Add Chris Nardi to contributors list
[WebKit-https.git] / Tools / ChangeLog
1 2018-01-24  Chris Nardi  <cnardi@chromium.org>
2
3         Add Chris Nardi to contributors list
4         https://bugs.webkit.org/show_bug.cgi?id=182029
5
6         Reviewed by Antti Koivisto.
7
8         * Scripts/webkitpy/common/config/contributors.json:
9
10 2018-01-22  Ryosuke Niwa  <rniwa@webkit.org>
11
12         Mac Sierra perf bots have been failing due to CG errors
13         https://bugs.webkit.org/show_bug.cgi?id=181955
14
15         Reviewed by Antti Koivisto.
16
17         Ignore the CoreGraphics error messages on macOS Sierra.
18
19         Also added tests for ignoring lines in stdout and stderr.
20
21         * Scripts/webkitpy/performance_tests/perftest.py:
22         (PerfTest.run_failed): Refactored for clarity.
23         (PerfTest):
24         (PerfTest.filter_ignored_lines): Added.
25         (PerfTest._lines_to_ignore): Renamed from _lines_to_ignore_in_parser_result since these regular expressions
26         are now used to ignore lines in other kinds of tests than parser tests.
27         (PerfTest._errors_to_ignore_in_sierra): Added.
28         (PerfTest._filter_output): Added the code to ignore errors only on macOS Sierra.
29         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
30         (test_parse_output_with_ignored_stdout): Added.
31         (test_parse_output_with_ignored_stderr): Added.
32         (test_parse_output_with_ignored_stderr.MockPortWithSierraName): Added.
33
34 2018-01-23  Eric Carlson  <eric.carlson@apple.com>
35
36         Resign NowPlaying status when no media element is eligible
37         https://bugs.webkit.org/show_bug.cgi?id=181914
38         <rdar://problem/35294116>
39
40         Reviewed by Jer Noble.
41
42         * TestWebKitAPI/Tests/WebKitCocoa/NowPlayingControlsTests.mm:
43         (-[NowPlayingTestWebView hasActiveNowPlayingSession]):
44         (TestWebKitAPI::TEST):
45         * TestWebKitAPI/Tests/WebKitCocoa/large-video-test-now-playing.html:
46
47 2018-01-23  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
48
49         [WinCairo] Use 64-bit toolset
50         https://bugs.webkit.org/show_bug.cgi?id=181979
51
52         Reviewed by Alex Christensen.
53
54         Use 64-bit toolset for 64-bit build in order to improve build time. 
55
56         * Scripts/webkitdirs.pm:
57         (generateBuildSystemFromCMakeProject):
58
59 2018-01-23  Simon Fraser  <simon.fraser@apple.com>
60
61         Element with position:fixed stops scrolling at the bottom of the page, but is painted in the right place on Chacos.com.
62         https://bugs.webkit.org/show_bug.cgi?id=181741
63         rdar://problem/36593581
64
65         Reviewed by Tim Horton.
66         
67         If zoomToScale:animated: is called with the current zoom level, call the callback
68         rather than doing nothing.
69
70         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
71         (-[TestRunnerWKWebView zoomToScale:animated:completionHandler:]):
72
73 2018-01-23  Basuke Suzuki  <Basuke.Suzuki@sony.com>
74
75         Add ignore_errors keyword argument to Executive.run_command() for replacing the common pattern of error_handler usage
76         https://bugs.webkit.org/show_bug.cgi?id=180820
77
78         Reviewed by David Kilzer.
79
80         * Scripts/webkitpy/common/checkout/scm/git.py:
81         (Git.in_working_directory):
82         (Git.clone):
83         (Git.read_git_config):
84         (Git.apply_reverse_diff):
85         * Scripts/webkitpy/common/checkout/scm/scm.py:
86         (SCM.run):
87         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
88         * Scripts/webkitpy/common/checkout/scm/svn.py:
89         (SVNRepository.has_authorization_for_realm):
90         * Scripts/webkitpy/common/net/credentials_unittest.py:
91         * Scripts/webkitpy/common/system/abstractexecutive.py:
92         (AbstractExecutive.run_command):
93         * Scripts/webkitpy/common/system/executive.py:
94         (Executive.kill_process.is):
95         (Executive.running_pids):
96         (Executive.kill_all):
97         (Executive.run_command):
98         * Scripts/webkitpy/common/system/executive_mock.py:
99         (MockExecutive.run_command):
100         (MockExecutive2.run_command):
101         * Scripts/webkitpy/common/system/executive_unittest.py:
102         (ExecutiveTest.test_run_command_with_bad_command.run_bad_command):
103         * Scripts/webkitpy/common/system/platforminfo.py:
104         (PlatformInfo.xcode_sdk_version):
105         * Scripts/webkitpy/layout_tests/servers/http_server.py:
106         (Lighttpd._check_and_kill):
107         * Scripts/webkitpy/port/base.py:
108         (Port._symbols_string):
109         * Scripts/webkitpy/port/gtk.py:
110         (GtkPort.setup_environ_for_server):
111         * Scripts/webkitpy/port/win.py:
112         (WinPort._runtime_feature_list):
113         (WinPort.read_registry_value):
114         * Scripts/webkitpy/port/win_unittest.py:
115         (WinPortTest.test_runtime_feature_list):
116         * Scripts/webkitpy/tool/commands/analyzechangelog.py:
117         * Scripts/webkitpy/tool/commands/analyzechangelog_unittest.py:
118
119 2018-01-23  Commit Queue  <commit-queue@webkit.org>
120
121         Unreviewed, rolling out r227279 and r227373.
122         https://bugs.webkit.org/show_bug.cgi?id=181988
123
124         The LayoutTest crash fix introduced an API test failure.
125         (Requested by ryanhaddad on #webkit).
126
127         Reverted changesets:
128
129         "Resign NowPlaying status when no media element is eligible"
130         https://bugs.webkit.org/show_bug.cgi?id=181914
131         https://trac.webkit.org/changeset/227279
132
133         "Resign NowPlaying status when no media element is eligible"
134         https://bugs.webkit.org/show_bug.cgi?id=181914
135         https://trac.webkit.org/changeset/227373
136
137 2018-01-22  Carlos Garcia Campos  <cgarcia@igalia.com>
138
139         Unreviewed. Add test case for slow in test_expectations.py.
140
141         I forgot to also check slow tests in test_expectations.py unit tests.
142
143         * Scripts/webkitpy/common/test_expectations_unittest.py:
144         (assert_slow):
145         (test_build_type):
146         (test_slow):
147
148 2018-01-22  Carlos Garcia Campos  <cgarcia@igalia.com>
149
150         Unreviewed. Mark test WTF_Lock.ManyContendedShortSections as slow.
151
152         * TestWebKitAPI/glib/TestExpectations.json:
153
154 2018-01-22  Ryosuke Niwa  <rniwa@webkit.org>
155
156         Blob conversion and sanitization doesn't work with Microsoft Word for Mac 2011
157         https://bugs.webkit.org/show_bug.cgi?id=181616
158         <rdar://problem/36484908>
159
160         Reviewed by Wenson Hsieh.
161
162         Added tests to make sure we sanitize plain HTML, not just web archives,
163         when and only when custom pasteboard data is enabled.
164
165         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
166         * TestWebKitAPI/Tests/WebKitCocoa/PasteHTML.mm: Added.
167         (writeHTMLToPasteboard): Added.
168         (createWebViewWithCustomPasteboardDataSetting): Added.
169
170 2018-01-22  Alexey Proskuryakov  <ap@apple.com>
171
172         REGRESSION (r226485): Many new wasm leaks detected by the leaks bot
173         https://bugs.webkit.org/show_bug.cgi?id=181400
174         rdar://problem/36358768
175
176         Reviewed by JF Bastien.
177
178         * BuildSlaveSupport/build.webkit.org-config/config.json: Disable poisoning on the leaks bot.
179
180 2018-01-22  Carlos Garcia Campos  <cgarcia@igalia.com>
181
182         [GTK] Test /webkit/WebKitWebsiteData/resource-load-statistics is failing since r227223
183         https://bugs.webkit.org/show_bug.cgi?id=181929
184
185         Reviewed by Michael Catanzaro.
186
187         The test is checking that the resource load stats file is deleted after clearing website data. Since r227223,
188         the website data completion callback is not called immediately, and a new file is created when the operation
189         finishes. We need to check that the file was removing after calling clear.
190
191         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
192         (fileChangedCallback):
193         (testWebsiteDataResourceLoadStatistics):
194
195 2018-01-22  Carlos Garcia Campos  <cgarcia@igalia.com>
196
197         Reviewed GTK gardening. Mark /webkit/WebKitWebView/mouse-target as fail too.
198
199         * TestWebKitAPI/glib/TestExpectations.json:
200
201 2018-01-22  Carlos Garcia Campos  <cgarcia@igalia.com>
202
203         Unreviewed GTK+ gardening. Fix /webkit/WebKitConsoleMessage/network-error.
204
205         Partially revert r226782, the fix was wrong for the GLib version we currently use.
206
207         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
208         (testWebKitConsoleMessageNetworkError):
209
210 2018-01-21  Carlos Garcia Campos  <cgarcia@igalia.com>
211
212         Unreviewed. Remove unused verbose mode from GLib API tests runner.
213
214         * glib/api_test_runner.py:
215         (add_options):
216
217 2018-01-21  Wenson Hsieh  <wenson_hsieh@apple.com>
218
219         Add a new feature flag for EXTRA_ZOOM_MODE and reintroduce AdditionalFeatureDefines.h
220         https://bugs.webkit.org/show_bug.cgi?id=181918
221
222         Reviewed by Tim Horton.
223
224         Add EXTRA_ZOOM_MODE to FeatureDefines.xconfig (off by default).
225
226         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
227
228 2018-01-21  Eric Carlson  <eric.carlson@apple.com>
229
230         Resign NowPlaying status when no media element is eligible
231         https://bugs.webkit.org/show_bug.cgi?id=181914
232         <rdar://problem/35294116>
233
234         Reviewed by Jer Noble.
235
236         * TestWebKitAPI/Tests/WebKitCocoa/NowPlayingControlsTests.mm:
237         (-[NowPlayingTestWebView hasActiveNowPlayingSession]):
238         (TestWebKitAPI::TEST):
239         * TestWebKitAPI/Tests/WebKitCocoa/large-video-test-now-playing.html:
240
241 2018-01-21  Aakash Jain  <aakash_jain@apple.com>
242
243         Fix broken unit-tests after r227192
244         https://bugs.webkit.org/show_bug.cgi?id=181909
245
246         Reviewed by Carlos Garcia Campos.
247
248         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
249
250 2018-01-20  Chris Dumez  <cdumez@apple.com>
251
252         API test URLSchemeHandler.Leaks1 is timing out on iOS simulator debug
253         https://bugs.webkit.org/show_bug.cgi?id=174984
254         <rdar://problem/33665676>
255
256         Reviewed by Alexey Proskuryakov.
257
258         Disable URLSchemeHandler.Leaks1 API test on iOS as it sometimes times out.
259
260         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-leaks.mm:
261         (TEST):
262
263 2018-01-20  Brian Burg  <bburg@apple.com>
264
265         WebDriver: fix some nits that prevent running W3C tests on Mac
266         https://bugs.webkit.org/show_bug.cgi?id=181864
267
268         Reviewed by Carlos Garcia Campos.
269
270         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_web_server.py:
271         (WebDriverW3CWebServer.__init__): _wsout needs to always be defined,
272         as we assume that the property exists later.
273
274         (WebDriverW3CWebServer.stop): If the temporary file doesn't
275         exist for some reason, the remove call will raise and exception.
276         Gracefully handle the case where the file isn't created due to
277         a problem/exception that happened elsewhere.
278
279 2018-01-19  Ling Ho  <lingcherd_ho@apple.com>
280
281         Move Bingdings EWS and Webkitpy EWS queues to High Sierra on buildbot dashboard.
282         https://bugs.webkit.org/show_bug.cgi?id=181881
283
284         Reviewed by Alexey Proskuryakov.
285
286         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
287         (BubbleQueueServer):
288         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
289         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
290         (table.queue-grid tr.platform.mac-os-x-elcapitan img.logo): Deleted.
291
292 2018-01-19  Youenn Fablet  <youenn@apple.com>
293
294         Do not go to the storage process when registering a service worker client if there is no service worker registered
295         https://bugs.webkit.org/show_bug.cgi?id=181740
296         <rdar://problem/36650400>
297
298         Reviewed by Chris Dumez.
299
300         Add support for internals inside API tests.
301
302         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
303         * TestWebKitAPI/Tests/InjectInternals_Bundle.cpp: Added.
304         (TestWebKitAPI::InternalsInjectedBundleTest::InternalsInjectedBundleTest):
305         (TestWebKitAPI::InternalsInjectedBundleTest::initialize):
306         (TestWebKitAPI::InternalsInjectedBundleTest::didCreatePage):
307         (TestWebKitAPI::InternalsInjectedBundleTest::didClearWindowForFrame):
308         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
309         (setConfigurationInjectedBundlePath):
310         (-[RegularPageMessageHandler userContentController:didReceiveScriptMessage:]):
311
312 2018-01-19  John Wilander  <wilander@apple.com>
313
314         Resource Load Statistics: Implement callback support for removal of WebsiteDataType::ResourceLoadStatistics
315         https://bugs.webkit.org/show_bug.cgi?id=181822
316         https://bugs.webkit.org/show_bug.cgi?id=175263
317         https://bugs.webkit.org/show_bug.cgi?id=178536
318         https://bugs.webkit.org/show_bug.cgi?id=181223
319         https://bugs.webkit.org/show_bug.cgi?id=181482
320         <rdar://problem/33491222>
321         <rdar://problem/33805293>
322         <rdar://problem/36332683>
323         <rdar://problem/36549026>
324
325         Reviewed by Alex Christensen.
326
327         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
328         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
329         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
330         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
331         * WebKitTestRunner/InjectedBundle/TestRunner.h:
332         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
333         (WTR::TestController::statisticsClearInMemoryAndPersistentStore):
334         (WTR::TestController::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
335
336 2018-01-19  Jonathan Bedard  <jbedard@apple.com>
337
338         run-webkit-tests fails when there is a curly brace in Xcode build output
339         https://bugs.webkit.org/show_bug.cgi?id=181254
340         <rdar://problem/36453374>
341
342         Reviewed by Daniel Bates.
343
344         * Scripts/webkitpy/port/base.py:
345         (Port._run_script): Encode script output before logging it.
346
347 2018-01-19  Chris Dumez  <cdumez@apple.com>
348
349         Service worker registrations restored from disk may not be reused when the JS calls register() again
350         https://bugs.webkit.org/show_bug.cgi?id=181810
351         <rdar://problem/36591711>
352
353         Reviewed by Youenn Fablet.
354
355         Add API test coverage.
356
357         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
358         (-[SWMessageHandlerForRestoreFromDiskTest initWithExpectedMessage:]):
359         (-[SWMessageHandlerForRestoreFromDiskTest userContentController:didReceiveScriptMessage:]):
360
361 2018-01-19  Ryan Haddad  <ryanhaddad@apple.com>
362
363         Remove El Capitan queues from flakiness dashboard
364         https://bugs.webkit.org/show_bug.cgi?id=181860
365
366         Reviewed by Aakash Jain.
367
368         * TestResultServer/static-dashboards/builders.jsonp:
369
370 2018-01-19  Keith Miller  <keith_miller@apple.com>
371
372         HaveInternalSDK includes should be "#include?"
373         https://bugs.webkit.org/show_bug.cgi?id=179670
374
375         Reviewed by Dan Bernstein.
376
377         * MiniBrowser/Configurations/Base.xcconfig:
378         * MobileMiniBrowser/Configurations/Base.xcconfig:
379         * TestWebKitAPI/Configurations/Base.xcconfig:
380         * WebKitTestRunner/Configurations/Base.xcconfig:
381
382 2018-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
383
384         WebDriver: driver environment not passed to pytest when running w3c tests
385         https://bugs.webkit.org/show_bug.cgi?id=181852
386
387         Reviewed by Carlos Alberto Lopez Perez.
388
389         That's why color codes are not used in the bots log for selenium tests but they appear in w3c tests.
390
391         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:
392         (WebDriverW3CExecutor.run):
393
394 2018-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
395
396         [GTK] WebDriver: wayland display no used in wayland bot
397         https://bugs.webkit.org/show_bug.cgi?id=181851
398
399         Reviewed by Carlos Alberto Lopez Perez.
400
401         We need to handle the additionalArguments property in the WebDriverTests step.
402
403         * BuildSlaveSupport/build.webkit.org-config/steps.py:
404         (RunWebDriverTests.start):
405
406 2018-01-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
407
408         [GTK] TERM environment variable is not passed to the test driver.
409         https://bugs.webkit.org/show_bug.cgi?id=181847
410
411         Rubber-stamped by by Carlos Garcia Campos.
412
413         * Scripts/webkitpy/port/base.py:
414         (Port.to.setup_environ_for_server):
415
416 2018-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
417
418         WebDriver: run-webdriver-tests is crashing in the bots when creating results json file
419         https://bugs.webkit.org/show_bug.cgi?id=181844
420
421         Reviewed by Carlos Alberto Lopez Perez.
422
423         We always try to create the directory where to store the json file, but when the filename is given directly,
424         like in the bots, the current dir is used.
425
426         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
427         (WebDriverTestRunner.dump_results_to_json_file): Do not try to create the directory if dirname() returns an
428         empty string.
429
430 2018-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
431
432         [GTK] WebDriver tests are running outside the jhbuild env
433         https://bugs.webkit.org/show_bug.cgi?id=181842
434
435         Reviewed by Žan Doberšek.
436
437         We need to enter jhbuild env in run-webdriver-tests.
438
439         * Scripts/run-webdriver-tests:
440
441 2018-01-18  Carlos Garcia Campos  <cgarcia@igalia.com>
442
443         [GTK] Run WebDriver tests in the bots
444         https://bugs.webkit.org/show_bug.cgi?id=181787
445
446         Reviewed by Michael Catanzaro.
447
448         Add a step to run WebDriver tests in the GTK test bots. The new step is not GTK specific, but only added to the
449         factory for the GTK port for now.
450
451         * BuildSlaveSupport/build.webkit.org-config/factories.py:
452         (TestFactory.__init__):
453         * BuildSlaveSupport/build.webkit.org-config/steps.py:
454         (RunWebDriverTests):
455         (RunWebDriverTests.start):
456         (RunWebDriverTests.commandComplete):
457         (RunWebDriverTests.evaluateCommand):
458         (RunWebDriverTests.getText):
459         (RunWebDriverTests.getText2):
460
461 2018-01-18  Basuke Suzuki  <Basuke.Suzuki@sony.com>
462
463         [WinCairo] Pass correct url for http test to test driver.
464         https://bugs.webkit.org/show_bug.cgi?id=181814
465
466         Reviewed by Alex Christensen.
467
468         * Scripts/webkitpy/port/driver.py:
469         (Driver):
470         (Driver.http_test_path_to_uri):
471         (Driver.is_secure_path):
472         (Driver.http_base_url):
473         (Driver.uri_to_test):
474
475 2018-01-18  Ryan Haddad  <ryanhaddad@apple.com>
476
477         Unreviewed, update the triggerable name for 'sierra-release-perf-tests'
478
479         * BuildSlaveSupport/build.webkit.org-config/config.json:
480
481 2018-01-18  Dan Bernstein  <mitz@apple.com>
482
483         [Xcode] Streamline and future-proof target-macOS-version-dependent build setting definitions
484         https://bugs.webkit.org/show_bug.cgi?id=181803
485
486         Reviewed by Tim Horton.
487
488         * DumpRenderTree/mac/Configurations/Base.xcconfig: Updated.
489         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Ditto.
490         * ImageDiff/cg/Configurations/Base.xcconfig: Ditto.
491         * ImageDiff/cg/Configurations/DebugRelease.xcconfig: Ditto.
492         * MiniBrowser/Configurations/Base.xcconfig: Ditto.
493         * MiniBrowser/Configurations/DebugRelease.xcconfig: Ditto.
494         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
495         * TestWebKitAPI/Configurations/DebugRelease.xcconfig: Ditto.
496         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Adopted macOSTargetConditionals
497           helpers.
498         * TestWebKitAPI/Configurations/macOSTargetConditionals.xcconfig: Added. Defines helper build
499           settings useful for defining settings that depend on the target macOS version.
500         * WebKitTestRunner/Configurations/Base.xcconfig: Updated.
501         * WebKitTestRunner/Configurations/DebugRelease.xcconfig: Updated.
502
503 2018-01-18  Ling Ho  <lingcherd_ho@apple.com>
504
505         Remove Opensource El Capitan queues from buildbot
506         https://bugs.webkit.org/show_bug.cgi?id=181712
507
508         Reviewed by Aakash Jain.
509
510         * BuildSlaveSupport/build.webkit.org-config/config.json:
511         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
512         (WebKitBuildbot):
513         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
514
515 2018-01-18  Chris Dumez  <cdumez@apple.com>
516
517         Service Workers restored from persistent storage have 'redundant' state
518         https://bugs.webkit.org/show_bug.cgi?id=181749
519         <rdar://problem/36556486>
520
521         Reviewed by Youenn Fablet.
522
523         Add API test coverage.
524
525         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
526         (-[SWMessageHandlerForFetchTest userContentController:didReceiveScriptMessage:]):
527
528 2018-01-18  Joanmarie Diggs  <jdiggs@igalia.com>
529
530         [GTK] AX: Two layout tests crash with error 'g_strstr_len: assertion 'haystack != NULL' failed' in Accessibility::UIElement::url
531         https://bugs.webkit.org/show_bug.cgi?id=176796
532
533         Reviewed by Chris Fleizach.
534
535         Add sanity check that we have a URL before calling g_strstr_len().
536
537         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
538         (WTR::AccessibilityUIElement::url):
539
540 2018-01-18  Ryan Haddad  <ryanhaddad@apple.com>
541
542         Add triggers for Sierra test262 and perf queues
543         https://bugs.webkit.org/show_bug.cgi?id=181799
544
545         Reviewed by Aakash Jain.
546
547         * BuildSlaveSupport/build.webkit.org-config/config.json:
548
549 2018-01-18  Wenson Hsieh  <wenson_hsieh@apple.com>
550
551         [iOS] Specify -[NSURL _title] for the associated URL when copying an image element
552         https://bugs.webkit.org/show_bug.cgi?id=181783
553         <rdar://problem/35785445>
554
555         Reviewed by Ryosuke Niwa.
556
557         Augments an existing API test and adds a new test to make sure that the resulting NSItemProvider's NSURL when
558         copying an image contains a relevant title.
559
560         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
561         (TestWebKitAPI::TEST):
562         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
563         * TestWebKitAPI/ios/UIKitSPI.h:
564
565 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
566
567         WebDriver: ignore the driver in selenium test names when getting expectations
568         https://bugs.webkit.org/show_bug.cgi?id=181738
569
570         Reviewed by Carlos Alberto Lopez Perez.
571
572         In selenium tests, the driver is added as a parameter to every test which results in tests names like
573         foo[DriverName] or foo[DriverName-param2] in case of tests using more parameters. We don't want to include the
574         driver name in the test expectations file, so we need to remove it when querying the expectations.
575
576         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
577         (TestExpectationsMarker.__init__): Save the param to ignore.
578         (TestExpectationsMarker._item_name): Return the name of the test without the para to ignore.
579         (TestExpectationsMarker.pytest_collection_modifyitems): Use _item_name().
580         (run): Pass param to ignore to TestExpectationsMarker().
581         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
582         (WebDriverSeleniumExecutor.__init__): Save the driver name.
583         (WebDriverSeleniumExecutor.run): Pass the driver name as param to ignore.
584
585 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
586
587         [GTK][WPE] Show unit tests unexpectedly passing in the bots
588         https://bugs.webkit.org/show_bug.cgi?id=181726
589
590         Reviewed by Michael Catanzaro.
591
592         Now that we have the info, let's show it also in the bots.
593
594         * BuildSlaveSupport/build.webkit.org-config/steps.py:
595         (RunGLibAPITests.commandComplete):
596
597 2018-01-17  Ling Ho  <lingcherd_ho@apple.com>
598
599         Fix broken unittest after r227048
600         https://bugs.webkit.org/show_bug.cgi?id=181760
601
602         Reviewed by Aakash Jain.
603
604
605 2018-01-17  Michael Catanzaro  <mcatanzaro@igalia.com>
606
607         WEBKIT_FRAMEWORK should not modify file-global include directories
608         https://bugs.webkit.org/show_bug.cgi?id=181656
609
610         Reviewed by Konstantin Tokarev.
611
612         * TestWebKitAPI/PlatformWPE.cmake:
613         * TestWebKitAPI/glib/CMakeLists.txt:
614
615 2018-01-17  Alicia Boya García  <aboya@igalia.com>
616
617         Unreviewed, mark Alicia as committer in contributors.json
618
619         * Scripts/webkitpy/common/config/contributors.json:
620
621 2018-01-17  Youenn Fablet  <youenn@apple.com>
622
623         Put fetch Request.keepalive behind a runtime flag
624         https://bugs.webkit.org/show_bug.cgi?id=181592
625
626         Reviewed by Chris Dumez.
627
628         * DumpRenderTree/mac/DumpRenderTree.mm:
629         (enableExperimentalFeatures):
630         * DumpRenderTree/win/DumpRenderTree.cpp:
631         (enableExperimentalFeatures):
632         * WebKitTestRunner/TestController.cpp:
633         (WTR::TestController::resetPreferencesToConsistentValues):
634
635 2018-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
636
637         Add injected bundle SPI to replace subresource URLs when dropping or pasting rich content
638         https://bugs.webkit.org/show_bug.cgi?id=181637
639         <rdar://problem/36508471>
640
641         Reviewed by Tim Horton.
642
643         Add 2 new API tests to exercise injected bundle SPI for supplying replacement URLs when pasting an image, and an
644         attributed string containing multiple NSTextAttachments. See WebKit and WebCore ChangeLogs for more detail.
645
646         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
647         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
648         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]):
649
650         Implement the new Objective-C bundle SPI to look up the incoming MIME type in the dictionary supplied via the
651         "MIMETypeToReplacementURLMap" bundle initialization parameter, and return it.
652
653         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
654         (webViewForTestingAttachments):
655         (-[TestWKWebView tagsInBody]):
656         (-[TestWKWebView expectElementTagsInOrder:]):
657         (-[TestWKWebView expectElementTag:toComeBefore:]):
658
659         Add a test helper to check that the given list of element tags appears in the document body. Also, reimplement
660         the existing -expectElementTag:toComeBefore: as a special case of -expectElementTagsInOrder:.
661
662         (TestWebKitAPI::TEST):
663         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
664         (WTR::InjectedBundlePage::InjectedBundlePage):
665
666 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
667
668         WebDriver: add support for test expectations
669         https://bugs.webkit.org/show_bug.cgi?id=180420
670
671         Reviewed by Carlos Alberto Lopez Perez.
672
673         Add support for parsing test expectations from a JSON file and mark tests on collection accordingly.
674
675         * Scripts/run-webdriver-tests: Get the retval from process_results().
676         * Scripts/webkitpy/thirdparty/__init__.py:
677         (AutoinstallImportHook._install_pytest): Install also py because pytest needs it.
678         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
679         (TestExpectationsMarker): Plugin to mark tests based on given expectations.
680         (TestExpectationsMarker.__init__): Initialize expectations.
681         (TestExpectationsMarker.pytest_collection_modifyitems): Mark tests if needed,
682         (run): Create and use TestExpectationsMarker plugin.
683         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
684         (WebDriverSeleniumExecutor.run): Pass expectations to pytest_runner.
685         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
686         (WebDriverTestRunner.__init__): Create a TestExpectations and pass it to the runners.
687         (WebDriverTestRunner.run): Do not count results here.
688         (WebDriverTestRunner.process_results): Rename print_results() as process_results() since it now returns the
689         amount of failures. Printing the test summary while processing results will be made optional in a follow up
690         patch.
691         (WebDriverTestRunner.process_results.report): Return the amount of failures.
692         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
693         (WebDriverTestRunnerSelenium.__init__): Initialize _expectations.
694         (WebDriverTestRunnerSelenium.collect_tests): Do not include skipped tests.
695         (WebDriverTestRunnerSelenium.run): Stop returning the tests count.
696         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
697         (WebDriverTestRunnerW3C.__init__): Initialize _expectations.
698         (WebDriverTestRunnerW3C.collect_tests): Do not include skipped tests.
699         (WebDriverTestRunnerW3C._scan_directory): Ditto.
700         (WebDriverTestRunnerW3C.run): Stop returning the tests count.
701         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:
702         (WebDriverW3CExecutor.run): Pass expectations to pytest_runner.
703
704 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
705
706         Unreviewed WPE gardening. Mark some known unit test failures.
707
708         * TestWebKitAPI/glib/TestExpectations.json:
709
710 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
711
712         [GTK][WPE] Use the same subtest names in GTK and WPE unit tests
713         https://bugs.webkit.org/show_bug.cgi?id=181724
714
715         Reviewed by Philippe Normand.
716
717         We currently use /webkit2/foo/bar for GTK and /wpe/foo/bar for WPE. Many of the tests are common, so there's no
718         reason to use different names. This way we can refer to the same test names for both and we can share the
719         expectations in the TestExpectations.json file.
720
721         * TestWebKitAPI/glib/TestExpectations.json:
722         * TestWebKitAPI/glib/WebKitGLib/TestMain.h: Use /webkit/foo/bar in GTK and WPE.
723
724 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
725
726         Unreviewed. Increase the slow timeout of GTK and WPE unit tests.
727
728         We are using now a lower default timeout, so multiplying by 5 is no longer enough for some of the WTF
729         tests. Multiply by 10 so that we get the same slow timeout as before, 50.
730
731         * glib/api_test_runner.py:
732         (TestRunner._run_test_glib):
733         (TestRunner._run_google_test):
734
735 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
736
737         [GTK] Duplicated symbols in libjavascriptcoregtk and libwebkit2gtk can cause crashes in production builds
738         https://bugs.webkit.org/show_bug.cgi?id=179914
739
740         Reviewed by Žan Doberšek.
741
742         Add two scripts to be run by dist-check step when releasing. One is to detect symbols duplicated in
743         libjavascriptcoregtk and libwebkit2gtk that should be included to the version script. The other one is to ensure
744         all symbols listed in the script are present in the library.
745
746         * Scripts/check-for-global-bss-symbols-in-webkigtk-libs: Added.
747         (bss_symbols):
748         * Scripts/check-for-invalid-symbols-in-version-script: Added.
749         (script_symbols):
750         * Scripts/make-dist:
751         (Distcheck.build):
752         (Distcheck):
753         (Distcheck.check_symbols):
754         (Distcheck.check):
755
756 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
757
758         [GTK][WPE] Propagate the parameters when restarting glib api tests after a crash
759         https://bugs.webkit.org/show_bug.cgi?id=181722
760
761         Reviewed by Žan Doberšek.
762
763         I forgot to pass the parameters to run() when restarting.
764
765         * glib/glib_test_runner.py:
766         (GLibTestRunner.run):
767
768 2018-01-16  Fujii Hironori  <Hironori.Fujii@sony.com>
769
770         [CMake] Remove WebCoreDerivedSources library target
771         https://bugs.webkit.org/show_bug.cgi?id=181664
772
773         Reviewed by Carlos Garcia Campos.
774
775         * TestWebKitAPI/PlatformWPE.cmake: Do not link WebCoreDerivedSources.
776         * TestWebKitAPI/PlatformWin.cmake: Ditto.
777
778 2018-01-16  Ling Ho  <lingcherd_ho@apple.com>
779
780         Move Debug Test262, Release Test262 and Performance queues to Sierra
781         https://bugs.webkit.org/show_bug.cgi?id=181692
782
783         Unreviewed
784
785 2018-01-16  Zach Li  <zachli@apple.com>
786
787         Add pop-up policy support in website policies.
788         https://bugs.webkit.org/show_bug.cgi?id=181544.
789         rdar://problem/30521400.
790
791         Reviewed by Alex Christensen.
792
793         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
794         Added pop-up-check.html.
795
796         * TestWebKitAPI/Tests/WebKit/pop-up-check.html: Added.
797
798         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
799         (-[PopUpPoliciesDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
800         (-[PopUpPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
801         (-[PopUpPoliciesDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
802         (TEST):
803
804 2018-01-16  Wenson Hsieh  <wenson_hsieh@apple.com>
805
806         [Attachment Support] Provide the `src` of an attachment to the UI delegate when an attachment is inserted
807         https://bugs.webkit.org/show_bug.cgi?id=181638
808         <rdar://problem/36508702>
809
810         Reviewed by Dan Bernstein.
811
812         Tweak an existing API test to check that the `src` of an attachment element inserted via script matches the
813         `source` provided to the UI delegate via -[WKUIDelegate _webView:didInsertAttachment:withSource:].
814
815         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
816         (-[AttachmentUpdateObserver init]):
817         (-[AttachmentUpdateObserver sourceForIdentifier:]):
818         (-[AttachmentUpdateObserver _webView:didInsertAttachment:withSource:]):
819         (TestWebKitAPI::ObserveAttachmentUpdatesForScope::expectSourceForIdentifier):
820         (TestWebKitAPI::TEST):
821         (-[AttachmentUpdateObserver _webView:didInsertAttachment:]): Deleted.
822
823 2018-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
824
825         Unreviewed. Fix GTK unit tests execution in the bots after r226967.
826
827         I forgot to pass the environment to the GLibTestRunner and Xvfb was not used in the bots.
828
829         * glib/api_test_runner.py:
830         (TestRunner._run_test_glib): Pass env to GLibTestRunner.
831         * glib/glib_test_runner.py:
832         (GLibTestRunner.run): Use given env.
833
834 2018-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
835
836         [GTK][WPE] Stop passing --verbose to run-api-tests from the bots
837         https://bugs.webkit.org/show_bug.cgi?id=181676
838
839         Reviewed by Carlos Alberto Lopez Perez.
840
841         The option was removed in r226967.
842
843         * BuildSlaveSupport/build.webkit.org-config/steps.py:
844         (RunGtkAPITests):
845         (RunWPEAPITests):
846
847 2018-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
848
849         Unreviewed. Temporarily bring back --verbose option of api_test_runner.py.
850
851         The bots are still passing that option and the step is failing because it was removed in r226967.
852
853         * glib/api_test_runner.py:
854         (add_options):
855
856 2018-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
857
858         [GTK][WPE] Improve the way glib tests are run
859         https://bugs.webkit.org/show_bug.cgi?id=181674
860
861         Reviewed by Žan Doberšek.
862
863         Stop using gtester external program and use our own tester from python directly. This way we no longer need to
864         parse the tests output to get the results which is causing problems in WPE bot. We can now differentiate between
865         tests failing due to an expected assert in the test and unexpected crashes.
866         This also fixes a bug in previous code where we failed to properly detect tests timing out, because gtester was
867         not showing the subtest name in stdout in case of timeouts.
868         I've lowered the default timeout from 10 to 5, since we are now properly handling the timeout for every test
869         case. I've also removed the verbose option, since it was only used by gtester and we now always show the result
870         of every test case.
871
872         * glib/api_test_runner.py:
873         (TestRunner._run_test_glib): Use GLibTestRunner.
874         (TestRunner._run_google_test): Wrote tests timing out to stdout too.
875         (add_options):
876         * glib/glib_test_runner.py: Added.
877         (TestTimeout):
878         (Message):
879         (Message.__init__):
880         (Message.create):
881         (Message.create.read_unsigned):
882         (Message.create.read_double):
883         (Message.create.read_string):
884         (GLibTestRunner):
885         (GLibTestRunner.__init__):
886         (GLibTestRunner._process_data):
887         (GLibTestRunner._process_message):
888         (GLibTestRunner._read_from_pipe):
889         (GLibTestRunner._read_from_stderr):
890         (GLibTestRunner._start_timeout):
891         (GLibTestRunner._start_timeout._alarm_handler):
892         (GLibTestRunner._stop_timeout):
893         (GLibTestRunner._subtest_start):
894         (GLibTestRunner._subtest_message):
895         (GLibTestRunner._subtest_stderr):
896         (GLibTestRunner._subtest_end):
897         (GLibTestRunner.run):
898
899 2018-01-15  Michael Catanzaro  <mcatanzaro@igalia.com>
900
901         Unreviewed, add Thibault to contributors.json
902
903         It's a bit weird to add someone here before their first contribution, but this affects
904         Bugzilla autocomplete, and that is serious business.
905
906         * Scripts/webkitpy/common/config/contributors.json:
907
908 2018-01-15  JF Bastien  <jfbastien@apple.com>
909
910         Remove makePoisonedUnique
911         https://bugs.webkit.org/show_bug.cgi?id=181630
912         <rdar://problem/36498623>
913
914         Reviewed by Mark Lam.
915
916         Update tests.
917
918         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
919         (TestWebKitAPI::TEST):
920         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp:
921         (TestWebKitAPI::TEST):
922
923 2018-01-15  Adrian Perez de Castro  <aperez@igalia.com>
924
925         [GTK][JHBuild] Tools/gtk/install-dependencies: Package libxfont does not exist anymore in Arch Linux
926         https://bugs.webkit.org/show_bug.cgi?id=181476
927
928         Reviewed by Michael Catanzaro.
929
930         Update to xorg-server 1.19.6 which depends on libxfont2, and change
931         the lists of packages to install libxfont2-devel (or equivalent).
932
933         * gtk/install-dependencies:
934         * gtk/jhbuild.modules:
935
936 2018-01-15  Carlos Garcia Campos  <cgarcia@igalia.com>
937
938         [GTK][WPE] Add support for unit test expectations
939         https://bugs.webkit.org/show_bug.cgi?id=181589
940
941         Reviewed by Michael Catanzaro.
942
943         We currently have a way to skip tests by annotating them in the api test runner script. The main problem of this
944         approach is that we skip tests when they fail in the bots and we never notice if they stop failing, keeping the
945         tests skipped forever. This is indeed the case of several WebKit2 C API tests. Annotating skipped tests in the
946         script itself is not a good idea either.
947
948         This patch adds a generic TestExpectations class for simple tests based on tests with subtests, like our unit
949         tests, but also WebDriver tests. It parses a json file with the tests and subtests expectations and provides
950         convenient methods to query them.
951
952         * Scripts/run-gtk-tests:
953         (GtkTestRunner): Remove all Skipped and Slow tests marked here.
954         * Scripts/run-wpe-tests:
955         (WPETestRunner): Ditto.
956         * Scripts/webkitpy/common/test_expectations.py: Added.
957         (TestExpectations):
958         (TestExpectations.__init__):
959         (TestExpectations._port_name_for_expected):
960         (TestExpectations._expected_value):
961         (TestExpectations.skipped_tests):
962         (TestExpectations.skipped_subtests):
963         (TestExpectations._expectation_value):
964         (TestExpectations.is_slow):
965         (TestExpectations.get_expectation):
966         * Scripts/webkitpy/common/test_expectations_unittest.py: Added.
967         (MockTestExpectations):
968         (MockTestExpectations.__init__):
969         (MockTestExpectations.is_skip):
970         (ExpectationsTest):
971         (assert_exp):
972         (assert_not_exp):
973         (assert_bad_exp):
974         (assert_skip):
975         (test_basic):
976         (test_skip):
977         (test_flaky):
978         (test_build_type):
979         * TestWebKitAPI/glib/TestExpectations.json: Added.
980         * glib/api_test_runner.py:
981         (TestRunner): Remove SkippedTest implementation.
982         (TestRunner.__init__): Create a TestExpectations.
983         (TestRunner._test_cases_to_skip): Use TestExpectations to check skipped tests.
984         (TestRunner._should_run_test_program): Ditto.
985         (TestRunner._run_test_glib): Use TestExpectations to check if test suite is slow.
986         (TestRunner._run_test_glib.parse_line.set_test_result): Register also tests passing.
987         (TestRunner._run_google_test): Use TestExpectations to check if test cases is slow and register tests passing.
988         (TestRunner.run_tests): Check if actual result is the expected one and register also unexpected passes.
989         (TestRunner.run_tests.report): Helper to write report to stdout.
990
991 2018-01-13  Mark Lam  <mark.lam@apple.com>
992
993         Replace all use of ConstExprPoisoned with Poisoned.
994         https://bugs.webkit.org/show_bug.cgi?id=181542
995         <rdar://problem/36442138>
996
997         Reviewed by JF Bastien.
998
999         1. Converted tests to using new uintptr_t& poison type.
1000         2. Added tests for Poisoned comparison operators.
1001
1002         * TestWebKitAPI/CMakeLists.txt:
1003         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1004         * TestWebKitAPI/Tests/WTF/ConstExprPoisoned.cpp: Removed.
1005         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
1006         (TestWebKitAPI::TEST):
1007         (TestWebKitAPI::initializeTestPoison): Deleted.
1008         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp:
1009         (TestWebKitAPI::TEST):
1010         (TestWebKitAPI::passWithRef):
1011         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp:
1012         (TestWebKitAPI::TEST):
1013         (TestWebKitAPI::f1):
1014         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
1015         (TestWebKitAPI::TEST):
1016         (TestWebKitAPI::poisonedPtrFoo):
1017         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp:
1018         (TestWebKitAPI::TEST):
1019         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp:
1020         (TestWebKitAPI::TEST):
1021
1022 2018-01-13  David Kilzer  <ddkilzer@apple.com>
1023
1024         check-webkit-style: false positive for [whitespace/braces] with os_log format string
1025         <https://webkit.org/b/181606>
1026
1027         Reviewed by Darin Adler.
1028
1029         * Scripts/webkitpy/style/checkers/cpp.py:
1030         (check_spacing): Modify regular expression to ignore
1031         os_log format strings like '%{public}'.
1032         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1033         (CppStyleTest.test_spacing_before_braces): Add os_log
1034         format string test.
1035
1036 2018-01-12  Wenson Hsieh  <wenson_hsieh@apple.com>
1037
1038         [macOS] API tests ChangeAttachmentDataUpdatesWithInPlaceDisplay and InPlaceVideoAttachmentInsertionWithinList are failing
1039         https://bugs.webkit.org/show_bug.cgi?id=181626
1040
1041         Reviewed by Joseph Pecoraro.
1042
1043         Make the web view for WKAttachmentTests slightly bigger to avoid size clamping behavior introduced in r226915.
1044         Additionally, write a new API test covering the change in r226915.
1045
1046         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1047         (webViewForTestingAttachments):
1048         (TestWebKitAPI::TEST):
1049
1050 2018-01-12  Alex Christensen  <achristensen@webkit.org>
1051
1052         History state should be updated during client redirects with asynchronous policy decisions
1053         https://bugs.webkit.org/show_bug.cgi?id=181358
1054         <rdar://problem/35547689>
1055
1056         Reviewed by Andy Estes.
1057
1058         * TestWebKitAPI/Tests/WebKit/WKBackForwardList.mm:
1059         (-[AsyncPolicyDecisionDelegate webView:didFinishNavigation:]):
1060         (-[AsyncPolicyDecisionDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1061         (TEST):
1062
1063 2018-01-12  Jonathan Bedard  <jbedard@apple.com>
1064
1065         webkitpy: Refactor simulator code (Part 4)
1066         https://bugs.webkit.org/show_bug.cgi?id=180555
1067         <rdar://problem/36131381>
1068
1069         Reviewed by Aakash Jain.
1070
1071         Move new_simulated_device.py to simulated_device.py.
1072
1073         * Scripts/webkitpy/port/ios_simulator.py: Update import statement.
1074         * Scripts/webkitpy/xcode/new_simulated_device.py: Removed.
1075         * Scripts/webkitpy/xcode/new_simulated_device_unittest.py: Removed.
1076         * Scripts/webkitpy/xcode/simulated_device.py: Copied from Tools/Scripts/webkitpy/xcode/new_simulated_device.py.
1077         * Scripts/webkitpy/xcode/simulated_device_unittest.py: Copied from Tools/Scripts/webkitpy/xcode/new_simulated_device_unittest.py.
1078
1079 2018-01-12  Alex Christensen  <achristensen@webkit.org>
1080
1081         REGRESSION (r226818): API test WebKitLegacy.LoadInvalidURLRequest is failing
1082         https://bugs.webkit.org/show_bug.cgi?id=181595
1083
1084         This test was testing behavior of an invalid URL that WebCore parses but NSURL does not.
1085         It was using example.com<> but after r226479 < and > are considered invalid by WebCore.
1086         I change the < and > to $ to make this test pass and continue to test what it used to.
1087
1088         * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.html:
1089         * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.mm:
1090         (-[LoadInvalidURLWebFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
1091
1092 2018-01-11  Keith Miller  <keith_miller@apple.com>
1093
1094         Rename ENABLE_ASYNC_ITERATION to ENABLE_JS_ASYNC_ITERATION
1095         https://bugs.webkit.org/show_bug.cgi?id=181573
1096
1097         Reviewed by Simon Fraser.
1098
1099         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1100
1101 2018-01-11  Jiewen Tan  <jiewen_tan@apple.com>
1102
1103         [WebAuthN] Import a CBOR coder from Chromium
1104         https://bugs.webkit.org/show_bug.cgi?id=181522
1105         <rdar://problem/36055729>
1106
1107         Reviewed by Brent Fulgham.
1108
1109         This patch also imports all unit tests into our API tests to ensure all
1110         workarounds and modification against the original codebase doesn't change
1111         any original functionalities.
1112
1113         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1114         * TestWebKitAPI/Tests/WebCore/CBORReaderTest.cpp: Added.
1115         (TestWebKitAPI::TEST):
1116         * TestWebKitAPI/Tests/WebCore/CBORValueTest.cpp: Added.
1117         (TestWebKitAPI::TEST):
1118         * TestWebKitAPI/Tests/WebCore/CBORWriterTest.cpp: Added.
1119         (TestWebKitAPI::eq):
1120         Workarounds applied.
1121         (TestWebKitAPI::TEST):
1122
1123 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
1124
1125         webkitpy: Use partially disambiguated type in SimulatedDeviceManager._disambiguate_device_type
1126         https://bugs.webkit.org/show_bug.cgi?id=181538
1127         <rdar://problem/36440580>
1128
1129         Reviewed by Aakash Jain.
1130
1131         When disambiguating a device type, it is possible that the provided device type is sufficiently
1132         ambiguous that the comparisons against complete device types without a disambiguated hardware_family
1133         will result in a failure to disambiguate the type.
1134
1135         * Scripts/webkitpy/xcode/new_simulated_device.py:
1136         (SimulatedDeviceManager._disambiguate_device_type):
1137
1138 2018-01-11  Brent Fulgham  <bfulgham@apple.com>
1139
1140         REGRESSION(r219530): ResourceLoadStatisticsPersistentStorage should be read-only in ephemeral sessions
1141         https://bugs.webkit.org/show_bug.cgi?id=181136
1142         <rdar://problem/36116604>
1143
1144         Reviewed by Chris Dumez.
1145
1146         Add a new API test to confirm that ResourceLoadStatistics can be turned on safely for ephemeral
1147         browsing sessions.
1148
1149         * Scripts/run-gtk-tests:
1150         (GtkTestRunner): Unskip test now that it passes.
1151         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1152         (TEST): Add new WebsiteDataStoreEphemeral test.
1153
1154 2018-01-11  Ryan Haddad  <ryanhaddad@apple.com>
1155
1156         Unreviewed, rolling out r226816.
1157
1158         This change broke LayoutTests on the bots.
1159
1160         Reverted changeset:
1161
1162         "run-webkit-tests fails when there is a curly brace in Xcode
1163         build output"
1164         https://bugs.webkit.org/show_bug.cgi?id=181254
1165         https://trac.webkit.org/changeset/226816
1166
1167 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
1168
1169         webkitpy: Fix flakey webserver tests
1170         https://bugs.webkit.org/show_bug.cgi?id=181555
1171         <rdar://problem/36448273>
1172
1173         Reviewed by Aakash Jain.
1174
1175         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
1176         (LayoutTestRunnerTests.test_servers_started): Add and bind custom checks to
1177         determine if a specific server is running.
1178
1179 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
1180
1181         Commit queue failed to land a bug, 'NoneType' object has no attribute 'strip'
1182         https://bugs.webkit.org/show_bug.cgi?id=181561
1183         <rdar://problem/36452652>
1184
1185         Reviewed by Aakash Jain.
1186
1187         BeautifulSoup.find may return None, this case should be gracefully handled.
1188
1189         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1190         (BugzillaQueries._parse_result_count):
1191         (BugzillaQueries._fetch_bugs_from_advanced_query): Added logging.
1192
1193 2018-01-11  Alexey Proskuryakov  <ap@apple.com>
1194
1195         run-webkit-tests fails when there is a curly brace in Xcode build output
1196         https://bugs.webkit.org/show_bug.cgi?id=181254
1197
1198         Reviewed by Daniel Bates.
1199
1200         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
1201         (MeteredStream.write):
1202
1203 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
1204
1205         webkitpy: Reimplement simulator code (Part 3)
1206         https://bugs.webkit.org/show_bug.cgi?id=180555
1207         <rdar://problem/36131381>
1208
1209         Reviewed by Aakash Jain.
1210
1211         Remove old simulator code.
1212
1213         * Scripts/webkitpy/xcode/__init__.py: Remove import statement.
1214         * Scripts/webkitpy/xcode/simulated_device.py: Removed.
1215         * Scripts/webkitpy/xcode/simulator.py: Removed.
1216         * Scripts/webkitpy/xcode/simulator_unittest.py: Removed.
1217
1218 2018-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1219
1220         [Attachment Support] Support moving attachment elements in editable areas using drag and drop
1221         https://bugs.webkit.org/show_bug.cgi?id=181337
1222         <rdar://problem/36324813>
1223
1224         Reviewed by Tim Horton.
1225
1226         Add 3 new API tests for attachment element dragging.
1227
1228         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1229         (-[TestWKWebView expectElementTag:toComeBefore:]):
1230         (-[NSItemProvider expectType:withData:]):
1231         (TestWebKitAPI::TEST):
1232
1233 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
1234
1235         REGRESSION(r225856): Incorrectly managing 'future' baseline_search_paths. 
1236         https://bugs.webkit.org/show_bug.cgi?id=179621
1237         <rdar://problem/35589585>
1238
1239         Unreviewed infrastructure fix.
1240
1241         * Scripts/webkitpy/port/mac.py:
1242         (MacPort.default_baseline_search_path): Include 'future' in the version_fallback
1243         list if we are the VERSION_MAX, which usually corresponds with future.
1244
1245 2018-01-11  Filip Pizlo  <fpizlo@apple.com>
1246
1247         CodeBlocks should be in IsoSubspaces
1248         https://bugs.webkit.org/show_bug.cgi?id=180884
1249
1250         Reviewed by Saam Barati.
1251         
1252         Remove some less important benchmarks from the default run. Doing run-jsc-benchmarks
1253         shouldn't take a long time due to benchmarks we don't optimize for.
1254         
1255         * Scripts/run-jsc-benchmarks:
1256
1257 2018-01-11  Ms2ger  <Ms2ger@igalia.com>
1258
1259         Test gardening for GTK.
1260         https://bugs.webkit.org/show_bug.cgi?id=181477
1261
1262         Unreviewed test gardening.
1263
1264         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp: Correct the file name.
1265         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp: Adjust the expected console message.
1266
1267 2018-01-11  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1268
1269         Add the new JSCOnly bot to the scheduler.
1270         https://bugs.webkit.org/show_bug.cgi?id=181487
1271
1272         Unreviewed follow-up patch after r226729
1273
1274         On r226729 I missed to add the new JSCOnly bot the default scheduler.
1275         This is needed to make the bot automatically pick each commit for testing.
1276
1277         * BuildSlaveSupport/build.webkit.org-config/config.json:
1278
1279 2018-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1280
1281         [Attachment Support] Support dragging attachment elements out as files on iOS
1282         https://bugs.webkit.org/show_bug.cgi?id=181199
1283         <rdar://problem/36299316>
1284
1285         Reviewed by Tim Horton, Andy Estes and Joseph Pecoraro.
1286
1287         Add support in the drag and drop simulator for testing blob-backed attachment element dragging, and also add new
1288         attachment API tests.
1289
1290         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1291         (-[NSItemProvider expectType:withData:]):
1292         (TestWebKitAPI::TEST):
1293
1294         Add two new WKAttachmentTests to exercise dragging data- and file-backed blobs via attachment elements. These
1295         tests first insert attachments via drop or WKWebView SPI, and then drag these attachments out and use the
1296         -expectType:withData: helper to inspect the item providers created from the drag source.
1297
1298         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1299         (TestWebKitAPI::TEST):
1300         * TestWebKitAPI/ios/DataInteractionSimulator.h:
1301         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
1302         (-[MockDragSession localContext]):
1303         (-[MockDragSession setLocalContext:]):
1304         (-[DataInteractionSimulator _resetSimulatedState]):
1305         (-[DataInteractionSimulator simulateAllTouchesCanceled:]):
1306         (-[DataInteractionSimulator _concludeDataInteractionAndPerformOperationIfNecessary]):
1307         (-[DataInteractionSimulator _advanceProgress]):
1308         (-[DataInteractionSimulator endDataTransfer]):
1309
1310         Make some tweaks to the iOS drag and drop simulator. In particular, this patch (1) adds a new hook to tell
1311         WebKit that data transfers have been completed, (2) fixes incorrect drop proposal handling when returning
1312         UIDropOperationForbidden by replacing _shouldPerformOperation with a UIDropProposal, and (3) teach the
1313         MockDragSession to hold on to a localContext.
1314
1315 2018-01-11  Ali Juma  <ajuma@chromium.org>
1316
1317         Unreviewed. Add Ali Juma as contributor
1318
1319         * Scripts/webkitpy/common/config/contributors.json:
1320
1321 2018-01-11  Carlos Garcia Campos  <cgarcia@igalia.com>
1322
1323         Unreviewed. Update Selenium WebDriver imported tests.
1324
1325         New version of selenium uses command line options to pass driver and browser binaries to pytest instead of
1326         environment variables.
1327
1328         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
1329         (collect): Reorder the arguments to make pytest happy.
1330         (run): Ditto.
1331         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
1332         (WebDriverSeleniumExecutor.__init__): Add driver binary, browser binary and browser args as arguments.
1333
1334 2018-01-11  Ling Ho  <lingcherd_ho@apple.com>
1335
1336         Move Commit Queue and EWS Queues to Sierra on Bot Watcher's Dasboard
1337         https://bugs.webkit.org/show_bug.cgi?id=181492
1338         <rdar://problem/36359679>
1339
1340         Reviewed by Alexey Proskuryakov. 
1341
1342 2018-01-10  Adrian Perez de Castro  <aperez@igalia.com>
1343
1344         [GTK] Tools/gtk/install-dependencies: Packages geoclue, ruby-highline, xorg-utils do not exist in Arch Linux
1345         https://bugs.webkit.org/show_bug.cgi?id=181475
1346
1347         Reviewed by Michael Catanzaro.
1348
1349         * gtk/install-dependencies: Update package list for Arch Linux, extend
1350         message shown at end of installation with additional tips.
1351
1352 2018-01-10  Wenson Hsieh  <wenson_hsieh@apple.com>
1353
1354         REGRESSION(r222507): Composition highlight doesn't render when using IME
1355         https://bugs.webkit.org/show_bug.cgi?id=181485
1356         <rdar://problem/35896516>
1357
1358         Reviewed by Ryosuke Niwa.
1359
1360         Add a `suppressUnderline` argument to TextInputController.setMarkedText. This suppresses the custom underlines
1361         rendered when testing IME on iOS in WebKit2. In this new test, suppressing underline rendering is needed to
1362         allow rendering composition backgrounds (see InlineTextBox::paint).
1363
1364         * DumpRenderTree/ios/TextInputControllerIOS.m:
1365         (+[TextInputController isSelectorExcludedFromWebScript:]):
1366         (+[TextInputController webScriptNameForSelector:]):
1367         (-[TextInputController setMarkedText:selectedFrom:length:suppressUnderline:]):
1368         (-[TextInputController setMarkedText:selectedFrom:length:]): Deleted.
1369         * DumpRenderTree/mac/TextInputControllerMac.m:
1370         (+[TextInputController isSelectorExcludedFromWebScript:]):
1371         (+[TextInputController webScriptNameForSelector:]):
1372         (-[TextInputController setMarkedText:selectedFrom:length:suppressUnderline:]):
1373         (-[TextInputController setMarkedText:selectedFrom:length:]): Deleted.
1374         * WebKitTestRunner/InjectedBundle/Bindings/TextInputController.idl:
1375         * WebKitTestRunner/InjectedBundle/TextInputController.cpp:
1376         (WTR::TextInputController::setMarkedText):
1377         * WebKitTestRunner/InjectedBundle/TextInputController.h:
1378
1379 2018-01-10  JF Bastien  <jfbastien@apple.com>
1380
1381         Poison small JSObject derivatives which only contain pointers
1382         https://bugs.webkit.org/show_bug.cgi?id=181483
1383         <rdar://problem/36407127>
1384
1385         Reviewed by Mark Lam.
1386
1387         Test the new move-assign and move-copy from unique_ptr, as well as
1388         nullptr_t ctors.
1389
1390         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
1391         (TestWebKitAPI::TEST):
1392         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
1393         (TestWebKitAPI::TEST):
1394         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp:
1395         (TestWebKitAPI::TEST):
1396
1397 2018-01-10  Chris Dumez  <cdumez@apple.com>
1398
1399         Multiple http/wpt/beacon/contentextensions/ test are flaky.
1400         https://bugs.webkit.org/show_bug.cgi?id=179256
1401         <rdar://problem/35401978>
1402
1403         Reviewed by Alex Christensen.
1404
1405         Update WebKitTestRunner to set a temporary path for content extensions so that its WKTR
1406         instance gets its own folder to avoid conflicts and flakiness.
1407
1408         * WebKitTestRunner/mac/TestControllerMac.mm:
1409         (WTR::TestController::platformConfigureViewForTest):
1410
1411 2018-01-10  Tim Horton  <timothy_horton@apple.com>
1412
1413         REGRESSION (r213590): Swipe from edge to go to previous page is significantly slower than tapping back button on Twitter
1414         https://bugs.webkit.org/show_bug.cgi?id=181269
1415         <rdar://problem/35110344>
1416
1417         Reviewed by Simon Fraser.
1418
1419         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1420         (WTR::UIScriptController::beginBackSwipe):
1421         (WTR::UIScriptController::completeBackSwipe):
1422         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1423         (WTR::UIScriptController::beginBackSwipe):
1424         (WTR::UIScriptController::completeBackSwipe):
1425         (WTR::UIScriptController::overridePreference):
1426         (WTR::UIScriptController::replaceTextAtRange):
1427         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1428         (WTR::PlatformWebView::setNavigationGesturesEnabled):
1429         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1430         (WTR::UIScriptController::beginBackSwipe):
1431         (WTR::UIScriptController::completeBackSwipe):
1432         Implement beginBackSwipe and completeBackSwipe on iOS (they already
1433         exist on Mac) in terms of the new WKWebView testing SPI.
1434
1435 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
1436
1437         REGRESSION (r226715): ignore WARNING output in linter tests
1438         https://bugs.webkit.org/show_bug.cgi?id=181486
1439         <rdar://problem/36408847>
1440
1441         Reviewed by Aakash Jain.
1442
1443         Linter unit tests should not be interested in logs at the the INFO or WARNING levels.
1444
1445         * Scripts/webkitpy/common/system/outputcapture.py:
1446         (OutputCapture.__init__): Pass logging level to be captured.
1447         * Scripts/webkitpy/style/main_unittest.py:
1448         (ExpectationLinterInStyleCheckerTest.test_no_linter_errors): Capture logging at the ERROR level.
1449         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line): Ditto.
1450         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_no_edit): Ditto.
1451         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_edit_in_file): Ditto.
1452         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_only_deletes): Ditto.
1453         (ExpectationLinterInStyleCheckerTest.test_linter_added_file_with_error): Ditto.
1454         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file): Ditto.
1455         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file_no_edit): Ditto.
1456
1457 2018-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1458
1459         Add a JSCOnly MIPS buildbot
1460         https://bugs.webkit.org/show_bug.cgi?id=181487
1461
1462         Reviewed by Michael Catanzaro.
1463
1464         Add the new bot configs definitions for the master and update the unit tests.
1465
1466         * BuildSlaveSupport/build.webkit.org-config/config.json:
1467         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1468
1469 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
1470
1471         REGRESSION (r226715): don't re-check number of simulators in child processes
1472         https://bugs.webkit.org/show_bug.cgi?id=181484
1473         <rdar://problem/36407151>
1474
1475         Reviewed by Aakash Jain.
1476
1477         * Scripts/webkitpy/port/ios_simulator.py:
1478         (IOSSimulatorPort.__init__): Skip the number of simulators check if simulators
1479         are already initialized.
1480
1481 2018-01-10  Commit Queue  <commit-queue@webkit.org>
1482
1483         Unreviewed, rolling out r226667 and r226673.
1484         https://bugs.webkit.org/show_bug.cgi?id=181488
1485
1486         This caused a flaky crash. (Requested by mlewis13 on #webkit).
1487
1488         Reverted changesets:
1489
1490         "CodeBlocks should be in IsoSubspaces"
1491         https://bugs.webkit.org/show_bug.cgi?id=180884
1492         https://trac.webkit.org/changeset/226667
1493
1494         "REGRESSION (r226667): CodeBlocks should be in IsoSubspaces"
1495         https://bugs.webkit.org/show_bug.cgi?id=180884
1496         https://trac.webkit.org/changeset/226673
1497
1498 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
1499
1500         Follow-up fix to r226715
1501         https://bugs.webkit.org/show_bug.cgi?id=180555
1502         <rdar://problem/36131381>
1503
1504         Unreviewed infrastructure fix.
1505
1506         * Scripts/webkitpy/xcode/new_simulated_device.py:
1507         (SimulatedDeviceManager._create_or_find_device_for_request): Use _delete instead
1508         of delete.
1509
1510 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
1511
1512         webkitpy: Refactor simulator code (Part 2)
1513         https://bugs.webkit.org/show_bug.cgi?id=180555
1514         <rdar://problem/36131381>
1515
1516         Reviewed by Aakash Jain.
1517
1518         The patch leverages the SimulatedDeviceManager when running layout tests.
1519         This patch is primarily code removal, since much of the IOSSimulatorPort
1520         was dedicated to managing simulators. The removed code is either now owned by the
1521         SimulatedDeviceManager (and committed in Part 1) or supported a technique to
1522         boot multiple simulators which was made obsolete in Xcode 9.
1523
1524         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1525         (Manager._custom_device_for_test.in): Device names now have spaces in them,
1526         strip those spaces.
1527         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1528         (parse_args): Remove '--runtime' flag, this is achieved with the --version flag.
1529         * Scripts/webkitpy/port/ios.py:
1530         (IOSPort.__init__): The _current_device idiom is no longer required since the
1531         SimulatedDeviceManager keeps track of any previously booted devices.
1532         (IOSPort.target_host): Even when only a single device is used, it will be accessed
1533         through the array of managed devices.
1534         (IOSPort.using_multiple_devices): Deleted.
1535         * Scripts/webkitpy/port/ios_device.py:
1536         (IOSDevicePort.using_multiple_devices): Deleted.
1537         * Scripts/webkitpy/port/ios_simulator.py:
1538         (IOSSimulatorPort): Remove constants required to manage simulators, change device
1539         class strings so they can be parsed by the DeviceType class.
1540         (IOSSimulatorPort.__init__): Determine the number of processes to use by checking
1541         the number of simulators currently booted, the number of child processes specified
1542         and the maximum number of simulators supported by this system.
1543         (IOSSimulatorPort._device_for_worker_number_map):Return the array of initialized
1544         devices owned by the SimulatedDeviceManager.
1545         (IOSSimulatorPort.ios_version): Remove support for the --runtime option.
1546         (IOSSimulatorPort.default_child_processes): Use the SimulatedDeviceManager to check
1547         the maximum number of supported simulators on this system.
1548         (IOSSimulatorPort._create_devices): Construct a list of device requests with a
1549         request for each child process and send this list to the SimulatedDeviceManager to
1550         initialize the devices.
1551         (IOSSimulatorPort.clean_up_test_run):
1552         (IOSSimulatorPort.check_sys_deps): Check that there are simulators running the
1553         specified version of iOS.
1554         (IOSSimulatorPort.reset_preferences):
1555         (IOSSimulatorPort.simulator_runtime): Deleted.
1556         (IOSSimulatorPort.simulator_device_type): Deleted.
1557         (IOSSimulatorPort._teardown_managed_simulators): Deleted.
1558         (IOSSimulatorPort.use_multiple_simulator_apps): Deleted.
1559         (IOSSimulatorPort._create_simulators): Deleted.
1560         (IOSSimulatorPort._quit_ios_simulator): Deleted.
1561         (IOSSimulatorPort._using_dedicated_simulators): Deleted.
1562         (IOSSimulatorPort.using_multiple_devices): Deleted.
1563         (IOSSimulatorPort._create_device): Deleted.
1564         (IOSSimulatorPort.get_simulator_path): Deleted.
1565         (IOSSimulatorPort._createSimulatorApps): Deleted.
1566         (IOSSimulatorPort._createSimulatorApp): Deleted.
1567         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1568         (TestRebaseline.test_rebaseline): Filter out commands run when determining the
1569         maximum number of simulators run on this system.
1570         (TestRebaselineExpectations.test_rebaseline_expectations): Ditto.
1571         * Scripts/webkitpy/xcode/new_simulated_device.py:
1572         (SimulatedDeviceManager._does_fulfill_request): Fixed log statement.
1573
1574 2018-01-10  Carlos Garcia Campos  <cgarcia@igalia.com>
1575
1576         WebDriver: run-webdriver-tests doesn't handle test names with a '/' correctly
1577         https://bugs.webkit.org/show_bug.cgi?id=181474
1578
1579         Reviewed by Carlos Alberto Lopez Perez.
1580
1581         We use os.path.basename() to get the subtest name. If the test name contains a slash we get part of the subtest
1582         name as the name.
1583
1584         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
1585         (WebDriverTestRunnerW3C._subtest_name): Helper function to get the subtest name.
1586         (WebDriverTestRunnerW3C.run): Use _subtest_name() instead of os.path.basename().
1587
1588 2018-01-09  Andy Estes  <aestes@apple.com>
1589
1590         [Xcode] Use the Apple Internal SDK if available when building ImageDiff
1591         https://bugs.webkit.org/show_bug.cgi?id=181459
1592
1593         Reviewed by Dan Bernstein.
1594
1595         * ImageDiff/cg/Configurations/Base.xcconfig:
1596
1597 2018-01-09  Myles C. Maxfield  <mmaxfield@apple.com>
1598
1599         font-display:fallback can cause a visual flash (which is supposed to be impossible)
1600         https://bugs.webkit.org/show_bug.cgi?id=181374
1601
1602         Reviewed by Simon Fraser.
1603
1604         The test requires Palatino.
1605
1606         * DumpRenderTree/mac/DumpRenderTree.mm:
1607         (allowedFontFamilySet):
1608         * WebKitTestRunner/mac/TestControllerMac.mm:
1609         (WTR::allowedFontFamilySet):
1610
1611 2018-01-09  Saam Barati  <sbarati@apple.com>
1612
1613         Give some slack in display-profiler-outputs computation of the terminal window's number of columns
1614         https://bugs.webkit.org/show_bug.cgi?id=181449
1615
1616         Reviewed by JF Bastien.
1617
1618         This allows me to Cmd+f in my terminal to search for things without
1619         having the results become misaligned.
1620
1621         * Scripts/display-profiler-output:
1622
1623 2018-01-09  Basuke Suzuki  <Basuke.Suzuki@sony.com>
1624
1625         [webkitpy] PlatformInfo should have default argument for casual use
1626         https://bugs.webkit.org/show_bug.cgi?id=180827
1627
1628         Reviewed by David Kilzer.
1629
1630         PlatformInfo should be the only way to check platform specific thing instead
1631         of sys.platform or other various checks. If there is something you want to check,
1632         it should be placed in PlatformInfo.
1633
1634         Currently to instantiate PlatformInfo, it requires arguments, which is usually
1635         sys, platform and Executive(). They are straight forward and should be handled
1636         by default arguments. Then we can instantiate PlatformInfo more casual.
1637
1638         * Scripts/webkitpy/common/system/platforminfo.py:
1639         (PlatformInfo): Use relative module path import
1640         (PlatformInfo.__init__):
1641         (PlatformInfo.executive): Lazy instantiation of Executive()
1642         (PlatformInfo.total_bytes_memory): Accessing via above property
1643         (PlatformInfo.xcode_sdk_version): Ditto
1644         (PlatformInfo.xcode_simctl_list): Ditto
1645         (PlatformInfo.xcode_version): Ditto
1646         (PlatformInfo._win_version_str): Ditto
1647         * Scripts/webkitpy/common/system/systemhost.py:
1648         (SystemHost.__init__):
1649         * Scripts/webkitpy/common/system/user.py:
1650         (User.__init__):
1651
1652 2018-01-09  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
1653
1654         [Win] Remove workaround for Bug 176442 after stopping MSVC 2015 support
1655         https://bugs.webkit.org/show_bug.cgi?id=176443
1656
1657         Reviewed by Darin Adler.
1658
1659         * TestWebKitAPI/Tests/WTF/PriorityQueue.cpp:
1660         (TEST):
1661
1662 2018-01-09  Frederic Wang  <fwang@igalia.com.fr>
1663
1664         check-webkit-style: Verify syntax for WK_API_AVAILABLE
1665         https://bugs.webkit.org/show_bug.cgi?id=181394
1666
1667         Reviewed by Darin Adler.
1668
1669         A common syntax error for WK_API_AVAILABLE is to write ios(WK_MAC_TBA)
1670         as the second parameter instead of ios(WK_IOS_TBA). This generally
1671         builds for iOS on EWS but not when using the public SDK. See r224057,
1672         r223207 and r226211 for example. This patch adds a basic style check
1673         for that macro to prevent this kind of mistake.
1674
1675         * Scripts/webkitpy/style/checkers/cpp.py:
1676         (check_min_versions_of_wk_api_available): New function to verify the parameters of WX_API_AVAILABLE.
1677         (check_style): Run new style check.
1678         (CppChecker): Add build type for the new style check.
1679         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1680         (WebKitStyleTest.test_min_versions_of_wk_api_available): Add tests for the new style check.
1681
1682 2018-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1683
1684         [Attachment Support] Expose HTMLAttachmentElement.uniqueIdentifier to bindings
1685         https://bugs.webkit.org/show_bug.cgi?id=181420
1686         <rdar://problem/36365827>
1687
1688         Reviewed by Alex Christensen.
1689
1690         Adjusts some existing API tests to verify that attachment elements' uniqueIdentifiers match the uniqueIdentifier
1691         of corresponding _WKAttachments.
1692
1693         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1694         (TestWebKitAPI::TEST):
1695
1696 2018-01-08  Alex Christensen  <achristensen@webkit.org>
1697
1698         Add WKNavigationDelegate SPI exposing WebProcess crash reason
1699         https://bugs.webkit.org/show_bug.cgi?id=181410
1700         <rdar://problem/36167199>
1701
1702         Reviewed by Wenson Hsieh.
1703
1704         * TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
1705         (-[CrashReasonDelegate _webView:webContentProcessDidTerminateWithReason:]):
1706         (TEST):
1707
1708 2018-01-08  Alex Christensen  <achristensen@webkit.org>
1709
1710         Add SPI for WKOpenPanelParameters._acceptedMIMETypes and _acceptedFileExtensions
1711         https://bugs.webkit.org/show_bug.cgi?id=181408
1712         <rdar://problem/35884960>
1713
1714         Reviewed by Tim Horton.
1715
1716         * TestWebKitAPI/Tests/WebKitCocoa/RunOpenPanel.mm:
1717         (-[RunOpenPanelUIDelegate webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]):
1718
1719 2018-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1720
1721         [Attachment Support] Expose file name and content type of WKAttachment
1722         https://bugs.webkit.org/show_bug.cgi?id=181390
1723         <rdar://problem/36336837>
1724
1725         Reviewed by Tim Horton.
1726
1727         Adjusts some existing tests in WKAttachmentTests to exercise -requestInfo:.
1728
1729         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1730         (-[_WKAttachment synchronouslyRequestInfo:]):
1731         (-[_WKAttachment synchronouslyRequestData:]):
1732
1733         Reimplement this in terms of -synchronouslyRequestInfo:.
1734
1735         (-[_WKAttachment expectRequestedDataToBe:]):
1736         (TestWebKitAPI::TEST):
1737
1738 2018-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1739
1740         Copying, pasting, and then deleting an attachment element breaks attachment data requests
1741         https://bugs.webkit.org/show_bug.cgi?id=181365
1742         <rdar://problem/36340647>
1743
1744         Reviewed by Tim Horton.
1745
1746         Adds two new attachment API tests to verify that copying and pasting an existing attachment inserts an
1747         attachment element that may be edited independently of the original attachment. See WebCore/ChangeLog for more
1748         detail.
1749
1750         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1751         (TestWebKitAPI::TEST):
1752
1753 2018-01-08  Youenn Fablet  <youenn@apple.com>
1754
1755         navigator.onLine does not work inside service workers
1756         https://bugs.webkit.org/show_bug.cgi?id=181079
1757         <rdar://problem/36178606>
1758
1759         Reviewed by Darin Adler.
1760
1761         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1762         (WTR::InjectedBundle::initialize): Setting service worker creation callback to inject ServiceWorkerInternals object.
1763
1764 2018-01-07  Saam Barati  <sbarati@apple.com>
1765
1766         Add total exits and total compilations sorting mode to the "full" command in display-profiler-output
1767         https://bugs.webkit.org/show_bug.cgi?id=181372
1768
1769         Reviewed by Filip Pizlo.
1770
1771         Adding these sorting modes makes it easier to analyze functions
1772         that recompile a lot and exit a lot.
1773
1774         * Scripts/display-profiler-output:
1775
1776 2018-01-06  Julien Brianceau  <julien.brianceau@gmail.com>
1777
1778         Unreviewed, remove my Cisco email from contributors.json
1779
1780         * Scripts/webkitpy/common/config/contributors.json:
1781
1782 2018-01-05  JF Bastien  <jfbastien@apple.com>
1783
1784         WebAssembly: poison JS object's secrets
1785         https://bugs.webkit.org/show_bug.cgi?id=181339
1786         <rdar://problem/36325001>
1787
1788         Reviewed by Mark Lam.
1789
1790         Update tests for swap(Poisoned<k, T>, T*)
1791
1792         * TestWebKitAPI/Tests/WTF/ConstExprPoisoned.cpp:
1793         (TestWebKitAPI::TEST):
1794         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
1795         (TestWebKitAPI::TEST):
1796         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp:
1797         (TestWebKitAPI::TEST):
1798
1799 2018-01-05  Wenson Hsieh  <wenson_hsieh@apple.com>
1800
1801         REGRESSION(r226396) DataInteractionTests: ContentEditableToContentEditable and ContentEditableToTextarea are failing
1802         https://bugs.webkit.org/show_bug.cgi?id=181359
1803
1804         Reviewed by Tim Horton.
1805
1806         Ensure that these tests still pass using older SDKs.
1807
1808         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1809         (TestWebKitAPI::TEST):
1810
1811 2018-01-05  Alex Christensen  <achristensen@webkit.org>
1812
1813         Rebase API test after r226469
1814         https://bugs.webkit.org/show_bug.cgi?id=181308
1815
1816         * TestWebKitAPI/Tests/WebKitCocoa/LoadInvalidURLRequest.mm:
1817         (-[LoadInvalidURLNavigationActionDelegate webView:didFailProvisionalNavigation:withError:]):
1818         A URL with < or > in it is now recognized as invalid by WebKit.  This is intentional, and matches our behavior before enabling the new URLParser.
1819
1820 2018-01-05  Alex Christensen  <achristensen@webkit.org>
1821
1822         Restrict navigation-time WKWebsiteDataStore swapping to main frame navigations
1823         https://bugs.webkit.org/show_bug.cgi?id=181217
1824
1825         Reviewed by Tim Horton.
1826
1827         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1828         (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
1829         (TEST):
1830
1831 2018-01-05  Alex Christensen  <achristensen@webkit.org>
1832
1833         Add WKBundleFrameCreateFrameHandle
1834         https://bugs.webkit.org/show_bug.cgi?id=181232
1835         <rdar://problem/35926696>
1836
1837         Reviewed by Tim Horton.
1838
1839         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1840         * TestWebKitAPI/Tests/WebKitCocoa/FrameHandleSerialization.mm: Added.
1841         (mouseDidMoveOverElement):
1842         (-[FrameHandleSerialization webProcessPlugIn:didCreateBrowserContextController:]):
1843         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
1844         (-[MouseMoveOverElementDelegate _webView:mouseDidMoveOverElement:withFlags:userInfo:]):
1845         (TEST):
1846
1847 2018-01-05  Chris Fleizach  <cfleizach@apple.com>
1848
1849         iOS: Build fix after r226432.
1850         
1851         Unreviewed. Stop duplicating speakAs symbols for iOS.
1852
1853         * DumpRenderTree/AccessibilityUIElement.cpp:
1854         (AccessibilityUIElement::speakAs):
1855
1856 2018-01-05  Javier Fernandez  <jfernandez@igalia.com>
1857
1858         Unreviewed, added myself as WebKit reviewer
1859
1860         * Scripts/webkitpy/common/config/contributors.json:
1861
1862 2018-01-05  Claudio Saavedra  <csaavedra@igalia.com>
1863
1864         WPE: Build fix after r226432.
1865
1866         Unreviewed. Rename ::speak() to ::speakAs().
1867         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
1868         (WTR::AccessibilityUIElement::speakAs):
1869         (WTR::AccessibilityUIElement::speak): Deleted.
1870
1871 2018-01-04  Chris Fleizach  <cfleizach@apple.com>
1872
1873         AX: Implement updated CSS3 Speech for 'speak' and 'speak-as' properties
1874         https://bugs.webkit.org/show_bug.cgi?id=180361
1875
1876         Reviewed by Zalan Bujtas.
1877
1878         * DumpRenderTree/AccessibilityUIElement.cpp:
1879         (speakAsCallback):
1880         (AccessibilityUIElement::speakAs):
1881         (AccessibilityUIElement::getJSClass):
1882         (speakCallback): Deleted.
1883         (AccessibilityUIElement::speak): Deleted.
1884         * DumpRenderTree/AccessibilityUIElement.h:
1885         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1886         (AccessibilityUIElement::speakAs):
1887         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1888         (AccessibilityUIElement::speakAs):
1889         (AccessibilityUIElement::speak): Deleted.
1890         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1891         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1892         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1893         (WTR::AccessibilityUIElement::speakAs):
1894         (WTR::AccessibilityUIElement::speak): Deleted.
1895         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1896         (WTR::AccessibilityUIElement::speakAs):
1897         (WTR::AccessibilityUIElement::speak): Deleted.
1898
1899 2018-01-04  Jonathan Bedard  <jbedard@apple.com>
1900
1901         REGRESSION (r226395): test-webkitperl test expectations incorrect
1902         https://bugs.webkit.org/show_bug.cgi?id=181307
1903         <rdar://problem/36306558>
1904
1905         Rubber-stamped by Aakash Jain.
1906
1907         r226395 added two lines towards the beginning of
1908         Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl, the line
1909         numbers in the test expectations need to update.
1910
1911         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests-expected.txt:
1912
1913 2018-01-04  Tim Horton  <timothy_horton@apple.com>
1914
1915         WKWebView loses minimum layout size overrides that happen while the process is terminated
1916         https://bugs.webkit.org/show_bug.cgi?id=181306
1917         <rdar://problem/34398288>
1918
1919         Reviewed by Dan Bernstein.
1920
1921         * TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:
1922         (TEST):
1923         Add a test that calling _overrideLayoutParametersWithMinimumLayoutSize
1924         while the process is terminated results in the page getting the correct
1925         minimum layout size.
1926
1927 2018-01-04  Eric Carlson  <eric.carlson@apple.com>
1928
1929         [MediaStream] Add Mock screen capture source
1930         https://bugs.webkit.org/show_bug.cgi?id=181291
1931         <rdar://problem/36298164>
1932
1933         Reviewed by Dean Jackson.
1934
1935         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new test.
1936         * TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm:
1937         * TestWebKitAPI/Tests/WebKit/getDisplayMedia.html:
1938
1939 2018-01-04  Lucas Forschler  <lforschler@apple.com>
1940
1941         <rdar://problem/36300930> Change proxy server setting on master config to reach s3 servers
1942
1943         Reviewed by Ling Ho.
1944
1945         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1946
1947 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
1948
1949         [Attachment Support] Create attachment elements when dropping files on iOS
1950         https://bugs.webkit.org/show_bug.cgi?id=181192
1951         <rdar://problem/36280945>
1952
1953         Reviewed by Tim Horton.
1954
1955         Adds 3 new API tests to exercise different use cases of dropping content as attachment elements when the runtime
1956         switch is enabled. See below for more details.
1957
1958         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1959         (-[NSItemProvider registerData:type:]):
1960         (platformCopyPNG):
1961         (TestWebKitAPI::TEST):
1962         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1963
1964         Fix some currently failing iOS drag and drop tests. In this case, there's no reason RTFD should appear in the
1965         source item provider when dragging rich text *without* attachments, so this should have been a check for just
1966         kUTTypeRTF instead.
1967
1968         (TestWebKitAPI::TEST):
1969
1970         Tests a few cases of inserting attachment elements via drop:
1971         1.  We should distinguish between drops containing rich/plain text files from just dropping rich/plain text.
1972             Instead of inserting the contents as inline web content, this should generate attachment elements.
1973         2.  Test the fallback mechanism for inserting attachment elements. If the preferred presentation style is not
1974             explicitly set, but there's nothing WebKit would otherwise do with the dropped content, then we should fall
1975             back to inserting the content as an attachment.
1976         3.  Test that if multiple attachments and inline item providers are present, WebKit will respect the order in
1977             which they were inserted by the source (as opposed to, for instance, putting all of the attachments in front
1978             or at the end).
1979
1980         * TestWebKitAPI/cocoa/TestWKWebView.h:
1981         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1982         (-[TestWKWebView objectByEvaluatingJavaScript:]):
1983
1984         Add a helper method to return an object that represents the result of evaluating some given script, and rewrite
1985         -stringByEvaluatingJavaScript to just turn around and call this.
1986
1987         (-[TestWKWebView stringByEvaluatingJavaScript:]):
1988
1989 2018-01-03  Ting-Wei Lan  <lantw44@gmail.com>
1990
1991         Replace hard-coded paths in shebangs with #!/usr/bin/env
1992         https://bugs.webkit.org/show_bug.cgi?id=181040
1993
1994         Reviewed by Alex Christensen.
1995
1996         * BuildSlaveSupport/build-launcher-app:
1997         * BuildSlaveSupport/build-launcher-dmg:
1998         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1999         * BuildSlaveSupport/built-product-archive:
2000         * BuildSlaveSupport/clean-build:
2001         * BuildSlaveSupport/delete-stale-build-files:
2002         * BuildSlaveSupport/download-built-product:
2003         * BuildSlaveSupport/gtk/buildbot/log/run:
2004         * BuildSlaveSupport/gtk/buildbot/run:
2005         * BuildSlaveSupport/gtk/pulseaudio/run:
2006         * BuildSlaveSupport/kill-old-processes:
2007         * BuildSlaveSupport/test-result-archive:
2008         * BuildSlaveSupport/win/kill-old-processes:
2009         * Scripts/SpacingHeuristics.pm:
2010         * Scripts/add-include:
2011         * Scripts/build-api-tests:
2012         * Scripts/build-dumprendertree:
2013         * Scripts/build-imagediff:
2014         * Scripts/build-jsc:
2015         * Scripts/build-webkit:
2016         * Scripts/build-webkittestrunner:
2017         * Scripts/check-Xcode-source-file-types:
2018         * Scripts/check-dom-results:
2019         * Scripts/check-for-exit-time-destructors:
2020         * Scripts/check-for-global-initializers:
2021         * Scripts/check-for-inappropriate-objc-class-names:
2022         * Scripts/check-for-weak-vtables-and-externals:
2023         * Scripts/clean-header-guards:
2024         * Scripts/compare-timing-files:
2025         * Scripts/configure-xcode-for-ios-development:
2026         * Scripts/copy-webkitlibraries-to-product-directory:
2027         * Scripts/create-exports:
2028         * Scripts/debug-minibrowser:
2029         * Scripts/debug-safari:
2030         * Scripts/debug-test-runner:
2031         * Scripts/do-file-rename:
2032         * Scripts/do-webcore-rename:
2033         * Scripts/dump-webkit-tests-run:
2034         * Scripts/ensure-valid-python:
2035         * Scripts/execAppWithEnv:
2036         * Scripts/extract-localizable-js-strings:
2037         * Scripts/filter-build-webkit:
2038         * Scripts/find-extra-includes:
2039         * Scripts/fix-blink-patch:
2040         * Scripts/generate-coverage-data:
2041         * Scripts/git-add-reviewer:
2042         * Scripts/jsc-stress-test-helpers/js-exception-fuzz:
2043         * Scripts/jsc-stress-test-helpers/js-executable-allocation-fuzz:
2044         * Scripts/jsc-stress-test-helpers/js-osr-exit-fuzz:
2045         * Scripts/make-new-script-test:
2046         * Scripts/make-script-test-wrappers:
2047         * Scripts/package-root:
2048         * Scripts/parse-malloc-history:
2049         * Scripts/report-include-statistics:
2050         * Scripts/resolve-ChangeLogs:
2051         * Scripts/run-api-tests:
2052         * Scripts/run-bindings-tests:
2053         * Scripts/run-content-extension-tester:
2054         * Scripts/run-iexploder-tests:
2055         * Scripts/run-javascriptcore-tests:
2056         * Scripts/run-jsc:
2057         * Scripts/run-leaks:
2058         * Scripts/run-mangleme-tests:
2059         * Scripts/run-minibrowser:
2060         * Scripts/run-pageloadtest:
2061         * Scripts/run-regexp-tests:
2062         * Scripts/run-safari:
2063         * Scripts/run-sunspider:
2064         * Scripts/run-test-runner:
2065         * Scripts/run-webkit-app:
2066         * Scripts/run-webkit-httpd:
2067         * Scripts/run-webkit-websocketserver:
2068         * Scripts/set-webkit-configuration:
2069         * Scripts/show-pretty-diff:
2070         * Scripts/sort-Xcode-project-file:
2071         * Scripts/split-file-by-class:
2072         * Scripts/sunspider-compare-results:
2073         * Scripts/svn-apply:
2074         * Scripts/svn-unapply:
2075         * Scripts/test-webkit-scripts:
2076         * Scripts/test-webkitperl:
2077         * Scripts/update-iexploder-cssproperties:
2078         * Scripts/update-javascriptcore-test-results:
2079         * Scripts/update-webkit:
2080         * Scripts/update-webkit-auxiliary-libs:
2081         * Scripts/update-webkit-dependency:
2082         * Scripts/update-webkit-libs-jhbuild:
2083         * Scripts/update-webkit-localizable-strings:
2084         * Scripts/update-webkit-support-libs:
2085         * Scripts/update-webkitgtk-libs:
2086         * Scripts/update-webkitwpe-libs:
2087         * Scripts/webkit-build-directory:
2088         * Scripts/webkitperl/LoadAsModule.pm:
2089         * Scripts/webkitperl/VCSUtils_unittest/decodeGitBinaryPatch.pl:
2090         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
2091         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatchThenSetChangeLogDateAndReviewer.pl:
2092         * Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl:
2093         * Scripts/webkitperl/VCSUtils_unittest/generatePatchCommand.pl:
2094         * Scripts/webkitperl/VCSUtils_unittest/mergeChangeLogs.pl:
2095         * Scripts/webkitperl/VCSUtils_unittest/parseChunkRange.pl:
2096         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
2097         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
2098         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
2099         * Scripts/webkitperl/VCSUtils_unittest/parseFirstEOL.pl:
2100         * Scripts/webkitperl/VCSUtils_unittest/parseGitDiffHeader.pl:
2101         * Scripts/webkitperl/VCSUtils_unittest/parsePatch.pl:
2102         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffFooter.pl:
2103         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl:
2104         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
2105         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
2106         * Scripts/webkitperl/VCSUtils_unittest/parseUnifiedDiffHeader.pl:
2107         * Scripts/webkitperl/VCSUtils_unittest/prepareParsedPatch.pl:
2108         * Scripts/webkitperl/VCSUtils_unittest/removeEOL.pl:
2109         * Scripts/webkitperl/VCSUtils_unittest/runCommand.pl:
2110         * Scripts/webkitperl/VCSUtils_unittest/runPatchCommand.pl:
2111         * Scripts/webkitperl/VCSUtils_unittest/setChangeLogDateAndReviewer.pl:
2112         * Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl:
2113         * Scripts/webkitperl/auto-version_unittest/versionStampTests.pl:
2114         * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl:
2115         * Scripts/webkitperl/prepare-ChangeLog_unittest/extractLineRangeBeforeAndAfterChange.pl:
2116         * Scripts/webkitperl/prepare-ChangeLog_unittest/fetchRadarURLFromBugXMLData.pl:
2117         * Scripts/webkitperl/prepare-ChangeLog_unittest/generateFunctionLists.pl:
2118         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
2119         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl:
2120         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl:
2121         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl:
2122         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl:
2123         * Scripts/webkitperl/webkitdirs_unittest/appendToEnvironmentVariableList.pl:
2124         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRef.pl:
2125         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRefGettingValue.pl:
2126         * Scripts/webkitperl/webkitdirs_unittest/extractNonMacOSHostConfiguration.pl:
2127         * Scripts/webkitperl/webkitdirs_unittest/prependToEnvironmentVariableList.pl:
2128         * Scripts/webkitpy/layout_tests/servers/run_webkit_httpd.py:
2129         * ccache/ccache-clang:
2130         * ccache/ccache-clang++:
2131         * ccache/ccache-wrapper:
2132         * gtk/install-dependencies:
2133         * iExploder/iexploder-1.3.2/htdocs/iexploder.cgi:
2134         * iExploder/iexploder-1.3.2/htdocs/webserver.rb:
2135         * iExploder/iexploder-1.3.2/tools/lasthit.rb:
2136         * iExploder/iexploder-1.3.2/tools/osx_last_crash.rb:
2137         * iExploder/iexploder-1.3.2/tools/showtest.rb:
2138         * iExploder/iexploder-1.7.2/src/browser_harness.rb:
2139         * iExploder/iexploder-1.7.2/src/iexploder.cgi:
2140         * iExploder/iexploder-1.7.2/src/webserver.rb:
2141         * iExploder/iexploder-1.7.2/tools/lasthit.rb:
2142         * iExploder/iexploder-1.7.2/tools/osx_last_crash.rb:
2143         * wpe/install-dependencies:
2144
2145 2018-01-03  Simon Fraser  <simon.fraser@apple.com>
2146
2147         filter-build-webkit filters out useful compiler error lines
2148         https://bugs.webkit.org/show_bug.cgi?id=179864
2149
2150         Reviewed by Tim Horton.
2151
2152         Don't filter out lines that contain information about build errors by always showing lines
2153         after a line that contains "note:" or "error:".
2154
2155         * Scripts/filter-build-webkit:
2156         (shouldShowSubsequentLine):
2157         (shouldIgnoreLine):
2158
2159 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
2160
2161         REGRESSION(r226366): [GTK] Broke TestBackForwardList and TestWebKitWebView
2162         https://bugs.webkit.org/show_bug.cgi?id=173915
2163
2164         Unreviewed follow-up. Fix /webkit2/WebKitWebView/session-state-with-form-data and
2165         /webkit2/WebKitWebView/submit-form. The form ID may be NULL, but we can't put NULL into a
2166         GVariant unless we use maybe types, and maybe types are incompatible with D-Bus. So use an
2167         empty string in this case.
2168
2169         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
2170         (emitFormSubmissionEvent):
2171
2172 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
2173
2174         [GTK] Add web process API to detect when form is submitted via JavaScript
2175         https://bugs.webkit.org/show_bug.cgi?id=173915
2176
2177         Reviewed by Carlos Garcia Campos.
2178
2179         Test it.
2180
2181         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
2182         (FormSubmissionTest::FormSubmissionTest):
2183         (FormSubmissionTest::~FormSubmissionTest):
2184         (FormSubmissionTest::testFormSubmissionResult):
2185         (FormSubmissionTest::willSendDOMEventCallback):
2186         (FormSubmissionTest::willCompleteCallback):
2187         (FormSubmissionTest::runJavaScriptAndWaitUntilFormSubmitted):
2188         (testWebExtensionFormSubmissionSteps):
2189         (beforeAll):
2190         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
2191         (DelayedSignal::DelayedSignal):
2192         (emitFormSubmissionEvent):
2193         (handleFormSubmissionCallback):
2194         (willSubmitFormCallback):
2195         (pageCreatedCallback):
2196
2197 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
2198
2199         Unreviewed, skip broken API test /webkit2/WebKitWebsiteData/databases
2200         https://bugs.webkit.org/show_bug.cgi?id=181251
2201
2202         * Scripts/run-gtk-tests:
2203         (GtkTestRunner):
2204
2205 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
2206
2207         Unreviewed, skip broken API test /webkit2/WebKitWebsiteData/ephemeral
2208         https://bugs.webkit.org/show_bug.cgi?id=181136
2209
2210         * Scripts/run-gtk-tests:
2211         (GtkTestRunner):
2212
2213 2018-01-02  Brent Fulgham  <bfulgham@apple.com>
2214
2215         [macOS, iOS] Adopt new secure coding APIs in WebKit
2216         https://bugs.webkit.org/show_bug.cgi?id=181085
2217         <rdar://problem/34837397>
2218
2219         Reviewed by Tim Horton.
2220
2221         Update API tests to use secure coding wherever possible. Currently, NSView/UIView-based classes are not
2222         capable of supporting NSSecureCoding, so pass through the current coding routines.
2223
2224         * TestWebKitAPI/Tests/WebKitCocoa/ApplicationManifest.mm: Updated for NSSecureCoding.
2225         * TestWebKitAPI/Tests/WebKitCocoa/Coding.mm:
2226         (encodeAndDecode): Check if class supports the NSSecureCoding protocol and use non-secure coding
2227         routines if necessary.
2228         (TEST): Updated for NSSecureCoding.
2229         * TestWebKitAPI/Tests/mac/EarlyKVOCrash.mm:
2230         (TestWebKitAPI::TEST): Updated for NSSecureCoding.
2231
2232 2017-12-28  Yusuke Suzuki  <utatane.tea@gmail.com>
2233
2234         Remove std::chrono completely
2235         https://bugs.webkit.org/show_bug.cgi?id=181186
2236
2237         Reviewed by Alex Christensen.
2238
2239         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2240         (WTR::TestController::platformRunUntil):
2241
2242 2018-01-02  Michael Catanzaro  <mcatanzaro@igalia.com>
2243
2244         REGRESSION(r223253): Broke ResourceLoadStatistics layout tests for non-Cocoa ports
2245         https://bugs.webkit.org/show_bug.cgi?id=181231
2246
2247         Reviewed by Alex Christensen.
2248
2249         Implement TestController APIs needed by ResourceLoadStatistics tests.
2250
2251         * WebKitTestRunner/TestController.cpp:
2252         (WTR::TestController::isStatisticsRegisteredAsSubFrameUnder):
2253         (WTR::TestController::isStatisticsRegisteredAsRedirectingTo):
2254
2255 2018-01-02  Tim Horton  <timothy_horton@apple.com>
2256
2257         Disable WKAttachmentTests if UIPasteboard.itemProviders is not available
2258         https://bugs.webkit.org/show_bug.cgi?id=181219
2259
2260         Reviewed by Wenson Hsieh.
2261
2262         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2263
2264 2018-01-02  Jiewen Tan  <jiewen_tan@apple.com>
2265
2266         Add a WebAuthentication runtime feature flag
2267         https://bugs.webkit.org/show_bug.cgi?id=181220
2268         <rdar://problem/36055305>
2269
2270         Reviewed by Brent Fulgham.
2271
2272         Renames the CredentialManagement runtime feature flag into WebAuthentication.
2273
2274         * DumpRenderTree/TestOptions.h:
2275         * DumpRenderTree/TestOptions.mm:
2276         (TestOptions::TestOptions):
2277         * DumpRenderTree/mac/DumpRenderTree.mm:
2278         (enableExperimentalFeatures):
2279         (setWebPreferencesForTestOptions):
2280         * WebKitTestRunner/TestController.cpp:
2281         (WTR::TestController::resetPreferencesToConsistentValues):
2282         (WTR::updateTestOptionsFromTestHeader):
2283         * WebKitTestRunner/TestOptions.h:
2284         (WTR::TestOptions::hasSameInitializationOptions const):
2285
2286 2018-01-02  Wenson Hsieh  <wenson_hsieh@apple.com>
2287
2288         [Attachment Support] Don't Blob-convert images and attachments with https:, http: or data: urls
2289         https://bugs.webkit.org/show_bug.cgi?id=181143
2290         <rdar://problem/36200381>
2291
2292         Reviewed by Tim Horton.
2293
2294         Add a new API test to ensure that a copied image with a data URL does not get pasted as an attachment when
2295         attachment elements are enabled.
2296
2297         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2298         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2299         (TestWebKitAPI::TEST):
2300
2301 2018-01-02  Jiewen Tan  <jiewen_tan@apple.com>
2302
2303         Update Credential Management API for WebAuthentication
2304         https://bugs.webkit.org/show_bug.cgi?id=181082
2305         <rdar://problem/36055239>
2306
2307         Reviewed by Brent Fulgham.
2308
2309         Enable Credential Management API for testing.
2310
2311         * DumpRenderTree/TestOptions.h:
2312         * WebKitTestRunner/TestOptions.h:
2313
2314 2018-01-02  Michael Catanzaro  <mcatanzaro@igalia.com>
2315
2316         [GTK] Test /webkit2/WebKitWebExtension/form-controls-associated-signal is flaky
2317         https://bugs.webkit.org/show_bug.cgi?id=168194
2318
2319         Reviewed by Carlos Garcia Campos.
2320
2321         Fix an assertion and unskip the test. The order that form controls are associated is not
2322         guaranteed.
2323
2324         * Scripts/run-gtk-tests:
2325         (GtkTestRunner):
2326         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
2327         (didAssociateFormControlsCallback):
2328
2329 2018-01-02  Alex Christensen  <achristensen@webkit.org>
2330
2331         Use new WebsiteDataStore passed in through decidePolicyForNavigation SPI
2332         https://bugs.webkit.org/show_bug.cgi?id=180897
2333         <rdar://problem/35535328>
2334
2335         Reviewed by Brent Fulgham.
2336
2337         Test two forms of storage to be sure we are using a different WebsiteDataStore: cookies and sessionStorage.
2338
2339         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2340         (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
2341         (-[WebsitePoliciesWebsiteDataStoreDelegate webView:startURLSchemeTask:]):
2342         (-[WebsitePoliciesWebsiteDataStoreDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2343         (websiteDataStoreTestWebView):
2344         (TEST):
2345
2346 == Rolled over to ChangeLog-2018-01-01 ==