Remove efl wk1 buildbot and ews
[WebKit-https.git] / Tools / ChangeLog
1 2014-06-19  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2
3         Remove efl wk1 buildbot and ews
4         https://bugs.webkit.org/show_bug.cgi?id=134089
5
6         Reviewed by Benjamin Poulain.
7
8         EFL WK1 is not supported anymore. Removed all bots for EFL WK1 bots.
9
10         * BuildSlaveSupport/build.webkit.org-config/config.json:
11         * QueueStatusServer/config/queues.py:
12         * Scripts/webkitpy/common/config/ews.json:
13         * Scripts/webkitpy/common/config/ports.py:
14         (DeprecatedPort.port):
15         (QtWK2Port.run_webkit_tests_command):
16         (EflPort): Deleted.
17         (EflPort.build_webkit_command): Deleted.
18         * Scripts/webkitpy/port/builders.py:
19         * TestResultServer/static-dashboards/flakiness_dashboard.js:
20         * TestResultServer/static-dashboards/loader_unittests.js:
21
22 2014-06-19  David Kilzer  <ddkilzer@apple.com>
23
24         check-webkit-style does not understand Obj-C literal syntax for NSDictionary
25         <http://webkit.org/b/134061>
26
27         Reviewed by Dan Bernstein.
28
29         * Scripts/webkitpy/style/checkers/cpp.py:
30         (check_spacing): Ignore '@' immediately before '{'.
31         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
32         (CppStyleTest.test_spacing_before_braces): Add unit test for
33         '^{' block syntax and '@{' Objective-C liternal NSDitionary
34         syntax.
35
36 2014-06-18  Tim Horton  <timothy_horton@apple.com>
37
38         All of MiniBrowser's WKWebViews should share a configuration
39         https://bugs.webkit.org/show_bug.cgi?id=134017
40
41         Reviewed by Anders Carlsson.
42
43         * MiniBrowser/mac/WK2BrowserWindowController.m:
44         (-[WK2BrowserWindowController awakeFromNib]):
45         Share a single WKWebViewConfiguration between all of MiniBrowser's views.
46         This means that they'll share things like preferences, visited links, etc.
47         It also means that we'll properly share processes once we hit the process limit.
48
49 2014-06-18  Zan Dobersek  <zdobersek@igalia.com>
50
51         [GTK] Bump the GLib and GTK+ dependencies in jhbuild-wayland.modules
52         https://bugs.webkit.org/show_bug.cgi?id=133971
53
54         Reviewed by Martin Robinson.
55
56         * gtk/jhbuild-wayland.modules: Bump the GTK+ dependency that's required for
57         building for the Wayland target. The latest 3.12 version is required to match
58         the xdg_shell protocol version used in Weston 1.5. GLib dependency is bumped
59         as well due to GTK+ depending on a newer version.
60
61 2014-06-17  Ryuan Choi  <ryuan.choi@samsung.com>
62
63         [EFL] Turn on NOSNIFF in FeatureList.pm
64         https://bugs.webkit.org/show_bug.cgi?id=134010
65
66         Reviewed by Csaba Osztrogonác.
67
68         r164848 enabled NOSNIFF feature for EFL port but missed to change FeatureList.pm.
69
70         * Scripts/webkitperl/FeatureList.pm: Turn on NOSNIFF for the EFL port.
71
72 2014-06-17  Tim Horton  <timothy_horton@apple.com>
73
74         MiniBrowser should show Web Content process pids in the window title
75         https://bugs.webkit.org/show_bug.cgi?id=134016
76
77         Reviewed by Sam Weinig.
78
79         * MiniBrowser/mac/WK2BrowserWindowController.m:
80         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
81
82 2014-06-17  Carlos Alberto Lopez Perez  <clopez@igalia.com>
83
84         [GTK] Fix the handling of resize events after r169505.
85         https://bugs.webkit.org/show_bug.cgi?id=133517
86
87         Reviewed by Martin Robinson.
88
89         * Scripts/webkitpy/port/xvfbdriver.py:
90         (XvfbDriver._start): Set the resolution of Xvfb to XGA (1024x768).
91         The tests css3/viewport-percentage-lengths/viewport-percentage-lengths-*.html
92         need at least 900x640 pixels to pass.
93         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
94         (XvfbDriverTest.test_start_no_pixel_tests): Update resolution.
95         (XvfbDriverTest.test_start_pixel_tests): Update resolution.
96         (XvfbDriverTest.test_start_arbitrary_worker_number): Update resolution.
97         (XvfbDriverTest.test_start_next_worker): Update resolution.
98         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
99         (WTR::PlatformWebView::PlatformWebView): gtk_widget_size_allocate should
100         be requested over the main widget instead of the window.
101         (WTR::PlatformWebView::resizeTo): Changed this to call setWindowFrame like
102         the Mac port.
103         (WTR::PlatformWebView::windowFrame): Remove legacy ifdef for GTK2.
104         (WTR::PlatformWebView::setWindowFrame): Set the size and position
105         of the Window and the web view.
106
107 2014-06-17  Matthew Mirman <mmirman@apple.com>
108
109         Unreviewed. Added myself to list of contributors.
110
111         * Scripts/webkitpy/common/config/contributors.json: Added myself.
112
113 2014-06-17  Commit Queue  <commit-queue@webkit.org>
114
115         Unreviewed, rolling out r170058.
116         https://bugs.webkit.org/show_bug.cgi?id=133993
117
118         Caused 4 webkitpy failures on the bots (Requested by bradee-oh
119         on #webkit).
120
121         Reverted changeset:
122
123         "[GTK] Fix the handling of resize events after r169505."
124         https://bugs.webkit.org/show_bug.cgi?id=133517
125         http://trac.webkit.org/changeset/170058
126
127 2014-06-17  Rebecca Hauck  <rhauck@adobe.com>
128
129         Update import-w3c-tests to reflect current W3C test repo directory structure
130         https://bugs.webkit.org/show_bug.cgi?id=133460
131
132         Reviewed by Bem Jones-Bey.
133
134         Removed all references to test status, which are no longer reflected in the
135         directory names in the W3C CSS test repo.  No tests are required for this 
136         change, the existing tests pass.
137
138         * Scripts/webkitpy/w3c/test_importer.py:
139         (main):
140         (TestImporter.__init__):
141         (TestImporter.find_importable_tests):
142         (TestImporter.setup_destination_directory):
143         (TestImporter.write_import_log):
144         (TestImporter.update_test_status): Deleted.
145
146 2014-06-17  Carlos Alberto Lopez Perez  <clopez@igalia.com>
147
148         [GTK] Fix the handling of resize events after r169505.
149         https://bugs.webkit.org/show_bug.cgi?id=133517
150
151         Reviewed by Martin Robinson.
152
153         * Scripts/webkitpy/port/xvfbdriver.py:
154         (XvfbDriver._start): Set the resolution of Xvfb to XGA (1024x768).
155         The tests css3/viewport-percentage-lengths/viewport-percentage-lengths-*.html
156         need at least 900x640 pixels to pass.
157         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
158         (WTR::PlatformWebView::PlatformWebView): gtk_widget_size_allocate should
159         be requested over the main widget instead of the window.
160         (WTR::PlatformWebView::resizeTo): Changed this to call setWindowFrame like
161         the Mac port.
162         (WTR::PlatformWebView::windowFrame): Remove legacy ifdef for GTK2.
163         (WTR::PlatformWebView::setWindowFrame): Set the size and position
164         of the Window and the web view.
165
166 2014-06-17  Dan Bernstein  <mitz@apple.com>
167
168         String::isolatedCopy doesn’t return an isolated copy when used on an rvalue reference
169         https://bugs.webkit.org/show_bug.cgi?id=133968
170
171         Reviewed by Anders Carlsson.
172
173         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
174         (TestWebKitAPI::TEST): Added a test that an isolated copy of an rvalue reference doesn’t
175         share an impl() with the original.
176
177 2014-06-17  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
178
179         [EFL][WK2] Skip failing EFL API tests
180         https://bugs.webkit.org/show_bug.cgi?id=133981
181
182         Reviewed by Csaba Osztrogonác.
183
184         UserMessage, WillLoad and test_ewk2_view have been failed since r169784.
185
186         * TestWebKitAPI/PlatformEfl.cmake:
187
188 2014-06-16  Ryuan Choi  <ryuan.choi@samsung.com>
189
190         [EFL][WK2] Remove workaround for icon display bug in MiniBrowser
191         https://bugs.webkit.org/show_bug.cgi?id=133962
192
193         Reviewed by Gyuyoung Kim.
194
195         Since we bumped EFL to 1.9, this workaround is unnecessary.
196
197         * MiniBrowser/efl/main.c:
198         (update_view_favicon):
199
200 2014-06-16  Gwang Yoon Hwang  <yoon@igalia.com>
201
202         [GTK] Add llvmpipe (Mesa) to the JHBuild moduleset and force it when running layout tests
203         https://bugs.webkit.org/show_bug.cgi?id=131472
204
205         Reviewed by Martin Robinson.
206
207         This patch reapplies r167510 with fixes to add llvm as a dependency for llvmpipe.
208
209         * Scripts/webkitpy/port/xvfbdriver.py:
210         (XvfbDriver._start): Use the LLVMPIPE_LIBGL_PATH to set the LD_LIBRARY_PATH
211         when running WebKitTestRunner with the Xvfb driver.
212         * gtk/install-dependencies: Add LLVM as a dependency to build llvmpipe.
213         * gtk/jhbuild.modules: Add Mesa to the modulelist so that the llvmpipe libGL is build, but not
214         installed.
215         * gtk/jhbuildrc: Set the LLVMPIPE_LIBGL_PATH environment variable so that the test driver knows
216         how to properly set the LD_LIBRARY_PATH variable. We do this because it is much easier to
217         calculate the path in the jhbuildrc than in the test driver code. This simplifies things a great
218         deal.
219
220 2014-06-16  Tanay C  <tanay.c@samsung.com>
221
222         Remove deprecated API warnings in WebKit/Tools/MiniBrowser/efl/main.c
223         https://bugs.webkit.org/show_bug.cgi?id=133792
224
225         Reviewed by Gyuyoung Kim.
226
227         * MiniBrowser/efl/main.c: replaced the deprecated API's with the latest ones
228         (show_file_entry_dialog):
229         (window_create):
230
231 2014-06-16  Mario Sanchez Prada  <mario.prada@samsung.com>
232
233         [ATK] Missing 'selection-changed' signal when navigating a combo box with keyboard
234         https://bugs.webkit.org/show_bug.cgi?id=133512
235
236         Reviewed by Chris Fleizach.
237
238         Added support for connecting to AtkSelection's 'selection-changed'
239         signal, and print it out as AXSelectedChildrenChanged in the tests.
240
241         Also removed some dead code, that became useless after r169487.
242
243         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
244         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Updated.
245
246 2014-06-15  Ryuan Choi  <ryuan.choi@samsung.com>
247
248         [EFL][WK2] Change ewk_view_settings_get to ewk_page_group_settings_get
249         https://bugs.webkit.org/show_bug.cgi?id=133841
250
251         Reviewed by Gyuyoung Kim.
252
253         * MiniBrowser/efl/main.c:
254         (window_create):
255
256 2014-06-15  Dan Bernstein  <mitz@apple.com>
257
258         Set the svn:ignore property on an Xcode project to ignore user and workspace data.
259
260         * jsc-cli/jsc-cli.xcodeproj: Added property svn:ignore.
261
262 2014-06-15  Anders Carlsson  <andersca@apple.com>
263
264         Fix build.
265
266         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
267         (callRunJavaScriptBlockAndRelease):
268         (runJavaScriptInMainFrame):
269         (TEST_F):
270
271 2014-06-13  Xabier Rodriguez Calvar  <calvaris@igalia.com>
272
273         Create MSE and EME watchlist
274         https://bugs.webkit.org/show_bug.cgi?id=133810
275
276         Reviewed by Eric Carlson.
277
278         * Scripts/webkitpy/common/config/watchlist: Create MSEEME
279         definition and add Eric Carlson and myself to it.
280
281 2014-06-12  Carlos Garcia Campos  <cgarcia@igalia.com>
282
283         [GTK] Remove all deprecated API from GObject DOM bindings
284         https://bugs.webkit.org/show_bug.cgi?id=133728
285
286         Reviewed by Martin Robinson.
287
288         * gtk/webkitdom.py:
289         (WebKitDOMDocGenerator): Remove all deleted classes from the list.
290         (WebKitDOMDocGeneratorSections.__init__): Fix a typo in member initialization.
291
292 2014-06-12  Simon Fraser  <simon.fraser@apple.com>
293
294         [iOS] Fix the view being half offscreen in WebKitTestRunner on iOS
295         https://bugs.webkit.org/show_bug.cgi?id=133835
296
297         Reviewed by Tim Horton.
298         
299         Don't do the _fakeOrigin stuff when -initWithFrame: is calling -setFrame:
300
301         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
302         (-[WebKitTestRunnerWindow initWithFrame:]):
303         (-[WebKitTestRunnerWindow setFrame:]):
304
305 2014-06-12  Carlos Alberto Lopez Perez  <clopez@igalia.com>
306
307         [GTK] Performance tests should be always ran with WKTR.
308         https://bugs.webkit.org/show_bug.cgi?id=133780
309
310         Reviewed by Ryosuke Niwa.
311
312         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
313         (PerfTestsRunner.__init__): Enable webkit_test_runner when port
314         is GTK.
315
316 2014-06-12  Sergio Villar Senin  <svillar@igalia.com>
317
318         [GTK] REGRESSION: application name is not correctly appended to the UA
319         https://bugs.webkit.org/show_bug.cgi?id=133793
320
321         Reviewed by Carlos Garcia Campos.
322
323         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
324         (testWebKitSettingsUserAgent):
325
326 2014-06-12  Sergio Villar Senin  <svillar@igalia.com>
327
328         [GTK] Unsupported browser in www.icloud.com
329         https://bugs.webkit.org/show_bug.cgi?id=133403
330
331         Reviewed by Martin Robinson.
332
333         * TestWebKitAPI/Tests/WebCore/gtk/UserAgentQuirks.cpp:
334         (TestWebKitAPI::TEST): removed a test for the NeedsSafariVersion6
335         quirk that was removed.
336
337 2014-06-11  Simon Fraser  <simon.fraser@apple.com>
338
339         [iOS WK2] Give WebKitTestRunner a viewport configuration with initial scale=1 for testing
340         https://bugs.webkit.org/show_bug.cgi?id=133779
341
342         Reviewed by Benjamin Poulain.
343         
344         Tell the WebPage to use the testing viewport configuration from the injected bundle.
345
346         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
347         (WTR::InjectedBundle::didReceiveMessage): Code cleanup.
348         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
349         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame): Call WKBundlePageSetUseTestingViewportConfiguration()
350         on iOS.
351
352 2014-06-11  Simon Fraser  <simon.fraser@apple.com>
353
354         WTR cleanup: push per-test viewport configuration into TestController, where platforms can customize it
355         https://bugs.webkit.org/show_bug.cgi?id=133770
356
357         Reviewed by Anders Carlsson.
358         
359         Push the per-test view configuration up to TestController, so that platforms
360         can modify the behavior. This also allows platform-specific changes (e.g.
361         for threaded scrolling) to made without #ifefs.
362
363         * WebKitTestRunner/TestController.cpp:
364         (WTR::TestController::updateWebViewSizeForTest):
365         (WTR::TestController::updateWindowScaleForTest):
366         (WTR::shouldUseFixedLayout):
367         (WTR::TestController::updateLayoutTypeForTest):
368         (WTR::TestController::platformConfigureViewForTest):
369         (WTR::TestController::configureViewForTest):
370         * WebKitTestRunner/TestController.h:
371         * WebKitTestRunner/TestInvocation.cpp:
372         (WTR::TestInvocation::invoke):
373         (WTR::sizeWebViewForCurrentTest): Deleted.
374         (WTR::changeWindowScaleIfNeeded): Deleted.
375         (WTR::shouldUseThreadedScrolling): Deleted.
376         (WTR::updateThreadedScrollingForCurrentTest): Deleted.
377         (WTR::shouldUseFixedLayout): Deleted.
378         (WTR::updateLayoutType): Deleted.
379         * WebKitTestRunner/TestInvocation.h:
380         (WTR::TestInvocation::pathOrURL):
381         * WebKitTestRunner/ios/TestControllerIOS.mm:
382         (WTR::shouldMakeViewportFlexible):
383         (WTR::TestController::platformConfigureViewForTest):
384         * WebKitTestRunner/mac/TestControllerMac.mm:
385         (WTR::shouldUseThreadedScrolling):
386         (WTR::TestController::platformConfigureViewForTest):
387
388 2014-06-11  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
389
390         [EFL] Add dependencies packages to efl install-dependencies file
391         https://bugs.webkit.org/show_bug.cgi?id=133720
392
393         Reviewed by Csaba Osztrogonác.
394
395         After r169785, EFL port starts to use efl 1.9 ver. EFL port needs to
396         install doxygen and libssl-dev because efl 1.9 depends on those libraries.
397
398         * efl/install-dependencies:
399
400 2014-06-11  Zoltan Horvath  <zoltan@webkit.org>
401
402         Unreviewed. Moving myself to the list of reviewers.
403
404         * Scripts/webkitpy/common/config/contributors.json:
405
406 2014-06-11  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
407
408         [EFL] Drop to maintain EFL 32bit release bot
409         https://bugs.webkit.org/show_bug.cgi?id=133710
410
411         Reviewed by Csaba Osztrogonác.
412
413         * BuildSlaveSupport/build.webkit.org-config/config.json: Removed EFL 32bit bot.
414
415 2014-06-11  Carlos Garcia Campos  <cgarcia@igalia.com>
416
417         [GTK] Use a different user agent string depending on the site
418         https://bugs.webkit.org/show_bug.cgi?id=132681
419
420         Reviewed by Anders Carlsson.
421
422         Add a unit test to check user agent quirks.
423
424         * TestWebKitAPI/PlatformGTK.cmake:
425         * TestWebKitAPI/Tests/WebCore/gtk/UserAgentQuirks.cpp: Added.
426         (TestWebKitAPI::TEST):
427         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
428         (testWebKitSettings): Site specific quirks setting is now enabled
429         by default.
430
431 2014-06-10  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
432
433         Unreviewed, update my list of email addresses in contributors.json.
434
435         * Scripts/webkitpy/common/config/contributors.json:
436
437 2014-06-10  Simon Fraser  <simon.fraser@apple.com>
438
439         Always switch to an sRGB screen color profile when running tests
440         https://bugs.webkit.org/show_bug.cgi?id=133712
441
442         Reviewed by Tim Horton.
443         
444         Switch the screen color profile to sRGB when running tests, because even ref
445         tests need the screen to use the correct color profile.
446
447         * DumpRenderTree/mac/LayoutTestHelper.m:
448         (installLayoutTestColorProfile):
449         * Scripts/webkitpy/port/mac.py:
450         (MacPort.start_helper):
451
452 2014-06-10  Martin Hodovan  <mhodovan@partner.samsung.com>
453
454         [EFL] Bump EFL libraries to 1.9
455         https://bugs.webkit.org/show_bug.cgi?id=125479
456
457         Reviewed by Gyuyoung Kim.
458
459         Based on the work of Ryuan Choi <ryuan.choi@samsung.com>
460         and László Langó <llango.u-szeged@partner.samsung.com>.
461
462         * ImageDiff/CMakeLists.txt:
463         * MiniBrowser/efl/CMakeLists.txt:
464         * efl/install-dependencies:
465         * efl/jhbuild.modules:
466         * efl/jhbuildrc:
467
468 2014-06-10  David Farler  <dfarler@apple.com>
469
470         old-run-webkit-tests: Create CoreSimulator device on demand and find it by name
471         https://bugs.webkit.org/show_bug.cgi?id=133663
472
473         Reviewed by David Kilzer.
474
475         * Scripts/old-run-webkit-tests:
476         (installAndLaunchDumpToolAppUsingNotification):
477         - Remove obsolete notification keys
478         - Key off of mandatory device UDID (a UUID)
479         - Create a device on demand via CoreSimulator if necessary
480         -- Grab the UDID from the created device plist.
481         * Scripts/webkitdirs.pm:
482         (iOSSimulatorDevicesPath): Added
483         (iOSSimulatorDevices): Added
484         (createiOSSimulatorDevice): Added
485         (deleteiOSSimulatorDevice): Added
486
487 2014-06-10  Víctor Manuel Jáquez Leal  <vjaquez@igalia.com>
488
489         [GTK][gtkdoc] remove -Wcast-align
490         https://bugs.webkit.org/show_bug.cgi?id=133640
491
492         Apparently gcc warns that GParamSpec is not castable to
493         GParamSpecInt64/GParamSpecUInt64/GParamSpecDouble due they are 64bit, even
494         though ARM hackers claim that those only need 4byte alignment. As long as gcc
495         behaves that way, this warning is not very useful, also they break the Debian
496         packaging.
497
498         This patch appends the compiler flag -Wno-align-cast for the gtkdoc
499         scanner compilation, thus the compiler ignores the previous
500         -Waling-cast flag.
501
502         Reviewed by Martin Robinson.
503
504         * gtk/generate-gtkdoc:
505         (get_generator_for_config):
506
507 2014-06-09  Alexey Proskuryakov  <ap@apple.com>
508
509         Disable button animations in regression tests
510         https://bugs.webkit.org/show_bug.cgi?id=133647
511         <rdar://problem/16677530>
512
513         Reviewed by Tim Horton.
514
515         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
516         (WTR::InjectedBundle::platformInitialize):
517
518 2014-06-09  Simon Fraser  <simon.fraser@apple.com>
519
520         Move scrolling-related tests to tiled-drawing/scrolling subdirectory, and minor cleanup
521         https://bugs.webkit.org/show_bug.cgi?id=133650
522
523         Reviewed by Tim Horton.
524         
525         No point checking for a Windows-style path in Cocoa code.
526
527         * WebKitTestRunner/TestInvocation.cpp:
528         (WTR::shouldUseThreadedScrolling):
529
530 2014-06-09  Simon Fraser  <simon.fraser@apple.com>
531
532         Fix more latched scrolling test flakiness and slowness
533         https://bugs.webkit.org/show_bug.cgi?id=133601
534
535         Reviewed by Brent Fulgham.
536         
537         Latched scrolling tests were flakey for two reasons. First, the EventSender
538         wheel events were async from the web to the UI process, and the resulting
539         synthetic events also async from the UI to the web process. Make them sync
540         for testing.
541         
542         Secondly, the timer-based scrolling tree commit could result in the scrolling
543         tree (specifically the frame node's notion of the scrollable area and content
544         size) not being updated before the scrolling thread starts getting wheel events.
545         Fix by having WebPage::wheelEventSyncForTesting() commit if necessary.
546         
547         Finally remove all the now-unnecessary timeouts from the tests.
548
549         * WebKitTestRunner/mac/EventSenderProxy.mm:
550         (WTR::EventSenderProxy::mouseMoveTo):
551         (WTR::EventSenderProxy::mouseScrollBy):
552         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
553
554 2014-06-09  Andrzej Badowski  <a.badowski@samsung.com>
555
556         [EFL] Add parameter to MiniBrowser to disable web security
557         https://bugs.webkit.org/show_bug.cgi?id=121095
558
559         Reviewed by Gyuyoung Kim.
560
561         -w (--web-security) commandline allows to disable/enable web security (enabled by default).
562         The reason for this is to test and debug (using, for example, MiniBrowser) scripts accessing
563         resources from other domains (cross-domain requests) such as access map location on another server.
564         Another possibility is to launch in a webkit browser local file tests that will refer to the links
565         in the http website loaded in an iframe. It will not be possible without deactivation of web security.
566
567         * MiniBrowser/efl/main.c:
568         (window_create):
569         (elm_main):
570
571 2014-06-06  Simon Fraser  <simon.fraser@apple.com>
572
573         32-bit build fix.
574
575         * WebKitTestRunner/mac/EventSenderProxy.mm:
576         (WTR::EventSenderProxy::mouseMoveTo):
577         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
578
579 2014-06-06  Simon Fraser  <simon.fraser@apple.com>
580
581         Fix builds on 10.8; -firstObject isn't declared on NSArray there.
582
583         * DumpRenderTree/mac/DumpRenderTree.mm:
584         (createWebViewAndOffscreenWindow):
585         * DumpRenderTree/mac/EventSendingController.mm:
586         (-[EventSendingController mouseScrollByX:andY:continuously:]):
587         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
588         * WebKitTestRunner/mac/EventSenderProxy.mm:
589         (WTR::EventSenderProxy::mouseScrollBy):
590         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
591
592 2014-06-06  Simon Fraser  <simon.fraser@apple.com>
593
594         Latched scrolling tests are flakey on Mavericks
595         https://bugs.webkit.org/show_bug.cgi?id=133578
596         <rdar://problem/17180591>
597
598         Reviewed by Brent Fulgham.
599         
600         The latched scrolling tests rely on synthetic mousewheel events whose coordinates can
601         be wrong on machines with more than one screen. This is because we use
602         [NSScreen mainScreen] when computing the global coordinates of the events, but
603         [NSScreen mainScreen] returns the screen with the key window, not the first screen.
604         
605         So replace calls to [NSScreen mainScreen] with [[NSScreen screens] firstObject]. Also
606         add comments clarifying why the coordinate math works (which is not obvious given
607         the events have no target window).
608         
609         Some scrolling tests also dispatched events outside the 800x600 test window, so
610         fix those tests, and add logging that will appear in test output when this happens.
611
612         * DumpRenderTree/mac/DumpRenderTree.mm:
613         (createWebViewAndOffscreenWindow):
614         * DumpRenderTree/mac/EventSendingController.mm:
615         (-[EventSendingController mouseScrollByX:andY:continuously:]):
616         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
617         * WebKitTestRunner/mac/EventSenderProxy.mm:
618         (WTR::EventSenderProxy::mouseMoveTo):
619         (WTR::EventSenderProxy::mouseScrollBy):
620         (WTR::EventSenderProxy::continuousMouseScrollBy):
621         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
622
623 2014-06-05  Carlos Alberto Lopez Perez  <clopez@igalia.com>
624
625         [GTK] run-perf-tests should run the tests inside the jhbuild shell.
626         https://bugs.webkit.org/show_bug.cgi?id=133533
627
628         Reviewed by Carlos Garcia Campos.
629
630         * Scripts/webkitpy/common/multiprocessing_bootstrap.py:
631         (run): Remove the jhbuild-wrapper wrapper from here. It should be
632         on Scripts/webkitpy/port/gtk.py.
633         * Scripts/webkitpy/port/base.py:
634         (Port.set_option): Add a set_option(name, value) function to set
635         the optparse parameter "name" to the value "value", even if the
636         parameter "name" is already initialized.
637         * Scripts/webkitpy/port/gtk.py:
638         (GtkPort.__init__): Set the default wrapper to jhbuild-wrapper.
639         If another wrapper is specified via the option "-l --wrapper=x",
640         then prepend the jhbuild-wrapper to the one specified.
641
642 2014-06-04  David Farler  <dfarler@apple.com>
643
644         Build ASan WebKit for iOS Simulator
645         https://bugs.webkit.org/show_bug.cgi?id=133489
646
647         Reviewed by Darin Adler.
648
649         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
650         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
651         - Add missing ASan LDFLAGS.
652         * asan/asan.xcconfig:
653         - Split compiler-rt linker flags for OS X and iOS Simulator
654
655 2014-06-03  Yoav Weiss  <yoav@yoav.ws>
656
657         Add myself (yoav@yoav.ws) to contributors.json
658         https://bugs.webkit.org/show_bug.cgi?id=133492
659
660         * Scripts/webkitpy/common/config/contributors.json:
661
662 2014-06-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
663
664         REGRESSION(r169092 and r169102): Skip failing JSC tests poperly on non-x86 Darwin platforms
665         https://bugs.webkit.org/show_bug.cgi?id=133149
666
667         Reviewed by Csaba Osztrogonác.
668
669         * Scripts/run-jsc-stress-tests: Added determineOS to determine the host operating system the script run on.
670
671 2014-06-02  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
672
673         Add a verbose flag to binding tests
674         https://bugs.webkit.org/show_bug.cgi?id=122303
675
676         Reviewed by Csaba Osztrogonác.
677
678         This patch will:
679         - Add a verbose keyword argument to the BindingsTests constructor,
680         - Add --no-verbose option to the run-bindigs-test.
681         Verbose mode, which is on by default, prints positive results to stdout as before.
682         When the --no-verbose option added to run-bindings-tests, positive results are not printed at all.
683
684         Original patch from Matthew Hanson <matthew_hanson@apple.com>
685
686         * Scripts/run-bindings-tests:
687         (main):
688         * Scripts/webkitpy/bindings/main.py:
689         (BindingsTests.__init__):
690         (BindingsTests.detect_changes):
691
692 2014-06-01  Ryosuke Niwa  <rniwa@webkit.org>
693
694         Rename DoYouEvenBench 0.17 to Speedometer 1.0 and add a new look.
695         https://bugs.webkit.org/show_bug.cgi?id=133455
696
697         Reviewed by Timothy Hatcher.
698
699         Since the perf. dashboard doesn't support following renamed benchmarks,
700         keep reporting Speedometer results as DoYouEvenBench results.
701
702         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
703         (_generate_results_dict):
704
705 2014-05-31  Darin Adler  <darin@apple.com>
706
707         Viewport percentage tests that resize the viewport are flaky
708         https://bugs.webkit.org/show_bug.cgi?id=133351
709
710         Reviewed by Anders Carlsson.
711
712         * DumpRenderTree/mac/DumpRenderTree.mm:
713         (sizeWebViewForCurrentTest): Added a call to reset the window origin, which
714         happens to be stored in the UI delegate object. This is part of resetting the
715         window position.
716
717         * DumpRenderTree/mac/UIDelegate.h: Store the window origin rather than storing
718         a frame rectangle. The size is stored in the size of the web view itself.
719         * DumpRenderTree/mac/UIDelegate.mm:
720         (-[UIDelegate resetWindowOrigin]): Added.
721         (-[UIDelegate webView:setFrame:]): Changed to set the size of the web view. The
722         old version would store the frame, but not resize the web view!
723         (-[UIDelegate webViewFrame:]): Get the size from the web view.
724
725         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
726         (WTR::PlatformWebView::setWindowFrame): Added code to resize the web view.
727
728         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
729         (WTR::PlatformWebView::resizeTo): Added a comment about missing code to resize
730         the window.
731
732         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
733         (WTR::PlatformWebView::resizeTo): Changed this to call setWindowFrame so the
734         window gets resized too, not just the web view.
735         (WTR::PlatformWebView::setWindowFrame): Added code to set the size of the web view.
736
737         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
738         (WTR::PlatformWebView::resizeTo): Changed this to call setWindowFrame so the
739         window gets resized too, not just the web view.
740         (WTR::PlatformWebView::setWindowFrame): Added code to set the size of the web view.
741
742 2014-05-30  Michael Saboff  <msaboff@apple.com>
743
744         Change run-jsc-stress-tests to not resolve jsc path locally when creating a bundle
745         https://bugs.webkit.org/show_bug.cgi?id=133409
746
747         Reviewed by Filip Pizlo.
748
749         Handle creating a tarball the same way as running remote when processing
750         paths in prepareBundle.
751
752         * Scripts/run-jsc-stress-tests:
753
754 2014-05-30  Mario Sanchez Prada  <mario.prada@samsung.com>
755
756         [ATK] Deprecate usage of logAccessibilityEvents() in layout tests
757         https://bugs.webkit.org/show_bug.cgi?id=132280
758
759         Reviewed by Chris Fleizach.
760
761         Remove implementation of logAccessibilityEvents() for ATK based
762         ports, as this has proved to be a flaky method of checking that
763         ATK events are being properly emitted. Instead, it's better to use
764         the addNotificationListener() functions and provide a JS callback
765         to check that the right events are being emmitted from the tests.
766
767         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
768         (WTR::AccessibilityController::logAccessibilityEvents): Replaced
769         with dummy implementation.
770         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
771         (WTR::AccessibilityNotificationHandler::logAccessibilityEvents): Removed
772
773 2014-05-30  Mario Sanchez Prada  <mario.prada@samsung.com>
774
775         [ATK] Deprecate usage of logAccessibilityEvents() in layout tests
776         https://bugs.webkit.org/show_bug.cgi?id=132280
777
778         Rubber stamped by Carlos Garcia Campos.
779
780         Fix two small issues with previous patch (r169483), that caused some tests to break.
781
782         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
783         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Removed
784         duplicated entry.
785         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
786         (WTR::AccessibilityUIElement::setSelectedTextRange): Fix boolean condition.
787
788 2014-05-30  Jarek Czekalski  <jarekczek@poczta.onet.pl>
789
790         [ATK] Added new accessibility signal: text-caret-moved.
791         Make AccessibilityUIElement.setSelectedTextRange work
792         as atk_text_set_caret_offset when given offset == 0.
793         https://bugs.webkit.org/show_bug.cgi?id=132527
794
795         Reviewed by Mario Sanchez Prada.
796
797         text-caret-moved signal in accessibilityController is needed to
798         implement tests from Tools/TestWebKitAPI/Tests/WebKitGtk/testatk.c
799         as LayoutTests. Add the signal to the controller.
800
801         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
802         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
803         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
804         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
805         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
806         (setSelectedTextRange): Change return type to bool.
807         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
808         (setSelectedTextRange): Call atk_text_set_caret_offset and return bool.
809         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
810         (axObjectEventListener): Add notification name AXTextCaretMoved, allow
811         for extra arguments passed to handler and use it for text-caret-moved offset.
812         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks):
813         Connect callback to new listener for ATK:AtkText:text-caret-moved.
814         Refactor so that failures be reported.
815         Initialize atk interfaces before trying to connect to them, see
816         https://bugzilla.gnome.org/show_bug.cgi?id=729922
817         (WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks):
818         Simplify code by using a vector in place of dozen variables.
819         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
820         Comment about not synchronizing with accessibilityController.
821
822 2014-05-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
823
824         [GTK] Add a WebKit2 Performance bot.
825         https://bugs.webkit.org/show_bug.cgi?id=132862
826
827         Reviewed by Csaba Osztrogonác.
828
829         This adds a GTK WebKit2 perf bot.
830
831         * BuildSlaveSupport/build.webkit.org-config/config.json:
832
833 2014-05-29  Dan Bernstein  <mitz@apple.com>
834
835         Fixed the WebKitTestRunner build after r169452.
836
837         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
838         (WTR::InjectedBundle::initialize):
839
840 2014-05-28  Gwang Yoon Hwang  <yoon@igalia.com>
841
842         Unreviewed. Update my email addresses in contributors.json.
843
844         * Scripts/webkitpy/common/config/contributors.json:
845
846 2014-05-27  Jon Honeycutt  <jhoneycutt@apple.com>
847
848         Need an API test for bug #133193 (r169315)
849         <https://bugs.webkit.org/show_bug.cgi?id=133324>
850
851         This adds an API test that ensures that calling "stop loading" during a
852         "did fail provisional load" callback doesn't crash.
853
854         Reviewed by Andy Estes.
855
856         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
857         Add new files to project.
858
859         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad.cpp: Added.
860         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
861         If the message is the "test done" message, record that.
862         (TestWebKitAPI::setInjectedBundleClient):
863         Register a function for the "did receive message from injected bundle"
864         callback.
865         (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame):
866         Assert that we received the message from the injected bundle, and set
867         'done' to finish the test.
868         (TestWebKitAPI::TEST):
869         Create a WebView, register a page loader client for the "did fail
870         provisional load" callback, and load a non-existent resource.
871
872         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad_bundle.cpp: Added.
873         (TestWebKitAPI::StopLoadingDuringDidFailProvisionalLoadTest::StopLoadingDuringDidFailProvisionalLoadTest):
874         (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrameCallback):
875         Tell the StopLoadingDuringDidFailProvisionalLoadTest object that the
876         provisional load failed.
877         (TestWebKitAPI::StopLoadingDuringDidFailProvisionalLoadTest::didCreatePage):
878         Register a page loader client for the "did fail provisional load"
879         callback.
880         (TestWebKitAPI::StopLoadingDuringDidFailProvisionalLoadTest::didFailProvisionalLoad):
881         Call WKBundlePageStopLoading() during the callback. This not crashing
882         is what we're ensuring with this test.
883
884 2014-05-28  Carlos Garcia Campos  <cgarcia@igalia.com>
885
886         [GTK] Make it possible to build with FTL enabled
887         https://bugs.webkit.org/show_bug.cgi?id=133219
888
889         Reviewed by Philippe Normand.
890
891         * gtk/jhbuild-optional.modules: Add llvm from svn and build the
892         same revision than mac.
893
894 2014-05-27  Michael Saboff  <msaboff@apple.com>
895
896         REGRESSION(r169265): sh: line 0: cd: ../.vm
897         https://bugs.webkit.org/show_bug.cgi?id=133242
898
899         Rubber stamped by Oliver Hunt.
900
901         Changed runAndMonitorTestRunnerCommand() to pass mysys as a string instead of an
902         array since the command may contain character escapes that don't work with the
903         array form of system().
904
905         * Scripts/run-jsc-stress-tests:
906
907 2014-05-27  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
908
909         [EFL] Change download url of freetype6
910         https://bugs.webkit.org/show_bug.cgi?id=133303
911
912         Reviewed by Csaba Osztrogonác.
913
914         freetype6 tarball isn't downloaded in Korea. So, we need to
915         change the url for now.
916
917         * efl/jhbuild.modules:
918
919 2014-05-27  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
920
921         Remove BLOB guards
922         https://bugs.webkit.org/show_bug.cgi?id=132863
923
924         Reviewed by Csaba Osztrogonác.
925
926         * Scripts/webkitperl/FeatureList.pm:
927
928 2014-05-27  Alberto Garcia  <berto@igalia.com>
929
930         Remove leftover comment from r165182.
931
932         Rubber stamped by Carlos Garcia Campos.
933
934         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
935
936 2014-05-26  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
937
938         [EFL] Add LLVM as optional jhbuild module for FTL developers
939         https://bugs.webkit.org/show_bug.cgi?id=133216
940
941         Reviewed by Gyuyoung Kim.
942
943         * efl/jhbuild.modules:
944
945 2014-05-26  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
946
947         Fix test failures on python test
948         https://bugs.webkit.org/show_bug.cgi?id=133297
949
950         Reviewed by Dirk Schulze.
951
952         2 tests are failing because of unbounded local variable reference in test_importer.py.
953
954         * Scripts/webkitpy/w3c/test_importer.py: Move local variable declaration to top.
955         (TestImporter.import_tests):
956
957 2014-05-26  Carlos Alberto Lopez Perez  <clopez@igalia.com>
958
959         [GTK] GObject DOM bindings API break test fails in the tests bots
960         https://bugs.webkit.org/show_bug.cgi?id=133211
961
962         Reviewed by Martin Robinson.
963
964         When generating the built product archive on platform GTK, we need
965         to copy also the file gtkdoc-webkitdom.cfg and the directory
966         DerivedSources/webkitdom.
967
968         * BuildSlaveSupport/built-product-archive:
969         (archiveBuiltProduct):
970
971 2014-05-26  Commit Queue  <commit-queue@webkit.org>
972
973         Unreviewed, rolling out r169122.
974         https://bugs.webkit.org/show_bug.cgi?id=133288
975
976         Broke CJK font fallback (Requested by ap on #webkit).
977
978         Reverted changeset:
979
980         "[Mac] WebProcess doesn't follow localization of UI process
981         when run as a service"
982         https://bugs.webkit.org/show_bug.cgi?id=133126
983         http://trac.webkit.org/changeset/169122
984
985 2014-05-26  Carlos Garcia Campos  <cgarcia@igalia.com>
986
987         [GTK] WebProcess leaked when closing pages with network process enabled
988         https://bugs.webkit.org/show_bug.cgi?id=129684
989
990         Reviewed by Anders Carlsson.
991
992         Enable the test to check that web processes finish when the web
993         view is destroyed.
994
995         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
996
997 2014-05-26  Carlos Garcia Campos  <cgarcia@igalia.com>
998
999         REGRESSION(r164632): [GTK] Crash in generate-gtkdoc when rebasing docs
1000         https://bugs.webkit.org/show_bug.cgi?id=133279
1001
1002         Reviewed by Philippe Normand.
1003
1004         generator.saw_warnings is only set by GTKDoc::generate(), so it
1005         should only be used after generate.
1006
1007         * gtk/generate-gtkdoc:
1008         (generate_documentation_for_config): Do not check
1009         generator.saw_warnings again, simply return the value returned by
1010         generate_doc() which is generator.saw_warnings. When rebasing,
1011         returns always False since there aren't warnings.
1012
1013 2014-05-26  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1014
1015         W3C test importer should catch exceptions coming from HTML/CSS conversion
1016         https://bugs.webkit.org/show_bug.cgi?id=133176
1017
1018         Reviewed by Darin Adler.
1019
1020         Exceptions raised when converting HTML/CSS are caught.
1021         Files for which conversion failed are still copied to the target directory.
1022         Each individual conversion failure is logged.
1023         Total conversion failure number is logged at the end of the import process.
1024
1025         * Scripts/webkitpy/w3c/test_importer.py:
1026         (TestImporter.import_tests):
1027
1028 2014-05-26  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1029
1030         [GTK] Allow to run the tests on the native X display.
1031         https://bugs.webkit.org/show_bug.cgi?id=133157
1032
1033         Reviewed by Benjamin Poulain.
1034
1035         This adds a new driver (xorgdriver) that runs the tests on the
1036         X display referenced by the environment variable DISPLAY.
1037
1038         This new driver will be activated only if the environment variable
1039         USE_NATIVE_XDISPLAY is defined. This can be used both for layout
1040         tests and performance tests.
1041
1042         This patch also makes the script run-perf-tests to check the
1043         system dependencies before starting the tests. Previously this
1044         was not checked, and if the system dependencies were not met,
1045         the script tried to execute the tests anyway, causing massive
1046         failures. For example, if you had Xvfb not installed and you
1047         wanted to use the Xvfb driver (the default on GTK and EFL),
1048         run-perf-tests would not abort.
1049
1050         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1051         (PerfTestsRunner._parse_args): Check the system dependencies of
1052         the driver before starting the tests.
1053         * Scripts/webkitpy/port/driver.py:
1054         (Driver): Implement generic check_driver method.
1055         (Driver.check_driver):
1056         (Driver.check_driver.implementation):
1057         * Scripts/webkitpy/port/gtk.py:
1058         (GtkPort._driver_class): Check for environment variable
1059         USE_NATIVE_XDISPLAY to decide if the Xorg driver should be used.
1060         * Scripts/webkitpy/port/xorgdriver.py: Added.
1061         (XorgDriver): Implement Xorg driver.
1062         (XorgDriver.check_driver):
1063         (XorgDriver._start):
1064
1065 2014-05-26  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1066
1067         REGRESSION(r166798): [GTK] [EFL] kill-old-processes should not kill dbus-daemon
1068         https://bugs.webkit.org/show_bug.cgi?id=133215
1069
1070         Reviewed by Csaba Osztrogonác.
1071
1072         This reverts r166798.
1073
1074         * BuildSlaveSupport/kill-old-processes:
1075         (main):
1076
1077 2014-05-26  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
1078
1079         [EFL] Turn on ENABLE_CSS_FILTERS in build script
1080         https://bugs.webkit.org/show_bug.cgi?id=133278
1081
1082         Reviewed by Gyuyoung Kim.
1083
1084         * Scripts/webkitperl/FeatureList.pm: Add a build script condition missing in r169172.
1085
1086 2014-05-26  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1087
1088         run-javascriptcore-tests warning fix on non Mac platforms
1089         https://bugs.webkit.org/show_bug.cgi?id=133260
1090
1091         Reviewed by Darin Adler.
1092
1093         * Scripts/webkitdirs.pm:
1094         (argumentsForConfiguration):
1095
1096 2014-05-23  Michael Saboff  <msaboff@apple.com>
1097
1098         REGRESSION(r169265): sh: line 0: cd: ../.vm
1099         https://bugs.webkit.org/show_bug.cgi?id=133242
1100
1101         Rubber stamped by Geoffrey Garen.
1102
1103         Added missing shell escapes '\' required as part of previous fix.
1104
1105         * Scripts/run-jsc-stress-tests:
1106
1107 2014-05-23  Ryosuke Niwa  <rniwa@webkit.org>
1108
1109         Revert the erroneous change committed in r169286.
1110
1111         * Scripts/webkitpy/performance_tests/perftest.py:
1112         (PerfTest._run_with_driver):
1113
1114 2014-05-23  Geoffrey Garen  <ggaren@apple.com>
1115
1116         run-perf-tests should ignore whitespace lines when snarfing test output
1117         https://bugs.webkit.org/show_bug.cgi?id=133238
1118
1119         Reviewed by Ryosuke Niwa.
1120
1121         Required for PerformanceTests/Canvas/terrain.html.
1122
1123         * Scripts/webkitpy/performance_tests/perftest.py:
1124         (PerfTest._run_with_driver):
1125         (PerfTest):
1126
1127 2014-05-23  Michael Saboff  <msaboff@apple.com>
1128
1129         REGRESSION (r169241) Crash running run-jsc-stress-tests on EFL ARM
1130         https://bugs.webkit.org/show_bug.cgi?id=133223
1131
1132         Reviewed by Geoffrey Garen.
1133
1134         Change runAndMonitorTestRunnerCommand() to convert the *cmd argument to a
1135         string before calling IO.popen() to work with older versions of ruby.
1136         Changed the remote path in runShellTestRunner to quote the command
1137         string we want to run via ssh so that it will work correctly with array
1138         to string conversion needed for popen.
1139
1140         * Scripts/run-jsc-stress-tests:
1141
1142 2014-05-23  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
1143
1144         Remove 'css-shaders' option from the build-webkit
1145         https://bugs.webkit.org/show_bug.cgi?id=133212
1146
1147         Reviewed by Daniel Bates.
1148
1149         Original CSS shaders removed in r162644.
1150
1151         * Scripts/webkitperl/FeatureList.pm:
1152
1153 2014-05-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1154
1155         [GTK] GObject DOM bindings API break test should fail in the bots when the command fails to run
1156         https://bugs.webkit.org/show_bug.cgi?id=133209
1157
1158         Reviewed by Sergio Villar Senin.
1159
1160         Return FAILURE when the command failed to run.
1161
1162         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1163         (RunGtkWebKitGObjectDOMBindingsAPIBreakTests.evaluateCommand):
1164
1165 2014-05-23  Alberto Garcia  <berto@igalia.com>
1166
1167         [GTK] Install libharfbuzz-dev in Tools/gtk/install-dependencies
1168         https://bugs.webkit.org/show_bug.cgi?id=133210
1169
1170         Reviewed by Carlos Garcia Campos.
1171
1172         * gtk/install-dependencies:
1173
1174 2014-05-22  Benjamin Poulain  <bpoulain@apple.com>
1175
1176         Add Yusuke Suzuki to the list of contributors (for real)
1177
1178         Wrong section...
1179
1180         * Scripts/webkitpy/common/config/contributors.json:
1181
1182 2014-05-22  Benjamin Poulain  <bpoulain@apple.com>
1183
1184         Add Yusuke Suzuki to the list of contributors
1185
1186         * Scripts/webkitpy/common/config/contributors.json:
1187
1188 2014-05-22  Michael Saboff  <msaboff@apple.com>
1189
1190         Eliminate n/total progress update from run-jsc-stress-tests output to file
1191         https://bugs.webkit.org/show_bug.cgi?id=133191
1192
1193         Reviewed by Geoffrey Garen.
1194
1195         Changed progressMeter setting to be based on stdout being a tty instead of
1196         stdin.  Unified the processing of output from the shell runner to match the
1197         same processing as is used by the makefile runner.  As part of this, the 
1198         shell runner script was simplified.  It now forwards the output of each
1199         test_script just like the Makefile and doesn't provide its own progress.
1200
1201         * Scripts/jsc-stress-test-helpers/shell-runner.sh:
1202         * Scripts/run-jsc-stress-tests:
1203
1204 2014-05-22  Michael Saboff  <msaboff@apple.com>
1205
1206         Add option to run-jsc-stress-tests to use installed jsc
1207         https://bugs.webkit.org/show_bug.cgi?id=133102
1208
1209         Reviewed by Geoffrey Garen.
1210
1211         Added --no-copy option to not copy a JavaScriptCore framework, but use the one
1212         provied with the --jsc option.
1213
1214         * Scripts/run-jsc-stress-tests:
1215
1216 2014-05-21  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
1217
1218         [EFL] Add include path of compact_unwind_encoding.h if FTL JIT is enabled
1219         https://bugs.webkit.org/show_bug.cgi?id=132907
1220
1221         Reviewed by Gyuyoung Kim.
1222
1223         We need the mach-o/compact_unwind_encoding.h header from libc++abi-dev package
1224         in JavaScriptCore/ftl/FTLUnwindInfo.cpp when FTL JIT is enabled.
1225
1226         * efl/install-dependencies:
1227
1228 2014-05-21  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1229
1230         REGRESSION(r169092): It broke run-jsc-stress tests on non Mac platforms
1231         https://bugs.webkit.org/show_bug.cgi?id=133145
1232
1233         Reviewed by Csaba Osztrogonác.
1234
1235         * Scripts/run-jsc-stress-tests:
1236
1237 2014-05-20  Alexey Proskuryakov  <ap@apple.com>
1238
1239         [Mac] WebProcess doesn't follow localization of UI process when run as a service
1240         https://bugs.webkit.org/show_bug.cgi?id=133126
1241         <rdar://problem/13396515>
1242         <rdar://problem/16561084>
1243
1244         Reviewed by Sam Weinig and Tim Horton.
1245
1246         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
1247         (WTR::InjectedBundle::platformInitialize): It was too late to override language
1248         here, and it's not necessary any more. Keeping the code for older OS versions in
1249         case it did have effect in some code paths.
1250
1251 2014-05-19  David Farler  <dfarler@apple.com>
1252
1253         Move WebKitTestRunner to std::unique_ptr
1254         https://bugs.webkit.org/show_bug.cgi?id=133081
1255
1256         Reviewed by Daniel Bates.
1257
1258         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1259         (WTR::InjectedBundle::didCreatePage):
1260         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1261         * WebKitTestRunner/TestController.cpp:
1262         (WTR::TestController::initialize):
1263         (WTR::TestController::createWebViewWithOptions):
1264         (WTR::TestController::resetStateToConsistentValues):
1265         (WTR::TestController::runTest):
1266         * WebKitTestRunner/TestController.h:
1267         * WebKitTestRunner/TestInvocation.cpp:
1268         * WebKitTestRunner/TestInvocation.h:
1269         * WebKitTestRunner/WorkQueueManager.cpp:
1270         (WTR::WorkQueueManager::processWorkQueue):
1271         (WTR::WorkQueueManager::enqueue):
1272         * WebKitTestRunner/WorkQueueManager.h:
1273
1274 2014-05-20  Carlos Garcia Campos  <cgarcia@igalia.com>
1275
1276         [GTK] WebKitWebPage::send-request always pass a valid pointer for redirected response
1277         https://bugs.webkit.org/show_bug.cgi?id=133119
1278
1279         Reviewed by Sergio Villar Senin.
1280
1281         Check that redirect response parameter of
1282         WebKitWebPage::send-request signal is NULL when not redirecting
1283         and a valid WebKitURIResponse object when redirecting.
1284
1285         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
1286         (testWebResourceSendRequest):
1287         (serverCallback):
1288         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1289         (sendRequestCallback):
1290
1291 2014-05-20  Carlos Garcia Campos  <cgarcia@igalia.com>
1292
1293         REGRESSION(CMAKE): [GTK] Several WebKit2GTK+ unit tests are no longer built
1294         https://bugs.webkit.org/show_bug.cgi?id=133117
1295
1296         Reviewed by Philippe Normand.
1297
1298         Bring back missing tests to the build.
1299
1300         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
1301
1302 2014-05-19  Filip Pizlo  <fpizlo@apple.com>
1303
1304         Take care of some ARM64 test failures
1305         https://bugs.webkit.org/show_bug.cgi?id=133090
1306
1307         Reviewed by Geoffrey Garen.
1308
1309         * Scripts/run-jsc-stress-tests: Make it easier to conditionally skip things.
1310
1311 2014-05-19  David Kilzer  <ddkilzer@apple.com>
1312
1313         [iOS] REGRESSION (r168910): webkitdirs.pm: Be more forgiving when parsing --sdk, --device and --sim
1314         <http://webkit.org/b/133089>
1315
1316         Reviewed by Darin Adler.
1317
1318         * Scripts/webkitdirs.pm:
1319         (determineXcodeSDK): If both '--sdk SDKROOT' and '--sim' are
1320         specified on the command line, we would remove the '--sdk'
1321         arguments, but leave '--sim', potentially passing it along to
1322         xcodebuild causing a build failure.  This happens when
1323         'old-run-webkit-tests --release --sim' invokes
1324         build-dumprendertree when DumpRenderTree hasn't been built yet.
1325
1326 2014-05-19  David Farler  <dfarler@apple.com>
1327
1328         Dashboard: OpenSource revision key changed from WebKitOpenSource to WebKit
1329         https://bugs.webkit.org/show_bug.cgi?id=133086
1330
1331         Reviewed by Daniel Bates.
1332
1333         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1334
1335 2014-05-19  David Kilzer  <ddkilzer@apple.com>
1336
1337         REGRESSION (r169042): Fix run-api-tests on Mountain Lion
1338         <http://webkit.org/b/132954>
1339
1340         * Scripts/webkitdirs.pm:
1341         (sharedCommandLineOptionsUsage): Remove the prototype for the
1342         subroutine.  Older perls don't like the "+@" syntax.
1343
1344 2014-05-19  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1345
1346         run-javascriptcore-tests should sort the list of failing stress tests
1347         https://bugs.webkit.org/show_bug.cgi?id=132989
1348
1349         Reviewed by Csaba Osztrogonác.
1350
1351         * Scripts/run-javascriptcore-tests:
1352
1353 2014-05-19  David Kilzer  <ddkilzer@apple.com>
1354
1355         webkitdirs.pm: Add setupMacWebKitEnvironment() to set __XPC_DYLD_FRAMEWORK_PATH consistently
1356         <http://webkit.org/b/132954>
1357
1358         Reviewed by Darin Adler.
1359
1360         Extract code into setupMacWebKitEnvironment() for setting up
1361         common environment variables so it may be shared.  Sets
1362         __XPC_DYLD_FRAMEWORK_PATH consistently and adds support for
1363         using guardmalloc to some scripts.
1364
1365         Also adds support for parsing shared (common) command-line
1366         switches, initially just -g|--guard-malloc.
1367
1368         * Scripts/bisect-builds: Add -g|--guard-malloc support by using
1369         sharedCommandLineOptions() and sharedCommandLineOptionsUsage().
1370         (mountAndRunNightly): Call setupMacWebKitEnvironment().  Use a
1371         local copy of %ENV when launching Safari so we don't have to
1372         restore variables.
1373
1374         * Scripts/run-api-tests: Add -g|--guard-malloc support by using
1375         sharedCommandLineOptions() and sharedCommandLineOptionsUsage().
1376         Check result of GetOptions() to catch invalid command-line
1377         switches.
1378         (runTest): Use a local copy of %ENV when running tests so we
1379         don't have to restore variables.
1380         (prepareEnvironmentForRunningTestTool): Call
1381         setupMacWebKitEnvironment().
1382
1383         * Scripts/run-pageloadtest: Add -g|--guard-malloc support by
1384         using sharedCommandLineOptions() and
1385         sharedCommandLineOptionsUsage().  Call
1386         setupMacWebKitEnvironment().
1387
1388         * Scripts/webkitdirs.pm:
1389         (sharedCommandLineOptions): Return array of common switches to
1390         pass to Getopt::Long::GetOptions().
1391         (sharedCommandLineOptionsUsage): Return formatted string of
1392         common switches for printing usage help text.
1393         (setUpGuardMallocIfNeeded): Support using '-g' for enabling
1394         guardmalloc.
1395         (printHelpAndExitForRunAndDebugWebKitAppIfNeeded): Ditto.
1396         (setupMacWebKitEnvironment): Extracted from runMacWebKitApp()
1397         and changed not to clobber DYLD_FRAMEWORK_PATH if already set.
1398         (runMacWebKitApp): Call setupMacWebKitEnvironment().  Use a
1399         local copy of %ENV when launching Safari so we don't have to
1400         restore variables.
1401         (execMacWebKitAppForDebugging): Call
1402         setupMacWebKitEnvironment().
1403
1404 2014-05-18  Rik Cabanier  <cabanier@adobe.com>
1405
1406         support for navigator.hardwareConcurrency
1407         https://bugs.webkit.org/show_bug.cgi?id=132588
1408
1409         Reviewed by Filip Pizlo.
1410
1411         * Scripts/webkitperl/FeatureList.pm:
1412
1413 2014-05-18  Anders Carlsson  <andersca@apple.com>
1414
1415         Implement Navigations for all methods declared returning one
1416         https://bugs.webkit.org/show_bug.cgi?id=133048
1417         <rdar://problem/16830064>
1418
1419         Reviewed by Sam Weinig.
1420
1421         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
1422         Import WebKit.h.
1423         
1424         * MiniBrowser/mac/WK2BrowserWindowController.m:
1425         (-[WK2BrowserWindowController webView:didStartProvisionalNavigation:]):
1426         (-[WK2BrowserWindowController webView:didReceiveServerRedirectForProvisionalNavigation:]):
1427         (-[WK2BrowserWindowController webView:didFailProvisionalNavigation:withError:]):
1428         (-[WK2BrowserWindowController webView:didCommitNavigation:]):
1429         (-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]):
1430         (-[WK2BrowserWindowController webView:didFailNavigation:withError:]):
1431         Print out the navigations.
1432
1433 2014-05-17  Zalan Bujtas  <zalan@apple.com>
1434
1435         Subpixel rendering: Add subpixelCSSOMElementMetricsEnabled to WK1 WebPreferences.
1436         https://bugs.webkit.org/show_bug.cgi?id=133029
1437
1438         Reviewed by Simon Fraser.
1439
1440         Added a menu item to toggle subpixelCSSOMElementMetricsEnabled's value. However
1441         toggling it on a WK2 window needs restart.
1442         Adding dynamic toggle to WK2 requires a WebPreferences SPI. It's not worth cluttering
1443         the WebPreferences just to support this temporary toggle.
1444
1445         * MiniBrowser/mac/BrowserWindowController.h:
1446         * MiniBrowser/mac/MainMenu.xib:
1447         * MiniBrowser/mac/WK1BrowserWindowController.m:
1448         (-[WK1BrowserWindowController validateMenuItem:]):
1449         (-[WK1BrowserWindowController isSubpixelCSSOMElementMetricsEnabled]):
1450         (-[WK1BrowserWindowController toggleSubpixelCSSOMElementMetricsEnabled:]):
1451         * MiniBrowser/mac/WK2BrowserWindowController.m:
1452         (-[WK2BrowserWindowController validateMenuItem:]):
1453         (-[WK2BrowserWindowController isSubpixelCSSOMElementMetricsEnabled]):
1454         (-[WK2BrowserWindowController toggleSubpixelCSSOMElementMetricsEnabled:]):
1455
1456 2014-05-17  Anders Carlsson  <andersca@apple.com>
1457
1458         Replace WKContextSetDatabaseDirectory with two WKContextConfiguration parameters
1459         https://bugs.webkit.org/show_bug.cgi?id=133033
1460         <rdar://problem/16830143>
1461
1462         Reviewed by Sam Weinig.
1463
1464         Set up the WebSQL and IndexedDB directories.
1465
1466         * WebKitTestRunner/TestController.cpp:
1467         (WTR::TestController::initialize):
1468
1469 2014-05-16  Martin Hock  <mhock@apple.com>
1470
1471         MemoryCache::addImageToCache should return the result of add().
1472         https://bugs.webkit.org/show_bug.cgi?id=132928
1473         <rdar://problem/16651547>
1474
1475         Reviewed by Alexey Proskuryakov.
1476
1477         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
1478         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1479         * TestWebKitAPI/Tests/ios/MemoryCacheAddImageToCacheIOS.mm: Added.
1480         (TestWebKitAPI::TEST):
1481
1482 2014-05-15  David Farler  <dfarler@apple.com>
1483
1484         old-run-webkit-tests: allow specifying a simulator app path
1485         https://bugs.webkit.org/show_bug.cgi?id=132975
1486
1487         Reviewed by Anders Carlsson.
1488
1489         * Scripts/old-run-webkit-tests:
1490         (openIPhoneSimulator):
1491         Add new --simulator-app command line parameter for specifying the
1492         absolute path to the simulator app to launch before starting a
1493         session.
1494
1495 2014-05-16  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1496
1497         [webkitpy] In case of multiple bug rollout, all bugs should be reopened, not only the oldest one
1498         https://bugs.webkit.org/show_bug.cgi?id=131363
1499
1500         Reviewed by Csaba Osztrogonác.
1501
1502         * Scripts/webkitpy/common/checkout/checkout_mock.py:
1503         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
1504         (MockBugzilla):
1505         * Scripts/webkitpy/tool/commands/download_unittest.py:
1506         (test_create_rollout_multiple_revision_with_one_resolved):
1507         (test_create_rollout_multiple_resolved):
1508         (test_rollout_two_revisions):
1509         (test_rollout_multiple_revisions):
1510         (test_rollout_multiple_revisions_with_a_missing_bug_id):
1511         * Scripts/webkitpy/tool/steps/createbug.py:
1512         (CreateBug.run):
1513         * Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
1514         (ReopenBugAfterRollout.run):
1515
1516 2014-05-16  Martin Hodovan  <mhodovan.u-szeged@partner.samsung.com>
1517
1518         [WK2] Change the remaining framework includes from WebKit2 to WebKit
1519         https://bugs.webkit.org/show_bug.cgi?id=132956
1520
1521         Reviewed by Sam Weinig.
1522
1523         * MiniBrowser/MiniBrowserWebProcessPlugIn.h:
1524         * MiniBrowser/mac/AppDelegate.m:
1525         * MiniBrowser/mac/WK2BrowserWindowController.m:
1526         * TestWebKitAPI/InjectedBundleController.h:
1527         * TestWebKitAPI/InjectedBundleMain.cpp:
1528         * TestWebKitAPI/JavaScriptTest.cpp:
1529         * TestWebKitAPI/PlatformUtilities.h:
1530         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
1531         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
1532         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp:
1533         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
1534         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive.cpp:
1535         (TestWebKitAPI::TEST):
1536         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive_Bundle.cpp:
1537         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewRestoreZoomAndScrollBackForward.cpp:
1538         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp:
1539         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
1540         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
1541         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
1542         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp:
1543         * TestWebKitAPI/Tests/WebKit2/DidNotHandleKeyDown.cpp:
1544         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
1545         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
1546         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
1547         * TestWebKitAPI/Tests/WebKit2/EphemeralSessionPushStateNoHistoryCallback.cpp:
1548         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
1549         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
1550         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
1551         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
1552         * TestWebKitAPI/Tests/WebKit2/ForceRepaint.cpp:
1553         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
1554         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
1555         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
1556         * TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback.cpp:
1557         * TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback_Bundle.cpp:
1558         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
1559         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp:
1560         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
1561         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic_Bundle.cpp:
1562         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest.cpp:
1563         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest_Bundle.cpp:
1564         * TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins.cpp:
1565         * TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins_Bundle.cpp:
1566         * TestWebKitAPI/Tests/WebKit2/LayoutMilestonesWithAllContentInFrame.cpp:
1567         * TestWebKitAPI/Tests/WebKit2/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
1568         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback.cpp:
1569         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback_Bundle.cpp:
1570         * TestWebKitAPI/Tests/WebKit2/LoadPageOnCrash.cpp:
1571         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp:
1572         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails.cpp:
1573         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails_Bundle.cpp:
1574         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
1575         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages_Bundle.cpp:
1576         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
1577         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames_Bundle.cpp:
1578         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout_Bundle.cpp:
1579         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
1580         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
1581         * TestWebKitAPI/Tests/WebKit2/ParentFrame.cpp:
1582         * TestWebKitAPI/Tests/WebKit2/ParentFrame_Bundle.cpp:
1583         * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications.mm:
1584         * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications_Bundle.cpp:
1585         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
1586         * TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp:
1587         * TestWebKitAPI/Tests/WebKit2/ReloadPageAfterCrash.cpp:
1588         * TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp:
1589         * TestWebKitAPI/Tests/WebKit2/ResizeWindowAfterCrash.cpp:
1590         * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:
1591         * TestWebKitAPI/Tests/WebKit2/SeccompFilters.cpp:
1592         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem.cpp:
1593         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem_Bundle.cpp:
1594         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
1595         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
1596         * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp:
1597         * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:
1598         * TestWebKitAPI/Tests/WebKit2/WebArchive_Bundle.cpp:
1599         * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp:
1600         * TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent_Bundle.cpp:
1601         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
1602         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks_Bundle.cpp:
1603         * TestWebKitAPI/Tests/WebKit2/mac/EditorCommands.mm:
1604         * TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor.mm:
1605         * TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor_Bundle.mm:
1606         * TestWebKitAPI/Tests/WebKit2/mac/GetPIDAfterAbortedProcessLaunch.cpp:
1607         * TestWebKitAPI/Tests/WebKit2/mac/WeakObjCPtr.mm:
1608         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
1609         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
1610         * TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp:
1611         * TestWebKitAPI/Tests/WebKit2/win/TranslateMessageGeneratesWMChar.cpp:
1612         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
1613         * TestWebKitAPI/Tests/WebKit2/win/WMPrint.cpp:
1614         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
1615         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
1616         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme_Bundle.cpp:
1617         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
1618         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
1619         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing_Bundle.cpp:
1620         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
1621         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm:
1622         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
1623         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
1624         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
1625         * TestWebKitAPI/config.h:
1626         * TestWebKitAPI/efl/PlatformWebView.cpp:
1627         * TestWebKitAPI/mac/JavaScriptTestMac.mm:
1628         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
1629         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
1630         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
1631         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
1632         * WebKitTestRunner/EventSenderProxy.h:
1633         * WebKitTestRunner/GeolocationProviderMock.cpp:
1634         * WebKitTestRunner/GeolocationProviderMock.h:
1635         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
1636         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1637         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
1638         * WebKitTestRunner/InjectedBundle/GCController.cpp:
1639         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1640         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1641         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
1642         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1643         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1644         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1645         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1646         * WebKitTestRunner/InjectedBundle/TextInputController.cpp:
1647         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
1648         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
1649         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1650         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
1651         * WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm:
1652         * WebKitTestRunner/InjectedBundle/ios/EventSenderProxyIOS.mm:
1653         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
1654         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
1655         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1656         * WebKitTestRunner/PlatformWebView.h:
1657         * WebKitTestRunner/StringFunctions.h:
1658         * WebKitTestRunner/TestController.cpp:
1659         * WebKitTestRunner/TestController.h:
1660         * WebKitTestRunner/TestInvocation.cpp:
1661         * WebKitTestRunner/TestInvocation.h:
1662         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
1663         * WebKitTestRunner/WebNotificationProvider.cpp:
1664         * WebKitTestRunner/WebNotificationProvider.h:
1665         * WebKitTestRunner/WorkQueueManager.cpp:
1666         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
1667         * WebKitTestRunner/cg/TestInvocationCG.cpp:
1668         * WebKitTestRunner/cocoa/CrashReporterInfo.mm:
1669         * WebKitTestRunner/config.h:
1670         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1671         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1672         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1673         * WebKitTestRunner/ios/TestControllerIOS.mm:
1674         * WebKitTestRunner/mac/EventSenderProxy.mm:
1675         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1676         * WebKitTestRunner/mac/TestControllerMac.mm:
1677
1678 2014-05-15  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1679
1680         [EFL][WK2] Skip failing unit tests
1681         https://bugs.webkit.org/show_bug.cgi?id=132979
1682
1683         Reviewed by Daniel Bates.
1684
1685         * TestWebKitAPI/PlatformEfl.cmake: Skip failing unit tests for now.
1686
1687 2014-05-15  David Kilzer  <ddkilzer@apple.com>
1688
1689         [iOS] Support TestWebKitAPI in the iOS Simulator
1690         <http://webkit.org/b/129535>
1691         <rdar://problem/16203529>
1692
1693         Reviewed by Daniel Bates.
1694
1695         * Scripts/run-api-tests:
1696         (runTest):
1697         (listAllTests):
1698         - Extract common arguments into local variable.
1699         - Use xcrun to find the sim tool in order to invoke
1700         TestWebKitAPI properly in the iOS Simulator. 
1701
1702         * Scripts/webkitdirs.pm:
1703         (argumentsForConfiguration): Set --device or --sim as
1704         appropriate to fix buildTestTool() in run-api-tests.
1705
1706 2014-05-15  Tim Horton  <timothy_horton@apple.com>
1707
1708         Fix a logging typo in copy-webkitlibraries-to-product-directory
1709
1710         Reviewed by Dean Jackson.
1711
1712         * Scripts/copy-webkitlibraries-to-product-directory:
1713
1714 2014-05-15  David Kilzer  <ddkilzer@apple.com>
1715
1716         TestWebKitAPI: URLExtras.mm should be a shared test for iOS and Mac
1717         <http://webkit.org/b/132959>
1718
1719         Reviewed by Dan Bernstein.
1720
1721         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add
1722         Cocoa directory to project and move URLExtras.mm into it.
1723         * TestWebKitAPI/Tests/Cocoa/URLExtras.mm: Renamed from Tools/TestWebKitAPI/Tests/mac/URLExtras.mm.
1724
1725 2014-05-15  Carlos Garcia Campos  <cgarcia@igalia.com>
1726
1727         [GTK] Compile all installed resources as GResources
1728         https://bugs.webkit.org/show_bug.cgi?id=131099
1729
1730         Reviewed by Philippe Normand.
1731
1732         * Scripts/webkitpy/port/gtk.py:
1733         (GtkPort.setup_environ_for_server): Removed now unneeded
1734         AUDIO_RESOURCES_PATH env var.
1735
1736 2014-05-14  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
1737
1738         Remove CSS_STICKY_POSITION guards
1739         https://bugs.webkit.org/show_bug.cgi?id=132676
1740
1741         Reviewed by Simon Fraser.
1742
1743         * Scripts/webkitperl/FeatureList.pm:
1744
1745 2014-05-14  Carlos Garcia Campos  <cgarcia@igalia.com>
1746
1747         REGRESSION(CMAKE): [GTK] InputMethodFilter unit test is not built
1748         https://bugs.webkit.org/show_bug.cgi?id=132686
1749
1750         Reviewed by Philippe Normand.
1751
1752         Bring back InputMethodFilter test to the build and compile it into
1753         a single binary TestWebCore with the other WebCore tests. Also
1754         move it from TestWebKitAPI/gtk/ to TestWebKitAPI/Tests/WebCore/gtk/.
1755
1756         * Scripts/run-gtk-tests:
1757         (TestRunner): Remove WebCoreGtk from the list of test directories.
1758         * TestWebKitAPI/PlatformGTK.cmake:
1759         * TestWebKitAPI/Tests/WebCore/gtk/InputMethodFilter.cpp: Renamed from Tools/TestWebKitAPI/Tests/gtk/InputMethodFilter.cpp.
1760
1761 2014-05-14  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
1762
1763         [EFL] Make XVFBDriver optional
1764         https://bugs.webkit.org/show_bug.cgi?id=131036
1765
1766         Reviewed by Gyuyoung Kim.
1767
1768         * Scripts/webkitpy/port/efl.py:
1769         (EflPort._driver_class):
1770
1771 2014-05-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1772
1773         Flakiness dashboard contains outdated list of bots on builders.jsonp
1774         https://bugs.webkit.org/show_bug.cgi?id=132874
1775
1776         Reviewed by Darin Adler.
1777
1778         * TestResultServer/static-dashboards/builders.jsonp: Regenerate this
1779         file by changing to the directory Tools/TestResultServer and executing
1780         the script generate_builders_json.py
1781
1782 2014-05-11  Anders Carlsson  <andersca@apple.com>
1783
1784         Replace WKContextSetLocalStorageDirectory with a context configuration getter/setter
1785         https://bugs.webkit.org/show_bug.cgi?id=132809
1786
1787         Reviewed by Dan Bernstein.
1788
1789         * WebKitTestRunner/TestController.cpp:
1790         (WTR::TestController::initialize):
1791         Set the local storage directory using WKContextConfigurationSetLocalStorageDirectory.
1792
1793 2014-05-12  Carlos Garcia Campos  <cgarcia@igalia.com>
1794
1795         REGRESSION(CMAKE): [GTK] JavaScriptCore API tests are not built anymore
1796         https://bugs.webkit.org/show_bug.cgi?id=132739
1797
1798         Reviewed Anders Carlsson.
1799
1800         * TestWebKitAPI/CMakeLists.txt: Add missing includes required by
1801         the JSC unit tests.
1802         * TestWebKitAPI/PlatformGTK.cmake: Bring back JavaScriptCore unit tests.
1803
1804 2014-05-11  Anders Carlsson  <andersca@apple.com>
1805
1806         Add a WKContextConfigurationRef object and make the injected bundle path part of the configuration
1807         https://bugs.webkit.org/show_bug.cgi?id=132806
1808
1809         Reviewed by Beth Dakin.
1810
1811         Migrate to WKContextConfiguration.
1812
1813         * WebKitTestRunner/TestController.cpp:
1814         (WTR::TestController::initialize):
1815
1816 2014-05-10  Carlos Garcia Campos  <cgarcia@igalia.com>
1817
1818         REGRESSION(CMAKE): [GTK] WebKit2 C API tests are not longer built in the same binary
1819         https://bugs.webkit.org/show_bug.cgi?id=132685
1820
1821         Reviewed by Martin Robinson.
1822
1823         Use a single TestWebKit2 binary for all WebKit2 C API tests.
1824
1825         * TestWebKitAPI/PlatformGTK.cmake:
1826
1827 2014-05-09  Benjamin Poulain  <benjamin@webkit.org>
1828
1829         [iOS] Switch geolocation to an explicit authorization query model
1830         https://bugs.webkit.org/show_bug.cgi?id=132717
1831
1832         Reviewed by Sam Weinig.
1833
1834         * DumpRenderTree/mac/MockGeolocationProvider.mm:
1835         (-[MockGeolocationProvider initializeGeolocationForWebView:listener:]):
1836         (-[MockGeolocationProvider cancelWarmUpForWebView:]): Deleted.
1837
1838 2014-05-09  David Farler  <dfarler@apple.com>
1839
1840         com.apple.iphonesimulator.startSession needs to pass "RuntimeIdentifier"
1841         https://bugs.webkit.org/show_bug.cgi?id=132718
1842
1843         Reviewed by David Kilzer.
1844
1845         The simulator may not be able to look up runtimes by SDK paths
1846         and instead will map SDK versions to runtimes instead. In
1847         com.apple.iphonesimulator.startSession notifications,
1848         'runtimeIdentifier' (SDK version string) is preferred over
1849         'sdkRoot' (SDK path) anyway. Include the 'runtimeIdentifier' key
1850         when creating a new DRT or WKTR simulator session.
1851
1852         IPhoneSimulatorNotification.pm filters out keys for this
1853         notification's userInfo with a hard-coded list. There's no harm
1854         in including extra key-value pairs in an NSNotification userInfo
1855         dictionary anyway and the simulator may again change its
1856         userInfo schema for this notification.
1857
1858         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/lib/IPhoneSimulatorNotification.pm:
1859         (postStartSessionNotification):
1860         * Scripts/old-run-webkit-tests:
1861         (installAndLaunchDumpToolAppUsingNotification):
1862
1863 2014-05-09  Anders Carlsson  <andersca@apple.com>
1864
1865         Another build fix.
1866
1867         * Scripts/build-webkit:
1868         WebKit2 should always be built for OS X and iOS.
1869
1870 2014-05-09  Anders Carlsson  <andersca@apple.com>
1871
1872         Follow-up build fix.
1873
1874         * Scripts/build-webkit:
1875         WebKit2 should no longer be built before WebKit.
1876
1877 2014-05-09  Anders Carlsson  <andersca@apple.com>
1878
1879         Rename WebKit2.framework to WebKit.framework
1880         https://bugs.webkit.org/show_bug.cgi?id=132743
1881         <rdar://problem/15920046>
1882
1883         Reviewed by Dan Bernstein.
1884
1885         * Scripts/check-for-inappropriate-files-in-framework:
1886         Use PRODUCT_NAME instead of PROJECT_NAME when matching frameworks.
1887         Change WebKit2 to WebKit.
1888
1889         * Scripts/check-for-webkit-framework-include-consistency:
1890         Change WebKit to WebKitLegacy.
1891
1892 2014-05-09  Manuel Rego Casasnovas  <rego@igalia.com>
1893
1894         Remove GTK+ WK1 EWS from build.webkit.org/dashboard
1895         https://bugs.webkit.org/show_bug.cgi?id=132732
1896
1897         Reviewed by Alexey Proskuryakov.
1898
1899         GTK+ WK1 EWS was removed in r166427, so it shouldn't appear in the dashboard.
1900
1901         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js:
1902         (EWS): Remove GTK+ WK1 EWS.
1903
1904 2014-05-09  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1905
1906         Add new u-szeged contributors.
1907
1908         Reviewed by Csaba Osztrogonác.
1909
1910         * Scripts/webkitpy/common/config/contributors.json:
1911
1912 2014-05-09  Carlos Garcia Campos  <cgarcia@igalia.com>
1913
1914         REGRESSION(CMAKE): [GTK] run-gtk-tests doesn't set the right injected bundle path
1915         https://bugs.webkit.org/show_bug.cgi?id=132736
1916
1917         Reviewed by Philippe Normand.
1918
1919         There are two problems, the path returned by common.library_build_path() is wrong when
1920         common.binary_build_path() has previously been called, and the test is still looking for
1921         the .la instead of .so
1922
1923         * TestWebKitAPI/gtk/PlatformUtilitiesGtk.cpp:
1924         (TestWebKitAPI::Util::createInjectedBundlePath): Use .so instead
1925         of .la as extension of the injected bundle library.
1926         * gtk/common.py:
1927         (binary_build_path): Remove unused global variable and add a new
1928         one for binary_build_dir instead of sharing the same global
1929         variable for library_build_path and binary_build_path.
1930
1931 2014-05-08  Praveen R Jadhav  <praveen.j@samsung.com>
1932
1933         [EFL] Enable MEDIA_STREAM for EFL port
1934         https://bugs.webkit.org/show_bug.cgi?id=132648
1935
1936         Reviewed by Gyuyoung Kim.
1937
1938         Script modified to enable MEDIA_STREAM for EFL build.
1939
1940         * Scripts/webkitperl/FeatureList.pm: 
1941
1942 2014-05-08  David Farler  <dfarler@apple.com>
1943
1944         old-run-webkit-tests: update strings for simulator devices and app name
1945         https://bugs.webkit.org/show_bug.cgi?id=132687
1946
1947         Reviewed by Darin Adler.
1948
1949         iPhone Retina (4-inch) -> iPhone 5
1950         iPhone Retina (4-inch 64-bit) -> iPhone 5s
1951
1952         * Scripts/old-run-webkit-tests:
1953         (installAndLaunchDumpToolAppUsingNotification):
1954         (openIPhoneSimulator):
1955         (quitIPhoneSimulator):
1956         quit iOS Simulator, not iPhone Simulator.
1957
1958 2014-05-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1959
1960         REGRESSION(r168471): Update the builder names on the scheduler list.
1961         https://bugs.webkit.org/show_bug.cgi?id=132699
1962
1963         Reviewed by Martin Robinson.
1964
1965         On r168471 I missed to update the builder names for the GTK build
1966         bots on the AnyBranchScheduler type scheduler list of bots.
1967
1968         * BuildSlaveSupport/build.webkit.org-config/config.json:
1969
1970 2014-05-08  Brady Eidson  <beidson@apple.com>
1971
1972         "shouldKeepCurrentBackForwardListItemInList" API should pass clientInfo to the callback
1973         <rdar://problem/16855357> and https://bugs.webkit.org/show_bug.cgi?id=132692
1974
1975         Reviewed by Tim Horton.
1976
1977         * TestWebKitAPI/Tests/WebKit2/ShouldKeepCurrentBackForwardListItemInList.cpp:
1978         (TestWebKitAPI::shouldKeepCurrentBackForwardListItemInList):
1979
1980 2014-05-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1981
1982         REGRESSION(r168471): Duplicate builddirs broke the build master.
1983         https://bugs.webkit.org/show_bug.cgi?id=132688
1984
1985         Reviewed by Carlos Garcia Campos.
1986
1987         Rename the builddirs of the new GTK bots introduced on r168471 to
1988         be unique. Otherwise the master will break.
1989
1990         * BuildSlaveSupport/build.webkit.org-config/config.json:
1991
1992 2014-05-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1993
1994         [GTK] webkitdom script assumes mkdir only fails because the directory already exists
1995         https://bugs.webkit.org/show_bug.cgi?id=132674
1996
1997         Reviewed by Philippe Normand.
1998
1999         Only ignore mkdir failure when exception is raised because the
2000         file already exists and it's a directory.
2001
2002         * gtk/webkitdom.py:
2003         (write_doc_files):
2004
2005 2014-05-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2006
2007         [WK2][GTK] Split the 64-bit GTK buildbots in Build and Test.
2008         https://bugs.webkit.org/show_bug.cgi?id=131358
2009
2010         Reviewed by Carlos Garcia Campos.
2011
2012         Current 64-bit GTK build bots (Release and Debug) not only test
2013         the build, but run all tests. Split each one of the bots in
2014         BuildOnly and TestWebKit2.
2015
2016         This will allow us to have a better overview of the status of
2017         the GTK port.
2018
2019         Original patch from Sergio Villar Senin <svillar@igalia.com>
2020
2021         * BuildSlaveSupport/build.webkit.org-config/config.json:
2022         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
2023         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2024         (WebKitBuildbot):
2025         * Scripts/webkitpy/port/builders.py:
2026         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2027         (TestRebaselineTest.test_baseline_directory):
2028         * TestResultServer/static-dashboards/builders.jsonp:
2029         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2030         (resetGlobals):
2031         * TestResultServer/static-dashboards/loader_unittests.js:
2032
2033 2014-05-07  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2034
2035         [CoordinatedGraphics][WK2] Scale factor and scroll position is not being restored properly in a back/forward load
2036         https://bugs.webkit.org/show_bug.cgi?id=126022
2037
2038         Reviewed by Benjamin Poulain.
2039
2040         Original author : Thiago de Barros Lacerda, and finished by Gyuyoung Kim.
2041
2042         Added an unit test case to check if scroll position and scale are restored properly.
2043
2044         * TestWebKitAPI/PlatformEfl.cmake:
2045         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewRestoreZoomAndScrollBackForward.cpp: Added.
2046         (TestWebKitAPI::didFinishLoadForFrame):
2047         (TestWebKitAPI::didChangeContentsPosition):
2048         (TestWebKitAPI::TEST):
2049         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/backforward1.html: Added.
2050         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/backforward2.html: Added.
2051
2052 2014-05-07  Simon Fraser  <simon.fraser@apple.com>
2053
2054         WebKit1 is flashy when compositing layers come and go
2055         https://bugs.webkit.org/show_bug.cgi?id=132655
2056         <rdar://problem/16830981&16788846>
2057
2058         Reviewed by Sam Weinig.
2059         
2060         Revert the change from r166117.
2061
2062         * DumpRenderTree/mac/DumpRenderTree.mm:
2063         (updateDisplay):
2064
2065 2014-05-07  Chris Fleizach  <cfleizach@apple.com>
2066
2067         AX: AXSelectTextWithCriteria should support capitalize/lowercase/uppercase
2068         https://bugs.webkit.org/show_bug.cgi?id=132622
2069
2070         Reviewed by Mario Sanchez Prada.
2071
2072         * DumpRenderTree/AccessibilityUIElement.cpp:
2073         (selectTextWithCriteriaCallback):
2074         (isEqualCallback):
2075         * DumpRenderTree/AccessibilityUIElement.h:
2076         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2077         (AccessibilityUIElement::selectTextWithCriteria):
2078         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2079         (AccessibilityUIElement::selectTextWithCriteria):
2080         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2081         (selectTextParameterizedAttributeForCriteria):
2082         (AccessibilityUIElement::selectTextWithCriteria):
2083         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2084         (AccessibilityUIElement::selectTextWithCriteria):
2085         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2086         (WTR::AccessibilityUIElement::selectTextWithCriteria):
2087         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2088         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2089         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2090         (WTR::AccessibilityUIElement::selectTextWithCriteria):
2091         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2092         (WTR::AccessibilityUIElement::selectTextWithCriteria):
2093         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2094         (WTR::selectTextParameterizedAttributeForCriteria):
2095         (WTR::AccessibilityUIElement::selectTextWithCriteria):
2096
2097 2014-05-07  Carlos Garcia Campos  <cgarcia@igalia.com>
2098
2099         [SOUP] TLSErrors do not cause page load to fail when not ignored
2100         https://bugs.webkit.org/show_bug.cgi?id=121548
2101
2102         Reviewed by Sergio Villar Senin.
2103
2104         Add unit tests to check that the load fails with TLS errors in
2105         case of a redirection.
2106
2107         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
2108         (testTLSErrorsRedirect):
2109         (httpsServerCallback):
2110         (beforeAll):
2111
2112 2014-05-07  Manuel Rego Casasnovas  <rego@igalia.com>
2113
2114         [CSS Grid Layout] Remove runtime feature
2115         https://bugs.webkit.org/show_bug.cgi?id=132382
2116
2117         Reviewed by Benjamin Poulain.
2118
2119         Remove cssGridLayoutEnabled setting usage.
2120
2121         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2122         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2123         * DumpRenderTree/efl/TestRunnerEfl.cpp:
2124         (TestRunner::overridePreference):
2125         * DumpRenderTree/mac/DumpRenderTree.mm:
2126         (resetWebPreferencesToConsistentValues):
2127
2128 2014-05-06  David Kilzer  <ddkilzer@apple.com>
2129
2130         Add Makefile targets for copying static libraries (LLVM and WKSI)
2131         <http://webkit.org/b/132619>
2132
2133         Reviewed by Mark Rowe.
2134
2135         * Scripts/copy-webkitlibraries-to-product-directory: Set a
2136         sensible default for product directory if not specified on
2137         either the command-line or in the environment (by Xcode) by
2138         calling productDir() in webkitdirs.pm.
2139
2140 2014-05-06  Brady Eidson  <beidson@apple.com>
2141
2142         Add WK2 SPI to prevent the previous back/forward item from remaining in the list
2143         <rdar://problem/16248710> and https://bugs.webkit.org/show_bug.cgi?id=132636
2144
2145         Reviewed by Sam Weinig.
2146
2147         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2148
2149         * TestWebKitAPI/Tests/WebKit2/ShouldKeepCurrentBackForwardListItemInList.cpp: Added.
2150         (TestWebKitAPI::itemURLLastComponentIsString):
2151         (TestWebKitAPI::didFinishLoadForFrame):
2152         (TestWebKitAPI::willGoToBackForwardListItem):
2153         (TestWebKitAPI::shouldKeepCurrentBackForwardListItemInList):
2154         (TestWebKitAPI::setPageLoaderClient):
2155         (TestWebKitAPI::TEST):
2156         * TestWebKitAPI/Tests/WebKit2/simple2.html: Added.
2157         * TestWebKitAPI/Tests/WebKit2/simple3.html: Added.
2158
2159         * WebKitTestRunner/TestController.cpp:
2160         (WTR::TestController::createWebViewWithOptions): Update for new client layout.
2161
2162 2014-05-06  Darin Adler  <darin@apple.com>
2163
2164         Try to fix iOS build.
2165
2166         * DumpRenderTree/mac/TestRunnerMac.mm:
2167         (-[APITestDelegateIPhone initWithTestRunner:utf8Data:baseURL:]):
2168         Updated since I changed testRunner into a pointer instead of a reference.
2169         Updated argument names to avoid conflict with field names.
2170         (-[APITestDelegateIPhone run]): Ditto.
2171         (-[APITestDelegateIPhone _cleanUp]): Ditto.
2172
2173 2014-05-06  Commit Queue  <commit-queue@webkit.org>
2174
2175         Unreviewed, rolling out r168304.
2176         https://bugs.webkit.org/show_bug.cgi?id=132607
2177
2178         Broke the build (Requested by KaL on #webkit).
2179
2180         Reverted changeset:
2181
2182         "[GTK][CMake] Unable to do make install"
2183         https://bugs.webkit.org/show_bug.cgi?id=130188
2184         http://trac.webkit.org/changeset/168304
2185
2186 2014-05-04  Darin Adler  <darin@apple.com>
2187
2188         RetainPtr: Use adoptCF function instead of AdoptCF constructor argument
2189         https://bugs.webkit.org/show_bug.cgi?id=80222
2190
2191         Reviewed by Alexey Proskuryakov.
2192
2193         * DumpRenderTree/mac/TestRunnerMac.mm:
2194         (-[APITestDelegateIPhone initWithTestRunner:utf8Data:baseURL:]): Updated to
2195         do more work here so we don't use RetainPtr local variables.
2196         (-[APITestDelegateIPhone dealloc]): Added.
2197         (-[APITestDelegateIPhone run]): Added an early exit if the web view is already
2198         created. Updated for changes to member names and types.
2199         (-[APITestDelegateIPhone _cleanUp]): Added code to set webView to nil and
2200         updated for changes to member names and types. Changed to two word spelling.
2201         (-[APITestDelegateIPhone webView:didFailLoadWithError:forFrame:]): Updated
2202         name of _cleanUp method.
2203         (-[APITestDelegateIPhone webView:didFailProvisionalLoadWithError:forFrame:]):
2204         Ditto.
2205         (-[APITestDelegateIPhone webView:didFinishLoadForFrame:]): Ditto.
2206
2207 2014-05-05  Benjamin Poulain  <benjamin@webkit.org>
2208
2209         Clean up Image Document and tweak the layout and viewport
2210         https://bugs.webkit.org/show_bug.cgi?id=132552
2211
2212         Reviewed by Anders Carlsson.
2213
2214         * DumpRenderTree/mac/DumpRenderTree.mm:
2215         (resetWebPreferencesToConsistentValues):
2216         Update the default settings to have something consistent with WebKit2.
2217
2218 2014-05-05  Martin Robinson  <mrobinson@igalia.com>
2219
2220         [GTK][CMake] Unable to do make install
2221         https://bugs.webkit.org/show_bug.cgi?id=130188
2222
2223         Reviewed by Carlos Garcia Campos.
2224
2225         * Scripts/webkitdirs.pm:
2226         (buildCMakeGeneratedProject): Always build gtkdoc-no-html for WebKitGTK+. This
2227         will give an early signal that a change has broken the documentation.
2228
2229 2014-05-05  Pratik Solanki  <psolanki@apple.com>
2230
2231         Update framework locations in package-root
2232         https://bugs.webkit.org/show_bug.cgi?id=132571
2233
2234         Reviewed by Simon Fraser.
2235
2236         * Scripts/package-root:
2237
2238 2014-05-05  Ryuan Choi  <ryuan.choi@samsung.com>
2239
2240         [EFL][WK2] Refactor favicon database APIs
2241         https://bugs.webkit.org/show_bug.cgi?id=132519
2242
2243         Reviewed by Gyuyoung Kim.
2244
2245         * MiniBrowser/efl/main.c: Use ewk_favicon_database_icon_get instead of ewk_view_favicon_get.
2246         (update_view_favicon):
2247         (on_icon_changed_cb):
2248         (window_free):
2249         (on_url_changed):
2250         (window_create):
2251         (on_view_favicon_changed): Deleted.
2252
2253 2014-05-02  Mark Rowe  <mrowe@apple.com>
2254
2255         <https://webkit.org/b/132505> Make it possible to tell copy-webkitlibraries-to-product-directory which OS X version to copy for
2256
2257         Reviewed by Dan Bernstein.
2258
2259         * Scripts/copy-webkitlibraries-to-product-directory: Add an --osx-version argument and use the passed value
2260         when determining which LLVM archive to extract.
2261
2262 2014-05-02  Jeremy Jones  <jeremyj@apple.com>
2263
2264         Add Jeremy as a committer.
2265         https://bugs.webkit.org/show_bug.cgi?id=132492
2266
2267         Reviewed by Jer Noble.
2268
2269         Add myself as a committer.
2270
2271         * Scripts/webkitpy/common/config/contributors.json:
2272
2273 2014-05-02  Jeremy Jones  <jeremyj@apple.com>
2274
2275         Add Jeremy as a committer.
2276         https://bugs.webkit.org/show_bug.cgi?id=132492
2277
2278         Reviewed by Jer Noble.
2279
2280         Add Jeremy Jones to the committers file.
2281
2282         * Scripts/webkitpy/common/config/contributors.json:
2283
2284 2014-05-02  Brian J. Burg  <burg@cs.washington.edu>
2285
2286         Hard to figure out how to run a single test with run-api-tests
2287         https://bugs.webkit.org/show_bug.cgi?id=116332
2288
2289         Reviewed by Alexey Proskuryakov.
2290
2291         * Scripts/run-api-tests: add two examples to the help message.
2292
2293 2014-05-02  Simon Fraser  <simon.fraser@apple.com>
2294
2295         Fix several memory leaks found by code inspection
2296         https://bugs.webkit.org/show_bug.cgi?id=132472
2297
2298         Reviewed by Geoffrey Garen.
2299         
2300         Fix memory leaks.
2301
2302         * TestWebKitAPI/Tests/mac/WillSendSubmitEvent.mm:
2303         (TestWebKitAPI::TEST):
2304         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2305         (WTR::InjectedBundlePage::willSendRequestForFrame):
2306         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2307         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
2308
2309 2014-05-02  Filip Pizlo  <fpizlo@apple.com>
2310
2311         DFGAbstractInterpreter should not claim Int52 arithmetic creates Int52s
2312         https://bugs.webkit.org/show_bug.cgi?id=132446
2313
2314         Reviewed by Mark Hahnenberg.
2315         
2316         Test the FTL by default now that it's enabled by default.
2317
2318         * Scripts/run-javascriptcore-tests:
2319
2320 2014-05-01  Ryuan Choi  <ryuan.choi@samsung.com>
2321
2322         [EFL][WK1] Drop ewk_view_setting_tiled_backingstore APIs
2323         https://bugs.webkit.org/show_bug.cgi?id=132240
2324
2325         Reviewed by Anders Carlsson.
2326
2327         Removed ewk_view_setting_tiled_backingstore related code.
2328
2329         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2330         (DumpRenderTreeChrome::createView):
2331         (shouldUseTiledBackingStore): Deleted.
2332         * EWebLauncher/main.c:
2333         (windowCreate):
2334         (parseUserArguments):
2335
2336 2014-05-01  Anders Carlsson  <andersca@apple.com>
2337
2338         window.testRunner.keepWebHistory() should update the UI process state
2339         https://bugs.webkit.org/show_bug.cgi?id=132440
2340
2341         Reviewed by Dan Bernstein.
2342
2343         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2344         (WTR::InjectedBundle::postSetAddsVisitedLinks):
2345         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2346         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2347         (WTR::TestRunner::keepWebHistory):
2348         * WebKitTestRunner/TestInvocation.cpp:
2349         (WTR::TestInvocation::invoke):
2350         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2351
2352 2014-05-01  David Kilzer  <ddkilzer@apple.com>
2353
2354         Really remove ENABLE_PLUGIN_PROXY_FOR_VIDEO
2355         <http://webkit.org/b/132432>
2356
2357         Reviewed by Tim Horton.
2358
2359         * Scripts/webkitperl/FeatureList.pm: Remove support for
2360         --plugin-proxy-for-video switch.
2361
2362 2014-04-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2363
2364         Kernel sysctl interface hw.activecpu don't exists on Linux.
2365         https://bugs.webkit.org/show_bug.cgi?id=132286
2366
2367         Reviewed by Filip Pizlo.
2368
2369         * Scripts/run-jsc-stress-tests: Redirect stderr to null when
2370         calling sysctl over hw.activecpu
2371
2372 2014-04-30  Anders Carlsson  <andersca@apple.com>
2373
2374         Move the legacy WebKit API into WebKitLegacy.framework and move it inside WebKit.framework
2375         https://bugs.webkit.org/show_bug.cgi?id=132399
2376         <rdar://problem/15920046>
2377
2378         Reviewed by Dan Bernstein.
2379
2380         * Scripts/check-for-webkit-framework-include-consistency:
2381         Allos WAK headers in WebKitLegacy as well as WebKit.
2382
2383         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2384         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
2385         Update header imports.
2386
2387 2014-04-30  Simon Fraser  <simon.fraser@apple.com>
2388
2389         [iOS WK2] Add test URL to crash reports for the UI process, clean up project
2390         https://bugs.webkit.org/show_bug.cgi?id=131954
2391
2392         Reviewed by Darin Adler.
2393         
2394         WebKitTestRunner was adding application-specific information to crash reports
2395         to log the test path, but only in the web process. Fix it to also do this
2396         for the UI process, for both iOS and OS X.
2397         
2398         Moved InjectedBundlePageMac.mm to InjectedBundlePageCocoa.mm and compile it for
2399         both iOS and OS X.
2400         
2401         Factored crash reprorter-related code into CrashReporterInfo, and call it from
2402         a new TestController::platformWillRunTest() function on Mac and iOS.
2403         
2404         Also remove Xcode-added unit test junk from the project.
2405
2406         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm: Copied from Tools/WebKitTestRunner/InjectedBundle/ios/InjectedBundlePageIOS.mm.
2407         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame):
2408         * WebKitTestRunner/TestController.cpp:
2409         (WTR::TestController::runTest):
2410         * WebKitTestRunner/TestController.h:
2411         * WebKitTestRunner/TestInvocation.cpp:
2412         (WTR::TestInvocation::url):
2413         * WebKitTestRunner/TestInvocation.h:
2414         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2415         * WebKitTestRunner/WebKitTestRunnerAppTests/WebKitTestRunnerAppTests-Info.plist: Removed.
2416         * WebKitTestRunner/WebKitTestRunnerAppTests/WebKitTestRunnerAppTests.m: Removed.
2417         * WebKitTestRunner/WebKitTestRunnerAppTests/en.lproj/InfoPlist.strings: Removed.
2418         * WebKitTestRunner/cocoa/CrashReporterInfo.h: Renamed from Tools/WebKitTestRunner/InjectedBundle/ios/InjectedBundlePageIOS.mm.
2419         * WebKitTestRunner/cocoa/CrashReporterInfo.mm: Renamed from Tools/WebKitTestRunner/InjectedBundle/mac/InjectedBundlePageMac.mm.
2420         (WTR::testPathFromURL):
2421         (WTR::setCrashReportApplicationSpecificInformationToURL):
2422         * WebKitTestRunner/efl/TestControllerEfl.cpp:
2423         (WTR::TestController::platformWillRunTest):
2424         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2425         (WTR::TestController::platformWillRunTest):
2426         * WebKitTestRunner/ios/TestControllerIOS.mm:
2427         (WTR::TestController::platformWillRunTest):
2428         (WTR::TestController::setHidden):
2429         * WebKitTestRunner/mac/TestControllerMac.mm:
2430         (WTR::TestController::platformWillRunTest):
2431
2432 2014-04-30  Simon Fraser  <simon.fraser@apple.com>
2433
2434         Fix DRT assertion about mock scrollbars, which doesn't apply to iOS.
2435
2436         Reviewed by Tim Horton.
2437
2438         * DumpRenderTree/mac/DumpRenderTree.mm:
2439         (resetWebPreferencesToConsistentValues):
2440         (prepareConsistentTestingEnvironment):
2441
2442 2014-04-30  Anders Carlsson  <andersca@apple.com>
2443
2444         check-for-inappropriate-macros-in-external-headers should get the product name, not the project name
2445         https://bugs.webkit.org/show_bug.cgi?id=132397
2446
2447         Reviewed by Dan Bernstein.
2448
2449         * Scripts/check-for-inappropriate-macros-in-external-headers:
2450
2451 2014-04-29  Martin Robinson  <mrobinson@igalia.com>
2452
2453         [GTK] Make it easier to run CMake for downstreams
2454         https://bugs.webkit.org/show_bug.cgi?id=132370
2455
2456         Reviewed by Carlos Garcia Campos.
2457
2458         * Scripts/webkitdirs.pm:
2459         (generateBuildSystemFromCMakeProject): Pass -DDEVELOPER_MODE when building
2460         the GTK+ port.
2461
2462 2014-04-29  Stephanie Lewis  <slewis@apple.com>
2463
2464         <rdar://problem/16765765> Use JSON::PP in perl scripts instead of JSON.
2465         
2466         Rubber stamped by Jessie Berlin.
2467
2468         JSON.pm was removed from our tools setup.
2469
2470         * Scripts/generate-coverage-data:
2471
2472 2014-04-29  Filip Pizlo  <fpizlo@apple.com>
2473
2474         Use LLVM as a backend for the fourth-tier DFG JIT (a.k.a. the FTL JIT)
2475         https://bugs.webkit.org/show_bug.cgi?id=112840
2476
2477         Rubber stamped by Geoffrey Garen.
2478
2479         * Scripts/build-jsc: Enable it on Mac.
2480         * Scripts/build-webkit: Enable it on Mac.
2481         * Scripts/export-llvm-build: Make it slightly easier to export the build if you've done a "make install".
2482
2483 2014-04-28  Sam Weinig  <sam@webkit.org>
2484
2485         REGRESSION (r167751): svn-create-patch is very slow
2486         https://bugs.webkit.org/show_bug.cgi?id=132300
2487
2488         Reviewed by Alexey Proskuryakov.
2489
2490         * Scripts/svn-create-patch:
2491         Change default behavior of svn-create-patch to no longer run the style checker. It can still be run
2492         by calling `svn-create-patch --style`.
2493
2494 2014-04-29  Enrique Ocaña González  <eocanha@igalia.com>
2495
2496         Generate Eclipse project + ninja build for GTK+ if Eclipse in available in the PATH
2497         https://bugs.webkit.org/show_bug.cgi?id=132190
2498
2499         Reviewed by Gustavo Noronha Silva.
2500
2501         * Scripts/webkitdirs.pm:
2502         (canUseEclipse): Test if Eclipse is in the path. This is the same method used to test
2503             if ninja is in the path.
2504         (generateBuildSystemFromCMakeProject): Use the eclipse generator if possible, fallback
2505             to the previous ninja generator if not.
2506
2507 2014-04-29  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
2508
2509         check-webkit-style should understand --git-index
2510         https://bugs.webkit.org/show_bug.cgi?id=125364
2511
2512         Reviewed by Csaba Osztrogonác.
2513
2514         * Scripts/webkitpy/common/checkout/scm/git.py:
2515         (Git.create_patch): The command now supports the --cached option.
2516         * Scripts/webkitpy/style/main.py:
2517         (CheckWebKitStyle.main): Passing the --git-index option.
2518         * Scripts/webkitpy/style/optparser.py:
2519         (CommandOptionValues.__init__): The git-index option is switched off by default.
2520         (CommandOptionValues.__eq__): Equality check for the new option.
2521         (ArgumentParser._create_option_parser):Adding the --git-index option
2522         (ArgumentParser.parse):
2523         * Scripts/webkitpy/style/optparser_unittest.py: New tests for the --git-index option
2524         (CommandOptionValuesTest.test_init): 
2525         (CommandOptionValuesTest.test_eq):
2526
2527 2014-04-28  Michael Saboff  <msaboff@apple.com>
2528
2529         Crash in platform/mac/accessibility/table-visible-rows.html
2530         https://bugs.webkit.org/show_bug.cgi?id=132146
2531
2532         Reviewed by Filip Pizlo.
2533
2534         Instead of creating a local JSValueRef array on the stack and passing that to
2535         JSObjectMakeArray(), changed to create an empty JSArray and then populate the
2536         values using the JSObjectSetPropertyAtIndex() API.
2537
2538         * DumpRenderTree/AccessibilityUIElement.cpp:
2539         (elementsForRangeCallback):
2540         (convertElementsToObjectArray):
2541         * DumpRenderTree/mac/TestRunnerMac.mm:
2542         (originsArrayToJS):
2543         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2544         (WTR::EventSendingController::contextClick):
2545         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2546         (WTR::stringArrayToJS):
2547         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2548         (WTR::convertElementsToObjectArray):
2549
2550 2014-04-28  Filip Pizlo  <fpizlo@apple.com>
2551
2552         Make sure that the coverage of our tests doesn't change much if we change the thresholds now and in the future, but making
2553         "no-cjit" runs force the old-school threshold.
2554
2555         Rubber stamped by Mark Hahnenberg.
2556
2557         * Scripts/run-jsc-stress-tests:
2558
2559 2014-04-28  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2560
2561         [GTK] install-dependencies should also install ruby-json and ruby-highline
2562         https://bugs.webkit.org/show_bug.cgi?id=132292
2563
2564         Reviewed by Philippe Normand.
2565
2566         * gtk/install-dependencies: Install ruby json and highline packages.
2567
2568 2014-04-27  Joonghun Park  <jh718.park@samsung.com>
2569
2570         [EFL] Remove indexedDB's dependency on leveldb and disable indexedDB
2571         https://bugs.webkit.org/show_bug.cgi?id=132176
2572
2573         Reviewed by Gyuyoung Kim.
2574
2575         EFL port will use sqlite to support indexedDB. So, this patch removes levelDB dependency
2576         and turn off indexedDB feature until the sqlite implementation is introduced.
2577
2578         * Scripts/webkitperl/FeatureList.pm:
2579
2580 2014-04-25  James Craig  <jcraig@apple.com>
2581
2582         Set prepare-Changelog flag so that it no longer runs check-webkit-style by default
2583         https://bugs.webkit.org/show_bug.cgi?id=132209
2584
2585         Reviewed by Daniel Bates.
2586
2587         Set default to --no-style to avoid additional spew from false positives in check-webkit-style.
2588         Run check-webkit-style before generating changelogs to avoid additional spurious errors.
2589
2590         * Scripts/prepare-ChangeLog:
2591         (main): 
2592
2593 2014-04-25  Michael Saboff  <msaboff@apple.com>
2594
2595         Crash in platform/mac/accessibility/table-visible-rows.html
2596         https://bugs.webkit.org/show_bug.cgi?id=132146
2597
2598         Reviewed by Mark Lam.
2599
2600         Changed to use a local JSValueRef array temporary instead of a
2601         std::make_unique<JSValueRef[]> when making an array of JSValues so that the temporary
2602         JSValues are visited during garbage collection when the stack is scanned.  Otherwise,
2603         the temporary values could be collected.
2604
2605         * DumpRenderTree/AccessibilityUIElement.cpp:
2606         (convertElementsToObjectArray):
2607         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2608         (WTR::EventSendingController::contextClick):
2609         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2610         (WTR::convertElementsToObjectArray):
2611
2612 2014-04-24  Eduardo Lima Mitev  <elima@igalia.com>
2613
2614         Unreviewed GTK gardening
2615
2616         * Scripts/run-gtk-tests: Skips one flaky accesibility test in WK2API suite
2617         (TestRunner):
2618
2619 2014-04-24  László Langó  <llango.u-szeged@partner.samsung.com>
2620
2621         prepare-ChangeLog reports as deleted methods that has not been removed.
2622         https://bugs.webkit.org/show_bug.cgi?id=131733
2623
2624         Reviewed by Ryosuke Niwa.
2625
2626         * Scripts/prepare-ChangeLog:
2627         (originalFile): Set merge base to origin/master by default.
2628
2629 2014-04-23  James Craig  <jcraig@apple.com>
2630
2631         prepare-Changelog and svn-create-patch should optionally run check-webkit-style.
2632         https://bugs.webkit.org/show_bug.cgi?id=131115
2633
2634         Reviewed by Daniel Bates.
2635
2636         Added [--[no-]style] param to run check-webkit-style as part of prepare-Changelog and svn-create-patch.
2637
2638         * Scripts/commit-log-editor: Added --no-style.
2639         * Scripts/prepare-ChangeLog: Primary patch.
2640         (main): Primary patch.
2641         (createPatchCommand): Added --no-style.
2642         * Scripts/svn-create-patch: Primary patch.
2643         * Scripts/webkit-tools-completion.sh: Added --style and --no-style.
2644         * Scripts/webkitpy/common/checkout/scm/svn.py: Added --no-style.
2645         (SVN.create_patch): Added --no-style.
2646
2647 2014-04-23  Anders Carlsson  <andersca@apple.com>
2648
2649         Try to fix iOS build.
2650
2651         * DumpRenderTree/mac/DumpRenderTree.mm:
2652
2653 2014-04-23  Alexey Proskuryakov  <ap@apple.com>
2654
2655         Eliminate internals.setMockScrollbarsEnabled()
2656         https://bugs.webkit.org/show_bug.cgi?id=132085
2657
2658         Reviewed by Tim Horton.
2659
2660         * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebPreferencesToConsistentValues):
2661         No need to reset the preference, there is no way it can change.
2662
2663 2014-04-23  James Craig  <jcraig@apple.com>
2664
2665         Unreviewed. Moving myself from Contributors to Committers list.
2666
2667         * Scripts/webkitpy/common/config/contributors.json:
2668
2669 2014-04-23  Tim Horton  <timothy_horton@apple.com>
2670
2671         Mock scrollbars don't always work in DumpRenderTree
2672         https://bugs.webkit.org/show_bug.cgi?id=132082
2673
2674         Reviewed by Alexey Proskuryakov.
2675
2676         * DumpRenderTree/mac/DumpRenderTree.mm:
2677         (prepareConsistentTestingEnvironment):
2678         Set the mock scrollbar setting before creating the WebView, as this setting
2679         cannot be dynamically changed, so any scrollbars that are created during
2680         WebView initialization and are not replaced before snapshotting will end
2681         up being platform scrollbars instead of mock ones.
2682         WebKitTestRunner already sets this preference before creating WKViews,
2683         so we're just matching its behavior.
2684
2685 2014-04-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2686
2687         [GTK] ShadowRoot API was removed in r164131
2688         https://bugs.webkit.org/show_bug.cgi?id=132059
2689
2690         Reviewed by Gustavo Noronha Silva.
2691
2692         Add WebKitDOMShadowRoot to the list of deleted classes to generate
2693         the API docs.
2694
2695         * gtk/webkitdom.py:
2696         (WebKitDOMDocGenerator):
2697
2698 2014-04-23  Lorenzo Tilve  <ltilve@igalia.com>
2699
2700         [GTK] run-webkit-tests script is failing to invoke run-launcher
2701         https://bugs.webkit.org/show_bug.cgi?id=132051
2702
2703         Reviewed by Philippe Normand.
2704
2705         After the WK1 support was dropped, if run-webkit-tests is executed
2706         without --no-show-results parameter, the launcher is being called
2707         using a -2 parameter that is it causing the run-launcher to break.
2708
2709         * Scripts/webkitpy/port/gtk.py:
2710         (GtkPort.show_results_html_file):
2711
2712 2014-04-22  Tim Horton  <timothy_horton@apple.com>
2713
2714         DumpRenderTree generates black snapshots on some platforms
2715         https://bugs.webkit.org/show_bug.cgi?id=132029
2716         <rdar://problem/16679363>
2717
2718         Reviewed by Simon Fraser.
2719
2720         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
2721         (createBitmapContextFromWebView):
2722         DRT checks with the WebView to determine whether it can use the window's
2723         backing store directly or (because of compositing) needs to take a WindowServer
2724         snapshot. However, on some platforms and in some situations, the window can
2725         be layer backed without the WebView necessarily currently being composited.
2726         We should check with the window in addition to the WebView before going
2727         ahead and using its backing store.
2728
2729 2014-04-22  Tim Horton  <timothy_horton@apple.com>
2730
2731         DumpRenderTree generates white snapshots on some platforms
2732         https://bugs.webkit.org/show_bug.cgi?id=132026
2733         <rdar://problem/16679363>
2734
2735         Reviewed by Simon Fraser.
2736
2737         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
2738         Link DRT against QuartzCore.
2739
2740         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
2741         (createBitmapContextFromWebView):
2742         Force CoreAnimation to synchronously update layers in a more explicit
2743         way that doesn't depend on AppKit behavior. This is very similar to what
2744         WebKitTestRunner does (indirectly) during its force repaint.
2745
2746 2014-04-22  Brent Fulgham  <bfulgham@apple.com>
2747
2748         [Win] Support Python 2.7 in Cygwin
2749         https://bugs.webkit.org/show_bug.cgi?id=132023
2750
2751         Reviewed by Michael Saboff.
2752
2753         * Scripts/webkitdirs.pm:
2754         (checkInstalledTools): Remove check for Python 2.7, since
2755         it now works properly.
2756
2757 2014-04-22  Filip Pizlo  <fpizlo@apple.com>
2758
2759         Switch the LLVMForJSC target to using the LLVM in /usr/local rather than /usr/local/LLVMForJavaScriptCore on iOS
2760         https://bugs.webkit.org/show_bug.cgi?id=130867
2761         <rdar://problem/16432456> 
2762
2763         Reviewed by Mark Hahnenberg.
2764
2765         * Scripts/build-webkit:
2766         * Scripts/copy-webkitlibraries-to-product-directory:
2767
2768 2014-04-22  Gustavo Noronha Silva  <gns@gnome.org>
2769
2770         [GTK] Fails to build documentation when output is redirected
2771         https://bugs.webkit.org/show_bug.cgi?id=131178
2772
2773         Reviewed by Martin Robinson.
2774
2775         * gtk/generate-gtkdoc: set the output for stdout and stderr to UTF-8
2776         explicitly to avoid encoding issues when they are redirected.
2777
2778 2014-04-22  ChangSeok Oh  <changseok.oh@collabora.com>
2779
2780         [GTK] YCM choose a newer compile_commands.json in between Release or Debug
2781         https://bugs.webkit.org/show_bug.cgi?id=131911
2782
2783         Reviewed by Martin Robinson.
2784
2785         common.get_build_path returns release path even though Debug configuration
2786         is newer than Release. So YouCompleteMe is used to refer old build setup inadvertently.
2787
2788         * gtk/ycm_extra_conf.py:
2789         (get_build_path): Compare modified time of Release and Debug. And return a recent modified path.
2790         (FlagsForFile):
2791
2792 2014-04-21  Brent Fulgham  <bfulgham@apple.com>
2793
2794         Unreviewed build fix.
2795
2796         * DumpRenderTree/mac/EventSendingController.mm:
2797         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
2798         Correct a typo that prevented tests from working properly.
2799
2800 2014-04-21  Martin Robinson  <mrobinson@igalia.com>
2801
2802         [GTK] Should have the ability to output composited contents during layout testing
2803         https://bugs.webkit.org/show_bug.cgi?id=131864
2804
2805         Reviewed by Philippe Normand.
2806
2807         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
2808         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Add a path that paints the widget contents
2809         to an image surface. We run the main loop a bit to match the implementation from WebKit1 and EFL.
2810         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2811         (WTR::PlatformWebView::windowSnapshotImage): Use the new UI-process path on GTK+.
2812
2813 2014-04-21  Sam Weinig  <sam@webkit.org>
2814
2815         Attempt to fix the tests.
2816
2817         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
2818         (-[DidFailProvisionalNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2819         Add policy handler to override the new default of denying loads that NSURLConnection cannot handle.
2820
2821 2014-04-21  Filip Pizlo  <fpizlo@apple.com>
2822
2823         Unreviewed test gardening, make no-eager runs run everything except eager (as opposed to
2824         being the same as a "quick run", which is meant for genuinely slow tests).
2825
2826         * Scripts/run-jsc-stress-tests:
2827
2828 2014-04-21  Darin Adler  <darin@apple.com>
2829
2830         Add HashSet::takeAny
2831         https://bugs.webkit.org/show_bug.cgi?id=131928
2832
2833         Reviewed by Benjamin Poulain.
2834
2835         * TestWebKitAPI/Tests/WTF/HashSet.cpp: Added a test for takeAny.
2836
2837 2014-04-20  Dan Bernstein  <mitz@apple.com>
2838
2839         Fixed a test timing out after r167572.
2840
2841         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
2842         (-[NavigationDelegate webView:didFinishNavigation:]): Renamed from
2843         -webView:didFinishLoadingNavigation:.
2844
2845 2014-04-20  Commit Queue  <commit-queue@webkit.org>
2846
2847         Unreviewed, rolling out r167510.
2848         https://bugs.webkit.org/show_bug.cgi?id=131915
2849
2850         broke GTK Debug bot (Requested by philn on #webkit).
2851
2852         Reverted changeset:
2853
2854         "[GTK] Add llvmpipe (Mesa) to the JHBuild moduleset and force
2855         it when running layout tests"
2856         https://bugs.webkit.org/show_bug.cgi?id=131472
2857         http://trac.webkit.org/changeset/167510
2858
2859 2014-04-18  Martin Robinson  <mrobinson@igalia.com>
2860
2861         [GTK] Add llvmpipe (Mesa) to the JHBuild moduleset and force it when running layout tests
2862         https://bugs.webkit.org/show_bug.cgi?id=131472
2863
2864         Reviewed by Philippe Normand.
2865
2866         * Scripts/webkitpy/port/gtk.py:
2867         (GtkPort.setup_environ_for_server): Use the LLVMPIPE_LIBGL_PATH to set the LD_LIBRARY_PATH
2868         when running WebKitTestRunner with run-webkit-tests.
2869         * gtk/jhbuild.modules: Add Mesa to the modulelist so that the llvmpipe libGL is build, but not
2870         installed.
2871         * gtk/jhbuildrc: Set the LLVMPIPE_LIBGL_PATH environment variable so that the test driver knows
2872         how to properly set the LD_LIBRARY_PATH variable. We do this because it is much easier to
2873         calculate the path in the jhbuildrc than in the test driver code. This simplifies things a great
2874         deal.
2875
2876 2014-04-18  Alexey Proskuryakov  <ap@apple.com>
2877
2878         DownloadDecideDestinationCrash API test uses an incorrect value for path
2879         https://bugs.webkit.org/show_bug.cgi?id=131845
2880         <rdar://problem/15925560>
2881
2882         Reviewed by Enrica Casucci.
2883
2884         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
2885         (TestWebKitAPI::decideDestinationWithSuggestedFilename):
2886
2887 2014-04-17  Alexey Proskuryakov  <ap@apple.com>
2888
2889         [Mac] AttributedStringTest API tests fail with async text input
2890         https://bugs.webkit.org/show_bug.cgi?id=131833
2891
2892         Reviewed by Enrica Casucci.
2893
2894         Don't run sync NSTextInputClient tests where we don't implement these calls.
2895
2896         * TestWebKitAPI/Tests/mac/AttributedString.mm:
2897         (TestWebKitAPI::AttributedStringTest_CustomFont::didLoadURL):
2898         (TestWebKitAPI::AttributedStringTest_CustomFont::runSyncTest):
2899         (TestWebKitAPI::AttributedStringTest_Strikethrough::didLoadURL):
2900         (TestWebKitAPI::AttributedStringTest_Strikethrough::runSyncTest):
2901         (TestWebKitAPI::AttributedStringTest_CustomFont::runTest): Deleted.
2902         (TestWebKitAPI::AttributedStringTest_Strikethrough::runTest): Deleted.
2903
2904 2014-04-18  Philippe Normand  <pnormand@igalia.com>
2905
2906         Remove NETWORK_INFO support
2907         https://bugs.webkit.org/show_bug.cgi?id=131841
2908
2909         Reviewed by Gyuyoung Kim.
2910
2911         * Scripts/webkitperl/FeatureList.pm:
2912
2913 2014-04-17  ChangSeok Oh  <changseok.oh@collabora.com>
2914
2915         [GTK] YouCompleteMe doesn't work for cmake build system.
2916         https://bugs.webkit.org/show_bug.cgi?id=131591
2917
2918         Reviewed by Martin Robinson.
2919
2920         Add cmake build system support for YouCompleteMe. It should work regardless of
2921         using make or ninja. In addition, autotools related code is removed since it's
2922         not used anymore in WebKit.
2923
2924         * Scripts/webkitdirs.pm:
2925         (generateBuildSystemFromCMakeProject):
2926         * gtk/ycm_extra_conf.py:
2927         (transform_relative_paths_to_absolute_paths):
2928         (FlagsForFile):
2929
2930 2014-04-17  Anders Carlsson  <andersca@apple.com>
2931
2932         Fix build.
2933
2934         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2935         (-[DownloadNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2936         (-[ConvertResponseToDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2937
2938 2014-04-17  Anders Carlsson  <andersca@apple.com>
2939
2940         Remove unused API enums
2941         https://bugs.webkit.org/show_bug.cgi?id=131836
2942
2943         Reviewed by Tim Horton.
2944
2945         * MiniBrowser/mac/WK2BrowserWindowController.m:
2946         (-[WK2BrowserWindowController webView:decidePolicyForNavigationResponse:decisionHandler:]):
2947
2948 2014-04-16  Brent Fulgham  <bfulgham@apple.com>
2949
2950         [Win] A few final cleanups to the DataObject classes.
2951         https://bugs.webkit.org/show_bug.cgi?id=131784
2952
2953         Reviewed by Anders Carlsson.
2954
2955         * DumpRenderTree/win/DRTDataObject.cpp:
2956         (DRTDataObject::clearData): Use 'last()' method.
2957         * DumpRenderTree/win/UIDelegate.cpp:
2958         (DRTUndoStack::pop): Use 'takeLast()' method.
2959
2960 2014-04-17  Andres Gomez  <agomez@igalia.com>
2961
2962         [Win] cygwin to keep installing curl 7.33.0-1 and subversion 1.7.14-1
2963         https://bugs.webkit.org/show_bug.cgi?id=131365
2964
2965         Reviewed by Brent Fulgham.
2966
2967         The cygwin installer is now downloading the wanted versions for
2968         the local installation given to the setup wizard.
2969
2970         * CygwinDownloader/cygwin-downloader.py:
2971         * CygwinDownloader/cygwin-downloader.zip:
2972
2973 2014-04-17  Adrian Perez de Castro  <aperez@igalia.com>
2974
2975         [GTK] Make run-webkit-tests always use WKTR
2976         https://bugs.webkit.org/show_bug.cgi?id=131737
2977
2978         Reviewed by Darin Adler.
2979
2980         Now that the GTK+ port only has support for WebKit2, instruct
2981         run-webkit-tests to always use WKTR. This avoids needing to pass
2982         flag "-2" every time.
2983
2984         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 
2985         (_set_up_derived_options): Always set webkit_test_runner when
2986         the platform is GTK+.
2987
2988 2014-04-17  Brendan Long  <b.long@cablelabs.com>
2989
2990         [Gtk] Install ninja-build in Tools/gtk/install-dependencies
2991         https://bugs.webkit.org/show_bug.cgi?id=131760
2992
2993         Reviewed by Philippe Normand.
2994
2995         * gtk/install-dependencies: Install ninja-build when it's available.
2996
2997 2014-04-16  peavo@outlook.com  <peavo@outlook.com>
2998
2999         [Win] run-javascriptcore-tests fails to run.
3000         https://bugs.webkit.org/show_bug.cgi?id=131761
3001
3002         Reviewed by Brent Fulgham.
3003
3004         * Scripts/build-jsc: For now, don't try to build bmalloc on Windows.
3005
3006 2014-04-16  Andres Gomez  <agomez@igalia.com>
3007
3008         [Win] Pass default parameters to cygwin setup wizard
3009         https://bugs.webkit.org/show_bug.cgi?id=131361
3010
3011         Reviewed by Brent Fulgham.
3012
3013         Added some parameters to the cygwin setup wizard so the user
3014         doesn't really have to do any interaction.
3015
3016         * CygwinDownloader/cygwin-downloader.py:
3017         * CygwinDownloader/cygwin-downloader.zip:
3018
3019 2014-04-15  Brent Fulgham  <bfulgham@apple.com>
3020
3021         [Win] Eliminate use of deleteAllValues in Windows Files
3022         https://bugs.webkit.org/show_bug.cgi?id=131631
3023
3024         Reviewed by Darin Adler.
3025
3026         Switch to std::unique_ptr for memory lifetime. Get rid of
3027         deleteAllValues now that it is no longer needed. Use ranged
3028         for loops where possible.
3029
3030         * DumpRenderTree/win/DRTDataObject.cpp:
3031         (WCEnumFormatEtc::WCEnumFormatEtc):
3032         (DRTDataObject::~DRTDataObject):
3033         (DRTDataObject::GetData):
3034         (DRTDataObject::QueryGetData):
3035         (DRTDataObject::SetData):
3036         (DRTDataObject::clearData):
3037         * DumpRenderTree/win/DRTDataObject.h:
3038         * DumpRenderTree/win/UIDelegate.cpp:
3039         (DRTUndoObject::DRTUndoObject):
3040         (DRTUndoObject::~DRTUndoObject):
3041         (DRTUndoStack::~DRTUndoStack):
3042         (DRTUndoStack::clear):
3043         (DRTUndoStack::pop):
3044         (DRTUndoManager::DRTUndoManager):
3045         (DRTUndoManager::redo):
3046         (DRTUndoManager::undo):
3047         (UIDelegate::UIDelegate):
3048         (UIDelegate::resetUndoManager):
3049         * DumpRenderTree/win/UIDelegate.h:
3050
3051 2014-04-16  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3052
3053         [GTK] Unreviewed GTK gardening.
3054
3055         Update list of skipped unit tests:
3056
3057           Skip test: WebKit2Gtk/TestWebKitWebView:/webkit2/WebKitWebView/page-visibility
3058
3059           Unskip tests: WebKit2/TestWebKit2:WebKit2.ResizeReversePaginatedWebView
3060           and WebKit2/TestWebKit2:WebKit2.ScrollPinningBehaviors
3061
3062         * Scripts/run-gtk-tests:
3063         (TestRunner):
3064
3065 2014-04-16  Tim Horton  <timothy_horton@apple.com>
3066
3067         check-webkit-style doesn't check code style in .mm or .m files
3068         https://bugs.webkit.org/show_bug.cgi?id=131708
3069
3070         Reviewed by Darin Adler.
3071
3072         * Scripts/webkitpy/style/checker.py:
3073         * Scripts/webkitpy/style/checker_unittest.py:
3074         (CheckerDispatcherDispatchTest.test_cpp_paths):
3075         (CheckerDispatcherDispatchTest.test_text_paths):
3076         Check .mm and .m files as C++.
3077
3078         * Scripts/webkitpy/style/checkers/cpp.py:
3079         (check_spacing):
3080         Add an override for our ordinary "missing spaces around =" for @synthesize,
3081         which should look like "@synthesize propertyName=_varName;"
3082
3083         Add an override for "missing space before {" for blocks' "^{".
3084
3085         Don't follow the "extra space before [" rule for Objective-C, because
3086         it breaks this rule in a multitude of ways because of method calls.
3087
3088         (check_braces):
3089         Don't complain about { not being on the end of the previous line if
3090         the previous line starts with "- (" or "+ (", which would indicate a
3091         Objective-C method definition.
3092
3093 2014-04-16  Darin Adler  <darin@apple.com>
3094
3095         Make Vector::takeLast work with move-only types (and optimize for types where move is faster)
3096         https://bugs.webkit.org/show_bug.cgi?id=131735
3097
3098         Reviewed by Alexey Proskuryakov.
3099
3100         * TestWebKitAPI/Tests/WTF/Vector.cpp: Added a test for Vector::takeLast with move only types.
3101         Fixed invocations of EXPECT macros so the expected value is on the left, and the test result
3102         is on the right. This can be confusing since our JavaScript test framework does it the opposite
3103         way, but gtest works better this way.
3104
3105 2014-04-15  Hyowon Kim  <hw1008.kim@samsung.com>
3106
3107         [EFL] Fix problems with the pixel dump.
3108         https://bugs.webkit.org/show_bug.cgi?id=131265
3109
3110         Reviewed by Gyuyoung Kim.
3111
3112         Painting and compositing paths of WebKit-EFL were totally modified from r166768.
3113         However pixel dump codes still call deprecated functions like ewk_view_paint(),
3114         which causes that nothing is drawn.
3115
3116         This patch adds new member functions to AcceleratedCompositingContext to support pixel dump.
3117         One of new functions is AcceleratedCompositingContext::extractImageData(),
3118         which replaces deprecated function calls. Besides the extractImageData() is invoked by
3119         ewk_view_screenshot_contents_get() in order to take the visible content displayed on the EFL webview.
3120
3121         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
3122         (createBitmapContextFromWebView): Add to call DumpRenderTreeSupportEfl::forcePaint().
3123
3124 2014-04-15  Filip Pizlo  <fpizlo@apple.com>
3125
3126         Update LLVM export scrpt to handle the build directory being different from the
3127         source directory.
3128
3129         Rubber stamped by Geoffrey Garen.
3130
3131         * Scripts/export-llvm-build:
3132
3133 2014-04-15  Ryosuke Niwa  <rniwa@webkit.org>
3134
3135         Update the hyperlink to waterfall views of perf bots on build.webkit.org
3136         https://bugs.webkit.org/show_bug.cgi?id=131695
3137
3138         Reviewed by Antti Koivisto.
3139
3140         Updated.
3141
3142         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
3143
3144 2014-04-15  Carlos Garcia Campos  <cgarcia@igalia.com>
3145
3146         [GTK] Reduce the binary size by compressing the text based web inspector resources
3147         https://bugs.webkit.org/show_bug.cgi?id=121545
3148
3149         Reviewed by Gustavo Noronha Silva.
3150
3151         Compress text based files when compiling inspector resources. It
3152         reduces the binary size in 3MB.
3153
3154         * gtk/generate-inspector-gresource-manifest.py:
3155         (find_all_files_in_directory):
3156         (is_compressible):
3157
3158 2014-04-14  Alexey Proskuryakov  <ap@apple.com>
3159
3160         Remove Gtk WebKit1 tester.
3161
3162         Gtk WebKit1 port no longer exists, and dashboard was trying to load its tester
3163         results over and over as fast as it could.
3164
3165         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3166         (WebKitBuildbot):
3167
3168 2014-04-14  Alexey Proskuryakov  <ap@apple.com>
3169
3170         Wrong link for webkitpy tests results in dashboard popover
3171         https://bugs.webkit.org/show_bug.cgi?id=131664
3172
3173         Reviewed by Timothy Hatcher.
3174
3175         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3176         (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds):
3177         Use a correct link.
3178
3179 2014-04-14  Alexey Proskuryakov  <ap@apple.com>
3180
3181         Update webkitpy regression test result that started to fail after http://trac.webkit.org/r167243
3182
3183         I'm not sure whether the changes are desirable, but am not suspicious enough to roll out.
3184
3185         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
3186         (CommitMessageForThisCommitTest):
3187
3188 2014-04-14  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
3189
3190         Fix commit-log-editor bug revealed by r165447
3191         https://bugs.webkit.org/show_bug.cgi?id=130676
3192
3193         Reviewed by Csaba Osztrogonác.
3194
3195         * Scripts/commit-log-editor:
3196         (createCommitMessage): Omitting empty Source/JavaScriptCore:... blocks.
3197         Add \n before the first block too, because the longest common prefix now ends with only one newline.
3198         (removeLongestCommonPrefixEndingInNewline): The longest common prefix ends with only one newline,
3199         now the last block of the common prefix isn't duplicated below. Changing the function name accordingly.
3200
3201 2014-04-13  Darin Adler  <darin@apple.com>
3202
3203         userVisibleString should not try to "encode" host names
3204         https://bugs.webkit.org/show_bug.cgi?id=131587
3205         rdar://problem/14686849
3206
3207         Reviewed by Alexey Proskuryakov.
3208
3209         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added URLExtras.mm.
3210
3211         * TestWebKitAPI/Tests/mac/URLExtras.mm: Added. A few tests for WebCoreNSURLExtras.
3212         Coverage is tiny at this point; we could add a lot more cases!
3213
3214 2014-04-13  Jaehun Lim  <ljaehun.lim@samsung.com>
3215
3216         Use #include instead of #import
3217         https://bugs.webkit.org/show_bug.cgi?id=131604
3218
3219         Reviewed by Darin Adler.
3220
3221         Fix "warning: #import is a deprecated GCC extension [-Wdeprecated]".
3222
3223         * TestWebKitAPI/Tests/WTF/StringView.cpp:
3224
3225 2014-04-12  Filip Pizlo  <fpizlo@apple.com>
3226
3227         Make slow-stress tests run faster by running fewer VM variants.
3228
3229         Rubber stamped by Geoffrey Garen.
3230
3231         * Scripts/run-javascriptcore-tests:
3232         * Scripts/run-jsc-stress-tests:
3233
3234 2014-04-10  Zan Dobersek  <zdobersek@igalia.com>
3235
3236         [CMake] Add missing WTF unit tests
3237         https://bugs.webkit.org/show_bug.cgi?id=131459
3238
3239         Reviewed by Martin Robinson.
3240
3241         * TestWebKitAPI/CMakeLists.txt: Add a few missing source files
3242         that should be compiled into the TestWTF binary.
3243
3244 2014-04-10  Brendan Long  <b.long@cablelabs.com>
3245
3246         [Gtk] run-launcher doesn't work by default
3247         https://bugs.webkit.org/show_bug.cgi?id=131494
3248
3249         Reviewed by Philippe Normand.
3250
3251         * Scripts/run-launcher: Always use MiniBrowser for WebKitGTK.
3252         * Scripts/webkitdirs.pm:
3253         (launcherName): Same.
3254         * Scripts/webkitpy/style/checker.py: Remove reference to GtkLauncher.
3255         * gtk/common.py:
3256         (get_build_path.is_valid_build_directory): Same.
3257         * gtk/manifest.txt: Same.
3258
3259 2014-04-09  Commit Queue  <commit-queue@webkit.org>
3260
3261         Unreviewed, rolling out r167046.
3262         https://bugs.webkit.org/show_bug.cgi?id=131479
3263
3264         Caused 300+ failures on Mavericks WK1 tester (Requested by ap
3265         on #webkit).
3266
3267         Reverted changeset:
3268
3269         "Remove "System Font" from whitelisted DRT fonts and char
3270         width calculations"
3271         https://bugs.webkit.org/show_bug.cgi?id=131411
3272         http://trac.webkit.org/changeset/167046
3273
3274 2014-04-09  Myles C. Maxfield  <mmaxfield@apple.com>
3275
3276         Remove "System Font" from whitelisted DRT fonts and char width calculations
3277         https://bugs.webkit.org/show_bug.cgi?id=131411
3278
3279         Reviewed by Tim Horton.
3280
3281         Covered by existing tests.
3282
3283         * DumpRenderTree/mac/DumpRenderTree.mm:
3284         (allowedFontFamilySet):
3285
3286 2014-04-09  Myles C. Maxfield  <mmaxfield@apple.com>
3287
3288         systemHiddenFontFamilySet in DRT is unnecessary
3289         https://bugs.webkit.org/show_bug.cgi?id=131414
3290
3291         Reviewed by Tim Horton.
3292
3293         It doesn't seem to affect test results on my machine.
3294
3295         * DumpRenderTree/mac/DumpRenderTree.mm:
3296         (drt_NSFontManager_availableFonts):
3297         (systemHiddenFontFamilySet): Deleted.
3298
3299 2014-04-09  Brent Fulgham  <bfulgham@apple.com>
3300
3301         [Win] Unreviewed test fix: Don't double-release BSTR.
3302
3303         * DumpRenderTree/win/DumpRenderTree.cpp:
3304         (dump): Remove unneeded call to SysFreeString now that we are
3305         using _bstr_t for this variable.
3306
3307 2014-04-09  Brent Fulgham  <bfulgham@apple.com>
3308
3309         [Win] Various DumpRenderTree Fixes.
3310         https://bugs.webkit.org/show_bug.cgi?id=131446.
3311
3312         Reviewed by Tim Horton.
3313
3314         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3315         (AccessibilityUIElement::title): Switch to _bstr_t. Use JSStringCreateWithBSTR.
3316         (AccessibilityUIElement::description): Ditto.
3317         (AccessibilityUIElement::helpText): Ditto.
3318         (AccessibilityUIElement::intValue): Ditto.
3319         (AccessibilityUIElement::isPressActionSupported): Ditto.
3320         (AccessibilityUIElement::accessibilityValue): Ditto.
3321         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
3322         (DRTDesktopNotificationPresenter::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
3323         (DRTDesktopNotificationPresenter::AddRef): Ditto.
3324         (DRTDesktopNotificationPresenter::Release): Ditto.
3325         (DRTDesktopNotificationPresenter::showDesktopNotification): Switch to _bstr_t. Use JSStringCreateWithBSTR.
3326         (DRTDesktopNotificationPresenter::cancelDesktopNotification): Ditto.
3327         (DRTDesktopNotificationPresenter::notificationDestroyed): Ditto.
3328         (DRTDesktopNotificationPresenter::checkNotificationPermission): Ditto.
3329         (DRTDesktopNotificationPresenter::requestNotificationPermission): Ditto.
3330         * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
3331         * DumpRenderTree/win/DumpRenderTree.cpp:
3332         (dumpFrameScrollPosition): Ditto.
3333         (dumpFramesAsText): Ditto.
3334         (compareHistoryItems): Ditto.
3335         (dumpHistoryItem): Ditto.
3336         (dump): Ditto.
3337         (resetDefaultsToConsistentValues): Ditto.
3338         (resetWebViewToConsistentStateBeforeTesting): Ditto.
3339         (runTest): Ditto.
3340         (createWebViewAndOffscreenWindow): Ditto.
3341         * DumpRenderTree/win/EditingDelegate.cpp:
3342         (EditingDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
3343         (EditingDelegate::AddRef): Ditto.
3344         (EditingDelegate::Release): Ditto.
3345         (dumpPath): Switch to _bstr_t. Use JSStringCreateWithBSTR
3346         (EditingDelegate::shouldBeginEditingInDOMRange): Get rid of uneeded STDMETHODCALLTYPE declaration.
3347         (EditingDelegate::shouldEndEditingInDOMRange): Ditto.
3348         (EditingDelegate::shouldInsertNode): Ditto.
3349         (EditingDelegate::shouldInsertText): Ditto.
3350         (EditingDelegate::shouldDeleteDOMRange): Ditto.
3351         (EditingDelegate::shouldChangeSelectedDOMRange): Ditto.
3352         (EditingDelegate::shouldApplyStyle): Ditto.
3353         (EditingDelegate::shouldChangeTypingStyle): Ditto.
3354         (EditingDelegate::doPlatformCommand): Ditto.
3355         (EditingDelegate::webViewDidBeginEditing): Switch to _bstr_t. Use JSStringCreateWithBSTR.
3356         (EditingDelegate::webViewDidChange): Ditto.
3357         (EditingDelegate::webViewDidEndEditing): Ditto.
3358         (EditingDelegate::webViewDidChangeTypingStyle): Ditto.
3359         (EditingDelegate::webViewDidChangeSelection): Ditto.
3360         (EditingDelegate::checkSpellingOfString): Ditto.
3361         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3362         (descriptionSuitableForTestResult): Switch to _bstr_t. Use JSStringCreateWithBSTR.
3363         (FrameLoadDelegate::FrameLoadDelegate): Ditto.
3364         (FrameLoadDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
3365         (FrameLoadDelegate::AddRef): Ditto.
3366         (FrameLoadDelegate::Release): Ditto.
3367         (FrameLoadDelegate::didStartProvisionalLoadForFrame): Switch to _bstr_t. Use JSStringCreateWithBSTR.
3368         (FrameLoadDelegate::didReceiveServerRedirectForProvisionalLoadForFrame): Ditto.
3369         (FrameLoadDelegate::didFailProvisionalLoadWithError): Ditto.
3370         (FrameLoadDelegate::didCommitLoadForFrame): Ditto.
3371         (FrameLoadDelegate::didReceiveTitle): Ditto.
3372         (FrameLoadDelegate::didChangeIcons): Ditto.
3373         (delegatesWithDelayedWork): Ditto.
3374         (FrameLoadDelegate::didFinishLoadForFrame): Ditto.
3375         (FrameLoadDelegate::didFailLoadWithError): Ditto.
3376         (FrameLoadDelegate::willPerformClientRedirectToURL): Ditto.
3377         (FrameLoadDelegate::didCancelClientRedirectForFrame): Ditto.
3378         (FrameLoadDelegate::willCloseFrame): Ditto.
3379         (FrameLoadDelegate::didFinishDocumentLoadForFrame): Ditto.
3380         (FrameLoadDelegate::didHandleOnloadEventsForFrame): Ditto.
3381         (FrameLoadDelegate::didFirstVisuallyNonEmptyLayoutInFrame): Ditto.
3382         (FrameLoadDelegate::didDisplayInsecureContent): Ditto.
3383         (FrameLoadDelegate::didRunInsecureContent): Ditto.
3384         * DumpRenderTree/win/FrameLoadDelegate.h:
3385         * DumpRenderTree/win/HistoryDelegate.cpp:
3386         (HistoryDelegate::didNavigateWithNavigationData): Switch to _bstr_t. Use JSStringCreateWithBSTR.
3387         (HistoryDelegate::updateHistoryTitle): Ditto.
3388         (HistoryDelegate::populateVisitedLinksForWebView): Ditto.
3389         * DumpRenderTree/win/PolicyDelegate.cpp:
3390         (dumpPath):
3391         (PolicyDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
3392         (PolicyDelegate::AddRef): Ditto.
3393         (PolicyDelegate::Release): Ditto.
3394         (PolicyDelegate::decidePolicyForNavigationAction): Switch to _bstr_t. Use JSStringCreateWithBSTR.
3395         (PolicyDelegate::unableToImplementPolicyWithError): Ditto.
3396         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3397         (ResourceLoadDelegate::descriptionSuitableForTestResult): Switch to _bstr_t. Use JSStringCreateWithBSTR.
3398         (ResourceLoadDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
3399         (ResourceLoadDelegate::AddRef): Ditto.
3400         (ResourceLoadDelegate::Release): Ditto.
3401         (ResourceLoadDelegate::identifierForInitialRequest): Switch to _bstr_t. Use JSStringCreateWithBSTR.
3402         (ResourceLoadDelegate::removeIdentifierForRequest): Ditto.
3403         (ResourceLoadDelegate::willSendRequest): Ditto.
3404         (ResourceLoadDelegate::didReceiveAuthenticationChallenge): Ditto.
3405         (ResourceLoadDelegate::didReceiveResponse): Ditto.
3406         (ResourceLoadDelegate::didFinishLoadingFromDataSource): Ditto.
3407         (ResourceLoadDelegate::didFailLoadingWithError): Ditto.
3408         * DumpRenderTree/win/TestRunnerWin.cpp: Ditto.
3409         (TestRunner::queueLoad): Switch to _bstr_t. Use JSStringCreateWithBSTR.
3410         (TestRunner::setUserStyleSheetLocation): Ditto.
3411         (TestRunner::execCommand): Ditto.
3412         (TestRunner::overridePreference): Ditto.
3413         (TestRunner::evaluateScriptInIsolatedWorld): Ditto.
3414         * DumpRenderTree/win/TextInputControllerWin.cpp: Ditto.
3415         (TextInputController::setMarkedText): Switch to _bstr_t. Use JSStringCreateWithBSTR.
3416         (TextInputController::insertText): Ditto.
3417         * DumpRenderTree/win/UIDelegate.cpp:
3418         (UIDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
3419         (UIDelegate::AddRef): Ditto.
3420         (UIDelegate::Release): Ditto.
3421         (UIDelegate::hasCustomMenuImplementation): Switch to _bstr_t. Use JSStringCreateWithBSTR.
3422         (UIDelegate::trackCustomPopupMenu): Ditto.
3423         (UIDelegate::registerUndoWithTarget): Ditto.
3424         (UIDelegate::removeAllActionsWithTarget): Ditto.
3425         (UIDelegate::setActionTitle): Ditto.
3426         (UIDelegate::undo): Ditto.
3427         (UIDelegate::redo): Ditto.
3428         (UIDelegate::canUndo): Ditto.
3429         (UIDelegate::canRedo): Ditto.
3430         (UIDelegate::printFrame): Ditto.
3431         (UIDelegate::ftpDirectoryTemplatePath): Ditto.
3432         (UIDelegate::webViewHeaderHeight): Ditto.
3433         (UIDelegate::webViewFooterHeight): Ditto.
3434         (UIDelegate::drawHeaderInRect): Ditto.
3435         (UIDelegate::drawFooterInRect): Ditto.
3436         (UIDelegate::webViewPrintingMarginRect): Ditto.
3437         (UIDelegate::canRunModal): Ditto.
3438         (UIDelegate::createModalDialog): Ditto.
3439         (UIDelegate::runModal): Ditto.
3440         (UIDelegate::isMenuBarVisible): Ditto.
3441         (UIDelegate::setMenuBarVisible): Ditto.
3442         (UIDelegate::runDatabaseSizeLimitPrompt): Ditto.
3443         (UIDelegate::paintCustomScrollbar): Ditto.
3444         (UIDelegate::paintCustomScrollCorner): Ditto.
3445         (UIDelegate::setFrame): Ditto.
3446         (UIDelegate::webViewFrame): Ditto.
3447         (UIDelegate::runJavaScriptAlertPanelWithMessage): Ditto.
3448         (UIDelegate::runJavaScriptConfirmPanelWithMessage): Ditto.
3449         (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Ditto.
3450         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage): Ditto.
3451         (UIDelegate::webViewAddMessageToConsole): Ditto.
3452         (UIDelegate::doDragDrop): Ditto.
3453         (UIDelegate::webViewGetDlgCode): Ditto.
3454         (UIDelegate::createWebViewWithRequest): Ditto.
3455         (UIDelegate::webViewClose): Ditto.
3456         (UIDelegate::webViewFocus): Ditto.
3457         (UIDelegate::webViewUnfocus): Ditto.
3458         (UIDelegate::webViewPainted): Ditto.
3459         (UIDelegate::exceededDatabaseQuota): Ditto.
3460         (UIDelegate::embeddedViewWithArguments): Ditto.
3461         (UIDelegate::webViewClosing): Ditto.
3462         (UIDelegate::webViewSetCursor): Ditto.
3463         (UIDelegate::webViewDidInvalidate): Ditto.
3464         (UIDelegate::setStatusText): Ditto.
3465         (UIDelegate::desktopNotificationsDelegate): Ditto.
3466         (UIDelegate::drawBackground): Ditto.
3467         (UIDelegate::decidePolicyForGeolocationRequest): Ditto.
3468         (UIDelegate::didPressMissingPluginButton): Ditto.
3469         * DumpRenderTree/win/WorkQueueItemWin.cpp: Ditto.
3470         (LoadItem::invoke):  Switch to _bstr_t. Use JSStringCreateWithBSTR.
3471         (LoadHTMLStringItem::invoke): Ditto.
3472         (ScriptItem::invoke): Ditto.
3473
3474 2014-04-09  Gergo Balogh  <gbalogh.u-szeged@partner.samsung.com>
3475
3476         Stylechecker: False positive on inline asm code.
3477         https://bugs.webkit.org/show_bug.cgi?id=130570
3478
3479         Reviewed by Csaba Osztrogonác.
3480
3481         Disable stylechecking in asm blocks.
3482
3483         * Scripts/webkitpy/style/checkers/cpp.py:
3484         (process_line):
3485         (_InlineASMState):
3486         (_InlineASMState.__init__):
3487         (_InlineASMState.process_line):
3488         (_InlineASMState.isInside):
3489         (_process_lines):
3490         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3491         (WebKitStyleTest.test_member_initialization_list):
3492
3493 2014-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
3494
3495         [GTK] Move WebKit1 unit tests resources used by WebKit2 unit tests to WebKit2 resources dir
3496         https://bugs.webkit.org/show_bug.cgi?id=131029
3497
3498         Reviewed by Philippe Normand.
3499
3500         Add blank.ico and test.pdf to resources dir of WebKit2Gtk unit
3501         tests and remove the getWebKit1TestResoucesDir() method.
3502
3503         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
3504         (testDownloadLocalFile): Use Test::getResourcesDir().
3505         (testDownloadLocalFileError): Ditto.
3506         (serverCallback): Ditto.
3507         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
3508         (serverCallback): Ditto.
3509         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
3510         (httpServerCallback): Ditto.
3511         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
3512         (serverCallback): Ditto.
3513         * TestWebKitAPI/Tests/WebKit2Gtk/resources/blank.ico: Added.
3514         * TestWebKitAPI/Tests/WebKit2Gtk/resources/test.pdf: Added.
3515         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
3516         (Test::getWebKit1TestResoucesDir): Deleted.
3517
3518 2014-04-09  Alexey Proskuryakov  <ap@apple.com>
3519
3520         [WK2] HTTP authentication regression tests fail
3521         https://bugs.webkit.org/show_bug.cgi?id=81627
3522         <rdar://problem/11079296>
3523
3524         Reviewed by Anders Carlsson.
3525
3526         * WebKitTestRunner/TestController.h:
3527         * WebKitTestRunner/TestController.cpp:
3528         (WTR::TestController::createWebViewWithOptions): Added canAuthenticateAgainstProtectionSpaceInFrame
3529         to pageLoaderClient structure.
3530         (WTR::TestController::canAuthenticateAgainstProtectionSpaceInFrame): Return true
3531         for password based authentication (we do get server trust challenges on some tests,
3532         which WKTR can't handle).
3533         When this client call is not implemented or returns false, didReceiveAuthenticationChallengeInFrame
3534         calls won't be made, at least on CFNetwork based platforms.
3535         (WTR::TestController::didReceiveAuthenticationChallengeInFrame): Changed the output
3536         to omit <unknown>. The resource is always unknown with WK2, and it doesn't really
3537         make sense to associate auth requests with individual resources - there can be
3538         multiple resources loading at once from the same protection space, so WebKit1 API
3539         that had a resource identifier was inherently racy.
3540
3541 2014-04-09  Ryuan Choi  <ryuan.choi@samsung.com>
3542
3543         [EFL] Change font path for DumpRenderTree and WebKitTestRunner
3544         https://bugs.webkit.org/show_bug.cgi?id=131427
3545
3546         Reviewed by Gyuyoung Kim.
3547
3548         Since r166973, font path was changed.
3549
3550         * DumpRenderTree/PlatformEfl.cmake:
3551         * WebKitTestRunner/PlatformEfl.cmake:
3552
3553 2014-04-08  Geoffrey Garen  <ggaren@apple.com>
3554
3555         Fix the build-jsc build
3556         https://bugs.webkit.org/show_bug.cgi?id=131410
3557
3558         Reviewed by Michael Saboff.
3559
3560         * Scripts/build-jsc: Make sure to build bmalloc before WTF, since
3561         WTF depends on it.
3562
3563 2014-04-08  Martin Robinson  <mrobinson@igalia.com>
3564
3565         [GTK] Remove WebKit1 unit tests
3566         https://bugs.webkit.org/show_bug.cgi?id=131359
3567
3568         Reviewed by Anders Carlsson.
3569
3570         Remove all WebKit1 GTK+ unit tests, in preparation for removing the WebKit1 port
3571         entirely. We also remove the list of skipped WebKi1 tests from run-gtk-tests, as
3572         they were inadvertently left in http://trac.webkit.org/changeset/166504.
3573
3574         * CMakeLists.txt: No longer load the WebKit1 unit test CMakeLists.txt file.
3575         * Scripts/run-gtk-tests: Remove skipped WebKit1 unit tests.
3576         * TestWebKitAPI/Tests/WebKitGtk/CMakeLists.txt: Removed.
3577         * TestWebKitAPI/Tests/WebKitGtk/resources/blank.ico: Removed.
3578         * TestWebKitAPI/Tests/WebKitGtk/resources/test.html: Removed.
3579         * TestWebKitAPI/Tests/WebKitGtk/resources/test.ogg: Removed.
3580         * TestWebKitAPI/Tests/WebKitGtk/resources/test.pdf: Removed.
3581         * TestWebKitAPI/Tests/WebKitGtk/resources/test.txt: Removed.
3582         * TestWebKitAPI/Tests/WebKitGtk/test_utils.c: Removed.
3583         * TestWebKitAPI/Tests/WebKitGtk/test_utils.h: Removed.
3584         * TestWebKitAPI/Tests/WebKitGtk/testapplicationcache.c: Removed.
3585         * TestWebKitAPI/Tests/WebKitGtk/testatk.c: Removed.
3586         * TestWebKitAPI/Tests/WebKitGtk/testatkroles.c: Removed.
3587         * TestWebKitAPI/Tests/WebKitGtk/testcontextmenu.c: Removed.
3588         * TestWebKitAPI/Tests/WebKitGtk/testcopyandpaste.c: Removed.
3589         * TestWebKitAPI/Tests/WebKitGtk/testdomdocument.c: Removed.
3590         * TestWebKitAPI/Tests/WebKitGtk/testdomdomwindow.c: Removed.
3591         * TestWebKitAPI/Tests/WebKitGtk/testdomnode.c: Removed.
3592         * TestWebKitAPI/Tests/WebKitGtk/testdownload.c: Removed.
3593         * TestWebKitAPI/Tests/WebKitGtk/testfavicondatabase.c: Removed.
3594         * TestWebKitAPI/Tests/WebKitGtk/testglobals.c: Removed.
3595         * TestWebKitAPI/Tests/WebKitGtk/testhittestresult.c: Removed.
3596         * TestWebKitAPI/Tests/WebKitGtk/testhttpbackend.c: Removed.
3597         * TestWebKitAPI/Tests/WebKitGtk/testkeyevents.c: Removed.
3598         * TestWebKitAPI/Tests/WebKitGtk/testloading.c: Removed.
3599         * TestWebKitAPI/Tests/WebKitGtk/testmimehandling.c: Removed.
3600         * TestWebKitAPI/Tests/WebKitGtk/testnetworkrequest.c: Removed.
3601         * TestWebKitAPI/Tests/WebKitGtk/testnetworkresponse.c: Removed.
3602         * TestWebKitAPI/Tests/WebKitGtk/testwebbackforwardlist.c: Removed.
3603         * TestWebKitAPI/Tests/WebKitGtk/testwebdatasource.c: Removed.
3604         * TestWebKitAPI/Tests/WebKitGtk/testwebframe.c: Removed.
3605         * TestWebKitAPI/Tests/WebKitGtk/testwebhistoryitem.c: Removed.
3606         * TestWebKitAPI/Tests/WebKitGtk/testwebinspector.c: Removed.
3607         * TestWebKitAPI/Tests/WebKitGtk/testwebplugindatabase.c: Removed.
3608         * TestWebKitAPI/Tests/WebKitGtk/testwebresource.c: Removed.
3609         * TestWebKitAPI/Tests/WebKitGtk/testwebsettings.c: Removed.
3610         * TestWebKitAPI/Tests/WebKitGtk/testwebview.c: Removed.
3611         * TestWebKitAPI/Tests/WebKitGtk/testwindow.c: Removed.
3612
3613 2014-04-08  Brent Fulgham  <bfulgham@apple.com>
3614
3615         Unreviewed gardening (Take 2): Prevent users from attempting
3616         to build with known invalid cURL. 
3617
3618         * Scripts/webkitdirs.pm:
3619         (checkInstalledTools): Check for 7.34.0 (the broken version), not
3620         7.33.0 (the known good version).
3621
3622 2014-04-08  Martin Robinson  <mrobinson@igalia.com>
3623
3624         [GTK] Remove DumpRenderTree and GtkLauncher
3625         https://bugs.webkit.org/show_bug.cgi?id=131373
3626
3627         Reviewed by Andreas Kling.
3628
3629         Remove the GTK+ port of DumpRenderTree and GtkLauncher. These tools are
3630         no longer necessary now that WebKit1 GTK+ will be removed.
3631
3632         * CMakeLists.txt:
3633         * DumpRenderTree/PlatformGTK.cmake: Removed.
3634         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp: Removed.
3635         * DumpRenderTree/gtk/DumpRenderTree.cpp: Removed.
3636         * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Removed.
3637         * DumpRenderTree/gtk/EditingCallbacks.cpp: Removed.
3638         * DumpRenderTree/gtk/EditingCallbacks.h: Removed.
3639         * DumpRenderTree/gtk/EventSender.cpp: Removed.
3640         * DumpRenderTree/gtk/EventSender.h: Removed.
3641         * DumpRenderTree/gtk/GCControllerGtk.cpp: Removed.
3642         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp: Removed.
3643         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.cpp: Removed.
3644         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.h: Removed.
3645         * DumpRenderTree/gtk/TestRunnerGtk.cpp: Removed.
3646         * DumpRenderTree/gtk/TextInputController.cpp: Removed.
3647         * DumpRenderTree/gtk/TextInputController.h: Removed.
3648         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Removed.