6a5235430fca889f9a0f831f3028d1e39f2c35af
[WebKit-https.git] / Tools / ChangeLog
1 2013-12-16  Simon Fraser  <simon.fraser@apple.com>
2
3         Add a menu option to MiniBrowser to enable UI-side compositing
4         https://bugs.webkit.org/show_bug.cgi?id=125793
5
6         Reviewed by Anders Carlsson.
7         
8         Make it possible to test UI-side compositing in MiniBrowser WK2 windows.
9
10         * MiniBrowser/mac/BrowserWindowController.h: Add optional protocol method
11         to toggle UI-side compositing.
12         * MiniBrowser/mac/MainMenu.xib: Add menu item to Debug menu.
13         * MiniBrowser/mac/WK2BrowserWindowController.m:
14         (-[WK2BrowserWindowController validateMenuItem:]):
15         (-[WK2BrowserWindowController isUISideCompositingEnabled]):
16         (-[WK2BrowserWindowController toggleUISideCompositing:]):
17         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
18         Adjust the window title to indicate whether the window is using UI-side compositing.
19
20 2013-12-16  Commit Queue  <commit-queue@webkit.org>
21
22         Unreviewed, rolling out r160645.
23         http://trac.webkit.org/changeset/160645
24         https://bugs.webkit.org/show_bug.cgi?id=125787
25
26         Change breaks test-webkitpy (Requested by bfulgham on
27         #webkit).
28
29         * Scripts/prepare-ChangeLog:
30         (get_selector_line_ranges_for_css):
31
32 2013-12-16  David Farler  <dfarler@apple.com>
33
34         [ASAN] WebKitLauncher: Include libasancrashreporter.dylib in DYLD_INSERT_LIBRARIES if it exists
35         https://bugs.webkit.org/show_bug.cgi?id=124610
36
37         Reviewed by Mark Rowe.
38
39         * WebKitLauncher/WebKitNightlyEnabler.m:
40         (enableWebKitNightlyBehaviour):
41         Add libasancrashreporter.dylib to DYLD_INSERT_LIBRARIES.
42         * WebKitLauncher/main.m:
43         (main):
44         Include both libasancrashreporter and the nightly enabler to
45         the list of libraries to insert.
46
47 2013-12-16  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
48
49         Resolve inconsistant style warning caused by r160319.
50         https://bugs.webkit.org/show_bug.cgi?id=125772
51
52         Reviewed by Darin Adler.
53
54         * Scripts/webkitpy/style/checkers/cpp.py:
55         (check_for_extra_new_line_at_eof):
56         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
57         (CppStyleTest.test_newline_at_eof):
58         (CppStyleTest.test_extra_newlines_at_eof):
59
60 2013-12-16  Eva Balazsfalvi  <balazsfalvi.eva@stud.u-szeged.hu>
61
62         Remove mock_drt.py: parse_options() - --test-shell and --pixel-tests=<path>
63         https://bugs.webkit.org/show_bug.cgi?id=125780
64
65         Reviewed by Darin Adler.
66
67         * Scripts/webkitpy/port/mock_drt.py:
68         (main):
69         (parse_options):
70         (MockDRT.write_test_output):
71         * Scripts/webkitpy/port/mock_drt_unittest.py:
72         (MockDRTTest.assertTest):
73         (MockDRTTest.test_reftest_mismatch):
74
75 2013-12-16  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
76
77         prepare-Changelog treats CSS keyframes as mismatched parentheses.
78         https://bugs.webkit.org/show_bug.cgi?id=125435
79
80         Reviewed by Darin Adler.
81
82         * Scripts/prepare-ChangeLog:
83         (get_selector_line_ranges_for_css):
84
85 2013-12-16  Mario Sanchez Prada  <mario.prada@samsung.com>
86
87         [ATK] Expose accessibility objects for more WAI-ARIA roles
88         https://bugs.webkit.org/show_bug.cgi?id=125596
89
90         Reviewed by Chris Fleizach.
91
92         Add mappings to DRT & WKTR for the newly exposed roles.
93
94         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
95         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
96
97 2013-12-16  Mario Sanchez Prada  <mario.prada@samsung.com>
98
99         [ATK] Expose accessibility objects with ATK_ROLE_CHECK_MENU_ITEM
100         https://bugs.webkit.org/show_bug.cgi?id=125594
101
102         Reviewed by Chris Fleizach.
103
104         Add mappings to DRT & WKTR for checkmenuitem role.
105
106         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
107         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
108
109 2013-12-16  Mario Sanchez Prada  <mario.prada@samsung.com>
110
111         [ATK] Expose accessibility objects with ATK_ROLE_ARTICLE
112         https://bugs.webkit.org/show_bug.cgi?id=125587
113
114         Reviewed by Chris Fleizach.
115
116         Add mappings to DRT & WKTR for article roles.
117
118         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
119         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
120
121 2013-12-16  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
122
123         [FTL] Allow EFL to build FTL with the build-jsc script.
124         https://bugs.webkit.org/show_bug.cgi?id=125774
125
126         Reviewed by Zoltan Herczeg.
127
128         * Scripts/build-jsc:
129
130 2013-12-16  Krzysztof Czech  <k.czech@samsung.com>
131
132         Add myself as a committer
133
134         Unreviewed.
135
136         * Scripts/webkitpy/common/config/contributors.json:
137
138 2013-12-15  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
139
140         Refactor option handling in WebKitTestRunner.
141         https://bugs.webkit.org/show_bug.cgi?id=123185
142
143         Reviewed by Darin Adler.
144
145         Option handling is refactored (according to the FIXME) that allows
146         to automatically generate the help message.
147
148         * WebKitTestRunner/CMakeLists.txt:
149         * WebKitTestRunner/GNUmakefile.am:
150         * WebKitTestRunner/Options.cpp: Added.
151         (WTR::Options::Options):
152         (WTR::handleOptionTimeout):
153         (WTR::handleOptionNoTimeout):
154         (WTR::handleOptionNoTimeoutAtAll):
155         (WTR::handleOptionVerbose):
156         (WTR::handleOptionGcBetweenTests):
157         (WTR::handleOptionPixelTests):
158         (WTR::handleOptionPrintSupportedFeatures):
159         (WTR::handleOptionComplexText):
160         (WTR::handleOptionAcceleratedDrawing):
161         (WTR::handleOptionRemoteLayerTree):
162         (WTR::handleOptionUnmatched):
163         (WTR::OptionsHandler::OptionsHandler):
164         (WTR::Option::Option):
165         (WTR::Option::matches):
166         (WTR::OptionsHandler::parse):
167         (WTR::OptionsHandler::printHelp):
168         * WebKitTestRunner/Options.h: Added.
169         * WebKitTestRunner/TestController.cpp:
170         (WTR::TestController::initialize):
171         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
172
173 2013-12-15  Dan Bernstein  <mitz@apple.com>
174
175         32-bit build fix.
176
177         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
178         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.mm:
179
180 2013-12-14  Tim Horton  <timothy_horton@apple.com>
181
182         stylebot should warn when FeatureDefines differ
183         https://bugs.webkit.org/show_bug.cgi?id=125748
184
185         Reviewed by Dan Bernstein.
186
187         Add a stylebot checker that ensures that FeatureDefines.xcconfig files
188         are always exactly equal (and warns people adding new FeatureDefines.xcconfig files,
189         an unlikely occurrance, to add them to the list).
190
191         It's a bit nontraditional for stylebot because it will warn on existing errors in the tree,
192         but that is the most straightforward way to implement it (and we're at zero diffs right now).
193
194         * Scripts/webkitpy/style/checker.py:
195         (_all_categories):
196         (FileType):
197         (CheckerDispatcher._file_type):
198         (CheckerDispatcher._create_checker):
199         * Scripts/webkitpy/style/checkers/featuredefines.py: Added.
200         (FeatureDefinesChecker):
201         (FeatureDefinesChecker.__init__):
202         (FeatureDefinesChecker.check):
203
204 2013-12-13  Sam Weinig  <sam@webkit.org>
205
206         Fix API tests.
207
208         * TestWebKitAPI/Tests/WebKit2/WillLoad.cpp:
209         (TestWebKitAPI::TEST_F):
210
211 2013-12-13  Brent Fulgham  <bfulgham@apple.com>
212
213         [Win] Remove Pre-VS2013 support code.
214         https://bugs.webkit.org/show_bug.cgi?id=125693
215
216         Reviewed by Darin Adler.
217
218         * DumpRenderTree/cg/ImageDiffCG.cpp: Remove strtof stub now supplied by
219         the math library.
220         * DumpRenderTree/win/ImageDiffCairo.cpp: Ditto.
221
222 2013-12-13  Lucas Forschler  <lforschler@apple.com>
223
224         Update Webkit bots.
225         
226         Unreviewed.
227         
228         * BuildSlaveSupport/build.webkit.org-config/config.json:
229
230 2013-12-13  Brent Fulgham  <bfulgham@apple.com>
231
232         [Win] Unreviewed build fix after r160548
233
234         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj: Specify
235         we are using vs12_xp target for Makefile-based projects.
236
237 2013-12-13  Lucas Forschler  <lforschler@apple.com>
238
239         Update Apple Webkit Bots
240         
241         Unreviewed.
242
243         * BuildSlaveSupport/build.webkit.org-config/config.json:
244
245 2013-12-13  Brent Fulgham  <bfulgham@apple.com>
246
247         Unreviewed build fix after r160548.
248
249         * Scripts/webkitdirs.pm:
250         (setupCygwinEnv): VCExpress.exe is now called WDExpress.exe.
251
252 2013-12-13  Lucas Forschler  <lforschler@apple.com>
253
254         Update Apple bots.
255         
256         Unreviewed.
257
258         * BuildSlaveSupport/build.webkit.org-config/config.json:
259
260 2013-12-13  Brent Fulgham  <bfulgham@apple.com>
261
262         [Win] Switch WebKit solution to Visual Studio 2013
263         https://bugs.webkit.org/show_bug.cgi?id=125192
264
265         Reviewed by Anders Carlsson.
266
267         Project files must reference vs12_xp for 32-bit builds. 
268
269         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
270         Update for VS2013
271         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
272         Ditto
273         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
274         Ditto
275         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
276         Ditto
277         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
278         Ditto
279         * Scripts/webkitdirs.pm:
280         (visualStudioInstallDir): Specify VS2013
281         (visualStudioVersion): Ditto.
282         (setupAppleWinEnv): Use VS2013 in messages
283         (setupCygwinEnv): Ditto
284         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
285         Update for VS2013
286         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
287         Ditto
288         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
289         Ditto
290         * win/record-memory/record-memory.vcxproj:
291         Ditto
292
293 2013-12-11  Martin Robinson  <mrobinson@igalia.com> and Danilo Cesar Lemes de Paula  <danilo.cesar@collabora.co.uk>
294
295         Adding a .ycm_extra_conf file for webkitGtk
296         https://bugs.webkit.org/show_bug.cgi?id=119618
297
298         Reviewed by Gustavo Noronha Silva.
299
300         Added a YouCompleteMe flag discovery script for Vim and the GTK+ port. The script
301         read the GTK+ build files to determine dynamically what flags to compile a source
302         file with. This allows Vim to provide auto-complete for C++/C language. See
303         https://github.com/Valloric/YouCompleteMe for how to use this file.
304
305         * gtk/common.py:
306         (get_build_path): Added a fatal argument to build_path to avoid crashing YCM on failure.
307         * gtk/ycm_extra_conf.py: Added.
308
309 2013-12-12  Tim Horton  <timothy_horton@apple.com>
310
311         [wk2] Handle pinch-to-zoom gesture
312         https://bugs.webkit.org/show_bug.cgi?id=125604
313
314         Reviewed by Simon Fraser.
315
316         * MiniBrowser/mac/WK2BrowserWindowController.m:
317         (-[WK2BrowserWindowController awakeFromNib]):
318         Enable handling of the magnification gesture in Minibrowser WebKit2 windows.
319
320 2013-12-12  Eunmi Lee  <eunmi15.lee@samsung.com>
321
322         Unreviewed. Add myself as a committer.
323
324         * Scripts/webkitpy/common/config/contributors.json:
325
326 2013-12-12  Lucas Forschler  <lforschler@apple.com>
327
328         Update hardware for Apple bots.
329         
330         Unreviewed.
331
332         * BuildSlaveSupport/build.webkit.org-config/config.json:
333
334 2013-12-12  Lucas Forschler  <lforschler@apple.com>
335
336         Remove unused Apple Bots.
337         
338         Unreviewed.
339
340         * BuildSlaveSupport/build.webkit.org-config/config.json:
341
342 2013-12-12  Thiago de Barros Lacerda  <thiago.lacerda@openbossa.org>
343
344         Unreviewed. Add myself as a committer.
345
346         * Scripts/webkitpy/common/config/contributors.json:
347
348 2013-12-12  Joseph Pecoraro  <pecoraro@apple.com>
349
350         Test new JSContext name APIs
351         https://bugs.webkit.org/show_bug.cgi?id=125607
352
353         Reviewed by Darin Adler.
354
355         * Scripts/run-javascriptcore-tests:
356         Remove trailing whitespace.
357
358 2013-12-12  Zan Dobersek  <zdobersek@igalia.com>
359
360         [Autotools] Prepend the WebCore layer archives' names with 'lib'
361         https://bugs.webkit.org/show_bug.cgi?id=125627
362
363         Reviewed by Martin Robinson.
364
365         * TestWebKitAPI/GNUmakefile.am: Libtool can complain about the WebCore layer archives not being prepended
366         with 'lib' when they are used during linking, so the prefix is now added to avoid such issues.
367
368 2013-12-12  Commit Queue  <commit-queue@webkit.org>
369
370         Unreviewed, rolling out r160446.
371         http://trac.webkit.org/changeset/160446
372         https://bugs.webkit.org/show_bug.cgi?id=125630
373
374         The upower-glib-based implementation is using API that was
375         recently removed (Requested by zdobersek1 on #webkit).
376
377         * Scripts/webkitperl/FeatureList.pm:
378
379 2013-12-12  Commit Queue  <commit-queue@webkit.org>
380
381         Unreviewed, rolling out r160417.
382         http://trac.webkit.org/changeset/160417
383         https://bugs.webkit.org/show_bug.cgi?id=125629
384
385         The patch is causing crashes (Requested by zdobersek1 on
386         #webkit).
387
388         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
389         (axObjectEventListener):
390         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
391
392 2013-12-12  Zan Dobersek  <zdobersek@igalia.com>
393
394         Use of ar T option not supported by older binutils
395         https://bugs.webkit.org/show_bug.cgi?id=118732
396
397         Reviewed by Gustavo Noronha Silva.
398
399         * TestWebKitAPI/GNUmakefile.am: To support non-thin archives when generating the WebCoreLayer archive,
400         switch to using the AR_FLAGS variable (which can be overridden) for providing the ar flags for the
401         new archive. Non-thin archives also pose the problem as their members are only noted by the basename
402         of the member's object file, and not the full path to it. To work around that, all the object files
403         under the build directory are listed by their relative paths. The members of various archives then have
404         the basenames of their paths grepped against that list, with the found path correlating to the member
405         finally added as the new member of the WebCoreLayer archive.
406
407 2013-12-11  Myles C. Maxfield  <mmaxfield@apple.com>
408
409         check-webkit-style shouldn't check spacing in #if preprocessor lines
410         https://bugs.webkit.org/show_bug.cgi?id=125534
411
412         Reviewed by Ryosuke Niwa.
413
414         Preprocessor lines that start with #if shouldn't have to adhere to
415         the same spacing requirements that regular code does
416
417         * Scripts/webkitpy/style/checkers/cpp.py:
418         (check_spacing):
419         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
420         (CppStyleTest.test_spacing_for_binary_ops):
421         (WebKitStyleTest.test_line_breaking):
422
423 2013-12-11  Myles C. Maxfield  <mmaxfield@apple.com>
424
425         check-webkit-style can't determine if a comma is part of an initialization list
426         https://bugs.webkit.org/show_bug.cgi?id=125537
427
428         Reviewed by Darin Adler.
429
430         The original check to make sure that initialization list lines start with
431         a comma didn't distinguish between commas that belong to the initialization
432         list and commas that are part of function calls. Because we don't want to
433         match parentheses with regular expressions, we should weaken this check to
434         only check for commas at the end of initialization list lines.
435
436         * Scripts/webkitpy/style/checkers/cpp.py:
437         (check_member_initialization_list):
438         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
439         (WebKitStyleTest.test_member_initialization_list):
440
441 2013-12-11  Tim Horton  <timothy_horton@apple.com>
442
443         Make it possible to compare layout test results between various configurations of WebKit
444         https://bugs.webkit.org/show_bug.cgi?id=125212
445         <rdar://problem/15199108>
446
447         Reviewed by Darin Adler.
448
449         * Scripts/compare-webkit-configurations: Added.
450         Add a script that allows comparison between the "normal" WebKit configuration
451         used for testing and a different configuration (e.g. with accelerated drawing
452         turned on, with the remote layer tree enabled, or WebKit1 vs WebKit2), like so:
453
454         compare-webkit-configurations -2 --comparison=accelerated-drawing compositing/background-color
455
456         This script runs the tests once in the default configuration, ignoring
457         all test expectations, writing the results out to a temporary directory.
458
459         It then runs the tests again in the modified configuration, against the
460         just-written temporary results.
461
462         Ref tests are treated as pixel tests, with their pixel output dumped to disk.
463
464         * DumpRenderTree/mac/DumpRenderTree.mm:
465         (resetWebPreferencesToConsistentValues):
466         (initializeGlobalsFromCommandLineOptions):
467         Enable accelerated drawing if requested.
468
469         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
470         (parse_args):
471         Add --accelerated-drawing and --remote-layer-tree feature switches, which
472         are forwarded on to the test drivers.
473         Move those two and --complex-text into their own "feature switches" section.
474         Drive-by change "Mac OS X" to "OS X".
475         Add --treat-ref-tests-as-pixel-tests option, which treats ref tests
476         as traditional pixel tests (with PNGs dumped on disk), and
477         ignores e.g. -expected.html files.
478
479         * Scripts/webkitpy/port/base.py:
480         (Port.reference_files):
481         Pretend that there are no ref tests.
482         Since is_reference_html_file is intact, our mechanism to ignore
483         the expected files will continue working in this case.
484
485         * Scripts/webkitpy/port/driver.py:
486         (Driver.cmd_line):
487         Forward --accelerated-drawing and --remote-layer-tree to DRT/WKTR.
488
489         * WebKitTestRunner/TestController.cpp:
490         (WTR::TestController::TestController):
491         (WTR::TestController::initialize):
492         (WTR::TestController::resetPreferencesToConsistentValues):
493         * WebKitTestRunner/TestController.h:
494         (WTR::TestController::shouldUseRemoteLayerTree):
495         * WebKitTestRunner/TestInvocation.cpp:
496         (WTR::updateThreadedScrollingForCurrentTest):
497         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
498         (WTR::PlatformWebView::PlatformWebView):
499         Parse and implement the three feature switches.
500
501 2013-12-11  Mario Sanchez Prada  <mario.prada@samsung.com>
502
503         [ATK] Expose accessibility objects WAI-ARIA landmark roles
504         https://bugs.webkit.org/show_bug.cgi?id=125584
505
506         Reviewed by Chris Fleizach.
507
508         Add mappings to DRT & WKTR for landmark roles.
509
510         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
511         (AccessibilityUIElement::role):
512         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
513         (WTR::AccessibilityUIElement::role):
514         * gtk/jhbuild.modules:
515
516 2013-12-11  Alejandro G. Castro  <alex@igalia.com>
517
518         [GTK] Avoid double quotations when passing parameters to valgrind in gtk.py
519         https://bugs.webkit.org/show_bug.cgi?id=125441
520
521         Reviewed by Martin Robinson.
522
523         Just avoid the double quotations when building the parameter
524         because some versions of valgrind are not handling it correctly.
525
526         * Scripts/webkitpy/port/gtk.py:
527         (GtkPort.setup_environ_for_server):
528
529 2013-12-11  Zan Dobersek  <zdobersek@igalia.com>
530
531         [GTK] Enable Battery Status API
532         https://bugs.webkit.org/show_bug.cgi?id=125453
533
534         Reviewed by Martin Robinson.
535
536         * Scripts/webkitperl/FeatureList.pm: Enable the Battery Status API feature for the GTK port.
537
538 2013-12-11  José Dapena Paz  <jdapena@igalia.com> and Zan Dobersek  <zdobersek@igalia.com>
539
540         [GTK][WK2] Add the WebKitBatteryProvider class
541         https://bugs.webkit.org/show_bug.cgi?id=115720
542
543         Reviewed by Martin Robinson.
544
545         * gtk/generate-gtkdoc:
546         (get_webkit2_options): Ignore the WebKitBatteryProvider source files when generating the documentation.
547
548 2013-12-11  Mark Rowe  <mrowe@apple.com>
549
550         <https://webkit.org/b/125563> Remove the DumpRenderTree Perl Support module
551
552         Now that old-run-webkit-tests is not used on OS X it's not worth the time and effort
553         to build and maintain this custom Perl module.
554
555         Reviewed by Anders Carlsson.
556
557         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Remove the target.
558         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport.c: Removed.
559         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupportPregenerated.pm: Removed.
560         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport_wrapPregenerated.c: Removed.
561         * DumpRenderTree/mac/PerlSupport/Makefile: Removed.
562         * Scripts/old-run-webkit-tests: Update a comment that referred to DumpRenderTreeSupport as a reason to
563         build DumpRenderTree.
564         (dumpToolDidCrash): Stop importing and using the module.
565         * Scripts/webkitpy/port/base.py:
566         (Port._build_driver): Update a comment in the same manner as in old-run-webkit-tests.
567
568 2013-12-11  Brendan Long  <b.long@cablelabs.com>
569
570         [GTK] Add "enable-mediasource" property to WebKitWebSettings
571         https://bugs.webkit.org/show_bug.cgi?id=125566
572
573         Reviewed by Philippe Normand.
574
575         * DumpRenderTree/gtk/DumpRenderTree.cpp:
576         (resetDefaultsToConsistentValues): Turn MediaSource on by default for easier testing.
577         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
578         (TestRunner::overridePreference): Allow overriding WebKitMediaSourceEnabled.
579
580 2013-12-11  Dan Bernstein  <mitz@apple.com>
581
582         [Mac] Observe the activeURL property to keep the MiniBrowser URL field up to date
583         https://bugs.webkit.org/show_bug.cgi?id=125579
584
585         Reviewed by Anders Carlsson.
586
587         * MiniBrowser/mac/WK2BrowserWindowController.m:
588         (-[WK2BrowserWindowController dealloc]): Stop observing the activeURL property.
589         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]): When the
590         activeURL property changes, update the URL field with its value.
591         (-[WK2BrowserWindowController awakeFromNib]): Start observing the activeURL property.
592         (-[WK2BrowserWindowController browsingContextControllerDidStartProvisionalLoad:]): Just log.
593         (-[WK2BrowserWindowController browsingContextControllerDidReceiveServerRedirectForProvisionalLoad:]):
594         Ditto.
595         (-[WK2BrowserWindowController browsingContextController:didFailProvisionalLoadWithError:]):
596         Ditto.
597         (-[WK2BrowserWindowController browsingContextControllerDidCommitLoad:]): Ditto.
598         (-[WK2BrowserWindowController browsingContextController:didFailLoadWithError:]): Ditto.
599
600 2013-12-11  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
601
602         Fixed test-wepkitpy logging for buildslaves
603         https://bugs.webkit.org/show_bug.cgi?id=125445
604
605         Reviewed by Csaba Osztrogonác.
606
607         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
608         (RunPythonTests):
609
610 2013-12-11  Mario Sanchez Prada  <mario.prada@samsung.com>
611
612         Programmatically-inserted children lack accessibility events
613         https://bugs.webkit.org/show_bug.cgi?id=100275
614
615         Reviewed by Chris Fleizach.
616
617         Update DRT and WebKitTestRunner to handle the children-changed
618         signal properly, considering the detail and optional parameters.
619
620         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp: Updated.
621         (axObjectEventListener):
622         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp: Updated.
623
624 2013-12-03  Mark Rowe  <mrowe@apple.com>
625
626         <https://webkit.org/b/125139> Modernize the WebKit API headers
627         <rdar://problem/15540175>
628
629         Reviewed by Anders Carlsson.
630
631         * DumpRenderTree/mac/TestRunnerMac.mm:
632         (TestRunner::setCacheModel): Cast to the enum type.
633
634 2013-12-10  Filip Pizlo  <fpizlo@apple.com>
635
636         Get rid of forward exit on DoubleAsInt32
637         https://bugs.webkit.org/show_bug.cgi?id=125552
638
639         Reviewed by Oliver Hunt.
640         
641         Add some support for testing the generic (non-X86) paths on X86 by disabling
642         architecture-specific optimizations (ASO's).
643
644         * Scripts/run-javascriptcore-tests:
645         * Scripts/run-jsc-stress-tests:
646
647 2013-12-10  Ryuan Choi  <ryuan.choi@samsung.com>
648
649         Unreviewed EFL build fix attempt
650
651         * TestWebKitAPI/CMakeLists.txt: Added ${WEBKIT2_DIR}/Platform/CoreIPC to include lists.
652         * WebKitTestRunner/CMakeLists.txt: Ditto.
653
654 2013-12-10  Anders Carlsson  <andersca@apple.com>
655
656         Add a HashMap constructor that takes an initializer list
657         https://bugs.webkit.org/show_bug.cgi?id=125551
658
659         Reviewed by Dan Bernstein.
660
661         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
662         (TestWebKitAPI::TEST):
663
664 2013-12-10  Laszlo Vidacs  <lac@inf.u-szeged.hu>
665
666         Use std::array when computing MD5 checksum
667         https://bugs.webkit.org/show_bug.cgi?id=125509
668
669         Reviewed by Anders Carlsson.
670
671         Use MD5::Digest type and MD5::hashSize when computing MD5 checksum.
672
673         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
674         (computeMD5HashStringForBitmapContext):
675         * DumpRenderTree/cairo/PixelDumpSupportCairo.cpp:
676         (computeMD5HashStringForBitmapContext):
677         * TestWebKitAPI/Tests/WTF/MD5.cpp:
678         (TestWebKitAPI::expectMD5):
679         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
680         (WTR::computeMD5HashStringForCairoSurface):
681         * WebKitTestRunner/cg/TestInvocationCG.cpp:
682         (WTR::computeMD5HashStringForContext):
683
684 2013-12-10  Mario Sanchez Prada  <mario.prada@samsung.com>
685
686         [ATK] Expose splitter elements with ATK_ROLE_SEPARATOR
687         https://bugs.webkit.org/show_bug.cgi?id=125522
688
689         Reviewed by Chris Fleizach.
690
691         Update strings representing ATK_ROLE_SEPARATOR for layout tests.
692
693         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
694         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
695
696 2013-12-10  Laszlo Vidacs  <lac@inf.u-szeged.hu>
697
698         Add --makeargs option to build-jsc
699         https://bugs.webkit.org/show_bug.cgi?id=125344
700
701         Reviewed by Filip Pizlo.
702
703         * Scripts/build-jsc: Handle and pass makefile arguments in jsc build.
704
705 2013-12-10  Joanmarie Diggs  <jdiggs@igalia.com>
706
707         AX: [ATK] Convert the get_text atktest.c unit tests to layout tests
708         https://bugs.webkit.org/show_bug.cgi?id=125497
709
710         Reviewed by Mario Sanchez Prada.
711
712         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
713         (AccessibilityUIElement::stringForRange): Implemented.
714         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
715         (WTR::AccessibilityUIElement::stringForRange): Implemented.
716
717 2013-12-10  Martin Robinson  <mrobinson@igalia.com>
718
719         Various fixes for the CMake GTK+ build
720
721         Reviewed by Gustavo Noronha.
722
723         * MiniBrowser/gtk/CMakeLists.txt: Update source list and correct the name of BrowserMarshal.h.
724         * TestWebKitAPI/PlatformGTK.cmake: Add GTK+ libraries to the test program. They're required.
725
726 2013-12-10  László Langó  <lango@inf.u-szeged.hu>
727
728         --cloop option does not work in Tools/Scripts/build-jsc.
729         https://bugs.webkit.org/show_bug.cgi?id=125214
730
731         Reviewed by Csaba Osztrogonác.
732
733         * Scripts/build-jsc:
734
735 2013-12-10  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
736
737         Merge mark_for_landing and mark_for_commit_queue into one argument
738         https://bugs.webkit.org/show_bug.cgi?id=125448
739
740         Reviewed by Ryosuke Niwa.
741
742         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
743         (CommitQueueFlag):
744         (Bugzilla._commit_queue_flag):
745         (Bugzilla._fill_attachment_form):
746         (Bugzilla.add_patch_to_bug):
747         (Bugzilla.create_bug):
748         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
749         (test_commit_queue_flag.assert_commit_queue_flag):
750         (test_commit_queue_flag):
751
752 2013-12-09  Tim Horton  <timothy_horton@apple.com>
753
754         Remove dead extract_reference_link.py (and the reftests module)
755         https://bugs.webkit.org/show_bug.cgi?id=125116
756
757         Reviewed by Ryosuke Niwa.
758
759         This code doesn't seem to have ever been used.
760
761         * Scripts/webkitpy/layout_tests/reftests/__init__.py: Removed.
762         * Scripts/webkitpy/layout_tests/reftests/extract_reference_link.py: Removed.
763         * Scripts/webkitpy/layout_tests/reftests/extract_reference_link_unittest.py: Removed.
764
765 2013-12-09  Mario Sanchez Prada  <mario.prada@samsung.com>
766
767         [ATK] Translate ATK_ROLE_SECTION into "AXSection" in DRT/WKTR
768         https://bugs.webkit.org/show_bug.cgi?id=125456
769
770         Reviewed by Chris Fleizach.
771
772         Return 'AXSection' for section roles instead of 'AXDiv'.
773
774         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
775         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
776
777 2013-12-09  Brian J. Burg  <burg@cs.washington.edu>
778
779         check-webkit-style should check for extra newlines at EOF
780         https://bugs.webkit.org/show_bug.cgi?id=125424
781
782         Reviewed by Darin Adler.
783
784         Report a style violation if extraneous newlines are added
785         to the end of a C++ file. There should only be one newline at EOF.
786
787         * Scripts/webkitpy/style/checkers/cpp.py:
788         (check_for_missing_new_line_at_eof): Renamed from check_for_new_line_at_eof.
789         (check_for_extra_new_line_at_eof): Added.
790         (_process_lines): Added new check and renamed existing EOF check.
791         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
792         (CppStyleTest.test_extra_newlines_at_eof): Added.
793         (CppStyleTest.test_extra_newlines_at_eof.do_test): Added.
794
795 2013-12-09  Laszlo Vidacs  <lac@inf.u-szeged.hu>
796
797         check-webkit-style: ternary operator in macro call identified as initialization list
798         https://bugs.webkit.org/show_bug.cgi?id=125443
799
800         Reviewed by Ryosuke Niwa.
801
802         Do not match initialization list when questionmark is placed before :
803
804         * Scripts/webkitpy/style/checkers/cpp.py:
805         (check_member_initialization_list):
806
807 2013-12-09  Joanmarie Diggs  <jdiggs@igalia.com>
808
809         AX: [ATK] Convert the get_{string,text}_at_offset atktest.c unit tests to layout tests
810         https://bugs.webkit.org/show_bug.cgi?id=125451
811
812         Reviewed by Mario Sanchez Prada.
813
814         Create the needed callbacks for DRT and WKTR.
815
816         * DumpRenderTree/AccessibilityUIElement.cpp:
817         (characterAtOffsetCallback): added
818         (wordAtOffsetCallback): added
819         (lineAtOffsetCallback): added
820         (sentenceAtOffsetCallback): added
821         (AccessibilityUIElement::getJSClass):
822         * DumpRenderTree/AccessibilityUIElement.h:
823         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
824         (stringAtOffset): added
825         (AccessibilityUIElement::characterAtOffset): added
826         (AccessibilityUIElement::wordAtOffset): added
827         (AccessibilityUIElement::lineAtOffset): added
828         (AccessibilityUIElement::sentenceAtOffset): added
829         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
830         (WTR::AccessibilityUIElement::characterAtOffset): added
831         (WTR::AccessibilityUIElement::wordAtOffset): added
832         (WTR::AccessibilityUIElement::lineAtOffset): added
833         (WTR::AccessibilityUIElement::sentenceAtOffset): added
834         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
835         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
836         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
837         (WTR::stringAtOffset): added
838         (WTR::AccessibilityUIElement::characterAtOffset): added
839         (WTR::AccessibilityUIElement::wordAtOffset): added
840         (WTR::AccessibilityUIElement::lineAtOffset): added
841         (WTR::AccessibilityUIElement::sentenceAtOffset): added
842
843 2013-12-08  Sam Weinig  <sam@webkit.org>
844
845         32-bit MiniBrowser doesn't build
846         https://bugs.webkit.org/show_bug.cgi?id=125420
847
848         Reviewed by Dan Bernstein.
849
850         * MiniBrowser/mac/AppDelegate.h:
851         * MiniBrowser/mac/AppDelegate.m:
852         (-[BrowserAppDelegate init]):
853         (-[BrowserAppDelegate applicationWillTerminate:]):
854
855 2013-12-08  Brian Holt  <brian.holt@samsung.com>
856
857         [WK2] Add ENABLE_NETWORK_PROCESS flag
858         https://bugs.webkit.org/show_bug.cgi?id=125421
859
860         Add support to build with the Network Process enabled.
861
862         Reviewed by Martin Robinson.
863
864         * Scripts/webkitperl/FeatureList.pm:
865
866 2013-12-07  Filip Pizlo  <fpizlo@apple.com>
867
868         Fold typedArray.length if typedArray is constant
869         https://bugs.webkit.org/show_bug.cgi?id=125252
870
871         Reviewed by Sam Weinig.
872         
873         Add Source/JavaScriptCore/tests/stress to the set of JS tests. This is where you
874         should put tests that run just like JSRegress but don't run as part of LayoutTests.
875         Currently I'm using it for tests that require some surgical support from jsc.cpp.
876
877         * Scripts/run-javascriptcore-tests:
878
879 2013-12-08  Zan Dobersek  <zdobersek@igalia.com>
880
881         [gdb] Update printers for WTF::CString, JSC::JSString
882         https://bugs.webkit.org/show_bug.cgi?id=124600
883
884         Reviewed by Gustavo Noronha Silva.
885
886         Update the two printers after they fell behind the changes in implementation.
887
888         * gdb/webkit.py:
889         (WTFCStringPrinter.to_string):
890         (JSCJSStringPrinter.to_string):
891
892 2013-12-08  Zan Dobersek  <zdobersek@igalia.com>
893
894         [webkitpy] Add a WestonDriver unit test
895         https://bugs.webkit.org/show_bug.cgi?id=125408
896
897         Reviewed by Gustavo Noronha Silva.
898
899         Add a webkitpy unit test for the Weston driver.
900
901         * Scripts/webkitpy/port/westondriver_unittest.py: Added.
902         (WestonDriverTest):
903         (WestonDriverTest.make_driver): Sets up a new WestonDriver instance for testing purposes.
904         (WestonDriverTest.test_start): Check that the Weston compositor is launched properly and that
905         the server environment contains proper WAYLAND and GDK_BACKEND entries.
906         (WestonDriverTest.test_stop): Check that the Weston compositor is terminated properly and that
907         the driver cleans up the temporary directory.
908         (WestonDriverTest.test_stop.FakeWestonProcess): A helper class that logs the expected termination.
909         (WestonDriverTest.test_stop.FakeWestonProcess.terminate):
910
911 2013-12-08  Brendan Long  <b.long@cablelabs.com>
912
913         [Gtk] install-dependencies doesn't install libgtk-3-dev
914         https://bugs.webkit.org/show_bug.cgi?id=125320
915
916         Reviewed by Gustavo Noronha Silva.
917
918         * gtk/install-dependencies: Add libgtk-3-dev, libsoup2.4 and subversion
919
920 2013-12-07  Sam Weinig  <sam@webkit.org>
921
922         [Cocoa] Convert a few more parts of MiniBrowser over to the Objective-C API
923         https://bugs.webkit.org/show_bug.cgi?id=125401
924
925         Reviewed by Dan Bernstein.
926
927         * MiniBrowser/mac/WK2BrowserWindowController.m:
928         (-[WK2BrowserWindowController fetch:]):
929         (-[WK2BrowserWindowController reload:]):
930         (-[WK2BrowserWindowController goBack:]):
931         (-[WK2BrowserWindowController goForward:]):
932         (-[WK2BrowserWindowController validateUserInterfaceItem:]):
933         (-[WK2BrowserWindowController currentZoomFactor]):
934         (-[WK2BrowserWindowController setCurrentZoomFactor:]):
935         (-[WK2BrowserWindowController zoomIn:]):
936         (-[WK2BrowserWindowController zoomOut:]):
937         (-[WK2BrowserWindowController canResetZoom]):
938         (-[WK2BrowserWindowController resetZoom:]):
939         (-[WK2BrowserWindowController toggleZoomMode:]):
940         (-[WK2BrowserWindowController updateTextFieldFromURL:]):
941
942 2013-12-07  Sam Weinig  <sam@webkit.org>
943
944         Convert MiniBrowser to use WKProcessGroup and WKBrowsingContextGroup
945         https://bugs.webkit.org/show_bug.cgi?id=125400
946
947         Reviewed by Dan Bernstein.
948
949         * MiniBrowser/mac/AppDelegate.h:
950         * MiniBrowser/mac/AppDelegate.m:
951         * MiniBrowser/mac/WK2BrowserWindowController.h:
952         * MiniBrowser/mac/WK2BrowserWindowController.m:
953         (-[WK2BrowserWindowController initWithProcessGroup:browsingContextGroup:]):
954         (-[WK2BrowserWindowController dealloc]):
955         (createNewPage):
956         (-[WK2BrowserWindowController awakeFromNib]):
957         (-[WK2BrowserWindowController browsingContextController:didNavigateWithNavigationData:]):
958         (-[WK2BrowserWindowController browsingContextController:didPerformClientRedirectFromURL:toURL:]):
959         (-[WK2BrowserWindowController browsingContextController:didPerformServerRedirectFromURL:toURL:]):
960         (-[WK2BrowserWindowController browsingContextController:didUpdateHistoryTitle:forURL:]):
961         Replace global WKContextRef and WKPageGroupRef with WKProcessGroup and WKBrowsingContextGroup. Also
962         replace context based WKContextHistoryClient with WKBrowsingContextController based WKBrowsingContextHistoryDelegate
963
964 2013-12-07  Gustavo Noronha Silva  <gns@gnome.org>
965
966         [GTK] Run each gtest subtest separately instead of in one go
967         https://bugs.webkit.org/show_bug.cgi?id=125386
968
969         Reviewed by Martin Robinson.
970
971         This is what other ports are doing (except they build each test as a separate binary)
972         and will help with the timeouts we sometimes hit because it applies to the full test
973         run.
974
975         * Scripts/run-gtk-tests:
976         (TestRunner._get_tests_from_google_test_suite): get a list of available sub-tests.
977         (TestRunner._run_google_test): run a single subtest from a gtest binary.
978         (TestRunner._run_google_test_suite): call the binary once per subtest.
979
980 2013-12-07  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
981
982         Move PrettyPatch related code to prettypatch.py
983         https://bugs.webkit.org/show_bug.cgi?id=124937
984
985         Reviewed by Ryosuke Niwa.
986
987         This code seems to have a better place here than in Port, since PrettyPatch already knows
988         pretty_patch_path, and this also unifies the usage of PrettyPatch
989
990         * Scripts/webkitpy/common/prettypatch.py:
991         (PrettyPatch.__init__):
992         (PrettyPatch.pretty_diff):
993         (PrettyPatch):
994         (PrettyPatch.pretty_patch_available):
995         (PrettyPatch.check_pretty_patch):
996         (PrettyPatch.pretty_patch_text):
997         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
998         (TestResultWriter.create_text_diff_and_write_result):
999         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1000         (summarize_results):
1001         * Scripts/webkitpy/port/base.py:
1002         (Port.__init__):
1003         (Port.wdiff_available):
1004         (Port.check_image_diff):
1005         (Port.wdiff_text):
1006         * Scripts/webkitpy/port/base_unittest.py:
1007         (PortTest.test_pretty_patch_os_error):
1008         (PortTest.test_pretty_patch_script_error):
1009
1010 2013-12-06  Dan Bernstein  <mitz@apple.com>
1011
1012         [Mac] MiniBrowser Debug builds are compiled with -Os
1013         https://bugs.webkit.org/show_bug.cgi?id=125376
1014
1015         Reviewed by Tim Horton.
1016
1017         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Set GCC_OPTIMIZATION_LEVEL to 0 for
1018         the Debug configuration at the project level.
1019
1020 2013-12-06  Jer Noble  <jer.noble@apple.com>
1021
1022         [MSE] Add a runtime-setting for the MediaSource constructor.
1023         https://bugs.webkit.org/show_bug.cgi?id=125336
1024
1025         Reviewed by Eric Carlson.
1026
1027         Enable MediaSource in DRT and WKTR.
1028
1029         * DumpRenderTree/mac/DumpRenderTree.mm:
1030         (resetWebPreferencesToConsistentValues):
1031         * WebKitTestRunner/TestController.cpp:
1032         (WTR::TestController::resetPreferencesToConsistentValues):
1033
1034 2013-12-06  Jer Noble  <jer.noble@apple.com>
1035
1036         Strip out extraneous logging from AppleGVA in media tests.
1037         https://bugs.webkit.org/show_bug.cgi?id=125357
1038
1039         Reviewed by Simon Fraser.
1040
1041         Add a mechanism for stripping out abritrary regular expressions from test input and output.
1042
1043         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1044         (SingleTestRunner._run_compare_test): Strip out logging
1045         * Scripts/webkitpy/port/base.py:
1046         (Port.logging_patterns_to_strip): Return an empty list by default.
1047         * Scripts/webkitpy/port/driver.py:
1048         (DriverOutput.strip_patterns): Apply the port specific patterns to the text.
1049         * Scripts/webkitpy/port/mac.py:
1050         (MacPort.logging_patterns_to_strip): Return a complete list.
1051
1052 2013-12-06  Dean Jackson  <dino@apple.com>
1053
1054         Updating ANGLE should point to instructions
1055         https://bugs.webkit.org/show_bug.cgi?id=125361
1056
1057         Reviewed by Eric Carlson.
1058
1059         Point to https://trac.webkit.org/wiki/UpdatingANGLE when
1060         someone wants to patch ANGLE.
1061
1062         * Scripts/webkitpy/common/config/watchlist:
1063
1064 2013-12-06  Dan Bernstein  <mitz@apple.com>
1065
1066         [Mac] Transition MiniBrowser to the Cocoa API: load delegate
1067         https://bugs.webkit.org/show_bug.cgi?id=125334
1068
1069         Reviewed by Darin Adler.
1070
1071         * MiniBrowser/mac/WK2BrowserWindowController.m:
1072         (-[WK2BrowserWindowController dealloc]): Nil out the load delegate and stop observing the
1073         title property.
1074         (-[WK2BrowserWindowController isPaginated]): Changed to use Cocoa SPI.
1075         (-[WK2BrowserWindowController togglePaginationMode:]): Ditto.
1076         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]): Update the
1077         window title with the title property changes.
1078         (-[WK2BrowserWindowController awakeFromNib]): Start observing the title property. Changed to
1079         set the load delegate instead of the load client.
1080         (-[WK2BrowserWindowController updateTextFieldFromURL:]): Changed to use Cocoa types.
1081         (-[WK2BrowserWindowController updateProvisionalURL]): Removed frame parameter.
1082         (-[WK2BrowserWindowController updateCommittedURL]): Ditto.
1083         (-[WK2BrowserWindowController browsingContextControllerDidStartProvisionalLoad:]):
1084         Implemented this load delegate method.
1085         (-[WK2BrowserWindowController browsingContextControllerDidReceiveServerRedirectForProvisionalLoad:]):
1086         Ditto.
1087         (-[WK2BrowserWindowController browsingContextController:didFailProvisionalLoadWithError:]): Ditto.
1088         (-[WK2BrowserWindowController browsingContextControllerDidCommitLoad:]): Ditto.
1089         (-[WK2BrowserWindowController browsingContextControllerDidFinishLoad:]): Ditto.
1090         (-[WK2BrowserWindowController browsingContextController:didFailLoadWithError:]): Ditto.
1091         (-[WK2BrowserWindowController browsingContextControllerDidChangeBackForwardList:addedItem:removedItems:]):
1092         Ditto.
1093         (-[WK2BrowserWindowController browsingContextController:canAuthenticateAgainstProtectionSpace:]):
1094         Ditto.
1095         (-[WK2BrowserWindowController browsingContextController:didReceiveAuthenticationChallenge:]): Ditto.
1096
1097 2013-12-06  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
1098
1099         Remove function from style/checkers/cpp.py.
1100         https://bugs.webkit.org/show_bug.cgi?id=125341
1101
1102         Reviewed by Darin Adler.
1103
1104         Corrects a FIXME: by removing a function from cpp.py.
1105
1106         * Scripts/webkitpy/style/checkers/cpp.py:
1107         (CppChecker.__init__):
1108         (CppChecker.check):
1109         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1110         (CppStyleTestBase.process_file_data):
1111
1112 2013-12-06  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
1113
1114         check-webkit-style: false positive warning for indentation of #ifdef code.
1115         https://bugs.webkit.org/show_bug.cgi?id=125254
1116
1117         Reviewed by Darin Adler.
1118
1119         * Scripts/webkitpy/style/checkers/cpp.py:
1120         (check_member_initialization_list):
1121         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1122         (WebKitStyleTest.test_member_initialization_list):
1123
1124 2013-12-06  Chris Fleizach  <cfleizach@apple.com>
1125
1126         Fix spelling error in style checker: beggining
1127         https://bugs.webkit.org/show_bug.cgi?id=125347
1128
1129         Reviewed by Anders Carlsson.
1130
1131         * Scripts/webkitpy/style/checkers/cpp.py:
1132         (check_member_initialization_list):
1133         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1134         (WebKitStyleTest.test_member_initialization_list):
1135
1136 2013-12-06  Lukasz Gajowy  <l.gajowy@samsung.com>
1137
1138         [ATK] Missing aria roles mappings
1139         https://bugs.webkit.org/show_bug.cgi?id=117729
1140
1141         Reviewed by Mario Sanchez Prada.
1142
1143         Added new mappings to AccessibilityUIElementAtk.cpp.
1144
1145         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1146         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1147
1148 2013-12-06  Csaba Osztrogonác  <ossy@webkit.org>
1149
1150         Typo fix after r160218.
1151
1152         * Scripts/webkitpy/test/main.py:
1153         (main):
1154
1155 2013-12-06  Csaba Osztrogonác  <ossy@webkit.org>
1156
1157         Unreviewed fix after r160206.
1158
1159         * Scripts/webkitpy/test/main.py:
1160         (main): sys.platform can be win32 or cygwin too on Windows.
1161
1162 2013-12-05  Csaba Osztrogonác  <ossy@webkit.org>
1163
1164         Disable WebKit2 webkitpy unittests on Windows
1165         https://bugs.webkit.org/show_bug.cgi?id=125318
1166
1167         Reviewed by Ryosuke Niwa.
1168
1169         * Scripts/webkitpy/test/main.py:
1170         (main):
1171
1172 2013-12-05  Anders Carlsson  <andersca@apple.com>
1173
1174         Tweak WeakObjCPtr
1175         https://bugs.webkit.org/show_bug.cgi?id=125311
1176
1177         Reviewed by Darin Adler.
1178
1179         Split up tests into more logical groups. Add new tests for new functionality.
1180
1181         * TestWebKitAPI/Tests/WebKit2/mac/WeakObjCPtr.mm:
1182
1183 2013-12-05  Carlos Garcia Campos  <cgarcia@igalia.com>
1184
1185         [GTK] Fix gtk-doc warnings when generating DOM bindings API docs
1186         https://bugs.webkit.org/show_bug.cgi?id=125302
1187
1188         Reviewed by Philippe Normand.
1189
1190         * gtk/generate-webkitdom-doc-files:
1191         (WebKitDOMDocGeneratorSections.write_footer): Add a new section
1192         containing a private subsection for WEBKIT_API, WEBKIT_DEPRECATED
1193         and WEBKIT_DEPRECATED_FOR macros.
1194
1195 2013-12-05  Laszlo Vidacs  <lac@inf.u-szeged.hu>
1196
1197         Fix cross compilation on x86
1198         https://bugs.webkit.org/show_bug.cgi?id=125295
1199
1200         Reviewed by Zoltan Herczeg.
1201
1202         Certain compiler flags should not be added when cross compilation is enabled.
1203
1204         * Scripts/webkitdirs.pm:
1205         (runAutogenForAutotoolsProjectIfNecessary):
1206         (generateBuildSystemFromCMakeProject):
1207
1208 2013-12-05  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
1209
1210         Remove duplicated/dead code from cpp style checker unit tests.
1211         https://bugs.webkit.org/show_bug.cgi?id=125226
1212
1213         Reviewed by Ryosuke Niwa.
1214
1215         Remove the first definition of OrderOfIncludesTest class as it is
1216         overwritten by the second. Remove a duplicated assert statement
1217         from the second class.
1218
1219         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1220         (OrderOfIncludesTest.setUp):
1221         (OrderOfIncludesTest.test_try_drop_common_suffixes):
1222           The last assert was duplicated.
1223
1224 2013-12-05  László Langó  <lango@inf.u-szeged.hu>
1225
1226         Remove Scripts/generate-qt-inspector-resource.
1227         https://bugs.webkit.org/show_bug.cgi?id=125288
1228
1229         Reviewed by Andreas Kling.
1230
1231         * Scripts/generate-qt-inspector-resource: Removed. There is no QT anymore.
1232         We don't need this file.
1233
1234 2013-12-05  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
1235
1236         Remove certain methods from TestExpectations and use TestExpectationsModel instead of them
1237         https://bugs.webkit.org/show_bug.cgi?id=125218
1238
1239         Reviewed by Ryosuke Niwa.
1240
1241         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
1242         (LayoutTestFinder.skip_tests):
1243         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1244         (LayoutTestRunner.run_tests):
1245         (LayoutTestRunner._update_summary_with_result):
1246         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1247         (Manager._test_is_slow):
1248         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1249         (JSONLayoutResultsGenerator._insert_failure_summaries):
1250         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1251         (TestExpectations.get_rebaselining_failures):
1252         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1253         (assert_exp):
1254         (MiscTests.test_multiple_results):
1255         (MiscTests.test_category_expectations):
1256         (MiscTests.test_get_modifiers):
1257         (MiscTests.test_get_expectations_string):
1258         (MiscTests.test_expectation_to_string):
1259         (MiscTests.test_get_test_set):
1260         (MiscTests.test_more_specific_override_resets_skip):
1261         (SkippedTests.check):
1262         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1263         (TestRunResults.__init__):
1264         (summarize_results):
1265         * Scripts/webkitpy/tool/commands/rebaseline.py:
1266         (RebaselineExpectations._tests_to_rebaseline):
1267
1268 2013-12-04  Ryosuke Niwa  <rniwa@webkit.org>
1269
1270         Enable HTMLTemplateElement by default
1271         https://bugs.webkit.org/show_bug.cgi?id=123851
1272
1273         Reviewed by Antti Koivisto.
1274
1275         * Scripts/webkitperl/FeatureList.pm:
1276
1277 2013-12-04  Jozsef Berta  <jberta@inf.u-szeged.hu>
1278
1279         [EFL] Bumping GStreamer version to 1.2.1
1280         https://bugs.webkit.org/show_bug.cgi?id=125155
1281
1282         Reviewed by Gyuyoung Kim.
1283
1284         * efl/jhbuild.modules: Set the GStreamer version to 1.2.1
1285
1286
1287 2013-12-04  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
1288
1289         Update jhbuild revision.
1290         https://bugs.webkit.org/show_bug.cgi?id=124966
1291         
1292         Reviewed by Gyuyoung Kim.
1293
1294         Used version of Jhbuild failed to create directories and caused
1295         update-webkitefl-libs to fail. Latest Jhbuild version has it fixed.
1296
1297         * jhbuild/jhbuild-wrapper:
1298
1299 2013-12-04  Anders Carlsson  <andersca@apple.com>
1300
1301         Add a WeakObjCPtr class
1302         https://bugs.webkit.org/show_bug.cgi?id=125267
1303
1304         Reviewed by Geoffrey Garen.
1305
1306         Add API tests for WeakObjCPtr.
1307
1308         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1309         * TestWebKitAPI/Tests/WebKit2/mac/WeakObjCPtr.mm: Added.
1310         (TEST):
1311
1312 2013-12-04  Anders Carlsson  <andersca@apple.com>
1313
1314         Make the estimatedProgress property observable using KVO
1315         https://bugs.webkit.org/show_bug.cgi?id=125259
1316
1317         Reviewed by Dan Bernstein.
1318
1319         Bind the progress indicator value to the "estimatedProgress" property.
1320
1321         * MiniBrowser/mac/WK2BrowserWindowController.m:
1322         (-[WK2BrowserWindowController dealloc]):
1323         (-[WK2BrowserWindowController awakeFromNib]):
1324
1325 2013-12-04  Anders Carlsson  <andersca@apple.com>
1326
1327         Add a loading property to WKBrowsingContextController
1328         https://bugs.webkit.org/show_bug.cgi?id=125256
1329
1330         Reviewed by Dan Bernstein.
1331
1332         Bind the progress indicator visibility to the "loading" property.
1333
1334         * MiniBrowser/mac/WK2BrowserWindowController.m:
1335         (-[WK2BrowserWindowController dealloc]):
1336         (-[WK2BrowserWindowController awakeFromNib]):
1337         (-[WK2BrowserWindowController didStartProgress]):
1338         (-[WK2BrowserWindowController didFinishProgress]):
1339
1340 2013-12-04  Nick Diego Yamane  <nick.yamane@openbossa.org>
1341
1342         [EFL][WK2] Buildfix after r160104
1343         https://bugs.webkit.org/show_bug.cgi?id=125231
1344
1345         Reviewed by Anders Carlsson.
1346
1347         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive.cpp:
1348         (TestWebKitAPI::TEST): reinterpret_cast<WKFooClientBase*>(&client) -> &client.base
1349         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
1350         (TestWebKitAPI::setViewClient): Ditto.
1351
1352 2013-12-04  Myles C. Maxfield  <mmaxfield@apple.com>
1353
1354         check-webkit-style detected some ternary statements as initialization lists
1355         https://bugs.webkit.org/show_bug.cgi?id=125246
1356
1357         Reviewed by Dean Jackson.
1358
1359         The regular expression that check-webkit-tests uses to detect initialization
1360         lists was too broad, resulting in false positives. This patch makes the
1361         regex more specific
1362
1363         * Scripts/webkitpy/style/checkers/cpp.py:
1364         (check_member_initialization_list):
1365         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1366         (WebKitStyleTest.test_member_initialization_list):
1367
1368 2013-12-04  Mark Hahnenberg  <mhahnenberg@apple.com>
1369
1370         run-jsc-stress-tests can only run locally
1371         https://bugs.webkit.org/show_bug.cgi?id=124551
1372
1373         Reviewed by Filip Pizlo.
1374
1375         * Scripts/jsc-stress-test-helpers/shell-runner.sh: Fixed a couple issues. One was if the script was
1376         killed before the lock directory was removed, future executions wouldn't make any progress. Also 
1377         added a couple more signals to handle gracefully at shutdown. 
1378         * Scripts/run-javascriptcore-tests: Pass through the --remote argument to run-jsc-stress-tests.
1379         * Scripts/run-jsc-stress-tests: Added support for the --remote flag. It accepts a hostname, user, and port.
1380         The script then generates the test bundle, tars it up, and copies it to the remote host via ssh where
1381         it then untars the bundle and executes the shell-based test runner. Also refactored some of the logic
1382         toward the end of the script to make it easier to tell which of the various modes do what.
1383
1384 2013-12-04  Csaba Osztrogonác  <ossy@webkit.org>
1385
1386         [EFL][WK2] Buildfix after r160104
1387         https://bugs.webkit.org/show_bug.cgi?id=125233
1388
1389         Reviewed by Anders Carlsson.
1390
1391         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive.cpp:
1392         (TestWebKitAPI::TEST):
1393         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
1394         (TestWebKitAPI::setPageLoaderClient):
1395
1396 2013-12-03  Anders Carlsson  <andersca@apple.com>
1397
1398         Deprecate all unversioned client structs in favor of having explicit versioned structs
1399         https://bugs.webkit.org/show_bug.cgi?id=125203
1400
1401         Reviewed by Dan Bernstein.
1402
1403         Update for WebKit2 API changes.
1404
1405         * MiniBrowser/mac/AppDelegate.m:
1406         (-[BrowserAppDelegate init]):
1407         * MiniBrowser/mac/WK2BrowserWindowController.m:
1408         (-[WK2BrowserWindowController awakeFromNib]):
1409         * TestWebKitAPI/InjectedBundleController.cpp:
1410         (TestWebKitAPI::InjectedBundleController::initialize):
1411         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp:
1412         (TestWebKitAPI::TEST):
1413         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
1414         (TestWebKitAPI::setInjectedBundleClient):
1415         * TestWebKitAPI/Tests/WebKit2/CloseThenTerminate.cpp:
1416         (TestWebKitAPI::TEST):
1417         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
1418         (TestWebKitAPI::TEST):
1419         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
1420         (TestWebKitAPI::TEST):
1421         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
1422         (TestWebKitAPI::DOMWindowExtensionBasic::didCreatePage):
1423         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache.cpp:
1424         (TestWebKitAPI::TEST):
1425         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
1426         (TestWebKitAPI::DOMWindowExtensionNoCache::didCreatePage):
1427         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls.cpp:
1428         (TestWebKitAPI::setInjectedBundleClient):
1429         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp:
1430         (TestWebKitAPI::DidAssociateFormControlsTest::didCreatePage):
1431         * TestWebKitAPI/Tests/WebKit2/DidNotHandleKeyDown.cpp:
1432         (TestWebKitAPI::TEST):
1433         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
1434         (TestWebKitAPI::TEST):
1435         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
1436         (TestWebKitAPI::setContextDownloadClient):
1437         (TestWebKitAPI::setPagePolicyClient):
1438         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
1439         (TestWebKitAPI::TEST):
1440         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
1441         (TestWebKitAPI::TEST):
1442         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
1443         (TestWebKitAPI::TEST):
1444         * TestWebKitAPI/Tests/WebKit2/ForceRepaint.cpp:
1445         (TestWebKitAPI::TEST):
1446         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
1447         (TestWebKitAPI::TEST):
1448         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
1449         (TestWebKitAPI::TEST):
1450         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
1451         (TestWebKitAPI::setupGeolocationProvider):
1452         (TestWebKitAPI::setupView):
1453         (TestWebKitAPI::TEST):
1454         * TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback.cpp:
1455         (TestWebKitAPI::TEST):
1456         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
1457         (TestWebKitAPI::setPageLoaderClient):
1458         (TestWebKitAPI::setInjectedBundleClient):
1459         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp:
1460         (TestWebKitAPI::HitTestResultNodeHandleTest::didCreatePage):
1461         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
1462         (TestWebKitAPI::TEST):
1463         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest.cpp:
1464         (TestWebKitAPI::setInjectedBundleClient):
1465         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest_Bundle.cpp:
1466         (TestWebKitAPI::InjectedBundleFrameHitTestTest::didCreatePage):
1467         * TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins.cpp:
1468         (TestWebKitAPI::TEST):
1469         * TestWebKitAPI/Tests/WebKit2/LayoutMilestonesWithAllContentInFrame.cpp:
1470         (TestWebKitAPI::TEST):
1471         * TestWebKitAPI/Tests/WebKit2/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
1472         (TestWebKitAPI::TEST):
1473         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback.cpp:
1474         (TestWebKitAPI::TEST):
1475         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback_Bundle.cpp:
1476         (TestWebKitAPI::LoadCanceledNoServerRedirectCallbackTest::didCreatePage):
1477         * TestWebKitAPI/Tests/WebKit2/LoadPageOnCrash.cpp:
1478         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
1479         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
1480         (TestWebKitAPI::setPageLoaderClient):
1481         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp:
1482         (TestWebKitAPI::setPageLoaderClient):
1483         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails.cpp:
1484         (TestWebKitAPI::setPageLoaderClient):
1485         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
1486         (TestWebKitAPI::setPageLoaderClient):
1487         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
1488         (TestWebKitAPI::setPageLoaderClient):
1489         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
1490         (TestWebKitAPI::TEST):
1491         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
1492         (TestWebKitAPI::TEST):
1493         * TestWebKitAPI/Tests/WebKit2/ParentFrame.cpp:
1494         (TestWebKitAPI::setInjectedBundleClient):
1495         * TestWebKitAPI/Tests/WebKit2/ParentFrame_Bundle.cpp:
1496         (TestWebKitAPI::ParentFrameTest::didCreatePage):
1497         * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications.mm:
1498         (TestWebKitAPI::setInjectedBundleClient):
1499         * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications_Bundle.cpp:
1500         (TestWebKitAPI::PasteboardNotificationsTest::didCreatePage):
1501         * TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp:
1502         (TestWebKitAPI::TEST):
1503         * TestWebKitAPI/Tests/WebKit2/ReloadPageAfterCrash.cpp:
1504         (TestWebKitAPI::TEST):
1505         * TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp:
1506         (TestWebKitAPI::TEST):
1507         * TestWebKitAPI/Tests/WebKit2/ResizeWindowAfterCrash.cpp:
1508         (TestWebKitAPI::TEST):
1509         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp:
1510         (TestWebKitAPI::setInjectedBundleClient):
1511         (TestWebKitAPI::setPageLoaderClient):
1512         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
1513         (TestWebKitAPI::setPageLoaderClient):
1514         * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:
1515         (TestWebKitAPI::TEST):
1516         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem.cpp:
1517         (TestWebKitAPI::setPageLoaderClient):
1518         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem_Bundle.cpp:
1519         (TestWebKitAPI::ShouldGoToBackForwardListItemTest::didCreatePage):
1520         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
1521         (TestWebKitAPI::TEST):
1522         * TestWebKitAPI/Tests/WebKit2/TerminateTwice.cpp:
1523         (TestWebKitAPI::TEST):
1524         * TestWebKitAPI/Tests/WebKit2/UserMessage.cpp:
1525         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::setInjectedBundleClient):
1526         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::setPageLoaderClient):
1527         * TestWebKitAPI/Tests/WebKit2/WKConnection.cpp:
1528         (TestWebKitAPI::TEST):
1529         * TestWebKitAPI/Tests/WebKit2/WKConnection_Bundle.cpp:
1530         (TestWebKitAPI::WKConnectionTest::initialize):
1531         * TestWebKitAPI/Tests/WebKit2/WKPageGetScaleFactorNotZero.cpp:
1532         (TestWebKitAPI::setPageLoaderClient):
1533         * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:
1534         (TestWebKitAPI::setInjectedBundleClient):
1535         (TestWebKitAPI::TEST):
1536         * TestWebKitAPI/Tests/WebKit2/WillLoad.cpp:
1537         (TestWebKitAPI::WebKit2WillLoadTest::setInjectedBundleClient):
1538         * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp:
1539         * TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent.cpp:
1540         (TestWebKitAPI::setInjectedBundleClient):
1541         * TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent_Bundle.cpp:
1542         (TestWebKitAPI::WillSendSubmitEventTest::didCreatePage):
1543         * TestWebKitAPI/Tests/WebKit2/mac/EditorCommands.mm:
1544         (TestWebKitAPI::TEST):
1545         * TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor.mm:
1546         (TestWebKitAPI::setInjectedBundleClient):
1547         * TestWebKitAPI/Tests/WebKit2/mac/GetPIDAfterAbortedProcessLaunch.cpp:
1548         (TestWebKitAPI::TEST):
1549         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme_Bundle.cpp:
1550         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing_Bundle.cpp:
1551         (TestWebKitAPI::DenyWillSendRequestTest::didCreatePage):
1552         * TestWebKitAPI/Tests/WebKit2ObjC/WKRemoteObjectRegistry.mm:
1553         (TestWebKitAPI::didCreateConnection):
1554         (TestWebKitAPI::TEST):
1555         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
1556         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::initializeView):
1557         * TestWebKitAPI/Tests/mac/WKRemoteObjectRegistry_Bundle.mm:
1558         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
1559         (TestWebKitAPI::setPageLoaderClient):
1560         * WebKitTestRunner/GeolocationProviderMock.cpp:
1561         (WTR::GeolocationProviderMock::GeolocationProviderMock):
1562         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1563         (WTR::InjectedBundle::initialize):
1564         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1565         (WTR::InjectedBundlePage::InjectedBundlePage):
1566         * WebKitTestRunner/TestController.cpp:
1567         (WTR::TestController::createOtherPage):
1568         (WTR::TestController::initialize):
1569         (WTR::TestController::createWebViewWithOptions):
1570
1571 2013-12-04  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
1572
1573         Style checker for .messages.in files (WTF:: prefix)
1574         https://bugs.webkit.org/show_bug.cgi?id=125142
1575
1576         Reviewed by Anders Carlsson.
1577
1578         A new style checker for .messages.in files, that checks for the use of WTF::
1579         prefix in these files. (Also checks for tabs as these files were previously
1580         handled as text files.)
1581
1582         * Scripts/webkitpy/style/checker.py:
1583         (CheckerDispatcher._create_checker):
1584           New checker is returned for .messages.in files.
1585         * Scripts/webkitpy/style/checkers/messagesin.py: Added.
1586           The new style checker class.
1587         (MessagesInChecker):
1588         (MessagesInChecker.__init__):
1589         (MessagesInChecker.check):
1590         (MessagesInChecker.check_WTF_prefix):
1591         * Scripts/webkitpy/style/checkers/messagesin_unittest.py: Added.
1592           Unit test for the new style  checker class.
1593         (MessagesInCheckerStyleTestCase):
1594         (test_checker):
1595         (test_checker.error_handler_for_test):
1596         (MessagesInCheckerTestCase):
1597         (MessagesInCheckerTestCase.test_init):
1598         (MessagesInCheckerTestCase.test_init.error_handler_for_test):
1599
1600 2013-12-04  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
1601
1602         Style checker requires alphabetical ordering in cmake lists even it contains variable.
1603         https://bugs.webkit.org/show_bug.cgi?id=124918
1604
1605         Reviewed by Csaba Osztrogonác.
1606
1607         * Scripts/webkitpy/style/checkers/cmake_unittest.py:
1608         (CMakeCheckerTest.test_check):
1609         * Scripts/webkitpy/style/checkers/cmake.py:
1610         (CMakeChecker._check_list_order):
1611         This will ignore lines with variable substitution.
1612
1613 2013-12-04  László Langó  <lango@inf.u-szeged.hu>
1614
1615         check-webkit-style is wrong about expected format parameter pack rvalue reference arguments
1616         https://bugs.webkit.org/show_bug.cgi?id=124731
1617
1618         Reviewed by Zoltan Herczeg.
1619
1620         * Scripts/webkitpy/style/checkers/cpp.py:
1621         (check_spacing):
1622         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1623         (Cpp11StyleTest.test_rvaule_reference_in_parameter_pack):
1624
1625 2013-12-04  László Langó  <lango@inf.u-szeged.hu>
1626
1627         Remove codecs and os dependencies from filereader.py in webkitpy/style.
1628         https://bugs.webkit.org/show_bug.cgi?id=124719
1629
1630         Although TextFileReader requires a FileSystem it circumvents it in two places!
1631         We should use the FileSystem only and remove codecs and os imports.
1632
1633         Reviewed by Zoltan Herczeg.
1634
1635         * Scripts/webkitpy/common/system/filesystem.py:
1636         (FileSystem.open_stdin): Moved from TextFileReader
1637         * Scripts/webkitpy/style/filereader.py:
1638         (TextFileReader._read_lines): use FileSystem instead of calling codecs.open directly
1639         (TextFileReader._process_directory): use FileSystem instead of calling os.walk directly
1640
1641 2013-12-04  László Langó  <lango@inf.u-szeged.hu>
1642
1643         check-webkit-style should check member initialization indentation.
1644         https://bugs.webkit.org/show_bug.cgi?id=124820
1645
1646         Reviewed by Zoltan Herczeg.
1647
1648         check-webkit-style should check member initialization indentation
1649         belongs to webkit coding style:
1650         http://www.webkit.org/coding/coding-style.html#punctuation-member-init
1651
1652         * Scripts/webkitpy/style/checkers/cpp.py:
1653         (check_member_initialization_list): Add new method to check member
1654         initialization list.
1655         (check_style): Add the call of the new method.
1656         (check_language): Move self initialization checking into the new method.
1657         (CppChecker): Add a new category for initialization list.
1658         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1659         (CppStyleTest.test_runtime_selfinit):
1660         (CppStyleTest.test_deprecated_cast):
1661         (WebKitStyleTest.test_member_initialization_list): Add new testcases for
1662         the new feature.
1663
1664 2013-12-04  Tamas Gergely  <gertom@inf.u-szeged.hu>
1665
1666         style-bot should reject Committer additions to committers.py
1667         https://bugs.webkit.org/show_bug.cgi?id=107574
1668
1669         Reviewed by Zoltan Herczeg.
1670
1671         The style check when executed in non-interactive mode (probably by a
1672         bot) will raise an additional error if the contributors.json file is
1673         modified. Non-interactive mode information is propagated to the
1674         Dispatcher, which creates a special JSON checker for the
1675         contributors.json file.
1676
1677         * Scripts/webkitpy/style/checker.py:
1678         (check_webkit_style_configuration):
1679         (CheckerDispatcher._create_checker):
1680         (CheckerDispatcher.dispatch):
1681         (StyleProcessorConfiguration.__init__):
1682         (StyleProcessor.process):
1683         * Scripts/webkitpy/style/checker_unittest.py:
1684         (CheckerDispatcherSkipTest._assert_should_skip_without_warning):
1685         (CheckerDispatcherDispatchTest.dispatch):
1686         (StyleProcessorConfigurationTest._style_checker_configuration):
1687         (StyleProcessor_EndToEndTest.test_init):
1688         (StyleProcessor_EndToEndTest.test_process):
1689         (StyleProcessor_CodeCoverageTest.MockDispatcher.dispatch):
1690         (StyleProcessor_CodeCoverageTest.setUp):
1691         * Scripts/webkitpy/style/checkers/jsonchecker.py:
1692         (JSONChecker.line_number_from_json_exception):
1693         (JSONContributorsChecker):
1694         (JSONContributorsChecker.check):
1695         * Scripts/webkitpy/style/error_handlers_unittest.py:
1696         (DefaultStyleErrorHandlerTest._style_checker_configuration):
1697         * Scripts/webkitpy/style/optparser.py:
1698         (CommandOptionValues.__init__):
1699         (ArgumentParser._create_option_parser):
1700         (ArgumentParser.parse):
1701         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1702         (test_post):
1703         (test_upload):
1704         * Scripts/webkitpy/tool/steps/checkstyle.py:
1705         (CheckStyle.run):
1706
1707 2013-12-04  Nick Diego Yamane  <nick.yamane@openbossa.org>
1708
1709         [EFL][WK2] Fix build after API::Client changes
1710         https://bugs.webkit.org/show_bug.cgi?id=125206
1711
1712         Reviewed by Csaba Osztrogonác.
1713
1714         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive.cpp:
1715         (TestWebKitAPI::TEST):
1716         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
1717         (TestWebKitAPI::setViewClient):
1718
1719 2013-12-03  Dan Bernstein  <mitz@apple.com>
1720
1721         Fixed a test timing out after r160040.
1722
1723         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
1724         (-[SimpleLoadFailDelegate browsingContextController:didFailProvisionalLoadWithError:]):
1725         Updated for the delegate method rename.
1726
1727 2013-12-03  Filip Pizlo  <fpizlo@apple.com>
1728
1729         REGRESSION: repro scripts disappear when you rerun tests
1730         https://bugs.webkit.org/show_bug.cgi?id=125184
1731
1732         Reviewed by Mark Hahnenberg.
1733         
1734         This bug made it difficult to quickly see if a test that recently failed is still
1735         failing while also running a new batch of tests.
1736
1737         Repro scripts are supposed to stay around until you delete them explicitly. This
1738         patch accomplishes that.
1739
1740         * Scripts/run-jsc-stress-tests:
1741
1742 2013-12-03  peavo@outlook.com  <peavo@outlook.com>
1743
1744         [Win] run-jsc-stress-tests has a great number of failures (2026/7606) on Windows
1745         https://bugs.webkit.org/show_bug.cgi?id=125111
1746
1747         Reviewed by Filip Pizlo.
1748
1749         Almost all errors seem to be caused by differences in line ending when diffing test output with expected output.
1750
1751         * Scripts/run-javascriptcore-tests: Enable api test and stress test for WinCairo.
1752         * Scripts/run-jsc-stress-tests: Ignore carriage return when diffing test output with expected output.
1753
1754 2013-12-03  Ryosuke Niwa  <rniwa@webkit.org>
1755
1756         Add a script to automatically configure a git clone
1757         https://bugs.webkit.org/show_bug.cgi?id=110073
1758
1759         Revert the change to use https for now since git.webkit.org is setup with http.
1760
1761         * Scripts/webkitpy/tool/commands/setupgitclone.py:
1762         (SetupGitClone.execute):
1763
1764 2013-12-03  Ryosuke Niwa  <rniwa@webkit.org>
1765
1766         Add a script to automatically configure a git clone
1767         https://bugs.webkit.org/show_bug.cgi?id=110073
1768
1769         Reviewed by Benjamin Poulain.
1770
1771         Added "webkit-patch setup-git-clone" to setup a brand new Git clone.
1772
1773         This command runs various commands listed on http://trac.webkit.org/wiki/UsingGitWithWebKit
1774
1775         * Scripts/webkitpy/tool/commands/__init__.py:
1776         * Scripts/webkitpy/tool/commands/setupgitclone.py: Added.
1777         (SetupGitClone):
1778         (SetupGitClone.execute):
1779
1780 2013-12-03  Anders Carlsson  <andersca@apple.com>
1781
1782         Deprecate WKNotificationProvider
1783         https://bugs.webkit.org/show_bug.cgi?id=125178
1784
1785         Reviewed by Sam Weinig.
1786
1787         Update for WebKit2 changes.
1788
1789         * WebKitTestRunner/TestController.cpp:
1790         (WTR::TestController::initialize):
1791         * WebKitTestRunner/WebNotificationProvider.cpp:
1792         (WTR::WebNotificationProvider::provider):
1793         * WebKitTestRunner/WebNotificationProvider.h:
1794
1795 2013-12-03  Brent Fulgham  <bfulgham@apple.com>
1796
1797         [Win] Support 64-bit Application Support Libraries Location 
1798         https://bugs.webkit.org/show_bug.cgi?id=125179
1799
1800         Reviewed by Tim Horton.
1801
1802         Enable the user to specify a location for 64-bit support libraries (such as libxml2, ICU, etc.)
1803         on Windows until an official distribution is available that properly creates registry settings
1804         to specify these locations.
1805
1806         * Scripts/webkitdirs.pm:
1807         (setupAppleWinEnv): Notify user to set WEBKIT_64_SUPPORT environment variable if needed.
1808         (setupCygwinEnv): Report WEWBKIT_64_SUPPORT path when running 64-bit builds.
1809         (appleApplicationSupportPath): Add WEBKIT_64_SUPPORT location to runtime environment when
1810         running 64-bit builds.
1811
1812 2013-12-03  Mark Hahnenberg  <mhahnenberg@apple.com>
1813
1814         run-jsc-stress-tests only supports host environments that have make installed
1815         https://bugs.webkit.org/show_bug.cgi?id=124550
1816
1817         Reviewed by Darin Adler.
1818
1819         This might not be the case for all hosts, so this patch implements an alternate "backend" 
1820         for run-jsc-stress-tests to use normal shell commands rather than Makefiles. To remain at 
1821         least somewhat competitive with the make-based test runner, the shell backend uses subshells
1822         run in the background to allow tests to run in parallel. Since the concurrency primitives 
1823         in shell scripting are rather coarse, the overhead of this parallelism is higher than that 
1824         of the make-based runner.
1825
1826         * Scripts/jsc-stress-test-helpers/shell-runner.sh: Added. This is the runner that is copied into
1827         the bundle and controls all of the parallel aspects of the shell-based test runner.
1828         * Scripts/run-jsc-stress-tests:
1829
1830 2013-12-03  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
1831
1832         Remove function from TextChecker
1833         https://bugs.webkit.org/show_bug.cgi?id=125148
1834
1835         Reviewed by Darin Adler.
1836
1837         The process_file_data is used only from the unit tests, so it is simply moved there.
1838
1839         * Scripts/webkitpy/style/checkers/text.py:
1840         (TextChecker.check):
1841         * Scripts/webkitpy/style/checkers/text_unittest.py:
1842         (TextStyleTestCase.process_file_data):
1843         (TextStyleTestCase.assertNoError):
1844         (TextStyleTestCase.assertError):
1845
1846 2013-12-03  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
1847
1848         Remove get_test() and reference test names directly instead.
1849         https://bugs.webkit.org/show_bug.cgi?id=124962
1850
1851         Reviewed by Csaba Osztrogonác.
1852
1853         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1854         (Base.__init__):
1855         (Base.get_basic_tests):
1856         (assert_exp):
1857         (MiscTests.test_multiple_results):
1858         (MiscTests.test_category_expectations):
1859         (MiscTests.test_get_modifiers):
1860         (MiscTests.test_get_expectations_string):
1861         (MiscTests.test_get_test_set):
1862         (MiscTests.test_parse_warning):
1863         (MiscTests.test_pixel_tests_flag.match):
1864
1865 2013-12-03  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
1866
1867         Style Checker false pass.
1868         https://bugs.webkit.org/show_bug.cgi?id=112456
1869
1870         Reviewed by Csaba Osztrogonác.
1871
1872         * Scripts/webkitpy/style/checkers/changelog.py:
1873         (ChangeLogChecker.check_entry):
1874         simple regex fix to check "No new tests (...)."
1875         * Scripts/webkitpy/style/checkers/changelog_unittest.py:
1876         (ChangeLogCheckerTest.test_no_new_tests):
1877
1878 2013-12-02  Filip Pizlo  <fpizlo@apple.com>
1879
1880         run-jsc-stress-tests should allow for tests that have a directory containing .js files nested within a directory containing the data
1881         https://bugs.webkit.org/show_bug.cgi?id=125130
1882
1883         Reviewed by Geoffrey Garen.
1884
1885         * Scripts/run-jsc-stress-tests:
1886
1887 2013-12-02  Samuel White  <samuel_white@apple.com>
1888
1889         AX: Add AXUIElementCountForSearchPredicate parameterized attribute.
1890         https://bugs.webkit.org/show_bug.cgi?id=124561
1891
1892         Reviewed by Chris Fleizach.
1893
1894         Added function to verify that NSAccessibilityUIElementCountForSearchPredicateParameterizedAttribute works as it should.
1895
1896         * DumpRenderTree/AccessibilityUIElement.cpp:
1897         (uiElementCountForSearchPredicateCallback):
1898         (uiElementForSearchPredicateCallback):
1899         (AccessibilityUIElement::getJSClass):
1900         * DumpRenderTree/AccessibilityUIElement.h:
1901         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1902         (AccessibilityUIElement::uiElementCountForSearchPredicate):
1903         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1904         (AccessibilityUIElement::uiElementCountForSearchPredicate):
1905         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1906         (searchPredicateParameterizedAttributeForSearchCriteria):
1907         (AccessibilityUIElement::uiElementCountForSearchPredicate):
1908         (AccessibilityUIElement::uiElementForSearchPredicate):
1909         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1910         (AccessibilityUIElement::uiElementCountForSearchPredicate):
1911         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1912         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
1913         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1914         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1915         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1916         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
1917         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1918         (WTR::searchPredicateParameterizedAttributeForSearchCriteria):
1919         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
1920         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1921
1922 2013-12-02  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
1923
1924         Instead of a large 'if' block, each failure class should write it's own result in test_result_writer.py
1925         https://bugs.webkit.org/show_bug.cgi?id=124714
1926
1927         Reviewed by Ryosuke Niwa.
1928
1929         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1930         (write_test_result):
1931         * Scripts/webkitpy/layout_tests/models/test_failures.py:
1932         (TestFailure.write_failure):
1933         (FailureText):
1934         (FailureText.write_failure):
1935         (FailureAudio):
1936         (FailureAudio.write_failure):
1937         (FailureCrash.write_failure):
1938         (FailureMissingResult):
1939         (FailureTextMismatch):
1940         (FailureMissingImageHash.write_failure):
1941         (FailureMissingImage.write_failure):
1942         (FailureImageHashMismatch.write_failure):
1943         (FailureReftestMismatch.write_failure):
1944         (FailureReftestMismatchDidNotOccur.write_failure):
1945         (FailureMissingAudio):
1946         (FailureAudioMismatch):
1947
1948 2013-12-02  László Langó  <lango@inf.u-szeged.hu>
1949
1950         Remove the stderr_write attribute from StyleProcessorConfiguration
1951         https://bugs.webkit.org/show_bug.cgi?id=124703
1952
1953         Reviewed by Ryosuke Niwa.
1954
1955         Remove the stderr_write attribute from this class in checker and
1956         replace its use with calls to a logging module logger. We Should 
1957         use logging module instead of writing to stderr directly.
1958
1959         * Scripts/webkitpy/style/checker.py: Change stderr_write attribute to logging module logger.
1960         (check_webkit_style_configuration):
1961         (CheckerDispatcher.dispatch): Remove FIXME comment.
1962         (StyleProcessorConfiguration):
1963         (StyleProcessorConfiguration.__init__):
1964         (StyleProcessorConfiguration.write_style_error):
1965         * Scripts/webkitpy/style/checker_unittest.py: Update test to the modification.
1966         There is an "ERROR" prefix in log messiges from now.
1967         (StyleProcessorConfigurationTest):
1968         (StyleProcessorConfigurationTest._style_checker_configuration):
1969         (StyleProcessorConfigurationTest.test_init):
1970         (StyleProcessorConfigurationTest.test_write_style_error_emacs):
1971         (StyleProcessorConfigurationTest.test_write_style_error_vs7):
1972         (StyleProcessor_EndToEndTest.with):
1973         (StyleProcessor_EndToEndTest.test_init):
1974         (StyleProcessor_EndToEndTest.test_process):
1975         (StyleProcessor_CodeCoverageTest.setUp):
1976         * Scripts/webkitpy/style/error_handlers.py: Remove stderr_write usage and replace with logging module logger.
1977         (DefaultStyleErrorHandler.__call__):
1978         * Scripts/webkitpy/style/error_handlers_unittest.py: Update test to the modification.
1979         There is an "ERROR" prefix in log messiges from now.
1980         (DefaultStyleErrorHandlerTest):
1981         (DefaultStyleErrorHandlerTest.setUp):
1982         (DefaultStyleErrorHandlerTest._mock_increment_error_count):
1983         (DefaultStyleErrorHandlerTest._style_checker_configuration):
1984         (DefaultStyleErrorHandlerTest._check_initialized):
1985         (DefaultStyleErrorHandlerTest.test_non_reportable_error):
1986         (DefaultStyleErrorHandlerTest.test_max_reports_per_category):
1987         (DefaultStyleErrorHandlerTest.test_line_numbers):
1988
1989 2013-12-02  Brian J. Burg  <burg@cs.washington.edu>
1990
1991         Add JavaScript style checker and teach checker.py about .js files
1992         https://bugs.webkit.org/show_bug.cgi?id=125049
1993
1994         Reviewed by Joseph Pecoraro.
1995
1996         Add a JavaScript file type, extension, and checker (JSChecker).
1997         Use TextChecker for JavaScript tests, libraries, website resources,
1998         etc. and use JSChecker for files within WebInspectorUI/UserInterface.
1999
2000         Amended tests for TextChecker to reflect the rule above.
2001
2002         * Scripts/webkitpy/style/checker.py:
2003         (_all_categories): Add categories defined by JSChecker.
2004         (FileType): Add file type for JS and re-number the enum.
2005         (CheckerDispatcher._file_type): Detect .js files as JavaScript.
2006         (CheckerDispatcher._create_checker):
2007         Create a JSChecker or TextChecker depending on the file's path.
2008
2009         * Scripts/webkitpy/style/checker_unittest.py:
2010         (CheckerDispatcherDispatchTest.assert_checker_js): Added.
2011         (CheckerDispatcherDispatchTest.test_js_paths): Added.
2012         (CheckerDispatcherDispatchTest.test_text_paths): Add new test paths
2013         that end in .js but should be checked with TextChecker.
2014         * Scripts/webkitpy/style/checkers/js.py: Added.
2015         (JSChecker):
2016         (JSChecker.__init__):
2017         (JSChecker.check):
2018         * Scripts/webkitpy/style/checkers/js_unittest.py: Added.
2019         (JSTestCase):
2020         (JSTestCase.assertNoError):
2021         (JSTestCase.assertNoError.error_for_test):
2022         (JSTestCase.assertError):
2023         (JSTestCase.assertError.error_for_test):
2024         (JSTestCase.test_no_error):
2025         (JSTestCase.test_error):
2026
2027 2013-12-02  Mark Hahnenberg  <mhahnenberg@apple.com>
2028
2029         run-jsc-stress-tests always copies the VM
2030         https://bugs.webkit.org/show_bug.cgi?id=125092
2031
2032         Reviewed by Filip Pizlo.
2033
2034         This can be slow, especially with full debug builds. It should just symlink the VM into the 
2035         bundle by default and do a full copy only when asked.
2036
2037         * Scripts/run-jsc-stress-tests:
2038
2039 2013-12-02  Brent Fulgham  <bfulgham@apple.com>
2040
2041         [Win] Port run-jsc-stress-tests
2042         https://bugs.webkit.org/show_bug.cgi?id=124801
2043
2044         Reviewed by Filip Pizlo.
2045
2046         * Scripts/run-jsc-stress-tests: Gracefully handle lack of sysctl
2047         command on Windows so that stress tests can run.
2048
2049 2013-12-02  Mark Hahnenberg  <mhahnenberg@apple.com>
2050
2051         Build fix after r159955
2052
2053         * Scripts/run-jsc-stress-tests:
2054
2055 2013-12-02  Mark Hahnenberg  <mhahnenberg@apple.com>
2056
2057         run-jsc-stress-tests should be able to package its tests and move them places
2058         https://bugs.webkit.org/show_bug.cgi?id=124549
2059
2060         Reviewed by Filip Pizlo.
2061
2062         * Scripts/jsc-stress-test-helpers/check-mozilla-failure: Removed. Was just a ruby reimplementation
2063         of grep -i -q
2064         * Scripts/run-javascriptcore-tests: Pass through the --tarball flag.
2065         * Scripts/run-jsc-stress-tests: Changed to create a bundle of tests inside the results directory.
2066         We now also copy whatever VM was specified, along with its associated framework, into this directory.
2067         All of the generated scripts now are completely relative within the results directory. This allows
2068         run-jsc-stress-tests to execute a bundle from anywhere. Also added a --tarball flag which creates a
2069         tarball of the generated results directory. Also refactored several portions of the script into
2070         separate functions to make it easier to run them conditionally depending on which mode we're running in. 
2071
2072 2013-12-02  Andrzej Badowski  <a.badowski@samsung.com>
2073
2074         [ATK] Support active state for listbox elements.
2075         https://bugs.webkit.org/show_bug.cgi?id=125009
2076
2077         Reviewed by Chris Fleizach.
2078
2079         Supplement WebKitTestRunner and DumpRenderTree to support isSelectedOptionActive.
2080
2081         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2082         (AccessibilityUIElement::isSelectedOptionActive):
2083         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2084         (WTR::AccessibilityUIElement::isSelectedOptionActive):
2085         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2086         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2087         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2088         (WTR::AccessibilityUIElement::isSelectedOptionActive):
2089         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2090         (WTR::AccessibilityUIElement::isSelectedOptionActive):
2091
2092 2013-12-02  Zan Dobersek  <zdobersek@igalia.com>
2093
2094         Unreviewed GTK gardening.
2095
2096         * Scripts/run-gtk-tests:
2097         (TestRunner): Skip two unit tests that are causing the subsequent test to crash.
2098
2099 2013-12-01  Dan Bernstein  <mitz@apple.com>
2100
2101         [Mac] Transition MiniBrowser to the Cocoa API: policy delegate   
2102         https://bugs.webkit.org/show_bug.cgi?id=125046
2103
2104         Reviewed by Sam Weinig.
2105
2106         * MiniBrowser/mac/AppDelegate.m:
2107         (-[BrowserAppDelegate newWindow:]): Added WK_API_ENABLED guards.
2108         (-[BrowserAppDelegate openDocument:]): Ditto.
2109         * MiniBrowser/mac/WK2BrowserWindowController.h: Ditto. Also moved ivar declarations from the
2110         interface to the implementation.
2111         * MiniBrowser/mac/WK2BrowserWindowController.m:
2112         (-[WK2BrowserWindowController awakeFromNib]): Changed to set the policy delegate instead of
2113         the policy client.
2114         (-[WK2BrowserWindowController browsingContextController:decidePolicyForNavigationAction:decisionHandler:]):
2115         Moved policy client implementation into this delegate method.
2116         (-[WK2BrowserWindowController browsingContextController:decidePolicyForNewWindowAction:decisionHandler:]):
2117         Ditto.
2118         (-[WK2BrowserWindowController browsingContextController:decidePolicyForResponseAction:decisionHandler:]):
2119         Ditto.
2120
2121 2013-12-01  Dan Bernstein  <mitz@apple.com>
2122
2123         [Mac] Remove the MiniBrowser injected bundle
2124         https://bugs.webkit.org/show_bug.cgi?id=125041
2125
2126         Reviewed by Anders Carlsson.
2127
2128         It had no ops!
2129
2130         * MiniBrowser/Configurations/WebBundle.xcconfig: Removed.
2131         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
2132         * MiniBrowser/mac/AppDelegate.m:
2133         (-[BrowserAppDelegate init]):
2134         * MiniBrowser/mac/WebBundle/Info.plist: Removed.
2135         * MiniBrowser/mac/WebBundle/WebBundleMain.m: Removed.
2136
2137 2013-11-29  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
2138
2139         check-webkit-style should check for extraneous newline between config.h and primary header.
2140         https://bugs.webkit.org/show_bug.cgi?id=124821
2141
2142         Reviewed by Csaba Osztrogonác.
2143
2144         * Scripts/webkitpy/style/checkers/cpp.py:
2145         (check_include_line):
2146         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2147         (OrderOfIncludesTest.test_check_line_break_after_own_header):
2148         (OrderOfIncludesTest):
2149         (OrderOfIncludesTest.test_check_line_break_before_own_header):
2150
2151 2013-11-29  Jozsef Berta  <jberta@inf.u-szeged.hu>
2152
2153         test-webkit-scripts should show the failing tests and use an appropriate exit code
2154         https://bugs.webkit.org/show_bug.cgi?id=124840
2155
2156         Reviewed by Ryosuke Niwa.
2157
2158         A fixme in test-webkit-scripts asked that the script should display success or failiure
2159         and exit with a 0 or 1 value accordingly after all of the tests have completed.
2160
2161         * Scripts/test-webkit-scripts:
2162         (ScriptsTester.run_test_script):
2163         The outcome of the currently run script is returned to the main as a boolean value. A boolean is returned,
2164         because at this point we don't need to pass on more information other than success or failiure.
2165         (ScriptsTester.main):
2166         The return values are now stored for each script and when all tests have completed successfully,
2167         the script indicates success and returns 0. Otherwise it will display the name(s) of the failing script(s) and return 1.
2168
2169 2013-11-29  Krzysztof Czech  <k.czech@samsung.com>
2170
2171         [ATK] Added support for isAttributeSettable in AccessibilityUIElementAtk
2172         https://bugs.webkit.org/show_bug.cgi?id=124923
2173
2174         Reviewed by Mario Sanchez Prada.
2175
2176         Added missing implementation of isAttributeSettable. Using
2177         ATK_STATE_EDITABLE for checking whether attribute is settable.
2178
2179         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2180         (AccessibilityUIElement::isAttributeSettable):
2181         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2182         (WTR::AccessibilityUIElement::isAttributeSettable):
2183
2184 2013-11-28  Commit Queue  <commit-queue@webkit.org>
2185
2186         Unreviewed, rolling out r159839.
2187         http://trac.webkit.org/changeset/159839
2188         https://bugs.webkit.org/show_bug.cgi?id=124974
2189
2190         run-webkit-tests doesn't generate pretty diff (Requested by
2191         Ossy on #webkit).
2192
2193         * Scripts/webkitpy/common/prettypatch.py:
2194         (PrettyPatch.__init__):
2195         (PrettyPatch.pretty_diff):
2196         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2197         (TestResultWriter.create_text_diff_and_write_result):
2198         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2199         (summarize_results):
2200         * Scripts/webkitpy/port/base.py:
2201         (Port.__init__):
2202         (Port.pretty_patch_available):
2203         (Port.check_pretty_patch):
2204         (Port.variable):
2205         (Port.variable.pretty_patch_text):
2206         * Scripts/webkitpy/port/base_unittest.py:
2207         (PortTest.test_pretty_patch_os_error):
2208         (PortTest.test_pretty_patch_script_error):
2209
2210 2013-11-28  Antti Koivisto  <antti@apple.com>
2211
2212         Remove feature: CSS variables
2213         https://bugs.webkit.org/show_bug.cgi?id=114119
2214
2215         Reviewed by Andreas Kling.
2216
2217         * Scripts/webkitperl/FeatureList.pm:
2218
2219 2013-11-28  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
2220
2221         Move PrettyPatch related code to prettypatch.py
2222         https://bugs.webkit.org/show_bug.cgi?id=124937
2223
2224         Reviewed by Ryosuke Niwa.
2225
2226         This code seems to have a better place here than in Port, since PrettyPatch already knows
2227         pretty_patch_path, and this also unifies the usage of PrettyPatch
2228
2229         * Scripts/webkitpy/common/prettypatch.py:
2230         (PrettyPatch.__init__):
2231         (PrettyPatch.pretty_diff):
2232         (PrettyPatch):
2233         (PrettyPatch.pretty_patch_available):
2234         (PrettyPatch.check_pretty_patch):
2235         (PrettyPatch.pretty_patch_text):
2236         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2237         (TestResultWriter.create_text_diff_and_write_result):
2238         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2239         (summarize_results):
2240         * Scripts/webkitpy/port/base.py:
2241         (Port.__init__):
2242         (Port.wdiff_available):
2243         (Port.check_image_diff):
2244         (Port.wdiff_text):
2245         * Scripts/webkitpy/port/base_unittest.py:
2246         (PortTest.test_pretty_patch_os_error):
2247         (PortTest.test_pretty_patch_script_error):
2248
2249 2013-11-28  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
2250
2251         Checkout should own the scm object in Host
2252         https://bugs.webkit.org/show_bug.cgi?id=124943
2253
2254         Reviewed by Ryosuke Niwa.
2255
2256         * Scripts/webkitpy/common/host.py:
2257         (Host.__init__):
2258         (Host.initialize_scm):
2259         (Host.scm):
2260
2261 2013-11-26  Filip Pizlo  <fpizlo@apple.com>
2262
2263         Do bytecode validation as part of testing
2264         https://bugs.webkit.org/show_bug.cgi?id=124913
2265
2266         Reviewed by Oliver Hunt.
2267
2268         * Scripts/run-jsc-stress-tests:
2269
2270 2013-11-27  Andres Gomez  <agomez@igalia.com>
2271
2272         [GTK] Tools/Scripts/update-webkitgtk-libs fails due to missing fontutils dependencies for building the "xserver" module
2273         https://bugs.webkit.org/show_bug.cgi?id=124940
2274
2275         Reviewed by Martin Robinson.
2276
2277         xserver-font-utils is needed for building gtk port dependencies
2278         with jhbuild.
2279
2280         * gtk/install-dependencies: Added xserver-font-utils to jhbuild
2281         dependecies.
2282
2283 2013-11-27  Andres Gomez  <agomez@igalia.com>
2284
2285         [GTK] Tools/Scripts/update-webkitgtk-libs unsorted and fails because of missing "git"
2286         https://bugs.webkit.org/show_bug.cgi?id=124938
2287
2288         Reviewed by Philippe Normand.
2289
2290         Added needed git dependency for building the gtk port with
2291         jhbuild. Also, the dependencies needed for building the gtk port
2292         are now sorted alphabetically.
2293
2294         * gtk/install-dependencies: Added git as jhbuild dependency and
2295         sorted dependencies alphabetically.
2296
2297 2013-11-27  Jozsef Berta  <jberta@inf.u-szeged.hu>
2298
2299         run_webkit_tests.py: error: no such option: --wincairo
2300         https://bugs.webkit.org/show_bug.cgi?id=124927
2301
2302         Reviewed by Ryosuke Niwa.
2303
2304         * BuildSlaveSupport/build.webkit.org-config/config.json: The run_webkit_tests.py doesn't supports
2305         the layout testing on wincairo, so it is turned off.
2306
2307 2013-11-26  Marcelo Lira  <marcelo.lira@openbossa.org>
2308
2309         Nix upstreaming - Adding build files and supporting scripts
2310         https://bugs.webkit.org/show_bug.cgi?id=118367
2311
2312         Reviewed by Ryosuke Niwa.
2313
2314         * Scripts/build-webkit:
2315         * Scripts/run-nix-tests: Added.
2316         * Scripts/run-webkit-tests:
2317         * Scripts/update-webkit-libs-jhbuild:
2318         * Scripts/update-webkitnix-libs: Added.
2319         * Scripts/webkitdirs.pm:
2320         (determineArchitecture):
2321         (argumentsForConfiguration):
2322         (jscProductDir):
2323         (builtDylibPathForName):
2324         (determineIsNix):
2325         (isNix):
2326         (isAppleWebKit):
2327         (launcherPath):
2328         (launcherName):
2329         (checkRequiredSystemConfig):
2330         (copyInspectorFrontendFiles):
2331         (jhbuildWrapperPrefixIfNeeded):
2332         (buildCMakeProjectOrExit):
2333         (cmakeBasedPortName):
2334         * Scripts/webkitpy/common/config/ports.py:
2335         (DeprecatedPort.port):
2336         (EflWK2Port.build_webkit_command):
2337         (NixPort):
2338         (NixPort.build_webkit_command):
2339         * Scripts/webkitpy/port/factory.py:
2340         (platform_options):
2341         (PortFactory):
2342         * Scripts/webkitpy/port/nix.py: Added.
2343         (NixPort):
2344         (NixPort._wk2_port_name):
2345         (NixPort.determine_full_port_name):
2346         (NixPort.__init__):
2347         (NixPort._port_flag_for_scripts):
2348         (NixPort.setup_test_run):
2349         (NixPort.setup_environ_for_server):
2350         (NixPort.default_timeout_ms):
2351         (NixPort.clean_up_test_run):
2352         (NixPort._generate_all_test_configurations):
2353         (NixPort._path_to_driver):
2354         (NixPort._path_to_image_diff):
2355         (NixPort._image_diff_command):
2356         (NixPort._search_paths):
2357         (NixPort.show_results_html_file):
2358         (NixPort._port_specific_expectations_files):
2359         (NixPort.default_baseline_search_path):
2360         * Scripts/webkitpy/port/nix_unittest.py: Added.
2361         (NixPortTest):
2362         (NixPortTest._assert_search_path):
2363         (NixPortTest._assert_expectations_files):
2364         (NixPortTest.test_baseline_search_path):
2365         (NixPortTest.test_expectations_files):
2366         (NixPortTest.test_default_timeout_ms):
2367         * jhbuild/jhbuild-wrapper:
2368         (determine_platform):
2369         * nix/common.py: Added.
2370         (script_path):
2371         (top_level_path):
2372         * nix/jhbuild.modules: Added.
2373         * nix/jhbuildrc: Added.
2374
2375 2013-11-26  Ryosuke Niwa  <rniwa@webkit.org>
2376
2377         Record subtest values in Dromaeo tests
2378         https://bugs.webkit.org/show_bug.cgi?id=124498
2379
2380         Reviewed by Andreas Kling.
2381
2382         Supported parsing subtest results.
2383
2384         * Scripts/webkitpy/performance_tests/perftest.py: Replaced _metrics with an ordered list of subtests, each of
2385         which contains a dictionary with its name and an ordered list of subtest's metrics.
2386         (PerfTest.__init__): Initialize _metrics as a list.
2387         (PerfTest.run): Go through each subtest and its metrics to create a list of TestMetrics.
2388         (PerfTest._run_with_driver):
2389         (PerfTest._ensure_metrics): Look for a subtest then a metric in _metrics.
2390
2391         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2392         (TestPerfTest._assert_results_are_correct): Updated the assertions per changes to _metrics.
2393         (TestPerfTest.test_parse_output): Ditto.
2394         (TestPerfTest.test_parse_output_with_subtests): Added the metric and the unit on each subtest result as well as
2395         assertions to ensure subtest results are parsed properly.
2396         (TestReplayPerfTest.test_run_with_driver_accumulates_results): Updated the assertions per changes to _metrics.
2397         (TestReplayPerfTest.test_run_with_driver_accumulates_memory_results): Dittp.
2398
2399         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2400         (_generate_results_dict): When the metric for a subtest is processed before that of the main test, the url is
2401         incorrectly suffixed with '/'. Fix this later by re-computing the url with TestPerfMetric.test_file_name when
2402         adding new results.
2403
2404         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
2405         (TestWithSubtestsData): Added.
2406         (TestDriver.run_test):
2407         (MainTest.test_run_test_with_subtests): Added.
2408
2409 2013-11-26  Ryosuke Niwa  <rniwa@webkit.org>
2410
2411         Enable HTML template element on Windows ports
2412         https://bugs.webkit.org/show_bug.cgi?id=124758
2413
2414         Reviewed by Andreas Kling.
2415
2416         * Scripts/webkitperl/FeatureList.pm:
2417
2418 2013-11-26  Ryosuke Niwa  <rniwa@webkit.org>
2419
2420         Remove replay performance tests as it's not actively maintained
2421         https://bugs.webkit.org/show_bug.cgi?id=124764
2422
2423         Reviewed by Andreas Kling.
2424
2425         Removed the feature.
2426
2427         * Scripts/webkitpy/performance_tests/perftest.py:
2428         (SingleProcessPerfTest.__init__):
2429         (PerfTestFactory):
2430         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2431         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2432         (PerfTestsRunner._parse_args):
2433         (PerfTestsRunner._collect_tests):
2434         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2435         (MainTest.test_collect_tests_with_ignored_skipped_list):
2436         (MainTest.test_default_args):
2437         * Scripts/webkitpy/thirdparty/__init__.py:
2438         (AutoinstallImportHook.find_module):
2439         (AutoinstallImportHook._install_unittest2):
2440         * Scripts/webkitpy/thirdparty/__init___unittest.py:
2441         (ThirdpartyTest.test_imports):
2442
2443 2013-11-26  Filip Pizlo  <fpizlo@apple.com>
2444
2445         Enable aggressive DFG validation in testing
2446         https://bugs.webkit.org/show_bug.cgi?id=124911
2447
2448         Rubber stamped by Ryosuke Niwa.
2449         
2450         This enables validation testing in non-concurrent-JIT runs.
2451
2452         * Scripts/run-jsc-stress-tests:
2453
2454 2013-11-26  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
2455
2456         Moved methods which belong to Checkout into checkout.py
2457         https://bugs.webkit.org/show_bug.cgi?id=124889
2458
2459         Reviewed by Ryosuke Niwa.
2460
2461         * Scripts/webkitpy/common/checkout/checkout.py:
2462         (Checkout.scripts_directory):
2463         (Checkout):
2464         (Checkout.script_path):
2465         (Checkout.commit_message_for_this_commit):
2466         (Checkout.apply_patch):
2467         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
2468         (test_commit_message_for_this_commit):
2469         (CheckoutTest.test_apply_patch):
2470         * Scripts/webkitpy/common/checkout/scm/scm.py:
2471         (SCM.absolute_path):
2472         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2473         (SCMTest._setup_webkittools_scripts_symlink):
2474         * Scripts/webkitpy/common/checkout/scm/svn.py:
2475         (SVN.create_patch):
2476
2477 2013-11-25  Ryuan Choi  <ryuan.choi@samsung.com>
2478
2479         [EFL] Use Config mode of find_package for EFL 1.8
2480         https://bugs.webkit.org/show_bug.cgi?id=124555
2481
2482         Reviewed by Gyuyoung Kim.
2483
2484         * MiniBrowser/efl/CMakeLists.txt:
2485         Added optional config mode and made version requirement optional.
2486
2487 2013-11-25  Andres Gomez  <agomez@igalia.com>
2488
2489         [GTK] Search functionality in MiniBrowser provides feedback on search fail
2490         https://bugs.webkit.org/show_bug.cgi?id=122681
2491
2492         Reviewed by Mario Sanchez Prada.
2493
2494         When using the search functionality in MiniBrowser, if the search
2495         fails, the entry background color gets red to report the user
2496         about the failing condition. When the entry is cleaned or the
2497         search is again succesful the background turns back to its
2498         original color.
2499
2500         * MiniBrowser/gtk/BrowserSearchBar.c:
2501         (setFailedStyleForEntry): Added.
2502         (doSearch): Sets the entry's background to its original style if
2503         there is no text to search.
2504         (findControllerFailedToFindTextCallback): Added.
2505         (findControllerFoundTextCallback): Added.
2506         (browser_search_bar_init): Creates and adds a new CSS provider to
2507         the text entry so we can change its style based on the success
2508         condition of the search.
2509         (browserSearchBarFinalize): Frees the new CSS provider.
2510         (browser_search_bar_new): Connects the two new handlers to the
2511         "failed-to-find-text" and "found-text" signals emitted by the
2512         WebKitFindController.
2513
2514 2013-11-25  Dan Bernstein  <mitz@apple.com>
2515
2516         [Cocoa] Put most of the Cocoa API behind WK_API_ENABLED guards
2517         https://bugs.webkit.org/show_bug.cgi?id=124850
2518
2519         Reviewed by Brady Eidson.
2520
2521         Added #if WK_API_ENABLED guards around tests that use the Objective-C API.
2522
2523         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
2524         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
2525         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
2526         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
2527         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
2528         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm:
2529         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
2530
2531 2013-11-25  Commit Queue  <commit-queue@webkit.org>
2532
2533         Unreviewed, rolling out r159752 and r159754.
2534         http://trac.webkit.org/changeset/159752
2535         http://trac.webkit.org/changeset/159754
2536         https://bugs.webkit.org/show_bug.cgi?id=124847
2537
2538         Broke linux test bots. (Requested by mhahnenberg on #webkit).
2539
2540         * Scripts/jsc-stress-test-helpers/check-mozilla-failure: Added.
2541         * Scripts/run-javascriptcore-tests:
2542         * Scripts/run-jsc-stress-tests:
2543
2544 2013-11-25  Mark Hahnenberg  <mhahnenberg@apple.com>
2545
2546         Followup fix after r159752
2547
2548         * Scripts/run-jsc-stress-tests: We need to handle Release builds too.
2549
2550 2013-11-25  Mark Hahnenberg  <mhahnenberg@apple.com>
2551
2552         run-jsc-stress-tests should be able to package its tests and move them places
2553         https://bugs.webkit.org/show_bug.cgi?id=124549
2554
2555         Reviewed by Filip Pizlo.
2556
2557         * Scripts/jsc-stress-test-helpers/check-mozilla-failure: Removed. Was just a ruby reimplementation 
2558         of grep -i -q
2559         * Scripts/run-javascriptcore-tests: Pass through the --tarball flag.
2560         * Scripts/run-jsc-stress-tests: Changed to create a bundle of tests inside the results directory. 
2561         We now also copy whatever VM was specified, along with its associated framework, into this directory. 
2562         All of the generated scripts now are completely relative within the results directory. This allows 
2563         run-jsc-stress-tests to execute a bundle from anywhere. Also added a --tarball flag which creates a 
2564         tarball of the generated results directory. Also refactored several portions of the script into 
2565         separate functions to make it easier to run them conditionally depending on which mode we're running in.
2566
2567 2013-11-25  László Langó  <lango@inf.u-szeged.hu>
2568
2569         EWS creates 0 byte sized log files
2570         https://bugs.webkit.org/show_bug.cgi?id=107606
2571
2572         Reviewed by Ryosuke Niwa.
2573
2574         There was a modification in r138264, that tried to make less log,
2575         because some of the messeges were duplicated. After this the EWS
2576         created the log file (with the same name as the bugID) but doesn't
2577         write anything into it, even if there were errors during the build.
2578         From now only creates the log file only if there is some error.
2579
2580         * Scripts/webkitpy/tool/bot/queueengine.py:
2581         (QueueEngine.run): If the build and tests pass, there is no ScriptError raised,
2582         there is nothing to log. Open the log file only if a ScriptError was raised to
2583         avoid to make empty log files for bugs.
2584         (QueueEngine._open_work_log): Does not need to tee STDOUT to log file anymore,
2585         because of changes in r138264. Teeing is used for locally testing purposes and
2586         this feature is not used anymore.
2587         (QueueEngine._ensure_work_log_closed): Close the logfile. We don't use output
2588         teeing anymore. It is a necessary change because of QueueEngine._open_work_log
2589         change.
2590         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
2591         (LoggingDelegate): The order of the callbacks was changed by this patch.
2592         (QueueEngineTest.test_trivial): Won't create log file if the queue was terminated,
2593         so we have to update this test.
2594         (QueueEngineTest.test_unexpected_error): The order of the callbacks was changed by
2595         this patch.
2596         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2597         (AbstractEarlyWarningSystem.review_patch): Raise again the captured ScriptError
2598         to be able to handle it in QueueEngine.run. Without this change, the existing
2599         exception handler never run (the process_work_item method never raise ScriptError)
2600         We can get the error message only from the ScriptError at this point.
2601
2602 2013-11-22  Dean Jackson  <dino@apple.com>
2603
2604         Speculative Mountain Lion build fix.
2605
2606         * MiniBrowser/mac/AppDelegate.m:
2607         (-[BrowserAppDelegate openDocument:]):
2608
2609 2013-11-22  Anders Carlsson  <andersca@apple.com>
2610
2611         Fix Mountain Lion bug.
2612
2613         * MiniBrowser/mac/AppDelegate.m:
2614         (-[BrowserAppDelegate openDocument:]):
2615
2616 2013-11-22  Anders Carlsson  <andersca@apple.com>
2617
2618         MiniBrowser should use the blocks-based NSOpenPanel API
2619         https://bugs.webkit.org/show_bug.cgi?id=124786
2620
2621         Reviewed by Simon Fraser.
2622
2623         * MiniBrowser/mac/AppDelegate.m:
2624         (-[BrowserAppDelegate frontmostBrowserWindowController]):
2625         Account for windows that don't have a BrowserWindowController.
2626
2627         (-[BrowserAppDelegate openDocument:]):
2628
2629 2013-11-22  Commit Queue  <commit-queue@webkit.org>
2630
2631         Unreviewed, rolling out r159690.
2632         http://trac.webkit.org/changeset/159690
2633         https://bugs.webkit.org/show_bug.cgi?id=124782
2634
2635         Broke webkitpy tests (Requested by ap on #webkit).
2636
2637         * Scripts/webkitpy/tool/bot/queueengine.py:
2638         (QueueEngine.run):
2639         (QueueEngine._open_work_log):
2640         (QueueEngine._ensure_work_log_closed):
2641         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2642         (AbstractEarlyWarningSystem.review_patch):
2643
2644 2013-11-22  László Langó  <lango@inf.u-szeged.hu>
2645
2646         EWS creates 0 byte sized log files
2647         https://bugs.webkit.org/show_bug.cgi?id=107606
2648
2649         Reviewed by Ryosuke Niwa.
2650
2651         There was a modification in r138264, that tried to make less log, 
2652         because some of the messeges were duplicated. After this the EWS 
2653         created the log file (with the same name as the bugID) but doesn't 
2654         write anything into it, even if there were errors during the build. 
2655         From now only creates the log file only if there is some error.
2656
2657         * Scripts/webkitpy/tool/bot/queueengine.py:
2658         (QueueEngine.run): If the build and tests pass, there is no ScriptError raised,
2659         there is nothing to log. Open the log file only if a ScriptError was raised to
2660         avoid to make empty log files for bugs.
2661         (QueueEngine._open_work_log): Does not need to tee STDOUT to log file anymore,
2662         because of changes in r138264. Teeing is used for locally testing purposes and
2663         this feature is not used anymore.
2664         (QueueEngine._ensure_work_log_closed): Close the logfile. We don't use output 
2665         teeing anymore. It is a necessary change because of QueueEngine._open_work_log
2666         change.
2667         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2668         (AbstractEarlyWarningSystem.review_patch): Raise again the captured ScriptError
2669         to be able to handle it in QueueEngine.run. Without this change, the existing
2670         exception handler never run (the process_work_item method never raise ScriptError)
2671         We can get the error message only from the ScriptError at this point.
2672
2673 2013-11-21  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
2674
2675         Remove ENABLE_WORKERS
2676         https://bugs.webkit.org/show_bug.cgi?id=105784
2677
2678         Reviewed by Darin Adler.
2679
2680         * Scripts/webkitperl/FeatureList.pm:
2681
2682 2013-11-21  Darin Adler  <darin@apple.com>
2683
2684         Try to fix buildbot Dashboard for people who have not hidden anything.
2685
2686         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2687         Add a null check for hidden platforms.
2688
2689 2013-11-21  Peter Szanka  <h868064@stud.u-szeged.hu>
2690
2691         Remove chrome/chromium related things from webkitpy.
2692         https://bugs.webkit.org/show_bug.cgi?id=124493
2693
2694         Reviewed by Darin Adler.
2695
2696         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2697         (PortTest.assert_mock_port_works):
2698         * Scripts/webkitpy/port/base.py:
2699         (Port.to.setup_environ_for_server):
2700         * Scripts/webkitpy/port/mac_unittest.py:
2701         (test_tests_for_other_platforms):
2702         * Scripts/webkitpy/port/mock_drt.py:
2703         (MockTestShell.output_for_test):
2704         * Scripts/webkitpy/tool/bot/irc_command.py:
2705         (Restart.execute):
2706         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
2707         (IRCBotTest.test_help):
2708
2709 2013-11-21  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
2710
2711         In filereader.py, process_file() should throw instead of exiting directly when the file doesn't exist
2712         https://bugs.webkit.org/show_bug.cgi?id=124717
2713
2714         Reviewed by Ryosuke Niwa.
2715
2716         * Scripts/webkitpy/style/filereader.py:
2717         (TextFileReader.process_file):
2718         * Scripts/webkitpy/style/filereader_unittest.py:
2719         (TextFileReaderTest.test_process_file__does_not_exist):
2720
2721 2013-11-21  Mark Rowe  <mrowe@apple.com>
2722
2723         <https://webkit.org/b/124702> Stop overriding VALID_ARCHS.
2724
2725         All modern versions of Xcode set it appropriately for our needs.
2726
2727         Reviewed by Alexey Proskuryakov.
2728
2729         * MiniBrowser/Configurations/Base.xcconfig:
2730         * WebKitTestRunner/Configurations/Base.xcconfig:
2731
2732 2013-11-21  Nick Diego Yamane  <nick.yamane@openbossa.org>
2733
2734         webkitdirs::checkForArgumentAndRemoveFromArrayRef() removed wrong element
2735         https://bugs.webkit.org/show_bug.cgi?id=124676
2736
2737         Reviewed by Daniel Bates.
2738
2739         checkForArgumentAndRemoveFromArrayRef functions was removing wrong
2740         elements when there were more then one occurrence of that argument.
2741         E.g: Checking for 'a' in {a, b, a, c}, the resulting array would be
2742         {b, a}, when it should be {b, c}.
2743
2744         * Scripts/webkitdirs.pm:
2745         (checkForArgumentAndRemoveFromArrayRef): bugfix mentioned above.
2746         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRef.pl:
2747         Added; Unit tests for webkitdirs::checkForArgumentAndRemoveFromArrayRef function.
2748
2749 2013-11-21  Ryosuke Niwa  <rniwa@webkit.org>
2750
2751         Update build-webkit after r159550.
2752
2753         * Scripts/webkitperl/FeatureList.pm:
2754
2755 2013-11-21  Lucas Forschler  <lforschler@apple.com>
2756
2757         Bring a new bot online, replacing the previous ones.
2758         
2759         Unreviewed.
2760
2761         * BuildSlaveSupport/build.webkit.org-config/config.json:
2762
2763 2013-11-21  Dean Jackson  <dino@apple.com>
2764
2765         Don't fetch hidden platforms on build.webkit.org/dashboard
2766         https://bugs.webkit.org/show_bug.cgi?id=124750
2767
2768         Reviewed by Tim Horton.
2769
2770         If a platform is hidden, don't fetch its data. If it
2771         becomes unhidden, try to fetch immediately (unless
2772         you've recently fetched).
2773
2774         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2775         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2776
2777 2013-11-21  Commit Queue  <commit-queue@webkit.org>
2778
2779         Unreviewed, rolling out r159633.
2780         http://trac.webkit.org/changeset/159633
2781         https://bugs.webkit.org/show_bug.cgi?id=124726
2782
2783         it broke 10 webkitpy tests (Requested by dino_ on #webkit).
2784
2785         * Scripts/webkitpy/style/checker.py:
2786         (check_webkit_style_configuration):
2787         (CheckerDispatcher.dispatch):
2788         (StyleProcessorConfiguration):
2789         (StyleProcessorConfiguration.__init__):
2790         (StyleProcessorConfiguration.write_style_error):
2791
2792 2013-11-21  László Langó  <lango@inf.u-szeged.hu>
2793
2794         Remove the stderr_write attribute from StyleProcessorConfiguration.
2795         https://bugs.webkit.org/show_bug.cgi?id=124703
2796
2797         Reviewed by Brent Fulgham.
2798
2799         * Scripts/webkitpy/style/checker.py:
2800         (check_webkit_style_configuration):
2801         (CheckerDispatcher.dispatch):
2802         (StyleProcessorConfiguration):
2803         (StyleProcessorConfiguration.__init__):
2804         (StyleProcessorConfiguration.write_style_error):
2805
2806 2013-11-21  Ryosuke Niwa  <rniwa@webkit.org>
2807
2808         PerfTestRunner._generate_results_dict shouldn't depend on test objects
2809         https://bugs.webkit.org/show_bug.cgi?id=124623
2810
2811         Removed the dependency on test objects from results JSON generation.
2812         This allows single test.run to return metrics for multiple tests
2813
2814         Reviewed by Antti Koivisto.
2815
2816         * Scripts/webkitpy/performance_tests/perftest.py:
2817         (PerfTestMetric.__init__): Takes the test path and test name.
2818         (PerfTestMetric.path): Added.
2819         (PerfTestMetric.test_file_name): Added.
2820         (PerfTest.run): Accumulate PerfTestMetric objects instead of raw values.
2821         (PerfTest._ensure_metrics): Instantiate PerfTestMetric with the test path and test name.
2822         The path is going to have the names of subtests at the end once we support them.
2823
2824         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2825         (TestPerfTestMetric.test_init_set_missing_unit): Specify the test path and test name.
2826         (TestPerfTestMetric.test_init_set_time_metric): Ditto.
2827         (TestPerfTestMetric.test_has_values): Ditto.
2828         (TestPerfTestMetric.test_append): Ditto.
2829
2830         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2831         (_generate_results_dict): Only use metrics.
2832         (_run_tests_set): Accumulate metrics as supposed to (test, metrics) pairs.
2833
2834 2013-11-21  Manuel Rego Casasnovas  <rego@igalia.com>
2835
2836         REGRESSION(r159599): webkitdirs.pm spits out warnings at lines 851 and 852
2837         https://bugs.webkit.org/show_bug.cgi?id=124697
2838
2839         Reviewed by Ryosuke Niwa.
2840
2841         * Scripts/webkitdirs.pm:
2842         (checkForArgumentAndRemoveFromARGVGettingValue): Fix check of array size
2843         before trying to access to the first element.
2844
2845 2013-11-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2846
2847         [GTK] Mark all deprecated symbols in GObject DOM bindings
2848         https://bugs.webkit.org/show_bug.cgi?id=124406
2849
2850         Reviewed by Gustavo Noronha Silva.
2851
2852         * Scripts/webkitpy/style/checker.py: Add special case for
2853         WebKitDOMDeprecated.
2854         * gtk/generate-gtkdoc:
2855         (get_webkit2_options): Use the prefix of the methods as namespace,
2856         since this is what gtkdoc expects to sort the index.
2857         (get_webkit1_options): Ditto.
2858         (get_webkitdom_options): Ditto.
2859         * gtk/generate-webkitdom-doc-files:
2860         (WebKitDOMDocGenerator): Add a global list of deleted objects.
2861         (WebKitDOMDocGenerator.write_deleted_classes): New method to write
2862         the documentation for classes that are deprecated because they
2863         have been removed.
2864         (WebKitDOMDocGeneratorDocs.write_deleted_classes): Add sections
2865         for deleted classes too.
2866         (WebKitDOMDocGeneratorSections.__init__): Build a list of
2867         deprecated symbols using the given symbols file.
2868         (WebKitDOMDocGeneratorSections._deleted_class): Returns the
2869         deleted class corresponding to the given function.
2870         (WebKitDOMDocGeneratorSections._deprecated_symbols): Builds a
2871         dictionary of deprecated symbols for every class.
2872         (WebKitDOMDocGeneratorSections.write_section): Add also the
2873         deprecated symbols in every section.
2874         (WebKitDOMDocGeneratorSections.write_deleted_classes): Add
2875         sections for deleted classes too.
2876
2877 2013-11-20  László Langó  <lango@inf.u-szeged.hu>
2878
2879         check-webkit-style should support C++11 rvalue references.
2880         https://bugs.webkit.org/show_bug.cgi?id=123406
2881
2882         Reviewed by Brent Fulgham.
2883
2884         * Scripts/webkitpy/style/checkers/cpp.py:
2885         (check_style):
2886         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2887         (Cpp11StyleTest):
2888         (Cpp11StyleTest.test_rvaule_reference_at_end_of_line):
2889
2890 2013-11-20  Dean Jackson  <dino@apple.com>
2891
2892         Allow settings to be shown/hidden on build.webkit.org/dashboard
2893         https://bugs.webkit.org/show_bug.cgi?id=124694
2894
2895         Reviewed by Tim Horton.
2896
2897         In preparation for more options/buttons, allow the page to
2898         show or hide all the interactive things using a little gear icon
2899         in the top left corner.
2900
2901         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
2902         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
2903         (Settings.prototype.toggleSettingsDisplay):
2904         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2905         (div.cellButton.hide):
2906         (div.cellButton.unhide):
2907         (.settings-visible div.cellButton.hide, .settings-visible div.cellButton.unhide):
2908         (.settings):
2909         (.settings:hover):
2910         (.settings-visible .settings):
2911
2912 2013-11-20  Dean Jackson  <dino@apple.com>
2913
2914         No need to base64 SVG on build.webkit.org/dashboard
2915         https://bugs.webkit.org/show_bug.cgi?id=124687
2916
2917         Reviewed by Tim Horton.
2918
2919         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
2920         (.status-line.good .bubble.pictogram):
2921
2922 2013-11-20  Dean Jackson  <dino@apple.com>
2923
2924         Make links look more like links on build.webkit.org/dashboard
2925         https://bugs.webkit.org/show_bug.cgi?id=124686
2926
2927         Reviewed by Tim Horton.
2928
2929         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotQueueView.css:
2930         (.queue-view .queueLabel:hover):
2931         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
2932         (.status-line.linked .label:hover):
2933
2934 2013-11-20  Nick Diego Yamane  <nick.yamane@openbossa.org>
2935
2936         Modify webkitdirs to reuse checkForArgumentAndRemoveFromARGV
2937         https://bugs.webkit.org/show_bug.cgi?id=124581
2938
2939         Reviewed by Daniel Bates.
2940
2941         Some subroutines are replicating code from checkForArgument**
2942         functions instead of reusing them as is being done by all other functions.
2943
2944         * Scripts/webkitdirs.pm:
2945         (determineXcodeSDK): Added.
2946         (determinePassedConfiguration): Added.
2947         (determinePassedArchitecture): Added.
2948         (checkForArgumentAndRemoveFromARGV): Added.
2949         (checkForArgumentAndRemoveFromARGVGettingValue): Added.
2950
2951 2013-11-20  Jozsef Berta  <jberta@inf.u-szeged.hu>
2952
2953         Delete baseline optimizer
2954         https://bugs.webkit.org/show_bug.cgi?id=122333
2955
2956         Reviewed by Ryosuke Niwa.
2957
2958         * Scripts/webkitpy/common/checkout/baselineoptimizer.py: Removed.
2959         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py: Removed.
2960         * Scripts/webkitpy/tool/commands/rebaseline.py:
2961         (RebaselineTest.execute):
2962         (AbstractParallelRebaselineCommand._files_to_add):
2963         (AbstractParallelRebaselineCommand._rebaseline):
2964         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2965         (TestRebaselineJson.test_rebaseline_all):
2966         (TestRebaselineJson.test_rebaseline_debug):
2967         (TestRebaselineExpectations.disabled_test_overrides_are_included_correctly):
2968
2969 2013-11-20  Anders Carlsson  <andersca@apple.com>
2970
2971         Enable PageLoadTest assertions again
2972         https://bugs.webkit.org/show_bug.cgi?id=124681
2973
2974         Reviewed by Tim Horton.
2975
2976         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2977         Actually install all-content-in-one-iframe.html, noticed while debugging this assertion.
2978
2979 2013-11-20  Mark Rowe  <mrowe@apple.com>
2980
2981         Remove some obsolete logic from WebKit.app.
2982
2983         Reviewed by Alexey Proskuryakov.
2984
2985         * WebKitLauncher/WebKitNightlyEnabler.m:
2986         (poseAsWebKitApp): Remove a pre-10.6 codepath.
2987         (enableWebKitNightlyBehaviour): Remove a 10.4-specific codepath.
2988
2989 2013-11-20  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
2990
2991         Moved stray urls from svn.py and statusserver.py into common.config.urls
2992         https://bugs.webkit.org/show_bug.cgi?id=124650
2993
2994         Reviewed by Ryosuke Niwa.
2995
2996         * Scripts/webkitpy/common/checkout/scm/svn.py:
2997         (SVNRepository):
2998         * Scripts/webkitpy/common/config/urls.py:
2999         * Scripts/webkitpy/common/net/statusserver.py:
3000         (StatusServer.__init__):
3001         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3002         (_generate_results_dict):
3003
3004 2013-11-20  Commit Queue  <commit-queue@webkit.org>
3005
3006         Unreviewed, rolling out r159496.
3007         http://trac.webkit.org/changeset/159496
3008         https://bugs.webkit.org/show_bug.cgi?id=124641
3009
3010         It caused warning and build break with cmake lower than 2.8.8
3011         (Requested by ryuan on #webkit).
3012
3013         * MiniBrowser/efl/CMakeLists.txt:
3014
3015 2013-11-20  Gabor Rapcsanyi  <rgabor@webkit.org>
3016
3017         [EFL] libseccomp-2.0.0 doesn't support ARM architecture
3018         https://bugs.webkit.org/show_bug.cgi?id=124412
3019
3020         Reviewed by Gyuyoung Kim.
3021
3022         Update libseccomp to a newer 2.1.0 version.
3023
3024         * efl/jhbuild.modules:
3025
3026 2013-11-19  Mark Rowe  <mrowe@apple.com>
3027
3028         <rdar://problem/15487072> Modernize WebKit.app's OS X version checking logic.
3029
3030         Gestalt is deprecated on recent OS X versions so we should switch off it.
3031
3032         Reviewed by Sam Weinig.
3033
3034         * WebKitLauncher/main.m:
3035         (currentMacOSXVersion): Retrieve the version string from SystemVersion.plist.
3036         (currentMacOSXMajorVersion): Split the version string at the periods, retrieve the first
3037         two components, then join them back up.
3038         (main): Switch to using currentMacOSXMajorVersion to make it clearer which part of
3039         the version we care about.
3040
3041 2013-11-19  Commit Queue  <commit-queue@webkit.org>
3042
3043         Unreviewed, rolling out r159538.
3044         http://trac.webkit.org/changeset/159538
3045         https://bugs.webkit.org/show_bug.cgi?id=124627
3046
3047         it broke run-jsc-stress-tests (Requested by mhahnenberg on
3048         #webkit).
3049
3050         * Scripts/jsc-stress-test-helpers/check-mozilla-failure: Added.
3051         * Scripts/run-javascriptcore-tests:
3052         * Scripts/run-jsc-stress-tests:
3053
3054 2013-11-19  Mark Hahnenberg  <mhahnenberg@apple.com>
3055
3056         run-jsc-stress-tests should be able to package its tests and move them places
3057         https://bugs.webkit.org/show_bug.cgi?id=124549
3058
3059         Reviewed by Geoff Garen and Filip Pizlo.
3060
3061         * Scripts/jsc-stress-test-helpers/check-mozilla-failure: Removed. This script was just a ruby reimplementation 
3062         of grep -i -q 
3063         * Scripts/run-javascriptcore-tests: Pass through the --make-bundle flag.
3064         * Scripts/run-jsc-stress-tests: Added the new concept of a "bundle", which is a collection of all tests and any
3065         other files that those tests require to run in any environment along with a fixed root directory into which these
3066         files and their expected directory structure are cloned. The default Bundle class is basically 
3067         a no-op so that it functions like run-jsc-stress-tests prior to this patch. MovableBundle is a Bundle that knows 
3068         how to translate local paths to bundle paths and does all the work of moving each test file into the right place 
3069         inside the .tests directory. After all the test files have been created in jsc-stress-results MovableBundle 
3070         creates a tarball of the entire directory for easy relocation. The --make-bundle flag causes run-jsc-stress-tests 
3071         to use MovableBundle instead of just Bundle. 
3072
3073 2013-11-19  Dan Bernstein  <mitz@apple.com>
3074
3075         <rdar://problem/15139479> Reenable the JSC Objective-C API tests on Mountain Lion once the bots are running Xcode 5
3076
3077         Rubber-stamped by Mark Rowe.
3078
3079         Reverted r156840.
3080
3081         * TestWebKitAPI/Tests/mac/WebViewDidCreateJavaScriptContext.mm:
3082
3083 2013-11-19  Ryosuke Niwa  <rniwa@webkit.org>
3084
3085         Yet another build fix. Just allow any character.
3086         There are just too many special characters to be listed here.
3087
3088         * Scripts/webkitpy/performance_tests/perftest.py:
3089         (PerfTest._lines_to_ignore_in_parser_result):
3090         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
3091         (TestPerfTest.test_parse_output_with_subtests)
3092
3093 2013-11-19  Ryosuke Niwa  <rniwa@webkit.org>
3094
3095         Another build fix. Allow ':' in subtest names.
3096
3097         * Scripts/webkitpy/performance_tests/perftest.py:
3098         (PerfTest._lines_to_ignore_in_parser_result):
3099         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
3100         (TestPerfTest.test_parse_output_with_subtests)
3101
3102 2013-11-19  Ryuan Choi  <ryuan.choi@samsung.com>
3103
3104         [EFL] Use Config mode of find_package for EFL 1.8
3105         https://bugs.webkit.org/show_bug.cgi?id=124555
3106
3107         Reviewed by Gyuyoung Kim.
3108
3109         * MiniBrowser/efl/CMakeLists.txt: Introduced a config mode to find elementary.
3110
3111 2013-11-19  Ryosuke Niwa  <rniwa@webkit.org>
3112
3113         Build fix. Subtest names need to be more permissive.
3114
3115         * Scripts/webkitpy/performance_tests/perftest.py:
3116         (PerfTest._lines_to_ignore_in_parser_result):
3117         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
3118         (TestPerfTest.test_parse_output_with_subtests)
3119
3120 2013-11-18  Mark Rowe  <mrowe@apple.com>
3121
3122         Use hw.activecpu for determining how many processes to spawn.
3123
3124         It's documented as the preferred way to determine the number of threads
3125         or processes to create in a SMP aware application.
3126
3127         Rubber-stamped by Tim Horton.
3128
3129         * Scripts/copy-webkitlibraries-to-product-directory:
3130         * Scripts/run-jsc-stress-tests:
3131         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3132
3133 2013-11-18  Tim Horton  <timothy_horton@apple.com>
3134
3135         build.webkit.org/dashboard builder headers should link to the builder page
3136         https://bugs.webkit.org/show_bug.cgi?id=124553
3137
3138         Reviewed by Timothy Hatcher.
3139
3140         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
3141         (BuildbotQueue.prototype.get overviewURL):
3142         Add overviewURL(), which returns the URL to the builder overview page, with the last 50 builds shown.
3143
3144         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
3145         (BuildbotBuilderQueueView.prototype.update.appendBuildArchitecture):
3146         (BuildbotBuilderQueueView.prototype.update):
3147         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3148         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
3149         (BuildbotTesterQueueView.prototype.update.appendBuild):
3150         (BuildbotTesterQueueView.prototype.update):
3151         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotQueueView.css:
3152         (.queue-view .queueLabel):
3153         (.queue-view .queueLabel:not(:first-child)):
3154         Make the header a link instead of a label, and wire it up to overviewURL.
3155
3156 2013-11-18  Samuel White  <samuel_white@apple.com>
3157
3158         AX: Add ability to fetch only visible table rows.
3159         https://bugs.webkit.org/show_bug.cgi?id=124430
3160
3161         Reviewed by Chris Fleizach.
3162
3163         Adding method to fetch array of AccessibilityUIElements to help with test brevity and test breakage. Specifically, we
3164         have a good deal of churn any time we add or update an element attribute. This happens because the number of tests
3165         that rely on a simple element description text dump to verify a single attribute is non trivial. So any time you
3166         change add an attribute, you have to update all the tests that are now implicitly verifying this new attribute. But
3167         as the test guidelines state, our tests should be more focused and specific about what they test.
3168
3169         * DumpRenderTree/AccessibilityUIElement.cpp:
3170         (uiElementArrayAttributeValueCallback):
3171         (AccessibilityUIElement::uiElementArrayAttributeValue):
3172         (AccessibilityUIElement::getJSClass):
3173         * DumpRenderTree/AccessibilityUIElement.h:
3174         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3175         (AccessibilityUIElement::uiElementArrayAttributeValue):
3176         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3177         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue):
3178         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3179         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3180         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3181         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue):
3182         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3183         (WTR::AccessibilityUIElement::getUIElementsWithAttribute):
3184         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue):
3185
3186 2013-11-18  Ryosuke Niwa  <rniwa@webkit.org>
3187
3188         Simplify and reformat the output of performance tests inside test runners
3189         https://bugs.webkit.org/show_bug.cgi?id=124496
3190
3191         Reviewed by Antti Koivisto.
3192
3193         As a preparation to support subtests for Dromaeo and DoYouEvenBench, simplify the output
3194         performance tests generate. Instead of spitting out noise in PerfTestRunner (runner.js)
3195         and ignoring it in PerfTest._filter_output (perftest.py), simply avoid generating it in
3196         the first place.
3197
3198         Also modernize the output to adopt "metric" concept better and make it forward compatible
3199         with subtests.
3200
3201         With this patch, performance tests written using runner.js only produces empty lines or
3202         lines of the following format inside test runners (DumpRenderTree and WebKitTestRunner):
3203         <subtest name> -> [<value 1>, <value 2>, ...]
3204         :<metric name> -> [<value 1>, <value 2>, ...]
3205
3206         This greatly simplifies the parsing logic inside PerfTest._run_with_driver.
3207
3208         * Scripts/webkitpy/performance_tests/perftest.py:
3209         (PerfTest): Removed a bunch of regular expressions that are no longer used.
3210         (PerfTest._run_with_driver): Just parse the values and description and treat everything
3211         else as errors.
3212
3213         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
3214         (TestPerfTest.test_parse_output): Removed the junk.
3215         (TestPerfTest._assert_failed_on_line): Extracted from test_parse_output_with_failing_line,
3216         which was removed in favor of the tests below.
3217         (TestPerfTest.test_parse_output_with_running_five_times): Added.
3218         (TestPerfTest.test_parse_output_with_detailed_info): Added.
3219         (TestPerfTest.test_parse_output_with_statistics): Added.
3220         (TestPerfTest.test_parse_output_with_description): Removed the junk.
3221         (TestPerfTest.test_parse_output_with_subtests): Ditto.
3222         (TestSingleProcessPerfTest.test_use_only_one_process): Ditto.
3223
3224         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
3225         (EventTargetWrapperTestData): Ditto.
3226         (SomeParserTestData): Ditto.
3227         (MemoryTestData): Ditto.
3228
3229 2013-11-18  Tim Horton  <timothy_horton@apple.com>
3230
3231         Occasionally, hundreds of tests fail with small text diffs on Mavericks
3232         https://bugs.webkit.org/show_bug.cgi?id=124312
3233
3234         Reviewed by Simon Fraser.
3235
3236         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3237         (Manager._set_up_run):
3238         * Scripts/webkitpy/port/base.py:
3239         (Port.to.reset_preferences):
3240         * Scripts/webkitpy/port/mac.py:
3241         (MacPort.reset_preferences):
3242         Delete DumpRenderTree and WebKitTestRunner defaults domains before running tests,
3243         returning some of the functionality of 158652 after 159364 removed it.
3244
3245 2013-11-18  Tim Horton  <timothy_horton@apple.com>
3246
3247         Checkmarks are shifted down on iPhone at build.webkit.org/dashboard
3248         https://bugs.webkit.org/show_bug.cgi?id=122909
3249
3250         Reviewed by Alexey Proskuryakov.
3251
3252         Put the checkmark SVG in the CSS file as a data URI so it loads immediately.
3253
3254         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
3255         (.status-line .bubble):
3256         (.status-line.good .bubble.pictogram):
3257
3258 2013-11-18  Ryosuke Niwa  <rniwa@webkit.org>
3259
3260         Remove _lines_to_ignore_in_stderr, which was only used in Chromium port
3261         https://bugs.webkit.org/show_bug.cgi?id=124499
3262
3263         Reviewed by Csaba Osztrogonác.
3264
3265         Removed the code. I didn't like this hack back when it was added, and I don't like it today.
3266
3267         * Scripts/webkitpy/performance_tests/perftest.py:
3268         (PerfTest._should_ignore_line):
3269         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
3270         (TestPerfTest): Removed the unit test.
3271
3272 2013-11-17  Filip Pizlo  <fpizlo@apple.com>
3273
3274         Unreviewed, fix this script for older Rubies where Pathname doesn't coerce to String
3275         quite as easily.
3276         
3277         With help from Andy Trick.
3278
3279         * Scripts/export-llvm-build:
3280
3281 2013-11-15  Filip Pizlo  <fpizlo@apple.com>
3282
3283         FTL should have an explicit notion of bytecode liveness
3284         https://bugs.webkit.org/show_bug.cgi?id=124181
3285
3286         Reviewed by Mark Hahnenberg.
3287
3288         * Scripts/run-jsc-stress-tests:
3289
3290 2013-11-16  Dan Bernstein  <mitz@apple.com>
3291
3292         No way for policy client to determine if a the response’s MIME type can be shown
3293         https://bugs.webkit.org/show_bug.cgi?id=124445
3294
3295         Reviewed by Sam Weinig.
3296
3297         * MiniBrowser/mac/WK2BrowserWindowController.m:
3298         (decidePolicyForResponse): Added canShowMIMEType parameter.
3299         (-[WK2BrowserWindowController awakeFromNib]): Updated for changes in the policy client.
3300
3301         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
3302         (TestWebKitAPI::decidePolicyForResponse): Added canShowMIMEType parameter.
3303
3304         * WebKitTestRunner/TestController.cpp:
3305         (WTR::TestController::createWebViewWithOptions): Updated for changes in the policy client.
3306         (WTR::TestController::decidePolicyForResponse): Added canShowMIMEType parameter.
3307         * WebKitTestRunner/TestController.h:
3308
3309 2013-11-16  Tim Horton  <timothy_horton@apple.com>
3310
3311         Checkmarks are shifted down on iPhone at build.webkit.org/dashboard
3312         https://bugs.webkit.org/show_bug.cgi?id=122909
3313
3314         Reviewed by Timothy Hatcher.
3315
3316         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/checkmark.svg: Added.
3317         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js:
3318         (StatusLineView.prototype.set repeatCount):
3319         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
3320         (.status-line.good .bubble.pictogram):
3321         Use an SVG image instead of an obscure font for the checkboxes so they
3322         render identically on all platforms.
3323
3324 2013-11-15  Tim Horton  <timothy_horton@apple.com>
3325
3326         Occasionally, hundreds of tests fail with small text diffs on Mavericks
3327         https://bugs.webkit.org/show_bug.cgi?id=124312
3328
3329         Reviewed by Alexey Proskuryakov.
3330
3331         Try reverting the part of r158652 that deleted all of the persistent
3332         defaults, in the thought that there might be some sort of race between
3333         processes causing some settings to be left in the wrong state.
3334
3335         * DumpRenderTree/mac/DumpRenderTree.mm:
3336         (setDefaultsToConsistentValuesForTesting):
3337         * WebKitTestRunner/mac/main.mm:
3338         (setDefaultsToConsistentValuesForTesting):
3339
3340 2013-11-15  Dan Bernstein  <mitz@apple.com>
3341
3342         Give the policy client the originating frame of a navigation action
3343         https://bugs.webkit.org/show_bug.cgi?id=124431
3344
3345         Reviewed by Anders Carlsson.
3346
3347         * MiniBrowser/mac/WK2BrowserWindowController.m:
3348         (decidePolicyForNavigationAction): Added originatingFrame parameter.
3349         (-[WK2BrowserWindowController awakeFromNib]): Updated for the new version of the policy
3350         client.
3351
3352         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
3353         (TestWebKitAPI::decidePolicyForNavigationAction): Added originatingFrame parameter.
3354         (TestWebKitAPI::setPagePolicyClient): Updated for the new version of the policy client.
3355
3356         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
3357         (TestWebKitAPI::decidePolicyForNavigationAction): Added originatingFrame parameter.
3358         (TestWebKitAPI::TEST): Updated for the new version of the policy client.
3359
3360         * WebKitTestRunner/TestController.cpp:
3361         (WTR::TestController::createWebViewWithOptions): Updated for the new version of the policy
3362         client.
3363         (WTR::TestController::decidePolicyForNavigationAction): Added originatingFrame parameter.
3364         * WebKitTestRunner/TestController.h:
3365
3366 2013-11-15  Tim Horton  <timothy_horton@apple.com>
3367
3368         build.webkit.org/dashboard should provide a way to focus on a subset of bots
3369         https://bugs.webkit.org/show_bug.cgi?id=122676
3370
3371         Reviewed by Timothy Hatcher.
3372
3373         Add a small 'hide' button next to every platform logo, and a 'show all'
3374         button which only appears when at least one platform is hidden. Hidden
3375         platforms persist using localStorage.
3376
3377         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
3378         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
3379         (updateHiddenPlatforms):
3380         (documentReady.unhideButton):
3381         (documentReady.hideButton):
3382         (documentReady):
3383         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js: Added.
3384         (Settings.prototype.setObject):
3385         (Settings.prototype.getObject):
3386         (Settings.prototype.addSettingListener):
3387         (Settings.prototype.fireSettingListener):
3388         (Settings.prototype.toggleHiddenPlatform):
3389         (Settings.prototype.clearHiddenPlatforms):
3390         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3391         (div.cellButton):
3392         (div.cellButton.hide):
3393         (.hidden):
3394         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
3395
3396 2013-11-15  Jer Noble  <jer.noble@apple.com>
3397
3398         MediaTime addition and subtraction operators have errors when the rhs is infinite.
3399         https://bugs.webkit.org/show_bug.cgi?id=124413
3400
3401         Reviewed by Eric Carlson.
3402
3403         Add a test for operator+ and operator- where an infinite value appears
3404         on the right-hand side:
3405         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
3406         (TestWebKitAPI::TEST):
3407
3408         Add a LLDB summary provider for MediaTime which displays the rational
3409         time as well as the value in seconds:
3410         * lldb/lldb_webkit.py:
3411         (__lldb_init_module):
3412         (WTFMediaTime_SummaryProvider):
3413         (WTFHashTableProvider.has_children):
3414         (WTFMediaTimeProvider):
3415         (WTFMediaTimeProvider.__init__):
3416         (WTFMediaTimeProvider.timeValue):
3417         (WTFMediaTimeProvider.timeScale):
3418         (WTFMediaTimeProvider.isInvalid):
3419         (WTFMediaTimeProvider.isPositiveInfinity):
3420         (WTFMediaTimeProvider.isNegativeInfinity):
3421         (WTFMediaTimeProvider.isIndefinite):
3422
3423 2013-11-15  Tim Horton  <timothy_horton@apple.com>
3424
3425         Make it possible to select revision numbers on build.webkit.org/dashboard
3426         https://bugs.webkit.org/show_bug.cgi?id=124400
3427
3428         Reviewed by Timothy Hatcher.
3429
3430         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3431         (BuildbotQueueView.prototype.revisionLinksForIteration):
3432         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3433         (.selectable):
3434         Add a child span to the trac link, which has '-webkit-user-select: all' on it.
3435         This way, a Dashboard user can highlight revision numbers for easy copying,
3436         and doesn't even have to be precise about the selection.
3437
3438 2013-11-15  Tim Horton  <timothy_horton@apple.com>
3439
3440         Adjust and add retina versions of EFL and GTK build.webkit.org/dashboard icons
3441         https://bugs.webkit.org/show_bug.cgi?id=124399
3442
3443         Reviewed by Gustavo Noronha Silva.
3444
3445         Add new EFL and GTK icons (derived from Wikipedia's SVGs) to make new 1x and 2x icons,
3446         with the icons adjusted to have solid backgrounds, to not be squished, and to not
3447         intersect the ring, similar to the Mac icons.
3448
3449         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/EFL.png:
3450         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/EFL@2x.png: Added.
3451         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/GTK.png:
3452         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/GTK@2x.png: Added.
3453         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
3454         (documentReady.hideButton):
3455         (documentReady):
3456         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3457         (table.queue-grid tr.platform.linux-gtk img.logo):
3458         (table.queue-grid tr.platform.linux-efl img.logo):
3459
3460 2013-11-15  Stephane Jadaud  <sjadaud@sii.fr>
3461
3462         [GStreamer] Add support for Media Source API
3463         https://bugs.webkit.org/show_bug.cgi?id=99065
3464
3465         Reviewed by Philippe Normand.
3466
3467         * Scripts/webkitperl/FeatureList.pm:
3468
3469 2013-11-15  Xabier Rodriguez Calvar  <calvaris@igalia.com>
3470
3471         [GTK] Bumping GStreamer version to 1.2.1 for the dependencies
3472         https://bugs.webkit.org/show_bug.cgi?id=124360
3473
3474         Reviewed by Philippe Normand.
3475
3476         * gtk/jhbuild.modules: Bumped GStreamer version up to 1.2.1
3477
3478 2013-11-14  Brent Fulgham  <bfulgham@apple.com>
3479
3480         [Win] Improve support for command line builds of 64-bit JSC
3481         https://bugs.webkit.org/show_bug.cgi?id=124380
3482
3483         Reviewed by David Kilzer.
3484
3485         * Scripts/webkitdirs.pm:
3486         (argumentsForConfiguration): Recognize all flavors of Debug and Release (i.e., 'Debug',
3487         'Debug|Win32', 'Debug|x64') when passing arguments to child processes.
3488         (determinePassedConfiguration): Don't suffix configuration with "|Win32" or "|x64". That's
3489         what the "$configurationForVisualStudio" value is for.
3490
3491 2013-11-14  Oliver Hunt  <oliver@apple.com>
3492
3493         Make CLoop easier to build, and make it work
3494         https://bugs.webkit.org/show_bug.cgi?id=124359
3495
3496         Reviewed by Geoffrey Garen.
3497
3498         Add --cloop support to forcibly enable to CLoop build
3499
3500         * Scripts/build-jsc:
3501         * Scripts/build-webkit:
3502
3503 2013-11-14  Lucas Forschler  <lforschler@apple.com>
3504
3505         Add webkit slave.
3506
3507         Unreviewed.
3508
3509         * BuildSlaveSupport/build.webkit.org-config/config.json:
3510
3511 2013-11-14  Tim Horton  <timothy_horton@apple.com>
3512
3513         build.webkit.org/dashboard can’t open different results in two new tabs
3514         https://bugs.webkit.org/show_bug.cgi?id=124383
3515
3516         Reviewed by Alexey Proskuryakov.
3517
3518         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3519         (BuildbotQueueView.prototype.revisionLinksForIteration):
3520         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js:
3521         (StatusLineView.prototype._clicked):
3522         Use _blank (which is effectively open-in-new-tab, in Safari) instead of _new (which isn't a
3523         real pseudo-target and instead acts as a named target and will end up causing all link clicks
3524         to open in the same secondary tab).
3525
3526 2013-11-14  Anders Carlsson  <andersca@apple.com>
3527
3528         Remove duplicate entry.
3529
3530         * Scripts/webkitpy/common/config/contributors.json:
3531
3532 2013-11-14  Krzysztof Czech  <k.czech@samsung.com>
3533
3534         [ATK] Change WKTR/DRT AX methods to use nullptr 
3535         https://bugs.webkit.org/show_bug.cgi?id=124352
3536
3537         Reviewed by Anders Carlsson.
3538
3539         Change WKTR/DRT accessibility related methods to use nullptr.
3540
3541         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
3542         (AccessibilityController::AccessibilityController):
3543         (AccessibilityController::elementAtPoint):
3544         (AccessibilityController::removeNotificationListener):
3545         (AccessibilityController::childElementById):
3546         * DumpRenderTree/atk/AccessibilityNotificationHandlerAtk.cpp:
3547         (AccessibilityNotificationHandler::AccessibilityNotificationHandler):
3548         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3549         (AccessibilityUIElement::elementAtPoint):
3550         (AccessibilityUIElement::linkedUIElementAtIndex):
3551         (AccessibilityUIElement::getChildAtIndex):
3552         (AccessibilityUIElement::titleUIElement):
3553         (AccessibilityUIElement::parentElement):
3554         (AccessibilityUIElement::subrole):
3555         (AccessibilityUIElement::roleDescription):
3556         (AccessibilityUIElement::orientation):
3557         (AccessibilityUIElement::ariaDropEffects):
3558         (AccessibilityUIElement::uiElementForSearchPredicate):
3559         (AccessibilityUIElement::cellForColumnAndRow):
3560         (AccessibilityUIElement::disclosedRowAtIndex):
3561         (AccessibilityUIElement::ariaOwnsElementAtIndex):
3562         (AccessibilityUIElement::ariaFlowToElementAtIndex):
3563         (AccessibilityUIElement::selectedRowAtIndex):
3564         (AccessibilityUIElement::rowAtIndex):
3565         (AccessibilityUIElement::disclosedByRow):
3566         (AccessibilityUIElement::removeNotificationListener):
3567         (AccessibilityUIElement::classList):
3568         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
3569         (WTR::AccessibilityController::logAccessibilityEvents):
3570         (WTR::AccessibilityController::resetToConsistentState):
3571         (WTR::childElementById):
3572         (WTR::AccessibilityController::accessibleElementById):
3573         (WTR::AccessibilityController::removeNotificationListener):
3574         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
3575         (WTR::AccessibilityNotificationHandler::setNotificationFunctionCallback):
3576         (WTR::AccessibilityNotificationHandler::removeAccessibilityNotificationHandler):
3577         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3578         (WTR::AccessibilityUIElement::elementAtPoint):
3579         (WTR::AccessibilityUIElement::childAtIndex):
3580         (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
3581         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
3582         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
3583         (WTR::AccessibilityUIElement::disclosedRowAtIndex):
3584         (WTR::AccessibilityUIElement::rowAtIndex):
3585         (WTR::AccessibilityUIElement::selectedChildAtIndex):
3586         (WTR::AccessibilityUIElement::selectedRowAtIndex):
3587         (WTR::AccessibilityUIElement::titleUIElement):
3588         (WTR::AccessibilityUIElement::parentElement):
3589         (WTR::AccessibilityUIElement::disclosedByRow):
3590         (WTR::AccessibilityUIElement::uiElementAttributeValue):
3591         (WTR::AccessibilityUIElement::orientation):
3592         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
3593         (WTR::AccessibilityUIElement::cellForColumnAndRow):
3594         (WTR::AccessibilityUIElement::horizontalScrollbar):
3595         (WTR::AccessibilityUIElement::verticalScrollbar):
3596         (WTR::AccessibilityUIElement::removeNotificationListener):
3597         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
3598         (WTR::AccessibilityUIElement::previousTextMarker):
3599         (WTR::AccessibilityUIElement::nextTextMarker):
3600         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
3601         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
3602         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
3603         (WTR::AccessibilityUIElement::endTextMarkerForBounds):
3604         (WTR::AccessibilityUIElement::startTextMarkerForBounds):
3605         (WTR::AccessibilityUIElement::textMarkerForPoint):
3606         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
3607         (WTR::AccessibilityUIElement::textMarkerForIndex):
3608         (WTR::AccessibilityUIElement::supportedActions):
3609         (WTR::AccessibilityUIElement::pathDescription):
3610         (WTR::AccessibilityUIElement::mathPostscriptsDescription):
3611         (WTR::AccessibilityUIElement::mathPrescriptsDescription):
3612         (WTR::AccessibilityUIElement::classList):
3613
3614 2013-11-14  Éva Balázsfalvi  <balazsfalvi.eva@stud.u-szeged.hu>
3615
3616         run-perf-tests should warn loudly if you're using a Debug build.
3617         https://bugs.webkit.org/show_bug.cgi?id=105236
3618
3619         Reviewed by Csaba Osztrogonác.
3620
3621         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3622         (PerfTestsRunner.run):
3623
3624 2013-11-14  Éva Balázsfalvi  <balazsfalvi.eva@stud.u-szeged.hu>
3625
3626         Fix Tools/Scripts/webkitpy/port/factory.py --help to display which configuration is default
3627         https://bugs.webkit.org/show_bug.cgi?id=124143
3628
3629         Reviewed by Csaba Osztrogonác.
3630
3631         * Scripts/webkitpy/port/factory.py:
3632         (configuration_options):
3633
3634 2013-11-13  Anders Carlsson  <andersca@apple.com>
3635
3636         Add a Vector constructor that takes an std::initializer_list
3637         https://bugs.webkit.org/show_bug.cgi?id=124287
3638
3639         Reviewed by Antti Koivisto.
3640
3641         * TestWebKitAPI/Tests/WTF/Vector.cpp:
3642         (TestWebKitAPI::TEST):
3643
3644 2013-11-13  Mario Sanchez Prada  <mario.prada@samsung.com>
3645
3646         Unreviewed GTK gardening. Updated rebaseline unit tests to include WK2 bot.
3647
3648         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3649         (TestRebaselineTest.test_baseline_directory): Updated.
3650
3651 2013-11-13  Krzysztof Czech  <k.czech@samsung.com>
3652
3653         [ATK] Support compilation of EFL/GTK without accessibility
3654         https://bugs.webkit.org/show_bug.cgi?id=122448
3655
3656         Reviewed by Chris Fleizach.
3657
3658         Added missing HAVE(ACCESSIBILITY) guards and stubs to ATK's related files,
3659         so that in case of turning off the HAVE_ACCESSIBILITY macro EFL/GTK would compile properly.
3660
3661         * DumpRenderTree/AccessibilityController.h:
3662         * DumpRenderTree/AccessibilityUIElement.h:
3663         * DumpRenderTree/atk/AccessibilityCallbacks.h:
3664         * DumpRenderTree/atk/AccessibilityNotificationHandlerAtk.cpp:
3665         * DumpRenderTree/atk/AccessibilityNotificationHandlerAtk.h:
3666         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
3667         (WTR::AccessibilityController::rootElement):
3668         (WTR::AccessibilityController::focusedElement):
3669         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3670         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
3671         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
3672         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.h:
3673         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3674         * WebKitTestRunner/PlatformEfl.cmake:
3675
3676 2013-11-12  Ryuan Choi  <ryuan.choi@samsung.com>
3677
3678         [EFL] Added libxss-dev to install-dependencies
3679         https://bugs.webkit.org/show_bug.cgi?id=124254
3680
3681         Reviewed by Gyuyoung Kim.
3682
3683         libxss-dev is required to build EFL packages.
3684         see building part in http://www.enlightenment.org/p.php?p=contribute
3685
3686         * efl/install-dependencies: Added libxss-dev to parameter of apt-get command.
3687
3688 2013-11-12  Tim Horton  <timothy_horton@apple.com>
3689
3690         After http://trac.webkit.org/changeset/159109, update
3691         rebaseline_unittest to use the new GTK bot names.
3692
3693         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3694         (TestRebaselineTest.test_baseline_directory):
3695
3696 2013-11-12  Denis Nomiyama  <d.nomiyama@samsung.com>
3697
3698         [GTK] Update GTK builders in Tools/Scripts/webkitpy/port/builders.py
3699         https://bugs.webkit.org/show_bug.cgi?id=124144
3700
3701         Reviewed by Gustavo Noronha Silva.
3702
3703         Updated the list of GTK builders in Tools/Scripts/webkitpy/port/builders.py
3704         according to http://build.webkit.org/builders.
3705
3706         * Scripts/webkitpy/port/builders.py:
3707
3708 2013-11-11  Samuel White  <samuel_white@apple.com>
3709
3710         AX: support helpText() in DumpRenderTree
3711         https://bugs.webkit.org/show_bug.cgi?id=40194
3712
3713         Reviewed by Chris Fleizach.
3714
3715         Implemented stubbed helpText methods so we can move aria-help.html back to LayoutTests/accessibility.
3716
3717         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3718         (AccessibilityUIElement::helpText):
3719
3720 2013-11-11  Anders Carlsson  <andersca@apple.com>
3721
3722         Remove block based APIs from the WebKit2 C API
3723         https://bugs.webkit.org/show_bug.cgi?id=124157
3724
3725         Reviewed by Sam Weinig.
3726
3727         Update for WK2 changes.
3728
3729         * MiniBrowser/mac/WK2BrowserWindowController.m:
3730         (dumpSource):
3731         (-[WK2BrowserWindowController dumpSourceToConsole:]):
3732
3733 2013-11-11  Tamas Gergely  <gertom@inf.u-szeged.hu>
3734
3735         The feeder queue will not feed patches older than one week.
3736         https://bugs.webkit.org/show_bug.cgi?id=107152
3737
3738         Reviewed by Csaba Osztrogonác.
3739
3740         The feeder queue will not feed patches older than one week.
3741         Unit test added to this scenario.
3742
3743         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3744         (BugzillaQueries._parse_attachment_ids_request_query):
3745           Handle date parameter.
3746         (BugzillaQueries):
3747         (BugzillaQueries._fetch_attachment_ids_request_query):
3748           Propagate date.
3749         (BugzillaQueries.fetch_attachment_ids_from_review_queue):
3750           Propagate date.
3751         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
3752         (MockBugzillaQueries.fetch_attachment_ids_from_review_queue):
3753           Handle date.
3754         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
3755         (test_request_page_parsing):
3756           Unit test added.
3757         * Scripts/webkitpy/tool/bot/feeders.py:
3758         (EWSFeeder.feed):
3759           Query patch ids with date parameter (now - 1 week).
3760
3761 2013-11-11  Tamas Gergely  <gertom@inf.u-szeged.hu>
3762
3763         Do not shut down ImageDiff server after every diff during the tests.
3764         https://bugs.webkit.org/show_bug.cgi?id=124140
3765
3766         Reviewed by Csaba Osztrogonác.
3767
3768         There was a FIXME: There is no need to shut down the ImageDiff
3769         server after every diff. Shutdown is removed from that point.
3770
3771         * Scripts/webkitpy/port/image_diff.py:
3772         (ImageDiffer._read):
3773
3774 2013-11-08  Matthew Hanson  <matthew_hanson@apple.com>
3775
3776         Unreviewed. Added myself as a contributor.
3777
3778         * Scripts/webkitpy/common/config/contributors.json:
3779
3780 2013-11-08  Krzysztof Czech  <k.czech@samsung.com>
3781
3782         [GTK] accessibility/aria-link-supports-press.html is failing
3783         https://bugs.webkit.org/show_bug.cgi?id=98355
3784
3785         Reviewed by Mario Sanchez Prada.
3786
3787         Checking "jump" action for link elements. Action "jump" occurs when a link 
3788         element is pressed/clicked.
3789
3790         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3791         (AccessibilityUIElement::isPressActionSupported):
3792         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3793         (WTR::AccessibilityUIElement::isPressActionSupported):
3794
3795 2013-11-08  Przemyslaw Szymanski  <p.szymanski3@samsung.com>
3796
3797         [JHBUILD] Jhbuild Makefile build bug workaround
3798         https://bugs.webkit.org/show_bug.cgi?id=123971
3799
3800         Reviewed by Ryosuke Niwa.
3801
3802         After Jhbuild repository is cloned (for instance when you use
3803         Tools/Scripts/update-webkitefl-libs) it is built from sources.
3804         If you have GREP_OPTIONS grep env variable set (for instance
3805         GREP_OPTIONS=-n) then it is jhbuild build error. Makefile.plain
3806         uses shell grep. For specific GREP_OPTIONS grep output will be
3807         different than expected one by Jhbuild and there is an error
3808         with Jhbuild build. Jhbuild will not be built and then WebKit
3809         source also will not be built. This patch is a workaround to this
3810         issue. It disables GREP_OPTIONS for Jhbuild build time.
3811
3812         * jhbuild/jhbuild-wrapper:
3813         (install_jhbuild):
3814
3815 2013-11-08  Carlos Garcia Campos  <cgarcia@igalia.com>
3816
3817         [GTK] Ignore deprecated macros when generating gtk-doc
3818         https://bugs.webkit.org/show_bug.cgi?id=123988
3819
3820         Reviewed by Philippe Normand.
3821
3822         * gtk/generate-gtkdoc:
3823         (get_common_options): Ignore also WEBKIT_DEPRECATED and
3824         WEBKIT_DEPRECATED_FOR decorators.
3825
3826 2013-11-08  Carlos Garcia Campos  <cgarcia@igalia.com>
3827
3828         [GTK] Pass the library namespace to gtkdoc-mkdb
3829         https://bugs.webkit.org/show_bug.cgi?id=123900
3830
3831         Reviewed by Martin Robinson.
3832
3833         This fixes the generation of the index of symbols in the API
3834         documentation.
3835
3836         * gtk/generate-gtkdoc:
3837         (get_webkit2_options): Define namespace as WebKit.
3838         (get_webkit1_options): Ditto.
3839         (get_webkitdom_options): Define namespace as WebKitDOM.
3840         * gtk/gtkdoc.py:
3841         (GTKDoc.__init__): Add namespace option.
3842         (GTKDoc._run_gtkdoc_mkdb): Pass namespace to mkdb if present.
3843
3844 2013-11-07  Chris Fleizach  <cfleizach@apple.com>
3845
3846         Modify email order list for James Craig so his primary email is first.
3847
3848         * Scripts/webkitpy/common/config/contributors.json:
3849
3850 2013-11-07  Nick Diego Yamane  <nick.yamane@openbossa.org>
3851
3852         [Gtk] Disable LTO when building cairo
3853         https://bugs.webkit.org/show_bug.cgi?id=123954
3854
3855         Reviewed by Martin Robinson.
3856
3857         Cairo always uses LTO, when it detects compiler support.
3858         LTO is buggy in many/all versions of GCC and shouldn't be enabled by
3859         default. This patch disables LTO when building cairo library.
3860         - See: https://bugs.freedesktop.org/show_bug.cgi?id=60852
3861
3862         With gcc 4.7.3, for example, the build fails with the following message:
3863         'lto1: fatal error: LTO_tags out of range: Range is 0 to 361, value is 15872'
3864
3865         * gtk/jhbuild.modules:
3866
3867 2013-11-07  Samuel White  <samuel_white@apple.com>
3868
3869         AX: DRT AccessibilityUIElement::isFocused methods should be finished.
3870         https://bugs.webkit.org/show_bug.cgi?id=123774
3871
3872         Reviewed by Chris Fleizach.
3873
3874         Implemented AccessibilityUIElement::isFocused methods and removed FIXMEs.
3875
3876         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3877         (AccessibilityUIElement::isFocused):
3878         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3879         (WTR::AccessibilityUIElement::isFocused):
3880
3881 2013-11-07  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
3882
3883         Removed retrieveQMakespecVar function
3884         https://bugs.webkit.org/show_bug.cgi?id=123996
3885
3886         Reviewed by Csaba Osztrogonác.
3887
3888         * Scripts/webkitdirs.pm:
3889
3890 2013-11-07  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
3891
3892         Removed QMake related filters
3893         https://bugs.webkit.org/show_bug.cgi?id=123992
3894
3895         Reviewed by Csaba Osztrogonác.
3896
3897         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3898         (TestRebaseline.test_rebaseline):
3899         (TestRebaselineExpectations.test_rebaseline_expectations):
3900
3901 2013-11-07  Nick Diego Yamane  <nick.yamane@openbossa.org>
3902
3903         [Efl] Disable LTO when building cairo
3904         https://bugs.webkit.org/show_bug.cgi?id=123947
3905
3906         Reviewed by Gyuyoung Kim.
3907
3908         Cairo always uses LTO, when it detects compiler support.
3909         LTO is buggy in many/all versions of GCC and shouldn't be enabled by
3910         default. This patch disables LTO when building cairo library.
3911         - See: https://bugs.freedesktop.org/show_bug.cgi?id=60852
3912
3913         With gcc 4.7.3, for example, the build fails with the following message:
3914         'lto1: fatal error: LTO_tags out of range: Range is 0 to 361, value is 15872'
3915
3916         * efl/jhbuild.modules:
3917
3918 2013-11-07  Mario Sanchez Prada  <mario.prada@samsung.com>
3919
3920         AX: [ATK] Video and audio elements are not properly exposed
3921         https://bugs.webkit.org/show_bug.cgi?id=123894
3922
3923         Reviewed by Chris Fleizach.
3924
3925         Update DRT and WKTR to handle the ATK_ROLE_EMBEDDED role.
3926
3927         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp: Updated.
3928         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp: Updated.
3929
3930 2013-11-07  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
3931
3932         Change git_commit_from_svn_revision() to work in a pure git checkout
3933         https://bugs.webkit.org/show_bug.cgi?id=111668
3934
3935         Reviewed by Ryosuke Niwa.
3936
3937         * Scripts/webkitpy/common/checkout/scm/git.py:
3938         (Git.git_commit_from_svn_revision):
3939
3940 2013-11-06  Jer Noble  <jer.noble@apple.com>
3941
3942         Unreviewed webkitpy unit test fix; update baselines after r158765
3943
3944         * Scripts/webkitpy/port/win_unittest.py:
3945         (WinPortTest.test_baseline_search_path):
3946
3947 2013-11-06  Jer Noble  <jer.noble@apple.com>
3948
3949         [Win] run-webkit-tests on the win platform should fall back to mac-mountainlion, not mac-lion.
3950         https://bugs.webkit.org/show_bug.cgi?id=123905
3951
3952         Reviewed by Brent Fulgham.
3953
3954         Now that the mac-lion results have been removed, the win port should fall back to
3955         the mac-mountainlion results.
3956
3957         * Scripts/webkitpy/port/win.py:
3958         (WinPort.default_baseline_search_path):
3959
3960 2013-11-06  Anders Carlsson  <andersca@apple.com>
3961
3962         Fix a Mountain Lion test failure.
3963
3964         NSURLRequest doesn't conform to NSSecureCoding on Mountain Lion, so don't try to test encoding it.
3965
3966         * TestWebKitAPI/Tests/WebKit2ObjC/WKRemoteObjectRegistry.mm:
3967         (TestWebKitAPI::TEST):
3968
3969 2013-11-06  Krzysztof Czech  <k.czech@samsung.com>
3970
3971         [ATK] Implement tables-related attributesOf*() functions for AccessibilityUIElement
3972         https://bugs.webkit.org/show_bug.cgi?id=118969
3973
3974         Reviewed by Mario Sanchez Prada.
3975
3976         Added missing implementation of attributesOfColumnHeaders, attributesOfRowHeaders, attributesOfVisibleCells.
3977
3978         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3979         (AccessibilityUIElement::attributesOfChildren):
3980         (AccessibilityUIElement::attributesOfColumnHeaders):
3981         (AccessibilityUIElement::attributesOfRowHeaders):
3982         (AccessibilityUIElement::attributesOfVisibleCells):
3983         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3984         (WTR::AccessibilityUIElement::attributesOfChildren):
3985         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
3986         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
3987         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
3988
3989 2013-11-05  Benjamin Poulain  <benjamin@webkit.org>
3990
3991         [WK2] Add a WebKit2 API for Geolocation's highAccuracy
3992         https://bugs.webkit.org/show_bug.cgi?id=123786
3993
3994         Reviewed by Darin Adler.
3995
3996         Add basic testing for the Geolocation API (start, stop and change accuracy).
3997
3998         * TestWebKitAPI/GNUmakefile.am:
3999         * TestWebKitAPI/PlatformEfl.cmake:
4000         * TestWebKitAPI/PlatformGTK.cmake:
4001         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4002         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp: Added.
4003         (TestWebKitAPI::operator<<):
4004         (TestWebKitAPI::GeolocationStateTracker::~GeolocationStateTracker):
4005         (TestWebKitAPI::GeolocationStateTracker::eventsChanged):
4006         (TestWebKitAPI::GeolocationStateTracker::startUpdatingCallback):
4007         (TestWebKitAPI::GeolocationStateTracker::stopUpdatingCallback):
4008         (TestWebKitAPI::GeolocationStateTracker::setEnableHighAccuracyCallback):
4009         (TestWebKitAPI::decidePolicyForGeolocationPermissionRequestCallBack):
4010         (TestWebKitAPI::setupGeolocationProvider):
4011         (TestWebKitAPI::setupView):
4012         (TestWebKitAPI::GeolocationBasicStateTracker::GeolocationBasicStateTracker):
4013         (TestWebKitAPI::GeolocationBasicStateTracker::eventsChanged):
4014         (TestWebKitAPI::GeolocationBasicWithHighAccuracyStateTracker::GeolocationBasicWithHighAccuracyStateTracker):
4015         (TestWebKitAPI::GeolocationBasicWithHighAccuracyStateTracker::eventsChanged):
4016         (TestWebKitAPI::GeolocationTransitionToHighAccuracyStateTracker::GeolocationTransitionToHighAccuracyStateTracker):
4017         (TestWebKitAPI::GeolocationTransitionToHighAccuracyStateTracker::eventsChanged):
4018         (TestWebKitAPI::GeolocationTransitionToLowAccuracyStateTracker::GeolocationTransitionToLowAccuracyStateTracker):
4019         (TestWebKitAPI::GeolocationTransitionToLowAccuracyStateTracker::eventsChanged):
4020         (TestWebKitAPI::didFinishLoadForFrame):
4021         * TestWebKitAPI/Tests/WebKit2/geolocationGetCurrentPosition.html: Added.
4022         * TestWebKitAPI/Tests/WebKit2/geolocationGetCurrentPositionWithHighAccuracy.html: Added.
4023         * TestWebKitAPI/Tests/WebKit2/geolocationWatchPosition.html: Added.
4024         * TestWebKitAPI/Tests/WebKit2/geolocationWatchPositionWithHighAccuracy.html: Added.
4025         * WebKitTestRunner/GeolocationProviderMock.cpp:
4026         (WTR::GeolocationProviderMock::GeolocationProviderMock):
4027
4028 2013-11-05  Anders Carlsson  <andersca@apple.com>
4029
4030         Implement more NSCoder methods
4031         https://bugs.webkit.org/show_bug.cgi?id=123815
4032
4033         Reviewed by Dan Bernstein.
4034
4035         Add a method that takes an NSArray, an NSDictionary and an NSURLRequest.
4036
4037         * TestWebKitAPI/Tests/WebKit2ObjC/WKRemoteObjectRegistry.mm:
4038         (TestWebKitAPI::TEST):
4039         * TestWebKitAPI/Tests/mac/WKRemoteObjectRegistry_Bundle.mm:
4040         (-[BundleObject testMethodWithArray:dictionary:request:]):
4041         * TestWebKitAPI/Tests/mac/WKRemoteObjectRegistry_Shared.h:
4042
4043 2013-11-05  Filip Pizlo  <fpizlo@apple.com>
4044
4045         Update ReducedFTL
4046         https://bugs.webkit.org/show_bug.cgi?id=123805
4047
4048         Reviewed by Sam Weinig.
4049         
4050         - Make ReducedFTL build with debug info.
4051         
4052         - Give ReducedFTL a --loop mode that runs everything in a loop. Great for finding
4053           memory leaks and attaching a profiler.
4054         
4055         - Reorder the passes so that they match the FTL.
4056         
4057         - Make it possible to change the backend opt level and enable the fast isel.
4058
4059         * ReducedFTL/ReducedFTL.c:
4060         (usage):
4061         (roundUpSize):
4062         (mmAllocateCodeSection):
4063         (main):
4064         * ReducedFTL/build.sh:
4065
4066 2013-11-05  Chris Fleizach  <cfleizach@apple.com>
4067
4068         AX: switch DRT AX methods to use nullptr
4069         https://bugs.webkit.org/show_bug.cgi?id=123773
4070
4071         Reviewed by Andreas Kling.
4072
4073         Switch AX related code in DRT and WKTR to use nullptr.
4074
4075         * DumpRenderTree/AccessibilityUIElement.cpp:
4076         (AccessibilityUIElement::startTextMarker):
4077         (AccessibilityUIElement::endTextMarker):
4078         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
4079         (findAccessibleObjectById):
4080         (AccessibilityController::accessibleElementById):
4081         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
4082         (AccessibilityUIElement::getChildAtIndex):
4083         (AccessibilityUIElement::linkedUIElementAtIndex):
4084         (AccessibilityUIElement::ariaOwnsElementAtIndex):
4085         (AccessibilityUIElement::ariaFlowToElementAtIndex):
4086         (AccessibilityUIElement::disclosedRowAtIndex):
4087         (AccessibilityUIElement::selectedChildAtIndex):
4088         (AccessibilityUIElement::selectedRowAtIndex):
4089         (AccessibilityUIElement::rowAtIndex):
4090         (AccessibilityUIElement::titleUIElement):
4091         (AccessibilityUIElement::parentElement):
4092         (AccessibilityUIElement::disclosedByRow):
4093         (AccessibilityUIElement::stringAttributeValue):
4094         (AccessibilityUIElement::uiElementAttributeValue):
4095         (AccessibilityUIElement::role):
4096         (AccessibilityUIElement::subrole):
4097         (AccessibilityUIElement::roleDescription):
4098         (AccessibilityUIElement::title):
4099         (AccessibilityUIElement::description):
4100         (AccessibilityUIElement::orientation):
4101         (AccessibilityUIElement::stringValue):
4102         (AccessibilityUIElement::language):
4103         (AccessibilityUIElement::helpText):
4104         (AccessibilityUIElement::valueDescription):
4105         (AccessibilityUIElement::speak):
4106         (AccessibilityUIElement::classList):
4107         (AccessibilityUIElement::ariaDropEffects):
4108         (AccessibilityUIElement::rangeForLine):
4109         (AccessibilityUIElement::rangeForPosition):
4110         (AccessibilityUIElement::boundsForRange):
4111         (AccessibilityUIElement::stringForRange):
4112         (AccessibilityUIElement::attributedStringForRange):
4113         (AccessibilityUIElement::uiElementForSearchPredicate):
4114         (AccessibilityUIElement::attributesOfColumnHeaders):
4115         (AccessibilityUIElement::attributesOfRowHeaders):
4116         (AccessibilityUIElement::attributesOfColumns):
4117         (AccessibilityUIElement::attributesOfRows):
4118         (AccessibilityUIElement::attributesOfVisibleCells):
4119         (AccessibilityUIElement::attributesOfHeader):
4120         (AccessibilityUIElement::rowIndexRange):
4121         (AccessibilityUIElement::columnIndexRange):
4122         (AccessibilityUIElement::cellForColumnAndRow):
4123         (AccessibilityUIElement::horizontalScrollbar):
4124         (AccessibilityUIElement::verticalScrollbar):
4125         (AccessibilityUIElement::pathDescription):
4126         (AccessibilityUIElement::selectedTextRange):
4127         (AccessibilityUIElement::url):
4128         (AccessibilityUIElement::textMarkerRangeForElement):
4129         (AccessibilityUIElement::textMarkerForIndex):
4130         (AccessibilityUIElement::previousTextMarker):
4131         (AccessibilityUIElement::nextTextMarker):
4132         (AccessibilityUIElement::stringForTextMarkerRange):
4133         (AccessibilityUIElement::textMarkerRangeForMarkers):
4134         (AccessibilityUIElement::startTextMarkerForTextMarkerRange):
4135         (AccessibilityUIElement::endTextMarkerForTextMarkerRange):
4136         (AccessibilityUIElement::endTextMarkerForBounds):
4137         (AccessibilityUIElement::startTextMarkerForBounds):
4138         (AccessibilityUIElement::textMarkerForPoint):
4139         (AccessibilityUIElement::accessibilityElementForTextMarker):
4140         (AccessibilityUIElement::startTextMarker):
4141         (AccessibilityUIElement::endTextMarker):
4142         (AccessibilityUIElement::supportedActions):
4143         (AccessibilityUIElement::mathPostscriptsDescription):
4144         (AccessibilityUIElement::mathPrescriptsDescription):
4145         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
4146         (WTR::AccessibilityController::accessibleElementById):
4147         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
4148         (WTR::AccessibilityUIElement::startTextMarker):
4149         (WTR::AccessibilityUIElement::endTextMarker):
4150         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
4151         (WTR::findAccessibleObjectById):
4152         (WTR::AccessibilityController::accessibleElementById):
4153         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
4154         (WTR::AccessibilityUIElement::childAtIndex):
4155         (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
4156         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
4157         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
4158         (WTR::AccessibilityUIElement::disclosedRowAtIndex):
4159         (WTR::AccessibilityUIElement::rowAtIndex):
4160         (WTR::AccessibilityUIElement::selectedChildAtIndex):
4161         (WTR::AccessibilityUIElement::selectedRowAtIndex):
4162         (WTR::AccessibilityUIElement::titleUIElement):
4163         (WTR::AccessibilityUIElement::parentElement):
4164         (WTR::AccessibilityUIElement::disclosedByRow):
4165         (WTR::AccessibilityUIElement::stringAttributeValue):
4166         (WTR::AccessibilityUIElement::uiElementAttributeValue):
4167         (WTR::AccessibilityUIElement::role):
4168         (WTR::AccessibilityUIElement::subrole):
4169         (WTR::AccessibilityUIElement::roleDescription):
4170         (WTR::AccessibilityUIElement::title):
4171         (WTR::AccessibilityUIElement::description):
4172         (WTR::AccessibilityUIElement::orientation):
4173         (WTR::AccessibilityUIElement::stringValue):
4174         (WTR::AccessibilityUIElement::language):
4175         (WTR::AccessibilityUIElement::helpText):
4176         (WTR::AccessibilityUIElement::valueDescription):
4177         (WTR::AccessibilityUIElement::classList):
4178         (WTR::AccessibilityUIElement::speak):
4179         (WTR::AccessibilityUIElement::ariaDropEffects):
4180         (WTR::AccessibilityUIElement::rangeForLine):
4181         (WTR::AccessibilityUIElement::rangeForPosition):
4182         (WTR::AccessibilityUIElement::boundsForRange):
4183         (WTR::AccessibilityUIElement::stringForRange):
4184         (WTR::AccessibilityUIElement::attributedStringForRange):
4185         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
4186         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
4187         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
4188         (WTR::AccessibilityUIElement::attributesOfColumns):
4189         (WTR::AccessibilityUIElement::attributesOfRows):
4190         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
4191         (WTR::AccessibilityUIElement::attributesOfHeader):
4192         (WTR::AccessibilityUIElement::rowIndexRange):
4193         (WTR::AccessibilityUIElement::columnIndexRange):
4194         (WTR::AccessibilityUIElement::cellForColumnAndRow):
4195         (WTR::AccessibilityUIElement::horizontalScrollbar):
4196         (WTR::AccessibilityUIElement::verticalScrollbar):
4197         (WTR::AccessibilityUIElement::selectedTextRange):
4198         (WTR::AccessibilityUIElement::url):
4199         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
4200         (WTR::AccessibilityUIElement::previousTextMarker):
4201         (WTR::AccessibilityUIElement::nextTextMarker):
4202         (WTR::AccessibilityUIElement::stringForTextMarkerRange):
4203         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
4204         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
4205         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
4206         (WTR::AccessibilityUIElement::endTextMarkerForBounds):
4207         (WTR::AccessibilityUIElement::startTextMarkerForBounds):
4208         (WTR::AccessibilityUIElement::textMarkerForPoint):
4209         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
4210         (WTR::AccessibilityUIElement::textMarkerForIndex):
4211         (WTR::AccessibilityUIElement::startTextMarker):
4212         (WTR::AccessibilityUIElement::endTextMarker):
4213         (WTR::AccessibilityUIElement::mathPostscriptsDescription):
4214         (WTR::AccessibilityUIElement::mathPrescriptsDescription):
4215         (WTR::AccessibilityUIElement::pathDescription):
4216         (WTR::AccessibilityUIElement::supportedActions):
4217
4218 2013-11-05  László Langó  <laszlo.lango@frontendart.com>
4219
4220         Remove leftover Qt related things from the flakiness_dashboard
4221         https://bugs.webkit.org/show_bug.cgi?id=123800
4222
4223         Reviewed by Anders Carlsson.
4224
4225         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
4226         (test):
4227
4228 2013-11-05  Robert Plociennik  <r.plociennik@samsung.com>
4229
4230         [EFL] accessibility/svg-group-element-with-title.html is failing
4231         https://bugs.webkit.org/show_bug.cgi?id=114151
4232
4233         Reviewed by Mario Sanchez Prada.
4234
4235         atk_component_ref_accessible_at_point(), utilized in
4236         AccessibilityUIElement::elementAtPoint(), is expected to 'get a reference to the
4237         accessible child, if one exists, at the coordinate point specified' and not
4238         explicitly return self in case of lack of child elements. This contradicts with
4239         expected behavior of elementAtPoint(). Therefore, elementAtPoint() is
4240         changed to return self regardless of coordinates specified, provided no child
4241         element could be retrieved, effectively mimicing the behaviour of equivalent
4242         Mac implementation in accessibilityHitTest().
4243
4244         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
4245         (AccessibilityUIElement::elementAtPoint): Fixed.
4246         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
4247         (WTR::AccessibilityUIElement::elementAtPoint): Fixed.
4248
4249 2013-11-05  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
4250
4251         [CSS] Enable css-image-orientation on EFL and GTK ports.
4252         https://bugs.webkit.org/show_bug.cgi?id=123698
4253
4254         Reviewed by Beth Dakin.
4255
4256         r157909 added wrong early return for css-image-orientation. It causes about 20 regressions in layout test
4257         when enabling css-image-orientaiton. This fixes those wrong implementation as well as enables it on EFL
4258         and GTK ports by default.
4259
4260         * Scripts/webkitperl/FeatureList.pm:
4261
4262 2013-11-04  Alexey Proskuryakov  <ap@apple.com>
4263
4264         DumpRenderTree should reset its preferences file on launch
4265         https://bugs.webkit.org/show_bug.cgi?id=29751
4266
4267         Reviewed by Dan Bernstein.
4268
4269         Using NSArgumentDomain was not a good idea. While it works with NSUserDefaults
4270         and CFPreferencesCopyAppValue family of functions, it doesn't work with
4271         CFPreferencesCopyValue(..., kCFPreferencesCurrentApplication, ...).
4272
4273         So, now we'll just set defaults in the current application.
4274
4275         * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
4276         - Delete the defaults.
4277         - Removed CFPreferencesSetAppValue calls, as -setValuesForKeysWithDictionary: does the same.
4278         - The comment about [NSUserDefaults standardUserDefaults] indirectly initializing NSApplication was incorrect.
4279
4280         * WebKitTestRunner/mac/main.mm: (setDefaultsToConsistentValuesForTesting):
4281         Switched to -setValuesForKeysWithDictionary for consistency.
4282
4283 2013-11-04  Filip Pizlo  <fpizlo@apple.com>
4284
4285         Running FTL tests shouldn't reduce coverage on DFG tests
4286         https://bugs.webkit.org/show_bug.cgi?id=123780
4287
4288         Reviewed by Geoffrey Garen.
4289
4290         * Scripts/run-jsc-stress-tests:
4291
4292 2013-11-04  Anders Carlsson  <andersca@apple.com>
4293
4294         More WKRemoteObjectRegistry work
4295         https://bugs.webkit.org/show_bug.cgi?id=123754
4296
4297         Reviewed by Dan Bernstein.
4298
4299         * TestWebKitAPI/Tests/WebKit2ObjC/WKRemoteObjectRegistry.mm:
4300         (TestWebKitAPI::TEST):