Allow WebKit clients to specify a minimum effective width for layout.
[WebKit-https.git] / Tools / ChangeLog
1 2018-11-28  Yongjun Zhang  <yongjun_zhang@apple.com>
2
3         Allow WebKit clients to specify a minimum effective width for layout.
4         https://bugs.webkit.org/show_bug.cgi?id=191499
5         <rdar://problem/45362678>
6
7         Reviewed by Wenson Hsieh.
8
9         Allow UIScriptController to set WKWebView's minimum effective width with a new `setMinimumEffectiveWidth` method.
10
11         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
12         (WTR::UIScriptController::setMinimumEffectiveWidth):
13         * DumpRenderTree/mac/UIScriptControllerMac.mm:
14         (WTR::UIScriptController::setViewScale):
15         (WTR::UIScriptController::setMinimumEffectiveWidth):
16         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
17         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
18         (WTR::UIScriptController::setMinimumEffectiveWidth):
19         * TestRunnerShared/UIScriptContext/UIScriptController.h:
20         * WebKitTestRunner/UIScriptControllerCocoa.mm:
21         (WTR::UIScriptController::setMinimumEffectiveWidth):
22         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
23         (WTR::TestController::cocoaResetStateToConsistentValues):
24
25 2018-11-28  Lucas Forschler  <lforschler@apple.com>
26
27         Fix webkitbot hi command.
28         https://bugs.webkit.org/show_bug.cgi?id=192080
29
30         Reviewed by Alexey Proskuryakov.
31
32         * Scripts/webkitpy/tool/bot/irc_command.py:
33         (Hi.execute):
34
35 2018-11-28  Zalan Bujtas  <zalan@apple.com>
36
37         [LFC][Quirk] Use non-collapsed vertical margin values when the container is stretched to the size of the ICB.
38         https://bugs.webkit.org/show_bug.cgi?id=192078
39
40         Reviewed by Antti Koivisto.
41
42         * LayoutReloaded/misc/LFC-passing-tests.txt:
43
44 2018-11-28  Zalan Bujtas  <zalan@apple.com>
45
46         [LFC] Add support for quirk container's collapsing top margin in quirks mode.
47         https://bugs.webkit.org/show_bug.cgi?id=192070
48
49         Reviewed by Antti Koivisto.
50
51         * LayoutReloaded/misc/LFC-passing-tests.txt:
52
53 2018-11-28  Thibault Saunier  <tsaunier@igalia.com>
54
55         [WebRTC][GStreamer] Make sure to have the default microphone on the top of the list
56         https://bugs.webkit.org/show_bug.cgi?id=192026
57
58         Reviewed by Philippe Normand.
59
60         Otherwise we might end up picking a useless one in some applications
61         (not sure what those application do though).
62
63         GStreamer patch proposed as https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/merge_requests/34/diffs
64
65         * flatpak/org.webkit.CommonModules.yaml:
66         * gstreamer/jhbuild.modules:
67         * gstreamer/patches/gst-plugins-good-0014-pulse-Mark-default-devices-as-default.patch: Added.
68
69 2018-11-28  Tomas Popela  <tpopela@redhat.com>
70
71         [GTK] Silence compilation warnings in glib unittests
72         https://bugs.webkit.org/show_bug.cgi?id=192009
73
74         Reviewed by Michael Catanzaro.
75
76         Mark the destructor as virtual.
77
78         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
79         (Test::~Test):
80
81 2018-11-27  Mark Lam  <mark.lam@apple.com>
82
83         ENABLE_FAST_JIT_PERMISSIONS should be false for iosmac.
84         https://bugs.webkit.org/show_bug.cgi?id=192055
85         <rdar://problem/46288783>
86
87         Reviewed by Saam Barati.
88
89         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
90
91 2018-11-27  Alex Christensen  <achristensen@webkit.org>
92
93         Make synchronous IPC introduced in r237267 asynchronous
94         https://bugs.webkit.org/show_bug.cgi?id=190757
95
96         Reviewed by Chris Dumez.
97
98         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
99
100 2018-11-27  Jonathan Bedard  <jbedard@apple.com>
101
102         webkitpy: Add watchOS ports
103         https://bugs.webkit.org/show_bug.cgi?id=191974
104         <rdar://problem/46251051>
105
106         Reviewed by Aakash Jain.
107
108         * Scripts/webkitpy/port/factory.py:
109         (PortFactory): Add WatchDevice and WatchSimulator ports.
110         * Scripts/webkitpy/port/watch.py: Added.
111         (WatchPort): Base class for watchOS ports.
112         * Scripts/webkitpy/port/watch_device.py: Added.
113         (WatchDevicePort): Class for running layout tests on a watchOS device.
114         * Scripts/webkitpy/port/watch_simulator.py: Added.
115         (WatchSimulatorPort): Class for running layout tests on a watchOS simulator.
116         * Scripts/webkitpy/port/watch_simulator_unittest.py: Added.
117         (WatchSimulatorTest):
118         * Scripts/webkitpy/port/watch_testcase.py: Added.
119         (WatchTest):
120
121 2018-11-27  Alex Christensen  <achristensen@webkit.org>
122
123         Safe browsing warning text needs to be visible on High Sierra
124         https://bugs.webkit.org/show_bug.cgi?id=192022
125
126         Reviewed by Tim Horton.
127
128         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
129         (TEST):
130
131 2018-11-27  Wenson Hsieh  <wenson_hsieh@apple.com>
132
133         Unreviewed, fix the watchOS engineering build
134
135         Disable a newly added API test, since DDScannerResult is unavailable on watchOS.
136
137         * TestWebKitAPI/Tests/WebKitCocoa/DataDetection.mm:
138
139 2018-11-27  Chris Dumez  <cdumez@apple.com>
140
141         Regression(PSON) crash under WebPageProxy::didReceiveServerRedirectForProvisionalLoadForFrame()
142         https://bugs.webkit.org/show_bug.cgi?id=191983
143         <rdar://problem/46246863>
144
145         Reviewed by Geoffrey Garen.
146
147         Add API test coverage.
148
149         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
150
151 2018-11-27  Aakash Jain  <aakash_jain@apple.com>
152
153         [ews-app] Add support to communicate with Buildbot (Follow-up fix)
154         https://bugs.webkit.org/show_bug.cgi?id=191935
155         <rdar://problem/46262314>
156
157         Unreviewed infrastructure fix.
158
159         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
160         (Buildbot.send_patch_to_buildbot):
161
162 2018-11-26  Wenson Hsieh  <wenson_hsieh@apple.com>
163
164         [Cocoa] No way for clients to tell whether the content view is in the responder chain when the web view is
165         https://bugs.webkit.org/show_bug.cgi?id=169212
166         <rdar://problem/30899656>
167
168         Reviewed by Tim Horton.
169
170         Add an API test to exercise the behavior of `-_contentViewIsFirstResponder` when an embedded text input becomes
171         and resigns first responder.
172
173         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
174         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewFirstResponderTests.mm: Added.
175         (-[FirstResponderTestingView initWithFrame:]):
176         (-[FirstResponderTestingView inputField]):
177         (TestWebKitAPI::TEST):
178
179 2018-11-26  Fujii Hironori  <Hironori.Fujii@sony.com>
180
181         [CMake] Remove ENABLE_ACCESSIBILITY CMake variable
182         https://bugs.webkit.org/show_bug.cgi?id=191831
183
184         Reviewed by Michael Catanzaro.
185
186         * WebKitTestRunner/CMakeLists.txt:
187
188 2018-11-26  Tim Horton  <timothy_horton@apple.com>
189
190         Insert <attachment> elements under editable images to make their backing data accessible
191         https://bugs.webkit.org/show_bug.cgi?id=191844
192         <rdar://problem/30900149>
193
194         Reviewed by Simon Fraser.
195
196         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
197         (WTR::UIScriptController::attachmentInfo):
198         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
199         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
200         (WTR::UIScriptController::attachmentInfo):
201         * TestRunnerShared/UIScriptContext/UIScriptController.h:
202         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
203         (WTR::UIScriptController::attachmentInfo):
204         Add a UIScriptController mechanism to retrieve information about
205         a given attachment.
206
207 2018-11-26  Aakash Jain  <aakash_jain@apple.com>
208
209         [ews-app] Add support to communicate with Buildbot
210         https://bugs.webkit.org/show_bug.cgi?id=191935
211
212         Reviewed by Lucas Forschler.
213
214         * BuildSlaveSupport/ews-app/ews/common/__init__.py: Added.
215         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Added.
216
217 2018-11-26  Jonathan Bedard  <jbedard@apple.com>
218
219         webkitpy: Race condition in ServerProcess tests
220         https://bugs.webkit.org/show_bug.cgi?id=191989
221         <rdar://problem/45536844>
222
223         Reviewed by Lucas Forschler.
224
225         Serializing these tests to prevent the race conditions.
226
227         * Scripts/webkitpy/port/server_process_unittest.py:
228         (TestServerProcess.serial_test_basic):
229         (TestServerProcess.serial_test_read_after_process_exits):
230         (TestServerProcess.serial_test_process_crashing):
231         (TestServerProcess.serial_test_process_crashing_no_data):
232         (TestServerProcess.test_basic): Deleted.
233         (TestServerProcess.test_read_after_process_exits): Deleted.
234         (TestServerProcess.test_process_crashing): Deleted.
235         (TestServerProcess.test_process_crashing_no_data): Deleted.
236
237 2018-11-26  Aakash Jain  <aakash_jain@apple.com>
238
239         [ews-app] Add field in Patch object to indicate if it has been sent to Buildbot
240         https://bugs.webkit.org/show_bug.cgi?id=191929
241
242         Reviewed by Lucas Forschler.
243
244         * BuildSlaveSupport/ews-app/ews/models/patch.py:
245         (Patch): Added sent_to_buildbot field.
246         (Patch.is_patch_sent_to_buildbot): Checks if the patch has been sent to Buildbot.
247
248 2018-11-26  Aakash Jain  <aakash_jain@apple.com>
249
250         [ews-app] Add a config file
251         https://bugs.webkit.org/show_bug.cgi?id=191933
252
253         Reviewed by Lucas Forschler.
254
255         * BuildSlaveSupport/ews-app/ews/config.py: Added.
256
257 2018-11-26  Aakash Jain  <aakash_jain@apple.com>
258
259         [ews-app] Add methods to save patch to database
260         https://bugs.webkit.org/show_bug.cgi?id=191928
261
262         Reviewed by Lucas Forschler.
263
264         * BuildSlaveSupport/ews-app/ews/models/patch.py:
265         (Patch.save_patch): Method to save the patch to database.
266         (Patch.save_patches): Method to save multiple patches to database.
267         (Patch.is_valid_patch_id): Checks if the patch id is valid.
268         (Patch.is_existing_patch_id): Checks if the patch id already exists in database.
269
270 2018-11-26  Alex Christensen  <achristensen@webkit.org>
271
272         Rename WKWebView._safeBrowsingWarningForTesting to _safeBrowsingWarning to use it for more than testing
273         https://bugs.webkit.org/show_bug.cgi?id=191981
274
275         Reviewed by Tim Horton.
276
277         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
278         (TEST):
279         (safeBrowsingView):
280
281 2018-11-26  Daniel Bates  <dabates@apple.com>
282
283         REGRESSION (r237738): Command Down Arrow doesn't scroll to the end of a page anymore
284         https://bugs.webkit.org/show_bug.cgi?id=191967
285         <rdar://problem/45976390>
286
287         Reviewed by Tim Horton.
288
289         Add more test infrastructure to dispatch key up events.
290
291         * WebKitTestRunner/ios/HIDEventGenerator.h:
292         * WebKitTestRunner/ios/HIDEventGenerator.mm:
293         (createHIDKeyEvent): Renamed from createHIDKeyDownEvent() and modified to take a boolean as
294         to whether to create an event for a key down or key up.
295         (createHIDKeyDownEvent): Deleted; renamed to createHIDKeyEvent().
296         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
297         (WTR::createUIPhysicalKeyboardEvent): Added. Convenience function to create a UIPhysicalKeyboardEvent.
298         (WTR::UIScriptController::keyDown): Modified to dispatch a key up event in addition to dispatching
299         a key down event.
300
301 2018-11-26  Aakash Jain  <aakash_jain@apple.com>
302
303         [ews-app] Set Foreign Keys in EWS Django app models
304         https://bugs.webkit.org/show_bug.cgi?id=191790
305
306         Reviewed by Lucas Forschler.
307
308         * BuildSlaveSupport/ews-app/ews/models/builds.py: Set Foreign Key.
309         * BuildSlaveSupport/ews-app/ews/models/steps.py: Ditto.
310
311 2018-11-26  Aakash Jain  <aakash_jain@apple.com>
312
313         [ews-app] Do not store patch content in database
314         https://bugs.webkit.org/show_bug.cgi?id=191788
315
316         Reviewed by Lucas Forschler.
317
318         * BuildSlaveSupport/ews-app/ews/models/patch.py: Removed content field.
319
320 2018-11-26  Jonathan Bedard  <jbedard@apple.com>
321
322         webkitpy: Retry app installation on watchOS simulators (Follow-up fix)
323         https://bugs.webkit.org/show_bug.cgi?id=191769
324         <rdar://problem/46139850>
325
326         Unreviewed infrastructure fix.
327
328         * Scripts/webkitpy/xcode/simulated_device.py:
329         (SimulatedDevice): Increase retry attempts.
330
331 2018-11-26  Daniel Bates  <dabates@apple.com>
332
333         Move testRunner.toggleCapsLock() to uiController
334         https://bugs.webkit.org/show_bug.cgi?id=191972
335
336         Reviewed by Tim Horton.
337
338         Move testRunner.toggleCapsLock() to uiController as uiController is the preferred JavaScript
339         object for UI test functions. Having this functionality be on uiController makes it an
340         asynchronous function naturally and complements use of onkeydown, onkeyup listeners to know
341         when the Caps Lock key event is dispatched. It also facilitates its use directly as part of
342         scripts with other uiController functions invocations that are passed in a single invocation
343         of testRunner.runUIScript().
344
345         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
346         (WTR::UIScriptController::toggleCapsLock):
347         * DumpRenderTree/mac/UIScriptControllerMac.mm:
348         (WTR::UIScriptController::toggleCapsLock):
349         Added stub functions that invoke the callback. We do not support toggling caps lock in Legacy
350         WebKit at the moment. Legacy WebKit reads the caps lock key state directly from the OS. Modern
351         WebKit caches the caps lock state in the WebProcess as a natural side effect of the fact that
352         the UIProcess is the only process capable of querying the caps lock key state from the OS and
353         hence the UIProcess must send over this state to the WebProcess.
354
355         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl: Add IDL for new function.
356         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
357         (WTR::UIScriptController::toggleCapsLock): Added empty implementation for ports non-Cocoa ports.
358         * TestRunnerShared/UIScriptContext/UIScriptController.h:
359
360         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
361         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
362         (WTR::TestRunner::toggleCapsLock): Deleted.
363         * WebKitTestRunner/InjectedBundle/TestRunner.h:
364         * WebKitTestRunner/TestController.h:
365         * WebKitTestRunner/TestInvocation.cpp:
366         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
367         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
368         (WTR::TestController::toggleCapsLock): Deleted; moved to UIScriptController::toggleCapsLock().
369         Removed logic to handle testRunner.toggleCapsLock().
370
371         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
372         (WTR::UIScriptController::toggleCapsLock): Add stub function that invokes the callback
373         and a FIXME comment that explains that we will implement this function in <https://bugs.webkit.org/show_bug.cgi?id=191815>.
374         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
375         (WTR::UIScriptController::toggleCapsLock): Moved the implementation from TestController::toggleCapsLock().
376
377 2018-11-26  Brent Fulgham  <bfulgham@apple.com>
378
379         [Win] Reduce the use of WKSI library calls: CoreAnimation
380         https://bugs.webkit.org/show_bug.cgi?id=191777
381         <rdar://problem/46140542>
382
383         Reviewed by Zalan Bujtas.
384
385         Update the Windows build of WebKit to refer to the SPI headers, rather than WebKitSystemInterface.
386         Move a small amount of glue code from WKSI to WebCore, and remove any includes or link
387         directives for WebKitSystemInterface.lib.
388
389         * TestWebKitAPI/PlatformWin.cmake:
390
391 2018-11-25  Zalan Bujtas  <zalan@apple.com>
392
393         [LFC][IFC] Use float box's margin box to adjust the line constraints.
394         https://bugs.webkit.org/show_bug.cgi?id=191961
395
396         Reviewed by Antti Koivisto.
397
398         * LayoutReloaded/misc/LFC-passing-tests.txt:
399
400 2018-11-25  Zalan Bujtas  <zalan@apple.com>
401
402         Unreviewed test fix after r238467.
403
404         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
405         (TestWebKitAPI::TEST):
406
407 2018-11-25  Wenson Hsieh  <wenson_hsieh@apple.com>
408
409         Unreviewed, fix the internal iOS 12 build after r238471
410
411         * TestWebKitAPI/Tests/WebKitCocoa/DataDetection.mm:
412         (TEST):
413
414 2018-11-25  Tim Horton  <timothy_horton@apple.com>
415
416         Make it possible to insert editable images with a gesture
417         https://bugs.webkit.org/show_bug.cgi?id=191937
418
419         Reviewed by Wenson Hsieh.
420
421         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
422         (WTR::UIScriptController::drawSquareInEditableImage):
423         If the canvas already has a drawing, draw a new stroke on top of it
424         instead of removing the existing stroke.
425
426 2018-11-24  Wenson Hsieh  <wenson_hsieh@apple.com>
427
428         [Cocoa] Add WKWebView SPI to trigger and remove data detection
429         https://bugs.webkit.org/show_bug.cgi?id=191918
430         <rdar://problem/36185051>
431
432         Reviewed by Tim Horton.
433
434         Add an API test to exercise the new WebKit SPI.
435
436         * TestWebKitAPI/DataDetectorsCoreSPI.h: Added.
437         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
438         * TestWebKitAPI/Tests/WebKitCocoa/DataDetection.mm:
439         (-[WKWebView synchronouslyDetectDataWithTypes:]):
440         (-[WKWebView synchronouslyRemoveDataDetectedLinks]):
441         (TEST):
442         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
443         (TestWebKitAPI::TEST):
444         (-[TestWKWebView tagsInBody]): Deleted.
445         (-[TestWKWebView expectElementTagsInOrder:]): Deleted.
446         (-[TestWKWebView expectElementCount:tagName:]): Deleted.
447         (-[TestWKWebView expectElementTag:toComeBefore:]): Deleted.
448
449         Rename this from `-expectElementCount:tagName:` to `-expectElementCount:querySelector:`.
450
451         * TestWebKitAPI/Tests/WebKitCocoa/data-detectors.html: Added.
452
453         Add a new test page containing some content that can be data detected.
454
455         * TestWebKitAPI/cocoa/TestWKWebView.h:
456         * TestWebKitAPI/cocoa/TestWKWebView.mm:
457         (-[WKWebView tagsInBody]):
458         (-[WKWebView expectElementTagsInOrder:]):
459         (-[WKWebView expectElementCount:querySelector:]):
460         (-[WKWebView expectElementTag:toComeBefore:]):
461
462         Move some testing helper functions from WKAttachmentTests to a testing category on WKWebView. This allows us to
463         use `-expectElementCount:querySelector:` in tests outside of WKAttachmentTests.
464
465         (-[WKWebView objectByEvaluatingJavaScript:]):
466         (-[WKWebView objectByEvaluatingJavaScriptWithUserGesture:]):
467         (-[WKWebView stringByEvaluatingJavaScript:]):
468
469         Move some common helper functions from TestWKWebView to a testing category on WKWebView.
470
471         (-[TestWKWebView objectByEvaluatingJavaScript:]): Deleted.
472         (-[TestWKWebView objectByEvaluatingJavaScriptWithUserGesture:]): Deleted.
473         (-[TestWKWebView stringByEvaluatingJavaScript:]): Deleted.
474
475 2018-11-23  Sam Weinig  <sam@webkit.org>
476
477         Add raw pointer overloads to ListHashSet via SmartPtr specialized functions
478         https://bugs.webkit.org/show_bug.cgi?id=191936
479
480         Reviewed by Zalan Bujtas.
481
482         Adds tests for raw pointer overloads in ListHashSet.
483
484         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
485         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
486
487 2018-11-23  Wenson Hsieh  <wenson_hsieh@apple.com>
488
489         Enable drag and drop support for iOSMac
490         https://bugs.webkit.org/show_bug.cgi?id=191818
491         <rdar://problem/43907454>
492
493         Reviewed by Dean Jackson.
494
495         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
496
497 2018-11-23  Zalan Bujtas  <zalan@apple.com>
498
499         [LFC][IFC] Add support for variable height runs.
500         https://bugs.webkit.org/show_bug.cgi?id=191925
501
502         Reviewed by Antti Koivisto.
503
504         * LayoutReloaded/misc/LFC-passing-tests.txt:
505
506 2018-11-23  Alberto Garcia  <berto@igalia.com>
507
508         [GTK] [WPE] Tools/Platform{GTK,WPE}.cmake files missing from the tarballs
509         https://bugs.webkit.org/show_bug.cgi?id=191923
510
511         Add Tools/PlatformGTK.cmake and Tools/PlatformWPE.cmake to their
512         respective tarballs.
513
514         Reviewed by Carlos Garcia Campos.
515
516         * gtk/manifest.txt.in:
517         * wpe/manifest.txt.in:
518
519 2018-11-22  Chris Dumez  <cdumez@apple.com>
520
521         Regression(r238353) Load sometimes hangs when navigating back after a cross-site navigation
522         https://bugs.webkit.org/show_bug.cgi?id=191914
523
524         Reviewed by Ryosuke Niwa.
525
526         Add API test coverage.
527
528         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
529
530 2018-11-22  Zalan Bujtas  <zalan@apple.com>
531
532         [LFC][IFC] Offset formatting context root runs with horizontal margins.
533         https://bugs.webkit.org/show_bug.cgi?id=191900
534
535         Reviewed by Antti Koivisto.
536
537         * LayoutReloaded/misc/LFC-passing-tests.txt:
538
539 2018-11-22  Philippe Normand  <pnormand@igalia.com>
540
541         [GTK] Remove unmaintained bots
542         https://bugs.webkit.org/show_bug.cgi?id=191467
543
544         Reviewed by Alex Christensen.
545
546         The Linux 32-bits and ARM build-slaves are no longer maintained
547         and have been failing for months, so get rid of them.
548
549         * BuildSlaveSupport/build.webkit.org-config/config.json:
550         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
551         (WebKitBuildbot):
552         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
553
554 2018-11-22  Thibault Saunier  <tsaunier@igalia.com>
555
556         [Flatpak] Do not disable signals when running "usual" commands
557         https://bugs.webkit.org/show_bug.cgi?id=190679
558
559         Reviewed by Philippe Normand.
560
561         Otherwise <ctr>c doesn't work while compiling. It is not the best fix
562         as there are cases we want to let only children receive signals, but
563         it is not clear how to determine when (when running gdb, we still
564         disable those).
565
566         * flatpak/flatpakutils.py:
567         (WebkitFlatpak.run_in_sandbox):
568
569 2018-11-21  Wenson Hsieh  <wenson_hsieh@apple.com>
570
571         [Cocoa] [WebKit2] Add support for replacing find-in-page text matches
572         https://bugs.webkit.org/show_bug.cgi?id=191786
573         <rdar://problem/45813871>
574
575         Reviewed by Ryosuke Niwa.
576
577         * MiniBrowser/mac/WK2BrowserWindowController.m:
578         (-[WK2BrowserWindowController setFindBarView:]):
579
580         Fix a bug in MiniBrowser that prevents AppKit from displaying the "All" button in the find bar after checking
581         the "Replace" option.
582
583         * TestWebKitAPI/Tests/WebKitCocoa/FindInPage.mm:
584
585         Add an API test to exercise find-and-replace API using WKWebView.
586
587         (replaceMatches):
588         (TEST):
589         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
590         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
591         (WTR::findOptionsFromArray):
592         (WTR::TestRunner::findString):
593         (WTR::TestRunner::findStringMatchesInPage):
594         (WTR::TestRunner::replaceFindMatchesAtIndices):
595
596         Add TestRunner hooks to simulate find-in-page and replace.
597
598         * WebKitTestRunner/InjectedBundle/TestRunner.h:
599
600 2018-11-21  Zalan Bujtas  <zalan@apple.com>
601
602         [LFC][IFC] Horizontal margins should be considered as non-breakable space
603         https://bugs.webkit.org/show_bug.cgi?id=191894
604
605         Reviewed by Antti Koivisto.
606
607         * LayoutReloaded/misc/LFC-passing-tests.txt:
608
609 2018-11-21  Zalan Bujtas  <zalan@apple.com>
610
611         [LFC][IFC] Border should be considered as non-breakable space
612         https://bugs.webkit.org/show_bug.cgi?id=191891
613
614         Reviewed by Antti Koivisto.
615
616         * LayoutReloaded/misc/LFC-passing-tests.txt:
617
618 2018-11-21  Zalan Bujtas  <zalan@apple.com>
619
620         [LFC][IFC] Take nonBreakableStart/End into use.
621         https://bugs.webkit.org/show_bug.cgi?id=191873
622
623         Reviewed by Antti Koivisto.
624
625         * LayoutReloaded/misc/LFC-passing-tests.txt:
626
627 2018-11-20  Jeff Miller  <jeffm@apple.com>
628
629         Return nullptr immediately if the key doesn't exist in the HashMap.
630         https://bugs.webkit.org/show_bug.cgi?id=191841
631
632         Reviewed by Chris Dumez.
633         
634         Add a test that would crash prior to the fix for this bug.
635
636         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
637         * TestWebKitAPI/Tests/WebKitCocoa/WKNSDictionaryEmptyDictionaryCrash.mm: Added.
638         (TestWebKitAPI::TEST):
639
640 2018-11-19  Alex Christensen  <achristensen@webkit.org>
641
642         Add SPI to disable JIT in a WKWebView
643         https://bugs.webkit.org/show_bug.cgi?id=191822
644         <rdar://problem/28119360>
645
646         Reviewed by Geoffrey Garen.
647
648         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
649         * TestWebKitAPI/Tests/WebKitCocoa/DisableJIT.mm: Added.
650         (TEST):
651
652 2018-11-19  Basuke Suzuki  <basuke.suzuki@sony.com>
653
654         [Curl] Add API for CertificateInfo.
655         https://bugs.webkit.org/show_bug.cgi?id=191647
656
657         Reviewed by Alex Christensen.
658
659         Added test for new WKCertificateInfo API.
660
661         * TestWebKitAPI/PlatformWin.cmake:
662         * TestWebKitAPI/Tests/WebKit/curl/Certificates.cpp: Added.
663         (TestWebKitAPI::Curl::makeCertificateInfo):
664         (TestWebKitAPI::Curl::isSamePEM):
665         (TestWebKitAPI::Curl::TEST):
666
667 2018-11-19  Wenson Hsieh  <wenson_hsieh@apple.com>
668
669         Unreviewed, fix the internal iOS debug build after r238380
670
671         UICalloutBar should only be declared when the public (non-internal) SDK is used to build WebKit; otherwise, we
672         end up with duplicate declarations of UICalloutBar.
673
674         * TestWebKitAPI/ios/UIKitSPI.h:
675
676 2018-11-19  David Quesada  <david_quesada@apple.com>
677
678         EXC_BAD_ACCESS when invoking a DownloadProxy's destination decision handler after the download has been canceled
679         https://bugs.webkit.org/show_bug.cgi?id=191762
680         rdar://problem/46151509
681
682         Reviewed by Dean Jackson.
683
684         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
685             Enable the Download API test on iOS, since the platform supports downloads. All the
686             tests pass already, except for one which was written using AppKit-specific code:
687         TEST(_WKDownload, RedirectedDownload):
688             Use a more platform-agnostic approach to starting the download in this API test.
689             Instead of manually triggering an NSMenu item to download a file from a link, the
690             test will simulate a user-initiated click on the link, and the navigation delegate
691             will direct the web view to start a download based on the link's navigation action.
692             Additionally, remove the manual creation of a new NSWindow. TestWKWebView makes its
693             own UI/NSWindow.
694         TEST(_WKDownload, DownloadCanceledWhileDecidingDestination):
695             Add an API test _WKDownload.DownloadCanceledWhileDecidingDestination to simulate the
696             conditions that would trigger this crash - handling a download's -decideDestination…
697             delegate call by canceling the download, waiting for the UI process to be notified
698             that the download has been canceled, and calling the decision handler. This should
699             not crash.
700         (-[CancelDownloadWhileDecidingDestinationDelegate _downloadDidFinish:]):
701         (-[CancelDownloadWhileDecidingDestinationDelegate _download:didFailWithError:]):
702         (-[CancelDownloadWhileDecidingDestinationDelegate _downloadDidCancel:]):
703         (-[CancelDownloadWhileDecidingDestinationDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
704         (-[UIDownloadAsFileTestDelegate _webView:contextMenu:forElement:]): Deleted.
705         * TestWebKitAPI/cocoa/TestWKWebView.h:
706         * TestWebKitAPI/cocoa/TestWKWebView.mm:
707         (-[TestWKWebView objectByEvaluatingJavaScriptWithUserGesture:]):
708             Add a user-initated version of -objectByEvaluatingJavaScript:. This is needed in
709             order to maintain the behavior of the RedirectedDownload test, which verifies the
710             state of the _WKDownload.wasUserInitiated property.
711
712 2018-11-19  Wenson Hsieh  <wenson_hsieh@apple.com>
713
714         [iOS Debug] Assertion failure in NSComparisonResult UIContentSizeCategoryCompareToCategory()
715         https://bugs.webkit.org/show_bug.cgi?id=190401
716         <rdar://problem/45195285>
717
718         Reviewed by Dean Jackson.
719
720         Work around sporadic UIKit assertions when running API tests that may present a UICalloutBar. Currently, UIKit
721         asks for the `UIApp`’s `-preferredContentSizeCategory` when showing or laying out the callout bar. However,
722         TestWebKitAPI lacks a UIApp altogether, and forcing one to be initialized via `UIApplicationInstantiateSingleton`
723         causes numerous other UIKit and WebKit assertions to be hit.
724
725         In lieu of TestWebKitAPI becoming a real UI application (see https://webkit.org/b/175204), simply don't allow
726         the callout bar to be initialized in TestWKWebView-based API tests. This encompasses all API tests which
727         have some chance of causing the callout bar to be shown by making a ranged text selections during the test.
728
729         * TestWebKitAPI/cocoa/TestWKWebView.mm:
730         (suppressUICalloutBar):
731         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
732         * TestWebKitAPI/ios/UIKitSPI.h:
733
734 2018-11-19  Fujii Hironori  <Hironori.Fujii@sony.com>
735
736         REGRESSION(r238016)[GTK][TestWebKitAPI][Ninja] TestJSC can't compile "Bytecodes.h: No such file or directory"
737         https://bugs.webkit.org/show_bug.cgi?id=191692
738
739         Reviewed by Michael Catanzaro.
740
741         r238016 added a new #include, and requires JSC's derived headers
742         to be copied into the forwarding header directory.
743
744         WEBKIT_MAKE_FORWARDING_HEADERS is using POST_BUILD event to copy
745         derived headers to the forwarding header directory. This is done
746         after linking JSC library.
747
748         GTK port has TestJSC which has a dependency to JSC static library.
749         And, this dependency is a link time dependency which means
750         compiling source files of TestJSC starts before the POST_BUILD
751         event of JSC. Thus, required header can't be found.
752
753         Add an intermediate target between TestJSC and JavaScriptCore to
754         ensure derived headers are copied into the forwarding header
755         directory.
756
757         * TestWebKitAPI/PlatformGTK.cmake: Added a new custom target pre-TestJSC.
758         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
759
760 2018-11-19  Alejandro G. Castro  <alex@igalia.com>
761
762         [GTK][WPE] Solve some issues in the enumerateDevices code
763         https://bugs.webkit.org/show_bug.cgi?id=191832
764
765         Reviewed by Carlos Garcia Campos.
766
767         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
768         (serverCallback): Make all the Strings with HTML code static.
769         (testWebsiteDataDeviceIdHashSalt): Change the webView settings in
770         the test.
771         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
772         (WebViewTest::initializeWebView): Remove the initialization of the
773         webView settings, we now do it in the specific test.
774
775 2018-11-18  Chris Dumez  <cdumez@apple.com>
776
777         [PSON] Received an invalid message "WebPageProxy.DidPerformClientRedirect" from the web process
778         https://bugs.webkit.org/show_bug.cgi?id=191828
779
780         Reviewed by Antti Koivisto.
781
782         Add API test coverage.
783
784         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
785         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
786         * TestWebKitAPI/Tests/WebKitCocoa/client-side-redirect.html: Added.
787
788 2018-11-17  Wenson Hsieh  <wenson_hsieh@apple.com>
789
790         [iOS] Remove all usages of UIItemProvider, UIItemProviderReading, and related classes
791         https://bugs.webkit.org/show_bug.cgi?id=191819
792
793         Reviewed by Dan Bernstein.
794
795         Replace UIItemProvider (and related classes) with NSItemProvider.
796
797         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
798         (platformCopyPNG):
799         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
800         (-[NSItemProvider registerDataRepresentationForTypeIdentifier:withData:]):
801
802         Replace usages of this deprecated method with `-registerDataRepresentationForTypeIdentifier:visibility:loadHandler:`.
803
804         (checkEstimatedSize):
805         (checkSuggestedNameAndEstimatedSize):
806         (TestWebKitAPI::TEST):
807         (-[UIItemProvider registerDataRepresentationForTypeIdentifier:withData:]): Deleted.
808         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
809         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
810         (-[MockDragDropSession canLoadObjectsOfClass:]):
811         (-[MockDragDropSession canLoadObjectsOfClasses:]):
812         (-[MockDropSession initWithProviders:location:window:allowMove:]):
813         (-[MockDropSession canCreateItemsOfClass:]):
814         (-[DragAndDropSimulator _advanceProgress]):
815         (-[DragAndDropSimulator _webView:dataInteractionOperationWasHandled:forSession:itemProviders:]):
816         (-[DragAndDropSimulator _webView:adjustedDataInteractionItemProvidersForItemProvider:representingObjects:additionalData:]):
817         * TestWebKitAPI/ios/UIKitSPI.h:
818
819 2018-11-17  Chris Dumez  <cdumez@apple.com>
820
821         ASSERTION FAILED: m_messageReceivers.contains(...) under ViewGestureController removeMessageReceiver
822         https://bugs.webkit.org/show_bug.cgi?id=191734
823         <rdar://problem/46151497>
824
825         Reviewed by Ryosuke Niwa.
826
827         Add API test coverage.
828
829         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
830
831 2018-11-17  Zalan Bujtas  <zalan@apple.com>
832
833         [LFC][IFC] InlineFormattingState::addDetachingRule should accumulate rules.
834         https://bugs.webkit.org/show_bug.cgi?id=191801
835
836         Reviewed by Antti Koivisto.
837
838         * LayoutReloaded/misc/LFC-passing-tests.txt:
839
840 2018-11-17  Jer Noble  <jer.noble@apple.com>
841
842         Regression(r233865): Causes synchronous IPC in the middle of layout
843         https://bugs.webkit.org/show_bug.cgi?id=188307
844         <rdar://problem/42807306>
845
846         Reviewed by Eric Carlson.
847
848         Follow-up test fix for r238322:
849
850         In ExitFullscreenOnEnterPiP.ElementFullScreen, explicitly make the video
851         element in element fullscreen the "main content" by playing the video during
852         a user gesture; only "main content" videos will cause fullscreen mode to exit
853         when that element is taken into PiP.
854
855         In FullscreenZoomInitialFrame.WebKit, the WebView is not visible, so the Page
856         is considered hidden, and fullscreen is not allowed when the WebView is hidden.
857         Make the WebView visible by ordering the test window on-screen.
858
859         * TestWebKitAPI/Tests/WebKitCocoa/ExitFullscreenOnEnterPiP.html:
860         * TestWebKitAPI/Tests/WebKitCocoa/ExitFullscreenOnEnterPiP.mm:
861         (TestWebKitAPI::TEST):
862         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
863         (TestWebKitAPI::FullscreenZoomInitialFrame::runTest):
864
865 2018-11-16  Alex Christensen  <achristensen@webkit.org>
866
867         Tweak _showSafeBrowsingWarningWithTitle SPI
868         https://bugs.webkit.org/show_bug.cgi?id=191799
869
870         Reviewed by Wenson Hsieh.
871
872         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
873         (TEST):
874
875 2018-11-16  Ryosuke Niwa  <rniwa@webkit.org>
876
877         REGRESSION (r238294): TestWebKitAPI.WKNavigation.ProcessCrashDuringCallback failing on iOS
878         https://bugs.webkit.org/show_bug.cgi?id=191783
879
880         Reviewed by Chris Dumez.
881
882         Allow either WKErrorWebContentProcessTerminated or WKErrorWebViewInvalidated since the test
883         is closing WebView, thereby invalidating the view, which is racing with the process termination.
884
885         * TestWebKitAPI/Tests/WebKitCocoa/WebContentProcessDidTerminate.mm:
886         (TEST):
887
888 2018-11-16  Chris Dumez  <cdumez@apple.com>
889
890         ProcessSwap.DisableForInspector API test is failing
891         https://bugs.webkit.org/show_bug.cgi?id=191798
892
893         Reviewed by Joseph Pecoraro.
894
895         We support process swapping when Web Inspector is shown now so update the
896         API test accordingly.
897
898         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
899
900 2018-11-16  Ryan Haddad  <ryanhaddad@apple.com>
901
902         Update buildbot dashboard after Windows 7/10 updates
903         https://bugs.webkit.org/show_bug.cgi?id=191219
904
905         Reviewed by Alexey Proskuryakov.
906
907         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
908         (BubbleQueueServer):
909         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
910         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
911         (WebKitBuildbot):
912         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
913         (table.queue-grid tr.platform td.logo::before):
914         (table.queue-grid tr.platform.windows-10 td.logo::before):
915         (table.queue-grid tr.platform.wincairo-windows-10 td.logo::before):
916         (table.queue-grid tr.platform.windows-7 td.logo::before):
917         (table.queue-grid tr.platform.wincairo-windows-10 img.logo):
918
919 2018-11-16  Chris Dumez  <cdumez@apple.com>
920
921         Regression(PSON) WebKit.GeolocationTransitionToHighAccuracy API test is timing out
922         https://bugs.webkit.org/show_bug.cgi?id=191789
923
924         Reviewed by Alex Christensen.
925
926         Relate the 2 test pages so they use the same process since WKContextSetMaximumNumberOfProcesses()
927         SPI no longer works with PSON / Process prewarming.
928
929         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
930         (TestWebKitAPI::TEST):
931
932 2018-11-16  Jonathan Bedard  <jbedard@apple.com>
933
934         webkitpy: Retry app installation on watchOS simulators
935         https://bugs.webkit.org/show_bug.cgi?id=191769
936         <rdar://problem/46139850>
937
938         Reviewed by Aakash Jain.
939
940         * Scripts/webkitpy/xcode/simulated_device.py:
941         (SimulatedDevice.install_app): Retry app installations.
942
943 2018-11-16  Zalan Bujtas  <zalan@apple.com>
944
945         Add DidFirstMeaningfulPaint milestone.
946         https://bugs.webkit.org/show_bug.cgi?id=191754
947
948         Reviewed by Simon Fraser.
949
950         * TestWebKitAPI/CMakeLists.txt:
951         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
952         * TestWebKitAPI/Tests/WebKit/FirstMeaningfulPaintMilestone.cpp: Added.
953         (TestWebKitAPI::didReachMilestone):
954         (TestWebKitAPI::setPageLoaderClient):
955         (TestWebKitAPI::TEST):
956         * TestWebKitAPI/Tests/WebKit/FirstMeaningfulPaintMilestone_Bundle.cpp: Copied from Source/WebKit/UIProcess/API/C/WKPageRenderingProgressEvents.h.
957         (TestWebKitAPI::FirstMeaningfulPaintMilestoneTest::FirstMeaningfulPaintMilestoneTest):
958         (TestWebKitAPI::FirstMeaningfulPaintMilestoneTest::didCreatePage):
959
960 2018-11-16  Takashi Komori  <Takashi.Komori@sony.com>
961
962         [WinCairo][WebKitTestRunner] Test contents window is displayed while testing.
963         https://bugs.webkit.org/show_bug.cgi?id=191593
964
965         Reviewed by Alex Christensen.
966
967         Hide TestRunner window and taskbar button.
968
969         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
970         (WTR::PlatformWebView::PlatformWebView):
971         (WTR::PlatformWebView::windowSnapshotImage):
972
973 2018-11-16  Alex Christensen  <achristensen@webkit.org>
974
975         Add API to disable safe browsing checks
976         https://bugs.webkit.org/show_bug.cgi?id=191610
977
978         Reviewed by Dean Jackson.
979
980         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
981         (resourceURL):
982         (TEST):
983         (safeBrowsingView):
984         (simpleURL): Deleted.
985
986 2018-11-16  Zalan Bujtas  <zalan@apple.com>
987
988         [LFC][IFC] Add support for out-of-flow positioned boxes
989         https://bugs.webkit.org/show_bug.cgi?id=191726
990
991         Reviewed by Antti Koivisto.
992
993         * LayoutReloaded/misc/LFC-passing-tests.txt:
994
995 2018-11-15  Myles C. Maxfield  <mmaxfield@apple.com>
996
997         WKPreferencesSetFontSmoothingLevel doesn't actually do anything
998         https://bugs.webkit.org/show_bug.cgi?id=191708
999
1000         Reviewed by Simon Fraser.
1001
1002         Delete the symbol because no one calls it and it doesn't do anything
1003
1004         * TestWebKitAPI/Tests/WebKit/WKPreferences.cpp:
1005         (TestWebKitAPI::TEST):
1006         * WebKitTestRunner/TestController.cpp:
1007         (WTR::TestController::resetPreferencesToConsistentValues):
1008
1009 2018-11-15  Truitt Savell  <tsavell@apple.com>
1010
1011         Unreviewed, rolling out r238244.
1012
1013         Caused High Sierra test runs to fail early with 50 crashes and
1014         casued 25 API failures.
1015
1016         Reverted changeset:
1017
1018         "[css-logical] Implement flow-relative margin, padding and
1019         border shorthands"
1020         https://bugs.webkit.org/show_bug.cgi?id=188697
1021         https://trac.webkit.org/changeset/238244
1022
1023 2018-11-15  Aakash Jain  <aakash_jain@apple.com>
1024
1025         Increase EWS lock timeout to 3 hours
1026         https://bugs.webkit.org/show_bug.cgi?id=191705
1027
1028         Reviewed by Alexey Proskuryakov.
1029
1030         * QueueStatusServer/config/queues.py: Increased EWS lock timeout to 3 hours.
1031
1032 2018-11-15  Chris Dumez  <cdumez@apple.com>
1033
1034         IndexedDB.IndexedDBTempFileSize API test times out with process prewarming enabled
1035         https://bugs.webkit.org/show_bug.cgi?id=191671
1036         <rdar://problem/46086062>
1037
1038         Reviewed by Alex Christensen.
1039
1040         Add API test coverage.
1041
1042         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1043         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1044         (TEST):
1045
1046 2018-11-15  Oriol Brufau  <obrufau@igalia.com>
1047
1048         [css-logical] Implement flow-relative margin, padding and border shorthands
1049         https://bugs.webkit.org/show_bug.cgi?id=188697
1050
1051         Reviewed by Simon Fraser and Antti Koivisto.
1052
1053         * DumpRenderTree/TestOptions.cpp:
1054         (TestOptions::TestOptions):
1055         * DumpRenderTree/TestOptions.h:
1056         * DumpRenderTree/mac/DumpRenderTree.mm:
1057         (setWebPreferencesForTestOptions):
1058         Allow tests to enable the CSSLogicalEnabled flag in WK1.
1059
1060         * Scripts/webkitpy/style/checkers/jsonchecker.py:
1061         (JSONCSSPropertiesChecker.check_codegen_properties):
1062         Allow CSS property definitions to have a 'runtime-flag' parameter which
1063         disables the property when the specified runtime flag is disabled.
1064
1065 2018-11-15  Timothy Hatcher  <timothy@apple.com>
1066
1067         REGRESSION (r238212): WebKit.BackgroundColor* API test failures.
1068         https://bugs.webkit.org/show_bug.cgi?id=191697
1069         rdar://problem/46098570
1070
1071         Reviewed by Dean Jackson.
1072
1073         * TestWebKitAPI/Tests/mac/BackgroundColor.mm:
1074         (TestWebKitAPI::TEST): Updated for new default background color.
1075
1076 2018-11-15  Jonathan Bedard  <jbedard@apple.com>
1077
1078         webkitpy: Check for specific process instead of using data migrator (Follow-up fix)
1079         https://bugs.webkit.org/show_bug.cgi?id=191551
1080         <rdar://problem/45993156>
1081
1082         Reviewed by Aakash Jain.
1083
1084         * Scripts/webkitpy/xcode/simulated_device.py:
1085         (SimulatedDevice.is_usable): Use software_variant instead of software_version for watchOS.
1086
1087 2018-11-15  Daniel Bates  <dabates@apple.com>
1088
1089         [iOS] Shift + Tab does not focus previous field
1090         https://bugs.webkit.org/show_bug.cgi?id=191596
1091         <rdar://problem/45892053>
1092
1093         Reviewed by Wenson Hsieh.
1094
1095         Add infrastructure to support testing a key down event with modifiers by creating
1096         and dispatching a UIEvent. This infrastructure replaces the previous mechanism in
1097         Tools/WebKitTestRunner/ios/HIDEventGenerator.mm to generate a IOHIDEvent for a
1098         keydown as it did not support creating an event with modifier key state that would
1099         be recognized by UIKit.
1100
1101         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1102         (WTR::UIScriptController::keyDown):
1103         (WTR::UIScriptController::keyDownUsingHardwareKeyboard): Deleted.
1104         (WTR::UIScriptController::keyUpUsingHardwareKeyboard): Deleted.
1105         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1106         Add function uiController.keyDown() that takes a character that represents a keyboard key
1107         and an array of modifier keys. The behavior of this function is analogous to eventSender.keyDown().
1108         Remove functions uiController.keyDownUsingHardwareKeyboard() and uiController.keyUpUsingHardwareKeyboard()
1109         as the former is replaced by uiController.keyDown() and the latter was never used.
1110
1111         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1112         (WTR::UIScriptController::keyDown): Added.
1113         (WTR::UIScriptController::keyUpUsingHardwareKeyboard): Deleted.
1114         (WTR::UIScriptController::keyDownUsingHardwareKeyboard): Deleted.
1115         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1116         * WebKitTestRunner/ios/HIDEventGenerator.h:
1117         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1118         (createHIDKeyDownEvent): Added.
1119         (-[HIDEventGenerator keyDown:completionBlock:]): Deleted.
1120         (-[HIDEventGenerator keyUp:completionBlock:]): Deleted.
1121         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1122         (WTR::arrayLength): Added.
1123         (WTR::parseModifier): Added.
1124         (WTR::parseModifierArray): Added.
1125         (WTR::UIScriptController::keyDown):
1126         (WTR::UIScriptController::keyDownUsingHardwareKeyboard): Deleted.
1127         (WTR::UIScriptController::keyUpUsingHardwareKeyboard): Deleted.
1128
1129 2018-11-15  Keith Rollin  <krollin@apple.com>
1130
1131         Delete old .xcfilelist files
1132         https://bugs.webkit.org/show_bug.cgi?id=191669
1133         <rdar://problem/46081994>
1134
1135         Reviewed by Chris Dumez.
1136
1137         .xcfilelist files were created and added to the Xcode project files in
1138         https://trac.webkit.org/changeset/238008/webkit. However, they caused
1139         build issues and they were removed from the Xcode projects in
1140         https://trac.webkit.org/changeset/238055/webkit. This check-in removes
1141         the files from the repository altogether. They'll ultimately be
1142         replaced with new files with names that indicate whether the
1143         associated files are inputs to the Run Script phase or are files
1144         created by the Run Script phase.
1145
1146         * DumpRenderTree/DerivedSources.xcfilelist: Removed.
1147         * WebKitTestRunner/DerivedSources.xcfilelist: Removed.
1148
1149 2018-11-14  Zalan Butjas  <zalan@apple.com>
1150
1151         [LFC][IFC] Add support for in-flow positioned inline boxes.
1152         https://bugs.webkit.org/show_bug.cgi?id=191672
1153
1154         Reviewed by Antti Koivisto.
1155
1156         * LayoutReloaded/misc/LFC-passing-tests.txt:
1157
1158 2018-11-14  Keith Rollin  <krollin@apple.com>
1159
1160         Move scripts for Derived and Unified Sources to external files
1161         https://bugs.webkit.org/show_bug.cgi?id=191670
1162         <rdar://problem/46082278>
1163
1164         Reviewed by Keith Miller.
1165
1166         Move the scripts in the Generate Derived Sources and Generate Unified
1167         Sources Run Script phases from the Xcode projects to external shell
1168         script files. Then invoke those scripts from the Run Script phases.
1169         This refactoring is being performed to support later work that will
1170         invoke these scripts in other contexts.
1171
1172         The scripts were maintained as-is when making the move. I did a little
1173         reformatting and added 'set -e' to the top of each file, but that's
1174         it.
1175
1176         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1177         * DumpRenderTree/Scripts/generate-derived-sources.sh: Added.
1178         * WebKitTestRunner/Scripts/generate-derived-sources.sh: Added.
1179         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1180
1181 2018-11-14  Chris Dumez  <cdumez@apple.com>
1182
1183         WebKit.DecidePolicyForNavigationActionForHyperlinkThatRedirects API fails when PSON is enabled
1184         https://bugs.webkit.org/show_bug.cgi?id=191640
1185
1186         Reviewed by Alex Christensen.
1187
1188         Add API test coverage.
1189
1190         * TestWebKitAPI/Tests/WebKitCocoa/DecidePolicyForNavigationAction.mm:
1191         (runDecidePolicyForNavigationActionForHyperlinkThatRedirects):
1192         (TEST):
1193
1194 2018-11-14  Chris Dumez  <cdumez@apple.com>
1195
1196         REGRESSION (r238115): [iOS] TestWebKitAPI.ProcessSwap.NavigateToInvalidURL is failing
1197         https://bugs.webkit.org/show_bug.cgi?id=191660
1198
1199         Reviewed by Ryosuke Niwa.
1200
1201         The test tries to navigate to an invalid URL and makes sure that we do not process swap
1202         for such load. The test was inherently racing because it was doing:
1203         <body onload="setTimeout(() => alert('DONE'), 0); location.href = 'http://A=a%B=b'">
1204
1205         Its load event handler tries to navigate to 'http://A=a%B=b' and sets a 0 timer to
1206         log an alert, which causes the API test to keep going and check that we did not swap
1207         process. The issue is that a 0 timer may not be sufficient to trigger the load, as
1208         the policy decision is asynchronous and relies on the UIProcess responding to it.
1209
1210         To address the issue, the test now waits for the next policy decision, spins the
1211         run loop and then makes sure we did not swap process. It no longer relies on a message
1212         from the page.
1213
1214         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1215         (-[PSONNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1216
1217 2018-11-14  Chris Dumez  <cdumez@apple.com>
1218
1219         WebKit.WebsiteDataStoreCustomPaths API test is failing when enabling process prewarming
1220         https://bugs.webkit.org/show_bug.cgi?id=191638
1221
1222         Reviewed by Alex Christensen.
1223
1224         Add API test coverage.
1225
1226         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1227         (runWebsiteDataStoreCustomPaths):
1228         (TEST):
1229
1230 2018-11-14  Alex Christensen  <achristensen@webkit.org>
1231
1232         Add SPI to show a safe browsing warning
1233         https://bugs.webkit.org/show_bug.cgi?id=191604
1234
1235         Reviewed by Andy Estes.
1236
1237         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1238         (TEST):
1239
1240 2018-11-14  Wenson Hsieh  <wenson_hsieh@apple.com>
1241
1242         [iOS] A few drag and drop tests are crashing after r238146
1243         https://bugs.webkit.org/show_bug.cgi?id=191617
1244
1245         Reviewed by Dean Jackson.
1246
1247         Augment these crashing tests to verify that selection commands are suppressed during drop over editable elements
1248         via more robust means. These tests currently hit an assertion when revealing the callout bar too early, because
1249         TestWebKitAPI is not a UI application (see <https://webkit.org/b/190401>).
1250
1251         Instead of relying on this other bug, directly ask the text input whether it is suppressing selection commands
1252         during a drop, and remember the answer via DragAndDropSimulator.
1253
1254         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
1255         (TestWebKitAPI::TEST):
1256
1257         Add to the existing tests that started failing after r238146.
1258
1259         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
1260         * TestWebKitAPI/cocoa/TestWKWebView.h:
1261         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1262         (-[TestWKWebView textInputContentView]):
1263         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1264         (-[DragAndDropSimulator _resetSimulatedState]):
1265         (-[DragAndDropSimulator _webView:dataInteractionOperationWasHandled:forSession:itemProviders:]):
1266         * TestWebKitAPI/ios/UIKitSPI.h:
1267
1268 2018-11-14  Wenson Hsieh  <wenson_hsieh@apple.com>
1269
1270         [Cocoa] [WebKit2] Hook up some more editing actions (-pasteAndMatchStyle:, -makeTextWritingDirectionNatural:)
1271         https://bugs.webkit.org/show_bug.cgi?id=191605
1272         <rdar://problem/45813991>
1273
1274         Reviewed by Dean Jackson.
1275
1276         Adds two new API tests to exercise -_pasteAndMatchStyle: and -makeTextWritingDirectionNatural:.
1277
1278         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1279         (-[TestWKWebView _synchronouslyExecuteEditCommand:argument:]): Deleted.
1280         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
1281         (TestWebKitAPI::TEST):
1282         * TestWebKitAPI/cocoa/TestWKWebView.h:
1283         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1284
1285         Pull `-_synchronouslyExecuteEditCommand:argument:` out of WKAttachmentTests and into shared code, in a new
1286         category on WKWebView declared in TestWKWebView. Also, fix an unrelated typo in a nearby category.
1287
1288         (-[WKWebView _synchronouslyExecuteEditCommand:argument:]):
1289         * TestWebKitAPI/ios/UIKitSPI.h:
1290
1291 2018-11-14  Chris Dumez  <cdumez@apple.com>
1292
1293         WebKit.ApplicationManifestBasic API test is failing when enabling PSON
1294         https://bugs.webkit.org/show_bug.cgi?id=191602
1295
1296         Reviewed by Alex Christensen.
1297
1298         Add API test coverage.
1299
1300         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1301
1302 2018-11-14  Jonathan Bedard  <jbedard@apple.com>
1303
1304         webkitpy: Refactor port code for devices
1305         https://bugs.webkit.org/show_bug.cgi?id=191568
1306         <rdar://problem/46005821>
1307
1308         Reviewed by Alex Christensen.
1309
1310         watchOS and iOS device ports share many characteristics in testing, mostly due
1311         to the fact that both are devices.
1312
1313         * Scripts/webkitpy/port/device_port.py: Added.
1314         (DevicePort): Add base class that all simulated/physical device ports share.
1315         (DevicePort.__init__):
1316         (DevicePort.driver_cmd_line_for_logging): Moved from iOS port.
1317         (DevicePort._generate_all_test_configurations): Ditto.
1318         (DevicePort.child_processes): Ditto.
1319         (DevicePort.driver_name): Ditto.
1320         (DevicePort.target_host): Generalize worker access to attached devices and
1321         simulated devices based on the device manager.
1322         (DevicePort.devices): Return a list of all devices associated with this port.
1323         (DevicePort._create_devices):
1324         (DevicePort._build_driver_flags): Moved from iOSSimulatorPort/iOSDevicePort.
1325         (DevicePort._install): Moved from iOS port.
1326         (DevicePort.setup_test_run): Ditto.
1327         (DevicePort.clean_up_test_run): Ditto.
1328         (DevicePort.did_spawn_worker): Ditto.
1329         (DevicePort.setup_environ_for_server): Ditto.
1330         * Scripts/webkitpy/port/ios.py:
1331         (IOSPort):
1332         (IOSPort._device_for_worker_number_map): Replaced by DevicePort.devices().
1333         (IOSPort.driver_cmd_line_for_logging): Moved to DevicePort.
1334         (IOSPort.driver_name): Ditto.
1335         (IOSPort._generate_all_test_configurations): Ditto.
1336         (IOSPort.child_processes): Ditto.
1337         (IOSPort._testing_device): Ditto.
1338         (IOSPort.target_host): Ditto.
1339         (IOSPort._create_devices): Ditto.
1340         (IOSPort.setup_test_run): Ditto.
1341         (IOSPort.clean_up_test_run): Ditto.
1342         (IOSPort.did_spawn_worker): Ditto.
1343         * Scripts/webkitpy/port/ios_device.py:
1344         (IOSDevicePort): IOSDevicePort uses a device manager from apple_additions.
1345         (IOSDevicePort._look_for_all_crash_logs_in_log_dir): Use DevicePort.devices().
1346         (IOSDevicePort._get_crash_log): Ditto.
1347         (IOSDevicePort.ios_version): Ditto.
1348         (IOSDevicePort._create_devices): Ditto.
1349         (IOSDevicePort._device_for_worker_number_map): Replaced by DevicePort.devices().
1350         (IOSSimulatorPort._build_driver_flags): Moved to DevicePort.
1351         * Scripts/webkitpy/port/ios_device_unittest.py:
1352         (IOSDeviceTest.test_get_crash_log):
1353         * Scripts/webkitpy/port/ios_simulator.py:
1354         (IOSSimulatorPort): IOSSimulatorPort uses the SimulatedDeviceManager.
1355         (IOSSimulatorPort._create_devices): Clean up logging statement.
1356         (IOSSimulatorPort.setup_environ_for_server): Some of environment set-up is shared
1357         across all devices.
1358         (IOSSimulatorPort._device_for_worker_number_map): Replaced by DevicePort.devices().
1359         (IOSSimulatorPort._build_driver_flags): Moved to DevicePort.
1360         * Scripts/webkitpy/port/ios_simulator_unittest.py:
1361         (IOSSimulatorTest.test_32bit):
1362         (IOSSimulatorTest.test_64bit):
1363
1364 2018-11-14  Chris Dumez  <cdumez@apple.com>
1365
1366         WebKit.WKHTTPCookieStoreWithoutProcessPool API test is failing with process prewarming is enabled
1367         https://bugs.webkit.org/show_bug.cgi?id=191624
1368
1369         Reviewed by Alex Christensen.
1370
1371         Add API test coverage.
1372
1373         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
1374         (runWKHTTPCookieStoreWithoutProcessPool):
1375         (TEST):
1376
1377 2018-11-13  Jiewen Tan  <jiewen_tan@apple.com>
1378
1379         [WebAuthN] Support CTAP HID authenticators on macOS
1380         https://bugs.webkit.org/show_bug.cgi?id=188623
1381         <rdar://problem/43353777>
1382
1383         Reviewed by Brent Fulgham and Chris Dumez.
1384
1385         This patch adds support for the mock testing and entitlements to allow minibrowser to talk
1386         to hid devices.
1387
1388         * MiniBrowser/MiniBrowser.entitlements:
1389         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1390         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
1391
1392 2018-11-13  Ryosuke Niwa  <rniwa@webkit.org>
1393
1394         WebKit.GeolocationTransitionToLowAccuracy API crashes when enabling PSON
1395         https://bugs.webkit.org/show_bug.cgi?id=191616
1396
1397         Reviewed by Chris Dumez.
1398
1399         The crash was caused by WKView in autorelease pool invoking stopUpdatingCallback after
1400         GeolocationTransitionToLowAccuracyStateTracker in the stack had been destroyed,
1401         resulting in the use-after-free.
1402
1403         Made the tests more robust by clearing geolocation provider before exiting each test
1404         since we can't really prevent WKView from entering an autorelease pool.
1405
1406         Also made WebKit.GeolocationTransitionToLowAccuracy wait for the success callback
1407         instead of simply the end of the navigation so that the test would continue to work
1408         even if a web content process was created for the second web view (lowAccuracyWebView)
1409
1410         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
1411         (TestWebKitAPI::setupGeolocationProvider): Moved "*" to match the WebKit coding style guideline.
1412         (TestWebKitAPI::clearGeolocationProvider): Added.
1413         (TestWebKitAPI::runJavaScriptAlert): Added.
1414         (TestWebKitAPI::didFinishNavigation): Deleted.
1415         * TestWebKitAPI/Tests/WebKit/geolocationWatchPosition.html:
1416
1417 2018-11-13  Chris Dumez  <cdumez@apple.com>
1418
1419         WKProcessPool.InitialWarmedProcessUsed API is failing with PSON enabled
1420         https://bugs.webkit.org/show_bug.cgi?id=191618
1421
1422         Reviewed by Ryosuke Niwa.
1423
1424         Update API test to explicitly disable automatic process prewarning since it is testing
1425         manual prewarming.
1426
1427         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1428         (TEST):
1429
1430 2018-11-13  Chris Dumez  <cdumez@apple.com>
1431
1432         Several Service Worker API tests are failing when enabling PSON
1433         https://bugs.webkit.org/show_bug.cgi?id=191619
1434
1435         Reviewed by Youenn Fablet.
1436
1437         Update tests to use _webProcessCountIgnoringPrewarmed instead of _webProcessCount so that they are
1438         not impacted by process prewarming.
1439
1440         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1441
1442 2018-11-13  Wenson Hsieh  <wenson_hsieh@apple.com>
1443
1444         [iOS] Do not show selection UI for editable elements with opacity near zero
1445         https://bugs.webkit.org/show_bug.cgi?id=191442
1446         <rdar://problem/45958625>
1447
1448         Reviewed by Simon Fraser.
1449
1450         Add a couple of new testing helpers to UIScriptController.
1451
1452         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1453         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1454         (WTR::UIScriptController::textSelectionRangeRects const):
1455         (WTR::UIScriptController::selectionCaretViewRect const):
1456         (WTR::UIScriptController::selectionRangeViewRects const):
1457         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1458         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1459         (WTR::UIScriptController::textSelectionRangeRects const):
1460
1461         Rename `selectionRangeViewRects` to `textSelectionRangeRects`. This allows us to draw a distinction between
1462         `textSelectionRangeRects`/`textSelectionCaretRect`, which retrieve information about selection rects known
1463         to the text interaction assistant, and `selectionCaretViewRect`/`selectionRangeViewRects`, which retrieve the
1464         actual frames of the selection views used to draw overlaid selection UI. This difference is important in the
1465         new layout tests added in this patch, which only suppress caret rendering (i.e. selection views remain hidden).
1466
1467         Also, drive-by fix a leaked `NSMutableArray`.
1468
1469         (WTR::UIScriptController::selectionStartGrabberViewRect const):
1470         (WTR::UIScriptController::selectionEndGrabberViewRect const):
1471         (WTR::UIScriptController::selectionCaretViewRect const):
1472         (WTR::UIScriptController::selectionRangeViewRects const):
1473
1474         Testing helpers to grab the frames of caret and selection views, in WKContentView's coordinate space. These
1475         rects are also clamped to WKContentView bounds.
1476
1477 2018-11-13  Daniel Bates  <dabates@apple.com>
1478
1479         Consolidate WebKit UIKitSPI.h and UIKitTestSPI.h
1480         https://bugs.webkit.org/show_bug.cgi?id=173341
1481         <rdar://problem/32752890>
1482
1483         Reviewed by Simon Fraser.
1484
1485         There is little value to making a distinction between forward declarations
1486         of UIKit SPI needed in the WebKit layer and just for testing. Moreover,
1487         the contents of these two headers can conflict with each other following
1488         r218275 as DumpRenderTree includes both headers. Instead we should remove
1489         UIKitTestSPI.h and have WebKitTestRunner include the WebKit variant, UIKitSPI.h.
1490
1491         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1492         * DumpRenderTree/mac/DumpRenderTree.mm:
1493         * TestRunnerShared/spi/UIKitTestSPI.h: Removed.
1494         * WebKitTestRunner/Configurations/Base.xcconfig:
1495         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1496         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1497         * WebKitTestRunner/ios/GeneratedTouchesDebugWindow.mm:
1498         * WebKitTestRunner/ios/HIDEventGenerator.h:
1499         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1500         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1501         * WebKitTestRunner/ios/TestControllerIOS.mm:
1502         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1503         * WebKitTestRunner/ios/mainIOS.mm:
1504
1505 2018-11-13  Takashi Komori  <Takashi.Komori@sony.com>
1506
1507         Remove WebKitTestRunnerLib's build warnings.
1508         https://bugs.webkit.org/show_bug.cgi?id=191580
1509
1510         Reviewed by Fujii Hironori.
1511
1512         Include cmakeconfig.h in precompiled header.
1513
1514         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
1515
1516 2018-11-12  Darshan Kadu  <darsh7807@gmail.com>
1517
1518         Implement Cache API support for WPE/GTK
1519         https://bugs.webkit.org/show_bug.cgi?id=178316
1520
1521         Reviewed by Michael Catanzaro.
1522
1523         Called WKWebsiteDataStoreSetCacheStoragePerOriginQuota function to set the cache limit to 400 * 1200
1524         on all the platforms in TestController.cpp. Also, removed the setCacheStoragePerOriginQuota call from TestControllerCocoa.mm
1525
1526         * WebKitTestRunner/TestController.cpp:
1527         (WTR::TestController::generatePageConfiguration):
1528         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1529         (WTR::initializeWebViewConfiguration):
1530
1531 2018-11-12  Christopher Reid  <chris.reid@sony.com>
1532
1533         [Curl] Reject entire cookie if the domain fails a tailmatch.
1534         https://bugs.webkit.org/show_bug.cgi?id=191406
1535
1536         Reviewed by Youenn Fablet.
1537
1538         Added unittests for Curl cookie implementation.
1539
1540         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
1541         (TestWebKitAPI::Curl::CurlCookies::RejectTailmatchFailureDomain):
1542
1543 2018-11-12  Alex Christensen  <achristensen@webkit.org>
1544
1545         [iOS] Implement safe browsing in WebKit
1546         https://bugs.webkit.org/show_bug.cgi?id=191441
1547
1548         Reviewed by Tim Horton.
1549
1550         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1551         (checkTitleAndClick):
1552         (TEST):
1553
1554 2018-11-12  Basuke Suzuki  <basuke.suzuki@sony.com>
1555
1556         [Curl] Add API Test for Curl cookie backend.
1557         https://bugs.webkit.org/show_bug.cgi?id=191493
1558
1559         Reviewed by Youenn Fablet.
1560
1561         Add unit test to TestWebCore.
1562
1563         * TestWebKitAPI/PlatformWin.cmake:
1564         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp: Added.
1565
1566 2018-11-12  Tim Horton  <timothy_horton@apple.com>
1567
1568         Make it possible to edit images inline
1569         https://bugs.webkit.org/show_bug.cgi?id=191352
1570         <rdar://problem/30107985>
1571
1572         Reviewed by Dean Jackson.
1573
1574         * WebKitTestRunner/TestController.cpp:
1575         (WTR::updateTestOptionsFromTestHeader):
1576         * WebKitTestRunner/TestOptions.h:
1577         (WTR::TestOptions::hasSameInitializationOptions const):
1578         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1579         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1580         (WTR::TestController::platformCreateWebView):
1581         Add a test option to enable editable images.
1582
1583         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1584         (WTR::UIScriptController::drawSquareInEditableImage):
1585         (WTR::UIScriptController::numberOfStrokesInEditableImage):
1586         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1587         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1588         (WTR::UIScriptController::drawSquareInEditableImage):
1589         (WTR::UIScriptController::numberOfStrokesInEditableImage):
1590         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1591         * TestRunnerShared/spi/PencilKitTestSPI.h: Added.
1592         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1593         (WTR::findEditableImageCanvas):
1594         (WTR::UIScriptController::drawSquareInEditableImage):
1595         (WTR::UIScriptController::numberOfStrokesInEditableImage):
1596         Add the ability to draw on a PKCanvasView that is a subview of the WKWebView,
1597         and also to retrieve the number of strokes currently on the PKCanvasView.
1598         Currently this just takes the first canvas; we might need to make it
1599         take an identifier or something in the future if we need tests with multiple
1600         canvases. The indirect testing mechanism is required because PKCanvasView
1601         can currently not actually paint its strokes in the Simulator.
1602
1603 2018-11-12  Ryan Haddad  <ryanhaddad@apple.com>
1604
1605         [MediaStream] Screen capture should be an experimental feature on OSX only
1606         https://bugs.webkit.org/show_bug.cgi?id=191552
1607
1608         Unreviewed test gardening.
1609
1610         * TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm: Only run these tests on macOS.
1611
1612 2018-11-12  Don Olmstead  <don.olmstead@sony.com>
1613
1614         Shipped PNGs include bad profiles: iCCP: known incorrect sRGB profile
1615         https://bugs.webkit.org/show_bug.cgi?id=189230
1616         <rdar://problem/44050379>
1617
1618         Reviewed by Joseph Pecoraro.
1619
1620         Runs all png images through zopflipng. This results in a smaller file
1621         size and takes care of this issue as a byproduct.
1622
1623         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/favicon-green.png:
1624         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/favicon-red.png:
1625         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/ElCapitan.png:
1626         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/ElCapitan@2x.png:
1627         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/GTK.png:
1628         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/GTK@2x.png:
1629         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/HighSierra.png:
1630         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/HighSierra@2x.png:
1631         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS10.png:
1632         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS10@2x.png:
1633         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS10Simulator.png:
1634         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS10Simulator@2x.png:
1635         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11.png:
1636         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11@2x.png:
1637         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11Simulator.png:
1638         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11Simulator@2x.png:
1639         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS12.png:
1640         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS12@2x.png:
1641         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS12Simulator.png:
1642         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS12Simulator@2x.png:
1643         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9.png:
1644         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9@2x.png:
1645         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9Simulator.png:
1646         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9Simulator@2x.png:
1647         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSDevice.png:
1648         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSDevice@2x.png:
1649         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSSimulator.png:
1650         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSSimulator@2x.png:
1651         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mavericks.png:
1652         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mavericks@2x.png:
1653         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mojave.png:
1654         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mojave@2x.png:
1655         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion.png:
1656         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion@2x.png:
1657         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/PlatformRing.png:
1658         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/PlatformRing@2x.png:
1659         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra.png:
1660         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra@2x.png:
1661         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WPE.png:
1662         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WPE@2x.png:
1663         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows10.png:
1664         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows10@2x.png:
1665         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows7.png:
1666         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows7@2x.png:
1667         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows8.png:
1668         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows8@2x.png:
1669         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WindowsXP.png:
1670         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WindowsXP@2x.png:
1671         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Yosemite.png:
1672         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Yosemite@2x.png:
1673
1674 2018-11-12  Tim Horton  <timothy_horton@apple.com>
1675
1676         Modernize WebKit Tools Xcode projects for localization's sake
1677         https://bugs.webkit.org/show_bug.cgi?id=191495
1678
1679         Reviewed by Alexey Proskuryakov.
1680
1681         * ContentExtensionTester/ContentExtensionTester.xcodeproj/project.pbxproj:
1682         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1683         * EditingHistory/EditingHistory.xcodeproj/project.pbxproj:
1684         * FontWithFeatures/FontWithFeatures.xcodeproj/project.pbxproj:
1685         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
1686         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
1687         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
1688         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1689         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
1690         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
1691         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1692         * lldb/lldbWebKitTester/lldbWebKitTester.xcodeproj/project.pbxproj:
1693         These are less important because they're not localized, but since
1694         I made the style checker complain, it now complains any time anyone
1695         touches any of these projects... so upgrade them.
1696
1697 2018-11-12  Jonathan Bedard  <jbedard@apple.com>
1698
1699         webkitpy: Check for specific process instead of using data migrator
1700         https://bugs.webkit.org/show_bug.cgi?id=191551
1701         <rdar://problem/45993156>
1702
1703         Rubber-stamped by Aakash Jain.
1704
1705         It's possible for the data migrator process to be stuck, but for a simulator to be
1706         usable. Use device-specific processes to detect when a device is usable.
1707
1708         * Scripts/webkitpy/xcode/simulated_device.py:
1709         (SimulatedDeviceManager._wait_until_device_is_usable):
1710         (SimulatedDeviceManager):
1711         (SimulatedDeviceManager.initialize_devices): Explicitly wait until a device is usable
1712         since this implies that a device is booted.
1713         (SimulatedDeviceManager.swap): Ditto.
1714         (SimulatedDevice.is_usable): Check that a device is booted and that a device-specific
1715         process indicating the device is usable can be found.
1716         (SimulatedDeviceManager.wait_until_data_migration_is_done): Deleted.
1717         * Scripts/webkitpy/xcode/simulated_device_unittest.py: Update simctl_json so that
1718         it triggers the logic in is_usable()
1719
1720 2018-11-12  Takashi Komori  <Takashi.Komori@sony.com>
1721
1722         Resurrect WebKitTestRunner for Windows port
1723         https://bugs.webkit.org/show_bug.cgi?id=189257
1724
1725         Reviewed by Fujii Hironori.
1726
1727         Implement WebKitTestRunner for WinCairo.
1728
1729         * PlatformWin.cmake:
1730         * Scripts/build-webkittestrunner:
1731         * WebKitTestRunner/CMakeLists.txt:
1732         * WebKitTestRunner/EventSenderProxy.h:
1733         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
1734         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1735         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1736         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
1737         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1738         (WTR::rangeToStr):
1739         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
1740         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1741         (WTR::TestRunner::TestRunner):
1742         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1743         * WebKitTestRunner/InjectedBundle/win/AccessibilityControllerWin.cpp: Added.
1744         (WTR::AccessibilityController::resetToConsistentState):
1745         (WTR::AccessibilityController::accessibleElementById):
1746         (WTR::AccessibilityController::platformName):
1747         (WTR::AccessibilityController::rootElement):
1748         (WTR::AccessibilityController::focusedElement):
1749         (WTR::AccessibilityController::addNotificationListener):
1750         (WTR::AccessibilityController::removeNotificationListener):
1751         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp: Added.
1752         (WTR::AccessibilityUIElement::AccessibilityUIElement):
1753         (WTR::AccessibilityUIElement::~AccessibilityUIElement):
1754         (WTR::AccessibilityUIElement::isEqual):
1755         (WTR::AccessibilityUIElement::getChildren):
1756         (WTR::AccessibilityUIElement::getChildrenWithRange):
1757         (WTR::AccessibilityUIElement::childrenCount):
1758         (WTR::AccessibilityUIElement::elementAtPoint):
1759         (WTR::AccessibilityUIElement::indexOfChild):
1760         (WTR::AccessibilityUIElement::childAtIndex):
1761         (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
1762         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
1763         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
1764         (WTR::AccessibilityUIElement::ariaControlsElementAtIndex):
1765         (WTR::AccessibilityUIElement::disclosedRowAtIndex):
1766         (WTR::AccessibilityUIElement::rowAtIndex):
1767         (WTR::AccessibilityUIElement::selectedChildAtIndex const):
1768         (WTR::AccessibilityUIElement::selectedChildrenCount const):
1769         (WTR::AccessibilityUIElement::selectedRowAtIndex):
1770         (WTR::AccessibilityUIElement::titleUIElement):
1771         (WTR::AccessibilityUIElement::parentElement):
1772         (WTR::AccessibilityUIElement::disclosedByRow):
1773         (WTR::AccessibilityUIElement::attributesOfLinkedUIElements):
1774         (WTR::AccessibilityUIElement::attributesOfDocumentLinks):
1775         (WTR::AccessibilityUIElement::attributesOfChildren):
1776         (WTR::AccessibilityUIElement::allAttributes):
1777         (WTR::AccessibilityUIElement::stringAttributeValue):
1778         (WTR::AccessibilityUIElement::numberAttributeValue):
1779         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue const):
1780         (WTR::AccessibilityUIElement::rowHeaders const):
1781         (WTR::AccessibilityUIElement::columnHeaders const):
1782         (WTR::AccessibilityUIElement::uiElementAttributeValue const):
1783         (WTR::AccessibilityUIElement::boolAttributeValue):
1784         (WTR::AccessibilityUIElement::isAttributeSettable):
1785         (WTR::AccessibilityUIElement::isAttributeSupported):
1786         (WTR::AccessibilityUIElement::parameterizedAttributeNames):
1787         (WTR::AccessibilityUIElement::role):
1788         (WTR::AccessibilityUIElement::subrole):
1789         (WTR::AccessibilityUIElement::roleDescription):
1790         (WTR::AccessibilityUIElement::computedRoleString):
1791         (WTR::AccessibilityUIElement::title):
1792         (WTR::AccessibilityUIElement::description):
1793         (WTR::AccessibilityUIElement::orientation const):
1794         (WTR::AccessibilityUIElement::stringValue):
1795         (WTR::AccessibilityUIElement::language):
1796         (WTR::AccessibilityUIElement::helpText const):
1797         (WTR::AccessibilityUIElement::x):
1798         (WTR::AccessibilityUIElement::y):
1799         (WTR::AccessibilityUIElement::width):
1800         (WTR::AccessibilityUIElement::height):
1801         (WTR::AccessibilityUIElement::clickPointX):
1802         (WTR::AccessibilityUIElement::clickPointY):
1803         (WTR::AccessibilityUIElement::intValue const):
1804         (WTR::AccessibilityUIElement::minValue):
1805         (WTR::AccessibilityUIElement::maxValue):
1806         (WTR::AccessibilityUIElement::valueDescription):
1807         (WTR::AccessibilityUIElement::insertionPointLineNumber):
1808         (WTR::AccessibilityUIElement::isPressActionSupported):
1809         (WTR::AccessibilityUIElement::isIncrementActionSupported):
1810         (WTR::AccessibilityUIElement::isDecrementActionSupported):
1811         (WTR::AccessibilityUIElement::isEnabled):
1812         (WTR::AccessibilityUIElement::isRequired const):
1813         (WTR::AccessibilityUIElement::isFocused const):
1814         (WTR::AccessibilityUIElement::isSelected const):
1815         (WTR::AccessibilityUIElement::isSelectedOptionActive const):
1816         (WTR::AccessibilityUIElement::isExpanded const):
1817         (WTR::AccessibilityUIElement::isChecked const):
1818         (WTR::AccessibilityUIElement::isIndeterminate const):
1819         (WTR::AccessibilityUIElement::hierarchicalLevel const):
1820         (WTR::AccessibilityUIElement::speakAs):
1821         (WTR::AccessibilityUIElement::ariaIsGrabbed const):
1822         (WTR::AccessibilityUIElement::ariaDropEffects const):
1823         (WTR::AccessibilityUIElement::lineForIndex):
1824         (WTR::AccessibilityUIElement::rangeForLine):
1825         (WTR::AccessibilityUIElement::rangeForPosition):
1826         (WTR::AccessibilityUIElement::boundsForRange):
1827         (WTR::AccessibilityUIElement::stringForRange):
1828         (WTR::AccessibilityUIElement::attributedStringForRange):
1829         (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
1830         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
1831         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1832         (WTR::AccessibilityUIElement::selectTextWithCriteria):
1833         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
1834         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
1835         (WTR::AccessibilityUIElement::attributesOfColumns):
1836         (WTR::AccessibilityUIElement::attributesOfRows):
1837         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
1838         (WTR::AccessibilityUIElement::attributesOfHeader):
1839         (WTR::AccessibilityUIElement::rowCount):
1840         (WTR::AccessibilityUIElement::columnCount):
1841         (WTR::AccessibilityUIElement::indexInTable):
1842         (WTR::AccessibilityUIElement::rowIndexRange):
1843         (WTR::AccessibilityUIElement::columnIndexRange):
1844         (WTR::AccessibilityUIElement::cellForColumnAndRow):
1845         (WTR::AccessibilityUIElement::horizontalScrollbar const):
1846         (WTR::AccessibilityUIElement::verticalScrollbar const):
1847         (WTR::AccessibilityUIElement::selectedTextRange):
1848         (WTR::AccessibilityUIElement::setSelectedTextRange):
1849         (WTR::AccessibilityUIElement::increment):
1850         (WTR::AccessibilityUIElement::decrement):
1851         (WTR::AccessibilityUIElement::showMenu):
1852         (WTR::AccessibilityUIElement::press):
1853         (WTR::AccessibilityUIElement::setSelectedChild const):
1854         (WTR::AccessibilityUIElement::setSelectedChildAtIndex const):
1855         (WTR::AccessibilityUIElement::removeSelectionAtIndex const):
1856         (WTR::AccessibilityUIElement::clearSelectedChildren const):
1857         (WTR::AccessibilityUIElement::accessibilityValue const):
1858         (WTR::AccessibilityUIElement::documentEncoding):
1859         (WTR::AccessibilityUIElement::documentURI):
1860         (WTR::AccessibilityUIElement::url):
1861         (WTR::AccessibilityUIElement::addNotificationListener):
1862         (WTR::AccessibilityUIElement::removeNotificationListener):
1863         (WTR::AccessibilityUIElement::isFocusable const):
1864         (WTR::AccessibilityUIElement::isSelectable const):
1865         (WTR::AccessibilityUIElement::isMultiSelectable const):
1866         (WTR::AccessibilityUIElement::isVisible const):
1867         (WTR::AccessibilityUIElement::isOffScreen const):
1868         (WTR::AccessibilityUIElement::isCollapsed const):
1869         (WTR::AccessibilityUIElement::isIgnored const):
1870         (WTR::AccessibilityUIElement::isSingleLine const):
1871         (WTR::AccessibilityUIElement::isMultiLine const):
1872         (WTR::AccessibilityUIElement::hasPopup const):
1873         (WTR::AccessibilityUIElement::takeFocus):
1874         (WTR::AccessibilityUIElement::takeSelection):
1875         (WTR::AccessibilityUIElement::addSelection):
1876         (WTR::AccessibilityUIElement::removeSelection):
1877         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
1878         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
1879         (WTR::AccessibilityUIElement::textMarkerRangeLength):
1880         (WTR::AccessibilityUIElement::previousTextMarker):
1881         (WTR::AccessibilityUIElement::nextTextMarker):
1882         (WTR::AccessibilityUIElement::stringForTextMarkerRange):
1883         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
1884         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
1885         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
1886         (WTR::AccessibilityUIElement::endTextMarkerForBounds):
1887         (WTR::AccessibilityUIElement::startTextMarkerForBounds):
1888         (WTR::AccessibilityUIElement::textMarkerForPoint):
1889         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
1890         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRange):
1891         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeWithOptions):
1892         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
1893         (WTR::AccessibilityUIElement::indexForTextMarker):
1894         (WTR::AccessibilityUIElement::isTextMarkerValid):
1895         (WTR::AccessibilityUIElement::textMarkerForIndex):
1896         (WTR::AccessibilityUIElement::startTextMarker):
1897         (WTR::AccessibilityUIElement::endTextMarker):
1898         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
1899         (WTR::AccessibilityUIElement::scrollToMakeVisible):
1900         (WTR::AccessibilityUIElement::scrollToGlobalPoint):
1901         (WTR::AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
1902         (WTR::AccessibilityUIElement::supportedActions const):
1903         (WTR::AccessibilityUIElement::pathDescription const):
1904         (WTR::AccessibilityUIElement::mathPostscriptsDescription const):
1905         (WTR::AccessibilityUIElement::mathPrescriptsDescription const):
1906         (WTR::AccessibilityUIElement::classList const):
1907         (WTR::AccessibilityUIElement::characterAtOffset):
1908         (WTR::AccessibilityUIElement::wordAtOffset):
1909         (WTR::AccessibilityUIElement::lineAtOffset):
1910         (WTR::AccessibilityUIElement::sentenceAtOffset):
1911         * WebKitTestRunner/InjectedBundle/win/ActivateFontsWin.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp.
1912         (WTR::activateFonts):
1913         (WTR::installFakeHelvetica):
1914         (WTR::uninstallFakeHelvetica):
1915         * WebKitTestRunner/InjectedBundle/win/InjectedBundleWin.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp.
1916         (WTR::InjectedBundle::platformInitialize):
1917         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.cpp: Added.
1918         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h: Copied from Tools/WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp.
1919         * WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp.
1920         (WTR::TestRunner::pathToLocalResource):
1921         (WTR::TestRunner::inspectorTestStubURL):
1922         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
1923         (WTR::TestRunner::platformInitialize):
1924         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
1925         (WTR::TestRunner::installFakeHelvetica):
1926         * WebKitTestRunner/PlatformWebView.h:
1927         * WebKitTestRunner/PlatformWin.cmake: Added.
1928         * WebKitTestRunner/TestController.cpp:
1929         (WTR::TestController::resetStateToConsistentValues):
1930         (WTR::createTestURL):
1931         * WebKitTestRunner/TestInvocation.cpp:
1932         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
1933         * WebKitTestRunner/win/EventSenderProxyWin.cpp: Added.
1934         (WTR::EventSenderProxy::EventSenderProxy):
1935         (WTR::EventSenderProxy::~EventSenderProxy):
1936         (WTR::EventSenderProxy::mouseDown):
1937         (WTR::EventSenderProxy::mouseUp):
1938         (WTR::EventSenderProxy::mouseMoveTo):
1939         (WTR::EventSenderProxy::mouseScrollBy):
1940         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
1941         (WTR::EventSenderProxy::continuousMouseScrollBy):
1942         (WTR::EventSenderProxy::leapForward):
1943         (WTR::EventSenderProxy::keyDown):
1944         * WebKitTestRunner/win/PlatformWebViewWin.cpp: Added.
1945         (WTR::registerWindowClass):
1946         (WTR::PlatformWebView::PlatformWebView):
1947         (WTR::PlatformWebView::~PlatformWebView):
1948         (WTR::PlatformWebView::resizeTo):
1949         (WTR::PlatformWebView::page):
1950         (WTR::PlatformWebView::focus):
1951         (WTR::PlatformWebView::windowFrame):
1952         (WTR::PlatformWebView::setWindowFrame):
1953         (WTR::PlatformWebView::didInitializeClients):
1954         (WTR::PlatformWebView::addChromeInputField):
1955         (WTR::PlatformWebView::removeChromeInputField):
1956         (WTR::PlatformWebView::addToWindow):
1957         (WTR::PlatformWebView::removeFromWindow):
1958         (WTR::PlatformWebView::setWindowIsKey):
1959         (WTR::PlatformWebView::makeWebViewFirstResponder):
1960         (WTR::generateCairoSurfaceFromBitmap):
1961         (WTR::PlatformWebView::windowSnapshotImage):
1962         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
1963         (WTR::PlatformWebView::setNavigationGesturesEnabled):
1964         (WTR::PlatformWebView::forceWindowFramesChanged):
1965         (WTR::PlatformWebView::drawsBackground const):
1966         (WTR::PlatformWebView::setDrawsBackground):
1967         * WebKitTestRunner/win/TestControllerWin.cpp: Added.
1968         (WTR::exceptionFilter):
1969         (WTR::runRunLoopUntil):
1970         (WTR::TestController::notifyDone):
1971         (WTR::TestController::setHidden):
1972         (WTR::TestController::platformInitialize):
1973         (WTR::TestController::platformPreferences):
1974         (WTR::TestController::platformDestroy):
1975         (WTR::toWK):
1976         (WTR::TestController::platformInitializeContext):
1977         (WTR::TestController::platformRunUntil):
1978         (WTR::TestController::platformDidCommitLoadForFrame):
1979         (WTR::TestController::initializeInjectedBundlePath):
1980         (WTR::TestController::initializeTestPluginDirectory):
1981         (WTR::TestController::runModal):
1982         (WTR::TestController::platformContext):
1983         (WTR::TestController::platformLibraryPathForTesting):
1984         (WTR::TestController::platformConfigureViewForTest):
1985         (WTR::TestController::platformResetPreferencesToConsistentValues):
1986         (WTR::TestController::updatePlatformSpecificTestOptionsForTest const):
1987         * WebKitTestRunner/win/WebKitTestRunnerPrefix.cpp: Added.
1988         * WebKitTestRunner/win/main.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp.
1989         (dllLauncherEntryPoint):
1990
1991 2018-11-12  Alicia Boya García  <aboya@igalia.com>
1992
1993         [MSE][GStreamer] Introduce AbortableTaskQueue
1994         https://bugs.webkit.org/show_bug.cgi?id=190902
1995
1996         Reviewed by Xabier Rodriguez-Calvar.
1997
1998         Tests for AbortableTaskQueue are included.
1999
2000         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2001         * TestWebKitAPI/PlatformGTK.cmake:
2002         * TestWebKitAPI/Tests/WebCore/AbortableTaskQueue.cpp: Added.
2003         (TestWebKitAPI::TEST):
2004         (TestWebKitAPI::FancyResponse::FancyResponse):
2005         (TestWebKitAPI::FancyResponse::operator=):
2006         (TestWebKitAPI::DeterministicScheduler::DeterministicScheduler):
2007         (TestWebKitAPI::DeterministicScheduler::ThreadContext::ThreadContext):
2008         (TestWebKitAPI::DeterministicScheduler::ThreadContext::waitMyTurn):
2009         (TestWebKitAPI::DeterministicScheduler::ThreadContext::yieldToThread):
2010
2011 2018-11-11  Fujii Hironori  <Hironori.Fujii@sony.com>
2012
2013         run-bindings-tests is timing out in some WinCairo bots
2014         https://bugs.webkit.org/show_bug.cgi?id=191348
2015
2016         Reviewed by Alex Christensen.
2017
2018         BuildBot kills run-bindings-tests if it outputs nothing for 20
2019         minutes. run-bindings-tests runs very slowly in WinCairo Docker,
2020         and it takes more than 30 minutes to finish. And, Windows Python
2021         buffers the progress output.
2022
2023         * Scripts/webkitpy/bindings/main.py:
2024         (BindingsTests.detect_changes): Call sys.stdout.flush() after the
2025         test case result is output.
2026
2027 2018-11-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2028
2029         Implement a new edit command to change the enclosing list type
2030         https://bugs.webkit.org/show_bug.cgi?id=191487
2031         <rdar://problem/45955922>
2032
2033         Reviewed by Ryosuke Niwa.
2034
2035         Add a new API test to verify that `-[WKWebView _changeListType:]` is hooked up to the corresponding editing
2036         command in WebCore. See the new layout test for a test that exercises more nuanced corner cases.
2037
2038         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2039         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
2040         (-[TestWKWebView setPosition:offset:]):
2041         (-[TestWKWebView setBase:baseOffset:extent:extentOffset:]):
2042         (TestWebKitAPI::webViewForEditActionTestingWithPageNamed):
2043         (TestWebKitAPI::TEST):
2044         * TestWebKitAPI/Tests/WebKitCocoa/editable-nested-lists.html: Added.
2045
2046 2018-11-11  Dan Bernstein  <mitz@apple.com>
2047
2048         ProcessPoolConfiguration::copy() doesn’t copy m_customWebContentServiceBundleIdentifier
2049         https://bugs.webkit.org/show_bug.cgi?id=191514
2050
2051         Reviewed by Geoffrey Garen.
2052
2053         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2054         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm: Added.
2055         (TEST):
2056
2057 2018-11-11  Benjamin Poulain  <benjamin@webkit.org>
2058
2059         Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
2060         https://bugs.webkit.org/show_bug.cgi?id=191492
2061
2062         Reviewed by Alex Christensen.
2063
2064         Update file name.
2065
2066         * DumpRenderTree/mac/DumpRenderTree.mm:
2067         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
2068         * WebKitTestRunner/mac/TestControllerMac.mm:
2069
2070 2018-11-10  Benjamin Poulain  <benjamin@webkit.org>
2071
2072         Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
2073         https://bugs.webkit.org/show_bug.cgi?id=191492
2074
2075         Reviewed by Alex Christensen.
2076
2077         * DumpRenderTree/mac/DumpRenderTree.mm:
2078         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
2079         * WebKitTestRunner/mac/TestControllerMac.mm:
2080
2081 2018-11-10  Ryan Haddad  <ryanhaddad@apple.com>
2082
2083         Unreviewed, rolling out r238065.
2084
2085         Breaks internal builds.
2086
2087         Reverted changeset:
2088
2089         "Make it possible to edit images inline"
2090         https://bugs.webkit.org/show_bug.cgi?id=191352
2091         https://trac.webkit.org/changeset/238065
2092
2093 2018-11-10  Michael Catanzaro  <mcatanzaro@igalia.com>
2094
2095         [WPE][GTK] API test /webkit/WebKitSettings/webkit-settings is failing
2096         https://bugs.webkit.org/show_bug.cgi?id=191221
2097
2098         Unreviewed, fix a typo from the previous patch. After disabling the setting, we should test
2099         that it is disabled, but we're testing that it is enabled, because I failed to update this
2100         line.
2101
2102         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2103         (testWebKitSettings):
2104
2105 2018-11-10  Tim Horton  <timothy_horton@apple.com>
2106
2107         Make it possible to edit images inline
2108         https://bugs.webkit.org/show_bug.cgi?id=191352
2109         <rdar://problem/30107985>
2110
2111         Reviewed by Dean Jackson.
2112
2113         * WebKitTestRunner/TestController.cpp:
2114         (WTR::updateTestOptionsFromTestHeader):
2115         * WebKitTestRunner/TestOptions.h:
2116         (WTR::TestOptions::hasSameInitializationOptions const):
2117         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2118         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2119         (WTR::TestController::platformCreateWebView):
2120         Add a test option to enable editable images.
2121
2122         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2123         (WTR::UIScriptController::drawSquareInEditableImage):
2124         (WTR::UIScriptController::numberOfStrokesInEditableImage):
2125         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2126         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2127         (WTR::UIScriptController::drawSquareInEditableImage):
2128         (WTR::UIScriptController::numberOfStrokesInEditableImage):
2129         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2130         * TestRunnerShared/spi/PencilKitTestSPI.h: Added.
2131         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2132         (WTR::findEditableImageCanvas):
2133         (WTR::UIScriptController::drawSquareInEditableImage):
2134         (WTR::UIScriptController::numberOfStrokesInEditableImage):
2135         Add the ability to draw on a PKCanvasView that is a subview of the WKWebView,
2136         and also to retrieve the number of strokes currently on the PKCanvasView.
2137         Currently this just takes the first canvas; we might need to make it
2138         take an identifier or something in the future if we need tests with multiple
2139         canvases. The indirect testing mechanism is required because PKCanvasView
2140         can currently not actually paint its strokes in the Simulator.
2141
2142 2018-11-09  Chris Dumez  <cdumez@apple.com>
2143
2144         Suspended page persists even after back/forward list item is gone
2145         https://bugs.webkit.org/show_bug.cgi?id=191488
2146         <rdar://problem/45953006>
2147
2148         Reviewed by Geoffrey Garen.
2149
2150         Add API test coverage.
2151
2152         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2153
2154 2018-11-09  Wenson Hsieh  <wenson_hsieh@apple.com>
2155
2156         [Cocoa] Implement SPI on WKWebView to increase and decrease list levels
2157         https://bugs.webkit.org/show_bug.cgi?id=191471
2158         <rdar://problem/45952472>
2159
2160         Reviewed by Tim Horton.
2161
2162         Add an API test to ensure that list levels can be incremented and decremented via WKWebView SPI.
2163
2164         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
2165         (TestWebKitAPI::webViewForEditActionTesting):
2166         (TestWebKitAPI::TEST):
2167
2168 2018-11-09  Basuke Suzuki  <basuke.suzuki@sony.com>
2169
2170         [Curl][WebKit] Implement Proxy configuration API.
2171         https://bugs.webkit.org/show_bug.cgi?id=189053
2172
2173         Reviewed by Youenn Fablet.
2174
2175         Added Proxy Settings dialog to call newly added API.
2176
2177         * MiniBrowser/win/BrowserWindow.h:
2178         * MiniBrowser/win/Common.cpp:
2179         (askProxySettings):
2180         (askCredential):
2181         (authDialogProc): Deleted.
2182         * MiniBrowser/win/Common.h:
2183         * MiniBrowser/win/DialogHelper.h: Added.
2184         (Dialog::run):
2185         (Dialog::doalogProc):
2186         (Dialog::handle):
2187         (Dialog::setup):
2188         (Dialog::update):
2189         (Dialog::validate):
2190         (Dialog::updateOkButton):
2191         (Dialog::command):
2192         (Dialog::ok):
2193         (Dialog::cancel):
2194         (Dialog::close):
2195         (Dialog::hDlg):
2196         (Dialog::item):
2197         (Dialog::setEnabled):
2198         (Dialog::setText):
2199         (Dialog::getText):
2200         (Dialog::getTextLength):
2201         (Dialog::RadioGroup::RadioGroup):
2202         (Dialog::RadioGroup::set):
2203         (Dialog::RadioGroup::get):
2204         (Dialog::radioGroup):
2205         * MiniBrowser/win/MainWindow.cpp:
2206         (MainWindow::WndProc):
2207         * MiniBrowser/win/MiniBrowserLib.rc:
2208         * MiniBrowser/win/MiniBrowserLibResource.h:
2209         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2210         (createWKURL):
2211         (WebKitBrowserWindow::WebKitBrowserWindow):
2212         (WebKitBrowserWindow::updateProxySettings):
2213         (WebKitBrowserWindow::loadURL):
2214         (WebKitBrowserWindow::loadHTMLString):
2215         (WebKitBrowserWindow::openProxySettings):
2216         * MiniBrowser/win/WebKitBrowserWindow.h:
2217         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
2218         (WebKitLegacyBrowserWindow::openProxySettings):
2219         * MiniBrowser/win/WebKitLegacyBrowserWindow.h:
2220
2221 2018-11-09  Wenson Hsieh  <wenson_hsieh@apple.com>
2222
2223         [Cocoa] Introduce WKWebView SPI to insert nested ordered and unordered lists
2224         https://bugs.webkit.org/show_bug.cgi?id=191410
2225         <rdar://problem/45898610>
2226
2227         Reviewed by Dean Jackson.
2228
2229         Move WKWebViewEditActions from iOS to WebKitCocoa, and enable the relevant WKWebViewEditActions tests on macOS.
2230         Additionally, add new API tests to verify that `-_pasteAsQuotation:` and `-_insertNested(Un)OrderedList:` are
2231         hooked up to their respective editing commands.
2232
2233         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2234         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm: Renamed from Tools/TestWebKitAPI/Tests/ios/WKWebViewEditActions.mm.
2235         (-[TestWKWebView querySelectorExists:]):
2236         (-[TestWKWebView insertString:]):
2237
2238         Add a helper method to insert a piece of text. This abstracts platform differences between iOS and macOS, by
2239         invoking the WKWebView directly on macOS and calling on the content view on iOS.
2240
2241         (TestWebKitAPI::webViewForEditActionTesting):
2242         (TestWebKitAPI::TEST):
2243
2244 2018-11-09  Philippe Normand  <pnormand@igalia.com>
2245
2246         [Flatpak] Refactoring and drive-by fixes
2247         https://bugs.webkit.org/show_bug.cgi?id=191421
2248
2249         Reviewed by Michael Catanzaro.
2250
2251         * Scripts/webkitdirs.pm:
2252         (inFlatpakSandbox): Flatpak now has a /.flatpak-info file when in
2253         the sandbox, so rely on this.
2254         * flatpak/flatpakutils.py:
2255         (expand_manifest): Pass explicit keywords to load_manifest() and
2256         remove unused local variable.
2257         (WebkitFlatpak.clean_args): Move hard-coded sdk/runtime infos to the manifest file.
2258         (WebkitFlatpak.run_in_sandbox): Add support for extra environment variables.
2259         (WebkitFlatpak.setup_dev_env): Stop build at final app. Refactor
2260         build_type handling a bit.
2261         * flatpak/org.webkit.CommonModules.yaml: Added.
2262         * flatpak/org.webkit.WPE.yaml: wpebackend upstream was renamed to libwpe.
2263         * flatpak/org.webkit.WebKit.yaml: Move common dependencies
2264         declaration to CommonModules, so it can be reused later when we
2265         add support for building extra libraries depending on WPE.
2266
2267 2018-11-08  Said Abou-Hallawa  <sabouhallawa@apple.com>
2268
2269 onal supported image formats
2270         https://bugs.webkit.org/show_bug.cgi?id=190454
2271
2272         Reviewed by Simon Fraser.
2273
2274         Test opening a TGA image in WebView which is not allowed by default. The
2275         TGA format will be allowed through WKWebViewConfiguration.
2276
2277         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2278         * TestWebKitAPI/Tests/WebKitCocoa/100x100-red.tga: Added.
2279         * TestWebKitAPI/Tests/WebKitCocoa/400x400-green.png: Added.
2280         * TestWebKitAPI/Tests/WebKitCocoa/AdditionalSupportedImageTypes.mm: Added.
2281         (runTest):
2282         (TEST):
2283
2284 2018-11-08  Jiewen Tan  <jiewen_tan@apple.com>
2285
2286         Unreviewed, a proper build fix for r237983
2287
2288         Don't include header PublicKeyCredential.h in CtapResponseTest.cpp.
2289
2290         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2291         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/mac/CtapRequestTest.cpp.
2292         (TestWebKitAPI::TEST):
2293         * TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/mac/CtapResponseTest.cpp.
2294         (TestWebKitAPI::getTestCorruptedSignResponse):
2295         (TestWebKitAPI::getTestCredentialRawIdBytes):
2296         (TestWebKitAPI::convertToVector):
2297         (TestWebKitAPI::TEST):
2298
2299 2018-11-08  Keith Rollin  <krollin@apple.com>
2300
2301         Create .xcfilelist files
2302         https://bugs.webkit.org/show_bug.cgi?id=191324
2303         <rdar://problem/45852819>
2304
2305         Reviewed by Alex Christensen.
2306
2307         As part of preparing for enabling XCBuild, create and use .xcfilelist
2308         files. These files are using during Run Script build phases in an
2309         Xcode project. If a Run Script build phase produces new files that are
2310         used later as inputs to subsequent build phases, XCBuild needs to know
2311         about these files. These files can be either specified in an "output
2312         files" section of the Run Script phase editor, or in .xcfilelist files
2313         that are associated with the Run Script build phase.
2314
2315         This patch takes the second approach. It consists of three sets of changes:
2316
2317         - Modify the DerivedSources.make files to have a
2318           'print_all_generated_files" target that produces a list of the files
2319           they create.
2320
2321         - Create a shell script that produces .xcfilelist files from the
2322           output of the previous step, as well as for the files created in the
2323           Generate Unified Sources build steps.
2324
2325         - Add the new .xcfilelist files to the associated projects.
2326
2327         Note that, with these changes, the Xcode workspace and projects can no
2328         longer be fully loaded into Xcode 9. Xcode will attempt to load the
2329         projects that have .xcfilelist files associated with them, but will
2330         fail and display a placeholder for those projects instead. It's
2331         expected that all developers are using Xcode 10 by now and that not
2332         being able to load into Xcode 9 is not a practical issue. Keep in mind
2333         that this is strictly an IDE issue, and that the projects can still be
2334         built with `xcodebuild`.
2335
2336         Also note that the shell script that creates the .xcfilelist files can
2337         also be used to verify that the set of files that's currently checked
2338         in is up-to-date. This checking can be used as part of a check-in hook
2339         or part of check-webkit-style to sooner catch cases where the
2340         .xcfilelist files need to be regenerated.
2341
2342         * DumpRenderTree/DerivedSources.make:
2343         * DumpRenderTree/DerivedSources.xcfilelist: Added.
2344         * Scripts/generate-xcfilelists: Added.
2345         * WebKitTestRunner/DerivedSources.make:
2346         * WebKitTestRunner/DerivedSources.xcfilelist: Added.
2347
2348 2018-11-08  Jiewen Tan  <jiewen_tan@apple.com>
2349
2350         Unreviewed, a quick build fix for r237983
2351
2352         Temporarily make CtapRequestTest.cpp/CtapResponseTest.cpp to mac only to avoid iOS build failures.
2353
2354         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
2355         * TestWebKitAPI/Tests/WebCore/mac/CtapRequestTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp.
2356         (TestWebKitAPI::TEST):
2357         * TestWebKitAPI/Tests/WebCore/mac/CtapResponseTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp.
2358         (TestWebKitAPI::getTestCorruptedSignResponse):
2359         (TestWebKitAPI::getTestCredentialRawIdBytes):
2360         (TestWebKitAPI::convertToVector):
2361         (TestWebKitAPI::TEST):
2362
2363 2018-11-05  Ryan Haddad  <ryanhaddad@apple.com>
2364
2365         Fix steps_unittest.py failures related to recent Win10/Win7 changes
2366         https://bugs.webkit.org/show_bug.cgi?id=191290
2367
2368         Reviewed by Alexey Proskuryakov.
2369
2370         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update expected results.
2371
2372 2018-11-08  Dean Jackson  <dino@apple.com>
2373
2374         Add a String literal that returns a String
2375         https://bugs.webkit.org/show_bug.cgi?id=191425
2376         <rdar://problem/45914556>
2377
2378         Reviewed by Sam Weinig.
2379
2380         Test _str.
2381
2382         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
2383         (TestWebKitAPI::TEST):
2384
2385 2018-11-08  Jonathan Bedard  <jbedard@apple.com>
2386
2387         webkitpy: Generalize trailing SDK specifier (Part 2)
2388         https://bugs.webkit.org/show_bug.cgi?id=191275
2389         <rdar://problem/45703660>
2390
2391         Rubber-stamped by Aakash Jain.
2392
2393         Re-landing this change, configuration issues have been resolved.
2394
2395         * Scripts/webkitpy/port/ios_device.py:
2396         (IOSDevicePort): Use normalized SDK.
2397         * Scripts/webkitpy/port/ios_simulator.py:
2398         (IOSSimulatorPort): Use normalized SDK.
2399         (IOSSimulatorPort._build_driver_flags): Use platform SDK in build driver flags.
2400
2401 2018-11-08  Jiewen Tan  <jiewen_tan@apple.com>
2402
2403         [WebAuthN] Import CTAP device request/response converters from Chromium
2404         https://bugs.webkit.org/show_bug.cgi?id=190784
2405         <rdar://problem/45460333>
2406
2407         Reviewed by Brent Fulgham.
2408
2409         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2410         * TestWebKitAPI/Tests/WebCore/CBORValueTest.cpp:
2411         (TestWebKitAPI::TEST):
2412         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp: Added.
2413         (TestWebKitAPI::TEST):
2414         * TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp: Added.
2415         (TestWebKitAPI::getTestCorruptedSignResponse):
2416         (TestWebKitAPI::getTestCredentialRawIdBytes):
2417         (TestWebKitAPI::convertToVector):
2418         (TestWebKitAPI::TEST):
2419         * TestWebKitAPI/Tests/WebCore/FidoTestData.h: Added.
2420
2421 2018-11-07  Caio Lima  <ticaiolima@gmail.com>
2422
2423         [BigInt] Add support to BigInt into ValueAdd
2424         https://bugs.webkit.org/show_bug.cgi?id=186177
2425
2426         Reviewed by Keith Miller.
2427
2428         * Scripts/run-jsc-benchmarks:
2429
2430 2018-11-07  Sihui Liu  <sihui_liu@apple.com>
2431
2432         RELEASE_ASSERT(!m_hardClosedForUserDelete) fails in WebCore::IDBServer::UniqueIDBDatabase::invokeOperationAndTransactionTimer
2433         https://bugs.webkit.org/show_bug.cgi?id=191326
2434         <rdar://problem/45769269>
2435
2436         Reviewed by Geoffrey Garen.
2437
2438         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2439         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.html: Added.
2440         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm: Added.
2441         (-[IndexedDBUserDeleteMessageHandler userContentController:didReceiveScriptMessage:]):
2442         (TEST):
2443
2444 2018-11-07  Daniel Bates  <dabates@apple.com>
2445
2446         Override +[UIKeyboard isInHardwareKeyboardMode] in WebKitTestRunner and DumpRenderTree
2447         https://bugs.webkit.org/show_bug.cgi?id=190141
2448
2449         Reviewed by Darin Adler.
2450
2451         Override +[UIKeyboard isInHardwareKeyboardMode] to always return NO so as to make test
2452         runs deterministic regardless of whether a hardware keyboard is attached.
2453
2454         * DumpRenderTree/mac/DumpRenderTree.mm:
2455         (overrideIsInHardwareKeyboardMode): Added.
2456         (prepareConsistentTestingEnvironment):
2457         * TestRunnerShared/spi/UIKitTestSPI.h: Forward declare SPI.
2458         * WebKitTestRunner/ios/TestControllerIOS.mm:
2459         (overrideIsInHardwareKeyboardMode): Added.
2460         (WTR::TestController::platformInitialize):
2461
2462 2018-11-07  Jonathan Bedard  <jbedard@apple.com>
2463
2464         Unreviewed, rolling out r237913.
2465
2466         Breaks running tests on Mac without iOS SDK installed
2467
2468         Reverted changeset:
2469
2470         "webkitpy: Generalize trailing SDK specifier (Part 2)"
2471         https://bugs.webkit.org/show_bug.cgi?id=191275
2472         https://trac.webkit.org/changeset/237913
2473
2474 2018-11-07  Zamiul Haque  <zhaque@apple.com>
2475
2476         Force a gregorian calendar to show for credit card expiration date inputs
2477         (autocomplete='cc-exp'*) regardless of default system settings.
2478         https://bugs.webkit.org/show_bug.cgi?id=191096
2479         rdar://problem/42640256
2480
2481         Reviewed by Tim Horton.
2482
2483         Implemented simulateForeignDefaultCalendar and calendarType to be used
2484         for changing the default calendar returned by the system (ie. [NSCalendar
2485         currentCalendar]) and getting the calendar type identifier of a presented date
2486         picker.
2487
2488         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2489         (WTR::UIScriptController::isShowingDataListSuggestions const):
2490         (WTR::UIScriptController::calendarType const):
2491         (WTR::UIScriptController::setDefaultCalendarType):
2492         * DumpRenderTree/mac/UIScriptControllerMac.mm:
2493         (WTR::UIScriptController::calendarType const):
2494         (WTR::UIScriptController::setDefaultCalendarType):
2495         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2496         (WTR::UIScriptController::selectionEndGrabberViewRect const):
2497         (WTR::UIScriptController::calendarType const): Deleted.
2498         * WebKitTestRunner/TestController.cpp:
2499         * WebKitTestRunner/TestController.h:
2500         * WebKitTestRunner/UIScriptControllerCocoa.mm:
2501         (WTR::UIScriptController::calendarType const):
2502         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2503         (WTR::swizzledCalendar):
2504         (WTR::TestController::getOverriddenCalendarIdentifier const):
2505         (WTR::TestController::setDefaultCalendarType):
2506         (WTR::TestController::cocoaResetStateToConsistentValues):
2507         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2508         (WTR::UIScriptController::selectionEndGrabberViewRect const):
2509         (WTR::UIScriptController::calendarType const): Deleted.
2510
2511 2018-11-06  Jonathan Bedard  <jbedard@apple.com>
2512
2513         webkitpy: Boot a single worker for custom devices
2514         https://bugs.webkit.org/show_bug.cgi?id=191312
2515         <rdar://problem/45848717>
2516
2517         Rubber-stamped by Aakash Jain.
2518
2519         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2520         (Manager.run): Custom devices only run a hand-full of tests. Booting multiple
2521         simulators is expensive and unneeded for these tests.
2522         * Scripts/webkitpy/port/ios.py:
2523         (IOSPort. child_processes): No reason to memoize this call, and it prevents
2524         overriding the number of child processes when booting custom devices.
2525
2526 2018-11-06  Jonathan Bedard  <jbedard@apple.com>
2527
2528         webkitpy: Generalize trailing SDK specifier (Part 2)
2529         https://bugs.webkit.org/show_bug.cgi?id=191275
2530         <rdar://problem/45703660>
2531
2532         Reviewed by Aakash Jain.
2533
2534         * Scripts/webkitpy/port/ios_device.py:
2535         (IOSDevicePort): Use normalized SDK.
2536         * Scripts/webkitpy/port/ios_simulator.py:
2537         (IOSSimulatorPort): Use normalized SDK.
2538         (IOSSimulatorPort._build_driver_flags): Use platform SDK in build driver flags.
2539
2540 2018-11-06  Justin Fan  <justin_fan@apple.com>
2541
2542         [WebGPU] Experimental prototype for WebGPURenderPipeline and WebGPUSwapChain
2543         https://bugs.webkit.org/show_bug.cgi?id=191291
2544
2545         Reviewed by Myles Maxfield.
2546
2547         Properly disable WEBGPU on all non-Metal platforms for now.
2548
2549         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2550
2551 2018-11-06  Aakash Jain  <aakash_jain@apple.com>
2552
2553         [ews-app] Add URL configuration for OpenSource EWS Django app
2554         https://bugs.webkit.org/show_bug.cgi?id=191132
2555
2556         Rubber-stamped by Lucas Forschler.
2557
2558         * BuildSlaveSupport/ews-app/ews-app/urls.py: Added entry for ews.urls.
2559         * BuildSlaveSupport/ews-app/ews/urls.py: Added.
2560
2561 2018-11-06  Youenn Fablet  <youenn@apple.com>
2562
2563         Make mDNS ICE Candidate an experimental flag again
2564         https://bugs.webkit.org/show_bug.cgi?id=191262
2565
2566         Reviewed by Dean Jackson.
2567
2568         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2569         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2570         (WTR::TestRunner::setWebRTCMDNSICECandidatesEnabled):
2571         (WTR::TestRunner::setMDNSICECandidatesEnabled): Deleted.
2572         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2573
2574 2018-11-06  Aakash Jain  <aakash_jain@apple.com>
2575
2576         [ews-app] Add views for OpenSource EWS Django app
2577         https://bugs.webkit.org/show_bug.cgi?id=191131
2578
2579         Rubber-stamped by Lucas Forschler.
2580
2581         * BuildSlaveSupport/ews-app/ews/views/index.py: Added.
2582         * BuildSlaveSupport/ews-app/ews/views/patch.py:
2583         * BuildSlaveSupport/ews-app/ews/views/results.py: Added.
2584         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py: Added.
2585
2586 2018-11-06  Aakash Jain  <aakash_jain@apple.com>
2587
2588         [ews-app] Add models for OpenSource EWS Django app
2589         https://bugs.webkit.org/show_bug.cgi?id=191123
2590
2591         Reviewed by Lucas Forschler.
2592
2593         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
2594         * BuildSlaveSupport/ews-app/ews/models/buildermappings.py: Added.
2595         * BuildSlaveSupport/ews-app/ews/models/builds.py: Added.
2596         * BuildSlaveSupport/ews-app/ews/models/patch.py:
2597         * BuildSlaveSupport/ews-app/ews/models/steps.py: Added.
2598
2599 2018-11-06  Aakash Jain  <aakash_jain@apple.com>
2600
2601         [ews-app] Fix Invalid HTTP_HOST header
2602         https://bugs.webkit.org/show_bug.cgi?id=191325
2603
2604         Reviewed by Lucas Forschler.
2605
2606         Changing ALLOWED_HOSTS to * as the landing page should be publicly accessible.
2607
2608         * BuildSlaveSupport/ews-app/ews-app/settings.py:
2609
2610 2018-11-06  Aakash Jain  <aakash_jain@apple.com>
2611
2612         [ews-app] Rename EWS_app to ews-app - part 2
2613         https://bugs.webkit.org/show_bug.cgi?id=191317
2614
2615         Reviewed by Lucas Forschler.
2616
2617         * BuildSlaveSupport/ews-app/EWS_app: Removed.
2618         * BuildSlaveSupport/ews-app/ews-app: Moved from BuildSlaveSupport/ews-app/EWS_app.
2619         * BuildSlaveSupport/ews-app/ews-app/settings.py:
2620         * BuildSlaveSupport/ews-app/ews-app/urls.py:
2621         * BuildSlaveSupport/ews-app/ews-app/wsgi.py:
2622         * BuildSlaveSupport/ews-app/manage.py:
2623
2624 2018-11-06  Aakash Jain  <aakash_jain@apple.com>
2625
2626         [ews-app] Rename EWS_app to ews-app - part 1
2627         https://bugs.webkit.org/show_bug.cgi?id=191317
2628
2629         Reviewed by Lucas Forschler.
2630
2631         * BuildSlaveSupport/EWS_app: Removed.
2632         * BuildSlaveSupport/ews-app: Moved from BuildSlaveSupport/EWS_app.
2633
2634 2018-11-06  Myles C. Maxfield  <mmaxfield@apple.com>
2635
2636         Spelling dots are drawn in the wrong place
2637         https://bugs.webkit.org/show_bug.cgi?id=190764
2638
2639         Reviewed by Dean Jackson.
2640
2641         Previously, it was impossible for WebKitTestRunner to draw spelling dots. This patch adds support for a header
2642         at the top of test files, of the form <!-- webkit-test-runner [ spellCheckingDots=true ] --> which will cause
2643         dots to be drawn.
2644
2645         * WebKitTestRunner/TestController.cpp:
2646         (WTR::TestController::resetStateToConsistentValues):
2647         (WTR::updateTestOptionsFromTestHeader):
2648         (WTR::TestController::platformResetStateToConsistentValues):
2649         * WebKitTestRunner/TestController.h:
2650         * WebKitTestRunner/TestOptions.h:
2651         (WTR::TestOptions::hasSameInitializationOptions const):
2652         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2653         (WTR::TestController::cocoaResetStateToConsistentValues):
2654         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2655         * WebKitTestRunner/ios/TestControllerIOS.mm:
2656         (WTR::TestController::platformResetStateToConsistentValues):
2657         * WebKitTestRunner/mac/TestControllerMac.mm:
2658         (WTR::TestController::platformResetStateToConsistentValues):
2659
2660 2018-11-06  Don Olmstead  <don.olmstead@sony.com>
2661
2662         Feature flags not present for Visual Studio when using build-webkit
2663         https://bugs.webkit.org/show_bug.cgi?id=191288
2664
2665         Reviewed by Fujii Hironori.
2666
2667         Passes feature flags to Visual studio builds within build-webkit.
2668         Removes cmakeBasedPortArguments as it is no longer in use.
2669
2670         * Scripts/build-jsc:
2671         * Scripts/build-webkit:
2672         * Scripts/webkitdirs.pm:
2673         (cmakeBasedPortArguments): Deleted.
2674
2675 2018-11-06  Per Arne Vollan  <pvollan@apple.com>
2676
2677         REGRESSION (r230523): Caps lock indicator not shown in password field
2678         https://bugs.webkit.org/show_bug.cgi?id=190056
2679
2680         Reviewed by Ryosuke Niwa.
2681
2682         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2683         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2684         (WTR::TestRunner::toggleCapsLock):
2685         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2686         * WebKitTestRunner/TestController.h:
2687         * WebKitTestRunner/TestInvocation.cpp:
2688         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2689         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2690         (WTR::TestController::toggleCapsLock):
2691
2692 2018-11-06  Sihui Liu  <sihui_liu@apple.com>
2693
2694         IndexedDB: WAL file keeps growing
2695         https://bugs.webkit.org/show_bug.cgi?id=191294
2696         <rdar://problem/41333493>
2697
2698         Reviewed by Chris Dumez.
2699
2700         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2701         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize-1.html: Added.
2702         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize-2.html: Added.
2703         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm: Added.
2704         (-[IndexedDBFileSizeMessageHandler userContentController:didReceiveScriptMessage:]):
2705         (TEST):
2706
2707 2018-11-06  Alex Christensen  <achristensen@webkit.org>
2708
2709         Fix tests after r237863
2710         https://bugs.webkit.org/show_bug.cgi?id=191315
2711
2712         Reviewed by Chris Dumez.
2713
2714         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2715         With the timing change of r237863, the WKWebView progressed further than before when loading main.html so it completed before main2.html.
2716         This test was meant to test that main2.html does eventually load, and it doesn't matter if main.html loads before it.  I updated the test
2717         to verify that main2.html eventually loads, making this test less timing dependent.
2718
2719 2018-11-06  Ryan Haddad  <ryanhaddad@apple.com>
2720
2721         Unreviewed, rolling out r237834.
2722
2723         Tests for this change crash on iOS Simulator
2724
2725         Reverted changeset:
2726
2727         "Spelling dots are drawn in the wrong place"
2728         https://bugs.webkit.org/show_bug.cgi?id=190764
2729         https://trac.webkit.org/changeset/237834
2730
2731 2018-11-05  Alex Christensen  <achristensen@webkit.org>
2732
2733         [Mac] Implement safe browsing in WebKit
2734         https://bugs.webkit.org/show_bug.cgi?id=188871
2735
2736         Reviewed by Tim Horton.
2737
2738         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2739         (-[SafeBrowsingNavigationDelegate webView:didCommitNavigation:]):
2740         (+[TestServiceLookupResult resultWithProvider:phishing:malware:unwantedSoftware:]):
2741         (-[TestLookupContext lookUpURL:completionHandler:]):
2742         (simpleURL):
2743         (safeBrowsingView):
2744         (TEST):
2745         (-[SafeBrowsingNavigationDelegate webView:didFinishNavigation:]): Deleted.
2746         (+[TestServiceLookupResult resultWithProvider:phishing:malware:unwantedSoftware:knownToBeUnsafe:]): Deleted.
2747         (-[TestServiceLookupResult isKnownToBeUnsafe]): Deleted.
2748         * TestWebKitAPI/Utilities.h:
2749
2750 2018-11-05  Jonathan Bedard  <jbedard@apple.com>
2751
2752         webkitpy: Generalize trailing SDK specifier (Part 1)
2753         https://bugs.webkit.org/show_bug.cgi?id=191275
2754         <rdar://problem/45703660>
2755
2756         Reviewed by Lucas Forschler.
2757
2758         * Scripts/webkitpy/common/system/platforminfo.py:
2759         (PlatformInfo.available_sdks): List all installed SDKs with version numbers stripped out.
2760         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
2761         (TestPlatformInfo):
2762         (TestPlatformInfo.test_available_sdks):
2763
2764 2018-11-05  Myles C. Maxfield  <mmaxfield@apple.com>
2765
2766         Spelling dots are drawn in the wrong place
2767         https://bugs.webkit.org/show_bug.cgi?id=190764
2768
2769         Reviewed by Dean Jackson.
2770
2771         Previously, it was impossible for WebKitTestRunner to draw spelling dots. This patch adds support for a header
2772         at the top of test files, of the form <!-- webkit-test-runner [ spellCheckingDots=true ] --> which will cause
2773         dots to be drawn.
2774
2775         * WebKitTestRunner/TestController.cpp:
2776         (WTR::TestController::resetStateToConsistentValues):
2777         (WTR::updateTestOptionsFromTestHeader):
2778         (WTR::TestController::platformResetStateToConsistentValues):
2779         * WebKitTestRunner/TestController.h:
2780         * WebKitTestRunner/TestOptions.h:
2781         (WTR::TestOptions::hasSameInitializationOptions const):
2782         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2783         (WTR::TestController::cocoaResetStateToConsistentValues):
2784         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2785         * WebKitTestRunner/ios/TestControllerIOS.mm:
2786         (WTR::TestController::platformResetStateToConsistentValues):
2787         * WebKitTestRunner/mac/TestControllerMac.mm:
2788         (WTR::TestController::platformResetStateToConsistentValues):
2789
2790 2018-11-05  Chris Dumez  <cdumez@apple.com>
2791
2792         Use same limit for page cache and suspended pages
2793         https://bugs.webkit.org/show_bug.cgi?id=191266
2794
2795         Reviewed by Geoffrey Garen.
2796
2797         Update API tests accordingly.
2798
2799         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2800
2801 2018-11-05  Basuke Suzuki  <Basuke.Suzuki@sony.com>
2802
2803         [style] Exclude style check for auto generated files.
2804         https://bugs.webkit.org/show_bug.cgi?id=191118
2805
2806         Reviewed by Eric Carlson.
2807
2808         Some files checked in to the repository are generated by other tools. In this patch,
2809         "MiniBrowserLibResource.h" is the file generated and managed by resource editor of
2810         VisualStudio.
2811
2812         There's no need to check these files because it's not practical to fix the style errors
2813         or it's hard to maintain those fixes.
2814
2815         * Scripts/webkitpy/style/checkers/cpp.py:
2816         (is_generated_file):
2817         (CppChecker.check):
2818
2819 2018-11-05  Thibault Saunier  <tsaunier@igalia.com>
2820
2821         [Flatpak] Build libx264 as it is the h264 encoder we support in WebRTC
2822         https://bugs.webkit.org/show_bug.cgi?id=190680
2823
2824         Reviewed by Philippe Normand.
2825
2826         * flatpak/org.webkit.WebKit.yaml:
2827
2828 2018-11-05  Daniel Bates  <dabates@apple.com>
2829
2830         [lldb-webkit] Fix formatting nits in Document and Frame summary strings
2831         https://bugs.webkit.org/show_bug.cgi?id=191094
2832
2833         Reviewed by Andy Estes.
2834
2835         Format boolean as 1/0 when printing Frame summary to be consistent with the formatting of
2836         booleans in other summary strings, substitute "inMainFrame" for "isMainFrame" in the printed
2837         Document summary and add closing brace '}' to both Frame and Document summary strings to make
2838         them look pretty.
2839
2840         * lldb/lldb_webkit.py:
2841         (WebCoreFrame_SummaryProvider):
2842         (WebCoreDocument_SummaryProvider):
2843
2844 2018-11-05  Wenson Hsieh  <wenson_hsieh@apple.com>
2845
2846         [iOS] Allow WKWebView clients to customize bar button item groups in the accessory view when editing
2847         https://bugs.webkit.org/show_bug.cgi?id=191240
2848         <rdar://problem/44872806>
2849
2850         Reviewed by Tim Horton.
2851
2852         Add new API tests to verify that setting leading and trailing bar button groups on WKWebView sets the first
2853         responder's (i.e. WKContentView's) leading and trailing bar button groups, and that this can also be achieved by
2854         overriding `-[WKWebView inputAssistantItem]`.
2855
2856         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2857         (-[InputAssistantItemTestingWebView fakeLeadingBarButtonItemAction]):
2858         (-[InputAssistantItemTestingWebView fakeTrailingBarButtonItemAction]):
2859         (+[InputAssistantItemTestingWebView barButtonIcon]):
2860         (+[InputAssistantItemTestingWebView leadingItemsForWebView:]):
2861         (+[InputAssistantItemTestingWebView trailingItemsForWebView:]):
2862         (-[InputAssistantItemTestingWebView inputAssistantItem]):
2863         (TestWebKitAPI::TEST):
2864
2865 2018-11-05  Wenson Hsieh  <wenson_hsieh@apple.com>
2866
2867         [iOS] Changing view scale sometimes does not zoom the page to the new initial scale when the page is zoomed in when ignoring meta viewport
2868         https://bugs.webkit.org/show_bug.cgi?id=191226
2869         <rdar://problem/45781765>
2870
2871         Reviewed by Tim Horton.
2872
2873         Add a missing check for `shouldIgnoreMetaViewport` when comparing TestOptions, to ensure that "ignore meta
2874         viewport" state doesn't unexpectedly persist after running a layout test that ignores meta viewport.
2875
2876         * WebKitTestRunner/TestOptions.h:
2877         (WTR::TestOptions::hasSameInitializationOptions const):
2878
2879 2018-11-05  Commit Queue  <commit-queue@webkit.org>
2880
2881         Unreviewed, rolling out r237784 and r237788.
2882         https://bugs.webkit.org/show_bug.cgi?id=191270
2883
2884         Caused mediastream layout test failures (Requested by
2885         ryanhaddad on #webkit).
2886
2887         Reverted changesets:
2888
2889         "[MediaStream] User should not be prompted again after denying
2890         getDisplayMedia request"
2891         https://bugs.webkit.org/show_bug.cgi?id=191227
2892         https://trac.webkit.org/changeset/237784
2893
2894         "[MediaStream] User should not be prompted again after denying
2895         getDisplayMedia request"
2896         https://bugs.webkit.org/show_bug.cgi?id=191227
2897         https://trac.webkit.org/changeset/237788
2898
2899 2018-11-05  Lucas Forschler  <lforschler@apple.com>
2900
2901         https://bugs.webkit.org/show_bug.cgi?id=191268
2902         Remove unused bots.
2903
2904         rubber-stamped by Alexey Proskuryakov.
2905
2906         * BuildSlaveSupport/build.webkit.org-config/config.json:
2907         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2908         (WebKitBuildbot):
2909
2910 2018-11-05  Michael Catanzaro  <mcatanzaro@igalia.com>
2911
2912         [WPE][GTK] API test runner fails to respect default build type
2913         https://bugs.webkit.org/show_bug.cgi?id=190247
2914
2915         Reviewed by Carlos Garcia Campos.
2916
2917         Problem is it's looking for a release build, even though I've run set-webkit-configuration
2918         --debug. It should look for a debug build unless I explicitly pass --release.
2919
2920         * glib/api_test_runner.py:
2921         (TestRunner.__init__):
2922
2923 2018-11-05  Thibault Saunier  <tsaunier@igalia.com>
2924
2925         [GStreamer][WebRTC] Add webrtcencoder bin to cleanup and refactor the way we set encoders
2926         https://bugs.webkit.org/show_bug.cgi?id=190674
2927
2928         Reviewed by Philippe Normand.
2929
2930         webrtcencoder is a simple GstBin with a set of well known GStreamer encoders which
2931         it can use to implement encoding for different formats exposing a trimmed down unified API.
2932
2933         It also adds proper handling of H264 profiles.
2934
2935         The added files follow GStreamer coding style as we aim at upstreaming the element
2936         in the future.
2937
2938         Reviewed by Philippe Normand.
2939
2940         * Scripts/webkitpy/style/checker.py:
2941
2942 2018-11-05  Michael Catanzaro  <mcatanzaro@igalia.com>
2943
2944         [WPE][GTK] API test /webkit/WebKitSettings/webkit-settings is failing
2945         https://bugs.webkit.org/show_bug.cgi?id=191221
2946
2947         Reviewed by Carlos Garcia Campos.
2948
2949         This test ensures that MSE is disabled by default, but we now enable it by default, so
2950         reverse the semantics of the test.
2951
2952         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2953         (testWebKitSettings):
2954
2955 2018-11-05  Michael Catanzaro  <mcatanzaro@igalia.com>
2956
2957         REGRESSION(r237031): [GTK] Test /webkit/WebKitWebView/settings is failing
2958         https://bugs.webkit.org/show_bug.cgi?id=191225
2959
2960         Reviewed by Alejandro G. Castro.
2961
2962         Fix a memory leak causing this test to fail.
2963
2964         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
2965         (WebViewTest::initializeWebView):
2966
2967 2018-11-04  Zan Dobersek  <zdobersek@igalia.com>
2968
2969         [webkitpy] Support WPE in the run-web-platform-tests script
2970         https://bugs.webkit.org/show_bug.cgi?id=191183
2971
2972         Reviewed by Alex Christensen.
2973
2974         * Scripts/webkitpy/w3c/wpt_runner.py:
2975         (parse_args): Support `--wpe` as an argument that specifies WPE as the
2976         target port. Additionally, the `--display-server` flag now accepts
2977         `headless` as a valid value, enabling the WPE WebDriver to run in
2978         headless mode.
2979
2980 2018-11-04  Fujii Hironori  <Hironori.Fujii@sony.com>
2981
2982         [Win] Use C++14, not C++17
2983         https://bugs.webkit.org/show_bug.cgi?id=191101
2984
2985         Reviewed by Alex Christensen.
2986
2987         std::basic_string::data() returns a read-only const buffer in
2988         C++14.
2989
2990         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2991         (createString): Use std::vector instead of std::wstring.
2992         (createUTF8String): Use std::vector instead of std::string.
2993
2994 2018-11-04  Wenson Hsieh  <wenson_hsieh@apple.com>
2995
2996         [Cocoa] Fold common UIScriptController functionality on macOS and iOS into UIScriptControllerCocoa.mm
2997         https://bugs.webkit.org/show_bug.cgi?id=191231
2998
2999         Reviewed by Simon Fraser.
3000
3001         Moves some UIScriptController method implementations specific to iOS and macOS into UIScriptControllerCocoa, so
3002         it can be shared between iOS-family and macOS platforms. See below for more details.
3003
3004         No change in behavior.
3005
3006         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3007         (WTR::UIScriptController::overridePreference):
3008
3009         Add a method stub for DumpRenderTree.
3010
3011         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3012         * WebKitTestRunner/UIScriptControllerCocoa.mm:
3013         (WTR::UIScriptController::doAsyncTask):
3014         (WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution):
3015
3016         Unify these method implementations.
3017
3018         (WTR::UIScriptController::removeViewFromWindow):
3019         (WTR::UIScriptController::addViewToWindow):
3020
3021         Move the macOS implementation to UIScriptControllerCocoa. On iOS, this method currently only adds the web view
3022         to the window, and does not attempt to invoke the given completion block; additionally, invoking the completion
3023         block after a presentation update (as done on macOS) causes pageoverlay/overlay-remove-reinsert-view.html to
3024         begin failing consistently. This patch does not attempt to change behavior, but adds a FIXME describing this.
3025
3026         (WTR::UIScriptController::overridePreference):
3027         (WTR::UIScriptController::findString):
3028         (WTR::UIScriptController::contentsOfUserInterfaceItem const):
3029
3030         Move these from UIScriptControllerMac to UIScriptControllerCocoa, so that it is now implemented on iOS as well.
3031
3032         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3033         (WTR::UIScriptController::doAsyncTask): Deleted.
3034         (WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution): Deleted.
3035         (WTR::UIScriptController::contentsOfUserInterfaceItem const): Deleted.
3036         (WTR::UIScriptController::findString): Deleted.
3037         (WTR::UIScriptController::removeViewFromWindow): Deleted.
3038         (WTR::UIScriptController::addViewToWindow): Deleted.
3039         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
3040         (WTR::UIScriptController::doAsyncTask): Deleted.
3041         (WTR::UIScriptController::contentsOfUserInterfaceItem const): Deleted.
3042         (WTR::UIScriptController::overridePreference): Deleted.
3043         (WTR::UIScriptController::findString): Deleted.
3044         (WTR::UIScriptController::removeViewFromWindow): Deleted.
3045         (WTR::UIScriptController::addViewToWindow): Deleted.
3046         (WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution): Deleted.
3047
3048 2018-11-04  Eric Carlson  <eric.carlson@apple.com>
3049
3050         [MediaStream] User should not be prompted again after denying getDisplayMedia request
3051         https://bugs.webkit.org/show_bug.cgi?id=191227
3052         <rdar://problem/45784512>
3053
3054         Reviewed by Youenn Fablet.
3055
3056         * TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm:
3057         (-[GetDisplayMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
3058         (TestWebKitAPI::GetDisplayMediaTest::promptForCapture):
3059         (TestWebKitAPI::TEST_F):
3060
3061 2018-11-04  Zalan Bujtas  <zalan@apple.com>
3062
3063         [LFC][BFC] Add support for percentage height in quirks mode.
3064         https://bugs.webkit.org/show_bug.cgi?id=191232
3065
3066         Reviewed by Antti Koivisto.
3067
3068         * LayoutReloaded/misc/LFC-passing-tests.txt:
3069
3070 2018-11-04  Zalan Bujtas  <zalan@apple.com>
3071
3072         [LFC][BCF] Add support for block level non-replaced inflow height percentage
3073         https://bugs.webkit.org/show_bug.cgi?id=191229
3074
3075         Reviewed by Antti Koivisto.
3076
3077         * LayoutReloaded/misc/LFC-passing-tests.txt:
3078
3079 2018-11-02  Zalan Bujtas  <zalan@apple.com>
3080
3081         [LFC][BFC] Resolve percentage height values.
3082         https://bugs.webkit.org/show_bug.cgi?id=191224
3083
3084         Reviewed by Antti Koivisto.
3085
3086         * LayoutReloaded/misc/LFC-passing-tests.txt:
3087
3088 2018-11-03  Alex Christensen  <achristensen@webkit.org>
3089
3090         Mac production builds should sign the network process xpc service with entitlements
3091         https://bugs.webkit.org/show_bug.cgi?id=191209
3092         <rdar://problem/45377609>
3093
3094         Reviewed by Geoff Garen.
3095
3096         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3097         * TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm: Added.
3098         (TEST):
3099
3100 2018-11-02  Alex Christensen  <achristensen@webkit.org>
3101
3102         Unreviewed, rolling out r237761.
3103
3104         Makes most API tests timeout and WK2 tests crash
3105
3106         Reverted changeset:
3107
3108         "Mac production builds should sign the network process xpc
3109         service with entitlements"
3110         https://bugs.webkit.org/show_bug.cgi?id=191209
3111         https://trac.webkit.org/changeset/237761
3112
3113 2018-11-02  Michael Catanzaro  <mcatanzaro@igalia.com>
3114
3115         Unreviewed API test gardening
3116
3117         * TestWebKitAPI/glib/TestExpectations.json:
3118
3119 2018-11-02  Justin Michaud  <justin_michaud@apple.com>
3120
3121         Add new global object and preliminary Worklets support for CSS painting api
3122         https://bugs.webkit.org/show_bug.cgi?id=190979
3123
3124         Reviewed by Chris Dumez.
3125
3126         * Scripts/webkitpy/bindings/main.py:
3127         (BindingsTests.generate_supplemental_dependency):
3128         (BindingsTests.main):
3129
3130 2018-11-02  Alex Christensen  <achristensen@webkit.org>
3131
3132         Mac production builds should sign the network process xpc service with entitlements
3133         https://bugs.webkit.org/show_bug.cgi?id=191209
3134         <rdar://problem/45377609>
3135
3136         Reviewed by Geoff Garen.
3137
3138         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3139         * TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm: Added.
3140         (TEST):
3141
3142 2018-11-02  Lucas Forschler  <lforschler@apple.com>
3143
3144         Add Windows 10 archive bots
3145         https://bugs.webkit.org/show_bug.cgi?id=190964
3146         
3147         This Change updates the Apple Windows Buildbot configuration.
3148         - Add Windows 10 specific builders and testers for release and debug.
3149         - Refactor Windows -> Windows 7.
3150         - Remove Windows 7 Debug.
3151
3152         Reviewed by Aakash Jain.
3153
3154         * BuildSlaveSupport/build.webkit.org-config/config.json:
3155
3156 2018-11-02  Philippe Normand  <pnormand@igalia.com>
3157
3158         [GTK][WPE] Enable GST_DEBUG_NO_COLOR environment variable pass-through
3159
3160         Rubber-stamped by Michael Catanzaro.
3161
3162         This variable is useful to get rid of shell color escapes in tests stderr files.
3163
3164         * Scripts/webkitpy/port/gtk.py:
3165         (GtkPort.setup_environ_for_server):
3166         * Scripts/webkitpy/port/wpe.py:
3167         (WPEPort.setup_environ_for_server):
3168
3169 2018-11-02  Aakash Jain  <aakash_jain@apple.com>
3170
3171         Add Basic Django web app for OpenSource EWS
3172         https://bugs.webkit.org/show_bug.cgi?id=191091
3173
3174         Reviewed by Lucas Forschler.
3175
3176         * BuildSlaveSupport/EWS_app/manage.py: Added, auto-generated by Django.
3177         * BuildSlaveSupport/EWS_app/EWS_app/__init__.py: Added, auto-generated by Django.
3178         * BuildSlaveSupport/EWS_app/EWS_app/settings.py: Added, auto-generated by Django.
3179         * BuildSlaveSupport/EWS_app/EWS_app/urls.py: Added, auto-generated by Django.
3180         * BuildSlaveSupport/EWS_app/EWS_app/wsgi.py: Added, auto-generated by Django.
3181         * BuildSlaveSupport/EWS_app/ews/__init__.py: Added.
3182         * BuildSlaveSupport/EWS_app/ews/admin.py: Added, auto-generated by Django.
3183         * BuildSlaveSupport/EWS_app/ews/apps.py: Added, auto-generated by Django.
3184         * BuildSlaveSupport/EWS_app/ews/migrations/__init__.py: Added.
3185         * BuildSlaveSupport/EWS_app/ews/tests.py: Added, auto-generated by Django.
3186         * BuildSlaveSupport/EWS_app/ews/models/__init__.py: Added.
3187         * BuildSlaveSupport/EWS_app/ews/models/patch.py: Added.
3188         * BuildSlaveSupport/EWS_app/ews/views/__init__.py: Added.
3189         * BuildSlaveSupport/EWS_app/ews/views/patch.py: Added.
3190
3191 2018-11-02  Daniel Bates  <dabates@apple.com>
3192
3193         [iOS] WebKit should dispatch DOM events when a modifier key is pressed
3194         https://bugs.webkit.org/show_bug.cgi?id=190487
3195
3196         Reviewed by Tim Horton.
3197
3198         Update the code for renamed enumerations. For WebKitTestRunner, removed comment that does not
3199         match my observations when using the simulator to simulate iOS 12 and add support for testing
3200         right-hand side modifiers.
3201
3202         * DumpRenderTree/mac/EventSendingController.mm:
3203         (modifierFlags):
3204         (-[EventSendingController keyDown:withModifiers:withLocation:]):
3205         (-[EventSendingController setTouchModifier:value:]):
3206         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3207         (hidUsageCodeForCharacter):
3208
3209 2018-11-02  Chris Dumez  <cdumez@apple.com>
3210
3211         [PSON] Reuse SuspendedPages' process when possible, for performance
3212         https://bugs.webkit.org/show_bug.cgi?id=191166
3213
3214         Reviewed by Geoffrey Garen.
3215
3216         Add API test coverage.
3217
3218         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3219
3220 2018-11-02  Zalan Bujtas  <zalan@apple.com>
3221
3222         [LFC][IFC] Add support for intrinsic width calculation
3223         https://bugs.webkit.org/show_bug.cgi?id=191144
3224
3225         Reviewed by Antti Koivisto.
3226
3227         * LayoutReloaded/misc/LFC-passing-tests.txt:
3228
3229 2018-11-01  Philippe Normand  <pnormand@igalia.com>
3230
3231         [Apache] Self-signed SSL certificate RSA key is considered too weak
3232         https://bugs.webkit.org/show_bug.cgi?id=191156
3233
3234         Reviewed by Michael Catanzaro.
3235
3236         * Scripts/webkitpy/common/system/pemfile.py:
3237
3238 2018-11-02  Zan Dobersek  <zdobersek@igalia.com>
3239
3240         Unreviewed follow-up to r237678.
3241
3242         * wpe/jhbuild.modules: The patch element apparently has to be a child
3243         of the branch in order for Jhbuild to properly detect and apply the
3244         patch file.
3245
3246 2018-11-01  Ross Kirsling  <ross.kirsling@sony.com>
3247
3248         build-jsc --wincairo should update WinCairo libraries
3249         https://bugs.webkit.org/show_bug.cgi?id=191170
3250
3251         Reviewed by Fujii Hironori.
3252
3253         * Scripts/build-jsc:
3254
3255 2018-11-01  John Wilander  <wilander@apple.com>
3256
3257         In WebCore::ResourceLoadObserver, use document.sessionID().isEphemeral() when possible and check for page existence when not
3258         https://bugs.webkit.org/show_bug.cgi?id=191119
3259         <rdar://problem/44176965>
3260
3261         Reviewed by Chris Dumez.
3262
3263         This is an API test for a WebKitLegacy WebView that is first closed and then
3264         JavaScript is handed a keyboard event.
3265
3266         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3267         * TestWebKitAPI/Tests/WebKitLegacy/mac/ClosingWebView.mm: Added.
3268         (-[ClosingWebViewThenSendingItAKeyDownEventLoadDelegate webView:didFinishLoadForFrame:]):
3269         (-[KeyboardEventListener handleEvent:]):
3270         (TestWebKitAPI::TEST):
3271
3272 2018-11-01  Sihui Liu  <sihui_liu@apple.com>
3273
3274         Add a storage limit for IndexedDB
3275         https://bugs.webkit.org/show_bug.cgi?id=190598
3276         <rdar://problem/44654715>
3277
3278         Reviewed by Chris Dumez.
3279
3280         Add API for testing.
3281
3282         * DumpRenderTree/TestRunner.cpp:
3283         (setIDBPerOriginQuotaCallback):
3284         (TestRunner::staticFunctions):
3285         * DumpRenderTree/TestRunner.h:
3286         * DumpRenderTree/mac/TestRunnerMac.mm:
3287         (TestRunner::setIDBPerOriginQuota):
3288         * DumpRenderTree/win/TestRunnerWin.cpp:
3289         (TestRunner::setIDBPerOriginQuota):
3290         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3291         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3292         (WTR::TestRunner::setIDBPerOriginQuota):
3293         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3294         * WebKitTestRunner/TestController.cpp:
3295         (WTR::TestController::setIDBPerOriginQuota):
3296         * WebKitTestRunner/TestController.h:
3297         * WebKitTestRunner/TestInvocation.cpp:
3298         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3299
3300 2018-11-01  Chris Dumez  <cdumez@apple.com>
3301
3302         [PSON] WebPageProxy::receivedNavigationPolicyDecision() should not schedule the new load asynchronously when process-swapping
3303         https://bugs.webkit.org/show_bug.cgi?id=191076
3304
3305         Reviewed by Geoffrey Garen.
3306
3307         Add API test coverage.
3308
3309         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3310         (-[PSONNavigationDelegate init]):
3311         (-[PSONNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3312
3313 2018-11-01  Adrian Perez de Castro  <aperez@igalia.com>
3314
3315         Fix build with VIDEO and WEB_AUDIO disabled
3316         https://bugs.webkit.org/show_bug.cgi?id=191147
3317         <rdar://problem/45726710>
3318
3319         Unreviewed build fix.
3320
3321         This adds the missing compilation guards in the WPE MiniBrowser.
3322
3323         * MiniBrowser/wpe/main.cpp:
3324         (main): Condition GST includes and calls.
3325
3326 2018-10-31  Zalan Bujtas  <zalan@apple.com>
3327
3328         [LFC][IFC] Add support for inline-block elements.
3329         https://bugs.webkit.org/show_bug.cgi?id=191143
3330
3331         Reviewed by Antti Koivisto.
3332
3333         * LayoutReloaded/misc/LFC-passing-tests.txt:
3334
3335 2018-11-01  Claudio Saavedra  <csaavedra@igalia.com>
3336
3337         [WPE] Add missing libsoup patch to jhbuild
3338         https://bugs.webkit.org/show_bug.cgi?id=191149
3339
3340         Reviewed by Žan Doberšek.
3341
3342         * wpe/jhbuild.modules:
3343         * wpe/patches/libsoup-soup-socket-fix-critical-warning-when-the-peer-certi.patch: Added.
3344
3345 2018-11-01  Claudio Saavedra  <csaavedra@igalia.com>
3346
3347         Fix build with VIDEO and WEB_AUDIO disabled
3348         https://bugs.webkit.org/show_bug.cgi?id=191147
3349
3350         Reviewed by Philippe Normand.
3351
3352         * MiniBrowser/gtk/main.c:
3353         (main): Condition GST includes and calls
3354
3355 2018-10-31  Justin Michaud  <justin_michaud@apple.com>
3356
3357         Add Justin Michaud to the list of WebKit Committers
3358         https://bugs.webkit.org/show_bug.cgi?id=191142
3359
3360         * Scripts/webkitpy/common/config/contributors.json:
3361
3362 2018-10-31  Guillaume Emont  <guijemont@igalia.com>
3363
3364         Don't run JIT tests on 32-bit platforms
3365         https://bugs.webkit.org/show_bug.cgi?id=191074
3366
3367         Reviewed by Michael Catanzaro.
3368
3369         * Scripts/run-jsc-stress-tests:
3370
3371 2018-10-30  Wenson Hsieh  <wenson_hsieh@apple.com>
3372
3373         [Cocoa] Attachment dropped from one web view to another is missing its file wrapper
3374         https://bugs.webkit.org/show_bug.cgi?id=190530
3375         <rdar://problem/45232149>
3376
3377         Reviewed by Tim Horton.
3378
3379         Add a test to verify that copying different types of attachments and pasting in a new web view inserts
3380         attachments in the second web view that are backed by _WKAttachment objects, whose NSFileWrappers hold data that
3381         is equivalent to the original file wrappers used to insert attachments in the first web view.
3382
3383         Existing API tests verify that when copying and pasting within a single web view, the pasted attachment element
3384         is still backed by the same NSFileWrapper instance.
3385
3386         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3387         (TestWebKitAPI::TEST):
3388
3389 2018-10-30  Fujii Hironori  <Hironori.Fujii@sony.com>
3390
3391         [Win] Remove obsolete code for Visual Studio Express in webkitdirs.pm
3392         https://bugs.webkit.org/show_bug.cgi?id=190949
3393
3394         Reviewed by Alex Christensen.
3395
3396         Visual Studio 2017 Community is the alternative.
3397
3398         * Scripts/webkitdirs.pm: Remove $willUseVCExpressWhenBuilding variable.
3399         (setupCygwinEnv): Remove obsolete code for Visual Studio Express.
3400         (buildVisualStudioProject): Ditto.
3401         (dieIfWindowsPlatformSDKNotInstalled): Deleted.
3402         (usingVisualStudioExpress): Deleted.
3403
3404 2018-10-30  Fujii Hironori  <Hironori.Fujii@sony.com>
3405
3406         [Win][Direct2D] Support building DumpRenderTree for Direct2D
3407         https://bugs.webkit.org/show_bug.cgi?id=191093
3408         <rdar://problem/45685706>
3409
3410         Unreviewed build fix.
3411
3412         error C2065: 'renderTarget': undeclared identifier
3413
3414         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
3415         (createBitmapContextFromWebView): Restored the previous implementation.
3416
3417 2018-10-30  Don Olmstead  <don.olmstead@sony.com>
3418
3419         [PlayStation] Enable JavaScriptCore
3420         https://bugs.webkit.org/show_bug.cgi?id=191072
3421
3422         Reviewed by Brent Fulgham.
3423
3424         Add platform scripts for building the PlayStation port.
3425         perl Tools/Scripts/build-webkit --playstation
3426
3427         * Scripts/build-webkit:
3428         * Scripts/build-webkittestrunner:
3429         * Scripts/webkitdirs.pm:
3430         (argumentsForConfiguration):
3431         (determineConfigurationProductDir):
3432         (isPlayStation): Added.
3433         (getMSBuildPlatformArgument): Added.
3434         (buildVisualStudioProject):
3435         (wrapperPrefixIfNeeded):
3436         (generateBuildSystemFromCMakeProject):
3437         * TestWebKitAPI/PlatformPlayStation.cmake: Added.
3438
3439 2018-10-30  Brent Fulgham  <bfulgham@apple.com>
3440
3441         [Win][Direct2D] Support building DumpRenderTree for Direct2D
3442         https://bugs.webkit.org/show_bug.cgi?id=191093
3443         <rdar://problem/45685706>
3444
3445         Reviewed by Alex Christensen.
3446
3447         * DumpRenderTree/PixelDumpSupport.cpp: Update for Direct2D use.
3448         * DumpRenderTree/PlatformWin.cmake: Add support for Direct2D build.
3449         * DumpRenderTree/win/PixelDumpSupportDirect2D.cpp: Added.
3450         (pixelDumpSystemFactory): Added.
3451         (printPNG): Create stub.
3452         (computeMD5HashStringForBitmapContext): Ditto.
3453         (dumpBitmap): Ditto.
3454         * DumpRenderTree/win/PixelDumpSupportDirect2D.h: Added.
3455         (BitmapContext::createByAdoptingBitmapAndContext):
3456         (BitmapContext::~BitmapContext):
3457         (BitmapContext::platformContext const):
3458         (BitmapContext::BitmapContext):
3459         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
3460         (createBitmapContextFromWebView): Update to support Direct2D.
3461         * MiniBrowser/win/MiniBrowserReplace.h: Drive-by fix: The old WebKit
3462         logo is no longer available at this location. Switch to the new logo.
3463
3464 2018-10-30  Jonathan Bedard  <jbedard@apple.com>
3465
3466         webkitpy: Support alternate simctl list outputs
3467         https://bugs.webkit.org/show_bug.cgi?id=191090
3468         <rdar://problem/45684255>
3469
3470         Rubber-stamped by Aakash Jain.
3471
3472         * Scripts/webkitpy/xcode/simulated_device.py:
3473         (SimulatedDeviceManager._create_runtimes): Support alternative availability format.
3474         (SimulatedDeviceManager._create_device_with_runtime): Ditto.
3475         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
3476         (test_available_devices): Add iOS 12 with alternative availability format.
3477
3478 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
3479
3480         Clean up some obsolete MAX_ALLOWED macros
3481         https://bugs.webkit.org/show_bug.cgi?id=190916
3482
3483         Reviewed by Tim Horton.
3484
3485         * TestWebKitAPI/Tests/WTF/darwin/WeakLinking.cpp:
3486         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
3487         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3488
3489 2018-10-30  Claudio Saavedra  <csaavedra@igalia.com>
3490
3491         [GTK][WPE] Fixes to the PublicSuffix implementation
3492         https://bugs.webkit.org/show_bug.cgi?id=191031
3493
3494         Reviewed by Michael Catanzaro.
3495
3496         * TestWebKitAPI/Tests/WebCore/PublicSuffix.cpp:
3497         (TestWebKitAPI::TEST_F): Remove a test for a domain
3498         that is not registrable and shouldn't be tested there.
3499
3500 2018-10-29  Tim Horton  <timothy_horton@apple.com>
3501
3502         Modernize WebKit nibs and lprojs for localization's sake
3503         https://bugs.webkit.org/show_bug.cgi?id=190911
3504         <rdar://problem/45349466>
3505
3506         Reviewed by Dan Bernstein.
3507
3508         * Scripts/check-inspector-strings:
3509         * Scripts/update-webkit-localizable-strings:
3510         * gtk/manifest.txt.in:
3511         * wpe/manifest.txt.in:
3512         English->en
3513
3514 2018-10-29  Daniel Bates  <dabates@apple.com>
3515
3516         [lldb-webkit] Last aliased enumerator in OptionSet is printed; should print first enumerator
3517         https://bugs.webkit.org/show_bug.cgi?id=191036
3518
3519         Reviewed by Andy Estes.
3520
3521         Prefer the first enumerator (in parse order) when pretty-printing an OptionSet that is parameterized
3522         by an enum that contains two or more enumerators with the same value. For example, suppose
3523         you have the following enum:
3524
3525         enum Flag {
3526             A = 1 << 0,
3527             AAlias = A,
3528         };
3529
3530         Then pretty-printing OptionSet<Flag>(Flag::A) should print A instead of AAlias. A side effect of
3531         this change is that OptionSet<Flag>(Flag::AAlias) will also print A as its only member as we cannot
3532         differentiate between A and Alias. This should be acceptable in practice as aliased enumerators
3533         tend to be used in bounds checks as opposed to code that adds to a set.
3534
3535         * lldb/lldbWebKitTester/main.cpp:
3536         (testSummaryProviders):
3537         * lldb/lldb_webkit.py:
3538         (WTFOptionSetProvider.update):
3539         * lldb/lldb_webkit_unittest.py:
3540         (TestSummaryProviders.serial_test_WTFOptionSetProvider_simple):
3541         (TestSummaryProviders):
3542         (TestSummaryProviders.serial_test_WTFOptionSetProvider_aliased_flag):
3543
3544 2018-10-29  Daniel Bates  <dabates@apple.com>
3545
3546         [llbd-webkit] Add summaries for Document, Frame, and SecurityOrigin
3547         https://bugs.webkit.org/show_bug.cgi?id=191033
3548
3549         Reviewed by Andy Estes.
3550
3551         For Documents we display its origin, URL, whether it's in the main frame, and its page cache state.
3552         We display the same details in the summary for a Frame because its Document tends to be the most
3553         interesting aspect of it. For SecurityOrigin we display its origin, domain (affects cookie access),
3554         and whether the origin has universal access.
3555
3556         * lldb/lldb_webkit.py:
3557         (__lldb_init_module):
3558         Register new summary providers.
3559
3560         (WebCoreSecurityOrigin_SummaryProvider):
3561         (WebCoreFrame_SummaryProvider):
3562         (WebCoreDocument_SummaryProvider):
3563         Add new summary providers.
3564
3565         (StdOptionalWrapper):
3566         (StdOptionalWrapper.__init__):
3567         (StdOptionalWrapper.has_value):
3568         (StdOptionalWrapper.value):
3569         Convenience data type that provides access to the fields of a std::optional<>.
3570         
3571         (WebCoreSecurityOriginProvider):
3572         (WebCoreSecurityOriginProvider.__init__):
3573         (WebCoreSecurityOriginProvider.is_unique):
3574         (WebCoreSecurityOriginProvider.scheme):
3575         (WebCoreSecurityOriginProvider.host):
3576         (WebCoreSecurityOriginProvider.port):
3577         (WebCoreSecurityOriginProvider.domain):
3578         (WebCoreSecurityOriginProvider.has_universal_access):
3579         (WebCoreSecurityOriginProvider.to_string):
3580         (WebCoreFrameProvider):
3581         (WebCoreFrameProvider.__init__):
3582         (WebCoreFrameProvider.is_main_frame):
3583         (WebCoreFrameProvider.document):
3584         (WebCoreDocumentProvider):
3585         (WebCoreDocumentProvider.__init__):
3586         (WebCoreDocumentProvider.url):
3587         (WebCoreDocumentProvider.origin):
3588         (WebCoreDocumentProvider.page_cache_state):
3589         (WebCoreDocumentProvider.frame):
3590
3591 2018-10-29  Chris Dumez  <cdumez@apple.com>
3592
3593         [PSON] When Safari restores session state after launching, going back and forward does not swap processes
3594         https://bugs.webkit.org/show_bug.cgi?id=190975
3595         <rdar://problem/45059256>
3596
3597         Reviewed by Antti Koivisto.
3598
3599         Add API test coverage.
3600
3601         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3602
3603 2018-10-29  Zalan Bujtas  <zalan@apple.com>
3604
3605         [LFC][IFC] Compute estimated margin top for inline formatting root's ancestors
3606         https://bugs.webkit.org/show_bug.cgi?id=191018
3607
3608         Reviewed by Antti Koivisto.
3609
3610         * LayoutReloaded/misc/LFC-passing-tests.txt:
3611
3612 2018-10-29  Zalan Bujtas  <zalan@apple.com>
3613
3614         [LFC] Add support for inflow non replaced content height when the box is an inline formatting root.
3615         https://bugs.webkit.org/show_bug.cgi?id=191011
3616
3617         Reviewed by Antti Koivisto.
3618
3619         * LayoutReloaded/misc/LFC-passing-tests.txt:
3620
3621 2018-10-29  Zalan Bujtas  <zalan@apple.com>
3622
3623         Missing from r237549
3624
3625         Reviewed by Antti Koivisto.
3626
3627         * LayoutReloaded/misc/LFC-passing-tests.txt:
3628
3629 2018-10-29  Zalan Bujtas  <zalan@apple.com>