[Soup] utilize multipart/x-mixed-replace support recently added to libsoup
[WebKit-https.git] / Tools / ChangeLog
1 2012-12-09  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
2
3         [Soup] utilize multipart/x-mixed-replace support recently added to libsoup
4         https://bugs.webkit.org/show_bug.cgi?id=94515
5
6         Reviewed by Martin Robinson.
7
8         This change requires a very recent libsoup, so update our jhbuild
9         requirements.
10
11         * gtk/jhbuild.modules: depend on soup version that adds the multipart/x-mixed-replace
12         support
13         * efl/jhbuild.modules: ditto
14
15 2012-12-10  Zoltan Nyul  <zoltan.nyul@intel.com>
16
17         Implement testRunner.setViewModeMediaFeature() in WebKitTestRunner
18         https://bugs.webkit.org/show_bug.cgi?id=103886
19
20         Reviewed by Kenneth Rohde Christiansen.
21
22         Implement testRunner.setViewModeMediaFeature() in WebKitTestRunner.
23         This API is required by layout tests.
24
25         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
26         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
27         (WTR::TestRunner::setViewModeMediaFeature):
28         (WTR):
29         * WebKitTestRunner/InjectedBundle/TestRunner.h:
30         (TestRunner):
31
32 2012-12-10  Martin Robinson  <mrobinson@igalia.com>
33
34         [GTK] Bring Harfbuzz-ng support to Gtk
35         https://bugs.webkit.org/show_bug.cgi?id=92098
36
37         Reviewed by Gustavo Noronha Silva.
38
39         Add HarfBuzz dependency.
40
41         * GNUmakefile.am: Add FreeType/HarfBuzz CFLAGS to the WebCore Internals library.
42         * gtk/jhbuild.modules: Add HarfBuzz to the JHbuild and remove Pango, since it
43         should no longer affect layout test results.
44
45 2012-12-10  Simon Hausmann  <simon.hausmann@digia.com>
46
47         [Qt] Use QLibraryInfo::LibraryExecutablesPath unconditionally
48         https://bugs.webkit.org/show_bug.cgi?id=104541
49
50         Reviewed by Jocelyn Turcotte.
51
52         We now depend on a Qt 5 version that is guaranteed to have this API, so we
53         can remove the configure checks for it.
54
55         * qmake/config.tests/libexecdir/libexecdir.cpp: Removed.
56         * qmake/config.tests/libexecdir/libexecdir.pro: Removed.
57         * qmake/mkspecs/features/features.prf:
58
59 2012-12-10  Víctor Manuel Jáquez Leal  <vjaquez@igalia.com>
60
61         REGRESSION(r135863): GtkLauncher --help no longer displays all help options
62         https://bugs.webkit.org/show_bug.cgi?id=104382
63
64         Reviewed by Philippe Normand.
65
66         Remove gst_init() because it steals the GOptionContext.
67         gst_init_get_option_group() already does the initialization job.
68
69         * GtkLauncher/main.c:
70         (main):
71
72 2012-12-10  Zan Dobersek  <zandobersek@gmail.com>
73
74         [GTK][WTR] Implement AccessibilityUIElement::titleUIElement
75         https://bugs.webkit.org/show_bug.cgi?id=102953
76
77         Reviewed by Martin Robinson.
78
79         Implement AccessibilityUIElement::titleUIElement in the ATK backend
80         in the same manner it is implemented in DumpRenderTree. Both implementations
81         are updated to unref the relation set before the final function return
82         rather than at the end of each loop through the relations held in the said
83         relation set.
84
85         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
86         (AccessibilityUIElement::titleUIElement):
87         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
88         (WTR::AccessibilityUIElement::titleUIElement):
89
90 2012-12-10  Martin Robinson  <mrobinson@igalia.com>
91
92         Fix the WebKit2 debug build
93
94         * WebKitTestRunner/TestInvocation.cpp:
95         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Fix a typo of WKStringGetTypeID().
96
97 2012-12-10  Martin Robinson  <mrobinson@igalia.com>
98
99         [WTR] Move text output accumulation to the UIProcess
100         https://bugs.webkit.org/show_bug.cgi?id=104214
101
102         Reviewed by Darin Adler.
103
104         Instead of accumulating text output in the InjectedBundle and then sending it to the UIProcess 
105         once a test is finished, immediately send any text output to the UIProcess. This will allow
106         WebKitTestRunner to output text from the UIProcess as well.
107
108         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: Remove the handling of the text output
109         StringBuilder. Add a method to send output to the UIProcess.
110         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
111         (InjectedBundle):
112         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Change code that appends to the StringBuilder
113         to use the new outputText method.
114         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
115         * WebKitTestRunner/InjectedBundle/TestRunner.cpp: Ditto.
116         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp: Ditto.
117         * WebKitTestRunner/TestInvocation.cpp:
118         (WTR::TestInvocation::TestInvocation): Intialize the StringBuilder.
119         (WTR::TestInvocation::invoke): Clear the StringBuilder when a new tests starts.
120         (WTR::TestInvocation::dumpResults): m_textOutput is a StringBuilder now so the
121         method of printing the text is slightly different.
122         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Handle the new TextOutput
123         message by appending the results to the StringBuilder.
124         * WebKitTestRunner/TestInvocation.h:
125         (TestInvocation): Switch the type of m_textOutput.
126
127 2012-12-10  Mihnea Ovidenie  <mihnea@adobe.com>
128
129         Unreviewed. Adding Mihai Maerean to the list of contributors, working on CSSRegions.
130
131         * Scripts/webkitpy/common/config/committers.py:
132
133 2012-12-10  Joanmarie Diggs  <jdiggs@igalia.com>
134
135         [GTK] accessibility/language-attribute.html is failing
136         https://bugs.webkit.org/show_bug.cgi?id=98369
137
138         Reviewed by Chris Fleizach.
139
140         The test is failing for two reasons: Not exposing the language
141         for accessible objects and AccessibilityUIElement::language() not
142         being implemented.
143
144         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
145         (AccessibilityUIElement::language): Implemented.
146
147 2012-12-10  Joanmarie Diggs  <jdiggs@igalia.com>
148
149         [GTK] accessibility/editable-webarea-context-menu-point.html is failing
150         https://bugs.webkit.org/show_bug.cgi?id=98364
151
152         Reviewed by Chris Fleizach.
153
154         The test is failing because the clickPoint values remain unchanged. The
155         values remain unchanged because ATK lacks a means to keep track of this
156         information.
157
158         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
159         (AccessibilityUIElement::clickPointX): Added comment that ATK doesn't have clickPoint details
160         (AccessibilityUIElement::clickPointY): Added comment that ATK doesn't have clickPoint details
161
162 2012-12-09  Alejandro Piñeiro  <apinheiro@igalia.com>
163
164         [GTK] lack of implemention of AccessibilityUIElementGtk::isSelectable and AccessibilityUIElementGtk::isMultiSelectable
165         https://bugs.webkit.org/show_bug.cgi?id=104481
166
167         Reviewed by Martin Robinson.
168
169         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
170         (AccessibilityUIElement::isSelectable): Implement this by checking
171         the current state of the AtkObject.
172         (AccessibilityUIElement::isMultiSelectable): Implement this by
173         checking the current state of the AtkObject.
174
175 2012-12-09  Joanmarie Diggs  <jdiggs@igalia.com>
176
177         [GTK] accessibility/placeholder.html is failing
178         https://bugs.webkit.org/show_bug.cgi?id=98373
179
180         Reviewed by Martin Robinson.
181
182         The test was failing because the placeholder text was not supported and
183         AccessibilityUIElement::stringAttributeValue() was not implemented.
184
185         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
186         (coreAttributeToAtkAttribute): New convenience method to convert WebCore attribute
187         names into AtkObject attribute names
188         (AccessibilityUIElement::stringAttributeValue): implemented
189
190 2012-12-09  Dan Winship  <danw@gnome.org>
191
192         [GTK] Bump libxml2 requirement in jhbuild.modules
193         https://bugs.webkit.org/show_bug.cgi?id=104477
194
195         Reviewed by Martin Robinson.
196
197         Fedora 18's Apache depends on symbols in libxml2 2.9.0, so the
198         tests won't run if we only have libxml2 2.8.0 installed in the
199         jhbuild root.
200
201         * gtk/jhbuild.modules:
202
203 2012-12-09  Zan Dobersek  <zandobersek@gmail.com>
204
205         Remove testRunner.disableImageLoading()
206         https://bugs.webkit.org/show_bug.cgi?id=98083
207
208         Reviewed by Gustavo Noronha Silva.
209
210         Remove the disableImageLoading methods and callback.
211         No tests use the method anymore and all ports except Wx
212         now support this behavior through overriding the
213         WebKitDisplayImagesKey preference.
214
215         * DumpRenderTree/TestRunner.cpp:
216         (TestRunner::staticFunctions):
217         * DumpRenderTree/TestRunner.h:
218         (TestRunner):
219         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
220         (TestRunner::overridePreference): Add support for overriding the
221         WebKitDisplayImagesKey preference which is now the preferred way
222         of disabling image loading.
223         * DumpRenderTree/efl/TestRunnerEfl.cpp:
224         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
225         * DumpRenderTree/mac/TestRunnerMac.mm:
226         * DumpRenderTree/qt/TestRunnerQt.cpp:
227         * DumpRenderTree/qt/TestRunnerQt.h:
228         (TestRunner):
229         * DumpRenderTree/win/TestRunnerWin.cpp:
230         * DumpRenderTree/wx/TestRunnerWx.cpp:
231
232 2012-12-09  Joanmarie Diggs  <jdiggs@igalia.com>
233
234         [GTK] accessibility/label-for-control-hittest.html is failing
235         https://bugs.webkit.org/show_bug.cgi?id=98368
236
237         Reviewed by Martin Robinson.
238
239         The test was failing because AccessibilityUIElement::elementAtPoint was
240         not implemented.
241
242         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
243         (AccessibilityUIElement::elementAtPoint): implemented
244
245 2012-12-09  Jon Lee  <jonlee@apple.com>
246
247         [WK2] Move button image to injected bundle
248         https://bugs.webkit.org/show_bug.cgi?id=104107
249         <rdar://problem/12813842>
250
251         Reviewed by Simon Fraser.
252
253         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
254         (WTR::InjectedBundlePage::InjectedBundlePage): Update the bundle page UI client.
255
256 2012-12-08  Halton Huo  <halton.huo@intel.com>
257
258         [CMake] Add CMake style checker
259         https://bugs.webkit.org/show_bug.cgi?id=104240
260
261         Reviewed by Eric Seidel.
262
263         The CMake style checker is followed by existing style checkers like cpp, python.
264         Unit test is added as well.
265
266         * Scripts/webkitpy/style/checker.py: Use CMakeChecker CMAKE type files(.cmake or CMakeLists.txt)
267         (FileType):
268         (CheckerDispatcher._file_type):
269         (CheckerDispatcher._create_checker):
270         * Scripts/webkitpy/style/checkers/cmake.py: Added.
271         (CMakeChecker):
272         (CMakeChecker.__init__): 
273         (CMakeChecker.check):
274         (CMakeChecker._process_line):
275         (CMakeChecker._check_trailing_whitespace):
276         (CMakeChecker._check_no_space_cmds):
277         (CMakeChecker._check_one_space_cmds):
278         (CMakeChecker._check_non_lowercase_cmd):
279         (CMakeChecker._check_indent):
280         * Scripts/webkitpy/style/checkers/cmake_unittest.py: Added.
281         (CMakeCheckerTest):
282         (CMakeCheckerTest.test_init):
283         (CMakeCheckerTest.test_init._mock_handle_style_error):
284         (CMakeCheckerTest.test_check):
285         (CMakeCheckerTest.test_check._mock_handle_style_error):
286
287 2012-12-08  Kondapally Kalyan  <kalyan.kondapally@intel.com>
288
289         [EFL] Enable WebGL by default.
290         https://bugs.webkit.org/show_bug.cgi?id=102991.
291
292         Reviewed by Kenneth Rohde Christiansen.
293
294         Enable WebGL by default.
295
296         * Scripts/webkitperl/FeatureList.pm:
297
298 2012-12-07  Scott Violet  <sky@chromium.org>
299
300         [chromium] Remove linux theme related files and switch to default
301         https://bugs.webkit.org/show_bug.cgi?id=103897
302
303         Reviewed by Dimitri Glazkov.
304
305         * Scripts/webkitpy/common/config/build_unittest.py:
306         (ShouldBuildTest): linux->default
307
308 2012-12-07  Mike Lattanzio  <mlattanzio@rim.com>
309
310         [BlackBerry] Update BlackBerry Port to use new Graphics::createBuffer BufferType enum values.
311         https://bugs.webkit.org/show_bug.cgi?id=104121
312
313         Reviewed by Rob Buis.
314
315         Update createBuffer call to reflect new BufferType enum.
316         Internal PR 254649
317         Internal Review: Jakob Petsovits
318
319         DRT is always backed for maximum compatibility.
320
321         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
322         (createBitmapContextFromWebView):
323
324 2012-12-07  Jochen Eisinger  <jochen@chromium.org>
325
326         Add 'CHROMIUM_DEVEL_SANDBOX' to the environment variables to copy for layout test drivers
327         https://bugs.webkit.org/show_bug.cgi?id=104355
328
329         Reviewed by Dirk Pranke.
330
331         This enables chromium's content_shell driver to run with the full SUID
332         sandbox.
333
334         * Scripts/webkitpy/layout_tests/port/base.py:
335         (Port.to.setup_environ_for_server):
336
337 2012-12-07  KyungTae Kim  <ktf.kim@samsung.com>
338
339         [EFL] Fix tools for WebKit2-only builds
340         https://bugs.webkit.org/show_bug.cgi?id=103904
341
342         Reviewed by Laszlo Gombos.
343
344         The libewebkit2.so should be used for library path for EFL WebKit2.
345
346         * Scripts/webkitdirs.pm:
347         (builtDylibPathForName):
348
349 2012-12-07  Xiaobo Wang  <xbwang@torchmobile.com.cn>
350
351         [BlackBerry] DRT - Update implementation of TestRunner.setCustomPolicyDelegate()
352         https://bugs.webkit.org/show_bug.cgi?id=104243
353
354         RIM PR 259337
355
356         Reviewed by Rob Buis.
357
358         1. Implement calculation of navigation originating in
359         didDecidePolicyForNavigationAction().
360         2. Implement policy delegate for resource response.
361         3. Enable customPolicyDelegate if waitForPolicyDelegate() is called.
362         4. Minor optional updates in dump() and dumpFrameLoadCallbacks().
363
364         The patch fixed the following tests:
365         - http/tests/download
366         - fast/forms/mailto/formenctype-attribute-button-html.html
367         - fast/forms/mailto/formenctype-attribute-input-html.html
368         - fast/encoding/mailto-always-utf-8.html
369
370         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
371         (BlackBerry::WebKit::DumpRenderTree::DumpRenderTree):
372         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
373         (BlackBerry::WebKit::DumpRenderTree::dump):
374         (BlackBerry::WebKit::DumpRenderTree::didFinishLoadForFrame):
375         (BlackBerry::WebKit::DumpRenderTree::didDecidePolicyForNavigationAction):
376         (BlackBerry::WebKit::DumpRenderTree::didDecidePolicyForResponse):
377         (BlackBerry::WebKit::DumpRenderTree::setCustomPolicyDelegate):
378         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
379         (DumpRenderTree):
380         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
381         (TestRunner::setCustomPolicyDelegate):
382         (TestRunner::waitForPolicyDelegate):
383         (TestRunner::overridePreference):
384
385 2012-12-07  Gwang Yoon Hwang  <ryumiel@company100.net>
386
387         [Qt] Adjust library name in layout_tests/port/qt.py after Qt5-r40
388         https://bugs.webkit.org/show_bug.cgi?id=104348
389
390         Reviewed by Csaba Osztrogonác.
391
392         After Qt-5.0.0-r40, the library was renamed from QtWebKitWidgets to
393         Qt5WebKitWidgets. run-webkit-tests were still looking for QtWebKitWidgets
394
395         * Scripts/webkitpy/layout_tests/port/qt.py:
396         (QtPort._path_to_webcore_library):
397
398 2012-12-07  Csaba Osztrogonác  <ossy@webkit.org>
399
400         Unreviewed fix, unbreak run-launcher after library renaming.
401
402         * Scripts/webkitdirs.pm:
403         (builtDylibPathForName):
404
405 2012-12-06  Csaba Osztrogonác  <ossy@webkit.org>
406
407         Unreviewed fix after r136896, unbreak --debug-rwt to make bots result verbose again.
408         https://bugs.webkit.org/show_bug.cgi?id=104296
409
410         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
411         (main):
412
413 2012-12-06  Rick Byers  <rbyers@chromium.org>
414
415         CSS cursor property should support webkit-image-set
416         https://bugs.webkit.org/show_bug.cgi?id=99493
417
418         Reviewed by Beth Dakin.
419
420         Add ENABLE_MOUSE_CURSOR_SCALE - disabled by default
421
422         * Scripts/webkitperl/FeatureList.pm:
423         * qmake/mkspecs/features/features.pri:
424
425 2012-12-06  Vivek Galatage  <vivek.vg@samsung.com>
426
427         Unreviewed. Fixing the email address order to work correctly with bugzilla.
428
429         * Scripts/webkitpy/common/config/committers.py:
430
431 2012-12-06  Jochen Eisinger  <jochen@chromium.org>
432
433         [chromium] when forwarding events through the WebPluginContainer, create a UserGestureIndicator if processing a user gesture
434         https://bugs.webkit.org/show_bug.cgi?id=104306
435
436         Reviewed by Dimitri Glazkov.
437
438         * DumpRenderTree/chromium/TestWebPlugin.cpp:
439         (TestWebPlugin::TestWebPlugin):
440         (TestWebPlugin::handleInputEvent): add support for printing the user gesture status
441         * DumpRenderTree/chromium/TestWebPlugin.h:
442         (TestWebPlugin):
443
444 2012-12-06  Dirk Pranke  <dpranke@chromium.org>
445
446         new-run-webkit-tests --lint-test-files seems to be broken
447         https://bugs.webkit.org/show_bug.cgi?id=104296
448
449         Unreviewed, build fix.
450
451         My recent refactoring caused me to not initialize the printer
452         before calling lint(); this patch restructures the code to make
453         the lint routine self-contained and do all the work necessary.
454         This will also make it easier to move this code out into a standalone
455         file.
456
457         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
458         (lint):
459         (main):
460         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
461         (LintTest.test_all_configurations):
462         (LintTest.test_lint_test_files):
463         (LintTest.test_lint_test_files__errors):
464
465 2012-12-05  Filip Pizlo  <fpizlo@apple.com>
466
467         DFG profiler should be helpful about gem installation
468         https://bugs.webkit.org/show_bug.cgi?id=104217
469
470         Reviewed by Oliver Hunt.
471         
472         'json' and 'highline' are not installed by default on the ruby distributions with
473         which I am familiar, and the default error messages don't make me happy. This makes
474         display-profiler-output print a helpful message if those gems are not found.
475
476         * Scripts/display-profiler-output:
477
478 2012-12-05  Filip Pizlo  <fpizlo@apple.com>
479
480         Profiler should print a helpful message if you pass the wrong arguments
481         https://bugs.webkit.org/show_bug.cgi?id=104222
482
483         Reviewed by Oliver Hunt.
484
485         * Scripts/display-profiler-output:
486
487 2012-12-06  Ojan Vafai  <ojan@chromium.org>
488
489         Allow for CCing a secondary email address from watchlists
490         https://bugs.webkit.org/show_bug.cgi?id=104286
491
492         Reviewed by Dirk Pranke.
493
494         Change my watchlist CC address so I can filter these separately from
495         when people explicitly CC me and update the watchlist parser to allow that.
496
497         * Scripts/webkitpy/common/config/committers.py:
498         * Scripts/webkitpy/common/config/watchlist:
499         * Scripts/webkitpy/common/watchlist/watchlistparser.py:
500         (WatchListParser._validate):
501         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:
502         (WatchListParserTest.test_cc_rule_with_invalid_email):
503         (WatchListParserTest.test_cc_rule_with_secondary_email):
504
505 2012-12-06  Max Vujovic  <mvujovic@adobe.com>
506
507         Unreviewed. Add myself to committers.py.
508
509         * Scripts/webkitpy/common/config/committers.py:
510
511 2012-12-06  Yael Aharon  <yael.aharon@intel.com>
512
513         [EFL] [WK2] fast/dom/vertical-scrollbar-in-rtl.html makes fast/regions tests flaky
514         https://bugs.webkit.org/show_bug.cgi?id=104139
515
516         Reviewed by Kenneth Rohde Christiansen.
517
518         Resize the window back to 800x600 between tests.
519         This should be a no-op if the test did not resize the window.
520
521         * WebKitTestRunner/TestController.cpp:
522         (WTR::TestController::resetStateToConsistentValues):
523
524 2012-12-06  Tommy Widenflycht  <tommyw@google.com>
525
526         Speech Recognition API: Change the error code to a string on SpeechRecognitionError
527         https://bugs.webkit.org/show_bug.cgi?id=104254
528
529         Reviewed by Adam Barth.
530
531         Changes the mock error function to take a string instead of an int.
532
533         * DumpRenderTree/chromium/DRTTestRunner.cpp:
534         (DRTTestRunner::setMockSpeechRecognitionError):
535         * DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp:
536         (WebTestRunner::ErrorTask::ErrorTask):
537         (MockWebSpeechRecognizer::setError):
538         * DumpRenderTree/chromium/MockWebSpeechRecognizer.h:
539         (MockWebSpeechRecognizer):
540
541 2012-12-06  Andras Becsi  <andras.becsi@digia.com>
542
543         [Qt][Mac] Fix libxslt and libxml2 config tests
544         https://bugs.webkit.org/show_bug.cgi?id=104164
545
546         Reviewed by Simon Hausmann.
547
548         We should not use pkg-config on Mac instead use direct include
549         paths and add needed libraries to the linker options to detect
550         libxslt and libxml2 provided by the system.
551         Previously we would always fall back to qtxmlpatterns.
552
553         * qmake/config.tests/libxml2/libxml2.pro:
554         * qmake/config.tests/libxslt/libxslt.pro:
555
556 2012-12-06  Csaba Osztrogonác  <ossy@webkit.org>
557
558         [Qt] Fix the build if the path contains "+" character
559         https://bugs.webkit.org/show_bug.cgi?id=104120
560
561         Reviewed by Tor Arne Vestbø.
562
563         The second parameter of qmake's replace() is regular expression, so
564         we have to escape special characters in paths passed to replace().
565
566         * qmake/mkspecs/features/default_post.prf:
567         * qmake/mkspecs/features/default_pre.prf:
568         * qmake/mkspecs/features/functions.prf:
569
570 2012-12-06  Sheriff Bot  <webkit.review.bot@gmail.com>
571
572         Unreviewed, rolling out r136825.
573         http://trac.webkit.org/changeset/136825
574         https://bugs.webkit.org/show_bug.cgi?id=104251
575
576         It made 100+ test fail on Qt-WK2 pixel bot, and 1800+ test
577         flakey on Qt-WK2 non-pixel bot (Requested by Ossy on #webkit).
578
579         * WebKitTestRunner/TestController.cpp:
580         (WTR::TestController::resetStateToConsistentValues):
581
582 2012-12-06  Yael Aharon  <yael.aharon@intel.com>
583
584         [EFL] [WK2] fast/dom/vertical-scrollbar-in-rtl.html makes fast/regions tests flaky
585         https://bugs.webkit.org/show_bug.cgi?id=104139
586
587         Reviewed by Kenneth Rohde Christiansen.
588
589         Resize the window back to 800x600 between tests.
590         This should be a no-op if the test did not resize the window.
591
592         * WebKitTestRunner/TestController.cpp:
593         (WTR::TestController::resetStateToConsistentValues):
594
595 2012-12-06  Sheriff Bot  <webkit.review.bot@gmail.com>
596
597         Unreviewed, rolling out r136784 and r136802.
598         http://trac.webkit.org/changeset/136784
599         http://trac.webkit.org/changeset/136802
600         https://bugs.webkit.org/show_bug.cgi?id=104231
601
602         breaks chromium canary (Requested by morrita on #webkit).
603
604         * Scripts/webkitpy/common/config/build_unittest.py:
605         (ShouldBuildTest):
606
607 2012-12-05  Ryosuke Niwa  <rniwa@webkit.org>
608
609         Add myself to watch changes in PerformanceTests/*.
610
611         * Scripts/webkitpy/common/config/watchlist:
612
613 2012-12-05  Shinya Kawanaka  <shinyak@chromium.org>
614
615         [Chromium] DRT on Windows crashes when a testcase has a progress element in indeterminate state
616         https://bugs.webkit.org/show_bug.cgi?id=102459
617
618         Reviewed by Dimitri Glazkov.
619
620         Since WebThemeControlDRTWin::markState does not consider indeterminate state, DRT caused a crash.
621
622         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp:
623         (WebThemeControlDRTWin::markState):
624
625 2012-12-05  Filip Pizlo  <fpizlo@apple.com>
626
627         DFG profiler should be able to display where a code block was inlined into, and what it inlined
628         https://bugs.webkit.org/show_bug.cgi?id=104216
629
630         Reviewed by Oliver Hunt.
631
632         Added an "inlines" command that shows the inline stacks that a code block participated
633         in. Also cleaned up some of the ways we print compilation units.
634
635         * Scripts/display-profiler-output:
636
637 2012-12-05  Halton Huo  <halton.huo@intel.com>
638
639         [CMake] Unify coding style for CMake files
640         https://bugs.webkit.org/show_bug.cgi?id=103605
641
642         Reviewed by Laszlo Gombos.
643
644         Update cmake files(.cmake, CMakeLists.txt) with following style rules:
645         1. Indentation
646         1.1 Use spaces, not tabs.
647         1.2 Four spaces as indent.
648         2. Spacing
649         2.1 Place one space between control statements and their parentheses.
650             For eg, if (), else (), elseif (), endif (), foreach (),
651             endforeach (), while (), endwhile (), break ().
652         2.2 Do not place spaces between function and macro statements and
653             their parentheses. For eg, macro(), endmacro(), function(),
654             endfunction().
655         2.3 Do not place spaces between a command or function or macro and its
656             parentheses, or between a parenthesis and its content. For eg,
657             message("testing") not message( "testing") or message ("testing" )
658         2.4 No space at line ending.
659         3. Lowercase when call commands macros and functions. For eg,
660            add_executable() not ADD_EXECUTABLE(), set() not SET().
661
662         * CMakeLists.txt:
663         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
664         * DumpRenderTree/efl/CMakeLists.txt:
665         * EWebLauncher/CMakeLists.txt:
666         * EWebLauncher/ControlTheme/CMakeLists.txt:
667         * MiniBrowser/efl/CMakeLists.txt:
668         * TestWebKitAPI/CMakeLists.txt:
669         * TestWebKitAPI/PlatformEfl.cmake:
670         * WebKitTestRunner/CMakeLists.txt:
671         * WebKitTestRunner/PlatformEfl.cmake:
672         * WinCELauncher/CMakeLists.txt:
673         * clang/ReportMemoryUsagePlugin/CMakeLists.txt:
674
675 2012-12-05  Scott Violet  <sky@chromium.org>
676
677         [chromium] Remove linux theme related files and switch to default
678         https://bugs.webkit.org/show_bug.cgi?id=103897
679
680         Reviewed by Tony Chang.
681
682         * Scripts/webkitpy/common/config/build_unittest.py:
683         (ShouldBuildTest): linux->default
684
685 2012-12-05  Dirk Pranke  <dpranke@chromium.org>
686
687         nrwt: run_webkit_tests_integrationtest.py depends on being able to share a port w/ between master and worker
688         https://bugs.webkit.org/show_bug.cgi?id=78168
689
690         Reviewed by Ojan Vafai.
691
692         This patch adds a single ordered list to ResultSummary that contains
693         the results of every test run in order of result received, and
694         modifies the TestResults class to contain the list of references used
695         for each test as well as the pid of the driver; this allows us to stop
696         having to override the test drivers to record the tests, and makes the
697         integration tests that test rdering, retries, restarts, etc. black-box
698         tests.
699
700         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
701         (SingleTestRunner._run_rebaseline):
702         (SingleTestRunner._compare_output):
703         (SingleTestRunner._run_reftest):
704         (SingleTestRunner._compare_output_with_reference):
705         * Scripts/webkitpy/layout_tests/models/result_summary.py:
706         (ResultSummary.__init__):
707         (ResultSummary.add):
708         * Scripts/webkitpy/layout_tests/models/test_results.py:
709         (TestResult.__init__):
710         * Scripts/webkitpy/layout_tests/port/driver.py:
711         (DriverOutput.__init__):
712         (Driver.run_test):
713         * Scripts/webkitpy/layout_tests/port/test.py:
714         (TestDriver):
715         (TestDriver.__init__):
716         (TestDriver.run_test):
717         (TestDriver.stop):
718         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
719         (get_tests_run):
720         (get_test_batches):
721         (get_test_results):
722         (MainTest.test_batch_size):
723         (MainTest.test_dryrun):
724         (MainTest.test_natural_order):
725         (MainTest.test_natural_order_test_specified_multiple_times):
726         (MainTest.test_random_order):
727         (MainTest.test_random_order_test_specified_multiple_times):
728         (MainTest.test_no_order):
729         (MainTest.test_no_order_test_specified_multiple_times):
730         (MainTest.test_no_order_with_directory_entries_in_natural_order):
731         (MainTest.test_repeat_each):
732         (MainTest.test_ignore_flag):
733         (MainTest.test_skipped_flag):
734         (MainTest.test_iterations):
735         (MainTest.test_run_chunk):
736         (MainTest.test_run_part):
737         (MainTest.test_run_singly):
738         (MainTest.test_skip_failing_tests):
739         (MainTest.test_single_file):
740         (MainTest.test_single_file_with_prefix):
741         (MainTest.test_single_skipped_file):
742         (MainTest.test_test_list):
743         (MainTest.test_test_list_with_prefix):
744         (MainTest.test_exit_after_n_failures):
745         (MainTest.test_exit_after_n_crashes):
746         (MainTest.test_run_order__inline):
747         (MainTest.test_reftest_run):
748         (MainTest.test_reftest_run_reftests_if_pixel_tests_are_disabled):
749         (MainTest.test_reftest_skip_reftests_if_no_ref_tests):
750         (MainTest.test_reftest_expected_html_should_be_ignored):
751         (MainTest.test_reftest_driver_should_run_expected_html):
752         (MainTest.test_reftest_driver_should_run_expected_mismatch_html):
753         (MainTest.test_no_http_tests):
754         (MainTest.test_platform_tests_are_found):
755
756 2012-12-05  Dana Jansens  <danakj@chromium.org>
757
758         [chromium] Make WebCompositorOutputSurface an empty class when USE_CC_OUTPUT_SURFACE is defined.
759         https://bugs.webkit.org/show_bug.cgi?id=103967
760
761         Reviewed by James Robinson.
762
763         Use the WebCompositorSupport methods to create an OutputSurface. If they
764         fail, then fall back to the WebViewHost methods.
765
766         Once the chromium side lands, the WebCompositorSupport methods will stop
767         failing, and will replace the WebViewHost ones.
768
769         * DumpRenderTree/chromium/WebViewHost.cpp:
770         (WebViewHost::createOutputSurface):
771
772 2012-12-05  Dirk Pranke  <dpranke@chromium.org>
773
774         nrwt: split all of the buildbot-specific output into its own file
775         https://bugs.webkit.org/show_bug.cgi?id=104165
776
777         Reviewed by Ojan Vafai.
778
779         Now that we have the RunDetails object we can move all of the
780         buildbot-specific knowledge out of the core test-running code
781         and into the outermost run_webkit_tests layer.
782
783         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
784         (run):
785         (main):
786         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
787         (passing_run):
788         (logging_run):
789         (run_and_capture):
790         (MainTest.test_all):
791         (MainTest.test_max_locked_shards):
792         (MainTest.test_child_processes_2):
793         (MainTest.test_child_processes_min):
794         (MainTest.test_full_results_html):
795         (MainTest.test_hung_thread):
796         (MainTest.test_keyboard_interrupt):
797         (MainTest.test_no_tests_found):
798         (MainTest.test_no_tests_found_2):
799         (MainTest.test_repeat_each_iterations_num_tests):
800         (MainTest.test_run_singly_actually_runs_tests):
801         (MainTest.test_test_list):
802         (MainTest.test_unexpected_failures):
803         (MainTest.test_missing_and_unexpected_results):
804         (MainTest.test_pixel_test_directories):
805         (MainTest.test_missing_and_unexpected_results_with_custom_exit_code):
806         (MainTest.test_crash_with_stderr):
807         (MainTest.test_no_image_failure_with_image_diff):
808         (MainTest.test_crash_log):
809         (MainTest.test_web_process_crash_log):
810         (MainTest.test_exit_after_n_failures_upload):
811         (MainTest.test_results_directory_absolute):
812         (MainTest.test_results_directory_default):
813         (MainTest.test_results_directory_relative):
814         (MainTest.test_retrying_and_flaky_tests):
815         (MainTest.test_reftest_should_not_use_naming_convention_if_not_listed_in_reftestlist):
816         (MainTest.test_output_diffs):
817         (MainTest.test_unsupported_platform):
818         (MainTest.test_verbose_in_child_processes):
819         (EndToEndTest.test_end_to_end):
820         (EndToEndTest.test_reftest_with_two_notrefs):
821         (RebaselineTest.test_reset_results):
822         (RebaselineTest.test_missing_results):
823         (RebaselineTest.test_new_baseline):
824         * Scripts/webkitpy/layout_tests/views/buildbot_results.py: Added.
825         (BuildBotPrinter):
826         (BuildBotPrinter.__init__):
827         (BuildBotPrinter.print_results):
828         (BuildBotPrinter._print):
829         (BuildBotPrinter.print_result_summary):
830         (BuildBotPrinter._print_result_summary_entry):
831         (BuildBotPrinter.print_unexpected_results):
832         (BuildBotPrinter.print_unexpected_results.add_to_dict_of_lists):
833         (BuildBotPrinter.print_unexpected_results.add_result):
834         * Scripts/webkitpy/layout_tests/views/buildbot_results_unittest.py: Added.
835         (BuildBotPrinterTests):
836         (BuildBotPrinterTests.assertEmpty):
837         (BuildBotPrinterTests.assertNotEmpty):
838         (BuildBotPrinterTests.get_printer):
839         (BuildBotPrinterTests.get_result):
840         (BuildBotPrinterTests.get_result_summary):
841         (BuildBotPrinterTests.test_print_unexpected_results):
842         (BuildBotPrinterTests.test_print_unexpected_results.get_unexpected_results):
843         * Scripts/webkitpy/layout_tests/views/printing.py:
844         (Printer):
845         (Printer.__init__):
846         (Printer.print_results):
847         (Printer._print_statistics_for_test_timings):
848         (Printer._print_baseline):
849         (Printer._print_debug):
850         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
851         (Testprinter.get_printer):
852         (Testprinter.get_result):
853         (Testprinter.test_configure_and_cleanup):
854         (Testprinter.test_print_config):
855         (Testprinter.test_print_one_line_summary):
856         (Testprinter.test_test_status_line):
857         (Testprinter.test_details):
858
859 2012-12-05  Dirk Pranke  <dpranke@chromium.org>
860
861         nrwt: collect all of the information about a run into a new RunDetails class
862         https://bugs.webkit.org/show_bug.cgi?id=104158
863
864         Reviewed by Ojan Vafai.
865
866         This patch collects the information from both test passes (the
867         main one and the retries) as well as the summarized results and
868         the exit code into a RunDetails class, so that the integration
869         tests can more easily tell what happened.
870
871         Also, change the way the --lint-test-files works slightly so that
872         we don't need to create a printer object (and hence we need to
873         rework the tests that are testing logging).
874
875         * Scripts/webkitpy/layout_tests/controllers/manager.py:
876         (RunDetails):
877         (RunDetails.__init__):
878         (Manager.run):
879         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
880         (run):
881         (main):
882         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
883         (passing_run):
884         (run_and_capture):
885         (LintTest.test_lint_test_files):
886         (LintTest.test_lint_test_files__errors):
887         (MainTest.test_verbose_in_child_processes):
888
889 2012-12-05  Dirk Pranke  <dpranke@chromium.org>
890
891         nrwt: remove --no-record-results
892         https://bugs.webkit.org/show_bug.cgi?id=104072
893
894         Reviewed by Ojan Vafai.
895
896         The command line flag was only being used in the unit tests and
897         wasn't really needed once we started using a mock filesystem.
898
899         Also, reformat a bunch of long lines ...
900
901         * Scripts/webkitpy/layout_tests/controllers/manager.py:
902         (Manager.run):
903         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
904         (parse_args):
905         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
906         (parse_args):
907         (passing_run):
908         (logging_run):
909         (MainTest.test_repeat_each_iterations_num_tests):
910         (MainTest.test_test_list):
911         (MainTest.test_missing_and_unexpected_results):
912         (MainTest.test_pixel_test_directories):
913         (MainTest.test_missing_and_unexpected_results_with_custom_exit_code):
914         (MainTest.test_crash_with_stderr):
915         (MainTest.test_no_image_failure_with_image_diff):
916         (MainTest.test_crash_log):
917         (MainTest.test_web_process_crash_log):
918         (MainTest.test_exit_after_n_failures_upload):
919         (MainTest.test_results_directory_absolute):
920         (MainTest.test_results_directory_relative):
921         (MainTest.test_reftest_should_not_use_naming_convention_if_not_listed_in_reftestlist):
922         (MainTest.test_additional_expectations):
923         (MainTest.test_output_diffs):
924         (EndToEndTest.test_end_to_end):
925         (EndToEndTest.test_reftest_with_two_notrefs):
926         (RebaselineTest.test_reset_results):
927         (RebaselineTest.test_missing_results):
928         (RebaselineTest.test_new_baseline):
929
930 2012-12-05  Dirk Pranke  <dpranke@chromium.org>
931
932         nrwt: only summarize the results one way
933         https://bugs.webkit.org/show_bug.cgi?id=104064
934
935         Reviewed by Ojan Vafai.
936
937         Change manager.summarize_results so that we always (and only)
938         include both expected and unexpected results. Previously we
939         would summarize the results twice, once with expected results
940         and once without. This made the code much more confusing than
941         it needed to be.
942
943         * Scripts/webkitpy/layout_tests/controllers/manager.py:
944         (summarize_results):
945         (Manager.run):
946         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
947         (ResultSummaryTest.summarized_results):
948         (ResultSummaryTest.test_no_svn_revision):
949         (ResultSummaryTest.test_svn_revision):
950         (ResultSummaryTest.test_summarized_results_wontfix):
951         * Scripts/webkitpy/layout_tests/views/printing.py:
952         (Printer.print_results):
953         (Printer._print_unexpected_results):
954         (Printer._print_unexpected_results.add_result):
955         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
956         (Testprinter.test_print_unexpected_results.get_unexpected_results):
957         (Testprinter):
958
959 2012-12-05  Filip Pizlo  <fpizlo@apple.com>
960
961         DFG profiler should display more information
962         https://bugs.webkit.org/show_bug.cgi?id=104163
963
964         Reviewed by Gavin Barraclough.
965
966         Added the following:
967         
968         - Distinguish between source counts and bytecode counts.
969         
970         - Add a "full" summary view that shows both kinds of counts, plus inline counts.
971         
972         - Add a "source" command to see the source.
973         
974         - Add a "bytecode" command to see the bytecode and counts.
975
976         * Scripts/display-profiler-output:
977
978 2012-12-05  Yong Li  <yoli@rim.com>
979
980         [BlackBerry] Build with libjpegturbo
981         https://bugs.webkit.org/show_bug.cgi?id=104152
982
983         Reviewed by Rob Buis.
984
985         RIM PR# 196975.
986         Make sure the right include path for libjpeg is included.
987
988         * Scripts/webkitdirs.pm:
989         (blackberryCMakeArguments):
990
991 2012-12-05  Joseph Pecoraro  <pecoraro@apple.com>
992
993         Remove stale check in check-for-webkit-framework-include-consistency
994         https://bugs.webkit.org/show_bug.cgi?id=103775
995
996         Reviewed by David Kilzer.
997
998         The underlying issue was fixed in r81173.
999
1000         * Scripts/check-for-webkit-framework-include-consistency:
1001
1002 2012-12-05  Dirk Pranke  <dpranke@chromium.org>
1003
1004         nrwt: simplify the finding of tests to retry
1005         https://bugs.webkit.org/show_bug.cgi?id=104067
1006
1007         Reviewed by Ryosuke Niwa.
1008
1009         I think this makes the code a little clearer; note that
1010         we were no longer using the include_missing flag.
1011
1012         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1013         (Manager.run):
1014         (Manager._failed_test_names):
1015
1016 2012-12-05  Dirk Pranke  <dpranke@chromium.org>
1017
1018         nrwt: remove two unused parameters from a function
1019         https://bugs.webkit.org/show_bug.cgi?id=104059
1020
1021         Reviewed by Ryosuke Niwa.
1022
1023         Also remove an old, stale FIXME.
1024
1025         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1026         (interpret_test_failures):
1027         (summarize_results):
1028         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1029         (ResultSummaryTest.test_interpret_test_failures):
1030
1031 2012-12-05  Dirk Pranke  <dpranke@chromium.org>
1032
1033         nrwt: return result_summaries from LayoutTestRunner.run_tests()
1034         https://bugs.webkit.org/show_bug.cgi?id=104051
1035
1036         Reviewed by Ojan Vafai.
1037
1038         This patch completes the refactoring that makes the result summary      
1039         an object returned from the layout test runner, rather than having      
1040         it passed in and modified. This makes the split of duties between       
1041         the manager and runner clearer and makes the data flow more             
1042         functionally.                                                           
1043
1044         Also clean up some minor lint issues.
1045
1046         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1047         (LayoutTestRunner.__init__):
1048         (LayoutTestRunner.run_tests):
1049         (LayoutTestRunner._mark_interrupted_tests_as_skipped):
1050         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
1051         (FakePrinter.print_expected):
1052         (LockCheckingRunner.__init__):
1053         (LayoutTestRunnerTests._runner):
1054         (LayoutTestRunnerTests._run_tests):
1055         (LayoutTestRunnerTests.test_interrupt_if_at_failure_limits):
1056         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1057         (Manager.__init__):
1058         (Manager.run):
1059         (Manager._run_tests):
1060
1061 2012-12-05  Dirk Pranke  <dpranke@chromium.org>
1062
1063         nrwt: move creation of the resultsummary objects into Manager._run_tests()
1064         https://bugs.webkit.org/show_bug.cgi?id=104048
1065
1066         Reviewed by Ojan Vafai.
1067
1068         This is a preparatory step to making the resultsummary just get
1069         returned from the layout_test_runner; this does most of manager-side
1070         changes.
1071
1072         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1073         (Manager._prepare_lists):
1074         (Manager.run):
1075         (Manager._run_tests):
1076
1077 2012-12-05  Leo Yang  <leoyang@rim.com>
1078
1079         [BlackBerry] Enable CSS_IMAGE_RESOLUTION
1080         https://bugs.webkit.org/show_bug.cgi?id=104132
1081
1082         Reviewed by Yong Li.
1083
1084         * Scripts/webkitperl/FeatureList.pm:
1085
1086 2012-12-05  Filip Pizlo  <fpizlo@apple.com>
1087
1088         JSC profiler should not count executions of op_call_put_result because doing so changes DFG codegen
1089         https://bugs.webkit.org/show_bug.cgi?id=104102
1090
1091         Reviewed by Oliver Hunt.
1092
1093         Modify the profiler to not output counts for op_call_put_result, since there
1094         won't be any. Also fix a few weird bugs, like providing better error reporting
1095         when you type something incorrectly and not reporting counts for slow paths
1096         in the old JIT since those counts are actually not what you think they are
1097         (we don't actually count slow path executions separately).
1098
1099         * Scripts/display-profiler-output:
1100
1101 2012-12-05  Andras Becsi  <andras.becsi@digia.com>
1102
1103         Fix compilation for Qt5.0.0 stable branch.
1104         https://bugs.webkit.org/show_bug.cgi?id=103870
1105
1106         Reviewed by Simon Hausmann.
1107
1108         Fix the use of renamed QWindow functions.
1109         Patch by Andras Becsi <andras.becsi@digia.com>
1110
1111         * MiniBrowser/qt/BrowserWindow.cpp:
1112         (BrowserWindow::BrowserWindow):
1113         (BrowserWindow::onTitleChanged):
1114         * MiniBrowser/qt/raw/View.cpp:
1115         (View::View):
1116
1117 2012-12-05  Jussi Kukkonen  <jussi.kukkonen@intel.com>
1118
1119         [WK2] InjectedBundle should check Intent url for null
1120         https://bugs.webkit.org/show_bug.cgi?id=104117
1121
1122         Reviewed by Kenneth Rohde Christiansen.
1123
1124         WKIntentServiceInfoCopyHref() can return null, we need to check
1125         for that in InjectedBundlePage::registerIntentServiceForFrame()
1126         to avoid crashing.
1127
1128         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1129         (WTR::InjectedBundlePage::registerIntentServiceForFrame):
1130
1131 2012-12-04  Jonathan Dong  <jonathan.dong@torchmobile.com.cn>
1132
1133         Change email address of Jonathan Dong
1134         https://bugs.webkit.org/show_bug.cgi?id=103976
1135
1136         Unreviewed, change my email address from jonathan.dong@torchmobile.com.cn
1137         to jonathan.dong.webkit@gmail.com in committers list.
1138
1139         * Scripts/webkitpy/common/config/committers.py:
1140
1141 2012-12-04  Xiaobo Wang  <xbwang@torchmobile.com.cn>
1142
1143         [BlackBerry] DRT - Tests under "dumpAsText" directory should be dumped as text
1144         https://bugs.webkit.org/show_bug.cgi?id=103986
1145
1146         Reviewed by Rob Buis.
1147
1148         Also move declaration of webSettingTransaction to before any WebSettings
1149         ::setXXX() calls so that it works as expected (commit only once in the
1150         function scope).
1151
1152         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
1153         (shouldDumpAsText):
1154         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
1155
1156 2012-12-04  Filip Pizlo  <fpizlo@apple.com>
1157
1158         display-profiler-output should be able to show source code
1159         https://bugs.webkit.org/show_bug.cgi?id=104073
1160
1161         Reviewed by Oliver Hunt.
1162
1163         Display source code in the summary, using a one-line shortening.
1164
1165         * Scripts/display-profiler-output:
1166
1167 2012-12-04  Filip Pizlo  <fpizlo@apple.com>
1168
1169         display-profiler-output should not use reflective infocation to resolve command names
1170
1171         Rubber stamped by Mark Hahnenberg.
1172
1173         Reflection is amazing, but here it was just kind of a bit much.
1174
1175         * Scripts/display-profiler-output:
1176
1177 2012-12-02  Filip Pizlo  <fpizlo@apple.com>
1178
1179         JSC should be able to report profiling data associated with the IR dumps and disassembly
1180         https://bugs.webkit.org/show_bug.cgi?id=102999
1181
1182         Reviewed by Gavin Barraclough.
1183
1184         Added a tool that allows you to grok the output from JSC's new profiler. Currently,
1185         this still gets confused a bit about the execution counts of a method running
1186         standalone versus a method running inlined, but other than that, it's pretty cool.
1187         See the attached "sampling profiling session" attached to the bug to see it in
1188         action.
1189         
1190         Also had to feed EFL's build system.
1191
1192         * DumpRenderTree/efl/CMakeLists.txt:
1193         * Scripts/display-profiler-output: Added.
1194
1195 2012-12-04  Dirk Pranke  <dpranke@chromium.org>
1196
1197         nrwt: fix total number of tests computed in the result summary
1198         https://bugs.webkit.org/show_bug.cgi?id=104061
1199
1200         Unreviewed, build fix.
1201
1202         One of the recent changes to the resultsummary refactoring caused
1203         us to not include the number of skipped tests in the total number
1204         of tests, throwing off the totals printed in print_one_line_summary().
1205
1206         Unfortunately, given the current state of the code it is difficult
1207         to construct an accurate unit test for this. I have verified the
1208         fix by hand, and will write a test once the remaining refactoring
1209         patches land, at which point it will be trivial to test it.
1210
1211         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1212         (Manager._prepare_lists):
1213
1214 2012-12-04  Dirk Pranke  <dpranke@chromium.org>
1215
1216         nrwt is not returning the exit status properly
1217         https://bugs.webkit.org/show_bug.cgi?id=103830
1218
1219         Unreviewed, build fix.
1220
1221         The fix in r136474 wasn't quite right either, and would return
1222         the correct exceptional status, but not the correct failing status.
1223
1224         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1225
1226 2012-12-04  Dirk Pranke  <dpranke@chromium.org>
1227
1228         nrwt: make paths and test_names passed arguments in Manager._prepare_lists et al
1229         https://bugs.webkit.org/show_bug.cgi?id=104047
1230
1231         Reviewed by Eric Seidel.
1232
1233         The code becomes cleaner if we are just passing values around rather
1234         than hanging them off the manager object, helps move _prepare_lists()
1235         to a pure function, and is needed to eventually make the
1236         result_summary object something returned from runner.run_tests()
1237         (note that two more patches are needed for that to happen).
1238
1239         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1240         (Manager.__init__):
1241         (Manager._http_tests):
1242         (Manager._prepare_lists):
1243         (Manager.needs_servers):
1244         (Manager._set_up_run):
1245         (Manager.run):
1246         (Manager._run_tests):
1247         (Manager._upload_json_files):
1248         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1249         (ManagerTest.test_needs_servers.get_manager):
1250         (ManagerTest.test_needs_servers):
1251         (ManagerTest.integration_test_needs_servers.get_manager):
1252         (ManagerTest.integration_test_needs_servers):
1253         (ManagerTest.test_look_for_new_crash_logs.get_manager):
1254         (ManagerTest):
1255         (ManagerTest.test_look_for_new_crash_logs):
1256         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1257         (JSONLayoutResultsGenerator.__init__):
1258         (JSONLayoutResultsGenerator._get_modifier_char):
1259
1260 2012-12-04  Adam Barth  <abarth@webkit.org>
1261
1262         commit-queue can get stuck with a local commit
1263         https://bugs.webkit.org/show_bug.cgi?id=104032
1264
1265         Reviewed by Dirk Pranke.
1266
1267         Previously the commit-queue would only clean down to HEAD. If the
1268         commit-queue gets interrupted in the middle of a commit (e.g., after
1269         the local commit but before the dcommit), then it can end up with a
1270         patch locally committed. That patch will then prevent the commit-queue
1271         from functioning.
1272
1273         This patch teaches the commit-queue to clean down to the merge base,
1274         which will remove any local commits.
1275
1276         * Scripts/webkitpy/common/checkout/scm/git.py:
1277         (Git.working_directory_is_clean):
1278         (Git.clean_working_directory):
1279         * Scripts/webkitpy/tool/commands/roll_unittest.py:
1280         * Scripts/webkitpy/tool/steps/commit.py:
1281         (Commit._commit_warning):
1282         (Commit.run):
1283
1284 2012-12-04  Dirk Pranke  <dpranke@chromium.org>
1285
1286         nrwt: store only the total number of tests in the result summary
1287         https://bugs.webkit.org/show_bug.cgi?id=103963
1288
1289         Reviewed by Ryosuke Niwa.
1290
1291         The result summary only needs the total number of tests that will
1292         be run (including repetitions) in order to provide the correct stats;
1293         it doesn't actually need to know how many unique tests there are, or
1294         or how many repetitions there are.
1295
1296         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
1297         (LayoutTestRunnerTests._result_summary):
1298         (LayoutTestRunnerTests.test_update_summary_with_result):
1299         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1300         (Manager._prepare_lists):
1301         (Manager.run):
1302         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1303         (ManagerTest.test_look_for_new_crash_logs):
1304         (ResultSummaryTest.get_result_summary):
1305         * Scripts/webkitpy/layout_tests/models/result_summary.py:
1306         (ResultSummary.__init__):
1307         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
1308         (Testprinter.get_result_summary):
1309
1310 2012-12-04  Dirk Pranke  <dpranke@chromium.org>
1311
1312         nrwt: do less work when ctrl-c'ed
1313         https://bugs.webkit.org/show_bug.cgi?id=103961
1314
1315         Reviewed by Ryosuke Niwa.
1316
1317         Do less work when we are ctrl-c'ed, because the statistics aren't
1318         that useful anyway. While we're at it, modify summarize_results
1319         to be aware that we don't always retry results (instead of pretending
1320         that the retry produced the same results the initial run did).
1321
1322         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1323         (summarize_results):
1324         (Manager.run):
1325
1326 2012-12-04  Dirk Pranke  <dpranke@chromium.org>
1327
1328         nrwt: result summaries should not require a list of tests to skip
1329         https://bugs.webkit.org/show_bug.cgi?id=103951
1330
1331         Reviewed by Ryosuke Niwa.
1332
1333         We shouldn't really be passing a list of tests to skip to the
1334         ResultSummary objects; they should be handled like any other
1335         test result as much as possible.
1336
1337         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
1338         (LayoutTestRunnerTests._result_summary):
1339         (LayoutTestRunnerTests.test_update_summary_with_result):
1340         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1341         (Manager._prepare_lists):
1342         (Manager.run):
1343         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1344         (ManagerTest.test_look_for_new_crash_logs):
1345         (ResultSummaryTest.get_result_summary):
1346         * Scripts/webkitpy/layout_tests/models/result_summary.py:
1347         (ResultSummary.__init__):
1348         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1349         (TestExpectations):
1350         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
1351         (Testprinter.get_result_summary):
1352
1353 2012-12-04  Dirk Pranke  <dpranke@chromium.org>
1354
1355         nrwt: derive per-thread, per-worker stats from result summaries
1356         https://bugs.webkit.org/show_bug.cgi?id=103943
1357
1358         Reviewed by Ojan Vafai.
1359
1360         This patch changes the manager and printing code to pull more           
1361         information from the ResultSummary object rather than tracking          
1362         additional statistics on the side. This allows us to consolidate        
1363         a bunch of logic and remove a bunch of free-floating lists and dicts of 
1364         of values. We add the shard_name and worker_name to each TestResult,    
1365         and then modify print_timing_statistics() and upload_json_files()       
1366         to just need the result summaries.                                      
1367
1368         Note that this patch also changes the timing statistics slightly
1369         so that the individual test times are the times to run just the
1370         tests themselves (TestResult.test_run_time) and do not include the
1371         times taken to run the ref tests, compute diffs, etc. The aggregated
1372         per-worker and per-shard statistics still use the total time to
1373         process each test (TestResult.total_run_time).
1374
1375         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1376         (LayoutTestRunner.__init__):
1377         (LayoutTestRunner.run_tests):
1378         (LayoutTestRunner._handle_finished_test_list):
1379         (LayoutTestRunner._handle_finished_test):
1380         (Worker.handle):
1381         (Worker._run_test):
1382         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1383         (summarize_results):
1384         (Manager.run):
1385         (Manager._upload_json_files):
1386         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1387         (ResultSummaryTest.summarized_results):
1388         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1389         (JSONLayoutResultsGenerator.__init__):
1390         (JSONLayoutResultsGenerator._get_test_timing):
1391         * Scripts/webkitpy/layout_tests/models/test_results.py:
1392         (TestResult.__init__):
1393         * Scripts/webkitpy/layout_tests/views/printing.py:
1394         (Printer.print_results):
1395         (Printer._print_timing_statistics):
1396         (Printer):
1397         (Printer._print_worker_statistics):
1398         (Printer._print_aggregate_test_statistics):
1399         (Printer._print_individual_test_times):
1400         (Printer._print_directory_timings):
1401         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
1402         (Testprinter.test_print_unexpected_results.get_unexpected_results):
1403         (Testprinter):
1404
1405 2012-12-04  Adam Barth  <abarth@webkit.org>
1406
1407         Remove obsolete code from webkitpy
1408         https://bugs.webkit.org/show_bug.cgi?id=104029
1409
1410         Reviewed by Eric Seidel.
1411
1412         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1413         (CommitQueueTask.run):
1414         * Scripts/webkitpy/tool/steps/commit.py:
1415         (Commit.options):
1416         * Scripts/webkitpy/tool/steps/options.py:
1417         (Options):
1418
1419 2012-12-04  Jochen Eisinger  <jochen@chromium.org>
1420
1421         [chromium] move WebPreferences and methods for modifying them to the TestRunner library
1422         https://bugs.webkit.org/show_bug.cgi?id=103841
1423
1424         Reviewed by Darin Fisher.
1425
1426         * DumpRenderTree/DumpRenderTree.gypi:
1427         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1428         (DRTTestRunner::DRTTestRunner):
1429         (DRTTestRunner::reset):
1430         * DumpRenderTree/chromium/DRTTestRunner.h:
1431         (DRTTestRunner):
1432         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h: Renamed from Tools/DumpRenderTree/chromium/WebPreferences.h.
1433         (WebKit):
1434         (WebTestRunner):
1435         (WebPreferences):
1436         (WebTestRunner::WebPreferences::WebPreferences):
1437         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1438         (WebTestRunner):
1439         (WebTestDelegate):
1440         (WebTestRunner::WebTestDelegate::localFileToDataURL):
1441         (WebTestRunner::WebTestDelegate::rewriteLayoutTestsURL):
1442         (WebTestRunner::WebTestDelegate::preferences):
1443         (WebTestRunner::WebTestDelegate::applyPreferences):
1444         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1445         (WebTestRunner::TestRunner::TestRunner):
1446         (WebTestRunner::TestRunner::reset):
1447         (WebTestRunner::TestRunner::setUserStyleSheetEnabled):
1448         (WebTestRunner):
1449         (WebTestRunner::TestRunner::setUserStyleSheetLocation):
1450         (WebTestRunner::TestRunner::setAuthorAndUserStylesEnabled):
1451         (WebTestRunner::TestRunner::setPopupBlockingEnabled):
1452         (WebTestRunner::TestRunner::setJavaScriptCanAccessClipboard):
1453         (WebTestRunner::TestRunner::setXSSAuditorEnabled):
1454         (WebTestRunner::TestRunner::setAllowUniversalAccessFromFileURLs):
1455         (WebTestRunner::TestRunner::setAllowFileAccessFromFileURLs):
1456         (WebTestRunner::TestRunner::overridePreference):
1457         (WebTestRunner::TestRunner::setPluginsEnabled):
1458         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1459         (TestRunner):
1460         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp: Renamed from Tools/DumpRenderTree/chromium/WebPreferences.cpp.
1461         (WebTestRunner::WebPreferences::reset):
1462         (WebTestRunner):
1463         (WebTestRunner::WebPreferences::applyTo):
1464         * DumpRenderTree/chromium/TestShell.h:
1465         (TestShell::preferences):
1466         (TestShell):
1467         * DumpRenderTree/chromium/WebViewHost.cpp:
1468         (WebViewHost::localFileToDataURL):
1469         (WebViewHost::rewriteLayoutTestsURL):
1470         (WebViewHost::preferences):
1471         (WebViewHost::applyPreferences):
1472         * DumpRenderTree/chromium/WebViewHost.h:
1473         (WebViewHost):
1474
1475 2012-12-04  Zan Dobersek  <zandobersek@gmail.com>
1476
1477         Many webkitpy unit tests can be run standalone, are executable
1478         https://bugs.webkit.org/show_bug.cgi?id=103900
1479
1480         Reviewed by Eric Seidel.
1481
1482         There's no need anymore to run unit tests in standalone mode as they
1483         are now handled by test-webkitpy in a formidable fashion. This makes
1484         it possible for this patch to remove the following unnecessary bits:
1485         - remove shebang lines from unit test files,
1486         - remove calls to unittest.main(),
1487         - make unit test files non-executable.
1488
1489         * Scripts/webkitpy/common/checkout/diff_parser_unittest.py:
1490         (DiffParserTest.test_git_mnemonicprefix):
1491         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1492         (GitTestWithMock.test_push_local_commits_to_server_without_username_and_with_password):
1493         * Scripts/webkitpy/common/config/build_unittest.py:
1494         (ShouldBuildTest.test_should_build):
1495         * Scripts/webkitpy/common/config/ports_unittest.py:
1496         (DeprecatedPortTest.test_chromium_xvfb_port):
1497         * Scripts/webkitpy/common/find_files_unittest.py:
1498         (TestWinNormalize.test_win):
1499         * Scripts/webkitpy/common/lru_cache_unittest.py:
1500         (LRUCacheTest.test_set_again):
1501         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1502         (test_results_zip_url):
1503         * Scripts/webkitpy/common/net/credentials_unittest.py:
1504         (test_keyring_without_git_repo_nor_keychain):
1505         * Scripts/webkitpy/common/net/omahaproxy_unittest.py:
1506         (OmahaProxyTest.test_get_revisions):
1507         * Scripts/webkitpy/common/net/unittestresults_unittest.py:
1508         * Scripts/webkitpy/common/newstringio_unittest.py:
1509         (NewStringIOTest.test_with):
1510         * Scripts/webkitpy/common/read_checksum_from_png_unittest.py:
1511         (ReadChecksumFromPngTest.test_read_checksum):
1512         * Scripts/webkitpy/common/system/file_lock_integrationtest.py:
1513         * Scripts/webkitpy/common/system/filesystem_mock_unittest.py:
1514         (MockFileSystemTest.test_normpath):
1515         * Scripts/webkitpy/common/system/filesystem_unittest.py:
1516         (RealFileSystemTest.test_sep):
1517         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
1518         (TestPlatformInfo.test_total_bytes_memory):
1519         * Scripts/webkitpy/common/system/zipfileset_unittest.py:
1520         (ZipFileSetTest.test_namelist):
1521         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
1522         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1523         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
1524         (TestResultWriterTest.test_reftest_diff_image):
1525         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1526         (JSONGeneratorTest.test_test_timings_trie):
1527         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1528         (TestExpectationSerializationTests.test_string_whitespace_stripping):
1529         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1530         (KeyCompareTest.test_test_key):
1531         * Scripts/webkitpy/layout_tests/port/builders_unittest.py:
1532         (BuildersTest.test_path_from_name):
1533         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
1534         (ChromiumAndroidTwoPortsTest.test_options_with_two_ports):
1535         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
1536         (ChromiumLinuxPortTest.test_path_to_image_diff):
1537         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
1538         (ChromiumMacPortTest.test_path_to_image_diff):
1539         * Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:
1540         (ChromiumPortLoggingTest.test_check_sys_deps):
1541         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1542         (ChromiumPortLoggingTest.test_check_sys_deps):
1543         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
1544         (ConfigTest.test_default_configuration__scripterror):
1545         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
1546         (DriverTest.test_start_actually_starts):
1547         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
1548         (FactoryTest.test_get_from_builder_name):
1549         * Scripts/webkitpy/layout_tests/port/http_lock_unittest.py:
1550         * Scripts/webkitpy/layout_tests/port/image_diff_unittest.py:
1551         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1552         * Scripts/webkitpy/layout_tests/reftests/extract_reference_link_unittest.py:
1553         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1554         (PortTest.disabled_test_mac_lion):
1555         * Scripts/webkitpy/layout_tests/servers/http_server_integrationtest.py:
1556         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
1557         (VerboseTest.test_log_args):
1558         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
1559         (test_details):
1560         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1561         (TestPerfTestFactory.test_inspector_test):
1562         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1563         (test_parse_args):
1564         * Scripts/webkitpy/style/checker_unittest.py:
1565         * Scripts/webkitpy/style/checkers/changelog_unittest.py:
1566         (ChangeLogCheckerTest.test_no_error):
1567         * Scripts/webkitpy/style/checkers/common_unittest.py:
1568         (TabCheckerTest.test_tab):
1569         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1570         (CppCheckerTest.test_ne):
1571         * Scripts/webkitpy/style/checkers/jsonchecker_unittest.py:
1572         * Scripts/webkitpy/style/checkers/png_unittest.py:
1573         (PNGCheckerTest.test_check):
1574         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1575         * Scripts/webkitpy/style/checkers/text_unittest.py:
1576         (TextCheckerTest.test_init):
1577         * Scripts/webkitpy/style/checkers/watchlist_unittest.py:
1578         * Scripts/webkitpy/style/checkers/xcodeproj_unittest.py:
1579         (XcodeProjectFileCheckerTest.test_detect_development_region):
1580         * Scripts/webkitpy/style/checkers/xml_unittest.py:
1581         (XMLCheckerTest.test_no_error):
1582         * Scripts/webkitpy/style/patchreader_unittest.py:
1583         * Scripts/webkitpy/test/finder_unittest.py:
1584         (FinderTest.test_paths):
1585         * Scripts/webkitpy/test/runner_unittest.py:
1586         (RunnerTest.test_run):
1587         * Scripts/webkitpy/test/skip_unittest.py:
1588         (SkipTest.test_skip_if_true):
1589         * Scripts/webkitpy/thirdparty/__init___unittest.py:
1590         (ThirdpartyTest.test_imports):
1591         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests_unittest.py:
1592         (TestTranslation.test_include_rewriting):
1593         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
1594         (QueueEngineTest.tearDown):
1595         * Scripts/webkitpy/tool/grammar_unittest.py:
1596         (GrammarTest.test_join_with_separators):
1597         * Scripts/webkitpy/tool/mocktool_unittest.py:
1598         (MockOptionsTest.test_kwarg__set):
1599         * Scripts/webkitpy/tool/multicommandtool_unittest.py:
1600         (test_command_help):
1601
1602 2012-12-04  Zan Dobersek  <zandobersek@gmail.com>
1603
1604         Many webkitpy module files are executable, have shebang line
1605         https://bugs.webkit.org/show_bug.cgi?id=103985
1606
1607         Reviewed by Dirk Pranke.
1608
1609         Remove the executable bit from webkitpy module files that are
1610         unnecessarily executable. Remove the shebang line from webkitpy
1611         module files, they are of no use. Only non-third-party files are
1612         changed.
1613
1614         * Scripts/webkitpy/bindings/main.py:
1615         * Scripts/webkitpy/common/config/watchlist:
1616         * Scripts/webkitpy/common/find_files.py:
1617         * Scripts/webkitpy/common/lru_cache.py:
1618         * Scripts/webkitpy/common/multiprocessing_bootstrap.py:
1619         * Scripts/webkitpy/common/net/file_uploader.py:
1620         * Scripts/webkitpy/common/newstringio.py:
1621         * Scripts/webkitpy/common/read_checksum_from_png.py:
1622         * Scripts/webkitpy/common/system/autoinstall.py:
1623         * Scripts/webkitpy/common/system/file_lock.py:
1624         * Scripts/webkitpy/common/system/file_lock_mock.py:
1625         * Scripts/webkitpy/common/version_check.py:
1626         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1627         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1628         * Scripts/webkitpy/layout_tests/models/test_failures.py:
1629         * Scripts/webkitpy/layout_tests/models/test_input.py:
1630         * Scripts/webkitpy/layout_tests/port/__init__.py:
1631         * Scripts/webkitpy/layout_tests/port/base.py:
1632         * Scripts/webkitpy/layout_tests/port/builders.py:
1633         * Scripts/webkitpy/layout_tests/port/chromium.py:
1634         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1635         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1636         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1637         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1638         * Scripts/webkitpy/layout_tests/port/config.py:
1639         * Scripts/webkitpy/layout_tests/port/factory.py:
1640         * Scripts/webkitpy/layout_tests/port/http_lock.py:
1641         * Scripts/webkitpy/layout_tests/port/image_diff.py:
1642         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
1643         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1644         * Scripts/webkitpy/layout_tests/port/server_process.py:
1645         * Scripts/webkitpy/layout_tests/port/test.py:
1646         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1647         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
1648         * Scripts/webkitpy/layout_tests/servers/http_server.py:
1649         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
1650         * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
1651         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
1652         * Scripts/webkitpy/layout_tests/views/printing.py:
1653         * Scripts/webkitpy/performance_tests/perftest.py:
1654         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1655         * Scripts/webkitpy/style/checkers/changelog.py:
1656         * Scripts/webkitpy/style/checkers/cpp.py:
1657         * Scripts/webkitpy/style/checkers/xcodeproj.py:
1658         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
1659         (main): There's no need to run this module in standalone because
1660         it's wrapped by the Tools/Scripts/update-webgl-conformance-tests script.
1661         * Scripts/webkitpy/tool/commands/upload.py:
1662         * Scripts/webkitpy/tool/comments.py:
1663         * Scripts/webkitpy/tool/main.py:
1664
1665 2012-12-04  Ryosuke Niwa  <rniwa@webkit.org>
1666
1667         Add a Chromium Android Release (Perf) to the list of perf. bots.
1668
1669         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
1670
1671 2012-12-04  Zan Dobersek  <zandobersek@gmail.com>
1672
1673         [GTK] Insert the jhbuild wrapper command at the beginning of the command list
1674         https://bugs.webkit.org/show_bug.cgi?id=103991
1675
1676         Reviewed by Martin Robinson.
1677
1678         Insert the Tools/gtk/run-with-jhbuild wrapper at the beginning of the
1679         command that's being formed in multiprocessing bootstrap. The wrapper is
1680         an executable Python script while the command being wrapped perhaps isn't
1681         and therefore requires the Python interpreter to be listed at the beginning
1682         of the command sublist that is then executed by the wrapper.
1683
1684         Specifically, the webkitpy/layout_tests/run_webkit_tests.py module file
1685         is about to lose the executable bit and the Python-signaling shebang line.
1686         The Jhbuild wrapper simply executes the command that's passed, but that errs
1687         in this case unless the Python executable is executed and the module file
1688         is passed to it as an argument.
1689
1690         * Scripts/webkitpy/common/multiprocessing_bootstrap.py:
1691         (run):
1692
1693 2012-12-04  Peter Beverloo  <peter@chromium.org>
1694
1695         Add the Chromium Android Release (Perf) bot
1696         https://bugs.webkit.org/show_bug.cgi?id=103891
1697
1698         Reviewed by Eric Seidel.
1699
1700         Add configuration for the bot itself. It will be triggered by the Chromium
1701         Android Release builder. When running for Android, the DownloadAndPerfTest
1702         factory will also add the OutputAndroidDeviceStatus step.
1703
1704         * BuildSlaveSupport/build.webkit.org-config/config.json:
1705         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1706         (DownloadAndPerfTestFactory.__init__):
1707
1708 2012-12-04  Peter Beverloo  <peter@chromium.org>
1709
1710         [Chromium] The ChromiumAndroidDriver constructor should not rely on adb being available
1711         https://bugs.webkit.org/show_bug.cgi?id=103758
1712
1713         Reviewed by Eric Seidel.
1714
1715         Lazily initialize the adb command parameters rather than initializing it in the
1716         constructor now that there is an assert if adb is not available on the system and
1717         we're not in a Chromium Android checkout.
1718
1719         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1720         (ChromiumAndroidDriver.__init__):
1721         (ChromiumAndroidDriver._push_file_if_needed):
1722         (ChromiumAndroidDriver._run_adb_command):
1723         (ChromiumAndroidDriver.cmd_line):
1724         (ChromiumAndroidDriver._start_once):
1725         (ChromiumAndroidDriver._read_prompt):
1726         (ChromiumAndroidDriver):
1727         (ChromiumAndroidDriver._adb_command):
1728
1729 2012-12-03  Ryosuke Niwa  <rniwa@webkit.org>
1730
1731         Dromaeo should report individual test result
1732         https://bugs.webkit.org/show_bug.cgi?id=99800
1733
1734         Reviewed by Eric Seidel.
1735
1736         Ignore subtest results spit out by Dromaeo tests.
1737
1738         * Scripts/webkitpy/performance_tests/perftest.py:
1739         (PerfTest): Added a line to ignore.
1740         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1741         (MainTest.test_parse_output_with_subtests): Added.
1742
1743 2012-12-03  Zan Dobersek  <zandobersek@gmail.com>
1744
1745         Unreviewed, functionality fix after r136437.
1746
1747         Calling sys.exit actually raises a SystemExit exception that
1748         is then handled in the second block and causes the script to
1749         return an 'exceptional' exit code rather than the code presenting
1750         the number of failed tests.
1751
1752         This is just a temporary fix to get the faultless bots green while
1753         they are unnecessarily red at the moment. The problem and a proper
1754         fix will be properly addressed.
1755
1756         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1757
1758 2012-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
1759
1760         Unreviewed, rolling out r136460.
1761         http://trac.webkit.org/changeset/136460
1762         https://bugs.webkit.org/show_bug.cgi?id=103958
1763
1764         This patch caused compile error when building DumpRenderTree
1765         (Requested by tasak on #webkit).
1766
1767         * Scripts/webkitpy/common/config/build_unittest.py:
1768         (ShouldBuildTest):
1769
1770 2012-12-03  Scott Violet  <sky@chromium.org>
1771
1772         [chromium] Remove linux theme related files and switch to default
1773         https://bugs.webkit.org/show_bug.cgi?id=103897
1774
1775         Reviewed by Darin Fisher.
1776
1777         * Scripts/webkitpy/common/config/build_unittest.py:
1778         (ShouldBuildTest): linux->default
1779
1780 2012-12-03  Roger Fong  <roger_fong@apple.com>
1781
1782         Disable WebKit2 API tests on Apple Windows port.
1783         https://bugs.webkit.org/show_bug.cgi?id=103929.
1784
1785         Reviewed by Timothy Horton.
1786
1787         * Scripts/run-api-tests:
1788         (runTestsBySuite):
1789
1790 2012-12-03  Dirk Pranke  <dpranke@chromium.org>
1791
1792         webkitpy's run_webkit_tests should initialize the printer earlier on
1793         https://bugs.webkit.org/show_bug.cgi?id=103661
1794
1795         Reviewed by Eric Seidel.
1796
1797         Initialize the printer before computing the derived options
1798         from the command line arguments, so that we can safely log from
1799         port methods.
1800
1801         Also clean up a few miscellaneous lint warnings.
1802
1803         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1804         (ChromiumAndroidPort.path_to_adb):
1805         * Scripts/webkitpy/layout_tests/port/mac.py:
1806         (MacPort.default_child_processes):
1807         (MacPort.sample_process):
1808         (MacPort.start_helper):
1809         (MacPort.stop_helper):
1810         (MacPort.nm_command):
1811         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1812         (test_default_child_processes):
1813         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1814         (run):
1815         (_set_up_derived_options):
1816
1817 2012-12-03  Dirk Pranke  <dpranke@chromium.org>
1818
1819         webkitpy: autoinstaller is failing on windows
1820         https://bugs.webkit.org/show_bug.cgi?id=103699
1821
1822         Reviewed by Tony Chang.
1823
1824         Attempt to fix the python autoinstaller to work for pylint on win32
1825         again ... it turns out one of the dependent packages contains
1826         a write-protected test file and windows will choke when it tries to move
1827         it into place. Fortunately we can just delete the file prior to
1828         installing it in the final location, but we have to jump through
1829         a couple of hoops to do so.
1830
1831         Also, make sure that we're flattening nested module names like
1832         "logilab/common" into either safe basenames (logilab_common) or
1833         host-specific subdirs (logilab\common) as needed.
1834
1835         * Scripts/webkitpy/common/system/autoinstall.py:
1836         (AutoInstaller._url_downloaded_path):
1837         (AutoInstaller._install):
1838         (AutoInstaller.install):
1839         * Scripts/webkitpy/thirdparty/__init__.py:
1840         (AutoinstallImportHook._install_pylint):
1841
1842 2012-12-03  Dirk Pranke  <dpranke@chromium.org>
1843
1844         nrwt: clean up exception propagation / handling for interrupts and early exits
1845         https://bugs.webkit.org/show_bug.cgi?id=103830
1846
1847         Reviewed by Ojan Vafai.
1848
1849         The code for propagating early exits out of the test run was
1850         convoluted and hard to follow. By adjusting the WorkerException to
1851         derive from BaseException rather than Exception (which is a fair
1852         way of representing an error that was really unexpected/unrecoverable
1853         anyway) and pushing the TestRunInterruptedException into the
1854         ResultSummary (which is also fair since it was more of a result
1855         than an exception) this allows us to consolidate and clean up
1856         a bunch of the try/catch logic and pass fewer state flags around.
1857
1858         There are no real functional changes to this patch; there's an
1859         API change in that we stop exporting TestRunInterruptedException
1860         and WorkerException out of the Manager, and the existence of the
1861         MessagePool is now completely hidden.
1862
1863         * Scripts/webkitpy/common/message_pool.py:
1864         (WorkerException):
1865         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1866         (LayoutTestRunner.run_tests):
1867         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1868         (summarize_results):
1869         (Manager.run):
1870         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1871         (ResultSummaryTest.summarized_results):
1872         * Scripts/webkitpy/layout_tests/models/result_summary.py:
1873         (ResultSummary.__init__):
1874         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1875         (run):
1876         (main):
1877         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1878         (MainTest.test_exception_raised.of):
1879         (MainTest.test_exception_raised):
1880         (MainTest.test_run_force):
1881         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
1882         (Testprinter.test_print_unexpected_results.get_unexpected_results):
1883         (Testprinter):
1884
1885 2012-12-03  Julien BRIANCEAU   <jbrianceau@nds.com>
1886
1887         Add Qt/SH4 build slave to build.webkit.org
1888         https://bugs.webkit.org/show_bug.cgi?id=103384
1889
1890         Reviewed by Csaba Osztrogonác.
1891
1892         * BuildSlaveSupport/build.webkit.org-config/config.json:
1893
1894 2012-12-03  Alexis Menard  <alexis@webkit.org>
1895
1896         Enable CSS3 background-position offset by default
1897         https://bugs.webkit.org/show_bug.cgi?id=103917
1898
1899         Reviewed by Benjamin Poulain.
1900
1901         Even though each port may enable or not the feature we still need
1902         to pass it at configure time otherwise it will be disabled.
1903
1904         * Scripts/webkitperl/FeatureList.pm:
1905
1906 2012-12-03  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
1907
1908         Unreviewed. Adding myself to committers.py.
1909
1910         * Scripts/webkitpy/common/config/committers.py:
1911
1912 2012-12-03  Laszlo Gombos  <l.gombos@samsung.com>
1913
1914         [CMake] Enable building WebKit2-only build for the EFL port
1915         https://bugs.webkit.org/show_bug.cgi?id=103820
1916
1917         Reviewed by Gyuyoung Kim.
1918
1919         Set ENABLE_WEBKIT2 to OFF if build-webkit was run with --no-webkit2.
1920         Never set ENABLE_WEBKIT in build-webkit. This will simplyfy invoking
1921         cmake directly. Initialize $cmakeArgs to avoid potential
1922         warnings when running the script.
1923
1924         * Scripts/build-webkit:
1925
1926 2012-12-03  Tommy Widenflycht  <tommyw@google.com>
1927
1928         Speech Recognition API: Update SpeechRecognitionEvent to match the specification
1929         https://bugs.webkit.org/show_bug.cgi?id=103407
1930
1931         Reviewed by Kentaro Hara.
1932
1933         Changing the mock to use the new results delivery API.
1934
1935         * DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp:
1936
1937 2012-12-03  Alexis Menard  <alexis@webkit.org>
1938
1939         [Qt] Enable CSS3 background-position offsets by default.
1940         https://bugs.webkit.org/show_bug.cgi?id=103877
1941
1942         Reviewed by Tor Arne Vestbø.
1943
1944         Enable by default CSS3 background-position offsets.
1945
1946         * qmake/mkspecs/features/features.pri:
1947
1948 2012-12-03  KyungTae Kim  <ktf.kim@samsung.com>
1949
1950         [EFL][WK2] Use float variable for zoom levels for MiniBrowser
1951         https://bugs.webkit.org/show_bug.cgi?id=103863
1952
1953         Reviewed by Gyuyoung Kim.
1954
1955         Use float instead of int for zoomLevels variables for a clearer expression
1956
1957         * MiniBrowser/efl/main.c:
1958         (on_key_down):
1959
1960 2012-12-02  KyungTae Kim  <ktf.kim@samsung.com>
1961
1962         [EFL][WK2] Add support for a zoom level setting to MiniBrowser
1963         https://bugs.webkit.org/show_bug.cgi?id=99285
1964
1965         Reviewed by Gyuyoung Kim.
1966
1967          Add support for a zoom level setting to MiniBrowser.
1968          Shortcuts for setting operations are same as common browsers:
1969          Ctrl + '+' to zoom in, Ctrl + '-' to zoom out and Ctrl + '0' to zoom to default.
1970
1971         * MiniBrowser/efl/main.c:
1972         (on_key_down):
1973
1974 2012-12-02  KyungTae Kim  <ktf.kim@samsung.com>
1975
1976         [EFL][WK2] ECORE_GETOPT_VALUE_BOOL need to be used for Eina_Bool
1977         https://bugs.webkit.org/show_bug.cgi?id=103835
1978
1979         Reviewed by Kentaro Hara.
1980
1981         Because legacy_behavior_enabled is Eina_Bool, ECORE_GETOPT_VALUE_BOOL need to be used
1982
1983         * MiniBrowser/efl/main.c:
1984         (elm_main):
1985
1986 2012-12-02  Mike West  <mkwst@chromium.org>
1987
1988         Garden-o-matic shouldn't die when blank JSON results are received.
1989         https://bugs.webkit.org/show_bug.cgi?id=103838
1990
1991         Reviewed by Adam Barth.
1992
1993         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
1994             If the JSONP string doesn't contain '(' or ')', return an empty object.
1995         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
1996             Check that this behavior stays in place.
1997
1998 2012-12-02  Eric Seidel  <eric@webkit.org>
1999
2000         run-perf-tests --profile should use iprofiler instead of instruments on Mac
2001         https://bugs.webkit.org/show_bug.cgi?id=103765
2002
2003         Unreviewed.  Updating the unittests after my previous change.
2004
2005         * Scripts/webkitpy/common/system/profiler_unittest.py:
2006         (ProfilerFactoryTest.test_basic):
2007
2008 2012-12-02  Julie Parent  <jparent@chromium.org>
2009
2010         Remove dead code in flakiness dashboard for obsolete buildDir option
2011         https://bugs.webkit.org/show_bug.cgi?id=103792
2012
2013         Reviewed by Dirk Pranke.
2014
2015         * TestResultServer/static-dashboards/dashboard_base.js:
2016         (initBuilders):
2017
2018 2012-12-02  Dirk Pranke  <dpranke@chromium.org>
2019
2020         nrwt: clean up logic for retrying failed tests a bit
2021         https://bugs.webkit.org/show_bug.cgi?id=103829
2022
2023         Reviewed by Ojan Vafai.
2024
2025         The code for determining when to retry test failures and
2026         show the results.html file was awkward and could stand some
2027         cleaning up. This patch should have no functional changes.
2028
2029         The routine called _get_failures() returned a dict of test names
2030         to failure types, but we only ever used the names, so I've converted
2031         it to return a list (and renamed it); also, the show_results_html()
2032         file was calling that routine to figure out if anything failed, when
2033         the information was already in the result_summary (as either
2034         unexpected_results or total_failures), so we were doing unnecessary work.
2035
2036         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2037         (Manager.__init__):
2038         (Manager.run):
2039         (Manager._run_tests):
2040         (Manager._failed_test_names):
2041         (Manager._copy_results_html_file):
2042
2043 2012-12-02  Dirk Pranke  <dpranke@chromium.org>
2044
2045         nrwt: remove unused methods in manager.py
2046         https://bugs.webkit.org/show_bug.cgi?id=103828
2047
2048         Reviewed by Eric Seidel.
2049
2050         These two methods weren't being called by anything and were no
2051         longer needed.
2052
2053         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2054         (Manager._get_failures):
2055         (Manager._upload_json_files):
2056
2057 2012-12-02  Laszlo Gombos  <l.gombos@samsung.com>
2058
2059         Correct the spelling of the cmakeargs argument
2060         https://bugs.webkit.org/show_bug.cgi?id=103814
2061
2062         Reviewed by Darin Adler.
2063
2064         The script expects cmakeargs (plural), so lets get the
2065         documentation of the script report the same.
2066
2067         * Scripts/build-webkit:
2068
2069 2012-12-02  Mike West  <mkwst@chromium.org>
2070
2071         [gtk] Enable the CSP_NEXT runtime flag.
2072         https://bugs.webkit.org/show_bug.cgi?id=103810
2073
2074         Reviewed by Adam Barth.
2075
2076         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2077         (resetDefaultsToConsistentValues):
2078             Turn on the CSP_NEXT runtime flag when running tests under GTK.
2079
2080 2012-12-02  Eric Seidel  <eric@webkit.org>
2081
2082         run-perf-tests --profile should use iprofiler instead of instruments on Mac
2083         https://bugs.webkit.org/show_bug.cgi?id=103765
2084
2085         Reviewed by Ryosuke Niwa.
2086
2087         Stephanie pointed out that iprofiler is the newer command-line interface
2088         to replace /usr/bin/instruments in Instruments 4 (which according to the
2089         interblags is supported on everything since 10.6.6), so I've moved --profile
2090         to use iprofiler on Mac.
2091
2092         I also made the IProfiler class wait for iprofiler to complete so that
2093         iprofiler won't continue running after run-perf-tests is complete (and
2094         spam over the top of your shell output).
2095
2096         There are a couple of "got-chas" to this approach:
2097         1.  iprofiler will ask for your password the first time you run it, which may
2098             cause your first test to fail.  /usr/bin/instruments doesn't seem to do that.
2099         2.  iprofiler has nice (but kinda awkward for our purposes) support for separate
2100             directory and basename arguments, making IProfiler a somewhat awkward
2101             baseclass of SingleFileOutputProfiler
2102
2103         I suspect we'll iterate from here.  It does seem slightly faster than
2104         /usr/bin/instruments was.
2105
2106         * Scripts/webkitpy/common/system/profiler.py:
2107         (ProfilerFactory.create_profiler):
2108         (IProfiler):
2109         (IProfiler.__init__):
2110         (IProfiler.attach_to_pid):
2111
2112 2012-12-02  Yongjun Zhang  <yongjun_zhang@apple.com>
2113
2114         Need a method to close all idle localstorage databases immediately.
2115         https://bugs.webkit.org/show_bug.cgi?id=103469
2116
2117         Reviewed by David Kilzer.
2118
2119         Add an JS method to TestRunner, to enable testing closing idle local storage databases in
2120         DumpRenderTree layout tests.
2121
2122         * DumpRenderTree/TestRunner.cpp:
2123         (closeIdleLocalStorageDatabasesCallback):
2124         (TestRunner::staticFunctions):
2125         * DumpRenderTree/TestRunner.h:
2126         (TestRunner):
2127         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
2128         (TestRunner::closeIdleLocalStorageDatabases):
2129         * DumpRenderTree/efl/TestRunnerEfl.cpp:
2130         (TestRunner::closeIdleLocalStorageDatabases):
2131         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
2132         (TestRunner::closeIdleLocalStorageDatabases):
2133         * DumpRenderTree/mac/TestRunnerMac.mm:
2134         (TestRunner::closeIdleLocalStorageDatabases):
2135         * DumpRenderTree/win/TestRunnerWin.cpp:
2136         (TestRunner::closeIdleLocalStorageDatabases):
2137         * DumpRenderTree/wx/TestRunnerWx.cpp:
2138         (TestRunner::closeIdleLocalStorageDatabases):
2139
2140 2012-12-02  Yael Aharon  <yael.aharon@intel.com>
2141
2142         [EFL][WK2] MiniBrowser should have a legacy mode
2143         https://bugs.webkit.org/show_bug.cgi?id=103679
2144
2145         Reviewed by Kenneth Rohde Christiansen.
2146
2147         Add an option to start MiniBrowser in legacy mode.
2148
2149         * MiniBrowser/efl/main.c:
2150         (window_create):
2151         (elm_main):
2152
2153 2012-12-02  Sheriff Bot  <webkit.review.bot@gmail.com>
2154
2155         Unreviewed, rolling out r136236.
2156         http://trac.webkit.org/changeset/136236
2157         https://bugs.webkit.org/show_bug.cgi?id=103833
2158
2159         [chromium] Flakey crashes in SpeechRecognitionEvent::emma
2160         during GC. (Requested by mkwst on #webkit).
2161
2162         * DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp:
2163
2164 2012-12-01  Zan Dobersek  <zandobersek@gmail.com>
2165
2166         [XvfbDriver] XvfbDriverTest.test_next_free_display is flaky on builders using XvfbDriver
2167         https://bugs.webkit.org/show_bug.cgi?id=103806
2168
2169         Reviewed by Dirk Pranke.
2170
2171         There are occasional mishaps on builders where XvfbDriver doesn't properly
2172         clean up the Xvfb instance it was managing so the related guard lock files
2173         are still existing when the webkitpy unit tests are run. This can cause failures
2174         in XvfbDriverTest.test_next_free_display as the test tries to acquire displays
2175         with a specific number but is unable to due to the stale locks.
2176
2177         The solution to this is to use MockFileLock when inside unit test. This is achievable
2178         by creating a file lock through the SystemHost instance connected to the Port object,
2179         the latter available to the Driver.
2180
2181         * Scripts/webkitpy/common/system/file_lock_mock.py:
2182         (MockFileLock.acquire_lock): Return True to signal lock acquiring succeeded.
2183         (MockFileLock.release_lock): Return True to signal lock releasing succeeded.
2184         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
2185         (XvfbDriver._next_free_display): Create the file lock through a mockable way.
2186         * Scripts/webkitpy/layout_tests/port/xvfbdriver_unittest.py:
2187         (XvfbDriverTest.test_next_free_display): Enable back the unit test.
2188
2189 2012-12-01  Zan Dobersek  <zandobersek@gmail.com>
2190
2191         [GTK] A11y tests in WK2 report badly-formatted AX roles
2192         https://bugs.webkit.org/show_bug.cgi?id=102947
2193
2194         Reviewed by Xan Lopez.
2195
2196         As in DRT, convert the ATK accessibility roles to corresponding AXRoles.
2197         These are expected in both tests and their baselines.
2198
2199         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2200         (WTR::roleToString):
2201         (WTR):
2202         (WTR::AccessibilityUIElement::role):
2203
2204 2012-11-30  Mike West  <mkwst@chromium.org>
2205
2206         CSP 1.1: Make the CSP_NEXT flag runtime enabled.
2207         https://bugs.webkit.org/show_bug.cgi?id=103652
2208
2209         Reviewed by Adam Barth.
2210
2211         Ensures that the new SecurityPolicy runtime flag is enabled for Chromium's tests.
2212
2213         * DumpRenderTree/chromium/TestShell.cpp:
2214         (TestShell::TestShell):
2215
2216 2012-11-30  Roger Fong  <roger_fong@apple.com>
2217
2218         Unreviewed. Removed temporary debugging change from DRT (r136300).
2219
2220         * DumpRenderTree/win/DumpRenderTree.cpp:
2221         (dump):
2222
2223 2012-11-30  Roger Fong  <roger_fong@apple.com>
2224
2225         Unreviewed. Temporary change to DRT for debugging purposes.
2226
2227         * DumpRenderTree/win/DumpRenderTree.cpp:
2228         (dump):
2229
2230 2012-11-29  Tommy Widenflycht  <tommyw@google.com>
2231
2232         Speech Recognition API: Update SpeechRecognitionEvent to match the specification
2233         https://bugs.webkit.org/show_bug.cgi?id=103407
2234
2235         Reviewed by Adam Barth.
2236
2237         Changing the mock to use the new results delivery API.
2238
2239         * DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp:
2240
2241 2012-11-30  Simon Hausmann  <simon.hausmann@digia.com>, Pierre Rossi  <pierre.rossi@digia.com>
2242
2243         [Qt] Separate Qt WebKit into Qt WebKit and Qt WebKit Widgets
2244         https://bugs.webkit.org/show_bug.cgi?id=99314
2245
2246         Reviewed by Tor Arne Vestbø.
2247
2248         This big change separates QtWebKit into QtWebKit and QtWebKitWidgets as
2249         shared libraries.
2250
2251         It's a big refactoring that mostly involves moving WebCore dependent
2252         code into QtWebKit and accessing it through exported QWebFrameAdapter
2253         and QWebPageAdapter classes.
2254
2255         * DumpRenderTree/qt/DumpRenderTree.pro:
2256         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2257         (WebCore::DumpRenderTree::dump): Adapt to internal API changes.
2258         * MiniBrowser/qt/MiniBrowser.pro:
2259         * Scripts/webkitpy/style/checker.py: Adapt Qt exceptions to new paths.
2260         * Scripts/webkitpy/style/checker_unittest.py:
2261         (GlobalVariablesTest.test_path_rules_specifier):
2262         * WebKitTestRunner/InjectedBundle/Target.pri:
2263         * qmake/mkspecs/features/default_post.prf:
2264         * qmake/mkspecs/features/webkit_modules.prf:
2265         * qmake/mkspecs/modules/webkitwidgets.prf: Removed.
2266
2267 2012-11-30  Csaba Osztrogonác  <ossy@webkit.org>
2268
2269         [Qt] Unreviewed trivial fix.
2270
2271         Add empty.cpp back, it was removed accidentally by r129092.
2272
2273         * qmake/config.tests/gccdepends/empty.cpp: Added.
2274
2275 2012-11-30  Tor Arne Vestbø  <tor.arne.vestbo@digia.com>
2276
2277         [Qt] Add support for prepare_docs and generate_docs
2278
2279         Follow-up to changes in Qt in how documentation is built.
2280
2281         Reviewed by Simon Hausmann.
2282
2283         * qmake/mkspecs/features/default_post.prf:
2284
2285 2012-11-30  Zan Dobersek  <zandobersek@gmail.com>
2286
2287         Finally remove webkitpy.common.system.deprecated_logging
2288         https://bugs.webkit.org/show_bug.cgi?id=103624
2289
2290         Reviewed by Adam Barth.
2291
2292         Remove the deprecated logging module and its unit tests now that such logging is not
2293         used anymore in webkitpy.
2294
2295         The tee and OutputTee classes are moved into a new module, webkitpy.common.system.outputtee.
2296         The tee class is renamed to Tee to conform with the usual guidelines.
2297
2298         Only unit test for the Tee class is currently provided as the OutputTee is not currently
2299         using the webkitpy Filesystem abstraction that would make its functionality testable.
2300
2301         * Scripts/webkitpy/common/system/executive.py: tee (now Tee) is now in a new module.
2302         (Executive.run_and_throw_if_fail):
2303         * Scripts/webkitpy/common/system/outputtee.py: Renamed from Tools/Scripts/webkitpy/common/system/deprecated_logging.py.
2304         (Tee):
2305         (Tee.__init__):
2306         (Tee.write):
2307         (OutputTee):
2308         (OutputTee.__init__):
2309         (OutputTee.add_log):
2310         (OutputTee.remove_log):
2311         (OutputTee._open_log_file):
2312         (OutputTee._tee_outputs_to_files):
2313         * Scripts/webkitpy/common/system/outputtee_unittest.py: Renamed from Tools/Scripts/webkitpy/common/system/deprecated_logging_unittest.py.
2314         (SimpleTeeTest):
2315         (SimpleTeeTest.test_simple_tee):
2316         * Scripts/webkitpy/tool/bot/queueengine.py: OutputTee is now in a new module.
2317         * Scripts/webkitpy/webkitpy.pyproj: Remove the deprecated_logging module and related unit test file.
2318
2319 2012-11-30  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
2320
2321         [EFL][WK2] Add support for PlatformWebView::simulateRightClick() in TestWebKitAPI
2322         https://bugs.webkit.org/show_bug.cgi?id=103634
2323
2324         Reviewed by Gyuyoung Kim.
2325
2326         Add support for PlatformWebView::simulateRightClick() and enable
2327         WebKit2 API test HitTestResultNodeHandle.
2328
2329         * TestWebKitAPI/PlatformEfl.cmake:
2330         * TestWebKitAPI/efl/PlatformWebView.cpp:
2331         (TestWebKitAPI::PlatformWebView::simulateRightClick):
2332         (TestWebKitAPI):
2333
2334 2012-11-30  Mihai Maerean  <mmaerean@adobe.com>
2335
2336         [CSSRegions] when WebKit uses V8, there should be a single variable to store if the CSS Regions feature is enabled
2337         https://bugs.webkit.org/show_bug.cgi?id=101192
2338
2339         Reviewed by Hajime Morita.
2340
2341         Removed the CSS Regions flag in Settings and switched to using the new flag I have added in RuntimeEnabledFeatures.
2342
2343         Tests: No new tests because there is no functional change.
2344
2345         * DumpRenderTree/chromium/WebPreferences.cpp:
2346         (WebPreferences::applyTo):
2347
2348 2012-11-29  Rafael Weinstein  <rafaelw@chromium.org>
2349
2350         [HTMLTemplateElement] Add feature flag
2351         https://bugs.webkit.org/show_bug.cgi?id=103694
2352
2353         Reviewed by Adam Barth.
2354
2355         This flag will guard the implementation of the HTMLTemplateElement.
2356         http://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/templates/index.html
2357
2358         * Scripts/webkitperl/FeatureList.pm:
2359
2360 2012-11-29  Dirk Pranke  <dpranke@chromium.org>
2361
2362         Ignore errors when removing directories on win32 during autoinstall
2363         https://bugs.webkit.org/show_bug.cgi?id=103699
2364
2365         Unreviewed, build fix.
2366
2367         I think this will work on win32; if not, I'll have to actually
2368         reproduce this :). The problem is that the logilab files
2369         appear to contain a write-protected file, and deleting those
2370         is problematic on windows.
2371
2372         * Scripts/webkitpy/common/system/autoinstall.py:
2373         (AutoInstaller._install):
2374         (AutoInstaller.install):
2375
2376 2012-11-29  Dirk Pranke  <dpranke@chromium.org>
2377
2378         webkitpy: autoinstaller is failing on windows
2379         https://bugs.webkit.org/show_bug.cgi?id=103699
2380
2381         Unreviewed, build fix.
2382
2383         We're attempting to create directories with forward slashes in them;
2384         this is a no-no on windows.
2385
2386         * Scripts/webkitpy/common/system/autoinstall.py:
2387         (AutoInstaller._create_scratch_directory_inner):
2388
2389 2012-11-29  Dirk Pranke  <dpranke@chromium.org>
2390
2391         Fix python unit tests after r136158 (android port tests failing)
2392         https://bugs.webkit.org/show_bug.cgi?id=103581
2393
2394         Unreviewed, build fix.
2395
2396         The unit tests apparently weren't ran for this patch; we failed
2397         to update the mock executive calls out to adb to determine various
2398         aspects of the environment, and were failing to create drivers.
2399
2400         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
2401         (MockRunCommand.mock_run_command_fn):
2402
2403 2012-11-29  Sheriff Bot  <webkit.review.bot@gmail.com>
2404
2405         Unreviewed, rolling out r136175 and r136177.
2406         http://trac.webkit.org/changeset/136175
2407         http://trac.webkit.org/changeset/136177
2408         https://bugs.webkit.org/show_bug.cgi?id=103683
2409
2410         Changes did not correct Windows build. (Requested by bfulgham
2411         on #webkit).
2412
2413         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:
2414
2415 2012-11-29  Brent Fulgham  <bfulgham@webkit.org>
2416
2417         [Windows, WinCairo] Unreviewed build correction. Correct debug
2418         build case on build machine.
2419
2420         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:
2421
2422 2012-11-29  Brent Fulgham  <bfulgham@webkit.org>
2423
2424         [Windows, WinCairo] Unreviewed build correction. Hide the
2425         unexported 'notSolidColor' symbol when testing against
2426         the BitmapImage class to avoid having to deal with a
2427         debug-only symbol in the Windows export definition file.
2428
2429         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp: 
2430
2431 2012-11-29  Peter Beverloo  <peter@chromium.org>
2432
2433         run-perf-tests --chromium-android should not require adb in my path
2434         https://bugs.webkit.org/show_bug.cgi?id=103581
2435
2436         Reviewed by Eric Seidel.
2437
2438         Remove the need to have "adb" available in the path for Layout and Performance
2439         tests. We'll determine the versions of the "adb" version in path (if any) and
2440         the one provided in the Chromium Android checkout. Unless the "adb" available
2441         in the path is newer, the provided version will be used.
2442
2443         Some other minor nits addressed:
2444         - The path_to_forwarder/path_to_md5sum should not be in the "private overrides"
2445           section, as they're not overriding anything and are used by the driver.
2446         - Make _restart_adb_as_root slightly more robust by waiting for the device
2447           to come back online regardless of the output.
2448
2449         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2450         (ChromiumAndroidPort.__init__):
2451         (ChromiumAndroidPort.check_build):
2452         (ChromiumAndroidPort.path_to_adb):
2453         (ChromiumAndroidPort):
2454         (ChromiumAndroidPort.path_to_forwarder):
2455         (ChromiumAndroidPort.path_to_md5sum):
2456         (ChromiumAndroidPort._path_to_helper):
2457         (ChromiumAndroidPort._determine_adb_version):
2458         (ChromiumAndroidPort._get_devices):
2459         (ChromiumAndroidDriver.__init__):
2460         (ChromiumAndroidDriver._setup_md5sum_and_push_data_if_needed):
2461         (ChromiumAndroidDriver._push_executable):
2462         (ChromiumAndroidDriver._restart_adb_as_root):
2463
2464 2012-11-29  Martin Robinson  <mrobinson@igalia.com>
2465
2466         [GTK] [WebKit2] Embed the HTTP authentication dialog into the WebView
2467         https://bugs.webkit.org/show_bug.cgi?id=103277
2468
2469         Reviewed by Carlos Garcia Campos.
2470
2471         Skip the new WebKit2GtkAuthenticationDialog files so that they are not processed
2472         during gtkdoc generation.
2473
2474         * gtk/generate-gtkdoc:
2475         (get_webkit2_options):
2476
2477 2012-11-29  Eric Seidel  <eric@webkit.org>
2478
2479         run-perf-tests --chromium-android fails due to Skia INFO logging
2480         https://bugs.webkit.org/show_bug.cgi?id=103585
2481
2482         Reviewed by Adam Barth.
2483
2484         Ignore all INFO logging from Chromium code.
2485         Also added some basic testing of the ignored-stderr lines code.
2486
2487         * Scripts/webkitpy/performance_tests/perftest.py:
2488         (PerfTest):
2489         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2490         (MainTest.test_ignored_stderr_lines):
2491
2492 2012-11-29  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
2493
2494         [EFL][WK2] Add support for PlatformWebView::simulateMouseMove() in TestWebKitAPI
2495         https://bugs.webkit.org/show_bug.cgi?id=103252
2496
2497         Reviewed by Kenneth Rohde Christiansen.
2498
2499         Add support for PlatformWebView::simulateMouseMove() and enable
2500         WebKit2 API test MouseMoveAfterCrash.
2501
2502         * TestWebKitAPI/PlatformEfl.cmake: Enable MouseMoveAfterCrash API
2503         test.
2504         * TestWebKitAPI/efl/PlatformWebView.cpp:
2505         (TestWebKitAPI::onWebProcessCrashed): Handle 'webprocess,crashed' signal
2506         to prevent loading an error page since the test case is reloading actual
2507         page after web process has terminated and recovered.
2508         (TestWebKitAPI):
2509         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2510         (TestWebKitAPI::PlatformWebView::simulateMouseMove): Implemented.
2511
2512 2012-11-29  Andras Becsi  <andras.becsi@digia.com>
2513
2514         [Qt] Fix installation of QtWebProcess binary
2515         https://bugs.webkit.org/show_bug.cgi?id=101735
2516
2517         Reviewed by Simon Hausmann.
2518
2519         Add config test to detect the availability of support
2520         for "program executables" in Qt (libexec).
2521
2522         This test can be removed after the Qt5 release.
2523
2524         * Tools.pro:
2525         * qmake/mkspecs/features/features.prf:
2526         * qmake/config.tests/libexecdir/libexecdir.cpp:
2527         * qmake/config.tests/libexecdir/libexecdir.pro:
2528
2529 2012-11-29  Eric Seidel  <eric@webkit.org>
2530
2531         run-perf-tests does not work when the layout test directory does not exist
2532         https://bugs.webkit.org/show_bug.cgi?id=103572
2533
2534         Reviewed by Ryosuke Niwa.
2535
2536         Make sure that Profiler() calls maybe_make_directory for the output_dir
2537         before ever using it.  It's a little awkward to create the directory
2538         from the constructor, but its simplest that way as the various subclasses
2539         all use the directory at different times.
2540
2541         Since this required having a filesystem in Profiler (and I didn't want
2542         to grab inside Workspace to get one), I just made Profiler expect a
2543         SystemHost instead of a separate filesystem, executive and workspace.
2544
2545         * Scripts/webkitpy/common/system/profiler.py:
2546         (ProfilerFactory.create_profiler):
2547         (Profiler.__init__):
2548         (SingleFileOutputProfiler.__init__):
2549         (GooglePProf.__init__):
2550         (GooglePProf.profile_after_exit):
2551         (Instruments.__init__):
2552         (Instruments.attach_to_pid):
2553         * Scripts/webkitpy/common/system/profiler_unittest.py:
2554         (ProfilerFactoryTest.test_basic):
2555
2556 2012-11-28  Vivek Galatage  <vivek.vg@samsung.com>
2557
2558         Adding secondary email id
2559         https://bugs.webkit.org/show_bug.cgi?id=103594
2560
2561         Unreviewed. Adding secondary email.
2562
2563         * Scripts/webkitpy/common/config/committers.py:
2564
2565 2012-11-28  Kent Tamura  <tkent@chromium.org>
2566
2567         garden-o-matic: Use indeterminate <progress> in the status area
2568         https://bugs.webkit.org/show_bug.cgi?id=103494
2569
2570         Reviewed by Adam Barth.
2571
2572         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
2573         Wrap the "Processing..." message with an indeterminate progress bar.
2574         We keep the message as a fallback content.
2575         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
2576         Follow the above change.
2577
2578 2012-11-28  Nima Ghanavatian  <nghanavatian@rim.com>
2579
2580         Adding Nima Ghanavatian to committers.py
2581         https://bugs.webkit.org/show_bug.cgi?id=103533
2582
2583         Reviewed by Rob Buis.
2584
2585         Adding myself to committers.py as a Committer.
2586
2587         * Scripts/webkitpy/common/config/committers.py:
2588
2589 2012-11-28  peavo@outlook.com  <peavo@outlook.com>
2590
2591         [WinCairo] Crash when requesting favicon.
2592         https://bugs.webkit.org/show_bug.cgi?id=102689
2593
2594         Reviewed by Brent Fulgham.
2595
2596         * TestWebKitAPI/Tests/WebCore/win: Added.
2597         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp: Added.
2598         (TestWebKitAPI::BitmapImageTest::BitmapImageTest): Allocate frame in constructor.
2599         (TestWebKitAPI::BitmapImageTest::frameCount): Override frameCount() method.
2600         (TestWebKitAPI::TEST): Added new test.
2601         * TestWebKitAPI/config.h: Make sure defines are correct for WinCairo.
2602        * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added new test.
2603
2604 2012-11-28  Eric Seidel  <eric@webkit.org>
2605
2606         run-perf-tests should have a --profile option for easy profiling
2607         https://bugs.webkit.org/show_bug.cgi?id=99517
2608
2609         Reviewed by Adam Barth.
2610
2611         This is a very basic implementation which works on Mac and Linux
2612         and makes it trivial for anyone to profile a PerformanceTest.
2613
2614         Currently it's not "hard" to profile a PerformanceTest
2615         but lowering the barriers to entry here allows all of us to focus
2616         less on the tools and more on the code.
2617
2618         This also paves the way for adding easy mobile-profiling (e.g. chromium-android)
2619         which is actually "hard", and this option will make much easier.
2620
2621         * Scripts/webkitpy/common/system/profiler.py: Added.
2622         (ProfilerFactory):
2623         (ProfilerFactory.create_profiler):
2624         (Profiler):
2625         (Profiler.__init__):
2626         (Profiler.adjusted_environment):
2627         (Profiler.attach_to_pid):
2628         (Profiler.did_stop):
2629         (SingleFileOutputProfiler):
2630         (SingleFileOutputProfiler.__init__):
2631         (GooglePProf):
2632         (GooglePProf.__init__):
2633         (GooglePProf.adjusted_environment):
2634         (GooglePProf.did_stop):
2635         (Instruments):
2636         (Instruments.__init__):
2637         (Instruments.attach_to_pid):
2638         * Scripts/webkitpy/common/system/profiler_unittest.py: Added.
2639         (ProfilerFactoryTest):
2640         (ProfilerFactoryTest.test_basic):
2641         * Scripts/webkitpy/layout_tests/port/driver.py:
2642         (Driver.__init__):
2643         (Driver._start):
2644         (Driver.stop):
2645         (Driver.cmd_line):
2646         * Scripts/webkitpy/performance_tests/perftest.py:
2647         (PerfTest.parse_output):
2648         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2649         (MainTest.test_parse_output):
2650         (MainTest.test_parse_output_with_failing_line):
2651         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2652         (PerfTestsRunner._parse_args):
2653         (PerfTestsRunner.run):
2654
2655 2012-11-28  Zan Dobersek  <zandobersek@gmail.com>
2656
2657         Remove deprecated logging usage from QueueEngine
2658         https://bugs.webkit.org/show_bug.cgi?id=103532
2659
2660         Reviewed by Dirk Pranke.
2661
2662         Replace usage of deprecated logging in webkitpy.tool.bot.queueengine with
2663         logging through the Logger object. The unit test is modified to reflect
2664         these changes.
2665
2666         After these changes the deprecated logging (i.e. logging to stderr) is not
2667         used anymore through webkitpy and can be removed.
2668
2669         * Scripts/webkitpy/tool/bot/queueengine.py:
2670         (QueueEngine.exit_after_handled_error):
2671         (QueueEngine.run):
2672         (QueueEngine._stopping):
2673         (QueueEngine._sleep):
2674         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
2675         (QueueEngineTest._run_engine):
2676
2677 2012-11-28  Nate Chapin  <japhet@chromium.org>
2678
2679         Move empty loading to DocumentLoader, simplify FrameLoader::init()
2680         https://bugs.webkit.org/show_bug.cgi?id=101512
2681
2682         Reviewed by Adam Barth.
2683
2684         * DumpRenderTree/chromium/WebViewHost.cpp:
2685         (WebViewHost::updateForCommittedLoad): This function doesn't play nicely with empty urls and incorrectly
2686             interprets them as a non-empty load. This change is required for
2687              http/tests/navigation/new-window-redirect-history.html to continue to pass in chromium.
2688         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp: This test relies on a callback that no longer
2689              is sent for about:blank loads.  Hook into didFinishLoadForFrame() instead.
2690         (TestWebKitAPI::didFinishLoadForFrame):
2691         (TestWebKitAPI::TEST):
2692
2693 2012-11-28  Sadrul Habib Chowdhury  <sadrul@chromium.org>
2694
2695         [chromium] Allow plugins to opt-in to receive synthetic mouse events out of touch events.
2696         https://bugs.webkit.org/show_bug.cgi?id=103092
2697
2698         Reviewed by Tony Chang.
2699
2700         Update the test web-plugin to be able to opt-in to receive synthesized mouse events created
2701         from touch events.
2702
2703         * DumpRenderTree/chromium/TestWebPlugin.cpp:
2704         (parseTouchEventRequestType):
2705         (TestWebPlugin::TestWebPlugin):
2706         (TestWebPlugin::initialize):
2707         * DumpRenderTree/chromium/TestWebPlugin.h:
2708         (TestWebPlugin):
2709
2710 2012-11-28  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
2711
2712         [EFL][WK2] Add support for PlatformWebView::simulateSpacebarKeyPress() in TestWebKitAPI
2713         https://bugs.webkit.org/show_bug.cgi?id=103123
2714
2715         Reviewed by Laszlo Gombos.
2716
2717         Add support for PlatformWebView::simulateSpacebarKeyPress().
2718         This functionality is needed by WebKit2 API test MouseMoveAfterCrash
2719         which is going to be unskipped in bug #103252.
2720
2721         * TestWebKitAPI/efl/PlatformUtilities.cpp:
2722         (TestWebKitAPI::Util::sleep):
2723         * TestWebKitAPI/efl/PlatformWebView.cpp: Use usleep() instead of
2724         sleep().
2725         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
2726         (TestWebKitAPI):
2727
2728 2012-11-28  Yael Aharon  <yael.aharon@intel.com>
2729
2730         Minor cleanup in TestInvocation
2731         https://bugs.webkit.org/show_bug.cgi?id=103512
2732
2733         Reviewed by Kenneth Rohde Christiansen.
2734
2735         Remove a function declaration that is not defined and not used.
2736         Fix spelling error in m_webProcessIsUnresponsive.
2737
2738         * WebKitTestRunner/TestInvocation.cpp:
2739         (WTR::TestInvocation::TestInvocation):
2740         (WTR::TestInvocation::invoke):
2741         * WebKitTestRunner/TestInvocation.h:
2742         (TestInvocation):
2743         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
2744         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
2745         * WebKitTestRunner/qt/TestInvocationQt.cpp:
2746         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
2747
2748 2012-11-28  Thiago Marcos P. Santos  <thiago.santos@intel.com>
2749
2750         Unreviewed. Use my personal email as bugzilla email.
2751
2752         * Scripts/webkitpy/common/config/committers.py:
2753
2754 2012-11-28  Thiago Marcos P. Santos  <thiago.santos@intel.com>
2755
2756         Unreviewed. Adding myself to committers.py.
2757
2758         * Scripts/webkitpy/common/config/committers.py:
2759
2760 2012-11-26  Andrey Adaikin  <aandrey@chromium.org>
2761
2762         Unreviewed. Adding myself to committers.py.
2763
2764         * Scripts/webkitpy/common/config/committers.py:
2765
2766 2012-11-28  Tommy Widenflycht  <tommyw@google.com>
2767
2768         Add basic implementation for MediaStreamAudioDestinationNode
2769         https://bugs.webkit.org/show_bug.cgi?id=101815
2770
2771         Reviewed by Chris Rogers.
2772
2773         Adds a bit of code that exercises the WebKit API.
2774
2775         * DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp:
2776         (MockWebMediaStreamSourceConsumer):
2777         (MockWebMediaStreamSourceConsumer::~MockWebMediaStreamSourceConsumer):
2778         (MockWebMediaStreamCenter::didCreateMediaStream):
2779
2780 2012-11-28  Matt Falkenhagen  <falken@chromium.org>
2781
2782         Unreviewed. Adding myself to committers list.
2783
2784         * Scripts/webkitpy/common/config/committers.py:
2785
2786 2012-11-27  Li Yin  <li.yin@intel.com>
2787
2788         Unreviewed. Adding myself to committers list.
2789
2790         * Scripts/webkitpy/common/config/committers.py:
2791
2792 2012-11-27  Christophe Dumez  <christophe.dumez@intel.com>
2793
2794         Unreviewed. Adding myself to committers.py.
2795
2796         * Scripts/webkitpy/common/config/committers.py:
2797
2798 2012-11-27  Vivek Galatage  <vivek.vg@samsung.com>
2799
2800         Unreviewd. Adding myself to committers list.
2801
2802         * Scripts/webkitpy/common/config/committers.py:
2803
2804 2012-11-27  Tony Chang  <tony@chromium.org>
2805
2806         Bring back partytime!
2807         https://bugs.webkit.org/show_bug.cgi?id=103466
2808
2809         Reviewed by Adam Barth.
2810
2811         "code 404, message Unknown function images/partytime_gif" since we didn't
2812         allow .gif or .png files to be served.
2813
2814         * Scripts/webkitpy/tool/servers/gardeningserver.py:
2815         (GardeningHTTPRequestHandler):
2816
2817 2012-11-27  Adam Barth  <abarth@webkit.org>
2818
2819         run-perf-tests fails on Android because of stderr output
2820         https://bugs.webkit.org/show_bug.cgi?id=103462
2821
2822         Reviewed by Ryosuke Niwa.
2823
2824         The chromium-android port produces some stderr output that causes
2825         run-perf-tests to get sad and not record the results of the performance
2826         test. This patch teaches run-perf-test to ignore this output much in
2827         the same way that it currently ignores some stdout messages.
2828
2829         * Scripts/webkitpy/performance_tests/perftest.py:
2830         (PerfTest.run):
2831         (PerfTest._should_ignore_line):
2832         (PerfTest):
2833         (PerfTest._should_ignore_line_in_stderr):
2834         (PerfTest._filter_stderr):
2835         (PerfTest._should_ignore_line_in_parser_test_result):
2836
2837 2012-11-27  Tony Chang  <tony@chromium.org>
2838
2839         Fix garden-o-matic for non-chromium ports
2840         https://bugs.webkit.org/show_bug.cgi?id=103458
2841
2842         Reviewed by Adam Barth.
2843
2844         I was getting a 403 error when trying to select any non-chromium port.
2845
2846         * Scripts/webkitpy/tool/servers/reflectionhandler.py:
2847         (ReflectionHandler._handle_request): Use the path without query params.
2848
2849 2012-11-27  Yael Aharon  <yael.aharon@intel.com>
2850
2851         [EFL][WK2] 3D pixel tests are failing
2852         https://bugs.webkit.org/show_bug.cgi?id=102833
2853
2854         Reviewed by Kenneth Rohde Christiansen.
2855
2856         Generate a snapshot of the view in the UI process instead of the web process.
2857         We have to use Texture Mapper in order to correctly paint 3D transforms etc.
2858
2859         * WebKitTestRunner/TestInvocation.h:
2860         (TestInvocation):
2861         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
2862         (WTR::writeFunction):
2863         (WTR::paintRepaintRectOverlay):
2864         (WTR):
2865         (WTR::TestInvocation::forceRepaintDoneCallback):
2866         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
2867         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2868         (WTR::PlatformWebView::windowSnapshotImage):
2869
2870 2012-11-27  Adam Barth  <abarth@webkit.org>
2871
2872         Make it possible to run performance tests on Chromium Android
2873         https://bugs.webkit.org/show_bug.cgi?id=103268
2874
2875         Reviewed by Ryosuke Niwa.
2876
2877         Based on a patch by Peter Beverloo.
2878
2879         This patch (almost) makes it possible to run WebKit performance tests
2880         on the Chromium port for Android. There are a few things I had to do
2881         in order to make this happen:
2882
2883         1) The worker number when creating a driver for a port is zero-based
2884            for layout tests and elsewhere. Android uses this to determine
2885            which device it has to run on, so make it zero based for performance
2886            tests as well.
2887
2888         2) Tests aren't available on the Android device, so we start an HTTP
2889            server that serves the tests to the device or emulator.
2890
2891         The one shortcoming of this patch is that chromium-android produces
2892         some stderr output that confuses run-perf-tests. I'll address that
2893         issue in a subsequent CL. This patch also depends on
2894         https://codereview.chromium.org/11416182 in order to work.
2895
2896         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2897         (ChromiumAndroidPort.start_http_server):
2898         (ChromiumAndroidDriver._command_from_driver_input):
2899         * Scripts/webkitpy/performance_tests/perftest.py:
2900         (ReplayPerfTest.prepare):
2901         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2902         (PerfTestsRunner.__init__):
2903         (PerfTestsRunner._parse_args):
2904         (PerfTestsRunner._start_servers):
2905         (PerfTestsRunner):
2906         (PerfTestsRunner._stop_servers):
2907         (PerfTestsRunner.run):
2908         (PerfTestsRunner._run_tests_set):
2909
2910 2012-11-27  Zan Dobersek  <zandobersek@gmail.com>
2911
2912         Remove use of deprecated logging from webkitpy.common and webkitpy.layout_tests
2913         https://bugs.webkit.org/show_bug.cgi?id=103408
2914
2915         Reviewed by Dirk Pranke.
2916
2917         Remove the use of the deprecated log and error methods by replacing them with
2918         logging through Python's logging.Logger objects.
2919
2920         This patch covers such changes in webkitpy.common and webkitpy.layout_tests and also
2921         updates any affected unit test.
2922
2923         * Scripts/webkitpy/common/checkout/changelog.py:
2924         (ChangeLogEntry._parse_entry):
2925         * Scripts/webkitpy/common/checkout/checkout.py:
2926         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
2927         (CheckoutTest.test_apply_patch):
2928         * Scripts/webkitpy/common/checkout/deps_mock.py:
2929         (MockDEPS.write_variable):
2930         * Scripts/webkitpy/common/checkout/scm/detection.py:
2931         (SCMDetector.default_scm):
2932         * Scripts/webkitpy/common/checkout/scm/detection_unittest.py:
2933         (SCMDetectorTest.test_detect_scm_system):
2934         * Scripts/webkitpy/common/checkout/scm/git.py:
2935         (Git._check_git_architecture):
2936         (Git._commit_on_branch):
2937         * Scripts/webkitpy/common/checkout/scm/scm.py:
2938         (SCM.ensure_clean_working_directory):
2939         (SCM.ensure_no_local_commits):
2940         (SCM.will.commit_locally_with_message):
2941         * Scripts/webkitpy/common/checkout/scm/svn.py:
2942         (SVN.apply_reverse_diff):
2943         * Scripts/webkitpy/common/net/bugzilla/attachment.py:
2944         (Attachment._validate_flag_value):
2945         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2946         (Bugzilla._fetch_bug_page):
2947         (Bugzilla.bug_id_for_attachment_id):
2948         (Bugzilla.authenticate):
2949         (Bugzilla._commit_queue_flag):
2950         (Bugzilla.add_attachment_to_bug):
2951         (Bugzilla.add_patch_to_bug):
2952         (Bugzilla.create_bug):
2953         (Bugzilla.clear_attachment_flags):
2954         (Bugzilla.set_flag_on_attachment):
2955         (Bugzilla.obsolete_attachment):
2956         (Bugzilla.add_cc_to_bug):
2957         (Bugzilla.post_comment_to_bug):
2958         (Bugzilla.close_bug_as_fixed):
2959         (Bugzilla.reassign_bug):
2960         (reopen_bug):
2961         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
2962         (MockBugzilla.create_bug):
2963         (MockBugzilla.reassign_bug):
2964         (MockBugzilla.set_flag_on_attachment):
2965         (MockBugzilla.post_comment_to_bug):
2966         (MockBugzilla.add_attachment_to_bug):
2967         (MockBugzilla.add_patch_to_bug):
2968         (MockBugzilla.reopen_bug):
2969         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
2970         (test_add_cc_to_bug):
2971         (_assert_reopen):
2972         (test_reopen_bug):
2973         * Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:
2974         (MockBuilder.force_build):
2975         * Scripts/webkitpy/common/net/credentials.py:
2976         (Credentials._run_security_tool):
2977         * Scripts/webkitpy/common/net/credentials_unittest.py:
2978         (_assert_security_call):
2979         * Scripts/webkitpy/common/net/irc/irc_mock.py:
2980         (MockIRC.post):
2981         (MockIRC.disconnect):
2982         * Scripts/webkitpy/common/net/irc/ircproxy.py:
2983         (IRCProxy.__init__):
2984         (IRCProxy.disconnect):
2985         * Scripts/webkitpy/common/net/irc/ircproxy_unittest.py:
2986         (IRCProxyTest.test_trivial):
2987         * Scripts/webkitpy/common/net/layouttestresults.py:
2988         (ORWTResultsHTMLParser._failures_from_fail_row):
2989         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2990         (test_failures_from_fail_row):
2991         * Scripts/webkitpy/common/net/networktransaction.py:
2992         * Scripts/webkitpy/common/net/resultsjsonparser.py:
2993         (JSONTestResult._tokenize):
2994         (JSONTestResult._failure_types_from_actual_result):
2995         * Scripts/webkitpy/common/net/statusserver.py:
2996         (StatusServer.update_status):
2997         (StatusServer.update_svn_revision):
2998         * Scripts/webkitpy/common/net/statusserver_mock.py:
2999         (MockStatusServer.release_work_item):
3000         (MockStatusServer.update_work_items):
3001         (MockStatusServer.submit_to_ews):
3002         (MockStatusServer.update_status):
3003         * Scripts/webkitpy/common/net/unittestresults.py:
3004         (UnitTestResults.results_from_string):
3005         * Scripts/webkitpy/common/system/executive_mock.py:
3006         (MockExecutive.running_pids):
3007         (MockExecutive.run_and_throw_if_fail):
3008         (MockExecutive.run_command):
3009         (MockExecutive.popen):
3010         * Scripts/webkitpy/common/system/user_mock.py:
3011         (MockUser.confirm):
3012         (MockUser.open_url):
3013         * Scripts/webkitpy/common/system/workspace_unittest.py:
3014         (WorkspaceTest.test_create_zip):
3015         (WorkspaceTest.test_create_zip_exception):
3016         * Scripts/webkitpy/common/watchlist/watchlist_mock.py:
3017         (MockWatchList.determine_cc_and_messages):
3018         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
3019         (ChromiumWinTest.test_setup_environ_for_server_register_cygwin):
3020         * Scripts/webkitpy/layout_tests/port/efl_unittest.py:
3021         (EflPortTest.test_show_results_html_file):
3022         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
3023         (GtkPortTest.test_show_results_html_file):
3024         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3025         (test_show_results_html_file):
3026         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3027         (test_build_driver):
3028         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
3029         (QtPortTest.test_show_results_html_file):
3030         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
3031         (WinPortTest.test_show_results_html_file):
3032         * Scripts/webkitpy/layout_tests/port/xvfbdriver_unittest.py:
3033         (XvfbDriverTest.assertDriverStartSuccessful):
3034         (XvfbDriverTest.test_start_no_pixel_tests):
3035         (XvfbDriverTest.test_start_pixel_tests):
3036         (XvfbDriverTest.test_start_arbitrary_worker_number):
3037         (XvfbDriverTest.test_start_next_worker):
3038         (XvfbDriverTest.test_stop):
3039         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
3040         (TestLayoutTestApacheHttpd.test_start_cmd):
3041         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3042         (test_run_test_pause_before_testing):
3043         (test_run_memory_test):
3044         (_test_run_with_json_output):
3045         (test_run_respects_no_results):
3046         (test_run_generates_and_show_results_page):
3047         (test_run_respects_no_show_results):
3048         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
3049         (FeedersTest.test_commit_queue_feeder):
3050         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3051         (FlakyTestReporterTest.test_create_bug_for_flaky_test):
3052         (test_report_flaky_tests_creating_bug):
3053         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
3054         (IRCCommandTest.test_rollout_updates_working_copy):
3055         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
3056         (IRCBotTest.test_exception_during_command):
3057         (IRCBotTest.test_hi):
3058         (IRCBotTest.test_help):
3059         (IRCBotTest.test_restart):
3060         (IRCBotTest.test_rollout):
3061         (IRCBotTest.test_revert):
3062         (IRCBotTest.test_roll_chromium_deps):
3063         (IRCBotTest.test_roll_chromium_deps_to_lkgr):
3064         (IRCBotTest.test_multi_rollout):
3065         (IRCBotTest.test_rollout_with_r_in_svn_revision):
3066         (IRCBotTest.test_multi_rollout_with_r_in_svn_revision):
3067         (IRCBotTest.test_rollout_bananas):
3068         (IRCBotTest.test_rollout_invalidate_revision):
3069         (IRCBotTest.test_rollout_invalidate_reason):
3070         (test_multi_rollout_invalidate_reason):
3071         (test_rollout_no_reason):
3072         (test_multi_rollout_no_reason):
3073         * Scripts/webkitpy/tool/bot/sheriff_unittest.py:
3074         (SheriffTest.test_post_blame_comment_on_bug):
3075         * Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py:
3076         (ApplyWatchListLocalTest.test_args_parsing):
3077         (test_args_parsing_with_bug):
3078         * Scripts/webkitpy/tool/commands/download_unittest.py:
3079         (test_land_cowboy):
3080         (test_check_style):
3081         (test_create_rollout):
3082         (test_create_rollout_resolved):
3083         (test_rollout):
3084         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3085         (AbstractEarlyWarningSystemTest.test_failing_tests_message):
3086         (EarlyWarningSytemTest._default_expected_logs):
3087         (EarlyWarningSytemTest._test_builder_ews):
3088         (EarlyWarningSytemTest._test_testing_ews):
3089         * Scripts/webkitpy/tool/commands/openbugs_unittest.py:
3090         (OpenBugsTest.test_args_parsing):
3091         * Scripts/webkitpy/tool/commands/queries_unittest.py:
3092         (QueryCommandsTest.test_bugs_to_commit):
3093         (QueryCommandsTest.test_patches_in_commit_queue):
3094         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3095         (FeederQueueTest.test_feeder_queue):
3096         (AbstractPatchQueueTest.test_next_patch):
3097         (AbstractPatchQueueTest.test_upload_results_archive_for_patch):
3098         (CommitQueueTest.test_commit_queue):
3099         (test_commit_queue_failure):
3100         (test_commit_queue_failure_with_failing_tests):
3101         (test_rollout):
3102         (test_rollout_lands):
3103         (test_auto_retry):
3104         (test_manual_reject_during_processing):
3105         (test_report_flaky_tests):
3106         (StyleQueueTest.test_style_queue_with_style_exception):
3107         (test_style_queue_with_watch_list_exception):
3108         * Scripts/webkitpy/tool/commands/queuestest.py:
3109         (QueuesTest._default_begin_work_queue_logs):
3110         * Scripts/webkitpy/tool/commands/roll_unittest.py:
3111         (RollCommandsTest.test_update_chromium_deps):
3112         * Scripts/webkitpy/tool/commands/upload_unittest.py:
3113         (UploadCommandsTest.test_assign_to_committer):
3114         (test_post):
3115         (test_attach_to_bug):
3116         (test_attach_to_bug_no_description_or_comment):
3117         (test_land_safely):
3118         (test_prepare):
3119         (test_upload):
3120         (test_mark_bug_fixed):
3121         * Scripts/webkitpy/tool/steps/applywatchlist_unittest.py:
3122         (ApplyWatchListTest.test_apply_watch_list_local):
3123         * Scripts/webkitpy/tool/steps/commit_unittest.py:
3124         (CommitTest._test_check_test_expectations):
3125         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
3126         (RunTestsTest.test_webkit_run_unit_tests):
3127         * Scripts/webkitpy/tool/steps/steps_unittest.py:
3128         (StepsTest._assert_step_output_with_bug):
3129         (StepsTest._assert_post_diff_output_for_bug):
3130         (StepsTest.test_post_diff):
3131         (StepsTest.test_post_diff_for_commit):
3132         (StepsTest.test_ensure_bug_is_open_and_assigned):
3133         (StepsTest.test_runtests_args):
3134         * Scripts/webkitpy/tool/steps/suggestreviewers_unittest.py:
3135         (SuggestReviewersTest.test_basic):
3136         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
3137         (ValidateChangeLogsTest._assert_start_line_produces_output):
3138
3139 2012-11-27  Pratik Solanki  <psolanki@apple.com>
3140
3141         objc/objc-runtime.h does not exist on all PLATFORM(MAC)
3142         https://bugs.webkit.org/show_bug.cgi?id=101780
3143
3144         Reviewed by Brent Fulgham.
3145
3146         Clean up header includes so we don't include objc/objc-runtime.h.
3147
3148         * DumpRenderTree/mac/DumpRenderTree.mm:
3149         * DumpRenderTree/mac/ObjCPlugin.m:
3150         * TestWebKitAPI/mac/InstanceMethodSwizzler.h:
3151         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
3152
3153 2012-11-27  Marja Hölttä  <marja@chromium.org>
3154
3155         Add callbacks to the FrameLoaderClient when a resource is requested
3156         https://bugs.webkit.org/show_bug.cgi?id=92761
3157
3158         Reviewed by Adam Barth.
3159
3160         In Chromium, when an extension script cancels a network
3161         request (which happens out of process), we'd like to
3162         notify content scripts running on the current page about
3163         which elements failed to load because the requests were
3164         cancelled (as opposed to e.g. the network request just
3165         didn't work). Since the resource request itself does not
3166         carry any information what DOM element is was made for,
3167         currently a content script has to search the DOM tree and
3168         guess which requests will be cancelled by its counter
3169         part. By adding these callbacks, the embedder can make
3170         this connection explictly.
3171
3172         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3173         (DRTTestRunner::DRTTestRunner):
3174         (DRTTestRunner::dumpResourceRequestCallbacks):
3175         (DRTTestRunner::reset):
3176         * DumpRenderTree/chromium/DRTTestRunner.h:
3177         (DRTTestRunner):
3178         (DRTTestRunner::setShouldDumpResourceRequestCallbacks):
3179         (DRTTestRunner::shouldDumpResourceRequestCallbacks):
3180         * DumpRenderTree/chromium/TestShell.h:
3181         (TestShell::shouldDumpResourceRequestCallbacks):
3182         * DumpRenderTree/chromium/WebViewHost.cpp:
3183         (WebViewHost::willRequestResource):
3184         * DumpRenderTree/chromium/WebViewHost.h:
3185         (WebViewHost):
3186
3187 2012-11-27  Víctor Manuel Jáquez Leal  <vjaquez@igalia.com>
3188
3189         [GStreamer] Verify if GStreamer was previously initialized
3190         https://bugs.webkit.org/show_bug.cgi?id=103151
3191
3192         Reviewed by Philippe Normand.
3193
3194         This patch adds the gst_init() in GtkLauncher, so we can add the
3195         GStreamer options in the command line through
3196         gst_init_get_option_group().
3197
3198         This approach is not valid for MiniBrowser because it uses WebKit2,
3199         where the GStreamer backend lives in the web process, which is
3200         different from the UI process.
3201
3202         * GNUmakefile.am:
3203         * GtkLauncher/main.c:
3204         (main):
3205
3206 2012-11-27  Andras Becsi  <andras.becsi@digia.com>
3207
3208         [Qt] Fix the build with new Qt5 hash
3209         https://bugs.webkit.org/show_bug.cgi?id=103406
3210
3211         Reviewed by Csaba Osztrogonác.
3212
3213         Remove references to deprecated QApplication::GuiServer which
3214         has been removed, and use QStyleFactory::create instead of
3215         instantiating a QWindowsStyle directly since it is about to
3216         become an internal class.
3217
3218         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
3219         (main):
3220         * QtTestBrowser/qttestbrowser.cpp:
3221         (LauncherApplication::LauncherApplication):
3222         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
3223         (WTR::InjectedBundle::platformInitialize):
3224
3225 2012-11-27  Sadrul Habib Chowdhury  <sadrul@chromium.org>
3226
3227         [style] Add a style-check for enum-member names
3228         https://bugs.webkit.org/show_bug.cgi?id=103157
3229
3230         Reviewed by Daniel Bates.
3231
3232         * Scripts/webkitpy/style/checkers/cpp.py:
3233         (_EnumState):
3234         (_EnumState.__init__):
3235         (_EnumState.process_clean_line):
3236         (check_enum_casing):
3237         (check_style):
3238         (process_line):
3239         (_process_lines):
3240         (CppChecker):
3241         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3242         (NoNonVirtualDestructorsTest.test_enum_casing):
3243         (NoNonVirtualDestructorsTest.test_internal_braces.Foo):
3244
3245 2012-11-26  Ryuan Choi  <ryuan.choi@gmail.com>
3246
3247         [EFL][jhbuild] Disable unnecessary options of elementary module
3248         https://bugs.webkit.org/show_bug.cgi?id=103360
3249
3250         Reviewed by Gyuyoung Kim.
3251
3252         When jhbuild configures elementary, unnecessary options may be enabled by
3253         user installed modules and it causes build break.
3254
3255         * efl/jhbuild.modules:
3256         Added --disable-emap --disable-ethumb --disable-eweather to elementary.
3257
3258 2012-11-26  Varun Jain  <varunjain@chromium.org>
3259
3260         LongPress and LongTap gestures should start drag/drop and open context menu respectively.
3261         https://bugs.webkit.org/show_bug.cgi?id=101545
3262
3263         Reviewed by Antonio Gomes.
3264
3265         For LongPress, we simulate drag by sending a mouse down and mouse drag
3266         events. If a drag is not started (because maybe there is no draggable
3267         element), then we show context menu instead (which is the current
3268         behavior for LongPress). For LongTap, we use the existing functions that
3269         LongPress uses to summon the context menu. LongPress initiated drag and
3270         drop can be enabled/disabled by the platform using the Setting
3271         touchDragDropEnabled which is disabled by default.
3272
3273         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
3274         (WebTestRunner):
3275         (WebTestRunner::EventSender::EventSender):
3276         (WebTestRunner::EventSender::gestureLongTap):
3277         (WebTestRunner::EventSender::gestureEvent):
3278         * DumpRenderTree/chromium/TestRunner/src/EventSender.h:
3279         (EventSender):
3280         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3281         (WebTestRunner::TestRunner::TestRunner):
3282         (WebTestRunner::TestRunner::setTouchDragDropEnabled):
3283         (WebTestRunner):
3284         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3285         (TestRunner):
3286
3287 2012-11-26  Christophe Dumez  <christophe.dumez@intel.com>
3288
3289         [EFL][WK2] Add setting to enable / disable HTML5 local storage functionality
3290         https://bugs.webkit.org/show_bug.cgi?id=103224
3291
3292         Reviewed by Laszlo Gombos.
3293
3294         Add --local-storage command line argument to MiniBrowser to
3295         explicitely disable HTML5 local storage functionality. This
3296         is useful for testing purposes.
3297
3298         * MiniBrowser/efl/main.c:
3299         (window_create):
3300         (elm_main):
3301
3302 2012-11-26  Zan Dobersek  <zandobersek@gmail.com>
3303
3304         Remove use of deprecated logging from most of webkitpy.tool
3305         https://bugs.webkit.org/show_bug.cgi?id=103180
3306
3307         Reviewed by Dirk Pranke.
3308
3309         Remove calls to log and error methods of the deprecated_logging module, replacing them
3310         by using Python's Logger objects. This patch covers the switch in all of webkitpy.tool
3311         except the QueueEngine.
3312
3313         Unit tests are adjusted for these changes, moving output from expected stderr to expected logs.
3314
3315         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3316         (MockCommitQueue.run_command):
3317         (MockCommitQueue.command_passed):
3318         (MockCommitQueue.command_failed):
3319         (MockCommitQueue.report_flaky_tests):
3320         (MockCommitQueue.archive_last_test_results):
3321         (CommitQueueTaskTest._run_through_task):
3322         (CommitQueueTaskTest.test_success_case):
3323         (test_fast_success_case):
3324         (test_clean_failure):
3325         (test_update_failure):
3326         (test_apply_failure):
3327         (test_validate_changelog_failure):
3328         (test_build_failure):
3329         (test_red_build_failure):
3330         (test_flaky_test_failure):
3331         (test_failed_archive):
3332         (test_double_flaky_test_failure):
3333         (test_test_failure):
3334         (test_red_test_failure):
3335         (test_very_red_tree_retry):
3336         (test_red_tree_patch_rejection):
3337         (test_land_failure):
3338         * Scripts/webkitpy/tool/bot/feeders.py:
3339         (CommitQueueFeeder._update_work_items):
3340         (EWSFeeder.feed):
3341         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
3342         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
3343         (LayoutTestResultsReader.archive):
3344         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
3345         (test_archive_last_layout_test_results):
3346         * Scripts/webkitpy/tool/bot/sheriff.py:
3347         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
3348         (AbstractSequencedCommand.execute):
3349         * Scripts/webkitpy/tool/commands/commandtest.py:
3350         (CommandsTest.assert_execute_outputs):
3351         * Scripts/webkitpy/tool/commands/download.py:
3352         (AbstractPatchProcessingCommand._process_patch.execute):
3353         (ProcessBugsMixin._fetch_list_of_patches_to_process):
3354         (ProcessURLsMixin._fetch_list_of_patches_to_process):
3355         (AbstractRolloutPrepCommand._commit_info):
3356         * Scripts/webkitpy/tool/commands/download_unittest.py:
3357         (AbstractRolloutPrepCommandTest.test_commit_info):
3358         (DownloadCommandsTest.test_build):
3359         (DownloadCommandsTest.test_build_and_test):
3360         (test_apply_attachment):
3361         (test_apply_from_bug):
3362         (test_apply_watch_list):
3363         (test_land):
3364         (test_land_red_builders):
3365         (test_check_style):
3366         (test_build_attachment):
3367         (test_land_attachment):
3368         (test_land_from_bug):
3369         (test_land_from_url):
3370         (test_prepare_rollout):
3371         (test_create_rollout):
3372         (test_create_rollout_resolved):
3373         (test_rollout):
3374         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3375         (AbstractEarlyWarningSystem.handle_script_error.does):
3376         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3377         (EarlyWarningSytemTest._default_expected_stderr):
3378         (EarlyWarningSytemTest._default_expected_logs):
3379         (EarlyWarningSytemTest._test_testing_ews):
3380         * Scripts/webkitpy/tool/commands/openbugs.py:
3381         (OpenBugs.execute):
3382         * Scripts/webkitpy/tool/commands/openbugs_unittest.py:
3383         (OpenBugsTest.test_args_parsing):
3384         * Scripts/webkitpy/tool/commands/perfalizer.py:
3385         (Perfalizer.handle_unexpected_error):
3386         * Scripts/webkitpy/tool/commands/queries.py:
3387         (PatchesInCommitQueue.execute):
3388         (PatchesToCommitQueue._needs_commit_queue):
3389         * Scripts/webkitpy/tool/commands/queries_unittest.py:
3390         (QueryCommandsTest.test_bugs_to_commit):
3391         (QueryCommandsTest.test_patches_in_commit_queue):
3392         (QueryCommandsTest.test_patches_to_commit_queue):
3393         * Scripts/webkitpy/tool/commands/queues.py:
3394         (AbstractQueue._cc_watchers):
3395         (AbstractQueue.begin_work_queue):
3396         (FeederQueue.handle_unexpected_error):
3397         (CommitQueue.handle_script_error):
3398         (AbstractReviewQueue.handle_unexpected_error):
3399         (AbstractReviewQueue.handle_script_error):
3400         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3401         (test_auto_retry):
3402         * Scripts/webkitpy/tool/commands/queuestest.py:
3403         (QueuesTest.assert_outputs):
3404         (QueuesTest._default_begin_work_queue_stderr):
3405         (QueuesTest):
3406         (QueuesTest._default_begin_work_queue_logs):
3407         (QueuesTest.assert_queue_outputs):
3408         * Scripts/webkitpy/tool/commands/roll_unittest.py:
3409         (RollCommandsTest.test_update_chromium_deps):
3410         (test_update_chromium_deps_older_revision):
3411         * Scripts/webkitpy/tool/commands/sheriffbot.py:
3412         (SheriffBot.handle_unexpected_error):
3413         * Scripts/webkitpy/tool/commands/stepsequence.py:
3414         (StepSequence.run_and_handle_errors):
3415         * Scripts/webkitpy/tool/commands/upload.py:
3416         (AssignToCommitter._assign_bug_to_last_patch_attacher):
3417         (AbstractPatchUploadingCommand._prepare_state):
3418         (PostCommits.execute):
3419         (MarkBugFixed._determine_bug_id_and_svn_revision):
3420         (MarkBugFixed.execute):
3421         (CreateBug.create_bug_from_commit):
3422         (CreateBug.execute):
3423         * Scripts/webkitpy/tool/commands/upload_unittest.py:
3424         (test_obsolete_attachments):
3425         (test_land_safely):
3426         (test_mark_bug_fixed):
3427         * Scripts/webkitpy/tool/multicommandtool.py:
3428         (Command.check_arguments_and_execute):
3429         (MultiCommandTool.main):
3430         * Scripts/webkitpy/tool/multicommandtool_unittest.py:
3431         (CommandTest.test_required_arguments):
3432         * Scripts/webkitpy/tool/steps/addsvnmimetypeforpng.py:
3433         (AddSvnMimetypeForPng.run):
3434         * Scripts/webkitpy/tool/steps/applypatch.py:
3435         (ApplyPatch.run):
3436         * Scripts/webkitpy/tool/steps/build.py:
3437         (Build.run):
3438         * Scripts/webkitpy/tool/steps/checkstyle.py:
3439         * Scripts/webkitpy/tool/steps/closebug.py:
3440         (CloseBug.run):
3441         * Scripts/webkitpy/tool/steps/closebugforlanddiff.py:
3442         (CloseBugForLandDiff.run):
3443         * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
3444         (CloseBugForLandDiffTest.test_empty_state):
3445         * Scripts/webkitpy/tool/steps/commit.py:
3446         (Commit.run):
3447         * Scripts/webkitpy/tool/steps/commit_unittest.py:
3448         (CommitTest._test_check_test_expectations):
3449         * Scripts/webkitpy/tool/steps/ensurelocalcommitifneeded.py:
3450         (EnsureLocalCommitIfNeeded.run):
3451         * Scripts/webkitpy/tool/steps/obsoletepatches.py:
3452         (ObsoletePatches.run):
3453         * Scripts/webkitpy/tool/steps/preparechangelog.py:
3454         (PrepareChangeLog.run):
3455         * Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
3456         (ReopenBugAfterRollout.run):
3457         * Scripts/webkitpy/tool/steps/runtests.py:
3458         (RunTests.run):
3459         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
3460         (RunTestsTest.test_webkit_run_unit_tests):
3461         * Scripts/webkitpy/tool/steps/steps_unittest.py:
3462         (StepsTest.test_update_step):
3463         (StepsTest.test_runtests_args):
3464         * Scripts/webkitpy/tool/steps/update.py:
3465         (Update.run):
3466         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
3467         (UpdateChangeLogsWithReviewerTest.test_guess_reviewer_from_bug):
3468         (UpdateChangeLogsWithReviewerTest.test_guess_reviewer_from_multipatch_bug):
3469         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
3470         (UpdateChangeLogsWithReviewer._guess_reviewer_from_bug):
3471         (UpdateChangeLogsWithReviewer.run):
3472         * Scripts/webkitpy/tool/steps/updatechromiumdeps.py:
3473         (UpdateChromiumDEPS._validate_revisions):
3474         (UpdateChromiumDEPS.run):
3475         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
3476         (ValidateChangeLogs._check_changelog_diff):
3477         (ValidateChangeLogs.run):
3478         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
3479         (ValidateChangeLogsTest._assert_start_line_produces_output):
3480         * Scripts/webkitpy/tool/steps/validatereviewer.py:
3481         (ValidateReviewer.run):
3482
3483 2012-11-26  Zan Dobersek  <zandobersek@gmail.com>
3484
3485         Coverage testing in webkitpy should omit some paths
3486         https://bugs.webkit.org/show_bug.cgi?id=103267
3487
3488         Reviewed by Dirk Pranke.
3489
3490         Omit testing coverage of any file under /usr directory and any file
3491         that is of third party origin and was autoinstalled.
3492
3493         * Scripts/webkitpy/test/main.py:
3494         (Tester._run_tests):
3495
3496 2012-11-26  Jaehun Lim  <ljaehun.lim@samsung.com>
3497
3498         Text Autosizing: Add Text Autosizing APIs for WK2
3499         https://bugs.webkit.org/show_bug.cgi?id=100633
3500
3501         Reviewed by Sam Weinig.
3502
3503         Add test cases for Text Autosizing in WKPreferences.
3504
3505         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
3506         (TestWebKitAPI::TEST):
3507
3508 2012-11-26  Pierre Rossi  <pierre.rossi@gmail.com>
3509
3510         [Qt] REGRESSION(r135575): It made all tests assert
3511         https://bugs.webkit.org/show_bug.cgi?id=103169
3512
3513         Reviewed by Simon Hausmann.
3514
3515         This fixes another regression introduced in r135515:
3516         initializeWebKitQt shouldn't implicitely call initializeWebCoreQt
3517         since it can be called from WebKit2 to initialize QStyle for testing.
3518         This would then lead to things such as PlatformStrategies being
3519         initialized twice.
3520
3521         * DumpRenderTree/qt/DumpRenderTreeQt.cpp: Also propagate the change to DRT this time.
3522         (WebCore::DumpRenderTree::DumpRenderTree):
3523
3524 2012-11-24  Zan Dobersek  <zandobersek@gmail.com>
3525
3526         Add the --order option to NRWT
3527         https://bugs.webkit.org/show_bug.cgi?id=102229
3528
3529         Reviewed by Dirk Pranke.
3530
3531         The --order option controls in what order the gathered tests will be run.
3532         There are 3 options:
3533         - natural, the tests are sorted in natural order,
3534         - random, the tests are sorted in random order,
3535         - none, the tests are kept in the order in which they were specified through
3536         arguments or the test list.
3537
3538         The natural option is the default one and maintains the current behavior.
3539
3540         The none option is primarily intended to be used with the --test-list option,
3541         with the test list file expected to list specific test names.
3542         When a directory is specified as one of the paths from under which tests should
3543         be gathered and the none option is used, that path will expand to all the tests
3544         under it, with these tests sorted in the natural order.
3545
3546         Using --order=random duplicated the behavior of the --randomize-order option, so
3547         the latter is removed.
3548
3549         This patch also incorporates the change with which makes it is possible to specify
3550         a test via arguments or the test list multiple tests and then have the test run
3551         that many times.
3552
3553         * Scripts/webkitpy/common/find_files.py:
3554         (find): Accept an optional sorting key that is used to sort files found in the directories
3555         that the given paths specify.
3556         (_normalized_find): Both paths that are then searched for the tests and the tests that
3557         were found are now kept in lists. This makes it possible to run a test multiple times
3558         by specifying it multiple times through arguments or the test list file.
3559         (_normalized_find.sort_by_directory_key):
3560         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
3561         (LayoutTestFinder.find_tests): Keep the paths where we should search for tests in a list.
3562         (LayoutTestFinder.skip_tests): Subtracting from a set of paths is necessary.
3563         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
3564         (LayoutTestRunner.__init__): The Sharder class no longer needs a test path separator.
3565         (Sharder.__init__): Ditto.
3566         (Sharder._resize_shards):
3567         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
3568         (SharderTests.get_shards): Modify the Shader initializing as required.
3569         (SharderTests.test_multiple_locked_shards): The natural sorting and test name key unit tests
3570         are now moved to the base Port unit tests.
3571         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3572         (Manager._prepare_lists): Keep the test names in a list. Order that list as specified by
3573         the new --order option.
3574         * Scripts/webkitpy/layout_tests/port/base.py:
3575         (Port.tests): This method should now return a list of all the tests found in the specified
3576         paths.
3577         (Port._real_tests): A list is required, so no conversion to a set is made.
3578         (Port):
3579         (Port.test_key): Place this method here for now, but it should really move into a separate
3580         module.
3581         (Port._natural_sort_key): Ditto.
3582         (Port._natural_sort_key.tryint):
3583         (Port._virtual_tests): A list is required, so the function now operates on that rather than
3584         on a set.
3585         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3586         (PortTest.test_find_with_skipped_directories_2): Adjust the test case to check for an empty
3587         list rather than an empty set.
3588         (PortTest.test_dont_require_http_server):
3589         (NaturalCompareTest): The natural sorting unit tests are placed here for now.
3590         (NaturalCompareTest.assert_cmp):
3591         (NaturalCompareTest.test_natural_compare):
3592         (KeyCompareTest): The test name key unit tests are placed here for now.
3593         (KeyCompareTest.assert_cmp):
3594         (KeyCompareTest.test_test_key):
3595         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3596         (parse_args): Remove the --randomize-order option, it's now possible to replicate its behavior
3597         by using --order=random.
3598         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Add unit tests covering
3599         various aspects of this change.
3600         (MainTest.test_natural_order):
3601         (MainTest):
3602         (MainTest.test_natural_order_test_specified_multiple_times):
3603         (MainTest.test_random_order):
3604         (MainTest.test_random_order_test_specified_multiple_times):
3605         (MainTest.test_no_order):
3606         (MainTest.test_no_order_test_specified_multiple_times):
3607         (MainTest.test_no_order_with_directory_entries_in_natural_order):
3608         * Scripts/webkitpy/tool/commands/queries.py:
3609         (PrintExpectations.execute): Operate on a set of tests when printing out expectations.
3610
3611 2012-11-24  Sheriff Bot  <webkit.review.bot@gmail.com>
3612
3613         Unreviewed, rolling out r135600.
3614         http://trac.webkit.org/changeset/135600
3615         https://bugs.webkit.org/show_bug.cgi?id=103173
3616
3617         It made EFL API test is failed (Requested by gyuyoung_mbp on
3618         #webkit).
3619
3620         * TestWebKitAPI/PlatformEfl.cmake:
3621         * TestWebKitAPI/efl/PlatformUtilities.cpp:
3622         (TestWebKitAPI::Util::sleep):
3623         * TestWebKitAPI/efl/PlatformWebView.cpp:
3624
3625 2012-11-23  Alexis Menard  <alexis@webkit.org>