1 2014-09-24 Langó László <llango.u-szeged@partner.samsung.com>
3 Update the list of u-szeged contributors.
5 Rubber-stamped by Csaba Osztrogonác <ossy@webkit.org>.
7 * Scripts/webkitpy/common/config/contributors.json:
9 2014-09-23 Roger Fong <roger_fong@apple.com>
11 [Windows] More debugging for the Windows bots.
13 * Scripts/webkitpy/common/system/path.py:
16 2014-09-23 Roger Fong <roger_fong@apple.com>
18 Unreviewed. Fix for r173899, those tabs should be spaces.
20 * Scripts/webkitpy/port/driver.py:
21 (Driver._command_from_driver_input):
24 2014-09-23 Roger Fong <roger_fong@apple.com>
26 [Windows] Add some logging to debug a problem with the Windows bots that causes layout tests to exit early.
28 * Scripts/webkitpy/port/driver.py:
31 2014-09-23 Jer Noble <jer.noble@apple.com>
33 [Tools] git-commit uses wrong ChangeLog when run from a subdirectory
34 https://bugs.webkit.org/show_bug.cgi?id=137031
36 Reviewed by Joseph Pecoraro.
38 commit-log-editor is run from the top of the Git checkout, even when git-commit is invoked
39 from a subdirectory, making the parsed locations of ChangeLog files incorrect. Git provides
40 a mapping prefix in the GIT_PREFIX environment variable, so apply this prefix to the parsed
41 ChangeLog locations before passing them to createCommitMessage().
43 * Scripts/commit-log-editor:
45 2014-09-23 Youenn Fablet <youenn.fablet@crf.canon.fr>
47 W3C test importer should detect manual and reference tests according their filenames
48 https://bugs.webkit.org/show_bug.cgi?id=133852
50 Reviewed by Bem Jones-Bey.
52 * Scripts/webkitpy/w3c/test_parser.py:
53 (TestParser.analyze_test): Adding checks based on WPT filename rules.
54 (TestParser.is_wpt_manualtest): Detecting whether the test is a manual test based on its filename.
56 (TestParser.potential_ref_filename): Getting the potential reference filename of a test from its filename.
57 (TestParser.is_wpt_reftest): Detecting whether the test is a ref test based on its filename.
58 * Scripts/webkitpy/w3c/test_parser_unittest.py:
59 (test_analyze_manual_wpt_test): Adding a test for a "-manual.html" file with testharness.js link in it.
61 2014-09-23 Bem Jones-Bey <bjonesbe@adobe.com>
63 Unreviewed, add Rebecca Hauck as a contributor.
65 * Scripts/webkitpy/common/config/contributors.json:
67 2014-09-23 David Kilzer <ddkilzer@apple.com>
69 Switch build.webkit.org URLs to https
71 Reviewed by Lucas Forschler and Alexey Proskuryakov.
73 * TestResultServer/app.yaml: Update version to this commit
76 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
77 * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
78 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
79 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/WebKitBuildbot.js:
81 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
82 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
83 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
85 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
87 * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
88 * Scripts/webkitpy/common/config/urls.py:
89 * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
90 (test_builder_with_name):
91 * Scripts/webkitpy/tool/commands/queries.py:
93 * TestResultServer/generate_builders_json.py:
95 * TestResultServer/generate_builders_json_unittest.py:
96 (GenerateBuildersJsonTest.test_generate_json_data.dummy_fetch_json):
97 (GenerateBuildersJsonTest):
98 (GenerateBuildersJsonTest.test_generate_json_data):
99 * TestResultServer/static-dashboards/builders.jsonp:
100 * TestResultServer/static-dashboards/flakiness_dashboard.js:
101 (loadExpectationsLayoutTests):
102 * TestResultServer/static-dashboards/timeline_explorer.js:
104 2014-09-23 Youenn Fablet <youenn.fablet@crf.canon.fr>
106 W3C test importer should copy .htaccess files
107 https://bugs.webkit.org/show_bug.cgi?id=136850
109 Reviewed by Bem Jones-Bey.
111 * Scripts/webkitpy/w3c/test_importer.py:
112 (TestImporter.should_skip_file): Helper function to check whether to skip file or not. Added ".htaccess" file specific check.
114 (TestImporter.find_importable_tests): Making use of new helper function.
116 2014-09-23 Alexey Proskuryakov <ap@apple.com>
118 Trying to revive bot watcher's dashboard after HSTS.
122 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
123 (WebKitBuildbot): It looks like XMLHttpRequest may not like HSTS redirects, let's try to avoid these.
125 2014-09-23 Tibor Meszaros <tmeszaros.u-szeged@partner.samsung.com>
127 Make Tools/BuildSlaveSupport/wait-for-SVN-server.py handle server donwtime
128 https://bugs.webkit.org/show_bug.cgi?id=137026
130 Reviewed by Csaba Osztrogonác.
132 * BuildSlaveSupport/wait-for-SVN-server.py:
133 (getLatestSVNRevision):
134 (waitForSVNRevision):
136 2014-09-23 Tibor Meszaros <tmeszaros.u-szeged@partner.samsung.com>
138 Remove unlinkZeroFiles from build-webkit
139 https://bugs.webkit.org/show_bug.cgi?id=137018
141 Reviewed by Csaba Osztrogonác.
143 * Scripts/build-webkit:
144 (unlinkZeroFiles): Deleted.
146 2014-09-23 Rohit Kumar <kumar.rohit@samsung.com>
148 [GTK] Minibrowser : Add keyboard support for stop page load
149 https://bugs.webkit.org/show_bug.cgi?id=136857
151 Reviewed by Philippe Normand.
153 Keyboard support to stop page load in GTK Minibrowser using F6 and Escape keys.
155 * MiniBrowser/gtk/BrowserWindow.c:
156 (stopPageLoad): Callback to stop page load.
157 (browser_window_init):
159 2014-09-22 Rohit Kumar <kumar.rohit@samsung.com>
161 [EFL][WK2] Minibrowser : Add keyboard support for page reload while ignoring cache
162 https://bugs.webkit.org/show_bug.cgi?id=136813
164 Reviewed by Gyuyoung Kim.
166 Ctrl+r is used for page reload along with F5. Ctrl+Shift+r and Ctrl+F5 is used for page reload while ignoring cache.
168 * MiniBrowser/efl/main.c:
171 2014-09-22 Daniel Bates <dabates@apple.com>
173 [Cocoa] Add UI delegate callback when window.close() is called
174 https://bugs.webkit.org/show_bug.cgi?id=137008
175 <rdar://problem/17801001>
177 Reviewed by Anders Carlsson.
179 Add a test to ensure that -[WKUIDelegatePrivate _webViewClose:] is called on window.close()
180 for window opened via JavaScript (i.e. window.open()).
182 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
183 * TestWebKitAPI/Tests/WebKit2/open-and-close-window.html: Added.
184 * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm: Added.
186 2014-09-22 Youenn Fablet <youennf@gmail.com>
188 W3C importer should import html files within resources folders
189 https://bugs.webkit.org/show_bug.cgi?id=127548
191 Reviewed by Ryosuke Niwa.
193 Import HTML files in any folder named "resources" even if file is not detected as a HTML test file
195 * Scripts/webkitpy/w3c/test_importer.py:
196 (TestImporter.find_importable_tests):
198 2014-09-22 Carlos Garcia Campos <cgarcia@igalia.com>
200 [GTK] Test /webkit2/WebKitWebView/can-show-mime-type fails if evince browser plugin is installed
201 https://bugs.webkit.org/show_bug.cgi?id=136998
203 Reviewed by Philippe Normand.
205 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
206 (testWebViewCanShowMIMEType): Remove the check of PDF as
207 unsupported MIME type.
209 2014-09-22 Carlos Garcia Campos <cgarcia@igalia.com>
211 Unreviewed. Fix WebKitGTKTranslations rule in watchlist.
213 In r145081 GTK+ translations were moved from Source/WebKit/gtk/po/
214 to Source/WebCore/platform/gtk/po/ but the rule was not updated.
216 * Scripts/webkitpy/common/config/watchlist: Use
217 Source/WebCore/platform/gtk/po/ as directory to watch for
218 WebKitGTKTranslations rule and add berto and myself to the list of
221 2014-09-22 Ryuan Choi <ryuan.choi@gmail.com>
223 Fix syntaxError in watchlist since r173594
224 https://bugs.webkit.org/show_bug.cgi?id=136996
226 Reviewed by Philippe Normand.
228 * Scripts/webkitpy/common/config/watchlist: Removed unnecessary comma.
230 2014-09-20 Sam Weinig <sam@webkit.org>
232 Make possible HashSet<std::unique_ptr<>>
233 https://bugs.webkit.org/show_bug.cgi?id=136166
235 Reviewed by Darin Adler.
237 * TestWebKitAPI/Tests/WTF/CopyMoveCounter.h: Removed.
238 * TestWebKitAPI/Counters.cpp: Added.
239 * TestWebKitAPI/Counters.h: Copied from Tools/TestWebKitAPI/Tests/WTF/CopyMoveCounter.h.
240 Move the CopyMoveCounter helper from CopyMoveCounter.h to Counters.h, and add a ConstructorDestructorCounter
241 helper to the mix as well. Add Counters.cpp to allow for the global variables to be used in more than one
244 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
247 * TestWebKitAPI/Tests/WTF/HashMap.cpp:
248 Add tests for using std::unique_ptr and OwnPtr as the key's of a HashMap.
250 * TestWebKitAPI/Tests/WTF/HashSet.cpp:
251 Add tests for using std::unique_ptr and OwnPtr as the values of a HashSet.
253 2014-09-21 Youenn Fablet <youenn.fablet@crf.canon.fr>
255 run-webkit-tests should count tests submitted as absolute paths once
256 https://bugs.webkit.org/show_bug.cgi?id=136848
258 Reviewed by Darin Adler.
260 * Scripts/webkitpy/port/base.py:
261 (Port._expanded_paths): In case of absolute path, do not search for platform specific tests.
263 2014-09-19 Joseph Pecoraro <pecoraro@apple.com>
265 JSStringRef leak on the leaks bot allocation under selectTextWithCriteriaCallback
266 https://bugs.webkit.org/show_bug.cgi?id=136974
268 Reviewed by Chris Fleizach.
270 * DumpRenderTree/AccessibilityUIElement.cpp:
271 (selectTextWithCriteriaCallback):
272 Be sure to release the string if it was allocated.
274 2014-09-19 Alexey Proskuryakov <ap@apple.com>
276 build.webkit.org/dashboard: Pending builds don't show up when there is a commit with no comments
277 https://bugs.webkit.org/show_bug.cgi?id=136966
279 Reviewed by Daniel Bates.
281 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
282 (Trac.prototype._convertCommitInfoElementToObject): Tolerate these horrible commits.
284 2014-09-19 Gyuyoung Kim <gyuyoung.kim@samsung.com>
286 [CoordinatedGraphics][EFL] window.scrollTo(x, y) doesn't work when fixed layout is enabled
287 https://bugs.webkit.org/show_bug.cgi?id=136917
289 Reviewed by Darin Adler.
291 Added WKViewScrollTo.cpp and scrollTo.html to test this issue.
293 * TestWebKitAPI/PlatformEfl.cmake:
294 * TestWebKitAPI/Tests/WebKit2/efl/WKViewScrollTo.cpp: Added.
295 (TestWebKitAPI::didFinishLoadForFrame):
296 (TestWebKitAPI::TEST):
297 * TestWebKitAPI/Tests/WebKit2/efl/scrollTo.html: Added.
299 2014-09-19 Daniel Bates <dabates@apple.com>
301 Always assume internal SDK when building configuration Production
302 https://bugs.webkit.org/show_bug.cgi?id=136925
303 <rdar://problem/18362399>
305 Reviewed by Dan Bernstein.
307 * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
308 * MiniBrowser/Configurations/DebugRelease.xcconfig:
309 * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
310 * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
312 2014-09-19 Youenn Fablet <youenn.fablet@crf.canon.fr>
314 WTR and DRT didReceiveAuthenticationChallengeInFrame should print messages consistently
315 https://bugs.webkit.org/show_bug.cgi?id=136847
317 Added protection space host and port logging to WTR didReceiveAuthenticationChallengeInFrame.
319 Reviewed by Alexey Proskuryakov.
321 * WebKitTestRunner/TestController.cpp:
322 (WTR::TestController::didReceiveAuthenticationChallengeInFrame):
324 2014-09-19 Carlos Garcia Campos <cgarcia@igalia.com>
326 [GTK] Missing inspector files in the tarball
327 https://bugs.webkit.org/show_bug.cgi?id=136952
329 Reviewed by Gustavo Noronha Silva.
331 * gtk/manifest.txt: Add
332 Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js
335 2014-09-19 Carlos Garcia Campos <cgarcia@igalia.com>
337 Webkitgtk 2.5.3: tarball contains APPLE LICENSE file - stating not distributable
338 https://bugs.webkit.org/show_bug.cgi?id=136632
340 Reviewed by Gustavo Noronha Silva.
342 * gtk/generate-inspector-gresource-manifest.py: Use an alias for
344 * gtk/manifest.txt: Only include the free icons in the tarball.
346 2014-09-19 Carlos Garcia Campos <cgarcia@igalia.com>
348 [GTK] generate-inspector-gresource-manifest.py should receive the list of files from the makefile
349 https://bugs.webkit.org/show_bug.cgi?id=136943
351 Reviewed by Philippe Normand.
353 Update the script to receive the list of files from the command
354 line instead of scanning the given directories.
356 * gtk/generate-inspector-gresource-manifest.py:
357 (get_filenames): Convert filenames to use relative paths.
358 (find_all_files_in_directory): Deleted.
359 (find_all_files_in_directory.select_file): Deleted.
361 2014-09-18 Tanay C <tanay.c@samsung.com>
363 [EFL][WK2] Minibrowser : Support Zoom on Control key + scroll
364 https://bugs.webkit.org/show_bug.cgi?id=136739
366 Reviewed by Gyuyoung Kim.
368 * MiniBrowser/efl/main.c: Add support for zoom on control key + mouse scroll
369 (on_mouse_wheel): Modified.
371 2014-09-18 Carlos Garcia Campos <cgarcia@igalia.com>
373 [GTK] Dot not allow to create delete-on-destroy GMainLoopSources
374 https://bugs.webkit.org/show_bug.cgi?id=136923
376 Reviewed by Gustavo Noronha Silva.
378 * TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp:
379 (TestWebKitAPI::TEST): Use the new API that doesn't allow to use
382 2014-09-18 Csaba Osztrogonác <ossy@webkit.org>
384 Fix countFailures of RunLLINTCLoopTests and Run32bitJSCTests (II)
385 https://bugs.webkit.org/show_bug.cgi?id=136856
387 Reviewed by Darin Adler.
389 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
390 (RunLLINTCLoopTests.countFailures):
391 (Run32bitJSCTests.countFailures):
392 * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
393 (RunLLINTCLoopTestsTest.test_failures):
394 (RunLLINTCLoopTestsTest.test_failure):
395 (RunLLINTCLoopTestsTest.test_no_failure):
396 (Run32bitJSCTestsTest.test_failures):
397 (Run32bitJSCTestsTest.test_failure):
398 (Run32bitJSCTestsTest.test_no_failure):
400 2014-09-18 Zan Dobersek <zdobersek@igalia.com>
402 GMainLoopSource is exposed to race conditions
403 https://bugs.webkit.org/show_bug.cgi?id=135800
405 Reviewed by Carlos Garcia Campos.
407 Add unit tests for GMainLoopSource.
409 The tests check correct behavior of GMainLoopSource in various conditions --
410 from the most simple rescheduling to rescheduling during dispatch, cancelling
411 or destroying the GMainLoopSource during dispatch, proper destroy callback
414 Scheduling both void (one-time) and bool (repeatable) callbacks is tested.
415 State of the GMainLoopSource object (either ready, sheduled or active) is
416 thoroughly tested throughout the lifetime of that object.
418 Still missing are tests for socket callbacks, which are a bit trickier because
419 they rely on a GSocket object. The delete-on-destroy GMainLoopSource objects
420 are also not tested thoroughly, simply because it is at the moment impossible
421 to test that the objects are actually destroyed when the corresponding source
424 * TestWebKitAPI/PlatformGTK.cmake:
425 * TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp: Added.
426 (TestWebKitAPI::GMainLoopSourceTest::GMainLoopSourceTest):
427 (TestWebKitAPI::GMainLoopSourceTest::~GMainLoopSourceTest):
428 (TestWebKitAPI::GMainLoopSourceTest::runLoop):
429 (TestWebKitAPI::GMainLoopSourceTest::delayedFinish):
430 (TestWebKitAPI::GMainLoopSourceTest::finish):
431 (TestWebKitAPI::GMainLoopSourceTest::source):
432 (TestWebKitAPI::TEST):
434 2014-09-17 Ryuan Choi <ryuan.choi@gmail.com>
436 Unreviewed, Update my email in contributors.json
438 * Scripts/webkitpy/common/config/contributors.json:
440 2014-09-17 Daniel Bates <dabates@apple.com>
442 Unreviewed, rolling out r173695.
444 Broke building third-party Legacy WebKit apps; will
449 "[iOS] Make WebCore build with public iOS SDK"
450 https://bugs.webkit.org/show_bug.cgi?id=136487
451 http://trac.webkit.org/changeset/173695
453 2014-09-17 Daniel Bates <dabates@apple.com>
455 [iOS] Make WebCore build with public iOS SDK
456 https://bugs.webkit.org/show_bug.cgi?id=136487
458 Reviewed by David Kilzer.
460 Substitute <WebCore/MachVMSPI.h> for <mach/mach_vm.h>.
462 * DumpRenderTree/mac/CheckedMalloc.cpp:
464 2014-09-17 Carlos Garcia Campos <cgarcia@igalia.com>
466 [GTK] WebKitWebView::load-failed-with-tls-errors should receive the failing URI instead of a host
467 https://bugs.webkit.org/show_bug.cgi?id=136889
469 Reviewed by Gustavo Noronha Silva.
471 * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
472 (testLoadFailedWithTLSErrors): Check that LoadFailedWithTLSErrors
473 event was added to the events vector.
474 * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
475 (loadFailedCallback): Do not assume the web view URI is the
476 failing URI when the load fails before the committed state.
477 (loadFailedWithTLSErrorsCallback): Handle the case of load failure
478 because of TLS errors can call LoadTrackingTest::loadFailedWithTLSErrors.
479 (LoadTrackingTest::LoadTrackingTest): Connect to WebKitWebView::load-failed-with-tls-errors.
480 (LoadTrackingTest::loadFailedWithTLSErrors): Add
481 LoadFailedWithTLSErrors event to the events vector.
482 * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h:
484 2014-09-17 Renato Nagy <rnagy@inf.u-szeged.hu>
486 [EFL][GTK] Remove WebKit1 related codes
487 https://bugs.webkit.org/show_bug.cgi?id=136853
489 Reviewed by Csaba Osztrogonác.
491 Gtk and EFL WebKit1 ports no longer exist. Webkit1 related codes were deleted
494 * BuildSlaveSupport/build.webkit.org-config/config.json:
495 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
497 (BuildAndTestWebKit2Factory):
498 (CompileWebKit1Only): Deleted.
499 (CompileWebKit2Only): Deleted.
500 (BuildAndTestWebKit1OnlyFactory): Deleted.
501 (BuildAndTestWebKit2OnlyFactory): Deleted.
502 * Scripts/build-webkit:
503 * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRefGettingValue.pl:
504 * Scripts/webkitpy/common/config/ports.py:
505 (GtkWK2Port.build_webkit_command):
506 (EflWK2Port.build_webkit_command):
507 * Scripts/webkitpy/common/config/ports_unittest.py:
508 (DeprecatedPortTest.test_gtk_wk2_port):
509 * Scripts/webkitpy/port/efl.py:
510 (EflPort.build_webkit_command):
511 * Scripts/webkitpy/port/gtk.py:
512 (GtkPort._built_libraries_path):
513 (GtkPort._search_paths):
514 (GtkPort.test_expectations_file_position):
515 (GtkPort.build_webkit_command):
516 (GtkPort.run_webkit_tests_command):
517 (GtkPort.warn_if_bug_missing_in_test_expectations): Deleted.
519 2014-09-16 Daniel Bates <dabates@apple.com>
521 [iOS] Add iOS SDK name and version suffix to WebKitSystemInterface debug/release product name
522 https://bugs.webkit.org/show_bug.cgi?id=136862
524 Reviewed by David Kilzer.
526 * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
527 * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
528 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Remove hardcoded iOS 8.0
529 IPHONEOS_DEPLOYMENT_TARGET to ensure we link against the latest version of WebKitSystemInterface.
531 2014-09-12 Ryosuke Niwa <rniwa@webkit.org>
533 Mac queue slaves should reboot every so often
534 https://bugs.webkit.org/show_bug.cgi?id=136791
536 Reviewed by Alexey Proskuryakov.
538 Reboot Mac queue slaves every night between 1 A.M. and 6 A.M.
540 * EWSTools/start-queue-mac.sh:
542 2014-09-16 Csaba Osztrogonác <ossy@webkit.org>
544 Unreviewed gardening, skip one more tests on Windows.
546 * Scripts/run-javascriptcore-tests:
548 2014-09-16 Csaba Osztrogonác <ossy@webkit.org>
551 https://bugs.webkit.org/show_bug.cgi?id=136823
553 Reviewed by Geoffrey Garen.
555 * Scripts/run-javascriptcore-tests: Skip tests on only the affected platforms.
557 2014-09-16 Eva Balazsfalvi <evab.u-szeged@partner.samsung.com>
559 Remove shouldAbortEarly cruft from master.cfg
560 https://bugs.webkit.org/show_bug.cgi?id=136779
562 Reviewed by Csaba Osztrogonác.
564 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
565 (ConfigureBuild.start):
566 (RunWebKitTests.start):
567 (RunWebKit2Tests.start): Deleted.
569 2014-09-15 Tibor Meszaros <tmeszaros.u-szeged@partner.samsung.com>
571 Remove ORWT related crufts from webkitdirs.pm
572 https://bugs.webkit.org/show_bug.cgi?id=136821
574 Reviewed by Alexey Proskuryakov.
576 * Scripts/webkitdirs.pm:
577 (isPerianInstalled): Deleted.
578 (determineIPhoneSimulatorVersion): Deleted.
579 (iPhoneSimulatorVersion): Deleted.
580 (isSnowLeopard): Deleted.
582 (quitIOSSimulator): Deleted.
584 2014-09-15 Roger Fong <roger_fong@apple.com>
586 Unreviewed. Skip yet another ecma/Date test that fails only on Windows.
587 https://bugs.webkit.org/show_bug.cgi?id=25160
589 * Scripts/run-javascriptcore-tests:
591 2014-09-15 Lucas Forschler <lforschler@apple.com>
593 Add another Apple build slave to the Mountain Lion Debug WK1 queue
595 Rubber stamped by Matt Hanson.
597 * BuildSlaveSupport/build.webkit.org-config/config.json:
599 2014-09-15 Grzegorz Czajkowski <g.czajkowski@samsung.com>
601 [EFL] Ecore and Eina are initialized twice in TestWebKitAPI
602 https://bugs.webkit.org/show_bug.cgi?id=136822
604 Reviewed by Gyuyoung Kim.
606 In TestWebKitAPI/efl/main.cpp, ecore and eina modules are unnecessarily
607 initialized as we already does it in PlatformWebView::PlatformWebView
608 calling ewk_init(). The reason for that was to ensure testing for example,
609 WTF where creating the view is not mandatory.
611 Call ewk_init() and ewk_shutdown() in TestWebKitAPI/efl/main.cpp
612 in order to properly initalize and release EWebKit.
614 * TestWebKitAPI/PlatformEfl.cmake:
615 * TestWebKitAPI/efl/PlatformWebView.cpp:
616 (TestWebKitAPI::PlatformWebView::PlatformWebView):
617 (TestWebKitAPI::PlatformWebView::~PlatformWebView):
618 * TestWebKitAPI/efl/main.cpp:
621 2014-09-15 peavo@outlook.com <peavo@outlook.com>
623 [WinCairo] Make it easier to enable/disable GStreamer.
624 https://bugs.webkit.org/show_bug.cgi?id=135766
626 Reviewed by Brent Fulgham.
628 Make it possible to enable/disable GStreamer by editing the new user macro ENABLE_GSTREAMER_WINCAIRO.
630 * WinLauncher/WinMain.cpp: Compile fix when GStreamer is enabled.
632 2014-09-12 Brian J. Burg <burg@cs.washington.edu>
634 Web Inspector: remind about rebaselining generator test results
635 https://bugs.webkit.org/show_bug.cgi?id=136759
637 Reviewed by Joseph Pecoraro.
639 For now, we can implement this as a watchlist message. Add watchlist
640 groups and messages for the inspector and web replay generators.
642 * Scripts/webkitpy/common/config/watchlist:
644 2014-09-12 Alexey Proskuryakov <ap@apple.com>
646 build.webkit.org/dashboard: Overlapping text when status is long
647 https://bugs.webkit.org/show_bug.cgi?id=136794
649 Reviewed by Timothy Hatcher.
651 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
652 (.status-line): Replaces height with min-height.
654 2014-09-12 Timothy Hatcher <timothy@apple.com>
656 Make Brian Burg a WebKit reviewer.
658 * Scripts/webkitpy/common/config/contributors.json: Move Brian Burg's entry.
660 2014-09-12 Alexey Proskuryakov <ap@apple.com>
662 Multiple EWS or commit bots can pick up processing of the same patch
663 https://bugs.webkit.org/show_bug.cgi?id=136793
665 Reviewed by Ryosuke Niwa.
667 Change timeout from one hour to two hours. This will let bots finish, and in the
668 unlikely event of a bot being frozen, will only delay patch processing restart by
671 * QueueStatusServer/app.yaml:
672 * QueueStatusServer/model/activeworkitems.py: (ActiveWorkItems.deactivate_expired):
674 2014-09-11 Andy Estes <aestes@apple.com>
676 [WebKit2] WKImageCreateCGImage crashes when passed a null WKImage
677 https://bugs.webkit.org/show_bug.cgi?id=136768
679 Reviewed by Tim Horton.
681 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
682 * TestWebKitAPI/Tests/WebKit2/WKImageCreateCGImageCrash.cpp: Added.
683 (TestWebKitAPI::TEST):
685 2014-09-12 Carlos Garcia Campos <cgarcia@igalia.com>
687 REGRESSION(r173423): CertificateInfo is never sent to the UI process when using shared secondary process model
688 https://bugs.webkit.org/show_bug.cgi?id=136669
690 Reviewed by Antti Koivisto.
692 * Scripts/run-gtk-tests:
693 (TestRunner): Unskip SSL test.
695 2014-09-12 Eric Carlson <eric.carlson@apple.com>
697 Strip extraneous AVFoundation and CoreMedia logging
698 https://bugs.webkit.org/show_bug.cgi?id=136747
700 Reviewed by Jer Noble.
702 * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
703 (SingleTestRunner._run_compare_test): Allow the port to specify patterns to strip from stderr.
705 * Scripts/webkitpy/port/base.py:
706 (Port.stderr_patterns_to_strip): Base class, empty list
708 * Scripts/webkitpy/port/driver.py:
709 (DriverOutput.strip_stderror_patterns): Strip the specified patterns from stderr.
711 * Scripts/webkitpy/port/ios.py:
712 (IOSSimulatorPort.stderr_patterns_to_strip): iOS patterns - there are none.
714 * Scripts/webkitpy/port/mac.py:
715 (MacPort.stderr_patterns_to_strip): CoreMedia and AVFoundation logging we can ignore.
718 2014-09-11 Michael Saboff <msaboff@apple.com>
720 lldb_webkit.py:btjs doesn't work with release builds
721 https://bugs.webkit.org/show_bug.cgi?id=136760
723 Reviewed by Jer Noble.
725 If we can't get a result calling JSC::ExecState::describeFrame(), try calling the
726 mangled name _ZN3JSC9ExecState13describeFrameEv. Also cleaned up the handling if
727 we can't get a valid result from trying either call. In that case, we fallback to
728 just showing the PC. Also added check for both entry points. If neither is found,
729 we issue a warning and output the stack trace without JavaScript annotations.
731 * lldb/lldb_webkit.py:
734 2014-09-11 Rebecca Hauck <rhauck@adobe.com>
736 webkitpy test failures from import-w3c-tests
737 https://bugs.webkit.org/show_bug.cgi?id=136752
739 Reviewed by Bem Jones-Bey.
741 This patch fixes a bug in import-w3c-tests where we were appending
742 the wrong set of files to the copy_list. This also updates the tests
743 to clear the failures introduced in the patch for bug 135929.
745 * Scripts/webkitpy/w3c/test_converter_unittest.py:
746 (W3CTestConverterTest.test_read_prefixed_property_list):
747 * Scripts/webkitpy/w3c/test_parser.py:
748 (TestParser.analyze_test):
749 (TestParser.support_files):
750 * Scripts/webkitpy/w3c/test_parser_unittest.py:
752 2014-09-10 Brent Fulgham <bfulgham@apple.com>
754 Blink merge: Speculative fix for windows run-webkit-tests hangs
755 https://bugs.webkit.org/show_bug.cgi?id=136727
757 Reviewed by Csaba Osztrogonác.
759 Merged from Blink (patch by Dirk Pranke):
760 <https://chromium.googlesource.com/chromium/blink/+/0cdd98d44a20c3951562ccf8b08b1fefba8dac67%5E%21/#F0>
762 * Scripts/webkitpy/common/system/executive.py:
763 (Executive.kill_process):
765 2014-09-11 Eva Balazsfalvi <evab.u-szeged@partner.samsung.com>
767 Added myself as a committer.
771 * Scripts/webkitpy/common/config/contributors.json:
773 2014-09-11 László Langó <llango.u-szeged@partner.samsung.com>
775 [JavaScriptCore] Fix FTL on platform EFL.
776 https://bugs.webkit.org/show_bug.cgi?id=133571
778 Reviewed by Filip Pizlo.
780 * efl/install-dependencies: Revert r169181.
781 * efl/jhbuild.modules: Clone and build a custom branch.
782 This branch contains some fix for FTL of platform EFL.
783 The branch is a fork of llvm r206311.
785 2014-09-10 Tanay C <tanay.c@samsung.com>
787 [EFL][WK2] Minibrowser : Shift+Scroll navigate to back or forward url's
788 https://bugs.webkit.org/show_bug.cgi?id=136698
790 Reviewed by Gyuyoung Kim.
792 * MiniBrowser/efl/main.c: Add functionality to support shift + mouse scroll navigation
793 (on_mouse_wheel): Added.
797 2014-09-10 Rohit Kumar <kumar.rohit@samsung.com>
799 [EFL][WK2] Minibrowser : Add tooltip for toolbar buttons in Minibrowser
800 https://bugs.webkit.org/show_bug.cgi?id=136284
802 Reviewed by Gyuyoung Kim.
804 * MiniBrowser/efl/main.c:
807 2014-09-10 Rebecca Hauck <rhauck@adobe.com>
809 import-w3c-tests doesn't handle relative paths to support files in ref files correctly
810 https://bugs.webkit.org/show_bug.cgi?id=135929
812 Reviewed by Bem Jones-Bey.
814 The recent refactor of the W3C test repo falsified a bunch of assmumptions that
815 were made when this script was originally written with respect to relative paths
816 in ref files. This patch updates import-w3c-tests to update paths in ref files if
817 they move relative to the test file.
820 * Scripts/webkitpy/w3c/test_converter.py:
821 (convert_for_webkit):
822 (_W3CTestConverter.__init__):
823 (_W3CTestConverter.convert_reference_relpaths):
824 (_W3CTestConverter.convert_style_data):
825 (_W3CTestConverter.convert_attributes_if_needed):
826 * Scripts/webkitpy/w3c/test_importer.py:
827 (TestImporter.find_importable_tests):
828 (TestImporter.import_tests):
829 * Scripts/webkitpy/w3c/test_parser.py:
830 (TestParser.load_file):
831 (TestParser.analyze_test):
832 (TestParser.support_files):
834 2014-09-10 Michael Catanzaro <mcatanzaro@igalia.com>
836 [GTK] allow overwriting destination of download
837 https://bugs.webkit.org/show_bug.cgi?id=136372
839 Reviewed by Carlos Garcia Campos.
841 * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
842 (downloadLocalFileSuccessfully): Split from testDownloadLocalFile
843 (testDownloadLocalFile): Split off downloadLocalFileSuccessfully
844 (createFileAtDestination): Added
845 (testDownloadOverwriteDestinationAllowed): Added
846 (testDownloadOverwriteDestinationDisallowed): Added
847 (testDownloadLocalFileError): Use new DownloadErrorTest::ExpectedError
848 (testDownloadRemoteFileError): Use new DownloadErrorTest::ExpectedError
849 (beforeAll): New tests
851 2014-08-05 David Farler <dfarler@apple.com>
853 iOS Simulator: run-webkit-tests chokes on unterminated UTF-8 when writing a test result
854 https://bugs.webkit.org/show_bug.cgi?id=135551
856 Reviewed by Daniel Bates.
858 Prevent printing invalid Unicode strings going to stderr.
859 Also, make filesystem.py more tolerant about receiving
860 Unicode (encoded as UTF-8) when writing to files, in the
861 rare case that an NSError description will make it to
862 stderr, such as -[LTRelayController createUniqueApp].
864 * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
865 (-[LTRelayController launchSimulator]): Removed.
866 (-[LTRelayController createUniqueApp]):
867 Don't explicitly try to uninstall the app. It is automatically handled
868 when installing an app with the same bundle identifier.
869 (-[LTRelayController start]):
870 (-[LTRelayController bootDevice]): Removed.
871 The device already boots as a part of starting the simulator. Attempting
872 to boot a second time may cause spurious stderr output.
873 * Scripts/webkitpy/port/driver.py:
874 (IOSSimulatorDriver._setup_environ_for_driver):
875 Explicitly set DEVELOPER_DIR once so xcode-select isn't called.
876 Open the iOS Simulator once instead of the LayoutTestRelay trying
878 * Scripts/webkitpy/port/ios.py:
879 (IOSSimulatorPort._get_crash_log):
880 Make sure stderr is at least an empty string.
882 (IOSSimulatorPort.developer_dir):
883 New property for setting up DEVELOPER_DIR in the driver environment.
885 2014-09-09 Dan Bernstein <mitz@apple.com>
887 Clean up the MiniBrowser Xcode project
888 https://bugs.webkit.org/show_bug.cgi?id=136684
890 Reviewed by Tim Horton.
892 * MiniBrowser/Configurations/Base.xcconfig: Enabled warnings recommended by Xcode 6.
893 * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Removed explicit linking against
894 WebKit2.framework. Upgraded project file version.
896 2014-09-09 Daniel Bates <dbates@webkit.org>
898 svn-{apply, unapply} fails to apply/unapply SVN 1.7 patch that adds new file with property change
899 https://bugs.webkit.org/show_bug.cgi?id=136379
901 Reviewed by David Kilzer.
903 Fixes an issue where svn-{apply, unapply} fail to apply or unapply, respectively,
904 a patch generated using Subversion 1.7.4 (r1295709) that both adds a new file F
905 and sets a property on F (say, the executable bit).
908 (patch): Only add file if the diff has text chunks.
909 * Scripts/svn-unapply:
910 (patch): Only delete added file if the diff has text chunks.
912 2014-09-09 Carlos Alberto Lopez Perez <clopez@igalia.com>
914 [GTK] Unreviewed GTK gardening.
916 * Scripts/run-gtk-tests:
917 (TestRunner): Skip TestSSL:webkit2/WebKitWebView/ssl (fails since r173423).
919 2014-09-09 Christophe Dumez <cdumez@apple.com>
921 Update my email in contributors.json
922 https://bugs.webkit.org/show_bug.cgi?id=136671
924 Reviewed by Andreas Kling.
926 * Scripts/webkitpy/common/config/contributors.json:
928 2014-09-08 Gyuyoung Kim <gyuyoung.kim@samsung.com>
930 [EFL] Enable fixed layout by default
931 https://bugs.webkit.org/show_bug.cgi?id=136607
933 Reviewed by Csaba Osztrogonác.
935 Fixed layout is being used by Tizen platform by default. However, the feature
936 has still many defects now. So, we need to enable it by default, then should fix
939 * MiniBrowser/efl/main.c:
941 2014-09-08 Eva Balazsfalvi <evab.u-szeged@partner.samsung.com>
944 https://bugs.webkit.org/show_bug.cgi?id=136571
946 Reviewed by Darin Adler.
948 * Scripts/webkitperl/FeatureList.pm:
950 2014-09-08 Alexey Proskuryakov <ap@apple.com>
952 Dashboard metrics should ignore commits that didn't trigger builds
953 https://bugs.webkit.org/show_bug.cgi?id=136618
955 Reviewed by Darin Adler.
957 Commits that didn't trigger builds are ones like ChangeLog updates, patches for
958 other platforms etc. It does not make sense to count wait time for these, as it
959 can be arbitrarily long.
961 The new algorithm is much slower asymptotically, but it's OK, computers are fast.
963 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
964 (BuildbotIteration.prototype._parseData): Record changes that triggered the iteration.
966 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
967 We used to walk the timeline to see which revisions are fully tested, but that's not
968 correct. A revision that's only tested by a subset of queues finishes independently
969 of another that's tested by another subset. Now, we just search for the answer for
970 each revision individually.
972 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsView.js:
973 (MetricsView.prototype._update.appendQueueResults): Added worst revision number, which
974 the analyzer now reports. Removed best time, which is more confusing than meaningful.
976 2014-09-08 Tibor Meszaros <tmeszaros.u-szeged@partner.samsung.com>
978 Remove EWebLauncher from webkitdirs.pm
979 https://bugs.webkit.org/show_bug.cgi?id=136622
981 Reviewed by Gyuyoung Kim.
983 * Scripts/webkitdirs.pm:
986 2014-09-06 Sam Weinig <sam@webkit.org>
988 XPCPtr should be converted into an all purpose smart pointer for os_objects
989 https://bugs.webkit.org/show_bug.cgi?id=136602
991 Reviewed by Darin Adler.
993 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
994 * TestWebKitAPI/Tests/WTF/darwin: Added.
995 * TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp: Added.
996 Add basic unit tests for OSObjectPtr.
998 2014-09-06 Saam Barati <saambarati1@gmail.com>
1000 Unreviewed. Add myself as a committer.
1002 * Scripts/webkitpy/common/config/contributors.json:
1004 2014-09-06 Gyuyoung Kim <gyuyoung.kim@samsung.com>
1006 Unreviewed, EFL build fix when SHARED_CORE is on.
1008 * TestWebKitAPI/PlatformEfl.cmake:
1010 2014-09-05 Lucas Forschler <lforschler@apple.com>
1012 <https://webkit.org/b/136586> Add bots to Apple build/test queues
1014 Reviewed by Daniel Bates.
1016 * BuildSlaveSupport/build.webkit.org-config/config.json:
1018 2014-09-05 Alexey Proskuryakov <ap@apple.com>
1020 Buildbot metrics page gives wrong results after a new bot gets added
1021 https://bugs.webkit.org/show_bug.cgi?id=136516
1023 Reviewed by Tim Horton.
1025 Part 2: Fix elapsed times.
1027 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
1028 (Analyzer.prototype._countTimes): Made lastTestedRevisionByQueue contain undefined values
1029 until the first build in a queue. This happens to work as needed with _fullyTestedRevisionNumber().
1031 2014-09-05 Carlos Alberto Lopez Perez <clopez@igalia.com>
1033 [SOUP] Implement ResourceResponse::platformSuggestedFilename() when USE(SOUP) is enabled.
1034 https://bugs.webkit.org/show_bug.cgi?id=136562
1036 Reviewed by Martin Robinson.
1038 * Scripts/run-gtk-tests:
1039 (TestRunner): Remove failure expectations for tests that now pass.
1041 2014-09-04 Alexey Proskuryakov <ap@apple.com>
1043 Dashboard metrics page wastes a lot of time sorting iterations
1044 https://bugs.webkit.org/show_bug.cgi?id=136559
1046 Reviewed by Tim Horton.
1048 Also fixes comments here and there, and adds a missing "var".
1050 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1051 (BuildbotIteration.prototype._parseData):
1052 (BuildbotIteration.prototype._updateWithData):
1053 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1054 (BuildbotQueue.prototype.loadAll):
1055 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
1056 (Analyzer.prototype._countTimes):
1058 2014-09-05 Carlos Alberto Lopez Perez <clopez@igalia.com>
1060 [GTK] Unreviewed GTK gardening.
1062 * Scripts/run-gtk-tests:
1063 (TestRunner): Skip tests failing since r173272.
1065 2014-09-04 Simon Fraser <simon.fraser@apple.com>
1067 Add some logging to help diagnose assertions in dumpWebViewAsPixelsAndCompareWithExpected() on bots
1068 https://bugs.webkit.org/show_bug.cgi?id=136561
1070 Reviewed by Tim Horton.
1072 Log for calloc() and CGBitmapContextCreate() failures.
1074 * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1075 (createBitmapContext):
1076 (createBitmapContextFromWebView):
1078 2014-09-04 Andy Estes <aestes@apple.com>
1080 Fix the Mac Production build after r173283.
1082 * WebKitTestRunner/config.h: Reverted to defining WEBCORE_EXPORT for now.
1084 2014-09-04 Brent Fulgham <bfulgham@apple.com>
1086 [Win] webkitpy test suite frequently fails to complete
1087 https://bugs.webkit.org/show_bug.cgi?id=136546
1089 Reviewed by Daniel Bates.
1091 Properly convert the ASCII crash log produced by ntsd into
1092 a unicode string as early as possible so that we handle it
1093 properly when generating our logs and other test support output.
1095 We were mixing ASCII/unicode strings under Windows, which was
1096 causing test system failures when we processed some crash logs.
1098 Also do a better job of handling garbage pid entries in the
1101 * Scripts/webkitpy/common/system/crashlogs.py:
1102 (CrashLogs._find_newest_log_win): The ntsd '.logopen' command
1103 creates an ASCII file. Decode it as ASCII, not 'utf-8', and
1104 handle the strings as unicode from that point on.
1105 * Scripts/webkitpy/port/http_lock.py:
1106 (HttpLock._current_lock_pid): Add logging and handle case of
1107 the current_pid failing to cleanly convert to 'int'.
1108 * Scripts/webkitpy/port/win.py:
1109 (WinPort): Add 64-bit architecture as a known target for the
1112 2014-09-04 Andy Estes <aestes@apple.com>
1114 Address additional review feedback after landing r173283.
1116 Reviewed by Daniel Bates.
1118 * DumpRenderTree/config.h: Removed redundant includes.
1119 * TestWebKitAPI/config.h: Ditto.
1120 * WebKitTestRunner/config.h: Ditto.
1122 2014-09-03 Andy Estes <aestes@apple.com>
1124 [Cocoa] Some WebKitLegacy headers migrated from WebCore incorrectly contain WEBCORE_EXPORT
1125 https://bugs.webkit.org/show_bug.cgi?id=136521
1127 Reviewed by Anders Carlsson.
1129 * DumpRenderTree/config.h: Included <WebCore/PlatformExportMacros.h> instead of defining WEBCORE_EXPORT.
1130 * TestWebKitAPI/config.h: Ditto.
1131 * WebKitTestRunner/config.h: Ditto.
1133 2014-09-04 Alexey Proskuryakov <ap@apple.com>
1135 REGRESSION: Dashboard metrics page aggregation counts performance bots
1136 https://bugs.webkit.org/show_bug.cgi?id=136539
1138 Reviewed by Tim Horton.
1140 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
1142 2014-09-04 Brent Fulgham <bfulgham@apple.com>
1144 [Win] Perl test fix.
1146 * Scripts/webkitperl/auto-version_unittest/versionStampTests.pl: Correct test to check for
1147 VersionStamp.exe tool, not just the driver script.
1149 2014-09-04 Eva Balazsfalvi <evab.u-szeged@partner.samsung.com>
1151 Remove CSS_FILTERS flag
1152 https://bugs.webkit.org/show_bug.cgi?id=136529
1154 Reviewed by Dirk Schulze.
1156 * Scripts/webkitperl/FeatureList.pm:
1158 2014-09-04 Commit Queue <commit-queue@webkit.org>
1160 Unreviewed, rolling out r173201.
1161 https://bugs.webkit.org/show_bug.cgi?id=136538
1163 Improves the situation but also introduces additional crashes.
1164 (Requested by zdobersek on #webkit).
1168 "GMainLoopSource is exposed to race conditions"
1169 https://bugs.webkit.org/show_bug.cgi?id=135800
1170 http://trac.webkit.org/changeset/173201
1172 2014-09-03 Alexey Proskuryakov <ap@apple.com>
1174 Buildbot metrics page gives wrong results after a new bot gets added
1175 https://bugs.webkit.org/show_bug.cgi?id=136516
1177 Part 1: Fix red/green counters. Dashboard is considered green at a given time
1178 if all the bots that ever had results before this time are green.
1180 This doesn't (and cannot) address situations where the bot gets removed and then
1181 re-added. It also gives wrong results after a bot gets removed, because it doesn't
1182 know that it was ever displayed on the dashboard.
1184 Reviewed by Darin Adler.
1186 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
1187 (Analyzer.prototype._dashboardIsAllGreen):
1188 (Analyzer.prototype._updateStretchOfRedCounters):
1189 (Analyzer.prototype._countPercentageOfGreen):
1190 (Analyzer.prototype._allQueuesAreSuccessful): Deleted.
1192 2014-09-03 Brent Fulgham <bfulgham@apple.com>
1194 [Win] Unreviewed test fix.
1196 * Scripts/webkitperl/auto-version_unittest/versionStampTests.pl: Don't fail
1197 test if user doesn't have the VersionStamp.exe program.
1199 2014-09-03 Dana Burkart <dburkart@apple.com>
1201 Unreviewed. Add myself as a committer.
1203 * Scripts/webkitpy/common/config/contributors.json:
1205 2014-09-03 Alexey Proskuryakov <ap@apple.com>
1207 build.webkit.org/dashboard performance popover is unstyled
1208 https://bugs.webkit.org/show_bug.cgi?id=136499
1210 Reviewed by Tim Horton.
1212 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
1213 (.performance-popover):
1214 (.performance-popover .dashboard-link):
1216 2014-09-03 Saam Barati <saambarati1@gmail.com>
1218 Create tests for type profiling
1219 https://bugs.webkit.org/show_bug.cgi?id=136161
1221 Reviewed by Geoffrey Garen.
1223 Have run-javascriptcore-tests run the newly created
1224 tests for the type profiler.
1226 * Scripts/run-javascriptcore-tests:
1227 * Scripts/run-jsc-stress-tests:
1229 2014-09-03 Brent Fulgham <bfulgham@apple.com>
1231 [Win] Revise test environment for Windows build.
1232 https://bugs.webkit.org/show_bug.cgi?id=136486
1234 Reviewed by David Kilzer.
1236 The various calls to get the Safari path really only have
1237 meaning on the Mac. Other ports get access to the build
1238 and test environment separately, so remove the various
1239 checks in the Safari-specific code to simplify things.
1241 Remove some 64-bit hacks used on Windows now that the
1242 various tools know how to find the 64-bit runtime environment.
1244 * Scripts/run-javascriptcore-tests:
1245 * Scripts/webkitdirs.pm:
1246 (safariPathFromSafariBundle): Revise to expect Mac.
1247 (installedSafariPath): Ditto.
1248 (safariPath): Ditto.
1249 (appleApplicationSupportPath): Get rid of 64-bit Windows hack.
1250 (setPathForRunningWebKitApp): Get rid of unused SafariPath
1251 argument for Windows runs.
1253 2014-09-03 Dana Burkart <dburkart@apple.com>
1255 Dashboard should show performance bots.
1256 https://bugs.webkit.org/show_bug.cgi?id=136386
1258 Reviewed by Alexey Proskuryakov.
1260 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1261 (BuildbotIteration.prototype._parseData.collectPerfTestResults):
1262 (BuildbotIteration.prototype._parseData):
1263 Support possible performance failures.
1265 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotPerformanceQueueView.js:
1266 New QueueView to manage the way we present performance data.
1268 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1270 Support new 'performance' and 'performanceTestName' keys.
1273 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
1274 Add performance column to the main page.
1276 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1278 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1280 Make sure everything fits on 13 inch screens.
1282 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
1284 2014-09-03 Zan Dobersek <zdobersek@igalia.com>
1286 GMainLoopSource is exposed to race conditions
1287 https://bugs.webkit.org/show_bug.cgi?id=135800
1289 Reviewed by Carlos Garcia Campos.
1291 Add a unit test for GMainLoopSource that tests different
1292 types of rescheduling tasks on already-active sources.
1294 * TestWebKitAPI/PlatformGTK.cmake:
1295 * TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp: Added.
1296 (GMainLoopSourceTest::GMainLoopSourceTest):
1297 (GMainLoopSourceTest::~GMainLoopSourceTest):
1298 (GMainLoopSourceTest::runLoop):
1299 (GMainLoopSourceTest::finish):
1300 (GMainLoopSourceTest::source):
1301 (testGMainLoopSourceBasicRescheduling):
1302 (testGMainLoopSourceReentrantRescheduling):
1303 (testGMainLoopSourceDifferentThreadRescheduling):
1306 (TestWebKitAPI::GMainLoopSourceTest::GMainLoopSourceTest):
1307 (TestWebKitAPI::GMainLoopSourceTest::~GMainLoopSourceTest):
1308 (TestWebKitAPI::GMainLoopSourceTest::runLoop):
1309 (TestWebKitAPI::GMainLoopSourceTest::finish):
1310 (TestWebKitAPI::GMainLoopSourceTest::source):
1311 (TestWebKitAPI::TEST):
1313 2014-09-02 Simon Fraser <simon.fraser@apple.com>
1315 Make sure WK1 prefs are initialized in MiniBrowser
1316 https://bugs.webkit.org/show_bug.cgi?id=136465
1318 Reviewed by Tim Horton.
1320 Call -didChangeSettings from -awakeFromNib for WK1 windows just as we do
1321 for WK2 windows, to make sure that WebPreferences are updated (to get
1322 layer borders to work consistently).
1324 * MiniBrowser/mac/WK1BrowserWindowController.m:
1325 (-[WK1BrowserWindowController awakeFromNib]):
1327 2014-09-02 Renato Nagy <rnagy@inf.u-szeged.hu>
1329 check-webkit-style should complain about C++ comments in Platform.h
1330 https://bugs.webkit.org/show_bug.cgi?id=133802
1332 Reviewed by Csaba Osztrogonác.
1334 * Scripts/webkitpy/style/checkers/cpp.py:
1335 (check_platformh_comments):
1338 * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1339 (CppStyleTest.test_platformh_comment):
1341 2014-09-02 Brendan Long <self@brendanlong.com>
1343 [Gtk] Make install-dependencies work on Arch Linux
1344 https://bugs.webkit.org/show_bug.cgi?id=136374
1346 Reviewed by Philippe Normand.
1348 * gtk/install-dependencies: Add dependencies for pacman (Arch Linux).
1350 2014-09-01 Brian J. Burg <burg@cs.washington.edu>
1352 Provide column numbers to DTrace willExecute/didExecute probes
1353 https://bugs.webkit.org/show_bug.cgi?id=136434
1355 Reviewed by Antti Koivisto.
1357 Create a directory for DTrace scripts. Add an example script that
1358 shows how to use static probes provided by JavaScriptCore's profiler.
1360 * Scripts/dtrace/jsc-trace-profiler-events.d: Added.
1362 2014-09-01 Carlos Alberto Lopez Perez <clopez@igalia.com>
1364 [GTK] [JHBuild] Cyclic dependency between cairo and librsvg.
1365 https://bugs.webkit.org/show_bug.cgi?id=136431
1367 Reviewed by Martin Robinson.
1369 * gtk/jhbuild.modules: Disable cairo SVG testsuite.
1370 Add missing dependencies for librsvg (glib and cairo).
1372 2014-09-01 Carlos Alberto Lopez Perez <clopez@igalia.com>
1374 [GTK] install-dependencies don't installs dbus-launch that is needed for the API tests.
1375 https://bugs.webkit.org/show_bug.cgi?id=136425
1377 Reviewed by Martin Robinson.
1379 * gtk/install-dependencies: Add dbus-x11 to the list of packages needed for running the tests.
1381 2014-09-01 Ryuan Choi <ryuan.choi@samsung.com>
1383 Update my list of email addresses in contributors.json
1384 https://bugs.webkit.org/show_bug.cgi?id=136424
1386 Reviewed by Gyuyoung Kim.
1388 * Scripts/webkitpy/common/config/contributors.json:
1390 2014-08-30 Filip Pizlo <fpizlo@apple.com>
1392 [RJST] eager-no-cjit should really mean eager
1393 https://bugs.webkit.org/show_bug.cgi?id=136407
1395 Reviewed by Mark Hahnenberg.
1397 At some point we made NO_CJIT_OPTIONS force threshold settings to something reasonable
1398 and well-known. But the way we appended options was such that NO_CJIT_OPTIONS came in
1399 after EAGER_OPTIONS. The whole point of "eager" was to use eager tier-up thresholds. This
1400 all meant that NO_CJIT_OPTIONS was overriding the eagerness of EAGER_OPTIONS, for the one
1401 threshold setting that NO_CJIT_OPTIONS was currently setting
1402 (thresholdForJITAfterWarmUp). The solution is to make sure that we always append
1403 NO_CJIT_OPTIONS before we append EAGER_OPTIONS.
1405 Luckily, no tests regressed during the time that we lost eager-no-cjit coverage.
1407 * Scripts/run-jsc-stress-tests:
1409 2014-08-29 Daniel Bates <dabates@apple.com>
1411 [iOS] Configure Xcode to build a command line tool for the iOS Simulator
1412 https://bugs.webkit.org/show_bug.cgi?id=136388
1414 Reviewed by David Kilzer.
1416 Add a script, called configure-xcode-for-ios-development, to configure Xcode to
1417 support building a command line tool for the iOS Simulator. You must run this
1420 The script uses the xcspec files in the OS X SDK to create xcspec files in the
1421 iOS Simulator SDK with the product- and package- type definitions to build a
1422 command line tool, if applicable.
1424 * Scripts/configure-xcode-for-ios-development: Added.
1426 2014-08-29 Tim Horton <timothy_horton@apple.com>
1428 Remove Windows WebKit2 code from TestWebKitAPI
1429 https://bugs.webkit.org/show_bug.cgi?id=136385
1431 Reviewed by Alexey Proskuryakov.
1433 * TestWebKitAPI/PlatformUtilities.h:
1434 * TestWebKitAPI/PlatformWebView.h:
1435 (TestWebKitAPI::PlatformWebView::setParentWindowMessageObserver): Deleted.
1436 * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
1437 (TestWebKitAPI::TEST): Deleted.
1438 * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
1439 (TestWebKitAPI::TEST):
1440 * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
1441 (TestWebKitAPI::TEST):
1442 * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp: Removed.
1443 * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp: Removed.
1444 * TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp: Removed.
1445 * TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp: Removed.
1446 * TestWebKitAPI/Tests/WebKit2/win/TranslateMessageGeneratesWMChar.cpp: Removed.
1447 * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp: Removed.
1448 * TestWebKitAPI/Tests/WebKit2/win/WMPrint.cpp: Removed.
1450 2014-08-29 Carlos Alberto Lopez Perez <clopez@igalia.com>
1452 [JSC] Some JSC tests are dependent on the machine time zone.
1453 https://bugs.webkit.org/show_bug.cgi?id=136363
1455 Reviewed by Filip Pizlo.
1457 * Scripts/run-javascriptcore-tests: Export TZ environment variable to US/Pacific.
1458 Unskip the tests that were skipped on r99580.
1460 2014-08-29 Eva Balazsfalvi <evab.u-szeged@partner.samsung.com>
1462 [EFL] Remove non Coordinated Graphics code path from cmake build system after r142169
1463 https://bugs.webkit.org/show_bug.cgi?id=135560
1465 Reviewed by Gyuyoung Kim.
1467 * Scripts/webkitperl/FeatureList.pm: Removed TILED_BACKING_STORE guard.
1469 2014-08-28 Daniel Bates <dabates@apple.com>
1471 [Win] update-webkit should update auxiliary libs by default
1473 Reviewed by Dan Bernstein.
1475 The change set <http://trac.webkit.org/changeset/172795> inadvertently prevented update-webkit
1476 from updating the Windows auxiliary libs by default. We should make update-webkit update the
1477 Windows auxiliary libs by default. This will make its behavior match its usage text.
1479 * Scripts/update-webkit:
1481 2014-08-28 Brian J. Burg <burg@cs.washington.edu>
1483 build-webkit --inspector-frontend tries to copy files from old inspector path
1484 https://bugs.webkit.org/show_bug.cgi?id=136346
1486 Reviewed by Timothy Hatcher.
1488 Remove the old code path for copying inspector resources. It doesn't work.
1489 Complain if this option is passed to CMake-based builds.
1491 * Scripts/build-webkit:
1492 * Scripts/webkitdirs.pm:
1493 (copyInspectorFrontendFiles): Deleted.
1495 2014-08-28 Alexey Proskuryakov <ap@apple.com>
1497 Dashboard metrics page could show longest stretch of red
1498 https://bugs.webkit.org/show_bug.cgi?id=136334
1500 Reviewed by Sam Weinig.
1502 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
1503 (Analyzer.prototype._updateStretchOfRedCounters):
1504 (Analyzer.prototype._countPercentageOfGreen):
1505 When counting percentage of green, also keep track of how long the page was red.
1507 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsView.js:
1508 (MetricsView.prototype._update.addDivider):
1509 (MetricsView.prototype._update.appendQueueResults):
1510 Show it in aggregate queues (can't think of a reason to have it in individual ones).
1512 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Metrics.css:
1513 Changed to use an explicit divider element between green time and performance groups,
1514 as there are too many combinations to easily express in CSS.
1516 2014-08-28 Carlos Garcia Campos <cgarcia@igalia.com>
1518 [GTK] Add webkit_uri_response_get_http_headers to WebKit2 GTK+ API
1519 https://bugs.webkit.org/show_bug.cgi?id=136248
1521 Reviewed by Gustavo Noronha Silva.
1523 Add new test case for webkit_uri_response_get_http_headers().
1525 * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
1526 (testURIResponseHTTPHeaders):
1530 2014-08-27 Alexey Proskuryakov <ap@apple.com>
1532 EWS status link at build.webkit.org/dashboard is incorrect until EWS pop-up is opened
1533 https://bugs.webkit.org/show_bug.cgi?id=131668
1535 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js:
1536 (EWSQueue.prototype.loadDetailedStatus): Fixed a typo in assertion.
1538 2014-08-27 Zalan Bujtas <zalan@apple.com>
1540 Subpixel layout: Cleanup snapSizeToPixel/snapSizeToDevicePixel.
1541 https://bugs.webkit.org/show_bug.cgi?id=136264
1543 Reviewed by Simon Fraser.
1545 1. Align snapSizeToPixel()/snapSizeToDevicePixel() function names with the rest of snapping
1546 functions. ->snappedIntSize()/snapSizeToDevicePixel().
1547 2. Operate on LayoutSize/LayoutPoint instead of LayoutUnit/LayoutUnit to reflect functionality.
1549 Covered by existing tests.
1551 * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
1552 (TestWebKitAPI::TEST): Deleted.
1554 2014-08-27 Alexey Proskuryakov <ap@apple.com>
1556 EWS status link at build.webkit.org/dashboard is incorrect until EWS pop-up is opened
1557 https://bugs.webkit.org/show_bug.cgi?id=131668
1559 Reviewed by Daniel Bates.
1561 We used to fetch the URL from EWS detailed status JSON, but there isn't much reason
1562 to not just hardcode.
1564 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js:
1565 (EWS.prototype.queueStatusURL): Added.
1567 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js:
1568 (EWSQueue.prototype.get statusPageURL): Use the above function.
1569 (EWSQueue.prototype.loadDetailedStatus): Changed assignment to an assertion.
1571 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js:
1572 (EWSQueueView.prototype.update): While at it, made a popover show up even if there
1573 are no patches in the queue. The popover has other useful information, such as charts
1574 link and bot status.
1576 2014-08-27 Alexey Proskuryakov <ap@apple.com>
1578 https://bugs.webkit.org/show_bug.cgi?id=136317
1579 Dashboard metrics page sometimes shows 0 for best time
1581 Reviewed by Tim Horton.
1583 This also affects regular dashboard display in a good way - iterations that failed
1584 due to infrastructure misbehavior will more reliably show up as yellow and not red.
1586 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1587 (BuildbotIteration): Added a list of steps that we actually care about. It will need to be
1588 updated if we rename steps.
1589 (BuildbotIteration.prototype.get productive): Now that computation is more involved,
1591 (BuildbotIteration.prototype._parseData): Tweak computation of "productive" - builds
1592 that failed e.g. at downloading built archive step are not productive.
1594 2014-08-27 Brent Fulgham <bfulgham@apple.com>
1596 [Win] Unreviewed gardening.
1598 * win/AssembleBuildLogs/AssembleLogs.cmd: Add some missing build logs to the set
1599 of logs assembled into the final build output.
1601 2014-08-27 Alexey Proskuryakov <ap@apple.com>
1603 build.webkit.org/dashboard: Add a metrics page with overall bot performance results
1604 https://bugs.webkit.org/show_bug.cgi?id=136196
1606 Reviewed by Timothy Hatcher.
1608 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External: Added.
1609 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External/daterangepicker.css: Added.
1610 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External/jquery-1.11.1.min.js: Added.
1611 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External/jquery.daterangepicker.js: Added.
1612 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External/moment.min.js: Added.
1613 A date range picker control with dependencies.
1614 There are a few modifications from upstream at <https://github.com/longbill/jquery-date-range-picker>:
1615 - Fixed a bug where selected dates were not at midnight the first time a range was chosen
1616 (it didn't happen again upon re-opening the picker).
1617 - Made made style tweaks to match Dashboard UI.
1619 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
1620 Don't create objects that are not needed by the given app, and thus are not loaded at all.
1622 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js: Added.
1623 Math to count all the things. Only supports open source tree and trunk at the moment,
1624 but written with internal tree and branches in mind.
1626 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js: Added.
1627 Like dashboard Main.js, draws the UI and creates all necessary objects.
1629 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsView.js: Added.
1630 A view for table cells.
1632 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
1633 (Settings.prototype.toggleSettingsDisplay): Added an event for entering settings.
1634 Metrics page has individual platforms initially scrolled away form the view, so
1635 it needs to scroll down to reveal what's being configured.
1637 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
1638 Added Array.prototype.average and Array.prototype.median.
1640 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1641 Made gear icon fixed instead of absolute, so that it's visible on metrics page when
1644 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Metrics.css:
1645 Additional style rules.
1647 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/metrics.html:
1650 2014-08-27 Gyuyoung Kim <gyuyoung.kim@samsung.com>
1652 Remove networkinfo watch category in watchlist
1653 https://bugs.webkit.org/show_bug.cgi?id=136279
1655 Reviewed by Alexey Proskuryakov.
1657 Network info was removed. So, it is not needed anymore.
1659 * Scripts/webkitpy/common/config/watchlist:
1661 2014-08-26 Alexey Proskuryakov <ap@apple.com>
1663 build.webkit.org/dashboard: Poor performance when there are broken builds at initial load time
1664 https://bugs.webkit.org/show_bug.cgi?id=136281
1666 Reviewed by Tim Horton.
1668 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1669 Track and expose whether the itertion is being loaded. Made update() a no-op if
1670 the iteration is already being loaded.
1672 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
1673 (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus): Instead of
1674 loading everything at once, ask the queue to load a little more. We can always repeat
1675 if we still don't have enough data.
1677 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1678 (BuildbotQueue.prototype.loadMoreHistoricalIterations): Added a function that loads
1679 10 more iterations intelligently.
1681 2014-08-26 Alexey Proskuryakov <ap@apple.com>
1683 build.webkit.org/dashboard raises an exception when Trac RSS fails to load
1684 https://bugs.webkit.org/show_bug.cgi?id=136283
1686 Reviewed by Tim Horton.
1688 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
1691 2014-08-26 Alexey Proskuryakov <ap@apple.com>
1693 build.webkit.org/dashboard raises an exception after a hidden platform is removed
1694 https://bugs.webkit.org/show_bug.cgi?id=136282
1696 Reviewed by Tim Horton.
1698 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
1699 (updateHiddenPlatforms): Check that the platform is still valid.
1701 2014-08-26 Matt Lilek <mrl@apple.com>
1703 Add WebKit SPI to control the navigator.standalone property
1704 https://bugs.webkit.org/show_bug.cgi?id=136189
1706 Reviewed by Andy Estes.
1708 Add API test for WKPreferences
1710 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1711 * TestWebKitAPI/Tests/WebKit2Cocoa/Preferences.mm:
1714 2014-08-26 Gyuyoung Kim <gyuyoung.kim@samsung.com>
1716 Remove ENABLE_DRT environment variable to enable SHARED_CORE
1717 https://bugs.webkit.org/show_bug.cgi?id=136205
1719 Reviewed by Andrei Bucur.
1721 EFL port doesn't need to enable SHARED_CORE since r172894. Thus, we don't need to
1722 use ENABLE_DRT enviroment variable, which enables SHARED_CORE.
1724 * Scripts/webkitdirs.pm:
1725 (generateBuildSystemFromCMakeProject):
1727 2014-08-26 Brent Fulgham <bfulgham@apple.com>
1729 [Win] Version stamp should include package-level version
1730 https://bugs.webkit.org/show_bug.cgi?id=136266
1731 <rdar://problem/18134138>
1733 Reviewed by David Kilzer.
1735 * Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl: Add
1736 tests for the full 3+ digit version.
1737 * Scripts/webkitperl/auto-version_unittest/versionStampTests.pl:
1738 Confirm that the final output DLL uses the 3+ digit version.
1740 2014-08-26 Brent Fulgham <bfulgham@apple.com>
1742 [Win] WebKit IDL incorrectly passes HWND as OLE_HANDLE
1743 https://bugs.webkit.org/show_bug.cgi?id=136258
1744 <rdar://problem/18134138>
1746 Reviewed by Tim Horton.
1748 Avoid 32/64-bit truncation by preventing 64-bit HWND (and other)
1749 values from passing through the 32-bit OLE_HANDLE data type.
1751 * DumpRenderTree/win/AccessibilityControllerWin.cpp:
1752 (AccessibilityController::rootElement):
1753 * DumpRenderTree/win/DumpRenderTree.cpp:
1754 (resetWebViewToConsistentStateBeforeTesting):
1756 (createWebViewAndOffscreenWindow):
1757 * DumpRenderTree/win/FrameLoadDelegate.h:
1758 (FrameLoadDelegate::didReceiveIcon):
1759 * DumpRenderTree/win/TestRunnerWin.cpp:
1760 (TestRunner::setWindowIsKey):
1761 * DumpRenderTree/win/UIDelegate.cpp:
1762 (UIDelegate::trackCustomPopupMenu):
1763 (UIDelegate::drawHeaderInRect):
1764 (UIDelegate::drawFooterInRect):
1765 (UIDelegate::webViewClose):
1766 (UIDelegate::webViewFocus):
1767 (UIDelegate::webViewSetCursor):
1768 (UIDelegate::drawBackground):
1769 * DumpRenderTree/win/UIDelegate.h:
1770 (UIDelegate::webViewFirstResponder):
1771 (UIDelegate::makeFirstResponder):
1772 (UIDelegate::contextMenuItemsForElement):
1773 (UIDelegate::addCustomMenuDrawingData):
1774 (UIDelegate::cleanUpCustomMenuDrawingData):
1775 (UIDelegate::webViewLostFocus):
1776 * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp:
1777 (TestWebKitAPI::WebViewDestructionWithHostWindow::SetUp):
1778 * WinLauncher/PrintWebUIDelegate.cpp:
1779 (PrintWebUIDelegate::drawHeaderInRect):
1780 (PrintWebUIDelegate::drawFooterInRect):
1781 * WinLauncher/PrintWebUIDelegate.h:
1782 (PrintWebUIDelegate::webViewFirstResponder):
1783 (PrintWebUIDelegate::makeFirstResponder):
1784 (PrintWebUIDelegate::contextMenuItemsForElement):
1785 (PrintWebUIDelegate::trackCustomPopupMenu):
1786 (PrintWebUIDelegate::addCustomMenuDrawingData):
1787 (PrintWebUIDelegate::cleanUpCustomMenuDrawingData):
1788 * WinLauncher/WinLauncher.cpp:
1789 (WinLauncher::prepareViews):
1790 * WinLauncher/WinLauncherWebHost.h:
1791 (WinLauncherWebHost::didReceiveIcon):
1793 2014-08-26 Daniel Bates <dabates@apple.com>
1795 Only define WEBCORE_EXPORT when building DumpRenderTree for Windows and iOS
1797 Rubber-stamped by Tim Horton.
1799 The Windows and iOS ports are the only ports that make use of WebCore headers
1802 * DumpRenderTree/config.h:
1804 2014-08-26 Dan Bernstein <mitz@apple.com>
1806 runSvnUpdateAndResolveChangeLogs() doesn’t work when invoked from a script outside Tools/Scripts
1807 https://bugs.webkit.org/show_bug.cgi?id=136254
1809 Reviewed by Tim Horton.
1811 * Scripts/webkitdirs.pm:
1812 (runSvnUpdateAndResolveChangeLogs): Locate resolve-ChangeLogs relative to the source tree,
1813 not the invoking script.
1815 2014-08-26 Krzysztof Czech <k.czech@samsung.com>
1817 [EFL] Utilize espeak as a synthesizer back-end for WebSpeech
1818 https://bugs.webkit.org/show_bug.cgi?id=136127
1820 Reviewed by Gyuyoung Kim.
1822 Add espeak dependency.
1824 * efl/install-dependencies:
1826 2014-08-25 Alexey Proskuryakov <ap@apple.com>
1828 Remove a little more accidentally landed code from r172891.
1830 iteration.branch also wasn't meant to be landed.
1832 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1833 (BuildbotIteration.prototype._parseData):
1835 2014-08-25 Alexey Proskuryakov <ap@apple.com>
1837 REGRESSION (r172891): Internal dashboard is broken.
1839 Removing some accidentally landed code - I needed "changes" for another patch, but
1840 not here, and then I decided to not use it anyway.
1842 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1843 (BuildbotIteration.prototype._parseData):
1845 2014-08-25 Daniel Bates <dabates@apple.com>
1847 Fix the iOS DumpRenderTree build after <http://trac.webkit.org/changeset/172814/>
1848 (https://bugs.webkit.org/show_bug.cgi?id=136108)
1850 Use a similar approach as in TestWebKitAPI/config.h and define a stub for the macro define WEBCORE_EXPORT
1851 so that we can compile DumpRenderTree for iOS.
1853 * DumpRenderTree/config.h:
1855 2014-08-25 Alexey Proskuryakov <ap@apple.com>
1857 Make build.webkit.org/dashboard work with changeset_show_files=location
1858 https://bugs.webkit.org/show_bug.cgi?id=136237
1860 Reviewed by Tim Horton.
1862 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
1863 (Trac.prototype._convertCommitInfoElementToObject): Remove location information
1864 from description before getting title, and also actually parse the location into
1865 result object when available.
1867 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
1868 (String.prototype.startsWith): Added.
1870 2014-08-25 Tanay C <tanay.c@samsung.com>
1872 [EFL][WK2] Minibrowser : Enhance application to be able to support history list navigation
1873 https://bugs.webkit.org/show_bug.cgi?id=135795
1875 Reviewed by Gyuyoung Kim.
1877 * MiniBrowser/efl/main.c: Adding functionality for long press history list navigation
1878 (history_list_hide): Hiding and dereferencing the history list and items
1881 (on_back_button_clicked): Early return for longpress
1882 (on_forward_button_clicked): Early return for longpress
1883 (list_item_label_get): Populate item labels
1884 (on_list_item_select): Navigates on selection from history list
1885 (navigation_button_longpress_process): Populates the history list and displays it
1886 (on_forward_button_longpress):
1887 (on_back_button_longpress):
1888 (window_create): Add the widget for history list
1890 2014-08-25 Carlos Alberto Lopez Perez <clopez@igalia.com>
1892 [GTK] JHBuild module gst-plugins-base fails to build on x86 with GCC 4.9
1893 https://bugs.webkit.org/show_bug.cgi?id=136152
1895 Reviewed by Philippe Normand.
1897 * gtk/jhbuild.modules: Apply gst-plugins-base-fix-build-gcc-4.9-x86.patch.
1898 * gtk/patches/gst-plugins-base-fix-build-gcc-4.9-x86.patch: Added.
1899 Cherry pick upstream patches daa194 and 4e3d101.
1901 2014-08-24 Zan Dobersek <zdobersek@igalia.com>
1903 GenericHashTraits::peek() is producing copies of passed-in temporary values
1904 https://bugs.webkit.org/show_bug.cgi?id=131461
1906 Reviewed by Darin Adler.
1908 Add a test case that checks the number of copies and moves of the mapped objects
1909 when calling HashMap::get(). Exactly one copy of the mapped value should be
1910 performed when there exists a value that is mapped to the specified key, and
1911 exactly one move and no copies of the empty value should be performed when there
1912 isn't any mapped value for the specified key.
1914 * TestWebKitAPI/Tests/WTF/CopyMoveCounter.h: Added.
1915 (CopyMoveCounter::TestingScope::TestingScope):
1916 (CopyMoveCounter::CopyMoveCounter):
1917 (CopyMoveCounter::operator=):
1918 * TestWebKitAPI/Tests/WTF/HashMap.cpp:
1919 (TestWebKitAPI::TEST):
1921 2014-08-24 Ryuan Choi <ryuan.choi@samsung.com>
1923 [EFL] Introduce DEVELOPER_MODE
1924 https://bugs.webkit.org/show_bug.cgi?id=135884
1926 Reviewed by Gyuyoung Kim.
1928 * Scripts/webkitdirs.pm: Turn on DEVELOPER_MODE for the EFL port.
1929 (generateBuildSystemFromCMakeProject):
1931 2014-08-24 Alexey Proskuryakov <ap@apple.com>
1933 build.webkit.org/dashboard unnecessarily loads results of hidden queues
1934 https://bugs.webkit.org/show_bug.cgi?id=136195
1936 Reviewed by Tim Horton.
1938 This patch also makes it possible to avoid any automatic loading, as needed for metrics view.
1940 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1941 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js:
1942 Don't start an update just because a queue object was created. Periodic updates
1943 are triggered by views, so it only makes sense to do the same for the initial update.
1945 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
1946 Now that Trac object doesn't auto-load, start loading here.
1948 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
1949 (QueueView): Calling _updateHiddenState right away was wrong, because it accesses
1950 a data member added by subclasses later. With this.platform being undefined, it
1951 always looked like this queue was not hidden.
1952 (QueueView.prototype._updateHiddenState): Start an immediate update, too.
1954 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
1955 (Trac): Don't load anything here, the client may choose to load a custom date range.
1956 (Trac.prototype.startPeriodicUpdates): Added a function to start automatic loading.
1958 2014-08-23 Alexey Proskuryakov <ap@apple.com>
1960 build.webkit.org/dashboard: Further improve Trac loading
1961 https://bugs.webkit.org/show_bug.cgi?id=136174
1963 Reviewed by Timothy Hatcher.
1965 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
1966 (Trac.prototype._xmlTimelineURL): Passing -1 as "max" resulted in an off by one
1967 error, the oldest commit within the range wasn't returned. The correct argument for
1969 (Trac.prototype.load): Added a function to load a specific time range.
1970 (Trac.prototype._loaded): Updated to support loading revisions that are arbitrarily
1971 positioned with regards to ones that were already known.
1973 2014-08-23 Alexey Proskuryakov <ap@apple.com>
1975 build.webkit.org/dashboard: Make it possible to pull historic data from Buildbot
1976 https://bugs.webkit.org/show_bug.cgi?id=136182
1978 Reviewed by Timothy Hatcher.
1980 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1981 Make it possible to create a complete BuildbotIteration object with JSON, not only by
1982 loading data from the network.
1984 An iteration has three states:
1985 1. Just created, it only knows the revision, and whether it's already finished.
1986 BuildbotIteration constructor used to create these.
1987 2. A complete JSON report loaded from buildbot. The new constructor form creates these.
1988 3. Data about tests is fetched.
1990 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1991 Make it possible to pull all data from a buildbot queue. This needs to be better
1992 optimized eventually, as it's somewhat slow.
1994 2014-08-22 Renato Nagy <nagy.renato@stud.u-szeged.hu>
1997 https://bugs.webkit.org/show_bug.cgi?id=136170
1999 Reviewed by Gyuyoung Kim.
2001 * Scripts/webkitpy/common/config/watchlist:
2002 * Scripts/webkitpy/style/checker.py:
2004 2014-08-22 Carlos Alberto Lopez Perez <clopez@igalia.com>
2006 [GTK] install-dependencies don't installs Xvfb that is needed for the tests.
2007 https://bugs.webkit.org/show_bug.cgi?id=136153
2009 Reviewed by Martin Robinson.
2011 * gtk/install-dependencies: Add Xvfb package to the list of dependencies necessary for running tests.
2013 2014-08-21 Alex Christensen <achristensen@webkit.org>
2015 [Win] Another unreviewed build fix.
2017 * DumpRenderTree/config.h:
2018 Defined WEBCORE_EXPORT on Windows.
2020 2014-08-21 Rohit Kumar <kumar.rohit@samsung.com>
2022 [EFL][WK2] Minibrowser : Add stop button to abort page load
2023 https://bugs.webkit.org/show_bug.cgi?id=136122
2025 Reviewed by Gyuyoung Kim.
2027 * MiniBrowser/efl/main.c:
2029 (on_stop_button_clicked): Callback for stop button press.
2032 2014-08-21 Carlos Alberto Lopez Perez <clopez@igalia.com>
2034 [GTK] Load the llvmpipe (Mesa) libraries when running the tests with Xvfb.
2035 https://bugs.webkit.org/show_bug.cgi?id=134070
2037 Reviewed by Martin Robinson.
2039 * Scripts/webkitpy/port/base.py:
2040 (Port.__init__): Set default _jhbuild_wrapper variable.
2041 (Port._should_use_jhbuild): Implement generic check.
2042 * Scripts/webkitpy/port/efl.py: Rename to jhbuild_wrapper variable
2043 to make it consistent with the other ports.
2044 * Scripts/webkitpy/port/gtk.py:
2045 (GtkPort.__init__): Use the new _should_use_jhbuild() method.
2046 (GtkPort.setup_environ_for_server): Get the path for llvmpipe_libgl_path by
2047 querying the jhbuild with printenv. Also check that the path contains
2048 the libraries we expect. Preload this path only for XvfbDriver.
2049 * Scripts/webkitpy/port/xvfbdriver.py:
2050 (XvfbDriver.check_driver): Check for the jhbuild wrapper and use it.
2051 (XvfbDriver._start): The environment for llvmpipe_libgl_path is now
2052 configured at setup_environ_for_server()
2053 * Scripts/webkitpy/port/xvfbdriver_unittest.py:
2054 (XvfbDriverTest.make_driver): Get the port default environment.
2055 (XvfbDriverTest.test_start_no_pixel_tests): The expected log now
2056 should include the environment that is passed when running Xvfb.
2057 (XvfbDriverTest.test_start_pixel_tests): Ditto.
2058 (XvfbDriverTest.test_start_arbitrary_worker_number): Ditto.
2059 (XvfbDriverTest.test_start_next_worker): Ditto.
2060 * gtk/jhbuild.modules: Rename checkoutdir to generic "Mesa" to
2061 prevent future problems when the version is raised. Add also a
2062 comment with a warning.
2063 * gtk/jhbuildrc: The path LLVMPIPE_LIBGL_PATH should be the one
2064 that has the llvm optimized Gallium libGL libraries.
2066 2014-08-21 Renato Nagy <nagy.renato@stud.u-szeged.hu>
2068 Fix countFailures of RunLLINTCLoopTests and Run32bitJSCTests.
2069 https://bugs.webkit.org/show_bug.cgi?id=136125
2071 Reviewed by Csaba Osztrogonác.
2073 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2074 (RunLLINTCLoopTests.countFailures):
2075 (Run32bitJSCTests.countFailures):
2076 * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2077 (RunLLINTCLoopTestsTest):
2078 (RunLLINTCLoopTestsTest.assertResults):
2079 (RunLLINTCLoopTestsTest.test_failures):
2080 (RunLLINTCLoopTestsTest.test_failure):
2081 (RunLLINTCLoopTestsTest.test_no_failure):
2082 (Run32bitJSCTestsTest):
2083 (Run32bitJSCTestsTest.assertResults):
2084 (Run32bitJSCTestsTest.test_failures):
2085 (Run32bitJSCTestsTest.test_failure):
2086 (Run32bitJSCTestsTest.test_no_failure):
2088 2014-08-20 Gyuyoung Kim <gyuyoung.kim@samsung.com>
2090 Unreviewed, EFL build fix since r172814.
2092 * WebKitTestRunner/config.h: Define WEBCORE_EXPORT.
2094 2014-08-20 Alex Christensen <achristensen@webkit.org>
2096 Introducing WEBCORE_EXPORT macro.
2097 https://bugs.webkit.org/show_bug.cgi?id=136108
2099 Reviewed by Antti Koivisto.
2101 * TestWebKitAPI/config.h:
2102 Added stub definition of WEBCORE_EXPORT defined to nothing to be able to compile with WebCore headers.
2104 2014-08-20 Rebecca Hauck <rhauck@adobe.com>
2106 import-w3c-tests doesn't import .svg support files
2107 https://bugs.webkit.org/show_bug.cgi?id=135928
2109 Reviewed by Bem Jones-Bey.
2111 This patch fixes the W3C import script to not treat all
2112 files with an xml mimetype as convertible tests, which
2113 was causing SVG support files to not be imported.
2115 * Scripts/webkitpy/w3c/test_importer.py:
2116 (TestImporter.find_importable_tests):
2118 2014-08-19 Dan Bernstein <mitz@apple.com>
2120 update-webkit should not check for the presence of Apple’s Internal directory
2121 Last part of https://bugs.webkit.org/show_bug.cgi?id=135815
2123 Reviewed by Tim Horton.
2125 * Scripts/update-webkit:
2127 2014-08-19 Zalan Bujtas <zalan@apple.com>
2129 Remove ENABLE(SUBPIXEL_LAYOUT).
2130 https://bugs.webkit.org/show_bug.cgi?id=136077
2132 Reviewed by Simon Fraser.
2134 Remove compile time flag SUBPIXEL_LAYOUT. All ports have it enabled for a while now.
2136 * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
2138 2014-08-19 Akos Kiss <akiss@inf.u-szeged.hu>
2140 Let the caller define JSC_timeout for run-javascriptcore-tests
2141 https://bugs.webkit.org/show_bug.cgi?id=136068
2143 Reviewed by Csaba Osztrogonác.
2145 Keep the 60 second timeout for jsc tests as the default setting but
2146 don't override the value of JSC_timeout if already set.
2148 * Scripts/run-javascriptcore-tests:
2150 2014-08-19 Renato Nagy <nagy.renato@stud.u-szeged.hu>
2152 Remove obsolete run-javascriptcore-tests result parsing from master.cfg
2153 https://bugs.webkit.org/show_bug.cgi?id=136039
2155 Reviewed by Csaba Osztrogonác.
2157 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2158 (RunJavaScriptCoreTests.commandComplete):
2159 * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2160 (RunJavaScriptCoreTestsTest.test_no_failure_new_output):
2161 (RunJavaScriptCoreTestsTest.test_mozilla_failure_old_output):
2162 (RunJavaScriptCoreTestsTest):
2163 (RunJavaScriptCoreTestsTest.test_jsc_stress_failure_new_output):
2164 (RunJavaScriptCoreTestsTest.test_mozilla_failure_new_output): Deleted.
2165 (test_layout_failure_new_output): Deleted.
2166 (test_layout_crash_new_output): Deleted.
2167 (test_mozilla_and_layout_failure_new_output): Deleted.
2168 (test_jsc_stress_failure_new_output): Deleted.
2169 (test_js_crashes_and_jsc_stress_failures_new_output): Deleted.
2171 2014-08-19 Alexey Proskuryakov <ap@apple.com>
2173 build.webkit.org/dashboard should not request 50 revisions from trac each time
2174 https://bugs.webkit.org/show_bug.cgi?id=127130
2176 build.webkit.org/dashboard sometimes fetches a Trac revision in an intermediate state, and never updates later
2177 https://bugs.webkit.org/show_bug.cgi?id=127131
2179 Reviewed by Timothy Hatcher.
2181 Turns out that requesting 50 builds is much slower than requesting by date - even
2182 if the request ends up returning more than 50 results. There is no way to only
2183 request updates, but this change brings request time from 6-8 seconds down to
2186 This patch generalizes date handling for later use in metrics code. As part of the
2187 rewrite, I made newly fetched data update author e-mail in previously fetched
2188 revisions, as it changes after commit queue first lands.
2190 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2191 Updated for event rename. I changed the trac event to not contain the list of new
2192 commits, as we now sometimes update old commits, and that couldn't be expressed
2193 in event data. We never used the list anywhere in the first place.
2195 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
2196 (Trac.prototype._xmlTimelineURL): Made this function take arbitrary dates. When called
2197 without arguments, return commits for today and yesterday.
2198 (Trac.prototype._loaded):
2199 (Trac.prototype.update): Moved the function for processing loaded results out of
2200 here for clarity, and also because I'm going to have a separate loading code path
2203 2014-08-18 Dan Bernstein <mitz@apple.com>
2205 Added an update-webkit option to override the ../Internal check.
2206 Part of https://bugs.webkit.org/show_bug.cgi?id=135815
2208 Reviewed by Tim Horton.
2210 * Scripts/update-webkit:
2211 Added an explicit --internal option to control updating ../Internal, defaulting to whether
2213 (runSvnUpdate): Moved to webkitdirs.pm.
2214 (runGitUpdate): Ditto.
2215 * Scripts/webkitdirs.pm:
2216 (runSvnUpdateAndResolveChangeLogs): Moved runSvnUpdate from update-webkit and renamed to this.
2217 (runGitUpdate): Moved from update-webkit.
2219 2014-08-18 Pratik Solanki <psolanki@apple.com>
2221 Make update-webkit more lenient for pure git svn repositories
2222 https://bugs.webkit.org/show_bug.cgi?id=135805
2224 Reviewed by Oliver Hunt.
2226 Make the call to git fetch be non fatal. If you have a pure git svn repository, then the
2227 call to git fetch will fail and update-webkit will abort. The purpose of r72966 was to
2228 provide an optimization when you have a git repository setup. We should not fail if the
2229 git setup does not have svn-remote.svn.fetch set.
2231 * Scripts/update-webkit:
2234 2014-08-18 Simon Fraser <simon.fraser@apple.com>
2236 Enable Web Inspector in MiniBrowser WK2 windows
2237 https://bugs.webkit.org/show_bug.cgi?id=136045
2239 Reviewed by Tim Horton.
2241 Set the pref to enable developer extras for all WK2 windows.
2243 * MiniBrowser/mac/WK2BrowserWindowController.m:
2244 (-[WK2BrowserWindowController awakeFromNib]):
2246 2014-08-18 Renato Nagy <nagy.renato@stud.u-szeged.hu>
2248 master.cfg should handle special return codes of run-perf-tests
2249 https://bugs.webkit.org/show_bug.cgi?id=135974
2251 Reviewed by Ryosuke Niwa.
2253 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2254 (RunAndUploadPerfTests.getText2):
2255 * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2256 (RunAndUploadPerfTestsTest):
2257 (RunAndUploadPerfTestsTest.assertResults):
2258 (RunAndUploadPerfTestsTest.test_tests_failed):
2259 (RunAndUploadPerfTestsTest.test_build_bad_build):
2260 (RunAndUploadPerfTestsTest.test_build_bad_source_json):
2261 (RunAndUploadPerfTestsTest.test_build_bad_marge):
2262 (RunAndUploadPerfTestsTest.test_build_bad_failed_uploading):
2263 (RunAndUploadPerfTestsTest.test_build_bad_preparation):
2265 2014-08-17 Brent Fulgham <bfulgham@apple.com>
2267 [Win] Unreviewed change to force rebuild
2268 (plus drive-by add an accessor I wanted for
2269 some future tooling).
2271 * WinLauncher/WinLauncher.h:
2272 (WinLauncher::webView): Added.
2274 2014-08-16 Mark Hahnenberg <mhahnenb@gmail.com>
2276 Update contributors.json for my new email
2277 https://bugs.webkit.org/show_bug.cgi?id=136021
2279 Reviewed by Filip Pizlo.
2281 * Scripts/webkitpy/common/config/contributors.json:
2283 2014-08-15 Alexey Proskuryakov <ap@apple.com>
2285 REGRESSION (r172660): WebKit2.TerminateTwice asserts
2286 https://bugs.webkit.org/show_bug.cgi?id=136012
2288 * TestWebKitAPI/Tests/WebKit2/TerminateTwice.cpp: Skipped the test in debug mode.
2290 2014-08-15 Ryuan Choi <ryuan.choi@samsung.com>
2292 Unreviewed build fix attempt on the CMake based pots since r172665
2294 * TestWebKitAPI/CMakeLists.txt: Added JavaScriptCore/interpreter to the include list.
2296 2014-08-15 Brian J. Burg <burg@cs.washington.edu>
2298 Web Inspector: rewrite CodeGeneratorInspector to be modular and testable
2299 https://bugs.webkit.org/show_bug.cgi?id=131596
2301 Reviewed by Joseph Pecoraro.
2303 * Scripts/run-inspector-generator-tests: Added.
2305 * Scripts/webkitpy/inspector/__init__.py: Added.
2306 * Scripts/webkitpy/inspector/main.py: Added.
2307 (InspectorGeneratorTests):
2308 (InspectorGeneratorTests.__init__):
2309 (InspectorGeneratorTests.generate_from_json):
2310 (InspectorGeneratorTests.write_error_file):
2311 (InspectorGeneratorTests.detect_changes):
2312 (InspectorGeneratorTests.run_tests):
2313 (InspectorGeneratorTests.main):
2315 2014-08-15 Rebecca Hauck <rhauck@adobe.com>
2317 run-webkit-tests should skip 'support' directories
2318 https://bugs.webkit.org/show_bug.cgi?id=135910
2320 Reviewed by Bem Jones-Bey.
2322 This patch adds the 'support' directory to the list
2323 of dirs to skip when looking for runnable tests.
2324 the W3C uses this name for support files, so tests
2325 imported from the W3C will not work without this change
2326 or without many edits.
2328 * Scripts/webkitpy/port/base.py:
2331 2014-08-14 Brent Fulgham <bfulgham@apple.com>
2333 [Win] Extend auto-version and version-stamp for RC_ProjectBuildVersion
2334 https://bugs.webkit.org/show_bug.cgi?id=135948
2335 <rdar://problem/18022221>
2337 Reviewed by David Kilzer.
2339 * Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl: Add tests
2340 for RC_ProjectBuildVersion.
2342 2014-08-05 David Farler <dfarler@apple.com>
2344 [iOS] run-webkit-tests runs webkit-build-directory on every test
2345 https://bugs.webkit.org/show_bug.cgi?id=135409
2347 Reviewed by Daniel Bates.
2349 * Scripts/webkitpy/port/ios.py:
2350 (IOSSimulatorPort.__init__): Cache Mac build directory.
2351 (IOSSimulatorPort.relay_path): Use cached build directory.
2352 (IOSSimulatorPort._path_to_image_diff): Use cached build directory.
2354 2014-08-14 Zan Dobersek <zdobersek@igalia.com>
2356 Initialize a separate variable (TestWTF_SOURCES) with the list of files
2357 that are built into the TestWTF executable and move it above the platform-specific
2358 config file inclusion. This makes it possible to add platform-specific files to that
2359 list (e.g. GUniquePtr.cpp for the GTK port).
2361 Rubber-stamped by Carlos Garcia Campos.
2363 * TestWebKitAPI/CMakeLists.txt:
2364 * TestWebKitAPI/PlatformGTK.cmake:
2366 2014-08-13 Akos Kiss <akiss@inf.u-szeged.hu>
2368 [EFL] Bump up and patch dependencies to allow building for aarch64
2369 https://bugs.webkit.org/show_bug.cgi?id=135885
2371 Reviewed by Gyuyoung Kim.
2373 The currently used versions of pixman, libffi, glib, glib-networking,
2374 and fontconfig fail to configure for aarch64, so they are bumped up to
2375 the latest stable version.
2377 Gstreamer-plugins-base configures for aarch64 but incorrectly recogizes
2378 ARM NEON assembly support, so it is patched with a change that has been
2379 accepted by upstream.
2381 * efl/jhbuild.modules:
2382 * efl/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch: Added.
2384 2014-08-13 Mark Rowe <mrowe@apple.com>
2386 <https://webkit.org/b/135911> WebKit should build on Yosemite with the public SDK.
2388 Reviewed by Darin Adler.
2390 * DumpRenderTree/mac/TextInputController.m: Don't use extern "C" in a non-C++ file.
2392 2014-08-13 Alex Christensen <achristensen@webkit.org>
2394 Progress towards CMake on Mac.
2395 https://bugs.webkit.org/show_bug.cgi?id=135819
2397 Reviewed by Laszlo Gombos.
2399 * WebKitTestRunner/CMakeLists.txt:
2400 Added new cpp parameter for the extension of the generated files.
2402 2014-08-13 Renato Nagy <nagy.renato@stud.u-szeged.hu>
2404 Make check-webkit-style run sort-export-file
2405 https://bugs.webkit.org/show_bug.cgi?id=135877
2407 Reviewed by Csaba Osztrogonác.
2409 * Scripts/webkitpy/style/checker.py:
2412 (CheckerDispatcher._file_type):
2413 (CheckerDispatcher._create_checker):
2414 * Scripts/webkitpy/style/checkers/exportfile.py: Added.
2415 (ExportFileChecker):
2416 (ExportFileChecker.__init__):
2417 (ExportFileChecker.check):
2418 * Scripts/webkitpy/style/checkers/exportfile_unittest.py: Added.
2419 (handle_style_error):
2421 (MockErrorHandler.__init__):
2422 (MockErrorHandler.turn_off_line_filtering):
2423 (MockErrorHandler.__call__):
2425 (ExportFileTest.setUp):
2426 (ExportFileTest.tearDown):
2427 (ExportFileTest.test_sorted):
2428 (ExportFileTest.test_non_sorted):
2429 (ExportFileTest.test_parse_error):
2431 2014-08-13 Jinwoo Song <jinwoo7.song@samsung.com>
2433 [EFL] Sets the persistent storage for cookies in MiniBrowser
2434 https://bugs.webkit.org/show_bug.cgi?id=135875
2436 Reviewed by Gyuyoung Kim.
2438 In case of EWK_COOKIE_ACCEPT_POLICY_ALWAYS, sets the persistent storage
2439 for non-session cookies can be stored persistently.
2441 * MiniBrowser/efl/main.c:
2444 2014-08-12 Daniel Bates <dabates@apple.com>
2446 [iOS] build-webkit should not build WebKitSystemInterface and WebKitAdditions
2447 https://bugs.webkit.org/show_bug.cgi?id=135845
2449 Reviewed by Andy Estes.
2451 Towards building the iOS WebKit port using the public SDK, remove the logic
2452 added to build-webkit to build projects WebKitSystemInterface and
2453 WebKitAdditions when building the iOS WebKit port.
2455 * Scripts/build-webkit:
2457 2014-08-12 Yusuke Suzuki <utatane.tea@gmail.com>
2459 [GTK] Adds dependency for GnuTLS 3.0+ explicitly in gtk/install-dependencies
2460 https://bugs.webkit.org/show_bug.cgi?id=135850
2462 Reviewed by Philippe Normand.
2464 After r172433, GTK port requires GnuTLS 3.0+. In this time, libgnutls-dev is 2.x in
2465 Ubuntu(trusty) and Debian(sid). So added libgnutls28-dev explicitly.
2467 * gtk/install-dependencies:
2469 2014-08-12 Eduardo Lima Mitev <elima@igalia.com>
2471 [GTK] Subtle-crypto feature off by default and add a new configure flag to enable it
2472 https://bugs.webkit.org/show_bug.cgi?id=135798
2474 Reviewed by Philippe Normand.
2476 * Scripts/webkitperl/FeatureList.pm: Adds new flag --subtle-crypto to
2477 toggle SUBTLE_CRYPTO feature.
2479 2014-08-12 Ryuan Choi <ryuan.choi@samsung.com>
2481 [EFL] Disable ecore logs about bad fd
2482 https://bugs.webkit.org/show_bug.cgi?id=135831
2484 Reviewed by Gyuyoung Kim.
2486 ecore checks EBADF and prints the warnings.
2487 But, it looks noise in layout test because it's not webkit issue.
2488 This patch disables it until we found right solution.
2490 * efl/jhbuild.modules:
2491 * efl/patches/ecore_remove_warnings.patch: Added.
2493 2014-08-12 Shivakumar JM <shiva.jm@samsung.com>
2495 [EFL][WK2] Minibrowser: Enhance the application to use download directory selector.
2496 https://bugs.webkit.org/show_bug.cgi?id=135791
2498 Reviewed by Gyuyoung Kim.
2500 Currently Minibrowser stores the downloaded files to /tmp directory, add support so that destination folder can be selected by the
2503 * MiniBrowser/efl/main.c:
2504 (on_download_request):
2506 2014-08-11 Grzegorz Czajkowski <g.czajkowski@samsung.com>
2508 [EFL] Prevent the client from creating ewk_view when EWebkit is not initialized
2509 https://bugs.webkit.org/show_bug.cgi?id=135606
2511 Reviewed by Gyuyoung Kim.
2513 TestWebKitAPI does not initialize EWebkit using ewk_init()
2514 which is not recommended.
2516 * TestWebKitAPI/efl/PlatformWebView.cpp:
2517 (TestWebKitAPI::createEcoreEvas):
2518 Renamed from initEcoreEvas() since it doesn't not initialize
2521 (TestWebKitAPI::PlatformWebView::PlatformWebView):
2522 Call ewk_init() that initalizes all EFL modules needed by EWebKit
2523 instead of ecore_evas_init() only.
2525 (TestWebKitAPI::PlatformWebView::~PlatformWebView):
2526 Call ewk_shutdown() to finalize EWebkit.
2527 (TestWebKitAPI::initEcoreEvas): Deleted.
2529 2014-08-11 Dan Bernstein <mitz@apple.com>
2531 Added an update-webkit option to update the auxiliary libraries or not.
2532 Part of https://bugs.webkit.org/show_bug.cgi?id=135815
2534 Reviewed by Tim Horton.
2536 * Scripts/update-webkit: Added --[no-]auxiliary-libs option, which defaults to yes unless
2537 an Internal directory exists alongside the WebKit root directory.
2539 2014-08-11 Bem Jones-Bey <bjonesbe@adobe.com>
2541 Remove hg changeset from w3c-import.log
2542 https://bugs.webkit.org/show_bug.cgi?id=135735
2544 Reviewed by Ryosuke Niwa.
2546 Since the csswg's test suite is now accessible via github and it is
2547 possible to push changes by creating github pull requests, the hg
2548 changeset makes less sense, as many people will just use a clone of
2549 the git repo. There isn't an obvious thing to replace it with, so
2550 might as well remove it for now instead of having it just be set to
2553 This also adds a pointer to the github repo in the generated comments
2554 in the w3c-import.log.
2556 * Scripts/webkitpy/w3c/test_importer.py:
2557 (TestImporter.__init__): Remove changeset handling.
2558 (TestImporter.do_import): Ditto.
2559 (TestImporter.write_import_log): Ditto.
2560 (TestImporter.load_changeset): Deleted.
2562 2014-08-11 Carlos Garcia Campos <cgarcia@igalia.com>
2564 Unreviewed. Fix GTK+ make distcheck.
2566 * gtk/manifest.txt: Remove Source/WebCore/Resources/inputSpeech.png.
2568 2014-08-08 Simon Fraser <simon.fraser@apple.com>
2570 Unbreak webkitpy unit tests by checking for the existence of the image diff template
2571 file before trying to open it (as the tests do for results.html).
2573 * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2574 (TestResultWriter.write_image_diff_files):
2576 2014-08-08 Simon Fraser <simon.fraser@apple.com>
2578 Load the layout test result image diff HTML from a file, rather than having it inline in webkitpy
2579 https://bugs.webkit.org/show_bug.cgi?id=135780
2581 Reviewed by Dan Bates.
2583 Pull the HTML for the image diff file into a separate file, for easier hackability.
2585 * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2586 (TestResultWriter.write_image_diff_files):
2588 2014-08-08 Mark Lam <mark.lam@apple.com>
2590 Gardening: fix Windows build after r172259.
2594 * DumpRenderTree/win/TestRunnerWin.cpp:
2595 (TestRunner::addMockSpeechInputResult): Deleted.
2596 (TestRunner::setMockSpeechInputDumpRect): Deleted.
2597 (TestRunner::startSpeechInput): Deleted.
2599 2014-08-08 Joseph Pecoraro <pecoraro@apple.com>
2601 make clean does not work in OpenSource, fails in WebKitLibraries
2602 https://bugs.webkit.org/show_bug.cgi?id=135734
2604 Reviewed by David Kilzer.
2606 * Scripts/copy-webkitlibraries-to-product-directory:
2607 Add a --clean switch that removes possible WebKitSystemInterface
2608 and LLVM libraries and headers that may have been copied to the
2611 2014-08-08 Joseph Pecoraro <pecoraro@apple.com>
2613 commit-log-message has extra blank line at the top of pre-populated message
2614 https://bugs.webkit.org/show_bug.cgi?id=135744
2616 Reviewed by Csaba Osztrogonác.
2618 Do not add a blank leading line in single ChangeLog commit messages.
2620 * Scripts/commit-log-editor:
2621 (createCommitMessage):
2622 * Scripts/webkitpy/common/checkout/checkout_unittest.py:
2623 (test_commit_message_for_one_reviewed_changelog):
2624 (test_commit_message_for_one_rollout_changelog):
2626 2014-08-07 Brent Fulgham <bfulgham@apple.com>
2628 [Win] Unreviewed gardening.
2630 Have 'Assemble Build Logs' step work properly for DebugSuffix target
2631 (both 32-bit and 64-bit).
2633 * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj:
2635 2014-08-07 Benjamin Poulain <bpoulain@apple.com>
2637 Get rid of INPUT_SPEECH
2638 https://bugs.webkit.org/show_bug.cgi?id=135672
2640 Reviewed by Andreas Kling.
2642 * DumpRenderTree/TestRunner.cpp:
2643 (TestRunner::staticFunctions):
2644 (addMockSpeechInputResultCallback): Deleted.
2645 (setMockSpeechInputDumpRectCallback): Deleted.
2646 * DumpRenderTree/TestRunner.h:
2647 * DumpRenderTree/mac/TestRunnerMac.mm:
2648 (TestRunner::addMockSpeechInputResult): Deleted.
2649 (TestRunner::setMockSpeechInputDumpRect): Deleted.
2650 (TestRunner::startSpeechInput): Deleted.
2652 2014-08-07 Bem Jones-Bey <bjonesbe@adobe.com>
2654 The support directory shouldn't be skipped unconditionally in test import
2655 https://bugs.webkit.org/show_bug.cgi?id=135660
2657 Reviewed by Ryosuke Niwa.
2659 The 'DIRS_TO_SKIP' should only be skipped when in the root directory
2660 of the test repo, as that's the only time they are special. In
2661 addition, instead of hardcoding .hg and .git as special, skip all
2662 directories that begin with '.', just like with files that begin with '.'.
2664 In order to make this work, the root directory must always be
2665 passed in, so the interface to the script has been changed to take the
2666 root directory, and if one wants to only import a subset of the tests,
2667 a new -t option can be used to limit the tests imported.
2669 * Scripts/webkitpy/w3c/test_importer.py:
2670 (main): Remove repo_dir command line argument.
2671 (parse_args): Add -t option and set expected non-option args to 1.
2672 (TestImporter.__init__): Remove repo_dir.
2673 (TestImporter.do_import): Handle the varying number of import
2675 (TestImporter.should_keep_subdir): Helper for find_importable_tests to
2676 determine if a subdirectory should be skipped.
2677 (TestImporter.find_importable_tests): Filter directories using new
2679 (TestImporter.import_tests): Remove use of repo_dir.
2680 (TestImporter.setup_destination_directory): Unused, Deleted.
2681 * Scripts/webkitpy/w3c/test_importer_unittest.py:
2682 (TestImporterTest.test_import_dir_with_no_tests_and_no_hg): Update for
2684 (TestImporterTest.test_import_dir_with_no_tests): Ditto.
2686 2014-08-07 Carlos Garcia Campos <cgarcia@igalia.com>
2688 [GTK] Use WebKitNavigationAction also for WebKitNavigationPolicyDecision
2689 https://bugs.webkit.org/show_bug.cgi?id=135695
2691 Reviewed by Gustavo Noronha Silva.
2693 Use WebKitNavigationAction API.
2695 * MiniBrowser/gtk/BrowserWindow.c:
2696 (webViewDecidePolicy):
2697 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitPolicyClient.cpp:
2698 (testNavigationPolicy):
2700 2014-08-07 Carlos Garcia Campos <cgarcia@igalia.com>
2702 [GTK] Test /webkit2/WebKitUserContentManager/injected-script fails
2703 https://bugs.webkit.org/show_bug.cgi?id=135696
2705 Reviewed by Sergio Villar Senin.
2707 Don't assume the JavaScript result is always a valid pointer. In case of JavaScript
2708 exception (that happens when testing the script hasn't been injected) the JavaScript
2711 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
2712 (isScriptInjectedForURLAtPath):
2714 2014-08-07 Csaba Osztrogonác <ossy@webkit.org>
2716 [GTK] Disable IndexedDB
2717 https://bugs.webkit.org/show_bug.cgi?id=135692
2719 Reviewed by Carlos Garcia Campos.
2721 * Scripts/webkitperl/FeatureList.pm:
2723 2014-08-06 Dean Jackson <dino@apple.com>
2725 ENABLE_CSS_TRANSFORMS_ANIMATIONS_UNPREFIXED is not used anywhere. Remove it.
2726 https://bugs.webkit.org/show_bug.cgi?id=135675
2728 Reviewed by Sam Weinig.
2730 * Scripts/webkitperl/FeatureList.pm:
2732 2014-08-06 David Farler <dfarler@apple.com>
2734 Set DSYMUTIL_NUM_THREADS to the number of logical cores
2735 https://bugs.webkit.org/show_bug.cgi?id=135655
2737 Reviewed by Mark Rowe.
2739 * Scripts/webkitdirs.pm:
2740 (buildXCodeProject): Set before calling xcodebuild.
2742 2014-08-06 Adrian Perez de Castro <aperez@igalia.com>
2744 [GTK] Add support for user scripts to WebKitUserContentManager
2745 https://bugs.webkit.org/show_bug.cgi?id=134738
2747 Reviewed by Carlos Garcia Campos.
2749 Add support for user scripts, to complement the user style sheet
2750 support already present in WebKitUserContentManager. Most of the
2751 moving parts are already present, so this just adds a boxed type
2752 for user scripts (WebKitUserScript) and the corresponding methods
2753 to add and remove scripts from the WebKitUserContentManager.
2755 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
2756 Add test case for injected user scripts.
2757 (isScriptInjectedForURLAtPath):
2758 (removeOldInjectedContentAndResetLists):
2759 (testUserContentManagerInjectedStyleSheet):
2760 (testUserContentManagerInjectedScript):
2762 (removeOldInjectedStyleSheetsAndResetLists): Deleted.
2764 2014-08-06 Philippe Normand <pnormand@igalia.com>
2766 [GTK] run-launcher --gtk still fails
2767 https://bugs.webkit.org/show_bug.cgi?id=135642
2769 Reviewed by Carlos Garcia Campos.
2771 The perl interpreter is confused by the combination of string
2772 concatenation and a ternary in the same line. Using a separate
2773 variable to determine the library file extension fixes this issue.
2775 * Scripts/webkitdirs.pm:
2776 (builtDylibPathForName): Use an intermediate variable, it's more
2777 readable and unambiguous.
2779 2014-07-29 Filip Pizlo <fpizlo@apple.com>
2781 Merge r170564, r170571, r170604, r170628, r170672, r170680, r170724, r170728, r170729, r170819, r170821, r170836, r170855, r170860, r170890, r170907, r170929, r171052, r171106, r171152, r171153, r171214 from ftlopt.
2783 2014-06-25 Filip Pizlo <fpizlo@apple.com>
2785 [ftlopt] If a CodeBlock is jettisoned due to a watchpoint then it should be possible to figure out something about that watchpoint
2786 https://bugs.webkit.org/show_bug.cgi?id=134333
2788 Reviewed by Geoffrey Garen.
2790 * Scripts/display-profiler-output:
2792 2014-08-05 David Farler <dfarler@apple.com>
2794 [iOS] Run ImageDiff in the sim bootstrap
2795 https://bugs.webkit.org/show_bug.cgi?id=135624
2797 Reviewed by David Kilzer.
2799 * Scripts/webkitpy/port/image_diff.py:
2801 (IOSSimulatorImageDiffer):
2802 (IOSSimulatorImageDiffer._start):
2803 * Scripts/webkitpy/port/ios.py:
2804 (IOSSimulatorPort.diff_image):
2806 2014-08-05 David Farler <dfarler@apple.com>
2808 [iOS] run-webkit-tests: defaults for --runtime and --device-type flags
2809 https://bugs.webkit.org/show_bug.cgi?id=135441
2811 Reviewed by Tim Horton.
2813 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2815 (_set_up_derived_options):
2816 If using the ios-simulator platform and runtime or device-type
2817 aren't defined, get the latest runtime from the active Xcode.app
2818 and pick a default device type based on the desired architecture:
2819 iPhone 5 for i386 and iPhone 5s for x86_64.
2820 * Scripts/webkitpy/xcode/__init__.py: Added.
2821 * Scripts/webkitpy/xcode/simulator.py: Added.
2823 2014-08-05 David Farler <dfarler@apple.com>
2825 [iOS] simctl can hang if run quickly after shutting down CoreSimulator services
2826 https://bugs.webkit.org/show_bug.cgi?id=135626
2828 Reviewed by Dan Bernstein.
2830 * Scripts/webkitpy/port/ios.py:
2831 (IOSSimulatorPort.setup_test_run):
2832 Remove call to simctl shutdown <device> - telling the simulator app to quit
2833 will shut down all booted devices.
2835 2014-08-05 Alexey Proskuryakov <ap@apple.com>
2837 Remove an unused argument from BuildbotQueue.update()
2838 https://bugs.webkit.org/show_bug.cgi?id=135623
2840 Reviewed by Timothy Hatcher.
2842 Also remaned a constant to better match what it means.
2844 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2846 2014-08-05 Vivek Galatage <vivek.vg@samsung.com>
2848 [gtk] Include llvm-dev(el) package to satisfy mesa build configuration
2849 https://bugs.webkit.org/show_bug.cgi?id=135555
2851 Reviewed by Philippe Normand.
2853 Initial setup of gtk on linux requires this package to be installed.
2854 This is required during the build configuration of mesa through jhbuild.
2856 * gtk/install-dependencies:
2858 2014-08-05 Eva Balazsfalvi <evab.u-szeged@partner.samsung.com>
2860 Fix the commit-log-editor after r167243 and add more unit tests
2861 https://bugs.webkit.org/show_bug.cgi?id=131727
2863 Reviewed by Csaba Osztrogonác.
2865 * Scripts/commit-log-editor:
2866 (createCommitMessage):
2867 (removeLongestCommonPrefixEndingInNewline):
2868 * Scripts/webkitpy/common/checkout/checkout_unittest.py:
2869 (CommitMessageForThisCommitTest):
2870 (CommitMessageForThisCommitTest.mock_changelog):
2871 (CommitMessageForThisCommitTest.mock_checkout_for_test):
2872 (CommitMessageForThisCommitTest.test_commit_message_for_unreviewed_changelogs_with_different_messages):
2873 (test_commit_message_for_one_reviewed_changelog):
2874 (test_commit_message_for_changelogs_with_same_messages):
2875 (test_commit_message_for_changelogs_with_different_messages):
2876 (test_commit_message_for_one_rollout_changelog):
2877 (test_commit_message_for_rollout_changelogs_with_different_directories):
2879 (test_commit_message_for_this_commit): Deleted.
2881 2014-08-04 Michael Catanzaro <mcatanzaro@igalia.com>
2883 [GTK] run-launcher --gtk is broken
2884 https://bugs.webkit.org/show_bug.cgi?id=135571
2886 Reviewed by Martin Robinson.
2888 * Scripts/webkitdirs.pm:
2889 (builtDylibPathForName): Search for libwebkit2gtk-4.0
2891 2014-08-04 Matt Baker <mattbaker@apple.com>
2893 lldb_webkit.py throws exception when generating summary of null StringImpl
2894 https://bugs.webkit.org/show_bug.cgi?id=129448
2896 Reviewed by Jer Noble.
2898 Added checks for null StringImpl and 0 byte ReadMemory calls.
2900 * lldb/lldb_webkit.py:
2901 (WTFStringImpl_SummaryProvider):
2902 (ustring_to_string):
2903 (lstring_to_string):
2904 (WTFStringImplProvider.to_string):
2905 (WTFStringImplProvider.is_initialized):
2907 2014-08-03 Carlos Garcia Campos <cgarcia@igalia.com>
2909 [GTK] Do not include JavaScriptCore stress tests in release tarballs
2910 https://bugs.webkit.org/show_bug.cgi?id=135503
2912 Reviewed by Martin Robinson.
2914 * gtk/manifest.txt: Exclude Source/JavaScriptCore/tests dir.
2916 2014-07-30 David Farler <dfarler@apple.com>
2918 build-webkittestrunner doesn't build the app target for iOS SDKs
2919 https://bugs.webkit.org/show_bug.cgi?id=135433
2921 Reviewed by Dan Bernstein.
2923 * Scripts/build-dumprendertree: Build the app target on iOS.
2924 * Scripts/build-webkittestrunner: Build the app target on iOS.
2925 * Scripts/webkitdirs.pm: Add -sdk flags when building for iOS.
2926 (buildXCodeProject):
2927 * Scripts/webkitpy/port/ios.py: Use --sdk flags instead of SDKROOT.
2928 (IOSSimulatorPort._build_driver_flags):
2930 2014-07-30 David Farler <dfarler@apple.com>
2932 Remove iOS Perl DumpRenderTree support target
2933 https://bugs.webkit.org/show_bug.cgi?id=135271
2935 Reviewed by Dan Bernstein.
2937 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Remove the target.
2938 * DumpRenderTree/ios/PerlSupport/DumpRenderTreeSupport.c: Removed.
2939 * DumpRenderTree/ios/PerlSupport/DumpRenderTreeSupportPregenerated.pm: Removed.
2940 * DumpRenderTree/ios/PerlSupport/DumpRenderTreeSupport_wrapPregenerated.c: Removed.
2941 * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/Changes: Removed.
2942 * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/IPhoneSimulatorNotification.xs: Removed.
2943 * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/MANIFEST: Removed.
2944 * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/Makefile.PL: Removed.
2945 * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/README: Removed.
2946 * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/lib/IPhoneSimulatorNotification.pm: Removed.
2947 * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/ppport.h: Removed.
2948 * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/t/IPhoneSimulatorNotification.t: Removed.
2949 * DumpRenderTree/ios/PerlSupport/Makefile: Removed.
2951 2014-07-30 David Farler <dfarler@apple.com>
2953 Remove old-run-webkit-tests
2954 https://bugs.webkit.org/show_bug.cgi?id=135374
2956 Reviewed by Csaba Osztrogonác.
2958 * Scripts/old-run-webkit-tests: Removed.
2960 2014-08-02 Dan Bernstein <mitz@apple.com>
2962 prepare-ChangeLog --no-write shouldn’t require ChangeLog to exist
2963 https://bugs.webkit.org/show_bug.cgi?id=135542
2965 Reviewed by Tim Horton.
2967 * Scripts/prepare-ChangeLog:
2968 (main): Pass $writeChangeLogs for the new requireChangeLogToExist parameter of
2970 (findChangeLogs): Don’t require a ChangeLog file to exist if unless the
2971 requireChangeLogToExist argument is true.
2973 2014-08-01 Dan Bernstein <mitz@apple.com>
2975 commit-log-editor uses a non-standard message format when git index contains no ChangeLog changes
2976 https://bugs.webkit.org/show_bug.cgi?id=135527
2978 Reviewed by Tim Horton.
2980 * Scripts/commit-log-editor:
2981 In the case of a git repository when there are no changed ChangeLog files, changed to pass
2982 the --delimiters option to prepare-ChangeLog, then process each entry in the output using
2983 commitMessageFromChangeLogEntry.
2984 (commitMessageFromChangeLogEntry): Factored out from createCommitMessage.
2985 (sortKey): Factored out from createCommitMessage.
2986 (createCommitMessage): Changed to use new sortKey and commitMessageFromChangeLogEntry
2989 * Scripts/prepare-ChangeLog:
2990 (main): Parse new --delimiters option.
2991 (generateNewChangeLogs): When --no-write and --delimiters are both specified, always print
2992 the label before each change log entry, and a "~" delimiter on a new line after each entry.
2994 2014-08-01 Bear Travis <betravis@adobe.com>
2996 [Feature Queries] Enable Feature Queries on EFL/GTK
2997 https://bugs.webkit.org/show_bug.cgi?id=134902
2999 Reviewed by Benjamin Poulain.
3001 Turn the feature on by default for the build script.
3003 * Scripts/webkitperl/FeatureList.pm:
3005 2014-08-01 Timothy Horton <timothy_horton@apple.com>
3007 Build fix for 32-bit after r171926.
3009 * MiniBrowser/mac/SettingsController.h:
3010 * MiniBrowser/mac/SettingsController.m:
3012 2014-08-01 Tim Horton <timothy_horton@apple.com>
3014 Confusing build fix after r171926.
3016 * MiniBrowser/mac/AppDelegate.h:
3017 * MiniBrowser/mac/AppDelegate.m:
3018 * MiniBrowser/mac/SettingsController.m:
3020 2014-08-01 Tim Horton <timothy_horton@apple.com>
3022 Make it easer to add switches to MiniBrowser
3023 https://bugs.webkit.org/show_bug.cgi?id=135499
3025 Reviewed by Simon Fraser.
3027 Add a single class to manage a set of persistent, global settings for MiniBrowser.
3028 Add a new menu that contains items to toggle the aforementioned settings (moving them out of the Debug menu).
3030 * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
3031 Add SettingsController.{m, h}.
3033 * MiniBrowser/mac/AppDelegate.h:
3034 Move _browserWindowControllers to the implementation.
3035 Get rid of toggleUseWebKit2ByDefault, because SettingsController now takes care
3036 of that; instead, we'll receive didChangeSettings.
3038 * MiniBrowser/mac/AppDelegate.m:
3039 Move the default URL, default URL preference key, and use-WebKit2-by-default
3040 preference key into SettingsController.
3042 (-[BrowserAppDelegate awakeFromNib]):
3043 Add the dynamically-generated SettingsController menu just to the left of the Debug menu.
3045 (-[BrowserAppDelegate newWindow:]):
3046 Ask SettingsController if we should use WebKit2 by default, and what the initial URL to load is.
3048 (-[BrowserAppDelegate applicationDidFinishLaunching:]):
3049 SettingsController now takes care of reading the default URL preference.
3050 WK1BrowserWindowController now takes care of enabling the developer extras, via WebPreferences.
3052 (-[BrowserAppDelegate didChangeSettings]):
3053 When settings change, update the key equivalents for the new-window menu items, as they
3054 might have changed (as use-WebKit2-by-default is one of the settings).
3056 Dispatch settings change notifications to all live BrowserControllers.
3058 (-[BrowserAppDelegate _updateNewWindowKeyEquivalents]):
3059 (-[BrowserAppDelegate toggleUseWebKit2ByDefault:]): Deleted.
3060 (-[BrowserAppDelegate _useWebKit2ByDefault]): Deleted.
3061 (-[BrowserAppDelegate validateMenuItem:]): Deleted.
3062 All menu item validation for settings is moved into SettingsController.
3064 * MiniBrowser/mac/BrowserWindowController.h:
3065 Simplify the BrowserWindowController interface; "toggling" settings will happen inside SettingsController,
3066 the BrowserWindowController subclasses will be able to a) know when any setting changes, b) query the current setting state.
3068 * MiniBrowser/mac/MainMenu.xib:
3069 Remove the settings menu items from the "Debug" menu.
3071 * MiniBrowser/mac/SettingsController.h: Added.
3072 * MiniBrowser/mac/SettingsController.m: Added.
3073 (+[SettingsController shared]):
3074 (-[SettingsController menu]):
3076 (-[SettingsController _addItemWithTitle:action:indented:]):
3077 (-[SettingsController _addHeaderWithTitle:]):
3078 NSMenuItem-creating helpers.
3080 (-[SettingsController _populateMenu]):
3081 Build the menu. Ideally this and the validation step would eventually be made more dynamic.
3083 (-[SettingsController validateMenuItem:]):
3084 Validate menu items; since they can be used to toggle the default state of a setting,
3085 we'll always return YES. However, we will use this opportunity to set the 'checked' state
3089 (-[SettingsController _toggleBooleanDefault:]):
3090 Toggle the given boolean default, and notify BrowserAppDelegate that something changed.
3092 (-[SettingsController toggleUseWebKit2ByDefault:]):
3093 (-[SettingsController useWebKit2ByDefault]):
3094 (-[SettingsController toggleUseTransparentWindows:]):
3095 (-[SettingsController useTransparentWindows]):
3096 (-[SettingsController toggleUsePaginatedMode:]):
3097 (-[SettingsController usePaginatedMode]):
3098 (-[SettingsController toggleUseUISideCompositing:]):
3099 (-[SettingsController useUISideCompositing]):
3100 (-[SettingsController toggleShowLayerBorders:]):
3101 (-[SettingsController layerBordersVisible]):
3102 (-[SettingsController toggleShowTiledScrollingIndicator:]):
3103 (-[SettingsController tiledScrollingIndicatorVisible]):
3104 (-[SettingsController toggleEnableSubPixelCSSOMMetrics:]):
3105 (-[SettingsController subPixelCSSOMMetricsEnabled]):
3106 (-[SettingsController defaultURL]):
3107 Toggle or return the current state of each preference.
3109 * MiniBrowser/mac/WK1BrowserWindowController.m:
3110 (-[WK1BrowserWindowController awakeFromNib]):
3111 (-[WK1BrowserWindowController validateMenuItem:]):
3112 (-[WK1BrowserWindowController windowWillClose:]):
3113 (-[WK1BrowserWindowController find:]):
3114 (-[WK1BrowserWindowController dumpSourceToConsole:]):
3115 (-[WK1BrowserWindowController didChangeSettings]):
3116 (-[WK1BrowserWindowController webView:didReceiveTitle:forFrame:]):
3117 (-[WK1BrowserWindowController isPaginated]): Deleted.
3118 (-[WK1BrowserWindowController togglePaginationMode:]): Deleted.
3119 (-[WK1BrowserWindowController toggleTransparentWindow:]): Deleted.
3120 (-[WK1BrowserWindowController isSubpixelCSSOMElementMetricsEnabled]): Deleted.
3121 (-[WK1BrowserWindowController toggleSubpixelCSSOMElementMetricsEnabled:]): Deleted.
3122 (-[WK1BrowserWindowController layerBordersVisible]): Deleted.
3123 (-[WK1BrowserWindowController toggleLayerBordersVisibility:]): Deleted.
3124 * MiniBrowser/mac/WK2BrowserWindowController.m:
3125 (-[WK2BrowserWindowController awakeFromNib]):
3126 (-[WK2BrowserWindowController validateMenuItem:]):
3127 (-[WK2BrowserWindowController forceRepaint:]):
3128 (-[WK2BrowserWindowController windowWillClose:]):
3129 (-[WK2BrowserWindowController didChangeSettings]):
3130 (-[WK2BrowserWindowController isPaginated]): Deleted.
3131 (-[WK2BrowserWindowController togglePaginationMode:]): Deleted.
3132 (-[WK2BrowserWindowController toggleTransparentWindow:]): Deleted.
3133 (-[WK2BrowserWindowController isUISideCompositingEnabled]): Deleted.
3134 (-[WK2BrowserWindowController toggleUISideCompositing:]): Deleted.
3135 (-[WK2BrowserWindowController layerBordersVisible]): Deleted.
3136 (-[WK2BrowserWindowController toggleLayerBordersVisibility:]): Deleted.
3137 (-[WK2BrowserWindowController tiledScrollingIndicatorVisible]): Deleted.
3138 (-[WK2BrowserWindowController toggleTiledScrollingIndicatorVisibility:]): Deleted.
3140 2014-08-01 Tim Horton <timothy_horton@apple.com>
3142 MiniBrowser doesn't support data URLs
3143 https://bugs.webkit.org/show_bug.cgi?id=135492
3145 Reviewed by Simon Fraser.
3147 * MiniBrowser/mac/BrowserWindowController.m:
3148 (-[BrowserWindowController addProtocolIfNecessary:]):
3149 Don't add http:// to data: URLs.
3151 * MiniBrowser/mac/WK2BrowserWindowController.m:
3152 (-[WK2BrowserWindowController fetch:]):
3153 (-[WK2BrowserWindowController updateTextFieldFromURL:]):
3154 Percent-escape the contents of the address field before trying to make a URL.
3155 Percent-unescape the URL when displaying it in the address field.
3156 This is not great, but trivial and good-enough-for-Minibrowser.
3158 2014-07-31 Ryuan Choi <ryuan.choi@samsung.com>
3160 [EFL][WK2] MiniBrower comes to crash when combo box is pressed
3161 https://bugs.webkit.org/show_bug.cgi?id=135378
3163 Reviewed by Gyuyoung Kim.
3165 "clicked" signal of elm_menu is emitted after EwkView calls popup_menu_hide
3166 and removes Ewk_Popup_Menu instance.
3168 * MiniBrowser/efl/main.c:
3169 (on_popup_menu_show):
3170 (on_popup_menu_discarded): Deleted.
3172 2014-07-31 Brent Fulgham <bfulgham@apple.com>
3174 [Win] Use RC_PROJECTBUILDVERSION as build portion of version
3175 https://bugs.webkit.org/show_bug.cgi?id=135478
3177 Reviewed by David Kilzer.
3179 Add new test suite for the version-stamp program.
3181 * Scripts/webkitperl/auto-version_unittest/versionStampTests.pl: Added.
3183 2014-07-31 Dan Bernstein <mitz@apple.com>
3185 Reverted r171893, because it broke http/tests/appcache/different-https-origin-resource-main.html,
3186 which loads HTTPS content without calling the delegate.
3188 Rubber-stamped by Alexey Proskuryakov.
3190 * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
3191 (WTR::InjectedBundle::platformInitialize):
3192 * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3193 (WTR::InjectedBundle::platformInitialize):
3195 2014-07-31 Brent Fulgham <bfulgham@apple.com>
3197 Unreviewed typo correction (and build fix).
3199 * MiniBrowser/mac/WK2BrowserWindowController.m:
3200 (-[WK2BrowserWindowController awakeFromNib]): Use correct
3201 property name (_fullScreenIsEnabled -> _fullScreenEnabled)
3203 2014-07-31 Brent Fulgham <bfulgham@apple.com>
3205 MiniBrowser Should Support Fullscreen Videos in WebKit2 Mode
3206 https://bugs.webkit.org/show_bug.cgi?id=135482
3208 Reviewed by Simon Fraser.
3210 * MiniBrowser/mac/WK2BrowserWindowController.m:
3211 (-[WK2BrowserWindowController awakeFromNib]): Activate the Fullscreen
3214 2014-07-31 Alexey Proskuryakov <ap@apple.com>
3216 [Mac, iOS] Remove -setAllowsAnyHTTPSCertificate calls
3217 https://bugs.webkit.org/show_bug.cgi?id=135472
3219 Reviewed by Dan Bernstein.
3221 We now handle server trust challenges, and don't need such hacks.
3223 * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
3224 (WTR::InjectedBundle::platformInitialize):
3225 * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3226 (WTR::InjectedBundle::platformInitialize):
3228 2014-07-31 Alexey Proskuryakov <ap@apple.com>
3230 media/track/add-and-remove-track.html and media/media-fragments/TC0001.html are flaky
3231 on Mac WK2 EWS, asserting under TestRunner::removeAllWebNotificationPermissions
3232 https://bugs.webkit.org/show_bug.cgi?id=135418
3234 Reviewed by Anders Carlsson.
3236 This was only happening in shared web process mode, because WKBundlePostMessage
3237 has different behavior then. When there is no process, the message is dropped on
3238 the floor in multiple process mode, but it's stored to be delivered after launch
3239 in shared process mode.
3241 So, calling resetStateToConsistentValues() resulted in storing a Reset bundle message
3242 that was delivered immediately after launch, when there was nothing to reset.
3244 We don't actually need to reset anything at this point, as the previous call has
3245 already reset everything UI process side, and web process is brand new. All we need
3246 is to reattach the page to a process, as invoke() expects one to exist.
3248 * WebKitTestRunner/TestController.cpp: (WTR::TestController::reattachPageToWebProcess):
3249 * WebKitTestRunner/TestController.h:
3250 * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::invoke):
3252 2014-07-31 Dan Bernstein <mitz@apple.com>
3254 [WK2] Regression tests can't load HTTPS pages with NetworkProcess due to self-signed certificate
3255 https://bugs.webkit.org/show_bug.cgi?id=115282
3257 Reviewed by Sam Weinig.
3259 * WebKitTestRunner/TestController.cpp:
3260 (WTR::TestController::canAuthenticateAgainstProtectionSpaceInFrame): Return true for any
3261 local host server trust protection space.
3262 (WTR::TestController::didReceiveAuthenticationChallengeInFrame): Respond with a non-empty
3263 credential to server trust challenges.
3265 2014-07-31 Tibor Meszaros <tmeszaros.u-szeged@partner.samsung.com>
3267 [webkitpy] Make diff_text generate correct diff if there is no newline at the end of file
3268 https://bugs.webkit.org/show_bug.cgi?id=135381
3270 Reviewed by Csaba Osztrogonác.
3272 * Scripts/webkitpy/port/base.py:
3274 * Scripts/webkitpy/port/base_unittest.py:
3275 (PortTest.test_diff_text):
3277 2014-07-31 Carlos Garcia Campos <cgarcia@igalia.com>
3279 Unreviewed. Fix GTK+ make distcheck.
3282 (ensure_version_if_possible): Use 4.0 instead of 3.0 as binary
3283 version to find the pkg-config file.
3284 * gtk/manifest.txt: Add missing resource to the tarball.
3286 2014-07-31 Carlos Garcia Campos <cgarcia@igalia.com>
3288 [GTK] make distcheck is building from sources dir instead of dist dir
3289 https://bugs.webkit.org/show_bug.cgi?id=135457
3291 Reviewed by Philippe Normand.
3294 (Distcheck.configure): Use dist_dir as source dir.
3295 (Distcheck.check): Pass dist_dir to configure().
3297 2014-07-31 Carlos Garcia Campos <cgarcia@igalia.com>
3299 [GTK] Do not include files that are not in git in the tarball
3300 https://bugs.webkit.org/show_bug.cgi?id=134804
3302 Reviewed by Philippe Normand.
3304 Skip all files in the source tree that are not under version control
3305 except for files added from the build dir like the documentation.
3308 (Directory.__init__): Initialize the list of files under control version.
3309 (Directory.list_cms_files): Helper function to list all files
3310 under the control version for the current source root.
3311 (Directory.should_skip_file): Return True for files that are not
3312 under control version only when the source root is also under
3314 (Directory.get_files): Filter the files also using should_skip_file().
3316 2014-07-29 David Farler <dfarler@apple.com>
3318 iOS Simulator LayoutTestRelay
3319 https://bugs.webkit.org/show_bug.cgi?id=135269
3321 Reviewed by David Kilzer.
3323 * LayoutTestRelay/Configurations/Base.xcconfig: Added.
3324 * LayoutTestRelay/Configurations/DebugRelease.xcconfig: Added.
3325 * LayoutTestRelay/LayoutTestRelay.xcodeproj/project.pbxproj: Added.
3326 * LayoutTestRelay/LayoutTestRelay/LTPipeRelay.h: Added.
3327 * LayoutTestRelay/LayoutTestRelay/LTPipeRelay.m: Added.
3328 (-[LTPipeRelay inPipePath]):
3329 (-[LTPipeRelay outPipePath]):
3330 (-[LTPipeRelay errorPipePath]):
3331 (-[LTPipeRelay outputStream]):
3332 (-[LTPipeRelay initWithPrefix:]):
3333 (-[LTPipeRelay setup]):
3334 (-[LTPipeRelay tearDown]):
3335 (-[LTPipeRelay connect]):
3336 (-[LTPipeRelay disconnect]):
3337 (-[LTPipeRelay createFIFOs]):
3338 (-[LTPipeRelay destroyFIFOs]):
3339 (-[LTPipeRelay relayStream:]):
3340 (-[LTPipeRelay stream:handleEvent:]):
3341 * LayoutTestRelay/LayoutTestRelay/LTRelay.h: Added.
3342 * LayoutTestRelay/LayoutTestRelay/LTRelayController.h: Added.
3343 * LayoutTestRelay/LayoutTestRelay/LTRelayController.m: Added.
3344 (-[LTRelayController uniqueAppPath]):
3345 (-[LTRelayController uniqueAppURL]):
3346 (-[LTRelayController uniqueAppIdentifier]):
3347 (-[LTRelayController processName]):
3348 (-[LTRelayController initWithDevice:productDir:appPath:identifierSuffix:dumpToolArguments:]):
3349 (-[LTRelayController readFileHandle:]):
3350 (-[LTRelayController receivedStandardOutputData:]):
3351 (-[LTRelayController receivedStandardErrorData:]):
3352 (-[LTRelayController disconnected]):
3353 (-[LTRelayController connected]):
3354 (-[LTRelayController crashWithMessage:]):
3355 (-[LTRelayController launchSimulator]):
3356 (-[LTRelayController bootDevice]):
3357 (-[LTRelayController createUniqueApp]):
3358 (-[LTRelayController killApp]):
3359 (-[LTRelayController launchApp]):
3360 (-[LTRelayController start]):
3361 * LayoutTestRelay/LayoutTestRelay/main.m: Added.
3363 (getTestingSimDevice):
3364 (getRequiredStringArgument):
3365 (getRemainderArguments):
3367 * LayoutTestRelay/Makefile: Added.
3368 * Tools/Scripts/build-layouttestrelay: Added.
3370 2014-07-29 Brent Fulgham <bfulgham@apple.com>
3372 [Win] Modify version numbering scheme to support 5-tuple versions
3373 https://bugs.webkit.org/show_bug.cgi?id=135400
3374 <rdar://problem/17849033>
3376 Reviewed by David Kilzer.
3378 Update test cases to recognize that we can only support Major
3379 values from 0-65535, Minor values from 0-64, Tiny values from 0-999,
3380 Micro values from 0-64, and Nano values from 0-999.
3382 * Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl: Update
3383 test expectations for physical limits.
3385 2014-07-30 Carlos Garcia Campos <cgarcia@igalia.com>
3387 [GTK] GLib tests fail with recent GTK+ due to runtime warning about deprecated properties
3388 https://bugs.webkit.org/show_bug.cgi?id=135411
3390 Reviewed by Sergio Villar Senin.
3392 Recent versions of GTK+ now warn at runtime when a deprecated
3393 property or signal is used. A diagnostic mode was added that is
3394 enabled by default, but that can be disabled by setting
3395 G_ENABLE_DIAGNOSTIC=0. Runtime warnings are considered test
3396 failures by gtester, so we need to run the tests with the
3397 diganostic mode disabled.
3399 * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.cpp:
3402 2014-07-29 Carlos Garcia Campos <cgarcia@igalia.com>
3404 [GTK] Remove WebKitCertificateInfo from WebKit2GTK+ API
3405 https://bugs.webkit.org/show_bug.cgi?id=134830
3407 Reviewed by Gustavo Noronha Silva.
3409 Update the SSL test for the API changes.
3411 * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
3412 (testLoadFailedWithTLSErrors):
3414 2014-07-24 David Farler <dfarler@apple.com>
3416 Add knowledge of the iOS Simulator to webkitpy
3417 http://bugs.webkit.org/show_bug.cgi?id=133963
3419 Reviewed by Simon Fraser.
3421 * Scripts/webkitdirs.pm:
3422 (argumentsForConfiguration): Add --ios-sim*
3423 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3424 --runtime and --device-type args added.
3425 * Scripts/webkitpy/port/base.py:
3426 * Scripts/webkitpy/port/driver.py: Add simulator driver.
3427 (IOSSimulatorDriver): Added.
3428 * Scripts/webkitpy/port/factory.py: Add simulator platform.
3429 * Scripts/webkitpy/port/ios.py: Added.
3431 2014-07-29 Alexey Proskuryakov <ap@apple.com>
3433 fast/borders/border-radius-on-subpixel-position-non-hidpi.html fails on Retina machines
3434 https://bugs.webkit.org/show_bug.cgi?id=135398
3436 Reviewed by Zalan Bujtas.
3438 * WebKitTestRunner/TestController.cpp: (WTR::TestController::updateWindowScaleForTest):
3439 "hidpi-" should be at the start. This allows "hidpi-" in both file and directory names.
3441 * DumpRenderTree/mac/DumpRenderTree.mm: (changeWindowScaleIfNeeded): Same fix.
3442 For some reason, I wasn't seeing this test fail on WK1 even without the fix, not
3445 2014-07-29 Alexey Proskuryakov <ap@apple.com>
3447 PPT: run-webkit-tests doesn't upload crash logs to bots
3448 https://bugs.webkit.org/show_bug.cgi?id=135391
3450 Reviewed by Joseph Pecoraro.
3452 * WebKitTestRunner/TestController.cpp: (WTR::TestController::processDidCrash):
3453 Not a fix to be proud of, but better than not having it work at all.
3455 2014-07-29 Adrian Perez de Castro <aperez@igalia.com>
3457 [GTK] Remove WebKitWebViewGroup from WebKit2 GTK+ API
3458 https://bugs.webkit.org/show_bug.cgi?id=133729
3460 Reviewed by Carlos Garcia Campos.
3462 Removes WebKitWebViewGroup, effectively reverting the changes
3463 introduced by r149117. The motivation for WebKitWebViewGroup
3464 was using the user style sheet injection API, which has been
3465 moved into WebKitUserContentManager, rendering it unneeded.
3467 * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Remove tests
3468 for WebKitWebViewGroup.
3469 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
3470 (testWebViewSettings):
3471 Restore the assertions that check that settings objects are
3472 released. Add test for webkit_web_view_new_with_settings().
3473 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebViewGroup.cpp: Removed.
3475 2014-07-29 Carlos Garcia Campos <cgarcia@igalia.com>
3477 Implement webkit_web_view_load_string() in WebKit2
3478 https://bugs.webkit.org/show_bug.cgi?id=134735
3480 Reviewed by Sergio Villar Senin.
3482 Add /webkit2/WebKitWebView/load-bytes test case and simplify
3483 TestDOMXPathNSResolver by using webkit_web_view_load_bytes()
3484 instead of a soup server just to sent the Content-type header.
3486 * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMXPathNSResolver.cpp:
3487 (testWebKitDOMXPathNSResolverNative):
3488 (testWebKitDOMXPathNSResolverCustom):
3491 (serverCallback): Deleted.
3492 * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
3495 * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
3496 (LoadTrackingTest::loadBytes):
3497 * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h:
3498 * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
3499 (WebViewTest::loadBytes):
3500 * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
3502 2014-07-28 Daniel Bates <dabates@apple.com>
3504 Add support for running the Clang static analyzer when building WebKit and JSC
3505 https://bugs.webkit.org/show_bug.cgi?id=134955
3507 Reviewed by Brent Fulgham.
3509 * Scripts/build-jsc: Added command line options -[no]-analyze (disabled by default).
3510 * Scripts/build-webkit: Add --analyze command line option to build-webkit to enable
3511 running the Clang static analyzer.
3512 * Scripts/webkitdirs.pm:
3513 (XcodeStaticAnalyzerOption): Added.
3515 2014-07-24 David Farler <dfarler@apple.com>
3517 Allow for multiple DumpRenderTree and WebKitTestRunner instances in the iOS Simulator
3518 https://bugs.webkit.org/show_bug.cgi?id=135272
3520 Reviewed by Simon Fraser.
3522 * DumpRenderTree/mac/DumpRenderTree.mm:
3523 (dumpRenderTree): Remove hard-coding of FIFO paths.
3524 (-[DumpRenderTree applicationDidEnterBackground:]): Create background task.
3525 (DumpRenderTreeMain): Set DumpRenderTree as UIApplication delegate.
3526 * DumpRenderTree/mac/DumpRenderTreeMac.h: bgTask ivar.
3527 * Scripts/old-run-webkit-tests: Update FIFO paths for ORWT.
3528 * WebKitTestRunner/TestController.cpp: Remove hard-coding of FIFO paths.
3529 * WebKitTestRunner/ios/TestControllerIOS.mm: Move dup2 calls to platformInitialize
3530 * WebKitTestRunner/ios/mainIOS.mm: bgTask ivar.
3531 (-[WebKitTestRunnerApp applicationDidEnterBackground:]): Create background task.
3532 (main): Set WebKitTestRunnerApp as UIApplication delegate.
3534 2014-07-24 David Farler <dfarler@apple.com>
3536 ImageDiff builds for the simulator when running iOS layout tests
3537 https://bugs.webkit.org/show_bug.cgi?id=135270
3539 Reviewed by Simon Fraser.
3541 * Scripts/build-imagediff: Added.
3543 2014-07-28 Renato Nagy <nagy.renato@stud.u-szeged.hu>
3545 Followup fix after r171594
3546 https://bugs.webkit.org/show_bug.cgi?id=135048
3548 Reviewed by Csaba Osztrogonác.
3550 * Scripts/sort-export-file: Removed extra newlines from help.
3552 2014-07-25 Anders Carlsson <andersca@apple.com>
3554 WKNavigation's properties are either always nil or don't behave as documented
3555 https://bugs.webkit.org/show_bug.cgi?id=135267
3556 <rdar://problem/17730536>
3558 Reviewed by Andreas Kling.
3560 * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
3561 (-[NavigationDelegate webView:didStartProvisionalNavigation:]):
3563 (-[DidFailProvisionalNavigationDelegate webView:didStartProvisionalNavigation:]):
3564 (-[DidFailProvisionalNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
3566 2014-07-25 Michael Catanzaro <mcatanzaro@igalia.com>
3568 [GTK] install-dependencies needs to install perl-CGI on Fedora
3569 https://bugs.webkit.org/show_bug.cgi?id=135302
3571 Reviewed by Martin Robinson.
3573 * gtk/install-dependencies:
3574 Add perl-CGI to yum dependencies needed for tests
3576 2014-07-25 Renato Nagy <nagy.renato@stud.u-szeged.hu>
3578 Add --dry-run option to sort-export-file
3579 https://bugs.webkit.org/show_bug.cgi?id=135048
3581 Reviewed by Csaba Osztrogonác.
3583 Added --dry-run option to sort-export-file. Running the script with --dry-run
3584 option does not sort the export files but creates a list of the files that
3587 * Scripts/sort-export-file:
3590 2014-07-24 Michael Catanzaro <mcatanzaro@igalia.com>
3592 GTK jhbuild modules needs to build xserver with --disable-local-transport
3593 https://bugs.webkit.org/show_bug.cgi?id=135262
3595 Reviewed by Martin Robinson.
3597 * gtk/jhbuild.modules:
3598 Build X server with --disable-local-transport, since local transport
3599 is only supported on Solaris, SCO, and System V. Fixes build on
3602 2014-07-24 Michael Catanzaro <mcatanzaro@igalia.com>
3604 [GTK] build-webkit script fails under jhbuild if ACLOCAL_FLAGS is unset
3605 https://bugs.webkit.org/show_bug.cgi?id=135065
3607 Reviewed by Martin Robinson.
3609 * jhbuild/jhbuild-wrapper:
3610 (ensure_jhbuild): do not assume jhbuild sets ACLOCAL_FLAGS
3612 2014-07-23 Joseph Pecoraro <pecoraro@apple.com>
3614 Unreviewed iOS build fix after r171355.
3616 * TestWebKitAPI/Configurations/Base.xcconfig:
3617 Since all the Tests/WebKit2Cocoa tests are already explicitly skipped on iOS,
3618 simplify to skipping all the tests in the directory. PlatformUtilities are not
3619 building on iOS, which means we are missing necessary Util functions.
3621 2014-07-23 Michał Pakuła vel Rutka <m.pakula@samsung.com>
3623 [EFL] Fix build after r171454
3624 https://bugs.webkit.org/show_bug.cgi?id=135191
3626 Reviewed by Csaba Osztrogonác.
3628 * MiniBrowser/efl/CMakeLists.txt: Add path to new EWebKit2.h location .
3630 2014-07-23 Ryuan Choi <ryuan.choi@samsung.com>
3632 [EFL] Do not generate forwarding header for ewk headers
3633 https://bugs.webkit.org/show_bug.cgi?id=135147
3635 Reviewed by Gyuyoung Kim.
3637 * WebKitTestRunner/EventSenderProxy.h:
3639 2014-07-21 Sam Weinig <sam@webkit.org>
3641 [Cocoa] WKScriptMessageHandlers don't seem to function properly after navigating
3642 https://bugs.webkit.org/show_bug.cgi?id=135148
3644 Reviewed by Geoffrey Garen.
3646 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3647 * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm: Added.
3648 (-[SimpleNavigationDelegate webView:didFinishNavigation:]):
3649 (-[ScriptMessageHandler userContentController:didReceiveScriptMessage:]):
3651 2014-07-22 Brent Fulgham <bfulgham@apple.com>
3653 Correct handling of __VERSION_TEXT__ for 4+-tuple versions
3654 https://bugs.webkit.org/show_bug.cgi?id=135161
3655 <rdar://problem/17763546>
3657 Reviewed by David Kilzer.
3659 * Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl:
3660 Add additional test cases to catch errors in multiple-tuple
3661 version string handling.