Source/WebKit/chromium: Use new type-specific WebGestureEvent fields
[WebKit-https.git] / Tools / ChangeLog
1 2012-09-05  Rick Byers  <rbyers@chromium.org>
2
3         Update chromium DumpRenderTree for new WebGestureEvent fields
4         https://bugs.webkit.org/show_bug.cgi?id=95573
5
6         Reviewed by James Robinson.
7
8         Update EventSender to write gesture details into the appropriate
9         type-specific WebGestureEvent fields.
10         * DumpRenderTree/chromium/TestRunner/EventSender.cpp:
11         (EventSender::gestureEvent):
12         (EventSender::gestureFlingStart):
13
14 2012-09-05  Dirk Pranke  <dpranke@chromium.org>
15
16         NRWT lies about the number of tests that it's skipping when used with --repeat-each
17         https://bugs.webkit.org/show_bug.cgi?id=95789
18
19         Reviewed by Ojan Vafai.
20
21         Fix miscalculation in log message.
22
23         * Scripts/webkitpy/layout_tests/views/printing.py:
24         (Printer.print_found):
25
26 2012-09-05  Kenichi Ishibashi  <bashi@chromium.org>
27
28         Unreviewed, rolling out r127612, r127660, and r127664.
29         http://trac.webkit.org/changeset/127612
30         http://trac.webkit.org/changeset/127660
31         http://trac.webkit.org/changeset/127664
32         https://bugs.webkit.org/show_bug.cgi?id=95920
33
34         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
35         (MockWebRTCPeerConnectionHandler::SuccessCallbackTask::SuccessCallbackTask):
36         (MockWebRTCPeerConnectionHandler::SuccessCallbackTask::runIfValid):
37         (MockWebRTCPeerConnectionHandler::FailureCallbackTask::FailureCallbackTask):
38         (MockWebRTCPeerConnectionHandler::FailureCallbackTask::runIfValid):
39         (MockWebRTCPeerConnectionHandler::createOffer):
40         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
41         (MockWebRTCPeerConnectionHandler):
42         (SuccessCallbackTask):
43         (FailureCallbackTask):
44
45 2012-09-05  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
46
47         Ignore-metrics includes scroll offsets.
48         https://bugs.webkit.org/show_bug.cgi?id=95845
49
50         Reviewed by Dirk Pranke.
51
52         Strip scroll-offsets the same way scroll-height and scroll-width is stripped.
53
54         * Scripts/old-run-webkit-tests:
55         (stripMetrics):
56         * Scripts/webkitpy/layout_tests/port/driver.py:
57         (DriverOutput):
58
59 2012-09-05  Zan Dobersek  <zandobersek@gmail.com>
60
61         Unreviewed test fix.
62
63         Including a plugin source file into the build that was added in r127595.
64
65         * GNUmakefile.am:
66
67 2012-09-05  Tommy Widenflycht  <tommyw@google.com>
68
69         MediaStream API: Add the local and remote description functionality to RTCPeerConnection
70         https://bugs.webkit.org/show_bug.cgi?id=95839
71
72         Reviewed by Adam Barth.
73
74         In addition to adding the new methods to MockWebRTCPeerConnectionHandler I cleaned
75         up the task definitions a bit. There was no need to have them in the header file.
76
77         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
78         (RTCSessionDescriptionRequestSuccededTask):
79         (RTCSessionDescriptionRequestSuccededTask::RTCSessionDescriptionRequestSuccededTask):
80         (RTCSessionDescriptionRequestFailedTask):
81         (RTCSessionDescriptionRequestFailedTask::RTCSessionDescriptionRequestFailedTask):
82         (RTCVoidRequestTask):
83         (RTCVoidRequestTask::RTCVoidRequestTask):
84         (MockWebRTCPeerConnectionHandler::createOffer):
85         (MockWebRTCPeerConnectionHandler::setLocalDescription):
86         (MockWebRTCPeerConnectionHandler::setRemoteDescription):
87         (MockWebRTCPeerConnectionHandler::localDescription):
88         (MockWebRTCPeerConnectionHandler::remoteDescription):
89         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
90         (MockWebRTCPeerConnectionHandler):
91
92 2012-09-05  Kangil Han  <kangil.han@samsung.com>
93
94         [EFL] Remove '+=' usage in String
95         https://bugs.webkit.org/show_bug.cgi?id=95808
96
97         Reviewed by Benjamin Poulain.
98
99         Replaced use of String operator '+=' with StringBuilder.append*() in order to adopt efficient String concatenation.
100
101         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
102         (descriptionSuitableForTestResult):
103
104 2012-09-05  Christophe Dumez  <christophe.dumez@intel.com>
105
106         [EFL][WK2] Provide implementation for TestRunner::pathToLocalResource()
107         https://bugs.webkit.org/show_bug.cgi?id=95842
108
109         Reviewed by Kenneth Rohde Christiansen.
110
111         Provide proper implementation for TestRunner::pathToLocalResource()
112         in EFL WKTR, identical to the one for DumpRenderTree.
113
114         Map /tmp to ${DUMPRENDERTREE_TEMP} environment variable and
115         /tmp/LayoutTests to ${LOCAL_RESOURCE_ROOT} so that local resources
116         are found my WebKitTestRunner.
117
118         * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp:
119         (WTR::TestRunner::pathToLocalResource):
120
121 2012-09-05  Brady Eidson  <beidson@apple.com>
122
123         Frequent crashes in PluginView::scriptObject under runtimeObjectCustomGetOwnPropertySlot
124         <rdar://problem/12142226> and https://bugs.webkit.org/show_bug.cgi?id=95026
125
126         Reviewed by Andy Estes.
127
128         Add a plug-in that always fails to initialize:
129         * DumpRenderTree/TestNetscapePlugIn/Tests/NPPNewFails.cpp: Added.
130         (NPPNewFails):
131         (NPPNewFails::NPPNewFails):
132         (NPPNewFails::NPP_New):
133
134         Add it to all the project files:
135         * DumpRenderTree/DumpRenderTree.gypi:
136         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
137         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
138         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
139         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
140
141 2012-09-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
142
143         [Qt] Fix makefile race condition between derived sources and target
144
145         r121966 removed too much of the old qmake logic, including the rule
146         that ensured that qmake_all would not trigger dual runs of qmake --
147         one of the derived sources -qmake-all rule, and one for making the
148         derived sources.
149
150         We now follow a similar pattern as before, by introducing a custom
151         target that explicitly depends on the derived sources' qmake-all before
152         doing a manual run of make. That ensures a single qmake run for the derived
153         sources.
154
155         https://bugs.webkit.org/show_bug.cgi?id=93847
156
157         Reviewed by Csaba Osztrogonác.
158
159         * qmake/mkspecs/features/functions.prf:
160
161 2012-09-05  Christophe Dumez  <christophe.dumez@intel.com>
162
163         WKTR doesn't implement dumpWillCacheResponse()
164         https://bugs.webkit.org/show_bug.cgi?id=94607
165
166         Reviewed by Kenneth Rohde Christiansen.
167
168         Define shouldCacheResponse() callback in resource
169         load client and provide implementation for
170         dumpWillCacheResponse() in WebKitTestRunner.
171
172         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
173         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
174         (WTR::InjectedBundlePage::InjectedBundlePage):
175         (WTR::InjectedBundlePage::shouldCacheResponse):
176         (WTR):
177         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
178         (InjectedBundlePage):
179         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
180         (WTR::TestRunner::TestRunner):
181         * WebKitTestRunner/InjectedBundle/TestRunner.h:
182         (WTR::TestRunner::dumpWillCacheResponse):
183         (WTR::TestRunner::shouldDumpWillCacheResponse):
184         (TestRunner):
185
186 2012-09-05  Kaustubh Atrawalkar  <kaustubh@motorola.com>
187
188         [DRT] LTC:: Move printing related APIs from LayoutTestController to Internals
189         https://bugs.webkit.org/show_bug.cgi?id=92735
190
191         Reviewed by Hajime Morita.
192
193         Move numberOfPages, pageProperty & pageSizeAndMarginsInPixels in Internals and remove duplicated code from DumprenderTree & WebkitTestRunner.
194
195         * DumpRenderTree/TestRunner.cpp:
196         (TestRunner::staticFunctions):
197         * DumpRenderTree/TestRunner.h:
198         (TestRunner):
199         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
200         (TestRunner::addUserStyleSheet):
201         * DumpRenderTree/chromium/DRTTestRunner.cpp:
202         (DRTTestRunner::DRTTestRunner):
203         (DRTTestRunner::hasCustomPageSizeStyle):
204         * DumpRenderTree/chromium/DRTTestRunner.h:
205         (DRTTestRunner):
206         * DumpRenderTree/efl/TestRunnerEfl.cpp:
207         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
208         * DumpRenderTree/mac/TestRunnerMac.mm:
209         * DumpRenderTree/qt/TestRunnerQt.cpp:
210         (TestRunner::evaluateScriptInIsolatedWorld):
211         * DumpRenderTree/qt/TestRunnerQt.h:
212         (TestRunner):
213         * DumpRenderTree/win/TestRunnerWin.cpp:
214         * DumpRenderTree/wx/TestRunnerWx.cpp:
215         (TestRunner::abortModal):
216         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
217         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
218         (WTR):
219         * WebKitTestRunner/InjectedBundle/TestRunner.h:
220         (TestRunner):
221
222 2012-09-05  Simon Hausmann  <simon.hausmann@nokia.com>
223
224         [Qt] Automate the use of AllInOne files in the Qt build
225         https://bugs.webkit.org/show_bug.cgi?id=95837
226
227         Reviewed by Tor Arne Vestbø.
228
229         New feature file that implements the all-in-one file automation by
230         adding the requested all-in-one files to SOURCES and removing the files
231         it includes from SOURCES.
232
233         * qmake/mkspecs/features/use_all_in_one_files.prf: Added.
234
235 2012-09-04  Tim Horton  <timothy_horton@apple.com>
236
237         Have NRWT log more output when crash logs are missing
238         https://bugs.webkit.org/show_bug.cgi?id=95814
239
240         Reviewed by Dan Bernstein.
241
242         Log the stderr and stdout of the test, in order to provide slightly more
243         context when the WebProcess times out while running tests.
244
245         * Scripts/webkitpy/layout_tests/port/driver.py:
246         (Driver.run_test):
247
248 2012-09-04  Xianzhu Wang  <wangxianzhu@chromium.org>
249
250         [Chromium-Android] Include device serial number in ChromiumAndroidDriver log messages
251         https://bugs.webkit.org/show_bug.cgi?id=95770
252
253         Reviewed by Adam Barth.
254
255         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
256         (ChromiumAndroidDriver.__init__):
257         (ChromiumAndroidDriver._log_error): Added to replace original _log.error().
258         (ChromiumAndroidDriver._log_debug): Added to replace original _log.debug().
259         (ChromiumAndroidDriver._abort): Added to replace original raise AssertionError().
260         (ChromiumAndroidDriver._push_executable):
261         (ChromiumAndroidDriver._push_fonts):
262         (ChromiumAndroidDriver._push_test_resources):
263         (ChromiumAndroidDriver._run_adb_command):
264         (ChromiumAndroidDriver._get_last_stacktrace):
265         (ChromiumAndroidDriver._get_crash_log):
266         (ChromiumAndroidDriver._start):
267         (ChromiumAndroidDriver._start_once):
268         (ChromiumAndroidDriver._start_once.deadlock_detector):
269         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
270         (ChromiumAndroidDriverTest.test_get_crash_log):
271
272 2012-09-04  Satish Sampath  <satish@chromium.org>
273
274         Run git commands within the checkout directory
275         https://bugs.webkit.org/show_bug.cgi?id=95742
276
277         Reviewed by Eric Seidel.
278
279         git commands run from scm/git.py are sometimes run with cwd set to the
280         checkout_root and other times with whatever directory was the default cwd.
281         Instead all these should run with the checkout root set as the cwd
282         (except where we explicitly need a different path)
283
284         * Scripts/webkitpy/common/checkout/scm/git.py:
285         (Git._run_git):
286         (Git.find_checkout_root):
287         (Git.discard_local_commits):
288         (Git.local_commits):
289         (Git.working_directory_is_clean):
290         (Git.clean_working_directory):
291         (Git.add_list):
292         (Git.delete_list):
293         (Git.exists):
294         (Git._current_branch):
295         (Git._changes_files_for_commit):
296         (Git.revisions_changing_file):
297         (Git.svn_revision):
298         (Git._run_git_svn_find_rev):
299         (Git.contents_at_revision):
300         (Git.diff_for_file):
301         (Git.show_head):
302         (Git.committer_email_for_revision):
303         (Git.apply_reverse_diff):
304         (Git.revert_files):
305         (Git.commit_with_message):
306         (Git._commit_on_branch):
307         (Git.svn_commit_log):
308         (Git.last_svn_commit_log):
309         (Git.svn_blame):
310         (Git._branch_ref_exists):
311         (Git.delete_branch):
312         (Git.remote_merge_base):
313         (Git.commit_locally_with_message):
314         (Git.push_local_commits_to_server):
315         (Git.commit_ids_from_commitish_arguments):
316         (Git.commit_message_for_local_commit):
317         (Git.files_changed_summary_for_commit):
318
319 2012-09-04  Tommy Widenflycht  <tommyw@google.com>
320
321         MediaStream API: Add the async createOffer functionality to RTCPeerConnection
322         https://bugs.webkit.org/show_bug.cgi?id=95734
323
324         Reviewed by Adam Barth.
325
326         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
327         (MockWebRTCPeerConnectionHandler::SuccessCallbackTask::SuccessCallbackTask):
328         (MockWebRTCPeerConnectionHandler::SuccessCallbackTask::runIfValid):
329         (MockWebRTCPeerConnectionHandler::FailureCallbackTask::FailureCallbackTask):
330         (MockWebRTCPeerConnectionHandler::FailureCallbackTask::runIfValid):
331         (MockWebRTCPeerConnectionHandler::createOffer):
332         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
333         (MockWebRTCPeerConnectionHandler):
334         (MockWebRTCPeerConnectionHandler::taskList):
335         (SuccessCallbackTask):
336         (FailureCallbackTask):
337
338 2012-09-04  Xianzhu Wang  <wangxianzhu@chromium.org>
339
340         [Chromium-Android] Output time and thread info in crash log
341         https://bugs.webkit.org/show_bug.cgi?id=95768
342
343         Reviewed by Adam Barth.
344
345         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
346         (ChromiumAndroidDriver._get_logcat): Add '-v threadtime' to adb logcat command line to get time and thread info.
347
348 2012-09-04  Tommy Widenflycht  <tommyw@google.com>
349
350         MediaStream API: Change the MediaStreamTrackList track added/removed signaling
351         https://bugs.webkit.org/show_bug.cgi?id=95721
352
353         Reviewed by Adam Barth.
354
355         * DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp:
356         (MockWebMediaStreamCenter::didAddMediaStreamTrack):
357         (MockWebMediaStreamCenter::didRemoveMediaStreamTrack):
358         * DumpRenderTree/chromium/MockWebMediaStreamCenter.h:
359         (MockWebMediaStreamCenter):
360
361 2012-09-04  Tony Chang  <tony@chromium.org>
362
363         Elide test names when running new-run-webkit-tests
364         https://bugs.webkit.org/show_bug.cgi?id=95626
365
366         Reviewed by Dirk Pranke.
367
368         When the test name exceeds the number of terminal columns, it leaves
369         text on the screen. Avoid this by eliding the test name when running
370         tests. This is similar to what ninja does when compiling.
371
372         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
373         (MeteredStream):
374         (MeteredStream.number_of_columns): Helper method to get number of
375         terminal columns. Won't work on Win32 python, but meh.
376         * Scripts/webkitpy/layout_tests/views/printing.py:
377         (Printer._test_status_line): New method for eliding the text. Doesn't use \u2026
378         because stderr appears to be ascii only.
379         (Printer.print_started_test): Route through _test_status_line.
380         (Printer.print_finished_test): Route through _test_status_line.
381         (Printer._print_test_trace): Route through _test_status_line.
382         (Printer._print_baseline): Route through _test_status_line.
383         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
384         (test_test_status_line): Test for _test_status_line.
385
386 2012-09-04  Martin Robinson  <mrobinson@igalia.com>
387
388         [GTK] Print API missing documentation when generating gtkdoc
389         https://bugs.webkit.org/show_bug.cgi?id=95703
390
391         Reviewed by Carlos Garcia Campos.
392
393         Print out API missing documentation when generating gtkdoc. This makes it
394         easier to fix documentation errors.
395
396         * gtk/generate-gtkdoc:
397         (print_missing_api): Added.
398         (generate_doc): Inline the rebase step, since it now reports an error
399         when you try to rebase without generating documentation first.
400         * gtk/gtkdoc.py:
401         (GTKDoc.rebase_installed_docs): Raise an error when rebasing without
402         generating documentation first to enable a small cleanup at the caller.
403         (GTKDoc.api_missing_documentation): Added.
404
405 2012-09-04  Vincent Scheib  <scheib@chromium.org>
406
407         [Chromium] Allow asyncronous response of pointer lock requests in layout tests.
408         https://bugs.webkit.org/show_bug.cgi?id=95628
409
410         Reviewed by James Robinson.
411
412         Future tests need the ability to respond asynchronously that
413         pointer lock requests have been accepted or rejected. This patch
414         adds the following:
415             testRunner.setPointerLockWillRespondAsynchronously();
416             testRunner.didAcquirePointerLock();
417             testRunner.didNotAcquirePointerLock();
418
419         Tested in existing test:
420             pointerlockchange-pointerlockerror-events.html
421
422         * DumpRenderTree/chromium/DRTTestRunner.cpp:
423         (DRTTestRunner::DRTTestRunner):
424         (DRTTestRunner::didAcquirePointerLock):
425         (DRTTestRunner::didNotAcquirePointerLock):
426         (DRTTestRunner::setPointerLockWillRespondAsynchronously):
427         * DumpRenderTree/chromium/DRTTestRunner.h:
428         (DRTTestRunner):
429         * DumpRenderTree/chromium/WebViewHost.cpp:
430         (WebViewHost::requestPointerLock):
431         (WebViewHost::didAcquirePointerLock):
432         (WebViewHost::didNotAcquirePointerLock):
433         * DumpRenderTree/chromium/WebViewHost.h:
434         (WebViewHost):
435         (WebViewHost::setPointerLockWillRespondAsynchronously):
436
437 2012-09-04  Ojan Vafai  <ojan@chromium.org>
438
439         Move content shell bots to their own builder group
440         https://bugs.webkit.org/show_bug.cgi?id=95765
441
442         Reviewed by Adam Barth.
443
444         In their current state of instability, they add too much noise. Once they get more stable,
445         we can add them back to the regular group or just have them replace the other bots.
446
447         Also, fix the filter for Apple Windows bots since some of them are now "Apple Win ...".
448
449         * TestResultServer/static-dashboards/builders.js:
450         (isWebkitTestRunner):
451         (isChromiumContentShellTestRunner):
452         (isChromiumWebkitTipOfTreeTestRunner):
453         (loadBuildersList):
454
455 2012-09-03  Ryuan Choi  <ryuan.choi@samsung.com>
456
457         [EFL] Change the focus when the web view is clicked in MiniBrowser and EWebLauncher
458         https://bugs.webkit.org/show_bug.cgi?id=95689
459
460         Reviewed by Kenneth Rohde Christiansen.
461
462         In Minibrowser & EWebLauncher, the web view loses the focus when url bar is clicked.
463         So, there are bugs that key events are always generated in url bar although
464         the user clicked the web view.
465
466         This patch recovers the focus of the web view when left button is pressed and
467         adds for MiniBrowser to toggle the focus when middle button is pressed
468         like EWebLauncher already did.
469
470         * EWebLauncher/main.c:
471         (on_mouse_down):
472         * MiniBrowser/efl/main.c:
473         (on_mouse_down):
474         (browserCreate):
475
476 2012-09-03  Tao Bai  <michaelbai@chromium.org>
477
478         Added ANDROID_GDBSERVER definition for Ant
479         https://bugs.webkit.org/show_bug.cgi?id=95265
480
481         Reviewed by Adam Barth.
482
483         ANDROID_GDBSERVER will replace ANDROID_TOOLCHAIN, because the ANDROID_TOOLCHAIN
484         is only used for finding the gdbserver.
485
486         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
487         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
488
489 2012-09-03  Tommy Widenflycht  <tommyw@google.com>
490
491         MediaStream API: Add Ice-related functionality to RTCPeerConnection
492         https://bugs.webkit.org/show_bug.cgi?id=95565
493
494         Reviewed by Adam Barth.
495
496         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
497         (MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
498         (MockWebRTCPeerConnectionHandler::updateICE):
499         (MockWebRTCPeerConnectionHandler::addICECandidate):
500         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
501         (MockWebRTCPeerConnectionHandler):
502
503 2012-09-03  Christophe Dumez  <christophe.dumez@intel.com>
504
505         [EFL] Fix resizing issues related to URL bar in Minibrowser / EWebLauncher
506         https://bugs.webkit.org/show_bug.cgi?id=95670
507
508         Reviewed by Kenneth Rohde Christiansen.
509
510         Fix layout issues related to the URL bar in Minibrowser
511         and EWebLauncher when the window is resized.
512
513         The URL bar was not resized accordingly and the Web
514         page was moved behing the URL bar, hiding part of it.
515
516         * EWebLauncher/main.c:
517         (on_ecore_evas_resize):
518         (closeWindow):
519         * EWebLauncher/url_bar.c:
520         (url_bar_width_set):
521         (url_bar_add):
522         * EWebLauncher/url_bar.h:
523         * MiniBrowser/efl/main.c:
524         (on_ecore_evas_resize):
525         (main):
526
527 2012-09-01  Xianzhu Wang  <wangxianzhu@chromium.org>
528
529         [Chromium-Android] Remove hard-coded skipped directories in chromium_android.py
530         https://bugs.webkit.org/show_bug.cgi?id=95605
531
532         Reviewed by Dirk Pranke.
533
534         Now skipping rules are put in LayoutTests/platform/chromium-android/TestExpectations.
535
536         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
537         (ChromiumAndroidPort.check_sys_deps):
538         (ChromiumAndroidPort.expectations_files):
539         (ChromiumAndroidPort.clean_up_test_run):
540
541 2012-09-01  Joanmarie Diggs  <jdiggs@igalia.com>
542
543         [Gtk] Incorrect/unexpected characters in the text of certain accessibles
544         https://bugs.webkit.org/show_bug.cgi?id=95180
545
546         Reviewed by Chris Fleizach.
547
548         The bug that was fixed stood in the way of fully implementing stringValue().
549         Testing that the bug is fixed requires stringValue() to be fully implemented
550         and object replacement characters to be printable.
551
552         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
553         (replaceCharactersForResults): New method which turns object replacement
554         characters into "<obj>" so that the characters can be properly shown in
555         Layout Test results. Also turns "\n" into "<\\n>" so that printing the
556         accessible text of a single object in the accessible tree doesn't mess up
557         the readibility of the results.
558         (AccessibilityUIElement::stringValue): Remove the code that immediately
559         returned upon encountering an object of ATK_ROLE_PANEL and call the new
560         replaceCharactersForResults() prior to returning the accessible string
561         value.
562
563 2012-09-01  Tommy Widenflycht  <tommyw@google.com>
564
565         MediaStream API: Add MediaStream management to RTCPeerConnection
566         https://bugs.webkit.org/show_bug.cgi?id=95543
567
568         Reviewed by Adam Barth.
569
570         Extending MockWebRTCPeerConnectionHandler to handle addStream/removeStream.
571
572         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
573         (MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
574         (MockWebRTCPeerConnectionHandler::addStream):
575         (MockWebRTCPeerConnectionHandler::removeStream):
576         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
577         (MockWebRTCPeerConnectionHandler):
578
579 2012-08-31  Tony Chang  <tony@chromium.org>
580
581         Remove ENABLE_CSS3_FLEXBOX compile time flag
582         https://bugs.webkit.org/show_bug.cgi?id=95382
583
584         Reviewed by Ojan Vafai.
585
586         Everyone is already enabling this by default and the spec has stablized.
587
588         * Scripts/webkitperl/FeatureList.pm:
589         * qmake/mkspecs/features/features.pri:
590
591 2012-08-31  Pratik Solanki  <psolanki@apple.com>
592
593         objc_msgSend and IMP should be cast appropriately before using
594         https://bugs.webkit.org/show_bug.cgi?id=95242
595
596         Reviewed by Benjamin Poulain.
597
598         Fix for older compilers. Pass id as the return type to the template
599         instead of relying on default type.
600
601         * DumpRenderTree/mac/DumpRenderTree.mm:
602         (drt_NSFontManager_availableFontFamilies):
603         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
604         (WTR::wtr_NSFontManager_availableFontFamilies):
605
606 2012-08-31  Zan Dobersek  <zandobersek@gmail.com>
607
608         nrwt: use scm instead of calling svn directly to get the revision in json results generator
609         https://bugs.webkit.org/show_bug.cgi?id=89616
610
611         Reviewed by Eric Seidel.
612
613         Add the new 'executive' optional function argument to the SCM.in_working_directory
614         class method. This way we get to reuse an Executive instance which is necessary in testing
615         when we're operating with a mock version of the object.
616
617         In JSONResultsGeneratorBase, it's now possible to get the current SVN revision by using
618         the SCMDetector with the generator's FileSystem and Executive instances.
619
620         * Scripts/webkitpy/common/checkout/scm/detection.py:
621         (SCMDetector.detect_scm_system):
622         * Scripts/webkitpy/common/checkout/scm/detection_unittest.py:
623         (SCMDetectorTest.test_detect_scm_system): Update the unit test to capture the mock
624         Executive output and test it against expected output.
625         * Scripts/webkitpy/common/checkout/scm/git.py:
626         (Git.in_working_directory):
627         * Scripts/webkitpy/common/checkout/scm/scm.py:
628         (SCM.in_working_directory):
629         * Scripts/webkitpy/common/checkout/scm/svn.py:
630         (SVN.in_working_directory):
631         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
632         (JSONResultsGeneratorBase.__init__):
633         (JSONResultsGeneratorBase._get_svn_revision):
634
635 2012-08-31  Jon Lee  <jonlee@apple.com>
636
637         [Tests] Add basic tests to http/tests/notifications
638         https://bugs.webkit.org/show_bug.cgi?id=95493
639         <rdar://problem/12209303>
640
641         Reviewed by Alexey Proskuryakov.
642
643         Add permission request support for WTR.
644
645         * WebKitTestRunner/TestController.cpp:
646         (WTR::TestController::initialize):
647         (WTR::TestController::decidePolicyForNotificationPermissionRequest): Always allow.
648         * WebKitTestRunner/TestController.h:
649         (TestController):
650
651 2012-08-31  Jon Lee  <jonlee@apple.com>
652
653         [DRT] Make simulating a web click on a notification a queued task
654         https://bugs.webkit.org/show_bug.cgi?id=95546
655         <rdar://problem/12214170>
656
657         Reviewed by Alexey Proskuryakov.
658
659         Making the web click happen asynchronously better mimics user interaction with the platform.
660
661         * DumpRenderTree/TestRunner.h: Add a flag that determines whether we have a pending notification click.
662         (TestRunner::hasPendingWebNotificationClick): Exposed so that dump() can check that the flag is
663         not set.
664         * DumpRenderTree/mac/DumpRenderTree.mm:
665         (dump): Assert that the flag is not set.
666         * DumpRenderTree/mac/TestRunnerMac.mm:
667         (TestRunner::simulateWebNotificationClick): Set the flag, then add a task to click the
668         notification. In the case where the block gets executed after the flag has been unset, we avoid
669         performing the click.
670
671 2012-08-31  Balazs Kelemen  <kbalazs@webkit.org>
672
673         [Qt] ImageDiff output is not in the expected form if image dimensions differ
674         https://bugs.webkit.org/show_bug.cgi?id=95575
675
676         Reviewed by Csaba Osztrogonác.
677
678         Output 100% difference in the case of differing image dimensions so
679         the test harness knows that we won't produce any output further.
680         This matches the behavior of other ports.
681
682         * DumpRenderTree/qt/ImageDiff.cpp:
683         (main):
684
685 2012-08-31  Sheriff Bot  <webkit.review.bot@gmail.com>
686
687         Unreviewed, rolling out r127261.
688         http://trac.webkit.org/changeset/127261
689         https://bugs.webkit.org/show_bug.cgi?id=95572
690
691         This patch depends on other build fixes (see blockers of bug
692         95466) which should land first (Requested by milian on
693         #webkit).
694
695         * qmake/mkspecs/features/features.prf:
696
697 2012-08-31  Milian Wolff  <milian.wolff@kdab.com>
698
699         [Qt] Support WebKit2/QML on QNX
700         https://bugs.webkit.org/show_bug.cgi?id=95466
701
702         Reviewed by Noam Rosenthal.
703
704         Enable USE(3D_GRAPHICS) on QNX again, paired with the other bug fixes
705         this should finally work now.
706
707         * qmake/mkspecs/features/features.prf:
708
709 2012-08-30  Xianzhu Wang  <wangxianzhu@chromium.org>
710
711         [Chromium-Android] Skip compositing/webgl and platform/chromium/virtual/threaded/compositing/webgl tests
712         https://bugs.webkit.org/show_bug.cgi?id=95400
713
714         Reviewed by Dirk Pranke.
715
716         WebGL is not enabled and should be skipped on Android (http://crbug.com/135877).
717
718         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
719         (ChromiumAndroidPort.skipped_layout_tests):
720
721 2012-08-30  Gustavo Noronha Silva  <gns@gnome.org>
722
723         [GTK] Tries to run empty string when calling generate-gtkdoc when not using jhbuild
724         https://bugs.webkit.org/show_bug.cgi?id=95499
725
726         Unreviewed. One more fix to avoid trying to run the empty string.
727
728         * Scripts/webkitdirs.pm:
729         (buildAutotoolsProject):
730
731 2012-08-30  Sheriff Bot  <webkit.review.bot@gmail.com>
732
733         Unreviewed, rolling out r127171.
734         http://trac.webkit.org/changeset/127171
735         https://bugs.webkit.org/show_bug.cgi?id=95505
736
737         testRunner does not need dumpWebNotificationCallbacks().
738         (Requested by jonlee on #webkit).
739
740         * DumpRenderTree/TestRunner.cpp:
741         (TestRunner::TestRunner):
742         (TestRunner::staticFunctions):
743         * DumpRenderTree/TestRunner.h:
744         (TestRunner):
745         * DumpRenderTree/mac/MockWebNotificationProvider.mm:
746         (-[MockWebNotificationProvider webView:didShowNotification:]):
747         (-[MockWebNotificationProvider webView:didClickNotification:]):
748         (-[MockWebNotificationProvider webView:didCloseNotifications:]):
749         * DumpRenderTree/mac/UIDelegate.mm:
750         (-[UIDelegate webView:decidePolicyForNotificationRequestFromOrigin:listener:]):
751
752 2012-08-30  Pratik Solanki  <psolanki@apple.com>
753
754         objc_msgSend and IMP should be cast appropriately before using
755         https://bugs.webkit.org/show_bug.cgi?id=95242
756
757         Reviewed by Benjamin Poulain.
758
759         Use wtfObjcMsgSend and wtfCallIMP templates which do appropriate casts
760         to a function pointer with right types when calling objc_msgSend and an
761         IMP method directly.
762
763         * DumpRenderTree/mac/DumpRenderTree.mm:
764         (drt_NSFontManager_availableFontFamilies):
765         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
766         (WTR::wtr_NSFontManager_availableFontFamilies):
767
768 2012-08-30  Benjamin Poulain  <bpoulain@apple.com>
769
770         Replace JSC::UString by WTF::String
771         https://bugs.webkit.org/show_bug.cgi?id=95271
772
773         Reviewed by Geoffrey Garen.
774
775         Get rid of UString.
776
777         * DumpRenderTree/efl/WorkQueueItemEfl.cpp:
778         * gdb/webkit.py:
779         (WTFStringPrinter.to_string):
780         (JSCIdentifierPrinter.to_string):
781         (JSCJSStringPrinter.to_string):
782         (add_pretty_printers):
783
784 2012-08-30  Dirk Pranke  <dpranke@chromium.org>
785
786         nrwt should have TestExpectations everywhere we have Skipped files for apple ports
787         https://bugs.webkit.org/show_bug.cgi?id=95495
788
789         Reviewed by Ojan Vafai.
790
791         This is a follow-on to bug 95370 that adds in support for
792         platform/wk2/TestExpectations and
793         platform/{mac,win}-$version/TestExpectations.
794
795         * Scripts/webkitpy/layout_tests/port/apple.py:
796         (ApplePort.expectations_files):
797         * Scripts/webkitpy/layout_tests/port/base.py:
798         (Port._skipped_file_search_paths):
799         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
800         (MacTest.test_expectations_files):
801         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
802         (MockDRTPortTest.make_port):
803         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
804         (WinPortTest.test_expectations_files):
805
806 2012-08-30  Dirk Pranke  <dpranke@chromium.org>
807
808         executive.run_in_parallel() hangs if given nothing to do
809         https://bugs.webkit.org/show_bug.cgi?id=95387
810
811         Reviewed by Ojan Vafai.
812
813         Check to make sure that Executive.run_in_parallel() requires
814         a non-empty list of commands to execute; passing an empty list
815         seems surely like a programming error.
816
817         * Scripts/webkitpy/common/system/executive.py:
818         (Executive.run_in_parallel):
819         * Scripts/webkitpy/common/system/executive_unittest.py:
820         (ExecutiveTest.test_run_in_parallel_assert_nonempty):
821
822 2012-08-30  Dirk Pranke  <dpranke@chromium.org>
823
824         decide what (and how) we should set the tolerance for ref test pixel compares and test for that
825         https://bugs.webkit.org/show_bug.cgi?id=94746
826
827         Reviewed by Ojan Vafai.
828
829         Add an assertion to diff_image() to check that we are passing
830         tolerance=0 explicitly when diffing ref test results.
831
832         * Scripts/webkitpy/layout_tests/port/test.py:
833         (TestPort.diff_image):
834
835 2012-08-30  Dirk Pranke  <dpranke@chromium.org>
836
837         NRWT should look in mac-wk2 for a TestExpecations file
838         https://bugs.webkit.org/show_bug.cgi?id=95370
839
840         Reviewed by Ojan Vafai.
841
842         Adds support for mac-wk2 and win-wk2 to expectations_files()
843         for the apple mac and apple win ports.
844         
845         * Scripts/webkitpy/layout_tests/port/apple.py:
846         (ApplePort.expectations_files):
847         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
848         (MacTest.test_expectations_files):
849         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
850         (WinTest.test_expectations_files):
851         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
852         (PortTestCase.test_expectations_files):
853
854 2012-08-30  Jon Lee  <jonlee@apple.com>
855
856         [Mac] Add testRunner.dumpWebNotificationCallbacks() to DRT
857         https://bugs.webkit.org/show_bug.cgi?id=95232
858         <rdar://problem/12190776>
859
860         Reviewed by Alexey Proskuryakov.
861
862         Add additional output when running test, if testRunner.dumpWebNotificationCallbacks() is called.
863
864         * DumpRenderTree/TestRunner.cpp:
865         (TestRunner::TestRunner):
866         (dumpWebNotificationCallbacksCallback):
867         (TestRunner::staticFunctions):
868         * DumpRenderTree/TestRunner.h:
869         (TestRunner):
870         (TestRunner::dumpWebNotificationCallbacks):
871         (TestRunner::setDumpWebNotificationCallbacks):
872         * DumpRenderTree/mac/MockWebNotificationProvider.mm:
873         (-[WebNotification _drt_descriptionSuitableForTestResult]):
874         (-[MockWebNotificationProvider webView:didShowNotification:]):
875         (-[MockWebNotificationProvider webView:didClickNotification:]):
876         (-[MockWebNotificationProvider webView:didCloseNotifications:]):
877         * DumpRenderTree/mac/UIDelegate.mm:
878         (-[UIDelegate webView:decidePolicyForNotificationRequestFromOrigin:listener:]):
879
880 2012-08-30  Tommy Widenflycht  <tommyw@google.com>
881
882         MediaStream API: Introduce MediaConstraints
883         https://bugs.webkit.org/show_bug.cgi?id=95198
884
885         Reviewed by Adam Barth.
886
887         Extending the MockWebRTCPeerConnectionHandler with MediaConstraints functionality.
888
889         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
890         (MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
891         (isSupportedConstraint):
892         (isValidConstraint):
893         (MockWebRTCPeerConnectionHandler::initialize):
894         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
895         (MockWebRTCPeerConnectionHandler):
896
897 2012-08-30  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
898
899         [WK2][WTR] Add didReceiveServerRedirectForProvisionalLoadForFrame dumping
900         https://bugs.webkit.org/show_bug.cgi?id=95454
901
902         Reviewed by Kenneth Rohde Christiansen.
903
904         Added didReceiveServerRedirectForProvisionalLoadForFrame dumping to WTR.
905
906         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
907         (WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
908
909 2012-08-30  Leo Yang  <leoyang@rim.com>
910
911         Update my email address.
912
913         Not reviewed.
914
915         * Scripts/webkitpy/common/config/committers.py:
916
917 2012-08-30  Jochen Eisinger  <jochen@chromium.org>
918
919         [NRWT] Add support for recognizing arbitrary process names in crash lines
920         https://bugs.webkit.org/show_bug.cgi?id=95435
921
922         Reviewed by Adam Barth.
923
924         When running layout tests in the chromium port using the content shell,
925         we want to be able to report sub-process crashes as well.
926
927         * Scripts/webkitpy/layout_tests/port/driver.py:
928         (Driver._check_for_driver_crash):
929         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
930         (DriverTest.test_check_for_driver_crash):
931
932 2012-08-29  Zan Dobersek  <zandobersek@gmail.com>
933
934         Random test-webkitpy failures on the buildbot
935         https://bugs.webkit.org/show_bug.cgi?id=95096
936
937         Reviewed by Dirk Pranke.
938
939         Suppress occasional errors when running test-webkitpy on GTK builders
940         by running these tests serially. The 64-bit Release builder is especially
941         prone to these as it can run up to 24 tests in parallel.
942
943         Despite the tests not being run in parallel, the testing only lasts a handful
944         of seconds more, so this is a worthy trade-off to avoid unnecessary
945         false-alarm redness on the GTK builders.
946
947         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
948         (RunPythonTests.start):
949
950 2012-08-29  Benjamin Poulain  <bpoulain@apple.com>
951
952         REGRESSION(r126780): Crash using StringImpl::is8Bit before checking if there is an impl
953         https://bugs.webkit.org/show_bug.cgi?id=95380
954
955         Reviewed by Michael Saboff.
956
957         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
958         Add very basic tests for String::ascii(). This covers the case of null strings that caused
959         the crash.
960
961 2012-08-29  Dominic Mazzoni  <dmazzoni@google.com>
962
963         AX: Canvas should have a distinct role
964         https://bugs.webkit.org/show_bug.cgi?id=95248
965
966         Reviewed by Chris Fleizach.
967
968         Add support for canvas accessibility role.
969
970         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
971         (roleToString):
972
973 2012-08-29  José Dapena Paz  <jdapena@igalia.com>
974
975         [Gtk] Process Gtk 3.4 smooth scroll events properly
976         https://bugs.webkit.org/show_bug.cgi?id=88070
977
978         Added continousMouseScrollBy support in WebKitTestRunner, and added
979         implementation for gtk, and stub for Qt, mac and EFL.
980
981         Added layout tests support for smooth scroll in Gtk 3.4, and use smooth
982         scroll for emulating multi-tick mouseScrollBy events.
983
984         Reviewed by Martin Robinson.
985
986         * DumpRenderTree/gtk/EventSender.cpp:
987         (mouseScrollByCallback):
988         (continuousMouseScrollByCallback):
989         * WebKitTestRunner/EventSenderProxy.h:
990         (EventSenderProxy):
991         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
992         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
993         (WTR::EventSendingController::mouseScrollBy):
994         (WTR):
995         (WTR::EventSendingController::continuousMouseScrollBy):
996         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
997         (EventSendingController):
998         * WebKitTestRunner/TestController.cpp:
999         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
1000         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
1001         (WTR):
1002         (WTR::EventSenderProxy::mouseScrollBy):
1003         (WTR::EventSenderProxy::continuousMouseScrollBy):
1004         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
1005         (WTR):
1006         (WTR::EventSenderProxy::continuousMouseScrollBy):
1007         * WebKitTestRunner/mac/EventSenderProxy.mm:
1008         (WTR::EventSenderProxy::continuousScrollBy):
1009         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
1010         (WTR::EventSenderProxy::continuousMouseScrollBy):
1011         (WTR):
1012
1013 2012-08-29  Alex Sakhartchouk  <alexst@chromium.org>
1014
1015         [chromium] Support high DIP pixel tests with DumpRenderTree
1016         https://bugs.webkit.org/show_bug.cgi?id=94935
1017
1018         Reviewed by James Robinson.
1019
1020         Adding device scale factor into the drt image dumping code
1021
1022         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1023         (DRTTestRunner::reset):
1024         (DRTTestRunner::setBackingScaleFactor):
1025         * DumpRenderTree/chromium/WebViewHost.cpp:
1026         (WebViewHost::setDeviceScaleFactor):
1027         (WebViewHost::paintInvalidatedRegion):
1028         (WebViewHost::canvas):
1029         * DumpRenderTree/chromium/WebViewHost.h:
1030         (WebViewHost):
1031
1032 2012-08-29  Kevin Funk  <kevin.funk@kdab.com>
1033
1034         Fix check-webkit-style (and probably others) when WebKit is in a git submodule
1035         https://bugs.webkit.org/show_bug.cgi?id=95177
1036
1037         Reviewed by Dirk Pranke.
1038
1039         Find the real checkout root by using 'git rev-parse --show-toplevel' instead of '--git-dir'
1040
1041         * Scripts/webkitpy/common/checkout/scm/git.py:
1042
1043 2012-08-29  Dirk Pranke  <dpranke@chromium.org>
1044
1045         webkit-patch rebaseline-expectations wrongly touches other platforms' TestExpectations
1046         https://bugs.webkit.org/show_bug.cgi?id=95222
1047
1048         Reviewed by Adam Barth.
1049
1050         The code we had to remove REBASELINE lines from the
1051         TestExpectations files did not handle multiple files (in a
1052         cascade) correctly; we weren't limiting lines to a particular
1053         file correctly in without_rebaseline_modifier(). This patch
1054         fixes that and corrects the tests (which weren't correct and
1055         didn't cover things very well).
1056
1057         Note also that the webkit-patch rebaseline-commands are still
1058         using the include_overrides=False option in a couple places;
1059         this is never correct or needed at this point. This patch fixes
1060         the usage for webkit-patch rebaseline-expectations, but I still
1061         need to fix rebaseline-test-internal, which I will do in a
1062         separate patch (see bug 95268).
1063
1064         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1065         (TestExpectations.remove_rebaselined_tests.without_rebaseline_modifier):
1066         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1067         (RebaseliningTest.assertRemove):
1068         (RebaseliningTest.test_remove):
1069         * Scripts/webkitpy/tool/commands/rebaseline.py:
1070         (RebaselineExpectations._update_expectations_files):
1071
1072 2012-08-29  Dirk Pranke  <dpranke@chromium.org>
1073
1074         webkit-patch rebaseline-expectations hangs
1075         https://bugs.webkit.org/show_bug.cgi?id=95243
1076
1077         Reviewed by Tony Chang.
1078
1079         Don't try to run no commands in parallel; report an error
1080         instead that we didn't find any tests to rebaseline.
1081
1082         Filed bug 95387 as well to make sure run_in_parallel() doesn't hang forever.
1083
1084         * Scripts/webkitpy/tool/commands/rebaseline.py:
1085         (RebaselineExpectations.execute):
1086         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1087         (_assert_command):
1088         (test_rebaseline_expectations_noop):
1089
1090 2012-08-29  Brady Eidson  <beidson@apple.com>
1091
1092         REGRESSION: Not sending NPP_SetWindow is causing Flash to not throttle itself
1093         <rdar://problem/12133021> and https://bugs.webkit.org/show_bug.cgi?id=95274
1094
1095         Reviewed by Sam Weinig.
1096
1097         Add a test plug-in that calls back into the page with info on the NPWindow passed
1098         in to NPP_SetWindow.
1099
1100         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1101         * DumpRenderTree/TestNetscapePlugIn/Tests/LogNPPSetWindow.cpp: Added.
1102         (LogNPPSetWindow):
1103         (LogNPPSetWindow::LogNPPSetWindow):
1104         (LogNPPSetWindow::NPP_SetWindow):
1105
1106 2012-08-29  Jon Lee  <jonlee@apple.com>
1107
1108         [Mac] Basic DRT support for web notifications
1109         https://bugs.webkit.org/show_bug.cgi?id=79492
1110         <rdar://problem/10357639>
1111
1112         Reviewed by Alexey Proskuryakov.
1113
1114         This patch implements the stubs for web notification support on DRT. Assume that when
1115         Notification.requestPermission() is called, the user always chooses to allow it. This can be easily
1116         overridden in layout tests with testRunner.denyWebNotificationPermission() when needed.
1117
1118         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Add MockWebNotificationProvider.
1119         * DumpRenderTree/mac/DumpRenderTree.mm:
1120         (createWebViewAndOffscreenWindow): Set MockWebNotificationProvider singleton as the provider for the
1121         web view.
1122         (resetWebViewToConsistentStateBeforeTesting): Make sure to reset the provider's state between each test.
1123
1124         * DumpRenderTree/mac/TestRunnerMac.mm:
1125         (TestRunner::grantWebNotificationPermission): Set permission to granted for specified origin.
1126         (TestRunner::denyWebNotificationPermission): Set permission to denied for specified origin.
1127         (TestRunner::removeAllWebNotificationPermissions):
1128         (TestRunner::simulateWebNotificationClick): Retrieve the notification ID from the JS notification object, and
1129         simulate the click. This is similar to how WTR performs the click.
1130         * DumpRenderTree/mac/UIDelegate.mm:
1131         (-[UIDelegate webView:decidePolicyForNotificationRequestFromOrigin:listener:]): Assume when asked, the
1132         user allows web notifications.
1133
1134         * DumpRenderTree/mac/MockWebNotificationProvider.h: Added. Maintains a list of registered web views, known permissions,
1135         a map of notification IDs to WebNotification instances, and a map of the WebViews from which the notifications were dispatched.
1136         * DumpRenderTree/mac/MockWebNotificationProvider.mm: Added.
1137         (+[MockWebNotificationProvider shared]): The provider is a singleton.
1138         (-[MockWebNotificationProvider init]): Instantiate the permissions map.
1139         (-[MockWebNotificationProvider registerWebView:]):
1140         (-[MockWebNotificationProvider unregisterWebView:]):
1141         (-[MockWebNotificationProvider showNotification:fromWebView:]): Add the notification to the maps. Tell the web view that the
1142         notification did show.
1143         (-[MockWebNotificationProvider cancelNotification:]): Tell the web view the notification did close.
1144         (-[MockWebNotificationProvider notificationDestroyed:]): Remove the notification from the maps. Here we don't make a callback.
1145         (-[MockWebNotificationProvider clearNotifications:]): Remove the specified notifications from the maps. Here we don't make a callback.
1146         (-[MockWebNotificationProvider webView:didShowNotification:]): Delegate callback. Dispatch the show event.
1147         (-[MockWebNotificationProvider webView:didClickNotification:]): Delegate callback. Dispatch the click event.
1148         (-[MockWebNotificationProvider webView:didCloseNotifications:]): Delegate callback. Dispatch the close event.
1149         (-[MockWebNotificationProvider simulateWebNotificationClick:]): Tell the web view we clicked the notification.
1150         (-[MockWebNotificationProvider policyForOrigin:]): Look in the permission dictionary.
1151         (-[MockWebNotificationProvider setWebNotificationOrigin:permission:]): Set the permission for the origin in the dictionary.
1152         (-[MockWebNotificationProvider removeAllWebNotificationPermissions]): Clear the permission map.
1153         (-[MockWebNotificationProvider reset]): Remove all mappings and permissions.
1154
1155 2012-08-29  Rob Buis  <rbuis@rim.com>
1156
1157         [BlackBerry] Adjust wtf include header style
1158         https://bugs.webkit.org/show_bug.cgi?id=95368
1159
1160         Reviewed by Yong Li.
1161
1162         Switch to #include <wtf/...> like the other ports.
1163
1164         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
1165         * DumpRenderTree/blackberry/PNGImageEncoder.cpp:
1166         * DumpRenderTree/blackberry/PNGImageEncoder.h:
1167         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
1168         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.h:
1169         * DumpRenderTree/blackberry/WorkQueueItemBlackBerry.cpp:
1170
1171 2012-08-29  Roger Fong  <roger_fong@apple.com>
1172
1173         Update cygwin-downloader.zip to match modified downloader script.
1174         https://bugs.webkit.org/show_bug.cgi?id=76936
1175
1176         Rubber Stamped by Jon Honeycutt.
1177
1178         cygwin-downloader.py was modified in http://trac.webkit.org/changeset/126948.
1179         Updating zip to reflect changes.
1180
1181         * CygwinDownloader/cygwin-downloader.zip:
1182
1183 2012-08-29  Dominik Röttsches  <dominik.rottsches@intel.com>
1184
1185         Stylechecker warns about comparison to zero when comparing to 0.5
1186         https://bugs.webkit.org/show_bug.cgi?id=94913
1187
1188         Reviewed by Dirk Pranke.
1189
1190         According to the python documentation, \W is the character group with all
1191         non-alphanumeric characters, equivalent to [^a-zA-Z0-9_], which is equal to
1192         to [^\w]. We need to exclude the dot "." as well, so that floating point
1193         values do not trigger this warning. Adding a unit test that shows the problem.
1194
1195         * Scripts/webkitpy/style/checkers/cpp.py:
1196         (check_for_comparisons_to_zero): Modifying the regex to not get triggered by comparing to floats.
1197         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1198         (WebKitStyleTest.test_null_false_zero): Unit test exposing this issue.
1199
1200 2012-08-29  Jon Lee  <jonlee@apple.com>
1201
1202         WTR build fixes.
1203
1204         * WebKitTestRunner/CMakeLists.txt:
1205         * WebKitTestRunner/GNUmakefile.am:
1206         * WebKitTestRunner/Target.pri:
1207         * WebKitTestRunner/WebNotificationProvider.cpp:
1208         (WTR::WebNotificationProvider::showWebNotification): Make ML happier.
1209         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1210
1211 2012-08-29  Jon Lee  <jonlee@apple.com>
1212
1213         [WK2] Basic WTR support for web notifications
1214         https://bugs.webkit.org/show_bug.cgi?id=95154
1215         <rdar://problem/12184492>
1216
1217         Reviewed by Alexey Proskuryakov.
1218
1219         Implement WTR support, without platform event output (bug 95233).
1220
1221         Legacy APIs will not be supported, since many of the tests are skipped
1222         on ports that do test notifications, and the issue with using file:// as the origin means a lot of the permissions
1223         tests won't work. Bugs 81048 and 81697 will track migrating the existing tests to use the new testRunner API, and move
1224         the tests to http/tests/notifications.
1225
1226         Permissions will be handled only in the injected bundle. This allows tests to set permission synchronously, and not
1227         require a chain of setTimeout()'s when writing a notification test. Clicking a notification, however, should
1228         be invoked from the UIProcess.
1229
1230         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1231         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1232         (WTR::InjectedBundle::didReceiveMessage): When told to "Reset", clear out all of the permissions.
1233         (WTR::InjectedBundle::postSimulateWebNotificationClick): Tell the bundle client to simulate a click based on the
1234         notification's internal ID.
1235         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1236         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1237         (WTR::TestRunner::grantWebNotificationPermission): Manually set the permission using WKBundle SPI.
1238         (WTR::TestRunner::denyWebNotificationPermission): Manually set the permission using WKBundle SPI.
1239         (WTR::TestRunner::removeAllWebNotificationPermissions):
1240         (WTR::TestRunner::simulateWebNotificationClick): Post a message through the injected bundle.
1241         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1242
1243         Because supporting web notifications goes beyond a couple functions, move all of the logic into a WebNotificationProvider
1244         class.
1245         * WebKitTestRunner/TestInvocation.cpp:
1246         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): When the injected bundle sends a message to simulate a click,
1247         TestInvocation forwards that request to the TestController.
1248         * WebKitTestRunner/TestController.cpp:
1249         (WTR::TestController::initialize): Set the provider.
1250         (WTR::TestController::resetStateToConsistentValues): Tell the provider to reset.
1251         (WTR::TestController::simulateWebNotificationClick): Tell the provider to simulate a user clicking on a platform notification.
1252         * WebKitTestRunner/TestController.h: Holds an instance to the provider.
1253
1254         The provider maintains a pointer to one notification manager (presumably the web process associated with WTR), and a set
1255         of notification IDs that have been "shown" by the platform. This allows us to simulate a click on a notification.
1256         * WebKitTestRunner/WebNotificationProvider.h: Added.
1257         * WebKitTestRunner/WebNotificationProvider.cpp: Added.
1258         (WTR::WebNotificationProvider::showWebNotification): Adds the notification to set of shown notifications. Notifies provider that
1259         the notification got shown.
1260         (WTR::WebNotificationProvider::closeWebNotification): Removes the notification from the set. Notifies provider that the notification
1261         got closed.
1262         (WTR::WebNotificationProvider::addNotificationManager): Maintains one manager, which is fine for testing purposes.
1263         (WTR::WebNotificationProvider::removeNotificationManager): Maintains one manager.
1264         (WTR::WebNotificationProvider::notificationPermissions): When the web process starts, it maintains an initial set of known
1265         permissions. For testing purposes, we always want this set to be empty.
1266         (WTR::WebNotificationProvider::simulateWebNotificationClick): Notifies provider that the notification got "clicked".
1267         (WTR::WebNotificationProvider::reset): To reset the state, we pretend that we closed all of the platform notifications.
1268
1269         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Add WebNotificationProvider.
1270
1271 2012-08-29  Kamil Blank  <k.blank@samsung.com>
1272
1273         [EFL] Add setting API for allow universal/file access from file URLs.
1274         https://bugs.webkit.org/show_bug.cgi?id=83121
1275
1276         Reviewed by Eric Seidel.
1277
1278         Implementation of setAllowUniversalAccessFromFileURLs and setAllowFileAccessFromFileURLs.
1279
1280         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1281         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
1282         * DumpRenderTree/efl/TestRunnerEfl.cpp:
1283         (TestRunner::setAllowUniversalAccessFromFileURLs):
1284         (TestRunner::setAllowFileAccessFromFileURLs):
1285
1286 2012-08-29  Jon Lee  <jonlee@apple.com>
1287
1288         Update TestRunner API for web notifications
1289         https://bugs.webkit.org/show_bug.cgi?id=95093
1290         <rdar://problem/12179649>
1291
1292         Reviewed by Alexey Proskuryakov.
1293
1294         As it turns out the patch for this accidentally got squashed into the commit for
1295         bug 95099 (r126909). This amendment patch adds some comments about the renaming
1296         of the older TestRunner API for web notifications.
1297
1298         * DumpRenderTree/TestRunner.h:
1299         (TestRunner):
1300
1301 2012-08-29  Sheriff Bot  <webkit.review.bot@gmail.com>
1302
1303         Unreviewed, rolling out r126972.
1304         http://trac.webkit.org/changeset/126972
1305         https://bugs.webkit.org/show_bug.cgi?id=95349
1306
1307         accessibility/canvas-description-and-role.html has been
1308         failing consistently on several bots and Dominic needs some
1309         time to investigate why (Requested by jchaffraix on #webkit).
1310
1311         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
1312         (roleToString):
1313
1314 2012-08-29  Raphael Kubo da Costa  <rakuco@webkit.org>
1315
1316         [EFL] Resolve CMake warnings on overlapping search paths for EFL jhbuild-enabled build
1317         https://bugs.webkit.org/show_bug.cgi?id=84707
1318
1319         Reviewed by Gustavo Noronha Silva.
1320
1321         Most of the warnings have been fixed now that FindCairo.cmake and
1322         FindGLIB.cmake have been rewritten. The remaining one, related to
1323         FindFontconfig.cmake, shows up when building on a 64-bit
1324         Debian-based systems.
1325
1326         jhbuild installs libraries into lib64/ by default on 64-bit Linux
1327         installations, while CMake does not look for libraries in lib64/
1328         when /etc/debian_version exists on the system. The FIND_LIBRARY()
1329         would then sometimes end up using the system installation instead of
1330         the jhbuild one, causing mismatches and, when pkg-config is not used
1331         at all, failing to find libraries altogether.
1332
1333         * efl/jhbuildrc: Set the CMAKE_LIBRARY_PATH environment variable
1334         when use_lib64 is set to force CMake to look into lib64/ regardless
1335         of the presence of /etc/debian_version.
1336
1337 2012-08-29  Dominik Röttsches  <dominik.rottsches@intel.com>
1338
1339         The 2d.imageData.object.round canvas test is failing
1340         https://bugs.webkit.org/show_bug.cgi?id=40272
1341
1342         Reviewed by Benjamin Poulain.
1343
1344         Updating patch to address Benjamin's review comments.
1345         Adding a WTF test to test lrint implementation.
1346
1347         * TestWebKitAPI/CMakeLists.txt: Added MathExtras.cpp test file.
1348         * TestWebKitAPI/GNUmakefile.am: Added MathExtras.cpp test file.
1349         * TestWebKitAPI/TestWebKitAPI.gypi: Added MathExtras.cpp test file.
1350         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added MathExtras.cpp test file.
1351         * TestWebKitAPI/Tests/WTF/MathExtras.cpp: Added this test file containing a test for lrint().
1352         (TestWebKitAPI):
1353         (TestWebKitAPI::TEST):
1354         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added MathExtras.cpp test file.
1355
1356 2012-08-29  Florin Malita  <fmalita@chromium.org>
1357
1358         Unreviewed, updating Kelly Norton's email address at his request.
1359
1360         * Scripts/webkitpy/common/config/committers.py:
1361
1362 2012-08-29  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
1363
1364         [NRWT] The nrwt should check the contents of the skipped files with --lint-test-files
1365         https://bugs.webkit.org/show_bug.cgi?id=93723
1366
1367         Reviewed by Dirk Pranke.
1368
1369         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1370         (TestExpectationParser.expectation_for_skipped_test):
1371         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1372         (SkippedTests.test_skipped_entry_dont_exist):
1373
1374 2012-08-29  Sheriff Bot  <webkit.review.bot@gmail.com>
1375
1376         Unreviewed, rolling out r120113.
1377         http://trac.webkit.org/changeset/120113
1378         https://bugs.webkit.org/show_bug.cgi?id=95320
1379
1380         Wrong fix for the problem, experimentally rolling it out for
1381         bug 95237. (Requested by rakuco on #webkit).
1382
1383         * efl/jhbuildrc:
1384
1385 2012-08-29  Dominic Mazzoni  <dmazzoni@google.com>
1386
1387         AX: Canvas should have a distinct role
1388         https://bugs.webkit.org/show_bug.cgi?id=95248
1389
1390         Reviewed by Chris Fleizach.
1391
1392         Add support for canvas accessibility role.
1393
1394         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
1395         (roleToString):
1396
1397 2012-08-28  Eric Seidel  <eric@webkit.org>
1398
1399         cr-ews bot doesn't set CWD correctly when zipping layout test results
1400         https://bugs.webkit.org/show_bug.cgi?id=91265
1401
1402         Reviewed by Kenneth Russell.
1403
1404         This should make the zips slightly less cumbersome to deal with.
1405
1406         * Scripts/webkitpy/common/system/workspace.py:
1407         (Workspace.create_zip):
1408         * Scripts/webkitpy/common/system/workspace_unittest.py:
1409         (WorkspaceTest.test_create_zip):
1410         (WorkspaceTest.test_create_zip_exception):
1411
1412 2012-08-28  Benjamin Poulain  <benjamin@webkit.org>
1413
1414         Fix the Commiters script
1415
1416         Unreviewed.
1417
1418         Remove Roger Fong from the Contributor list, he appears in the Commiter list since r126949.
1419
1420         * Scripts/webkitpy/common/config/committers.py:
1421
1422 2012-08-28  Roger Fong  <roger_fong@apple.com>
1423
1424         Unreviewed. Adding myself to committers list.
1425
1426         * Scripts/webkitpy/common/config/committers.py:
1427
1428 2012-08-28  Roger Fong  <roger_fong@apple.com>
1429
1430         Add minires to list of required cygwin install packages.
1431         https://bugs.webkit.org/show_bug.cgi?id=76936
1432
1433         Reviewed by Tim Horton.
1434
1435         * CygwinDownloader/cygwin-downloader.py:
1436
1437 2012-08-28  Xianzhu Wang  <wangxianzhu@chromium.org>
1438
1439         [Chromium-Android] Upstream layout test expectations (Part 2)
1440         https://bugs.webkit.org/show_bug.cgi?id=95212
1441
1442         Reviewed by Adam Barth.
1443
1444         - Now run both gpu path and non-gpu path of 2d canvas layout tests
1445         because both are used in chromium-android.
1446
1447         - Exclude all webgl tests because webgl is not enabled yet.
1448
1449         - Removed 'win' from the baseline fallback list. This was a mistake.
1450
1451         - Moved some small directories to TestExpectations from skipped_layout_tests().
1452
1453         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1454         (ChromiumAndroidPort):
1455         (ChromiumAndroidPort.skipped_layout_tests):
1456
1457 2012-08-28  Joanmarie Diggs  <jdiggs@igalia.com>
1458
1459         Implement AccessibilityUIElement::titleUIElement() and AccessibilityUIElement::stringValue()
1460         https://bugs.webkit.org/show_bug.cgi?id=95185
1461
1462         Reviewed by Chris Fleizach.
1463
1464         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1465         (AccessibilityUIElement::titleUIElement): Implemented
1466         Gets the ATK_RELATION_LABELLED_BY target.
1467         (AccessibilityUIElement::stringValue): Implemented for all roles but ATK_ROLE_PANEL.
1468         Gets the string from atk_text_get_text(). Will implement for ATK_ROLE_PANEL after
1469         bug 95180 is fixed.
1470
1471 2012-08-28  Dominic Mazzoni  <dmazzoni@google.com>
1472
1473         AX: Crash due to object getting deleted inside updateBackingStore
1474         https://bugs.webkit.org/show_bug.cgi?id=94619
1475
1476         Reviewed by Chris Fleizach.
1477
1478         Change isValid to !isDetached after deleting isValid from
1479         chromium WebAccessibilityObject as being redundant.
1480
1481         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
1482         (AccessibilityUIElement::isValidGetterCallback):
1483
1484 2012-08-28  Sheriff Bot  <webkit.review.bot@gmail.com>
1485
1486         Unreviewed, rolling out r126914.
1487         http://trac.webkit.org/changeset/126914
1488         https://bugs.webkit.org/show_bug.cgi?id=95239
1489
1490         it breaks everything and fixes nothing (Requested by pizlo on
1491         #webkit).
1492
1493         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
1494         (MockWebSpeechInputController::addMockRecognitionResult):
1495         * DumpRenderTree/chromium/NotificationPresenter.cpp:
1496         (NotificationPresenter::simulateClick):
1497         (NotificationPresenter::show):
1498         * DumpRenderTree/chromium/TestRunner/CppBoundClass.cpp:
1499         (CppBoundClass::~CppBoundClass):
1500         (CppBoundClass::invoke):
1501         (CppBoundClass::getProperty):
1502         (CppBoundClass::setProperty):
1503         (CppBoundClass::bindCallback):
1504         (CppBoundClass::bindProperty):
1505         * DumpRenderTree/chromium/WebPreferences.cpp:
1506         (applyFontMap):
1507         * DumpRenderTree/chromium/WebViewHost.cpp:
1508         (WebViewHost::printResourceDescription):
1509         * DumpRenderTree/mac/TestRunnerMac.mm:
1510         (worldIDForWorld):
1511         (TestRunner::evaluateScriptInIsolatedWorld):
1512         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
1513         (AccessibilityController::~AccessibilityController):
1514         (AccessibilityController::winNotificationReceived):
1515         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1516         (ResourceLoadDelegate::descriptionSuitableForTestResult):
1517         * DumpRenderTree/win/TestRunnerWin.cpp:
1518         (worldIDForWorld):
1519         (TestRunner::evaluateScriptInIsolatedWorld):
1520         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
1521         (TestWebKitAPI::DOMWindowExtensionBasic::willDestroyPage):
1522         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
1523         (TestWebKitAPI::DOMWindowExtensionNoCache::willDestroyPage):
1524         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1525         (WTR::TestRunner::worldIDForWorld):
1526         (WTR::TestRunner::evaluateScriptInIsolatedWorld):
1527
1528 2012-08-28  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
1529
1530         Rename first/second to key/value in HashMap iterators
1531         https://bugs.webkit.org/show_bug.cgi?id=82784
1532
1533         Reviewed by Eric Seidel.
1534
1535         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
1536         (MockWebSpeechInputController::addMockRecognitionResult):
1537         * DumpRenderTree/chromium/NotificationPresenter.cpp:
1538         (NotificationPresenter::simulateClick):
1539         (NotificationPresenter::show):
1540         * DumpRenderTree/chromium/TestRunner/CppBoundClass.cpp:
1541         (CppBoundClass::~CppBoundClass):
1542         (CppBoundClass::invoke):
1543         (CppBoundClass::getProperty):
1544         (CppBoundClass::setProperty):
1545         (CppBoundClass::bindCallback):
1546         (CppBoundClass::bindProperty):
1547         * DumpRenderTree/chromium/WebPreferences.cpp:
1548         (applyFontMap):
1549         * DumpRenderTree/chromium/WebViewHost.cpp:
1550         (WebViewHost::printResourceDescription):
1551         * DumpRenderTree/mac/TestRunnerMac.mm:
1552         (worldIDForWorld):
1553         (TestRunner::evaluateScriptInIsolatedWorld):
1554         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
1555         (AccessibilityController::~AccessibilityController):
1556         (AccessibilityController::winNotificationReceived):
1557         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1558         (ResourceLoadDelegate::descriptionSuitableForTestResult):
1559         * DumpRenderTree/win/TestRunnerWin.cpp:
1560         (worldIDForWorld):
1561         (TestRunner::evaluateScriptInIsolatedWorld):
1562         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
1563         (TestWebKitAPI::DOMWindowExtensionBasic::willDestroyPage):
1564         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
1565         (TestWebKitAPI::DOMWindowExtensionNoCache::willDestroyPage):
1566         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1567         (WTR::TestRunner::worldIDForWorld):
1568         (WTR::TestRunner::evaluateScriptInIsolatedWorld):
1569
1570 2012-08-27  Jon Lee  <jonlee@apple.com>
1571
1572         Update TestRunner API for web notifications
1573         https://bugs.webkit.org/show_bug.cgi?id=95093
1574         <rdar://problem/12179649>
1575
1576         Reviewed by Jessie Berlin.
1577
1578         This is work toward providing Mac support for web notifications in DRT and WTR (77969).
1579
1580         Some of the legacy APIs are less than ideal, and not tenable with the WTR infrastructure.
1581         This first patch renames the TestRunner calls to use the term "web notifications" instead of
1582         "desktop notifications", deprecates a couple API calls that are not used by anyone, and adds
1583         additional calls that will be used in the tests that test the standard API.
1584
1585         * DumpRenderTree/TestRunner.h:
1586         (TestRunner): For consistency, rename a couple member variables. Remove unused checkDesktopNotificationPermission()
1587         and areDesktopNotificationPermissionRequestsIgnored(). Remove origin mapping since each port implements its own solution.
1588         * DumpRenderTree/TestRunner.cpp: Push grantWebNotificationPermission() to individual ports.
1589         (TestRunner::TestRunner):
1590         (ignoreLegacyWebNotificationPermissionRequestsCallback): Renamed.
1591         (simulateLegacyWebNotificationClickCallback): Renamed.
1592         (grantWebNotificationPermissionCallback): Renamed.
1593         (denyWebNotificationPermissionCallback): Added.
1594         (removeAllWebNotificationPermissionsCallback): Added.
1595         (simulateWebNotificationClickCallback): Added.
1596         (TestRunner::staticFunctions):
1597         (TestRunner::ignoreLegacyWebNotificationPermissionRequests):
1598
1599         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1600         (DRTTestRunner::DRTTestRunner): Added bindings for new APIs.
1601         (DRTTestRunner::grantWebNotificationPermission):
1602         (DRTTestRunner::denyWebNotificationPermission): Stub.
1603         (DRTTestRunner::removeAllWebNotificationPermissions): Stub.
1604         (DRTTestRunner::simulateWebNotificationClick): Stub.
1605         (DRTTestRunner::simulateLegacyWebNotificationClick):
1606         * DumpRenderTree/chromium/DRTTestRunner.h:
1607         (DRTTestRunner):
1608
1609         Added stubs.
1610         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
1611         * DumpRenderTree/efl/TestRunnerEfl.cpp:
1612         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
1613         * DumpRenderTree/mac/TestRunnerMac.mm: Later patch will contain implementation of this API.
1614         * DumpRenderTree/qt/TestRunnerQt.cpp: Added Qt-based stubs.
1615         * DumpRenderTree/win/TestRunnerWin.cpp:
1616
1617 2012-08-28  Szilard Ledan  <szledan@inf.u-szeged.hu>
1618
1619         [webkit-patch] gets stuck into an infinite loop if bugzilla doesn't respond in time.
1620         https://bugs.webkit.org/show_bug.cgi?id=94700
1621
1622         Reviewed by Eric Seidel.
1623
1624         Interrupting download with a timeout would be a possible solution.
1625         I imported the socket module and used the setdefaulttimeout() method.
1626         Fixing it is important, because EWS bots need to be restarted regularly
1627         because of this bug.
1628
1629         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1630         (Bugzilla._get_browser):
1631         (Bugzilla.setdefaulttimeout):
1632
1633 2012-08-28  Gabor Rapcsanyi  <rgabor@webkit.org>
1634
1635         [Qt] Keep QT_QPA_PLATFORM_PLUGIN_PATH environment variable in NRWT
1636         https://bugs.webkit.org/show_bug.cgi?id=95194
1637
1638         Reviewed by Simon Hausmann.
1639
1640         * Scripts/webkitpy/layout_tests/port/qt.py:
1641         (QtPort.setup_environ_for_server):
1642
1643 2012-08-28  Andras Becsi  <andras.becsi@nokia.com>
1644
1645         [watchlist] Unreviewed, subscribe to Qt bugs.
1646
1647         * Scripts/webkitpy/common/config/watchlist:
1648
1649 2012-08-28  Simon Hausmann  <simon.hausmann@nokia.com>
1650
1651         [Qt] New test introduced in r126611 fails: fast/css/image-set-setting.html
1652         https://bugs.webkit.org/show_bug.cgi?id=95054
1653
1654         Reviewed by Eric Seidel.
1655
1656         Enable CSS_IMAGE_SET for the Qt build.
1657
1658         * qmake/mkspecs/features/features.pri:
1659
1660 2012-08-27  Csaba Osztrogonác  <ossy@webkit.org>
1661
1662         [Qt] Enable CSS sticky position
1663         https://bugs.webkit.org/show_bug.cgi?id=95172
1664
1665         Reviewed by Simon Hausmann.
1666
1667         * qmake/mkspecs/features/features.pri:
1668
1669 2012-08-27  Zan Dobersek  <zandobersek@gmail.com>
1670
1671         [GTK] Memory cache should be cleared in between test runs
1672         https://bugs.webkit.org/show_bug.cgi?id=95105
1673
1674         Reviewed by Martin Robinson.
1675
1676         Call the new DumpRenderTreeSupportGtk helper method after every test
1677         to clear the memory cache.
1678
1679         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1680         (runTest):
1681
1682 2012-08-27  Sheriff Bot  <webkit.review.bot@gmail.com>
1683
1684         Unreviewed, rolling out r126836.
1685         http://trac.webkit.org/changeset/126836
1686         https://bugs.webkit.org/show_bug.cgi?id=95163
1687
1688         Broke all Apple ports, EFL, and Qt. (Requested by tkent on
1689         #webkit).
1690
1691         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
1692         (MockWebSpeechInputController::addMockRecognitionResult):
1693         * DumpRenderTree/chromium/NotificationPresenter.cpp:
1694         (NotificationPresenter::simulateClick):
1695         (NotificationPresenter::show):
1696         * DumpRenderTree/chromium/TestRunner/CppBoundClass.cpp:
1697         (CppBoundClass::~CppBoundClass):
1698         (CppBoundClass::invoke):
1699         (CppBoundClass::getProperty):
1700         (CppBoundClass::setProperty):
1701         (CppBoundClass::bindCallback):
1702         (CppBoundClass::bindProperty):
1703         * DumpRenderTree/chromium/WebPreferences.cpp:
1704         (applyFontMap):
1705         * DumpRenderTree/chromium/WebViewHost.cpp:
1706         (WebViewHost::printResourceDescription):
1707         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
1708         (AccessibilityController::~AccessibilityController):
1709         (AccessibilityController::winNotificationReceived):
1710         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1711         (ResourceLoadDelegate::descriptionSuitableForTestResult):
1712         * DumpRenderTree/win/TestRunnerWin.cpp:
1713         (worldIDForWorld):
1714         (TestRunner::evaluateScriptInIsolatedWorld):
1715         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
1716         (TestWebKitAPI::DOMWindowExtensionBasic::willDestroyPage):
1717         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
1718         (TestWebKitAPI::DOMWindowExtensionNoCache::willDestroyPage):
1719         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1720         (WTR::TestRunner::worldIDForWorld):
1721         (WTR::TestRunner::evaluateScriptInIsolatedWorld):
1722
1723 2012-08-27  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
1724
1725         Rename first/second to key/value in HashMap iterators
1726         https://bugs.webkit.org/show_bug.cgi?id=82784
1727
1728         Reviewed by Eric Seidel.
1729
1730         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
1731         (MockWebSpeechInputController::addMockRecognitionResult):
1732         * DumpRenderTree/chromium/NotificationPresenter.cpp:
1733         (NotificationPresenter::simulateClick):
1734         (NotificationPresenter::show):
1735         * DumpRenderTree/chromium/TestRunner/CppBoundClass.cpp:
1736         (CppBoundClass::~CppBoundClass):
1737         (CppBoundClass::invoke):
1738         (CppBoundClass::getProperty):
1739         (CppBoundClass::setProperty):
1740         (CppBoundClass::bindCallback):
1741         (CppBoundClass::bindProperty):
1742         * DumpRenderTree/chromium/WebPreferences.cpp:
1743         (applyFontMap):
1744         * DumpRenderTree/chromium/WebViewHost.cpp:
1745         (WebViewHost::printResourceDescription):
1746         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
1747         (AccessibilityController::~AccessibilityController):
1748         (AccessibilityController::winNotificationReceived):
1749         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1750         (ResourceLoadDelegate::descriptionSuitableForTestResult):
1751         * DumpRenderTree/win/TestRunnerWin.cpp:
1752         (worldIDForWorld):
1753         (TestRunner::evaluateScriptInIsolatedWorld):
1754         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
1755         (TestWebKitAPI::DOMWindowExtensionBasic::willDestroyPage):
1756         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
1757         (TestWebKitAPI::DOMWindowExtensionNoCache::willDestroyPage):
1758         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1759         (WTR::TestRunner::worldIDForWorld):
1760         (WTR::TestRunner::evaluateScriptInIsolatedWorld):
1761
1762 2012-08-24  James Robinson  <jamesr@chromium.org>
1763
1764         WebGL should not flip textures on presentation if contents are unchanged
1765         https://bugs.webkit.org/show_bug.cgi?id=94961
1766
1767         Reviewed by Kenneth Russell.
1768
1769         Run some compositing webgl tests in threaded mode to catch regressions specific to that mode.
1770
1771         * Scripts/webkitpy/layout_tests/port/chromium.py:
1772         (ChromiumPort.virtual_test_suites):
1773
1774 2012-08-27  Gavin Peters  <gavinp@chromium.org>
1775
1776         [webkit-patch] Don't crash chrome-channels command when a previously unknown platform shows up.
1777         https://bugs.webkit.org/show_bug.cgi?id=95104
1778
1779         Reviewed by Adam Barth.
1780
1781         Today I found out this command was broken by the new iOS platform showing up on omahaproxy. Now the webkit-patch chrome-channels command gracefully handles new, previously unknown platforms. Also, it prints iOS in the proper mixed case.
1782
1783         * Scripts/webkitpy/common/net/omahaproxy.py:
1784         (OmahaProxy):
1785         (OmahaProxy.get_revisions):
1786         * Scripts/webkitpy/common/net/omahaproxy_unittest.py:
1787         (OmahaProxyTest):
1788         (OmahaProxyTest.test_get_revisions):
1789
1790 2012-08-27  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1791
1792         [EFL][WK2] Free Url_Bar on program exit
1793         https://bugs.webkit.org/show_bug.cgi?id=95086
1794
1795         Reviewed by Eric Seidel.
1796
1797         Fix a memory leak by freeing the Url_Bar on program exit.
1798
1799         * MiniBrowser/efl/main.c:
1800         (main): Call url_bar_del() to free the Url_Bar.
1801
1802 2012-08-27  James Robinson  <jamesr@chromium.org>
1803
1804         [chromium] Fix exit code status logic in run-chromium-webkit-unit-tests
1805         https://bugs.webkit.org/show_bug.cgi?id=95115
1806
1807         Reviewed by Adam Barth.
1808
1809         Use VCSUtils utility function to check if webkit_unit_tests terminates normally so we generate a non-zero exit
1810         code if the unit tests crash.
1811
1812         * Scripts/run-chromium-webkit-unit-tests:
1813
1814 2012-08-27  Benjamin Poulain  <benjamin@webkit.org>
1815
1816         Add ECMAScript Number to String conversion to WTF::String
1817         https://bugs.webkit.org/show_bug.cgi?id=95016
1818
1819         Reviewed by Geoffrey Garen.
1820
1821         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
1822         (TestWebKitAPI::testNumberToStringECMAScript):
1823         (TestWebKitAPI): Add tests for String's ECMAString number conversion.
1824
1825 2012-08-27  Philippe Normand  <pnormand@igalia.com>
1826
1827         [GStreamer][Qt] WebAudio support
1828         https://bugs.webkit.org/show_bug.cgi?id=94806
1829
1830         Reviewed by Simon Hausmann.
1831
1832         * MiniBrowser/qt/qml/BrowserWindow.qml: Enable WebAudio support.
1833
1834 2012-08-27  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1835
1836         Rename RegisterProtocolHandler API to NavigatorContentUtils
1837         https://bugs.webkit.org/show_bug.cgi?id=94920
1838
1839         Reviewed by Adam Barth.
1840
1841         Renamed 'register-protocol-handler' feature to 'navigator-content-utils'.
1842
1843         * Scripts/webkitperl/FeatureList.pm:
1844         * qmake/mkspecs/features/features.pri:
1845
1846 2012-08-24  Benjamin Poulain  <bpoulain@apple.com>
1847
1848         Unify Number to StringImpl conversion
1849         https://bugs.webkit.org/show_bug.cgi?id=94879
1850
1851         Reviewed by Geoffrey Garen.
1852
1853         Add testing for the new IntegerToStringConversion.
1854
1855         * TestWebKitAPI/CMakeLists.txt:
1856         * TestWebKitAPI/GNUmakefile.am:
1857         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1858         * TestWebKitAPI/Tests/WTF/IntegerToStringConversion.cpp: Added.
1859
1860 2012-08-23  James Robinson  <jamesr@chromium.org>
1861
1862         [chromium] Convert WebLayerTreeView interface into pure virtual
1863         https://bugs.webkit.org/show_bug.cgi?id=94866
1864
1865         Reviewed by Adrienne Walker.
1866
1867         Updates DumpRenderTree's WebViewHost to vend a WebCompositorOutputSurface so DumpRenderTree can run compositing
1868         tests.
1869
1870         * DumpRenderTree/DumpRenderTree.gypi:
1871         * DumpRenderTree/chromium/WebViewHost.cpp:
1872         (WebViewHost::createOutputSurface):
1873         * DumpRenderTree/chromium/WebViewHost.h:
1874         (WebViewHost):
1875         * DumpRenderTree/chromium/WebViewHostOutputSurface.cpp: Copied from Source/WebKit/chromium/src/WebLayerTreeViewImpl.h.
1876         (WebKit):
1877         (WebKit::WebViewHostOutputSurface::WebViewHostOutputSurface):
1878         (WebKit::WebViewHostOutputSurface::~WebViewHostOutputSurface):
1879         (WebKit::WebViewHostOutputSurface::bindToClient):
1880         (WebKit::WebViewHostOutputSurface::capabilities):
1881         (WebKit::WebViewHostOutputSurface::context3D):
1882         (WebKit::WebViewHostOutputSurface::sendFrameToParentCompositor):
1883         * DumpRenderTree/chromium/WebViewHostOutputSurface.h: Copied from Source/WebKit/chromium/src/WebLayerTreeViewImpl.h.
1884         (WebKit):
1885         (WebViewHostOutputSurface):
1886
1887 2012-08-24  Xianzhu Wang  <wangxianzhu@chromium.org>
1888
1889         [Chromium-Android] Many 'Unexpected EOF ...' when a test crashes
1890         https://bugs.webkit.org/show_bug.cgi?id=94865
1891
1892         Reviewed by Dirk Pranke.
1893
1894         Android detects crash of test by checking if the return value of read() is None.
1895         Added a parameter 'treat_no_data_as_crash' to let ServerProcess know the special requirement of Android.
1896         If set, ServerProcess will set _crashed unconditionaly when there is no data.
1897
1898         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1899         (ChromiumAndroidPort.__init__):
1900         (ChromiumAndroidPort):
1901         (ChromiumAndroidPort._android_server_process_constructor):
1902         (ChromiumAndroidDriver._start_once):
1903         * Scripts/webkitpy/layout_tests/port/server_process.py:
1904         (ServerProcess.__init__):
1905         (ServerProcess._wait_for_data_and_update_buffers_using_select):
1906
1907 2012-08-24  Arnaud Renevier  <a.renevier@sisa.samsung.com>
1908
1909         build-webkit --gtk fails with Can't exec ""
1910         https://bugs.webkit.org/show_bug.cgi?id=94944
1911
1912         Reviewed by Martin Robinson.
1913
1914         When jhbuild wrapper is not needed, do unshift a blank string to build
1915         arguments.
1916
1917         * Scripts/webkitdirs.pm:
1918         (runAutogenForAutotoolsProjectIfNecessary):
1919
1920 2012-08-24  Tommy Widenflycht  <tommyw@google.com>
1921
1922         MediaStream API: Add readyState functionality to RTCPeerConnection
1923         https://bugs.webkit.org/show_bug.cgi?id=94813
1924
1925         Reviewed by Adam Barth.
1926
1927         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
1928         (MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
1929         (MockWebRTCPeerConnectionHandler::stop):
1930         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
1931         (MockWebRTCPeerConnectionHandler):
1932
1933 2012-08-24  Michael Brüning  <michaelbruening@gmail.com>
1934
1935         Unreviewed. Adding myself to committers list.
1936
1937         Also updated email information.
1938
1939         * Scripts/webkitpy/common/config/committers.py:
1940
1941 2012-08-24  Michael Brüning  <michaelbruening@gmail.com>
1942
1943         [Qt][WK2] Make viewport related experimental.test properties encapsulated.
1944         https://bugs.webkit.org/show_bug.cgi?id=88320
1945
1946         Reviewed by Kenneth Rohde Christiansen.
1947
1948         Changed the access to the viewport attributes to use the viewport object that is introduced by this change.
1949
1950         * MiniBrowser/qt/qml/ViewportInfoItem.qml:
1951
1952 2012-08-23  Dirk Pranke  <dpranke@chromium.org>
1953
1954         leak detection broken after r126247 on mac
1955         https://bugs.webkit.org/show_bug.cgi?id=94893
1956
1957         Unreviewed, build fix.
1958
1959         Adds is_snowleopard(), is_lion back() in for the mac port. We'll
1960         probably need an is_mountainlion() or equivalent at some point,
1961         I'm guessing (but I've deleted the leopard code).
1962
1963         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
1964         (LeakDetector._callstacks_to_exclude_from_leaks):
1965         * Scripts/webkitpy/layout_tests/port/mac.py:
1966         (MacPort):
1967         (MacPort.is_snowleopard):
1968         (MacPort.is_lion):
1969
1970 2012-08-23  Julien Chaffraix  <jchaffraix@webkit.org>
1971
1972         [Chromium] Enable AtomicString && CString && WTFString && StringImpl unit tests
1973         https://bugs.webkit.org/show_bug.cgi?id=94871
1974
1975         Reviewed by Benjamin Poulain.
1976
1977         * TestWebKitAPI/TestWebKitAPI.gypi:
1978         Added the missing files to Chromium's build system.
1979
1980 2012-08-23  Raphael Kubo da Costa  <rakuco@webkit.org>
1981
1982         [watchlist] Unreviewed, subscribe to WebKit2-EFL bugs.
1983
1984         * Scripts/webkitpy/common/config/watchlist:
1985
1986 2012-08-23  Ryosuke Niwa  <rniwa@webkit.org>
1987
1988         Replay tests take forever to load
1989         https://bugs.webkit.org/show_bug.cgi?id=94764
1990
1991         Reviewed by Adam Barth.
1992
1993         Don't load about:blank at the beginning. This appears to clog the DRT.
1994
1995         * Scripts/webkitpy/performance_tests/perftest.py:
1996         (ReplayPerfTest.run_single):
1997         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1998         (TestReplayPerfTest.test_run_single):
1999         (TestReplayPerfTest.test_run_single_fails_when_output_has_error):
2000
2001 2012-08-23  Kenneth Russell  <kbr@google.com>
2002
2003         Unreviewed, rolling out r126497.
2004         http://trac.webkit.org/changeset/126497
2005         https://bugs.webkit.org/show_bug.cgi?id=94764
2006
2007         Caused webkitpy-test step to start failing.
2008
2009         * Scripts/webkitpy/performance_tests/perftest.py:
2010         (ReplayPerfTest.run_single):
2011
2012 2012-08-23  Emil A Eklund  <eae@chromium.org>
2013
2014         Add saturation arithmetic support to FractionalLayoutUnit
2015         https://bugs.webkit.org/show_bug.cgi?id=94364
2016
2017         Reviewed by Benjamin Poulain.
2018
2019         Add test for new saturatedArithmetic functions.
2020
2021         * TestWebKitAPI/CMakeLists.txt:
2022         * TestWebKitAPI/GNUmakefile.am:
2023         * TestWebKitAPI/TestWebKitAPI.gypi:
2024         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2025         * TestWebKitAPI/Tests/WTF/SaturatedArithmeticOperations.cpp: Added.
2026         (TestWebKitAPI):
2027         (TestWebKitAPI::TEST):
2028         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2029
2030 2012-08-23  Ryosuke Niwa  <rniwa@webkit.org>
2031
2032         Replay tests take forever to load
2033         https://bugs.webkit.org/show_bug.cgi?id=94764
2034
2035         Reviewed by Adam Barth.
2036
2037         Don't load about:blank at the beginning. This appears to clog the DRT.
2038
2039         * Scripts/webkitpy/performance_tests/perftest.py:
2040         (ReplayPerfTest.run_single):
2041
2042 2012-08-23  Wei Jia  <wjia@chromium.org>
2043
2044         create different WebKit::WebMediaPlayer based on URL
2045         https://bugs.webkit.org/show_bug.cgi?id=91301
2046
2047         Reviewed by Adam Barth.
2048
2049         Pass URL to createMediaPlayer. This corresponds to change in base
2050         class WebKit::WebFrameClient.
2051
2052         * DumpRenderTree/chromium/WebViewHost.cpp:
2053         (WebViewHost::createMediaPlayer): add URL as additional argument.
2054         * DumpRenderTree/chromium/WebViewHost.h:
2055         (WebViewHost):
2056
2057 2012-08-23  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2058
2059         Unreviewed, upgrade gyuyoung to reviewer.
2060         http://lists.webkit.org/pipermail/webkit-dev/2012-August/022004.html
2061
2062         * Scripts/webkitpy/common/config/committers.py:
2063
2064 2012-08-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2065
2066         REGRESSION(r126306): it broke the plugin process
2067         https://bugs.webkit.org/show_bug.cgi?id=94797
2068
2069         Reviewed by Xan Lopez.
2070
2071         * GNUmakefile.am:
2072
2073 2012-08-23  Ryuan Choi  <ryuan.choi@samsung.com>
2074
2075         [EFL] Add url bar to EWebLauncher and MiniBrowser/Efl.
2076         https://bugs.webkit.org/show_bug.cgi?id=63966
2077
2078         Reviewed by Kenneth Rohde Christiansen.
2079
2080         EWebLauncher and MiniBrowser/Efl did not have functionality that users
2081         navigates the site which they want.
2082         This patch adds the urlbar and functionality to load url which users want.
2083
2084         * CMakeLists.txt:
2085         Added to share urlbar theme for both EWebLauncher and MiniBrowser/Efl.
2086         * EWebLauncher/CMakeLists.txt:
2087         Added urlbar.c and dependency of urlbar theme.
2088         In addition, changed macro name to THEME_DIR to share the code easily.
2089         * EWebLauncher/ControlTheme/CMakeLists.txt: Added for urlbar theme.
2090         * EWebLauncher/ControlTheme/entry.edc: Implemented urlbar theme.
2091         * EWebLauncher/main.c:
2092         Implemented to use the urlbar.
2093         In addition, remove unnecessary border of webview to control webview and urlbar easily.
2094         (_ELauncher):
2095         (on_url_changed):
2096         (browserCreate):
2097         (closeWindow):
2098         (findThemePath):
2099         * EWebLauncher/url_bar.c: Implemented functionality of the urlbar.
2100         (_url_bar_url_get_with_protocol):
2101         (on_urlbar_key_down):
2102         (on_urlbar_mouse_down):
2103         (on_urlbar_focus_out):
2104         (url_bar_add):
2105         (url_bar_del):
2106         (url_bar_url_set):
2107         * EWebLauncher/url_bar.h: Added.
2108         * MiniBrowser/efl/CMakeLists.txt:
2109         * MiniBrowser/efl/main.c: Implemented to use the urlbar.
2110         (_MiniBrowser):
2111         (on_url_changed):
2112         (browserCreate):
2113
2114 2012-08-23  Balazs Kelemen  <kbalazs@webkit.org>
2115
2116         [nrwt, WTR] Remove workaround for timeout handing from r126062
2117         https://bugs.webkit.org/show_bug.cgi?id=94609
2118
2119         Reviewed by Dirk Pranke.
2120
2121         Don't try to reset state if a timeout occured but inform
2122         the harness that the web process is no longer reliable.
2123
2124         * Scripts/webkitpy/layout_tests/port/driver.py:
2125         (Driver.run_test): Remove the workaround. Furthermore, handle the case when
2126         the pid is unknown.
2127         * WebKitTestRunner/TestController.cpp:
2128         (WTR::TestController::run):
2129         * WebKitTestRunner/TestInvocation.cpp:
2130         (WTR::TestInvocation::invoke):
2131         (WTR::TestInvocation::dumpWebProcessUnresponsiveness):
2132         * WebKitTestRunner/TestInvocation.h:
2133         (TestInvocation):
2134
2135 2012-08-23  Ádám Kallai  <kadam@inf.u-szeged.hu>
2136
2137         Unreviewed. Adding myself to committers list.
2138
2139         * Scripts/webkitpy/common/config/committers.py:
2140
2141 2012-08-22  Alexis Menard  <alexis@webkit.org>
2142
2143         Unreviewed update of my email.
2144
2145         * Scripts/webkitpy/common/config/committers.py:
2146         * Scripts/webkitpy/common/config/watchlist:
2147
2148 2012-08-22  Dirk Pranke  <dpranke@chromium.org>
2149
2150         Fix typos in r126374
2151         https://bugs.webkit.org/show_bug.cgi?id=94665
2152         Unreviewed, build fix.
2153
2154         Fix two issues that snuck in, one that caused a crash if there
2155         were no baselines to optimize and one that occurred as a result
2156         of failing to rename a variable when I changed the recursion to
2157         a loop in the previous patch.
2158
2159         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
2160         (BaselineOptimizer._optimize_by_pushing_results_up):
2161
2162 2012-08-22  Dirk Pranke  <dpranke@chromium.org>
2163
2164         Baseline optimizer should try to optimize per-port if global optimization fails
2165         https://bugs.webkit.org/show_bug.cgi?id=94665
2166
2167         Reviewed by Adam Barth.
2168
2169         Add a fallback strategy for optimizing baselines if the default
2170         one fails; this one simply attempts to shift baselines up in the
2171         tree and consolidates them if a parent and child in the fallback
2172         path have the same result. This strategy is somewhat flawed in
2173         that we will always put something in a parent dir even if we
2174         "shouldn't"; for example, if chromium-mac produces a different
2175         result from chromium-win and chromium-linux, then the new
2176         algorithm will move the mac result into platform/chromium,
2177         leaving chromium-mac empty. This result is still correct, but
2178         perhaps confusing.
2179
2180         I haven't done much testing of this algorithm yet, so it's not
2181         clear how many cases where this does a better job than the
2182         default algorithm and how many it'll do a worse job.
2183
2184         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
2185         (BaselineOptimizer._find_optimal_result_placement):
2186         (BaselineOptimizer._optimize_by_most_specific_common_directory):
2187         (BaselineOptimizer):
2188         (BaselineOptimizer._optimize_by_pushing_results_up):
2189         (BaselineOptimizer._find_in_fallbackpath):
2190         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
2191         (BaselineOptimizerTest.test_platform_mac_different):
2192
2193 2012-08-22  Dirk Pranke  <dpranke@chromium.org>
2194
2195         add debug info, another test to webkit-patch optimize-baselines
2196         https://bugs.webkit.org/show_bug.cgi?id=94762
2197
2198         Reviewed by Adam Barth.
2199
2200         This patch adds more debug logging for optimize-baselines so
2201         that you can tell the before and after states and figure out
2202         what the command is actually deciding to do.
2203
2204         Also, this command adds a (disabled) test for the problem in bug
2205         94665. It's disabled because we don't have the fix yet (that
2206         will be posted in a patch to that bug).
2207
2208         There should be no functional changes in this patch apart from
2209         the additional logging.
2210
2211         Note that adding the debug logging exposed a bug in
2212         filesystem_mock.relpath() (that would return None if the path
2213         wasn't a subpath of the start); the real relpath computes a
2214         relpath with parent dirs. Fixing this revealed a bad check in
2215         the style checker's change_directory() call which was checking
2216         for None.
2217
2218         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
2219         (BaselineOptimizer._find_optimal_result_placement):
2220         (BaselineOptimizer):
2221         (BaselineOptimizer._optimize_by_most_specific_common_directory):
2222         (BaselineOptimizer._move_baselines):
2223         (BaselineOptimizer.optimize):
2224         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
2225         (BaselineOptimizerTest.disabled_test_platform_mac_different):
2226         * Scripts/webkitpy/common/system/filesystem.py:
2227         (FileSystem):
2228         * Scripts/webkitpy/common/system/filesystem_mock.py:
2229         (MockFileSystem):
2230         (MockFileSystem.__init__):
2231         (MockFileSystem.relpath):
2232         * Scripts/webkitpy/common/system/filesystem_unittest.py:
2233         (RealFileSystemTest.test_sep):
2234         * Scripts/webkitpy/style/main.py:
2235         (change_directory):
2236
2237 2012-08-22  Alejandro Piñeiro  <apinheiro@igalia.com>
2238
2239         Dojo toggle buttons should expose ROLE_TOGGLE_BUTTON not ROLE_PUSH_BUTTON
2240         https://bugs.webkit.org/show_bug.cgi?id=73819
2241
2242         Reviewed by Chris Fleizach.
2243
2244         Added a new role, Toggle Button, based on whether aria-pressed is present.
2245         http://www.w3.org/TR/wai-aria/states_and_properties#aria-pressed
2246
2247         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
2248         (roleToString): added "ToggleButton" string for WebAccessibilityRoleToggleButton
2249
2250 2012-08-23  Victor Carbune  <victor@rosedu.org>
2251
2252         Add myself to the committer list
2253         https://bugs.webkit.org/show_bug.cgi?id=94659
2254
2255         Reviewed by James Robinson.
2256
2257         Added my email and IRC handle.
2258
2259         * Scripts/webkitpy/common/config/committers.py:
2260
2261 2012-08-22  Scott Graham  <scottmg@chromium.org>
2262
2263         Don't unconditionally define NOMINMAX on Windows
2264         https://bugs.webkit.org/show_bug.cgi?id=94742
2265
2266         Reviewed by Adrienne Walker.
2267
2268         Avoids a warning when building on Windows when NOMINMAX is defined
2269         elsewhere or on the command line.
2270
2271         * TestWebKitAPI/config.h:
2272
2273 2012-08-22  Zan Dobersek  <zandobersek@gmail.com>
2274
2275         REGRESSION(r126189): Reftest mismatches are (again) run through ImageDiff with 0.1 tolerance
2276         https://bugs.webkit.org/show_bug.cgi?id=94704
2277
2278         Reviewed by Dirk Pranke.
2279
2280         Use tolerance=0 when acquiring diff image of reftest output.
2281
2282         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2283         (SingleTestRunner._compare_output_with_reference):
2284
2285 2012-08-22  Tommy Widenflycht  <tommyw@google.com>
2286
2287         [chromium] MediaStream API: Add MockWebRTCPeerConnectionHandler
2288         https://bugs.webkit.org/show_bug.cgi?id=93091
2289
2290         Reviewed by Adam Barth.
2291
2292         Add a skeleton MockWebRTCPeerConnectionHandler to DumpRenderTree,
2293         to complete the infrastructure for RTCPeerConnection.
2294
2295         * DumpRenderTree/DumpRenderTree.gypi:
2296         * DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp:
2297         (MockWebKitPlatformSupport::createRTCPeerConnectionHandler):
2298         * DumpRenderTree/chromium/MockWebKitPlatformSupport.h:
2299         (MockWebKitPlatformSupport):
2300         * DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp:
2301         * DumpRenderTree/chromium/MockWebMediaStreamCenter.h:
2302         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp: Copied from Tools/DumpRenderTree/chromium/MockWebKitPlatformSupport.h.
2303         (MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
2304         (MockWebRTCPeerConnectionHandler::initialize):
2305         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h: Copied from Tools/DumpRenderTree/chromium/MockWebKitPlatformSupport.h.
2306         (WebKit):
2307         (MockWebRTCPeerConnectionHandler):
2308         (MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
2309
2310 2012-08-21  Ryosuke Niwa  <rniwa@webkit.org>
2311
2312         Merge TestExpectationSerializer into TestExpectationLine
2313         https://bugs.webkit.org/show_bug.cgi?id=94638
2314
2315         Reviewed by Dimitri Glazkov.
2316
2317         Moved all methods except, list_to_string which was moved to TestExpectations
2318         from TestExpectationSerializer to TestExpectationLine and removed TestExpectationSerializer.
2319
2320         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:
2321         (TestExpectationEditorTests.assert_remove_roundtrip):
2322         (TestExpectationEditorTests.assert_update_roundtrip):
2323         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2324         (ParseError.__repr__):
2325         (TestExpectationLine):
2326         (TestExpectationLine.create_passing_expectation):
2327         (TestExpectationLine.to_string): Moved from TestExpectationSerializer.
2328         (TestExpectationLine.to_csv): Ditto.
2329         (TestExpectationLine._serialize_parsed_expectations): Ditto.
2330         (TestExpectationLine._serialize_parsed_modifiers): Ditto.
2331         (TestExpectationLine._format_line):
2332         (TestExpectations.remove_configuration_from_test):
2333         (TestExpectations.remove_rebaselined_tests):
2334         (TestExpectations.add_skipped_tests):
2335         (TestExpectations):
2336         (TestExpectations.list_to_string): Moved from TestExpectationSerializer.
2337         (TestExpectations.list_to_string.serialize):
2338         (TestExpectations.list_to_string.nones_out):
2339         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2340         (TestExpectationSerializationTests): Renamed from TestExpectationSerializerTests.
2341         (TestExpectationSerializationTests.__init__):
2342         (TestExpectationSerializationTests.assert_round_trip):
2343         (TestExpectationSerializationTests.assert_list_round_trip):
2344         (TestExpectationSerializationTests.test_unparsed_to_string):
2345         (TestExpectationSerializationTests.test_unparsed_list_to_string):
2346         (TestExpectationSerializationTests.test_parsed_to_string):
2347         (TestExpectationSerializationTests.test_serialize_parsed_expectations):
2348         (TestExpectationSerializationTests.test_serialize_parsed_modifier_string):
2349         (TestExpectationSerializationTests.test_format_line):
2350         (TestExpectationSerializationTests.test_reconstitute_only_these):
2351         * Scripts/webkitpy/tool/commands/expectations.py:
2352         (OptimizeExpectations.execute):
2353         * Scripts/webkitpy/tool/commands/queries.py:
2354         (PrintExpectations.execute):
2355         (PrintExpectations._format_lines):
2356         * Scripts/webkitpy/tool/servers/gardeningserver.py:
2357         (GardeningExpectationsUpdater.update_expectations):
2358
2359 2012-08-22  Alexandre Elias  <aelias@chromium.org>
2360
2361         Unreviewed, add aelias@chromium.org to committers
2362
2363         I (aelias@chromium.org) have been approved for commit access and Apple
2364         has confirmed receipt of my committer agreement.
2365
2366         * Scripts/webkitpy/common/config/committers.py:
2367
2368 2012-08-22  Alexey Proskuryakov  <ap@apple.com>
2369
2370         [WK2] Support posting injected bundle messages to a page
2371         https://bugs.webkit.org/show_bug.cgi?id=94630
2372
2373         Reviewed by Sam Weinig.
2374
2375         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
2376         * TestWebKitAPI/InjectedBundleController.cpp:
2377         (TestWebKitAPI::InjectedBundleController::initialize):
2378         (TestWebKitAPI::InjectedBundleController::didReceiveMessageToPage):
2379         * TestWebKitAPI/InjectedBundleController.h:
2380         * TestWebKitAPI/InjectedBundleTest.h:
2381         (TestWebKitAPI::InjectedBundleTest::didReceiveMessageToPage):
2382         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2383         (WTR::InjectedBundle::didReceiveMessage):
2384         (WTR::InjectedBundle::didReceiveMessageToPage):
2385         (WTR::InjectedBundle::initialize):
2386         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2387         Updated for new client API call.
2388
2389 2012-08-22  Dominic Mazzoni  <dmazzoni@google.com>
2390
2391         REGRESSION (r125710): accessibility/accessibility-node-reparent.html, accessibility/accessibility-node-memory-management.html failing on GTK Linux
2392         https://bugs.webkit.org/show_bug.cgi?id=94200
2393
2394         Reviewed by Chris Fleizach.
2395
2396         Adds reference counting for AtkObjects referenced by
2397         AccessibilityUIElementGtk. This prevents bogus results and
2398         assertion failures on AccessibilityUIElements whose underlying
2399         object has been deleted (as opposed to just made defunct).
2400
2401         This fixes two tests that were previously failing because of this bug.
2402
2403         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2404         (AccessibilityUIElement::AccessibilityUIElement):
2405         (AccessibilityUIElement::~AccessibilityUIElement):
2406
2407 2012-08-22  Gustavo Noronha Silva  <gns@gnome.org>
2408
2409         [GTK] Split WebCore/platform into a separate library
2410         https://bugs.webkit.org/show_bug.cgi?id=94435
2411
2412         Reviewed by Martin Robinson.
2413
2414         More people have been reporting problems when linking WebCore because
2415         the command line limit is being exceeded. Splitting WebCore a bit more
2416         is in order.
2417
2418         * GNUmakefile.am: link libWebCorePlatform into DRT
2419
2420 2012-08-22  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
2421
2422         Unreviewed buildfix for Qt-minimal after r126291
2423
2424         Disable smooth scrolling when request-animation-frame has been disabled either
2425         explicitly or as part of --minimal.
2426
2427         * qmake/mkspecs/features/features.prf:
2428
2429 2012-08-22  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
2430
2431         [Qt] Optionally support smooth-scrolling on all platforms
2432         https://bugs.webkit.org/show_bug.cgi?id=74926
2433
2434         Reviewed by Simon Hausmann.
2435
2436         Enabled SMOOTH_SCROLLING on Qt, and expose the enable scroll animator
2437         setting in QtTestBrowser so it can be tested.
2438
2439         * QtTestBrowser/launcherwindow.cpp:
2440         (LauncherWindow::createChrome):
2441         (LauncherWindow::toggleScrollAnimator):
2442         * QtTestBrowser/launcherwindow.h:
2443         (WindowOptions::WindowOptions):
2444         (WindowOptions):
2445         (LauncherWindow):
2446         * qmake/mkspecs/features/features.pri:
2447
2448 2012-08-22  Dominik Röttsches  <dominik.rottsches@intel.com>
2449
2450         Unreviewed, adding myself to committers.py.
2451
2452         * Scripts/webkitpy/common/config/committers.py:
2453
2454 2012-08-21  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2455
2456         [GTK] contextClick and getMenuItemTitle callbacks are leaky in DRT's EventSender
2457         https://bugs.webkit.org/show_bug.cgi?id=94669
2458
2459         Reviewed by Carlos Garcia Campos.
2460
2461         Fix memory leaks in DRT's EventSender code.
2462
2463         * DumpRenderTree/gtk/EventSender.cpp:
2464         (getMenuItemTitleCallback): Use JSRetainPtr and don't leak.
2465         (contextClickCallback): Use GOwnPtr to manage memory of a
2466         newly-allocated list automatically.
2467
2468 2012-08-21  Dirk Pranke  <dpranke@chromium.org>
2469
2470         Add mountain lion to perf-tests, layout tests
2471         https://bugs.webkit.org/show_bug.cgi?id=94553
2472
2473         Reviewed by Adam Barth.
2474
2475         This patch adds support for the 'mac-mountainlion' platform and
2476         stamps out the last references to 'mac-leopard' as a supported
2477         name.
2478         
2479         This patch does a small amount of refactoring to try and make
2480         things a little clearer how we treat the "most recent version"
2481         specially for baselines and skipped files, and so you only
2482         should have to touch the VERSION_FALLBACK_ORDER constants on the
2483         ports, but unfortunately changing this list changes a bunch of
2484         the unit tests which are doing exact matches for correctness, so
2485         you have to touch more than a couple files :(. There's probably
2486         still more refactoring that can be done so that we don't have to
2487         do all of this functional testing to feel completely correct.
2488
2489         * Scripts/webkitpy/common/system/platforminfo.py:
2490         (PlatformInfo._determine_mac_version):
2491         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
2492         (TestPlatformInfo.test_os_version):
2493         * Scripts/webkitpy/layout_tests/port/apple.py:
2494         (ApplePort.__init__):
2495         (ApplePort):
2496         (ApplePort._skipped_file_search_paths):
2497         (ApplePort._generate_all_test_configurations):
2498         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2499         (ChromiumMacPort):
2500         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
2501         (FactoryTest.test_mac):
2502         * Scripts/webkitpy/layout_tests/port/mac.py:
2503         (MacPort):
2504         (MacPort._build_driver_flags):
2505         (MacPort.should_retry_crashes):
2506         (MacPort.default_baseline_search_path):
2507         (MacPort.operating_system):
2508         (MacPort.default_child_processes):
2509         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2510         (MacTest):
2511         (MacTest.test_skipped_file_search_paths):
2512         (test_versions):
2513         (test_baseline_search_path):
2514         * Scripts/webkitpy/layout_tests/port/win.py:
2515         (WinPort):
2516         (WinPort.default_baseline_search_path):
2517
2518 2012-08-21  Zan Dobersek  <zandobersek@gmail.com>
2519
2520         [GTK] fast/xmlhttprequest/xmlhttprequest-nonexistent-file.html is failing
2521         https://bugs.webkit.org/show_bug.cgi?id=94617
2522
2523         Reviewed by Martin Robinson.
2524
2525         Set the 'enable-file-access-from-file-uris' setting to true when
2526         resetting default values. The other ports do this as well, giving
2527         documents with local security origin permission to load other
2528         local resources.
2529
2530         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2531         (resetDefaultsToConsistentValues):
2532
2533 2012-08-21  Kent Tamura  <tkent@chromium.org>
2534
2535         [Chromium] DRT produces wrong back-forward list
2536         https://bugs.webkit.org/show_bug.cgi?id=94575
2537
2538         Reviewed by Adam Barth.
2539
2540         DRT clears its history state before running every tests. However
2541         HistoryController in WebCore isn't reset. So, it is possible that
2542         'isNewNavigation' flag is false even though the navigation should be
2543         handled as "new" for DRT.
2544
2545         This change might fix a problem of
2546         fast/forms/select/select-state-restore.html (Bug 90207).
2547
2548         * DumpRenderTree/chromium/WebViewHost.cpp:
2549         (WebViewHost::updateForCommittedLoad):
2550         Treat the first page load (m_pageID == -1) as new navigation except for about:blank.
2551         Without this change, a navigation entry for this loading won't be recorded.
2552
2553 2012-08-21  Thiago Marcos P. Santos  <thiago.santos@intel.com>
2554
2555         [EFL] Enable CSS Text Decoration by default
2556         https://bugs.webkit.org/show_bug.cgi?id=94483
2557
2558         Reviewed by Kenneth Rohde Christiansen.
2559
2560         * Scripts/webkitperl/FeatureList.pm:
2561
2562 2012-08-21  Benjamin Poulain  <bpoulain@apple.com>
2563
2564         Store CString data in the CStringBuffer to avoid the double indirection
2565         https://bugs.webkit.org/show_bug.cgi?id=94562
2566
2567         Reviewed by Darin Adler.
2568
2569         Add test coverage for WTF::CString.
2570
2571         * TestWebKitAPI/CMakeLists.txt:
2572         * TestWebKitAPI/GNUmakefile.am:
2573         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2574         * TestWebKitAPI/Tests/WTF/CString.cpp:
2575
2576 2012-08-21  Dirk Pranke  <dpranke@chromium.org>
2577
2578         Text Autosizing: ::first-letter pseudo-element is incorrectly sized
2579         https://bugs.webkit.org/show_bug.cgi?id=94540
2580
2581         Reviewed by Ojan Vafai.
2582
2583         Revert the changes in bugs 94517 and 94396 so that we are
2584         actually looking for stderr output from ImageDiff and doing
2585         image compares on ref tests on the wk2 ports again.
2586
2587         Also, do an actual diff_image() call if the hash checks fail on
2588         reftests, and only fail the test if we get real diffs (or don't,
2589         for mismatches).
2590
2591         Lastly, clean up the log messages to be more helpful.
2592
2593         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2594         (SingleTestRunner._compare_image):
2595         (SingleTestRunner._compare_output_with_reference):
2596         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2597         (write_test_result):
2598
2599 2012-08-21  Dirk Pranke  <dpranke@chromium.org>
2600
2601         _compare_image() swaps actual and expected images by mistake
2602         https://bugs.webkit.org/show_bug.cgi?id=94567
2603
2604         Reviewed by Ojan Vafai.
2605
2606         Re-work the code so that we consistently pass (expected, actual)
2607         across all of the compare/diff routines.
2608
2609         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2610         (SingleTestRunner._run_compare_test):
2611         (SingleTestRunner._compare_output):
2612         (SingleTestRunner._compare_text):
2613         (SingleTestRunner._compare_audio):
2614         (SingleTestRunner._compare_image):
2615         (SingleTestRunner._run_reftest):
2616         (SingleTestRunner._compare_output_with_reference):
2617         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2618         (write_test_result):
2619
2620 2012-08-21  Adam Barth  <abarth@webkit.org>
2621
2622         Unreviewed. Move the commit-queue to building release only. Previously,
2623         we built debug too, but for some reason the debug build doesn't work on
2624         the bots. We can re-enable debug builds once we fix the underlying
2625         problem.
2626
2627         * Scripts/webkitpy/tool/commands/queues.py:
2628         (CommitQueue.build_style):
2629         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2630
2631 2012-08-21  Ryosuke Niwa  <rniwa@webkit.org>
2632
2633         TestExpectationsParser doesn't warn about test files that don't exist.
2634         https://bugs.webkit.org/show_bug.cgi?id=94632
2635
2636         Reviewed by Dirk Pranke.
2637
2638         Exit early and warn when the test file doesn't exist as well when a test directory doesn't exist.
2639
2640         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2641         (TestExpectationParser._parse_line):
2642         (TestExpectationParser._check_test_exists):
2643         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2644         (test_parse_warning):
2645
2646 2012-08-20  Ryosuke Niwa  <rniwa@webkit.org>
2647
2648         Move free functions in test_expectations to TestExpectations class
2649         https://bugs.webkit.org/show_bug.cgi?id=94557
2650
2651         Reviewed by Dirk Pranke.
2652
2653         Moved test_result_was_expected, test_remove_pixel_failures, and test_suffixes_for_expectations into TestExpectations
2654         to allow further refactoring.
2655
2656         * Scripts/webkitpy/common/net/resultsjsonparser.py:
2657         (JSONTestResult.did_run_as_expected):
2658         (JSONTestResult._tokenize):
2659         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2660         (TestExpectations):
2661         (TestExpectations.result_was_expected):
2662         (TestExpectations.remove_pixel_failures):
2663         (TestExpectations.has_pixel_failures):
2664         (TestExpectations.suffixes_for_expectations):
2665         (TestExpectations.matches_an_expected_result):
2666         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2667         (MockBugManager.create_bug):
2668         (test_result_was_expected):
2669         (test_remove_pixel_failures):
2670         (test_suffixes_for_expectations):
2671         * Scripts/webkitpy/tool/commands/rebaseline.py:
2672         (RebaselineExpectations._tests_to_rebaseline):
2673
2674 2012-08-21  Simon Hausmann  <simon.hausmann@nokia.com>
2675
2676         Unreviewed build fix for newer Qt 5: The meaning of private_includes changed to be fully
2677         self-contained. The module name is not appended automatically anymore.
2678
2679         * qmake/qt_webkit.pri:
2680
2681 2012-08-20  Xianzhu Wang  <wangxianzhu@chromium.org>
2682
2683         [Chromium-Android] Add stop_when_done parameter to ChromiumAndroidDriver.run_test()
2684         https://bugs.webkit.org/show_bug.cgi?id=94558
2685
2686         Reviewed by Dirk Pranke.
2687
2688         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2689         (ChromiumAndroidDriver.run_test):
2690
2691 2012-08-20  Ryosuke Niwa  <rniwa@webkit.org>
2692
2693         Cleanup TestExpectationParser.parse
2694         https://bugs.webkit.org/show_bug.cgi?id=94545
2695
2696         Reviewed by Dirk Pranke.
2697
2698         Refactor TestExpectations to simplify the code.
2699
2700         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2701         (TestExpectationParser.parse): Merged _tokenize_list.
2702         (TestExpectationParser._parse_line): Removed the call to _check_modifiers_against_expectations
2703         since the check is now done in _parser_modifiers.
2704         (TestExpectationParser._parse_modifiers): Merged _check_modifiers_against_expectations.
2705         (TestExpectationParser._tokenize_line): Renamed from _tokenize.
2706         (TestExpectationParser._split_space_separated): No longer calls lower() on all modifiers.
2707         This is done on a local variable in _parse_modifiers, preserving the original case.
2708         (TestExpectations.remove_rebaselined_tests.without_rebaseline_modifier): Check the existence
2709         of 'rebaseline' against parsed modifiers.
2710         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2711         (TestExpectationParserTests._tokenize):
2712         (TestExpectationParserTests.test_tokenize_valid_with_comment): Preserves case.
2713         (TestExpectationParserTests.test_tokenize_valid_with_multiple_modifiers): Ditto.
2714         (TestExpectationSerializerTests._tokenize):
2715         (TestExpectationSerializerTests.assert_list_round_trip): Call parse since _tokenize_list has
2716         been merged into parse.
2717         * Scripts/webkitpy/tool/commands/queries_unittest.py:
2718         (PrintExpectationsTest.test_csv): Preserves the case.
2719
2720 2012-08-20  Gustavo Noronha Silva  <gns@gnome.org>
2721
2722         [jhbuild] EFL now runs jhbuild update for every build
2723         https://bugs.webkit.org/show_bug.cgi?id=94267
2724
2725         Reviewed by Martin Robinson.
2726
2727         Try to fix WinCE build by returning the empty string instead of
2728         env when no jhbuild infrastructure is found.
2729
2730         * Scripts/webkitdirs.pm:
2731         (jhbuildWrapperPrefixIfNeeded):
2732
2733 2012-08-20  Benjamin Poulain  <benjamin@webkit.org>
2734
2735         Add a watcher for WTF changes
2736
2737         Unreviewed.
2738
2739         Add myself as a watcher for changes in WTF.
2740
2741         * Scripts/webkitpy/common/config/watchlist:
2742
2743 2012-08-20  Thiago Marcos P. Santos  <thiago.santos@intel.com>
2744
2745         [EFL] Move jhbuild dependencies based on SVN to tarballs
2746         https://bugs.webkit.org/show_bug.cgi?id=90374
2747
2748         Reviewed by Kenneth Rohde Christiansen.
2749
2750         Moved all the dependencies based on SVN to tarballs taken from a
2751         equivalent snapshot from the official git mirror. This will make
2752         update-webkitefl not dependent on network connection after the first
2753         run. The bots will not fail if EFL SVN server in unreachable.
2754         The reason why git mirror is not used directly is to minimize the
2755         total size of source code we need to download.
2756
2757         * efl/jhbuild.modules:
2758
2759 2012-08-20  Simon Fraser  <simon.fraser@apple.com>
2760
2761         Lots of "error, test and reference image have different properties" in pixel test output
2762         https://bugs.webkit.org/show_bug.cgi?id=92578
2763
2764         Reviewed by Dirk Pranke.
2765
2766         Improve ImageDiff's error reporting when test result image and expected image
2767         differ in their properties.
2768
2769         * DumpRenderTree/cg/ImageDiffCG.cpp:
2770
2771 2012-08-20  Nate Chapin  <japhet@chromium.org>
2772
2773         Unsafe vsprintf usage in TestNetscapePlugin
2774         https://bugs.webkit.org/show_bug.cgi?id=94522
2775
2776         Reviewed by Adam Barth.
2777
2778         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2779         (pluginLogWithArguments): Using vsnprintf instead of vsprintf to ensure we don't overflow
2780             the message buffer.
2781         (testDocumentOpen):
2782         (testWindowOpen):
2783
2784 2012-08-20  George Staikos  <staikos@webkit.org>
2785
2786         [BlackBerry] Enable XHR Response BLOB
2787         https://bugs.webkit.org/show_bug.cgi?id=94525
2788
2789         Reviewed by Rob Buis.
2790
2791         Turn on the XHR response blob feature for the BlackBerry port.
2792
2793         * Scripts/webkitperl/FeatureList.pm: Add the feature and enable it.
2794
2795 2012-08-20  Dirk Pranke  <dpranke@chromium.org>
2796
2797         Fix change for timeout detection to not crash if we have no output :)
2798         https://bugs.webkit.org/show_bug.cgi?id=94505
2799
2800         Unreviewed, build fix.
2801
2802         * Scripts/webkitpy/layout_tests/port/driver.py:
2803         (Driver.run_test):
2804
2805 2012-08-20  Dirk Pranke  <dpranke@chromium.org>
2806
2807         temporarily disable ImageDiff on WK2 ports for ref tests
2808         https://bugs.webkit.org/show_bug.cgi?id=94517
2809
2810         Reviewed by Brady Eidson.
2811
2812         ImageDiff appears to be unable to handle the pngs returned from
2813         WebKitTestRunner, so we disable checking images by default
2814         for ref tests on wk2 ports (unless pixel tests is explicitly enabled).
2815
2816         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2817         (SingleTestRunner._compare_output_with_reference):
2818
2819 2012-08-20  Dirk Pranke  <dpranke@chromium.org>
2820
2821         Add missing FIXME: to previous change.
2822         https://bugs.webkit.org/show_bug.cgi?id=94505
2823
2824         Reviewed by Ojan Vafai.
2825
2826         * Scripts/webkitpy/layout_tests/port/driver.py:
2827         (Driver.run_test):
2828
2829 2012-08-20  Dirk Pranke  <dpranke@chromium.org>
2830
2831         Intermittenly, many WebKit2 tests have results from the wrong test compared to the test just run, giving false failures.
2832         https://bugs.webkit.org/show_bug.cgi?id=94505
2833
2834         Reviewed by Ojan Vafai.
2835
2836         It looks like if the webprocess times out, WTR may tell NRWT
2837         that the test completed, but not properly reset its internal
2838         state, and then return stale output for subsequent tests.
2839
2840         This patch modifies NRWT temporarily to check for
2841         "Timed out waiting for final message from web process" in stdout
2842         and treat that as a timeout (and thus kill WTR); this seems
2843         to solve the cascade of failures, but of course there's probably
2844         still a bug in WTR that needs to be fixed.
2845
2846         * Scripts/webkitpy/layout_tests/port/driver.py:
2847         (Driver.run_test):
2848
2849 2012-08-20  Dirk Pranke  <dpranke@chromium.org>
2850
2851         NRWT reports unexpected EOF
2852         https://bugs.webkit.org/show_bug.cgi?id=94387
2853
2854         Reviewed by Adam Barth.
2855
2856         Stop logging "Unexpected EOF" when we are reading the last few
2857         bytes from stdout/stderr after stopping the subprocess.
2858
2859         * Scripts/webkitpy/layout_tests/port/server_process.py:
2860         (ServerProcess._wait_for_data_and_update_buffers_using_select):
2861         (ServerProcess.stop):
2862
2863 2012-08-20  Brady Eidson  <beidson@apple.com>
2864
2865         Temporarily disable the 20+ crash and 500+ failure options on WK2 bots.
2866         https://bugs.webkit.org/show_bug.cgi?id=94506
2867
2868         Reviewed by Dirk Pranke.
2869
2870         When running WK2 tests, don't add the "abort early" command line options.
2871
2872         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2873         (ConfigureBuild.start):
2874         (RunWebKitTests):
2875         (RunWebKitTests.start):
2876         (RunWebKit2Tests.start):
2877
2878 2012-08-19  Stephanie Lewis  <slewis@apple.com>
2879
2880         Add mountain lion to build config.
2881         https://bugs.webkit.org/show_bug.cgi?id=94441
2882
2883         Reviewed by Adam Barth.
2884
2885         Add Mountain Lion to the build trigger configurations.
2886
2887         * Scripts/webkitpy/common/config/build.py:
2888         (_should_file_trigger_build):
2889         * Scripts/webkitpy/common/config/build_unittest.py:
2890         (ShouldBuildTest):
2891         (ShouldBuildTest.test_should_build):
2892
2893 2012-08-17  Kiran Muppala  <cmuppala@apple.com>
2894
2895         Add self to webkit contributors list
2896         https://bugs.webkit.org/show_bug.cgi?id=94409
2897
2898         Reviewed by Dirk Pranke.
2899
2900         Add name, email and irc handle to webkit contributors list.
2901
2902         * Scripts/webkitpy/common/config/committers.py:
2903
2904 2012-08-17  Ryosuke Niwa  <rniwa@webkit.org>
2905
2906         Perfalizer should differentiate results with and without the patch
2907         https://bugs.webkit.org/show_bug.cgi?id=94399
2908
2909         Reviewed by Dirk Pranke.
2910
2911         Add "with 12345" and "without 12345" descriptions in results JSON so that graphs in
2912         the results page are labled accordingly.
2913
2914         Also use _build_without_patch when building without a patch so that we get the right error message.
2915
2916         * Scripts/webkitpy/tool/commands/perfalizer.py:
2917         (PerfalizerTask.run):
2918         (PerfalizerTask._run_perf_test):
2919         * Scripts/webkitpy/tool/commands/perfalizer_unittest.py:
2920         (PerfalizerTaskTest._create_and_run_perfalizer.run_perf_test):
2921
2922 2012-08-17  Dirk Pranke  <dpranke@chromium.org>
2923
2924         nrwt: don't fail tests if ImageDiff fails on the wk2 ports
2925         https://bugs.webkit.org/show_bug.cgi?id=94396
2926
2927         Reviewed by Ryosuke Niwa.
2928
2929         It appears that WTR is generating PNGs that ImageDiff doesn't
2930         like, and so we're getting lots of "can not get ImageDiff"
2931         errors (see bug 81962). The change in r124581 made this a test
2932         failure, and this is causing the WK2 bots to frequently abort
2933         with 500+ failures. 
2934
2935         This change makes ImageDiff errors not be test failures just for
2936         WK2 for now until we can better triage what's going on.
2937
2938         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2939         (SingleTestRunner._compare_image):
2940
2941 2012-08-17  James Robinson  <jamesr@chromium.org>
2942
2943         [chromium] Add a style check for #include "cc/..." in chromium files
2944         https://bugs.webkit.org/show_bug.cgi?id=94382
2945
2946         Reviewed by Adam Barth.
2947
2948         Adds a style check to make sure new chromium code follows the correct convention for including cc files.
2949
2950         * Scripts/webkitpy/style/checkers/cpp.py:
2951         (check_include_line):
2952         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2953         (OrderOfIncludesTest.test_check_cc_includes):
2954
2955 2012-08-17  Ojan Vafai  <ojan@chromium.org>
2956
2957         Delete some dead code from the flakiness dashboard
2958         https://bugs.webkit.org/show_bug.cgi?id=94380
2959
2960         Reviewed by Dirk Pranke.
2961
2962         This code became dead in one of the refactors of how we handle BuilderGroups.
2963         There's no bug here, it's just dead code.
2964         * TestResultServer/static-dashboards/builders.js:
2965         (requestBuilderList):
2966         (loadBuildersList):
2967
2968 2012-08-17  Jochen Eisinger  <jochen@chromium.org>
2969
2970         [chromium] Add content shell bots to the flakiness dashboard
2971         https://bugs.webkit.org/show_bug.cgi?id=94369
2972
2973         Reviewed by Ojan Vafai.
2974
2975         The bots are named $OS (Content Shell).
2976
2977         * TestResultServer/static-dashboards/builders.js:
2978         (isChromiumWebkitTipOfTreeTestRunner):
2979         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2980
2981 2012-08-17  Shadi Khalek  <shadi@chromium.org>
2982
2983         Add AV perf layout tests to webkit flakiness dashboard
2984         https://bugs.webkit.org/show_bug.cgi?id=94255
2985
2986         Reviewed by Ojan Vafai.
2987
2988         Added missing mappings to LEGACY_BUILDER_MASTERS_TO_GROUPS.
2989         The isChromiumDepsAVTestRunner() filter does not work on current builder names. 
2990         It assumes the new names they are getting renamed to (AV Linux, AV Win7).
2991
2992         * TestResultServer/static-dashboards/builders.js:
2993         (isChromiumTipOfTreeAVTestRunner):
2994         (loadBuildersList):
2995
2996 2012-08-17  Milian Wolff  <milian.wolff@kdab.com>
2997
2998         [Qt] QtWebKit fails to build with OpenGL support on QNX
2999         https://bugs.webkit.org/show_bug.cgi?id=93278
3000
3001         Reviewed by Noam Rosenthal.
3002
3003         Change the order in which we define WTF_USE_3D_GRAPHICS and ENABLE_WEBGL.
3004         First, we now defined WTF_USE_3D_GRAPHICS=1, but only if QT_CONFIG
3005         contains opengl. Furthermore, we disable this feature on win32-* as usual,
3006         but now also disable it on QNX.
3007
3008         Then, we set ENABLE_WEBGL=1 but only if we previously set WTF_USE_3D_GRAPHICS=1.
3009
3010         * qmake/mkspecs/features/features.prf:
3011
3012 2012-08-16  Gustavo Noronha Silva  <gns@gnome.org>
3013
3014         [jhbuild] EFL now runs jhbuild update for every build
3015         https://bugs.webkit.org/show_bug.cgi?id=94267
3016
3017         Reviewed by Dirk Pranke.
3018
3019         This change makes EFL's approach to jhbuild more in line with the one
3020         used by WebKitGTK+. update-webkitefl-libs will only be called by build-
3021         webkit if --update-efl is given explicitly. The EWS bot will do that
3022         from now on.
3023
3024         * Scripts/webkitdirs.pm:
3025         (jhbuildWrapperPrefixIfNeeded): return jhbuild wrapper only if the
3026         Dependencies directory exists also for EFL
3027         (generateBuildSystemFromCMakeProject): no longer run update-webkitefl-libs
3028         (buildCMakeProjectOrExit): build update-webkitefl-libs if --update-efl is
3029         given
3030         * Scripts/webkitpy/common/config/ports.py:
3031         (EflPort.build_webkit_command): make EWS bots pass --update-efl to build-webkit
3032         * Scripts/webkitpy/common/config/ports_unittest.py:
3033         (DeprecatedPortTest.test_efl_port): add unit testing for EFL port
3034
3035 2012-08-16  Kent Tamura  <tkent@chromium.org>
3036
3037         Add forms-bugs@chromium.org as a contributor.
3038
3039         * Scripts/webkitpy/common/config/committers.py:
3040
3041 2012-08-16  Gustavo Noronha Silva  <gns@gnome.org>
3042
3043         Unreviewed warning fix, sys.argv is a python construct.
3044
3045         * Scripts/update-webkitefl-libs:
3046
3047 2012-08-16  Dirk Pranke  <dpranke@chromium.org>
3048
3049         NRWT cutting off the output from LayoutTest run under Valgrind
3050         https://bugs.webkit.org/show_bug.cgi?id=94011
3051
3052         Reviewed by Ojan Vafai.
3053
3054         Make NRWT work with valgrind again ... I needed to rework the
3055         driver infrastructure so that we could get the stderr written
3056         between a test completing and a process being stopped and
3057         associate it with the DriverOutput for the test; this meant that
3058         run_test() needed to stop the driver at the end of the test
3059         directly if/when appropriate. This also entailed reworking
3060         run_test() so that we would gather stderr and stdout
3061         consistently regardless of whether this was a normal test, or
3062         stop_when_done, or a crash or timeout.
3063
3064         Also, I had to rework the process_stop_time() (and renamed it to
3065         driver_stop_timeout) so that it would be longer if --time-out-ms
3066         was long as well (so that valgrind would get enough time to
3067         run), and I reworked driver.stop(kill_directly=True) to just
3068         driver.stop(timeout=0.0).
3069
3070         Lastly, adding the new stop_when_done parameter entailed
3071         touching a lot of test mock functions :(.
3072
3073         This change appeared to be well-covered by existing tests.
3074
3075         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
3076         (Worker._run_test):
3077         (Worker._run_test_with_timeout):
3078         (Worker._run_test_in_another_thread):
3079         (Worker._run_test_in_another_thread.SingleTestThread.run):
3080         (Worker._run_test_in_this_thread):
3081         (Worker._run_single_test):
3082         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3083         (run_single_test):
3084         (SingleTestRunner.__init__):
3085         (SingleTestRunner._run_compare_test):
3086         (SingleTestRunner._run_rebaseline):
3087         (SingleTestRunner._run_reftest):
3088         * Scripts/webkitpy/layout_tests/port/base.py:
3089         (Port.driver_stop_timeout):
3090         (Port.variable.default_configuration):
3091         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3092         (ChromiumAndroidPort.driver_stop_timeout):
3093         (ChromiumAndroidDriver.stop):
3094         * Scripts/webkitpy/layout_tests/port/driver.py:
3095         (Driver.run_test):
3096         (Driver.stop):
3097         (DriverProxy.run_test):
3098         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
3099         (DriverTest.test_check_for_driver_crash.FakeServerProcess.stop):
3100         * Scripts/webkitpy/layout_tests/port/server_process.py:
3101         (ServerProcess.write):
3102         (ServerProcess._wait_for_data_and_update_buffers_using_select):
3103         (ServerProcess.stop):
3104         (ServerProcess.kill):
3105         (ServerProcess):
3106         (ServerProcess._kill):
3107         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
3108         (TrivialMockPort.__init__):
3109         (MockProc.wait):
3110         (TestServerProcess.test_basic):
3111         * Scripts/webkitpy/layout_tests/port/test.py:
3112         (TestDriver.run_test):
3113         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3114         (get_tests_run.RecordingTestDriver.run_test):
3115         * Scripts/webkitpy/performance_tests/perftest.py:
3116         (PerfTest.run_single):
3117         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
3118         (TestPageLoadingPerfTest.MockDriver.run_test):
3119         (TestReplayPerfTest.ReplayTestPort.__init__.ReplayTestDriver.run_test):
3120         (TestReplayPerfTest.test_run_single.run_test):
3121         (TestReplayPerfTest.test_run_single_fails_when_output_has_error.run_test):
3122         (TestReplayPerfTest.test_prepare.run_test):
3123         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3124         (MainTest.TestDriver.run_test):
3125
3126 2012-08-16  Roger Fong  <roger_fong@apple.com>
3127
3128         Typo in old-run-webkit-tests script from https://bugs.webkit.org/show_bug.cgi?id=93904.
3129         https://bugs.webkit.org/show_bug.cgi?id=94228
3130
3131         Reviewed by Tim Horton.
3132
3133         I previously made the change but made a typo that causes the script not ignore mismatch ref tests.
3134
3135         * Scripts/old-run-webkit-tests:
3136         (isUsedInReftest):
3137
3138 2012-08-16  Peter Beverloo  <peter@chromium.org>
3139
3140         [Chromium] Pass the --strip-binary argument to the apk test generator
3141         https://bugs.webkit.org/show_bug.cgi?id=94224
3142
3143         Reviewed by Adam Barth.
3144
3145         The native test generator currently relies on the $STRIP environment
3146         variable to be available, which it shouldn't do. Instead, pass it as an
3147         argument to the script. The $STRIP variable is being deprecated.
3148
3149         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3150         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
3151
3152 2012-08-16  Xiaobo Wang  <xbwang@torchmobile.com.cn>
3153
3154         [BlackBerry] Update format of JS console message to keep consistent with other ports.
3155         https://bugs.webkit.org/show_bug.cgi?id=94058
3156
3157         Reviewed by Yong Li.
3158         Reviewed internally by George Staikos.
3159
3160         1. Remove line number if it's zero.
3161         2. Print only file name for "file://" URL.
3162
3163         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
3164         (BlackBerry::WebKit::DumpRenderTree::addMessageToConsole):
3165
3166 2012-08-16  Simon Hausmann  <simon.hausmann@nokia.com>
3167
3168         [Qt] Make DRT results more reliable on X11
3169
3170         Reviewed by Jocelyn Turcotte.
3171
3172         Disable desktop setting awareness, to prevent QApplication on X11 from reading palette settings from
3173         the running desktop environment.
3174
3175         * DumpRenderTree/qt/main.cpp:
3176         (main):
3177
3178 2012-08-16  Pierre Rossi  <pierre.rossi@gmail.com>
3179
3180         [Qt] Remove FontQt4, HAVE_QRAWFONT flag and the related dead code
3181         https://bugs.webkit.org/show_bug.cgi?id=93960
3182
3183         Reviewed by Simon Hausmann.
3184
3185         Following the removal of Qt 4 support from trunk in r124879.
3186
3187         * qmake/mkspecs/features/features.prf:
3188
3189 2012-08-16  Taiju Tsuiki  <tzik@chromium.org>
3190
3191         Add deleteFileSystem support to DumpRenderTree for chromium
3192         https://bugs.webkit.org/show_bug.cgi?id=94071
3193
3194         Reviewed by Kent Tamura.
3195
3196         * DumpRenderTree/chromium/WebViewHost.cpp:
3197         (WebViewHost::deleteFileSystem): Added
3198         * DumpRenderTree/chromium/WebViewHost.h:
3199         (WebViewHost):
3200
3201 2012-08-15  Ryosuke Niwa  <rniwa@webkit.org>
3202
3203         Rename LayoutTestController to TestRunner in WebKitTestRunner
3204         https://bugs.webkit.org/show_bug.cgi?id=93942
3205
3206         Reviewed by Simon Fraser.
3207
3208         Renamed the class and relevant files.
3209
3210         * WebKitTestRunner/CMakeLists.txt:
3211         * WebKitTestRunner/DerivedSources.make:
3212         * WebKitTestRunner/GNUmakefile.am:
3213         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Removed.
3214         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Copied from Tools/WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl.
3215         * WebKitTestRunner/InjectedBundle/DerivedSources.pri:
3216         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3217         (WTR::InjectedBundle::didReceiveMessage):
3218         (WTR::InjectedBundle::beginTesting):
3219         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3220         (WTR::InjectedBundle::testRunner):
3221         (InjectedBundle):
3222         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3223         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: Removed.
3224         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Removed.
3225         * WebKitTestRunner/InjectedBundle/Target.pri:
3226         * WebKitTestRunner/InjectedBundle/TestRunner.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.cpp.
3227         * WebKitTestRunner/InjectedBundle/TestRunner.h: Copied from Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.h.
3228         (TestRunner):
3229         * WebKitTestRunner/InjectedBundle/efl/LayoutTestControllerEfl.cpp: Removed.
3230         * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/efl/LayoutTestControllerEfl.cpp.
3231         (WTR::waitToDumpWatchdogTimerCallback):
3232         (WTR::TestRunner::platformInitialize):
3233         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
3234         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
3235         (WTR::TestRunner::pathToLocalResource):
3236         (WTR::TestRunner::platformName):
3237         * WebKitTestRunner/InjectedBundle/gtk/LayoutTestControllerGtk.cpp: Removed.
3238         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/gtk/LayoutTestControllerGtk.cpp.
3239         (WTR::waitToDumpWatchdogTimerCallback):
3240         (WTR::TestRunner::platformInitialize):
3241         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
3242         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
3243         (WTR::TestRunner::pathToLocalResource):
3244         (WTR::TestRunner::platformName):
3245         * WebKitTestRunner/InjectedBundle/mac/LayoutTestControllerMac.mm: Removed.
3246         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm: Copied from Tools/WebKitTestRunner/InjectedBundle/mac/LayoutTestControllerMac.mm.
3247         (WTR::TestRunner::platformInitialize):
3248         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
3249         (WTR::waitUntilDoneWatchdogTimerFired):
3250         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
3251         (WTR::TestRunner::pathToLocalResource):
3252         (WTR::TestRunner::platformName):
3253         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp: Removed.
3254         * WebKitTestRunner/InjectedBundle/qt/TestRunnerQt.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp.
3255         (WTR::WatchdogTimerHelper::timerFired):
3256         (WTR::TestRunner::platformInitialize):
3257         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
3258         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
3259         (WTR::TestRunner::pathToLocalResource):
3260         (WTR::TestRunner::platformName):
3261         * WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp: Removed.
3262         * WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp.
3263         (WTR::TestRunner::platformInitialize):
3264         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
3265         (WTR::waitToDumpWatchdogTimerFired):
3266         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
3267         (WTR::TestRunner::pathToLocalResource):
3268         (WTR::TestRunner::platformName):
3269         * WebKitTestRunner/PlatformEfl.cmake:
3270         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3271         * WebKitTestRunner/win/InjectedBundle.vcproj:
3272
3273 2012-08-15  Xianzhu Wang  <wangxianzhu@chromium.org>
3274
3275         [Chromium-Android] DumpRenderTree timeouts before NRWT timeouts
3276         https://bugs.webkit.org/show_bug.cgi?id=94155
3277
3278         Reviewed by Dirk Pranke.
3279
3280         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3281         (ChromiumAndroidPort.create_driver): Force no_timeout=True
3282
3283 2012-08-15  Ryosuke Niwa  <rniwa@webkit.org>
3284
3285         Add a hyperlink to perf-o-matic from build.webkit.org/root.html
3286         https://bugs.webkit.org/show_bug.cgi?id=93749
3287
3288         Reviewed by Csaba Osztrogonác.
3289
3290         Added the hyperlink to webkit-perf.appspot.com. Also added hyperlinks to the waterfall display
3291         of performance tests.
3292
3293         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
3294
3295 2012-08-15  Bruno de Oliveira Abinader  <bruno.abinader@basyskom.com>
3296
3297         [css3-text] Add CSS3 Text decoration compile flag
3298         https://bugs.webkit.org/show_bug.cgi?id=93863
3299
3300         Reviewed by Julien Chaffraix.
3301
3302         This patch handles the compile flag implementation, which will come disabled by
3303         default, thus not exposing the CSS3 text decoration features to the web, unless
3304         when explicitly enabling it with "--css3-text-decoration" build parameter.
3305
3306         * Scripts/webkitperl/FeatureList.pm:
3307         * qmake/mkspecs/features/features.pri:
3308
3309 2012-08-15  Beth Dakin  <bdakin@apple.com>
3310
3311         https://bugs.webkit.org/show_bug.cgi?id=93693
3312         [WK2] REGRESSION(125091): pixel results don't sow scrollbars 
3313         anymore
3314
3315         Reviewed by Sam Weinig.
3316
3317         Use new API WKBundlePageCreateSnapshotWithOptions().
3318         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3319         (WTR::InjectedBundlePage::dump):
3320
3321 2012-08-15  Alexey Proskuryakov  <ap@apple.com>
3322
3323         Add rfong to Bugzilla CC "contributor" list.
3324
3325         * Scripts/webkitpy/common/config/committers.py:
3326
3327 2012-08-15  Scott Graham  <scottmg@chromium.org>
3328
3329         Rename window.internals.fastMallocStatistics to mallocStatistics
3330         https://bugs.webkit.org/show_bug.cgi?id=94033
3331
3332         Reviewed by Adam Barth.
3333
3334         * GNUmakefile.am:
3335         * Scripts/webkitpy/performance_tests/perftest.py:
3336         (PerfTest):
3337         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3338         (test_run_memory_test):
3339
3340 2012-08-15  Peter Beverloo  <peter@chromium.org>
3341
3342         Fix a warning in TestWebKitAPI's MediaTime test-suite
3343         https://bugs.webkit.org/show_bug.cgi?id=94096
3344
3345         Reviewed by Adam Barth.
3346
3347         This warning is visible when building the file with certain GCC versions,
3348         including the one used by Chromium for Android. The warning is visible in
3349         the cr-android build bot output:
3350
3351         MediaTime.cpp:152: warning: this decimal constant is unsigned only in ISO C90
3352
3353         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
3354         (TestWebKitAPI::TEST):
3355
3356 2012-08-15  Kevin Funk  <kevin.funk@kdab.com>
3357
3358         Fix the 'git log' call in VCSUtils.pm for Windows
3359         https://bugs.webkit.org/show_bug.cgi?id=94113
3360
3361         Reviewed by Kenneth Rohde Christiansen.
3362
3363         Failed because of invalid enquoting characters.
3364
3365         * Scripts/VCSUtils.pm:
3366
3367 2012-08-14  Gustavo Noronha Silva  <gns@gnome.org>
3368
3369         [jhbuild] move md5sum checking to update-webkit-libs-jhbuild
3370         https://bugs.webkit.org/show_bug.cgi?id=93208
3371
3372         Reviewed by Martin Robinson.
3373
3374         This change makes the md5sum check and saving be done by the script
3375         that performs the dependencies update. build-webkit no longer prefixes
3376         calls to commands with jhbuild-wrapper if jhbuild has not been
3377         bootstrapped by the developer and --update-gtk is not given.
3378
3379         * Scripts/update-webkit-libs-jhbuild:
3380         (getMD5HashForFile): moved from webkitdirs.
3381         (jhbuildConfigurationChanged): ditto.
3382         (saveJhbuildMd5): ditto.
3383         (cleanJhbuild): ditto, and changed to run jhbuild clean before removing
3384         jhbuild.
3385         * Scripts/webkitdirs.pm:
3386         (runAutogenForAutotoolsProjectIfNecessary): use jhbuildWrapperPrefixIfNeeded.
3387         (buildAutotoolsProject): ditto.
3388         (jhbuildWrapperPrefixIfNeeded): add a code branch for GTK+.
3389         (generateBuildSystemFromCMakeProject): call update-webkitefl-libs
3390         unconditionally for EFL.
3391         * jhbuild/jhbuild-wrapper:
3392         (update_webkit_libs_jhbuild): removed, jhbuild-wrapper no longer runs the
3393         update script itself
3394         (ensure_jhbuild): remove update call.
3395
3396 2012-08-15  Christophe Dumez  <christophe.dumez@intel.com>
3397
3398         [WK2] Add support for Web Intents MessagePorts
3399         https://bugs.webkit.org/show_bug.cgi?id=89072
3400
3401         Reviewed by Kenneth Rohde Christiansen.
3402
3403         Use WKBundleIntent instead of WebIntentData in
3404         WebKitTestRunner. WTR now prints the number of
3405         MessagePorts in received Web intents as
3406         expected by the following layout tests:
3407         webintents/web-intents-invoke-port.html
3408         webintents/web-intents-obj-constructor.html
3409
3410         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3411         (WTR::InjectedBundlePage::didReceiveIntentForFrame):
3412         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3413         (WTR::LayoutTestController::deliverWebIntent):
3414
3415 2012-08-14  Ryosuke Niwa  <rniwa@webkit.org>
3416
3417         Build fix after r125516. Revert the erroneous rename since we need to keep exposing
3418         layoutTestController in Chromium port as explained r124785.
3419
3420         * DumpRenderTree/chromium/TestShell.cpp:
3421         (TestShell::bindJSObjectsToWindow):
3422
3423 2012-08-14  Dan Bernstein  <mitz@apple.com>
3424
3425         fast/events/overflow-scroll-fake-mouse-move.html and fast/events/frame-scroll-fake-mouse-move.html are failing in WebKit1
3426         https://bugs.webkit.org/show_bug.cgi?id=94045
3427
3428         Reviewed by Geoff Garen.
3429
3430         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
3431         (-[DumpRenderTreeWindow _hasKeyAppearance]): Added. Returns [self isKeyWindow]. This is
3432         needed now that WebView uses -_hasKeyAppearance instead of -isKeyWindow.
3433
3434 2012-08-14  Alexey Proskuryakov  <ap@apple.com>
3435
3436         [WK2] Fix some typos in MiniBrowser
3437         https://bugs.webkit.org/show_bug.cgi?id=94047
3438
3439         Reviewed by Jon Honeycutt.
3440
3441         * MiniBrowser/mac/AppDelegate.m:
3442         (didReceiveMessageFromInjectedBundle): (-[BrowserAppDelegate init]):
3443         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
3444         (didReceiveMessage):
3445         (WKBundleInitialize):
3446
3447 2012-08-14  Roger Fong  <roger_fong@apple.com>
3448
3449         old-run-webkit-tests should skip all file extensions for ref tests, not just .html.
3450         https://bugs.webkit.org/show_bug.cgi?id=93904
3451
3452         Reviewed by Tim Horton.
3453
3454         old-run-webkit-tests ref test only skipped .html test.
3455         They need to skip .html, .shtml, .xml, .xhtml, .pl, .htm, .php, .svg, .mht.
3456         
3457         * Scripts/old-run-webkit-tests:
3458         (isUsedInReftest): Skip all extensions for ref tests.
3459
3460 2012-08-14  Lauro Neto  <lauro.neto@openbossa.org>
3461
3462         Convert signals/slots to Q_* macros.
3463
3464         [Qt] Use Q_SLOTS and Q_SIGNALS instead of slots and signals
3465         https://bugs.webkit.org/show_bug.cgi?id=93996
3466
3467         Reviewed by Kenneth Rohde Christiansen.
3468
3469         Change usage of keyword-conflicting 'signals' and 'slots' for
3470         Q_SIGNALS and Q_SLOTS macro.
3471
3472         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3473         (NetworkAccessManager):
3474         (WebPage):
3475         * DumpRenderTree/qt/EventSenderQt.h:
3476         (EventSender):
3477         * DumpRenderTree/qt/GCControllerQt.h:
3478         (GCController):
3479         * DumpRenderTree/qt/TestRunnerQt.h:
3480         (TestRunner):
3481         * DumpRenderTree/qt/TextInputControllerQt.h:
3482         (TextInputController):
3483         * MiniBrowser/qt/BrowserWindow.h:
3484         (BrowserWindow):
3485         * MiniBrowser/qt/MiniBrowserApplication.h:
3486         (WindowOptions):
3487         * MiniBrowser/qt/UrlLoader.h:
3488         (UrlLoader):
3489         * QtTestBrowser/cookiejar.h:
3490         (TestBrowserCookieJar):
3491         * QtTestBrowser/fpstimer.h:
3492         (FpsTimer):
3493         * QtTestBrowser/launcherwindow.h:
3494         (LauncherWindow):
3495         * QtTestBrowser/locationedit.h:
3496         (LocationEdit):
3497         * QtTestBrowser/mainwindow.h:
3498         (MainWindow):
3499         * QtTestBrowser/urlloader.h:
3500         (UrlLoader):
3501         * QtTestBrowser/webinspector.h:
3502         (WebInspector):
3503         * QtTestBrowser/webpage.h:
3504         (WebPage):
3505         * QtTestBrowser/webview.h:
3506         (WebViewGraphicsBased):
3507         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
3508         (WatchdogTimerHelper):
3509         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3510         (WrapperWindow):
3511         * WebKitTestRunner/qt/main.cpp:
3512         (Launcher):
3513
3514 2012-08-14  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3515
3516         WebKitTestRunner needs layoutTestController.dumpResourceLoadCallbacks
3517         https://bugs.webkit.org/show_bug.cgi?id=42332
3518
3519         Reviewed by Kenneth Rohde Christiansen.
3520
3521         Added Resource Callbacks logging. Several aux dumping functions are added.
3522
3523         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3524         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3525         (WTR::isFileScheme):
3526         (WTR):
3527         (WTR::pathSuitableForTestResult):
3528         (WTR::urlSuitableForTestResult):
3529         (WTR::InjectedBundlePage::resetAfterTest):
3530         (WTR::dumpRequestDescriptionSuitableForTestResult):
3531         (WTR::dumpResponseDescriptionSuitableForTestResult):
3532         (WTR::dumpErrorDescriptionSuitableForTestResult):
3533         (WTR::InjectedBundlePage::didInitiateLoadForResource):
3534         (WTR::InjectedBundlePage::willSendRequestForFrame):
3535         (WTR::InjectedBundlePage::didReceiveResponseForResource):
3536         (WTR::InjectedBundlePage::didFinishLoadForResource):
3537         (WTR::InjectedBundlePage::didFailLoadForResource):
3538         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3539         (WTR::LayoutTestController::LayoutTestController):
3540         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3541         (WTR::LayoutTestController::dumpResourceLoadCallbacks):
3542         (WTR::LayoutTestController::shouldDumpResourceLoadCallbacks):
3543         (LayoutTestController):
3544
3545 2012-08-14  Alexis Menard  <alexis.menard@openbossa.org>
3546
3547         Update INdT build bot to Mountain Lion.
3548         https://bugs.webkit.org/show_bug.cgi?id=93963
3549
3550         Reviewed by Csaba Osztrogonác.
3551
3552         We updated the machine as well as the OS as the Qt port is now running
3553         on top of Qt5.
3554
3555         * BuildSlaveSupport/build.webkit.org-config/config.json:
3556
3557 2012-08-14  Peter Beverloo  <peter@chromium.org>
3558
3559         [Chromium] Remove unneeded build logic for Android
3560         https://bugs.webkit.org/show_bug.cgi?id=93962
3561
3562         Reviewed by Dimitri Glazkov.
3563
3564         The Android SDK and NDK have been checked in to the Chromium tree, which
3565         allows WebKit to leverage those as well. They will already be pulled in
3566         through a DEPS change made last week, and by not setting the ANDROID_NDK_ROOT
3567         environment variable, the envsetup.sh will set the project files up
3568         appropriately for us.
3569
3570         * Scripts/webkitdirs.pm:
3571
3572 2012-08-14  Sergio Villar Senin  <svillar@igalia.com>
3573
3574         [WK2] [GTK] Plugin tests failing in WK2 bot
3575         https://bugs.webkit.org/show_bug.cgi?id=93954
3576
3577         Reviewed by Carlos Garcia Campos.
3578
3579         Plugin tests are failing in the WK2 bot because we aren't exporting
3580         the Netscape plugin when creating the product archive.
3581
3582         * BuildSlaveSupport/built-product-archive: added TestNetscapePlugin
3583         to the list of directories to export.
3584         (archiveBuiltProduct):
3585
3586 2012-08-14  Peter Beverloo  <peter@chromium.org>
3587
3588         [Chromium] Fix apk generation for the Android platform
3589         https://bugs.webkit.org/show_bug.cgi?id=93841
3590
3591         Unreviewed build fix.
3592
3593         APK generation was broken as the configuration file assumed compilation
3594         would only occur in the Chromium tree. Pass the path to Chromium's source
3595         base directory as a property to ant.
3596
3597         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3598         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
3599
3600 2012-08-14  Sergio Villar Senin  <svillar@igalia.com>
3601
3602         [GTK] REGRESSION (r122428) WebKit2APITests/TestWebKitFindController fails "next" test
3603         https://bugs.webkit.org/show_bug.cgi?id=91083
3604
3605         Reviewed by Carlos Garcia Campos.
3606
3607         Unskipped a couple of API tests that should work fine from now on.
3608
3609         * Scripts/run-gtk-tests:
3610         (TestRunner):
3611
3612 2012-08-14  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
3613
3614         [NRWT] Compare results between different platforms
3615         https://bugs.webkit.org/show_bug.cgi?id=90555
3616
3617         Reviewed by Dirk Pranke.
3618
3619         * Scripts/webkitpy/layout_tests/port/base.py:
3620         (Port.baseline_search_path):
3621         (Port):
3622         (Port.compare_baseline):
3623         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3624         (parse_args):
3625
3626 2012-08-13  Ryosuke Niwa  <rniwa@webkit.org>
3627
3628         Rename LayoutTestController to TestRunner in DumpRenderTree
3629         https://bugs.webkit.org/show_bug.cgi?id=93758
3630
3631         Reviewed by Tony Chang.
3632
3633         Renamed LayoutTestController to TestRunner. For Chromium port, it's renamed to DRTTestRunner
3634         since it already has TestRunner class shared between DumpRenderTree and content_shell.
3635
3636         * DumpRenderTree/DumpRenderTree.h:
3637         * DumpRenderTree/PixelDumpSupport.cpp:
3638         * DumpRenderTree/StorageTrackerDelegate.h:
3639         * DumpRenderTree/StorageTrackerDelegate.mm:
3640         * DumpRenderTree/TestRunner.cpp:
3641         * DumpRenderTree/TestRunner.h:
3642         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
3643         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
3644         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3645         * DumpRenderTree/chromium/DRTTestRunner.h:
3646         * DumpRenderTree/chromium/DumpRenderTree.cpp: