Add support for reporting "display composited video frames" through the VideoPlayback...
[WebKit-https.git] / Tools / ChangeLog
1 2018-10-03  Jer Noble  <jer.noble@apple.com>
2
3         Add support for reporting "display composited video frames" through the VideoPlaybackQuality object.
4         https://bugs.webkit.org/show_bug.cgi?id=190266
5
6         Reviewed by Eric Carlson.
7
8         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
9         * TestWebKitAPI/Tests/WebKitCocoa/VideoQualityDisplayCompositing.mm: Added.
10         (TestWebKitAPI::TEST):
11
12 2018-10-05  Ryan Haddad  <ryanhaddad@apple.com>
13
14         Unreviewed, rolling out r236866.
15
16         Breaks internal builds.
17
18         Reverted changeset:
19
20         "Add support for reporting "display composited video frames"
21         through the VideoPlaybackQuality object."
22         https://bugs.webkit.org/show_bug.cgi?id=190266
23         https://trac.webkit.org/changeset/236866
24
25 2018-10-05  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
26
27         [WPE][JSC] Use Unified Sources for Platform-specific sources
28         https://bugs.webkit.org/show_bug.cgi?id=190300
29
30         Reviewed by Yusuke Suzuki.
31
32         Currently the GTK port already used Unified Sources with the same source files.
33         As WPE has conditional code using gmodule, we need to add GLIB_GMODULE_LIBRARIES
34         to the list of libraries to link with.
35
36         * TestWebKitAPI/PlatformWPE.cmake:
37
38 2018-10-05  Zach Li  <zachli@apple.com>
39
40         Expose whether WKWebProcessPlugInNodeHandle is a select element to clients
41         https://bugs.webkit.org/show_bug.cgi?id=190302
42         <rdar://problem/45031469>
43
44         Reviewed by Tim Horton.
45
46         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
47         * TestWebKitAPI/Tests/WebKitCocoa/InjectedBundleNodeHandleIsSelectElement.mm: Added.
48         (-[InjectedBundleNodeHandleIsSelectElement verifySelectElementForHTMLElementTag:document:jsContext:expectedResult:failedElementTags:]):
49         (-[InjectedBundleNodeHandleIsSelectElement webProcessPlugIn:didCreateBrowserContextController:]):
50         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
51         (-[InjectedBundleNodeHandleIsSelectElementDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
52         (TEST):
53
54 2018-10-04  Wenson Hsieh  <wenson_hsieh@apple.com>
55
56         [iOS] [WK2] Expose some more editing SPI on WKWebView
57         https://bugs.webkit.org/show_bug.cgi?id=190232
58         <rdar://problem/44963368>
59
60         Reviewed by Tim Horton.
61
62         Adds new API tests to exercise the new SPIs.
63
64         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
65         * TestWebKitAPI/Tests/ios/WKWebViewEditActions.mm: Added.
66         (-[TestWKWebView querySelectorExists:]):
67         (TestWebKitAPI::webViewForEditActionTesting):
68         (TestWebKitAPI::TEST):
69         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
70         (-[TestWKWebView collapseToStart]): Deleted.
71         (-[TestWKWebView collapseToEnd]): Deleted.
72         (-[TestWKWebView stylePropertyAtSelectionStart:]): Deleted.
73         (-[TestWKWebView stylePropertyAtSelectionEnd:]): Deleted.
74         * TestWebKitAPI/cocoa/TestWKWebView.h:
75         * TestWebKitAPI/cocoa/TestWKWebView.mm:
76         (-[TestWKWebView stylePropertyAtSelectionStart:]):
77         (-[TestWKWebView stylePropertyAtSelectionEnd:]):
78         (-[TestWKWebView collapseToStart]):
79         (-[TestWKWebView collapseToEnd]):
80
81         Pull some common testing helpers out of NSFontManager and into TestWKWebView.
82
83 2018-10-04  Jer Noble  <jer.noble@apple.com>
84
85         Add support for reporting "display composited video frames" through the VideoPlaybackQuality object.
86         https://bugs.webkit.org/show_bug.cgi?id=190266
87
88         Reviewed by Eric Carlson.
89
90         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
91         * TestWebKitAPI/Tests/WebKitCocoa/VideoQualityDisplayCompositing.mm: Added.
92         (TestWebKitAPI::TEST):
93
94 2018-10-04  Wenson Hsieh  <wenson_hsieh@apple.com>
95
96         [Cocoa] Add SPI to expose typing attributes at the current selection on WKWebView
97         https://bugs.webkit.org/show_bug.cgi?id=190119
98         <rdar://problem/44767062>
99
100         Reviewed by Tim Horton.
101
102         Add a new API test that loads a document containing various rich text styles. This test moves the selection
103         around the document and checks the last set of font attributes received via the new UI delegate hook.
104
105         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
106         * TestWebKitAPI/Tests/WebKitCocoa/FontAttributes.mm: Added.
107         (-[FontAttributesListener _webView:didChangeFontAttributes:]):
108         (-[FontAttributesListener lastFontAttributes]):
109         (-[TestWKWebView selectElementWithIdentifier:]):
110         (-[TestWKWebView fontAttributesAfterNextPresentationUpdate]):
111         (ColorExpectation::ColorExpectation):
112         (ShadowExpectation::ShadowExpectation):
113         (checkColor):
114         (checkShadow):
115         (checkFont):
116         (webViewForTestingFontAttributes):
117         * TestWebKitAPI/Tests/WebKitCocoa/rich-text-attributes.html: Added.
118
119 2018-10-04  Alan Coon  <alancoon@apple.com>
120
121         Unreviewed, add self as contributor.
122
123         * Scripts/webkitpy/common/config/contributors.json:
124
125 2018-10-04  Wenson Hsieh  <wenson_hsieh@apple.com>
126
127         [macOS] Fix some font attribute conversion bugs in preparation for "Font > Styles…" support in WebKit2
128         https://bugs.webkit.org/show_bug.cgi?id=190289
129         <rdar://problem/45020806>
130
131         Reviewed by Ryosuke Niwa.
132
133         Add new API tests to exercise two corner cases when using NSFontOptions ("Font > Styles…") to change font
134         attributes at the current selection.
135
136         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
137         * TestWebKitAPI/Tests/TestWebKitAPI/mac/AppKitSPI.h:
138         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
139         (webViewForFontManagerTesting):
140         (TestWebKitAPI::TEST):
141         * TestWebKitAPI/mac/TestFontOptions.h: Copied from Source/WebCore/editing/cocoa/FontAttributesCocoa.mm.
142         * TestWebKitAPI/mac/TestFontOptions.mm: Added.
143
144         Introduce TestFontOptions, which wraps the shared NSFontOptions and swizzles `-sharedFontOptions` to return a
145         global instance of itself. TestFontOptions supports several testing helpers to add or remove font shadows,
146         foreground colors, and background colors.
147
148         (sharedFontOptionsForTesting):
149         (+[TestFontOptions sharedInstance]):
150         (-[TestFontOptions initWithFontOptions:]):
151         (-[TestFontOptions selectedAttributes]):
152         (-[TestFontOptions fontOptions]):
153         (-[TestFontOptions shadowWidth]):
154         (-[TestFontOptions setShadowWidth:]):
155         (-[TestFontOptions shadowHeight]):
156         (-[TestFontOptions setShadowHeight:]):
157         (-[TestFontOptions setShadowBlurRadius:]):
158         (-[TestFontOptions setHasShadow:]):
159         (-[TestFontOptions foregroundColor]):
160         (-[TestFontOptions setForegroundColor:]):
161         (-[TestFontOptions backgroundColor]):
162         (-[TestFontOptions setBackgroundColor:]):
163         (-[TestFontOptions _dispatchFontAttributeChanges]):
164         (-[TestFontOptions convertAttributes:]):
165         (-[TestFontOptions setSelectedAttributes:isMultiple:]):
166         (-[TestFontOptions forwardInvocation:]):
167
168 2018-10-04  Jiewen Tan  <jiewen_tan@apple.com>
169
170         [WebAuthN] Move time out control from WebProcess to UIProcess
171         https://bugs.webkit.org/show_bug.cgi?id=189642
172         <rdar://problem/44476765>
173
174         Reviewed by Chris Dumez.
175
176         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
177         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
178
179 2018-10-04  YUHAN WU  <yuhan_wu@apple.com>
180
181         Runtime flag and IDL for MediaRecorder
182         https://bugs.webkit.org/show_bug.cgi?id=190018
183
184         Reviewed by Youenn Fablet and Chris Dumez.
185
186         * DumpRenderTree/mac/DumpRenderTree.mm:
187         (enableExperimentalFeatures):
188
189 2018-10-04  Basuke Suzuki  <Basuke.Suzuki@sony.com>
190
191         [LayoutTests][Win] Stop wpt server correctly.
192         https://bugs.webkit.org/show_bug.cgi?id=190248
193
194         Reviewed by Fujii Hironori.
195
196         Use signal.CTRL_C_EVENT instead of signal.SIGINT for Windows.
197         Also refactoring the detection of Windows and cygwin environment check.
198
199         * Scripts/webkitpy/common/system/executive.py:
200         (Executive.__init__): Check environment once.
201         (Executive._should_close_fds):
202         (Executive.kill_process):
203         (Executive.check_running_pid):
204         (Executive.running_pids):
205         (Executive.interrupt): Use signal.CTRL_C_EVENT for Windows.
206         (Executive.kill_all):
207         (Executive._child_process_encoding):
208         (Executive._should_encode_child_process_arguments):
209         (Executive.popen):
210         (Executive.run_in_parallel):
211
212 2018-10-04  Michael Catanzaro  <mcatanzaro@igalia.com>
213
214         Convert tests to use navigation client
215         https://bugs.webkit.org/show_bug.cgi?id=190153
216
217         Reviewed by Alex Christensen.
218
219         Convert these tests from PagePolicyClient and PageLoaderClient to PageNavigationClient.
220
221         * TestWebKitAPI/Tests/WebKit/DownloadDecideDestinationCrash.cpp:
222         (TestWebKitAPI::decidePolicyForNavigationAction):
223         (TestWebKitAPI::setPagePolicyClient):
224         * TestWebKitAPI/Tests/WebKit/ProvisionalURLAfterWillSendRequestCallback.cpp:
225         (TestWebKitAPI::didCommitNavigationCallback):
226         (TestWebKitAPI::TEST):
227         (TestWebKitAPI::didCommitLoadForFrame): Deleted.
228
229 2018-10-03  Dan Bernstein  <mitz@apple.com>
230
231         [Cocoa] Let clients specify an NSFileWrapper subclassed to be used for _WKAttachment
232         https://bugs.webkit.org/show_bug.cgi?id=190270
233
234         Reviewed by Wenson Hsieh.
235
236         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
237         (TestWebKitAPI::TEST):
238
239 2018-10-03  Ryosuke Niwa  <rniwa@webkit.org>
240
241         Enable selectionAcrossShadowBoundariesEnabled by default in WebKitLegacy
242         https://bugs.webkit.org/show_bug.cgi?id=190238
243
244         Reviewed by Antti Koivisto.
245
246         * DumpRenderTree/TestOptions.h:
247         * DumpRenderTree/mac/DumpRenderTree.mm:
248         (resetWebPreferencesToConsistentValues):
249
250 2018-10-02  Wenson Hsieh  <wenson_hsieh@apple.com>
251
252         [WebKit2] Format > Bold and Format > Italic don't toggle between bold and italic style
253         https://bugs.webkit.org/show_bug.cgi?id=179787
254         <rdar://problem/35593389>
255
256         Reviewed by Tim Horton.
257
258         Add a test to verify that NSFontManager's selected font is updated when applying italic and bold styles using
259         menu items.
260
261         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
262         (webViewForFontManagerTesting):
263         (menuItemCellForFontAction):
264         (TestWebKitAPI::TEST):
265
266 2018-10-02  Chris Dumez  <cdumez@apple.com>
267
268         REGRESSION: TestWebKitAPI.WKWebView.ProvisionalURLNotChange API test is failing
269         https://bugs.webkit.org/show_bug.cgi?id=190176
270         <rdar://problem/44925871>
271
272         Reviewed by Alex Christensen.
273
274         Use a URL that is truly recognized as invalid by WebCore's URL parser.
275
276         * TestWebKitAPI/Tests/WebKitCocoa/ProvisionalURLNotChange.mm:
277         (TEST):
278
279 2018-10-02  Alex Christensen  <achristensen@webkit.org>
280
281         Remove ParsedURLString
282         https://bugs.webkit.org/show_bug.cgi?id=190154
283
284         Reviewed by Chris Dumez.
285
286         * TestWebKitAPI/Tests/WebCore/URL.cpp:
287         (TestWebKitAPI::TEST_F):
288         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
289         (TestWebKitAPI::assertUserAgentForURLHasChromeBrowserQuirk):
290         (TestWebKitAPI::assertUserAgentForURLHasLinuxPlatformQuirk):
291         (TestWebKitAPI::assertUserAgentForURLHasMacPlatformQuirk):
292         (TestWebKitAPI::TEST):
293
294 2018-10-02  Daniel Bates  <dabates@apple.com>
295
296         Fix iOS TestWebKitAPI failures following <https://trac.webkit.org/changeset/236619>
297         (https://bugs.webkit.org/show_bug.cgi?id=190017)
298
299         For now swizzle +[UIKeyboard isInHardwareKeyboardMode] to return NO in the following tests:
300             WKWebViewAutofillTests.AutofillRequiresInputSession
301             DragAndDropTests.ExternalSourceJPEGOnly
302             DragAndDropTests.ExternalSourceUTF8PlainTextOnly
303
304         so that the presence of a hardware keyboad does not effect their results. In <https://bugs.webkit.org/show_bug.cgi?id=190211>
305         we will look to swizzle this method for all test by default.
306
307         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
308         (TestWebKitAPI::overrideIsInHardwareKeyboardMode):
309         (TestWebKitAPI::TEST):
310         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
311         (TestWebKitAPI::overrideIsInHardwareKeyboardMode):
312         (TestWebKitAPI::TEST):
313         * TestWebKitAPI/ios/UIKitSPI.h:
314
315 2018-10-02  Dawei Fenton  <realdawei@apple.com>
316
317         Unreviewed, rolling out r236751.
318
319         broke the iOS Build
320
321         Reverted changeset:
322
323         "Fix iOS TestWebKitAPI failures following
324         <https://trac.webkit.org/changeset/236619>"
325         https://bugs.webkit.org/show_bug.cgi?id=190017
326         https://trac.webkit.org/changeset/236751
327
328 2018-10-02  Daniel Bates  <dabates@apple.com>
329
330         Fix iOS TestWebKitAPI failures following <https://trac.webkit.org/changeset/236619>
331         (https://bugs.webkit.org/show_bug.cgi?id=190017)
332
333         For now swizzle +[UIKeyboard isInHardwareKeyboardMode] to return NO in the following tests:
334             WKWebViewAutofillTests.AutofillRequiresInputSession
335             DragAndDropTests.ExternalSourceJPEGOnly
336             DragAndDropTests.ExternalSourceUTF8PlainTextOnly
337
338         so that the presence of a hardware keyboad does not effect their results. In <https://bugs.webkit.org/show_bug.cgi?id=190211>
339         we will look to swizzle this method for all test by default.
340
341         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
342         (TestWebKitAPI::overrideIsInHardwareKeyboardMode):
343         (TestWebKitAPI::TEST):
344         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
345         (TestWebKitAPI::overrideIsInHardwareKeyboardMode):
346         (TestWebKitAPI::TEST):
347         * TestWebKitAPI/ios/UIKitSPI.h:
348
349 2018-10-01  Dean Jackson  <dino@apple.com>
350
351         Remove CSS Animation Triggers
352         https://bugs.webkit.org/show_bug.cgi?id=190175
353         <rdar://problem/44925626>
354
355         Reviewed by Simon Fraser.
356
357         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
358
359 2018-10-02  Thibault Saunier  <tsaunier@igalia.com>
360
361         [Flatpak] Use our own check of flatpak repos
362         https://bugs.webkit.org/show_bug.cgi?id=190194
363
364         Allowing us to not mess up with user installation
365         and "--assumeyes" everywhere.
366
367         Reviewed by Michael Catanzaro.
368
369         * flatpak/flatpakutils.py:
370         (FlatpakPackage.__init__):
371         (FlatpakPackage.install):
372         (FlatpakPackage.update):
373         (WebkitFlatpak.load_from_args):
374         (WebkitFlatpak.__init__):
375         (WebkitFlatpak.clean_args):
376
377 2018-10-02  Wenson Hsieh  <wenson_hsieh@apple.com>
378
379         [macOS] Implement a way for the UI process to request typing attributes at the current selection
380         https://bugs.webkit.org/show_bug.cgi?id=189983
381         <rdar://problem/44648705>
382
383         Reviewed by Ryosuke Niwa.
384
385         Adds new FontManagerTests that exercise -typingAttributesWithCompletionHandler:. See below for more detail.
386
387         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
388         * TestWebKitAPI/Tests/TestWebKitAPI/mac/AppKitSPI.h:
389         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
390
391         Add a new test that exercises font attribute modification via inspector bar. Also, add a new test that checks
392         typing attributes when using subscript/superscript/unscript. Lastly, augment an existing NSFontPanel test to
393         additionally check that shadowed text and strike-through are reflected in typing attributes.
394
395         (-[FontManagerTestWKWebView inspectorBarItemIdentifiers]):
396         (-[TestWKWebView typingAttributes]):
397
398         Add a synchronous wrapper around `-typingAttributesWithCompletionHandler:` by spinning the runloop.
399
400         (-[TestWKWebView collapseToStart]):
401         (webViewForFontManagerTesting):
402         (TestWebKitAPI::TEST):
403         * TestWebKitAPI/cocoa/TestWKWebView.h:
404         * TestWebKitAPI/mac/TestInspectorBar.h: Copied from Tools/TestWebKitAPI/Tests/TestWebKitAPI/mac/AppKitSPI.h.
405         * TestWebKitAPI/mac/TestInspectorBar.mm: Added.
406
407         Introduce subclasses of `__InspectorBarItemController` and `NSInspectorBar` for testing inspector bar interaction.
408
409         (-[TestInspectorBarItemController initWithInspectorBar:]):
410         (-[TestInspectorBarItemController inspectorBar]):
411         (-[TestInspectorBarItemController updateSelectedAttributes]):
412         (-[TestInspectorBar initWithWebView:]):
413         (+[TestInspectorBar standardItemControllerClass]):
414         (+[TestInspectorBar standardTextItemIdentifiers]):
415         (-[TestInspectorBar _setStyleControlSelected:atIndex:]):
416         (-[TestInspectorBar chooseFontSize:]):
417         (-[TestInspectorBar chooseFontFamily:]):
418         (-[TestInspectorBar _chooseColor:inColorWell:]):
419         (-[TestInspectorBar chooseForegroundColor:]):
420         (-[TestInspectorBar chooseBackgroundColor:]):
421         (-[TestInspectorBar formatBold:]):
422         (-[TestInspectorBar formatItalic:]):
423         (-[TestInspectorBar formatUnderline:]):
424
425         Add helper methods to TestInspectorBar to simulate interacting with various controls (e.g. color wells and font
426         styling controls).
427
428         (-[TestInspectorBar itemController]):
429         (-[TestInspectorBar setItemController:]):
430
431 2018-10-02  Thibault Saunier  <tsaunier@igalia.com>
432
433         [Flatpak] Implement icecream and ccache support
434         https://bugs.webkit.org/show_bug.cgi?id=190146
435
436         Reviewed by Alejandro G. Castro.
437
438         * flatpak/flatpakutils.py:
439         (WebkitFlatpak.load_from_args):
440         (WebkitFlatpak.__init__):
441         (WebkitFlatpak.clean_args):
442         (WebkitFlatpak.run_in_sandbox):
443         (WebkitFlatpak.save_config):
444         (WebkitFlatpak):
445         (WebkitFlatpak.setup_ccache):
446         (WebkitFlatpak.setup_icecc):
447         (WebkitFlatpak.setup_dev_env):
448         * flatpak/org.webkit.WebKit.yaml:
449
450 2018-10-02  Michael Catanzaro  <mcatanzaro@igalia.com>
451
452         Unreviewed, fix missing return value in TestController::keyExistsInKeychain
453
454         * WebKitTestRunner/TestController.cpp:
455         (WTR::TestController::keyExistsInKeychain):
456
457 2018-10-02  Basuke Suzuki  <Basuke.Suzuki@sony.com>
458
459         [WinCairo] Enable WPT tests environment.
460         https://bugs.webkit.org/show_bug.cgi?id=190128
461
462         Reviewed by Youenn Fablet.
463
464         Escaping backslash of the path not to confuse the JSON parser.
465
466         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
467         (WebPlatformTestServer._prepare_config):
468
469 2018-10-01  Ross Kirsling  <ross.kirsling@sony.com>
470
471         [Win][DRT] Actually set "experimental:WebAnimationsCSSIntegrationEnabled" when requested
472         https://bugs.webkit.org/show_bug.cgi?id=190150
473
474         Reviewed by Fujii Hironori.
475
476         * DumpRenderTree/win/DumpRenderTree.cpp:
477         (setWebPreferencesForTestOptions):
478         DRT has been recognizing this field, but not propagating its value to WebPreferences.
479
480 2018-10-01  Alex Christensen  <achristensen@webkit.org>
481
482         Unreviewed, rolling out r236551.
483
484         Fails URL validating too aggressively
485
486         Reverted changeset:
487
488         "URLWithUserTypedString should return nil for URLs deemed to
489         be invalid by WebCore::URL"
490         https://bugs.webkit.org/show_bug.cgi?id=189979
491         https://trac.webkit.org/changeset/236551
492
493 2018-10-01  Wenson Hsieh  <wenson_hsieh@apple.com>
494
495         [iOS] Add SPI to customize the input accessory view when focusing an element
496         https://bugs.webkit.org/show_bug.cgi?id=190152
497         <rdar://problem/42754975>
498
499         Reviewed by Dan Bernstein.
500
501         Add an API test to verify that setting a custom input accessory view and custom input view on the form input
502         session when focusing an element overrides the first responder's (i.e. WKContentView's) `-inputView` and
503         `-inputAccessoryView`.
504
505         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
506         (webViewWithAutofocusedInput):
507         (TestWebKitAPI::TEST):
508         * TestWebKitAPI/Tests/ios/TestInputDelegate.h:
509         * TestWebKitAPI/Tests/ios/TestInputDelegate.mm:
510         (-[TestInputDelegate setWillStartInputSessionHandler:]):
511         (-[TestInputDelegate willStartInputSessionHandler]):
512         (-[TestInputDelegate _webView:willStartInputSession:]):
513
514 2018-10-01  Sihui Liu  <sihui_liu@apple.com>
515
516         Remove StorageProcess
517         https://bugs.webkit.org/show_bug.cgi?id=189975
518
519         Reviewed by Geoffrey Garen.
520
521         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
522         (TEST):
523         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
524         * TestWebKitAPI/Tests/WebKitCocoa/WebProcessKillIDBCleanup.mm:
525         (TEST):
526         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
527         (TEST):
528         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
529         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
530         (WTR::TestRunner::terminateStorageProcess): Deleted.
531         * WebKitTestRunner/InjectedBundle/TestRunner.h:
532         * WebKitTestRunner/TestController.cpp:
533         (WTR::TestController::generatePageConfiguration):
534         (WTR::TestController::databaseProcessName): Deleted.
535         (WTR::TestController::databaseProcessDidCrash): Deleted.
536         (WTR::TestController::terminateStorageProcess): Deleted.
537         * WebKitTestRunner/TestController.h:
538         * WebKitTestRunner/TestInvocation.cpp:
539         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
540
541 2018-10-01  Jiewen Tan  <jiewen_tan@apple.com>
542
543         [WebAuthN] Import a JS CBOR coder
544         https://bugs.webkit.org/show_bug.cgi?id=189877
545         <rdar://problem/44701124>
546
547         Reviewed by Chris Dumez.
548
549         Add logic to only process privateKeyBase64, userCertificateBase64 and intermediateCACertificateBase64
550         only if acceptAttestation is true.
551
552         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
553         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
554
555 2018-10-01  Chris Dumez  <cdumez@apple.com>
556
557         Regression(r236512): http/tests/navigation/keyboard-events-during-provisional-navigation.html is flaky
558         https://bugs.webkit.org/show_bug.cgi?id=190052
559
560         Reviewed by Ryosuke Niwa.
561
562         The test relies on EventSender to send events to the page synchronously to the page and then uses console.log
563         to log those events. It also uses console.log() before sending those events to indicate what the test is about
564         to do. Note that console.log() normally causes the WebKitTestRunner to send an asynchronous IPC to the UIProcess
565         so that it can log the message.
566         The issue is that EventSender uses IPC::SendOption::UseFullySynchronousModeForTesting when sending the
567         sync IPC to the UIProcess. This option causes follow-up *asynchronous* IPC sent from the synchronous IPC reply
568         handler to be transformed into synchronous IPC.
569         As a result, some of the console.log IPC ended up being asynchronous and some other ended up being synchronous.
570         Because synchronous and asynchronous IPC is not necessarily processed in-order by the UIProcess, the logged
571         messages may end up being out of order, leading to flakiness.
572
573         To address the issue, we now make sure that InjectedBundle::outputText() uses a new IPC::SendOption indicated
574         that the IPC should always be sent asynchronously, even if the connection is in fully synchronous mode. As a
575         result, all text outputing IPC to the UIProcess will be asynchronous, and thus in order.
576
577         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
578         (WTR::InjectedBundle::outputText):
579
580 2018-10-01  Daniel Bates  <dabates@apple.com>
581
582         [iOS] Special keys are misidentified in DOM keyboard events
583         https://bugs.webkit.org/show_bug.cgi?id=189974
584
585         Reviewed by Wenson Hsieh.
586
587         Add support for testing keys Forward Delete and Num Lock / Clear.
588
589         * WebKitTestRunner/ios/HIDEventGenerator.mm:
590         (hidUsageCodeForCharacter):
591
592 2018-10-01  Alex Christensen  <achristensen@webkit.org>
593
594         URL should not use TextEncoding internally
595         https://bugs.webkit.org/show_bug.cgi?id=190111
596
597         Reviewed by Andy Estes.
598
599         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
600         (TestWebKitAPI::testUserPass):
601         (TestWebKitAPI::TEST_F):
602
603 2018-10-01  Daniel Bates  <dabates@apple.com>
604
605         LLDB tests may use wrong configuration of lldbWebKitTester
606         https://bugs.webkit.org/show_bug.cgi?id=189011
607
608         Reviewed by Dean Jackson.
609
610         Fixes an issue where the LLDB unit tests may use the wrong configuration of lldbWebKitTester.
611         Additionally, add back the unit tests originally added in r235376 (https://bugs.webkit.org/show_bug.cgi?id=188936).
612
613         Currently the unit tests pick the LLDBWebKitTester binary based on the configuration set by
614         script set-webkit-configuration. This may not be the same configuration specified to test-webkitpy.
615         So, the unit tests may use the wrong binary. Instead we have test-webkitpy store the path
616         to the correct lldbWebKitTester binary that the unit tests should use in an environment variable,
617         called LLDB_WEBKIT_TESTER_EXECUTABLE. (We use an environment variable because the test driver,
618         test-webkitpy, and the unit tests cannot talk to each other directly due the limitations of
619         the Python unittest module, the Python multiprocessing module, and the general principle of unit
620         tests - to test code in isolation). The unit tests make use of the value of this environment
621         variable to launch lldbWebKitTester binary.
622
623         * Scripts/build-lldbwebkittester: We only support building lldbWebKitTester on Mac for now. Error
624         out if this script is invoked for a non-Mac platform.
625         * Scripts/webkitpy/test/main.py:
626         (Tester._run_tests): Build lldbWebKitTester and store the path to it in the environment variable
627         LLDB_WEBKIT_TESTER_EXECUTABLE.
628         (_build_lldb_webkit_tester): Deleted.
629         * lldb/dump_class_layout_unittest.py:
630         (TestDumpClassLayout.shouldSkip): Use SystemHost() here and remove the _host global variable as
631         this is the only call site that needs the Host object now.
632         (TestDumpClassLayout.setUpClass): Take the path to the lldbWebKitTester binary from the value of
633         the environment variable LLDB_WEBKIT_TESTER_EXECUTABLE.
634         * lldb/lldbWebKitTester/main.cpp:
635         (testSummaryProviders): Add back unit test support infrastructure originally added in r235376 (https://bugs.webkit.org/show_bug.cgi?id=188936).
636         * lldb/lldb_webkit_unittest.py:
637         (LLDBDebugSession.setup): Take the path to the lldbWebKitTester binary from the value of the environment
638         variable LLDB_WEBKIT_TESTER_EXECUTABLE.
639         (TestSummaryProviders):
640         (TestSummaryProviders.shouldSkip): Skip the tests on non-Mac platforms.
641         (TestSummaryProviders.serial_test_WTFHashSet_tablesize_and_size):
642         (TestSummaryProviders.serial_test_WTFOptionSet_SummaryProvider_empty):
643         (TestSummaryProviders.serial_test_WTFOptionSet_SummaryProvider_simple):
644         (TestSummaryProviders.serial_test_WTFOptionSetProvider_empty):
645         (TestSummaryProviders.serial_test_WTFOptionSetProvider_simple):
646         Add back the unit tests originally added in r235376 (https://bugs.webkit.org/show_bug.cgi?id=188936).
647
648 2018-10-01  Olivier Blin  <olivier.blin@softathome.com>
649
650         [WPE] Update install-dependencies
651         https://bugs.webkit.org/show_bug.cgi?id=190127
652
653         Reviewed by Michael Catanzaro.
654
655         * wpe/install-dependencies:
656         libxrandr-dev is needed for gstreamer-vaapi in jhbuild
657         It is used by gstvaapidisplay_x11.c.
658         Add it only for Apt, already ok for Pacman and DNF.
659
660         Install libevent-dev for WebRTC (like GTK)
661
662         Install libasound2-dev for WebRTC.
663         Add it only for Apt, already ok for Pacam and DNF.
664
665         Install libgbm-dev for HeadlessViewBackend, which uses gbm.h
666
667 2018-10-01  Thibault Saunier  <tsaunier@igalia.com>
668
669         [Flatpak] Add libunwind in the sandbox
670         https://bugs.webkit.org/show_bug.cgi?id=190123
671
672         Allowing us to get proper traces in GStreamer trace grabing
673         debug functions.
674
675         Reviewed by Philippe Normand.
676
677         * flatpak/org.webkit.WebKit.yaml:
678
679 2018-09-29  Commit Queue  <commit-queue@webkit.org>
680
681         Unreviewed, rolling out r236631.
682         https://bugs.webkit.org/show_bug.cgi?id=190112
683
684         Caused various eventSender tests, including fast/css/pseudo-
685         active-style-sharing*, to fail (Requested by smfr on #webkit).
686
687         Reverted changeset:
688
689         "Regression(r236512): http/tests/navigation/keyboard-events-
690         during-provisional-navigation.html is flaky"
691         https://bugs.webkit.org/show_bug.cgi?id=190052
692         https://trac.webkit.org/changeset/236631
693
694 2018-09-28  Myles C. Maxfield  <mmaxfield@apple.com>
695
696         [WHLSL] Fix build after r236635
697         https://bugs.webkit.org/show_bug.cgi?id=189210
698
699         Unreviewed.
700
701         * WebGPUShadingLanguageRI/Intrinsics.js:
702         (Intrinsics.):
703         * WebGPUShadingLanguageRI/Test.js:
704         (tests.atomicsNull):
705         (tests.numThreads):
706         (tests.textureDimensionsNull):
707
708 2018-09-28  Myles C. Maxfield  <mmaxfield@apple.com>
709
710         [WHLSL] Allow uniform buffers to be used in the interpreter
711         https://bugs.webkit.org/show_bug.cgi?id=189210
712
713         Reviewed by Filip Pizlo.
714
715         Every lvalue is associated with an address space, and the propagation of these address spaces
716         matches the propagation of lvalues. Luckily, there was already the infrastructure to do most
717         of this, so this patch just goes the last few yards. It also updates the standard library to
718         allow for writing into all writable address spaces for out-params.
719
720         * WebGPUShadingLanguageRI/Checker.js:
721         (Checker.prototype.visitAssignment):
722         (Checker.prototype._finishVisitingPropertyAccess):
723         * WebGPUShadingLanguageRI/Intrinsics.js:
724         (Intrinsics.):
725         (Intrinsics.checkFalse):
726         (Intrinsics):
727         * WebGPUShadingLanguageRI/StandardLibrary.js:
728         (let.standardLibrary):
729         * WebGPUShadingLanguageRI/Test.js:
730         (tests.threadArrayRefLoad):
731         (tests.threadArrayRefLoadIntLiteral):
732         (tests.deviceArrayRefLoad):
733         (tests.threadArrayRefStore):
734         (tests.deviceArrayRefStore):
735         (tests.deviceArrayRefStoreIntLiteral):
736         (tests.threadPointerLoad):
737         (tests.threadPointerStore):
738         (tests.devicePointerLoad):
739         (tests.devicePointerStore):
740         (tests.arrayLoad):
741         (tests.constantAddressSpace):
742         (tests.standardLibraryDevicePointers):
743         (tests.threadArrayLoad): Deleted.
744         (tests.threadArrayLoadIntLiteral): Deleted.
745         (tests.deviceArrayLoad): Deleted.
746         (tests.threadArrayStore): Deleted.
747         (tests.deviceArrayStore): Deleted.
748         (tests.deviceArrayStoreIntLiteral): Deleted.
749
750 2018-09-28  Wenson Hsieh  <wenson_hsieh@apple.com>
751
752         No DOM API to instantiate an attachment for an img element
753         https://bugs.webkit.org/show_bug.cgi?id=189934
754         <rdar://problem/44743222>
755
756         Reviewed by Ryosuke Niwa.
757
758         Adds 3 new API tests in WKAttachmentTests:
759
760         `AddAttachmentToConnectedImageElement` verifies that an image element that's already in the document can gain an
761         attachment element via `HTMLAttachmentElement.getAttachmentIdentifier`.
762
763         `ChangeFileWrapperForPastedImage` verifies that an image that has been pasted produces a _WKAttachment in the UI
764         process, and changing the file wrapper of that _WKAttachment changes the pasted image.
765
766         `ConnectImageWithAttachmentToDocument` verifies that script can create an image element, ensure that it has an
767         attachment, and set a file wrapper for the generated _WKAttachment. Connecting the image to the document should
768         then result in an image element with the contents of the _WKAttachment's file wrapper.
769
770         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
771         (-[TestWKWebView imageElementSize]):
772         (-[TestWKWebView waitForImageElementSizeToBecome:]):
773         (TestWebKitAPI::TEST):
774         (-[TestWKWebView waitForAttachmentElementSizeToBecome:]): Deleted.
775
776 2018-09-28  Chris Dumez  <cdumez@apple.com>
777
778         Regression(r236512): http/tests/navigation/keyboard-events-during-provisional-navigation.html is flaky
779         https://bugs.webkit.org/show_bug.cgi?id=190052
780
781         Reviewed by Ryosuke Niwa.
782
783         The test relies on EventSender to send events to the page synchronously to the page and then uses console.log
784         to log those events. It also uses console.log() before sending those events to indicate what the test is about
785         to do. Note that console.log() normally causes the WebKitTestRunner to send an asynchronous IPC to the UIProcess
786         so that it can log the message.
787         The issue is that EventSender uses IPC::SendOption::UseFullySynchronousModeForTesting when sending the
788         sync IPC to the UIProcess. This option causes follow-up *asynchronous* IPC sent from the synchronous IPC reply
789         handler to be transformed into synchronous IPC.
790         As a result, some of the console.log IPC ended up being asynchronous and some other ended up being synchronous.
791         Because synchronous and asynchronous IPC is not necessarily processed in-order by the UIProcess, the logged
792         messages may end up being out of order, leading to flakiness.
793
794         To address the issue, we now make sure that InjectedBundle::outputText() uses a new IPC::SendOption indicating
795         that the IPC should always be sent asynchronously, even if the connection is in fully synchronous mode. As a
796         result, all text outputing IPC to the UIProcess will be asynchronous, and thus in order.
797
798         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
799         (WTR::InjectedBundle::outputText):
800
801 2018-09-28  Myles C. Maxfield  <mmaxfield@apple.com>
802
803         [WHLSL] Pointers should have automatically-generated equality checks
804         https://bugs.webkit.org/show_bug.cgi?id=189986
805
806         Reviewed by Filip Pizlo.
807
808         C allows for pointer equality, and we need it so people can do null checks.
809         This is generated the same way all our other NativeFuncs are generated - by Checker
810         creating NativeFuncs inside CallExpression.resolve().
811
812         This patch also does some general cleanup.
813
814         * WebGPUShadingLanguageRI/All.js: Everything the late checker does is no longer necessary.
815         The last thing it was doing was making sure that only primitive types are in resources, but
816         it's totally reasonable to put structs and arrays in resources, so I removed this pass. We
817         still have to add a check to make sure resources can't live within resources, but I expect
818         that will be done in the same place that semantics are checked.
819         * WebGPUShadingLanguageRI/AllocateAtEntryPoints.js:
820         (allocateAtEntryPoints.updateFunction.UpdateFunctions.prototype._addVariableDeclaration):
821         Name the global struct for debugging purposes.
822         * WebGPUShadingLanguageRI/CallExpression.js: 
823         (CallExpression.prototype._resolveByInstantiation): Cleanup
824         (CallExpression.prototype._resolveWithOperatorAnderIndexer): Ditto
825         (CallExpression.prototype._resolveWithOperatorLength): Ditto
826         (CallExpression.prototype._resolveWithReferenceComparator): Add support to automatically
827         generate pointer equality NativeFuncs.
828         * WebGPUShadingLanguageRI/EPtr.js: Implement pointer equality in the interpreter.
829         * WebGPUShadingLanguageRI/LateChecker.js: Removed.
830         * WebGPUShadingLanguageRI/LayoutBuffers.js: Renamed from Tools/WebGPUShadingLanguageRI/LateCheckAndLayoutBuffers.js.
831         (layoutBuffers):
832         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL Tests.xcodeproj/project.pbxproj:
833         * WebGPUShadingLanguageRI/NativeFunc.js:
834         * WebGPUShadingLanguageRI/OperatorArrayRefLength.js:
835         (OperatorArrayRefLength.prototype.instantiateImplementation):
836         (OperatorArrayRefLength):
837         * WebGPUShadingLanguageRI/Prepare.js:
838         (let.prepare):
839         * WebGPUShadingLanguageRI/SPIRV.html:
840         * WebGPUShadingLanguageRI/Test.html:
841         * WebGPUShadingLanguageRI/Test.js:
842         (tests.ternaryExpression):
843         (tests.break): Speed up testing time
844         (tests.doWhile): Ditto
845         (tests.forLoop): Ditto
846         (tests.atomics): Ditto
847         (tests.atomicsNull): Ditto
848         (tests.pointerEquality): Test pointer equality
849         (tests.standardLibraryDevicePointers):
850         (tests.devicePtrPtr): Deleted.
851         (tests.threadgroupPtrPtr): Deleted.
852         (tests.constantPtrPtr): Deleted.
853         * WebGPUShadingLanguageRI/index.html:
854
855 2018-09-28  Jiewen Tan  <jiewen_tan@apple.com>
856
857         [WebAuthN] Polish WebAuthN auto-test environment
858         https://bugs.webkit.org/show_bug.cgi?id=189283
859         <rdar://problem/44117828>
860
861         Reviewed by Chris Dumez.
862
863         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
864         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
865
866 2018-09-28  Chris Dumez  <cdumez@apple.com>
867
868         Drop support for cross-origin-window-policy header
869         https://bugs.webkit.org/show_bug.cgi?id=190081
870
871         Reviewed by Ryosuke Niwa.
872
873         190081_DropCrossOriginWindowPolicy
874
875         * DumpRenderTree/mac/DumpRenderTree.mm:
876         (enableExperimentalFeatures):
877         * DumpRenderTree/win/DumpRenderTree.cpp:
878         (enableExperimentalFeatures):
879         * WebKitTestRunner/TestController.cpp:
880         (WTR::TestController::resetPreferencesToConsistentValues):
881
882 2018-09-28  Koby Boyango  <koby.b@mce.systems>
883
884         [WTF] Add ExternalStringImpl, a StringImpl for user controlled buffers
885         https://bugs.webkit.org/show_bug.cgi?id=189991
886
887         Reviewed by Yusuke Suzuki.
888
889         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
890
891 2018-09-27  Ryan Haddad  <ryanhaddad@apple.com>
892
893         Update flakiness dashboard configuration for Mojave queues
894         https://bugs.webkit.org/show_bug.cgi?id=190068
895
896         Reviewed by Alexey Proskuryakov.
897
898         * TestResultServer/static-dashboards/builders.jsonp:
899
900 2018-09-27  Ryan Haddad  <ryanhaddad@apple.com>
901
902         Bring up queues for Mojave
903         https://bugs.webkit.org/show_bug.cgi?id=189935
904
905         Unreviewed infrastructure fix.
906
907         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove trigger, update bot assignment.
908
909 2018-09-24  Ryan Haddad  <ryanhaddad@apple.com>
910
911         Bring up queues for Mojave
912         https://bugs.webkit.org/show_bug.cgi?id=189935
913
914         Reviewed by Alexey Proskuryakov.
915
916         * BuildSlaveSupport/build.webkit.org-config/config.json:
917         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
918         (WebKitBuildbot):
919         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
920
921 2018-09-27  Ryan Haddad  <ryanhaddad@apple.com>
922
923         Increase the timeout for iOS Simulator data migration
924         https://bugs.webkit.org/show_bug.cgi?id=190059
925
926         Reviewed by Aakash Jain.
927
928         3 minutes isn't always enough time for the data migrator to complete
929         when booting up multiple iOS Simulators. Change the timeout to 10 minutes.
930
931         * Scripts/webkitpy/xcode/simulated_device.py:
932         (SimulatedDeviceManager): Create a constant for the default timeout.
933         (SimulatedDeviceManager.initialize_devices): Use new constant.
934         (SimulatedDeviceManager.swap): Ditto.
935         (SimulatedDeviceManager.wait_until_data_migration_is_done): Ditto.
936
937 2018-09-27  Alex Christensen  <achristensen@webkit.org>
938
939         URLParser should use TextEncoding through an abstract class
940         https://bugs.webkit.org/show_bug.cgi?id=190027
941
942         Reviewed by Andy Estes.
943
944         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
945         (TestWebKitAPI::checkURL):
946         (TestWebKitAPI::TEST_F):
947
948 2018-09-27  Ryan Haddad  <ryanhaddad@apple.com>
949
950         iOS Simulator bots should pass '--dedicated-simulators' to run-webkit-tests
951         https://bugs.webkit.org/show_bug.cgi?id=190042
952
953         Reviewed by Aakash Jain.
954
955         To make iOS Simulator bots resilient to issues that can arise from reusing
956         existing simulators, ensure that dedicated simulators are created for each test run.
957
958         * Scripts/webkitpy/common/config/ports.py:
959         (IOSSimulatorWK2Port.run_webkit_tests_command):
960
961 2018-09-27  Alex Christensen  <achristensen@webkit.org>
962
963         URLWithUserTypedString should return nil for URLs deemed to be invalid by WebCore::URL
964         https://bugs.webkit.org/show_bug.cgi?id=189979
965
966         Reviewed by Youenn Fablet.
967
968         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
969         (TestWebKitAPI::originalDataAsString):
970         (TestWebKitAPI::TEST):
971
972 2018-09-27  Basuke Suzuki  <Basuke.Suzuki@sony.com>
973
974         [Win][WebKit] Implement authentication dialog on MiniBrowser.
975         https://bugs.webkit.org/show_bug.cgi?id=189846
976
977         Reviewed by Fujii Hironori.
978
979         It was implemented for WebKitLegacy, but not for WebKit.
980         Also added text field to display Realm information.
981
982         * MiniBrowser/win/Common.cpp:
983         (authDialogProc):
984         (askCredential):
985         (displayAuthDialog): Deleted.
986         * MiniBrowser/win/Common.h:
987         * MiniBrowser/win/MiniBrowserLib.rc:
988         * MiniBrowser/win/MiniBrowserLibResource.h:
989         * MiniBrowser/win/ResourceLoadDelegate.cpp:
990         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
991         * MiniBrowser/win/WebKitBrowserWindow.cpp:
992         (createString):
993         (createUTF8String):
994         (createWKString):
995         (createWKURL):
996         (WebKitBrowserWindow::WebKitBrowserWindow):
997         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
998         (toNullTerminatedUTF8): Deleted.
999         * MiniBrowser/win/WebKitBrowserWindow.h:
1000
1001 2018-09-27  Youenn Fablet  <youenn@apple.com>
1002
1003         Enable getUserMedia in mini browser
1004         https://bugs.webkit.org/show_bug.cgi?id=190012
1005
1006         Reviewed by Eric Carlson.
1007
1008         Enable MediaDevices and mock capture devices.
1009         Grant mock devices access to any getUserMedia call.
1010         Covered by manual testing.
1011
1012         * MiniBrowser/mac/AppDelegate.m:
1013         (defaultConfiguration):
1014         * MiniBrowser/mac/WK2BrowserWindowController.m:
1015         (-[WK2BrowserWindowController _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
1016         (-[WK2BrowserWindowController _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
1017
1018 2018-09-27  Antoine Quint  <graouts@apple.com>
1019
1020         [Web Animations] Turn Web Animations with CSS integration on
1021         https://bugs.webkit.org/show_bug.cgi?id=184819
1022         <rdar://problem/39597337>
1023
1024         Reviewed by Dean Jackson.
1025
1026         * DumpRenderTree/TestOptions.h:
1027
1028 2018-09-26  Alex Christensen  <achristensen@webkit.org>
1029
1030         Unreviewed, rolling out r236524.
1031
1032         Broke API tests
1033
1034         Reverted changeset:
1035
1036         "URLWithUserTypedString should return nil for URLs deemed to
1037         be invalid by WebCore::URL"
1038         https://bugs.webkit.org/show_bug.cgi?id=189979
1039         https://trac.webkit.org/changeset/236524
1040
1041 2018-09-26  James Savage  <james.savage@apple.com>
1042
1043         Allow override of viewport configuration.
1044         https://bugs.webkit.org/show_bug.cgi?id=188772.
1045         <rdar://problem/43538892>.
1046
1047         Reviewed by Simon Fraser.
1048
1049         * WebKitTestRunner/TestController.cpp:
1050         (WTR::updateTestOptionsFromTestHeader): Parse new test option key from comments.
1051         * WebKitTestRunner/TestOptions.h:
1052         * WebKitTestRunner/ios/TestControllerIOS.mm:
1053         (WTR::TestController::platformConfigureViewForTest): Handle new test option by
1054         modifying the web view's preferences accordingly.
1055
1056 2018-09-26  Alex Christensen  <achristensen@webkit.org>
1057
1058         URLs with mismatched surrogate pairs in the host should fail to parse
1059         https://bugs.webkit.org/show_bug.cgi?id=190005
1060
1061         Reviewed by Chris Dumez.
1062
1063         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1064         (TestWebKitAPI::TEST_F):
1065
1066 2018-09-26  Alex Christensen  <achristensen@webkit.org>
1067
1068         URLWithUserTypedString should return nil for URLs deemed to be invalid by WebCore::URL
1069         https://bugs.webkit.org/show_bug.cgi?id=189979
1070         <rdar://problem/44119696>
1071
1072         Reviewed by Chris Dumez.
1073
1074         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
1075         (TestWebKitAPI::TEST):
1076
1077 2018-09-26  Ryosuke Niwa  <rniwa@webkit.org>
1078
1079         Selection should work across shadow boundary when initiated by a mouse drag
1080         https://bugs.webkit.org/show_bug.cgi?id=151380
1081         <rdar://problem/24363872>
1082
1083         Reviewed by Wenson Hsieh.
1084
1085         Added the support for internal:selectionAcrossShadowBoundariesEnabled test option.
1086
1087         * DumpRenderTree/TestOptions.cpp:
1088         (TestOptions::TestOptions):
1089         * DumpRenderTree/TestOptions.h:
1090         * DumpRenderTree/mac/DumpRenderTree.mm:
1091         (resetWebPreferencesToConsistentValues):
1092         (setWebPreferencesForTestOptions):
1093
1094 2018-09-26  Ryosuke Niwa  <rniwa@webkit.org>
1095
1096         MiniBrowser doesn't respect default enabled-ness of experimental and internal debug features
1097         https://bugs.webkit.org/show_bug.cgi?id=189989
1098
1099         Reviewed by Simon Fraser.
1100
1101         When the preference isn't found in user defaults, use the default value of each feature's enabledness.
1102
1103         * MiniBrowser/mac/AppDelegate.m:
1104         (defaultConfiguration):
1105
1106 2018-09-26  Philippe Normand  <pnormand@igalia.com>
1107
1108         [Flatpak] Bump to apr 1.6.5
1109
1110         Version 1.6.3 is no longer available on Apache's website.
1111
1112         Rubber-stamped by Michael Catanzaro.
1113
1114         * flatpak/org.webkit.WebKit.yaml:
1115
1116 2018-09-25  Jiewen Tan  <jiewen_tan@apple.com>
1117
1118         [WebAuthN] Make AuthenticatorManager
1119         https://bugs.webkit.org/show_bug.cgi?id=189279
1120         <rdar://problem/44116792>
1121
1122         Reviewed by Chris Dumez.
1123
1124         Besides the functionality to set the WebAuthenticationMockConfiguration. Three operations are
1125         added to manipulate Keychain: addTestKeyToKeychain, cleanUpKeychain and keyExistedInKeychain.
1126
1127         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1128         * TestWebKitAPI/Tests/ios/LocalAuthenticator.mm: Removed.
1129         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1130         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1131         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
1132         (WTR::TestRunner::addTestKeyToKeychain):
1133         (WTR::TestRunner::cleanUpKeychain):
1134         (WTR::TestRunner::isKeyExisted):
1135         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1136         * WebKitTestRunner/TestController.cpp:
1137         (WTR::TestController::addTestKeyToKeychain):
1138         (WTR::TestController::cleanUpKeychain):
1139         (WTR::TestController::isKeyExisted):
1140         (WTR::TestController::setWebAuthenticationMockConfiguration):
1141         * WebKitTestRunner/TestController.h:
1142         * WebKitTestRunner/TestInvocation.cpp:
1143         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1144         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1145         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1146         (WTR::TestController::addTestKeyToKeychain):
1147         (WTR::TestController::cleanUpKeychain):
1148         (WTR::TestController::keyExistedInKeychain):
1149
1150 2018-09-25  Sihui Liu  <sihui_liu@apple.com>
1151
1152         Move Service Worker Management from Storage Process to Network Process
1153         https://bugs.webkit.org/show_bug.cgi?id=189422
1154
1155         Reviewed by Youenn Fablet.
1156
1157         Change a check in ServiceWorkers.HasServiceWorkerRegistrationBit as storage process is not
1158         launched during service worker operations now.
1159
1160         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1161
1162 2018-09-25  Eric Carlson  <eric.carlson@apple.com>
1163
1164         [MediaStream] Update constraints supported by getDisplayMedia
1165         https://bugs.webkit.org/show_bug.cgi?id=189930
1166         <rdar://problem/44740305>
1167
1168         Unreviewed, fix test broken by r236465.
1169
1170         * TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm:
1171         (TestWebKitAPI::TEST_F):
1172
1173 2018-09-25  Myles C. Maxfield  <mmaxfield@apple.com>
1174
1175         [WHSL] Implement semantics
1176         https://bugs.webkit.org/show_bug.cgi?id=189134
1177
1178         Reviewed by Filip Pizlo.
1179
1180         This patch adds parsing support and adds the checks required to support HLSL-style semantics.
1181
1182         There are 3 places where semantics are allowed:
1183
1184         1. In a field in a struct. E.g.
1185
1186         struct R {
1187             float4 position : SV_Position;
1188         }
1189         vertex R foo() {
1190             ...
1191         }
1192
1193         2. In a parameter of a function. If the function is not an entry point, the semantic is ignored.
1194
1195         compute void foo(device float[] data : buffer(u0)) {
1196             ...
1197         }
1198
1199         3. On a function. This is so you don't have to create structs for the return types of simple vertex shaders.
1200
1201         vertex float4 foo() : SV_Position {
1202             ...
1203         }
1204
1205         The semantics are partitioned into 4 types:
1206
1207         1. Built-in variables. For example, : SV_Position.
1208         2. Resources. For example, : register(u0).
1209         3. Stage-in / stage-out variables. For example, : attribute(0).
1210         4. Specialization constants. For example, : specialized.
1211
1212         The semantics are validated according to a collection of rules:
1213
1214         - The same entry point can't list the same semantic twice
1215         - Each built-in type has an appropriate type that is listed in the spec. 
1216         - Each built-in is appropriate as either an input or an output of a particular shader stage
1217         - Resource semantics have to have the appropriate type (e.g. can't use register(s0) on a buffer)
1218         - Resources can't be output from entry points
1219         - The resource semantic mode must match the address space of the resource
1220         - Stage-in and stage-out variables have to be POD
1221         - Specialization constants can't be output from entry points, and have to be numbers
1222
1223         * WebGPUShadingLanguageRI/All.js:
1224         * WebGPUShadingLanguageRI/BuiltInSemantic.js: Added.
1225         (BuiltInSemantic):
1226         (BuiltInSemantic.prototype.get name):
1227         (BuiltInSemantic.prototype.get extraArguments):
1228         (BuiltInSemantic.prototype.isAcceptableType):
1229         (BuiltInSemantic.prototype.isAcceptableForShaderType):
1230         (BuiltInSemantic.prototype.toString):
1231         * WebGPUShadingLanguageRI/CallExpression.js:
1232         (CallExpression.prototype._resolveWithOperatorAnderIndexer):
1233         (CallExpression.prototype._resolveWithOperatorLength):
1234         * WebGPUShadingLanguageRI/Checker.js:
1235         (Checker):
1236         (Checker.prototype.visitProgram):
1237         (Checker.prototype._checkSemantics.Item):
1238         (Checker.prototype._checkSemantics.Item.prototype.get type):
1239         (Checker.prototype._checkSemantics.Item.prototype.get semantic):
1240         (Checker.prototype._checkSemantics.Gatherer):
1241         (Checker.prototype._checkSemantics.Gatherer.prototype.reset):
1242         (Checker.prototype._checkSemantics.Gatherer.prototype.set currentSemantic):
1243         (Checker.prototype._checkSemantics.Gatherer.prototype.get currentSemantic):
1244         (Checker.prototype._checkSemantics.Gatherer.prototype.get result):
1245         (Checker.prototype._checkSemantics.Gatherer.prototype.visitEnumType):
1246         (Checker.prototype._checkSemantics.Gatherer.prototype.visitVectorType):
1247         (Checker.prototype._checkSemantics.Gatherer.prototype.visitMatrixType):
1248         (Checker.prototype._checkSemantics.Gatherer.prototype.visitNativeType):
1249         (Checker.prototype._checkSemantics.Gatherer.prototype.visitStructType):
1250         (Checker.prototype._checkSemantics.Gatherer.prototype.visitTypeRef):
1251         (Checker.prototype._checkSemantics.Gatherer.prototype.visitPtrType):
1252         (Checker.prototype._checkSemantics.Gatherer.prototype.visitArrayRefType):
1253         (Checker.prototype._checkSemantics.Gatherer.prototype.visitArrayType):
1254         (Checker.prototype._checkSemantics.Gatherer.prototype.visitFuncParameter):
1255         (Checker.prototype._checkSemantics.checkDuplicateSemantics):
1256         (Checker.prototype._checkSemantics.checkSemanticTypes):
1257         (Checker.prototype._checkSemantics.checkSemanticForShaderType):
1258         (Checker.prototype._checkSemantics.PODChecker.prototype.visitEnumType):
1259         (Checker.prototype._checkSemantics.PODChecker.prototype.visitArrayType):
1260         (Checker.prototype._checkSemantics.PODChecker.prototype.visitVectorType):
1261         (Checker.prototype._checkSemantics.PODChecker.prototype.visitMatrixType):
1262         (Checker.prototype._checkSemantics.PODChecker.prototype.visitNativeType):
1263         (Checker.prototype._checkSemantics.PODChecker.prototype.visitPtrType):
1264         (Checker.prototype._checkSemantics.PODChecker.prototype.visitArrayRefType):
1265         (Checker.prototype._checkSemantics.PODChecker.prototype.visitStructType):
1266         (Checker.prototype._checkSemantics.PODChecker.prototype.visitTypeRef):
1267         (Checker.prototype._checkSemantics.PODChecker):
1268         (Checker.prototype._checkSemantics.checkPODData):
1269         (Checker.prototype._checkSemantics):
1270         (Checker.prototype._checkShaderType):
1271         (Checker.prototype._checkOperatorOverload):
1272         (Checker.prototype.visitFuncDef):
1273         (Checker.prototype.visitEnumType):
1274         (Checker.prototype.visitArrayType):
1275         (Checker.prototype.visitMakePtrExpression):
1276         (Checker.prototype.visitMakeArrayRefExpression):
1277         (Checker.prototype._finishVisitingPropertyAccess):
1278         (Checker.prototype.visitIndexExpression):
1279         (Checker.prototype.visitReturn):
1280         (Checker.prototype.visitSwitchStatement):
1281         (Checker.prototype.visitTernaryExpression):
1282         (Checker.prototype.visitCallExpression):
1283         * WebGPUShadingLanguageRI/Field.js:
1284         (Field):
1285         (Field.prototype.get semantic):
1286         (Field.prototype.toString):
1287         * WebGPUShadingLanguageRI/Func.js:
1288         (Func):
1289         (Func.prototype.get semantic):
1290         (Func.prototype.toDeclString):
1291         * WebGPUShadingLanguageRI/FuncDef.js:
1292         (FuncDef):
1293         * WebGPUShadingLanguageRI/FuncParameter.js:
1294         (FuncParameter):
1295         (FuncParameter.prototype.get semantic):
1296         (FuncParameter.prototype.toString):
1297         * WebGPUShadingLanguageRI/Intrinsics.js:
1298         * WebGPUShadingLanguageRI/LateChecker.js:
1299         (LateChecker.prototype.visitReferenceType):
1300         (LateChecker):
1301         (LateChecker.prototype._checkShaderType): Deleted.
1302         (LateChecker.prototype.visitFuncDef): Deleted.
1303         * WebGPUShadingLanguageRI/NativeFunc.js:
1304         (NativeFunc):
1305         * WebGPUShadingLanguageRI/Parse.js:
1306         (parseParameter):
1307         (parseFuncDecl):
1308         (parseFuncDef):
1309         (parseStageInOutSemantic):
1310         (parseResourceSemantic):
1311         (parseSpecializationConstantSemantic):
1312         (parseBuiltInSemantic):
1313         (parseField):
1314         (parseNativeFunc):
1315         * WebGPUShadingLanguageRI/ProgramWithUnnecessaryThingsRemoved.js:
1316         (programWithUnnecessaryThingsRemoved):
1317         * WebGPUShadingLanguageRI/ResourceSemantic.js: Added.
1318         (ResourceSemantic):
1319         (ResourceSemantic.prototype.get resourceMode):
1320         (ResourceSemantic.prototype.get index):
1321         (ResourceSemantic.prototype.get space):
1322         (ResourceSemantic.prototype.isAcceptableType):
1323         (ResourceSemantic.prototype.isAcceptableForShaderType):
1324         (ResourceSemantic.prototype.toString):
1325         * WebGPUShadingLanguageRI/Rewriter.js:
1326         (Rewriter.prototype.visitFuncParameter):
1327         (Rewriter.prototype.visitField):
1328         (Rewriter.prototype.visitBuiltInSemantic):
1329         (Rewriter.prototype.visitResourceSemantic):
1330         (Rewriter.prototype.visitStageInOutSemantic):
1331         (Rewriter.prototype.visitSpecializationConstantSemantic):
1332         (Rewriter):
1333         * WebGPUShadingLanguageRI/SPIRV.html:
1334         * WebGPUShadingLanguageRI/Semantic.js: Added.
1335         (Semantic):
1336         (Semantic.prototype.get origin):
1337         (Semantic.prototype.equalToOtherSemantic.Comparer.prototype.visitBuiltInSemantic):
1338         (Semantic.prototype.equalToOtherSemantic.Comparer.prototype.visitResourceSemantic):
1339         (Semantic.prototype.equalToOtherSemantic.Comparer.prototype.visitStageInOutSemantic):
1340         (Semantic.prototype.equalToOtherSemantic.Comparer.prototype.visitSpecializationConstantSemantic):
1341         (Semantic.prototype.equalToOtherSemantic.Comparer):
1342         (Semantic.prototype.equalToOtherSemantic):
1343         * WebGPUShadingLanguageRI/SpecializationConstantSemantic.js: Copied from Tools/WebGPUShadingLanguageRI/Field.js.
1344         (SpecializationConstantSemantic):
1345         (SpecializationConstantSemantic.prototype.isAcceptableType):
1346         (SpecializationConstantSemantic.prototype.isAcceptableForShaderType):
1347         (SpecializationConstantSemantic.prototype.toString):
1348         * WebGPUShadingLanguageRI/StageInOutSemantic.js: Copied from Tools/WebGPUShadingLanguageRI/FuncDef.js.
1349         (StageInOutSemantic):
1350         (StageInOutSemantic.prototype.get index):
1351         (StageInOutSemantic.prototype.isAcceptableType):
1352         (StageInOutSemantic.prototype.isAcceptableForShaderType):
1353         (StageInOutSemantic.prototype.toString):
1354         * WebGPUShadingLanguageRI/StatementCloner.js:
1355         (StatementCloner.prototype.visitNativeFunc):
1356         * WebGPUShadingLanguageRI/SynthesizeArrayOperatorLength.js:
1357         (synthesizeArrayOperatorLength):
1358         * WebGPUShadingLanguageRI/SynthesizeCopyConstructorOperator.js:
1359         (synthesizeCopyConstructorOperator):
1360         * WebGPUShadingLanguageRI/SynthesizeDefaultConstructorOperator.js:
1361         (synthesizeDefaultConstructorOperator):
1362         * WebGPUShadingLanguageRI/SynthesizeEnumFunctions.js:
1363         (synthesizeEnumFunctions):
1364         * WebGPUShadingLanguageRI/SynthesizeStructAccessors.js:
1365         (setupAnder):
1366         (synthesizeStructAccessorsForStructType):
1367         * WebGPUShadingLanguageRI/Test.html:
1368         * WebGPUShadingLanguageRI/Test.js:
1369         (tests.shaderTypes):
1370         * WebGPUShadingLanguageRI/Visitor.js:
1371         (Visitor.prototype.visitFunc):
1372         (Visitor.prototype.visitFuncParameter):
1373         (Visitor.prototype.visitField):
1374         (Visitor.prototype.visitBuiltInSemantic):
1375         (Visitor.prototype.visitResourceSemantic):
1376         (Visitor.prototype.visitStageInOutSemantic):
1377         (Visitor.prototype.visitSpecializationConstantSemantic):
1378         (Visitor):
1379         * WebGPUShadingLanguageRI/index.html:
1380
1381 2018-09-25  Thomas Denney  <tdenney@apple.com>
1382
1383         [WHLSL] Test suite for Metal code generation
1384         https://bugs.webkit.org/show_bug.cgi?id=187738
1385
1386         Reviewed by Myles C. Maxfield.
1387
1388         This patch adds an Xcode project that contains a Cocoa app that can be
1389         used for running WHLSL shaders on the GPU. It also contains an Xcode
1390         test suite that runs all of the tests in Test.js on the GPU.
1391
1392         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/.gitignore: Added.
1393         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/AppDelegate.h: Added.
1394         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/AppDelegate.m: Added.
1395         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Assets.xcassets/AppIcon.appiconset/Contents.json: Added.
1396         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Assets.xcassets/Contents.json: Added.
1397         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Base.lproj/Main.storyboard: Added.
1398         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CompileResult.h: Added.
1399         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CompileResult.m: Added.
1400         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Compiler.h: Added.
1401         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Compiler.m: Added.
1402         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CustomMetalView.h: Added.
1403         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CustomMetalView.m: Added.
1404         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Demo shaders/Default.whlsl: Added.
1405         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Demo shaders/Julia.whlsl: Added.
1406         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Demo shaders/Mandelbrot.whlsl: Added.
1407         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Info.plist: Added.
1408         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OffscreenRenderer.h: Added.
1409         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OffscreenRenderer.m: Added.
1410         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OnscreenRenderer.h: Added.
1411         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OnscreenRenderer.m: Added.
1412         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/Renderer.h: Added.
1413         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/Renderer.m: Added.
1414         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestCallArgument.h: Added.
1415         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestCallArgument.m: Added.
1416         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestDescription.h: Added.
1417         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestDescription.m: Added.
1418         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.h: Added.
1419         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m: Added.
1420         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.h: Added.
1421         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.m: Added.
1422         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.h: Added.
1423         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m: Added.
1424         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/WHLSL.entitlements: Added.
1425         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/_SharedMetal.txt: Added.
1426         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/main.m: Added.
1427         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL Tests.xcodeproj/project.pbxproj: Added.
1428         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL ToyTests/Info.plist: Added.
1429         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL ToyTests/WHLSL_ToyTests.m: Added.
1430         * WebGPUShadingLanguageRI/Test.js:
1431         (tests.lotsOfLocalVariables):
1432
1433 2018-09-25  Myles C. Maxfield  <mmaxfield@apple.com>
1434
1435         Unreviewed build fix after r236455
1436         https://bugs.webkit.org/show_bug.cgi?id=189121
1437
1438         * WebGPUShadingLanguageRI/Test.js:
1439         (tests.shaderStages):
1440
1441 2018-09-24  Myles C. Maxfield  <mmaxfield@apple.com>
1442
1443         [WHLSL] Not all functions should be able to run in all shader stages
1444         https://bugs.webkit.org/show_bug.cgi?id=189121
1445
1446         Reviewed by Filip Pizlo.
1447
1448         ddx() and ddy() can only run in fragment shaders, and the barrier functions can only run in compute shaders.
1449         ddx_coarse() & friends are currently implemented as just calling ddx(), so we only need to modify those functions
1450         if/when we make them native.
1451
1452         The texture sampling functions that use implicit derivatives can run in any shader stage - they just use a LOD of
1453         0. Therefore, those functions are unchanged.
1454
1455         * WebGPUShadingLanguageRI/All.js:
1456         * WebGPUShadingLanguageRI/Intrinsics.js:
1457         * WebGPUShadingLanguageRI/LateChecker.js:
1458         (LateChecker.prototype._checkShaderType):
1459         * WebGPUShadingLanguageRI/NativeFunc.js:
1460         (NativeFunc):
1461         (NativeFunc.prototype.get stage):
1462         (NativeFunc.prototype.toDeclString):
1463         * WebGPUShadingLanguageRI/Parse.js:
1464         (parseFuncDecl):
1465         (parseNativeFunc):
1466         (parseNative):
1467         * WebGPUShadingLanguageRI/Prepare.js:
1468         (let.prepare):
1469         * WebGPUShadingLanguageRI/SPIRV.html:
1470         * WebGPUShadingLanguageRI/StandardLibrary.js:
1471         (let.standardLibrary):
1472         * WebGPUShadingLanguageRI/StatementCloner.js:
1473         (StatementCloner.prototype.visitNativeFunc):
1474         * WebGPUShadingLanguageRI/Test.html:
1475         * WebGPUShadingLanguageRI/Test.js:
1476         (tests.shaderStages):
1477         * WebGPUShadingLanguageRI/WSyntaxError.js:
1478         (WSyntaxError.prototype.toString):
1479         (WSyntaxError):
1480         * WebGPUShadingLanguageRI/index.html:
1481
1482 2018-09-24  Thomas Denney  <tdenney@apple.com>
1483
1484         [WHLSL] Implement trap statements in Metal code generation
1485         https://bugs.webkit.org/show_bug.cgi?id=189615
1486
1487         Reviewed by Myles C. Maxfield.
1488
1489         Each function called by an entry point now receives an additional
1490         boolean pointer parameter, which is set to false if the function traps.
1491         After each function call (to a non-native function) this trap parameter
1492         is checked. The behavior of the interpreter has also been updated so
1493         that a function entry point catches the trap and instead returns zero,
1494         matching the behavior of compiled code.
1495
1496         * WebGPUShadingLanguageRI/Evaluator.js: Adds a new flag to allow the
1497         test suite to check for traps and also returns zero from entry points
1498         whose invocation trapped.
1499         * WebGPUShadingLanguageRI/Metal/MSLBackend.js: Pass program to function
1500         declarations.
1501         * WebGPUShadingLanguageRI/Metal/MSLCodegenAll.js: Update dependencies.
1502         * WebGPUShadingLanguageRI/Metal/MSLFunctionDeclaration.js: Add program
1503         property.
1504         * WebGPUShadingLanguageRI/Metal/MSLFunctionDefinition.js: Ditto.
1505         * WebGPUShadingLanguageRI/Metal/MSLInsertTrapParameter.js: Added.
1506         * WebGPUShadingLanguageRI/Metal/MSLStatementEmitter.js: Conforms to the
1507         new trapping behavior.
1508         * WebGPUShadingLanguageRI/Test.js: Update tests that trap.
1509
1510 2018-09-24  Thomas Denney  <tdenney@apple.com>
1511
1512         [WHLSL] It shouldn’t be possible to use ternary expressions as l-values
1513         https://bugs.webkit.org/show_bug.cgi?id=189290
1514
1515         Reviewed by Myles C. Maxfield.
1516
1517         It is no longer possible for a ternary expression to be treated as an
1518         l-value. This patch adds several test cases to verify that this is the
1519         case.
1520
1521         * WebGPUShadingLanguageRI/Checker.js:
1522         (Checker.prototype.visitTernaryExpression): No longer check isLValue.
1523         * WebGPUShadingLanguageRI/NormalUsePropertyResolver:
1524         (NormalUsePropertyResolver.visitTernaryExpression): Deleted.
1525         * WebGPUShadingLanguageRI/Rewriter.js:
1526         (Rewriter.prototype.visitTernaryExpression): No longer copy isLValue.
1527         * WebGPUShadingLanguageRI/TernaryExpression.js:
1528         (TernaryExpression):
1529         (TernaryExpression.prototype.get elseExpression):
1530         (TernaryExpression.prototype.get isLValue): Deleted.
1531         (TernaryExpression.prototype.set isLValue): Deleted.
1532         * WebGPUShadingLanguageRI/Test.js:
1533         (tests.ternaryExpression): Add checks for failure if a failure is used
1534         as an l-value.
1535         (ternaryExpressionIsLValue.node.TernaryExpressionVisitor.prototype.visitTernaryExpression): Deleted.
1536         (ternaryExpressionIsLValue.node.TernaryExpressionVisitor): Deleted.
1537         (tests.ternaryExpressionIsLValue): Deleted.
1538
1539 2018-09-24  Jer Noble  <jer.noble@apple.com>
1540
1541         SharedBuffer should have an equality test
1542         https://bugs.webkit.org/show_bug.cgi?id=189919
1543
1544         Reviewed by Alex Christensen.
1545
1546         * TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp:
1547         (TestWebKitAPI::TEST_F):
1548
1549 2018-09-24  Alex Christensen  <achristensen@webkit.org>
1550
1551         Prepare to replace WKBundleFileHandleCreateWithPath with a version that takes a WKBundlePageRef
1552         https://bugs.webkit.org/show_bug.cgi?id=189929
1553
1554         Reviewed by Andy Estes.
1555
1556         * TestWebKitAPI/Tests/WebKit/WKBundleFileHandle_Bundle.cpp:
1557
1558 2018-09-24  Thomas Denney  <tdenney@apple.com>
1559
1560         [WHLSL] Casting user-created types to themselves should always work
1561         https://bugs.webkit.org/show_bug.cgi?id=189113
1562
1563         Reviewed by Myles C. Maxfield.
1564
1565         Casting user-defined types to themselves worked already, but we didn't
1566         test it anywhere.
1567
1568         * WebGPUShadingLanguageRI/Test.js:
1569         (tests.selfCasts):
1570
1571 2018-09-24  Zan Dobersek  <zdobersek@igalia.com>
1572
1573         Unreviewed build fix for Jhbuild-using ports.
1574
1575         * gstreamer/patches/gst-plugins-good-0010-matroskademux-Emit-no-more-pads-after-parsing-Tracks.patch:
1576         Adjust the patch so it applies cleanly on the 1.14.3 version of the
1577         gst-plugins-good package.
1578
1579 2018-09-24  Ryan Haddad  <ryanhaddad@apple.com>
1580
1581         Update flakiness dashboard configuration for iOS 12 queues
1582         https://bugs.webkit.org/show_bug.cgi?id=189688
1583
1584         Reviewed by Alexey Proskuryakov.
1585
1586         * TestResultServer/static-dashboards/builders.jsonp:
1587
1588 2018-09-24  Alicia Boya García  <aboya@igalia.com>
1589
1590         [GStreamer] Unreviewed build fix.
1591
1592         A GStreamer patch was not applying cleanly on 1.14.3.
1593
1594         * gstreamer/patches/gst-plugins-good-0008-matroskademux-Refactor-track-parsing-out-from-adding.patch:
1595
1596 2018-09-24  Alicia Boya García  <aboya@igalia.com>
1597
1598         [MSE][GStreamer] Use no-more-pads event for noticing initialization segments
1599         https://bugs.webkit.org/show_bug.cgi?id=189868
1600
1601         Reviewed by Xabier Rodriguez-Calvar.
1602
1603         Added patch from https://bugzilla.gnome.org/show_bug.cgi?id=797187
1604
1605         * gstreamer/jhbuild.modules:
1606         * gstreamer/patches/gst-plugins-good-0010-matroskademux-Emit-no-more-pads-after-parsing-Tracks.patch: Added.
1607
1608 2018-09-24  Alicia Boya García  <aboya@igalia.com>
1609         [MSE][GStreamer] Add patch to jhbuild: matroskademux: Allow Matroska headers to be read more than once
1610         https://bugs.webkit.org/show_bug.cgi?id=185731
1611
1612         Reviewed by Xabier Rodriguez-Calvar.
1613
1614         Upstream bug in GStreamer: https://bugzilla.gnome.org/show_bug.cgi?id=793333
1615
1616         This fixes YTTV 35. AppendMultipleInitOpusAudio (and any other use
1617         case where two WebM initialization segments are appended on a row).
1618
1619         * gstreamer/jhbuild.modules:
1620         * gstreamer/patches/gst-plugins-good-0007-matroskademux-Allow-Matroska-headers-to-be-read-more.patch: Added.
1621         * gstreamer/patches/gst-plugins-good-0008-matroskademux-Refactor-track-parsing-out-from-adding.patch: Added.
1622         * gstreamer/patches/gst-plugins-good-0009-matroskademux-Parse-successive-Tracks-elements.patch: Added.
1623
1624 2018-09-22  Myles C. Maxfield  <mmaxfield@apple.com>
1625
1626         [WHSL] Need grammar to specify kernel group size
1627         https://bugs.webkit.org/show_bug.cgi?id=189108
1628
1629         Reviewed by Dean Jackson.
1630
1631         In HLSL, compute functions are annotated with their workgroup size.
1632         For example,
1633
1634         [numthreads(3, 4, 5)] compute void foo(...) { ... }
1635
1636         * WebGPUShadingLanguageRI/All.js:
1637         * WebGPUShadingLanguageRI/Func.js:
1638         (Func):
1639         (Func.prototype.get attributeBlock):
1640         * WebGPUShadingLanguageRI/FuncAttribute.js: Copied from Tools/WebGPUShadingLanguageRI/FuncDef.js.
1641         (FuncAttribute):
1642         * WebGPUShadingLanguageRI/FuncDef.js:
1643         (FuncDef):
1644         * WebGPUShadingLanguageRI/FuncNumThreadsAttribute.js: Copied from Tools/WebGPUShadingLanguageRI/FuncDef.js.
1645         (FuncNumThreadsAttribute):
1646         (FuncNumThreadsAttribute.prototype.get x):
1647         (FuncNumThreadsAttribute.prototype.get y):
1648         (FuncNumThreadsAttribute.prototype.get z):
1649         * WebGPUShadingLanguageRI/LateChecker.js:
1650         (LateChecker.prototype._checkShaderType):
1651         * WebGPUShadingLanguageRI/Parse.js:
1652         (parseAttributeBlock):
1653         (parseFuncDecl):
1654         (parseFuncDef):
1655         (parseNativeFunc):
1656         * WebGPUShadingLanguageRI/SPIRV.html:
1657         * WebGPUShadingLanguageRI/StatementCloner.js:
1658         (StatementCloner.prototype.visitFuncDef):
1659         (StatementCloner.prototype.visitFuncNumThreadsAttribute):
1660         (StatementCloner):
1661         * WebGPUShadingLanguageRI/Test.html:
1662         * WebGPUShadingLanguageRI/Test.js:
1663         (tests.numThreads):
1664         * WebGPUShadingLanguageRI/Visitor.js:
1665         (Visitor.prototype.visitFunc):
1666         (Visitor.prototype.visitFuncNumThreadsAttribute):
1667         (Visitor):
1668         * WebGPUShadingLanguageRI/index.html:
1669
1670 2018-09-22  Myles C. Maxfield  <mmaxfield@apple.com>
1671
1672         Native functions which accept pointers need to do null checks
1673         https://bugs.webkit.org/show_bug.cgi?id=189883
1674
1675         Reviewed by Dean Jackson.
1676
1677         Simply guard all the places where we write through an author-provided pointer.
1678
1679         * WebGPUShadingLanguageRI/Intrinsics.js:
1680         (Intrinsics.):
1681         * WebGPUShadingLanguageRI/Test.js:
1682         (tests.textureDimensionsNull):
1683
1684 2018-09-22  Myles C. Maxfield  <mmaxfield@apple.com>
1685
1686         [WHLSL] Implement atomic operations and barriers
1687         https://bugs.webkit.org/show_bug.cgi?id=189025
1688
1689         Reviewed by Dean Jackson.
1690
1691         In the interpreter, atomic operations don't need to be atomic.
1692
1693         * WebGPUShadingLanguageRI/Intrinsics.js:
1694         (Intrinsics.):
1695         * WebGPUShadingLanguageRI/StandardLibrary.js:
1696         (let.standardLibrary):
1697         * WebGPUShadingLanguageRI/Test.js:
1698         (tests.atomics):
1699
1700 2018-09-22  Thibault Saunier  <tsaunier@igalia.com>
1701
1702         [WPE] Be very permissive in the MiniBrowser.
1703         https://bugs.webkit.org/show_bug.cgi?id=189800
1704
1705         This is just a test tool and we should make
1706         it just work, security and privacy is not really
1707         a primary focus here.
1708
1709         Reviewed by Žan Doberšek.
1710
1711         * MiniBrowser/wpe/main.cpp:
1712         (decidePermissionRequest):
1713         (main):
1714
1715 2018-09-21  Thomas Denney  <tdenney@apple.com>
1716
1717         [WHLSL] Local variables should be statically allocated
1718         https://bugs.webkit.org/show_bug.cgi?id=188402
1719
1720         Reviewed by Myles C. Maxfield.
1721
1722         An additional preparation stage is now performed so that all local
1723         variables and function parameters are allocated in a single struct at
1724         entry points. A pointer to this struct is then passed for function
1725         calls.
1726
1727         * WebGPUShadingLanguageRI/All.js: Update dependencies.
1728         * WebGPUShadingLanguageRI/AllocateAtEntryPoints.js: Added new stage.
1729         * WebGPUShadingLanguageRI/CallExpression.js:
1730         (CallExpression.prototype.set argumentList): Add setter because
1731         allocateAtEntryPoints needs to change this.
1732         * WebGPUShadingLanguageRI/EBufferBuilder.js: Remove a redundant
1733         constructor that wasn't used anywhere.
1734         * WebGPUShadingLanguageRI/Func.js:
1735         (Func.prototype.set parameters): Add setter.
1736         * WebGPUShadingLanguageRI/FuncDef.js:
1737         (FuncDef.prototype.set body): Ditto.
1738         * WebGPUShadingLanguageRI/Prepare.js:
1739         (let.prepare): Add call to allocateAtEntryPoints. This call cannot
1740         happen any earlier because it depends on having types for call
1741         arguments.
1742         * WebGPUShadingLanguageRI/Rewriter.js:
1743         (Rewriter.prototype.visitReturn): Resolve issue where the return
1744         statement's function wasn't copied. A null check is required as the
1745         Rewriter might be used before this property is set.
1746         * WebGPUShadingLanguageRI/SPIRV.html: Update dependencies.
1747         * WebGPUShadingLanguageRI/SynthesizeStructAccessors.js: Abstracted logic
1748         into a separate function so that allocateAtEntryPoints can create the
1749         accessors for the struct type it introduces.
1750         * WebGPUShadingLanguageRI/Test.html: Update dependencies.
1751         * WebGPUShadingLanguageRI/Test.js: Add new tests to verify the static
1752         allocation transform works safely.
1753         * WebGPUShadingLanguageRI/index.html: Update dependencies.
1754
1755 2018-09-21  Jonathan Bedard  <jbedard@apple.com>
1756
1757         Bring up queues for iOS 12 (Build fix)
1758         https://bugs.webkit.org/show_bug.cgi?id=189683
1759
1760         Unreviewed build fix.
1761
1762         We should not build ImageDiff as x86 by default since 32 bit projects are
1763         deprecated in Xcode. ImageDiff should only be built once.
1764
1765         * Scripts/build-webkit:
1766         * Scripts/webkitdirs.pm:
1767         (argumentsForConfiguration):
1768
1769 2018-09-21  Adrian Perez de Castro  <aperez@igalia.com>
1770
1771         [WPE] Built RPM of WPE webkit fails to install with "nothing provides libWPEToolingBackends.so()"
1772         https://bugs.webkit.org/show_bug.cgi?id=189797
1773
1774         Reviewed by Žan Doberšek.
1775
1776         * wpe/backends/CMakeLists.txt: Make libWPEToolingBackends a static library to avoid
1777         the need for installing it. This works fine because the library only contains utility
1778         code intended to be reused from other various components (MiniBrowser, WebKitTestRunner).
1779
1780 2018-09-20  Daniel Bates  <dabates@apple.com>
1781
1782         Move IOKitSPI.h from TestRunnerShared to PAL
1783         https://bugs.webkit.org/show_bug.cgi?id=189804
1784
1785         Reviewed by Wenson Hsieh.
1786
1787         Towards fixing <https://bugs.webkit.org/show_bug.cgi?id=189604> move the IOKit SPI forward
1788         declarations to PAL so that they can be shared by WebKit, DumpRenderTree and WebKitTestRunner.
1789
1790         No functionality changed. So, no new tests.
1791
1792         * TestRunnerShared/EventSerialization/mac/EventSerializerMac.mm:
1793         * TestRunnerShared/spi/UIKitTestSPI.h:
1794         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1795         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1796
1797 2018-09-20  Thomas Denney  <tdenney@apple.com>
1798
1799         [WHLSL] Metal code generation
1800         https://bugs.webkit.org/show_bug.cgi?id=187735
1801
1802         Reviewed by Myles C. Maxfield.
1803
1804         Adds support for generating Metal Shading Language from WHLSL. Clients
1805         should include the file MetalCodegenAll.js and then call whlslToMsl
1806         with their program source code to compile to Metal.
1807
1808         * WebGPUShadingLanguageRI/ArrayType.js:
1809         (ArrayType.prototype.get arrayRefType): Adds the arrayRefType method to
1810         all types to find the type of that expression when it is used in a
1811         MakeArrayRefExpression.
1812         * WebGPUShadingLanguageRI/MakeArrayRefExpression.js:
1813         (MakeArrayRefExpression):
1814         (MakeArrayRefExpression.prototype.get type): Uses the new arrayRefType
1815         getter on all types to find the type of the expression.
1816         * WebGPUShadingLanguageRI/Metal/MSLBackend.js: Added.
1817         * WebGPUShadingLanguageRI/Metal/MSLCodegenAll.js: Added.
1818         * WebGPUShadingLanguageRI/Metal/MSLCompileResult.js: Added.
1819         * WebGPUShadingLanguageRI/Metal/MSLConstexprEmitter.js: Added.
1820         * WebGPUShadingLanguageRI/Metal/MSLFunctionDeclaration.js: Added.
1821         * WebGPUShadingLanguageRI/Metal/MSLFunctionDefinition.js: Added.
1822         * WebGPUShadingLanguageRI/Metal/MSLFunctionForwardDeclaration.js: Added.
1823         * WebGPUShadingLanguageRI/Metal/MSLNameMangler.js: Added.
1824         * WebGPUShadingLanguageRI/Metal/MSLNativeFunctionCall.js: Added.
1825         * WebGPUShadingLanguageRI/Metal/MSLStatementEmitter.js: Added.
1826         * WebGPUShadingLanguageRI/Metal/MSLTypeAttributes.js: Added.
1827         * WebGPUShadingLanguageRI/Metal/MSLTypeAttributesMap.js: Added.
1828         * WebGPUShadingLanguageRI/Metal/MSLTypeUnifier.js: Added.
1829         * WebGPUShadingLanguageRI/Metal/TypeOf.js: Added.
1830         * WebGPUShadingLanguageRI/Metal/WhlslToMsl.js: Added.
1831         * WebGPUShadingLanguageRI/PropertyResolver.js:
1832         * WebGPUShadingLanguageRI/SynthesizeStructAccessors.js:
1833         * WebGPUShadingLanguageRI/Test.js: Added awkward tests for the compiler
1834         to generate code for.
1835         (tests.incrementAndDecrement):
1836         (tests.returnIntLiteralUint):
1837         (tests.returnIntLiteralFloat):
1838         (tests.nestedSubscriptWithArraysInStructs):
1839         (tests.nestedSubscript):
1840         (tests.lotsOfLocalVariables):
1841         * WebGPUShadingLanguageRI/Type.js:
1842         (Type.prototype.get arrayRefType): See above.
1843
1844 2018-09-20  Ryan Haddad  <ryanhaddad@apple.com>
1845
1846         Bring up queues for iOS 12
1847         https://bugs.webkit.org/show_bug.cgi?id=189683
1848
1849         Unreviewed infrastructure fix.
1850
1851         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS12@2x.png: Renamed from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/iOS12@2x.png.
1852         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
1853         (BubbleQueueServer): Move EWS bubbles to the iOS 12 section of the dashboard.
1854
1855 2018-09-20  Ryan Haddad  <ryanhaddad@apple.com>
1856
1857         Bring up queues for iOS 12
1858         https://bugs.webkit.org/show_bug.cgi?id=189683
1859
1860         Reviewed by Aakash Jain.
1861
1862         * BuildSlaveSupport/build.webkit.org-config/config.json:
1863         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS12.png: Added.
1864         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS12Simulator.png: Added.
1865         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS12Simulator@2x.png: Added.
1866         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/iOS12@2x.png: Added.
1867         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1868         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1869         (WebKitBuildbot):
1870         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1871         (table.queue-grid tr.platform.ios-simulator-12 img.logo):
1872         (table.queue-grid tr.platform.ios-12 img.logo):
1873         (table.queue-grid tr.platform.ios-simulator-11 img.logo): Deleted.
1874         (table.queue-grid tr.platform.ios-11 img.logo): Deleted.
1875         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1876         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
1877         (_should_file_trigger_build):
1878         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
1879         (ShouldBuildTest):
1880         (ShouldBuildTest.test_should_build):
1881
1882 2018-09-20  Basuke Suzuki  <Basuke.Suzuki@sony.com>
1883
1884         [Win] TestRunner::queueLoad() fails to generate correct url for some urls.
1885         https://bugs.webkit.org/show_bug.cgi?id=189679
1886
1887         Reviewed by Fujii Hironori.
1888
1889         Replace the implementation with correct API call.
1890
1891         * DumpRenderTree/win/TestRunnerWin.cpp:
1892         (TestRunner::queueLoad): Call UrlCombineW.
1893
1894 2018-09-20  Michael Catanzaro  <mcatanzaro@igalia.com>
1895
1896         [WPE] fails to build on ARM arches complaining about undefined reference to `epoxy_eglMakeCurrent'
1897         https://bugs.webkit.org/show_bug.cgi?id=189556
1898
1899         Reviewed by Konstantin Tokarev.
1900
1901         This is only a speculative build fix as I didn't attempt to reproduce. Explicitly link to
1902         libepoxy.
1903
1904         * wpe/backends/CMakeLists.txt:
1905
1906 2018-09-20  Daniel Bates  <dabates@apple.com>
1907
1908         [iOS] Support testing more hardware special keys
1909         https://bugs.webkit.org/show_bug.cgi?id=189793
1910
1911         Reviewed by Simon Fraser.
1912
1913         * TestRunnerShared/spi/IOKitSPI.h: Add more SPI constants.
1914         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1915         (keyCodeForDOMFunctionKey): Extracted out logic from hidUsageCodeForCharacter() to return the
1916         key code for the F1, F2, ..., F12 keys and extended the code to compute the key code for the
1917         F13, F14, ..., F24 keys.
1918         (hidUsageCodeForCharacter): Modified to call keyCodeForDOMFunctionKey().
1919
1920 2018-09-20  Michael Catanzaro  <mcatanzaro@igalia.com>
1921
1922         Unreviewed, remove accidentally-committed debugging changes from flatpakutils script
1923
1924         Aaaaaah maybe this is why changes are supposed to be reviewed.
1925
1926         * flatpak/flatpakutils.py:
1927         (WebkitFlatpak.clean_args):
1928
1929 2018-09-20  Michael Catanzaro  <mcatanzaro@igalia.com>
1930
1931         Unreviewed, manually rollout our switch to master runtime
1932
1933         Phil wants html5-codecs, which aren't available yet here. Let's switch back to 3.28 in the
1934         meantime, where we were already building GStreamer ourselves anyway. But use an updated
1935         SDK revision.
1936
1937         * flatpak/files/httpd-autogen.sh: Added.
1938         * flatpak/flatpakutils.py:
1939         (WebkitFlatpak.clean_args):
1940         * flatpak/org.webkit.GTK.yaml:
1941         * flatpak/org.webkit.WebKit.yaml:
1942         * flatpak/patches/httpd-0001-configure-use-pkg-config-for-PCRE-detection.patch: Added.
1943         * flatpak/patches/libgcrypt-0001-Use-pkg-config-to-detect-gpg-error.patch: Added.
1944
1945 2018-09-20  Thibault Saunier  <tsaunier@igalia.com>
1946
1947         [WPE][GTK] webkit-flatpak intercepts --help for other commands
1948         https://bugs.webkit.org/show_bug.cgi?id=189058
1949
1950         The approach of run_in_sandbox_if_available is that we basically have the
1951         same set of arguments to setup the sandbox (ie. port name, build type, etc...)
1952         and we can pass those args first to setup the flatpak launcher object
1953         and then to the underlying script. That doesn't work well with the `--help` argument
1954         as once processed it 1. prints the help (which make no sense to the user of the calling script)
1955         2. exits the app - The solution is to just make sure that `--help` is not used when using
1956         flatpakutils from any script that is not `webkit-flatpak` itself.
1957
1958         Reviewed by Michael Catanzaro.
1959
1960         * flatpak/flatpakutils.py:
1961         (WebkitFlatpak.load_from_args):
1962         (run_in_sandbox_if_available):
1963
1964 2018-09-20  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1965
1966         Unreviewed. Add W3C imported tests to the MSEEME watchlist.
1967
1968         * Scripts/webkitpy/common/config/watchlist:
1969
1970 2018-09-20  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1971
1972         Unreviewed. Fix the Streams API watchlist.
1973
1974         * Scripts/webkitpy/common/config/watchlist:
1975
1976 2018-09-19  Chris Dumez  <cdumez@apple.com>
1977
1978         Crash under WebProcessProxy::suspendedPageWasDestroyed(WebKit::SuspendedPageProxy&)
1979         https://bugs.webkit.org/show_bug.cgi?id=189721
1980         <rdar://problem/44359788>
1981
1982         Reviewed by Geoffrey Garen.
1983
1984         Add API test coverage.
1985
1986         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1987
1988 2018-09-19  Thomas Denney  <tdenney@apple.com>
1989
1990         [WHLSL] Improve test suite type safety
1991         https://bugs.webkit.org/show_bug.cgi?id=189502
1992
1993         Reviewed by Myles C. Maxfield.
1994
1995         Each of the 'makeT' functions now call the relevant cast function on the
1996         value before hand. The checkNumber function has also been removed and
1997         its uses have been replaced with functions that also check the type.
1998         Some of the arithmetic checks have been updated to reflect that the
1999         casts happen outside of WHLSL evaluation. Other tests have also been
2000         updated to reflect that some values cannot be precisely expressed in
2001         32-bit floating point.
2002
2003         * WebGPUShadingLanguageRI/Casts.js:
2004         (castToBool): Added.
2005         (castAndCheckValue): Added.
2006         (isBitwiseEquivalent): Moved from Intrinsics.js.
2007         * WebGPUShadingLanguageRI/Intrinsics.js: Ditto.
2008         * WebGPUShadingLanguageRI/SPIRV.html: Update depdencies.
2009         * WebGPUShadingLanguageRI/Test.html: Ditto.
2010         * WebGPUShadingLanguageRI/Test.js: Update makeT functions to do a cast
2011         and check the result. Some tests were also updated to reflect the change
2012         in the behavior of these functions.
2013         * WebGPUShadingLanguageRI/index.html: Update dependencies.
2014
2015 2018-09-19  John Wilander  <wilander@apple.com>
2016
2017         Resource Load Statistics: Add optional cap on partitioned cache max age
2018         https://bugs.webkit.org/show_bug.cgi?id=189711
2019         <rdar://problem/39246837>
2020
2021         Reviewed by Antti Koivisto and Chris Dumez.
2022
2023         This change adds infrastructure for layout tests of capped cache max age.
2024
2025         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2026         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2027         (WTR::TestRunner::setStatisticsCacheMaxAgeCap):
2028         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2029         * WebKitTestRunner/TestController.cpp:
2030         (WTR::TestController::setStatisticsCacheMaxAgeCap):
2031         * WebKitTestRunner/TestController.h:
2032         * WebKitTestRunner/TestInvocation.cpp:
2033         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2034
2035 2018-09-19  Dawei Fenton  <realdawei@apple.com>
2036
2037        Unreviewed. Update my email and alias in list of contributors.
2038
2039         * Scripts/webkitpy/common/config/contributors.json:
2040
2041 2018-09-19  Michael Catanzaro  <mcatanzaro@igalia.com>
2042
2043         [WPE][GTK] Unreviewed, try #3 to fix a typo
2044
2045         I feel like Charlie Brown, how hard this has been for me....
2046
2047         * Scripts/run-minibrowser:
2048         * Scripts/webkitdirs.pm:
2049         (runInFlatpakIfAvailable):
2050         (runInFlatpakIfAvailible): Deleted.
2051
2052 2018-09-19  Michael Catanzaro  <mcatanzaro@igalia.com>
2053
2054         [WPE][GTK] Unreviewed, fix that typo in more places
2055
2056         It got copied into webkitdirs.pm!
2057
2058         * Scripts/webkitdirs.pm:
2059         (runInFlatpakIfAvailible):
2060         (runInFlatpakIfAvalaible): Deleted.
2061
2062 2018-09-19  Michael Catanzaro  <mcatanzaro@igalia.com>
2063
2064         [WPE][GTK] Unreviewed, fix a pervasive typo in the webkit-flatpak script
2065
2066         * flatpak/flatpakutils.py:
2067         (WebkitFlatpak.load_from_args):
2068         (WebkitFlatpak.__init__):
2069         (WebkitFlatpak.run):
2070
2071 2018-09-19  Michael Catanzaro  <mcatanzaro@igalia.com>
2072
2073         [WPE][GTK] Unreviewed, update to latest GNOME SDK
2074
2075         * flatpak/org.webkit.WebKit.yaml:
2076
2077 2018-09-19  Michael Catanzaro  <mcatanzaro@igalia.com>
2078
2079         Unreviewed, rolling out r235500.
2080
2081         Time to switch back to master runtime
2082
2083         Reverted changeset:
2084
2085         "Unreviewed, rolling out r235114."
2086         https://bugs.webkit.org/show_bug.cgi?id=188731
2087         https://trac.webkit.org/changeset/235500
2088
2089 2018-09-19  Adrian Perez de Castro  <aperez@igalia.com>
2090
2091         Unreviewed. Add Pablo Saavedra to the list of contributors.
2092
2093         * Scripts/webkitpy/common/config/contributors.json:
2094
2095 2018-09-19  Philippe Normand  <pnormand@igalia.com>
2096
2097         [GStreamer] Add support for AV1 decoding
2098         https://bugs.webkit.org/show_bug.cgi?id=189647
2099
2100         Reviewed by Žan Doberšek.
2101
2102         Add patches required for AV1 decoding support. They're all
2103         upstream already and will be shipped in GStreamer 1.16. The aom
2104         GStreamer plugin depends on the aom library for which there's no
2105         official release yet.
2106
2107         * gstreamer/jhbuild.modules:
2108         * gstreamer/patches/gst-plugins-bad-0001-aomenc-Add-support-for-10-12bit-decoding.patch: Added.
2109         * gstreamer/patches/gst-plugins-bad-0002-aomenc-Handle-8-bit_depth-images-with-AOM_IMG_FMT_HI.patch: Added.
2110         * gstreamer/patches/gst-plugins-good-0001-qtdemux-Detect-and-expose-CEA-608-708-Closed-Caption.patch: Added. This one is unrelated but an implicit dependency of the next one.
2111         * gstreamer/patches/gst-plugins-good-0004-qtdemux-Add-initial-support-for-AV1-demuxing.patch: Added.
2112         * gstreamer/patches/gst-plugins-good-0005-qtdemux-Extract-AV1-codec_data-and-put-it-in-the-cap.patch: Added.
2113         * gstreamer/patches/gst-plugins-good-0006-qtdemux-Recognize-more-AV1-atoms.patch: Added.
2114
2115 2018-09-18  Jonathan Bedard  <jbedard@apple.com>
2116
2117         webkitpy: Clobbering and building occurs multiple times for iOS Simulator ports
2118         https://bugs.webkit.org/show_bug.cgi?id=189702
2119         <rdar://problem/44541704>
2120
2121         Reviewed by Aakash Jain.
2122
2123         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2124         (Manager._set_up_run): Move build check and clobbering to run, since set up is
2125         run multiple times for iOS simulator.
2126         (Manager.run):
2127
2128 2018-09-18  Chris Dumez  <cdumez@apple.com>
2129
2130         "DidFirstVisuallyNonEmptyLayout" callback does not get called when restoring a page from PageCache
2131         https://bugs.webkit.org/show_bug.cgi?id=189681
2132         <rdar://problem/44526171>
2133
2134         Reviewed by Alex Christensen and Zalan Bujtas.
2135
2136         Add API test coverage.
2137
2138         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
2139         (TestWebKitAPI::didFinishNavigation):
2140         (TestWebKitAPI::TEST):
2141
2142 2018-09-18  Claudio Saavedra  <csaavedra@igalia.com>
2143
2144         [WPE] Implement mouse event modifiers
2145         https://bugs.webkit.org/show_bug.cgi?id=189697
2146
2147         Reviewed by Carlos Garcia Campos.
2148
2149         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
2150         (WTR::wkEventModifiersToWPE):
2151         (WTR::EventSenderProxy::mouseDown):
2152         (WTR::EventSenderProxy::mouseUp):
2153
2154 2018-09-17  Yusuke Suzuki  <utatane.tea@gmail.com>
2155
2156         [WTF] Use Semaphore and BinarySemaphore instead of dispatch_semaphore_t
2157         https://bugs.webkit.org/show_bug.cgi?id=185339
2158
2159         Reviewed by Mark Lam.
2160
2161         * TestWebKitAPI/Tests/WTF/SynchronizedFixedQueue.cpp:
2162         (TestWebKitAPI::ToUpperConverter::stopProducing):
2163         (TestWebKitAPI::ToUpperConverter::stopConsuming):
2164
2165 2018-09-17  Simon Fraser  <simon.fraser@apple.com>
2166
2167         Many modern media control tests leak documents in testing
2168         https://bugs.webkit.org/show_bug.cgi?id=189437
2169
2170         Reviewed by Darin Adler.
2171         
2172         In order to accurately detect leaks in media controls tests which use lots of
2173         SVGImages, we have to:
2174         - Fire a zero-delay timer after the postTask, in order for ImagesLoader's m_derefElementTimer
2175           to clear references to elements.
2176         - Have releaseCriticalMemory() call CachedResourceLoader's garbageCollectDocumentResources()
2177           to drop the last handle to the CachedResource for an SVGImage.
2178         - Call WKBundleReleaseMemory() after the GC and timer, since we need garbageCollectDocumentResources()
2179           to run again after that timer has fired.
2180         
2181         This should fix most of the spurious leak reports involving SVGImage documents.
2182
2183         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2184         (WTR::InjectedBundle::reportLiveDocuments):
2185         (WTR::InjectedBundle::didReceiveMessageToPage):
2186
2187 2018-09-17  Chris Dumez  <cdumez@apple.com>
2188
2189         PSON: window.open() with 'noopener' should only process-swap cross-site, not cross-origin
2190         https://bugs.webkit.org/show_bug.cgi?id=189602
2191         <rdar://problem/44430549>
2192
2193         Reviewed by Geoff Garen.
2194
2195         Add API test coverage.
2196
2197         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2198
2199 2018-09-17  Philippe Normand  <pnormand@igalia.com>
2200
2201         [JHBuild] Update to GStreamer 1.14.3
2202         https://bugs.webkit.org/show_bug.cgi?id=189450
2203
2204         Reviewed by Xabier Rodriguez-Calvar.
2205
2206         * gstreamer/jhbuild.modules: Bump GStreamer modules from 1.14.1 to 1.14.3.
2207
2208 2018-09-17  Philippe Normand  <pnormand@igalia.com>
2209
2210         [JHBuild] Doesn't check sha256 sums
2211         https://bugs.webkit.org/show_bug.cgi?id=189646
2212
2213         Reviewed by Michael Catanzaro.
2214
2215         * gstreamer/jhbuild.modules: Properly set the sha256: prefix on hashes.
2216
2217 2018-09-17  Sihui Liu  <sihui_liu@apple.com>
2218
2219         Move IndexedDB to Network Process
2220         https://bugs.webkit.org/show_bug.cgi?id=189415
2221         <rdar://problem/44396973>
2222
2223         Reviewed by Chris Dumez.
2224
2225         * TestWebKitAPI/Tests/WebKitCocoa/IDBDeleteRecovery.mm:
2226         (TEST):
2227         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
2228         (TEST):
2229         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBDatabaseProcessKill.mm:
2230         (TEST):
2231         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBMultiProcess.mm:
2232         (TEST):
2233         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
2234         (TEST):
2235
2236 2018-09-08  Darin Adler  <darin@apple.com>
2237
2238         Streamline JSRetainPtr, fix leaks of JSString and JSGlobalContext
2239         https://bugs.webkit.org/show_bug.cgi?id=189455
2240
2241         Reviewed by Keith Miller.
2242
2243         There is a lot of copied and pasted code for WebKit vs. Legacy WebKit
2244         testing and even for macOS vs. iOS vs. Windows platform-specific code.
2245         For now, this patch just makes corresponding changes to the copied code.
2246         Later we might get better results by merging more code instead of having
2247         all these separate copies.
2248
2249         * DumpRenderTree/AccessibilityController.cpp:
2250         (AccessibilityController::makeWindowObject): Use the adopt function
2251         instead of the special Adopt constructor of JSRetainPtr.
2252
2253         * DumpRenderTree/AccessibilityTextMarker.cpp: Removed unneeded include.
2254
2255         * DumpRenderTree/AccessibilityUIElement.cpp: Ditto.
2256         (allAttributesCallback): Don't adopt at this level; changed the
2257         underlying function to return a JSRetainPtr so the adopt is right next
2258         to the call to the create or copy function.
2259         (attributesOfLinkedUIElementsCallback): Ditto.
2260         (attributesOfDocumentLinksCallback): Ditto.
2261         (attributesOfChildrenCallback): Ditto.
2262         (parameterizedAttributeNamesCallback): Ditto.
2263         (attributesOfColumnHeadersCallback): Ditto.
2264         (attributesOfRowHeadersCallback): Ditto.
2265         (attributesOfColumnsCallback): Ditto.
2266         (attributesOfRowsCallback): Ditto.
2267         (attributesOfVisibleCellsCallback): Ditto.
2268         (attributesOfHeaderCallback): Ditto.
2269         (rowIndexRangeCallback): Ditto.
2270         (columnIndexRangeCallback): Ditto.
2271         (rangeForLineCallback): Ditto.
2272         (boundsForRangeCallback): Ditto.
2273         (rangeForPositionCallback): Ditto.
2274         (stringForRangeCallback): Ditto.
2275         (attributedStringForRangeCallback): Ditto.
2276         (uiElementCountForSearchPredicateCallback): Use the free adopt
2277         function instead of the adopt member function.
2278         (uiElementForSearchPredicateCallback): Ditto.
2279         (selectTextWithCriteriaCallback): Don't adopt at this level.
2280         (attributedStringForElementCallback): Ditto.
2281         (setValueCallback): Use free adopt.
2282         (stringAttributeValueCallback): Don't adopt at this level.
2283         (uiElementArrayAttributeValueCallback): Ditto.
2284         (uiElementAttributeValueCallback): Ditto.
2285         (stringForTextMarkerRangeCallback): Ditto.
2286         (attributedStringForTextMarkerRangeCallback): Ditto.
2287         (attributedStringForTextMarkerRangeWithOptionsCallback): Ditto.
2288         (getARIADropEffectsCallback): Ditto.
2289         (getClassListCallback): Ditto.
2290         (getRoleCallback): Ditto.
2291         (getSubroleCallback): Ditto.
2292         (getRoleDescriptionCallback): Ditto.
2293         (getComputedRoleStringCallback): Ditto.
2294         (getTitleCallback): Ditto.
2295         (getDescriptionCallback): Ditto.
2296         (getStringValueCallback): Ditto.
2297         (getLanguageCallback): Ditto.
2298         (getHelpTextCallback): Ditto.
2299         (getOrientationCallback): Ditto.
2300         (getPathDescriptionCallback): Ditto.
2301         (getSelectedTextRangeCallback): Ditto.
2302         (speakAsCallback): Ditto.
2303         (getValueDescriptionCallback): Ditto.
2304         (getAccessibilityValueCallback): Ditto.
2305         (getDocumentEncodingCallback): Ditto.
2306         (getDocumentURICallback): Ditto.
2307         (getURLCallback): Ditto.
2308         (characterAtOffsetCallback): Ditto.
2309         (wordAtOffsetCallback): Ditto.
2310         (lineAtOffsetCallback): Ditto.
2311         (sentenceAtOffsetCallback): Ditto.
2312         (stringForSelectionCallback): Ditto.
2313         (getIdentifierCallback): Ditto.
2314         (getTraitsCallback): Ditto.
2315         (supportedActionsCallback): Ditto.
2316         (mathPostscriptsDescriptionCallback): Ditto.
2317         (mathPrescriptsDescriptionCallback): Ditto.
2318         (AccessibilityUIElement::rangeForLine): Updated to return JSRetainPtr.
2319         (AccessibilityUIElement::rangeForPosition): Ditto.
2320         (AccessibilityUIElement::speakAs): Ditto.
2321         (AccessibilityUIElement::pathDescription const): Ditto.
2322         (AccessibilityUIElement::stringForTextMarkerRange): Ditto.
2323         (AccessibilityUIElement::attributedStringForTextMarkerRange): Ditto.
2324         (AccessibilityUIElement::attributedStringForTextMarkerRangeWithOptions): Ditto.
2325
2326         * DumpRenderTree/AccessibilityUIElement.h: Use JSRetainPtr instead of
2327         raw pointers for the results of the functions that create strings.
2328         The old way was difficult to get right; the functions didn't even follow
2329         the create/copy naming rule.
2330
2331         * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm:
2332         (_platformTypeConstructor): Use the adopt function instead of the
2333         JSRetainPtr adopt constructor. Also nullptr instead of 0.
2334
2335         * DumpRenderTree/GCController.cpp:
2336         (GCController::makeWindowObject): Use adopt function instead of constructor.
2337
2338         * DumpRenderTree/TestRunner.cpp:
2339         (pathToLocalResourceCallback): Use adopt function instead of constructor.
2340         (addDisallowedURLCallback): Ditto.
2341         (addURLToRedirectCallback): Ditto.
2342         (clearApplicationCacheForOriginCallback): Ditto.
2343         (applicationCacheDiskUsageForOriginCallback): Ditto.
2344         (decodeHostNameCallback): Don't adopt at this level.
2345         (encodeHostNameCallback): Ditto.
2346         (execCommandCallback): Use adopt instead of JSRetainPtr::adopt.
2347         (findStringCallback): Use adopt function instead of constructor.
2348         (isCommandEnabledCallback): Ditto.
2349         (overridePreferenceCallback): Ditto.
2350         (queueLoadCallback): Ditto.
2351         (queueLoadHTMLStringCallback): Ditto.
2352         (queueLoadingScriptCallback): Ditto.
2353         (queueNonLoadingScriptCallback): Ditto.
2354         (setAuthenticationPasswordCallback): Ditto.
2355         (setAuthenticationUsernameCallback): Ditto.
2356         (setDomainRelaxationForbiddenForURLSchemeCallback): Ditto.
2357         (setMockGeolocationPositionUnavailableErrorCallback): Ditto.
2358         (setPOSIXLocaleCallback): Ditto.
2359         (setPersistentUserStyleSheetLocationCallback): Ditto.
2360         (setUserStyleSheetLocationCallback): Ditto.
2361         (setValueForUserCallback): Ditto.
2362         (setWillSendRequestClearHeaderCallback): Ditto.
2363         (setPageVisibilityCallback): Ditto.
2364         (evaluateInWebInspectorCallback): Ditto.
2365         (evaluateScriptInIsolatedWorldCallback): Ditto.
2366         (evaluateScriptInIsolatedWorldAndReturnValueCallback): Ditto.
2367         (addOriginAccessWhitelistEntryCallback): Ditto.
2368         (removeOriginAccessWhitelistEntryCallback): Ditto.
2369         (setScrollbarPolicyCallback): Ditto.
2370         (addUserScriptCallback): Ditto.
2371         (addUserStyleSheetCallback): Ditto.
2372         (apiTestNewWindowDataLoadBaseURLCallback): Ditto.
2373         (authenticateSessionCallback): Ditto.
2374         (getTitleTextDirectionCallback): Ditto.
2375         (getInspectorTestStubURLCallback): Ditto.
2376         (simulateLegacyWebNotificationClickCallback): Ditto.
2377         (setTextDirectionCallback): Ditto.
2378         (grantWebNotificationPermissionCallback): Ditto.
2379         (denyWebNotificationPermissionCallback): Ditto.
2380         (accummulateLogsForChannel): Ditto.
2381         (runUIScriptCallback): Ditto.
2382         (TestRunner::makeWindowObject): Ditto.
2383         (TestRunner::uiScriptDidComplete): Ditto.
2384         (TestRunner::setOpenPanelFiles): Ditto.
2385
2386         * DumpRenderTree/TestRunner.h: Use JSRetainPtr instead of
2387         raw pointers for the results of the functions that create strings.
2388
2389         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
2390         (AccessibilityController::platformName const): Use the adopt
2391         function instead of the adopt constructor.
2392
2393         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2394         (createEmptyJSString): Added. This helper function makes reduces the
2395         repetitive code to create empty strings.
2396         (concatenateAttributeAndValue): Changed to return a JSRetainPtr.
2397         (AccessibilityUIElement::identifier): Ditto.
2398         (AccessibilityUIElement::traits): Ditto.
2399         (AccessibilityUIElement::url): Ditto.
2400         (AccessibilityUIElement::speakAs): Ditto.
2401         (AccessibilityUIElement::stringForSelection): Ditto.
2402         (AccessibilityUIElement::stringForRange): Ditto.
2403         (AccessibilityUIElement::attributedStringForRange): Ditto.
2404         (AccessibilityUIElement::attributedStringForElement): Ditto.
2405         (AccessibilityUIElement::pathDescription const): Ditto.
2406         (AccessibilityUIElement::stringForTextMarkerRange): Ditto.
2407         (AccessibilityUIElement::attributedStringForTextMarkerRange): Ditto.
2408         (AccessibilityUIElement::attributedStringForTextMarkerRangeWithOptions): Ditto.
2409         (AccessibilityUIElement::attributesOfLinkedUIElements): Ditto.
2410         (AccessibilityUIElement::attributesOfDocumentLinks): Ditto.
2411         (AccessibilityUIElement::attributesOfChildren): Ditto.
2412         (AccessibilityUIElement::allAttributes): Ditto.
2413         (AccessibilityUIElement::stringAttributeValue): Ditto.
2414         (AccessibilityUIElement::parameterizedAttributeNames): Ditto.
2415         (AccessibilityUIElement::role): Ditto.
2416         (AccessibilityUIElement::subrole): Ditto.
2417         (AccessibilityUIElement::roleDescription): Ditto.
2418         (AccessibilityUIElement::computedRoleString): Ditto.
2419         (AccessibilityUIElement::title): Ditto.
2420         (AccessibilityUIElement::description): Ditto.
2421         (AccessibilityUIElement::orientation const): Ditto.
2422         (AccessibilityUIElement::stringValue): Ditto.
2423         (AccessibilityUIElement::language): Ditto.
2424         (AccessibilityUIElement::helpText const): Ditto.
2425         (AccessibilityUIElement::valueDescription): Ditto.
2426         (AccessibilityUIElement::ariaDropEffects const): Ditto.
2427         (AccessibilityUIElement::boundsForRange): Ditto.
2428         (AccessibilityUIElement::attributesOfColumnHeaders): Ditto.
2429         (AccessibilityUIElement::attributesOfRowHeaders): Ditto.
2430         (AccessibilityUIElement::attributesOfColumns): Ditto.
2431         (AccessibilityUIElement::attributesOfRows): Ditto.
2432         (AccessibilityUIElement::attributesOfVisibleCells): Ditto.
2433         (AccessibilityUIElement::attributesOfHeader): Ditto.
2434         (AccessibilityUIElement::rowIndexRange): Ditto.
2435         (AccessibilityUIElement::columnIndexRange): Ditto.
2436         (AccessibilityUIElement::selectedTextRange): Ditto.
2437         (AccessibilityUIElement::accessibilityValue const): Ditto.
2438         (AccessibilityUIElement::documentEncoding): Ditto.
2439         (AccessibilityUIElement::documentURI): Ditto.
2440         (AccessibilityUIElement::selectTextWithCriteria): Ditto.
2441         (AccessibilityUIElement::classList const): Ditto.
2442
2443         * DumpRenderTree/mac/AccessibilityCommonMac.h: Changed the
2444         createJSStringRef method to return a JSRetainPtr.
2445         * DumpRenderTree/mac/AccessibilityCommonMac.mm:
2446         (-[NSString createJSStringRef]): Ditto.
2447         (searchPredicateParameterizedAttributeForSearchCriteria): Use the
2448         adopt function instead of the adopt constructor.
2449         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2450         (AccessibilityController::platformName const): Ditto.
2451
2452         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
2453         (-[NSString createJSStringRef]): Return a JSRetainPtr.
2454         (makeValueRefForValue): Updated for the above, no adopt needed here now.
2455         (makeObjectRefForDictionary): Ditto.
2456         (-[AccessibilityNotificationHandler _notificationReceived:]): Ditto.
2457
2458         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2459         (createEmptyJSString): Added. This helper function makes reduces the
2460         repetitive code to create empty strings.
2461         (concatenateAttributeAndValue): Changed to return a JSRetainPtr.
2462         (descriptionOfElements): Ditto.
2463         (selectTextParameterizedAttributeForCriteria): Ditto.
2464         (AccessibilityUIElement::attributesOfLinkedUIElements): Ditto.
2465         (AccessibilityUIElement::attributesOfDocumentLinks): Ditto.
2466         (AccessibilityUIElement::attributesOfChildren): Ditto.
2467         (AccessibilityUIElement::allAttributes): Ditto.
2468         (AccessibilityUIElement::stringAttributeValue): Ditto.
2469         (AccessibilityUIElement::parameterizedAttributeNames): Ditto.
2470         (AccessibilityUIElement::role): Ditto.
2471         (AccessibilityUIElement::subrole): Ditto.
2472         (AccessibilityUIElement::roleDescription): Ditto.
2473         (AccessibilityUIElement::computedRoleString): Ditto.
2474         (AccessibilityUIElement::title): Ditto.
2475         (AccessibilityUIElement::description): Ditto.
2476         (AccessibilityUIElement::orientation const): Ditto.
2477         (AccessibilityUIElement::stringValue): Ditto.
2478         (AccessibilityUIElement::language): Ditto.
2479         (AccessibilityUIElement::helpText const): Ditto.
2480         (AccessibilityUIElement::valueDescription): Ditto.
2481         (AccessibilityUIElement::speakAs): Ditto.
2482         (AccessibilityUIElement::classList const): Ditto.
2483         (AccessibilityUIElement::ariaDropEffects const): Ditto.
2484         (AccessibilityUIElement::rangeForLine): Ditto.
2485         (AccessibilityUIElement::rangeForPosition): Ditto.
2486         (AccessibilityUIElement::boundsForRange): Ditto.
2487         (AccessibilityUIElement::stringForRange): Ditto.
2488         (AccessibilityUIElement::attributedStringForRange): Ditto.
2489         (AccessibilityUIElement::selectTextWithCriteria): Ditto.
2490         (AccessibilityUIElement::attributesOfColumnHeaders): Ditto.
2491         (AccessibilityUIElement::attributesOfRowHeaders): Ditto.
2492         (AccessibilityUIElement::attributesOfColumns): Ditto.
2493         (AccessibilityUIElement::attributesOfRows): Ditto.
2494         (AccessibilityUIElement::attributesOfVisibleCells): Ditto.
2495         (AccessibilityUIElement::attributesOfHeader): Ditto.
2496         (AccessibilityUIElement::rowIndexRange): Ditto.
2497         (AccessibilityUIElement::columnIndexRange): Ditto.
2498         (AccessibilityUIElement::pathDescription const): Ditto.
2499         (AccessibilityUIElement::selectedTextRange): Ditto.
2500         (AccessibilityUIElement::accessibilityValue const): Ditto.
2501         (AccessibilityUIElement::documentEncoding): Ditto.
2502         (AccessibilityUIElement::documentURI): Ditto.
2503         (AccessibilityUIElement::url): Ditto.
2504         (AccessibilityUIElement::stringForTextMarkerRange): Ditto.
2505         (createJSStringRef): Ditto.
2506         (AccessibilityUIElement::attributedStringForTextMarkerRange): Ditto.
2507         (AccessibilityUIElement::attributedStringForTextMarkerRangeWithOptions): Ditto.
2508         (AccessibilityUIElement::supportedActions): Ditto.
2509         (AccessibilityUIElement::mathPostscriptsDescription const): Ditto.
2510         (AccessibilityUIElement::mathPrescriptsDescription const): Ditto.
2511
2512         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2513         (-[FrameLoadDelegate didClearWindowObjectForFrame:inIsolatedWorld:]):
2514         Use the adopt function instead of the adopt constructor.
2515         * DumpRenderTree/mac/TestRunnerMac.mm:
2516         (originsArrayToJS): Ditto.
2517         (TestRunner::copyDecodedHostName): Return a JSRetainPtr.
2518         (TestRunner::copyEncodedHostName): Ditto.
2519         (TestRunner::pathToLocalResource): Ditto.
2520         (TestRunner::queueLoad): Use adopt function instead of constructor.
2521         (TestRunner::findString): Ditto.
2522         (TestRunner::inspectorTestStubURL): Return a JSRetainPtr.
2523
2524         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2525         (AccessibilityController::winNotificationReceived): Use adopt function
2526         instead of adopt constructor.
2527         (AccessibilityController::platformName const): Ditto.
2528
2529         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2530         (createEmptyJSString): Added. This helper function makes reduces the
2531         repetitive code to create empty strings.
2532         (AccessibilityUIElement::allAttributes): Changed to return a JSRetainPtr.
2533         (AccessibilityUIElement::attributesOfLinkedUIElements): Ditto.
2534         (AccessibilityUIElement::attributesOfDocumentLinks): Ditto.
2535         (AccessibilityUIElement::attributesOfChildren): Ditto.
2536         (AccessibilityUIElement::parameterizedAttributeNames): Ditto.
2537         (AccessibilityUIElement::role): Ditto.
2538         (AccessibilityUIElement::subrole): Ditto.
2539         (AccessibilityUIElement::roleDescription): Ditto.
2540         (AccessibilityUIElement::computedRoleString): Ditto.
2541         (AccessibilityUIElement::title): Ditto.
2542         (AccessibilityUIElement::description): Ditto.
2543         (AccessibilityUIElement::stringValue): Ditto.
2544         (AccessibilityUIElement::language): Ditto.
2545         (AccessibilityUIElement::helpText const): Ditto.
2546         (AccessibilityUIElement::valueDescription): Ditto.
2547         (AccessibilityUIElement::ariaDropEffects const): Ditto.
2548         (AccessibilityUIElement::orientation const): Ditto.
2549         (AccessibilityUIElement::attributesOfColumnHeaders): Ditto.
2550         (AccessibilityUIElement::attributesOfRowHeaders): Ditto.
2551         (AccessibilityUIElement::attributesOfColumns): Ditto.
2552         (AccessibilityUIElement::attributesOfRows): Ditto.
2553         (AccessibilityUIElement::attributesOfVisibleCells): Ditto.
2554         (AccessibilityUIElement::attributesOfHeader): Ditto.
2555         (AccessibilityUIElement::rowIndexRange): Ditto.
2556         (AccessibilityUIElement::columnIndexRange): Ditto.
2557         (AccessibilityUIElement::boundsForRange): Ditto.
2558         (AccessibilityUIElement::stringForRange): Ditto.
2559         (AccessibilityUIElement::attributedStringForRange): Ditto.
2560         (AccessibilityUIElement::selectTextWithCriteria): Ditto.
2561         (AccessibilityUIElement::selectedTextRange): Ditto.
2562         (AccessibilityUIElement::stringAttributeValue): Ditto.
2563         (AccessibilityUIElement::accessibilityValue const): Ditto.
2564         (AccessibilityUIElement::documentEncoding): Ditto.
2565         (AccessibilityUIElement::documentURI): Ditto.
2566         (AccessibilityUIElement::url): Ditto.
2567         (AccessibilityUIElement::classList const): Ditto.
2568
2569         * DumpRenderTree/win/TestRunnerWin.cpp:
2570         (TestRunner::copyDecodedHostName): Changed to return a JSRetainPtr.
2571         (TestRunner::copyEncodedHostName): Ditto.
2572         (TestRunner::pathToLocalResource): Ditto.
2573         (TestRunner::queueLoad): Ditto.
2574         (TestRunner::findString): Ditto.
2575         (TestRunner::inspectorTestStubURL): Ditto.
2576
2577         * TestRunnerShared/Bindings/JSWrapper.h:
2578         (WTR::setProperty): Use adopt function instead of constructor.
2579         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
2580         (UIScriptContext::UIScriptContext): Ditto.
2581         (UIScriptContext::runUIScript): Ditto.
2582         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2583         (WTR::toDeviceOrientation): Ditto.
2584
2585         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
2586         (nsTextCheckingType): Changed this function to not take an rvalue
2587         reference to a JSRetainPtr since it doesn't take ownership.
2588         (-[LayoutTestSpellChecker setResultsFromJSObject:inContext:]): Updated
2589         for the above change.
2590
2591         * TestWebKitAPI/JavaScriptTest.cpp:
2592         (TestWebKitAPI::javaScriptCallback): Use adopt function instead of
2593         adopt member function.
2594
2595         * TestWebKitAPI/Tests/WebKit/WKPageIsPlayingAudio.cpp: Removed unneeded include.
2596         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm: Ditto.
2597         * TestWebKitAPI/Tests/mac/DOMNodeFromJSObject.mm: Use adopt function instead of
2598         adopt constructor.
2599         * TestWebKitAPI/Tests/mac/JSWrapperForNodeInWebFrame.mm: Ditto.
2600
2601         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
2602         Removed unneeded includes.
2603         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.cpp: Ditto.
2604         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.cpp: Ditto.
2605         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp: Ditto.
2606
2607         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
2608         (_platformTypeConstructor): Use the adopt function instead of the
2609         JSRetainPtr adopt constructor. Also nullptr instead of 0.
2610
2611         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2612         (WTR::arrayLength): Use adopt function instead of constructor.
2613         (WTR::parseModifierArray): Ditto.
2614         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2615         (WTR::propertyValue): Ditto.
2616         (WTR::dumpPath): Ditto.
2617         (WTR::toJS): Ditto.
2618         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2619         (WTR::TestRunner::findString): Ditto.
2620         (WTR::TestRunner::statisticsDidRunTelemetryCallback): Ditto.
2621         (WTR::TestRunner::callDidReceiveAllStorageAccessEntriesCallback): Ditto.
2622         (WTR::TestRunner::setOpenPanelFiles): Ditto.
2623         * WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm:
2624         (WTR::AccessibilityController::platformName): Ditto.
2625
2626         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2627         (-[NSString createJSStringRef]): Return a JSRetainPtr.
2628         This fixes storage leaks in many functions below, which were using
2629         the create function and putting the value right into a JSRetainPtr
2630         without adoption.
2631         (WTR::createEmptyJSString): Added. This helper function reduces the
2632         repetitive code to create empty strings.
2633         (WTR::concatenateAttributeAndValue): Return a JSRetainPtr.
2634         (WTR::AccessibilityUIElement::attributesOfLinkedUIElements):
2635         Use createEmptyJSString, fixing a storage leak due to missing adoption.
2636         (WTR::AccessibilityUIElement::attributesOfDocumentLinks): Ditto.
2637         (WTR::AccessibilityUIElement::attributesOfChildren): Ditto.
2638         (WTR::AccessibilityUIElement::allAttributes): Ditto.
2639         (WTR::AccessibilityUIElement::stringAttributeValue): Ditto.
2640         (WTR::AccessibilityUIElement::parameterizedAttributeNames): Ditto.
2641         (WTR::AccessibilityUIElement::role): Ditto.
2642         (WTR::AccessibilityUIElement::subrole): Ditto.
2643         (WTR::AccessibilityUIElement::roleDescription): Ditto.
2644         (WTR::AccessibilityUIElement::computedRoleString): Ditto.
2645         (WTR::AccessibilityUIElement::title): Ditto.
2646         (WTR::AccessibilityUIElement::orientation const): Ditto.
2647         (WTR::AccessibilityUIElement::language): Ditto.
2648         (WTR::AccessibilityUIElement::valueDescription): Ditto.
2649         (WTR::AccessibilityUIElement::ariaDropEffects const): Ditto.
2650         (WTR::AccessibilityUIElement::boundsForRange): Ditto.
2651         (WTR::AccessibilityUIElement::stringForRange): Removed unneeded null check.
2652         (WTR::AccessibilityUIElement::attributedStringForRange): Ditto.
2653         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
2654         Use createEmptyJSString, fixing a storage leak due to missing adoption.
2655         (WTR::AccessibilityUIElement::attributesOfRowHeaders): Ditto.
2656         (WTR::AccessibilityUIElement::attributesOfColumns): Ditto.
2657         (WTR::AccessibilityUIElement::attributesOfRows): Ditto.
2658         (WTR::AccessibilityUIElement::attributesOfVisibleCells): Ditto.
2659         (WTR::AccessibilityUIElement::attributesOfHeader): Ditto.
2660         (WTR::AccessibilityUIElement::selectedTextRange): Ditto.
2661         (WTR::AccessibilityUIElement::accessibilityValue const): Ditto.
2662         (WTR::AccessibilityUIElement::documentEncoding): Ditto.
2663         (WTR::AccessibilityUIElement::documentURI): Ditto.
2664         (WTR::AccessibilityUIElement::stringForSelection): Removed unneeded
2665         null check.
2666         (WTR::AccessibilityUIElement::stringForTextMarkerRange):
2667         Use createEmptyJSString, fixing a storage leak due to missing adoption.
2668
2669         * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.h:
2670         Use JSRetainPtr for the return value of createJSStringRef.
2671         * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.mm:
2672         (-[NSString createJSStringRef]): Ditto.
2673         (WTR::searchPredicateParameterizedAttributeForSearchCriteria): Use the
2674         adopt function instead of the adopt constructor.
2675         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
2676         (WTR::AccessibilityController::platformName): Ditto
2677
2678         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
2679         (-[NSString createJSStringRef]): Return a JSRetainPtr.
2680         (makeValueRefForValue): Updated for above by removing adopt.
2681         (makeObjectRefForDictionary): Ditto.
2682         (-[AccessibilityNotificationHandler _notificationReceived:]): Ditto.
2683
2684         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2685         (WTR::createEmptyJSString): Added. This helper function makes reduces the
2686         repetitive code to create empty strings.
2687         (WTR::concatenateAttributeAndValue): Return a JSRetainPtr.
2688         (WTR::descriptionOfElements): Ditto.
2689         (WTR::selectTextParameterizedAttributeForCriteria): Ditto.
2690         (WTR::AccessibilityUIElement::accessibilityValue const): Use createEmptyJSString,
2691         fixing a storage leak due to missing adoption.
2692         (WTR::AccessibilityUIElement::documentEncoding): Ditto.
2693         (WTR::AccessibilityUIElement::documentURI): Ditto.
2694         (WTR::createJSStringRef): Return a JSRetainPtr.
2695
2696         * WebKitTestRunner/StringFunctions.h:
2697         (WTR::toWK): Take a const& to eliminate a little bit of reference count churn.
2698         (WTR::toJS): Use the adopt function instead of the constructor.
2699
2700 2018-09-14  Dean Jackson  <dino@grorg.org>
2701
2702         Add Justin Michaud.
2703
2704         * Scripts/webkitpy/common/config/contributors.json:
2705
2706 2018-09-14  Ryan Haddad  <ryanhaddad@apple.com>
2707
2708         bots should pass --clobber-old-results to run-webkit-tests
2709         https://bugs.webkit.org/show_bug.cgi?id=189623
2710
2711         Reviewed by Aakash Jain.
2712
2713         In order to ensure that bots to not produce confusing results due to transient execptions,
2714         or run out of space if they continually hit an exception, old layout test results should be clobbered.
2715
2716         * BuildSlaveSupport/build.webkit.org-config/steps.py:
2717         (RunWebKitTests):
2718
2719 2018-09-13  Ryan Haddad  <ryanhaddad@apple.com>
2720
2721         Unreviewed, rolling out r235954.
2722
2723         Breaks the watchOS build.
2724
2725         Reverted changeset:
2726
2727         "Move IndexedDB to Network Process"
2728         https://bugs.webkit.org/show_bug.cgi?id=189415
2729         https://trac.webkit.org/changeset/235954
2730
2731 2018-09-13  Daniel Bates  <dabates@apple.com>
2732
2733         Add Copy WebKit Permalink plugin for Sublime Text
2734         https://bugs.webkit.org/show_bug.cgi?id=189589
2735
2736         Rubber-stamped by Joseph Pecoraro.
2737
2738         Port the Copy WebKit Permalink Automator service to a Sublime Text plugin. Once installed you can
2739         use the plugin to copy to the Clipboard a trac.webkit.org hyperlink to the selected line in the
2740         active document with or without blame annotations.
2741
2742         Once installed, you can Control-click (on Mac) or right-click (on Windows and Linux) on a line and
2743         choose Copy WebKit Permalink or Copy WebKit Permalink to Blame from the context menu to copy to the
2744         Clipboard a permanent hyperlink to the selected line without or with blame annotations, respectively.
2745         On Mac you can also invoke the same functionality using the keyboard shortcuts Command + Shift + Control + C
2746         and Command + Shift + Control + Option + C, respectively.
2747
2748         * CopyPermalink/Sublime Text/CopyWebKitPermalink/Context.sublime-menu: Added.
2749         * CopyPermalink/Sublime Text/CopyWebKitPermalink/CopyWebKitPermalink.py: Added.
2750         * CopyPermalink/Sublime Text/CopyWebKitPermalink/Default (OSX).sublime-keymap: Added.
2751         * CopyPermalink/Sublime Text/INSTALL: Added.
2752         * CopyPermalink/Xcode/Copy WebKit Permalink.workflow/Contents/Info.plist: Renamed from Tools/CopyPermalink/Copy WebKit Permalink.workflow/Contents/Info.plist.
2753         * CopyPermalink/Xcode/Copy WebKit Permalink.workflow/Contents/document.wflow: Renamed from Tools/CopyPermalink/Copy WebKit Permalink.workflow/Contents/document.wflow.
2754         * CopyPermalink/Xcode/INSTALL: Renamed from Tools/CopyPermalink/README.
2755
2756 2018-09-13  Carlos Garcia Campos  <cgarcia@igalia.com>
2757
2758         Unreviewed. Fix WebDriver tests after r235225.
2759
2760         Use wpt serve command to run the http server.
2761
2762         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_web_server.py:
2763         (WebDriverW3CWebServer.__init__):
2764         (WebDriverW3CWebServer.start):
2765         (WebDriverW3CWebServer.stop):
2766
2767 2018-09-13  Carlos Garcia Campos  <cgarcia@igalia.com>
2768
2769         [GTK][WPE] Allow to run script dialogs asynchronously in the UI process
2770         https://bugs.webkit.org/show_bug.cgi?id=189544
2771
2772         Reviewed by Michael Catanzaro.
2773
2774         Add test cases for the new API.
2775
2776         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
2777         (testWebViewJavaScriptDialogs):
2778
2779 2018-09-12  Fujii Hironori  <Hironori.Fujii@sony.com>
2780
2781         [Win][Clang][ImageDiff] Fix compilation error and warning of PlatformImageCairo.cpp
2782         https://bugs.webkit.org/show_bug.cgi?id=189496
2783         <rdar://problem/44370981>
2784
2785         Unreviewed warning fix.
2786
2787         r235929 has introduced a new compilation warning:
2788         > Tools/ImageDiff/cairo/PlatformImageCairo.cpp:34:70: warning: unused parameter ‘imageSize’ [-Wunused-parameter]
2789
2790         * ImageDiff/cairo/PlatformImageCairo.cpp:
2791         (ImageDiff::PlatformImage::createFromStdin): Removed the variable name.
2792
2793 2018-09-12  Dan Bernstein  <mitz@apple.com>
2794
2795         [Cocoa] Complete support for Paste as Quotation
2796         https://bugs.webkit.org/show_bug.cgi?id=189504
2797
2798         Reviewed by Wenson Hsieh.
2799
2800         * MiniBrowser/mac/MainMenu.xib: Added a Paste as Quotation command in the Edit menu.
2801
2802 2018-09-12  Sihui Liu  <sihui_liu@apple.com>
2803
2804         Move IndexedDB to Network Process
2805         https://bugs.webkit.org/show_bug.cgi?id=189415
2806
2807         Reviewed by Geoffrey Garen.
2808
2809         * TestWebKitAPI/Tests/WebKitCocoa/IDBDeleteRecovery.mm:
2810         (TEST):
2811         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
2812         (TEST):
2813         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBDatabaseProcessKill.mm:
2814         (TEST):
2815         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBMultiProcess.mm:
2816         (TEST):
2817         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
2818         (TEST):
2819
2820 2018-09-12  Chris Dumez  <cdumez@apple.com>
2821
2822         PSON: No process swap on back navigation after URL bar navigation
2823         https://bugs.webkit.org/show_bug.cgi?id=189557
2824         <rdar://problem/44353108>
2825
2826         Reviewed by Alex Christensen.
2827
2828         Add API test coverage.
2829
2830         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2831
2832 2018-09-11  Dean Jackson  <dino@apple.com>
2833
2834         Header parsing for experimental and internal debug features
2835         https://bugs.webkit.org/show_bug.cgi?id=189486
2836         <rdar://problem/44320618>
2837
2838         Reviewed by Tim Horton.
2839
2840         Keep track of experimental and internal debug features in TestOptions, and
2841         allow webkit-test-runner headers to toggle them by name.
2842
2843         * DumpRenderTree/TestOptions.cpp:
2844         (TestOptions::TestOptions):
2845         * WebKitTestRunner/TestController.cpp:
2846         (WTR::TestController::resetPreferencesToConsistentValues):
2847         (WTR::updateTestOptionsFromTestHeader):
2848         * WebKitTestRunner/TestOptions.h:
2849         (WTR::TestOptions::hasSameInitializationOptions const):
2850
2851 2018-09-12  Fujii Hironori  <Hironori.Fujii@sony.com>
2852
2853         [Win][Clang][DumpRenderTree] 0 and nullptr can't be implicitly converted to AccessibilityUIElement
2854         https://bugs.webkit.org/show_bug.cgi?id=189492
2855
2856         Reviewed by Alex Christensen.
2857
2858         0 and nullptr can't be implicitly converted to
2859         AccessibilityUIElement because only Windows port typedefs
2860         PlatformUIElement as COMPtr<IAccessible> not a pointer.
2861
2862         Replaced "return 0" and "return nullptr" with "return { nullptr }".
2863
2864         * DumpRenderTree/AccessibilityUIElement.cpp:
2865         (AccessibilityUIElement::horizontalScrollbar const):
2866         (AccessibilityUIElement::verticalScrollbar const):
2867         (AccessibilityUIElement::uiElementAttributeValue const):
2868         (AccessibilityUIElement::accessibilityElementForTextMarker):
2869         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2870         (AccessibilityController::elementAtPoint):
2871         (AccessibilityController::accessibleElementById):
2872         (AccessibilityController::focusedElement):
2873         (AccessibilityController::rootElement):
2874         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2875         (AccessibilityUIElement::elementAtPoint):
2876         (AccessibilityUIElement::linkedUIElementAtIndex):
2877         (AccessibilityUIElement::getChildAtIndex):
2878         (AccessibilityUIElement::titleUIElement):
2879         (AccessibilityUIElement::parentElement):
2880         (AccessibilityUIElement::uiElementForSearchPredicate):
2881         (AccessibilityUIElement::cellForColumnAndRow):
2882         (AccessibilityUIElement::disclosedRowAtIndex):
2883         (AccessibilityUIElement::ariaOwnsElementAtIndex):
2884         (AccessibilityUIElement::ariaFlowToElementAtIndex):
2885         (AccessibilityUIElement::ariaControlsElementAtIndex):
2886         (AccessibilityUIElement::selectedRowAtIndex):
2887         (AccessibilityUIElement::rowAtIndex):
2888         (AccessibilityUIElement::disclosedByRow):
2889         (AccessibilityUIElement::selectedChildAtIndex const):
2890
2891 2018-09-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2892
2893         FontManagerTests.ChangeFontColorWithColorPanel fails on macOS Sierra
2894         https://bugs.webkit.org/show_bug.cgi?id=189382
2895
2896         Reviewed by Ryosuke Niwa.
2897
2898         Fix the test by specifying colors in RGB colorspace.
2899
2900         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
2901         (TestWebKitAPI::TEST):
2902
2903 2018-09-11  Fujii Hironori  <Hironori.Fujii@sony.com>
2904
2905         [Win][Clang][ImageDiff] Fix compilation error and warning of PlatformImageCairo.cpp
2906         https://bugs.webkit.org/show_bug.cgi?id=189496
2907
2908         Reviewed by Alex Christensen.
2909
2910         * ImageDiff/cairo/PlatformImageCairo.cpp:
2911         (ImageDiff::PlatformImage::createFromStdin): Removed unnecessary ReadContext struct.
2912         (ImageDiff::PlatformImage::writeAsPNGToStdout): Use '%lu' format type specifier for unsigned long.
2913
2914 2018-09-07  Dean Jackson  <dino@apple.com>
2915
2916         Add and expose Internal features from WebKit
2917         https://bugs.webkit.org/show_bug.cgi?id=189442
2918         <rdar://problem/44243404>
2919
2920         Reviewed by Simon Fraser.
2921
2922         Update MiniBrowser to expose an Internal feature menu.
2923
2924         * MiniBrowser/mac/AppDelegate.m:
2925         (defaultConfiguration):
2926         * MiniBrowser/mac/SettingsController.m:
2927         (-[SettingsController _populateMenu]):
2928         (-[SettingsController validateMenuItem:]):
2929         (-[SettingsController toggleExperimentalFeature:]):
2930         (-[SettingsController toggleInternalDebugFeature:]):
2931
2932 2018-09-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2933
2934         [macOS] [WK2] Support changing foreground colors via color panel
2935         https://bugs.webkit.org/show_bug.cgi?id=189382
2936         <rdar://problem/44227311>
2937
2938         Reviewed by Ryosuke Niwa.
2939
2940         Add an API test that uses NSColorPanel to change the color of selected text, and also apply typing styles when
2941         the selection is collapsed. The test also exercises switching between opaque colors (alpha = 1) and transparent
2942         colors, as well as making different parts of a word different colors.
2943
2944         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
2945         (-[TestWKWebView collapseToEnd]):
2946         (webViewForFontManagerTesting):
2947         (TestWebKitAPI::TEST):
2948         * TestWebKitAPI/cocoa/TestWKWebView.h:
2949
2950 == Rolled over to ChangeLog-2018-09-11 ==