Tools/ChangeLog

   1 2014-03-31  Ryuan Choi  <ryuan.choi@samsung.com>
   2
   3         Unreviewed build fix on the EFL port with latest EFL libraries since r166149
   4
   5         * ImageDiff/PlatformEfl.cmake: Added ECORE_IMF_INCLUDE_DIRS to include dirs
   6
   7 2014-03-31  Brent Fulgham  <bfulgham@apple.com>
   8
   9         Unreviewed test correction after r166530.
  10
  11         * DumpRenderTree/mac/DumpRenderTree.mm:
  12         (setDefaultsToConsistentValuesForTesting): No need to change preference for all tests. We set the proper
  13         fine-grained setting for swipe tests. This prevents existing tests from breaking.
  14
  15 2014-03-31  Carlos Alberto Lopez Perez  <clopez@igalia.com>
  16
  17         Remove the trigger for webkit1 tests on the gtk-linux-64-release bot
  18         https://bugs.webkit.org/show_bug.cgi?id=130987
  19
  20         r166427 removed the WebKit1 GTK+ bots, so we don't longer need to
  21         trigger the webkit1 bot tests on the gtk-linux-64-release bot.
  22
  23         Reviewed by Martin Robinson.
  24
  25         * BuildSlaveSupport/build.webkit.org-config/config.json:
  26
  27 2014-03-31  Dean Jackson  <dino@apple.com>
  28
  29         Remove WEB_ANIMATIONS
  30         https://bugs.webkit.org/show_bug.cgi?id=130989
  31
  32         Reviewed by Simon Fraser.
  33
  34         Remove this feature flag until we plan to implement.
  35
  36         * Scripts/webkitperl/FeatureList.pm:
  37
  38 2014-03-31  Brent Fulgham  <bfulgham@apple.com>
  39
  40         Reduced Latched Scroll Test Flakiness
  41         https://bugs.webkit.org/show_bug.cgi?id=130983
  42
  43         Reviewed by Darin Adler.
  44
  45         * DumpRenderTree/mac/DumpRenderTree.mm:
  46         (setDefaultsToConsistentValuesForTesting): Test user should have 'high resolution' scrolling.
  47         * DumpRenderTree/mac/EventSendingController.mm:
  48         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]): Generate mouse wheel events
  49         with high resolution flags turned on.
  50         * WebKitTestRunner/mac/EventSenderProxy.mm:
  51         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases): Ditto.
  52
  53 2014-03-31  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
  54
  55         run-webkit-tests should have a --no-timeout option
  56         https://bugs.webkit.org/show_bug.cgi?id=128286
  57
  58         Reviewed by Joseph Pecoraro.
  59
  60         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
  61         (Worker._run_test): Renaming _run_test_with_timeout()
  62         (Worker._run_test_with_or_without_timeout): Renaming _run_test_with_timeout(), because tests can now run without timeout.
  63         (Worker._run_test_in_another_thread): Passing the --no-timeout option to the driver
  64         (Worker._run_test_in_this_thread):
  65         (Worker._run_test_with_timeout): Deleted.
  66         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  67         (parse_args): Added the --no-timeout option
  68
  69 2014-03-31  Samuel White  <samuel_white@apple.com>
  70
  71         AX: Need ability to get line range for text marker.
  72         https://bugs.webkit.org/show_bug.cgi?id=130906
  73
  74         Reviewed by Chris Fleizach.
  75
  76         Added a new function in DRT and TestRunner to test that AXLineTextMarkerRangeForTextMarker works as expected.
  77
  78         * DumpRenderTree/AccessibilityUIElement.cpp:
  79         (lineTextMarkerRangeForTextMarkerCallback):
  80         (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
  81         (AccessibilityUIElement::getJSClass):
  82         * DumpRenderTree/AccessibilityUIElement.h:
  83         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
  84         (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
  85         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
  86         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
  87         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
  88         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
  89         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
  90         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
  91         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
  92         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
  93         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
  94         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
  95
  96 2014-03-31  Filip Pizlo  <fpizlo@apple.com>
  97
  98         More validation for FTL inline caches
  99         https://bugs.webkit.org/show_bug.cgi?id=130948
 100
 101         Reviewed by Geoffrey Garen.
 102
 103         * Scripts/run-jsc-stress-tests:
 104
 105 2014-03-31  Carlos Garcia Campos  <cgarcia@igalia.com>
 106
 107         [GTK] Do not run WebKit1 unit tests by default
 108         https://bugs.webkit.org/show_bug.cgi?id=130968
 109
 110         Reviewed by Martin Robinson.
 111
 112         * Scripts/run-gtk-tests:
 113         (TestRunner):
 114
 115 2014-03-31  Martin Robinson  <mrobinson@igalia.com>
 116
 117         [GTK] Remove scripts code only applicable to autotools
 118         https://bugs.webkit.org/show_bug.cgi?id=130841
 119
 120         Reviewed by Anders Carlsson.
 121
 122         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
 123         (_should_file_trigger_build): Update file list to reflect GTK+ CMake port.
 124         * Scripts/webkitpy/common/config/watchlist: Remove the GTK+ build watchlist.
 125         * Scripts/webkitpy/style/checker.py: The GNUmakefile doesn't exist any longer.
 126         * gtk/find-make-dist-errors: Removed.
 127         * gtk/generate-feature-defines-files: Removed.
 128         * gtk/manifest.txt: No longer need to consider autotools files.
 129
 130 2014-03-30  Andy Estes  <aestes@apple.com>
 131
 132         Fix two failing layout tests on Mountain Lion after r166466.
 133
 134         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
 135         (-[DownloadDelegate _downloadDidStart:]):
 136
 137 2014-03-30  Andy Estes  <aestes@apple.com>
 138
 139         [Cocoa] Add an originatingWebView property to _WKDownload
 140         https://bugs.webkit.org/show_bug.cgi?id=130945
 141
 142         Reviewed by Anders Carlsson.
 143
 144         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
 145         (-[DownloadDelegate _downloadDidStart:]):
 146         (-[OriginatingWebViewDownloadDelegate initWithWebView:]):
 147         (-[OriginatingWebViewDownloadDelegate _downloadDidStart:]):
 148         (TEST):
 149
 150 2014-03-28  Filip Pizlo  <fpizlo@apple.com>
 151
 152         Land the stackmap register liveness glue with the uses of the liveness disabled
 153         https://bugs.webkit.org/show_bug.cgi?id=130924
 154
 155         Reviewed by Oliver Hunt.
 156
 157         * Scripts/run-jsc-stress-tests:
 158
 159 2014-03-29  Alexey Proskuryakov  <ap@apple.com>
 160
 161         Update WebKit1.StringTruncator for Mountain Lion.
 162
 163         * TestWebKitAPI/Tests/mac/StringTruncator.mm: Looks like one subtest was failing
 164         due to different font metrics on 10.8.
 165
 166 2014-03-28  Darin Adler  <darin@apple.com>
 167
 168         Fix recently-introduced off-by-one error in centerTruncateToBuffer
 169         https://bugs.webkit.org/show_bug.cgi?id=130889
 170
 171         Reviewed by Alexey Proskuryakov.
 172
 173         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added StringTruncator.mm.
 174         * TestWebKitAPI/Tests/mac/StringTruncator.mm: Added. One test for each of the
 175         WebStringTruncator methods; should be good for a start. These are dependent on the
 176         metrics of Helvetica 12, but I am hoping that will be consistent across OS X machines.
 177
 178 2014-03-28  Martin Hock  <mhock@apple.com>
 179
 180         Unreviewed. Add myself as a committer.
 181
 182         * Scripts/webkitpy/common/config/contributors.json:
 183
 184 2014-03-28  Martin Robinson  <mrobinson@igalia.com>
 185
 186         Remove WebKit1 GTK+ bots
 187         https://bugs.webkit.org/show_bug.cgi?id=130904
 188
 189         Reviewed by Anders Carlsson.
 190
 191         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove references to GTK+ WebKit1 test bot and ensure
 192         all bots are testing WebKit2 only.
 193         * Scripts/webkitpy/common/config/ews.json: Remove references to GTK+ WK1 EWS.
 194         * Scripts/webkitpy/common/config/ports.py: Remove references to GTK+ WK1 bots.
 195         * Scripts/webkitpy/common/config/ports_unittest.py: Ditto.
 196         * Scripts/webkitpy/port/builders.py: Ditto.
 197         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py: Ditto.
 198         * TestResultServer/static-dashboards/builders.jsonp: Ditto.
 199
 200 2014-03-28  Timothy Hatcher  <timothy@apple.com>
 201
 202         Remove Brian Burg's apple.com email address.
 203
 204         * Scripts/webkitpy/common/config/contributors.json:
 205
 206 2014-03-28  David Kilzer  <ddkilzer@apple.com>
 207
 208         bisect-builds should print Trac 'changeset' URL if only one build is detected
 209         <http://webkit.org/b/130903>
 210
 211         Reviewed by Dan Bernstein.
 212
 213         * Scripts/bisect-builds:
 214         (printTracLink): Print a direct link to the Trac 'changeset'
 215         URL if there is only one revision in the range.
 216
 217 2014-03-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
 218
 219         [EFL] Bump glib version from 2.36 to 2.38
 220         https://bugs.webkit.org/show_bug.cgi?id=130886
 221
 222         Reviewed by Csaba Osztrogonác.
 223
 224         There is a build break on EFL port when using glib 2.36 ver. To fix it,
 225         we need to bump glib version up to 2.38 as gtk port.
 226
 227         * efl/jhbuild.modules:
 228
 229 2014-03-27  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
 230
 231         <https://webkit.org/b/42704> WebKitTestRunner needs to print history delegate information
 232
 233         Provide an implementation of WKContextHistoryClient that logs when called for tests in
 234         the globalhistory directory.
 235
 236         Reviewed by Sam Weinig.
 237
 238         * WebKitTestRunner/TestController.cpp:
 239         (WTR::TestController::TestController):
 240         (WTR::TestController::initialize): Set the history client.
 241         (WTR::TestController::resetStateToConsistentValues): Disable logging of history client callbacks.
 242         (WTR::TestController::didNavigateWithNavigationData): Log information about the navigation. Some portions
 243         of the output are hard-coded to match WebKit1's results for now since they're fixed in our existing tests
 244         and we don't yet have API to access the data in question.
 245         (WTR::TestController::didPerformClientRedirect):
 246         (WTR::TestController::didPerformServerRedirect):
 247         (WTR::TestController::didUpdateHistoryTitle):
 248         * WebKitTestRunner/TestController.h:
 249         (WTR::TestController::setShouldLogHistoryClientCallbacks):
 250         * WebKitTestRunner/TestInvocation.cpp:
 251         (WTR::shouldLogHistoryClientCallbacks): Log history client callbacks for tests in a globalhistory directory.
 252         (WTR::TestInvocation::invoke):
 253
 254 2014-03-27  Filip Pizlo  <fpizlo@apple.com>
 255
 256         Revert http://trac.webkit.org/changeset/166386 because it broke builds.
 257
 258         * Scripts/build-webkit:
 259         * Scripts/copy-webkitlibraries-to-product-directory:
 260
 261 2014-03-27  Filip Pizlo  <fpizlo@apple.com>
 262
 263         Switch the LLVMForJSC target to using the LLVM in /usr/local rather than /usr/local/LLVMForJavaScriptCore on iOS
 264         https://bugs.webkit.org/show_bug.cgi?id=130867
 265         <rdar://problem/16432456>
 266
 267         Reviewed by Mark Hahnenberg.
 268
 269         * Scripts/build-webkit:
 270         * Scripts/copy-webkitlibraries-to-product-directory:
 271
 272 2014-03-26  Andy Estes  <aestes@apple.com>
 273
 274         [Cocoa] Expose DownloadClient::didFail() and DownloadClient::didCancel()
 275         https://bugs.webkit.org/show_bug.cgi?id=130805
 276
 277         Reviewed by Dan Bernstein.
 278
 279         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
 280         (-[DownloadDelegate _download:didReceiveResponse:]):
 281         (-[DownloadDelegate _downloadDidFinish:]):
 282         (runTest):
 283         (TEST):
 284         (-[FailingDownloadDelegate _downloadDidFinish:]):
 285         (-[FailingDownloadDelegate _download:didFailWithError:]):
 286         (-[FailingDownloadDelegate _downloadDidCancel:]):
 287         (-[CancelledDownloadDelegate _downloadDidStart:]):
 288         (-[CancelledDownloadDelegate _downloadDidFinish:]):
 289         (-[CancelledDownloadDelegate _download:didFailWithError:]):
 290         (-[CancelledDownloadDelegate _downloadDidCancel:]):
 291         (-[DownloadDelegate initWithSourceURL:]): Deleted.
 292         (-[DownloadDelegate sourceURL]): Deleted.
 293         (runTestWithNavigationDelegate): Deleted.
 294
 295 2014-03-26  Anders Carlsson  <andersca@apple.com>
 296
 297         Change MiniBrowser to hold on to window controllers instead of windows
 298         https://bugs.webkit.org/show_bug.cgi?id=130797
 299
 300         Reviewed by Oliver Hunt.
 301
 302         * MiniBrowser/mac/AppDelegate.h:
 303         * MiniBrowser/mac/AppDelegate.m:
 304         (-[BrowserAppDelegate init]):
 305         (-[BrowserAppDelegate newWindow:]):
 306         (-[BrowserAppDelegate browserWindowWillClose:]):
 307         (-[BrowserAppDelegate applicationWillTerminate:]):
 308         (-[BrowserAppDelegate frontmostBrowserWindowController]):
 309
 310 2014-03-26  Commit Queue  <commit-queue@webkit.org>
 311
 312         Unreviewed, rolling out r166264.
 313         https://bugs.webkit.org/show_bug.cgi?id=130785
 314
 315         Broke some window.opener tests for WK2 Mavericks (Requested by
 316         brrian__ on #webkit).
 317
 318         Reverted changeset:
 319
 320         "Web Replay: resource unique identifiers should be unique-per-
 321         frame, not globally"
 322         https://bugs.webkit.org/show_bug.cgi?id=130632
 323         http://trac.webkit.org/changeset/166264
 324
 325 2014-03-26  Zoltan Horvath  <zoltan@webkit.org>
 326
 327         [CSS Shapes] Remove shape-inside support
 328         https://bugs.webkit.org/show_bug.cgi?id=130698
 329
 330         Reviewed by David Hyatt.
 331
 332         * Scripts/webkitperl/FeatureList.pm:
 333
 334 2014-02-27  Gurpreet Kaur  <k.gurpreet@samsung.com>
 335
 336         Unreviewed. Add myself as a committer.
 337
 338         * Scripts/webkitpy/common/config/contributors.json:
 339
 340 2014-03-26  Tomas Popela  <tpopela@redhat.com>
 341
 342         run-launcher is Perl script so use elsif and not elif
 343         https://bugs.webkit.org/show_bug.cgi?id=130771
 344
 345         Reviewed by Carlos Garcia Campos.
 346
 347         * Scripts/run-launcher:
 348
 349 2014-03-26  Krzysztof Czech  <k.czech@samsung.com>
 350
 351         [ATK] Utilize new AtkValue interface coming in ATK 2.11.92
 352         https://bugs.webkit.org/show_bug.cgi?id=130575
 353
 354         Reviewed by Mario Sanchez Prada.
 355
 356         Change ATK version to 2.11.92. Adjust current implementation.
 357
 358         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
 359         (AccessibilityUIElement::intValue):
 360         (AccessibilityUIElement::minValue):
 361         (AccessibilityUIElement::maxValue):
 362         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
 363         (WTR::AccessibilityUIElement::intValue):
 364         (WTR::AccessibilityUIElement::minValue):
 365         (WTR::AccessibilityUIElement::maxValue):
 366         * efl/jhbuild.modules:
 367         * gtk/jhbuild.modules:
 368
 369 2014-03-12  Philippe Normand  <pnormand@igalia.com>
 370
 371         [GTK] The gnumake package is no longer needed in jhbuild
 372         https://bugs.webkit.org/show_bug.cgi?id=130121
 373
 374         Reviewed by Martin Robinson.
 375
 376         For GTK build-webkit now relies on cmake and ninja/gnumake. Even
 377         for a debug build cmake/system-gnumake worked just fine for me.
 378
 379         * gtk/jhbuild.modules: Removed gnumake.
 380         * gtk/patches/make-3.82-arg-list-length.patch: Removed.
 381         * gtk/patches/make-3.82-parallel-build.patch: Removed.
 382
 383 2014-03-25  Andy Estes  <aestes@apple.com>
 384
 385         Fix a failing API test on Mountain Lion and remove temporary debug logging.
 386
 387         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
 388         (-[DownloadDelegate _download:didReceiveData:]):
 389         (-[DownloadDelegate _downloadDidFinish:]):
 390
 391 2014-03-25  Brian Burg  <bburg@apple.com>
 392
 393         Web Replay: resource unique identifiers should be unique-per-frame, not globally
 394         https://bugs.webkit.org/show_bug.cgi?id=130623
 395
 396         Reviewed by Timothy Hatcher.
 397
 398         The resource loader callback dumping routines assumed that resource identifiers
 399         were globally unique. Its map of resource identifiers to URLs must also track the
 400         frame associated with the resource.
 401
 402         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
 403         (WTR::dumpResourceURL): Additionally take a WKBundleFrameRef argument, and use the
 404         opaque pointer as part of the key for assignedUrlsCache. The frame pointer is
 405         stable as long as the frame is valid.
 406         (WTR::InjectedBundlePage::didInitiateLoadForResource):
 407         (WTR::InjectedBundlePage::willSendRequestForFrame):
 408         (WTR::InjectedBundlePage::didReceiveResponseForResource):
 409         (WTR::InjectedBundlePage::didFinishLoadForResource):
 410         (WTR::InjectedBundlePage::didFailLoadForResource):
 411
 412 2014-03-25  Andy Estes  <aestes@apple.com>
 413
 414         Fix one API test expectation failure on Mountain Lion, and add additional logging to help diagnose another.
 415
 416         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
 417         (-[DownloadDelegate _download:didReceiveResponse:]):
 418         (-[DownloadDelegate _download:didReceiveData:]):
 419
 420 2014-03-25  Andy Estes  <aestes@apple.com>
 421
 422         Add some debug logging to an API test that's failing on Mountain Lion.
 423
 424         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
 425         (-[DownloadDelegate _download:didReceiveResponse:]):
 426         (-[DownloadDelegate _downloadDidFinish:]):
 427
 428 2014-03-25  Anders Carlsson  <andersca@apple.com>
 429
 430         Add goBack: and goForward: IBActions and move stopLoading: to a new WKIBActions category on WKWebView
 431         https://bugs.webkit.org/show_bug.cgi?id=130732
 432
 433         Reviewed by Tim Horton.
 434
 435         * MiniBrowser/mac/WK2BrowserWindowController.m:
 436         (-[WK2BrowserWindowController validateUserInterfaceItem:]):
 437
 438 2014-03-25  Martin Robinson  <mrobinson@igalia.com>
 439
 440         [GTK] Remove the autotools build
 441         https://bugs.webkit.org/show_bug.cgi?id=130717
 442
 443         Reviewed by Anders Carlsson.
 444
 445         * DumpRenderTree/config.h: Remove references to the autotools configure file.
 446         * GNUmakefile.am: Removed.
 447         * GtkLauncher/GNUmakefile.am: Removed.
 448         * GtkLauncher/main.c: Remove references to the autotools configure file.
 449         * MiniBrowser/gtk/BrowserDownloadsBar.c: Ditto.
 450         * MiniBrowser/gtk/BrowserSearchBar.c: Ditto.
 451         * MiniBrowser/gtk/BrowserWindow.c: Ditto.
 452         * MiniBrowser/gtk/GNUmakefile.am: Removed.
 453         * MiniBrowser/gtk/main.c: Remove references to the autotools configure file.
 454         * Scripts/build-webkit: No longer handle autotools.
 455         * Scripts/run-gtk-tests: Ditto.
 456         (TestRunner._setup_testing_environment):
 457         * Scripts/run-launcher: Ditto.
 458         * Scripts/webkitdirs.pm: Ditto.
 459         * Scripts/webkitpy/common/config/contributionareas.py: Remove autotools as a contribution area.
 460         * Scripts/webkitpy/common/config/contributors.json: Ditto.
 461         * Scripts/webkitpy/port/gtk.py: No longer handle autotools.
 462         * Scripts/webkitpy/style/checker.py:
 463         * TestWebKitAPI/GNUmakefile.am: Removed.
 464         * TestWebKitAPI/config.h: Remove references to the autotools configure file.
 465         * WebKitTestRunner/GNUmakefile.am: Removed.
 466         * WebKitTestRunner/WebKitTestRunnerPrefix.h: Ditto.
 467         * gtk/GNUmakefile.am: Removed.
 468         * gtk/common.py: Remove checks for the autotools build.
 469         * gtk/symbols.filter: Renamed from Source/autotools/symbols.filter.
 470
 471 2014-03-25  László Langó  <llango.u-szeged@partner.samsung.com>
 472
 473         prepare-ChangeLog throws false positive warnings for modified files.
 474         https://bugs.webkit.org/show_bug.cgi?id=130687
 475
 476         Reviewed by Darin Adler.
 477
 478         * Scripts/prepare-ChangeLog:
 479         (originalFile): Ignore git commit paremeter.
 480         We don't need this to get the unmodified file.
 481         (extractLineRangeBeforeChange):
 482         Simplify the if statement. Follow-up after r166189.
 483
 484 2014-03-25  Gabor Rapcsanyi  <rgabor@webkit.org>
 485
 486         [EFL] Add ARM64 build support
 487         https://bugs.webkit.org/show_bug.cgi?id=130506
 488
 489         Rubber stamped by Gyuyoung Kim.
 490
 491         * Scripts/webkitdirs.pm:
 492         (isARM): Detect aarch64 as ARM.
 493
 494 2014-03-25  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
 495
 496         [webkitpy] Improve _parse_bug_description to recognize more descriptions
 497         https://bugs.webkit.org/show_bug.cgi?id=130137
 498
 499         Reviewed by Csaba Osztrogonác.
 500
 501         * Scripts/webkitpy/common/checkout/changelog.py:
 502         (ChangeLogEntry._parse_bug_description):
 503         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
 504         (test_parse_log_entries_from_changelog):
 505         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
 506         (CheckoutTest.test_commit_info_for_revision):
 507
 508 2014-03-24  Andy Estes  <aestes@apple.com>
 509
 510         Fix the iOS build of TestWebKitAPI.
 511
 512         * TestWebKitAPI/Configurations/Base.xcconfig:
 513         * TestWebKitAPI/PlatformUtilities.h:
 514
 515 2014-03-24  László Langó  <llango.u-szeged@partner.samsung.com>
 516
 517         Fix prepare-ChangeLog after r166156.
 518         https://bugs.webkit.org/show_bug.cgi?id=130674
 519
 520         Reviewed by Darin Adler.
 521
 522         * Scripts/prepare-ChangeLog:
 523         (generateFunctionLists):
 524         (extractLineRangeBeforeChange):
 525
 526 2014-03-24  Andy Estes  <aestes@apple.com>
 527
 528         [iOS] Download support by CFURLDownloadRef under USE(CFNETWORK).
 529         https://bugs.webkit.org/show_bug.cgi?id=129322
 530
 531         Reviewed by Anders Carlsson.
 532
 533         Add an API test suite for _WKDownload.
 534
 535         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 536         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm: Added.
 537         (-[DownloadDelegate initWithSourceURL:]):
 538         (-[DownloadDelegate sourceURL]):
 539         (-[DownloadDelegate _downloadDidStart:]):
 540         (-[DownloadDelegate _download:didReceiveResponse:]):
 541         (-[DownloadDelegate _download:didReceiveData:]):
 542         (-[DownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
 543         (-[DownloadDelegate _downloadDidFinish:]):
 544         (TEST):
 545         (runTestWithNavigationDelegate):
 546         (-[DownloadNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
 547         (-[ConvertResponseToDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
 548
 549 2014-03-24  Joseph Pecoraro  <pecoraro@apple.com>
 550
 551         filter-build-webkit: reduce unfiltered output
 552         https://bugs.webkit.org/show_bug.cgi?id=130485
 553
 554         Reviewed by Brent Fulgham.
 555
 556         * Scripts/filter-build-webkit:
 557         (shouldIgnoreLine):
 558
 559 2014-03-24  László Langó  <llango.u-szeged@partner.samsung.com>
 560
 561         prepare-ChangeLog should list functions that have been removed too.
 562         https://bugs.webkit.org/show_bug.cgi?id=130508
 563
 564         Reviewed by Darin Adler.
 565
 566         The prepare-ChangeLog does not list the deleted functions in the Changelog.
 567         We have to read the functions and the line ranges of them from the source
 568         before the change, then search for overlaps between them and the changed
 569         line ranges from diff.
 570
 571         * Scripts/prepare-ChangeLog:
 572         (originalFile): Get original source command.
 573         (generateFunctionLists): Collect deleted functions too.
 574         (generateFunctionListsByRanges): Duplicated code is moved to a separate subroutine.
 575         (extractLineRangeBeforeChange): Extract line ranges from the original source to get
 576         deleted functions ranges too.
 577         (extractLineRange): Renamed to extractLineRangeAfterChange.
 578
 579 2014-03-23  Hyowon Kim  <hw1008.kim@samsung.com>
 580
 581         Move all EFL typedefs into EflTypedefs.h.
 582         https://bugs.webkit.org/show_bug.cgi?id=130511
 583
 584         Reviewed by Gyuyoung Kim.
 585
 586         * TestWebKitAPI/PlatformWebView.h: Remove EFL typedefs.
 587         * WebKitTestRunner/InjectedBundle/TestRunner.h: Ditto.
 588         * WebKitTestRunner/PlatformWebView.h: Ditto.
 589
 590 2014-03-21  Simon Fraser  <simon.fraser@apple.com>
 591
 592         Don't flush compositing layers within FrameView::willPaintContents()
 593         https://bugs.webkit.org/show_bug.cgi?id=130627
 594         <rdar://problem/16368869>
 595
 596         Reviewed by Sam Weinig.
 597
 598         Fix DRT to correctly render tests with layers now that FrameView::paintContents
 599         does not flush.
 600
 601         Move the -[WebView displayIfNeeded] from -[FrameLoadDelegate webView:didFinishLoadForFrame:]
 602         into an explicit function called before dumping.
 603
 604         Then explicitly call _flushCompositingChanges to ensure that GraphicsLayer changes
 605         are flushed to CA. They will be pushed to the window by snapshotting.
 606
 607         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
 608         Fix weird path to IOKit.framework.
 609         * DumpRenderTree/mac/DumpRenderTree.mm:
 610         (updateDisplay):
 611         (dump):
 612         * DumpRenderTree/mac/FrameLoadDelegate.mm:
 613         (-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]): Fix parameter name.
 614         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]): Remove display call.
 615
 616 2014-03-21  David Kilzer  <ddkilzer@apple.com>
 617
 618         fix-blink-patch: tool to fix up renamed directory paths in Blink
 619         <http://webkit.org/b/130609>
 620
 621         Reviewed by Ryosuke Niwa.
 622
 623         Usage: cat blink.patch | fix-blink-patch | svn-apply
 624
 625         * Scripts/fix-blink-patch: Added.
 626
 627 2014-03-21  Darin Adler  <darin@apple.com>
 628
 629         Remove use of deprecatedCharacters in WebKit API tests
 630         https://bugs.webkit.org/show_bug.cgi?id=130602
 631
 632         Reviewed by Antti Koivisto.
 633
 634         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
 635         (TestWebKitAPI::expectBuilderContent): Use characters8/16 instead of deprecatedCharacters.
 636         (TestWebKitAPI::expectEmpty): Use characters8.
 637         (TestWebKitAPI::TEST): Use characters8 instead of deprecatedCharacters in most cases.
 638
 639         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
 640         Removed the test that is entirely about 16-bit conversion since that's basically a test of
 641         the deprecatedCharacters function itself, which we are about to delete.
 642
 643 2014-03-21  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
 644
 645         [webkitpy] Fix has_valid_reviewer()
 646         https://bugs.webkit.org/show_bug.cgi?id=130589
 647
 648         Reviewed by Csaba Osztrogonác.
 649
 650         * Scripts/webkitpy/common/checkout/changelog.py:
 651         (ChangeLogEntry.has_valid_reviewer):
 652         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
 653         (test_has_valid_reviewer):
 654         * Scripts/webkitpy/common/config/committers.py:
 655         (CommitterList._reviewer_only):
 656         (CommitterList.committer_by_name):
 657         (CommitterList.reviewer_by_email):
 658         (CommitterList):
 659         (CommitterList.reviewer_by_name):
 660
 661 2014-03-21  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
 662
 663         Add cache support for jhbuild
 664         https://bugs.webkit.org/show_bug.cgi?id=130588
 665
 666         Reviewed by Csaba Osztrogonác.
 667
 668         * jhbuild/jhbuildrc_common.py:
 669         (init): Jhbuild can now save the dependencies locally, if the JHBUILD_MIRROR environment variable is set.
 670
 671 2014-03-21  Xabier Rodriguez Calvar  <calvaris@igalia.com>
 672
 673         [CMake] Add support for MAX_CPU_LOAD translated to -l in ninja and make
 674         https://bugs.webkit.org/show_bug.cgi?id=130504
 675
 676         Reviewed by Martin Robinson.
 677
 678         * Scripts/build-webkit: Add the maxCPULoad() to the makeArgs in
 679         CMake if not specified.
 680         * Scripts/webkitdirs.pm:
 681         (determineMaxCPULoad): Read MAX_CPU_LOAD as maxCPULoad.
 682         (maxCPULoad): determineMaxCPULoad and return maxCPULoad.
 683
 684 2014-03-21  Andreas Kling  <akling@apple.com>
 685
 686         RetainPtr API test should use CFArray instead of CFString for testing.
 687         <rdar://problem/16384899>
 688
 689         Unreviewed bot fix.
 690
 691         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp:
 692         (TestWebKitAPI::TEST):
 693         * TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp:
 694         (TestWebKitAPI::TEST):
 695
 696 2014-03-20  Hyowon Kim  <hw1008.kim@samsung.com>
 697
 698         Move to using std::unique_ptr for EFL objects.
 699         https://bugs.webkit.org/show_bug.cgi?id=129853
 700
 701         Reviewed by Gyuyoung Kim.
 702
 703         EflUniquePtr is a template alias of std::unique_ptr
 704         with a custom deleter for each Efl Objects, which is motivated by GUniquePtr.
 705         This patch replaces uses of OwnPtr and PassOwnPtr for Efl objects with EflUniquePtr.
 706
 707         * DumpRenderTree/efl/DumpRenderTree.cpp:
 708         (main):
 709         * ImageDiff/efl/ImageDiff.cpp:
 710         (initEfl):
 711         (main):
 712
 713 2014-03-20  Ryuan Choi  <ryuan.choi@samsung.com>
 714
 715         Unreviewed buildfix after r165983 for non Cocoa platforms
 716
 717         Renamed WKPreferencesPrivate.h to WKPreferencesRefPrivate.h
 718
 719         * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:
 720         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
 721         * WebKitTestRunner/TestController.cpp:
 722
 723 2014-03-20  Zan Dobersek  <zdobersek@igalia.com>
 724
 725         [GTK][CMake] Add support for building with Clang
 726         https://bugs.webkit.org/show_bug.cgi?id=130260
 727
 728         Reviewed by Martin Robinson.
 729
 730         * TestWebKitAPI/CMakeLists.txt: When building with Clang TestWebKitAPI should be
 731         built with GTEST_HAS_TR1_TUPLE defined to 0 to avoid build failures occuring in the
 732         included GTest framework headers.
 733         * gtk/generate-gtkdoc:
 734         (prepare_environment_for_gtkdoc_generation): Don't modify the CFLAGS env anymore
 735         in case of using Clang since that is now set by the CMake rule.
 736
 737 2014-03-19  Simon Fraser  <simon.fraser@apple.com>
 738
 739         Expose text and page zoom in WK2 SPI, and hook them up in MiniBrowser
 740         https://bugs.webkit.org/show_bug.cgi?id=130476
 741
 742         Reviewed by Anders Carlsson.
 743
 744         Hook up page/text zoom in MiniBrowser, make reload work, remove some logging.
 745
 746         * MiniBrowser/mac/WK1BrowserWindowController.m:
 747         (-[WK1BrowserWindowController webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
 748         Remove log.
 749         * MiniBrowser/mac/WK2BrowserWindowController.m:
 750         (-[WK2BrowserWindowController awakeFromNib]):
 751         (-[WK2BrowserWindowController validateMenuItem:]):
 752         (-[WK2BrowserWindowController reload:]):
 753         Hook up reload.
 754         (-[WK2BrowserWindowController toggleZoomMode:]):
 755         (-[WK2BrowserWindowController resetZoom:]):
 756         (-[WK2BrowserWindowController canResetZoom]):
 757         (-[WK2BrowserWindowController currentZoomFactor]):
 758         (-[WK2BrowserWindowController setCurrentZoomFactor:]):
 759         (-[WK2BrowserWindowController canZoomIn]):
 760         (-[WK2BrowserWindowController canZoomOut]):
 761
 762 2014-03-19  Alexey Proskuryakov  <ap@apple.com>
 763
 764         REGRESSION (OS X 10.9.2): PageVisibilityStateWithWindowChanges.WebKit2 API test fails
 765         https://bugs.webkit.org/show_bug.cgi?id=130463
 766
 767         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm: Disable the test.
 768
 769 2014-03-18  Samuel White  <samuel_white@apple.com>
 770
 771         AX: Not able to use arrow keys to read text with VoiceOver before selection is set someplace (anyplace).
 772         https://bugs.webkit.org/show_bug.cgi?id=130250
 773
 774         Reviewed by Chris Fleizach.
 775
 776         Added ability to toggle enhanced accessibility on and off to support tests that require it.
 777
 778         * DumpRenderTree/AccessibilityController.cpp:
 779         (enableEnhancedAccessibilityCallback):
 780         (getEnhancedAccessibilityEnabledCallback):
 781         (AccessibilityController::getJSClass):
 782         * DumpRenderTree/AccessibilityController.h:
 783         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
 784         (AccessibilityController::enableEnhancedAccessibility):
 785         (AccessibilityController::enhancedAccessibilityEnabled):
 786         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
 787         (AccessibilityController::enableEnhancedAccessibility):
 788         (AccessibilityController::enhancedAccessibilityEnabled):
 789         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
 790         (AccessibilityController::enableEnhancedAccessibility):
 791         (AccessibilityController::enhancedAccessibilityEnabled):
 792         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
 793         (AccessibilityController::enableEnhancedAccessibility):
 794         (AccessibilityController::enhancedAccessibilityEnabled):
 795         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
 796         (WTR::AccessibilityController::enableEnhancedAccessibility):
 797         (WTR::AccessibilityController::enhancedAccessibilityEnabled):
 798         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
 799         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
 800
 801 2014-03-18  Filip Pizlo  <fpizlo@apple.com>
 802
 803         Unreviewed, add some contributors, and fix Nadav's entry (he's not really a reviewer
 804         yet).
 805
 806         * Scripts/webkitpy/common/config/contributors.json:
 807
 808 2014-03-18  Joseph Pecoraro  <pecoraro@apple.com>
 809
 810         Web Inspector: Remove stale ReportMemoryUsagePlugin
 811         https://bugs.webkit.org/show_bug.cgi?id=130405
 812
 813         Reviewed by Andreas Kling.
 814
 815         This clang plugin looks like it was used for the old Inspector memory
 816         instrumentation that was removed. So the tool can be removed.
 817
 818         * clang/ReportMemoryUsagePlugin/CMakeLists.txt: Removed.
 819         * clang/ReportMemoryUsagePlugin/Makefile: Removed.
 820         * clang/ReportMemoryUsagePlugin/ReportMemoryUsage.cpp: Removed.
 821         * clang/ReportMemoryUsagePlugin/tests/Source/WebCore/Test.cpp: Removed.
 822
 823 2014-03-18  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
 824
 825         webkit-patch land shouldn't add a reviewer for unreviewed build fixes
 826         https://bugs.webkit.org/show_bug.cgi?id=130220
 827
 828         Reviewed by Csaba Osztrogonác.
 829
 830         * Scripts/webkitpy/common/checkout/changelog.py:
 831         (ChangeLog.set_reviewer):
 832         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
 833         (test_set_reviewer):
 834
 835 2014-03-17  Filip Pizlo  <fpizlo@apple.com>
 836
 837         More FTL enabling.
 838
 839         Rubber stamped by Dan Bernstein.
 840
 841         * Tools/Scripts/build-webkit:
 842
 843 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
 844
 845         Renable pagination mode in WK2 MiniBrowser
 846         https://bugs.webkit.org/show_bug.cgi?id=130374
 847
 848         Reviewed by Anders Carlsson.
 849
 850         Put the implementation of togglePaginationMode: back, and correctly
 851         enable the menu item.
 852
 853         * MiniBrowser/mac/WK2BrowserWindowController.m:
 854         (-[WK2BrowserWindowController validateMenuItem:]):
 855         (-[WK2BrowserWindowController isPaginated]):
 856         (-[WK2BrowserWindowController togglePaginationMode:]):
 857
 858 2014-03-18  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
 859
 860         Add --reset option to Tools/Scripts/set-webkit-configuration script
 861         https://bugs.webkit.org/show_bug.cgi?id=130401
 862
 863         Reviewed by Csaba Osztrogonác.
 864
 865         * Scripts/set-webkit-configuration:
 866
 867 2014-03-18  Alberto Garcia  <berto@igalia.com>
 868
 869         [GTK] [CMake] build-webkit-options.txt is not generated during a fresh build
 870         https://bugs.webkit.org/show_bug.cgi?id=130388
 871
 872         Reviewed by Sergio Villar Senin.
 873
 874         * Scripts/webkitdirs.pm:
 875         (shouldRemoveCMakeCache): make sure that the build directory
 876         exists before attempting to create a file in it.
 877
 878 2014-03-18  Robert Plociennik  <r.plociennik@samsung.com>
 879
 880         [EFL] fontconfig-2.8.0 is not compliant with C++11 leading to a build break
 881         https://bugs.webkit.org/show_bug.cgi?id=130336
 882
 883         Reviewed by Gyuyoung Kim.
 884
 885         Compilation with gcc 4.8.x results in 'invalid suffix on literal; C++11
 886         requires a space between literal and string macro [-Wliteral-suffix]'
 887         warning treated as error.
 888
 889         This patch applies a solution from r162448 to the EFL port.
 890
 891         * efl/patches/fontconfig-C-11-requires-a-space-between-literal-and-identifier.patch: Added.
 892         * efl/jhbuild.modules: Added appropriate patch section.
 893
 894 2014-03-17  Ryosuke Niwa  <rniwa@webkit.org>
 895
 896         webkitpy test rebaseline.
 897
 898         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
 899         (MainTest.test_default_args):
 900
 901 2014-03-17  Ryosuke Niwa  <rniwa@webkit.org>
 902
 903         --profile should imply --test-runner-count=1 in run-perf-tests
 904         https://bugs.webkit.org/show_bug.cgi?id=130375
 905
 906         Reviewed by Benjamin Poulain.
 907
 908         Use the test runner count of 1 when --profile is specified but not --test-runner-count.
 909
 910         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
 911         (PerfTestsRunner._parse_args): Use -1 as the default value.
 912         (PerfTestsRunner._collect_tests): If --test-runner-count is set (i.e. it's a positive value),
 913         then use that value. Otherwise, if it's never set and --profile is present, test-runner-count
 914         should be 1.
 915
 916 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
 917
 918         Address some style nits.
 919
 920         * MiniBrowser/mac/WK2BrowserWindowController.m:
 921
 922 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
 923
 924         Add transparent window support back into MiniBrowser
 925         https://bugs.webkit.org/show_bug.cgi?id=130363
 926
 927         Reviewed by Anders Carlsson.
 928
 929         Re-enable transparent window support for WK2.
 930
 931         * MiniBrowser/mac/WK2BrowserWindowController.m:
 932         (-[WK2BrowserWindowController validateMenuItem:]):
 933         (-[WK2BrowserWindowController toggleTransparentWindow:]):
 934
 935 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
 936
 937         Fix the 32-bit build; make the open panel make a WK1 window.
 938
 939         * MiniBrowser/mac/AppDelegate.m:
 940         (-[BrowserAppDelegate openDocument:]):
 941
 942 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
 943
 944         Convert MiniBrowser to use WKWebView API
 945         https://bugs.webkit.org/show_bug.cgi?id=130061
 946
 947         Reviewed by Anders Carlsson.
 948
 949         Convert the MiniBrowser WK2 window to use WebKit2 API as much
 950         as possible.
 951
 952         Some functionality was removed temporarily:
 953             - text zoom, page zoom
 954             - reload
 955             - pagination mode
 956             - transparent window
 957             - dumping source
 958             - window.open support
 959             - beforeUnload panel
 960             - find in page
 961
 962         * MiniBrowser/mac/AppDelegate.h:
 963         * MiniBrowser/mac/AppDelegate.m:
 964         (-[BrowserAppDelegate init]):
 965         (-[BrowserAppDelegate newWindow:]):
 966         (-[BrowserAppDelegate applicationWillTerminate:]):
 967         (-[BrowserAppDelegate openDocument:]):
 968         * MiniBrowser/mac/WK2BrowserWindowController.h:
 969         * MiniBrowser/mac/WK2BrowserWindowController.m:
 970         (-[WK2BrowserWindowController awakeFromNib]):
 971         (-[WK2BrowserWindowController dealloc]):
 972         (-[WK2BrowserWindowController fetch:]):
 973         (-[WK2BrowserWindowController validateMenuItem:]):
 974         (-[WK2BrowserWindowController reload:]):
 975         (-[WK2BrowserWindowController goBack:]):
 976         (-[WK2BrowserWindowController goForward:]):
 977         (-[WK2BrowserWindowController toggleZoomMode:]):
 978         (-[WK2BrowserWindowController resetZoom:]):
 979         (-[WK2BrowserWindowController canResetZoom]):
 980         (-[WK2BrowserWindowController dumpSourceToConsole:]):
 981         (-[WK2BrowserWindowController togglePaginationMode:]):
 982         (-[WK2BrowserWindowController validateUserInterfaceItem:]):
 983         (-[WK2BrowserWindowController windowShouldClose:]):
 984         (-[WK2BrowserWindowController applicationTerminating]):
 985         (-[WK2BrowserWindowController currentZoomFactor]):
 986         (-[WK2BrowserWindowController setCurrentZoomFactor:]):
 987         (-[WK2BrowserWindowController toggleTransparentWindow:]):
 988         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
 989         (-[WK2BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
 990         (-[WK2BrowserWindowController webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
 991         (-[WK2BrowserWindowController webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:completionHandler:]):
 992         (-[WK2BrowserWindowController find:]):
 993         (-[WK2BrowserWindowController webView:decidePolicyForNavigationResponse:decisionHandler:]):
 994         (-[WK2BrowserWindowController webView:didStartProvisionalNavigation:]):
 995         (-[WK2BrowserWindowController webView:didReceiveServerRedirectForProvisionalNavigation:]):
 996         (-[WK2BrowserWindowController webView:didFailProvisionalNavigation:withError:]):
 997         (-[WK2BrowserWindowController webView:didCommitNavigation:]):
 998         (-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]):
 999         (-[WK2BrowserWindowController webView:didFailNavigation:withError:]):
1000         * WebKitTestRunner/PlatformWebView.h:
1001         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1002         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1003
1004 2014-03-17  Zan Dobersek  <zdobersek@igalia.com>
1005
1006         Use RunLoop objects through references instead of pointers
1007         https://bugs.webkit.org/show_bug.cgi?id=130313
1008
1009         Reviewed by Andreas Kling.
1010
1011         Adjust the code accordingly now that RunLoop::current() and RunLoop::main()
1012         return RunLoop reference instead of a pointer.
1013
1014         * TestWebKitAPI/Tests/WebKit2Gtk/DOMDOMWindowTest.cpp:
1015         (loadedCallback):
1016         (clickedCallback):
1017
1018 2014-03-17  Tim Horton  <timothy_horton@apple.com>
1019
1020         sort-export-file --help doesn't work (missing 'use')
1021         https://bugs.webkit.org/show_bug.cgi?id=130338
1022
1023         Reviewed by Anders Carlsson.
1024
1025         * Scripts/sort-export-file:
1026         Add a missing 'use', and fix a typo in an error message.
1027
1028 2014-03-17  Martin Robinson  <mrobinson@igalia.com>
1029
1030         [GTK][CMake] Ensure that HAVE_GTK_UNIX_PRINTING is defined when appropriate
1031         https://bugs.webkit.org/show_bug.cgi?id=130155
1032
1033         Reviewed by Philippe Normand.
1034
1035         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Add GTK_UNIX_PRINT flags to the build.
1036
1037 2014-03-17  Carlos Garcia Campos  <cgarcia@igalia.com>
1038
1039         [GTK] MiniBrowser fails to load injected bundle lib
1040         https://bugs.webkit.org/show_bug.cgi?id=130332
1041
1042         Reviewed by Anders Carlsson.
1043
1044         This is because WEBKIT_INJECTED_BUNDLE_PATH env var is set too late.
1045
1046         * MiniBrowser/gtk/main.c:
1047         (main): Make sure WEBKIT_INJECTED_BUNDLE_PATH is set before a web
1048         process is spawn.
1049
1050 2014-03-16  Kim Byung Jun  <bj1987.kim@samsung.com>
1051
1052         [EFL] Enable TOUCH_SLIDER macro
1053         https://bugs.webkit.org/show_bug.cgi?id=130185
1054
1055         Reviewed by Gyuyoung Kim.
1056
1057         * Scripts/webkitperl/FeatureList.pm:
1058
1059 2014-03-16  Zan Dobersek  <zdobersek@igalia.com>
1060
1061         [GTK][CMake] Build with -fno-rtti
1062         https://bugs.webkit.org/show_bug.cgi?id=130261
1063
1064         Reviewed by Martin Robinson.
1065
1066         * TestWebKitAPI/CMakeLists.txt: Build TestWebKitAPI with GTEST_HAS_RTTI macro
1067         defined to 0 to prevent typeid use in included GTest headers.
1068
1069 2014-03-16  Brian Burg  <bburg@apple.com>
1070
1071         Web Inspector: vended backend commands file should be generated as part of the build
1072         https://bugs.webkit.org/show_bug.cgi?id=130110
1073
1074         Reviewed by Timothy Hatcher.
1075
1076         * Scripts/build-webkit: build WebInspectorUI after WebCore but before WebKit.
1077
1078 2014-03-16  Diego Pino García  <dpino@igalia.com>
1079
1080         [GTK] Minibrowser: Add shortcuts for reloading page and reloading page ignoring cache
1081         https://bugs.webkit.org/show_bug.cgi?id=128999
1082
1083         Reviewed by Philippe Normand.
1084
1085         * MiniBrowser/gtk/BrowserWindow.c:
1086         (reloadPage):
1087         (reloadPageIgnoringCache):
1088         (browser_window_init):
1089
1090 2014-03-15  Martin Robinson  <mrobinson@igalia.com>
1091
1092         [GTK] Improve ninja detection in webkitdirs.pm
1093         https://bugs.webkit.org/show_bug.cgi?id=129902
1094
1095         Reviewed by Daniel Bates.
1096
1097         * Scripts/webkitdirs.pm:
1098         (canUseNinja): Use which instead of trying to invoke ninja directly. This also allows
1099         us to look for ninja-build as well.
1100
1101 2014-03-14  Maciej Stachowiak  <mjs@apple.com>
1102
1103         Replace "Apple Computer, Inc." with "Apple Inc." in copyright headers
1104         https://bugs.webkit.org/show_bug.cgi?id=130276
1105         <rdar://problem/16266927>
1106
1107         Reviewed by Simon Fraser.
1108
1109         * BuildSlaveSupport/build-launcher-app:
1110         * BuildSlaveSupport/build-launcher-dmg:
1111         * DumpRenderTree/DumpRenderTree.h:
1112         * DumpRenderTree/DumpRenderTreePrefix.h:
1113         * DumpRenderTree/GCController.cpp:
1114         * DumpRenderTree/GCController.h:
1115         * DumpRenderTree/JavaScriptThreading.cpp:
1116         * DumpRenderTree/JavaScriptThreading.h:
1117         * DumpRenderTree/PixelDumpSupport.cpp:
1118         * DumpRenderTree/PixelDumpSupport.h:
1119         * DumpRenderTree/TestNetscapePlugIn/PluginObjectMac.mm:
1120         * DumpRenderTree/TestRunner.cpp:
1121         * DumpRenderTree/TestRunner.h:
1122         * DumpRenderTree/WorkQueue.cpp:
1123         * DumpRenderTree/WorkQueue.h:
1124         * DumpRenderTree/WorkQueueItem.h:
1125         * DumpRenderTree/atk/AccessibilityCallbacks.h:
1126         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
1127         * DumpRenderTree/cairo/PixelDumpSupportCairo.cpp:
1128         * DumpRenderTree/cairo/PixelDumpSupportCairo.h:
1129         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1130         * DumpRenderTree/cg/PixelDumpSupportCG.h:
1131         * DumpRenderTree/efl/EditingCallbacks.cpp:
1132         * DumpRenderTree/efl/EditingCallbacks.h:
1133         * DumpRenderTree/efl/EventSender.cpp:
1134         * DumpRenderTree/efl/EventSender.h:
1135         * DumpRenderTree/efl/GCControllerEfl.cpp:
1136         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
1137         * DumpRenderTree/efl/TestRunnerEfl.cpp:
1138         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1139         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
1140         * DumpRenderTree/gtk/EditingCallbacks.cpp:
1141         * DumpRenderTree/gtk/EditingCallbacks.h:
1142         * DumpRenderTree/gtk/EventSender.cpp:
1143         * DumpRenderTree/gtk/EventSender.h:
1144         * DumpRenderTree/gtk/GCControllerGtk.cpp:
1145         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
1146         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.cpp:
1147         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.h:
1148         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
1149         * DumpRenderTree/gtk/TextInputController.cpp:
1150         * DumpRenderTree/gtk/TextInputController.h:
1151         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/Makefile.PL:
1152         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/lib/IPhoneSimulatorNotification.pm:
1153         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
1154         * DumpRenderTree/mac/AppleScriptController.h:
1155         * DumpRenderTree/mac/AppleScriptController.m:
1156         * DumpRenderTree/mac/CheckedMalloc.cpp:
1157         * DumpRenderTree/mac/CheckedMalloc.h:
1158         * DumpRenderTree/mac/DumpRenderTree.mm:
1159         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
1160         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
1161         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1162         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
1163         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
1164         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1165         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1166         * DumpRenderTree/mac/EditingDelegate.h:
1167         * DumpRenderTree/mac/EditingDelegate.mm:
1168         * DumpRenderTree/mac/EventSendingController.h:
1169         * DumpRenderTree/mac/EventSendingController.mm:
1170         * DumpRenderTree/mac/FrameLoadDelegate.h:
1171         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1172         * DumpRenderTree/mac/GCControllerMac.mm:
1173         * DumpRenderTree/mac/MockWebNotificationProvider.h:
1174         * DumpRenderTree/mac/MockWebNotificationProvider.mm:
1175         * DumpRenderTree/mac/NavigationController.h:
1176         * DumpRenderTree/mac/NavigationController.m:
1177         * DumpRenderTree/mac/ObjCController.h:
1178         * DumpRenderTree/mac/ObjCController.m:
1179         * DumpRenderTree/mac/ObjCPlugin.h:
1180         * DumpRenderTree/mac/ObjCPlugin.m:
1181         * DumpRenderTree/mac/ObjCPluginFunction.h:
1182         * DumpRenderTree/mac/ObjCPluginFunction.m:
1183         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1184         * DumpRenderTree/mac/PolicyDelegate.h:
1185         * DumpRenderTree/mac/PolicyDelegate.mm:
1186         * DumpRenderTree/mac/ResourceLoadDelegate.h:
1187         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1188         * DumpRenderTree/mac/TestRunnerMac.mm:
1189         * DumpRenderTree/mac/TextInputController.h:
1190         * DumpRenderTree/mac/TextInputController.m:
1191         * DumpRenderTree/mac/UIDelegate.h:
1192         * DumpRenderTree/mac/UIDelegate.mm:
1193         * DumpRenderTree/mac/WorkQueueItemMac.mm:
1194         * DumpRenderTree/win/DRTDataObject.cpp:
1195         * DumpRenderTree/win/DRTDataObject.h:
1196         * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
1197         * DumpRenderTree/win/DRTDropSource.cpp:
1198         * DumpRenderTree/win/DRTDropSource.h:
1199         * DumpRenderTree/win/DraggingInfo.h:
1200         * DumpRenderTree/win/DumpRenderTree.cpp:
1201         * DumpRenderTree/win/DumpRenderTreeWin.h:
1202         * DumpRenderTree/win/EditingDelegate.cpp:
1203         * DumpRenderTree/win/EditingDelegate.h:
1204         * DumpRenderTree/win/EventSender.cpp:
1205         * DumpRenderTree/win/EventSender.h:
1206         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1207         * DumpRenderTree/win/FrameLoadDelegate.h:
1208         * DumpRenderTree/win/GCControllerWin.cpp:
1209         * DumpRenderTree/win/HistoryDelegate.cpp:
1210         * DumpRenderTree/win/HistoryDelegate.h:
1211         * DumpRenderTree/win/MD5.cpp:
1212         * DumpRenderTree/win/MD5.h:
1213         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
1214         * DumpRenderTree/win/PolicyDelegate.cpp:
1215         * DumpRenderTree/win/PolicyDelegate.h:
1216         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1217         * DumpRenderTree/win/ResourceLoadDelegate.h:
1218         * DumpRenderTree/win/TestRunnerWin.cpp:
1219         * DumpRenderTree/win/TextInputController.cpp:
1220         * DumpRenderTree/win/TextInputController.h:
1221         * DumpRenderTree/win/TextInputControllerWin.cpp:
1222         * DumpRenderTree/win/UIDelegate.cpp:
1223         * DumpRenderTree/win/UIDelegate.h:
1224         * DumpRenderTree/win/WorkQueueItemWin.cpp:
1225         * EWebLauncher/main.c:
1226         * GtkLauncher/main.c:
1227         * ImageDiff/efl/ImageDiff.cpp:
1228         * ImageDiff/gtk/ImageDiff.cpp:
1229         * MiniBrowser/gtk/main.c:
1230         * Scripts/SpacingHeuristics.pm:
1231         * Scripts/VCSUtils.pm:
1232         * Scripts/bisect-builds:
1233         * Scripts/build-dumprendertree:
1234         * Scripts/build-jsc:
1235         * Scripts/build-webkit:
1236         * Scripts/check-dom-results:
1237         * Scripts/check-for-exit-time-destructors:
1238         * Scripts/check-for-global-initializers:
1239         * Scripts/commit-log-editor:
1240         * Scripts/compare-timing-files:
1241         * Scripts/debug-minibrowser:
1242         * Scripts/debug-safari:
1243         * Scripts/do-file-rename:
1244         * Scripts/find-extra-includes:
1245         * Scripts/generate-coverage-data:
1246         * Scripts/make-script-test-wrappers:
1247         * Scripts/malloc-tree:
1248         * Scripts/old-run-webkit-tests:
1249         * Scripts/parse-malloc-history:
1250         * Scripts/report-include-statistics:
1251         * Scripts/resolve-ChangeLogs:
1252         * Scripts/run-bindings-tests:
1253         * Scripts/run-iexploder-tests:
1254         * Scripts/run-javascriptcore-tests:
1255         * Scripts/run-jsc:
1256         * Scripts/run-launcher:
1257         * Scripts/run-leaks:
1258         * Scripts/run-mangleme-tests:
1259         * Scripts/run-minibrowser:
1260         * Scripts/run-pageloadtest:
1261         * Scripts/run-regexp-tests:
1262         * Scripts/run-safari:
1263         * Scripts/run-sunspider:
1264         * Scripts/run-webkit-app:
1265         * Scripts/sampstat:
1266         * Scripts/set-webkit-configuration:
1267         * Scripts/sort-Xcode-project-file:
1268         * Scripts/sort-export-file:
1269         * Scripts/split-file-by-class:
1270         * Scripts/sunspider-compare-results:
1271         * Scripts/svn-apply:
1272         * Scripts/svn-create-patch:
1273         * Scripts/svn-unapply:
1274         * Scripts/test-webkit-scripts:
1275         * Scripts/update-javascriptcore-test-results:
1276         * Scripts/update-webkit:
1277         * Scripts/update-webkit-auxiliary-libs:
1278         * Scripts/update-webkit-dependency:
1279         * Scripts/update-webkit-localizable-strings:
1280         * Scripts/update-webkit-support-libs:
1281         * Scripts/update-webkit-wincairo-libs:
1282         * Scripts/webkit-build-directory:
1283         * Scripts/webkitdirs.pm:
1284         (installedSafariPath):
1285         * Scripts/webkitperl/VCSUtils_unittest/parseChunkRange.pl:
1286         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
1287         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffFooter.pl:
1288         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl:
1289         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
1290         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
1291         * Scripts/webkitperl/features.pm:
1292         * Scripts/webkitperl/httpd.pm:
1293         * Scripts/webkitpy/bindings/main.py:
1294         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
1295         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
1296         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
1297         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
1298         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp:
1299         * TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp:
1300         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
1301         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1302         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
1303         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.h:
1304         * WebKitTestRunner/PixelDumpSupport.cpp:
1305         * WebKitTestRunner/PixelDumpSupport.h:
1306         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
1307         * WinLauncher/WinLauncher.cpp:
1308         * WinLauncher/WinLauncher.h:
1309         * WinLauncher/stdafx.cpp:
1310         * WinLauncher/stdafx.h:
1311
1312 2014-03-14  Filip Pizlo  <fpizlo@apple.com>
1313
1314         Sometimes we need to be explicit about the SDK when running ranlib on Darwin
1315         https://bugs.webkit.org/show_bug.cgi?id=130265
1316
1317         Reviewed by Michael Saboff.
1318
1319         * Scripts/build-webkit:
1320         * Scripts/copy-webkitlibraries-to-product-directory:
1321
1322 2014-03-14  Landry Breuil  <landry@openbsd.org>
1323
1324         Recognize openbsd/netbsd and am64 archs in Tools/Scripts.
1325         Also allow to set MAKE in the environment.
1326         https://bugs.webkit.org/show_bug.cgi?id=129991
1327
1328         Reviewed by Andreas Kling.
1329
1330         * Scripts/webkitdirs.pm:
1331         (determineArchitecture):
1332         (determineNumberOfCPUs):
1333         (isBSD):
1334         (buildAutotoolsProject):
1335         * Scripts/webkitpy/common/system/platforminfo.py:
1336         (PlatformInfo.__init__):
1337         (PlatformInfo.is_openbsd):
1338         (PlatformInfo):
1339         (PlatformInfo.is_netbsd):
1340         (PlatformInfo._determine_os_name):
1341
1342 2014-03-14  Dean Jackson  <dino@apple.com>
1343
1344         Remove libWebKitSystemInterfaceLion.a
1345         https://bugs.webkit.org/show_bug.cgi?id=130254
1346
1347         Reviewed by Geoffrey Garen and Andreas Kling.
1348
1349         No need to copy the Lion libraries into the build.
1350
1351         * Scripts/copy-webkitlibraries-to-product-directory:
1352
1353 2014-03-14  Jinwoo Song  <jinwoo7.song@samsung.com>
1354
1355         [EFL][MiniBrowser] Revise help messages of command line parameters
1356         https://bugs.webkit.org/show_bug.cgi?id=130222
1357
1358         Reviewed by Csaba Osztrogonác.
1359
1360         Correct the default value description and make help messages to be consistent.
1361
1362         * MiniBrowser/efl/main.c:
1363
1364 2014-03-12  Sergio Villar Senin  <svillar@igalia.com>
1365
1366         Rename DEFINE_STATIC_LOCAL to DEPRECATED_DEFINE_STATIC_LOCAL
1367         https://bugs.webkit.org/show_bug.cgi?id=129612
1368
1369         Reviewed by Darin Adler.
1370
1371         For new code use static NeverDestroyed<T> instead.
1372
1373         * DumpRenderTree/JavaScriptThreading.cpp:
1374         (javaScriptThreadsMutex):
1375         (javaScriptThreads):
1376         * DumpRenderTree/efl/EventSender.cpp:
1377         (touchPointList):
1378         (delayedEventQueue):
1379         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1380         (delegatesWithDelayedWork):
1381         * Scripts/check-for-exit-time-destructors:
1382         * TestWebKitAPI/Tests/WebKit2/SeccompFilters.cpp:
1383         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
1384         (testsMap):
1385
1386 2014-03-13  Sanghyup Lee  <sh53.lee@samsung.com>
1387
1388         [EFL][WK2] Fix compilation warning in Minibrowser
1389         https://bugs.webkit.org/show_bug.cgi?id=130132
1390
1391         Reviewed by Csaba Osztrogonác.
1392
1393         Replace mktemp() with mkstemp() to fix compilation warning in MiniBrowser.
1394
1395         * MiniBrowser/efl/main.c:
1396         (on_download_request):
1397
1398 2014-03-13  Filip Pizlo  <fpizlo@apple.com>
1399
1400         FTL should support IsBlah
1401         https://bugs.webkit.org/show_bug.cgi?id=130202
1402
1403         Reviewed by Geoffrey Garen.
1404
1405         Running existing JSRegress tests with noInline gives us coverage for these
1406         changes. Chances are, this will also give coverage for other interesting things
1407         as well.
1408
1409         * Scripts/run-jsc-stress-tests:
1410
1411 2014-03-12  Brian Burg  <bburg@apple.com>
1412
1413         Web Inspector: Remove unused callId parameter from evaluateInWebInspector
1414         https://bugs.webkit.org/show_bug.cgi?id=129744
1415
1416         Reviewed by Timothy Hatcher.
1417
1418         * DumpRenderTree/TestRunner.cpp:
1419         (evaluateInWebInspectorCallback):
1420         * DumpRenderTree/TestRunner.h:
1421         * DumpRenderTree/efl/TestRunnerEfl.cpp:
1422         (TestRunner::evaluateInWebInspector):
1423         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
1424         (TestRunner::evaluateInWebInspector):
1425         * DumpRenderTree/mac/TestRunnerMac.mm:
1426         (TestRunner::evaluateInWebInspector):
1427         * DumpRenderTree/win/TestRunnerWin.cpp:
1428         (TestRunner::evaluateInWebInspector):
1429         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1430         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1431         (WTR::TestRunner::evaluateInWebInspector):
1432         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1433
1434 2014-03-13  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
1435
1436         [GTK] build-webkit shouldn't show error message when ninja isn't installed
1437         https://bugs.webkit.org/show_bug.cgi?id=130129
1438
1439         Reviewed by Csaba Osztrogonác.
1440
1441         * Scripts/webkitdirs.pm:
1442         (canUseNinja): Redirecting stderr to /dev/null
1443
1444 2014-03-13  Andres Gomez  <agomez@igalia.com>
1445
1446         [GTK] "Tools/jhbuild/jhbuild-wrapper --gtk" build fails even after running Tools/gtk/install-dependencies due to missing proper libxml2 python bindings
1447         https://bugs.webkit.org/show_bug.cgi?id=130092
1448
1449         Reviewed by Csaba Osztrogonác.
1450
1451         Added "python-dev" as dependency for deb based distros. It is
1452         already present for rpm based distros. This dependency will allow
1453         libxml2 to generate its python bindings, needed by gtk-doc.
1454
1455         * gtk/install-dependencies:
1456
1457 2014-03-12  Carlos Garcia Campos  <cgarcia@igalia.com>
1458
1459         Unreviewed. Fix GTK+ cmake build after r165488.
1460
1461         * MiniBrowser/gtk/CMakeLists.txt: Add CMAKE_BINARY_DIR to include dirs.
1462
1463 2014-03-12  Carlos Garcia Campos  <cgarcia@igalia.com>
1464
1465         [GTK][CMAKE] Remove compile warnings about GTK+ deprecated API
1466         https://bugs.webkit.org/show_bug.cgi?id=130014
1467
1468         Reviewed by Martin Robinson.
1469
1470         Include cmake or autotools config header.
1471
1472         * MiniBrowser/gtk/BrowserDownloadsBar.c:
1473         * MiniBrowser/gtk/BrowserSearchBar.c:
1474         * MiniBrowser/gtk/BrowserWindow.c:
1475         * MiniBrowser/gtk/main.c:
1476
1477 2014-03-12  Commit Queue  <commit-queue@webkit.org>
1478
1479         Unreviewed, rolling out r165471.
1480         https://bugs.webkit.org/show_bug.cgi?id=130139
1481
1482         Didn't really fix the issue and broke another bot (Requested
1483         by mrobinson on #webkit).
1484
1485         Reverted changeset:
1486
1487         "[CMake] Newer versions of CMake cannot find older versions of
1488         Freetype"
1489         https://bugs.webkit.org/show_bug.cgi?id=130107
1490         http://trac.webkit.org/changeset/165471
1491
1492 2014-03-11  Filip Pizlo  <fpizlo@apple.com>
1493
1494         It should be possible to build WebKit with FTL on iOS
1495         https://bugs.webkit.org/show_bug.cgi?id=130116
1496
1497         Reviewed by Dan Bernstein.
1498
1499         * Scripts/build-webkit:
1500         * Scripts/copy-webkitlibraries-to-product-directory:
1501
1502 2014-03-12  Brent Fulgham  <bfulgham@apple.com>
1503
1504         [Win] Remove use of QTSDK
1505         https://bugs.webkit.org/show_bug.cgi?id=130049
1506
1507         Reviewed by Darin Adler.
1508
1509         * DumpRenderTree/win/DumpRenderTree.cpp:
1510         (initialize): Remove QuickTime code.
1511         * win/AssembleBuildLogs/AssembleLogs.cmd: Don't grab logs from
1512         building QTMovieWin.
1513
1514 2014-03-12  Martin Robinson  <mrobinson@igalia.com>
1515
1516         [GTK][CMAKE] Too verbose build output
1517         https://bugs.webkit.org/show_bug.cgi?id=130076
1518
1519         Reviewed by Carlos Garcia Campos.
1520
1521         Instead of building with cmake --build which isn't smart about pretty printing and
1522         colors, we build with a script which calls the proper build command.
1523
1524         * Scripts/webkitdirs.pm:
1525         (buildCMakeGeneratedProject): For GTK+ call the script that we generate during
1526         the CMake configuration pass.
1527
1528 2014-03-11  Martin Robinson  <mrobinson@igalia.com>
1529
1530         [CMake] Newer versions of CMake cannot find older versions of Freetype
1531         https://bugs.webkit.org/show_bug.cgi?id=130107
1532
1533         Reviewed by Gustavo Noronha Silva.
1534
1535         * gtk/jhbuildrc: Work around a bug in newer CMakes by giving the FREETYPE_DIR hint
1536         to CMake during jhbuild initialization.
1537
1538 2014-03-12  Zalan Bujtas  <zalan@apple.com>
1539
1540         Add hiDPI support for compositing content in DumpRenderTree/WebKitTestRunner
1541         https://bugs.webkit.org/show_bug.cgi?id=129961
1542
1543         Reviewed by Simon Fraser.
1544
1545         Now scaled content can go through the window capturing mechanism too for compositing content.
1546         AppleMagnifiedMode is redundant.
1547
1548         * DumpRenderTree/mac/DumpRenderTree.mm:
1549         (setDefaultsToConsistentValuesForTesting):
1550         (runTest):
1551         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1552         (createBitmapContextFromWebView):
1553         * WebKitTestRunner/PlatformWebView.h:
1554         * WebKitTestRunner/cg/TestInvocationCG.cpp:
1555         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1556         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1557         (WTR::PlatformWebView::didInitializeClients):
1558         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
1559         (WTR::PlatformWebView::forceWindowFramesChanged):
1560         * WebKitTestRunner/mac/main.mm:
1561         (setDefaultsToConsistentValuesForTesting):
1562
1563 2014-03-12  Anton Obzhirov  <a.obzhirov@samsung.com>
1564
1565         Unreviewed. Add myself as a committer.
1566
1567         * Scripts/webkitpy/common/config/contributors.json:
1568
1569 2014-03-12  Ryuan Choi  <ryuan.choi@samsung.com>
1570
1571         Unreviewed build fix on the EFL port when used lower version of ATK
1572
1573         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1574         (WTR::AccessibilityUIElement::y): Fixed typo.
1575
1576 2014-03-11  Myles C. Maxfield  <mmaxfield@apple.com>
1577
1578         Some images are blank in the rebaseline server UI
1579         https://bugs.webkit.org/show_bug.cgi?id=130104
1580
1581         Reviewed by Tim Horton.
1582
1583         Let the server check for images in the 'retries' directory
1584         if it can't find an image otherwise.
1585
1586         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
1587         (RebaselineHTTPRequestHandler.test_result):
1588
1589 2014-03-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
1590
1591         [GTK][CMake] --update-gtk has no effect
1592         https://bugs.webkit.org/show_bug.cgi?id=130088
1593
1594         Reviewed by Philippe Normand.
1595
1596         * Scripts/webkitdirs.pm:
1597         (buildCMakeProjectOrExit): call update-webkitgtk-libs if --update-gtk has been passed
1598         as an argument.
1599
1600 2014-03-10  Myles C. Maxfield  <mmaxfield@apple.com>
1601
1602         Add "System Font" to the list of whitelisted DRT fonts
1603         https://bugs.webkit.org/show_bug.cgi?id=130046
1604
1605         Reviewed by Darin Adler.
1606
1607         * DumpRenderTree/mac/DumpRenderTree.mm:
1608         (allowedFontFamilySet):
1609         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
1610
1611 2014-03-11  Martin Robinson  <mrobinson@igalia.com>
1612
1613         [GTK] The jhbuild environment should set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_PATH
1614         https://bugs.webkit.org/show_bug.cgi?id=130064
1615
1616         Reviewed by Philippe Normand.
1617
1618         * efl/jhbuildrc: Remove duplicated code.
1619         * gtk/jhbuildrc: Remove duplicated code.
1620         * jhbuild/jhbuildrc_common.py:
1621         (init): Move duplicated code from jhbuildrc's and extend setting CMake environment variables to
1622         GTK+. We always set the CMAKE_LIBRARY_PATH, which should be harmless for EFL 32-bit systems.
1623         and is apparently necessary for GTK+.
1624
1625 2014-03-11  László Langó  <llango.u-szeged@partner.samsung.com>
1626
1627         check-webkit-style failed to complain about missing braces
1628         https://bugs.webkit.org/show_bug.cgi?id=34189
1629
1630         Reviewed by Ryosuke Niwa.
1631
1632         * Scripts/webkitpy/style/checkers/cpp.py:
1633         (check_braces):
1634         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1635         (WebKitStyleTest.test_braces):
1636
1637 2014-03-11  László Langó  <llango.u-szeged@partner.samsung.com>
1638
1639         Remove Qt cruft from style checker.
1640         https://bugs.webkit.org/show_bug.cgi?id=130085
1641
1642         Reviewed by Csaba Osztrogonác.
1643
1644         There is no 'foreach' keyword in c++. That was a Qt feature
1645         added in: http://trac.webkit.org/changeset/46113
1646         Qt was removed from WebKit, so we should remove the checks
1647         of this keyword from check-webkit-style scripts.
1648
1649         * Scripts/webkitpy/style/checkers/cpp.py:
1650         (check_spacing_for_function_call):
1651         (check_spacing):
1652         (check_braces):
1653         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1654         (CppStyleTest.test_mismatching_spaces_in_parens):
1655         (CppStyleTest.test_spacing_for_fncall):
1656         (WebKitStyleTest.test_braces):
1657
1658 2014-03-11  Martin Hodovan  <mhodovan@inf.u-szeged.hu>
1659
1660         [GTK] update-webkitgtk-libs needs itstool
1661         https://bugs.webkit.org/show_bug.cgi?id=130082
1662
1663         After http://trac.webkit.org/changeset/165110 WebKitGTK+ uses gtk-doc 1.20.
1664         itstool is a dependency of building gtk-doc from version 1.19, so it should
1665         be added to Tools/gtk/install-dependencies script, too.
1666
1667         Reviewed by Philippe Normand.
1668
1669         * gtk/install-dependencies:
1670
1671 2014-03-11  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1672
1673         webkitbot rollout ChangeLogs should be nicer
1674         https://bugs.webkit.org/show_bug.cgi?id=122654
1675
1676         Reviewed by Csaba Osztrogonác.
1677
1678         Added bug urls and descriptions of rolled out patches to the rollout changelog
1679         if they are present in the original changelog. Additionally removed the list of
1680         changed files and functions.
1681
1682         * Scripts/webkitpy/common/checkout/changelog.py:
1683         (ChangeLog.update_with_unreviewed_message): Cut off the list of modified files.
1684         * Scripts/webkitpy/common/checkout/checkout.py:
1685         (Checkout._changelog_data_for_revision): Store bug description.
1686         * Scripts/webkitpy/common/checkout/checkout_mock.py:
1687         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1688         (CheckoutTest.test_commit_info_for_revision):
1689         * Scripts/webkitpy/common/checkout/commitinfo.py:
1690         (CommitInfo.bug_description): Added.
1691         (CommitInfo.to_json):
1692         * Scripts/webkitpy/common/checkout/commitinfo_unittest.py:
1693         (CommitInfoTest.test_commit_info_creation):
1694         * Scripts/webkitpy/tool/commands/download.py:
1695         (AbstractRolloutPrepCommand._prepare_state): Store bug ids and descriptions of rolled
1696         out patches for creating rollout changelog.
1697         (CreateRollout._prepare_state): Remove obsolete comments and code, the bug id that
1698         caused the regression is stored in state["bug_blocked"] now.
1699         * Scripts/webkitpy/tool/commands/download_unittest.py:
1700         (test_prepare_rollout):
1701         (test_create_rollout_multiple_revision):
1702         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
1703         (PrepareChangeLogForRevert._message_for_revert): Add bug urls and descriptions of
1704         rolled out patches to the changelog.
1705         (PrepareChangeLogForRevert.run):
1706         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
1707         (UpdateChangeLogsForRevertTest):
1708         (test_message_for_revert):
1709         * Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
1710         (ReopenBugAfterRollout.run):
1711
1712 2014-03-11  Krzysztof Czech  <k.czech@samsung.com>
1713
1714         [ATK] Adjust WKTR/DRT to use new API from ATK 2.11.90
1715         https://bugs.webkit.org/show_bug.cgi?id=130021
1716
1717         Reviewed by Mario Sanchez Prada.
1718
1719         Replace deprecated functions to use new API from ATK 2.11.90.
1720
1721         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1722         (AccessibilityUIElement::x):
1723         (AccessibilityUIElement::y):
1724         (AccessibilityUIElement::width):
1725         (AccessibilityUIElement::height):
1726         (AccessibilityUIElement::clickPointX):
1727         (AccessibilityUIElement::clickPointY):
1728         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1729         (WTR::AccessibilityUIElement::x):
1730         (WTR::AccessibilityUIElement::y):
1731         (WTR::AccessibilityUIElement::width):
1732         (WTR::AccessibilityUIElement::height):
1733         (WTR::AccessibilityUIElement::clickPointX):
1734         (WTR::AccessibilityUIElement::clickPointY):
1735
1736 2014-03-11  Krzysztof Czech  <k.czech@samsung.com>
1737
1738         [ATK] Expose aria-posinset and aria-setsize through object attributes
1739         https://bugs.webkit.org/show_bug.cgi?id=130011
1740
1741         Reviewed by Chris Fleizach.
1742
1743         Added missing implementation of numberAttributeValue both to WKTR and DRT.
1744
1745         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1746         (AccessibilityUIElement::numberAttributeValue):
1747         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1748         (WTR::AccessibilityUIElement::numberAttributeValue):
1749
1750 2014-03-10  Brent Fulgham  <bfulgham@apple.com>
1751
1752         [Win] Unreviewed build fix.
1753
1754         Some bad Windows code was committed at some point that prevents the Apple Windows port
1755         from finding its runtime dependencies reliably.
1756
1757         * win/DLLLauncher/DLLLauncherMain.cpp:
1758         (appleApplicationSupportDirectory): Restored this function.
1759         (modifyPath): Update to use appleApplicationSupportDirectory function.
1760
1761 2014-03-10  Zoltan Horvath  <zoltan@webkit.org>
1762
1763         Let the user define the full address of the performance-site-server for uploading results
1764         https://bugs.webkit.org/show_bug.cgi?id=129819
1765
1766         Reviewed by Ryosuke Niwa.
1767
1768         Currently perftestsrunner.py assumes that the server uses https protocol all the time, which
1769         can be confusing. It's more straightforward, if you need to define explicitly the server's full
1770         address along with the protocol, when you're using this parameter. I added HTTPS as the default
1771         protocol for now, in order to avoid breaking the perf bots.
1772
1773         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1774         (_upload_json):
1775         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1776         (MainTest.test_upload_json):
1777
1778 2014-03-10  Brent Fulgham  <bfulgham@apple.com>
1779
1780         [Win] Pass environment to Pre-Build, Pre-Link, and Post-Build Stages.
1781         https://bugs.webkit.org/show_bug.cgi?id=130023
1782
1783         Reviewed by Dean Jackson.
1784
1785         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj: Add missing
1786         /SAFESEH flag to DLL launcher process.
1787
1788 2014-03-09  Martin Robinson  <mrobinson@igalia.com>
1789
1790         RunGtkWebKitGObjectDOMBindingsAPIBreakTests should be added to the BuildAndTestFactory not the TestFactory
1791         https://bugs.webkit.org/show_bug.cgi?id=129980
1792
1793         Reviewed by Carlos Garcia Campos.
1794
1795         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add RunGtkWebKitGObjectDOMBindingsAPIBreakTests to the correct factory.
1796
1797 2014-03-09  Martin Robinson  <mrobinson@igalia.com>
1798
1799         [GTK] Remove the WebView source-mode WebKit1 test
1800         https://bugs.webkit.org/show_bug.cgi?id=129976
1801
1802         Reviewed by Carlos Garcia Campos.
1803
1804         * TestWebKitAPI/Tests/WebKitGtk/testwebview.c: Remove the source-mode test.
1805
1806 2014-03-08  Martin Robinson  <mrobinson@igalia.com>
1807
1808         Unreviewed build fix for GTKbuild after the switch to CMake
1809
1810         * gtk/common.py:
1811         (is_cmake_build): Like r165284, we need to assume CMake by default, since the
1812         test-only bot doesn't have any build files.
1813
1814 2014-03-07  Martin Robinson  <mrobinson@igalia.com>
1815
1816         [GTK] built-product-archive does not handle GTK+ CMake build
1817         https://bugs.webkit.org/show_bug.cgi?id=129941
1818
1819         * BuildSlaveSupport/built-product-archive:
1820         (archiveBuiltProduct): Fix the build by adding support to built-product-archive for
1821         the CMake build.
1822
1823 2014-03-07  Lorenzo Tilve  <ltilve@igalia.com>
1824
1825         [GTK] Include CMake into install-dependencies script
1826         https://bugs.webkit.org/show_bug.cgi?id=129909
1827
1828         Reviewed by Martin Robinson.
1829
1830         As since r165267 buid-webkit uses CMake by default, the dependency
1831         with 'cmake' package should be introduced.
1832
1833         * gtk/install-dependencies: Ditto.
1834
1835 2014-03-07  Martin Robinson  <mrobinson@igalia.com>
1836
1837         REGRESSION(165267): Broke a webkitpy unit tests
1838         https://bugs.webkit.org/show_bug.cgi?id=129904
1839
1840         Reviewed by Jon Honeycutt.
1841
1842         * Scripts/webkitpy/port/gtk.py: Flip the default test to assume CMake by default.
1843         (GtkPort._is_cmake_build):
1844
1845 2014-03-07  Andres Gomez  <agomez@igalia.com>
1846
1847         [GTK] webkit-patch setup-git-clone fails even after running Tools/gtk/install-dependencies
1848         https://bugs.webkit.org/show_bug.cgi?id=129893
1849
1850         Reviewed by Martin Robinson.
1851
1852         Added "git-svn" as dependency for deb based distros and,
1853         additionally, "subversion" for rpm based distros.
1854
1855         * gtk/install-dependencies:
1856
1857 2014-03-07  Roger Fong  <roger_fong@apple.com>
1858
1859         Remove dummy setSystemWebGLLoadPolicy client method.
1860         https://bugs.webkit.org/show_bug.cgi?id=129873.
1861
1862         Reviewed by Dean Jackson.
1863
1864         * WebKitTestRunner/TestController.cpp:
1865         (WTR::TestController::createWebViewWithOptions):
1866
1867 2014-03-07  Mark Hahnenberg  <mhahnenberg@apple.com>
1868
1869         run-jsc-stress-tests doesn't eagerly report test failures when using the shell runner
1870         https://bugs.webkit.org/show_bug.cgi?id=129886
1871
1872         Reviewed by Mark Lam.
1873
1874         * Scripts/jsc-stress-test-helpers/shell-runner.sh: Added a "verbose" mode to the shell runner.
1875         If we're in verbose mode, then we don't redirect any output when running each test. If we're not
1876         in verbose mode then we redirect stdout to /dev/null and allow any stderr output through.
1877         * Scripts/run-jsc-stress-tests: Redirect any sort of error output to stderr so that it will
1878         make it through when in non-verbose mode.
1879
1880 2014-03-07  Martin Robinson  <mrobinson@igalia.com>
1881
1882         [GTK] buid-webkit should use CMake by default
1883         https://bugs.webkit.org/show_bug.cgi?id=129855
1884
1885         Reviewed by Carlos Garcia Campos.
1886
1887         Make the CMake build the default GTK+ build when using build-webkit. This will
1888         ensure that all bots are using CMake. We do this by swapping --gtk and --gtkcmake,
1889         so that we have --gtk and --gtkautotools.
1890
1891         * Scripts/webkitdirs.pm: Swap --gtkcmake/--gtk for --gtk/--gtkautotools.
1892         * Scripts/webkitpy/port/gtk.py: Ditto.
1893
1894 2014-03-06  Martin Robinson  <mrobinson@igalia.com>
1895
1896         [CMake] [GTK] Build with ninja when it is available
1897         https://bugs.webkit.org/show_bug.cgi?id=129805
1898
1899         Reviewed by Philippe Normand.
1900
1901         * Scripts/webkitdirs.pm:
1902         (canUseNinja): Added this helper which tries to execute Ninja, in an effort to determine
1903         if it's available on the system.
1904         (cmakeGeneratedBuildfile): Return the path to the generated build file. Only Unix support ATM.
1905         (generateBuildSystemFromCMakeProject): For GTK+ compile with Ninja when possible.
1906
1907 2014-03-06  Filip Pizlo  <fpizlo@apple.com>
1908
1909         If the FTL is build-time enabled then it should be run-time enabled.
1910
1911         Rubber stamped by Geoffrey Garen.
1912
1913         * Scripts/run-jsc-stress-tests:
1914
1915 2014-03-06  Mark Hahnenberg  <mhahnenberg@apple.com>
1916
1917         detectFailures in run-jsc-stress-tests can report everything was ok if too many tests fail
1918         https://bugs.webkit.org/show_bug.cgi?id=129837
1919
1920         Reviewed by Michael Saboff.
1921
1922         ls test_fail_* can fail if there are too many files that match. We then swallow that error, which makes everything seem ok.
1923         The fix is to use find instead of ls like we do in shell-runner.sh.
1924
1925         * Scripts/run-jsc-stress-tests:
1926
1927 2014-03-06  Joseph Pecoraro  <pecoraro@apple.com>
1928
1929         filter-build-webkit should not strip .o
1930         https://bugs.webkit.org/show_bug.cgi?id=129614
1931
1932         Reviewed by Dean Jackson.
1933
1934         This makes it much easier to jump from the failing output at
1935         the end back up to the compile errors earlier in the output.
1936
1937         * Scripts/filter-build-webkit:
1938
1939 2014-03-06  Anders Carlsson  <andersca@apple.com>
1940
1941         Build WebKit2 before building WebKit
1942         https://bugs.webkit.org/show_bug.cgi?id=129831
1943         <rdar://problem/15920020>
1944
1945         Reviewed by Dan Bernstein.
1946
1947         * Scripts/build-webkit:
1948         Always build WebKit2 and make sure to build it before WebKit when building on Mac.
1949
1950 2014-03-06  ChangSeok Oh  <changseok.oh@collabora.com>
1951
1952         make-3.82 fails to build on ARM/Linux
1953         https://bugs.webkit.org/show_bug.cgi?id=107926
1954
1955         Reviewed by Martin Robinson.
1956
1957         Some ARM/Linux systems don't support PAGE_SIZE macro so that it causes a build failure.
1958         The related bug reporting is here. https://lists.debian.org/debian-kernel/2014/02/msg00274.html
1959         To avoid this, I propose to use sysconf(_SC_PAGESIZE) instead of PAGE_SIZE
1960         where it is not defined. See more details, http://linux.die.net/man/2/getpagesize
1961
1962         * gtk/patches/make-3.82-arg-list-length.patch:
1963
1964 2014-03-06  Carlos Garcia Campos  <cgarcia@igalia.com>
1965
1966         [GTK] Close the page when the view is disposed instead of when finalized
1967         https://bugs.webkit.org/show_bug.cgi?id=129783
1968
1969         Reviewed by Sergio Villar Senin.
1970
1971         Add test case but disabled for now because it's affetected by bug #129684.
1972
1973         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
1974         (testProcessPerWebView):
1975
1976 2014-03-06  Carlos Garcia Campos  <cgarcia@igalia.com>
1977
1978         [GTK] MiniBrowser crashes when opening several urls passed as command line options
1979         https://bugs.webkit.org/show_bug.cgi?id=129738
1980
1981         Reviewed by Sergio Villar Senin.
1982
1983         The problem is that we are calling g_object_unref() for the
1984         WebKitWebSettings everytime we set it to a WebKitWebView, but the
1985         view only increases the reference counter when the settings is not
1986         the same it currently has. We should release our reference once.
1987
1988         * MiniBrowser/gtk/main.c:
1989         (createBrowserWindow):
1990         (main):
1991
1992 2014-03-05  Martin Robinson  <mrobinson@igalia.com>
1993
1994         [GTK][CMake] Tarball is created with wrong tarball paths
1995         https://bugs.webkit.org/show_bug.cgi?id=129496
1996
1997         Reviewed by Daniel Bates.
1998
1999         * gtk/make-dist.py:
2000         (Manifest.__init__): I inadvertently inverted the logic of these checks when
2001         landing the original patch with some suggestions from the reviewer. With the
2002         checks corrected, the tarball path is constructed properly.
2003
2004 2014-03-05  Jae Hyun Park  <jaepark@webkit.org>
2005
2006         Unreviewed. Update my email in contributors.json
2007
2008         * Scripts/webkitpy/common/config/contributors.json:
2009
2010 2014-03-05  Dean Jackson  <dino@apple.com>
2011
2012         [WebGL] Use WKSI to see what the system policy for WebGL is
2013         https://bugs.webkit.org/show_bug.cgi?id=129722
2014         <rdar://problem/15790542>
2015
2016         Reviewed by Tim Horton.
2017
2018         Dummy entry for setSystemWebGLLoadPolicy.
2019
2020         * WebKitTestRunner/TestController.cpp:
2021         (WTR::TestController::createWebViewWithOptions):
2022
2023 2014-03-03  Martin Robinson  <mrobinson@igalia.com>
2024
2025         [GTK][CMake] Generate documentation for the DOM bindings
2026         https://bugs.webkit.org/show_bug.cgi?id=126211
2027
2028         Reviewed by Carlos Garcia Campos.
2029
2030         * gtk/GNUmakefile.am: No longer generation sections and SGML files in the makefile.
2031         * gtk/generate-gtkdoc: Call the code from webkitdom.py to generate sections and SGML files.
2032         * gtk/generate-webkitdom-doc-files: Removed.
2033         * gtk/webkitdom.py: Moved WebKit GObject DOM bindings doc generation code here, so
2034         that it can be called by generate-gtkdoc.
2035
2036 2014-03-05  Martin Robinson  <mrobinson@igalia.com>
2037
2038         [GTK][CMake] build-webkit should rerun cmake if the Makefile is missing
2039         https://bugs.webkit.org/show_bug.cgi?id=129380
2040
2041         Reviewed by Philippe Normand.
2042
2043         * Scripts/webkitdirs.pm:
2044         (generateBuildSystemFromCMakeProject): Check for the existence of the Makefile before
2045         skipping CMake execution.
2046
2047 2014-03-05  Martin Robinson  <mrobinson@igalia.com>
2048
2049         [GTK] The jhbuild environment should have the latest stable release of gtk-doc
2050         https://bugs.webkit.org/show_bug.cgi?id=129651
2051
2052         Reviewed by Philippe Normand.
2053
2054         * gtk/jhbuild.modules: Add gtk-doc to the list of modules.
2055
2056 2014-03-05  Martin Robinson  <mrobinson@igalia.com>
2057
2058         [GTK] Give the WebKit GObject DOM bindings API break detection it's own buildbot bubble
2059         https://bugs.webkit.org/show_bug.cgi?id=129637
2060
2061         Reviewed by Carlos Garcia Campos.
2062
2063         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2064         (RunGtkWebKitGObjectDOMBindingsAPIBreakTests): Added this test runner.
2065         (RunGtkWebKitGObjectDOMBindingsAPIBreakTests.commandComplete): Run the breakage test command and scan the output.
2066         (RunGtkWebKitGObjectDOMBindingsAPIBreakTests.evaluateCommand): Return failure if there is missing API (an API break).
2067         New API typically just requires a rebaseline and isn't necessarily a faiulre.
2068         (TestFactory.__init__): Add the test for GTK+.
2069         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Add a unit test for the new bubble.
2070
2071 2014-03-05  Krzysztof Czech  <k.czech@samsung.com>
2072
2073         [ATK] Expose missing functionalities of AtkTableCell to AT
2074         https://bugs.webkit.org/show_bug.cgi?id=129492
2075
2076         Reviewed by Mario Sanchez Prada.
2077
2078         Reducing some code by using new API of AtkTableCell.
2079
2080         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2081         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2082
2083 2014-03-04  Alex Christensen  <achristensen@webkit.org>
2084
2085         Preparing to run layout tests on Wincairo.
2086         https://bugs.webkit.org/show_bug.cgi?id=129709
2087
2088         Reviewed by Brent Fulgham.
2089
2090         * Scripts/webkitdirs.pm:
2091         (setPathForRunningWebKitApp):
2092         Add GStreamer directory for WinCairo running layout tests.
2093         * win/DLLLauncher/DLLLauncherMain.cpp:
2094         (modifyPath):
2095         Added the WinCairo bin32 or bin64 directory for running WinLauncher.
2096
2097 2014-03-04  Martin Robinson  <mrobinson@igalia.com>
2098
2099         [GTK] Simplify the GObject DOM bindings API break check into one step
2100         https://bugs.webkit.org/show_bug.cgi?id=129571
2101
2102         Reviewed by Carlos Garcia Campos.
2103
2104         * GNUmakefile.am: Add the API break check to 'make check.'
2105         * gtk/check-for-webkitdom-api-breaks: Added. A combination of the two removed scripts.
2106         * gtk/check-gdom-symbols: Removed.
2107         * gtk/webkitdom.py: Added.
2108         (header_name_list_from_gtkdoc_config_file): Gets the names of all headers from the gtkdoc config file.
2109         (get_all_webkitdom_symbol_files): Find the symbol files from the names.
2110
2111 2014-03-03  Simon Fraser  <simon.fraser@apple.com>
2112
2113         Add Jeremy Jones to the contributors list as a contributor.
2114
2115         * Scripts/webkitpy/common/config/contributors.json:
2116
2117 2014-03-03  Adenilson Cavalcanti  <cavalcantii@gmail.com>
2118
2119         Unreviewed. Update contact email.
2120         https://bugs.webkit.org/show_bug.cgi?id=129610
2121
2122         * Scripts/webkitpy/common/config/contributors.json:
2123
2124 2014-03-02  Brian Burg  <bburg@apple.com>
2125
2126         Web Inspector model tests load wrong inspector page under WebKitTestRunner
2127         https://bugs.webkit.org/show_bug.cgi?id=129460
2128
2129         Reviewed by Dan Bernstein.
2130
2131         Don't unconditionally open the inspector before running an inspector test.
2132         Instead, the test should request that the inspector open when it's ready.
2133
2134         This change was lost during a rebase, but is the same change made to
2135         DumpRenderTree.
2136
2137         * WebKitTestRunner/TestInvocation.cpp:
2138         (WTR::TestInvocation::invoke):
2139
2140 2014-03-02  Darin Adler  <darin@apple.com>
2141
2142         Split TextIteratorBehavior into a separate header
2143         https://bugs.webkit.org/show_bug.cgi?id=129578
2144
2145         Reviewed by Sam Weinig.
2146
2147         * Scripts/sort-export-file: Added special cases to the script so you can just paste link errors
2148         from WebKit in and the script will add them in as unconditional exports. This makes the "add"
2149         task easy, but the remove is still a bit of a pain.
2150
2151 2014-03-02  Darin Adler  <darin@apple.com>
2152
2153         Sort Mac platform export files so they merge better
2154         https://bugs.webkit.org/show_bug.cgi?id=129581
2155
2156         Reviewed by Sam Weinig.
2157
2158         * Scripts/sort-export-file: Added. Quickly whipped together script that sorts
2159         Mac export files in a "canonical" order for this project.
2160
2161 2014-02-28  Zalan Bujtas  <zalan@apple.com>
2162
2163         Add hiDPI support to DumpRenderTree/WebKitTestRunner without the need of reloading the test case.
2164         https://bugs.webkit.org/show_bug.cgi?id=129438
2165
2166         Reviewed by Simon Fraser.
2167
2168         'hidpi-' prefixed test cases now trigger 2x scale factor on the testing
2169         offscreen window. It makes testing subpixel rendering and positioning possible.
2170
2171         Both the offscreen window's and WebKit's scaling are set accordingly.
2172
2173         * DumpRenderTree/mac/DumpRenderTree.mm:
2174         (createWebViewAndOffscreenWindow): cleanup
2175         (destroyWebViewAndOffscreenWindow): cleanup
2176         (dumpRenderTree):
2177         (changeWindowScaleIfNeeded):
2178         (runTest):
2179         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
2180         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
2181         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]): cleanup
2182         * WebKitTestRunner/PlatformWebView.h:
2183         * WebKitTestRunner/TestInvocation.cpp:
2184         (WTR::changeWindowScaleIfNeeded):
2185         (WTR::TestInvocation::invoke):
2186         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2187         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
2188         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2189         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
2190         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2191         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
2192         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2193         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
2194
2195 2014-02-28  Anders Carlsson  <andersca@apple.com>
2196
2197         Remove logging.
2198
2199         Reviewed by Dan Bernstein.
2200
2201         * MiniBrowser/mac/WK2BrowserWindowController.m:
2202         (-[WK2BrowserWindowController browsingContextController:decidePolicyForNavigationAction:decisionHandler:]):
2203
2204 2014-02-28  Daniel Bates  <dabates@apple.com>
2205
2206         [iOS] DumpRenderTree Perl Support may build against wrong SDK and toolchain
2207         https://bugs.webkit.org/show_bug.cgi?id=129163
2208
2209         Reviewed by David Kilzer.
2210
2211         Fixes an issue where DumpRenderTree Perl Support may build with the specified
2212         iOS Simulator SDK and toolchain instead of using the OS X SDK and toolchain.
2213         This issue manifests itself in a build failure when building the IPhoneSimulatorNotification
2214         bundle.
2215
2216         Currently we build DumpRenderTree Perl Support with respect to the variable SDKROOT,
2217         which is specified either explicitly when building with MAKE(1) or implicitly by
2218         build-{dumprendertree, webkit}. Instead we should always build Perl Support using
2219         the OS X SDK and toolchain since the built products are only applicable to OS X.
2220
2221         * DumpRenderTree/ios/PerlSupport/Makefile:
2222
2223 2014-02-28  Commit Queue  <commit-queue@webkit.org>
2224
2225         Unreviewed, rolling out r164859.
2226         http://trac.webkit.org/changeset/164859
2227         https://bugs.webkit.org/show_bug.cgi?id=129483
2228
2229         caused WK1 crashes (DumpRenderTree) (Requested by zalan on
2230         #webkit).
2231
2232         * DumpRenderTree/mac/DumpRenderTree.mm:
2233         (createWebViewAndOffscreenWindow):
2234         (dumpRenderTree):
2235         (runTest):
2236         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
2237         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
2238         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
2239         * WebKitTestRunner/PlatformWebView.h:
2240         * WebKitTestRunner/TestInvocation.cpp:
2241         (WTR::TestInvocation::invoke):
2242         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2243         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2244         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2245         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2246         (-[WebKitTestRunnerWindow frameRespectingFakeOrigin]):
2247
2248 2014-02-28  Zalan Bujtas  <zalan@apple.com>
2249
2250         Add hiDPI support to DumpRenderTree/WebKitTestRunner without the need of reloading the test case.
2251         https://bugs.webkit.org/show_bug.cgi?id=129438
2252
2253         Reviewed by Simon Fraser.
2254
2255         'hidpi-' prefixed test cases now trigger 2x scale factor on the testing
2256         offscreen window. It makes testing subpixel rendering and positioning possible.
2257
2258         Both the offscreen window's and WebKit's scaling are set accordingly.
2259
2260         * DumpRenderTree/mac/DumpRenderTree.mm:
2261         (createWebViewAndOffscreenWindow): unrelated cleanup.
2262         (destroyWebViewAndOffscreenWindow): unrelated cleanup.
2263         (dumpRenderTree):
2264         (changeOffscreenWindowScaleIfNeeded):
2265         (runTest):
2266         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
2267         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
2268         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]): cleanup.
2269         * WebKitTestRunner/PlatformWebView.h:
2270         * WebKitTestRunner/TestInvocation.cpp:
2271         (WTR::changeOffscreenWindowScaleIfNeeded):
2272         (WTR::TestInvocation::invoke):
2273         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2274         (WTR::PlatformWebView::changeOffscreenWindowScaleIfNeeded):
2275
2276 2014-02-27  Brian Burg  <bburg@apple.com>
2277
2278         Web Inspector: model tests should use a special Test.html inspector page
2279         https://bugs.webkit.org/show_bug.cgi?id=129190
2280
2281         Reviewed by Timothy Hatcher.
2282
2283         Remove code that immediately opens the Web Inspector based on the file path of the test.
2284         Instead, the test page should request that the inspector open inside its `test()` method.
2285
2286         This change is necessary because otherwise, the inspector would be opened too early for
2287         InspectorController::isUnderTest to get set in time, so the normal Web Inspector page
2288         will get loaded instead of the minimal test page.
2289
2290         * DumpRenderTree/efl/DumpRenderTree.cpp:
2291         (createTestRunner):
2292         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2293         (runTest):
2294         * DumpRenderTree/mac/DumpRenderTree.mm:
2295         (runTest):
2296         * DumpRenderTree/win/DumpRenderTree.cpp:
2297         (runTest):
2298
2299 2014-02-27  Laszlo Vidacs  <lvidacs.u-szeged@partner.samsung.com>
2300
2301         check-webkit-style indentation false alarm in WebKit/win/WebNodeHighlight.cpp
2302         https://bugs.webkit.org/show_bug.cgi?id=127076
2303
2304         Reviewed by Anders Carlsson.
2305
2306         Avoid match for :: as start of a member initialization list. Modify expression to match
2307         after a colon either non-colon character or end of line.
2308
2309         * Scripts/webkitpy/style/checkers/cpp.py:
2310         (check_member_initialization_list):
2311         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2312         (WebKitStyleTest.test_member_initialization_list):
2313
2314 2014-02-27  Renata Hodovan  <rhodovan.u-szeged@partner.samsung.com>
2315
2316         Unreviewed. Update my email addresses in contributors.json.
2317
2318         * Scripts/webkitpy/common/config/contributors.json:
2319
2320 2014-02-27  Alberto Garcia  <berto@igalia.com>
2321
2322         [gtk-doc] UnicodeEncodeError: 'ascii' codec can't encode character
2323         https://bugs.webkit.org/show_bug.cgi?id=128927
2324
2325         Reviewed by Philippe Normand.
2326
2327         Encode manually the data for sys.{stdout,stderr}.write.
2328
2329         * gtk/gtkdoc.py:
2330         (GTKDoc._run_command):
2331
2332 2014-02-27  Andres Gomez  <agomez@igalia.com>
2333
2334         Unreviewed. Add myself to watchlists
2335
2336         * Scripts/webkitpy/common/config/watchlist: Add myself to
2337         watchlists.
2338
2339 2014-02-27  Andres Gomez  <agomez@igalia.com>
2340
2341         Unreviewed, rolling out r164790.
2342         http://trac.webkit.org/changeset/164790
2343
2344         Revert r164790 because of erroneous commit log
2345
2346         * Scripts/webkitpy/common/config/watchlist:
2347
2348 2014-02-27  Krzysztof Czech  <k.czech@samsung.com>
2349
2350         [ATK] Utilize AtkTableCell to expose directly AccessibilityTableCell to AT
2351         https://bugs.webkit.org/show_bug.cgi?id=129250
2352
2353         Reviewed by Mario Sanchez Prada.
2354
2355         Changing version of ATK to 2.11.90, because it introduces AtkTableCell interface.
2356         Implementing methods so that we could test column/row headers represented as an array of cells.
2357
2358         * DumpRenderTree/AccessibilityUIElement.cpp:
2359         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2360         (AccessibilityUIElement::columnHeaders):
2361         (AccessibilityUIElement::rowHeaders):
2362         * DumpRenderTree/win/AccessibilityUIElementWin.cpp: Adding empty stubs, to not break compilation.
2363         (AccessibilityUIElement::columnHeaders):
2364         (AccessibilityUIElement::rowHeaders):
2365         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2366         (WTR::AccessibilityUIElement::rowHeaders):
2367         (WTR::AccessibilityUIElement::columnHeaders):
2368         * efl/jhbuild.modules:
2369         * gtk/jhbuild.modules:
2370
2371 2014-02-27  Andres Gomez  <agomez@igalia.com>
2372
2373         Unreviewed. Add myself to watchlists
2374
2375         * Scripts/webkitpy/common/config/watchlist: Add myself to
2376         watchlists.
2377
2378 2014-02-27  Andres Gomez  <agomez@igalia.com>
2379
2380         Unreviewed. Add myself as a committer.
2381
2382         * Scripts/webkitpy/common/config/contributors.json:
2383
2384 2014-02-27  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2385
2386         Unreviewed. Add Víctor Jáquez and myself to watchlists
2387
2388         * Scripts/webkitpy/common/config/watchlist: Add Víctor Jáquez and
2389         myself to watchlists.
2390
2391 2014-02-26  Julien Brianceau  <jbriance@cisco.com>
2392
2393         Unreviewed. Add myself as a committer.
2394
2395         * Scripts/webkitpy/common/config/contributors.json:
2396
2397 2014-02-26  Laszlo Vidacs  <lvidacs.u-szeged@partner.samsung.com>
2398
2399         Unreviewed. Moved myself to the list of committers.
2400
2401         * Scripts/webkitpy/common/config/contributors.json:
2402
2403 2014-02-24  Martin Robinson  <mrobinson@igalia.com>
2404
2405         [GTK] Reduplicate common.top_level_path in scripts
2406         https://bugs.webkit.org/show_bug.cgi?id=129291
2407
2408         Reviewed by Philippe Normand.
2409
2410         Duplicate common.top_level_path and avoid polluting many scripts with awkward system
2411         path manipulation and weird dependencies on the jhbuild infrastructure.
2412
2413         * Scripts/run-gtk-tests: Use common again.
2414         (TestRunner._setup_testing_environment): Ditto.
2415         * gtk/check-gdom-symbols: Ditto.
2416         * gtk/common.py:
2417         (top_level_path): Re-add top_level_path..
2418         (get_build_path): Use the builtin top_level_path again.
2419         * gtk/find-make-dist-errors: Use common again.
2420         (get_missing_headers): Ditto.
2421         * gtk/generate-inspector-gresource-manifest.py: Ditto.
2422
2423 2014-02-26  Mark Hahnenberg  <mhahnenberg@apple.com>
2424
2425         runscript: line 42: /bin/ls: Argument list too long
2426         https://bugs.webkit.org/show_bug.cgi?id=129376
2427
2428         Reviewed by Michael Saboff.
2429
2430         The "test_script_*" can expand to more things than can be passed as arguments on the command line.
2431         We should use find instead, which generates the list of files rather than expanding them all on
2432         the command line and spitting them back out.
2433
2434         * Scripts/jsc-stress-test-helpers/shell-runner.sh:
2435
2436 2014-02-26  Martin Robinson  <mrobinson@igalia.com>
2437
2438         ENABLE_PROMISES is improperly specified as ENABLE_PROMISE in Features.pm
2439         https://bugs.webkit.org/show_bug.cgi?id=129377
2440
2441         Reviewed by Csaba Osztrogonác.
2442
2443         * Scripts/webkitperl/FeatureList.pm: Properly specify the promises feature as ENABLE_PROMISES.
2444
2445 2014-02-26  Manuel Rego Casasnovas  <rego@igalia.com>
2446
2447         [GTK] Re-enable gtk-doc in EWS
2448         https://bugs.webkit.org/show_bug.cgi?id=128369
2449
2450         Reviewed by Carlos Garcia Campos.
2451
2452         Enable again gtk-doc generation in EWS once bug #128417 has been fixed.
2453
2454         * Scripts/webkitpy/common/config/ports.py:
2455         (GtkPort.build_webkit_command): Add --disable-gtk-doc arg.
2456         (GtkWK2Port.build_webkit_command): Ditto.
2457         * Scripts/webkitpy/common/config/ports_unittest.py:
2458         (DeprecatedPortTest.test_gtk_port): Ditto.
2459         (DeprecatedPortTest.test_gtk_wk2_port): Ditto.
2460
2461 2014-02-26  Martin Robinson  <mrobinson@igalia.com>
2462
2463         [GTK] generate-gtkdoc can fail with WebKit1 or WebKit2 only builds
2464         https://bugs.webkit.org/show_bug.cgi?id=129319
2465
2466         Reviewed by Carlos Garcia Campos.
2467
2468         * gtk/generate-gtkdoc:
2469         (get_generator_for_config): Properly handle the situation where the pkgconfig file is missing.
2470
2471 2014-02-25  Mihai Maerean  <mmaerean@adobe.com>
2472
2473         Unreviewed. Add myself as a committer.
2474
2475         * Scripts/webkitpy/common/config/contributors.json:
2476
2477 2014-02-25  Sergio Villar Senin  <svillar@igalia.com>
2478
2479         [CSS Grid Layout] Add ENABLE flag
2480         https://bugs.webkit.org/show_bug.cgi?id=129153
2481
2482         Reviewed by Simon Fraser.
2483
2484         Added ENABLE_CSS_GRID_LAYOUT feature flag. It's on by default for
2485         all ports for developer builds.
2486
2487         * Scripts/webkitperl/FeatureList.pm:
2488
2489 2014-02-25  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
2490
2491         Added myself as a committer.
2492
2493         Unreviewed.
2494
2495         * Scripts/webkitpy/common/config/contributors.json:
2496
2497 2014-02-25  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
2498
2499         Unreviewed. Moved myself to the list of committers.
2500
2501         * Scripts/webkitpy/common/config/contributors.json:
2502
2503 2014-02-25  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
2504
2505         Move myself to the committers list.
2506
2507         Unreviewed.
2508
2509         * Scripts/webkitpy/common/config/contributors.json:
2510
2511 2014-02-25  László Langó  <llango.u-szeged@partner.samsung.com>
2512
2513         Unreviewed. Add myself as a committer.
2514
2515         * Scripts/webkitpy/common/config/contributors.json:
2516
2517 2014-02-25  Commit Queue  <commit-queue@webkit.org>
2518
2519         Unreviewed, rolling out r164639.
2520         http://trac.webkit.org/changeset/164639
2521         https://bugs.webkit.org/show_bug.cgi?id=129302
2522
2523         gtk-doc still have problems in EWS (Requested by rego on
2524         #webkit).
2525
2526         * Scripts/webkitpy/common/config/ports.py:
2527         (GtkPort.build_webkit_command):
2528         (GtkWK2Port.build_webkit_command):
2529         * Scripts/webkitpy/common/config/ports_unittest.py:
2530         (DeprecatedPortTest.test_gtk_port):
2531         (DeprecatedPortTest.test_gtk_wk2_port):
2532
2533 2014-02-25  Manuel Rego Casasnovas  <rego@igalia.com>
2534
2535         [GTK] Re-enable gtk-doc in EWS
2536         https://bugs.webkit.org/show_bug.cgi?id=128369
2537
2538         Reviewed by Carlos Garcia Campos.
2539
2540         Enable again gtk-doc generation in EWS once bug #128417 has been fixed.
2541
2542         * Scripts/webkitpy/common/config/ports.py:
2543         (GtkPort.build_webkit_command): Add --disable-gtk-doc arg.
2544         (GtkWK2Port.build_webkit_command): Ditto.
2545         * Scripts/webkitpy/common/config/ports_unittest.py:
2546         (DeprecatedPortTest.test_gtk_port): Ditto.
2547         (DeprecatedPortTest.test_gtk_wk2_port): Ditto.
2548
2549 2014-02-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2550
2551         [GTK] Mark view source mode methods as deprecated
2552         https://bugs.webkit.org/show_bug.cgi?id=128920
2553
2554         Reviewed by Martin Robinson.
2555
2556         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2557         (beforeAll): Remove view mode test.
2558
2559 2014-02-24  Martin Robinson  <mrobinson@igalia.com>
2560
2561         [GTK] generate-gtkdoc should not generate documentation for source files for unbuilt source files
2562         https://bugs.webkit.org/show_bug.cgi?id=128417
2563
2564         Reviewed by Carlos Garcia Campos.
2565
2566         * gtk/GNUmakefile.am: Make the documentation process depend on the configuration files.
2567         * gtk/generate-gtkdoc: Switch from using hard-coded configurations to reading them from
2568         a makefile. This allows accepting a header list from the build system, which can be used
2569         to dynamically build a list of ignored files. We can ignore any source file that doesn't
2570         have a corresponding header file on the header list.
2571         * gtk/gtkdoc.py: Now accept a headers parameter, which can be used instead of passing just
2572         source directories to gtkdoc-scan.
2573
2574 2014-02-24  Anders Carlsson  <andersca@apple.com>
2575
2576         Add a DefaultVisitedLinkProvider and route visited link actions through it
2577         https://bugs.webkit.org/show_bug.cgi?id=129285
2578
2579         Reviewed by Dan Bernstein.
2580
2581         * MiniBrowser/mac/AppDelegate.m:
2582         (-[BrowserAppDelegate applicationDidFinishLaunching:]):
2583         Set a shared history so we'll get visited link tracking.
2584
2585         * MiniBrowser/mac/WK1BrowserWindowController.m:
2586         (-[WK1BrowserWindowController awakeFromNib]):
2587         Set a group name.
2588
2589 2014-02-24  Dan Bernstein  <mitz@apple.com>
2590
2591         iOS build fix after r164577.
2592
2593         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2594         (AccessibilityUIElement::selectedChildrenCount):
2595         (AccessibilityUIElement::selectedChildAtIndex):
2596
2597 2014-02-24  David Kilzer  <ddkilzer@apple.com>
2598
2599         [ASan] Remove methods from ignore list that no longer cause crashes
2600         <http://webkit.org/b/129257>
2601
2602         Reviewed by Anders Carlsson.
2603
2604         * asan/webkit-asan-ignore.txt: Remove old methods.
2605
2606 2014-02-24  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
2607
2608         Extract common parts from jhbuildrc files.
2609         https://bugs.webkit.org/show_bug.cgi?id=125986
2610
2611         Reviewed by Csaba Osztrogonác.
2612
2613         Co-authored with Peter Szanka <h868064@stud.u-szeged.hu>.
2614
2615         * Scripts/run-gtk-tests:
2616         (TestRunner._setup_testing_environment):
2617         * efl/common.py: Removed.
2618         * efl/jhbuildrc:
2619         * gtk/check-gdom-symbols:
2620         * gtk/common.py:
2621         (binary_build_path):
2622         (get_build_path):
2623         * gtk/find-make-dist-errors:
2624         (get_missing_headers):
2625         * gtk/generate-gtkdoc:
2626         (get_webkit2_options):
2627         (get_webkit1_options.src_path):
2628         (get_webkit1_options):
2629         (get_webkitdom_options.src_path):
2630         (get_webkitdom_options):
2631         * gtk/generate-inspector-gresource-manifest.py:
2632         * gtk/jhbuildrc:
2633         * jhbuild/jhbuildrc_common.py: Added.
2634         (script_path):
2635         (top_level_path):
2636         (init):
2637
2638 2014-02-24  Diego Pino Garcia  <dpino@igalia.com>
2639
2640         Unreviewed. Fix code indentation and spacing.
2641
2642         * Scripts/webkitpy/style/checkers/js.py:
2643         (SingleQuoteChecker.check):
2644
2645 2014-02-24  Krzysztof Czech  <k.czech@samsung.com>
2646
2647         [ATK] Wrong selected element at a given index in a list box.
2648         https://bugs.webkit.org/show_bug.cgi?id=129039
2649
2650         Reviewed by Chris Fleizach.
2651
2652         Added missing implementation and proposed some new function for testing selection
2653         in a list boxes.
2654
2655         * DumpRenderTree/AccessibilityUIElement.cpp:
2656         (setSelectedChildAtIndexCallback):
2657         (removeSelectionAtIndexCallback):
2658         (AccessibilityUIElement::getJSClass):
2659         * DumpRenderTree/AccessibilityUIElement.h:
2660         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2661         (AccessibilityUIElement::selectedChildrenCount):
2662         (AccessibilityUIElement::selectedChildAtIndex):
2663         (AccessibilityUIElement::setSelectedChildAtIndex):
2664         (AccessibilityUIElement::removeSelectionAtIndex):
2665         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2666         (AccessibilityUIElement::selectedChildrenCount):
2667         (AccessibilityUIElement::selectedChildAtIndex):
2668         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2669         (WTR::AccessibilityUIElement::setSelectedChildAtIndex):
2670         (WTR::AccessibilityUIElement::removeSelectionAtIndex):
2671         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2672         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2673         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2674         (WTR::AccessibilityUIElement::selectedChildAtIndex):
2675         (WTR::AccessibilityUIElement::selectedChildrenCount):
2676         (WTR::AccessibilityUIElement::setSelectedChildAtIndex):
2677         (WTR::AccessibilityUIElement::removeSelectionAtIndex):
2678
2679 2014-02-23  Diego Pino García  <dpino@igalia.com>
2680
2681         [GTK] Fix build after Web Inspector code reorganization (r164543)
2682         https://bugs.webkit.org/show_bug.cgi?id=129231
2683
2684         Reviewed by Dean Jackson.
2685
2686         * gtk/generate-inspector-gresource-manifest.py:
2687         Modify paths to Web Inspector code.
2688
2689 2014-02-23  Martin Robinson  <mrobinson@igalia.com>
2690
2691         [GTK] generate-gtkdoc should use argparse
2692         https://bugs.webkit.org/show_bug.cgi?id=128418
2693
2694         Reviewed by Carlos Garcia Campos.
2695
2696         * gtk/generate-gtkdoc: Get all arguments from argparse, pass then as parameters
2697         to all functions, and guard the main routine with a __name__ == __main__ check.
2698
2699 2014-02-23  Martin Robinson  <mrobinson@igalia.com>
2700
2701         [GTK][CMake] Many plugin tests fail when running WebKit1 layout tests
2702         https://bugs.webkit.org/show_bug.cgi?id=129191
2703
2704         Reviewed by Anders Carlsson.
2705
2706         * DumpRenderTree/PlatformGTK.cmake: Properly specify the library build directory
2707         for the GTK+ DumpRenderTree build. We could manually construct this path, but the
2708         name of the directory is "lib" and not "libs". Instead we should use the CMake
2709         variable specifically assigned to this task.
2710
2711 2014-02-23  David Kilzer  <ddkilzer@apple.com>
2712
2713         [ASan] Add JSC::DFG::prepareOSREntry() to ignore list
2714         <http://webkit.org/b/129209>
2715
2716         Reviewed by Geoffrey Garen.
2717
2718         * asan/webkit-asan-ignore.txt: Add DFG::prepareOSREntry() to the
2719         ignore list to make ASan builds usable again.  Follow-up
2720         investigation is tracked by <rdar://problem/16055903>.
2721
2722 2014-02-20  David Farler  <dfarler@apple.com>
2723
2724         Make old-run-webkit-tests work with iOS Simulator WebKitTestRunner
2725         https://bugs.webkit.org/show_bug.cgi?id=128622
2726
2727         Reviewed by Simon Fraser.
2728
2729         With this change, we now have layout tests running in both DumpRenderTree
2730         and WebKitTestRunner, with WebKit and WebKit2 used respectively in the iOS
2731         simulator.
2732
2733         * Scripts/old-run-webkit-tests:
2734         In general, make any specific reference to DumpRenderTree
2735         able to refer to WebKitTestRunner wherever possible:
2736         - Rename functions to remove DRT-specific naming.
2737         - Name FIFOs after the tool that is being used.
2738         -- Clean up FIFO creation code
2739         Other necessary changes:
2740         - Allow use of an ios-sim-wk2 platform.
2741         - Clean up platform hierarchy creation where the simulator platform behavior differed.
2742         * WebKitTestRunner/TestController.cpp:
2743         Open FIFOs to get dumps out of the simulator as we do in DumpRenderTree.
2744         (WTR::TestController::TestController):
2745         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2746         Copy the injected bundle into the app bundle.
2747
2748 2014-02-21  Joseph Pecoraro  <pecoraro@apple.com>
2749
2750         run-webkit-httpd fails to find httpd configuation file.
2751
2752         Reviewed by Ryosuke Niwa.
2753
2754         * Scripts/webkitperl/httpd.pm:
2755         (getHTTPDConfigPathForTestDirectory):
2756
2757 2014-02-21  Eric Carlson  <eric.carlson@apple.com>
2758
2759         Fix TimeRanges layering violations
2760         https://bugs.webkit.org/show_bug.cgi?id=128717
2761
2762         Reviewed by Jer Noble.
2763
2764         * TestWebKitAPI/Tests/WebCore/TimeRanges.cpp: TimeRanges* -> TimeRanges&.
2765         (TestWebKitAPI::TEST):
2766
2767 2014-02-21  Diego Pino García  <dpino@igalia.com>
2768
2769         Web Inspector: update check-webkit-style to flag single quotes in WebInspectorUI projects
2770         https://bugs.webkit.org/show_bug.cgi?id=128422
2771
2772         Reviewed by Joseph Pecoraro.
2773
2774         * Scripts/webkitpy/style/checkers/js.py:
2775         (JSChecker.__init__):
2776         (JSChecker.check):
2777         (SingleQuoteChecker):
2778         (SingleQuoteChecker.__init__):
2779         (SingleQuoteChecker.check):
2780         * Scripts/webkitpy/style/checkers/js_unittest.py:
2781         (JSTestCase.assertError.error_for_test):
2782         (JSTestCase.assertError):
2783         (JSTestCase.test_no_error):
2784         (JSTestCase.test_error):
2785
2786 == Rolled over to ChangeLog-2014-02-20 ==