Tools/ChangeLog

   1 2015-10-09  Brian Burg  <bburg@apple.com>
   2
   3         Teach webkitperl how to figure out IOS versions from the SDK
   4         https://bugs.webkit.org/show_bug.cgi?id=149963
   5
   6         Reviewed by Daniel Bates.
   7
   8         It should be easier to check the major and minor version of IOS SDKs.
   9
  10         * Scripts/copy-webkitlibraries-to-product-directory: use iosVersion().
  11         * Scripts/webkitdirs.pm:
  12         (splitVersionString): Added.
  13         (determineOSXVersion): Use splitVersionString.
  14         (determineIOSVersion): Added. Look at the SDK version and make a tuple.
  15         (iosVersion): Added.
  16
  17 2015-10-09  Simon Fraser  <simon.fraser@apple.com>
  18
  19         [iOS WK2] Fix some leaks in TestRunnerWKWebView and UIScriptContext
  20         https://bugs.webkit.org/show_bug.cgi?id=149960
  21
  22         Reviewed by Tim Horton.
  23
  24         Use adoptWK(), and null out some members (file is not using ARC).
  25
  26         * WebKitTestRunner/UIScriptContext/UIScriptContext.cpp:
  27         (UIScriptContext::uiScriptComplete):
  28         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
  29         (-[TestRunnerWKWebView dealloc]):
  30
  31 2015-10-09  Csaba Osztrogonác  <ossy@webkit.org>
  32
  33         Remove ENABLE_SUID_SANDBOX_LINUX cruft
  34         https://bugs.webkit.org/show_bug.cgi?id=149954
  35
  36         Reviewed by Darin Adler.
  37
  38         * Scripts/webkitperl/FeatureList.pm:
  39
  40 2015-10-09  Daniel Bates  <dabates@apple.com>
  41
  42         Make iOS builders generate debug information in a separate dSYM file
  43         https://bugs.webkit.org/show_bug.cgi?id=149696
  44
  45         Reviewed by Darin Adler.
  46
  47         Similar to the Mac builders, the iOS builders should write debug information
  48         into a separate dSYM file instead of including such information in the binary
  49         itself (default Xcode behavior)
  50
  51         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
  52         (CompileWebKit.start):
  53
  54 2015-10-09  Csaba Osztrogonác  <ossy@webkit.org>
  55
  56         Fix webkitpy tests after r190779
  57         https://bugs.webkit.org/show_bug.cgi?id=149949
  58
  59         Reviewed by Ryosuke Niwa.
  60
  61         * Scripts/webkitpy/benchmark_runner/benchmark_results.py:
  62         (BenchmarkResults.format):
  63         (BenchmarkResults._format_values):
  64
  65 2015-10-08  Dewei Zhu  <dewei_zhu@apple.com>
  66
  67         Extend run-benchmark script to support human-readable results conversion.
  68         https://bugs.webkit.org/show_bug.cgi?id=149944
  69
  70         Reviewed by Ryosuke Niwa.
  71
  72         Add '--read-results-json' and '--no-adjust-unit' options.
  73         '--read-results-json' option converts result file to human readable format.
  74         '--no-adjust-unit' option skips scientific notation convertion.
  75         '--platform' defaults to 'osx' and '--browser' defaults to 'safari'.
  76
  77         * Scripts/webkitpy/benchmark_runner/benchmark_results.py:
  78         (BenchmarkResults.format):
  79         (BenchmarkResults._format_tests):
  80         (BenchmarkResults._format_values):
  81         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
  82         (BenchmarkRunner.__init__):
  83         (BenchmarkRunner._run_benchmark):
  84         (BenchmarkRunner._dump):
  85         (BenchmarkRunner.show_results):
  86         (BenchmarkRunner._show_results): Deleted.
  87         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
  88         (parse_args):
  89         (start):
  90
  91 2015-10-08  Daniel Bates  <dabates@apple.com>
  92
  93         Add iOS 9 device builder to WebKit Bot Watcher's Dashboard
  94         https://bugs.webkit.org/show_bug.cgi?id=149945
  95
  96         Reviewed by Dan Bernstein.
  97
  98         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9.png: Added.
  99         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9@2x.png: Added.
 100         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
 101         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
 102         (WebKitBuildbot):
 103         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
 104         (table.queue-grid tr.platform.ios-9 img.logo):
 105
 106 2015-10-08  Daniel Bates  <dabates@apple.com>
 107
 108         Teach build-webkit to install LLVM binaries for iOS when building for device with the public iOS SDK
 109         https://bugs.webkit.org/show_bug.cgi?id=149943
 110
 111         Reviewed by Dan Bernstein.
 112
 113         Following the addition of the LLVM binaries for iOS in changeset r190759 (bug #149913) we should
 114         teach build-webkit to install them when building for iOS device using the public iOS SDK.
 115
 116         * Scripts/build-webkit:
 117
 118 2015-10-08  Daniel Bates  <dabates@apple.com>
 119
 120         Add LLVM binaries for iOS 9 device
 121         https://bugs.webkit.org/show_bug.cgi?id=149913
 122
 123         Reviewed by Filip Pizlo.
 124
 125         Implement support for building LLVM for ARM64-based iOS devices.
 126
 127         * Scripts/build-jsc: Enable the FTL when building for Mac or iOS device.
 128         * Scripts/copy-webkitlibraries-to-product-directory: Move logic to clean
 129         an existing build earlier in the file such that remove previously built
 130         libraries before building/copying new ones (if applicable).
 131         (fileContains): Moved function outside of if-block.
 132         (isContentOfFileEqualToString): Renamed; formerly named fileContentsEquals().
 133         (buildLLVM): Added. Extracted machinery to build LLVM into this function and
 134         added logic to build LLVM for ARM64-based iOS devices.
 135         (symlinkLLVMLibrariesIfNeeded): Added. Extracted machinery to symlink the built
 136         LLVM into the WebKitBuild directory.
 137
 138 2015-10-08  Alexey Proskuryakov  <ap@apple.com>
 139
 140         Crash-only queues on bot watcher's dashboard should not have non-crashing tests in popovers
 141         https://bugs.webkit.org/show_bug.cgi?id=149848
 142
 143         Reviewed by Darin Adler.
 144
 145         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
 146
 147 2015-10-07  Brent Fulgham  <bfulgham@apple.com>
 148
 149         [Win] Support 64-bit Build and Testing
 150         https://bugs.webkit.org/show_bug.cgi?id=149904
 151
 152         Reviewed by Daniel Bates.
 153
 154         Extend our existing scripts to support 64-bit build and test operations on
 155         Windows.
 156
 157         * Scripts/build-dumprendertree: We don't need to build DRT on its own;
 158         Windows always builds the whole stack.
 159         * Scripts/webkit-build-directory: Add an option to return the location of
 160         the executable files produced by a specific configuration. This change is
 161         actually useful for Gtk and EFL, too.
 162         * Scripts/webkitdirs.pm:
 163         (executableProductDir): Added. This function appends the proper binary
 164         path to the productDir. This is useful for Windows, Gtk, and EFL ports.
 165         (jscProductDir): Use the new 'executableProductDir' method.
 166         (setPathForRunningWebKitApp): Ditto.
 167         (runSafari): Ditto.
 168         (runMiniBrowser): Ditto.
 169         * Scripts/webkitpy/port/factory.py:
 170         (configuration_options): Add a 64-bit option, used on Windows to specify
 171         which binary target should be used for testing.
 172         * Scripts/webkitpy/port/win.py:
 173         (WinPort._port_flag_for_scripts): Added. Supply the 64-bit flag to child
 174         processes when needed.
 175         (WinPort._build_path): Add the correct binary target path to _build_path.
 176         (WinPort._ntsd_location): Check 32-bit paths when running 32-bit tests,
 177         64-bit paths for 64-bit tests.
 178         (WinPort.setup_crash_log_saving): Remove '-e %ld' argument, since the
 179         NTSD debugger does not understand this argument.
 180
 181 2015-10-07  Myles C. Maxfield  <mmaxfield@apple.com>
 182
 183         Test font-variant-* and font-feature-settings with TrueType fonts
 184         https://bugs.webkit.org/show_bug.cgi?id=149776
 185
 186         Reviewed by Simon Fraser.
 187
 188         This test extends our existing FontWithFeatures project to be able to generate a
 189         TrueType font. This font is conceptually similar as the existing OpenType font,
 190         except the feature -> character mapping is different.
 191
 192         The font itself only supports the following characters:
 193         ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz
 194         However, the shape of these letters are either an X or a check mark.
 195         The letter "A" always is a check mark.
 196         The letter "B" always is an X.
 197         Each font feature has an letter associated with it. When the font feature is enabled,
 198         that letter is shown as a check mark. For example, when
 199         "kLowerCaseType / kLowerCaseSmallCapsSelector" is enabled, "S" is shown as a check
 200         mark.
 201
 202         Here are the mappings of font features to letters:
 203         kLigaturesType / kCommonLigaturesOnSelector: C
 204         kLigaturesType / kContextualLigaturesOnSelector: D
 205         kLigaturesType / kRareLigaturesOnSelector: G
 206         kLigaturesType / kHistoricalLigaturesOnSelector: I
 207         kContextualAlternatesType / kContextualAlternatesOnSelector: L
 208         kVerticalPositionType / kInferiorsSelector: O
 209         kVerticalPositionType / kSuperiorsSelector: P
 210         kLowerCaseType / kLowerCaseSmallCapsSelector: S
 211         kUpperCaseType / kUpperCaseSmallCapsSelector: V
 212         kLowerCaseType / kLowerCasePetiteCapsSelector: T
 213         kUpperCaseType / kUpperCasePetiteCapsSelector: W
 214         kLetterCaseType / 14: Y
 215         kStyleOptionsType / kTitlingCapsSelector: a
 216         kNumberCaseType / kUpperCaseNumbersSelector: c
 217         kNumberCaseType / kLowerCaseNumbersSelector: d
 218         kNumberSpacingType / kProportionalNumbersSelector: f
 219         kNumberSpacingType / kMonospacedNumbersSelector: g
 220         kFractionsType / kDiagonalFractionsSelector: i
 221         kFractionsType / kVerticalFractionsSelector: j
 222         kVerticalPositionType / kOrdinalsSelector: Q
 223         kTypographicExtrasType / kSlashedZeroOnSelector: k
 224         kLigaturesType / kHistoricalLigaturesOnSelector: K
 225         kCharacterShapeType / kJIS1978CharactersSelector: m
 226         kCharacterShapeType / kJIS1983CharactersSelector: n
 227         kCharacterShapeType / kJIS1990CharactersSelector: o
 228         kCharacterShapeType / kJIS2004CharactersSelector: p
 229         kCharacterShapeType / kSimplifiedCharactersSelector: q
 230         kCharacterShapeType / kTraditionalCharactersSelector: r
 231         kTextSpacingType / kMonospacedTextSelector: t
 232         kTextSpacingType / kProportionalTextSelector: u
 233         kRubyKanaType / kRubyKanaOnSelector: v
 234
 235         * FontWithFeatures/FontWithFeatures.xcodeproj/project.pbxproj:
 236         * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
 237         (CFFBuilder::moveTo):
 238         (CFFBuilder::lineTo):
 239         (GLYFBuilder::GLYFBuilder):
 240         (GLYFBuilder::takeResult):
 241         (GLYFBuilder::moveTo):
 242         (GLYFBuilder::lineTo):
 243         (GLYFBuilder::closePath):
 244         (GLYFBuilder::writePoint):
 245         (GLYFBuilder::append16):
 246         (generateBoxCharString):
 247         (generateCheckCharString):
 248         (generateXCharString):
 249         (itemForGlyph):
 250         (Generator::generate):
 251         (Generator::insertSelector):
 252         (Generator::insertFeature):
 253         (Generator::generateFeatureDescription):
 254         (Generator::appendCFFTable):
 255         (Generator::appendGLYFTable):
 256         (Generator::appendLOCATable):
 257         (Generator::appendFEATTable):
 258         (Generator::appendMetamorphosisChain):
 259         (Generator::appendMORXTable):
 260         (Generator::appendHEADTable):
 261         (Generator::appendHMTXTable):
 262         (Generator::appendNameSubtable):
 263         (Generator::append2ByteASCIIString):
 264         (Generator::appendNAMETable):
 265         (generateFont):
 266         (CFFBuilder::curveToCubic): Deleted.
 267         (charStringForGlyph): Deleted.
 268         * FontWithFeatures/FontWithFeatures/FontCreator.h:
 269         * FontWithFeatures/FontWithFeatures/main.cpp:
 270         (constructFontWithTrueTypeFeature):
 271         (constructFontWithOpenTypeFeature):
 272         (drawText):
 273         (main):
 274         (drawTextWithFeature): Deleted.
 275
 276 2015-10-07  Commit Queue  <commit-queue@webkit.org>
 277
 278         Unreviewed, rolling out r190572, r190593, r190594, and
 279         r190639.
 280         https://bugs.webkit.org/show_bug.cgi?id=149897
 281
 282         Breaks Mavericks build (Requested by litherum on #webkit).
 283
 284         Reverted changesets:
 285
 286         "Allow WKRetainPtrs to be used as keys in hashing data
 287         structures"
 288         https://bugs.webkit.org/show_bug.cgi?id=149762
 289         http://trac.webkit.org/changeset/190572
 290
 291         "REGRESSION(189668?): http/tests/notifications/events.html
 292         flakily asserts or times out"
 293         https://bugs.webkit.org/show_bug.cgi?id=149218
 294         http://trac.webkit.org/changeset/190593
 295
 296         "Prospective Mavericks build fix."
 297         http://trac.webkit.org/changeset/190594
 298
 299         "Post-review cleanup after r190572."
 300         http://trac.webkit.org/changeset/190639
 301
 302 2015-10-06  Michael Catanzaro  <mcatanzaro@igalia.com>
 303
 304         [GTK] Add autocleanups
 305         https://bugs.webkit.org/show_bug.cgi?id=149588
 306
 307         Reviewed by Darin Adler.
 308
 309         * TestWebKitAPI/Tests/WebKit2Gtk/AutocleanupsTest.cpp: Added.
 310         (AutocleanupsTest::create):
 311         (AutocleanupsTest::testWebProcessAutocleanups):
 312         (registerTests):
 313         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
 314         * TestWebKitAPI/Tests/WebKit2Gtk/TestAutocleanups.cpp: Added.
 315         (testUIProcessAutocleanups):
 316         (testWebProcessAutocleanups):
 317         (beforeAll):
 318         (afterAll):
 319
 320 2015-10-06  Brian Burg  <bburg@apple.com>
 321
 322         Unreviewed, try to fix the iOS 8 build after r190368.
 323
 324         On older versions, IOHIDEventCreateForceEvent is not available.
 325
 326         * WebKitTestRunner/ios/HIDEventGenerator.mm:
 327         (-[HIDEventGenerator _createIOHIDEventType:]): Add another guard for force events.
 328
 329 2015-10-06  Keith Miller  <keith_miller@apple.com>
 330
 331         Add gmalloc option to run-javascriptcore-tests.
 332         https://bugs.webkit.org/show_bug.cgi?id=149858
 333
 334         Reviewed by Geoffrey Garen.
 335
 336         run-javascriptcore-tests takes a new option --gmalloc with an optional string argument, the path to the gmalloc dylib.
 337         If no argument is provided then /usr/lib/libgmalloc.dylib is used by default.
 338
 339         * Scripts/run-javascriptcore-tests:
 340
 341 2015-10-06  Myles C. Maxfield  <mmaxfield@apple.com>
 342
 343         Post-review cleanup after r190572.
 344
 345         Unreviewed.
 346
 347         * TestWebKitAPI/Tests/WebKit2/WKRetainPtr.cpp:
 348
 349 2015-10-06  Brent Fulgham  <bfulgham@apple.com>
 350
 351         [Win] Unreviewed build correction.
 352
 353         * TestWebKitAPI/PlatformWin.cmake: We don't need to link to all of these libraries. Most
 354         are soft-linked at runtime.
 355
 356 2015-10-06  Keith Miller  <keith_miller@apple.com>
 357
 358         Fix run-javascriptcore-tests/run-jsc-stress-tests to work with rootless, add a --quick option and deprecate the Mozilla driver.
 359         https://bugs.webkit.org/show_bug.cgi?id=149815
 360
 361         Reviewed by Filip Pizlo.
 362
 363         Rootless has an issue where it will strip any environment variables that start with DYLD starting a perl/ruby/python script.
 364         Now, run-jsc-stress-tests takes an new argument, --env-vars, that will set the specified environment variables before
 365         running tests. Additionally, I added a quick option that only runs default and the NoCJITValidate versions of each test.
 366         Finally, I removed the calls to the mozilla jsDriver.pl since the run-jsc-stress-tests runner runs the same test suite
 367         so should just use one test runner.
 368
 369         * Scripts/run-javascriptcore-tests:
 370         (runJSCStressTests):
 371         (runMozillaTests): Deleted.
 372         (defaultJsDriverArgsForMozillaTests): Deleted.
 373         * Scripts/run-jsc-stress-tests:
 374
 375 2015-10-06  Mark Salisbury  <mark.salisbury@hp.com>
 376
 377         [GTK] Make update-webkitgtk-libs work behind firewall
 378
 379         update-webkitgtk-libs can work behind a firewall with changes to
 380         a few packages.  Where outbound git and active FTP connections
 381         fail, using http protocol succeeds.  Most packages are
 382         already accessed using http.
 383
 384         https://bugs.webkit.org/show_bug.cgi?id=148941
 385
 386         Reviewed by Martin Robinson.
 387
 388         Tools
 389         * gtk/jhbuild.modules:
 390             Replace git URLs with http.  Remove no longer used ftp repositories.
 391             Update argument for libxml2's autogen.sh script (--without-python
 392             is ignored; --with-python=no is correct).
 393         * jhbuild/jhbuild-wrapper:
 394             Instead of connecting to git://git.gnome.org/jhbuild, connect to
 395             http://git.gnome.org/browse/jhbuild.
 396
 397 2015-10-06  Daniel Bates  <dbates@webkit.org>
 398
 399         Enable XSLT when building WebKit for iOS using the public iOS SDK
 400         https://bugs.webkit.org/show_bug.cgi?id=149827
 401
 402         Reviewed by Alexey Proskuryakov.
 403
 404         Teach script configure-xcode-for-ios-development to copy the OS X XSLT headers to the iPhoneOS
 405         and iPhoneSimulator SDKs so as to support building WebKit for iOS with XSLT. A person must
 406         run this script before building WebKit for iOS or the build will fail because one or more XSLT
 407         headers cannot be found.
 408
 409         * Scripts/configure-xcode-for-ios-development:
 410         (copyMissingXSLTHeadersToSDKIfNeeded): Added.
 411
 412 2015-10-05  Myles C. Maxfield  <mmaxfield@apple.com>
 413
 414         REGRESSION(189668?): http/tests/notifications/events.html flakily asserts or times out
 415         https://bugs.webkit.org/show_bug.cgi?id=149218
 416
 417         Reviewed by Alexey Proskuryakov.
 418
 419         Because of r189668, WebKitTestRunner now tears down and recreates its WKNotificationManagerRef
 420         when the TestOptions change. Previously, WebNotificationProvider only could handle a single
 421         WKNotificationManagerRef. Because the ower of the WKNotificationManagerRef is reference counted,
 422         and AppKit internally retains some objects which end up retaining the WKNotificationManagerRef,
 423         the old WKNotificationManager may not be destroyed before the new one is created. Therefore,
 424         WebNotificationProvider must be updated to appropriately handle multiple
 425         WKNotificationManagerRefs in flight at the same time.
 426
 427         * WebKitTestRunner/WebNotificationProvider.cpp:
 428         (WTR::WebNotificationProvider::~WebNotificationProvider):
 429         (WTR::WebNotificationProvider::showWebNotification):
 430         (WTR::WebNotificationProvider::closeWebNotification):
 431         (WTR::WebNotificationProvider::addNotificationManager):
 432         (WTR::WebNotificationProvider::removeNotificationManager):
 433         (WTR::WebNotificationProvider::simulateWebNotificationClick):
 434         (WTR::WebNotificationProvider::reset):
 435         * WebKitTestRunner/WebNotificationProvider.h:
 436
 437 2015-10-05  Daniel Bates  <dabates@apple.com>
 438
 439         Disable Bitcode when building for iOS device
 440         https://bugs.webkit.org/show_bug.cgi?id=149818
 441
 442         Reviewed by Alexey Proskuryakov.
 443
 444         Xcode 7 generates bitcode for iOS device apps by default. Do not generate bitcode
 445         when building for iOS device.
 446
 447         * Scripts/webkitdirs.pm:
 448         (XcodeOptions):
 449
 450 2015-10-05  Daniel Bates  <dabates@apple.com>
 451
 452         [iOS] Make it possible to build WebKit using iphoneos SDK without a developer certificate installed
 453         https://bugs.webkit.org/show_bug.cgi?id=140828
 454         <rdar://problem/19520599>
 455
 456         Reviewed by Alexey Proskuryakov.
 457
 458         Support building WebKit for iOS device without an iOS Developer certificate installed. Otherwise,
 459         we will pass CODE_SIGN_IDENTITY="iPhone Developer: " to Xcode to find a iOS Developer certificate
 460         to use. To use a specific installed iOS Developer certificate, explicitly pass CODE_SIGN_IDENTITY
 461         to build-webkit.
 462
 463         * Scripts/webkitdirs.pm:
 464         (XcodeOptions): Cleaned up code. When building for iOS device, pass to Xcode CODE_SIGN_IDENTITY="iPhone Developer: "
 465         to code sign using the installed iOS development certificate (if it exists - we assume there is only one such certificate).
 466         Otherwise, pass CODE_SIGN_IDENTITY="" and CODE_SIGNING_REQUIRED=NO to Xcode to disable code signing.
 467         (hasIOSDevelopmentCertificate): Added.
 468
 469 2015-10-05  Daniel Bates  <dabates@apple.com>
 470
 471         DumpRenderTree built with public iOS SDK crashes under -[WebPreferences(WebPrivate) _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]
 472         https://bugs.webkit.org/show_bug.cgi?id=149766
 473
 474         Reviewed by Alexey Proskuryakov.
 475
 476         Create network storage testing session on iOS.
 477
 478         Currently we do not create a network storage testing session on iOS. A network storage testing session always
 479         has an associated cookie store. When WebKit is built without USE(CFNETWORK), NetworkStorageSession::defaultStorageSession().cookieStorage()
 480         returns nullptr because the caller is expected to interact with NSHTTPCookieStorage instead of querying
 481         NetworkStorageSession for the cookie store. When WebKit is built with USE(CFNETWORK) accessing
 482         NetworkStorageSession::defaultStorageSession().cookieStorage() returns a valid cookie store (creating one if
 483         it does not exist). Instead we should make use of NetworkStorageSession::switchToNewTestingSession() to
 484         create a network storage testing session when building DumpRenderTree for iOS so as to ensure a consistent
 485         testing environment regardless of whether we built with USE(CFNETWORK). This will also make the behavior of
 486         DumpRenderTree on iOS more consistent with the behavior of DumpRenderTree on Mac.
 487
 488         As a side effect of this change DumpRenderTree no longer crashes in -[WebPreferences(WebPrivate) _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]
 489         when WebKit is built without USE(CFNETWORK) because NetworkStorageSession::defaultStorageSession().cookieStorage()
 490         returns a non-null pointer to a cookie store.
 491
 492         * DumpRenderTree/mac/DumpRenderTree.mm:
 493         (prepareConsistentTestingEnvironment):
 494
 495 2015-10-05  Simon Fraser  <simon.fraser@apple.com>
 496
 497         Fix the iOS 8 build again, where -[UIApplication _enqueueHIDEvent:] is not
 498         available.
 499
 500         * WebKitTestRunner/ios/HIDEventGenerator.mm:
 501         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]):
 502
 503 2015-10-05  Myles C. Maxfield  <mmaxfield@apple.com>
 504
 505         Allow WKRetainPtrs to be used as keys in hashing data structures
 506         https://bugs.webkit.org/show_bug.cgi?id=149762
 507
 508         Reviewed by Anders Carlsson.
 509
 510         * TestWebKitAPI/PlatformGTK.cmake:
 511         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 512         * TestWebKitAPI/Tests/WebKit2/WKRetainPtr.cpp: Added.
 513         (TestWebKitAPI::TEST):
 514
 515 2015-10-05  Simon Fraser  <simon.fraser@apple.com>
 516
 517         Fix the iOS 8 build, where -[UIApplication _enqueueHIDEvent:] is not
 518         available, and tidy up the #ifdefs in the UIKitSPI header.
 519
 520         * WebKitTestRunner/ios/HIDEventGenerator.mm:
 521         (-[HIDEventGenerator _sendHIDEvent:]):
 522         * WebKitTestRunner/ios/UIKitSPI.h:
 523
 524 2015-10-04  Zan Dobersek  <zdobersek@igalia.com>
 525
 526         [GTK] Remove duplicate entries in WebKitTestRunner_SOURCES
 527         https://bugs.webkit.org/show_bug.cgi?id=149792
 528
 529         Reviewed by Martin Robinson.
 530
 531         * WebKitTestRunner/PlatformGTK.cmake: Don't list build targets
 532         for WebKitTestRunner multiple times.
 533
 534 2015-10-04  Daniel Bates  <dabates@apple.com>
 535
 536         Fix the Apple Internal iOS build after <http://trac.webkit.org/changeset/190515>
 537         (https://bugs.webkit.org/show_bug.cgi?id=149753)
 538
 539         For now, support calling build-layouttestrelay without --ios-simulator so long
 540         as we are building on a Mac.
 541
 542         * Scripts/build-layouttestrelay:
 543
 544 2015-10-04  Alexey Proskuryakov  <ap@apple.com>
 545
 546         Support Trac 1.0.x XML timeline link format
 547         https://bugs.webkit.org/show_bug.cgi?id=149786
 548
 549         Reviewed by Lucas Forschler.
 550
 551         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
 552         (Trac.prototype._convertCommitInfoElementToObject):
 553
 554 2015-10-04  Alexey Proskuryakov  <ap@apple.com>
 555
 556         Fix some errors on bot watcher's dashboard
 557         https://bugs.webkit.org/show_bug.cgi?id=149789
 558
 559         Reviewed by Lucas Forschler.
 560
 561         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
 562         (BuildbotTesterQueueView.prototype.appendBuilderQueueStatus): We may not get to layout
 563         tests step, in which case layoutTestResults.tooManyFailures would raise an exception.
 564
 565 2015-10-04  Alexey Proskuryakov  <ap@apple.com>
 566
 567         Bot watcher's dashboard builders should turn yellow when svn fails
 568         https://bugs.webkit.org/show_bug.cgi?id=149791
 569
 570         Reviewed by Lucas Forschler.
 571
 572         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
 573         (BuildbotBuilderQueueView.prototype.appendBuilderQueueStatus):
 574         (BuildbotBuilderQueueView.prototype.update):
 575
 576 2015-10-02  Daniel Bates  <dabates@apple.com>
 577
 578         Add iOS 9 Simulator builders and testers to WebKit Bot Watcher's Dashboard
 579         https://bugs.webkit.org/show_bug.cgi?id=149769
 580
 581         Reviewed by Alexey Proskuryakov.
 582
 583         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9Simulator.png: Added.
 584         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9Simulator@2x.png: Added.
 585         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
 586         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
 587         (WebKitBuildbot):
 588         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
 589         (table.queue-grid tr.platform.ios-simulator-9 img.logo):
 590
 591 2015-10-02  Ryosuke Niwa  <rniwa@webkit.org>
 592
 593         REGRESSION(r190370): Speedometer spits out an extra console message
 594         https://bugs.webkit.org/show_bug.cgi?id=149720
 595
 596         Unreviewed. Temporarily ignore the console error message.
 597
 598         * Scripts/webkitpy/performance_tests/perftest.py:
 599         (PerfTest._filter_output):
 600
 601 2015-10-02  Brent Fulgham  <bfulgham@apple.com>
 602
 603         Provide "--no-ninja" option to avoid using Ninja
 604         https://bugs.webkit.org/show_bug.cgi?id=149757
 605
 606         Reviewed by Alex Christensen.
 607
 608         Add a new command line argument understood by webkitdirs.pm so
 609         that we can conditionally avoid using Ninja. This is an
 610         'opt-out' argument, so no existing Ninja users should be affected.
 611
 612         * Scripts/webkitdirs.pm:
 613         (canUseNinja): Check for option and block ninja if present.
 614
 615 2015-10-02  Aakash Jain  <aakash_jain@apple.com>
 616
 617         Flakiness dashboard should support OS X El Capitan
 618         https://bugs.webkit.org/show_bug.cgi?id=149648
 619
 620         Reviewed by Alexey Proskuryakov.
 621
 622         * TestResultServer/static-dashboards/flakiness_dashboard.js: Fix the broken dashboard for ElCapitan.
 623
 624 2015-10-02  Daniel Bates  <dabates@apple.com>
 625
 626         Fix run-webkit-tests --ios-simulator after <http://trac.webkit.org/changeset/190515>
 627         (https://bugs.webkit.org/show_bug.cgi?id=149753)
 628
 629         For now, pass --ios-simulator.
 630
 631         * Scripts/webkitpy/port/ios.py:
 632         (IOSSimulatorPort._build_relay):
 633
 634 2015-10-02  Simon Fraser  <simon.fraser@apple.com>
 635
 636         Remove a "nullable" that breaks the iOS 8 build.
 637
 638         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
 639         (-[TestRunnerWKWebView scrollViewWillBeginZooming:withView:]):
 640
 641 2015-10-02  Daniel Bates  <dabates@apple.com>
 642
 643         LayoutTestRelay is not built and archived when building for iOS Simulator
 644         https://bugs.webkit.org/show_bug.cgi?id=149753
 645
 646         Reviewed by Alexey Proskuryakov and Andy Estes.
 647
 648         Towards running layout tests on the iOS Simulator test bots, we need to teach scripts build-webkit
 649         and built-product-archive to build the Mac tool LayoutTestRelay and include this tool in the built
 650         product archive when building for iOS Simulator, respectively.
 651
 652         * BuildSlaveSupport/built-product-archive:
 653         (main): Pass the full platform name (options.platform) to archiveBuiltProduct() so that it can
 654         differentiate between iOS device and iOS Simulator platforms.
 655         (webkitBuildDirectoryForConfigurationAndPlatform): Extracted logic to run the script webkit-build-directory
 656         from determineWebKitBuildDirectories() into this function so that it can be used by both
 657         determineWebKitBuildDirectories() and archiveBuiltProduct().
 658         (determineWebKitBuildDirectories): Moved logic to execute the script webkit-build-directory from here to
 659         webkitBuildDirectoryForConfigurationAndPlatform().
 660         (createZip): Added parameter embedParentDirectoryNameOnDarwin (defaults to False) to specify whether
 661         we should call ditto(1) with --keepParent to embed the parent directory name in the zip archive. This
 662         argument is only applicable when building on Darwin. We only pass embedParentDirectoryNameOnDarwin=True
 663         when making an archive for a Mac or iOS device build. For iOS Simulator builds we archive two directories
 664         and we do not want to keep the parent directory because it is a placeholder directory used as a workaround
 665         for the limitation that ditto(1) can only accept a single directory to archive on its command line.
 666         (archiveBuiltProduct): Modified to take the full platform name as an argument. Added logic for iOS.
 667         For iOS device builds we use the same logic as for a Mac build and archive the configuration-specific
 668         build directory. For iOS Simulator builds we archive the configuration-specific iOS build directory,
 669         LayoutTestRelay and LayoutTestRelay.dSYM (if it exists) from the configuration-specific Mac build.
 670         * Scripts/build-layouttestrelay:
 671             - Remove unnecessary include of Perl module POSIX.
 672             - Only build LayoutTestRelay when building for iOS Simulator (i.e. --ios-simulator is passed).
 673         * Scripts/build-webkit:
 674             - Invoke script build-layouttestrelay when building for iOS Simulator.
 675
 676 2015-10-02  Brent Fulgham  <bfulgham@apple.com>
 677
 678         [Win] Unreviewed test fix.
 679
 680         You cannot run 'run-webkit-tests' from the command line because it does not know
 681         to append the binary subdirectory (bin32/bin64). We don't see this on our builders
 682         because they explicitly set use the 'root' argument to provide the full path to
 683         the test binaries.
 684
 685         * Scripts/webkitpy/port/win.py:
 686         (WinPort._build_path): Added.
 687
 688 2015-10-02  Alex Christensen  <achristensen@webkit.org>
 689
 690         Reloading without content blockers doesn't apply to resource loads after the main frame finishes
 691         https://bugs.webkit.org/show_bug.cgi?id=149430
 692         rdar://problem/22742222
 693
 694         Reviewed by Geoffrey Garen.
 695
 696         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
 697         (WTR::TestController::cocoaResetStateToConsistentValues):
 698         * WebKitTestRunner/mac/TestControllerMac.mm:
 699         (WTR::TestController::platformConfigureViewForTest):
 700         Test what happens when you disable content blockers from the SPI.
 701
 702 2015-10-01  Brent Fulgham  <bfulgham@apple.com>
 703
 704         [Win] Unreviewed build fix for run-api-tests
 705
 706         * Scripts/run-api-tests:
 707         (testToolPaths): Windows run needs to specify the binary path.
 708
 709 2015-10-01  Daniel Bates  <dabates@apple.com>
 710
 711         Another attempt to fix the Windows builders after <https://trac.webkit.org/changeset/190387>
 712         (https://bugs.webkit.org/show_bug.cgi?id=149695)
 713
 714         Following r190424 we can now rely on webkit-build-directory to return the path to
 715         the correct configuration-specific build directory on Windows.
 716
 717         * BuildSlaveSupport/built-product-archive:
 718         (archiveBuiltProduct):
 719
 720 2015-10-01  Brent Fulgham  <bfulgham@apple.com>
 721
 722         [Win] Unreviewed build fix.
 723
 724         * Scripts/webkitdirs.pm:
 725         (setupAppleWinEnv): Use 64-bit build tools if available
 726
 727 2015-10-01  Brent Fulgham  <bfulgham@apple.com>
 728
 729         [Win] Fix TestWebKitAPI build under CMake.
 730
 731         Reviewed by Alex Christensen.
 732
 733         * TestWebKitAPI/PlatformWin.cmake: Add missing link command
 734         for Psapi.lib.
 735
 736 2015-10-01  Brent Fulgham  <bfulgham@apple.com>
 737
 738         [Win] Fix behavior of webkit-build-directory script
 739         https://bugs.webkit.org/show_bug.cgi?id=149718
 740
 741         Reviewed by Alex Christensen.
 742
 743         * Scripts/webkitdirs.pm:
 744         (determineConfigurationProductDir): Do not include the binary
 745         sub-directory in the configuration product directory output.
 746         (jscProductDir): Append correct binary path for Windows build.
 747         (setPathForRunningWebKitApp): Include properly binary subdirectories.
 748         (runSafari): Update for revised productDir behavior.
 749         (runMiniBrowser): Ditto.
 750
 751 2015-10-01  Alexey Proskuryakov  <ap@apple.com>
 752
 753         Stop building LayoutTestRelay for now. It's a Mac project, but build-webkit tries to
 754         use iOS SDK, like with all the others.
 755
 756         * Scripts/build-webkit:
 757
 758 2015-10-01  Daniel Bates  <dabates@apple.com>
 759
 760         Attempt to fix the iOS 9 Simulator testers
 761
 762         Add dependency DumpRenderTree.app to target All of project DumpRenderTree so that we
 763         build DumpRenderTree.app, if applicable. Also, teach build-webkit to build project
 764         LayoutTestRelay when building for iOS Simulator.
 765
 766         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
 767         * Scripts/build-webkit:
 768
 769 2015-10-01  Carlos Garcia Campos  <cgarcia@igalia.com>
 770
 771         [GTK] Websites with invalid auth header keep loading forever
 772         https://bugs.webkit.org/show_bug.cgi?id=149710
 773
 774         Reviewed by Martin Robinson.
 775
 776         Add test case to check that we can authenticate sites with an
 777         empty realm.
 778
 779         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
 780         (testWebViewAuthenticationEmptyRealm):
 781         (serverCallback):
 782         (beforeAll):
 783
 784 2015-10-01  Alexey Proskuryakov  <ap@apple.com>
 785
 786         [Mac] Make run-api-tests work with System Integrity Protection
 787         https://bugs.webkit.org/show_bug.cgi?id=149711
 788         rdar://problem/22928202
 789
 790         Reviewed by Dan Bernstein.
 791
 792         * Scripts/run-api-tests:
 793         (runTest):
 794         (archCommandLineArgumentsForRestrictedEnvironmentVariables):
 795
 796 2015-10-01  Daniel Bates  <dabates@apple.com>
 797
 798         Attempt to fix the Windows build after <https://trac.webkit.org/changeset/190387>
 799         (https://bugs.webkit.org/show_bug.cgi?id=149695)
 800
 801         For some reason built-product-archive hardcodes the assumption that we build for 32-bit Windows.
 802         For now, use the path to the top-level WebKit build directory instead of using the configuration-
 803         specific build directory.
 804
 805         * BuildSlaveSupport/built-product-archive:
 806         (archiveBuiltProduct):
 807
 808 2015-10-01  Csaba Osztrogonác  <ossy@webkit.org>
 809
 810         [EFL] Fix the openwebrtc and gst-plugins-openwebrtc build with clang
 811         https://bugs.webkit.org/show_bug.cgi?id=145837
 812
 813         Reviewed by Philippe Normand.
 814
 815         * efl/jhbuild.modules:
 816         * efl/patches/openwebrtc-clang-warning-fix.patch: Added.
 817         * efl/patches/openwebrtc-gst-plugins-clang-warning-fix.patch: Added.
 818
 819 2015-10-01  Wenson Hsieh  <wenson_hsieh@apple.com>
 820
 821         Unreviewed. Fix the iOS build after r190407.
 822
 823         * WebKitTestRunner/ios/IOKitSPI.h:
 824
 825 2015-10-01  Wenson Hsieh  <wenson_hsieh@apple.com>
 826
 827         Implement keyboard event sending for iOS in WebKitTestRunner
 828         https://bugs.webkit.org/show_bug.cgi?id=149676
 829
 830         Reviewed by Simon Fraser.
 831
 832         Adds support for generating and sending key events in WebKitTestRunner. This is accomplished in a similar
 833         way as touch events, using IOHIDEvent machinery. Also adds callbacks to the UIScriptController JS API that
 834         allows us to run code when the keyboard is shown or hidden.
 835
 836         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl: Adds the typeCharacter JS interface.
 837         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
 838         (WTR::UIScriptController::setDidShowKeyboardCallback):
 839         (WTR::UIScriptController::didShowKeyboardCallback):
 840         (WTR::UIScriptController::setDidHideKeyboardCallback):
 841         (WTR::UIScriptController::didHideKeyboardCallback):
 842         (WTR::UIScriptController::typeCharacterUsingHardwareKeyboard):
 843         (WTR::UIScriptController::platformSetDidShowKeyboardCallback):
 844         (WTR::UIScriptController::platformSetDidHideKeyboardCallback):
 845         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
 846         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
 847         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
 848         (-[TestRunnerWKWebView initWithFrame:configuration:]): Registers the TestRunnerWKWebView to listen to
 849                 the notifications that the keyboard has been raised or lowered.
 850         (-[TestRunnerWKWebView _keyboardDidShow:]):
 851         (-[TestRunnerWKWebView _keyboardDidHide:]):
 852         * WebKitTestRunner/ios/HIDEventGenerator.h:
 853         * WebKitTestRunner/ios/HIDEventGenerator.m:
 854         (-[HIDEventGenerator _sendIOHIDKeyboardEvent:usage:isKeyDown:]): Helper to send a HID keyboard event.
 855         (shouldWrapWithShiftKeyEventForCharacter): Helper used to generate key events.
 856         (hidUsageCodeForCharacter): Ditto.
 857         (-[HIDEventGenerator keyDown:completionBlock:]): Synthesizes and sends HIDKeyboardEvents, triggering
 858                 a keyDown event in WebKit.
 859         * WebKitTestRunner/ios/IOKitSPI.h:
 860         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
 861
 862 2015-10-01  Carlos Garcia Campos  <cgarcia@igalia.com>
 863
 864         Unreviewed, rolling out r190399.
 865
 866         Tests are still failing even after r190362
 867
 868         Reverted changeset:
 869
 870         "Unreviewed. Unskip GTK+ user media unit tests after r190362."
 871         http://trac.webkit.org/changeset/190399
 872
 873 2015-10-01  Csaba Osztrogonác  <ossy@webkit.org>
 874
 875         [jhbuild] switch to new upstream usrsctp library
 876         https://bugs.webkit.org/show_bug.cgi?id=149494
 877
 878         Reviewed by Philippe Normand.
 879
 880         * efl/jhbuild.modules:
 881         * gtk/jhbuild.modules:
 882
 883 2015-10-01  Carlos Garcia Campos  <cgarcia@igalia.com>
 884
 885         Unreviewed. Unskip GTK+ user media unit tests after r190362.
 886
 887         They should pass now.
 888
 889         * Scripts/run-gtk-tests:
 890         (TestRunner):
 891
 892 2015-09-30  Daniel Bates  <dabates@apple.com>
 893
 894         Another attempt to fix the build after <https://trac.webkit.org/changeset/190387>
 895         (https://bugs.webkit.org/show_bug.cgi?id=149695)
 896
 897         * BuildSlaveSupport/built-product-archive:
 898         (determineWebKitBuildDirectories): Substitute _configurationBuildDirectory for _buildDirectory.
 899         (extractBuiltProduct): Substitute _topLevelBuildDirectory for _buildDirectory.
 900
 901 2015-09-30  Daniel Bates  <dabates@apple.com>
 902
 903         Attempt to fix the build after <https://trac.webkit.org/changeset/190387>
 904         (https://bugs.webkit.org/show_bug.cgi?id=149695)
 905
 906         Actually, we need to pass --configuration to script webkit-build-directory to have
 907         it return the path to the configuration-specific build directory.
 908
 909         * BuildSlaveSupport/built-product-archive:
 910         (determineWebKitBuildDirectories):
 911
 912 2015-09-30  Daniel Bates  <dabates@apple.com>
 913
 914         built-product-archive archives incorrect build directory for iOS port
 915         https://bugs.webkit.org/show_bug.cgi?id=149695
 916
 917         Reviewed by Darin Adler.
 918
 919         Fixes an issue where the script built-product-archive archives a non-existent
 920         build directory for the iOS port. Without loss of generality, the script assumes
 921         the path to the Release configuration build for iOS is in directory WebKitBuild/Release.
 922         But the built products for this configuration are in directory WebKitBuild/Release-iphonesimulator.
 923
 924         Currently the script built-product-archive calls `webkit-build-directory --top-level ...`
 925         to determine the top-level build directory and computes the configuration-specific
 926         build directory to be the concatenation of the the top-level build directory and
 927         the configuration (e.g. Release). This is incorrect. Instead we should call
 928         webkit-build-directory omitting the flag --top-level to compute the path to the
 929         configuration-specific build directory.
 930
 931         * BuildSlaveSupport/built-product-archive: Fix up the style such that we use single quoted literals.
 932         (main): Renamed global variable _buildDirectory to _topLevelBuildDirectory to better describe
 933         its purpose and added global variable _configurationBuildDirectory to store the path
 934         to the configuration-specific build directory. Ensure that we have a non-empty string
 935         for both the top-level and configuration-specific build directories.
 936         (determineWebKitBuildDirectories): Formerly named determineWebKitBuildDirectory.
 937         Compute the configuration-specific build directory and store it in the global variable
 938         _configurationBuildDirectory.
 939         (archiveBuiltProduct): Modified to use _configurationBuildDirectory.
 940         (extractBuiltProduct): Modified to use _configurationBuildDirectory and _topLevelBuildDirectory
 941         as needed.
 942         (determineWebKitBuildDirectory): Deleted.
 943
 944 2015-09-30  Hunseop Jeong  <hs85.jeong@samsung.com>
 945
 946         [EFL] css3/device-adapt/* tests failed after r190335.
 947         https://bugs.webkit.org/show_bug.cgi?id=149655
 948
 949         Reviewed by Simon Fraser.
 950
 951         device-adapt/* tests need the fixedLayout option but useFixedLayout option is
 952         overwritten by updatePlatformSpecificViewOptionsForTest after r190335.
 953
 954         * WebKitTestRunner/efl/TestControllerEfl.cpp:
 955         (WTR::shouldUseFixedLayout):
 956
 957 2015-09-30  Dewei Zhu  <dewei_zhu@apple.com>
 958
 959         Extend JetStream timeout for slow devices.
 960
 961         Reviewed by Chris Dumez.
 962
 963         Extend JetStream timeout to 20 minutes.
 964
 965         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:
 966
 967 2015-09-30  Daniel Bates  <dabates@apple.com>
 968
 969         Rename iOS builders/testers to include version
 970         https://bugs.webkit.org/show_bug.cgi?id=149685
 971
 972         Reviewed by Simon Fraser.
 973
 974         Substitute "Apple iOS 9" for "Apple iOS" in the names of iOS builders/testers so as
 975         make it clear to a reader the version of iOS these builders/testers are using.
 976
 977         * BuildSlaveSupport/build.webkit.org-config/config.json:
 978         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
 979
 980 2015-09-30  Daniel Bates  <dabates@apple.com>
 981
 982         Add iOS criterion for triggering a build
 983         https://bugs.webkit.org/show_bug.cgi?id=149679
 984
 985         Rubber-stamped by Alexey Proskuryakov.
 986
 987         First pass at defining criterion for triggering an iOS build.
 988
 989         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
 990         (_should_file_trigger_build):
 991         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
 992         (ShouldBuildTest):
 993         (ShouldBuildTest.test_should_build):
 994
 995 2015-09-29  Simon Fraser  <simon.fraser@apple.com>
 996
 997         [iOS] Allow tests to generate user gestures for UI testing
 998         https://bugs.webkit.org/show_bug.cgi?id=149653
 999
1000         Reviewed by Tim Horton.
1001
1002         Expose functionality in UIScriptController to allow for testing single- and double-tap,
1003         and to listen for completion of scrolling and zooming in the WKWebView.
1004
1005         Tap generation is done using synthetic IOHIDEvents, via a new HIDEventGenerator class
1006         which hides the complexity of creating these events. Event dispatch is asynchronous.
1007         We detect when the last event has been handled by dispatching a vendor-specific event,
1008         which is detected via -_handleHIDEvent: in our UIApplication subclass.
1009
1010         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: Link with IOKit.
1011         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl: Two new properties
1012         for 'will begin zooming' and 'did end zooming' callbacks, and functions to dispatch
1013         single and double taps.
1014         * WebKitTestRunner/UIScriptContext/UIScriptContext.cpp:
1015         (UIScriptContext::registerCallback): Used to store the callbacks for zooming.
1016         Unlike the "task" callbacks, these are persistent, but we store them in the same hash map.
1017         (UIScriptContext::unregisterCallback):
1018         (UIScriptContext::callbackWithID):
1019         (UIScriptContext::fireCallback):
1020         * WebKitTestRunner/UIScriptContext/UIScriptContext.h:
1021         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
1022         (WTR::UIScriptController::setWillBeginZoomingCallback): Cross-platform code.
1023         (WTR::UIScriptController::willBeginZoomingCallback): Ditto.
1024         (WTR::UIScriptController::setDidEndZoomingCallback):
1025         (WTR::UIScriptController::didEndZoomingCallback):
1026         (WTR::UIScriptController::singleTapAtPoint): Non-iOS stub.
1027         (WTR::UIScriptController::doubleTapAtPoint): Ditto.
1028         (WTR::UIScriptController::platformSetWillBeginZoomingCallback):
1029         (WTR::UIScriptController::platformSetDidEndZoomingCallback):
1030         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
1031         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1032         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h: Properties for the zooming callbacks.
1033         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1034         (-[TestRunnerWKWebView zoomToScale:animated:completionHandler:]): Dispatch the zooming callback.
1035         (-[TestRunnerWKWebView scrollViewWillBeginZooming:withView:]): Ditto.
1036         (-[TestRunnerWKWebView scrollViewDidEndZooming:withView:atScale:]): Ditto.
1037         (-[TestRunnerWKWebView onDidEndZooming:]): Deleted.
1038         * WebKitTestRunner/ios/HIDEventGenerator.h: Copied from Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.h.
1039         * WebKitTestRunner/ios/HIDEventGenerator.m: Added.
1040         (simpleDragCurve):
1041         (calculateNextLocation):
1042         (delayBetweenMove):
1043         (+[HIDEventGenerator sharedHIDEventGenerator]):
1044         (+[HIDEventGenerator nextEventCallbackID]):
1045         (-[HIDEventGenerator init]):
1046         (-[HIDEventGenerator _createIOHIDEventType:]):
1047         (-[HIDEventGenerator _sendHIDEvent:]):
1048         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]):
1049         (-[HIDEventGenerator _updateTouchPoints:count:]):
1050         (-[HIDEventGenerator touchDownAtPoints:touchCount:]):
1051         (-[HIDEventGenerator touchDown:touchCount:]):
1052         (-[HIDEventGenerator touchDown:]):
1053         (-[HIDEventGenerator liftUpAtPoints:touchCount:]):
1054         (-[HIDEventGenerator liftUp:touchCount:]):
1055         (-[HIDEventGenerator liftUp:]):
1056         (-[HIDEventGenerator moveToPoints:touchCount:duration:]):
1057         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
1058         (-[HIDEventGenerator tap:completionBlock:]):
1059         (-[HIDEventGenerator doubleTap:completionBlock:]):
1060         (-[HIDEventGenerator twoFingerTap:completionBlock:]):
1061         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
1062         (-[HIDEventGenerator pinchCloseWithStartPoint:endPoint:duration:completionBlock:]):
1063         (-[HIDEventGenerator pinchOpenWithStartPoint:endPoint:duration:completionBlock:]):
1064         (-[HIDEventGenerator markerEventReceived:]):
1065         * WebKitTestRunner/ios/IOKitSPI.h: Added.
1066         * WebKitTestRunner/ios/UIKitSPI.h: Copied from Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.h.
1067         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1068         (WTR::globalToContentCoordinates):
1069         (WTR::UIScriptController::singleTapAtPoint):
1070         (WTR::UIScriptController::doubleTapAtPoint):
1071         (WTR::UIScriptController::platformSetWillBeginZoomingCallback):
1072         (WTR::UIScriptController::platformSetDidEndZoomingCallback):
1073         * WebKitTestRunner/ios/mainIOS.mm:
1074         (-[WebKitTestRunnerApp _handleHIDEvent:]):
1075
1076 2015-09-30  Dana Burkart  <dburkart@apple.com>
1077
1078         git-add-reviewer should trim trailing spaces/newlines
1079         https://bugs.webkit.org/show_bug.cgi?id=149513
1080
1081         Reviewed by Darin Adler.
1082
1083         * Scripts/git-add-reviewer:
1084         (nonInteractive):
1085
1086 2015-09-30  Eric Carlson  <eric.carlson@apple.com>
1087
1088         REGRESSION(r190262): User media unit test failures after r190262
1089         https://bugs.webkit.org/show_bug.cgi?id=149580
1090
1091         Reviewed by Darin Adler.
1092
1093         * WebKitTestRunner/TestController.cpp:
1094         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Fix parameter
1095           order to WKUserMediaPermissionRequestAllow.
1096
1097 2015-09-30  Daniel Bates  <dabates@apple.com>
1098
1099         Add iOS builders and testers
1100         https://bugs.webkit.org/show_bug.cgi?id=149549
1101
1102         Reviewed by Alexey Proskuryakov.
1103
1104         Adds definitions for 64-bit iOS Simulator release builders and testers and a iOS device
1105         builder that builds universal release binaries for armv7, armv7s and arm64 architectures.
1106
1107         * BuildSlaveSupport/build.webkit.org-config/config.json: Add definitions for builders and testers.
1108         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Update unit tests.
1109
1110 2015-09-30  Timothy Hatcher  <timothy@apple.com>
1111
1112         Give WebKitLauncher the get-task-allow entitlement to allow it to work on El Capitan
1113         https://bugs.webkit.org/show_bug.cgi?id=149674
1114
1115         Reviewed by Lucas Forschler.
1116
1117         * WebKitLauncher/WebKitLauncher.entitlements: Added.
1118         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
1119
1120 2015-09-30  Jason Marcell  <jmarcell@apple.com>
1121
1122         BuildbotQueueView.prototype._appendPendingRevisionCount should skip repositories that don't
1123         have an associated trac instance.
1124         https://bugs.webkit.org/show_bug.cgi?id=149673
1125
1126         Reviewed by Alexey Proskuryakov.
1127
1128         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1129         (BuildbotQueueView.prototype._appendPendingRevisionCount): Skip repositories that don't
1130         have an associated trac instance.
1131
1132 2015-09-30  Daniel Bates  <dabates@apple.com>
1133
1134         Prioritize testing latest build request on iOS test bots
1135         https://bugs.webkit.org/show_bug.cgi?id=149669
1136
1137         Reviewed by Darin Adler.
1138
1139         We should prioritize testing of the latest build request on the iOS test bots
1140         as we do for Mac and Windows test bots.
1141
1142         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1143         (loadBuilderConfig):
1144
1145 2015-09-30  Daniel Bates  <dabates@apple.com>
1146
1147         Add buildbot category for iOS builders and testers
1148         https://bugs.webkit.org/show_bug.cgi?id=149667
1149
1150         Reviewed by Darin Adler.
1151
1152         Group iOS builders and testers under category iOS and add dashboard and console hyperlinks
1153         for iOS to the build.webkit.org home page.
1154
1155         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1156         (loadBuilderConfig):
1157         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
1158
1159 2015-09-30  Daniel Bates  <dabates@apple.com>
1160
1161         Actually fix the Mac builders build after <http://trac.webkit.org/changeset/190219>
1162         (https://bugs.webkit.org/show_bug.cgi?id=149539)
1163
1164         I inadvertently didn't remove the ONLY_ACTIVE_ARCH=NO flag when building on a Mac
1165         in <http://trac.webkit.org/changeset/190351>.
1166
1167         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1168         (CompileWebKit.start):
1169
1170 2015-09-30  Daniel Bates  <dabates@apple.com>
1171
1172         Attempt to fix the Mac builders build after <http://trac.webkit.org/changeset/190219>
1173         (https://bugs.webkit.org/show_bug.cgi?id=149539)
1174
1175         {32, 64}-bit Mac builders should not try to build project {Plugin.64, Plugin.32},
1176         respectively; only pass ONLY_ACTIVE_ARCH=NO when building for iOS.
1177
1178         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1179         (CompileWebKit.start):
1180
1181 2015-09-30  Lucas Forschler  <lforschler@apple.com>
1182
1183         bot210 was configured for a queue instead of bot126.
1184
1185         Unreviewed config.json fix.
1186
1187         * BuildSlaveSupport/build.webkit.org-config/config.json:
1188
1189 2015-09-30  Lucas Forschler  <lforschler@apple.com>
1190
1191         Bring El Capitan buildbot infrastructure online.
1192         https://bugs.webkit.org/show_bug.cgi?id=149605
1193
1194         Reviewed by Darin Adler.
1195
1196         * BuildSlaveSupport/build.webkit.org-config/config.json:
1197
1198 2015-09-30  Tomas Popela  <tpopela@redhat.com>
1199
1200         [GTK] Deprecation warnings in DOMNodeTest
1201         https://bugs.webkit.org/show_bug.cgi?id=149663
1202
1203         After the webkit_dom_document_get_elements_by_tag_name deprecation we
1204         need to update the tests to use webkit_dom_document_query_selector_all
1205         to avoid compilation warnings.
1206
1207         Also add a new test for webkit_dom_document_get_elements_by_tag_name_as_html_collection
1208         (the suggested replacement for the deprecated function).
1209
1210         Reviewed by Carlos Garcia Campos.
1211
1212         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
1213         (WebKitDOMNodeTest::testTagNamesNodeList):
1214         (WebKitDOMNodeTest::testTagNamesHTMLCollection):
1215         (registerTests):
1216         (WebKitDOMNodeTest::testTagNames): Deleted.
1217         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
1218         (prepareDOMForTagNamesTests):
1219         (testWebKitDOMNodeTagNamesNodeList):
1220         (testWebKitDOMNodeTagNamesHTMLCollection):
1221         (beforeAll):
1222         (testWebKitDOMNodeTagNames): Deleted.
1223
1224 2015-09-29  Simon Fraser  <simon.fraser@apple.com>
1225
1226         WebKitTestRunner fails to apply "useFlexibleViewport" when it's specified in a file comment
1227         https://bugs.webkit.org/show_bug.cgi?id=149650
1228
1229         Reviewed by Tim Horton.
1230
1231         TestInvocation::invoke() consulted shouldMakeViewportFlexible(), but that only
1232         looks at the file path, and not the custom options that come from file comments.
1233
1234         Fix by computing TestOptions before making the TestInvocation, and setting them
1235         as const TestInvocation data. This meant changing various call sites to take
1236         the std::string pathOrURL, rather than the TestInvocation itself.
1237
1238         Also initialize TestInvocation with a WKURLRef, rather than a std::string.
1239
1240         * WebKitTestRunner/CMakeLists.txt:
1241         * WebKitTestRunner/TestController.cpp:
1242         (WTR::TestController::ensureViewSupportsOptionsForTest):
1243         (WTR::testPath):
1244         (WTR::createTestURL):
1245         (WTR::updateTestOptionsFromTestHeader):
1246         (WTR::TestController::testOptionsForTest):
1247         (WTR::TestController::updateWebViewSizeForTest):
1248         (WTR::TestController::updateWindowScaleForTest):
1249         (WTR::TestController::runTest):
1250         * WebKitTestRunner/TestController.h:
1251         * WebKitTestRunner/TestInvocation.cpp:
1252         (WTR::TestInvocation::TestInvocation):
1253         (WTR::TestInvocation::invoke):
1254         (WTR::createWKURL): Deleted.
1255         (WTR::TestInvocation::shouldMakeViewportFlexible): Deleted.
1256         (WTR::TestInvocation::shouldUseFixedLayout): Deleted.
1257         * WebKitTestRunner/TestInvocation.h:
1258         (WTR::TestInvocation::options):
1259         * WebKitTestRunner/TestOptions.cpp: Copied from Tools/WebKitTestRunner/TestOptions.h.
1260         (WTR::pathContains):
1261         (WTR::shouldMakeViewportFlexible):
1262         (WTR::shouldUseFixedLayout):
1263         (WTR::isSVGTestPath):
1264         (WTR::isHiDPITestPath):
1265         (WTR::TestOptions::TestOptions):
1266         * WebKitTestRunner/TestOptions.h:
1267         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1268         * WebKitTestRunner/efl/TestControllerEfl.cpp:
1269         (WTR::pathContains):
1270         (WTR::shouldUseFixedLayout):
1271         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
1272         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1273         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
1274         * WebKitTestRunner/ios/TestControllerIOS.mm:
1275         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
1276         * WebKitTestRunner/mac/TestControllerMac.mm:
1277         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
1278
1279 2015-09-29  Aakash Jain  <aakash_jain@apple.com>
1280
1281         Flakiness dashboard should support OS X El Capitan
1282         https://bugs.webkit.org/show_bug.cgi?id=149648
1283
1284         Reviewed by Alexey Proskuryakov.
1285
1286         * QueueStatusServer/app.yaml: We do not need to maintain SVN revision here because of
1287         difference between new appscale and old Google App Engine implementation.
1288         * TestResultServer/app.yaml: Same.
1289         * TestResultServer/static-dashboards/builders.jsonp: Added OSX El Capitan support.
1290
1291 2015-09-29  Daniel Bates  <dabates@apple.com>
1292
1293         configure-xcode-for-ios-development does not work with Xcode 7
1294         https://bugs.webkit.org/show_bug.cgi?id=149640
1295
1296         Reviewed by Alexey Proskuryakov.
1297
1298         When Xcode 7 is installed, running configure-xcode-for-ios-development dies with an error
1299         because it cannot find the Xcode specification files for iOS simulator and device. These
1300         files have moved to a new location in Xcode 7 distribution. Moreover we must add the
1301         relevant definitions to the Xcode 7 specification files directly as opposed to creating
1302         new specification files with the added definitions (as we did in older versions of Xcode)
1303         in order for Xcode 7 to honor these definitions.
1304
1305         * Scripts/configure-xcode-for-ios-development: Sorted forward declarations.
1306         (updateXcodeSpecificationFilesForSDKIfNeeded): Added.
1307         (updateXcode7SpecificationFile): Added.
1308         (createLegacyXcodeSpecificationFilesForSDKIfNeeded): Formerly named createXcodeSpecificationFilesForSDKIfNeeded.
1309         (writeXcodeSpecification): Moved congratulations line to caller so as to write out the
1310         appropriate success message.
1311         (mergeXcodeSpecificationWithSpecificationAndId): Formerly named createXcodeSpecificationFromSpecificationAndId.
1312         (createXcodeSpecificationFilesForSDKIfNeeded): Deleted.
1313         (createXcodeSpecificationFromSpecificationAndId): Deleted.
1314
1315 2015-09-29  Brent Fulgham  <bfulgham@apple.com>
1316
1317         [Win] Allow 'prepare-ChangeLog' to be used without Cygwin
1318         https://bugs.webkit.org/show_bug.cgi?id=149639
1319
1320         Reviewed by Alex Christensen.
1321
1322         * Scripts/VCSUtils.pm:
1323         (exitStatus): Use 'isWindows()' method.
1324         (isSVNVersion16OrNewer): 'eval' is not needed here, and just causes
1325         an error. This method could probably just go away.
1326         (normalizePath): Leave Windows (or Unix) paths as platform paths, rather than
1327         always changing to Unix style.
1328         (unixPath): Added. Needed so Windows can always show a Unix path in the
1329         ChangeLog file.
1330         (changeLogName): Work around the fact that 'getpwuid' is not available on
1331         a pure Windows build of Perl.
1332         * Scripts/prepare-ChangeLog:
1333         (generateFunctionLists): Normalize path received from 'svn' in case it's a Unix
1334         path on Windows.
1335         (svnUpdateCommand): Added helper function. Needed because Windows Perl does not
1336         support using arrays for 'open' arguments.
1337         (resolveChangeLogsPath): Ditto.
1338         (resolveConflictedChangeLogs): Use new helper functions.
1339         (generateNewChangeLogs): Force Windows to use Unix paths in ChangeLog output.
1340         (diffCommand): Use double-quotes for paths, since Windows doesn't understand single
1341         quotes. Unix systems are happy either way.
1342         (statusCommand): Ditto.
1343         * Scripts/webkitdirs.pm:
1344         (launcherName): Drive-by fix. WinLauncher was renamed to MiniBrowser some time ago.
1345
1346 2015-09-29  Brent Fulgham  <bfulgham@apple.com>
1347
1348         [Win] Unreviewed 64-bit build fix after switch to CMake.
1349
1350         * Scripts/webkitdirs.pm:
1351         (determineIsWin64FromArchitecture): Added.
1352
1353 2015-09-16  Carlos Garcia Campos  <cgarcia@igalia.com>
1354
1355         printing does not use minimum page zoom factor
1356         https://bugs.webkit.org/show_bug.cgi?id=108507
1357
1358         Reviewed by Darin Adler.
1359
1360         WebKitTestRunner always takes the snapshots from the UI process
1361         (expect for IOS), so in the case of printing, the layout in the
1362         web view is not the expected one. When printing, we need to take
1363         the snapshot in the web process and ensure it's rendered with a
1364         PrintContext.
1365
1366         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1367         (WTR::InjectedBundlePage::dump): When dumping pixels, pass
1368         kWKSnapshotOptionsPrinting option to
1369         WKBundlePageCreateSnapshotWithOptions() when printing.
1370
1371 2015-09-28  Carlos Garcia Campos  <cgarcia@igalia.com>
1372
1373         [WTR] Pixel tests generate the snapshots twice in Web and UI processes
1374         https://bugs.webkit.org/show_bug.cgi?id=149595
1375
1376         Reviewed by Tim Horton.
1377
1378         All ports except IOS implement
1379         PlatformWebView::windowSnapshotImage() to generate the snapshot
1380         for the pixel tests in the UI process. But we are still generating
1381         a snapshot for pixel tests in the Web process too, that is passed
1382         to the UI process but ignored.
1383         Whether a pixel result is needed or not, is only known by the web
1384         process depending on whether the test called dumpAsText with
1385         dumpPixels == true or not. Since the pixels are now dump in the UI
1386         process, we need to pass that information to the UI process when
1387         the test is done. For that we set a PixelResultIsPending bool
1388         parameter to the Done message, and we only add the PixelResult
1389         when UI process doesn't need to generate the pixels dump.
1390
1391         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1392         (WTR::InjectedBundle::didReceiveMessageToPage): Set
1393         m_pixelResultIsPending to false on reset.
1394         (WTR::InjectedBundle::done): Add PixelResultIsPending parameter to the
1395         Done message, and set the PixelResult if m_pixelResultIsPending is false.
1396         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1397         (WTR::InjectedBundle::setPixelResult): Set m_pixelResultIsPending to false.
1398         (WTR::InjectedBundle::setNeedsPixelResult): Set m_pixelResultIsPending.
1399         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1400         (WTR::InjectedBundlePage::dump): Only create a snapshot for IOS
1401         port.
1402         * WebKitTestRunner/TestInvocation.cpp:
1403         (WTR::TestInvocation::dumpResults): Use either the pixel result
1404         from the web process or generate a pixel result from the web view
1405         if need it.
1406         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1407         * WebKitTestRunner/TestInvocation.h: Add SnapshotResultType enum
1408         parameter to dumpPixelsAndCompareWithExpected, since the snapshot
1409         is created by the caller now, but the CG implementation needs to
1410         know if it's a Web or UI process snapshot.
1411         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
1412         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
1413         cairo surface for the given image.
1414         * WebKitTestRunner/cg/TestInvocationCG.cpp:
1415         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
1416         CGContext for the given image.
1417
1418 2015-09-28  Dean Johnson  <dean_johnson@apple.com>
1419
1420         Fix JS errors on dashboard metrics page
1421         https://bugs.webkit.org/show_bug.cgi?id=149608
1422
1423         Reviewed by Alexey Proskuryakov.
1424
1425         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Updated to use Settings.
1426         (initPlatformsByFamily):
1427         (updateHiddenPlatforms):
1428         (parsePlatformFamily): Deleted.
1429         (updateToggleButtons): Deleted.
1430         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
1431         (updateHiddenPlatforms): Added to remove errors.
1432         (initPlatformsByFamily): Added to remove errors.
1433         (unhiddenQueues): Updated to use Settings.
1434         (documentReady): Added logic to add toggle buttons to the settings menu.
1435         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
1436         (Settings.prototype.parsePlatformFamily): Moved duplicate logic from Main.js and
1437         MetricsMain.js to Settings.
1438         (Settings.prototype.updateToggleButtons): Moved duplicate logic from Main.js and
1439         MetricsMain.js to Settings.
1440         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
1441         (QueueView.prototype._updateHiddenState): Updated to use Settings.
1442
1443 2015-09-28  Aakash Jain  <aakash_jain@apple.com>
1444
1445         Appscale query fails because of missing index
1446         https://bugs.webkit.org/show_bug.cgi?id=149609
1447
1448         Reviewed by Darin Adler.
1449
1450         * QueueStatusServer/index.yaml: Added the required index.
1451
1452 2015-09-28  Brent Fulgham  <bfulgham@apple.com>
1453
1454         [Win] Fix the 64-bit build after switch to cmake.
1455
1456         Reviewed by Alex Christensen.
1457
1458         * Scripts/webkitdirs.pm:
1459         (generateBuildSystemFromCMakeProject): Use correct arguments for cmake to
1460         run a 64-bit build.
1461
1462 2015-09-28  Brent Fulgham  <bfulgham@apple.com>
1463
1464         [Win] Allow Windows to run test-webkitpy without Cygwin
1465         https://bugs.webkit.org/show_bug.cgi?id=149602
1466
1467         Reviewed by Alex Christensen.
1468
1469         These changes mostly shift from hard-coded paths using UNIX-style
1470         separators to Python's "os.path.join" syntax that uses the correct
1471         path separator for each platform.
1472
1473         * Scripts/webkitpy/common/system/path.py:
1474         (cygpath): Don't pass paths through Cygpath on native Windows.
1475         * Scripts/webkitpy/port/win.py:
1476         (WinPort._path_to_apache): Use os.path.join.
1477         (WinPort._ntsd_location): Support 64-bit environment (ProgramW6432 doesn't exist
1478         in 64-bit environments).
1479         * Scripts/webkitpy/style/checker.py: Use os.path.join.
1480         * Scripts/webkitpy/style/checker_unittest.py:
1481         (GlobalVariablesTest.test_path_rules_specifier.assertNoCheck): Use os.path.join.
1482         (GlobalVariablesTest.test_path_rules_specifier): Ditto.
1483         (GlobalVariablesTest): Ditto.
1484         (GlobalVariablesTest.test_max_reports_per_category): Ditto.
1485         (CheckerDispatcherSkipTest.test_should_skip_with_warning): Ditto.
1486         (CheckerDispatcherDispatchTest.test_js_paths): Ditto.
1487         (CheckerDispatcherDispatchTest.test_json_paths): Ditto.
1488         (CheckerDispatcherDispatchTest.test_python_paths): Ditto.
1489         (CheckerDispatcherDispatchTest.test_text_paths): Ditto.
1490         (CheckerDispatcherDispatchTest.test_xml_paths): Ditto.
1491         (StyleProcessor_CodeCoverageTest._create_carriage_checker_class): Ditto.
1492         (StyleProcessor_CodeCoverageTest): Ditto.
1493         (StyleProcessor_CodeCoverageTest.test_should_process__skip_without_warning): Ditto.
1494         (StyleProcessor_CodeCoverageTest.test_should_process__skip_with_warning): Ditto.
1495         (StyleProcessor_CodeCoverageTest.test_should_process__true_result): Ditto.
1496         * Scripts/webkitpy/w3c/test_parser_unittest.py: Uses os.path.join rather than
1497         manual string concatenation of paths.
1498
1499 2015-09-28  Csaba Osztrogonác  <ossy@webkit.org>
1500
1501         Add bugzilla addresses of committers to contributors.json
1502         https://bugs.webkit.org/show_bug.cgi?id=149520
1503
1504         Reviewed by Darin Adler.
1505
1506         * Scripts/webkitpy/common/config/contributors.json:
1507
1508 2015-09-28  Csaba Osztrogonác  <ossy@webkit.org>
1509
1510         validate-committer-lists -b shouldn't need edituser privileges
1511         https://bugs.webkit.org/show_bug.cgi?id=149519
1512
1513         Reviewed by Darin Adler.
1514
1515         * Scripts/validate-committer-lists:
1516         (CommitterListBugzillaChecker._has_invalid_bugzilla_email):
1517         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1518         (BugzillaQueries.is_invalid_bugzilla_email):
1519         (BugzillaQueries): Deleted.
1520         (BugzillaQueries.fetch_logins_matching_substring): Deleted.
1521
1522 2015-09-26  Carlos Garcia Campos  <cgarcia@igalia.com>
1523
1524         Unreviewed. Gardening: skip media stream tests failing after r190262.
1525
1526         * Scripts/run-gtk-tests:
1527         (TestRunner):
1528
1529 2015-09-25  Alexey Proskuryakov  <ap@apple.com>
1530
1531         [Mac] USE_INTERNAL_SDK is used undefined in tools projects
1532         https://bugs.webkit.org/show_bug.cgi?id=149571
1533
1534         Reviewed by Dan Bernstein.
1535
1536         Use the same pattern as in Source directory configurations (so, also get rid of AspenFamily.xcconfig).
1537
1538         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1539         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1540         * LayoutTestRelay/Configurations/Base.xcconfig:
1541         * MiniBrowser/Configurations/Base.xcconfig:
1542         * MiniBrowser/Configurations/DebugRelease.xcconfig:
1543         * TestWebKitAPI/Configurations/Base.xcconfig:
1544         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
1545         * WebEditingTester/Configurations/Base.xcconfig:
1546         * WebEditingTester/Configurations/DebugRelease.xcconfig:
1547         * WebKitTestRunner/Configurations/Base.xcconfig:
1548         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1549         * WebKitTestRunner/iOS.xcconfig: Removed.
1550
1551 2015-09-25  Eric Carlson  <eric.carlson@apple.com>
1552
1553         Clean up user media request internal API
1554         https://bugs.webkit.org/show_bug.cgi?id=149527
1555
1556         Reviewed by Tim Horton.
1557
1558         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
1559         (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack): Update for API changes.
1560
1561         * WebKitTestRunner/TestController.cpp:
1562         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Ditto.
1563
1564 2015-09-25  Simon Fraser  <simon.fraser@apple.com>
1565
1566         [iOS WK2] Add viewport tests and fix runUIScript() timing issues
1567         https://bugs.webkit.org/show_bug.cgi?id=149577
1568
1569         Reviewed by Tim Horton.
1570
1571         When calling testRunner.runUIScript() from a page load event, the script could run
1572         in the UI process before the current remote layer tree transaction had been handled
1573         there. This meant that runUIScript() could query state which was about to change.
1574
1575         Fix by delaying the execution of the UI script until a layer tree transaction has
1576         been handled by the UI process, leveraging the existing DrawingAreaProxy::dispatchAfterEnsuringDrawing().
1577
1578         * WebKitTestRunner/TestInvocation.cpp:
1579         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1580         (WTR::TestInvocation::runUISideScriptAfterUpdateCallback):
1581         * WebKitTestRunner/TestInvocation.h:
1582
1583 2015-09-25  Alexey Proskuryakov  <ap@apple.com>
1584
1585         [Mac] Media tests start to time out after a few days of bot uptime
1586         https://bugs.webkit.org/show_bug.cgi?id=149468
1587
1588         Reviewed by Darin Adler.
1589
1590         Delete cache directory in addition to the temporary one. Don't delete /private/tmp/MediaCache,
1591         as it's not longer used by tests. Set TMPDIR and DIRHELPER_USER_DIR_SUFFIX to make
1592         all temporary and cache files go to a custom location.
1593
1594         * Scripts/webkitpy/port/base.py:
1595         * Scripts/webkitpy/port/driver.py:
1596         * Scripts/webkitpy/port/mac.py:
1597         * Scripts/webkitpy/port/win.py:
1598         (WinPort._driver_tempdir_for_environment): Deleted unused function.
1599
1600 2015-09-25  Dan Bernstein  <mitz@apple.com>
1601
1602         Removed MiniBrowser.entitlements.
1603
1604         Rubber-stamped by Anders Carlsson.
1605
1606         The entitlements weren’t used anyway.
1607
1608         * MiniBrowser/MiniBrowser.entitlements: Removed.
1609         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
1610
1611 2015-09-24  Daniel Bates  <dabates@apple.com>
1612
1613         Add WebKitSystemInterface for iOS 9.0
1614         https://bugs.webkit.org/show_bug.cgi?id=149550
1615
1616         Rubber-stamped by Alexey Proskuryakov.
1617
1618         * Scripts/copy-webkitlibraries-to-product-directory:
1619
1620 2015-09-24  Daniel Bates  <dabates@apple.com>
1621
1622         Support building for arbitrary architectures
1623         https://bugs.webkit.org/show_bug.cgi?id=149539
1624
1625         Reviewed by Alexey Proskuryakov.
1626
1627         Teach buildbot to pass the architectures associated with the builder to build-webkit
1628         when building on OS X and iOS. As a side effect of this change we now support building
1629         universal binaries when multiples architectures are specified.
1630
1631         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1632         (CompileWebKit.start):
1633
1634 2015-09-24  Daniel Bates  <dabates@apple.com>
1635
1636         Fix the build after <http://trac.webkit.org/changeset/190212>
1637         (http://trac.webkit.org/changeset/190212)
1638
1639         I inadvertently did not remove the fullPlatform argument from one of the callers of archiveBuiltProduct().
1640
1641         * BuildSlaveSupport/built-product-archive:
1642         (main):
1643
1644 2015-09-24  Daniel Bates  <dabates@apple.com>
1645
1646         Support running unit tests on iOS Simulator test bot
1647         https://bugs.webkit.org/show_bug.cgi?id=149536
1648
1649         Reviewed by Alexey Proskuryakov.
1650
1651         Implements support for running unit tests on a iOS test bot. At the time of writing,
1652         the script run-api-tests supports running unit tests on Mac, Windows and iOS Simulator.
1653
1654         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1655         (RunUnitTests.start): Append appropriate command line flag when invoking script run-api-tests.
1656         (TestFactory.__init__): Add step RunUnitTests when the test bot is for the iOS Simulator platform.
1657
1658 2015-09-24  Daniel Bates  <dabates@apple.com>
1659
1660         Add support infrastructure for OpenSource iOS builders and testers
1661         https://bugs.webkit.org/show_bug.cgi?id=149534
1662
1663         Reviewed by Darin Adler.
1664
1665         Towards setting up OpenSource iOS build bots, teach buildbot and its support
1666         scripts about iOS.
1667
1668         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1669         (appendCustomBuildFlags): Require the caller to pass parameter fullPlatform and append
1670         --ios-simulator or --device for a builder/tester whose full platform name begins with
1671         "ios-simulator" or "ios", respectively.
1672         (RunJavaScriptCoreTests.start): Pass the full platform name to appendCustomBuildFlags().
1673         * BuildSlaveSupport/built-product-archive:
1674         (main): Pass the full platform name to determineWebKitBuildDirectory().
1675         (determineWebKitBuildDirectory): Call script webkit-build-directory with the appropriate
1676         command line flag when building for iOS.
1677         (archiveBuiltProduct): Use the same logic for iOS as we do for Mac. Also, remove unused
1678         parameter fullPlatform. This parameter was originally added in r125066 to support the
1679         Chromium Android port, which has since been removed from the OpenSource WebKit Project.
1680         (extractBuiltProduct): Use the same logic for iOS as we do for Mac.
1681         * BuildSlaveSupport/clean-build:
1682         (main): Call script webkit-build-directory with the appropriate command line flag when
1683         building for iOS.
1684         * BuildSlaveSupport/delete-stale-build-files:
1685         (main): Use the same logic for iOS as we do for Mac.
1686         (webkitBuildDirectory): Call script webkit-build-directory with the appropriate command line
1687         flag when building for iOS.
1688         * BuildSlaveSupport/test-result-archive:
1689         (archiveTestResults): Use the same logic for iOS as we do for Mac.
1690
1691 2015-09-24  Daniel Bates  <dabates@apple.com>
1692
1693         Remove Chromium-specific changes to script built-product-archive
1694         https://bugs.webkit.org/show_bug.cgi?id=149530
1695
1696         Rubber-stamped by Csaba Osztrogonác.
1697
1698         Reverts changes made in r113074 and r113067 to support Chromium testers. The
1699         Chromium code has long since been removed from the OpenSource WebKit Project.
1700
1701         * BuildSlaveSupport/built-product-archive:
1702         (createZipManually):
1703         (createZip):
1704         (archiveBuiltProduct):
1705
1706 2015-09-24  Dan Bernstein  <mitz@apple.com>
1707
1708         Build fix.
1709
1710         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
1711
1712 2015-09-24  Mark Lam  <mark.lam@apple.com>
1713
1714         Unreviewed. Make Lucas Forschler a WebKit reviewer.
1715
1716         * Scripts/webkitpy/common/config/contributors.json:
1717
1718 2015-09-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1719
1720         Unreviewed. Fix GObject DOM API breaks after r190120.
1721
1722         Bring back code removed in r169931 to handle documentation of
1723         deleted classes.
1724
1725         * gtk/webkitdom.py:
1726         (WebKitDOMDocGenerator):
1727         (WebKitDOMDocGenerator.write_deleted_classes):
1728         (WebKitDOMDocGenerator.generate):
1729         (write_deleted_classes):
1730         (WebKitDOMDocGeneratorSections._deleted_class):
1731         (WebKitDOMDocGeneratorSections._deleted_class.in):
1732         (WebKitDOMDocGeneratorSections.write_deleted_classes):
1733         (WebKitDOMDocGeneratorSections.write_deleted_classes.with):
1734
1735 2015-09-23  Myles C. Maxfield  <mmaxfield@apple.com>
1736
1737         [Cocoa] [Font Features] Implement font-variant-*
1738         https://bugs.webkit.org/show_bug.cgi?id=148413
1739
1740         Reviewed by Darin Adler.
1741
1742         Update test font to use "lnum" feature.
1743
1744         * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
1745         (Generator::appendGSUBTable):
1746
1747 2015-09-22  Andy Estes  <aestes@apple.com>
1748
1749         ContentFiltering.AllowDownloadAfterAddData is very flaky
1750         https://bugs.webkit.org/show_bug.cgi?id=148885
1751         <rdar://problem/22729563>
1752
1753         Reviewed by Alexey Proskuryakov.
1754
1755         The AllowDownload* tests were relying on -_downloadDidStart: being called before -webView:didFinishNavigation:,
1756         but there is no guarantee of this. For tests that should allow a download, spin the runloop until
1757         -_downloadDidStart: is called. The test will now timeout on failure, but will no longer produce false failures.
1758
1759         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
1760         (downloadTest):
1761
1762 2015-09-22  Alexey Proskuryakov  <ap@apple.com>
1763
1764         Mavericks: Media tests start to time out after a few days of bot uptime
1765         https://bugs.webkit.org/show_bug.cgi?id=149468
1766
1767         Reviewed by Chris Dumez.
1768
1769         * Scripts/webkitpy/port/base.py:
1770         * Scripts/webkitpy/port/driver.py:
1771         * Scripts/webkitpy/port/mac.py:
1772
1773 2015-09-22  Nan Wang  <n_wang@apple.com>
1774
1775         Unreviewed, add myself to the committers list.
1776
1777         * Scripts/webkitpy/common/config/contributors.json:
1778
1779 2015-09-21  Simon Fraser  <simon.fraser@apple.com>
1780
1781         Remove 'nullable' to fix older iOS builds.
1782
1783         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1784         (-[TestRunnerWKWebView scrollViewDidEndZooming:withView:atScale:]):
1785
1786 2015-09-21  Brent Fulgham  <bfulgham@apple.com>
1787
1788         [Win] Show tiled drawing debug overlay on Windows
1789         https://bugs.webkit.org/show_bug.cgi?id=149426
1790
1791         Reviewed by Dean Jackson.
1792
1793         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc: Add new menu option.
1794         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h: Ditto.
1795         * MiniBrowser/win/Common.cpp:
1796         (::ToggleMenuItem): Recognize new menu item and toggle the 'showTiledScrollingIndicator'
1797         flag if needed.
1798         * MiniBrowser/win/MiniBrowser.h: Update to use new IWebPreferencesPrivate3 class.
1799
1800 2015-09-21  Brent Fulgham  <bfulgham@apple.com>
1801
1802         [Win] Use command-line argument to launch in regular or High DPI mode.
1803         https://bugs.webkit.org/show_bug.cgi?id=149417
1804
1805         Reviewed by Dean Jackson.
1806
1807         * MiniBrowser/win/Common.cpp:
1808         (parseCommandLine): Ignore the '--highDPI' argument. It's used at the
1809         very start of execution, before the MiniBrowser.dll is loaded.
1810         * win/DLLLauncher/DLLLauncherMain.cpp:
1811         (shouldUseHighDPI): Check for '--highDPI', and use this mode if
1812         present. On WinCairo, always use High DPI.
1813
1814 2015-09-21  Ryosuke Niwa  <rniwa@webkit.org>
1815
1816         32-bit Mac build fix attempt after r190065.
1817
1818         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1819
1820 2015-09-21  Alexey Proskuryakov  <ap@apple.com>
1821
1822         [OS X] Update for Xcode 7.0 on Yosemite
1823         https://bugs.webkit.org/show_bug.cgi?id=149389
1824
1825         Reviewed by Dan Bernstein.
1826
1827         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
1828         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h:
1829         Removed unneeded declarations - conforming to a protocol is sufficient.
1830
1831         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
1832         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm:
1833         Changed the definitions to be compiled whenever the SDK requires it (so we will have
1834         dead code compiled in when building for 10.10 with 10.11 SDK, somewhat unfortunately).
1835
1836 2015-09-21  Simon Fraser  <simon.fraser@apple.com>
1837
1838         Add the ability for tests to run script in the UI process in WebKitTestRunner
1839         https://bugs.webkit.org/show_bug.cgi?id=149356
1840
1841         Reviewed by Tim Horton.
1842
1843         This change adds testRunner.runUIScript(script, callback), which allows a test
1844         to execute script in a JSContext which runs in the UI process. That context
1845         has bindings exposed through the UIScriptController interface; currently one test
1846         function, and some iOS-specific functions are included. UIScriptController can be
1847         async with a callback, and runUIScript() itself is asynchronous. When the UI
1848         script is complete, it calls uiController.uiScriptComplete(result), where 'result'
1849         is a string passed back to the web process, and given to the runUIScript()
1850         callback function.
1851
1852         Thanks to Gyuyoung Kim for help with the Gtk/Efl build.
1853
1854         * WebKitTestRunner/DerivedSources.make: Build UIScriptController.idl.
1855         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Add runUIScript().
1856         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1857         (WTR::InjectedBundle::didReceiveMessageToPage): When the UI-side script is
1858         complete, call back into TestRunner.
1859         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1860         (WTR::nextUIScriptCallbackID):
1861         (WTR::TestRunner::runUIScript): Post a message to the injected bundle to run the UI script.
1862         (WTR::TestRunner::runUIScriptCallback): When the UI script is done, execute its callback function.
1863         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1864         * WebKitTestRunner/PlatformWebView.h:
1865         * WebKitTestRunner/TestController.cpp:
1866         (WTR::updateTestOptionsFromTestHeader):
1867         (WTR::TestController::testOptionsForTest): Support "useFlexibleViewport" as a test argument.
1868         (WTR::shouldUseFixedLayout): Deleted. Moved to a TestInvocation function.
1869         * WebKitTestRunner/TestInvocation.cpp:
1870         (WTR::TestInvocation::shouldUseFixedLayout):
1871         (WTR::TestInvocation::shouldUseThreadedScrolling):
1872         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1873         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1874         (WTR::TestInvocation::runUISideScript): Run the UI-side script!
1875         (WTR::TestInvocation::uiScriptDidComplete): Send a message back to the injected bundle.
1876         * WebKitTestRunner/TestInvocation.h:
1877         * WebKitTestRunner/TestOptions.h:
1878         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1879         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1880         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h: Copied from Tools/WebKitTestRunner/TestOptions.h.
1881         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm: Added.
1882         (-[TestRunnerWKWebView dragImage:at:offset:event:pasteboard:source:slideBack:]):
1883         (-[TestRunnerWKWebView zoomToScale:animated:completionHandler:]):
1884         (-[TestRunnerWKWebView scrollViewDidEndZooming:withView:atScale:]):
1885         (-[TestRunnerWKWebView onDidEndZooming:]): Allow a test to hook into the end of zooming.
1886         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1887         (WTR::PlatformWebView::PlatformWebView): Make a TestRunnerWKWebView on iOS.
1888         * WebKitTestRunner/ios/UIScriptControllerIOS.mm: Added.
1889         (WTR::UIScriptController::doAsyncTask):
1890         (WTR::UIScriptController::zoomToScale):
1891         (WTR::UIScriptController::zoomScale):
1892         (WTR::UIScriptController::minimumZoomScale):
1893         (WTR::UIScriptController::maximumZoomScale):
1894         (WTR::UIScriptController::contentVisibleRect):
1895         * WebKitTestRunner/mac/EventSenderProxy.mm:
1896         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1897         (-[TestRunnerWKWebView dragImage:at:offset:event:pasteboard:source:slideBack:]): Deleted.
1898         * WebKitTestRunner/mac/TestControllerMac.mm:
1899         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
1900         (WTR::shouldUseThreadedScrolling): Deleted. Moved to TestInvocation.
1901         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h:
1902         * WebKitTestRunner/uiscriptcontext/UIScriptContext.cpp: Added. Owns the JS context in the UI process.
1903         (UIScriptContext::UIScriptContext):
1904         (UIScriptContext::~UIScriptContext):
1905         (UIScriptContext::runUIScript): Entrypoint to running the UI script. If the script didn't do anything
1906         asynchronous, call the callback.
1907         (UIScriptContext::nextTaskCallbackID):
1908         (UIScriptContext::prepareForAsyncTask): Do setup for one async task (i.e. a UIScriptController function
1909         that has a callback). Has to store the callbackID of the script, so code called from the completion
1910         callback knows which UI script invoked it.
1911         (UIScriptContext::asyncTaskComplete): Called when one task is finished.
1912         (UIScriptContext::uiScriptComplete):
1913         (UIScriptContext::objectFromRect): Make a JS object from a rect.
1914         * WebKitTestRunner/uiscriptcontext/UIScriptContext.h: Copied from Tools/WebKitTestRunner/TestOptions.h.
1915         (WTR::UIScriptContext::hasOutstandingAsyncTasks):
1916         * WebKitTestRunner/uiscriptcontext/UIScriptController.cpp: Copied from Tools/WebKitTestRunner/TestOptions.h.
1917         (WTR::UIScriptController::UIScriptController):
1918         (WTR::UIScriptController::makeWindowObject):
1919         (WTR::UIScriptController::wrapperClass):
1920         (WTR::UIScriptController::doAsyncTask):
1921         (WTR::UIScriptController::zoomToScale):
1922         (WTR::UIScriptController::zoomScale):
1923         (WTR::UIScriptController::minimumZoomScale):
1924         (WTR::UIScriptController::maximumZoomScale):
1925         (WTR::UIScriptController::contentVisibleRect):
1926         (WTR::UIScriptController::uiScriptComplete):
1927         * WebKitTestRunner/uiscriptcontext/UIScriptController.h: Copied from Tools/WebKitTestRunner/TestOptions.h.
1928         (WTR::UIScriptController::create):
1929         * WebKitTestRunner/uiscriptcontext/bindings/UIScriptController.idl: Copied from Tools/WebKitTestRunner/TestOptions.h.
1930
1931 2015-09-21  Tim Horton  <timothy_horton@apple.com>
1932
1933         Turn on threaded scrolling by default in the tests
1934         https://bugs.webkit.org/show_bug.cgi?id=149377
1935
1936         Reviewed by Simon Fraser.
1937
1938         * WebKitTestRunner/mac/TestControllerMac.mm:
1939         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
1940         (WTR::shouldUseThreadedScrolling): Deleted.
1941         Turn on threaded scrolling by default.
1942
1943 2015-09-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1944
1945         [GTK] run-gtk-tests doesn't provide feedback about crashing google tests
1946         https://bugs.webkit.org/show_bug.cgi?id=149252
1947
1948         Reviewed by Darin Adler.
1949
1950         In case of glib tests the test runner notifies about tests
1951         crashing, but for google tests we don't get any feedback, which
1952         means that in case of a test crashing we get a list of **PASS**
1953         messages and at the summary we are notified that the test suite
1954         has failed, but it's impossible to know which test cases have failed.
1955
1956         * Scripts/run-gtk-tests:
1957         (TestRunner._run_google_test): Add a **CRASH** message if test
1958         case crashed.
1959
1960 2015-09-20  Alexey Proskuryakov  <ap@apple.com>
1961
1962         WebKitTestRunner can leak user content script results between tests
1963         https://bugs.webkit.org/show_bug.cgi?id=149391
1964
1965         Reviewed by Sam Weinig.
1966
1967         Move WKBundlePageRemoveAllUserContent call so that it's executed before loading
1968         about:blank, and thus about:blank doesn't have unintended side effects.
1969
1970         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1971         (WTR::InjectedBundle::beginTesting):
1972         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1973         (WTR::InjectedBundlePage::resetAfterTest):
1974
1975 2015-09-20  Alexey Proskuryakov  <ap@apple.com>
1976
1977         [Mac, iOS] AccessibilityController doesn't uninstall global notification handler
1978         https://bugs.webkit.org/show_bug.cgi?id=149384
1979
1980         Reviewed by Chris Fleizach.
1981
1982         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
1983         (AccessibilityController::addNotificationListener): Fixed a leak, and cleaned up the code.
1984         (AccessibilityController::platformResetToConsistentState): Actually remove the handler,
1985         regardless of whether someone else holds a reference (we also call -stopListening in
1986         -dealloc).
1987
1988         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
1989         (AccessibilityController::platformResetToConsistentState):
1990         (AccessibilityController::addNotificationListener):
1991         Ditto.
1992
1993 2015-09-20  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1994
1995         Remove XHR_TIMEOUT compilation guard
1996         https://bugs.webkit.org/show_bug.cgi?id=149260
1997
1998         Reviewed by Benjamin Poulain.
1999
2000         * Scripts/webkitperl/FeatureList.pm:
2001
2002 2015-09-19  Dan Bernstein  <mitz@apple.com>
2003
2004         Attempted build fix.
2005
2006         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
2007
2008 2015-09-18  Commit Queue  <commit-queue@webkit.org>
2009
2010         Unreviewed, rolling out r189908.
2011         https://bugs.webkit.org/show_bug.cgi?id=149368
2012
2013         Broke run-webkit-tests --pixel (Requested by ap on #webkit).
2014
2015         Reverted changeset:
2016
2017         "printing does not use minimum page zoom factor"
2018         https://bugs.webkit.org/show_bug.cgi?id=108507
2019         http://trac.webkit.org/changeset/189908
2020
2021 2015-09-18  Andy Estes  <aestes@apple.com>
2022
2023         [iOS] did{Start,Finish}LoadForQuickLookDocumentInMainFrame is never called on WKNavigationDelegate
2024         https://bugs.webkit.org/show_bug.cgi?id=149360
2025
2026         Reviewed by Tim Horton.
2027
2028         Added an API test.
2029
2030         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2031         * TestWebKitAPI/Tests/WebKit2Cocoa/QuickLook.mm: Added.
2032         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
2033         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
2034         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]):
2035         (TEST):
2036         * TestWebKitAPI/ios/pages.pages: Added.
2037
2038 2015-09-18  Nan Wang  <n_wang@apple.com>
2039
2040         AX: Implement ARIA 1.1 @aria-current on iOS
2041         https://bugs.webkit.org/show_bug.cgi?id=149297
2042
2043         Reviewed by Chris Fleizach.
2044
2045         Added support to test aria-current on iOS.
2046
2047         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2048         (AccessibilityUIElement::stringAttributeValue):
2049         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2050         (WTR::AccessibilityUIElement::stringAttributeValue):
2051
2052 2015-09-18  Alexey Proskuryakov  <ap@apple.com>
2053
2054         iOS WebKitTestRunner frequently crashes in WKContextGetIconDatabase
2055         https://bugs.webkit.org/show_bug.cgi?id=149352
2056
2057         Reviewed by Simon Fraser.
2058
2059         * WebKitTestRunner/TestController.cpp: (WTR::TestController::~TestController):
2060         m_context can be null. This may indicate a bug in webkitpy too, but
2061         WebKitTestRunner should handle this situation nicely, there is nothing intrinsically
2062         wrong with opening and immediately closing it.
2063
2064 2015-09-18  Daniel Bates  <dabates@apple.com>
2065
2066         isGitSVNDirectory() returns true when Git is not installed
2067         https://bugs.webkit.org/show_bug.cgi?id=149351
2068
2069         Reviewed by Alexey Proskuryakov.
2070
2071         Fixes an issue where VCSUtils::isGitSVNDirectory() returns true for any arbitrary directory if
2072         Git is not installed on the machine.
2073
2074         * Scripts/VCSUtils.pm:
2075         (isGitSVNDirectory): Ensure that `git config --get svn-remote.svn.fetch 2>& 1` exits with
2076         status code 0 (success).
2077
2078 2015-09-18  Alex Christensen  <achristensen@webkit.org>
2079
2080         Prevent build-webkit from building four times on Windows
2081         https://bugs.webkit.org/show_bug.cgi?id=149336
2082
2083         Reviewed by Brent Fulgham.
2084
2085         * Scripts/build-webkit:
2086         Move the Windows code out of the for loop iterating over each subdirectory to be build.
2087         They're built all at once.
2088         * Scripts/webkitdirs.pm:
2089         (buildVisualStudioProject):
2090         (cmakeGeneratedBuildfile):
2091         Don't generate the Visual Studio solution if it already exists.
2092         It will run CMake again if necessary.
2093
2094 2015-09-17  Simon Fraser  <simon.fraser@apple.com>
2095
2096         [iOS WK2] WTR fails to set the key window in the UIKit sense
2097         https://bugs.webkit.org/show_bug.cgi?id=149325
2098
2099         Reviewed by Tim Horton.
2100
2101         -[WebKitTestRunnerWindow isKeyWindow] just returned _platformWebView->windowIsKey().
2102         This causes UIKit to bypass code that actually sets the key window, resulting in
2103         [UIAppliation sharedApplication].keyWindow always being nil.
2104
2105         Fix by PlatformWebView::setWindowIsKey() actually call -makeKeyWindow, and having
2106         -[WebKitTestRunnerWindow isKeyWindow] call super.
2107
2108         * WebKitTestRunner/PlatformWebView.h:
2109         (WTR::PlatformWebView::setWindowIsKey): Deleted.
2110         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2111         (WTR::PlatformWebView::setWindowIsKey):
2112         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2113         (WTR::PlatformWebView::setWindowIsKey):
2114         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2115         (-[WebKitTestRunnerWindow isKeyWindow]):
2116         (WTR::PlatformWebView::PlatformWebView):
2117         (WTR::PlatformWebView::~PlatformWebView):
2118         (WTR::PlatformWebView::setWindowIsKey):
2119         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2120         (WTR::PlatformWebView::setWindowIsKey):
2121
2122 2015-09-17  Simon Fraser  <simon.fraser@apple.com>
2123
2124         [iOS WK2] When loading viewport tests, use the normal web page viewport configuration
2125         https://bugs.webkit.org/show_bug.cgi?id=149321
2126
2127         Reviewed by Tim Horton.
2128
2129         InjectedBundlePage::platformDidStartProvisionalLoadForFrame() unconditionally
2130         enabled the "testing" viewport configuration, which disables page scaling.
2131
2132         If we're running viewport tests, we want the normal web page configuration.
2133         Do that by passing a flag in the dictionary sent to InjectedBundle::beginTesting(),
2134         based on whether the test is in a "viewport" directory.
2135
2136         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2137         (WTR::InjectedBundle::beginTesting):
2138         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
2139         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame): Deleted.
2140         * WebKitTestRunner/TestInvocation.cpp:
2141         (WTR::TestInvocation::shouldLogFrameLoadDelegates):
2142         (WTR::TestInvocation::shouldLogHistoryClientCallbacks):
2143         (WTR::TestInvocation::shouldMakeViewportFlexible):
2144         (WTR::TestInvocation::invoke):
2145         * WebKitTestRunner/TestInvocation.h:
2146         * WebKitTestRunner/ios/TestControllerIOS.mm:
2147         (WTR::TestController::platformConfigureViewForTest):
2148         (WTR::shouldMakeViewportFlexible): Deleted.
2149
2150 2015-09-17  Simon Fraser  <simon.fraser@apple.com>
2151
2152         Give iOS WebKitTestRunner a launch storyboard
2153         https://bugs.webkit.org/show_bug.cgi?id=149314
2154
2155         Reviewed by Dan Bates.
2156
2157         Add a launch storyboard to iOS WebKitTestRunner so that Springboard recognizes
2158         that it's been built for specific device configurations, and puts the window
2159         at the top of the screen. This simplifies coordinate conversions in a future patch.
2160
2161         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2162         * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist:
2163         * WebKitTestRunner/ios/Launch.storyboard: Added.
2164
2165 2015-09-17  Myles C. Maxfield  <mmaxfield@apple.com>
2166
2167         Update licence in r189890
2168         https://bugs.webkit.org/show_bug.cgi?id=149306
2169
2170         Reviewed by Dean Jackson.
2171
2172         * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
2173         * FontWithFeatures/FontWithFeatures/FontCreator.h:
2174         * FontWithFeatures/FontWithFeatures/main.cpp:
2175
2176 2015-09-17  Mark Lam  <mark.lam@apple.com>
2177
2178         Add the ability to skip JIT stress tests in run-javascriptcore-tests.
2179         https://bugs.webkit.org/show_bug.cgi?id=149285
2180
2181         Reviewed by Saam Barati.
2182
2183         Just need to add an option to pass --no-jit to run-jsc-stress-test.
2184
2185         * Scripts/run-javascriptcore-tests:
2186         (runJSCStressTests):
2187
2188 2015-09-17  Alex Christensen  <achristensen@webkit.org>
2189
2190         Switch AppleWin build to use CMake
2191         https://bugs.webkit.org/show_bug.cgi?id=149163
2192
2193         Reviewed by Brent Fulgham.
2194
2195         * Scripts/build-webkit:
2196         * Scripts/run-api-tests:
2197         (runTest):
2198         (listAllTests):
2199         (prepareEnvironmentForRunningTestTool):
2200         (testToolPaths):
2201         (testToolPath): Deleted.
2202         Run the API tests as separate executables on Windows.
2203         It used to be TestWebKitAPI.exe, and it is now TestWTF.exe, TestWebCore.exe, and TestWebKit.exe.
2204         * Scripts/webkitdirs.pm:
2205         (checkRequiredSystemConfig):
2206         (jhbuildWrapperPrefixIfNeeded):
2207         (generateBuildSystemFromCMakeProject):
2208         Fix configuration quirks.
2209
2210 2015-09-17  Dean Johnson  <dean_johnson@apple.com>
2211
2212         Added toggle options for hiding and showing certain platform families on the dashboard.
2213         https://bugs.webkit.org/show_bug.cgi?id=148403
2214
2215         Reviewed by David Kilzer.
2216
2217         This patch removes "hiddenPlatforms" from use in the code and local storage. We also removed
2218         individual hide/show buttons for platforms because we've added toggle options to hide/show entire
2219         families. Examples of these are "mac", "ios", and "linux". "Show All Platforms" was also removed
2220         in lieu of an "all" button in the toggle menu.
2221
2222         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
2223         (parsePlatformFamily): Helper function to parse out a platform family.
2224         (initPlatformsByFamily): Initializes platformsByFamily, which organizes platforms on the
2225         page by platformsByFamily[<family>] = <list of platforms belonging to that family>.
2226         (updateToggleButtons): Updates the status of the toggle buttons.
2227         (updateHiddenPlatforms): Changed to work with the new implementation of hiding/showing platforms.
2228         (documentReady): Added creation of toggle buttons.
2229         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
2230         (unhiddenQueues): Updated to search by platform family instead of the individual platform name.
2231         (documentReady): Changed hiddenPlatforms => hiddenPlatformFamilies.
2232         (updateHiddenPlatforms): Deleted. After removing the individual hide button code,
2233         this did the exact same thing as the updateHiddenPlatforms in Scripts/Main.js so it was removed.
2234         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
2235         (QueueView): Updated to use hiddenPlatformFamilies.
2236         (QueueView.prototype._updateHiddenState): Updated to use hiddenPlatformFamilies.
2237         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
2238         (Settings.prototype.toggleHiddenPlatformFamily): Renamed function and some variables.
2239         (Settings.prototype.clearHiddenPlatformFamilies): Now uses hiddenPlatformFamilies for events.
2240         (Settings.prototype.toggleHiddenPlatform): Deleted.
2241         (Settings.prototype.clearHiddenPlatforms): Deleted.
2242         (Settings.prototype.toggleShowPlatformFamily): Deleted.
2243         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2244         (div.cellButton, div.accessibilityButton, div.platformFamilyToggleButton):
2245         (div.cellButton.unhide, div.accessibilityButton.unhide, div.platformFamilyToggleButton.unhide):
2246         (.settings-visible div.settingsWrapper.hide, .settings-visible div.settingsWrapper):
2247         (table.queue-grid tr.headers th):
2248         (div.settingsWrapper.hide):
2249         (div.settingsWrapper):
2250         (div.familyToggleWrapper):
2251         (div.platformFamilyToggleButton):
2252         (div.platformFamilyShowToggleButton:not(:last-child)):
2253         (div.familyShown):
2254         (div.accessibilityButton):
2255         (div.cellButton, div.accessibilityButton): Added platformFamilyToggleButton class.
2256         (div.cellButton.unhide, div.accessibilityButton.unhide): Added platformFamilyToggleButton class.
2257         (.settings-visible div.accessibilityButton.hide, .settings-visible div.accessibilityButton.unhide): Added
2258         platformFamilyToggleButton and settingsWrapper class.
2259         (.accessibilityButton): Deleted.
2260
2261 2015-09-17  Tim Horton  <timothy_horton@apple.com>
2262
2263         Add a test ensuring that scrolling in the middle of a page can't start a swipe gesture
2264         https://bugs.webkit.org/show_bug.cgi?id=148904
2265
2266         Reviewed by Myles Maxfield.
2267
2268         * WebKitTestRunner/TestController.cpp:
2269         (WTR::parseBooleanTestHeaderValue):
2270         (WTR::updateViewOptionsFromTestHeader):
2271         Check for the key "useThreadedScrolling".
2272         Add some code to check for "true" and "false" for boolean options.
2273
2274         (WTR::TestController::viewOptionsForTest):
2275         Apply the test's overrides last, even after the platform's.
2276
2277 2015-09-16  Carlos Garcia Campos  <cgarcia@igalia.com>
2278
2279         printing does not use minimum page zoom factor
2280         https://bugs.webkit.org/show_bug.cgi?id=108507
2281
2282         Reviewed by Darin Adler.
2283
2284         WebKitTestRunner always takes the snapshots from the UI process
2285         (expect for IOS), so in the case of printing, the layout in the
2286         web view is not the expected one. When printing, we need to take
2287         the snapshot in the web process and ensure it's rendered with a
2288         PrintContext.
2289
2290         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2291         (WTR::InjectedBundlePage::dump): When dumping pixels, pass
2292         kWKSnapshotOptionsPrinting option to
2293         WKBundlePageCreateSnapshotWithOptions() when printing. When not
2294         printing, don't even create the snapshot, since it will be ignored
2295         by the UI process that always creates its own from the WebView (expect for IOS platform)
2296         * WebKitTestRunner/TestInvocation.cpp:
2297         (WTR::TestInvocation::dumpResults): Use always the snapshot image
2298         received from the web process if any when comparing pixel
2299         results. Now we only receive a snapshot from the web process in
2300         case of printing, or when platform is IOS. Otherwhise, generate
2301         the snapshot from the WebView as usual.
2302         * WebKitTestRunner/TestInvocation.h: Add SnapshotResultType enum
2303         parameter to dumpPixelsAndCompareWithExpected, since the snapshot
2304         is created by the caller now, but the CG implementation needs to
2305         know if it's a Web or UI process snapshot.
2306         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
2307         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
2308         cairo surface for the given image.
2309         * WebKitTestRunner/cg/TestInvocationCG.cpp:
2310         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
2311         CGContext for the given image.
2312
2313 2015-09-16  Myles C. Maxfield  <mmaxfield@apple.com>
2314
2315         Create a font which can be used for testing font features
2316         https://bugs.webkit.org/show_bug.cgi?id=149237
2317
2318         Reviewed by Simon Fraser.
2319
2320         This patch adds a new project in the Tools/ directory which generates a font which can
2321         be used for testing font features. This is a standalone project consisting of two files:
2322         1. A file which actually generates the byte vector representing the font. This file has
2323         a single public function: std::vector<uint8_t> generateFont(). This file is not platform
2324         specific, and only relies on the C++ STL.
2325         2. A file with a main() which calls generateFont() and writes out the font, as well as
2326         uses the font to render some demonstration text into a .png file. This file is platform
2327         specific.
2328
2329         The font itself only supports the following characters:
2330         ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz
2331         However, the shape of these letters are either an X or a check mark.
2332
2333         The letter "A" always is a check mark.
2334         The letter "B" always is an X.
2335         Without any font features turned on, the rest of the letters are shown as X.
2336
2337         Each font feature has an letter associated with it. When the font feature is enabled,
2338         that letter is shown as a check mark. For example, when "smcp" is enabled, "J" is shown
2339         as a check mark.
2340
2341         Here are the mappings of font features to letters:
2342         liga: C
2343         clig: D
2344         dlig: E
2345         hlig: F
2346         calt: G
2347         subs: H
2348         sups: I
2349         smcp: J
2350         c2sc: K
2351         pcap: L
2352         c2pc: M
2353         unic: N
2354         titl: O
2355         onum: P
2356         pnum: Q
2357         tnum: R
2358         frac: S
2359         afrc: T
2360         ordn: U
2361         zero: V
2362         hist: W
2363         jp78: X
2364         jp83: Y
2365         jp90: Z
2366         jp04: a
2367         smpl: b
2368         trad: c
2369         fwid: d
2370         pwid: e
2371         ruby: f
2372
2373         * FontWithFeatures/FontWithFeatures.xcodeproj/project.pbxproj: Added.
2374         * FontWithFeatures/FontWithFeatures/FontCreator.cpp: Added.
2375         (integralLog2):
2376         (roundDownToPowerOfTwo):
2377         (isFourByteAligned):
2378         (clampTo):
2379         (append32):
2380         (writeCFFEncodedNumber):
2381         (CFFBuilder::CFFBuilder):
2382         (CFFBuilder::takeResult):
2383         (CFFBuilder::moveTo):
2384         (CFFBuilder::lineTo):
2385         (CFFBuilder::curveToCubic):
2386         (CFFBuilder::closePath):
2387         (CFFBuilder::writePoint):
2388         (generateBoxCharString):
2389         (generateCheckCharString):
2390         (generateXCharString):
2391         (charStringForGlyph):
2392         (Generator::generate):
2393         (Generator::Placeholder::Placeholder):
2394         (Generator::Placeholder::populate):
2395         (Generator::Placeholder::~Placeholder):
2396         (Generator::placeholder):
2397         (Generator::append16):
2398         (Generator::append32):
2399         (Generator::append32BitCode):
2400         (Generator::overwrite16):
2401         (Generator::overwrite32):
2402         (Generator::appendCFFTable):
2403         (Generator::appendSubstitutionSubtable):
2404         (Generator::appendScriptSubtable):
2405         (Generator::appendGSUBTable):
2406         (Generator::appendOS2Table):
2407         (Generator::appendFormat12CMAPTable):
2408         (Generator::appendFormat4CMAPTable):
2409         (Generator::appendCMAPTable):
2410         (Generator::appendHEADTable):
2411         (Generator::appendHHEATable):
2412         (Generator::appendHMTXTable):
2413         (Generator::appendMAXPTable):
2414         (Generator::appendNAMETable):
2415         (Generator::appendPOSTTable):
2416         (Generator::calculateChecksum):
2417         (Generator::appendTable):
2418         (generateFont):
2419         * FontWithFeatures/FontWithFeatures/FontCreator.h: Added.
2420         * FontWithFeatures/FontWithFeatures/main.cpp: Added.
2421         (drawTextWithFeature):
2422         (main):
2423
2424 2015-09-16  Commit Queue  <commit-queue@webkit.org>
2425
2426         Unreviewed, rolling out r189875 and r189878.
2427         https://bugs.webkit.org/show_bug.cgi?id=149235
2428
2429         cygwin cmake build not ready yet (Requested by alexchristensen
2430         on #webkit).
2431
2432         Reverted changesets:
2433
2434         "Switch AppleWin build to use CMake"
2435         https://bugs.webkit.org/show_bug.cgi?id=149163
2436         http://trac.webkit.org/changeset/189875
2437
2438         "Cygwin build fix after r189875"
2439         http://trac.webkit.org/changeset/189878
2440
2441 2015-09-16  Alex Christensen  <achristensen@webkit.org>
2442
2443         Cygwin build fix after r189875
2444
2445         * Scripts/build-webkit:
2446         * Scripts/webkitdirs.pm:
2447         (jhbuildWrapperPrefixIfNeeded):
2448         (generateBuildSystemFromCMakeProject):
2449         Make things work with cygwin and cmake.
2450
2451 2015-09-16  Alex Christensen  <achristensen@webkit.org>
2452
2453         Switch AppleWin build to use CMake
2454         https://bugs.webkit.org/show_bug.cgi?id=149163
2455
2456         Reviewed by Brent Fulgham.
2457
2458         * Scripts/build-webkit:
2459         Build with CMake.
2460         * Scripts/run-api-tests:
2461         (runTest):
2462         (listAllTests):
2463         (prepareEnvironmentForRunningTestTool):
2464         (testToolPaths):
2465         (testToolPath): Deleted.
2466         Run the API tests as separate executables on Windows.
2467         It used to be TestWebKitAPI.exe, and it is now TestWTF.exe, TestWebCore.exe, and TestWebKit.exe.
2468
2469 2015-09-16  Alexey Proskuryakov  <ap@apple.com>
2470
2471         Add newer build.webkit.org pages to robots.txt
2472         https://bugs.webkit.org/show_bug.cgi?id=149219
2473
2474         Reviewed by Darin Adler.
2475
2476         Indexing bot watcher's dashboard can't be good.
2477
2478         * BuildSlaveSupport/build.webkit.org-config/public_html/robots.txt:
2479
2480 2015-09-16  Alex Christensen  <achristensen@webkit.org>
2481
2482         Rollout r189851 and 189853 because they didn’t actually fix the permissions issue
2483
2484         * BuildSlaveSupport/built-product-archive:
2485         (unzipArchive):
2486
2487 2015-09-16  Csaba Osztrogonác  <ossy@webkit.org>
2488
2489         [EFL] Fix the help message of separated web process option of MiniBrowser
2490         https://bugs.webkit.org/show_bug.cgi?id=149212
2491
2492         Reviewed by Gyuyoung Kim.
2493
2494         * MiniBrowser/efl/main.c:
2495
2496 2015-09-16  Alex Christensen  <achristensen@webkit.org>
2497
2498         Fix python syntax after r189851.
2499
2500         * BuildSlaveSupport/built-product-archive:
2501         (unzipArchive):
2502         For loops need a colon.
2503
2504 2015-09-15  Alex Christensen  <achristensen@webkit.org>
2505
2506         Fix Windows test bots after changing to non-cygwin build
2507         https://bugs.webkit.org/show_bug.cgi?id=149196
2508
2509         Reviewed by Daniel Bates.
2510
2511         * BuildSlaveSupport/built-product-archive:
2512         (unzipArchive):
2513         Using different versions of python makes what I think is https://bugs.python.org/issue15795
2514         prevent us from executing files from the archive on the test bots.
2515
2516 2015-09-15  Ryosuke Niwa  <rniwa@webkit.org>
2517
2518         Add ShadowRoot interface and Element.prototype.attachShadow
2519         https://bugs.webkit.org/show_bug.cgi?id=149187
2520
2521         Reviewed by Antti Koivisto.
2522
2523         * Scripts/webkitperl/FeatureList.pm:
2524
2525 2015-09-15  Aakash Jain  <aakash_jain@apple.com>
2526
2527         Appscale queue status json output lacks bots
2528         https://bugs.webkit.org/show_bug.cgi?id=149194
2529         <rdar://problem/22171089>
2530
2531         Reviewed by Alexey Proskuryakov.
2532
2533         * QueueStatusServer/handlers/queuestatusjson.py:
2534         (QueueStatusJSON._bots): Order the results by date so as to get latest events, this was default in AppEngine.
2535         * QueueStatusServer/index.yaml: Index according to appscale requirements.
2536
2537 2015-09-15  Brent Fulgham  <bfulgham@apple.com>
2538
2539         [Win] Provide a means for viewing the layer tree
2540         https://bugs.webkit.org/show_bug.cgi?id=149165
2541
2542         Reviewed by Simon Fraser.
2543
2544         Update MiniBrowser with a new Debug menu option that will
2545         dump the current layer tree to the debug console.
2546
2547         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc:
2548         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h:
2549         * MiniBrowser/win/Common.cpp:
2550         (WndProc): Add handler for 'Print Layer Tree' menu option.
2551         * MiniBrowser/win/MiniBrowser.cpp:
2552         (MiniBrowser::printLayerTree): Added Handler.
2553         * MiniBrowser/win/MiniBrowser.h:
2554
2555 2015-09-14  Myles C. Maxfield  <mmaxfield@apple.com>
2556
2557         WebKitTestRunner declarative language setting is broken for iOS
2558         https://bugs.webkit.org/show_bug.cgi?id=149119
2559
2560         Unreviewed.
2561
2562         In all of the patches on webkit.org/b/189669, my patch to get this working on iOS was
2563         lost in the final version which got committed. This simply implements the existing
2564         OS X behavior on iOS.
2565
2566         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
2567         (WTR::InjectedBundle::platformInitialize):
2568
2569 2015-09-14  Dewei Zhu  <dewei_zhu@apple.com>
2570
2571         Unreviewed, add myself to committers list.
2572
2573         * Scripts/webkitpy/common/config/contributors.json:
2574
2575 2015-09-12  Myles C. Maxfield  <mmaxfield@apple.com>
2576
2577         [Cocoa] Allow testing with the system language
2578         https://bugs.webkit.org/show_bug.cgi?id=148671
2579
2580         Reviewed by Anders Carlsson and Alexey Proskuryakov.
2581
2582         React to tests marked with language=lang1,lang2,etc in their header.
2583         Once this information is parsed, pass it to
2584         WKContextConfigurationSetOverrideLanguages().
2585
2586         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2587         (WTR::InjectedBundle::platformInitialize): Don't clobber the language
2588         list.
2589         * WebKitTestRunner/TestController.cpp:
2590         (WTR::TestController::createWebViewWithOptions): Call
2591         WKContextConfigurationSetOverrideLanguages().
2592         (WTR::updateTestOptionsFromTestHeader): Inspect the language option.
2593         * WebKitTestRunner/TestOptions.h:
2594         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2595         (WTR::PlatformWebView::viewSupportsOptions): Cause a differing language
2596         option to restart the web process.
2597         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2598         (WTR::PlatformWebView::viewSupportsOptions): Ditto.
2599
2600 2015-09-12  Myles C. Maxfield  <mmaxfield@apple.com>
2601
2602         [WKTR] Allow changing the WKContextConfiguration between successive tests
2603         https://bugs.webkit.org/show_bug.cgi?id=148833
2604
2605         Reviewed by Tim Horton.
2606
2607         Previously, we were creating a single WKContext and it lived for the life of the entire test runner.
2608         However, there are certain tests which require specifying options in this object. This patch makes
2609         our existing code for recreating the test runner web view also recreate the WKContext.
2610
2611         As such, our options to the view are now options to the WKContextConfiguration. This patch renames the
2612         class.
2613
2614         * WebKitTestRunner/ContextConfigurationOptions.h: Renamed from Tools/WebKitTestRunner/ViewOptions.h.
2615         * WebKitTestRunner/PlatformWebView.h:
2616         (WTR::PlatformWebView::options):
2617         * WebKitTestRunner/TestController.cpp:
2618         (WTR::TestController::initialize):
2619         (WTR::TestController::generateContextConfiguration):
2620         (WTR::TestController::generatePageConfiguration):
2621         (WTR::TestController::createWebViewWithOptions):
2622         (WTR::TestController::ensureViewSupportsOptionsForTest):
2623         (WTR::updateContextConfigurationOptionsFromTestHeader):
2624         (WTR::TestController::contextConfigurationOptionsForTest):
2625         (WTR::TestController::platformCreateWebView):
2626         (WTR::TestController::platformCreateOtherPage):
2627         (WTR::updateViewOptionsFromTestHeader): Deleted.
2628         (WTR::TestController::viewOptionsForTest): Deleted.
2629         * WebKitTestRunner/TestController.h:
2630         (WTR::TestController::injectedBundlePath):
2631         (WTR::TestController::testPluginDirectory):
2632         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2633         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2634         (WTR::TestController::platformCreateWebView):
2635         (WTR::TestController::platformCreateOtherPage):
2636         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2637         (WTR::PlatformWebView::PlatformWebView):
2638         (WTR::PlatformWebView::viewSupportsOptions):
2639         * WebKitTestRunner/efl/TestControllerEfl.cpp:
2640         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
2641         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
2642         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2643         (WTR::PlatformWebView::PlatformWebView):
2644         (WTR::PlatformWebView::viewSupportsOptions):
2645         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2646         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
2647         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
2648         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2649         (WTR::PlatformWebView::PlatformWebView):
2650         (WTR::PlatformWebView::viewSupportsOptions):
2651         * WebKitTestRunner/ios/TestControllerIOS.mm:
2652         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
2653         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
2654         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2655         (WTR::PlatformWebView::PlatformWebView):
2656         (WTR::PlatformWebView::viewSupportsOptions):
2657         * WebKitTestRunner/mac/TestControllerMac.mm:
2658         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
2659         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
2660
2661 2015-09-11  Michael Saboff  <msaboff@apple.com>
2662
2663         LayoutTestHelper crashes if a color profile isn't set for a 3rd party monitor
2664         https://bugs.webkit.org/show_bug.cgi?id=149083
2665
2666         Reviewed by Alexey Proskuryakov.
2667
2668         Check to make sure that we have a valid factoryProfile CFDictionaryRef before using it.
2669
2670         * DumpRenderTree/mac/LayoutTestHelper.m:
2671         (colorProfileURLForDisplay):
2672
2673 2015-09-11  Saam barati  <sbarati@apple.com>
2674
2675         There should be a defaultSpotCheck-like mode that doesn't run the MaximalFlushInsertionPhase in run-jsc-stress-tests
2676         https://bugs.webkit.org/show_bug.cgi?id=149058
2677
2678         Reviewed by Geoffrey Garen.
2679
2680         * Scripts/run-jsc-stress-tests:
2681
2682 2015-09-10  Commit Queue  <commit-queue@webkit.org>
2683
2684         Unreviewed, rolling out r189595.
2685         https://bugs.webkit.org/show_bug.cgi?id=149052
2686
2687         The tests still fail (Requested by ap on #webkit).
2688
2689         Reverted changeset:
2690
2691         "Spurious output on Windows tests: AQMEIOManager::FindIOUnit:
2692         error -1"
2693         https://bugs.webkit.org/show_bug.cgi?id=142929
2694         http://trac.webkit.org/changeset/189595
2695
2696 2015-09-10  Alexey Proskuryakov  <ap@apple.com>
2697
2698         Spurious output on Windows tests: AQMEIOManager::FindIOUnit: error -1
2699         https://bugs.webkit.org/show_bug.cgi?id=142929
2700
2701         Reviewed by Brent Fulgham.
2702
2703         Silence the logging. We'll track fixing the root cause in Radar.
2704
2705         * Scripts/webkitpy/port/mac.py:
2706         (MacPort.stderr_patterns_to_strip): Added a FIXME.
2707
2708         * Scripts/webkitpy/port/win.py:
2709         (WinPort.logging_patterns_to_strip): Added.
2710
2711 2015-09-09  Andy Estes  <aestes@apple.com>
2712
2713         [iOS] Teach run-webkit-tests how to parse simulator runtimes when version numbers contain a revision
2714         https://bugs.webkit.org/show_bug.cgi?id=149022
2715
2716         Reviewed by Daniel Bates.
2717
2718         Simulator runtime versions can contain a revision number (e.g. 8.4.1), but the regex for matching runtimes
2719         did not account for this.
2720
2721         * Scripts/webkitpy/xcode/simulator.py:
2722         (Simulator): Optionally matched a revision at the end of a runtime version number.
2723         * Scripts/webkitpy/xcode/simulator_unittest.py: Added a test.
2724
2725 2015-09-09  Andy Estes  <aestes@apple.com>
2726
2727         [iOS] Teach run-webkit-tests how to parse `simctl list` when a tvOS SDK is installed
2728         https://bugs.webkit.org/show_bug.cgi?id=149029
2729         <rdar://problem/22432624>
2730
2731         Reviewed by Daniel Bates.
2732
2733         * Scripts/webkitpy/xcode/simulator.py:
2734         (Simulator): Taught to parse tvOS runtimes.
2735         * Scripts/webkitpy/xcode/simulator_unittest.py: Added tests.
2736
2737 2015-09-09  Alexey Proskuryakov  <ap@apple.com>
2738
2739         Fix bit rot on bot watcher's dashboard page
2740         https://bugs.webkit.org/show_bug.cgi?id=149012
2741
2742         Reviewed by Tim Horton.
2743
2744         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2745         The code path used by the metrics page was trying to add properties to an undefined.
2746
2747         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
2748         Silence an expection that would occur when the step has no logs. This should never
2749         happen, but it did (perhaps buildbot was misconfigured for a while).
2750
2751 2015-09-09  Alexey Proskuryakov  <ap@apple.com>
2752
2753         Update LayoutTestRelay xcconfig file.
2754
2755         Rubber-stamped by Dan Bernstein.
2756
2757         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
2758
2759 2015-09-09  Saam barati  <sbarati@apple.com>
2760
2761         DFG should have a debugging option that runs a phase that flushes all locals
2762         https://bugs.webkit.org/show_bug.cgi?id=148916
2763
2764         Reviewed by Filip Pizlo.
2765
2766         * Scripts/run-jsc-stress-tests:
2767
2768 2015-09-09  Commit Queue  <commit-queue@webkit.org>
2769
2770         Unreviewed, rolling out r189530 and r189534.
2771         https://bugs.webkit.org/show_bug.cgi?id=148996
2772
2773         Caused assertion failures on Yosemite (Requested by litherum
2774         on #webkit).
2775
2776         Reverted changesets:
2777
2778         "[WKTR] Allow changing the WKContextConfiguration between
2779         successive tests"
2780         https://bugs.webkit.org/show_bug.cgi?id=148833
2781         http://trac.webkit.org/changeset/189530
2782
2783         "[Cocoa] Fix the tests after r189530"
2784         http://trac.webkit.org/changeset/189534
2785
2786 2015-09-08  Myles C. Maxfield  <mmaxfield@apple.com>
2787
2788         [Cocoa] Fix the tests after r189530
2789
2790         Unreviewed.
2791
2792         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2793         (WTR::initializeWebViewConfiguration):
2794
2795 2015-09-08  Myles C. Maxfield  <mmaxfield@apple.com>
2796
2797         [WKTR] Allow changing the WKContextConfiguration between successive tests
2798         https://bugs.webkit.org/show_bug.cgi?id=148833
2799
2800         Reviewed by Tim Horton.
2801
2802         Previously, we were creating a single WKContext and it lived for the life of the entire test runner.
2803         However, there are certain tests which require specifying options in this object. This patch makes
2804         our existing code for recreating the test runner web view also recreate the WKContext.
2805
2806         As such, our options to the view are now options to the WKContextConfiguration. This patch renames the
2807         class.
2808
2809         * WebKitTestRunner/ContextConfigurationOptions.h: Renamed from Tools/WebKitTestRunner/ViewOptions.h.
2810         * WebKitTestRunner/PlatformWebView.h:
2811         (WTR::PlatformWebView::options):
2812         * WebKitTestRunner/TestController.cpp:
2813         (WTR::TestController::initialize):
2814         (WTR::TestController::generateContextConfiguration):
2815         (WTR::TestController::generatePageConfiguration):
2816         (WTR::TestController::createWebViewWithOptions):
2817         (WTR::TestController::ensureViewSupportsOptionsForTest):
2818         (WTR::updateContextConfigurationOptionsFromTestHeader):
2819         (WTR::TestController::contextConfigurationOptionsForTest):
2820         (WTR::TestController::platformCreateWebView):
2821         (WTR::TestController::platformCreateOtherPage):
2822         (WTR::updateViewOptionsFromTestHeader): Deleted.
2823         (WTR::TestController::viewOptionsForTest): Deleted.
2824         * WebKitTestRunner/TestController.h:
2825         (WTR::TestController::injectedBundlePath):
2826         (WTR::TestController::testPluginDirectory):
2827         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2828         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2829         (WTR::TestController::platformCreateWebView):
2830         (WTR::TestController::platformCreateOtherPage):
2831         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2832         (WTR::PlatformWebView::PlatformWebView):
2833         (WTR::PlatformWebView::viewSupportsOptions):
2834         * WebKitTestRunner/efl/TestControllerEfl.cpp:
2835         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
2836         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
2837         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2838         (WTR::PlatformWebView::PlatformWebView):
2839         (WTR::PlatformWebView::viewSupportsOptions):
2840         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2841         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
2842         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
2843         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2844         (WTR::PlatformWebView::PlatformWebView):
2845         (WTR::PlatformWebView::viewSupportsOptions):
2846         * WebKitTestRunner/ios/TestControllerIOS.mm:
2847         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
2848         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
2849         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2850         (WTR::PlatformWebView::PlatformWebView):
2851         (WTR::PlatformWebView::viewSupportsOptions):
2852         * WebKitTestRunner/mac/TestControllerMac.mm:
2853         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
2854         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
2855
2856 2015-09-08  Daniel Bates  <dabates@apple.com>
2857
2858         [Mac] Expose Enable/Disable Accelerated Drawing in MiniBrowser
2859         https://bugs.webkit.org/show_bug.cgi?id=148980
2860
2861         Reviewed by Alexey Proskuryakov.
2862
2863         Add setting to enable/disable accelerated drawing so as to support testing
2864         this feature in MiniBrowser on Mac.
2865
2866         * MiniBrowser/mac/SettingsController.h:
2867         * MiniBrowser/mac/SettingsController.m:
2868         (-[SettingsController _populateMenu]): Add menu item.
2869         (-[SettingsController validateMenuItem:]): Update setting when menu item is toggled.
2870         (-[SettingsController toggleAcceleratedDrawingEnabled:]): Added.
2871         (-[SettingsController acceleratedDrawingEnabled]): Added.
2872         * MiniBrowser/mac/WK1BrowserWindowController.m:
2873         (-[WK1BrowserWindowController didChangeSettings]): Apply setting in WebKit1.
2874         * MiniBrowser/mac/WK2BrowserWindowController.m:
2875         (-[WK2BrowserWindowController didChangeSettings]): Apply setting in WebKit2.
2876
2877 2015-09-08  Jason Marcell  <jmarcell@apple.com>
2878
2879         Unreviewed. Added myself as a commiter in contributors.json.
2880
2881         * Scripts/webkitpy/common/config/contributors.json:
2882
2883 2015-09-08  Keith Miller  <keith_miller@apple.com>
2884
2885         Unreviewed, added myself to the list of contributors.
2886
2887         * Scripts/webkitpy/common/config/contributors.json:
2888
2889 2015-09-08  Daniel Bates  <dabates@apple.com>
2890
2891         Dashboard: Remove use of z-index for ring overlay; use DOM ordering
2892         https://bugs.webkit.org/show_bug.cgi?id=148921
2893
2894         Reviewed by Alexey Proskuryakov.
2895
2896         The ring image is positioned above the platform icon in markup and we specify the CSS
2897         property z-index for the ring image so that it is painted on top of the platform icon
2898         instead of below it (by DOM ordering). Instead we can take advantage of the transparency
2899         of the ring image, switch the order of these DOM elements and remove the use of the CSS
2900         property z-index to achieve a similar effect.
2901
2902         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
2903         (documentReady): Create the platform icon image element before the ring image such that
2904         the ring image is painted on top of the platform icon.
2905         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2906         (table.queue-grid td.logo img.ring): Removed property z-index.
2907
2908 2015-09-08  Daniel Bates  <dabates@apple.com>
2909
2910         Dashboard: Remove duplicate gear icon data URLs
2911         https://bugs.webkit.org/show_bug.cgi?id=148920
2912
2913         Reviewed by Alexey Proskuryakov.
2914
2915         Currently we duplicate the SVG data URL for the gear icon up to its fill color in the CSS property
2916         background-image associated with each of the three gear icon states: collapsed (.settings), hover
2917         (.settings:hover), and expanded (.settings-visible .settings). Instead we should use the gear icon
2918         as a mask and make use of the CSS background-color to define the fill color for each of these three
2919         states.
2920
2921         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2922         (.settings): Use gear icon as mask and define CSS background-color for collapsed state.
2923         (.settings:hover): Override CSS background-color for hover state.
2924         (.settings-visible .settings): Override CSS background-color for expanded state.
2925
2926 2015-09-07  Andy Estes  <aestes@apple.com>
2927
2928         [Mac] DebugRelease builds should link against libWebKitSystemInterfaceElCapitan.a on 10.11
2929         https://bugs.webkit.org/show_bug.cgi?id=148946
2930         <rdar://problem/22603981>
2931
2932         Reviewed by Dan Bernstein.
2933
2934         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2935         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2936
2937 2015-09-07  Hunseop Jeong  <hs85.jeong@samsung.com>
2938
2939         [EFL] Many of the css3/device-adapt/* tests failed after r188548.
2940         https://bugs.webkit.org/show_bug.cgi?id=148927
2941
2942         Reviewed by Csaba Osztrogonác.
2943
2944         device-adapt/* tests need the fixedLayout option but useFixedLayout option is
2945         overwritten by updatePlatformSpecificViewOptionsForTest after r188548.
2946
2947         * WebKitTestRunner/TestController.cpp:
2948         (WTR::shouldUseFixedLayout): Removed the unnecessary indentations.
2949         * WebKitTestRunner/efl/TestControllerEfl.cpp:
2950         (WTR::shouldUseFixedLayout): Return true if the test is related with 'device-adapt'.
2951
2952 2015-09-07  Andy Estes  <aestes@apple.com>
2953
2954         Fix the Production build after r189455.
2955
2956         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Somehow I added the All target using the
2957         In-App Purchase template instead of the Aggregate template. Whoops.
2958
2959 2015-09-06  Andy Estes  <aestes@apple.com>
2960
2961         WebKit.xcworkspace should be be able to build iOS platforms
2962         https://bugs.webkit.org/show_bug.cgi?id=148881
2963
2964         Reviewed by Daniel Bates.
2965
2966         Since we don't want to create platform-specific schemes, all projects in the workspace's schemes need to build
2967         for all supported platforms.
2968
2969         * MiniBrowser/Configurations/Base.xcconfig: Included iphoneos and iphonesimulator in SUPPORTED_PLATFORMS.
2970         * MiniBrowser/Configurations/MiniBrowser.xcconfig: Excluded all source files on iOS, and linked Cocoa and WebKit on Mac.
2971         * MiniBrowser/Configurations/MiniBrowserBundle.xcconfig: Ditto.
2972         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Stopped linking frameworks in Link Binaries With Libraries.
2973
2974 2015-09-06  Andy Estes  <aestes@apple.com>
2975
2976         WebKitTestRunner should build for iOS using the default target
2977         https://bugs.webkit.org/show_bug.cgi?id=148918
2978
2979         Reviewed by Daniel Bates.
2980
2981         When WebKitTestRunner was ported to iOS, a separate target (WebKitTestRunnerApp) was created for building the
2982         iOS variant. This is annoying because (1) all tools that invoke xcodebuild need to be taught to build this
2983         non-default target, and (2) a single Xcode scheme cannot be used to build both Mac and iOS variants.
2984
2985         This change adds a new default target (All) and makes it work for both Mac and iOS. Files that were built for
2986         both WebKitTestRunner and WebKitTestRunnerApp are now built in a static library target (WebKitTestRunner (Library)),
2987         and both apps now link this library. Files that are specific to Mac or iOS are excluded on the other platform.
2988         WebKitTestRunnerApp.app (which should be renamed to WebKitTestRunner.app) is skipped when installing on Mac, and
2989         WebKitTestRunner is skipped when installing on iOS.
2990
2991         The target dependency graph now looks like this:
2992
2993             All
2994                 WebKitTestRunnerApp
2995                     WebKitTestRunner (Library)
2996                         WebKitTestRunnerInjectedBundle
2997                             Derived Sources
2998                 WebKitTestRunner
2999                     WebKitTestRunner (Library)
3000                         WebKitTestRunnerInjectedBundle
3001                             Derived Sources
3002
3003         * Scripts/build-webkit: Stopped building the WebKitTestRunnerApp target on iOS.
3004         * Scripts/build-webkittestrunner: Ditto.
3005         * WebKitTestRunner/Configurations/Base.xcconfig: Set SUPPORTED_PLATFORMS to macosx, iphoneos, and iphonesimulator.
3006         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Set INSTALL_PATH here since it is the same for all targets.
3007         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Stopped setting INSTALL_PATH.
3008         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig: Moved frameworks from the build phase to here,
3009         excluded iOS-only files, and skipped installing on iOS.
3010         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: Moved frameworks from the build phase to here,
3011         excluded Mac-only files, and skipped installing on Mac.
3012         * WebKitTestRunner/Configurations/WebKitTestRunnerLibrary.xcconfig: Skipped installing always.
3013         * WebKitTestRunner/Makefile: Stopped building the WebKitTestRunnerApp target on iOS.
3014         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Added new targets, removed frameworks from
3015         Link Binary With Libraries builds phases, moved common files to the WebKitTestRunner (Library) target, and added
3016         new configuration files.
3017
3018 2015-09-05  Joseph Pecoraro  <pecoraro@apple.com>
3019
3020         Web Inspector: Improve prepare-ChangeLog for multiple cases
3021         https://bugs.webkit.org/show_bug.cgi?id=148875
3022
3023         Reviewed by Timothy Hatcher.
3024
3025         * Scripts/prepare-ChangeLog:
3026         (get_function_line_ranges_for_javascript):
3027         - We were ignoring everything inside of an anonymous function expression,
3028           such as (function(){ ... }), which made InjectedScriptSource produce nothing.
3029           Better handle this by inserting a few tweaks.
3030         - Allow method syntax outside of classes as long as they are at the global level.
3031         - Avoid treating "get" and "set" as getter/setter functions in bad contexts.
3032
3033         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests-expected.txt:
3034         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests.js:
3035         (Foo.prototype.method1):
3036         (Foo.prototype.method2):
3037         (Foo.prototype.method3.innerFunction):
3038         (Foo.prototype.method3):
3039         (insideGlobalAnonymousFunctionExpression):
3040         (foo.insideGlobalFunctionExpression):
3041         (IssueWithMapGetAndSet.prototype.method1.nestedFunctionInsideMethod1):
3042         (IssueWithMapGetAndSet.prototype.method1):
3043         (IssueWithMapGetAndSet.prototype.method2):
3044         (IssueWithMapGetAndSet.prototype.method3):
3045         (IssueWithMapGetAndSet):
3046
3047 2015-09-05  Yusuke Suzuki  <utatane.tea@gmail.com>
3048
3049         [ES6] Enable ES6 Module in JSC shell by default
3050         https://bugs.webkit.org/show_bug.cgi?id=148689
3051
3052         Reviewed by Geoffrey Garen.
3053
3054         * Scripts/run-javascriptcore-tests:
3055         (runJSCStressTests):
3056         * Scripts/run-jsc-stress-tests:
3057
3058 2015-09-04  Basile Clement  <basile_clement@apple.com>
3059
3060         Unreviewed, change my email address.
3061
3062         * Scripts/webkitpy/common/config/contributors.json:
3063
3064 2015-09-04  Beth Dakin  <bdakin@apple.com>
3065
3066         Should have a test to make sure links don't navigate after a cancelled force
3067         click
3068         https://bugs.webkit.org/show_bug.cgi?id=148846
3069
3070         Reviewed by Tim Horton.
3071
3072         New EventSender function for a started then cancelled force click.
3073         * WebKitTestRunner/EventSenderProxy.h:
3074         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
3075         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3076         (WTR::EventSendingController::mouseForceClick):
3077         (WTR::EventSendingController::startAndCancelMouseForceClick):
3078         (WTR::EventSendingController::mouseForceDown):
3079         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
3080         * WebKitTestRunner/TestController.cpp:
3081         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
3082         * WebKitTestRunner/mac/EventSenderProxy.mm:
3083         (WTR::EventSenderProxy::mouseForceClick):
3084         (WTR::EventSenderProxy::startAndCancelMouseForceClick):
3085         (WTR::EventSenderProxy::mouseForceDown):
3086         (WTR::EventSenderProxy::mouseMoveTo):
3087
3088 2015-09-04  Tim Horton  <timothy_horton@apple.com>
3089
3090         Add a test for r179736 (programmatic navigation during swipe causing a crash)
3091         https://bugs.webkit.org/show_bug.cgi?id=148830
3092
3093         Reviewed by Beth Dakin.
3094
3095         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3096         (WTR::InjectedBundle::beginTesting):
3097         Make sure that TestRunner callbacks don't leak between tests!
3098
3099 2015-09-04  Anders Carlsson  <andersca@apple.com>
3100
3101         It should be possible to pass relative HTTP test paths to DumpRenderTree
3102         https://bugs.webkit.org/show_bug.cgi?id=148825
3103         <rdar://problem/22583866>
3104
3105         Reviewed by Tim Horton.
3106
3107         Convert the path to an absolute path if needed.
3108
3109         * DumpRenderTree/mac/DumpRenderTree.mm:
3110         (computeTestURL):
3111
3112 2015-09-04  Jason Marcell  <jmarcell@apple.com>
3113
3114         Fix Swift unit tests for prepare-ChangeLog.
3115         https://bugs.webkit.org/show_bug.cgi?id=148817
3116
3117         Reviewed by Alexey Proskuryakov.
3118
3119         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/swift_unittests-expected.txt: Fixed
3120         Swift unit tests for prepare-ChangeLog.
3121
3122 2015-09-04  Lucas Forschler  <lforschler@apple.com>
3123
3124         Modifications to the webkit-nightly logic.
3125
3126         * WebKitLauncher/WebKitNightlyEnablerSparkle.m:
3127         (updateAlertPanel):
3128         * WebKitLauncher/main.m:
3129         (displayErrorAndQuit):
3130
3131 2015-09-04  Beth Dakin  <bdakin@apple.com>
3132
3133         Speculative build fix.
3134
3135         * WebKitTestRunner/mac/EventSenderProxy.mm:
3136
3137 2015-09-04  Brian Burg  <bburg@apple.com>
3138
3139         Web Inspector: InspectorController should support multiple frontend channels
3140         https://bugs.webkit.org/show_bug.cgi?id=148538
3141
3142         Reviewed by Joseph Pecoraro.
3143
3144         InspectorClients must explicitly disconnect their frontend channel(s) from the
3145         inspected page's InspectorController.
3146
3147         To make this possible, DumpRenderTree should not destroy non-primary views until
3148         it has tried to close any abandoned Web Inspector instances. Performing teardown
3149         in the reverse order prevents disconnection of the frontend channel because that
3150         prematurely destroys the inspector frontend client.
3151
3152         * DumpRenderTree/mac/DumpRenderTree.mm:
3153         (runTest):
3154         * DumpRenderTree/win/DumpRenderTree.cpp:
3155         (runTest):
3156
3157 2015-09-04  Beth Dakin  <bdakin@apple.com>
3158
3159         Need to be able to test default behaviors on force click
3160         https://bugs.webkit.org/show_bug.cgi?id=148758
3161
3162         Reviewed by Tim Horton.
3163
3164         This patch adds a new eventSender method to do a full, completed force click,
3165         and it re-works all of the existing force methods to dispatch their events in
3166         such a way that they will trigger the NSImmediateAction gesture recognizer.
3167         To do this, first we need to send the events to the app rather than straight
3168         to the view, and also needed to tweak some state and send the events in a
3169         delayed fashion.
3170
3171         New public function mouseForceClick() and private helper functions to make
3172         NSEvents.
3173         * WebKitTestRunner/EventSenderProxy.h:
3174
3175         New public function mouseForceClick().
3176         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
3177         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3178         (WTR::EventSendingController::mouseMoveTo):
3179         (WTR::EventSendingController::mouseForceClick):
3180         (WTR::EventSendingController::mouseForceDown):
3181         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
3182         * WebKitTestRunner/TestController.cpp:
3183         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
3184
3185         initPressureEventAtLocation needs to take a stageTransition and a window.
3186         * WebKitTestRunner/mac/EventSenderProxy.mm:
3187         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
3188         (-[EventSenderSyntheticEvent stageTransition]):
3189         (-[EventSenderSyntheticEvent timestamp]):
3190         (-[EventSenderSyntheticEvent _cgsEventRecord]):
3191         (-[EventSenderSyntheticEvent window]):
3192
3193         In order to enter the gesture recognizer, we need to start with a mouse down
3194         that has a NSEventMaskPressure modifier.
3195         (WTR::EventSenderProxy::sendMouseDownToStartPressureEvents):
3196
3197         This ensures that the events queue properly for the force monitor in AppKit.
3198         (WTR::spinRunLoopForForce):
3199
3200          We need to start the pressure change events with a began.
3201         (WTR::EventSenderProxy::beginPressureEvent):
3202
3203         These functions can be used to create the NSEvent for a pressure change every
3204         time we need one.
3205         (WTR::EventSenderProxy::pressureChangeEvent):
3206
3207         Send the right series of events to emulate a full, completed force click.
3208         (WTR::EventSenderProxy::mouseForceClick):
3209
3210         Use all of the new things for these existing functions.
3211         (WTR::EventSenderProxy::mouseForceDown):
3212         (WTR::EventSenderProxy::mouseForceUp):
3213         (WTR::EventSenderProxy::mouseForceChanged):
3214
3215         Set NSFakeForceTouchDevice to YES.
3216         * WebKitTestRunner/mac/main.mm:
3217         (setDefaultsToConsistentValuesForTesting):
3218
3219 2015-09-04  Jason Marcell  <jmarcell@apple.com>
3220
3221         prepare-ChangeLog needs to know how to parse Swift files.
3222         https://bugs.webkit.org/show_bug.cgi?id=148784
3223         <rdar://problem/22510062>
3224
3225         Reviewed by Darin Adler.
3226
3227         * Scripts/prepare-ChangeLog:
3228         (get_function_line_ranges): Added entry for get_function_line_ranges_for_swift.
3229         (get_function_line_ranges_for_swift): Added function that knows how to parse Swift code.
3230         (parseSwiftFunctionArgs): Added function that knows how to parse Swift function arguments.
3231         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl: Added.
3232         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/swift_unittests-expected.txt: Ditto.
3233         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/swift_unittests.swift: Ditto.
3234         (freeFunction): Ditto.
3235         (MyClass.function): Ditto.
3236         (MyClass.functionWithArgument(_:)): Ditto.
3237         (MyClass.functionWithMoreArguments(_:arg2:)): Ditto.
3238         (MyClass.functionWithNamedFirstArgument(argument:)): Ditto.
3239         (MyClass.functionWithNamedFirstAndSecondArgument(first:second:)): Ditto.
3240         (MyClass.classFunction): Ditto.
3241         (MyClass.readWriteComputedVariable): Ditto.
3242         (MyClass.readOnlyComputedVariable): Ditto.
3243
3244 2015-09-04  Ryosuke Niwa  <rniwa@webkit.org>
3245
3246         Import css/css-color-3
3247         https://bugs.webkit.org/show_bug.cgi?id=148803
3248
3249         Reviewed by Chris Dumez.
3250
3251         Fixed a bug that the imported reference files used the same extention as tests.
3252         This would result in parsing errors if the tests were XML and references were HTML and vice versa.
3253
3254         * Scripts/webkitpy/w3c/test_importer.py:
3255         (TestImporter.find_importable_tests):
3256
3257 2015-09-03  Commit Queue  <commit-queue@webkit.org>
3258
3259         Unreviewed, rolling out r189338.
3260         https://bugs.webkit.org/show_bug.cgi?id=148785
3261
3262         Caused tons of crashes (Requested by cdumez on #webkit).
3263
3264         Reverted changeset:
3265
3266         "Web Inspector: InspectorController should support multiple
3267         frontend channels"
3268         https://bugs.webkit.org/show_bug.cgi?id=148538
3269         http://trac.webkit.org/changeset/189338
3270
3271 2015-09-03  Brian Burg  <bburg@apple.com>
3272
3273         Web Inspector: InspectorController should support multiple frontend channels
3274         https://bugs.webkit.org/show_bug.cgi?id=148538
3275
3276         Reviewed by Joseph Pecoraro.
3277
3278         InspectorClients must explicitly disconnect their frontend channel(s) from the
3279         inspected page's InspectorController.
3280
3281         To make this possible, DumpRenderTree should not destroy non-primary views until
3282         it has tried to close any abandoned Web Inspector instances. Performing teardown
3283         in the reverse order prevents disconnection of the frontend channel because that
3284         prematurely destroys the inspector frontend client.
3285
3286         * DumpRenderTree/mac/DumpRenderTree.mm:
3287         (runTest):
3288         * DumpRenderTree/win/DumpRenderTree.cpp:
3289         (runTest):
3290
3291 2015-09-03  Timothy Hatcher  <timothy@apple.com>
3292
3293         Update WebKit nightly icon to be more like Safari
3294         https://bugs.webkit.org/show_bug.cgi?id=148768
3295
3296         Reviewed by Joseph Pecoraro.
3297
3298         * WebKitLauncher/webkit.icns:
3299
3300 2015-09-03  Geoffrey Garen  <ggaren@apple.com>
3301
3302         JavaScriptCore should have some ES6 conformance tests
3303         https://bugs.webkit.org/show_bug.cgi?id=148771
3304
3305         Reviewed by Chris Dumez.
3306
3307         * Scripts/run-javascriptcore-tests:
3308         (runJSCStressTests): Added es6 as a test suite.
3309
3310         * Scripts/run-jsc-stress-tests: Added es6 as a test suite.
3311
3312         Some of these tests currently fail, so I also added a way to expect
3313         failure for now. We'll migrate failing tests to expected passes as we
3314         fix them.
3315
3316 2015-09-03  Tim Horton  <timothy_horton@apple.com>
3317
3318         Add a test for swipe-start hysteresis
3319         https://bugs.webkit.org/show_bug.cgi?id=148756
3320
3321         Reviewed by Anders Carlsson.
3322
3323         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3324         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3325         (WTR::cacheTestRunnerCallback):
3326         (WTR::TestRunner::clearTestRunnerCallbacks):
3327         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3328         Make sure that we log if a client tries to install a callback twice
3329         (since we use .add, the second call would not work).
3330
3331         Also, add clearTestRunnerCallbacks so tests can swap out installed
3332         callbacks.
3333
3334 2015-09-03  Anders Carlsson  <andersca@apple.com>
3335
3336         DumpRenderTree should automatically compute HTTP URLs for HTTP tests
3337         https://bugs.webkit.org/show_bug.cgi?id=148746
3338         rdar://problem/22568073
3339
3340         Reviewed by Tim Horton.
3341
3342         * DumpRenderTree/mac/DumpRenderTree.mm:
3343         (computeTestURL):
3344         Compute the test URL from the passed in path or URL. Special-case paths that contain /LayoutTests/http/tests.
3345
3346         (runTest):
3347         Call computeTestURL.
3348
3349         (testPathFromURL):
3350         Get rid of this; computeTestURL does this for us now.
3351
3352         * Scripts/webkitpy/port/driver.py:
3353         (Driver._command_from_driver_input):
3354         Don't convert HTTP test paths to URLS before passing them to DumpRenderTree on Mac. That's handled by DRT itself now.
3355
3356 2015-09-03  Tim Horton  <timothy_horton@apple.com>
3357
3358         Swipe tests fail on Mavericks
3359         https://bugs.webkit.org/show_bug.cgi?id=148752
3360
3361         Reviewed by Beth Dakin.
3362
3363         * WebKitTestRunner/mac/EventSenderProxy.mm:
3364
3365 2015-09-03  Tim Horton  <timothy_horton@apple.com>
3366
3367         Fix the 32-bit build
3368
3369         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3370         (WTR::PlatformWebView::setNavigationGesturesEnabled):
3371
3372 2015-09-03  Tim Horton  <timothy_horton@apple.com>
3373
3374         Remove some logging that wasn't meant to be in the tree
3375
3376         * WebKitTestRunner/mac/EventSenderProxy.mm:
3377         (WTR::EventSenderProxy::swipeGestureWithWheelAndMomentumPhases):
3378
3379 2015-09-03  Tim Horton  <timothy_horton@apple.com>
3380
3381         [Mac] Add support for testing swipes
3382         https://bugs.webkit.org/show_bug.cgi?id=148700
3383
3384         Reviewed by Beth Dakin.
3385
3386         * WebKitTestRunner/EventSenderProxy.h:
3387         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
3388         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3389         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3390         (WTR::cgEventPhaseFromString):
3391         (WTR::cgEventMomentumPhaseFromString):
3392         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
3393         (WTR::EventSendingController::swipeGestureWithWheelAndMomentumPhases):
3394         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
3395         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3396         (WTR::InjectedBundle::didReceiveMessageToPage):
3397         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3398         (WTR::TestRunner::installDidBeginSwipeCallback):
3399         (WTR::TestRunner::installWillEndSwipeCallback):
3400         (WTR::TestRunner::installDidEndSwipeCallback):
3401         (WTR::TestRunner::installDidRemoveSwipeSnapshotCallback):
3402         (WTR::TestRunner::callDidBeginSwipeCallback):
3403         (WTR::TestRunner::callWillEndSwipeCallback):
3404         (WTR::TestRunner::callDidEndSwipeCallback):
3405         (WTR::TestRunner::callDidRemoveSwipeSnapshotCallback):
3406         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3407         * WebKitTestRunner/TestController.cpp:
3408         (WTR::TestController::createOtherPage):
3409         (WTR::TestController::createWebViewWithOptions):
3410         (WTR::TestController::didReceiveMessageFromInjectedBundle):
3411         (WTR::TestController::didBeginNavigationGesture):
3412         (WTR::TestController::willEndNavigationGesture):
3413         (WTR::TestController::didEndNavigationGesture):
3414         (WTR::TestController::didRemoveNavigationGestureSnapshot):
3415         * WebKitTestRunner/TestController.h:
3416         * WebKitTestRunner/TestInvocation.cpp:
3417         (WTR::TestInvocation::didBeginSwipe):
3418         (WTR::TestInvocation::willEndSwipe):
3419         (WTR::TestInvocation::didEndSwipe):
3420         (WTR::TestInvocation::didRemoveSwipeSnapshot):
3421         * WebKitTestRunner/TestInvocation.h:
3422         Add callbacks when navigation gestures didBegin/willEnd/didEnd, and
3423         when the snapshot is removed.
3424
3425         Add swipeGestureWithWheelAndMomentumPhases, just like the equivalent
3426         mouseScrollBy function.
3427
3428         * WebKitTestRunner/mac/EventSenderProxy.mm:
3429         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:phase:time:eventNumber:]):
3430         (-[EventSenderSyntheticEvent type]):
3431         (-[EventSenderSyntheticEvent subtype]):
3432         (-[EventSenderSyntheticEvent locationInWindow]):
3433         (-[EventSenderSyntheticEvent location]):
3434         (-[EventSenderSyntheticEvent momentumPhase]):
3435         (-[EventSenderSyntheticEvent _isTouchesEnded]):
3436         (-[EventSenderSyntheticEvent _cgsEventRecord]):
3437         Rename EventSenderPressureEvent to EventSenderSyntheticEvent and add some
3438         more adjustable values.
3439
3440         (WTR::EventSenderProxy::mouseForceDown):
3441         (WTR::EventSenderProxy::mouseForceUp):
3442         (WTR::EventSenderProxy::mouseForceChanged):
3443         Adopt EventSenderSyntheticEvent.
3444
3445         (WTR::nsEventPhaseFromCGEventPhase):
3446         (WTR::EventSenderProxy::swipeGestureWithWheelAndMomentumPhases):
3447         Make use of EventSenderSyntheticEvent to synthesize swipe gesture events.
3448
3449         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3450         (WTR::PlatformWebView::PlatformWebView):
3451         Enable swipe.
3452
3453 2015-09-03  Myles C. Maxfield  <mmaxfield@apple.com>
3454
3455         [WK2] Allow tagging tests with metadata which needs to be known at web process creation time
3456         https://bugs.webkit.org/show_bug.cgi?id=148723
3457
3458         Reviewed by Anders Carlsson.
3459
3460         * WebKitTestRunner/TestController.cpp:
3461         (WTR::testPath):
3462         (WTR::updateViewOptionsFromTestHeader):
3463         (WTR::TestController::viewOptionsForTest):
3464
3465 2015-09-03  Lucas Forschler  <lforschler@apple.com>
3466
3467         Test commit.
3468
3469 2015-09-02  Tim Horton  <timothy_horton@apple.com>
3470
3471         Add a modern API way to know that the navigation gesture snapshot was removed, for WebKitTestRunner
3472         https://bugs.webkit.org/show_bug.cgi?id=148693
3473
3474         Reviewed by Anders Carlsson.
3475
3476         * WebKitTestRunner/TestController.cpp:
3477         (WTR::TestController::createOtherPage):
3478         (WTR::TestController::createWebViewWithOptions):
3479
3480 2015-09-02  Carlos Garcia Campos  <cgarcia@igalia.com>
3481
3482         REGRESSION(r188548): Some tests crash after r188548 because injected bundle messages are received after the test finishes
3483         https://bugs.webkit.org/show_bug.cgi?id=148529
3484
3485         Reviewed by Darin Adler.
3486
3487         When there are pending EventSender messages after a test finishes,
3488         they could be processed in the main loop started by the
3489         resetStateToConsistentValues(), but the old EventSender has been
3490         replaced by a new one at that point. The new Eventsender can crash
3491         when processing messages that were sent to the old one. To avoid
3492         this, we return early when receiving an EventSender message and
3493         the TestController state is not RunningTest.
3494
3495         * WebKitTestRunner/TestController.cpp:
3496         (WTR::TestController::didReceiveKeyDownMessageFromInjectedBundle):
3497         (WTR::TestController::didReceiveMessageFromInjectedBundle):
3498
3499 2015-09-02  Carlos Garcia Campos  <cgarcia@igalia.com>
3500
3501         REGRESSION(r188548): TestController state is Resseting while tests are running after r188548
3502         https://bugs.webkit.org/show_bug.cgi?id=148528
3503
3504         Reviewed by Darin Adler.
3505
3506         Before r188548 resetStateToConsistentValues() was called in
3507         TestController::run(), before tests are run, but now it's called
3508         for every test in TestInvocation::invoke(), after m_status has
3509         changed to RunningTest.
3510
3511         * WebKitTestRunner/TestController.cpp:
3512         (WTR::TestController::resetStateToConsistentValues): Use
3513         TemporaryChange to reset m_state ot its previous value after reset
3514         is done.
3515
3516 2015-08-31  Jason Marcell  <jmarcell@apple.com>
3517
3518         Modify prepare-Changelog to be aware of files that are marked as tests as well as files
3519         that are marked as requiring corresponding tests.
3520         https://bugs.webkit.org/show_bug.cgi?id=148498
3521         <rdar://problem/21555314>
3522
3523         Reviewed by Dan Bernstein and David Kilzer.
3524
3525         * Scripts/prepare-ChangeLog: Added "attributeCache" to cache Subversion properties in order to
3526         simulate Git's attribute behevaior.
3527         (main): Added "requiresTests" array to contain files that require tests.
3528         (generateNewChangeLogs): Checks "requiresTests" array to determine whether to inject "tests"
3529         section in ChangeLog.
3530         (attributeCommand): Queries a given file for a given Git attribute value. If using Subversion,
3531         however, we check if the file or any containing folder has the given property set to "1" and
3532         return 1 if so; return 0 otherwise.
3533         (generateFileList): Adds files to "requiresTests" array if Git attribute is set to "1". Also
3534         adds files to "addedRegressionTests" array if "test" attribute is set to "1".
3535
3536 2015-08-26  Andy Estes  <aestes@apple.com>
3537
3538         [Content Filtering] Determine navigation and content policy before continuing to filter a load
3539         https://bugs.webkit.org/show_bug.cgi?id=148506
3540
3541         Reviewed by Brady Eidson.
3542
3543         Added download API tests covering every decision and decision point.
3544         Removed _WKDownload.AsynchronousDownloadPolicy in favor of these new tests.
3545
3546         * TestWebKitAPI/Configurations/Base.xcconfig: Added $(BUILT_PRODUCTS_DIR)/WebCoreTestSupport to the header search path.
3547         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Removed it from here.
3548         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParametersPlugIn.mm:
3549         (-[BundleParametersPlugIn observeValueForKeyPath:ofObject:change:context:]): Called -valueForKeyPath:, which
3550         returns an id, instead of -valueForKey:, which always returns an NSString even if the object is of another type.
3551         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm: Added a class that can send a MockContentFilter
3552         decision and decision point as a bundle parameter.
3553         (+[MockContentFilterEnabler supportsSecureCoding]):
3554         (-[MockContentFilterEnabler copyWithZone:]):
3555         (-[MockContentFilterEnabler initWithCoder:]):
3556         (-[MockContentFilterEnabler initWithDecision:decisionPoint:]):
3557         (-[MockContentFilterEnabler encodeWithCoder:]):
3558         (configurationWithContentFilterSettings): Added a helper function to create a WKWebViewConfiguration with MockConentFilter settings.
3559         (TEST): Renamed ContentFiltering.ServerRedirect to ContentFiltering.URLAfterServerRedirect.
3560         (-[BecomeDownloadDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Decided _WKNavigationResponsePolicyBecomeDownload.
3561         (-[BecomeDownloadDelegate webView:didFailProvisionalNavigation:withError:]): Set isDone to true.
3562         (-[BecomeDownloadDelegate webView:didFinishNavigation:]): Ditto.
3563         (-[ContentFilteringDownloadDelegate _downloadDidStart:]): Set downloadDidStart to true.
3564         (downloadTest): Added a helper function to test downloads with a given decision and decision point.
3565         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm: Added a corresponding bundle class that decodes
3566         the MockContentFilter decision and decision point, and sets these values in the MockContentFilterSettings
3567         singleton. This class is duplicated in the bundle to prevent TestWebKitAPI from having to link to WebCoreTestSupport.
3568         (+[MockContentFilterEnabler supportsSecureCoding]):
3569         (-[MockContentFilterEnabler copyWithZone:]):
3570         (-[MockContentFilterEnabler initWithCoder:]):
3571         (-[MockContentFilterEnabler dealloc]):
3572         (-[MockContentFilterEnabler encodeWithCoder:]):
3573         (-[ContentFilteringPlugIn webProcessPlugIn:initializeWithObject:]): Start observing changes to the MockContentFilterEnabler key path.
3574         (-[ContentFilteringPlugIn dealloc]): Stop observing.
3575         (-[ContentFilteringPlugIn observeValueForKeyPath:ofObject:change:context:]): Store a MockContentFilterEnabler in _contentFilterEnabler.
3576         (+[ServerRedirectPlugIn initialize]): Deleted.
3577         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
3578         (-[AsynchronousDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
3579         (-[AsynchronousDownloadDelegate _downloadDidStart:]): Deleted.
3580         (TEST): Deleted.
3581
3582 2015-08-31  Filip Pizlo  <fpizlo@apple.com>
3583
3584         Skip slow lock tests on Windows/debug
3585         https://bugs.webkit.org/show_bug.cgi?id=148643
3586
3587         Reviewed by Alexey Proskuryakov.
3588
3589         The lock tests simulate a critical section by doing some floating point math, and then either
3590         make those critical sections very long or invoke them many times. This appears to be
3591         particularly slow on Windows in debug mode, maybe because Visual Studio's debug build makes
3592         that kind of computation slow.
3593
3594         These tests are almost as useful in release as they are in debug, so it's probably better to
3595         just skip the in debug on platforms where this causes timeouts.
3596
3597         * TestWebKitAPI/Tests/WTF/Lock.cpp:
3598         (TestWebKitAPI::runLockTest):
3599         (TestWebKitAPI::skipSlow):
3600         (TestWebKitAPI::TEST):
3601
3602 2015-08-29  Chris Fleizach  <cfleizach@apple.com>
3603
3604         AX: When navigating the elements of a scrollable element with VoiceOver, the scrollTop() position of the element does not permanently change
3605         https://bugs.webkit.org/show_bug.cgi?id=125720
3606
3607         Reviewed by Daniel Bates.
3608
3609         Add support for scrollToMakeVisibleWithSubFocus and scrollToGlobalPoint.
3610
3611         * DumpRenderTree/AccessibilityUIElement.cpp:
3612         (pressCallback):
3613         (scrollToMakeVisibleWithSubFocusCallback):
3614         (scrollToGlobalPointCallback):
3615         (scrollToMakeVisibleCallback):
3616         (AccessibilityUIElement::getJSClass):
3617         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3618         (AccessibilityUIElement::scrollToMakeVisible):
3619         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
3620         (AccessibilityUIElement::scrollToGlobalPoint):
3621         (AccessibilityUIElement::selectedTextRange):
3622         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3623         (AccessibilityUIElement::AccessibilityUIElement):
3624         (AccessibilityUIElement::mathPrescriptsDescription):
3625         (AccessibilityUIElement::scrollToMakeVisible):
3626         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
3627         (AccessibilityUIElement::scrollToGlobalPoint):
3628         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3629         (WTR::AccessibilityUIElement::isTextMarkerValid):
3630         (WTR::AccessibilityUIElement::textMarkerForIndex):
3631         (WTR::AccessibilityUIElement::scrollToMakeVisible):
3632         (WTR::AccessibilityUIElement::scrollToGlobalPoint):
3633         (WTR::AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
3634         (WTR::AccessibilityUIElement::supportedActions):
3635         (WTR::AccessibilityUIElement::mathPostscriptsDescription):
3636         (WTR::AccessibilityUIElement::mathPrescriptsDescription):
3637         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3638         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3639         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3640         (WTR::AccessibilityUIElement::scrollToMakeVisible):
3641         (WTR::AccessibilityUIElement::scrollToGlobalPoint):
3642         (WTR::AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
3643         (WTR::AccessibilityUIElement::selectedTextRange):
3644         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3645         (WTR::AccessibilityUIElement::scrollToMakeVisible):
3646         (WTR::AccessibilityUIElement::scrollToGlobalPoint):
3647         (WTR::AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
3648         (WTR::AccessibilityUIElement::selectedTextRange):
3649
3650 2015-08-28  Timothy Horton  <timothy_horton@apple.com>
3651
3652         Add a mysteriously nonproblematic missing comma.
3653
3654         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3655         (TestExpectationParser._collect_matching_tests):
3656         (TestExpectationParser):
3657
3658 2015-08-28  Timothy Horton  <timothy_horton@apple.com>
3659
3660         Remove an old temporary script that has served its purpose
3661
3662         * Scripts/convert-test-expectations: Removed.
3663
3664 2015-08-28  Jer Noble  <jer.noble@apple.com>
3665
3666         [iOS] Add WebKit/WebKit2 settings to control automatic data loading
3667         https://bugs.webkit.org/show_bug.cgi?id=148579
3668
3669         Reviewed by Anders Carlsson.
3670
3671         In DumpRenderTree, set the new mediaDataLoadsAutomatically preference to YES.
3672
3673         In WebKitTestRunner, do the same for the new _mediaDataLoadsAutomatically configuration property,
3674         and also set the existing requiresUserActionForMediaPlayback configuration property to NO.
3675
3676         * DumpRenderTree/mac/DumpRenderTree.mm:
3677         (resetWebPreferencesToConsistentValues):
3678         (resetWebViewToConsistentStateBeforeTesting):
3679         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3680         (WTR::initializeWebViewConfiguration):
3681
3682 2015-08-28  Alexey Proskuryakov  <ap@apple.com>
3683
3684         Fix run-webkit-tests --additional-env-var="DYLD_INSERT_LIBRARIES=..."
3685         https://bugs.webkit.org/show_bug.cgi?id=148592
3686
3687         Reviewed by Tim Horton.
3688
3689         * Scripts/webkitpy/port/base.py:
3690         (Port.to.setup_environ_for_server):
3691         (Port.to):
3692         (Port.to._append_value_colon_separated):
3693         (Port.to.show_results_html_file):
3694         * Scripts/webkitpy/port/ios.py:
3695         (IOSSimulatorPort.setup_environ_for_server):
3696         * Scripts/webkitpy/port/mac.py:
3697         (MacPort.setup_environ_for_server):
3698
3699 2015-08-28  Filip Pizlo  <fpizlo@apple.com>
3700
3701         LICM should be sound even if the CFG has changed
3702         https://bugs.webkit.org/show_bug.cgi?id=148259
3703
3704         Reviewed by Benjamin Poulain.
3705
3706         Add a utility for creating tests that set some uncommon option.
3707
3708         * Scripts/run-jsc-stress-tests:
3709
3710 2015-08-28  Brent Fulgham  <bfulgham@apple.com>
3711
3712         [Win] Unreviewed EWS correction.
3713
3714         * EWSTools/start-queue-win.sh: Update settings to point to VS2015.
3715
3716 2015-08-28  Jer Noble  <jer.noble@apple.com>
3717
3718         [iOS] Make the AllowsInlineMediaPlayback preference work in WebKit / WebKit2.
3719         https://bugs.webkit.org/show_bug.cgi?id=147512
3720
3721         Reviewed by Anders Carlsson.
3722
3723         Set the value of WebKitAllowsInlineMediaPlayback / WKPreferencesSetMediaPlaybackAllowsInline()
3724         to a consistent (true) value.
3725
3726         * DumpRenderTree/mac/DumpRenderTree.mm:
3727         (setDefaultsToConsistentValuesForTesting):
3728         * WebKitTestRunner/TestController.cpp:
3729         (WTR::TestController::resetPreferencesToConsistentValues):
3730
3731 2015-08-28  Tim Horton  <timothy_horton@apple.com>
3732
3733         Add navigation gesture callbacks to WKPageNavigationClient
3734         https://bugs.webkit.org/show_bug.cgi?id=148568
3735         <rdar://problem/22371346>
3736
3737         Reviewed by Anders Carlsson.
3738
3739         * WebKitTestRunner/TestController.cpp:
3740         (WTR::TestController::createOtherPage):
3741         (WTR::TestController::createWebViewWithOptions):
3742         Add some zeroes.
3743
3744 2015-08-28  Alexey Proskuryakov  <ap@apple.com>
3745
3746         [Mac] kill-old-processes should kill more processes
3747         https://bugs.webkit.org/show_bug.cgi?id=148577
3748
3749         Reviewed by Tim Horton.
3750
3751         * BuildSlaveSupport/kill-old-processes:
3752
3753 2015-08-28  Jason Marcell  <jmarcell@apple.com>
3754
3755         The status message for combined builder queues should say "all builds succeeded" if everything
3756         built correctly.
3757         https://bugs.webkit.org/show_bug.cgi?id=148535
3758
3759         Reviewed by David Kilzer and Alexey Proskuryakov.
3760
3761         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
3762         (BuildbotCombinedQueueView.prototype.update): Make status message for combined builder queues
3763         say "all builds succeeded" if everything built correctly.
3764
3765 2015-08-28  Carlos Garcia Campos  <cgarcia@igalia.com>
3766
3767         [GTK] Simplify the internal API to create a WebView
3768         https://bugs.webkit.org/show_bug.cgi?id=148570
3769
3770         Reviewed by Žan Doberšek.
3771
3772         * TestWebKitAPI/PlatformWebView.h: Add initialize method for GTK+ too.
3773         * TestWebKitAPI/gtk/PlatformWebViewGtk.cpp:
3774         (TestWebKitAPI::PlatformWebView::PlatformWebView): Implement all
3775         PlatformWebView constructors that end up calling initialize with a PageConfiguration.
3776         (TestWebKitAPI::PlatformWebView::initialize): Create the WebView
3777         passing the received PageConfiguration.
3778         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3779         (WTR::PlatformWebView::PlatformWebView): Create the WebView
3780         passing the received PageConfiguration.
3781
3782 2015-08-27  Aakash Jain  <aakash_jain@apple.com>
3783
3784         iOS Simulator API tests fails as Simulator is not running
3785         https://bugs.webkit.org/show_bug.cgi?id=148501
3786         rdar://problem/22447525
3787
3788         Reviewed by Daniel Bates.
3789
3790         This change is a workaround for <rdar://problem/22388812>.
3791
3792          * Scripts/run-api-tests: Launch the iOS Simulator before starting the API Tests
3793          and quit it on program termination when running tests on the iOS port.
3794          * Scripts/webkitdirs.pm: Store string "For WebKit Development" in constant
3795          SIMULATOR_DEVICE_SUFFIX_FOR_WEBKIT_DEVELOPMENT to make it consistently reusable.
3796
3797 2015-08-27  Alex Christensen  <achristensen@webkit.org>
3798
3799         Make DLLLauncherMain executables dependent on dll
3800         https://bugs.webkit.org/show_bug.cgi?id=148548
3801
3802         Reviewed by Brent Fulgham.
3803
3804         * DumpRenderTree/CMakeLists.txt:
3805         * DumpRenderTree/PlatformWin.cmake:
3806         * MiniBrowser/win/CMakeLists.txt:
3807         * TestWebKitAPI/CMakeLists.txt:
3808         * TestWebKitAPI/PlatformWin.cmake:
3809
3810 2015-08-27  Lucas Forschler  <lforschler@apple.com>
3811
3812         Remove Mac slaves 188/189 after being replaced with 400/401.
3813
3814         Unreviewed.
3815
3816         * BuildSlaveSupport/build.webkit.org-config/config.json:
3817
3818 2015-08-27  Lucas Forschler  <lforschler@apple.com>
3819
3820         Add two bots to the Mac Yosemite queue.
3821         This is to eventually replace bots188/189, which will be removed after 400/401 are vetted.
3822
3823         Unreviewed.
3824
3825         * BuildSlaveSupport/build.webkit.org-config/config.json:
3826
3827 2015-08-27  Alex Christensen  <achristensen@webkit.org>
3828
3829         [Win CMake] Fix incremental build after r188673
3830         https://bugs.webkit.org/show_bug.cgi?id=148539
3831
3832         Reviewed by Brent Fulgham.
3833
3834         * TestWebKitAPI/PlatformWin.cmake:
3835         Copy forwarding headers from WebCore before building in case that was not yet done.
3836         It used to be done when running CMake, but now it's a build step.
3837
3838 2015-08-27  Nan Wang  <n_wang@apple.com>
3839
3840         AX: Fix accessibility/select-element-at-index.html test
3841         https://bugs.webkit.org/show_bug.cgi?id=148516
3842
3843         Reviewed by Chris Fleizach.
3844
3845         Implemented setSelectedChildAtIndex and removeSelectionAtIndex for mac.
3846
3847         * DumpRenderTree/AccessibilityUIElement.cpp:
3848         (setSelectedChildCallback):
3849         (setSelectedChildAtIndexCallback):
3850         (removeSelectionAtIndexCallback):
3851         (elementAtPointCallback):
3852         (sentenceAtOffsetCallback):
3853         (stringForSelectionCallback):
3854         (AccessibilityUIElement::getJSClass):
3855         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3856         (AccessibilityUIElement::setSelectedChild):
3857         (AccessibilityUIElement::setSelectedChildAtIndex):
3858         (AccessibilityUIElement::removeSelectionAtIndex):
3859         (AccessibilityUIElement::accessibilityValue):
3860         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3861         (WTR::AccessibilityUIElement::wordAtOffset):
3862         (WTR::AccessibilityUIElement::lineAtOffset):
3863         (WTR::AccessibilityUIElement::sentenceAtOffset):
3864         (WTR::AccessibilityUIElement::isSelectable):
3865         (WTR::AccessibilityUIElement::isMultiSelectable):
3866         (WTR::AccessibilityUIElement::setSelectedChild):
3867         (WTR::AccessibilityUIElement::setSelectedChildAtIndex):
3868         (WTR::AccessibilityUIElement::removeSelectionAtIndex):
3869         (WTR::AccessibilityUIElement::selectedChildrenCount):
3870         (WTR::AccessibilityUIElement::selectedChildAtIndex):
3871         (WTR::AccessibilityUIElement::isExpanded):
3872         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3873         (WTR::AccessibilityUIElement::setSelectedChild):
3874         (WTR::AccessibilityUIElement::setSelectedChildAtIndex):
3875         (WTR::AccessibilityUIElement::removeSelectionAtIndex):
3876         (WTR::AccessibilityUIElement::accessibilityValue):
3877
3878 2015-08-27  Alex Christensen  <achristensen@webkit.org>
3879
3880         Build fix after r188982
3881
3882         * MiniBrowser/win/CMakeLists.txt:
3883         The directory structure changed in the move.
3884
3885 2015-08-27  Michael Catanzaro  <mcatanzaro@igalia.com>
3886
3887         [GTK] Unreviewed, install-dependencies should install geoclue2 on Fedora
3888
3889         geoclue-devel is for obsolete geoclue. Install geoclue2-devel instead.
3890
3891         * gtk/install-dependencies:
3892
3893 2015-08-27  Carlos Garcia Campos  <cgarcia@igalia.com>
3894
3895         Unreviewed. Mark WTF_WordLock.ContendedShortSection as slow too.
3896
3897         * Scripts/run-gtk-tests:
3898         (TestRunner):
3899
3900 2015-08-27  Carlos Garcia Campos  <cgarcia@igalia.com>
3901
3902         Fix GTK+ WTR crashes in initializeMainRunLoop()
3903
3904         Rubber-stamped by Žan Doberšek.
3905
3906         Initialize threading and main thread before
3907         RunLoop::initializeMainRunLoop(), since the GLib implementation of
3908         the RunLoop uses isMainThread() to decide whether to create a new
3909         GMainContext or use the default one. Also use RunLoop::run() and
3910         ::stop() instead of gtk_main/quit.
3911
3912         * WebKitTestRunner/TestController.cpp:
3913         (WTR::TestController::initialize):
3914         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
3915         (WTR::TestController::notifyDone):
3916         (WTR::TestController::platformRunUntil):
3917
3918 2015-08-27  Filip Pizlo  <fpizlo@apple.com>
3919
3920         Unreviewed, further shorten a test that times out because it's very long
3921         running.
3922
3923         I've locally run these tests on repeat for 24 hours and found no genuine
3924         failures, like deadlocks. So, the timeouts are probably because the test
3925         machine is slow and debug is slow. We should just run this test for fewer
3926         iterations.
3927
3928         * TestWebKitAPI/Tests/WTF/Lock.cpp:
3929         (TestWebKitAPI::TEST):
3930
3931 2015-08-26  Ryuan Choi  <ryuan.choi@navercorp.com>
3932
3933         Unreviewed build fix attempt on EFL
3934
3935         * WebKitTestRunner/PlatformEfl.cmake:
3936
3937 2015-08-26  Alex Christensen  <achristensen@webkit.org>
3938
3939         Build fix after r188982
3940
3941         * MiniBrowser/win/CMakeLists.txt:
3942         Find .rc files in correct directory.
3943
3944 2015-08-26  Ryuan Choi  <ryuan.choi@navercorp.com>
3945
3946         [EFL] Bump cairo version to 1.14.2
3947         https://bugs.webkit.org/show_bug.cgi?id=148474
3948
3949         Reviewed by Csaba Osztrogonác.
3950
3951         * efl/jhbuild.modules:
3952
3953 2015-08-26  Andy Estes  <aestes@apple.com>
3954
3955         Crash when following a Google search link to Twitter with Limit Adult Content enabled
3956         https://bugs.webkit.org/show_bug.cgi?id=147651
3957
3958         Rubber-stamped by Brady Eidson.
3959
3960         Taught TestRunner how to decide the navigation policy after a delay.
3961
3962         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3963         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3964         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
3965         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3966         (WTR::TestRunner::setShouldDecideNavigationPolicyAfterDelay):
3967         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3968         (WTR::TestRunner::shouldDecideNavigationPolicyAfterDelay):
3969         * WebKitTestRunner/TestController.cpp:
3970         (WTR::TestController::initialize):
3971         (WTR::TestController::resetStateToConsistentValues):
3972         (WTR::TestController::decidePolicyForNavigationAction):
3973         * WebKitTestRunner/TestController.h:
3974         (WTR::TestController::setShouldDecideNavigationPolicyAfterDelay):
3975         * WebKitTestRunner/TestInvocation.cpp:
3976         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3977
3978 2015-08-26  Brent Fulgham  <bfulgham@apple.com>
3979
3980         [Win] Rename 'WinLauncher' to 'MiniBrowser'
3981         https://bugs.webkit.org/show_bug.cgi?id=148485
3982
3983         Reviewed by Alex Christensen
3984
3985         Move the WinLauncher project and source files to a subdirectory
3986         of MiniBrowser. Globally change WinLauncher -> MiniBrowser in the
3987         source code and project files.
3988
3989         * MiniBrowser/MiniBrowser.vcxproj: Copied from WinLauncher/WinLauncher.vcxproj.
3990         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.ico: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.ico.
3991         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.rc: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.rc.
3992         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.vcxproj: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.
3993         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.vcxproj.filters: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.filters.
3994         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCF.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherCF.props.
3995         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCFLite.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherCFLite.props.
3996         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCommon.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherCommon.props.
3997         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserDebug.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherDebug.props.
3998         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc.
3999         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.vcxproj: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.
4000         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.vcxproj.filters: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters.
4001         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibCommon.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props.
4002         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibDebug.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibDebug.props.
4003         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibPostBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibPostBuild.cmd.
4004         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibPreBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd.
4005         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibProduction.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibProduction.props.
4006         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibRelease.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibRelease.props.
4007         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h.
4008         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserPostBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherPostBuild.cmd.
4009         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserPreBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherPreBuild.cmd.
4010         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserProduction.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherProduction.props.
4011         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserRelease.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherRelease.props.
4012         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserResource.h: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherResource.h.
4013         * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.ico: Removed.
4014         * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.rc: Removed.
4015         * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.vcxproj: Removed.
4016         * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.vcxproj.filters: Removed.
4017         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherCF.props: Removed.
4018         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherCFLite.props: Removed.
4019         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherCommon.props: Removed.
4020         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherDebug.props: Removed.
4021         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLib.rc: Removed.
4022         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLib.vcxproj: Removed.
4023         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLib.vcxproj.filters: Removed.
4024         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibCommon.props: Removed.
4025         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibDebug.props: Removed.
4026         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibPostBuild.cmd: Removed.
4027         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibPreBuild.cmd: Removed.
4028         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibProduction.props: Removed.
4029         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibRelease.props: Removed.
4030         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibResource.h: Removed.
4031         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherPostBuild.cmd: Removed.
4032         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherPreBuild.cmd: Removed.
4033         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherProduction.props: Removed.
4034         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherRelease.props: Removed.
4035         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherResource.h: Removed.
4036         * MiniBrowser/win: Copied from WinLauncher.
4037         * MiniBrowser/win/Common.cpp:
4038         * MiniBrowser/win/MiniBrowser.cpp: Copied from WinLauncher/WinLauncher.cpp.
4039         * MiniBrowser/win/MiniBrowser.h: Copied from WinLauncher/WinLauncher.h.
4040         * MiniBrowser/win/MiniBrowserReplace.h: Copied from WinLauncher/WinLauncherReplace.h.
4041         * MiniBrowser/win/MiniBrowserWebHost.cpp: Copied from WinLauncher/WinLauncherWebHost.cpp.
4042         * MiniBrowser/win/MiniBrowserWebHost.h: Copied from WinLauncher/WinLauncherWebHost.h.
4043         * MiniBrowser/win/PageLoadTestClient.cpp:
4044         * MiniBrowser/win/PageLoadTestClient.h:
4045         * MiniBrowser/win/ResourceLoadDelegate.cpp:
4046         * MiniBrowser/win/ResourceLoadDelegate.h:
4047         * MiniBrowser/win/WinLauncher.cpp: Removed.
4048         * MiniBrowser/win/WinLauncher.h: Removed.
4049         * MiniBrowser/win/WinLauncher.vcxproj: Removed.
4050         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.ico: Removed.
4051         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.rc: Removed.
4052         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.vcxproj: Removed.
4053         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.vcxproj.filters: Removed.
4054         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherCF.props: Removed.
4055         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherCFLite.props: Removed.
4056         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherCommon.props: Removed.
4057         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherDebug.props: Removed.
4058         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLib.rc: Removed.
4059         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Removed.
4060         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters: Removed.
4061         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibCommon.props: Removed.
4062         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibDebug.props: Removed.
4063         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibPostBuild.cmd: Removed.
4064         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd: Removed.
4065         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibProduction.props: Removed.
4066         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibRelease.props: Removed.
4067         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibResource.h: Removed.
4068         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherPostBuild.cmd: Removed.
4069         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherPreBuild.cmd: Removed.
4070         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherProduction.props: Removed.
4071         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherRelease.props: Removed.
4072         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherResource.h: Removed.
4073         * MiniBrowser/win/WinLauncher.vcxproj/small.ico: Removed.
4074         * MiniBrowser/win/WinLauncherReplace.h: Removed.
4075         * MiniBrowser/win/WinLauncherWebHost.cpp: Removed.
4076         * MiniBrowser/win/WinLauncherWebHost.h: Removed.
4077         * MiniBrowser/win/WinMain.cpp:
4078         * WinLauncher: Removed.
4079         * WinLauncher/AccessibilityDelegate.cpp: Removed.
4080         * WinLauncher/AccessibilityDelegate.h: Removed.
4081         * WinLauncher/CMakeLists.txt: Removed.
4082         * WinLauncher/Common.cpp: Removed.
4083         * WinLauncher/DOMDefaultImpl.cpp: Removed.
4084         * WinLauncher/DOMDefaultImpl.h: Removed.
4085         * WinLauncher/PageLoadTestClient.cpp: Removed.
4086         * WinLauncher/PageLoadTestClient.h: Removed.
4087         * WinLauncher/PrintWebUIDelegate.cpp: Removed.
4088         * WinLauncher/PrintWebUIDelegate.h: Removed.
4089         * WinLauncher/ResourceLoadDelegate.cpp: Removed.
4090         * WinLauncher/ResourceLoadDelegate.h: Removed.
4091         * WinLauncher/WebDownloadDelegate.cpp: Removed.
4092         * WinLauncher/WebDownloadDelegate.h: Removed.
4093         * WinLauncher/WinLauncher.cpp: Removed.
4094         * WinLauncher/WinLauncher.h: Removed.
4095         * WinLauncher/WinLauncher.vcxproj: Removed.
4096         * WinLauncher/WinLauncher.vcxproj/WinLauncher.ico: Removed.
4097         * WinLauncher/WinLauncher.vcxproj/WinLauncher.rc: Removed.
4098         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Removed.
4099         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.filters: Removed.
4100         * WinLauncher/WinLauncher.vcxproj/WinLauncherCF.props: Removed.
4101         * WinLauncher/WinLauncher.vcxproj/WinLauncherCFLite.props: Removed.
4102         * WinLauncher/WinLauncher.vcxproj/WinLauncherCommon.props: Removed.
4103         * WinLauncher/WinLauncher.vcxproj/WinLauncherDebug.props: Removed.
4104         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Removed.
4105         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Removed.
4106         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters: Removed.
4107         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props: Removed.
4108         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibDebug.props: Removed.
4109         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibPostBuild.cmd: Removed.
4110         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd: Removed.
4111         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibProduction.props: Removed.
4112         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibRelease.props: Removed.
4113         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h: Removed.
4114         * WinLauncher/WinLauncher.vcxproj/WinLauncherPostBuild.cmd: Removed.
4115         * WinLauncher/WinLauncher.vcxproj/WinLauncherPreBuild.cmd: Removed.
4116         * WinLauncher/WinLauncher.vcxproj/WinLauncherProduction.props: Removed.
4117         * WinLauncher/WinLauncher.vcxproj/WinLauncherRelease.props: Removed.
4118         * WinLauncher/WinLauncher.vcxproj/WinLauncherResource.h: Removed.
4119         * WinLauncher/WinLauncher.vcxproj/small.ico: Removed.
4120         * WinLauncher/WinLauncherReplace.h: Removed.
4121         * WinLauncher/WinLauncherWebHost.cpp: Removed.
4122         * WinLauncher/WinLauncherWebHost.h: Removed.
4123         * WinLauncher/WinMain.cpp: Removed.
4124         * WinLauncher/resource.h: Removed.
4125         * WinLauncher/stdafx.cpp: Removed.
4126         * WinLauncher/stdafx.h: Removed.
4127         * win/AssembleBuildLogs/AssembleLogs.cmd:
4128
4129 2015-08-26  Brent Fulgham  <bfulgham@apple.com>
4130
4131         [Win] Simplify menu handling code in WinLauncher
4132         https://bugs.webkit.org/show_bug.cgi?id=148461
4133
4134         Reviewed by Zalan Bujtas.
4135
4136         Revise 'ToggleMenuItem' to return a boolean value indicating if
4137         it handled the message. Revise WndProc to use this to decide if it
4138         should pass the message on to the default handler, rather than
4139         duplicating the logic in both places.
4140
4141         * WinLauncher/Common.cpp:
4142         (ToggleMenuItem): Return true if the menu item message was handled.
4143         (WndProc): If 'ToggleMenuItem' did not handle the message, pass
4144         the message tothe default handler.
4145
4146 2015-08-26  Csaba Osztrogonác  <ossy@webkit.org>
4147
4148         Remove unused code after r188948
4149         https://bugs.webkit.org/show_bug.cgi?id=148467
4150
4151         Reviewed by Gyuyoung Kim.
4152
4153         * WebKitTestRunner/TestController.cpp:
4154         (WTR::TestController::platformPreferences): Deleted.
4155
4156 2015-08-26  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
4157
4158         [EFL][GTK] REGRESSION(r188828): All performance tests and almost all layout tests crash
4159         https://bugs.webkit.org/show_bug.cgi?id=148377
4160
4161         Reviewed by Carlos Garcia Campos.
4162
4163         EFL and GTK don't support TestController::platformPreferences() yet which was introduced by r188828.
4164         It caused all crashes of layout test and performance test on EFL and GTK. So this patch implements
4165         TestController::platformPreferences() using WKPageGroupGetPreferences() which was previous thing for
4166         EFL and GTK at the moment.
4167
4168         * WebKitTestRunner/TestController.cpp:
4169         (WTR::TestController::platformWillRunTest):
4170         * WebKitTestRunner/efl/TestControllerEfl.cpp:
4171         (WTR::TestController::platformPreferences):
4172         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
4173         (WTR::TestController::platformPreferences):
4174
4175 2015-08-25  Nan Wang  <n_wang@apple.com>
4176
4177         AX: Enable accessibility/aria-controls.html test for mac
4178         https://bugs.webkit.org/show_bug.cgi?id=148458
4179
4180         Reviewed by Chris Fleizach.
4181
4182         Implemented ariaControlsElementAtIndex(unsigned index).
4183
4184         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
4185         (AccessibilityUIElement::ariaControlsElementAtIndex):
4186       &nb