Teach Buildbot dashboard to parse alternative revision format
[WebKit-https.git] / Tools / ChangeLog
1 2014-01-28  Daniel Bates  <dabates@apple.com>
2
3         Teach Buildbot dashboard to parse alternative revision format
4         https://bugs.webkit.org/show_bug.cgi?id=127561
5
6         Reviewed by Alexey Proskuryakov.
7
8         Add support for extracting the OpenSource and Internal revision numbers when Buildbot
9         returns a dictionary for the value of property got_revision.
10
11         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
12         (isMultiCodebaseGotRevisionProperty): Added.
13         (parseRevisionProperty): Added; parses Buildbot revision property, which can either be a
14         string or a dictionary.
15         (BuildbotIteration.prototype.update.): Modified to call parseRevisionProperty() to determine
16         the OpenSource and Internal revision numbers.
17
18 2014-01-28  Adrian Perez de Castro  <aperez@igalia.com>
19
20         [GTK] Add API to allow setting the process model in WebKitWebContext
21         https://bugs.webkit.org/show_bug.cgi?id=125463
22
23         Reviewed by Carlos Garcia Campos.
24
25         Implements accessors in WebKitWebContext for the process model.
26         The default behavior is unchanged, and a single web process is
27         used. Using WEBKIT_PROCESS_MODEL_ONE_SECONDARY_PROCESS_PER_WEB_VIEW
28         as the process model will make use one web process for each
29         WebKitWebView. This also enables the network process. Setting
30         the process model must be done as early as possible, before the
31         very first web process is spawned.
32
33         * MiniBrowser/gtk/main.c:
34         (main):
35         Enable multiple process mode if the MINIBROWSER_MULTIPROCESS
36         environment variable is defined and not empty.
37         * TestWebKitAPI/GNUmakefile.am:
38         Add new TestMultiprocess test case.
39         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
40         Add new TestMultiprocess test case.
41         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp: Added.
42         (loadChanged):
43         (testMultipleSecondaryProcesses):
44         (initializeWebExtensions):
45         (beforeAll):
46         (afterAll):
47         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
48         (methodCallCallback):
49         Implement the GetProcessIdentifier D-Bus method.
50         (makeBusName):
51         Choose a different bus name when the web extension is used
52         from TestMultiprocess.
53         (webkit_web_extension_initialize_with_user_data):
54         Use makeBusName() to choose the bus name.
55
56 2014-01-28  Carlos Garcia Campos  <cgarcia@igalia.com>
57
58         [SOUP] Remove soupURIToKURL
59         https://bugs.webkit.org/show_bug.cgi?id=127104
60
61         Reviewed by Martin Robinson.
62
63         * TestWebKitAPI/GNUmakefile.am: Add soup cppflags to WebCore unit
64         tests, because URL.h now includes GUniquePtrSoup.h.
65         * TestWebKitAPI/CMakeLists.txt: Ditto.
66         * WebKitTestRunner/PlatformEfl.cmake: Add soup cppflags to WTR,
67         because URL.h now includes GUniquePtrSoup.h.
68
69 2014-01-27  Carlos Garcia Campos  <cgarcia@igalia.com>
70
71         [GTK] Make webkit_uri_scheme_request_get_web_view() work with CustomProtocols
72         https://bugs.webkit.org/show_bug.cgi?id=127614
73
74         Reviewed by Gustavo Noronha Silva.
75
76         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp: Bring
77         back the custom URI scheme WebView check.
78
79 2014-01-27  Tim Horton  <timothy_horton@apple.com>
80
81         Revert yet one more tiny part of r162629 that didn't get reverted in r162883
82
83         * WebKitTestRunner/TestController.cpp:
84         (WTR::TestController::pluginLoadPolicy):
85         * WebKitTestRunner/TestController.h:
86
87 2014-01-27  Tim Horton  <timothy_horton@apple.com>
88
89         Revert one more tiny part of r162629 that didn't get reverted in r162883.
90
91         ... which was also causing test failures!
92
93         * WebKitTestRunner/TestController.cpp:
94         (WTR::TestController::createWebViewWithOptions):
95
96 2014-01-27  David Farler  <dfarler@apple.com>
97
98         iOS DumpRenderTree.app dies loading fonts
99         https://bugs.webkit.org/show_bug.cgi?id=127730
100
101         Reviewed by Daniel Bates.
102
103         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
104         - Add Ahem to the __DATA section
105         * DumpRenderTree/mac/DumpRenderTree.mm:
106         (activateFontsIOS):
107         - Load "WeightWatcher100" instead.
108
109 2014-01-27  Alexey Proskuryakov  <ap@apple.com>
110
111         [Mac] Extra logging output from run-safari --no-saved-state
112         https://bugs.webkit.org/show_bug.cgi?id=127732
113
114         Reviewed by Daniel Bates.
115
116         * Scripts/webkitdirs.pm: (argumentsForRunAndDebugMacWebKitApp): Use an option that
117         disables saved state without logging.
118
119 2014-01-27  Tim Horton  <timothy_horton@apple.com>
120
121         Revert the parts of r162629 that add a new pluginLoadPolicy and the context menu item.
122
123         We're leaving the parts that make us use PDFPlugin instead of showing the blocked
124         plugin indicator intact, though.
125
126         * WebKitTestRunner/TestController.cpp:
127         (WTR::TestController::createWebViewWithOptions):
128
129 2014-01-27  Andy Estes  <aestes@apple.com>
130
131         Scrub WebKit API headers of WTF macros
132         https://bugs.webkit.org/show_bug.cgi?id=127706
133
134         Reviewed by David Kilzer.
135
136         * Scripts/check-for-inappropriate-macros-in-external-headers: Modified
137         the regex to require a '(' after the macro name in order to be
138         considered a match. This prevents things like 'ENABLE_SOME_FEATURE'
139         from being flagged as an ENABLE() macro.
140
141 2014-01-27  Commit Queue  <commit-queue@webkit.org>
142
143         Unreviewed, rolling out r162846.
144         http://trac.webkit.org/changeset/162846
145         https://bugs.webkit.org/show_bug.cgi?id=127695
146
147         "Broke the WebKit Bot Watcher's Dashboard; will fix offline"
148         (Requested by dydz on #webkit).
149
150         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
151         (BuildbotIteration.prototype.update.):
152
153 2014-01-27  Daniel Bates  <dabates@apple.com>
154
155         Add support for displaying results from multiple Buildbots on WebKit Bot Watcher's Dashboard
156         https://bugs.webkit.org/show_bug.cgi?id=127564
157
158         Reviewed by Alexey Proskuryakov.
159
160         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
161         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
162
163 2014-01-27  Daniel Bates  <dabates@apple.com>
164
165         Teach Buildbot dashboard to parse alternative revision format
166         https://bugs.webkit.org/show_bug.cgi?id=127561
167
168         Reviewed by Alexey Proskuryakov.
169
170         Add support for extracting the OpenSource and Internal revision numbers when Buildbot
171         returns a dictionary for the value of property got_revision.
172
173         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
174         (parseRevisionProperty): Added; parses Buildbot revision property, which can either be a
175         string or a dictionary.
176         (BuildbotIteration.prototype.update.): Modified to call parseRevisionProperty() to determine
177         the OpenSource and Internal revision numbers.
178
179 2014-01-27  Carlos Garcia Campos  <cgarcia@igalia.com>
180
181         [GTK] Implement custom URI schemes with CustomProtocols
182         https://bugs.webkit.org/show_bug.cgi?id=127091
183
184         Reviewed by Gustavo Noronha Silva.
185
186         Temporarily disable the WebKitWebView check until we figure out
187         how to implement it with CustomProtocols.
188
189         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
190
191 2014-01-26  Alexey Proskuryakov  <ap@apple.com>
192
193         REGRESSION(r127412): http/tests/misc/link-rel-icon-beforeload.html is broken.
194
195         * DumpRenderTree/mac/TestRunnerMac.mm: (TestRunner::setIconDatabaseEnabled):
196         Fixed an incorrect ifdef.
197
198 2014-01-26  Brendan Long  <b.long@cablelabs.com>
199
200         [GTK] DumpRenderTree prints out suggesting to set WEBKIT_TOP_LEVEL when fonts are missing but doesn't use it.
201         https://bugs.webkit.org/show_bug.cgi?id=110602
202
203         Reviewed by Philippe Normand.
204
205         * DumpRenderTree/gtk/DumpRenderTree.cpp:
206         (getTopLevelPath): Use WEBKIT_TOP_LEVEL environment variable if it exists.
207         (initializeFonts): Fix printing of expected font path (fontPath is guaranteed to be null here).
208
209 2014-01-24  Andy Estes  <aestes@apple.com>
210
211         [iOS] Upstream changes in Tools/DumpRenderTree
212         https://bugs.webkit.org/show_bug.cgi?id=127412
213
214         Reviewed by Simon Fraser.
215
216         Upstream all iOS changes. Added a new target called DumpRenderTree.app,
217         which builds the DumpRenderTree static library into an app bundle as
218         expected by the iOS Simulator.
219
220         * DumpRenderTree/AccessibilityTextMarker.h:
221         * DumpRenderTree/AccessibilityUIElement.h:
222         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
223         * DumpRenderTree/DumpRenderTreeFileDraggingSource.h:
224         * DumpRenderTree/DumpRenderTreePrefix.h:
225         * DumpRenderTree/PixelDumpSupport.cpp:
226         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
227         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
228         * DumpRenderTree/TestNetscapePlugIn/PluginObjectMac.mm:
229         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
230         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
231         * DumpRenderTree/TestNetscapePlugIn/TestObject.cpp:
232         * DumpRenderTree/TestNetscapePlugIn/TestObject.h:
233         * DumpRenderTree/TestNetscapePlugIn/Tests/DocumentOpenInDestroyStream.cpp:
234         * DumpRenderTree/TestNetscapePlugIn/Tests/EvaluateJSAfterRemovingPluginElement.cpp:
235         * DumpRenderTree/TestNetscapePlugIn/Tests/GetUserAgentWithNullNPPFromNPPNew.cpp:
236         * DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeObjectFromDestroyedPlugin.cpp:
237         * DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeRemoveProperty.cpp:
238         * DumpRenderTree/TestNetscapePlugIn/Tests/NullNPPGetValuePointer.cpp:
239         * DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:
240         * DumpRenderTree/TestNetscapePlugIn/Tests/PluginScriptableNPObjectInvokeDefault.cpp:
241         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
242         * DumpRenderTree/TestRunner.cpp:
243         * DumpRenderTree/TestRunner.h:
244         * DumpRenderTree/cg/ImageDiffCG.cpp:
245         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
246         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
247         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
248         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h: Added.
249         * DumpRenderTree/ios/DumpRenderTreeBrowserView.mm: Added.
250         * DumpRenderTree/ios/Info.plist: Added.
251         * DumpRenderTree/ios/PerlSupport/DumpRenderTreeSupport.c: Added.
252         * DumpRenderTree/ios/PerlSupport/DumpRenderTreeSupportPregenerated.pm: Added.
253         * DumpRenderTree/ios/PerlSupport/DumpRenderTreeSupport_wrapPregenerated.c: Added.
254         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/Changes: Added.
255         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/IPhoneSimulatorNotification.xs: Added.
256         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/MANIFEST: Added.
257         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/Makefile.PL: Added.
258         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/README: Added.
259         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/lib/IPhoneSimulatorNotification.pm: Added.
260         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/ppport.h: Added.
261         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/t/IPhoneSimulatorNotification.t: Added.
262         * DumpRenderTree/ios/PerlSupport/Makefile: Added.
263         * DumpRenderTree/ios/PixelDumpSupportIOS.mm: Added.
264         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
265         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
266         * DumpRenderTree/mac/AppleScriptController.m:
267         * DumpRenderTree/mac/Configurations/Base.xcconfig:
268         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
269         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
270         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig: Added.
271         * DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig:
272         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig:
273         * DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig: Added.
274         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig:
275         * DumpRenderTree/mac/DumpRenderTree.mm:
276         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
277         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
278         * DumpRenderTree/mac/DumpRenderTreeMac.h:
279         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
280         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
281         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
282         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
283         * DumpRenderTree/mac/EditingDelegate.h:
284         * DumpRenderTree/mac/EventSendingController.h:
285         * DumpRenderTree/mac/EventSendingController.mm:
286         * DumpRenderTree/mac/FrameLoadDelegate.mm:
287         * DumpRenderTree/mac/HistoryDelegate.h:
288         * DumpRenderTree/mac/LayoutTestHelper.m:
289         * DumpRenderTree/mac/MockGeolocationProvider.mm:
290         * DumpRenderTree/mac/NavigationController.h:
291         * DumpRenderTree/mac/ObjCPlugin.h:
292         * DumpRenderTree/mac/ObjCPlugin.m:
293         * DumpRenderTree/mac/ObjCPluginFunction.h:
294         * DumpRenderTree/mac/PolicyDelegate.h:
295         * DumpRenderTree/mac/ResourceLoadDelegate.h:
296         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
297         * DumpRenderTree/mac/TestRunnerMac.mm:
298         * DumpRenderTree/mac/TextInputController.h:
299         * DumpRenderTree/mac/TextInputController.m:
300         * DumpRenderTree/mac/UIDelegate.h:
301         * DumpRenderTree/mac/UIDelegate.mm:
302
303 2014-01-25  Darin Adler  <darin@apple.com>
304
305         Call deprecatedCharacters instead of characters at more call sites
306         https://bugs.webkit.org/show_bug.cgi?id=127631
307
308         Reviewed by Sam Weinig.
309
310         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
311         (TestWebKitAPI::expectBuilderContent):
312         (TestWebKitAPI::expectEmpty):
313         (TestWebKitAPI::TEST):
314         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
315         (TestWebKitAPI::TEST):
316         Use the new name.
317
318 2014-01-25  Anders Carlsson  <andersca@apple.com>
319
320         Modernize HashTable threading code
321         https://bugs.webkit.org/show_bug.cgi?id=127621
322
323         Reviewed by Darin Adler.
324
325         Explicitly include headers that used to be brought in by HashTable.h
326
327         * DumpRenderTree/JavaScriptThreading.cpp:
328
329 2014-01-24  Eric Carlson  <eric.carlson@apple.com>
330
331         Unreviewed. Add Philip Jägenstedt to watch and contributor lists.
332
333         * Scripts/webkitpy/common/config/contributors.json:
334         * Scripts/webkitpy/common/config/watchlist:
335
336 2014-01-23  David Farler  <dfarler@apple.com>
337
338         Make WebKitTestRunner work with iOS
339         https://bugs.webkit.org/show_bug.cgi?id=127448
340
341         Reviewed by Simon Fraser.
342
343         Combined patch from Simon below with some additional xcconfig cleanups,
344         rebasing and stubbing out a couple of new functions that popped up
345         since then.
346
347         2013-12-03  Simon Fraser  <simon.fraser@apple.com>
348
349                 <rdar://problem/15515469> Get WebKitTestRunner working on iOS
350
351                 Get WebKitTestRunner limping on iOS. Main parts:
352                 - Stub out lots of accessibility-related functions.
353                 - Stub out EventSender
354                 - Create target to make a bundled app that runs in the simulator,
355                   and copy the injected bundle library into it.
356                 - Make a UIWindow and WKView to load tests in
357
358                 It runs, load tests, and dumps results to output. More work will be
359                 required once we can execute it via the webkitpy scripts.
360
361         * WebKitTestRunner/Configurations/Base.xcconfig:
362         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
363         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
364         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
365         * WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm: Added.
366         (WTR::AccessibilityController::addNotificationListener):
367         (WTR::AccessibilityController::removeNotificationListener):
368         (WTR::AccessibilityController::platformName):
369         (WTR::AccessibilityController::logAccessibilityEvents):
370         (WTR::AccessibilityController::resetToConsistentState):
371         (WTR::findAccessibleObjectById):
372         (WTR::AccessibilityController::accessibleElementById):
373         * WebKitTestRunner/InjectedBundle/ios/AccessibilityNotificationHandler.h: Added.
374         * WebKitTestRunner/InjectedBundle/ios/AccessibilityTextMarkerIOS.mm: Copied from Tools/WebKitTestRunner/WebKitTestRunnerPrefix.h.
375         (WTR::AccessibilityTextMarker::isEqual):
376         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm: Added.
377         (WTR::AccessibilityUIElement::AccessibilityUIElement):
378         (WTR::AccessibilityUIElement::~AccessibilityUIElement):
379         (WTR::AccessibilityUIElement::isEqual):
380         (WTR::AccessibilityUIElement::getLinkedUIElements):
381         (WTR::AccessibilityUIElement::getDocumentLinks):
382         (WTR::AccessibilityUIElement::getChildren):
383         (WTR::AccessibilityUIElement::getChildrenWithRange):
384         (WTR::AccessibilityUIElement::childrenCount):
385         (WTR::AccessibilityUIElement::elementAtPoint):
386         (WTR::AccessibilityUIElement::indexOfChild):
387         (WTR::AccessibilityUIElement::childAtIndex):
388         (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
389         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
390         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
391         (WTR::AccessibilityUIElement::disclosedRowAtIndex):
392         (WTR::AccessibilityUIElement::rowAtIndex):
393         (WTR::AccessibilityUIElement::selectedChildAtIndex):
394         (WTR::AccessibilityUIElement::selectedChildrenCount):
395         (WTR::AccessibilityUIElement::selectedRowAtIndex):
396         (WTR::AccessibilityUIElement::titleUIElement):
397         (WTR::AccessibilityUIElement::parentElement):
398         (WTR::AccessibilityUIElement::disclosedByRow):
399         (WTR::AccessibilityUIElement::attributesOfLinkedUIElements):
400         (WTR::AccessibilityUIElement::attributesOfDocumentLinks):
401         (WTR::AccessibilityUIElement::attributesOfChildren):
402         (WTR::AccessibilityUIElement::allAttributes):
403         (WTR::AccessibilityUIElement::stringAttributeValue):
404         (WTR::AccessibilityUIElement::numberAttributeValue):
405         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue):
406         (WTR::AccessibilityUIElement::uiElementAttributeValue):
407         (WTR::AccessibilityUIElement::boolAttributeValue):
408         (WTR::AccessibilityUIElement::isAttributeSettable):
409         (WTR::AccessibilityUIElement::isAttributeSupported):
410         (WTR::AccessibilityUIElement::parameterizedAttributeNames):
411         (WTR::AccessibilityUIElement::role):
412         (WTR::AccessibilityUIElement::subrole):
413         (WTR::AccessibilityUIElement::roleDescription):
414         (WTR::AccessibilityUIElement::title):
415         (WTR::AccessibilityUIElement::description):
416         (WTR::AccessibilityUIElement::orientation):
417         (WTR::AccessibilityUIElement::stringValue):
418         (WTR::AccessibilityUIElement::language):
419         (WTR::AccessibilityUIElement::helpText):
420         (WTR::AccessibilityUIElement::x):
421         (WTR::AccessibilityUIElement::y):
422         (WTR::AccessibilityUIElement::width):
423         (WTR::AccessibilityUIElement::height):
424         (WTR::AccessibilityUIElement::clickPointX):
425         (WTR::AccessibilityUIElement::clickPointY):
426         (WTR::AccessibilityUIElement::intValue):
427         (WTR::AccessibilityUIElement::minValue):
428         (WTR::AccessibilityUIElement::maxValue):
429         (WTR::AccessibilityUIElement::valueDescription):
430         (WTR::AccessibilityUIElement::insertionPointLineNumber):
431         (WTR::AccessibilityUIElement::isPressActionSupported):
432         (WTR::AccessibilityUIElement::isIncrementActionSupported):
433         (WTR::AccessibilityUIElement::isDecrementActionSupported):
434         (WTR::AccessibilityUIElement::isEnabled):
435         (WTR::AccessibilityUIElement::isRequired):
436         (WTR::AccessibilityUIElement::isFocused):
437         (WTR::AccessibilityUIElement::isSelected):
438         (WTR::AccessibilityUIElement::isSelectedOptionActive):
439         (WTR::AccessibilityUIElement::isIndeterminate):
440         (WTR::AccessibilityUIElement::isExpanded):
441         (WTR::AccessibilityUIElement::isChecked):
442         (WTR::AccessibilityUIElement::hierarchicalLevel):
443         (WTR::AccessibilityUIElement::classList):
444         (WTR::AccessibilityUIElement::speak):
445         (WTR::AccessibilityUIElement::ariaIsGrabbed):
446         (WTR::AccessibilityUIElement::ariaDropEffects):
447         (WTR::AccessibilityUIElement::lineForIndex):
448         (WTR::AccessibilityUIElement::rangeForLine):
449         (WTR::AccessibilityUIElement::rangeForPosition):
450         (WTR::AccessibilityUIElement::boundsForRange):
451         (WTR::AccessibilityUIElement::stringForRange):
452         (WTR::AccessibilityUIElement::attributedStringForRange):
453         (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
454         (WTR::uiElementCountForSearchPredicate):
455         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
456         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
457         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
458         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
459         (WTR::AccessibilityUIElement::attributesOfColumns):
460         (WTR::AccessibilityUIElement::attributesOfRows):
461         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
462         (WTR::AccessibilityUIElement::attributesOfHeader):
463         (WTR::AccessibilityUIElement::rowCount):
464         (WTR::AccessibilityUIElement::columnCount):
465         (WTR::AccessibilityUIElement::indexInTable):
466         (WTR::AccessibilityUIElement::rowIndexRange):
467         (WTR::AccessibilityUIElement::columnIndexRange):
468         (WTR::AccessibilityUIElement::cellForColumnAndRow):
469         (WTR::AccessibilityUIElement::horizontalScrollbar):
470         (WTR::AccessibilityUIElement::verticalScrollbar):
471         (WTR::AccessibilityUIElement::scrollToMakeVisible):
472         (WTR::AccessibilityUIElement::selectedTextRange):
473         (WTR::AccessibilityUIElement::setSelectedTextRange):
474         (WTR::AccessibilityUIElement::increment):
475         (WTR::AccessibilityUIElement::decrement):
476         (WTR::AccessibilityUIElement::showMenu):
477         (WTR::AccessibilityUIElement::press):
478         (WTR::AccessibilityUIElement::setSelectedChild):
479         (WTR::AccessibilityUIElement::accessibilityValue):
480         (WTR::AccessibilityUIElement::documentEncoding):
481         (WTR::AccessibilityUIElement::documentURI):
482         (WTR::AccessibilityUIElement::url):
483         (WTR::AccessibilityUIElement::addNotificationListener):
484         (WTR::AccessibilityUIElement::removeNotificationListener):
485         (WTR::AccessibilityUIElement::isFocusable):
486         (WTR::AccessibilityUIElement::isSelectable):
487         (WTR::AccessibilityUIElement::isMultiSelectable):
488         (WTR::AccessibilityUIElement::isVisible):
489         (WTR::AccessibilityUIElement::isOffScreen):
490         (WTR::AccessibilityUIElement::isCollapsed):
491         (WTR::AccessibilityUIElement::isIgnored):
492         (WTR::AccessibilityUIElement::hasPopup):
493         (WTR::AccessibilityUIElement::takeFocus):
494         (WTR::AccessibilityUIElement::takeSelection):
495         (WTR::AccessibilityUIElement::addSelection):
496         (WTR::AccessibilityUIElement::removeSelection):
497         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
498         (WTR::AccessibilityUIElement::textMarkerRangeLength):
499         (WTR::AccessibilityUIElement::previousTextMarker):
500         (WTR::AccessibilityUIElement::nextTextMarker):
501         (WTR::AccessibilityUIElement::stringForTextMarkerRange):
502         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
503         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
504         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
505         (WTR::AccessibilityUIElement::endTextMarkerForBounds):
506         (WTR::AccessibilityUIElement::startTextMarkerForBounds):
507         (WTR::AccessibilityUIElement::textMarkerForPoint):
508         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
509         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
510         (WTR::AccessibilityUIElement::indexForTextMarker):
511         (WTR::AccessibilityUIElement::isTextMarkerValid):
512         (WTR::AccessibilityUIElement::textMarkerForIndex):
513         (WTR::AccessibilityUIElement::startTextMarker):
514         (WTR::AccessibilityUIElement::endTextMarker):
515         (WTR::AccessibilityUIElement::mathPostscriptsDescription):
516         (WTR::AccessibilityUIElement::mathPrescriptsDescription):
517         (WTR::AccessibilityUIElement::pathDescription):
518         (WTR::AccessibilityUIElement::supportedActions):
519         * WebKitTestRunner/InjectedBundle/ios/ActivateFontsIOS.mm: Copied from Tools/WebKitTestRunner/WebKitTestRunnerPrefix.h.
520         (WTR::activateFonts):
521         * WebKitTestRunner/InjectedBundle/ios/EventSenderProxyIOS.mm: Added.
522         (WTR::EventSenderProxy::EventSenderProxy):
523         (WTR::EventSenderProxy::~EventSenderProxy):
524         (WTR::EventSenderProxy::updateClickCountForButton):
525         (WTR::EventSenderProxy::mouseDown):
526         (WTR::EventSenderProxy::mouseUp):
527         (WTR::EventSenderProxy::mouseMoveTo):
528         (WTR::EventSenderProxy::leapForward):
529         (WTR::EventSenderProxy::keyDown):
530         (WTR::EventSenderProxy::mouseScrollBy):
531         (WTR::EventSenderProxy::continuousMouseScrollBy):
532         (WTR::EventSenderProxy::addTouchPoint):
533         (WTR::EventSenderProxy::updateTouchPoint):
534         (WTR::EventSenderProxy::setTouchModifier):
535         (WTR::EventSenderProxy::setTouchPointRadius):
536         (WTR::EventSenderProxy::touchStart):
537         (WTR::EventSenderProxy::touchMove):
538         (WTR::EventSenderProxy::touchEnd):
539         (WTR::EventSenderProxy::touchCancel):
540         (WTR::EventSenderProxy::clearTouchPoints):
541         (WTR::EventSenderProxy::releaseTouchPoint):
542         (WTR::EventSenderProxy::cancelTouchPoint):
543         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm: Copied from Tools/WebKitTestRunner/WebKitTestRunnerPrefix.h.
544         (WTR::InjectedBundle::platformInitialize):
545         * WebKitTestRunner/InjectedBundle/ios/InjectedBundlePageIOS.mm: Copied from Tools/WebKitTestRunner/WebKitTestRunnerPrefix.h.
546         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame):
547         * WebKitTestRunner/Makefile:
548         * WebKitTestRunner/TestController.cpp:
549         (WTR::TestController::initialize):
550         * WebKitTestRunner/TestController.h:
551         * WebKitTestRunner/TestInvocation.cpp:
552         (WTR::TestInvocation::invoke):
553         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
554         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
555         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.h: Added.
556         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.m: Added.
557         (-[AppDelegate application:didFinishLaunchingWithOptions:]):
558         (-[AppDelegate applicationWillResignActive:]):
559         (-[AppDelegate applicationDidEnterBackground:]):
560         (-[AppDelegate applicationWillEnterForeground:]):
561         (-[AppDelegate applicationDidBecomeActive:]):
562         (-[AppDelegate applicationWillTerminate:]):
563         * WebKitTestRunner/WebKitTestRunnerApp/Images.xcassets/AppIcon.appiconset/Contents.json: Added.
564         * WebKitTestRunner/WebKitTestRunnerApp/Images.xcassets/LaunchImage.launchimage/Contents.json: Added.
565         * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist: Added.
566         * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Prefix.pch: Added.
567         * WebKitTestRunner/WebKitTestRunnerApp/en.lproj/InfoPlist.strings: Added.
568         * WebKitTestRunner/WebKitTestRunnerApp/main.m: Added.
569         (main):
570         * WebKitTestRunner/WebKitTestRunnerAppTests-Info.plist: Added.
571         * WebKitTestRunner/WebKitTestRunnerAppTests/WebKitTestRunnerAppTests-Info.plist: Added.
572         * WebKitTestRunner/WebKitTestRunnerAppTests/WebKitTestRunnerAppTests.m: Added.
573         (-[WebKitTestRunnerAppTests setUp]):
574         (-[WebKitTestRunnerAppTests tearDown]):
575         (-[WebKitTestRunnerAppTests testExample]):
576         * WebKitTestRunner/WebKitTestRunnerAppTests/en.lproj/InfoPlist.strings: Added.
577         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
578         * WebKitTestRunner/cg/TestInvocationCG.cpp:
579         * WebKitTestRunner/iOS.xcconfig: Added.
580         * WebKitTestRunner/ios/PlatformWebViewIOS.mm: Added.
581         (-[TestRunnerWKView initWithFrame:contextRef:pageGroupRef:relatedToPage:useTiledDrawing:]):
582         (-[TestRunnerWKView _shouldUseTiledDrawingArea]):
583         (-[WebKitTestRunnerWindow isKeyWindow]):
584         (-[WebKitTestRunnerWindow setFrameOrigin:]):
585         (-[WebKitTestRunnerWindow setFrame:]):
586         (-[WebKitTestRunnerWindow frameRespectingFakeOrigin]):
587         (-[WebKitTestRunnerWindow backingScaleFactor]):
588         (WTR::PlatformWebView::PlatformWebView):
589         (WTR::PlatformWebView::resizeTo):
590         (WTR::PlatformWebView::~PlatformWebView):
591         (WTR::PlatformWebView::page):
592         (WTR::PlatformWebView::focus):
593         (WTR::PlatformWebView::windowFrame):
594         (WTR::PlatformWebView::setWindowFrame):
595         (WTR::PlatformWebView::didInitializeClients):
596         (WTR::PlatformWebView::addChromeInputField):
597         (WTR::PlatformWebView::removeChromeInputField):
598         (WTR::PlatformWebView::makeWebViewFirstResponder):
599         (WTR::PlatformWebView::windowSnapshotImage):
600         (WTR::PlatformWebView::viewSupportsOptions):
601         * WebKitTestRunner/ios/TestControllerIOS.mm: Added.
602         (WTR::TestController::notifyDone):
603         (WTR::TestController::platformInitialize):
604         (WTR::TestController::platformDestroy):
605         (WTR::TestController::initializeInjectedBundlePath):
606         (WTR::TestController::initializeTestPluginDirectory):
607         (WTR::TestController::platformRunUntil):
608         (WTR::TestController::platformInitializeContext):
609         (WTR::TestController::runModal):
610         (WTR::TestController::platformLibraryPathForTesting):
611         * WebKitTestRunner/ios/WebArchiveDumpSupportIOS.mm: Copied from Tools/WebKitTestRunner/WebKitTestRunnerPrefix.h.
612         (createCFURLResponseFromResponseData):
613         (supportedNonImageMIMETypes):
614         * WebKitTestRunner/ios/mainIOS.mm: Copied from Tools/WebKitTestRunner/WebKitTestRunnerPrefix.h.
615         (-[WebKitTestRunnerApp _runTestController]):
616         (-[WebKitTestRunnerApp applicationDidFinishLaunching:]):
617         (main):
618
619 2014-01-24  Enrique Ocaña González  <eocanha@igalia.com>
620
621         [GTK] Put cache files in XDG_CACHE_HOME
622         https://bugs.webkit.org/show_bug.cgi?id=123458
623
624         Reviewed by Martin Robinson.
625
626         * GtkLauncher/main.c:
627         (createBrowser):
628
629 2014-01-23  Max Vujovic  <mvujovic@adobe.com>
630
631         Remove CSS Custom Filters code and tests
632         https://bugs.webkit.org/show_bug.cgi?id=127382
633
634         Reviewed by Simon Fraser.
635
636         * DumpRenderTree/gtk/DumpRenderTree.cpp:
637         (resetDefaultsToConsistentValues):
638         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
639         (TestRunner::overridePreference):
640
641 2014-01-23  Tim Horton  <timothy_horton@apple.com>
642
643         PDFPlugin: Use PDFPlugin even if there's an external plugin installed, if it's blocked
644         https://bugs.webkit.org/show_bug.cgi?id=127415
645         <rdar://problem/12482452>
646
647         Reviewed by Sam Weinig.
648
649         Adopt the new page loader client plugin load callback.
650
651         * WebKitTestRunner/TestController.cpp:
652         (WTR::TestController::createWebViewWithOptions):
653         (WTR::TestController::pluginLoadPolicy):
654         * WebKitTestRunner/TestController.h:
655
656 2014-01-23  peavo@outlook.com  <peavo@outlook.com>
657
658         [Curl] There is no way to specify cache folder.
659         https://bugs.webkit.org/show_bug.cgi?id=125028
660
661         Reviewed by Brent Fulgham.
662
663         Enable disc cache in WinLauncher by setting cache folder location.
664
665         * WinLauncher/WinLauncher.cpp:
666         (getAppDataFolder): Added function to get app data folder.
667         (setCacheFolder): Added function to set cache folder.
668         (createCrashReport): Use new getAppDataFolder function.
669         (wWinMain): Use function setCacheFolder to set cache folder location.
670
671 2014-01-23  Daniel Bates  <dabates@apple.com>
672
673         build-webkit --sdk=iphonesimulator doesn't think it's building iOS
674         https://bugs.webkit.org/show_bug.cgi?id=127379
675
676         Reviewed by Simon Fraser.
677
678         Teach build-webkit to recognize --sdk=X.
679
680         Currently, build-webkit recognizes --sdk X to specify X as the Xcode SDK to use, which is also
681         considered when determining the WebKit port to build. But build-webkit advertises --sdk=X in its
682         help message. We should teach build-webkit to recognize both --sdk X and --sdk=X to make its handling
683         of --sdk more consistent with the handling of other build-webkit options that take a value (e.g. --prefix).
684
685         * Scripts/webkitdirs.pm:
686         (checkForArgumentAndRemoveFromArrayRefGettingValue): Added.
687         (checkForArgumentAndRemoveFromARGVGettingValue): Modified to call checkForArgumentAndRemoveFromArrayRefGettingValue().
688         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRefGettingValue.pl: Added.
689
690 2014-01-23  Commit Queue  <commit-queue@webkit.org>
691
692         Unreviewed, rolling out r162612.
693         http://trac.webkit.org/changeset/162612
694         https://bugs.webkit.org/show_bug.cgi?id=127488
695
696         broke the build (Requested by mhahnenberg on #webkit).
697
698         * Scripts/build-jsc:
699         * jsc-cli/jsc-cli.xcodeproj/project.pbxproj: Removed.
700         * jsc-cli/jsc-cli/CLIInstance.h: Removed.
701         * jsc-cli/jsc-cli/CLIInstance.m: Removed.
702         * jsc-cli/jsc-cli/JSModule.h: Removed.
703         * jsc-cli/jsc-cli/JSModule.m: Removed.
704         * jsc-cli/jsc-cli/JSRunLoopThread.h: Removed.
705         * jsc-cli/jsc-cli/JSRunLoopThread.m: Removed.
706         * jsc-cli/jsc-cli/ReadEvalPrintLoop.h: Removed.
707         * jsc-cli/jsc-cli/ReadEvalPrintLoop.m: Removed.
708         * jsc-cli/jsc-cli/RunLoopThread.h: Removed.
709         * jsc-cli/jsc-cli/RunLoopThread.m: Removed.
710         * jsc-cli/jsc-cli/ScriptInputSource.h: Removed.
711         * jsc-cli/jsc-cli/ScriptInputSource.m: Removed.
712         * jsc-cli/jsc-cli/main.m: Removed.
713
714 2014-01-23  Mark Hahnenberg  <mhahnenberg@apple.com>
715
716         Basic framework for a modern jsc CLI
717         https://bugs.webkit.org/show_bug.cgi?id=127435
718
719         Reviewed by Geoffrey Garen.
720
721         The most basic components of a modern jsc command line interface consist of the following:
722
723         - A simple REPL to enter commands and receive results
724         - The ability to define a module (which consists of various internal methods as well as a 
725           set of externally visible methods)
726         - The ability to load other modules at runtime
727         - The ability to interact with the underlying platform to perform various "privileged" 
728           functions (e.g. opening files, printing to the stdout, etc.)
729         
730         The basic architecture will look something like the following:
731         - If the tool is run in REPL mode (i.e. no command line arguments), it will start the REPL 
732           on the main thread and start a secondary thread with a run loop to handle various inputs 
733           from the REPL thread.
734         - If the tool is given a script to run, it will evaluate that script (and any scripts that 
735           it might transitively load) within the run loop on the secondary thread while the main 
736           thread blocks until it has completed.
737
738         * Scripts/build-jsc:
739         * jsc-cli: Added.
740         * jsc-cli/jsc-cli: Added.
741         * jsc-cli/jsc-cli.xcodeproj: Added.
742         * jsc-cli/jsc-cli.xcodeproj/project.pbxproj: Added.
743         * jsc-cli/jsc-cli/CLIInstance.h: Added.
744         * jsc-cli/jsc-cli/CLIInstance.m: Added.
745         (-[CLIInstance init]):
746         (-[CLIInstance loadFile:]):
747         (-[CLIInstance run]):
748         * jsc-cli/jsc-cli/JSModule.h: Added.
749         * jsc-cli/jsc-cli/JSModule.m: Added.
750         (coreModules):
751         (isCoreModule):
752         (classForModule):
753         (coreModuleFullPath):
754         (resolveModuleAsFile):
755         (resolveModuleAsDirectory):
756         (nodeModulePaths):
757         (resolveAsNodeModule):
758         (+[JSModule resolve:atPath:]):
759         (globalModuleCache):
760         (isCached):
761         (cachedModule):
762         (cacheModule):
763         (+[JSModule require:atPath:]):
764         (+[JSModule require:atPath:inContext:]):
765         (-[JSModule platformObjectInContext:]):
766         (-[JSModule initWithId:filename:context:]):
767         (-[JSModule dealloc]):
768         (-[JSModule didStartLoading]):
769         (-[JSModule didFinishLoading]):
770         (-[JSModule require:]):
771         (-[JSModule exports]):
772         * jsc-cli/jsc-cli/JSRunLoopThread.h: Added.
773         * jsc-cli/jsc-cli/JSRunLoopThread.m: Added.
774         (jsThreadMain):
775         (+[JSRunLoopThread threadMain]):
776         (-[JSRunLoopThread initWithFiles:andContext:]):
777         (-[JSRunLoopThread startRunLoop]):
778         (-[JSRunLoopThread start]):
779         (-[JSRunLoopThread join]):
780         (-[JSRunLoopThread didReceiveInput:]):
781         (-[JSRunLoopThread performCallback:withError:]):
782         (-[JSRunLoopThread performCallback:withArguments:]):
783         (-[JSRunLoopThread didFinishRunLoopInitialization]):
784         * jsc-cli/jsc-cli/ReadEvalPrintLoop.h: Added.
785         * jsc-cli/jsc-cli/ReadEvalPrintLoop.m: Added.
786         (-[ReadEvalPrintLoop initWithJSThread:]):
787         (prompt):
788         (escapeStringForOutput):
789         (-[ReadEvalPrintLoop processNextInput]):
790         (-[ReadEvalPrintLoop run]):
791         * jsc-cli/jsc-cli/RunLoopThread.h: Added.
792         * jsc-cli/jsc-cli/RunLoopThread.m: Added.
793         (+[RunLoopThread threadMain]):
794         (-[RunLoopThread init]):
795         (-[RunLoopThread dealloc]):
796         (-[RunLoopThread didFinishRunLoopInitialization]):
797         (-[RunLoopThread start]):
798         (-[RunLoopThread join]):
799         * jsc-cli/jsc-cli/ScriptInputSource.h: Added.
800         * jsc-cli/jsc-cli/ScriptInputSource.m: Added.
801         (scriptInputSourceScheduleRoutine):
802         (scriptInputSourcePerformRoutine):
803         (scriptInputSourceCancelRoutine):
804         (-[ScriptInputSource initWithContext:]):
805         (-[ScriptInputSource dealloc]):
806         (-[ScriptInputSource addToCurrentRunLoop]):
807         (-[ScriptInputSource removeFromRemoteRunLoop]):
808         (-[ScriptInputSource didReceiveScript:]):
809         (-[ScriptInputSource didReceiveSignal]):
810         (-[ScriptInputSource runScriptRemotely:]):
811         (-[ScriptInputSource finishAsyncCallback:withResult:]):
812         * jsc-cli/jsc-cli/main.m: Added.
813         (main):
814
815 2014-01-23  László Langó  <llango.u-szeged@partner.samsung.com>
816
817         Remove a FIXME comment that is already fixed.
818         https://bugs.webkit.org/show_bug.cgi?id=127468
819
820         Reviewed by Csaba Osztrogonác.
821
822         * Scripts/webkitpy/style/filereader.py:
823         (TextFileReader.__init__):
824
825 2014-01-22  Carlos Garcia Campos  <cgarcia@igalia.com>
826
827         [GLIB] Use GUniquePtr instead of GOwnPtr
828         https://bugs.webkit.org/show_bug.cgi?id=127431
829
830         Reviewed by Martin Robinson.
831
832         GUniquePtr is a template alias of std::unique_ptr with a custom
833         deleter that replaces GOwnPtr. GOwnPtr is still used for the cases
834         where the output pointer is needed, but it will also be replaced soon.
835
836         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
837         (printAccessibilityEvent):
838         (axObjectEventListener):
839         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
840         (indexRangeInTable):
841         (AccessibilityUIElement::role):
842         (AccessibilityUIElement::title):
843         (AccessibilityUIElement::description):
844         (AccessibilityUIElement::stringValue):
845         (AccessibilityUIElement::language):
846         (AccessibilityUIElement::lineForIndex):
847         (AccessibilityUIElement::selectedTextRange):
848         (AccessibilityUIElement::url):
849         * DumpRenderTree/efl/AccessibilityControllerEfl.cpp:
850         (AccessibilityController::accessibleElementById):
851         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
852         (AccessibilityController::accessibleElementById):
853         * DumpRenderTree/gtk/DumpRenderTree.cpp:
854         (getOutputDir):
855         (getFontsPath):
856         (initializeFonts):
857         (dumpFramesAsText):
858         (compareHistoryItems):
859         (dumpHistoryItem):
860         (soupURIToStringPreservingPassword):
861         (resetDefaultsToConsistentValues):
862         (temporaryDatabaseDirectory):
863         (webViewTitleChanged):
864         (webFrameLoadStatusNotified):
865         (pathFromSoupURI):
866         (convertWebResourceToURLPath):
867         (urlSuitableForTestResult):
868         (descriptionSuitableForTestResult):
869         (willSendRequestCallback):
870         (frameLoadEventCallback):
871         * DumpRenderTree/gtk/EditingCallbacks.cpp:
872         (dumpNodePath):
873         (dumpRange):
874         (shouldApplyStyle):
875         * DumpRenderTree/gtk/EventSender.cpp:
876         (contextClickCallback):
877         (beginDragWithFilesCallback):
878         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
879         (TestRunner::pathToLocalResource):
880         (TestRunner::queueLoad):
881         (TestRunner::removeOriginAccessWhitelistEntry):
882         (TestRunner::setMockGeolocationPositionUnavailableError):
883         (TestRunner::setIconDatabaseEnabled):
884         (TestRunner::findString):
885         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
886         (TestRunner::overridePreference):
887         (TestRunner::addUserScript):
888         (TestRunner::addUserStyleSheet):
889         (TestRunner::setTextDirection):
890         * DumpRenderTree/gtk/TextInputController.cpp:
891         (setMarkedTextCallback):
892         (insertTextCallback):
893         (doCommandCallback):
894         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
895         (LoadHTMLStringItem::invoke):
896         * TestWebKitAPI/PlatformGTK.cmake:
897         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
898         (WebKitDOMNodeTest::testTagNames):
899         * TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp:
900         (testBackForwardListLimitAndCache):
901         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
902         (testContextMenuSmartSeparators):
903         * TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp:
904         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
905         (testDownloadLocalFile):
906         (testDownloadLocalFileError):
907         (addContentDispositionHTTPHeaderToResponse):
908         (serverCallback):
909         (testDownloadRemoteFileError):
910         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
911         (startTestServer):
912         (testInspectorServerPageList):
913         (openRemoteDebuggingSession):
914         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
915         (testPrintOperationPrint):
916         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
917         (addCacheHTTPHeadersToResponse):
918         (serverCallback):
919         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
920         (httpsServerCallback):
921         (httpServerCallback):
922         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
923         (testWebViewJavaScriptDialogs):
924         (testWebViewWindowProperties):
925         (testWebViewFileChooserRequest):
926         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
927         (testWebExtensionWindowObjectCleared):
928         (testWebExtensionIsolatedWorld):
929         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitAccessibility.cpp:
930         (startTestServer):
931         (checkAtspiAccessible):
932         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
933         (serverCallback):
934         (testClearDatabase):
935         (testGetFaviconURI):
936         (webkitFaviconDatabaseFinalizedCallback):
937         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
938         (testWebContextGetPlugins):
939         (testWebContextURIScheme):
940         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
941         (testWebViewRunJavaScript):
942         (testWebViewMode):
943         (testWebViewPageVisibility):
944         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebViewGroup.cpp:
945         (isStyleSheetInjectedForURLAtPath):
946         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
947         (testWebViewEditorCutCopyPasteNonEditable):
948         (testWebViewEditorCutCopyPasteEditable):
949         (testWebViewEditorSelectAllNonEditable):
950         (testWebViewEditorSelectAllEditable):
951         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
952         (sendRequestCallback):
953         (methodCallCallback):
954         * TestWebKitAPI/gtk/PlatformUtilitiesGtk.cpp:
955         (TestWebKitAPI::Util::createInjectedBundlePath):
956         (TestWebKitAPI::Util::createURLForResource):
957         * TestWebKitAPI/gtk/PlatformWebViewGtk.cpp:
958         (TestWebKitAPI::doKeyStroke):
959         (TestWebKitAPI::doMouseButtonEvent):
960         (TestWebKitAPI::PlatformWebView::simulateMouseMove):
961         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
962         (loadFailedCallback):
963         (LoadTrackingTest::loadURI):
964         (LoadTrackingTest::loadHtml):
965         (LoadTrackingTest::loadPlainText):
966         (LoadTrackingTest::loadRequest):
967         (LoadTrackingTest::reload):
968         (LoadTrackingTest::goBack):
969         (LoadTrackingTest::goForward):
970         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h:
971         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.cpp:
972         (registerGResource):
973         (removeNonEmptyDirectory):
974         (main):
975         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
976         (Test::getWebKit1TestResoucesDir):
977         (Test::getResourcesDir):
978         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.cpp:
979         (WebKitTestBus::run):
980         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.cpp:
981         (WebKitTestServer::WebKitTestServer):
982         (WebKitTestServer::getURIForPath):
983         * TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.cpp:
984         (WebProcessTestRunner::runTest):
985         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
986         (resourceGetDataCallback):
987         (WebViewTest::mainResourceData):
988         (WebViewTest::mouseMoveTo):
989         (WebViewTest::keyStroke):
990         (WebViewTest::doMouseButtonEvent):
991         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
992         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
993         (WTR::AccessibilityController::accessibleElementById):
994         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
995         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
996         (WTR::AccessibilityUIElement::role):
997         (WTR::AccessibilityUIElement::title):
998         (WTR::AccessibilityUIElement::description):
999         (WTR::AccessibilityUIElement::stringValue):
1000         (WTR::AccessibilityUIElement::language):
1001         (WTR::AccessibilityUIElement::lineForIndex):
1002         (WTR::AccessibilityUIElement::selectedTextRange):
1003         (WTR::AccessibilityUIElement::url):
1004         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1005         (WTR::getOutputDir):
1006         (WTR::getFontsPath):
1007         (WTR::initializeFontConfigSetting):
1008         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
1009         (WTR::topLevelPath):
1010         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
1011         (WTR::TestRunner::pathToLocalResource):
1012         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1013         (WTR::TestController::initializeInjectedBundlePath):
1014         (WTR::TestController::initializeTestPluginDirectory):
1015
1016 2014-01-05  Martin Robinson  <mrobinson@igalia.com>
1017
1018         [GTK] [CMake] run-webkit-tests should support the CMake build
1019         https://bugs.webkit.org/show_bug.cgi?id=126503
1020
1021         Reviewed by Daniel Bates.
1022
1023         Update run-launcher and gtk.py to work properly when dealing with the CMake port.
1024         run-webkit-tests does not need the --gtkcmake flag, but run-launcher does.
1025
1026         * Scripts/run-launcher: Work properly with the gtkcmake flag.
1027         * Scripts/webkitpy/port/gtk.py:
1028         (GtkPort._is_cmake_build): Added this helper which looks for the CMakeCache
1029         file to detect a CMake build.
1030         (GtkPort._built_executables_path): Added this helper to locate the built executable path.
1031         (GtkPort._built_libraries_path): Added this helper to locate the built library path.
1032         (GtkPort._port_flag_for_scripts): Use --gtkcmake when appropriate.
1033         (GtkPort.setup_environ_for_server): The way CMake builds libraries differs from GTK+.
1034         (GtkPort._path_to_driver): Use the new helper.
1035         (GtkPort._path_to_image_diff): Use the new helper.
1036         (GtkPort._path_to_webcore_library): Use the new helper.
1037         (GtkPort.build_webkit_command): Use --gtkcmake when appropriate.
1038
1039 2014-01-22  Ryuan Choi  <ryuan.choi@samsung.com>
1040
1041         [EFL] Remove unnecessary smart method since ewk_view_tiled removed
1042         https://bugs.webkit.org/show_bug.cgi?id=127417
1043
1044         Reviewed by Gyuyoung Kim.
1045
1046         * EWebLauncher/main.c:
1047         (on_key_down): Removed shortcut to test pre render.
1048
1049 2014-01-22  Myles C. Maxfield  <mmaxfield@apple.com>
1050
1051         Remove CSS3_TEXT_DECORATION define
1052         https://bugs.webkit.org/show_bug.cgi?id=127333
1053
1054         This is required for unprefixing the text-decoration-* CSS properties.
1055
1056         Reviewed by Simon Fraser.
1057
1058         * Configurations/FeatureDefines.xcconfig:
1059
1060 2014-01-22  Andy Estes  <aestes@apple.com>
1061
1062         [iOS] Prepare for upstreaming DumpRenderTree changes
1063         https://bugs.webkit.org/show_bug.cgi?id=127412
1064
1065         Reviewed by Simon Fraser.
1066
1067         Unlike on Mac where DumpRenderTree is a command-line tool, on iOS it is
1068         an application bundle. Instead of upstreaming a separate target for the
1069         app that duplicates the 'Compile Sources' phase of the tool, separate
1070         out the compilation into a static library target that both the
1071         command-line tool and the app can link against. Also, perform some
1072         unrelated cleanup.
1073
1074         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Updated the
1075         project file format from 2.4- to 3.2-compatible. Removed the
1076         'Copy Headers' build phase and removed all files from the
1077         'Compile Sources' build phase of DumpRenderTree. Added some files that
1078         were missing from the project. Created a 'DumpRenderTree (Library)'
1079         target for building the static library and made the 'DumpRenderTree'
1080         target depend on it. Added a 'Compile Sources' build phase to this
1081         target that builds the same files the DumpRenderTree target used to.
1082         Created DumpRenderTreeMain.mm as the only source file of the
1083         DumpRenderTree target, since targets won't link a binary without at
1084         least one source file. Made DumpRenderTree (Library) use
1085         DumpRenderTreeLibrary.xcconfig and made LayoutTestHelper use
1086         BaseTarget.xcconfig (so that it doesn't try to link libDumpRenderTree.a).
1087         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Moved
1088         definitions of GCC_ENABLE_OBJC_EXCEPTIONS and GCC_PREFIX_HEADER from
1089         DumpRenderTree.xcconfig to here so that LayoutTestHelper can use them.
1090         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Passed
1091         -force_load $(BUILT_PRODUCTS_DIR)libDumpRenderTree.a to OTHER_LDFLAGS.
1092         This is needed to correctly link a static library containing an Objective-C
1093         category (see <https://developer.apple.com/library/mac/qa/qa1490/_index.html>).
1094         * DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig: Added.
1095         * DumpRenderTree/mac/DumpRenderTree.mm:
1096         (DumpRenderTreeMain): Renamed from main.
1097         * DumpRenderTree/mac/DumpRenderTreeMac.h: Added declaration of DumpRenderTreeMain.
1098         * DumpRenderTree/mac/DumpRenderTreeMain.mm: Added.
1099         (main): Called DumpRenderTreeMain from main.
1100
1101 2014-01-15  Martin Robinson  <mrobinson@igalia.com>
1102
1103         [GTK][CMake] build-webkit should try harder to avoid re-running cmake
1104         https://bugs.webkit.org/show_bug.cgi?id=127073
1105
1106         Reviewed by Daniel Bates.
1107
1108         * Scripts/build-webkit: Unify all the ports that call buildCMakeProjectOrExit with
1109         the new isCMakeBuild conditional. This allows us to share more code between ports.
1110         Pass the build arguments to the removeCMakeCache function.
1111         * Scripts/webkitdirs.pm:
1112         (runAutogenForAutotoolsProjectIfNecessary): Renamed mustReRunAutogen to cachedArgumentFileOutOfDate
1113         because it's now shared with the CMake build.
1114         (cachedArgumentFileOutOfDate): Renamed.
1115         (cmakeCachePath): Added this helper which gets the CMakeCache.txt path.
1116         (shouldRemoveCMakeCache): Tries to preserve current behavior for all ports, 
1117         except GTK+ which examines the OptionsGTK.cmake and OptionsCommon.cmake file
1118         as well as checking if build-webkit has been run with different arguments.
1119         (removeCMakeCache): Call shouldRemoveCMakeCache now.
1120         (generateBuildSystemFromCMakeProject): Exit early if CMakeCache.txt exists for GTK+.
1121         (isCMakeBuild): Added.
1122
1123 2014-01-22  Thiago de Barros Lacerda  <thiago.lacerda@openbossa.org>
1124
1125         [EFL][GTK] Get EFL and GTK compiling with ACCESSIBILITY disabled
1126         https://bugs.webkit.org/show_bug.cgi?id=127119
1127
1128         Reviewed by Mario Sanchez Prada.
1129
1130         Guarding ACCESSIBILITY code in DumpRenderTree and WebKitTestRunner with HAVE(ACCESSIBILITY).
1131
1132         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1133         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
1134         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1135         (resetDefaultsToConsistentValues):
1136         (webViewWindowObjectCleared):
1137         (main):
1138         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
1139         (WTR::AccessibilityController::platformName):
1140         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1141         (WTR::AccessibilityUIElement::isIndeterminate):
1142
1143 2014-01-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1144
1145
1146         [GTK] Add GUniquePtr
1147         https://bugs.webkit.org/show_bug.cgi?id=127170
1148
1149         Reviewed by Gustavo Noronha Silva.
1150
1151         Add unit tests for GUniquePtr.
1152
1153         * TestWebKitAPI/GNUmakefile.am: Add new file to compilation.
1154         * TestWebKitAPI/Tests/WTF/gobject/GUniquePtr.cpp: Added.
1155         (log):
1156         (takeLogStr):
1157         (TestWebKitAPI::TEST):
1158
1159 2014-01-22  Jinwoo Song  <jinwoo7.song@samsung.com>
1160
1161         Remove Nix files from Tools
1162         https://bugs.webkit.org/show_bug.cgi?id=127418
1163
1164         Reviewed by Csaba Osztrogonác.
1165
1166         * Scripts/build-webkit:
1167         * Scripts/update-webkit-libs-jhbuild:
1168         * Scripts/webkitdirs.pm:
1169         (determineArchitecture):
1170         (argumentsForConfiguration):
1171         (jscProductDir):
1172         (builtDylibPathForName):
1173         (isAppleWebKit):
1174         (launcherPath):
1175         (launcherName):
1176         (checkRequiredSystemConfig):
1177         (copyInspectorFrontendFiles):
1178         (jhbuildWrapperPrefixIfNeeded):
1179         (buildCMakeProjectOrExit):
1180         (cmakeBasedPortName):
1181         * Scripts/webkitpy/common/config/ports.py:
1182         (DeprecatedPort.port):
1183         (EflWK2Port.build_webkit_command):
1184         * Scripts/webkitpy/port/factory.py:
1185         (platform_options):
1186         (PortFactory):
1187         * Scripts/webkitpy/port/nix.py: Removed.
1188         * Scripts/webkitpy/port/nix_unittest.py: Removed.
1189
1190 2014-01-21  Benjamin Poulain  <benjamin@webkit.org>
1191
1192         Add Ian and Ricky to the contributor list
1193
1194         * Scripts/webkitpy/common/config/contributors.json:
1195         I am too old to remember all those email addresses :)
1196
1197 2014-01-21  David Farler  <dfarler@apple.com>
1198
1199         Upstream package-root for iOS
1200
1201         Reviewed by Daniel bates.
1202
1203         * Scripts/package-root: Added.
1204         (usage):
1205         * Scripts/webkitdirs.pm:
1206         (XcodeSDKPath): Added function.
1207
1208 2014-01-21  Daniel Bates  <dabates@apple.com>
1209
1210         [iOS] Tools/Makefile shouldn't build modules DumpRenderTree, gtest, or TestWebKitAPI
1211         https://bugs.webkit.org/show_bug.cgi?id=127368
1212
1213         Reviewed by Tim Horton.
1214
1215         Similar to the build-webkit change in <https://bugs.webkit.org/show_bug.cgi?id=127364>,
1216         we don't want to build DumpRenderTree, gtest, or TestWebKitAPI when running make in
1217         Tools.
1218
1219         * Makefile:
1220
1221 2014-01-21  Daniel Bates  <dabates@apple.com>
1222
1223         [iOS] Don't build DumpRenderTree, gtest, or TestWebKitAPI
1224         https://bugs.webkit.org/show_bug.cgi?id=127364
1225
1226         Reviewed by Simon Fraser.
1227
1228         For now, don't build DumpRenderTree and TestWebKitAPI for iOS as these
1229         projects fail to build because we need to upstream the relevant iOS changes.
1230         Also, don't build gtest, which is a dependency of TestWebKitAPI since we
1231         aren't building TestWebKitAPI.
1232
1233         * Scripts/build-webkit:
1234
1235 2014-01-21  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1236
1237         Unreviewed, remove myself from some watchlist entries.
1238
1239         * Scripts/webkitpy/common/config/watchlist:
1240
1241 2014-01-21  Zalan Bujtas  <zalan@apple.com>
1242
1243         Use 64 as the default value for the subpixel denominator.
1244
1245         Reviewed by Simon Fraser.
1246
1247         * lldb/lldb_webkit.py:
1248         (WebCoreLayoutUnitProvider.to_string):
1249
1250 2014-01-21  ChangSeok Oh  <changseok.oh@collabora.com>
1251
1252         [GTK] Fix a c++11 compliance issue for fontconfig
1253         https://bugs.webkit.org/show_bug.cgi?id=127283
1254
1255         Reviewed by Martin Robinson.
1256
1257         fontconfig-2.8.0 is not compliant with C++11. So I propose to apply a
1258         hotfix until bumping fontconfig up.
1259
1260         * gtk/jhbuild.modules:
1261         * gtk/patches/fontconfig-C-11-requires-a-space-between-literal-and-identifier.patch: Added.
1262
1263 2014-01-21  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
1264
1265         run-jsc-stress-tests should accept --child-processes option and WEBKIT_TEST_CHILD_PROCESSES env.var
1266         like run_webkit_test does
1267         https://bugs.webkit.org/show_bug.cgi?id=127349
1268
1269         Reviewed by Csaba Osztrogonác.
1270
1271         * Scripts/run-jsc-stress-tests:
1272
1273 2014-01-21  Adrian Perez de Castro  <aperez@igalia.com>
1274
1275         [GTK] Allow passing extra data to web extensions
1276         https://bugs.webkit.org/show_bug.cgi?id=125990
1277
1278         Reviewed by Carlos Garcia Campos.
1279
1280         Allow passing additional information to the injected bundle. On top
1281         of the string containing the path to the web extensions directory,
1282         a GVariant can be set with additional data using
1283         webkit_web_context_set_web_extensions_initialization_user_data().
1284         Also, a new initialize-web-extensions signal is emitted before
1285         launching a new WebProcess to allow setting different user data
1286         for each process. The GVariant is serialized as a string, passed
1287         to the injected bundle, and the injected bundle deserializes back
1288         the data, which is passed to web extensions which define the
1289         webkit_web_extension_initialize_with_user_data() function (for
1290         backwards compatibility, webkit_web_extension_initialize() is
1291         used as a fallback.)
1292
1293         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
1294         (initializeWebExtensions): Handles the initialize-web-extensions
1295         signal, and sets the web extensions directory and the initialization
1296         user data.
1297         (testWebExtensionInitializationUserData): New test case for checking
1298         the user data passed on initialization to web extensions.
1299         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1300         (methodCallCallback): Added implementation for the
1301         GetInitializationUserData D-Bus method, used by
1302         testWebExtensionInitializationUserData().
1303         (webkit_web_extension_initialize_with_user_data): Define the
1304         initialization function with the additional user data parameter.
1305
1306 2014-01-21  Siddharth Mathur  <s.mathur@ieee.org>
1307
1308         Change my email address in contributors.json.
1309
1310         Unreviewed.
1311
1312         * Scripts/webkitpy/common/config/contributors.json:
1313
1314 2014-01-21  Krzysztof Czech  <k.czech@samsung.com>
1315
1316         [ATK] Expose aria-flowto through ATK_RELATION_FLOWS_TO
1317         https://bugs.webkit.org/show_bug.cgi?id=127291
1318
1319         Reviewed by Mario Sanchez Prada.
1320
1321         Implemented AccessibilityUIElement::ariaFlowToElementAtIndex method.
1322
1323         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1324         (AccessibilityUIElement::ariaFlowToElementAtIndex):
1325         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1326         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
1327
1328 2014-01-20  Zalan Bujtas  <zalan@apple.com>
1329
1330         Force float division when calculating CSS px value.
1331
1332         Reviewed by Simon Fraser.
1333
1334         Note that in Python 3, this is the default behavior.
1335
1336         * lldb/lldb_webkit.py:
1337         (WebCoreLayoutUnitProvider.to_string):
1338
1339 2014-01-20  Alexey Proskuryakov  <ap@apple.com>
1340
1341         build.webkit.org/dashboard should display information about patches in EWS
1342         https://bugs.webkit.org/show_bug.cgi?id=127006
1343
1344         Reviewed by Ryosuke Niwa.
1345
1346         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
1347         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Bugzilla.js: Added.
1348         (Bugzilla.prototype.detailsURLForAttachment):
1349         Added a class for Bugzilla. So far, the only thing it can do is build patch URLs,
1350         which is needed when one wants to do something with a patch EWS is stuck on.
1351
1352         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
1353         Create a Bugzilla instance.
1354
1355         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js:
1356         (EWS.prototype.jsonQueueLengthURL):
1357         (EWS.prototype.jsonQueueStatusURL):
1358         Build JSON ULRs here, not in EWSQueue, as this is how other classes are structured.
1359
1360         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js:
1361         (EWSQueue.prototype.get statusPageURL): Changed to use a URL provided by EWS instead
1362         of second guessing.
1363         (EWSQueue.prototype.get chartsPageURL): Added.
1364         (EWSQueue.prototype.get loadedDetailedStatus): Tells whether we currently have
1365         additional data already loaded (it's reset with every update).
1366         (EWSQueue.prototype.get patches): Get patch queue.
1367         (EWSQueue.prototype.get bots): Get bots.
1368         (EWSQueue.prototype.update): Changed to use a specialized cheaper URL.
1369         (EWSQueue.prototype.loadDetailedStatus): Load and transform detailed status JSON.
1370
1371         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js:
1372         (EWSQueueView.prototype.update.appendQueue): Add a popover is there are any patches
1373         in the queue.
1374         (EWSQueueView.prototype.addLinkToRow): A helper to build the popover.
1375         (EWSQueueView.prototype.addTextToRow): Ditto.
1376         (EWSQueueView.prototype._addQueueHeadingToPopover): Ditto.
1377         (EWSQueueView.prototype._addBotsHeadingToPopover): Ditto.
1378         (EWSQueueView.prototype._addDividerToPopover): Ditto.
1379         (EWSQueueView.prototype._timeIntervalString): A helper to format a timestamp into a
1380         relative string.
1381         (EWSQueueView.prototype._popoverContentForEWSQueue): Build the popover.
1382         (EWSQueueView.prototype._presentPopoverForEWSQueue): Start loading data, and present
1383         it when done.
1384
1385         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
1386         Added rules for EWS popover. Removed a duplicate rule for build-logs-popover.
1387         Changed a few difficult to read padding styles to padding-left.
1388
1389 2014-01-20  Alexey Proskuryakov  <ap@apple.com>
1390
1391         Fix webkitpy tests.
1392
1393         * Scripts/webkitpy/common/net/web_mock.py: (MockBrowser.set_handle_robots):
1394         Added a mock implementation, as we now call this function.
1395
1396 2014-01-20  Darin Adler  <darin@apple.com>
1397
1398         Update style checker and tests to deal with override instead of OVERRIDE
1399         https://bugs.webkit.org/show_bug.cgi?id=127175
1400
1401         Reviewed by Anders Carlsson.
1402
1403         * Scripts/webkitpy/style/checkers/cpp.py:
1404         (check_braces): Use override instead of OVERRIDE.
1405         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1406         (CppStyleTest.test_brace_at_begin_of_line): Ditto.
1407
1408 2014-01-20  Alexey Proskuryakov  <ap@apple.com>
1409
1410         EWS should provide better information to Dashboard via JSON
1411         https://bugs.webkit.org/show_bug.cgi?id=127265
1412
1413         Reviewed by Ryosuke Niwa.
1414
1415         * QueueStatusServer/app.yaml: Updated version.
1416
1417         * QueueStatusServer/main.py:
1418         * QueueStatusServer/handlers/queuelengthjson.py:
1419         Added a way to cheaply get only the queue length, which is all the dashboard
1420         needs unless a popover is opened.
1421
1422         * QueueStatusServer/handlers/queuestatusjson.py: Updated to return more information
1423         that we will need. Changed some field names to be more meaningful. Fixed bot listing
1424         to understand that a bot can be reprurposed and used in a different queue.
1425
1426 2014-01-20  Alexey Proskuryakov  <ap@apple.com>
1427
1428         Make uploading results to EWS work despite robots.txt
1429         https://bugs.webkit.org/show_bug.cgi?id=127296
1430
1431         Reviewed by Ryosuke Niwa.
1432
1433         * Scripts/webkitpy/common/net/statusserver.py: (StatusServer.__init__): Disable
1434         checking robots.txt.
1435
1436         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py: (Bugzilla._get_browser):
1437         Removed a comment saying that we would want to stop doing this. Not checking
1438         robots.txt is more efficient than checking it.
1439
1440 2014-01-19  Ryuan Choi  <ryuan.choi@samsung.com>
1441
1442         [EFL][WK1] Remove and refactor the APIs which use single and base keyword
1443         https://bugs.webkit.org/show_bug.cgi?id=127214
1444
1445         Reviewed by Gyuyoung Kim.
1446
1447         Followed the changes of API.
1448
1449         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
1450         (drtViewAdd):
1451         * EWebLauncher/main.c:
1452         (windowCreate):
1453
1454 2014-01-19  Eunmi Lee  <eunmi15.lee@samsung.com>
1455
1456         [EFL][WK2] Add touch events option to MiniBrowser.
1457         https://bugs.webkit.org/show_bug.cgi?id=127262
1458
1459         Reviewed by Gyuyoung Kim.
1460
1461         As a default, touch events are disabled and mouse events are enabled.
1462         If touch events option sets to true, touch events are enabled and mouse
1463         events are disabled.
1464
1465         * MiniBrowser/efl/main.c:
1466         (window_create):
1467         (elm_main):
1468
1469 2014-01-19  Zalan Bujtas  <zalan@apple.com>
1470
1471         Pretty print LayoutUnit, LayoutPoint, and LayoutSize in lldb and gdb.
1472         https://bugs.webkit.org/show_bug.cgi?id=126080
1473
1474         Reviewed by Sam Weinig.
1475
1476         This changes the output of printing LayoutUnits to be in px but it also
1477         preserves the original LayoutUnit value.
1478
1479         This will lead to lldb output like: (and it works even when subpixel is disabled)
1480
1481         (const WebCore::LayoutRect) $0 = {
1482             m_location = { x = 2.25px (144), y = 1px (64)}
1483             m_size = { width = 13.75px (880), height = 20px (1280) }
1484
1485
1486         And gdb output like:
1487
1488         m_frameRect = {
1489             m_location = LayoutPoint(0px (0), 0px(0)),
1490             m_size = LayoutSize(8px (512), 5px (320))
1491         }
1492
1493         This patch is based on patch by bjonesbe@adobe.com and for Blink by cbiesinger@chromium.org.
1494
1495         * gdb/webkit.py:
1496         (WebCoreLayoutUnitPrinter):
1497         (WebCoreLayoutUnitPrinter.__init__):
1498         (WebCoreLayoutUnitPrinter.to_string):
1499         (WebCoreLayoutSizePrinter):
1500         (WebCoreLayoutSizePrinter.__init__):
1501         (WebCoreLayoutSizePrinter.to_string):
1502         (WebCoreLayoutPointPrinter):
1503         (WebCoreLayoutPointPrinter.__init__):
1504         (WebCoreLayoutPointPrinter.to_string):
1505         (add_pretty_printers):
1506         * lldb/lldb_webkit.py:
1507         (__lldb_init_module):
1508         (WebCoreLayoutUnit_SummaryProvider):
1509         (WebCoreLayoutSize_SummaryProvider):
1510         (WebCoreLayoutPoint_SummaryProvider):
1511         (WebCoreLayoutUnitProvider):
1512         (WebCoreLayoutUnitProvider.__init__):
1513         (WebCoreLayoutUnitProvider.to_string):
1514         (WebCoreLayoutSizeProvider):
1515         (WebCoreLayoutSizeProvider.__init__):
1516         (WebCoreLayoutSizeProvider.get_width):
1517         (WebCoreLayoutSizeProvider.get_height):
1518         (WebCoreLayoutPointProvider):
1519         (WebCoreLayoutPointProvider.__init__):
1520         (WebCoreLayoutPointProvider.get_x):
1521         (WebCoreLayoutPointProvider.get_y):
1522
1523 2014-01-18  Alexey Proskuryakov  <ap@apple.com>
1524
1525         Add robots.txt to http://webkit-queues.appspot.com
1526         https://bugs.webkit.org/show_bug.cgi?id=127240
1527
1528         * QueueStatusServer/app.yaml: Added required "upload" attribute for robots.txt.
1529
1530 2014-01-18  Alexey Proskuryakov  <ap@apple.com>
1531
1532         Add robots.txt to http://webkit-queues.appspot.com
1533         https://bugs.webkit.org/show_bug.cgi?id=127240
1534
1535         Reviewed by Ryosuke Niwa.
1536
1537         * QueueStatusServer/app.yaml: Added robots.txt as a static file. Updated version.
1538
1539         * QueueStatusServer/robots.txt: Added.
1540
1541 2014-01-18  Alberto Garcia  <berto@igalia.com>
1542
1543         Tools/Scripts/test-webkitperl fails: 'tempdir' can't be called as a method
1544         https://bugs.webkit.org/show_bug.cgi?id=127217
1545
1546         Reviewed by Daniel Bates.
1547
1548         The syntax File::Temp->tempdir() was explicitly made invalid
1549         following <https://github.com/Perl-Toolchain-Gang/File-Temp/commit/c8920b2161ab6900a09e02b9410e0e4c3d74f565>
1550         which was included in File::Temp v2.30, shipped with Perl v5.18.0.
1551
1552         Use File::Temp::tempdir() instead.
1553
1554         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
1555
1556 2014-01-18  Alexey Proskuryakov  <ap@apple.com>
1557
1558         build.webkit.org/dashboard should have image diff links in test results popovers
1559         https://bugs.webkit.org/show_bug.cgi?id=127188
1560
1561         Reviewed by Timothy Hatcher.
1562
1563         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
1564         (Buildbot.prototype.layoutTestImagesURLForIteration):
1565         (Buildbot.prototype.layoutTestImageDiffURLForIteration):
1566         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1567         (BuildbotIteration.prototype.loadLayoutTestResults):
1568         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1569         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions.addFailureInfoLink):
1570         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions.addFailureInfoText):
1571         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions):
1572
1573 2014-01-18  Anders Carlsson  <andersca@apple.com>
1574
1575         Remove ENABLE_THREADED_HTML_PARSER defines everywhere
1576         https://bugs.webkit.org/show_bug.cgi?id=127225
1577
1578         Reviewed by Andreas Kling.
1579
1580         This concludes the removal of over 8.8 million lines of threaded parser code.
1581
1582         * Scripts/webkitperl/FeatureList.pm:
1583
1584 2014-01-17  Alexey Proskuryakov  <ap@apple.com>
1585
1586         build.webkit.org/dashboard should have diff links in test results popovers
1587         https://bugs.webkit.org/show_bug.cgi?id=126986
1588
1589         Reviewed by Tim Horton.
1590
1591         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
1592         (Buildbot.prototype.layoutTestCrashLogURLForIteration):
1593         (Buildbot.prototype.layoutTestStderrURLForIteration):
1594         (Buildbot.prototype.layoutTestDiffURLForIteration):
1595         (Buildbot.prototype.layoutTestPrettyDiffURLForIteration):
1596         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1597         (BuildbotIteration.prototype.loadLayoutTestResults):
1598         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1599         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions):
1600
1601 2014-01-17  Matthew Hanson  <matthew_hanson@apple.com>
1602
1603         Add the bare minimum support for branches to the bot-watchers dashboard
1604         https://bugs.webkit.org/show_bug.cgi?id=127124
1605
1606         This patch simply introduces the notion of branches into the bot-watchers dashboard.
1607         Subsequent patches will build functionality on top of this simple bit of infrastructure.
1608
1609         Reviewed by Timothy Hatcher.
1610
1611         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1612         (BuildbotQueue): store the branch property in the BuildbotQueue constructor
1613         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1614         Initialize the Dashboard.Branch object
1615
1616 2014-01-17  Chris Fleizach  <cfleizach@apple.com>
1617
1618         platform/mac/accessibility/aria-multiline.html sometimes asserts in AccessibilityController::removeNotificationListener
1619         https://bugs.webkit.org/show_bug.cgi?id=127141
1620
1621         Reviewed by Alexey Proskuryakov.
1622
1623         Make sure to reset the notification handler each time.
1624
1625         * DumpRenderTree/AccessibilityController.cpp:
1626         (AccessibilityController::resetToConsistentState):
1627         * DumpRenderTree/AccessibilityController.h:
1628         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
1629         (AccessibilityController::platformResetToConsistentState):
1630         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
1631         (AccessibilityController::platformResetToConsistentState):
1632         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
1633         (AccessibilityController::~AccessibilityController):
1634         (AccessibilityController::platformResetToConsistentState):
1635         (AccessibilityController::removeNotificationListener):
1636         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
1637         (AccessibilityController::platformResetToConsistentState):
1638
1639 2014-01-17  Alberto Garcia  <berto@igalia.com>
1640
1641         [GTK] Test /webkit/download/not-found fails in GTK Linux 64-bit Release bot
1642         https://bugs.webkit.org/show_bug.cgi?id=82329
1643
1644         Reviewed by Carlos Garcia Campos.
1645
1646         Unskip, this is working fine now.
1647
1648         * Scripts/run-gtk-tests:
1649         (TestRunner):
1650
1651 2014-01-17  Alberto Garcia  <berto@igalia.com>
1652
1653         [GTK] Test /webkit/webview/icon-uri times out in GTK Linux 64-bit Release bot
1654         https://bugs.webkit.org/show_bug.cgi?id=82328
1655
1656         Reviewed by Carlos Garcia Campos.
1657
1658         This was caused by the icon database being corrupted in the
1659         Release bot. After removing it the test works fine so it can be
1660         run again.
1661
1662         * Scripts/run-gtk-tests:
1663         (TestRunner):
1664
1665 2014-01-16  Alexey Proskuryakov  <ap@apple.com>
1666
1667         Test results popovers at http://build.webkit.org/dashboard should link to stderr
1668         https://bugs.webkit.org/show_bug.cgi?id=126929
1669
1670         Reviewed by Timothy Hatcher.
1671
1672         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
1673         (Buildbot.prototype.layoutTestCrashLogURLForIteration): Renamed for consistency.
1674         (Buildbot.prototype.layoutTestStderrURLForIteration): Added.
1675
1676         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1677         (BuildbotIteration.prototype.loadLayoutTestResults): Store has_stderr attribute.
1678
1679         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1680         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions):
1681         Add a link to stderr output if present.
1682
1683         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
1684         (.test-results-popover .additional-link): Style with light grey (will use the same style
1685         for diff links).
1686
1687 2014-01-16  Ryosuke Niwa  <rniwa@webkit.org>
1688
1689         Automate DoYouEvenBench
1690         https://bugs.webkit.org/show_bug.cgi?id=124497
1691
1692         Reviewed by Geoffrey Garen.
1693
1694         * Scripts/webkitpy/performance_tests/perftest.py:
1695         (PerfTestMetric.__init__): Added the aggregator name as an argument.
1696         (PerfTestMetric.aggregator): Added.
1697         (PerfTest._metrics_regex): Made the subtest name match non-greedy so that the metric names will be
1698         won't be eagerly parsed as a part of the subtest name. e.g. "Time" and "Total" in "a:Time:Total"
1699         should be parsed as the metric and the aggregator respectively.
1700         (PerfTest._run_with_driver): Pass in the aggregator name.
1701         (PerfTest._ensure_metrics): Ditto. Also split the subtest name by / as required by DoYouEvenBench
1702         which generates subtests of subtests within a single test file.
1703
1704         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1705         (test_parse_output_with_subtests_and_total): Added.
1706
1707         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1708         (_generate_results_dict): Add the aggregator name to the JSON when one is available.
1709
1710         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
1711         (TestWithSubtestsData): Added a sub test with an aggregator and a sub-sub test.
1712
1713 2014-01-16  Chris Fleizach  <cfleizach@apple.com>
1714
1715         platform/mac/accessibility/aria-multiline.html sometimes asserts in AccessibilityController::removeNotificationListener
1716         https://bugs.webkit.org/show_bug.cgi?id=127141
1717
1718         Reviewed by Alexey Proskuryakov.
1719
1720         Don't assert that the notification handler needs to be cleaned up. Deallocing the controller should be enough to clean up as it is.
1721
1722         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
1723         (AccessibilityController::~AccessibilityController):
1724
1725 2014-01-16  Ryosuke Niwa  <rniwa@webkit.org>
1726
1727         EWS shouldn't comment on Bugzilla for failing builds or style errors
1728         https://bugs.webkit.org/show_bug.cgi?id=127079
1729
1730         Reviewed by Anders Carlsson.
1731
1732         Since patch authors and reviewers could retrieve this information from bubbles,
1733         we shouldn't spam the Bugzilla with useless comments.
1734
1735         We still post style errors but not python paths we used since it's a pure noise.
1736
1737         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1738         (AbstractEarlyWarningSystem._post_reject_message_on_bug):
1739         * Scripts/webkitpy/tool/commands/queues.py:
1740         (StyleQueue.review_patch):
1741
1742 2014-01-15  Roger Fong  <roger_fong@apple.com>
1743
1744         Add support for handling WebGL load policies.
1745         https://bugs.webkit.org/show_bug.cgi?id=126935
1746         <rdar://problem/15790448>.
1747
1748         Reviewed by Timothy Horton.
1749
1750         * WebKitTestRunner/TestController.cpp: Update WKPageLoaderClient to V4.
1751         (WTR::TestController::createWebViewWithOptions):
1752
1753 2014-01-16  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
1754
1755         Remove workaround for compilers not supporting explicit override control
1756         https://bugs.webkit.org/show_bug.cgi?id=127111
1757
1758         Reviewed by Anders Carlsson.
1759
1760         Now all compilers support explicit override control, this workaround can be removed.
1761
1762         * DumpRenderTree/gtk/fonts/fonts.conf:
1763         * Scripts/do-webcore-rename:
1764         Removed this rename operation from the list of contemplated future renames.
1765         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp:
1766         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest_Bundle.cpp:
1767         * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp:
1768         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme_Bundle.cpp:
1769         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
1770
1771 2014-01-16  Oliver Hunt  <oliver@apple.com>
1772
1773         Stop run-jsc from consuming stderr output
1774         https://bugs.webkit.org/show_bug.cgi?id=127115
1775
1776         Reviewed by Mark Lam.
1777
1778         Simple patch to make run-jsc easier to deal with
1779
1780         * Scripts/run-jsc:
1781
1782 2014-01-16  Eva Balazsfalvi  <balazsfalvi.eva@stud.u-szeged.hu>
1783
1784         Tools/gtk/generate-feature-defines-files doesn't work with older versions of python
1785         https://bugs.webkit.org/show_bug.cgi?id=126323
1786
1787         Reviewed by Csaba Osztrogonác.
1788
1789         * gtk/generate-feature-defines-files:
1790
1791 2014-01-16  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
1792
1793         [EFL][WK2] Implement TestController::setHidden
1794         https://bugs.webkit.org/show_bug.cgi?id=127036
1795
1796         Reviewed by Gyuyoung Kim.
1797
1798         WebKitTestRunner needs TestController::setHidden implementation to
1799         properly handle page visibility API layout tests after r161105.
1800
1801         * WebKitTestRunner/efl/TestControllerEfl.cpp:
1802         (WTR::TestController::setHidden):
1803
1804 2014-01-16  Zan Dobersek  <zdobersek@igalia.com>
1805
1806         [GTK][MiniBrowser] The progress entry reset callback can be fired after the BrowserWindow is destroyed
1807         https://bugs.webkit.org/show_bug.cgi?id=127083
1808
1809         Reviewed by Carlos Garcia Campos.
1810
1811         When the load progress reaches 1.0 (i.e. 100%), a timeout callback is set up in webViewLoadProgressChanged.
1812         The progress entry is then reset back to 0 in that callback and the timeout source is removed.
1813
1814         The callback can be fired after the relevant BrowserWindow and its progress entry are destroyed, causing
1815         assertion failures in gtk_entry_set_progress_fraction due to an invalid GtkEntry object. To avoid that,
1816         To avoid that, the ID of the timeout source is stored on the BrowserWindow and is destroyed when the
1817         BrowserWindow object is being finalized, preventing the callback from firing.
1818
1819         * MiniBrowser/gtk/BrowserWindow.c:
1820         (resetEntryProgress):
1821         (webViewLoadProgressChanged):
1822         (browserWindowFinalize):
1823
1824 2014-01-15  Alexey Proskuryakov  <ap@apple.com>
1825
1826         DumpRenderTree doesn't disable web preferences autosave
1827         https://bugs.webkit.org/show_bug.cgi?id=127062
1828
1829         Reviewed by Dan Bernstein.
1830
1831         * DumpRenderTree/mac/DumpRenderTree.mm: (prepareConsistentTestingEnvironment):
1832         Do it.
1833
1834 2014-01-15  Dean Jackson  <dino@apple.com>
1835
1836         Improve filter-build-webkit, especially for iOS builds
1837         https://bugs.webkit.org/show_bug.cgi?id=81046
1838
1839         Reviewed by Joseph Pecoraro.
1840
1841         Lots of updates to the filtering rules, mostly from the
1842         iOS build output. Other highlights include:
1843         - ignoring escape sequences for color ouput
1844         - detecting escaped spaces in file name regexps
1845
1846         * Scripts/filter-build-webkit:
1847         (shouldIgnoreLine):
1848
1849 2014-01-15  Carlos Garcia Campos  <cgarcia@igalia.com>
1850
1851         [GTK] Web process sometimes crashes when printing in synchronous mode
1852         https://bugs.webkit.org/show_bug.cgi?id=126979
1853
1854         Reviewed by Gustavo Noronha Silva.
1855
1856         * Scripts/run-gtk-tests:
1857         (TestRunner): Unskip
1858         /webkit2/WebKitPrintOperation/close-after-print.
1859
1860 2014-01-15  ChangSeok Oh  <changseok.oh@collabora.com>
1861
1862         [EFL] Change test font installed path to webkitgtk-font-tests
1863         https://bugs.webkit.org/show_bug.cgi?id=126723
1864
1865         Reviewed by Gyuyoung Kim.
1866
1867         I'd like to change the test fonts installed directory from 'webkitgtk-test-fonts-0.0.3'
1868         to 'webkitgtk-test-fonts'. webkitgtk-test-fonts-0.0.3 doesn't match the path
1869         hard-coded in FontManagement.cpp#105
1870
1871         * DumpRenderTree/PlatformEfl.cmake:
1872         * WebKitTestRunner/PlatformEfl.cmake:
1873         * efl/jhbuild.modules:
1874
1875 2014-01-14  Ryosuke Niwa  <rniwa@webkit.org>
1876
1877         Make DoYouEvenBench runnable by run-perf-tests
1878         https://bugs.webkit.org/show_bug.cgi?id=127030
1879
1880         Reviewed by Andreas Kling.
1881
1882         Ignore console messages spit out by DoYouEvenBench and support aggregator names such as
1883         ":Total" to appear at the end of a test name. We don't do anything with it for now.
1884
1885         * Scripts/webkitpy/performance_tests/perftest.py:
1886         (PerfTest._metrics_regex): Handle aggregator names such as ":Total". We'll pass it down
1887         to the JSON in a follow up patch for the perf dashboard.
1888         (PerfTest._lines_to_ignore_in_parser_result): Added lines to ignore for DoYouEvenBench.
1889
1890 2014-01-14  Carlos Garcia Campos  <cgarcia@igalia.com>
1891
1892         [GTK] UI process crashes when the web process crashes while printing
1893         https://bugs.webkit.org/show_bug.cgi?id=126977
1894
1895         Reviewed by Gustavo Noronha Silva.
1896
1897         Add new test case to check that closing the window right after
1898         printing works. It's skipped for now, because this patch only
1899         fixes the UI process crash, but not the web process one.
1900
1901         * Scripts/run-gtk-tests:
1902         (TestRunner): Skip
1903         /webkit2/WebKitPrintOperation/close-after-print.
1904         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
1905         (testPrintOperationPrintPrinter):
1906         (findPrintToFilePrinter):
1907         (testPrintOperationPrint):
1908         (testPrintOperationErrors):
1909         (testPrintOperationCloseAfterPrint):
1910         (beforeAll):
1911
1912 2014-01-14  Brent Fulgham  <bfulgham@apple.com>
1913
1914         [WIN] Set MSBuild environment variable to avoid long-lived processes locking log files
1915         https://bugs.webkit.org/show_bug.cgi?id=127002
1916
1917         Reviewed by David Kilzer.
1918
1919         * Scripts/webkitdirs.pm:
1920         (setupAppleWinEnv): Export MSBUILDDISABLENODEREUSE=1 to the environment.
1921
1922 2014-01-14  Commit Queue  <commit-queue@webkit.org>
1923
1924         Unreviewed, rolling out r162000.
1925         http://trac.webkit.org/changeset/162000
1926         https://bugs.webkit.org/show_bug.cgi?id=127009
1927
1928         API versioning is wrong (Requested by rfong on #webkit).
1929
1930         * MiniBrowser/mac/WK2BrowserWindowController.m:
1931         (-[WK2BrowserWindowController awakeFromNib]):
1932         * WebKitTestRunner/TestController.cpp:
1933         (WTR::TestController::createOtherPage):
1934         (WTR::TestController::createWebViewWithOptions):
1935
1936 2014-01-13  Roger Fong  <roger_fong@apple.com>
1937
1938         Add support for handling WebGL load policies.
1939         https://bugs.webkit.org/show_bug.cgi?id=126935
1940         <rdar://problem/15790448>.
1941
1942         Reviewed by Brent Fulgham.
1943
1944         * MiniBrowser/mac/WK2BrowserWindowController.m:
1945         (-[WK2BrowserWindowController awakeFromNib]):
1946         * WebKitTestRunner/TestController.cpp:
1947         (WTR::TestController::createWebViewWithOptions):
1948
1949 2014-01-14  Zan Dobersek  <zdobersek@igalia.com>
1950
1951         [GTK] Skip FontConfig initialization in WebKitTestRunner if requested
1952         https://bugs.webkit.org/show_bug.cgi?id=120110
1953
1954         Reviewed by Martin Robinson.
1955
1956         Skip the FontConfig settings initialization in WebKitTestRunner if the
1957         WEBKIT_SKIP_WEBKITTESTRUNNER_FONTCONFIG_INITIALIZATION environment variable is set.
1958         This is useful when profiling the WebKitTestRunner execution, where at the startup
1959         this step takes considerable amount of time and disturbs the profiling output.
1960
1961         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1962         (WTR::initializeFontConfigSetting):
1963
1964 2014-01-14  Brian J. Burg  <burg@cs.washington.edu>
1965
1966         Add ENABLE(WEB_REPLAY) feature flag to the build system
1967         https://bugs.webkit.org/show_bug.cgi?id=126949
1968
1969         Reviewed by Joseph Pecoraro.
1970
1971         * Scripts/webkitperl/FeatureList.pm:
1972
1973 2014-01-14  László Langó  <llango.u-szeged@partner.samsung.com>
1974
1975         REGRESSION (r160085): check-webkit-style: utf8' codec can't decode byte 0x89 in position 0: invalid start byte.
1976         https://bugs.webkit.org/show_bug.cgi?id=126702
1977
1978         Reviewed by Alexey Proskuryakov.
1979
1980         Resolve regression and remove a FIXME comment that is already fixed.
1981
1982         * Scripts/webkitpy/common/system/filesystem.py:
1983         (FileSystem.open_text_file_for_reading):
1984         * Scripts/webkitpy/common/system/filesystem_unittest.py:
1985         (RealFileSystemTest.test_read_and_write_file):
1986         * Scripts/webkitpy/style/filereader.py:
1987         (TextFileReader._read_lines):
1988         * Scripts/webkitpy/style/filereader_unittest.py:
1989         (TextFileReaderTest.test_count_delete_only_file):
1990         (TextFileReaderTest):
1991         (TextFileReaderTest.test_process_malformed_file):
1992
1993 2014-01-02  Brian Holt  <brian.holt@samsung.com>
1994
1995         [GTK] Parse Valgrind xml leak files
1996         https://bugs.webkit.org/show_bug.cgi?id=119446
1997
1998         Reviewed by Alejandro G. Castro.
1999
2000         Parse the xml files generated by Valgrind to yield useful
2001         information about the memory leaks.
2002
2003         * Scripts/webkitpy/port/gtk.py:
2004         (GtkPort.__init__):
2005         (GtkPort.setup_test_run): Clear the previous output files before new
2006         run.
2007         (GtkPort.print_leaks_summary):
2008
2009         * Scripts/webkitpy/port/leakdetector_valgrind.py: Added.
2010         Parse the xml files generated by Valgrind and summarise leaks
2011         into an easily understandable list.
2012         (get_text_of):
2013         (get_CDATA_of):
2014         (gather_frames):
2015         (ValgrindError):
2016         (ValgrindError.__init__):
2017         (ValgrindError.__str__):
2018         (ValgrindError.unique_string):
2019         (ValgrindError.error_hash):
2020         (ValgrindError.__hash__):
2021         (ValgrindError.__eq__):
2022         (LeakDetectorValgrind):
2023         (LeakDetectorValgrind.__init__):
2024         (LeakDetectorValgrind._parse_leaks_output):
2025         (LeakDetectorValgrind.leaks_files_in_results_directory):
2026         (LeakDetectorValgrind.clean_leaks_files_from_results_directory):
2027         (LeakDetectorValgrind.parse_and_print_leaks_detail):
2028
2029         * Scripts/webkitpy/port/leakdetector_valgrind_unittest.py: Added.
2030         (make_mock_valgrind_output):
2031         (make_mock_incomplete_valgrind_output):
2032         (make_mock_valgrind_results):
2033         (make_mock_valgrind_results_incomplete):
2034         (make_mock_valgrind_results_empty):
2035         (make_mock_valgrind_results_misformatted):
2036         (mock_run_cppfilt_command):
2037         (LeakDetectorValgrindTest):
2038         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_pass):
2039         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_incomplete):
2040         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_empty):
2041         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_misformatted):
2042         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_pass):
2043         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_incomplete):
2044         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_empty):
2045         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_misformatted):
2046
2047 2014-01-13  Lucas Forschler  <lforschler@apple.com>
2048
2049         Update the LLINT CLoop Bot build infrastructure
2050         https://bugs.webkit.org/show_bug.cgi?id=126604
2051         
2052         Unreviewed.
2053         
2054         * BuildSlaveSupport/build.webkit.org-config/config.json:
2055         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2056         (CompileLLINTCLoop):
2057         (RunLLINTCLoopTests):
2058         (BuildAndTestLLINTCLoopFactory):
2059         (BuildAndTestLLINTCLoopFactory.__init__):
2060
2061 2014-01-13  Jinwoo Song  <jinwoo7.song@samsung.com>
2062
2063         [EFL][WK2] Disable failing API tests
2064         https://bugs.webkit.org/show_bug.cgi?id=126960
2065
2066         Reviewed by Gyuyoung Kim.
2067
2068         Disable WKViewUserViewportToContents test until bug 126261 is resolved.
2069
2070         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp:
2071         (TestWebKitAPI::TEST):
2072
2073 2014-01-13  Daniel Batyai  <dbatyai.u-szeged@partner.samsung.com>
2074
2075         Remove wdiff
2076         https://bugs.webkit.org/show_bug.cgi?id=124766
2077
2078         Reviewed by Ryosuke Niwa.
2079
2080         * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
2081         (ResultsJSONParserTest):
2082         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2083         (TestResultWriter):
2084         (TestResultWriter.create_text_diff_and_write_result):
2085         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2086         (summarize_results):
2087         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2088         (RunTest.test_output_diffs):
2089         * Scripts/webkitpy/port/base.py:
2090         (Port.__init__):
2091         (Port.driver_stop_timeout):
2092         (Port.check_image_diff):
2093         (Port.repository_paths):
2094         (Port._path_to_lighttpd_php):
2095         * Scripts/webkitpy/port/base_unittest.py:
2096         (PortTest.test_default_child_processes):
2097         (PortTest.test_pretty_patch_script_error):
2098         * Scripts/webkitpy/port/port_testcase.py:
2099         (PortTestCase.test_diff_image_crashed):
2100         * Scripts/webkitpy/port/test.py:
2101         (TestPort.operating_system):
2102
2103 2014-01-13  Martin Robinson  <mrobinson@igalia.com>
2104
2105         Build fix for the GTK+ CMake port
2106
2107         * TestWebKitAPI/PlatformGTK.cmake: The WKConnection test is no longer with us.
2108
2109 2014-01-13  Adrian Perez de Castro  <aperez@igalia.com>
2110
2111         [GTK] Add cast in call to g_object_add_weak_pointer in MiniBrowser
2112         https://bugs.webkit.org/show_bug.cgi?id=126881
2113
2114         Reviewed by Carlos Garcia Campos.
2115
2116         * MiniBrowser/gtk/BrowserWindow.c:
2117         (browser_window_new):
2118         Explicitly cast GtkWindow** to gpointer* in call to
2119         g_object_add_weak_pointer to avoid compiler warnings.
2120
2121 2014-01-13  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
2122
2123         Remove parsing of old-run-webkit-tests output from master.cfg
2124         https://bugs.webkit.org/show_bug.cgi?id=126690
2125
2126         Reviewed by Csaba Osztrogonác.
2127
2128         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2129         Removed parsing of ORWT output, as it is not used anymore.
2130         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2131         Updated unit tests accordingly.
2132
2133 2014-01-13  Commit Queue  <commit-queue@webkit.org>
2134
2135         Unreviewed, rolling out r161808.
2136         http://trac.webkit.org/changeset/161808
2137         https://bugs.webkit.org/show_bug.cgi?id=126874
2138
2139         This patch make several files to be always regenerated on
2140         every make (Requested by KaL on #webkit).
2141
2142         * WebKitTestRunner/GNUmakefile.am:
2143
2144 2014-01-13  Adrian Perez de Castro  <aperez@igalia.com>
2145
2146         [GTK] Make MiniBrowser windows non-transient by default
2147         https://bugs.webkit.org/show_bug.cgi?id=126840
2148
2149         Reviewed by Carlos Garcia Campos.
2150
2151         Instead of making new browser windows transient as soon as they are
2152         created, save the pointer to the parent window and set the transient
2153         state later on when handling the "run-as-modal" signal. This makes
2154         it easier to use the MiniBrowser to do tests involving multiple
2155         windows, and will be useful as well when multi-web-process mode is
2156         enabled for the GTK port.
2157
2158         * MiniBrowser/gtk/BrowserWindow.c:
2159         (webViewRunAsModal): Set the parent window using
2160         gtk_window_set_transient_for() using the saved parent
2161         window.
2162         (browser_window_new): Save the parent window using
2163         g_object_set_data() instead of making the new window
2164         transient immediately.
2165
2166 2014-01-12  Sergio Correia  <sergio.correia@openbossa.org>
2167
2168         [EFL][WK2] Make API tests work again
2169         https://bugs.webkit.org/show_bug.cgi?id=126769
2170
2171         Reviewed by Gyuyoung Kim.
2172
2173         The EFL and WK2 test binaries are currently being generated at *TestWebKitAPI/
2174         [E]WebKit2, respectively, and this causes problems because the logic to find
2175         where WebProcess is to look in the same directory of the running process and
2176         then proceed to use LIBEXECDIR (typically /usr/loca/bin).
2177
2178         This patch introduces a WEBKIT_EXEC_PATH environment variable, inspired in the
2179         Gtk port, which allows us to look for WebProcess initially in this directory,
2180         if it's defined.
2181
2182         * TestWebKitAPI/efl/main.cpp:
2183         (main): Define WEBKIT_EXEC_PATH to be used by WebKit2 API tests.
2184
2185 2014-01-12  Daniel Bates  <dabates@apple.com>
2186
2187         [iOS] Fix the build
2188
2189         For now, ensure we build WebKit System Interface before we build WebKit.
2190         We'll remove this constraint and the constraint to build WebKit Additions
2191         in a subsequent commit.
2192
2193         * Scripts/build-webkit:
2194
2195 2014-01-12  Carlos Garcia Campos  <cgarcia@igalia.com>
2196
2197         Unreviewed. Fix make distcheck.
2198
2199         * gtk/GNUmakefile.am: Add generate-inspector-gresource-manifest.py
2200         to EXTRA_DIST.
2201
2202 2014-01-12  Tobias Mueller  <tobiasmue@gnome.org>
2203
2204         --disable-dependency-tracking causes build failure due to missing directories
2205         https://bugs.webkit.org/show_bug.cgi?id=94488
2206
2207         Reviewed by Gustavo Noronha Silva.
2208
2209         Autotools build fix: Ensure output directory existing
2210         before generating DerivedSources. This allows for
2211         --disable-dependency-tracking to be run.
2212
2213
2214         * WebKitTestRunner/GNUmakefile.am: Added a new target of the directory in which files are meant to be stored.
2215
2216 2014-01-12  Carlos Garcia Campos  <cgarcia@igalia.com>
2217
2218         [GTK] Fix return value of WebKitDownload::created-destination
2219         https://bugs.webkit.org/show_bug.cgi?id=126741
2220
2221         Reviewed by Martin Robinson.
2222
2223         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp: Fix return
2224         value of several callbacks.
2225
2226 2014-01-11  Sam Weinig  <sam@webkit.org>
2227
2228         Add support for null StringViews
2229         https://bugs.webkit.org/show_bug.cgi?id=126827
2230
2231         Reviewed by Anders Carlsson.
2232
2233         Add new test for StringView.
2234
2235         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2236         * TestWebKitAPI/Tests/WTF/StringView.cpp: Added.
2237         (TestWebKitAPI::TEST):
2238
2239 2014-01-10  Benjamin Poulain  <bpoulain@apple.com>
2240
2241         Remove the BlackBerry port from trunk
2242         https://bugs.webkit.org/show_bug.cgi?id=126715
2243
2244         Reviewed by Anders Carlsson.
2245
2246         * DumpRenderTree/DumpRenderTree.h:
2247         * DumpRenderTree/PixelDumpSupport.cpp:
2248
2249 2014-01-10  Daniel Bates  <dabates@apple.com>
2250
2251         [iOS] Fix project build order
2252
2253         Ensure we build WebKitAdditions before WebCore (if applicable). Also, we don't
2254         build WebInspectorUI, Tools/MiniBrowser, or Tools/WebKitTestRunner on iOS at the
2255         time of writing.
2256
2257         * Scripts/build-webkit:
2258
2259 2014-01-10  Mario Sanchez Prada  <mario.prada@samsung.com>
2260
2261         Move platformName property from testRunner to accessibilityController
2262         https://bugs.webkit.org/show_bug.cgi?id=126689
2263
2264         Reviewed by Chris Fleizach.
2265
2266         Move the platformName property from the testRunner into
2267         accessibilityController, since this is a concept that has only be
2268         used by accessibility tests since it got added, and also because
2269         the real intention was not to distinguish among "ports" (mac, win,
2270         gtk, efl) but between platforms (atk, mac, win).
2271
2272         This change will be very useful to merge GTK's roles-exposed.html
2273         and Mac's role-subrole-roledescription.html into one single test,
2274         since we will be specifying in the test itself which elements are
2275         supported in which accessibility "platform". In this context,
2276         being able to check accessibilityController.platformName directly
2277         against a list of supported accessibility platforms (e.g. "atk,mac")
2278         will certainly maintain the code cleaner and simpler.
2279
2280         * DumpRenderTree/TestRunner.h:
2281         (TestRunner::platformName): Removed.
2282         * DumpRenderTree/TestRunner.cpp:
2283         (getPlatformNameCallback): Removed.
2284         (TestRunner::staticValues): Removed platformName
2285         * DumpRenderTree/efl/TestRunnerEfl.cpp:
2286         (TestRunner::platformName): Removed.
2287         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
2288         (TestRunner::platformName): Removed.
2289         * DumpRenderTree/mac/TestRunnerMac.mm:
2290         (TestRunner::platformName): Removed.
2291         * DumpRenderTree/win/TestRunnerWin.cpp:
2292         (TestRunner::platformName): Removed.
2293
2294         * DumpRenderTree/AccessibilityController.h:
2295         (AccessibilityController::platformName): Added.
2296         * DumpRenderTree/AccessibilityController.cpp:
2297         (getPlatformNameCallback): Added.
2298         (AccessibilityController::getJSClass): Added platformName.
2299         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
2300         (AccessibilityController::platformName): Added, returning "atk".
2301         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2302         (AccessibilityController::platformName): Ditto, returning "mac".
2303         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
2304         (AccessibilityController::platformName): Ditto, returning "ios".
2305         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2306         (AccessibilityController::platformName): Ditto, returning "win".
2307
2308         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2309         (platformName): Removed.
2310         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2311         (TestRunner::platformName): Removed.
2312         * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp:
2313         (TestRunner::platformName): Removed.
2314         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
2315         (TestRunner::platformName): Removed.
2316         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
2317         (TestRunner::platformName): Removed.
2318         * WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp:
2319         (TestRunner::platformName): Removed.
2320
2321         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
2322         (WTR:AccessibilityController::platformName): Added.
2323         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
2324         (platformName): Added.
2325         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
2326         (WTR::AccessibilityController::platformName): Added, returning "atk".
2327         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
2328         (WTR::AccessibilityController::platformName): Added, returning "mac".
2329
2330 2014-01-10  Benjamin Poulain  <bpoulain@apple.com>
2331
2332         Remove the BlackBerry port from trunk
2333         https://bugs.webkit.org/show_bug.cgi?id=126715
2334
2335         Reviewed by Anders Carlsson.
2336
2337         * Scripts/webkitpy/common/config/watchlist:
2338
2339 2014-01-09  Benjamin Poulain  <bpoulain@apple.com>
2340
2341         Remove the BlackBerry files outside WebCore
2342         https://bugs.webkit.org/show_bug.cgi?id=126715
2343
2344         Reviewed by Anders Carlsson.
2345
2346         * DumpRenderTree/blackberry: Removed.
2347
2348 2014-01-10  Simon Fraser  <simon.fraser@apple.com>
2349
2350         Remove knowledge of Blackberry from build scripts
2351         https://bugs.webkit.org/show_bug.cgi?id=126766
2352
2353         Reviewed by Anders Carlsson.
2354         
2355         Remove isBlackBerry() and references to it, and rmeove
2356         blackberry-related stuff from the watchlist.
2357
2358         * Scripts/build-webkit:
2359         * Scripts/webkit-build-directory:
2360         * Scripts/webkitdirs.pm:
2361         (determineBaseProductDir):
2362         (argumentsForConfiguration):
2363         (builtDylibPathForName):
2364         (isAppleWebKit):
2365         (buildCMakeProjectOrExit):
2366         (cmakeBasedPortArguments):
2367         (cmakeBasedPortName):
2368         * Scripts/webkitperl/FeatureList.pm:
2369         * Scripts/webkitpy/common/config/watchlist:
2370
2371 2014-01-10  Daniel Bates  <dabates@apple.com>
2372
2373         [iOS] Fix up simulator build and enable default features
2374
2375         Rubber-stamped by Joseph Pecoraro.
2376
2377         * Scripts/webkitdirs.pm:
2378         (determineArchitecture):
2379         (determinePassedArchitecture):
2380         * Scripts/webkitperl/FeatureList.pm: Also expose command line option to toggle ENABLE_PLUGIN_PROXY_FOR_VIDEO (enabled
2381         by default only in iOS).
2382
2383 2014-01-10  Daniel Bates  <dabates@apple.com>
2384
2385         [iOS] Upstream WebCore and Tools miscellaneous changes
2386         https://bugs.webkit.org/show_bug.cgi?id=126698
2387
2388         Reviewed by David Kilzer.
2389
2390         * Scripts/check-for-inappropriate-objc-class-names:
2391         * Scripts/check-for-webkit-framework-include-consistency:
2392
2393 2014-01-09  Dan Bernstein  <mitz@apple.com>
2394
2395         [Cocoa] Promote WKBackForwardList{,Item}.h to public
2396         https://bugs.webkit.org/show_bug.cgi?id=126707
2397
2398         Reviewed by Sam Weinig.
2399
2400         * Scripts/check-for-webkit-framework-include-consistency: Account for stale private headers
2401         left behind in the build products directory after a private header is made public.
2402
2403 2014-01-09  Carlos Garcia Campos  <cgarcia@igalia.com>
2404
2405         [SOUP] Partial file left on disk after a download fails or is cancelled in WebKit2
2406         https://bugs.webkit.org/show_bug.cgi?id=126686
2407
2408         Reviewed by Martin Robinson.
2409
2410         Test that partial files are not left on disk after a download has
2411         been cancelled after the destination has been decided. To make
2412         sure the download is cancelled after the destination has been
2413         decided and before the operation finishes, we cancel the download
2414         in the destination decided callback, and we use an infinite
2415         resource that writes chunks to the response body and never
2416         completes the body.
2417
2418         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
2419         (addContentDispositionHTTPHeaderToResponse): Helper function to
2420         add the Content-Disposition to the response headers.
2421         (writeNextChunkIdle): Write next chunk to response body.
2422         (writeNextChunk): Write next chunk in an idle to avoid flooding
2423         the network with the inifnite resource.
2424         (serverCallback): Add an inifinite resource.
2425         (testDownloadRemoteFileError): Check that partial file is not
2426         present after the download has been cancelled.
2427
2428 2014-01-09  Roland Takacs  <rtakacs@inf.u-szeged.hu>
2429
2430         Move myself to the committers list.
2431
2432         Unreviewed.
2433
2434         * Scripts/webkitpy/common/config/contributors.json:
2435
2436 2014-01-08  Seokju Kwon  <seokju@webkit.org>
2437
2438         [GTK] Unreviewed build fix after r161522.
2439
2440         * TestWebKitAPI/GNUmakefile.am: Remove WKConnection.cpp and WKConnection_Bundle.cpp.
2441
2442 2014-01-08  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
2443
2444         Missleading style error when mixing system and non-system header include lines.
2445         https://bugs.webkit.org/show_bug.cgi?id=126564
2446
2447         Reviewed by Ryosuke Niwa.
2448
2449         * Scripts/webkitpy/style/checkers/cpp.py:
2450         (check_include_line):
2451         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2452         (OrderOfIncludesTest.test_check_alphabetical_include_order):
2453         (OrderOfIncludesTest.test_public_primary_header):
2454
2455 2014-01-08  Seokju Kwon  <seokju@webkit.org>
2456
2457         [EFL] Unreviewed build fix after r161522.
2458
2459         * TestWebKitAPI/CMakeLists.txt:
2460         * TestWebKitAPI/PlatformEfl.cmake:
2461
2462 2014-01-08  Anders Carlsson  <andersca@apple.com>
2463
2464         Remove WKConnectionRef tests
2465         https://bugs.webkit.org/show_bug.cgi?id=126666
2466
2467         Reviewed by Dan Bernstein.
2468
2469         The WKConnectionRef is poorly designed but thankfully not used anywhere. 
2470         Remove the API tests as a first step towards killing the entire thing.
2471
2472         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2473         * TestWebKitAPI/Tests/WebKit2/WKConnection.cpp: Removed.
2474         * TestWebKitAPI/Tests/WebKit2/WKConnection_Bundle.cpp: Removed.
2475
2476 2014-01-08  Commit Queue  <commit-queue@webkit.org>
2477
2478         Unreviewed, rolling out r161512.
2479         http://trac.webkit.org/changeset/161512
2480         https://bugs.webkit.org/show_bug.cgi?id=126655
2481
2482         Broke webkitpy tests (Requested by ap on #webkit).
2483
2484         * Scripts/webkitpy/port/gtk.py:
2485         (GtkPort.__init__):
2486         (GtkPort.setup_test_run):
2487         (GtkPort._port_specific_expectations_files):
2488         * Scripts/webkitpy/port/leakdetector_valgrind.py: Removed.
2489         * Scripts/webkitpy/port/leakdetector_valgrind_unittest.py: Removed.
2490
2491 2014-01-08  Commit Queue  <commit-queue@webkit.org>
2492
2493         Unreviewed, rolling out r161517.
2494         http://trac.webkit.org/changeset/161517
2495         https://bugs.webkit.org/show_bug.cgi?id=126659
2496
2497         The fix didn't completely remove the problem and is now
2498         standing in the way of the rollout of the offending patch
2499         (Requested by zdobersek on #webkit).
2500
2501         * Scripts/webkitpy/port/gtk.py:
2502         (GtkPort.__init__):
2503
2504 2014-01-08  Zan Dobersek  <zdobersek@igalia.com>
2505
2506         Unreviewed. Attempting to fix webkitpy tests after r161512.
2507
2508         * Scripts/webkitpy/port/gtk.py:
2509         (GtkPort.__init__): Construct LeakDetectorValgrin only if leak detection is enabled.
2510
2511 2014-01-08  Brian Holt  <brian.holt@samsung.com>
2512
2513         [GTK] Parse Valgrind xml leak files
2514         https://bugs.webkit.org/show_bug.cgi?id=119446
2515
2516         Reviewed by Alejandro G. Castro.
2517
2518         Parse the xml files generated by Valgrind to yield useful
2519         information about the memory leaks.
2520
2521         * Scripts/webkitpy/port/gtk.py:
2522         (GtkPort.__init__):
2523         (GtkPort.setup_test_run): Clear the previous output files before new
2524         run.
2525         (GtkPort.print_leaks_summary):
2526
2527         * Scripts/webkitpy/port/leakdetector_valgrind.py: Added.
2528         Parse the xml files generated by Valgrind and summarise leaks
2529         into an easily understandable list.
2530         (get_text_of):
2531         (get_CDATA_of):
2532         (gather_frames):
2533         (ValgrindError):
2534         (ValgrindError.__init__):
2535         (ValgrindError.__str__):
2536         (ValgrindError.unique_string):
2537         (ValgrindError.error_hash):
2538         (ValgrindError.__hash__):
2539         (ValgrindError.__eq__):
2540         (LeakDetectorValgrind):
2541         (LeakDetectorValgrind.__init__):
2542         (LeakDetectorValgrind._parse_leaks_output):
2543         (LeakDetectorValgrind.leaks_files_in_results_directory):
2544         (LeakDetectorValgrind.clean_leaks_files_from_results_directory):
2545         (LeakDetectorValgrind.parse_and_print_leaks_detail):
2546
2547         * Scripts/webkitpy/port/leakdetector_valgrind_unittest.py: Added.
2548         (make_mock_valgrind_output):
2549         (make_mock_incomplete_valgrind_output):
2550         (make_mock_valgrind_results):
2551         (make_mock_valgrind_results_incomplete):
2552         (make_mock_valgrind_results_empty):
2553         (make_mock_valgrind_results_misformatted):
2554         (LeakDetectorValgrindTest):
2555         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_pass):
2556         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_incomplete):
2557         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_empty):
2558         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_misformatted):
2559         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_pass):
2560         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_incomplete):
2561         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_empty):
2562         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_misformatted):
2563
2564 2014-01-08  Commit Queue  <commit-queue@webkit.org>
2565
2566         Unreviewed, rolling out r161427.
2567         http://trac.webkit.org/changeset/161427
2568         https://bugs.webkit.org/show_bug.cgi?id=126645
2569
2570         Emits a stye error on any newly added files (Requested by ap
2571         on #webkit).
2572
2573         * Scripts/webkitpy/style/checkers/cpp.py:
2574         (check_style):
2575         (CppChecker):
2576         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2577         (WebKitStyleTest.test_other):
2578
2579 2014-01-08  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
2580
2581         Remove run-webkit-tests wrapper script as all platform are using NRWT now.
2582         https://bugs.webkit.org/show_bug.cgi?id=126580
2583
2584         Reviewed by Csaba Osztrogonác.
2585
2586         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2587         (RunWebKitTests): Passing --debug-rwt-logging here instead of the
2588         run-webkit-tests script.
2589         * Scripts/new-run-webkit-tests: Renamed to run-webkit-tests.
2590         * Scripts/run-webkit-tests: Removed, as it was just a temporary hack.
2591
2592 2014-01-08  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
2593
2594         Update the list of non-committer u-szeged contributors
2595         https://bugs.webkit.org/show_bug.cgi?id=126640
2596
2597         Reviewed by Csaba Osztrogonác.
2598
2599         * Scripts/webkitpy/common/config/contributors.json:
2600
2601 2014-01-08  Alberto Garcia  <berto@igalia.com>
2602
2603         Fix some compilation warnings
2604         https://bugs.webkit.org/show_bug.cgi?id=126635
2605
2606         Reviewed by Csaba Osztrogonác.
2607
2608         * GtkLauncher/main.c:
2609         (createWindow): This function is not supposed to receive any
2610         parameter, yet we are passing one.
2611
2612 2014-01-08  Brian Holt  <brian.holt@samsung.com>
2613
2614         [GTK][WK2] unskip passing unit tests
2615         https://bugs.webkit.org/show_bug.cgi?id=126637
2616
2617         Reviewed by Carlos Garcia Campos.
2618
2619         Unskip TestResources and TestAuthentication unit tests since they
2620         are passing both under Xvfb and X.
2621
2622         * Scripts/run-gtk-tests:
2623         (TestRunner):
2624
2625 2014-01-08  Alberto Garcia  <berto@igalia.com>
2626
2627         REGRESSION(r160304): [GTK] Disable libtool fast install
2628         https://bugs.webkit.org/show_bug.cgi?id=126381
2629
2630         Reviewed by Gustavo Noronha Silva.
2631
2632         Disable the libtool fast-install mode in developer/test builds.
2633
2634         In this mode binaries are generated ready to be used directly from
2635         the build tree. Otherwise they would need to be relinked when they
2636         are executed, which can take a lot of resources, particularly in
2637         debug builds.
2638
2639         * Scripts/webkitdirs.pm:
2640         (runAutogenForAutotoolsProjectIfNecessary):
2641
2642 2014-01-08  Zan Dobersek  <zdobersek@igalia.com>
2643
2644         Unreviewed GTK gardening.
2645
2646         * Scripts/run-gtk-tests:
2647         (TestRunner): Skipping the snapshot test case from the TestWebKitWebView test suite.
2648         The test is failing due to issues with Xvfb, with the problem being handled in bug #120404.
2649
2650 2014-01-07  Lucas Forschler  <lforschler@apple.com>
2651
2652         Add buildbot infrasctructure for building and testing JSC cloop
2653         https://bugs.webkit.org/show_bug.cgi?id=126604
2654
2655         Reviewed by Geoffrey Garen.
2656
2657         * BuildSlaveSupport/build.webkit.org-config/config.json:
2658         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2659         (CompileCLOOP):
2660         (RunCLOOPTests):
2661         (RunCLOOPTests.countFailures):
2662         (BuildAndTestCLOOP):
2663
2664 2014-01-07  Brian Burg  <bburg@apple.com>
2665
2666         Unreviewed. Add myself as a committer.
2667
2668         * Scripts/webkitpy/common/config/contributors.json:
2669
2670 2014-01-07  Alexey Proskuryakov  <ap@apple.com>
2671
2672         Popovers at build.webkit.org/dashboard could have titles
2673         https://bugs.webkit.org/show_bug.cgi?id=126495
2674
2675         Reviewed by Timothy Hatcher.
2676
2677         Added titles to all popovers except for pending revisions one, which I would like
2678         to improve more (probably add an ETA).
2679
2680         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
2681         (BuildbotBuilderQueueView.prototype._presentPopoverFailureLogs): Moved code for 
2682         adding a title to base class.
2683
2684         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2685         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Moved code for inserting
2686         a divider to a separate function.
2687         (BuildbotQueueView.prototype._presentPopoverForRevisionRange): Added a title.
2688         (BuildbotQueueView.prototype._presentNoChangePopover): Updated the text to match
2689         title from above function.
2690         (BuildbotQueueView.prototype._revisionPopoverContentForIteration): Renamed "contentElement"
2691         variable to "content" to match all other code.
2692         (BuildbotQueueView.prototype._addIterationHeadingToPopover): Added.
2693         (BuildbotQueueView.prototype._addDividerToPopover): Added.
2694
2695         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2696         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions): Add a title.
2697         (BuildbotTesterQueueView.prototype._presentPopoverForLayoutTestRegressions): Ditto.
2698         (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds): Ditto.
2699
2700         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
2701
2702 2014-01-07  Alexey Proskuryakov  <ap@apple.com>
2703
2704         There should be a delay when quickly switching to a different popover at build.webkit.org/dashboard
2705         https://bugs.webkit.org/show_bug.cgi?id=126472
2706
2707         Reviewed by Timothy Hatcher.
2708
2709         Added a delay when quickly switching to a different popover, making it easier to
2710         move mouse pointer from active element to its popover without accidentally opening
2711         a different popover.
2712
2713         Used this code to add a delay before creating a popover. This doesn't change UI
2714         behavior, as there was alerady a delay before it became visible, but it avoids
2715         flooding buildbot server with http requests when quickly moving the mouse over
2716         dashboard page.
2717
2718         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Popover.js:
2719         Fixed a case where popover could get stuck. If content was updated while fade-out
2720         transition was already in place, the transition was removed for no good reason.
2721
2722         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/PopoverTracker.js:
2723         (PopoverTracker._onblur): While at it, also taught popovers to disappear on window blur.
2724
2725         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Popover.css:
2726         (.popover.step-in): Now that PopoverTracker has a 200ms delay of its own, reduced
2727         popover delay from 1s to 800ms.
2728
2729 2014-01-07  Alexey Proskuryakov  <ap@apple.com>
2730
2731         Improve display of failed builds at build.webkit.org/dashboard
2732         https://bugs.webkit.org/show_bug.cgi?id=126542
2733         <rdar://problem/15753550>
2734
2735         Reviewed by Timothy Hatcher.
2736
2737         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
2738         Instead of hardcoding step name, look for the first step that failed.
2739         While at it, added a popover with more links. There are multiple, and it's good
2740         to have a choice of which one to look at in each situation.
2741
2742         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2743         (BuildbotIteration.prototype.get successful): Being successful is not the opposite
2744         of having failed. Many iterations are interrupted for whatever reason internal to
2745         Buildbot, and these are suppoed to be orange, not red.
2746         (BuildbotIteration.prototype.get productive): Changed to exclude inerrupted iterations,
2747         not only WillRetry ones.
2748         (BuildbotIteration.prototype.get failed): Changed to only include iterations that
2749         actually failed, more likely indicating a problem with code base.
2750         (BuildbotIteration.prototype.get firstFailedStepName):
2751         (BuildbotIteration.prototype.failureLogURL): Expose informaiton about failure.
2752         (BuildbotIteration.prototype.get failureLogs): Ditto.
2753         (BuildbotIteration.prototype.update): Store complete results for the failed step.
2754         Not every failure stops the iteration, so we could have multiple failed steps,
2755         but let's see if seeing just the first one will be enough.
2756
2757         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2758         (BuildbotQueue.prototype.get firstRecentUnsuccessfulIteration): Updated to work in
2759         terms of successful iterations.
2760         (BuildbotQueue.prototype.get mostRecentSuccessfulIteration): Ditto.
2761
2762         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2763         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): Updated to work in
2764         terms of successful iterations.
2765
2766         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2767         Removed code to create a path to build output, we now take it from results JSON.
2768
2769         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
2770         Added styles for the new popover.
2771
2772 2014-01-07  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
2773
2774         defined constants should use all uppercase names with words separated by underscores.
2775         https://bugs.webkit.org/show_bug.cgi?id=126055
2776
2777         Reviewed by Alexey Proskuryakov.
2778
2779         * Scripts/webkitpy/style/checkers/cpp.py:
2780         (check_style):
2781         (CppChecker):
2782         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2783         (WebKitStyleTest.test_define_constants):
2784
2785 2014-01-07  Brian Holt  <brian.holt@samsung.com>
2786
2787         Unreviewed. Add myself as a committer.
2788
2789         * Scripts/webkitpy/common/config/contributors.json:
2790
2791 2014-01-07  Csaba Osztrogonác  <ossy@webkit.org>
2792
2793         Remove the WinCE buildbot from build.webkit.org
2794         https://bugs.webkit.org/show_bug.cgi?id=126517
2795
2796         Reviewed by Alexey Proskuryakov.
2797
2798         * BuildSlaveSupport/build.webkit.org-config/config.json:
2799         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2800         (appendCustomBuildFlags):
2801
2802 2014-01-07  Krzysztof Czech  <k.czech@samsung.com>
2803
2804         [EFL] Change ATK version to 2.11.4
2805         https://bugs.webkit.org/show_bug.cgi?id=126573
2806
2807         Reviewed by Gyuyoung Kim.
2808
2809         ATK 2.11.4 introduces some new roles, that are already being used by WebKit.
2810
2811         * efl/jhbuild.modules:
2812
2813 2014-01-07  Alberto Garcia  <berto@igalia.com>
2814
2815         [GTK][EFL] Use function jhbuildWrapperPrefixIfNeeded to run launcher
2816         https://bugs.webkit.org/show_bug.cgi?id=117275
2817
2818         Reviewed by Carlos Garcia Campos.
2819
2820         If we are not using the internal jhbuild we must not use the
2821         jhbuild-wrapper script, else it will try to download and install
2822         it.
2823
2824         * Scripts/run-launcher:
2825
2826 2014-01-07  Krzysztof Czech  <k.czech@samsung.com>
2827
2828         [ATK] Expose aria-checked mixed state as ATK_STATE_INDETERMINATE
2829         https://bugs.webkit.org/show_bug.cgi?id=125855
2830
2831         Reviewed by Mario Sanchez Prada.
2832
2833         Added new function isIndeterminate for testing aria-checked mixed state.
2834         I provided respective, but empty function in mac port. Mac testing it differently.
2835
2836         * DumpRenderTree/AccessibilityUIElement.cpp:
2837         (getIsIndeterminate):
2838         (AccessibilityUIElement::getJSClass):
2839         * DumpRenderTree/AccessibilityUIElement.h:
2840         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2841         (AccessibilityUIElement::isIndeterminate):
2842         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm: Added empty function.
2843         (AccessibilityUIElement::isIndeterminate):
2844         * DumpRenderTree/mac/AccessibilityUIElementMac.mm: Added empty function.
2845         (AccessibilityUIElement::isIndeterminate):
2846         * DumpRenderTree/win/AccessibilityUIElementWin.cpp: Added empty function.
2847         (AccessibilityUIElement::isIndeterminate):
2848         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2849         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2850         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2851         (WTR::AccessibilityUIElement::isIndeterminate):
2852         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2853         (WTR::AccessibilityUIElement::isIndeterminate):
2854
2855 2014-01-06  Mark Rowe  <mrowe@apple.com>
2856
2857         <https://webkit.org/b/126560> Fix incorrectness in use of some AppKit enums
2858
2859         Reviewed by Ryosuke Niwa.
2860
2861         * DumpRenderTree/mac/DumpRenderTree.mm:
2862         (-[DRTMockScroller rectForPart:]): Move to using an if with early return instead of a switch
2863         with a single case. This avoids the potential for warnings about unhandled cases.
2864         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2865         (WTR::PlatformWebView::PlatformWebView): Cast the argument to NSBackingStoreType.
2866
2867 2014-01-04  Carlos Garcia Campos  <cgarcia@igalia.com>
2868
2869         [GTK] Move all GTK/GObject unit tests to Tools/TestWebKitAPI
2870         https://bugs.webkit.org/show_bug.cgi?id=126342
2871
2872         Reviewed by Gustavo Noronha Silva.
2873
2874         * CMakeLists.txt: Include the new unit tests subdirectories.
2875         * Scripts/run-gtk-tests: Update to refer to the new build locations.
2876         * Scripts/webkitpy/style/checker.py: Update the style checker.
2877         * Scripts/webkitpy/style/checker_unittest.py:
2878         * TestWebKitAPI/GNUmakefile.am:
2879         * TestWebKitAPI/Tests/WebKit2Gtk/AccessibilityTestServer.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/AccessibilityTestServer.cpp.
2880         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Added.
2881         * TestWebKitAPI/Tests/WebKit2Gtk/DOMDOMWindowTest.cpp: Added.
2882         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/DOMNodeTest.cpp.
2883         * TestWebKitAPI/Tests/WebKit2Gtk/FrameTest.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/FrameTest.cpp.
2884         * TestWebKitAPI/Tests/WebKit2Gtk/InspectorTestServer.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/InspectorTestServer.cpp.
2885         * TestWebKitAPI/Tests/WebKit2Gtk/LoadTrackingTest.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/LoadTrackingTest.cpp.
2886         * TestWebKitAPI/Tests/WebKit2Gtk/LoadTrackingTest.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/LoadTrackingTest.h.
2887         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestAuthentication.cpp.
2888         * TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestBackForwardList.cpp.
2889         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestContextMenu.cpp.
2890         * TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestCookieManager.cpp.
2891         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMDOMWindow.cpp: Added.
2892         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestDOMNode.cpp.
2893         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestDownloads.cpp.
2894         * TestWebKitAPI/Tests/WebKit2Gtk/TestFrame.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestFrame.cpp.
2895         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspector.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestInspector.cpp.
2896         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestInspectorServer.cpp.
2897         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestLoaderClient.cpp.
2898         * TestWebKitAPI/Tests/WebKit2Gtk/TestMain.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestMain.cpp.
2899         * TestWebKitAPI/Tests/WebKit2Gtk/TestMain.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestMain.h.
2900         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestPrinting.cpp.
2901         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestResources.cpp.
2902         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestSSL.cpp.
2903         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestUIClient.cpp.
2904         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebExtensions.cpp.
2905         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitAccessibility.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitAccessibility.cpp.
2906         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitFaviconDatabase.cpp.
2907         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFindController.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitFindController.cpp.
2908         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitPolicyClient.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitPolicyClient.cpp.
2909         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitSettings.cpp.
2910         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitVersion.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitVersion.cpp.
2911         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebContext.cpp.
2912         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebView.cpp.
2913         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebViewGroup.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebViewGroup.cpp.
2914         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebViewEditor.cpp.
2915         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebExtensionTest.cpp.
2916         * TestWebKitAPI/Tests/WebKit2Gtk/WebKitTestBus.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebKitTestBus.cpp.
2917         * TestWebKitAPI/Tests/WebKit2Gtk/WebKitTestBus.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebKitTestBus.h.
2918         * TestWebKitAPI/Tests/WebKit2Gtk/WebKitTestServer.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebKitTestServer.cpp.
2919         * TestWebKitAPI/Tests/WebKit2Gtk/WebKitTestServer.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebKitTestServer.h.
2920         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebProcessTest.cpp.
2921         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebProcessTest.h.
2922         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTestRunner.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebProcessTestRunner.cpp.
2923         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTestRunner.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebProcessTestRunner.h.
2924         * TestWebKitAPI/Tests/WebKit2Gtk/WebViewTest.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebViewTest.cpp.
2925         * TestWebKitAPI/Tests/WebKit2Gtk/WebViewTest.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebViewTest.h.
2926         * TestWebKitAPI/Tests/WebKit2Gtk/resources/link-title.js: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/resources/link-title.js.
2927         * TestWebKitAPI/Tests/WebKit2Gtk/resources/test-cert.pem: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/resources/test-cert.pem.
2928         * TestWebKitAPI/Tests/WebKit2Gtk/resources/test-key.pem: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/resources/test-key.pem.
2929         * TestWebKitAPI/Tests/WebKit2Gtk/resources/webkit2gtk-tests.gresource.xml: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/resources/webkit2gtk-tests.gresource.xml.
2930         * TestWebKitAPI/Tests/WebKitGtk/CMakeLists.txt: Added.
2931         * TestWebKitAPI/Tests/WebKitGtk/resources/blank.ico: Renamed from Source/WebKit/gtk/tests/resources/blank.ico.
2932         * TestWebKitAPI/Tests/WebKitGtk/resources/test.html: Renamed from Source/WebKit/gtk/tests/resources/test.html.
2933         * TestWebKitAPI/Tests/WebKitGtk/resources/test.ogg: Renamed from Source/WebKit/gtk/tests/resources/test.ogg.
2934         * TestWebKitAPI/Tests/WebKitGtk/resources/test.pdf: Renamed from Source/WebKit/gtk/tests/resources/test.pdf.
2935         * TestWebKitAPI/Tests/WebKitGtk/resources/test.txt: Renamed from Source/WebKit/gtk/tests/resources/test.txt.
2936         * TestWebKitAPI/Tests/WebKitGtk/test_utils.c: Renamed from Source/WebKit/gtk/tests/test_utils.c.
2937         * TestWebKitAPI/Tests/WebKitGtk/test_utils.h: Renamed from Source/WebKit/gtk/tests/test_utils.h.
2938         * TestWebKitAPI/Tests/WebKitGtk/testapplicationcache.c: Renamed from Source/WebKit/gtk/tests/testapplicationcache.c.
2939         * TestWebKitAPI/Tests/WebKitGtk/testatk.c: Renamed from Source/WebKit/gtk/tests/testatk.c.
2940         * TestWebKitAPI/Tests/WebKitGtk/testatkroles.c: Renamed from Source/WebKit/gtk/tests/testatkroles.c.
2941         * TestWebKitAPI/Tests/WebKitGtk/testcontextmenu.c: Renamed from Source/WebKit/gtk/tests/testcontextmenu.c.
2942         * TestWebKitAPI/Tests/WebKitGtk/testcopyandpaste.c: Renamed from Source/WebKit/gtk/tests/testcopyandpaste.c.
2943         * TestWebKitAPI/Tests/WebKitGtk/testdomdocument.c: Renamed from Source/WebKit/gtk/tests/testdomdocument.c.
2944         * TestWebKitAPI/Tests/WebKitGtk/testdomdomwindow.c: Renamed from Source/WebKit/gtk/tests/testdomdomwindow.c.
2945         * TestWebKitAPI/Tests/WebKitGtk/testdomnode.c: Renamed from Source/WebKit/gtk/tests/testdomnode.c.
2946         * TestWebKitAPI/Tests/WebKitGtk/testdownload.c: Renamed from Source/WebKit/gtk/tests/testdownload.c.
2947         * TestWebKitAPI/Tests/WebKitGtk/testfavicondatabase.c: Renamed from Source/WebKit/gtk/tests/testfavicondatabase.c.
2948         * TestWebKitAPI/Tests/WebKitGtk/testglobals.c: Renamed from Source/WebKit/gtk/tests/testglobals.c.
2949         * TestWebKitAPI/Tests/WebKitGtk/testhittestresult.c: Renamed from Source/WebKit/gtk/tests/testhittestresult.c.
2950         * TestWebKitAPI/Tests/WebKitGtk/testhttpbackend.c: Renamed from Source/WebKit/gtk/tests/testhttpbackend.c.
2951         * TestWebKitAPI/Tests/WebKitGtk/testkeyevents.c: Renamed from Source/WebKit/gtk/tests/testkeyevents.c.
2952         * TestWebKitAPI/Tests/WebKitGtk/testloading.c: Renamed from Source/WebKit/gtk/tests/testloading.c.
2953         * TestWebKitAPI/Tests/WebKitGtk/testmimehandling.c: Renamed from Source/WebKit/gtk/tests/testmimehandling.c.
2954         * TestWebKitAPI/Tests/WebKitGtk/testnetworkrequest.c: Renamed from Source/WebKit/gtk/tests/testnetworkrequest.c.
2955         * TestWebKitAPI/Tests/WebKitGtk/testnetworkresponse.c: Renamed from Source/WebKit/gtk/tests/testnetworkresponse.c.
2956         * TestWebKitAPI/Tests/WebKitGtk/testwebbackforwardlist.c: Renamed from Source/WebKit/gtk/tests/testwebbackforwardlist.c.
2957         * TestWebKitAPI/Tests/WebKitGtk/testwebdatasource.c: Renamed from Source/WebKit/gtk/tests/testwebdatasource.c.
2958         * TestWebKitAPI/Tests/WebKitGtk/testwebframe.c: Renamed from Source/WebKit/gtk/tests/testwebframe.c.
2959         * TestWebKitAPI/Tests/WebKitGtk/testwebhistoryitem.c: Renamed from Source/WebKit/gtk/tests/testwebhistoryitem.c.
2960         * TestWebKitAPI/Tests/WebKitGtk/testwebinspector.c: Renamed from Source/WebKit/gtk/tests/testwebinspector.c.
2961         * TestWebKitAPI/Tests/WebKitGtk/testwebplugindatabase.c: Renamed from Source/WebKit/gtk/tests/testwebplugindatabase.c.
2962         * TestWebKitAPI/Tests/WebKitGtk/testwebresource.c: Renamed from Source/WebKit/gtk/tests/testwebresource.c.
2963         * TestWebKitAPI/Tests/WebKitGtk/testwebsettings.c: Renamed from Source/WebKit/gtk/tests/testwebsettings.c.
2964         * TestWebKitAPI/Tests/WebKitGtk/testwebview.c: Renamed from Source/WebKit/gtk/tests/testwebview.c.
2965         * TestWebKitAPI/Tests/WebKitGtk/testwindow.c: Renamed from Source/WebKit/gtk/tests/testwindow.c.
2966
2967 2014-01-06  Alexey Proskuryakov  <ap@apple.com>
2968
2969         Gtk and Efl API test results confuse the dashboard
2970         https://bugs.webkit.org/show_bug.cgi?id=126535
2971
2972         Reviewed by Tim Horton.
2973
2974         Added "API tests" step as "platform api tests".
2975
2976         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
2977         (Buildbot.prototype.platformAPITestResultsURLForIteration):
2978         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2979         (BuildbotIteration):
2980         (BuildbotIteration.prototype.update):
2981         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2982         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
2983         (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds):
2984
2985 2014-01-06  Tim Horton  <timothy_horton@apple.com>
2986
2987         build.webkit.org/dashboard should still function if localStorage is disabled
2988         https://bugs.webkit.org/show_bug.cgi?id=126511
2989
2990         Reviewed by Alexey Proskuryakov.
2991
2992         If localStorage is disabled, we should carry on with a warning.
2993
2994         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
2995         Don't show the gear if localStorage isn't working.
2996
2997         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
2998         (QueueView.prototype._updateHiddenState):
2999         Bail if localStorage isn't working.
3000
3001         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
3002         (Settings.prototype.available):
3003
3004 2014-01-02  Roger Fong  <roger_fong@apple.com>
3005
3006         Set VSINSTALLDIR in win ews start script.
3007         https://bugs.webkit.org/show_bug.cgi?id=126407
3008
3009         Reviewed by Brent Fulgham.
3010
3011         * EWSTools/start-queue-win.sh:
3012
3013 2014-01-06  Bem Jones-Bey  <bjonesbe@adobe.com>
3014
3015         Adding myself as a reviewer.
3016
3017         Unreviewed.
3018
3019         * Scripts/webkitpy/common/config/contributors.json:
3020
3021 2014-01-06  Zan Dobersek  <zdobersek@igalia.com>
3022
3023         Unreviewed. Unbreaking JSC tests after r161328.
3024
3025         * Scripts/webkitdirs.pm:
3026         (cmakeBasedPortName): Only recognize the GTK port as CMake-based if actually building
3027         through the CMake build system (i.e. passing --gtkcmake to build-webkit).
3028
3029 2014-01-05  Martin Robinson  <mrobinson@igalia.com>
3030
3031         [GTK][CMake] Add support for building the GTK+ port with cmake to build-webkit
3032         https://bugs.webkit.org/show_bug.cgi?id=126212
3033
3034         Reviewed by Daniel Bates.
3035
3036         Allow building the GTK+ cmake port with --gtkcmake.
3037
3038         * Scripts/build-webkit: Use the new isGtkCMake function to head down the CMake path
3039         when appropriate. Skip the autotoos path when isGtkAutotools is false.
3040         * Scripts/webkitdirs.pm: Add an isGtkCMake path in addition to the newly renamed isGtkAutotools.
3041         Add isGtk which checks isGtkCMake || isGtkAutotools
3042         (determineArchitecture): Use the CMake path for GTK+ when appropriate.
3043         (argumentsForConfiguration): use --gtkcmake when appropriate.
3044         (jscProductDir): Look in the CMake directory when appropriate.
3045         (builtDylibPathForName): CMake builds the library into a different directory, so handle that.
3046         (determineIsGtkCMake): Added.
3047         (isGtkCMake): Added.
3048         (isGtkAutotools): Renamed from isGtk.
3049         (isGtk): New function which returns isGtkAutotools || isGtkCMake.
3050         (determineIsGtkAutotools): Renamed from determineIsGtk.
3051         (cmakeBasedPortName): Added a GTK+ path.
3052
3053 2014-01-04  Martin Robinson  <mrobinson@igalia.com>
3054
3055         [GTK] [CMake] Fix the video and audio build
3056         https://bugs.webkit.org/show_bug.cgi?id=126464
3057
3058         Reviewed by Philippe Normand.
3059
3060         * GtkLauncher/CMakeLists.txt: Add GStreamer includes and libraries, since GtkLauncher uses it.
3061
3062 2014-01-03  Alexey Proskuryakov  <ap@apple.com>
3063
3064         It's confusing to have two elements link to the same URL at build.webkit.org/dashboard
3065         https://bugs.webkit.org/show_bug.cgi?id=126467
3066
3067         Reviewed by Geoffrey Garen.
3068
3069         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js:
3070         (StatusLineView): Don't linkify the label text, the bubble is easier to target with mouse
3071         pointer, or to tap.
3072
3073 2014-01-03  Alexey Proskuryakov  <ap@apple.com>
3074
3075         build.webkit.org/dashboard says "failed build" even if it's another step that failed
3076         https://bugs.webkit.org/show_bug.cgi?id=126461
3077
3078         Reviewed by Geoffrey Garen.
3079
3080         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
3081         (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus): Link to main
3082         build page if it's not the compilation that failed. Use text from buildbot for description.
3083         Show a yellow icon if it's a different kind of failure.
3084
3085         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3086         (BuildbotIteration.prototype.update): Record whether it was compile-webkit step that failed.
3087
3088 2014-01-03  Bem Jones-Bey  <bjonesbe@adobe.com>
3089
3090         setup-git-clone fails to get email address from git
3091         https://bugs.webkit.org/show_bug.cgi?id=126446
3092
3093         Reviewed by Ryosuke Niwa.
3094
3095         The setup-git-clone command fails to get an email address from git
3096         because of a bug in VCSUtils. This patch fixes that bug, and also
3097         makes it so that when VCSUtils fails for real because of a local
3098         misconfiguration, the error message is actually presented to the user
3099         of setup-git-clone.
3100
3101         * Scripts/VCSUtils.pm:
3102         (gitConfig): Call isGit() instead of accessing $isGit directly to make
3103             sure that $isGit is properly initialized.
3104         * Scripts/webkitpy/tool/commands/setupgitclone.py:
3105         (SetupGitClone.execute): Pull out username and email acquistion to
3106             it's own method.
3107         (SetupGitClone._get_username_and_email): Catch the exception thrown
3108             when VCSUtils fails and print out the error message so that the
3109             user actually knows why the command failed.
3110
3111 2014-01-03  Alexey Proskuryakov  <ap@apple.com>
3112
3113         It feels too hard to get rid of a popover at build.webkit.org/dashboard
3114         https://bugs.webkit.org/show_bug.cgi?id=126451
3115
3116         Reviewed by Simon Fraser.
3117
3118         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Popover.css:
3119         (.popover.fade-out): Reduced the timeout - 200 ms is enough to not have flicker
3120         when moving the mouse from an element to its popover.
3121
3122 2014-01-03  Alexey Proskuryakov  <ap@apple.com>
3123
3124         Please add a way to quick peek at failing tests at build.webkit.org/dashboard
3125         https://bugs.webkit.org/show_bug.cgi?id=122181
3126
3127         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3128         (BuildbotQueueView.prototype._presentNoChangePopover): Update one more place for
3129         popover.present signature change.
3130
3131 2014-01-03  Alexey Proskuryakov  <ap@apple.com>
3132
3133         Please add a way to quick peek at failing tests at build.webkit.org/dashboard
3134         https://bugs.webkit.org/show_bug.cgi?id=122181
3135
3136         Reviewed by Timothy Hatcher and Timothy Horton.
3137
3138         Detailed results are saved by run-webkit-tests to full_results.json (which is actually
3139         JSONP). Dashboard will load them on demand.
3140
3141         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
3142         (Buildbot.prototype.layoutTestResultsURLForIteration): Moved from WebKitBuildbot.js
3143         and made it use a function from WebKitBuildbot that builds results directory path.
3144         (Buildbot.prototype.layoutTestFullResultsURLForIteration): Added a function that builds
3145         a URL for full_results.json.
3146         (Buildbot.prototype.layoutTestCrashLogForIteration): Added a function that builds
3147         a URL for a crash log.
3148
3149         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3150         (BuildbotIteration.prototype.loadLayoutTestResults): Load and cache layout test results for
3151         the iteration.
3152
3153         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:        
3154         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Updated for changed
3155         popover API (see below).
3156         (BuildbotQueueView.prototype._presentPopoverForRevisionRange): Ditto.
3157
3158         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3159         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): Added a check
3160         for iterations that were interrupted (previously, they were displayed incorrectly,
3161         often as passes). Install popover trackers for failure bubbles for which we can currently
3162         display something useful.
3163         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions): Build
3164         a popover for layout test regressions when we have the data loaded on demand.
3165         We have test paths, special indicators for crashes/timeouts, and links to test history
3166         at flakiness dashboard.
3167         (BuildbotTesterQueueView.prototype._presentPopoverForLayoutTestRegressions): Show
3168         the popover for layout test regressions. Just shows "Loading..." until the data is
3169         loaded.
3170         (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds): List
3171         types of failures if there are multiple. There is a lot of similarity with
3172         appendBuilderQueueStatus(), but I couldn't find a good way to share the code.
3173
3174         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
3175         Create a global test history object, which is used for links in layout test popover.
3176
3177         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Popover.js:
3178         Changed the API to be more like WebInspector again, allowing for changing content
3179         of an existing popover. As the size of a popover can change, making the mouse pointer
3180         enter it without a mousenter event, install a handler for mousewheel instead, and block
3181         document scrolling from this event handler when needed.
3182
3183         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js:
3184         (StatusLineView.prototype.get statusBubbleElement): Added an accessor for status
3185         bubble element, making it possible to install a popover on it.
3186
3187         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
3188         (JSON.load): Added the ability to load JSONP by providing an optional callback name.
3189
3190         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3191         (WebKitBuildbot.prototype.layoutTestResultsDirectoryURLForIteration): Switched from
3192         building a complete results URL to only building one for root results path. This is
3193         the part that depends on specific buildbot installation, everything relative to it
3194         is the same.
3195
3196         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitTestHistory.js: Added.
3197         Build a path to test history page. In the future, we may consider adding code to
3198         load the data and display it inline.
3199
3200         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
3201         Added styles for this new popover.
3202
3203         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html: Added
3204         a new file, WebKitTestHistory.js.
3205
3206 2014-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3207
3208         REGRESSION(r161214): [GTK] WebKit2 C API tests fail to run after r161214
3209         https://bugs.webkit.org/show_bug.cgi?id=126430
3210
3211         Reviewed by Martin Robinson.
3212
3213         * Scripts/run-gtk-tests:
3214         (TestRunner._setup_testing_environment):
3215         * gtk/common.py: Use common.tests_library_build_path() instead.
3216         (tests_library_build_path): Helper funtion that returns the path
3217         where the tests libraries are built.
3218
3219 2014-01-03  Martin Robinson  <mrobinson@igalia.com>
3220
3221         [CMake] Build TestWebKitAPI tests into a directory structure
3222         https://bugs.webkit.org/show_bug.cgi?id=126358
3223
3224         Reviewed by Gyuyoung Kim.
3225
3226         WebKitGTK+ builds the TestWebKitAPI tests into a "TestWebKitAPI" directory. This
3227         is useful for keeping the "bin" directory tidy during building and will make it easier
3228         to integrate the CMake build into the existing WebKitGTK+ scripts.
3229
3230         * TestWebKitAPI/CMakeLists.txt: Set the output directory of all TestWebKitAPI binaries
3231         and make the names simpler now that the directory identifies what category the test is in.
3232
3233 2014-01-03  Alexey Proskuryakov  <ap@apple.com>
3234
3235         Provide a visual clue when element has a popover at build.webkit.org/dashboard
3236         https://bugs.webkit.org/show_bug.cgi?id=126281
3237
3238         Reviewed by Timothy Hatcher.
3239
3240         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/PopoverTracker.js:
3241         (PopoverTracker): Add a class name to elements with popovers.
3242
3243         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3244         (*): We have -webkit-user-select:none, so let's also not show text selection cursor.
3245         I might have broke that recently.
3246         (*:link): Show hand cursor over links.
3247         (.popover-tracking:hover): Put a shadow on hover over element with popovers.
3248
3249         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
3250         (.status-line .message .revision-number): Show text selection cursor on our only
3251         selectable text element.
3252         (.status-line .bubble.popover-tracking:hover): Text in a bubble looks better with
3253         a white shadow than with a dark one on hover.
3254
3255 2014-01-02  Carlos Garcia Campos  <cgarcia@igalia.com>
3256
3257         [GTK] Add API to WebKitResponsePolicyDecision to check if the MIME type can be shown
3258         https://bugs.webkit.org/show_bug.cgi?id=124652
3259
3260         Reviewed by Martin Robinson.
3261
3262         * MiniBrowser/gtk/BrowserWindow.c:
3263         (webViewDecidePolicy): Use the new API instead of
3264         webkit_web_view_can_show_mime_type().
3265
3266 2014-01-02  Carlos Garcia Campos  <cgarcia@igalia.com>
3267
3268         REGRESSION(r160304): [GTK] Disable libtool fast install
3269         https://bugs.webkit.org/show_bug.cgi?id=126381
3270
3271         Reviewed by Martin Robinson.
3272
3273         Remove -no-fast-install ld flag since fast install is now disabled
3274         globally.
3275
3276         * GNUmakefile.am:
3277         * GtkLauncher/GNUmakefile.am:
3278         * MiniBrowser/gtk/GNUmakefile.am:
3279         * TestWebKitAPI/GNUmakefile.am:
3280         * WebKitTestRunner/GNUmakefile.am:
3281
3282 2014-01-02  Ryuan Choi  <ryuan.choi@samsung.com>
3283
3284         Unreviewed. Add myself to EFL and related watch lists.
3285
3286         * Scripts/webkitpy/common/config/watchlist:
3287
3288 2014-01-02  Danilo Cesar Lemes de Paula  <danilo.cesar@collabora.co.uk>
3289
3290         [GTK] fixing ycm_extra_conf.py file
3291         https://bugs.webkit.org/show_bug.cgi?id=126371
3292
3293         It's an attempt to fix three problems with the current ycm_extra_conf file.
3294         The current implementation assumes that it's a symlink, which is not true.
3295         Usually python creates a pyc file, and this is what you get in __file__.
3296         the .pyc is not a symlink, and the current implementation doesn't work
3297         if that's the case.
3298
3299         It also assumes that the user is in the root folder.
3300         If the user is in WebkitBuild/Debug and open a file as ../../Source/* it won't work.
3301
3302         Last but not least, "elif flag in FLAGS_PRECEDING_PATHS" emits an
3303         exception since "flag" doesn't exists.
3304
3305         All those things were fixed.
3306
3307         Reviewed by Martin Robinson.
3308
3309         * gtk/ycm_extra_conf.py:
3310         (transform_relative_paths_to_absolute_paths):
3311
3312 2014-01-02  Alexey Proskuryakov  <ap@apple.com>
3313
3314         Bindings tests results links are broken at build.webkit.org/dashboard
3315         https://bugs.webkit.org/show_bug.cgi?id=126402
3316
3317         Reviewed by Tim Horton.
3318
3319         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
3320         (Buildbot.prototype.bindingsTestResultsURLForIteration): Fixed a typo that was there
3321         since the beginning.
3322
3323 2014-01-02  Alexey Proskuryakov  <ap@apple.com>
3324
3325         "+" is very confusing at http://build.webkit.org/dashboard
3326         https://bugs.webkit.org/show_bug.cgi?id=126400
3327
3328         Reviewed by Tim Horton.
3329
3330         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3331         (BuildbotQueueView.prototype._appendPendingRevisionCount): Instead of listing open
3332         source and internal counts separately, simply add them. One can always open a popover
3333         for more detail.
3334
3335 2014-01-02  Alexey Proskuryakov  <ap@apple.com>
3336
3337         Accessing Trac from build.webkit.org/dashboard should enable XMLHttpRequest.withCredentials
3338         https://bugs.webkit.org/show_bug.cgi?id=126391
3339
3340         Reviewed by Dan Bernstein.
3341
3342         Make it conditional, as trac.webkit.org doesn't work when withCredentials is enabled.
3343         One can request credentials use via Initialization.js.
3344
3345         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
3346         (Trac):
3347         (Trac.prototype.update):
3348         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
3349         (loadXML):
3350
3351 2014-01-02  Commit Queue  <commit-queue@webkit.org>
3352
3353         Unreviewed, rolling out r160846.
3354         http://trac.webkit.org/changeset/160846
3355         https://bugs.webkit.org/show_bug.cgi?id=126395
3356
3357         Breaks build scripts for Windows when Visual Studio is not
3358         installed in Program Files (Requested by rfong on #webkit).
3359
3360         * Scripts/webkitdirs.pm:
3361         (visualStudioInstallDir):
3362
3363 2014-01-02  Martin Robinson  <mrobinson@igalia.com>
3364
3365         [GTK] [CMake] run-gtk-tests should run with the cmake build
3366         https://bugs.webkit.org/show_bug.cgi?id=126341
3367
3368         Reviewed by Carlos Garcia Campos.
3369
3370         * Scripts/run-gtk-tests:
3371         (TestRunner.__init__): Use the new calling conventions for the common script.
3372         (TestRunner._setup_testing_environment): Ditto.
3373         * gtk/common.py:
3374         (set_build_types): Added set_build_types, to avoid having build_type arguments
3375         for all functions in common.
3376         (binary_build_path): Added this function which gets the path to the built binaries.
3377         (get_build_path): Removed the build_types argument.
3378         (build_path): Removed the build_types argument and call get_build_path directly now.
3379
3380 2014-01-02  Alexey Proskuryakov  <ap@apple.com>
3381
3382         https://bugs.webkit.org/show_bug.cgi?id=126391
3383         Accessing Trac from build.webkit.org/dashboard should enable XMLHttpRequest.withCredentials
3384
3385         Rubber-stamped by Dan Bernstein.
3386
3387         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
3388         (loadXML): Quick and dirty fix, with a FIXME.
3389
3390 2014-01-01  Martin Robinson  <mrobinson@igalia.com>
3391
3392         [GTK] Rename libtestnetscapeplugin to libTestNetscapePlugin
3393         https://bugs.webkit.org/show_bug.cgi?id=126349
3394
3395         Reviewed by Carlos Garcia Campos.
3396
3397         All CMake ports use "libTestNetscapePlugin," so choosing the same
3398         name in the autotools port will make the transition easier.
3399
3400         * GNUmakefile.am: Rename the plugin library.
3401
3402 2014-01-01  ChangSeok Oh  <changseok.oh@collabora.com>
3403
3404         [GTK][WK2] Back items are shown in reverse order in MiniBrowser
3405         https://bugs.webkit.org/show_bug.cgi?id=126354
3406
3407         Reviewed by Carlos Garcia Campos.
3408
3409         The latest visited site for backward history should be placed on the top of a history stack
3410         as a common behavior. However currently its order is reverse.
3411
3412         * MiniBrowser/gtk/BrowserWindow.c:
3413         (browserWindowUpdateNavigationActions):
3414
3415 2013-12-30  Martin Robinson  <mrobinson@igalia.com>
3416
3417         [GTK] Make the output directory of GObject unit tests binaries consistent with the CMake build
3418         https://bugs.webkit.org/show_bug.cgi?id=126297
3419
3420         Reviewed by Philippe Normand.
3421
3422         * Scripts/run-gtk-tests: Looks for the tests in the new directories.
3423         (TestRunner): Ditto.
3424         (TestRunner._run_test): Ditto.
3425
3426 2013-12-30  Alexey Proskuryakov  <ap@apple.com>
3427
3428         full_results.json should distinguish unexpected failures from expected ones
3429         https://bugs.webkit.org/show_bug.cgi?id=126300
3430
3431         Reviewed by Timothy Hatcher.
3432
3433         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
3434         (summarize_results): Add "report" element to JSON, which tells the consumer how
3435         this result was counted for summary.
3436
3437         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3438         Updated results to include the new element.
3439
3440         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
3441         (print_unexpected_results): Added a comment pointing to another place that
3442         summarizes results, and should stay in sync.
3443
3444 2013-12-30  Ryuan Choi  <ryuan.choi@samsung.com>
3445
3446         Replace remaning CoreIPC namespace to IPC
3447         https://bugs.webkit.org/show_bug.cgi?id=126305
3448
3449         Reviewed by Anders Carlsson.
3450
3451         * TestWebKitAPI/CMakeLists.txt: Replaced CoreIPC includes to IPC.
3452         * TestWebKitAPI/efl/PlatformWebView.cpp: Removed temporal define for IPC.
3453         * WebKitTestRunner/CMakeLists.txt: Replaced CoreIPC includes to IPC.
3454         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp: Removed temporal define for IPC.
3455
3456 2013-12-30  Brendan Long  <self@brendanlong.com>
3457
3458         Add myself to the committers list.
3459
3460         Unreviewed.
3461
3462         * Scripts/webkitpy/common/config/contributors.json:
3463
3464 2013-12-30  Carlos Garcia Campos  <cgarcia@igalia.com>
3465
3466         [GTK] Split WebKit2APITests/TestWebKitWebView
3467         https://bugs.webkit.org/show_bug.cgi?id=126284
3468
3469         Reviewed by Philippe Normand.
3470
3471         Skip only WebKitWebView/mouse-target and all TestAuthentication
3472         tests that are timing out when running under xvfb.
3473
3474         * Scripts/run-gtk-tests:
3475         (TestRunner):
3476
3477 2013-12-29  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
3478
3479         [EFL][WK2] Disable geolocation API test
3480         https://bugs.webkit.org/show_bug.cgi?id=125851
3481
3482         Reviewed by Gyuyoung Kim.
3483
3484         Geolocation is turned off by default in EFL port, so it shouldn't be tested.
3485
3486         * TestWebKitAPI/PlatformEfl.cmake: Move Geolocation to test_webkit2_api_fail_BINARIES.
3487
3488 2013-12-29  Ryuan Choi  <ryuan.choi@samsung.com>
3489
3490         [EFL] Remove ewk_view_tiled
3491         https://bugs.webkit.org/show_bug.cgi?id=125961
3492
3493         Reviewed by Gyuyoung Kim.
3494
3495         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3496         (shouldUseTiledBackingStore):
3497         Moved from DumpRenderTreeChrome to enable WebCore's TiledBackingStore
3498         instead of switching ewk_view_tiled.
3499         (DumpRenderTreeChrome::createView):
3500         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
3501         (drtViewAdd):
3502         * EWebLauncher/main.c: Removed ewk_view_tiled option.
3503         (windowCreate):
3504         (parseUserArguments):
3505
3506 2013-12-29  Alexey Proskuryakov  <ap@apple.com>
3507
3508         Pending revision popover is slightly misplaced at build.webkit.org/dashboard
3509         https://bugs.webkit.org/show_bug.cgi?id=126278
3510
3511         Reviewed by Timothy Hatcher.
3512
3513         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3514         (BuildbotQueueView.prototype._appendPendingRevisionCount): Create a span for the text,
3515         as StatusLineView message element has extra padding, and doesn't fit the text snugly.
3516         (BuildbotQueueView.prototype._revisionPopoverContentForIteration): Added bug number to a FIXME.
3517
3518         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js:
3519         (StatusLineView.prototype.set messageElement): Removed the getter, as we no longer need it.
3520
3521         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
3522         Removed display:inline-block hack for messageElement div, as we no longer use it for measuring text bounds.
3523
3524 2013-12-29  Alexey Proskuryakov  <ap@apple.com>
3525
3526         Interrupted test runs should not count at build.webkit.org/dashboard
3527         https://bugs.webkit.org/show_bug.cgi?id=126279
3528
3529         Reviewed by Timothy Hatcher.
3530
3531         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3532         (BuildbotIteration.prototype.get productive):
3533         (BuildbotIteration.prototype.get previousProductiveIteration): Replaced previous with
3534         this accessor to skips iterations that don't have relevant data. We still want to
3535         display them, but revision ranges should not be affected.
3536         (BuildbotIteration.prototype.update): Record whether the iteration was up for retry.
3537
3538         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3539         Use latest productive iteration instead of latest iteration for pending revision
3540         count and popovers.
3541
3542 2013-12-29  Alexey Proskuryakov  <ap@apple.com>
3543
3544         Please display (and link to) revision ranges at build.webkit.org/dashboard
3545         https://bugs.webkit.org/show_bug.cgi?id=122187
3546
3547         Reviewed by Timothy Hatcher.
3548
3549         Added popovers for revision numbers. Removed direct links, because they were misleading -
3550         a test run covers a revision range, not just the latest revision. This also makes
3551         selecting a revision for copy easier.
3552
3553         All revision numbers have the popovers for consistency, although they are most useful
3554         for iterations that are not the last ones in a view, because the content is a delta
3555         from previous iteration.
3556
3557         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
3558         (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus):
3559         revisionLinksForIteration() is now named revisionContentForIteration().
3560
3561         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3562         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
3563         Ditto.
3564
3565         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3566         (BuildbotIteration.prototype.get previous):