Tools/ChangeLog

   1 2015-04-07  Tim Horton  <timothy_horton@apple.com>
   2
   3         Expose and test fixedLayoutSize via modern WebKit SPI
   4         https://bugs.webkit.org/show_bug.cgi?id=143500
   5
   6         Reviewed by Simon Fraser.
   7
   8         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
   9         * TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm: Added.
  10         (-[FixedLayoutSizeNavigationDelegate webView:didFinishNavigation:]):
  11         (TEST):
  12         Add a test that verifies that fixedLayoutSize works at all, that
  13         it persists through a navigation, and that turning it back off reverts to
  14         laying out at the size of the view.
  15
  16 2015-04-07  Michael Catanzaro  <mcatanzaro@igalia.com>
  17
  18         Unreviewed. Add myself as a committer.
  19
  20         * Scripts/webkitpy/common/config/contributors.json:
  21
  22 2015-04-07  Brent Fulgham  <bfulgham@apple.com>
  23
  24         [Win] Bots complain about missing /etc/catalog
  25         https://bugs.webkit.org/show_bug.cgi?id=143484
  26
  27         Reviewed by Chris Dumez.
  28
  29         The libxml2 build on Mac, iOS, and Windows does not provide the set
  30         of default catalog files. We do not actually need these for our
  31         purposes, but we get warnings and some bot flakiness because they
  32         are not present.
  33
  34         We can avoid both problems the same way the Mac and iOS ports do,
  35         by setting the XML_CATALOG_FILES environment variable to 'empty string',
  36         which avoid the warnings and bot problems.
  37
  38         * Scripts/webkitpy/port/win.py:
  39         (WinPort.setup_environ_for_server): Added.
  40
  41 2015-04-06  Sam Weinig  <sam@webkit.org>
  42
  43         Use content extensions in MiniBrowser.
  44         https://bugs.webkit.org/show_bug.cgi?id=143446
  45
  46         Reviewed by Alex Christensen.
  47
  48         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
  49         * MiniBrowser/mac/AppDelegate.h:
  50         * MiniBrowser/mac/AppDelegate.m:
  51         (-[BrowserAppDelegate init]):
  52         (-[BrowserAppDelegate showExtensionsManager:]):
  53         (-[BrowserAppDelegate userContentContoller]):
  54         * MiniBrowser/mac/ExtensionManagerWindowController.h: Added.
  55         * MiniBrowser/mac/ExtensionManagerWindowController.m: Added.
  56         (-[ExtensionManagerWindowController init]):
  57         (-[ExtensionManagerWindowController windowDidLoad]):
  58         (-[ExtensionManagerWindowController add:]):
  59         (-[ExtensionManagerWindowController remove:]):
  60         * MiniBrowser/mac/ExtensionManagerWindowController.xib: Added.
  61         * MiniBrowser/mac/MainMenu.xib:
  62
  63 2015-04-07  Youenn Fablet  <youenn.fablet@crf.canon.fr>
  64
  65         web-platform-tests server should retrieve the modules file relatively to its docroot path
  66         https://bugs.webkit.org/show_bug.cgi?id=142742
  67
  68         Reviewed by Darin Adler.
  69
  70         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
  71         (WebPlatformTestServer._install_modules): Compute the modules description file path according wpt server doc root path.
  72
  73 2015-04-06  Commit Queue  <commit-queue@webkit.org>
  74
  75         Unreviewed, rolling out r182445.
  76         https://bugs.webkit.org/show_bug.cgi?id=143459
  77
  78         broke 32 bit build (Requested by alexchristensen on #webkit).
  79
  80         Reverted changeset:
  81
  82         "Use content extensions in MiniBrowser."
  83         https://bugs.webkit.org/show_bug.cgi?id=143446
  84         http://trac.webkit.org/changeset/182445
  85
  86 2015-04-06  Sam Weinig  <sam@webkit.org>
  87
  88         Use content extensions in MiniBrowser.
  89         https://bugs.webkit.org/show_bug.cgi?id=143446
  90
  91         Reviewed by Alex Christensen.
  92
  93         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
  94         * MiniBrowser/mac/AppDelegate.h:
  95         * MiniBrowser/mac/AppDelegate.m:
  96         (-[BrowserAppDelegate init]):
  97         (-[BrowserAppDelegate showExtensionsManager:]):
  98         (-[BrowserAppDelegate userContentContoller]):
  99         * MiniBrowser/mac/ExtensionManagerWindowController.h: Added.
 100         * MiniBrowser/mac/ExtensionManagerWindowController.m: Added.
 101         (-[ExtensionManagerWindowController init]):
 102         (-[ExtensionManagerWindowController windowDidLoad]):
 103         (-[ExtensionManagerWindowController add:]):
 104         (-[ExtensionManagerWindowController remove:]):
 105         * MiniBrowser/mac/ExtensionManagerWindowController.xib: Added.
 106         * MiniBrowser/mac/MainMenu.xib:
 107
 108 2015-04-06  Michael Catanzaro  <mcatanzaro@gnome.org>
 109
 110         [GTK] install-dependencies should prefer dnf to yum
 111         https://bugs.webkit.org/show_bug.cgi?id=143441
 112
 113         Reviewed by Martin Robinson.
 114
 115         Test for the existance of dnf before yum, and only try to use yum if dnf does not exist.
 116
 117         * gtk/install-dependencies:
 118
 119 2015-04-06  Andy Estes  <aestes@apple.com>
 120
 121         [iOS] 'make clean' fails in Tools/WebKitTestRunner
 122         https://bugs.webkit.org/show_bug.cgi?id=143455
 123
 124         Reviewed by Dan Bernstein.
 125
 126         This Makefile adds '-target WebKitTestRunnerApp' to OTHER_OPTIONS during iOS builds, but the top-level
 127         Makefile.shared adds '-alltargets' for clean builds, and xcodebuild does not allow both -target and -alltargets.
 128
 129         * WebKitTestRunner/Makefile: Don't add '-target WebKitTestRunerApp' to OTHER_OPTIONS on clean builds.
 130
 131 2015-04-06  Alexey Proskuryakov  <ap@apple.com>
 132
 133         WebKit1.SetAndUpdateCacheModelPreferencesChangeMix fails on some machines
 134         https://bugs.webkit.org/show_bug.cgi?id=143450
 135
 136         Reviewed by Anders Carlsson.
 137
 138         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm: (TestWebKitAPI::TEST):
 139         Make sure that the view is actually closed, regardless of anything else that happens beneath.
 140         Also, removed unnecessary get() calls.
 141
 142 2015-04-03  Alexey Proskuryakov  <ap@apple.com>
 143
 144         Reduce the dependency on Flash in regression tests
 145         https://bugs.webkit.org/show_bug.cgi?id=143391
 146
 147         Reviewed by Anders Carlsson.
 148
 149         * WebKitTestRunner/TestController.cpp: (WTR::TestController::decidePolicyForPluginLoad):
 150         Only allow QuickTime and the test plug-in.
 151
 152 2015-04-06  Youenn Fablet  <youenn.fablet@crf.canon.fr>
 153
 154         W3C test importer should generate the modules installed dynamically to run wpt tests
 155         https://bugs.webkit.org/show_bug.cgi?id=142738
 156
 157         Reviewed by Ryosuke Niwa.
 158
 159         The test importer can now generate the submodules description file based on information extracted from the corresponding git repository.
 160         The implementation is done within TestDownloader and it is activated for the WPT repository.
 161         LayoutTests/imported/w3c/resources/WPTModules is renamed as LayoutTests/imported/w3c/resources/web-platform-tests-modules.json for that reason.
 162
 163         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
 164         (WebPlatformTestServer._install_modules): Updated to cope with path as array.
 165         * Scripts/webkitpy/w3c/test_downloader.py:
 166         (TestDownloader._git_submodules_status): Added so that it can be overriden for unit tests.
 167         (TestDownloader):
 168         (TestDownloader._git_submodules_description): Computes submodule description.
 169         (TestDownloader.generate_git_submodules_description): Write submodule description in a file.
 170         * Scripts/webkitpy/w3c/test_importer.py:
 171         (TestImporter.do_import): Added the possibility to post process the tests.
 172         (TestImporter):
 173         (TestImporter.generate_git_submodules_description_for_all_repositories): Enable generating module description file.
 174         (TestImporter.should_convert_test_harness_links): Updated according new options format.
 175         * Scripts/webkitpy/w3c/test_importer_unittest.py:
 176         (TestImporterTest.import_downloaded_tests): Making use of TestDownloaderMock.
 177         (TestImporterTest.import_downloaded_tests.TestDownloaderMock): Added to override submodule status gathering.
 178         (TestImporterTest.import_downloaded_tests.TestDownloaderMock.__init__):
 179         (TestImporterTest.import_downloaded_tests.TestDownloaderMock._git_submodules_status):
 180         (TestImporterTest.test_submodules_generation): Added to check that modules description files works.
 181
 182 2015-04-05  Antti Koivisto  <antti@apple.com>
 183
 184         Bloom filter should support longer hashes
 185         https://bugs.webkit.org/show_bug.cgi?id=143419
 186
 187         Reviewed by Dan Bernstein.
 188
 189         * TestWebKitAPI/Tests/WTF/BloomFilter.cpp:
 190         (TestWebKitAPI::generateRandomDigests):
 191         (TestWebKitAPI::TEST):
 192
 193 2015-04-03  Csaba Osztrogonác  <ossy@webkit.org>
 194
 195         run-jsc-stress-tests --remote should add libllvmForJSC.so to the bundle on Linux
 196         https://bugs.webkit.org/show_bug.cgi?id=143372
 197
 198         Reviewed by Darin Adler.
 199
 200         * Scripts/run-jsc-stress-tests:
 201
 202 2015-04-03  Antti Koivisto  <antti@apple.com>
 203
 204         Add non-counting bloom filter class
 205         https://bugs.webkit.org/show_bug.cgi?id=143366
 206
 207         Reviewed by Sam Weinig.
 208
 209         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 210         * TestWebKitAPI/Tests/WTF/BloomFilter.cpp: Added.
 211         (TestWebKitAPI::generateRandomHashes):
 212         (TestWebKitAPI::TEST):
 213
 214 2015-04-03  Csaba Osztrogonác  <ossy@webkit.org>
 215
 216         FTL JIT tests should fail if LLVM library isn't available
 217         https://bugs.webkit.org/show_bug.cgi?id=143374
 218
 219         Reviewed by Mark Lam.
 220
 221         * Scripts/run-jsc-stress-tests:
 222
 223 2015-04-03  Csaba Osztrogonác  <ossy@webkit.org>
 224
 225         [EFL] Speedup jhbuild with disable running autogen.sh
 226         https://bugs.webkit.org/show_bug.cgi?id=143369
 227
 228         Reviewed by Gyuyoung Kim.
 229
 230         * efl/jhbuild.modules:
 231
 232 2015-04-01  Alexey Proskuryakov  <ap@apple.com>
 233
 234         filter-webkit-build should filter out "created by an unsupported XCDependencyGraph build" lines
 235         https://bugs.webkit.org/show_bug.cgi?id=143282
 236
 237         Reviewed by Daniel Bates.
 238
 239         * Scripts/filter-build-webkit: (shouldIgnoreLine): Do it.
 240
 241 2015-04-01  Alexey Proskuryakov  <ap@apple.com>
 242
 243         When LayoutTestHelper fails to start, we continue to run the tests, ending up with mysterious failures
 244         https://bugs.webkit.org/show_bug.cgi?id=143240
 245         rdar://problem/19990425
 246
 247         Reviewed by Tim Horton.
 248
 249         * DumpRenderTree/mac/LayoutTestHelper.m:
 250         (colorProfileURLForDisplay):
 251         (saveDisplayColorProfiles):
 252         Gracefully handle it when the current profile cannot be retrieved, fixing at
 253         least one case when LayoutTestHelper couldn't start.
 254
 255         * Scripts/webkitpy/layout_tests/controllers/manager.py:
 256         (Manager._set_up_run):
 257         (Manager._force_pixel_tests_if_needed):
 258         * Scripts/webkitpy/port/base.py: (Port.to.start_helper):
 259         * Scripts/webkitpy/port/mac.py: (MacPort.start_helper):
 260         Return and check an error from start_helper().
 261
 262 2015-04-01  Brent Fulgham  <bfulgham@apple.com>
 263
 264         [Win] Run test-webkitpy as part of EWS (just like we do on other platforms)
 265         https://bugs.webkit.org/show_bug.cgi?id=143321
 266
 267         Reviewed by Alexey Proskuryakov.
 268
 269         * EWSTools/start-queue-win.sh: Add commands to run 'test-webkitpy' during processing loop.
 270
 271 2015-04-01  Enrica Casucci  <enrica@apple.com>
 272
 273         Injected bundle messages should be at the page level.
 274         https://bugs.webkit.org/show_bug.cgi?id=143283
 275
 276         Reviewed by Alexey Proskuryakov.
 277
 278         Updating WebKitTestRunner to use the new page level messaging.
 279         The author of this patch is Tim Horton, I just finished it.
 280
 281         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
 282         (WTR::EventSendingController::mouseDown):
 283         (WTR::EventSendingController::mouseUp):
 284         (WTR::EventSendingController::mouseMoveTo):
 285         (WTR::EventSendingController::leapForward):
 286         (WTR::EventSendingController::scheduleAsynchronousClick):
 287         (WTR::EventSendingController::keyDown):
 288         (WTR::EventSendingController::scheduleAsynchronousKeyDown):
 289         (WTR::EventSendingController::mouseScrollBy):
 290         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
 291         (WTR::EventSendingController::continuousMouseScrollBy):
 292         (WTR::EventSendingController::addTouchPoint):
 293         (WTR::EventSendingController::updateTouchPoint):
 294         (WTR::EventSendingController::setTouchModifier):
 295         (WTR::EventSendingController::setTouchPointRadius):
 296         (WTR::EventSendingController::touchStart):
 297         (WTR::EventSendingController::touchMove):
 298         (WTR::EventSendingController::touchEnd):
 299         (WTR::EventSendingController::touchCancel):
 300         (WTR::EventSendingController::clearTouchPoints):
 301         (WTR::EventSendingController::releaseTouchPoint):
 302         (WTR::EventSendingController::cancelTouchPoint):
 303         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
 304         (WTR::InjectedBundle::didReceiveMessage):
 305         (WTR::InjectedBundle::didReceiveMessageToPage):
 306         (WTR::InjectedBundle::done):
 307         (WTR::InjectedBundle::outputText):
 308         (WTR::InjectedBundle::postNewBeforeUnloadReturnValue):
 309         (WTR::InjectedBundle::postAddChromeInputField):
 310         (WTR::InjectedBundle::postRemoveChromeInputField):
 311         (WTR::InjectedBundle::postFocusWebView):
 312         (WTR::InjectedBundle::postSetBackingScaleFactor):
 313         (WTR::InjectedBundle::postSetWindowIsKey):
 314         (WTR::InjectedBundle::postSimulateWebNotificationClick):
 315         (WTR::InjectedBundle::postSetAddsVisitedLinks):
 316         (WTR::InjectedBundle::setGeolocationPermission):
 317         (WTR::InjectedBundle::setMockGeolocationPosition):
 318         (WTR::InjectedBundle::setMockGeolocationPositionUnavailableError):
 319         (WTR::InjectedBundle::setUserMediaPermission):
 320         (WTR::InjectedBundle::setCustomPolicyDelegate):
 321         (WTR::InjectedBundle::setHidden):
 322         (WTR::InjectedBundle::setCacheModel):
 323         (WTR::InjectedBundle::shouldProcessWorkQueue):
 324         (WTR::InjectedBundle::processWorkQueue):
 325         (WTR::InjectedBundle::queueBackNavigation):
 326         (WTR::InjectedBundle::queueForwardNavigation):
 327         (WTR::InjectedBundle::queueLoad):
 328         (WTR::InjectedBundle::queueLoadHTMLString):
 329         (WTR::InjectedBundle::queueReload):
 330         (WTR::InjectedBundle::queueLoadingScript):
 331         (WTR::InjectedBundle::queueNonLoadingScript):
 332         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
 333         (WTR::TestRunner::setHandlesAuthenticationChallenges):
 334         (WTR::TestRunner::setAuthenticationUsername):
 335         (WTR::TestRunner::setAuthenticationPassword):
 336         (WTR::TestRunner::secureEventInputIsEnabled):
 337         (WTR::TestRunner::setBlockAllPlugins):
 338         * WebKitTestRunner/TestController.cpp:
 339         (WTR::TestController::createWebViewWithOptions):
 340         (WTR::TestController::resetStateToConsistentValues):
 341         (WTR::TestController::didReceivePageMessageFromInjectedBundle):
 342         (WTR::TestController::didReceiveSynchronousPageMessageFromInjectedBundle):
 343         * WebKitTestRunner/TestController.h:
 344         * WebKitTestRunner/TestInvocation.cpp:
 345         (WTR::TestInvocation::invoke):
 346         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
 347
 348 2015-04-01  Commit Queue  <commit-queue@webkit.org>
 349
 350         Unreviewed, rolling out r182174 and r182177.
 351         https://bugs.webkit.org/show_bug.cgi?id=143314
 352
 353         Try to correct EWS failures (Requested by bfulgham on
 354         #webkit).
 355
 356         Reverted changesets:
 357
 358         "Python SCM should be able to retrieve untracked files"
 359         https://bugs.webkit.org/show_bug.cgi?id=143135
 360         http://trac.webkit.org/changeset/182174
 361
 362         "[buildbot] clean-build script should remove untracked files
 363         and revert local changes too"
 364         https://bugs.webkit.org/show_bug.cgi?id=142400
 365         http://trac.webkit.org/changeset/182177
 366
 367 2015-04-01  Alex Christensen  <achristensen@webkit.org>
 368
 369         [Content Extensions] Properly handle regexes that match everything.
 370         https://bugs.webkit.org/show_bug.cgi?id=143281
 371
 372         Reviewed by Benjamin Poulain.
 373
 374         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
 375         (TestWebKitAPI::testRequest):
 376         (TestWebKitAPI::makeBackend):
 377         (TestWebKitAPI::TEST_F):
 378         Removed duplicate code and added test.
 379
 380 2015-03-31  Benjamin Poulain  <bpoulain@apple.com>
 381
 382         Content Extensions: split the state machines to minimize prefix states
 383         https://bugs.webkit.org/show_bug.cgi?id=143253
 384
 385         Reviewed by Alex Christensen.
 386
 387         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
 388         (TestWebKitAPI::TEST_F):
 389         (TestWebKitAPI::testPatternStatus):
 390
 391 2015-03-31  Yusuke Suzuki  <utatane.tea@gmail.com>
 392
 393         Clean up Identifier factories to clarify the meaning of StringImpl*
 394         https://bugs.webkit.org/show_bug.cgi?id=143146
 395
 396         Reviewed by Filip Pizlo.
 397
 398         Simple API tests for StringImpl are added.
 399
 400         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
 401         (TestWebKitAPI::TEST):
 402
 403 2015-03-31  Csaba Osztrogonác  <ossy@webkit.org>
 404
 405         [EFL] Add AArch64 builder and tester bot to build.webkit.org
 406         https://bugs.webkit.org/show_bug.cgi?id=143092
 407
 408         Reviewed by Gyuyoung Kim.
 409
 410         * BuildSlaveSupport/build.webkit.org-config/config.json:
 411         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
 412         (Factory.__init__):
 413         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
 414
 415 2015-03-31  Youenn Fablet  <youenn.fablet@crf.canon.fr>
 416
 417         [buildbot] clean-build script should remove untracked files and revert local changes too
 418         https://bugs.webkit.org/show_bug.cgi?id=142400
 419
 420         Reviewed by Ryosuke Niwa.
 421
 422         This patch cleans the WebKit folder by reverting tracked files changes and deleting SCM untracked files, including SCM ignored files.
 423         A helper routine SCM.discard_untracked_files is added for that purpose.
 424
 425         * BuildSlaveSupport/clean-build:
 426         (main): Making call to Scripts/clean-webkit
 427         * Scripts/clean-webkit: Added.
 428         (main): Revert changes and delete untracked files.
 429         * Scripts/webkitpy/common/checkout/scm/scm.py:
 430         (SCM.discard_untracked_files): Helper function to discard untracked files or folders found by SCM.
 431         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
 432         (SCMTest._shared_test_discard_untracked_files):
 433         (test_discard_untracked_files): Tests that untracked file and untracked folder get discarded correctly.
 434
 435 2015-03-31  Youenn Fablet  <youenn.fablet@crf.canon.fr>
 436
 437         Python SCM should be able to retrieve untracked files
 438         https://bugs.webkit.org/show_bug.cgi?id=143135
 439
 440         Reviewed by Ryosuke Niwa.
 441
 442         This patch introduces SCM.untracked_files to retrieve a list of untracked files.
 443         Ignored files may be included or not in this list according boolean passed to the function.
 444
 445         * Scripts/webkitpy/common/checkout/scm/git.py:
 446         (Git.untracked_files):
 447         * Scripts/webkitpy/common/checkout/scm/scm.py:
 448         (SCM.untracked_files):
 449         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
 450         (SCMTest._shared_test_untracked_files):
 451         (test_untracked_files):
 452         (GitSVNTest.test_untracked_files):
 453         * Scripts/webkitpy/common/checkout/scm/svn.py:
 454         (SVN.untracked_files):
 455
 456 2015-03-30  Alex Christensen  <achristensen@webkit.org>
 457
 458         [Content Extensions] Correctly handle regular expressions matching everything
 459         https://bugs.webkit.org/show_bug.cgi?id=143235
 460
 461         Reviewed by Benjamin Poulain.
 462
 463         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
 464         (TestWebKitAPI::checkCompilerError):
 465         (TestWebKitAPI::TEST_F):
 466         Test ContentExtensionErrors.
 467
 468 2015-03-30  Alexey Proskuryakov  <ap@apple.com>
 469
 470         DumpRenderTree should set NSWindowDisplayWithRunLoopObserver
 471         https://bugs.webkit.org/show_bug.cgi?id=143241
 472         rdar://problem/20351297
 473
 474         Reviewed by Mark Lam.
 475
 476         * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
 477
 478 2015-03-30  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
 479
 480         [CMake][EFL] Remove redundant library link and include path
 481         https://bugs.webkit.org/show_bug.cgi?id=143221
 482
 483         Reviewed by Csaba Osztrogonác.
 484
 485         * ImageDiff/PlatformEfl.cmake: Remove unnecessary library link and include path.
 486
 487 2015-03-30  Sam Weinig  <sam@webkit.org>
 488
 489         [Content Extensions] Flesh out the UserContentExtensionStore
 490         https://bugs.webkit.org/show_bug.cgi?id=143123
 491
 492         Reviewed by Benjamin Poulain.
 493
 494         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 495         * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentExtensionStore.mm: Added.
 496         Add tests for _WKUserContentExtensionStore.
 497
 498 2015-03-30  Marcos Chavarría Teijeiro  <chavarria1991@gmail.com>
 499
 500         Update install-dependencies Fedora packages after r181624
 501         https://bugs.webkit.org/show_bug.cgi?id=143215
 502
 503         Add json-glib, libv4l, openssl and pulseaudio development packages to
 504         the Fedora list providing we need them to build WebKit dependencies
 505         for this distribution.
 506
 507         Reviewed by Philippe Normand.
 508
 509         * gtk/install-dependencies:
 510
 511 2015-03-30  Commit Queue  <commit-queue@webkit.org>
 512
 513         Unreviewed, rolling out r182119.
 514         https://bugs.webkit.org/show_bug.cgi?id=143196
 515
 516         problem with syntax (Requested by youenn on #webkit).
 517
 518         Reverted changeset:
 519
 520         "[buildbot] clean-build script should remove untracked files
 521         and revert local changes too"
 522         https://bugs.webkit.org/show_bug.cgi?id=142400
 523         http://trac.webkit.org/changeset/182119
 524
 525 2015-03-30  Benjamin Poulain  <benjamin@webkit.org>
 526
 527         Start the features.json files
 528         https://bugs.webkit.org/show_bug.cgi?id=143207
 529
 530         Reviewed by Darin Adler.
 531
 532         I kept the style checking light. We'll have to figure
 533         what is the best format for each field.
 534
 535         * Scripts/webkitpy/style/checker.py:
 536         (CheckerDispatcher._create_checker):
 537         * Scripts/webkitpy/style/checkers/jsonchecker.py:
 538         (JSONContributorsChecker.check):
 539         (JSONFeaturesChecker):
 540         (JSONFeaturesChecker.check):
 541
 542 2015-03-29  Youenn Fablet  <youenn.fablet@crf.canon.fr>
 543
 544         [buildbot] clean-build script should remove untracked files and revert local changes too
 545         https://bugs.webkit.org/show_bug.cgi?id=142400
 546
 547         Reviewed by Ryosuke Niwa.
 548
 549         This patch cleans the WebKit folder by deleting SCM untracked files and reverting changes for tracked files.
 550
 551         * BuildSlaveSupport/clean-build:
 552         (main): Adding call to Tools/Scripts/clean-webkit.
 553         * Scripts/clean-webkit: Added.
 554         (main): Removes untracked and changed files.
 555         * Scripts/webkitpy/common/checkout/scm/git.py:
 556         (Git.untracked_files): Retrieves GIT untracked files.
 557         * Scripts/webkitpy/common/checkout/scm/scm.py:
 558         (SCM.untracked_files): Retrieves SVN untracked files.
 559         (SCM):
 560         (SCM.discard_untracked_files): Deletes untracked files/folders.
 561         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
 562         (SCMTest._shared_test_untracked_files): Unit testing for untracked files.
 563         (test_untracked_files):
 564         (GitSVNTest.test_untracked_files):
 565         * Scripts/webkitpy/common/checkout/scm/svn.py:
 566         (SVN.untracked_files):
 567
 568 2015-03-27  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
 569
 570         [CMake] Remove unnecessary INCLUDE_IF_EXISTS macro
 571         https://bugs.webkit.org/show_bug.cgi?id=143138
 572
 573         Reviewed by Csaba Osztrogonác.
 574
 575         INCLUDE_IF_EXISTS isn't used except for 2 places. However those uses can
 576         be replaced with WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS.
 577
 578         * ImageDiff/CMakeLists.txt:
 579         Use WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS() instead of INCLUDE_IF_EXISTS.
 580         * WebKitTestRunner/CMakeLists.txt: ditto.
 581
 582 2015-03-27  Myles C. Maxfield  <mmaxfield@apple.com>
 583
 584         Support building WTF on Windows without Cygwin
 585         https://bugs.webkit.org/show_bug.cgi?id=143084
 586
 587         Reviewed by Brent Fulgham.
 588
 589         Windows without Cygwin doesn't have curl, unzip, or grep. Luckily, Perl does all of these things.
 590         This patch also migrates to using File::Spec->catfile() for directory separators.
 591
 592         * Scripts/update-webkit-dependency:
 593         (wanted):
 594         * Scripts/update-webkit-support-libs:
 595         (wanted):
 596         (downloadExpectedVersionNumber):
 597         (zipFileVersion):
 598         (toUnixPath): Deleted.
 599         * Scripts/webkitdirs.pm:
 600         (determineSourceDir):
 601         (windowsSourceSourceDir):
 602         (windowsLibrariesDir):
 603         (windowsOutputDir):
 604         (checkInstalledTools):
 605         (buildVisualStudioProject):
 606
 607 2015-03-27  Alex Christensen  <achristensen@webkit.org>
 608
 609         Fix WinCairo bot.
 610         https://bugs.webkit.org/show_bug.cgi?id=143086
 611
 612         Reviewed by Brent Fulgham.
 613
 614         * Scripts/webkitdirs.pm:
 615         (buildVisualStudioProject):
 616         (runSvnUpdateAndResolveChangeLogs):
 617         Use ActivePerl-friendly perl.
 618
 619 2015-03-27  Csaba Osztrogonác  <ossy@webkit.org>
 620
 621         URTBF after r182059 to fix the EFL build.
 622
 623         * TestWebKitAPI/CMakeLists.txt:
 624
 625 2015-03-26  Alexey Proskuryakov  <ap@apple.com>
 626
 627         Layout test results URL loads in WK1 but not WK2 minibrowser
 628         https://bugs.webkit.org/show_bug.cgi?id=143117
 629
 630         Reviewed by Tim Horton.
 631
 632         * MiniBrowser/mac/WK2BrowserWindowController.m:
 633         (-[WK2BrowserWindowController fetch:]): Fix this, international domain names, and
 634         everything.
 635         (-[WK2BrowserWindowController updateTextFieldFromURL:]): Ditto.
 636
 637 2015-03-26  Jer Noble  <jer.noble@apple.com>
 638
 639         Add --allowed-host support to run-webkit-tests
 640         https://bugs.webkit.org/show_bug.cgi?id=142938
 641
 642         Reviewed by Brent Fulgham.
 643
 644         Accept --allowed-host arguments from run-webkit-tests and pass them through to
 645         DumpRenderTree and WebKitTestRunner.
 646
 647         Drive-by fix: Depending on the value of the --layout-test-dir parameter, layout test results
 648         are placed in the wrong location. The argument is compared with each tests's path, and if a
 649         relative path or a path with '..' was used, results are placed alongside the test. Take the
 650         absolute path of the --layout-test-dir argument, collapsing path components like '..'.
 651
 652         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
 653         (parse_args):
 654         * Scripts/webkitpy/port/base.py:
 655         (Port.__init__):
 656         (Port.allowed_hosts):
 657         * Scripts/webkitpy/port/driver.py:
 658         (Driver.cmd_line):
 659
 660 2015-03-26  Jer Noble  <jer.noble@apple.com>
 661
 662         [Mac] Add an --allowed-host argument to DRT and WKTR to allow tests to connect to non-localhost servers
 663         https://bugs.webkit.org/show_bug.cgi?id=142931
 664
 665         Reviewed by Brent Fulgham.
 666
 667         Currently, both DRT and WKTR will refuse to allow network connections to non-localhost servers
 668         over HTTP/HTTPS. For certain testing scenarios, however, it would be useful if both DRT and
 669         WKTR could be allowed to make HTTP/HTTPS connections to certain, specific servers defined at
 670         runtime.
 671
 672         To allow this, add an optional argument to DRT and WKTR, --allowed-host, which will add the specified
 673         hostname to a whitelist; requests to these hosts will allowed to proceed normally.
 674
 675         Drive-by fix: in InjectedBundlePage::willSendRequestForFrame, we get the top loading frame from the
 676         injected bundle. But after the main resource load completes, the bundle nulls out it's pointer to the
 677         top loading frame, which causes a subsequent crash when further resources are requested. Instead, get
 678         the top loading frame from the page, as we do elsewhere in this class.
 679
 680         * DumpRenderTree/TestRunner.h:
 681         (TestRunner::allowedHosts):
 682         (TestRunner::setAllowedHosts):
 683         * DumpRenderTree/mac/DumpRenderTree.mm:
 684         (initializeGlobalsFromCommandLineOptions):
 685         (runTest):
 686         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
 687         (isAllowedHost):
 688         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
 689         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
 690         (WTR::InjectedBundle::didReceiveMessage):
 691         (WTR::InjectedBundle::isAllowedHost):
 692         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
 693         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
 694         (WTR::isAllowedHost):
 695         (WTR::InjectedBundlePage::willSendRequestForFrame):
 696         * WebKitTestRunner/InjectedBundle/TestRunner.h:
 697         * WebKitTestRunner/Options.cpp:
 698         (WTR::handleOptionAllowedHost):
 699         (WTR::OptionsHandler::OptionsHandler):
 700         * WebKitTestRunner/Options.h:
 701         * WebKitTestRunner/TestController.cpp:
 702         (WTR::TestController::initialize):
 703         (WTR::TestController::resetStateToConsistentValues):
 704         * WebKitTestRunner/TestController.h:
 705
 706 2015-03-26  Brady Eidson  <beidson@apple.com>
 707
 708         Apply ContentExtension actions after redirects.
 709         <rdar://problem/20062613> and https://bugs.webkit.org/show_bug.cgi?id=143055
 710
 711         Reviewed by Alex Christensen.
 712
 713         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
 714         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame): Dump the fact that the load error is kWKErrorCodeCannotShowURL
 715           which is specifically interesting to a new test.
 716
 717 2015-03-26  Csaba Osztrogonác  <ossy@webkit.org>
 718
 719         [EFL] Disable building libseccomp on AArch64
 720         https://bugs.webkit.org/show_bug.cgi?id=143094
 721
 722         Reviewed by Gyuyoung Kim.
 723
 724         * efl/jhbuildrc:
 725
 726 2015-03-26  Csaba Osztrogonác  <ossy@webkit.org>
 727
 728         [jhbuild] git should use only 1 thread for cloning jhbuild
 729         https://bugs.webkit.org/show_bug.cgi?id=143095
 730
 731         Reviewed by Gyuyoung Kim.
 732
 733         * jhbuild/jhbuild-wrapper:
 734         (clone_jhbuild):
 735
 736 2015-03-25  Joseph Pecoraro  <pecoraro@apple.com>
 737
 738         Update prepare-ChangeLog to work with ES6 Class syntax
 739         https://bugs.webkit.org/show_bug.cgi?id=143069
 740
 741         Reviewed by Timothy Hatcher.
 742
 743         * Scripts/prepare-ChangeLog:
 744         (get_function_line_ranges_for_javascript):
 745         Better handle ES6 Class syntax.
 746
 747         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests-expected.txt:
 748         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests.js:
 749         (BaseClass):
 750         (DerivedClass):
 751         (DerivedClass.staticMethod):
 752         (DerivedClass.prototype.method.nestedFunctionInsideMethod):
 753         (DerivedClass.prototype.method):
 754         (DerivedClass.prototype.get getter):
 755         (namespace.MyClass):
 756         (namespace.MyClass.staticMethod):
 757         (namespace.MyClass.prototype.method.nestedFunctionInsideMethod):
 758         (namespace.MyClass.prototype.method):
 759         (namespace.MyClass.prototype.get getter):
 760         Proof!
 761
 762 2015-03-25  Filip Pizlo  <fpizlo@apple.com>
 763
 764         Use JITCompilationCanFail in more places, and make the fail path of JITCompilationMustSucceed a crash instead of attempting GC
 765         https://bugs.webkit.org/show_bug.cgi?id=142993
 766
 767         Reviewed by Mark Lam.
 768
 769         Bunch of support for testing executable allocation failure.
 770
 771         * Scripts/jsc-stress-test-helpers/js-executable-allocation-fuzz: Added.
 772         (fail):
 773         * Scripts/run-javascriptcore-tests:
 774         (runJSCStressTests):
 775         * Scripts/run-jsc-stress-tests:
 776
 777 2015-03-25  Myles C. Maxfield  <mmaxfield@apple.com>
 778
 779         Fix Windows build from r181977.
 780
 781         Unreviewed.
 782
 783         * Scripts/update-webkit-dependency:
 784
 785 2015-03-25  Sam Weinig  <sam@webkit.org>
 786
 787         Address additional review feedback from https://bugs.webkit.org/show_bug.cgi?id=143059.
 788
 789         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
 790         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
 791
 792 2015-03-25  Myles C. Maxfield  <mmaxfield@apple.com>
 793
 794         Migrate update-webkit for Windows to not require Cygwin
 795         https://bugs.webkit.org/show_bug.cgi?id=143040
 796
 797         Reviewed by Brent Fulgham.
 798
 799         * Scripts/update-webkit-dependency:
 800         (wanted):
 801         (toUnixPath): Deleted.
 802         * Scripts/webkitdirs.pm:
 803         (fontExists):
 804         (checkInstalledTools):
 805         (setupAppleWinEnv):
 806
 807 2015-03-25  Sam Weinig  <sam@webkit.org>
 808
 809         [Content Extensions] Convert content extension compiling to return error codes and write its output using a client
 810         https://bugs.webkit.org/show_bug.cgi?id=143059
 811
 812         Reviewed by Alex Christensen.
 813
 814         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
 815         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
 816         Update for new interface of compileRuleList().
 817
 818 2015-03-25  Alex Christensen  <achristensen@webkit.org>
 819
 820         [Content Extensions] Add multi-DFA compiling and interpreting.
 821         https://bugs.webkit.org/show_bug.cgi?id=143010
 822
 823         Reviewed by Benjamin Poulain.
 824
 825         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
 826         (TestWebKitAPI::testRequest):
 827         (TestWebKitAPI::TEST_F):
 828         Add some tests for ignore-previous-rules and large rulesets.
 829
 830 2015-03-25  Alexey Proskuryakov  <ap@apple.com>
 831
 832         Mavericks WK1 still runs JSC tests
 833         https://bugs.webkit.org/show_bug.cgi?id=143035
 834
 835         Reviewed by Csaba Osztrogonác.
 836
 837         * BuildSlaveSupport/build.webkit.org-config/config.json: Bring Mavericks WK1 in line
 838         with other bots.
 839
 840         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Updated the tests
 841         accordingly.
 842
 843 2015-03-25  Commit Queue  <commit-queue@webkit.org>
 844
 845         Unreviewed, rolling out r181932.
 846         https://bugs.webkit.org/show_bug.cgi?id=143041
 847
 848         The test fails most of the time on bots (Requested by ap on
 849         #webkit).
 850
 851         Reverted changeset:
 852
 853         "[Content Extensions] Add multi-DFA compiling and
 854         interpreting."
 855         https://bugs.webkit.org/show_bug.cgi?id=143010
 856         http://trac.webkit.org/changeset/181932
 857
 858 2015-03-24  Alex Christensen  <achristensen@webkit.org>
 859
 860         [Content Extensions] Add multi-DFA compiling and interpreting.
 861         https://bugs.webkit.org/show_bug.cgi?id=143010
 862
 863         Reviewed by Benjamin Poulain.
 864
 865         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
 866         (TestWebKitAPI::testRequest):
 867         (TestWebKitAPI::TEST_F):
 868         Add some tests for ignore-previous-rules and large rulesets.
 869
 870 2015-03-24  Benjamin Poulain  <bpoulain@apple.com>
 871
 872         Make URL filter patterns matching consistent and add a simple canonicalization step
 873         https://bugs.webkit.org/show_bug.cgi?id=142998
 874
 875         Reviewed by Alex Christensen.
 876
 877         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
 878
 879 2015-03-24  Csaba Osztrogonác  <ossy@webkit.org>
 880
 881         [EFL] Add OpenWebRTC in jhbuild
 882         https://bugs.webkit.org/show_bug.cgi?id=142778
 883
 884         Reviewed by Gyuyoung Kim.
 885
 886         Original patch by Philippe Normand <pnormand@igalia.com>
 887
 888         * efl/install-dependencies: Dependencies for OpenWebRTC.
 889         * efl/jhbuild.modules: build OpenWebRTC, libusrsctp, libnice and
 890         the openwebrtc gst plugins.
 891
 892 2015-03-23  Brent Fulgham  <bfulgham@apple.com>
 893
 894         Regression(r181257): WTF_WorkQueue.Simple is flaky
 895         https://bugs.webkit.org/show_bug.cgi?id=142560
 896
 897         Remove the check that the refCount has returned to one after the
 898         individual tasks have completed. It's too nondeterministic when
 899         the reference count will be reduced.
 900
 901         Reviewed by Alexey Proskuryakov
 902
 903         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
 904         (TestWebKitAPI::TEST): Remove test that refCount is back to 1.
 905
 906 2015-03-23  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
 907
 908         [CMake][EFL] Put failure API test excutables into failure directory
 909         https://bugs.webkit.org/show_bug.cgi?id=142965
 910
 911         Reviewed by Csaba Osztrogonác.
 912
 913         Move failing WK2 API test executables to *bin/TestWebKitAPI/WebKit2/failure* directory.
 914
 915         * TestWebKitAPI/CMakeLists.txt: Fix a typo. Change *testBaseName* with *testName*.
 916         * TestWebKitAPI/PlatformEfl.cmake: Additionally remove unnecessary SHARED_CORE and comment for SeccompFilters test.
 917
 918 2015-03-22  Benjamin Poulain  <benjamin@webkit.org>
 919
 920         CSS Selectors: fix attribute case-insensitive matching of Contain and List
 921         https://bugs.webkit.org/show_bug.cgi?id=142932
 922
 923         Reviewed by Darin Adler.
 924
 925         Add tests for the new features and fix some existing tests using the
 926         stringFromUTF8() utility recently added by Dhi.
 927
 928         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
 929         (TestWebKitAPI::stringFromUTF8):
 930         * TestWebKitAPI/Tests/WTF/StringView.cpp:
 931
 932 2015-03-22  Michael Catanzaro  <mcatanzaro@igalia.com>
 933
 934         [GTK] install-dependencies should install orc
 935         https://bugs.webkit.org/show_bug.cgi?id=142955
 936
 937         Reviewed by Martin Robinson.
 938
 939         Install orc, needed by openwebrtc
 940
 941         * gtk/install-dependencies:
 942
 943 2015-03-22  Benjamin Poulain  <bpoulain@apple.com>
 944
 945         Detect when url filter pattern with groups match the empty string
 946         https://bugs.webkit.org/show_bug.cgi?id=142930
 947
 948         Reviewed by Sam Weinig.
 949
 950         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
 951
 952 2015-03-22  Anders Carlsson  <andersca@apple.com>
 953
 954         _WKWebsiteDataStore should clear WebSQL databases
 955         https://bugs.webkit.org/show_bug.cgi?id=142947
 956
 957         Reviewed by Sam Weinig.
 958
 959         Add a variable that keeps track of the types of data we want to operate on, for easier debugging.
 960
 961         * MiniBrowser/mac/WK2BrowserWindowController.m:
 962         (-[WK2BrowserWindowController fetchWebsiteData:]):
 963         (-[WK2BrowserWindowController fetchAndClearWebsiteData:]):
 964         (-[WK2BrowserWindowController clearWebsiteData:]):
 965
 966 2015-03-20  Mark Hahnenberg  <mhahnenb@gmail.com>
 967
 968         GCTimer should know keep track of nested GC phases
 969         https://bugs.webkit.org/show_bug.cgi?id=142675
 970
 971         Reviewed by Darin Adler.
 972
 973         Adds a tool to aid in parsing the GC phase timing output into a
 974         tree-like structure based on the parent-child relationships
 975         of nested GC phases.
 976
 977         * Scripts/parse-gc-phase-timings: Added.
 978         (Timing):
 979         (Timing.__init__):
 980         (Timing.__unicode__):
 981         (Timing.__str__):
 982         (Timing.__repr__):
 983         (parse_input):
 984         (print_timing_node):
 985         (print_timing_tree):
 986         (link_parents):
 987         (main):
 988
 989 2015-03-20  Brent Fulgham  <bfulgham@apple.com>
 990
 991         [Win] Temporarily turn of EWS Windows tests while I debug the test failure.
 992
 993         * Scripts/webkitpy/common/config/ews.json:
 994
 995 2015-03-20  Philippe Normand  <pnormand@igalia.com>
 996
 997         [GTK][jhbuild] Fix flakey failures due to unstable googlecode repository
 998         https://bugs.webkit.org/show_bug.cgi?id=142867
 999
1000         Rubber-stamped by Csaba Osztrogon.
1001
1002         * gtk/jhbuild.modules: Use Ossy's libusrsctp Github fork. Also use
1003         a fixed revision for the openwebrtc-gst-plugins.
1004
1005 2015-03-19  Ryosuke Niwa  <rniwa@webkit.org>
1006
1007         Unreviewed build fix. Don't try to report stats for all benchmarks.
1008         Just report the geometric mean of preferred means.
1009
1010         * Scripts/run-jsc-benchmarks:
1011
1012 2015-03-19  Ryosuke Niwa  <rniwa@webkit.org>
1013
1014         run-jsc-benchmarks should only report preferred mean
1015         https://bugs.webkit.org/show_bug.cgi?id=142874
1016
1017         Reviewed by Geoffrey Garen.
1018
1019         Just collect statistics for the preferred mean.
1020
1021         * Scripts/run-jsc-benchmarks:
1022
1023 2015-03-19  Alex Christensen  <achristensen@webkit.org>
1024
1025         [Content Extensions] Test regular expression parse failures.
1026         https://bugs.webkit.org/show_bug.cgi?id=142872
1027
1028         Reviewed by Benjamin Poulain.
1029
1030         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1031         (TestWebKitAPI::testPatternStatus):
1032         (TestWebKitAPI::TEST_F):
1033         Added tests for each parsing status.
1034
1035 2015-03-19  Alex Christensen  <achristensen@webkit.org>
1036
1037         Fix API tests after r181754.
1038
1039         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1040         (TestWebKitAPI::testRequest):
1041
1042 2015-03-19  Brady Eidson  <beidson@apple.com>
1043
1044         Part of content extensions should apply css selectors
1045         https://bugs.webkit.org/show_bug.cgi?id=142604
1046
1047         Reviewed by Alex Christensen.
1048
1049         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1050         (WebCore::ContentExtensions::operator<<):
1051
1052 2015-03-19  Brent Fulgham  <bfulgham@apple.com>
1053
1054         [Win] Activate tests on EWS
1055         https://bugs.webkit.org/show_bug.cgi?id=142850
1056
1057         Reviewed by Alexey Proskuryakov.
1058
1059         * Scripts/webkitpy/common/config/ews.json: Add me as
1060         the EWS bot watcher, and activate tests.
1061
1062 2015-03-19  Csaba Osztrogonác  <ossy@webkit.org>
1063
1064         [GTK] Fix inspector userinterface related incremental build issue
1065         https://bugs.webkit.org/show_bug.cgi?id=142849
1066
1067         Reviewed by Carlos Garcia Campos.
1068
1069         * Scripts/webkitdirs.pm:
1070         (shouldRemoveCMakeCache):
1071
1072 2015-03-18  Alex Christensen  <achristensen@webkit.org>
1073
1074         [ContentExtensions] Prepare for compiling stylesheets of selectors to be used on every page.
1075         https://bugs.webkit.org/show_bug.cgi?id=142799
1076
1077         Reviewed by Brady Eidson.
1078
1079         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1080         (TestWebKitAPI::testPattern):
1081         (TestWebKitAPI::TEST_F):
1082         Start testing regex failures.
1083
1084 2015-03-18  Dhi Aurrahman  <diorahman@rockybars.com>
1085
1086         Fix StringView typos after r181525 and r181558
1087         https://bugs.webkit.org/show_bug.cgi?id=142772
1088
1089         Reviewed by Darin Adler.
1090
1091         Add some tests in [1] to cover the StringView::startsWith,
1092         StringView::startsWithIgnoringASCIICase, StringView::endsWith and
1093         StringView::endsWithIgnoringASCIICase implementations.
1094
1095         * TestWebKitAPI/Tests/WTF/StringView.cpp:
1096         (TestWebKitAPI::TEST):
1097
1098 2015-03-18  Dana Burkart  <dburkart@apple.com>
1099
1100         Remove extraneous import to fix the build.
1101
1102         Unreviewed.
1103
1104         * Scripts/webkitpy/port/driver.py:
1105
1106 2015-03-18  Dana Burkart  <dburkart@apple.com>
1107
1108         ASAN_OPTIONS=allocator_may_return_null=1 needs to be set
1109         https://bugs.webkit.org/show_bug.cgi?id=142547
1110
1111         Reviewed by Alexey Proskuryakov.
1112
1113         * Scripts/webkitpy/port/driver.py:
1114         (Driver._setup_environ_for_driver):
1115
1116 2015-03-18  Alexey Proskuryakov  <ap@apple.com>
1117
1118         Tweak how AppleSystemFontOSSubversion default is added
1119         https://bugs.webkit.org/show_bug.cgi?id=142835
1120
1121         Reviewed by Dan Bernstein.
1122
1123         * DumpRenderTree/mac/DumpRenderTree.mm:
1124         (setDefaultsToConsistentValuesForTesting):
1125
1126 2015-03-18  Dan Bernstein  <mitz@apple.com>
1127
1128         prepare-ChangeLog doesn't understand C string literals split across multiple lines with \
1129         https://bugs.webkit.org/show_bug.cgi?id=142815
1130
1131         Reviewed by Darin Adler.
1132
1133         * Scripts/prepare-ChangeLog:
1134         (get_function_line_ranges_for_cpp): If the line ends with a backslash instead of a matching
1135         quotation mark, use new variable $quotation_mark to remember what we are looking for, and
1136         keep consuming the quoted text until the matching quotation mark is reached. Emit the
1137         warning only if a line ends without a backslash before the matching quotation mark was found.
1138
1139 2015-03-18  Joseph Pecoraro  <pecoraro@apple.com>
1140
1141         Remove unused "preprocessor" parameter to sub-CodeGenerators
1142         https://bugs.webkit.org/show_bug.cgi?id=142793
1143
1144         Reviewed by Darin Adler.
1145
1146         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
1147         (new):
1148
1149 2015-03-18  Csaba Osztrogonác  <ossy@webkit.org>
1150
1151         [EFL] Bump gstreamer version to 1.4.4
1152         https://bugs.webkit.org/show_bug.cgi?id=142782
1153
1154         Reviewed by Philippe Normand.
1155
1156         * efl/jhbuild.modules:
1157         * efl/patches/gst-libav.patch:
1158         * efl/patches/gst-plugins-bad-remove-gnustep-support.patch: Added.
1159         * efl/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch: Removed.
1160
1161 2015-03-17  Tim Horton  <timothy_horton@apple.com>
1162
1163         Fix the iOS build.
1164
1165         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
1166         (WTR::InjectedBundle::platformInitialize):
1167
1168 2015-03-17  Dean Jackson  <dino@apple.com>
1169
1170         check-webkit-style should allow "bool a : 1"
1171         https://bugs.webkit.org/show_bug.cgi?id=142794
1172
1173         Reviewed by Brent Fulgham.
1174
1175         We should allow member bitfields of the form:
1176
1177         bool m_var : 1;
1178
1179         It seems that Visual Studio 8 was the last compiler that
1180         wasn't happy about not using unsigned here. We already have
1181         about 500 cases (in WebCore) where people were ignoring this rule.
1182
1183         * Scripts/webkitpy/style/checkers/cpp.py:
1184         (check_language): Allow "bool".
1185         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add tests.
1186         (CppStyleTest.test_enum_bitfields):
1187         (CppStyleTest.test_plain_integral_bitfields):
1188
1189 2015-03-17  Benjamin Poulain  <bpoulain@apple.com>
1190
1191         Compile character ranges targeting the same state as range check in the bytecode
1192         https://bugs.webkit.org/show_bug.cgi?id=142759
1193
1194         Reviewed by Alex Christensen.
1195
1196         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1197         (TestWebKitAPI::TEST_F):
1198
1199 2015-03-17  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1200
1201         W3C test parser and converter should use test importer host
1202         https://bugs.webkit.org/show_bug.cgi?id=142729
1203
1204         Reviewed by Bem Jones-Bey.
1205
1206         When instantiated by TestImporter, TestParser and TestConverter are now using the same host.
1207         This enables adding more TestImporter unit testing.
1208         This patch also ensures that the git object instantiated by TestDownloader is using the
1209         same Executive and FileSystem object as TestDownloader, again to enable TestImporter/TestDownloader unit testing.
1210
1211         * Scripts/webkitpy/common/system/filesystem_mock.py:
1212         (MockFileSystem.copytree): Fixes implementation as it creates a runtime error.
1213         * Scripts/webkitpy/w3c/test_downloader.py:
1214         (TestDownloader.git): Set the executive of the git object to the one of TestDownloader. Refactoring in a new git function for future reuse.
1215         (TestDownloader.checkout_test_repository): Making use of the new git function.
1216         * Scripts/webkitpy/w3c/test_importer.py:
1217         (TestImporter.find_importable_tests): Adding host as parameter to the parser.
1218         (TestImporter.import_tests): Adding host as parameter to the converter.
1219         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1220         (TestImporterTest.create_test_download_importer): Creating a test downloader mock, to be reused by other tests.
1221         (TestImporterTest):
1222         (TestImporterTest.test_harnesslinks_conversion): Adding test to check that test harness links are converted for CSS tests but not WPT tests.
1223         * Scripts/webkitpy/w3c/test_parser.py:
1224         (TestParser.__init__): Adding host as parameter constructor.
1225
1226 2015-03-17  Carlos Garcia Campos  <cgarcia@igalia.com>
1227
1228         [GTK] WebKitDOM objects leaking
1229         https://bugs.webkit.org/show_bug.cgi?id=118788
1230
1231         Reviewed by Darin Adler and Sergio Villar Senin.
1232
1233         Update DOMObjectCache unit test to check that DOM objects are also
1234         released when new contents are loaded in the web view, and the old
1235         document is detached from the frame.
1236
1237         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
1238         (testWebKitDOMObjectCache):
1239         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
1240         (runTest):
1241
1242 2015-03-17  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1243
1244         W3C test importer default import folder should be LayoutTests/imported/w3c
1245         https://bugs.webkit.org/show_bug.cgi?id=142728
1246
1247         Reviewed by Bem Jones-Bey.
1248
1249         * Scripts/webkitpy/w3c/test_importer.py:
1250         (parse_args): Updating the default destination option value to 'imported/w3c'.
1251
1252 2015-03-17  Philippe Normand  <pnormand@igalia.com>
1253
1254         [GTK] basic OpenWebRTC build support
1255         https://bugs.webkit.org/show_bug.cgi?id=142393
1256
1257         Reviewed by Carlos Garcia Campos.
1258
1259         * gtk/jhbuild.modules: Add OpenWebRTC and its dependencies. This
1260         is not the upstream OpenWebRTC repository. This temporary fork
1261         contains a few patches needed by WebKit for audio/video rendering.
1262
1263 2015-03-17  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1264
1265         [CMake][EFL] Build test tools only for developer mode
1266         https://bugs.webkit.org/show_bug.cgi?id=142761
1267
1268         Reviewed by Csaba Osztrogonác.
1269
1270         Do not build EFL MiniBrowser, WebKitTestRunner, and ImageDiff on production mode.
1271
1272         * CMakeLists.txt:
1273
1274 2015-03-17  Joseph Pecoraro  <pecoraro@apple.com>
1275
1276         Remove never used "useLayerOnTop" bindings generator argument
1277         https://bugs.webkit.org/show_bug.cgi?id=142773
1278
1279         Reviewed by Darin Adler.
1280
1281         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
1282         (new):
1283
1284 2015-03-16  Ryosuke Niwa  <rniwa@webkit.org>
1285
1286         Enable ES6 classes by default
1287         https://bugs.webkit.org/show_bug.cgi?id=142774
1288
1289         Reviewed by Gavin Barraclough.
1290
1291         * Scripts/webkitperl/FeatureList.pm:
1292
1293 2015-03-16  Alexey Proskuryakov  <ap@apple.com>
1294
1295         Fix webkitpy tests after r181585.
1296
1297         Looks like "me" cannot be anyone's email, it's a special case.
1298
1299         * Scripts/webkitpy/common/config/contributors.json:
1300
1301 2015-03-16  Alexey Proskuryakov  <ap@apple.com>
1302
1303         Add tolerance to WebAudio tests
1304         https://bugs.webkit.org/show_bug.cgi?id=142676
1305
1306         Reviewed by Tim Horton.
1307
1308         * Scripts/webkitpy/common/wavediff.py: Added. Based on Jer Noble's work.
1309
1310         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1311         (TestResultWriter.create_audio_diff_and_write_result):
1312         * Scripts/webkitpy/layout_tests/models/test_failures.py:
1313         (FailureAudio.write_failure):
1314         * Scripts/webkitpy/port/base.py:
1315         (Port.do_audio_results_differ):
1316         Diff audio failures.
1317
1318         * Scripts/webkitpy/port/test.py: Added a test for the tolerance, fixed existing
1319         tests to use real parseable WAV data, and got rid of base64, which there didn't
1320         seem to have been any reason for.
1321
1322 2015-03-16  Alexey Proskuryakov  <ap@apple.com>
1323
1324         [Mac] fast/forms/text-control-intrinsic-widths.html fails when MS Office is installed
1325         https://bugs.webkit.org/show_bug.cgi?id=142720
1326
1327         Reviewed by Myles C. Maxfield.
1328
1329         Activate system copies of Microsoft fonts for the current process, thus overriding
1330         any other ones that could be preferred by the system otherwise.
1331
1332         * DumpRenderTree/mac/DumpRenderTree.mm:
1333         (activateSystemCoreWebFonts):
1334         (adjustFonts):
1335         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
1336         (WTR::activateSystemCoreWebFonts):
1337         (WTR::activateFonts):
1338
1339 2015-03-16  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1340
1341         Created Streams API watchlist
1342         https://bugs.webkit.org/show_bug.cgi?id=142684
1343
1344         Reviewed by Benjamin Poulain.
1345
1346         * Scripts/webkitpy/common/config/watchlist: Created StreamsAPI
1347         watchlist and added Benjamin, Youenn and me to it.
1348
1349 2015-03-15  Benjamin Poulain  <benjamin@webkit.org>
1350
1351         CSS: fix the case-insensitive matching of the attribute selectors Begin, End and Hyphen
1352         https://bugs.webkit.org/show_bug.cgi?id=142715
1353
1354         Reviewed by Brent Fulgham.
1355
1356         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1357         (TestWebKitAPI::TEST):
1358
1359 2015-03-15  Benjamin Poulain  <bpoulain@apple.com>
1360
1361         Change the exact attribute matching to be ASCII case-insensitive
1362         https://bugs.webkit.org/show_bug.cgi?id=142609
1363
1364         Reviewed by Darin Adler.
1365
1366         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1367         * TestWebKitAPI/Tests/WTF/StringView.cpp:
1368
1369 2015-03-13  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1370
1371         WebKit test infrastructure should automate the process of cloning W3C test suite and importing tests from it
1372         https://bugs.webkit.org/show_bug.cgi?id=134764
1373
1374         Reviewed by Ryosuke Niwa.
1375
1376         TestDownloader is introduced to download W3C tests from the official
1377         W3C tests repositories (https://github.com/w3c/web-platform-tests.git
1378         and https://github.com/w3c/csswg-test.git).
1379         TestDownloader clones the repositories and checkouts revisions of the tests
1380         defined in LayoutTests/imported/w3c/resources/TestRepositories.
1381
1382         Similarly to https://codereview.chromium.org/148173016,
1383         TestDownloader copies part of the files based on the rules
1384         defined in LayoutTests/imported/w3c/resources/ImportExpectations.
1385
1386         TestDownloader is used by TestImporter when no source directory is provided.
1387
1388         * Scripts/webkitpy/w3c/test_downloader.py: Added.
1389         (TestDownloader):
1390         (TestDownloader.default_options):
1391         (TestDownloader.load_test_repositories):
1392         (TestDownloader.__init__):
1393         (TestDownloader.checkout_test_repository):
1394         (TestDownloader._init_paths_from_expectations):
1395         (TestDownloader._add_test_suite_paths):
1396         (TestDownloader._empty_directory):
1397         (TestDownloader.copy_tests):
1398         (TestDownloader.download_tests):
1399         * Scripts/webkitpy/w3c/test_importer.py:
1400         (main):
1401         (parse_args):
1402         (TestImporter.__init__):
1403         (TestImporter.do_import):
1404         (TestImporter.test_downloader):
1405         (TestImporter.find_importable_tests.should_keep_subdir):
1406         (TestImporter.should_convert_test_harness_links):
1407         (TestImporter.import_tests):
1408         (TestImporter.write_import_log):
1409
1410 2015-03-12  Alexey Proskuryakov  <ap@apple.com>
1411
1412         [Mavericks] Test snapshots are 1600x1200 on Retina devices
1413         https://bugs.webkit.org/show_bug.cgi?id=142630
1414
1415         Reviewed by Tim Horton.
1416
1417         * WebKitTestRunner/mac/PlatformWebViewMac.mm: (WTR::PlatformWebView::windowSnapshotImage):
1418         Removed an ifdef that disabled the fix on Mavericks.
1419
1420 2015-03-12  Csaba Osztrogonác  <ossy@webkit.org>
1421
1422         Remove isWK2 cruft from webkitdirs.pm after r170426
1423         https://bugs.webkit.org/show_bug.cgi?id=142618
1424
1425         Reviewed by Daniel Bates.
1426
1427         * Scripts/webkitdirs.pm:
1428         (isWK2): Deleted.
1429
1430 2015-03-12  Alexey Proskuryakov  <ap@apple.com>
1431
1432         testRunner.setAlwaysAcceptCookies does not work with NetworkProcess
1433         https://bugs.webkit.org/show_bug.cgi?id=138687
1434
1435         Reviewed by Carlos Garcia Campos.
1436
1437         Always change cookie policy from UI process, as changing it from WebProcess doesn't
1438         affect other processes.
1439
1440         The implementation is imperfect, because the change happens asynchronously, but I
1441         don't expect it to be a problem in practice.
1442
1443         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1444         (WTR::InjectedBundle::beginTesting):
1445         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1446         (WTR::TestRunner::setAlwaysAcceptCookies):
1447         * WebKitTestRunner/TestInvocation.cpp:
1448         (WTR::TestInvocation::invoke):
1449         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1450
1451 2015-03-12  Csaba Osztrogonác  <ossy@webkit.org>
1452
1453         [EFL] Enable building EFL 1.13 with NEON support
1454         https://bugs.webkit.org/show_bug.cgi?id=142619
1455
1456         Reviewed by Gyuyoung Kim.
1457
1458         * efl/jhbuild.modules:
1459
1460 2015-03-11  Alex Christensen  <achristensen@webkit.org>
1461
1462         [Content Extensions] Add resource type and load type triggers.
1463         https://bugs.webkit.org/show_bug.cgi?id=142422
1464
1465         Reviewed by Benjamin Poulain.
1466
1467         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1468         (TestWebKitAPI::testRequest):
1469         (TestWebKitAPI::mainDocumentRequest):
1470         (TestWebKitAPI::TEST_F):
1471         (TestWebKitAPI::testURL): Deleted.
1472
1473 2015-03-10  Sam Weinig  <sam@webkit.org>
1474
1475         Allow adding a button in input elements for auto fill related functionality
1476         <rdar://problem/19782066>
1477         https://bugs.webkit.org/show_bug.cgi?id=142564
1478
1479         Reviewed by Anders Carlsson.
1480
1481         * WebKitTestRunner/TestController.cpp:
1482         (WTR::TestController::createOtherPage):
1483         (WTR::TestController::createWebViewWithOptions):
1484         Update for new callback.
1485
1486 2015-03-11  Benjamin Poulain  <bpoulain@apple.com>
1487
1488         Add basic support for BOL and EOL assertions to the URL Filter parser
1489         https://bugs.webkit.org/show_bug.cgi?id=142568
1490
1491         Reviewed by Alex Christensen.
1492
1493         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1494         (TestWebKitAPI::TEST_F):
1495
1496 2015-03-11  Carlos Garcia Campos  <cgarcia@igalia.com>
1497
1498         [GTK] Add support for handling TLS errors to MiniBrowser
1499         https://bugs.webkit.org/show_bug.cgi?id=142576
1500
1501         Reviewed by Sergio Villar Senin.
1502
1503         It's useful for testing TLS errors handling itself, but also to
1504         allow ignoring TLS errors when testing.
1505
1506         * MiniBrowser/gtk/BrowserWindow.c:
1507         (webViewLoadFailedWithTLSerrors):
1508         (browserWindowConstructed):
1509
1510 2015-03-11  Myles C. Maxfield  <mmaxfield@apple.com>
1511
1512         Use out-of-band messaging for RenderBox::firstLineBaseline() and RenderBox::inlineBlockBaseline()
1513         https://bugs.webkit.org/show_bug.cgi?id=142569
1514
1515         Reviewed by David Hyatt.
1516
1517         Test Optional::valueOrCompute().
1518
1519         * TestWebKitAPI/Tests/WTF/Optional.cpp:
1520         (TestWebKitAPI::TEST):
1521
1522 2015-03-11  Carlos Garcia Campos  <cgarcia@igalia.com>
1523
1524         [GTK] Add an option to enable MiniBrowser for non developer builds and always install it
1525         https://bugs.webkit.org/show_bug.cgi?id=126688
1526
1527         Reviewed by Gustavo Noronha Silva.
1528
1529         * CMakeLists.txt: Build testing tools only for developer builds,
1530         but MiniBrowser when ENABLE_MINIBROWSER option is ON.
1531         * MiniBrowser/gtk/CMakeLists.txt: Only add
1532         -DWEBKIT_INJECTED_BUNDLE_PATH to the build for developer builds,
1533         and add a rule to install the MiniBrowser.
1534         * MiniBrowser/gtk/main.c:
1535         (main): Only set WEBKIT_INJECTED_BUNDLE_PATH env var for developer
1536         builds.
1537
1538 2015-03-11  Brent Fulgham  <bfulgham@apple.com>
1539
1540         Add some DateMath tests to TestWebKitAPI
1541         https://bugs.webkit.org/show_bug.cgi?id=142565
1542
1543         Reviewed by Alexey Proskuryakov.
1544
1545         * TestWebKitAPI/CMakeLists.txt: Add new DateMath.cpp file.
1546         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Ditto.
1547         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters: Ditto.
1548         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto."
1549         * TestWebKitAPI/Tests/WTF/DateMath.cpp: Added.
1550
1551 2015-03-10  Brent Fulgham  <bfulgham@apple.com>
1552
1553         Regression(r181257): WTF_WorkQueue.Simple is flaky
1554         https://bugs.webkit.org/show_bug.cgi?id=142560
1555
1556         Unreviewed attempt to improve test stability.
1557
1558         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp: Check the reference count for
1559         the WorkQueue a little later to redue flakiness.
1560
1561 2015-03-10  Myles C. Maxfield  <mmaxfield@apple.com>
1562
1563         Migrate from SystemUIFontSelect to AppleSystemFontOSSubversion
1564         https://bugs.webkit.org/show_bug.cgi?id=142555
1565
1566         Reviewed by Simon Fraser.
1567
1568         * DumpRenderTree/mac/DumpRenderTree.mm:
1569         (setDefaultsToConsistentValuesForTesting):
1570         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
1571         (WTR::InjectedBundle::platformInitialize):
1572
1573 2015-03-10  Alex Christensen  <achristensen@webkit.org>
1574
1575         Use unsigned for HashSet size.
1576         https://bugs.webkit.org/show_bug.cgi?id=142518
1577
1578         Reviewed by Benjamin Poulain.
1579
1580         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
1581         (TestWebKitAPI::TEST):
1582         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
1583         (TestWebKitAPI::testInitialCapacity):
1584         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
1585         (TestWebKitAPI::TEST):
1586
1587 2015-03-10  Daniel Bates  <dabates@apple.com>
1588
1589         [iOS] Add WebKitSystemInterface for iOS 8.2
1590         https://bugs.webkit.org/show_bug.cgi?id=142505
1591
1592         Rubber-stamped by Anders Carlsson.
1593
1594         Make copy-webkitlibraries-to-product-directory install libWebKitSystemInterfaceIOS{Device, Simulator}8.2.a.
1595         I inadvertently forgot to add libWebKitSystemInterfaceIOS{Device, Simulator}8.2.a to script
1596         copy-webkitlibraries-to-product-directory in r181286.
1597
1598         * Scripts/copy-webkitlibraries-to-product-directory:
1599
1600 2015-03-10  Benjamin Poulain  <bpoulain@apple.com>
1601
1602         Extend URL filter's Term definition to support groups/subpatterns
1603         https://bugs.webkit.org/show_bug.cgi?id=142519
1604
1605         Reviewed by Alex Christensen.
1606
1607         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1608         (TestWebKitAPI::testURL):
1609
1610 2015-03-06  Jer Noble  <jer.noble@apple.com>
1611
1612         Add an option to run-webkit-tests to override the LayoutTests/ directory
1613         https://bugs.webkit.org/show_bug.cgi?id=142418
1614
1615         Reviewed by David Kilzer.
1616
1617         Add an arugment to run-webkit-tests which, when set, overrides the port's default LayoutTests
1618         directory. The base port will parse the options during initialization and store the override
1619         location if present. layout_tests_dir() will return this overridden location if set.
1620
1621         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1622         (parse_args):
1623         * Scripts/webkitpy/port/base.py:
1624         (Port.__init__):
1625         (Port.layout_tests_dir):
1626
1627 2015-03-09  Martin Robinson  <mrobinson@igalia.com>
1628
1629         [CMake] Enable WorkQueue tests for CMake ports
1630         https://bugs.webkit.org/show_bug.cgi?id=142473
1631
1632         Reviewed by Darin Adler.
1633
1634         * TestWebKitAPI/CMakeLists.txt: Add the WorkQueue tests source file to
1635         the list of source files.
1636         * Tools/TestWebKitAPI/PlatformEfl.cmake: Add the DispatchQueueEfl directory
1637         to the list of include directories for EFL.
1638
1639 2015-03-09  David Kilzer  <ddkilzer@apple.com>
1640
1641         Attempt to fix timeouts on iOS Simulator layout tests
1642
1643         * Scripts/webkitpy/port/ios.py:
1644         (IOSSimulatorPort.setup_test_run): Most layout test runs on iOS
1645         Simulator end after the first 50 tests time out.  Some analysis
1646         this past weekend shows that the 'Booted' status in the output
1647         of `xcrun simctl list` is not sufficient (and watching the test
1648         run shows that SpringBoard hasn't fully started to the point
1649         where it's displaying icons on the home screen).  The workaround
1650         until we have a better fix is to add an arbitrary timeout to let
1651         SpringBoard finish launching.  In practice, 15 seconds is
1652         probably enough, but 30 seconds should nearly always work.
1653
1654 2015-03-09  Per Arne Vollan  <peavo@outlook.com>
1655
1656         Unreviewed. Add myself as a committer.
1657
1658         * Scripts/webkitpy/common/config/contributors.json:
1659
1660 2015-03-09  David Kilzer  <ddkilzer@apple.com>
1661
1662         Attempt to fix WTF_WorkQueue.TwoQueues timeout test failure
1663
1664         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
1665         (TestWebKitAPI::TEST): Change delay from 50ns to 50ms, and add
1666         an expectation that will fail if we hit the race condition.
1667         This test is inherently racy and will deadlock if the first job
1668         for queue2 takes the mutex lock before the second job for
1669         queue1.
1670
1671 2015-03-08  Brent Fulgham  <bfulgham@apple.com>
1672
1673         [Win] WTF::WorkQueue does not balance ref/deref properly
1674         https://bugs.webkit.org/show_bug.cgi?id=142471
1675
1676         Reviewed by Antti Koivisto.
1677
1678         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
1679         (TestWebKitAPI::TEST): Check that the refcount is correct.
1680
1681 2015-03-08  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1682
1683         Do not show passing test result on output of EFL layout test
1684         https://bugs.webkit.org/show_bug.cgi?id=142380
1685
1686         Reviewed by Darin Adler.
1687
1688         To show passing tests has caused inconvenience when we detect problem tests
1689         in output of layout test. So this patch applies '--debug-rwt-logging' except for EFL port
1690         in order not to show passing tests in the output of EFL layout test.
1691
1692         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1693         (RunWebKitTests.start):
1694
1695 2015-03-08  Brent Fulgham  <bfulgham@apple.com>
1696
1697         Unreviewed build fix.
1698
1699         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
1700         (TestWebKitAPI::TEST): Remove two unused variables.
1701
1702 2015-03-08  Brent Fulgham  <bfulgham@apple.com>
1703
1704         Add some WorkQueue tests to TestWebKitAPI
1705         https://bugs.webkit.org/show_bug.cgi?id=142447
1706
1707         Reviewed by Sam Weinig.
1708
1709         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1710         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
1711         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1712         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp: Added.
1713         (TestWebKitAPI::simpleTest):
1714         (TestWebKitAPI::longTest):
1715         (TestWebKitAPI::thirdTest):
1716         (TestWebKitAPI::finishedTests):
1717         (TestWebKitAPI::TEST):
1718         (TestWebKitAPI::longTest2):
1719
1720 2015-03-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1721
1722         Remove willDestroyFrame in WKBundlePageLoaderClient
1723         https://bugs.webkit.org/show_bug.cgi?id=142389
1724
1725         Reviewed by Anders Carlsson.
1726
1727         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1728         (WTR::InjectedBundlePage::InjectedBundlePage):
1729
1730 2015-03-07  Brent Fulgham  <bfulgham@apple.com>
1731
1732         [Win] Increase TestWebKitAPI Test Coverage[Win] Increase TestWebKitAPI Test Coverage
1733         https://bugs.webkit.org/show_bug.cgi?id=142433
1734
1735         Reviewed by Darin Adler.
1736
1737         Include more TestWebKitAPI tests when building for Windows. Also
1738         fix a build error in MetaAllocator.cpp caused by one of the
1739         Microsoft headers #defining 'small'.
1740
1741         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1742         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
1743         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
1744
1745 2015-03-06  Sam Weinig  <sam@webkit.org>
1746
1747         [Content Extensions] Move compiling of content extensions to the UIProcess
1748         https://bugs.webkit.org/show_bug.cgi?id=142402
1749
1750         Reviewed by Benjamin Poulain.
1751
1752         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1753         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp: Copied from Tools/TestWebKitAPI/Tests/WebCore/ContentFilter.cpp.
1754         (TestWebKitAPI::InMemoryCompiledContentExtension::create):
1755         (TestWebKitAPI::InMemoryCompiledContentExtension::~InMemoryCompiledContentExtension):
1756         (TestWebKitAPI::InMemoryCompiledContentExtension::InMemoryCompiledContentExtension):
1757         (TestWebKitAPI::TEST_F):
1758         * TestWebKitAPI/Tests/WebCore/ContentFilter.cpp: Removed.
1759         Update test for new name (ContentFilter -> ContentExtensions) and API (CompiledContentExtension
1760         is now abstract).
1761
1762 2015-03-06  Brent Fulgham  <bfulgham@apple.com>
1763
1764         [Win] Correct Windows build.
1765
1766         Rubberstamped by Michael Saboff
1767
1768         * win/AssembleBuildLogs/AssembleLogs.cmd: Correct cut/paste error
1769         in the GOTO labels.
1770
1771 2015-03-06  Carlos Garcia Campos  <cgarcia@igalia.com>
1772
1773         [GTK] Test /webkit2/WebKitWebView/sync-request-on-max-conns might fail after finished
1774         https://bugs.webkit.org/show_bug.cgi?id=142385
1775
1776         Reviewed by Sergio Villar Senin.
1777
1778         Use stack allocated GMainLoopSources to make sure they are
1779         cancelled automatically if the test finishes before they have
1780         been processed.
1781
1782         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
1783         (testWebViewSyncRequestOnMaxConns):
1784
1785 2015-03-06  Csaba Osztrogonác  <ossy@webkit.org>
1786
1787         Remove Mountain Lion libraries since ML isn't supported
1788         https://bugs.webkit.org/show_bug.cgi?id=142332
1789
1790         Reviewed by Darin Adler.
1791
1792         * Scripts/copy-webkitlibraries-to-product-directory:
1793
1794 2015-03-06  Carlos Alberto Lopez Perez <clopez@igalia.com> and Youenn Fablet  <youenn.fablet@crf.canon.fr>
1795
1796         Layout tests imported/w3c/web-platform-tests certificates should not be tracked on WebKit VCS
1797         https://bugs.webkit.org/show_bug.cgi?id=142083
1798
1799         Reviewed by Simon Fraser.
1800
1801         Modifying on the fly wpt config.json to set the directory where to generate/read certificates as a subfolder of the layout test results folder.
1802
1803         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1804         (WebPlatformTestServer._copy_webkit_test_files):
1805
1806 2015-03-06  Csaba Osztrogonác  <ossy@webkit.org>
1807
1808         setup-git-clone fails due to the failure to download python-irclib-0.4.8
1809         https://bugs.webkit.org/show_bug.cgi?id=141946
1810
1811         Reviewed by Ryosuke Niwa.
1812
1813         Check in ircbot.py and irclib.py to avoid network problems in the future.
1814
1815         * Scripts/webkitpy/common/net/irc/ircbot.py:
1816         * Scripts/webkitpy/thirdparty/__init__.py:
1817         (AutoinstallImportHook.find_module):
1818         (AutoinstallImportHook._install_irc): Deleted.
1819         * Scripts/webkitpy/thirdparty/__init___unittest.py:
1820         (ThirdpartyTest.test_imports):
1821         * Scripts/webkitpy/thirdparty/irc/__init__.py: Added.
1822         * Scripts/webkitpy/thirdparty/irc/ircbot.py: Added.
1823         * Scripts/webkitpy/thirdparty/irc/irclib.py: Added.
1824
1825 2015-03-06  David Kilzer  <ddkilzer@apple.com>
1826
1827         Dashboard: Perf bot status is missing for Apple {Mavericks,Yosemite} Release builds
1828
1829         See also fix to config.json in r181097.
1830
1831         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1832         (WebKitBuildbot): Add missing "WK2" to the names of the perf
1833         bots.
1834
1835 2015-03-06  Csaba Osztrogonác  <ossy@webkit.org>
1836
1837         run-jsc-stress-tests should determine the architecture from ELF binaries
1838         https://bugs.webkit.org/show_bug.cgi?id=142335
1839
1840         Reviewed by Darin Adler.
1841
1842         * Scripts/run-jsc-stress-tests:
1843
1844 2015-03-05  David Kilzer  <ddkilzer@apple.com>
1845
1846         [iOS] TestExpectations for ios-simulator-wk2 should fall back to 'wk2' after 'ios-simulator'
1847         <http://webkit.org/b/142226>
1848
1849         Reviewed by Darin Adler.
1850
1851         * Scripts/webkitpy/port/ios.py:
1852         (IOSSimulatorPort.default_baseline_search_path): Switch the
1853         TestExpectations order of ios-simulator-wk2 from this:
1854           ios-simulator-wk2, wk2, ios-simulator
1855         To this:
1856           ios-simulator-wk2, ios-simualtor, wk2
1857
1858 2015-03-05  Brent Fulgham  <bfulgham@apple.com>
1859
1860         [Win] Provide tiered logging from MSBuild -- Errors on top, Warnings after
1861         https://bugs.webkit.org/show_bug.cgi?id=142370
1862
1863         Reviewed by Dean Jackson.
1864
1865         * Scripts/webkitdirs.pm:
1866         (buildVisualStudioProject): Tell MSBuild to output log files to two separate
1867         logs, one for warnings, the other for errors.
1868         * win/AssembleBuildLogs/AssembleLogs.cmd: Combine the error and warning logs
1869         into the standard BuildOutput.htm document.
1870
1871 2015-03-05  David Kilzer  <ddkilzer@apple.com>
1872
1873         Dashboard has trouble parsing iOS test output
1874         <http://webkit.org/b/142364>
1875
1876         Reviewed by Alex Christensen.
1877
1878         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
1879         (BuildbotTestResults.prototype._parseResults.resultSummarizer):
1880         Add fallback path to build a regex using 'matchString' so that
1881         it matches anywhere in the line.  In practice, 'matchString' is
1882         a prefix for the label following the number.
1883
1884 2015-03-05  Alex Christensen  <achristensen@webkit.org>
1885
1886         Fix linker warnings in TestWebKitAPI.
1887         https://bugs.webkit.org/show_bug.cgi?id=141912
1888
1889         Reviewed by David Kilzer.
1890
1891         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
1892         Do not export TearDownTestCase or SetUpTestCase symbols.
1893
1894 2015-03-05  Brent Fulgham  <bfulgham@apple.com>
1895
1896         [Win] Unreviewed EWS fix.
1897
1898         * Scripts/webkitdirs.pm:
1899         (buildVisualStudioProject): Dial logging back to 'ErrorsOnly' to see if that makes
1900         the EWS output more usable.
1901
1902 2015-03-05  Chris Dumez  <cdumez@apple.com>
1903
1904         Regression(r173761): ASSERTION FAILED: !is8Bit() in StringImpl::characters16()
1905         https://bugs.webkit.org/show_bug.cgi?id=142350
1906
1907         Reviewed by Michael Saboff and Benjamin Poulain.
1908
1909         Add API test for WTFString::hasInfixStartingAt() to make sure it doesn't
1910         crash if the string is 8-bit but the pattern is 16-bit (and vice-versa).
1911
1912         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
1913         (TestWebKitAPI::TEST):
1914
1915 2015-03-05  Brent Fulgham  <bfulgham@apple.com>
1916
1917         [Win] Ensure build target directory exists when launching MSBuild
1918         https://bugs.webkit.org/show_bug.cgi?id=142360
1919
1920         Reviewed by Dean Jackson.
1921
1922         Create the build output directory (if it doesn't exist) before
1923         launching MSBuild so that it can immediately begin writing logs.
1924
1925         * Scripts/webkitdirs.pm:
1926         (buildVisualStudioProject):
1927
1928 2015-03-05  Chris Dumez  <cdumez@apple.com>
1929
1930         run-webkit-tests and run-perf-tests should use WebKitTestRunner by default
1931         https://bugs.webkit.org/show_bug.cgi?id=142325
1932
1933         Reviewed by Csaba Osztrogonác.
1934
1935         run-webkit-tests and run-perf-tests now use WebKitTestRunner by default.
1936         As a result, "--webkit-test-runner / -2" parameters are replaced by
1937         "--dump-render-tree / -1" so developers can run DumpRenderTree rather
1938         than WebKitTestRunner.
1939
1940         * BuildSlaveSupport/build.webkit.org-config/config.json:
1941         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1942         (RunWebKit1Tests):
1943         (RunWebKit1Tests.start):
1944         (RunWebKit1LeakTests):
1945         (RunWebKit1LeakTests.start):
1946         (RunAndUploadPerfTestsWebKit1):
1947         (RunAndUploadPerfTestsWebKit1.start):
1948         (TestFactory):
1949         (TestWebKit1LeaksFactory):
1950         (TestWebKit1LeaksFactory.__init__):
1951         (TestWebKit1Factory):
1952         (TestWebKit1AllButJSCFactory):
1953         (TestAllButJSCFactory):
1954         (BuildAndPerfTestWebKit1Factory):
1955         (BuildAndPerfTestWebKit1Factory.__init__):
1956         (BuildAndPerfTestFactory):
1957         (BuildAndPerfTestFactory.__init__):
1958         (DownloadAndPerfTestWebKit1Factory):
1959         (DownloadAndPerfTestWebKit1Factory.__init__):
1960         (DownloadAndPerfTestFactory):
1961         (DownloadAndPerfTestFactory.__init__):
1962         (RunWebKitLeakTests): Deleted.
1963         (RunWebKitLeakTests.start): Deleted.
1964         (RunWebKit2Tests): Deleted.
1965         (RunWebKit2Tests.start): Deleted.
1966         (RunAndUploadPerfTestsWebKit2): Deleted.
1967         (RunAndUploadPerfTestsWebKit2.start): Deleted.
1968         (TestLeaksFactory): Deleted.
1969         (TestLeaksFactory.__init__): Deleted.
1970         (TestWebKit2Factory): Deleted.
1971         (TestWebKit2AndJSCFactory): Deleted.
1972         (BuildAndPerfTestWebKit2Factory): Deleted.
1973         (BuildAndPerfTestWebKit2Factory.__init__): Deleted.
1974         (DownloadAndPerfTestWebKit2Factory): Deleted.
1975         (DownloadAndPerfTestWebKit2Factory.__init__): Deleted.
1976         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1977         (parse_args):
1978         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1979         (PerfTestsRunner._parse_args):
1980         * Scripts/webkitpy/port/port_testcase.py:
1981         (PortTestCase.test_build_driver):
1982
1983 2015-03-05  Brent Fulgham  <bfulgham@apple.com>
1984
1985         [Win] Switch to MSBuild so we get more useful stdout logging in buildbot
1986         https://bugs.webkit.org/show_bug.cgi?id=140845
1987
1988         Reviewed by David Kilzer.
1989
1990         Update 'webkitdirs.pm' to locate the MSBuild used with Visual Studio 2013
1991         and generate suitable build commands to drive a full build from our
1992         existing solution files.
1993
1994         * Scripts/webkitdirs.pm:
1995         (msBuildInstallDir): Added.
1996         (determineConfigurationForVisualStudio): Revise to use MSBuild command
1997         line arguments to drive the build.
1998         (setupCygwinEnv): Warn user if MSBuild cannot be located.
1999         (buildVisualStudioProject): Revise to use MSBuild command line arguments
2000         to specify build architecture.
2001         * win/AssembleBuildLogs/AssembleLogs.cmd: MSBuild doesn't produce individual
2002         output logs, so don't attempt to consolidate them. Also: Drive-by fix: Don't
2003         bother looking for CoreUI or SafariTheme build logs.
2004
2005 2015-03-05  Csaba Osztrogonác  <ossy@webkit.org>
2006
2007         [buildbot] mastercfg_unittest.py should be runnable easily
2008         https://bugs.webkit.org/show_bug.cgi?id=142219
2009
2010         Reviewed by Chris Dumez.
2011
2012         Buildbot 0.8.6p1 runs on build.webkit org with Twisted 12.1.0, which is
2013         the last Twisted version works together with this buildbot version.
2014
2015         * Scripts/webkitpy/common/system/autoinstall.py:
2016         (AutoInstaller): Added prepend_to_search_path argument to be able
2017         to prefer autoinstalled package to system package.
2018         (AutoInstaller.__init__):
2019         (AutoInstaller._set_up_target_dir):
2020         (AutoInstaller._extract_tar): Renamed from _extract_targz, now it works with tar.bz2 too.
2021         (AutoInstaller._prepare_package):
2022         (AutoInstaller._extract_targz): Renamed to _extract_tar.
2023         * Scripts/webkitpy/thirdparty/__init__.py:
2024         (AutoinstallImportHook._install_buildbot): Autoinstall Twisted 12.1.0.
2025
2026 2015-03-05  Lukasz Bialek  <l.bialek@samsung.com>
2027
2028         [EFL][WK2] Crash when "Download Linked File" from MiniBrowser context menu is clicked
2029         https://bugs.webkit.org/show_bug.cgi?id=131162
2030
2031         Reviewed by Gyuyoung Kim.
2032
2033         * MiniBrowser/efl/main.c:
2034         (on_download_request):
2035         (on_download_finished):
2036         (on_download_failed):
2037         (window_create):
2038         Adapt download callbacks to new callback mechanism
2039
2040 2015-03-05  Carlos Garcia Campos  <cgarcia@igalia.com>
2041
2042         Unreviewed. Fix /webkit2/WebKitWebResource/mime-type after r180927.
2043
2044         In r180927 we updated the libsoup version used by the jhbuild. In
2045         this new version the sniffer uses image/x-icon instead of
2046         image/vnd.microsoft.icon for blank.ico resource.
2047
2048         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
2049         (testWebResourceMimeType):
2050
2051 2015-03-05  Carlos Garcia Campos  <cgarcia@igalia.com>
2052
2053         [SOUP] Check TLS errors as soon as they are set in the SoupMessage
2054         https://bugs.webkit.org/show_bug.cgi?id=142244
2055
2056         Reviewed by Sergio Villar Senin.
2057
2058         Check that the SSL server doesn't process any request in case of
2059         TLS errors when the policy is set to FAIL.
2060
2061         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
2062         (testTLSErrorsPolicy):
2063         (testTLSErrorsRedirect):
2064         (testTLSErrorsHTTPAuth):
2065         (testLoadFailedWithTLSErrors):
2066         (testSubresourceLoadFailedWithTLSErrors):
2067         (httpsServerCallback):
2068
2069 2015-03-05  Pawel Forysiuk  <p.forysiuk@samsung.com>
2070
2071         [EFL] REGRESSION (r178685): ASSERTION FAILED: !parameters.mediaKeyStorageDirectory.isEmpty()
2072         https://bugs.webkit.org/show_bug.cgi?id=141154
2073
2074         Reviewed by Jer Noble.
2075
2076         Unlike GTK, EFL port enables ENABLE_ENCRYPTED_MEDIA_V2 build option by default.
2077
2078         For the sake of completeness WebKitTestRunner should specify temporary
2079         folder for MediaKeysStorageDirecory as well as IndexedDB, LocalStorage, etc.
2080
2081         Default non legacy paths are set up in ProcessPoolConfiguration constructor.
2082         They use WebsiteDataStore::websiteDataDirectoryFileSystemRepresentation
2083         to get data storage paths. Only Mac port has an actual implementation of it.
2084         However, WebKitTestRunner overrides them in favour of unique temporary dir
2085         which is taken from libraryPathForTesting().
2086
2087         Since WebsiteDataStore::websiteDataDirectoryFileSystemRepresentation
2088         is not implemented for EFL and GTK ports it returns an empty string.
2089         All default data folders besides MediaKeys are overridden in TestRunner
2090         code with unique temporary folders derived from DUMPRENDERTREE_TEMP
2091         env variable.
2092
2093         GTK port does not enable encrypted keys by default so
2094         WebMediaKeyStorageManager::initialize() code path is never triggered.
2095
2096         * WebKitTestRunner/TestController.cpp:
2097         (WTR::TestController::initialize): Set MediaKeysStorageDirectory for all
2098         WebKit ports.
2099
2100 2015-03-05  Csaba Osztrogonác  <ossy@webkit.org>
2101
2102         [buildbot] Add regression test to check which builder runs which tests
2103         https://bugs.webkit.org/show_bug.cgi?id=142166
2104
2105         Reviewed by Alexey Proskuryakov.
2106
2107         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2108         (BuildStepsConstructorTest.createTest):
2109         (BuildStepsTest):
2110         (BuildStepsTest.generateTests):
2111         (BuildStepsTest.createTest):
2112         (BuildStepsTest.createTest.doTest):
2113         (BuildStepsTest.test_unnecessary_expected_results):
2114
2115 2015-03-04  Commit Queue  <commit-queue@webkit.org>
2116
2117         Unreviewed, rolling out r181054.
2118         https://bugs.webkit.org/show_bug.cgi?id=142320
2119
2120         Broke the api tests (Requested by sundiamonde on #webkit).
2121
2122         Reverted changeset:
2123
2124         "Fix linker warnings in TestWebKitAPI."
2125         https://bugs.webkit.org/show_bug.cgi?id=141912
2126         http://trac.webkit.org/changeset/181054
2127
2128 2015-03-04  Alex Christensen  <achristensen@webkit.org>
2129
2130         Fix linker warnings in TestWebKitAPI.
2131         https://bugs.webkit.org/show_bug.cgi?id=141912
2132
2133         Reviewed by David Kilzer.
2134
2135         * TestWebKitAPI/Configurations/Base.xcconfig:
2136         Use GCC_SYMBOLS_PRIVATE_EXTERN like we do in WebCore.
2137
2138 2015-03-04  Alexey Proskuryakov  <ap@apple.com>
2139
2140         [Mac] Set SystemUIFontSelect in DRT and WKTR
2141         https://bugs.webkit.org/show_bug.cgi?id=142303
2142
2143         Reviewed by Myles C. Maxfield.
2144
2145         * DumpRenderTree/mac/DumpRenderTree.mm:
2146         (setDefaultsToConsistentValuesForTesting):
2147         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2148         (WTR::InjectedBundle::platformInitialize):
2149
2150 2015-03-04  Chris Dumez  <cdumez@apple.com>
2151
2152         Mac Perf bots should use WebKitTestRunner instead of DumpRenderTree
2153         https://bugs.webkit.org/show_bug.cgi?id=142314
2154         <rdar://problem/20046835>
2155
2156         Reviewed by Ryosuke Niwa.
2157
2158         Mac Perf bots should use WebKitTestRunner instead of DumpRenderTree
2159         to get WK2 code coverage.
2160
2161         * BuildSlaveSupport/build.webkit.org-config/config.json:
2162
2163 2015-03-04  Alex Christensen  <achristensen@webkit.org>
2164
2165         Move content extensions test to properly named directory.
2166         https://bugs.webkit.org/show_bug.cgi?id=142299
2167
2168         Reviewed by Tim Horton.
2169
2170         * WebKitTestRunner/mac/TestControllerMac.mm:
2171         (WTR::TestController::platformConfigureViewForTest):
2172
2173 2015-03-04  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2174
2175         W3C test importer should use filesystem instead of os.walk
2176         https://bugs.webkit.org/show_bug.cgi?id=142085
2177
2178         Reviewed by Bem Jones-Bey.
2179
2180         Added FileSystem.dirs_under to remove the use of os.walk in test importer.
2181         Added MockFileSystem.dirs_under and MockFileSystem.getsize to enable unit testing of test importer.
2182         Added unit test for FileSystem.dirs_under and MockFileSystem.dirs_under.
2183
2184         Made use of FileSystem.dirs_under within TestImporter.find_importable_tests.
2185         Added a unit test to check that test importer is now black-box testable using a Mock system.
2186
2187         * Scripts/webkitpy/common/system/filesystem.py:
2188         (FileSystem.dirs_under): Returns a list of filtered sub-directories.
2189         (FileSystem.dirs_under.filter_all):
2190         * Scripts/webkitpy/common/system/filesystem_mock.py:
2191         (MockFileSystem.dirs_under):
2192         (MockFileSystem.dirs_under.filter_all):
2193         (MockFileSystem.getsize):
2194         * Scripts/webkitpy/common/system/filesystem_mock_unittest.py:
2195         (MockFileSystemTest.test_dirs_under):
2196         (MockFileSystemTest.test_dirs_under.filter_dir):
2197         * Scripts/webkitpy/common/system/filesystem_unittest.py:
2198         (RealFileSystemTest.test_sep):
2199         (RealFileSystemTest):
2200         (RealFileSystemTest.test_dirs_under):
2201         (RealFileSystemTest.test_dirs_under.filter_this_dir):
2202         * Scripts/webkitpy/w3c/test_importer.py:
2203         (TestImporter.do_import):
2204         (TestImporter.find_importable_tests.should_keep_subdir):
2205         (TestImporter.find_importable_tests):
2206         (TestImporter.should_keep_subdir): Deleted.
2207         (TestImporter.should_skip_file): Deleted.
2208         * Scripts/webkitpy/w3c/test_importer_unittest.py:
2209         (TestImporterTest.test_import_dir_with_empty_init_py): Added test to ensure empty __init__.py are no longer empty once imported.
2210
2211 2015-03-04  Timothy Horton  <timothy_horton@apple.com>
2212
2213         [WebEditingTester] Add support for the find and replace bar
2214         https://bugs.webkit.org/show_bug.cgi?id=142247
2215
2216         Reviewed by Enrica Casucci.
2217
2218         While it's not hooked up yet in WKWebView, adding support for the
2219         find bar to WebEditingTester will help us implement that functionality.
2220
2221         * WebEditingTester/AppDelegate.h:
2222         * WebEditingTester/AppDelegate.m:
2223         (-[WebEditingAppDelegate performTextFinderAction:]):
2224         * WebEditingTester/MainMenu.xib:
2225         Receive performTextFinderAction: and forward it to the frontmost WebDocumentController.
2226
2227         * WebEditingTester/WK2WebDocumentController.m:
2228         (-[WK2WebDocumentController awakeFromNib]):
2229         (-[WK2WebDocumentController performTextFinderAction:]):
2230         (-[WK2WebDocumentController findBarView]):
2231         (-[WK2WebDocumentController setFindBarView:]):
2232         (-[WK2WebDocumentController isFindBarVisible]):
2233         (-[WK2WebDocumentController setFindBarVisible:]):
2234         (-[WK2WebDocumentController findBarViewDidChangeHeight]):
2235         (-[WK2WebDocumentController layout]):
2236         Implement performTextFinderAction: for WebKit2, and have a NSTextFinder
2237         pointing at the WKWebView (currently nothing will work, but the bar will
2238         show up). Install and uninstall the bar as needed.
2239
2240         * WebEditingTester/WebDocument.xib:
2241         Don't use a full-size content view. There's no need, and it makes find
2242         bar layout harder.
2243
2244         * WebEditingTester/WebDocumentController.h:
2245         * WebEditingTester/WebDocumentController.m:
2246         (-[WebDocumentController performTextFinderAction:]):
2247
2248 2015-03-03  Sam Weinig  <sam@webkit.org>
2249
2250         [Content Extensions] Split parsing and compiling of content extensions into their own files
2251         https://bugs.webkit.org/show_bug.cgi?id=142259
2252
2253         Reviewed by Anders Carlsson.
2254
2255         Add basic unit test for the content filter compiler.
2256
2257         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2258         * TestWebKitAPI/Tests/WebCore/ContentFilter.cpp: Added.
2259         (WebCore::ContentExtensions::operator<<):
2260         (TestWebKitAPI::ContentFilterTest::SetUp):
2261         (TestWebKitAPI::TEST_F):
2262
2263 2015-03-04  Matthew Mirman  <mmirman@apple.com>
2264
2265         Cleaned up BuildAndTestFactory to not be a near duplicate of TestFactory
2266         https://bugs.webkit.org/show_bug.cgi?id=142230
2267
2268         Reviewed by Csaba Osztrogonác.
2269
2270         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2271         (TestFactory):
2272         (TestFactory.getProduct): Added
2273         (TestFactory.__init__): moved downloader to getProduct
2274         (BuildAndTestFactory):
2275         (BuildAndTestFactory.getProduct): Added
2276         (BuildAndTestFactory.__init__): made to call TestFactory.__init__ and append steps to the end.
2277         (BuildAndTestWebKit2Factory): Deleted.  Wasn't used anywhere.
2278
2279 2015-03-04  Debarshi Ray  <debarshir@gnome.org>
2280
2281         [GTK] WebView should hold a reference on WebContext because non-default contexts are a reality
2282         https://bugs.webkit.org/show_bug.cgi?id=142225
2283
2284         Reviewed by Carlos Garcia Campos.
2285
2286         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2287         (testWebViewWebContextLifetime):
2288         (beforeAll):
2289
2290 2015-03-03  David Kilzer  <ddkilzer@apple.com>
2291
2292         [iOS] Crash logs can't be found on ios-simulator because WebKitTestRunner returns the wrong process name
2293         <http://webkit.org/b/142243>
2294
2295         Reviewed by Alexey Proskuryakov.
2296
2297         * WebKitTestRunner/TestController.cpp:
2298         (WTR::TestController::webProcessName):
2299         (WTR::TestController::networkProcessName):
2300         - Return the same process name on iOS and Mac because they both
2301           use the same process name for local engineering builds.
2302
2303 2015-03-03  David Kilzer  <ddkilzer@apple.com>
2304
2305         check-webkit-style: Add exception for FrameworkSoftLink.h header order
2306         <http://webkit.org/b/141872>
2307
2308         Reviewed by Alex Christensen.
2309
2310         * Scripts/webkitpy/style/checkers/cpp.py: Remove unneeded
2311         semi-colons in various places and fix whitespace.
2312         (_IncludeState): Add _SOFT_LINK_HEADER and _SOFT_LINK_SECTION
2313         constants.
2314         (_IncludeState.__init__): Add self._visited_soft_link_section
2315         boolean state variable.
2316         (_IncludeState.visited_soft_link_section): Getter for
2317         self._visited_soft_link_section.
2318         (_IncludeState.check_next_include_order): Update state machine
2319         for soft-link headers.  Add check that soft-link headers always
2320         appear last.
2321         (_classify_include): Add check for soft-link header type.
2322         (check_include_line): Return early if there is a soft-link
2323         header error.
2324
2325         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2326         (OrderOfIncludesTest.test_public_primary_header): Add tests for
2327         including soft-link headers.
2328         (OrderOfIncludesTest.test_classify_include): Add test for
2329         _SOFT_LINK_HEADER type.
2330
2331 2015-03-03  Alexey Proskuryakov  <ap@apple.com>
2332
2333         build.webkit.org/dashboard: Don't repeatedly handle each test type
2334         https://bugs.webkit.org/show_bug.cgi?id=142211
2335
2336         Reviewed by Tim Horton and Matt Hanson.
2337
2338         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
2339         (Buildbot.prototype.javascriptTestResultsURLForIteration): Deleted.
2340         (Buildbot.prototype.apiTestResultsURLForIteration): Deleted.
2341         (Buildbot.prototype.platformAPITestResultsURLForIteration): Deleted.
2342         (Buildbot.prototype.webkitpyTestResultsURLForIteration): Deleted.
2343         (Buildbot.prototype.webkitperlTestResultsURLForIteration): Deleted.
2344         (Buildbot.prototype.bindingsTestResultsURLForIteration): Deleted.
2345         Removed functions that build a link to test step results. The buildbot provides
2346         these links in JSON.
2347
2348         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2349         (BuildbotIteration): Put failing tests into an array, instead of named variables.
2350         (BuildbotIteration.ProductiveSteps): Removed step names that are not used on build.webkit.org.
2351         We can easily add them to the map as needed.
2352         (BuildbotIteration.TestSteps): Added a list of test steps to be displayed by test queues.
2353         (BuildbotIteration.prototype._parseData): Moved code for parsing step results away
2354         to BuildbotTestResults class. We used to parse here, build an intermediate data structure,
2355         and then build a BuildbotTestResults object, which was strange.
2356         (BuildbotIteration.prototype.loadLayoutTestResults): Ditto.
2357
2358         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2359         Corrected an unrelated assertion that was buggy, and kept firing.
2360
2361         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
2362         (BuildbotTestResults):
2363         (BuildbotTestResults.prototype._parseResults.resultSummarizer):
2364         (BuildbotTestResults.prototype._parseResults):
2365         (BuildbotTestResults.prototype.addFullLayoutTestResults):
2366         Moved the code for parsing JSON results for a single step here.
2367
2368         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2369         (BuildbotTesterQueueView.prototype._testStepFailureDescription):
2370         (BuildbotTesterQueueView.prototype._testStepFailureDescriptionWithCount):
2371         (BuildbotTesterQueueView.prototype._presentPopoverForGenericTestFailures):
2372         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): Deleted.
2373         (BuildbotTesterQueueView.prototype.update): Deleted.
2374         (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds): Deleted.
2375         Updated for the new data structures. One behavior change is that we now display individual
2376         counts when multiple test kinds fail, e.g. "1 javascript test failure, 83+ layout
2377         test failures, 3 platform api test failures".
2378
2379 2015-03-03  Matthew Mirman  <mmirman@apple.com>
2380
2381         JSC tests should not be repeated twice for each branch builder, and should if possible have their own queue.
2382         https://bugs.webkit.org/show_bug.cgi?id=142094
2383
2384         Reviewed by Csaba Osztrogonác.
2385
2386         * BuildSlaveSupport/build.webkit.org-config/config.json: Added bots 155 and 157
2387         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2388         (TestFactory):
2389         (TestFactory.__init__): Made running of JSC tests conditional.
2390         (TestAllButJSCFactory):
2391         (TestJSCFactory): Added.
2392         (TestJSCFactory.__init__):
2393         (TestWebKit2AndJSCFactory): Added factory to not run JSC tests on WebKit2.
2394
2395 2015-03-03  David Kilzer  <ddkilzer@apple.com>
2396
2397         `build-webkit --help` is wrong about how to build for the iOS simulator
2398         <http://webkit.org/b/142223>
2399
2400         Reviewed by Csaba Osztrogonác.
2401
2402         * Scripts/build-webkit: Fix help.
2403
2404 2015-03-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2405
2406         Unreviewed. Bump libsoup version to 2.49.91.1 to fix 32 bit build.
2407
2408         * gtk/jhbuild.modules:
2409
2410 2015-03-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2411
2412         [SOUP] Synchronous XMLHttpRequests can time out when we reach the max connections limit
2413         https://bugs.webkit.org/show_bug.cgi?id=141508
2414
2415         Reviewed by Sergio Villar Senin.
2416
2417         Add a unit test to check that synchronous XHRs load even if the
2418         maximum connection limits are reached.
2419
2420         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
2421         (testWebViewSyncRequestOnMaxConns):
2422         (serverCallback):
2423         (beforeAll):
2424         * gtk/jhbuild.modules: Bump libsoup version to 2.49.91.
2425
2426 2015-03-02  Alexey Proskuryakov  <ap@apple.com>
2427
2428         Update the name of ASan build step.
2429
2430         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2431
2432 2015-03-02  Jer Noble  <jer.noble@apple.com>
2433
2434         [WK1][WK2][Mac] Fullscreen animation is incorrect when page is scaled.
2435         https://bugs.webkit.org/show_bug.cgi?id=142121
2436
2437         Reviewed by Simon Fraser.
2438
2439         Add a test which changes the WebView's page scale, then enters fullscreen mode, and verifies
2440         that the initial and final screen rects for the web content are as expected.
2441
2442         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2443         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.html: Added.
2444         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm: Added.
2445         (-[FullscreenStateDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
2446         (runJavaScriptAlert):
2447         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
2448         (TestWebKitAPI::FullscreenZoomInitialFrame::teardownView):
2449         (TestWebKitAPI::FullscreenZoomInitialFrame::setPageScale):
2450         (TestWebKitAPI::FullscreenZoomInitialFrame::sendMouseDownEvent):
2451         (TestWebKitAPI::FullscreenZoomInitialFrame::runTest):
2452         (TestWebKitAPI::TEST_F):
2453
2454 2015-03-01  David Kilzer  <ddkilzer@apple.com>
2455
2456         LayoutTestRealy: Prepend __XPC_ to the key, not the value!
2457
2458         Follow-up fix for:
2459
2460         LayoutTestRelay: App environment variables not set for --guard-malloc or --leaks
2461         <http://webkit.org/b/142145>
2462
2463         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
2464         (-[LTRelayController _environmentVariables]): Fix think-o.
2465
2466 2015-03-01  David Kilzer  <ddkilzer@apple.com>
2467
2468         LayoutTestRelay: App environment variables not set for --guard-malloc or --leaks
2469         <http://webkit.org/b/142145>
2470
2471         Reviewed by Simon Fraser.
2472
2473         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
2474         (-[LTRelayController _environmentVariables]): Add.
2475         (-[LTRelayController launchApp]): Use -_environmentVariables.
2476
2477 2015-02-28  David Kilzer  <ddkilzer@apple.com>
2478
2479         [iOS] Stop running webkit-build-directory on every layout test
2480
2481         This was originally fixed by David Farler for Bug 135409 in
2482         r172602.
2483
2484         * Scripts/webkitpy/port/ios.py:
2485         (IOSSimulatorPort.relay_path): Mark as @memoized so it doesn't
2486         run webkit-build-directory every time it's called.
2487
2488 2015-02-28  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2489
2490         W3C importer should use filesystem instead of shutil/host
2491         https://bugs.webkit.org/show_bug.cgi?id=142012
2492
2493         Reviewed by Bem Jones-Bey.
2494
2495         Removed direct use of python shutil and os, except for os.walk which will require its own fix.
2496
2497         * Scripts/webkitpy/w3c/test_importer.py:
2498         (main):
2499         (TestImporter.do_import):
2500         (TestImporter.find_importable_tests):
2501         (TestImporter.import_tests):
2502         (TestImporter.remove_deleted_files):
2503         (TestImporter.write_import_log):
2504
2505 2015-02-28  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2506
2507         W3C test importer should use filesystem to read and write files
2508         https://bugs.webkit.org/show_bug.cgi?id=142084
2509
2510         Reviewed by Bem Jones-Bey.
2511
2512         Use of FileSystem.write_binary_file, read_text_file and write_text_file in lieu of open().
2513
2514         * Scripts/webkitpy/w3c/test_importer.py:
2515         (TestImporter.import_tests):
2516         (TestImporter.remove_deleted_files):
2517         (TestImporter.write_import_log):
2518
2519 2015-02-27  Sam Weinig  <sam@webkit.org>
2520
2521         Add WebKit2 SPI to create a DOM File object
2522         https://bugs.webkit.org/show_bug.cgi?id=142109
2523
2524         Reviewed by Tim Horton.
2525
2526         Add a test for WKBundleFileHandleRef.
2527
2528         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2529         * TestWebKitAPI/Tests/WebKit2/WKBundleFileHandle.cpp: Added.
2530         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
2531         (TestWebKitAPI::didFinishLoadForFrame):
2532         (TestWebKitAPI::TEST):
2533         * TestWebKitAPI/Tests/WebKit2/WKBundleFileHandle_Bundle.cpp: Added.
2534         (TestWebKitAPI::WKBundleFileHandleTest::WKBundleFileHandleTest):
2535         * TestWebKitAPI/Tests/WebKit2/bundle-file.html: Added.
2536
2537 2015-02-27  Michael Saboff  <msaboff@apple.com>
2538
2539         Add ability for run-jsc-benchmarks to set library path from test binary when run on a build bot
2540         https://bugs.webkit.org/show_bug.cgi?id=142112
2541
2542         Reviewed by Filip Pizlo.
2543
2544         Added check for VMs in the form of <someDir>/{DumpRenderTree,webkitTestRunner,jsc} and use
2545         <someDir> as the library path.
2546
2547         * Scripts/run-jsc-benchmarks:
2548
2549 2015-02-27  Alex Christensen  <achristensen@webkit.org>
2550
2551         [WinCairo] Unreviewed build fix.
2552
2553         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props:
2554         Use TestWebKitAPIPrefix.h like in TestWebKitAPICommon.props.
2555
2556 2015-02-27  Anders Carlsson  <andersca@apple.com>
2557
2558         Add infrastructure for handling website data in the network process
2559         https://bugs.webkit.org/show_bug.cgi?id=142092
2560
2561         Reviewed by Andreas Kling.
2562
2563         Add a menu item that will fetch all website data, delete the returned data records, and
2564         fetch all website data again so we can confirm that it's all empty.
2565
2566         * MiniBrowser/mac/WK2BrowserWindowController.m:
2567         (-[WK2BrowserWindowController fetchAndClearWebsiteData:]):
2568
2569 2015-02-26  Brent Fulgham  <bfulgham@apple.com>
2570
2571         [Win] Remove remaining SafariTheme cruft
2572         https://bugs.webkit.org/show_bug.cgi?id=142075
2573
2574         Reviewed by Anders Carlsson.
2575
2576         Remove reference to SafariTheme-switching preference.
2577
2578         * DumpRenderTree/win/DumpRenderTree.cpp:
2579         (resetWebPreferencesToConsistentValues):
2580         (prepareConsistentTestingEnvironment):
2581
2582 2015-02-26  Doug Russell  <d_russell@apple.com>
2583
2584         AX: Expose caret browsing preference to accessibility API
2585         https://bugs.webkit.org/show_bug.cgi?id=141862
2586
2587         Reviewed by Chris Fleizach.
2588
2589         Exposing the caret browsing setting on WebCore::Frame via the accessibility API would allow assistive tech apps to enable it contextually (for example, when the assistive tech app is running).
2590         Enabling caret browsing when assistive tech apps are running greatly improves the reliability of keyboard navigation on the web. Most especially in cases where selection would be disrupted by focus events.
2591
2592         * DumpRenderTree/AccessibilityUIElement.cpp:
2593         (setBoolAttributeValueCallback):
2594         (selectedTextMarkerRangeCallback):
2595         (resetSelectedTextMarkerRangeCallback):
2596         (AccessibilityUIElement::setBoolAttributeValue):
2597         (AccessibilityUIElement::selectedTextMarkerRange):
2598         (AccessibilityUIElement::resetSelectedTextMarkerRange):
2599         (AccessibilityUIElement::getJSClass):
2600         * DumpRenderTree/AccessibilityUIElement.h:
2601         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2602         (AccessibilityUIElement::setBoolAttributeValue):
2603         (AccessibilityUIElement::selectedTextMarkerRange):
2604         (AccessibilityUIElement::resetSelectedTextMarkerRange):
2605         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2606         (WTR::AccessibilityUIElement::selectedTextMarkerRange):
2607         (WTR::AccessibilityUIElement::resetSelectedTextMarkerRange):
2608         (WTR::AccessibilityUIElement::setBoolAttributeValue):
2609         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2610         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2611         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2612         (WTR::AccessibilityUIElement::setBoolAttributeValue):
2613         (WTR::AccessibilityUIElement::selectedTextMarkerRange):
2614         (WTR::AccessibilityUIElement::resetSelectedTextMarkerRange):
2615
2616 2015-02-26  Brent Fulgham  <bfulgham@apple.com>
2617
2618         [Win] Remove WebKitExportGenerator project (and related)
2619         https://bugs.webkit.org/show_bug.cgi?id=142035
2620
2621         Reviewed by Dean Jackson.
2622
2623         * win/AssembleBuildLogs/AssembleLogs.cmd: Don't look for a
2624         build log from WebKitExportGenerator.
2625
2626 2015-02-26  Csaba Osztrogonác  <ossy@webkit.org>
2627
2628         [EFL] Bump EFL version to 1.13.0
2629         https://bugs.webkit.org/show_bug.cgi?id=141708
2630
2631         Reviewed by Gyuyoung Kim.
2632
2633         * efl/jhbuild.modules:
2634
2635 2015-02-26  Sam Weinig  <sam@webkit.org>
2636
2637         Check in missing WebEditingTester.xcconfig file.
2638
2639         * WebEditingTester/Configurations/WebEditingTester.xcconfig: Added.
2640
2641 2015-02-26  Csaba Osztrogonác  <ossy@webkit.org>
2642
2643         [webkitpy] Remove skipped file related crufts
2644         https://bugs.webkit.org/show_bug.cgi?id=142046
2645
2646         Reviewed by Ryosuke Niwa.
2647
2648         * Scripts/webkitpy/port/base.py:
2649         (Port.skipped_layout_tests):
2650         (Port._tests_from_skipped_file_contents): Deleted.
2651         (Port): Deleted.
2652         (Port._expectations_from_skipped_files): Deleted.
2653         * Scripts/webkitpy/port/mac_unittest.py:
2654         (MacTest.test_default_timeout_ms):
2655         (MacTest): Deleted.
2656         (test_tests_from_skipped_file_contents): Deleted.
2657
2658 2015-02-26  Brent Fulgham  <bfulgham@apple.com>
2659
2660         [Win] Unreviewed WinCairo build fix after r180653.
2661
2662         TestWebKitAPI should know about proper WEBCORE_EXPORT definitions.
2663
2664         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
2665         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
2666         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommon.props:
2667         * TestWebKitAPI/win/TestWebKitAPIPrefix.cpp: Added.
2668         * TestWebKitAPI/win/TestWebKitAPIPrefix.h: Added.
2669
2670 2015-02-25  Brent Fulgham  <bfulgham@apple.com>
2671
2672         [Win] Use WEBCORE_EXPORT instead of Definition file
2673         https://bugs.webkit.org/show_bug.cgi?id=141734
2674
2675         Reviewed by Alex Christensen.
2676
2677         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
2678         Use a precompiled header so we can define our export macros properly.
2679         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj.filters:
2680         Visual studio automatic update stuff.
2681         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeCommon.props:
2682         Set up Precompiled Header use for project..
2683         * DumpRenderTree/win/DumpRenderTreePrefix.cpp: Added.
2684         * DumpRenderTree/DumpRenderTreePrefix.h: Update with proper export
2685         declarations for building DumpRenderTree as a client of
2686         WebCore/WebKit.
2687
2688 2015-02-25  Mark Lam  <mark.lam@apple.com>
2689
2690         ASan does not like JSC::MachineThreads::tryCopyOtherThreadStack.
2691         <https://webkit.org/b/141672>
2692
2693         Reviewed by Alexey Proskuryakov.
2694
2695         ASan does not like the fact that we memcpy the stack for GC scans.  So,
2696         we're working around this by using our own memcpy (asanUnsafeMemcpy)
2697         implementation that we can tell ASan to ignore.
2698
2699         Also removed the previous added directive to ignore *tryCopyOtherThreadStack*
2700         which isn't effective for working around this issue.
2701
2702         * asan/webkit-asan-ignore.txt:
2703
2704 2015-02-25  Benjamin Poulain  <bpoulain@apple.com>
2705
2706         CodeBlock crashes when dumping op_push_name_scope
2707         https://bugs.webkit.org/show_bug.cgi?id=141953
2708
2709         Reviewed by Filip Pizlo.
2710
2711         * Scripts/run-jsc-stress-tests:
2712
2713 2015-02-25  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2714
2715         W3C test importer should use argparse instead of optparse
2716         https://bugs.webkit.org/show_bug.cgi?id=142013
2717
2718         Reviewed by Bem Jones-Bey.
2719
2720         * Scripts/webkitpy/w3c/test_importer.py:
2721         (main): Updating according argparse.
2722         (parse_args): Moving from optparse to argparse.
2723
2724 2015-02-25  Brady Eidson  <beidson@apple.com>
2725
2726         Get rid of TestInvocation::pathOrURL
2727         https://bugs.webkit.org/show_bug.cgi?id=142021
2728
2729         Reviewed by Tim Horton.
2730
2731         The pathOrURL string is a relative path used as an argument to WebKitTestRunner,
2732         but most code that uses it expected an absolute path.
2733
2734         This gets rid of the member and replaces all uses with a more descriptive "urlContains" method.
2735
2736         * WebKitTestRunner/TestController.cpp:
2737         (WTR::TestController::updateWebViewSizeForTest):
2738         (WTR::TestController::updateWindowScaleForTest):
2739         (WTR::shouldUseFixedLayout):
2740         (WTR::TestController::updateLayoutTypeForTest):
2741
2742         * WebKitTestRunner/TestInvocation.cpp:
2743         (WTR::TestInvocation::TestInvocation):
2744         (WTR::TestInvocation::urlContains):
2745         (WTR::TestInvocation::shouldLogFrameLoadDelegates):
2746         (WTR::TestInvocation::shouldLogHistoryClientCallbacks):
2747         (WTR::TestInvocation::invoke):
2748         (WTR::shouldLogFrameLoadDelegates): Deleted.
2749         (WTR::shouldLogHistoryClientCallbacks): Deleted.
2750         * WebKitTestRunner/TestInvocation.h:
2751         (WTR::TestInvocation::pathOrURL): Deleted.
2752
2753         * WebKitTestRunner/ios/TestControllerIOS.mm:
2754         (WTR::shouldMakeViewportFlexible):
2755         (WTR::TestController::platformConfigureViewForTest):
2756
2757         * WebKitTestRunner/mac/TestControllerMac.mm:
2758         (WTR::shouldUseThreadedScrolling):
2759         (WTR::TestController::platformConfigureViewForTest):
2760
2761 2015-02-25  Brady Eidson  <beidson@apple.com>
2762
2763         Layout test support for user content filters
2764         https://bugs.webkit.org/show_bug.cgi?id=142018
2765
2766         Reviewed by Tim Horton.
2767
2768         * WebKitTestRunner/TestController.cpp:
2769         (WTR::TestController::resetStateToConsistentValues): Clear all user content filters between tests.
2770
2771         * WebKitTestRunner/mac/TestControllerMac.mm:
2772         (WTR::TestController::platformConfigureViewForTest): For all tests with usercontentfilter/ in their path try to load a matching .json
2773           file before loading the test itself.
2774
2775 2015-02-24  Sam Weinig  <sam@webkit.org>
2776
2777         Convert WebEditingTester to use xcconfig files
2778         https://bugs.webkit.org/show_bug.cgi?id=141879
2779
2780         Reviewed by Darin Adler.
2781
2782         Add xcconfig files to WebEditingTester based on the ones used by MiniBrowser.
2783
2784         * WebEditingTester/Configurations: Added.
2785         * WebEditingTester/Configurations/Base.xcconfig: Added.
2786         * WebEditingTester/Configurations/DebugRelease.xcconfig: Added.
2787         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
2788
2789 2015-02-24  Andy Estes  <aestes@apple.com>
2790
2791         Teach MiniBrowser how to disable per-window web processes
2792         https://bugs.webkit.org/show_bug.cgi?id=141988
2793
2794         Reviewed by Darin Adler.
2795
2796         * MiniBrowser/mac/AppDelegate.m:
2797         (defaultConfiguration): Created a _WKProcessPoolConfiguration with maximumProcessCount == 1 if per-window web processes are disabled.
2798         * MiniBrowser/mac/SettingsController.h:
2799         * MiniBrowser/mac/SettingsController.m:
2800         (-[SettingsController _populateMenu]): Added a new Settings menu item.
2801         (-[SettingsController validateMenuItem:]): Validated the new Settings menu item.
2802         (-[SettingsController togglePerWindowWebProcessesDisabled:]): Displayed an alert informing the user that MiniBrowser must be restarted for the setting to take effect.
2803         (-[SettingsController perWindowWebProcessesDisabled]): Returned the value from user defaults.
2804
2805 2015-02-24  Alexey Proskuryakov  <ap@apple.com>
2806
2807         Bot watcher's dashboard sometimes hits an assertion: data.num_missing === this.layoutTestResults.testsWithMissingResults.length
2808         https://bugs.webkit.org/show_bug.cgi?id=141889
2809
2810         Reviewed by Darin Adler.
2811
2812         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2813
2814 2015-02-24  Yusuke Suzuki  <utatane.tea@gmail.com>
2815
2816         REGRESSION(r179429): Can't type comments in Facebook
2817         https://bugs.webkit.org/show_bug.cgi?id=141859
2818
2819         Reviewed by Brent Fulgham.
2820
2821         Drop javaScriptExperimentsEnabled and specify JavaScriptRuntimeFlagsAllEnabled as KJavaScriptRuntimeFlags.
2822
2823         * DumpRenderTree/mac/DumpRenderTree.mm:
2824         (resetWebPreferencesToConsistentValues):
2825         * DumpRenderTree/win/DumpRenderTree.cpp:
2826         (resetWebPreferencesToConsistentValues):
2827         * WebKitTestRunner/TestController.cpp:
2828         (WTR::TestController::resetPreferencesToConsistentValues):
2829
2830 2015-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
2831
2832         Crash loading local file with WebPageProxy::loadAlternateHTMLString
2833         https://bugs.webkit.org/show_bug.cgi?id=141867
2834
2835         Reviewed by Anders Carlsson.
2836
2837         * TestWebKitAPI/Tests/WebKit2/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
2838         (TestWebKitAPI::loadAlternateHTMLString): Split most of this test into a function so it can
2839         be shared with the new test.
2840         (TestWebKitAPI::TEST): Add a cross-platform test for this crash.
2841         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp: Add a GTK+ test for this crash.
2842         (testLoadAlternateHTMLForLocalPage):
2843         (beforeAll):
2844
2845 2015-02-24  David Kilzer  <ddkilzer@apple.com>
2846
2847         [iOS] Implement WTR::activateFonts() to fix missing fonts in WebKit2 test runs
2848         <http://webkit.org/b/141900>
2849
2850         Reviewed by Myles C. Maxfield.
2851
2852         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
2853         (OTHER_LDFLAGS_BASE): Link to CoreText.framework.
2854         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm: Rename from Tools/WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm.
2855         - Rename to share code with iOS.
2856         - Add USE(APPKIT) around AppKit-specific headers and code.
2857         - Fix a check-webkit-style warning.
2858         * WebKitTestRunner/InjectedBundle/ios/ActivateFontsIOS.mm: Remove.
2859         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2860         - Rename mac/ActivateFonts.mm to cocoa/ActivateFontsCocoa.mm.
2861         - Remove ios/ActivateFontsIOS.mm.
2862         - Fix InjectedBundle/cocoa group to represent the directory on
2863           disk.  Includes a change to InjectedBundlePageCocoa.mm.
2864
2865 2015-02-23  Commit Queue  <commit-queue@webkit.org>
2866
2867         Unreviewed, rolling out r180547 and r180550.
2868         https://bugs.webkit.org/show_bug.cgi?id=141957
2869
2870         Broke 10 Windows tests. (Requested by bfulgham_ on #webkit).
2871
2872         Reverted changesets:
2873
2874         "REGRESSION(r179429): Can't type comments in Facebook"
2875         https://bugs.webkit.org/show_bug.cgi?id=141859
2876         http://trac.webkit.org/changeset/180547
2877
2878         "Constructor returning null should construct an object instead
2879         of null"
2880         https://bugs.webkit.org/show_bug.cgi?id=141640
2881         http://trac.webkit.org/changeset/180550
2882
2883 2015-02-23  Yusuke Suzuki  <utatane.tea@gmail.com>
2884
2885         REGRESSION(r179429): Can't type comments in Facebook
2886         https://bugs.webkit.org/show_bug.cgi?id=141859
2887
2888         Reviewed by Geoffrey Garen.
2889
2890         Drop javaScriptExperimentsEnabled and specify JavaScriptRuntimeFlagsAllEnabled as KJavaScriptRuntimeFlags.
2891
2892         * DumpRenderTree/mac/DumpRenderTree.mm:
2893         (resetWebPreferencesToConsistentValues):
2894         * WebKitTestRunner/TestController.cpp:
2895         (WTR::TestController::resetPreferencesToConsistentValues):
2896
2897 2015-02-23  KwangHyuk Kim  <hyuki.kim@samsung.com>
2898
2899         [EFL] fix eo errors
2900         https://bugs.webkit.org/show_bug.cgi?id=141909
2901
2902         Reviewed by Gyuyoung Kim.
2903
2904         Fix eo errors that occur whenever minibrowser is launched.
2905         - elm_obj_entry_text_style_user_push can only be applied for elm_entry
2906         - elm_obj_win_resize_object_add's first parameter should be elm_win
2907
2908         * MiniBrowser/efl/main.c:
2909         (window_create):
2910
2911 2015-02-23  Ryosuke Niwa  <rniwa@webkit.org>
2912
2913         Unreviewed build fix after r180535. Removed the test case that wasn't compiling.
2914
2915         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
2916         (TestWebKitAPI::TEST):
2917
2918 2015-02-23  Brent Fulgham  <bfulgham@apple.com>
2919
2920         WTF::WeakPtr should rename 'forgot' to 'clear' and support nullptr assignment
2921         https://bugs.webkit.org/show_bug.cgi?id=141935
2922
2923         Reviewed by Myles C. Maxfield.
2924
2925         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
2926         (TestWebKitAPI::TEST): Updated for 'clear' method rename, and added a few
2927         tests for assigning from nullptr.
2928
2929 2015-02-23  Brent Fulgham  <bfulgham@apple.com>
2930
2931         WTF::WeakPtr should have a 'forget' method.
2932         https://bugs.webkit.org/show_bug.cgi?id=141923
2933
2934         Reviewed by Myles C. Maxfield.
2935
2936         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
2937         (TestWebKitAPI::TEST): Added 'Forget' tests case.
2938
2939 2015-02-23  Alexey Proskuryakov  <ap@apple.com>
2940
2941         build.webkit.org/dashboard CrashOnly queues should not show two green bubbles
2942         https://bugs.webkit.org/show_bug.cgi?id=141920
2943
2944         Reviewed by Tim Horton.
2945
2946         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2947         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
2948         Do the same thing as we do for regular green bubbles.
2949
2950 2015-02-23  Alexey Proskuryakov  <ap@apple.com>
2951
2952         Bot watcher's dashboard doesn't show a popover for commit history when all commits were to another branch
2953         https://bugs.webkit.org/show_bug.cgi?id=141925
2954
2955         Reviewed by Tim Horton.
2956
2957         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2958         (BuildbotQueueView.prototype._presentPopoverForRevisionRange):
2959
2960 2015-02-23  Anders Carlsson  <andersca@apple.com>
2961
2962         Add API for fetching website data records to _WKWebsiteDataStore
2963         https://bugs.webkit.org/show_bug.cgi?id=141926
2964
2965         Reviewed by Beth Dakin.
2966
2967         * MiniBrowser/mac/MainMenu.xib:
2968         * MiniBrowser/mac/WK2BrowserWindowController.m:
2969         (-[WK2BrowserWindowController fetchWebsiteData:]):
2970         Add menu item to fetch and dump website data.
2971
2972 2015-02-23  David Kilzer  <ddkilzer@apple.com>
2973
2974         [iOS] run-webkit-tests --leaks is broken because IOSSimulatorPort has no is_snowleopard attribute
2975         <http://webkit.org/b/141884>
2976
2977         Reviewed by Alexey Proskuryakov.
2978
2979         * Scripts/webkitpy/port/leakdetector.py:
2980         (LeakDetector._callstacks_to_exclude_from_leaks): Remove
2981         snowleopard, lion and older leaks.  Add known leak for
2982         mavericks, but check Port.operating_system before calling
2983         Port.is_mavericks.
2984         * Scripts/webkitpy/port/mac.py:
2985         (MacPort.is_snowleopard): Delete.
2986         (MacPort.is_lion): Delete.
2987         (MacPort.is_mavericks): Add.
2988
2989 2015-02-23  Alexey Proskuryakov  <ap@apple.com>
2990
2991         build.webkit.org/dashboard should filter out commits to other branches
2992         https://bugs.webkit.org/show_bug.cgi?id=140362
2993
2994         Reviewed by Tim Horton.
2995
2996         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2997         (BuildbotQueue):
2998         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2999         (BuildbotQueueView.prototype._presentPopoverForPendingCommits):
3000         (BuildbotQueueView.prototype._presentPopoverForRevisionRange):
3001         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration):
3002         (BuildbotQueueView.prototype.revisionContentForIteration):
3003         (BuildbotQueueView.prototype._appendPendingRevisionCount): Deleted.
3004         (BuildbotQueueView.prototype._popoverLinesForCommitRange): Deleted.
3005         (BuildbotQueueView.prototype._revisionPopoverContentForIteration): Deleted.
3006         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
3007         (Trac.prototype.get oldestRecordedRevisionNumber):
3008         (Trac.prototype.commitsOnBranch):
3009         (Trac.prototype._xmlTimelineURL):
3010         (Trac.prototype._convertCommitInfoElementToObject):
3011         (Trac.prototype._update):
3012         (Trac.prototype.startPeriodicUpdates):
3013         (Trac.prototype.loadMoreHistoricalData):
3014         (Trac.prototype.update): Deleted.
3015
3016 2015-02-21  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3017
3018         Tests don't work on some bots: Failed to stop wptwk
3019         https://bugs.webkit.org/show_bug.cgi?id=141235
3020
3021         Reviewed by Ryosuke Niwa.
3022
3023         Logging of server subprocesses in launcher script.
3024         Killing of server subprocesses when stopping/before starting.
3025         Removed empty __init.py__ file creation as importer now ensures these files cannot be empty anymore.
3026
3027         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
3028         (main): Removed empty __init.py__ file creation as importer now ensures these files cannot be empty anymore. Added logging in a file of server subprocesses to clean them in case of abnormal shutdown.
3029         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
3030         (WebPlatformTestServer.__init__):
3031         (WebPlatformTestServer._stop_running_subservers): Kill server subprocesses based on file created by wpt launcher.
3032         (WebPlatformTestServer):
3033         (WebPlatformTestServer.stop): Overriden to ensure killing subprocesses in case of orphaned process.
3034         (WebPlatformTestServer._stop_running_server): Killing of wpt launcher process after regular shutdown.
3035         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
3036         (TestWebPlatformTestServer.test_server_closes_previously_spawned_instance): Reworked the test to call start/stop with an existing pid file.
3037         (TestWebPlatformTestServer.test_import_web_platform_test_modules): No change.
3038         (TestWebPlatformTestServer):
3039         (TestWebPlatformTestServer.test_corrupted_subserver_files): Checked that server subprocess cleaning does not throw in case of bad server pid file.
3040
3041 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
3042
3043         [WebEditingTester] Allow dropping HTML files on the app
3044         https://bugs.webkit.org/show_bug.cgi?id=141834
3045
3046         Reviewed by Simon Fraser.
3047
3048         * WebEditingTester/AppDelegate.m:
3049         (-[WebEditingAppDelegate openDocument:]):
3050         (-[WebEditingAppDelegate application:openFile:]):
3051         Implement application:openFile:, factoring file loading code out of openDocument.
3052
3053         * WebEditingTester/Info.plist:
3054         Register as an editor for HTML files.
3055
3056         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
3057         Enrica is not an organization.
3058
3059 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
3060
3061         [WebEditingTester] Expand "WK" to "WebKit" in a few places
3062         https://bugs.webkit.org/show_bug.cgi?id=141833
3063
3064         Reviewed by Anders Carlsson.
3065
3066         * WebEditingTester/AppDelegate.h:
3067         * WebEditingTester/AppDelegate.m:
3068         (-[WebEditingAppDelegate newEditor:]):
3069         (-[WebEditingAppDelegate toggleUseWebKit2ByDefault:]):
3070         (-[WebEditingAppDelegate validateMenuItem:]):
3071         (-[WebEditingAppDelegate _updateNewWindowKeyEquivalents]):
3072         (-[WebEditingAppDelegate applicationDidFinishLaunching:]): Deleted.
3073         (-[WebEditingAppDelegate applicationWillTerminate:]): Deleted.
3074         (-[WebEditingAppDelegate showOperations:]): Deleted.
3075         * WebEditingTester/MainMenu.xib:
3076         The WK abbreviation is unnaturally grating in menu items for some reason.
3077
3078 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
3079
3080         [WebEditingTester] Add a custom protocol for loading canned content
3081         https://bugs.webkit.org/show_bug.cgi?id=141830
3082
3083         Reviewed by Enrica Casucci.
3084
3085         Add a canned:// protocol handler, which can be used to emulate behaviors
3086         in WebKit client apps (like Mail) that use custom protocol handlers,
3087         which can have important effects on editing (mostly, the URLs are only
3088         valid inside of the client application, but not when copied/dragged out).
3089
3090         For now, we only support two canned files:
3091
3092             canned://dice is a PNG of dice (stolen from LayoutTests/)
3093             canned://text is the string "canned text" served as text/html
3094
3095         In the future we could support things like very large (generated) files,
3096         progressive loading, etc. to further simulate conditions in other apps.
3097
3098         * WebEditingTester/AppDelegate.m:
3099         (-[WebEditingAppDelegate applicationDidFinishLaunching:]):
3100         Register the protocol with CFNetwork, and the scheme with WebKit2.
3101
3102         * WebEditingTester/Canned Content/dice.png: Added.
3103         * WebEditingTester/CannedContent.h: Added.
3104         * WebEditingTester/CannedContent.m: Added.
3105         (-[CannedContent initWithRequest:cachedResponse:client:]):
3106         (+[CannedContent canonicalRequestForRequest:]):
3107         (+[CannedContent canInitWithRequest:]):
3108         We only want to handle canned:// URLs.
3109
3110         (-[CannedContent startLoading]):
3111         For now, immediately load the two files we know about.
3112         Otherwise, immediately fail the load.
3113
3114         (-[CannedContent stopLoading]):
3115         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
3116
3117 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
3118
3119         [WebEditingTester] Implement an open panel
3120         https://bugs.webkit.org/show_bug.cgi?id=141829
3121
3122         Reviewed by Simon Fraser.
3123
3124         * WebEditingTester/AppDelegate.m:
3125         (-[WebEditingAppDelegate _useWebKit1ForOpeningDocument:]):
3126         (-[WebEditingAppDelegate _useWebKit2ForOpeningDocument:]):
3127         (-[WebEditingAppDelegate openDocument:]):
3128         Add an open panel (with radio buttons to pick which WebKit to open with).
3129         Loads the file as an HTML string.
3130
3131 2015-02-20  Simon Fraser  <simon.fraser@apple.com>
3132
3133         [WebEditingTester] @properties, dot syntax, and remember the window position
3134         https://bugs.webkit.org/show_bug.cgi?id=141843
3135
3136         Reviewed by Tim Horton.
3137
3138         Modernize a bit with more dot syntax, use @property for the web views,
3139         and give the main window an Autosave name so it remembers the widow position.
3140
3141         * WebEditingTester/WK1WebDocumentController.m:
3142         (-[WK1WebDocumentController awakeFromNib]):
3143         (-[WK1WebDocumentController loadHTMLString:]):
3144         * WebEditingTester/WK2WebDocumentController.m:
3145         (-[WK2WebDocumentController awakeFromNib]):
3146         * WebEditingTester/WebDocument.xib:
3147
3148 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
3149
3150         [WebEditingTester] Hook up key equivalents for new window action
3151         https://bugs.webkit.org/show_bug.cgi?id=141828
3152
3153         Reviewed by Enrica Casucci.
3154
3155         * WebEditingTester/AppDelegate.h:
3156         * WebEditingTester/AppDelegate.m:
3157         (-[WebEditingAppDelegate applicationDidFinishLaunching:]):
3158         (-[WebEditingAppDelegate newEditor:]):
3159         (-[WebEditingAppDelegate _defaultWebDocumentControllerClass]):
3160         (-[WebEditingAppDelegate toggleUseWK2ByDefault:]):
3161         (-[WebEditingAppDelegate _updateNewWindowKeyEquivalents]):
3162         (defaultConfiguration): Deleted.
3163         (-[WebEditingAppDelegate applicationWillTerminate:]): Deleted.
3164         Move WKWebViewConfiguration setup into WK2WebDocumentController.
3165         Remove unused application termination code.
3166         Update new-window menu item key equivalents when launching and when
3167         changing the use-WebKit2-by-default setting.
3168         Make WebDocumentController subclasses all initialized the same way,
3169         and use that to factor out alloc/init.
3170         Rename loadContent to loadHTMLString for future use.
3171
3172         * WebEditingTester/MainMenu.xib:
3173         Add default key equivalents.
3174         Cmd-N will always make the default kind of window (controlled by the pref).
3175         Cmd-Opt-N will always make the other kind.
3176         The menu items are configured as alternates so they only show up if you
3177         press alt (just like in MiniBrowser).
3178
3179         * WebEditingTester/WK1WebDocumentController.m:
3180         (-[WK1WebDocumentController loadHTMLString:]):
3181         (-[WK1WebDocumentController loadContent]): Deleted.
3182         * WebEditingTester/WK2WebDocumentController.h:
3183         * WebEditingTester/WK2WebDocumentController.m:
3184         (defaultConfiguration):
3185         (-[WK2WebDocumentController awakeFromNib]):
3186         (-[WK2WebDocumentController loadHTMLString:]):
3187         (-[WK2WebDocumentController initWithConfiguration:]): Deleted.
3188         (-[WK2WebDocumentController dealloc]): Deleted.
3189         * WebEditingTester/WebDocumentController.h:
3190         * WebEditingTester/WebDocumentController.m:
3191         (-[WebDocumentController init]):
3192         (-[WebDocumentController initWithWindow:]):
3193         (+[WebDocumentController defaultEditingSource]):
3194         (-[WebDocumentController loadHTMLString:]):
3195         (-[WebDocumentController windowDidLoad]): Deleted.
3196         (-[WebDocumentController defaultEditingSource]): Deleted.
3197         (-[WebDocumentController applicationTerminating]): Deleted.
3198         (-[WebDocumentController loadContent]): Deleted.
3199
3200 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
3201
3202         [WebEditingTester] ARC-ify WebEditingTester
3203         https://bugs.webkit.org/show_bug.cgi?id=141827
3204
3205         Reviewed by Sam Weinig.
3206
3207         * WebEditingTester/AppDelegate.m:
3208         (-[WebEditingAppDelegate showOperations:]):
3209         * WebEditingTester/EditingOperations.m:
3210         (editingOperations):
3211         * WebEditingTester/WK1WebDocumentController.m:
3212         (-[WK1WebDocumentController dealloc]): Deleted.
3213         * WebEditingTester/WK2WebDocumentController.m:
3214         (-[WK2WebDocumentController dealloc]): Deleted.
3215         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
3216         Turn on ARC and remove a few retain/release/autorelease calls.
3217         We don't need to implement dealloc in either document controller
3218         because WebView and WKWebView's UIDelegate property does not hold a
3219         strong reference.
3220
3221 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
3222
3223         [WebEditingTester] Factor out list of editing operations
3224         https://bugs.webkit.org/show_bug.cgi?id=141826
3225
3226         Reviewed by Sam Weinig.
3227
3228         * WebEditingTester/AppDelegate.m:
3229         (-[WebEditingAppDelegate showOperations:]):
3230         * WebEditingTester/EditingOperations.h: Added.
3231         * WebEditingTester/EditingOperations.m: Added.
3232         (editingOperations):
3233         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
3234         Move EditingOperations array to its own file, and make it an NSArray
3235         instead of a C array. Adjust accordingly in showOperations:.
3236
3237 2015-02-20  Michael Saboff  <msaboff@apple.com>
3238
3239         DFG JIT needs to check for stack overflow at the start of Program and Eval execution
3240         https://bugs.webkit.org/show_bug.cgi?id=141676
3241
3242         Reviewed by Filip Pizlo.
3243
3244         Set the newly added --maximumEvalCacheableSourceLength option for eager test runs.  This is needed
3245         to allow the eval out of stack tests to tier up.  Without this option, we don't cache the likely
3246         large string expression that we want to eval.
3247
3248         * Scripts/run-jsc-stress-tests:
3249
3250 2015-02-19  Daniel Bates  <dabates@apple.com>
3251
3252         REGRESSION (r180239): run-webkit-test fails to boot simulator device that was booted by previous test run
3253         https://bugs.webkit.org/show_bug.cgi?id=141815
3254         <rdar://problem/19893933>
3255
3256         Reviewed by Simon Fraser.
3257
3258         Fixes an issue where run-webkit-tests would fail to boot the WebKit Tester simulator device if it
3259         was booted by iOS Simulator in a previous run of run-webkit-test.
3260
3261         * Scripts/webkitpy/port/ios.py:
3262         (IOSSimulatorPort.check_sys_deps): Added logic moved from IOSSimulatorPort.setup_test_run().
3263         (IOSSimulatorPort.setup_test_run): Moved logic to quit the iOS Simulator app and wait for the
3264         testing device to be in the shutdown state from here to IOSSimulatorPort.check_sys_deps().
3265
3266 2015-02-19  David Kilzer  <ddkilzer@apple.com>
3267
3268         check-webkit-style: do not warn about missing primary header for *SoftLink.cpp files
3269         <http://webkit.org/b/141799>
3270
3271         Reviewed by Alex Christensen.
3272
3273         * Scripts/webkitpy/style/checkers/cpp.py:
3274         (_IncludeState.check_next_include_order): Don't emit a warning
3275         if the primary header exists and the source file name ends with
3276         "SoftLink.cpp".  Add 'filename' argument to method.
3277         (check_include_line): Pass in 'filename'.
3278
3279         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3280         (OrderOfIncludesTest.test_check_next_include_order__no_config):
3281         (OrderOfIncludesTest.test_check_next_include_order__no_self):
3282         (OrderOfIncludesTest.test_check_next_include_order__likely_then_config):
3283         (OrderOfIncludesTest.test_check_next_include_order__other_then_config):
3284         (OrderOfIncludesTest.test_check_next_include_order__config_then_other_then_likely):
3285         - Add test filename arguments for calls to
3286           check_next_include_order().
3287         (OrderOfIncludesTest.test_primary_header): Add test for a file
3288         name ending in "SoftLink.cpp".
3289
3290 2015-02-18  Enrica Casucci  <enrica@apple.com>
3291
3292         Add new tool to test editable Webviews.
3293         https://bugs.webkit.org/show_bug.cgi?id=141772
3294
3295         Reviewed by Tim Horton.
3296
3297         Adding WebEditingTester, a Cocoa application to
3298         test WK1 and Wk2 views in editable mode.
3299
3300         * WebEditingTester: Added.
3301         * WebEditingTester/AppDelegate.h: Added.
3302         * WebEditingTester/AppDelegate.m: Added.
3303         (-[WebEditingAppDelegate init]):
3304         (defaultConfiguration):
3305         (-[WebEditingAppDelegate applicationDidFinishLaunching:]):
3306         (-[WebEditingAppDelegate applicationWillTerminate:]):
3307         (-[WebEditingAppDelegate newEditor:]):
3308         (-[WebEditingAppDelegate showOperations:]):
3309         (-[WebEditingAppDelegate useWebKit2ByDefault]):
3310         (-[WebEditingAppDelegate toggleUseWK2ByDefault:]):
3311         (-[WebEditingAppDelegate validateMenuItem:]):
3312         * WebEditingTester/Info.plist: Added.
3313         * WebEditingTester/MainMenu.xib: Added.
3314         * WebEditingTester/WK1WebDocumentController.h: Added.
3315         * WebEditingTester/WK1WebDocumentController.m: Added.
3316         (-[WK1WebDocumentController awakeFromNib]):
3317         (-[WK1WebDocumentController loadContent]):
3318         (-[WK1WebDocumentController dealloc]):
3319         (-[WK1WebDocumentController pasteAsMarkup:]):
3320         * WebEditingTester/WK2WebDocumentController.h: Added.
3321         * WebEditingTester/WK2WebDocumentController.m: Added.
3322         (-[WK2WebDocumentController initWithConfiguration:]):
3323         (-[WK2WebDocumentController pasteAsMarkup:]):
3324         (-[WK2WebDocumentController awakeFromNib]):
3325         (-[WK2WebDocumentController dealloc]):
3326         (-[WK2WebDocumentController loadContent]):
3327         * WebEditingTester/WebDocument.xib: Added.
3328         * WebEditingTester/WebDocumentController.h: Added.
3329         * WebEditingTester/WebDocumentController.m: Added.
3330         (-[WebDocumentController initWithWindow:]):
3331         (-[WebDocumentController windowDidLoad]):
3332         (-[WebDocumentController defaultEditingSource]):
3333         (-[WebDocumentController applicationTerminating]):
3334         (-[WebDocumentController loadContent]):
3335         * WebEditingTester/WebEditingTester.xcodeproj: Added.
3336         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj: Added.
3337         * WebEditingTester/main.m: Added.
3338         (main):
3339
3340 2015-02-18  Csaba Osztrogonác  <ossy@webkit.org>
3341
3342         Run JSC tests on ARM EFL bots
3343         https://bugs.webkit.org/show_bug.cgi?id=141165
3344
3345         Reviewed by Alexey Proskuryakov.
3346
3347         * BuildSlaveSupport/build.webkit.org-config/config.json:
3348         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3349         (RunJavaScriptCoreTests.countFailures):
3350         (RunRemoteJavaScriptCoreTests):
3351         (RunRemoteJavaScriptCoreTests.start):
3352         (BuildAndRemoteJSCTestsFactory):
3353         (BuildAndRemoteJSCTestsFactory.__init__):
3354
3355 2015-02-18  Alexey Proskuryakov  <ap@apple.com>
3356
3357         Streamline unexported function build fixes
3358         https://bugs.webkit.org/show_bug.cgi?id=141761
3359
3360         Reviewed by Alex Christensen.
3361
3362         * Scripts/check-for-weak-vtables-and-externals: (readXcode5SymbolsToIgnore): Deleted.
3363         We don't need to ignore symbols that are not exported due to the .unexp file.
3364
3365 2015-02-18  Timothy Horton  <timothy_horton@apple.com>
3366
3367         Remove more references to WebCore.exp.in
3368         https://bugs.webkit.org/show_bug.cgi?id=141747
3369
3370         Reviewed by Alexey Proskuryakov.
3371
3372         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
3373         (ShouldBuildTest):
3374
3375 2015-02-17  Myles C. Maxfield  <mmaxfield@apple.com>
3376
3377         Windows test results should not fall back to mac-mountainlion after r180176
3378         https://bugs.webkit.org/show_bug.cgi?id=141719
3379
3380         Reviewed by Brent Fulgham.
3381
3382         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
3383         (_should_file_trigger_build):
3384         * Scripts/webkitpy/port/win.py:
3385         (WinPort.default_baseline_search_path):
3386         * Scripts/webkitpy/port/win_unittest.py:
3387         (WinPortTest.test_baseline_search_path):
3388
3389 2015-02-17  Daniel Bates  <dabates@apple.com>
3390
3391         [iOS] run-webkit-tests should check that simctl can boot and shutdown simulator device before running tests
3392         https://bugs.webkit.org/show_bug.cgi?id=141718
3393
3394         Reviewed by Alex Christensen.
3395
3396         We should only run layout tests if simctl can successfully boot and shutdown the testing device.
3397
3398         * Scripts/webkitpy/port/ios.py:
3399         (IOSSimulatorPort.check_sys_deps): Modified to call Simulator.check_simulator_device_and_erase_if_needed().
3400         Log a error and return False if we are unable to boot the simulator device so that the caller can take
3401         appropriate action, say exit(3) before running any layout tests.
3402         * Scripts/webkitpy/xcode/simulator.py:
3403         (Simulator._boot_and_shutdown_simulator_device): Added. Boot and then shut down the simulator device
3404         with the specified UDID.
3405         (Simulator.check_simulator_device_and_erase_if_needed): Added. Checks that simulator device
3406         with the specified UDID can successfully boot and shut down. We make at most two attempts to
3407         boot and shut down the device, erasing the device between tries so as to restore the device
3408         to a known good state.
3409
3410 2015-02-17  Daniel Bates  <dabates@apple.com>
3411
3412         run_webkit_tests.py should not know about iOS Simulator details
3413         https://bugs.webkit.org/show_bug.cgi?id=141711
3414
3415         Reviewed by Alex Christensen.
3416
3417         Run_webkit_tests.py should only parse the iOS-specific command
3418         line options --runtime and --device-type. Let the port-specific
3419         logic in ios.py validate the parsed options and instantiate
3420         internal data structures.
3421
3422         Currently run_webkit_tests.py parses the iOS-specific command
3423         line options --runtime and --device-type, validates them, and
3424         instantiates internal data structures from the parsed strings.
3425         Instead the validation logic and instantiation of internal
3426         data structures should be handled by the iOS port object.
3427
3428         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3429         (_set_up_derived_options): Remove logic to validate --runtime and --device-type
3430         and instantiate internal data structures for them.
3431         * Scripts/webkitpy/port/driver.py:
3432         (IOSSimulatorDriver.cmd_line): Modified to reference IOSSimulatorPort.simulator_runtime
3433         and IOSSimulatorPort.simulator_device_type for the iOS Simulator runtime and device type,
3434         respectively.
3435         * Scripts/webkitpy/port/ios.py: Sort the list of imports.
3436         (IOSSimulatorPort.simulator_runtime): Added. Instantiates a Runtime
3437         object from --runtime, if specified. Otherwise, instantiates a Runtime
3438         object for the latest installed iphonesimulator SDK version.
3439         (IOSSimulatorPort.simulator_device_type): Added. Instantiates a DeviceType
3440         object from --device-type, if specified. Otherwise, instantiates
3441         a DeviceType object for a iPhone 5 or iPhone 5s when on a 32-bit and 64-bit
3442         machine, respectively.
3443         (IOSSimulatorPort.check_sys_deps): Added. Validate if the chosen iOS simulator
3444         runtime is available to use.
3445         (IOSSimulatorPort.testing_device): Modified to make use of properties simulator_device_type
3446         and simulator_runtime for the iOS Simulator device type and runtime, respectively.
3447         * Scripts/webkitpy/xcode/simulator.py:
3448         (Runtime.from_version_string): Added. Turns around and calls Runtime.from_identifier()
3449         with a runtime identifier for the specified iOS version.
3450
3451 2015-02-17  Dana Burkart  <dburkart@apple.com>
3452
3453         ASan does not like JSC::MachineThreads::tryCopyOtherThreadStack
3454         https://bugs.webkit.org/show_bug.cgi?id=141672
3455
3456         Reviewed by David Kilzer.
3457
3458         * asan/webkit-asan-ignore.txt:
3459
3460 2015-02-17  Alex Christensen  <achristensen@webkit.org>
3461
3462         Remove WebCore.exp.in and clean up.
3463         https://bugs.webkit.org/show_bug.cgi?id=141491
3464
3465         Reviewed by Andreas Kling.
3466
3467         * Scripts/sort-export-file: Removed.
3468         * Scripts/webkitpy/style/checker.py:
3469         (_all_categories):
3470         (FileType):
3471         (CheckerDispatcher._file_type):
3472         (CheckerDispatcher._create_checker):
3473         Don't check if the export files are sorted.
3474         * Scripts/webkitpy/style/checkers/exportfile.py: Removed.
3475         * Scripts/webkitpy/style/checkers/exportfile_unittest.py: Removed.
3476
3477 2015-02-17  Carlos Garcia Campos  <cgarcia@igalia.com>
3478
3479         Unreviewed. Fix GTK+ make distcheck.
3480
3481         Do not exclude bmalloc directory from the tarball.
3482
3483         * gtk/manifest.txt.in:
3484
3485 2015-02-17  Carlos Garcia Campos  <cgarcia@igalia.com>
3486
3487         Unreviewed. Fix /webkit2/WebKitDOMNode/dom-cache after r180214.
3488
3489         I forgot to add the return of a bool function.
3490
3491         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
3492         (WebKitDOMNodeTest::testDOMCache):
3493
3494 2015-02-17  Carlos Garcia Campos  <cgarcia@igalia.com>
3495
3496         [GTK] GObject DOM bindings object are cached forever
3497         https://bugs.webkit.org/show_bug.cgi?id=141558
3498
3499         Reviewed by Sergio Villar Senin.
3500
3501         Add checks for all DOM objects to ensure they are not leaked. Also
3502         add a dedicated test for the DOM Object Cache.
3503
3504         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeFilterTest.cpp:
3505         (WebKitDOMNodeFilterTest::testTreeWalker):
3506         (WebKitDOMNodeFilterTest::testNodeIterator):
3507         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
3508         (WebKitDOMNodeTest::testHierarchyNavigation):
3509         (WebKitDOMNodeTest::testInsertion):
3510         (WebKitDOMNodeTest::testTagNames):
3511         (WebKitDOMNodeTest::testDOMCache):
3512         (registerTests):
3513         * TestWebKitAPI/Tests/WebKit2Gtk/DOMXPathNSResolverTest.cpp:
3514         (WebKitDOMXPathNSResolverTest::evaluateFooChildTextAndCheckResult):
3515         (WebKitDOMXPathNSResolverTest::testXPathNSResolverNative):
3516         (WebKitDOMXPathNSResolverTest::testXPathNSResolverCustom):
3517         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
3518         (testWebKitDOMObjectCache):
3519         (beforeAll):
3520         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
3521         (documentLoadedCallback):
3522
3523 2015-02-16  Carlos Garcia Campos  <cgarcia@igalia.com>
3524
3525         [GTK] WebKitFrame objects are never released
3526         https://bugs.webkit.org/show_bug.cgi?id=141641
3527
3528         Reviewed by Martin Robinson.
3529
3530         Add a way to check GObjects leaks for WebProcess tests and check
3531         WebKitFrame objects are not leaked.
3532
3533         * TestWebKitAPI/Tests/WebKit2Gtk/FrameTest.cpp:
3534         (WebKitFrameTest::testMainFrame):
3535         (WebKitFrameTest::testURI):
3536         (WebKitFrameTest::testJavaScriptContext):
3537         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
3538         (WebProcessTest::assertObjectIsDeletedWhenTestFinishes):
3539         (runTest):
3540         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h:
3541
3542 2015-02-16  Tim Horton  <timothy_horton@apple.com>
3543
3544         Fix the MiniBrowser build with newer clang
3545
3546         * MiniBrowser/mac/SettingsController.m:
3547         (-[SettingsController _toggleBooleanDefault:]):
3548         * MiniBrowser/mac/WK1BrowserWindowController.m:
3549         (-[WK1BrowserWindowController windowWillClose:]):
3550         * MiniBrowser/mac/WK2BrowserWindowController.m:
3551         (-[WK2BrowserWindowController windowWillClose:]):
3552         NSApp is id and clang gets confused about which -delegate we're talking about.
3553
3554 2015-02-16  Antti Koivisto  <antti@apple.com>
3555
3556         Develop/Disable Caches does not properly disable disk cache
3557         https://bugs.webkit.org/show_bug.cgi?id=141636
3558
3559         Reviewed by Anders Carlsson.
3560
3561         Make testRunner.setCacheModel() use the WKContext interface so the model gets passed to
3562         the network process too.
3563
3564         This makes setCacheModel asynchronous but there don't seem to be any tests that expect otherwise.
3565
3566         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3567         (WTR::InjectedBundle::beginTesting):
3568         (WTR::InjectedBundle::setCacheModel):
3569         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3570         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3571
3572             Forward to TestController.
3573
3574         (WTR::TestRunner::setCacheModel):
3575         * WebKitTestRunner/TestInvocation.cpp:
3576         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3577
3578 2015-02-16  Andrzej Badowski  <a.badowski@samsung.com>
3579
3580         Unreviewed. Add myself as a committer.
3581
3582         * Scripts/webkitpy/common/config/contributors.json:
3583
3584 2015-02-15  David Kilzer  <ddkilzer@apple.com>
3585
3586         REGRESSION (r180082): WebCore Debug builds fail on Mavericks due to weak export symbols
3587         <http://webkit.org/b/141607>
3588
3589         * Scripts/check-for-weak-vtables-and-externals: Ignore weak
3590         externals in Source/WebCore/Configurations/WebCore.unexp when
3591         building with Xcode 5.x.
3592         (readXcode5SymbolsToIgnore): Add.
3593
3594 2015-02-15  KwangHyuk Kim  <hyuki.kim@samsung.com>
3595
3596         [EFL] fix Evas GL engine error.
3597         https://bugs.webkit.org/show_bug.cgi?id=141621
3598
3599         Reviewed by Gyuyoung Kim.
3600
3601         As new elm engine api was added from efl 1.10, replace elm_config_preferred_engine_set with elm_config_accel_preference_set.
3602
3603         * MiniBrowser/efl/main.c:
3604         (elm_main):
3605
3606 2015-02-14  Csaba Osztrogonác  <ossy@webkit.org>
3607
3608         [buildbot] Enable run-api-tests on release Mac bots
3609         https://bugs.webkit.org/show_bug.cgi?id=141518
3610
3611         Reviewed by Darin Adler.
3612
3613         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3614         (RunUnitTests):
3615         (BuildFactory.__init__):
3616         (TestFactory.__init__):
3617         (BuildAndTestFactory.__init__):
3618         (RunUnitTests.start): Deleted.
3619         (unitTestsSupported): Deleted.
3620
3621 2015-02-13  Anders Carlsson  <andersca@apple.com>
3622
3623         Add a move constructor and move assignment operator to Deque
3624         https://bugs.webkit.org/show_bug.cgi?id=141571
3625
3626         Reviewed by Andreas Kling.
3627
3628         * TestWebKitAPI/Tests/WTF/Deque.cpp:
3629         (TestWebKitAPI::TEST):
3630
3631 2015-02-13  Csaba Osztrogonác  <ossy@webkit.org>
3632
3633         run-jsc-stress-tests --remote should skip profiler tests
3634         https://bugs.webkit.org/show_bug.cgi?id=141470
3635
3636         Reviewed by Filip Pizlo.
3637
3638         * Scripts/run-jsc-stress-tests:
3639
3640 2015-02-13  Anders Carlsson  <andersca@apple.com>
3641
3642         Add an initializer list constructor to Deque
3643         https://bugs.webkit.org/show_bug.cgi?id=141565
3644
3645         Reviewed by Andreas Kling.
3646
3647         * TestWebKitAPI/Tests/WTF/Deque.cpp:
3648         (TestWebKitAPI::TEST):
3649
3650 2015-02-13  Csaba Osztrogonác  <ossy@webkit.org>
3651
3652         [buildbot] Remove buildJSCTool cruft from master.cfg
3653         https://bugs.webkit.org/show_bug.cgi?id=141513
3654
3655         Reviewed by Alexey Proskuryakov.
3656
3657         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3658         (RunJavaScriptCoreTests):
3659         (RunJavaScriptCoreTests.start):
3660         (RunWebKitTests):
3661         (RunWebKitTests.start):
3662         (TestFactory.__init__):
3663         (TestLeaksFactory.__init__):
3664         (RunJavaScriptCoreTests.__init__): Deleted.
3665         (RunWebKitTests.__init__): Deleted.
3666
3667 2015-02-13  Csaba Osztrogonác  <ossy@webkit.org>
3668
3669         Unreviewed, remove empty directories.
3670
3671         * DumpRenderTree/gtk: Removed.
3672         * DumpRenderTree/gtk/fonts: Removed.
3673         * DumpRenderTree/unix: Removed.
3674         * DumpRenderTree/unix/TestNetscapePlugin: Removed.
3675         * GtkLauncher: Removed.
3676         * TestWebKitAPI/Tests/WebKitGtk: Removed.
3677         * TestWebKitAPI/Tests/WebKitGtk/resources: Removed.
3678         * WebKitTestRunner/WebKitTestRunnerAppTests: Removed.
3679         * WebKitTestRunner/WebKitTestRunnerAppTests/en.lproj: Removed.
3680
3681 2015-02-13  Csaba Osztrogonác  <ossy@webkit.org>
3682
3683         Remove Windows cruft from Tools/Scripts/build-webkittestrunner
3684         https://bugs.webkit.org/show_bug.cgi?id=141519
3685
3686         Reviewed by Alexey Proskuryakov.
3687
3688         * Scripts/build-webkittestrunner:
3689
3690 2015-02-12  Alex Christensen  <achristensen@webkit.org>
3691
3692         Removed empty directory.
3693
3694         * WinCELauncher: Removed.
3695
3696 2015-02-12  Csaba Osztrogonác  <ossy@webkit.org>
3697
3698         run-jsc-stress-tests --remote should be able add the necessary libraries to the bundle on Linux
3699         https://bugs.webkit.org/show_bug.cgi?id=141202
3700
3701         Reviewed by Darin Adler.
3702
3703         * Scripts/run-jsc-stress-tests:
3704
3705 2015-02-12  Brent Fulgham  <bfulgham@apple.com>
3706
3707         [Win] Test bot infrastructure should not try to find/use old Safari DLLs
3708         https://bugs.webkit.org/show_bug.cgi?id=141517
3709
3710         Reviewed by Anders Carlsson.
3711
3712         We do not need to locate or use the DLL's that came with Safari, so stop
3713         failing when we cannot find them. Also remove some old Qt cruft from this
3714         script.
3715
3716         * BuildSlaveSupport/built-product-archive:
3717         (archiveBuiltProduct):
3718         (extractBuiltProduct):
3719
3720 2015-02-11  Brent Fulgham  <bfulgham@apple.com>
3721
3722         [Win] [64-bit] Work around MSVC2013 Runtime Bug
3723         https://bugs.webkit.org/show_bug.cgi?id=141498
3724         <rdar://problem/19803642>
3725
3726         Reviewed by Anders Carlsson.
3727
3728         Disable FMA3 instruction use in the MSVC math library to
3729         work around a VS2013 runtime crash. We can remove this
3730         workaround when we switch to VS2015.
3731
3732         * DumpRenderTree/cg/ImageDiffCG.cpp: Call _set_FMA3_enable(0) to
3733         disable FMA3 support.
3734         * DumpRenderTree/win/DumpRenderTree.cpp: Ditto.
3735         * DumpRenderTree/win/ImageDiffCairo.cpp: Ditto.
3736         * DumpRenderTree/win/TestRunnerWin.cpp: Ditto.
3737         * Scripts/webkitperl/httpd.pm: Ditto.
3738         * TestWebKitAPI/win/main.cpp: Ditto.
3739         * WinLauncher/Common.cpp: Ditto.
3740         * win/DLLLauncher/DLLLauncherMain.cpp: Ditto.
3741
3742 2015-02-12  Csaba Osztrogonác  <ossy@webkit.org>
3743
3744         run-jsc-stress-tests should accept remote host config from JSON file
3745         https://bugs.webkit.org/show_bug.cgi?id=141509
3746
3747         Reviewed by Michael Saboff.
3748
3749         * Scripts/run-javascriptcore-tests:
3750         (runJSCStressTests):
3751         * Scripts/run-jsc-stress-tests:
3752
3753 2015-02-12  Carlos Garcia Campos  <cgarcia@igalia.com>
3754
3755         [GTK] Add API to allow overriding the default color chooser implementation
3756         https://bugs.webkit.org/show_bug.cgi?id=98935
3757
3758         Reviewed by Gustavo Noronha Silva.
3759
3760         Add a color chooser implementation for MiniBrowser using
3761         GtkPopover when the GTK+ version is recent enough.
3762         And a test case to check the new color chooser API.
3763
3764         * MiniBrowser/gtk/BrowserWindow.c:
3765         (colorChooserRGBAChanged):
3766         (popoverColorClosed):
3767         (colorChooserRequestFinished):
3768         (runColorChooserCallback):
3769         (browserWindowConstructed):
3770         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
3771         (testWebViewColorChooserRequest):
3772         (beforeAll):
3773
3774 2015-02-11  Csaba Osztrogonác  <ossy@webkit.org>
3775
3776         Make run-jsc-stress-tests --remote work with make-based runner
3777         https://bugs.webkit.org/show_bug.cgi?id=141079
3778
3779         Reviewed by Darin Adler.
3780
3781         * Scripts/run-javascriptcore-tests:
3782         (runJSCStressTests): Pass through the --shell-runner and --make-runner arguments.
3783         * Scripts/run-jsc-stress-tests: Made the make-based runner the default runner,
3784         except for remote testing on Darwin. Unified runShellTestRunner and runMakeTestRunner
3785         to avoid code duplication.
3786
3787 2015-02-11  Csaba Osztrogonác  <ossy@webkit.org>
3788
3789         run-jsc-stress tests should detect the number of processors on the remote machine too
3790         https://bugs.webkit.org/show_bug.cgi?id=141196
3791
3792         Reviewed by Darin Adler.
3793
3794         * Scripts/run-javascriptcore-tests:
3795         (runJSCStressTests): Pass through the --child-processes argument.
3796         * Scripts/run-jsc-stress-tests: Added determineNumberOfProcessors function
3797         to detect the number of local and remote processors with the same algorithm.
3798         Additionally introduced $numChildProcesses to emphasize it isn't necessarily
3799         same as $numProcessors.
3800
3801 2015-02-11  Csaba Osztrogonác  <ossy@webkit.org>
3802
3803         run-jsc-stress-tests should pass JSC_timeout to remote hosts
3804         https://bugs.webkit.org/show_bug.cgi?id=141164
3805
3806         Reviewed by Darin Adler.
3807
3808         Additonally removed IMPORTANT_ENVS, since JSC_timeout was the only one.
3809
3810         * Scripts/run-jsc-stress-tests:
3811
3812 2015-02-11  Carlos Garcia Campos  <cgarcia@igalia.com>
3813
3814         [GTK] Add default color chooser implementation using GtkColorChooserDialog
3815         https://bugs.webkit.org/show_bug.cgi?id=141392
3816
3817         Reviewed by Gustavo Noronha Silva.
3818
3819         Enable INPUT_TYPE_COLOR by default for GTK+ port.
3820
3821         * Scripts/webkitperl/FeatureList.pm:
3822
3823 2015-02-09  Csaba Osztrogonác  <ossy@webkit.org>
3824
3825         run-jsc-stress-tests shell test runner should run tests in fixed order
3826         https://bugs.webkit.org/show_bug.cgi?id=141383
3827
3828         Reviewed by Darin Adler.
3829
3830         * Scripts/jsc-stress-test-helpers/shell-runner.sh:
3831
3832 2015-02-08  Chris Fleizach  <cfleizach@apple.com>
3833
3834         AX: VoiceOver appears unresponsive when JavaScript alerts are triggered via focus or blur events
3835         https://bugs.webkit.org/show_bug.cgi?id=140485
3836
3837         Reviewed by Anders Carlsson.
3838
3839         Implement takeFocus() as a way to set focus through accessibility wrappers.
3840
3841         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3842         (AccessibilityUIElement::takeFocus):
3843         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3844         (WTR::AccessibilityUIElement::takeFocus):
3845
3846 2015-02-08  Darin Adler  <darin@apple.com>
3847
3848         Remove the SVG instance tree
3849         https://bugs.webkit.org/show_bug.cgi?id=140602
3850
3851         Reviewed by Dean Jackson.
3852
3853         * Scripts/check-for-global-initializers: Removed special case for
3854         SVGElementInstance.o.
3855
3856 2015-02-07  David Kilzer  <ddkilzer@apple.com>
3857
3858         [iOS] run-webkit-tests fails due to simulator devices from previous SDK installs being marked as unavailable
3859         <http://webkit.org/b/141365>
3860
3861         Reviewed by Daniel Bates.
3862
3863         * Scripts/webkitpy/xcode/simulator.py:
3864         (Simulator): Add unavailable_version_re precompiled regex.
3865         (Simulator._parse_devices): Check for unavailable versions and
3866         ignore them if found when parsing the output of
3867         `xcrun simctl list`.
3868         * Scripts/webkitpy/xcode/simulator_unittest.py:
3869         (test_unavailable_devices): Add test with output from
3870         `xcrun simctl list` with unavailable runtimes that fails before
3871         the fix.
3872
3873 2015-02-07  Chris Dumez  <cdumez@apple.com>
3874
3875         Add Vector::removeFirstMatching() / removeAllMatching() methods taking lambda functions
3876         https://bugs.webkit.org/show_bug.cgi?id=141321
3877
3878         Reviewed by Darin Adler.
3879
3880         Use new Vector::removeFirstMatching() / removeAllMatching() methods.
3881
3882 2015-02-07  David Kilzer  <ddkilzer@apple.com>
3883
3884         [iOS] Make Simulator class testable
3885         <http://webkit.org/b/141358>
3886
3887         Rubber-stamped by Darin Adler.
3888
3889         * Scripts/webkitpy/common/system/platforminfo.py:
3890         (PlatformInfo.xcode_simctl_list): Move `xcrun simctl list`
3891         command to here from Simulator.refresh() in xcode/simulator.py
3892         so that the output of the command can be mocked.
3893
3894         * Scripts/webkitpy/common/system/platforminfo_mock.py:
3895         (MockPlatformInfo.__init__): Set self.expected_xcode_simctl_list
3896         to None.
3897         (MockPlatformInfo.xcode_simctl_list): Add method that returns
3898         self.expected_xcode_simctl_list expectation.
3899
3900         * Scripts/webkitpy/xcode/simulator.py: Add missing copyright
3901         and license header.
3902         (Simulator.__init__): Add optional 'host' parameter to make it
3903         possible to pass in a mock object for testing.  Set self._host
3904         to 'host' parameter or create Host() object.
3905         (Simulator.refresh): Call new PlatformInfo.xcode_simctl_list()
3906         method.
3907
3908         * Scripts/webkitpy/xcode/simulator_unittest.py: Add unit test
3909         for current code.
3910         (SimulatorTest):
3911         (SimulatorTest.setUp):
3912         (SimulatorTest._set_expected_xcrun_simctl_list):
3913         (SimulatorTest.test_simulator_device_types):
3914         (test_invalid_device_types_header):
3915         (test_invalid_runtimes_header):
3916         (test_invalid_devices_header):
3917
3918 2015-02-07  Csaba Osztrogonác  <ossy@webkit.org>
3919
3920         run-jsc-stress-tests --remote should use the default ssh port
3921         https://bugs.webkit.org/show_bug.cgi?id=141287
3922
3923         Reviewed by Darin Adler.
3924
3925         * Scripts/run-jsc-stress-tests: Extended URI module to be able to handle ssh scheme with the default 22 port number.
3926
3927 2015-02-06  Dana Burkart  <dburkart@apple.com>
3928
3929         dashboard: BuildbotTesterQueueView crashesOnly logic is wrong
3930         https://bugs.webkit.org/show_bug.cgi?id=141349
3931
3932         Reviewed by Alexey Proskuryakov.
3933
3934         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3935         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
3936         (BuildbotTesterQueueView.prototype.update):
3937
3938 2015-02-06  Alexey Proskuryakov  <ap@apple.com>
3939
3940         Report network process crashes during layout tests
3941         https://bugs.webkit.org/show_bug.cgi?id=139646
3942
3943         Reviewed by Anders Carlsson.
3944
3945         * WebKitTestRunner/TestController.cpp:
3946         (WTR::TestController::initialize):
3947         (WTR::TestController::networkProcessName):
3948         (WTR::TestController::networkProcessDidCrash):
3949         * WebKitTestRunner/TestController.h:
3950
3951 2015-02-06  Csaba Osztrogonác  <ossy@webkit.org>
3952
3953         run-jsc-stress-tests --remote should create remote directory before copying the bundle
3954         https://bugs.webkit.org/show_bug.cgi?id=141329
3955
3956         Reviewed by Michael Saboff.
3957
3958         * Scripts/run-jsc-stress-tests:
3959
3960 2015-02-06  Carlos Garcia Campos  <cgarcia@igalia.com>
3961
3962         [GTK] Remove WebKitWebView::close-notification signal
3963         https://bugs.webkit.org/show_bug.cgi?id=141330
3964
3965         Reviewed by Gustavo Noronha Silva.
3966
3967         Update notifications unit tests according to the API changes, and
3968         add a test case to check that onclose event is fired when a
3969         notification is closed by the user.
3970
3971         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
3972         (testWebViewNotification):
3973
3974 2015-02-05  Alexey Proskuryakov  <ap@apple.com>
3975
3976         Dashboard doesn't consider building ASan a productive step
3977         https://bugs.webkit.org/show_bug.cgi?id=141312
3978
3979         Reviewed by Simon Fraser.
3980
3981         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3982
3983 2015-02-05  Daniel Bates  <dabates@apple.com>
3984
3985         [iOS] webkitpy.xcode.simulator.Runtime.from_identifier() returns wrong result for non-existent runtime
3986         https://bugs.webkit.org/show_bug.cgi?id=141306
3987
3988         Reviewed by Alexey Proskuryakov.
3989
3990         The function webkitpy.xcode.simulator.Runtime.from_identifier always returns a Runtime object
3991         corresponding to the last-most runtime parsed from the output of `simctl list` for any non-
3992         existent runtime.
3993
3994         * Scripts/webkitpy/xcode/simulator.py:
3995         (Runtime.from_identifier):
3996
3997 2015-02-05  Daniel Bates  <dabates@apple.com>
3998
3999         LayoutTestRelay does not install DumpRenderTree.app/WebKitTestRunnerApp.app
4000         https://bugs.webkit.org/show_bug.cgi?id=139746
4001         <rdar://problem/19283658>
4002
4003         Reviewed by Alexey Proskuryakov.
4004
4005         Fixes an issues where LayoutTestRelay may fail to install DumpRenderTree.app/WebKitTestRunnerApp.app
4006         if the simulator device is not in state Booted.
4007
4008         Currently run-webkit-test --ios-sim executes LayoutTestRelay immediately after
4009         launching/relaunching the iOS Simulator app and a simulator app can only be installed
4010         on a device that is in the Booted state. LayoutTestRelay may run before the
4011         device is booted and hence fail to install DumpRenderTree.app/WebKitTestRunnerApp.app.
4012         We should defer executing LayoutTestRelay until the simulator device booted by
4013         iOS Simulator is in the Booted state.
4014
4015         * Scripts/webkitpy/port/ios.py: Import webkitpy.xcode.simulator.Simulator to avoid prefixing
4016         Simulator methods with the module name, simulator.
4017         (IOSSimulatorPort.setup_test_run): Wait for the simulator device to be in the Booted state
4018         after launching iOS Simulator. Also, wait until the simulator device is in the Shutdown state
4019         before launching iOS Simulator to boot it.
4020         (IOSSimulatorPort.testing_device): Fix up caller since we now import webkitpy.xcode.simulator.Simulator.
4021         (IOSSimulatorPort.simulator_path): Deleted; moved this function to class Simulator and renamed to device_directory().
4022         * Scripts/webkitpy/xcode/simulator.py:
4023         (Device.__init__): Remove parameter state and an instance variable of the same name, which represented
4024         the state of the device when we created this object as part of parsing the output of `simctl list`. Callers
4025         interested in the state of the device are more likely interested in the current state of the device as
4026         opposed to the state of the device when the Device object was created.
4027         (Device.state): Added; turn around and call Simulator.device_state() for the current state of the device.
4028         (Device.path): Extracted implementation into Simulator.device_directory() so that it can be called
4029         from both this function and Simulator.device_state().
4030         (Device.create): Use Simulator.wait_until_device_is_in_state() to simplify the implementation of this function.
4031         (Simulator.DeviceState): Added; class of constants.
4032         (Simulator.wait_until_device_is_in_state): Added; this function does not return until the specified
4033         device is in the specified state.
4034         (Simulator.device_state): Added; parses the state of the device from the appropriate CoreSimulator device.plist file.
4035         (Simulator.device_directory): Added.
4036         (Simulator._parse_devices): Do not pass argument state to Device constructor as it no longer accepts it.
4037
4038 2015-02-05  Alexey Proskuryakov  <ap@apple.com>
4039
4040         Disable retries on Mac debug testers
4041         https://bugs.webkit.org/show_bug.cgi?id=141296
4042
4043         Reviewed by Simon Fraser.
4044
4045         * BuildSlaveSupport/build.webkit.org-config/config.json:
4046
4047 2015-02-05  Dan Bernstein  <mitz@apple.com>
4048
4049         Need a way to force $xcodeSDK in webkitdirs.pm
4050         https://bugs.webkit.org/show_bug.cgi?id=141291
4051
4052         Reviewed by Anders Carlsson.
4053
4054         * Scripts/webkitdirs.pm:
4055         (setXcodeSDK): Added.
4056
4057 2015-02-05  Youenn Fablet  <youenn.fablet@crf.canon.fr> and Xabier Rodriguez Calvar <calvaris@igalia.com>
4058
4059         [Streams API] Implement a barebone ReadableStream interface
4060         https://bugs.webkit.org/show_bug.cgi?id=141045
4061
4062         Reviewed by Benjamin Poulain.
4063
4064         * Scripts/webkitperl/FeatureList.pm: Added streams-api compilation switch.
4065
4066 2015-02-04  Joseph Pecoraro  <pecoraro@apple.com>
4067
4068         filter-build-webkit: reduce more unfiltered output
4069         https://bugs.webkit.org/show_bug.cgi?id=141282
4070
4071         Reviewed by Daniel Bates.
4072
4073         * Scripts/filter-build-webkit:
4074         Report CompileDTraceScript and Preprocess lines as successful.
4075
4076 2015-02-04  Dana Burkart  <dburkart@apple.com>
4077
4078         Botwatcher's Dashboard is cramped
4079         https://bugs.webkit.org/show_bug.cgi?id=140273
4080
4081         Reviewed by Alexey Proskuryakov.
4082
4083         Add a heading key which will allow for arbitrary headings in builder queues.
4084
4085         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
4086         (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus):
4087         (BuildbotBuilderQueueView.prototype.update):
4088         (BuildbotBuilderQueueView.prototype.update.appendBuildArchitecture): Deleted.
4089         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
4090         (BuildbotIteration.prototype._parseData):
4091         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotLeaksQueueView.js:
4092         (BuildbotLeaksQueueView.prototype.update):
4093         (BuildbotLeaksQueueView.prototype.update.appendBuild): Deleted.
4094         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotPerformanceQueueView.js:
4095         (BuildbotPerformanceQueueView.prototype.update):
4096         (BuildbotPerformanceQueueView.prototype.update.appendBuild): Deleted.
4097         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
4098         (BuildbotQueue):
4099         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
4100         (BuildbotQueueView.prototype._unauthorizedAccess):
4101         (BuildbotQueueView.prototype._appendBuild):
4102         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
4103         (BuildbotTestResults):
4104         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
4105         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
4106         (BuildbotTesterQueueView.prototype.update):
4107         (BuildbotTesterQueueView.prototype.update.appendBuild): Deleted.
4108
4109 2015-02-04  Simon Fraser  <simon.fraser@apple.com>
4110
4111         WKTR should not use -mainScreen to pick a color profile
4112         https://bugs.webkit.org/show_bug.cgi?id=141265
4113
4114         Reviewed by Tim Horton.
4115
4116         -[NSScreen mainScreen] depends on the active window, so use the first screen
4117         (which is the one we put the window on anyway).
4118
4119         Do some cleanup in DRT that makes the code look similar.
4120
4121         * DumpRenderTree/mac/DumpRenderTree.mm:
4122         (createWebViewAndOffscreenWindow):
4123         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
4124         (WTR::PlatformWebView::PlatformWebView):
4125
4126 2015-02-04  Simon Fraser  <simon.fraser@apple.com>
4127
4128         LayoutTestHelper should set the color profile of all displays
4129         https://bugs.webkit.org/show_bug.cgi?id=141260
4130
4131         Reviewed by Tim Horton.
4132
4133         WebKitTestRunner can (erroneously) grab the colorspace of the "main" screen.
4134         which is the screen with the active window. Make things more robust by changing
4135         the colorspace of all displays, not just the main screen, when running layout tests.
4136
4137         * DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig: Enable ARC
4138         * DumpRenderTree/mac/LayoutTestHelper.m:
4139         (originalColorProfileURLs):
4140         (colorProfileURLForDisplay):
4141         (displayUUIDStrings):
4142         (saveDisplayColorProfiles):
4143         (setDisplayColorProfile):
4144         (restoreDisplayColorProfiles):
4145         (installLayoutTestColorProfile):
4146         (restoreUserColorProfile):
4147         (main):
4148         Store display color profiles by map of UUID strings to URLs (NSUUID and CFUUID are not
4149         toll-free bridged, sadly). Use the map to restore all profiles on exit.
4150         Convert to use more Obj-C types.
4151
4152 2015-02-04  Daniel Bates  <dabates@apple.com>
4153
4154         test-webkitpy fails on Mac without iphoneos SDK
4155         https://bugs.webkit.org/show_bug.cgi?id=141255
4156         <rdar://problem/19619691>
4157
4158         I inadvertently committed the wrong exception message. Fix up the exception message
4159         to instruct a person to install the iOS SDK when it cannot be found.
4160
4161         * Scripts/webkitpy/port/ios.py:
4162         (IOSPort.determine_full_port_name):
4163
4164 2015-02-04  Youenn Fablet  <youenn.fablet@crf.canon.fr>
4165
4166         W3C test importer should sort the list of files when generating the w3c-import.log
4167         https://bugs.webkit.org/show_bug.cgi?id=141156
4168
4169         Reviewed by Bem Jones-Bey.
4170
4171         Sort explicitly the list of imported files written in the w3c-import.log.
4172         Removed logging of the import date.
4173
4174         * Scripts/webkitpy/w3c/test_importer.py:
4175         (TestImporter.write_import_log):
4176
4177 2015-02-04  Daniel Bates  <dabates@apple.com>
4178
4179         test-webkitpy fails on Mac without iphoneos SDK
4180         https://bugs.webkit.org/show_bug.cgi?id=141255
4181         <rdar://problem/19619691>
4182
4183         Reviewed by David Kilzer and Alexey Proskuryakov.
4184
4185         Fixes an issue where test-webkitpy fails on a Mac without the iOS SDK. We should
4186         should not require the iphoneos SDK to be installed to run the webkitpy tests.
4187
4188         * Scripts/webkitpy/common/system/platforminfo.py:
4189         (PlatformInfo.xcode_sdk_version): Added; return the version of the specified SDK, if
4190         installed. We take advantage of the behavior that xcrun --show-sdk-version only writes
4191         to standard output if the SDK is installed to return the empty string if the SDK is
4192         not installed.
4193         * Scripts/webkitpy/common/system/platforminfo_mock.py:
4194         (MockPlatformInfo.xcode_sdk_version): Added.
4195         * Scripts/webkitpy/port/ios.py:
4196         (IOSPort.determine_full_port_name): Modified to call PlatformInfo.xcode_sdk_version()
4197         to get the version of the iphoneos SDK, if installed.
4198
4199 2015-02-04  Alexey Proskuryakov  <ap@apple.com>
4200
4201         run-webkit-tests doesn't always capture ASan violation reports
4202         https://bugs.webkit.org/show_bug.cgi?id=141231
4203
4204         Reviewed by Darin Adler.
4205
4206         * Scripts/webkitpy/port/driver.py:
4207         (Driver.run_test): Don't look for CrashReporter crash logs if a log was provided
4208         by the driver already (as is the case with ASan violations, which are printed to
4209         stderr).
4210         (Driver._check_for_address_sanitizer_violation): Check if the line is a start of ASan
4211         report.
4212         (Driver._read_block): Give ASan enough time to symbolicate a crash, and put it into
4213         a separate variable for reporting.
4214
4215 2015-02-03  Ryosuke Niwa  <rniwa@webkit.org>
4216
4217         [webkitpy] Add platform specific Skipped file mechanism for performance tests
4218         https://bugs.webkit.org/show_bug.cgi?id=141152
4219
4220         Reviewed by Csaba Osztrogonác.
4221
4222         Support a test-expectation-like syntax in performance tests' skipped files.
4223         e.g. [Mac] Parsed/BadTest.html will skip Parsed/BadTest.html on Mac ports.
4224
4225         * Scripts/webkitpy/port/base.py:
4226         (Port.skipped_perf_tests): Implemented the syntax support by a regular expression.
4227
4228         * Scripts/webkitpy/port/base_unittest.py:
4229         (PortTest.test_skipped_perf_tests): Test the new syntax.
4230
4231 2015-02-04  Alexey Proskuryakov  <ap@apple.com>
4232
4233         When tests fail on leaks bot so much that there are no leaks detected, dashboard erroneously shows green
4234         https://bugs.webkit.org/show_bug.cgi?id=141236
4235
4236         Reviewed by Sam Weinig.
4237
4238         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotLeaksQueueView.js:
4239         (BuildbotLeaksQueueView.prototype.update.appendLeaksQueueStatus):
4240
4241 2015-02-04  Chris Dumez  <cdumez@apple.com>
4242
4243         Add removeFirst(value) / removeAll(value) methods to WTF::Vector
4244         https://bugs.webkit.org/show_bug.cgi?id=141192
4245
4246         Reviewed by Benjamin Poulain.
4247
4248         Add API tests for Vector::removeFirst(value) and
4249         Vector::removeAll(value).
4250
4251         * TestWebKitAPI/Tests/WTF/Vector.cpp:
4252         (TestWebKitAPI::TEST):
4253
4254 2015-02-03  Tim Horton  <timothy_horton@apple.com>
4255
4256         Add WKPageNavigationClient as C SPI around API::NavigationClient, and adopt in WKTR
4257         https://bugs.webkit.org/show_bug.cgi?id=141217
4258
4259         Reviewed by Sam Weinig.
4260
4261         * WebKitTestRunner/TestController.cpp:
4262         (WTR::copyWebCryptoMasterKey):
4263         (WTR::TestController::createOtherPage):
4264         (WTR::TestController::createWebViewWithOptions):
4265         (WTR::TestController::ensureViewSupportsOptions):
4266         (WTR::TestController::didCommitNavigation):
4267         (WTR::TestController::didFinishNavigation):
4268         (WTR::TestController::canAuthenticateAgainstProtectionSpace):
4269         (WTR::TestController::didReceiveAuthenticationChallenge):
4270         (WTR::TestController::decidePolicyForPluginLoad):
4271         (WTR::TestController::decidePolicyForNavigationAction):
4272         (WTR::TestController::decidePolicyForNavigationResponse):
4273         (WTR::TestController::didCommitLoadForFrame): Deleted.
4274         (WTR::TestController::didFinishLoadForFrame): Deleted.
4275         * WebKitTestRunner/TestController.h:
4276         Adopt WKPageNavigationClient and adjust to its semantics (navigations are main-frame-only, etc.)
4277
4278 2015-02-03  Dhi Aurrahman  <diorahman@rockybars.com>
4279
4280         Unreviewed. Add myself as a committer.
4281
4282         * Scripts/webkitpy/common/config/contributors.json:
4283
4284 2015-02-03  Brent Fulgham  <bfulgham@apple.com>
4285
4286         [Win] Unreviewed test fix.
4287
4288         * DumpRenderTree/win/PolicyDelegate.cpp:
4289         (PolicyDelegate::unableToImplementPolicyWithError): The message was missing a linefeed,
4290         so was not matching expected output.
4291
4292 2015-02-03  Youenn Fablet  <youenn.fablet@crf.canon.fr>
4293
4294         Unreviewed. Moving myself to the committer section at last.
4295
4296         * Scripts/webkitpy/common/config/contributors.json:
4297
4298 2015-02-03  Brent Fulgham  <bfulgham@apple.com>
4299
4300         [Win] Tests fail because DRT reports '(null)' instead of an empty string
4301         https://bugs.webkit.org/show_bug.cgi?id=141205
4302
4303         Reviewed by Anders Carlsson.
4304
4305         * DumpRenderTree/win/HistoryDelegate.cpp:
4306         (HistoryDelegate::didNavigateWithNavigationData): Deal with empty BSTR values
4307         properly so that we match expected DumpRenderTree output.
4308
4309 2015-02-03  Michael Catanzaro  <mcatanzaro@igalia.com>
4310
4311         [GTK] TestWebKitAccessibility is not skipped
4312         https://bugs.webkit.org/show_bug.cgi?id=141179
4313
4314         Reviewed by Carlos Garcia Campos.
4315
4316         Don't attempt to skip TestWebKitAccessibility. This path is wrong so it was not being
4317         skipped, and it apparently works reliably on the bots.
4318
4319         * Scripts/run-gtk-tests:
4320         (TestRunner):
4321
4322 2015-02-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
4323
4324         run-perf-tests: allow to specify a wrapper command.
4325         https://bugs.webkit.org/show_bug.cgi?id=141172
4326
4327         Reviewed by Ryosuke Niwa.
4328
4329         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4330         (parse_args): Update text to indicate is also valid for WTR.
4331         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
4332         (PerfTestsRunner._parse_args): Add wrapper command.
4333
4334 2015-02-03  Brent Fulgham  <bfulgham@apple.com>
4335
4336         [Win] Correct version parsing warning in update-webkit
4337         https://bugs.webkit.org/show_bug.cgi?id=141200
4338
4339         Reviewed by Anders Carlsson.
4340