1 2015-09-07 Hunseop Jeong <hs85.jeong@samsung.com>
3 [EFL] Many of the css3/device-adapt/* tests failed after r188548.
4 https://bugs.webkit.org/show_bug.cgi?id=148927
6 Reviewed by Csaba Osztrogonác.
8 device-adapt/* tests need the fixedLayout option but useFixedLayout option is
9 overwritten by updatePlatformSpecificViewOptionsForTest after r188548.
11 * WebKitTestRunner/TestController.cpp:
12 (WTR::shouldUseFixedLayout): Removed the unnecessary indentations.
13 * WebKitTestRunner/efl/TestControllerEfl.cpp:
14 (WTR::shouldUseFixedLayout): Return true if the test is related with 'device-adapt'.
16 2015-09-07 Andy Estes <aestes@apple.com>
18 Fix the Production build after r189455.
20 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Somehow I added the All target using the
21 In-App Purchase template instead of the Aggregate template. Whoops.
23 2015-09-06 Andy Estes <aestes@apple.com>
25 WebKit.xcworkspace should be be able to build iOS platforms
26 https://bugs.webkit.org/show_bug.cgi?id=148881
28 Reviewed by Daniel Bates.
30 Since we don't want to create platform-specific schemes, all projects in the workspace's schemes need to build
31 for all supported platforms.
33 * MiniBrowser/Configurations/Base.xcconfig: Included iphoneos and iphonesimulator in SUPPORTED_PLATFORMS.
34 * MiniBrowser/Configurations/MiniBrowser.xcconfig: Excluded all source files on iOS, and linked Cocoa and WebKit on Mac.
35 * MiniBrowser/Configurations/MiniBrowserBundle.xcconfig: Ditto.
36 * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Stopped linking frameworks in Link Binaries With Libraries.
38 2015-09-06 Andy Estes <aestes@apple.com>
40 WebKitTestRunner should build for iOS using the default target
41 https://bugs.webkit.org/show_bug.cgi?id=148918
43 Reviewed by Daniel Bates.
45 When WebKitTestRunner was ported to iOS, a separate target (WebKitTestRunnerApp) was created for building the
46 iOS variant. This is annoying because (1) all tools that invoke xcodebuild need to be taught to build this
47 non-default target, and (2) a single Xcode scheme cannot be used to build both Mac and iOS variants.
49 This change adds a new default target (All) and makes it work for both Mac and iOS. Files that were built for
50 both WebKitTestRunner and WebKitTestRunnerApp are now built in a static library target (WebKitTestRunner (Library)),
51 and both apps now link this library. Files that are specific to Mac or iOS are excluded on the other platform.
52 WebKitTestRunnerApp.app (which should be renamed to WebKitTestRunner.app) is skipped when installing on Mac, and
53 WebKitTestRunner is skipped when installing on iOS.
55 The target dependency graph now looks like this:
59 WebKitTestRunner (Library)
60 WebKitTestRunnerInjectedBundle
63 WebKitTestRunner (Library)
64 WebKitTestRunnerInjectedBundle
67 * Scripts/build-webkit: Stopped building the WebKitTestRunnerApp target on iOS.
68 * Scripts/build-webkittestrunner: Ditto.
69 * WebKitTestRunner/Configurations/Base.xcconfig: Set SUPPORTED_PLATFORMS to macosx, iphoneos, and iphonesimulator.
70 * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Set INSTALL_PATH here since it is the same for all targets.
71 * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Stopped setting INSTALL_PATH.
72 * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig: Moved frameworks from the build phase to here,
73 excluded iOS-only files, and skipped installing on iOS.
74 * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: Moved frameworks from the build phase to here,
75 excluded Mac-only files, and skipped installing on Mac.
76 * WebKitTestRunner/Configurations/WebKitTestRunnerLibrary.xcconfig: Skipped installing always.
77 * WebKitTestRunner/Makefile: Stopped building the WebKitTestRunnerApp target on iOS.
78 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Added new targets, removed frameworks from
79 Link Binary With Libraries builds phases, moved common files to the WebKitTestRunner (Library) target, and added
80 new configuration files.
82 2015-09-05 Joseph Pecoraro <pecoraro@apple.com>
84 Web Inspector: Improve prepare-ChangeLog for multiple cases
85 https://bugs.webkit.org/show_bug.cgi?id=148875
87 Reviewed by Timothy Hatcher.
89 * Scripts/prepare-ChangeLog:
90 (get_function_line_ranges_for_javascript):
91 - We were ignoring everything inside of an anonymous function expression,
92 such as (function(){ ... }), which made InjectedScriptSource produce nothing.
93 Better handle this by inserting a few tweaks.
94 - Allow method syntax outside of classes as long as they are at the global level.
95 - Avoid treating "get" and "set" as getter/setter functions in bad contexts.
97 * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests-expected.txt:
98 * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests.js:
99 (Foo.prototype.method1):
100 (Foo.prototype.method2):
101 (Foo.prototype.method3.innerFunction):
102 (Foo.prototype.method3):
103 (insideGlobalAnonymousFunctionExpression):
104 (foo.insideGlobalFunctionExpression):
105 (IssueWithMapGetAndSet.prototype.method1.nestedFunctionInsideMethod1):
106 (IssueWithMapGetAndSet.prototype.method1):
107 (IssueWithMapGetAndSet.prototype.method2):
108 (IssueWithMapGetAndSet.prototype.method3):
109 (IssueWithMapGetAndSet):
111 2015-09-05 Yusuke Suzuki <utatane.tea@gmail.com>
113 [ES6] Enable ES6 Module in JSC shell by default
114 https://bugs.webkit.org/show_bug.cgi?id=148689
116 Reviewed by Geoffrey Garen.
118 * Scripts/run-javascriptcore-tests:
120 * Scripts/run-jsc-stress-tests:
122 2015-09-04 Basile Clement <basile_clement@apple.com>
124 Unreviewed, change my email address.
126 * Scripts/webkitpy/common/config/contributors.json:
128 2015-09-04 Beth Dakin <bdakin@apple.com>
130 Should have a test to make sure links don't navigate after a cancelled force
132 https://bugs.webkit.org/show_bug.cgi?id=148846
134 Reviewed by Tim Horton.
136 New EventSender function for a started then cancelled force click.
137 * WebKitTestRunner/EventSenderProxy.h:
138 * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
139 * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
140 (WTR::EventSendingController::mouseForceClick):
141 (WTR::EventSendingController::startAndCancelMouseForceClick):
142 (WTR::EventSendingController::mouseForceDown):
143 * WebKitTestRunner/InjectedBundle/EventSendingController.h:
144 * WebKitTestRunner/TestController.cpp:
145 (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
146 * WebKitTestRunner/mac/EventSenderProxy.mm:
147 (WTR::EventSenderProxy::mouseForceClick):
148 (WTR::EventSenderProxy::startAndCancelMouseForceClick):
149 (WTR::EventSenderProxy::mouseForceDown):
150 (WTR::EventSenderProxy::mouseMoveTo):
152 2015-09-04 Tim Horton <timothy_horton@apple.com>
154 Add a test for r179736 (programmatic navigation during swipe causing a crash)
155 https://bugs.webkit.org/show_bug.cgi?id=148830
157 Reviewed by Beth Dakin.
159 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
160 (WTR::InjectedBundle::beginTesting):
161 Make sure that TestRunner callbacks don't leak between tests!
163 2015-09-04 Anders Carlsson <andersca@apple.com>
165 It should be possible to pass relative HTTP test paths to DumpRenderTree
166 https://bugs.webkit.org/show_bug.cgi?id=148825
167 <rdar://problem/22583866>
169 Reviewed by Tim Horton.
171 Convert the path to an absolute path if needed.
173 * DumpRenderTree/mac/DumpRenderTree.mm:
176 2015-09-04 Jason Marcell <jmarcell@apple.com>
178 Fix Swift unit tests for prepare-ChangeLog.
179 https://bugs.webkit.org/show_bug.cgi?id=148817
181 Reviewed by Alexey Proskuryakov.
183 * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/swift_unittests-expected.txt: Fixed
184 Swift unit tests for prepare-ChangeLog.
186 2015-09-04 Lucas Forschler <lforschler@apple.com>
188 Modifications to the webkit-nightly logic.
190 * WebKitLauncher/WebKitNightlyEnablerSparkle.m:
192 * WebKitLauncher/main.m:
193 (displayErrorAndQuit):
195 2015-09-04 Beth Dakin <bdakin@apple.com>
197 Speculative build fix.
199 * WebKitTestRunner/mac/EventSenderProxy.mm:
201 2015-09-04 Brian Burg <bburg@apple.com>
203 Web Inspector: InspectorController should support multiple frontend channels
204 https://bugs.webkit.org/show_bug.cgi?id=148538
206 Reviewed by Joseph Pecoraro.
208 InspectorClients must explicitly disconnect their frontend channel(s) from the
209 inspected page's InspectorController.
211 To make this possible, DumpRenderTree should not destroy non-primary views until
212 it has tried to close any abandoned Web Inspector instances. Performing teardown
213 in the reverse order prevents disconnection of the frontend channel because that
214 prematurely destroys the inspector frontend client.
216 * DumpRenderTree/mac/DumpRenderTree.mm:
218 * DumpRenderTree/win/DumpRenderTree.cpp:
221 2015-09-04 Beth Dakin <bdakin@apple.com>
223 Need to be able to test default behaviors on force click
224 https://bugs.webkit.org/show_bug.cgi?id=148758
226 Reviewed by Tim Horton.
228 This patch adds a new eventSender method to do a full, completed force click,
229 and it re-works all of the existing force methods to dispatch their events in
230 such a way that they will trigger the NSImmediateAction gesture recognizer.
231 To do this, first we need to send the events to the app rather than straight
232 to the view, and also needed to tweak some state and send the events in a
235 New public function mouseForceClick() and private helper functions to make
237 * WebKitTestRunner/EventSenderProxy.h:
239 New public function mouseForceClick().
240 * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
241 * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
242 (WTR::EventSendingController::mouseMoveTo):
243 (WTR::EventSendingController::mouseForceClick):
244 (WTR::EventSendingController::mouseForceDown):
245 * WebKitTestRunner/InjectedBundle/EventSendingController.h:
246 * WebKitTestRunner/TestController.cpp:
247 (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
249 initPressureEventAtLocation needs to take a stageTransition and a window.
250 * WebKitTestRunner/mac/EventSenderProxy.mm:
251 (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
252 (-[EventSenderSyntheticEvent stageTransition]):
253 (-[EventSenderSyntheticEvent timestamp]):
254 (-[EventSenderSyntheticEvent _cgsEventRecord]):
255 (-[EventSenderSyntheticEvent window]):
257 In order to enter the gesture recognizer, we need to start with a mouse down
258 that has a NSEventMaskPressure modifier.
259 (WTR::EventSenderProxy::sendMouseDownToStartPressureEvents):
261 This ensures that the events queue properly for the force monitor in AppKit.
262 (WTR::spinRunLoopForForce):
264 We need to start the pressure change events with a began.
265 (WTR::EventSenderProxy::beginPressureEvent):
267 These functions can be used to create the NSEvent for a pressure change every
269 (WTR::EventSenderProxy::pressureChangeEvent):
271 Send the right series of events to emulate a full, completed force click.
272 (WTR::EventSenderProxy::mouseForceClick):
274 Use all of the new things for these existing functions.
275 (WTR::EventSenderProxy::mouseForceDown):
276 (WTR::EventSenderProxy::mouseForceUp):
277 (WTR::EventSenderProxy::mouseForceChanged):
279 Set NSFakeForceTouchDevice to YES.
280 * WebKitTestRunner/mac/main.mm:
281 (setDefaultsToConsistentValuesForTesting):
283 2015-09-04 Jason Marcell <jmarcell@apple.com>
285 prepare-ChangeLog needs to know how to parse Swift files.
286 https://bugs.webkit.org/show_bug.cgi?id=148784
287 <rdar://problem/22510062>
289 Reviewed by Darin Adler.
291 * Scripts/prepare-ChangeLog:
292 (get_function_line_ranges): Added entry for get_function_line_ranges_for_swift.
293 (get_function_line_ranges_for_swift): Added function that knows how to parse Swift code.
294 (parseSwiftFunctionArgs): Added function that knows how to parse Swift function arguments.
295 * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl: Added.
296 * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/swift_unittests-expected.txt: Ditto.
297 * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/swift_unittests.swift: Ditto.
298 (freeFunction): Ditto.
299 (MyClass.function): Ditto.
300 (MyClass.functionWithArgument(_:)): Ditto.
301 (MyClass.functionWithMoreArguments(_:arg2:)): Ditto.
302 (MyClass.functionWithNamedFirstArgument(argument:)): Ditto.
303 (MyClass.functionWithNamedFirstAndSecondArgument(first:second:)): Ditto.
304 (MyClass.classFunction): Ditto.
305 (MyClass.readWriteComputedVariable): Ditto.
306 (MyClass.readOnlyComputedVariable): Ditto.
308 2015-09-04 Ryosuke Niwa <rniwa@webkit.org>
310 Import css/css-color-3
311 https://bugs.webkit.org/show_bug.cgi?id=148803
313 Reviewed by Chris Dumez.
315 Fixed a bug that the imported reference files used the same extention as tests.
316 This would result in parsing errors if the tests were XML and references were HTML and vice versa.
318 * Scripts/webkitpy/w3c/test_importer.py:
319 (TestImporter.find_importable_tests):
321 2015-09-03 Commit Queue <commit-queue@webkit.org>
323 Unreviewed, rolling out r189338.
324 https://bugs.webkit.org/show_bug.cgi?id=148785
326 Caused tons of crashes (Requested by cdumez on #webkit).
330 "Web Inspector: InspectorController should support multiple
332 https://bugs.webkit.org/show_bug.cgi?id=148538
333 http://trac.webkit.org/changeset/189338
335 2015-09-03 Brian Burg <bburg@apple.com>
337 Web Inspector: InspectorController should support multiple frontend channels
338 https://bugs.webkit.org/show_bug.cgi?id=148538
340 Reviewed by Joseph Pecoraro.
342 InspectorClients must explicitly disconnect their frontend channel(s) from the
343 inspected page's InspectorController.
345 To make this possible, DumpRenderTree should not destroy non-primary views until
346 it has tried to close any abandoned Web Inspector instances. Performing teardown
347 in the reverse order prevents disconnection of the frontend channel because that
348 prematurely destroys the inspector frontend client.
350 * DumpRenderTree/mac/DumpRenderTree.mm:
352 * DumpRenderTree/win/DumpRenderTree.cpp:
355 2015-09-03 Timothy Hatcher <timothy@apple.com>
357 Update WebKit nightly icon to be more like Safari
358 https://bugs.webkit.org/show_bug.cgi?id=148768
360 Reviewed by Joseph Pecoraro.
362 * WebKitLauncher/webkit.icns:
364 2015-09-03 Geoffrey Garen <ggaren@apple.com>
366 JavaScriptCore should have some ES6 conformance tests
367 https://bugs.webkit.org/show_bug.cgi?id=148771
369 Reviewed by Chris Dumez.
371 * Scripts/run-javascriptcore-tests:
372 (runJSCStressTests): Added es6 as a test suite.
374 * Scripts/run-jsc-stress-tests: Added es6 as a test suite.
376 Some of these tests currently fail, so I also added a way to expect
377 failure for now. We'll migrate failing tests to expected passes as we
380 2015-09-03 Tim Horton <timothy_horton@apple.com>
382 Add a test for swipe-start hysteresis
383 https://bugs.webkit.org/show_bug.cgi?id=148756
385 Reviewed by Anders Carlsson.
387 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
388 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
389 (WTR::cacheTestRunnerCallback):
390 (WTR::TestRunner::clearTestRunnerCallbacks):
391 * WebKitTestRunner/InjectedBundle/TestRunner.h:
392 Make sure that we log if a client tries to install a callback twice
393 (since we use .add, the second call would not work).
395 Also, add clearTestRunnerCallbacks so tests can swap out installed
398 2015-09-03 Anders Carlsson <andersca@apple.com>
400 DumpRenderTree should automatically compute HTTP URLs for HTTP tests
401 https://bugs.webkit.org/show_bug.cgi?id=148746
402 rdar://problem/22568073
404 Reviewed by Tim Horton.
406 * DumpRenderTree/mac/DumpRenderTree.mm:
408 Compute the test URL from the passed in path or URL. Special-case paths that contain /LayoutTests/http/tests.
414 Get rid of this; computeTestURL does this for us now.
416 * Scripts/webkitpy/port/driver.py:
417 (Driver._command_from_driver_input):
418 Don't convert HTTP test paths to URLS before passing them to DumpRenderTree on Mac. That's handled by DRT itself now.
420 2015-09-03 Tim Horton <timothy_horton@apple.com>
422 Swipe tests fail on Mavericks
423 https://bugs.webkit.org/show_bug.cgi?id=148752
425 Reviewed by Beth Dakin.
427 * WebKitTestRunner/mac/EventSenderProxy.mm:
429 2015-09-03 Tim Horton <timothy_horton@apple.com>
433 * WebKitTestRunner/mac/PlatformWebViewMac.mm:
434 (WTR::PlatformWebView::setNavigationGesturesEnabled):
436 2015-09-03 Tim Horton <timothy_horton@apple.com>
438 Remove some logging that wasn't meant to be in the tree
440 * WebKitTestRunner/mac/EventSenderProxy.mm:
441 (WTR::EventSenderProxy::swipeGestureWithWheelAndMomentumPhases):
443 2015-09-03 Tim Horton <timothy_horton@apple.com>
445 [Mac] Add support for testing swipes
446 https://bugs.webkit.org/show_bug.cgi?id=148700
448 Reviewed by Beth Dakin.
450 * WebKitTestRunner/EventSenderProxy.h:
451 * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
452 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
453 * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
454 (WTR::cgEventPhaseFromString):
455 (WTR::cgEventMomentumPhaseFromString):
456 (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
457 (WTR::EventSendingController::swipeGestureWithWheelAndMomentumPhases):
458 * WebKitTestRunner/InjectedBundle/EventSendingController.h:
459 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
460 (WTR::InjectedBundle::didReceiveMessageToPage):
461 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
462 (WTR::TestRunner::installDidBeginSwipeCallback):
463 (WTR::TestRunner::installWillEndSwipeCallback):
464 (WTR::TestRunner::installDidEndSwipeCallback):
465 (WTR::TestRunner::installDidRemoveSwipeSnapshotCallback):
466 (WTR::TestRunner::callDidBeginSwipeCallback):
467 (WTR::TestRunner::callWillEndSwipeCallback):
468 (WTR::TestRunner::callDidEndSwipeCallback):
469 (WTR::TestRunner::callDidRemoveSwipeSnapshotCallback):
470 * WebKitTestRunner/InjectedBundle/TestRunner.h:
471 * WebKitTestRunner/TestController.cpp:
472 (WTR::TestController::createOtherPage):
473 (WTR::TestController::createWebViewWithOptions):
474 (WTR::TestController::didReceiveMessageFromInjectedBundle):
475 (WTR::TestController::didBeginNavigationGesture):
476 (WTR::TestController::willEndNavigationGesture):
477 (WTR::TestController::didEndNavigationGesture):
478 (WTR::TestController::didRemoveNavigationGestureSnapshot):
479 * WebKitTestRunner/TestController.h:
480 * WebKitTestRunner/TestInvocation.cpp:
481 (WTR::TestInvocation::didBeginSwipe):
482 (WTR::TestInvocation::willEndSwipe):
483 (WTR::TestInvocation::didEndSwipe):
484 (WTR::TestInvocation::didRemoveSwipeSnapshot):
485 * WebKitTestRunner/TestInvocation.h:
486 Add callbacks when navigation gestures didBegin/willEnd/didEnd, and
487 when the snapshot is removed.
489 Add swipeGestureWithWheelAndMomentumPhases, just like the equivalent
490 mouseScrollBy function.
492 * WebKitTestRunner/mac/EventSenderProxy.mm:
493 (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:phase:time:eventNumber:]):
494 (-[EventSenderSyntheticEvent type]):
495 (-[EventSenderSyntheticEvent subtype]):
496 (-[EventSenderSyntheticEvent locationInWindow]):
497 (-[EventSenderSyntheticEvent location]):
498 (-[EventSenderSyntheticEvent momentumPhase]):
499 (-[EventSenderSyntheticEvent _isTouchesEnded]):
500 (-[EventSenderSyntheticEvent _cgsEventRecord]):
501 Rename EventSenderPressureEvent to EventSenderSyntheticEvent and add some
502 more adjustable values.
504 (WTR::EventSenderProxy::mouseForceDown):
505 (WTR::EventSenderProxy::mouseForceUp):
506 (WTR::EventSenderProxy::mouseForceChanged):
507 Adopt EventSenderSyntheticEvent.
509 (WTR::nsEventPhaseFromCGEventPhase):
510 (WTR::EventSenderProxy::swipeGestureWithWheelAndMomentumPhases):
511 Make use of EventSenderSyntheticEvent to synthesize swipe gesture events.
513 * WebKitTestRunner/mac/PlatformWebViewMac.mm:
514 (WTR::PlatformWebView::PlatformWebView):
517 2015-09-03 Myles C. Maxfield <mmaxfield@apple.com>
519 [WK2] Allow tagging tests with metadata which needs to be known at web process creation time
520 https://bugs.webkit.org/show_bug.cgi?id=148723
522 Reviewed by Anders Carlsson.
524 * WebKitTestRunner/TestController.cpp:
526 (WTR::updateViewOptionsFromTestHeader):
527 (WTR::TestController::viewOptionsForTest):
529 2015-09-03 Lucas Forschler <lforschler@apple.com>
533 2015-09-02 Tim Horton <timothy_horton@apple.com>
535 Add a modern API way to know that the navigation gesture snapshot was removed, for WebKitTestRunner
536 https://bugs.webkit.org/show_bug.cgi?id=148693
538 Reviewed by Anders Carlsson.
540 * WebKitTestRunner/TestController.cpp:
541 (WTR::TestController::createOtherPage):
542 (WTR::TestController::createWebViewWithOptions):
544 2015-09-02 Carlos Garcia Campos <cgarcia@igalia.com>
546 REGRESSION(r188548): Some tests crash after r188548 because injected bundle messages are received after the test finishes
547 https://bugs.webkit.org/show_bug.cgi?id=148529
549 Reviewed by Darin Adler.
551 When there are pending EventSender messages after a test finishes,
552 they could be processed in the main loop started by the
553 resetStateToConsistentValues(), but the old EventSender has been
554 replaced by a new one at that point. The new Eventsender can crash
555 when processing messages that were sent to the old one. To avoid
556 this, we return early when receiving an EventSender message and
557 the TestController state is not RunningTest.
559 * WebKitTestRunner/TestController.cpp:
560 (WTR::TestController::didReceiveKeyDownMessageFromInjectedBundle):
561 (WTR::TestController::didReceiveMessageFromInjectedBundle):
563 2015-09-02 Carlos Garcia Campos <cgarcia@igalia.com>
565 REGRESSION(r188548): TestController state is Resseting while tests are running after r188548
566 https://bugs.webkit.org/show_bug.cgi?id=148528
568 Reviewed by Darin Adler.
570 Before r188548 resetStateToConsistentValues() was called in
571 TestController::run(), before tests are run, but now it's called
572 for every test in TestInvocation::invoke(), after m_status has
573 changed to RunningTest.
575 * WebKitTestRunner/TestController.cpp:
576 (WTR::TestController::resetStateToConsistentValues): Use
577 TemporaryChange to reset m_state ot its previous value after reset
580 2015-08-31 Jason Marcell <jmarcell@apple.com>
582 Modify prepare-Changelog to be aware of files that are marked as tests as well as files
583 that are marked as requiring corresponding tests.
584 https://bugs.webkit.org/show_bug.cgi?id=148498
585 <rdar://problem/21555314>
587 Reviewed by Dan Bernstein and David Kilzer.
589 * Scripts/prepare-ChangeLog: Added "attributeCache" to cache Subversion properties in order to
590 simulate Git's attribute behevaior.
591 (main): Added "requiresTests" array to contain files that require tests.
592 (generateNewChangeLogs): Checks "requiresTests" array to determine whether to inject "tests"
593 section in ChangeLog.
594 (attributeCommand): Queries a given file for a given Git attribute value. If using Subversion,
595 however, we check if the file or any containing folder has the given property set to "1" and
596 return 1 if so; return 0 otherwise.
597 (generateFileList): Adds files to "requiresTests" array if Git attribute is set to "1". Also
598 adds files to "addedRegressionTests" array if "test" attribute is set to "1".
600 2015-08-26 Andy Estes <aestes@apple.com>
602 [Content Filtering] Determine navigation and content policy before continuing to filter a load
603 https://bugs.webkit.org/show_bug.cgi?id=148506
605 Reviewed by Brady Eidson.
607 Added download API tests covering every decision and decision point.
608 Removed _WKDownload.AsynchronousDownloadPolicy in favor of these new tests.
610 * TestWebKitAPI/Configurations/Base.xcconfig: Added $(BUILT_PRODUCTS_DIR)/WebCoreTestSupport to the header search path.
611 * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Removed it from here.
612 * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParametersPlugIn.mm:
613 (-[BundleParametersPlugIn observeValueForKeyPath:ofObject:change:context:]): Called -valueForKeyPath:, which
614 returns an id, instead of -valueForKey:, which always returns an NSString even if the object is of another type.
615 * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm: Added a class that can send a MockContentFilter
616 decision and decision point as a bundle parameter.
617 (+[MockContentFilterEnabler supportsSecureCoding]):
618 (-[MockContentFilterEnabler copyWithZone:]):
619 (-[MockContentFilterEnabler initWithCoder:]):
620 (-[MockContentFilterEnabler initWithDecision:decisionPoint:]):
621 (-[MockContentFilterEnabler encodeWithCoder:]):
622 (configurationWithContentFilterSettings): Added a helper function to create a WKWebViewConfiguration with MockConentFilter settings.
623 (TEST): Renamed ContentFiltering.ServerRedirect to ContentFiltering.URLAfterServerRedirect.
624 (-[BecomeDownloadDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Decided _WKNavigationResponsePolicyBecomeDownload.
625 (-[BecomeDownloadDelegate webView:didFailProvisionalNavigation:withError:]): Set isDone to true.
626 (-[BecomeDownloadDelegate webView:didFinishNavigation:]): Ditto.
627 (-[ContentFilteringDownloadDelegate _downloadDidStart:]): Set downloadDidStart to true.
628 (downloadTest): Added a helper function to test downloads with a given decision and decision point.
629 * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm: Added a corresponding bundle class that decodes
630 the MockContentFilter decision and decision point, and sets these values in the MockContentFilterSettings
631 singleton. This class is duplicated in the bundle to prevent TestWebKitAPI from having to link to WebCoreTestSupport.
632 (+[MockContentFilterEnabler supportsSecureCoding]):
633 (-[MockContentFilterEnabler copyWithZone:]):
634 (-[MockContentFilterEnabler initWithCoder:]):
635 (-[MockContentFilterEnabler dealloc]):
636 (-[MockContentFilterEnabler encodeWithCoder:]):
637 (-[ContentFilteringPlugIn webProcessPlugIn:initializeWithObject:]): Start observing changes to the MockContentFilterEnabler key path.
638 (-[ContentFilteringPlugIn dealloc]): Stop observing.
639 (-[ContentFilteringPlugIn observeValueForKeyPath:ofObject:change:context:]): Store a MockContentFilterEnabler in _contentFilterEnabler.
640 (+[ServerRedirectPlugIn initialize]): Deleted.
641 * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
642 (-[AsynchronousDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
643 (-[AsynchronousDownloadDelegate _downloadDidStart:]): Deleted.
646 2015-08-31 Filip Pizlo <fpizlo@apple.com>
648 Skip slow lock tests on Windows/debug
649 https://bugs.webkit.org/show_bug.cgi?id=148643
651 Reviewed by Alexey Proskuryakov.
653 The lock tests simulate a critical section by doing some floating point math, and then either
654 make those critical sections very long or invoke them many times. This appears to be
655 particularly slow on Windows in debug mode, maybe because Visual Studio's debug build makes
656 that kind of computation slow.
658 These tests are almost as useful in release as they are in debug, so it's probably better to
659 just skip the in debug on platforms where this causes timeouts.
661 * TestWebKitAPI/Tests/WTF/Lock.cpp:
662 (TestWebKitAPI::runLockTest):
663 (TestWebKitAPI::skipSlow):
664 (TestWebKitAPI::TEST):
666 2015-08-29 Chris Fleizach <cfleizach@apple.com>
668 AX: When navigating the elements of a scrollable element with VoiceOver, the scrollTop() position of the element does not permanently change
669 https://bugs.webkit.org/show_bug.cgi?id=125720
671 Reviewed by Daniel Bates.
673 Add support for scrollToMakeVisibleWithSubFocus and scrollToGlobalPoint.
675 * DumpRenderTree/AccessibilityUIElement.cpp:
677 (scrollToMakeVisibleWithSubFocusCallback):
678 (scrollToGlobalPointCallback):
679 (scrollToMakeVisibleCallback):
680 (AccessibilityUIElement::getJSClass):
681 * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
682 (AccessibilityUIElement::scrollToMakeVisible):
683 (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
684 (AccessibilityUIElement::scrollToGlobalPoint):
685 (AccessibilityUIElement::selectedTextRange):
686 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
687 (AccessibilityUIElement::AccessibilityUIElement):
688 (AccessibilityUIElement::mathPrescriptsDescription):
689 (AccessibilityUIElement::scrollToMakeVisible):
690 (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
691 (AccessibilityUIElement::scrollToGlobalPoint):
692 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
693 (WTR::AccessibilityUIElement::isTextMarkerValid):
694 (WTR::AccessibilityUIElement::textMarkerForIndex):
695 (WTR::AccessibilityUIElement::scrollToMakeVisible):
696 (WTR::AccessibilityUIElement::scrollToGlobalPoint):
697 (WTR::AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
698 (WTR::AccessibilityUIElement::supportedActions):
699 (WTR::AccessibilityUIElement::mathPostscriptsDescription):
700 (WTR::AccessibilityUIElement::mathPrescriptsDescription):
701 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
702 * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
703 * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
704 (WTR::AccessibilityUIElement::scrollToMakeVisible):
705 (WTR::AccessibilityUIElement::scrollToGlobalPoint):
706 (WTR::AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
707 (WTR::AccessibilityUIElement::selectedTextRange):
708 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
709 (WTR::AccessibilityUIElement::scrollToMakeVisible):
710 (WTR::AccessibilityUIElement::scrollToGlobalPoint):
711 (WTR::AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
712 (WTR::AccessibilityUIElement::selectedTextRange):
714 2015-08-28 Timothy Horton <timothy_horton@apple.com>
716 Add a mysteriously nonproblematic missing comma.
718 * Scripts/webkitpy/layout_tests/models/test_expectations.py:
719 (TestExpectationParser._collect_matching_tests):
720 (TestExpectationParser):
722 2015-08-28 Timothy Horton <timothy_horton@apple.com>
724 Remove an old temporary script that has served its purpose
726 * Scripts/convert-test-expectations: Removed.
728 2015-08-28 Jer Noble <jer.noble@apple.com>
730 [iOS] Add WebKit/WebKit2 settings to control automatic data loading
731 https://bugs.webkit.org/show_bug.cgi?id=148579
733 Reviewed by Anders Carlsson.
735 In DumpRenderTree, set the new mediaDataLoadsAutomatically preference to YES.
737 In WebKitTestRunner, do the same for the new _mediaDataLoadsAutomatically configuration property,
738 and also set the existing requiresUserActionForMediaPlayback configuration property to NO.
740 * DumpRenderTree/mac/DumpRenderTree.mm:
741 (resetWebPreferencesToConsistentValues):
742 (resetWebViewToConsistentStateBeforeTesting):
743 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
744 (WTR::initializeWebViewConfiguration):
746 2015-08-28 Alexey Proskuryakov <ap@apple.com>
748 Fix run-webkit-tests --additional-env-var="DYLD_INSERT_LIBRARIES=..."
749 https://bugs.webkit.org/show_bug.cgi?id=148592
751 Reviewed by Tim Horton.
753 * Scripts/webkitpy/port/base.py:
754 (Port.to.setup_environ_for_server):
756 (Port.to._append_value_colon_separated):
757 (Port.to.show_results_html_file):
758 * Scripts/webkitpy/port/ios.py:
759 (IOSSimulatorPort.setup_environ_for_server):
760 * Scripts/webkitpy/port/mac.py:
761 (MacPort.setup_environ_for_server):
763 2015-08-28 Filip Pizlo <fpizlo@apple.com>
765 LICM should be sound even if the CFG has changed
766 https://bugs.webkit.org/show_bug.cgi?id=148259
768 Reviewed by Benjamin Poulain.
770 Add a utility for creating tests that set some uncommon option.
772 * Scripts/run-jsc-stress-tests:
774 2015-08-28 Brent Fulgham <bfulgham@apple.com>
776 [Win] Unreviewed EWS correction.
778 * EWSTools/start-queue-win.sh: Update settings to point to VS2015.
780 2015-08-28 Jer Noble <jer.noble@apple.com>
782 [iOS] Make the AllowsInlineMediaPlayback preference work in WebKit / WebKit2.
783 https://bugs.webkit.org/show_bug.cgi?id=147512
785 Reviewed by Anders Carlsson.
787 Set the value of WebKitAllowsInlineMediaPlayback / WKPreferencesSetMediaPlaybackAllowsInline()
788 to a consistent (true) value.
790 * DumpRenderTree/mac/DumpRenderTree.mm:
791 (setDefaultsToConsistentValuesForTesting):
792 * WebKitTestRunner/TestController.cpp:
793 (WTR::TestController::resetPreferencesToConsistentValues):
795 2015-08-28 Tim Horton <timothy_horton@apple.com>
797 Add navigation gesture callbacks to WKPageNavigationClient
798 https://bugs.webkit.org/show_bug.cgi?id=148568
799 <rdar://problem/22371346>
801 Reviewed by Anders Carlsson.
803 * WebKitTestRunner/TestController.cpp:
804 (WTR::TestController::createOtherPage):
805 (WTR::TestController::createWebViewWithOptions):
808 2015-08-28 Alexey Proskuryakov <ap@apple.com>
810 [Mac] kill-old-processes should kill more processes
811 https://bugs.webkit.org/show_bug.cgi?id=148577
813 Reviewed by Tim Horton.
815 * BuildSlaveSupport/kill-old-processes:
817 2015-08-28 Jason Marcell <jmarcell@apple.com>
819 The status message for combined builder queues should say "all builds succeeded" if everything
821 https://bugs.webkit.org/show_bug.cgi?id=148535
823 Reviewed by David Kilzer and Alexey Proskuryakov.
825 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
826 (BuildbotCombinedQueueView.prototype.update): Make status message for combined builder queues
827 say "all builds succeeded" if everything built correctly.
829 2015-08-28 Carlos Garcia Campos <cgarcia@igalia.com>
831 [GTK] Simplify the internal API to create a WebView
832 https://bugs.webkit.org/show_bug.cgi?id=148570
834 Reviewed by Žan Doberšek.
836 * TestWebKitAPI/PlatformWebView.h: Add initialize method for GTK+ too.
837 * TestWebKitAPI/gtk/PlatformWebViewGtk.cpp:
838 (TestWebKitAPI::PlatformWebView::PlatformWebView): Implement all
839 PlatformWebView constructors that end up calling initialize with a PageConfiguration.
840 (TestWebKitAPI::PlatformWebView::initialize): Create the WebView
841 passing the received PageConfiguration.
842 * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
843 (WTR::PlatformWebView::PlatformWebView): Create the WebView
844 passing the received PageConfiguration.
846 2015-08-27 Aakash Jain <aakash_jain@apple.com>
848 iOS Simulator API tests fails as Simulator is not running
849 https://bugs.webkit.org/show_bug.cgi?id=148501
850 rdar://problem/22447525
852 Reviewed by Daniel Bates.
854 This change is a workaround for <rdar://problem/22388812>.
856 * Scripts/run-api-tests: Launch the iOS Simulator before starting the API Tests
857 and quit it on program termination when running tests on the iOS port.
858 * Scripts/webkitdirs.pm: Store string "For WebKit Development" in constant
859 SIMULATOR_DEVICE_SUFFIX_FOR_WEBKIT_DEVELOPMENT to make it consistently reusable.
861 2015-08-27 Alex Christensen <achristensen@webkit.org>
863 Make DLLLauncherMain executables dependent on dll
864 https://bugs.webkit.org/show_bug.cgi?id=148548
866 Reviewed by Brent Fulgham.
868 * DumpRenderTree/CMakeLists.txt:
869 * DumpRenderTree/PlatformWin.cmake:
870 * MiniBrowser/win/CMakeLists.txt:
871 * TestWebKitAPI/CMakeLists.txt:
872 * TestWebKitAPI/PlatformWin.cmake:
874 2015-08-27 Lucas Forschler <lforschler@apple.com>
876 Remove Mac slaves 188/189 after being replaced with 400/401.
880 * BuildSlaveSupport/build.webkit.org-config/config.json:
882 2015-08-27 Lucas Forschler <lforschler@apple.com>
884 Add two bots to the Mac Yosemite queue.
885 This is to eventually replace bots188/189, which will be removed after 400/401 are vetted.
889 * BuildSlaveSupport/build.webkit.org-config/config.json:
891 2015-08-27 Alex Christensen <achristensen@webkit.org>
893 [Win CMake] Fix incremental build after r188673
894 https://bugs.webkit.org/show_bug.cgi?id=148539
896 Reviewed by Brent Fulgham.
898 * TestWebKitAPI/PlatformWin.cmake:
899 Copy forwarding headers from WebCore before building in case that was not yet done.
900 It used to be done when running CMake, but now it's a build step.
902 2015-08-27 Nan Wang <n_wang@apple.com>
904 AX: Fix accessibility/select-element-at-index.html test
905 https://bugs.webkit.org/show_bug.cgi?id=148516
907 Reviewed by Chris Fleizach.
909 Implemented setSelectedChildAtIndex and removeSelectionAtIndex for mac.
911 * DumpRenderTree/AccessibilityUIElement.cpp:
912 (setSelectedChildCallback):
913 (setSelectedChildAtIndexCallback):
914 (removeSelectionAtIndexCallback):
915 (elementAtPointCallback):
916 (sentenceAtOffsetCallback):
917 (stringForSelectionCallback):
918 (AccessibilityUIElement::getJSClass):
919 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
920 (AccessibilityUIElement::setSelectedChild):
921 (AccessibilityUIElement::setSelectedChildAtIndex):
922 (AccessibilityUIElement::removeSelectionAtIndex):
923 (AccessibilityUIElement::accessibilityValue):
924 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
925 (WTR::AccessibilityUIElement::wordAtOffset):
926 (WTR::AccessibilityUIElement::lineAtOffset):
927 (WTR::AccessibilityUIElement::sentenceAtOffset):
928 (WTR::AccessibilityUIElement::isSelectable):
929 (WTR::AccessibilityUIElement::isMultiSelectable):
930 (WTR::AccessibilityUIElement::setSelectedChild):
931 (WTR::AccessibilityUIElement::setSelectedChildAtIndex):
932 (WTR::AccessibilityUIElement::removeSelectionAtIndex):
933 (WTR::AccessibilityUIElement::selectedChildrenCount):
934 (WTR::AccessibilityUIElement::selectedChildAtIndex):
935 (WTR::AccessibilityUIElement::isExpanded):
936 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
937 (WTR::AccessibilityUIElement::setSelectedChild):
938 (WTR::AccessibilityUIElement::setSelectedChildAtIndex):
939 (WTR::AccessibilityUIElement::removeSelectionAtIndex):
940 (WTR::AccessibilityUIElement::accessibilityValue):
942 2015-08-27 Alex Christensen <achristensen@webkit.org>
944 Build fix after r188982
946 * MiniBrowser/win/CMakeLists.txt:
947 The directory structure changed in the move.
949 2015-08-27 Michael Catanzaro <mcatanzaro@igalia.com>
951 [GTK] Unreviewed, install-dependencies should install geoclue2 on Fedora
953 geoclue-devel is for obsolete geoclue. Install geoclue2-devel instead.
955 * gtk/install-dependencies:
957 2015-08-27 Carlos Garcia Campos <cgarcia@igalia.com>
959 Unreviewed. Mark WTF_WordLock.ContendedShortSection as slow too.
961 * Scripts/run-gtk-tests:
964 2015-08-27 Carlos Garcia Campos <cgarcia@igalia.com>
966 Fix GTK+ WTR crashes in initializeMainRunLoop()
968 Rubber-stamped by Žan Doberšek.
970 Initialize threading and main thread before
971 RunLoop::initializeMainRunLoop(), since the GLib implementation of
972 the RunLoop uses isMainThread() to decide whether to create a new
973 GMainContext or use the default one. Also use RunLoop::run() and
974 ::stop() instead of gtk_main/quit.
976 * WebKitTestRunner/TestController.cpp:
977 (WTR::TestController::initialize):
978 * WebKitTestRunner/gtk/TestControllerGtk.cpp:
979 (WTR::TestController::notifyDone):
980 (WTR::TestController::platformRunUntil):
982 2015-08-27 Filip Pizlo <fpizlo@apple.com>
984 Unreviewed, further shorten a test that times out because it's very long
987 I've locally run these tests on repeat for 24 hours and found no genuine
988 failures, like deadlocks. So, the timeouts are probably because the test
989 machine is slow and debug is slow. We should just run this test for fewer
992 * TestWebKitAPI/Tests/WTF/Lock.cpp:
993 (TestWebKitAPI::TEST):
995 2015-08-26 Ryuan Choi <ryuan.choi@navercorp.com>
997 Unreviewed build fix attempt on EFL
999 * WebKitTestRunner/PlatformEfl.cmake:
1001 2015-08-26 Alex Christensen <achristensen@webkit.org>
1003 Build fix after r188982
1005 * MiniBrowser/win/CMakeLists.txt:
1006 Find .rc files in correct directory.
1008 2015-08-26 Ryuan Choi <ryuan.choi@navercorp.com>
1010 [EFL] Bump cairo version to 1.14.2
1011 https://bugs.webkit.org/show_bug.cgi?id=148474
1013 Reviewed by Csaba Osztrogonác.
1015 * efl/jhbuild.modules:
1017 2015-08-26 Andy Estes <aestes@apple.com>
1019 Crash when following a Google search link to Twitter with Limit Adult Content enabled
1020 https://bugs.webkit.org/show_bug.cgi?id=147651
1022 Rubber-stamped by Brady Eidson.
1024 Taught TestRunner how to decide the navigation policy after a delay.
1026 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1027 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1028 (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
1029 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1030 (WTR::TestRunner::setShouldDecideNavigationPolicyAfterDelay):
1031 * WebKitTestRunner/InjectedBundle/TestRunner.h:
1032 (WTR::TestRunner::shouldDecideNavigationPolicyAfterDelay):
1033 * WebKitTestRunner/TestController.cpp:
1034 (WTR::TestController::initialize):
1035 (WTR::TestController::resetStateToConsistentValues):
1036 (WTR::TestController::decidePolicyForNavigationAction):
1037 * WebKitTestRunner/TestController.h:
1038 (WTR::TestController::setShouldDecideNavigationPolicyAfterDelay):
1039 * WebKitTestRunner/TestInvocation.cpp:
1040 (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1042 2015-08-26 Brent Fulgham <bfulgham@apple.com>
1044 [Win] Rename 'WinLauncher' to 'MiniBrowser'
1045 https://bugs.webkit.org/show_bug.cgi?id=148485
1047 Reviewed by Alex Christensen
1049 Move the WinLauncher project and source files to a subdirectory
1050 of MiniBrowser. Globally change WinLauncher -> MiniBrowser in the
1051 source code and project files.
1053 * MiniBrowser/MiniBrowser.vcxproj: Copied from WinLauncher/WinLauncher.vcxproj.
1054 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.ico: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.ico.
1055 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.rc: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.rc.
1056 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.vcxproj: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.
1057 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.vcxproj.filters: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.filters.
1058 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCF.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherCF.props.
1059 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCFLite.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherCFLite.props.
1060 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCommon.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherCommon.props.
1061 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserDebug.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherDebug.props.
1062 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc.
1063 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.vcxproj: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.
1064 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.vcxproj.filters: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters.
1065 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibCommon.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props.
1066 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibDebug.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibDebug.props.
1067 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibPostBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibPostBuild.cmd.
1068 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibPreBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd.
1069 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibProduction.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibProduction.props.
1070 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibRelease.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibRelease.props.
1071 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h.
1072 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserPostBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherPostBuild.cmd.
1073 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserPreBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherPreBuild.cmd.
1074 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserProduction.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherProduction.props.
1075 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserRelease.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherRelease.props.
1076 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserResource.h: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherResource.h.
1077 * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.ico: Removed.
1078 * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.rc: Removed.
1079 * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.vcxproj: Removed.
1080 * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.vcxproj.filters: Removed.
1081 * MiniBrowser/MiniBrowser.vcxproj/WinLauncherCF.props: Removed.
1082 * MiniBrowser/MiniBrowser.vcxproj/WinLauncherCFLite.props: Removed.
1083 * MiniBrowser/MiniBrowser.vcxproj/WinLauncherCommon.props: Removed.
1084 * MiniBrowser/MiniBrowser.vcxproj/WinLauncherDebug.props: Removed.
1085 * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLib.rc: Removed.
1086 * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLib.vcxproj: Removed.
1087 * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLib.vcxproj.filters: Removed.
1088 * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibCommon.props: Removed.
1089 * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibDebug.props: Removed.
1090 * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibPostBuild.cmd: Removed.
1091 * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibPreBuild.cmd: Removed.
1092 * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibProduction.props: Removed.
1093 * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibRelease.props: Removed.
1094 * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibResource.h: Removed.
1095 * MiniBrowser/MiniBrowser.vcxproj/WinLauncherPostBuild.cmd: Removed.
1096 * MiniBrowser/MiniBrowser.vcxproj/WinLauncherPreBuild.cmd: Removed.
1097 * MiniBrowser/MiniBrowser.vcxproj/WinLauncherProduction.props: Removed.
1098 * MiniBrowser/MiniBrowser.vcxproj/WinLauncherRelease.props: Removed.
1099 * MiniBrowser/MiniBrowser.vcxproj/WinLauncherResource.h: Removed.
1100 * MiniBrowser/win: Copied from WinLauncher.
1101 * MiniBrowser/win/Common.cpp:
1102 * MiniBrowser/win/MiniBrowser.cpp: Copied from WinLauncher/WinLauncher.cpp.
1103 * MiniBrowser/win/MiniBrowser.h: Copied from WinLauncher/WinLauncher.h.
1104 * MiniBrowser/win/MiniBrowserReplace.h: Copied from WinLauncher/WinLauncherReplace.h.
1105 * MiniBrowser/win/MiniBrowserWebHost.cpp: Copied from WinLauncher/WinLauncherWebHost.cpp.
1106 * MiniBrowser/win/MiniBrowserWebHost.h: Copied from WinLauncher/WinLauncherWebHost.h.
1107 * MiniBrowser/win/PageLoadTestClient.cpp:
1108 * MiniBrowser/win/PageLoadTestClient.h:
1109 * MiniBrowser/win/ResourceLoadDelegate.cpp:
1110 * MiniBrowser/win/ResourceLoadDelegate.h:
1111 * MiniBrowser/win/WinLauncher.cpp: Removed.
1112 * MiniBrowser/win/WinLauncher.h: Removed.
1113 * MiniBrowser/win/WinLauncher.vcxproj: Removed.
1114 * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.ico: Removed.
1115 * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.rc: Removed.
1116 * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.vcxproj: Removed.
1117 * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.vcxproj.filters: Removed.
1118 * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherCF.props: Removed.
1119 * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherCFLite.props: Removed.
1120 * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherCommon.props: Removed.
1121 * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherDebug.props: Removed.
1122 * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLib.rc: Removed.
1123 * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Removed.
1124 * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters: Removed.
1125 * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibCommon.props: Removed.
1126 * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibDebug.props: Removed.
1127 * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibPostBuild.cmd: Removed.
1128 * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd: Removed.
1129 * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibProduction.props: Removed.
1130 * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibRelease.props: Removed.
1131 * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibResource.h: Removed.
1132 * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherPostBuild.cmd: Removed.
1133 * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherPreBuild.cmd: Removed.
1134 * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherProduction.props: Removed.
1135 * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherRelease.props: Removed.
1136 * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherResource.h: Removed.
1137 * MiniBrowser/win/WinLauncher.vcxproj/small.ico: Removed.
1138 * MiniBrowser/win/WinLauncherReplace.h: Removed.
1139 * MiniBrowser/win/WinLauncherWebHost.cpp: Removed.
1140 * MiniBrowser/win/WinLauncherWebHost.h: Removed.
1141 * MiniBrowser/win/WinMain.cpp:
1142 * WinLauncher: Removed.
1143 * WinLauncher/AccessibilityDelegate.cpp: Removed.
1144 * WinLauncher/AccessibilityDelegate.h: Removed.
1145 * WinLauncher/CMakeLists.txt: Removed.
1146 * WinLauncher/Common.cpp: Removed.
1147 * WinLauncher/DOMDefaultImpl.cpp: Removed.
1148 * WinLauncher/DOMDefaultImpl.h: Removed.
1149 * WinLauncher/PageLoadTestClient.cpp: Removed.
1150 * WinLauncher/PageLoadTestClient.h: Removed.
1151 * WinLauncher/PrintWebUIDelegate.cpp: Removed.
1152 * WinLauncher/PrintWebUIDelegate.h: Removed.
1153 * WinLauncher/ResourceLoadDelegate.cpp: Removed.
1154 * WinLauncher/ResourceLoadDelegate.h: Removed.
1155 * WinLauncher/WebDownloadDelegate.cpp: Removed.
1156 * WinLauncher/WebDownloadDelegate.h: Removed.
1157 * WinLauncher/WinLauncher.cpp: Removed.
1158 * WinLauncher/WinLauncher.h: Removed.
1159 * WinLauncher/WinLauncher.vcxproj: Removed.
1160 * WinLauncher/WinLauncher.vcxproj/WinLauncher.ico: Removed.
1161 * WinLauncher/WinLauncher.vcxproj/WinLauncher.rc: Removed.
1162 * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Removed.
1163 * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.filters: Removed.
1164 * WinLauncher/WinLauncher.vcxproj/WinLauncherCF.props: Removed.
1165 * WinLauncher/WinLauncher.vcxproj/WinLauncherCFLite.props: Removed.
1166 * WinLauncher/WinLauncher.vcxproj/WinLauncherCommon.props: Removed.
1167 * WinLauncher/WinLauncher.vcxproj/WinLauncherDebug.props: Removed.
1168 * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Removed.
1169 * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Removed.
1170 * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters: Removed.
1171 * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props: Removed.
1172 * WinLauncher/WinLauncher.vcxproj/WinLauncherLibDebug.props: Removed.
1173 * WinLauncher/WinLauncher.vcxproj/WinLauncherLibPostBuild.cmd: Removed.
1174 * WinLauncher/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd: Removed.
1175 * WinLauncher/WinLauncher.vcxproj/WinLauncherLibProduction.props: Removed.
1176 * WinLauncher/WinLauncher.vcxproj/WinLauncherLibRelease.props: Removed.
1177 * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h: Removed.
1178 * WinLauncher/WinLauncher.vcxproj/WinLauncherPostBuild.cmd: Removed.
1179 * WinLauncher/WinLauncher.vcxproj/WinLauncherPreBuild.cmd: Removed.
1180 * WinLauncher/WinLauncher.vcxproj/WinLauncherProduction.props: Removed.
1181 * WinLauncher/WinLauncher.vcxproj/WinLauncherRelease.props: Removed.
1182 * WinLauncher/WinLauncher.vcxproj/WinLauncherResource.h: Removed.
1183 * WinLauncher/WinLauncher.vcxproj/small.ico: Removed.
1184 * WinLauncher/WinLauncherReplace.h: Removed.
1185 * WinLauncher/WinLauncherWebHost.cpp: Removed.
1186 * WinLauncher/WinLauncherWebHost.h: Removed.
1187 * WinLauncher/WinMain.cpp: Removed.
1188 * WinLauncher/resource.h: Removed.
1189 * WinLauncher/stdafx.cpp: Removed.
1190 * WinLauncher/stdafx.h: Removed.
1191 * win/AssembleBuildLogs/AssembleLogs.cmd:
1193 2015-08-26 Brent Fulgham <bfulgham@apple.com>
1195 [Win] Simplify menu handling code in WinLauncher
1196 https://bugs.webkit.org/show_bug.cgi?id=148461
1198 Reviewed by Zalan Bujtas.
1200 Revise 'ToggleMenuItem' to return a boolean value indicating if
1201 it handled the message. Revise WndProc to use this to decide if it
1202 should pass the message on to the default handler, rather than
1203 duplicating the logic in both places.
1205 * WinLauncher/Common.cpp:
1206 (ToggleMenuItem): Return true if the menu item message was handled.
1207 (WndProc): If 'ToggleMenuItem' did not handle the message, pass
1208 the message tothe default handler.
1210 2015-08-26 Csaba Osztrogonác <ossy@webkit.org>
1212 Remove unused code after r188948
1213 https://bugs.webkit.org/show_bug.cgi?id=148467
1215 Reviewed by Gyuyoung Kim.
1217 * WebKitTestRunner/TestController.cpp:
1218 (WTR::TestController::platformPreferences): Deleted.
1220 2015-08-26 Gyuyoung Kim <gyuyoung.kim@webkit.org>
1222 [EFL][GTK] REGRESSION(r188828): All performance tests and almost all layout tests crash
1223 https://bugs.webkit.org/show_bug.cgi?id=148377
1225 Reviewed by Carlos Garcia Campos.
1227 EFL and GTK don't support TestController::platformPreferences() yet which was introduced by r188828.
1228 It caused all crashes of layout test and performance test on EFL and GTK. So this patch implements
1229 TestController::platformPreferences() using WKPageGroupGetPreferences() which was previous thing for
1230 EFL and GTK at the moment.
1232 * WebKitTestRunner/TestController.cpp:
1233 (WTR::TestController::platformWillRunTest):
1234 * WebKitTestRunner/efl/TestControllerEfl.cpp:
1235 (WTR::TestController::platformPreferences):
1236 * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1237 (WTR::TestController::platformPreferences):
1239 2015-08-25 Nan Wang <n_wang@apple.com>
1241 AX: Enable accessibility/aria-controls.html test for mac
1242 https://bugs.webkit.org/show_bug.cgi?id=148458
1244 Reviewed by Chris Fleizach.
1246 Implemented ariaControlsElementAtIndex(unsigned index).
1248 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1249 (AccessibilityUIElement::ariaControlsElementAtIndex):
1250 (AccessibilityUIElement::disclosedRowAtIndex):
1251 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1252 (WTR::AccessibilityUIElement::ariaControlsElementAtIndex):
1254 2015-08-25 Gyuyoung Kim <gyuyoung.kim@webkit.org>
1256 Remove python tests for PassRefPtr
1257 https://bugs.webkit.org/show_bug.cgi?id=148463
1259 Reviewed by Andy Estes.
1261 As we're removing uses of PassRefPtr, we need to remove all python tests for PassRefPtr as well.
1263 * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1264 (PassPtrTest): Deleted.
1265 (PassPtrTest.assert_pass_ptr_check): Deleted.
1266 (PassPtrTest.test_pass_ref_ptr_in_function): Deleted.
1267 (PassPtrTest.test_pass_other_type_ptr_in_function): Deleted.
1268 (PassPtrTest.test_pass_ref_ptr_return_value): Deleted.
1269 (PassPtrTest.test_ref_ptr_parameter_value): Deleted.
1270 (PassPtrTest.test_ref_ptr_member_variable): Deleted.
1271 (PassPtrTest.test_ref_ptr_member_variable.Foo): Deleted.
1273 2015-08-25 Andy Estes <aestes@apple.com>
1275 [iOS] run-webkit-tests fails if watchOS SDK is installed
1276 https://bugs.webkit.org/show_bug.cgi?id=148453
1278 Reviewed by David Kilzer.
1280 * Scripts/webkitpy/xcode/simulator.py:
1281 (Simulator): Taught Simulator how to parse watchOS runtimes and devices.
1282 * Scripts/webkitpy/xcode/simulator_unittest.py: Added tests.
1284 2015-08-25 Aakash Jain <aakash_jain@apple.com>
1286 iOS Simulator layout-tests fail to start while cleaning a directory structure if simulator is already running
1287 https://bugs.webkit.org/show_bug.cgi?id=148197
1288 rdar://problem/22334382
1290 Reviewed by Daniel Bates.
1292 * BuildSlaveSupport/kill-old-processes: Add Simulator to the list of processes to kill (for iOS builders).
1293 * Scripts/webkitpy/port/ios.py:
1294 (IOSSimulatorPort): Converted bundle id com.apple.iphonesimulator to a variable SIMULATOR_BUNDLE_ID.
1295 (IOSSimulatorPort._quitIOSSimulator): Common function to quit iOS Simulator.
1296 (IOSSimulatorPort.clean_up_test_run): Quit the simulator during the cleanup.
1297 (IOSSimulatorPort.check_sys_deps): No need to quit the simulator here as its now being quit in reset_preferences().
1298 (IOSSimulatorPort.reset_preferences): Quit the simulator before trying to delete associated data directory.
1300 2015-08-25 Gyuyoung Kim <gyuyoung.kim@webkit.org>
1302 Remove PassRefPtr style check rule
1303 https://bugs.webkit.org/show_bug.cgi?id=148432
1305 Reviewed by Andreas Kling.
1307 PassRefPtr is being removed. Thus style rule needs to be removed as well.
1309 * Scripts/webkitpy/style/checkers/cpp.py:
1310 (_check_parameter_name_against_text): Deleted.
1311 (check_function_definition_and_pass_ptr): Deleted.
1312 (check_function_definition): Deleted.
1313 (check_pass_ptr_usage): Deleted.
1314 (process_line): Deleted.
1315 (CppChecker): Deleted.
1317 2015-08-25 Brent Fulgham <bfulgham@apple.com>
1319 [Win] Expose "Inverted Colors" option in WinLauncher
1320 https://bugs.webkit.org/show_bug.cgi?id=148451
1322 Reviewed by Tim Horton.
1324 Add the ability to toggle the "Inverted Colors" preference
1327 * WinLauncher/Common.cpp:
1328 (ToggleMenuItem): Toggle the feature when the menu item
1330 (WndProc): Recognize the new menu option.
1331 * WinLauncher/WinLauncher.cpp:
1332 (WinLauncher::setToDefaultPreferences): Launch with "Invert
1334 * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Add menu
1335 entry for "Invert Colors".
1336 * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h:
1338 2015-08-25 Nan Wang <n_wang@apple.com>
1340 [Mac] accessibility/document-attributes.html fails
1341 https://bugs.webkit.org/show_bug.cgi?id=116636
1343 Reviewed by Chris Fleizach.
1345 Implemented documentURI() and documentEncoding().
1347 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1348 (AccessibilityUIElement::documentEncoding):
1349 (AccessibilityUIElement::documentURI):
1350 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1351 (WTR::AccessibilityUIElement::documentEncoding):
1352 (WTR::AccessibilityUIElement::documentURI):
1354 2015-08-24 Brent Fulgham <bfulgham@apple.com>
1356 [Win] Unreviewed test gardening.
1358 Fix another case where the logging string is constructed using the variable 'frame',
1359 but the method argument is not given a name. This causes the global 'frame' value to
1360 be used, producing incorrect output.
1362 * DumpRenderTree/win/FrameLoadDelegate.cpp:
1363 (FrameLoadDelegate::didReceiveServerRedirectForProvisionalLoadForFrame): Use 'frame'
1366 2015-08-24 Tim Horton <timothy_horton@apple.com>
1368 (Finally...) get rid of WKViewIOS
1369 https://bugs.webkit.org/show_bug.cgi?id=148404
1371 Reviewed by Anders Carlsson.
1373 * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
1374 * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
1375 * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
1376 * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
1377 * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
1378 * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
1379 * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm:
1380 * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
1381 * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
1382 * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.mm:
1383 Mark tests that use WKBrowsingContextController as Mac-only.
1385 * WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm:
1386 (WTR::AccessibilityController::addNotificationListener):
1387 * WebKitTestRunner/ios/mainIOS.mm:
1388 (-[WebKitTestRunnerApp applicationDidEnterBackground:]):
1389 Import UIKit instead of depending on WKView.h to do so.
1391 2015-08-24 Jason Marcell <jmarcell@apple.com>
1393 Add support to dashboard for displaying Git SHA's as revisions.
1394 https://bugs.webkit.org/show_bug.cgi?id=148387
1396 Reviewed by Daniel Bates.
1398 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1399 (parseRevisionProperty): Added support to dashboard for displaying Git SHA's as revisions.
1400 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1401 (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Ditto.
1402 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js: Added
1403 "isSVN" property to Dashboard.Repository.(OpenSource|Internal).
1405 2015-08-24 Andy Estes <aestes@apple.com>
1407 REGRESSION (r188851): WebKit2.BundleParameters fails on iOS
1409 * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Specify LD_RUNPATH_SEARCH_PATHS correctly for iOS.
1411 2015-08-23 Andy Estes <aestes@apple.com>
1413 Addressed a missed piece of review feedback from r188851.
1415 * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
1417 2015-08-23 Andy Estes <aestes@apple.com>
1419 [Content Filtering] REGRESSION (r182356): Provisional URL is incorrect in didReceiveServerRedirectForProvisionalLoadForFrame when Content Filtering is enabled
1420 https://bugs.webkit.org/show_bug.cgi?id=147872
1421 rdar://problem/22044000
1423 Reviewed by Dan Bernstein.
1427 * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Linked libWebCoreTestSupport in order to use MockContentFilter.
1428 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1429 * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm: Added.
1430 (-[ServerRedirectNavigationDelegate webView:didStartProvisionalNavigation:]): Expect the initial request URL.
1431 (-[ServerRedirectNavigationDelegate webView:didReceiveServerRedirectForProvisionalNavigation:]): Expect the redirect URL.
1432 (-[ServerRedirectNavigationDelegate webView:didCommitNavigation:]):
1433 (TEST): Tested that -[WKWebView URL] is updated after a redirect when content filtering is enabled.
1434 * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm: Added.
1435 (+[ServerRedirectPlugIn initialize]): Enable MockContentFilter.
1436 * TestWebKitAPI/cocoa/TestProtocol.h: Renamed from Tools/TestWebKitAPI/mac/TestProtocol.h.
1437 * TestWebKitAPI/cocoa/TestProtocol.mm: Renamed from Tools/TestWebKitAPI/mac/TestProtocol.mm.
1439 2015-08-23 Andy Estes <aestes@apple.com>
1441 Fixed the 32-bit Mac build after r188844.
1443 * TestWebKitAPI/WKWebViewConfigurationExtras.h:
1444 * TestWebKitAPI/WKWebViewConfigurationExtras.mm:
1446 2015-08-22 Andy Estes <aestes@apple.com>
1448 [Cocoa] API tests using the Modern WebKit API should be able to create web process plug-ins
1449 https://bugs.webkit.org/show_bug.cgi?id=148317
1451 Reviewed by Dan Bernstein.
1453 Added the ability for Modern WebKit API tests to create WKWebProcessPlugIns. A test can create a plug-in by
1454 creating a class that conforms to WKWebProcessPlugIn, adding it to the WebProcessPlugIn target, and using the
1455 WKWebViewConfiguration returned by +[WKWebViewConfiguration testwebkitapi_configurationWithTestPlugInClassName:]
1456 when creating WKWebViews.
1458 Since TestWebKitAPI relies on a bundle parameter to know which test class to instantiate in the plug-in, I also
1459 added a new API test for bundle parameters.
1461 * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Added. Named the bundle TestWebKitAPI.wkbundle and
1462 named its executable TestWebKitAPI.bundle.
1463 * TestWebKitAPI/PlatformUtilities.h: Declared TestPlugInClassNameParameter.
1464 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added the WebProcessPlugIn target.
1465 * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParameters.mm: Added.
1466 (TEST): Tested bundle parameters by verifying that parameter changes in the UI process are observed in the bundle.
1467 * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParametersPlugIn.mm: Added.
1468 (-[BundleParametersPlugIn webProcessPlugIn:didCreateBrowserContextController:]): Started observing changes to a
1469 bundle parameter and asked for an initial notification.
1470 (-[BundleParametersPlugIn dealloc]): Stopped observing changes to a bundle parameter.
1471 (-[BundleParametersPlugIn observeValueForKeyPath:ofObject:change:context:]): When a bundle parameter changes,
1472 mirror its value in the main frame's JSContext.
1473 * TestWebKitAPI/WKWebViewConfigurationExtras.h: Added.
1474 * TestWebKitAPI/WKWebViewConfigurationExtras.mm: Added.
1475 (+[WKWebViewConfiguration testwebkitapi_configurationWithTestPlugInClassName:]): Created a configuration with
1476 TestWebKitAPI's bundle URL and set a bundle parameter indicating the test plug-in's class name.
1477 * TestWebKitAPI/cocoa/PlatformUtilitiesCocoa.mm: Defined TestPlugInClassNameParameter.
1478 * TestWebKitAPI/cocoa/WebProcessPlugIn/Info.plist: Added. Set the principal class to WebProcessPlugIn.
1479 * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm: Added.
1480 (-[WebProcessPlugIn webProcessPlugIn:initializeWithObject:]): Forwarded to a newly-created test class instance.
1481 (-[WebProcessPlugIn respondsToSelector:]): Returned YES if the test class instance response.
1482 (-[WebProcessPlugIn forwardingTargetForSelector:]): Forwarded unimplemented methods to the test class instance.
1484 2015-08-23 Csaba Osztrogonác <ossy@webkit.org>
1486 URTBF after r188828.
1488 * WebKitTestRunner/PlatformWebView.h:
1490 2015-08-23 Alexey Proskuryakov <ap@apple.com>
1492 build.webkit.org/dashboard: Combined queues don't turn orange on internal failure
1493 https://bugs.webkit.org/show_bug.cgi?id=148356
1495 Reviewed by Darin Adler.
1497 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
1498 (BuildbotCombinedQueueView.prototype.update):
1500 2015-08-23 Alexey Proskuryakov <ap@apple.com>
1502 build.webkit.org/dashboard: Respect step's hidden flag
1503 https://bugs.webkit.org/show_bug.cgi?id=148357
1505 Reviewed by Darin Adler.
1507 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1508 (BuildbotIteration.prototype._parseData):
1510 2015-08-23 Nan Wang <n_wang@apple.com>
1512 AX: Fix accessibility/deleting-iframe-destroys-axcache.html test
1513 https://bugs.webkit.org/show_bug.cgi?id=148328
1515 Reviewed by Darin Adler.
1517 We should only expose stringValue() when value attribute is set.
1519 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1520 (AccessibilityUIElement::stringValue):
1521 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1522 (WTR::AccessibilityUIElement::stringValue):
1524 2015-08-23 Gyuyoung Kim <gyuyoung.kim@webkit.org>
1526 Remove style checking rule regarding OwnPtr and PassOwnPtr
1527 https://bugs.webkit.org/show_bug.cgi?id=148360
1529 Reviewed by Darin Adler.
1531 OwnPtr and PassOwnPtr were totally removed though, style rule is still alive.
1534 * Scripts/do-webcore-rename:
1535 * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1536 (PassPtrTest.test_pass_own_ptr_in_function): Deleted.
1537 (PassPtrTest.test_pass_ref_ptr_return_value): Deleted.
1538 (PassPtrTest.test_own_ptr_parameter_value): Deleted.
1539 (WebKitStyleTest.test_names): Deleted.
1541 2015-08-22 Timothy Horton <timothy_horton@apple.com>
1543 WebKitTestRunner should use WKWebView on OS X and iOS
1544 https://bugs.webkit.org/show_bug.cgi?id=143743
1545 <rdar://problem/16947123>
1547 Reviewed by Anders Carlsson.
1548 Patch by Enrica Casucci and myself.
1550 * WebKitTestRunner/PlatformWebView.h:
1551 (WTR::PlatformWebView::windowSnapshotEnabled): Deleted.
1552 Add a PlatformWebView constructor that takes a WKWebViewConfiguration
1553 instead of WKContext and WKPageGroup.
1555 Remove the unused, always-true windowSnapshotEnabled().
1556 While technically some platforms don't have window snapshotting,
1557 they just return null instead of implementing windowSnapshotEnabled().
1559 * WebKitTestRunner/TestController.h:
1560 * WebKitTestRunner/TestController.cpp:
1561 (WTR::TestController::createOtherPage):
1562 (WTR::TestController::initialize):
1563 (WTR::TestController::createWebViewWithOptions):
1564 Delegate to the various platforms for creating PlatformWebView instances,
1565 for creating WKContexts, and for accessing WKPreferences,
1566 so that they can do special things (like, use WKWebView instead!).
1568 (WTR::TestController::resetPreferencesToConsistentValues):
1569 Make explicit WebKitTestRunner's desired default for two preferences
1570 which have differing defaults between the antique and modern API,
1571 for consistency's sake.
1573 (WTR::TestController::resetStateToConsistentValues):
1574 Add platformResetStateToConsistentValues.
1576 * WebKitTestRunner/TestInvocation.cpp:
1577 (WTR::TestInvocation::dumpResults):
1578 Adjust to the aforementioned removal of windowSnapshotEnabled().
1580 * WebKitTestRunner/ios/TestControllerCocoa.mm:
1581 (WTR::TestController::platformResetStateToConsistentValues):
1582 (WTR::TestController::platformPreferences):
1583 (WTR::TestController::platformCreateWebView):
1584 (WTR::TestController::platformCreateOtherPage):
1585 (WTR::TestController::platformInitializeConfiguration):
1586 Implement the new platform functions for the Modern WebKit2 API,
1587 in a new TestControllerCocoa file that is shared between iOS and Mac.
1589 For platformMaybeCreateContext, use the trick that we know we can cast
1590 the WKProcessPool to a WKContextRef to retrieve a WKContextRef from
1591 WKWebView's configuration.
1593 Ditto for WKPreferencesRef and WKPreferences.
1595 Remove user content filters on the WKWebView's userContentController.
1597 * WebKitTestRunner/mac/TestControllerMac.mm:
1598 * WebKitTestRunner/ios/TestControllerIOS.mm:
1599 Move code into TestControllerCocoa.
1601 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1602 (WTR::InjectedBundle::beginTesting):
1603 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1604 (WTR::TestRunner::addUserScript):
1605 (WTR::TestRunner::addUserStyleSheet):
1606 Adopt WKBundlePage API for user scripts/sheets.
1608 * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1609 * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1610 Make and keep a WKWebView instead of a WKView.
1612 * WebKitTestRunner/mac/EventSenderProxy.mm:
1613 (WTR::EventSenderProxy::mouseUp):
1614 (WTR::EventSenderProxy::mouseMoveTo):
1615 Reach inside the WKWebView to the WKView when dispatching events.
1616 This is fairly ugly and we should come up with a better solution.
1617 Also, fix some flipping and style errors.
1619 2015-08-22 Michael Catanzaro <mcatanzaro@igalia.com>
1621 Unreviewed, attempt to fix GTK build after r188718
1623 * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1624 (WTR::PlatformWebView::PlatformWebView):
1626 2015-08-21 Commit Queue <commit-queue@webkit.org>
1628 Unreviewed, rolling out r188807, r188813, and r188815.
1629 https://bugs.webkit.org/show_bug.cgi?id=148349
1631 lots of 32-bit build problems, better to resolve separately
1632 and try again (Requested by thorton on #webkit).
1634 Reverted changesets:
1636 "WebKitTestRunner should use WKWebView on OS X and iOS"
1637 https://bugs.webkit.org/show_bug.cgi?id=143743
1638 http://trac.webkit.org/changeset/188807
1640 "Stop building WebKitTestRunner for 32-bit platforms"
1641 https://bugs.webkit.org/show_bug.cgi?id=143743
1642 http://trac.webkit.org/changeset/188813
1644 "Stop building WebKitTestRunner for 32-bit platforms"
1645 https://bugs.webkit.org/show_bug.cgi?id=143743
1646 http://trac.webkit.org/changeset/188815
1648 2015-08-21 Tim Horton <timothy_horton@apple.com>
1650 Stop building WebKitTestRunner for 32-bit platforms
1651 https://bugs.webkit.org/show_bug.cgi?id=143743
1652 <rdar://problem/16947123>
1654 * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1655 This is a restriction on the valid set, not the desired set.
1657 2015-08-21 Jason Marcell <jmarcell@apple.com>
1659 Make Dashboard.Branches be objects of the form (repository, "branch name") and update existing code
1660 to work with these new objects.
1661 https://bugs.webkit.org/show_bug.cgi?id=148188
1663 Reviewed by Daniel Bates.
1665 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
1666 (Buildbot.prototype._normalizeQueueInfo): Renamed BuildbotQueue.branch to BuildbotQueue.branches.
1667 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
1668 (BuildbotCombinedQueueView): Changed to work with new branch objects which represent a
1669 (repository, "branch name")-pair.
1670 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: Ditto.
1671 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1672 (BuildbotQueue): Renamed BuildbotQueue.branch to BuildbotQueue.branches.
1673 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1674 (BuildbotQueueView.prototype._appendPendingRevisionCount): Changed to work with new branch
1675 objects which represent a (repository, "branch name")-pair.
1676 (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Ditto.
1677 (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Ditto.
1678 (BuildbotQueueView.prototype._addDividerToPopover): Ditto.
1679 (BuildbotQueueView.prototype.revisionContentForIteration): Ditto.
1680 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Renamed
1681 BuildbotQueue.branch to BuildbotQueue.branches.
1682 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1683 (WebKitBuildbot.prototype.get defaultBranches): Changed to new (repository, "branch name") format.
1685 2015-08-21 Tim Horton <timothy_horton@apple.com>
1687 Stop building WebKitTestRunner for 32-bit platforms
1688 https://bugs.webkit.org/show_bug.cgi?id=143743
1689 <rdar://problem/16947123>
1691 * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1692 WKWebView is not available on 32-bit OS X.
1694 2015-08-21 Brent Fulgham <bfulgham@apple.com>
1696 [Win] Unreviewed test correction after r188709.
1698 I removed a function argument that happened to be mirrored by a global
1699 value with the same name. This prevented a compile error, but testing
1700 showed that the wrong value was being used in the function.
1702 * DumpRenderTree/win/FrameLoadDelegate.cpp:
1703 (FrameLoadDelegate::willPerformClientRedirectToURL): Put function argument
1706 2015-08-21 Timothy Horton <timothy_horton@apple.com>
1708 WebKitTestRunner should use WKWebView on OS X and iOS
1709 https://bugs.webkit.org/show_bug.cgi?id=143743
1710 <rdar://problem/16947123>
1712 Reviewed by Anders Carlsson.
1713 Patch by Enrica Casucci and myself.
1715 * WebKitTestRunner/PlatformWebView.h:
1716 (WTR::PlatformWebView::windowSnapshotEnabled): Deleted.
1717 Add a PlatformWebView constructor that takes a WKWebViewConfiguration
1718 instead of WKContext and WKPageGroup.
1720 Remove the unused, always-true windowSnapshotEnabled().
1721 While technically some platforms don't have window snapshotting,
1722 they just return null instead of implementing windowSnapshotEnabled().
1724 * WebKitTestRunner/TestController.h:
1725 * WebKitTestRunner/TestController.cpp:
1726 (WTR::TestController::createOtherPage):
1727 (WTR::TestController::initialize):
1728 (WTR::TestController::createWebViewWithOptions):
1729 Delegate to the various platforms for creating PlatformWebView instances,
1730 for creating WKContexts, and for accessing WKPreferences,
1731 so that they can do special things (like, use WKWebView instead!).
1733 (WTR::TestController::resetPreferencesToConsistentValues):
1734 Make explicit WebKitTestRunner's desired default for two preferences
1735 which have differing defaults between the antique and modern API,
1736 for consistency's sake.
1738 (WTR::TestController::resetStateToConsistentValues):
1739 Add platformResetStateToConsistentValues.
1741 * WebKitTestRunner/TestInvocation.cpp:
1742 (WTR::TestInvocation::dumpResults):
1743 Adjust to the aforementioned removal of windowSnapshotEnabled().
1745 * WebKitTestRunner/ios/TestControllerCocoa.mm:
1746 (WTR::TestController::platformResetStateToConsistentValues):
1747 (WTR::TestController::platformPreferences):
1748 (WTR::TestController::platformCreateWebView):
1749 (WTR::TestController::platformCreateOtherPage):
1750 (WTR::TestController::platformInitializeConfiguration):
1751 Implement the new platform functions for the Modern WebKit2 API,
1752 in a new TestControllerCocoa file that is shared between iOS and Mac.
1754 For platformMaybeCreateContext, use the trick that we know we can cast
1755 the WKProcessPool to a WKContextRef to retrieve a WKContextRef from
1756 WKWebView's configuration.
1758 Ditto for WKPreferencesRef and WKPreferences.
1760 Remove user content filters on the WKWebView's userContentController.
1762 * WebKitTestRunner/mac/TestControllerMac.mm:
1763 * WebKitTestRunner/ios/TestControllerIOS.mm:
1764 Move code into TestControllerCocoa.
1766 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1767 (WTR::InjectedBundle::beginTesting):
1768 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1769 (WTR::TestRunner::addUserScript):
1770 (WTR::TestRunner::addUserStyleSheet):
1771 Adopt WKBundlePage API for user scripts/sheets.
1773 * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1774 * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1775 Make and keep a WKWebView instead of a WKView.
1777 * WebKitTestRunner/mac/EventSenderProxy.mm:
1778 (WTR::EventSenderProxy::mouseUp):
1779 (WTR::EventSenderProxy::mouseMoveTo):
1780 Reach inside the WKWebView to the WKView when dispatching events.
1781 This is fairly ugly and we should come up with a better solution.
1782 Also, fix some flipping and style errors.
1784 2015-08-21 Alexey Proskuryakov <ap@apple.com>
1786 Improve how UI events are dispatched by WebKitTestRunner
1787 https://bugs.webkit.org/show_bug.cgi?id=148326
1789 Reviewed by Anders Carlsson.
1791 * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
1792 * WebKitTestRunner/InjectedBundle/EventSendingController.h:
1793 Removed asyncScrolling from mouseScrollByWithWheelAndMomentumPhases, it's now always
1794 asynchronous (and really, it has always been for the most part).
1796 * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1797 (WTR::EventSendingController::mouseDown): Updated for WKBundlePagePostSynchronousMessage renaming.
1798 (WTR::EventSendingController::mouseUp): Ditto.
1799 (WTR::EventSendingController::mouseMoveTo): Ditto.
1800 (WTR::EventSendingController::mouseForceDown): Ditto.
1801 (WTR::EventSendingController::mouseForceUp): Ditto.
1802 (WTR::EventSendingController::mouseForceChanged): Ditto.
1803 (WTR::EventSendingController::leapForward): Ditto.
1804 (WTR::EventSendingController::scheduleAsynchronousClick): Ditto.
1805 (WTR::EventSendingController::keyDown): Ditto.
1806 (WTR::EventSendingController::scheduleAsynchronousKeyDown): Ditto.
1807 (WTR::EventSendingController::mouseScrollBy): Force a scrolling tree commit. It used
1808 to be done in custom WebKit2 code for test wheel event handling.
1809 (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases): Got rid of sync version.
1810 (WTR::EventSendingController::continuousMouseScrollBy): Added a FIXME. This one is weird.
1811 (WTR::EventSendingController::contextClick): Updated for WKBundlePagePostSynchronousMessage renaming.
1812 (WTR::EventSendingController::addTouchPoint): Ditto.
1813 (WTR::EventSendingController::updateTouchPoint): Ditto.
1814 (WTR::EventSendingController::setTouchModifier): Ditto.
1815 (WTR::EventSendingController::setTouchPointRadius): Ditto.
1816 (WTR::EventSendingController::touchStart): Ditto.
1817 (WTR::EventSendingController::touchMove): Ditto.
1818 (WTR::EventSendingController::touchEnd): Ditto.
1819 (WTR::EventSendingController::touchCancel): Ditto.
1820 (WTR::EventSendingController::clearTouchPoints): Ditto.
1821 (WTR::EventSendingController::releaseTouchPoint): Ditto.
1822 (WTR::EventSendingController::cancelTouchPoint): Ditto.
1824 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1825 (WTR::InjectedBundle::postSetWindowIsKey):
1826 (WTR::InjectedBundle::postSimulateWebNotificationClick):
1827 (WTR::InjectedBundle::isGeolocationProviderActive):
1828 (WTR::InjectedBundle::shouldProcessWorkQueue):
1829 Updated for WKBundlePagePostSynchronousMessage renaming.
1831 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1832 (WTR::TestRunner::secureEventInputIsEnabled): Ditto.
1834 * WebKitTestRunner/TestController.cpp:
1835 (WTR::TestController::initialize): Allow handling the new test style messages.
1836 (WTR::TestController::didReceiveKeyDownMessageFromInjectedBundle): Removed calls
1837 to WKPageSetShouldSendEventsSynchronously, which we no longer need.
1838 (WTR::TestController::didReceiveMessageFromInjectedBundle):
1839 (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle): Moved
1840 "MouseScrollBy" to async section, and got rid of WKPageSetShouldSendEventsSynchronously.
1842 * WebKitTestRunner/mac/EventSenderProxy.mm:
1843 (WTR::EventSenderProxy::mouseMoveTo): Got rid of WKPageSetShouldSendEventsSynchronously.
1844 (WTR::EventSenderProxy::keyDown): Ditto.
1845 (WTR::EventSenderProxy::mouseScrollBy): Ditto.
1846 (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases): Ditto.
1848 2015-08-21 Yusuke Suzuki <utatane.tea@gmail.com>
1850 Skip no-llint tests that fail due to running out of executable memory after r188969
1851 https://bugs.webkit.org/show_bug.cgi?id=148273
1853 Reviewed by Michael Saboff.
1855 * Scripts/run-jsc-stress-tests:
1857 2015-08-21 Nan Wang <n_wang@apple.com>
1859 [Mac] accessibility/selection-states.html fails
1860 https://bugs.webkit.org/show_bug.cgi?id=116637
1862 Reviewed by Chris Fleizach.
1864 Implemented isSelectable() and isMultiSelectable().
1866 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1867 (AccessibilityUIElement::isSelectable):
1868 (AccessibilityUIElement::isMultiSelectable):
1869 (AccessibilityUIElement::isSelectedOptionActive):
1870 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1871 (WTR::AccessibilityUIElement::isSelectable):
1872 (WTR::AccessibilityUIElement::isMultiSelectable):
1873 (WTR::AccessibilityUIElement::isVisible):
1875 2015-08-21 Jason Marcell <jmarcell@apple.com>
1877 Fix iteration over repositories on bot watcher's dashboard.
1879 Reviewed by Alexey Proskuryakov.
1881 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1882 (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Don't reuse the same index variable.
1884 2015-08-20 Joonghun Park <jh718.park@samsung.com>
1886 [EFL] Revise PlatformWebView ctor according to r188718
1887 https://bugs.webkit.org/show_bug.cgi?id=148282
1889 This patch change PlatformWebView ctor's argument to use WKPageConfigurationRef
1890 instead of WKContextRef and WKPageGroupRef respectively.
1892 Reviewed by Gyuyoung Kim.
1894 * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1895 (WTR::PlatformWebView::PlatformWebView):
1897 2015-08-20 Devin Rousso <dcrousso+webkit@gmail.com>
1899 Unreviewed, changed Devin Rousso's email.
1901 * Scripts/webkitpy/common/config/contributors.json:
1903 2015-08-20 Anders Carlsson <andersca@apple.com>
1905 Use WKPageConfigurationRef in WebKitTestRunner
1906 https://bugs.webkit.org/show_bug.cgi?id=147996
1908 Reviewed by Tim Horton.
1910 * WebKitTestRunner/TestController.cpp:
1911 (WTR::TestController::createOtherPage):
1912 (WTR::TestController::initialize):
1913 (WTR::TestController::createWebViewWithOptions):
1914 * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1915 (-[TestRunnerWKView initWithFrame:configurationRef:useThreadedScrolling:]):
1916 (WTR::PlatformWebView::PlatformWebView):
1917 (-[TestRunnerWKView initWithFrame:contextRef:pageGroupRef:relatedToPage:useThreadedScrolling:]): Deleted.
1919 2015-08-20 Brent Fulgham <bfulgham@apple.com>
1921 [Win] Update Windows tools for revised MIDL interfaces
1922 https://bugs.webkit.org/show_bug.cgi?id=148249
1924 Reviewed by Dean Jackson.
1926 This is a follow-up to Bug 148001.
1928 Revise the testing software to use compatible signatures and
1929 implementations to match the requirements of the IDL generated
1930 with the SAL annotations.
1932 * DumpRenderTree/win/DRTDataObject.cpp:
1933 * DumpRenderTree/win/DRTDataObject.h:
1934 * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
1935 * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
1936 * DumpRenderTree/win/DRTDropSource.cpp:
1937 * DumpRenderTree/win/DRTDropSource.h:
1938 * DumpRenderTree/win/DumpRenderTree.cpp:
1939 * DumpRenderTree/win/EditingDelegate.cpp:
1940 * DumpRenderTree/win/EditingDelegate.h:
1941 * DumpRenderTree/win/FrameLoadDelegate.cpp:
1942 * DumpRenderTree/win/FrameLoadDelegate.h:
1943 * DumpRenderTree/win/HistoryDelegate.cpp:
1944 * DumpRenderTree/win/HistoryDelegate.h:
1945 * DumpRenderTree/win/PolicyDelegate.cpp:
1946 * DumpRenderTree/win/PolicyDelegate.h:
1947 * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1948 * DumpRenderTree/win/ResourceLoadDelegate.h:
1949 * DumpRenderTree/win/TestRunnerWin.cpp:
1950 * DumpRenderTree/win/UIDelegate.cpp:
1951 * DumpRenderTree/win/UIDelegate.h:
1952 * WinLauncher/AccessibilityDelegate.cpp:
1953 * WinLauncher/AccessibilityDelegate.h:
1954 * WinLauncher/Common.cpp:
1955 * WinLauncher/DOMDefaultImpl.cpp:
1956 * WinLauncher/DOMDefaultImpl.h:
1957 * WinLauncher/PageLoadTestClient.cpp:
1958 * WinLauncher/PageLoadTestClient.h:
1959 * WinLauncher/PrintWebUIDelegate.cpp:
1960 * WinLauncher/PrintWebUIDelegate.h:
1961 * WinLauncher/ResourceLoadDelegate.cpp:
1962 * WinLauncher/ResourceLoadDelegate.h:
1963 * WinLauncher/WebDownloadDelegate.cpp:
1964 * WinLauncher/WebDownloadDelegate.h:
1965 * WinLauncher/WinLauncherWebHost.cpp:
1966 * WinLauncher/WinLauncherWebHost.h:
1967 * WinLauncher/WinMain.cpp:
1968 * win/DLLLauncher/DLLLauncherMain.cpp:
1970 2015-08-20 Filip Pizlo <fpizlo@apple.com>
1972 Unreviewed, shorten a test that runs too long and times out.
1974 * TestWebKitAPI/Tests/WTF/Lock.cpp:
1975 (TestWebKitAPI::TEST):
1977 2015-08-20 Alex Christensen <achristensen@webkit.org>
1979 Clean up CMake build after r188673
1980 https://bugs.webkit.org/show_bug.cgi?id=148234
1982 Reviewed by Tim Horton.
1984 * DumpRenderTree/PlatformWin.cmake:
1985 * TestWebKitAPI/CMakeLists.txt:
1986 * TestWebKitAPI/PlatformWin.cmake:
1987 Define WIN_CAIRO so WinCairo executables can find the correct dlls in WebKitLibraries.
1988 gtest needs to be a static library on Windows to not crash.
1990 2015-08-19 Alex Christensen <achristensen@webkit.org>
1992 CMake Windows build should not include files directly from other Source directories
1993 https://bugs.webkit.org/show_bug.cgi?id=148198
1995 Reviewed by Brent Fulgham.
1997 * DumpRenderTree/DumpRenderTreePrefix.h:
1998 Include cmakeconfig.h to properly define all enabled features.
1999 * DumpRenderTree/PlatformWin.cmake:
2000 * TestWebKitAPI/PlatformWin.cmake:
2002 2015-08-19 Alex Christensen <achristensen@webkit.org>
2004 Build TestWTF on Mac with CMake.
2005 https://bugs.webkit.org/show_bug.cgi?id=147972
2007 Reviewed by Tim Horton.
2009 TestWTF only depends on gtest and WTF instead of TestWebKitAPi depending on all of WebKit.
2010 Now I can run the WTF API tests after a few seconds of building instead of waiting for all of WebKit to build.
2012 * TestWebKitAPI/CMakeLists.txt:
2013 Added WTF as a dependency for platforms that do not have ForwardingHeadersForTestWebKitAPI_NAME.
2014 WTF was already a library that was linked, but having at least one item makes the syntax of add_dependencies work.
2015 * TestWebKitAPI/PlatformMac.cmake: Added.
2016 * TestWebKitAPI/config.h:
2017 Postpone some build fixes until WebKit builds completely on Mac with CMake.
2019 2015-08-19 Brian Burg <bburg@apple.com>
2021 Unreviewed, add Aleksandr Skachkov to the list of contributors.
2023 * Scripts/webkitpy/common/config/contributors.json:
2025 2015-08-18 Carlos Alberto Lopez Perez <clopez@igalia.com>
2027 REGRESSION(r188548): [GTK] Build broken.
2028 https://bugs.webkit.org/show_bug.cgi?id=148154
2030 Reviewed by Martin Robinson.
2032 * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2033 (WTR::TestController::updatePlatformSpecificViewOptionsForTest):
2034 Even if we don't need to add/override any settings in ViewOptions,
2035 we need to define this as an empty function to make it build.
2037 2015-08-18 Gyuyoung Kim <gyuyoung.kim@webkit.org>
2039 Fix conversion-null warning in conversion.cpp of TestWebKitAPI
2040 https://bugs.webkit.org/show_bug.cgi?id=148073
2042 Reviewed by Alexey Proskuryakov.
2044 * TestWebKitAPI/Tests/WTF/Condition.cpp: Use EXPECT_FALSE instead of EXPECT_EQ.
2045 (TestWebKitAPI::TEST):
2047 2015-08-18 Anders Carlsson <andersca@apple.com>
2049 Fix test failure fallout from r188602 by using a V5 page ui client struct.
2051 * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
2052 (TestWebKitAPI::setUpClients):
2054 2015-08-18 Brian Burg <bburg@apple.com>
2056 Web Inspector: load ProtocolTestStub from the WebInspectorUI bundle
2057 https://bugs.webkit.org/show_bug.cgi?id=147955
2059 Reviewed by Timothy Hatcher.
2061 To enable sharing of common test code between protocol and model tests,
2062 start loading the protocol TestStub.js through the WebInspectorUI bundle.
2064 This patch adds the read-only getter TestRunner.inspectorTestStubURL, which
2065 protocol-test.js uses to load the inspector frontend stub into its iframe
2066 from an arbitrary local file URL.
2068 * DumpRenderTree/TestRunner.cpp:
2069 (getInspectorTestStubURLCallback):
2070 (TestRunner::staticValues):
2071 * DumpRenderTree/TestRunner.h:
2072 * DumpRenderTree/mac/TestRunnerMac.mm:
2073 (SOFT_LINK_STAGED_FRAMEWORK):
2074 (TestRunner::inspectorTestStubURL):
2075 * DumpRenderTree/win/TestRunnerWin.cpp:
2076 (TestRunner::inspectorTestStubURL):
2077 * WebKitTestRunner/Configurations/Base.xcconfig:
2078 Since WebKitTestRunner now includes WebCore private headers, also search
2079 for the WebCore framework inside the WebKit umbrella framework.
2081 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2082 * WebKitTestRunner/InjectedBundle/TestRunner.h:
2083 * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp:
2084 (WTR::TestRunner::inspectorTestStubURL):
2085 * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
2086 (WTR::TestRunner::inspectorTestStubURL):
2087 * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
2088 (WTR::TestRunner::inspectorTestStubURL):
2090 2015-08-18 Filip Pizlo <fpizlo@apple.com>
2092 Unreviewed, fix GTK build.
2094 * TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp:
2095 (TestWebKitAPI::TEST):
2097 2015-08-17 Filip Pizlo <fpizlo@apple.com>
2099 Replace all remaining uses of WTF::Mutex with WTF::Lock
2100 https://bugs.webkit.org/show_bug.cgi?id=148089
2102 Reviewed by Geoffrey Garen.
2104 * DumpRenderTree/JavaScriptThreading.cpp:
2105 (javaScriptThreadsMutex):
2106 (runJavaScriptThread):
2107 (startJavaScriptThreads):
2108 (stopJavaScriptThreads):
2109 * TestWebKitAPI/Tests/WTF/Condition.cpp: Fixed a bug in the test that I found from turning the test into a benchmark.
2110 * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
2111 (TestWebKitAPI::TEST):
2112 * TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp:
2113 (TestWebKitAPI::TEST):
2115 2015-08-17 Commit Queue <commit-queue@webkit.org>
2117 Unreviewed, rolling out r188539, r188544, r188552, and
2119 https://bugs.webkit.org/show_bug.cgi?id=148122
2121 Broke tests and some build styles (Requested by ap on
2124 Reverted changesets:
2126 "Web Inspector: load ProtocolTestStub from the WebInspectorUI
2128 https://bugs.webkit.org/show_bug.cgi?id=147955
2129 http://trac.webkit.org/changeset/188539
2131 "Web Inspector: split TestStub.js into multiple files and
2133 https://bugs.webkit.org/show_bug.cgi?id=148077
2134 http://trac.webkit.org/changeset/188544
2136 "Web Inspector: InspectorTest should be a subclass of
2138 https://bugs.webkit.org/show_bug.cgi?id=148079
2139 http://trac.webkit.org/changeset/188552
2141 "Unreviewed internal build fix attempt after r188539."
2142 http://trac.webkit.org/changeset/188564
2144 2015-08-17 Myles C. Maxfield <mmaxfield@apple.com>
2146 [OS X] Remove support for composite fonts
2147 https://bugs.webkit.org/show_bug.cgi?id=147920
2149 Reviewed by Dan Bernstein.
2151 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2152 * DumpRenderTree/fonts/SampleFont.sfont: Removed.
2153 * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
2154 * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
2155 * DumpRenderTree/mac/DumpRenderTree.mm:
2156 (allowedFontFamilySet): Deleted.
2157 (activateTestingFonts): Deleted.
2158 * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
2159 (WTR::allowedFontFamilySet): Deleted.
2160 (WTR::activateFonts): Deleted.
2161 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2162 * WebKitTestRunner/fonts/SampleFont.sfont: Removed.
2163 * WebKitTestRunner/mac/TestControllerMac.mm:
2164 (WTR::allowedFontFamilySet): Deleted.
2166 2015-08-17 Jon Honeycutt <jhoneycutt@apple.com>
2168 Unreviewed internal build fix attempt after r188539.
2170 * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
2172 2015-08-17 Myles C. Maxfield <mmaxfield@apple.com>
2178 * TestWebKitAPI/Tests/WTF/StringHasher.cpp:
2180 2015-08-17 Alex Christensen <achristensen@webkit.org>
2182 Build Debug Suffix on Windows with CMake
2183 https://bugs.webkit.org/show_bug.cgi?id=148083
2185 Reviewed by Brent Fulgham.
2187 * TestWebKitAPI/CMakeLists.txt:
2188 * TestWebKitAPI/PlatformWin.cmake:
2191 2015-08-17 Anders Carlsson <andersca@apple.com>
2193 Simplify how PlatformWebViews are created when view options change
2194 https://bugs.webkit.org/show_bug.cgi?id=148093
2196 Reviewed by Sam Weinig.
2198 Instead of letting each port dictate when the PlatformWebView should be recreated we now do the following:
2200 TestController::ensureViewSupportsOptionsForTest gets the view options for a test by calling
2201 TestController::viewOptionsForTest, which returns a filled in ViewOptions struct for a given test. It also allows
2202 ports to add/override settings by calling TestController::updatePlatformSpecificViewOptionsForTest.
2204 If the current PlatformWebView doesn't support the given view options, delete the web view and create a new one.
2206 Also, get rid of the first call to TestController::createWebViewWithOptions in TestController::initialize and
2207 always rely on TestController::ensureViewSupportsOptionsForTest creating a PlatformWebView for us.
2209 * WebKitTestRunner/TestController.cpp:
2210 (WTR::TestController::ensureViewSupportsOptionsForTest):
2211 (WTR::shouldUseFixedLayout):
2212 (WTR::TestController::viewOptionsForTest):
2213 (WTR::TestController::updateWebViewSizeForTest):
2214 (WTR::TestController::updateWindowScaleForTest):
2215 (WTR::TestController::configureViewForTest):
2216 (WTR::TestController::initialize): Deleted.
2217 (WTR::TestController::ensureViewSupportsOptions): Deleted.
2218 (WTR::TestController::updateLayoutTypeForTest): Deleted.
2219 (WTR::TestController::platformConfigureViewForTest): Deleted.
2220 (WTR::TestController::platformResetPreferencesToConsistentValues): Deleted.
2221 (WTR::TestController::run): Deleted.
2222 * WebKitTestRunner/TestController.h:
2223 * WebKitTestRunner/efl/TestControllerEfl.cpp:
2224 (WTR::shouldUseFixedLayout):
2225 (WTR::TestController::updatePlatformSpecificViewOptionsForTest):
2226 (WTR::TestController::platformConfigureViewForTest):
2227 (WTR::TestController::platformResetPreferencesToConsistentValues):
2228 * WebKitTestRunner/ios/TestControllerIOS.mm:
2229 (WTR::TestController::updatePlatformSpecificViewOptionsForTest):
2230 * WebKitTestRunner/mac/TestControllerMac.mm:
2231 (WTR::TestController::updatePlatformSpecificViewOptionsForTest):
2232 (WTR::TestController::platformConfigureViewForTest):
2234 2015-08-17 Sam Weinig <sam@webkit.org>
2236 API::PageConfiguration's sessionID needs to be set whenever the API::WebsiteDataStore is set
2237 https://bugs.webkit.org/show_bug.cgi?id=148097
2239 Reviewed by Anders Carlsson.
2241 * TestWebKitAPI/Tests/WebKit2/WKPageConfiguration.cpp:
2242 Add tests for WebsiteDataStores in the WKPageConfiguration.
2244 2015-08-17 Brian Burg <bburg@apple.com>
2246 Web Inspector: load ProtocolTestStub from the WebInspectorUI bundle
2247 https://bugs.webkit.org/show_bug.cgi?id=147955
2249 Reviewed by Timothy Hatcher.
2251 To enable sharing of common test code between protocol and model tests,
2252 start loading the protocol TestStub.js through the WebInspectorUI bundle.
2254 This patch adds the read-only getter TestRunner.inspectorTestStubURL, which
2255 protocol-test.js uses to load the inspector frontend stub into its iframe
2256 from an arbitrary local file URL.
2258 * DumpRenderTree/TestRunner.cpp:
2259 (getInspectorTestStubURLCallback):
2260 (TestRunner::staticValues):
2261 * DumpRenderTree/TestRunner.h:
2262 * DumpRenderTree/mac/TestRunnerMac.mm:
2263 (SOFT_LINK_STAGED_FRAMEWORK):
2264 (TestRunner::inspectorTestStubURL):
2265 * DumpRenderTree/win/TestRunnerWin.cpp:
2266 (TestRunner::inspectorTestStubURL):
2267 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2268 * WebKitTestRunner/InjectedBundle/TestRunner.h:
2269 * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp:
2270 (WTR::TestRunner::inspectorTestStubURL):
2271 * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
2272 (WTR::TestRunner::inspectorTestStubURL):
2273 * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
2274 (WTR::TestRunner::inspectorTestStubURL):
2276 2015-08-17 Saam barati <sbarati@apple.com>
2278 Change email address from saambarati1@gmail.com to sbarati@apple.com
2280 * Scripts/webkitpy/common/config/contributors.json:
2282 2015-08-17 Jason Marcell <jmarcell@apple.com>
2284 Refactor BuildbotQueueView._presentPopoverForPendingCommits to work more generically with
2285 repositories other than "openSource" and "internal".
2286 https://bugs.webkit.org/show_bug.cgi?id=147961
2288 Reviewed by Daniel Bates.
2290 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2291 (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Refactored to work more
2292 generically with repositories other than "openSource" and "internal".
2294 2015-08-17 Alexey Proskuryakov <ap@apple.com>
2296 build.webkit.org/dashboard shows yellow when crash-only queues have too many failures
2297 https://bugs.webkit.org/show_bug.cgi?id=148081
2299 Reviewed by Tim Horton.
2301 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2302 (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
2304 2015-08-11 Andy Estes <aestes@apple.com>
2306 [Cocoa] Add redirect support to CustomProtocolManager
2307 https://bugs.webkit.org/show_bug.cgi?id=147871
2309 Reviewed by Dan Bernstein.
2311 Updated WebKit2CustomProtocolsTest.MainResource to generate a redirect response.
2313 * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
2314 (TestWebKitAPI::TEST): Unregesitered TestProtocol.
2315 * TestWebKitAPI/Tests/WebKit2/custom-protocol-sync-xhr.html: Changed scheme to http.
2316 * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
2317 (-[CustomProtocolsLoadDelegate browsingContextControllerDidStartProvisionalLoad:]): Expected a certain provisional URL.
2318 (-[CustomProtocolsLoadDelegate browsingContextControllerDidReceiveServerRedirectForProvisionalLoad:]): Ditto.
2319 (-[CustomProtocolsLoadDelegate browsingContextControllerDidCommitLoad:]): Expected a certain committed URL.
2320 (-[CustomProtocolsLoadDelegate browsingContextControllerDidFinishLoad:]): Expected isLoading to be false.
2321 (TestWebKitAPI::TEST): Used the new load delegate and unregistered TestProtocol.
2322 * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
2323 (TestWebKitAPI::TEST): Unregistered TestProtocol.
2324 * TestWebKitAPI/mac/TestProtocol.mm: Changed scheme to http.
2325 (+[TestProtocol canInitWithRequest:]): Changed to use property syntax.
2326 (-[TestProtocol startLoading]): Taught to handle redirect responses.
2328 2015-08-13 Andy Estes <aestes@apple.com>
2330 [Cocoa] Downloads do not start if policy decision is made asynchronously
2331 https://bugs.webkit.org/show_bug.cgi?id=147985
2333 Reviewed by Brady Eidson.
2335 Added a new API test.
2337 * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2338 (-[AsynchronousDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2339 (-[AsynchronousDownloadDelegate _downloadDidStart:]):
2342 2015-08-14 Commit Queue <commit-queue@webkit.org>
2344 Unreviewed, rolling out r187357.
2345 https://bugs.webkit.org/show_bug.cgi?id=148032
2347 webkit-patch generates incorrect patches that cannot be
2348 applied (Requested by dydz on #webkit).
2352 "Call fixChangeLogPatch when generating patches from webkit-
2354 https://bugs.webkit.org/show_bug.cgi?id=147248
2355 http://trac.webkit.org/changeset/187357
2357 2015-08-14 Jason Marcell <jmarcell@apple.com>
2359 Refactor BuildbotQueueView._appendPendingRevisionCount to work more generically with repositories
2360 other than "openSource" and "internal".
2361 https://bugs.webkit.org/show_bug.cgi?id=147938
2363 Reviewed by Daniel Bates.
2365 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2366 (BuildbotQueueView.prototype._appendPendingRevisionCount): Refactored to work more generically with
2367 repositories other than "openSource" and "internal".
2369 2015-08-14 Filip Pizlo <fpizlo@apple.com>
2371 Unreviewed, shorten another test that is timing out.
2373 * TestWebKitAPI/Tests/WTF/Lock.cpp:
2374 (TestWebKitAPI::TEST):
2376 2015-08-13 Aakash Jain <aakash_jain@apple.com>
2378 AppScale: Assertion hit when hovering a webkit-queue bubble
2379 https://bugs.webkit.org/show_bug.cgi?id=147997
2381 Reviewed by Alexey Proskuryakov.
2383 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueue.js:
2384 (BubbleQueue.prototype.loadDetailedStatus): Strip off http(s) before asserting.
2386 2015-08-13 Lucas Forschler <lforschler@apple.com>
2388 Teach Scripts/copy-webkitlibraries-to-product-directory to copy the El Capitan Library.
2392 * Scripts/copy-webkitlibraries-to-product-directory:
2394 2015-08-13 Dewei Zhu <dewei_zhu@apple.com>
2396 Run benchmark customized Dromaeo should not assume there is an internet connection.
2397 https://bugs.webkit.org/show_bug.cgi?id=147995
2399 Reviewed by Ryosuke Niwa.
2401 Add several dependency js libs to local.
2403 * Scripts/webkitpy/benchmark_runner/data/patches/Dromaeo.patch:
2405 2015-08-13 Filip Pizlo <fpizlo@apple.com>
2407 WTF should have a compact Condition object to use with Lock
2408 https://bugs.webkit.org/show_bug.cgi?id=147986
2410 Reviewed by Geoffrey Garen.
2412 Add a test for WTF::Condition.
2414 * TestWebKitAPI/CMakeLists.txt:
2415 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
2416 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2417 * TestWebKitAPI/Tests/WTF/Condition.cpp: Added.
2418 (TestWebKitAPI::TEST):
2419 * TestWebKitAPI/Tests/WTF/Lock.cpp:
2420 (TestWebKitAPI::runLockTest): Change the name of the thread.
2422 2015-08-13 Filip Pizlo <fpizlo@apple.com>
2424 Unreviewed, shorten another test. It's timing out in debug on some bot.
2426 * TestWebKitAPI/Tests/WTF/Lock.cpp:
2427 (TestWebKitAPI::TEST):
2429 2015-08-12 Filip Pizlo <fpizlo@apple.com>
2431 WTF::Lock should not suffer from the thundering herd
2432 https://bugs.webkit.org/show_bug.cgi?id=147947
2434 Reviewed by Geoffrey Garen.
2436 Add testing that checks that locks return to a pristine state after contention is over.
2438 * TestWebKitAPI/Tests/WTF/Lock.cpp:
2439 (TestWebKitAPI::LockInspector::isFullyReset):
2440 (TestWebKitAPI::runLockTest):
2441 (TestWebKitAPI::TEST):
2443 2015-08-12 Dewei Zhu <dewei_zhu@apple.com>
2445 Benchmarks supported by run_benchmark script should not assume we have internet access.
2446 https://bugs.webkit.org/show_bug.cgi?id=147959
2448 Reviewed by Ryosuke Niwa.
2450 For JSBench we should not request jquery.min.js from google through the internet.
2452 * Scripts/webkitpy/benchmark_runner/data/patches/JSBench.patch:
2454 2015-08-12 Jason Marcell <jmarcell@apple.com>
2456 Refactor BuildbotQueueView.revisionContentForIteration to work more generically with repositories
2457 other than "openSource" and "internal".
2458 https://bugs.webkit.org/show_bug.cgi?id=147796
2460 Reviewed by Daniel Bates.
2462 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2463 (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): The "repository" parameter
2464 is now a repository object instead of the repository name, thus we don't have to pass the "trac"
2465 object in separately. Also added an assertion to see if the given repository is in iteration.revision,
2466 and another assertion that, if the previousIteration is non-null, the given repository is in
2467 previousIteration.revision.
2468 (BuildbotQueueView.prototype.revisionContentForIteration): Refactored to work more generically
2469 with repositories other than "openSource" and "internal". Also added an assertion that the returned
2470 fragment has at least one child node.
2472 2015-08-12 Simon Fraser <simon.fraser@apple.com>
2474 Add a tool that dumps class and struct member layout, showing padding
2475 https://bugs.webkit.org/show_bug.cgi?id=147898
2477 Reviewed by Zalan Bujtas.
2479 This 'dump-class-layout' script uses the lldb Python bindings to collect data
2480 about data member layout, and displays it.
2484 +0 { 72} WTF::ListHashSet<WebCore::URL, WebCore::URLHash>::Node
2485 +0 < 56> WebCore::URL m_value;
2486 +0 < 8> WTF::String m_string;
2487 +0 < 8> WTF::RefPtr<WTF::StringImpl> m_impl;
2488 +0 < 8> WTF::StringImpl * m_ptr;
2489 +8 < 1> bool:1 m_isValid;
2490 +8 < 1> bool:1 m_protocolIsInHTTPFamily;
2492 +12 < 4> int m_schemeEnd;
2493 +16 < 4> int m_userStart;
2494 +20 < 4> int m_userEnd;
2495 +24 < 4> int m_passwordEnd;
2496 +28 < 4> int m_hostEnd;
2497 +32 < 4> int m_portEnd;
2498 +36 < 4> int m_pathAfterLastSlash;
2499 +40 < 4> int m_pathEnd;
2500 +44 < 4> int m_queryEnd;
2501 +48 < 4> int m_fragmentEnd;
2504 +56 < 8> WTF::ListHashSetNode<WebCore::URL> * m_prev;
2505 +64 < 8> WTF::ListHashSetNode<WebCore::URL> * m_next;
2508 Padding percentage: 15.28 %
2510 * Scripts/dump-class-layout: Added.
2514 (find_build_directory):
2516 (verify_type_recursive):
2521 2015-08-12 Alex Christensen <achristensen@webkit.org>
2523 Fix Debug CMake builds on Windows
2524 https://bugs.webkit.org/show_bug.cgi?id=147940
2526 Reviewed by Chris Dumez.
2528 * DumpRenderTree/PlatformWin.cmake:
2529 * TestWebKitAPI/PlatformWin.cmake:
2530 The BitmapImage test is not enabled on the AppleWin port.
2531 * WinLauncher/CMakeLists.txt:
2532 Debug builds need /NODEFAULTLIB:MSVCRTD, too.
2534 2015-08-12 Carlos Garcia Campos <cgarcia@igalia.com>
2536 Unreviewed. run-gtk-tests: Use a longer timeout for slow tests.
2538 In r188125 I added a way to mark tests as slow to use a longer
2539 timeout. But it seems it was not enough for
2540 WTF_Lock.ContendedShortSection, so let's try again with a longer
2543 * Scripts/run-gtk-tests:
2544 (TestRunner._run_google_test):
2546 2015-08-12 Yusuke Suzuki <utatane.tea@gmail.com>
2548 Allow --debug option in run-jsc
2549 https://bugs.webkit.org/show_bug.cgi?id=147923
2551 Reviewed by Csaba Osztrogonác.
2553 When `--debug` option is specified in run-jsc, it runs the JSC shell built in the debug mode.
2557 2015-08-11 Alex Christensen <achristensen@webkit.org>
2559 Fix test after build fix in r188286.
2560 https://bugs.webkit.org/show_bug.cgi?id=147907
2562 Reviewed by Anders Carlsson.
2564 * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
2565 sleep_for can now be used, but we need to include <thread>
2567 2015-08-11 Filip Pizlo <fpizlo@apple.com>
2569 Always use a byte-sized lock implementation
2570 https://bugs.webkit.org/show_bug.cgi?id=147908
2572 Reviewed by Geoffrey Garen.
2574 All previous tests of Lock are now tests of WordLock. All previous tests of ByteLock are
2577 * TestWebKitAPI/Tests/WTF/Lock.cpp:
2578 (TestWebKitAPI::runLockTest):
2579 (TestWebKitAPI::TEST):
2581 2015-08-11 Alexey Proskuryakov <ap@apple.com>
2583 Make ASan build not depend on asan.xcconfig
2584 https://bugs.webkit.org/show_bug.cgi?id=147840
2585 rdar://problem/21093702
2587 Reviewed by Daniel Bates.
2589 * asan/asan.xcconfig:
2590 * asan/webkit-asan-ignore.txt: Removed. It's no longer needed, as unsafe functions
2591 are now marked in source code.
2593 2015-08-11 Filip Pizlo <fpizlo@apple.com>
2595 Unreviewed, shorten another test since it timed out.
2597 * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
2598 (TestWebKitAPI::TEST):
2600 2015-08-11 Mark Lam <mark.lam@apple.com>
2602 Fix names of Lock tests: should be "Contended", not "Contented".
2603 https://bugs.webkit.org/show_bug.cgi?id=147905
2605 Reviewed by Saam Barati.
2607 We're testing the behavior of lock contention (i.e. when threads contend), not
2608 whether the locks are happy (contented).
2610 * Scripts/run-gtk-tests:
2612 (TestRunner.__init__): Deleted.
2613 * TestWebKitAPI/Tests/WTF/Lock.cpp:
2614 (TestWebKitAPI::runLockTest):
2615 (TestWebKitAPI::TEST):
2617 2015-08-11 Alex Christensen <achristensen@webkit.org>
2619 Update WinCairoRequirements to VS2015.
2621 * Scripts/update-webkit-wincairo-libs:
2622 Update WinCairoRequirements location.
2624 2015-08-11 Jason Marcell <jmarcell@apple.com>
2626 Substituted Dashboard.Repository.OpenSource.trac for webkitTrac and Dashboard.Repository.Internal.trac
2628 https://bugs.webkit.org/show_bug.cgi?id=147805
2630 Reviewed by Daniel Bates.
2632 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2633 (BuildbotQueueView): Substituted Dashboard.Repository.OpenSource.trac for webkitTrac and
2634 Dashboard.Repository.Internal.trac for internalTrac.
2635 (BuildbotQueueView.prototype._appendPendingRevisionCount): Added local variables webkitTrac
2636 and internalTrac for Dashboard.Repository.OpenSource.trac and Dashboard.Repository.Internal.trac,
2638 (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Ditto.
2639 (BuildbotQueueView.prototype.revisionContentForIteration): Substituted
2640 Dashboard.Repository.OpenSource.trac for webkitTrac and Dashboard.Repository.Internal.trac for
2642 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js: Ditto.
2643 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Ditto.
2644 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
2646 (Analyzer.prototype.analyze): Ditto.
2648 2015-08-11 Filip Pizlo <fpizlo@apple.com>
2650 Unreviewed, gardening these tests to run faster so that they don't timeout on slower OSes.
2652 * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
2653 (TestWebKitAPI::TEST):
2655 2015-08-11 Brent Fulgham <bfulgham@apple.com>
2657 [Win] Switch Windows build to Visual Studio 2015
2658 https://bugs.webkit.org/show_bug.cgi?id=147887
2659 <rdar://problem/22235098>
2661 Reviewed by Alex Christensen.
2663 Update Visual Studio project file settings to use the current Visual
2664 Studio and compiler. Continue targeting binaries to run on our minimum
2665 supported configuration of Windows 7.
2667 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
2668 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
2669 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
2670 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
2671 * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
2672 * Scripts/webkitdirs.pm: Modify our Visual Studio search routines to
2673 prefer the newer MSBuild included in Visual Studio 2015.
2674 (visualStudioInstallDir):
2675 (msBuildInstallDir):
2676 (visualStudioVersion):
2677 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
2678 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
2679 * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
2680 * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
2681 * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj:
2682 * win/record-memory/record-memory.vcxproj:
2684 2015-08-11 Alex Christensen <achristensen@webkit.org>
2686 Another speculative build fix after r188280.
2688 * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
2689 std::this_thread is too modern c++ for VS2013 and supported GCC versions,
2690 so let's go back to usleep and I made something close to usleep, but with much lower resolution.
2692 2015-08-11 Alex Christensen <achristensen@webkit.org>
2694 Unreviewed build fix after r188280.
2696 * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
2697 Include DataLog.h, and usleep is not available on Windows, so I used what I think is the c++11 equivalent.
2699 2015-08-10 Filip Pizlo <fpizlo@apple.com>
2701 WTF should have a ParkingLot for parking sleeping threads, so that locks can fit in 1.6 bits
2702 https://bugs.webkit.org/show_bug.cgi?id=147665
2704 Reviewed by Mark Lam.
2706 * TestWebKitAPI/CMakeLists.txt:
2707 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
2708 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2709 * TestWebKitAPI/Tests/WTF/Lock.cpp:
2710 (TestWebKitAPI::TEST):
2711 * TestWebKitAPI/Tests/WTF/ParkingLot.cpp: Added.
2712 (TestWebKitAPI::TEST):
2714 2015-08-11 Brian Burg <bburg@apple.com>
2716 webkit-patch should not explode when $EDITOR is set incorrectly
2717 https://bugs.webkit.org/show_bug.cgi?id=147884
2719 Reviewed by Darin Adler.
2721 If $EDITOR doesn't exist, log a warning and continue.
2723 * Scripts/webkitpy/common/system/user.py:
2725 (User.edit_changelog):
2727 2015-08-11 Dan Bernstein <mitz@apple.com>
2729 Reverted r188255, because it turned out that delegates do nonot need this information.
2731 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2732 * TestWebKitAPI/Tests/WebKit2Cocoa/PrintFrame.mm: Removed.
2734 2015-08-11 Dan Bernstein <mitz@apple.com>
2736 [Cocoa] The UI delegate can't tell if printing was user-initiated
2737 https://bugs.webkit.org/show_bug.cgi?id=147869
2739 Reviewed by Sam Weinig.
2741 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2742 * TestWebKitAPI/Tests/WebKit2Cocoa/PrintFrame.mm: Added.
2743 (-[PrintFrameController webView:didFinishNavigation:]):
2744 (-[PrintFrameController _webView:printFrame:userInitiated:]):
2747 2015-08-10 Alex Christensen <achristensen@webkit.org>
2749 Another build fix after r188239.
2751 * TestWebKitAPI/PlatformWin.cmake:
2752 Link with more libraries.
2753 * WinLauncher/CMakeLists.txt:
2754 /NODEFAULTLIB:MSVCRT is not just needed for AppleWin.
2756 2015-08-10 Ryosuke Niwa <rniwa@webkit.org>
2758 Build fix after r188237.
2760 * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
2761 (BenchmarkBuilder.__enter__):
2763 2015-08-10 Dewei Zhu <dewei_zhu@apple.com>
2765 Update ReadMe and correct the way to use abstract abstract class.
2766 https://bugs.webkit.org/show_bug.cgi?id=147860
2768 Reviewed by Ryosuke Niwa.
2770 Update ReadMe according to recent changes. And set ABCMeta to be the __metaclass__ of BrowserDriver and HTTPServerDriver,
2771 so that all methods annotated by 'abstractmethod' will check whether they are implememnt by subclasses.
2773 * Scripts/webkitpy/benchmark_runner/README.md:
2774 * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
2776 * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
2777 (OSXBrowserDriver.restore_env):
2778 * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py:
2780 (HTTPServerDriver.set_device_id):
2781 * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
2782 (SimpleHTTPServerDriver.get_return_code):
2783 (SimpleHTTPServerDriver):
2784 (SimpleHTTPServerDriver.set_device_id):
2786 2015-08-10 Alex Christensen <achristensen@webkit.org>
2788 Build TestWebKitAPI with CMake on Windows
2789 https://bugs.webkit.org/show_bug.cgi?id=147851
2791 Reviewed by Chris Dumez.
2794 * TestWebKitAPI/CMakeLists.txt:
2795 Removed TestJavaScriptCore because JavaScriptCore's API tests are elsewhere and this was just making an empty binary.
2796 Surrounded WebKit2-specific features with ENABLE_WEBKIT2 checks.
2797 Include directories after the Platform*.cmake is included because HostWindow.h needs to be found in Tools/TestWebKitAPI/win
2798 before we look in Source/WebCore/platform, where another file named HostWindow.h exists.
2799 * TestWebKitAPI/PlatformEfl.cmake:
2800 * TestWebKitAPI/PlatformGTK.cmake:
2801 Windows needs all the binaries to be in the same directory to find gtest.dll and the other dlls.
2802 I did this without changing the directory structure of the existing EFL and GTK builds.
2803 * TestWebKitAPI/PlatformWin.cmake: Added.
2804 * TestWebKitAPI/win/main.cpp:
2806 (dllLauncherEntryPoint):
2807 Added so we can launch TestWebKitAPI executables after finding the AAS directory.
2808 * WinLauncher/CMakeLists.txt:
2809 AppleWin port needs /NODEFAULTLIB:MSVCRT.
2811 2015-08-10 Dewei Zhu <dewei_zhu@apple.com>
2813 Make cleanup more robust and minor code cleaning in run benchmark script.
2814 https://bugs.webkit.org/show_bug.cgi?id=147800
2816 Reviewed by Ryosuke Niwa.
2818 Use 'finnaly' block to make sure cleanup code is always executed.
2820 * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2822 (built_benchmark.__init__):
2823 (built_benchmark.__enter__):
2824 (built_benchmark.__exit__):
2826 (test_environment.__init__):
2827 (test_environment.__enter__):
2828 (test_environment.__exit__):
2829 (BenchmarkRunner.__init__):
2830 (BenchmarkRunner.execute):
2831 (BenchmarkRunner._dump):
2832 (BenchmarkRunner._wrap):
2833 (BenchmarkRunner): Deleted.
2834 (BenchmarkRunner._cleanup): Deleted.
2835 * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
2836 (BrowserDriver.close_browsers):
2838 (BrowserDriver.restore_env):
2839 * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
2840 (SimpleHTTPServerDriver.__init__): We do not actually need to know external ip address for now.
2842 2015-08-10 Youenn Fablet <youenn.fablet@crf.canon.fr>
2844 Compile warning (-Wsign-compare) on 32-bits at WebCore/platform/FileSystem.cpp
2845 https://bugs.webkit.org/show_bug.cgi?id=146414
2847 Reviewed by Darin Adler.
2849 * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
2850 (TestWebKitAPI::TEST): Improving testing of WTF::isInBounds.
2852 2015-08-10 Carlos Garcia Campos <cgarcia@igalia.com>
2854 [GTK] Test /webkit2/WebKitWebView/submit-form is flaky
2855 https://bugs.webkit.org/show_bug.cgi?id=147727
2857 Reviewed by Sergio Villar Senin.
2859 I think it was not this test in particular, but
2860 /webkit2/WebKitWebView/custom-charset that is affecting the
2861 others. This is because changing the encoding reloads the page,
2862 but we don't wait for the page to be reloaded, so when the test
2863 finishes and other test starts the web process is still reloading
2866 * Scripts/run-gtk-tests:
2867 (TestRunner): Unskip /webkit2/WebKitWebView/submit-form.
2868 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2869 (testWebViewCustomCharset): Wait until page is reloaded after
2870 changing the charset.
2872 2015-08-09 Carlos Garcia Campos <cgarcia@igalia.com>
2874 Unreviewed. Skip GTK+ test /webkit2/WebKitWebView/install-missing-plugins-permission-request.
2876 It's timing out in the bots. My guess is that there's no installer
2877 installed in the bots and gst_install_plugins_supported() returns
2878 false, so we don't even get a permission request because no
2879 installer will be launched.
2881 * Scripts/run-gtk-tests:
2884 2015-08-07 Alex Christensen <achristensen@webkit.org>
2886 [GTK] Another build fix after r188157.
2888 * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2889 (WTR::PlatformWebView::viewSupportsOptions):
2890 Name all the things correctly!
2892 2015-08-07 Alex Christensen <achristensen@webkit.org>
2894 [EFL, GTK] Build fix after r188176.
2896 * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
2897 I moved forwarding headers out of a unix subdirectory because I am using them on Windows now.
2899 2015-08-07 Alex Christensen <achristensen@webkit.org>
2901 [GTK] Speculative build fix after r188157.
2903 * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2904 (WTR::PlatformWebView::PlatformWebView):
2905 Update parameter list.
2907 2015-08-07 Alex Christensen <achristensen@webkit.org>
2909 Build more testing binaries with CMake on Windows
2910 https://bugs.webkit.org/show_bug.cgi?id=147799
2912 Reviewed by Brent Fulgham.
2914 * DumpRenderTree/CMakeLists.txt:
2915 Build TestNetscapePlugin.
2916 * DumpRenderTree/PlatformWin.cmake:
2917 Build ImageDiff and add files necessary for TestNetscapePlugin on Windows.
2918 * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders: Added.
2919 * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit: Added.
2920 * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: Copied from DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npapi.h.
2921 * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Copied from DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npfunctions.h.
2922 * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h: Copied from DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npruntime.h.
2923 * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npapi.h: Removed.
2924 * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npfunctions.h: Removed.
2925 * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npruntime.h: Removed.
2927 2015-08-07 Jason Marcell <jmarcell@apple.com>
2929 Refactor BuildbotQueue.compareIterations and BuildbotQueue.compareIterationsByRevisions to be more generic
2930 https://bugs.webkit.org/show_bug.cgi?id=147667
2932 Reviewed by Daniel Bates.
2934 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2935 (BuildbotQueue.prototype.compareIterations): Refactored to work more generically with repositories
2936 other than "openSource" and "internal".
2937 (BuildbotQueue.prototype.compareIterationsByRevisions): Ditto.
2938 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2939 (Dashboard.get sortedPlatforms): Added. Returns a sorted array of platforms.
2940 (Dashboard.get sortedRepositories): Added. Returns a sorted array of repositories.
2941 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
2942 (documentReady): Using Dashboard.sortedPlatforms instead of sortedPlatforms.
2943 (sortedPlatforms): Deleted.
2944 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
2945 (buildQueuesTable): Using Dashboard.sortedPlatforms instead of sortedPlatforms.
2946 (sortedPlatforms): Deleted.
2947 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
2948 (sortDictionariesByOrder): Added. Takes an array of dictionaries that have an "order" property
2949 and sorts them by this property returning the new sorted array.
2951 2015-08-07 Filip Pizlo <fpizlo@apple.com>
2953 Lightweight locks should be adaptive
2954 https://bugs.webkit.org/show_bug.cgi?id=147545
2956 Reviewed by Geoffrey Garen.
2958 * TestWebKitAPI/CMakeLists.txt:
2959 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
2960 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2961 * TestWebKitAPI/Tests/WTF/Lock.cpp: Added.
2962 (TestWebKitAPI::runLockTest):
2963 (TestWebKitAPI::TEST):
2965 2015-08-07 Anders Carlsson <andersca@apple.com>
2969 * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2970 (WTR::PlatformWebView::viewSupportsOptions):
2972 2015-08-07 Alexey Proskuryakov <ap@apple.com>
2974 Update AppEngine app version numbers to the latest commit.
2976 * QueueStatusServer/app.yaml:
2977 * TestResultServer/app.yaml:
2979 2015-08-07 Anders Carlsson <andersca@apple.com>
2981 Simplify WKTR's view options
2982 https://bugs.webkit.org/show_bug.cgi?id=147791
2984 Reviewed by Sam Weinig.
2986 Instead of using a WKDictionaryRef, just use a struct for the options.
2988 * WebKitTestRunner/PlatformWebView.h:
2989 (WTR::PlatformWebView::options):
2990 (WTR::PlatformWebView::viewSupportsOptions): Deleted.
2991 * WebKitTestRunner/TestController.cpp:
2992 (WTR::TestController::initialize):
2993 (WTR::TestController::createWebViewWithOptions):
2994 (WTR::TestController::ensureViewSupportsOptions):
2995 (WTR::TestController::updateLayoutTypeForTest):
2996 * WebKitTestRunner/TestController.h:
2997 * WebKitTestRunner/ViewOptions.h: Added.
2998 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2999 * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
3000 (WTR::PlatformWebView::PlatformWebView):
3001 (WTR::PlatformWebView::viewSupportsOptions):
3002 * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3003 (WTR::PlatformWebView::viewSupportsOptions):
3004 * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3005 (WTR::PlatformWebView::viewSupportsOptions):
3006 * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3007 (WTR::PlatformWebView::PlatformWebView):
3008 (WTR::PlatformWebView::viewSupportsOptions):
3009 * WebKitTestRunner/mac/TestControllerMac.mm:
3010 (WTR::TestController::platformConfigureViewForTest):
3012 2015-08-07 Joseph Pecoraro <pecoraro@apple.com>
3014 Running tests for a long time results in some tests running very slowly (throttling)
3015 https://bugs.webkit.org/show_bug.cgi?id=147718
3017 Reviewed by Chris Dumez.
3019 Follow-up, make DumpRenderTree consistent with WebKitTestRunner.
3020 Although COCOA ports default this setting to be disabled in WebKit1,
3021 we should make both test harnesses disable the setting for consistency.
3023 * DumpRenderTree/mac/DumpRenderTree.mm:
3024 (resetWebPreferencesToConsistentValues):
3026 2015-08-07 Ryosuke Niwa <rniwa@webkit.org>
3028 Use a specific version of Speedometer in run-benchmark
3029 https://bugs.webkit.org/show_bug.cgi?id=147769
3031 Reviewed by Chris Dumez.
3033 Use the current latest revision as we work towards the bug 147768 (Update frameworks in Speedometer).
3035 * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan:
3037 2015-08-07 Ryosuke Niwa <rniwa@webkit.org>
3039 twisted_http_server.py should support --port
3040 https://bugs.webkit.org/show_bug.cgi?id=147771
3042 Reviewed by Chris Dumez.
3044 Added the option. This makes the script more useful on its own.
3046 * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
3048 2015-08-07 Carlos Garcia Campos <cgarcia@igalia.com>
3050 [GTK] WTF unit tests are timing out in the bots
3051 https://bugs.webkit.org/show_bug.cgi?id=147777
3053 Reviewed by Filip Pizlo.
3055 Add a way to mark google unit tests as slow and add
3056 WTF_Lock.ContentedShortSection to the list. In case of slow test
3057 we use the double of the given timeout for that particular test.
3059 * Scripts/run-gtk-tests:
3061 (TestRunner._run_google_test):
3063 2015-08-07 Carlos Garcia Campos <cgarcia@igalia.com>
3065 [GTK] run-gtk-tests should not stop when a google test case fails
3066 https://bugs.webkit.org/show_bug.cgi?id=147778
3068 Reviewed by Philippe Normand.
3070 For glib based tests we run the test runner with the -k option,
3071 but for google tests we are aborting as soon as we find a failure.
3073 * Scripts/run-gtk-tests:
3074 (TestRunner._run_google_test_suite): Use a global return code that
3075 is set to 1 when any test has failed.
3077 2015-08-07 Carlos Garcia Campos <cgarcia@igalia.com>
3079 [GStreamer] Do not automatically show PackageKit codec installation notifications
3080 https://bugs.webkit.org/show_bug.cgi?id=135973
3082 Reviewed by Philippe Normand.
3084 Handle the missing media plugins installation permission request
3085 in MiniBrowser and add a test case for the new API.
3087 * MiniBrowser/gtk/BrowserWindow.c:
3088 (webViewDecidePermissionRequest):
3089 * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
3090 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
3091 (permissionRequestCallback):
3092 (testInstallMissingPluginsPermissionRequest):
3094 * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
3095 (methodCallCallback):
3097 2015-08-06 Joseph Pecoraro <pecoraro@apple.com>
3099 Running tests for a long time results in some tests running very slowly (throttling)
3100 https://bugs.webkit.org/show_bug.cgi?id=147718
3102 Reviewed by Alexey Proskuryakov.
3104 * WebKitTestRunner/TestController.cpp:
3105 (WTR::TestController::resetPreferencesToConsistentValues):
3106 Ensure throttling settings are disabled for tests for all ports, as
3107 COCOA ports default to having these setting enabled. Note, there is
3108 still other timer throttling not covered by these setting.
3110 2015-08-06 Ryosuke Niwa <rniwa@webkit.org>
3112 http_server_driver and benchmark_builder should not be in run-benchmark's plan files
3113 https://bugs.webkit.org/show_bug.cgi?id=147752
3115 Reviewed by Chris Dumez.
3117 Removed BenchmarkBuilderFactory since we have exactly one subclass of BenchmarkBuilder.
3119 Also made HTTPServerDriverFactory instantiate the appropriate HTTP server based on the platform name instead of HTTP server name.
3120 This allows us to remove --http-server-driver option from run-benchmark, which was added to support the HTTP server for iOS.
3122 * Scripts/webkitpy/benchmark_runner/benchmark_builder: Removed.
3123 * Scripts/webkitpy/benchmark_runner/benchmark_builder.py: Moved from benchmark_runner/benchmark_builder/generic_benchmark_builder.py.
3124 * Scripts/webkitpy/benchmark_runner/benchmark_builder/__init__.py: Removed.
3125 * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builder_factory.py: Removed.
3126 * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py: Moved to benchmark_runner/benchmark_builder.py.
3127 * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
3128 (BenchmarkRunner.__init__): No longer takes http_server_driver_override as an argument since this is not handled by
3129 HTTPServerDriverFactory taking the platform name as an argument.
3130 (BenchmarkRunner.execute): Directly instantiate BenchmarkBuilder.
3131 * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-cssquery.plan: Removed http_server_driver and benchmark_builder.
3132 * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-dom.plan: Ditto.
3133 * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-jslib.plan: Ditto.
3134 * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Ditto.
3135 * Scripts/webkitpy/benchmark_runner/data/plans/jsbench.plan: Ditto.
3136 * Scripts/webkitpy/benchmark_runner/data/plans/kraken.plan: Ditto.
3137 * Scripts/webkitpy/benchmark_runner/data/plans/octane.plan: Ditto.
3138 * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan: Ditto.
3139 * Scripts/webkitpy/benchmark_runner/data/plans/sunspider.plan: Ditto.
3140 * Scripts/webkitpy/benchmark_runner/http_server_driver/__init__.py:
3141 (http_server_driver_loader): Register http server drivers via supported platform names instead of http server names.
3142 * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py:
3143 (HTTPServerDriver): Replaced name by platforms.
3144 * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
3145 (SimpleHTTPServerDriver): Ditto.
3146 * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
3147 (parse_args): Removed --http-server-driver option.
3150 2015-08-06 Chris Dumez <cdumez@apple.com>
3152 Toggle GPS state based on page visibility to save battery
3153 https://bugs.webkit.org/show_bug.cgi?id=147685
3155 Reviewed by Benjamin Poulain.
3157 Add testRunner.isGeolocationProviderActive() test support function.
3159 * DumpRenderTree/TestRunner.cpp:
3160 (isGeolocationProviderActiveCallback):
3161 (TestRunner::staticFunctions):
3162 * DumpRenderTree/TestRunner.h:
3163 * DumpRenderTree/mac/MockGeolocationProvider.h:
3164 * DumpRenderTree/mac/MockGeolocationProvider.mm:
3165 (-[MockGeolocationProvider isActive]):
3166 * DumpRenderTree/mac/TestRunnerMac.mm:
3167 (TestRunner::isGeolocationProviderActive):
3168 * DumpRenderTree/win/TestRunnerWin.cpp:
3169 (TestRunner::isGeolocationProviderActive):
3170 * WebKitTestRunner/GeolocationProviderMock.h:
3171 (WTR::GeolocationProviderMock::isActive):
3172 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3173 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3174 (WTR::InjectedBundle::isGeolocationProviderActive):
3175 * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3176 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3177 (WTR::TestRunner::isGeolocationProviderActive):
3178 * WebKitTestRunner/InjectedBundle/TestRunner.h:
3179 * WebKitTestRunner/TestController.cpp:
3180 (WTR::TestController::isGeolocationProviderActive):
3181 * WebKitTestRunner/TestController.h:
3182 * WebKitTestRunner/TestInvocation.cpp:
3183 (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3185 2015-08-06 Ryosuke Niwa <rniwa@webkit.org>
3187 Automate JSBench with run-benchmark
3188 https://bugs.webkit.org/show_bug.cgi?id=147716
3190 Reviewed by Chris Dumez.
3192 Added JSBench plan to run-benchmark.
3194 * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py:
3195 (GenericBenchmarkBuilder.prepare): Pass in the archive type to _fetch_remote_archive.
3196 (GenericBenchmarkBuilder._fetch_remote_archive): Added the support for extracting files from tar.gz in addition to zip.
3197 * Scripts/webkitpy/benchmark_runner/data/patches/Dromaeo.patch: Fixed the coding style.
3198 * Scripts/webkitpy/benchmark_runner/data/patches/JSBench.patch: Added.
3199 * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Fixed the coding style.
3200 * Scripts/webkitpy/benchmark_runner/data/patches/Kraken.patch: Ditto.
3201 * Scripts/webkitpy/benchmark_runner/data/patches/Octane.patch: Ditto.
3202 * Scripts/webkitpy/benchmark_runner/data/patches/SunSpider.patch: Ditto.
3203 * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-cssquery.plan: Specified the archive type.
3204 * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-dom.plan: Specified the archive type.
3205 * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-jslib.plan: Ditto.
3206 * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Fixed the coding style.
3207 * Scripts/webkitpy/benchmark_runner/data/plans/jsbench.plan: Added.
3208 * Scripts/webkitpy/benchmark_runner/data/plans/kraken.plan: Specified the archive type.
3209 * Scripts/webkitpy/benchmark_runner/data/plans/octane.plan: Ditto.
3211 2015-08-06 Yusuke Suzuki <utatane.tea@gmail.com>
3213 Pass-through the undefined options in run-jsc
3214 https://bugs.webkit.org/show_bug.cgi?id=147717
3216 Undefined options in run-jsc is just passed to the actual jsc shell.
3217 We can execute `Tools/Scripts/run-jsc -d`.
3219 Reviewed by Csaba Osztrogonác.
3223 2015-08-06 Carlos Garcia Campos <cgarcia@igalia.com>
3225 Unreviewed. Skip GTK+ test /webkit2/WebKitWebView/submit-form.
3229 * Scripts/run-gtk-tests:
3232 2015-08-06 Csaba Osztrogonác <ossy@webkit.org>
3234 [EFL] Bump EFL version to 1.15.0
3235 https://bugs.webkit.org/show_bug.cgi?id=147450
3237 Reviewed by Gyuyoung Kim.
3239 * efl/jhbuild.modules:
3241 2015-08-06 Carlos Garcia Campos <cgarcia@igalia.com>
3243 Unreviewed. Unksip TestContextMenu GTK+ API test.
3245 This has been skipped for a long time, and it's very
3246 unconvenient. It has never failed for me locally, so let's try
3247 again to see if it works in the bots. I'll skip it again if it
3250 * Scripts/run-gtk-tests:
3253 2015-08-05 Filip Pizlo <fpizlo@apple.com>
3255 Unreviewed, roll out http://trac.webkit.org/changeset/187972.
3257 * DumpRenderTree/JavaScriptThreading.cpp:
3258 (javaScriptThreadsMutex):
3259 (runJavaScriptThread):
3260 (startJavaScriptThreads):
3261 (stopJavaScriptThreads):
3262 * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
3263 (TestWebKitAPI::TEST):
3264 * TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp:
3265 (TestWebKitAPI::TEST):
3267 2015-08-05 Alex Christensen <achristensen@webkit.org>
3269 Build DumpRenderTree with CMake.
3270 https://bugs.webkit.org/show_bug.cgi?id=147519
3272 Reviewed by Brent Fulgham.
3275 Build the DumpRenderTree directory now that it builds successfully.
3276 * DumpRenderTree/CMakeLists.txt:
3277 Added missing source file and don't link with WebCore.lib.
3278 * DumpRenderTree/PlatformWin.cmake:
3279 Added sources to DumpRenderTreeLib and made DumpRenderTree only build DLLLauncherMain.cpp.
3280 * WinLauncher/CMakeLists.txt:
3281 We need libcmt now that we are not linking with WebCore.lib.
3283 2015-08-05 Alexey Proskuryakov <ap@apple.com>
3285 AppScale: Use https URLs for subresources and links
3286 https://bugs.webkit.org/show_bug.cgi?id=147686
3288 Reviewed by Ryosuke Niwa.
3290 * QueueStatusServer/filters/webkit_extras.py:
3291 * TestResultServer/static-dashboards/dashboard_base.js:
3292 * TestResultServer/static-dashboards/flakiness_dashboard.js:
3293 * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3294 * TestResultServer/static-dashboards/treemap.js:
3295 * TestResultServer/static-dashboards/ui.js:
3297 2015-08-04 Filip Pizlo <fpizlo@apple.com>
3299 Rename Mutex to DeprecatedMutex
3300 https://bugs.webkit.org/show_bug.cgi?id=147675
3302 Reviewed by Geoffrey Garen.
3304 * DumpRenderTree/JavaScriptThreading.cpp:
3305 (javaScriptThreadsMutex):
3306 (runJavaScriptThread):
3307 (startJavaScriptThreads):
3308 (stopJavaScriptThreads):
3309 * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
3310 (TestWebKitAPI::TEST):
3311 * TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp:
3312 (TestWebKitAPI::TEST):
3314 2015-08-05 Timothy Hatcher <timothy@apple.com>
3316 Update the WebKit nightly icon
3317 https://bugs.webkit.org/show_bug.cgi?id=147684
3319 Reviewed by Sam Weinig.
3321 * WebKitLauncher/webkit.icns: Replaced.
3323 2015-08-05 Daniel Bates <dabates@apple.com>
3325 REGRESSION (r185111): Clicking phone numbers doesn't prompt to call sometimes
3326 https://bugs.webkit.org/show_bug.cgi?id=147678
3327 <rdar://problem/21827815>
3329 Reviewed by Brady Eidson.
3331 Add a test to ensure that we restore the "should open external URLs" policy on
3332 page reload after the web content process crashes.
3334 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3335 * TestWebKitAPI/Tests/WebKit2/should-open-external-schemes.html: Added.
3336 * TestWebKitAPI/Tests/WebKit2Cocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
3339 2015-08-04 Hunseop Jeong <hs85.jeong@samsung.com>
3341 [EFL] Editing tests have been broken since r186694
3342 https://bugs.webkit.org/show_bug.cgi?id=146888
3344 Reviewed by Brent Fulgham.
3346 Restored some codes for the context click on GTK+ and EFL port.
3348 * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3349 (WTR::EventSendingController::contextClick): Seperated the codes using the PLATFORM guard.
3351 2015-08-04 Dewei Zhu <dewei_zhu@apple.com>
3353 Install twisted package for http server when necessary.
3354 https://bugs.webkit.org/show_bug.cgi?id=147082
3356 Reviewed by Ryosuke Niwa.
3358 * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
3359 * Scripts/webkitpy/thirdparty/__init__.py:
3360 (AutoinstallImportHook.find_module):
3361 (AutoinstallImportHook._install_twisted):
3363 2015-08-04 Brent Fulgham <bfulgham@apple.com>
3365 [Win] Update Apple Windows build for VS2015
3366 https://bugs.webkit.org/show_bug.cgi?id=147653
3368 Reviewed by Dean Jackson.
3370 * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/PluginTest.h: If building with
3371 something older than VS2015, define snprintf as _snprintf.
3372 * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginCommon.props:
3373 Remove unneeded macro definition for snprintf.
3374 * Scripts/webkitpy/common/system/platforminfo.py:
3375 (PlatformInfo._determine_win_version): Recognize Windows 10.
3376 * Scripts/webkitpy/port/win.py:
3378 * Scripts/webkitpy/port/win_unittest.py:
3379 (WinPortTest.test_baseline_search_path): Include Windows 10 in tests.
3380 (WinPortTest._assert_version): Ditto.
3382 2015-08-04 Brian Burg <bburg@apple.com>
3384 Unreviewed, update email addresses in contributors.json and watchlist.
3386 * Scripts/webkitpy/common/config/contributors.json:
3387 * Scripts/webkitpy/common/config/watchlist:
3389 2015-08-04 Alexey Proskuryakov <ap@apple.com>
3391 Implement NPAPI redirect handling
3392 https://bugs.webkit.org/show_bug.cgi?id=138675
3393 rdar://problem/15779101
3395 Patch by Jeffrey Pfau, updated and tweaked by me.
3397 Reviewed by Anders Carlsson.
3399 * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
3400 * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj.filters:
3401 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3402 * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
3403 * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
3404 (PluginTest::NPP_URLNotify):
3405 (PluginTest::NPP_URLRedirectNotify):
3406 (PluginTest::NPP_GetValue):
3407 (PluginTest::NPN_GetURLNotify):
3408 (PluginTest::NPN_PostURLNotify):
3409 (PluginTest::NPN_GetValue):
3410 (PluginTest::NPN_ReleaseVariantValue):
3411 (PluginTest::NPN_URLRedirectResponse):
3412 (PluginTest::NPN_ConvertPoint):
3413 * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
3414 * DumpRenderTree/TestNetscapePlugIn/Tests/URLRedirect.cpp: Added.
3415 (URLRedirect::URLRedirect):
3416 (URLRedirect::ScriptableObject::hasMethod):
3417 (URLRedirect::ScriptableObject::get):
3418 (URLRedirect::ScriptableObject::serviceAsync):
3419 (URLRedirect::ScriptableObject::invoke):
3420 (URLRedirect::NPP_GetValue):
3421 (URLRedirect::NPP_URLNotify):
3422 (URLRedirect::NPP_URLRedirectNotify):
3423 * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3424 (NP_GetEntryPoints):
3426 (NPP_URLRedirectNotify):
3429 2015-08-04 Tim Horton <timothy_horton@apple.com>
3431 Move Matt Daiter to committers.
3433 * Scripts/webkitpy/common/config/contributors.json:
3435 2015-08-04 Brent Fulgham <bfulgham@apple.com>
3437 [Win] build-webkit and MSBuild fight over BuildOutput.htm, causing build failures.
3438 https://bugs.webkit.org/show_bug.cgi?id=147636
3440 Reviewed by Alex Christensen.
3442 We no longer need build-webkit to manually troll the log data and pipe it to stdout; MSBuild is already doing this properly.
3443 Stop the build-webkit script from interacting with BuildOutput.htm, thereby preventing a potential build failure (especially
3446 * Scripts/build-webkit:
3448 2015-08-04 Jason Marcell <jmarcell@apple.com>
3450 Refactor to convert openSourceRevision and internalRevision properties on BuildbotIteration into a more generic collection of revisions.
3451 https://bugs.webkit.org/show_bug.cgi?id=147280
3453 Reviewed by Daniel Bates.
3455 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3456 (BuildbotIteration): Removed opensourceRevision, internalRevision. Added revision.
3457 Refactored _parseData to handle repositories more generically.
3458 (parseRevisionProperty): Moved a comment up to parseRevisionProperty where it seems more relevant.
3459 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
3460 (BuildbotQueue.prototype.compareIterations): Using "revision" property instead of
3461 "opensourceRevision" and "internalRevision".
3462 (BuildbotQueue.prototype.compareIterationsByRevisions): Ditto.
3463 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3464 (BuildbotQueueView.prototype._appendPendingRevisionCount): Ditto.
3465 (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Ditto.
3466 (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Changing "internal" boolean
3467 parameter to more generic "repository" string parameter. Added "trac" parameter in order to
3468 specify the trac instance to use. Using "revision" property instead of "opensourceRevision"
3469 and "internalRevision".
3470 (BuildbotQueueView.prototype.revisionContentForIteration): Passing the repository name and trac
3471 instance to _revisionContentWithPopoverForIteration(). Using "revision" property instead of
3472 "opensourceRevision" and "internalRevision".
3473 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js: Adding
3474 constants for internal and opensource repositories.
3475 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
3476 (Analyzer.prototype._findIndexOfLargestIterationAtOrBeforeStart): Using "revision" property
3477 instead of "opensourceRevision" and "internalRevision".
3478 (Analyzer.prototype._countPercentageOfGreen): Ditto.
3479 (Analyzer.prototype.webkitTrac.recordedCommits.forEach): Ditto.
3480 (Analyzer.prototype._countTimes): Ditto.
3481 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3482 (WebKitBuildbot.prototype.layoutTestResultsDirectoryURLForIteration): Ditto.
3484 2015-08-04 Mark Lam <mark.lam@apple.com>
3486 Removed a local debugging line I accidentally left in from a previous commit.
3490 * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
3492 2015-08-04 Mark Lam <mark.lam@apple.com>
3494 Unreviewed. Make Saam Barati a WebKit reviewer.
3496 * Scripts/webkitpy/common/config/contributors.json:
3498 2015-08-04 Xabier Rodriguez Calvar <calvaris@igalia.com>
3500 Unreviewed, updated Streams API watchlist.
3502 * Scripts/webkitpy/common/config/watchlist: Matched .*Readable.*Stream.* and .*QueuingStrategy.* in bindings/js.
3504 2015-08-03 Csaba Osztrogonác <ossy@webkit.org>
3506 [CMake] Add an option to build AllInOne files
3507 https://bugs.webkit.org/show_bug.cgi?id=102647
3509 Reviewed by Alex Christensen.
3511 * Scripts/webkitperl/FeatureList.pm:
3513 2015-08-03 Alexey Proskuryakov <ap@apple.com>
3515 AppScale: Add required indices
3516 https://bugs.webkit.org/show_bug.cgi?id=147593
3518 Reviewed by Tim Horton.
3520 * QueueStatusServer/index.yaml:
3522 2015-08-03 Filip Pizlo <fpizlo@apple.com>
3524 Check in LLVM 3.6.2 binary drops for El Capitan
3525 https://bugs.webkit.org/show_bug.cgi?id=147582
3527 Reviewed by Alexey Proskuryakov.
3529 Recognize 10.11 and use the right drops.
3531 * Scripts/copy-webkitlibraries-to-product-directory:
3533 2015-08-03 Alex Christensen <achristensen@webkit.org>
3535 [Win] Build fix after r187733.
3537 * WinLauncher/PageLoadTestClient.cpp:
3538 (PageLoadTestClient::dumpRunStatistics):
3539 wtf/MathExtras.h is now included in HashTable.h, which #defines pow to wtf_pow.
3541 2015-08-02 Benjamin Poulain <bpoulain@apple.com>
3543 Investigate HashTable::HashTable(const HashTable&) and HashTable::operator=(const HashTable&) performance for hash-based static analyses
3544 https://bugs.webkit.org/show_bug.cgi?id=118455
3546 Reviewed by Filip Pizlo.
3548 * TestWebKitAPI/Tests/WTF/HashSet.cpp:
3549 (TestWebKitAPI::TEST):
3551 2015-07-31 Alex Christensen <achristensen@webkit.org>
3554 https://bugs.webkit.org/show_bug.cgi?id=146579
3556 Reviewed by Jon Honeycutt.
3558 * WinLauncher/stdafx.h:
3559 Define __STDC_LIMIT_MACROS to have access to INTMAX_MAX.
3561 2015-07-31 Csaba Osztrogonác <ossy@webkit.org>
3563 [EFL] Fix pixman build on ARM with GCC 4.9.3
3564 https://bugs.webkit.org/show_bug.cgi?id=147224
3566 Reviewed by Gyuyoung Kim.
3568 * efl/jhbuild.modules: Disable ARM IWMMXT fast paths as workarounding a GCC bug.
3570 2015-07-30 Anders Carlsson <andersca@apple.com>
3572 Add support for window.open to WK1BrowserWindowController
3573 https://bugs.webkit.org/show_bug.cgi?id=147474
3575 Reviewed by Dan Bernstein.
3577 * MiniBrowser/mac/WK1Brows