SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
[WebKit-https.git] / Tools / ChangeLog
1 2019-01-18  Jer Noble  <jer.noble@apple.com>
2
3         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
4         https://bugs.webkit.org/show_bug.cgi?id=189553
5
6         Reviewed by Tim Horton.
7
8         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
9
10         * ContentExtensionTester/Configurations/Base.xcconfig:
11         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
12         * DumpRenderTree/mac/Configurations/Base.xcconfig:
13         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
14         * ImageDiff/cg/Configurations/Base.xcconfig:
15         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
16         * MiniBrowser/Configurations/Base.xcconfig:
17         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
18         * MobileMiniBrowser/Configurations/Base.xcconfig:
19         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
20         * Scripts/webkitpy/style/checker.py:
21         (_all_categories):
22         (FileType):
23         (CheckerDispatcher._file_type):
24         (CheckerDispatcher._create_checker):
25         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
26         (SDKVariantChecker):
27         (SDKVariantChecker.__init__):
28         (SDKVariantChecker.check):
29         * TestWebKitAPI/Configurations/Base.xcconfig:
30         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
31         * WebEditingTester/Configurations/Base.xcconfig:
32         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
33         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
34         * WebKitTestRunner/Configurations/Base.xcconfig:
35         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
36         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
37         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
38
39 2019-01-18  David Kilzer  <ddkilzer@apple.com>
40
41         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
42         <https://webkit.org/b/193568>
43         <rdar://problem/47381130>
44
45         Reviewed by Alex Christensen.
46
47         Make sure no one re-introduces UIKit soft-linking by adding a
48         style rule.
49
50         * Scripts/webkitpy/style/checkers/cpp.py:
51         (check_language): Add softlink/uikit check.
52         (CppChecker): Enable softlink/uikit check.
53         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
54         (CppStyleTest): Add test for softlink/uikit.
55
56 2019-01-18  Joanmarie Diggs  <jdiggs@igalia.com>
57
58         [GTK] install-dependencies tool looks for libunistring-dev for dnf
59         https://bugs.webkit.org/show_bug.cgi?id=193584
60
61         Change "-dev" to "-devel".
62
63         Reviewed by Michael Catanzaro.
64
65         * gtk/install-dependencies:
66
67 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
68
69         webkitpy: Add iPhone and iPad ports
70         https://bugs.webkit.org/show_bug.cgi?id=193537
71         <rdar://problem/47353390>
72
73         Reviewed by Lucas Forschler.
74
75         Add --iphone-simulator and --ipad-simulator commands to run-webkit-tests which separate iPhone and iPad into separate
76         ports. Note that this separation is optional, the --ios-simulator command remains.
77
78         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
79         (RunTest.test_device_type_test_division): Drive-by fix.
80         (RunTest.test_device_type_specific_listing): Ditto.
81         (RunTest.test_ipad_test_division):
82         (RunTest):
83         (RunTest.test_ipad_listing):
84         * Scripts/webkitpy/port/factory.py:
85         (platform_options): Add --iphone-simulator and --ipad-simulator flags.
86         (PortFactory):
87         * Scripts/webkitpy/port/ios_simulator.py:
88         (IPhoneSimulatorPort):
89         (IPadSimulatorPort):
90
91 2019-01-18  Chris Dumez  <cdumez@apple.com>
92
93         Regression(PSON) Scroll position is not always restored properly when navigating back
94         https://bugs.webkit.org/show_bug.cgi?id=193578
95         <rdar://problem/47386331>
96
97         Reviewed by Tim Horton.
98
99         Add API test coverage.
100
101         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
102
103 2019-01-18  Youenn Fablet  <youenn@apple.com>
104
105         Add a new SPI to request for cache storage quota increase
106         https://bugs.webkit.org/show_bug.cgi?id=193323
107
108         Reviewed by Alex Christensen.
109
110         Implement WebsiteDataStore quota delegate to handle quota requests.
111         By default, do not update quota.
112         Update quota if test calls the new testRunner.allowCacheStorageQuotaIncrease method.
113
114         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
115         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
116         (WTR::TestRunner::allowCacheStorageQuotaIncrease):
117         * WebKitTestRunner/InjectedBundle/TestRunner.h:
118         * WebKitTestRunner/TestController.cpp:
119         (WTR::TestController::allowCacheStorageQuotaIncrease):
120         * WebKitTestRunner/TestController.h:
121         * WebKitTestRunner/TestInvocation.cpp:
122         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
123         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
124         (-[CacheStorageQuotaManager init]):
125         (-[CacheStorageQuotaManager _requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
126         (WTR::initializeWebViewConfiguration):
127         (WTR::TestController::cocoaResetStateToConsistentValues):
128         (WTR::TestController::allowCacheStorageQuotaIncrease):
129
130 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
131
132         [ews-build] Pass owner to the triggered builds
133         https://bugs.webkit.org/show_bug.cgi?id=193574
134
135         Reviewed by Lucas Forschler.
136
137         * BuildSlaveSupport/ews-build/factories.py:
138         (BuildFactory.propertiesToPassToTriggers):
139
140 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
141
142         [ews-app] Send patch author as a build property
143         https://bugs.webkit.org/show_bug.cgi?id=193560
144
145         Reviewed by Lucas Forschler.
146
147         * BuildSlaveSupport/ews-app/ews/fetcher.py:
148         (BugzillaPatchFetcher.fetch):
149
150 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
151
152         webkitpy: Implement device type specific expected results (Follow-up fix)
153         https://bugs.webkit.org/show_bug.cgi?id=192162
154         <rdar://problem/46345449>
155
156         Unreviewed infrastructure fix.
157
158         * Scripts/webkitpy/layout_tests/controllers/manager.py:
159         (Manager.run): Don't boot a device if no tests are available to run on it.
160
161 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
162
163         webkitpy: Implement device type specific expected results (Follow-up fix)
164         https://bugs.webkit.org/show_bug.cgi?id=192162
165         <rdar://problem/46345449>
166
167         Unreviewed infrastructure fix.
168
169         * Scripts/webkitpy/api_tests/manager.py:
170         (Manager._initialize_devices): Use DEVICE_TYPE when running API tests.
171
172 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
173
174         webkitpy: Implement device type specific expected results (Part 2)
175         https://bugs.webkit.org/show_bug.cgi?id=192162
176         <rdar://problem/46345449>
177
178         Rubber-stamped by Aakash Jain.
179
180         This change uses device_type to select a different set of TestExpectation files based on the type of device running
181         tests. This requires multiple baseline search paths to be used in a single instantiation of run-webkit-tests. Note
182         that while multiple baseline search paths are used, any single test will only ever be run on a single device type.
183
184         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
185         (LayoutTestFinder.find_tests): Pass device_type through.
186         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py:
187         (LayoutTestFinderTests.test_touched_but_skipped_test): Allow device_type to be passed in.
188         * Scripts/webkitpy/layout_tests/controllers/manager.py:
189         (Manager.__init__): Make _expectations an OrderedDict indexed by device_type, add current_device_type.
190         (Manager._collect_tests): Pass device type to test finder.
191         (Manager._needs_web_platform_test):
192         (Manager._prepare_lists): Index _expectations by device type.
193         (Manager._test_input_for_file):
194         (Manager._test_is_slow): Ditto.
195         (Manager._test_should_dump_jsconsolelog_in_stderr):
196         (Manager._test_should_dump_jsconsolelog_in_stderr): Ditto.
197         (Manager._get_test_inputs):
198         (Manager._update_worker_count):
199         (Manager._set_up_run): Use current_device_type instead of passing device_type in.
200         (Manager.run): Re-write function to gather and parse expectations from multiple baseline search paths. In the event
201         that a test can be run on multiple device types, the first device in the device type list which is eligible will be
202         the one which runs the test.
203         (Manager._run_test_subset):
204         (Manager._run_tests): Index _expectations by current_device_type.
205         (Manager._print_expectation_line_for_test): Ditto.
206         (Manager._print_expectations_for_subset): Ditto.
207         (Manager.print_expectations): Re-write function to gather and parse expectations from multiple baseline search paths.
208         Unlike run, this function will behave the same regardless of what devices are available.
209         (Manager._custom_device_for_test): Deleted.
210         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
211         (ManagerTest.test_uses_custom_device): Deleted.
212         (ManagerTest.test_uses_custom_device.get_manager): Deleted.
213         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
214         (JSONLayoutResultsGenerator.__init__): Pass expectations as a dictionary indexed by device type.
215         (JSONLayoutResultsGenerator._insert_failure_summaries): The number of fixable tests must take into consideration
216         all of the expectations.
217         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
218         (FakePort.skipped_layout_tests): Allow device_type to be passed in.
219         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
220         (TestExpectations.__init__): Allow device_type to be passed through.
221         (TestExpectations.parse_all_expectations): Pick expectations_dict by device type.
222         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Allow device_type to be passed in.
223         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
224         (summarize_results):
225         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
226         (summarized_results): Expectations are stored in a dictionary indexed by device_type. When determining the expectation
227         a test ran with, one must check all expectations to find the first non-skip expectation.
228         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
229         (RunTest.test_device_type_test_division):
230         (RunTest):
231         (RunTest.test_device_type_specific_listing):
232         * Scripts/webkitpy/port/base.py:
233         (Port): Add default values for DEVICE_TYPE and DEFAULT_DEVICE_TYPES.
234         (Port.supported_device_types): The result of this function will change based on what devices are available.
235         * Scripts/webkitpy/port/device_port.py:
236         (DevicePort._device_type_with_version): Replace DEFAULT_DEVICE_TYPE with DEVICE_TYPE.
237         (DevicePort.default_child_processes): DEVICE_TYPE is a general type, so the built-in comparison of the DeviceType object
238         can be used.
239         (DevicePort.supported_device_types): Generates a list of device types determined by the available devices, if there are
240         any, or the DEFAULT_DEVICE_TYPES of the port.
241         * Scripts/webkitpy/port/ios.py:
242         (IOSPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
243         * Scripts/webkitpy/port/ios_simulator.py:
244         (IOSSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the devices currently used to run layout tests.
245         * Scripts/webkitpy/port/watch.py:
246         (WatchPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
247         * Scripts/webkitpy/port/watch_simulator.py:
248         (WatchSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the device currently used to run layout tests.
249         * Scripts/webkitpy/xcode/device_type.py:
250         (DeviceType):
251         (DeviceType.__hash__): Allow DeviceType to be used as a dictionary index.
252
253 2019-01-18  Philippe Normand  <pnormand@igalia.com>
254
255         [WPE] run-qt-wpe-minibrowser needlessly expects a --wpe argument
256         https://bugs.webkit.org/show_bug.cgi?id=193575
257
258         Reviewed by Michael Catanzaro.
259
260         Allow the script to run without explicit port argument because
261         it's specific to the WPE port anyway.
262
263         * Scripts/run-qt-wpe-minibrowser: Manually insert --wpe in argv
264         and simplify the rest of the code accordingly.
265
266 2019-01-18  Charlie Turner  <cturner@igalia.com>
267
268         [GStreamer][EME][ClearKey] Request keys from CDMInstance rather than passing via bus messages
269         https://bugs.webkit.org/show_bug.cgi?id=192229
270
271         Reviewed by Xabier Rodriguez-Calvar.
272
273         * MiniBrowser/wpe/main.cpp:
274         (main): Enable encrypted-media by default.
275
276 2019-01-18  Philippe Normand  <pnormand@igalia.com>
277
278         [Flatpak] Missing KeyboardInterrupt exception handler
279         https://bugs.webkit.org/show_bug.cgi?id=193570
280
281         Reviewed by Michael Catanzaro.
282
283         * flatpak/flatpakutils.py:
284         (WebkitFlatpak.run_in_sandbox): Basic KeyboardInterrupt handling.
285
286 2019-01-18  Zalan Bujtas  <zalan@apple.com>
287
288         [LFC][BFC][MarginCollapsing] Collapsing through should not ignore floats.
289         https://bugs.webkit.org/show_bug.cgi?id=193564
290
291         Reviewed by Antti Koivisto.
292
293         * LayoutReloaded/misc/LFC-passing-tests.txt:
294
295 2019-01-18  Zalan Bujtas  <zalan@apple.com>
296
297         [LFC] Do not skip float boxes that are not part of the current formatting context when computing bottom.
298         https://bugs.webkit.org/show_bug.cgi?id=193562
299
300         Reviewed by Antti Koivisto.
301
302         * LayoutReloaded/misc/LFC-passing-tests.txt:
303
304 2019-01-18  Zalan Bujtas  <zalan@apple.com>
305
306         [LFC][BFC] Check for inflow children while computing height for block formatting context roots.
307         https://bugs.webkit.org/show_bug.cgi?id=193555
308
309         Reviewed by Antti Koivisto.
310
311         * LayoutReloaded/misc/LFC-passing-tests.txt:
312
313 2019-01-18  Philippe Normand  <pnormand@igalia.com>
314
315         [WPE] Add Qt extension
316         https://bugs.webkit.org/show_bug.cgi?id=191464
317
318         Reviewed by Carlos Garcia Campos.
319
320         MiniBrowser and API tests for the WPE Qt API. To run the
321         MiniBrowser a new script is introduced. Example invocation:
322
323         $ run-qt-wpe-minibrowser -platform wayland https://webkit.org
324
325         Also note-worthy is the introduction of the python2-subprocess32
326         dependency to run the GLib API tests.
327
328         * MiniBrowser/wpe/CMakeLists.txt:
329         * MiniBrowser/wpe/qt/CMakeLists.txt: Added.
330         * MiniBrowser/wpe/qt/main.cpp: Added.
331         (main):
332         * MiniBrowser/wpe/qt/main.qml: Added.
333         * MiniBrowser/wpe/qt/qml.qrc: Added.
334         * Scripts/run-gtk-tests:
335         (GtkTestRunner.is_google_test):
336         (GtkTestRunner):
337         (GtkTestRunner.is_qt_test):
338         * Scripts/run-qt-wpe-minibrowser: Added.
339         * Scripts/run-wpe-tests:
340         (WPETestRunner):
341         (WPETestRunner.is_google_test):
342         (WPETestRunner.is_qt_test):
343         * TestWebKitAPI/Tests/WPEQt/TestLoad.cpp: Added.
344         (TestLoad::main):
345         * TestWebKitAPI/Tests/WPEQt/TestLoadHtml.cpp: Added.
346         (TestLoadHtml::main):
347         * TestWebKitAPI/Tests/WPEQt/TestLoadRequest.cpp: Added.
348         (TestLoadRequest::main):
349         * TestWebKitAPI/Tests/WPEQt/TestRunJavaScript.cpp: Added.
350         (TestRunJavaScript::main):
351         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.cpp: Added.
352         (waitForSignal):
353         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.h: Added.
354         (LoadSpy::LoadSpy):
355         (LoadSpy::~LoadSpy):
356         (LoadSpy::onLoadingChanged):
357         (LoadStartedCatcher::LoadStartedCatcher):
358         (LoadStartedCatcher::~LoadStartedCatcher):
359         (LoadStartedCatcher::onLoadingChanged):
360         (waitForLoadSucceeded):
361         (waitForLoadFailed):
362         * TestWebKitAPI/glib/CMakeLists.txt:
363         * flatpak/flatpakutils.py:
364         (WebkitFlatpak.load_from_args):
365         (WebkitFlatpak.__init__):
366         (WebkitFlatpak.clean_args):
367         (WebkitFlatpak.run_in_sandbox):
368         * flatpak/org.webkit.CommonModules.yaml:
369         * flatpak/org.webkit.WPE.yaml:
370         * flatpak/org.webkit.WPEModules.yaml:
371         * flatpak/org.webkit.WPEQT.yaml: Copied from Tools/flatpak/org.webkit.WebKit.yaml.
372         * flatpak/org.webkit.WebKit.yaml:
373         * glib/api_test_runner.py:
374         (TestRunner._run_test_qt):
375         (TestRunner.is_qt_test):
376         (TestRunner._run_test):
377
378 2019-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
379
380         [iOS] Content offset jumps erratically when autoscrolling near scroll view content inset areas
381         https://bugs.webkit.org/show_bug.cgi?id=193494
382         <rdar://problem/46859627>
383
384         Reviewed by Simon Fraser and Tim Horton.
385
386         Add a new test option to add a top content inset to the test runner's WKWebView's scroll view, and automatically
387         scroll to reveal this top content inset area when beginning the test (i.e., scroll to (0, -topContentInset)).
388
389         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
390         (WTR::UIScriptController::contentOffsetX const):
391         (WTR::UIScriptController::contentOffsetY const):
392         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
393         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
394         (WTR::UIScriptController::contentOffsetX const):
395         (WTR::UIScriptController::contentOffsetY const):
396         * TestRunnerShared/UIScriptContext/UIScriptController.h:
397
398         Also add new UIScriptController methods to ask for the content offset of the platform scroll view.
399
400         * WebKitTestRunner/TestController.cpp:
401         (WTR::updateTestOptionsFromTestHeader):
402         * WebKitTestRunner/TestOptions.h:
403         (WTR::TestOptions::hasSameInitializationOptions const):
404         * WebKitTestRunner/ios/TestControllerIOS.mm:
405         (WTR::TestController::platformResetStateToConsistentValues):
406         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
407         (WTR::UIScriptController::contentOffsetX const):
408         (WTR::UIScriptController::contentOffsetY const):
409
410 2019-01-17  Truitt Savell  <tsavell@apple.com>
411
412         Unreviewed, rolling out r240124.
413
414         This commit broke an internal build.
415
416         Reverted changeset:
417
418         "SDK_VARIANT build destinations should be separate from non-
419         SDK_VARIANT builds"
420         https://bugs.webkit.org/show_bug.cgi?id=189553
421         https://trac.webkit.org/changeset/240124
422
423 2019-01-17  Alex Christensen  <achristensen@webkit.org>
424
425         Fix string concatenation API test after r239920
426         https://bugs.webkit.org/show_bug.cgi?id=193551
427         <rdar://problem/47359304>
428
429         Reviewed by Youenn Fablet.
430
431         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
432         (TestWebKitAPI::TEST):
433         Cocoa platforms' interpretation of UChar/unsigned short equality is not affected by ICU's recent change of UChar's type
434         in WebKit's build configuration like it apparently is on Linux.
435
436 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
437
438         [ews-build] validate-patch should handle the case when bug_id is None
439         https://bugs.webkit.org/show_bug.cgi?id=193547
440
441         Reviewed by Lucas Forschler.
442
443         * BuildSlaveSupport/ews-build/steps.py:
444         (ValidatePatch._is_bug_closed): Gracefully handle the case when bug_id is None.
445         (ValidatePatch.start): If bug_id is set as None in build properties, fetch it from the patch.
446
447 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
448
449         [ews-build] Add patch author information in build
450         https://bugs.webkit.org/show_bug.cgi?id=193465
451
452         Reviewed by Lucas Forschler.
453
454         * BuildSlaveSupport/ews-build/steps.py:
455         (ValidatePatch._is_patch_obsolete):
456
457 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
458
459         [ews-build] Pass bug_id to the triggered builds
460         https://bugs.webkit.org/show_bug.cgi?id=193548
461
462         Reviewed by Lucas Forschler.
463
464         * BuildSlaveSupport/ews-build/factories.py:
465         (BuildFactory.propertiesToPassToTriggers):
466
467 2019-01-17  Jer Noble  <jer.noble@apple.com>
468
469         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
470         https://bugs.webkit.org/show_bug.cgi?id=189553
471
472         Reviewed by Tim Horton.
473
474         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
475
476         * ContentExtensionTester/Configurations/Base.xcconfig:
477         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
478         * DumpRenderTree/mac/Configurations/Base.xcconfig:
479         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
480         * ImageDiff/cg/Configurations/Base.xcconfig:
481         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
482         * MiniBrowser/Configurations/Base.xcconfig:
483         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
484         * MobileMiniBrowser/Configurations/Base.xcconfig:
485         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
486         * Scripts/webkitpy/style/checker.py:
487         (_all_categories):
488         (FileType):
489         (CheckerDispatcher._file_type):
490         (CheckerDispatcher._create_checker):
491         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
492         (SDKVariantChecker):
493         (SDKVariantChecker.__init__):
494         (SDKVariantChecker.check):
495         * TestWebKitAPI/Configurations/Base.xcconfig:
496         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
497         * WebEditingTester/Configurations/Base.xcconfig:
498         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
499         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
500         * WebKitTestRunner/Configurations/Base.xcconfig:
501         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
502         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
503         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
504
505 2019-01-17  Zalan Bujtas  <zalan@apple.com>
506
507         [LFC][BFC] An element with transform is a containing block for positioned descendants.
508         https://bugs.webkit.org/show_bug.cgi?id=193534
509
510         Reviewed by Antti Koivisto.
511
512         * LayoutReloaded/misc/LFC-passing-tests.txt:
513
514 2019-01-17  Zalan Bujtas  <zalan@apple.com>
515
516         [LFC][BFC][Quirk] Take body padding and border into account when stretching height.
517         https://bugs.webkit.org/show_bug.cgi?id=193528
518
519         Reviewed by Antti Koivisto.
520
521         * LayoutReloaded/misc/LFC-passing-tests.txt:
522
523 2019-01-17  Zalan Bujtas  <zalan@apple.com>
524
525         [LFC][BFC] For height computation, the bottom edge of the last line box value should include top border/padding
526         https://bugs.webkit.org/show_bug.cgi?id=193520
527
528         Reviewed by Antti Koivisto.
529
530         * LayoutReloaded/misc/LFC-passing-tests.txt:
531
532 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
533
534         [ews-build] unapply-patch step should not update source
535         https://bugs.webkit.org/show_bug.cgi?id=193234
536
537         Reviewed by Lucas Forschler.
538
539         * BuildSlaveSupport/ews-build/steps.py:
540         (CleanWorkingDirectory): Use clean-webkit script to clean the working directory.
541         (UnApplyPatchIfRequired): Use CleanWorkingDirectory as base class.
542
543 2019-01-16  Youenn Fablet  <youenn@apple.com>
544
545         Add a new SPI for controlling getUserMedia
546         https://bugs.webkit.org/show_bug.cgi?id=192793
547
548         Reviewed by Eric Carlson.
549
550         * MiniBrowser/mac/WK2BrowserWindowController.m:
551         (-[WK2BrowserWindowController _webView:requestUserMediaAuthorizationForFrame:devices:decisionHandler:]):
552         (-[WK2BrowserWindowController _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
553         * TestWebKitAPI/Tests/WebKit/GetUserMediaNavigation.mm:
554         (-[NavigationWhileGetUserMediaPromptDisplayedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
555         * TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm:
556         (-[GetUserMediaRepromptUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
557         * TestWebKitAPI/Tests/WebKit/MediaStreamTrackDetached.mm:
558         (-[MediaStreamTrackDetachedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
559         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
560         (-[UserMediaUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
561         (-[UserMediaUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
562         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaSimulateFailedSandbox.mm:
563         (-[SimulateFailedSandboxUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
564         (-[SimulateFailedSandboxUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
565
566 2019-01-16  Zalan Bujtas  <zalan@apple.com>
567
568         [LFC][BFC] Inflow non-replaced used width should not be negative.
569         https://bugs.webkit.org/show_bug.cgi?id=193495
570
571         Reviewed by Antti Koivisto.
572
573         * LayoutReloaded/misc/LFC-passing-tests.txt:
574
575 2019-01-16  Chris Dumez  <cdumez@apple.com>
576
577         Regression(PSON) View becomes blank after click a cross-site download link
578         https://bugs.webkit.org/show_bug.cgi?id=193361
579         <rdar://problem/47099573>
580
581         Reviewed by Geoffrey Garen.
582
583         Add API test coverage.
584
585         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
586         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
587
588 2019-01-16  Zalan Bujtas  <zalan@apple.com>
589
590         [LFC][Out-of-flow] Set used vertical margin values when top/height/bottom are non-auto.
591         https://bugs.webkit.org/show_bug.cgi?id=193470
592
593         Reviewed by Antti Koivisto.
594
595         * LayoutReloaded/misc/LFC-passing-tests.txt:
596
597 2019-01-16  Zalan Bujtas  <zalan@apple.com>
598
599         [LFC] Adjust margin box verification.
600         https://bugs.webkit.org/show_bug.cgi?id=193482
601
602         Reviewed by Antti Koivisto.
603
604         * LayoutReloaded/misc/LFC-passing-tests.txt:
605
606 2019-01-15  Sihui Liu  <sihui_liu@apple.com>
607
608         Fix API test WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming after 193354
609         https://bugs.webkit.org/show_bug.cgi?id=193451
610
611         Reviewed by Geoffrey Garen.
612
613         * TestWebKitAPI/Tests/WebKitCocoa/DuplicateCompletionHandlerCalls.mm:
614         (TEST):
615         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
616         (runWebsiteDataStoreCustomPaths):
617
618 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
619
620         webkitpy: Support boolean simctl isAvailable
621         https://bugs.webkit.org/show_bug.cgi?id=193472
622         <rdar://problem/47296150>
623
624         Reviewed by Ryosuke Niwa.
625
626         * Scripts/webkitpy/xcode/simulated_device.py:
627         (SimulatedDeviceManager._create_runtimes):
628         (SimulatedDeviceManager._create_device_with_runtime):
629
630 2019-01-15  Chris Dumez  <cdumez@apple.com>
631
632         Unreviewed, rolling out r239993, r239995, r239997, and
633         r239999.
634
635         Caused assertions under
636         ViewGestureController::disconnectFromProcess()
637
638         Reverted changesets:
639
640         "Regression(PSON) View becomes blank after click a cross-site
641         download link"
642         https://bugs.webkit.org/show_bug.cgi?id=193361
643         https://trac.webkit.org/changeset/239993
644
645         "Unreviewed iOS build fix after r239993."
646         https://trac.webkit.org/changeset/239995
647
648         "Fix iOS build after r239993"
649         https://bugs.webkit.org/show_bug.cgi?id=193361
650         https://trac.webkit.org/changeset/239997
651
652         "Unreviewed, revert part of r239997 as it is not needed to fix
653         the build."
654         https://trac.webkit.org/changeset/239999
655
656 2019-01-15  Tim Horton  <timothy_horton@apple.com>
657
658         Cannot tab out of WKWebView on macOS
659         https://bugs.webkit.org/show_bug.cgi?id=161448
660         <rdar://problem/28100085>
661
662         Reviewed by Dean Jackson.
663
664         Add a test that tabbing into and out of WKWebView works correctly.
665
666         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
667         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
668         (WebKit2_CommandBackForwardTest::SetUp):
669         (-[CommandBackForwardOffscreenWindow isKeyWindow]): Deleted.
670         (-[CommandBackForwardOffscreenWindow isVisible]): Deleted.
671         * TestWebKitAPI/Tests/WebKitCocoa/TabOutOfWebView.mm: Added.
672         (-[FocusableView canBecomeKeyView]):
673         (TEST):
674         * TestWebKitAPI/mac/OffscreenWindow.h: Added.
675         * TestWebKitAPI/mac/OffscreenWindow.mm: Added.
676         (-[OffscreenWindow initWithSize:]):
677         (-[OffscreenWindow isKeyWindow]):
678         (-[OffscreenWindow isVisible]):
679         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
680         (TestWebKitAPI::PlatformWebView::initialize):
681         (-[ActiveOffscreenWindow isKeyWindow]): Deleted.
682         (-[ActiveOffscreenWindow isVisible]): Deleted.
683         Factor ActiveOffscreenWindow out into OffscreenWindow and share it.
684
685 2019-01-15  Ryan Haddad  <ryanhaddad@apple.com>
686
687         Adjust the arguments passed to run-javascriptcore-tests for the 32-bit JSC bot
688         https://bugs.webkit.org/show_bug.cgi?id=193459
689
690         Reviewed by Mark Lam.
691
692         * BuildSlaveSupport/build.webkit.org-config/steps.py:
693         (Run32bitJSCTests): This queue should not run JIT, testair, testb3, or testmasm.
694
695 2019-01-15  Chris Dumez  <cdumez@apple.com>
696
697         Regression(PSON) View becomes blank after click a cross-site download link
698         https://bugs.webkit.org/show_bug.cgi?id=193361
699         <rdar://problem/47099573>
700
701         Reviewed by Geoff Garen.
702
703         Add API test coverage.
704
705         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
706         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
707
708 2019-01-15  Zalan Bujtas  <zalan@apple.com>
709
710         [LFC][Out-of-flow] Ignore bottom when the vertical values are over-constrained
711         https://bugs.webkit.org/show_bug.cgi?id=193448
712
713         Reviewed by Antti Koivisto.
714
715         * LayoutReloaded/misc/LFC-passing-tests.txt:
716
717 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
718
719         webkitpy: Implement device type specific expected results (Part 1)
720         https://bugs.webkit.org/show_bug.cgi?id=192162
721
722         Reviewed by Lucas Forschler.
723
724         Device type specific expected results covers two related ideas. The first (covered by this change)
725         is where to search for -expected.* files. The second is which tests to run based on the
726         TestExpectations.txt file.
727
728         After this change, the baseline search path will be determined by the type of device running a
729         test. Device type will be passed into any function which picks a file based on the baseline search
730         path.
731
732         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
733         (Worker._update_test_input): Pass device_type to self._port.reference_files(...).
734         * Scripts/webkitpy/layout_tests/controllers/manager.py:
735         (Manager.run): Print baseline search path for each round of devices.
736         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
737         (SingleTestRunner.__init__): Pass device_type into expected_*(...).
738         (SingleTestRunner._expected_driver_output): Ditto.
739         (SingleTestRunner._driver_input): Ditto.
740         * Scripts/webkitpy/layout_tests/views/printing.py:
741         (Printer.print_config): Move printing of baseline search path to a separate function.
742         (Printer.print_baseline_search_path): Moved from Printer.print_config.
743         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
744         (Testprinter.test_print_config):
745         (Testprinter.test_print_baseline_search_path):
746         * Scripts/webkitpy/port/base.py:
747         (Port.baseline_search_path): Pass device_type through.
748         (Port._expected_baselines_for_suffixes): Ditto.
749         (Port.expected_baselines): Ditto.
750         (Port.expected_filename): Ditto.
751         (Port.expected_checksum): Ditto.
752         (Port.expected_image): Ditto.
753         (Port.expected_audio): Ditto.
754         (Port.expected_text): Ditto.
755         (Port.reference_files): Ditto.
756         (Port.tests): Ditto.
757         (Port._expanded_paths): Ditto.
758         (Port.skipped_layout_tests): Ditto.
759         (Port.expectations_dict): Ditto.
760         (Port._port_specific_expectations_files): Ditto.
761         (Port.expectations_files): Ditto.
762         (Port.test_search_path): Ditto.
763         (Port._tests_for_other_platforms): Ditto.
764         * Scripts/webkitpy/port/base_unittest.py:
765         (PortTest.test_additional_platform_directory): Accept, but do not use, device_type.
766         (PortTest.test_nonexistant_expectations): Ditto.
767         (test_ref_tests_platform_directory): Ditto.
768         * Scripts/webkitpy/port/darwin.py:
769         (DarwinPort._port_specific_expectations_files): Accept device_type.
770         * Scripts/webkitpy/port/driver.py:
771         (DriverProxy):
772         (DriverProxy.host): Expose _target_host for device_type information.
773         * Scripts/webkitpy/port/gtk.py:
774         (GtkPort._port_specific_expectations_files): Accept, but do not use, device_type.
775         * Scripts/webkitpy/port/ios.py:
776         (IOSPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
777         * Scripts/webkitpy/port/mac.py:
778         (MacPort. default_baseline_search_path): Ditto.
779         * Scripts/webkitpy/port/port_testcase.py:
780         (TestWebKitPort._tests_for_other_platforms): Accept, but do not use, device_type.
781         * Scripts/webkitpy/port/test.py:
782         * Scripts/webkitpy/port/watch.py:
783         (WatchPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
784         * Scripts/webkitpy/port/win.py:
785         (WinPort.test_search_path): Accept, but do not use, device_type.
786         * Scripts/webkitpy/port/wpe.py:
787         (WPEPort._port_specific_expectations_files): Ditto.
788         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
789         (get_test_baselines.AllPlatformsPort.baseline_search_path): Ditto.
790
791 2019-01-15  Zalan Bujtas  <zalan@apple.com>
792
793         [LFC] Use the containing block's padding box to position out-of-flow elements.
794         https://bugs.webkit.org/show_bug.cgi?id=193431
795
796         Reviewed by Antti Koivisto.
797
798         * LayoutReloaded/misc/LFC-passing-tests.txt:
799
800 2019-01-14  Tim Horton  <timothy_horton@apple.com>
801
802         Move a test implementation file that got misplaced in the Xcode project
803
804         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
805
806 2019-01-14  Commit Queue  <commit-queue@webkit.org>
807
808         Unreviewed, rolling out r239901, r239909, r239910, r239912,
809         r239913, and r239914.
810         https://bugs.webkit.org/show_bug.cgi?id=193407
811
812         These revisions caused an internal failure (Requested by
813         Truitt on #webkit).
814
815         Reverted changesets:
816
817         "[Cocoa] Avoid importing directly from subumbrella frameworks"
818         https://bugs.webkit.org/show_bug.cgi?id=186016
819         https://trac.webkit.org/changeset/239901
820
821         "Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901."
822         https://trac.webkit.org/changeset/239909
823
824         "Tried to fix the build."
825         https://trac.webkit.org/changeset/239910
826
827         "Fixed iOS builds after r239910."
828         https://trac.webkit.org/changeset/239912
829
830         "More build fixing."
831         https://trac.webkit.org/changeset/239913
832
833         "Tried to fix USE(APPLE_INTERNAL_SDK) 32-bit builds."
834         https://trac.webkit.org/changeset/239914
835
836 2019-01-14  Mark Lam  <mark.lam@apple.com>
837
838         Re-enable ability to build --cloop builds.
839         https://bugs.webkit.org/show_bug.cgi?id=192955
840         <rdar://problem/46882363>
841
842         Reviewed by Saam barati and Keith Miller.
843
844         The --cloop build option was being ignored this whole time since r236381.
845         This patch makes it possible to build CLoop builds again.
846
847         * Scripts/build-jsc:
848         * Scripts/webkitperl/FeatureList.pm:
849         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
850
851 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
852
853         webkitpy: Expose device_type from host-like objects
854         https://bugs.webkit.org/show_bug.cgi?id=193406
855         <rdar://problem/47262305>
856
857         Reviewed by Lucas Forschler.
858
859         Devices should expose device_type. As a result, all host objects should
860         provide a device_type property, even if they do not yet define a device_type.
861
862         * Scripts/webkitpy/common/system/systemhost.py:
863         (SystemHost):
864         (SystemHost.device_type):
865         * Scripts/webkitpy/common/system/systemhost_mock.py:
866         (MockSystemHost):
867         (MockSystemHost.device_type):
868         * Scripts/webkitpy/port/device.py:
869         (Device):
870         (Device.device_type):
871         * Scripts/webkitpy/xcode/simulated_device.py:
872         (SimulatedDeviceManager._find_exisiting_device_for_request):
873         (SimulatedDeviceManager._disambiguate_device_type):
874         (SimulatedDeviceManager._does_fulfill_request):
875         (SimulatedDeviceManager.device_count_for_type):
876         (SimulatedDeviceManager.initialize_devices):
877         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
878         (test_available_devices):
879         (test_swapping_devices):
880
881 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
882
883         webkitpy: Support alternate simctl device list output (Follow-up fix)
884         https://bugs.webkit.org/show_bug.cgi?id=193362
885         <rdar://problem/47122965>
886
887         Rubber-stamped by Lucas Forschler.
888
889         * Scripts/webkitpy/xcode/simulated_device.py:
890         (SimulatedDeviceManager.populate_available_devices):
891
892 2019-01-14  Wenson Hsieh  <wenson_hsieh@apple.com>
893
894         [iOS] Expose SPI to access the current sentence boundary and selection state
895         https://bugs.webkit.org/show_bug.cgi?id=193398
896         <rdar://problem/45893108>
897
898         Reviewed by Dean Jackson.
899
900         Add an API test to verify that an SPI client can observe changes in the `@"_selectionAttributes"` key path on
901         WKWebView, and that inserting text, deleting, and changing the selection cause selection attributes to change as
902         expected.
903
904         * TestWebKitAPI/EditingTestHarness.h:
905         * TestWebKitAPI/EditingTestHarness.mm:
906         (-[EditingTestHarness moveBackward]):
907         (-[EditingTestHarness moveForward]):
908         (-[EditingTestHarness moveForwardAndExpectEditorStateWith:]):
909
910         Add a couple of new helper methods on EditingTestHarness.
911
912         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
913         (-[SelectionChangeObserver initWithWebView:]):
914         (-[SelectionChangeObserver webView]):
915         (-[SelectionChangeObserver observeValueForKeyPath:ofObject:change:context:]):
916         (-[SelectionChangeObserver currentSelectionAttributes]):
917
918 2019-01-14  Zalan Bujtas  <zalan@apple.com>
919
920         [LFC][BFC] Add basic box-sizing support.
921         https://bugs.webkit.org/show_bug.cgi?id=193392
922
923         Reviewed by Antti Koivisto.
924
925         * LayoutReloaded/misc/LFC-passing-tests.txt:
926
927 2019-01-14  Charlie Turner  <cturner@igalia.com>
928
929         [WPE] API test gardening
930         https://bugs.webkit.org/show_bug.cgi?id=193319
931
932         Reviewed by Michael Catanzaro.
933
934         * TestWebKitAPI/glib/TestExpectations.json: Remove some now
935         passing tests.
936
937 2019-01-14  Charlie Turner  <cturner@igalia.com>
938
939         [GStreamer] Add sharedBuffer utility to GstMappedBuffer, and a testsuite
940         https://bugs.webkit.org/show_bug.cgi?id=192977
941
942         Reviewed by Carlos Garcia Campos.
943
944         * TestWebKitAPI/PlatformGTK.cmake: Build the new GStreamer test harness
945         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
946         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.cpp: Added.
947         (TestWebKitAPI::GStreamerTest::SetUp):
948         (TestWebKitAPI::GStreamerTest::TearDown):
949         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.h: Added.
950         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp: Added.
951         (TestWebKitAPI::TEST_F):
952
953 2019-01-14  Charlie Turner  <cturner@igalia.com>
954
955         [WPE] Workaround for incorrect template specialization being selected when UChar=char16_t
956         https://bugs.webkit.org/show_bug.cgi?id=193332
957
958         Reviewed by Michael Catanzaro.
959
960         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: When UChar is
961         defined as a char16_t, which changed in ICU 59, the
962         StringTypeAdapter<UnsignedInt, ...> overload catches casts to
963         unsigned short. This test is relying on the behaviour that
964         UChar=unsigned short, which doesn't hold across platforms and ICU
965         library versions. The full fix would be a special syntax for
966         literal characters so that these ambiguities do not arise. That
967         work is proposed in https://bugs.webkit.org/show_bug.cgi?id=193101.
968         (TestWebKitAPI::TEST):
969
970 2019-01-14  Carlos Garcia Campos  <cgarcia@igalia.com>
971
972         Unreviewed. [GTK][WPE] Run distcheck with gtkdoc and MiniBrowser enabled
973
974         * Scripts/make-dist:
975         (Distcheck.configure):
976
977 2019-01-13  Aakash Jain  <aakash_jain@apple.com>
978
979         [ews-build] Update macOS queue configurations
980         https://bugs.webkit.org/show_bug.cgi?id=193365
981         <rdar://problem/47221073>
982
983         Unreviewed, renamed mac-high-sierra to mac-highsierra to match with build.webkit.org configuration.
984
985         * BuildSlaveSupport/ews-build/config.json:
986
987 2019-01-13  Zalan Bujtas  <zalan@apple.com>
988
989         [LFC] Adjust assert for statically positioned fixed elements
990         https://bugs.webkit.org/show_bug.cgi?id=193385
991
992         Reviewed by Antti Koivisto.
993
994         * LayoutReloaded/misc/LFC-passing-tests.txt:
995
996 2019-01-13  Philippe Normand  <pnormand@igalia.com>
997
998         [WPE][MiniBrowser] Ephemeral WebContext leaks in automation mode
999         https://bugs.webkit.org/show_bug.cgi?id=193387
1000
1001         Reviewed by Carlos Garcia Campos.
1002
1003         * MiniBrowser/wpe/main.cpp:
1004         (main):
1005
1006 2019-01-12  Timothy Hatcher  <timothy@apple.com>
1007
1008         Have prefers-color-scheme: light always match on macOS versions before Mojave.
1009         https://bugs.webkit.org/show_bug.cgi?id=191655
1010         rdar://problem/46074680
1011
1012         Reviewed by Megan Gardner.
1013
1014         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions.
1015         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
1016
1017 2019-01-12  Dan Bernstein  <mitz@apple.com>
1018
1019         [Cocoa] Avoid importing directly from subumbrella frameworks
1020         https://bugs.webkit.org/show_bug.cgi?id=186016
1021         <rdar://problem/40591038>
1022
1023         Reviewed by Sam Weinig.
1024
1025         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
1026           LaunchServices header.
1027         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
1028           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
1029         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
1030           when using SDKs earlier than 10.13.
1031         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
1032           and OTHER_CPLUSPLUSFLAGS.
1033         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
1034           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
1035         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
1036           LaunchServices header.
1037
1038 2019-01-11  John Wilander  <wilander@apple.com>
1039
1040         Compile out Web API Statistics Collection
1041         https://bugs.webkit.org/show_bug.cgi?id=193370
1042         <rdar://problem/45388584>
1043
1044         Reviewed by Brent Fulgham.
1045
1046         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1047             Defined ENABLE_WEB_API_STATISTICS, off by default.
1048
1049 2019-01-11  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
1050
1051         [WPE] Add gtk-doc
1052         https://bugs.webkit.org/show_bug.cgi?id=178900
1053
1054         Reviewed by Michael Catanzaro.
1055
1056         Add Tools/gtkdoc to manifest.txt.in files.
1057         This should have been done in r238853 and caused failure in building WebKitGTK+ unstable release 2.23.2.
1058
1059         * gtk/manifest.txt.in: Add Tools/gtkdoc directory.
1060         * wpe/manifest.txt.in: Add Tools/gtkdoc directory and uncomment lines to move documentation artifacts.
1061
1062 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1063
1064         [iOS] Precision drop state thrashes when dragging near the top edge of an editable element
1065         https://bugs.webkit.org/show_bug.cgi?id=193364
1066         <rdar://problem/47214117>
1067
1068         Reviewed by Tim Horton.
1069
1070         Add a test to verify that dragging near the top of a textarea element does not flag the drop proposal as
1071         precise, whereas dragging near the middle of the textarea does.
1072
1073         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
1074         (TestWebKitAPI::TEST):
1075
1076 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
1077
1078         webkitpy: Support alternate simctl device list output
1079         https://bugs.webkit.org/show_bug.cgi?id=193362
1080         <rdar://problem/47122965>
1081
1082         Reviewed by Lucas Forschler.
1083
1084         * Scripts/webkitpy/xcode/simulated_device.py:
1085         (SimulatedDeviceManager.populate_available_devices):
1086
1087 2019-01-11  Aakash Jain  <aakash_jain@apple.com>
1088
1089         [ews-build] Update macOS queue configurations
1090         https://bugs.webkit.org/show_bug.cgi?id=193365
1091
1092         Reviewed by Lucas Forschler.
1093
1094         * BuildSlaveSupport/ews-build/config.json:
1095
1096 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
1097
1098         webkitpy: Incorporate device type into baseline search path
1099         https://bugs.webkit.org/show_bug.cgi?id=193356
1100         <rdar://problem/47215515>
1101
1102         Reviewed by Lucas Forschler.
1103
1104         We need a way to include device type in the baseline search path for iOS to support device specific test expectations.
1105
1106         * Scripts/webkitpy/port/base.py:
1107         (Port.default_baseline_search_path): Allow device type to be passed in.
1108         * Scripts/webkitpy/port/gtk.py:
1109         (GtkPort.default_baseline_search_path): Ignore device type.
1110         * Scripts/webkitpy/port/ios.py:
1111         (IOSPort.default_baseline_search_path): Optionally allow device type to be incorporated into the baseline search path.
1112         (IOSPort.test_expectations_file_position): Update index for the additional device-type specific baseline search path.
1113         * Scripts/webkitpy/port/ios_device_unittest.py:
1114         (IOSDeviceTest):
1115         * Scripts/webkitpy/port/ios_simulator_unittest.py:
1116         (IOSSimulatorTest):
1117         * Scripts/webkitpy/port/mac.py:
1118         (MacPort.default_baseline_search_path): Ignore device type.
1119         * Scripts/webkitpy/port/watch.py:
1120         (WatchPort.default_baseline_search_path): Ditto.
1121         * Scripts/webkitpy/port/win.py:
1122         (WinPort.default_baseline_search_path): Ditto.
1123         (WinCairoPort.default_baseline_search_path): Ditto.
1124         * Scripts/webkitpy/port/wpe.py:
1125         (WPEPort.default_baseline_search_path): Ditto.
1126
1127 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
1128
1129         webkitpy: Print abbreviated baseline search path that includes only folders that exist
1130         https://bugs.webkit.org/show_bug.cgi?id=193352
1131         <rdar://problem/47210736>
1132
1133         Reviewed by Lucas Forschler.
1134
1135         * Scripts/webkitpy/layout_tests/views/printing.py:
1136         (Printer.print_config): Print list on only baseline search paths which exist. 
1137         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
1138         (Testprinter.test_print_config):
1139
1140 2019-01-11  Joseph Pecoraro  <pecoraro@apple.com>
1141
1142         Cleanup possible WK*Copy/Create leaks in WebKitTestRunner
1143         https://bugs.webkit.org/show_bug.cgi?id=193340
1144
1145         Reviewed by David Kilzer.
1146
1147         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1148         (WTR::InjectedBundle::didReceiveMessageToPage):
1149         Pull the strings out into a WKRetainPtr.
1150
1151         * WebKitTestRunner/WebNotificationProvider.cpp:
1152         (WTR::WebNotificationProvider::closeWebNotification):
1153         Adopt the created value into the WKRetainPtr.
1154
1155         * WebKitTestRunner/mac/TestControllerMac.mm:
1156         (WTR::generateWhitelist):
1157         Immediately adopt a created value to avoid potential mistakes.
1158
1159 2019-01-11  Dominik Infuehr  <dinfuehr@igalia.com>
1160
1161         Enable DFG on ARM/Linux again
1162         https://bugs.webkit.org/show_bug.cgi?id=192496
1163
1164         Reviewed by Yusuke Suzuki.
1165
1166         After changing the bytecode format DFG was disabled on all 32-bit
1167         architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
1168         on ARM by default.
1169
1170         * Scripts/run-jsc-stress-tests:
1171
1172 2019-01-11  Timothy Hatcher  <timothy@apple.com>
1173
1174         Unreviewed, fix #ifdef in API test added in r239851.
1175         https://bugs.webkit.org/show_bug.cgi?id=193327
1176         rdar://problem/47093222
1177
1178         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm:
1179
1180 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1181
1182         Introduce IDL files for runtime-enabled UndoManager and UndoItem JavaScript API
1183         https://bugs.webkit.org/show_bug.cgi?id=193109
1184         <rdar://problem/44807048>
1185
1186         Reviewed by Ryosuke Niwa.
1187
1188         Introduce and respect a test option to enable the UndoManager API.
1189
1190         * WebKitTestRunner/TestController.cpp:
1191         (WTR::updateTestOptionsFromTestHeader):
1192         * WebKitTestRunner/TestOptions.h:
1193         (WTR::TestOptions::hasSameInitializationOptions const):
1194         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1195         (WTR::TestController::platformCreateWebView):
1196
1197 2019-01-11  Zalan Bujtas  <zalan@apple.com>
1198
1199         [LFC][BFC][MarginCollapsing] Adjust vertical position when box margin collapses through.
1200         https://bugs.webkit.org/show_bug.cgi?id=193346
1201
1202         Reviewed by Antti Koivisto.
1203
1204         * LayoutReloaded/misc/LFC-passing-tests.txt:
1205
1206 2019-01-10  Ryan Haddad  <ryanhaddad@apple.com>
1207
1208         Unreviewed, fix typo that breaks dashboard link.
1209
1210         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1211         (WebKitBuildbot):
1212
1213 2019-01-10  Ryan Haddad  <ryanhaddad@apple.com>
1214
1215         Update macOS queue configurations
1216         https://bugs.webkit.org/show_bug.cgi?id=193329
1217
1218         Reviewed by Alexey Proskuryakov.
1219
1220         * BuildSlaveSupport/build.webkit.org-config/config.json:
1221         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
1222         (BubbleQueueServer):
1223         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1224         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1225         (WebKitBuildbot):
1226         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1227         (table.queue-grid tr.platform.macos-sierra img.logo): Deleted.
1228         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1229
1230 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
1231
1232         MiniBrowser should be able to navigate to about:blank
1233         https://bugs.webkit.org/show_bug.cgi?id=193345
1234
1235         Reviewed by Simon Fraser.
1236
1237         * MiniBrowser/mac/BrowserWindowController.m:
1238         (-[BrowserWindowController addProtocolIfNecessary:]):
1239         Don't prepend "http://" to "about:" prefixed URLs like "about:blank".
1240
1241         * MiniBrowser/mac/WK1BrowserWindowController.m:
1242         (-[WK1BrowserWindowController fetch:]):
1243         * MiniBrowser/mac/WK2BrowserWindowController.m:
1244         (-[WK2BrowserWindowController fetch:]):
1245         Clean up the code that uses this to match style.
1246
1247 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
1248
1249         Remove MiniBrowser custom "Process Swap" menu item which does not work
1250         https://bugs.webkit.org/show_bug.cgi?id=193344
1251
1252         Reviewed by Simon Fraser.
1253
1254         There is a menu item under the Experimental menu that does work.
1255
1256         * MiniBrowser/mac/AppDelegate.m:
1257         (defaultConfiguration):
1258         * MiniBrowser/mac/SettingsController.h:
1259         * MiniBrowser/mac/SettingsController.m:
1260         (-[SettingsController _populateMenu]):
1261         (-[SettingsController validateMenuItem:]):
1262         (-[SettingsController processSwapOnNavigationEnabled]): Deleted.
1263         (-[SettingsController toggleProcessSwapOnNavigation:]): Deleted.
1264
1265 2019-01-10  Timothy Hatcher  <timothy@apple.com>
1266
1267         Add WKBundlePage SPI to temporarily force light or dark appearance on a page.
1268         https://bugs.webkit.org/show_bug.cgi?id=193327
1269         rdar://problem/47093222
1270
1271         Reviewed by Tim Horton.
1272
1273         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1274         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm: Added.
1275         (TestWebKitAPI::didFinishNavigation):
1276         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
1277         (TestWebKitAPI::TEST):
1278         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm: Added.
1279         (TestWebKitAPI::ForceLightAppearanceInBundleTest::ForceLightAppearanceInBundleTest):
1280         (TestWebKitAPI::ForceLightAppearanceInBundleTest::didCreatePage):
1281         (TestWebKitAPI::ForceLightAppearanceInBundleTest::didReceiveMessage):
1282         * TestWebKitAPI/Tests/WebKit/mac/dark-mode.html: Added.
1283
1284 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
1285
1286         Leak of WKWebProcessPlugInHitTestResult (160 bytes) in com.apple.WebKit.WebContent running layout tests
1287         https://bugs.webkit.org/show_bug.cgi?id=193338
1288         <rdar://problem/46664774>
1289
1290         Reviewed by David Kilzer.
1291
1292         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1293         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
1294
1295 2019-01-10  Commit Queue  <commit-queue@webkit.org>
1296
1297         Unreviewed, rolling out r239825.
1298         https://bugs.webkit.org/show_bug.cgi?id=193330
1299
1300         Broke tests on armv7/linux bots (Requested by guijemont on
1301         #webkit).
1302
1303         Reverted changeset:
1304
1305         "Enable DFG on ARM/Linux again"
1306         https://bugs.webkit.org/show_bug.cgi?id=192496
1307         https://trac.webkit.org/changeset/239825
1308
1309 2019-01-10  Zhifei Fang  <zhifei_fang@apple.com>
1310
1311         Disable the run-jsc-stress-test remote host key check.
1312         https://bugs.webkit.org/show_bug.cgi?id=192988
1313
1314         Reviewed by Alexey Proskuryakov.
1315
1316         * Scripts/run-jsc-stress-tests:
1317
1318 2019-01-10  John Wilander  <wilander@apple.com>
1319
1320         Override the session configuration for cookieAcceptPolicy
1321         https://bugs.webkit.org/show_bug.cgi?id=190925
1322         <rdar://problem/45497382>
1323
1324         Reviewed by Alexey Proskuryakov and Alex Christensen.
1325
1326         Test infrastructure for setting a first-party-only cookie policy.
1327
1328         * DumpRenderTree/TestRunner.cpp:
1329         (setOnlyAcceptFirstPartyCookiesCallback):
1330         (TestRunner::staticFunctions):
1331         * DumpRenderTree/TestRunner.h:
1332         * DumpRenderTree/mac/TestRunnerMac.mm:
1333         (TestRunner::setOnlyAcceptFirstPartyCookies):
1334         * DumpRenderTree/win/TestRunnerWin.cpp:
1335         (TestRunner::setOnlyAcceptFirstPartyCookies):
1336         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1337         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1338         (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
1339         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1340         * WebKitTestRunner/TestInvocation.cpp:
1341         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1342
1343 2019-01-09  Matt Rajca  <mrajca@apple.com>
1344
1345         Put per-document autoplay behavior behind runtime website policies quirk instead of a compile time flag
1346         https://bugs.webkit.org/show_bug.cgi?id=193301
1347
1348         Reviewed by Jer Noble.
1349         
1350         Added API tests.
1351
1352         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1353         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1354         (TEST):
1355         * TestWebKitAPI/Tests/WebKitCocoa/autoplaying-multiple-media-elements.html: Added.
1356
1357 2019-01-10  Zalan Bujtas  <zalan@apple.com>
1358
1359         [LFC][BFC][MarginCollapsing] Take collapsed through siblings into account when computing vertical position
1360         https://bugs.webkit.org/show_bug.cgi?id=193310
1361
1362         Reviewed by Antti Koivisto.
1363
1364         * LayoutReloaded/misc/LFC-passing-tests.txt:
1365
1366 2019-01-10  Dominik Infuehr  <dinfuehr@igalia.com>
1367
1368         Enable DFG on ARM/Linux again
1369         https://bugs.webkit.org/show_bug.cgi?id=192496
1370
1371         Reviewed by Yusuke Suzuki.
1372
1373         After changing the bytecode format DFG was disabled on all 32-bit
1374         architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
1375         on ARM by default.
1376
1377         * Scripts/run-jsc-stress-tests:
1378
1379 2019-01-09  Fujii Hironori  <Hironori.Fujii@sony.com>
1380
1381         [Win][MiniBrowser] wchar_t strings shouldn't be treated as BSTR
1382         https://bugs.webkit.org/show_bug.cgi?id=193271
1383
1384         Reviewed by Brent Fulgham.
1385
1386         BSTR is a special data structure created by SysAllocString, not a
1387         wchar_t null-terminated string.
1388
1389         * DumpRenderTree/win/TestRunnerWin.cpp:
1390         (TestRunner::setDatabaseQuota): Use L"" instead of "" for _bstr_t.
1391         * MiniBrowser/win/MiniBrowserWebHost.cpp:
1392         (MiniBrowserWebHost::didFinishLoadForFrame): Use _bstr_t to create
1393         BSTR from wide string literals.
1394
1395 2019-01-09  Alexey Proskuryakov  <ap@apple.com>
1396
1397         Tweak wording for build/version_check style checker error
1398         https://bugs.webkit.org/show_bug.cgi?id=193256
1399
1400         Reviewed by Tim Horton.
1401
1402         * Scripts/webkitpy/style/checkers/cpp.py:
1403         (check_os_version_checks):
1404         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1405         (WebKitStyleTest.test_os_version_checks):
1406
1407 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
1408
1409         [ews-build] Add link to bug along with bug title
1410         https://bugs.webkit.org/show_bug.cgi?id=193293
1411
1412         Reviewed by Lucas Forschler.
1413
1414         * BuildSlaveSupport/ews-build/steps.py:
1415         (ValidatePatch._is_bug_closed): Fetch bug title from Bugzilla and add it to the build.
1416         (ConfigureBuild.add_bug_id_url): Deleted.
1417         (ConfigureBuild.getBugURL): Deleted.
1418
1419 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
1420
1421         [ews-build] Use https for ews-build server
1422         https://bugs.webkit.org/show_bug.cgi?id=193193
1423
1424         Reviewed by Lucas Forschler.
1425
1426         * BuildSlaveSupport/ews-build/steps.py:
1427
1428 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
1429
1430         [ews-build] Parse and display number of style failures
1431         https://bugs.webkit.org/show_bug.cgi?id=193280
1432
1433         Reviewed by Lucas Forschler.
1434
1435         * BuildSlaveSupport/ews-build/steps.py:
1436         (CheckStyle): Use TestWithFailureCount as base class.
1437         (CheckStyle.countFailures): Count the number of style failures.
1438
1439 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
1440
1441         [ews-build] use patch_id instead of ewspatchid
1442         https://bugs.webkit.org/show_bug.cgi?id=193235
1443
1444         Reviewed by Lucas Forschler.
1445
1446         * BuildSlaveSupport/ews-build/factories.py: Replaced ewspatchid with patch_id.
1447         * BuildSlaveSupport/ews-build/steps.py: Ditto.
1448         * BuildSlaveSupport/ews-build/steps_unittest.py: Ditto.
1449
1450 2019-01-09  Zalan Bujtas  <zalan@apple.com>
1451
1452         [LFC][BFC][MarginCollapsing] Add support for peculiar cases.
1453         https://bugs.webkit.org/show_bug.cgi?id=192625
1454
1455         Reviewed by Antti Koivisto.
1456
1457         * LayoutReloaded/misc/LFC-passing-tests.txt:
1458
1459 2019-01-09  Michael Catanzaro  <mcatanzaro@igalia.com>
1460
1461         [WPE][GTK] Purge use of g_assert() under TestWebKitAPI
1462         https://bugs.webkit.org/show_bug.cgi?id=192841
1463
1464         Reviewed by Carlos Garcia Campos.
1465
1466         There are separate g_assert_*() macros for use in tests, which we use inconsistently
1467         currently. Use them always. We'll get nicer error messages now when tests fail, and the
1468         assertions will now run during tests even if G_DISABLE_ASSERT is used when building.
1469
1470         Note that the documentation of g_assert() says that it is not to be used when writing tests.
1471
1472         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1473         * TestWebKitAPI/Tests/WebKitGLib/EditorTest.cpp:
1474         (WebKitWebEditorTest::testSelectionChanged):
1475         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp:
1476         (WebKitFrameTest::testMainFrame):
1477         (WebKitFrameTest::testURI):
1478         (WebKitFrameTest::testJavaScriptContext):
1479         (WebKitFrameTest::testJavaScriptValues):
1480         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
1481         (testWebViewAuthenticationRequest):
1482         (testWebViewAuthenticationLoadCancelled):
1483         (testWebViewAuthenticationFailure):
1484         (testWebViewAuthenticationStorage):
1485         (ProxyAuthenticationTest::ProxyAuthenticationTest):
1486         (testWebViewAuthenticationProxy):
1487         (testWebViewAuthenticationProxyHTTPS):
1488         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
1489         (testAutomationSessionRequestSession):
1490         * TestWebKitAPI/Tests/WebKitGLib/TestBackForwardList.cpp:
1491         (testBackForwardListNavigation):
1492         (testWebKitWebViewSessionState):
1493         (testWebKitWebViewSessionStateWithFormData):
1494         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
1495         (ConsoleMessageTest::consoleMessageReceivedCallback):
1496         (testWebKitConsoleMessageConsoleAPI):
1497         (testWebKitConsoleMessageJavaScriptException):
1498         (testWebKitConsoleMessageNetworkError):
1499         (testWebKitConsoleMessageSecurityError):
1500         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
1501         (testCookieManagerAcceptPolicy):
1502         (testCookieManagerCookiesChanged):
1503         (testCookieManagerPersistentStorage):
1504         (testCookieManagerPersistentStorageDeleteAll):
1505         (testCookieManagerEphemeral):
1506         * TestWebKitAPI/Tests/WebKitGLib/TestDOMElement.cpp:
1507         (testWebKitDOMElementAutoFill):
1508         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:
1509         (downloadLocalFileSuccessfully):
1510         (createFileAtDestination):
1511         (testDownloadOverwriteDestinationDisallowed):
1512         (testDownloadLocalFileError):
1513         (testDownloadRemoteFile):
1514         (testDownloadRemoteFileError):
1515         (testWebViewDownloadURI):
1516         (testPolicyResponseDownload):
1517         (testPolicyResponseDownloadCancel):
1518         (testDownloadMIMEType):
1519         (contextMenuCallback):
1520         (testContextMenuDownloadActions):
1521         (testBlobDownload):
1522         * TestWebKitAPI/Tests/WebKitGLib/TestEditor.cpp:
1523         (testWebKitWebEditorSelectionChanged):
1524         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp:
1525         (testWebKitFrameMainFrame):
1526         (testWebKitFrameURI):
1527         (testWebKitFrameJavaScriptContext):
1528         (testWebKitFrameJavaScriptValues):
1529         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
1530         (LoadStopTrackingTest::loadFailed):
1531         (testWebViewTitle):
1532         (testURIRequestHTTPHeaders):
1533         (testURIRequestHTTPMethod):
1534         (testURIResponseHTTPHeaders):
1535         (testRedirectToDataURI):
1536         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp:
1537         (testProcessPerWebView):
1538         (testWebProcessLimit):
1539         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
1540         (testWebViewResources):
1541         (testWebResourceLoading):
1542         (testWebResourceSuggestedFilename):
1543         (testWebResourceGetData):
1544         (testWebResourceGetDataError):
1545         (testWebViewResourcesHistoryCache):
1546         (testWebResourceSendRequest):
1547         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
1548         (testSSL):
1549         (testInsecureContent):
1550         (testTLSErrorsPolicy):
1551         (testTLSErrorsRedirect):
1552         (testTLSErrorsHTTPAuth):
1553         (testLoadFailedWithTLSErrors):
1554         (testSubresourceLoadFailedWithTLSErrors):
1555         (httpsServerCallback):
1556         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
1557         (testWebViewCreateNavigationData):
1558         (testWebViewJavaScriptDialogs):
1559         (testWebViewWindowProperties):
1560         (testWebViewMouseTarget):
1561         (testWebViewFileChooserRequest):
1562         (testWebViewColorChooserRequest):
1563         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
1564         (testWebExtensionGetTitle):
1565         (testDocumentLoadedSignal):
1566         (testWebKitWebViewProcessCrashed):
1567         (testWebExtensionWindowObjectCleared):
1568         (testWebExtensionIsolatedWorld):
1569         (permissionRequestCallback):
1570         (didAssociateFormControlsCallback):
1571         (testWebExtensionFormControlsAssociated):
1572         (FormSubmissionTest::FormSubmissionTest):
1573         (FormSubmissionTest::testFormSubmissionResult):
1574         (testWebExtensionFormSubmissionSteps):
1575         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
1576         (testNotInitialized):
1577         (testClearDatabase):
1578         (testPrivateBrowsing):
1579         (testGetFavicon):
1580         (testWebViewFavicon):
1581         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFindController.cpp:
1582         (testFindControllerTextFound):
1583         (testFindControllerTextNotFound):
1584         (testFindControllerMatchCount):
1585         (testFindControllerMaxMatchCount):
1586         (testFindControllerNext):
1587         (testFindControllerPrevious):
1588         (testFindControllerCountedMatches):
1589         (testFindControllerOptions):
1590         (testFindControllerHide):
1591         (testFindControllerInstance):
1592         (testFindControllerGetters):
1593         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitPolicyClient.cpp:
1594         (testNavigationPolicy):
1595         (testResponsePolicy):
1596         (testNewWindowPolicy):
1597         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSecurityOrigin.cpp:
1598         (testSecurityOriginBasicConstructor):
1599         (testSecurityOriginURIConstructor):
1600         (testSecurityOriginDefaultPort):
1601         (testSecurityOriginFileURI):
1602         (testOpaqueSecurityOrigin):
1603         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
1604         (testWebKitSettings):
1605         (testWebKitSettingsNewWithSettings):
1606         (testWebKitSettingsUserAgent):
1607         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
1608         (testWebViewNewWithUserContentManager):
1609         (isStyleSheetInjectedForURLAtPath):
1610         (isScriptInjectedForURLAtPath):
1611         (testUserContentManagerInjectedStyleSheet):
1612         (testUserContentManagerInjectedScript):
1613         (UserScriptMessageTest::scriptMessageReceived):
1614         (UserScriptMessageTest::waitUntilMessageReceived):
1615         (UserScriptMessageTest::runJavaScriptFinished):
1616         (testUserContentManagerScriptMessageReceived):
1617         (testUserContentManagerScriptMessageInWorldReceived):
1618         (testUserContentManagerScriptMessageFromDOMBindings):
1619         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
1620         (testWebContextDefault):
1621         (testWebContextEphemeral):
1622         (testWebContextGetPlugins):
1623         (testWebContextURIScheme):
1624         (testWebContextSpellChecker):
1625         (testWebContextLanguages):
1626         (consoleMessageReceivedCallback):
1627         (testWebContextSecurityFileXHR):
1628         (ProxyTest::ProxyTest):
1629         (testWebContextProxySettings):
1630         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
1631         (testWebViewWebContext):
1632         (testWebViewWebBackend):
1633         (testWebViewEphemeral):
1634         (testWebViewCustomCharset):
1635         (testWebViewSettings):
1636         (testWebViewRunJavaScript):
1637         (testWebViewCanShowMIMEType):
1638         (testWebViewSubmitForm):
1639         (testWebViewSave):
1640         (testWebViewPageVisibility):
1641         (testWebViewSnapshot):
1642         (testWebViewNotification):
1643         (testWebViewNotificationInitialPermissionAllowed):
1644         (testWebViewNotificationInitialPermissionDisallowed):
1645         (testWebViewIsPlayingAudio):
1646         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
1647         (WebsiteDataTest::WebsiteDataTest):
1648         (WebsiteDataTest::remove):
1649         (WebsiteDataTest::clear):
1650         (testWebsiteDataConfiguration):
1651         (testWebsiteDataEphemeral):
1652         (testWebsiteDataCache):
1653         (testWebsiteDataStorage):
1654         (testWebsiteDataDatabases):
1655         (testWebsiteDataAppcache):
1656         (testWebsiteDataCookies):
1657         (testWebsiteDataDeviceIdHashSalt):
1658         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1659         (emitDocumentLoaded):
1660         (emitURIChanged):
1661         (sendRequestCallback):
1662         (contextMenuCallback):
1663         (consoleMessageSentCallback):
1664         (emitFormControlsAssociated):
1665         (formControlsAssociatedCallback):
1666         (emitFormSubmissionEvent):
1667         (willSubmitFormCallback):
1668         (windowObjectCleared):
1669         (methodCallCallback):
1670         (registerGResource):
1671         (webkit_web_extension_initialize_with_user_data):
1672         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.cpp:
1673         (checkLeaks):
1674         (WebProcessTest::create):
1675         (runTest):
1676         * TestWebKitAPI/Tests/WebKitGtk/AutocleanupsTest.cpp:
1677         (AutocleanupsTest::testWebProcessAutocleanups):
1678         * TestWebKitAPI/Tests/WebKitGtk/DOMClientRectTest.cpp:
1679         (WebKitDOMClientRectTest::testDivBoundingClientRectPosition):
1680         (WebKitDOMClientRectTest::testDivClientRectsPositionAndLength):
1681         * TestWebKitAPI/Tests/WebKitGtk/DOMDOMWindowTest.cpp:
1682         (WebKitDOMDOMWindowTest::testSignals):
1683         (WebKitDOMDOMWindowTest::testDispatchEvent):
1684         (WebKitDOMDOMWindowTest::testGetComputedStyle):
1685         * TestWebKitAPI/Tests/WebKitGtk/DOMNodeFilterTest.cpp:
1686         (WebKitDOMNodeFilterTest::testTreeWalker):
1687         (WebKitDOMNodeFilterTest::testNodeIterator):
1688         * TestWebKitAPI/Tests/WebKitGtk/DOMNodeTest.cpp:
1689         (WebKitDOMNodeTest::testHierarchyNavigation):
1690         (WebKitDOMNodeTest::testInsertion):
1691         (WebKitDOMNodeTest::testTagNamesNodeList):
1692         (WebKitDOMNodeTest::testTagNamesHTMLCollection):
1693         (WebKitDOMNodeTest::testDOMCache):
1694         * TestWebKitAPI/Tests/WebKitGtk/DOMXPathNSResolverTest.cpp:
1695         (WebKitDOMXPathNSResolverTest::evaluateFooChildTextAndCheckResult):
1696         (WebKitDOMXPathNSResolverTest::testXPathNSResolverNative):
1697         (WebKitDOMXPathNSResolverTest::testXPathNSResolverCustom):
1698         * TestWebKitAPI/Tests/WebKitGtk/TestAutocleanups.cpp:
1699         (testUIProcessAutocleanups):
1700         (testWebProcessAutocleanups):
1701         * TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp:
1702         (testContextMenuPopulateMenu):
1703         (testContextMenuDismissed):
1704         * TestWebKitAPI/Tests/WebKitGtk/TestDOMClientRect.cpp:
1705         (testWebKitDOMClientRectDivBoundingClientRectPosition):
1706         (testWebKitDOMClientRectDivClientRectsPositionAndLength):
1707         * TestWebKitAPI/Tests/WebKitGtk/TestDOMDOMWindow.cpp:
1708         (testWebKitDOMDOMWindowSignals):
1709         (testWebKitDOMDOMWindowDispatchEvent):
1710         (testWebKitDOMDOMWindowGetComputedStyle):
1711         * TestWebKitAPI/Tests/WebKitGtk/TestDOMNode.cpp:
1712         (testWebKitDOMNodeHierarchyNavigation):
1713         (testWebKitDOMNodeInsertion):
1714         (testWebKitDOMNodeTagNamesNodeList):
1715         (testWebKitDOMNodeTagNamesHTMLCollection):
1716         (testWebKitDOMObjectCache):
1717         * TestWebKitAPI/Tests/WebKitGtk/TestDOMNodeFilter.cpp:
1718         (testWebKitDOMNodeFilterTreeWalker):
1719         (testWebKitDOMNodeFilterNodeIterator):
1720         * TestWebKitAPI/Tests/WebKitGtk/TestDOMXPathNSResolver.cpp:
1721         (testWebKitDOMXPathNSResolverNative):
1722         (testWebKitDOMXPathNSResolverCustom):
1723         * TestWebKitAPI/Tests/WebKitGtk/TestInspector.cpp:
1724         (testInspectorDefault):
1725         (testInspectorManualAttachDetach):
1726         (testInspectorCustomContainerDestroyed):
1727         * TestWebKitAPI/Tests/WebKitGtk/TestInspectorServer.cpp:
1728         (startTestServer):
1729         (testInspectorServerPageList):
1730         * TestWebKitAPI/Tests/WebKitGtk/TestOptionMenu.cpp:
1731         (OptionMenuTest::showOptionMenuCallback):
1732         (OptionMenuTest::menuCloseCallback):
1733         (OptionMenuTest::close):
1734         (OptionMenuTest::activateItem):
1735         (OptionMenuTest::selectItem):
1736         (testOptionMenuSimple):
1737         (testOptionMenuGroups):
1738         (testOptionMenuActivate):
1739         (testOptionMenuSelect):
1740         * TestWebKitAPI/Tests/WebKitGtk/TestPrinting.cpp:
1741         (testPrintOperationPrintSettings):
1742         (webViewPrintCallback):
1743         (testPrintOperationPrint):
1744         (testPrintCustomWidget):
1745         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
1746         (checkAtspiAccessible):
1747         (testAtspiBasicHierarchy):
1748         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitVersion.cpp:
1749         (testWebKitCheckVersion):
1750         * TestWebKitAPI/Tests/WebKitGtk/TestWebViewEditor.cpp:
1751         (testWebViewEditorCutCopyPasteNonEditable):
1752         (testWebViewEditorCutCopyPasteEditable):
1753         (testWebViewEditorSelectAllNonEditable):
1754         (testWebViewEditorSelectAllEditable):
1755         (loadContentsAndTryToCutSelection):
1756         (testWebViewEditorNonEditable):
1757         (testWebViewEditorEditable):
1758         (testWebViewEditorEditorStateTypingAttributes):
1759         (testWebViewEditorInsertImage):
1760         (testWebViewEditorCreateLink):
1761         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp:
1762         (loadChangedCallback):
1763         (loadFailedCallback):
1764         (loadFailedWithTLSErrorsCallback):
1765         (LoadTrackingTest::LoadTrackingTest):
1766         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
1767         (registerGResource):
1768         (removeNonEmptyDirectory):
1769         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
1770         (Test::adoptView):
1771         (Test::~Test):
1772         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
1773         (WebKitTestBus::getOrCreateConnection):
1774         (WebKitTestBus::createProxy):
1775         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.cpp:
1776         (WebKitTestServer::getWebSocketURIForPath const):
1777         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
1778         (WebViewTest::initializeWebView):
1779         (WebViewTest::loadURI):
1780         (WebViewTest::loadHtml):
1781         (WebViewTest::loadPlainText):
1782         (WebViewTest::loadBytes):
1783         (WebViewTest::loadRequest):
1784         (WebViewTest::loadAlternateHTML):
1785         (WebViewTest::goBack):
1786         (WebViewTest::goForward):
1787         (WebViewTest::goToBackForwardListItem):
1788         (resourceGetDataCallback):
1789         (WebViewTest::mainResourceData):
1790         (WebViewTest::javascriptResultToCString):
1791         (WebViewTest::javascriptResultToNumber):
1792         (WebViewTest::javascriptResultToBoolean):
1793         (WebViewTest::javascriptResultIsNull):
1794         (WebViewTest::javascriptResultIsUndefined):
1795         (onSnapshotReady):
1796         (WebViewTest::runWebProcessTest):
1797         * TestWebKitAPI/glib/WebKitGLib/gtk/WebViewTestGtk.cpp:
1798         (WebViewTest::platformInitializeWebView):
1799         (WebViewTest::showInWindow):
1800         (WebViewTest::showInWindowAndWaitUntilMapped):
1801         (WebViewTest::mouseMoveTo):
1802         (WebViewTest::emitPopupMenuSignal):
1803         (WebViewTest::keyStroke):
1804         (WebViewTest::doMouseButtonEvent):
1805
1806 2019-01-09  Philippe Normand  <pnormand@igalia.com>
1807
1808         [WPE] API tests can't run in flatpak environment
1809         https://bugs.webkit.org/show_bug.cgi?id=193242
1810
1811         Reviewed by Michael Catanzaro.
1812
1813         * Scripts/run-wpe-tests: Add --wpe to arguments passed to
1814         flatpakutils so that it knows which port it's dealing with.
1815         * glib/common.py: Remove build_dir globals so that subsequent
1816         calls actually take args into account.
1817         (library_build_path):
1818         (binary_build_path):
1819
1820 2019-01-08  Dean Jackson  <dino@apple.com>
1821
1822         Blob references for System Previews don't get a correct file extension
1823         https://bugs.webkit.org/show_bug.cgi?id=193268
1824         <rdar://problem/47133037>
1825
1826         Reviewed by Tim Horton.
1827
1828         New test that a Blob download of a USDZ file gets named correctly.
1829
1830         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1831         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1832         (-[BlobWithUSDZExtensionDownloadDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
1833         (-[BlobWithUSDZExtensionDownloadDelegate _downloadDidFinish:]):
1834         (TEST):
1835         * TestWebKitAPI/Tests/WebKitCocoa/SystemPreviewBlobNaming.html: Added.
1836
1837 2019-01-08  Jiewen Tan  <jiewen_tan@apple.com>
1838
1839         [WebAuthN] Support U2F HID Authenticators on macOS
1840         https://bugs.webkit.org/show_bug.cgi?id=191535
1841         <rdar://problem/47102027>
1842
1843         Reviewed by Brent Fulgham.
1844
1845         This patch:
1846         1) adds support for U2F mocking mechanism;
1847         2) updates tests to reflect U2fCommandConstructor changes.
1848
1849         * TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp:
1850         (TestWebKitAPI::TEST):
1851         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
1852         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1853         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
1854
1855 2019-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1856
1857         [iOS] Dispatch a synthetic mousedown event prior to starting drags
1858         https://bugs.webkit.org/show_bug.cgi?id=193229
1859         <rdar://problem/46717097>
1860
1861         Reviewed by Tim Horton.
1862
1863         Add a cross-platform drag and drop test to verify that calling `preventDefault()` on the mousedown event
1864         prevents a drag from starting.
1865
1866         * TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm:
1867         * TestWebKitAPI/Tests/WebKitCocoa/link-and-target-div.html:
1868
1869         Tweak this test to make it robust when dragging the link to the target element multiple times in a single test.
1870
1871 2019-01-08  Zhifei Fang  <zhifei_fang@apple.com>
1872   
1873         Layout test will generate a perf metric file to results dir.
1874         https://bugs.webkit.org/show_bug.cgi?id=192030
1875         <rdar://problem/32779516>
1876
1877         Reviewed by Aakash Jain.
1878
1879         Layout test running time will be collected to a perf metric file.
1880         For now, instead of outputing running time of all tests (which is huge),
1881         we aggregate them by test directories which are at most two level deep. 
1882
1883         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1884         (Manager._end_test_run):
1885         (Manager._output_perf_metrics):
1886         (Manager._print_expectation_line_for_test):
1887         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1888         (add_test_perf_metric):
1889         (test_perf_metrics):
1890         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1891         (JSONGeneratorTest.test_test_timings_trie):
1892         (JSONGeneratorTest):
1893         (JSONGeneratorTest.test_test_perf_metrics):
1894         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1895         (RebaselineTest.test_reset_results):
1896         (RebaselineTest.test_missing_results):
1897         (RebaselineTest.test_new_baseline):
1898
1899 2019-01-08  Patrick Griffis  <pgriffis@igalia.com>
1900
1901         [WPE][GTK] Add php-json to install-dependencies
1902         https://bugs.webkit.org/show_bug.cgi?id=193233
1903
1904         Reviewed by Michael Catanzaro.
1905
1906         * gtk/install-dependencies:
1907         * wpe/install-dependencies:
1908
1909 2019-01-08  Chris Dumez  <cdumez@apple.com>
1910
1911         Regression(PSON-r239182): Blank view when navigating back and forth between google.com and stack overflow
1912         https://bugs.webkit.org/show_bug.cgi?id=193224
1913         <rdar://problem/47097726>
1914
1915         Reviewed by Alex Christensen.
1916
1917         Add API test coverage.
1918
1919         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1920
1921 2019-01-07  David Kilzer  <ddkilzer@apple.com>
1922
1923         Leak of ScrollCompletionCallbackData (16 bytes) in com.apple.WebKit.WebContent running WebKit layout tests
1924         <https://webkit.org/b/193222>
1925         <rdar://problem/46862309>
1926
1927         Reviewed by Joseph Pecoraro.
1928
1929         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1930         (WTR::executeCallback): Fix camel case of variable name.
1931         (WTR::EventSendingController::callAfterScrollingCompletes): If
1932         WKBundlePageRegisterScrollOperationCompletionCallback() returns
1933         false, make sure to release the ScrollCompletionCallbackData
1934         object.  This fixes the leak.
1935
1936 2019-01-07  Fujii Hironori  <Hironori.Fujii@sony.com>
1937
1938         [Win] EWS: wincairo-ews cannot apply a patch with *.png
1939         https://bugs.webkit.org/show_bug.cgi?id=193044
1940
1941         Reviewed by Daniel Bates.
1942
1943         WinCairo EWS bots are using Windows Perl. Binary files should be
1944         opened as binary mode.
1945
1946         * Scripts/svn-apply:
1947         (handleGitBinaryChange): Use 'binmode' for binary file handles.
1948
1949 2019-01-07  Don Olmstead  <don.olmstead@sony.com>
1950
1951         [CMake] Add ENABLE_CSS_TYPED_OM option
1952         https://bugs.webkit.org/show_bug.cgi?id=193216
1953
1954         Reviewed by Michael Catanzaro.
1955
1956         * Scripts/webkitperl/FeatureList.pm:
1957
1958 2019-01-07  David Kilzer  <ddkilzer@apple.com>
1959
1960         Prefer RetainPtr<NSObject> to RetainPtr<NSObject *>
1961         <https://webkit.org/b/193056>
1962
1963         Reviewed by Alex Christensen.
1964
1965         * Scripts/webkitpy/style/checker.py:
1966         - Ignore use of new runtime/retainptr check in
1967           Tools/TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm since it
1968           contains tests to ensure RetainPtr<NSObject *> is compatible
1969           with RetainPtr<NSObject>.
1970
1971         * Scripts/webkitpy/style/checkers/cpp.py:
1972         (check_language):
1973         (CppChecker):
1974         - Add checker for use of '*' in RetainPtr<> type.  A for loop
1975           was used instead of a single regex so that angle brackets
1976           could be matched up when checking the type contained within
1977           the RetainPtr<> type.
1978
1979         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1980         (CppStyleTest):
1981         - Add unit test for new runtime/retainptr check.
1982
1983         * TestRunnerShared/EventSerialization/mac/EventSerializerMac.h:
1984         * TestWebKitAPI/EditingTestHarness.h:
1985         - Remove '*' from RetainPtr<> type.
1986
1987         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1988         - Add cf/RetainPtr.cpp back to TestWTFLibrary target!  This
1989           regressed in r201938.
1990
1991         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp:
1992         (TestWebKitAPI::TEST):
1993         - Update tests to match RetainPtr.mm tests (except for the
1994           `*SimilarNSType` tests since there is no CF equivalent of
1995           RetainPtr<NSString> and RetainPtr<NSString *>).
1996
1997         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
1998         (TestWebKitAPI::TEST):
1999         - Update tests to:
2000           - Not conflict by name with equivalent CF tests in
2001             RetainPtr.cpp.
2002           - Add test cases for RetainPtr<NSObject>,
2003             RetainPtr<NSObject *> and RetainPtr<id> were appropriate.
2004           - Add `*SimilarNSType` tests for converting between
2005             RetainPtr<NSObject> and RetainPtr<NSObject *>.
2006           - Change `0` to `nil` as appropriate.
2007           - Re-alphabetize the tests by name.
2008           - Add Optional<RetainPtr<>> tests.
2009           - Add retainPtr() tests.
2010
2011         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
2012         (-[DownloadProgressTestRunner _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2013         * TestWebKitAPI/Tests/WebKitCocoa/IconLoadingDelegate.mm:
2014         (TEST):
2015         - Remove '*' from RetainPtr<> type.
2016
2017         * TestWebKitAPI/Tests/WebKitCocoa/JITEnabled.mm:
2018         (TEST(WebKit, JITEnabled)):
2019         - Add missing WTFMove().  Apparently a temporary was being
2020           created before in the argument list due to mismatched
2021           RetainPtr<> types.
2022
2023         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2024         * TestWebKitAPI/Tests/WebKitCocoa/VideoControlsManager.mm:
2025         (TestWebKitAPI::setUpWebViewForTestingVideoControlsManager):
2026         (TestWebKitAPI::TEST):
2027         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2028         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2029         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
2030         (WTR::resourcesDirectoryURL):
2031         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
2032         (WTR::InjectedBundle::platformInitialize):
2033         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2034         - Remove '*' from RetainPtr<> type.
2035
2036 2019-01-07  Eric Carlson  <eric.carlson@apple.com>
2037
2038         A MediaTime timescale must never be zero
2039         https://bugs.webkit.org/show_bug.cgi?id=193156
2040         <rdar://problem/32504501>
2041
2042         Reviewed by Jer Noble.
2043
2044         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
2045         (TestWebKitAPI::TEST): Add tests for zero timescale.
2046
2047 2019-01-07  Youenn Fablet  <youenn@apple.com>
2048
2049         API test broken: TestWebKitAPI.WebKit.CustomDataStorePathsVersusCompletionHandlers
2050         https://bugs.webkit.org/show_bug.cgi?id=193175
2051
2052         Reviewed by Chris Dumez.
2053
2054         Updated API test as we bumped the SW schema to version 4.
2055
2056         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2057         * TestWebKitAPI/Tests/WebKitCocoa/SimpleServiceWorkerRegistrations-4.sqlite3: Renamed from Tools/TestWebKitAPI/Tests/WebKitCocoa/SimpleServiceWorkerRegistrations-3.sqlite3.
2058         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2059         (TEST):
2060
2061 2019-01-06  Fujii Hironori  <Hironori.Fujii@sony.com>
2062
2063         [Win][Clang] Fix compilation warnings of MiniBrowser
2064         https://bugs.webkit.org/show_bug.cgi?id=193029
2065
2066         Reviewed by Ross Kirsling.
2067
2068         * MiniBrowser/win/MiniBrowserWebHost.h: Removed unused m_oldFont
2069         and m_URLBarFont. Reorder member variables to fix -Wreorder
2070         warning.
2071         * MiniBrowser/win/PageLoadTestClient.cpp:
2072         (PageLoadTestClient::PageLoadTestClient): Reorder the member initializer list.
2073         * MiniBrowser/win/PageLoadTestClient.h: Removed 'virtual' of
2074         pageLoadStartedAtTime and pageLoadEndedAtTime. Removed unused
2075         m_currentURLIndex.
2076         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2077         (WebKitBrowserWindow::WebKitBrowserWindow): Initialize
2078         navigationClient with '{ }' to fix the missing field warning.
2079         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
2080         (initDocStruct): Changed the argument type docname to const.
2081
2082 2019-01-06  Jiewen Tan  <jiewen_tan@apple.com>
2083
2084         [WebAuthN] Import U2F command/response converters from Chromium
2085         https://bugs.webkit.org/show_bug.cgi?id=193150
2086         <rdar://problem/47054028>
2087
2088         Reviewed by Brent Fulgham.
2089
2090         Adds API tests.
2091
2092         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2093         * TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp:
2094         (TestWebKitAPI::getTestAttestedCredentialDataBytes):
2095         (TestWebKitAPI::getTestAuthenticatorDataBytes):
2096         (TestWebKitAPI::getTestAttestationObjectBytes):
2097         (TestWebKitAPI::getTestSignResponse):
2098         (TestWebKitAPI::getTestU2fRegisterResponse):
2099         (TestWebKitAPI::TEST):
2100         (TestWebKitAPI::convertToVector): Deleted.
2101         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
2102         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp: Added.
2103         (TestWebKitAPI::constructMakeCredentialRequest):
2104         (TestWebKitAPI::constructGetAssertionRequest):
2105         (TestWebKitAPI::TEST):
2106
2107 2019-01-05  Oriol Brufau  <obrufau@igalia.com>
2108
2109         [GTK] Add python3-setuptools, libunistring-dev, bison and flex dependencies
2110         https://bugs.webkit.org/show_bug.cgi?id=193136
2111
2112         Reviewed by Michael Catanzaro.
2113
2114         * gtk/install-dependencies:
2115         Add python3-setuptools, libunistring-dev, bison and flex to install-dependencies,
2116         they are needed by update-webkitgtk-libs.
2117
2118 2019-01-05  Aakash Jain  <aakash_jain@apple.com>
2119
2120         Unreviewed follow-up fix to r239650
2121         https://bugs.webkit.org/show_bug.cgi?id=193140
2122         <rdar://problem/47063037>
2123
2124         Typecast patch_id to string.
2125
2126         * BuildSlaveSupport/ews-build/steps.py:
2127         (ValidatePatch._is_patch_obsolete):
2128
2129 2019-01-04  Daniel Bates  <dabates@apple.com>
2130
2131         [lldb-webkit]: Add support for pretty-printing raw bitmask types
2132         https://bugs.webkit.org/show_bug.cgi?id=193024
2133
2134         Reviewed by Jer Noble.
2135
2136         Add support infrastructure to pretty-print a raw bitmask type. Included is a pretty-printer
2137         for the bitmask type WebEventFlags as an example.
2138
2139         Exposed a new function lldb_webkit.addSummaryAndSyntheticFormattersForRawBitmaskType()
2140         that can be used to register summary and synthetic child formatters for a bitmask type.
2141         For example, consider the following enum and bitmask typedefs:
2142
2143         typedef enum {
2144             A = 1 << 0,
2145             B = 1 << 1,
2146             C = 1 << 2,
2147         } SpecialFlagValues;
2148         typedef unsigned SpecialFlags;
2149
2150         To teach lldb-webkit how to pretty print SpecialFlags types, add the following code inside
2151         __lldb_init_module():
2152
2153             addSummaryAndSyntheticFormattersForRawBitmaskType(debugger, "SpecialFlags", {
2154                     1 << 0: "A",
2155                     1 << 1: "B",
2156                     1 << 2: "C",
2157             })
2158
2159         * lldb/lldb_webkit.py:
2160         (addSummaryAndSyntheticFormattersForRawBitmaskType):
2161         (addSummaryAndSyntheticFormattersForRawBitmaskType.GeneratedRawBitmaskProvider):
2162         (addSummaryAndSyntheticFormattersForRawBitmaskType.raw_bitmask_summary_provider):
2163         (addSummaryAndSyntheticFormattersForRawBitmaskType.lldb_webkit):
2164         A convenience function to dynamically creaste a synthetic formatter class and summary
2165         string function for the specified bitmask type and enumerator value to name map. This
2166         function register the dynamically created class and function with LLDB.
2167
2168         (__lldb_init_module):
2169         (FlagEnumerationProvider):
2170         (FlagEnumerationProvider._enumerator_value_to_name_map):
2171         (FlagEnumerationProvider._bitmask):
2172         (FlagEnumerationProvider._update):
2173         (FlagEnumerationProvider.has_children):
2174         (FlagEnumerationProvider.num_children):
2175         (FlagEnumerationProvider.get_child_index):
2176         (FlagEnumerationProvider.get_child_at_index):
2177         (FlagEnumerationProvider.update):
2178         Extract out provider logic from WTFOptionSetProvider into a base class that can be shared.
2179
2180         (WTFOptionSetProvider):
2181         (WTFOptionSetProvider._enumerator_value_to_name_map):
2182         (WTFOptionSetProvider._bitmask):
2183         (WTFOptionSetProvider._update):
2184         Write in terms of the base class.
2185
2186         (RawBitmaskProviderBase):
2187         (RawBitmaskProviderBase._enumerator_value_to_name_map):
2188         (RawBitmaskProviderBase._bitmask):
2189         Added. Base synthetic formatter class for a raw bitmask type. Derived classes are expected to
2190         override the class variable ENUMERATOR_VALUE_TO_NAME_MAP with a dictionary of the form:
2191         {
2192             1 << 0: "A",
2193             1 << 1: "B",
2194             1 << 2: "C",
2195         }
2196         It is not necessary to instantiate such a derived class directory. Instead use the convenience
2197         function addSummaryAndSyntheticFormattersForRawBitmaskType.
2198
2199         (WTFOptionSetProvider.has_children): Deleted.
2200         (WTFOptionSetProvider.num_children): Deleted.
2201         (WTFOptionSetProvider.get_child_index): Deleted.
2202         (WTFOptionSetProvider.get_child_at_index): Deleted.
2203         (WTFOptionSetProvider.update): Deleted.
2204
2205 2019-01-04  Aakash Jain  <aakash_jain@apple.com>
2206
2207         [ews-build] Add build step to validate the patch before processing it
2208         https://bugs.webkit.org/show_bug.cgi?id=193140
2209
2210         Reviewed by Lucas Forschler.
2211
2212         * BuildSlaveSupport/ews-build/factories.py:
2213         (Factory.__init__): Added ValidatePatch step.
2214         * BuildSlaveSupport/ews-build/steps.py:
2215         (ValidatePatch):
2216         (ValidatePatch.fetch_data_from_url): Fetch data from a url.
2217         (ValidatePatch.get_patch_json): Get patch json data.
2218         (ValidatePatch.get_bug_json): Get bug json data.
2219         (ValidatePatch.get_bug_id_from_patch): Get bug id from a patch id.
2220         (ValidatePatch._is_patch_obsolete): Check if the patch is obsolete.
2221         (ValidatePatch._is_patch_review_denied): Check if the patch is marked r-.
2222         (ValidatePatch._is_bug_closed): Check if the bug is already closed.
2223         (ValidatePatch.skip_build): Skip the build.
2224         (ValidatePatch.start):
2225
2226 2019-01-04  Alex Christensen  <achristensen@webkit.org>
2227
2228         Progress towards fixing Mac CMake build
2229         https://bugs.webkit.org/show_bug.cgi?id=193105
2230
2231         Reviewed by Don Olmstead.
2232
2233         * TestWebKitAPI/PlatformMac.cmake:
2234
2235 2019-01-04  Alex Christensen  <achristensen@webkit.org>
2236
2237         Fix API test after r239631
2238         https://bugs.webkit.org/show_bug.cgi?id=193118
2239
2240         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
2241         (TestWebKitAPI::TEST):
2242         This test relied on m_maximumProcessCount being set to 1 in ProcessPoolConfiguration::createWithLegacyOptions.
2243         Do the same thing via the API to fix the test.
2244
2245 2019-01-04  Jer Noble  <jer.noble@apple.com>
2246
2247         [WebKitLegacy] Media playback pauses on scroll
2248         https://bugs.webkit.org/show_bug.cgi?id=192829
2249
2250         Reviewed by Eric Carlson.
2251
2252         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2253         * TestWebKitAPI/Tests/WebKitCocoa/StopSuspendResumeAllMedia.mm: Added.
2254         (TestWebKitAPI::TEST):
2255         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm: Added.
2256         (-[ScrollingDoesNotPauseMediaDelegate webViewDidFinishLoad:]):
2257         (-[ScrollingDoesNotPauseMediaDelegate uiWebView:didCommitLoadForFrame:]):
2258         (-[ScrollingDoesNotPauseMediaDelegate handleEvent:]):
2259         (TestWebKitAPI::TEST):
2260
2261 2019-01-04  Chris Dumez  <cdumez@apple.com>
2262
2263         Add support for toggling device orientation API support per site
2264         https://bugs.webkit.org/show_bug.cgi?id=193143
2265         <rdar://problem/46605724>
2266
2267         Reviewed by Alex Christensen.
2268
2269         Add API test coverage.
2270
2271         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2272         (-[DataMappingSchemeHandler setTaskHandler:]):
2273         (-[DataMappingSchemeHandler webView:startURLSchemeTask:]):
2274         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationEventEnabled:]):
2275         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2276         (-[WebsitePoliciesDeviceOrientationDelegate webView:didFinishNavigation:]):
2277
2278 2019-01-04  Aakash Jain  <aakash_jain@apple.com>
2279
2280         [ews-build] use svn-apply script to apply the patches
2281         https://bugs.webkit.org/show_bug.cgi?id=193138
2282
2283         Reviewed by Lucas Forschler.
2284
2285         * BuildSlaveSupport/ews-build/factories.py:
2286         (Factory.__init__): Add the ApplyPatch step.
2287         * BuildSlaveSupport/ews-build/steps.py:
2288         (CheckOutSource): Added step name.
2289         (CheckOutSource.__init__): Used alwaysUseLatest so that it doesn't apply patch.
2290         (ApplyPatch): Build step to apply patch using svn-apply script.
2291         (UnApplyPatchIfRequired):
2292         (UnApplyPatchIfRequired.__init__): Deleted, since the alwaysUseLatest parameter is now in base class.
2293
2294 2019-01-04  Alex Christensen  <achristensen@webkit.org>
2295
2296         Deprecate WKContextCreate
2297         https://bugs.webkit.org/show_bug.cgi?id=193118
2298
2299         Reviewed by Brady Eidson.
2300
2301         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2302         (WebKitBrowserWindow::WebKitBrowserWindow):
2303         * TestWebKitAPI/Tests/WebKit/AboutBlankLoad.cpp:
2304         (TestWebKitAPI::TEST):
2305         * TestWebKitAPI/Tests/WebKit/CloseFromWithinCreatePage.cpp:
2306         (TestWebKitAPI::TEST):
2307         * TestWebKitAPI/Tests/WebKit/CloseThenTerminate.cpp:
2308         (TestWebKitAPI::TEST):
2309         * TestWebKitAPI/Tests/WebKit/CookieManager.cpp:
2310         (TestWebKitAPI::TEST):
2311         * TestWebKitAPI/Tests/WebKit/DownloadDecideDestinationCrash.cpp:
2312         (TestWebKitAPI::TEST):
2313         * TestWebKitAPI/Tests/WebKit/EnumerateMediaDevices.cpp:
2314         (TestWebKitAPI::TEST):
2315         * TestWebKitAPI/Tests/WebKit/EphemeralSessionPushStateNoHistoryCallback.cpp:
2316         (TestWebKitAPI::TEST):
2317         * TestWebKitAPI/Tests/WebKit/EvaluateJavaScript.cpp:
2318         (TestWebKitAPI::TEST):
2319         * TestWebKitAPI/Tests/WebKit/EventModifiers.cpp:
2320         (TestWebKitAPI::TEST):
2321         * TestWebKitAPI/Tests/WebKit/FailedLoad.cpp:
2322         (TestWebKitAPI::TEST):
2323         * TestWebKitAPI/Tests/WebKit/Find.cpp:
2324         (TestWebKitAPI::TEST):
2325         * TestWebKitAPI/Tests/WebKit/FindMatches.mm:
2326         (TestWebKitAPI::TEST):
2327         * TestWebKitAPI/Tests/WebKit/ForceRepaint.cpp:
2328         (TestWebKitAPI::TEST):
2329         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp:
2330         (TestWebKitAPI::TEST):
2331         * TestWebKitAPI/Tests/WebKit/FrameMIMETypeHTML.cpp:
2332         (TestWebKitAPI::TEST):
2333         * TestWebKitAPI/Tests/WebKit/FrameMIMETypePNG.cpp:
2334         (TestWebKitAPI::TEST):
2335         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
2336         (TestWebKitAPI::TEST):
2337         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
2338         (TestWebKitAPI::TEST):
2339         * TestWebKitAPI/Tests/WebKit/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
2340         (TestWebKitAPI::loadAlternateHTMLString):
2341         * TestWebKitAPI/Tests/WebKit/LoadPageOnCrash.cpp:
2342         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
2343         * TestWebKitAPI/Tests/WebKit/MenuTypesForMouseEvents.cpp:
2344         (TestWebKitAPI::buildAndPerformTest):
2345         * TestWebKitAPI/Tests/WebKit/ModalAlertsSPI.cpp:
2346         (TestWebKitAPI::TEST):
2347         * TestWebKitAPI/Tests/WebKit/NavigationClientDefaultCrypto.cpp:
2348         (TestWebKitAPI::TEST):
2349         * TestWebKitAPI/Tests/WebKit/PageGroup.cpp:
2350         (TestWebKitAPI::TEST):
2351         * TestWebKitAPI/Tests/WebKit/PageLoadBasic.cpp:
2352         (TestWebKitAPI::TEST):
2353         * TestWebKitAPI/Tests/WebKit/PageLoadDidChangeLocationWithinPageForFrame.cpp:
2354         (TestWebKitAPI::TEST):
2355         * TestWebKitAPI/Tests/WebKit/PendingAPIRequestURL.cpp:
2356         (TestWebKitAPI::TEST):
2357         * TestWebKitAPI/Tests/WebKit/PreventEmptyUserAgent.cpp:
2358         (TestWebKitAPI::TEST):
2359         * TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp:
2360         (TestWebKitAPI::TEST):
2361         * TestWebKitAPI/Tests/WebKit/ProcessDidTerminate.cpp:
2362         (TestWebKitAPI::TEST):
2363         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
2364         (TestWebKitAPI::TEST):
2365         * TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:
2366         (TestWebKitAPI::TEST):
2367         * TestWebKitAPI/Tests/WebKit/ResizeWindowAfterCrash.cpp:
2368         (TestWebKitAPI::TEST):
2369         * TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp:
2370         (TestWebKitAPI::TEST):
2371         * TestWebKitAPI/Tests/WebKit/RestoreSessionStateContainingFormData.cpp:
2372         (TestWebKitAPI::TEST):
2373         * TestWebKitAPI/Tests/WebKit/ScrollPinningBehaviors.cpp:
2374         (TestWebKitAPI::TEST):
2375         * TestWebKitAPI/Tests/WebKit/ShouldKeepCurrentBackForwardListItemInList.cpp:
2376         (TestWebKitAPI::TEST):
2377         * TestWebKitAPI/Tests/WebKit/TerminateTwice.cpp:
2378         (TestWebKitAPI::TEST):
2379         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
2380         (TestWebKitAPI::TEST):
2381         * TestWebKitAPI/Tests/WebKit/WKPageConfiguration.cpp:
2382         (TestWebKitAPI::TEST):
2383         * TestWebKitAPI/Tests/WebKit/WKPageCopySessionStateWithFiltering.cpp:
2384         (TestWebKitAPI::TEST):
2385         * TestWebKitAPI/Tests/WebKit/WKPageGetScaleFactorNotZero.cpp:
2386         (TestWebKitAPI::TEST):
2387         * TestWebKitAPI/Tests/WebKit/WKPageIsPlayingAudio.cpp:
2388         (TestWebKitAPI::TEST):
2389         * TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm:
2390         (TestWebKitAPI::TEST):
2391         * TestWebKitAPI/Tests/WebKit/WebCoreStatisticsWithNoWebProcess.cpp:
2392         (TestWebKitAPI::TEST):
2393         * TestWebKitAPI/Tests/WebKit/mac/GetPIDAfterAbortedProcessLaunch.cpp:
2394         (TestWebKitAPI::TEST):
2395         * TestWebKitAPI/Tests/WebKit/mac/RestoreStateAfterTermination.mm:
2396         (TestWebKitAPI::TEST):
2397         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
2398         (WebKit2_CommandBackForwardTestWKView::SetUp):
2399         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
2400         (TestWebKitAPI::TEST):
2401         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
2402         (TestWebKitAPI::TEST):
2403         * TestWebKitAPI/Tests/WebKitCocoa/SchemeRegistry.mm:
2404         (TestWebKitAPI::TEST):
2405         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
2406         (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):
2407
2408 2019-01-03  Matt Rajca  <mrajca@apple.com>
2409
2410         Make DidPlayMediaPreventedFromPlaying autoplay event more generic.
2411         https://bugs.webkit.org/show_bug.cgi?id=193128
2412         rdar://34554231
2413
2414         Reviewed by Jer Noble.
2415
2416         Today, the "DidPlayMediaPreventedFromPlaying" autoplay event is only sent for
2417         media prevented from autoplaying. It could be generalized to a "DidPlayMediaWithUserGesture"
2418         event along with a flag that indicates whether or not autoplay was actually prevented.
2419
2420         Tests: existing API tests were updated to reflect the new names. New API tests
2421         were added for the new case in which the "DidPlayMediaWithUserGesture" event is sent.
2422
2423         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2424         * TestWebKitAPI/Tests/WebKit/long-test.mp4: Added.
2425         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2426         (TEST):
2427         * TestWebKitAPI/Tests/WebKitCocoa/audio-with-play-button.html: Added.
2428         * TestWebKitAPI/Tests/WebKitCocoa/video-with-play-button.html: Added.
2429
2430 2019-01-04  Chris Dumez  <cdumez@apple.com>
2431
2432         [PSON] Calling history.back() from inside the load event handler prevents process-swapping
2433         https://bugs.webkit.org/show_bug.cgi?id=193120
2434
2435         Reviewed by Alex Christensen.
2436
2437         Add API test coverage.
2438
2439         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2440
2441 2019-01-04  Chris Dumez  <cdumez@apple.com>
2442
2443         Crash under WebProcessPool::addSuspendedPage()
2444         https://bugs.webkit.org/show_bug.cgi?id=193110
2445
2446         Reviewed by Youenn Fablet.
2447
2448         Add API test coverage.
2449
2450         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2451
2452 2019-01-04  Aakash Jain  <aakash_jain@apple.com>
2453
2454         [ews-build] Check patch relevance before applying the patch
2455         https://bugs.webkit.org/show_bug.cgi?id=193102
2456
2457         Reviewed by Lucas Forschler.
2458
2459         * BuildSlaveSupport/ews-build/factories.py:
2460         (Factory.__init__): Moved CheckPatchRelevance step to base class.
2461
2462 2019-01-04  Aakash Jain  <aakash_jain@apple.com>
2463
2464         [ews-build] Check patch relevance step should print patch id
2465         https://bugs.webkit.org/show_bug.cgi?id=193137
2466
2467         Reviewed by Lucas Forschler.
2468
2469         * BuildSlaveSupport/ews-build/steps.py:
2470         (CheckPatchRelevance.start): Update the status to include patch id.
2471
2472 2019-01-04  Jonathan Bedard  <jbedard@apple.com>
2473
2474         webkitpy: Increase simulator teardown timeout
2475         https://bugs.webkit.org/show_bug.cgi?id=193141
2476         <rdar://problem/46174217>
2477
2478         Rubber-stamped by Aakash Jain.
2479
2480         * Scripts/webkitpy/xcode/simulated_device.py:
2481         (SimulatedDeviceManager.tear_down): Use SIMULATOR_BOOT_TIMEOUT.
2482
2483 2019-01-03  Ross Kirsling  <ross.kirsling@sony.com>
2484
2485         test262-runner misbehaves when test file YAML has a trailing space
2486         https://bugs.webkit.org/show_bug.cgi?id=193053
2487
2488         Reviewed by Yusuke Suzuki.
2489
2490         * Scripts/test262/Runner.pm:
2491         (parseData):
2492         Accept trailing space when parsing a test file's YAML block.
2493
2494 2019-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
2495
2496         UserMedia test should use WKPageNavigationClient
2497         https://bugs.webkit.org/show_bug.cgi?id=192913
2498
2499         Reviewed by Youenn Fablet.
2500
2501         The test currently uses the deprecated WKPageLoaderClient. It should use
2502         WKPageNavigationClient instead, which provides the same callback under a similar name.
2503
2504         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
2505         (TestWebKitAPI::TEST):
2506
2507 2019-01-02  Alex Christensen  <achristensen@webkit.org>
2508
2509         Homograph with LATIN SMALL LETTER R WITH FISHHOOK
2510         https://bugs.webkit.org/show_bug.cgi?id=192944
2511
2512         Reviewed by Tim Horton.
2513
2514         * TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm:
2515         (TestWebKitAPI::TEST):
2516
2517 2019-01-02  Wenson Hsieh  <wenson_hsieh@apple.com>
2518
2519         Add support for using the current text selection as the find string on iOS
2520         https://bugs.webkit.org/show_bug.cgi?id=193034
2521         <rdar://problem/45138739>
2522
2523         Reviewed by Tim Horton.
2524
2525         Add a new API test to verify that the new WebKit SPI (_stringForFind, _takeFindStringFromSelection:, and
2526         _setStringForFind) works as expected.
2527
2528         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2529         * TestWebKitAPI/Tests/WebKitCocoa/UseSelectionAsFindString.mm: Added.
2530
2531 2019-01-02  Aakash Jain  <aakash_jain@apple.com>
2532
2533         [ews-build] Use git on OpenSource EWS bots
2534         https://bugs.webkit.org/show_bug.cgi?id=193092
2535
2536         Reviewed by Lucas Forschler.
2537
2538         * BuildSlaveSupport/ews-build/steps.py:
2539         (CheckOutSource): Use git instead of svn.
2540         (CheckOutSource.__init__): Use timeout of 2 hours since the initial checkout might take a long time.
2541
2542 2019-01-02  Daniel Bates  <dabates@apple.com>
2543
2544         [lldb-webkit] Remove broken code to print WTF::OptionSet::m_storage
2545         https://bugs.webkit.org/show_bug.cgi?id=193023
2546
2547         Reviewed by Simon Fraser.
2548
2549         The code to print WTF::OptionSet::m_storage as an item in the set never worked and does
2550         not seem meaningful to fix because WTF::OptionSet::m_storage is just the sum of the printed
2551         enumerator values. We should just remove this code.
2552
2553         * lldb/lldb_webkit.py:
2554         (WTFOptionSetProvider.has_children):
2555         (WTFOptionSetProvider.num_children):
2556         (WTFOptionSetProvider.get_child_index):
2557         (WTFOptionSetProvider.get_child_at_index):
2558
2559 2018-12-29  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
2560
2561         .ycm_extra_conf.py should handle XXXInlines.h
2562         https://bugs.webkit.org/show_bug.cgi?id=193055
2563
2564         Reviewed by Carlos Garcia Campos.
2565
2566         compile_commands.json database only records flags and options for cpp source files.
2567         So, when we open headers, this database does not have any information for that.
2568         Our .ycm_extra_conf.py alleviates this by using XXX.cpp's configuration for XXX.h.
2569         But this mitigation does not handle XXXInlines.h well since we do not have XXXInlines.cpp.
2570         This patch adds support for XXXInlines.h in .ycm_extra_conf.py. When XXXInlines.h is queried,
2571         we attempt to find XXX.cpp and use the configuration if it exists.
2572
2573         * gtk/ycm_extra_conf.py:
2574         (getImplementationFilename):
2575         (FlagsForFile):
2576
2577 2018-12-31  Carlos Garcia Campos  <cgarcia@igalia.com>
2578
2579         Unreviewed. Support PHP 7.3 in Debian.
2580
2581         Add 7.3 to the list of php versions supported in Debian.
2582
2583         * Scripts/webkitpy/port/base.py:
2584         (Port._debian_php_version):
2585
2586 2018-12-27  Alex Christensen  <achristensen@webkit.org>
2587
2588         Resurrect Mac CMake build
2589         https://bugs.webkit.org/show_bug.cgi?id=192658
2590
2591         Reviewed by Yusuke Suzuki.
2592
2593         * DumpRenderTree/PlatformMac.cmake:
2594         * MiniBrowser/mac/CMakeLists.txt:
2595         * TestWebKitAPI/PlatformMac.cmake:
2596
2597 2018-12-26  Adrian Perez de Castro  <aperez@igalia.com>
2598
2599         [Tools] Remove references to Bison and Flex
2600         https://bugs.webkit.org/show_bug.cgi?id=193033
2601
2602         Reviewed by Michael Catanzaro.
2603
2604         The Bison and Flex tools are not needed anymore since r209883.
2605
2606         * CygwinDownloader/cygwin-downloader.py:
2607         * EWSTools/ubuntu-ews-packages:
2608         * Scripts/filter-build-webkit:
2609         (shouldIgnoreLine):
2610         * gtk/install-dependencies:
2611         * wpe/install-dependencies:
2612
2613 2018-12-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2614
2615         WebDriver: warn about non existing tests when parsing expectations
2616         https://bugs.webkit.org/show_bug.cgi?id=192979
2617
2618         Reviewed by Michael Catanzaro.
2619
2620         It's common to update web driver tests and forget updating the test expectations in case of tests removed or
2621         renamed.
2622
2623         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
2624         (WebDriverTestRunner.__init__):
2625
2626 2018-12-21  Chris Dumez  <cdumez@apple.com>
2627
2628         navigator.userAgent in service workers does not reflect customUserAgent set by client
2629         https://bugs.webkit.org/show_bug.cgi?id=192951
2630
2631         Reviewed by Youenn Fablet.
2632
2633         Extend API test coverage.
2634
2635         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2636         (-[SWCustomUserAgentDelegate initWithUserAgent:]):
2637         (-[SWCustomUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2638         (-[SWUserAgentMessageHandler initWithExpectedMessage:]):
2639         (-[SWUserAgentMessageHandler userContentController:didReceiveScriptMessage:]):
2640
2641 2018-12-21  Jiewen Tan  <jiewen_tan@apple.com>
2642
2643         [WebAuthN] userPresence should always be true
2644         https://bugs.webkit.org/show_bug.cgi?id=192835
2645         <rdar://problem/46538788>
2646
2647         Reviewed by Brent Fulgham.
2648
2649         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
2650         (TestWebKitAPI::TEST):
2651
2652 2018-12-19  Simon Fraser  <simon.fraser@apple.com>
2653
2654         Add support to run-benchmark to use non-default copies of the browser apps
2655         https://bugs.webkit.org/show_bug.cgi?id=192905
2656         rdar://problem/46845840
2657
2658         Reviewed by Dewei Zhu.
2659         
2660         Add support for a --browser-path argument to run-benchmark, which allows you to use
2661         a custom app bundle for a given browser (only implemented for Safari at present).
2662
2663         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2664         (BenchmarkRunner.__init__):
2665         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
2666         (BrowserDriver.__init__):
2667         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py:
2668         (BrowserDriverFactory.create):
2669         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
2670         (OSXBrowserDriver._launch_process):
2671         (OSXBrowserDriver._launch_process_with_caffeinate): Fix spelling.
2672         (OSXBrowserDriver._launch_process_with_caffinate): Deleted.
2673         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
2674         (OSXChromeCanaryDriver.launch_url):
2675         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
2676         (OSXFirefoxNightlyDriver.launch_url):
2677         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
2678         (OSXSafariDriver.__init__):
2679         (OSXSafariDriver.launch_url):
2680         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
2681         (parse_args):
2682         (run_benchmark_plan):
2683         * Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py:
2684         (WebServerBenchmarkRunner.__init__):
2685         * Scripts/webkitpy/browserperfdash/browserperfdash_unittest.py:
2686         (FakeBenchmarkRunner.__init__):
2687
2688 2018-12-21  Jiewen Tan  <jiewen_tan@apple.com>
2689
2690         [WebAuthN] Import an APDU coder from Chromium
2691         https://bugs.webkit.org/show_bug.cgi?id=192949
2692         <rdar://problem/46879933>
2693
2694         Reviewed by Brent Fulgham.
2695
2696         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2697         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp: Added.
2698         (TestWebKitAPI::TEST):
2699
2700 2018-12-21  Wenson Hsieh  <wenson_hsieh@apple.com>
2701
2702         Setting the file wrapper and content type of an attachment to a PDF should update its image
2703         https://bugs.webkit.org/show_bug.cgi?id=192984
2704         <rdar://problem/46798028>
2705
2706         Reviewed by Tim Horton.
2707
2708         Add an API test to verify that setting the file wrapper for a _WKAttachment with an enclosing image element with
2709         PDF data correctly updates the image element.
2710
2711         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2712
2713 2018-12-21  Michael Catanzaro  <mcatanzaro@igalia.com>
2714
2715         Add JSCOnly to bot dashboard
2716         https://bugs.webkit.org/show_bug.cgi?id=192964
2717
2718         Reviewed by Alexey Proskuryakov.
2719
2720         Apparently we have five JSCOnly test bots and multiple developers working on keeping them in
2721         good shape. Sadly, they are hidden bots not exposed in the dashboard. They would be more
2722         useful if they were not so secret, so add them.
2723
2724         There appear to be no build-only bots, so the first column is blank. And of course there are
2725         no WebKit1 or WebKit2 bots, because this is JSCOnly, so the second and third columns are
2726         blank too. That's OK. This will be the last bot on the dashboard, so it won't look too bad,
2727         and there's plenty of room in the final column for all the bots.
2728
2729         I had a hard time picking a logo to use, because the JavaScript language does not have an
2730         official logo. But I believe I've found one that will be satisfactory.
2731
2732         I will sneak in one bonus change: WPE's EWS queue was missing, and has been added.
2733
2734         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/SquirrelFish.png: Added.
2735         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/SquirrelFish@2x.png: Added.
2736         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2737         (BubbleQueueServer):
2738         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2739         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2740         (WebKitBuildbot):
2741         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2742         (table.queue-grid tr.platform.linux-jsconly img.logo):
2743
2744 2018-12-21  Benjamin Poulain  <benjamin@webkit.org>
2745
2746         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
2747         https://bugs.webkit.org/show_bug.cgi?id=192821
2748
2749         Reviewed by Chris Dumez.
2750
2751         * DumpRenderTree/mac/DumpRenderTree.mm:
2752         (createWebViewAndOffscreenWindow):
2753         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
2754
2755 2018-12-20  Fujii Hironori  <Hironori.Fujii@sony.com>
2756
2757         [Win][Clang] Fix compilation warnings of DumpRenderTree
2758         https://bugs.webkit.org/show_bug.cgi?id=192924
2759
2760         Reviewed by Alex Christensen.
2761
2762         * DumpRenderTree/AccessibilityController.h: Added member variable initializations in the class definition.
2763         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2764         (AccessibilityController::AccessibilityController): Moved member variable initializations to the class definition.
2765         * DumpRenderTree/win/DumpRenderTree.cpp:
2766         (dumpHistoryItem): String literals can't be converted non-const type. Use auto for them.
2767         (resetWebPreferencesToConsistentValues): Pass a temporal _bstr_t
2768         object to the argument of setDefaultTextEncodingName instead of a
2769         const string literal.
2770         (createWebViewAndOffscreenWindow): Use %lx for HRESULT (aka 'long').
2771         (main): Exit if _dup2 fails. Use %lu for'DWORD'(aka 'unsigned long').
2772         (setCacheFolder): Deleted.
2773         * DumpRenderTree/win/DumpRenderTreeWin.h: Fix class/struct mismatch of FrameLoadDelegate and PolicyDelegate declarations.
2774         * DumpRenderTree/win/EditingDelegate.cpp:
2775         (dump): Use %d for int.
2776         * DumpRenderTree/win/FrameLoadDelegate.cpp: Removed unused variable g_delegateWaitingOnTimer.
2777         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
2778         (BSTRFromString): Deleted unused function.
2779         * DumpRenderTree/win/TestRunnerWin.cpp:
2780         (TestRunner::setDatabaseQuota): Pass a temporal _bstr_t object to
2781         the arguemnt of setQuota instead of const string literal.
2782         * DumpRenderTree/win/WorkQueueItemWin.cpp:
2783         (jsStringRefToWString): Deleted unused function.
2784
2785 2018-12-20  Chris Dumez  <cdumez@apple.com>
2786
2787         Add API test coverage for customUserAgent client setting and service workers
2788         https://bugs.webkit.org/show_bug.cgi?id=192952
2789
2790         Reviewed by Alex Christensen.
2791
2792         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2793         (-[SWMessageHandler userContentController:didReceiveScriptMessage:]):
2794         (-[SWSchemes webView:startURLSchemeTask:]):
2795         (-[SWCustomUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2796         (-[SWUserAgentMessageHandler userContentController:didReceiveScriptMessage:]):
2797
2798 2018-12-20  Chris Dumez  <cdumez@apple.com>
2799
2800         Use Optional::hasValue() instead of Optional::has_value()
2801         https://bugs.webkit.org/show_bug.cgi?id=192948
2802
2803         Reviewed by Tim Horton.
2804
2805         * TestWebKitAPI/Tests/WebCore/CBORReaderTest.cpp:
2806         (TestWebKitAPI::TEST):
2807         * TestWebKitAPI/Tests/WebCore/CBORWriterTest.cpp:
2808         (TestWebKitAPI::TEST):
2809         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp:
2810         (TestWebKitAPI::TEST_F):
2811
2812 2018-12-20  Chris Dumez  <cdumez@apple.com>
2813
2814         Add style script rule to check for uses of std::optional<>
2815         https://bugs.webkit.org/show_bug.cgi?id=192931
2816
2817         Reviewed by Tim Horton.
2818
2819         * Scripts/webkitpy/style/checkers/cpp.py:
2820         (check_wtf_optional):
2821         (check_style):
2822
2823 2018-12-20  Jiewen Tan  <jiewen_tan@apple.com>
2824
2825         [WebAuthN] Add a runtime flag for local authenticator
2826         https://bugs.webkit.org/show_bug.cgi?id=192792
2827         <rdar://problem/46798738>
2828
2829         Reviewed by Brent Fulgham.
2830
2831         * DumpRenderTree/TestOptions.cpp:
2832         (TestOptions::TestOptions):
2833         * DumpRenderTree/TestOptions.h:
2834         * DumpRenderTree/mac/DumpRenderTree.mm:
2835         (enableExperimentalFeatures):
2836         (setWebPreferencesForTestOptions):
2837         * WebKitTestRunner/TestController.cpp:
2838         (WTR::TestController::resetPreferencesToConsistentValues):
2839         (WTR::updateTestOptionsFromTestHeader):
2840         * WebKitTestRunner/TestOptions.h:
2841         (WTR::TestOptions::hasSameInitializationOptions const):
2842
2843 2018-12-20  Jonathan Bedard  <jbedard@apple.com>
2844
2845         webkitpy: Autoinstall package URLs have changed
2846         https://bugs.webkit.org/show_bug.cgi?id=192909
2847         <rdar://problem/46860359>
2848
2849         Rubber-stamped by Alexey Proskuryakov.
2850
2851         PyPi urls have been moved around, we need to update our auto-installed packages.
2852
2853         We should check for Selenium before asking PyPi for the latest version.
2854
2855         * Scripts/webkitpy/thirdparty/__init__.py:
2856         (AutoinstallImportHook._install_mechanize): Update with new pypi url.
2857         (AutoinstallImportHook._install_keyring): Ditto.
2858         (AutoinstallImportHook._install_pep8): Ditto.
2859         (AutoinstallImportHook._install_mozlog): Ditto.
2860         (AutoinstallImportHook._install_mozprocess): Ditto.
2861         (AutoinstallImportHook._install_pytest_timeout): Ditto.
2862         (AutoinstallImportHook._install_pytest): Ditto.
2863         (AutoinstallImportHook._install_pylint): Ditto.
2864         (AutoinstallImportHook._install_buildbot): Ditto.
2865         (AutoinstallImportHook._install_coverage): Ditto.
2866         (AutoinstallImportHook._install_twisted_15_5_0): Ditto.
2867         (AutoinstallImportHook._install_selenium): Update with new pypi url, only check
2868         for new Selenium if the installed version isn't sufficient.
2869         (AutoinstallImportHook.get_latest_pypi_url): Update with new pypi url.
2870
2871 2018-12-20  Chris Dumez  <cdumez@apple.com>
2872
2873         Use Optional::valueOr() instead of Optional::value_or()
2874         https://bugs.webkit.org/show_bug.cgi?id=192933
2875
2876         Reviewed by Geoffrey Garen.
2877
2878         * TestWebKitAPI/Tests/WTF/URLParser.cpp:
2879         (TestWebKitAPI::checkURL):
2880         (TestWebKitAPI::checkRelativeURL):
2881         (TestWebKitAPI::checkURLDifferences):
2882         (TestWebKitAPI::checkRelativeURLDifferences):
2883         * TestWebKitAPI/Tests/WebCore/URLParserTextEncoding.cpp:
2884         (TestWebKitAPI::checkURL):
2885
2886 2018-12-20  Ryan Haddad  <ryanhaddad@apple.com>
2887
2888         Unreviewed, rolling out r239417.
2889
2890         Introduced two API test failures on macOS.
2891
2892         Reverted changeset:
2893
2894         "<rdar://problem/46194315> macOS: WebKit1 does not handle
2895         occlusion changes"
2896         https://bugs.webkit.org/show_bug.cgi?id=192821
2897         https://trac.webkit.org/changeset/239417
2898
2899 2018-12-20  Devin Rousso  <drousso@apple.com>
2900
2901         Web Inspector: UIString should take an optional key and description to aid localization
2902         https://bugs.webkit.org/show_bug.cgi?id=153962
2903         <rdar://problem/24542505>
2904
2905         Reviewed by Brian Burg.
2906
2907         * Scripts/extract-localizable-js-strings:
2908
2909 2018-12-20  Tim Horton  <timothy_horton@apple.com>
2910
2911         Unparented WKWebView can't retrieve main resource data for a main frame plugin
2912         https://bugs.webkit.org/show_bug.cgi?id=192923
2913         <rdar://problem/46859068>
2914
2915         Reviewed by Wenson Hsieh.
2916
2917         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2918         * TestWebKitAPI/WebKitCocoa/GetResourceData.mm:
2919         Add a test ensuring that both parented and unparented WKWebViews can
2920         retrieve main resource data when loading a PDF.
2921
2922 2018-12-20  Carlos Garcia Campos  <cgarcia@igalia.com>
2923
2924         [GTK][WPE] Bump webkitgtk-test-fonts to 0.0.8
2925         https://bugs.webkit.org/show_bug.cgi?id=192852
2926
2927         Reviewed by Michael Catanzaro.
2928
2929         EmojiOne font was replaced by Noto Color Emoji.
2930
2931         * WebKitTestRunner/gtk/fonts/fonts.conf: Use Noto Color Emoji when Apple Color Emoji font family is used in tests.
2932         * gtk/jhbuild.modules:
2933         * wpe/jhbuild.modules:
2934
2935 2018-12-19  Chris Dumez  <cdumez@apple.com>
2936
2937         wtf/Optional.h: move-constructor and move-assignment operator should disengage the value being moved from
2938         https://bugs.webkit.org/show_bug.cgi?id=192728
2939         <rdar://problem/46746779>
2940
2941         Reviewed by Geoff Garen.
2942
2943         * DumpRenderTree/*:
2944         * MiniBrowser/*:
2945         * TestRunnerShared/*:
2946         * TestWebKitAPI/*:
2947         * WebGPUAPIStructure/*:
2948         * WebKitTestRunner/*:
2949
2950 2018-12-19  Benjamin Poulain  <benjamin@webkit.org>
2951
2952         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
2953         https://bugs.webkit.org/show_bug.cgi?id=192821
2954
2955         Reviewed by Chris Dumez.
2956
2957         * DumpRenderTree/mac/DumpRenderTree.mm:
2958         (createWebViewAndOffscreenWindow):
2959
2960 2018-12-19  Alex Christensen  <achristensen@webkit.org>
2961
2962         Navigations away from the SafeBrowsing interstitial show a flash of old content
2963         https://bugs.webkit.org/show_bug.cgi?id=192676
2964
2965         Reviewed by Chris Dumez.
2966
2967         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2968         (safeBrowsingView):
2969         (TEST):
2970         (-[SafeBrowsingHelper webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]): Deleted.
2971
2972 2018-12-19  Adrian Perez de Castro  <aperez@igalia.com>
2973
2974         [GTK][WPE] Unify TestController::platformRunUntil() and honor condition flag
2975         https://bugs.webkit.org/show_bug.cgi?id=192855
2976
2977         Reviewed by Michael Catanzaro.
2978
2979         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2980         (WTR::TestController::notifyDone): Use the WPE implementation.
2981         (WTR::TestController::platformRunUntil): Use the WPE implementation.
2982         * WebKitTestRunner/wpe/TestControllerWPE.cpp:
2983         (WTR::TestController::platformRunUntil): Honor the condition flag.
2984
2985 2018-12-19  Megan Gardner  <megan_gardner@apple.com>
2986
2987         Allow clients to set the navigator platform
2988         https://bugs.webkit.org/show_bug.cgi?id=192735
2989
2990         Reviewed by Tim Horton.
2991
2992         Add a test for setting a custom navigator platform.
2993
2994         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2995         (-[CustomNavigatorPlatformDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2996         (-[CustomNavigatorPlatformDelegate webView:didFinishNavigation:]):
2997
2998 2018-12-19  Truitt Savell  <tsavell@apple.com>
2999
3000         Unreviewed, rolling out r239358.
3001
3002         Revision caused imported/w3c/web-platform-tests/IndexedDB/ to
3003         crash on Debug bots
3004
3005         Reverted changeset:
3006
3007         "Clean up IndexedDB files between tests"
3008         https://bugs.webkit.org/show_bug.cgi?id=192796
3009         https://trac.webkit.org/changeset/239358
3010
3011 2018-12-18  Wenson Hsieh  <wenson_hsieh@apple.com>
3012
3013         [iOS] A copied text selection is pasted as a web archive attachment in the entry view in Messages
3014         https://bugs.webkit.org/show_bug.cgi?id=192842
3015         <rdar://problem/46823586>
3016
3017         Reviewed by Tim Horton.
3018
3019         Adjusts an existing API test to verify that "com.apple.webarchive" is not one of the types registered to the
3020         item provider when dragging a rich text selection.
3021
3022         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3023
3024 2018-12-18  David Quesada  <david_quesada@apple.com>
3025
3026         REGRESSION: [iOS] API test TestWebKitAPI._WKDownload.OriginatingWebView is a flaky failure
3027         https://bugs.webkit.org/show_bug.cgi?id=192810
3028         <rdar://problem/46812536>
3029
3030         Reviewed by Alex Christensen.
3031
3032         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3033         (-[OriginatingWebViewDownloadDelegate _downloadDidStart:]):
3034             After releasing our reference to the web view, wait until the next turn of the runloop
3035             before checking that the originatingWebView has been zeroed, since the web view might
3036             still be referenced in the autorelease pool. This _WKDownload unit test isn't about
3037             testing general memory management of WKWebViews, only that _WKDownload does not retain
3038             its web view via the 'originatingWebView' property.
3039
3040 2018-12-18  Sihui Liu  <sihui_liu@apple.com>
3041
3042         Clean up IndexedDB files between tests
3043         https://bugs.webkit.org/show_bug.cgi?id=192796
3044
3045         Reviewed by Geoffrey Garen.
3046
3047         * DumpRenderTree/mac/DumpRenderTree.mm:
3048         (runTest):
3049         * WebKitTestRunner/TestController.cpp:
3050         (WTR::TestController::resetStateToConsistentValues):
3051         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
3052         (WTR::RemoveAllIndexedDatabasesCallback):
3053         (WTR::TestController::ClearIndexedDatabases):
3054         * WebKitTestRunner/TestController.h:
3055
3056 2018-12-18  Alex Christensen  <achristensen@webkit.org>
3057
3058         Fix API test introduced in r239339 on iOS.
3059         https://bugs.webkit.org/show_bug.cgi?id=192675
3060
3061         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3062         (TEST):
3063         The iOS implementation of the safe browsing warning is a little different.
3064         It does some element creation when it is added to the window so it knows how big it is.
3065         To test these elements, we need to simulate adding it to the window.
3066         A similar technique is done in other iOS API tests, such as SafeBrowsing.ShowWarningSPI.
3067
3068 2018-12-18  Jonathan Bedard  <jbedard@apple.com>
3069
3070         webkitpy: Ignore device type for test when using --force
3071         https://bugs.webkit.org/show_bug.cgi?id=192786
3072         <rdar://problem/46794894>
3073
3074         Reviewed by Daniel Bates.
3075
3076         It is sometimes the case that a contributor will wish to run a test on a specific device,
3077         despite expectations which indicate a test should not be run on that device.
3078
3079         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3080         (parse_args):
3081         * Scripts/webkitpy/port/device_port.py:
3082         (DevicePort.default_child_processes): Strip device type information when using --force.
3083         (DevicePort.setup_test_run): Only allow incomplete match when using --force.
3084
3085 2018-12-18  Alex Christensen  <achristensen@webkit.org>
3086
3087         WKWebView has old URL while displaying SafeBrowsing interstitial, for link-click navigations
3088         https://bugs.webkit.org/show_bug.cgi?id=192675
3089
3090         Reviewed by Geoffrey Garen.
3091
3092         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3093         (goBack):
3094         (TEST):
3095         (visitUnsafeSite):
3096         (-[SafeBrowsingHelper observeValueForKeyPath:ofObject:change:context:]):
3097         (-[SafeBrowsingHelper webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3098
3099 2018-12-18  Chris Dumez  <cdumez@apple.com>
3100
3101         Regression(r239182) SuspendedPage's process reuse for link navigation optimization sometimes broken
3102         https://bugs.webkit.org/show_bug.cgi?id=192772
3103
3104         Reviewed by Antti Koivisto.
3105
3106         Add API test coverage.
3107
3108         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3109
3110 2018-12-18  Philippe Normand  <pnormand@igalia.com>
3111
3112         Unreviewed, JHBuild GTK build fix attempt
3113
3114         * gtk/jhbuild.modules: There's no libffi in this moduleset anymore.
3115         There's no ninja module either, it should be provided by the
3116         host system.
3117
3118 2018-12-17  Chris Dumez  <cdumez@apple.com>
3119
3120         Allow passing nil as session state to [WKWebView _restoreSessionState:]
3121         https://bugs.webkit.org/show_bug.cgi?id=192789
3122         <rdar://problem/46755277>
3123
3124         Reviewed by Alex Christensen.
3125
3126         Add API test coverage.
3127
3128         * TestWebKitAPI/Tests/WebKit/WKBackForwardList.mm:
3129         (TEST):
3130
3131 2018-12-17  Simon Fraser  <simon.fraser@apple.com>
3132
3133         Don't use more expensive layer backing store formats when subpixel text antialiasing is not enabled
3134         https://bugs.webkit.org/show_bug.cgi?id=192780
3135         rdar://problem/43394387
3136
3137         Reviewed by Tim Horton.
3138
3139         No need to set "AppleFontSmoothing" defaults for WK2.
3140
3141         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3142         (WTR::InjectedBundle::platformInitialize):
3143
3144 2018-12-17  Jonathan Bedard  <jbedard@apple.com>
3145
3146         webkitpy: Handle case where stdout and stderr don't accept unicode
3147         https://bugs.webkit.org/show_bug.cgi?id=192775
3148         <rdar://problem/46497303>
3149
3150         Reviewed by Stephanie Lewis.
3151
3152         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
3153         (MeteredStream.write): If unicode cannot be written to the stream, replace unicode
3154         characters with '?'.
3155         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
3156         (RegularTest.test_stream_with_encoding):
3157
3158 2018-12-17  Daniel Bates  <dabates@apple.com>
3159
3160         Support concatenating StringView with other string types
3161         https://bugs.webkit.org/show_bug.cgi?id=177566
3162
3163         Reviewed by Darin Adler.
3164
3165         Add some tests to ensure we do not regress the number of allocations needed when performing
3166         string concatenation with string views.
3167
3168         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
3169         (TestWebKitAPI::TEST):
3170
3171 2018-12-17  Commit Queue  <commit-queue@webkit.org>
3172
3173         Unreviewed, rolling out r239265 and r239274.
3174         https://bugs.webkit.org/show_bug.cgi?id=192765
3175
3176         unorm_normalize is deprecated, and broke an internal build
3177         (Requested by Truitt on #webkit).
3178
3179         Reverted changesets:
3180
3181         "[GTK][WPE] Need a function to convert internal URI to display
3182         ("pretty") URI"
3183         https://bugs.webkit.org/show_bug.cgi?id=174816
3184         https://trac.webkit.org/changeset/239265
3185
3186         "Fix the Apple Internal Mac build with a newer SDK"
3187         https://trac.webkit.org/changeset/239274
3188
3189 2018-12-17  Daniel Bates  <dabates@apple.com>
3190
3191         Implement UIScriptController::toggleCapsLock() for iOS
3192         https://bugs.webkit.org/show_bug.cgi?id=191815
3193
3194         Reviewed by Andy Estes.
3195
3196         Add support for toggling the caps lock state in WebKitTestRunner on iOS.
3197
3198         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3199         * WebKitTestRunner/TestController.cpp:
3200         (WTR::TestController::resetStateToConsistentValues): Clear the current modifier state
3201         before running a test. This ensures that the caps lock state does not persist between
3202         tests should a test enable caps lock and not disable it.
3203         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3204         (hidUsageCodeForCharacter): Map "capsLock" to the Caps Lock key usage code.
3205         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3206         (WTR::createUIPhysicalKeyboardEvent): Modified to take the keyboard input flags to use to
3207         create the event. Also substituted NSString* for const String& as the data type for the first
3208         two parameters to avoid conversions in the implementation of UIScriptController::toggleCapsLock()
3209         below.
3210         (WTR::UIScriptController::keyDown): Update as needed due to changes to prototype of createUIPhysicalKeyboardEvent().
3211         (WTR::UIScriptController::toggleCapsLock): Dispatch a UIEvent to toggle caps lock.
3212
3213 2018-12-17  Daniel Bates  <dabates@apple.com>
3214
3215         [iOS] Remove -[WebEvent initWithKeyEventType:...:characterSet:]
3216         https://bugs.webkit.org/show_bug.cgi?id=192633
3217
3218         Reviewed by Wenson Hsieh.
3219
3220         Update code to use the modern initializer.
3221
3222         * DumpRenderTree/mac/EventSendingController.mm:
3223         (-[EventSendingController keyDown:withModifiers:withLocation:]):
3224
3225 2018-12-17  Matt Lewis  <jlewis3@apple.com>
3226
3227         Unreviewed, rolling out r239254.
3228
3229         This broke the Windows 10 Debug build
3230
3231         Reverted changeset:
3232
3233         "Replace many uses of String::format with more type-safe
3234         alternatives"
3235         https://bugs.webkit.org/show_bug.cgi?id=192742
3236         https://trac.webkit.org/changeset/239254
3237
3238 2018-12-17  David Kilzer  <ddkilzer@apple.com>
3239
3240         clang-tidy: loop variable is copied but only used as const reference in WebCore, WebKit, Tools
3241         <https://webkit.org/b/192751>
3242         <rdar://problem/46771623>
3243
3244         Reviewed by Daniel Bates.
3245
3246         Change loop variables to const references to avoid unnecessary
3247         copies.
3248
3249         * DumpRenderTree/mac/DumpRenderTreePasteboard.mm:
3250         (-[LocalPasteboard pasteboardItems]):
3251
3252 2018-12-17  Ms2ger  <Ms2ger@igalia.com>
3253
3254         [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
3255         https://bugs.webkit.org/show_bug.cgi?id=174816
3256
3257         Reviewed by Michael Catanzaro.
3258
3259         Add tests for userVisibleString() and (for GTK and WPE) webkit_uri_for_display().
3260
3261         * TestWebKitAPI/CMakeLists.txt:
3262         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3263         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Added.
3264         (TestWebKitAPI::TEST):
3265         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
3266         (testURIForDisplayUnaffected):
3267         (testURIForDisplayAffected):
3268         (beforeAll):
3269         (afterAll):
3270         * TestWebKitAPI/glib/CMakeLists.txt:
3271
3272 2018-12-17  Carlos Garcia Campos  <cgarcia@igalia.com>
3273
3274         [WPE] Add API to notify about frame displayed view backend callback
3275         https://bugs.webkit.org/show_bug.cgi?id=192224
3276
3277         Reviewed by Michael Catanzaro.
3278
3279         Add a test case to check the new API.
3280
3281         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
3282         (testWebViewFrameDisplayed):
3283         (beforeAll):
3284         * wpe/jhbuild.modules: Bump WPEBackend-fdo to 1.1.0.
3285
3286 2018-12-16  Adrian Perez de Castro  <aperez@igalia.com>
3287
3288         Unreviewed build fix after r239253
3289
3290         * gtk/jhbuild.modules: Fix typo in libpsl dependency name.
3291
3292 2018-12-15  Darin Adler  <darin@apple.com>
3293
3294         Use warning-ignoring macros more consistently and simply
3295         https://bugs.webkit.org/show_bug.cgi?id=192743
3296
3297         Reviewed by Mark Lam.
3298
3299         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3300         (handleEventCarbon): Use ALLOW_DEPRECATED_DECLARATIONS_BEGIN/END.
3301         * DumpRenderTree/mac/TextInputControllerMac.m:
3302         (-[TextInputController interpretKeyEvents:withSender:]): Use
3303         IGNORE_WARNINGS_BEGIN/END.
3304         * WebKitTestRunner/mac/EventSenderProxy.mm:
3305         (WTR::EventSenderProxy::mouseForceClick): Use
3306         IGNORE_NULL_CHECK_WARNINGS_BEGIN/END.
3307         (WTR::EventSenderProxy::startAndCancelMouseForceClick): Ditto.
3308         (WTR::EventSenderProxy::mouseForceDown): Ditto.
3309         (WTR::EventSenderProxy::mouseForceUp): Ditto.
3310         (WTR::EventSenderProxy::mouseForceChanged): Ditto.
3311
3312 2018-12-15  Darin Adler  <darin@apple.com>
3313
3314         Replace many uses of String::format with more type-safe alternatives
3315         https://bugs.webkit.org/show_bug.cgi?id=192742
3316
3317         Reviewed by Mark Lam.
3318
3319         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3320         (WTR::cacheTestRunnerCallback): Use makeString.
3321         * WebKitTestRunner/TestController.cpp:
3322         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
3323         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
3324
3325 2018-12-15  Adrian Perez de Castro  <aperez@igalia.com>
3326
3327         [WPE][GTK] Add libpsl to JHBuild module sets
3328         https://bugs.webkit.org/show_bug.cgi?id=192740
3329
3330         Reviewed by Michael Catanzaro.
3331
3332         * gtk/jhbuild.modules: Add libpsl module.
3333         * wpe/jhbuild.modules: Ditto.
3334
3335 2018-12-14  Alexey Proskuryakov  <ap@apple.com>
3336
3337         Add a style checker rule for Xcode version macros use
3338         https://bugs.webkit.org/show_bug.cgi?id=192703
3339
3340         Reviewed by Alex Christensen.
3341
3342         * Scripts/webkitpy/style/checkers/cpp.py:
3343         (check_os_version_checks):
3344         (process_line):
3345         (CppChecker):
3346         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3347         (WebKitStyleTest.test_os_version_checks):
3348
3349 2018-12-14  Chris Dumez  <cdumez@apple.com>
3350
3351         [PSON] Process-swapping on a loadHTMLString causes duplicate decidePolicyForNavigationAction delegate calls
3352         https://bugs.webkit.org/show_bug.cgi?id=192704
3353
3354         Reviewed by Geoffrey Garen.
3355
3356         Extend existing API test to reproduce the problem.
3357
3358         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3359
3360 2018-12-14  Chris Dumez  <cdumez@apple.com>
3361
3362         [PSON] WebsitePolicies are lost on process-swap
3363         https://bugs.webkit.org/show_bug.cgi?id=192694
3364         <rdar://problem/46715748>
3365
3366         Reviewed by Brady Eidson.
3367
3368         Extend existing API test to reproduce the issue.
3369
3370         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3371
3372 2018-12-14  Michael Catanzaro  <mcatanzaro@igalia.com>
3373
3374         [GTK] Error writing data to TLS socket in some sites when using the jhbuild
3375         https://bugs.webkit.org/show_bug.cgi?id=192678
3376
3377         Reviewed by Carlos Garcia Campos.
3378
3379         Update our ancient versions of libsoup and glib-networking.
3380
3381         * gtk/install-dependencies:
3382         * gtk/jhbuild.modules:
3383         * gtk/patches/libsoup-auth-Fix-async-authentication-when-flag-SOUP_MESSAGE.patch: Removed.
3384         * gtk/patches/libsoup-auth-do-not-use-cached-credentials-in-lookup-method-.patch: Removed.
3385         * gtk/patches/libsoup-soup-message-io-Do-not-fail-when-there-s-no-empty-li.patch: Removed.
3386         * gtk/patches/libsoup-soup-socket-fix-critical-warning-when-the-peer-certi.patch: Removed.
3387         * wpe/install-dependencies:
3388         * wpe/jhbuild.modules:
3389         * wpe/patches/libsoup-soup-socket-fix-critical-warning-when-the-peer-certi.patch: Removed.
3390
3391 2018-12-14  Carlos Garcia Campos  <cgarcia@igalia.com>
3392
3393         [WPE] Use new view state API from libwpe
3394         https://bugs.webkit.org/show_bug.cgi?id=191906
3395
3396         Reviewed by Žan Doberšek.
3397
3398         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
3399         (beforeAll): Enable /webkit/WebKitWebView/page-visibility in WPE.
3400         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
3401         (Test::createWebViewBackend): Make the view initially hidden for consistency with GTK+ tests.
3402         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.h:
3403         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
3404         (WebViewTest::showInWindow): Add wpe_view_activity_state_visible, wpe_view_activity_state_in_window and
3405         wpe_view_activity_state_focused state flags.
3406         (WebViewTest::hideView): Remove wpe_view_activity_state_visible and wpe_view_activity_state_focused state flags.
3407         * wpe/backends/HeadlessViewBackend.cpp:
3408         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Assume view is always visible, focused and in window.
3409         * wpe/backends/WindowViewBackend.cpp:
3410         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Update the view state flags depending on state
3411         received in configure callback.
3412         * wpe/jhbuild.modules: Bump libwpe to 1.1.0
3413
3414 2018-12-13  Fujii Hironori  <Hironori.Fujii@sony.com>
3415
3416         [WinCairo][Clang] DLLLauncherMain.cpp: warning: unused function 'prependPath' and 'appleApplicationSupportDirectory'
3417         https://bugs.webkit.org/show_bug.cgi?id=192688
3418
3419         Reviewed by Ross Kirsling.
3420
3421         * win/DLLLauncher/DLLLauncherMain.cpp:
3422         (copyEnvironmentVariable): Moved.
3423         (getStringValue): Enclosed with #if !defined(WIN_CAIRO).
3424         (applePathFromRegistry): Ditto.
3425         (appleApplicationSupportDirectory): Ditto.
3426         (prependPath): Ditto.
3427
3428 2018-12-13  Don Olmstead  <don.olmstead@sony.com>
3429
3430         Unreviewed. Changed my status to a reviewer.
3431
3432         * Scripts/webkitpy/common/config/contributors.json:
3433
3434 2018-12-13  Wenson Hsieh  <wenson_hsieh@apple.com>
3435
3436         [iOS] Support dropping contact card data (public.vcard) in editable content
3437         https://bugs.webkit.org/show_bug.cgi?id=192570
3438         <rdar://problem/35626913>
3439
3440         Reviewed by Tim Horton.
3441
3442         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3443
3444         Add API tests to verify that registering `MKMapItem`s and `CNContact`s to item providers and dropping them in
3445         attachment-enabled rich text editable areas inserts attachment elements (and in the case of `MKMapItem`,
3446         additionally inserts a link).
3447
3448         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3449         (TestWebKitAPI::createMapItemForTesting):
3450         (TestWebKitAPI::createContactItemForTesting):
3451
3452         Add API tests to verify that dropping map items and contact items into rich and plain editable areas behaves as
3453         expected (in the case where a URL is present, e.g. dropping a map item, we insert the URL as an anchor, and when
3454         there is no other suitable representation in the item provider, we do nothing at all, which is the case for the
3455         dropped `CNContact`). Also, add a test to verify that drag and drop can be used to upload these items as .vcf
3456         files.
3457
3458 2018-12-13  Ross Kirsling  <ross.kirsling@sony.com>
3459
3460         Unreviewed -- update my status to "reviewer".
3461
3462         * Scripts/webkitpy/common/config/contributors.json:
3463
3464 2018-12-13  Youenn Fablet  <youenn@apple.com>
3465
3466         On page close, WebPage::m_userMediaPermissionRequestManager is nullified too early
3467         https://bugs.webkit.org/show_bug.cgi?id=192657
3468
3469         Reviewed by Eric Carlson.
3470
3471         Add a test that loads a page registering ondevicechange,
3472         load another page in the same process, closes the first page.
3473         Ensure that the process does not crash in that case.
3474
3475         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3476         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
3477         (TestWebKitAPI::TEST):
3478         (TestWebKitAPI::didCrashCallback):
3479         * TestWebKitAPI/Tests/WebKit/ondevicechange.html: Added.
3480
3481 2018-12-13  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
3482
3483         [GStreamer][JHBuild] update-webkit{gtk,wpe}-libs fails with libfdk-2.0.0
3484         https://bugs.webkit.org/show_bug.cgi?id=192643
3485
3486         Reviewed by Philippe Normand.
3487
3488         This problem happens with Arch Linux users which have libfdk-2.0.0
3489         installed (which is anybody with gst-plugins-bad 1.14.4 installed).
3490
3491         The problem has already been solved upstream at
3492         https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/merge_requests/77.
3493
3494         Adding patches while this problem is not in a release yet.
3495
3496         * gstreamer/jhbuild.modules: Add patches to fix build of gst-plugins-bad with libfdk-2.0.0.
3497         * gstreamer/patches/gst-plugins-bad-0003-fdkaacenc-Remove-MODE_2_1.patch: Added.
3498         * gstreamer/patches/gst-plugins-bad-0004-fdkaacdec-Use-WAV-channel-mapping-instead-of-interleave-setting.patch: Added.
3499
3500 2018-12-12  Carlos Garcia Campos  <cgarcia@igalia.com>
3501
3502         [FreeType] Add initial implementation of variation fonts
3503         https://bugs.webkit.org/show_bug.cgi?id=192151
3504
3505         Reviewed by Michael Catanzaro.
3506
3507         Add cairo patch to avoid crashes.
3508
3509         * gtk/jhbuild.modules:
3510         * gtk/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
3511
3512 2018-12-12  Fujii Hironori  <Hironori.Fujii@sony.com>
3513
3514         [Win][Clang][WebKitLegacy] WebFrame.cpp: warning: delete called on non-final 'WebFrame' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
3515         https://bugs.webkit.org/show_bug.cgi?id=192618
3516
3517         Reviewed by Alex Christensen.
3518
3519         * DumpRenderTree/win/DRTDataObject.cpp:
3520         * DumpRenderTree/win/DRTDataObject.h:
3521         * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
3522         * DumpRenderTree/win/DRTDropSource.h:
3523         * DumpRenderTree/win/EditingDelegate.h:
3524         * DumpRenderTree/win/PolicyDelegate.h:
3525         * DumpRenderTree/win/UIDelegate.h:
3526
3527 2018-12-12  Ryosuke Niwa  <rniwa@webkit.org>
3528
3529         Make TextInputController.legacyAttributedString take DOM nodes and offsets
3530         https://bugs.webkit.org/show_bug.cgi?id=192653
3531
3532         Reviewed by Wenson Hsieh.
3533
3534         Updated TextInputController.legacyAttributedString to take DOM nodes and offsets instead of
3535         a DOM Range object in preparation to add layout tests for HTMLConverter which crosses
3536         shadow boundaries.
3537
3538         * DumpRenderTree/mac/TextInputControllerMac.m:
3539         (+[TextInputController isSelectorExcludedFromWebScript:]): Updated the selector signature.
3540         (+[TextInputController webScriptNameForSelector:]): Ditto.
3541         (-[TextInputController legacyAttributedString:offset:to:offset:]): Made this function take
3542         start node and offset then end node and offset pairs.
3543
3544 2018-12-12  Alex Christensen  <achristensen@webkit.org>
3545
3546         Implement safe browsing in WebKit on WatchOS
3547         https://bugs.webkit.org/show_bug.cgi?id=192641
3548         <rdar://problem/46376188>
3549
3550         Reviewed by Geoff Garen.
3551
3552         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3553         (-[SafeBrowsingNavigationDelegate _webViewDidShowSafeBrowsingWarning:]):
3554         (safeBrowsingView):
3555         Add a test that the new delegate callback is called.
3556
3557 2018-12-12  Michael Catanzaro  <mcatanzaro@igalia.com>
3558
3559         Unreviewed manual rollout of r239100-r239102 and r239116
3560         https://bugs.webkit.org/show_bug.cgi?id=192151
3561         <rdar://problem/46655586>
3562
3563         * gtk/jhbuild.modules:
3564         * gtk/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Removed.
3565
3566 2018-12-12  Commit Queue  <commit-queue@webkit.org>
3567
3568         Unreviewed, rolling out r239103.
3569         https://bugs.webkit.org/show_bug.cgi?id=192627
3570
3571         It broke the built because it depends on another patch that
3572         didn't land yet (Requested by KaL on #webkit).
3573
3574         Reverted changeset:
3575
3576         "[WPE] Add API to notify about frame displayed view backend
3577         callback"
3578         https://bugs.webkit.org/show_bug.cgi?id=192224
3579         https://trac.webkit.org/changeset/239103
3580
3581 2018-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
3582
3583         [WPE] Add API to notify about frame displayed view backend callback
3584         https://bugs.webkit.org/show_bug.cgi?id=192224
3585
3586         Reviewed by Michael Catanzaro.
3587
3588         Add a test case to check the new API.
3589
3590         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
3591         (testWebViewFrameDisplayed):
3592         (beforeAll):
3593
3594 2018-12-12  Carlos Garcia Campos  <cgarcia@igalia.com>
3595
3596         [FreeType] Add initial implementation of variation fonts
3597         https://bugs.webkit.org/show_bug.cgi?id=192151
3598
3599         Reviewed by Michael Catanzaro.
3600
3601         Add cairo patch to avoid crashes.
3602
3603         * gtk/jhbuild.modules:
3604         * gtk/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
3605
3606 2018-12-11  Justin Michaud  <justin_michaud@apple.com>
3607
3608         Implement feature flag for CSS Typed OM
3609         https://bugs.webkit.org/show_bug.cgi?id=192610
3610
3611         Reviewed by Ryosuke Niwa.
3612
3613         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3614
3615 2018-12-11  Chris Dumez  <cdumez@apple.com>
3616
3617         Unreviewed, fix bad check in API test added in r239080.
3618
3619         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3620
3621 2018-12-11  Fujii Hironori  <Hironori.Fujii@sony.com>
3622
3623         [Win][Clang] Fix warning -Wmissing-field-initializers
3624         https://bugs.webkit.org/show_bug.cgi?id=192584
3625
3626         Reviewed by Yusuke Suzuki.
3627
3628         Initialize a struct with '{ }' instead of '= {0}'.
3629
3630         * DumpRenderTree/win/DumpRenderTree.cpp:
3631         (runTest):
3632         * DumpRenderTree/win/EventSender.cpp:
3633         (makeMsg):
3634         (replaySavedEvents):
3635         (beginDragWithFilesCallback):
3636         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
3637         (createBitmapContextFromWebView):
3638         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
3639         (updateMenuItemForHistoryItem):
3640         * MiniBrowser/win/WinMain.cpp:
3641         (wWinMain):
3642         * TestWebKitAPI/win/HostWindow.cpp:
3643         (TestWebKitAPI::HostWindow::clientRect const):
3644         (TestWebKitAPI::HostWindow::registerWindowClass):
3645         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
3646         (TestWebKitAPI::PlatformWebView::registerWindowClass):
3647         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3648         (WTR::registerWindowClass):