Add afterScreenUpdates to WKSnapshotConfiguration
[WebKit-https.git] / Tools / ChangeLog
1 2019-02-08  Beth Dakin  <bdakin@apple.com>
2
3         Add afterScreenUpdates to WKSnapshotConfiguration
4         https://bugs.webkit.org/show_bug.cgi?id=194362
5         -and corresponding-
6         <rdar://problem/40655528> Please add an "after screen updates" property to 
7         WKSnapshotConfiguration (to solve blank snapshots)
8
9         Reviewed by Tim Horton.
10
11         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:
12         (TEST):
13
14 2019-02-08  Benjamin Poulain  <benjamin@webkit.org>
15
16         clampTo(): do not convert the input to double when dealing with integers
17         https://bugs.webkit.org/show_bug.cgi?id=194263
18         <rdar://problem/47692312>
19
20         Reviewed by Darin Adler.
21
22         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
23         (TestWebKitAPI::testClampFloatingPointToFloatingPoint):
24         (TestWebKitAPI::testClampFloatingPointToInteger):
25         (TestWebKitAPI::testClampSameSignIntegers):
26         (TestWebKitAPI::testClampUnsignedToSigned):
27         (TestWebKitAPI::testClampSignedToUnsigned):
28
29 2019-02-07  Jonathan Bedard  <jbedard@apple.com>
30
31         webkitpy: Respect --dedicated-simulators flag
32         https://bugs.webkit.org/show_bug.cgi?id=194416
33         <rdar://problem/47894722>
34
35         Reviewed by Lucas Forschler.
36
37         * Scripts/webkitpy/port/device_port.py:
38         (DevicePort.supported_device_types): If --dedicated-simulators is passed, all
39         available devices can be safely ignored.
40
41 2019-02-07  Keith Rollin  <krollin@apple.com>
42
43         Remove extra copy of 100x100-red.tga
44         https://bugs.webkit.org/show_bug.cgi?id=194371
45         <rdar://problem/47873465>
46
47         Reviewed by Said Abou-Hallawa.
48
49         In order to help it pass its tests, Bug 194190 added a second copy of
50         the file 100x100-red.tga. However, it turns out that this additional
51         file wasn't actually needed, and that that sole previous copy was
52         sufficient. At the same time, this second copy -- which was copied to
53         the same location in the build output as the first copy -- now caused
54         XCBuild to complain because there were two production rules for the
55         same output file. Address this by removing the newly-added extra copy.
56
57         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
58         * TestWebKitAPI/Tests/mac/100x100-red.tga: Removed.
59
60 2019-02-07  Alex Christensen  <achristensen@webkit.org>
61
62         Deprecate WKBundlePageSetDefersLoading
63         https://bugs.webkit.org/show_bug.cgi?id=191394
64
65         Reviewed by Dean Jackson.
66
67         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
68         (WTR::TestRunner::setDefersLoading):
69
70 2019-02-07  Zalan Bujtas  <zalan@apple.com>
71
72         [LFC][Out-of-flow] Use the containing block's padding width when computing min/max width.
73         https://bugs.webkit.org/show_bug.cgi?id=194391
74
75         Reviewed by Antti Koivisto.
76
77         * LayoutReloaded/misc/LFC-passing-tests.txt:
78
79 2019-02-06  Keith Rollin  <krollin@apple.com>
80
81         Remove Info.plist from MobileMiniBrowser.framework's Copy Bundle Resources phase
82         https://bugs.webkit.org/show_bug.cgi?id=193975
83         <rdar://problem/47643306>
84
85         Reviewed by Tim Horton.
86
87         The MobileMiniBrowser.framework's Copy Bundle Resources phase copies
88         the Info.plist file into the bundle. This step is not necessary as the
89         implicit "bundle up all the build products into a framework" build
90         phase does this already. Having the Copy Bundle Resources phase do
91         this causes a conflict under XCBuild, which objects to two build
92         phases producing the same file (Info.plist). Address this by removing
93         Info.plist from the Copy Bundle Resources phase.
94
95         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
96
97 2019-02-06  Keith Rollin  <krollin@apple.com>
98
99         Really enable the automatic checking and regenerations of .xcfilelists during builds
100         https://bugs.webkit.org/show_bug.cgi?id=194357
101         <rdar://problem/47861231>
102
103         Reviewed by Chris Dumez.
104
105         Bug 194124 was supposed to enable the automatic checking and
106         regenerating of .xcfilelist files during the build. While related
107         changes were included in that patch, the change to actually enable the
108         operation somehow was omitted. This patch actually enables the
109         operation. The check-xcfilelist.sh scripts now check
110         WK_DISABLE_CHECK_XCFILELISTS, and if it's "1", opts-out the developer
111         from the checking.
112
113         * DumpRenderTree/Scripts/check-xcfilelists.sh:
114         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
115
116 2019-02-06  David Kilzer  <ddkilzer@apple.com>
117
118         WTR::InjectedBundlePage::willSendRequestForFrame() leaks a WKDataRef
119         <https://webkit.org/b/194286>
120         <rdar://problem/47815558>
121
122         Reviewed by Alexey Proskuryakov.
123
124         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
125         (WTR::InjectedBundlePage::willSendRequestForFrame): Use
126         WKRetainPtr<> to avoid leaking the WKDataRef.
127
128 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
129
130         Unreviewed, fix a typo
131
132         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
133
134 2019-02-06  Olivier Blin  <olivier.blin@softathome.com>
135
136         [GTK][WPE] force libpsl build to use ICU in jhbuild
137         https://bugs.webkit.org/show_bug.cgi?id=194288
138
139         Reviewed by Carlos Garcia Campos.
140
141         * gtk/jhbuild.modules:
142         Require ICU for libpsl build in jhbuild, like done in WPE.
143
144 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
145
146         REGRESSION(r240785): [SOUP] Broke cookie persistent storage
147         https://bugs.webkit.org/show_bug.cgi?id=194209
148
149         Reviewed by Carlos Garcia Campos.
150
151         Enhance TestCookieManager to ensure this doesn't happen again.
152
153         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
154         (testCookieManagerPersistentStorage):
155         (beforeAll):
156
157 2019-02-05  Wenson Hsieh  <wenson_hsieh@apple.com>
158
159         Rename TestOptions.ignoreSynchronousMessagingTimeoutsForTesting
160         https://bugs.webkit.org/show_bug.cgi?id=194324
161
162         Reviewed by Andy Estes.
163
164         Rename ignoreSynchronousMessagingTimeoutsForTesting to just ignoreSynchronousMessagingTimeouts. The -ForTesting
165         part of the name is already implicit, since this is in testing code in TestOptions.
166
167         * WebKitTestRunner/TestController.cpp:
168         (WTR::TestController::generateContextConfiguration const):
169         (WTR::updateTestOptionsFromTestHeader):
170         * WebKitTestRunner/TestOptions.h:
171         (WTR::TestOptions::hasSameInitializationOptions const):
172
173 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
174
175         [ews-build] Allow * as platform for builders and workers
176         https://bugs.webkit.org/show_bug.cgi?id=188533
177
178         Reviewed by Lucas Forschler.
179
180         * BuildSlaveSupport/ews-build/loadConfig.py:
181         (checkWorkersAndBuildersForConsistency):
182
183 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
184
185         [ews-build] Add few bots to config.json
186         https://bugs.webkit.org/show_bug.cgi?id=194304
187
188         Reviewed by Lucas Forschler.
189
190         * BuildSlaveSupport/ews-build/config.json:
191
192 2019-02-05  Keith Rollin  <krollin@apple.com>
193
194         Enable the automatic checking and regenerations of .xcfilelists during builds
195         https://bugs.webkit.org/show_bug.cgi?id=194124
196         <rdar://problem/47721277>
197
198         Reviewed by Tim Horton.
199
200         Bug 193790 add a facility for checking -- during build time -- that
201         any needed .xcfilelist files are up-to-date and for updating them if
202         they are not. This facility was initially opt-in by setting
203         WK_ENABLE_CHECK_XCFILELISTS until other pieces were in place and until
204         the process seemed robust. Its now time to enable this facility and
205         make it opt-out. If there is a need to disable this facility, set and
206         export WK_DISABLE_CHECK_XCFILELISTS=1 in your environment before
207         running `make` or `build-webkit`, or before running Xcode from the
208         command line.
209
210         Additionally, remove the step that generates a list of source files
211         going into the UnifiedSources build step. It's only necessarily to
212         specify Sources.txt and SourcesCocoa.txt as inputs.
213
214         * Scripts/generate-xcfilelists:
215
216 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
217
218         [GTK][WPE] force libpsl build to use ICU in jhbuild
219         https://bugs.webkit.org/show_bug.cgi?id=194288
220
221         Reviewed by Philippe Normand.
222
223         In jhbuild, libpsl depends on ICU, but its configure script may decide to use libidn instead of ICU.
224         This can cause build failures if libidn is detected but libunistring is not available.
225
226         Make sure that ICU is used for runtime and builtin PSL data.
227
228         * gtk/jhbuild.modules:
229         * wpe/jhbuild.modules:
230
231 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
232
233         [ews-app] Modified timestamp should be updated on updating data
234         https://bugs.webkit.org/show_bug.cgi?id=194295
235
236         Reviewed by Lucas Forschler.
237
238         * BuildSlaveSupport/ews-app/ews/models/build.py:
239         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
240         * BuildSlaveSupport/ews-app/ews/models/step.py:
241
242 2019-02-05  Ryan Haddad  <ryanhaddad@apple.com>
243
244         Unreviewed, rolling out r240742.
245
246         Causes crashes on iOS simulator.
247
248         Reverted changeset:
249
250         "[iOS] Keyups for non-modifier keys identified as "Dead" when
251         not focused in a content-editable element"
252         https://bugs.webkit.org/show_bug.cgi?id=192824
253         https://trac.webkit.org/changeset/240742
254
255 2019-02-05  Jonathan Bedard  <jbedard@apple.com>
256
257         run-webkit-tests emits message "...running None" when running tests
258         https://bugs.webkit.org/show_bug.cgi?id=194133
259         <rdar://problem/47724738>
260
261         Reviewed by Lucas Forschler.
262
263         * Scripts/webkitpy/xcode/device_type.py:
264         (DeviceType.__str__): Use both version mapping tables and use just the variant
265         name if no version name is available.
266         * Scripts/webkitpy/xcode/device_type_unittest.py:
267         (DeviceTypeTest):
268         (DeviceTypeTest.test_unmapped_version): Test case where the version does not have
269         an associated named.
270
271 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
272
273         [WPE] require python3-setuptools for meson build in jhbuild
274         https://bugs.webkit.org/show_bug.cgi?id=194287
275
276         Reviewed by Philippe Normand.
277
278         python3-setuptools is needed to build meson in jhbuild.
279         It is already required by the GTK port.
280
281         * wpe/install-dependencies:
282
283 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
284
285         [ews-app] Add method to save BuilderMapping to database
286         https://bugs.webkit.org/show_bug.cgi?id=194264
287
288         Reviewed by Lucas Forschler.
289
290         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
291         (BuilderMapping.__str__):
292         (BuilderMapping):
293         (BuilderMapping.save_mapping):
294         (BuilderMapping.update_mapping):
295         (BuilderMapping.get_existing_mapping):
296         (BuilderMapping.is_valid_mapping):
297
298 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
299
300         [ews-app] Add timestamp fields for BuilderMappings
301         https://bugs.webkit.org/show_bug.cgi?id=194266
302
303         Reviewed by Lucas Forschler.
304
305         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
306         (BuilderMapping):
307
308 2019-02-04  Ms2ger  <Ms2ger@igalia.com>
309
310         [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
311         https://bugs.webkit.org/show_bug.cgi?id=174816
312
313         Reviewed by Michael Catanzaro.
314
315         Add tests for webkit_uri_for_display().
316
317         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
318         (testURIForDisplayUnaffected):
319         (testURIForDisplayAffected):
320         (beforeAll):
321         (afterAll):
322         * TestWebKitAPI/glib/CMakeLists.txt:
323
324 2019-02-04  Jonathan Bedard  <jbedard@apple.com>
325
326         webkitpy: Precedence of booted devices should match precedence in DEFAULT_DEVICE_TYPES
327         https://bugs.webkit.org/show_bug.cgi?id=194158
328         <rdar://problem/47737268>
329
330         Rubber-stamped by Aakash Jain.
331
332         * Scripts/webkitpy/port/device_port.py:
333         (DevicePort.supported_device_types): Sort supported device types by the DEFAULT_DEVICE_TYPES.
334
335 2019-02-04  Said Abou-Hallawa  <said@apple.com>
336
337         [CG] Enable setAdditionalSupportedImageTypes for WK1
338         https://bugs.webkit.org/show_bug.cgi?id=194190
339
340         Reviewed by Tim Horton.
341
342         Add a test similar to the one under WebKit Cocoa but make it create a
343         WebView instead of a WKWebView.
344
345         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
346         * TestWebKitAPI/Tests/mac/100x100-red.tga: Added.
347         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.html: Added.
348         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.mm: Added.
349         (-[AdditionalSupportedImageTypesTest webView:didFinishLoadForFrame:]):
350         (TestWebKitAPI::runTest):
351         (TestWebKitAPI::TEST):
352
353 2019-02-04  Zalan Bujtas  <zalan@apple.com>
354
355         [First paint] Adjust "finishedParsingMainDocument" flag by taking deferred and async scripts into account.
356         https://bugs.webkit.org/show_bug.cgi?id=194168
357
358         Reviewed by Simon Fraser.
359
360         Test if the firstVisuallyNoneEmpty milestone fires before the deferred script's post-message. 
361
362         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
363         * TestWebKitAPI/Tests/WebKit/FirstVisuallyNonEmptyMilestoneWithDeferredScript.mm: Added.
364         (-[FirstPaintMessageHandler userContentController:didReceiveScriptMessage:]):
365         (-[RenderingProgressNavigationDelegate _webView:renderingProgressDidChange:]):
366         (TEST):
367         * TestWebKitAPI/Tests/WebKit/deferred-script-load.html: Added.
368         * TestWebKitAPI/Tests/WebKit/deferred-script.js: Added.
369
370 2019-02-04  Dean Johnson  <dean_johnson@apple.com>
371
372         REGRESSION (r237269): webkit-patch what-broke is broken 
373         https://bugs.webkit.org/show_bug.cgi?id=193025
374
375         Reviewed by Aakash Jain.
376
377         * Scripts/webkitpy/common/host.py:
378         (Host.buildbot):
379         (Host.bugzilla): Renamed to 'buildbot'.
380
381 2019-02-04  Wenson Hsieh  <wenson_hsieh@apple.com>
382
383         [iOS] API test WKAttachmentTests.InsertAndRemoveDuplicateAttachment is failing after r240902
384         https://bugs.webkit.org/show_bug.cgi?id=194207
385
386         Reviewed by Tim Horton.
387
388         Fix this API test by making it robust against smart paste on iOS. Currently, this test pastes an attachment
389         element and assumes that the pasted attachment is adjacent to the original one. However, after enabling smart
390         paste, we now insert an extra space in between. Instead of executing "DeleteBackward" twice to test removing the
391         attachment elements, we delete backwards once to remove the pasted attachment, and move the selection to the
392         start and delete forwards to remove the original attachment.
393
394         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
395         (TestWebKitAPI::TEST):
396
397 2019-02-04  Youenn Fablet  <youenn@apple.com>
398
399         Capture state should be managed consistently when doing process swapping
400         https://bugs.webkit.org/show_bug.cgi?id=194122
401         <rdar://problem/47609293>
402
403         Reviewed by Eric Carlson.
404
405         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
406         (-[GetUserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
407         (-[GetUserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
408         (-[GetUserMediaUIDelegate _webView:mediaCaptureStateDidChange:]):
409         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
410         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
411         (WTR::TestRunner::isDoingMediaCapture const):
412         * WebKitTestRunner/InjectedBundle/TestRunner.h:
413         * WebKitTestRunner/TestController.cpp:
414         (WTR::TestController::isDoingMediaCapture const):
415         * WebKitTestRunner/TestController.h:
416         * WebKitTestRunner/TestInvocation.cpp:
417         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
418         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
419         (WTR::TestController::isDoingMediaCapture const):
420
421 2019-02-03  Fujii Hironori  <Hironori.Fujii@sony.com>
422
423         [Win] WebKitTestRunners is failing to create the IndexedDB directory.
424         https://bugs.webkit.org/show_bug.cgi?id=194142
425
426         Reviewed by Ross Kirsling.
427
428         There three 'separator' variables in TestController.cpp. Renamed
429         it 'pathSeparator', and unified them.
430
431         * WebKitTestRunner/TestController.cpp:
432         (WTR::TestController::generateContextConfiguration const):
433         (WTR::createTestURL):
434         (WTR::TestController::platformAdjustContext):
435
436 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
437
438         Make setNeedsLayout on the root more explicitly about triggering its side-effects
439         https://bugs.webkit.org/show_bug.cgi?id=194198
440
441         Reviewed by Antti Koivisto.
442
443         No need to set the banner heights on navigation now, since Page stores them.
444
445         * MiniBrowser/mac/WK2BrowserWindowController.m:
446         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
447
448 2019-02-03  John Wilander  <wilander@apple.com>
449
450         Parse and handle Ad Click Attribution attributes in HTMLAnchorElement::handleClick()
451         https://bugs.webkit.org/show_bug.cgi?id=194104
452         <rdar://problem/47649991>
453
454         Reviewed by Chris Dumez, Daniel Bates, and Darin Adler.
455
456         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
457         (TestWebKitAPI::TEST):
458             Changed numeric types from unsigned short to uint32_t.
459
460 2019-02-02  David Kilzer  <ddkilzer@apple.com>
461
462         Leak of NSArray (4.25 Kbytes) in com.apple.WebKit.WebContent running WebKit layout tests on iOS Simulator
463         <https://webkit.org/b/194178>
464         <rdar://problem/47753473>
465
466         Reviewed by Alexey Proskuryakov.
467
468         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
469         (WTR::uninstallFakeHelvetica): Pass nullptr into
470         CTFontManagerUnregisterFontsForURLs() to ignore any errors.
471
472 2019-02-02  Zalan Bujtas  <zalan@apple.com>
473
474         [LFC] Initialize ICB's style with fixed width/height.
475         https://bugs.webkit.org/show_bug.cgi?id=194188
476
477         Reviewed by Antti Koivisto.
478
479         * LayoutReloaded/misc/LFC-passing-tests.txt:
480
481 2019-02-02  Zalan Bujtas  <zalan@apple.com>
482
483         [LFC] Add missing case to out-of-flow non-replaced horizontal used margin value computation
484         https://bugs.webkit.org/show_bug.cgi?id=194185
485
486         Reviewed by Antti Koivisto.
487
488         * LayoutReloaded/misc/LFC-passing-tests.txt:
489
490 2018-12-16  Darin Adler  <darin@apple.com>
491
492         Convert additional String::format clients to alternative approaches
493         https://bugs.webkit.org/show_bug.cgi?id=192746
494
495         Reviewed by Alexey Proskuryakov.
496
497         * WebKitTestRunner/TestController.cpp:
498         (WTR::originUserVisibleName): Use makeString and reduce the use of std::string
499         as an intermediate in code that ultimately constructs a WTF::String.
500         (WTR::userMediaOriginHash): Use makeString.
501         (WTR::TestController::didNavigateWithNavigationData): More of the same.
502         (WTR::TestController::didPerformClientRedirect): Ditto.
503         (WTR::TestController::didPerformServerRedirect): Ditto.
504         (WTR::TestController::didUpdateHistoryTitle): Ditto.
505
506 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
507
508         [ews-build] Add unit test to verify builder keys
509         https://bugs.webkit.org/show_bug.cgi?id=194152
510
511         Reviewed by Lucas Forschler.
512
513         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
514         (ConfigDotJSONTest.test_builder_keys): Added unit-test.
515
516 2019-02-01  Zalan Bujtas  <zalan@apple.com>
517
518         [LFC] Expand tests coverage (12 new tests -> 787)
519
520         Unreviewed test gardening.
521
522         * LayoutReloaded/misc/LFC-passing-tests.txt:
523
524 2019-02-01  Zalan Bujtas  <zalan@apple.com>
525
526         [LFC] Fix statically positioned replaced out-of-flow horizontal geometry
527         https://bugs.webkit.org/show_bug.cgi?id=194163
528
529         Reviewed by Simon Fraser.
530
531         775
532
533         * LayoutReloaded/misc/LFC-passing-tests.txt:
534
535 2019-02-01  Wenson Hsieh  <wenson_hsieh@apple.com>
536
537         [iOS] Consistent 1 sec hang when triggering modal alerts while handling synchronous touch events
538         https://bugs.webkit.org/show_bug.cgi?id=194140
539         <rdar://problem/47728098>
540
541         Reviewed by Tim Horton.
542
543         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
544         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
545         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
546
547         Add a new TestRunner hook to make modal JavaScript alerts dismiss asynchronously. This is used by the new layout
548         test to induce an IPC deadlock when presenting a modal alert during touch start.
549
550         * WebKitTestRunner/InjectedBundle/TestRunner.h:
551         * WebKitTestRunner/TestController.cpp:
552         (WTR::runJavaScriptAlert):
553
554         Add a client callback function for running JavaScript alerts.
555
556         (WTR::TestController::createOtherPage):
557         (WTR::TestController::generateContextConfiguration const):
558
559         Add a test option to disable IPC timeouts for a layout test. This forces the test to reliably time out without
560         the fix in this patch.
561
562         (WTR::TestController::createWebViewWithOptions):
563
564         Plumb TestOptions to generateContextConfiguration.
565
566         (WTR::TestController::resetPreferencesToConsistentValues):
567         (WTR::TestController::resetStateToConsistentValues):
568         (WTR::updateTestOptionsFromTestHeader):
569         (WTR::TestController::setShouldDismissJavaScriptAlertsAsynchronously):
570         (WTR::TestController::handleJavaScriptAlert):
571         * WebKitTestRunner/TestController.h:
572         * WebKitTestRunner/TestInvocation.cpp:
573         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
574         * WebKitTestRunner/TestOptions.h:
575         (WTR::TestOptions::hasSameInitializationOptions const):
576
577 2019-02-01  Chris Dumez  <cdumez@apple.com>
578
579         REGRESSION: Flaky ASSERTION FAILED: m_uncommittedState.state == State::Committed on http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page.html
580         https://bugs.webkit.org/show_bug.cgi?id=193740
581         <rdar://problem/47527267>
582
583         Reviewed by Alex Christensen.
584
585         Add API test coverage.
586
587         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
588
589 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
590
591         [ews-app] Add display name field to BuilderMapping model
592         https://bugs.webkit.org/show_bug.cgi?id=194153
593
594         Reviewed by Lucas Forschler.
595
596         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
597         (BuilderMapping):
598
599 2019-02-01  Youenn Fablet  <youenn@apple.com>
600
601         API Test broken: TestWebKitAPI.WebKit2.GetUserMediaReprompt
602         https://bugs.webkit.org/show_bug.cgi?id=194155
603
604         Reviewed by Eric Carlson.
605
606         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
607         Revert use of async functions as it seems it cannot be evaluated from TestWebKitAPI.
608         Keep calling enumerateDevices to continue cover https://bugs.webkit.org/show_bug.cgi?id=194106.
609
610 2019-02-01  Zalan Bujtas  <zalan@apple.com>
611
612         [LFC] Adjust replaced element's intrinsic ratio
613         https://bugs.webkit.org/show_bug.cgi?id=194154
614
615         Reviewed by Antti Koivisto.
616
617         761
618
619         * LayoutReloaded/misc/LFC-passing-tests.txt:
620
621 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
622
623         [WPE] Show test results in minibrowser
624         https://bugs.webkit.org/show_bug.cgi?id=194150
625
626         Reviewed by Žan Doberšek.
627
628         * Scripts/webkitpy/port/wpe.py:
629         (WPEPort.show_results_html_file):
630
631 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
632
633         [WPE] MiniBrowser: add ky bindings for back/forward navigation
634         https://bugs.webkit.org/show_bug.cgi?id=194151
635
636         Reviewed by Žan Doberšek.
637
638         ALT + <- go back
639         ALT + -> go forward
640
641         * MiniBrowser/wpe/main.cpp:
642         (main):
643
644 2019-02-01  Zalan Bujtas  <zalan@apple.com>
645
646         [LFC] Set intrinsic size on Layout::Replaced
647         https://bugs.webkit.org/show_bug.cgi?id=194139
648
649         Reviewed by Antti Koivisto.
650
651         744
652
653         * LayoutReloaded/misc/LFC-passing-tests.txt:
654
655 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
656
657         [WPE] MiniBrowser: use g_file_new_for_commandline_arg
658         https://bugs.webkit.org/show_bug.cgi?id=194146
659
660         Reviewed by Xabier Rodriguez-Calvar.
661
662         It allows to open relative paths.
663
664         * MiniBrowser/wpe/main.cpp:
665         (main):
666
667 2019-01-31  Ryan Haddad  <ryanhaddad@apple.com>
668
669         Update flakiness dashboard configuration after recent queue changes
670         https://bugs.webkit.org/show_bug.cgi?id=194127
671
672         Rubber-stamped by Aakash Jain.
673
674         Apple Windows queues were updated in r237755, and Sierra was removed in r239859.
675
676         * TestResultServer/static-dashboards/builders.jsonp:
677
678 2019-01-31  Youenn Fablet  <youenn@apple.com>
679
680         Add an API test to cover UIClient checkUserMediaPermissionForOrigin being nullptr
681         https://bugs.webkit.org/show_bug.cgi?id=194106
682         <rdar://problem/47676333>
683
684         Reviewed by Ryosuke Niwa.
685
686         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
687         (TestWebKitAPI::didFinishNavigation):
688         (TestWebKitAPI::TEST):
689         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
690
691 2019-01-31  Chris Dumez  <cdumez@apple.com>
692
693         Page zoom level is lost after a process swap or a crash
694         https://bugs.webkit.org/show_bug.cgi?id=194105
695         <rdar://problem/47610781>
696
697         Reviewed by Alex Christensen.
698
699         Add API test coverage.
700
701         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
702         (-[PSONNavigationDelegate webView:didCommitNavigation:]):
703
704 2019-01-31  Alex Christensen  <achristensen@webkit.org>
705
706         Revert r238819 which is unneeded and caused a performance regression.
707         https://bugs.webkit.org/show_bug.cgi?id=192272
708         <rdar://problem/46664625>
709
710         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenPlugIn.mm:
711         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didCommitLoadForFrame:]):
712         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:willStartProvisionalLoadForFrame:completionHandler:]): Deleted.
713
714 2019-01-31  Jiewen Tan  <jiewen_tan@apple.com>
715
716         Formalize WebKitAdditions mechanism of LoadOptimizer
717         https://bugs.webkit.org/show_bug.cgi?id=193886
718         <rdar://problem/47696809>
719
720         Reviewed by Brent Fulgham.
721
722         * MiniBrowser/MiniBrowser.entitlements:
723         Make com.apple.security.temporary-exception.mach-lookup.global-name an array.
724
725 2019-01-31  Zalan Bujtas  <zalan@apple.com>
726
727         [LFC] Margin before/after/start/end initial value is 0 and not auto.
728         https://bugs.webkit.org/show_bug.cgi?id=194090
729
730         Reviewed by Antti Koivisto.
731
732         * LayoutReloaded/misc/LFC-passing-tests.txt:
733
734 2019-01-31  Zalan Bujtas  <zalan@apple.com>
735
736         [LFC] Use the used margin values in outOfFlowReplacedHorizontalGeometry consistently
737         https://bugs.webkit.org/show_bug.cgi?id=194074
738
739         Reviewed by Antti Koivisto.
740
741         * LayoutReloaded/misc/LFC-passing-tests.txt:
742
743 2019-01-31  Zalan Bujtas  <zalan@apple.com>
744
745         [LFC][BFC] Add support for block level replaced box.
746         https://bugs.webkit.org/show_bug.cgi?id=194071
747
748         Reviewed by Antti Koivisto.
749
750         * LayoutReloaded/misc/LFC-passing-tests.txt:
751
752 2019-01-31  Fujii Hironori  <Hironori.Fujii@sony.com>
753
754         Fix WebKitTestRunner's testPath with Windows full paths
755         https://bugs.webkit.org/show_bug.cgi?id=194012
756
757         Reviewed by Alex Christensen.
758
759         updateTestOptionsFromTestHeader failed to open test files because
760         testPath returned wrong file paths. It returned a path "/C:/..."
761         if a URL "file:///C:/..." was given.
762
763         * WebKitTestRunner/TestController.cpp:
764         (WTR::testPath): Removed the first '/' if the path starts with something like "/C:/".
765
766 2019-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
767
768         [WPE] Bump font related dependencies to match the GTK+ port
769         https://bugs.webkit.org/show_bug.cgi?id=194017
770
771         Reviewed by Žan Doberšek.
772
773         * wpe/jhbuild.modules:
774         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
775         * wpe/patches/icudata-stdlibs.patch: Added.
776
777 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
778
779         Enable swipe tests on iOS
780         https://bugs.webkit.org/show_bug.cgi?id=194076
781
782         Reviewed by Geoffrey Garen.
783
784         Removed the superflous call to prepareForAsyncTask and asyncTaskComplete as
785         it causes a debug assertion failure in runUIScript.
786
787         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
788         (WTR::UIScriptController::beginBackSwipe):
789         (WTR::UIScriptController::completeBackSwipe):
790
791 2019-01-30  Keith Rollin  <krollin@apple.com>
792
793         Use correct printf format specifier
794         https://bugs.webkit.org/show_bug.cgi?id=194062
795         <rdar://problem/47686167>
796
797         Reviewed by Alexey Proskuryakov.
798
799         LayoutTestSpellChecker.mm is trying to format a variable of type
800         NSTextCheckingType with %tu (unsigned ptrdiff_t), when the type is
801         actually an unsigned long long. Fix this by formatting with %llu.
802
803         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
804         (-[LayoutTestTextCheckingResult description]):
805
806 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
807
808         REGRESSION(r240541): WebKit.WebsitePoliciesCustomJavaScriptUserAgent is failing since introduction on iOS
809         https://bugs.webkit.org/show_bug.cgi?id=193979
810
811         Reviewed by Wenson Hsieh.
812
813         Fix the test for iOS. Make the test work with iOS UA string.
814
815         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
816
817 2019-01-30  Ryan Haddad  <ryanhaddad@apple.com>
818
819         Replace High Sierra LLINT CLoop bot due to hardware failure
820         https://bugs.webkit.org/show_bug.cgi?id=194066
821
822         Reviewed by Aakash Jain.
823
824         * BuildSlaveSupport/build.webkit.org-config/config.json:
825
826 2019-01-30  Keith Rollin  <krollin@apple.com>
827
828         [NSDragItem init] is unavailable
829         https://bugs.webkit.org/show_bug.cgi?id=194059
830         <rdar://problem/47685715>
831
832         Reviewed by Wenson Hsieh.
833
834         [NSDragItem init] is marked as NS_UNAVAILABLE. This affects
835         DumpRenderTree and TestWebKitAPI, which both try to create an
836         NSDragItem in a manner that invokes this method. Address this by using
837         -initWithPasteboardWriter instead.
838
839         Note that the parameter passed to initWithPasteboardWriter is likely
840         incorrect. In both cases, the object passed does not conform to
841         NSPasteboardWriting. However, with this fix, we're no worse off than
842         before, and can now perform builds with newer compilers and SDKs until
843         a real fix can be crafted. That work is tracked in
844         https://bugs.webkit.org/show_bug.cgi?id=194060
845
846         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
847         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
848         * TestWebKitAPI/mac/TestDraggingInfo.mm:
849         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
850
851 2019-01-30  Daniel Bates  <dabates@apple.com>
852
853         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
854         https://bugs.webkit.org/show_bug.cgi?id=192824
855         <rdar://problem/47100332>
856
857         Reviewed by Wenson Hsieh.
858
859         Fix a bug where the wrong usage code was used for F13 thru F24.
860
861         * WebKitTestRunner/ios/HIDEventGenerator.mm:
862         (keyCodeForDOMFunctionKey):
863
864 2019-01-30  Chris Dumez  <cdumez@apple.com>
865
866         Regression(PSON) Load hang can occur on history navigation
867         https://bugs.webkit.org/show_bug.cgi?id=194030
868         <rdar://problem/47656939>
869
870         Reviewed by Antti Koivisto.
871
872         Add API test coverage.
873
874         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
875
876 2019-01-30  Zalan Bujtas  <zalan@apple.com>
877
878         [LFC] Expand tests coverage.
879
880         Unreviewed test gardening.
881
882         * LayoutReloaded/misc/LFC-passing-tests.txt:
883
884 2019-01-30  Thibault Saunier  <tsaunier@igalia.com>
885
886         [Flatpak] Add openjpeg support
887         https://bugs.webkit.org/show_bug.cgi?id=194019
888
889         Reviewed by Michael Catanzaro.
890
891         * flatpak/org.webkit.CommonModules.yaml:
892
893 2019-01-30  Commit Queue  <commit-queue@webkit.org>
894
895         Unreviewed, rolling out r240708.
896         https://bugs.webkit.org/show_bug.cgi?id=194022
897
898         It broke WPE build (Requested by KaL on #webkit).
899
900         Reverted changeset:
901
902         "[WPE] Bump font related dependencies to match the GTK+ port"
903         https://bugs.webkit.org/show_bug.cgi?id=194017
904         https://trac.webkit.org/changeset/240708
905
906 2019-01-30  Zalan Bujtas  <zalan@apple.com>
907
908         [LFC][IFC] nextBreakablePosition returns the same position on hyphen characters
909         https://bugs.webkit.org/show_bug.cgi?id=194001
910
911         Reviewed by Antti Koivisto.
912
913         * LayoutReloaded/misc/LFC-passing-tests.txt:
914
915 2019-01-30  Zalan Bujtas  <zalan@apple.com>
916
917         [LFC] Use the used margin values in outOfFlowReplacedVerticalGeometry consistently
918         https://bugs.webkit.org/show_bug.cgi?id=194020
919
920         Reviewed by Antti Koivisto.
921
922         * LayoutReloaded/misc/LFC-passing-tests.txt:
923
924 2019-01-30  Chris Fleizach  <cfleizach@apple.com>
925
926         AX: Support color well on iOS
927         https://bugs.webkit.org/show_bug.cgi?id=194010
928
929         Reviewed by Joanmarie Diggs.
930
931         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
932         (WTR::AccessibilityUIElement::stringAttributeValue):
933
934 2019-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
935
936         [WPE] Bump font related dependencies to match the GTK+ port
937         https://bugs.webkit.org/show_bug.cgi?id=194017
938
939         Reviewed by Žan Doberšek.
940
941         * wpe/jhbuild.modules:
942         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
943         * wpe/patches/icudata-stdlibs.patch: Added.
944
945 2019-01-29  Alexey Proskuryakov  <ap@apple.com>
946
947         [Mac] Update window scale API usage
948         https://bugs.webkit.org/show_bug.cgi?id=193991
949         rdar://problem/47614795
950
951         Reviewed by Tim Horton.
952
953         * DumpRenderTree/mac/DumpRenderTree.mm:
954         (changeWindowScaleIfNeeded):
955         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
956         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
957         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
958
959 2019-01-29  Chris Dumez  <cdumez@apple.com>
960
961         REGRESSION: ProcessSwap.DoSameSiteNavigationAfterCrossSiteProvisionalLoadStarted Failing on iOS
962         https://bugs.webkit.org/show_bug.cgi?id=193977
963         <rdar://problem/47643716>
964
965         Reviewed by Geoff Garen.
966
967         Update API test to address flakiness on iOS. Instead of doing the last navigation after receiving the
968         didStartProvisionalLoad, do we right after we answer the navigation policy request. Flakiness was due
969         to the previous provisional committing *before* we make the last load. 
970
971         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
972
973 2019-01-29  Youenn Fablet  <youenn@apple.com>
974
975         Adopt new SPI to evaluate server certificate trust
976         https://bugs.webkit.org/show_bug.cgi?id=193355
977
978         Reviewed by Alex Christensen.
979
980         Add infrastructure to handle HTTPS server trust evaluation testing.
981
982         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
983         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
984         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
985         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
986         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
987         * WebKitTestRunner/InjectedBundle/TestRunner.h:
988         * WebKitTestRunner/TestController.cpp:
989         (WTR::TestController::resetPreferencesToConsistentValues):
990         (WTR::TestController::didReceiveAuthenticationChallenge):
991         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
992         * WebKitTestRunner/TestController.h:
993         (WTR::TestController::serverTrustEvaluationCallbackCallsCount const):
994         * WebKitTestRunner/TestInvocation.cpp:
995         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
996         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
997         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
998
999 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1000
1001         [ews-build] Add build step to print bot Configuration
1002         https://bugs.webkit.org/show_bug.cgi?id=193887
1003
1004         Reviewed by Lucas Forschler.
1005
1006         * BuildSlaveSupport/ews-build/steps.py:
1007         (PrintConfiguration): Build step to print configuration.
1008         * BuildSlaveSupport/ews-build/factories.py:
1009
1010 2019-01-29  Chris Dumez  <cdumez@apple.com>
1011
1012         Regression (r240046): [PSON] Spurious changes to [WKWebView url] and [WKWebView loading] after [WKWebView loadRequest]
1013         https://bugs.webkit.org/show_bug.cgi?id=193967
1014         <rdar://problem/47635348>
1015
1016         Reviewed by Alex Christensen.
1017
1018         Add API test coverage.
1019
1020         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1021         (-[PSONLoadingObserver observeValueForKeyPath:ofObject:change:context:]):
1022
1023 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1024
1025         [ews-app] Handle incoming results data
1026         https://bugs.webkit.org/show_bug.cgi?id=193973
1027
1028         Reviewed by Lucas Forschler.
1029
1030         * BuildSlaveSupport/ews-app/ews/views/results.py:
1031
1032 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1033
1034         [ews-app] Make the results url generic
1035         https://bugs.webkit.org/show_bug.cgi?id=193928
1036
1037         Reviewed by Lucas Forschler.
1038
1039         * BuildSlaveSupport/ews-app/ews/urls.py:
1040
1041 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1042
1043         [ews-build] Configure buildbot to send events to ews-app
1044         https://bugs.webkit.org/show_bug.cgi?id=193968
1045
1046         Reviewed by Lucas Forschler.
1047
1048         * BuildSlaveSupport/ews-build/events.py: Added.
1049         * BuildSlaveSupport/ews-build/master.cfg:
1050
1051 2019-01-29  Keith Rollin  <krollin@apple.com>
1052
1053         Add .xcfilelists to Run Script build phases
1054         https://bugs.webkit.org/show_bug.cgi?id=193792
1055         <rdar://problem/47201785>
1056
1057         Reviewed by Alex Christensen.
1058
1059         As part of supporting XCBuild, update the necessary Run Script build
1060         phases in their Xcode projects to refer to their associated
1061         .xcfilelist files.
1062
1063         Note that the addition of these files bumps the Xcode project version
1064         number to something that's Xcode 10 compatible. This change means that
1065         older versions of the Xcode IDE can't read these projects. Nor can it
1066         fully load workspaces that refer to these projects (the updated
1067         projects are shown as non-expandable placeholders). `xcodebuild` can
1068         still build these projects; it's just that the IDE can't open them.
1069
1070         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1071         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1072
1073 2019-01-29  John Wilander  <wilander@apple.com>
1074
1075         Add data abstraction and validation for Ad Click Attribution
1076         https://bugs.webkit.org/show_bug.cgi?id=193916
1077         <rdar://problem/47603481>
1078
1079         Reviewed by Daniel Bates, Brent Fulgham, and Alex Christensen.
1080
1081         Ad click attribution has two steps. First, the storage of an ad
1082         campaign ID for a click that takes the user to a destination
1083         site. Second, a conversion on the destination site that can be
1084         attributed to the ad click.
1085
1086         This patch adds a class that represents a request for ad click
1087         attribution. Validation makes sure that the bits of entropy
1088         reported through this mechanism is limited.
1089
1090         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1091         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp: Added.
1092         (TestWebKitAPI::TEST):
1093
1094 2019-01-29  Chris Dumez  <cdumez@apple.com>
1095
1096         REGRESSION (PSON): Twitter link gets stuck at t.co after navigating back in tab
1097         https://bugs.webkit.org/show_bug.cgi?id=193932
1098         <rdar://problem/47598947>
1099
1100         Reviewed by Brady Eidson.
1101
1102         Add API test coverage.
1103
1104         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1105
1106 2019-01-29  Zalan Bujtas  <zalan@apple.com>
1107
1108         Adding new passing LFC tests.
1109
1110         Unreviewed test gardening.
1111
1112         * LayoutReloaded/misc/LFC-passing-tests.txt:
1113
1114 2019-01-29  Zalan Bujtas  <zalan@apple.com>
1115
1116         [LFC][BFC][MarginCollapsing] Remove incorrect downcast<Container>
1117         https://bugs.webkit.org/show_bug.cgi?id=193964
1118
1119         Reviewed by Antti Koivisto.
1120
1121         * LayoutReloaded/misc/LFC-passing-tests.txt:
1122
1123 2019-01-29  Zalan Bujtas  <zalan@apple.com>
1124
1125         [LFC][BFC] Do not ignore next sibling box while laying out BFC.
1126         https://bugs.webkit.org/show_bug.cgi?id=193954
1127
1128         Reviewed by Antti Koivisto.
1129
1130         * LayoutReloaded/misc/LFC-passing-tests.txt:
1131
1132 2019-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
1133
1134         WebDriver: add support for running subtests
1135         https://bugs.webkit.org/show_bug.cgi?id=193904
1136
1137         Reviewed by Michael Catanzaro.
1138
1139         pytest already supports it by passing test.py::subtest, so we can do the same.
1140
1141         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
1142         (get_item_name): Made this global.
1143         (CollectRecorder.__init__): Receive the parameter to ignore.
1144         (CollectRecorder.pytest_collectreport): Collect also the subtests.
1145         (TestExpectationsMarker.pytest_collection_modifyitems): Use get_item_name().
1146         (collect): Add parameter to ignore.
1147         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
1148         (WebDriverSeleniumExecutor.collect): Pass the driver name as parameter to ignore.
1149         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
1150         (WebDriverTestRunnerSelenium.collect_tests): Handle subtest name in test path.
1151         (WebDriverTestRunnerSelenium.run): Ditto.
1152         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
1153         (WebDriverTestRunnerW3C.collect_tests): Ditto.
1154         (WebDriverTestRunnerW3C.run): Ditto.
1155
1156 2019-01-28  Ryosuke Niwa  <rniwa@webkit.org>
1157
1158         User agent string override for navigator.userAgent should be site specific quirks
1159         https://bugs.webkit.org/show_bug.cgi?id=193950
1160
1161         Reviewed by Brent Fulgham.
1162
1163         Updated per the _WKWebsitePolicies rename.
1164
1165         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1166         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1167
1168 2019-01-28  Ross Kirsling  <ross.kirsling@sony.com>
1169
1170         Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
1171         https://bugs.webkit.org/show_bug.cgi?id=193941
1172
1173         Reviewed by Alex Christensen.
1174
1175         * TestWebKitAPI/Tests/WTF/ConcurrentPtrHashSet.cpp:
1176         * TestWebKitAPI/Tests/WTF/Condition.cpp:
1177         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1178         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
1179         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
1180         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
1181         * TestWebKitAPI/Tests/WTF/ScopedLambda.cpp:
1182         * TestWebKitAPI/Tests/WTF/Time.cpp:
1183         * TestWebKitAPI/Tests/WTF/UniqueArray.cpp:
1184         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
1185         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
1186         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
1187
1188 2019-01-28  Yusuke Suzuki  <ysuzuki@apple.com>
1189
1190         Unreviewed, reorder my emails to fix autocomplete in bugzilla
1191
1192         * Scripts/webkitpy/common/config/contributors.json:
1193
1194 2019-01-28  Andy Estes  <aestes@apple.com>
1195
1196         [watchOS] Enable Parental Controls content filtering
1197         https://bugs.webkit.org/show_bug.cgi?id=193939
1198         <rdar://problem/46641912>
1199
1200         Reviewed by Ryosuke Niwa.
1201
1202         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1203
1204 2019-01-28  David Kilzer  <ddkilzer@apple.com>
1205
1206         REGRESSION (r236481): Move soft-linking of LocalAuthentication.framework out of LocalAuthenticationSoftLink.h
1207         <https://webkit.org/b/193884>
1208
1209         Reviewed by Jiewen Tan.
1210
1211         * Scripts/webkitpy/style/checkers/cpp.py:
1212         (check_language): Add LocalAuthentication to
1213         `frameworks_with_soft_links`.
1214
1215 2019-01-28  Fujii Hironori  <Hironori.Fujii@sony.com>
1216
1217         [Win][WebKitTestRunner] Error: test and reference images have different sizes. Test image is 784x561, reference image is 800x600
1218         https://bugs.webkit.org/show_bug.cgi?id=193891
1219
1220         Reviewed by Ross Kirsling.
1221
1222         There were three problems in window sizes of WebView and the host window.
1223         1. The sizes of pixel image output were incorrect.
1224         2. The host window is going to appear after window.resize was invoked.
1225         3. window.resize resized only the host window, not WebView.
1226
1227         This change solves them with a following approach.
1228         a. PlatformWebView::PlatformWebView creates the initial host window as zero size.
1229         b. Changes the host window style from WS_OVERLAPPEDWINDOW to WS_POPUP
1230            as well as DumpRenderTree in order to match the client area and the window area.
1231         c. PlatformWebView::resizeTo simply calls PlatformWebView::setWindowFrame as well as Mac port and GTK port.
1232         d. PlatformWebView::setWindowFrame changes both window sizes.
1233         e. PlatformWebView::setWindowFrame moves the host window to the out side of screen if m_options.shouldShowWebView.
1234
1235         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1236         (WTR::PlatformWebView::PlatformWebView): Create the host window
1237         and WebView as zero size. Use WS_POPUP instead of WS_OVERLAPPEDWINDOW.
1238         (WTR::PlatformWebView::resizeTo): Calls PlatformWebView::setWindowFrame.
1239         (WTR::PlatformWebView::setWindowFrame): Change both window sizes.
1240
1241 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
1242
1243         [ews-app] Add method to save Step data to database
1244         https://bugs.webkit.org/show_bug.cgi?id=193890
1245
1246         Reviewed by Lucas Forschler.
1247
1248         * BuildSlaveSupport/ews-app/ews/models/step.py:
1249         (Step.save_step): Method to save step data.
1250         (Step.update_step): Method to update step data.
1251         (Step.get_existing_step): Method to fetch existing step from database.
1252         (Step.is_valid_result): Method to validate valid step result.
1253
1254 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
1255
1256         [ews-app] Add method to save Build data to database
1257         https://bugs.webkit.org/show_bug.cgi?id=193735
1258
1259         Reviewed by Lucas Forschler.
1260
1261         * BuildSlaveSupport/ews-app/ews/models/build.py:
1262         (Build.save_build): Method to save build information to database.
1263         (Build.get_existing_build): Method to fetch existing build from database.
1264         (Build.is_valid_result): Method to validate build result.
1265         * BuildSlaveSupport/ews-app/ews/common/util.py:
1266         (is_valid_int_id): Method to validate valid id.
1267
1268 2019-01-28  Chris Dumez  <cdumez@apple.com>
1269
1270         Regression(PSON) Crash under WebPageProxy::didStartProgress()
1271         https://bugs.webkit.org/show_bug.cgi?id=193915
1272         <rdar://problem/47560907>
1273
1274         Reviewed by Alex Christensen.
1275
1276         Add API test coverage.
1277
1278         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1279
1280 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
1281
1282         [ews-app] Rename id variables
1283         https://bugs.webkit.org/show_bug.cgi?id=193883
1284
1285         Reviewed by Lucas Forschler.
1286
1287         * BuildSlaveSupport/ews-app/ews/models/build.py:
1288         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1289         * BuildSlaveSupport/ews-app/ews/models/step.py:
1290         * BuildSlaveSupport/ews-app/ews/urls.py:
1291         * BuildSlaveSupport/ews-app/ews/views/patch.py:
1292         * BuildSlaveSupport/ews-app/ews/views/results.py:
1293         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1294
1295 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
1296
1297         [ews-app] Allow certain fields to be empty
1298         https://bugs.webkit.org/show_bug.cgi?id=193892
1299
1300         Reviewed by Lucas Forschler.
1301
1302         * BuildSlaveSupport/ews-app/ews/models/build.py:
1303         * BuildSlaveSupport/ews-app/ews/models/step.py:
1304
1305 2019-01-28  Rob Buis  <rbuis@igalia.com>
1306
1307         Update MIME type parser
1308         https://bugs.webkit.org/show_bug.cgi?id=180526
1309
1310         Reviewed by Frédéric Wang.
1311
1312         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
1313         (TestWebKitAPI::TEST):
1314
1315 2019-01-28  Zalan Bujtas  <zalan@apple.com>
1316
1317         [LFC][MarginCollapsing][Quirks] Quirk margin values get propagated through margin collapsing
1318         https://bugs.webkit.org/show_bug.cgi?id=193896
1319
1320         Reviewed by Antti Koivisto.
1321
1322         * LayoutReloaded/misc/LFC-passing-tests.txt:
1323
1324 2018-12-15  Darin Adler  <darin@apple.com>
1325
1326         Replace many uses of String::format with more type-safe alternatives
1327         https://bugs.webkit.org/show_bug.cgi?id=192742
1328
1329         Reviewed by Mark Lam.
1330
1331         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1332         (WTR::cacheTestRunnerCallback): Use makeString.
1333         * WebKitTestRunner/TestController.cpp:
1334         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
1335         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
1336
1337 2019-01-27  Jiewen Tan  <jiewen_tan@apple.com>
1338
1339         Use a load optimizer for some sites
1340         https://bugs.webkit.org/show_bug.cgi?id=193881
1341         <rdar://problem/46325455>
1342
1343         Reviewed by Brent Fulgham.
1344
1345         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1346         * TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm: Added.
1347
1348 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
1349
1350         AX: Introduce a static accessibility tree
1351         https://bugs.webkit.org/show_bug.cgi?id=193348
1352         <rdar://problem/47203295>
1353
1354         Reviewed by Ryosuke Niwa.
1355
1356         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1357
1358 2019-01-26  Zalan Bujtas  <zalan@apple.com>
1359
1360         [LFC] The default values for top/bottom in contentHeightForFormattingContextRoot should not be 0.
1361         https://bugs.webkit.org/show_bug.cgi?id=193867
1362
1363         Reviewed by Antti Koivisto.
1364
1365         * LayoutReloaded/misc/LFC-passing-tests.txt:
1366
1367 2019-01-26  Zalan Bujtas  <zalan@apple.com>
1368
1369         [LFC][BFC] Ignore last inflow child's collapsed through margin after when computing containing block's height.
1370         https://bugs.webkit.org/show_bug.cgi?id=193865
1371
1372         Reviewed by Antti Koivisto.
1373
1374         * LayoutReloaded/misc/LFC-passing-tests.txt:
1375
1376 2019-01-25  Ryosuke Niwa  <rniwa@webkit.org>
1377
1378         Need a mechanism to override navigator.userAgent
1379         https://bugs.webkit.org/show_bug.cgi?id=193762
1380         <rdar://problem/47504939>
1381
1382         Reviewed by Brent Fulgham.
1383
1384         Added test cases for _WKWebsitePolicies.customJavaScriptUserAgent.
1385
1386         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1387         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1388         (-[CustomJavaScriptUserAgentDelegate webView:didFinishNavigation:]):
1389
1390 2019-01-25  Dean Jackson  <dino@apple.com>
1391
1392         REGRESSION: Some USDz from 3rd party websites don't go directly to AR QL
1393         https://bugs.webkit.org/show_bug.cgi?id=193831
1394         <rdar://problem/47399263>
1395
1396         Reviewed by Chris Dumez.
1397
1398         Two new tests that exercise cross-origin and same-origin System
1399         Previews.
1400
1401         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1402
1403 2019-01-25  Keith Rollin  <krollin@apple.com>
1404
1405         Update Xcode projects with "Check .xcfilelists" build phase
1406         https://bugs.webkit.org/show_bug.cgi?id=193790
1407         <rdar://problem/47201374>
1408
1409         Reviewed by Alex Christensen.
1410
1411         Support for XCBuild includes specifying inputs and outputs to various
1412         Run Script build phases. These inputs and outputs are specified as
1413         .xcfilelist files. Once created, these .xcfilelist files need to be
1414         kept up-to-date. In order to check that they are up-to-date or not,
1415         add an Xcode build step that invokes an external script that performs
1416         the checking. If the .xcfilelists are found to be out-of-date, update
1417         them, halt the build, and instruct the developer to restart the build
1418         with up-to-date files.
1419
1420         At this time, the checking and regenerating is performed only if the
1421         WK_ENABLE_CHECK_XCFILELISTS environment variable is set to 1. People
1422         who want to use this facility can set this variable and test out the
1423         checking/regenerating. Once it seems like there are no egregious
1424         issues that upset a developer's workflow, we'll unconditionally enable
1425         this facility.
1426
1427         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1428         * DumpRenderTree/Scripts/check-xcfilelists.sh: Added.
1429         * WebKitTestRunner/Scripts/check-xcfilelists.sh: Added.
1430         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1431
1432 2019-01-25  Keith Rollin  <krollin@apple.com>
1433
1434         Update Xcode projects with "Apply Configuration to XCFileLists" build target
1435         https://bugs.webkit.org/show_bug.cgi?id=193781
1436         <rdar://problem/47201153>
1437
1438         Reviewed by Alex Christensen.
1439
1440         Part of generating the .xcfilelists used as part of adopting XCBuild
1441         includes running `make DerivedSources.make` from a standalone script.
1442         It’s important for this invocation to have the same environment as
1443         when the actual build invokes `make DerivedSources.make`. If the
1444         environments are different, then the two invocations will provide
1445         different results. In order to get the same environment in the
1446         standalone script, have the script launch xcodebuild targeting the
1447         "Apply Configuration to XCFileLists" build target, which will then
1448         re-invoke our standalone script. The script is now running again, this
1449         time in an environment with all workspace, project, target, xcconfig
1450         and other environment variables established.
1451
1452         The "Apply Configuration to XCFileLists" build target accomplishes
1453         this task via a small embedded shell script that consists only of:
1454
1455             eval "${WK_SUBLAUNCH_SCRIPT_PARAMETERS[@]}"
1456
1457         The process that invokes "Apply Configuration to XCFileLists" first
1458         sets WK_SUBLAUNCH_SCRIPT_PARAMETERS to an array of commands to be
1459         evaluated and exports it into the shell environment. When xcodebuild
1460         is invoked, it inherits the value of this variable and can `eval` the
1461         contents of that variable. Our external standalone script can then set
1462         WK_SUBLAUNCH_SCRIPT_PARAMETERS to the path to itself, along with a set
1463         of command-line parameters needed to restart itself in the appropriate
1464         state.
1465
1466         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1467         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1468
1469 2019-01-25  Alex Christensen  <achristensen@webkit.org>
1470
1471         Add SPI to inform an application that "Go Back" has been clicked from a safe browsing warning
1472         https://bugs.webkit.org/show_bug.cgi?id=193802
1473         <rdar://problem/46010580>
1474
1475         Reviewed by Andy Estes.
1476
1477         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1478         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]):
1479         (TEST):
1480
1481 2019-01-25  Daniel Bates  <dabates@apple.com>
1482
1483         [iOS] uiController.keyDown() does not translate Control modified key
1484         https://bugs.webkit.org/show_bug.cgi?id=192898
1485
1486         Reviewed by Wenson Hsieh.
1487
1488         Implement uiController.keyDown() in terms of HIDEventGenerator so that UIKit performs
1489         key translation, as applicable. Among other cases, key translation occurs when performing
1490         a Control key modified key sequence. Writing uiController.keyDown() in terms of HIDEventGenerator
1491         also makes the behavior of uiController.keyDown() more closely match the behavior of a
1492         human pressing down and releasing key(s) using a hardware keyboard.
1493
1494         * WebKitTestRunner/ios/HIDEventGenerator.h:
1495         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1496         (-[HIDEventGenerator sendMarkerHIDEventWithCompletionBlock:]): Renamed; formerly named _sendMarkerHIDEventWithCompletionBlock.
1497
1498         (-[HIDEventGenerator touchDown:touchCount:completionBlock:]):
1499         (-[HIDEventGenerator liftUp:touchCount:completionBlock:]):
1500         (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
1501         (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
1502         (-[HIDEventGenerator stylusUpAtPoint:completionBlock:]):
1503         (-[HIDEventGenerator stylusTapAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
1504         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
1505         (-[HIDEventGenerator longPress:completionBlock:]):
1506         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
1507         Update code for above renaming.
1508
1509         (hidUsageCodeForCharacter): Translate \b to a backspace and teach this function to recognize the
1510         DumpRenderTree EventSender-compatible modifier key names (e.g. "metaKey").
1511
1512         (-[HIDEventGenerator keyDown:]): Added.
1513         (-[HIDEventGenerator keyUp:]): Added.
1514         (-[HIDEventGenerator keyPress:completionBlock:]):
1515         (-[HIDEventGenerator eventDispatchThreadEntry:]):
1516         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]): Deleted; renamed to sendMarkerHIDEventWithCompletionBlock.
1517         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1518         (WTR::parseModifierArray): Modified to return a vector of strings that represent the modifier keys to press.
1519         (WTR::UIScriptController::keyDown): Write in terms of HIDEventGenerator.
1520         (WTR::parseModifier): Deleted.
1521
1522 2019-01-25  Keith Rollin  <krollin@apple.com>
1523
1524         Complete the implementation of generate-xcfilelists
1525         https://bugs.webkit.org/show_bug.cgi?id=193782
1526
1527         Reviewed by Alex Christensen.
1528
1529         A preliminary version of generate-xcfilelists was added in r238008.
1530         This patch updates that script in order to:
1531
1532         - Support checking of .xcfilelists
1533         - Perform better execution of `make DerivedSources.make` by
1534           relaunching generate-xcfilelists under xcodebuild
1535         - Support incremental generation and checking of .xcfilelists
1536         - Support supplementary .xcfilelists files from WebKitAdditions
1537         - Support being wrapped by parallel version of generate-xcfilelists in
1538           Internal that adds support for (re)generating WebKit projects in
1539           that repo.
1540         - Support builds that have been performed in WebKitBuild as well as
1541           ~/Library/Developer/code/DerivedData
1542         - Increase robustness and debugging facilities.
1543
1544         * Scripts/generate-xcfilelists:
1545
1546 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
1547
1548         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
1549         https://bugs.webkit.org/show_bug.cgi?id=193297
1550         <rdar://problem/47158841>
1551
1552         Unreviewed test case fix.
1553
1554         These test cases require ResourceLoadStatistics to be active, so the feature must be turned on.
1555         Previously, the default data store turned the feature on automatically, allowing these tests to pass.
1556
1557         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
1558         (TEST):
1559
1560 2019-01-25  Keith Rollin  <krollin@apple.com>
1561
1562         Update existing .xcfilelists
1563         https://bugs.webkit.org/show_bug.cgi?id=193791
1564         <rdar://problem/47201706>
1565
1566         Reviewed by Alex Christensen.
1567
1568         Many .xcfilelist files were added in r238824 in order to support
1569         XCBuild. Update these with recent changes to the set of build files
1570         and with the current generate-xcfilelist script.
1571
1572         * DumpRenderTree/DerivedSources-input.xcfilelist:
1573         * DumpRenderTree/DerivedSources-output.xcfilelist:
1574         * WebKitTestRunner/DerivedSources-input.xcfilelist:
1575         * WebKitTestRunner/DerivedSources-output.xcfilelist:
1576
1577 2019-01-25  Keith Rollin  <krollin@apple.com>
1578
1579         Fix missing dependencies in extract-dependencies-from-makefile
1580         https://bugs.webkit.org/show_bug.cgi?id=193783
1581         <rdar://problem/47201571>
1582
1583         Reviewed by Alex Christensen.
1584
1585         The extract-dependencies-from-makefile script generates .xcfilelists
1586         for XCBuild by invoking a makefile in --debug mode, parsing the
1587         dependency information in the output, and extracting information
1588         regarding targets and dependents. However, the way `make` emits this
1589         dependency information is not rigorous, and so we need to determine
1590         what lines to look for and parse by trial and error. This approach
1591         didn't coriginally atch all the information we needed to collect, so
1592         update the script to look for the additional lines we now know to look
1593         for.
1594
1595         * Scripts/extract-dependencies-from-makefile:
1596         (Parser):
1597         (Parser.addTarget):
1598         (Parser.addPrereq):
1599         (Parser.doParse):
1600
1601 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
1602
1603         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
1604         https://bugs.webkit.org/show_bug.cgi?id=193297
1605         <rdar://problem/47158841>
1606
1607         Reviewed by Alex Christensen.
1608
1609         * TestWebKitAPI/Tests/WebKit Cocoa/ResourceLoadStatistics.mm:
1610             Revise tests to ensure a running NetworkProcess before attempting ResourceLoadStatistics operations.
1611         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1612         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
1613         activating the message used to trigger the callback when it is set.
1614
1615 2019-01-25  Alex Christensen  <achristensen@webkit.org>
1616
1617         WKWebView.goBack should reload if there is a safe browsing warning
1618         https://bugs.webkit.org/show_bug.cgi?id=193805
1619         <rdar://problem/46908216>
1620
1621         Reviewed by Geoff Garen.
1622
1623         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1624         (+[Simple3LookupContext sharedLookupContext]):
1625         (-[Simple3LookupContext lookUpURL:completionHandler:]):
1626         (-[WKWebViewGoBackNavigationDelegate webView:didFinishNavigation:]):
1627         (TEST):
1628
1629 2019-01-25  Chris Dumez  <cdumez@apple.com>
1630
1631         Regression(PSON) cross-site provisional page is not canceled if a new same-site one is started
1632         https://bugs.webkit.org/show_bug.cgi?id=193788
1633         <rdar://problem/47531231>
1634
1635         Reviewed by Alex Christensen.
1636
1637         Add API test coverage.
1638
1639         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1640         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
1641
1642 2019-01-25  Jonathan Bedard  <jbedard@apple.com>
1643
1644         webkitpy: Missing PID in crashlog name should not be fatal (Follow-up fix)
1645         https://bugs.webkit.org/show_bug.cgi?id=193771
1646
1647         Unreviewed infrastructure fix.
1648
1649         * Scripts/webkitpy/port/darwin.py:
1650         (DarwinPort._merge_crash_logs): Correct syntax for catching multiple exception types.
1651
1652 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
1653
1654         * Scripts/webkitpy/common/config/contributors.json: Removing a stray comma.
1655
1656 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
1657
1658         Add contributors.json entries for Ling Ho and for a new bot watchers group.
1659
1660         * Scripts/webkitpy/common/config/contributors.json:
1661
1662 2019-01-25  Chris Dumez  <cdumez@apple.com>
1663
1664         Regression(PSON?) Crash under NavigationState::NavigationClient::decidePolicyForNavigationAction()
1665         https://bugs.webkit.org/show_bug.cgi?id=193779
1666         <rdar://problem/46170903>
1667
1668         Reviewed by Antti Koivisto.
1669
1670         Add API test that quickly navigates forward to a previous process without waiting for it to
1671         suspend. I suspect the crash could have been happening due to receiving leftover IPC from
1672         the process' previous page when reconnecting the it for the forward navigation.
1673
1674         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1675
1676 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1677
1678         Need a way for JavaScript (or bundle) code to participate in undo
1679         https://bugs.webkit.org/show_bug.cgi?id=190009
1680         <rdar://problem/44807048>
1681
1682         Reviewed by Ryosuke Niwa.
1683
1684         Add UIScriptController helpers to grab the platform undo and redo action labels. Currently only implemented for
1685         Cocoa platforms in WebKit2. See other ChangeLogs for more detail.
1686
1687         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1688         (WTR::UIScriptController::lastUndoLabel const):
1689         (WTR::UIScriptController::firstRedoLabel const):
1690         (WTR::UIScriptController::platformUndoManager const):
1691         * DumpRenderTree/mac/UIScriptControllerMac.mm:
1692         (WTR::UIScriptController::lastUndoLabel const):
1693         (WTR::UIScriptController::firstRedoLabel const):
1694         (WTR::UIScriptController::platformUndoManager const):
1695         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1696         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1697         (WTR::UIScriptController::lastUndoLabel const):
1698         (WTR::UIScriptController::firstRedoLabel const):
1699         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1700         * WebKitTestRunner/UIScriptControllerCocoa.mm:
1701         (WTR::UIScriptController::lastUndoLabel const):
1702         (WTR::UIScriptController::firstRedoLabel const):
1703         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1704         (WTR::UIScriptController::platformUndoManager const):
1705         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1706         (WTR::UIScriptController::platformUndoManager const):
1707
1708 2019-01-25  Zalan Bujtas  <zalan@apple.com>
1709
1710         [LFC][BFC][MarginCollapsing] Add "clear" to static position computation.
1711         https://bugs.webkit.org/show_bug.cgi?id=193824
1712
1713         Reviewed by Antti Koivisto.
1714
1715         * LayoutReloaded/misc/LFC-passing-tests.txt:
1716
1717 2019-01-24  Ryan Haddad  <ryanhaddad@apple.com>
1718
1719         Update macOS JSC bot configurations
1720         https://bugs.webkit.org/show_bug.cgi?id=193739
1721
1722         Reviewed by Alexey Proskuryakov.
1723
1724         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove 32-bit BuildAndTest queue.
1725         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
1726         (BubbleQueueServer): Move JSC EWS to Mojave section.
1727         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1728         (WebKitBuildbot): Remove 32-bit BuildAndTest queue from dashboard.
1729         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update unit test.
1730
1731 2019-01-24  Fujii Hironori  <Hironori.Fujii@sony.com>
1732
1733         [Win][WebKitTestRunner] Implement EventSenderProxy
1734         https://bugs.webkit.org/show_bug.cgi?id=193755
1735
1736         Reviewed by Don Olmstead.
1737
1738         * WebKitTestRunner/EventSenderProxy.h: Removed unused members m_buttonState and m_mouseButtonsCurrentlyDown.
1739         * WebKitTestRunner/win/EventSenderProxyWin.cpp:
1740         (WTR::EventSenderProxy::dispatchMessage):
1741         (WTR::EventSenderProxy::EventSenderProxy):
1742         (WTR::EventSenderProxy::mouseDown):
1743         (WTR::EventSenderProxy::mouseUp):
1744         (WTR::EventSenderProxy::mouseMoveTo):
1745         (WTR::EventSenderProxy::mouseScrollBy):
1746         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
1747
1748 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
1749
1750         Unreviewed fix for API test failure after r240437.
1751
1752         TestWTF.WTF.StringOperators apparently can't deal with another test using String::operator+. This is fine...
1753
1754         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
1755
1756 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
1757
1758         [webkitdirs] iosSimulatorApplicationsPath may not have iOS.simruntime in its path
1759         https://bugs.webkit.org/show_bug.cgi?id=193787
1760         <rdar://problem/47497634>
1761
1762         Reviewed by Alexey Proskuryakov.
1763
1764         * Scripts/webkitdirs.pm:
1765         (iosSimulatorApplicationsPath): Pick from available runtime directories.
1766
1767 2019-01-24  Truitt Savell  <tsavell@apple.com>
1768
1769         Unreviewed, rolling out r240446.
1770
1771         Casued 5 API failures
1772
1773         Reverted changeset:
1774
1775         "Activate the WebResourceLoadStatisticsStore in the
1776         NetworkProcess and deactivate it in the UIProcess."
1777         https://bugs.webkit.org/show_bug.cgi?id=193297
1778         https://trac.webkit.org/changeset/240446
1779
1780 2019-01-24  Zalan Bujtas  <zalan@apple.com>
1781
1782         DidFirstVisuallyNonEmptyLayout milestone should always fire at some point.
1783         https://bugs.webkit.org/show_bug.cgi?id=193741
1784         <rdar://problem/47135030>
1785
1786         Reviewed by Antti Koivisto and Simon Fraser.
1787
1788         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1789         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
1790         (TestWebKitAPI::TEST):
1791
1792 2019-01-24  Brent Fulgham  <bfulgham@apple.com>
1793
1794         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
1795         https://bugs.webkit.org/show_bug.cgi?id=193297
1796         <rdar://problem/47158841>
1797
1798         Reviewed by Alex Christensen.
1799
1800         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1801         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
1802         activating the message used to trigger the callback when it is set.
1803
1804 2019-01-24  John Wilander  <wilander@apple.com>
1805
1806         Add Ad Click Attribution as an internal/experimental feature
1807         https://bugs.webkit.org/show_bug.cgi?id=193685
1808         <rdar://problem/47450399>
1809
1810         Reviewed by Brent Fulgham.
1811
1812         Added test option adClickAttributionEnabled.
1813
1814         * DumpRenderTree/TestOptions.cpp:
1815         (TestOptions::TestOptions):
1816         * DumpRenderTree/TestOptions.h:
1817         * DumpRenderTree/mac/DumpRenderTree.mm:
1818         (setWebPreferencesForTestOptions):
1819
1820 2019-01-24  Antti Koivisto  <antti@apple.com>
1821
1822         [PSON] Flash on back navigation on Mac
1823         https://bugs.webkit.org/show_bug.cgi?id=193716
1824         <rdar://problem/47148458>
1825
1826         Reviewed by Chris Dumez.
1827
1828         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1829
1830         Closing of the previous page is delayed so waiting for didFinishNavigation is
1831         not sufficient to guarantee we have received all the messages. Wait for them.
1832
1833 2019-01-24  Chris Dumez  <cdumez@apple.com>
1834
1835         Regression(PSON) Back/Forward list items' URL sometimes gets replaced with the URL of a subframe
1836         https://bugs.webkit.org/show_bug.cgi?id=193761
1837         <rdar://problem/47456405>
1838
1839         Reviewed by Alex Christensen.
1840
1841         Add API test coverage.
1842
1843         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1844
1845 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
1846
1847         webkitpy: Missing PID in crashlog name should not be fatal
1848         https://bugs.webkit.org/show_bug.cgi?id=193771
1849
1850         If we can't determine the PID of a crashlog, just ignore the crashlog instead
1851         of raising an exception.
1852
1853         Reviewed by Lucas Forschler.
1854
1855         * Scripts/webkitpy/port/darwin.py:
1856         (DarwinPort._merge_crash_logs):
1857
1858 2019-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
1859
1860         test_exporter.py: webkitpy.common.system.executive.ScriptError from create_branch_with_patch
1861         https://bugs.webkit.org/show_bug.cgi?id=193746
1862
1863         Reviewed by Youenn Fablet.
1864
1865         It calls 'git apply --index --abort', but --abort is not a valid argument to 'git apply',
1866         so we'd best just not call it.
1867
1868         * Scripts/webkitpy/w3c/test_exporter.py:
1869         (WebPlatformTestExporter.create_branch_with_patch):
1870
1871 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
1872
1873         Move FileSystem to WTF
1874         https://bugs.webkit.org/show_bug.cgi?id=193602
1875
1876         Reviewed by Yusuke Suzuki.
1877
1878         * DumpRenderTree/win/DumpRenderTree.cpp:
1879         * TestWebKitAPI/CMakeLists.txt:
1880         * TestWebKitAPI/PlatformGTK.cmake:
1881         * TestWebKitAPI/PlatformJSCOnly.cmake:
1882         * TestWebKitAPI/PlatformPlayStation.cmake:
1883         * TestWebKitAPI/PlatformWPE.cmake:
1884         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1885         * TestWebKitAPI/Tests/WTF/FileSystem.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp.
1886         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
1887         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
1888         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp:
1889         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
1890         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
1891         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1892         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
1893         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
1894
1895 2019-01-24  Philippe Normand  <pnormand@igalia.com>
1896
1897         [WPE] Remove hard dependency on subprocess32 for the API tests
1898
1899         Rubber-stamped by Carlos Garcia Campos.
1900
1901         * glib/api_test_runner.py:
1902         (TestRunner._run_test_qt): Lazily import subprocess32 and check
1903         its presence only when running WPEQt tests.
1904
1905 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1906
1907         [GLIB] Expose JavaScriptCore options in GLib public API
1908         https://bugs.webkit.org/show_bug.cgi?id=188742
1909
1910         Reviewed by Michael Catanzaro.
1911
1912         Add a test for the new API.
1913
1914         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1915         (testsJSCOptions):
1916         (main):
1917
1918 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1919
1920         [GTK][WPE] Support JPEG 2000 images
1921         https://bugs.webkit.org/show_bug.cgi?id=186272
1922
1923         Reviewed by Žan Doberšek.
1924
1925         Add OpenJPEG to jhbuild since 2.2.0 version is required and it's not available in debian stable.
1926
1927         * gtk/jhbuild.modules:
1928         * wpe/jhbuild.modules:
1929
1930 2019-01-23  David Kilzer  <ddkilzer@apple.com>
1931
1932         check-webkit-style should warn when using soft-linking macros in a header
1933         <https://webkit.org/b/193750>
1934
1935         Reviewed by Darin Adler.
1936
1937         * Scripts/webkitpy/style/checkers/cpp.py:
1938         (check_language): Add softlink/header check by refactoring the
1939         softlink/framework check.
1940         (CppChecker): Enable softlink/header check by default.
1941         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1942         (CppStyleTest.test_softlink_framework): Rename from
1943         CppStyleTest.test_softlink() and change test framework name in
1944         case AVFoundation gets its own AVFoundationSoftLink.{h,mm}
1945         files. Set file_name for macros that only appear in headers.
1946         (CppStyleTest.test_softlink_header): Add tests for using
1947         soft-link macros in headers.
1948
1949 2019-01-23  Chris Dumez  <cdumez@apple.com>
1950
1951         Deprecate API to limit the maximum number of WebProcesses
1952         https://bugs.webkit.org/show_bug.cgi?id=193725
1953         <rdar://problem/47464879>
1954
1955         Reviewed by Geoff Garen.
1956
1957         Update existing API tests to stop using deprecated API.
1958
1959         * MiniBrowser/mac/AppDelegate.m:
1960         (defaultConfiguration):
1961         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
1962         (TestWebKitAPI::TEST):
1963         * TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimer.mm:
1964         (TestWebKitAPI::TEST):
1965         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1966         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
1967         (TEST):
1968         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1969         (TEST):
1970
1971 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
1972
1973         [ews-app] Rename ews model buildermappings to buildermapping
1974         https://bugs.webkit.org/show_bug.cgi?id=193729
1975
1976         Reviewed by Lucas Forschler.
1977
1978         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/buildermappings.py.
1979         (BuilderMapping): Renamed BuildMappings to BuilderMapping.
1980         * BuildSlaveSupport/ews-app/ews/models/__init__.py: Ditto.
1981
1982 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
1983
1984         [ews-app] Rename ews model steps to step
1985         https://bugs.webkit.org/show_bug.cgi?id=193697
1986
1987         Reviewed by Lucas Forschler.
1988
1989         * BuildSlaveSupport/ews-app/ews/models/step.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/steps.py.
1990         (Step): Renamed Steps to Step.
1991
1992 2019-01-23  Sihui Liu  <sihui_liu@apple.com>
1993
1994         Clean up IndexedDB files between tests
1995         https://bugs.webkit.org/show_bug.cgi?id=192796
1996         <rdar://problem/46824999>
1997
1998         Reviewed by Geoffrey Garen.
1999
2000         * DumpRenderTree/mac/DumpRenderTree.mm:
2001         (runTest):
2002         * WebKitTestRunner/TestController.cpp:
2003         (WTR::TestController::resetStateToConsistentValues):
2004         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
2005         (WTR::RemoveAllIndexedDatabasesCallback):
2006         (WTR::TestController::ClearIndexedDatabases):
2007         * WebKitTestRunner/TestController.h:
2008         * WebKitTestRunner/TestInvocation.cpp:
2009         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2010
2011 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
2012
2013         [ews-app] Rename ews model Builds to Build
2014         https://bugs.webkit.org/show_bug.cgi?id=193695
2015
2016         Reviewed by Lucas Forschler.
2017
2018         * BuildSlaveSupport/ews-app/ews/models/build.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/builds.py.
2019         (Build): Renamed Builds to Build.
2020
2021 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
2022
2023         webkitpy: Wait longer when launching WebKitTestRunner
2024         https://bugs.webkit.org/show_bug.cgi?id=193734
2025
2026         Reviewed by Aakash Jain.
2027
2028         * Scripts/webkitpy/port/simulator_process.py:
2029         (SimulatorProcess._start): Increase timeout from 6 seconds to 15 seconds.
2030
2031 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
2032
2033         [iOS] fast/events/touch/ios/hover-when-style-change-is-async.html times out
2034         https://bugs.webkit.org/show_bug.cgi?id=193182
2035         <rdar://problem/47452154>
2036
2037         Reviewed by Tim Horton.
2038
2039         This test was timing out because one of its preceding tests (drag-to-autoscroll-in-single-line-editable.html)
2040         long presses and drags to select text, but does not end the touch by lifting up; subsequently, the tap gesture
2041         recognizer isn't fired when simulating a tap in hover-when-style-change-is-async.html.
2042
2043         To fix this, tweak the test runner to make it safe for tests to end while touching the web view without
2044         preventing later tests from recognizing gestures.
2045
2046         * WebKitTestRunner/ios/TestControllerIOS.mm:
2047         (WTR::TestController::platformResetStateToConsistentValues):
2048
2049         Cancel all touches in the UIApplication when resetting to a consistent state between tests.
2050
2051 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
2052
2053         webkitpy: Use correct config for --iphone-simulator and --ipad-simulator
2054         https://bugs.webkit.org/show_bug.cgi?id=193722
2055         <rdar://problem/47481475>
2056
2057         Reviewed by Lucas Forschler.
2058
2059         iPhone and iPad ports should both use the iOS config.
2060
2061         * Scripts/webkitpy/port/ios_simulator.py:
2062         (IPhoneSimulatorPort.__init__):
2063         (IPadSimulatorPort.__init__):
2064
2065 2019-01-23  Rob Buis  <rbuis@igalia.com>
2066
2067         Update MIME type parser
2068         https://bugs.webkit.org/show_bug.cgi?id=180526
2069
2070         Reviewed by Frédéric Wang.
2071
2072         Add unit tests for both parse modes of ParsedContentType.
2073
2074         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2075         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp: Added.
2076         (TestWebKitAPI::TEST):
2077
2078 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
2079
2080         [ews-app] fetch loop should not stop on network issues
2081         https://bugs.webkit.org/show_bug.cgi?id=193666
2082
2083         Reviewed by Lucas Forschler.
2084
2085         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2086         (FetchLoop.run): Ensure that fetch loop doesn't exit on any exception.
2087
2088 2019-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2089
2090         [iOS] Multiple WKWebViewAutofillTests are flaky failures
2091         https://bugs.webkit.org/show_bug.cgi?id=189165
2092         <rdar://problem/47433765>
2093
2094         Reviewed by Tim Horton.
2095
2096         These tests are currently flaky because they expect an invocation of "Element.blur()" in the web process to
2097         immediately dispatch an IPC message to notify the UI process that the element has been blurred. In particular,
2098         the -textInputHasAutofillContext helper assumes that waiting for the next remote layer tree commit in the UI
2099         process in sufficient to ensure that any previous action that blurred the focused element in the web process
2100         would make its way to the UI process by the time the layer tree commit is finished.
2101
2102         However, WebPage::elementDidBlur sends its IPC message to the UI process asynchronously, using callOnMainThread.
2103         This means that if a layer tree flush was already scheduled in the web process before the element was blurred,
2104         the element blur IPC message to the UI process will lose the race against the layer tree commit, and the test
2105         will fail because it asks for -_autofillContext too early.
2106
2107         To fix this, we tweak these tests to actually wait until the intended input session change triggered by script
2108         is handled in the UI process.
2109
2110         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
2111
2112         Tweak some of these tests to wait for input session changes before checking for the presence of an autofill
2113         context. The only exception is an existing test that doesn't allow programmatic focus to begin input sessions
2114         by default; to fix this test, we simply wait for _WKInputDelegate to be invoked, instead of waiting for a new
2115         input session.
2116
2117         (-[AutofillTestView textInputHasAutofillContext]):
2118
2119         Remove the incorrect presentation update here. This helper now assumes that the UI process is up to date.
2120
2121         * TestWebKitAPI/cocoa/TestWKWebView.h:
2122         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2123         (nextInputSessionChangeCount):
2124
2125         Monotonically increasing identifier that's incremented whenever an input session is started in the UI process.
2126         This includes changing the focused element from one to another.
2127
2128         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
2129         (-[TestWKWebView didStartFormControlInteraction]):
2130         (-[TestWKWebView didEndFormControlInteraction]):
2131         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
2132
2133         Add a helper to evaluate JavaScript and wait for this script to cause some change in the input session. This
2134         handles three cases: (1) changing focus from an element that doesn't require an input session to one that does,
2135         (2) changing focus between elements that require input sessions, and (3) changing focus from an input session
2136         that doesn't require an input session to one that doesn't.
2137
2138 2019-01-22  David Kilzer  <ddkilzer@apple.com>
2139
2140         check-webkit-style reports false-positive whitespace/init warning in C++ initialization parameters
2141         <https://webkit.org/b/193676>
2142
2143         Reviewed by Alexey Proskuryakov.
2144
2145         * Scripts/webkitpy/style/checkers/cpp.py:
2146         (check_member_initialization_list):
2147         - Don't report missing whitespace around colon if the colon at
2148           the start of the line is formatted correctly.
2149         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2150         (WebKitStyleTest.test_member_initialization_list):
2151         - Add a test for a missing permutation of existing tests.
2152         - Add a test this false-positive.
2153         - Add blank lines between subtests to make them easier to read.
2154
2155 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
2156
2157         [build.webkit.org] Unit-test failure after r237113
2158         https://bugs.webkit.org/show_bug.cgi?id=193669
2159
2160         Reviewed by Michael Catanzaro.
2161
2162         * BuildSlaveSupport/build.webkit.org-config/factories.py:
2163         (Factory.__init__): Properly check for --no-experimental-features flag when additionalArguments has 
2164         multiple or zero flags.
2165
2166 2019-01-22  Tadeu Zagallo  <tzagallo@apple.com>
2167
2168         Cache bytecode to disk
2169         https://bugs.webkit.org/show_bug.cgi?id=192782
2170         <rdar://problem/46084932>
2171
2172         Reviewed by Keith Miller.
2173
2174         Add test helper to execute bytecode-cache tests: it executes each test
2175         twice, the first with JSC_diskCachePath set to a temporary directory
2176         and second with JSC_forceDiskCache=true (in addition to the cache path)
2177         to guarantee that only the disk cache is being used and no new
2178         UnlinkedCodeBlocks are being created.
2179
2180         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh: Added.
2181         * Scripts/run-jsc-stress-tests:
2182
2183 2019-01-22  Oriol Brufau  <obrufau@igalia.com>
2184
2185         [css-logical] Implement flow-relative margin, padding and border shorthands
2186         https://bugs.webkit.org/show_bug.cgi?id=188697
2187
2188         Reviewed by Simon Fraser and Antti Koivisto.
2189
2190         * DumpRenderTree/TestOptions.cpp:
2191         (TestOptions::TestOptions):
2192         * DumpRenderTree/TestOptions.h:
2193         * DumpRenderTree/mac/DumpRenderTree.mm:
2194         (setWebPreferencesForTestOptions):
2195         Allow tests to enable the CSSLogicalEnabled flag in WK1.
2196
2197         * Scripts/webkitpy/style/checkers/jsonchecker.py:
2198         (JSONCSSPropertiesChecker.check_codegen_properties):
2199         Allow CSS property definitions to have a 'runtime-flag' parameter which
2200         disables the property when the specified runtime flag is disabled.
2201
2202 2019-01-21  Fujii Hironori  <Hironori.Fujii@sony.com>
2203
2204         [GTK][WPE] libgcrypt-1.7.6 can't be compiled on Ubuntu 18.10
2205         https://bugs.webkit.org/show_bug.cgi?id=193643
2206
2207         Reviewed by Michael Catanzaro.
2208
2209         * gtk/jhbuild.modules: Bumped to libgcrypt-1.8.4.
2210         * wpe/jhbuild.modules: Ditto.
2211
2212 2019-01-21  Zalan Bujtas  <zalan@apple.com>
2213
2214         [LFC][Floats] Take float top position into account when computing containing block height.
2215         https://bugs.webkit.org/show_bug.cgi?id=193655
2216
2217         Reviewed by Antti Koivisto.
2218
2219         * LayoutReloaded/misc/LFC-passing-tests.txt:
2220
2221 2019-01-21  David Kilzer  <ddkilzer@apple.com>
2222
2223         Switch remaining VideoToolbox soft-linking in WebCore over to VideoToolboxSoftLink.{cpp,h}
2224         <https://webkit.org/b/193645>
2225         <rdar://problem/47421574>
2226
2227         Reviewed by Alex Christensen.
2228
2229         - Now checks for local soft-linking of all frameworks that have
2230           their own *SoftLinking.{cpp,h,mm} files.
2231         - Changes softlink/uikit warning to softlink/framework.
2232
2233         * Scripts/webkitpy/style/checkers/cpp.py:
2234         (check_language):
2235         (CppChecker):
2236         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2237         (CppStyleTest):
2238
2239 2019-01-20  Saam Barati  <sbarati@apple.com>
2240
2241         Rollout r240210: It broke tests on iOS
2242         https://bugs.webkit.org/show_bug.cgi?id=193640
2243
2244         Unreviewed.
2245
2246         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper:
2247         * Scripts/run-jsc-stress-tests:
2248
2249 2019-01-20  chris fleizach  <cfleizach@apple.com>
2250
2251         AX: Support returning relative frames for accessibility
2252         https://bugs.webkit.org/show_bug.cgi?id=193414
2253         <rdar://problem/47268501>
2254
2255         Reviewed by Zalan Bujtas.
2256
2257         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2258         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2259         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2260         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
2261         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2262         (WTR::attributesOfElement):
2263         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
2264
2265 2019-01-20  Yusuke Suzuki  <ysuzuki@apple.com>
2266
2267         Unreviewed, add my new email address
2268
2269         * Scripts/webkitpy/common/config/contributors.json:
2270
2271 2019-01-19  Zalan Bujtas  <zalan@apple.com>
2272
2273         [LFC][BFC] <body>'s overflow property value is propagated to viewport
2274         https://bugs.webkit.org/show_bug.cgi?id=193617
2275
2276         Reviewed by Antti Koivisto.
2277
2278         * LayoutReloaded/misc/LFC-passing-tests.txt:
2279
2280 2019-01-20  Michael Catanzaro  <mcatanzaro@igalia.com>
2281
2282         Unreviewed, rolling out r240209.
2283
2284         Broke GTK/WPE injected bundle
2285
2286         Reverted changeset:
2287
2288         "AX: Support returning relative frames for accessibility"
2289         https://bugs.webkit.org/show_bug.cgi?id=193414
2290         https://trac.webkit.org/changeset/240209
2291
2292 2019-01-12  Dan Bernstein  <mitz@apple.com>
2293
2294         [Cocoa] Avoid importing directly from subumbrella frameworks
2295         https://bugs.webkit.org/show_bug.cgi?id=186016
2296         <rdar://problem/40591038>
2297
2298         Reviewed by Sam Weinig.
2299
2300         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
2301           LaunchServices header.
2302         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
2303           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
2304         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
2305           when using SDKs earlier than 10.13.
2306         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
2307           and OTHER_CPLUSPLUSFLAGS.
2308         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
2309           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
2310         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
2311           LaunchServices header.
2312
2313 2019-01-20  Tadeu Zagallo  <tzagallo@apple.com>
2314
2315         Cache bytecode to disk
2316         https://bugs.webkit.org/show_bug.cgi?id=192782
2317         <rdar://problem/46084932>
2318
2319         Reviewed by Keith Miller.
2320
2321         Add test helper to execute bytecode-cache tests: it executes each test
2322         twice, the first with JSC_diskCachePath set to a temporary directory
2323         and second with JSC_forceDiskCache=true (in addition to the cache path)
2324         to guarantee that only the disk cache is being used and no new
2325         UnlinkedCodeBlocks are being created.
2326
2327         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper: Added.
2328         * Scripts/run-jsc-stress-tests:
2329
2330 2019-01-20  chris fleizach  <cfleizach@apple.com>
2331
2332         AX: Support returning relative frames for accessibility
2333         https://bugs.webkit.org/show_bug.cgi?id=193414
2334         <rdar://problem/47268501>
2335
2336         Reviewed by Zalan Bujtas.
2337
2338         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2339         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2340         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2341         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
2342         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2343         (WTR::attributesOfElement):
2344         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
2345
2346 2019-01-20  Antoine Quint  <graouts@apple.com>
2347
2348         Add a POINTER_EVENTS feature flag
2349         https://bugs.webkit.org/show_bug.cgi?id=193577
2350         <rdar://problem/47408511>
2351
2352         Unreviewed. Also enable Pointer Events for iosmac.
2353
2354         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2355
2356 2019-01-19  Zalan Bujtas  <zalan@apple.com>
2357
2358         [LFC][Floats] Ensure that floats in FloatingContext::m_floats are always horizontally ordered.
2359         https://bugs.webkit.org/show_bug.cgi?id=193613
2360
2361         Reviewed by Antti Koivisto.
2362
2363         * LayoutReloaded/misc/LFC-passing-tests.txt:
2364
2365 2019-01-19  Antoine Quint  <graouts@apple.com>
2366
2367         Add a POINTER_EVENTS feature flag
2368         https://bugs.webkit.org/show_bug.cgi?id=193577
2369
2370         Reviewed by Dean Jackson.
2371
2372         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2373
2374 2019-01-18  Zhifei FANG  <zhifei_fang@apple.com>
2375
2376         Disable the run-jsc-stress-test remote host key check [second round].
2377         https://bugs.webkit.org/show_bug.cgi?id=192988
2378
2379         Reviewed by Dewei Zhu.
2380
2381         * Scripts/run-jsc-stress-tests:
2382
2383 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
2384
2385         [build.webkit.org] unit-test failure Builder GTK Linux 32-bit Release doesn't exist
2386         https://bugs.webkit.org/show_bug.cgi?id=193597
2387
2388         Reviewed by Lucas Forschler.
2389
2390         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
2391
2392 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
2393
2394         [build.webkit.org] api tests failures are incorrectly named as unit test failures
2395         https://bugs.webkit.org/show_bug.cgi?id=193595
2396
2397         Reviewed by Lucas Forschler.
2398
2399         * BuildSlaveSupport/build.webkit.org-config/factories.py: Renamed RunUnitTests to RunAPITests.
2400         * BuildSlaveSupport/build.webkit.org-config/steps.py: Ditto.
2401         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Ditto.
2402
2403 2019-01-18  Chris Dumez  <cdumez@apple.com>
2404
2405         Regression(PSON) Content blockers are sometimes lost on back navigation cross-site
2406         https://bugs.webkit.org/show_bug.cgi?id=193588
2407         <rdar://problem/47131566>
2408
2409         Reviewed by Alex Christensen.
2410
2411         Add layout test coverage.
2412
2413         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2414
2415 2019-01-18  Jer Noble  <jer.noble@apple.com>
2416
2417         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
2418         https://bugs.webkit.org/show_bug.cgi?id=189553
2419
2420         Reviewed by Tim Horton.
2421
2422         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
2423
2424         * ContentExtensionTester/Configurations/Base.xcconfig:
2425         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
2426         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2427         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
2428         * ImageDiff/cg/Configurations/Base.xcconfig:
2429         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
2430         * MiniBrowser/Configurations/Base.xcconfig:
2431         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
2432         * MobileMiniBrowser/Configurations/Base.xcconfig:
2433         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
2434         * Scripts/webkitpy/style/checker.py:
2435         (_all_categories):
2436         (FileType):
2437         (CheckerDispatcher._file_type):
2438         (CheckerDispatcher._create_checker):
2439         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
2440         (SDKVariantChecker):
2441         (SDKVariantChecker.__init__):
2442         (SDKVariantChecker.check):
2443         * TestWebKitAPI/Configurations/Base.xcconfig:
2444         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
2445         * WebEditingTester/Configurations/Base.xcconfig:
2446         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
2447         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
2448         * WebKitTestRunner/Configurations/Base.xcconfig:
2449         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
2450         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
2451         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
2452
2453 2019-01-18  David Kilzer  <ddkilzer@apple.com>
2454
2455         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
2456         <https://webkit.org/b/193568>
2457         <rdar://problem/47381130>
2458
2459         Reviewed by Alex Christensen.
2460
2461         Make sure no one re-introduces UIKit soft-linking by adding a
2462         style rule.
2463
2464         * Scripts/webkitpy/style/checkers/cpp.py:
2465         (check_language): Add softlink/uikit check.
2466         (CppChecker): Enable softlink/uikit check.
2467         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2468         (CppStyleTest): Add test for softlink/uikit.
2469
2470 2019-01-18  Joanmarie Diggs  <jdiggs@igalia.com>
2471
2472         [GTK] install-dependencies tool looks for libunistring-dev for dnf
2473         https://bugs.webkit.org/show_bug.cgi?id=193584
2474
2475         Change "-dev" to "-devel".
2476
2477         Reviewed by Michael Catanzaro.
2478
2479         * gtk/install-dependencies:
2480
2481 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
2482
2483         webkitpy: Add iPhone and iPad ports
2484         https://bugs.webkit.org/show_bug.cgi?id=193537
2485         <rdar://problem/47353390>
2486
2487         Reviewed by Lucas Forschler.
2488
2489         Add --iphone-simulator and --ipad-simulator commands to run-webkit-tests which separate iPhone and iPad into separate
2490         ports. Note that this separation is optional, the --ios-simulator command remains.
2491
2492         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2493         (RunTest.test_device_type_test_division): Drive-by fix.
2494         (RunTest.test_device_type_specific_listing): Ditto.
2495         (RunTest.test_ipad_test_division):
2496         (RunTest):
2497         (RunTest.test_ipad_listing):
2498         * Scripts/webkitpy/port/factory.py:
2499         (platform_options): Add --iphone-simulator and --ipad-simulator flags.
2500         (PortFactory):
2501         * Scripts/webkitpy/port/ios_simulator.py:
2502         (IPhoneSimulatorPort):
2503         (IPadSimulatorPort):
2504
2505 2019-01-18  Chris Dumez  <cdumez@apple.com>
2506
2507         Regression(PSON) Scroll position is not always restored properly when navigating back
2508         https://bugs.webkit.org/show_bug.cgi?id=193578
2509         <rdar://problem/47386331>
2510
2511         Reviewed by Tim Horton.
2512
2513         Add API test coverage.
2514
2515         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2516
2517 2019-01-18  Youenn Fablet  <youenn@apple.com>
2518
2519         Add a new SPI to request for cache storage quota increase
2520         https://bugs.webkit.org/show_bug.cgi?id=193323
2521
2522         Reviewed by Alex Christensen.
2523
2524         Implement WebsiteDataStore quota delegate to handle quota requests.
2525         By default, do not update quota.
2526         Update quota if test calls the new testRunner.allowCacheStorageQuotaIncrease method.
2527
2528         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2529         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2530         (WTR::TestRunner::allowCacheStorageQuotaIncrease):
2531         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2532         * WebKitTestRunner/TestController.cpp:
2533         (WTR::TestController::allowCacheStorageQuotaIncrease):
2534         * WebKitTestRunner/TestController.h:
2535         * WebKitTestRunner/TestInvocation.cpp:
2536         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2537         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2538         (-[CacheStorageQuotaManager init]):
2539         (-[CacheStorageQuotaManager _requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
2540         (WTR::initializeWebViewConfiguration):
2541         (WTR::TestController::cocoaResetStateToConsistentValues):
2542         (WTR::TestController::allowCacheStorageQuotaIncrease):
2543
2544 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
2545
2546         [ews-build] Pass owner to the triggered builds
2547         https://bugs.webkit.org/show_bug.cgi?id=193574
2548
2549         Reviewed by Lucas Forschler.
2550
2551         * BuildSlaveSupport/ews-build/factories.py:
2552         (BuildFactory.propertiesToPassToTriggers):
2553
2554 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
2555
2556         [ews-app] Send patch author as a build property
2557         https://bugs.webkit.org/show_bug.cgi?id=193560
2558
2559         Reviewed by Lucas Forschler.
2560
2561         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2562         (BugzillaPatchFetcher.fetch):
2563
2564 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
2565
2566         webkitpy: Implement device type specific expected results (Follow-up fix)
2567         https://bugs.webkit.org/show_bug.cgi?id=192162
2568         <rdar://problem/46345449>
2569
2570         Unreviewed infrastructure fix.
2571
2572         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2573         (Manager.run): Don't boot a device if no tests are available to run on it.
2574
2575 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
2576
2577         webkitpy: Implement device type specific expected results (Follow-up fix)
2578         https://bugs.webkit.org/show_bug.cgi?id=192162
2579         <rdar://problem/46345449>
2580
2581         Unreviewed infrastructure fix.
2582
2583         * Scripts/webkitpy/api_tests/manager.py:
2584         (Manager._initialize_devices): Use DEVICE_TYPE when running API tests.
2585
2586 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
2587
2588         webkitpy: Implement device type specific expected results (Part 2)
2589         https://bugs.webkit.org/show_bug.cgi?id=192162
2590         <rdar://problem/46345449>
2591
2592         Rubber-stamped by Aakash Jain.
2593
2594         This change uses device_type to select a different set of TestExpectation files based on the type of device running
2595         tests. This requires multiple baseline search paths to be used in a single instantiation of run-webkit-tests. Note
2596         that while multiple baseline search paths are used, any single test will only ever be run on a single device type.
2597
2598         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
2599         (LayoutTestFinder.find_tests): Pass device_type through.
2600         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py:
2601         (LayoutTestFinderTests.test_touched_but_skipped_test): Allow device_type to be passed in.
2602         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2603         (Manager.__init__): Make _expectations an OrderedDict indexed by device_type, add current_device_type.
2604         (Manager._collect_tests): Pass device type to test finder.
2605         (Manager._needs_web_platform_test):
2606         (Manager._prepare_lists): Index _expectations by device type.
2607         (Manager._test_input_for_file):
2608         (Manager._test_is_slow): Ditto.
2609         (Manager._test_should_dump_jsconsolelog_in_stderr):
2610         (Manager._test_should_dump_jsconsolelog_in_stderr): Ditto.
2611         (Manager._get_test_inputs):
2612         (Manager._update_worker_count):
2613         (Manager._set_up_run): Use current_device_type instead of passing device_type in.
2614         (Manager.run): Re-write function to gather and parse expectations from multiple baseline search paths. In the event
2615         that a test can be run on multiple device types, the first device in the device type list which is eligible will be
2616         the one which runs the test.
2617         (Manager._run_test_subset):
2618         (Manager._run_tests): Index _expectations by current_device_type.
2619         (Manager._print_expectation_line_for_test): Ditto.
2620         (Manager._print_expectations_for_subset): Ditto.
2621         (Manager.print_expectations): Re-write function to gather and parse expectations from multiple baseline search paths.
2622         Unlike run, this function will behave the same regardless of what devices are available.
2623         (Manager._custom_device_for_test): Deleted.
2624         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2625         (ManagerTest.test_uses_custom_device): Deleted.
2626         (ManagerTest.test_uses_custom_device.get_manager): Deleted.
2627         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2628         (JSONLayoutResultsGenerator.__init__): Pass expectations as a dictionary indexed by device type.
2629         (JSONLayoutResultsGenerator._insert_failure_summaries): The number of fixable tests must take into consideration
2630         all of the expectations.
2631         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
2632         (FakePort.skipped_layout_tests): Allow device_type to be passed in.
2633         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2634         (TestExpectations.__init__): Allow device_type to be passed through.
2635         (TestExpectations.parse_all_expectations): Pick expectations_dict by device type.
2636         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Allow device_type to be passed in.
2637         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2638         (summarize_results):
2639         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
2640         (summarized_results): Expectations are stored in a dictionary indexed by device_type. When determining the expectation
2641         a test ran with, one must check all expectations to find the first non-skip expectation.
2642         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2643         (RunTest.test_device_type_test_division):
2644         (RunTest):
2645         (RunTest.test_device_type_specific_listing):
2646         * Scripts/webkitpy/port/base.py:
2647         (Port): Add default values for DEVICE_TYPE and DEFAULT_DEVICE_TYPES.
2648         (Port.supported_device_types): The result of this function will change based on what devices are available.
2649         * Scripts/webkitpy/port/device_port.py:
2650         (DevicePort._device_type_with_version): Replace DEFAULT_DEVICE_TYPE with DEVICE_TYPE.
2651         (DevicePort.default_child_processes): DEVICE_TYPE is a general type, so the built-in comparison of the DeviceType object
2652         can be used.
2653         (DevicePort.supported_device_types): Generates a list of device types determined by the available devices, if there are
2654         any, or the DEFAULT_DEVICE_TYPES of the port.
2655         * Scripts/webkitpy/port/ios.py:
2656         (IOSPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
2657         * Scripts/webkitpy/port/ios_simulator.py:
2658         (IOSSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the devices currently used to run layout tests.
2659         * Scripts/webkitpy/port/watch.py:
2660         (WatchPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
2661         * Scripts/webkitpy/port/watch_simulator.py:
2662         (WatchSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the device currently used to run layout tests.
2663         * Scripts/webkitpy/xcode/device_type.py:
2664         (DeviceType):
2665         (DeviceType.__hash__): Allow DeviceType to be used as a dictionary index.
2666
2667 2019-01-18  Philippe Normand  <pnormand@igalia.com>
2668
2669         [WPE] run-qt-wpe-minibrowser needlessly expects a --wpe argument
2670         https://bugs.webkit.org/show_bug.cgi?id=193575
2671
2672         Reviewed by Michael Catanzaro.
2673
2674         Allow the script to run without explicit port argument because
2675         it's specific to the WPE port anyway.
2676
2677         * Scripts/run-qt-wpe-minibrowser: Manually insert --wpe in argv
2678         and simplify the rest of the code accordingly.
2679
2680 2019-01-18  Charlie Turner  <cturner@igalia.com>
2681
2682         [GStreamer][EME][ClearKey] Request keys from CDMInstance rather than passing via bus messages
2683         https://bugs.webkit.org/show_bug.cgi?id=192229
2684
2685         Reviewed by Xabier Rodriguez-Calvar.
2686
2687         * MiniBrowser/wpe/main.cpp:
2688         (main): Enable encrypted-media by default.
2689
2690 2019-01-18  Philippe Normand  <pnormand@igalia.com>
2691
2692         [Flatpak] Missing KeyboardInterrupt exception handler
2693         https://bugs.webkit.org/show_bug.cgi?id=193570
2694
2695         Reviewed by Michael Catanzaro.
2696
2697         * flatpak/flatpakutils.py:
2698         (WebkitFlatpak.run_in_sandbox): Basic KeyboardInterrupt handling.
2699
2700 2019-01-18  Zalan Bujtas  <zalan@apple.com>
2701
2702         [LFC][BFC][MarginCollapsing] Collapsing through should not ignore floats.
2703         https://bugs.webkit.org/show_bug.cgi?id=193564
2704
2705         Reviewed by Antti Koivisto.
2706
2707         * LayoutReloaded/misc/LFC-passing-tests.txt:
2708
2709 2019-01-18  Zalan Bujtas  <zalan@apple.com>
2710
2711         [LFC] Do not skip float boxes that are not part of the current formatting context when computing bottom.
2712         https://bugs.webkit.org/show_bug.cgi?id=193562
2713
2714         Reviewed by Antti Koivisto.
2715
2716         * LayoutReloaded/misc/LFC-passing-tests.txt:
2717
2718 2019-01-18  Zalan Bujtas  <zalan@apple.com>
2719
2720         [LFC][BFC] Check for inflow children while computing height for block formatting context roots.
2721         https://bugs.webkit.org/show_bug.cgi?id=193555
2722
2723         Reviewed by Antti Koivisto.
2724
2725         * LayoutReloaded/misc/LFC-passing-tests.txt:
2726
2727 2019-01-18  Philippe Normand  <pnormand@igalia.com>
2728
2729         [WPE] Add Qt extension
2730         https://bugs.webkit.org/show_bug.cgi?id=191464
2731
2732         Reviewed by Carlos Garcia Campos.
2733
2734         MiniBrowser and API tests for the WPE Qt API. To run the
2735         MiniBrowser a new script is introduced. Example invocation:
2736
2737         $ run-qt-wpe-minibrowser -platform wayland https://webkit.org
2738
2739         Also note-worthy is the introduction of the python2-subprocess32
2740         dependency to run the GLib API tests.
2741
2742         * MiniBrowser/wpe/CMakeLists.txt:
2743         * MiniBrowser/wpe/qt/CMakeLists.txt: Added.
2744         * MiniBrowser/wpe/qt/main.cpp: Added.
2745         (main):
2746         * MiniBrowser/wpe/qt/main.qml: Added.
2747         * MiniBrowser/wpe/qt/qml.qrc: Added.
2748         * Scripts/run-gtk-tests:
2749         (GtkTestRunner.is_google_test):
2750         (GtkTestRunner):
2751         (GtkTestRunner.is_qt_test):
2752         * Scripts/run-qt-wpe-minibrowser: Added.
2753         * Scripts/run-wpe-tests:
2754         (WPETestRunner):
2755         (WPETestRunner.is_google_test):
2756         (WPETestRunner.is_qt_test):
2757         * TestWebKitAPI/Tests/WPEQt/TestLoad.cpp: Added.
2758         (TestLoad::main):
2759         * TestWebKitAPI/Tests/WPEQt/TestLoadHtml.cpp: Added.
2760         (TestLoadHtml::main):
2761         * TestWebKitAPI/Tests/WPEQt/TestLoadRequest.cpp: Added.
2762         (TestLoadRequest::main):
2763         * TestWebKitAPI/Tests/WPEQt/TestRunJavaScript.cpp: Added.
2764         (TestRunJavaScript::main):
2765         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.cpp: Added.
2766         (waitForSignal):
2767         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.h: Added.
2768         (LoadSpy::LoadSpy):
2769         (LoadSpy::~LoadSpy):
2770         (LoadSpy::onLoadingChanged):
2771         (LoadStartedCatcher::LoadStartedCatcher):
2772         (LoadStartedCatcher::~LoadStartedCatcher):
2773         (LoadStartedCatcher::onLoadingChanged):
2774         (waitForLoadSucceeded):
2775         (waitForLoadFailed):
2776         * TestWebKitAPI/glib/CMakeLists.txt:
2777         * flatpak/flatpakutils.py:
2778         (WebkitFlatpak.load_from_args):
2779         (WebkitFlatpak.__init__):
2780         (WebkitFlatpak.clean_args):
2781         (WebkitFlatpak.run_in_sandbox):
2782         * flatpak/org.webkit.CommonModules.yaml:
2783         * flatpak/org.webkit.WPE.yaml:
2784         * flatpak/org.webkit.WPEModules.yaml:
2785         * flatpak/org.webkit.WPEQT.yaml: Copied from Tools/flatpak/org.webkit.WebKit.yaml.
2786         * flatpak/org.webkit.WebKit.yaml:
2787         * glib/api_test_runner.py:
2788         (TestRunner._run_test_qt):
2789         (TestRunner.is_qt_test):
2790         (TestRunner._run_test):
2791
2792 2019-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
2793
2794         [iOS] Content offset jumps erratically when autoscrolling near scroll view content inset areas
2795         https://bugs.webkit.org/show_bug.cgi?id=193494
2796         <rdar://problem/46859627>
2797
2798         Reviewed by Simon Fraser and Tim Horton.
2799
2800         Add a new test option to add a top content inset to the test runner's WKWebView's scroll view, and automatically
2801         scroll to reveal this top content inset area when beginning the test (i.e., scroll to (0, -topContentInset)).
2802
2803         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2804         (WTR::UIScriptController::contentOffsetX const):
2805         (WTR::UIScriptController::contentOffsetY const):
2806         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2807         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2808         (WTR::UIScriptController::contentOffsetX const):
2809         (WTR::UIScriptController::contentOffsetY const):
2810         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2811
2812         Also add new UIScriptController methods to ask for the content offset of the platform scroll view.
2813
2814         * WebKitTestRunner/TestController.cpp:
2815         (WTR::updateTestOptionsFromTestHeader):
2816         * WebKitTestRunner/TestOptions.h:
2817         (WTR::TestOptions::hasSameInitializationOptions const):
2818         * WebKitTestRunner/ios/TestControllerIOS.mm:
2819         (WTR::TestController::platformResetStateToConsistentValues):
2820         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2821         (WTR::UIScriptController::contentOffsetX const):
2822         (WTR::UIScriptController::contentOffsetY const):
2823
2824 2019-01-17  Truitt Savell  <tsavell@apple.com>
2825
2826         Unreviewed, rolling out r240124.
2827
2828         This commit broke an internal build.
2829
2830         Reverted changeset:
2831
2832         "SDK_VARIANT build destinations should be separate from non-
2833         SDK_VARIANT builds"
2834         https://bugs.webkit.org/show_bug.cgi?id=189553
2835         https://trac.webkit.org/changeset/240124
2836
2837 2019-01-17  Alex Christensen  <achristensen@webkit.org>
2838
2839         Fix string concatenation API test after r239920
2840         https://bugs.webkit.org/show_bug.cgi?id=193551
2841         <rdar://problem/47359304>
2842
2843         Reviewed by Youenn Fablet.
2844
2845         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
2846         (TestWebKitAPI::TEST):
2847         Cocoa platforms' interpretation of UChar/unsigned short equality is not affected by ICU's recent change of UChar's type
2848         in WebKit's build configuration like it apparently is on Linux.
2849
2850 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
2851
2852         [ews-build] validate-patch should handle the case when bug_id is None
2853         https://bugs.webkit.org/show_bug.cgi?id=193547
2854
2855         Reviewed by Lucas Forschler.
2856
2857         * BuildSlaveSupport/ews-build/steps.py:
2858         (ValidatePatch._is_bug_closed): Gracefully handle the case when bug_id is None.
2859         (ValidatePatch.start): If bug_id is set as None in build properties, fetch it from the patch.
2860
2861 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
2862
2863         [ews-build] Add patch author information in build
2864         https://bugs.webkit.org/show_bug.cgi?id=193465
2865
2866         Reviewed by Lucas Forschler.
2867
2868         * BuildSlaveSupport/ews-build/steps.py:
2869         (ValidatePatch._is_patch_obsolete):
2870
2871 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
2872
2873         [ews-build] Pass bug_id to the triggered builds
2874         https://bugs.webkit.org/show_bug.cgi?id=193548
2875
2876         Reviewed by Lucas Forschler.
2877
2878         * BuildSlaveSupport/ews-build/factories.py:
2879         (BuildFactory.propertiesToPassToTriggers):
2880
2881 2019-01-17  Jer Noble  <jer.noble@apple.com>
2882
2883         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
2884         https://bugs.webkit.org/show_bug.cgi?id=189553
2885
2886         Reviewed by Tim Horton.
2887
2888         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
2889
2890         * ContentExtensionTester/Configurations/Base.xcconfig:
2891         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
2892         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2893         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
2894         * ImageDiff/cg/Configurations/Base.xcconfig:
2895         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
2896         * MiniBrowser/Configurations/Base.xcconfig:
2897         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
2898         * MobileMiniBrowser/Configurations/Base.xcconfig:
2899         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
2900         * Scripts/webkitpy/style/checker.py:
2901         (_all_categories):
2902         (FileType):
2903         (CheckerDispatcher._file_type):
2904         (CheckerDispatcher._create_checker):
2905         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
2906         (SDKVariantChecker):
2907         (SDKVariantChecker.__init__):
2908         (SDKVariantChecker.check):
2909         * TestWebKitAPI/Configurations/Base.xcconfig:
2910         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
2911         * WebEditingTester/Configurations/Base.xcconfig:
2912         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
2913         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
2914         * WebKitTestRunner/Configurations/Base.xcconfig:
2915         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
2916         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
2917         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
2918
2919 2019-01-17  Zalan Bujtas  <zalan@apple.com>
2920
2921         [LFC][BFC] An element with transform is a containing block for positioned descendants.
2922         https://bugs.webkit.org/show_bug.cgi?id=193534
2923
2924         Reviewed by Antti Koivisto.
2925
2926         * LayoutReloaded/misc/LFC-passing-tests.txt:
2927
2928 2019-01-17  Zalan Bujtas  <zalan@apple.com>
2929
2930         [LFC][BFC][Quirk] Take body padding and border into account when stretching height.
2931         https://bugs.webkit.org/show_bug.cgi?id=193528
2932
2933         Reviewed by Antti Koivisto.
2934
2935         * LayoutReloaded/misc/LFC-passing-tests.txt:
2936
2937 2019-01-17  Zalan Bujtas  <zalan@apple.com>
2938
2939         [LFC][BFC] For height computation, the bottom edge of the last line box value should include top border/padding
2940         https://bugs.webkit.org/show_bug.cgi?id=193520
2941
2942         Reviewed by Antti Koivisto.
2943
2944         * LayoutReloaded/misc/LFC-passing-tests.txt:
2945
2946 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
2947
2948         [ews-build] unapply-patch step should not update source
2949         https://bugs.webkit.org/show_bug.cgi?id=193234
2950
2951         Reviewed by Lucas Forschler.
2952
2953         * BuildSlaveSupport/ews-build/steps.py:
2954         (CleanWorkingDirectory): Use clean-webkit script to clean the working directory.
2955         (UnApplyPatchIfRequired): Use CleanWorkingDirectory as base class.
2956
2957 2019-01-16  Youenn Fablet  <youenn@apple.com>
2958
2959         Add a new SPI for controlling getUserMedia
2960         https://bugs.webkit.org/show_bug.cgi?id=192793
2961
2962         Reviewed by Eric Carlson.
2963
2964         * MiniBrowser/mac/WK2BrowserWindowController.m:
2965         (-[WK2BrowserWindowController _webView:requestUserMediaAuthorizationForFrame:devices:decisionHandler:]):
2966         (-[WK2BrowserWindowController _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
2967         * TestWebKitAPI/Tests/WebKit/GetUserMediaNavigation.mm:
2968         (-[NavigationWhileGetUserMediaPromptDisplayedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
2969         * TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm:
2970         (-[GetUserMediaRepromptUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
2971         * TestWebKitAPI/Tests/WebKit/MediaStreamTrackDetached.mm:
2972         (-[MediaStreamTrackDetachedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
2973         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
2974         (-[UserMediaUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
2975         (-[UserMediaUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
2976         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaSimulateFailedSandbox.mm:
2977         (-[SimulateFailedSandboxUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
2978         (-[SimulateFailedSandboxUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
2979
2980 2019-01-16  Zalan Bujtas  <zalan@apple.com>
2981
2982         [LFC][BFC] Inflow non-replaced used width should not be negative.
2983         https://bugs.webkit.org/show_bug.cgi?id=193495
2984
2985         Reviewed by Antti Koivisto.
2986
2987         * LayoutReloaded/misc/LFC-passing-tests.txt:
2988
2989 2019-01-16  Chris Dumez  <cdumez@apple.com>
2990
2991         Regression(PSON) View becomes blank after click a cross-site download link
2992         https://bugs.webkit.org/show_bug.cgi?id=193361
2993         <rdar://problem/47099573>
2994
2995         Reviewed by Geoffrey Garen.
2996
2997         Add API test coverage.
2998
2999         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3000         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3001
3002 2019-01-16  Zalan Bujtas  <zalan@apple.com>
3003
3004         [LFC][Out-of-flow] Set used vertical margin values when top/height/bottom are non-auto.
3005         https://bugs.webkit.org/show_bug.cgi?id=193470
3006
3007         Reviewed by Antti Koivisto.
3008
3009         * LayoutReloaded/misc/LFC-passing-tests.txt:
3010
3011 2019-01-16  Zalan Bujtas  <zalan@apple.com>
3012
3013         [LFC] Adjust margin box verification.
3014         https://bugs.webkit.org/show_bug.cgi?id=193482
3015
3016         Reviewed by Antti Koivisto.
3017
3018         * LayoutReloaded/misc/LFC-passing-tests.txt:
3019
3020 2019-01-15  Sihui Liu  <sihui_liu@apple.com>
3021
3022         Fix API test WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming after 193354
3023         https://bugs.webkit.org/show_bug.cgi?id=193451
3024
3025         Reviewed by Geoffrey Garen.
3026
3027         * TestWebKitAPI/Tests/WebKitCocoa/DuplicateCompletionHandlerCalls.mm:
3028         (TEST):
3029         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3030         (runWebsiteDataStoreCustomPaths):
3031
3032 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
3033
3034         webkitpy: Support boolean simctl isAvailable
3035         https://bugs.webkit.org/show_bug.cgi?id=193472
3036         <rdar://problem/47296150>
3037
3038         Reviewed by Ryosuke Niwa.
3039
3040         * Scripts/webkitpy/xcode/simulated_device.py:
3041         (SimulatedDeviceManager._create_runtimes):
3042         (SimulatedDeviceManager._create_device_with_runtime):
3043
3044 2019-01-15  Chris Dumez  <cdumez@apple.com>
3045
3046         Unreviewed, rolling out r239993, r239995, r239997, and
3047         r239999.
3048
3049         Caused assertions under
3050         ViewGestureController::disconnectFromProcess()
3051
3052         Reverted changesets:
3053
3054         "Regression(PSON) View becomes blank after click a cross-site
3055         download link"
3056         https://bugs.webkit.org/show_bug.cgi?id=193361
3057         https://trac.webkit.org/changeset/239993
3058
3059         "Unreviewed iOS build fix after r239993."
3060         https://trac.webkit.org/changeset/239995
3061
3062         "Fix iOS build after r239993"
3063         https://bugs.webkit.org/show_bug.cgi?id=193361
3064         https://trac.webkit.org/changeset/239997
3065
3066         "Unreviewed, revert part of r239997 as it is not needed to fix
3067         the build."
3068         https://trac.webkit.org/changeset/239999
3069
3070 2019-01-15  Tim Horton  <timothy_horton@apple.com>
3071
3072         Cannot tab out of WKWebView on macOS
3073         https://bugs.webkit.org/show_bug.cgi?id=161448
3074         <rdar://problem/28100085>
3075
3076         Reviewed by Dean Jackson.
3077
3078         Add a test that tabbing into and out of WKWebView works correctly.
3079
3080         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3081         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
3082         (WebKit2_CommandBackForwardTest::SetUp):
3083         (-[CommandBackForwardOffscreenWindow isKeyWindow]): Deleted.
3084         (-[CommandBackForwardOffscreenWindow isVisible]): Deleted.
3085         * TestWebKitAPI/Tests/WebKitCocoa/TabOutOfWebView.mm: Added.
3086         (-[FocusableView canBecomeKeyView]):
3087         (TEST):
3088         * TestWebKitAPI/mac/OffscreenWindow.h: Added.
3089         * TestWebKitAPI/mac/OffscreenWindow.mm: Added.
3090         (-[OffscreenWindow initWithSize:]):
3091         (-[OffscreenWindow isKeyWindow]):
3092         (-[OffscreenWindow isVisible]):
3093         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3094         (TestWebKitAPI::PlatformWebView::initialize):
3095         (-[ActiveOffscreenWindow isKeyWindow]): Deleted.
3096         (-[ActiveOffscreenWindow isVisible]): Deleted.
3097         Factor ActiveOffscreenWindow out into OffscreenWindow and share it.
3098
3099 2019-01-15  Ryan Haddad  <ryanhaddad@apple.com>
3100
3101         Adjust the arguments passed to run-javascriptcore-tests for the 32-bit JSC bot
3102         https://bugs.webkit.org/show_bug.cgi?id=193459
3103
3104         Reviewed by Mark Lam.
3105
3106         * BuildSlaveSupport/build.webkit.org-config/steps.py:
3107         (Run32bitJSCTests): This queue should not run JIT, testair, testb3, or testmasm.
3108
3109 2019-01-15  Chris Dumez  <cdumez@apple.com>
3110
3111         Regression(PSON) View becomes blank after click a cross-site download link
3112         https://bugs.webkit.org/show_bug.cgi?id=193361
3113         <rdar://problem/47099573>
3114
3115         Reviewed by Geoff Garen.
3116
3117         Add API test coverage.
3118
3119         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3120         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3121
3122 2019-01-15  Zalan Bujtas  <zalan@apple.com>
3123
3124         [LFC][Out-of-flow] Ignore bottom when the vertical values are over-constrained
3125         https://bugs.webkit.org/show_bug.cgi?id=193448
3126
3127         Reviewed by Antti Koivisto.
3128
3129         * LayoutReloaded/misc/LFC-passing-tests.txt:
3130
3131 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
3132
3133         webkitpy: Implement device type specific expected results (Part 1)
3134         https://bugs.webkit.org/show_bug.cgi?id=192162
3135
3136         Reviewed by Lucas Forschler.
3137
3138         Device type specific expected results covers two related ideas. The first (covered by this change)
3139         is where to search for -expected.* files. The second is which tests to run based on the
3140         TestExpectations.txt file.
3141
3142         After this change, the baseline search path will be determined by the type of device running a
3143         test. Device type will be passed into any function which picks a file based on the baseline search
3144         path.
3145
3146         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
3147         (Worker._update_test_input): Pass device_type to self._port.reference_files(...).
3148         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3149         (Manager.run): Print baseline search path for each round of devices.
3150         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3151         (SingleTestRunner.__init__): Pass device_type into expected_*(...).
3152         (SingleTestRunner._expected_driver_output): Ditto.
3153         (SingleTestRunner._driver_input): Ditto.
3154         * Scripts/webkitpy/layout_tests/views/printing.py:
3155         (Printer.print_config): Move printing of baseline search path to a separate function.
3156         (Printer.print_baseline_search_path): Moved from Printer.print_config.
3157         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3158         (Testprinter.test_print_config):
3159         (Testprinter.test_print_baseline_search_path):
3160         * Scripts/webkitpy/port/base.py:
3161         (Port.baseline_search_path): Pass device_type through.
3162         (Port._expected_baselines_for_suffixes): Ditto.
3163         (Port.expected_baselines): Ditto.
3164         (Port.expected_filename): Ditto.
3165         (Port.expected_checksum): Ditto.
3166         (Port.expected_image): Ditto.
3167         (Port.expected_audio): Ditto.
3168         (Port.expected_text): Ditto.
3169         (Port.reference_files): Ditto.
3170         (Port.tests): Ditto.
3171         (Port._expanded_paths): Ditto.
3172         (Port.skipped_layout_tests): Ditto.
3173         (Port.expectations_dict): Ditto.
3174         (Port._port_specific_expectations_files): Ditto.
3175         (Port.expectations_files): Ditto.
3176         (Port.test_search_path): Ditto.
3177         (Port._tests_for_other_platforms): Ditto.
3178         * Scripts/webkitpy/port/base_unittest.py:
3179         (PortTest.test_additional_platform_directory): Accept, but do not use, device_type.
3180         (PortTest.test_nonexistant_expectations): Ditto.
3181         (test_ref_tests_platform_directory): Ditto.
3182         * Scripts/webkitpy/port/darwin.py:
3183         (DarwinPort._port_specific_expectations_files): Accept device_type.
3184         * Scripts/webkitpy/port/driver.py:
3185         (DriverProxy):
3186         (DriverProxy.host): Expose _target_host for device_type information.
3187         * Scripts/webkitpy/port/gtk.py:
3188         (GtkPort._port_specific_expectations_files): Accept, but do not use, device_type.
3189         * Scripts/webkitpy/port/ios.py:
3190         (IOSPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
3191         * Scripts/webkitpy/port/mac.py:
3192         (MacPort. default_baseline_search_path): Ditto.
3193         * Scripts/webkitpy/port/port_testcase.py:
3194         (TestWebKitPort._tests_for_other_platforms): Accept, but do not use, device_type.
3195         * Scripts/webkitpy/port/test.py:
3196         * Scripts/webkitpy/port/watch.py:
3197         (WatchPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
3198         * Scripts/webkitpy/port/win.py:
3199         (WinPort.test_search_path): Accept, but do not use, device_type.
3200         * Scripts/webkitpy/port/wpe.py:
3201         (WPEPort._port_specific_expectations_files): Ditto.
3202         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
3203         (get_test_baselines.AllPlatformsPort.baseline_search_path): Ditto.
3204
3205 2019-01-15  Zalan Bujtas  <zalan@apple.com>
3206
3207         [LFC] Use the containing block's padding box to position out-of-flow elements.
3208         https://bugs.webkit.org/show_bug.cgi?id=193431
3209
3210         Reviewed by Antti Koivisto.
3211
3212         * LayoutReloaded/misc/LFC-passing-tests.txt:
3213
3214 2019-01-14  Tim Horton  <timothy_horton@apple.com>
3215
3216         Move a test implementation file that got misplaced in the Xcode project
3217
3218         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3219
3220 2019-01-14  Commit Queue  <commit-queue@webkit.org>
3221
3222         Unreviewed, rolling out r239901, r239909, r239910, r239912,
3223         r239913, and r239914.
3224         https://bugs.webkit.org/show_bug.cgi?id=193407
3225
3226         These revisions caused an internal failure (Requested by
3227         Truitt on #webkit).
3228
3229         Reverted changesets:
3230
3231         "[Cocoa] Avoid importing directly from subumbrella frameworks"
3232         https://bugs.webkit.org/show_bug.cgi?id=186016
3233         https://trac.webkit.org/changeset/239901
3234
3235         "Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901."
3236         https://trac.webkit.org/changeset/239909
3237
3238         "Tried to fix the build."
3239         https://trac.webkit.org/changeset/239910
3240
3241         "Fixed iOS builds after r239910."
3242         https://trac.webkit.org/changeset/239912
3243
3244         "More build fixing."
3245         https://trac.webkit.org/changeset/239913
3246
3247         "Tried to fix USE(APPLE_INTERNAL_SDK) 32-bit builds."
3248         https://trac.webkit.org/changeset/239914
3249
3250 2019-01-14  Mark Lam  <mark.lam@apple.com>
3251
3252         Re-enable ability to build --cloop builds.
3253         https://bugs.webkit.org/show_bug.cgi?id=192955
3254         <rdar://problem/46882363>
3255
3256         Reviewed by Saam barati and Keith Miller.
3257
3258         The --cloop build option was being ignored this whole time since r236381.
3259         This patch makes it possible to build CLoop builds again.
3260
3261         * Scripts/build-jsc:
3262         * Scripts/webkitperl/FeatureList.pm:
3263         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3264
3265 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
3266
3267         webkitpy: Expose device_type from host-like objects
3268         https://bugs.webkit.org/show_bug.cgi?id=193406
3269         <rdar://problem/47262305>
3270
3271         Reviewed by Lucas Forschler.
3272
3273         Devices should expose device_type. As a result, all host objects should
3274         provide a device_type property, even if they do not yet define a device_type.
3275
3276         * Scripts/webkitpy/common/system/systemhost.py:
3277         (SystemHost):
3278         (SystemHost.device_type):
3279         * Scripts/webkitpy/common/system/systemhost_mock.py:
3280         (MockSystemHost):
3281         (MockSystemHost.device_type):
3282         * Scripts/webkitpy/port/device.py:
3283         (Device):
3284         (Device.device_type):
3285         * Scripts/webkitpy/xcode/simulated_device.py:
3286         (SimulatedDeviceManager._find_exisiting_device_for_request):
3287         (SimulatedDeviceManager._disambiguate_device_type):
3288         (SimulatedDeviceManager._does_fulfill_request):
3289         (SimulatedDeviceManager.device_count_for_type):
3290         (SimulatedDeviceManager.initialize_devices):
3291         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
3292         (test_available_devices):
3293         (test_swapping_devices):
3294
3295 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
3296
3297         webkitpy: Support alternate simctl device list output (Follow-up fix)
3298         https://bugs.webkit.org/show_bug.cgi?id=193362
3299         <rdar://problem/47122965>
3300
3301         Rubber-stamped by Lucas Forschler.
3302
3303         * Scripts/webkitpy/xcode/simulated_device.py:
3304         (SimulatedDeviceManager.populate_available_devices):
3305
3306 2019-01-14  Wenson Hsieh  <wenson_hsieh@apple.com>
3307
3308         [iOS] Expose SPI to access the current sentence boundary and selection state
3309         https://bugs.webkit.org/show_bug.cgi?id=193398
3310         <rdar://problem/45893108>
3311
3312         Reviewed by Dean Jackson.
3313
3314         Add an API test to verify that an SPI client can observe changes in the `@"_selectionAttributes"` key path on
3315         WKWebView, and that inserting text, deleting, and changing the selection cause selection attributes to change as
3316         expected.
3317
3318         * TestWebKitAPI/EditingTestHarness.h:
3319         * TestWebKitAPI/EditingTestHarness.mm:
3320         (-[EditingTestHarness moveBackward]):
3321         (-[EditingTestHarness moveForward]):
3322         (-[EditingTestHarness moveForwardAndExpectEditorStateWith:]):
3323
3324         Add a couple of new helper methods on EditingTestHarness.
3325
3326         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
3327         (-[SelectionChangeObserver initWithWebView:]):
3328         (-[SelectionChangeObserver webView]):
3329         (-[SelectionChangeObserver observeValueForKeyPath:ofObject:change:context:]):
3330         (-[SelectionChangeObserver currentSelectionAttributes]):
3331
3332 2019-01-14  Zalan Bujtas  <zalan@apple.com>
3333
3334         [LFC][BFC] Add basic box-sizing support.
3335         https://bugs.webkit.org/show_bug.cgi?id=193392
3336
3337         Reviewed by Antti Koivisto.
3338
3339         * LayoutReloaded/misc/LFC-passing-tests.txt:
3340
3341 2019-01-14  Charlie Turner  <cturner@igalia.com>
3342
3343         [WPE] API test gardening
3344         https://bugs.webkit.org/show_bug.cgi?id=193319
3345
3346         Reviewed by Michael Catanzaro.
3347
3348         * TestWebKitAPI/glib/TestExpectations.json: Remove some now
3349         passing tests.
3350
3351 2019-01-14  Charlie Turner  <cturner@igalia.com>
3352
3353         [GStreamer] Add sharedBuffer utility to GstMappedBuffer, and a testsuite
3354         https://bugs.webkit.org/show_bug.cgi?id=192977
3355
3356         Reviewed by Carlos Garcia Campos.
3357
3358         * TestWebKitAPI/PlatformGTK.cmake: Build the new GStreamer test harness
3359         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
3360         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.cpp: Added.
3361         (TestWebKitAPI::GStreamerTest::SetUp):
3362         (TestWebKitAPI::GStreamerTest::TearDown):
3363         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.h: Added.
3364         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp: Added.
3365         (TestWebKitAPI::TEST_F):
3366
3367 2019-01-14  Charlie Turner  <cturner@igalia.com>
3368
3369         [WPE] Workaround for incorrect template specialization being selected when UChar=char16_t
3370         https://bugs.webkit.org/show_bug.cgi?id=193332
3371
3372         Reviewed by Michael Catanzaro.
3373
3374         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: When UChar is
3375         defined as a char16_t, which changed in ICU 59, the
3376         StringTypeAdapter<UnsignedInt, ...> overload catches casts to
3377         unsigned short. This test is relying on the behaviour that
3378         UChar=unsigned short, which doesn't hold across platforms and ICU
3379         library versions. The full fix would be a special syntax for
3380         literal characters so that these ambiguities do not arise. That
3381         work is proposed in https://bugs.webkit.org/show_bug.cgi?id=193101.
3382         (TestWebKitAPI::TEST):
3383
3384 2019-01-14  Carlos Garcia Campos  <cgarcia@igalia.com>
3385
3386         Unreviewed. [GTK][WPE] Run distcheck with gtkdoc and MiniBrowser enabled
3387
3388         * Scripts/make-dist:
3389         (Distcheck.configure):
3390
3391 2019-01-13  Aakash Jain  <aakash_jain@apple.com>
3392
3393         [ews-build] Update macOS queue configurations
3394         https://bugs.webkit.org/show_bug.cgi?id=193365
3395         <rdar://problem/47221073>
3396
3397         Unreviewed, renamed mac-high-sierra to mac-highsierra to match with build.webkit.org configuration.
3398
3399         * BuildSlaveSupport/ews-build/config.json:
3400
3401 2019-01-13  Zalan Bujtas  <zalan@apple.com>
3402
3403         [LFC] Adjust assert for statically positioned fixed elements
3404         https://bugs.webkit.org/show_bug.cgi?id=193385
3405
3406         Reviewed by Antti Koivisto.
3407
3408         * LayoutReloaded/misc/LFC-passing-tests.txt:
3409
3410 2019-01-13  Philippe Normand  <pnormand@igalia.com>
3411
3412         [WPE][MiniBrowser] Ephemeral WebContext leaks in automation mode
3413         https://bugs.webkit.org/show_bug.cgi?id=193387
3414
3415         Reviewed by Carlos Garcia Campos.
3416
3417         * MiniBrowser/wpe/main.cpp:
3418         (main):
3419
3420 2019-01-12  Timothy Hatcher  <timothy@apple.com>
3421
3422         Have prefers-color-scheme: light always match on macOS versions before Mojave.
3423         https://bugs.webkit.org/show_bug.cgi?id=191655
3424         rdar://problem/46074680
3425
3426         Reviewed by Megan Gardner.
3427
3428         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions.
3429         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
3430
3431 2019-01-12  Dan Bernstein  <mitz@apple.com>
3432
3433         [Cocoa] Avoid importing directly from subumbrella frameworks
3434         https://bugs.webkit.org/show_bug.cgi?id=186016
3435         <rdar://problem/40591038>
3436
3437         Reviewed by Sam Weinig.
3438
3439         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
3440           LaunchServices header.
3441         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
3442           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
3443         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
3444           when using SDKs earlier than 10.13.
3445         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
3446           and OTHER_CPLUSPLUSFLAGS.
3447         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
3448           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
3449         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
3450           LaunchServices header.
3451
3452 2019-01-11  John Wilander  <wilander@apple.com>
3453
3454         Compile out Web API Statistics Collection
3455         https://bugs.webkit.org/show_bug.cgi?id=193370
3456         <rdar://problem/45388584>
3457
3458         Reviewed by Brent Fulgham.
3459
3460         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3461             Defined ENABLE_WEB_API_STATISTICS, off by default.
3462
3463 2019-01-11  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
3464
3465         [WPE] Add gtk-doc
3466         https://bugs.webkit.org/show_bug.cgi?id=178900
3467
3468         Reviewed by Michael Catanzaro.
3469
3470         Add Tools/gtkdoc to manifest.txt.in files.
3471         This should have been done in r238853 and caused failure in building WebKitGTK+ unstable release 2.23.2.
3472
3473         * gtk/manifest.txt.in: Add Tools/gtkdoc directory.
3474         * wpe/manifest.txt.in: Add Tools/gtkdoc directory and uncomment lines to move documentation artifacts.
3475
3476 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
3477
3478         [iOS] Precision drop state thrashes when dragging near the top edge of an editable element
3479         https://bugs.webkit.org/show_bug.cgi?id=193364
3480         <rdar://problem/47214117>
3481
3482         Reviewed by Tim Horton.
3483
3484         Add a test to verify that dragging near the top of a textarea element does not flag the drop proposal as
3485         precise, whereas dragging near the middle of the textarea does.
3486
3487         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3488         (TestWebKitAPI::TEST):
3489
3490 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
3491
3492         webkitpy: Support alternate simctl device list output
3493         https://bugs.webkit.org/show_bug.cgi?id=193362
3494         <rdar://problem/47122965>
3495
3496         Reviewed by Lucas Forschler.
3497
3498         * Scripts/webkitpy/xcode/simulated_device.py:
3499         (SimulatedDeviceManager.populate_available_devices):
3500
3501 2019-01-11  Aakash Jain  <aakash_jain@apple.com>
3502
3503         [ews-build] Update macOS queue configurations
3504         https://bugs.webkit.org/show_bug.cgi?id=193365
3505
3506         Reviewed by Lucas Forschler.
3507
3508         * BuildSlaveSupport/ews-build/config.json:
3509
3510 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
3511
3512         webkitpy: Incorporate device type into baseline search path
3513         https://bugs.webkit.org/show_bug.cgi?id=193356
3514         <rdar://problem/47215515>
3515
3516         Reviewed by Lucas Forschler.
3517
3518         We need a way to include device type in the baseline search path for iOS to support device specific test expectations.
3519
3520         * Scripts/webkitpy/port/base.py:
3521         (Port.default_baseline_search_path): Allow device type to be passed in.
3522         * Scripts/webkitpy/port/gtk.py:
3523         (GtkPort.default_baseline_search_path): Ignore device type.
3524         * Scripts/webkitpy/port/ios.py:
3525         (IOSPort.default_baseline_search_path): Optionally allow device type to be incorporated into the baseline search path.
3526         (IOSPort.test_expectations_file_position): Update index for the additional device-type specific baseline search path.
3527         * Scripts/webkitpy/port/ios_device_unittest.py:
3528         (IOSDeviceTest):
3529         * Scripts/webkitpy/port/ios_simulator_unittest.py:
3530         (IOSSimulatorTest):
3531         * Scripts/webkitpy/port/mac.py:
3532         (MacPort.default_baseline_search_path): Ignore device type.
3533         * Scripts/webkitpy/port/watch.py:
3534         (WatchPort.default_baseline_search_path): Ditto.
3535         * Scripts/webkitpy/port/win.py:
3536         (WinPort.default_baseline_search_path): Ditto.
3537         (WinCairoPort.default_baseline_search_path): Ditto.
3538         * Scripts/webkitpy/port/wpe.py:
3539         (WPEPort.default_baseline_search_path): Ditto.
3540
3541 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
3542
3543         webkitpy: Print abbreviated baseline search path that includes only folders that exist
3544         https://bugs.webkit.org/show_bug.cgi?id=193352
3545         <rdar://problem/47210736>
3546
3547         Reviewed by Lucas Forschler.
3548
3549         * Scripts/webkitpy/layout_tests/views/printing.py:
3550         (Printer.print_config): Print list on only baseline search paths which exist. 
3551         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3552         (Testprinter.test_print_config):
3553
3554 2019-01-11  Joseph Pecoraro  <pecoraro@apple.com>
3555
3556         Cleanup possible WK*Copy/Create leaks in WebKitTestRunner
3557         https://bugs.webkit.org/show_bug.cgi?id=193340
3558
3559         Reviewed by David Kilzer.
3560
3561         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3562         (WTR::InjectedBundle::didReceiveMessageToPage):
3563         Pull the strings out into a WKRetainPtr.
3564
3565         * WebKitTestRunner/WebNotificationProvider.cpp:
3566         (WTR::WebNotificationProvider::closeWebNotification):
3567         Adopt the created value into the WKRetainPtr.
3568
3569         * WebKitTestRunner/mac/TestControllerMac.mm:
3570         (WTR::generateWhitelist):
3571         Immediately adopt a created value to avoid potential mistakes.
3572
3573 2019-01-11  Dominik Infuehr  <dinfuehr@igalia.com>
3574
3575         Enable DFG on ARM/Linux again
3576         https://bugs.webkit.org/show_bug.cgi?id=192496
3577
3578         Reviewed by Yusuke Suzuki.
3579
3580         After changing the bytecode format DFG was disabled on all 32-bit
3581         architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
3582         on ARM by default.
3583
3584         * Scripts/run-jsc-stress-tests:
3585
3586 2019-01-11  Timothy Hatcher  <timothy@apple.com>
3587
3588         Unreviewed, fix #ifdef in API test added in r239851.
3589         https://bugs.webkit.org/show_bug.cgi?id=193327
3590         rdar://problem/47093222
3591
3592         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm:
3593
3594 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
3595
3596         Introduce IDL files for runtime-enabled UndoManager and UndoItem JavaScript API
3597         https://bugs.webkit.org/show_bug.cgi?id=193109
3598         <rdar://problem/44807048>
3599
3600         Reviewed by Ryosuke Niwa.
3601
3602         Introduce and respect a test option to enable the UndoManager API.
3603
3604         * WebKitTestRunner/TestController.cpp:
3605         (WTR::updateTestOptionsFromTestHeader):
3606         * WebKitTestRunner/TestOptions.h:
3607         (WTR::TestOptions::hasSameInitializationOptions const):
3608         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3609         (WTR::TestController::platformCreateWebView):
3610
3611 2019-01-11  Zalan Bujtas  <zalan@apple.com>
3612
3613         [LFC][BFC][MarginCollapsing] Adjust vertical position when box margin collapses through.
3614         https://bugs.webkit.org/show_bug.cgi?id=193346
3615
3616         Reviewed by Antti Koivisto.
3617
3618         * LayoutReloaded/misc/LFC-passing-tests.txt:
3619
3620 2019-01-10  Ryan Haddad  <ryanhaddad@apple.com>
3621
3622         Unreviewed, fix typo that breaks dashboard link.
3623
3624         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3625         (WebKitBuildbot):
3626
3627 2019-01-10  Ryan Haddad  <ryanhaddad@apple.com>
3628
3629         Update macOS queue configurations
3630         https://bugs.webkit.org/show_bug.cgi?id=193329
3631
3632         Reviewed by Alexey Proskuryakov.
3633
3634         * BuildSlaveSupport/build.webkit.org-config/config.json:
3635         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3636         (BubbleQueueServer):
3637         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3638         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3639         (WebKitBuildbot):
3640         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3641         (table.queue-grid tr.platform.macos-sierra img.logo): Deleted.
3642         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3643
3644 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
3645
3646         MiniBrowser should be able to navigate to about:blank
3647         https://bugs.webkit.org/show_bug.cgi?id=193345
3648
3649         Reviewed by Simon Fraser.
3650
3651         * MiniBrowser/mac/BrowserWindowController.m:
3652         (-[BrowserWindowController addProtocolIfNecessary:]):
3653         Don't prepend "http://" to "about:" prefixed URLs like "about:blank".
3654
3655         * MiniBrowser/mac/WK1BrowserWindowController.m:
3656         (-[WK1BrowserWindowController fetch:]):
3657         * MiniBrowser/mac/WK2BrowserWindowController.m:
3658         (-[WK2BrowserWindowController fetch:]):
3659         Clean up the code that uses this to match style.
3660
3661 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
3662
3663         Remove MiniBrowser custom "Process Swap" menu item which does not work
3664         https://bugs.webkit.org/show_bug.cgi?id=193344
3665
3666         Reviewed by Simon Fraser.
3667
3668         There is a menu item under the Experimental menu that does work.
3669
3670         * MiniBrowser/mac/AppDelegate.m:
3671         (defaultConfiguration):
3672         * MiniBrowser/mac/SettingsController.h:
3673         * MiniBrowser/mac/SettingsController.m:
3674         (-[SettingsController _populateMenu]):
3675         (-[SettingsController validateMenuItem:]):
3676       &nbs