Update bots on test-results.appspot
[WebKit-https.git] / Tools / ChangeLog
1 2013-03-26  Isaac Levy  <ilevy@google.com>
2
3         Update bots on test-results.appspot
4         https://bugs.webkit.org/show_bug.cgi?id=113333
5
6         Reviewed by Ojan Vafai.
7
8         * TestResultServer/static-dashboards/builders.jsonp:
9
10 2013-03-26  Zan Dobersek  <zdobersek@igalia.com>
11
12         Unreviewed GTK gardening.
13
14         * Scripts/run-gtk-tests:
15         (TestRunner): A follow-up to 146859, skipping the complete WebKit2APITests/TestInspector unit test.
16
17 2013-03-26  Csaba Osztrogonác  <ossy@webkit.org>
18
19         [Qt] Enable release/debug/2/webkit2 options for run-qtwebkit-tests
20         https://bugs.webkit.org/show_bug.cgi?id=113287
21
22         Reviewed by Jocelyn Turcotte.
23
24         * Scripts/run-qtwebkit-tests:
25         (Options.__init__):
26
27 2013-03-26  Rijubrata Bhaumik  <rijubrata.bhaumik@intel.com>
28
29         [EFL] Enable IndexedDB by default
30         https://bugs.webkit.org/show_bug.cgi?id=107248
31
32         Reviewed by Laszlo Gombos.
33
34         * Scripts/webkitperl/FeatureList.pm:
35         Enable IndexedDB by default on EFL.
36
37 2013-03-26  Alan Cutter  <alancutter@chromium.org>
38
39         Sheriffbot should explain rollout failures in a human readable form.
40         https://bugs.webkit.org/show_bug.cgi?id=107092
41
42         Reviewed by Ryosuke Niwa.
43
44         Improved sheriffbot's error reporting when a rollout command fails to reverse diff files (the most common failure).
45
46         * Scripts/webkitpy/tool/bot/irc_command.py:
47         (Rollout._check_diff_failure):
48         (Rollout.execute):
49         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
50         (IRCCommandTest.test_rollout):
51
52 2013-03-26  Zan Dobersek  <zdobersek@igalia.com>
53
54         Unreviewed GTK gardening.
55
56         * Scripts/run-gtk-tests:
57         (TestRunner): Skipping a failing unit test after r146518.
58
59 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
60
61         Remove Lion leaks builder
62         https://bugs.webkit.org/show_bug.cgi?id=113252
63
64         Reviewed by Andreas Kling.
65
66         Removed.
67
68         * BuildSlaveSupport/build.webkit.org-config/config.json:
69
70 2013-03-25  Kent Tamura  <tkent@chromium.org>
71
72         Rename ENABLE_INPUT_TYPE_DATETIME
73         https://bugs.webkit.org/show_bug.cgi?id=113254
74
75         Reviewed by Kentaro Hara.
76
77         Rename ENABLE_INPUT_TYPE_DATETIME to ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE.
78         Actually I'd like to remove the code, but we shouldn't remove it yet
79         because we shipped products with it on some platforms.
80
81         * Scripts/webkitperl/FeatureList.pm:
82         * qmake/mkspecs/features/features.pri:
83
84 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
85
86         Remove one more line that was intended to be removed in r146657.
87
88         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
89         (summarize_results):
90
91 2013-03-25  Roger Fong  <roger_fong@apple.com>
92
93         No longer run bindings tests on WinEWS bots which are causing hangs on the bots.
94         Re-enable WinEWS tests.
95
96         * Scripts/webkitpy/common/config/ports.py:
97         (WinPort.run_bindings_tests_command):
98         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
99         (WinEWS):
100
101 2013-03-25  Sheriff Bot  <webkit.review.bot@gmail.com>
102
103         Unreviewed, rolling out r146793.
104         http://trac.webkit.org/changeset/146793
105         https://bugs.webkit.org/show_bug.cgi?id=113248
106
107         Fix did not work (Requested by rfong on #webkit).
108
109         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
110         (WinEWS):
111
112 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
113
114         REGRESSION(r146657): Test failures reported incorrectly
115         https://bugs.webkit.org/show_bug.cgi?id=113223
116
117         Reviewed by Dirk Pranke.
118
119         The bug was caused by BuildBotPrinter not taking the new behavior into account.
120
121         Fixed the bug by exposing enabled_pixel_tests_in_retry flag via ResultDetails object and have BuildBotPrinter
122         treat ['TEXT', 'IMAGE+TEXT'] as a regular failure when the flag is set true.
123
124         * Scripts/webkitpy/layout_tests/controllers/manager.py:
125         (Manager.run):
126
127         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
128         (RunDetails.__init__):
129         (summarize_results): Remove the line I intended to remove in r146657.
130
131         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
132         (logging_run): Return details instead of the exit code.
133         (run_and_capture): Ditto.
134
135         (RunTest.test_full_results_html):
136         (RunTest.test_hung_thread):
137         (RunTest.test_no_tests_found):
138         (RunTest.test_no_tests_found_2):
139         (RunTest.test_repeat_each_iterations_num_tests):
140         (RunTest.test_run_singly_actually_runs_tests):
141         (RunTest.test_test_list):
142         (RunTest.test_missing_and_unexpected_results):
143         (RunTest.test_pixel_test_directories):
144         (RunTest.test_missing_and_unexpected_results_with_custom_exit_code):
145         (RunTest.test_crash_with_stderr):
146         (RunTest.test_no_image_failure_with_image_diff):
147         (RunTest.test_crash_log):
148         (RunTest.test_exit_after_n_failures_upload):
149         (RunTest.test_results_directory_absolute):
150         (RunTest.test_results_directory_relative):
151         (RunTest.test_retrying_and_flaky_tests):
152         (RunTest.test_retrying_force_pixel_tests): Added a test case to ensure enabled_pixel_tests_in_retry is set.
153         (RunTest.test_retrying_uses_retries_directory):
154         (RunTest.test_reftest_should_not_use_naming_convention_if_not_listed_in_reftestlist):
155         (RunTest.test_output_diffs):
156         (EndToEndTest.test_reftest_with_two_notrefs):
157         (RebaselineTest.test_reset_results):
158         (RebaselineTest.test_missing_results):
159         (RebaselineTest.test_new_baseline):
160
161         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
162         (BuildBotPrinter.print_results):
163         (BuildBotPrinter.print_unexpected_results):
164         (BuildBotPrinter.print_unexpected_results.add_result): Don't treat ['TEXT', 'IMAGE+TEXT'] as flaky
165         when we forced pixel tests in retry (i.e. pixel test was initially disabled).
166
167 2013-03-25  Julie Parent  <jparent@chromium.org>
168
169         Dashboard refactor: Move cross dashboard history related code into history.js.
170         https://bugs.webkit.org/show_bug.cgi?id=113104
171
172         Reviewed by Ojan Vafai.
173
174         All functions relating to cross dashboard behavior move from being
175         globals to methods on the history.History object. Names stay the same,
176         except many are made private, ones that should have been constants now
177         are, and the long standing TODO to change "currentState" to 
178         dashboardSpecificState is done.
179         
180         We now create a global history object in dashboard_base, as an 
181         intermediate measure.  Once the dashboard specific code is
182         added to history, each DB will need to create its own, and this
183         global will be eliminated.
184         
185         * TestResultServer/static-dashboards/aggregate_results.js:
186         (handleValidHashParameter):
187         (htmlForBuilder):
188         (rawValuesHTML):
189         * TestResultServer/static-dashboards/dashboard_base.js:
190         (parseDashboardSpecificParameters):
191         (defaultValue):
192         (currentBuilderGroupCategory):
193         (currentBuilderGroupName):
194         (handleLocationChange):
195         (expectationsMap):
196         * TestResultServer/static-dashboards/flakiness_dashboard.js:
197         (generatePage):
198         (.switch.return):
199         (platformAndBuildType):
200         (individualTests):
201         (substringList):
202         (processMissingAndExtraExpectations):
203         (pathToFailureLog):
204         (showPopupForBuild):
205         (htmlForTestsWithExpectationsButNoFailures):
206         (shouldHideTest):
207         (isCrossBuilderView):
208         (tableHeaders):
209         (htmlForSingleTestRow):
210         (htmlForTableColumnHeader):
211         (generatePageForExpectationsUpdate):
212         (handleUpdate):
213         (nextUpdate):
214         (setUpdateIndex):
215         (htmlForIndividualTestOnAllBuildersWithResultsLinks):
216         (.appendExpectationsItem):
217         (loadExpectations):
218         (.dummyNode.onload):
219         (loadExpectationsLayoutTests):
220         (appendExpectations):
221         (htmlForNavBar):
222         (checkBoxToToggleState):
223         (linkHTMLToToggleState):
224         (generatePageForBuilder):
225         (isInvalidKeyForCrossBuilderView):
226         (handleQueryParameterChange):
227         (showLegend):
228         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
229         (resetGlobals):
230         (test):
231         * TestResultServer/static-dashboards/history.js:
232         (.):
233         * TestResultServer/static-dashboards/history_unittests.js:
234         * TestResultServer/static-dashboards/loader.js:
235         (.):
236         * TestResultServer/static-dashboards/loader_unittests.js:
237         * TestResultServer/static-dashboards/timeline_explorer.js:
238         (generatePage):
239         (initCurrentBuilderTestResults):
240         (selectBuild):
241         (showResultsDelta):
242         * TestResultServer/static-dashboards/treemap.js:
243         (generatePage):
244         (.switch.return):
245         (handleFocus):
246         * TestResultServer/static-dashboards/ui.js:
247
248 2013-03-25  Roger Fong  <roger_fong@apple.com>
249
250         Unreviewed. Enable WinEWS tests again.
251
252         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
253         (WinEWS):
254
255 2013-03-25  Dominik Röttsches  <dominik.rottsches@intel.com>
256
257         [HarfBuzz] ICU detection fix in HarfBuzz obsoletes our workaround
258         https://bugs.webkit.org/show_bug.cgi?id=112166
259
260         HarfBuzz 0.9.14 merged my patch for icu detection without
261         pkg-config files, as needed by for example Ubuntu 12.04.
262         This obsoletes our local workaround. Removed it for GTK and EFL.
263
264         Reviewed by Martin Robinson.
265
266         * efl/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
267         * efl/patches/harfbuzz-icu-detection-fix.patch: Removed.
268         * gtk/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
269         * gtk/patches/harfbuzz-icu-detection-fix.patch: Removed.
270
271 2013-03-22  Kiran Muppala  <cmuppala@apple.com>
272
273         Unreviewed.  Move self from contributor to committer list.
274
275         * Scripts/webkitpy/common/config/committers.py:
276
277 2013-03-22  Ryosuke Niwa  <rniwa@webkit.org>
278
279         EWS should use a human readable port name when uploading layout test archives
280         https://bugs.webkit.org/show_bug.cgi?id=113099
281
282         Reviewed by Dirk Pranke.
283
284         Use new port's object's name() method to report human readable port names.
285         This will also help us resolving the bug to apply layout test results posted by EWS.
286
287         * Scripts/webkitpy/tool/bot/botinfo.py:
288         (BotInfo.__init__): Take port's name.
289         (BotInfo.summary_text):
290
291         * Scripts/webkitpy/tool/bot/botinfo_unittest.py:
292         (BotInfoTest.test_summary_text):
293
294         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
295         (FlakyTestReporter.__init__): Preserve the old behavior since we don't have a real port object here.
296
297         * Scripts/webkitpy/tool/commands/queues.py:
298         (PatchProcessingQueue.__init__): Initialize self._port.
299         (PatchProcessingQueue._upload_results_archive_for_patch): Intansitate a real port object if needed,
300         and use that for the attachment filename and the comment posted.
301
302         * Scripts/webkitpy/tool/commands/queues_unittest.py:
303         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Port name is updated to be
304         "mac-snowleopard" as expected for TestPort.
305
306 2013-03-22  Roger Fong  <roger_fong@apple.com>
307
308         Unreviewed. Turn off EWS test on Win again.
309         The battle continues.
310
311         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
312         (WinEWS):
313
314 2013-03-22  Ryosuke Niwa  <rniwa@webkit.org>
315
316         NRWT: Enable pixel tests when retrying tests
317         https://bugs.webkit.org/show_bug.cgi?id=112898
318
319         Reviewed by Dirk Pranke.
320
321         * Scripts/webkitpy/layout_tests/controllers/manager.py:
322         (Manager.run): Call _force_pixel_tests_if_needed before retrying tests and set pixel_tests False
323         if we've forced pixel tests in the retry.
324         (Manager._run_tests):
325         (Manager._clean_up_run): Fixed the capitalizations.
326         (Manager._force_pixel_tests_if_needed): Added.
327
328         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
329         (_interpret_test_failures): Now that this function maybe called multiple times, only set
330         'image_diff_percent' if it doesn't already exist.
331
332         (summarize_results): When the first attempt resulted in a text failure and the second attempt
333         resulted in image and text failures and we've forced to run pixel tests in the retry run,
334         treat this as a regular regression instead of a flakiness.
335
336         Also update test_dict with retry_result so that image_diff_percent maybe filled in if retry
337         run had image diffs.
338
339         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
340         (summarized_results):
341
342         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
343         (parse_full_results): Moved out of EndToEndTest to be used in test_retrying_force_pixel_tests.
344         Also removed some dead code.
345
346         (RunTest.test_retrying_force_pixel_tests): Added. Assert that we generate and only generate
347         pixel results in retries when pixel tests is turned off. Also assert that image_diff_percent
348         is set and pixel_tests_enabled is set to false.
349         (EndToEndTest.test_reftest_with_two_notrefs):
350
351 2013-03-22  Tim Horton  <timothy_horton@apple.com>
352
353         Make it possible to run layout tests on Retina MBP
354         https://bugs.webkit.org/show_bug.cgi?id=93673
355
356         Reviewed by Ryosuke Niwa.
357
358         Use NSWindow SPI and override -backingScaleFactor so that WKTR and DRT
359         windows on 2x machines still run at 1x.
360
361         * DumpRenderTree/mac/DumpRenderTree.mm:
362         (createWebViewAndOffscreenWindow):
363         Reset the window resolution to 1x on creation.
364         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Add NSWindow details.
365         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
366         (-[DumpRenderTreeWindow backingScaleFactor]): Override, always return 1.
367         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
368         (-[WebKitTestRunnerWindow backingScaleFactor]): Override, always return 1.
369         (WTR::PlatformWebView::PlatformWebView):
370         Add NSWindow details, reset the window resolution to 1x on creation.
371
372 2013-03-19  Ryosuke Niwa  <rniwa@webkit.org>
373
374         Leak bots shouldn't build
375         https://bugs.webkit.org/show_bug.cgi?id=112774
376
377         Reviewed by Simon Fraser.
378
379         Since leak bots use regular debug builds, there is no need to build on these bots.
380         Simply downloading builds will dramatically improve the cycle time of these bots.
381
382         * BuildSlaveSupport/build.webkit.org-config/config.json:
383         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
384         (TestLeaksFactory): Renamed from BuildAndTestLeaksFactory and changed to inherit from
385         TestFactory instead of BuildAndTestFactory.
386
387 2013-03-22  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
388
389         [Qt] Fix the TestWebKitAPI build
390         https://bugs.webkit.org/show_bug.cgi?id=113044
391
392         Reviewed by Tor Arne Vestbø.
393
394         The generate-forwarding-headers script would only be run
395         after the targets in InjectedBundle.pri since the second
396         addStrictSubdirOrderBetween call in
397         Tools/TestWebKitAPI/TestWebKitAPI.pro would overwrite
398         the derived_sources -> injected_bundle order in SUBDIRS.
399
400         Fix it by only moving the dependent target at the end of
401         SUBDIRS, don't touch its dependency.
402
403         * qmake/mkspecs/features/functions.prf:
404
405 2013-03-22  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
406
407         [EFL][WK2] View is not focused when fullscreen mode toggled
408         https://bugs.webkit.org/show_bug.cgi?id=113009
409
410         Reviewed by Laszlo Gombos.
411
412         Set focus on view when fullscreen mode enabled/disabled
413         by FullScreen API.
414
415         * MiniBrowser/efl/main.c:
416         (on_fullscreen_accept):
417         (on_fullscreen_deny):
418
419 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
420
421         nrwt is no longer saving retry results in the retries/ subdirectory
422         https://bugs.webkit.org/show_bug.cgi?id=112995
423
424         Reviewed by Ojan Vafai.
425
426         I think this has been broken a long time, unfortunately. This
427         patch should fix that.
428
429         In order to do so, I had to pass the directory to use from
430         the Worker object through the SingleTestWriter to the
431         TestResultWriter. While I was plumbing that through, I rationalized
432         the order of the parameter arguments a bit ...
433
434         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
435         (Worker._run_single_test):
436         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
437         (run_single_test):
438         (SingleTestRunner.__init__):
439         (SingleTestRunner._run_compare_test):
440         (SingleTestRunner._run_rebaseline):
441         (SingleTestRunner._run_reftest):
442         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
443         (write_test_result):
444         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
445         (TestResultWriterTest.test_reftest_diff_image):
446         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
447         (RunTest.test_retrying_uses_retries_directory):
448
449 2013-03-21  Filip Pizlo  <fpizlo@apple.com>
450
451         JSC profiler should have an at-a-glance report of the success of DFG optimization
452         https://bugs.webkit.org/show_bug.cgi?id=112988
453
454         Reviewed by Geoffrey Garen.
455
456         * Scripts/display-profiler-output:
457
458 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
459
460         [chromium] Linux ASAN WebKit canary is running out of memory
461         https://bugs.webkit.org/show_bug.cgi?id=112978
462
463         Reviewed by Tony Chang.
464
465         Running the AddressSanitizer on a crash takes a lot of
466         memory, so we should serialize access to it to avoid running
467         out of memory on a machine.
468
469         * Scripts/webkitpy/layout_tests/port/chromium.py:
470         (ChromiumPort._get_crash_log):
471         * Scripts/webkitpy/layout_tests/port/http_lock.py:
472         (HttpLock.__init__):
473         (HttpLock.wait_for_httpd_lock):
474
475 2013-03-21  Min Qin  <qinmin@chromium.org>
476
477         Cleanup android media layout test code
478         https://bugs.webkit.org/show_bug.cgi?id=112944
479
480         Reviewed by Adam Barth.
481
482         Chromium change: https://codereview.chromium.org/12892010/
483         The current android layout tests are using WebmediaPlayerInProcessAndroid class.
484         The code path has been largely diverged from that of the WebMediaPlayerImplAndroid.
485         It is not worth the effort to keep the code path, and the layout tests will not reflect the actual behavior on the browser.
486         Instead, we should switch to use content shell for layout tests.
487
488         * DumpRenderTree/chromium/TestShell.cpp:
489         (TestShell::resetTestController):
490
491 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
492
493         [chromium] add missing project dependencies to DRT to fix Mac Valgrind
494         https://bugs.webkit.org/show_bug.cgi?id=112953
495
496         Reviewed by Tony Chang.
497
498         When I created the DumpRenderTree_resources target in r144863 I
499         forgot to declare the needed dependencies on the other resource
500         targets. Due to a quirk of ordering, this appears to have been fine
501         w/ ninja but not w/ Xcode (which is still being used on the chromium
502         mac valgrind bots). Declaring the dependencies fixes the build
503         failures.
504
505         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
506
507 2013-03-21  Brent Fulgham  <bfulgham@webkit.org>
508
509         [WinCairo] Correct assert in Empty BitmapImage Test.
510         https://bugs.webkit.org/show_bug.cgi?id=112934
511
512         Reviewed by Tim Horton.
513
514         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:
515         (TestWebKitAPI::TEST): Use proper RefPtr and adoptRef
516         to avoid ref counting assertion when leaving test scope.
517
518 2013-03-21  Zan Dobersek  <zdobersek@igalia.com>
519
520         [GTK] generate-feature-defines-files is incompatible with Python3
521         https://bugs.webkit.org/show_bug.cgi?id=112956
522
523         Reviewed by Martin Robinson.
524
525         Make the generate-feature-defines-files compatible with Python3 by calling the items()
526         method on the dictionary objects when iterating through said dictionaries.
527
528         * gtk/generate-feature-defines-files:
529         (write_feature_defines_header):
530         (write_flattened_feature_defines_file):
531
532 2013-03-20  Ryosuke Niwa  <rniwa@webkit.org>
533
534         kill-old-processes spits out error messages on Mac
535         https://bugs.webkit.org/show_bug.cgi?id=112878
536
537         Reviewed by Jessie Berlin.
538
539         Use grep -E instead of grep -P since grep on Mac doesn't seem to support the latter even though it's
540         included in the list of options grep --help shows.
541
542         Also use double-slash in escaping ++ in clang++ since the slashes needs to escape + inside the shell.
543
544         * BuildSlaveSupport/kill-old-processes:
545         (main):
546
547 2013-03-21  Alberto Garcia  <agarcia@igalia.com>
548
549         [BlackBerry] AccessibilityUIElement: add dummy implementations of scroll methods
550         https://bugs.webkit.org/show_bug.cgi?id=112597
551
552         Reviewed by Xan Lopez.
553
554         These were introduced for the Chromium port in r105295. We need
555         dummy implementations in order to compile the BlackBerry port.
556
557         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
558         (AccessibilityUIElement::scrollToMakeVisible):
559         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
560         (AccessibilityUIElement::scrollToGlobalPoint):
561
562 2013-03-21  Roger Fong  <roger_fong@apple.com>
563
564         Re-enable WinEWS tests following r146376.
565
566         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
567         (WinEWS):
568
569 2013-03-21  Zoltan Horvath  <zoltan@webkit.org>
570
571         Unreviewed. Add Bem Jones-Bey to the list of contributors.
572
573         * Scripts/webkitpy/common/config/committers.py:
574
575 2013-03-21  Claudio Saavedra  <csaavedra@igalia.com>
576
577         [GTK] Missing atk in install-dependencies script
578         https://bugs.webkit.org/show_bug.cgi?id=112272
579
580         Reviewed by Gustavo Noronha Silva.
581
582         * gtk/install-dependencies: Add missing atk dependency.
583
584 2013-03-21  Claudio Saavedra  <csaavedra@igalia.com>
585
586         [GTK] Missing backslash in install-dependencies script
587         https://bugs.webkit.org/show_bug.cgi?id=112907
588
589         Reviewed by Philippe Normand.
590
591         * gtk/install-dependencies: Add missing backslash to dependencies
592         list.
593
594 2013-03-20  Ryosuke Niwa  <rniwa@webkit.org>
595
596         EWS bots have stopped uploading results to bugzilla
597         https://bugs.webkit.org/show_bug.cgi?id=101091
598
599         Reviewed by Adam Barth.
600
601         The bug was caused by LayoutTestResultsReader passing a relative file path to the archive zip
602         to workspace.archive_zip. Because archive_zip uses the results directory as the working directory,
603         this relative file path resoled to a file inside a non-existent directory for "zip".
604
605         Fixed the bug by resolving both test results directory and zip archive paths in
606         LayoutTestResultsReader.archive.
607
608         Also made workspace.create_zip print the source_path so that we may debug these issues more easily
609         in the future.
610
611         * Scripts/webkitpy/common/system/filesystem_mock.py:
612         (MockFileSystem.splitext): Don't assume the entire file path is a file extension when there is no ".".
613
614         * Scripts/webkitpy/common/system/workspace.py:
615         (Workspace.create_zip): Log the source path when "zip" failed.
616
617         * Scripts/webkitpy/common/system/workspace_mock.py:
618         (MockWorkspace.create_zip): Record zip_path and source_path for testing.
619
620         * Scripts/webkitpy/common/system/workspace_unittest.py:
621         (WorkspaceTest.test_create_zip_exception): Test that.
622
623         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
624         (LayoutTestResultsReader.archive): Resolve paths before passing them to workspace.create_zip.
625         This is the actual bug fix.
626
627         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
628         (test_archive_last_layout_test_results_with_relative_path): Added a test case.
629
630 2013-03-20  Jochen Eisinger  <jochen@chromium.org>
631
632         [chromium] move WebThemeEngine implementations to TestRunner library
633         https://bugs.webkit.org/show_bug.cgi?id=112751
634
635         Reviewed by Adam Barth.
636
637         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
638         * DumpRenderTree/DumpRenderTree.gypi:
639         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
640         (WebKit):
641         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
642         (WebTestRunner::TestInterfaces::themeEngine):
643         (WebTestRunner):
644         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
645         (WebKit):
646         (TestInterfaces):
647         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
648         (WebTestRunner::WebTestInterfaces::themeEngine):
649         (WebTestRunner):
650         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
651         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
652         (WebTestRunner):
653         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
654         (WebTestRunner::WebTestThemeControlWin::box):
655         (WebTestRunner::WebTestThemeControlWin::line):
656         (WebTestRunner::WebTestThemeControlWin::triangle):
657         (WebTestRunner::WebTestThemeControlWin::roundRect):
658         (WebTestRunner::WebTestThemeControlWin::oval):
659         (WebTestRunner::WebTestThemeControlWin::circle):
660         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
661         (WebTestRunner::WebTestThemeControlWin::markState):
662         (WebTestRunner::WebTestThemeControlWin::draw):
663         (WebTestRunner::WebTestThemeControlWin::drawTextField):
664         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
665         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
666         (WebTestRunner):
667         (WebTestThemeControlWin):
668         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
669         (WebTestRunner):
670         (WebTestThemeEngineMac):
671         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
672         (+[FakeActiveWindow alwaysActiveWindow]):
673         (+[FakeActiveWindow alwaysInactiveWindow]):
674         (-[FakeActiveWindow initWithActiveControls:]):
675         (-[FakeActiveWindow _hasActiveControls]):
676         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
677         (WebTestRunner):
678         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
679         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
680         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
681         (WebTestRunner::WebTestThemeEngineWin::paintButton):
682         (WebTestRunner):
683         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
684         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
685         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
686         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
687         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
688         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
689         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
690         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
691         (WebTestRunner::WebTestThemeEngineWin::getSize):
692         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
693         (WebTestRunner):
694         (WebTestThemeEngineWin):
695         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
696         * DumpRenderTree/chromium/TestShell.cpp:
697         (TestShell::initialize):
698         * DumpRenderTree/chromium/TestShell.h:
699         (WebKit):
700         * DumpRenderTree/chromium/TestShellMac.mm:
701         (platformInit):
702         * DumpRenderTree/chromium/TestShellWin.cpp:
703         (platformInit):
704         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
705
706 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
707
708         [WinCairo] Unreviewed build fix for TestWebKitAPI under VS2010
709
710         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props: Added.
711         New property sheet that does not link against CoreFoundation and
712         CFNetwork.
713         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props:
714         Use new TestWebKitAPICommonWinCairo property sheet.
715         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props:
716         Ditto.
717
718 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
719
720         [WinCairo] Unreviewed build fix for VS2010.
721
722         Had to add WinCairo-specific property sheets to deal with some
723         library and path differences with the main Apple port.
724
725         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
726         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props:
727         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props:
728         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommonWinCairo.props: Added.
729         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebugWinCairo.props: Added.
730         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffReleaseWinCairo.props: Added.
731
732 2013-03-20  Benjamin Poulain  <bpoulain@apple.com>
733
734         [WK2] Remove VIEW_MODE_CSS_MEDIA from WebKit2
735         https://bugs.webkit.org/show_bug.cgi?id=112849
736
737         Reviewed by Sam Weinig.
738
739         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
740         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
741         * WebKitTestRunner/InjectedBundle/TestRunner.h:
742
743 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
744
745         [WinCairo] Build WebKit Tools under VS2010
746         https://bugs.webkit.org/show_bug.cgi?id=112821
747
748         Reviewed by Tim Horton.
749
750         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
751         Add WinCairo-specific build target.
752         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props: Added.
753         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj: Add WinCairo-specific build target.
754         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props: Added.
755         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeWinCairo.props: Added.
756         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
757         Add WinCairo-specific build target.
758         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
759         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
760         Add WinCairo-specific build target.
761         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Add
762         WinCairo-specific build target.
763         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props: Added.
764         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props: Added.
765         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Add WinCairo-
766         specific build target.
767         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Add
768         WinCairo-specific build target.
769         * win/record-memory/record-memory.vcxproj: Add WinCairo target.
770         * win/record-memory/record-memoryDebugWinCairo.props: Added.
771         * win/record-memory/record-memoryReleaseWinCairo.props: Added.
772
773 2013-03-20  Roger Fong  <roger_fong@apple.com>
774
775         API test gardening AppleWin port.
776
777         The BitmapImageEmptyFrameTest should only be tested on Cairo not on AppleWin port.
778
779         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
780         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
781
782 2013-03-20  Roger Fong  <roger_fong@apple.com>
783
784         Test fix for Win EWS bots, catch various errors and restart script if necessary.
785
786         * EWSTools/start-queue-win.sh:
787
788 2013-03-20  Sami Kyostila  <skyostil@chromium.org>
789
790         Unreviewed, add myself to committers.py.
791
792 2013-03-20  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
793
794         Unreviewed. Adding another email for me.
795
796         * Scripts/webkitpy/common/config/committers.py:
797
798 2013-03-20  Justin Novosad  <junov@google.com>
799
800         [Chromium] Code cleanup: removing support for non-deferred 2d canvas rendering
801         https://bugs.webkit.org/show_bug.cgi?id=112605
802
803         Reviewed by James Robinson.
804
805         Deleting all the code that was used for propagating and supporting
806         the Chromium setting for disabling deferred 2d canvas rendering.
807
808         * DumpRenderTree/chromium/DumpRenderTree.cpp:
809         (main):
810         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
811         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
812         (WebTestRunner::WebPreferences::reset):
813         (WebTestRunner::WebPreferences::applyTo):
814         * DumpRenderTree/chromium/TestShell.cpp:
815         (TestShell::TestShell):
816         (TestShell::resetWebSettings):
817         (TestShell::runFileTest):
818         * DumpRenderTree/chromium/TestShell.h:
819         (TestShell):
820
821 2013-03-20  Ádám Kallai  <kadam@inf.u-szeged.hu>
822
823         [Qt] Qt 4.8 tool related stuff removal from webkitpy.
824         https://bugs.webkit.org/show_bug.cgi?id=112699.
825
826         Reviewed by Adam Barth.
827
828         * Scripts/webkitpy/layout_tests/port/qt.py:
829         (QtPort._search_paths):
830         (QtPort._port_specific_expectations_files):
831         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
832         (QtPortTest):
833         (QtPortTest._assert_search_path):
834         (QtPortTest._assert_expectations_files):
835
836 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
837
838         [Qt] Enable kerning by default
839         https://bugs.webkit.org/show_bug.cgi?id=112704
840
841         Reviewed by Jocelyn Turcotte.
842
843         Disable kerning by default, since some reference test expectations
844         expect kerning to be default off.
845
846         * DumpRenderTree/qt/TestRunnerQt.cpp:
847         (TestRunnerQt::reset):
848         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
849         (WTR::activateFonts):
850
851 2013-03-20  Zeno Albisser  <zeno@webkit.org>
852
853         [Qt] Remove empty function stubs from TestRunnerQt.
854         https://bugs.webkit.org/show_bug.cgi?id=112799
855
856         We are reducing the code in TestRunnerQt step by step,
857         in order to finally replace all of it with the generic
858         TestRunner implementation.
859         This patch removes several simple function stubs that
860         currently do not implement any actual functionality.
861
862         Reviewed by Kenneth Rohde Christiansen.
863
864         * DumpRenderTree/qt/TestRunnerQt.cpp:
865         * DumpRenderTree/qt/TestRunnerQt.h:
866         (TestRunnerQt):
867
868 2013-03-20  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
869
870         [EFL][WK2] Don't show the SearchBar by default when MiniBrowser opened
871         https://bugs.webkit.org/show_bug.cgi?id=112687
872
873         Reviewed by Kenneth Rohde Christiansen.
874
875         Hide the SearchBar by default on window creation.
876
877         * MiniBrowser/efl/main.c:
878         (window_create):
879
880 2013-03-20  Sheriff Bot  <webkit.review.bot@gmail.com>
881
882         Unreviewed, rolling out r146304.
883         http://trac.webkit.org/changeset/146304
884         https://bugs.webkit.org/show_bug.cgi?id=112788
885
886         to many expectations to update (Requested by antonm on
887         #webkit).
888
889         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
890         * DumpRenderTree/DumpRenderTree.gypi:
891         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
892         (WebKit):
893         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
894         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
895         (TestInterfaces):
896         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
897         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
898         * DumpRenderTree/chromium/TestShell.cpp:
899         (TestShell::initialize):
900         * DumpRenderTree/chromium/TestShell.h:
901         (WebKit):
902         * DumpRenderTree/chromium/TestShellMac.mm:
903         (platformInit):
904         * DumpRenderTree/chromium/TestShellWin.cpp:
905         (platformInit):
906         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp.
907         (WebThemeControlDRTWin::WebThemeControlDRTWin):
908         (WebThemeControlDRTWin::~WebThemeControlDRTWin):
909         (WebThemeControlDRTWin::box):
910         (WebThemeControlDRTWin::line):
911         (WebThemeControlDRTWin::triangle):
912         (WebThemeControlDRTWin::roundRect):
913         (WebThemeControlDRTWin::oval):
914         (WebThemeControlDRTWin::circle):
915         (WebThemeControlDRTWin::nestedBoxes):
916         (WebThemeControlDRTWin::markState):
917         (WebThemeControlDRTWin::draw):
918         (WebThemeControlDRTWin::drawTextField):
919         (WebThemeControlDRTWin::drawProgressBar):
920         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h.
921         (WebThemeControlDRTWin):
922         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h.
923         (WebThemeEngineDRTMac):
924         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm.
925         (+[FakeActiveWindow alwaysActiveWindow]):
926         (+[FakeActiveWindow alwaysInactiveWindow]):
927         (-[FakeActiveWindow initWithActiveControls:]):
928         (-[FakeActiveWindow _hasActiveControls]):
929         (WebThemeEngineDRTMac::paintScrollbarThumb):
930         (stateToHIEnableState):
931         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
932         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
933         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Added.
934         (webRectToSkIRect):
935         (drawControl):
936         (drawTextField):
937         (drawProgressBar):
938         (WebThemeEngineDRTWin::paintButton):
939         (WebThemeEngineDRTWin::paintMenuList):
940         (WebThemeEngineDRTWin::paintScrollbarArrow):
941         (WebThemeEngineDRTWin::paintScrollbarThumb):
942         (WebThemeEngineDRTWin::paintScrollbarTrack):
943         (WebThemeEngineDRTWin::paintSpinButton):
944         (WebThemeEngineDRTWin::paintTextField):
945         (WebThemeEngineDRTWin::paintTrackbar):
946         (WebThemeEngineDRTWin::paintProgressBar):
947         (WebThemeEngineDRTWin::getSize):
948         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h.
949         (WebThemeEngineDRTWin):
950         (WebThemeEngineDRTWin::WebThemeEngineDRTWin):
951
952 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
953
954         [Qt] Support -webkit-font-smoothing
955         https://bugs.webkit.org/show_bug.cgi?id=106009
956
957         Reviewed by Jocelyn Turcotte.
958
959         Set shouldUseFontSmoothing to false to match WebKitTestRunner.
960
961         * DumpRenderTree/qt/TestRunnerQt.cpp:
962         (TestRunnerQt::reset):
963
964 2013-03-20  Krzysztof Czech  <k.czech@samsung.com>
965
966         [GTK] accessibility/aria-scrollbar-role.html is failing
967         https://bugs.webkit.org/show_bug.cgi?id=98358
968
969         Reviewed by Martin Robinson.
970
971         Adds support for checking accessibility object's orientation.
972         Orientation is checked by retrieving proper state of accessibility object.
973
974         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
975         (checkElementState):
976         (AccessibilityUIElement::orientation):
977         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
978         (WTR::AccessibilityUIElement::orientation):
979
980 2013-03-19  Jochen Eisinger  <jochen@chromium.org>
981
982         [chromium] move WebThemeEngine implementations to TestRunner library
983         https://bugs.webkit.org/show_bug.cgi?id=112751
984
985         Reviewed by Adam Barth.
986
987         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
988         * DumpRenderTree/DumpRenderTree.gypi:
989         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
990         (WebKit):
991         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
992         (WebTestRunner::TestInterfaces::themeEngine):
993         (WebTestRunner):
994         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
995         (WebKit):
996         (TestInterfaces):
997         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
998         (WebTestRunner::WebTestInterfaces::themeEngine):
999         (WebTestRunner):
1000         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
1001         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
1002         (WebTestRunner):
1003         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
1004         (WebTestRunner::WebTestThemeControlWin::box):
1005         (WebTestRunner::WebTestThemeControlWin::line):
1006         (WebTestRunner::WebTestThemeControlWin::triangle):
1007         (WebTestRunner::WebTestThemeControlWin::roundRect):
1008         (WebTestRunner::WebTestThemeControlWin::oval):
1009         (WebTestRunner::WebTestThemeControlWin::circle):
1010         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
1011         (WebTestRunner::WebTestThemeControlWin::markState):
1012         (WebTestRunner::WebTestThemeControlWin::draw):
1013         (WebTestRunner::WebTestThemeControlWin::drawTextField):
1014         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
1015         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
1016         (WebTestRunner):
1017         (WebTestThemeControlWin):
1018         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
1019         (WebTestRunner):
1020         (WebTestThemeEngineMac):
1021         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
1022         (+[FakeActiveWindow alwaysActiveWindow]):
1023         (+[FakeActiveWindow alwaysInactiveWindow]):
1024         (-[FakeActiveWindow initWithActiveControls:]):
1025         (-[FakeActiveWindow _hasActiveControls]):
1026         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
1027         (WebTestRunner):
1028         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
1029         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
1030         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
1031         (WebTestRunner::WebTestThemeEngineWin::paintButton):
1032         (WebTestRunner):
1033         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
1034         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
1035         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
1036         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
1037         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
1038         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
1039         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
1040         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
1041         (WebTestRunner::WebTestThemeEngineWin::getSize):
1042         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
1043         (WebTestRunner):
1044         (WebTestThemeEngineWin):
1045         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
1046         * DumpRenderTree/chromium/TestShell.cpp:
1047         (TestShell::initialize):
1048         * DumpRenderTree/chromium/TestShell.h:
1049         (WebKit):
1050         * DumpRenderTree/chromium/TestShellMac.mm:
1051         (platformInit):
1052         * DumpRenderTree/chromium/TestShellWin.cpp:
1053         (platformInit):
1054         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
1055
1056 2013-03-19  Tony Chang  <tony@chromium.org>
1057
1058         Move testRunner.setTouchDragDropEnabled to internals.settings
1059         https://bugs.webkit.org/show_bug.cgi?id=112739
1060
1061         Reviewed by Adam Barth.
1062
1063         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1064         (WebTestRunner::TestRunner::TestRunner): Remove unnecessary code.
1065         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1066         (TestRunner): Remove unnecessary code.
1067         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
1068         (WebTestRunner::WebPreferences::reset):
1069         (WebTestRunner::WebPreferences::applyTo): Always set to false.
1070
1071 2013-03-19  Mark Pilgrim  <pilgrim@chromium.org>
1072
1073         [Chromium] Migrate to WEBKIT_USE_NEW_WEBFILESYSTEMTYPE
1074         https://bugs.webkit.org/show_bug.cgi?id=112754
1075
1076         Reviewed by Darin Fisher.
1077
1078         Remove old code behind ifndef WEBKIT_USE_NEW_WEBFILESYSTEMTYPE
1079         now that it's always defined.
1080
1081         * DumpRenderTree/chromium/WebViewHost.cpp:
1082         * DumpRenderTree/chromium/WebViewHost.h:
1083         (WebViewHost):
1084
1085 2013-03-19  Kenneth Russell  <kbr@google.com>
1086
1087         Unreviewed, rolling out r146290.
1088         http://trac.webkit.org/changeset/146290
1089         https://bugs.webkit.org/show_bug.cgi?id=112751
1090
1091         Broke Chromium Mac build.
1092
1093         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1094         * DumpRenderTree/DumpRenderTree.gypi:
1095         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
1096         (WebKit):
1097         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
1098         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
1099         (TestInterfaces):
1100         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
1101         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
1102         * DumpRenderTree/chromium/TestShell.cpp:
1103         (TestShell::initialize):
1104         * DumpRenderTree/chromium/TestShell.h:
1105         (WebKit):
1106         * DumpRenderTree/chromium/TestShellMac.mm:
1107         (platformInit):
1108         * DumpRenderTree/chromium/TestShellWin.cpp:
1109         (platformInit):
1110         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp.
1111         (WebThemeControlDRTWin::WebThemeControlDRTWin):
1112         (WebThemeControlDRTWin::~WebThemeControlDRTWin):
1113         (WebThemeControlDRTWin::box):
1114         (WebThemeControlDRTWin::line):
1115         (WebThemeControlDRTWin::triangle):
1116         (WebThemeControlDRTWin::roundRect):
1117         (WebThemeControlDRTWin::oval):
1118         (WebThemeControlDRTWin::circle):
1119         (WebThemeControlDRTWin::nestedBoxes):
1120         (WebThemeControlDRTWin::markState):
1121         (WebThemeControlDRTWin::draw):
1122         (WebThemeControlDRTWin::drawTextField):
1123         (WebThemeControlDRTWin::drawProgressBar):
1124         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h.
1125         (WebThemeControlDRTWin):
1126         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h.
1127         (WebThemeEngineDRTMac):
1128         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm.
1129         (+[FakeActiveWindow alwaysActiveWindow]):
1130         (+[FakeActiveWindow alwaysInactiveWindow]):
1131         (-[FakeActiveWindow initWithActiveControls:]):
1132         (-[FakeActiveWindow _hasActiveControls]):
1133         (WebThemeEngineDRTMac::paintScrollbarThumb):
1134         (stateToHIEnableState):
1135         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
1136         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
1137         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Added.
1138         (webRectToSkIRect):
1139         (drawControl):
1140         (drawTextField):
1141         (drawProgressBar):
1142         (WebThemeEngineDRTWin::paintButton):
1143         (WebThemeEngineDRTWin::paintMenuList):
1144         (WebThemeEngineDRTWin::paintScrollbarArrow):
1145         (WebThemeEngineDRTWin::paintScrollbarThumb):
1146         (WebThemeEngineDRTWin::paintScrollbarTrack):
1147         (WebThemeEngineDRTWin::paintSpinButton):
1148         (WebThemeEngineDRTWin::paintTextField):
1149         (WebThemeEngineDRTWin::paintTrackbar):
1150         (WebThemeEngineDRTWin::paintProgressBar):
1151         (WebThemeEngineDRTWin::getSize):
1152         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h.
1153         (WebThemeEngineDRTWin):
1154         (WebThemeEngineDRTWin::WebThemeEngineDRTWin):
1155
1156 2013-03-19  Krzysztof Czech  <k.czech@samsung.com>
1157
1158         [EFL] canvas-fallback-content.html is failing
1159         https://bugs.webkit.org/show_bug.cgi?id=111998
1160
1161         Reviewed by Chris Fleizach.
1162
1163         Adds support for getting platform name.
1164
1165         * DumpRenderTree/TestRunner.cpp:
1166         (TestRunner::staticValues):
1167         * DumpRenderTree/TestRunner.h:
1168         (TestRunner):
1169         * DumpRenderTree/efl/TestRunnerEfl.cpp:
1170         (TestRunner::platformName):
1171
1172 2013-03-19  Jochen Eisinger  <jochen@chromium.org>
1173
1174         [chromium] move WebThemeEngine implementations to TestRunner library
1175         https://bugs.webkit.org/show_bug.cgi?id=112751
1176
1177         Reviewed by Adam Barth.
1178
1179         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1180         * DumpRenderTree/DumpRenderTree.gypi:
1181         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
1182         (WebKit):
1183         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
1184         (WebTestRunner::TestInterfaces::themeEngine):
1185         (WebTestRunner):
1186         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
1187         (WebKit):
1188         (TestInterfaces):
1189         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
1190         (WebTestRunner::WebTestInterfaces::themeEngine):
1191         (WebTestRunner):
1192         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
1193         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
1194         (WebTestRunner):
1195         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
1196         (WebTestRunner::WebTestThemeControlWin::box):
1197         (WebTestRunner::WebTestThemeControlWin::line):
1198         (WebTestRunner::WebTestThemeControlWin::triangle):
1199         (WebTestRunner::WebTestThemeControlWin::roundRect):
1200         (WebTestRunner::WebTestThemeControlWin::oval):
1201         (WebTestRunner::WebTestThemeControlWin::circle):
1202         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
1203         (WebTestRunner::WebTestThemeControlWin::markState):
1204         (WebTestRunner::WebTestThemeControlWin::draw):
1205         (WebTestRunner::WebTestThemeControlWin::drawTextField):
1206         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
1207         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
1208         (WebTestRunner):
1209         (WebTestThemeControlWin):
1210         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
1211         (WebTestRunner):
1212         (WebTestThemeEngineMac):
1213         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
1214         (+[FakeActiveWindow alwaysActiveWindow]):
1215         (+[FakeActiveWindow alwaysInactiveWindow]):
1216         (-[FakeActiveWindow initWithActiveControls:]):
1217         (-[FakeActiveWindow _hasActiveControls]):
1218         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
1219         (WebTestRunner):
1220         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
1221         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
1222         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
1223         (WebTestRunner::WebTestThemeEngineWin::paintButton):
1224         (WebTestRunner):
1225         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
1226         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
1227         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
1228         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
1229         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
1230         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
1231         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
1232         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
1233         (WebTestRunner::WebTestThemeEngineWin::getSize):
1234         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
1235         (WebTestRunner):
1236         (WebTestThemeEngineWin):
1237         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
1238         * DumpRenderTree/chromium/TestShell.cpp:
1239         (TestShell::initialize):
1240         * DumpRenderTree/chromium/TestShell.h:
1241         (WebKit):
1242         * DumpRenderTree/chromium/TestShellMac.mm:
1243         (platformInit):
1244         * DumpRenderTree/chromium/TestShellWin.cpp:
1245         (platformInit):
1246         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
1247
1248 2013-03-19  Kenneth Rohde Christiansen  <kenneth@webkit.org> and Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1249
1250         [EFL][WK2] Separate WebView further from EwkView
1251         https://bugs.webkit.org/show_bug.cgi?id=111591
1252
1253         Reviewed by Caio Marcelo de Oliveira Filho.
1254
1255         Updated EFL PlatformWebView to meet the new WKView API and ewk view private API.
1256         PlatformWKView is pointer to Evas_Object for EFL, as this is more natural and
1257         since we can afford it having EWKViewGetWKView() private API to access WKView.
1258
1259         * TestWebKitAPI/PlatformWebView.h:
1260         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
1261         (TestWebKitAPI::TEST):
1262         * TestWebKitAPI/efl/PlatformWebView.cpp:
1263         (TestWebKitAPI::PlatformWebView::PlatformWebView):
1264         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
1265         (TestWebKitAPI::PlatformWebView::resizeTo):
1266         (TestWebKitAPI::PlatformWebView::page):
1267         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
1268         (TestWebKitAPI::PlatformWebView::simulateMouseMove):
1269         (TestWebKitAPI::PlatformWebView::simulateRightClick):
1270         * WebKitTestRunner/PlatformWebView.h:
1271         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
1272         (WTR::EventSenderProxy::dispatchEvent):
1273         (WTR::EventSenderProxy::keyDown):
1274         (WTR::EventSenderProxy::sendTouchEvent):
1275         (WTR::EventSenderProxy::setTouchModifier):
1276         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1277         (WTR::PlatformWebView::PlatformWebView):
1278         (WTR::PlatformWebView::~PlatformWebView):
1279         (WTR::PlatformWebView::resizeTo):
1280         (WTR::PlatformWebView::page):
1281         (WTR::PlatformWebView::focus):
1282         (WTR::PlatformWebView::windowSnapshotImage):
1283
1284 2013-03-19  Roger Fong  <roger_fong@apple.com>
1285
1286         Changes to VS2010 project files should only trigger builds on Windows bots.
1287         https://bugs.webkit.org/show_bug.cgi?id=112731
1288
1289         Reviewed by Timothy Horton.
1290
1291         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
1292         (_should_file_trigger_build):
1293
1294 2013-03-19  Roger Fong  <roger_fong@apple.com>
1295
1296         Unreviewed. webkitpy tests fix for Windows, runtests.py run-webkit-tests arguments changed.
1297
1298         * Scripts/webkitpy/tool/steps/runtests.py:
1299         (RunTests.run):
1300         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
1301         (RunTestsTest.test_webkit_run_unit_tests):
1302
1303 2013-03-19  Julie Parent  <jparent@chromium.org>
1304
1305         Dashboards: Introduce history namespace and unit tests.
1306         https://bugs.webkit.org/show_bug.cgi?id=112645
1307
1308         Reviewed by Ojan Vafai.
1309         
1310         Laying the framework for introducing the new history object and
1311         namespace.  This moves only static functions into the history
1312         namespace, and moves corresponding unit tests into seperate
1313         unit test file.
1314
1315         * TestResultServer/static-dashboards/aggregate_results.html:
1316         * TestResultServer/static-dashboards/dashboard_base.js:
1317         (parseCrossDashboardParameters):
1318         (parseDashboardSpecificParameters):
1319         (parseParameters):
1320         * TestResultServer/static-dashboards/flakiness_dashboard.html:
1321         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1322         (.switch.return):
1323         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1324         * TestResultServer/static-dashboards/history.js: Added.
1325         * TestResultServer/static-dashboards/history_unittests.js: Added.
1326         * TestResultServer/static-dashboards/loader.js:
1327         (.):
1328         * TestResultServer/static-dashboards/run-embedded-unittests.html:
1329         * TestResultServer/static-dashboards/run-unittests.html:
1330         * TestResultServer/static-dashboards/timeline_explorer.html:
1331         * TestResultServer/static-dashboards/timeline_explorer.js:
1332         * TestResultServer/static-dashboards/treemap.html:
1333         * TestResultServer/static-dashboards/treemap.js:
1334         (.switch.return):
1335         * TestResultServer/static-dashboards/ui.js:
1336
1337 2013-03-19  Daniel Bates  <dbates@webkit.org>
1338
1339         svn-apply has trouble applying a patch that adds a Windows newline to EOF
1340         https://bugs.webkit.org/show_bug.cgi?id=112732
1341
1342         Reviewed by Eric Seidel.
1343
1344         Fixes an issues where a diff that adds a Windows line ending (CRLF) to the end
1345         of an existing file cannot be applied.
1346
1347         In particular, svn-{apply, unapply} compensate for differences in line endings
1348         by converting the line endings in a diff to match the line endings in the target
1349         file. The diff(1) command precedes the last line of a diff that adds a newline
1350         character to the end of a file with the special character sequence "\n \\ No newline at end of file\n"
1351         Svn-{apply, unapply} converts the newline characters (\n) in this character sequence
1352         to \r\n (CRLF) when the target file has Windows line endings and patch(1) complains
1353         when applying this modified diff. Instead, svn-{apply, unapply} should not modify
1354         the newline characters in this special character sequence to match the line endings
1355         in the target file.
1356
1357         * Scripts/VCSUtils.pm:
1358         (parseDiff):
1359         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
1360         Added tests:
1361             - "SVN: Patch adds Windows newline to EOF and IndexPath has Windows line endings"
1362             - "SVN: Patch adds Mac newline to EOF and IndexPath has Mac line endings"
1363             - "Git: Patch adds Windows newline to EOF and IndexPath has Windows line endings"
1364             - "Git: Patch adds Mac newline to EOF and IndexPath has Mac line endings"
1365         (escapeNewLineCharacters): Added.
1366         (toMacLineEndings): Added.
1367
1368 2013-03-19  James Robinson  <jamesr@chromium.org>
1369
1370         [chromium] Remove compositor settings that don't go through WebKit
1371         https://bugs.webkit.org/show_bug.cgi?id=112718
1372
1373         Reviewed by Adam Barth.
1374
1375         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1376         (main):
1377         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
1378         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
1379         (WebTestRunner::WebPreferences::reset):
1380         (WebTestRunner::WebPreferences::applyTo):
1381         * DumpRenderTree/chromium/TestShell.cpp:
1382         (TestShell::TestShell):
1383         (TestShell::resetWebSettings):
1384         * DumpRenderTree/chromium/TestShell.h:
1385         (TestShell):
1386
1387 2013-03-19  Dirk Pranke  <dpranke@chromium.org>
1388
1389         Unreviewed, rolling out r146101.
1390         https://bugs.webkit.org/show_bug.cgi?id=111884
1391
1392         re-enable custom freetype on asan; this needs to be on
1393         now that the bot is running lucid.
1394
1395         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1396
1397 2013-03-19  Alberto Garcia  <agarcia@igalia.com>
1398
1399         [BlackBerry] Enable USE_SYSTEM_MALLOC by default
1400         https://bugs.webkit.org/show_bug.cgi?id=112365
1401
1402         Reviewed by Benjamin Poulain.
1403
1404         Enable USE_SYSTEM_MALLOC by default via FeatureList.pm instead of
1405         harcoding it in wtf/Platform.h
1406
1407         * Scripts/webkitperl/FeatureList.pm:
1408
1409 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
1410
1411         [Qt] Make ImageDiff similar to Chromium's ImageDiff
1412         https://bugs.webkit.org/show_bug.cgi?id=94782
1413
1414         Based on patch by Csaba Osztrogonác.
1415         Reviewed by Jocelyn Turcotte.
1416
1417         The diff image is generated with bright red indicating errors, but letting the base image
1418         shine through so the context of the error-pixel can be identified.
1419
1420         * DumpRenderTree/qt/ImageDiff.cpp:
1421         (main):
1422
1423 2013-03-18  Andras Becsi  <andras.becsi@digia.com>
1424
1425         [Qt] Fix the build of QtTestBrowser if the print preview dialog is disabled in Qt
1426
1427         Rubber-stamped by Csaba Osztrogonác.
1428
1429         Check for QT_NO_PRINTPREVIEWDIALOG instead of QT_NO_PRINTER
1430         since the latter might not cover the former.
1431
1432         * QtTestBrowser/launcherwindow.cpp:
1433         (LauncherWindow::print):
1434
1435 2013-03-18  Simon Fraser  <simon.fraser@apple.com>
1436
1437         Style tweeks to default.css.
1438         
1439         Rubber-stamped by David Kilzer.
1440         
1441         Give visited links a different color to other links, so you can
1442         see which builds you've viewed.
1443         
1444         Make the <small> text less tiny.
1445
1446         * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
1447         (small):
1448         (a:link,a:visited,a:active):
1449         (a:visited):
1450
1451 2013-03-18  Ryosuke Niwa  <rniwa@webkit.org>
1452
1453         Remove the temporary hack for webkit-perf.appspot.com and cleanup the code
1454         https://bugs.webkit.org/show_bug.cgi?id=112494
1455
1456         Reviewed by Dirk Pranke.
1457
1458         Removed the code to override webkit-perf.appspot.com by perf.webkit.org.
1459         Also merged two pairs of methods to cleanup the code.
1460
1461         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1462         (PerfTestsRunner.run): Merged _upload_and_show_results.
1463         (PerfTestsRunner._generate_results): Merged _generate_output_files.
1464
1465 2013-03-18  Dirk Pranke  <dpranke@chromium.org>
1466
1467         [chromium] build xdisplaycheck when building DRT
1468         https://bugs.webkit.org/show_bug.cgi?id=112636
1469
1470         Reviewed by Tony Chang.
1471
1472         It appears that we need xdisplaycheck to be built in order for
1473         Xvfb to be started correctly on the bots, and DRT was missing
1474         a dependency on it. This may be the cause of the ASAN bot not
1475         starting up properly (it only builds DRT).
1476
1477         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1478
1479 2013-03-18  David Levin  <levin@chromium.org>
1480
1481         Implement icon change notification dump for Chromium's test shell.
1482         https://bugs.webkit.org/show_bug.cgi?id=112614
1483
1484         This was previously implemented for some other platforms in r58111
1485         and r116547.
1486
1487         In r122806, fast/dom/icon-url-property.html stopped using it, but
1488         it is useful for tests, so I plan to re-add it to that test again.
1489
1490         Reviewed by Jochen Eisinger.
1491
1492         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
1493         (WebTestRunner::WebTestProxy::didChangeIcon): Add handler so that
1494          icon change notifications from WebKit may be logged in test output.
1495         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1496         (WebTestRunner::TestRunner::TestRunner): Expose dumpIconChanges.
1497         (WebTestRunner::TestRunner::reset): Clear the new dump variable.
1498         (WebTestRunner::TestRunner::shouldDumpIconChanges): Expose the dump vairable.
1499         (WebTestRunner):
1500         (WebTestRunner::TestRunner::dumpIconChanges): Implement the test method.
1501         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1502         (TestRunner):
1503         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
1504         (WebTestRunner::WebTestProxyBase::didChangeIcon):
1505         (WebTestRunner):
1506         * DumpRenderTree/chromium/WebViewHost.cpp:
1507         (WebViewHost::didChangeIcon): Add the output about changing the icon.
1508         * DumpRenderTree/chromium/WebViewHost.h:
1509         (WebViewHost):
1510
1511 2013-03-18  Julie Parent  <jparent@chromium.org>
1512
1513         Cleanup: Move js for treemap and aggregate_results into own js files.
1514         https://bugs.webkit.org/show_bug.cgi?id=112618
1515
1516         Reviewed by Dirk Pranke.
1517         
1518         No functional changes, just moving the code into separate js file
1519         rather than inlined in the html, so we can test it, make it more
1520         modular, etc.  Other dashboard types are already done this way.
1521
1522         * TestResultServer/static-dashboards/aggregate_results.html:
1523         * TestResultServer/static-dashboards/aggregate_results.js: Copied from Tools/TestResultServer/static-dashboards/aggregate_results.html.
1524         (generatePage):
1525         (handleValidHashParameter):
1526         (htmlForBuilder):
1527         (rawValuesHTML):
1528         (chartHTML):
1529         (filteredValues):
1530         (chart):
1531         (htmlForRevisionRows):
1532         (wrapHTMLInTable):
1533         (htmlForSummaryTable):
1534         (valuesPerExpectation):
1535         (htmlForTestType):
1536         (htmlForTableRow):
1537         (extendedEncode):
1538         * TestResultServer/static-dashboards/treemap.html:
1539         * TestResultServer/static-dashboards/treemap.js: Copied from Tools/TestResultServer/static-dashboards/treemap.html.
1540         (humanReadableTime):
1541         (convertToWebTreemapFormat):
1542         (reverseSortByAverage):
1543         (generatePage):
1544         (focusPath):
1545         (.switch.return):
1546         (handleQueryParameterChange):
1547         (extractName):
1548         (fullName):
1549         (handleFocus.):
1550         (handleFocus):
1551
1552 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
1553
1554         [webkitpy] '/usr/bin/interdiff' output while running test-webkitpy
1555         https://bugs.webkit.org/show_bug.cgi?id=112622
1556
1557         Reviewed by Dirk Pranke.
1558
1559         * Scripts/webkitpy/tool/steps/haslanded_unittest.py:
1560         (HasLandedTest): Pipe the stdout and stderr output of the subprocess call to subprocess.PIPE, eliminating unnecessary output.
1561
1562 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
1563
1564         [NRWT][GTK] Add gtk-wk1 directory to the list of baseline search paths when using DumpRenderTree
1565         https://bugs.webkit.org/show_bug.cgi?id=112619
1566
1567         Reviewed by Dirk Pranke.
1568
1569         When using DumpRenderTree on the Gtk port, NRWT should look for baselines first in the LayoutTests/platform/gtk-wk1
1570         directory and then fall back to the generic LayoutTests/platform/gtk directory.
1571
1572         * Scripts/webkitpy/layout_tests/port/gtk.py:
1573         (GtkPort.default_baseline_search_path): Implement the method on the GtkPort class, mapping every search path to the
1574         Port._webkit_baseline_path method.
1575         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
1576         (GtkPortTest.test_default_baseline_search_path): Add a test for the changes that are being introduced.
1577         (GtkPortTest.test_port_specific_expectations_files): Wrap a couple of long lines.
1578         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1579         (TestRebaselineTest.test_baseline_directory): Enhance one and add an additional test case for baseline directories
1580         that are expected based on the builder name.
1581
1582 2013-03-18  Mark Pilgrim  <pilgrim@chromium.org>
1583
1584         [Chromium] Create WebFileSystemType enum to allow easier filesystem refactoring
1585         https://bugs.webkit.org/show_bug.cgi?id=112571
1586
1587         Reviewed by Adam Barth.
1588
1589         Update function declarations for new WebFileSystemType enum. (All
1590         changes are behind an #ifdef so we can sync required changes in embedders.)
1591
1592         * DumpRenderTree/chromium/WebViewHost.cpp:
1593         (WebViewHost::openFileSystem):
1594         (WebViewHost::deleteFileSystem):
1595         * DumpRenderTree/chromium/WebViewHost.h:
1596         (WebViewHost):
1597
1598 2013-03-18  Julie Parent  <jparent@chromium.org>
1599
1600         Cleanup: Move timeline_exporer js out of html file into js.
1601         https://bugs.webkit.org/show_bug.cgi?id=112188
1602
1603         Reviewed by Dirk Pranke.
1604         
1605         Moves the javascript out of the html file and into a new js file.
1606         This follows the format of flakiness_dashboard.{html|js}.
1607         
1608         Also moves code from dashboard_base that is used only by this one
1609         dashboard, and makes it private to the dashboard.
1610
1611         * TestResultServer/static-dashboards/dashboard_base.js:
1612         * TestResultServer/static-dashboards/timeline_explorer.html:
1613         * TestResultServer/static-dashboards/timeline_explorer.js: Copied from Tools/TestResultServer/static-dashboards/timeline_explorer.html.
1614         (generatePage):
1615         (initCurrentBuilderTestResults):
1616         (shouldShowWebKitRevisionsOnly):
1617         (updateTimelineForBuilder.):
1618         (updateTimelineForBuilder):
1619         (selectBuild):
1620         (updateBuildIndicator):
1621         (.addRow):
1622         (.addNumberRow):
1623         (.inspectorNode.getElementsByTagName.0.onclick):
1624         (.inspectorNode.getElementsByTagName.1.onclick):
1625         (.inspectorNode.getElementsByTagName.2.onclick):
1626         (updateBuildInspector):
1627         (showResultsDelta):
1628         (decompressResults.addFlakyDelta):
1629         (decompressResults):
1630
1631 2013-03-18  Dirk Pranke  <dpranke@chromium.org>
1632
1633         Unreviewed, rolling out r145272.
1634         http://trac.webkit.org/changeset/145272
1635         https://bugs.webkit.org/show_bug.cgi?id=111884
1636
1637         Turns out the ASAN build is still broken; possibly there's
1638         something still setting LD_LIBRARY_PATH, or possibly there's
1639         something else wrong. In the meantime, we need it to work again.
1640
1641         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1642
1643 2013-03-18  Ryosuke Niwa  <rniwa@webkit.org>
1644
1645         delete-stale-build-files is too aggressive
1646         https://bugs.webkit.org/show_bug.cgi?id=112595
1647
1648         Reviewed by Tim Horton.
1649
1650         It appears that whitelisting file extensions to keep is not a good idea.
1651         Blacklist files to delete instead, and only delete .o files for now.
1652         We can add more file extensions as needed.
1653
1654         * BuildSlaveSupport/delete-stale-build-files:
1655
1656 2013-03-18  Simon Fraser  <simon.fraser@apple.com>
1657
1658         Disable accessibility notifications after each test
1659         https://bugs.webkit.org/show_bug.cgi?id=112579
1660
1661         Reviewed by Tim Horton.
1662         
1663         In WebKitTestRunner, if any tests triggered accessibility notifications,
1664         the global notification handler would thereafter be active, and fire
1665         notifications for all subsequent tests.
1666         
1667         Fix by implementing AccessibilityController::resetToConsistentState() for
1668         Mac, and using it to clear the global notification handler.
1669
1670         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
1671         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
1672         (WTR::AccessibilityController::addNotificationListener): Remove stupid comment.
1673         (WTR::AccessibilityController::removeNotificationListener): Explicitly call
1674         -stopObserving so that unregistering the observer doesn't rely on object lifetimes
1675         (e.g. because of -autorelease).
1676         (WTR::AccessibilityController::logAccessibilityEvents): Stub.
1677         (WTR::AccessibilityController::resetToConsistentState): Remove the notification listener
1678         if there is one.
1679         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.h:
1680         Add -stopObserving
1681         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
1682         (-[AccessibilityNotificationHandler dealloc]): Call -stopObserving
1683         (-[AccessibilityNotificationHandler stopObserving]): Unregister from the notification
1684         center.
1685
1686 2013-03-18  Dana Jansens  <danakj@chromium.org>
1687
1688         [chromium] Remove WebGraphicsContext3DInProcessImpl support from DRT.
1689         https://bugs.webkit.org/show_bug.cgi?id=112392
1690
1691         Reviewed by James Robinson.
1692
1693         Removes the command line flag option from DRT.
1694
1695         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1696         (main):
1697
1698 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
1699
1700         [GTK] plugins/plugin-clip-subframe.html is failing
1701         https://bugs.webkit.org/show_bug.cgi?id=112570
1702
1703         Reviewed by Martin Robinson.
1704
1705         * GNUmakefile.am: Add the LogNPPSetWindow.cpp file to the build.
1706
1707 2013-03-17  Morten Stenshorne  <mstensho@opera.com>
1708
1709         Add reload button (and F5 accelerator) to the GtkLauncher toolbar
1710         https://bugs.webkit.org/show_bug.cgi?id=112442
1711
1712         Reviewed by Gustavo Noronha Silva.
1713
1714         * GtkLauncher/main.c:
1715         (reloadCb):
1716         (createToolbar):
1717         (createWindow):
1718
1719 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
1720
1721         REGRESSION (r144884?): WebKit2.DOMWindowExtensionBasic API test is asserting
1722         https://bugs.webkit.org/show_bug.cgi?id=112205
1723
1724         Disable this API test until Geoff can fix it.
1725
1726         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
1727         (TestWebKitAPI::TEST):
1728
1729 2013-03-15  Jochen Eisinger  <jochen@chromium.org>
1730
1731         plugins/netscape-plugin-setwindow-size*.html and plugins/pass-different-npp-struct.html should be async
1732         https://bugs.webkit.org/show_bug.cgi?id=112478
1733
1734         Reviewed by Tony Chang.
1735
1736         There is nothing that ensures that the log messages from the plugin
1737         come in before the layout test finished loading.
1738
1739         * DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:
1740         (PassDifferentNPPStruct::NPP_SetWindow):
1741         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1742         (NPP_SetWindow):
1743
1744 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
1745
1746         Have the mac port support per_test_timeout in webkitpy
1747         https://bugs.webkit.org/show_bug.cgi?id=112466
1748
1749         Reviewed by Dirk Pranke.
1750         
1751         Both WTR and DRT handle --timeout arguments, so we can
1752         have the scripts pass the timeout values down to the tools.
1753
1754         * Scripts/webkitpy/layout_tests/port/mac.py:
1755         (MacPort.supports_per_test_timeout):
1756
1757 2013-03-15  Rouslan Solomakhin  <rouslan@chromium.org>
1758
1759         Remove setAsynchronousSpellCheckingEnabled from test runners
1760         https://bugs.webkit.org/show_bug.cgi?id=112362
1761
1762         Reviewed by Tony Chang.
1763
1764         Remove setAsynchronousSpellCheckingEnabled from test runners. The setting is now
1765         in internals.settings, so all ports can share it.
1766
1767         * DumpRenderTree/TestRunner.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
1768         * DumpRenderTree/TestRunner.h: Remove setAsynchronousSpellCheckingEnabled() method.
1769         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
1770         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
1771         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: Remove setAsynchronousSpellCheckingEnabled() method.
1772         * DumpRenderTree/efl/TestRunnerEfl.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
1773         * DumpRenderTree/gtk/TestRunnerGtk.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
1774         * DumpRenderTree/mac/TestRunnerMac.mm: Remove setAsynchronousSpellCheckingEnabled() method.
1775         * DumpRenderTree/qt/TestRunnerQt.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
1776         * DumpRenderTree/qt/TestRunnerQt.h: Remove setAsynchronousSpellCheckingEnabled() method.
1777         * DumpRenderTree/win/TestRunnerWin.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
1778         * DumpRenderTree/wx/TestRunnerWx.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
1779
1780 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
1781
1782         Fix the stupid unit tests.
1783
1784         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1785         (test_sample_process):
1786
1787 2013-03-14  Simon Fraser  <simon.fraser@apple.com>
1788
1789         Collect samples for unresponsive web processes
1790         https://bugs.webkit.org/show_bug.cgi?id=112409
1791
1792         Reviewed by Tim Horton.
1793         
1794         When we detect that a subprocess was unresponsive, run the 'sample'
1795         tool on that process, for the Mac port.
1796         
1797         The sample will be linked to from the results.html page, next
1798         to the crash log link.
1799
1800         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1801         (Manager._look_for_new_crash_logs): Before looking for crash logs,
1802         look for samples on disk.
1803         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1804         (TestResultWriter):
1805         (TestResultWriter.copy_sample_file): Teach TestResultWriter about
1806         -sample.txt files, and have it copy their contents to a new file
1807         next to the test that spawned them (as we do for crash logs).
1808         * Scripts/webkitpy/layout_tests/port/base.py:
1809         (Port.look_for_new_samples): Base class does nothing for sampling.
1810         * Scripts/webkitpy/layout_tests/port/driver.py:
1811         (Driver._check_for_driver_crash): Kick off a sample if we detected
1812         that the subprocess was unresponsive.
1813         * Scripts/webkitpy/layout_tests/port/mac.py:
1814         (MacPort.sample_file_path): Utility to generate the file path
1815         to the generated sample files at the top level of layout-test-results.
1816         (MacPort.look_for_new_crash_logs): Fix typo
1817         (MacPort.look_for_new_samples): New function to find sample files.
1818         (MacPort.sample_process): Use the utility function to get the file path.
1819
1820 2013-03-15  Zeno Albisser  <zeno@webkit.org>
1821
1822         [Qt] Remove simple getters and setters from TestRunnerQt
1823         https://bugs.webkit.org/show_bug.cgi?id=112343
1824
1825         Reviewed by Benjamin Poulain.
1826
1827         The removed functions and boolean members
1828         are being replaced by the implementations in the
1829         generic TestRunner.h.
1830
1831         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1832         (DumpRenderTree::dumpFrameScrollPosition):
1833         (DumpRenderTree::dumpFramesAsText):
1834         (DumpRenderTree::dump):
1835         (DumpRenderTree::titleChanged):
1836         (DumpRenderTree::dumpDatabaseQuota):
1837         (DumpRenderTree::dumpApplicationCacheQuota):
1838         (DumpRenderTree::statusBarMessage):
1839         (DumpRenderTree::createWindow):
1840         * DumpRenderTree/qt/TestRunnerQt.cpp:
1841         (TestRunnerQt::reset):
1842         * DumpRenderTree/qt/TestRunnerQt.h:
1843         (TestRunnerQt):
1844
1845 2013-03-15  Ryosuke Niwa  <rniwa@webkit.org>
1846
1847         Update the link on build.webkit.org to refer to perf.webkit.org
1848         https://bugs.webkit.org/show_bug.cgi?id=112416
1849
1850         Reviewed by Philip Rogers.
1851
1852         Updated the link. Also updated the template to use HTML5 DOCTYPE.
1853
1854         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
1855
1856 2013-03-15  Tobias Mueller  <tobiasmue@gnome.org>
1857
1858         Build fix for Tools/GtkLauncher/Programs_GtkLauncher-main.o if gstreamer is not installed
1859         https://bugs.webkit.org/show_bug.cgi?id=112394
1860
1861         Reviewed by Philippe Normand.
1862
1863         * GtkLauncher/main.c:
1864         (main): Guard using the gstreamer function with #ifdef WTF_USE_GSTREAMER
1865
1866 2013-03-14  Andreas Kling  <akling@apple.com>
1867
1868         REGRESSION(r145169): [Mac][WK2] http/tests/security/cross-frame-access-put.html fails.
1869         <http://webkit.org/b/111815>
1870         <rdar://problem/13380145>
1871
1872         Reviewed by Anders Carlsson.
1873
1874         Add PlatformWebView::didInitializeClients() and call it after setting up all the clients
1875         after creating a PlatformWebView. Otherwise, the initial WindowAndViewFramesChanged message
1876         will be sent before there's a UI client set up to adjust the frame with WTR's fake origin.
1877
1878         * WebKitTestRunner/PlatformWebView.h:
1879         (PlatformWebView):
1880         * WebKitTestRunner/TestController.cpp:
1881         (WTR::TestController::createOtherPage):
1882         (WTR::TestController::createWebViewWithOptions):
1883         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1884         (WTR::PlatformWebView::didInitializeClients):
1885
1886 2013-03-14  Jinwoo Song  <jinwoo7.song@samsung.com>
1887
1888         [EFL][MiniBrowser] Add a search field to the MiniBrowser
1889         https://bugs.webkit.org/show_bug.cgi?id=112122
1890
1891         Reviewed by Kenneth Rohde Christiansen.
1892
1893         Implement a search field to test API ewk_view_text_find() and add a shortcut 'ctrl' + f.
1894
1895         * MiniBrowser/efl/main.c:
1896         (_Browser_Window):
1897         (search_box_show):
1898         (search_box_hide):
1899         (on_key_down):
1900         (on_url_changed):
1901         (on_search_field_aborted):
1902         (on_search_field_activated):
1903         (on_search_field_clicked):
1904         (on_search_backward_button_clicked):
1905         (on_search_forward_button_clicked):
1906         (window_create):
1907
1908 2013-03-14  Julie Parent  <jparent@chromium.org>
1909
1910         Cleanup: Remove g_resourceLoader.
1911         https://bugs.webkit.org/show_bug.cgi?id=112305
1912
1913         Reviewed by Dirk Pranke.
1914         
1915         Removing another global.
1916         
1917         Now, each dashboard creates its own loader, rather than having
1918         a general global one.
1919         
1920         Remove usage of g_resourceLoader.isLoadingComplete from 
1921         handleLocationChange by ensuring that handleLocationChange is
1922         never called before the loader is done.  It was called in two
1923         places before: 1 was from the callback when the loader is done,
1924         so that was obviously true, and the other was from onhashchange,
1925         where it would just return rather than running.  Instead, lets
1926         only register the onhashchange handler once the loader is
1927         setup, so the check is no longer necessary.
1928         
1929         Remove isLoadingComplete since it is now unused.
1930         
1931         Callback for loader is now initializeHistory, rather than just
1932         handleLocationChange which will set up the hashchange handler now.
1933         This will all eventually be moving to a new History object.
1934
1935         * TestResultServer/static-dashboards/aggregate_results.html:
1936         * TestResultServer/static-dashboards/dashboard_base.js:
1937         (handleLocationChange):
1938         (intializeHistory):
1939         (decompressResults):
1940         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1941         (generatePage):
1942         * TestResultServer/static-dashboards/loader.js:
1943         (.):
1944         * TestResultServer/static-dashboards/loader_unittests.js:
1945         * TestResultServer/static-dashboards/timeline_explorer.html:
1946         * TestResultServer/static-dashboards/treemap.html:
1947
1948 2013-03-14  Manuel Rego Casasnovas  <rego@igalia.com>
1949
1950         Add selectTrailingWhitespaceEnabled setting to WebCore::Page
1951         https://bugs.webkit.org/show_bug.cgi?id=109404
1952
1953         Reviewed by Tony Chang.
1954
1955         Removes all the code related to smartInsertDeleteEnabled and
1956         selectTrailingWhitespaceEnabled settings as they will be managed from
1957         internals from now on.
1958
1959         * DumpRenderTree/TestRunner.cpp:
1960         (TestRunner::staticFunctions):
1961         * DumpRenderTree/TestRunner.h:
1962         (TestRunner):
1963         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
1964         (WebKit):
1965         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
1966         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
1967         (DumpRenderTree):
1968         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
1969         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
1970         (WebTestRunner::WebTestProxy::didStopLoading):
1971         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1972         (WebTestRunner::TestRunner::TestRunner):
1973         (WebTestRunner::TestRunner::reset):
1974         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1975         (TestRunner):
1976         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
1977         (WebTestRunner::WebPreferences::applyTo): Set default values for
1978         smartInsertDeleteEnabled and selectTrailingWhitespaceEnabled settings as
1979         Chromium DRT default values are different from Chromium browser.
1980         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
1981         * DumpRenderTree/chromium/WebViewHost.cpp:
1982         * DumpRenderTree/chromium/WebViewHost.h:
1983         (WebViewHost):
1984         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1985         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
1986         * DumpRenderTree/efl/TestRunnerEfl.cpp:
1987         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1988         (resetDefaultsToConsistentValues):
1989         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
1990         * DumpRenderTree/mac/DumpRenderTree.mm:
1991         (resetWebViewToConsistentStateBeforeTesting):
1992         * DumpRenderTree/mac/TestRunnerMac.mm:
1993         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1994         (WebCore::WebPage::resetSettings):
1995         * DumpRenderTree/qt/TestRunnerQt.cpp:
1996         * DumpRenderTree/qt/TestRunnerQt.h:
1997         (TestRunnerQt):
1998         * DumpRenderTree/win/DumpRenderTree.cpp:
1999         (resetWebViewToConsistentStateBeforeTesting):
2000         * DumpRenderTree/win/TestRunnerWin.cpp:
2001         * DumpRenderTree/wx/TestRunnerWx.cpp:
2002
2003 2013-03-14  Simon Hausmann  <simon.hausmann@digia.com>
2004
2005         [Qt] Disable DRT on Windows
2006
2007         Reviewed by Jocelyn Turcotte.
2008
2009         We don't run and maintain DRT on Windows, so let's not try to maintain the build of it.
2010
2011         * qmake/mkspecs/features/configure.prf:
2012
2013 2013-03-14  Jinwoo Song  <jinwoo7.song@samsung.com>
2014
2015         [EFL][WK2] Add an API for adding and removing user style sheets from a page group
2016         https://bugs.webkit.org/show_bug.cgi?id=110728
2017
2018         Reviewed by Gyuyoung Kim.
2019
2020         Use the page group to create the view object.
2021
2022         * MiniBrowser/efl/main.c:
2023         (window_create):
2024
2025 2013-03-14  Simon Hausmann  <simon.hausmann@digia.com>
2026
2027         [Qt] Improve the handling of mock geolocation, device orientation and motion clients
2028
2029         Reviewed by Tor Arne Vestbø.
2030
2031         The mock versions of these web facing features should be instantiated when
2032         running in DumpRenderTree only. In order for them to work, no extra Qt modules
2033         such as QtLocation are actually needed.
2034
2035         This patch decouples enabling device orientation/motion and geolocation from
2036         the underlying Qt modules and makes them available in developer builds
2037         (!production_build) and backed by mock backends when running in drt.
2038
2039         So if the Qt 5 modules are available, they'll be used (unless drtRun). For
2040         developers the web facing features are always enabled (although requests will
2041         time out) and the mock backends are enabled inside DRT, allowing for the layout
2042         tests to run with less dependencies.
2043
2044         In addition this also enables the mock device motion client, which was
2045         previously never instantiated.
2046
2047         * qmake/mkspecs/features/features.prf:
2048
2049 2013-03-14  Zeno Albisser  <zeno@webkit.org>
2050
2051         [Qt] Removing no-ops and simple setters/getters from TestRunnerQt
2052         https://bugs.webkit.org/show_bug.cgi?id=112340
2053
2054         Reviewed by Simon Hausmann.
2055
2056         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2057         (DumpRenderTree::dump):
2058             Replace shouldDumpBackForwardList() with TestController:dumpBackForwardList().
2059         (DumpRenderTree::dumpApplicationCacheQuota):
2060         * DumpRenderTree/qt/TestRunnerQt.cpp:
2061         (TestRunnerQt::reset):
2062         * DumpRenderTree/qt/TestRunnerQt.h:
2063         (TestRunnerQt):
2064
2065 2013-03-14  Zeno Albisser  <zeno@webkit.org>
2066
2067         [Qt] Port DRT to use TestRunner::dumpAsText()
2068         https://bugs.webkit.org/show_bug.cgi?id=112260
2069
2070         Reviewed by Benjamin Poulain.
2071
2072         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2073         (WebCore::DumpRenderTree::open):
2074         (WebCore::methodNameStringForFailedTest):
2075             Change parameter from type TestRunnerQt* to TestRunner*.
2076         (WebCore::DumpRenderTree::dump):
2077             TestRunnerQt::shouldDumpPixels() always returned true in our case.
2078             Instead we should rely on TestRunner::generatePixelResults().
2079         * DumpRenderTree/qt/TestRunnerQt.cpp:
2080         (TestRunnerQt::reset):
2081         * DumpRenderTree/qt/TestRunnerQt.h:
2082         (TestRunnerQt):
2083
2084 2013-03-13  Kunihiko Sakamoto  <ksakamoto@chromium.org>
2085
2086         Implement FontLoader interface
2087         https://bugs.webkit.org/show_bug.cgi?id=98395
2088
2089         Reviewed by Eric Seidel.
2090
2091         Enable FontLoadEvents runtime flag for TestShell.
2092
2093         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2094         (WebTestRunner::TestInterfaces::TestInterfaces):
2095
2096 2013-03-13  Julie Parent  <jparent@chromium.org>
2097
2098         CLeanup: remove unnecessary call to parseParameters.
2099         https://bugs.webkit.org/show_bug.cgi?id=112309
2100
2101         Reviewed by Ojan Vafai.
2102         
2103         We call parseCrossDashboardParameters when the dashboard initially
2104         loads to set the state required for loadBuildersList, and then we
2105         call it again once we are fully done with loading, so there is no
2106         reason to call it in the middle of the loading process here.
2107
2108         * TestResultServer/static-dashboards/loader.js:
2109         (.):
2110
2111 2013-03-13  Elliott Sprehn  <esprehn@chromium.org>
2112
2113         Unreviewed. Now I'm a reviewer :)
2114
2115         * Scripts/webkitpy/common/config/committers.py:
2116
2117 2013-03-13  Ryosuke Niwa  <rniwa@webkit.org>
2118
2119         Threaded HTML Parser is missing feature define flags in all but Chromium port's build files
2120         https://bugs.webkit.org/show_bug.cgi?id=112277
2121
2122         Reviewed by Adam Barth.
2123
2124         * Scripts/webkitperl/FeatureList.pm:
2125         * qmake/mkspecs/features/features.pri:
2126
2127 2013-03-13  Adam Barth  <abarth@webkit.org>
2128
2129         run-perf-tests should support content_shell
2130         https://bugs.webkit.org/show_bug.cgi?id=112291
2131
2132         Reviewed by Eric Seidel.
2133
2134         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2135         (PerfTestsRunner._parse_args):
2136
2137 2013-03-13  Oliver Hunt  <oliver@apple.com>
2138
2139         Simplify Checked<> multiplication
2140         https://bugs.webkit.org/show_bug.cgi?id=112286
2141
2142         Reviewed by James Robinson.
2143
2144         Add tests for multiplication by zero and max to ensure we don't
2145         mess them up should we ever make changes to Checked<> in future.
2146
2147         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
2148         (TestWebKitAPI):
2149
2150 2013-03-13  Simon Hausmann  <simon.hausmann@digia.com>
2151
2152         [Qt] Unreviewed prospective Windows build fix
2153
2154         Do the usual thing, include the moc generated code in the .cpp file instead
2155         of compiling it standalone, to ensure that config.h is included, too, and
2156         NOMINMAX is defined to avoid the min/max conflict when also including qdatetime.h.
2157
2158         * DumpRenderTree/qt/EventSenderQt.cpp:
2159
2160 2013-03-13  Simon Hausmann  <simon.hausmann@digia.com>
2161
2162         [Qt] Port TestRunner::findString to shared interface
2163         https://bugs.webkit.org/show_bug.cgi?id=112147
2164
2165         Reviewed by Jocelyn Turcotte.
2166
2167         This patch also removes DumpRenderTree and some other helper classes from
2168         the WebCore namespace, to which they do not really belong.
2169
2170         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
2171         (main):
2172         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2173         (DumpRenderTree::DumpRenderTree):
2174         (DumpRenderTree::~DumpRenderTree):
2175         (DumpRenderTree::instance):
2176         (DumpRenderTree::setShouldTimeout):
2177         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2178         (DumpRenderTree):
2179         * DumpRenderTree/qt/EventSenderQt.cpp:
2180         (EventSender::contextClick):
2181         (EventSender::sendEvent):
2182         (EventSender::postEvent):
2183         * DumpRenderTree/qt/EventSenderQt.h:
2184         (EventSender::isGraphicsBased):
2185         * DumpRenderTree/qt/TestRunnerQt.cpp:
2186         (TestRunnerQt::TestRunnerQt):
2187         (TestRunner::findString):
2188         (TestRunnerQt::setMockDeviceOrientation):
2189         (TestRunnerQt::setGeolocationPermission):
2190         (TestRunnerQt::numberOfPendingGeolocationPermissionRequests):
2191         (TestRunnerQt::setMockGeolocationPositionUnavailableError):
2192         (TestRunnerQt::setMockGeolocationPosition):
2193         * DumpRenderTree/qt/TestRunnerQt.h:
2194         (TestRunnerQt):
2195
2196 2013-03-13  Mikhail Naganov  <mnaganov@chromium.org>
2197
2198         [Chromium] Rename android_build_type to android_webview_build in .gyp files.
2199         https://bugs.webkit.org/show_bug.cgi?id=112129
2200
2201         Reviewed by Adam Barth.
2202
2203         Following Chromium
2204         http://src.chromium.org/viewvc/chrome?view=rev&revision=187556
2205         this is being renamed to better explain what it does.
2206
2207         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2208
2209 2013-03-13  Simon Hausmann  <simon.hausmann@digia.com>
2210
2211         [Qt] Unreviewed trivial typo fix
2212
2213         * DumpRenderTree/qt/DumpRenderTree.pro: It's TestRunner.h, not
2214         TextRunner.h. Thanks Zeno :)
2215
2216 2013-03-12  Simon Hausmann  <simon.hausmann@digia.com>
2217
2218         [Qt] Prepare DRT for transition to shared TestRunner interface
2219         https://bugs.webkit.org/show_bug.cgi?id=112144
2220
2221         Reviewed by Benjamin Poulain.
2222
2223         Prepare Qt's DRT for a transition from the QObject based TestRunner to
2224         the JSC C API based one.
2225
2226         This is impplemented by instantiating the QObject based testRunner in
2227         the global object, then instantiating the JSC C based TestRunner
2228         separately and placing it "behind" the QObject based testRunner through
2229         injection of the individual functions through proxies. (prototype
2230         chaining doesn't work due to the this object and Function.prototype.bind
2231         doesn't work due to the native function)
2232
2233         This allows for porting over method by method by removing the method
2234         from the QObject TestRunnerQt and implementing it in the JSC C based
2235         TestRunner.
2236
2237         In order for this to link and run dummy implementations of all the
2238         necessary TestRunner functions are provided.
2239
2240         * DumpRenderTree/qt/DumpRenderTree.pro:
2241         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
2242         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2243         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2244         (WebCore::DumpRenderTree::initJSObjects):
2245         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2246         (DumpRenderTree):
2247         * DumpRenderTree/qt/TestRunnerQt.cpp:
2248         (TestRunner::~TestRunner):
2249         (TestRunner::addDisallowedURL):
2250         (TestRunner::queueLoad):
2251         (TestRunner::removeAllVisitedLinks):
2252         (TestRunner::setAcceptsEditing):
2253         (TestRunner::simulateLegacyWebNotificationClick):
2254         (TestRunner::setWindowIsKey):
2255         (TestRunner::setAlwaysAcceptCookies):
2256         (TestRunner::addOriginAccessWhitelistEntry):
2257         (TestRunner::setWebViewEditable):
2258         (TestRunner::clearAllApplicationCaches):
2259         (TestRunner::setTextDirection):
2260         (TestRunner::notifyDone):
2261         (TestRunner::numberOfPendingGeolocationPermissionRequests):
2262         (TestRunner::overridePreference):
2263         (TestRunner::pathToLocalResource):
2264         (TestRunner::removeAllWebNotificationPermissions):
2265         (TestRunner::simulateWebNotificationClick):
2266         (TestRunner::closeIdleLocalStorageDatabases):
2267         (TestRunner::focusWebView):
2268         (TestRunner::setBackingScaleFactor):
2269         (TestRunner::removeChromeInputField):
2270         (TestRunner::addChromeInputField):
2271         (TestRunner::originsWithLocalStorage):
2272         (TestRunner::deleteAllLocalStorage):
2273         (TestRunner::deleteLocalStorageForOrigin):
2274         (TestRunner::observeStorageTrackerNotifications):
2275         (TestRunner::syncLocalStorage):
2276         (TestRunner::windowCount):
2277         (TestRunner::setWaitToDump):
2278         (TestRunner::waitForPolicyDelegate):
2279         (TestRunner::webHistoryItemCount):
2280         (TestRunner::showWebInspector):
2281         (TestRunner::closeWebInspector):
2282         (TestRunner::evaluateInWebInspector):
2283         (TestRunner::setSerializeHTTPLoads):
2284         (TestRunner::apiTestNewWindowDataLoadBaseURL):
2285         (TestRunner::setCustomPolicyDelegate):
2286         (TestRunner::setDatabaseQuota):
2287         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
2288         (TestRunner::resetPageVisibility):
2289         (TestRunner::keepWebHistory):
2290         (TestRunner::goBack):
2291         (TestRunner::originsWithApplicationCache):
2292         (TestRunner::applicationCacheDiskUsageForOrigin):
2293         (TestRunner::display):
2294         (TestRunner::dispatchPendingLoadRequests):
2295         (TestRunner::clearPersistentUserStyleSheet):
2296         (TestRunner::callShouldCloseOnWebView):
2297         (TestRunner::copyDecodedHostName):
2298         (TestRunner::clearBackForwardList):
2299         (TestRunner::clearAllDatabases):
2300         (TestRunner::clearApplicationCacheForOrigin):
2301         (TestRunner::apiTestGoToCurrentBackForwardItem):
2302         (TestRunner::authenticateSession):
2303         (TestRunner::abortModal):
2304         (TestRunner::setStorageDatabaseIdleInterval):
2305         (TestRunner::setAsynchronousSpellCheckingEnabled):
2306         (TestRunner::setXSSAuditorEnabled):
2307         (TestRunner::setSpatialNavigationEnabled):
2308         (TestRunner::setScrollbarPolicy):
2309         (TestRunner::setJavaScriptCanAccessClipboard):
2310         (TestRunner::setAutomaticLinkDetectionEnabled):
2311         (TestRunner::setUserStyleSheetEnabled):
2312         (TestRunner::setUserStyleSheetLocation):
2313         (TestRunner::setUseDashboardCompatibilityMode):
2314         (TestRunner::setTabKeyCyclesThroughElements):
2315         (TestRunner::setSmartInsertDeleteEnabled):
2316         (TestRunner::setSelectTrailingWhitespaceEnabled):
2317         (TestRunner::setPrivateBrowsingEnabled):
2318         (TestRunner::setPluginsEnabled):
2319         (TestRunner::setPopupBlockingEnabled):
2320         (TestRunner::setMockSpeechInputDumpRect):
2321         (TestRunner::setPersistentUserStyleSheetLocation):
2322         (TestRunner::setMockGeolocationPosition):
2323         (TestRunner::setMockGeolocationPositionUnavailableError):
2324         (TestRunner::setMockDeviceOrientation):
2325         (TestRunner::setMainFrameIsFirstResponder):
2326         (TestRunner::setIconDatabaseEnabled):
2327         (TestRunner::setGeolocationPermission):
2328         (TestRunner::setDefersLoading):
2329         (TestRunner::setCacheModel):
2330         (TestRunner::setAuthorAndUserStylesEnabled):
2331         (TestRunner::setAllowFileAccessFromFileURLs):
2332         (TestRunner::setAppCacheMaximumSize):
2333         (TestRunner::setAllowUniversalAccessFromFileURLs):
2334         (TestRunner::setApplicationCacheOriginQuota):
2335         (TestRunner::denyWebNotificationPermission):
2336         (TestRunner::grantWebNotificationPermission):
2337         (TestRunner::setValueForUser):
2338         (TestRunner::setViewModeMediaFeature):
2339         (TestRunner::setPageVisibility):
2340         (TestRunner::addMockSpeechInputResult):
2341         (TestRunner::removeOriginAccessWhitelistEntry):
2342         (TestRunner::addUserScript):
2343         (TestRunner::isCommandEnabled):
2344         (TestRunner::evaluateScriptInIsolatedWorld):
2345         (TestRunner::evaluateScriptInIsolatedWorldAndReturnValue):
2346         (TestRunner::copyEncodedHostName):
2347         (TestRunner::addUserStyleSheet):
2348         (TestRunner::findString):
2349         (TestRunner::execCommand):
2350         (TestRunner::localStorageDiskUsageForOrigin):
2351
2352 2013-03-12  Julie Parent  <jparent@chromium.org>
2353
2354         Cleanup: Move flatten-trie to loader.
2355         https://bugs.webkit.org/show_bug.cgi?id=112196
2356
2357         Reviewed by Dirk Pranke.
2358
2359         flatten-trie is used only by the loader, so move it there and make it
2360         private, rather than global in dashbaord_base. Moved the corresponding
2361         unit test from flakiness_dashboard_unittests to loader_unittests.
2362         
2363         * TestResultServer/static-dashboards/dashboard_base.js:
2364         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2365         * TestResultServer/static-dashboards/loader.js:
2366         (.):
2367         * TestResultServer/static-dashboards/loader_unittests.js:
2368
2369 2013-03-12  Oliver Hunt  <oliver@apple.com>
2370
2371         Unbreak api tests
2372
2373         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
2374         (TestWebKitAPI):
2375
2376 2013-03-12  Tim Horton  <timothy_horton@apple.com>
2377
2378         Unreviewed, disabling tests for Win EWS.
2379
2380         win-ews obviously cannot keep up with running tests, it's >300 behind.
2381         Probably doesn't help that its (likely) running tests serially.
2382
2383         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2384         (WinEWS):
2385
2386 2013-03-12  Tim Horton  <timothy_horton@apple.com>
2387
2388         Add a --build-directory argument to delete-stale-build-files
2389         https://bugs.webkit.org/show_bug.cgi?id=112198
2390
2391         Reviewed by Ryosuke Niwa.
2392
2393         * BuildSlaveSupport/delete-stale-build-files:
2394         (main): Add --build-directory argument.
2395
2396 2013-03-12  Oliver Hunt  <oliver@apple.com>
2397
2398         Appease MSVC
2399
2400         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
2401         (TestWebKitAPI):
2402
2403 2013-03-12  Oliver Hunt  <oliver@apple.com>
2404
2405         Add more Checked<> tests
2406         https://bugs.webkit.org/show_bug.cgi?id=112190
2407
2408         Reviewed by Geoffrey Garen.
2409
2410         Tests!
2411
2412         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
2413         (TestWebKitAPI):
2414
2415 2013-03-12  Julie Parent  <jparent@chromium.org>
2416
2417         Cleanup: Move loading complete function into callback, rather than global.
2418         https://bugs.webkit.org/show_bug.cgi?id=112167
2419
2420         Reviewed by Dirk Pranke.
2421         
2422         Stop calling global functions, pass in proper handler to Loader
2423         constructor. Note that the callback is optional, as tests, and
2424         some potential dashboards, do not need one.
2425
2426         * TestResultServer/static-dashboards/dashboard_base.js:
2427         * TestResultServer/static-dashboards/loader.js:
2428         (.):
2429         * TestResultServer/static-dashboards/loader_unittests.js:
2430
2431 2013-03-12  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2432
2433         [EFL][WK2] Add popup menu support to MiniBrowser
2434         https://bugs.webkit.org/show_bug.cgi?id=108934
2435
2436         Reviewed by Kenneth Rohde Christiansen.
2437
2438         Implement popup menu support in MiniBrowser by handling popup_menu_show
2439         and popup_menu_hide smart functions on the view and using the Ewk popup
2440         menu API.
2441
2442         * MiniBrowser/efl/main.c:
2443         (_Browser_Window):
2444         (on_popup_menu_discarded):
2445         (on_popup_menu_item_clicked):
2446         (popup_menu_populate):
2447         (on_popup_menu_show):
2448         (on_popup_menu_hide):
2449         (window_create): Use calloc() instead of malloc() to allocate memory for
2450         Browser_Window. This makes sure all the structs members are initialized
2451         to 0 (such as the new elm_popup_menu pointer).
2452
2453 2013-03-12  Zan Dobersek  <zdobersek@igalia.com>
2454
2455         [GTK] Set up the libPlatformGtk.la library
2456         https://bugs.webkit.org/show_bug.cgi?id=111738
2457
2458         Reviewed by Martin Robinson.
2459
2460         * GNUmakefile.am: Reference platformgtk_cppflags variable along with webcoregtk_cppflags variable.
2461         Adjust the path to GtkVersioning.c, the file has moved under Source/Platform.
2462         * TestWebKitAPI/GNUmakefile.am: Reference platformgtk_cppflags variable along with webcoregtk_cppflags variable.
2463
2464 2013-03-12  Zan Dobersek  <zdobersek@igalia.com>
2465
2466         [GTK] Enable Web Audio in development builds
2467         https://bugs.webkit.org/show_bug.cgi?id=111831
2468
2469         Reviewed by Philippe Normand.
2470
2471         Web Audio is already quite well supported on the GTK port but still has a few issues
2472         that must be addressed before it is enabled by default. Despite that it should be enabled
2473         in development builds just so we are up-to-date with future feature infrastructure changes.
2474         The Web Audio-related layout tests are not run yet due to missing support in DRT/WKTR, but
2475         that's an obvious goal before enabling the feature in release builds.
2476
2477         * Scripts/webkitperl/FeatureList.pm:
2478
2479 2013-03-11  Andreas Kling  <akling@apple.com>
2480
2481         [Mac][WK1] Add support for alert() in MiniBrowser.
2482         <http://webkit.org/b/112090>
2483
2484         Reviewed by Anders Carlsson.
2485
2486         * MiniBrowser/mac/WK1BrowserWindowController.m:
2487         (-[WK1BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
2488
2489 2013-03-11  Julie Parent  <jparent@chromium.org>
2490
2491         Dashboard cleanup: Create ui.Errors
2492         https://bugs.webkit.org/show_bug.cgi?id=111785
2493
2494         Reviewed by Ojan Vafai.
2495         
2496         Create ui.Errors for handling errors the dashboards
2497         encounter. Loader now has a Error object that it can add to,
2498         and individual dashboards can show errors when desired.
2499         Currently, only flakiness_db shows errors, but this is 
2500         generic and there is no reason why other dbs wouldn't want to
2501         show errors.
2502
2503         * TestResultServer/static-dashboards/dashboard_base.js:
2504         (resourceLoadingComplete):
2505         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2506         (generatePage):
2507         * TestResultServer/static-dashboards/loader.js:
2508         (.):
2509         * TestResultServer/static-dashboards/ui.js:
2510         (.):
2511
2512 2013-03-08  Geoffrey Garen  <ggaren@apple.com>
2513
2514         Some StringHasher tests are broken because of missing null termination
2515         https://bugs.webkit.org/show_bug.cgi?id=111284
2516
2517         Reviewed by Darin Adler.
2518
2519         * TestWebKitAPI/Tests/WTF/StringHasher.cpp:
2520         (TestWebKitAPI): Added null termination since C strings are null-terminated.
2521         (TestWebKitAPI::TEST): Removed #ifdef's that disabled this testing since
2522         the bug caught by it is now fixed.
2523
2524 2013-03-11  Sheriff Bot  <webkit.review.bot@gmail.com>
2525
2526         Unreviewed, rolling out r145200.
2527         http://trac.webkit.org/changeset/145200
2528         https://bugs.webkit.org/show_bug.cgi?id=112063
2529
2530         Broke a couple of unit tests (Requested by zdobersek on
2531         #webkit).
2532
2533         * Scripts/webkitperl/FeatureList.pm:
2534
2535 2013-03-11  Zan Dobersek  <zdobersek@igalia.com>
2536
2537         [GTK] WebKit2-only build fails
2538         https://bugs.webkit.org/show_bug.cgi?id=112033
2539
2540         Reviewed by Gustavo Noronha Silva.
2541
2542         * GNUmakefile.am: Split the list of files the docs-build.stamp target depends on into the
2543         generic part, WebKit1-specific part and WebKit2-specific part.
2544         * TestWebKitAPI/GNUmakefile.am: The TestGtk executable should not link agains libwebkitgtk
2545         as it is not WebKit1-specific, but should rather link to libWebCore.la and libWebCoreGtk.la
2546         directly.
2547
2548 2013-03-11  Dima Gorbik  <dgorbik@apple.com>
2549
2550         Adding myself to the committers list.
2551
2552         Unreviewed.
2553
2554         * Scripts/webkitpy/common/config/committers.py:
2555
2556 2013-03-11  Jeff Rogers  <jrogers@rim.com>
2557
2558         [BlackBerry] Disable MathML support
2559         https://bugs.webkit.org/show_bug.cgi?id=111929
2560
2561         Reviewed by Rob Buis.
2562
2563         * Scripts/webkitperl/FeatureList.pm:
2564
2565 2013-03-11  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2566
2567         [EFL][GTK][WKTR] Regression(r145231): Undefined symbol in libTestRunnerInjectedBundle.so
2568         https://bugs.webkit.org/show_bug.cgi?id=111970
2569
2570         Reviewed by Chris Fleizach.
2571
2572         Provide dummy implementation for AccessibilityUIElement::supportedActions() in ATK
2573         or libTestRunnerInjectedBundle.so cannot be loaded in EFL / GTK otherwise, due to
2574         undefined symbol.
2575
2576         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2577         (WTR::AccessibilityUIElement::supportedActions):
2578         (WTR):
2579
2580 2013-03-11  Chris Hopman  <cjhopman@chromium.org>
2581
2582         [chromium] Android apk targets should depend directly on Java library targets
2583         https://bugs.webkit.org/show_bug.cgi?id=111746
2584
2585         Reviewed by Eric Seidel.
2586
2587         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2588         Make DumpRenderTree_apk depend directly on base_java and net_java.
2589         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
2590         Make TestWebKitAPI_apk depend directly on base_java.
2591
2592 2013-03-11  Jochen Eisinger  <jochen@chromium.org>
2593
2594         [chromium] remove obsolete user gesture methods from WebFrame
2595         https://bugs.webkit.org/show_bug.cgi?id=111696
2596
2597         Reviewed by Adam Barth.
2598
2599         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp:
2600         (WebTestRunner::TestPlugin::handleInputEvent):
2601         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
2602
2603 2013-03-10  Silvia Pfeiffer  <silviapf@chromium.org>
2604
2605         Unreviewed, add myself to commiters.py.
2606
2607         * Scripts/webkitpy/common/config/committers.py:
2608
2609 2013-03-08  Julie Parent  <jparent@chromium.org>
2610
2611         Cleanup: Remove dead code.
2612         https://bugs.webkit.org/show_bug.cgi?id=111900
2613
2614         Reviewed by Dirk Pranke.
2615         
2616         Treemap overrides a global function that used to be in 
2617         dashboard_base, but was removed months ago in
2618         https://bugs.webkit.org/show_bug.cgi?id=99246, so this code has
2619         no caller. 
2620
2621         * TestResultServer/static-dashboards/treemap.html:
2622
2623 2013-03-08  Harald Alvestrand  <hta@chromium.org>
2624
2625         Implemented new API for RTCStatsReport object.
2626         https://bugs.webkit.org/show_bug.cgi?id=110333
2627
2628         Reviewed by Adam Barth.
2629
2630         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp:
2631         (WebTestRunner::MockWebRTCPeerConnectionHandler::getStats):
2632
2633 2013-03-08  Dirk Pranke  <dpranke@chromium.org>
2634
2635         [chromium] use custom freetype on linux asan builds again
2636         https://bugs.webkit.org/show_bug.cgi?id=111884
2637
2638         Reviewed by Tony Chang.
2639
2640         We no longer need the workaround after chromium r186540.
2641
2642         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2643
2644 2013-03-08  Ryosuke Niwa  <rniwa@webkit.org>
2645
2646         Warning about the user not having edit rights on Bugzilla is confusing new contributors
2647         https://bugs.webkit.org/show_bug.cgi?id=111798
2648
2649         Reviewed by Dirk Pranke.
2650
2651         Don't scare people by the warning. Instead, tell them to ignore it if they don't have EditBugs privileges.
2652
2653         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2654
2655 2013-03-08  James Robinson  <jamesr@chromium.org>
2656
2657         [chromium] Remove WebLayerTreeViewClient and WebLayerTreeView::Settings
2658         https://bugs.webkit.org/show_bug.cgi?id=111632
2659
2660         Reviewed by Adrienne Walker.
2661
2662         * DumpRenderTree/chromium/WebViewHost.cpp:
2663         (WebViewHost::initializeLayerTreeView):
2664         * DumpRenderTree/chromium/WebViewHost.h:
2665         (WebViewHost):
2666
2667 2013-03-08  Benjamin Poulain  <benjamin@webkit.org>
2668
2669         [Mac] Add a feature flag for 'view-mode' Media Feature, disable it on Mac
2670         https://bugs.webkit.org/show_bug.cgi?id=111297
2671
2672         Reviewed by Kenneth Rohde Christiansen.
2673
2674         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2675         (WTR::TestRunner::setViewModeMediaFeature):
2676
2677 2013-03-08  Chris Fleizach  <cfleizach@apple.com>
2678
2679         [Mac] [WK2] platform/mac/accessibility/press-action-is-first.html fails
2680         https://bugs.webkit.org/show_bug.cgi?id=111814
2681
2682         Reviewed by Ryosuke Niwa.
2683
2684         Add the needed supportedActions() attribute to WKTestRunner.
2685
2686         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2687         (WTR::AccessibilityUIElement::supportedActions):
2688         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2689         (AccessibilityUIElement):
2690         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2691         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2692         (WTR::AccessibilityUIElement::supportedActions):
2693
2694 2013-03-08  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2695
2696         [EFL] Memory leak at WKViewClientWebProcessCallbacks API test
2697         https://bugs.webkit.org/show_bug.cgi?id=111851
2698
2699         Reviewed by Kenneth Rohde Christiansen.
2700
2701         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
2702         (TestWebKitAPI::TEST):
2703
2704             Fixed WKURLRef instance leaking.
2705
2706 2013-03-08  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2707
2708         [EFL] [WK2] Some authentication tests fail in WebKit2
2709         https://bugs.webkit.org/show_bug.cgi?id=106407
2710
2711         Reviewed by Kenneth Rohde Christiansen.
2712
2713         Add patch from upstream for libsoup 2.40 to fix several authentication
2714         test cases.
2715
2716         * efl/jhbuild.modules:
2717         * efl/patches/libsoup-2.40-auth-fix.patch: Added.
2718
2719 2013-03-08  Zan Dobersek  <zdobersek@igalia.com>
2720
2721         [GTK] Enable Web Audio in development builds
2722         https://bugs.webkit.org/show_bug.cgi?id=111831
2723
2724         Reviewed by Philippe Normand.
2725
2726         Web Audio is already quite well supported on the GTK port but still has a few issues
2727         that must be addressed before it is enabled by default. Despite that it should be enabled
2728         in development builds just so we are up-to-date with future feature infrastructure changes.
2729         The Web Audio-related layout tests are not run yet due to missing support in DRT/WKTR, but
2730         that's an obvious goal before enabling the feature in release builds.
2731
2732         * Scripts/webkitperl/FeatureList.pm:
2733
2734 2013-03-07  Jochen Eisinger  <jochen@chromium.org>
2735
2736         [chromium] delay clearing the TestRunners until the main view was deleted
2737         https://bugs.webkit.org/show_bug.cgi?id=111823
2738
2739         Reviewed by Eric Seidel.
2740
2741         During WebViewHost::shutdown, we navigate the WebView to about:blank.
2742         This may call into the test runners which assume that the delegate is
2743         always non-NULL.
2744
2745         * DumpRenderTree/chromium/TestShell.cpp:
2746         (TestShell::~TestShell):
2747
2748 2013-03-07  Alan Cutter  <alancutter@chromium.org>
2749
2750         Sheriffbot whois command can't search by full name
2751         https://bugs.webkit.org/show_bug.cgi?id=111825
2752
2753         Reviewed by Eric Seidel.
2754
2755         Allowed multiple arguments to Sheriffbot's whois command.
2756         Updated test expectations.
2757
2758         * Scripts/webkitpy/tool/bot/irc_command.py:
2759         (Whois.execute):
2760         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2761         (IRCCommandTest.test_whois):
2762
2763 2013-03-07  Nils Barth  <nbarth@chromium.org>
2764
2765         Add Nils Barth and Koji Hara to committers.py
2766         https://bugs.webkit.org/show_bug.cgi?id=111806
2767
2768         Reviewed by Eric Seidel.
2769
2770         * Scripts/webkitpy/common/config/committers.py:
2771
2772 2013-03-07  Glenn Adams  <glenn@skynav.com>
2773
2774         run-pert-tests should have a --test-runner-count option
2775         https://bugs.webkit.org/show_bug.cgi?id=111726
2776
2777         Reviewed by Ryosuke Niwa.
2778
2779         Add --test-runner-count option to run-perf-tests, with default value of 4.
2780         This option allows command line configuration of the number of times to invoke
2781         the test runner (serially, not in parallel) when running a specific test in
2782         a test set.
2783
2784         * Scripts/webkitpy/performance_tests/perftest.py:
2785         (PerfTest): Add DEFAULT_TEST_RUNNER_COUNT constant.
2786         (PerfTest.__init__): Rename process_run_count to test_runner_count (throughout).
2787         (PerfTest.run): Rename process_run_count to test_runner_count.
2788         (SingleProcessPerfTest.__init__): Add test_runner_count optional argument.
2789         (ChromiumStylePerfTest.__init__): Add test_runner_count optional argument.
2790         (ReplayPerfTest.__init__): Add test_runner_count optional argument.
2791         (PerfTestFactory.create_perf_test): Add test_runner_count optional argument.
2792         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2793         (PerfTestsRunner._parse_args): Add '--test-runner-count' option.
2794         (PerfTestsRunner._collect_tests): Use test_runner_count when creating PerfTest.
2795         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
2796         (MainTest._test_run_with_json_output): Add optional compare_logs argument.
2797         (MainTest.test_run_with_repeat):
2798         (MainTest.test_run_with_test_runner_count): Add new test for test-runner-count option semantics.
2799         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2800         (MainTest.test_default_args): Add test for default option argument values.
2801         (MainTest.test_parse_args): Add test for test-runner-count option parsing.
2802
2803 2013-03-07  Christian Biesinger  <cbiesinger@chromium.org>
2804
2805         Add myself to reviewers.py
2806         https://bugs.webkit.org/show_bug.cgi?id=111757
2807
2808         Reviewed by Eric Seidel.
2809
2810         * Scripts/webkitpy/common/config/committers.py:
2811
2812 2013-03-07  Glenn Adams  <glenn@skynav.com>
2813
2814         run-perf-tests should have a --repeat option
2815         https://bugs.webkit.org/show_bug.cgi?id=100030
2816
2817         Reviewed by Ryosuke Niwa.
2818
2819         Add --repeat option to run-perf-tests, with default value of 1. When greater
2820         than 1, runs test set specified number of times. Note that multiple runs are
2821         not aggregated for statistical purposes.
2822
2823         Incidentally fixed typo: s/suceeds/succeeds/.
2824
2825         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2826         (PerfTestsRunner._parse_args): Add repeat option.
2827         (PerfTestsRunner.run): Add outer repeat loop.
2828         (PerfTestsRunner._generate_results): Split from original _generate_and_show_results.
2829         (PerfTestsRunner._upload_and_show_results): Split from original _generate_and_show_results.
2830         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
2831         (MainTest._test_run_with_json_output): Add repeat optional argument for generating expected logs. Fix typo.
2832         (MainTest._test_run_with_json_output.mock_upload_json): Fix typo.
2833         (MainTest.test_run_with_json_output): Fix typo.
2834         (MainTest.test_run_with_description): Fix typo.
2835         (MainTest.test_run_respects_no_results): Fix typo.
2836         (MainTest.test_run_with_slave_config_json): Fix typo.
2837         (MainTest.test_run_with_multiple_repositories): Fix typo.
2838         (MainTest.test_run_with_upload_json): Fix typo.
2839         (MainTest.test_run_with_upload_json_should_generate_perf_webkit_json): Fix typo.
2840         (MainTest.test_run_with_repeat): Added new test for repeat count semantics.
2841         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2842         (MainTest.test_parse_args): Add test for repeat option parsing.
2843
2844 2013-03-07  Julie Parent  <jparent@chromium.org>
2845
2846         showAllRuns checkbox no longer works on the stats dashboard
2847         https://bugs.webkit.org/show_bug.cgi?id=111673
2848
2849         Reviewed by Ojan Vafai.
2850
2851         Stats dashboard does not have any DB_SPECIFIC_INVALIDATING_PARAMETERS,
2852         so we were trying to index into an undefined object.
2853         
2854         * TestResultServer/static-dashboards/dashboard_base.js:
2855         (invalidateQueryParameters):
2856
2857 2013-03-07  Mark Pilgrim  <pilgrim@chromium.org>
2858
2859         [Chromium] Update #include for WebStorageNamespace.h
2860         https://bugs.webkit.org/show_bug.cgi?id=111748
2861
2862         Reviewed by Adam Barth.
2863
2864         In anticipation of removing
2865         WK/chromium/public/WebStorageNamespace.h (once downstream
2866         references have been updated)
2867
2868         * DumpRenderTree/chromium/WebViewHost.cpp:
2869
2870 2013-03-07  Dirk Pranke  <dpranke@chromium.org>
2871
2872         run-perf-tests fails due to svn_revision not working on a pure git clone
2873         https://bugs.webkit.org/show_bug.cgi?id=110839
2874
2875         Reviewed by Ryosuke Niwa.
2876
2877         Previously we would call git svn find-rev to look up the commit for
2878         a given revision, and that'll hang in a pure git checkout.
2879
2880         This patch changes the way we look up svn revisions in a git
2881         repository to use git log --grep 'git-svn-id', which is much faster
2882         than grepping ourselves. It also renames timestamp_of_latest_commit()
2883         to timestamp_of_revision() in order to accurately reflect what
2884         the method is doing. Note that this patch only changes the logic
2885         inside latest_revision() and svn_revision(). I'll file a separate
2886         bug to change git_commit_from_svn_revision().
2887
2888         This patch also contains some fixes to unit tests that had bit-rotted
2889         or were otherwise fragile, so that test-webkitpy --all would pass
2890         cleanly, and a fix to outputcapture so that
2891         test-webkitpy -p would work correctly again.
2892
2893         * Scripts/webkitpy/common/checkout/scm/git.py:
2894         (Git.svn_revision):
2895         (Git.timestamp_of_revision):
2896         * Scripts/webkitpy/common/checkout/scm/scm.py:
2897         (SCM.svn_revision):
2898         (SCM.timestamp_of_revision):
2899         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2900         (MockSCM.timestamp_of_revision):
2901         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2902         (_shared_test_commit_with_message):
2903         (test_commit_without_authorization):
2904         (test_timestamp_of_revision):
2905         * Scripts/webkitpy/common/checkout/scm/svn.py:
2906         (SVN.timestamp_of_revision):
2907         * Scripts/webkitpy/common/system/outputcapture.py:
2908           Importing unittest2 directly may not be safe if this module is
2909           imported before the autoinstaller gets a chance to set things up
2910           properly. We don't actually need unittest2 here.
2911         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2912         (PerfTestsRunner._generate_results_dict):
2913
2914 2013-03-07  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2915
2916         [EFL] Bump libsoup dependency to 2.40.3 to fix regressions
2917         https://bugs.webkit.org/show_bug.cgi?id=111756
2918
2919         Reviewed by Kenneth Rohde Christiansen.
2920
2921         Bump libsoup to v2.40.3 to fix the regressions introduced by
2922         previous v2.40.0 bump.
2923
2924         * efl/jhbuild.modules:
2925
2926 2013-03-07  Roger Fong  <roger_fong@apple.com>
2927
2928         Re-enable Win EWS tests.
2929
2930         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2931         (WinEWS):
2932
2933 2013-03-07  Dirk Pranke  <dpranke@chromium.org>
2934
2935         [nrwt] handle corrupt http server pid files cleanly
2936         https://bugs.webkit.org/show_bug.cgi?id=111628
2937
2938         Reviewed by Eric Seidel.
2939
2940         If the pid file from a previous http server is corrupt for some
2941         reason, NRWT will just raise errors and not clean it up or recover.
2942         This patch fixes that to at least delete the pid file and
2943         not throw; not that we may still have stale http servers left on
2944         the system, since there's no way to know which pid to kill if
2945         the file was corrupted.
2946
2947         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
2948         (HttpServerBase.start):
2949         (HttpServerBase.stop):
2950         (HttpServerBase._remove_pid_file):
2951         * Scripts/webkitpy/layout_tests/servers/http_server_base_unittest.py: Added.
2952         (TestHttpServerBase):
2953         (TestHttpServerBase.test_corrupt_pid_file):
2954
2955 2013-03-07  Chris Fleizach  <cfleizach@apple.com>
2956
2957         AX: Can't activate links with VoiceOver in Safari
2958         https://bugs.webkit.org/show_bug.cgi?id=111755
2959
2960         Reviewed by Tim Horton.
2961
2962         * DumpRenderTree/AccessibilityUIElement.cpp:
2963         (supportedActionsCallback):
2964         (AccessibilityUIElement::getJSClass):
2965         * DumpRenderTree/AccessibilityUIElement.h:
2966         (AccessibilityUIElement):
2967         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2968         (AccessibilityUIElement::supportedActions):
2969
2970 2013-03-07  Roger Fong  <roger_fong@apple.com>
2971
2972         Windows debug layout tests are crashing like crazy again.
2973         Disable tests on Win EWS bots temporarily.
2974
2975         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2976         (WinEWS):
2977
2978 2013-03-07  Roger Fong  <roger_fong@apple.com>
2979
2980         Make EWS bots build and test in release.
2981
2982         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2983         (WinEWS):
2984         * Scripts/webkitpy/tool/steps/runtests.py:
2985         (RunTests.run):
2986
2987 2013-03-07  Jochen Eisinger  <jochen@chromium.org>
2988
2989         [chromium] don't track the top loading frame if no layout test is currently running
2990         https://bugs.webkit.org/show_bug.cgi?id=111716
2991
2992         Reviewed by Kentaro Hara.
2993
2994         In DRT, we synchronously stop the test and start loading the next test
2995         URL. However, in content_shell, this happens asynchronously. It's
2996         important that the top loading frame is not changed due to stray
2997         navigation events before the next test starts.
2998
2999         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3000         (WebTestRunner::TestRunner::setTopLoadingFrame):
3001
3002 2013-03-06  Julie Parent  <jparent@chromium.org>
3003
3004         Dashboard cleanup: Move all dashboard ui related code into ui.js.
3005         https://bugs.webkit.org/show_bug.cgi?id=111621
3006
3007         Reviewed by Ojan Vafai.
3008         
3009         Creates ui.js, a package for the common UI code the various
3010         dashboards use. HTML generation is now in the ui.html namespace
3011         and popup handling is in ui.popup.
3012         Also moves the event listening for popups to ui.popup.show and
3013         removes it on ui.popup.hid rather than having listener always
3014         around.
3015
3016         * TestResultServer/static-dashboards/aggregate_results.html:
3017         * TestResultServer/static-dashboards/dashboard_base.js:
3018         * TestResultServer/static-dashboards/flakiness_dashboard.html:
3019         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3020         (showPopupForBuild):
3021         (htmlForNavBar):
3022         (generatePageForIndividualTests.if):
3023         (generatePageForIndividualTests):
3024         * TestResultServer/static-dashboards/flakiness_dashboard_embedded_unittests.js:
3025         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3026         * TestResultServer/static-dashboards/run-embedded-unittests.html:
3027         * TestResultServer/static-dashboards/run-unittests.html:
3028         * TestResultServer/static-dashboards/timeline_explorer.html:
3029         * TestResultServer/static-dashboards/treemap.html:
3030         * TestResultServer/static-dashboards/ui.js: Added.
3031         (.):
3032
3033 2013-03-06  Krzysztof Czech  <k.czech@samsung.com>
3034
3035         [EFL] Missing implementation of AccessibilityControllerEfl and AccessibilityUIElementEfl files
3036         https://bugs.webkit.org/show_bug.cgi?id=110584
3037
3038         Reviewed by Gyuyoung Kim.
3039
3040         Adds missing implementation of AccessibilityControllerEfl
3041         and AccessibilityUIElementEfl files. Modify DumpRenderTreeChrome
3042         so that it can make accessibilityController as a js object.
3043
3044         * DumpRenderTree/AccessibilityController.h:
3045         (AccessibilityController):
3046         * DumpRenderTree/AccessibilityUIElement.h:
3047         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
3048         (AccessibilityController::childElementById): Moved declaration to base class.
3049         Implementation can be shared among other ports.
3050         * DumpRenderTree/efl/AccessibilityControllerEfl.cpp: Copied from Tools/DumpRenderTree/gtk/AccessibilityControllerGtk.cpp.
3051         (AccessibilityController::focusedElement):
3052         (AccessibilityController::rootElement):
3053         (AccessibilityController::accessibleElementById):
3054         * DumpRenderTree/efl/AccessibilityUIElementEfl.cpp: Copied from Tools/DumpRenderTree/atk/AccessibilityControllerAtk.cpp.
3055         (AccessibilityUIElement::helpText):
3056         * DumpRenderTree/efl/CMakeLists.txt:
3057         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3058         (DumpRenderTreeChrome::DumpRenderTreeChrome):
3059         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
3060         (DumpRenderTreeChrome::onWindowObjectCleared):
3061         (DumpRenderTreeChrome::accessibilityController):
3062         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
3063         (DumpRenderTreeChrome):
3064         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
3065
3066 2013-03-06  Benjamin Poulain  <benjamin@webkit.org>
3067
3068         WebKitTestRunner needs layoutTestController.elementDoesAutoCompleteForElementWithId
3069         https://bugs.webkit.org/show_bug.cgi?id=42696
3070
3071         Reviewed by Andreas Kling.
3072
3073         * DumpRenderTree/TestRunner.cpp:
3074         (TestRunner::staticFunctions):
3075         * DumpRenderTree/TestRunner.h:
3076         (TestRunner):
3077         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
3078         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3079         (WebTestRunner::TestRunner::TestRunner):
3080         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3081         (TestRunner):
3082         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3083         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
3084         * DumpRenderTree/mac/TestRunnerMac.mm:
3085         * DumpRenderTree/qt/TestRunnerQt.cpp:
3086         * DumpRenderTree/qt/TestRunnerQt.h:
3087         (TestRunnerQt):
3088         * DumpRenderTree/win/TestRunnerWin.cpp:
3089         * DumpRenderTree/wx/TestRunnerWx.cpp:
3090
3091 2013-03-06  Roger Fong  <roger_fong@apple.com>
3092
3093         Re-enable WinEWS test and decrease iterations before clean build back to 10.
3094
3095         * EWSTools/start-queue-win.sh:
3096         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3097         (WinEWS):
3098
3099 2013-03-06  Manuel Rego Casasnovas  <rego@igalia.com>
3100
3101         [WK2][GTK] Fix unit test WebKit2APITests/WebKitWebView/mouse-target
3102         https://bugs.webkit.org/show_bug.cgi?id=82866
3103
3104         Reviewed by Martin Robinson.
3105
3106         * Scripts/run-gtk-tests:
3107         (TestRunner): Unflag WebKit2APITests/WebKitWebView/mouse-target test as
3108         it is passing now.
3109
3110 2013-03-06  Julie Parent  <jparent@chromium.org>
3111
3112         Dashboard cleanup: remove dashboard time logging.
3113         https://bugs.webkit.org/show_bug.cgi?id=111608
3114
3115         Reviewed by Dirk Pranke.
3116
3117         Remove logTime.  It was never accurate, and the dev tools
3118         have better ways to measure this if anyone cares to look
3119         into dashboard perf.
3120         
3121         * TestResultServer/static-dashboards/dashboard_base.js:
3122         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3123         (processTestRunsForBuilder):
3124         (appendHTML):
3125
3126 2013-03-06  Tony Chang  <tony@chromium.org>
3127
3128         [chromium] making DumpRenderTree_resources a separate bundle breaks xcode
3129         https://bugs.webkit.org/show_bug.cgi?id=111509
3130
3131         Reviewed by Dirk Pranke.
3132
3133         Add DumpRenderTree.pak to DumpRenderTree.app again.
3134
3135         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3136
3137 2013-03-06  Jochen Eisinger  <jochen@chromium.org>
3138
3139         [chromium] introduce WebUserGestureIndicator
3140         https://bugs.webkit.org/show_bug.cgi?id=111531
3141
3142         Reviewed by Adam Barth.
3143
3144         * DumpRenderTree/chromium/WebViewHost.cpp:
3145         (WebViewHost::createView):
3146
3147 2013-03-06  Alan Cutter  <alancutter@chromium.org>
3148
3149         sheriffbot roll-chromium-deps shouldn't create a bug with None as the new revision.
3150         https://bugs.webkit.org/show_bug.cgi?id=73482
3151
3152         Reviewed by Ryosuke Niwa.
3153
3154         Added input checking to the UpdateChromiumDEPS step.
3155         Removed the default use of LKGR when the revision input is invalid. "LKGR" must be explicitly given instead.
3156
3157         * Scripts/webkitpy/tool/bot/irc_command.py: Updated input validation and error message handling.
3158         (RollChromiumDEPS):
3159         (RollChromiumDEPS._parse_args):
3160         (RollChromiumDEPS.execute):
3161         * Scripts/webkitpy/tool/bot/irc_command_unittest.py: Updated unit tests.
3162         (IRCCommandTest.test_roll_chromium_deps):
3163         * Scripts/webkitpy/tool/bot/ircbot_unittest.py: Updated unit tests.
3164         (IRCBotTest.test_roll_chromium_deps_to_lkgr):
3165         * Scripts/webkitpy/tool/commands/roll_unittest.py: Updated unit tests.
3166         * Scripts/webkitpy/tool/steps/updatechromiumdeps.py: Added input validation and added new error handling cases. Changed the logic of deciding to use LKGR to be only when the input is "LKGR".
3167         (UpdateChromiumDEPS._fetch_last_known_good_revision):
3168         (UpdateChromiumDEPS):
3169         (UpdateChromiumDEPS._parse_revision_number):
3170         (UpdateChromiumDEPS._validate_revisions):
3171         (UpdateChromiumDEPS.run):
3172         * Scripts/webkitpy/tool/steps/updatechromiumdeps_unittest.py: Added unit tests.
3173         (UpdateChromiumDEPSTest):
3174         (UpdateChromiumDEPSTest.test_parse_revision_number):
3175         * Scripts/webkitpy/tool/commands/roll.py: Updated help text.
3176         (RollChromiumDEPS):
3177         (PostChromiumDEPSRoll):
3178
3179 2013-03-06  Andras Becsi  <andras.becsi@digia.com>
3180
3181         [Qt][MiniBrowser] Touch mocking broken for chained getures
3182         https://bugs.webkit.org/show_bug.cgi?id=111430
3183
3184         Reviewed by Jocelyn Turcotte.
3185
3186         Make it possible again to use touch mocking to test gesture chains
3187         like pan->pinch->pan->pinch without lifting the primary "finger".
3188         For this to work we need to track the pressed mouse buttons and
3189         only synthesize touch release events when the ctrl key is released
3190         if no mouse button is pressed. Else the pressed mouse button(s)
3191         should result in a stationary touch point in a touch update event.
3192         Since it has been fixed in Qt 5.0.1 use QGuiApplication::keyboardModifiers()
3193         to check for the state of the ctrl key modifier instead of getting
3194         it from the mouse events.
3195
3196         * MiniBrowser/qt/MiniBrowserApplication.cpp:
3197         (MiniBrowserApplication::MiniBrowserApplication):
3198         (MiniBrowserApplication::notify):
3199
3200 2013-03-05  Dirk Pranke  <dpranke@chromium.org>
3201
3202         [chromium] don't use custom freetype on linux asan for now
3203         https://bugs.webkit.org/show_bug.cgi?id=111516
3204
3205         Unreviewed, build fix.
3206
3207         Turns out the custom lib is getting picked up by other binaries
3208         on our bot, which is bad.
3209
3210         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3211
3212 2013-03-05  Dirk Pranke  <dpranke@chromium.org>
3213
3214         [chromium] making DumpRenderTree_resources a separate bundle breaks xcode
3215         https://bugs.webkit.org/show_bug.cgi?id=111509
3216
3217         Unreviewed, build fix.
3218
3219         Actually comment out the flag :(.
3220
3221         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3222
3223 2013-03-05  Dirk Pranke  <dpranke@chromium.org>
3224
3225         [chromium] making DumpRenderTree_resources a separate bundle breaks xcode
3226         https://bugs.webkit.org/show_bug.cgi?id=111509
3227
3228         Unreviewed, build fix.
3229
3230         r144863 appears to have broken the xcode build; I'm temporarily
3231         trying this instead, and if this doesn't work, I'll revert the
3232         other changes.
3233
3234         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3235
3236 2013-03-05  Dirk Pranke  <dpranke@chromium.org>
3237
3238         [chromium] build a DumpRenderTree.pak even on windows
3239         https://bugs.webkit.org/show_bug.cgi?id=111504
3240
3241         Reviewed by Tony Chang.
3242
3243         The Chromium Aura build uses the default theme to draw
3244         controls, and that theme requires the ui ResourceBundle
3245         to be initialized. On every other platform, we build
3246         a DumpRenderTree.pak that works for this, but on Windows we
3247         still compile the resources directly into DRT. As a first step,
3248         let's build the pak file. I will then need to land a patch
3249         in Chromium to actually load it. Then I can go back and move
3250         the resources over to just use the .pak file and no longer need
3251         the .rc's.
3252
3253         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3254
3255 2013-03-05  Julie Parent  <jparent@chromium.org>
3256         Dashboard cleanup: move string utilities into their own namespace.
3257         
3258         https://bugs.webkit.org/show_bug.cgi?id=111485
3259
3260         Reviewed by Ojan Vafai.
3261         
3262         One of many pieces to clean up dashboard_base.
3263         
3264         Moves string utility functions into separate file (string.js) and into their own namespace rather than cluttering up the global scope.
3265
3266         * TestResultServer/static-dashboards/aggregate_results.html:
3267         * TestResultServer/static-dashboards/dashboard_base.js:
3268         (isTreeMap):
3269         (isFlakinessDashboard):
3270         * TestResultServer/static-dashboards/flakiness_dashboard.html:
3271         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3272         (determineWKPlatform):
3273         (chromiumPlatform):
3274         (platformAndBuildType):
3275         (substringList):
3276         (individualTestsForSubstringList):
3277         (filterBugs):
3278         (populateExpectationsData):
3279         (processMissingTestsWithExpectations):
3280         (processMissingAndExtraExpectations):
3281         (htmlForSingleTestRow):
3282         (.dummyNode.onload):
3283         (expectationsTitle):
3284         * TestResultServer/static-dashboards/run-embedded-unittests.html:
3285         * TestResultServer/static-dashboards/run-unittests.html:
3286         * TestResultServer/static-dashboards/string.js: Added.
3287         * TestResultServer/static-dashboards/timeline_explorer.html:
3288         * TestResultServer/static-dashboards/treemap.html:
3289
3290 2013-03-05  Ryuan Choi  <ryuan.choi@samsung.com>
3291
3292         [EFL] Build break with latest EFL libraries
3293         https://bugs.webkit.org/show_bug.cgi?id=111028
3294
3295         Reviewed by Dirk Pranke.
3296
3297         * MiniBrowser/efl/CMakeLists.txt: Added ECORE_XXX_INCLUDE_DIRS.
3298         * TestWebKitAPI/PlatformEfl.cmake: Ditto.
3299         * WebKitTestRunner/PlatformEfl.cmake: Ditto.
3300
3301 2013-03-05  Roger Fong  <roger_fong@apple.com>
3302
3303         Increase number of WinEWS iterations to 20.
3304         Don't reboot after each iteration set.
3305         Make EWS bots just build temporarily so that the queue catches up again.
3306
3307         * EWSTools/start-queue-win.sh:
3308         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3309         (WinEWS):
3310
3311 2013-03-04  James Robinson  <jamesr@chromium.org>
3312
3313         [chromium] Move check for threaded compositing from WebCompositorSupport to Platform
3314         https://bugs.webkit.org/show_bug.cgi?id=111386
3315
3316         Reviewed by Adrienne Walker.
3317
3318         * DumpRenderTree/chromium/TestShell.cpp:
3319         (TestShell::initialize):
3320
3321 2013-03-05  Min Qin  <qinmin@chromium.org>
3322
3323         Copy dictionary to the external storage before running layout test on android
3324         https://bugs.webkit.org/show_bug.cgi?id=111480
3325
3326         Reviewed by Adam Barth.
3327
3328         TestWebKitPlatformSupport now needs to read an external dictionary file.
3329         This file does not exist on the device. We need to copy it before running layout tests.
3330
3331         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3332         (ChromiumAndroidDriver._setup_md5sum_and_push_data_if_needed):
3333         (ChromiumAndroidDriver._push_platform_resources):
3334
3335 2013-03-05  Dirk Pranke  <dpranke@chromium.org>
3336
3337         [chromium] DRT crashes in an Aura/Win build
3338         https://bugs.webkit.org/show_bug.cgi?id=111394
3339
3340         Reviewed by Tony Chang.
3341
3342         When building (and running) with use_aura=1, we assume that
3343         we're using the default theme engine, but DRT creates the
3344         DRTWin theme engine and overwrites the default, leading to crashes
3345         in basically every test from the mismatch.
3346
3347         This fix gets us down to at least "lots of crashes" :).
3348
3349         * DumpRenderTree/chromium/TestShellWin.cpp:
3350         (platformInit):
3351
3352 2013-03-05  Eric Seidel  <eric@webkit.org>
3353
3354         Add html-parser-threaded perf test now that the threaded parser is enabled by default
3355         https://bugs.webkit.org/show_bug.cgi?id=111200
3356
3357         Reviewed by Ryosuke Niwa.
3358
3359         Had to teach run-perf-tests to ignore one more warning.
3360
3361         * Scripts/webkitpy/performance_tests/perftest.py:
3362         (PerfTest):
3363
3364 2013-03-05  Jochen Eisinger  <jochen@chromium.org>
3365
3366         Update list of builders for test results server
3367         https://bugs.webkit.org/show_bug.cgi?id=111166
3368
3369         Reviewed by Ojan Vafai.
3370
3371         * TestResultServer/static-dashboards/builders.jsonp:
3372
3373 2013-03-05  Martin Robinson  <mrobinson@igalia.com> and Tomas Popela  <tpopela@redhat.com>
3374
3375         [GTK] Move basic dependency installation to a script
3376         https://bugs.webkit.org/show_bug.cgi?id=110692
3377
3378         Reviewed by Gustavo Noronha Silva.
3379
3380         * gtk/install-dependencies: Added. A Script which installs all dependencies
3381         necessary for building for Debian-based distributions and Fedora.
3382
3383 2013-03-05  James Robinson  <jamesr@chromium.org>
3384
3385         Chromium DumpRenderTree dumps a core every time it's run (Linux/Debug)
3386         https://bugs.webkit.org/show_bug.cgi?id=111440
3387
3388         Reviewed by Adrienne Walker.
3389
3390         Remove unnecessary WebCompositorSupport::shutdown call
3391
3392         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3393         (main):
3394
3395 2013-03-05  Gustavo Noronha Silva  <gns@gnome.org>
3396
3397         Unreviewed build fix.
3398
3399         * GNUmakefile.am: add generate-feature-defines-files scripts to EXTRA_DIST.
3400
3401 2013-03-05  Andras Becsi  <andras.becsi@digia.com>
3402
3403         [Qt][MiniBrowser] Improve the update of touch indicators
3404         https://bugs.webkit.org/show_bug.cgi?id=111429
3405
3406         Reviewed by Jocelyn Turcotte.
3407
3408         MiniBrowserApplication::sendTouchEvent sends an empty list
3409         to BrowserWindow::updateVisualMockTouchPoints if the control
3410         button is released, in which case the touch indicators should
3411         be hidden so that we never end up with a leftover indicator
3412         sticking on the screen.
3413         This patch also simplifies the lookup of the indicator items by
3414         replacing the findChild search in the item tree with a QHash
3415         that stores the touch ID's and the pointers to the corresponding
3416         indicator items.
3417
3418         * MiniBrowser/qt/BrowserWindow.cpp:
3419         (BrowserWindow::updateVisualMockTouchPoints):
3420         * MiniBrowser/qt/BrowserWindow.h:
3421         (BrowserWindow):
3422
3423 2013-03-05  Tim Horton  <timothy_horton@apple.com>, Grzegorz Czajkowski  <g.czajkowski@samsung.com>
3424
3425         [WK2] WTR needs an implementation of setAsynchronousSpellCheckingEnabled
3426         https://bugs.webkit.org/show_bug.cgi?id=81042
3427
3428         Reviewed by Enrica Casucci.
3429
3430         Add setAsynchronousSpellCheckingEnabled implementation for
3431         WebKitTestRunner to have the possibility to test asynchronous
3432         spell checking implementation from bug 109577.
3433
3434         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3435         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3436         (WTR::TestRunner::setAsynchronousSpellCheckingEnabled):
3437         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3438         * WebKitTestRunner/TestController.cpp:
3439         (WTR::TestController::resetStateToConsistentValues):
3440
3441 2013-03-05  Tommy Widenflycht  <tommyw@google.com>
3442
3443         MediaStream API: Add the getStreamById method on RTCPeerConnection
3444         https://bugs.webkit.org/show_bug.cgi?id=111311
3445
3446         Reviewed by Adam Barth.
3447
3448         Changing mocks to be more realistic.
3449
3450         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp:
3451         (WebTestRunner::MockWebRTCPeerConnectionHandler::addStream):
3452         (WebTestRunner::MockWebRTCPeerConnectionHandler::removeStream):
3453         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.cpp:
3454         (WebTestRunner::WebUserMediaClientMock::requestUserMedia):
3455
3456 2013-03-05  Jochen Eisinger  <jochen@chromium.org>
3457
3458         Add content shell bots to garden-o-matic for general failurse
3459         https://bugs.webkit.org/show_bug.cgi?id=111168
3460
3461         Reviewed by Adam Barth.
3462
3463         All but the WebKit (Content Shell) Android bot is stable enough. While
3464         they're not green yet, there must not be any non-layout test failures on
3465         them.
3466
3467         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
3468         (.):
3469
3470 2013-03-04  Jochen Eisinger  <jochen@chromium.org>
3471
3472         [chromium] remove deprecated WebTestRunner::setFocus API
3473         https://bugs.webkit.org/show_bug.cgi?id=111354
3474
3475         Reviewed by James Robinson.
3476
3477         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
3478         (WebTestDelegate):
3479
3480 2013-03-04  Jochen Eisinger  <jochen@chromium.org>
3481
3482         Run the bindings generation tests on EWS and CQ bots
3483         https://bugs.webkit.org/show_bug.cgi?id=111358
3484
3485         Reviewed by Adam Barth.
3486
3487         The tests are super fast and not flaky.
3488
3489         * Scripts/webkitpy/common/config/ports.py:
3490         (DeprecatedPort.run_bindings_tests_command):
3491         * Scripts/webkitpy/common/config/ports_mock.py:
3492         (MockPort.run_webkit_tests_command):
3493         (MockPort):
3494         (MockPort.run_bindings_tests_command):
3495         * Scripts/webkitpy/tool/commands/download_unittest.py:
3496         * Scripts/webkitpy/tool/steps/runtests.py:
3497         (RunTests.run):
3498         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
3499         (RunTestsTest.test_webkit_run_unit_tests):
3500         * Scripts/webkitpy/tool/steps/steps_unittest.py:
3501
3502 2013-03-04  Eric Seidel  <eric@webkit.org>
3503
3504         run-webkit-tests should support --profile and --profiler= just like run-perf-tests does
3505         https://bugs.webkit.org/show_bug.cgi?id=111384
3506
3507         Reviewed by Ryosuke Niwa.
3508
3509         Sometimes I want to know why various LayoutTests are slow
3510         without having to convert them into PerformanceTests in order
3511         to use our fancy profiling.  The Driver already knows how to
3512         do the right thing, we just need to expose the options to the user.
3513
3514         Handling of these options is already unittested in the perftests_unittest.
3515
3516         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3517         (parse_args):
3518
3519 2013-03-04  Alan Cutter  <alancutter@chromium.org>
3520
3521         check-webkit-style says "Have to enable auto props in the subversion config file"
3522         https://bugs.webkit.org/show_bug.cgi?id=107724
3523
3524         Reviewed by Tony Chang.
3525
3526         Added a standard svn config file for WebKit developers to use.
3527         Updated the style and commit queue bot build scripts to load this file.
3528
3529         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
3530         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh:
3531         * EWSTools/configure-svn-config.sh: Copied from Tools/EWSTools/GoogleComputeEngine/build-commit-queue.sh.
3532         * svn-config: Added.
3533
3534 2013-03-04  James Robinson  <jamesr@chromium.org>
3535
3536         [chromium] Switch to new webkit_support::CreateLayerTreeView interface
3537         https://bugs.webkit.org/show_bug.cgi?id=111285
3538
3539         Reviewed by Adrienne Walker.
3540
3541         This removes the need for WebCompositorSupport::initialize and exposes
3542         slightly fewer entry points across the repository boundary.
3543
3544         * DumpRenderTree/chromium/TestShell.cpp:
3545         (TestShell::initialize):
3546         * DumpRenderTree/chromium/TestShell.h:
3547         (TestShell::webCompositorThread):
3548         (TestShell):
3549         * DumpRenderTree/chromium/WebViewHost.cpp:
3550         (WebViewHost::initializeLayerTreeView):
3551
3552 2013-03-04  Roger Fong  <roger_fong@apple.com>
3553
3554         Unreviewed. Get rid of some AppleWin VS2010 build warnings.
3555
3556         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginCommon.props:
3557
3558 2013-03-04  David Kilzer  <ddkilzer@apple.com>
3559
3560         BUILD FIX (r144657): Fix DumpRenderTree build failure on iOS
3561
3562             Tools/DumpRenderTree/ios/AccessibilityControllerIOS.mm:95:29: error: class method '+stringWithJSStringRef:' not found (return type defaults to 'id') [-Werror,-Wobjc-method-access]
3563                 NSString *idAttribute = [NSString stringWithJSStringRef:idAttributeRef];
3564                                         ^         ~~~~~~~~~~~~~~~~~~~~~
3565             1 error generated.
3566
3567         * DumpRenderTree/ios/AccessibilityControllerIOS.mm: Import
3568         AccessibilityCommonMac.h.
3569
3570 2013-03-04  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3571
3572         [WK2][EFL] Add callbacks to the WKViewClient to handle Web Process crash and relaunch
3573         https://bugs.webkit.org/show_bug.cgi?id=109828
3574
3575         Reviewed by Kenneth Rohde Christiansen.
3576
3577         Added API test for newly added Web Process crash and Web Process relaunch WKViewClient
3578         callbacks.
3579
3580         * TestWebKitAPI/CMakeLists.txt:
3581
3582             Tests located in 'TestWebKitAPI/Tests/WebKit2' subdirectories are also
3583             considered.
3584
3585         * TestWebKitAPI/PlatformEfl.cmake:
3586         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp: Added.
3587         (TestWebKitAPI):
3588         (TestWebKitAPI::didFinishLoadForFrame):
3589         (TestWebKitAPI::setPageLoaderClient):
3590         (TestWebKitAPI::webProcessCrashed):
3591         (TestWebKitAPI::webProcessDidRelaunch):
3592         (TestWebKitAPI::setViewClient):
3593         (TestWebKitAPI::TEST):
3594
3595 2013-03-04  Chris Fleizach  <cfleizach@apple.com>
3596
3597         AX: Upstream iOS Accessibility DumpRenderTree changes
3598         https://bugs.webkit.org/show_bug.cgi?id=111220
3599
3600         Reviewed by David Kilzer.
3601
3602         Upstream the iOS changes for accessibility in DumpRenderTree.
3603
3604         * DumpRenderTree/AccessibilityUIElement.cpp:
3605         (headerElementAtIndexCallback):
3606         (linkedElementCallback):
3607         (elementsForRangeCallback):
3608         (increaseTextSelectionCallback):
3609         (decreaseTextSelectionCallback):
3610         (assistiveTechnologySimulatedFocusCallback):
3611         (stringForSelectionCallback):
3612         (getIPhoneLabelCallback):
3613         (getIPhoneHintCallback):
3614         (getIPhoneValueCallback):
3615         (getIPhoneIdentifierCallback):
3616         (getIPhoneTraitsCallback):
3617         (getIPhoneIsElementCallback):
3618         (getIPhoneElementTextPositionCallback):
3619         (getIPhoneElementTextLengthCallback):
3620         (AccessibilityUIElement::getJSClass):
3621         * DumpRenderTree/AccessibilityUIElement.h:
3622         (AccessibilityUIElement):
3623         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3624         * DumpRenderTree/ios: Added.
3625         * DumpRenderTree/ios/AccessibilityControllerIOS.mm: Added.
3626         (AccessibilityController::AccessibilityController):
3627         (AccessibilityController::~AccessibilityController):
3628         (AccessibilityController::elementAtPoint):
3629         (AccessibilityController::focusedElement):
3630         (AccessibilityController::rootElement):
3631         (findAccessibleObjectById):
3632         (AccessibilityController::accessibleElementById):
3633         (AccessibilityController::setLogFocusEvents):
3634         (AccessibilityController::setLogScrollingStartEvents):
3635         (AccessibilityController::setLogValueChangeEvents):