REGRESSION(r238168) Web Inspector: <iframe src=...> request does not show up in Netwo...
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-16  Commit Queue  <commit-queue@webkit.org>
2
3         Unreviewed, rolling out r244321.
4         https://bugs.webkit.org/show_bug.cgi?id=196968
5
6         Causing all WK2 Debug builds to exit early after Assertion
7         failures. (Requested by ShawnRoberts on #webkit).
8
9         Reverted changeset:
10
11         "URL set by document.open() is not communicated to the
12         UIProcess"
13         https://bugs.webkit.org/show_bug.cgi?id=196941
14         https://trac.webkit.org/changeset/244321
15
16 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
17
18         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
19         https://bugs.webkit.org/show_bug.cgi?id=196948
20
21         Reviewed by Zalan Bujtas.
22
23         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
24         (TEST): Disabling the test for now to keep infrastructure happy, while the root-cause is being investigated.
25
26 2019-04-15  Chris Dumez  <cdumez@apple.com>
27
28         URL set by document.open() is not communicated to the UIProcess
29         https://bugs.webkit.org/show_bug.cgi?id=196941
30         <rdar://problem/49237544>
31
32         Reviewed by Geoffrey Garen.
33
34         Add API test coverage.
35
36         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
37         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
38         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
39         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
40         (TEST):
41
42 2019-04-15  Dean Johnson  <dean_johnson@apple.com>
43
44         Using Tools/Scripts/clean-webkit should not install requests
45         https://bugs.webkit.org/show_bug.cgi?id=196940
46
47         Reviewed by Lucas Forschler.
48
49         * Scripts/webkitpy/common/system/autoinstall.py: Drive-by fix for no logging handlers
50         existing, depending on the path autoinstalled is run through.
51         * Scripts/webkitpy/port/base.py: Import webkitpy.results.upload.Upload only where it's
52         needed.
53         (Port.configuration_for_upload):
54         (Port.commits_for_upload):
55
56 2019-04-15  Alex Christensen  <achristensen@webkit.org>
57
58         Add a DiagnosticLogging method taking an arbitrary dictionary of values.
59         https://bugs.webkit.org/show_bug.cgi?id=196773
60
61         Reviewed by Jer Noble.
62
63         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewDiagnosticLogging.mm:
64         (-[TestLoggingDelegate _webView:logDiagnosticMessage:description:valueDictionary:]):
65         (TEST):
66
67 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
68
69         ews-build should clearly indicate flaky test failures
70         https://bugs.webkit.org/show_bug.cgi?id=196947
71
72         Reviewed by Lucas Forschler.
73
74         * BuildSlaveSupport/ews-build/steps.py:
75         (AnalyzeAPITestsResults.analyzeResults):
76
77 2019-04-15  Brent Fulgham  <bfulgham@apple.com>
78
79         InjectedBundle parameters often need initialization function called before unarchiving
80         https://bugs.webkit.org/show_bug.cgi?id=189709
81         <rdar://problem/44573653>
82
83         Reviewed by Ryosuke Niwa.
84
85         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
86         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
87
88 2019-04-12  Ryosuke Niwa  <rniwa@webkit.org>
89
90         HashTable::removeIf always shrinks the hash table by half even if there is nothing left
91         https://bugs.webkit.org/show_bug.cgi?id=196681
92
93         Reviewed by Darin Adler.
94
95         Added tests.
96
97         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
98         (WTF_HashSet.RemoveIf):
99         (WTF_HashSet.RemoveIfShrinkToBestSize):
100
101 2019-04-15  John Wilander  <wilander@apple.com>
102
103         Send delayed Ad Click Attribution conversion requests to the click source
104         https://bugs.webkit.org/show_bug.cgi?id=196838
105         <rdar://problem/47650157>
106
107         Reviewed by Chris Dumez and Youenn Fablet.
108
109         This patch adds test infrastructure to override the default behavior in
110         WebKit::NetworkAdClickAttribution.
111
112         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
113         (TestWebKitAPI::TEST):
114         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
115         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
116         (WTR::TestRunner::dumpAdClickAttribution):
117         (WTR::TestRunner::clearAdClickAttribution):
118         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
119         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
120         * WebKitTestRunner/InjectedBundle/TestRunner.h:
121         * WebKitTestRunner/TestController.cpp:
122         (WTR::TestController::setAdClickAttributionOverrideTimerForTesting):
123         (WTR::TestController::setAdClickAttributionConversionURLForTesting):
124         * WebKitTestRunner/TestController.h:
125         * WebKitTestRunner/TestInvocation.cpp:
126         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
127
128 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
129
130         [ews-app] status-bubble should display position in queue
131         https://bugs.webkit.org/show_bug.cgi?id=196607
132
133         Reviewed by Lucas Forschler.
134
135         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
136         (StatusBubble._build_bubble):
137         (StatusBubble._queue_position): Method to calculate patch's position in queue.
138
139 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
140
141         [ews-build] Do not run clean build by default on EWS builders
142         https://bugs.webkit.org/show_bug.cgi?id=196897
143
144         Reviewed by Lucas Forschler.
145
146         * BuildSlaveSupport/ews-build/steps.py:
147         (ApplyPatch.start): Do not create .buildbot-patched file. This is a special file for Buildbot and if this
148         file is present, during the Source checkout, Buildbot cleans the working directory completely (including removing 
149         untracked directories like WebKitBuild).
150         (CheckOutSource.__init__): Pass method=clean so that Buildbot clean the working directory. This does not remove
151         untracked files/directories (like WebKitBuild).
152
153 2019-04-15  Per Arne Vollan  <pvollan@apple.com>
154
155         TestRunner::notifyDone() should be safely reentrant
156         https://bugs.webkit.org/show_bug.cgi?id=196898
157
158         Reviewed by Darin Adler.
159
160         It is currently possible that TestRunner::notifyDone() will call itself, since
161         notifyDone() will force a repaint, which can start executing JavaScript, which
162         may call notifyDone() again. This can lead to test failures and flakiness.
163         Fix this by setting the m_waitToDump flag before calling the dump() method.
164
165         * DumpRenderTree/mac/TestRunnerMac.mm:
166         (TestRunner::notifyDone):
167         (TestRunner::forceImmediateCompletion):
168         * DumpRenderTree/win/TestRunnerWin.cpp:
169         (TestRunner::notifyDone):
170         (TestRunner::forceImmediateCompletion):
171
172 2019-04-15  Philippe Normand  <pnormand@igalia.com>
173
174         [GTK][WPE] Add enable-media websetting
175         https://bugs.webkit.org/show_bug.cgi?id=196863
176
177         Reviewed by Michael Catanzaro.
178
179         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
180         (testWebKitSettings): Add test for the enable-media web-setting.
181
182 2019-04-14  Wenson Hsieh  <wenson_hsieh@apple.com>
183
184         API test WKAttachmentTests.AddAttachmentToConnectedImageElement is a flaky failure on Mac Release builds
185         https://bugs.webkit.org/show_bug.cgi?id=196905
186         <rdar://problem/49886096>
187
188         Reviewed by Tim Horton.
189
190         This flaky test exercises a race condition between when attachment insertion updates are dispatched from the web
191         process to the UI process, and when script is executed via -[WKWebView evaluateJavaScript:completionHandler:].
192         Since attachment insertion and removal updates from the web process to the UI process are scheduled on a zero-
193         delay timer, we end up with this sequence of events in the problematic (failure) case:
194
195         (a) [UI]    Run script #1 (which calls `HTMLAttachmentElement.getAttachmentIdentifier`)
196             ...IPC from UI to web process...
197         (b) [Web]   Evaluate script #1 in the web process, which schedules attachment updates on a zero-delay timer
198             ...IPC from web to UI process...
199         (c) [UI]    Invoke completion handler for script #1
200         (d) [UI]    Run script #2 (which calls `document.querySelector('img').attachmentIdentifier`)
201             ...IPC from UI to web process...
202         (e) [Web]   Evaluate script #2 in the web process
203         (f) [Web]   Zero-delay timer fires and dispatches attachment updates to the UI process
204
205         ...which means that script #2 will complete before the UI process has received the attachment updates sent in
206         step (f). However, in the case where the flaky test succeeds, the zero-delay timer in (f) fires *before* script
207         #2 is run in step (e).
208
209         This patch fixes the flaky test by waiting until attachment insertion updates are guaranteed to be received in
210         the UI process by waiting on a script message posted by the web process, after attachment updates are
211         dispatched.
212
213         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
214         (TestWebKitAPI::TEST):
215
216 2019-04-14  Aakash Jain  <aakash_jain@apple.com>
217
218         Disable Flaky API Test WKAttachmentTests.AddAttachmentToConnectedImageElement
219         https://bugs.webkit.org/show_bug.cgi?id=196909
220
221         Reviewed by Wenson Hsieh.
222
223         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
224         (TestWebKitAPI::TEST):
225
226 2019-04-13  Tadeu Zagallo  <tzagallo@apple.com>
227
228         CodeCache should check that the UnlinkedCodeBlock was successfully created before caching it
229         https://bugs.webkit.org/show_bug.cgi?id=196880
230
231         Reviewed by Yusuke Suzuki.
232
233         Add a new function for bytecode cache tests that does not forceDiskCache
234         for the second run: runBytecodeCacheNoAssetion. This is necessary for the
235         test added in this patch, since the code is invalid and therefore won't be
236         cached. It should also be useful for tests that evaluate dynamically
237         generated code.
238
239         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
240         * Scripts/run-jsc-stress-tests:
241
242 2019-04-12  Eric Carlson  <eric.carlson@apple.com>
243
244         Update AudioSession route sharing policy
245         https://bugs.webkit.org/show_bug.cgi?id=196776
246         <rdar://problem/46501611>
247
248         Reviewed by Jer Noble.
249
250         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
251         (TestWebKitAPI::routeSharingPolicyLongFormVideo):
252         (TestWebKitAPI::routeSharingPolicyLongFormAudio):
253         (TestWebKitAPI::TEST):
254
255 2019-04-12  Wenson Hsieh  <wenson_hsieh@apple.com>
256
257         [iOS] Software keyboard is shown too frequently on some websites
258         https://bugs.webkit.org/show_bug.cgi?id=195856
259         <rdar://problem/49191395>
260
261         Reviewed by Darin Adler.
262
263         Add support for attaching or detaching the hardware keyboard on iOS in layout tests.
264
265         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
266         (WTR::UIScriptController::setHardwareKeyboardAttached):
267         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
268         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
269         (WTR::UIScriptController::setHardwareKeyboardAttached):
270         * TestRunnerShared/UIScriptContext/UIScriptController.h:
271         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
272
273         Additionally link against GraphicsServices in WebKitTestRunner.
274
275         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
276         (WTR::TestController::platformResetStateToConsistentValues):
277         (WTR::UIScriptController::setHardwareKeyboardAttached):
278
279 2019-04-12  Ludovico de Nittis  <ludovico.denittis@collabora.com>
280
281         [GTK][WPE] Fix pacman install-dependencies packages
282         https://bugs.webkit.org/show_bug.cgi?id=196817
283
284         Reviewed by Žan Doberšek.
285         
286         python3-setuptools is called python-setuptools
287         ruby-highline is only available on AUR
288         libv4l-devel is incorporated in v4l-utils
289
290         * gtk/install-dependencies:
291         * wpe/install-dependencies:
292
293 2019-04-11  Carlos Garcia Campos  <cgarcia@igalia.com>
294
295         [GTK] REGRESSION(r243860): Many tests failing
296         https://bugs.webkit.org/show_bug.cgi?id=196791
297
298         Reviewed by Joanmarie Diggs.
299
300         Rework the accessibility unit test to use DBus for the communication with the server. This way we can load
301         multiple documents and check that accessibility hierarchy is updated after a navigation.
302
303         * TestWebKitAPI/Tests/WebKitGtk/AccessibilityTestServer.cpp:
304         (loadChangedCallback):
305         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
306         (AccessibilityTest::AccessibilityTest):
307         (AccessibilityTest::~AccessibilityTest):
308         (AccessibilityTest::loadHTMLAndWaitUntilFinished):
309         (AccessibilityTest::findTestServerApplication):
310         (AccessibilityTest::findDocumentWeb):
311         (AccessibilityTest::findRootObject):
312         (AccessibilityTest::waitUntilChildrenRemoved):
313         (AccessibilityTest::ensureProxy):
314         (testAtspiBasicHierarchy):
315         (beforeAll):
316         (afterAll):
317
318 2019-04-11  Aakash Jain  <aakash_jain@apple.com>
319
320         [ews-build] Handle bug titles with unicode characters
321         https://bugs.webkit.org/show_bug.cgi?id=196802
322
323         Reviewed by Dewei Zhu.
324
325         * BuildSlaveSupport/ews-build/steps.py:
326         (ValidatePatch._is_bug_closed):
327
328 2019-04-11  Michael Saboff  <msaboff@apple.com>
329
330         Improve the Inline Cache Stats code
331         https://bugs.webkit.org/show_bug.cgi?id=196836
332
333         Reviewed by Saam Barati.
334
335         Added a new script to consolidate and arrange the output of --useICStats option.
336
337         This script merges the output from every group into one large table and sorts it from most common to
338         least common.  It also counts the slow path GetById and PutById variants and then calculates the
339         percentage of gets or puts for each unique base,property pair compared to all the gets and puts.
340         Put together, this is useful to see what property accesses are not getting cached.
341
342         * Scripts/ic-stats.py: Added.
343         (ICStats):
344         (ICStats.__init__):
345         (ICStats.parse):
346         (ICStats.dumpStats):
347         (usage):
348
349 2019-04-10  Alex Christensen  <achristensen@webkit.org>
350
351         WKNavigationResponse._downloadAttribute should be nil when no download attribute is present
352         https://bugs.webkit.org/show_bug.cgi?id=196809
353         <rdar://49800762>
354
355         Reviewed by Brady Eidson.
356
357         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
358         (TEST):
359
360 2019-04-10  Said Abou-Hallawa  <sabouhallawa@apple.com>
361
362         requestAnimationFrame should execute before the next frame
363         https://bugs.webkit.org/show_bug.cgi?id=177484
364
365         Reviewed by Simon Fraser.
366
367         Add trace points for the page RenderingUpdate.
368
369         * Tracing/SystemTracePoints.plist:
370
371 2019-04-10  Fujii Hironori  <Hironori.Fujii@sony.com>
372
373         [Win] Use a bundled vswhere.exe instead of downloading by update-vswhere.py
374         https://bugs.webkit.org/show_bug.cgi?id=196760
375
376         Reviewed by Don Olmstead.
377
378         vswhere.exe has been bundled since Visual Studio 2017 version
379         15.2. We shouldn't download vswhere.exe.
380
381         * Scripts/build-jsc: Do not call update-vswhere.py.
382         * Scripts/build-webkit: Ditto.
383         * Scripts/update-vswhere.py: Removed.
384         * Scripts/webkitdirs.pm:
385         (requireModulesForVSWhere): Deleted.
386         (pickCurrentVisualStudioInstallation): Deleted.
387         (visualStudioInstallDirVSWhere): Return the latest installed VS
388         installation path by using the bundled vswhere.exe.
389         (setupCygwinEnv): Removed a unused variable $visualStudioPath.
390         (visualStudioInstallDirFallback): Removed.
391
392 2019-04-10  Aakash Jain  <aakash_jain@apple.com>
393
394         [ews-build] PrintConfiguration should display Xcode version instead of SDKVersion
395         https://bugs.webkit.org/show_bug.cgi?id=196780
396
397         Reviewed by Alexey Proskuryakov.
398
399         * BuildSlaveSupport/ews-build/steps.py:
400         * BuildSlaveSupport/ews-build/steps_unittest.py:
401
402 2019-04-10  Alex Christensen  <achristensen@webkit.org>
403
404         Add SPI WKNavigationResponse._downloadAttribute
405         https://bugs.webkit.org/show_bug.cgi?id=196755
406         <rdar://49587365>
407
408         Reviewed by Brady Eidson.
409
410         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
411         (-[NavigationResponseTestDelegate navigationResponse]):
412         (-[NavigationResponseTestDelegate waitForNavigationResponseCallback]):
413         (-[NavigationResponseTestDelegate waitForNavigationFinishedCallback]):
414         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
415         (-[NavigationResponseTestDelegate webView:didFinishNavigation:]):
416         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
417         (readRequest):
418         (writeResponse):
419         (TEST):
420
421 2019-04-10  Tim Horton  <timothy_horton@apple.com>
422
423         Add modern API for overriding the page's specified viewport configuration
424         https://bugs.webkit.org/show_bug.cgi?id=167734
425         <rdar://problem/30331795>
426
427         Reviewed by Simon Fraser.
428
429         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
430         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm: Added.
431
432 2019-04-10  Tadeu Zagallo  <tzagallo@apple.com>
433
434         Add support for incremental bytecode cache updates
435         https://bugs.webkit.org/show_bug.cgi?id=195000
436
437         Reviewed by Filip Pizlo.
438
439         Exit when the initial run to generate bytecode fails.
440
441         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
442
443 2019-04-10  Alex Christensen  <achristensen@webkit.org>
444
445         RemoteObjectRegistry message receiver should be removed when WebPage::close is called instead of waiting until dealloc
446         https://bugs.webkit.org/show_bug.cgi?id=196744
447         <rdar://49415309>
448
449         Reviewed by Chris Dumez.
450
451         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
452         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
453
454 2019-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
455
456         Add a way to opt into modern compatibility mode in layout tests
457         https://bugs.webkit.org/show_bug.cgi?id=196770
458         <rdar://problem/49777550>
459
460         Reviewed by Antoine Quint.
461
462         Add a new test option to enable modern compatibility mode in layout tests.
463
464         * WebKitTestRunner/TestController.cpp:
465         (WTR::updateTestOptionsFromTestHeader):
466         * WebKitTestRunner/TestController.h:
467         * WebKitTestRunner/TestOptions.h:
468         (WTR::TestOptions::hasSameInitializationOptions const):
469         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
470         (WTR::TestController::platformCreateWebView):
471         (WTR::TestController::enableModernCompatibilityMode):
472
473 2019-04-10  Andy Estes  <aestes@apple.com>
474
475         Try to fix the 32-bit watchOS build.
476
477         * TestWebKitAPI/cocoa/TestWKWebView.mm:
478         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
479
480 2019-04-10  Antoine Quint  <graouts@apple.com>
481
482         Enable Pointer Events on watchOS
483         https://bugs.webkit.org/show_bug.cgi?id=196771
484         <rdar://problem/49040909>
485
486         Reviewed by Dean Jackson.
487
488         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
489
490 2019-04-10  Philippe Normand  <pnormand@igalia.com>
491
492         Unreviewed. Fix WPE accessibility tests after r244059.
493
494         We are failing to load the injected bundle due to undefined symbol
495         AccessibilityUIElement::replaceTextInRange().
496
497         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
498         (WTR::AccessibilityUIElement::replaceTextInRange):
499
500 2019-04-10  Takashi Komori  <Takashi.Komori@sony.com>
501
502         [WinCairo][MiniBrowser] Pull down menu "Disable JavaScript" doesn't work.
503         https://bugs.webkit.org/show_bug.cgi?id=196727
504
505         Reviewed by Fujii Hironori.
506
507         * MiniBrowser/win/WebKitBrowserWindow.cpp:
508         (WebKitBrowserWindow::create):
509
510 2019-04-09  Aakash Jain  <aakash_jain@apple.com>
511
512         [ews-build] Add unit tests for PrintConfiguration
513         https://bugs.webkit.org/show_bug.cgi?id=196752
514
515         Reviewed by Dewei Zhu.
516
517         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
518
519 2019-04-09  Keith Rollin  <krollin@apple.com>
520
521         Unreviewed build maintenance -- update .xcfilelists.
522
523         * DumpRenderTree/DerivedSources-input.xcfilelist:
524         * DumpRenderTree/DerivedSources-output.xcfilelist:
525
526 2019-04-09  Zalan Bujtas  <zalan@apple.com>
527
528         [AutoSizing] Avoid making text paragraphs scroll horizontally when there is a wide table
529         https://bugs.webkit.org/show_bug.cgi?id=196743
530         <rdar://problem/43897551>
531
532         Reviewed by Tim Horton.
533
534         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm: expected behavior change.
535         (TEST):
536
537 2019-04-09  Youenn Fablet  <youenn@apple.com>
538
539         Close service worker database on network process suspension
540         https://bugs.webkit.org/show_bug.cgi?id=196623
541         <rdar://problem/48930869>
542
543         Reviewed by Alex Christensen.
544
545         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
546
547 2019-04-09  Daniel Bates  <dabates@apple.com>
548
549         [iPad] Should open popover when the spacebar is pressed
550         https://bugs.webkit.org/show_bug.cgi?id=196360
551         <rdar://problem/49389129>
552
553         Reviewed by Brent Fulgham.
554
555         Add testing infrastructure to support waiting for a popover to be presented or dismissed.
556
557         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
558         (WTR::UIScriptController::isShowingPopover const): Added.
559         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
560         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
561         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
562         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
563         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
564         (WTR::UIScriptController::setWillPresentPopoverCallback): Added.
565         (WTR::UIScriptController::willPresentPopoverCallback const): Added.
566         (WTR::UIScriptController::setDidDismissPopoverCallback): Added.
567         (WTR::UIScriptController::didDismissPopoverCallback const): Added.
568         (WTR::UIScriptController::isShowingPopover const): Added.
569         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
570         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
571         * TestRunnerShared/UIScriptContext/UIScriptController.h:
572         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
573         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
574         (-[TestRunnerWKWebView initWithFrame:configuration:]): Update some state.
575         (-[TestRunnerWKWebView resetInteractionCallbacks]): Ditto.
576         (-[TestRunnerWKWebView _willPresentPopover]): Added.
577         (-[TestRunnerWKWebView _didDismissPopover]): Added.
578         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
579         (WTR::UIScriptController::isShowingPopover const): Added.
580         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
581         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
582
583 2019-04-09  Alex Christensen  <achristensen@webkit.org>
584
585         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
586         https://bugs.webkit.org/show_bug.cgi?id=196665
587         <rdar://45115669>
588
589         Reviewed by Geoff Garen.
590
591         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
592         (goBack):
593         (+[SimpleLookupContext sharedLookupContext]):
594         (-[SimpleLookupContext lookUpURL:completionHandler:]):
595         (TEST):
596         (+[Simple3LookupContext sharedLookupContext]): Deleted.
597         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
598
599 2019-04-09  John Wilander  <wilander@apple.com>
600
601         Pick up Ad Click Attribution conversions in NetworkResourceLoader::willSendRedirectedRequest()
602         https://bugs.webkit.org/show_bug.cgi?id=196558
603         <rdar://problem/47650245>
604
605         Reviewed by Youenn Fablet.
606
607         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
608         (TestWebKitAPI::TEST):
609             Added tests of WebCore::AdClickAttribution::parseConversionRequest().
610
611 2019-04-09  Don Olmstead  <don.olmstead@sony.com>
612
613         [CMake] Apple builds should use ICU_INCLUDE_DIRS
614         https://bugs.webkit.org/show_bug.cgi?id=196720
615
616         Reviewed by Konstantin Tokarev.
617
618         * TestWebKitAPI/PlatformMac.cmake:
619
620 2019-04-09  Jonathan Bedard  <jbedard@apple.com>
621
622         iOS 12 Simulator Release WK2 frequently timing out while running layout tests
623         https://bugs.webkit.org/show_bug.cgi?id=196694
624         <rdar://problem/48388734>
625
626         Rubber-stamped by Aakash Jain.
627
628         * Scripts/webkitpy/port/image_diff.py:
629         (ImageDiffer.diff_image): If the ImageDiff process has data, kill it before running again.
630         * Scripts/webkitpy/port/server_process.py:
631         (ServerProcess.has_available_stdout): Check if stdout has data in it.
632         (ServerProcess._wait_for_data_and_update_buffers_using_select):
633         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
634         * Scripts/webkitpy/port/server_process_mock.py:
635         (MockServerProcess.has_available_stdout):
636         * Scripts/webkitpy/port/server_process_unittest.py:
637         (TestServerProcess.serial_test_basic):
638
639 2019-04-09  Jer Noble  <jer.noble@apple.com>
640
641         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
642         https://bugs.webkit.org/show_bug.cgi?id=196097
643
644         Reviewed by Eric Carlson.
645
646         Drive-by bug fix: allow tests to play audio without a user gesture by default.
647
648         * DumpRenderTree/mac/DumpRenderTree.mm:
649         (resetWebPreferencesToConsistentValues):
650         * WebKitTestRunner/TestController.cpp:
651         (WTR::TestController::resetPreferencesToConsistentValues):
652
653 2019-04-09  Pablo Saavedra  <psaavedra@igalia.com>
654
655         [JSCOnly] Add an i386 JSCOnly EWS that runs tests
656         https://bugs.webkit.org/show_bug.cgi?id=196690
657
658         Reviewed by Michael Catanzaro.
659
660         * QueueStatusServer/config/queues.py:
661         * Scripts/webkitpy/common/config/ews.json:
662         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
663         (test_ews_name):
664
665 2019-04-09  Chris Dumez  <cdumez@apple.com>
666
667         Loads using loadHTMLString() cause flashing when process-swapping
668         https://bugs.webkit.org/show_bug.cgi?id=196714
669         <rdar://problem/49637354>
670
671         Reviewed by Antti Koivisto.
672
673         Add API test coverage.
674
675         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
676
677 2019-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
678
679         Unreviewed. Fix ATK accessibility tests after r244059.
680
681         We are failing to load the injected bundle due to undefined symbol
682         AccessibilityUIElement::replaceTextInRange().
683
684         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
685         (WTR::AccessibilityUIElement::replaceTextInRange):
686
687 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
688
689         AX: Support API: accessibilityReplaceRange:withText
690         https://bugs.webkit.org/show_bug.cgi?id=196636
691
692         Unreviewed build fix for Windows port.
693
694         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
695         (WTR::AccessibilityUIElement::replaceTextInRange): Added.
696
697 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
698
699         [CMake][WinCairo] Separate copied headers into different directories
700         https://bugs.webkit.org/show_bug.cgi?id=196655
701
702         Reviewed by Michael Catanzaro.
703
704         * DumpRenderTree/CMakeLists.txt:
705         * MiniBrowser/win/CMakeLists.txt:
706         * TestWebKitAPI/CMakeLists.txt:
707         * TestWebKitAPI/PlatformWin.cmake:
708
709 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
710
711         Log stack-trace for run-webkit-tests when interrupted
712         https://bugs.webkit.org/show_bug.cgi?id=176393
713         <rdar://problem/34262310>
714
715         Reviewed by Lucas Forschler.
716
717         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
718         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
719         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
720         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
721         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
722         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
723         (main): Set handlers to log stack trace on interruption.
724
725 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
726
727         AX: Support API: accessibilityReplaceRange:withText
728         https://bugs.webkit.org/show_bug.cgi?id=196636
729
730         Unreviewed build fix for Windows port.
731
732         * DumpRenderTree/AccessibilityUIElement.cpp:
733         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
734
735 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
736
737         [ews-build] Scripts using Buildbot API have CORS error
738         https://bugs.webkit.org/show_bug.cgi?id=196709
739
740         Reviewed by Alexey Proskuryakov.
741
742         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
743
744 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
745
746         AX: Support API: accessibilityReplaceRange:withText
747         https://bugs.webkit.org/show_bug.cgi?id=196636
748
749         Reviewed by Daniel Bates.
750
751         * DumpRenderTree/AccessibilityUIElement.cpp:
752         (replaceTextInRangeCallback):
753         (AccessibilityUIElement::replaceTextInRange):
754         (AccessibilityUIElement::getJSClass):
755         * DumpRenderTree/AccessibilityUIElement.h:
756         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
757         (AccessibilityUIElement::replaceTextInRange):
758         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
759         (AccessibilityUIElement::replaceTextInRange):
760         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
761         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
762         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
763         (WTR::AccessibilityUIElement::replaceTextInRange):
764         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
765         (WTR::AccessibilityUIElement::replaceTextInRange):
766
767 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
768
769         [iOS] Do not allow starting selection drags when selection views are not visible
770         https://bugs.webkit.org/show_bug.cgi?id=196686
771         <rdar://problem/49399192>
772
773         Reviewed by Tim Horton.
774
775         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
776         also add some new API tests to cover scenarios where the web view is not first responder.
777
778         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
779         (TestWebKitAPI::TEST):
780         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
781
782         Add a switch to optionally make the web view first responder when starting the simulated drag.
783
784         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
785         (-[DragAndDropSimulator initWithWebView:]):
786         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
787
788 2019-04-08  Justin Fan  <justin_fan@apple.com>
789
790         [Web GPU] Fix Web GPU experimental feature on iOS
791         https://bugs.webkit.org/show_bug.cgi?id=196632
792
793         Reviewed by Myles C. Maxfield.
794
795         Properly make Web GPU available on iOS 11+.
796
797         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
798
799 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
800
801         [ews-build] Do not upload archive when Compile Fails
802         https://bugs.webkit.org/show_bug.cgi?id=196674
803
804         Reviewed by Alexey Proskuryakov.
805
806         * BuildSlaveSupport/ews-build/factories.py:
807         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
808         * BuildSlaveSupport/ews-build/steps.py:
809         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
810         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
811         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
812
813 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
814
815         Enable DFG on MIPS
816         https://bugs.webkit.org/show_bug.cgi?id=196689
817
818         Reviewed by Žan Doberšek.
819
820         Since the bytecode change, we enabled the baseline JIT on mips in
821         r240432, but DFG is still missing. With this change, all tests are
822         passing on a ci20 board.
823
824         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
825
826 2019-04-08  Philippe Normand  <pnormand@igalia.com>
827
828         [Flatpak] Second run update-webkitwpe-flatpak fails
829         https://bugs.webkit.org/show_bug.cgi?id=192702
830
831         Reviewed by Carlos Garcia Campos.
832
833         * flatpak/flatpakutils.py:
834         (FlatpakObject.flatpak): Fix typo.
835         (FlatpakPackage.install): When installing, also update to the configured remote commit.
836         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
837
838 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
839
840         [GTK][WPE] outlook.live.com displays old-fashioned UI
841         https://bugs.webkit.org/show_bug.cgi?id=196642
842
843         Reviewed by Carlos Garcia Campos.
844
845         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
846         (TestWebKitAPI::TEST): New Mac platform quirk test.
847
848 2019-04-07  Commit Queue  <commit-queue@webkit.org>
849
850         Unreviewed, rolling out r243956.
851         https://bugs.webkit.org/show_bug.cgi?id=196688
852
853         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
854         by aakashjain on #webkit).
855
856         Reverted changeset:
857
858         "Clicking "Go Back" from a safe browsing warning from an
859         iframe should navigate the WKWebView back to the previous
860         page"
861         https://bugs.webkit.org/show_bug.cgi?id=196665
862         https://trac.webkit.org/changeset/243956
863
864 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
865
866         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
867         https://bugs.webkit.org/show_bug.cgi?id=196669
868
869         Reviewed by Geoffrey Garen.
870
871         Added three new unit tests for WeakHashSet.
872
873         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
874         (WTF_WeakPtr.WeakHashSetConstObjects):
875         (WTF_WeakPtr.WeakHashSetComputesEmpty):
876         (WTF_WeakPtr.WeakHashSetComputeSize):
877
878 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
879
880         Hide next and previous form control buttons when WKWebView is editable
881         https://bugs.webkit.org/show_bug.cgi?id=196672
882         <rdar://problem/35625321>
883
884         Reviewed by Tim Horton.
885
886         Add a new API test.
887
888         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
889         (-[TestWKWebView lastTrailingBarButtonGroup]):
890         (TestWebKitAPI::TEST):
891         * TestWebKitAPI/ios/UIKitSPI.h:
892
893 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
894
895         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
896         https://bugs.webkit.org/show_bug.cgi?id=196077
897         <rdar://problem/49108202>
898
899         Reviewed by Chris Dumez.
900
901         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
902         on new web view.
903
904         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
905
906 2019-04-05  Saam Barati  <sbarati@apple.com>
907
908         Make compare-results understand MotionMark
909         https://bugs.webkit.org/show_bug.cgi?id=196666
910
911         Reviewed by Yusuke Suzuki.
912
913         * Scripts/compare-results:
914         (PLT5Results):
915         (detectMotionMark):
916         (detectMotionMark1_1):
917         (motionMarkResults):
918         (motionMark1_1Results):
919         (detectBenchmark):
920         (biggerIsBetter):
921         (main):
922
923 2019-04-05  Alex Christensen  <achristensen@webkit.org>
924
925         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
926         https://bugs.webkit.org/show_bug.cgi?id=196665
927         <rdar://45115669>
928
929         Reviewed by Geoff Garen.
930
931         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
932         (goBack):
933         (+[SimpleLookupContext sharedLookupContext]):
934         (-[SimpleLookupContext lookUpURL:completionHandler:]):
935         (TEST):
936         (+[Simple3LookupContext sharedLookupContext]): Deleted.
937         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
938
939 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
940
941         [ews-build] Add configuration and architecture for windows builders
942         https://bugs.webkit.org/show_bug.cgi?id=196660
943
944         Reviewed by Lucas Forschler.
945
946         * BuildSlaveSupport/ews-build/config.json:
947
948 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
949
950         webkitpy: Don't run subsequent rounds if interrupted
951         https://bugs.webkit.org/show_bug.cgi?id=196646
952
953         Reviewed by Aakash Jain.
954
955         * Scripts/webkitpy/layout_tests/controllers/manager.py:
956         (Manager.run): Bail out if interrupted.
957
958 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
959
960         Test sessionStorage in PSON private browsing mode
961         https://bugs.webkit.org/show_bug.cgi?id=196561
962
963         Reviewed by Alex Christensen.
964
965         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
966
967 2019-04-05  Commit Queue  <commit-queue@webkit.org>
968
969         Unreviewed, rolling out r243833.
970         https://bugs.webkit.org/show_bug.cgi?id=196645
971
972         This change breaks build of WPE and GTK ports (Requested by
973         annulen on #webkit).
974
975         Reverted changeset:
976
977         "[CMake][WTF] Mirror XCode header directories"
978         https://bugs.webkit.org/show_bug.cgi?id=191662
979         https://trac.webkit.org/changeset/243833
980
981 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
982
983         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
984         https://bugs.webkit.org/show_bug.cgi?id=196635
985
986         Reviewed by Antti Koivisto.
987         
988         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
989         for a test to enable async frame scrolling via:
990             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
991         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
992         
993         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
994
995         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
996         (WTR::InjectedBundle::beginTesting):
997         * WebKitTestRunner/TestController.cpp:
998         (WTR::TestController::resetPreferencesToConsistentValues):
999
1000 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
1001
1002         Use a correct LC_RPATH when building with ASan
1003         https://bugs.webkit.org/show_bug.cgi?id=196576
1004
1005         Reviewed by David Kilzer.
1006
1007         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
1008         so that ../Frameworks is checked. This is simpler and more reliable than updating
1009         each SPC service xcconfig.
1010
1011 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1012
1013         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
1014         https://bugs.webkit.org/show_bug.cgi?id=196629
1015
1016         Reviewed by Lucas Forschler.
1017
1018         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
1019
1020 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1021
1022         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
1023         https://bugs.webkit.org/show_bug.cgi?id=196618
1024
1025         Reviewed by Lucas Forschler.
1026
1027         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1028         (StatusBubble): Added QUEUE_TRIGGERS.
1029         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
1030         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
1031         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
1032         its parent(builder).
1033
1034 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1035
1036         [ews-app] Status-bubble steps are sometimes displayed in reverse order
1037         https://bugs.webkit.org/show_bug.cgi?id=196625
1038
1039         Reviewed by Lucas Forschler.
1040
1041         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1042         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
1043
1044 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1045
1046         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
1047         https://bugs.webkit.org/show_bug.cgi?id=196630
1048
1049         Reviewed by Wenson Hsieh.
1050
1051         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1052
1053 2019-04-04  Youenn Fablet  <youenn@apple.com>
1054
1055         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
1056         https://bugs.webkit.org/show_bug.cgi?id=196543
1057
1058         Reviewed by Alex Christensen.
1059
1060         * WebKitTestRunner/TestController.cpp:
1061         (WTR::TestController::generatePageConfiguration):
1062
1063 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1064
1065         [ews-app] Status bubble should not display skipped buildbot steps
1066         https://bugs.webkit.org/show_bug.cgi?id=196584
1067
1068         Reviewed by Lucas Forschler.
1069
1070         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1071
1072 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1073
1074         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
1075         https://bugs.webkit.org/show_bug.cgi?id=196620
1076
1077         Reviewed by Lucas Forschler.
1078
1079         * BuildSlaveSupport/ews-app/ews/config.py:
1080
1081 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
1082
1083         [Win] DumpRenderTreeWatchDog.py is not checked into source
1084         https://bugs.webkit.org/show_bug.cgi?id=196567
1085         <rdar://problem/49525901>
1086
1087         Reviewed by Lucas Forschler.
1088
1089         This script is used on Win EWS bots to terminate hanging DRT processes.
1090
1091         * EWSTools/dumprendertreewatchdog.py: Added.
1092
1093 2019-04-04  Chris Dumez  <cdumez@apple.com>
1094
1095         Unreviewed, roll out r243858 which made tests time out.
1096
1097         Disable new API tests on Windows instead.
1098
1099         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1100         (TestWebKitAPI::TEST):
1101
1102 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
1103
1104         [ATK] Cleanup WebPageAccessibilityObjectAtk
1105         https://bugs.webkit.org/show_bug.cgi?id=196537
1106
1107         Reviewed by Michael Catanzaro.
1108
1109         Also consider files under atk directories as exceptions for GObject conventions.
1110
1111         * Scripts/webkitpy/style/checkers/cpp.py:
1112         (check_identifier_name_in_declaration):
1113
1114 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
1115
1116         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
1117         https://bugs.webkit.org/show_bug.cgi?id=196588
1118         <rdar://problem/49365787>
1119
1120         Unreviewed build fix for Windows port.
1121
1122         error C3861: 'kill': identifier not found
1123
1124         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1125         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
1126
1127 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1128
1129         [ews-build] Cancel build and similar operations should have authentication
1130         https://bugs.webkit.org/show_bug.cgi?id=196520
1131
1132         Reviewed by Dewei Zhu.
1133
1134         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
1135         environment variables.
1136
1137 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1138
1139         [ews-build] Do not trigger queues which are not in production yet
1140         https://bugs.webkit.org/show_bug.cgi?id=196581
1141
1142         Reviewed by Dewei Zhu.
1143
1144         * BuildSlaveSupport/ews-build/config.json:
1145
1146 2019-04-03  Chris Dumez  <cdumez@apple.com>
1147
1148         Unreviewed, fix typo in the name of API test added in r243848.
1149
1150         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1151         (TestWebKitAPI::TEST):
1152
1153 2019-04-03  Chris Dumez  <cdumez@apple.com>
1154
1155         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
1156         https://bugs.webkit.org/show_bug.cgi?id=196588
1157         <rdar://problem/49365787>
1158
1159         Reviewed by Ryosuke Niwa.
1160
1161         Add API test coverage.
1162
1163         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1164         (TestWebKitAPI::nullJavaScriptCallback):
1165         (TestWebKitAPI::didCrashCheckFrames):
1166         (TestWebKitAPI::TEST):
1167
1168 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
1169
1170         run-webkit-tests: Upload test results (new results database)
1171         https://bugs.webkit.org/show_bug.cgi?id=196577
1172         <rdar://problem/34841155>
1173
1174         Reviewed by Lucas Forschler.
1175
1176         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1177         (Manager.run): Upload results after each device shard, since the configuration will be
1178         different for each device.
1179         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
1180         uploaded to a results database.
1181         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1182         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
1183
1184 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
1185
1186         -apple-trailing-word is needed for browser detection
1187         https://bugs.webkit.org/show_bug.cgi?id=196575
1188
1189         Unreviewed.
1190
1191         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1192
1193 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
1194
1195         [CMake][WTF] Mirror XCode header directories
1196         https://bugs.webkit.org/show_bug.cgi?id=191662
1197
1198         Reviewed by Konstantin Tokarev.
1199
1200         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
1201         builds.
1202
1203         * CMakeLists.txt:
1204         * DumpRenderTree/CMakeLists.txt:
1205         * DumpRenderTree/PlatformWin.cmake:
1206         * MiniBrowser/win/CMakeLists.txt:
1207         * TestWebKitAPI/CMakeLists.txt:
1208         * TestWebKitAPI/PlatformWin.cmake:
1209         * WebKitTestRunner/PlatformGTK.cmake:
1210         * WebKitTestRunner/PlatformWin.cmake:
1211
1212 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1213
1214         [ews-app] Status bubble should not display certain infrastructure status messages
1215         https://bugs.webkit.org/show_bug.cgi?id=196550
1216
1217         Reviewed by Lucas Forschler.
1218
1219         Do not display the steps which are un-needed for end-user. This information is still avaiable
1220         if the user click on the bubble and look at the Buildbot build.
1221         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1222         (StatusBubble._steps_messages):
1223         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
1224
1225 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1226
1227         [ews-build] Use https for sending data to ews-app
1228         https://bugs.webkit.org/show_bug.cgi?id=196492
1229
1230         Reviewed by Lucas Forschler.
1231
1232         * BuildSlaveSupport/ews-build/events.py:
1233
1234 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
1235
1236         Remove support for -apple-trailing-word
1237         https://bugs.webkit.org/show_bug.cgi?id=196525
1238
1239         Reviewed by Zalan Bujtas.
1240
1241         This CSS property is nonstandard and not used.
1242
1243         * Scripts/webkitperl/FeatureList.pm:
1244         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1245
1246 2019-04-03  Youenn Fablet  <youenn@apple.com>
1247
1248         Add a test for DOMCache on multiple browsing in case of private browsing
1249         https://bugs.webkit.org/show_bug.cgi?id=196524
1250
1251         Reviewed by Alex Christensen.
1252
1253         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1254         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
1255
1256 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
1257
1258         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
1259         https://bugs.webkit.org/show_bug.cgi?id=196540
1260
1261         Reviewed by Aakash Jain.
1262
1263         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
1264
1265 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
1266
1267         Add plumbing for a compatibility mode preference in WebKit
1268         https://bugs.webkit.org/show_bug.cgi?id=196005
1269
1270         Reviewed by Tim Horton.
1271
1272         Add new API tests.
1273
1274         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1275         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
1276
1277 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
1278
1279         [WPE][GTK] Update libsrtp dependency package for Debian
1280         https://bugs.webkit.org/show_bug.cgi?id=196528
1281
1282         Reviewed by Frédéric Wang.
1283
1284         * gtk/install-dependencies:
1285         * wpe/install-dependencies:
1286
1287 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
1288
1289         [WK2] Add support for Window's beforeprint / afterprint events
1290         https://bugs.webkit.org/show_bug.cgi?id=196478
1291         <rdar://problem/49535124>
1292
1293         Unreviewed build fix for MSVC.
1294
1295         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
1296
1297         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
1298
1299         * WebKitTestRunner/TestController.cpp:
1300         (WTR::printFrame): Use int and float literals.
1301
1302 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
1303
1304         [ews-build] Reassign bots to queues
1305
1306         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
1307
1308 2019-04-02  Chris Dumez  <cdumez@apple.com>
1309
1310         [WK2] Add support for Window's beforeprint / afterprint events
1311         https://bugs.webkit.org/show_bug.cgi?id=196478
1312
1313         Reviewed by Alex Christensen.
1314
1315         Add minimal implementation for printFrame in WebKitTestRunner.
1316
1317         * WebKitTestRunner/TestController.cpp:
1318         (WTR::printFrame):
1319         (WTR::TestController::createOtherPage):
1320         (WTR::TestController::createWebViewWithOptions):
1321
1322 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
1323
1324         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
1325         https://bugs.webkit.org/show_bug.cgi?id=196491
1326
1327         Reviewed by Lucas Forschler.
1328
1329         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1330
1331 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
1332
1333         [ews-build] Configure buildbot try credentials in environment variables
1334         https://bugs.webkit.org/show_bug.cgi?id=196501
1335
1336         Reviewed by Lucas Forschler.
1337
1338         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
1339         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
1340         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
1341
1342 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
1343
1344         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
1345         https://bugs.webkit.org/show_bug.cgi?id=196496
1346         <rdar://problem/49521634>
1347
1348         Reviewed by Chris Dumez.
1349
1350         Add new API tests (see WebKit ChangeLog for more detail).
1351
1352         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1353         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1354         (TEST):
1355
1356 2019-04-02  David Kilzer  <ddkilzer@apple.com>
1357
1358         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
1359         <https://webkit.org/b/196499>
1360
1361         Reviewed by Alexey Proskuryakov.
1362
1363         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
1364         ENABLE_ADDRESS_SANITIZER.
1365
1366 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
1367
1368         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
1369         https://bugs.webkit.org/show_bug.cgi?id=182757
1370
1371         Reviewed by Don Olmstead.
1372
1373         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
1374         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
1375
1376 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
1377
1378         run-api-tests: Upload test results
1379         https://bugs.webkit.org/show_bug.cgi?id=196323
1380         <rdar://problem/49356714>
1381
1382         Reviewed by Lucas Forschler.
1383
1384         * Scripts/webkitpy/api_tests/manager.py:
1385         (Manager):
1386         (Manager.run): Upload results to a results database.
1387         * Scripts/webkitpy/api_tests/run_api_tests.py:
1388         (parse_args): Add upload arguments.
1389         * Scripts/webkitpy/port/base.py:
1390         (Port):
1391         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
1392         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
1393         with commits from any other associated repositories.
1394         * Scripts/webkitpy/port/device.py:
1395         (Device):
1396         (Device.build_version): Access build_versoin of underlying platform device.
1397         * Scripts/webkitpy/port/ios_simulator_unittest.py:
1398         (IOSSimulatorTest):
1399         (IOSSimulatorTest.test_configuration_for_upload):
1400         * Scripts/webkitpy/port/device_port.py:
1401         (DevicePort):
1402         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
1403         the same as the machine uploading results.
1404         * Scripts/webkitpy/port/mac.py:
1405         (MacPort):
1406         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
1407         * Scripts/webkitpy/port/mac_unittest.py:
1408         (MacTest):
1409         (MacTest.test_configuration_for_upload):
1410         * Scripts/webkitpy/xcode/simulated_device.py:
1411         (SimulatedDeviceManager._create_device_with_runtime):
1412         (SimulatedDevice.__init__): Create simulated device with a build_version.
1413         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
1414         (test_existing_simulator):
1415
1416 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1417
1418         Remove extra newline characters (Follow-up fix to r243707)
1419
1420         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1421
1422 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1423
1424         [ews-app] Use API_KEY to accept results data
1425         https://bugs.webkit.org/show_bug.cgi?id=196461
1426
1427         Reviewed by Dewei Zhu.
1428
1429         * BuildSlaveSupport/ews-app/ews/views/results.py:
1430         (Results.post): Validate EWS_API_KEY before accepting any data.
1431         * BuildSlaveSupport/ews-build/events.py:
1432         (Events.sendData): Send EWS_API_KEY if available along with event data.
1433
1434 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
1435
1436         Unable to copy and paste a PDF from Notes into Mail compose body
1437         https://bugs.webkit.org/show_bug.cgi?id=196442
1438         <rdar://problem/48573098>
1439
1440         Reviewed by Tim Horton.
1441
1442         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
1443         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
1444         to be specified on the item providers.
1445
1446         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1447         (TestWebKitAPI::mapItemForTesting):
1448         (TestWebKitAPI::contactItemForTesting):
1449
1450 2019-04-01  Tim Horton  <timothy_horton@apple.com>
1451
1452         Make UIWKDocumentContext rects per-character instead of per-word
1453         https://bugs.webkit.org/show_bug.cgi?id=196459
1454
1455         Reviewed by Wenson Hsieh.
1456
1457         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1458         (TEST):
1459         Adjust test results due to switching to per-character rects.
1460
1461 2019-04-01  Chris Dumez  <cdumez@apple.com>
1462
1463         UIProcess crash when a prewarmed process is terminated
1464         https://bugs.webkit.org/show_bug.cgi?id=196451
1465         <rdar://problem/49245471>
1466
1467         Reviewed by Geoffrey Garen.
1468
1469         Add API test coverage.
1470
1471         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1472         (TEST):
1473
1474 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1475
1476         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
1477         https://bugs.webkit.org/show_bug.cgi?id=196449
1478
1479         Reviewed by Lucas Forschler.
1480
1481         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1482         (StatusBubble.get_os_details): Method to get OS and Xcode details.
1483         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
1484         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
1485
1486 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1487
1488         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
1489         https://bugs.webkit.org/show_bug.cgi?id=196444
1490
1491         Reviewed by Lucas Forschler.
1492
1493         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
1494
1495 2019-04-01  Alex Christensen  <achristensen@webkit.org>
1496
1497         Add SPI to canonicalize NSURLs with WTF::URL
1498         https://bugs.webkit.org/show_bug.cgi?id=196415
1499         <rdar://problem/44980271>
1500
1501         Reviewed by Darin Adler.
1502
1503         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1504         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
1505         (TestWebKitAPI::TEST):
1506
1507 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
1508
1509         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
1510         https://bugs.webkit.org/show_bug.cgi?id=196441
1511
1512         Reviewed by Carlos Garcia Campos.
1513
1514         Don't cache the wpe_view_backend object that might not exist yet at the
1515         time of EventSenderProxy constructor invocation, but instead retrieve
1516         that object whenever it's required for event dispatching. This should
1517         avoid crashes in this constructor now that it's invoked before any
1518         PlatformWindow has been set up (as changed in r243496).
1519
1520         * WebKitTestRunner/EventSenderProxy.h:
1521         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
1522         (WTR::viewBackend):
1523         (WTR::EventSenderProxy::EventSenderProxy):
1524         (WTR::EventSenderProxy::mouseDown):
1525         (WTR::EventSenderProxy::mouseUp):
1526         (WTR::EventSenderProxy::mouseMoveTo):
1527         (WTR::EventSenderProxy::mouseScrollBy):
1528         (WTR::EventSenderProxy::keyDown):
1529         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
1530
1531 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
1532
1533         [Win][WebKit] MiniBrowser should support high DPI display
1534         https://bugs.webkit.org/show_bug.cgi?id=196391
1535
1536         Reviewed by Alex Christensen.
1537
1538         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1539         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
1540         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
1541         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
1542
1543 2019-03-31  Sam Weinig  <weinig@apple.com>
1544
1545         Remove more i386 specific configurations
1546         https://bugs.webkit.org/show_bug.cgi?id=196430
1547
1548         Reviewed by Alexey Proskuryakov.
1549
1550         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1551         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
1552
1553 2019-03-31  Andy Estes  <aestes@apple.com>
1554
1555         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
1556         https://bugs.webkit.org/show_bug.cgi?id=196433
1557         <rdar://problem/49293305>
1558
1559         Reviewed by Tim Horton.
1560
1561         Enhanced API test coverage to include all navigation response policy decisions in both
1562         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
1563
1564         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1565         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
1566         (TestWebKitAPI::TEST):
1567         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
1568         (readFile):
1569         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
1570         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
1571         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1572         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
1573         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
1574         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
1575         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
1576         (-[QuickLookDelegate _downloadDidStart:]):
1577         (-[QuickLookDelegate _download:didReceiveResponse:]):
1578         (-[QuickLookDelegate _download:didReceiveData:]):
1579         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
1580         (-[QuickLookDelegate _downloadDidFinish:]):
1581         (-[QuickLookDelegate _download:didFailWithError:]):
1582         (-[QuickLookDelegate _downloadDidCancel:]):
1583         (-[QuickLookDelegate verifyDownload]):
1584         (runTest):
1585         (runTestDecideBeforeLoading):
1586         (runTestDecideAfterLoading):
1587         (TEST):
1588         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1589         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
1590         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
1591         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
1592         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
1593         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
1594         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
1595         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
1596         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
1597         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
1598         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
1599         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
1600         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
1601         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
1602
1603 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
1604
1605         [CMake] add testdfg as target with build-jsc
1606         https://bugs.webkit.org/show_bug.cgi?id=196393
1607
1608         Reviewed by Saam Barati.
1609
1610         Added testdfg as one of the targets to build when
1611         using CMake.
1612
1613         * Scripts/build-jsc:
1614
1615 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
1616
1617         Delete WebMetal implementation in favor of WebGPU
1618         https://bugs.webkit.org/show_bug.cgi?id=195418
1619
1620         Reviewed by Dean Jackson.
1621
1622         * DumpRenderTree/mac/DumpRenderTree.mm:
1623         (enableExperimentalFeatures):
1624         (resetWebPreferencesToConsistentValues):
1625         * Scripts/webkitperl/FeatureList.pm:
1626         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1627         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1628         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
1629         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
1630         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
1631         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
1632         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
1633         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
1634         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
1635         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1636         (WTR::InjectedBundle::beginTesting):
1637         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1638         (WTR::TestRunner::setWebMetalEnabled): Deleted.
1639         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1640
1641 2019-03-29  Chris Dumez  <cdumez@apple.com>
1642
1643         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
1644         https://bugs.webkit.org/show_bug.cgi?id=196405
1645         <rdar://problem/49428130>
1646
1647         Reviewed by Wenson Hsieh.
1648
1649         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
1650         the popover presentation methods to be no-ops. Use this in the new test added in
1651         r243523 so that we do not swizzle those methods for all tests. This is needed because
1652         those WatchOS tests rely on the popover getting presented and interactive.
1653
1654         * WebKitTestRunner/TestController.cpp:
1655         (WTR::updateTestOptionsFromTestHeader):
1656         * WebKitTestRunner/TestController.h:
1657         * WebKitTestRunner/TestOptions.h:
1658         (WTR::TestOptions::hasSameInitializationOptions const):
1659         * WebKitTestRunner/ios/TestControllerIOS.mm:
1660         (WTR::TestController::platformInitialize):
1661         (WTR::TestController::platformResetStateToConsistentValues):
1662
1663 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
1664
1665         [Curl] Add Server Trust Evaluation Support.
1666         https://bugs.webkit.org/show_bug.cgi?id=191646
1667
1668         Reviewed by Fujii Hironori.
1669
1670         Implemented MiniBrowser UI for asking if user trusts the server.
1671
1672         * MiniBrowser/win/Common.cpp:
1673         (askServerTrustEvaluation):
1674         (replaceString):
1675         * MiniBrowser/win/Common.h:
1676         * MiniBrowser/win/MiniBrowserLib.rc:
1677         * MiniBrowser/win/MiniBrowserLibResource.h:
1678         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1679         (createPEMString):
1680         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
1681         (WebKitBrowserWindow::canTrustServerCertificate):
1682         * MiniBrowser/win/WebKitBrowserWindow.h:
1683
1684 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
1685
1686         Implement ResizeObserver.
1687         https://bugs.webkit.org/show_bug.cgi?id=157743
1688
1689         Reviewed by Simon Fraser.
1690
1691         Support resizeObserverEnabled webPreferences.
1692
1693         * DumpRenderTree/TestOptions.cpp:
1694         (TestOptions::TestOptions):
1695         * DumpRenderTree/TestOptions.h:
1696         * DumpRenderTree/mac/DumpRenderTree.mm:
1697         (setWebPreferencesForTestOptions):
1698         * DumpRenderTree/win/DumpRenderTree.cpp:
1699         (enableExperimentalFeatures):
1700         * Scripts/webkitperl/FeatureList.pm:
1701         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1702
1703 2019-03-28  John Wilander  <wilander@apple.com>
1704
1705         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
1706         https://bugs.webkit.org/show_bug.cgi?id=196281
1707         <rdar://problem/48938748>
1708
1709         Reviewed by Alex Christensen.
1710
1711         This patch adds the function isStatisticsHasLocalStorage() to the
1712         TestRunner. With it, the page can query the WebsiteDataStore in the
1713         UI process to make sure that it sees LocalStorage.
1714
1715         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1716         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1717         (WTR::TestRunner::isStatisticsHasLocalStorage):
1718         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1719         * WebKitTestRunner/TestController.cpp:
1720         (WTR::TestController::isStatisticsHasLocalStorage):
1721         * WebKitTestRunner/TestController.h:
1722         * WebKitTestRunner/TestInvocation.cpp:
1723         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1724
1725 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
1726
1727         API::Data::createWithoutCopying should do a null check before calling CFRelease
1728         https://bugs.webkit.org/show_bug.cgi?id=196276
1729         <rdar://problem/48059859>
1730
1731         Reviewed by Alex Christensen.
1732
1733         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
1734
1735         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1736         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
1737         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
1738         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
1739         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1740         (TestWebKitAPI::TEST):
1741
1742 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
1743
1744         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
1745         https://bugs.webkit.org/show_bug.cgi?id=186276
1746
1747         Reviewed by Carlos Garcia Campos.
1748
1749         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
1750         (webViewLoadChanged):
1751         (testWebResourceGetDataError):
1752         (testWebResourceGetDataEmpty):
1753         (beforeAll):
1754         (webViewloadChanged): Deleted.
1755
1756 2019-03-27  Andy Estes  <aestes@apple.com>
1757
1758         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
1759         https://bugs.webkit.org/show_bug.cgi?id=196317
1760
1761         Reviewed by Dan Bernstein.
1762
1763         package-root copies built products into a staging directory using ditto(1), which does not
1764         follow symbolic links as it traverses a directory. Now that the files in
1765         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
1766         itself, these become broken links when ditto'd into the staging directory.
1767
1768         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
1769
1770         * Scripts/package-root:
1771
1772 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
1773
1774         [ews-app] Update display text of Submit for ews analysis
1775         https://bugs.webkit.org/show_bug.cgi?id=196309
1776
1777         Reviewed by Dewei Zhu.
1778
1779         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
1780
1781 2019-03-27  David Kilzer  <ddkilzer@apple.com>
1782
1783         run-webkit-tests should check for leaks in WebKit processes
1784         <https://webkit.org/b/193772>
1785         <rdar://problem/46526680>
1786
1787         Reviewed by Ryosuke Niwa.
1788
1789         This works by doing the following:
1790         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
1791           The list of child processes are returned one per line:
1792           process.name: pid
1793         - Run the "#LIST CHILD PROCESSES" command just before the
1794           "#CHECK FOR WORLD LEAKS" command, and store the list of child
1795           processes on the ServerProcess object.
1796         - When the `--leaks` switch is handled, run check_for_leaks() on
1797           each child process after the main test harness.
1798
1799         * DumpRenderTree/mac/DumpRenderTree.mm:
1800         (handleControlCommand):
1801         - Use strncmp() instead of strcmp().
1802         - Add support for handling "#LIST CHILD PROCESSES" command.
1803
1804         * Scripts/webkitpy/port/base.py:
1805         (Port.check_for_leaks):
1806         * Scripts/webkitpy/port/darwin.py:
1807         (DarwinPort.check_for_leaks):
1808         - Rename redundant 'process_pid' argument to 'process_id'.
1809
1810         * Scripts/webkitpy/port/driver.py:
1811         (Driver.do_post_tests_work):
1812         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
1813           longer the only command this sends to WebKitTestRunner.
1814         - If the `--leaks` switch is present, send the
1815           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
1816           result using Port.set_webkit_processes().
1817         (Driver._parse_child_processes_output):
1818         - Add helper method to parse list of child process names and
1819           process IDs returned from WebKitTestRunner.
1820
1821         * Scripts/webkitpy/port/ios_device.py:
1822         (IOSDevicePort.check_for_leaks):
1823         - Rename redundant 'process_pid' argument to 'process_id'.
1824
1825         * Scripts/webkitpy/port/leakdetector.py:
1826         (LeakDetector._parse_leaks_output):
1827         - Return early if there is no leaks_output.
1828         (LeakDetector.check_for_leaks):
1829         - Rename redundant 'process_pid' argument to 'process_id'.
1830
1831         * Scripts/webkitpy/port/server_process.py:
1832         (ServerProcess.__init__):
1833         (ServerProcess.child_processes):
1834         (ServerProcess.set_child_processes):
1835         - Add instance variable to Port to store list of child process
1836           names and process IDs returned from WebKitTestRunner.
1837         (ServerProcess._start):
1838         - Clear self._child_processes.
1839         (ServerProcess.stop):
1840         - If self._child_processes is set, call
1841           self._port.check_for_leaks() for each child process.
1842
1843         * Scripts/webkitpy/port/server_process_unittest.py:
1844         (TrivialMockPort.check_for_leaks):
1845         - Rename redundant 'process_pid' argument to 'process_id'.
1846
1847         * Scripts/webkitpy/port/simulator_process.py:
1848         (SimulatorProcess.stop):
1849         - If self._child_processes is set, call
1850           self._port.check_for_leaks() for each child process.
1851
1852         * Scripts/webkitpy/port/watch_device.py:
1853         (WatchDevicePort.check_for_leaks):
1854         - Rename redundant 'process_pid' argument to 'process_id'.
1855
1856         * WebKitTestRunner/TestController.cpp:
1857         (WTR::TestController::dumpResponse):
1858         - Extract method from findAndDumpWorldLeaks() so that it may be
1859           reused by findAndDumpWebKitProcessIdentifiers().
1860         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1861         - Add method to output process name and process ID of both the
1862           WebContent and Networking processes.
1863         (WTR::TestController::findAndDumpWorldLeaks):
1864         - Fix missing newline in output when there were no abandoned
1865           documents.
1866         - Call dumpResponse() for extracted code.
1867         (WTR::TestController::handleControlCommand):
1868         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
1869         - Use strncmp() instead of strcmp().
1870         - Call findAndDumpWebKitProcessIdentifiers() when
1871           "#LIST CHILD PROCESSES" command is sent.
1872         * WebKitTestRunner/TestController.h:
1873         (WTR::TestController::dumpResponse):
1874         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1875         - Declare methods.
1876
1877 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1878
1879         Unreviewed. Add GLib API test cases after r243434.
1880
1881         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
1882         (testWebViewActiveURI):
1883         (serverCallback):
1884         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1885         (sendRequestCallback):
1886
1887 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1888
1889         Geolocation request not complete when watch request was started in a different web process
1890         https://bugs.webkit.org/show_bug.cgi?id=195996
1891
1892         Reviewed by Alex Christensen.
1893
1894         Add a test case.
1895
1896         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
1897         (TestWebKitAPI::runJavaScriptAlert):
1898         (TestWebKitAPI::TEST):
1899
1900 2019-03-26  Keith Rollin  <krollin@apple.com>
1901
1902         Update the way generate-xcfilelists returns strings from functions
1903         https://bugs.webkit.org/show_bug.cgi?id=195975
1904         <rdar://problem/49040807>
1905
1906         Reviewed by Dean Jackson.
1907
1908         There are places where generate-xcfilelists executes assignments with
1909         statements like:
1910
1911             FOO=$(some_function)
1912
1913         where "some_function" return a string by echoing it. E.g.
1914
1915             some_function()
1916             {
1917                 echo "Hello, World"
1918             }
1919
1920         This is a common idiom, but it has a problem if "some_function" needs
1921         to call "exit" in an attempt to halt the entire script right then and
1922         there. Since "some_function" is called inside of $(), it's being
1923         executed in a sub-shell. Calling exit in that sub-shell simply exits
1924         that shell; it doesn't not exit the outer shell in which the main part
1925         of the script is still running. As such, the main script keeps
1926         executing when the intent was for the script to halt.
1927
1928         The solution to this is to use a different idiom for returning
1929         strings. The one we now is to pass in the name of the variable to
1930         receive the string result:
1931
1932             some_function()
1933             {
1934                 variable_name=$1
1935                 eval $variable_name ="Hello, World"
1936             }
1937
1938         The call site now looks like
1939
1940             some_function FOO
1941
1942         Because there's no invocation of a sub-shell, some_function can now
1943         call "exit" if it wants to, and the entire script will exit at that
1944         point.
1945
1946         * Scripts/generate-xcfilelists:
1947
1948 2019-03-26  Chris Dumez  <cdumez@apple.com>
1949
1950         Add basic layout test coverage for File Picker on iOS
1951         https://bugs.webkit.org/show_bug.cgi?id=196265
1952
1953         Reviewed by Wenson Hsieh.
1954
1955         Add layout test infrastructure to test the file picker on iOS.
1956
1957         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1958         (WTR::UIScriptController::dismissFilePicker):
1959         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1960         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1961         (WTR::UIScriptController::dismissFilePicker):
1962         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1963         * WebKitTestRunner/TestController.cpp:
1964         (WTR::TestController::createWebViewWithOptions):
1965         (WTR::updateTestOptionsFromTestHeader):
1966         * WebKitTestRunner/TestOptions.h:
1967         (WTR::TestOptions::hasSameInitializationOptions const):
1968         * WebKitTestRunner/ios/TestControllerIOS.mm:
1969         (overridePresentViewController):
1970         (WTR::TestController::platformInitialize):
1971         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1972         (WTR::UIScriptController::dismissFilePicker):
1973
1974 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
1975
1976         Implement async paste method on UIWKInteractionViewProtocol
1977         https://bugs.webkit.org/show_bug.cgi?id=196267
1978         <rdar://problem/49236346>
1979
1980         Reviewed by Tim Horton.
1981
1982         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
1983         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
1984         are now a part of all iOS 12 internal SDKs.
1985
1986         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
1987
1988         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
1989         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
1990
1991         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
1992         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1993         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
1994         * TestWebKitAPI/ios/UIKitSPI.h:
1995
1996 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1997
1998         [ews-build] Use PostgreSQL for ews.webkit.org database
1999         https://bugs.webkit.org/show_bug.cgi?id=196270
2000
2001         Reviewed by Lucas Forschler.
2002
2003         * BuildSlaveSupport/ews-app/ews-app/settings.py:
2004
2005 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
2006
2007         [ews] Reset simctl states on reboot
2008         https://bugs.webkit.org/show_bug.cgi?id=196260
2009
2010         Rubber-stamped by Aakash Jain.
2011
2012         * EWSTools/start-queue-mac.sh:
2013
2014 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2015
2016         [ews-build] Use PostgreSQL for ews-build database
2017         https://bugs.webkit.org/show_bug.cgi?id=196229
2018
2019         Reviewed by Lucas Forschler.
2020
2021         * BuildSlaveSupport/ews-build/master.cfg:
2022
2023 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2024
2025         [ews-build] Get master_hostname dynamically in master.cfg
2026         https://bugs.webkit.org/show_bug.cgi?id=196255
2027
2028         Reviewed by Lucas Forschler.
2029
2030         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
2031         send events data in test mode.
2032
2033 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2034
2035         [ews-app] Set db_constraint to False for Foreign Keys
2036         https://bugs.webkit.org/show_bug.cgi?id=196252
2037
2038         Reviewed by Lucas Forschler.
2039
2040         * BuildSlaveSupport/ews-app/ews/models/build.py:
2041         * BuildSlaveSupport/ews-app/ews/models/step.py:
2042
2043 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2044
2045         [ews-build] is_test_mode_enabled should default to True
2046         https://bugs.webkit.org/show_bug.cgi?id=196248
2047
2048         Reviewed by Lucas Forschler.
2049
2050         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
2051
2052 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2053
2054         [ews-app] Add webkitperl to ENABLED_QUEUES
2055         https://bugs.webkit.org/show_bug.cgi?id=196253
2056
2057         Reviewed by Lucas Forschler.
2058
2059         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2060
2061 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
2062
2063         Address NSWindow sometimes using WebKitTestRunnerEvent too early
2064         https://bugs.webkit.org/show_bug.cgi?id=196211
2065         rdar://problem/49110552
2066
2067         Reviewed by Tim Horton.
2068
2069         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
2070         Make sure that EventSenderProxy always exists when running tests. We used to create
2071         it when resetting before the first test, which is a bit too late.
2072
2073         * WebKitTestRunner/TestController.h:
2074         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2075         (WTR::TestController::platformCreateWebView):
2076         (WTR::TestController::platformCreateOtherPage):
2077         (WTR::TestController::finishCreatingPlatformWebView):
2078         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2079         (WTR::PlatformWebView::PlatformWebView):
2080         Moved some code that made NSWindow use NSEvent during web view creation. We may
2081         need to move more if some other case us found, but this is enough for now.
2082
2083 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
2084
2085         Unreviewed. Fix typo in GLib geolocation API after r243285.
2086
2087         gelocation -> geolocation.
2088
2089         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
2090         (testGeolocationManagerWatchPosition):
2091
2092 2019-03-25  Alex Christensen  <achristensen@webkit.org>
2093
2094         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
2095         https://bugs.webkit.org/show_bug.cgi?id=196213
2096
2097         Reviewed by Geoff Garen.
2098
2099         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2100         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
2101         (credentialWithIdentityAndKeychainPath):
2102         (-[ChallengeDelegate webView:didFinishNavigation:]):
2103         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
2104         (TestWebKitAPI::TEST):
2105
2106 2019-03-25  Alex Christensen  <achristensen@webkit.org>
2107
2108         Expected shouldn't assume its contained types are copyable
2109         https://bugs.webkit.org/show_bug.cgi?id=195986
2110
2111         Reviewed by JF Bastien.
2112
2113         * TestWebKitAPI/Tests/WTF/Expected.cpp:
2114         (TestWebKitAPI::NonCopyable::operator== const):
2115         (TestWebKitAPI::NonCopyable::operator!= const):
2116         (TestWebKitAPI::TEST):
2117
2118 2019-03-25  Tim Horton  <timothy_horton@apple.com>
2119
2120         Remove some now-unnecessary dynamic class lookup
2121         https://bugs.webkit.org/show_bug.cgi?id=196237
2122
2123         Reviewed by Simon Fraser.
2124
2125         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
2126         (makeRequest):
2127         (TEST):
2128
2129 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
2130
2131         Unreviewed, rolling out r243450.
2132
2133         AppleWin and WinCairo port builds get broken.
2134
2135         Reverted changeset:
2136
2137         "Add test for fix of #196095"
2138         https://bugs.webkit.org/show_bug.cgi?id=196097
2139         https://trac.webkit.org/changeset/243450
2140
2141 2019-03-25  Commit Queue  <commit-queue@webkit.org>
2142
2143         Unreviewed, rolling out r243465.
2144         https://bugs.webkit.org/show_bug.cgi?id=196226
2145
2146         the test doesn't build (Requested by thorton on #webkit).
2147
2148         Reverted changeset:
2149
2150         "Do not terminate the NetworkProcess if a third party
2151         application sends a NSCredential with a SecIdentityRef"
2152         https://bugs.webkit.org/show_bug.cgi?id=196213
2153         https://trac.webkit.org/changeset/243465
2154
2155 2019-03-25  Alex Christensen  <achristensen@webkit.org>
2156
2157         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
2158         https://bugs.webkit.org/show_bug.cgi?id=196213
2159
2160         Reviewed by Geoff Garen.
2161
2162         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2163         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
2164         (credentialWithIdentityAndKeychainPath):
2165         (-[ChallengeDelegate webView:didFinishNavigation:]):
2166         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
2167         (TestWebKitAPI::TEST):
2168
2169 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
2170
2171         [ews-build] Gracefully handle missing patch_id in events
2172         https://bugs.webkit.org/show_bug.cgi?id=196216
2173
2174         Reviewed by Lucas Forschler.
2175
2176         * BuildSlaveSupport/ews-build/events.py:
2177
2178 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
2179
2180         [ews-build] use lz4 compression for improving buildbot performance
2181         https://bugs.webkit.org/show_bug.cgi?id=196155
2182
2183         Reviewed by Lucas Forschler.
2184
2185         * BuildSlaveSupport/ews-build/master.cfg:
2186
2187 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2188
2189         Pull some API testing helper methods out of TestWKWebView
2190         https://bugs.webkit.org/show_bug.cgi?id=196212
2191
2192         Reviewed by Tim Horton.
2193
2194         Refactor some more API testing utility methods, so that they can be used in
2195         tests that do not use TestWKWebView.
2196
2197         * TestWebKitAPI/cocoa/TestWKWebView.h:
2198         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2199         (-[WKWebView loadTestPageNamed:]):
2200         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
2201         (-[WKWebView synchronouslyLoadHTMLString:]):
2202         (-[WKWebView synchronouslyLoadTestPageNamed:]):
2203         (-[TestWKWebView loadTestPageNamed:]): Deleted.
2204         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
2205         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
2206         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
2207
2208 2019-03-25  Jer Noble  <jer.noble@apple.com>
2209
2210         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
2211         https://bugs.webkit.org/show_bug.cgi?id=196097
2212
2213         Reviewed by Eric Carlson.
2214
2215         Drive-by bug fix: allow tests to play audio without a user gesture by default.
2216
2217         * DumpRenderTree/mac/DumpRenderTree.mm:
2218         (resetWebPreferencesToConsistentValues):
2219         * WebKitTestRunner/TestController.cpp:
2220         (WTR::TestController::resetPreferencesToConsistentValues):
2221
2222 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2223
2224         Pull IPadUserInterfaceSwizzler out into a separate header file
2225         https://bugs.webkit.org/show_bug.cgi?id=196193
2226
2227         Reviewed by Anders Carlsson.
2228
2229         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
2230         be used in other API tests.
2231
2232         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2233         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
2234         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
2235         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
2236         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
2237         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
2238         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
2239
2240 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2241
2242         Remove NavigatorContentUtils in WebCore/Modules
2243         https://bugs.webkit.org/show_bug.cgi?id=196070
2244
2245         Reviewed by Alex Christensen.
2246
2247         NavigatorContentUtils was to support the custom scheme spec [1].
2248         However, in WebKit side, no port has supported the feature in
2249         WebKit layer after EFL port was removed. So there has been the
2250         only IDL implementation of the NavigatorContentUtils in WebCore.
2251         So we don't need to keep the implementation in WebCore anymore.
2252
2253         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
2254
2255         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2256
2257 2019-03-24  Andy Estes  <aestes@apple.com>
2258
2259         [watchOS] Remove unused Proximity Networking code
2260         https://bugs.webkit.org/show_bug.cgi?id=196188
2261
2262         Reviewed by Tim Horton.
2263
2264         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
2265         (TEST):
2266
2267 2019-03-23  Keith Miller  <keith_miller@apple.com>
2268
2269         Refactor clz/ctz and fix getLSBSet.
2270         https://bugs.webkit.org/show_bug.cgi?id=196162
2271
2272         Reviewed by Saam Barati.
2273
2274         Add tests for clz, ctz, getLSBSet, and getMSBSet.
2275
2276         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2277         (TestWebKitAPI::TEST):
2278
2279 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2280
2281         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
2282         https://bugs.webkit.org/show_bug.cgi?id=196143
2283
2284         Reviewed by Michael Catanzaro.
2285
2286         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
2287         directories.
2288
2289         * Scripts/webkitpy/style/checkers/cpp.py:
2290         (check_identifier_name_in_declaration):
2291         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2292         (WebKitStyleTest.test_names):
2293
2294 2019-03-22  Philippe Normand  <pnormand@igalia.com>
2295
2296         [Flatpak] Manifest expanding fails for qt WPE extension
2297         https://bugs.webkit.org/show_bug.cgi?id=196148
2298
2299         Reviewed by Alex Christensen.
2300
2301         * flatpak/flatpakutils.py:
2302         (expand_submodules_recurse): The last recurse manifest expand
2303         iteration might lead to a single module so take it into account
2304         and don't try to recurse further.
2305
2306 2019-03-22  Chris Dumez  <cdumez@apple.com>
2307
2308         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
2309         https://bugs.webkit.org/show_bug.cgi?id=195348
2310         <rdar://problem/48622090>
2311
2312         Reviewed by Alex Christensen.
2313
2314         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
2315         to NO when test.options().shouldIgnoreMetaViewport is false.
2316
2317         * WebKitTestRunner/ios/TestControllerIOS.mm:
2318         (WTR::TestController::platformConfigureViewForTest):
2319
2320 2019-03-22  Chris Dumez  <cdumez@apple.com>
2321
2322         Prewarmed processes should be usable with any website data store
2323         https://bugs.webkit.org/show_bug.cgi?id=196104
2324
2325         Reviewed by Alex Christensen.
2326
2327         Add API test coverage.
2328
2329         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2330         (runInitialWarmedProcessUsedTest):
2331         (TEST):
2332
2333 2019-03-22  David Kilzer  <ddkilzer@apple.com>
2334
2335         Back out local changes to Alex's Subversion working directory
2336
2337         They were accidentally committed.
2338
2339         * Scripts/webkitpy/common/system/abstractexecutive.py:
2340         (AbstractExecutive.wait_newest):
2341         * Scripts/webkitpy/common/system/executive.py:
2342         (Executive.running_pids):
2343         * Scripts/webkitpy/common/system/executive_mock.py:
2344         (MockExecutive.running_pids):
2345         * Scripts/webkitpy/common/system/executive_unittest.py:
2346         (ExecutiveTest.serial_test_running_pids):
2347         * Scripts/webkitpy/port/darwin.py:
2348         (DarwinPort.check_for_leaks):
2349         * Scripts/webkitpy/port/leakdetector.py:
2350         (LeakDetector.check_for_leaks):
2351         - This was the hack attached to Bug 193772.
2352
2353         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
2354         (+[WebKitTestRunnerEvent mouseLocation]):
2355         - This works around a crash on an internal build.
2356
2357 2019-03-22  Tim Horton  <timothy_horton@apple.com>
2358
2359         Fix the build after r243354
2360         https://bugs.webkit.org/show_bug.cgi?id=196138
2361         <rdar://problem/49145951>
2362
2363         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
2364         (TEST):
2365         * TestWebKitAPI/ios/UIKitSPI.h:
2366
2367 2019-03-21  Tim Horton  <timothy_horton@apple.com>
2368
2369         Adopt UIWKDocumentContext
2370         https://bugs.webkit.org/show_bug.cgi?id=196040
2371         <rdar://problem/48642440>
2372
2373         Reviewed by Ryosuke Niwa.
2374
2375         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2376         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
2377         (makeRequest):
2378         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
2379         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
2380         (applyStyle):
2381         (TEST):
2382         Add tests for UIWKDocumentContext.
2383
2384         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
2385         (TEST):
2386         (recursiveFindWKContentView): Deleted.
2387         * TestWebKitAPI/cocoa/TestWKWebView.h:
2388         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2389         (recursiveFindWKContentView):
2390         (-[TestWKWebView wkContentView]):
2391         * TestWebKitAPI/ios/UIKitSPI.h:
2392         Share the WKContentView finding code between tests.
2393
2394 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
2395
2396         [iOS WK2] Turn on async overflow scrolling by default
2397         https://bugs.webkit.org/show_bug.cgi?id=196011
2398         rdar://problem/48453859
2399
2400         Reviewed by Antti Koivisto.
2401         
2402         Explicitly turn off the async overflow scrolling internal feature for tests by default,
2403         since so many basic layout tests have different results when compositing is triggered for
2404         overflow.
2405         
2406         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
2407
2408         * WebKitTestRunner/TestController.cpp:
2409         (WTR::TestController::resetPreferencesToConsistentValues):
2410
2411 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
2412
2413         [ews-build] Retry API test in case of failures
2414         https://bugs.webkit.org/show_bug.cgi?id=196004
2415
2416         Reviewed by Lucas Forschler.
2417
2418         * BuildSlaveSupport/ews-build/steps.py:
2419         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
2420         (CompileWebKitToT.doStepIf): Ditto.
2421         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
2422         (ReRunAPITests): Re-run API tests.
2423         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
2424         (RunAPITestsWithoutPatch): Run API tests without patch.
2425         (RunAPITestsWithoutPatch.doStepIf):
2426         (RunAPITestsWithoutPatch.hideStepIf):
2427         (RunAPITestsWithoutPatch.evaluateCommand):
2428         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
2429         (AnalyzeAPITestsResults.start):
2430         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
2431         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
2432         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
2433         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
2434
2435 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
2436
2437         [ews-build] Update queues configurations
2438         https://bugs.webkit.org/show_bug.cgi?id=196074
2439
2440         Reviewed by Dewei Zhu.
2441
2442         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
2443         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
2444
2445 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
2446
2447         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
2448         https://bugs.webkit.org/show_bug.cgi?id=195680
2449         <rdar://problem/48903534>
2450
2451         Unreviewed infrastructure fix.
2452
2453         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2454         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
2455
2456 2019-03-21  Andy Estes  <aestes@apple.com>
2457
2458         [iOS] Apple Pay should be available in documents with no user agent scripts
2459         https://bugs.webkit.org/show_bug.cgi?id=196061
2460         <rdar://problem/48649391>
2461
2462         Reviewed by Brady Eidson.
2463
2464         Added API tests and related infrastructure.
2465
2466         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2467         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
2468         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
2469         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
2470         (TestWebKitAPI::TEST):
2471         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
2472         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
2473         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
2474         * TestWebKitAPI/cocoa/TestProtocol.mm:
2475         (-[TestProtocol startLoading]):
2476         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
2477         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
2478         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
2479         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
2480
2481 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
2482
2483         REGRESSSION (r243297): webkitpy tests broken
2484         https://bugs.webkit.org/show_bug.cgi?id=196108
2485
2486         Reviewed by Aakash Jain.
2487
2488         r243297 updated contributors.json, which broke a few unit tests.
2489
2490         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2491         (IRCCommandTest.test_whois):
2492         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
2493
2494 2019-03-21  Chris Dumez  <cdumez@apple.com>
2495
2496         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
2497         https://bugs.webkit.org/show_bug.cgi?id=196041
2498         <rdar://problem/49083230>
2499
2500         Reviewed by Alex Christensen.
2501
2502         Add API test coverage.
2503
2504         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
2505         (TEST):
2506
2507 2019-03-21  Alex Christensen  <achristensen@webkit.org>
2508
2509         Add SPI to inform applications of WKContentRuleList actions
2510         https://bugs.webkit.org/show_bug.cgi?id=195965
2511         <rdar://problem/42664365>
2512
2513         Reviewed by Geoff Garen.
2514
2515         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2516         (TestWebKitAPI::allActionsForResourceLoad):
2517         (TestWebKitAPI::testRequest):
2518         (TestWebKitAPI::TEST_F):
2519         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
2520         (Notification::description):
2521         (Notification::operator== const):
2522         (toVector):
2523         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
2524         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
2525         (makeContentRuleList):
2526         (TEST):
2527         (makeWarnContentRuleList): Deleted.
2528
2529 2019-03-21  Timothy Hatcher  <timothy@apple.com>
2530
2531         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
2532         https://bugs.webkit.org/show_bug.cgi?id=196088
2533
2534         Reviewed by Brian Burg.
2535
2536         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
2537         Support checks when only one platform is specified. Also deprecate macosx() and
2538         force the use of macos() instead.
2539
2540         * Scripts/webkitpy/style/checkers/cpp.py:
2541         (check_min_versions_of_wk_api_available):
2542         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2543         (WebKitStyleTest.test_min_versions_of_wk_api_available):
2544
2545 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
2546
2547         Update status inactive committers' status to 'contributor'.
2548
2549         * Scripts/webkitpy/common/config/contributors.json:
2550
2551 2019-03-21  Xan Lopez  <xan@igalia.com>
2552
2553         [JSC][x86] Drop support for x87 floating point
2554         https://bugs.webkit.org/show_bug.cgi?id=194853
2555
2556         Reviewed by Don Olmstead.
2557
2558         Force SSE2 on x86/32bit builds.
2559
2560         * Scripts/webkitdirs.pm:
2561         (generateBuildSystemFromCMakeProject):
2562
2563 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2564
2565         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
2566         https://bugs.webkit.org/show_bug.cgi?id=196073
2567
2568         Reviewed by Michael Catanzaro.
2569
2570         Add test cases to check functions and constructors with no arguments but receiving user data.
2571
2572         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2573         (checkUserData):
2574         (testJSCFunction):
2575         (fooCreateWithUserData):
2576         (testJSCClass):
2577
2578 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2579
2580         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
2581
2582         Add g_assert_cmpfloat_with_epsilon macro if not defined.
2583
2584         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
2585
2586 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2587
2588         [GTK][WPE] Add API to provide geolocation information
2589         https://bugs.webkit.org/show_bug.cgi?id=195940
2590
2591         Reviewed by Michael Catanzaro.
2592
2593         Add a new test to check the new API.
2594
2595         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
2596         (testGeolocationManagerCurrentPosition):
2597         (testGeolocationManagerWatchPosition):
2598         (beforeAll):
2599         (afterAll):
2600         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
2601         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
2602         (beforeAll): Ditto.
2603         * TestWebKitAPI/glib/CMakeLists.txt:
2604
2605 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2606
2607         [GLib] Returning G_TYPE_OBJECT from a method does not work
2608         https://bugs.webkit.org/show_bug.cgi?id=195574
2609
2610         Reviewed by Michael Catanzaro.
2611
2612         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
2613
2614         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2615         (getGFile):
2616         (getParent):
2617         (createGString):
2618         (getGString):
2619         (getGStringCopyWillRaise):
2620         (getGStringCopy):
2621         (getGStringStr):
2622         (getGStringLen):
2623         (freeGString):
2624         (testJSCClass):
2625
2626 2019-03-20  Saam Barati  <sbarati@apple.com>
2627
2628         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
2629         https://bugs.webkit.org/show_bug.cgi?id=195721
2630
2631         Reviewed by Filip Pizlo.
2632
2633         * Scripts/run-javascriptcore-tests:
2634
2635 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
2636
2637         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
2638         https://bugs.webkit.org/show_bug.cgi?id=196049
2639
2640         Reviewed by Tim Horton.
2641
2642         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
2643         overflow scrolling in general, so rename it.
2644
2645         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2646
2647 2019-03-20  Daniel Bates  <dabates@apple.com>
2648
2649         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
2650         https://bugs.webkit.org/show_bug.cgi?id=196031
2651         <rdar://problem/49078172>
2652
2653         Reviewed by Tim Horton.
2654
2655         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
2656         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
2657         same code path used when the Done button is pressed to dismiss the <select> picker.
2658
2659         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
2660         (TestWebKitAPI::TEST):
2661
2662 2019-03-20  Chris Dumez  <cdumez@apple.com>
2663
2664         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
2665         https://bugs.webkit.org/show_bug.cgi?id=196029
2666         <rdar://problem/48954651>
2667
2668         Reviewed by Tim Horton.
2669
2670         Add API test coverage.
2671
2672         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2673
2674 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
2675
2676         [ews-build] Improve failure summary string for ApplyPatch step
2677         https://bugs.webkit.org/show_bug.cgi?id=195995
2678
2679         Reviewed by Alexey Proskuryakov.
2680
2681         * BuildSlaveSupport/ews-build/steps.py:
2682         (ApplyPatch.getResultSummary): Override getResultSummary.
2683
2684 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
2685
2686         AX: Implement support for new meter ARIA role
2687         https://bugs.webkit.org/show_bug.cgi?id=195966
2688
2689         Reviewed by Chris Fleizach.
2690
2691         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
2692         to AXLevelIndicator.
2693
2694         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2695
2696 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
2697
2698         [WebAuthN] Implement FIDO AppID extension
2699         https://bugs.webkit.org/show_bug.cgi?id=143491
2700         <rdar://problem/48298273>
2701
2702         Reviewed by Brent Fulgham.
2703
2704         Add a test that covers the new flag of convertToU2fSignCommand.
2705
2706         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
2707         (TestWebKitAPI::TEST):
2708         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
2709         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
2710         (TestWebKitAPI::TEST):
2711
2712 2019-03-19  Keith Rollin  <krollin@apple.com>
2713
2714         Add support for more platforms to generate-xcfilelists
2715         https://bugs.webkit.org/show_bug.cgi?id=195977
2716
2717         Reviewed by Alexey Proskuryakov.
2718
2719         generate-xcfilelists incorrectly complains when involved with building
2720         WebKit for iphonesimulator:
2721
2722             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
2723             …
2724             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
2725
2726         Address this by teaching generate-xcfilelists about more platforms.
2727
2728         * Scripts/generate-xcfilelists:
2729
2730 2019-03-19  John Wilander  <wilander@apple.com>
2731
2732         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
2733         https://bugs.webkit.org/show_bug.cgi?id=195923
2734         <rdar://problem/49001272>
2735
2736         Reviewed by Alex Christensen.
2737
2738         This patch does the following to the TestRunner:
2739         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
2740         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
2741         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
2742
2743         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2744         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2745         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
2746         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2747         * WebKitTestRunner/TestController.cpp:
2748         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
2749         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
2750         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
2751         * WebKitTestRunner/TestController.h:
2752         * WebKitTestRunner/TestInvocation.cpp:
2753         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2754
2755 2019-03-19  Christopher Reid  <chris.reid@sony.com>
2756
2757         [CMake] Support more clang and gcc sanitizers
2758         https://bugs.webkit.org/show_bug.cgi?id=195956
2759
2760         Reviewed by Michael Catanzaro.
2761
2762         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
2763
2764 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2765
2766         [ews-build] Improve summary for PrintConfiguration step
2767         https://bugs.webkit.org/show_bug.cgi?id=195945
2768
2769         Reviewed by Lucas Forschler.
2770
2771         * BuildSlaveSupport/ews-build/steps.py:
2772         (PrintConfiguration.getResultSummary): Override getResultSummary.
2773
2774 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2775
2776         [ews-build] Improve summary for CheckOutSource step
2777         https://bugs.webkit.org/show_bug.cgi?id=195963
2778
2779         Reviewed by Lucas Forschler.
2780
2781         * BuildSlaveSupport/ews-build/steps.py:
2782         (CheckOutSource.getResultSummary):
2783
2784 2019-03-19  Daniel Bates  <dabates@apple.com>
2785
2786         [iOS] Focus not preserved when switching between tabs
2787         https://bugs.webkit.org/show_bug.cgi?id=195820
2788         <rdar://problem/43614450>
2789
2790         Reviewed by Brent Fulgham.
2791
2792         Add tests to ensure that we restore focus when resigning and becoming first responder.
2793
2794         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2795         (TestWebKitAPI::TEST):
2796
2797 2019-03-19  Alex Christensen  <achristensen@webkit.org>
2798
2799         Make WTFLogChannelState and WTFLogLevel enum classes
2800         https://bugs.webkit.org/show_bug.cgi?id=195904
2801
2802         Reviewed by Eric Carlson.
2803
2804         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2805         (TestWebKitAPI::TEST_F):
2806
2807 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2808
2809         [GStreamer][EME] Backported mssdemux protection data crash fix
2810         https://bugs.webkit.org/show_bug.cgi?id=195918
2811
2812         Reviewed by Philippe Normand.
2813
2814         * gstreamer/jhbuild.modules:
2815         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
2816
2817 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
2818
2819         Unreviewed, rolling out r243132.
2820
2821         Broke GTK build
2822
2823         Reverted changeset:
2824
2825         "Make WTFLogChannelState and WTFLogLevel enum classes"
2826         https://bugs.webkit.org/show_bug.cgi?id=195904
2827         https://trac.webkit.org/changeset/243132
2828
2829 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
2830
2831         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
2832
2833         * Scripts/webkitdirs.pm:
2834         (builtDylibPathForName): Adjust the shared library name that's changed
2835         with the API version bump in r243073.
2836
2837 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2838
2839         Make WTFLogChannelState and WTFLogLevel enum classes
2840         https://bugs.webkit.org/show_bug.cgi?id=195904
2841
2842         Reviewed by Eric Carlson.
2843
2844         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2845         (TestWebKitAPI::TEST_F):
2846
2847 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2848
2849         Disable flaky test added in r2431100
2850         https://webkit.org/b/195785
2851
2852         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2853         (TestWebKitAPI::TEST):
2854         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
2855
2856 2019-03-18  Timothy Hatcher  <timothy@apple.com>
2857
2858         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
2859         https://bugs.webkit.org/show_bug.cgi?id=195916
2860
2861         Reviewed by Tim Horton.
2862
2863         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2864         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
2865
2866 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
2867
2868         Add a secondary e-mail address for Fujii Hironori to make tools happier.
2869
2870         * Scripts/webkitpy/common/config/contributors.json:
2871
2872 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2873
2874         Implement DownloadMonitor to prevent long-running slow downloads from background apps
2875         https://bugs.webkit.org/show_bug.cgi?id=195785
2876
2877         Reviewed by Geoffrey Garen.
2878
2879         * TestWebKitAPI/TCPServer.cpp: Added.
2880         (TestWebKitAPI::TCPServer::TCPServer):
2881         (TestWebKitAPI::TCPServer::~TCPServer):
2882         (TestWebKitAPI::TCPServer::socketBindListen):
2883         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
2884         * TestWebKitAPI/TCPServer.h: Added.
2885         (TestWebKitAPI::TCPServer::port const):
2886         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2887         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2888         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
2889         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
2890         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2891         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
2892         (TestWebKitAPI::respondSlowly):
2893         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
2894         (TestWebKitAPI::downloadAtRate):
2895         (TestWebKitAPI::TEST):
2896
2897 2019-03-18  Saam Barati  <sbarati@apple.com>
2898
2899         Add a plan file for JetStream 2
2900         https://bugs.webkit.org/show_bug.cgi?id=190734
2901
2902         Reviewed by Mark Lam.
2903
2904         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
2905
2906 2019-03-18  Chris Dumez  <cdumez@apple.com>
2907
2908         Delay WebProcess launch until a load is triggered in a Web view
2909         https://bugs.webkit.org/show_bug.cgi?id=195758
2910         <rdar://problem/48126013>
2911
2912         Reviewed by Geoff Garen.
2913
2914         Add API test coverage. Also update some existing API tests to not expect
2915         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
2916
2917         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
2918         (TestWebKitAPI::TEST):
2919         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
2920         (TestWebKitAPI::TEST):
2921         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2922         (TEST):
2923         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2924         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2925         (TEST):
2926         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2927         (TEST):
2928         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
2929
2930 2019-03-18  Xan Lopez  <xan@igalia.com>
2931
2932         [CMake] Prevent potential warning when determining $architecture
2933         https://bugs.webkit.org/show_bug.cgi?id=195891
2934
2935         Reviewed by Michael Catanzaro.
2936
2937         It's possible for generateBuildSystemForCMakeProject to be called
2938         before determineArchitecture() is ever called. This will make the
2939         first eq check with $architecture to be bogus (and print a
2940         warning). Change that to an eq check with architecture(), which
2941         implicitly calls determineArchitecture() if needed, and change all
2942         the other similar cases in the method in the same way to prevent
2943         future bugs like this one.
2944
2945         * Scripts/webkitdirs.pm:
2946         (generateBuildSystemFromCMakeProject):
2947
2948 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2949
2950         [WPE] Tarballs generated with “make dist” cannot build documentation
2951         https://bugs.webkit.org/show_bug.cgi?id=195885
2952
2953         Reviewed by Carlos Garcia Campos.
2954
2955         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
2956
2957 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2958
2959         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
2960         https://bugs.webkit.org/show_bug.cgi?id=195883
2961
2962         Reviewed by Carlos Garcia Campos.
2963
2964         * gtkdoc/gtkdoc.py:
2965         (GTKDoc._run_command): When commands fail to run, include the full command line for
2966         the program invocation and the output it has generated on the standard error stream.
2967
2968 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2969
2970         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
2971         https://bugs.webkit.org/show_bug.cgi?id=195786
2972
2973         Reviewed by Philippe Normand.
2974
2975         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
2976         * wpe/jhbuild.modules: Ditto.
2977
2978 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
2979
2980         [ews-build] Don't run clean builds on EWS builders
2981         https://bugs.webkit.org/show_bug.cgi?id=195851
2982
2983         Reviewed by Geoffrey Garen.
2984
2985         * BuildSlaveSupport/ews-build/factories.py:
2986
2987 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
2988
2989         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
2990         https://bugs.webkit.org/show_bug.cgi?id=195849
2991
2992         Reviewed by Chris Dumez.
2993
2994         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
2995
2996         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2997         (runWebsiteDataStoreCustomPaths):
2998
2999 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
3000
3001         webkitpy: Upload test results
3002         https://bugs.webkit.org/show_bug.cgi?id=195755
3003         <rdar://problem/48896182>
3004
3005         Reviewed by Aakash Jain.
3006
3007         Establish a new format for uploading results that is not tied to layout tests, apply
3008         that format to webkitpy tests.
3009
3010         * Scripts/webkitpy/common/checkout/scm/git.py:
3011         (Git.native_branch): Return what branch the current checkout is on.
3012         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
3013         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3014         * Scripts/webkitpy/common/checkout/scm/svn.py:
3015         (SVN.native_branch): Ditto.
3016         * Scripts/webkitpy/common/system/platforminfo.py:
3017         (PlatformInfo.build_version): Return a build version for Mac.
3018         * Scripts/webkitpy/common/system/platforminfo_mock.py:
3019         (MockPlatformInfo.__init__):
3020         (MockPlatformInfo.build_version):
3021         * Scripts/webkitpy/results: Added.
3022         * Scripts/webkitpy/results/__init__.py: Added.
3023         * Scripts/webkitpy/results/options.py: Added.
3024         (upload_options): OptParse list for upload options.
3025         * Scripts/webkitpy/results/upload.py: Added.
3026         (Upload): Class which enforces the upload format expected by the results server.
3027         (Upload.Expectations):
3028         (Upload.create_configuration):
3029         (Upload.create_commit):
3030         (Upload.create_details):
3031         (Upload.create_run_stats):
3032         (Upload.create_test_result):
3033         (Upload.__init__):
3034         (Upload.Encoder): Encode Upload object as json.
3035         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
3036         * Scripts/webkitpy/results/upload_unittest.py: Added.
3037         * Scripts/webkitpy/test/main.py:
3038         (Tester._parse_args): Add upload arguments.
3039         (Tester._run_tests): Allow results to be uploaded.
3040         * Scripts/webkitpy/test/runner.py:
3041         (Runner.__init__): Record which tests were run, rather than just counting them.
3042         (Runner.handle):
3043         * Scripts/webkitpy/test/runner_unittest.py:
3044         (RunnerTest.test_run):
3045         * Scripts/webkitpy/thirdparty/__init__.py:
3046         (AutoinstallImportHook.find_module): Add requests auto-install.
3047         (AutoinstallImportHook._install_requests):
3048         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3049         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
3050
3051 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
3052
3053         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
3054         https://bugs.webkit.org/show_bug.cgi?id=195810
3055
3056         Reviewed by Tim Horton.
3057
3058         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
3059         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
3060         ending certain layout tests.
3061
3062         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3063         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3064         (-[TestRunnerWKWebView dealloc]):
3065         (-[TestRunnerWKWebView resetInteractionCallbacks]):
3066
3067         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
3068         helper method when destroying the web view, and when resetting state between tests.
3069
3070         * WebKitTestRunner/ios/TestControllerIOS.mm:
3071         (WTR::TestController::platformResetStateToConsistentValues):
3072
3073         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
3074
3075 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
3076
3077         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
3078         https://bugs.webkit.org/show_bug.cgi?id=190350
3079         <rdar://problem/45089503>
3080
3081         Reviewed by Geoffrey Garen.
3082
3083         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3084         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
3085         (TEST):
3086         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
3087         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
3088         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
3089         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
3090         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
3091         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
3092         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
3093         (runTest):
3094         (createDirectories):
3095         (TEST):
3096         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
3097         (TEST):
3098         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
3099         (TEST):
3100
3101 2019-03-15  Timothy Hatcher  <timothy@apple.com>
3102
3103         Add support to WebPage for getting the contents as an attributed string.
3104         https://bugs.webkit.org/show_bug.cgi?id=195636
3105         rdar://problem/45055697
3106
3107         Reviewed by Tim Horton.
3108
3109         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
3110         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
3111
3112 2019-03-15  Chris Dumez  <cdumez@apple.com>
3113
3114         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
3115         https://bugs.webkit.org/show_bug.cgi?id=195747
3116
3117         Reviewed by Geoff Garen.
3118
3119         Add API test coverage.
3120
3121         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3122
3123 2019-03-15  Shawn Roberts  <sroberts@apple.com>
3124
3125         Unreviewed, rolling out r242952.
3126
3127         Causing API failures on iOS Simulator
3128
3129         Reverted changeset:
3130
3131         "[PSON] Make sure the WebProcessCache is leverage when
3132         relaunching a process after termination"
3133         https://bugs.webkit.org/show_bug.cgi?id=195747
3134         https://trac.webkit.org/changeset/242952
3135
3136 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
3137
3138         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
3139         https://bugs.webkit.org/show_bug.cgi?id=195740
3140
3141         Reviewed by Ross Kirsling.
3142
3143         window.open doesn't work for WebKitBrowserWindow because it is not
3144         implemented yet.
3145
3146         1. Implemented createNewPage callback of WKPageUIClient.
3147         2. Changed MainWindow to take a BrowserWindow factory function
3148           instead of BrowserWindowType to be flexible to create
3149           BrowserWindow with extra settings.
3150         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
3151           because it is not relevant with MainWindow anymore.
3152
3153         * MiniBrowser/win/Common.cpp:
3154         (parseCommandLine):
3155         * MiniBrowser/win/Common.h:
3156         (CommandLineOptions::CommandLineOptions):
3157         * MiniBrowser/win/MainWindow.cpp:
3158         (MainWindow::MainWindow):
3159         (MainWindow::create):
3160         (MainWindow::init):
3161         (MainWindow::WndProc):
3162         * MiniBrowser/win/MainWindow.h:
3163         * MiniBrowser/win/PrintWebUIDelegate.cpp:
3164         (PrintWebUIDelegate::createWebViewWithRequest):
3165         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3166         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
3167         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
3168         (WebKitBrowserWindow::updateProxySettings):
3169         (WebKitBrowserWindow::createNewPage):
3170         * MiniBrowser/win/WebKitBrowserWindow.h:
3171         * MiniBrowser/win/WinMain.cpp:
3172         (wWinMain):
3173
3174 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
3175
3176         Make it possible to test scrolling tree layer manipulation more easily
3177         https://bugs.webkit.org/show_bug.cgi?id=195780
3178
3179         Reviewed by Tim Horton.
3180         
3181         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
3182         cuts off communication of scrolling tree scrolls back to the web process
3183         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
3184         allows tests to trigger scrolls which run the scrolling tree layer positioning
3185         logic, but never get another commit from the web process that might mask
3186         scrolling tree bugs.
3187         
3188         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
3189         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
3190         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
3191
3192         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3193         (WTR::UIScriptController::scrollUpdatesDisabled const):
3194         (WTR::UIScriptController::setScrollUpdatesDisabled):
3195         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3196         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3197         (WTR::UIScriptController::scrollUpdatesDisabled const):
3198         (WTR::UIScriptController::setScrollUpdatesDisabled):
3199         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3200         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3201         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3202         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
3203         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
3204         * WebKitTestRunner/ios/TestControllerIOS.mm:
3205         (WTR::TestController::platformResetStateToConsistentValues):
3206         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3207         (WTR::UIScriptController::scrollUpdatesDisabled const):
3208         (WTR::UIScriptController::setScrollUpdatesDisabled):
3209
3210 2019-03-14  Youenn Fablet  <youenn@apple.com>
3211
3212         Move IDB storage in private browsing mode to NetworkProcess
3213         https://bugs.webkit.org/show_bug.cgi?id=195602
3214
3215         Reviewed by Brady Eidson.
3216
3217         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
3218         (TEST):
3219
3220 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3221
3222         [ews-build] Make descriptionDone messages more readable
3223         https://bugs.webkit.org/show_bug.cgi?id=195760
3224
3225         Reviewed by Lucas Forschler.
3226
3227         * BuildSlaveSupport/ews-build/steps.py:
3228         * BuildSlaveSupport/ews-build/steps_unittest.py:
3229
3230 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3231
3232         [ews-build] Generate status-bubble hover-over messages
3233         https://bugs.webkit.org/show_bug.cgi?id=195680
3234
3235         Reviewed by Lucas Forschler.
3236
3237         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3238         (StatusBubble):
3239         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
3240         on hover-over.
3241         (StatusBubble._iso_time):
3242         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
3243         hover-over message.
3244         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
3245
3246 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3247
3248         [ews-app] Gracefully handle the case when state_string is None
3249         https://bugs.webkit.org/show_bug.cgi?id=195753
3250
3251         Reviewed by Lucas Forschler.
3252
3253         * BuildSlaveSupport/ews-app/ews/models/build.py:
3254         * BuildSlaveSupport/ews-app/ews/models/step.py:
3255
3256 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3257
3258         [ews-app] Status bubble display pending for currently running build step
3259         https://bugs.webkit.org/show_bug.cgi?id=195744
3260
3261         Reviewed by Lucas Forschler.
3262
3263         * BuildSlaveSupport/ews-build/events.py:
3264         (Events.stepStarted): If state_string is pending, replace it with step name.
3265
3266 2019-03-14  Chris Dumez  <cdumez@apple.com>
3267
3268         Add WebsitePolicy for the client to specify the device orientation & motion access policy
3269         https://bugs.webkit.org/show_bug.cgi?id=195750
3270
3271         Reviewed by Geoffrey Garen.
3272
3273         Add API test coverage.
3274
3275         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3276         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
3277         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3278         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3279
3280 2019-03-14  Chris Dumez  <cdumez@apple.com>
3281
3282         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
3283         https://bugs.webkit.org/show_bug.cgi?id=195747
3284
3285         Reviewed by Geoff Garen.
3286
3287         Add API test coverage.
3288
3289         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3290
3291 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
3292
3293         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
3294         https://bugs.webkit.org/show_bug.cgi?id=195725
3295         <rdar://problem/48545062>
3296
3297         Reviewed by Tim Horton.
3298
3299         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
3300         handler is nil.
3301
3302         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3303         (TestWebKitAPI::TEST):
3304
3305 2019-03-13  Sam Weinig  <sam@webkit.org>
3306
3307         Add utility function to allow easy reverse range-based iteration of a container
3308         https://bugs.webkit.org/show_bug.cgi?id=195542
3309
3310         Reviewed by Antti Koivisto.
3311
3312         * TestWebKitAPI/CMakeLists.txt:
3313         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3314         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
3315         (TestWebKitAPI::TEST):
3316         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
3317
3318 2019-03-13  Chris Dumez  <cdumez@apple.com>
3319
3320         Use a ServiceWorker process per registrable domain
3321         https://bugs.webkit.org/show_bug.cgi?id=195649
3322
3323         Reviewed by Youenn Fablet.
3324
3325         Update API test coverage.
3326
3327         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3328
3329 2019-03-13  Chris Dumez  <cdumez@apple.com>
3330
3331         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
3332         https://bugs.webkit.org/show_bug.cgi?id=195684
3333         <rdar://problem/48294714>
3334
3335         Reviewed by Antti Koivisto.
3336
3337         Add API test coverage.
3338
3339         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3340
3341 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
3342
3343         [ews-app] Remove unused patch view
3344         https://bugs.webkit.org/show_bug.cgi?id=195669
3345
3346         Reviewed by Lucas Forschler.
3347
3348         * BuildSlaveSupport/ews-app/ews/urls.py:
3349         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
3350
3351 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
3352
3353         [ews-app] Use Buildbot result code variables
3354         https://bugs.webkit.org/show_bug.cgi?id=195668
3355
3356         Reviewed by Alexey Proskuryakov.
3357
3358         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
3359         (Buildbot): Added Buildbot result code variables.
3360         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3361         (StatusBubble._build_bubble): Used Buildbot result code variables.
3362
3363 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
3364
3365         [Flatpak] Expand submodule recursively
3366         https://bugs.webkit.org/show_bug.cgi?id=195672
3367
3368         Building WPE with flatpak was impossible without that as it was raising an exception.
3369         Also update wpebackend-fdo to match what is built in jhbuild
3370
3371         Reviewed by Philippe Normand.
3372
3373         * flatpak/flatpakutils.py:
3374         (expand_submodules_recurse):
3375         (expand_manifest):
3376         * flatpak/org.webkit.WPEModules.yaml:
3377
3378 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
3379
3380         [ews-app] status bubble should be hidden for certain builds
3381         https://bugs.webkit.org/show_bug.cgi?id=194597
3382
3383         Reviewed by Dewei Zhu.
3384
3385         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3386         (StatusBubble._build_bubble):
3387         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
3388         because the patch didn't have relevant changes.
3389         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
3390         in production yet.
3391
3392 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
3393
3394         [Win] Fix a slew of simple clang-cl warnings.
3395         https://bugs.webkit.org/show_bug.cgi?id=195652
3396
3397         Reviewed by Don Olmstead.
3398
3399         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3400         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
3401
3402 2019-03-12  Justin Fan  <justin_fan@apple.com>
3403
3404         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
3405         https://bugs.webkit.org/show_bug.cgi?id=195518
3406         <rdar://problem/46322356>
3407
3408         Reviewed by Myles C. Maxfield.
3409
3410         * DumpRenderTree/DerivedSources-input.xcfilelist:
3411         * DumpRenderTree/DerivedSources-output.xcfilelist:
3412
3413 2019-03-12  Commit Queue  <commit-queue@webkit.org>
3414
3415         Unreviewed, rolling out r242825.
3416         https://bugs.webkit.org/show_bug.cgi?id=195648
3417
3418         "Broke webkitpy tests with my change to
3419         lldb_dump_class_layout.py" (Requested by rmorisset on
3420         #webkit).
3421
3422         Reverted changeset:
3423
3424         "Alter Tools/Scripts/dump-class-layout to be able to dump all
3425         classes with suspicious padding"
3426         https://bugs.webkit.org/show_bug.cgi?id=195573
3427         https://trac.webkit.org/changeset/242825
3428
3429 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3430
3431         [ews-build] Show status bubbles while the patch is waiting in queue
3432         https://bugs.webkit.org/show_bug.cgi?id=195618
3433
3434         Reviewed by Lucas Forschler.
3435
3436         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3437         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
3438         enabled in initial deployment.
3439         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
3440         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
3441         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
3442         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
3443         (StatusBubble._build_bubbles_for_patch):
3444
3445 2019-03-12  Robin Morisset  <rmorisset@apple.com>
3446
3447         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
3448         https://bugs.webkit.org/show_bug.cgi?id=195573
3449
3450         Reviewed by Simon Fraser.
3451
3452         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
3453
3454         * Scripts/dump-class-layout:
3455         (main):
3456         * lldb/lldb_dump_class_layout.py:
3457         (ClassLayout.__init__):
3458         (ClassLayout._compute_padding_recursive):
3459         (LLDBDebuggerInstance.dump_layout_for_classname):
3460         (LLDBDebuggerInstance):
3461         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
3462         (LLDBDebuggerInstance.layout_for_classname): Deleted.
3463
3464 2019-03-12  Chris Dumez  <cdumez@apple.com>
3465
3466         Device Orientation access permission should be denied unless explicitly granted by the client
3467         https://bugs.webkit.org/show_bug.cgi?id=195625
3468
3469         Reviewed by Youenn Fablet.
3470
3471         add API test coverage.
3472
3473         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3474         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
3475         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
3476         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
3477         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3478         (runDeviceOrientationTest):
3479         (TEST):
3480         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3481         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3482
3483 2019-03-12  Jer Noble  <jer.noble@apple.com>
3484
3485         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
3486         https://bugs.webkit.org/show_bug.cgi?id=195137
3487         <rdar://problem/48810307>
3488
3489         Reviewed by Eric Carlson.
3490
3491         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
3492         (TestWebKitAPI::TEST):
3493
3494 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3495
3496         [ews-build] Change urls from uat to production
3497         https://bugs.webkit.org/show_bug.cgi?id=195566
3498
3499         Reviewed by Lucas Forschler.
3500
3501         * BuildSlaveSupport/ews-app/ews/config.py:
3502         * BuildSlaveSupport/ews-build/events.py:
3503         * BuildSlaveSupport/ews-build/steps.py:
3504
3505 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3506
3507         [ews-build] change max_builds for local-worker to 1
3508         https://bugs.webkit.org/show_bug.cgi?id=195568
3509
3510         Reviewed by Lucas Forschler.
3511
3512         * BuildSlaveSupport/ews-build/loadConfig.py:
3513
3514 2019-03-12  Tim Horton  <timothy_horton@apple.com>
3515
3516         Fix the build
3517
3518         * TestRunnerShared/spi/PencilKitTestSPI.h:
3519         * TestWebKitAPI/ios/PencilKitTestSPI.h:
3520
3521 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
3522
3523         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
3524         https://bugs.webkit.org/show_bug.cgi?id=194131
3525
3526         Reviewed by Michael Catanzaro.
3527
3528         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
3529         (uriChanged):
3530         (testUnfinishedSubresourceLoad):
3531         (serverCallback):
3532         (beforeAll):
3533
3534 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3535
3536         WTF::Expected should use std::addressof instead of operator&
3537         https://bugs.webkit.org/show_bug.cgi?id=195604
3538
3539         Reviewed by Myles Maxfield.
3540
3541         * TestWebKitAPI/Tests/WTF/Expected.cpp:
3542         (TestWebKitAPI::Unique::Unique):
3543         (TestWebKitAPI::Unique::operator&):
3544         (TestWebKitAPI::TEST):
3545
3546 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
3547
3548         Add Optional to Forward.h.
3549         https://bugs.webkit.org/show_bug.cgi?id=195586
3550
3551         Reviewed by Darin Adler.
3552
3553         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
3554         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
3555         Remove unnecessary includes from headers.
3556
3557 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
3558
3559         Add testing API to hit-test and scroll overflow scrollers
3560         https://bugs.webkit.org/show_bug.cgi?id=195278
3561
3562         Reviewed by Antti Koivisto.
3563         
3564         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
3565         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
3566         
3567         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
3568
3569         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3570         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3571         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3572         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3573         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3574         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3575         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3576         (WTR::enclosingScrollViewIncludingSelf):
3577         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3578
3579 2019-03-11  Tim Horton  <timothy_horton@apple.com>
3580
3581         API test WebKit.RequestTextInputContext fails on iOS
3582         https://bugs.webkit.org/show_bug.cgi?id=195585
3583
3584         Reviewed by Wenson Hsieh and Simon Fraser.
3585
3586         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
3587         (applyStyle):
3588         (TEST):
3589         Add a viewport, so that the coordinates match up on iOS.
3590         Scroll by moving the UIScrollView's contentOffset.
3591
3592 2019-03-11  Chris Dumez  <cdumez@apple.com>
3593
3594         Assert in WebPageProxy::suspendCurrentPageIfPossible()
3595         https://bugs.webkit.org/show_bug.cgi?id=195506
3596         <rdar://problem/48733477>
3597
3598         Reviewed by Alex Christensen.
3599
3600         Add API test coverage.
3601
3602         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3603
3604 2019-03-11  Shawn Roberts  <sroberts@apple.com>
3605
3606         Adding myself to contributors.json
3607
3608         Unreviewed, addming myself to contributors.json .
3609
3610         * Scripts/webkitpy/common/config/contributors.json:
3611
3612 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3613
3614         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
3615         https://bugs.webkit.org/show_bug.cgi?id=195511
3616         <rdar://problem/44873269>
3617
3618         Reviewed by Darin Adler.
3619
3620         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3621         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3622         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3623         (TEST_F):
3624
3625 2019-03-11  Chris Dumez  <cdumez@apple.com>
3626
3627         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
3628         https://bugs.webkit.org/show_bug.cgi?id=195561
3629
3630         Reviewed by Youenn Fablet.
3631
3632         Make sure the JS in the test requests for permission to receive device orientation events.
3633
3634         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3635
3636 2019-03-11  Youenn Fablet  <youenn@apple.com>
3637
3638         Allow storage quota increase by default in WTR
3639         https://bugs.webkit.org/show_bug.cgi?id=195541
3640
3641         Reviewed by Geoffrey Garen.
3642
3643         Allow storage quota increase by default in WTR.
3644         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
3645         Use this for tests that explicitly need cache increase.
3646
3647         Instead of increasing quota by 2, make sure the next request is
3648         granted by adding all given parameters.
3649
3650         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3651         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3652         (WTR::TestRunner::setAllowStorageQuotaIncrease):
3653         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
3654         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3655         * WebKitTestRunner/TestController.cpp:
3656         (WTR::TestController::setAllowStorageQuotaIncrease):
3657         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
3658         * WebKitTestRunner/TestController.h:
3659         * WebKitTestRunner/TestInvocation.cpp:
3660         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3661         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3662         (WTR::TestController::cocoaResetStateToConsistentValues):
3663         (WTR::TestController::setAllowStorageQuotaIncrease):
3664         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
3665         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3666         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3667
3668 2019-03-11  Xan Lopez  <xan@igalia.com>
3669
3670         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
3671         https://bugs.webkit.org/show_bug.cgi?id=194147
3672
3673         Reviewed by Michael Saboff.
3674
3675         To make --32-bit work correctly on Linux/64bit we need to:
3676
3677         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
3678         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
3679         unfortunately CMake only allows us to do this during
3680         crosscompilation, which is overkill here.
3681         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
3682         pkg-config detection module uses the x86 .pc files instead of the
3683         x86_64 ones.
3684         - Set the -m32 flags for the compiler.
3685
3686         * Scripts/webkitdirs.pm:
3687         (generateBuildSystemFromCMakeProject):
3688
3689 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
3690
3691         Add MotionMark-1.1 plan file for run-benchmark script.
3692         https://bugs.webkit.org/show_bug.cgi?id=195481
3693
3694         Rubber-stamped by Darin Adler.
3695
3696         Run-benchmark script should support&n