Run tests on mips EWS
[WebKit-https.git] / Tools / ChangeLog
1 2019-07-10  Guillaume Emont  <guijemont@igalia.com>
2
3         Run tests on mips EWS
4         https://bugs.webkit.org/show_bug.cgi?id=196854
5
6         Reviewed by Carlos Garcia Campos.
7
8         * Scripts/webkitpy/common/config/ews.json:
9
10 2019-07-09  Michael Catanzaro  <mcatanzaro@igalia.com>
11
12         [WPE][GTK] GUniqueOutPtr::release should return a raw pointer
13         https://bugs.webkit.org/show_bug.cgi?id=199579
14
15         Reviewed by Carlos Garcia Campos.
16
17         * TestWebKitAPI/Tests/WTF/glib/GUniquePtr.cpp:
18         (TestWebKitAPI::TEST):
19
20 2019-07-09  Chris Dumez  <cdumez@apple.com>
21
22         Fix integer type encoding / decoding in WKRemoteObjectCoder
23         https://bugs.webkit.org/show_bug.cgi?id=199643
24         <rdar://problem/52732342>
25
26         Reviewed by Anders Carlsson.
27
28         Update API test coverage.
29
30         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.h:
31         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.mm:
32         (TEST):
33         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistryPlugIn.mm:
34         (-[RemoteObjectRegistryPlugIn takeUnsignedLongLong:completionHandler:]):
35         (-[RemoteObjectRegistryPlugIn takeLongLong:completionHandler:]):
36         (-[RemoteObjectRegistryPlugIn takeUnsignedLong:completionHandler:]):
37         (-[RemoteObjectRegistryPlugIn takeLong:completionHandler:]):
38
39 2019-07-09  Sam Weinig  <weinig@apple.com>
40
41         Add StringBuilder member function which allows makeString() style variadic argument construction
42         https://bugs.webkit.org/show_bug.cgi?id=198997
43
44         Reviewed by Darin Adler.
45
46         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
47         Add basic test showing that StringBuilder::flexibleAppend can be used to 
48         append one or more string adaptable types. 
49
50 2019-07-09  Sihui Liu  <sihui_liu@apple.com>
51
52         Only allow fetching and removing session credentials from WebsiteDataStore
53         https://bugs.webkit.org/show_bug.cgi?id=199385
54         <rdar://problem/52622080>
55
56         Reviewed by Alex Christensen.
57
58         removeDataOfTypes will no longer remove persistent credentials. We should clear persistent credentials using
59         the new SPI after each test that creates persistent credentials, otherwise the later tests may use credentials
60         left by previous tests and didReceiveAuthenticationChallenge will not be invoked.
61
62         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
63         (TEST):
64         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
65         (TestWebKitAPI::TEST):
66
67 2019-07-09  Alex Christensen  <achristensen@webkit.org>
68
69         When parsing an IPv4 address, wait until after deciding it is indeed an IPv4 address before reporting syntax violations
70         https://bugs.webkit.org/show_bug.cgi?id=199628
71
72         Reviewed by Brady Eidson.
73
74         * TestWebKitAPI/Tests/WTF/URLParser.cpp:
75         (TestWebKitAPI::TEST_F):
76
77 2019-07-09  Alex Christensen  <achristensen@webkit.org>
78
79         Remove invalid assertion in URLParser::domainToASCII
80         https://bugs.webkit.org/show_bug.cgi?id=199624
81
82         Reviewed by Brady Eidson.
83
84         * TestWebKitAPI/Tests/WTF/URLParser.cpp:
85         (TestWebKitAPI::TEST_F):
86
87 2019-07-09  Alex Christensen  <achristensen@webkit.org>
88
89         URLParser should reserialize IPv6 addresses that end with a colon
90         https://bugs.webkit.org/show_bug.cgi?id=199627
91
92         Reviewed by Brady Eidson.
93
94         * TestWebKitAPI/Tests/WTF/URLParser.cpp:
95         (TestWebKitAPI::TEST_F):
96
97 2019-07-08  Aakash Jain  <aakash_jain@apple.com>
98
99         [ews-build] Do not run unix commands for windows in PrintConfiguration
100         https://bugs.webkit.org/show_bug.cgi?id=199605
101
102         Reviewed by Jonathan Bedard.
103
104         * BuildSlaveSupport/ews-build/steps.py:
105
106 2019-07-08  Fujii Hironori  <Hironori.Fujii@sony.com>
107
108         JSTestGlobalObject.cpp of bindings-generation-tests is failing for Windows Python
109         https://bugs.webkit.org/show_bug.cgi?id=199487
110
111         Reviewed by Ross Kirsling.
112
113         In Windows Python, preprocessor.pm is using cl.exe. cl.exe was
114         failing to open testglobalscope_constructors_file which was
115         created by using tempfile.mkstemp() because it keeps the file
116         open. Use tempfile.mkdtemp() to create temporary files in the
117         temporary directory instead of tempfile.mkstemp().
118
119         * Scripts/webkitpy/bindings/main.py:
120         (BindingsTests.run_tests):
121         (BindingsTests.main):
122         (BindingsTests.close_and_remove): Deleted.
123
124 2019-07-08  Aakash Jain  <aakash_jain@apple.com>
125
126         [ews-build] Add KillOldProcesses step before running API or Layout tests
127         https://bugs.webkit.org/show_bug.cgi?id=199592
128
129         Reviewed by Jonathan Bedard.
130
131         * BuildSlaveSupport/ews-build/factories.py:
132
133 2019-07-08  Jonathan Bedard  <jbedard@apple.com>
134
135         test-webkitpy: Explicitly use Python 2.7 lldb library
136         https://bugs.webkit.org/show_bug.cgi?id=199578
137         <rdar://problem/51853557>
138
139         Reviewed by Aakash Jain.
140
141         * Scripts/webkitpy/common/system/systemhost.py:
142         (SystemHost.path_to_lldb_python_directory): Explicitly use Python 2.7 lldb libary.
143         * Scripts/webkitpy/test/main.py:
144         (_supports_building_and_running_lldb_tests): Run lldb tests on Catalina again.
145
146 2019-07-08  Ryan Haddad  <ryanhaddad@apple.com>
147
148         Add test expectations and baselines for Catalina
149         https://bugs.webkit.org/show_bug.cgi?id=199328
150
151         Reviewed by Jonathan Bedard.
152
153         * Scripts/webkitpy/port/mac.py:
154         (MacPort): Increment current version to 10.15 so that baseline search paths are correctly constructed for High Sierra.
155
156 2019-07-08  Christopher Reid  <chris.reid@sony.com>
157
158         Implement MappedFileData for Windows
159         https://bugs.webkit.org/show_bug.cgi?id=198269
160
161         Reviewed by Darin Adler.
162
163         * TestWebKitAPI/PlatformWin.cmake:
164
165 2019-07-08  Charlie Turner  <cturner@igalia.com>
166
167         REGRESSION(r243197): [GStreamer] Web process hangs when scrolling twitter timeline which contains HLS videos
168         https://bugs.webkit.org/show_bug.cgi?id=197558
169
170         Reviewed by Xabier Rodriguez-Calvar.
171
172         On shutdown we can easily deadlock the web process if we don't
173         ensure all network operations are completed before comitting state
174         changes. In HLS, make sure the network operations are cancelled,
175         and also prevent hlsdemux's retry logic from scuppering our
176         efforts.
177
178         * gstreamer/jhbuild.modules: Include the patch.
179         * gstreamer/patches/gst-plugins-bad-do-not-retry-downloads-during-shutdown.patch: Added.
180
181 2019-07-08  Antoine Quint  <graouts@apple.com>
182
183         [Pointer Events] Enable only on the most recent version of the supported iOS family
184         https://bugs.webkit.org/show_bug.cgi?id=199562
185         <rdar://problem/52766511>
186
187         Reviewed by Dean Jackson.
188
189         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
190
191 2019-07-06  Simon Fraser  <simon.fraser@apple.com>
192
193         Long hang when loading a cnn.com page on iOS
194         https://bugs.webkit.org/show_bug.cgi?id=199556
195
196         Reviewed by Zalan Bujtas.
197
198         Add code to load a page by default in MobileMiniBrowser so it's easy to hack it
199         to load a test page of your choice.
200
201         * MobileMiniBrowser/MobileMiniBrowserFramework/WebViewController.m:
202         (-[WebViewController viewDidLoad]):
203
204 2019-07-05  Ryosuke Niwa  <rniwa@webkit.org>
205
206         [iOS] Crash in WebKit::WebPage::positionInformation via Range::startPosition
207         https://bugs.webkit.org/show_bug.cgi?id=199503
208
209         Reviewed by Wenson Hsieh.
210
211         Added UIScriptController.ensurePositionInformationIsUpToDateAt using the existing WKWebView SPI:
212         _requestActivatedElementAtPosition
213
214         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
215         (WTR::UIScriptController::ensurePositionInformationIsUpToDateAt):
216         * DumpRenderTree/mac/UIScriptControllerMac.mm:
217         (WTR::UIScriptController::ensurePositionInformationIsUpToDateAt):
218         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
219         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
220         (WTR::UIScriptController::ensurePositionInformationIsUpToDateAt):
221         * TestRunnerShared/UIScriptContext/UIScriptController.h:
222         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
223         (WTR::UIScriptController::ensurePositionInformationIsUpToDateAt):
224         * WebKitTestRunner/ios/UIScriptControllerMac.mm:
225         (WTR::UIScriptController::ensurePositionInformationIsUpToDateAt):
226
227 2019-07-05  Ryan Haddad  <ryanhaddad@apple.com>
228
229         Unreviewed, rolling out r247115.
230
231         Breaks lldbWebKitTester (and by extension, test-webkitpy)
232
233         Reverted changeset:
234
235         "[WHLSL] Standard library is too big to directly include in
236         WebCore"
237         https://bugs.webkit.org/show_bug.cgi?id=198186
238         https://trac.webkit.org/changeset/247115
239
240 2019-07-05  Ryan Haddad  <ryanhaddad@apple.com>
241
242         Unreviewed, rolling out r247123.
243
244         Caused TestWebKitAPI.Challenge.BasicProposedCredential to
245         fail.
246
247         Reverted changeset:
248
249         "Only allow fetching and removing session credentials from
250         WebsiteDataStore"
251         https://bugs.webkit.org/show_bug.cgi?id=199385
252         https://trac.webkit.org/changeset/247123
253
254 2019-07-05  Wenson Hsieh  <wenson_hsieh@apple.com>
255
256         Touching media controls sometimes shows software keyboard
257         https://bugs.webkit.org/show_bug.cgi?id=199490
258         <rdar://problem/52076270>
259
260         Reviewed by Eric Carlson.
261
262         Adds plumbing for a new testing hook to check whether or not there is an active input session. See other
263         ChangeLog entries for more detail.
264
265         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
266         (WTR::UIScriptController::hasInputSession const):
267         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
268         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
269         (WTR::UIScriptController::hasInputSession const):
270         * TestRunnerShared/UIScriptContext/UIScriptController.h:
271         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
272         (WTR::UIScriptController::hasInputSession const):
273
274 2019-07-04  Aakash Jain  <aakash_jain@apple.com>
275
276         [ews-build] Remove GTK and WPE queue from old EWS and dashboard
277         https://bugs.webkit.org/show_bug.cgi?id=199458
278
279         Reviewed by Michael Catanzaro.
280
281         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
282         * QueueStatusServer/config/queues.py:
283
284 2019-07-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
285
286         [GTK] Fix browserperfdash script after r239522
287         https://bugs.webkit.org/show_bug.cgi?id=199496
288
289         Reviewed by Michael Catanzaro.
290
291         * Scripts/webkitpy/browserperfdash/browserperfdash_runner.py:
292         (BrowserPerfDashRunner.run): Pass None for the new required BenchmarkRunner constructor.
293
294 2019-07-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
295
296         [webkitpy] test-webkitpy is broken on Linux since r246662
297         https://bugs.webkit.org/show_bug.cgi?id=199493
298
299         Reviewed by Michael Catanzaro.
300
301         * Scripts/webkitpy/test/main.py:
302         (_supports_building_and_running_lldb_tests): Add a check for None before calling startswith().
303
304 2019-07-02  Carlos Alberto Lopez Perez  <clopez@igalia.com>
305
306         [GTK][WPE] Not longer needed to build woff2 on the JHBuild
307         https://bugs.webkit.org/show_bug.cgi?id=199406
308
309         Reviewed by Michael Catanzaro.
310
311         Install the Woff2 libraries and headers from the system package
312         and stop building them on the JHBuild.
313
314         * gtk/install-dependencies:
315         * gtk/jhbuild.modules:
316         * wpe/install-dependencies:
317         * wpe/jhbuild.modules:
318
319 2019-07-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
320
321         [GTK][WPE][CMake] The CMake cache should be clean when the JHBuild is rebuilt
322         https://bugs.webkit.org/show_bug.cgi?id=199449
323
324         Reviewed by Michael Catanzaro.
325
326         * Scripts/webkitdirs.pm:
327         (shouldRemoveCMakeCache): Clean the CMake cache if we detect that the JHBuild has been rebuilt.
328
329 2019-07-01  Philippe Normand  <pnormand@igalia.com>
330
331         Unreviewed, GTK a11y tests fix after r247071
332
333         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
334         (WTR::AccessibilityUIElement::popupValue const):
335
336 2019-07-03  Aakash Jain  <aakash_jain@apple.com>
337
338         [ews-build] Enable WPE and GTK queues on new EWS
339         https://bugs.webkit.org/show_bug.cgi?id=199234
340
341         Reviewed by Jonathan Bedard.
342
343         * BuildSlaveSupport/ews-build/config.json: Enabled the triggers for GTK and WPE builders.
344         * BuildSlaveSupport/ews-build/factories.py: Added required build steps for GTKFactory and WPEFactory.
345         * BuildSlaveSupport/ews-build/steps.py:
346         (CompileWebKit.evaluateCommand): Added InstallGtkDependencies/InstallWpeDependencies step before Compiling WebKit without patch.
347         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
348         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
349         (StatusBubble): Enable gtk and wpe status-bubbles.
350
351 2019-07-03  Sihui Liu  <sihui_liu@apple.com>
352
353         Only allow fetching and removing session credentials from WebsiteDataStore
354         https://bugs.webkit.org/show_bug.cgi?id=199385
355
356         Reviewed by Alex Christensen.
357
358         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
359         (TestWebKitAPI::TEST):
360
361 2019-07-03  Tim Horton  <timothy_horton@apple.com>
362
363         UI process exception when dragging an <attachment> with no content type
364         https://bugs.webkit.org/show_bug.cgi?id=199480
365         <rdar://problem/44351353>
366
367         Reviewed by Wenson Hsieh.
368
369         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
370         (TestWebKitAPI::TEST):
371         Add a test; before the change, it crashes.
372
373 2019-07-03  Jonathan Bedard  <jbedard@apple.com>
374
375         [Catalina] Enable WebKit build
376         https://bugs.webkit.org/show_bug.cgi?id=199209
377
378         Reviewed by Darin Adler.
379
380         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig: Add Mac framework stubs.
381
382 2019-07-03  Sam Weinig  <weinig@apple.com>
383
384         Adopt simple structured bindings in more places
385         https://bugs.webkit.org/show_bug.cgi?id=199247
386
387         Reviewed by Alex Christensen.
388
389         Replaces simple uses of std::tie() with structured bindings. Does not touch
390         uses of std::tie() that are not initial declarations, use std::ignore or in
391         case where the binding is captured by a lambda, as structured bindings don't
392         work for those cases yet.
393
394         * TestWebKitAPI/ios/PreferredContentMode.mm:
395         (TestWebKitAPI::TEST):
396
397 2019-07-03  Aakash Jain  <aakash_jain@apple.com>
398
399         Unreviewed follow-up fix to r247049, default the platform to '*' when platform property is not set.
400
401         * BuildSlaveSupport/ews-build/steps.py:
402         (PrintConfiguration.run):
403
404 2019-07-02  Aakash Jain  <aakash_jain@apple.com>
405
406         [ews-build] Add build steps to Install Wpe and Gtk dependencies
407         https://bugs.webkit.org/show_bug.cgi?id=199408
408
409         Reviewed by Michael Catanzaro.
410
411         * BuildSlaveSupport/ews-build/steps.py:
412         (InstallGtkDependencies): Build step to install dependencies for GTK. Set haltOnFailure=False so that in case of failure, build isn't
413         marked as failed (which would indicated patch failed EWS), instead subsequent steps would be run and the build would be marked as RETRY.
414         (InstallWpeDependencies): Ditto for WPE.
415         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
416
417 2019-07-02  Aakash Jain  <aakash_jain@apple.com>
418
419         [ews-build] Allow skipping uploading built product for few builders
420         https://bugs.webkit.org/show_bug.cgi?id=199422
421
422         Reviewed by Michael Catanzaro.
423
424         * BuildSlaveSupport/ews-build/steps.py:
425         (CompileWebKit.__init__): Added optional skipUpload parameter.
426         (CompileWebKit.evaluateCommand): Allow to skip upload if there are no triggers and skipUpload is True.
427
428 2019-07-02  Tim Horton  <timothy_horton@apple.com>
429
430         REGRESSION (r243240): Unable to swipe back in Safari
431         https://bugs.webkit.org/show_bug.cgi?id=199394
432         <rdar://problem/51137447>
433
434         Reviewed by Wenson Hsieh.
435
436         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
437         Make sure that we actually end up with swipe gesture recognizers installed
438         after process swap and crash.
439
440 2019-07-02  Andres Gonzalez  <andresg_22@apple.com>
441
442         Enhance support of aria-haspopup per ARIA 1.1 specification.
443         https://bugs.webkit.org/show_bug.cgi?id=199216
444         <rdar://problem/46221342>
445
446         Reviewed by Chris Fleizach.
447
448         * DumpRenderTree/AccessibilityUIElement.cpp:
449         (getPopupValueCallback):
450         (AccessibilityUIElement::getJSClass):
451         * DumpRenderTree/AccessibilityUIElement.h:
452         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
453         (AccessibilityUIElement::popupValue const):
454         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
455         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
456         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
457         (WTR::AccessibilityUIElement::popupValue const):
458         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
459         (WTR::AccessibilityUIElement::popupValue const):
460
461 2019-07-02  Aakash Jain  <aakash_jain@apple.com>
462
463         [ews-build] Do not print worker environment variables in each build step [part 2]
464         https://bugs.webkit.org/show_bug.cgi?id=199405
465
466         Reviewed by Jonathan Bedard.
467
468         * BuildSlaveSupport/ews-build/steps.py:
469         (CheckOutSpecificRevision.__init__): Disabled logging of environment variables.
470         (CleanWorkingDirectory.__init__): Ditto.
471         (RunBindingsTests.__init__): Ditto.
472         (RunWebKitPerlTests.__init__): Ditto.
473         (RunWebKitPyTests.__init__): Ditto.
474         (CompileWebKit.__init__): Ditto.
475         (ArchiveTestResults.__init__): Ditto.
476         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
477
478 2019-07-02  Jer Noble  <jer.noble@apple.com>
479
480         Pipe suport for 'cenc' init data type into CDMFairPlayStreaming
481         https://bugs.webkit.org/show_bug.cgi?id=199381
482         <rdar://problem/52483103>
483
484         Reviewed by Eric Carlson.
485
486         * TestWebKitAPI/Tests/WebCore/ISOBox.cpp:
487
488 2019-07-02  Aakash Jain  <aakash_jain@apple.com>
489
490         [ews-build] Update bot configuration for WPE and GTK
491         https://bugs.webkit.org/show_bug.cgi?id=199238
492
493         Reviewed by Michael Catanzaro.
494
495         * BuildSlaveSupport/ews-build/config.json:
496
497 2019-07-02  Aakash Jain  <aakash_jain@apple.com>
498
499         [ews-build] Make PrintConfiguration platform aware
500         https://bugs.webkit.org/show_bug.cgi?id=196657
501
502         Reviewed by Lucas Forschler.
503
504         * BuildSlaveSupport/ews-build/steps.py:
505         (PrintConfiguration): Specified platform-specific command lists.
506         (PrintConfiguration.run): Override run method and specify platform specific commands.
507         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
508
509 2019-07-01  Justin Michaud  <justin_michaud@apple.com>
510
511         [Wasm-References] Disable references by default
512         https://bugs.webkit.org/show_bug.cgi?id=199390
513
514         Reviewed by Saam Barati.
515
516         * Scripts/run-jsc-stress-tests:
517
518 2019-07-01  Joonghun Park  <pjh0718@gmail.com>
519
520         Unreviewed. Revert r246965 to fix build break
521         since r247019 reverted its related changes.
522
523         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
524         (WTR::AccessibilityUIElement::popupValue const): Deleted.
525
526 2019-07-01  Alex Christensen  <achristensen@webkit.org>
527
528         Add new decidePolicyForNavigationAction SPI with preferences and userInfo
529         https://bugs.webkit.org/show_bug.cgi?id=199371
530         <rdar://problem/52352905>
531
532         Reviewed by Tim Horton.
533
534         * TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
535         (-[NavigationActionSPIDelegate webView:didFinishNavigation:]):
536         (-[NavigationActionSPIDelegate _webView:decidePolicyForNavigationAction:preferences:userInfo:decisionHandler:]):
537         (-[NavigationActionSPIDelegate spiCalled]):
538         (TEST):
539
540 2019-07-01  Alex Christensen  <achristensen@webkit.org>
541
542         Deprecate _webView:showCustomSheetForElement: after transition to UIContextMenuInteraction
543         https://bugs.webkit.org/show_bug.cgi?id=199296
544         <rdar://problem/51041960>
545
546         Reviewed by Darin Adler.
547
548         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
549         (-[DragAndDropSimulator _webView:showCustomSheetForElement:]):
550
551 2019-07-01  Truitt Savell  <tsavell@apple.com>
552
553         Unreviewed, rolling out r246958.
554
555         Broke inspector/dom/getAccessibilityPropertiesForNode.html
556
557         Reverted changeset:
558
559         "Enhance support of aria-haspopup per ARIA 1.1 specification."
560         https://bugs.webkit.org/show_bug.cgi?id=199216
561         https://trac.webkit.org/changeset/246958
562
563 2019-07-01  Philippe Normand  <pnormand@igalia.com>
564
565         Unreviewed, GTK a11y tests fix after r246958
566
567         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
568         (WTR::AccessibilityUIElement::popupValue const):
569
570 2019-06-30  Andres Gonzalez  <andresg_22@apple.com>
571
572         Enhance support of aria-haspopup per ARIA 1.1 specification.
573         https://bugs.webkit.org/show_bug.cgi?id=199216
574         <rdar://problem/46221342>
575
576         Reviewed by Chris Fleizach.
577
578         * DumpRenderTree/AccessibilityUIElement.cpp:
579         (getPopupValueCallback):
580         (AccessibilityUIElement::getJSClass):
581         * DumpRenderTree/AccessibilityUIElement.h:
582         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
583         (AccessibilityUIElement::popupValue const):
584         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
585         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
586         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
587         (WTR::AccessibilityUIElement::popupValue const):
588         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
589         (WTR::AccessibilityUIElement::popupValue const):
590
591 2019-06-28  Robin Morisset  <rmorisset@apple.com>
592
593         Adding myself as a reviewer to contributors.json.
594
595         Unreviewed.
596
597         * Scripts/webkitpy/common/config/contributors.json:
598
599 2019-06-28  Jer Noble  <jer.noble@apple.com>
600
601         Add new -[WKWebView _closeAllMediaPresentations] SPI
602         https://bugs.webkit.org/show_bug.cgi?id=199294
603         <rdar://problem/51965958>
604
605         Reviewed by Alex Christensen.
606
607         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
608         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewCloseAllMediaPresentations.mm: Added.
609         (TEST):
610
611 2019-06-28  Sihui Liu  <sihui_liu@apple.com>
612
613         Add a regression test for change r246901
614         https://bugs.webkit.org/show_bug.cgi?id=199290
615
616         Reviewed by Geoffrey Garen.
617
618         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
619         * TestWebKitAPI/Tests/WebKitCocoa/LocalStoragePersistence.mm:
620         (-[LocalStorageNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
621         (TEST):
622         * TestWebKitAPI/Tests/WebKitCocoa/localstorage-open-window-private.html: Added.
623
624 2019-06-28  Konstantin Tokarev  <annulen@yandex.ru>
625
626         Remove traces of ENABLE_ICONDATABASE remaining after its removal in 219733
627         https://bugs.webkit.org/show_bug.cgi?id=199317
628
629         Reviewed by Michael Catanzaro.
630
631         While IconDatabase and all code using it was removed,
632         ENABLE_ICONDATABASE still exists as build option and C++ macro.
633
634         * Scripts/webkitperl/FeatureList.pm:
635         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
636         * gtk/manifest.txt.in: Remove reference to unused urlIcon.png file.
637         * wpe/manifest.txt.in: Remove reference to unused urlIcon.png file.
638
639 2019-06-28  Wenson Hsieh  <wenson_hsieh@apple.com>
640
641         -[WKContentView _selectionClipRects] returns a bogus value in -reloadInputViews when focusing an element
642         https://bugs.webkit.org/show_bug.cgi?id=199310
643         <rdar://problem/52292137>
644
645         Reviewed by Megan Gardner.
646
647         Add a new API test to verify that _selectionClipRects returns the correct value when invoked under the scope of
648         _elementDidFocus.
649
650         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
651         (TestWebKitAPI::TEST):
652         * TestWebKitAPI/Tests/ios/TestInputDelegate.h:
653         * TestWebKitAPI/Tests/ios/TestInputDelegate.mm:
654         (-[TestInputDelegate setDidStartInputSessionHandler:]):
655         (-[TestInputDelegate didStartInputSessionHandler]):
656
657         Add plumbing for a handler block in TestInputDelegate.
658
659         (-[TestInputDelegate setWillStartInputSessionHandler:]):
660
661         Drive-by style fixes to add a space between id and < for Objective-C protocols.
662
663         (-[TestInputDelegate willStartInputSessionHandler]):
664         (-[TestInputDelegate _webView:willStartInputSession:]):
665         (-[TestInputDelegate _webView:didStartInputSession:]):
666         * TestWebKitAPI/cocoa/TestWKWebView.h:
667         * TestWebKitAPI/ios/UIKitSPI.h:
668
669         Add a declaration for _selectionClipRects.
670
671 2019-06-27  Zalan Bujtas  <zalan@apple.com>
672
673         REGRESSION(r244633): e-mail with "height: 100%" causes unstable layout.
674         https://bugs.webkit.org/show_bug.cgi?id=199303
675         <rdar://problem/51340927>
676
677         Reviewed by Tim Horton.
678
679         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
680         (TEST):
681
682 2019-06-27  Beth Dakin  <bdakin@apple.com>
683
684         Upstream use of MACCATALYST
685         https://bugs.webkit.org/show_bug.cgi?id=199245
686         rdar://problem/51687723
687
688         Reviewed by Tim Horton.
689
690         * ContentExtensionTester/Configurations/SDKVariant.xcconfig:
691         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig:
692         * ImageDiff/cg/Configurations/SDKVariant.xcconfig:
693         * MiniBrowser/Configurations/SDKVariant.xcconfig:
694         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig:
695         * Scripts/webkitpy/generate_xcfilelists_lib/generators.py:
696         (JavaScriptCoreGenerator):
697         (WebCoreGenerator):
698         (WebKitGenerator):
699         * TestWebKitAPI/Configurations/Base.xcconfig:
700         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
701         * TestWebKitAPI/Configurations/SDKVariant.xcconfig:
702         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
703         * WebEditingTester/Configurations/SDKVariant.xcconfig:
704         * WebKitLauncher/Configurations/SDKVariant.xcconfig:
705         * WebKitTestRunner/Configurations/SDKVariant.xcconfig:
706         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig:
707
708 2019-06-27  Saam Barati  <sbarati@apple.com>
709
710         Make WEBGPU enabled only on Mojave and later.
711
712         Rubber-stamped by Myles C. Maxfield.
713
714         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
715
716 2019-06-27  Aakash Jain  <aakash_jain@apple.com>
717
718         [ews-build] Do not print worker environment variables in each build step
719         https://bugs.webkit.org/show_bug.cgi?id=197319
720
721         Reviewed by Lucas Forschler.
722
723         * BuildSlaveSupport/ews-build/steps.py:
724         (CheckOutSource.__init__): Disabled logging of environment variables.
725         (ApplyPatch.__init__): Ditto.
726         (KillOldProcesses.__init__): Ditto.
727         (ArchiveBuiltProduct.__init__): Ditto.
728         (DownloadBuiltProduct.__init__): Ditto.
729         (ExtractBuiltProduct.__init__): Ditto.
730         (RunAPITests.__init__): Ditto.
731         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests accordingly.
732
733 2019-06-26  Jiewen Tan  <jiewen_tan@apple.com>
734
735         SubFrameSOAuthorizationSession should preserve the referrer header when fall back to web path
736         https://bugs.webkit.org/show_bug.cgi?id=199232
737         <rdar://problem/51718328>
738
739         Reviewed by Youenn Fablet.
740
741         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
742         (TestWebKitAPI::TEST):
743         Add a test that utilizes TCPServer as local files always omit referrer.
744
745 2019-06-26  Aakash Jain  <aakash_jain@apple.com>
746
747         [ews-build] Add configuration and architecture for WPE and GTK builders
748         https://bugs.webkit.org/show_bug.cgi?id=199249
749
750         Reviewed by Jonathan Bedard.
751
752         * BuildSlaveSupport/ews-build/config.json:
753
754 2019-06-26  Aakash Jain  <aakash_jain@apple.com>
755
756         [ews-build] Add check for duplicate workers in config.json
757         https://bugs.webkit.org/show_bug.cgi?id=199240
758
759         Reviewed by Jonathan Bedard.
760
761         * BuildSlaveSupport/ews-build/loadConfig.py:
762         (checkWorkersAndBuildersForConsistency._find_worker_with_name): Check for duplicate worker entry.
763         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
764         (TestcheckWorkersAndBuildersForConsistency.test_duplicate_worker): Added unit-test.
765
766 2019-06-26  Ross Kirsling  <ross.kirsling@sony.com>
767
768         [Win] MiniBrowser should make better font choices
769         https://bugs.webkit.org/show_bug.cgi?id=199244
770
771         Reviewed by Brent Fulgham.
772
773         * MiniBrowser/win/MainWindow.cpp:
774         (MainWindow::updateDeviceScaleFactor):
775         * MiniBrowser/win/MiniBrowserLib.rc:
776
777 2019-06-26  Alex Christensen  <achristensen@webkit.org>
778
779         testRunner.setAlwaysAcceptCookies should wait for cookie accept policy to be set
780         https://bugs.webkit.org/show_bug.cgi?id=199230
781         <rdar://51757107>
782
783         Reviewed by Andy Estes.
784
785         * TestWebKitAPI/Tests/WebKit/CookieManager.cpp:
786         (TestWebKitAPI::didGetTestHTTPCookieAcceptPolicy):
787         (TestWebKitAPI::didGetUserHTTPCookieAcceptPolicy):
788         * WebKitTestRunner/TestController.cpp:
789         (WTR::TestController::generatePageConfiguration):
790         (WTR::TestController::createWebViewWithOptions):
791         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundleWithListener):
792         (WTR::TestController::didReceiveSynchronousPageMessageFromInjectedBundleWithListener):
793         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
794         (WTR::TestController::didReceiveSynchronousPageMessageFromInjectedBundle): Deleted.
795         * WebKitTestRunner/TestController.h:
796         * WebKitTestRunner/TestInvocation.cpp:
797         (WTR::TestInvocation::invoke):
798         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
799
800 2019-06-26  Ross Kirsling  <ross.kirsling@sony.com>
801
802         [Win][MiniBrowser] Remove obsolete code after r246814.
803         https://bugs.webkit.org/show_bug.cgi?id=199233
804
805         Reviewed by Fujii Hironori.
806
807         * MiniBrowser/win/MiniBrowserWebHost.cpp:
808         (MiniBrowserWebHost::didFinishLoadForFrame):
809         (SimpleEventListener::SimpleEventListener): Deleted.
810         (SimpleEventListener::handleEvent): Deleted.
811
812 2019-06-25  Jiewen Tan  <jiewen_tan@apple.com>
813
814         Implement a new SPI to inform clients about AppSSO
815         https://bugs.webkit.org/show_bug.cgi?id=199085
816         <rdar://problem/50028246>
817
818         Reviewed by Geoffrey Garen.
819
820         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
821         (-[TestSOAuthorizationBasicDelegate webView:didFinishNavigation:]):
822         (-[TestSOAuthorizationNavigationDelegate init]):
823         (-[TestSOAuthorizationNavigationDelegate _webView:decidePolicyForSOAuthorizationLoadWithCurrentPolicy:forExtension:completionHandler:]):
824         (TestWebKitAPI::TEST):
825
826 2019-06-25  Aakash Jain  <aakash_jain@apple.com>
827
828         [ews-build] Retry Layout test in case of failures
829         https://bugs.webkit.org/show_bug.cgi?id=199194
830
831         Reviewed by Jonathan Bedard.
832
833         * BuildSlaveSupport/ews-build/steps.py:
834         (RunWebKitTests.evaluateCommand): Check if tests failed and retry them if required.
835         (ReRunWebKitTests): Build step to re-run layout tests.
836         (ReRunWebKitTests.evaluateCommand): Check if tests failed and retry on clean build if required.
837         (RunWebKitTestsWithoutPatch): Build step to run tests without patch.
838         (RunWebKitTestsWithoutPatch.evaluateCommand):
839
840 2019-06-25  Aakash Jain  <aakash_jain@apple.com>
841
842         [ews-build] Combine various patchFailed*Tests properties
843         https://bugs.webkit.org/show_bug.cgi?id=199193
844
845         Reviewed by Jonathan Bedard.
846
847         * BuildSlaveSupport/ews-build/steps.py: Renamed patchFailedJSCTests and patchFailedAPITests to patchFailedTests. This property 
848         can also be used for layout-tests later on.
849         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
850
851 2019-06-25  Ross Kirsling  <ross.kirsling@sony.com>
852
853         [Win] MiniBrowser should default to webkit.org
854         https://bugs.webkit.org/show_bug.cgi?id=199201
855
856         Reviewed by Don Olmstead.
857
858         * MiniBrowser/win/BrowserWindow.h:
859         * MiniBrowser/win/MiniBrowserReplace.h:
860         * MiniBrowser/win/WebKitBrowserWindow.cpp:
861         (WebKitBrowserWindow::loadHTMLString): Deleted.
862         * MiniBrowser/win/WebKitBrowserWindow.h:
863         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
864         (WebKitLegacyBrowserWindow::loadHTMLString): Deleted.
865         * MiniBrowser/win/WebKitLegacyBrowserWindow.h:
866         * MiniBrowser/win/WinMain.cpp:
867         (wWinMain):
868
869 2019-06-25  Wenson Hsieh  <wenson_hsieh@apple.com>
870
871         [iOS] Occasional crash under -[UIPreviewTarget initWithContainer:center:transform:] when generating a drag preview
872         https://bugs.webkit.org/show_bug.cgi?id=199192
873         <rdar://problem/51554509>
874
875         Reviewed by Tim Horton.
876
877         Tweak the drag and drop simulator to ask for drag cancellation previews, and use this to write a couple tests to
878         verify that we gracefully handle web process termination and web view unparenting mid-drag.
879
880         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
881         (TestWebKitAPI::TEST):
882         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
883         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
884         (-[DragAndDropSimulator _resetSimulatedState]):
885         (-[DragAndDropSimulator _concludeDropAndPerformOperationIfNecessary]):
886         (-[DragAndDropSimulator _advanceProgress]):
887         (-[DragAndDropSimulator liftPreviews]):
888         (-[DragAndDropSimulator cancellationPreviews]):
889         (-[DragAndDropSimulator setSessionWillBeginBlock:]):
890         (-[DragAndDropSimulator sessionWillBeginBlock]):
891         (-[DragAndDropSimulator _webView:dataInteraction:sessionWillBegin:]):
892
893 2019-06-25  Aakash Jain  <aakash_jain@apple.com>
894
895         [ews-build] UploadTestResults and ExtractTestResults clobber results in case of multiple layout test runs in a build
896         https://bugs.webkit.org/show_bug.cgi?id=199178
897
898         Reviewed by Jonathan Bedard.
899
900         * BuildSlaveSupport/ews-build/steps.py:
901         (UploadTestResults.__init__): Add an optional identifier and append the identifier to the file name.
902         (ExtractTestResults.__init__): Ditto.
903         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit tests.
904
905 2019-06-25  Michael Catanzaro  <mcatanzaro@igalia.com>
906
907         Add user agent quirk for bankofamerica.com
908         https://bugs.webkit.org/show_bug.cgi?id=199154
909
910         Reviewed by Carlos Garcia Campos.
911
912         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
913         (TestWebKitAPI::TEST):
914
915 2019-06-25  Michael Catanzaro  <mcatanzaro@igalia.com>
916
917         Fully rename WebKitGTK+ -> WebKitGTK everywhere
918         https://bugs.webkit.org/show_bug.cgi?id=199159
919
920         Reviewed by Carlos Garcia Campos.
921
922         * BuildSlaveSupport/gtk/README:
923         * MiniBrowser/gtk/BrowserWindow.c:
924         * MiniBrowser/gtk/main.c:
925         (aboutURISchemeRequestCallback):
926         * Scripts/webkitpy/common/config/contributionareas.py:
927         * Scripts/webkitpy/common/config/contributors.json:
928         * Scripts/webkitpy/tool/commands/analyzechangelog_unittest.py:
929         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
930         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
931         (testWebViewResources):
932         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
933         (testWebViewMouseTarget):
934         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
935         (testWebExtensionGetTitle):
936         (testDocumentLoadedSignal):
937         (testWebExtensionFormControlsAssociated):
938         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
939         (testWebKitSettingsUserAgent):
940         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
941         (testWebViewRunJavaScript):
942         * TestWebKitAPI/Tests/WebKitGtk/InspectorTestServer.cpp:
943         (main):
944         * TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp:
945         (prepareContextMenuTestView):
946         (testContextMenuPopulateMenu):
947         (testContextMenuCustomMenu):
948         (testContextMenuDisableMenu):
949         (testContextMenuSubMenu):
950         (testContextMenuDismissed):
951         (testContextMenuWebExtensionMenu):
952         (testContextMenuWebExtensionNode):
953         * TestWebKitAPI/Tests/WebKitGtk/TestInspector.cpp:
954         (testInspectorDefault):
955         (testInspectorManualAttachDetach):
956         (testInspectorCustomContainerDestroyed):
957         * TestWebKitAPI/Tests/WebKitGtk/TestPrinting.cpp:
958         (testWebViewPrint):
959         (testPrintOperationPrint):
960         (testPrintOperationErrors):
961         * gtk/install-dependencies:
962         * gtk/jhbuild.modules:
963         * gtkdoc/generate-gtkdoc:
964         * wpe/install-dependencies:
965
966 2019-06-24  Michael Catanzaro  <mcatanzaro@igalia.com>
967
968         contributors.json not canonicalized since r243297
969         https://bugs.webkit.org/show_bug.cgi?id=199161
970
971         Reviewed by Alexey Proskuryakov.
972
973         Canonicalize it using 'validate-committer-lists --canonicalize'
974
975         * Scripts/webkitpy/common/config/contributors.json:
976
977 2019-06-24  Jonathan Bedard  <jbedard@apple.com>
978
979         webkitpy: Build style should be lower-case
980         https://bugs.webkit.org/show_bug.cgi?id=199158
981
982         Reviewed by Aakash Jain.
983
984         * Scripts/webkitpy/test/main.py:
985         (Tester._run_tests): Make all styles lower-case.
986
987 2019-06-24  Aakash Jain  <aakash_jain@apple.com>
988
989         [ews-build] Remove iOS queue from old EWS and dashboard
990         https://bugs.webkit.org/show_bug.cgi?id=199150
991
992         Reviewed by Jonathan Bedard.
993
994         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
995         * QueueStatusServer/config/queues.py:
996
997 2019-06-21  Ryan Haddad  <ryanhaddad@apple.com>
998
999         API Test [Mojave+ WK2 Debug ] TestWebKitAPI.WKAttachmentTestsMac.InsertDroppedFilePromisesAsAttachments is a flaky crash
1000         https://bugs.webkit.org/show_bug.cgi?id=198795
1001
1002         Unreviewed test gardening.
1003
1004         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1005         (TestWebKitAPI::TEST): Disable flaky test.
1006
1007 2019-06-24  Aakash Jain  <aakash_jain@apple.com>
1008
1009         [ews-build] Enable iOS-12-Build queue on new EWS
1010         https://bugs.webkit.org/show_bug.cgi?id=199149
1011
1012         Reviewed by Jonathan Bedard.
1013
1014         * BuildSlaveSupport/ews-build/config.json: Enable iOS-12-Build-EWS trigger. Also temporarily share ews152 and ews154 with
1015         this queue.
1016         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1017         (StatusBubble): Enable ios status-bubble. Also display the ios bubble first (left). Going forward
1018         will keep the builders to the left and testers to the right.
1019
1020 2019-06-24  Aakash Jain  <aakash_jain@apple.com>
1021
1022         [ews-build] Upload test results after running layout-tests
1023         https://bugs.webkit.org/show_bug.cgi?id=199120
1024
1025         Reviewed by Jonathan Bedard.
1026
1027         * BuildSlaveSupport/ews-build/steps.py:
1028         (RunWebKitTests.evaluateCommand):
1029         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
1030
1031 2019-06-24  Aakash Jain  <aakash_jain@apple.com>
1032
1033         [ews-build] EWS should provide option to download layout test results zip file
1034         https://bugs.webkit.org/show_bug.cgi?id=199121
1035
1036         Reviewed by Jonathan Bedard.
1037
1038         * BuildSlaveSupport/ews-build/steps.py:
1039         (ExtractTestResults.resultsDownloadURL): Method to return layout test result zip file url. 
1040         (ExtractTestResults.addCustomURLs): Add url to download layout test results zip file.
1041
1042 2019-06-24  Michael Catanzaro  <mcatanzaro@igalia.com>
1043
1044         Add user agent quirk for Google Drive
1045         https://bugs.webkit.org/show_bug.cgi?id=199153
1046
1047         Reviewed by Carlos Garcia Campos.
1048
1049         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1050         (TestWebKitAPI::TEST):
1051
1052 2019-06-22  Zalan Bujtas  <zalan@apple.com>
1053
1054         [LFC] Expand tests coverage (328 new tests -> 2652).
1055
1056         * LayoutReloaded/misc/LFC-passing-tests.txt:
1057
1058 2019-06-22  Andres Gonzalez  <andresg_22@apple.com>
1059
1060         Accessibility objects contained in links should honor the aria-haspopup attribute in the ancestor link.
1061         https://bugs.webkit.org/show_bug.cgi?id=199107
1062         <rdar://problem/43663611>
1063
1064         Reviewed by Chris Fleizach.
1065
1066         iOS implementation for AccessibilityUIElement::hasPopup.
1067         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1068         (WTR::AccessibilityUIElement::hasPopup const):
1069
1070 2019-06-22  Konstantin Tokarev  <annulen@yandex.ru>
1071
1072         Unreviewed, add myself to CMake watchlist
1073
1074         * Scripts/webkitpy/common/config/watchlist:
1075
1076 2019-06-21  Sihui Liu  <sihui_liu@apple.com>
1077
1078         openDatabase should return an empty object when WebSQL is disabled
1079         https://bugs.webkit.org/show_bug.cgi?id=198805
1080
1081         Reviewed by Geoffrey Garen.
1082
1083         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1084         * TestWebKitAPI/Tests/WebKitCocoa/WebSQLBasics.mm: Added.
1085         (-[WebSQLBasicsMessageHandler userContentController:didReceiveScriptMessage:]):
1086         (TEST):
1087         * TestWebKitAPI/Tests/WebKitCocoa/opendatabase-always-exists.html: Added.
1088
1089 2019-06-21  Jiewen Tan  <jiewen_tan@apple.com>
1090
1091         WebPageProxy::loadData should accept ShouldOpenExternalURLsPolicy
1092         https://bugs.webkit.org/show_bug.cgi?id=199114
1093         <rdar://problem/51671674>
1094
1095         Reviewed by Youenn Fablet.
1096
1097         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
1098         (-[TestSOAuthorizationNavigationDelegate init]):
1099         (-[TestSOAuthorizationNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1100         (configureSOAuthorizationWebView):
1101         (TestWebKitAPI::TEST):
1102
1103 2019-06-21  Youenn Fablet  <youenn@apple.com>
1104
1105         WebPageProxy should use the right path for sandbox extension
1106         https://bugs.webkit.org/show_bug.cgi?id=198902
1107         <rdar://problem/50772810>
1108
1109         Reviewed by Geoffrey Garen.
1110
1111         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm:
1112         (TEST):
1113         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1114
1115 2019-06-21  Michael Catanzaro  <mcatanzaro@igalia.com>
1116
1117         [WPE][GTK] Bump minimum versions of GLib, GTK, libsoup, ATK, GStreamer, and Cairo
1118         https://bugs.webkit.org/show_bug.cgi?id=199094
1119
1120         Reviewed by Carlos Garcia Campos.
1121
1122         * MiniBrowser/gtk/BrowserTab.c:
1123         (runColorChooserCallback):
1124         (browserTabConstructed):
1125         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
1126         (testWebViewSyncRequestOnMaxConns):
1127         (beforeAll):
1128         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
1129         (testWebSocketTLSErrors):
1130         (beforeAll):
1131         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.cpp:
1132         (WebKitTestServer::~WebKitTestServer):
1133         (WebKitTestServer::getWebSocketURIForPath const):
1134         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1135         (WTR::AccessibilityUIElement::rowHeaders const):
1136         (WTR::AccessibilityUIElement::columnHeaders const):
1137         (WTR::AccessibilityUIElement::isAttributeSettable):
1138         (WTR::AccessibilityUIElement::x):
1139         (WTR::AccessibilityUIElement::y):
1140         (WTR::AccessibilityUIElement::width):
1141         (WTR::AccessibilityUIElement::height):
1142         (WTR::AccessibilityUIElement::clickPointX):
1143         (WTR::AccessibilityUIElement::clickPointY):
1144         (WTR::AccessibilityUIElement::intValue const):
1145         (WTR::AccessibilityUIElement::minValue):
1146         (WTR::AccessibilityUIElement::maxValue):
1147         (WTR::stringAtOffset):
1148
1149 2019-06-20  Dean Johnson  <dean_johnson@apple.com>
1150
1151         test-webkitpy is broken on macOS Catalina
1152         https://bugs.webkit.org/show_bug.cgi?id=199078
1153
1154         Reviewed by Jonathan Bedard.
1155
1156         * Scripts/webkitpy/test/main.py: Check if lldb tests are supported before adding them
1157         to the runner.
1158         (main): 
1159         (_supports_building_and_running_lldb_tests): Check if you are running macOS Catalina.
1160
1161 2019-06-20  Dean Johnson  <dean_johnson@apple.com>
1162
1163         Change status to "committer" in contributors.json
1164
1165         Unreviewed.
1166
1167         * Scripts/webkitpy/common/config/contributors.json:
1168
1169 2019-06-20  Alex Christensen  <achristensen@webkit.org>
1170
1171         Add unit test for UIContextMenuConfiguration API
1172         https://bugs.webkit.org/show_bug.cgi?id=199043
1173
1174         Reviewed by Wenson Hsieh.
1175
1176         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1177         * TestWebKitAPI/Tests/WebKitCocoa/ContextMenus.mm: Added.
1178         (-[TestContextMenuUIDelegate webView:contextMenuConfigurationForElement:completionHandler:]):
1179         (-[TestContextMenuUIDelegate webView:contextMenuWillPresentForElement:]):
1180         (-[TestContextMenuUIDelegate webView:contextMenuForElement:willCommitWithAnimator:]):
1181         (-[TestContextMenuUIDelegate webView:contextMenuDidEndForElement:]):
1182         (TEST):
1183         * TestWebKitAPI/cocoa/TestContextMenuDriver.h: Added.
1184         * TestWebKitAPI/cocoa/TestContextMenuDriver.mm: Added.
1185         (-[TestContextMenuDriver delegate]):
1186         (-[TestContextMenuDriver setDelegate:]):
1187         (-[TestContextMenuDriver view]):
1188         (-[TestContextMenuDriver setView:]):
1189         (-[TestContextMenuDriver allowableMovement]):
1190         (-[TestContextMenuDriver setAllowableMovement:]):
1191         (-[TestContextMenuDriver primaryGestureRecognizer]):
1192         (-[TestContextMenuDriver setPrimaryGestureRecognizer:]):
1193         (-[TestContextMenuDriver touchDuration]):
1194         (-[TestContextMenuDriver setTouchDuration:]):
1195         (-[TestContextMenuDriver locationInCoordinateSpace:]):
1196         (-[TestContextMenuDriver cancelInteraction]):
1197         (-[TestContextMenuDriver begin:]):
1198         (-[TestContextMenuDriver clickDown]):
1199         (-[TestContextMenuDriver clickUp]):
1200         (-[TestContextMenuDriver end]):
1201         * TestWebKitAPI/ios/UIKitSPI.h:
1202
1203 2019-06-20  Aakash Jain  <aakash_jain@apple.com>
1204
1205         [ews-app] Status bubble should not turn orange when any build step is skipped
1206         https://bugs.webkit.org/show_bug.cgi?id=199079
1207
1208         Reviewed by Jonathan Bedard.
1209
1210         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1211
1212 2019-06-20  Alex Christensen  <achristensen@webkit.org>
1213
1214         Fix an internal engineering build after r246605
1215        ​https://bugs.webkit.org/show_bug.cgi?id=197800
1216
1217         * TestWebKitAPI/TCPServer.cpp:
1218
1219 2019-06-20  Aakash Jain  <aakash_jain@apple.com>
1220
1221         [ews-build] Triggered builds should use same revision as parent build
1222         https://bugs.webkit.org/show_bug.cgi?id=198289
1223
1224         Reviewed by Jonathan Bedard.
1225
1226         * BuildSlaveSupport/ews-build/steps.py:
1227         (CheckOutSpecificRevision): Build step to checkout specific revision.
1228         (CheckOutSpecificRevision.doStepIf): Run this step only if ews_revision property is set.
1229         (CheckOutSpecificRevision.hideStepIf): Hide this step when it is skipped.
1230         (CheckOutSpecificRevision.start): Run appropriate git command.
1231         (Trigger.propertiesToPassToTriggers): Pass ews_revision property to triggered builds, so that triggered
1232         builds use same revision as parent build.
1233         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
1234         * BuildSlaveSupport/ews-build/factories.py:
1235         (Factory.__init__): Added CheckOutSpecificRevision step.
1236
1237 2019-06-20  Aakash Jain  <aakash_jain@apple.com>
1238
1239         [ews-build] Add unit tests for AnalyzeCompileWebKitResults
1240         https://bugs.webkit.org/show_bug.cgi?id=199073
1241
1242         Reviewed by Jonathan Bedard.
1243
1244         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests for AnalyzeCompileWebKitResults.
1245
1246 2019-06-20  Alexander Mikhaylenko  <exalm7659@gmail.com>
1247
1248         [GTK] Enable navigation swipe layout tests
1249         https://bugs.webkit.org/show_bug.cgi?id=198995
1250
1251         Reviewed by Michael Catanzaro.
1252
1253         Add a way for tests to enable and then control swipe gesture on GTK.
1254
1255         * TestRunnerShared/UIScriptContext/UIScriptController.cpp: Hide
1256         empty implementations of beginBackSwipe() and completeBackSwipe() for GTK.
1257         * WebKitTestRunner/PlatformGTK.cmake:
1258         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1259         (WTR::PlatformWebView::setNavigationGesturesEnabled): Implemented.
1260         * WebKitTestRunner/gtk/UIScriptControllerGtk.cpp: Added.
1261         (WTR::UIScriptController::beginBackSwipe):
1262         (WTR::UIScriptController::completeBackSwipe):
1263
1264 2019-06-20  Alexander Mikhaylenko  <exalm7659@gmail.com>
1265
1266         [GTK] HTTP layout tests don't run in flatpak
1267         https://bugs.webkit.org/show_bug.cgi?id=199067
1268
1269         Reviewed by Michael Catanzaro.
1270
1271         Stop bind mounting /app/lib/perl to /etc/perl because Perl doesn't actually
1272         check that path. Instead, add /app/lib/perl to Apache config directly.
1273
1274         /usr/manifest.json file is not guaranteed to exist in sandbox, check for
1275         /.flatpak-info instead.
1276
1277         * Scripts/webkitpy/port/base.py:
1278         (Port._is_flatpak):
1279         (Port._in_flatpak_sandbox):
1280         * flatpak/flatpakutils.py:
1281         (WebkitFlatpak.run_in_sandbox):
1282         (is_sandboxed):
1283
1284 2019-06-18  Darin Adler  <darin@apple.com>
1285
1286         Tidy up the remaining bits of the AtomicString to AtomString rename
1287         https://bugs.webkit.org/show_bug.cgi?id=198990
1288
1289         Reviewed by Michael Catanzaro.
1290
1291         * Scripts/do-webcore-rename: Removed already-done renames.
1292         * TestWebKitAPI/Tests/WTF/StringImpl.cpp: Rename one use of "atomic".
1293
1294 2019-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
1295
1296         [GTK] Remove support for GTK2 plugins
1297         https://bugs.webkit.org/show_bug.cgi?id=199065
1298
1299         Reviewed by Sergio Villar Senin.
1300
1301         * EWSTools/ubuntu-ews-packages:
1302         * TestWebKitAPI/PlatformGTK.cmake:
1303         * WebKitTestRunner/PlatformGTK.cmake:
1304         * flatpak/org.webkit.GTK.yaml:
1305         * gtk/install-dependencies:
1306
1307 2019-06-19  Yusuke Suzuki  <ysuzuki@apple.com>
1308
1309         [bmalloc] IsoHeap's initialization is racy with IsoHeap::isInitialized
1310         https://bugs.webkit.org/show_bug.cgi?id=199053
1311
1312         Reviewed by Saam Barati.
1313
1314         Added a test stressing IsoHeap with multiple threads.
1315
1316         * TestWebKitAPI/Tests/WTF/bmalloc/IsoHeap.cpp:
1317         (assertHasObjects):
1318         (assertHasOnlyObjects):
1319         (assertClean):
1320         (TEST):
1321
1322 2019-06-19  Zalan Bujtas  <zalan@apple.com>
1323
1324         [LFC] Expand tests coverage (1126 new tests -> 2324).
1325
1326         * LayoutReloaded/misc/LFC-passing-tests.txt:
1327
1328 2019-06-19  Fujii Hironori  <Hironori.Fujii@sony.com>
1329
1330         Add WTF::crossThreadCopy(T&&) to utilize String::isolatedCopy() &&
1331         https://bugs.webkit.org/show_bug.cgi?id=198957
1332
1333         Reviewed by Alex Christensen.
1334
1335         * TestWebKitAPI/CMakeLists.txt:
1336         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1337         * TestWebKitAPI/Tests/WTF/CrossThreadCopier.cpp: Added.
1338
1339 2019-06-19  Keith Rollin  <krollin@apple.com>
1340
1341         Relocate some test tools in non-mac builds
1342         https://bugs.webkit.org/show_bug.cgi?id=198984
1343         <rdar://problem/51873261>
1344
1345         Reviewed by Andy Estes.
1346
1347         The tools DumpRenderTree, WebKitTestRunner, LayoutTestHelper, and
1348         TestNetscapePlugin get created in
1349         WebKit.framework/Versions/A/Resources on non-mac builds. This is
1350         incorrect, as those bundles are shallow bundles that don't use the
1351         Versions hierarchy. Instead, store these files directly in
1352         WebKit.framework.
1353
1354         Note that getting rid of just the "Versions/A" path components and
1355         putting the files in WebKit.framework/Resources doesn't work as
1356         `codesign` treats the result as an invalid layout.
1357
1358         The work in this patch involves changing the definition of the custom
1359         build variable WEBKIT_FRAMEWORK_RESOURCES_PATH. The standard build
1360         variable INSTALL_PATH is defined in terms of this variable. In order
1361         to increase visiblity into this relationship, move both of these
1362         variables into .xcconfig files if they weren't already. This
1363         refactoring was done in a way to be the least disruptive and most
1364         compatible with the previous definitions, even at the cost of being
1365         repetitive.
1366
1367         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1368         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1369         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
1370         * DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig:
1371         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig:
1372         * WebKitTestRunner/Configurations/BaseTarget.xcconfig:
1373
1374 2019-06-19  Aakash Jain  <aakash_jain@apple.com>
1375
1376         [ews-build] Patch link should open the pretty patch
1377         https://bugs.webkit.org/show_bug.cgi?id=199031
1378
1379         Reviewed by Jonathan Bedard.
1380
1381         * BuildSlaveSupport/ews-build/steps.py:
1382         (ConfigureBuild.getPatchURL): Use the prettypatch url for patch.
1383
1384 2019-06-19  Aakash Jain  <aakash_jain@apple.com>
1385
1386         [ews-build] Add step to analyze Compile WebKit failures
1387         https://bugs.webkit.org/show_bug.cgi?id=199025
1388
1389         Reviewed by Jonathan Bedard.
1390
1391         * BuildSlaveSupport/ews-build/steps.py:
1392         (CompileWebKit.evaluateCommand): Add AnalyzeCompileWebKitResults step.
1393         (CompileWebKitToT): set haltOnFailure to False since we need to run AnalyzeCompileWebKitResults step.
1394         (AnalyzeCompileWebKitResults): Class to analyze compile webkit steps results.
1395         (AnalyzeCompileWebKitResults.start): If ToT fails to build, retry the build, else marked the build as failed. Note that
1396         this step is run only when compile-webkit failed.
1397
1398 2019-06-19  Aakash Jain  <aakash_jain@apple.com>
1399
1400         [ews-build] Send email notifications for failures
1401         https://bugs.webkit.org/show_bug.cgi?id=198919
1402
1403         Reviewed by Jonathan Bedard.
1404
1405         * BuildSlaveSupport/ews-build/master.cfg:
1406
1407 2019-06-19  Alex Christensen  <achristensen@webkit.org>
1408
1409         Add a unit test for client certificate authentication
1410         https://bugs.webkit.org/show_bug.cgi?id=197800
1411
1412         Reviewed by Youenn Fablet.
1413
1414         Make better abstractions for reading and writing from/to TCPServer.
1415         Add a unit test that causes a client certificate authentication challenge to happen.
1416
1417         * TestWebKitAPI/TCPServer.cpp:
1418         (TestWebKitAPI::TCPServer::TCPServer):
1419         (TestWebKitAPI::TCPServer::read):
1420         (TestWebKitAPI::TCPServer::write):
1421         (TestWebKitAPI::TCPServer::respondWithChallengeThenOK):
1422         (TestWebKitAPI::TCPServer::respondWithOK):
1423         * TestWebKitAPI/TCPServer.h:
1424         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
1425         (credentialWithIdentity):
1426         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1427         (TEST):
1428         (-[ClientCertificateDelegate webView:didFinishNavigation:]):
1429         (-[ClientCertificateDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1430         (-[ClientCertificateDelegate challengeCount]):
1431         (TestWebKitAPI::TEST):
1432         (respondWithChallengeThenOK): Deleted.
1433         (credentialWithIdentityAndKeychainPath): Deleted.
1434         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
1435         (TEST):
1436         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:
1437         (TestWebKitAPI::TEST):
1438         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
1439         (TEST):
1440         (readRequest): Deleted.
1441         (writeResponse): Deleted.
1442         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
1443         (TestWebKitAPI::TEST):
1444         (TestWebKitAPI::respondWithChallengeThenOK): Deleted.
1445
1446 2019-06-19  Michael Catanzaro  <mcatanzaro@igalia.com>
1447
1448         Unreviewed, fix build warnings in TestWebKitAPIInjectedBundle
1449
1450         System headers are being included without SYSTEM again here.
1451
1452         * TestWebKitAPI/PlatformGTK.cmake:
1453
1454 2019-06-18  Yusuke Suzuki  <ysuzuki@apple.com>
1455
1456         [JSC] JSLock should be WebThread aware
1457         https://bugs.webkit.org/show_bug.cgi?id=198911
1458
1459         Reviewed by Geoffrey Garen.
1460
1461         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1462         * TestWebKitAPI/Tests/WebKitLegacy/ios/JSLockTakesWebThreadLock.mm: Added.
1463         (TestWebKitAPI::TEST):
1464
1465 2019-06-18  Keith Miller  <keith_miller@apple.com>
1466
1467         webkit-patch should allow for a bugzilla url not just bugzilla id
1468         https://bugs.webkit.org/show_bug.cgi?id=198972
1469
1470         Reviewed by Dewei Zhu.
1471
1472         When prompting for a bugzilla id or a new title we should also
1473         allow for a bugzilla url.
1474
1475         * Scripts/webkitpy/tool/steps/promptforbugortitle.py:
1476         (PromptForBugOrTitle.run):
1477
1478 2019-06-18  David Quesada  <david_quesada@apple.com>
1479
1480         REGRESSION: _WKDownload.OriginatingWebView and _WKDownload.CrashAfterDownloadDidFinishWhenDownloadProxyHoldsTheLastRefOnWebProcessPool failing
1481         https://bugs.webkit.org/show_bug.cgi?id=198954
1482         rdar://problem/51711556
1483
1484         Reviewed by Alex Christensen.
1485
1486         For these tests, kill the web process after the download starts. This makes the deallocation
1487         of the download-originating web views, which these tests depend on, more reliable.
1488
1489         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1490         (-[OriginatingWebViewDownloadDelegate _downloadDidStart:]):
1491         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
1492
1493 2019-06-18  Dan Bernstein  <mitz@apple.com>
1494
1495         Revert workaround for bug 198904 from run-webkit-archive
1496         https://bugs.webkit.org/show_bug.cgi?id=198931
1497
1498         Reviewed by Alexey Proskuryakov.
1499
1500         Reverted r245965, now that the load commands in the XPC service binaries make them correctly
1501         pick up the built frameworks.
1502
1503         * WebKitArchiveSupport/run-webkit-archive:
1504         (set_dyld_framework_path):
1505
1506 2019-06-17  Sihui Liu  <sihui_liu@apple.com>
1507
1508         -[WKWebsiteDataStore removeDataOfTypes:modifiedSince:completionHandler:] doesn't delete _WKWebsiteDataTypeCredentials
1509         https://bugs.webkit.org/show_bug.cgi?id=198854
1510         <rdar://problem/51386058>
1511
1512         Reviewed by Geoffrey Garen.
1513
1514         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
1515         (TestWebKitAPI::TEST):
1516
1517 2019-06-17  Adrian Perez de Castro  <aperez@igalia.com>
1518
1519         [Flatpak][JHBuild] Update build environments to use WPEBackend-fdo 1.3.1
1520         https://bugs.webkit.org/show_bug.cgi?id=198831
1521
1522         Reviewed by Žan Doberšek.
1523
1524         * flatpak/org.webkit.WPEModules.yaml: Bump versions of libwpe and WPEBackend-fdo to 1.3.1
1525         * wpe/jhbuild.modules: Ditto.
1526         * wpe/patches/wpebackend-fdo-Handle-the-case-of-new-target-created-for-the-same-v.patch: Removed.
1527         * wpe/wpebackend-fdo-view-backend-exportable-private-don-t-double-free-ca.patch: Removed.
1528
1529 2019-06-17  Jiewen Tan  <jiewen_tan@apple.com>
1530
1531         Move SOAuthorization from WebKitAdditions to WebKit
1532         https://bugs.webkit.org/show_bug.cgi?id=198874
1533         <rdar://problem/47573431>
1534
1535         Reviewed by Brent Fulgham.
1536
1537         This patch moves all SOAuthorization tests from WebKitAdditions to WebKit.
1538
1539         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
1540         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1541         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm: Added.
1542         (-[TestSOAuthorizationNavigationDelegate init]):
1543         (-[TestSOAuthorizationNavigationDelegate webView:didFinishNavigation:]):
1544         (-[TestSOAuthorizationNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1545         (-[TestSOAuthorizationNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
1546         (-[TestSOAuthorizationViewController viewDidAppear]):
1547         (-[TestSOAuthorizationViewController viewDidDisappear]):
1548         (overrideCanPerformAuthorizationWithURL):
1549         (overrideSetDelegate):
1550         (overrideBeginAuthorizationWithURL):
1551         (overrideCancelAuthorization):
1552         (overrideAddObserverForName):
1553         (overrideIsURLFromAppleOwnedDomain):
1554         (resetState):
1555         (configureSOAuthorizationWebView):
1556         (generateHtml):
1557         (checkAuthorizationOptions):
1558         (TestWebKitAPI::TEST):
1559
1560 2019-06-17  Brent Fulgham  <bfulgham@apple.com>
1561
1562         Ensure ITP state is relayed to Network Process on restart
1563         https://bugs.webkit.org/show_bug.cgi?id=198797
1564         <rdar://problem/51646944>
1565
1566         Reviewed by Youenn Fablet.
1567
1568         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
1569         (cleanupITPDatabase): Added.
1570         (TEST:EnableDisableITP): Update to use cleanup method.
1571         (TEST:NetworkProcessRestart): Added.
1572
1573 2019-06-17  Aakash Jain  <aakash_jain@apple.com>
1574
1575         New EWS can't process patches larger than 640kb
1576         https://bugs.webkit.org/show_bug.cgi?id=198851
1577
1578         Reviewed by Jonathan Bedard.
1579
1580         * BuildSlaveSupport/ews-build/master.cfg: Increase the patch size limit to 100 MB.
1581
1582 2019-06-17  Jonathan Bedard  <jbedard@apple.com>
1583
1584         webkitpy: Add macOS Catalina, iOS 13
1585         https://bugs.webkit.org/show_bug.cgi?id=198492
1586
1587         Reviewed by Alexey Proskuryakov.
1588
1589         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Catalina.png: Added.
1590         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Catalina@2x.png: Added.
1591         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS13.png: Added.
1592         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS13@2x.png: Added.
1593         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS13Simulator.png: Added.
1594         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS13Simulator@2x.png: Added.
1595         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1596         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1597         * BuildSlaveSupport/ews-build/steps.py:
1598         * Scripts/webkitpy/common/version_name_map.py:
1599         * Scripts/webkitpy/common/version_name_map_unittest.py:
1600         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1601         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1602
1603 2019-06-17  Carlos Garcia Campos  <cgarcia@igalia.com>
1604
1605         Unreviewed. [GTK] Bump WPEBackend-fdo requirement to 1.3.1
1606
1607         * gtk/jhbuild.modules:
1608         * gtk/patches/wpebackend-fdo-Handle-the-case-of-new-target-created-for-the-same-v.patch: Removed.
1609         * gtk/wpebackend-fdo-view-backend-exportable-private-don-t-double-free-ca.patch: Removed.
1610
1611 2019-06-16  Zalan Bujtas  <zalan@apple.com>
1612
1613         [LFC] Expand tests coverage (325 new tests -> 1198).
1614
1615         * LayoutReloaded/misc/LFC-passing-tests.txt:
1616
1617 2019-06-16  Darin Adler  <darin@apple.com>
1618
1619         Rename AtomicString to AtomString
1620         https://bugs.webkit.org/show_bug.cgi?id=195276
1621
1622         Reviewed by Michael Catanzaro.
1623
1624         * many files: Let do-webcore-rename do the renaming.
1625
1626         * Scripts/do-webcore-rename: Updated with a list of all the identifiers
1627         that mention "atomic string" and changed them to instead say "atom string".
1628
1629 2019-06-16  Zalan Bujtas  <zalan@apple.com>
1630
1631         [LFC] Unreviewed test gardening.
1632
1633         Unsupported alignments.
1634
1635         fast/inline/absolute-positioned-inline-in-centred-block.html -align: center
1636         fast/borders/empty-outline-border-assert.html -vertical-align: super
1637         css2.1/20110323/vertical-align-boxes-001.htm - vertical-align: middle
1638
1639         * LayoutReloaded/misc/LFC-passing-tests.txt:
1640
1641 2019-06-15  Youenn Fablet  <youenn@apple.com>
1642
1643         WPT test importer WTR option reader should not throw if the file is not proper UTF-8
1644         https://bugs.webkit.org/show_bug.cgi?id=198780
1645
1646         Reviewed by Jonathan Bedard.
1647
1648         * Scripts/webkitpy/w3c/test_importer.py:
1649         (TestImporter._webkit_test_runner_options):
1650         In case the test file cannot be read as text, consider that there is no WTR option.
1651
1652 2019-06-14  Youenn Fablet  <youenn@apple.com>
1653
1654         WebResourceLoadStatisticsStore should not use its network session if invalidated
1655         https://bugs.webkit.org/show_bug.cgi?id=198814
1656
1657         Reviewed by Geoffrey Garen.
1658
1659         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
1660         (TEST):
1661
1662 2019-06-14  Youenn Fablet  <youenn@apple.com>
1663
1664         import-w3c-tests should respect WEBKIT_OUTPUTDIR
1665         https://bugs.webkit.org/show_bug.cgi?id=198682
1666         <rdar://problem/51536931>
1667
1668         Reviewed by Jonathan Bedard.
1669
1670         Check for WEBKIT_OUTPUTDIR environment variable to compute the w3c-tests folder.
1671         Made some refactoring to also teach WPTPaths users about WEBKIT_OUTPUTDIR.
1672
1673         * Scripts/webkitpy/common/webkit_finder.py:
1674         (WebKitFinder.path_from_webkit_outputdir):
1675         * Scripts/webkitpy/w3c/common.py:
1676         (WPTPaths):
1677         (WPTPaths.checkout_directory):
1678         (WPTPaths.wpt_checkout_path):
1679         * Scripts/webkitpy/w3c/test_importer.py:
1680         (TestImporter.__init__):
1681         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1682         (test_checkout_directory):
1683
1684 2019-06-13  Antoine Quint  <graouts@apple.com>
1685
1686         REGRESSION (r246103) [ Mojave+ WK1 ] Layout Test scrollbars/scrollbar-iframe-click-does-not-blur-content.html is timing out
1687         https://bugs.webkit.org/show_bug.cgi?id=198800
1688         <rdar://problem/51679634>
1689
1690         Reviewed by Tim Horton.
1691
1692         We didn't detect an NSScroller in a sub-frame due to WebHTMLView's implementation of -[NSView hitTest:]. We now use a private method
1693         which lets us use the default implementation and correctly returns an NSScroller in a sub-frame.
1694
1695         * DumpRenderTree/mac/EventSendingController.mm:
1696         (eventPressedMouseButtonsSwizzlerForViewAndEvent):
1697         (-[EventSendingController mouseDown:withModifiers:]):
1698         (-[EventSendingController mouseUp:withModifiers:]):
1699         (-[EventSendingController mouseMoveToX:Y:]):
1700
1701 2019-06-13  Fujii Hironori  <Hironori.Fujii@sony.com>
1702
1703         [WinCairo][WebKitTestRunner] pixel image dump outputs blank images
1704         https://bugs.webkit.org/show_bug.cgi?id=198820
1705
1706         Reviewed by Ross Kirsling.
1707
1708         WebView window paints nothing because it is moved out of the
1709         screen. Send WM_PRINT with memory DC instead of WM_PAINT as well
1710         as DumpRenderTree does.
1711
1712         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1713         (WTR::PlatformWebView::windowSnapshotImage): Send WM_PRINT instead of BitBlt.
1714
1715 2019-06-13  Tim Horton  <timothy_horton@apple.com>
1716
1717         Make it possible for validate-committer-lists to dump a mailmap file
1718         https://bugs.webkit.org/show_bug.cgi?id=198517
1719
1720         Reviewed by Simon Fraser.
1721
1722         Mailmaps wildly improve the output of various Git tools, including
1723         `git shortlog -sne`, mapping committers to our canonical name/email pair.
1724
1725         * Scripts/validate-committer-lists:
1726         (CommitterListFromGit):
1727         (CommitterListBugzillaChecker.print_committers_with_invalid_bugzilla_emails):
1728         Add some missing legacy username mappings.
1729
1730         (dump_mailmap):
1731         (dump_mailmap.format_email):
1732         (dump_mailmap.format_email_with_gitsvn_uuid):
1733         (dump_mailmap.map_emails_to_legacy_username):
1734         (main):
1735         Add `validate-committer-lists --dump-mailmap`, which generates
1736         one given committers.json and the existing mapping of legacy username
1737         to email addresses that exists in validate-committer-lists.
1738
1739 2019-06-12  Aakash Jain  <aakash_jain@apple.com>
1740
1741         Replace double-quotes with single quotes in loadConfig.py
1742         https://bugs.webkit.org/show_bug.cgi?id=198792
1743
1744         Reviewed by Jonathan Bedard.
1745
1746         * BuildSlaveSupport/ews-build/loadConfig.py:
1747         * BuildSlaveSupport/ews-build/steps_unittest.py:
1748
1749 22019-06-11  Brent Fulgham  <bfulgham@apple.com>
1750
1751         Add mechanism and test case to check if ITP is active
1752         https://bugs.webkit.org/show_bug.cgi?id=198694
1753         <rdar://problem/51557704>
1754
1755         Reviewed by Youenn Fablet.
1756
1757         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
1758         (TEST):
1759
1760 2019-06-12  Michael Catanzaro  <mcatanzaro@igalia.com>
1761
1762         [WPE][GTK] Deprecate WebSQL APIs
1763         https://bugs.webkit.org/show_bug.cgi?id=195011
1764
1765         Reviewed by Carlos Garcia Campos.
1766
1767         * MiniBrowser/gtk/main.c:
1768         (gotWebsiteDataCallback):
1769         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
1770         (testWebsiteDataConfiguration):
1771         (testWebsiteDataEphemeral):
1772         (testWebsiteDataDatabases):
1773
1774 2019-06-12  Michael Catanzaro  <mcatanzaro@igalia.com>
1775
1776         [WPE][GTK] Enable hyperlink auditing
1777         https://bugs.webkit.org/show_bug.cgi?id=197845
1778
1779         Reviewed by Carlos Garcia Campos.
1780
1781         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
1782         (testWebKitSettings):
1783
1784 2019-06-11  Keith Rollin  <krollin@apple.com>
1785
1786         Open up xcfilelist processing to more platforms
1787         https://bugs.webkit.org/show_bug.cgi?id=198675
1788         <rdar://problem/51533238>
1789
1790         Reviewed by Jonathan Bedard.
1791
1792         Now that it's been tested, add AppleTV{OS,Simulator} to the set of
1793         platforms on which to perform xcfilelist generation/updating.
1794
1795         * Scripts/webkitpy/generate_xcfilelists_lib/generators.py:
1796         (JavaScriptCoreGenerator):
1797         (WebCoreGenerator):
1798         (WebKitGenerator):
1799
1800 2019-06-11  Jonathan Bedard  <jbedard@apple.com>
1801
1802         webkitpy: Fix device ASan reporting, add testing for report configurations
1803         https://bugs.webkit.org/show_bug.cgi?id=198756
1804
1805         Reviewed by Aakash Jain.
1806
1807         ASan results were reporting an incorrect style. This indicates we need to be testing this upload
1808         configuration thoroughly in webkitpy.
1809
1810         * Scripts/webkitpy/port/config.py:
1811         (clear_cached_configuration): Clearing configurations should clear the ASan cache as well.
1812         * Scripts/webkitpy/port/device_port.py:
1813         (DevicePort.configuration_for_upload): Add ASan as style.
1814         * Scripts/webkitpy/port/ios_device_unittest.py:
1815         (IOSDeviceTest):
1816         (IOSDeviceTest.test_default_upload_configuration):
1817         * Scripts/webkitpy/port/ios_simulator_unittest.py:
1818         (IOSSimulatorTest.test_default_upload_configuration):
1819         * Scripts/webkitpy/port/mock_drt_unittest.py:
1820         (MockDRTPortTest.test_asan_upload_configuration):
1821         * Scripts/webkitpy/port/port_testcase.py:
1822         (test_default_upload_configuration):
1823         (test_debug_upload_configuration):
1824         (test_asan_upload_configuration):
1825         (test_guard_malloc_configuration):
1826         * Scripts/webkitpy/port/watch_simulator_unittest.py:
1827         (WatchSimulatorTest):
1828         (WatchSimulatorTest.test_default_upload_configuration):
1829
1830 2019-06-11  Michael Catanzaro  <mcatanzaro@igalia.com>
1831
1832         tu-berlin university email web interface (Outlook Web App) goes directly to the light version instead of the normal web app
1833         https://bugs.webkit.org/show_bug.cgi?id=198749
1834
1835         Reviewed by Carlos Garcia Campos.
1836
1837         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1838         (TestWebKitAPI::TEST):
1839
1840 2019-06-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1841
1842         Quotes are always inserted as smart quotes on stackblitz.com, causing compilation errors
1843         https://bugs.webkit.org/show_bug.cgi?id=198735
1844         <rdar://problem/51557159>
1845
1846         Reviewed by Megan Gardner.
1847
1848         Add a test to verify that spellcheck="false" disables smart quotes and dashes, but any other value defers to the
1849         user's preferences by using UITextSmartQuotesTypeDefault and UITextSmartDashesTypeDefault.
1850
1851         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1852         (TestWebKitAPI::TEST):
1853
1854 2019-06-11  Tadeu Zagallo  <tzagallo@apple.com>
1855
1856         Unreviewed, add myself to the JavaScriptCore watchlist.
1857
1858         * Scripts/webkitpy/common/config/watchlist:
1859
1860 2019-06-11  Tadeu Zagallo  <tzagallo@apple.com>
1861
1862         Unreviewed, change my status to be a WebKit reviewer
1863
1864         * Scripts/webkitpy/common/config/contributors.json:
1865
1866 2019-06-11  Carlos Garcia Campos  <cgarcia@igalia.com>
1867
1868         [WPE] Use new exported image API from fdo backend
1869         https://bugs.webkit.org/show_bug.cgi?id=198558
1870
1871         Reviewed by Philippe Normand.
1872
1873         * WebKitTestRunner/PlatformWPE.cmake: Do not find fdo backend and libxkb again here, since WKTR depends on
1874         WPEToolingBackends that already depends on fdo backend and libxkb
1875         * wpe/backends/CMakeLists.txt: Bump fdo requirements to 1.3.0 version.
1876         * wpe/backends/HeadlessViewBackend.cpp:
1877         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend):
1878         (WPEToolingBackends::HeadlessViewBackend::createSnapshot):
1879         (WPEToolingBackends::HeadlessViewBackend::performUpdate):
1880         (WPEToolingBackends::HeadlessViewBackend::displayBuffer):
1881         * wpe/backends/HeadlessViewBackend.h:
1882         * wpe/backends/ViewBackend.cpp:
1883         (WPEToolingBackends::ViewBackend::initialize):
1884         * wpe/backends/ViewBackend.h:
1885         * wpe/backends/WindowViewBackend.cpp:
1886         (WPEToolingBackends::WindowViewBackend::displayBuffer):
1887         * wpe/backends/WindowViewBackend.h:
1888
1889 2019-06-10  Dewei Zhu  <dewei_zhu@apple.com>
1890
1891         Extend run-benchmark to allow diagnosing before closing browser on test failure.
1892         https://bugs.webkit.org/show_bug.cgi?id=198729
1893
1894         Reviewed by Ryosuke Niwa.
1895
1896         Add '--diagnose-directory' option to store diagnose information when test failed.
1897
1898         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1899         (BenchmarkRunner.__init__):
1900         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
1901         (BrowserDriver.diagnose_test_failure): Add default no-op function to base class.
1902         * Scripts/webkitpy/benchmark_runner/run_benchmark.py: Added '--diagnose-directory' option.
1903         (parse_args):
1904         (run_benchmark_plan):
1905         * Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py:
1906         (WebDriverBenchmarkRunner._run_one_test): Added 'diagnose_test_failure' invocation on test failure.
1907         * Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py:
1908         (WebServerBenchmarkRunner.__init__):
1909         (WebServerBenchmarkRunner._run_one_test): Added 'diagnose_test_failure' invocation on test failure.
1910
1911 2019-06-10  Sam Weinig  <weinig@apple.com>
1912
1913         Remove Dashboard support
1914         https://bugs.webkit.org/show_bug.cgi?id=198615
1915
1916         Reviewed by Ryosuke Niwa.
1917
1918         * DumpRenderTree/TestRunner.cpp:
1919         (TestRunner::staticFunctions):
1920         (setUseDashboardCompatibilityModeCallback): Deleted.
1921         * DumpRenderTree/TestRunner.h:
1922         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1923         * DumpRenderTree/mac/DumpRenderTree.mm:
1924         (resetWebViewToConsistentStateBeforeTesting):
1925         * DumpRenderTree/mac/TestRunnerMac.mm:
1926         (TestRunner::setUseDashboardCompatibilityMode): Deleted.
1927         * ImageDiff/cg/Configurations/Base.xcconfig:
1928         * Scripts/webkitperl/FeatureList.pm:
1929         * TestWebKitAPI/Configurations/Base.xcconfig:
1930         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1931         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1932         * TestWebKitAPI/Tests/mac/DeviceScaleFactorInDashboardRegions.mm: Removed.
1933         * WebKitTestRunner/Configurations/Base.xcconfig:
1934         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1935         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1936         (WTR::InjectedBundle::beginTesting):
1937         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1938         (WTR::TestRunner::setUseDashboardCompatibilityMode): Deleted.
1939         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1940
1941 2019-06-10  Alexey Proskuryakov  <ap@apple.com>
1942
1943         Tool binaries like WebKitTestRunner have too aggressive stripping, resulting in non-symbolicated crash logs
1944         https://bugs.webkit.org/show_bug.cgi?id=198616
1945         rdar://problem/36386573
1946
1947         Reviewed by David Kilzer.
1948
1949         Adding an explicit STRIP_STYLE to appropriate xcconfigs.
1950
1951         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
1952         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
1953         * DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig:
1954         * ImageDiff/cg/Configurations/ImageDiff.xcconfig:
1955         * MiniBrowser/Configurations/MiniBrowser.xcconfig:
1956         * MobileMiniBrowser/Configurations/MobileMiniBrowser.xcconfig:
1957         * TestWebKitAPI/Configurations/TestWTF.xcconfig:
1958         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
1959         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
1960         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
1961
1962 2019-06-10  Wenson Hsieh  <wenson_hsieh@apple.com>
1963
1964         [iOS] fast/xsl tests are flaky when run after certain viewport shrink-to-fit tests
1965         https://bugs.webkit.org/show_bug.cgi?id=198699
1966         <rdar://problem/50501718>
1967
1968         Reviewed by Simon Fraser.
1969
1970         Add logic to platformResetPreferencesToConsistentValues, to reset the "ShouldIgnoreMetaViewport" preference.
1971         While this is already being adjusted in platformConfigureViewForTest using the correct, TestOptions, this might
1972         happen too late, allowing the shrink-to-fit-content heuristic to unexpectedly kick in on tests where testing
1973         viewport parameters are used.
1974
1975         * WebKitTestRunner/ios/TestControllerIOS.mm:
1976         (WTR::TestController::platformResetPreferencesToConsistentValues):
1977         (WTR::TestController::platformConfigureViewForTest):
1978
1979 2019-06-10  Yusuke Suzuki  <ysuzuki@apple.com>
1980
1981         [JSC] UnlinkedCodeBlock should be eventually jettisoned in VM mini mode
1982         https://bugs.webkit.org/show_bug.cgi?id=198023
1983
1984         Reviewed by Saam Barati.
1985
1986         * Scripts/run-jsc-stress-tests:
1987
1988 2019-06-10  Timothy Hatcher  <timothy@apple.com>
1989
1990         Integrate dark mode support for iOS.
1991         https://bugs.webkit.org/show_bug.cgi?id=198687
1992         rdar://problem/51545643
1993
1994         Reviewed by Tim Horton.
1995
1996         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1997
1998 2019-06-10  Jonathan Bedard  <jbedard@apple.com>
1999
2000         webkitpy: xcrun simctl spawn *** launchctl print system output is not utf-8
2001         https://bugs.webkit.org/show_bug.cgi?id=198723
2002
2003         Reviewed by Aakash Jain.
2004
2005         * Scripts/webkitpy/xcode/simulated_device.py:
2006         (SimulatedDevice.is_usable): Do not decode 'print system' output, it's already ASCII.
2007
2008 2019-06-10  Sihui Liu  <sihui_liu@apple.com>
2009
2010         [WKHTTPCookieStore getAllCookies:] may return duplicate cookies
2011         https://bugs.webkit.org/show_bug.cgi?id=198635
2012         <rdar://problem/46010232>
2013
2014         Reviewed by Ryosuke Niwa.
2015
2016         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
2017         (areCookiesEqual):
2018         (TEST):
2019
2020 2019-06-10  Adrian Perez de Castro  <aperez@igalia.com>
2021
2022         [JHBuild] Bump shared-mime-info to version ≥ 1.6
2023         https://bugs.webkit.org/show_bug.cgi?id=198714
2024
2025         Reviewed by Carlos Garcia Campos.
2026
2027         * gtk/jhbuild.modules: Bump shared-mime-info version to 1.10.
2028         * gtk/patches/shared-mime-info-xht-glob.patch: Removed.
2029         * gtk/patches/shared-mime-info-xhtml-magic.patch: Removed.
2030
2031 2019-06-10  Philippe Normand  <pnormand@igalia.com>
2032
2033         [WPE][Qt] Port to new wpe_fdo_egl_exported_image API
2034         https://bugs.webkit.org/show_bug.cgi?id=198713
2035
2036         Reviewed by Carlos Garcia Campos.
2037
2038         * flatpak/org.webkit.WPEModules.yaml: Include wpebackend-fdo
2039         patches currently used in JHBuild.
2040
2041 2019-06-10  Adrian Perez de Castro  <aperez@igalia.com>
2042
2043         [GTK][Flatpak] webkit-build fails due to missing libwpe in Flatpak environment
2044         https://bugs.webkit.org/show_bug.cgi?id=198711
2045
2046         Reviewed by Philippe Normand.
2047
2048         * flatpak/org.webkit.GTK.yaml: Also include modules from
2049         org.webkit.WPEModules.yaml, which brings in libwpe and WPEBackend-fdo
2050
2051 2019-06-10  Zan Dobersek  <zdobersek@igalia.com>
2052
2053         Unreviewed follow-up to r246148. Add another WPEBackend-fdo patch that
2054         avoids double-free condition that's causing bots to exit early.
2055
2056         * gtk/jhbuild.modules:
2057         * gtk/wpebackend-fdo-view-backend-exportable-private-don-t-double-free-ca.patch: Added.
2058         * wpe/jhbuild.modules:
2059         * wpe/wpebackend-fdo-view-backend-exportable-private-don-t-double-free-ca.patch: Added.
2060
2061 2019-06-09  Fujii Hironori  <Hironori.Fujii@sony.com>
2062
2063         [WinCairo][MiniBrowser] Disable MediaCapabilities until it's ready
2064         https://bugs.webkit.org/show_bug.cgi?id=198655
2065
2066         Reviewed by Ross Kirsling.
2067
2068         MediaCapabilities is enabled by default for WK2, but WinCairo
2069         doesn't implemented yet. Disable it in MiniBrowser.
2070
2071         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2072         (WebKitBrowserWindow::create):
2073
2074 2019-06-08  Wenson Hsieh  <wenson_hsieh@apple.com>
2075
2076         [iOS] The default application name for user agent when requesting desktop content is still "Mobile/15E148"
2077         https://bugs.webkit.org/show_bug.cgi?id=198693
2078         <rdar://problem/51555371>
2079
2080         Reviewed by Tim Horton.
2081
2082         Augment an existing API test to exercise three additional scenarios:
2083             -   The web view configuration's application name is never set; the default should not include
2084                 "Mobile/15E148" in desktop mode.
2085             -   The application name is explicitly set to nil; the default application name should still not include
2086                 "Mobile/15E148".
2087             -   The application name is explicitly set to the default value, "Mobile/15E148". WKWebView should honor
2088                 this when generating the user agent, even in desktop mode.
2089
2090         * TestWebKitAPI/ios/PreferredContentMode.mm:
2091         (TestWebKitAPI::setUpWebViewForPreferredContentModeTestingWithoutNavigationDelegate):
2092         (TestWebKitAPI::setUpWebViewForPreferredContentModeTesting):
2093         (TestWebKitAPI::TEST):
2094
2095 2019-06-08  Zalan Bujtas  <zalan@apple.com>
2096
2097         [LFC] Unreviewed test gardening.
2098
2099         Remove rtl tests. They were mistakenly marked as pass.
2100
2101         * LayoutReloaded/misc/LFC-passing-tests.txt:
2102
2103 2019-06-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
2104
2105         REGRESSION (r244182) [WK1]: Page updates should always scheduleCompositingLayerFlush() immediately
2106         https://bugs.webkit.org/show_bug.cgi?id=198664
2107
2108         Reviewed by Simon Fraser.
2109
2110         Delete repeated entries which were submitted by mistake.
2111
2112         * Tracing/SystemTracePoints.plist:
2113
2114 2019-06-07  Wenson Hsieh  <wenson_hsieh@apple.com>
2115
2116         Allow clients to vend custom -inputView and -inputAccessoryView by overriding WKWebView methods
2117         https://bugs.webkit.org/show_bug.cgi?id=198631
2118         <rdar://problem/51505431>
2119
2120         Reviewed by Tim Horton.
2121
2122         Add an API test that overrides -[WKWebView inputView] and -[WKWebView inputAccessoryView].
2123
2124         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2125         (-[CustomInputWebView initWithFrame:configuration:inputView:inputAccessoryView:]):
2126         (-[CustomInputWebView inputView]):
2127         (-[CustomInputWebView inputAccessoryView]):
2128         (TestWebKitAPI::TEST):
2129
2130 2019-06-07  Daniel Bates  <dabates@apple.com>
2131
2132         [lldb-webkit] Pretty-print all kinds of Documents
2133         https://bugs.webkit.org/show_bug.cgi?id=198620
2134
2135         Reviewed by Simon Fraser.
2136
2137         Register formatters for all classes derived from WebCore::Document so we get nice summaries
2138         without having to drill down in Xcode- or casting- to the base class, Document.
2139
2140         Older LLDB versions use to do this automatically, but this functionality was removed in newer
2141         versions:
2142             [[
2143                 Warning: previous versions of LLDB defined cascading to mean not only going through typedef
2144                 chains, but also through inheritance chains. This feature has been removed since it
2145                 significantly degrades performance. You need to set up your formatters for every type in
2146                 inheritance chains to which you want the formatter to apply.
2147             ]]
2148             <https://lldb.llvm.org/use/variable.html> (as of 06/06/2019)
2149
2150         * lldb/lldb_webkit.py:
2151         (__lldb_init_module):
2152
2153 2019-06-07  Jonathan Bedard  <jbedard@apple.com>
2154
2155         webkitpy: Support reporting results for uncommon test configurations
2156         https://bugs.webkit.org/show_bug.cgi?id=198662
2157         <rdar://problem/51524128>
2158
2159         Reviewed by Aakash Jain.
2160
2161         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2162         (Manager.run): Override wk1 and wk2 flavors with specified flavor.
2163         * Scripts/webkitpy/port/base.py:
2164         (Port.configuration_for_upload): Set flavor based on options.
2165         * Scripts/webkitpy/results/options.py:
2166         (upload_options): Add result-report-flavor option.
2167         * Scripts/webkitpy/test/main.py:
2168         (Tester._run_tests): Set flavor based on options.
2169
2170 2019-06-07  Wenson Hsieh  <wenson_hsieh@apple.com>
2171
2172         [iOS] At least 6 API tests are failing due to an exception when writing NSAttributedString to the pasteboard
2173         https://bugs.webkit.org/show_bug.cgi?id=198641
2174         <rdar://problem/51266310>
2175
2176         Reviewed by Tim Horton.
2177
2178         Work around a bug in a lower-level framework, which currently prevents NSAttributedStrings from being written to
2179         UIPasteboard by way of -[NSItemProvider registerObject:visibility:]. This is because, when saving a
2180         representation of "public.rtfd" to disk, the default suggested filename (determined using CoreServices APIs
2181         _UTTypeCreateSuggestedFilename and UTTypeCopyDescription) ends up being nil; UIKit then subsequently tries to
2182         append nil as a path component using -URLByAppendingPathComponent:, which throws an exception. This only
2183         reproduces on iOS simulator.
2184
2185         To work around this for the time being, simply avoid writing a representation of "public.rtfd" to disk. This
2186         representation is actually ignored by most clients anyways (including WebKit), in favor of using
2187         "com.apple.flat-rtfd".
2188
2189         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2190         (TestWebKitAPI::TEST):
2191         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2192         (applyWorkaroundToAllowWritingAttributedStringsToItemProviders):
2193         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
2194
2195 2019-06-06  Carlos Garcia Campos  <cgarcia@igalia.com>
2196
2197         REGRESSION(r244857): [GTK][WPE] Many tests are no longer run in the bots after r244857
2198         https://bugs.webkit.org/show_bug.cgi?id=198607
2199
2200         Reviewed by Michael Catanzaro.
2201
2202         Since r244857 several test executables are compiled in the base tests directory instead of using their own sub
2203         directory. Our scripts to run the tests rely on the tests location to decide whether to run them or not, or
2204         determine the type of the tests.
2205
2206         * Scripts/run-gtk-tests:
2207         (GtkTestRunner): Rename TEST_DIRS as TEST_TARGETS and use the executable names for tests not in a subdirectory.
2208         (GtkTestRunner._setup_testing_environment): Fix TestWebKitAccessibility directory name.
2209         (GtkTestRunner.is_glib_test): Use the test name for the ones not using a subdirectory.
2210         (GtkTestRunner.is_google_test): Ditto.
2211         * Scripts/run-wpe-tests:
2212         (WPETestRunner): Rename TEST_DIRS as TEST_TARGETS and use the executable names for tests not in a subdirectory.
2213         (WPETestRunner.is_glib_test): Use the test name for the ones not using a subdirectory.
2214         (WPETestRunner.is_google_test): Ditto.
2215         * glib/api_test_runner.py:
2216         (TestRunner): Rename TEST_DIRS as TEST_TARGETS.
2217         (TestRunner._get_tests): Handle test targets which can now contain directories and executables.
2218
2219 2019-06-06  Keith Rollin  <krollin@apple.com>
2220
2221         Remove SSL-based tests from TestWebKitAPI on some configurations
2222         https://bugs.webkit.org/show_bug.cgi?id=198551
2223         <rdar://problem/51424996>
2224
2225         Reviewed by Jonathan Bedard.
2226
2227         Not all platforms have SSL handy, so don't include SSL-based tests on
2228         those platforms.
2229
2230         * TestWebKitAPI/TCPServer.cpp:
2231         * TestWebKitAPI/TCPServer.h:
2232         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
2233         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:
2234         * TestWebKitAPI/config.h:
2235
2236 2019-06-06  Daniel Bates  <dabates@apple.com>
2237
2238         [lldb-webkit] TypeError: cannot concatenate 'str' and 'int' objects when prettify SecurityOrigin with
2239         non-default port number
2240         https://bugs.webkit.org/show_bug.cgi?id=198618
2241
2242         Reviewed by Brent Fulgham.
2243
2244         WebCoreSecurityOriginProvider.port() returns an int data type. We need to explicitly convert this to
2245         a string before we concatenate it with another string when building the string representation
2246         for the WebCore::SecurityOrigin object. Otherwise, Python complains that we are concatenating a str
2247         with an int and we don't get a pretty-printed representation for WebCore::SecurityOrigin.
2248
2249         * lldb/lldb_webkit.py:
2250         (WebCoreSecurityOriginProvider.to_string): Call str() on the port before concatenting it.
2251
2252 2019-06-06  Jonathan Bedard  <jbedard@apple.com>
2253
2254         Remove obsolete TOOLCHAINS overrides from as asan.xcconfig
2255         https://bugs.webkit.org/show_bug.cgi?id=198613
2256
2257         Reviewed by Alexey Proskuryakov.
2258
2259         * asan/asan.xcconfig: XCBuild doesn't support overriding toolchains.
2260
2261 2019-06-06  Jonathan Bedard  <jbedard@apple.com>
2262
2263         webkitpluginhost: Support ASan as a style
2264         https://bugs.webkit.org/show_bug.cgi?id=198586
2265         <rdar://problem/51459088>
2266
2267         Reviewed by Alexey Proskuryakov.
2268
2269         * Scripts/webkitpy/port/base.py:
2270         (Port.configuration_for_upload): Add ASan as a style.
2271         * Scripts/webkitpy/port/config.py:
2272         (Config._read_configuration):
2273         (Config):
2274         (Config.asan): Add property to check if the ASan configuration is active.
2275         * Scripts/webkitpy/port/config_unittest.py:
2276         (ConfigTest.test_default_configuration__scripterror):
2277         (ConfigTest):
2278         (ConfigTest.test_asan):
2279         * Scripts/webkitpy/test/main.py:
2280         (Tester._run_tests): Add Asan as a style.
2281
2282 2019-06-06  Alexey Proskuryakov  <ap@apple.com>
2283
2284         block-spammers tool doesn't block e-mail
2285         https://bugs.webkit.org/show_bug.cgi?id=198570
2286
2287         Reviewed by Jonathan Bedard.
2288
2289         * Scripts/block-spammers: (disable_user): Corrected the parameters, Bugzilla doesn't
2290         recognize "false" here. Also, request body is unnecessary.
2291
2292 2019-06-06  Carlos Garcia Campos  <cgarcia@igalia.com>
2293
2294         [GTK][WPE] Enable PSON
2295         https://bugs.webkit.org/show_bug.cgi?id=194979
2296
2297         Reviewed by Žan Doberšek.
2298
2299         Add WPEBackend-fdo patch required for PSON to work. It can be removed once we have a new version to depend on.
2300
2301         * gtk/jhbuild.modules:
2302         * gtk/patches/wpebackend-fdo-Handle-the-case-of-new-target-created-for-the-same-v.patch: Added.
2303         * wpe/jhbuild.modules:
2304         * wpe/patches/wpebackend-fdo-Handle-the-case-of-new-target-created-for-the-same-v.patch: Added.
2305
2306 2019-06-05  Andy Estes  <aestes@apple.com>
2307
2308         [macOS] Stop calling -[NSDraggingItem setItem:]
2309         https://bugs.webkit.org/show_bug.cgi?id=198588
2310         <rdar://problem/48297453>
2311
2312         On macOS Catalina, use -[NSDraggingItem _initWithItem:] instead.
2313
2314         Reviewed by Wenson Hsieh.
2315
2316         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Fixed up file paths in the
2317         TestRunnerShared group.
2318
2319         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
2320         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
2321         Changed to call -[NSDraggingItem _initWithItem:] when available.
2322
2323         * TestRunnerShared/spi/AppKitTestSPI.h: Renamed from
2324         Tools/DumpRenderTree/mac/AppKitTestSPI.h and moved NSDraggingItem internal interface
2325         declarations here from DumpRenderTree.
2326
2327         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2328         Added TestRunnerShared/spi/AppKitTestSPI.h.
2329
2330         * TestWebKitAPI/mac/TestDraggingInfo.mm:
2331         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
2332         Changed to call -[NSDraggingItem _initWithItem:] when available.
2333
2334 2019-06-05  Jer Noble  <jer.noble@apple.com>
2335
2336         -[WKWebView _suspendAllMediaPlayback] does not persist across navigation.
2337         https://bugs.webkit.org/show_bug.cgi?id=198585
2338
2339         Reviewed by Chris Dumez.
2340
2341         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2342         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2343         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSuspendAllMediaPlayback.mm: Added.
2344         (TEST):
2345         * TestWebKitAPI/Tests/WebKitLegacy/ios/video-with-audio.html:
2346
2347 2019-06-05  Alex Christensen  <achristensen@webkit.org>
2348
2349         Re-enable safe browsing in WKWebView
2350         https://bugs.webkit.org/show_bug.cgi?id=196161
2351         <rdar://problem/49171413>
2352
2353         Reviewed by Ryosuke Niwa.
2354
2355         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2356         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2357         (TEST):
2358         (safeBrowsingView):
2359
2360 == Rolled over to ChangeLog-2019-06-05 ==