Actually fix the Mac builders build after <http://trac.webkit.org/changeset/190219>
[WebKit-https.git] / Tools / ChangeLog
1 2015-09-30  Daniel Bates  <dabates@apple.com>
2
3         Actually fix the Mac builders build after <http://trac.webkit.org/changeset/190219>
4         (https://bugs.webkit.org/show_bug.cgi?id=149539)
5
6         I inadvertently didn't remove the ONLY_ACTIVE_ARCH=NO flag when building on a Mac
7         in <http://trac.webkit.org/changeset/190351>.
8
9         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
10         (CompileWebKit.start):
11
12 2015-09-30  Daniel Bates  <dabates@apple.com>
13
14         Attempt to fix the Mac builders build after <http://trac.webkit.org/changeset/190219>
15         (https://bugs.webkit.org/show_bug.cgi?id=149539)
16
17         {32, 64}-bit Mac builders should not try to build project {Plugin.64, Plugin.32},
18         respectively; only pass ONLY_ACTIVE_ARCH=NO when building for iOS.
19
20         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
21         (CompileWebKit.start):
22
23 2015-09-30  Lucas Forschler  <lforschler@apple.com>
24
25         bot210 was configured for a queue instead of bot126.
26         
27         Unreviewed config.json fix.
28         
29         * BuildSlaveSupport/build.webkit.org-config/config.json:
30
31 2015-09-30  Lucas Forschler  <lforschler@apple.com>
32
33         Bring El Capitan buildbot infrastructure online.
34         https://bugs.webkit.org/show_bug.cgi?id=149605
35         
36         Reviewed by Darin Adler.
37
38         * BuildSlaveSupport/build.webkit.org-config/config.json:
39
40 2015-09-30  Tomas Popela  <tpopela@redhat.com>
41
42         [GTK] Deprecation warnings in DOMNodeTest
43         https://bugs.webkit.org/show_bug.cgi?id=149663
44
45         After the webkit_dom_document_get_elements_by_tag_name deprecation we
46         need to update the tests to use webkit_dom_document_query_selector_all
47         to avoid compilation warnings.
48
49         Also add a new test for webkit_dom_document_get_elements_by_tag_name_as_html_collection
50         (the suggested replacement for the deprecated function).
51
52         Reviewed by Carlos Garcia Campos.
53
54         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
55         (WebKitDOMNodeTest::testTagNamesNodeList):
56         (WebKitDOMNodeTest::testTagNamesHTMLCollection):
57         (registerTests):
58         (WebKitDOMNodeTest::testTagNames): Deleted.
59         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
60         (prepareDOMForTagNamesTests):
61         (testWebKitDOMNodeTagNamesNodeList):
62         (testWebKitDOMNodeTagNamesHTMLCollection):
63         (beforeAll):
64         (testWebKitDOMNodeTagNames): Deleted.
65
66 2015-09-29  Simon Fraser  <simon.fraser@apple.com>
67
68         WebKitTestRunner fails to apply "useFlexibleViewport" when it's specified in a file comment
69         https://bugs.webkit.org/show_bug.cgi?id=149650
70
71         Reviewed by Tim Horton.
72         
73         TestInvocation::invoke() consulted shouldMakeViewportFlexible(), but that only
74         looks at the file path, and not the custom options that come from file comments.
75         
76         Fix by computing TestOptions before making the TestInvocation, and setting them
77         as const TestInvocation data. This meant changing various call sites to take
78         the std::string pathOrURL, rather than the TestInvocation itself.
79         
80         Also initialize TestInvocation with a WKURLRef, rather than a std::string.
81
82         * WebKitTestRunner/CMakeLists.txt:
83         * WebKitTestRunner/TestController.cpp:
84         (WTR::TestController::ensureViewSupportsOptionsForTest):
85         (WTR::testPath):
86         (WTR::createTestURL):
87         (WTR::updateTestOptionsFromTestHeader):
88         (WTR::TestController::testOptionsForTest):
89         (WTR::TestController::updateWebViewSizeForTest):
90         (WTR::TestController::updateWindowScaleForTest):
91         (WTR::TestController::runTest):
92         * WebKitTestRunner/TestController.h:
93         * WebKitTestRunner/TestInvocation.cpp:
94         (WTR::TestInvocation::TestInvocation):
95         (WTR::TestInvocation::invoke):
96         (WTR::createWKURL): Deleted.
97         (WTR::TestInvocation::shouldMakeViewportFlexible): Deleted.
98         (WTR::TestInvocation::shouldUseFixedLayout): Deleted.
99         * WebKitTestRunner/TestInvocation.h:
100         (WTR::TestInvocation::options):
101         * WebKitTestRunner/TestOptions.cpp: Copied from Tools/WebKitTestRunner/TestOptions.h.
102         (WTR::pathContains):
103         (WTR::shouldMakeViewportFlexible):
104         (WTR::shouldUseFixedLayout):
105         (WTR::isSVGTestPath):
106         (WTR::isHiDPITestPath):
107         (WTR::TestOptions::TestOptions):
108         * WebKitTestRunner/TestOptions.h:
109         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
110         * WebKitTestRunner/efl/TestControllerEfl.cpp:
111         (WTR::pathContains):
112         (WTR::shouldUseFixedLayout):
113         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
114         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
115         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
116         * WebKitTestRunner/ios/TestControllerIOS.mm:
117         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
118         * WebKitTestRunner/mac/TestControllerMac.mm:
119         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
120
121 2015-09-29  Aakash Jain  <aakash_jain@apple.com>
122
123         Flakiness dashboard should support OS X El Capitan
124         https://bugs.webkit.org/show_bug.cgi?id=149648
125
126         Reviewed by Alexey Proskuryakov.
127
128         * QueueStatusServer/app.yaml: We do not need to maintain SVN revision here because of 
129         difference between new appscale and old Google App Engine implementation.
130         * TestResultServer/app.yaml: Same.
131         * TestResultServer/static-dashboards/builders.jsonp: Added OSX El Capitan support.
132
133 2015-09-29  Daniel Bates  <dabates@apple.com>
134
135         configure-xcode-for-ios-development does not work with Xcode 7
136         https://bugs.webkit.org/show_bug.cgi?id=149640
137
138         Reviewed by Alexey Proskuryakov.
139
140         When Xcode 7 is installed, running configure-xcode-for-ios-development dies with an error
141         because it cannot find the Xcode specification files for iOS simulator and device. These
142         files have moved to a new location in Xcode 7 distribution. Moreover we must add the
143         relevant definitions to the Xcode 7 specification files directly as opposed to creating
144         new specification files with the added definitions (as we did in older versions of Xcode)
145         in order for Xcode 7 to honor these definitions.
146
147         * Scripts/configure-xcode-for-ios-development: Sorted forward declarations.
148         (updateXcodeSpecificationFilesForSDKIfNeeded): Added.
149         (updateXcode7SpecificationFile): Added.
150         (createLegacyXcodeSpecificationFilesForSDKIfNeeded): Formerly named createXcodeSpecificationFilesForSDKIfNeeded.
151         (writeXcodeSpecification): Moved congratulations line to caller so as to write out the
152         appropriate success message.
153         (mergeXcodeSpecificationWithSpecificationAndId): Formerly named createXcodeSpecificationFromSpecificationAndId.
154         (createXcodeSpecificationFilesForSDKIfNeeded): Deleted.
155         (createXcodeSpecificationFromSpecificationAndId): Deleted.
156
157 2015-09-29  Brent Fulgham  <bfulgham@apple.com>
158
159         [Win] Allow 'prepare-ChangeLog' to be used without Cygwin
160         https://bugs.webkit.org/show_bug.cgi?id=149639
161
162         Reviewed by Alex Christensen.
163
164         * Scripts/VCSUtils.pm:
165         (exitStatus): Use 'isWindows()' method.
166         (isSVNVersion16OrNewer): 'eval' is not needed here, and just causes
167         an error. This method could probably just go away.
168         (normalizePath): Leave Windows (or Unix) paths as platform paths, rather than
169         always changing to Unix style. 
170         (unixPath): Added. Needed so Windows can always show a Unix path in the
171         ChangeLog file.
172         (changeLogName): Work around the fact that 'getpwuid' is not available on
173         a pure Windows build of Perl.
174         * Scripts/prepare-ChangeLog:
175         (generateFunctionLists): Normalize path received from 'svn' in case it's a Unix
176         path on Windows.
177         (svnUpdateCommand): Added helper function. Needed because Windows Perl does not
178         support using arrays for 'open' arguments.
179         (resolveChangeLogsPath): Ditto.
180         (resolveConflictedChangeLogs): Use new helper functions.
181         (generateNewChangeLogs): Force Windows to use Unix paths in ChangeLog output.
182         (diffCommand): Use double-quotes for paths, since Windows doesn't understand single
183         quotes. Unix systems are happy either way.
184         (statusCommand): Ditto.
185         * Scripts/webkitdirs.pm:
186         (launcherName): Drive-by fix. WinLauncher was renamed to MiniBrowser some time ago.
187
188 2015-09-29  Brent Fulgham  <bfulgham@apple.com>
189
190         [Win] Unreviewed 64-bit build fix after switch to CMake.
191
192         * Scripts/webkitdirs.pm:
193         (determineIsWin64FromArchitecture): Added.
194
195 2015-09-16  Carlos Garcia Campos  <cgarcia@igalia.com>
196
197         printing does not use minimum page zoom factor
198         https://bugs.webkit.org/show_bug.cgi?id=108507
199
200         Reviewed by Darin Adler.
201
202         WebKitTestRunner always takes the snapshots from the UI process
203         (expect for IOS), so in the case of printing, the layout in the
204         web view is not the expected one. When printing, we need to take
205         the snapshot in the web process and ensure it's rendered with a
206         PrintContext.
207
208         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
209         (WTR::InjectedBundlePage::dump): When dumping pixels, pass
210         kWKSnapshotOptionsPrinting option to
211         WKBundlePageCreateSnapshotWithOptions() when printing.
212
213 2015-09-28  Carlos Garcia Campos  <cgarcia@igalia.com>
214
215         [WTR] Pixel tests generate the snapshots twice in Web and UI processes
216         https://bugs.webkit.org/show_bug.cgi?id=149595
217
218         Reviewed by Tim Horton.
219
220         All ports except IOS implement
221         PlatformWebView::windowSnapshotImage() to generate the snapshot
222         for the pixel tests in the UI process. But we are still generating
223         a snapshot for pixel tests in the Web process too, that is passed
224         to the UI process but ignored.
225         Whether a pixel result is needed or not, is only known by the web
226         process depending on whether the test called dumpAsText with
227         dumpPixels == true or not. Since the pixels are now dump in the UI
228         process, we need to pass that information to the UI process when
229         the test is done. For that we set a PixelResultIsPending bool
230         parameter to the Done message, and we only add the PixelResult
231         when UI process doesn't need to generate the pixels dump.
232
233         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
234         (WTR::InjectedBundle::didReceiveMessageToPage): Set
235         m_pixelResultIsPending to false on reset.
236         (WTR::InjectedBundle::done): Add PixelResultIsPending parameter to the
237         Done message, and set the PixelResult if m_pixelResultIsPending is false.
238         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
239         (WTR::InjectedBundle::setPixelResult): Set m_pixelResultIsPending to false.
240         (WTR::InjectedBundle::setNeedsPixelResult): Set m_pixelResultIsPending.
241         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
242         (WTR::InjectedBundlePage::dump): Only create a snapshot for IOS
243         port.
244         * WebKitTestRunner/TestInvocation.cpp:
245         (WTR::TestInvocation::dumpResults): Use either the pixel result
246         from the web process or generate a pixel result from the web view
247         if need it.
248         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
249         * WebKitTestRunner/TestInvocation.h: Add SnapshotResultType enum
250         parameter to dumpPixelsAndCompareWithExpected, since the snapshot
251         is created by the caller now, but the CG implementation needs to
252         know if it's a Web or UI process snapshot.
253         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
254         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
255         cairo surface for the given image.
256         * WebKitTestRunner/cg/TestInvocationCG.cpp:
257         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
258         CGContext for the given image.
259
260 2015-09-28  Dean Johnson  <dean_johnson@apple.com>
261
262         Fix JS errors on dashboard metrics page
263         https://bugs.webkit.org/show_bug.cgi?id=149608
264
265         Reviewed by Alexey Proskuryakov.
266
267         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Updated to use Settings.
268         (initPlatformsByFamily): 
269         (updateHiddenPlatforms):
270         (parsePlatformFamily): Deleted.
271         (updateToggleButtons): Deleted.
272         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
273         (updateHiddenPlatforms): Added to remove errors.
274         (initPlatformsByFamily): Added to remove errors.
275         (unhiddenQueues): Updated to use Settings.
276         (documentReady): Added logic to add toggle buttons to the settings menu.
277         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
278         (Settings.prototype.parsePlatformFamily): Moved duplicate logic from Main.js and
279         MetricsMain.js to Settings.
280         (Settings.prototype.updateToggleButtons): Moved duplicate logic from Main.js and
281         MetricsMain.js to Settings.
282         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
283         (QueueView.prototype._updateHiddenState): Updated to use Settings.
284
285 2015-09-28  Aakash Jain  <aakash_jain@apple.com>
286
287         Appscale query fails because of missing index
288         https://bugs.webkit.org/show_bug.cgi?id=149609
289
290         Reviewed by Darin Adler.
291
292         * QueueStatusServer/index.yaml: Added the required index.
293
294 2015-09-28  Brent Fulgham  <bfulgham@apple.com>
295
296         [Win] Fix the 64-bit build after switch to cmake.
297
298         Reviewed by Alex Christensen.
299
300         * Scripts/webkitdirs.pm:
301         (generateBuildSystemFromCMakeProject): Use correct arguments for cmake to
302         run a 64-bit build.
303
304 2015-09-28  Brent Fulgham  <bfulgham@apple.com>
305
306         [Win] Allow Windows to run test-webkitpy without Cygwin
307         https://bugs.webkit.org/show_bug.cgi?id=149602
308
309         Reviewed by Alex Christensen.
310
311         These changes mostly shift from hard-coded paths using UNIX-style
312         separators to Python's "os.path.join" syntax that uses the correct
313         path separator for each platform.
314         
315         * Scripts/webkitpy/common/system/path.py:
316         (cygpath): Don't pass paths through Cygpath on native Windows.
317         * Scripts/webkitpy/port/win.py:
318         (WinPort._path_to_apache): Use os.path.join.
319         (WinPort._ntsd_location): Support 64-bit environment (ProgramW6432 doesn't exist
320         in 64-bit environments).
321         * Scripts/webkitpy/style/checker.py: Use os.path.join.
322         * Scripts/webkitpy/style/checker_unittest.py:
323         (GlobalVariablesTest.test_path_rules_specifier.assertNoCheck): Use os.path.join.
324         (GlobalVariablesTest.test_path_rules_specifier): Ditto.
325         (GlobalVariablesTest): Ditto.
326         (GlobalVariablesTest.test_max_reports_per_category): Ditto.
327         (CheckerDispatcherSkipTest.test_should_skip_with_warning): Ditto.
328         (CheckerDispatcherDispatchTest.test_js_paths): Ditto.
329         (CheckerDispatcherDispatchTest.test_json_paths): Ditto.
330         (CheckerDispatcherDispatchTest.test_python_paths): Ditto.
331         (CheckerDispatcherDispatchTest.test_text_paths): Ditto.
332         (CheckerDispatcherDispatchTest.test_xml_paths): Ditto.
333         (StyleProcessor_CodeCoverageTest._create_carriage_checker_class): Ditto.
334         (StyleProcessor_CodeCoverageTest): Ditto.
335         (StyleProcessor_CodeCoverageTest.test_should_process__skip_without_warning): Ditto.
336         (StyleProcessor_CodeCoverageTest.test_should_process__skip_with_warning): Ditto.
337         (StyleProcessor_CodeCoverageTest.test_should_process__true_result): Ditto.
338         * Scripts/webkitpy/w3c/test_parser_unittest.py: Uses os.path.join rather than
339         manual string concatenation of paths.
340
341 2015-09-28  Csaba Osztrogonác  <ossy@webkit.org>
342
343         Add bugzilla addresses of committers to contributors.json
344         https://bugs.webkit.org/show_bug.cgi?id=149520
345
346         Reviewed by Darin Adler.
347
348         * Scripts/webkitpy/common/config/contributors.json:
349
350 2015-09-28  Csaba Osztrogonác  <ossy@webkit.org>
351
352         validate-committer-lists -b shouldn't need edituser privileges
353         https://bugs.webkit.org/show_bug.cgi?id=149519
354
355         Reviewed by Darin Adler.
356
357         * Scripts/validate-committer-lists:
358         (CommitterListBugzillaChecker._has_invalid_bugzilla_email):
359         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
360         (BugzillaQueries.is_invalid_bugzilla_email):
361         (BugzillaQueries): Deleted.
362         (BugzillaQueries.fetch_logins_matching_substring): Deleted.
363
364 2015-09-26  Carlos Garcia Campos  <cgarcia@igalia.com>
365
366         Unreviewed. Gardening: skip media stream tests failing after r190262.
367
368         * Scripts/run-gtk-tests:
369         (TestRunner):
370
371 2015-09-25  Alexey Proskuryakov  <ap@apple.com>
372
373         [Mac] USE_INTERNAL_SDK is used undefined in tools projects
374         https://bugs.webkit.org/show_bug.cgi?id=149571
375
376         Reviewed by Dan Bernstein.
377
378         Use the same pattern as in Source directory configurations (so, also get rid of AspenFamily.xcconfig). 
379
380         * DumpRenderTree/mac/Configurations/Base.xcconfig:
381         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
382         * LayoutTestRelay/Configurations/Base.xcconfig:
383         * MiniBrowser/Configurations/Base.xcconfig:
384         * MiniBrowser/Configurations/DebugRelease.xcconfig:
385         * TestWebKitAPI/Configurations/Base.xcconfig:
386         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
387         * WebEditingTester/Configurations/Base.xcconfig:
388         * WebEditingTester/Configurations/DebugRelease.xcconfig:
389         * WebKitTestRunner/Configurations/Base.xcconfig:
390         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
391         * WebKitTestRunner/iOS.xcconfig: Removed.
392
393 2015-09-25  Eric Carlson  <eric.carlson@apple.com>
394
395         Clean up user media request internal API
396         https://bugs.webkit.org/show_bug.cgi?id=149527
397
398         Reviewed by Tim Horton.
399
400         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
401         (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack): Update for API changes.
402
403         * WebKitTestRunner/TestController.cpp:
404         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Ditto.
405
406 2015-09-25  Simon Fraser  <simon.fraser@apple.com>
407
408         [iOS WK2] Add viewport tests and fix runUIScript() timing issues
409         https://bugs.webkit.org/show_bug.cgi?id=149577
410
411         Reviewed by Tim Horton.
412         
413         When calling testRunner.runUIScript() from a page load event, the script could run
414         in the UI process before the current remote layer tree transaction had been handled
415         there. This meant that runUIScript() could query state which was about to change.
416         
417         Fix by delaying the execution of the UI script until a layer tree transaction has
418         been handled by the UI process, leveraging the existing DrawingAreaProxy::dispatchAfterEnsuringDrawing().
419
420         * WebKitTestRunner/TestInvocation.cpp:
421         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
422         (WTR::TestInvocation::runUISideScriptAfterUpdateCallback):
423         * WebKitTestRunner/TestInvocation.h:
424
425 2015-09-25  Alexey Proskuryakov  <ap@apple.com>
426
427         [Mac] Media tests start to time out after a few days of bot uptime
428         https://bugs.webkit.org/show_bug.cgi?id=149468
429
430         Reviewed by Darin Adler.
431
432         Delete cache directory in addition to the temporary one. Don't delete /private/tmp/MediaCache,
433         as it's not longer used by tests. Set TMPDIR and DIRHELPER_USER_DIR_SUFFIX to make
434         all temporary and cache files go to a custom location.
435
436         * Scripts/webkitpy/port/base.py:
437         * Scripts/webkitpy/port/driver.py:
438         * Scripts/webkitpy/port/mac.py:
439         * Scripts/webkitpy/port/win.py:
440         (WinPort._driver_tempdir_for_environment): Deleted unused function.
441
442 2015-09-25  Dan Bernstein  <mitz@apple.com>
443
444         Removed MiniBrowser.entitlements.
445
446         Rubber-stamped by Anders Carlsson.
447
448         The entitlements weren’t used anyway.
449
450         * MiniBrowser/MiniBrowser.entitlements: Removed.
451         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
452
453 2015-09-24  Daniel Bates  <dabates@apple.com>
454
455         Add WebKitSystemInterface for iOS 9.0
456         https://bugs.webkit.org/show_bug.cgi?id=149550
457
458         Rubber-stamped by Alexey Proskuryakov.
459
460         * Scripts/copy-webkitlibraries-to-product-directory:
461
462 2015-09-24  Daniel Bates  <dabates@apple.com>
463
464         Support building for arbitrary architectures
465         https://bugs.webkit.org/show_bug.cgi?id=149539
466
467         Reviewed by Alexey Proskuryakov.
468
469         Teach buildbot to pass the architectures associated with the builder to build-webkit
470         when building on OS X and iOS. As a side effect of this change we now support building
471         universal binaries when multiples architectures are specified.
472
473         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
474         (CompileWebKit.start):
475
476 2015-09-24  Daniel Bates  <dabates@apple.com>
477
478         Fix the build after <http://trac.webkit.org/changeset/190212>
479         (http://trac.webkit.org/changeset/190212)
480
481         I inadvertently did not remove the fullPlatform argument from one of the callers of archiveBuiltProduct().
482
483         * BuildSlaveSupport/built-product-archive:
484         (main):
485
486 2015-09-24  Daniel Bates  <dabates@apple.com>
487
488         Support running unit tests on iOS Simulator test bot
489         https://bugs.webkit.org/show_bug.cgi?id=149536
490
491         Reviewed by Alexey Proskuryakov.
492
493         Implements support for running unit tests on a iOS test bot. At the time of writing,
494         the script run-api-tests supports running unit tests on Mac, Windows and iOS Simulator.
495
496         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
497         (RunUnitTests.start): Append appropriate command line flag when invoking script run-api-tests.
498         (TestFactory.__init__): Add step RunUnitTests when the test bot is for the iOS Simulator platform.
499
500 2015-09-24  Daniel Bates  <dabates@apple.com>
501
502         Add support infrastructure for OpenSource iOS builders and testers
503         https://bugs.webkit.org/show_bug.cgi?id=149534
504
505         Reviewed by Darin Adler.
506
507         Towards setting up OpenSource iOS build bots, teach buildbot and its support
508         scripts about iOS.
509
510         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
511         (appendCustomBuildFlags): Require the caller to pass parameter fullPlatform and append
512         --ios-simulator or --device for a builder/tester whose full platform name begins with
513         "ios-simulator" or "ios", respectively.
514         (RunJavaScriptCoreTests.start): Pass the full platform name to appendCustomBuildFlags().
515         * BuildSlaveSupport/built-product-archive:
516         (main): Pass the full platform name to determineWebKitBuildDirectory().
517         (determineWebKitBuildDirectory): Call script webkit-build-directory with the appropriate
518         command line flag when building for iOS.
519         (archiveBuiltProduct): Use the same logic for iOS as we do for Mac. Also, remove unused
520         parameter fullPlatform. This parameter was originally added in r125066 to support the
521         Chromium Android port, which has since been removed from the OpenSource WebKit Project.
522         (extractBuiltProduct): Use the same logic for iOS as we do for Mac.
523         * BuildSlaveSupport/clean-build:
524         (main): Call script webkit-build-directory with the appropriate command line flag when
525         building for iOS.
526         * BuildSlaveSupport/delete-stale-build-files:
527         (main): Use the same logic for iOS as we do for Mac.
528         (webkitBuildDirectory): Call script webkit-build-directory with the appropriate command line
529         flag when building for iOS.
530         * BuildSlaveSupport/test-result-archive:
531         (archiveTestResults): Use the same logic for iOS as we do for Mac.
532
533 2015-09-24  Daniel Bates  <dabates@apple.com>
534
535         Remove Chromium-specific changes to script built-product-archive
536         https://bugs.webkit.org/show_bug.cgi?id=149530
537
538         Rubber-stamped by Csaba Osztrogonác.
539
540         Reverts changes made in r113074 and r113067 to support Chromium testers. The
541         Chromium code has long since been removed from the OpenSource WebKit Project.
542
543         * BuildSlaveSupport/built-product-archive:
544         (createZipManually):
545         (createZip):
546         (archiveBuiltProduct):
547
548 2015-09-24  Dan Bernstein  <mitz@apple.com>
549
550         Build fix.
551
552         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
553
554 2015-09-24  Mark Lam  <mark.lam@apple.com>
555
556         Unreviewed. Make Lucas Forschler a WebKit reviewer.
557
558         * Scripts/webkitpy/common/config/contributors.json:
559
560 2015-09-24  Carlos Garcia Campos  <cgarcia@igalia.com>
561
562         Unreviewed. Fix GObject DOM API breaks after r190120.
563
564         Bring back code removed in r169931 to handle documentation of
565         deleted classes.
566
567         * gtk/webkitdom.py:
568         (WebKitDOMDocGenerator):
569         (WebKitDOMDocGenerator.write_deleted_classes):
570         (WebKitDOMDocGenerator.generate):
571         (write_deleted_classes):
572         (WebKitDOMDocGeneratorSections._deleted_class):
573         (WebKitDOMDocGeneratorSections._deleted_class.in):
574         (WebKitDOMDocGeneratorSections.write_deleted_classes):
575         (WebKitDOMDocGeneratorSections.write_deleted_classes.with):
576
577 2015-09-23  Myles C. Maxfield  <mmaxfield@apple.com>
578
579         [Cocoa] [Font Features] Implement font-variant-*
580         https://bugs.webkit.org/show_bug.cgi?id=148413
581
582         Reviewed by Darin Adler.
583
584         Update test font to use "lnum" feature.
585
586         * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
587         (Generator::appendGSUBTable):
588
589 2015-09-22  Andy Estes  <aestes@apple.com>
590
591         ContentFiltering.AllowDownloadAfterAddData is very flaky
592         https://bugs.webkit.org/show_bug.cgi?id=148885
593         <rdar://problem/22729563>
594
595         Reviewed by Alexey Proskuryakov.
596
597         The AllowDownload* tests were relying on -_downloadDidStart: being called before -webView:didFinishNavigation:,
598         but there is no guarantee of this. For tests that should allow a download, spin the runloop until
599         -_downloadDidStart: is called. The test will now timeout on failure, but will no longer produce false failures.
600
601         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
602         (downloadTest):
603
604 2015-09-22  Alexey Proskuryakov  <ap@apple.com>
605
606         Mavericks: Media tests start to time out after a few days of bot uptime
607         https://bugs.webkit.org/show_bug.cgi?id=149468
608
609         Reviewed by Chris Dumez.
610
611         * Scripts/webkitpy/port/base.py:
612         * Scripts/webkitpy/port/driver.py:
613         * Scripts/webkitpy/port/mac.py:
614
615 2015-09-22  Nan Wang  <n_wang@apple.com>
616
617         Unreviewed, add myself to the committers list.
618
619         * Scripts/webkitpy/common/config/contributors.json:
620
621 2015-09-21  Simon Fraser  <simon.fraser@apple.com>
622
623         Remove 'nullable' to fix older iOS builds.
624
625         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
626         (-[TestRunnerWKWebView scrollViewDidEndZooming:withView:atScale:]):
627
628 2015-09-21  Brent Fulgham  <bfulgham@apple.com>
629
630         [Win] Show tiled drawing debug overlay on Windows
631         https://bugs.webkit.org/show_bug.cgi?id=149426
632
633         Reviewed by Dean Jackson.
634
635         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc: Add new menu option.
636         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h: Ditto.
637         * MiniBrowser/win/Common.cpp:
638         (::ToggleMenuItem): Recognize new menu item and toggle the 'showTiledScrollingIndicator'
639         flag if needed.
640         * MiniBrowser/win/MiniBrowser.h: Update to use new IWebPreferencesPrivate3 class.
641
642 2015-09-21  Brent Fulgham  <bfulgham@apple.com>
643
644         [Win] Use command-line argument to launch in regular or High DPI mode.
645         https://bugs.webkit.org/show_bug.cgi?id=149417
646
647         Reviewed by Dean Jackson.
648
649         * MiniBrowser/win/Common.cpp:
650         (parseCommandLine): Ignore the '--highDPI' argument. It's used at the
651         very start of execution, before the MiniBrowser.dll is loaded.
652         * win/DLLLauncher/DLLLauncherMain.cpp:
653         (shouldUseHighDPI): Check for '--highDPI', and use this mode if
654         present. On WinCairo, always use High DPI.
655
656 2015-09-21  Ryosuke Niwa  <rniwa@webkit.org>
657
658         32-bit Mac build fix attempt after r190065.
659
660         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
661
662 2015-09-21  Alexey Proskuryakov  <ap@apple.com>
663
664         [OS X] Update for Xcode 7.0 on Yosemite
665         https://bugs.webkit.org/show_bug.cgi?id=149389
666
667         Reviewed by Dan Bernstein.
668
669         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
670         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h:
671         Removed unneeded declarations - conforming to a protocol is sufficient.
672
673         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
674         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm:
675         Changed the definitions to be compiled whenever the SDK requires it (so we will have
676         dead code compiled in when building for 10.10 with 10.11 SDK, somewhat unfortunately).
677
678 2015-09-21  Simon Fraser  <simon.fraser@apple.com>
679
680         Add the ability for tests to run script in the UI process in WebKitTestRunner
681         https://bugs.webkit.org/show_bug.cgi?id=149356
682
683         Reviewed by Tim Horton.
684
685         This change adds testRunner.runUIScript(script, callback), which allows a test
686         to execute script in a JSContext which runs in the UI process. That context
687         has bindings exposed through the UIScriptController interface; currently one test
688         function, and some iOS-specific functions are included. UIScriptController can be
689         async with a callback, and runUIScript() itself is asynchronous. When the UI 
690         script is complete, it calls uiController.uiScriptComplete(result), where 'result'
691         is a string passed back to the web process, and given to the runUIScript()
692         callback function.
693         
694         Thanks to Gyuyoung Kim for help with the Gtk/Efl build.
695
696         * WebKitTestRunner/DerivedSources.make: Build UIScriptController.idl.
697         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Add runUIScript().
698         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
699         (WTR::InjectedBundle::didReceiveMessageToPage): When the UI-side script is
700         complete, call back into TestRunner.
701         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
702         (WTR::nextUIScriptCallbackID):
703         (WTR::TestRunner::runUIScript): Post a message to the injected bundle to run the UI script.
704         (WTR::TestRunner::runUIScriptCallback): When the UI script is done, execute its callback function.
705         * WebKitTestRunner/InjectedBundle/TestRunner.h:
706         * WebKitTestRunner/PlatformWebView.h:
707         * WebKitTestRunner/TestController.cpp:
708         (WTR::updateTestOptionsFromTestHeader):
709         (WTR::TestController::testOptionsForTest): Support "useFlexibleViewport" as a test argument.
710         (WTR::shouldUseFixedLayout): Deleted. Moved to a TestInvocation function.
711         * WebKitTestRunner/TestInvocation.cpp:
712         (WTR::TestInvocation::shouldUseFixedLayout):
713         (WTR::TestInvocation::shouldUseThreadedScrolling):
714         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
715         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
716         (WTR::TestInvocation::runUISideScript): Run the UI-side script!
717         (WTR::TestInvocation::uiScriptDidComplete): Send a message back to the injected bundle.
718         * WebKitTestRunner/TestInvocation.h:
719         * WebKitTestRunner/TestOptions.h:
720         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
721         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
722         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h: Copied from Tools/WebKitTestRunner/TestOptions.h.
723         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm: Added.
724         (-[TestRunnerWKWebView dragImage:at:offset:event:pasteboard:source:slideBack:]):
725         (-[TestRunnerWKWebView zoomToScale:animated:completionHandler:]):
726         (-[TestRunnerWKWebView scrollViewDidEndZooming:withView:atScale:]):
727         (-[TestRunnerWKWebView onDidEndZooming:]): Allow a test to hook into the end of zooming.
728         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
729         (WTR::PlatformWebView::PlatformWebView): Make a TestRunnerWKWebView on iOS.
730         * WebKitTestRunner/ios/UIScriptControllerIOS.mm: Added.
731         (WTR::UIScriptController::doAsyncTask):
732         (WTR::UIScriptController::zoomToScale):
733         (WTR::UIScriptController::zoomScale):
734         (WTR::UIScriptController::minimumZoomScale):
735         (WTR::UIScriptController::maximumZoomScale):
736         (WTR::UIScriptController::contentVisibleRect):
737         * WebKitTestRunner/mac/EventSenderProxy.mm:
738         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
739         (-[TestRunnerWKWebView dragImage:at:offset:event:pasteboard:source:slideBack:]): Deleted.
740         * WebKitTestRunner/mac/TestControllerMac.mm:
741         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
742         (WTR::shouldUseThreadedScrolling): Deleted. Moved to TestInvocation.
743         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h:
744         * WebKitTestRunner/uiscriptcontext/UIScriptContext.cpp: Added. Owns the JS context in the UI process.
745         (UIScriptContext::UIScriptContext):
746         (UIScriptContext::~UIScriptContext):
747         (UIScriptContext::runUIScript): Entrypoint to running the UI script. If the script didn't do anything
748         asynchronous, call the callback.
749         (UIScriptContext::nextTaskCallbackID):
750         (UIScriptContext::prepareForAsyncTask): Do setup for one async task (i.e. a UIScriptController function
751         that has a callback). Has to store the callbackID of the script, so code called from the completion
752         callback knows which UI script invoked it.
753         (UIScriptContext::asyncTaskComplete): Called when one task is finished.
754         (UIScriptContext::uiScriptComplete):
755         (UIScriptContext::objectFromRect): Make a JS object from a rect.
756         * WebKitTestRunner/uiscriptcontext/UIScriptContext.h: Copied from Tools/WebKitTestRunner/TestOptions.h.
757         (WTR::UIScriptContext::hasOutstandingAsyncTasks):
758         * WebKitTestRunner/uiscriptcontext/UIScriptController.cpp: Copied from Tools/WebKitTestRunner/TestOptions.h.
759         (WTR::UIScriptController::UIScriptController):
760         (WTR::UIScriptController::makeWindowObject):
761         (WTR::UIScriptController::wrapperClass):
762         (WTR::UIScriptController::doAsyncTask):
763         (WTR::UIScriptController::zoomToScale):
764         (WTR::UIScriptController::zoomScale):
765         (WTR::UIScriptController::minimumZoomScale):
766         (WTR::UIScriptController::maximumZoomScale):
767         (WTR::UIScriptController::contentVisibleRect):
768         (WTR::UIScriptController::uiScriptComplete):
769         * WebKitTestRunner/uiscriptcontext/UIScriptController.h: Copied from Tools/WebKitTestRunner/TestOptions.h.
770         (WTR::UIScriptController::create):
771         * WebKitTestRunner/uiscriptcontext/bindings/UIScriptController.idl: Copied from Tools/WebKitTestRunner/TestOptions.h.
772
773 2015-09-21  Tim Horton  <timothy_horton@apple.com>
774
775         Turn on threaded scrolling by default in the tests
776         https://bugs.webkit.org/show_bug.cgi?id=149377
777
778         Reviewed by Simon Fraser.
779
780         * WebKitTestRunner/mac/TestControllerMac.mm:
781         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
782         (WTR::shouldUseThreadedScrolling): Deleted.
783         Turn on threaded scrolling by default.
784
785 2015-09-21  Carlos Garcia Campos  <cgarcia@igalia.com>
786
787         [GTK] run-gtk-tests doesn't provide feedback about crashing google tests
788         https://bugs.webkit.org/show_bug.cgi?id=149252
789
790         Reviewed by Darin Adler.
791
792         In case of glib tests the test runner notifies about tests
793         crashing, but for google tests we don't get any feedback, which
794         means that in case of a test crashing we get a list of **PASS**
795         messages and at the summary we are notified that the test suite
796         has failed, but it's impossible to know which test cases have failed.
797
798         * Scripts/run-gtk-tests:
799         (TestRunner._run_google_test): Add a **CRASH** message if test
800         case crashed.
801
802 2015-09-20  Alexey Proskuryakov  <ap@apple.com>
803
804         WebKitTestRunner can leak user content script results between tests
805         https://bugs.webkit.org/show_bug.cgi?id=149391
806
807         Reviewed by Sam Weinig.
808
809         Move WKBundlePageRemoveAllUserContent call so that it's executed before loading
810         about:blank, and thus about:blank doesn't have unintended side effects.
811
812         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
813         (WTR::InjectedBundle::beginTesting):
814         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
815         (WTR::InjectedBundlePage::resetAfterTest):
816
817 2015-09-20  Alexey Proskuryakov  <ap@apple.com>
818
819         [Mac, iOS] AccessibilityController doesn't uninstall global notification handler
820         https://bugs.webkit.org/show_bug.cgi?id=149384
821
822         Reviewed by Chris Fleizach.
823
824         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
825         (AccessibilityController::addNotificationListener): Fixed a leak, and cleaned up the code.
826         (AccessibilityController::platformResetToConsistentState): Actually remove the handler,
827         regardless of whether someone else holds a reference (we also call -stopListening in
828         -dealloc).
829
830         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
831         (AccessibilityController::platformResetToConsistentState):
832         (AccessibilityController::addNotificationListener):
833         Ditto.
834
835 2015-09-20  Youenn Fablet  <youenn.fablet@crf.canon.fr>
836
837         Remove XHR_TIMEOUT compilation guard
838         https://bugs.webkit.org/show_bug.cgi?id=149260
839
840         Reviewed by Benjamin Poulain.
841
842         * Scripts/webkitperl/FeatureList.pm:
843
844 2015-09-19  Dan Bernstein  <mitz@apple.com>
845
846         Attempted build fix.
847
848         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
849
850 2015-09-18  Commit Queue  <commit-queue@webkit.org>
851
852         Unreviewed, rolling out r189908.
853         https://bugs.webkit.org/show_bug.cgi?id=149368
854
855         Broke run-webkit-tests --pixel (Requested by ap on #webkit).
856
857         Reverted changeset:
858
859         "printing does not use minimum page zoom factor"
860         https://bugs.webkit.org/show_bug.cgi?id=108507
861         http://trac.webkit.org/changeset/189908
862
863 2015-09-18  Andy Estes  <aestes@apple.com>
864
865         [iOS] did{Start,Finish}LoadForQuickLookDocumentInMainFrame is never called on WKNavigationDelegate
866         https://bugs.webkit.org/show_bug.cgi?id=149360
867
868         Reviewed by Tim Horton.
869
870         Added an API test.
871
872         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
873         * TestWebKitAPI/Tests/WebKit2Cocoa/QuickLook.mm: Added.
874         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
875         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
876         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]):
877         (TEST):
878         * TestWebKitAPI/ios/pages.pages: Added.
879
880 2015-09-18  Nan Wang  <n_wang@apple.com>
881
882         AX: Implement ARIA 1.1 @aria-current on iOS
883         https://bugs.webkit.org/show_bug.cgi?id=149297
884
885         Reviewed by Chris Fleizach.
886
887         Added support to test aria-current on iOS.
888
889         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
890         (AccessibilityUIElement::stringAttributeValue):
891         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
892         (WTR::AccessibilityUIElement::stringAttributeValue):
893
894 2015-09-18  Alexey Proskuryakov  <ap@apple.com>
895
896         iOS WebKitTestRunner frequently crashes in WKContextGetIconDatabase
897         https://bugs.webkit.org/show_bug.cgi?id=149352
898
899         Reviewed by Simon Fraser.
900
901         * WebKitTestRunner/TestController.cpp: (WTR::TestController::~TestController):
902         m_context can be null. This may indicate a bug in webkitpy too, but
903         WebKitTestRunner should handle this situation nicely, there is nothing intrinsically
904         wrong with opening and immediately closing it.
905
906 2015-09-18  Daniel Bates  <dabates@apple.com>
907
908         isGitSVNDirectory() returns true when Git is not installed
909         https://bugs.webkit.org/show_bug.cgi?id=149351
910
911         Reviewed by Alexey Proskuryakov.
912
913         Fixes an issue where VCSUtils::isGitSVNDirectory() returns true for any arbitrary directory if
914         Git is not installed on the machine.
915
916         * Scripts/VCSUtils.pm:
917         (isGitSVNDirectory): Ensure that `git config --get svn-remote.svn.fetch 2>& 1` exits with
918         status code 0 (success).
919
920 2015-09-18  Alex Christensen  <achristensen@webkit.org>
921
922         Prevent build-webkit from building four times on Windows 
923         https://bugs.webkit.org/show_bug.cgi?id=149336
924
925         Reviewed by Brent Fulgham.
926
927         * Scripts/build-webkit:
928         Move the Windows code out of the for loop iterating over each subdirectory to be build.
929         They're built all at once.
930         * Scripts/webkitdirs.pm:
931         (buildVisualStudioProject):
932         (cmakeGeneratedBuildfile):
933         Don't generate the Visual Studio solution if it already exists.
934         It will run CMake again if necessary.
935
936 2015-09-17  Simon Fraser  <simon.fraser@apple.com>
937
938         [iOS WK2] WTR fails to set the key window in the UIKit sense
939         https://bugs.webkit.org/show_bug.cgi?id=149325
940
941         Reviewed by Tim Horton.
942
943         -[WebKitTestRunnerWindow isKeyWindow] just returned _platformWebView->windowIsKey().
944         This causes UIKit to bypass code that actually sets the key window, resulting in
945         [UIAppliation sharedApplication].keyWindow always being nil.
946
947         Fix by PlatformWebView::setWindowIsKey() actually call -makeKeyWindow, and having
948         -[WebKitTestRunnerWindow isKeyWindow] call super.
949
950         * WebKitTestRunner/PlatformWebView.h:
951         (WTR::PlatformWebView::setWindowIsKey): Deleted.
952         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
953         (WTR::PlatformWebView::setWindowIsKey):
954         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
955         (WTR::PlatformWebView::setWindowIsKey):
956         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
957         (-[WebKitTestRunnerWindow isKeyWindow]):
958         (WTR::PlatformWebView::PlatformWebView):
959         (WTR::PlatformWebView::~PlatformWebView):
960         (WTR::PlatformWebView::setWindowIsKey):
961         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
962         (WTR::PlatformWebView::setWindowIsKey):
963
964 2015-09-17  Simon Fraser  <simon.fraser@apple.com>
965
966         [iOS WK2] When loading viewport tests, use the normal web page viewport configuration
967         https://bugs.webkit.org/show_bug.cgi?id=149321
968
969         Reviewed by Tim Horton.
970         
971         InjectedBundlePage::platformDidStartProvisionalLoadForFrame() unconditionally 
972         enabled the "testing" viewport configuration, which disables page scaling.
973         
974         If we're running viewport tests, we want the normal web page configuration.
975         Do that by passing a flag in the dictionary sent to InjectedBundle::beginTesting(),
976         based on whether the test is in a "viewport" directory.
977
978         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
979         (WTR::InjectedBundle::beginTesting):
980         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
981         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame): Deleted.
982         * WebKitTestRunner/TestInvocation.cpp:
983         (WTR::TestInvocation::shouldLogFrameLoadDelegates):
984         (WTR::TestInvocation::shouldLogHistoryClientCallbacks):
985         (WTR::TestInvocation::shouldMakeViewportFlexible):
986         (WTR::TestInvocation::invoke):
987         * WebKitTestRunner/TestInvocation.h:
988         * WebKitTestRunner/ios/TestControllerIOS.mm:
989         (WTR::TestController::platformConfigureViewForTest):
990         (WTR::shouldMakeViewportFlexible): Deleted.
991
992 2015-09-17  Simon Fraser  <simon.fraser@apple.com>
993
994         Give iOS WebKitTestRunner a launch storyboard
995         https://bugs.webkit.org/show_bug.cgi?id=149314
996
997         Reviewed by Dan Bates.
998         
999         Add a launch storyboard to iOS WebKitTestRunner so that Springboard recognizes
1000         that it's been built for specific device configurations, and puts the window
1001         at the top of the screen. This simplifies coordinate conversions in a future patch.
1002
1003         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1004         * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist:
1005         * WebKitTestRunner/ios/Launch.storyboard: Added.
1006
1007 2015-09-17  Myles C. Maxfield  <mmaxfield@apple.com>
1008
1009         Update licence in r189890
1010         https://bugs.webkit.org/show_bug.cgi?id=149306
1011
1012         Reviewed by Dean Jackson.
1013
1014         * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
1015         * FontWithFeatures/FontWithFeatures/FontCreator.h:
1016         * FontWithFeatures/FontWithFeatures/main.cpp:
1017
1018 2015-09-17  Mark Lam  <mark.lam@apple.com>
1019
1020         Add the ability to skip JIT stress tests in run-javascriptcore-tests.
1021         https://bugs.webkit.org/show_bug.cgi?id=149285
1022
1023         Reviewed by Saam Barati.
1024
1025         Just need to add an option to pass --no-jit to run-jsc-stress-test.
1026
1027         * Scripts/run-javascriptcore-tests:
1028         (runJSCStressTests):
1029
1030 2015-09-17  Alex Christensen  <achristensen@webkit.org>
1031
1032         Switch AppleWin build to use CMake
1033         https://bugs.webkit.org/show_bug.cgi?id=149163
1034
1035         Reviewed by Brent Fulgham.
1036
1037         * Scripts/build-webkit:
1038         * Scripts/run-api-tests:
1039         (runTest):
1040         (listAllTests):
1041         (prepareEnvironmentForRunningTestTool):
1042         (testToolPaths):
1043         (testToolPath): Deleted.
1044         Run the API tests as separate executables on Windows.
1045         It used to be TestWebKitAPI.exe, and it is now TestWTF.exe, TestWebCore.exe, and TestWebKit.exe.
1046         * Scripts/webkitdirs.pm:
1047         (checkRequiredSystemConfig):
1048         (jhbuildWrapperPrefixIfNeeded):
1049         (generateBuildSystemFromCMakeProject):
1050         Fix configuration quirks.
1051
1052 2015-09-17  Dean Johnson  <dean_johnson@apple.com>
1053
1054         Added toggle options for hiding and showing certain platform families on the dashboard.
1055         https://bugs.webkit.org/show_bug.cgi?id=148403
1056
1057         Reviewed by David Kilzer.
1058
1059         This patch removes "hiddenPlatforms" from use in the code and local storage. We also removed
1060         individual hide/show buttons for platforms because we've added toggle options to hide/show entire
1061         families. Examples of these are "mac", "ios", and "linux". "Show All Platforms" was also removed
1062         in lieu of an "all" button in the toggle menu.
1063
1064         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
1065         (parsePlatformFamily): Helper function to parse out a platform family.
1066         (initPlatformsByFamily): Initializes platformsByFamily, which organizes platforms on the
1067         page by platformsByFamily[<family>] = <list of platforms belonging to that family>.
1068         (updateToggleButtons): Updates the status of the toggle buttons.
1069         (updateHiddenPlatforms): Changed to work with the new implementation of hiding/showing platforms.
1070         (documentReady): Added creation of toggle buttons.
1071         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
1072         (unhiddenQueues): Updated to search by platform family instead of the individual platform name.
1073         (documentReady): Changed hiddenPlatforms => hiddenPlatformFamilies.
1074         (updateHiddenPlatforms): Deleted. After removing the individual hide button code, 
1075         this did the exact same thing as the updateHiddenPlatforms in Scripts/Main.js so it was removed.
1076         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
1077         (QueueView): Updated to use hiddenPlatformFamilies.
1078         (QueueView.prototype._updateHiddenState): Updated to use hiddenPlatformFamilies.
1079         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
1080         (Settings.prototype.toggleHiddenPlatformFamily): Renamed function and some variables.
1081         (Settings.prototype.clearHiddenPlatformFamilies): Now uses hiddenPlatformFamilies for events.
1082         (Settings.prototype.toggleHiddenPlatform): Deleted.
1083         (Settings.prototype.clearHiddenPlatforms): Deleted.
1084         (Settings.prototype.toggleShowPlatformFamily): Deleted.
1085         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1086         (div.cellButton, div.accessibilityButton, div.platformFamilyToggleButton):
1087         (div.cellButton.unhide, div.accessibilityButton.unhide, div.platformFamilyToggleButton.unhide):
1088         (.settings-visible div.settingsWrapper.hide, .settings-visible div.settingsWrapper):
1089         (table.queue-grid tr.headers th):
1090         (div.settingsWrapper.hide):
1091         (div.settingsWrapper):
1092         (div.familyToggleWrapper):
1093         (div.platformFamilyToggleButton):
1094         (div.platformFamilyShowToggleButton:not(:last-child)):
1095         (div.familyShown):
1096         (div.accessibilityButton):
1097         (div.cellButton, div.accessibilityButton): Added platformFamilyToggleButton class.
1098         (div.cellButton.unhide, div.accessibilityButton.unhide): Added platformFamilyToggleButton class.
1099         (.settings-visible div.accessibilityButton.hide, .settings-visible div.accessibilityButton.unhide): Added
1100         platformFamilyToggleButton and settingsWrapper class.
1101         (.accessibilityButton): Deleted.
1102
1103 2015-09-17  Tim Horton  <timothy_horton@apple.com>
1104
1105         Add a test ensuring that scrolling in the middle of a page can't start a swipe gesture
1106         https://bugs.webkit.org/show_bug.cgi?id=148904
1107
1108         Reviewed by Myles Maxfield.
1109
1110         * WebKitTestRunner/TestController.cpp:
1111         (WTR::parseBooleanTestHeaderValue):
1112         (WTR::updateViewOptionsFromTestHeader):
1113         Check for the key "useThreadedScrolling".
1114         Add some code to check for "true" and "false" for boolean options.
1115
1116         (WTR::TestController::viewOptionsForTest):
1117         Apply the test's overrides last, even after the platform's.
1118
1119 2015-09-16  Carlos Garcia Campos  <cgarcia@igalia.com>
1120
1121         printing does not use minimum page zoom factor
1122         https://bugs.webkit.org/show_bug.cgi?id=108507
1123
1124         Reviewed by Darin Adler.
1125
1126         WebKitTestRunner always takes the snapshots from the UI process
1127         (expect for IOS), so in the case of printing, the layout in the
1128         web view is not the expected one. When printing, we need to take
1129         the snapshot in the web process and ensure it's rendered with a
1130         PrintContext.
1131
1132         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1133         (WTR::InjectedBundlePage::dump): When dumping pixels, pass
1134         kWKSnapshotOptionsPrinting option to
1135         WKBundlePageCreateSnapshotWithOptions() when printing. When not
1136         printing, don't even create the snapshot, since it will be ignored
1137         by the UI process that always creates its own from the WebView (expect for IOS platform)
1138         * WebKitTestRunner/TestInvocation.cpp:
1139         (WTR::TestInvocation::dumpResults): Use always the snapshot image
1140         received from the web process if any when comparing pixel
1141         results. Now we only receive a snapshot from the web process in
1142         case of printing, or when platform is IOS. Otherwhise, generate
1143         the snapshot from the WebView as usual.
1144         * WebKitTestRunner/TestInvocation.h: Add SnapshotResultType enum
1145         parameter to dumpPixelsAndCompareWithExpected, since the snapshot
1146         is created by the caller now, but the CG implementation needs to
1147         know if it's a Web or UI process snapshot.
1148         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
1149         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
1150         cairo surface for the given image.
1151         * WebKitTestRunner/cg/TestInvocationCG.cpp:
1152         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
1153         CGContext for the given image.
1154
1155 2015-09-16  Myles C. Maxfield  <mmaxfield@apple.com>
1156
1157         Create a font which can be used for testing font features
1158         https://bugs.webkit.org/show_bug.cgi?id=149237
1159
1160         Reviewed by Simon Fraser.
1161
1162         This patch adds a new project in the Tools/ directory which generates a font which can
1163         be used for testing font features. This is a standalone project consisting of two files:
1164         1. A file which actually generates the byte vector representing the font. This file has
1165         a single public function: std::vector<uint8_t> generateFont(). This file is not platform
1166         specific, and only relies on the C++ STL.
1167         2. A file with a main() which calls generateFont() and writes out the font, as well as
1168         uses the font to render some demonstration text into a .png file. This file is platform
1169         specific.
1170
1171         The font itself only supports the following characters:
1172         ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz
1173         However, the shape of these letters are either an X or a check mark.
1174
1175         The letter "A" always is a check mark.
1176         The letter "B" always is an X.
1177         Without any font features turned on, the rest of the letters are shown as X.
1178
1179         Each font feature has an letter associated with it. When the font feature is enabled,
1180         that letter is shown as a check mark. For example, when "smcp" is enabled, "J" is shown
1181         as a check mark.
1182
1183         Here are the mappings of font features to letters:
1184         liga: C
1185         clig: D
1186         dlig: E
1187         hlig: F
1188         calt: G
1189         subs: H
1190         sups: I
1191         smcp: J
1192         c2sc: K
1193         pcap: L
1194         c2pc: M
1195         unic: N
1196         titl: O
1197         onum: P
1198         pnum: Q
1199         tnum: R
1200         frac: S
1201         afrc: T
1202         ordn: U
1203         zero: V
1204         hist: W
1205         jp78: X
1206         jp83: Y
1207         jp90: Z
1208         jp04: a
1209         smpl: b
1210         trad: c
1211         fwid: d
1212         pwid: e
1213         ruby: f
1214
1215         * FontWithFeatures/FontWithFeatures.xcodeproj/project.pbxproj: Added.
1216         * FontWithFeatures/FontWithFeatures/FontCreator.cpp: Added.
1217         (integralLog2):
1218         (roundDownToPowerOfTwo):
1219         (isFourByteAligned):
1220         (clampTo):
1221         (append32):
1222         (writeCFFEncodedNumber):
1223         (CFFBuilder::CFFBuilder):
1224         (CFFBuilder::takeResult):
1225         (CFFBuilder::moveTo):
1226         (CFFBuilder::lineTo):
1227         (CFFBuilder::curveToCubic):
1228         (CFFBuilder::closePath):
1229         (CFFBuilder::writePoint):
1230         (generateBoxCharString):
1231         (generateCheckCharString):
1232         (generateXCharString):
1233         (charStringForGlyph):
1234         (Generator::generate):
1235         (Generator::Placeholder::Placeholder):
1236         (Generator::Placeholder::populate):
1237         (Generator::Placeholder::~Placeholder):
1238         (Generator::placeholder):
1239         (Generator::append16):
1240         (Generator::append32):
1241         (Generator::append32BitCode):
1242         (Generator::overwrite16):
1243         (Generator::overwrite32):
1244         (Generator::appendCFFTable):
1245         (Generator::appendSubstitutionSubtable):
1246         (Generator::appendScriptSubtable):
1247         (Generator::appendGSUBTable):
1248         (Generator::appendOS2Table):
1249         (Generator::appendFormat12CMAPTable):
1250         (Generator::appendFormat4CMAPTable):
1251         (Generator::appendCMAPTable):
1252         (Generator::appendHEADTable):
1253         (Generator::appendHHEATable):
1254         (Generator::appendHMTXTable):
1255         (Generator::appendMAXPTable):
1256         (Generator::appendNAMETable):
1257         (Generator::appendPOSTTable):
1258         (Generator::calculateChecksum):
1259         (Generator::appendTable):
1260         (generateFont):
1261         * FontWithFeatures/FontWithFeatures/FontCreator.h: Added.
1262         * FontWithFeatures/FontWithFeatures/main.cpp: Added.
1263         (drawTextWithFeature):
1264         (main):
1265
1266 2015-09-16  Commit Queue  <commit-queue@webkit.org>
1267
1268         Unreviewed, rolling out r189875 and r189878.
1269         https://bugs.webkit.org/show_bug.cgi?id=149235
1270
1271         cygwin cmake build not ready yet (Requested by alexchristensen
1272         on #webkit).
1273
1274         Reverted changesets:
1275
1276         "Switch AppleWin build to use CMake"
1277         https://bugs.webkit.org/show_bug.cgi?id=149163
1278         http://trac.webkit.org/changeset/189875
1279
1280         "Cygwin build fix after r189875"
1281         http://trac.webkit.org/changeset/189878
1282
1283 2015-09-16  Alex Christensen  <achristensen@webkit.org>
1284
1285         Cygwin build fix after r189875
1286
1287         * Scripts/build-webkit:
1288         * Scripts/webkitdirs.pm:
1289         (jhbuildWrapperPrefixIfNeeded):
1290         (generateBuildSystemFromCMakeProject):
1291         Make things work with cygwin and cmake.
1292
1293 2015-09-16  Alex Christensen  <achristensen@webkit.org>
1294
1295         Switch AppleWin build to use CMake
1296         https://bugs.webkit.org/show_bug.cgi?id=149163
1297
1298         Reviewed by Brent Fulgham.
1299
1300         * Scripts/build-webkit:
1301         Build with CMake.
1302         * Scripts/run-api-tests:
1303         (runTest):
1304         (listAllTests):
1305         (prepareEnvironmentForRunningTestTool):
1306         (testToolPaths):
1307         (testToolPath): Deleted.
1308         Run the API tests as separate executables on Windows.
1309         It used to be TestWebKitAPI.exe, and it is now TestWTF.exe, TestWebCore.exe, and TestWebKit.exe.
1310
1311 2015-09-16  Alexey Proskuryakov  <ap@apple.com>
1312
1313         Add newer build.webkit.org pages to robots.txt
1314         https://bugs.webkit.org/show_bug.cgi?id=149219
1315
1316         Reviewed by Darin Adler.
1317
1318         Indexing bot watcher's dashboard can't be good.
1319
1320         * BuildSlaveSupport/build.webkit.org-config/public_html/robots.txt:
1321
1322 2015-09-16  Alex Christensen  <achristensen@webkit.org>
1323
1324         Rollout r189851 and 189853 because they didn’t actually fix the permissions issue
1325
1326         * BuildSlaveSupport/built-product-archive:
1327         (unzipArchive):
1328
1329 2015-09-16  Csaba Osztrogonác  <ossy@webkit.org>
1330
1331         [EFL] Fix the help message of separated web process option of MiniBrowser
1332         https://bugs.webkit.org/show_bug.cgi?id=149212
1333
1334         Reviewed by Gyuyoung Kim.
1335
1336         * MiniBrowser/efl/main.c:
1337
1338 2015-09-16  Alex Christensen  <achristensen@webkit.org>
1339
1340         Fix python syntax after r189851.
1341
1342         * BuildSlaveSupport/built-product-archive:
1343         (unzipArchive):
1344         For loops need a colon.
1345
1346 2015-09-15  Alex Christensen  <achristensen@webkit.org>
1347
1348         Fix Windows test bots after changing to non-cygwin build
1349         https://bugs.webkit.org/show_bug.cgi?id=149196
1350
1351         Reviewed by Daniel Bates.
1352
1353         * BuildSlaveSupport/built-product-archive:
1354         (unzipArchive):
1355         Using different versions of python makes what I think is https://bugs.python.org/issue15795
1356         prevent us from executing files from the archive on the test bots.
1357
1358 2015-09-15  Ryosuke Niwa  <rniwa@webkit.org>
1359
1360         Add ShadowRoot interface and Element.prototype.attachShadow
1361         https://bugs.webkit.org/show_bug.cgi?id=149187
1362
1363         Reviewed by Antti Koivisto.
1364
1365         * Scripts/webkitperl/FeatureList.pm:
1366
1367 2015-09-15  Aakash Jain  <aakash_jain@apple.com>
1368
1369         Appscale queue status json output lacks bots
1370         https://bugs.webkit.org/show_bug.cgi?id=149194
1371         <rdar://problem/22171089>
1372
1373         Reviewed by Alexey Proskuryakov.
1374
1375         * QueueStatusServer/handlers/queuestatusjson.py:
1376         (QueueStatusJSON._bots): Order the results by date so as to get latest events, this was default in AppEngine.
1377         * QueueStatusServer/index.yaml: Index according to appscale requirements.
1378
1379 2015-09-15  Brent Fulgham  <bfulgham@apple.com>
1380
1381         [Win] Provide a means for viewing the layer tree
1382         https://bugs.webkit.org/show_bug.cgi?id=149165
1383
1384         Reviewed by Simon Fraser.
1385
1386         Update MiniBrowser with a new Debug menu option that will
1387         dump the current layer tree to the debug console.
1388         
1389         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc:
1390         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h:
1391         * MiniBrowser/win/Common.cpp:
1392         (WndProc): Add handler for 'Print Layer Tree' menu option.
1393         * MiniBrowser/win/MiniBrowser.cpp:
1394         (MiniBrowser::printLayerTree): Added Handler.
1395         * MiniBrowser/win/MiniBrowser.h:
1396
1397 2015-09-14  Myles C. Maxfield  <mmaxfield@apple.com>
1398
1399         WebKitTestRunner declarative language setting is broken for iOS
1400         https://bugs.webkit.org/show_bug.cgi?id=149119
1401
1402         Unreviewed.
1403
1404         In all of the patches on webkit.org/b/189669, my patch to get this working on iOS was
1405         lost in the final version which got committed. This simply implements the existing
1406         OS X behavior on iOS.
1407
1408         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
1409         (WTR::InjectedBundle::platformInitialize):
1410
1411 2015-09-14  Dewei Zhu  <dewei_zhu@apple.com>
1412
1413         Unreviewed, add myself to committers list.
1414
1415         * Scripts/webkitpy/common/config/contributors.json:
1416
1417 2015-09-12  Myles C. Maxfield  <mmaxfield@apple.com>
1418
1419         [Cocoa] Allow testing with the system language
1420         https://bugs.webkit.org/show_bug.cgi?id=148671
1421
1422         Reviewed by Anders Carlsson and Alexey Proskuryakov.
1423
1424         React to tests marked with language=lang1,lang2,etc in their header.
1425         Once this information is parsed, pass it to
1426         WKContextConfigurationSetOverrideLanguages().
1427
1428         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
1429         (WTR::InjectedBundle::platformInitialize): Don't clobber the language
1430         list.
1431         * WebKitTestRunner/TestController.cpp:
1432         (WTR::TestController::createWebViewWithOptions): Call
1433         WKContextConfigurationSetOverrideLanguages().
1434         (WTR::updateTestOptionsFromTestHeader): Inspect the language option.
1435         * WebKitTestRunner/TestOptions.h:
1436         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1437         (WTR::PlatformWebView::viewSupportsOptions): Cause a differing language
1438         option to restart the web process.
1439         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1440         (WTR::PlatformWebView::viewSupportsOptions): Ditto.
1441
1442 2015-09-12  Myles C. Maxfield  <mmaxfield@apple.com>
1443
1444         [WKTR] Allow changing the WKContextConfiguration between successive tests
1445         https://bugs.webkit.org/show_bug.cgi?id=148833
1446
1447         Reviewed by Tim Horton.
1448
1449         Previously, we were creating a single WKContext and it lived for the life of the entire test runner.
1450         However, there are certain tests which require specifying options in this object. This patch makes
1451         our existing code for recreating the test runner web view also recreate the WKContext.
1452
1453         As such, our options to the view are now options to the WKContextConfiguration. This patch renames the
1454         class.
1455
1456         * WebKitTestRunner/ContextConfigurationOptions.h: Renamed from Tools/WebKitTestRunner/ViewOptions.h.
1457         * WebKitTestRunner/PlatformWebView.h:
1458         (WTR::PlatformWebView::options):
1459         * WebKitTestRunner/TestController.cpp:
1460         (WTR::TestController::initialize):
1461         (WTR::TestController::generateContextConfiguration):
1462         (WTR::TestController::generatePageConfiguration):
1463         (WTR::TestController::createWebViewWithOptions):
1464         (WTR::TestController::ensureViewSupportsOptionsForTest):
1465         (WTR::updateContextConfigurationOptionsFromTestHeader):
1466         (WTR::TestController::contextConfigurationOptionsForTest):
1467         (WTR::TestController::platformCreateWebView):
1468         (WTR::TestController::platformCreateOtherPage):
1469         (WTR::updateViewOptionsFromTestHeader): Deleted.
1470         (WTR::TestController::viewOptionsForTest): Deleted.
1471         * WebKitTestRunner/TestController.h:
1472         (WTR::TestController::injectedBundlePath):
1473         (WTR::TestController::testPluginDirectory):
1474         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1475         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1476         (WTR::TestController::platformCreateWebView):
1477         (WTR::TestController::platformCreateOtherPage):
1478         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1479         (WTR::PlatformWebView::PlatformWebView):
1480         (WTR::PlatformWebView::viewSupportsOptions):
1481         * WebKitTestRunner/efl/TestControllerEfl.cpp:
1482         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
1483         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
1484         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1485         (WTR::PlatformWebView::PlatformWebView):
1486         (WTR::PlatformWebView::viewSupportsOptions):
1487         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1488         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
1489         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
1490         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1491         (WTR::PlatformWebView::PlatformWebView):
1492         (WTR::PlatformWebView::viewSupportsOptions):
1493         * WebKitTestRunner/ios/TestControllerIOS.mm:
1494         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
1495         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
1496         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1497         (WTR::PlatformWebView::PlatformWebView):
1498         (WTR::PlatformWebView::viewSupportsOptions):
1499         * WebKitTestRunner/mac/TestControllerMac.mm:
1500         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
1501         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
1502
1503 2015-09-11  Michael Saboff  <msaboff@apple.com>
1504
1505         LayoutTestHelper crashes if a color profile isn't set for a 3rd party monitor
1506         https://bugs.webkit.org/show_bug.cgi?id=149083
1507
1508         Reviewed by Alexey Proskuryakov.
1509
1510         Check to make sure that we have a valid factoryProfile CFDictionaryRef before using it.
1511
1512         * DumpRenderTree/mac/LayoutTestHelper.m:
1513         (colorProfileURLForDisplay):
1514
1515 2015-09-11  Saam barati  <sbarati@apple.com>
1516
1517         There should be a defaultSpotCheck-like mode that doesn't run the MaximalFlushInsertionPhase in run-jsc-stress-tests
1518         https://bugs.webkit.org/show_bug.cgi?id=149058
1519
1520         Reviewed by Geoffrey Garen.
1521
1522         * Scripts/run-jsc-stress-tests:
1523
1524 2015-09-10  Commit Queue  <commit-queue@webkit.org>
1525
1526         Unreviewed, rolling out r189595.
1527         https://bugs.webkit.org/show_bug.cgi?id=149052
1528
1529         The tests still fail (Requested by ap on #webkit).
1530
1531         Reverted changeset:
1532
1533         "Spurious output on Windows tests: AQMEIOManager::FindIOUnit:
1534         error -1"
1535         https://bugs.webkit.org/show_bug.cgi?id=142929
1536         http://trac.webkit.org/changeset/189595
1537
1538 2015-09-10  Alexey Proskuryakov  <ap@apple.com>
1539
1540         Spurious output on Windows tests: AQMEIOManager::FindIOUnit: error -1
1541         https://bugs.webkit.org/show_bug.cgi?id=142929
1542
1543         Reviewed by Brent Fulgham.
1544
1545         Silence the logging. We'll track fixing the root cause in Radar.
1546
1547         * Scripts/webkitpy/port/mac.py:
1548         (MacPort.stderr_patterns_to_strip): Added a FIXME.
1549
1550         * Scripts/webkitpy/port/win.py:
1551         (WinPort.logging_patterns_to_strip): Added.
1552
1553 2015-09-09  Andy Estes  <aestes@apple.com>
1554
1555         [iOS] Teach run-webkit-tests how to parse simulator runtimes when version numbers contain a revision
1556         https://bugs.webkit.org/show_bug.cgi?id=149022
1557
1558         Reviewed by Daniel Bates.
1559
1560         Simulator runtime versions can contain a revision number (e.g. 8.4.1), but the regex for matching runtimes
1561         did not account for this.
1562
1563         * Scripts/webkitpy/xcode/simulator.py:
1564         (Simulator): Optionally matched a revision at the end of a runtime version number.
1565         * Scripts/webkitpy/xcode/simulator_unittest.py: Added a test.
1566
1567 2015-09-09  Andy Estes  <aestes@apple.com>
1568
1569         [iOS] Teach run-webkit-tests how to parse `simctl list` when a tvOS SDK is installed
1570         https://bugs.webkit.org/show_bug.cgi?id=149029
1571         <rdar://problem/22432624>
1572
1573         Reviewed by Daniel Bates.
1574
1575         * Scripts/webkitpy/xcode/simulator.py:
1576         (Simulator): Taught to parse tvOS runtimes.
1577         * Scripts/webkitpy/xcode/simulator_unittest.py: Added tests.
1578
1579 2015-09-09  Alexey Proskuryakov  <ap@apple.com>
1580
1581         Fix bit rot on bot watcher's dashboard page
1582         https://bugs.webkit.org/show_bug.cgi?id=149012
1583
1584         Reviewed by Tim Horton.
1585
1586         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1587         The code path used by the metrics page was trying to add properties to an undefined.
1588
1589         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
1590         Silence an expection that would occur when the step has no logs. This should never
1591         happen, but it did (perhaps buildbot was misconfigured for a while).
1592
1593 2015-09-09  Alexey Proskuryakov  <ap@apple.com>
1594
1595         Update LayoutTestRelay xcconfig file.
1596
1597         Rubber-stamped by Dan Bernstein.
1598
1599         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
1600
1601 2015-09-09  Saam barati  <sbarati@apple.com>
1602
1603         DFG should have a debugging option that runs a phase that flushes all locals
1604         https://bugs.webkit.org/show_bug.cgi?id=148916
1605
1606         Reviewed by Filip Pizlo.
1607
1608         * Scripts/run-jsc-stress-tests:
1609
1610 2015-09-09  Commit Queue  <commit-queue@webkit.org>
1611
1612         Unreviewed, rolling out r189530 and r189534.
1613         https://bugs.webkit.org/show_bug.cgi?id=148996
1614
1615         Caused assertion failures on Yosemite (Requested by litherum
1616         on #webkit).
1617
1618         Reverted changesets:
1619
1620         "[WKTR] Allow changing the WKContextConfiguration between
1621         successive tests"
1622         https://bugs.webkit.org/show_bug.cgi?id=148833
1623         http://trac.webkit.org/changeset/189530
1624
1625         "[Cocoa] Fix the tests after r189530"
1626         http://trac.webkit.org/changeset/189534
1627
1628 2015-09-08  Myles C. Maxfield  <mmaxfield@apple.com>
1629
1630         [Cocoa] Fix the tests after r189530
1631
1632         Unreviewed.
1633
1634         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1635         (WTR::initializeWebViewConfiguration):
1636
1637 2015-09-08  Myles C. Maxfield  <mmaxfield@apple.com>
1638
1639         [WKTR] Allow changing the WKContextConfiguration between successive tests
1640         https://bugs.webkit.org/show_bug.cgi?id=148833
1641
1642         Reviewed by Tim Horton.
1643
1644         Previously, we were creating a single WKContext and it lived for the life of the entire test runner.
1645         However, there are certain tests which require specifying options in this object. This patch makes
1646         our existing code for recreating the test runner web view also recreate the WKContext.
1647
1648         As such, our options to the view are now options to the WKContextConfiguration. This patch renames the
1649         class.
1650
1651         * WebKitTestRunner/ContextConfigurationOptions.h: Renamed from Tools/WebKitTestRunner/ViewOptions.h.
1652         * WebKitTestRunner/PlatformWebView.h:
1653         (WTR::PlatformWebView::options):
1654         * WebKitTestRunner/TestController.cpp:
1655         (WTR::TestController::initialize):
1656         (WTR::TestController::generateContextConfiguration):
1657         (WTR::TestController::generatePageConfiguration):
1658         (WTR::TestController::createWebViewWithOptions):
1659         (WTR::TestController::ensureViewSupportsOptionsForTest):
1660         (WTR::updateContextConfigurationOptionsFromTestHeader):
1661         (WTR::TestController::contextConfigurationOptionsForTest):
1662         (WTR::TestController::platformCreateWebView):
1663         (WTR::TestController::platformCreateOtherPage):
1664         (WTR::updateViewOptionsFromTestHeader): Deleted.
1665         (WTR::TestController::viewOptionsForTest): Deleted.
1666         * WebKitTestRunner/TestController.h:
1667         (WTR::TestController::injectedBundlePath):
1668         (WTR::TestController::testPluginDirectory):
1669         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1670         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1671         (WTR::TestController::platformCreateWebView):
1672         (WTR::TestController::platformCreateOtherPage):
1673         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1674         (WTR::PlatformWebView::PlatformWebView):
1675         (WTR::PlatformWebView::viewSupportsOptions):
1676         * WebKitTestRunner/efl/TestControllerEfl.cpp:
1677         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
1678         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
1679         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1680         (WTR::PlatformWebView::PlatformWebView):
1681         (WTR::PlatformWebView::viewSupportsOptions):
1682         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1683         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
1684         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
1685         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1686         (WTR::PlatformWebView::PlatformWebView):
1687         (WTR::PlatformWebView::viewSupportsOptions):
1688         * WebKitTestRunner/ios/TestControllerIOS.mm:
1689         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
1690         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
1691         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1692         (WTR::PlatformWebView::PlatformWebView):
1693         (WTR::PlatformWebView::viewSupportsOptions):
1694         * WebKitTestRunner/mac/TestControllerMac.mm:
1695         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
1696         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
1697
1698 2015-09-08  Daniel Bates  <dabates@apple.com>
1699
1700         [Mac] Expose Enable/Disable Accelerated Drawing in MiniBrowser
1701         https://bugs.webkit.org/show_bug.cgi?id=148980
1702
1703         Reviewed by Alexey Proskuryakov.
1704
1705         Add setting to enable/disable accelerated drawing so as to support testing
1706         this feature in MiniBrowser on Mac.
1707
1708         * MiniBrowser/mac/SettingsController.h:
1709         * MiniBrowser/mac/SettingsController.m:
1710         (-[SettingsController _populateMenu]): Add menu item.
1711         (-[SettingsController validateMenuItem:]): Update setting when menu item is toggled.
1712         (-[SettingsController toggleAcceleratedDrawingEnabled:]): Added.
1713         (-[SettingsController acceleratedDrawingEnabled]): Added.
1714         * MiniBrowser/mac/WK1BrowserWindowController.m:
1715         (-[WK1BrowserWindowController didChangeSettings]): Apply setting in WebKit1.
1716         * MiniBrowser/mac/WK2BrowserWindowController.m:
1717         (-[WK2BrowserWindowController didChangeSettings]): Apply setting in WebKit2.
1718
1719 2015-09-08  Jason Marcell  <jmarcell@apple.com>
1720
1721         Unreviewed. Added myself as a commiter in contributors.json.
1722
1723         * Scripts/webkitpy/common/config/contributors.json:
1724
1725 2015-09-08  Keith Miller  <keith_miller@apple.com>
1726
1727         Unreviewed, added myself to the list of contributors.
1728
1729         * Scripts/webkitpy/common/config/contributors.json:
1730
1731 2015-09-08  Daniel Bates  <dabates@apple.com>
1732
1733         Dashboard: Remove use of z-index for ring overlay; use DOM ordering
1734         https://bugs.webkit.org/show_bug.cgi?id=148921
1735
1736         Reviewed by Alexey Proskuryakov.
1737
1738         The ring image is positioned above the platform icon in markup and we specify the CSS
1739         property z-index for the ring image so that it is painted on top of the platform icon
1740         instead of below it (by DOM ordering). Instead we can take advantage of the transparency
1741         of the ring image, switch the order of these DOM elements and remove the use of the CSS
1742         property z-index to achieve a similar effect.
1743
1744         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
1745         (documentReady): Create the platform icon image element before the ring image such that
1746         the ring image is painted on top of the platform icon.
1747         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1748         (table.queue-grid td.logo img.ring): Removed property z-index.
1749
1750 2015-09-08  Daniel Bates  <dabates@apple.com>
1751
1752         Dashboard: Remove duplicate gear icon data URLs
1753         https://bugs.webkit.org/show_bug.cgi?id=148920
1754
1755         Reviewed by Alexey Proskuryakov.
1756
1757         Currently we duplicate the SVG data URL for the gear icon up to its fill color in the CSS property
1758         background-image associated with each of the three gear icon states: collapsed (.settings), hover
1759         (.settings:hover), and expanded (.settings-visible .settings). Instead we should use the gear icon
1760         as a mask and make use of the CSS background-color to define the fill color for each of these three
1761         states.
1762
1763         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1764         (.settings): Use gear icon as mask and define CSS background-color for collapsed state. 
1765         (.settings:hover): Override CSS background-color for hover state.
1766         (.settings-visible .settings): Override CSS background-color for expanded state.
1767
1768 2015-09-07  Andy Estes  <aestes@apple.com>
1769
1770         [Mac] DebugRelease builds should link against libWebKitSystemInterfaceElCapitan.a on 10.11
1771         https://bugs.webkit.org/show_bug.cgi?id=148946
1772         <rdar://problem/22603981>
1773
1774         Reviewed by Dan Bernstein.
1775
1776         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1777         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1778
1779 2015-09-07  Hunseop Jeong  <hs85.jeong@samsung.com>
1780
1781         [EFL] Many of the css3/device-adapt/* tests failed after r188548.
1782         https://bugs.webkit.org/show_bug.cgi?id=148927
1783
1784         Reviewed by Csaba Osztrogonác.
1785
1786         device-adapt/* tests need the fixedLayout option but useFixedLayout option is
1787         overwritten by updatePlatformSpecificViewOptionsForTest after r188548.
1788
1789         * WebKitTestRunner/TestController.cpp:
1790         (WTR::shouldUseFixedLayout): Removed the unnecessary indentations.
1791         * WebKitTestRunner/efl/TestControllerEfl.cpp:
1792         (WTR::shouldUseFixedLayout): Return true if the test is related with 'device-adapt'.
1793
1794 2015-09-07  Andy Estes  <aestes@apple.com>
1795
1796         Fix the Production build after r189455.
1797
1798         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Somehow I added the All target using the
1799         In-App Purchase template instead of the Aggregate template. Whoops.
1800
1801 2015-09-06  Andy Estes  <aestes@apple.com>
1802
1803         WebKit.xcworkspace should be be able to build iOS platforms
1804         https://bugs.webkit.org/show_bug.cgi?id=148881
1805
1806         Reviewed by Daniel Bates.
1807
1808         Since we don't want to create platform-specific schemes, all projects in the workspace's schemes need to build
1809         for all supported platforms.
1810
1811         * MiniBrowser/Configurations/Base.xcconfig: Included iphoneos and iphonesimulator in SUPPORTED_PLATFORMS.
1812         * MiniBrowser/Configurations/MiniBrowser.xcconfig: Excluded all source files on iOS, and linked Cocoa and WebKit on Mac.
1813         * MiniBrowser/Configurations/MiniBrowserBundle.xcconfig: Ditto.
1814         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Stopped linking frameworks in Link Binaries With Libraries.
1815
1816 2015-09-06  Andy Estes  <aestes@apple.com>
1817
1818         WebKitTestRunner should build for iOS using the default target
1819         https://bugs.webkit.org/show_bug.cgi?id=148918
1820
1821         Reviewed by Daniel Bates.
1822
1823         When WebKitTestRunner was ported to iOS, a separate target (WebKitTestRunnerApp) was created for building the
1824         iOS variant. This is annoying because (1) all tools that invoke xcodebuild need to be taught to build this
1825         non-default target, and (2) a single Xcode scheme cannot be used to build both Mac and iOS variants.
1826
1827         This change adds a new default target (All) and makes it work for both Mac and iOS. Files that were built for
1828         both WebKitTestRunner and WebKitTestRunnerApp are now built in a static library target (WebKitTestRunner (Library)),
1829         and both apps now link this library. Files that are specific to Mac or iOS are excluded on the other platform.
1830         WebKitTestRunnerApp.app (which should be renamed to WebKitTestRunner.app) is skipped when installing on Mac, and
1831         WebKitTestRunner is skipped when installing on iOS.
1832
1833         The target dependency graph now looks like this:
1834
1835             All
1836                 WebKitTestRunnerApp
1837                     WebKitTestRunner (Library)
1838                         WebKitTestRunnerInjectedBundle
1839                             Derived Sources
1840                 WebKitTestRunner
1841                     WebKitTestRunner (Library)
1842                         WebKitTestRunnerInjectedBundle
1843                             Derived Sources
1844
1845         * Scripts/build-webkit: Stopped building the WebKitTestRunnerApp target on iOS.
1846         * Scripts/build-webkittestrunner: Ditto.
1847         * WebKitTestRunner/Configurations/Base.xcconfig: Set SUPPORTED_PLATFORMS to macosx, iphoneos, and iphonesimulator.
1848         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Set INSTALL_PATH here since it is the same for all targets.
1849         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Stopped setting INSTALL_PATH.
1850         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig: Moved frameworks from the build phase to here,
1851         excluded iOS-only files, and skipped installing on iOS.
1852         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: Moved frameworks from the build phase to here,
1853         excluded Mac-only files, and skipped installing on Mac.
1854         * WebKitTestRunner/Configurations/WebKitTestRunnerLibrary.xcconfig: Skipped installing always.
1855         * WebKitTestRunner/Makefile: Stopped building the WebKitTestRunnerApp target on iOS.
1856         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Added new targets, removed frameworks from
1857         Link Binary With Libraries builds phases, moved common files to the WebKitTestRunner (Library) target, and added
1858         new configuration files.
1859
1860 2015-09-05  Joseph Pecoraro  <pecoraro@apple.com>
1861
1862         Web Inspector: Improve prepare-ChangeLog for multiple cases
1863         https://bugs.webkit.org/show_bug.cgi?id=148875
1864
1865         Reviewed by Timothy Hatcher.
1866
1867         * Scripts/prepare-ChangeLog:
1868         (get_function_line_ranges_for_javascript):
1869         - We were ignoring everything inside of an anonymous function expression,
1870           such as (function(){ ... }), which made InjectedScriptSource produce nothing.
1871           Better handle this by inserting a few tweaks.
1872         - Allow method syntax outside of classes as long as they are at the global level.
1873         - Avoid treating "get" and "set" as getter/setter functions in bad contexts.
1874
1875         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests-expected.txt:
1876         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests.js:
1877         (Foo.prototype.method1):
1878         (Foo.prototype.method2):
1879         (Foo.prototype.method3.innerFunction):
1880         (Foo.prototype.method3):
1881         (insideGlobalAnonymousFunctionExpression):
1882         (foo.insideGlobalFunctionExpression):
1883         (IssueWithMapGetAndSet.prototype.method1.nestedFunctionInsideMethod1):
1884         (IssueWithMapGetAndSet.prototype.method1):
1885         (IssueWithMapGetAndSet.prototype.method2):
1886         (IssueWithMapGetAndSet.prototype.method3):
1887         (IssueWithMapGetAndSet):
1888
1889 2015-09-05  Yusuke Suzuki  <utatane.tea@gmail.com>
1890
1891         [ES6] Enable ES6 Module in JSC shell by default
1892         https://bugs.webkit.org/show_bug.cgi?id=148689
1893
1894         Reviewed by Geoffrey Garen.
1895
1896         * Scripts/run-javascriptcore-tests:
1897         (runJSCStressTests):
1898         * Scripts/run-jsc-stress-tests:
1899
1900 2015-09-04  Basile Clement  <basile_clement@apple.com>
1901
1902         Unreviewed, change my email address.
1903
1904         * Scripts/webkitpy/common/config/contributors.json:
1905
1906 2015-09-04  Beth Dakin  <bdakin@apple.com>
1907
1908         Should have a test to make sure links don't navigate after a cancelled force 
1909         click
1910         https://bugs.webkit.org/show_bug.cgi?id=148846
1911
1912         Reviewed by Tim Horton.
1913
1914         New EventSender function for a started then cancelled force click.
1915         * WebKitTestRunner/EventSenderProxy.h:
1916         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
1917         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1918         (WTR::EventSendingController::mouseForceClick):
1919         (WTR::EventSendingController::startAndCancelMouseForceClick):
1920         (WTR::EventSendingController::mouseForceDown):
1921         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
1922         * WebKitTestRunner/TestController.cpp:
1923         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
1924         * WebKitTestRunner/mac/EventSenderProxy.mm:
1925         (WTR::EventSenderProxy::mouseForceClick):
1926         (WTR::EventSenderProxy::startAndCancelMouseForceClick):
1927         (WTR::EventSenderProxy::mouseForceDown):
1928         (WTR::EventSenderProxy::mouseMoveTo):
1929
1930 2015-09-04  Tim Horton  <timothy_horton@apple.com>
1931
1932         Add a test for r179736 (programmatic navigation during swipe causing a crash)
1933         https://bugs.webkit.org/show_bug.cgi?id=148830
1934
1935         Reviewed by Beth Dakin.
1936
1937         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1938         (WTR::InjectedBundle::beginTesting):
1939         Make sure that TestRunner callbacks don't leak between tests!
1940
1941 2015-09-04  Anders Carlsson  <andersca@apple.com>
1942
1943         It should be possible to pass relative HTTP test paths to DumpRenderTree
1944         https://bugs.webkit.org/show_bug.cgi?id=148825
1945         <rdar://problem/22583866>
1946
1947         Reviewed by Tim Horton.
1948
1949         Convert the path to an absolute path if needed.
1950
1951         * DumpRenderTree/mac/DumpRenderTree.mm:
1952         (computeTestURL):
1953
1954 2015-09-04  Jason Marcell  <jmarcell@apple.com>
1955
1956         Fix Swift unit tests for prepare-ChangeLog.
1957         https://bugs.webkit.org/show_bug.cgi?id=148817
1958
1959         Reviewed by Alexey Proskuryakov.
1960
1961         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/swift_unittests-expected.txt: Fixed
1962         Swift unit tests for prepare-ChangeLog.
1963
1964 2015-09-04  Lucas Forschler  <lforschler@apple.com>
1965
1966         Modifications to the webkit-nightly logic.
1967         
1968         * WebKitLauncher/WebKitNightlyEnablerSparkle.m:
1969         (updateAlertPanel):
1970         * WebKitLauncher/main.m:
1971         (displayErrorAndQuit):
1972
1973 2015-09-04  Beth Dakin  <bdakin@apple.com>
1974
1975         Speculative build fix.
1976
1977         * WebKitTestRunner/mac/EventSenderProxy.mm:
1978
1979 2015-09-04  Brian Burg  <bburg@apple.com>
1980
1981         Web Inspector: InspectorController should support multiple frontend channels
1982         https://bugs.webkit.org/show_bug.cgi?id=148538
1983
1984         Reviewed by Joseph Pecoraro.
1985
1986         InspectorClients must explicitly disconnect their frontend channel(s) from the
1987         inspected page's InspectorController.
1988
1989         To make this possible, DumpRenderTree should not destroy non-primary views until
1990         it has tried to close any abandoned Web Inspector instances. Performing teardown
1991         in the reverse order prevents disconnection of the frontend channel because that
1992         prematurely destroys the inspector frontend client.
1993
1994         * DumpRenderTree/mac/DumpRenderTree.mm:
1995         (runTest):
1996         * DumpRenderTree/win/DumpRenderTree.cpp:
1997         (runTest):
1998
1999 2015-09-04  Beth Dakin  <bdakin@apple.com>
2000
2001         Need to be able to test default behaviors on force click
2002         https://bugs.webkit.org/show_bug.cgi?id=148758
2003
2004         Reviewed by Tim Horton.
2005
2006         This patch adds a new eventSender method to do a full, completed force click, 
2007         and it re-works all of the existing force methods to dispatch their events in 
2008         such a way that they will trigger the NSImmediateAction gesture recognizer. 
2009         To do this, first we need to send the events to the app rather than straight 
2010         to the view, and also needed to tweak some state and send the events in a 
2011         delayed fashion.
2012
2013         New public function mouseForceClick() and private helper functions to make 
2014         NSEvents.
2015         * WebKitTestRunner/EventSenderProxy.h:
2016
2017         New public function mouseForceClick().
2018         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
2019         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2020         (WTR::EventSendingController::mouseMoveTo):
2021         (WTR::EventSendingController::mouseForceClick):
2022         (WTR::EventSendingController::mouseForceDown):
2023         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
2024         * WebKitTestRunner/TestController.cpp:
2025         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
2026
2027         initPressureEventAtLocation needs to take a stageTransition and a window.
2028         * WebKitTestRunner/mac/EventSenderProxy.mm:
2029         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
2030         (-[EventSenderSyntheticEvent stageTransition]):
2031         (-[EventSenderSyntheticEvent timestamp]):
2032         (-[EventSenderSyntheticEvent _cgsEventRecord]):
2033         (-[EventSenderSyntheticEvent window]):
2034
2035         In order to enter the gesture recognizer, we need to start with a mouse down 
2036         that has a NSEventMaskPressure modifier.
2037         (WTR::EventSenderProxy::sendMouseDownToStartPressureEvents):
2038
2039         This ensures that the events queue properly for the force monitor in AppKit.
2040         (WTR::spinRunLoopForForce):
2041
2042          We need to start the pressure change events with a began.
2043         (WTR::EventSenderProxy::beginPressureEvent):
2044
2045         These functions can be used to create the NSEvent for a pressure change every 
2046         time we need one.
2047         (WTR::EventSenderProxy::pressureChangeEvent):
2048
2049         Send the right series of events to emulate a full, completed force click.
2050         (WTR::EventSenderProxy::mouseForceClick):
2051
2052         Use all of the new things for these existing functions.
2053         (WTR::EventSenderProxy::mouseForceDown):
2054         (WTR::EventSenderProxy::mouseForceUp):
2055         (WTR::EventSenderProxy::mouseForceChanged):
2056
2057         Set NSFakeForceTouchDevice to YES.
2058         * WebKitTestRunner/mac/main.mm:
2059         (setDefaultsToConsistentValuesForTesting):
2060
2061 2015-09-04  Jason Marcell  <jmarcell@apple.com>
2062
2063         prepare-ChangeLog needs to know how to parse Swift files.
2064         https://bugs.webkit.org/show_bug.cgi?id=148784
2065         <rdar://problem/22510062>
2066
2067         Reviewed by Darin Adler.
2068
2069         * Scripts/prepare-ChangeLog:
2070         (get_function_line_ranges): Added entry for get_function_line_ranges_for_swift.
2071         (get_function_line_ranges_for_swift): Added function that knows how to parse Swift code.
2072         (parseSwiftFunctionArgs): Added function that knows how to parse Swift function arguments.
2073         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl: Added.
2074         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/swift_unittests-expected.txt: Ditto.
2075         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/swift_unittests.swift: Ditto.
2076         (freeFunction): Ditto.
2077         (MyClass.function): Ditto.
2078         (MyClass.functionWithArgument(_:)): Ditto.
2079         (MyClass.functionWithMoreArguments(_:arg2:)): Ditto.
2080         (MyClass.functionWithNamedFirstArgument(argument:)): Ditto.
2081         (MyClass.functionWithNamedFirstAndSecondArgument(first:second:)): Ditto.
2082         (MyClass.classFunction): Ditto.
2083         (MyClass.readWriteComputedVariable): Ditto.
2084         (MyClass.readOnlyComputedVariable): Ditto.
2085
2086 2015-09-04  Ryosuke Niwa  <rniwa@webkit.org>
2087
2088         Import css/css-color-3
2089         https://bugs.webkit.org/show_bug.cgi?id=148803
2090
2091         Reviewed by Chris Dumez.
2092
2093         Fixed a bug that the imported reference files used the same extention as tests.
2094         This would result in parsing errors if the tests were XML and references were HTML and vice versa.
2095
2096         * Scripts/webkitpy/w3c/test_importer.py:
2097         (TestImporter.find_importable_tests):
2098
2099 2015-09-03  Commit Queue  <commit-queue@webkit.org>
2100
2101         Unreviewed, rolling out r189338.
2102         https://bugs.webkit.org/show_bug.cgi?id=148785
2103
2104         Caused tons of crashes (Requested by cdumez on #webkit).
2105
2106         Reverted changeset:
2107
2108         "Web Inspector: InspectorController should support multiple
2109         frontend channels"
2110         https://bugs.webkit.org/show_bug.cgi?id=148538
2111         http://trac.webkit.org/changeset/189338
2112
2113 2015-09-03  Brian Burg  <bburg@apple.com>
2114
2115         Web Inspector: InspectorController should support multiple frontend channels
2116         https://bugs.webkit.org/show_bug.cgi?id=148538
2117
2118         Reviewed by Joseph Pecoraro.
2119
2120         InspectorClients must explicitly disconnect their frontend channel(s) from the
2121         inspected page's InspectorController.
2122
2123         To make this possible, DumpRenderTree should not destroy non-primary views until
2124         it has tried to close any abandoned Web Inspector instances. Performing teardown
2125         in the reverse order prevents disconnection of the frontend channel because that
2126         prematurely destroys the inspector frontend client.
2127
2128         * DumpRenderTree/mac/DumpRenderTree.mm:
2129         (runTest):
2130         * DumpRenderTree/win/DumpRenderTree.cpp:
2131         (runTest):
2132
2133 2015-09-03  Timothy Hatcher  <timothy@apple.com>
2134
2135         Update WebKit nightly icon to be more like Safari
2136         https://bugs.webkit.org/show_bug.cgi?id=148768
2137
2138         Reviewed by Joseph Pecoraro.
2139
2140         * WebKitLauncher/webkit.icns:
2141
2142 2015-09-03  Geoffrey Garen  <ggaren@apple.com>
2143
2144         JavaScriptCore should have some ES6 conformance tests
2145         https://bugs.webkit.org/show_bug.cgi?id=148771
2146
2147         Reviewed by Chris Dumez.
2148
2149         * Scripts/run-javascriptcore-tests:
2150         (runJSCStressTests): Added es6 as a test suite.
2151
2152         * Scripts/run-jsc-stress-tests: Added es6 as a test suite.
2153
2154         Some of these tests currently fail, so I also added a way to expect
2155         failure for now. We'll migrate failing tests to expected passes as we
2156         fix them.
2157
2158 2015-09-03  Tim Horton  <timothy_horton@apple.com>
2159
2160         Add a test for swipe-start hysteresis
2161         https://bugs.webkit.org/show_bug.cgi?id=148756
2162
2163         Reviewed by Anders Carlsson.
2164
2165         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2166         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2167         (WTR::cacheTestRunnerCallback):
2168         (WTR::TestRunner::clearTestRunnerCallbacks):
2169         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2170         Make sure that we log if a client tries to install a callback twice
2171         (since we use .add, the second call would not work).
2172
2173         Also, add clearTestRunnerCallbacks so tests can swap out installed
2174         callbacks.
2175
2176 2015-09-03  Anders Carlsson  <andersca@apple.com>
2177
2178         DumpRenderTree should automatically compute HTTP URLs for HTTP tests
2179         https://bugs.webkit.org/show_bug.cgi?id=148746
2180         rdar://problem/22568073
2181
2182         Reviewed by Tim Horton.
2183
2184         * DumpRenderTree/mac/DumpRenderTree.mm:
2185         (computeTestURL):
2186         Compute the test URL from the passed in path or URL. Special-case paths that contain /LayoutTests/http/tests. 
2187
2188         (runTest):
2189         Call computeTestURL.
2190
2191         (testPathFromURL):
2192         Get rid of this; computeTestURL does this for us now.
2193
2194         * Scripts/webkitpy/port/driver.py:
2195         (Driver._command_from_driver_input):
2196         Don't convert HTTP test paths to URLS before passing them to DumpRenderTree on Mac. That's handled by DRT itself now.
2197
2198 2015-09-03  Tim Horton  <timothy_horton@apple.com>
2199
2200         Swipe tests fail on Mavericks
2201         https://bugs.webkit.org/show_bug.cgi?id=148752
2202
2203         Reviewed by Beth Dakin.
2204
2205         * WebKitTestRunner/mac/EventSenderProxy.mm:
2206
2207 2015-09-03  Tim Horton  <timothy_horton@apple.com>
2208
2209         Fix the 32-bit build
2210
2211         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2212         (WTR::PlatformWebView::setNavigationGesturesEnabled):
2213
2214 2015-09-03  Tim Horton  <timothy_horton@apple.com>
2215
2216         Remove some logging that wasn't meant to be in the tree
2217
2218         * WebKitTestRunner/mac/EventSenderProxy.mm:
2219         (WTR::EventSenderProxy::swipeGestureWithWheelAndMomentumPhases):
2220
2221 2015-09-03  Tim Horton  <timothy_horton@apple.com>
2222
2223         [Mac] Add support for testing swipes
2224         https://bugs.webkit.org/show_bug.cgi?id=148700
2225
2226         Reviewed by Beth Dakin.
2227
2228         * WebKitTestRunner/EventSenderProxy.h:
2229         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
2230         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2231         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2232         (WTR::cgEventPhaseFromString):
2233         (WTR::cgEventMomentumPhaseFromString):
2234         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
2235         (WTR::EventSendingController::swipeGestureWithWheelAndMomentumPhases):
2236         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
2237         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2238         (WTR::InjectedBundle::didReceiveMessageToPage):
2239         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2240         (WTR::TestRunner::installDidBeginSwipeCallback):
2241         (WTR::TestRunner::installWillEndSwipeCallback):
2242         (WTR::TestRunner::installDidEndSwipeCallback):
2243         (WTR::TestRunner::installDidRemoveSwipeSnapshotCallback):
2244         (WTR::TestRunner::callDidBeginSwipeCallback):
2245         (WTR::TestRunner::callWillEndSwipeCallback):
2246         (WTR::TestRunner::callDidEndSwipeCallback):
2247         (WTR::TestRunner::callDidRemoveSwipeSnapshotCallback):
2248         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2249         * WebKitTestRunner/TestController.cpp:
2250         (WTR::TestController::createOtherPage):
2251         (WTR::TestController::createWebViewWithOptions):
2252         (WTR::TestController::didReceiveMessageFromInjectedBundle):
2253         (WTR::TestController::didBeginNavigationGesture):
2254         (WTR::TestController::willEndNavigationGesture):
2255         (WTR::TestController::didEndNavigationGesture):
2256         (WTR::TestController::didRemoveNavigationGestureSnapshot):
2257         * WebKitTestRunner/TestController.h:
2258         * WebKitTestRunner/TestInvocation.cpp:
2259         (WTR::TestInvocation::didBeginSwipe):
2260         (WTR::TestInvocation::willEndSwipe):
2261         (WTR::TestInvocation::didEndSwipe):
2262         (WTR::TestInvocation::didRemoveSwipeSnapshot):
2263         * WebKitTestRunner/TestInvocation.h:
2264         Add callbacks when navigation gestures didBegin/willEnd/didEnd, and
2265         when the snapshot is removed.
2266
2267         Add swipeGestureWithWheelAndMomentumPhases, just like the equivalent
2268         mouseScrollBy function.
2269
2270         * WebKitTestRunner/mac/EventSenderProxy.mm:
2271         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:phase:time:eventNumber:]):
2272         (-[EventSenderSyntheticEvent type]):
2273         (-[EventSenderSyntheticEvent subtype]):
2274         (-[EventSenderSyntheticEvent locationInWindow]):
2275         (-[EventSenderSyntheticEvent location]):
2276         (-[EventSenderSyntheticEvent momentumPhase]):
2277         (-[EventSenderSyntheticEvent _isTouchesEnded]):
2278         (-[EventSenderSyntheticEvent _cgsEventRecord]):
2279         Rename EventSenderPressureEvent to EventSenderSyntheticEvent and add some
2280         more adjustable values.
2281
2282         (WTR::EventSenderProxy::mouseForceDown):
2283         (WTR::EventSenderProxy::mouseForceUp):
2284         (WTR::EventSenderProxy::mouseForceChanged):
2285         Adopt EventSenderSyntheticEvent.
2286
2287         (WTR::nsEventPhaseFromCGEventPhase):
2288         (WTR::EventSenderProxy::swipeGestureWithWheelAndMomentumPhases):
2289         Make use of EventSenderSyntheticEvent to synthesize swipe gesture events.
2290
2291         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2292         (WTR::PlatformWebView::PlatformWebView):
2293         Enable swipe.
2294
2295 2015-09-03  Myles C. Maxfield  <mmaxfield@apple.com>
2296
2297         [WK2] Allow tagging tests with metadata which needs to be known at web process creation time
2298         https://bugs.webkit.org/show_bug.cgi?id=148723
2299
2300         Reviewed by Anders Carlsson.
2301
2302         * WebKitTestRunner/TestController.cpp:
2303         (WTR::testPath):
2304         (WTR::updateViewOptionsFromTestHeader):
2305         (WTR::TestController::viewOptionsForTest):
2306
2307 2015-09-03  Lucas Forschler  <lforschler@apple.com>
2308
2309         Test commit.
2310
2311 2015-09-02  Tim Horton  <timothy_horton@apple.com>
2312
2313         Add a modern API way to know that the navigation gesture snapshot was removed, for WebKitTestRunner
2314         https://bugs.webkit.org/show_bug.cgi?id=148693
2315
2316         Reviewed by Anders Carlsson.
2317
2318         * WebKitTestRunner/TestController.cpp:
2319         (WTR::TestController::createOtherPage):
2320         (WTR::TestController::createWebViewWithOptions):
2321
2322 2015-09-02  Carlos Garcia Campos  <cgarcia@igalia.com>
2323
2324         REGRESSION(r188548): Some tests crash after r188548 because injected bundle messages are received after the test finishes
2325         https://bugs.webkit.org/show_bug.cgi?id=148529
2326
2327         Reviewed by Darin Adler.
2328
2329         When there are pending EventSender messages after a test finishes,
2330         they could be processed in the main loop started by the
2331         resetStateToConsistentValues(), but the old EventSender has been
2332         replaced by a new one at that point. The new Eventsender can crash
2333         when processing messages that were sent to the old one. To avoid
2334         this, we return early when receiving an EventSender message and
2335         the TestController state is not RunningTest.
2336
2337         * WebKitTestRunner/TestController.cpp:
2338         (WTR::TestController::didReceiveKeyDownMessageFromInjectedBundle):
2339         (WTR::TestController::didReceiveMessageFromInjectedBundle):
2340
2341 2015-09-02  Carlos Garcia Campos  <cgarcia@igalia.com>
2342
2343         REGRESSION(r188548): TestController state is Resseting while tests are running after r188548
2344         https://bugs.webkit.org/show_bug.cgi?id=148528
2345
2346         Reviewed by Darin Adler.
2347
2348         Before r188548 resetStateToConsistentValues() was called in
2349         TestController::run(), before tests are run, but now it's called
2350         for every test in TestInvocation::invoke(), after m_status has
2351         changed to RunningTest.
2352
2353         * WebKitTestRunner/TestController.cpp:
2354         (WTR::TestController::resetStateToConsistentValues): Use
2355         TemporaryChange to reset m_state ot its previous value after reset
2356         is done.
2357
2358 2015-08-31  Jason Marcell  <jmarcell@apple.com>
2359
2360         Modify prepare-Changelog to be aware of files that are marked as tests as well as files
2361         that are marked as requiring corresponding tests.
2362         https://bugs.webkit.org/show_bug.cgi?id=148498
2363         <rdar://problem/21555314>
2364
2365         Reviewed by Dan Bernstein and David Kilzer.
2366
2367         * Scripts/prepare-ChangeLog: Added "attributeCache" to cache Subversion properties in order to
2368         simulate Git's attribute behevaior.
2369         (main): Added "requiresTests" array to contain files that require tests.
2370         (generateNewChangeLogs): Checks "requiresTests" array to determine whether to inject "tests"
2371         section in ChangeLog.
2372         (attributeCommand): Queries a given file for a given Git attribute value. If using Subversion,
2373         however, we check if the file or any containing folder has the given property set to "1" and
2374         return 1 if so; return 0 otherwise.
2375         (generateFileList): Adds files to "requiresTests" array if Git attribute is set to "1". Also
2376         adds files to "addedRegressionTests" array if "test" attribute is set to "1".
2377
2378 2015-08-26  Andy Estes  <aestes@apple.com>
2379
2380         [Content Filtering] Determine navigation and content policy before continuing to filter a load
2381         https://bugs.webkit.org/show_bug.cgi?id=148506
2382
2383         Reviewed by Brady Eidson.
2384
2385         Added download API tests covering every decision and decision point.
2386         Removed _WKDownload.AsynchronousDownloadPolicy in favor of these new tests.
2387
2388         * TestWebKitAPI/Configurations/Base.xcconfig: Added $(BUILT_PRODUCTS_DIR)/WebCoreTestSupport to the header search path.
2389         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Removed it from here.
2390         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParametersPlugIn.mm:
2391         (-[BundleParametersPlugIn observeValueForKeyPath:ofObject:change:context:]): Called -valueForKeyPath:, which
2392         returns an id, instead of -valueForKey:, which always returns an NSString even if the object is of another type.
2393         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm: Added a class that can send a MockContentFilter
2394         decision and decision point as a bundle parameter.
2395         (+[MockContentFilterEnabler supportsSecureCoding]):
2396         (-[MockContentFilterEnabler copyWithZone:]):
2397         (-[MockContentFilterEnabler initWithCoder:]):
2398         (-[MockContentFilterEnabler initWithDecision:decisionPoint:]):
2399         (-[MockContentFilterEnabler encodeWithCoder:]):
2400         (configurationWithContentFilterSettings): Added a helper function to create a WKWebViewConfiguration with MockConentFilter settings.
2401         (TEST): Renamed ContentFiltering.ServerRedirect to ContentFiltering.URLAfterServerRedirect.
2402         (-[BecomeDownloadDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Decided _WKNavigationResponsePolicyBecomeDownload.
2403         (-[BecomeDownloadDelegate webView:didFailProvisionalNavigation:withError:]): Set isDone to true.
2404         (-[BecomeDownloadDelegate webView:didFinishNavigation:]): Ditto.
2405         (-[ContentFilteringDownloadDelegate _downloadDidStart:]): Set downloadDidStart to true.
2406         (downloadTest): Added a helper function to test downloads with a given decision and decision point.
2407         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm: Added a corresponding bundle class that decodes
2408         the MockContentFilter decision and decision point, and sets these values in the MockContentFilterSettings
2409         singleton. This class is duplicated in the bundle to prevent TestWebKitAPI from having to link to WebCoreTestSupport.
2410         (+[MockContentFilterEnabler supportsSecureCoding]):
2411         (-[MockContentFilterEnabler copyWithZone:]):
2412         (-[MockContentFilterEnabler initWithCoder:]):
2413         (-[MockContentFilterEnabler dealloc]):
2414         (-[MockContentFilterEnabler encodeWithCoder:]):
2415         (-[ContentFilteringPlugIn webProcessPlugIn:initializeWithObject:]): Start observing changes to the MockContentFilterEnabler key path.
2416         (-[ContentFilteringPlugIn dealloc]): Stop observing.
2417         (-[ContentFilteringPlugIn observeValueForKeyPath:ofObject:change:context:]): Store a MockContentFilterEnabler in _contentFilterEnabler.
2418         (+[ServerRedirectPlugIn initialize]): Deleted.
2419         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2420         (-[AsynchronousDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
2421         (-[AsynchronousDownloadDelegate _downloadDidStart:]): Deleted.
2422         (TEST): Deleted.
2423
2424 2015-08-31  Filip Pizlo  <fpizlo@apple.com>
2425
2426         Skip slow lock tests on Windows/debug
2427         https://bugs.webkit.org/show_bug.cgi?id=148643
2428
2429         Reviewed by Alexey Proskuryakov.
2430
2431         The lock tests simulate a critical section by doing some floating point math, and then either
2432         make those critical sections very long or invoke them many times. This appears to be
2433         particularly slow on Windows in debug mode, maybe because Visual Studio's debug build makes
2434         that kind of computation slow.
2435
2436         These tests are almost as useful in release as they are in debug, so it's probably better to
2437         just skip the in debug on platforms where this causes timeouts.
2438
2439         * TestWebKitAPI/Tests/WTF/Lock.cpp:
2440         (TestWebKitAPI::runLockTest):
2441         (TestWebKitAPI::skipSlow):
2442         (TestWebKitAPI::TEST):
2443
2444 2015-08-29  Chris Fleizach  <cfleizach@apple.com>
2445
2446         AX: When navigating the elements of a scrollable element with VoiceOver, the scrollTop() position of the element does not permanently change
2447         https://bugs.webkit.org/show_bug.cgi?id=125720
2448
2449         Reviewed by Daniel Bates.
2450
2451         Add support for scrollToMakeVisibleWithSubFocus and scrollToGlobalPoint.
2452
2453         * DumpRenderTree/AccessibilityUIElement.cpp:
2454         (pressCallback):
2455         (scrollToMakeVisibleWithSubFocusCallback):
2456         (scrollToGlobalPointCallback):
2457         (scrollToMakeVisibleCallback):
2458         (AccessibilityUIElement::getJSClass):
2459         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2460         (AccessibilityUIElement::scrollToMakeVisible):
2461         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
2462         (AccessibilityUIElement::scrollToGlobalPoint):
2463         (AccessibilityUIElement::selectedTextRange):
2464         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2465         (AccessibilityUIElement::AccessibilityUIElement):
2466         (AccessibilityUIElement::mathPrescriptsDescription):
2467         (AccessibilityUIElement::scrollToMakeVisible):
2468         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
2469         (AccessibilityUIElement::scrollToGlobalPoint):
2470         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2471         (WTR::AccessibilityUIElement::isTextMarkerValid):
2472         (WTR::AccessibilityUIElement::textMarkerForIndex):
2473         (WTR::AccessibilityUIElement::scrollToMakeVisible):
2474         (WTR::AccessibilityUIElement::scrollToGlobalPoint):
2475         (WTR::AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
2476         (WTR::AccessibilityUIElement::supportedActions):
2477         (WTR::AccessibilityUIElement::mathPostscriptsDescription):
2478         (WTR::AccessibilityUIElement::mathPrescriptsDescription):
2479         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2480         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2481         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2482         (WTR::AccessibilityUIElement::scrollToMakeVisible):
2483         (WTR::AccessibilityUIElement::scrollToGlobalPoint):
2484         (WTR::AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
2485         (WTR::AccessibilityUIElement::selectedTextRange):
2486         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2487         (WTR::AccessibilityUIElement::scrollToMakeVisible):
2488         (WTR::AccessibilityUIElement::scrollToGlobalPoint):
2489         (WTR::AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
2490         (WTR::AccessibilityUIElement::selectedTextRange):
2491
2492 2015-08-28  Timothy Horton  <timothy_horton@apple.com>
2493
2494         Add a mysteriously nonproblematic missing comma.
2495
2496         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2497         (TestExpectationParser._collect_matching_tests):
2498         (TestExpectationParser):
2499
2500 2015-08-28  Timothy Horton  <timothy_horton@apple.com>
2501
2502         Remove an old temporary script that has served its purpose
2503
2504         * Scripts/convert-test-expectations: Removed.
2505
2506 2015-08-28  Jer Noble  <jer.noble@apple.com>
2507
2508         [iOS] Add WebKit/WebKit2 settings to control automatic data loading
2509         https://bugs.webkit.org/show_bug.cgi?id=148579
2510
2511         Reviewed by Anders Carlsson.
2512
2513         In DumpRenderTree, set the new mediaDataLoadsAutomatically preference to YES.
2514
2515         In WebKitTestRunner, do the same for the new _mediaDataLoadsAutomatically configuration property,
2516         and also set the existing requiresUserActionForMediaPlayback configuration property to NO.
2517
2518         * DumpRenderTree/mac/DumpRenderTree.mm:
2519         (resetWebPreferencesToConsistentValues):
2520         (resetWebViewToConsistentStateBeforeTesting): 
2521         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2522         (WTR::initializeWebViewConfiguration):
2523
2524 2015-08-28  Alexey Proskuryakov  <ap@apple.com>
2525
2526         Fix run-webkit-tests --additional-env-var="DYLD_INSERT_LIBRARIES=..."
2527         https://bugs.webkit.org/show_bug.cgi?id=148592
2528
2529         Reviewed by Tim Horton.
2530
2531         * Scripts/webkitpy/port/base.py:
2532         (Port.to.setup_environ_for_server):
2533         (Port.to):
2534         (Port.to._append_value_colon_separated):
2535         (Port.to.show_results_html_file):
2536         * Scripts/webkitpy/port/ios.py:
2537         (IOSSimulatorPort.setup_environ_for_server):
2538         * Scripts/webkitpy/port/mac.py:
2539         (MacPort.setup_environ_for_server):
2540
2541 2015-08-28  Filip Pizlo  <fpizlo@apple.com>
2542
2543         LICM should be sound even if the CFG has changed
2544         https://bugs.webkit.org/show_bug.cgi?id=148259
2545
2546         Reviewed by Benjamin Poulain.
2547
2548         Add a utility for creating tests that set some uncommon option.
2549
2550         * Scripts/run-jsc-stress-tests:
2551
2552 2015-08-28  Brent Fulgham  <bfulgham@apple.com>
2553
2554         [Win] Unreviewed EWS correction.
2555
2556         * EWSTools/start-queue-win.sh: Update settings to point to VS2015.
2557
2558 2015-08-28  Jer Noble  <jer.noble@apple.com>
2559
2560         [iOS] Make the AllowsInlineMediaPlayback preference work in WebKit / WebKit2.
2561         https://bugs.webkit.org/show_bug.cgi?id=147512
2562
2563         Reviewed by Anders Carlsson.
2564
2565         Set the value of WebKitAllowsInlineMediaPlayback / WKPreferencesSetMediaPlaybackAllowsInline()
2566         to a consistent (true) value.
2567
2568         * DumpRenderTree/mac/DumpRenderTree.mm:
2569         (setDefaultsToConsistentValuesForTesting):
2570         * WebKitTestRunner/TestController.cpp:
2571         (WTR::TestController::resetPreferencesToConsistentValues):
2572
2573 2015-08-28  Tim Horton  <timothy_horton@apple.com>
2574
2575         Add navigation gesture callbacks to WKPageNavigationClient
2576         https://bugs.webkit.org/show_bug.cgi?id=148568
2577         <rdar://problem/22371346>
2578
2579         Reviewed by Anders Carlsson.
2580
2581         * WebKitTestRunner/TestController.cpp:
2582         (WTR::TestController::createOtherPage):
2583         (WTR::TestController::createWebViewWithOptions):
2584         Add some zeroes.
2585
2586 2015-08-28  Alexey Proskuryakov  <ap@apple.com>
2587
2588         [Mac] kill-old-processes should kill more processes
2589         https://bugs.webkit.org/show_bug.cgi?id=148577
2590
2591         Reviewed by Tim Horton.
2592
2593         * BuildSlaveSupport/kill-old-processes:
2594
2595 2015-08-28  Jason Marcell  <jmarcell@apple.com>
2596
2597         The status message for combined builder queues should say "all builds succeeded" if everything
2598         built correctly.
2599         https://bugs.webkit.org/show_bug.cgi?id=148535
2600
2601         Reviewed by David Kilzer and Alexey Proskuryakov.
2602
2603         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
2604         (BuildbotCombinedQueueView.prototype.update): Make status message for combined builder queues
2605         say "all builds succeeded" if everything built correctly.
2606
2607 2015-08-28  Carlos Garcia Campos  <cgarcia@igalia.com>
2608
2609         [GTK] Simplify the internal API to create a WebView
2610         https://bugs.webkit.org/show_bug.cgi?id=148570
2611
2612         Reviewed by Žan Doberšek.
2613
2614         * TestWebKitAPI/PlatformWebView.h: Add initialize method for GTK+ too.
2615         * TestWebKitAPI/gtk/PlatformWebViewGtk.cpp:
2616         (TestWebKitAPI::PlatformWebView::PlatformWebView): Implement all
2617         PlatformWebView constructors that end up calling initialize with a PageConfiguration.
2618         (TestWebKitAPI::PlatformWebView::initialize): Create the WebView
2619         passing the received PageConfiguration.
2620         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2621         (WTR::PlatformWebView::PlatformWebView): Create the WebView
2622         passing the received PageConfiguration.
2623
2624 2015-08-27  Aakash Jain  <aakash_jain@apple.com>
2625
2626         iOS Simulator API tests fails as Simulator is not running
2627         https://bugs.webkit.org/show_bug.cgi?id=148501
2628         rdar://problem/22447525
2629
2630         Reviewed by Daniel Bates.
2631
2632         This change is a workaround for <rdar://problem/22388812>.
2633
2634          * Scripts/run-api-tests: Launch the iOS Simulator before starting the API Tests
2635          and quit it on program termination when running tests on the iOS port.
2636          * Scripts/webkitdirs.pm: Store string "For WebKit Development" in constant
2637          SIMULATOR_DEVICE_SUFFIX_FOR_WEBKIT_DEVELOPMENT to make it consistently reusable.
2638
2639 2015-08-27  Alex Christensen  <achristensen@webkit.org>
2640
2641         Make DLLLauncherMain executables dependent on dll
2642         https://bugs.webkit.org/show_bug.cgi?id=148548
2643
2644         Reviewed by Brent Fulgham.
2645
2646         * DumpRenderTree/CMakeLists.txt:
2647         * DumpRenderTree/PlatformWin.cmake:
2648         * MiniBrowser/win/CMakeLists.txt:
2649         * TestWebKitAPI/CMakeLists.txt:
2650         * TestWebKitAPI/PlatformWin.cmake:
2651
2652 2015-08-27  Lucas Forschler  <lforschler@apple.com>
2653
2654         Remove Mac slaves 188/189 after being replaced with 400/401.
2655         
2656         Unreviewed.
2657         
2658         * BuildSlaveSupport/build.webkit.org-config/config.json:
2659
2660 2015-08-27  Lucas Forschler  <lforschler@apple.com>
2661
2662         Add two bots to the Mac Yosemite queue.
2663         This is to eventually replace bots188/189, which will be removed after 400/401 are vetted.
2664         
2665         Unreviewed.
2666         
2667         * BuildSlaveSupport/build.webkit.org-config/config.json:
2668
2669 2015-08-27  Alex Christensen  <achristensen@webkit.org>
2670
2671         [Win CMake] Fix incremental build after r188673
2672         https://bugs.webkit.org/show_bug.cgi?id=148539
2673
2674         Reviewed by Brent Fulgham.
2675
2676         * TestWebKitAPI/PlatformWin.cmake:
2677         Copy forwarding headers from WebCore before building in case that was not yet done.
2678         It used to be done when running CMake, but now it's a build step.
2679
2680 2015-08-27  Nan Wang  <n_wang@apple.com>
2681
2682         AX: Fix accessibility/select-element-at-index.html test
2683         https://bugs.webkit.org/show_bug.cgi?id=148516
2684
2685         Reviewed by Chris Fleizach.
2686
2687         Implemented setSelectedChildAtIndex and removeSelectionAtIndex for mac.
2688
2689         * DumpRenderTree/AccessibilityUIElement.cpp:
2690         (setSelectedChildCallback):
2691         (setSelectedChildAtIndexCallback):
2692         (removeSelectionAtIndexCallback):
2693         (elementAtPointCallback):
2694         (sentenceAtOffsetCallback):
2695         (stringForSelectionCallback):
2696         (AccessibilityUIElement::getJSClass):
2697         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2698         (AccessibilityUIElement::setSelectedChild):
2699         (AccessibilityUIElement::setSelectedChildAtIndex):
2700         (AccessibilityUIElement::removeSelectionAtIndex):
2701         (AccessibilityUIElement::accessibilityValue):
2702         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2703         (WTR::AccessibilityUIElement::wordAtOffset):
2704         (WTR::AccessibilityUIElement::lineAtOffset):
2705         (WTR::AccessibilityUIElement::sentenceAtOffset):
2706         (WTR::AccessibilityUIElement::isSelectable):
2707         (WTR::AccessibilityUIElement::isMultiSelectable):
2708         (WTR::AccessibilityUIElement::setSelectedChild):
2709         (WTR::AccessibilityUIElement::setSelectedChildAtIndex):
2710         (WTR::AccessibilityUIElement::removeSelectionAtIndex):
2711         (WTR::AccessibilityUIElement::selectedChildrenCount):
2712         (WTR::AccessibilityUIElement::selectedChildAtIndex):
2713         (WTR::AccessibilityUIElement::isExpanded):
2714         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2715         (WTR::AccessibilityUIElement::setSelectedChild):
2716         (WTR::AccessibilityUIElement::setSelectedChildAtIndex):
2717         (WTR::AccessibilityUIElement::removeSelectionAtIndex):
2718         (WTR::AccessibilityUIElement::accessibilityValue):
2719
2720 2015-08-27  Alex Christensen  <achristensen@webkit.org>
2721
2722         Build fix after r188982
2723
2724         * MiniBrowser/win/CMakeLists.txt:
2725         The directory structure changed in the move.
2726
2727 2015-08-27  Michael Catanzaro  <mcatanzaro@igalia.com>
2728
2729         [GTK] Unreviewed, install-dependencies should install geoclue2 on Fedora
2730
2731         geoclue-devel is for obsolete geoclue. Install geoclue2-devel instead.
2732
2733         * gtk/install-dependencies:
2734
2735 2015-08-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2736
2737         Unreviewed. Mark WTF_WordLock.ContendedShortSection as slow too.
2738
2739         * Scripts/run-gtk-tests:
2740         (TestRunner):
2741
2742 2015-08-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2743
2744         Fix GTK+ WTR crashes in initializeMainRunLoop()
2745
2746         Rubber-stamped by Žan Doberšek.
2747
2748         Initialize threading and main thread before
2749         RunLoop::initializeMainRunLoop(), since the GLib implementation of
2750         the RunLoop uses isMainThread() to decide whether to create a new
2751         GMainContext or use the default one. Also use RunLoop::run() and
2752         ::stop() instead of gtk_main/quit.
2753
2754         * WebKitTestRunner/TestController.cpp:
2755         (WTR::TestController::initialize):
2756         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2757         (WTR::TestController::notifyDone):
2758         (WTR::TestController::platformRunUntil):
2759
2760 2015-08-27  Filip Pizlo  <fpizlo@apple.com>
2761
2762         Unreviewed, further shorten a test that times out because it's very long
2763         running.
2764
2765         I've locally run these tests on repeat for 24 hours and found no genuine
2766         failures, like deadlocks. So, the timeouts are probably because the test
2767         machine is slow and debug is slow. We should just run this test for fewer
2768         iterations.
2769
2770         * TestWebKitAPI/Tests/WTF/Lock.cpp:
2771         (TestWebKitAPI::TEST):
2772
2773 2015-08-26  Ryuan Choi  <ryuan.choi@navercorp.com>
2774
2775         Unreviewed build fix attempt on EFL
2776
2777         * WebKitTestRunner/PlatformEfl.cmake:
2778
2779 2015-08-26  Alex Christensen  <achristensen@webkit.org>
2780
2781         Build fix after r188982
2782
2783         * MiniBrowser/win/CMakeLists.txt:
2784         Find .rc files in correct directory.
2785
2786 2015-08-26  Ryuan Choi  <ryuan.choi@navercorp.com>
2787
2788         [EFL] Bump cairo version to 1.14.2
2789         https://bugs.webkit.org/show_bug.cgi?id=148474
2790
2791         Reviewed by Csaba Osztrogonác.
2792
2793         * efl/jhbuild.modules:
2794
2795 2015-08-26  Andy Estes  <aestes@apple.com>
2796
2797         Crash when following a Google search link to Twitter with Limit Adult Content enabled
2798         https://bugs.webkit.org/show_bug.cgi?id=147651
2799
2800         Rubber-stamped by Brady Eidson.
2801
2802         Taught TestRunner how to decide the navigation policy after a delay.
2803
2804         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2805         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2806         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
2807         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2808         (WTR::TestRunner::setShouldDecideNavigationPolicyAfterDelay):
2809         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2810         (WTR::TestRunner::shouldDecideNavigationPolicyAfterDelay):
2811         * WebKitTestRunner/TestController.cpp:
2812         (WTR::TestController::initialize):
2813         (WTR::TestController::resetStateToConsistentValues):
2814         (WTR::TestController::decidePolicyForNavigationAction):
2815         * WebKitTestRunner/TestController.h:
2816         (WTR::TestController::setShouldDecideNavigationPolicyAfterDelay):
2817         * WebKitTestRunner/TestInvocation.cpp:
2818         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2819
2820 2015-08-26  Brent Fulgham  <bfulgham@apple.com>
2821
2822         [Win] Rename 'WinLauncher' to 'MiniBrowser'
2823         https://bugs.webkit.org/show_bug.cgi?id=148485
2824
2825         Reviewed by Alex Christensen
2826
2827         Move the WinLauncher project and source files to a subdirectory
2828         of MiniBrowser. Globally change WinLauncher -> MiniBrowser in the
2829         source code and project files.
2830         
2831         * MiniBrowser/MiniBrowser.vcxproj: Copied from WinLauncher/WinLauncher.vcxproj.
2832         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.ico: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.ico.
2833         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.rc: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.rc.
2834         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.vcxproj: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.
2835         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.vcxproj.filters: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.filters.
2836         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCF.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherCF.props.
2837         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCFLite.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherCFLite.props.
2838         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCommon.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherCommon.props.
2839         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserDebug.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherDebug.props.
2840         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc.
2841         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.vcxproj: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.
2842         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.vcxproj.filters: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters.
2843         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibCommon.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props.
2844         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibDebug.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibDebug.props.
2845         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibPostBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibPostBuild.cmd.
2846         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibPreBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd.
2847         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibProduction.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibProduction.props.
2848         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibRelease.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibRelease.props.
2849         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h.
2850         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserPostBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherPostBuild.cmd.
2851         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserPreBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherPreBuild.cmd.
2852         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserProduction.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherProduction.props.
2853         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserRelease.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherRelease.props.
2854         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserResource.h: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherResource.h.
2855         * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.ico: Removed.
2856         * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.rc: Removed.
2857         * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.vcxproj: Removed.
2858         * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.vcxproj.filters: Removed.
2859         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherCF.props: Removed.
2860         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherCFLite.props: Removed.
2861         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherCommon.props: Removed.
2862         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherDebug.props: Removed.
2863         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLib.rc: Removed.
2864         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLib.vcxproj: Removed.
2865         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLib.vcxproj.filters: Removed.
2866         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibCommon.props: Removed.
2867         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibDebug.props: Removed.
2868         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibPostBuild.cmd: Removed.
2869         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibPreBuild.cmd: Removed.
2870         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibProduction.props: Removed.
2871         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibRelease.props: Removed.
2872         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibResource.h: Removed.
2873         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherPostBuild.cmd: Removed.
2874         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherPreBuild.cmd: Removed.
2875         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherProduction.props: Removed.
2876         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherRelease.props: Removed.
2877         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherResource.h: Removed.
2878         * MiniBrowser/win: Copied from WinLauncher.
2879         * MiniBrowser/win/Common.cpp:
2880         * MiniBrowser/win/MiniBrowser.cpp: Copied from WinLauncher/WinLauncher.cpp.
2881         * MiniBrowser/win/MiniBrowser.h: Copied from WinLauncher/WinLauncher.h.
2882         * MiniBrowser/win/MiniBrowserReplace.h: Copied from WinLauncher/WinLauncherReplace.h.
2883         * MiniBrowser/win/MiniBrowserWebHost.cpp: Copied from WinLauncher/WinLauncherWebHost.cpp.
2884         * MiniBrowser/win/MiniBrowserWebHost.h: Copied from WinLauncher/WinLauncherWebHost.h.
2885         * MiniBrowser/win/PageLoadTestClient.cpp:
2886         * MiniBrowser/win/PageLoadTestClient.h:
2887         * MiniBrowser/win/ResourceLoadDelegate.cpp:
2888         * MiniBrowser/win/ResourceLoadDelegate.h:
2889         * MiniBrowser/win/WinLauncher.cpp: Removed.
2890         * MiniBrowser/win/WinLauncher.h: Removed.
2891         * MiniBrowser/win/WinLauncher.vcxproj: Removed.
2892         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.ico: Removed.
2893         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.rc: Removed.
2894         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.vcxproj: Removed.
2895         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.vcxproj.filters: Removed.
2896         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherCF.props: Removed.
2897         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherCFLite.props: Removed.
2898         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherCommon.props: Removed.
2899         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherDebug.props: Removed.
2900         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLib.rc: Removed.
2901         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Removed.
2902         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters: Removed.
2903         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibCommon.props: Removed.
2904         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibDebug.props: Removed.
2905         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibPostBuild.cmd: Removed.
2906         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd: Removed.
2907         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibProduction.props: Removed.
2908         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibRelease.props: Removed.
2909         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibResource.h: Removed.
2910         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherPostBuild.cmd: Removed.
2911         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherPreBuild.cmd: Removed.
2912         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherProduction.props: Removed.
2913         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherRelease.props: Removed.
2914         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherResource.h: Removed.
2915         * MiniBrowser/win/WinLauncher.vcxproj/small.ico: Removed.
2916         * MiniBrowser/win/WinLauncherReplace.h: Removed.
2917         * MiniBrowser/win/WinLauncherWebHost.cpp: Removed.
2918         * MiniBrowser/win/WinLauncherWebHost.h: Removed.
2919         * MiniBrowser/win/WinMain.cpp:
2920         * WinLauncher: Removed.
2921         * WinLauncher/AccessibilityDelegate.cpp: Removed.
2922         * WinLauncher/AccessibilityDelegate.h: Removed.
2923         * WinLauncher/CMakeLists.txt: Removed.
2924         * WinLauncher/Common.cpp: Removed.
2925         * WinLauncher/DOMDefaultImpl.cpp: Removed.
2926         * WinLauncher/DOMDefaultImpl.h: Removed.
2927         * WinLauncher/PageLoadTestClient.cpp: Removed.
2928         * WinLauncher/PageLoadTestClient.h: Removed.
2929         * WinLauncher/PrintWebUIDelegate.cpp: Removed.
2930         * WinLauncher/PrintWebUIDelegate.h: Removed.
2931         * WinLauncher/ResourceLoadDelegate.cpp: Removed.
2932         * WinLauncher/ResourceLoadDelegate.h: Removed.
2933         * WinLauncher/WebDownloadDelegate.cpp: Removed.
2934         * WinLauncher/WebDownloadDelegate.h: Removed.
2935         * WinLauncher/WinLauncher.cpp: Removed.
2936         * WinLauncher/WinLauncher.h: Removed.
2937         * WinLauncher/WinLauncher.vcxproj: Removed.
2938         * WinLauncher/WinLauncher.vcxproj/WinLauncher.ico: Removed.
2939         * WinLauncher/WinLauncher.vcxproj/WinLauncher.rc: Removed.
2940         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Removed.
2941         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.filters: Removed.
2942         * WinLauncher/WinLauncher.vcxproj/WinLauncherCF.props: Removed.
2943         * WinLauncher/WinLauncher.vcxproj/WinLauncherCFLite.props: Removed.
2944         * WinLauncher/WinLauncher.vcxproj/WinLauncherCommon.props: Removed.
2945         * WinLauncher/WinLauncher.vcxproj/WinLauncherDebug.props: Removed.
2946         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Removed.
2947         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Removed.
2948         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters: Removed.
2949         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props: Removed.
2950         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibDebug.props: Removed.
2951         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibPostBuild.cmd: Removed.
2952         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd: Removed.
2953         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibProduction.props: Removed.
2954         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibRelease.props: Removed.
2955         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h: Removed.
2956         * WinLauncher/WinLauncher.vcxproj/WinLauncherPostBuild.cmd: Removed.
2957         * WinLauncher/WinLauncher.vcxproj/WinLauncherPreBuild.cmd: Removed.
2958         * WinLauncher/WinLauncher.vcxproj/WinLauncherProduction.props: Removed.
2959         * WinLauncher/WinLauncher.vcxproj/WinLauncherRelease.props: Removed.
2960         * WinLauncher/WinLauncher.vcxproj/WinLauncherResource.h: Removed.
2961         * WinLauncher/WinLauncher.vcxproj/small.ico: Removed.
2962         * WinLauncher/WinLauncherReplace.h: Removed.
2963         * WinLauncher/WinLauncherWebHost.cpp: Removed.
2964         * WinLauncher/WinLauncherWebHost.h: Removed.
2965         * WinLauncher/WinMain.cpp: Removed.
2966         * WinLauncher/resource.h: Removed.
2967         * WinLauncher/stdafx.cpp: Removed.
2968         * WinLauncher/stdafx.h: Removed.
2969         * win/AssembleBuildLogs/AssembleLogs.cmd:
2970
2971 2015-08-26  Brent Fulgham  <bfulgham@apple.com>
2972
2973         [Win] Simplify menu handling code in WinLauncher
2974         https://bugs.webkit.org/show_bug.cgi?id=148461
2975
2976         Reviewed by Zalan Bujtas.
2977
2978         Revise 'ToggleMenuItem' to return a boolean value indicating if
2979         it handled the message. Revise WndProc to use this to decide if it
2980         should pass the message on to the default handler, rather than
2981         duplicating the logic in both places.
2982         
2983         * WinLauncher/Common.cpp:
2984         (ToggleMenuItem): Return true if the menu item message was handled.
2985         (WndProc): If 'ToggleMenuItem' did not handle the message, pass
2986         the message tothe default handler.
2987
2988 2015-08-26  Csaba Osztrogonác  <ossy@webkit.org>
2989
2990         Remove unused code after r188948
2991         https://bugs.webkit.org/show_bug.cgi?id=148467
2992
2993         Reviewed by Gyuyoung Kim.
2994
2995         * WebKitTestRunner/TestController.cpp:
2996         (WTR::TestController::platformPreferences): Deleted.
2997
2998 2015-08-26  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2999
3000         [EFL][GTK] REGRESSION(r188828): All performance tests and almost all layout tests crash
3001         https://bugs.webkit.org/show_bug.cgi?id=148377
3002
3003         Reviewed by Carlos Garcia Campos.
3004
3005         EFL and GTK don't support TestController::platformPreferences() yet which was introduced by r188828.
3006         It caused all crashes of layout test and performance test on EFL and GTK. So this patch implements
3007         TestController::platformPreferences() using WKPageGroupGetPreferences() which was previous thing for
3008         EFL and GTK at the moment.
3009
3010         * WebKitTestRunner/TestController.cpp:
3011         (WTR::TestController::platformWillRunTest):
3012         * WebKitTestRunner/efl/TestControllerEfl.cpp:
3013         (WTR::TestController::platformPreferences):
3014         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
3015         (WTR::TestController::platformPreferences):
3016
3017 2015-08-25  Nan Wang  <n_wang@apple.com>
3018
3019         AX: Enable accessibility/aria-controls.html test for mac
3020         https://bugs.webkit.org/show_bug.cgi?id=148458
3021
3022         Reviewed by Chris Fleizach.
3023
3024         Implemented ariaControlsElementAtIndex(unsigned index).
3025
3026         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3027         (AccessibilityUIElement::ariaControlsElementAtIndex):
3028         (AccessibilityUIElement::disclosedRowAtIndex):
3029         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3030         (WTR::AccessibilityUIElement::ariaControlsElementAtIndex):
3031
3032 2015-08-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3033
3034         Remove python tests for PassRefPtr 
3035         https://bugs.webkit.org/show_bug.cgi?id=148463
3036
3037         Reviewed by Andy Estes.
3038
3039         As we're removing uses of PassRefPtr, we need to remove all python tests for PassRefPtr as well.
3040
3041         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3042         (PassPtrTest): Deleted.
3043         (PassPtrTest.assert_pass_ptr_check): Deleted.
3044         (PassPtrTest.test_pass_ref_ptr_in_function): Deleted.
3045         (PassPtrTest.test_pass_other_type_ptr_in_function): Deleted.
3046         (PassPtrTest.test_pass_ref_ptr_return_value): Deleted.
3047         (PassPtrTest.test_ref_ptr_parameter_value): Deleted.
3048         (PassPtrTest.test_ref_ptr_member_variable): Deleted.
3049         (PassPtrTest.test_ref_ptr_member_variable.Foo): Deleted.
3050
3051 2015-08-25  Andy Estes  <aestes@apple.com>
3052
3053         [iOS] run-webkit-tests fails if watchOS SDK is installed
3054         https://bugs.webkit.org/show_bug.cgi?id=148453
3055
3056         Reviewed by David Kilzer.
3057
3058         * Scripts/webkitpy/xcode/simulator.py:
3059         (Simulator): Taught Simulator how to parse watchOS runtimes and devices.
3060         * Scripts/webkitpy/xcode/simulator_unittest.py: Added tests.
3061
3062 2015-08-25  Aakash Jain  <aakash_jain@apple.com>
3063
3064         iOS Simulator layout-tests fail to start while cleaning a directory structure if simulator is already running
3065         https://bugs.webkit.org/show_bug.cgi?id=148197
3066         rdar://problem/22334382
3067
3068         Reviewed by Daniel Bates.
3069
3070         * BuildSlaveSupport/kill-old-processes: Add Simulator to the list of processes to kill (for iOS builders).
3071         * Scripts/webkitpy/port/ios.py:
3072         (IOSSimulatorPort): Converted bundle id com.apple.iphonesimulator to a variable SIMULATOR_BUNDLE_ID.
3073         (IOSSimulatorPort._quitIOSSimulator): Common function to quit iOS Simulator.
3074         (IOSSimulatorPort.clean_up_test_run): Quit the simulator during the cleanup.
3075         (IOSSimulatorPort.check_sys_deps): No need to quit the simulator here as its now being quit in reset_preferences().
3076         (IOSSimulatorPort.reset_preferences): Quit the simulator before trying to delete associated data directory.
3077
3078 2015-08-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3079
3080         Remove PassRefPtr style check rule
3081         https://bugs.webkit.org/show_bug.cgi?id=148432
3082
3083         Reviewed by Andreas Kling.
3084
3085         PassRefPtr is being removed. Thus style rule needs to be removed as well.
3086
3087         * Scripts/webkitpy/style/checkers/cpp.py:
3088         (_check_parameter_name_against_text): Deleted.
3089         (check_function_definition_and_pass_ptr): Deleted.
3090         (check_function_definition): Deleted.
3091         (check_pass_ptr_usage): Deleted.
3092         (process_line): Deleted.
3093         (CppChecker): Deleted.
3094
3095 2015-08-25  Brent Fulgham  <bfulgham@apple.com>
3096
3097         [Win] Expose "Inverted Colors" option in WinLauncher
3098         https://bugs.webkit.org/show_bug.cgi?id=148451
3099
3100         Reviewed by Tim Horton.
3101
3102         Add the ability to toggle the "Inverted Colors" preference
3103         in WinLauncher.
3104         
3105         * WinLauncher/Common.cpp:
3106         (ToggleMenuItem): Toggle the feature when the menu item
3107         is selected.
3108         (WndProc): Recognize the new menu option.
3109         * WinLauncher/WinLauncher.cpp:
3110         (WinLauncher::setToDefaultPreferences): Launch with "Invert
3111         Colors" turned off.
3112         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Add menu
3113         entry for "Invert Colors".
3114         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h:
3115
3116 2015-08-25  Nan Wang  <n_wang@apple.com>
3117
3118         [Mac] accessibility/document-attributes.html fails
3119         https://bugs.webkit.org/show_bug.cgi?id=116636
3120
3121         Reviewed by Chris Fleizach.
3122
3123         Implemented documentURI() and documentEncoding().
3124
3125         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3126         (AccessibilityUIElement::documentEncoding):
3127         (AccessibilityUIElement::documentURI):
3128         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3129         (WTR::AccessibilityUIElement::documentEncoding):
3130         (WTR::AccessibilityUIElement::documentURI):
3131
3132 2015-08-24  Brent Fulgham  <bfulgham@apple.com>
3133
3134         [Win] Unreviewed test gardening.
3135
3136         Fix another case where the logging string is constructed using the variable 'frame',
3137         but the method argument is not given a name. This causes the global 'frame' value to
3138         be used, producing incorrect output.
3139
3140         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3141         (FrameLoadDelegate::didReceiveServerRedirectForProvisionalLoadForFrame): Use 'frame'
3142         argument.
3143
3144 2015-08-24  Tim Horton  <timothy_horton@apple.com>
3145
3146         (Finally...) get rid of WKViewIOS
3147         https://bugs.webkit.org/show_bug.cgi?id=148404
3148
3149         Reviewed by Anders Carlsson.
3150
3151         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
3152         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
3153         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
3154         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
3155         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
3156         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
3157         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm:
3158         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
3159         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
3160         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.mm:
3161         Mark tests that use WKBrowsingContextController as Mac-only.
3162
3163         * WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm:
3164         (WTR::AccessibilityController::addNotificationListener):
3165         * WebKitTestRunner/ios/mainIOS.mm:
3166         (-[WebKitTestRunnerApp applicationDidEnterBackground:]):
3167         Import UIKit instead of depending on WKView.h to do so.
3168
3169 2015-08-24  Jason Marcell  <jmarcell@apple.com>
3170
3171         Add support to dashboard for displaying Git SHA's as revisions.
3172         https://bugs.webkit.org/show_bug.cgi?id=148387
3173
3174         Reviewed by Daniel Bates.
3175
3176         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3177         (parseRevisionProperty): Added support to dashboard for displaying Git SHA's as revisions.
3178         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3179         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Ditto.
3180         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js: Added
3181         "isSVN" property to Dashboard.Repository.(OpenSource|Internal).
3182
3183 2015-08-24  Andy Estes  <aestes@apple.com>
3184
3185         REGRESSION (r188851): WebKit2.BundleParameters fails on iOS
3186
3187         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Specify LD_RUNPATH_SEARCH_PATHS correctly for iOS.
3188
3189 2015-08-23  Andy Estes  <aestes@apple.com>
3190
3191         Addressed a missed piece of review feedback from r188851.
3192
3193         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
3194
3195 2015-08-23  Andy Estes  <aestes@apple.com>
3196
3197         [Content Filtering] REGRESSION (r182356): Provisional URL is incorrect in didReceiveServerRedirectForProvisionalLoadForFrame when Content Filtering is enabled
3198         https://bugs.webkit.org/show_bug.cgi?id=147872
3199         rdar://problem/22044000
3200
3201         Reviewed by Dan Bernstein.
3202         
3203         Added an API test.
3204
3205         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Linked libWebCoreTestSupport in order to use MockContentFilter.
3206         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3207         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm: Added.
3208         (-[ServerRedirectNavigationDelegate webView:didStartProvisionalNavigation:]): Expect the initial request URL.
3209         (-[ServerRedirectNavigationDelegate webView:didReceiveServerRedirectForProvisionalNavigation:]): Expect the redirect URL.
3210         (-[ServerRedirectNavigationDelegate webView:didCommitNavigation:]):
3211         (TEST): Tested that -[WKWebView URL] is updated after a redirect when content filtering is enabled.
3212         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm: Added.
3213         (+[ServerRedirectPlugIn initialize]): Enable MockContentFilter.
3214         * TestWebKitAPI/cocoa/TestProtocol.h: Renamed from Tools/TestWebKitAPI/mac/TestProtocol.h.
3215         * TestWebKitAPI/cocoa/TestProtocol.mm: Renamed from Tools/TestWebKitAPI/mac/TestProtocol.mm.
3216
3217 2015-08-23  Andy Estes  <aestes@apple.com>
3218
3219         Fixed the 32-bit Mac build after r188844.
3220
3221         * TestWebKitAPI/WKWebViewConfigurationExtras.h:
3222         * TestWebKitAPI/WKWebViewConfigurationExtras.mm:
3223
3224 2015-08-22  Andy Estes  <aestes@apple.com>
3225
3226         [Cocoa] API tests using the Modern WebKit API should be able to create web process plug-ins
3227         https://bugs.webkit.org/show_bug.cgi?id=148317
3228
3229         Reviewed by Dan Bernstein.
3230
3231         Added the ability for Modern WebKit API tests to create WKWebProcessPlugIns. A test can create a plug-in by
3232         creating a class that conforms to WKWebProcessPlugIn, adding it to the WebProcessPlugIn target, and using the
3233         WKWebViewConfiguration returned by +[WKWebViewConfiguration testwebkitapi_configurationWithTestPlugInClassName:]
3234         when creating WKWebViews.
3235
3236         Since TestWebKitAPI relies on a bundle parameter to know which test class to instantiate in the plug-in, I also
3237         added a new API test for bundle parameters.
3238
3239         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Added. Named the bundle TestWebKitAPI.wkbundle and
3240         named its executable TestWebKitAPI.bundle.
3241         * TestWebKitAPI/PlatformUtilities.h: Declared TestPlugInClassNameParameter.
3242         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added the WebProcessPlugIn target.
3243         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParameters.mm: Added.
3244         (TEST): Tested bundle parameters by verifying that parameter changes in the UI process are observed in the bundle.
3245         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParametersPlugIn.mm: Added.
3246         (-[BundleParametersPlugIn webProcessPlugIn:didCreateBrowserContextController:]): Started observing changes to a
3247         bundle parameter and asked for an initial notification.
3248         (-[BundleParametersPlugIn dealloc]): Stopped observing changes to a bundle parameter.
3249         (-[BundleParametersPlugIn observeValueForKeyPath:ofObject:change:context:]): When a bundle parameter changes,
3250         mirror its value in the main frame's JSContext.
3251         * TestWebKitAPI/WKWebViewConfigurationExtras.h: Added.
3252         * TestWebKitAPI/WKWebViewConfigurationExtras.mm: Added.
3253         (+[WKWebViewConfiguration testwebkitapi_configurationWithTestPlugInClassName:]): Created a configuration with
3254         TestWebKitAPI's bundle URL and set a bundle parameter indicating the test plug-in's class name.
3255         * TestWebKitAPI/cocoa/PlatformUtilitiesCocoa.mm: Defined TestPlugInClassNameParameter.
3256         * TestWebKitAPI/cocoa/WebProcessPlugIn/Info.plist: Added. Set the principal class to WebProcessPlugIn.
3257         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm: Added.
3258         (-[WebProcessPlugIn webProcessPlugIn:initializeWithObject:]): Forwarded to a newly-created test class instance.
3259         (-[WebProcessPlugIn respondsToSelector:]): Returned YES if the test class instance response.
3260         (-[WebProcessPlugIn forwardingTargetForSelector:]): Forwarded unimplemented methods to the test class instance.
3261
3262 2015-08-23  Csaba Osztrogonác  <ossy@webkit.org>
3263
3264         URTBF after r188828.
3265
3266         * WebKitTestRunner/PlatformWebView.h:
3267
3268 2015-08-23  Alexey Proskuryakov  <ap@apple.com>
3269
3270         build.webkit.org/dashboard: Combined queues don't turn orange on internal failure
3271         https://bugs.webkit.org/show_bug.cgi?id=148356
3272
3273         Reviewed by Darin Adler.
3274
3275         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
3276         (BuildbotCombinedQueueView.prototype.update):
3277
3278 2015-08-23  Alexey Proskuryakov  <ap@apple.com>
3279
3280         build.webkit.org/dashboard: Respect step's hidden flag
3281         https://bugs.webkit.org/show_bug.cgi?id=148357
3282
3283         Reviewed by Darin Adler.
3284
3285         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3286         (BuildbotIteration.prototype._parseData):
3287
3288 2015-08-23  Nan Wang  <n_wang@apple.com>
3289
3290         AX: Fix accessibility/deleting-iframe-destroys-axcache.html test
3291         https://bugs.webkit.org/show_bug.cgi?id=148328
3292
3293         Reviewed by Darin Adler.
3294
3295         We should only expose stringValue() when value attribute is set.
3296
3297         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3298         (AccessibilityUIElement::stringValue):
3299         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3300         (WTR::AccessibilityUIElement::stringValue):
3301
3302 2015-08-23  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3303
3304         Remove style checking rule regarding OwnPtr and PassOwnPtr
3305         https://bugs.webkit.org/show_bug.cgi?id=148360
3306
3307         Reviewed by Darin Adler.
3308
3309         OwnPtr and PassOwnPtr were totally removed though, style rule is still alive.
3310         Removed it.
3311
3312         * Scripts/do-webcore-rename:
3313         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3314         (PassPtrTest.test_pass_own_ptr_in_function): Deleted.
3315         (PassPtrTest.test_pass_ref_ptr_return_value): Deleted.
3316         (PassPtrTest.test_own_ptr_parameter_value): Deleted.
3317         (WebKitStyleTest.test_names): Deleted.
3318
3319 2015-08-22  Timothy Horton  <timothy_horton@apple.com>
3320
3321         WebKitTestRunner should use WKWebView on OS X and iOS
3322         https://bugs.webkit.org/show_bug.cgi?id=143743
3323         <rdar://problem/16947123>
3324
3325         Reviewed by Anders Carlsson.
3326         Patch by Enrica Casucci and myself.
3327
3328         * WebKitTestRunner/PlatformWebView.h:
3329         (WTR::PlatformWebView::windowSnapshotEnabled): Deleted.
3330         Add a PlatformWebView constructor that takes a WKWebViewConfiguration
3331         instead of WKContext and WKPageGroup.
3332
3333         Remove the unused, always-true windowSnapshotEnabled().
3334         While technically some platforms don't have window snapshotting,
3335         they just return null instead of implementing windowSnapshotEnabled().
3336
3337         * WebKitTestRunner/TestController.h:
3338         * WebKitTestRunner/TestController.cpp:
3339         (WTR::TestController::createOtherPage):
3340         (WTR::TestController::initialize):
3341         (WTR::TestController::createWebViewWithOptions):
3342         Delegate to the various platforms for creating PlatformWebView instances,
3343         for creating WKContexts, and for accessing WKPreferences,
3344         so that they can do special things (like, use WKWebView instead!).
3345
3346         (WTR::TestController::resetPreferencesToConsistentValues):
3347         Make explicit WebKitTestRunner's desired default for two preferences
3348         which have differing defaults between the antique and modern API,
3349         for consistency's sake.
3350
3351         (WTR::TestController::resetStateToConsistentValues):
3352         Add platformResetStateToConsistentValues.
3353
3354         * WebKitTestRunner/TestInvocation.cpp:
3355         (WTR::TestInvocation::dumpResults):
3356         Adjust to the aforementioned removal of windowSnapshotEnabled().
3357
3358         * WebKitTestRunner/ios/TestControllerCocoa.mm:
3359         (WTR::TestController::platformResetStateToConsistentValues):
3360         (WTR::TestController::platformPreferences):
3361         (WTR::TestController::platformCreateWebView):
3362         (WTR::TestController::platformCreateOtherPage):
3363         (WTR::TestController::platformInitializeConfiguration):
3364         Implement the new platform functions for the Modern WebKit2 API,
3365         in a new TestControllerCocoa file that is shared between iOS and Mac.
3366         
3367         For platformMaybeCreateContext, use the trick that we know we can cast
3368         the WKProcessPool to a WKContextRef to retrieve a WKContextRef from
3369         WKWebView's configuration.
3370
3371         Ditto for WKPreferencesRef and WKPreferences.
3372
3373         Remove user content filters on the WKWebView's userContentController.
3374
3375         * WebKitTestRunner/mac/TestControllerMac.mm:
3376         * WebKitTestRunner/ios/TestControllerIOS.mm:
3377         Move code into TestControllerCocoa.
3378
3379         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3380         (WTR::InjectedBundle::beginTesting):
3381         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3382         (WTR::TestRunner::addUserScript):
3383         (WTR::TestRunner::addUserStyleSheet):
3384         Adopt WKBundlePage API for user scripts/sheets.
3385
3386         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3387         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3388         Make and keep a WKWebView instead of a WKView.
3389         
3390         * WebKitTestRunner/mac/EventSenderProxy.mm:
3391         (WTR::EventSenderProxy::mouseUp):
3392         (WTR::EventSenderProxy::mouseMoveTo):
3393         Reach inside the WKWebView to the WKView when dispatching events.
3394         This is fairly ugly and we should come up with a better solution.
3395         Also, fix some flipping and style errors.
3396
3397 2015-08-22  Michael Catanzaro  <mcatanzaro@igalia.com>
3398
3399         Unreviewed, attempt to fix GTK build after r188718
3400
3401         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3402         (WTR::PlatformWebView::PlatformWebView):
3403
3404 2015-08-21  Commit Queue  <commit-queue@webkit.org>
3405
3406         Unreviewed, rolling out r188807, r188813, and r188815.
3407         https://bugs.webkit.org/show_bug.cgi?id=148349
3408
3409         lots of 32-bit build problems, better to resolve separately
3410         and try again (Requested by thorton on #webkit).
3411
3412         Reverted changesets:
3413
3414         "WebKitTestRunner should use WKWebView on OS X and iOS"
3415         https://bugs.webkit.org/show_bug.cgi?id=143743
3416         http://trac.webkit.org/changeset/188807
3417
3418         "Stop building WebKitTestRunner for 32-bit platforms"
3419         https://bugs.webkit.org/show_bug.cgi?id=143743
3420         http://trac.webkit.org/changeset/188813
3421
3422         "Stop building WebKitTestRunner for 32-bit platforms"
3423         https://bugs.webkit.org/show_bug.cgi?id=143743
3424         http://trac.webkit.org/changeset/188815
3425
3426 2015-08-21  Tim Horton  <timothy_horton@apple.com>
3427
3428         Stop building WebKitTestRunner for 32-bit platforms
3429         https://bugs.webkit.org/show_bug.cgi?id=143743
3430         <rdar://problem/16947123>
3431
3432         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3433         This is a restriction on the valid set, not the desired set.
3434
3435 2015-08-21  Jason Marcell  <jmarcell@apple.com>
3436
3437         Make Dashboard.Branches be objects of the form (repository, "branch name") and update existing code
3438         to work with these new objects.
3439         https://bugs.webkit.org/show_bug.cgi?id=148188
3440
3441         Reviewed by Daniel Bates.
3442
3443         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
3444         (Buildbot.prototype._normalizeQueueInfo): Renamed BuildbotQueue.branch to BuildbotQueue.branches.
3445         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
3446         (BuildbotCombinedQueueView): Changed to work with new branch objects which represent a
3447         (repository, "branch name")-pair.
3448         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: Ditto.
3449         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
3450         (BuildbotQueue): Renamed BuildbotQueue.branch to BuildbotQueue.branches.
3451         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3452         (BuildbotQueueView.prototype._appendPendingRevisionCount): Changed to work with new branch
3453         objects which represent a (repository, "branch name")-pair.
3454         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Ditto.
3455         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Ditto.
3456         (BuildbotQueueView.prototype._addDividerToPopover): Ditto.
3457         (BuildbotQueueView.prototype.revisionContentForIteration): Ditto.
3458         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Renamed
3459         BuildbotQueue.branch to BuildbotQueue.branches.
3460         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3461         (WebKitBuildbot.prototype.get defaultBranches): Changed to new (repository, "branch name") format.
3462
3463 2015-08-21  Tim Horton  <timothy_horton@apple.com>
3464
3465         Stop building WebKitTestRunner for 32-bit platforms
3466         https://bugs.webkit.org/show_bug.cgi?id=143743
3467         <rdar://problem/16947123>
3468
3469         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3470         WKWebView is not available on 32-bit OS X.
3471
3472 2015-08-21  Brent Fulgham  <bfulgham@apple.com>
3473
3474         [Win] Unreviewed test correction after r188709.
3475
3476         I removed a function argument that happened to be mirrored by a global
3477         value with the same name. This prevented a compile error, but testing
3478         showed that the wrong value was being used in the function.
3479
3480         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3481         (FrameLoadDelegate::willPerformClientRedirectToURL): Put function argument
3482         back
3483
3484 2015-08-21  Timothy Horton  <timothy_horton@apple.com>
3485
3486         WebKitTestRunner should use WKWebView on OS X and iOS
3487         https://bugs.webkit.org/show_bug.cgi?id=143743
3488         <rdar://problem/16947123>
3489
3490         Reviewed by Anders Carlsson.
3491         Patch by Enrica Casucci and myself.
3492
3493         * WebKitTestRunner/PlatformWebView.h:
3494         (WTR::PlatformWebView::windowSnapshotEnabled): Deleted.
3495         Add a PlatformWebView constructor that takes a WKWebViewConfiguration
3496         instead of WKContext and WKPageGroup.
3497
3498         Remove the unused, always-true windowSnapshotEnabled().
3499         While technically some platforms don't have window snapshotting,
3500         they just return null instead of implementing windowSnapshotEnabled().
3501
3502         * WebKitTestRunner/TestController.h:
3503         * WebKitTestRunner/TestController.cpp:
3504         (WTR::TestController::createOtherPage):
3505         (WTR::TestController::initialize):
3506         (WTR::TestController::createWebViewWithOptions):
3507         Delegate to the various platforms for creating PlatformWebView instances,
3508         for creating WKContexts, and for accessing WKPreferences,
3509         so that they can do special things (like, use WKWebView instead!).
3510
3511         (WTR::TestController::resetPreferencesToConsistentValues):
3512         Make explicit WebKitTestRunner's desired default for two preferences
3513         which have differing defaults between the antique and modern API,
3514         for consistency's sake.
3515
3516         (WTR::TestController::resetStateToConsistentValues):
3517         Add platformResetStateToConsistentValues.
3518
3519         * WebKitTestRunner/TestInvocation.cpp:
3520         (WTR::TestInvocation::dumpResults):
3521         Adjust to the aforementioned removal of windowSnapshotEnabled().
3522
3523         * WebKitTestRunner/ios/TestControllerCocoa.mm:
3524         (WTR::TestController::platformResetStateToConsistentValues):
3525         (WTR::TestController::platformPreferences):
3526         (WTR::TestController::platformCreateWebView):
3527         (WTR::TestController::platformCreateOtherPage):
3528         (WTR::TestController::platformInitializeConfiguration):
3529         Implement the new platform functions for the Modern WebKit2 API,
3530         in a new TestControllerCocoa file that is shared between iOS and Mac.
3531         
3532         For platformMaybeCreateContext, use the trick that we know we can cast
3533         the WKProcessPool to a WKContextRef to retrieve a WKContextRef from
3534         WKWebView's configuration.
3535
3536         Ditto for WKPreferencesRef and WKPreferences.
3537
3538         Remove user content filters on the WKWebView's userContentController.
3539
3540         * WebKitTestRunner/mac/TestControllerMac.mm:
3541         * WebKitTestRunner/ios/TestControllerIOS.mm:
3542         Move code into TestControllerCocoa.
3543
3544         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3545         (WTR::InjectedBundle::beginTesting):
3546         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3547         (WTR::TestRunner::addUserScript):
3548         (WTR::TestRunner::addUserStyleSheet):
3549         Adopt WKBundlePage API for user scripts/sheets.