63e840783e00e974ba1eb72dd7df3eaddabd4462
[WebKit-https.git] / Tools / ChangeLog
1 2013-07-23  Tim Horton  <timothy_horton@apple.com>
2
3         Add a test for plug-in unavailability indicator obscurity detection
4         https://bugs.webkit.org/show_bug.cgi?id=119007
5
6         Reviewed by Anders Carlsson.
7
8         Expose the ability to block plug-ins via pluginLoadPolicy to testRunner.
9
10         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
11         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
12         (WTR::TestRunner::setBlockAllPlugins):
13         * WebKitTestRunner/InjectedBundle/TestRunner.h:
14         * WebKitTestRunner/TestInvocation.cpp:
15         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
16         Add testRunner.setBlockAllPlugins function (and corresponding message to
17         forward it through to TestController).
18
19         * WebKitTestRunner/TestController.cpp:
20         Initialize m_shouldBlockAllPlugins to false (and drive-by initialize m_handlesAuthenticationChallenges).
21
22         (WTR::TestController::createWebViewWithOptions):
23         Register our pluginLoadPolicy callback.
24
25         (WTR::TestController::resetStateToConsistentValues):
26         Reset m_shouldBlockAllPlugins to false.
27
28         (WTR::TestController::pluginLoadPolicy):
29         Return the existing plugin load policy, unless setBlockAllPlugins(true)
30         was called, in which case we reject all plugins with kWKPluginLoadPolicyBlocked.
31
32         * WebKitTestRunner/TestController.h:
33         (WTR::TestController::setBlockAllPlugins):
34
35 2013-07-21  Andreas Kling  <akling@apple.com>
36
37         KURL creates duplicate strings when completing data: URIs.
38         <http://webkit.org/b/118952>
39         <rdar://problem/14504480>
40
41         Reviewed by Anders Carlsson.
42
43         * TestWebKitAPI/Tests/WebCore/KURL.cpp:
44         (TestWebKitAPI::TEST_F):
45
46 2013-07-19  Chris Fleizach  <cfleizach@apple.com>
47
48         AX: VoiceOver not detecting misspelled words don't work in all cases
49         https://bugs.webkit.org/show_bug.cgi?id=118924
50
51         Reviewed by Tim Horton.
52
53         Make the misspelled detection dependent on both types of attributes being present.
54
55         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
56         (AccessibilityUIElement::attributedStringRangeIsMisspelled):
57         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
58         (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
59
60 2013-07-19  Alex Christensen  <achristensen@apple.com>
61
62         Improved code coverage generation.
63         https://bugs.webkit.org/show_bug.cgi?id=118926
64
65         Reviewed by Tim Horton.
66
67         * Scripts/build-webkit: Removed exception preventing ANGLE code coverage support.
68         * Scripts/generate-coverage-data: Added --no-build to run-javascriptcore-tests call.
69         (generateReport): Moved report generation to a subroutine.
70
71 2013-07-19  Stephanie Lewis  <slewis@apple.com>
72
73         <rdar://problem/14499595> pagination wk2 api test failing on ML (118928)
74
75         Unreviewed.
76
77         Rebaseline pagination test after http://trac.webkit.org/changeset/152911
78
79         * TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp:
80         (TestWebKitAPI::didLayout):
81
82 2013-07-19  Daniel Bates  <dabates@apple.com>
83
84         Make Perl tools work when using git bisect with Git branch build setup
85         https://bugs.webkit.org/show_bug.cgi?id=118512
86
87         Reviewed by Martin Robinson.
88
89         The various Perl tools (run-webkit-app, {debug, run}-safari, et cetera) don't work
90         during a git bisect session with a Git branch build setup (i.e. git config
91         core.webKitBranchBuild true). Specifically, the tools cannot find the branch-
92         specific build of WebKit because they cannot determine the branch Git is on (since
93         git bisect puts Git into a detached HEAD state). We should teach our tooling to
94         parse the file .git/BISECT_START (created by git bisect start) for the name of the
95         branch Git was on when we began a git bisect session. Then the tools can determine
96         the path to the built WebKit.
97
98         * Scripts/VCSUtils.pm:
99         (gitDirectory): Added.
100         (gitBisectStartBranch): Added.
101         (gitBranch): Modified to call gitBisectStartBranch() when we have a detached
102         HEAD (e.g. running git bisect).
103         (determineVCSRoot): Modified to call gitDirectory() to determine the path to
104         the .git directory in the Git checkout.
105
106 2013-07-19  Alex Christensen  <achristensen@apple.com>
107
108         Added x64 configuration to Visual Studio build.
109         https://bugs.webkit.org/show_bug.cgi?id=118888
110
111         Reviewed by Brent Fulgham.
112
113         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
114         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj.filters:
115         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
116         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
117         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
118         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
119         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
120         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
121         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
122         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj:
123         * win/record-memory/record-memory.vcxproj:
124
125 2013-07-19  Martin Robinson  <mrobinson@igalia.com>
126
127         Add a couple people to the MathML watchlist
128         https://bugs.webkit.org/show_bug.cgi?id=118909
129
130         Reviewed by Andreas Kling.
131
132         Add a couple people to the MathML watchlist and add Kalyan's other
133         email address to fix style checker warnings about the watchlist
134         contents.
135
136         * Scripts/webkitpy/common/config/contributors.json: Add Frédéric to the
137         list of contributors and add Kalyan's second email address.
138         * Scripts/webkitpy/common/config/watchlist: Add myself and Frédéric to the MathML
139         watchlist.
140
141 2013-07-19  Simon Pena  <simon.pena@samsung.com>
142
143         [GTK] Fix regression in DumpRenderTree introduced in r152782 by checking if uri is valid
144         https://bugs.webkit.org/show_bug.cgi?id=118895
145
146         Reviewed by Philippe Normand.
147
148         In r152782 an uri is used to create an string representation without checking first if it
149         is valid. That fails later when the string is used to check for existing redirections. This
150         patch ensures that the uri is valid before using it.
151
152         * DumpRenderTree/gtk/DumpRenderTree.cpp:
153         (willSendRequestCallback): Ensure an uri is valid before using it.
154
155 2013-07-18  Timothy Hatcher  <timothy@apple.com>
156
157         Add extract-localizable-js-strings and use it for WebInspectorUI.
158
159         https://bugs.webkit.org/show_bug.cgi?id=118851
160
161         Reviewed by Joseph Pecoraro.
162
163         * Scripts/extract-localizable-js-strings: Added.
164         * Scripts/extract-localizable-strings: Drive-by-fix: disable deprecated warnings about "goto".
165         * Scripts/update-webkit-localizable-strings: Use extract-localizable-js-strings for
166         the WebInspectorUI project.
167
168 2013-07-18  Brent Fulgham  <bfulgham@apple.com>
169
170         [Windows] Build correction #2 after r152861.
171
172         * WinLauncher/WinLauncher.cpp: Declare proper linkage.
173
174 2013-07-18  Brent Fulgham  <bfulgham@apple.com>
175
176         [Windows] Build correction after r152861.
177
178         * WinLauncher/WinLauncher.cpp: Don't reference private header.
179
180 2013-07-16  Brent Fulgham  <bfulgham@apple.com>
181
182         [Win] Support in-band text tracks.
183         https://bugs.webkit.org/show_bug.cgi?id=103770
184
185         Reviewed by Eric Carlson.
186
187         Update WinLauncher to run in a CFRunLoop (rather than a hand-written Windows event loop) so that
188         libdispatch and CFRunLoop elements are services during the run loop.
189
190         * WinLauncher/WinLauncher.cpp:
191         (dllLauncherEntryPoint): Use CFRunLoopRun (rather than a Windows message loop) if running with
192         a CoreFoundation (or CFLite) support library.
193         * WinLauncher/WinLauncher.vcxproj/WinLauncherCF.props: Added.
194         * WinLauncher/WinLauncher.vcxproj/WinLauncherCFLite.props: Added.
195         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Add references to WinLauncherCF.props
196         and WinLauncherCFLite.props.
197
198 2013-07-18  Roger Fong  <roger_fong@apple.com>
199
200         Unreviewed. Test enabling WinEWS tests now that queue is at a good state and NRWT with multiple processes is enabled.
201
202         * Scripts/webkitpy/common/config/ews.json:
203
204 2013-07-18  Daniel Bates  <dabates@apple.com>
205
206         REGRESSION (r132678): Tests that use SSL or port 8080 time out when run using old-run-webkit-tests
207         https://bugs.webkit.org/show_bug.cgi?id=118854
208         <rdar://problem/14081339>
209
210         Reviewed by David Kilzer.
211
212         Following <http://trac.webkit.org/changeset/132678> (https://bugs.webkit.org/show_bug.cgi?id=98602)
213         Apache no longer listens to ports 8443 (SSL) and 8080. So, tests that use these ports time out when
214         run using old-run-webkit-tests. We need to update old-run-webkit-tests to explicitly tell Apache to
215         listen on these ports so that we can run tests that use port 8443 and 8080.
216
217         * Scripts/old-run-webkit-tests:
218         (configureAndOpenHTTPDIfNeeded):
219
220 2013-07-17  Tim Horton  <timothy_horton@apple.com>
221
222         Update blocked/missing plug-in UI
223         https://bugs.webkit.org/show_bug.cgi?id=118347
224         <rdar://problem/14209318>
225
226         Reviewed by Sam Weinig.
227
228         * MiniBrowser/mac/WK2BrowserWindowController.m:
229         (-[WK2BrowserWindowController awakeFromNib]):
230         * WebKitTestRunner/TestController.cpp:
231         (WTR::TestController::createWebViewWithOptions):
232         Match new WKPageLoaderClient entry.
233
234 2013-07-17  Commit Queue  <commit-queue@webkit.org>
235
236         Unreviewed, rolling out r152701, r152703, r152739, r152754,
237         and r152756.
238         http://trac.webkit.org/changeset/152701
239         http://trac.webkit.org/changeset/152703
240         http://trac.webkit.org/changeset/152739
241         http://trac.webkit.org/changeset/152754
242         http://trac.webkit.org/changeset/152756
243         https://bugs.webkit.org/show_bug.cgi?id=118821
244
245         this was a buggy fix and we're going to try something
246         different (Requested by thorton on #webkit).
247
248         * MiniBrowser/mac/WK2BrowserWindowController.m:
249         (-[WK2BrowserWindowController awakeFromNib]):
250         * WebKitTestRunner/TestController.cpp:
251         (WTR::TestController::createWebViewWithOptions):
252
253 2013-07-17  Commit Queue  <commit-queue@webkit.org>
254
255         Unreviewed, rolling out r151535.
256         http://trac.webkit.org/changeset/151535
257         https://bugs.webkit.org/show_bug.cgi?id=118804
258
259         Re-disable WinEWS tests (Requested by rfong on #webkit).
260
261         * Scripts/webkitpy/common/config/ews.json:
262
263 2013-07-17  Simon Pena  <simon.pena@samsung.com>
264
265         [GTK] Make DRT obbey testRunner's addURLToRedirect
266         https://bugs.webkit.org/show_bug.cgi?id=118239
267
268         Reviewed by Gustavo Noronha Silva.
269
270         Support testRunner's addURLToRedirect in GTK's DRT, so it redirects
271         to the proper URI when indicated.
272
273         * DumpRenderTree/gtk/DumpRenderTree.cpp:
274         (willSendRequestCallback):
275
276 2013-07-17  Gabor Abraham  <abrhm@inf.u-szeged.hu>
277
278         Add a new find-resolved-bugs command to webkit-patch.
279         https://bugs.webkit.org/show_bug.cgi?id=118060
280
281         Reviewed by Csaba Osztrogonác.
282
283         * Scripts/webkitpy/tool/commands/queries.py:
284         (PrintBaselines._platform_for_path):
285         (FindResolvedBugs):
286         (FindResolvedBugs.execute):
287
288 2013-07-16  Balazs Kelemen  <kbalazs@webkit.org>
289
290         [CMake] Undefined references should be detected at build time
291         https://bugs.webkit.org/show_bug.cgi?id=110236
292
293         Reviewed by Christophe Dumez.
294
295         Add library dependencies that were not defined explicitly before.
296
297         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
298         * TestWebKitAPI/CMakeLists.txt:
299         * WebKitTestRunner/CMakeLists.txt:
300
301 2013-07-16  Kwang Yul Seo  <skyul@company100.net>
302
303         check-webkit-style: "using namespace foo;" should be flagged as an error only in headers
304         https://bugs.webkit.org/show_bug.cgi?id=118755
305
306         Reviewed by Ryosuke Niwa.
307
308         Fix r152719 to check "using namespace foo;" only in headers.
309
310         * Scripts/webkitpy/style/checkers/cpp.py:
311         (check_using_namespace):
312         (check_style):
313         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
314         (WebKitStyleTest.test_using_namespace):
315
316 2013-07-16  Christophe Dumez  <ch.dumez@sisa.samsung.com>
317
318         Get rid of multiple inheritance support from the bindings generators
319         https://bugs.webkit.org/show_bug.cgi?id=118353
320
321         Reviewed by Kentaro Hara.
322
323         Update CodeGeneratorTestRunner.pm to use domInterface->parent instead of
324         deprecated domInterface->parents.
325
326         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
327         (_parentInterface):
328
329 2013-07-16  Brian Holt  <brian.holt@samsung.com>
330
331         check-webkit-style: "using namespace foo;" should be flagged as an error in headers
332         https://bugs.webkit.org/show_bug.cgi?id=57241
333
334         Reviewed by Ryosuke Niwa.
335
336         Added check for "using namespace foo" and unit test.
337
338         * Scripts/webkitpy/style/checkers/cpp.py:
339         (check_using_namespace):
340         (check_style):
341         (CppChecker):
342         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
343         (WebKitStyleTest.test_using_namespace):
344
345 2013-07-16  Anton Obzhirov  <a.obzhirov@samsung.com>
346
347         [GTK] fast/events/platform-wheelevent-with-delta-zero-crash.html is crashing
348         https://bugs.webkit.org/show_bug.cgi?id=110222
349
350         Reviewed by Gustavo Noronha Silva.
351
352         Added handling of zero mouse scroll deltas in EventSender.
353
354         * DumpRenderTree/gtk/EventSender.cpp:
355         (mouseScrollByCallback):
356
357 2013-07-16  Brian Holt  <brian.holt@samsung.com>
358
359         webkitpy: replace urllib with urllib2 for downloading additional modules
360         https://bugs.webkit.org/show_bug.cgi?id=118671
361
362         Reviewed by Ryosuke Niwa.
363
364         Urllib2 is available whereever urllib is, but has better proxy support.
365
366         * Scripts/webkitpy/common/system/autoinstall.py:
367         (AutoInstaller._download_to_stream):
368
369 2013-07-16  Krzysztof Czech  <k.czech@samsung.com>
370
371         [ATK] Adds support for aria-haspopup property.
372         https://bugs.webkit.org/show_bug.cgi?id=117834
373
374         Reviewed by Christophe Dumez.
375
376         Adds implementation for testing aria-haspopup property.
377
378         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
379         (getAttributeSetValueForId):
380         (AccessibilityUIElement::stringAttributeValue):
381         (AccessibilityUIElement::hasPopup):
382         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
383         (WTR::getAttributeSetValueForId):
384         (WTR::AccessibilityUIElement::stringAttributeValue):
385         (WTR::AccessibilityUIElement::hasPopup):
386
387 2013-07-16  Michael Brüning  <michael.bruning@digia.com>
388
389         [Qt] Replace Nokia references.
390         https://bugs.webkit.org/show_bug.cgi?id=118728
391
392         Reviewed by Simon Hausmann.
393
394         * MiniBrowser/qt/MiniBrowserApplication.cpp:
395         (MiniBrowserApplication::MiniBrowserApplication):
396         * QtTestBrowser/qttestbrowser.cpp:
397         (LauncherApplication::LauncherApplication):
398
399 2013-07-15  Tim Horton  <timothy_horton@apple.com>
400
401         Update blocked/missing plug-in UI
402         https://bugs.webkit.org/show_bug.cgi?id=118347
403         <rdar://problem/14209318>
404
405         Reviewed by Sam Weinig.
406
407         * MiniBrowser/mac/WK2BrowserWindowController.m:
408         (-[WK2BrowserWindowController awakeFromNib]):
409         * WebKitTestRunner/TestController.cpp:
410         (WTR::TestController::createWebViewWithOptions):
411         Match new WKPageLoaderClient entry.
412
413 2013-07-15  Chris Fleizach  <cfleizach@apple.com>
414
415         Update James Craig's email address.
416
417         * Scripts/webkitpy/common/config/contributors.json:
418
419 2013-07-15  Dong-Gwan Kim  <donggwan.kim@samsung.com>
420
421         [EFL] Add fallback for TestWebKitAPI if opengl is not available.
422         https://bugs.webkit.org/show_bug.cgi?id=118583
423
424         Reviewed by Christophe Dumez.
425
426         There're many fails on efl webkit2 API test if opengl is not available.
427         So, add fallback to non-opengl evas engine.
428
429         * TestWebKitAPI/efl/PlatformWebView.cpp:
430         (TestWebKitAPI::initEcoreEvas):
431
432 2013-07-15  Brian Holt  <brian.holt@samsung.com>
433
434         check-webkit-style: Ignore false positive: Instance of 'Popen' has no 'pid' member
435         https://bugs.webkit.org/show_bug.cgi?id=118592
436
437         Reviewed by Martin Robinson.
438
439         Added a suppression for pylint false positives and a unit test.
440
441         * Scripts/webkitpy/style/checkers/python.py:
442         (Pylinter):
443         * Scripts/webkitpy/style/checkers/python_unittest.py:
444         (PythonCheckerTest.test_check):
445         (PythonCheckerTest):
446         (PythonCheckerTest.test_pylint_false_positives):
447         (PythonCheckerTest.test_pylint_false_positives._mock_handle_style_error):
448         * Scripts/webkitpy/style/checkers/python_unittest_falsepositives.py: Added.
449         (test_popen):
450
451 2013-07-15  Xabier Rodriguez Calvar  <calvaris@igalia.com>
452
453         [GTK] Increase the JHBuild version of GStreamer to 1.0.7
454         https://bugs.webkit.org/show_bug.cgi?id=115166
455
456         Reviewed by Philippe Normand.
457
458         * gtk/jhbuild.modules: Bumping GStreamer version up to 1.0.8.
459
460 2013-07-12  Kwang Yul Seo  <skyul@company100.net>
461
462         Unreviewed. Add an email address and update my domain of experts.
463
464         * Scripts/webkitpy/common/config/contributors.json:
465
466 2013-07-12  Emanuele Aina  <emanuele.aina@collabora.com>
467
468         [jhbuild] Avoid restarting from scratch failed initial checkouts
469         https://bugs.webkit.org/show_bug.cgi?id=118603
470
471         Reviewed by Martin Robinson.
472
473         If the initial checkout is interrupted midway (eg. because the internet
474         connection went down) config files do not get generated and that causes
475         the next checkout to start from scratch (the missing files cause the
476         script to delete the build root and the downloaded sources).
477
478         By generating the files before invoking jhbuild, subsequent runs are able
479         to start where the previous run left.
480
481         * Scripts/update-webkit-libs-jhbuild:
482         (saveJhbuildMd5): invoke it before runJhbuild().
483
484 2013-07-12  Brent Fulgham  <bfulgham@apple.com>
485
486         [Windows] Remove single-worker restriction on tests.
487
488         * Scripts/webkitpy/port/win.py: Remove restriction of one worker.
489
490 2013-07-12  Commit Queue  <commit-queue@webkit.org>
491
492         Unreviewed, rolling out r152599.
493         http://trac.webkit.org/changeset/152599
494         https://bugs.webkit.org/show_bug.cgi?id=118612
495
496         This patch includes a failing unit test (Requested by
497         mrobinson on #webkit).
498
499         * Scripts/webkitpy/style/checkers/python.py:
500         (Pylinter):
501         * Scripts/webkitpy/style/checkers/python_unittest.py:
502         (PythonCheckerTest.test_check):
503         * Scripts/webkitpy/style/checkers/python_unittest_falsepositives.py: Removed.
504
505 2013-07-12  Emanuele Aina  <emanuele.aina@collabora.com>
506
507         [Tools] Ignore missing GNUmakefile when detecting previous arch in build-webkit
508         https://bugs.webkit.org/show_bug.cgi?id=91223
509
510         Reviewed by Martin Robinson.
511
512         When run on a clean checkout, `build-webkit` complains that no
513         GNUmakefile exists when trying to detect the previously configured
514         architecture, but in this case there's no previous configuration so
515         the warning is pointless.
516
517         * Scripts/webkitdirs.pm:
518         (determineArchitecture): Redirect grep stderr to /dev/null.
519
520 2013-07-12  Brian Holt  <brian.holt@samsung.com>
521
522         check-webkit-style: Ignore false positive: Instance of 'Popen' has no 'pid' member
523         https://bugs.webkit.org/show_bug.cgi?id=118592
524
525         Reviewed by Martin Robinson.
526
527         Added a suppression for pylint false positives and a unit test.
528
529         * Scripts/webkitpy/style/checkers/python.py:
530         (Pylinter):
531         * Scripts/webkitpy/style/checkers/python_unittest.py:
532         (PythonCheckerTest.test_check):
533         (PythonCheckerTest):
534         (PythonCheckerTest.test_pylint_false_positives):
535         (PythonCheckerTest.test_pylint_false_positives._mock_handle_pylint_false_positives):
536         * Scripts/webkitpy/style/checkers/python_unittest_falsepositives.py: Added.
537         (test_popen):
538
539 2013-07-11  Arnaud Renevier  <a.renevier@samsung.com>
540
541         Unreviewed. Add myself as a committer.
542
543         * Scripts/webkitpy/common/config/contributors.json:
544
545 2013-07-10  Sergio Correia  <sergio.correia@openbossa.org>
546
547         Handle "load,provisional,failed" with the on_error callback on EFL MiniBrowser
548         https://bugs.webkit.org/show_bug.cgi?id=118538
549
550         Reviewed by Christophe Dumez.
551
552         When attempting some odd url such as ``foo'', MiniBrowser will now show an
553         error message such as "Cannot resolve hostname (foo)".
554
555         Previously, it had the following behavior if MiniBrowser was started with
556         such urls, e.g ``./MiniBrowser foo'':
557
558         - Debug:
559         It wouldt hit WebKit2/Platform/CoreIPC/unix/ConnectionUnix.cpp(460) and crash.
560
561         - Release:
562         No asserts, naturally, but the view would remain blank, even if we tried to
563         change to a valid url.
564
565         * MiniBrowser/efl/main.c:
566         (window_create):
567
568 2013-07-10  Simon Pena  <simon.pena@samsung.com>
569
570         [GTK] WebKitTestRunner tries to remove an already deleted event in EventSenderProxy::replaySavedEvents
571         https://bugs.webkit.org/show_bug.cgi?id=118509
572
573         Reviewed by Martin Robinson.
574
575         In EventSenderProxy::replaySavedEvents WebKitTestRunner can crash
576         when trying to remove an event already removed, if another event is
577         processed in the middle. By using a Deque's takeFirst, we ensure the
578         element is removed before we dispatch it.
579
580         fast/events/mousedown-inside-dragstart-should-not-cause-crash.html no longer
581         crashes after this fix is added.
582
583         * WebKitTestRunner/EventSenderProxy.h: Use a Deque instead of Vector in GTK
584         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
585         (WTR::EventSenderProxy::replaySavedEvents): Use takeFirst to retrieve the event
586         from the queue.
587
588 2013-07-09  Ryuan Choi  <ryuan.choi@samsung.com>
589
590         [EFL] Add ewk_view_device_pixel_ratio_set
591         https://bugs.webkit.org/show_bug.cgi?id=118521
592
593         Reviewed by Gyuyoung Kim.
594
595         * EWebLauncher/main.c: Added new option(-r) to test device pixel ratio.
596         (windowCreate):
597         (parseUserArguments):
598
599 2013-07-09  Bruno de Oliveira Abinader  <brunoabinader@gmail.com>
600
601         Unreviewed change of my email addresses.
602         https://bugs.webkit.org/show_bug.cgi?id=100122
603
604         * Scripts/webkitpy/common/config/contributors.json:
605
606 2013-07-09  Anders Carlsson  <andersca@apple.com>
607
608         DumpRenderTree should stop sending unsupported URLs to NSWorkspace
609         https://bugs.webkit.org/show_bug.cgi?id=118514
610         <rdar://problem/13686836>
611
612         Reviewed by Sam Weinig.
613
614         Add a new default policy delegate and override decidePolicyForNavigationAction: to not pass unhandled URLs to NSWorkspace.
615
616         * DumpRenderTree/DefaultPolicyDelegate.h: Added.
617         * DumpRenderTree/DefaultPolicyDelegate.m: Added.
618         (-[DefaultPolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
619         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
620         Add DefaultPolicyDelegate.h and DefaultPolicyDelegate.m.
621
622         * DumpRenderTree/mac/DumpRenderTree.mm:
623         (allocateGlobalControllers):
624         Allocate a DefaultPolicyDelegate object.
625
626         (resetWebViewToConsistentStateBeforeTesting):
627         Set the policy delegate to the default policy delegate.
628
629         * DumpRenderTree/mac/DumpRenderTreeMac.h:
630         Declare the defaultPolicyDelegate object.
631
632         * DumpRenderTree/mac/TestRunnerMac.mm:
633         (TestRunner::setCustomPolicyDelegate):
634         Set the policy delegate to the default delegate if setDelegate is false.
635
636 2013-07-08  Zan Dobersek  <zdobersek@igalia.com>
637
638         KURL unit test fixture class should have a meaningful name
639         https://bugs.webkit.org/show_bug.cgi?id=118467
640
641         Reviewed by Sam Weinig.
642
643         * TestWebKitAPI/Tests/WebCore/KURL.cpp:
644         (TestWebKitAPI::TEST_F): Use 'KURLTest' as the name for the KURL unit test's fixture class
645         instead of the generic and inappropriate 'WebCore' name.
646
647 2013-07-08  Antti Koivisto  <antti@apple.com>
648
649         Add Deque::removeLast
650         https://bugs.webkit.org/show_bug.cgi?id=118466
651
652         Reviewed by Andreas Kling.
653
654         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
655         * TestWebKitAPI/Tests/WTF/Deque.cpp: Added.
656         (TestWebKitAPI::TEST):
657
658 2013-07-08  Brian Holt  <brian.holt@samsung.com>
659
660         [GTK] Leak: GFile* leaking in beginDragWithFilesCallback
661         https://bugs.webkit.org/show_bug.cgi?id=118412
662
663         Reviewed by Martin Robinson.
664
665         An adoptRef is required to balance ref and deref calls.
666
667         * DumpRenderTree/gtk/EventSender.cpp:
668         (beginDragWithFilesCallback):
669
670 2013-07-06  Sergio Correia  <sergio.correia@openbossa.org>
671
672         Update list of EFL WK2 API tests
673         https://bugs.webkit.org/show_bug.cgi?id=118443
674
675         Reviewed by Christophe Dumez.
676
677         The following tests were included:
678
679         Passing:
680         - CloseThenTerminate
681         - DidAssociateFormControls
682         - PageVisibilityState
683         - ResponsivenessTimerDoesntFireEarly
684         - TerminateTwice
685         - WillLoad
686
687         Failing:
688         - ResizeReversePaginatedWebView
689         - ScrollPinningBehaviors
690
691         This patch also modified ``test_webkit2_api_BINARIES'' list so that it is in
692         alphabetical order.
693
694         * TestWebKitAPI/CMakeLists.txt: Added Bundles for included tests.
695         * TestWebKitAPI/PlatformEfl.cmake: Added a few tests.
696
697 2013-07-05  Tim Horton  <timothy_horton@apple.com>
698
699         Fix r152265: FrameView's pagination mode is only one of two, and the logic was totally wrong
700         https://bugs.webkit.org/show_bug.cgi?id=118439
701         <rdar://problem/14366120>
702
703         Reviewed by Anders Carlsson.
704
705         * TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp:
706         (TestWebKitAPI::didLayout):
707         (TestWebKitAPI::TEST):
708         - Make use of EXPECT_JS_EQ instead of manually doing JavaScript stuff.
709         - Assert that we got the right number of pages for sanity.
710         - Reduce the page gap size so that DrawingAreaImpl doesn't try to allocate
711             so much memory that SharedMemory asserts and makes the test time out.
712         - Use didFirstLayoutAfterSuppressedIncrementalRendering instead of Paint
713             because paint doesn't fire if the window is offscreen.
714
715 2013-07-05  Tim Horton  <timothy_horton@apple.com>
716
717         [wk2] Add API to lock the scroll position at the top or bottom of the page
718         https://bugs.webkit.org/show_bug.cgi?id=118429
719         <rdar://problem/14120323>
720
721         Reviewed by Anders Carlsson.
722
723         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
724         * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp: Added.
725         (TestWebKitAPI::didFinishDocumentLoadForFrame):
726         (TestWebKitAPI::TEST):
727         Add a test that ensures that the three pinning modes (DoNotPin, PinToTop, PinToBottom)
728         all work correctly in the face of resizing the view and scrolling from JS.
729
730 2013-07-05  Michael Pruett  <michael@68k.org>
731
732         Unreviewed. Add myself as a committer.
733
734         * Scripts/webkitpy/common/config/contributors.json:
735
736 2013-07-05  Xabier Rodriguez Calvar  <calvaris@igalia.com>
737
738         [GTK] WebKit2 test TestWebKitFaviconDatabase times out with recent glib
739         https://bugs.webkit.org/show_bug.cgi?id=111434
740
741         Reviewed by Carlos Garcia Campos.
742
743         * Scripts/run-gtk-tests:
744         (TestRunner): Unskipped TestWebKitFaviconDatabase tests.
745
746 2013-07-04  Viatcheslav Ostapenko  <sl.ostapenko@samsung.com>
747
748         [EFL] DumpRenderTree doesn't run if "opengl_x11" engine is not available
749         https://bugs.webkit.org/show_bug.cgi?id=118370
750
751         Reviewed by Christophe Dumez.
752
753         Add fallback to software X11 engine if opengl_x11 engine creation fails.
754
755         * DumpRenderTree/efl/DumpRenderTree.cpp:
756         (initEcoreEvas):
757
758 2013-07-04  Brian Holt  <brian.holt@samsung.com>
759
760         [ATK] Leak: AtkAttributeSet* should be freed
761         https://bugs.webkit.org/show_bug.cgi?id=118307
762
763         Reviewed by Christophe Dumez.
764
765         Fixed memory leaks for AtkAttributeSet by calling
766         atk_attribute_set_free().
767
768         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
769         (AccessibilityController::childElementById):
770         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
771         (getAtkAttributeSetAsString):
772         (AccessibilityUIElement::allAttributes):
773         (AccessibilityUIElement::stringAttributeValue):
774         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
775         (WTR::childElementById):
776         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
777         (WTR::getAtkAttributeSetAsString):
778         (WTR::AccessibilityUIElement::allAttributes):
779         (WTR::AccessibilityUIElement::stringAttributeValue):
780
781 2013-07-03  David Farler  <dfarler@apple.com>
782
783         Add Makefile to WebKitLauncher
784         https://bugs.webkit.org/show_bug.cgi?id=118365
785
786         Reviewed by Mark Rowe.
787
788         * WebKitLauncher/Makefile: Added.
789
790 2013-07-03  Brian Holt  <brian.holt@samsung.com>
791
792         [ATK] Leak: more leaks in AccessibilityUIElement
793         https://bugs.webkit.org/show_bug.cgi?id=118362
794
795         Reviewed by Christophe Dumez.
796
797         Free the memory created by g_strdup_printf.
798
799         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
800         (AccessibilityUIElement::language):
801         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
802         (WTR::AccessibilityUIElement::language):
803
804 2013-07-03  Jer Noble  <jer.noble@apple.com>
805
806         Xcode often gets in a state where the debugger is completely unresponsive
807         https://bugs.webkit.org/show_bug.cgi?id=118157
808
809         The GetPointeeData() operations we use to retrieve strings is extremely expensive.
810         Rather than pull the character data out of the debugger one byte at a time
811         through the GetPointeeData() API, retrieve the memory contents of the string through
812         the ReadMemory() API, and convert the retrieved memory into a python string.
813
814         Reviewed by Anders Carlsson.
815
816         * lldb/lldb_webkit.py:
817         (__lldb_init_module.lldb_webkit):
818         (guess_string_length):
819         (ustring_to_string):
820         (lstring_to_string):
821
822 2013-07-03  Morten Stenshorne  <mstensho@opera.com>
823
824         [GTK] Let F5 refresh the page in MiniBrowser
825         https://bugs.webkit.org/show_bug.cgi?id=117638
826
827         Reviewed by Carlos Garcia Campos.
828
829         Also use the correct icon for the refresh button that was already there.
830
831         * MiniBrowser/gtk/BrowserWindow.c:
832         (browser_window_init):
833
834 2013-07-02  Kondapally Kalyan  <kalyan.kondapally@intel.com>
835
836         Unreviewed. Add my email to a few watchlists.
837
838         * Scripts/webkitpy/common/config/watchlist:
839
840 2013-07-02  David Farler  <dfarler@apple.com>
841
842         Unreviewed. Adding myself to contributors.json.
843
844         * Scripts/webkitpy/common/config/contributors.json:
845
846 2013-07-02  Brian Holt  <brian.holt@samsung.com>
847
848         [ATK] Leak: leaks in AccessibilityUIElement
849         https://bugs.webkit.org/show_bug.cgi?id=118297
850
851         Fixed memory leak.
852
853         Reviewed by Christophe Dumez.
854
855         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
856         (AccessibilityUIElement::stringValue):
857
858 2013-07-02  Byungwoo Lee  <bw80.lee@samsung.com>
859
860         Fix WebKitTestRunner crashes.
861         https://bugs.webkit.org/show_bug.cgi?id=117630
862
863         Reviewed by Darin Adler.
864
865         Create static function to dump for WebProcess unresponsiveness status,
866         and use it before calling TestController::runTest().
867
868         Accessing TestController::m_currentInvocation before calling
869         TestController::runTest() can make crash because the invocation
870         instance will be assigned at the function.
871
872         * WebKitTestRunner/TestController.cpp:
873         (WTR::TestController::run):
874         * WebKitTestRunner/TestInvocation.cpp:
875         (WTR::TestInvocation::dumpWebProcessUnresponsiveness):
876         * WebKitTestRunner/TestInvocation.h:
877
878 2013-07-02  Allan Sandfeld Jensen  <allan.jensen@digia.com>
879
880         [Qt][WK1] Support WebGL with EGL on Linux
881         https://bugs.webkit.org/show_bug.cgi?id=118251
882
883         Reviewed by Kenneth Rohde Christiansen.
884
885         * qmake/mkspecs/features/features.prf:
886
887 2013-07-01  Nick Diego Yamane  <nick.yamane@openbossa.org>
888
889         [Efl][Gtk] Look at WEBKIT_OUTPUTDIR instead of WEBKITOUTPUTDIR in jhbuildrc
890         https://bugs.webkit.org/show_bug.cgi?id=118267
891
892         Reviewed by Gyuyoung Kim.
893
894         After r152226 (from https://bugs.webkit.org/show_bug.cgi?id=117249)
895         WEBKIT_OUTPUTDIR should be used instead of WEBKITOUPUTDIR. However
896         Efl's jhbuildrc is still using the WEBKITOUTPUTDIR environment variable.
897
898         * efl/jhbuildrc:
899         * gtk/jhbuildrc:
900
901 2013-07-01  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
902
903         [GTK] Remove unsupported AC backends
904         https://bugs.webkit.org/show_bug.cgi?id=117362
905
906         Reviewed by Martin Robinson.
907
908         * gtk/jhbuild-optional.modules: no longer needs clutter-gtk, clutter
909         and cogl, so removed.
910
911 2013-07-01  Timothy Hatcher  <timothy@apple.com>
912
913         Link to WebInspectorUI.framework at build time instead of soft linking.
914
915         https://bugs.webkit.org/show_bug.cgi?id=118261
916
917         Reviewed by Joseph Pecoraro.
918
919         * Scripts/build-webkit: Build WebInspectorUI before WebKit and WebKit2.
920
921 2013-07-01  Tim Horton  <timothy_horton@apple.com>
922
923         Maximum scroll position can be negative in some cases
924         https://bugs.webkit.org/show_bug.cgi?id=118175
925         <rdar://problem/14301217>
926
927         Reviewed by Anders Carlsson.
928
929         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
930         * TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp: Added.
931         (TestWebKitAPI::didRunJavaScript):
932         (TestWebKitAPI::didLayout):
933         (TestWebKitAPI::TEST):
934         * TestWebKitAPI/Tests/WebKit2/lots-of-text-vertical-lr.html: Added.
935         Add a test that loads a vertical-lr document, paginates it horizontally
936         from right to left, resizes the view to fit the entire document, and
937         verifies that the scroll position is negative, as it must be for the
938         document to be enclosed by the view.
939
940 2013-07-01  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
941
942         [EFL][GTK] Migrate from WEBKITOUTPUTDIR to WEBKIT_OUTPUTDIR
943         https://bugs.webkit.org/show_bug.cgi?id=117249
944
945         Reviewed by Brent Fulgham.
946
947         Finish converting all use cases of WEBKITOUTPUTDIR to
948         WEBKIT_OUTPUTDIR, which seems to be preferred these days.
949
950         * DumpRenderTree/efl/FontManagement.cpp:
951         (getCustomBuildDir):
952         (getPlatformFontsPath):
953         * DumpRenderTree/gtk/DumpRenderTree.cpp:
954         (getOutputDir):
955         * Scripts/webkitdirs.pm:
956         (determineBaseProductDir):
957         (usesPerConfigurationBuildDirectory):
958         * Scripts/webkitpy/port/base.py:
959         (Port.to.setup_environ_for_server):
960         * Scripts/webkitpy/port/driver.py:
961         (Driver._setup_environ_for_driver):
962         * Scripts/webkitpy/port/gtk.py:
963         (GtkPort.setup_environ_for_server):
964         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
965         (WTR::getOutputDir):
966         * jhbuild/jhbuildutils.py:
967         (get_dependencies_path):
968
969 2013-07-01  Rafael Brandao  <rafael.lobo@webkit.org>
970
971         Unreviewed change of my email address.
972
973         * Scripts/webkitpy/common/config/contributors.json:
974
975 2013-06-28  Andreas Kling  <akling@apple.com>
976
977         Fix Windows builds after deprecatedCharactersWithNullTermination() removal.
978
979         * DumpRenderTree/win/DumpRenderTree.cpp:
980         (addFontFallbackIfPresent):
981         (removeFontFallbackIfPresent):
982
983 2013-06-28  Anders Carlsson  <andersca@apple.com>
984
985         Remove String::deprecatedCharactersWithNullTermination() and related code
986         https://bugs.webkit.org/show_bug.cgi?id=118211
987
988         Reviewed by Benjamin Poulain.
989
990         Remove all hasTerminatingNullCharacter() checks.
991
992         * TestWebKitAPI/Tests/WTF/AtomicString.cpp:
993         (TestWebKitAPI::TEST):
994         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
995         (TestWebKitAPI::TEST):
996         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
997         (TestWebKitAPI::TEST):
998
999 2013-06-28  Alexey Proskuryakov  <ap@apple.com>
1000
1001         [Mac] Crash when loading is stopped from -didReceiveResponse
1002         https://bugs.webkit.org/show_bug.cgi?id=118209
1003         <rdar://problem/14259249>
1004
1005         Reviewed by Brady Eidson.
1006
1007         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1008         * TestWebKitAPI/Tests/mac/StopLoadingFromDidReceiveResponse.html: Added.
1009         * TestWebKitAPI/Tests/mac/StopLoadingFromDidReceiveResponse.mm: Added.
1010         (-[StopLoadingFromDidReceiveResponse webView:resource:didReceiveResponse:fromDataSource:]):
1011         (TestWebKitAPI::TEST):
1012
1013 2013-06-28  Andy Estes  <aestes@apple.com>
1014
1015         [Mac] Newer versions of clang use a default template instantiation depth that is too small for TestWebKitAPI
1016         https://bugs.webkit.org/show_bug.cgi?id=118208
1017
1018         Reviewed by Mark Rowe.
1019
1020         Newer versions of clang use a default template depth of 128, but this
1021         is too small for Tests/WTF/HashSet.cpp. Use 256 instead, which was the
1022         previous default.
1023
1024         Clang lowered the default to keep recursive template instantiation
1025         from overflowing the stack (see <rdar://problem/13935016>), but
1026         TestWebKitAPI's C++ files don't trigger a stack overflow even with the
1027         higher limit. If for some reason this starts happening then we can
1028         lower the limit back down.
1029
1030         * TestWebKitAPI/Configurations/Base.xcconfig: Build TestWebKitAPI with -ftemplate-depth=256.
1031
1032 2013-06-28  Nick Diego Yamane  <nick.yamane@openbossa.org>
1033
1034         [Tools] Add support for "webKitBranchBuild" git option when calculating jhbuildPath
1035         https://bugs.webkit.org/show_bug.cgi?id=118195
1036
1037         Reviewed by Daniel Bates.
1038
1039         Currently, ports that use jhbuild fail to determine jhbuild directory
1040         when "webKitBranchBuild" git configuration property is enabled. To reproduce
1041         that issue in Efl port, enable that flag in .git/config, switch to a git branch
1042         other than "master" and try to build webkit. The build will fail to
1043         locate dependencies due to lack of pkg-config paths which should be set
1044         by jhbuild.
1045
1046         For more details about "webKitBranchBuild" option, see:
1047         https://trac.webkit.org/wiki/UsingGitWithWebKit
1048
1049         * Scripts/webkitdirs.pm:
1050         (getJhbuildPath):
1051
1052 2013-06-28  Jessie Berlin  <jberlin@apple.com>
1053
1054         WebKitTestRunner should disable automatic quote and dash substitution like DumpRenderTree does
1055         https://bugs.webkit.org/show_bug.cgi?id=118201
1056
1057         Reviewed by Dean Jackson.
1058
1059         * WebKitTestRunner/mac/main.mm:
1060         (main):
1061         Modify NSUserDefaults directly since setAutomaticQuoteSubstitutionEnabled and
1062         setAutomaticDashSubstitutionEnabled are not exposed on WKView.
1063
1064 2013-06-28  David Farler  <dfarler@apple.com>
1065
1066         Upstream WebKit Nightly’s WebKitLauncher
1067         https://bugs.webkit.org/show_bug.cgi?id=117418
1068
1069         Reviewed by Mark Rowe.
1070
1071         Literal patch from Nightly's OpenSource repo.
1072
1073         * WebKitLauncher/Configurations/Base.xcconfig:
1074         * WebKitLauncher/Configurations/WebKitLauncher.xcconfig:
1075         * WebKitLauncher/Info.plist:
1076         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
1077         * WebKitLauncher/WebKitLauncherURLProtocol.m:
1078         (+[WebKitLauncherURLProtocol load]):
1079         (+[WebKitLauncherURLProtocol canInitWithRequest:]):
1080         (-[WebKitLauncherURLProtocol startLoading]):
1081         (-[WebKitLauncherURLProtocol handleWebKitVersionInformation]):
1082         (-[WebKitLauncherURLProtocol resourceNotFound]):
1083         * WebKitLauncher/WebKitNightlyEnablerSparkle.m:
1084         (initializeSparkle):
1085         * WebKitLauncher/main.m:
1086         (determineExecutablePath):
1087         (currentMacOSXVersion):
1088         (main):
1089         * WebKitLauncher/start.html:
1090
1091 2013-06-28  Balazs Kelemen  <b.kelemen@samsung.com>
1092
1093         [EFL] back/forward keyboard shortcuts are non-intuitive
1094         https://bugs.webkit.org/show_bug.cgi?id=118193
1095
1096         Reviewed by Christophe Dumez.
1097
1098         Changed shortcuts for go-back/go-forward to alt+left and alt+right.
1099
1100         * EWebLauncher/main.c:
1101         (on_key_down):
1102         * MiniBrowser/efl/main.c:
1103         (on_key_down):
1104
1105 2013-06-28  Roger Fong  <roger_fong@apple.com>
1106
1107         Enable AVFoundation in Web Prefs for WinLauncher and DumpRenderTree on Windows.
1108         https://bugs.webkit.org/show_bug.cgi?id=118194.
1109
1110         Reviewed by Brent Fulgham.
1111
1112         * DumpRenderTree/win/DumpRenderTree.cpp:
1113         (dllLauncherEntryPoint):
1114         * WinLauncher/WinLauncher.cpp:
1115         (dllLauncherEntryPoint):
1116
1117 2013-06-28  Roger Fong  <roger_fong@apple.com>
1118
1119         Unreviewed build fix for AppleWin port. Fix some file paths.
1120
1121         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
1122         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters:
1123
1124 2013-06-27  Roger Fong  <roger_fong@apple.com>
1125
1126         Add IAccessibilityDelegate implementation to WinLauncher for testing purposes.
1127         https://bugs.webkit.org/show_bug.cgi?id=118160.
1128
1129         Reviewed by Brent Fulgham.
1130
1131         * WinLauncher/AccessibilityDelegate.cpp: Added.
1132         (AccessibilityDelegate::QueryInterface):
1133         (AccessibilityDelegate::AddRef):
1134         (AccessibilityDelegate::Release):
1135         (AccessibilityDelegate::fireFrameLoadStartedEvents): Just returns S_OK;
1136         (AccessibilityDelegate::fireFrameLoadFinishedEvents): Ditto.
1137         * WinLauncher/AccessibilityDelegate.h: Added.
1138         (AccessibilityDelegate::AccessibilityDelegate):
1139         * WinLauncher/WinLauncher.cpp:
1140         (dllLauncherEntryPoint):
1141         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
1142         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters:
1143
1144 2013-06-28  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1145
1146         Clean up temporary files created by the bindings test script
1147         https://bugs.webkit.org/show_bug.cgi?id=118189
1148
1149         Reviewed by Kentaro Hara.
1150
1151         Remove temporary files created by preprocess-idls.pl script after
1152         the bindings tests are executed.
1153
1154         Based on Blink 153236 by Kentaro Hara <haraken@chromium.org>.
1155
1156         * Scripts/webkitpy/bindings/main.py:
1157         (BindingsTests.main):
1158
1159 2013-06-26  Dean Jackson  <dino@apple.com>
1160
1161         [Mac] Add Mavericks system font to Test systems
1162         https://bugs.webkit.org/show_bug.cgi?id=118109
1163
1164         Reviewed by Simon Fraser.
1165
1166         OS X Mavericks uses a different font for system controls. Tell DRT and
1167         WKTR about them otherwise they use a fallback font. Unfortunately the
1168         fonts are hidden (not found in the list of available fonts) so I
1169         had to add them manually.
1170
1171         Even though there is only one at the moment, I implemented this
1172         as a set so it will be easier to add new fonts if necessary.
1173
1174         * DumpRenderTree/mac/DumpRenderTree.mm:
1175         (allowedFontFamilySet): Fixed typo.
1176         (systemHiddenFontFamilySet): New method that returns the system control font.
1177         (drt_NSFontManager_availableFonts): Merge the hidden fonts.
1178         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
1179         (WTR::allowedFontFamilySet): Fixed typo.
1180         (WTR::systemHiddenFontFamilySet): As above.
1181         (WTR::wtr_NSFontManager_availableFonts):
1182
1183 2013-06-27  Anders Carlsson  <andersca@apple.com>
1184
1185         Get rid of the last uses of deprecatedCharactersWithNullTermination()
1186         https://bugs.webkit.org/show_bug.cgi?id=118159
1187
1188         Reviewed by Andreas Kling.
1189
1190         Replace calls to deprecatedCharactersWithNullTermination() with charactersWithNullTermination().data().
1191
1192         * DumpRenderTree/win/DumpRenderTree.cpp:
1193         (findFontFallback):
1194
1195 2013-06-27  Bem Jones-Bey  <bjonesbe@adobe.com>
1196
1197         Sync up w3c import script with changes in Blink
1198         https://bugs.webkit.org/show_bug.cgi?id=118149
1199
1200         Reviewed by Dirk Pranke.
1201
1202         This is a port of the following blink changes:
1203
1204         https://codereview.chromium.org/15366004
1205         https://chromiumcodereview.appspot.com/15592005
1206         https://codereview.chromium.org/16021006
1207         https://codereview.chromium.org/15590004
1208         https://codereview.chromium.org/15901008
1209         https://codereview.chromium.org/16171009
1210         https://codereview.chromium.org/16465007
1211         https://codereview.chromium.org/15981013
1212
1213         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1214         (setUp):
1215         (test_commit_message_for_this_commit):
1216         * Scripts/webkitpy/port/base.py:
1217         (Port):
1218         * Scripts/webkitpy/port/test.py:
1219         * Scripts/webkitpy/w3c/test_converter.py:
1220         (W3CTestConverter.__init__):
1221         (W3CTestConverter.read_webkit_prefixed_css_property_list):
1222         (W3CTestConverter.convert_for_webkit):
1223         (W3CTestConverter.convert_css):
1224         (W3CTestConverter.convert_html):
1225         (W3CTestConverter.convert_testharness_paths):
1226         (W3CTestConverter.convert_prefixed_properties):
1227         (W3CTestConverter.add_webkit_prefix_to_unprefixed_properties):
1228         * Scripts/webkitpy/w3c/test_converter_unittest.py:
1229         * Scripts/webkitpy/w3c/test_importer.py:
1230         (main):
1231         (configure_logging):
1232         (configure_logging.LogHandler):
1233         (configure_logging.LogHandler.format):
1234         (parse_args):
1235         (TestImporter.__init__):
1236         (TestImporter.find_importable_tests):
1237         (TestImporter.import_tests):
1238         (TestImporter.setup_destination_directory):
1239         (TestImporter.remove_deleted_files):
1240         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1241         (TestImporterTest.test_import_dir_with_no_tests_and_no_hg):
1242         (TestImporterTest.test_import_dir_with_no_tests):
1243         (TestImporterTest):
1244         * Scripts/webkitpy/w3c/test_parser.py:
1245         (TestParser.load_file):
1246         (TestParser.analyze_test):
1247         (TestParser.support_files):
1248         * Scripts/webkitpy/w3c/test_parser_unittest.py:
1249
1250 2013-06-27  Csaba Osztrogonác  <ossy@webkit.org>
1251
1252         [webkitpy] AbstractPatchSequencingCommand should have _prepare_state
1253         https://bugs.webkit.org/show_bug.cgi?id=118128
1254
1255         Reviewed by Ryosuke Niwa.
1256
1257         It is a preparation for a new webkit-patch command: run-tests-touched-by-attachment
1258         https://bugs.webkit.org/show_bug.cgi?id=117831
1259
1260         * Scripts/webkitpy/tool/commands/download.py:
1261         (AbstractPatchSequencingCommand):
1262         (AbstractPatchSequencingCommand._prepare_to_process): Call _prepare_state before prepare_steps.
1263         (AbstractPatchSequencingCommand._process_patch): Use the same initial state for each patch.
1264         (AbstractPatchSequencingCommand._prepare_state): Added.
1265
1266 2013-06-27  Brendan Long  <b.long@cablelabs.com>
1267
1268         [Qt] Build overrides -j when given --makeargs="-sj40"
1269         https://bugs.webkit.org/show_bug.cgi?id=116897
1270
1271         Reviewed by Csaba Osztrogonác.
1272
1273         * Scripts/webkitdirs.pm:
1274         (buildQMakeProjects):
1275         Change regex checking for -j* to also check for -*j*
1276
1277 2013-06-27  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1278
1279         Remove [NoInterfaceObject] from WorkerGlobalScope
1280         https://bugs.webkit.org/show_bug.cgi?id=118071
1281
1282         Reviewed by Kentaro Hara.
1283
1284         Update bindings test script to pass 2 additional parameters
1285         now needed by the preprocess-idls.pl script.
1286
1287         * Scripts/webkitpy/bindings/main.py:
1288         (BindingsTests.generate_supplemental_dependency):
1289         (BindingsTests.main):
1290
1291 2013-06-27  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1292
1293         Fixing some compiler warnings
1294         https://bugs.webkit.org/show_bug.cgi?id=117791
1295
1296         Reviewed by Martin Robinson.
1297
1298         * GNUmakefile.am: Silenced format warning.
1299         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
1300         (TestWebKitAPI::DOMWindowExtensionNoCache::globalObjectIsAvailableForFrame):
1301         Solved warning about uninitialized variable.
1302
1303 2013-06-27  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1304
1305         Fix bindings tests after r152080
1306         https://bugs.webkit.org/show_bug.cgi?id=118118
1307
1308         Reviewed by Gyuyoung Kim.
1309
1310         r152080 renamed argument to preprocess-idls.pl from --workerContextConstructorsFile
1311         to --workerGlobalScopeConstructorsFile. This patch updates to bindings test script
1312         accordingly.
1313
1314         * Scripts/webkitpy/bindings/main.py:
1315         (BindingsTests.generate_supplemental_dependency):
1316         (BindingsTests.main):
1317
1318 2013-06-26  Carlos Garcia Campos  <cargarcia@blackberry.com>
1319
1320         [BlackBerry] Handle testRunner.setCustomPolicyDelegate()
1321         https://bugs.webkit.org/show_bug.cgi?id=117982
1322
1323         Reviewed by Rob Buis.
1324
1325         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
1326         (BlackBerry::WebKit::DumpRenderTree::DumpRenderTree): Initialize
1327         m_policyDelegateIsPermissive.
1328         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
1329         Reset m_policyDelegateIsPermissive.
1330         (BlackBerry::WebKit::DumpRenderTree::setCustomPolicyDelegate): Set
1331         m_policyDelegateIsPermissive.
1332         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
1333         (BlackBerry::WebKit::DumpRenderTree::policyDelegateEnabled):
1334         Return whether custom policy is enabled.
1335         (BlackBerry::WebKit::DumpRenderTree::policyDelegateIsPermissive):
1336         Return whether custom policy is permissive.
1337
1338 2013-06-26  Anders Carlsson  <andersca@apple.com>
1339
1340         Deprecate StringImpl::charactersWithNullTermination
1341         https://bugs.webkit.org/show_bug.cgi?id=118108
1342
1343         Reviewed by Beth Dakin.
1344
1345         Rename calls to charactersWithNullTermination to deprecatedCharactersWithNullTermination.
1346
1347         * DumpRenderTree/win/DumpRenderTree.cpp:
1348         (findFontFallback):
1349         (addFontFallbackIfPresent):
1350         (removeFontFallbackIfPresent):
1351
1352 2013-06-26  Nico Weber  <thakis@chromium.org>
1353
1354         Remove detect-mismached-virtual-const.
1355         https://bugs.webkit.org/show_bug.cgi?id=117999
1356
1357         Reviewed by Anders Carlsson.
1358
1359         Clang warns on mismatched virtual const, so there's no need for this
1360         script any more.
1361
1362         * Scripts/detect-mismatched-virtual-const: Removed.
1363
1364 2013-06-26  Alex Christensen  <achristensen@apple.com>
1365
1366         Added a code coverage report.
1367         https://bugs.webkit.org/show_bug.cgi?id=117941
1368
1369         Reviewed by Joseph Pecoraro.
1370
1371         * CodeCoverage: Added.
1372         * CodeCoverage/results-template.html: Added.
1373         * Scripts/generate-coverage-data: Generate and open the new report.
1374
1375 2013-06-25  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1376
1377         gdb: Remove the webcore.py pretty printer.
1378         https://bugs.webkit.org/show_bug.cgi?id=117992
1379
1380         Reviewed by Jochen Eisinger.
1381
1382         webcore.py has been only a placeholder for backwards compatibility
1383         for almost 3 years. It should be safe enough to remove it now.
1384
1385         * gdb/webcore.py: Removed.
1386
1387 2013-05-26  Peter Gal  <galpeter@inf.u-szeged.hu>
1388
1389         Creating cURL watchlist and adding myself to it.
1390
1391         Reviewed by Csaba Osztrogonác.
1392
1393         * Scripts/webkitpy/common/config/watchlist:
1394
1395 2013-06-25  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1396
1397         Unreviewed, change my email address for watch list.
1398
1399         * Scripts/webkitpy/common/config/watchlist:
1400
1401 2013-06-25  Byungwoo Lee  <bw80.lee@samsung.com>
1402
1403         [EFL] Add a script to install dependencies.
1404         https://bugs.webkit.org/show_bug.cgi?id=117968
1405
1406         Reviewed by Christophe Dumez.
1407
1408         Add a script which installs basic dependencies for building WebKit EFL.
1409
1410         The dependencies are from the current EFLWebKit wiki page.
1411         After this patch is landed, the wiki page will be updated to use
1412         this script.
1413
1414         * efl/install-dependencies: Added.
1415
1416 2013-06-24  Dean Jackson  <dino@apple.com>
1417
1418         [Mac] Update font used for Chinese in test systems
1419         https://bugs.webkit.org/show_bug.cgi?id=117970
1420
1421         Reviewed by Alexey Proskuryakov.
1422
1423         Add "Songti TC" and "Songti SC" to the list of allowed fonts
1424         in DRT and WKTR.
1425
1426         * DumpRenderTree/mac/DumpRenderTree.mm:
1427         (allowedFontFamilySet):
1428         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
1429         (WTR::allowedFontFamilySet):
1430
1431 2013-06-24  Tim Horton  <timothy_horton@apple.com>
1432
1433         Make MiniBrowser paginated mode work with WebKit1
1434         https://bugs.webkit.org/show_bug.cgi?id=117950
1435
1436         Reviewed by Beth Dakin.
1437
1438         * MiniBrowser/mac/WK1BrowserWindowController.m:
1439         (-[WK1BrowserWindowController isPaginated]):
1440         (-[WK1BrowserWindowController togglePaginationMode:]):
1441         Hook up isPaginated and togglePaginationMode just as for WebKit2.
1442
1443 2013-06-24  David Kilzer  <ddkilzer@apple.com>
1444
1445         bisect-builds: improve heuristic for choosing the next build after a broken build
1446         <http://webkit.org/b/117918>
1447
1448         Reviewed by Simon Fraser.
1449
1450         * Scripts/bisect-builds: When a build is broken, use a heuristic
1451         that "bisects" the left side or the right side of the remaining
1452         revisions to pick a revision that's sufficiently different from
1453         the revision of the broken build.  This heuristic assumes there
1454         is a sequential range of broken builds whenever one broken build
1455         is found.
1456
1457 2013-06-24  Chris Rogers  <crogers@google.com>
1458
1459         WaveTable name has changed to PeriodicWave
1460         https://bugs.webkit.org/show_bug.cgi?id=117748
1461
1462         Reviewed by Jer Noble.
1463
1464         * Scripts/do-webcore-rename:
1465
1466 2013-06-22  Santosh Mahto  <santosh.ma@samsung.com>
1467
1468         [EFL] Add support for MHTML save/load feature to MiniBrowser
1469         https://bugs.webkit.org/show_bug.cgi?id=106620
1470
1471         Reviewed by Christophe Dumez.
1472
1473         Enable CTRL + S as save page in mhtml and CTRL + L to load any page
1474         from filesystem.
1475
1476         * MiniBrowser/efl/CMakeLists.txt:
1477         * MiniBrowser/efl/main.c:
1478         (page_contents_callback):
1479         (on_key_down):
1480         (show_file_entry_dialog): generic function to show file enrty
1481         selector dialogue
1482
1483 2013-06-21  Brent Fulgham  <bfulgham@apple.com>
1484
1485         [Windows] Unreviewed crash protection for DRT
1486
1487         * DumpRenderTree/win/AccessibilityUIElementWin.cpp: Check for null elements in routines
1488         to avoid crashing during test runs.
1489
1490 2013-06-21  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1491
1492         REGRESSION (r150663): Using webkitAudioContext in Inspector makes it undefined everywhere
1493         https://bugs.webkit.org/show_bug.cgi?id=117825
1494
1495         Reviewed by Kentaro Hara.
1496
1497         DumpRenderTreeSupportEfl::setWebAudioEnabled() now requires an additional view argument.
1498
1499         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1500         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
1501         * DumpRenderTree/efl/TestRunnerEfl.cpp:
1502         (TestRunner::overridePreference):
1503
1504 2013-06-21  Krzysztof Czech  <k.czech@samsung.com>
1505
1506         [ATK] Added support for aria-required attribute.
1507         https://bugs.webkit.org/show_bug.cgi?id=117730
1508
1509         Reviewed by Chris Fleizach.
1510
1511         Added support for testing aria-required attribute.
1512
1513         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1514         (AccessibilityUIElement::isRequired):
1515         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1516         (WTR::AccessibilityUIElement::isRequired):
1517
1518 2013-06-20  Ryuan Choi  <ryuan.choi@samsung.com>
1519
1520         [CMAKE][EFL] Enable DOM4 Events Constructor
1521         https://bugs.webkit.org/show_bug.cgi?id=117858
1522
1523         Reviewed by Laszlo Gombos.
1524
1525         * Scripts/webkitperl/FeatureList.pm: Enable the feature for the EFL port.
1526
1527 2013-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
1528
1529         [BlackBerry] Handle testRunner.setWillSendRequestReturnsNull() in DRT
1530         https://bugs.webkit.org/show_bug.cgi?id=117827
1531
1532         Reviewed by Rob Buis.
1533
1534         Reset the passed in request if willSendRequestReturnsNull() is
1535         true or willSendRequestReturnsNullOnRedirect() is true and it's a
1536         redirection.
1537
1538         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
1539         (BlackBerry::WebKit::DumpRenderTree::willSendRequestForFrame):
1540         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
1541
1542 2013-06-20  Csaba Osztrogonác  <ossy@webkit.org>
1543
1544         Commit queue shouldn't reopen unrelated bugs because of flakiness
1545         https://bugs.webkit.org/show_bug.cgi?id=117503
1546
1547         Reviewed by Ryosuke Niwa.
1548
1549         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1550         (_follow_duplicate_chain):
1551         (_update_bug_for_flaky_test):
1552
1553 2013-06-19  Brent Fulgham  <bfulgham@apple.com>
1554
1555         [Windows] AX: Expand notification support.
1556         https://bugs.webkit.org/show_bug.cgi?id=117761
1557
1558         Reviewed by Anders Carlsson.
1559
1560         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1561         (AccessibilityUIElement::isPressActionSupported): Provide implementation.
1562         (AccessibilityUIElement::press): Provide implementation.
1563
1564 2013-06-19  Benjamin Poulain  <bpoulain@apple.com>
1565
1566         Use the PlatformEvent timestamp when creating a DOM Event
1567         https://bugs.webkit.org/show_bug.cgi?id=117179
1568
1569         Reviewed by Darin Adler.
1570
1571         * WebKitTestRunner/mac/EventSenderProxy.mm:
1572         (WTR::EventSenderProxy::mouseDown):
1573         (WTR::EventSenderProxy::mouseUp):
1574         (WTR::EventSenderProxy::mouseMoveTo):
1575         (WTR::EventSenderProxy::keyDown):
1576
1577 2013-06-18  Alex Christensen  <achristensen@apple.com>
1578
1579         Working on coverage script, added xml to json data extraction script.
1580         https://bugs.webkit.org/show_bug.cgi?id=117648
1581
1582         This is part of a new test code coverage analysis tool.  This compiles WebKit to generate
1583         coverage data, runs the tests, and collects all of the data in json format.
1584
1585         Reviewed by Stephanie Lewis.
1586
1587         * Scripts/generate-coverage-data:
1588         (parseGcovrOutput):
1589         (getFileHitsAndBranches):
1590         (addLineCounts):
1591         (createResultName):
1592         * Scripts/webkitpy/tool/gcovr: Added.
1593
1594 2013-06-18  Ryuan Choi  <ryuan.choi@samsung.com>
1595
1596         Unreviewed build fix after r151699.
1597
1598         * TestWebKitAPI/CMakeLists.txt:
1599         * WebKitTestRunner/CMakeLists.txt:
1600         Added include dir for InjectedBundleHitTestResultMediaType.h and WKBundleHitTestResult.h
1601
1602 2013-06-18  Roger Fong  <roger_fong@apple.com>
1603
1604         Replace tools32 folder with tools and update WebKit Windows solution accordingly.
1605         <rdar://problem/14118143>.
1606
1607         Rubberstamped by Brent Fulgham.
1608
1609         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
1610         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebug.props:
1611         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props:
1612         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
1613         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherDebug.props:
1614         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherProduction.props:
1615         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherRelease.props:
1616         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeProduction.props:
1617         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeRelease.props:
1618         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props:
1619         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
1620         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebug.props:
1621         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebugWinCairo.props:
1622         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
1623         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherDebug.props:
1624         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherProduction.props:
1625         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherRelease.props:
1626         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffProduction.props:
1627         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffRelease.props:
1628         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffReleaseWinCairo.props:
1629         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
1630         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginDebug.props:
1631         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginProduction.props:
1632         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginRelease.props:
1633         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1634         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebug.props:
1635         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props:
1636         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIProduction.props:
1637         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIRelease.props:
1638         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props:
1639         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
1640         * WinLauncher/WinLauncher.vcxproj/WinLauncherDebug.props:
1641         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
1642         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibDebug.props:
1643         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibProduction.props:
1644         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibRelease.props:
1645         * WinLauncher/WinLauncher.vcxproj/WinLauncherProduction.props:
1646         * WinLauncher/WinLauncher.vcxproj/WinLauncherRelease.props:
1647         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj:
1648         * win/record-memory/record-memory.vcxproj:
1649         * win/record-memory/record-memoryDebug.props:
1650         * win/record-memory/record-memoryDebugWinCairo.props:
1651         * win/record-memory/record-memoryProduction.props:
1652         * win/record-memory/record-memoryRelease.props:
1653         * win/record-memory/record-memoryReleaseWinCairo.props:
1654
1655 2013-06-17  Kangil Han  <kangil.han@samsung.com>
1656
1657         Unreviewed. Add my email to a DOM watchlist.
1658
1659         * Scripts/webkitpy/common/config/watchlist:
1660
1661 2013-06-17  Zan Dobersek  <zdobersek@igalia.com>
1662
1663         Unreviewed GTK gardening.
1664
1665         * Scripts/run-gtk-tests:
1666         (TestRunner): Skip three WebKit2APITests suites that are currently timing out.
1667
1668 2013-06-15  Bruno de Oliveira Abinader  <brunoabinader@gmail.com>
1669
1670         Unreviewed. Reorder my email addresses.
1671         https://bugs.webkit.org/show_bug.cgi?id=100122
1672
1673         * Scripts/webkitpy/common/config/contributors.json:
1674
1675 2013-06-14  Enrica Casucci  <enrica@apple.com>
1676
1677         WKPageFindStringMatches ignores the kWKFindOptionsBackwards option.
1678         https://bugs.webkit.org/show_bug.cgi?id=117647
1679         <rdar://problem/13881024>
1680
1681         Reviewed by Darin Adler.
1682         
1683         The test now uses content with a selection and tests both
1684         forwards and backward find as well as the case of a find
1685         that has no matches after the user selection.
1686
1687         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1688         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
1689         (TestWebKitAPI::didFindStringMatches):
1690         * TestWebKitAPI/Tests/WebKit2/findRanges.html: Added.
1691
1692 2013-06-14  Tor Arne Vestbø  <tor.arne.vestbo@digia.com>
1693
1694         Remove myself from Qt build system watchlist
1695
1696         Reviewed by Simon Hausmann.
1697
1698         * Scripts/webkitpy/common/config/watchlist:
1699
1700 2013-06-13  Michael Brüning  <michael.bruning@digia.com>
1701
1702         [Qt][Mac] Disable QTKit video on OS X.
1703         https://bugs.webkit.org/show_bug.cgi?id=117591
1704
1705         Reviewed by Tor Arne Vestbø.
1706
1707         Deployment of Qt binaries to different Mac OS X
1708         platform version makes it impossible to link against
1709         the correct version of the WebKitSystemInterface library,
1710         so we need to disable QTKit for media elements.
1711
1712         * qmake/mkspecs/features/features.prf:
1713
1714 2013-06-13  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
1715
1716         [EFL][WK2] Wrong context menu and popup menu positions when scroll is applied
1717         https://bugs.webkit.org/show_bug.cgi?id=116610
1718
1719         Reviewed by Noam Rosenthal.
1720
1721         Remove unnecessary code adjusting context menu position to webview position.
1722         Now position is calculcated in EwkView.
1723
1724         * MiniBrowser/efl/main.c:
1725         (on_context_menu_show):
1726
1727 2013-06-12  Roger Fong  <roger_fong@apple.com>
1728
1729         Unreviewed. Turn on WinEWS test now that AppleWin port uses new-run-webkit-tests.
1730
1731         * Scripts/webkitpy/common/config/ews.json:
1732
1733 2013-06-12  Eduardo Lima Mitev  <elima@igalia.com>
1734
1735         [atk] Replace deprecated call to atk_document_get_locale() in DumpRenderTree
1736         https://bugs.webkit.org/show_bug.cgi?id=115647
1737
1738         Reviewed by Martin Robinson.
1739
1740         Locale resolution is moved to WebKitAccessibleWrapperAtk using
1741         AtkObject::get_object_locale() API. Now, implementation of
1742         AccessibilityUIElement::language() in both DumpRenderTree and WebKitTestRunner can
1743         be leveraged to get_object_locale() of AtkObject.
1744
1745         Apart from improving encapsulation, this avoids calling deprecated get_document_locale()
1746         method.
1747
1748         No new functionality, no new tests.
1749
1750         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1751         (AccessibilityUIElement::language): Leverage locale resolution to
1752         AtkObject::get_object_locale().
1753         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1754         (WTR::AccessibilityUIElement::language): Leverage locale resolution to
1755         AtkObject::get_object_locale().
1756
1757 2013-06-12  Hugo Parente Lima  <hugo.lima@openbossa.org>
1758
1759         Remove last bits of GYP from build-webkit and update-webkit scripts
1760         https://bugs.webkit.org/show_bug.cgi?id=117557
1761
1762         Reviewed by Ryosuke Niwa.
1763
1764         * Scripts/build-webkit:
1765         * Scripts/update-webkit:
1766
1767 2013-06-12  Hugo Parente Lima  <hugo.lima@openbossa.org>
1768
1769         Remove forgotten unused Tools/Script/make-gypi script
1770         https://bugs.webkit.org/show_bug.cgi?id=117558
1771
1772         Reviewed by Ryosuke Niwa.
1773
1774         This script isn't used since the GYP removal from WebKit.
1775
1776         * Scripts/make-gypi: Removed.
1777
1778 2013-06-12  Andres Gomez  <agomez@igalia.com>
1779
1780         [GTK] MiniBrowser to automatically download "non-showable" documents when left click in link
1781         https://bugs.webkit.org/show_bug.cgi?id=117533
1782
1783         Reviewed by Carlos Garcia Campos.
1784
1785         MiniBrowser now starts automatically the download of the documents
1786         that cannot be shown just by WebKit itself on link left clicking.
1787
1788         * MiniBrowser/gtk/BrowserWindow.c:
1789         (webViewDecidePolicy): handled the
1790         WEBKIT_POLICY_DECISION_TYPE_RESPONSE decision type too.
1791
1792 2013-06-12  Zan Dobersek  <zdobersek@igalia.com>
1793
1794         [GTK] Remove the WebCoreLayer(Gtk2).a archives before regenerating them
1795         https://bugs.webkit.org/show_bug.cgi?id=116723
1796
1797         Reviewed by Carlos Garcia Campos.
1798
1799         * TestWebKitAPI/GNUmakefile.am: When generating the WebCoreLayer.a archive from all the dependency archives,
1800         remove the current archive (if any). Updating an existent archive in an incremental build is not bulletproof
1801         and can lead to corrupt archives and subsequent build failures. On the other hand, the archive generation is
1802         not expensive and produces a working archive without problems even on incremental builds.
1803
1804 2013-06-11  Santosh Mahto  <santosh.ma@samsung.com>
1805
1806         [EFL] Window resize should close the popupmenu
1807         https://bugs.webkit.org/show_bug.cgi?id=117391
1808
1809         Reviewed by Christophe Dumez.
1810         
1811         Added the code to close the popup when main window is resized.
1812
1813         * MiniBrowser/efl/main.c:
1814         (on_window_resize):
1815
1816 2013-06-11  Alex Christensen  <achristensen@apple.com>
1817
1818         Removed old broken code coverage tool.
1819         https://bugs.webkit.org/show_bug.cgi?id=117520
1820
1821         Reviewed by Sam Weinig.
1822
1823         * CodeCoverage: Removed.
1824         * CodeCoverage/README: Removed.
1825         * CodeCoverage/amber.png: Removed.
1826         * CodeCoverage/cov.py: Removed.
1827         * CodeCoverage/emerald.png: Removed.
1828         * CodeCoverage/gcov.css: Removed.
1829         * CodeCoverage/glass.png: Removed.
1830         * CodeCoverage/regenerate-coverage-display: Removed.
1831         * CodeCoverage/ruby.png: Removed.
1832         * CodeCoverage/run-generate-coverage-data: Removed.
1833         * CodeCoverage/snow.png: Removed.
1834
1835 2013-06-11  Timothy Hatcher  <timothy@apple.com>
1836
1837         Have build-webkit build the WebInspectorUI project.
1838
1839         * Scripts/build-webkit:
1840
1841 2013-06-11  Ryosuke Niwa  <rniwa@webkit.org>
1842
1843         Add an option to run-webkit-tests to skip java dependency check
1844         https://bugs.webkit.org/show_bug.cgi?id=117516
1845
1846         Reviewed by Andreas Kling.
1847
1848         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1849         (parse_args):
1850         * Scripts/webkitpy/port/mac.py:
1851         (MacPort._check_port_build):
1852
1853 2013-06-11  Alex Christensen  <achristensen@apple.com>
1854
1855         https://bugs.webkit.org/show_bug.cgi?id=117514
1856         Removed extra Xcode code coverage flags.
1857
1858         Reviewed by Sam Weinig.
1859
1860         * Scripts/webkitdirs.pm:
1861         (XcodeCoverageSupportOptions):
1862
1863 2013-06-11  Brent Fulgham  <bfulgham@apple.com>
1864
1865         [Windows] Implement 'attributeValue' accessor to support testing
1866         https://bugs.webkit.org/show_bug.cgi?id=117513
1867
1868         Reviewed by Anders Carlsson.
1869
1870         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
1871         (comparableObject): Move earlier in file.
1872         (findAccessibleObjectById): New implemenation.
1873         (AccessibilityController::accessibleElementById): New implementation.
1874
1875 2013-06-11  Csaba Osztrogonác  <ossy@webkit.org>
1876
1877         Make WTR use its own temporary directory for application cache
1878         https://bugs.webkit.org/show_bug.cgi?id=117143
1879
1880         Reviewed by Alexey Proskuryakov.
1881
1882         * WebKitTestRunner/TestController.cpp:
1883         (WTR::TestController::initialize):
1884
1885 2013-06-10  Alexey Proskuryakov  <ap@apple.com>
1886
1887         https://bugs.webkit.org/show_bug.cgi?id=117449
1888         Remove dead code for storing fonts in __DATA section
1889
1890         Reviewed by Dan Bernstein.
1891
1892         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
1893         Don't copy font resources to __DATA, as we don't have any code that reads them
1894         from there (previously removed due to being under "defined(BUILDING_ON_LEOPARD)").
1895
1896         * DumpRenderTree/mac/DumpRenderTree.mm: (activateTestingFonts):
1897         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm: (WTR::activateFonts):
1898         Removed comments suggesting that we want to restore the old solution.
1899
1900 2013-06-10  Bear Travis  <betravis@adobe.com>
1901
1902         [CSS Shapes][CSS Exclusions] Split CSS Exclusions and CSS Shapes code
1903         https://bugs.webkit.org/show_bug.cgi?id=117162
1904
1905         Reviewed by Alexandru Chiculita.
1906
1907         Adding the WebCore/rendering/shapes directory to the include list.
1908
1909         * DumpRenderTree/efl/CMakeLists.txt:
1910
1911 2013-06-09  Brent Fulgham  <bfulgham@apple.com>
1912
1913         [Windows] Unreviewed test correction:  Prevent DumpRenderTree crashes
1914         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1915         (AccessibilityUIElement::role): Prevent crashes when m_element is null. This
1916         happends in some of the 'accessibility' test cases.
1917
1918 2013-06-08  peavo@outlook.com  <peavo@outlook.com>
1919
1920         [WinCairo] TestWebKitAPI fails to link.
1921         https://bugs.webkit.org/show_bug.cgi?id=117345
1922
1923         Reviewed by Brent Fulgham.
1924
1925         Need to link with WTF.lib.
1926
1927         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props: Link with WTF.lib.
1928
1929 2013-06-07  Roger Fong  <roger_fong@apple.com>
1930
1931         Get rid of not very helpful test that fails only on some machines because xcrun is not installed.
1932
1933         Rubberstamped by Ryousuke Niwa.
1934
1935         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1936         (RunTest.test_build_check):
1937
1938 2013-06-07  Hugo Parente Lima  <hugo.lima@openbossa.org>
1939
1940         [Qt] Remove Qt bits from Scripts/webkitperl/FeatureList.pm
1941         https://bugs.webkit.org/show_bug.cgi?id=117315
1942
1943         Reviewed by Benjamin Poulain.
1944
1945         Qt doesn't use the default values specified on FeatureList since r44681,
1946         this patch just remove a bit of noise.
1947
1948         * Scripts/webkitperl/FeatureList.pm:
1949
1950 2013-06-07  Jungsik Tae  <davidtlay88@gmail.com>
1951
1952         [EFL] Implement colorpicker for HTML5 input type color on Minibrowser
1953         https://bugs.webkit.org/show_bug.cgi?id=115890
1954
1955         Reviewed by Christophe Dumez.
1956
1957         When user clicks HTML5 input type color,
1958         color selector window is created on browser object by using elm_colorchooser_add().
1959         It can listen a signal dismissing colorpicker by calling the ewk_color_picker_color_set().
1960         The evas_object_color_set() sets a color value returning to browser.
1961
1962         * MiniBrowser/efl/main.c:
1963         (window_free): When we delete parent window, deleting the colorpicker object.
1964         (on_color_changed): Change color of rectangle to show color selected by user.
1965         (on_color_item_selected): Change color of rectangle when clicked color palettes offered by elm_color_chooser().
1966         (on_color_picker_ok_clicked): Call on_colorpicker_dismiss() and set the color.
1967         (on_color_picker_cancel_clicked): Get a preexisting color and call ewk_color_picker_color_set().
1968         (on_color_picker_dismiss): Delete colorpicker object.
1969         (on_color_picker_request): Create colorpicker window object.
1970         (window_create):
1971
1972 2013-06-06  Yuki Sekiguchi  <yuki.sekiguchi@access-company.com>
1973
1974         svn-apply cannot apply patches which is generated by git to files that contain space characters in their path
1975         https://bugs.webkit.org/show_bug.cgi?id=111066
1976
1977         Reviewed by Daniel Bates.
1978
1979         Fixes an issue where parseGitDiffHeader() would extract the wrong substring of the diff --git line as the target file path when the source file path contains a space character.
1980
1981         ParseGitDiffHeader() should support the path which line has space characters.
1982         To support this, I changed parsing algorithm like the following:
1983         - When the diff have prefix, we consider next characters after "b/" as part of a file path.
1984         - When the diff have no prefix, we assume that both path have same directory prefix, and we split the diff line using the prefix.
1985
1986         We only support --src-prefix and --dst-prefix don't contain a non-word character (\W) and end with '/' because we cannot distinguish the prefix from directory path.
1987
1988         If the path has a tab, the patch(1) command thinks file path is characters before the tab.
1989         I added a dummy tab and revision when we convert git diff to svn diff.
1990
1991         * Scripts/VCSUtils.pm:
1992         (parseGitDiffHeader):
1993         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl: Update expectations for dummy revision.
1994         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl: Ditto.
1995         * Scripts/webkitperl/VCSUtils_unittest/parseGitDiffHeader.pl: Ditto.
1996           - Added test case for files which have space in their path and --src-prefix and --dst-prefix option.
1997
1998 2013-06-06  Simon Fraser  <simon.fraser@apple.com>
1999
2000         Add a menu item to MiniBrowser to toggle Transparent windows
2001         https://bugs.webkit.org/show_bug.cgi?id=117316
2002
2003         Reviewed by Anders Carlsson.
2004         
2005         Add a menu item that toggles "Transparent window" mode, which is exposed
2006         via private WebKit API and WebKit2 API.
2007
2008         * MiniBrowser/mac/BrowserWindowController.h:
2009         * MiniBrowser/mac/MainMenu.xib:
2010         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
2011         * MiniBrowser/mac/WK1BrowserWindowController.m:
2012         (-[WK1BrowserWindowController validateMenuItem:]):
2013         (-[WK1BrowserWindowController toggleTransparentWindow:]):
2014         * MiniBrowser/mac/WK2BrowserWindowController.m:
2015         (-[WK2BrowserWindowController validateMenuItem:]):
2016         (-[WK2BrowserWindowController toggleTransparentWindow:]):
2017         (-[WK2BrowserWindowController dumpSourceToConsole:]): Fix a crash that was seen
2018         when testing.
2019
2020 2013-06-06  Roger Fong  <roger_fong@apple.com>
2021
2022         Stop copying AAS binaries into build folder.
2023         https://bugs.webkit.org/show_bug.cgi?id=117319.
2024
2025         Rubberstamped by Darin Adler.
2026
2027         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePostBuild.cmd:
2028
2029 2013-06-06  Hugo Parente Lima  <hugo.lima@openbossa.org>
2030
2031         Aligning build-webkit command line switch names to the WebKit flag names
2032         https://bugs.webkit.org/show_bug.cgi?id=117254
2033
2034         Reviewed by Laszlo Gombos.
2035
2036         * Scripts/webkitperl/FeatureList.pm: Rename some command line switches.
2037
2038 2013-06-06  Chris Fleizach  <cfleizach@apple.com>
2039
2040         AX: iOS ignores ARIA progressbar elements
2041         https://bugs.webkit.org/show_bug.cgi?id=116727
2042
2043         Reviewed by David Kilzer.
2044
2045         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2046         (AccessibilityUIElement::minValue):
2047         (AccessibilityUIElement::maxValue):
2048
2049 2013-06-06  peavo@outlook.com  <peavo@outlook.com>
2050
2051         [WinCairo] Fix build-webkit to build WinCairo under VS2010.
2052         https://bugs.webkit.org/show_bug.cgi?id=117255
2053
2054         Reviewed by Daniel Bates.
2055
2056         Need to update configuration names according to solution file.
2057
2058         * Scripts/webkitdirs.pm:
2059         (determineConfiguration):
2060         (determinePassedConfiguration):
2061
2062 2013-06-06  Ryosuke Niwa  <rniwa@webkit.org>
2063
2064         Remove run-performance-tests
2065         https://bugs.webkit.org/show_bug.cgi?id=117285
2066
2067         Reviewed by Andreas Kling.
2068         
2069         Remove the script since it's not used anywhere.
2070
2071         * BuildSlaveSupport/run-performance-tests: Removed.
2072
2073 2013-06-05  Bear Travis  <betravis@adobe.com>
2074
2075         [CSS Exclusions][CSS Shapes] Split CSS Exclusions & Shapes compile & runtime flags
2076         https://bugs.webkit.org/show_bug.cgi?id=117172
2077
2078         Reviewed by Alexandru Chiculita.
2079
2080         Adding the CSS_SHAPES compile flag.
2081
2082         * Scripts/webkitperl/FeatureList.pm:
2083         * qmake/mkspecs/features/features.pri:
2084
2085 2013-06-05  Brent Fulgham  <bfulgham@apple.com>
2086
2087         [Windows] Unreviewed build fix. Add CRLF eol-style for DOS shell scripts; if they accidentally change
2088         to UNIX-style they will not execute properly.
2089
2090         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePostBuild.cmd: Added property svn:eol-style.
2091         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePreBuild.cmd: Added property svn:eol-style.
2092
2093 2013-06-05  Roger Fong  <roger_fong@apple.com>
2094
2095         Unreviewed build fix. Don't pass in --use-remote-links argument on Windows now that we use NRWT.
2096
2097         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2098         (RunWebKitTests.start):
2099
2100 2013-06-05  Brent Fulgham  <bfulgham@apple.com>
2101
2102         [Windows] Switch to NRWT
2103         https://bugs.webkit.org/show_bug.cgi?id=117200
2104
2105         Reviewed by Anders Carlsson.
2106
2107         * Scripts/run-webkit-tests:
2108         (useNewRunWebKitTests): No longer use old-run-webkit-tests for Windows port.
2109
2110 2013-06-05  Dominik Röttsches  <dominik.rottsches@intel.com>
2111
2112         Unreviewed name fix after r150662
2113
2114         My firstname got duplicated when fixing bug 116737.
2115
2116         * Scripts/webkitpy/common/config/contributors.json:
2117
2118 2013-06-05  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2119
2120         Use WEBKITOUTPUTDIR if WEBKIT_OUTPUTDIR is not present.
2121         https://bugs.webkit.org/show_bug.cgi?id=117244
2122
2123         Reviewed by Daniel Bates.
2124
2125         Fixed a regression introduced by r151196: not only does webkit.org
2126         still mention WEBKITOUTPUTDIR instead of WEBKIT_OUTPUTDIR, but the
2127         infrastructure used by ports such as GTK+ and EFL also use on it for
2128         things such as jhbuild.
2129
2130         While everything is not fully transitioned to WEBKIT_OUTPUTDIR, read
2131         both environment variables.
2132
2133         * Scripts/webkitdirs.pm:
2134         (determineBaseProductDir):
2135
2136 2013-06-05  Wojciech Bielawski  <w.bielawski@samsung.com>
2137
2138         [GTK] Forwarding headers not generated for incremental build
2139         https://bugs.webkit.org/show_bug.cgi?id=117198
2140
2141         Reviewed by Carlos Garcia Campos.
2142
2143         * WebKitTestRunner/GNUmakefile.am: libTestRunnerInjectedBundle added to dependencies.
2144
2145 2013-06-05  Andras Becsi  <andras.becsi@digia.com>
2146
2147         [Qt][WK2] Fix layout testing with Qt 5.1
2148         https://bugs.webkit.org/show_bug.cgi?id=117203
2149
2150         Reviewed by Jocelyn Turcotte.
2151
2152         With Qt 5.1 synchronous requests via QNetworkAccessManager do not
2153         go into loading state but directly call handler functions for
2154         finished state instead of relying on a connection.
2155         Our wrapper QQuickView uses a data URI scheme to create the root
2156         item for testing which results in a synchronous request when loading
2157         the QML data, therefore the state of the QQuickWindow immediately
2158         becomes Ready.
2159         Since the final initialization of the root item depended on the
2160         emission of QQuickView::statusChanged(QQuickView::Ready) we ended
2161         up with a partially initialized wrapper window, thus most of our
2162         layout tests were failing.
2163         For compatibility with pre-5.1 Qt versions keep the old behaviour
2164         in case the WrapperWindow is not ready in the constructor yet.
2165
2166         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2167         (WTR::WrapperWindow::WrapperWindow):
2168         * TestWebKitAPI/qt/PlatformWebViewQt.cpp:
2169         (TestWebKitAPI::WrapperWindow::WrapperWindow):
2170
2171 2013-06-05  Dariusz Frankiewicz  <d.frankiewic@samsung.com>
2172
2173         Bad value in tests counter at new-run-webkit-tests
2174         in --debug-rwt-logging mode
2175         https://bugs.webkit.org/show_bug.cgi?id=116858
2176
2177         Reviewed by Dirk Pranke.
2178
2179         Fix by moving counter incrementation, from after printing line,
2180         to before printing. Also changed variable name.
2181
2182         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
2183         (LayoutTestRunner.run_tests):
2184         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
2185         (FakePrinter):
2186         * Scripts/webkitpy/layout_tests/views/printing.py:
2187         (Printer.__init__):
2188         (Printer._test_status_line):
2189         (Printer.print_started_test):
2190         (Printer.print_finished_test):
2191         * Scripts/webkitpy/test/printer.py:
2192         (Printer.__init__):
2193         (Printer.print_finished_test):
2194         (Printer._test_line):
2195         (Printer.print_result):
2196
2197 2013-06-05  Zan Dobersek  <zdobersek@igalia.com>
2198
2199         Move MemoryInfo under window.internals
2200         https://bugs.webkit.org/show_bug.cgi?id=117197
2201
2202         Reviewed by Ryosuke Niwa.
2203
2204         * GNUmakefile.am: Add the testing/MemoryInfo.(h|idl) files and the generated targets to
2205         the Automake build
2206         * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl: List the
2207         testing/MemoryInfo.idl file instead of page/MemoryInfo.idl.
2208
2209 2013-06-03  Roger Fong  <roger_fong@apple.com>
2210
2211         Remove uses of VS2005 scripts, executables and associated environment variables from scripts.
2212         <rdar://problem/14042021>.
2213
2214         Reviewed by Brent Fulgham.
2215
2216         * Scripts/build-api-tests:
2217         * Scripts/build-dumprendertree:
2218         * Scripts/build-webkit:
2219         * Scripts/update-webkit-dependency:
2220         * Scripts/update-webkit-support-libs:
2221         * Scripts/webkitdirs.pm:
2222         (determineBaseProductDir):
2223         (setupAppleWinEnv):
2224         (setupCygwinEnv):
2225
2226 2013-06-04  Brent Fulgham  <bfulgham@apple.com>
2227
2228         [Windows] NRWT is not putting crash logs in proper place (corrections)
2229         https://bugs.webkit.org/show_bug.cgi?id=117212
2230
2231         Reviewed by Dirk Pranke.
2232
2233         * Scripts/webkitpy/common/system/crashlogs.py:
2234         (CrashLogs.__init__): Accept a result directory argument in constructor.
2235         (CrashLogs.find_newest_log): Don't require 'port' argument anymore.
2236         (CrashLogs._find_newest_log_win): No longer use 'port' argument.
2237         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
2238         (CrashLogsTest.test_find_log_win): Simplify test.
2239         * Scripts/webkitpy/common/system/executive.py:
2240         (Executive.running_pids): Handle "win32" case separately from "cygwin" case.
2241         * Scripts/webkitpy/port/win.py:
2242         (WinPort._get_crash_log): No longer require 'port' argument.
2243
2244 2013-06-04  Ryosuke Niwa  <rniwa@webkit.org>
2245
2246         Build fix after r150592. We need to disable \2 shouldn't be treated as an escape character.
2247
2248         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2249
2250 2013-06-04  Greg Hughes  <ghughes@apple.com>
2251
2252         Add "VisibleOnly" key to search predicate
2253         https://bugs.webkit.org/show_bug.cgi?id=115491
2254
2255         Reviewed by Chris Fleizach.
2256
2257         Added support for accessibility clients to use the search predicate to find only visible elements
2258
2259         * DumpRenderTree/AccessibilityUIElement.cpp:
2260         (uiElementForSearchPredicateCallback):
2261         * DumpRenderTree/AccessibilityUIElement.h:
2262         (AccessibilityUIElement):
2263         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2264         (AccessibilityUIElement::uiElementForSearchPredicate):
2265         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2266         (AccessibilityUIElement::uiElementForSearchPredicate):
2267         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2268         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
2269         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2270         (AccessibilityUIElement):
2271         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2272         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2273         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
2274
2275 2013-06-04  Brent Fulgham  <bfulgham@apple.com>
2276
2277         [Windows] Unreviewed build fix.  The last check-in lost CR/LF endings on the batch file,
2278         causing build failure.
2279
2280         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePostBuild.cmd: Revert to
2281         DOS-style CR/LF endings.
2282
2283 2013-06-04  Brent Fulgham  <bfulgham@apple.com>
2284
2285         [Windows] Unreviewed test correction.
2286
2287         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePostBuild.cmd: Also copy the
2288         QuartzCore dll's, which are needed by TestWebKitAPI.
2289         * TestWebKitAPI/win/main.cpp: Declare proper manfifest dependencies to ensure TestWebKitAPI built
2290         with VS2010 will run when linked against VS2005 support libraries.
2291
2292 2013-06-04  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2293
2294         Automatically generate WorkerContext constructor attributes
2295         https://bugs.webkit.org/show_bug.cgi?id=117183
2296
2297         Reviewed by Kentaro Hara.
2298
2299         Pass new --workerContextConstructorsFile to preprocess-idl.pl for bindings
2300         tests.
2301
2302         * Scripts/webkitpy/bindings/main.py:
2303         (BindingsTests.generate_supplemental_dependency):
2304         (BindingsTests.main):
2305
2306 2013-06-04  Ryuan Choi  <ryuan.choi@samsung.com>
2307
2308         [EFL] File dialog of MiniBrowser have broken background.
2309         https://bugs.webkit.org/show_bug.cgi?id=117189
2310
2311         Reviewed by Christophe Dumez.
2312
2313         * MiniBrowser/efl/main.c:
2314         (on_file_chooser_request): Added elm_bg for elm_win of file chooser.
2315
2316 2013-06-04  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2317
2318         [WKTR][WTK] Undefined symbols in libTestRunnerInjectedBundle.so after r151124
2319         https://bugs.webkit.org/show_bug.cgi?id=117184
2320
2321         Reviewed by Gyuyoung Kim.
2322
2323         Add ATK stubs for mathPostscriptsDescription() and mathPrescriptsDescription() so
2324         that we don't have undefined symbols in libTestRunnerInjectedBundle.so.
2325
2326         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2327         (WTR::AccessibilityUIElement::mathPostscriptsDescription):
2328         (WTR::AccessibilityUIElement::mathPrescriptsDescription):
2329
2330 2013-06-03  Simon Pena  <simon.pena@samsung.com>
2331
2332         validate-committer-lists script is now outdated and does not work
2333         https://bugs.webkit.org/show_bug.cgi?id=115860
2334
2335         Reviewed by Brent Fulgham.
2336
2337         The script validate-committer-lists was outdated, still using the deprecated log
2338         system and having the old addresses for the mailing lists, as well as still referring
2339         to committers.py, after this was renamed to contributors.json. This patch fixes that
2340         so it can be used again.
2341
2342         * Scripts/validate-committer-lists: Replace calls to log and error with the
2343         new logging mechanism, fix the URLs for the mailing lists, and fix the mentions
2344         to committers.py, which should be contributors.json.
2345         (CommitterListFromMailingList):
2346         (CommitterListFromMailingList.check_for_emails_missing_from_list):
2347         (CommitterListFromGit._fetch_authors_and_last_commit_time_from_git_log):
2348         (CommitterListFromGit._fill_in_emails_for_old_logins):
2349         (CommitterListFromGit.print_committers_missing_from_committer_list):
2350
2351 2013-06-03  Dirk Pranke  <dpranke@chromium.org>
2352
2353         add a script to dump the tests run most recently by a given worker
2354         https://bugs.webkit.org/show_bug.cgi?id=116571
2355
2356         Reviewed by Brent Fulgham.
2357
2358         The tests_run*.txt results files in layout-test-results/ were removed
2359         in r137356, in favor of collecting more data about how the tests were
2360         run and compressing it and storing it in stats.json. However, it was
2361         nice to just be able to look at a flat text file.
2362
2363         This script will extract the tests run by a given worker from a
2364         given stats.json file, and should help to address that.
2365
2366         * Scripts/dump-webkit-tests-run: Added.
2367         (main):
2368         (convert_trie_to_flat_paths):
2369
2370 2013-06-03  Brent Fulgham  <bfulgham@apple.com>
2371
2372         [Windows] NRWT is not putting crash logs in proper place
2373         https://bugs.webkit.org/show_bug.cgi?id=117098
2374
2375         Reviewed by Ryosuke Niwa.
2376
2377         Provide windows-specific overloads for various Port features needed to create and capture
2378         crash logs.  This change makes it possible to view crash logs (when created) as part of the
2379         summary report at the end of the NRWT run.
2380
2381         * Scripts/webkitpy/common/system/crashlogs.py:
2382         (CrashLogs.find_newest_log): Add support for win32 crash logs
2383         (CrashLogs._find_newest_log_win): Added
2384         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
2385         (make_mock_crash_report_win): Added
2386         (CrashLogsTest.test_find_log_win): Added.
2387         * Scripts/webkitpy/common/system/executive.py:
2388         (Executive.running_pids): Add support for Cygwin win32 crash logs
2389         * Scripts/webkitpy/common/system/executive_mock.py:
2390         (MockExecutive.__init__):
2391         * Scripts/webkitpy/common/system/filesystem_unittest.py:
2392         (RealFileSystemTest.test_read_and_write_file): Add tests for
2393         malformed ascii/utf8 handling (i.e., Windows log files)
2394         * Scripts/webkitpy/port/base.py:
2395         (Port.find_system_pid): Added
2396         * Scripts/webkitpy/port/server_process.py:
2397         (ServerProcess._start): Gather windows PIDs to match up with Cygwin PIDs
2398         * Scripts/webkitpy/port/win.py:
2399         (WinPort.setup_crash_log_saving): Don't open windows shell (which might get stuck waiting
2400         for user to hit enter.
2401         (WinPort._get_crash_log): Added
2402         (WinPort.look_for_new_crash_logs): Added
2403         (WinPort.find_system_pid): Added
2404         * Scripts/webkitpy/port/win_unittest.py:
2405         (WinPortTest.test_get_crash_log): Added test
2406
2407 2013-06-03  Eduardo Lima Mitev  <elima@igalia.com>
2408
2409         [EFL] Add ATK version 2.8.0 to efl jhbuild moduleset
2410         https://bugs.webkit.org/show_bug.cgi?id=116726
2411
2412         Reviewed by Gyuyoung Kim.
2413
2414         Current version of ATK in efl-ews environment is 2.4.0 and is taken from
2415         the platform (it is not listed in jhbuild moduleset). That version is
2416         old-ish and contain deprecated symbols and missing API, that are blocking
2417         patches in other ports (gtk). This patch adds ATK version 2.8.0 to efl
2418         moduleset, which is the same version the gtk port uses.
2419
2420         See bug https://bugs.webkit.org/show_bug.cgi?id=115647 for more details on
2421         why this is needed.
2422
2423         * efl/jhbuild.modules: Adds ATK module as dependency
2424
2425 2013-06-03  Erik van Pienbroek  <epienbro@fedoraproject.org>
2426
2427         [GTK] Respect PKG_CONFIG env variable when generating gtk-doc
2428         https://bugs.webkit.org/show_bug.cgi?id=117168
2429
2430         Reviewed by Martin Robinson.
2431
2432         The tool generate-gtkdoc internally calls pkg-config.
2433         When cross-compiling it shouldn't use pkg-config, but
2434         it should use the pkg-config which was detected by
2435         the ./configure script (for example this can be
2436         i686-w64-mingw32-pkg-config when cross-compiling)
2437
2438         * GNUmakefile.am:
2439         * gtk/gtkdoc.py:
2440         (PkgConfigGTKDoc.__init__):
2441
2442 2013-06-03  Brent Fulgham  <bfulgham@apple.com>
2443
2444         [Windows] Unreviewed build fix.
2445
2446         * TestWebKitAPI/win/main.cpp: Embed proper manifest information to
2447         allow VS2010 builds to use VS2005 runtime libraries as needed.
2448
2449 2013-06-03  Roger Fong  <roger_fong@apple.com>
2450
2451         Nuke VS2005 files from the tree.
2452         <rdar://problem/14042021>.
2453
2454         Rubberstamped by Brent Fulgham.
2455
2456         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.def: Removed.
2457         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Removed.
2458         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Removed.
2459         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops: Removed.
2460         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebug.vsprops: Removed.
2461         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugAll.vsprops: Removed.
2462         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugCairoCFLite.vsprops: Removed.
2463         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd: Removed.
2464         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd: Removed.
2465         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops: Removed.
2466         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginRelease.vsprops: Removed.
2467         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseCairoCFLite.vsprops: Removed.
2468         * DumpRenderTree/TestNetscapePlugIn/win/resource.h: Removed.
2469         * DumpRenderTree/win/DumpRenderTree.vcproj: Removed.
2470         * DumpRenderTree/win/DumpRenderTreeApple.vsprops: Removed.
2471         * DumpRenderTree/win/DumpRenderTreeCFLite.vsprops: Removed.
2472         * DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Removed.
2473         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops: Removed.
2474         * DumpRenderTree/win/DumpRenderTreeDebug.vsprops: Removed.
2475         * DumpRenderTree/win/DumpRenderTreeDebugAll.vsprops: Removed.
2476         * DumpRenderTree/win/DumpRenderTreeDebugCairoCFLite.vsprops: Removed.
2477         * DumpRenderTree/win/DumpRenderTreeLauncher.vcproj: Removed.
2478         * DumpRenderTree/win/DumpRenderTreeLauncherCommon.vsprops: Removed.
2479         * DumpRenderTree/win/DumpRenderTreeLauncherDebug.vsprops: Removed.
2480         * DumpRenderTree/win/DumpRenderTreeLauncherDebugAll.vsprops: Removed.
2481         * DumpRenderTree/win/DumpRenderTreeLauncherDebugCairoCFLite.vsprops: Removed.
2482         * DumpRenderTree/win/DumpRenderTreeLauncherProduction.vsprops: Removed.
2483         * DumpRenderTree/win/DumpRenderTreeLauncherRelease.vsprops: Removed.
2484         * DumpRenderTree/win/DumpRenderTreeLauncherReleaseCairoCFLite.vsprops: Removed.
2485         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd: Removed.
2486         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd: Removed.
2487         * DumpRenderTree/win/DumpRenderTreeProduction.vsprops: Removed.
2488         * DumpRenderTree/win/DumpRenderTreeRelease.vsprops: Removed.
2489         * DumpRenderTree/win/DumpRenderTreeReleaseCairoCFLite.vsprops: Removed.
2490         * DumpRenderTree/win/ImageDiff.vcproj: Removed.
2491         * DumpRenderTree/win/ImageDiffCommon.vsprops: Removed.
2492         * DumpRenderTree/win/ImageDiffDebug.vsprops: Removed.
2493         * DumpRenderTree/win/ImageDiffDebugAll.vsprops: Removed.
2494         * DumpRenderTree/win/ImageDiffDebugCairoCFLite.vsprops: Removed.
2495         * DumpRenderTree/win/ImageDiffLauncher.vcproj: Removed.
2496         * DumpRenderTree/win/ImageDiffLauncherCommon.vsprops: Removed.
2497         * DumpRenderTree/win/ImageDiffLauncherDebug.vsprops: Removed.
2498         * DumpRenderTree/win/ImageDiffLauncherDebugAll.vsprops: Removed.
2499         * DumpRenderTree/win/ImageDiffLauncherDebugCairoCFLite.vsprops: Removed.
2500         * DumpRenderTree/win/ImageDiffLauncherProduction.vsprops: Removed.
2501         * DumpRenderTree/win/ImageDiffLauncherRelease.vsprops: Removed.
2502         * DumpRenderTree/win/ImageDiffLauncherReleaseCairoCFLite.vsprops: Removed.
2503         * DumpRenderTree/win/ImageDiffPostBuild.cmd: Removed.
2504         * DumpRenderTree/win/ImageDiffPreBuild.cmd: Removed.
2505         * DumpRenderTree/win/ImageDiffProduction.vsprops: Removed.
2506         * DumpRenderTree/win/ImageDiffRelease.vsprops: Removed.
2507         * DumpRenderTree/win/ImageDiffReleaseCairoCFLite.vsprops: Removed.
2508         * DumpRenderTree/win/ImageDiffWinCairoCommon.vsprops: Removed.
2509         * Scripts/pdevenv: Removed.
2510         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Removed.
2511         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd: Removed.
2512         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd: Removed.
2513         * WebKitLauncherWin: Removed.
2514         * WebKitLauncherWin/Resource.h: Removed.
2515         * WebKitLauncherWin/WebKitLauncherWin.cpp: Removed.
2516         * WebKitLauncherWin/WebKitLauncherWin.rc: Removed.
2517         * WebKitLauncherWin/WebKitLauncherWin.vcproj: Removed.
2518         * WebKitLauncherWin/WebKitLauncherWinCommon.vsprops: Removed.
2519         * WebKitLauncherWin/WebKitLauncherWinDebug.vsprops: Removed.
2520         * WebKitLauncherWin/WebKitLauncherWinDebugAll.vsprops: Removed.
2521         * WebKitLauncherWin/WebKitLauncherWinDebugCairoCFLite.vsprops: Removed.
2522         * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops: Removed.
2523         * WebKitLauncherWin/WebKitLauncherWinRelease.vsprops: Removed.
2524         * WebKitLauncherWin/WebKitLauncherWinReleaseCairoCFLite.vsprops: Removed.
2525         * WebKitLauncherWin/webkit.ico: Removed.
2526         * WinLauncher/WinLauncher.ico: Removed.
2527         * WinLauncher/WinLauncher.rc: Removed.
2528         * WinLauncher/WinLauncher.vcproj: Removed.
2529         * WinLauncher/WinLauncherCommon.vsprops: Removed.
2530         * WinLauncher/WinLauncherDebug.vsprops: Removed.
2531         * WinLauncher/WinLauncherDebugAll.vsprops: Removed.
2532         * WinLauncher/WinLauncherDebugCairoCFLite.vsprops: Removed.
2533         * WinLauncher/WinLauncherLauncher.rc: Removed.
2534         * WinLauncher/WinLauncherLauncher.vcproj: Removed.
2535         * WinLauncher/WinLauncherLauncherCommon.vsprops: Removed.
2536         * WinLauncher/WinLauncherLauncherDebug.vsprops: Removed.
2537         * WinLauncher/WinLauncherLauncherDebugAll.vsprops: Removed.
2538         * WinLauncher/WinLauncherLauncherDebugCairoCFLite.vsprops: Removed.
2539         * WinLauncher/WinLauncherLauncherProduction.vsprops: Removed.
2540         * WinLauncher/WinLauncherLauncherRelease.vsprops: Removed.
2541         * WinLauncher/WinLauncherLauncherReleaseCairoCFLite.vsprops: Removed.
2542         * WinLauncher/WinLauncherLauncherResource.h: Removed.
2543         * WinLauncher/WinLauncherPostBuild.cmd: Removed.
2544         * WinLauncher/WinLauncherPreBuild.cmd: Removed.
2545         * WinLauncher/WinLauncherProduction.vsprops: Removed.
2546         * WinLauncher/WinLauncherRelease.vsprops: Removed.
2547         * WinLauncher/WinLauncherReleaseCairoCFLite.vsprops: Removed.
2548         * WinLauncher/small.ico: Removed.
2549         * record-memory-win: Removed.
2550         * record-memory-win/main.cpp: Removed.
2551         * record-memory-win/record-memory-win-common.vsprops: Removed.
2552         * record-memory-win/record-memory-win.vcproj: Removed.
2553         * record-memory-win/record-memory-winDebug.vsprops: Removed.
2554         * record-memory-win/record-memory-winDebugAll.vsprops: Removed.
2555         * record-memory-win/record-memory-winDebugCairoCFLite.vsprops: Removed.
2556         * record-memory-win/record-memory-winProduction.vsprops: Removed.
2557         * record-memory-win/record-memory-winRelease.vsprops: Removed.
2558         * record-memory-win/record-memory-winReleaseCairoCFLite.vsprops: Removed.
2559
2560 2013-06-03  Chris Fleizach  <cfleizach@apple.com>
2561
2562         AX: MathML multiscripts not exposed in Accessibility
2563         https://bugs.webkit.org/show_bug.cgi?id=115069
2564
2565         Reviewed by Tim Horton.
2566
2567         Add methods to help output components of math multiscripts for accessibility.
2568
2569         * DumpRenderTree/AccessibilityUIElement.cpp:
2570         (mathPostscriptsDescriptionCallback):
2571         (mathPrescriptsDescriptionCallback):
2572         (AccessibilityUIElement::getJSClass):
2573         * DumpRenderTree/AccessibilityUIElement.h:
2574         (AccessibilityUIElement):
2575         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2576         (convertMathMultiscriptPairsToString):
2577         (AccessibilityUIElement::mathPostscriptsDescription):
2578         (AccessibilityUIElement::mathPrescriptsDescription):
2579         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2580         (WTR::AccessibilityUIElement::mathPostscriptsDescription):
2581         (WTR::AccessibilityUIElement::mathPrescriptsDescription):
2582         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2583         (AccessibilityUIElement):
2584         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2585         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2586         (WTR::_convertMathMultiscriptPairsToString):
2587         (WTR::AccessibilityUIElement::mathPostscriptsDescription):
2588         (WTR::AccessibilityUIElement::mathPrescriptsDescription):
2589
2590 2013-06-03  Commit Queue  <commit-queue@webkit.org>
2591
2592         Unreviewed, rolling out r151109.
2593         http://trac.webkit.org/changeset/151109
2594         https://bugs.webkit.org/show_bug.cgi?id=117145
2595
2596         "Plugins in WK2 aren't implemented yet." (Requested by
2597         jturcotte on #webkit).
2598
2599         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2600         * qmake/mkspecs/features/features.prf:
2601         * qmake/mkspecs/features/unix/default_pre.prf:
2602
2603 2013-05-22  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
2604
2605         [Qt] Re-enable plugins on Mac.
2606         https://bugs.webkit.org/show_bug.cgi?id=116622
2607
2608         Reviewed by Tor Arne Vestbø.
2609
2610         Plugins on Mac were only enabled if !embedded but the later was set if
2611         QPA is enabled, which is the default since Qt 5.0.
2612
2613         Remove references to 'embedded' and fix various build issues,
2614         PluginViewMac.mm and PluginPackageMac.cpp haven't been compiled since a few
2615         months.
2616
2617         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2618         * qmake/mkspecs/features/features.prf:
2619         * qmake/mkspecs/features/unix/default_pre.prf:
2620
2621 2013-06-03  Krzysztof Czech  <k.czech@samsung.com>
2622
2623         [GTK][WK2] accessibility/placeholder.html is failing
2624         https://bugs.webkit.org/show_bug.cgi?id=106344
2625
2626         Reviewed by Gyuyoung Kim.
2627
2628         Adds support for retrieving attribute value.
2629
2630         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2631         (WTR::coreAttributeToAtkAttribute):
2632         (WTR::AccessibilityUIElement::stringAttributeValue):
2633
2634 2013-06-01  Tim Horton  <timothy_horton@apple.com>
2635
2636         Add a preferred email address and "expertise" for me.
2637
2638         * Scripts/webkitpy/common/config/contributors.json:
2639
2640 2013-05-31  Roger Fong  <roger_fong@apple.com>
2641
2642         Unreviewed. Make windows test bots search in the correct directory for build output.
2643
2644         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2645         (RunWebKitTests.start):
2646         * Scripts/webkitdirs.pm:
2647         (determineConfigurationProductDir):
2648
2649 2013-05-31  Roger Fong  <roger_fong@apple.com>
2650
2651         Unreviewed. Windows build fix...
2652
2653         * BuildSlaveSupport/built-product-archive:
2654         (createZip):
2655
2656 2013-05-31  Roger Fong  <roger_fong@apple.com>
2657
2658         Unreviewed. Windows build fix. One more time!
2659
2660         * BuildSlaveSupport/built-product-archive:
2661         (archiveBuiltProduct):
2662         (extractBuiltProduct):
2663
2664 2013-05-31  Roger Fong  <roger_fong@apple.com>
2665
2666         Unreviewed. Windows build fix.
2667
2668         * Scripts/build-webkit:
2669
2670 2013-05-31  Roger Fong  <roger_fong@apple.com>
2671
2672         Unreviewed. Windows build fix.
2673
2674         * Scripts/build-webkit:
2675
2676 2013-05-31  Roger Fong  <roger_fong@apple.com>
2677
2678         Make build-webkit output VCExpress 2010 build logs properly.
2679         https://bugs.webkit.org/show_bug.cgi?id=117096
2680
2681         Reviewed by Brent Fulgham.
2682
2683         Make it so that output from VCExpress is always printed to console.
2684         Get build log results from AssembleBuildLogs project output.
2685         We don't need those old VCExpress scripts anymore either. 
2686
2687         * Scripts/build-webkit:
2688         * Scripts/print-msvc-project-dependencies: Removed.
2689         * Scripts/print-vse-failure-logs: Removed.
2690
2691 2013-05-31  Brent Fulgham  <bfulgham@apple.com>
2692
2693         [Windows] Use WinLauncher to display LayoutTest results
2694         https://bugs.webkit.org/show_bug.cgi?id=117085
2695
2696         Reviewed by Oliver Hunt.
2697
2698         * Scripts/webkitdirs.pm:
2699         (runSafari): Use WinLauncher to display content
2700         * WinLauncher/WinLauncher.cpp:
2701         (dllLauncherEntryPoint): Check for URL argument.
2702
2703 2013-05-31  Roger Fong  <roger_fong@apple.com>
2704
2705         Unreviewed. Modify AssembleBuildLogs project to WebKit solution in preparation for moving buildbots to VCExpress 2010.
2706
2707         * win/AssembleBuildLogs/AssembleLogs.cmd:
2708
2709 2013-05-31  Commit Queue  <commit-queue@webkit.org>
2710
2711         Unreviewed, rolling out r151022.
2712         http://trac.webkit.org/changeset/151022
2713         https://bugs.webkit.org/show_bug.cgi?id=117084
2714
2715         Also breaks build by introducing duplicate symbols (Requested
2716         by bfulgham on #webkit).
2717
2718         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
2719
2720 2013-05-31  Brent Fulgham  <bfulgham@apple.com>
2721
2722         [Windows] Unreviewed build fix to NRWT
2723
2724         * Scripts/webkitpy/port/win.py:
2725         (WinPort.create_debugger_command_file): Use proper argument for _filesystem.write_text_file.
2726
2727 2013-05-31  Brent Fulgham  <bfulgham@apple.com>
2728
2729         [Windows] Unreviewed build fix after r151012
2730
2731         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops: Add dependency on
2732         WTF library to support SHA tests
2733
2734 2013-05-31  Brent Fulgham  <bfulgham@apple.com>
2735
2736         [Windows] Unreviewed build fix after r151012
2737
2738         * TestWebKitAPI/Tests/WTF/MD5.cpp: Include <wtf/StringExtras.h> to provide
2739         snprintf definition for Windows.
2740
2741 2013-05-31  Zan Dobersek  <zdobersek@igalia.com>
2742
2743         Move MD5, SHA1 unit tests from WTF to TestWebKitAPI
2744         https://bugs.webkit.org/show_bug.cgi?id=116445
2745
2746         Reviewed by Benjamin Poulain.
2747
2748         Add the MD5 and SHA1 unit tests that were previously located inside WTF.
2749
2750         * TestWebKitAPI/CMakeLists.txt:
2751         * TestWebKitAPI/GNUmakefile.am:
2752         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
2753         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
2754         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2755         * TestWebKitAPI/Tests/WTF/MD5.cpp: Added.
2756         (TestWebKitAPI):
2757         (TestWebKitAPI::expectMD5):
2758         (TestWebKitAPI::TEST):
2759         * TestWebKitAPI/Tests/WTF/SHA1.cpp: Added.
2760         (TestWebKitAPI):
2761         (TestWebKitAPI::expectSHA1):
2762         (TestWebKitAPI::TEST):
2763         * TestWebKitAPI/Tests/WTF/WTF.pro:
2764         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2765
2766 2013-05-30  Brent Fulgham  <bfulgham@apple.com>
2767
2768         [Windows] Unreviewed build correction.
2769
2770         * Scripts/webkitpy/port/win.py:
2771         (WinPort.create_debugger_command_file): The directory needs to be
2772         a string, not a temporary directory object.
2773
2774 2013-05-30  Brent Fulgham  <bfulgham@apple.com>
2775
2776         [Windows] NRWT doesn't save crash logs on Apple's Windows port.
2777         https://bugs.webkit.org/show_bug.cgi?id=76935
2778
2779         Reviewed by Ryosuke Niwa.
2780
2781         Extend the WinPort class with commands to set and clean up various registry
2782         values needed to invoke the correct debugger to get crash files.
2783
2784         * Scripts/webkitpy/port/win.py:
2785         (WinPort): Added global caches for registry keys and settings
2786         (WinPort._ntsd_location): Added
2787         (WinPort.create_debugger_command_file): Added
2788         (WinPort.read_registry_string): Added
2789         (WinPort.write_registry_string): Added
2790         (WinPort.setup_crash_log_saving): Added
2791         (WinPort.restore_crash_log_saving): Added
2792         (WinPort.setup_test_run): Added overload to add registry settings.
2793         (WinPort.clean_up_test_run): Added overload to clean up registry settings.
2794
2795 2013-05-30  Roger Fong  <roger_fong@apple.com>
2796
2797         Get rid of JavaScript exports file on AppleWin port.
2798         https://bugs.webkit.org/show_bug.cgi?id=117050.
2799
2800         Reviewed by Darin Adler.
2801
2802         Start linking in WTF.lib now that it's a shared library.
2803
2804         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeCommon.props:
2805         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommon.props:
2806         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommon.props:
2807
2808 2013-05-30  Ryosuke Niwa  <rniwa@webkit.org>
2809
2810         Web Inspector: tests in PerformanceTests/inspector/ are timing out
2811         https://bugs.webkit.org/show_bug.cgi?id=77024
2812
2813         Reviewed by Andreas Kling.
2814
2815         Remove inspector performance tests since they have been disabled for ages,
2816         and they don't use the standard parser-style performance output.
2817
2818         It's adding a lot of code complexity to our infrastructure.
2819
2820         * Scripts/webkitpy/performance_tests/perftest.py:
2821         (SingleProcessPerfTest.__init__):
2822         (PerfTestFactory):
2823         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2824         (TestPerfTestFactory.test_regular_test):
2825         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
2826         (TestDriver.run_test):
2827         (MainTest.run_test):
2828         (MainTest._tests_for_runner):
2829         (MainTest.test_run_test_set_kills_drt_per_run):
2830         (MainTest._test_run_with_json_output):
2831         (MainTest):
2832         (MainTest.test_run_with_upload_json_should_generate_perf_webkit_json):
2833
2834 2013-05-30  Ryosuke Niwa  <rniwa@webkit.org>
2835
2836         Remove requires_http_server as Chromium Android was the only port that needed this
2837         https://bugs.webkit.org/show_bug.cgi?id=117018
2838
2839         Reviewed by Benjamin Poulain.
2840
2841         Removed the unused code that existed for Chromium Android port.
2842
2843         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
2844         (LayoutTestRunner.run_tests):
2845         (LayoutTestRunner._handle_finished_test_list):
2846         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2847         (Manager._run_tests):
2848         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2849         (PerfTestsRunner._collect_tests):
2850         (PerfTestsRunner.run):
2851         * Scripts/webkitpy/port/base.py:
2852         (Port.to.start_helper):
2853         * Scripts/webkitpy/port/base_unittest.py:
2854         (PortTest.test_build_path):
2855
2856 2013-05-29  Ruth Fong  <ruth_fong@apple.com>
2857
2858         prepare-Changelog should not be generating namespace-only or class-name-only lines like "(WebCore):"
2859         https://bugs.webkit.org/show_bug.cgi?id=113221
2860
2861         Reviewed by Ryosuke Niwa.
2862
2863         Teach prepare-Changelog to not list the names of modified namespaces, 
2864         classes, or structs in C++ files. Thus, if a change is made 
2865         within a namespace/class/struct yet outside a function, it will 
2866         not be reflected in the ChangeLog entry. 
2867         See https://bugs.webkit.org/show_bug.cgi?id=113221#c8 
2868         for more details on how ChangeLog entries are affected.
2869
2870         * Scripts/prepare-ChangeLog:
2871         (get_function_line_ranges_for_cpp): 
2872         (delete_namespaces_from_ranges_for_cpp): Added.
2873         (is_function_in_namespace): Added.
2874         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt: Updated
2875         to reflect revised definition of a function (i.e. excludes namespaces, classes, structs)
2876
2877 2013-05-29  Praveen R Jadhav  <praveen.j@samsung.com>
2878
2879         Cleanup AudioSourceNode.idl from WebKit build.
2880         https://bugs.webkit.org/show_bug.cgi?id=116905.
2881
2882         Reviewed by Darin Adler.
2883
2884         AudioSourceNode.idl is not part of WebAudio Specifications anymore.
2885         AudioNode is inherited directly in all the audio source nodes.
2886
2887         * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl:
2888
2889 2013-05-29  Andrew Lo  <anlo@rim.com>
2890
2891         Add Andrew Lo to contributors.json
2892         https://bugs.webkit.org/show_bug.cgi?id=116981
2893
2894         Reviewed by Rob Buis.
2895
2896         Adding Andrew Lo to contributors.json.
2897
2898         * Scripts/webkitpy/common/config/contributors.json:
2899
2900 2013-05-29  Adenilson Cavalcanti  <cavalcantii@gmail.com>
2901
2902         Unreviewed. Adding myself as a committer.
2903
2904         * Scripts/webkitpy/common/config/contributors.json:
2905
2906 2013-05-29  Marcelo Lira  <marcelo.lira@openbossa.org>
2907
2908         [WK2][CoordinatedGraphics][EFL] WKViewUserViewportToContents() function doesn't do what it says
2909         https://bugs.webkit.org/show_bug.cgi?id=116683
2910
2911         Reviewed by Noam Rosenthal.
2912
2913         A coordinates conversion test for WKViewUserViewportToContents was
2914         added to WebKit2 API tests.
2915
2916         * TestWebKitAPI/PlatformEfl.cmake:
2917         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp: Added.
2918         (TestWebKitAPI):
2919         (TestWebKitAPI::TEST):
2920
2921 2013-05-29  Yong Li  <yong.li.webkit@outlook.com>
2922
2923         Unreviewed. Update my info.
2924
2925         * Scripts/webkitpy/common/config/contributors.json:
2926
2927 2013-05-29  Dongseong Hwang  <dongseong.hwang@intel.com>
2928
2929         Unreviewed. Add myself as committer in contributors.json.
2930
2931         * Scripts/webkitpy/common/config/contributors.json:
2932
2933 2013-05-29  Carlos Garcia Campos  <cgarcia@igalia.com>
2934
2935         Unreviewed. Fix make distcheck.
2936
2937         * TestWebKitAPI/GNUmakefile.am: Add WebCoreLayer.a to
2938         DISTCLEANFILES.
2939
2940 2013-05-29  Mary Wu  <mawu@blackberry.com>
2941
2942         Unreviewed: update my email address in contributors.json.
2943
2944         * Scripts/webkitpy/common/config/contributors.json:
2945
2946 2013-05-29  Kalyan Kondapally  <kalyan.kondapally@intel.com>
2947
2948         Unreviewed: Adding myself to committers list.
2949
2950         * Scripts/webkitpy/common/config/contributors.json:
2951
2952 2013-05-28  Arpita Bahuguna  <a.bah@samsung.com>
2953
2954         Unreviewed: Adding myself to committers list.
2955
2956         * Scripts/webkitpy/common/config/contributors.json:
2957
2958 2013-05-28  Brent Fulgham  <bfulgham@webkit.org>
2959
2960         [Windows] Many CSS2.1 tests fail under NRWT.
2961         https://bugs.webkit.org/show_bug.cgi?id=75707
2962
2963         Reviewed by Darin Adler.
2964
2965         * DumpRenderTree/win/DumpRenderTree.cpp:
2966         (findFontFallback): Added
2967         (addFontFallbackIfPresent): Added
2968         (removeFontFallbackIfPresent): Added
2969         (runTest): Set up/remove font fallbacks when needed.
2970
2971 2013-05-28  Brent Fulgham  <bfulgham@apple.com>
2972
2973         [Windows] NRWT reports failure for 'mac' test cases.
2974         https://bugs.webkit.org/show_bug.cgi?id=116698
2975
2976         Reviewed by Ryosuke Niwa.
2977
2978         The Windows port falls back to the Mac port for many test results,
2979         and so adds the mac and mac-wk2 to its set of fallbacks.
2980         Unfortunately, NRWT thinks that this means that tests in these
2981         folders should be executed, resulting in many failures on
2982         Windows.
2983
2984         This change overloads the '_tests_for_other_platforms' method
2985         to return a subset of the result fallback list so that we do
2986         not attempt to execute Mac tests on Windows.
2987
2988         * Scripts/webkitpy/port/base.py:
2989         (Port.test_search_path): Added. Defaults to just calling the
2990         baseline_search_path method, which is how most ports behave.
2991         (Port._test_for_other_platforms): Modified to call the new
2992         test_search_path method.
2993
2994         * Scripts/webkitpy/port/win.py:
2995         (WinPort.test_search_path): Added custom overload. Strips
2996         out mac-specific test paths.
2997
2998 2013-05-28  Martin Robinson  <mrobinson@igalia.com>
2999
3000         Fix GTK+ CMake build
3001
3002         * MiniBrowser/gtk/CMakeLists.txt: After r150336, the name of the WebKit2
3003         library target is simply "WebKit2."
3004
3005 2013-05-28  Zan Dobersek  <zdobersek@igalia.com>
3006
3007         [webkitpy] Explicitly specify the reference file extensions
3008         https://bugs.webkit.org/show_bug.cgi?id=116333
3009
3010         Reviewed by Benjamin Poulain.
3011
3012         Explicitly specify the extensions that are valid for the reference files. This helps to differentiate
3013         between valid reference files required by reftests and text baselines that have the same extension as
3014         potential test files (specifically the current MHTML tests in the .mht files and the future .mht baselines
3015         that were until this change recognized as reference files).
3016
3017         Covered by existing tests and the new test_is_reference_html_file test in webkitpy.port.base_unittest.
3018
3019         * Scripts/webkitpy/port/base.py:
3020         (Port.reference_files): Iterate through the _supported_reference_extensions set.
3021         (Port): Rename the _supported_file_extensions set to _supported_test_extensions. Add the
3022         _supported_reference_extensions set, containing the extensions allowed for reference files.
3023         (Port.is_reference_html_file): Return False if the file's extension is not a supported reference file extension.
3024         (Port._has_supported_extension): Use _supported_test_extensions.
3025         * Scripts/webkitpy/port/base_unittest.py:
3026         (PortTest.test_is_reference_html_file): Add the unit test, testing various test cases around the
3027         Port.is_reference_html_file method.
3028
3029 2013-05-26  Ryosuke Niwa  <rniwa@webkit.org>
3030
3031         Yet another WKR build fix. Sorry for the mess. It seems like I can't win today :(
3032
3033         * Scripts/webkitpy/tool/commands/newcommitbot.py:
3034         (NewCommitBot.next_work_item):
3035
3036 2013-05-26  Ryosuke Niwa  <rniwa@webkit.org>
3037
3038         WKR and webkitbot build fixes.
3039
3040         * Scripts/webkitpy/tool/bot/irc_command.py:
3041         (RollChromiumDEPS.execute):
3042         * Scripts/webkitpy/tool/commands/newcommitbot.py:
3043         (NewCommitBot.next_work_item):
3044
3045 2013-05-26  Ryosuke Niwa  <rniwa@webkit.org>
3046
3047         roll-chromium-deps doesn't repeat the full name.
3048
3049         Rubber-stamped by Andreas Kling.
3050
3051         * Scripts/webkitpy/tool/bot/irc_command.py:
3052         (RollChromiumDEPS.execute):
3053
3054 2013-05-25  Ryosuke Niwa  <rniwa@webkit.org>
3055
3056         Revert another erroneous change.
3057
3058         * Scripts/webkitpy/tool/commands/newcommitbot.py:
3059         (NewCommitBot.next_work_item):
3060
3061 2013-05-25  Ryosuke Niwa  <rniwa@webkit.org>
3062
3063         Revert an erroneous change.
3064
3065         * Scripts/webkitpy/tool/commands/sheriffbot.py:
3066         (SheriffBot):
3067
3068 2013-05-25  Ryosuke Niwa  <rniwa@webkit.org>
3069
3070         Some build fixes for WKR and webkitbot.
3071
3072         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
3073         (IRCBotTest.test_help):
3074         * Scripts/webkitpy/tool/commands/newcommitbot.py:
3075         (Agent):
3076         (Agent.__init__):
3077         (Agent.name):
3078         (NewCommitBot):
3079         (NewCommitBot.begin_work_queue):
3080         (NewCommitBot.next_work_item):
3081         * Scripts/webkitpy/tool/commands/sheriffbot.py:
3082         (SheriffBot):
3083
3084 2013-05-25  Ryosuke Niwa  <rniwa@webkit.org>
3085
3086         Teach webkitbot and WKR how to respond to yt?
3087         https://bugs.webkit.org/show_bug.cgi?id=116775
3088
3089         Reviewed by Andreas Kling.
3090
3091         * Scripts/webkitpy/tool/bot/irc_command.py:
3092         (Hi): Fixed the usage string.
3093         (Hi.execute): Made it more generic so that it works in WKR.
3094         (YouThere): Added.
3095         (YouThere.execute): Added.
3096         * Scripts/webkitpy/tool/commands/newcommitbot.py:
3097
3098 2013-05-25  Simon Fraser  <simon.fraser@apple.com>
3099
3100         Try to fix the EFL build.
3101         
3102         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3103         (TestRunner::setPageVisibility):
3104
3105 2013-05-25  Simon Fraser  <simon.fraser@apple.com>
3106
3107         Unprefix Page Visibility API
3108         https://bugs.webkit.org/show_bug.cgi?id=102340
3109
3110         Reviewed by Tim Horton.
3111         
3112         Rename "preview" state to "unloaded" state, and adjust the tests
3113         to test for it.
3114
3115         * DumpRenderTree/mac/TestRunnerMac.mm:
3116         (TestRunner::setPageVisibility):
3117         * TestWebKitAPI/Tests/WebKit2/PageVisibilityState.cpp:
3118         (TestWebKitAPI::setPageVisibilityStateWithEvalContinuation):
3119         (TestWebKitAPI::didRunStep2StateChangeHiddenToPrerender):
3120         (TestWebKitAPI::didRunStep3StateChangePrerenderToUnloaded):
3121         (TestWebKitAPI::didRunStep4InStateUnloaded):
3122         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.html:
3123         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
3124         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):
3125         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3126         (WTR::TestRunner::setPageVisibility):
3127
3128 2013-05-24  Brent Fulgham  <bfulgham@apple.com>
3129
3130         Unreviewed build fix. Don't use new NRWT logic needed
3131         by Windows yet. Activate (and fix test) when we cut over.
3132
3133         * Scripts/webkitpy/port/driver.py:
3134         (Driver._setup_environ_for_driver):
3135         (Driver._start):
3136
3137 2013-05-24  Brent Fulgham  <bfulgham@apple.com>
3138
3139         [Windows] Expose database storage and cache locations via preferences.
3140         https://bugs.webkit.org/show_bug.cgi?id=116729
3141
3142         Reviewed by Tim Horton.
3143
3144         Update DumpRenderTree to use CFPreferences to control where WebKit
3145         stores its local databases, URL caches, etc.
3146
3147         * DumpRenderTree/win/DumpRenderTree.cpp:
3148         (libraryPathForDumpRenderTree): Added.
3149         (dllLauncherEntryPoint): Set up DRT-specific cache locations.
3150         * Scripts/webkitpy/port/base.py:
3151         (Port._driver_tempdir): Added (to allow port-specific overload).
3152         (Port._driver_tempdir_for_environment): Ditto
3153         * Scripts/webkitpy/port/driver.py:
3154         (Driver._setup_environ_for_driver): Use new overload to set
3155         environment variable.
3156         (Driver._start): Use new overload for temp directory location.
3157         * Scripts/webkitpy/port/win.py:
3158         (WinPort._driver_tempdir_for_environment): New overload to supply
3159         Windows path to DumpRenderTree environment (while still using
3160         cygwin paths for internal operations.
3161
3162 2013-05-24  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3163
3164         Remove custom code for webkitAudioContext global constructor getter
3165         https://bugs.webkit.org/show_bug.cgi?id=116530
3166
3167         Reviewed by Geoffrey Garen.
3168
3169         Update EFL's DumpRenderTree to use DumpRenderTreeSupport to toggle
3170         WebAudio feature instead of public ewk_view API since that API was
3171         removed.
3172
3173         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3174         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
3175         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3176         (TestRunner::overridePreference):
3177
3178 2013-05-24  Bem Jones-Bey  <bjonesbe@adobe.com>
3179
3180         Make team.html have each contributor's area of expertise
3181         https://bugs.webkit.org/show_bug.cgi?id=116737
3182
3183         Reviewed by Benjamin Poulain.
3184
3185         * Scripts/webkitpy/common/config/contributors.json:
3186         Add expertise to each contributor, taken from http://trac.webkit.org/wiki/WebKit%20Team
3187         
3188         Changed formatting of the file because the lines are getting way to
3189         long, and I generated this, so it's easier if the formatting of the
3190         file is regular.
3191
3192 2013-05-24  Simon Pena  <simon.pena@samsung.com>
3193
3194         Update WTF::Vector pretty printers
3195         https://bugs.webkit.org/show_bug.cgi?id=116719
3196
3197         Reviewed by Anders Carlsson.
3198
3199         After r148891, WTF::Vector pretty printers were left outdated, as
3200         the WTF::Vector was made to extend a VectorBuffer, instead of keeping
3201         one as a member. This patch updates the pretty printers so they work
3202         again. 
3203
3204         * gdb/webkit.py:
3205         (WTFVectorPrinter.children):
3206         (WTFVectorPrinter.to_string):
3207
3208 2013-05-24  Steve Falkenburg  <sfalken@apple.com>
3209
3210         Update prepareConsistentTestingEnvironment to use a non-deprecated API.
3211         https://bugs.webkit.org/show_bug.cgi?id=116710
3212
3213         Reviewed by Mark Rowe.
3214
3215         * DumpRenderTree/mac/DumpRenderTree.mm:
3216         (prepareConsistentTestingEnvironment): Use beginActivityWithOptions instead of beginSuspensionOfSystemBehaviors.
3217
3218 2013-05-23  Lauro Neto  <lauro.neto@openbossa.org>
3219
3220         Add missing dependencies to deps script.
3221
3222         [GTK] Missing packages in install-dependencies script.
3223         https://bugs.webkit.org/show_bug.cgi?id=116632
3224
3225         Reviewed by Martin Robinson.
3226
3227         * gtk/install-dependencies:
3228
3229 2013-05-23  Brent Fulgham  <bfulgham@apple.com>
3230
3231         [Windows] Unreviewed change for NRWT support.
3232
3233         * Scripts/webkitpy/port/win.py:
3234         (WinPort.default_child_processes): Added a default implementation
3235         that limits NRWT to a single instance.
3236
3237 2013-05-23  Brent Fulgham  <bfulgham@apple.com>
3238
3239         Remove meaningless "test_uses_apache" from Python test cases.
3240         https://bugs.webkit.org/show_bug.cgi?id=38756
3241
3242         Reviewed by Ryosuke Niwa.
3243
3244         * Scripts/webkitpy/port/port_testcase.py:
3245         (PortTestCase.test_driver_cmd_line): Remove the meaningless
3246         "test_uses_apache" test case from the Python test infrastructure.
3247         It was hard-coded to true, even though not all ports use
3248         Apache.
3249
3250 2013-05-23  Brent Fulgham  <bfulgham@webkit.org>
3251
3252         [Windows] Update new-run-webkit-tests for Windows port.
3253         https://bugs.webkit.org/show_bug.cgi?id=38756
3254
3255         Reviewed by Ryosuke Niwa.
3256
3257         * Scripts/new-run-webkit-httpd:
3258         (run): Switch from 'chromium' to 'win'
3259         * Scripts/webkitpy/port/win.py:
3260         (WinPort): Add support methods for lighttpd server.
3261         (WinPort._uses_apache):
3262         (WinPort._path_to_lighttpd):
3263         (WinPort._path_to_lighttpd_modules):
3264         (WinPort._path_to_lighttpd_php):
3265
3266 2013-05-23  Patrick Gansterer  <paroga@webkit.org>
3267
3268         Make default bug links in buildbot clickable
3269         https://bugs.webkit.org/show_bug.cgi?id=116673
3270
3271         Reviewed by Ryosuke Niwa.
3272
3273         Use changecommentlink of html.WebStatus to make the links clickable.
3274
3275         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3276
3277 2013-05-22  Ryosuke Niwa  <rniwa@webkit.org>
3278
3279         REGRESSION(r150491): WebKit2.DOMWindowExtensionNoCache fails
3280         https://bugs.webkit.org/show_bug.cgi?id=116595
3281
3282         Temporarily skip this test.
3283
3284         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache.cpp:
3285         (TestWebKitAPI::TEST):
3286
3287 2013-05-22  Alex Christensen  <achristensen@apple.com>
3288
3289         Unreviewed.  Added myself to contributors.json.
3290
3291         * Scripts/webkitpy/common/config/contributors.json:
3292         Added myself.
3293
3294 2013-05-22  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
3295
3296         [EFL][WK2] Add sub menus to MiniBrowser
3297         https://bugs.webkit.org/show_bug.cgi?id=114728
3298
3299         Reviewed by Christophe Dumez.
3300
3301         Elementary Ctxpopup widget API does not provide support for submenu item.
3302         To implement ewk submenus in Minibrowser, Ctxpopup has to be replaced with
3303         Elementary Menu widget.
3304
3305         * MiniBrowser/efl/main.c:
3306         (_Browser_Window):
3307         (on_window_resize):
3308         (window_free):
3309         (context_menu_item_selected_cb):
3310         (context_menu_populate):
3311         (on_context_menu_show):
3312         (on_context_menu_hide):
3313         (window_create):
3314
3315 2013-05-22  Andrzej Badowski  <a.badowski@samsung.com>
3316
3317         [EFL] Add command line option to MiniBrowser to set cookies policy.
3318         https://bugs.webkit.org/show_bug.cgi?id=115028
3319
3320         Reviewed by Christophe Dumez.
3321
3322         Add command line option to MiniBrowser EFL to set cookies policy:
3323         -p parameter with value from (always, never, no-third-party) respectively (EWK_COOKIE_ACCEPT_POLICY_ALWAYS,
3324         EWK_COOKIE_ACCEPT_POLICY_NEVER, EWK_COOKIE_ACCEPT_POLICY_NO_THIRD_PARTY).
3325
3326         * MiniBrowser/efl/main.c:
3327         (elm_main):
3328
3329 2013-05-21  Ryosuke Niwa  <rniwa@webkit.org>
3330
3331         REGRESSION(r150369): WebKit2WillLoadTest tests are failing
3332         https://bugs.webkit.org/show_bug.cgi?id=116585
3333
3334         Reviewed by Alexey Proskuryakov.
3335
3336         willLoadURLRequest and willLoadDataRequest require the API version 6.
3337
3338         * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp:
3339
3340 2013-05-21  Ryosuke Niwa  <rniwa@webkit.org>
3341
3342         REGRESSION(r150393): editing/inserting/typing-at-end-of-line.html fails
3343         https://bugs.webkit.org/show_bug.cgi?id=116516
3344
3345         Reviewed by Alexey Proskuryakov.
3346
3347         Reset states in DumpRenderTree. The fix for WebKitTestRunner should be implemented in the bug 116577.
3348
3349         * DumpRenderTree/mac/DumpRenderTree.mm:
3350         (createWebViewAndOffscreenWindow): Match the ordering.
3351         (resetWebViewToConsistentStateBeforeTesting): Reset text replacement states.
3352
3353 2013-05-21  Alexey Proskuryakov  <ap@apple.com>
3354
3355         <rdar://problem/13929704> [WK2] WebKitTestRunner always crashes on exit
3356         https://bugs.webkit.org/show_bug.cgi?id=116568
3357
3358         Reviewed by Anders Carlsson.
3359
3360         * WebKitTestRunner/WebNotificationProvider.cpp:
3361         (WTR::WebNotificationProvider::~WebNotificationProvider):
3362         * WebKitTestRunner/WebNotificationProvider.h:
3363         When the provider is destroyed, it should no longer be registered with the manager.
3364
3365         * WebKitTestRunner/GeolocationProviderMock.cpp:
3366         (WTR::GeolocationProviderMock::~GeolocationProviderMock):
3367         * WebKitTestRunner/GeolocationProviderMock.h:
3368         I wasn't seeing a crash here, but this code has the same issue as notification
3369         provider, so applying the same fix.
3370
3371         * WebKitTestRunner/TestController.cpp: (WTR::TestController::~TestController):
3372         Close icon database. I started seeing ASSERT(!isOpen()) in WebCore IconDatabase
3373         destructor having fixed the above.
3374
3375 2013-05-21  Commit Queue  <commit-queue@webkit.org>
3376
3377         Unreviewed, rolling out r150386 and r150397.
3378         http://trac.webkit.org/changeset/150386
3379         http://trac.webkit.org/changeset/150397
3380         https://bugs.webkit.org/show_bug.cgi?id=116572
3381
3382         Broke a test; Alex is going to try again later. (Requested by
3383         thorton on #webkit).
3384
3385         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3386         (WTR::pathSuitableForTestResult):
3387         (WTR::dumpRequestDescriptionSuitableForTestResult):
3388         (WTR::dumpResponseDescriptionSuitableForTestResult):
3389         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame):
3390         (WTR::InjectedBundlePage::didInitiateLoadForResource):
3391         (WTR::InjectedBundlePage::willSendRequestForFrame):
3392         (WTR::InjectedBundlePage::didReceiveResponseForResource):
3393         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3394         (InjectedBundlePage):
3395
3396 2013-05-21  Ryosuke Niwa  <rniwa@webkit.org>
3397
3398         Fix a python unittest after r149419. We need to support Python 2.6 on Windows.
3399
3400         * Scripts/webkitpy/tool/commands/suggestnominations.py:
3401         (AbstractCommitLogCommand._recent_commit_messages):
3402
3403 2013-05-21  Martin Robinson  <mrobinson@igalia.com>
3404
3405         [GTK] [CMake] Add support for building WebKit2
3406         https://bugs.webkit.org/show_bug.cgi?id=116372
3407
3408         Reviewed by Gustavo Noronha Silva.
3409
3410         * CMakeLists.txt: Do not build WebKitTestRunner yet for WebKitGTK+.
3411         * MiniBrowser/gtk/CMakeLists.txt: Added.
3412
3413 2013-05-21  Jessie Berlin  <jberlin@apple.com>
3414
3415         Revert r149635, it was too optimistic.
3416
3417         Rubber-stamped by Andreas Kling.
3418
3419         We are not at the point where we can always use more descriptive macros instead of PLATFORM()
3420         #ifdefs in WebCore code outside of WebCore/platform.
3421
3422         * Scripts/webkitpy/style/checkers/cpp.py:
3423         (check_invalid_increment):
3424         (process_line):
3425         (CppChecker):
3426         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3427         (CppStyleTest.test_plain_integral_bitfields):
3428
3429 2013-05-21  Jer Noble  <jer.noble@apple.com>
3430
3431         Unreviewed; fix lldb synthetic representation of WTF::Vector after r148891.
3432
3433         * lldb/lldb_webkit.py:
3434         (WTFVectorProvider.num_children):
3435         (WTFVectorProvider.get_child_index):
3436         (WTFVectorProvider.get_child_at_index):
3437         (WTFVectorProvider.update):
3438
3439 2013-05-21  Jessie Berlin  <jberlin@apple.com>
3440
3441         Expose a way to know when forms are added to a page or when form controls are added to a form
3442         in the injected bundle
3443         https://bugs.webkit.org/show_bug.cgi?id=116334
3444
3445         Reviewed by Alexey Proskuryakov.
3446
3447         Add tests for the new callbacks.
3448
3449         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3450         Add DidAssociateFormControls/_Bundle.cpp and associate-form-controls.html
3451
3452         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls.cpp: Added.
3453         (TestWebKitAPI::nullJavaScriptCallback):
3454         A "null" callback to handle the fact that WKPageRunJavaScriptInMainFrame cannot handle null
3455         being passed in for the callback.
3456         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
3457         After receiving the message that didAssociateFormControls callback was invoked from adding
3458         the form in the onload handler, tell the page to add a password field to the form, which
3459         should also invoke didAssociateFormControls callback.
3460         (TestWebKitAPI::setInjectedBundleClient):
3461         Register to receive messages.
3462         (TestWebKitAPI::TEST):
3463         Load associate-form-controls.html and wait until the didAssociateFormControls callback has
3464         been invoked for both adding the form and for adding a password field to the form.
3465
3466         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp: Added.
3467         (TestWebKitAPI::shouldNotifyOnFormChanges):
3468         Return true so the didAssociateFormControls callback is invoked.
3469         (TestWebKitAPI::didAssociateFormControls):
3470         Tell the UI process.
3471         (TestWebKitAPI::DidAssociateFormControlsTest::DidAssociateFormControlsTest):
3472         (TestWebKitAPI::DidAssociateFormControlsTest::didCreatePage):
3473         Register for the shouldNotifyOnFormChanges and didAssociateFormControls callbacks.
3474
3475         * TestWebKitAPI/Tests/WebKit2/associate-form-controls.html: Added.
3476         Add a form in response to the onload event. Add a button that will add the password field
3477         for manual testing.
3478
3479 2013-05-21  Krzysztof Czech  <k.czech@samsung.com>
3480
3481         [GTK][WK2] accessibility/label-for-control-hittest.html is failing
3482         https://bugs.webkit.org/show_bug.cgi?id=106341
3483
3484         Reviewed by Martin Robinson.
3485
3486         Adds support for retrieving accessibility element at exact point.
3487
3488         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3489         (WTR::AccessibilityUIElement::elementAtPoint):
3490
3491 2013-05-21  Krzysztof Czech  <k.czech@samsung.com>
3492
3493         [ATK] [WebKit2] AccessibilityUIElement often leaks its AtkObject
3494         https://bugs.webkit.org/show_bug.cgi?id=112913
3495
3496         Reviewed by Martin Robinson.
3497
3498         AccessibilityUIElement is often created by passing new reference to AtkObject (transfer full).
3499         AccessibilityUIElement::~AccessibilityUIElement does not decrement the reference of the element,
3500         so the leak appears.
3501
3502         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
3503         (WTR):
3504         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3505         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
3506         (WTR::AccessibilityController::rootElement):
3507         (WTR):
3508         (WTR::AccessibilityController::focusedElement):
3509         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3510         (WTR::checkElementState):
3511         (WTR::indexRangeInTable):
3512         (WTR::alterCurrentValue):
3513         (WTR::AccessibilityUIElement::getChildren):
3514         (WTR::AccessibilityUIElement::getChildrenWithRange):
3515         (WTR::AccessibilityUIElement::childrenCount):
3516         (WTR::AccessibilityUIElement::indexOfChild):
3517         (WTR::AccessibilityUIElement::titleUIElement):
3518         (WTR::AccessibilityUIElement::parentElement):
3519         (WTR::AccessibilityUIElement::allAttributes):
3520         (WTR::AccessibilityUIElement::role):
3521         (WTR::AccessibilityUIElement::title):
3522         (WTR::AccessibilityUIElement::description):
3523         (WTR::AccessibilityUIElement::orientation):
3524         (WTR::AccessibilityUIElement::stringValue):
3525         (WTR::AccessibilityUIElement::language):
3526         (WTR::AccessibilityUIElement::x):
3527         (WTR::AccessibilityUIElement::y):
3528         (WTR::AccessibilityUIElement::width):
3529         (WTR::AccessibilityUIElement::height):
3530         (WTR::AccessibilityUIElement::intValue):
3531         (WTR::AccessibilityUIElement::minValue):
3532         (WTR::AccessibilityUIElement::maxValue):
3533         (WTR::AccessibilityUIElement::isEnabled):
3534         (WTR::AccessibilityUIElement::isFocused):
3535         (WTR::AccessibilityUIElement::isSelected):
3536         (WTR::AccessibilityUIElement::isExpanded):
3537         (WTR::AccessibilityUIElement::isChecked):
3538         (WTR::AccessibilityUIElement::rowCount):
3539         (WTR::AccessibilityUIElement::columnCount):
3540         (WTR::AccessibilityUIElement::rowIndexRange):
3541         (WTR::AccessibilityUIElement::columnIndexRange):
3542         (WTR::AccessibilityUIElement::cellForColumnAndRow):
3543         (WTR::AccessibilityUIElement::increment):
3544         (WTR::AccessibilityUIElement::decrement):
3545         (WTR::AccessibilityUIElement::press):
3546         (WTR::AccessibilityUIElement::documentEncoding):
3547         (WTR::AccessibilityUIElement::documentURI):
3548         (WTR::AccessibilityUIElement::isFocusable):
3549         (WTR::AccessibilityUIElement::isSelectable):
3550         (WTR::AccessibilityUIElement::isMultiSelectable):
3551         (WTR::AccessibilityUIElement::isVisible):
3552
3553 2013-05-20  Lucas Forschler  <lforschler@apple.com>
3554
3555     Rollout 150398.
3556     
3557 2013-05-20  Zan Dobersek  <zdobersek@igalia.com>
3558
3559         [GTK] Fix concatenations of string literals that are not C++11-compliant
3560         https://bugs.webkit.org/show_bug.cgi?id=116449
3561
3562         Reviewed by Martin Robinson.
3563
3564         Fix the problematic concatenations of string literals so they are compilable under the C++11 standard. This
3565         is simply a matter of separating the string and the string literal that are being concatenated with a space.
3566
3567         * ImageDiff/gtk/ImageDiff.cpp:
3568         (printImage):
3569
3570 2013-05-20  Zan Dobersek  <zdobersek@igalia.com>
3571
3572         [GTK] Pass GTEST_HAS_RTTI=0 cppflag to TestWebKitAPI programs at compilation-time
3573         https://bugs.webkit.org/show_bug.cgi?id=116450
3574
3575         Reviewed by Martin Robinson.
3576
3577         The -fno-rtti flag is used when compiling C++ source code throughout the project. The TestWebKitAPI
3578         programs fail to compile because of this when using the C++11 standard as the GTest headers assume by
3579         default that the RTTI support is available. This can be turned off by passing GTEST_HAS_RTTI=0 to the
3580         TestWebKitAPI programs when compiling them.
3581
3582         * TestWebKitAPI/GNUmakefile.am:
3583
3584 2013-05-20  Ryosuke Niwa  <rniwa@webkit.org>
3585
3586         Remove DriverProxy._running_drivers from webkitpy.layout_tests.port
3587         https://bugs.webkit.org/show_bug.cgi?id=116492
3588
3589         Reviewed by Dirk Pranke.
3590
3591         Merge https://chromium.googlesource.com/chromium/blink/+/1af2f0be5a1746784ff114952f29f7b8fa9895f3.
3592
3593         The DriverProxy class had the concept of keeping a pool of started DRTs around (indexed by command line)
3594         so that we didn't necessarily need to restart DRT when the command line for a test changed (e.g., when
3595         starting to run tests in a virtual suite). However, the pool was per-worker (so not shared across the machine)
3596         and we didn't cap the number of processes started, so we would end up with a whole bunch of DRTs (3x-4x
3597         the number of workers started). If anything, this seemed to make the tests slightly slower and probably added
3598         to memory pressure on the machine.
3599
3600         This change removes the pool code; now we'll simply restart DRT when the command line changes. With this change,
3601         we can actually fold the restarting code into Driver itself (and get rid of DriverProxy), but I'll leave that
3602         for a subsequent patch just to make things easier to follow.
3603
3604         * Scripts/webkitpy/port/driver.py:
3605         (DriverProxy.__init__):
3606         (DriverProxy.run_test):
3607         (DriverProxy.has_crashed):
3608         (DriverProxy.stop):
3609
3610 2013-05-20  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3611
3612         Change EFL Linux 64-bit Release with EFL Linux 64-bit Release WK1
3613         https://bugs.webkit.org/show_bug.cgi?id=116423
3614
3615         Reviewed by Ryosuke Niwa.
3616
3617         EFL Linux 64-bit Release starts to support WK1's build and layout test from now on.
3618
3619         * BuildSlaveSupport/build.webkit.org-config/config.json:
3620
3621 2013-05-20  Seokju Kwon  <seokju.kwon@gmail.com>
3622
3623         Remove remaining link-prerender code
3624         https://bugs.webkit.org/show_bug.cgi?id=116429
3625
3626         Reviewed by Darin Adler.
3627
3628         Link prerendering code was removed in r150356.
3629
3630         * Scripts/webkitperl/FeatureList.pm:
3631         * qmake/mkspecs/features/features.pri:
3632
3633 2013-05-20  Ryosuke Niwa  <rniwa@webkit.org>
3634
3635         commit-queue should check for oops in changelog entries
3636         https://bugs.webkit.org/show_bug.cgi?id=116395
3637
3638         Reviewed by Martin Robinson.
3639
3640         Make changelog validation fail when it contains oops!.
3641
3642         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3643         (CommitQueueTask._validate_changelog):
3644         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3645         (CommitQueueTaskTest._run_through_task):
3646         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3647         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
3648         (ValidateChangeLogs.options):
3649         (ValidateChangeLogs._check_changelog_diff):
3650         (ValidateChangeLogs._changelog_contains_oops):
3651         (ValidateChangeLogs.run):
3652         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
3653         (ValidateChangeLogsTest._assert_start_line_produces_output):
3654         (ValidateChangeLogsTest.test_check_changelog_diff):
3655         (ValidateChangeLogsTest):
3656         (ValidateChangeLogsTest.test_changelog_contains_oops):
3657
3658 2013-05-20  Jessie Berlin  <jberlin@apple.com>
3659
3660         Expose a way to know when forms are added to a page or when form controls are added to a form
3661         in the injected bundle
3662         https://bugs.webkit.org/show_bug.cgi?id=116334
3663
3664         Reviewed by Alexey Proskuryakov.
3665
3666         Add tests for the new callbacks.
3667
3668         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3669         Add DidAssociateFormControls/_Bundle.cpp and associate-form-controls.html
3670
3671         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls.cpp: Added.
3672         (TestWebKitAPI::nullJavaScriptCallback):
3673         A "null" callback to handle the fact that WKPageRunJavaScriptInMainFrame cannot handle null
3674         being passed in for the callback.
3675         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
3676         After receiving the message that didAssociateFormControls callback was invoked from adding
3677         the form in the onload handler, tell the page to add a password field to the form, which
3678         should also invoke didAssociateFormControls callback.
3679         (TestWebKitAPI::setInjectedBundleClient):
3680         Register to receive messages.
3681         (TestWebKitAPI::TEST):
3682         Load associate-form-controls.html and wait until the didAssociateFormControls callback has
3683         been invoked for both adding the form and for adding a password field to the form.
3684
3685         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp: Added.
3686         (TestWebKitAPI::shouldNotifyOnFormChanges):
3687         Return true so the didAssociateFormControls callback is invoked.
3688         (TestWebKitAPI::didAssociateFormControls):
3689         Tell the UI process.
3690         (TestWebKitAPI::DidAssociateFormControlsTest::DidAssociateFormControlsTest):
3691         (TestWebKitAPI::DidAssociateFormControlsTest::didCreatePage):
3692         Register for the shouldNotifyOnFormChanges and didAssociateFormControls callbacks.
3693
3694         * TestWebKitAPI/Tests/WebKit2/associate-form-controls.html: Added.
3695         Add a form in response to the onload event. Add a button that will add the password field
3696         for manual testing.
3697
3698 2013-05-20  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3699
3700         [EFL][JHBUILD] Make sure eet is built before evas
3701         https://bugs.webkit.org/show_bug.cgi?id=116440
3702
3703         Reviewed by Gyuyoung Kim.
3704
3705         Mark eet as a dependency of evas since evas requires eet to enable some of its
3706         functionality.
3707
3708         * efl/jhbuild.modules:
3709
3710 2013-05-20  Alex Christensen  <achristensen@apple.com>
3711
3712         WTR::pathSuitableForTestResult should behave the same as _drt_descriptionSuitableForTestResult so we can unskip tests.
3713         https://bugs.webkit.org/show_bug.cgi?id=116125
3714
3715         Reviewed by Tim Horton.
3716
3717         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3718         (WTR::pathSuitableForTestResult):
3719         Changed string operations to match _drt_descriptionSuitableForTestResult.
3720         (WTR::dumpRequestDescriptionSuitableForTestResult):
3721         (WTR::dumpResponseDescriptionSuitableForTestResult):
3722         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame):
3723         (WTR::InjectedBundlePage::didInitiateLoadForResource):
3724         (WTR::InjectedBundlePage::willSendRequestForFrame):
3725         (WTR::InjectedBundlePage::didReceiveResponseForResource):
3726         Pass the main frame's URL to pathSuitableForTestResult.
3727         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3728         Added WKBundlePageRef to willPerformClientRedirectForFrame.
3729
3730 2013-05-20  Dirk Pranke  <dpranke@chromium.org>
3731
3732         fix w3c test importer unit tests after r150324
3733         https://bugs.webkit.org/show_bug.cgi?id=116459
3734
3735         Reviewed by Ryosuke Niwa.
3736
3737         This patch fixes the unit tests to not actually call out to
3738         'hg' (by using a mock executive) and also changes the real
3739         directory we crawl from Source/WebCore/css to
3740         Tools/Scripts/webkitpy/w3c to run much more quickly. We should
3741         still change this to a mock filesystem, but that's a separate change.
3742
3743         * Scripts/webkitpy/w3c/test_importer.py:
3744         (main):
3745         (TestImporter.__init__):
3746         (TestImporter.load_changeset):
3747         * Scripts/webkitpy/w3c/test_importer_unittest.py:
3748         (TestImporterTest.test_import_dir_with_no_tests_and_no_hg):
3749         (TestImporterTest.test_import_dir_with_no_tests):
3750
3751 2013-05-20  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3752
3753         Unreviewed EFL build fix.
3754
3755         Fix linking errors due to undefined symbols on Ubuntu 13.04.
3756
3757         * DumpRenderTree/efl/CMakeLists.txt:
3758         * EWebLauncher/CMakeLists.txt:
3759         * MiniBrowser/efl/CMakeLists.txt:
3760
3761 2013-05-20  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3762
3763         [EFL] Reenabled INDEXED_DATABASE after r150344
3764         https://bugs.webkit.org/show_bug.cgi?id=116430
3765
3766         Reviewed by Gyuyoung Kim.
3767
3768         Reenable INDEXED_DATABASE flag for EFL port now that WebKit2
3769         build was fixed in r150344.
3770
3771         * Scripts/webkitperl/FeatureList.pm:
3772
3773 2013-05-19  Ryuan Choi  <ryuan.choi@samsung.com>
3774
3775         [EFL] init/shutdown should be paired in EWebLauncher
3776         https://bugs.webkit.org/show_bug.cgi?id=116427
3777
3778         Reviewed by Christophe Dumez.
3779
3780         Added ecore_file_shutdown() for cleanup of ecore_file.
3781         Removed edje_init and ecore_evas_init because it was in ewk_init().
3782
3783         * EWebLauncher/main.c:
3784         (main):
3785
3786 2013-05-19  Jinwoo Song  <jinwoo7.song@samsung.com>
3787
3788         [EFL] Add command line option to MiniBrowser to set user agent
3789         https://bugs.webkit.org/show_bug.cgi?id=116387
3790
3791         Reviewed by Christophe Dumez.
3792
3793         We need this option to compare the rendering differences according to different user agents.
3794
3795         * MiniBrowser/efl/main.c:
3796         (window_create):
3797         (elm_main):
3798
3799 2013-05-19  Zan Dobersek  <zdobersek@igalia.com>
3800
3801         Unreviewed, addressing test-webkitpy failures after r150317.
3802
3803         * Scripts/webkitpy/w3c/test_converter.py:
3804         (W3CTestConverter.read_webkit_prefixed_css_property_list): CssPropertyNames.in doesn't exist, but CSSPropertyNames.in does.
3805
3806 2013-05-18  Patrick Gansterer  <paroga@webkit.org>
3807
3808         [CMake] Replace *_LIBRARY_NAME with *_OUTPUT_NAME
3809         https://bugs.webkit.org/show_bug.cgi?id=114554
3810
3811         Reviewed by Gyuyoung Kim.
3812
3813         Using variables as target names is very uncommon in CMake.
3814         The usual way to specify the name of the resulting binary
3815         is to set the OUTPUT_NAME target property.
3816
3817         * DumpRenderTree/efl/CMakeLists.txt:
3818         * EWebLauncher/CMakeLists.txt:
3819         * ImageDiff/CMakeLists.txt:
3820         * MiniBrowser/efl/CMakeLists.txt:
3821         * TestWebKitAPI/CMakeLists.txt:
3822         * WebKitTestRunner/CMakeLists.txt:
3823         * WebKitTestRunner/PlatformEfl.cmake:
3824         * WinCELauncher/CMakeLists.txt:
3825
3826 2013-05-18  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3827
3828         Unreviewed EFL build fix.
3829
3830         Temporarily disabled INDEXED_DATABASE at compile-time as it breaks
3831         WK2 build after r150305.
3832
3833         * Scripts/webkitperl/FeatureList.pm:
3834
3835 2013-05-18  Alberto Garcia  <agarcia@igalia.com>
3836
3837         [GTK] Parallel build fails if gtk-doc is enabled
3838         https://bugs.webkit.org/show_bug.cgi?id=116227
3839
3840         Reviewed by Martin Robinson.
3841
3842         * GNUmakefile.am:
3843         Don't use the 'all' target to generate the documentation.
3844         The prerequisites of this target must be files that need to be
3845         built _before_ the actual compilation of WebKit starts. Since the
3846         documentation depends on WebKit being built first, this means in
3847         practice that the code will be built in parallel with the
3848         generation of its dependencies, potentially making the build fail.
3849
3850 2013-05-17  Ryosuke Niwa  <rniwa@webkit.org>
3851
3852         Don't run hg.
3853
3854         * Scripts/webkitpy/w3c/test_importer_unittest.py:
3855         (TestImporterTest):
3856
3857 2013-05-17  Dirk Pranke  <dpranke@chromium.org>
3858
3859         Create a script to import W3C tests
3860         https://bugs.webkit.org/show_bug.cgi?id=111513
3861
3862         Reviewed by Ryosuke Niwa.
3863
3864         This patch attempts to re-land the 'import-w3c-tests'
3865         script and accompanying modules.  The tests and code have
3866         been cleaned up so that we do not log anything to stdout/stderr
3867         while running the tests (thanks to outputcapture) and do not
3868         write into the source tree while running the tests, and much
3869         but not all of the code has been converted over to using the webkitpy
3870
3871         * Scripts/import-w3c-tests: Added.
3872         * Scripts/webkitpy/w3c/__init__.py: Added.
3873         * Scripts/webkitpy/w3c/test_converter.py: Added.
3874         (W3CTestConverter):
3875         (W3CTestConverter.__init__):
3876         (W3CTestConverter.path_from_webkit_root):
3877         (W3CTestConverter.read_webkit_prefixed_css_property_list):
3878         (W3CTestConverter.convert_for_webkit):
3879         (W3CTestConverter.convert_css):
3880         (W3CTestConverter.convert_html):
3881         (W3CTestConverter.convert_testharness_paths):
3882         (W3CTestConverter.convert_prefixed_properties):
3883         (W3CTestConverter.add_webkit_prefix_to_unprefixed_properties):
3884         (W3CTestConverter.replace_tag):
3885         * Scripts/webkitpy/w3c/test_converter_unittest.py: Added.
3886         (W3CTestConverterTest):
3887         (W3CTestConverterTest.fake_dir_path):
3888         (W3CTestConverterTest.test_read_prefixed_property_list):
3889         (W3CTestConverterTest.test_convert_for_webkit_nothing_to_convert):
3890         (test_convert_for_webkit_harness_only):
3891         (test_convert_for_webkit_properties_only):
3892         (test_convert_for_webkit_harness_and_properties):
3893         (test_convert_test_harness_paths):
3894         (test_convert_prefixed_properties):
3895         (verify_conversion_happened):
3896         (verify_no_conversion_happened):
3897         (verify_test_harness_paths):
3898         (verify_prefixed_properties):
3899         (generate_test_content):
3900         * Scripts/webkitpy/w3c/test_importer.py: Added.
3901         (main):
3902         (parse_args):
3903         (validate_import_directory):
3904         (TestImporter):
3905         (TestImporter.__init__):
3906         (TestImporter.path_from_webkit_root):
3907         (TestImporter.do_import):
3908         (TestImporter.load_changeset):
3909         (TestImporter.find_importable_tests):
3910         (TestImporter.import_tests):
3911         (TestImporter.setup_destination_directory):
3912         (TestImporter.update_test_status):
3913         (TestImporter.remove_deleted_files):
3914         (TestImporter.write_import_log):
3915         * Scripts/webkitpy/w3c/test_importer_unittest.py: Added.
3916         (TestImporterTest):
3917         (TestImporterTest.test_import_dir_with_no_tests):
3918         * Scripts/webkitpy/w3c/test_parser.py: Added.
3919         (TestParser):
3920         (TestParser.__init__):
3921         (TestParser.load_file):
3922         (TestParser.analyze_test):
3923         (TestParser.reference_links_of_type):
3924         (TestParser.is_jstest):
3925         (TestParser.support_files):
3926         * Scripts/webkitpy/w3c/test_parser_unittest.py: Added.
3927         (TestParserTest):
3928         (TestParserTest.test_analyze_test_reftest_one_match):
3929         (test_analyze_test_reftest_multiple_matches):
3930         (test_analyze_test_reftest_match_and_mismatch):
3931         (test_analyze_test_reftest_with_ref_support_Files):
3932         (test_analyze_jstest):
3933         (test_analyze_pixel_test_all_true):
3934         (test_analyze_pixel_test_all_false):
3935         (test_analyze_non_html_file):
3936
3937 2013-05-17  Ryosuke Niwa  <rniwa@webkit.org>
3938
3939         Leaks builders exit early frequently
3940         https://bugs.webkit.org/show_bug.cgi?id=116355
3941
3942         Reviewed by Stephanie Lewis.
3943
3944         Throttle the number of processes to use, and also bump up the number of crashes/timeouts
3945         we tolerate from 20 to 50.
3946
3947         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3948         (RunWebKitTests.start):
3949         * Scripts/webkitpy/port/mac.py:
3950         (MacPort.default_child_processes):
3951
3952 2013-05-17  Peter Gal  <galpeter@inf.u-szeged.hu>
3953
3954         Remove chrome-channels command from the webkit-patch
3955         https://bugs.webkit.org/show_bug.cgi?id=116303
3956
3957         Reviewed by Ryosuke Niwa.
3958
3959         * Scripts/webkitpy/common/config/urls.py: Removed omahaproxy url.
3960         * Scripts/webkitpy/common/net/omahaproxy.py: Removed.
3961         * Scripts/webkitpy/common/net/omahaproxy_unittest.py: Removed.
3962         * Scripts/webkitpy/tool/commands/__init__.py: Removed chromechannels import.
3963         * Scripts/webkitpy/tool/commands/chromechannels.py: Removed.
3964         * Scripts/webkitpy/tool/commands/chromechannels_unittest.py: Removed.
3965
3966 2013-05-17  David Kilzer  <ddkilzer@apple.com>
3967
3968         filter-build-webkit: Don't filter out the location of the missing symbol when linking fails
3969         Part 3 of 3: <http://webkit.org/b/116247>
3970
3971         Reviewed by Benjamin Poulain.
3972
3973         * Scripts/filter-build-webkit: Change while() loop to for() loop
3974         to track $previousLine, then pass $previousLine into
3975         shouldIgnoreLine().
3976         (shouldIgnoreLine): Add $previousLine argument. Do not skip a
3977         line that begins with four spaces if the previous line is a
3978         linker error message.
3979         * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl:
3980         - Add "Ignored: " to test descriptions to document expected
3981           behavior.
3982         - Add comment blocks for various groups of tests.
3983         - Expand "Build settings" tests since we're changing the code in
3984           shouldIgnoreLine() that ignores those lines.
3985         - Add tests for undefined symbols error message.
3986         (description): Add.  Extract from global code.
3987
3988 2013-05-17  David Kilzer  <ddkilzer@apple.com>
3989
3990         Add tests for shouldIgnoreLine() in filter-build-webkit
3991         Part 2 of 3: <http://webkit.org/b/116247>
3992
3993         Reviewed by Benjamin Poulain.
3994
3995         * Scripts/filter-build-webkit:
3996         (shouldIgnoreLine): Add.  Extract code from global scope into
3997         subroutine to make it testable.
3998         * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl: Add.
3999         Tests shouldIgnoreLine() using output from a real build
4000         transcript.
4001
4002 2013-05-17  Ryosuke Niwa  <rniwa@webkit.org>
4003
4004         Rename "WebKit Queues" to explicitly call out for EWS and CQ on build.webkit.org
4005         https://bugs.webkit.org/show_bug.cgi?id=116341
4006
4007         Reviewed by Brady Eidson.
4008
4009         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
4010
4011 2013-05-17  Brent Fulgham  <bfulgham@apple.com>
4012
4013         [Windows] Don't use pdevenv when building with VS2010.
4014         https://bugs.webkit.org/show_bug.cgi?id=116338.
4015
4016         Reviewed by Adam Roben.
4017
4018         * Scripts/webkitdirs.pm:
4019         (setupCygwinEnv): Check if we are using VS2005, and only use
4020         the 'pdevenv' hack if we are. Otherwise, just build with
4021         our standard project since it uses VS2010+'s native
4022         parallel building features.
4023
4024 2013-05-17  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
4025
4026         Unreviewed. Disable accelerated compositing until we figure out why it does not work
4027         properly in the 64 bits release bot.
4028
4029         * DumpRenderTree/gtk/DumpRenderTree.cpp:
4030         (resetDefaultsToConsistentValues):
4031
4032 2013-05-17  David Kilzer  <ddkilzer@apple.com>
4033
4034         Make filter-build-webkit testable using LoadAsModule
4035         Part 1 of 3: <http://webkit.org/b/116247>
4036
4037         Reviewed by Benjamin Poulain.
4038
4039         * Scripts/filter-build-webkit: Change global variables that are
4040         used in subroutines from 'my' to 'our' to make it possible to
4041         evaluate the script in a package context in LoadAsModule.pm.
4042
4043 2013-05-14  Sam Weinig  <sam@webkit.org>
4044
4045         Add variants of the loading APIs that take user data and a way for the injected bundle to find out about them
4046         https://bugs.webkit.org/show_bug.cgi?id=116132
4047
4048         Reviewed by Anders Carlsson.
4049
4050         Adds "WithUserData" versions of all the load APIs and two new WKBundlePageLoaderClient functions,
4051         willLoadURLRequest and willLoadDataRequest to let the bundle access them.
4052
4053         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4054         * TestWebKitAPI/Tests/WebKit2/WillLoad.cpp: Added.
4055         * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp: Added.
4056         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4057
4058 2013-05-16  Seokju Kwon  <seokju.kwon@gmail.com>
4059
4060         [EFL] inspector-protocol/page/javascriptDialogEvents.html is failing
4061         https://bugs.webkit.org/show_bug.cgi?id=114781
4062
4063         Reviewed by Christophe Dumez.
4064
4065         Add run_before_unload_confirm and
4066         Print the log message with "CONFIRM NAVIGATION: " in console.
4067
4068         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
4069         (onBeforeUnloadConfirm):
4070         (drtViewAdd):
4071
4072 2013-05-16  Peter Gal  <galpeter@inf.u-szeged.hu>
4073
4074         Fix Analyze ChangeLog's entry processing
4075         https://bugs.webkit.org/show_bug.cgi?id=116219
4076
4077         Reviewed by Ryosuke Niwa.
4078
4079         * Scripts/webkitpy/tool/commands/analyzechangelog.py:
4080         (ChangeLogAnalyzer._analyze_entries): Fix the counter initialization.
4081
4082 2013-05-16  Hyungchan Kim  <hyungchan2.kim@lge.com>
4083
4084         [Qt] UrlLoader::loadNext is broken in MiniBrowser
4085         https://bugs.webkit.org/show_bug.cgi?id=116099
4086
4087         Reviewed by Jocelyn Turcotte.
4088
4089         QQuickWebView's 3 signals(loadStarted, loadSucceeded, loadFailed)
4090         are not available any more. So, UrlLoader::loadNext was broken
4091         because it failed to connect to those signals.
4092
4093         * MiniBrowser/qt/UrlLoader.cpp:
4094         (UrlLoader::UrlLoader):
4095         (UrlLoader::loadingChanged):
4096         * MiniBrowser/qt/UrlLoader.h:
4097         (UrlLoader):
4098
4099 2013-05-16  Lamarque V. Souza  <Lamarque.Souza@basyskom.com>
4100
4101         [WebSocket] Update pywebsocket to r760
4102         https://bugs.webkit.org/show_bug.cgi?id=115863
4103
4104         Reviewed by Alexey Proskuryakov.
4105
4106         Version r760 supports a newer draft of message compression.
4107         We need this update to finish the permessage compression patch in
4108         bug 98840. This patch also fixes failing unit tests after the update.
4109
4110         * Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_base.py:
4111         (StreamBase._read):
4112         (StreamBase._read.of):
4113         (StreamBase._write):
4114         (StreamBase.receive_bytes):
4115         (StreamBase._read_until):
4116         * Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_hybi.py:
4117         (parse_frame):
4118         (StreamOptions.__init__):
4119         (Stream.__init__):
4120         (Stream._receive_frame_as_frame_object):
4121         (Stream._get_message_from_frame):
4122         (Stream._process_close_message):
4123         (Stream.close_connection):
4124         (Stream.get_last_received_opcode):
4125         * Scripts/webkitpy/thirdparty/mod_pywebsocket/common.py:
4126         * Scripts/webkitpy/thirdparty/mod_pywebsocket/dispatch.py:
4127         (Dispatcher.do_extra_handshake):
4128         (Dispatcher.transfer_data):
4129         * Scripts/webkitpy/thirdparty/mod_pywebsocket/extensions.py:
4130         (ExtensionProcessorInterface.__init__):
4131         (ExtensionProcessorInterface.request):
4132         (ExtensionProcessorInterface):
4133         (ExtensionProcessorInterface.name):
4134         (ExtensionProcessorInterface.check_consistency_with_other_processors):
4135         (ExtensionProcessorInterface.set_active):
4136         (ExtensionProcessorInterface.is_active):
4137         (ExtensionProcessorInterface._get_extension_response_internal):
4138         (ExtensionProcessorInterface.get_extension_response):
4139         (ExtensionProcessorInterface._setup_stream_options_internal):
4140         (ExtensionProcessorInterface.setup_stream_options):
4141         (_log_outgoing_compression_ratio):
4142         (_log_incoming_compression_ratio):
4143         (_parse_window_bits):
4144         (_AverageRatioCalculator):
4145         (_AverageRatioCalculator.__init__):
4146         (_AverageRatioCalculator.add_original_bytes):
4147         (_AverageRatioCalculator.add_result_bytes):
4148         (_AverageRatioCalculator.get_average_ratio):
4149         (DeflateFrameExtensionProcessor):
4150         (DeflateFrameExtensionProcessor.__init__):
4151         (DeflateFrameExtensionProcessor._get_extension_response_internal):
4152         (DeflateFrameExtensionProcessor._setup_stream_options_internal):
4153         (DeflateFrameExtensionProcessor._outgoing_filter):
4154         (DeflateFrameExtensionProcessor._incoming_filter):
4155         (CompressionExtensionProcessorBase.for):
4156         (CompressionExtensionProcessorBase.__init__):
4157         (CompressionExtensionProcessorBase._get_extension_response_internal):
4158         (CompressionExtensionProcessorBase._setup_stream_options_internal):
4159         (PerFrameCompressExtensionProcessor):
4160         (PerMessageDeflateExtensionProcessor):
4161         (PerMessageDeflateExtensionProcessor.__init__):
4162         (PerMessageDeflateExtensionProcessor._get_extension_response_internal):
4163         (PerMessageDeflateExtensionProcessor._setup_stream_options_internal):
4164         (PerMessageDeflateExtensionProcessor.set_c2s_max_window_bits):
4165         (PerMessageDeflateExtensionProcessor.set_c2s_max_window_bits.adds):
4166         (PerMessageDeflateExtensionProcessor.set_c2s_no_context_takeover):
4167         (PerMessageDeflateExtensionProcessor.set_c2s_no_context_takeover.adds):
4168         (PerMessageDeflateExtensionProcessor.set_bfinal):
4169         (PerMessageDeflateExtensionProcessor.enable_outgoing_compression):
4170         (PerMessageDeflateExtensionProcessor.disable_outgoing_compression):
4171         (_PerMessageDeflateFramer):
4172         (_PerMessageDeflateFramer.__init__):
4173         (_PerMessageDeflateFramer.set_compress_outgoing_enabled):
4174         (_PerMessageDeflateFramer._process_incoming_message):
4175         (_PerMessageDeflateFramer._process_outgoing_message):
4176         (_PerMessageDeflateFramer.setup_stream_options):
4177         (_PerMessageDeflateFramer.setup_stream_options._OutgoingMessageFilter):
4178         (_PerMessageDeflateFramer.setup_stream_options._OutgoingMessageFilter.__init__):
4179         (_PerMessageDeflateFramer.setup_stream_options._OutgoingMessageFilter.filter):
4180         (_PerMessageDeflateFramer.setup_stream_options._IncomingMessageFilter):
4181         (_PerMessageDeflateFramer.setup_stream_options._IncomingMessageFilter.__init__):
4182         (_PerMessageDeflateFramer.setup_stream_options._IncomingMessageFilter.decompress_next_message):
4183         (_PerMessageDeflateFramer.setup_stream_options._IncomingMessageFilter.filter):
4184         (_PerMessageDeflateFramer.setup_stream_options._OutgoingFrameFilter):
4185         (_PerMessageDeflateFramer.setup_stream_options._OutgoingFrameFilter.__init__):
4186         (_PerMessageDeflateFramer.setup_stream_options._OutgoingFrameFilter.set_compression_bit):
4187         (_PerMessageDeflateFramer.setup_stream_options._OutgoingFrameFilter.filter):
4188         (_PerMessageDeflateFramer.setup_stream_options._IncomingFrameFilter):
4189         (_PerMessageDeflateFramer.setup_stream_options._IncomingFrameFilter.__init__):
4190         (_PerMessageDeflateFramer.setup_stream_options._IncomingFrameFilter.filter):
4191         (PerMessageCompressExtensionProcessor):
4192         (PerMessageCompressExtensionProcessor._lookup_compression_processor):
4193         (MuxExtensionProcessor.__init__):
4194         (MuxExtensionProcessor.check_consistency_with_other_processors):
4195         (MuxExtensionProcessor):
4196         (MuxExtensionProcessor._get_extension_response_internal):
4197         (MuxExtensionProcessor._setup_stream_options_internal):
4198         (MuxExtensionProcessor.set_quota):
4199         (MuxExtensionProcessor.quota):
4200         (MuxExtensionProcessor.set_extensions):
4201         (MuxExtensionProcessor.extensions):
4202         (is_compression_extension):
4203         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/_base.py:
4204         (validate_subprotocol):
4205         (parse_host_header):
4206         (format_header):
4207         (check_request_line):
4208         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/hybi.py:
4209         (Handshaker.do_handshake):
4210         (Handshaker._create_handshake_response):
4211         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/hybi00.py:
4212         (_validate_subprotocol):
4213         (_check_header_lines):
4214         (_build_location):
4215         (Handshaker.do_handshake):
4216         (Handshaker._set_subprotocol):
4217         (Handshaker._set_location):
4218         * Scripts/webkitpy/thirdparty/mod_pywebsocket/headerparserhandler.py:
4219         (_create_dispatcher):
4220         (headerparserhandler):
4221         * Scripts/webkitpy/thirdparty/mod_pywebsocket/mux.py:
4222         (_create_add_channel_response):
4223         (_create_drop_channel):
4224         (_create_flow_control):
4225         (_create_new_channel_slot):
4226         (_create_fallback_new_channel_slot):
4227         (_MuxFramePayloadParser._read_number):
4228         (_MuxFramePayloadParser._read_size_and_contents):
4229         (_MuxFramePayloadParser._read_flow_control):
4230         (_MuxFramePayloadParser._read_new_channel_slot):
4231         (_LogicalConnection.__init__):
4232         (_LogicalConnection.write):
4233         (_LogicalConnection.on_write_data_done):
4234         (_LogicalConnection):
4235         (_LogicalConnection.on_writer_done):
4236         (_InnerMessage):
4237         (_InnerMessage.__init__):
4238         (_InnerMessageBuilder):
4239         (_InnerMessageBuilder.that):
4240         (_InnerMessageBuilder.__init__):
4241         (_InnerMessageBuilder._handle_first):
4242         (_InnerMessageBuilder._process_first_fragmented_control):
4243         (_InnerMessageBuilder._process_first_fragmented_message):
4244         (_InnerMessageBuilder._handle_fragmented_control):
4245         (_InnerMessageBuilder._reassemble_fragmented_control):
4246         (_InnerMessageBuilder._handle_fragmented_message):
4247         (_InnerMessageBuilder._reassemble_fragmented_message):
4248         (_InnerMessageBuilder.build):
4249         (_LogicalStream.__init__):
4250         (_LogicalStream._create_inner_frame):
4251         (_LogicalStream._write_inner_frame):
4252         (_LogicalStream.replenish_send_quota):
4253         (_LogicalStream.send_message):
4254         (_LogicalStream._receive_frame):
4255         (_LogicalStream._get_message_from_frame):
4256         (_LogicalStream.stop_sending):
4257         (_PhysicalConnectionWriter.__init__):
4258         (_PhysicalConnectionWriter._write_data):
4259         (_PhysicalConnectionWriter.run):
4260         (_PhysicalConnectionWriter.stop):
4261         (_Worker.run):
4262         (_MuxHandshaker.__init__):
4263         (_MuxHandshaker._create_stream):
4264         (_MuxHandshaker._create_handshake_response):
4265         (_HandshakeDeltaBase.create_headers):
4266         (_MuxHandler.start):
4267         (_MuxHandler.wait_until_done):
4268         (_MuxHandler.notify_write_data_done):
4269         (_MuxHandler._process_drop_channel):
4270         (_MuxHandler._process_logical_frame):
4271         (_MuxHandler.notify_reader_done):
4272         (_MuxHandler):
4273         (_MuxHandler.notify_writer_done):
4274         (_MuxHandler.fail_physical_connection):
4275         (_MuxHandler.fail_logical_channel):
4276         (use_mux):
4277         * Scripts/webkitpy/thirdparty/mod_pywebsocket/standalone.py:
4278         (_StandaloneRequest.get_uri):
4279         (_StandaloneRequest.get_unparsed_uri):
4280         (_StandaloneRequest):
4281         (_StandaloneRequest.is_https):
4282         (_import_ssl):
4283         (_import_pyopenssl):
4284         (_StandaloneSSLConnection.for):
4285         (_StandaloneSSLConnection):
4286         (_StandaloneSSLConnection.__getattribute__):
4287         (_StandaloneSSLConnection.__setattr__):
4288         (_StandaloneSSLConnection.makefile):
4289         (_StandaloneSSLConnection.shutdown):
4290         (_StandaloneSSLConnection.recv):
4291         (WebSocketServer.__init__):
4292         (WebSocketServer._create_sockets):
4293         (WebSocketServer.handle_error):
4294         (WebSocketServer.get_request):
4295         (WebSocketServer.get_request.default_callback):
4296         (WebSocketRequestHandler.parse_request):
4297         (_build_option_parser):
4298         (_main):
4299         (_main.if):
4300         * Scripts/webkitpy/thirdparty/mod_pywebsocket/util.py:
4301         (RepeatedXorMasker.__init__):
4302         (RepeatedXorMasker._mask_using_swig):
4303         (RepeatedXorMasker):
4304         (RepeatedXorMasker._mask_using_array):
4305         (_Deflater.compress_and_finish):
4306         (_RFC1979Deflater.filter):
4307         (DeflateSocket.send):
4308
4309 2013-05-16  Jonathan Liu  <net147@gmail.com>
4310
4311         Fix testing if program exists in PATH
4312         https://bugs.webkit.org/show_bug.cgi?id=116216
4313
4314         Reviewed by Jocelyn Turcotte.
4315
4316         functions.prf incorrectly uses win_cmd_shell to test whether to
4317         add .exe to the executable name when checking if it exists in
4318         the PATH environment variable. This works correctly when
4319         building using Windows Command Prompt but not under MSYS shell.
4320
4321         To resolve this, check the win32 platform scope instead of
4322         win_cmd_shell so that it correctly adds .exe to the executable
4323         name on Windows regardless of the shell used when testing if
4324         it exists in PATH.
4325
4326         * qmake/mkspecs/features/functions.prf:
4327
4328 2013-05-16  Ryosuke Niwa  <rniwa@webkit.org>
4329
4330         Fix the hard-coded names of EWS bots that run tests.
4331
4332         * Scripts/webkitpy/tool/commands/queues.py:
4333         (CommitQueue.did_pass_testing_ews):
4334
4335 2013-05-16  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
4336
4337         [GTK] Build Xvfb with jhbuild
4338         https://bugs.webkit.org/show_bug.cgi?id=115907
4339
4340         Reviewed by Martin Robinson.
4341
4342         Build our own Xvfb so that we can avoid problems with the system Xvfb
4343         relying on symbols not present in our jhbuilt libraries such as pixman,
4344         and also to ensure we have the fix for a GLX module crasher.
4345
4346         * DumpRenderTree/gtk/DumpRenderTree.cpp:
4347         (resetDefaultsToConsistentValues): enable accelerated compositing.
4348         * gtk/install-dependencies: list packages required for building Xvfb.