Allow NSFileCoordinator to be called from WebContent process
[WebKit-https.git] / Tools / ChangeLog
1 2019-05-15  Alex Christensen  <achristensen@webkit.org>
2
3         Allow NSFileCoordinator to be called from WebContent process
4         https://bugs.webkit.org/show_bug.cgi?id=197895
5         <rdar://problem/50107679>
6
7         Reviewed by Brent Fulgham.
8
9         Add a unit test that verifies calling the block succeeds.
10
11         * TestWebKitAPI/Tests/WebKitCocoa/AdditionalReadAccessAllowedURLsPlugin.mm:
12         (-[AdditionalReadAccessAllowedURLsPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
13
14 2019-05-14  Andy Estes  <aestes@apple.com>
15
16         [Apple Pay] Payment APIs should be completely disabled in web views into which clients have injected user scripts
17         https://bugs.webkit.org/show_bug.cgi?id=197751
18         <rdar://problem/50631563>
19
20         Reviewed by Alex Christensen.
21
22         Added new API tests.
23
24         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm:
25         (-[TestApplePayScriptMessageHandler initWithAPIsAvailableExpectation:canMakePaymentsExpectation:]):
26         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
27         (TestWebKitAPI::TEST):
28         (-[TestApplePayScriptMessageHandler initWithExpectation:]): Deleted.
29         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html:
30
31 2019-05-14  Youenn Fablet  <youenn@apple.com>
32
33         A service worker process should app nap when all its clients app nap
34         https://bugs.webkit.org/show_bug.cgi?id=185626
35         <rdar://problem/46785908>
36
37         Reviewed by Alex Christensen.
38
39         Allow to enable app nap through test header.
40
41         * WebKitTestRunner/TestController.cpp:
42         (WTR::TestController::resetPreferencesToConsistentValues):
43         (WTR::updateTestOptionsFromTestHeader):
44         * WebKitTestRunner/TestOptions.h:
45         (WTR::TestOptions::hasSameInitializationOptions const):
46
47 2019-05-14  Commit Queue  <commit-queue@webkit.org>
48
49         Unreviewed, rolling out r245281.
50         https://bugs.webkit.org/show_bug.cgi?id=197887
51
52         Broke API Test TestWebKitAPI.Challenge.ClientCertificate
53         (Requested by aakashjain on #webkit).
54
55         Reverted changeset:
56
57         "Add a unit test for client certificate authentication"
58         https://bugs.webkit.org/show_bug.cgi?id=197800
59         https://trac.webkit.org/changeset/245281
60
61 2019-05-14  Youenn Fablet  <youenn@apple.com>
62
63         Add support for webkit-test-runner options to WPT importer
64         https://bugs.webkit.org/show_bug.cgi?id=197826
65
66         Reviewed by Alex Christensen.
67
68         In case of overwriting an existing test, check if the existing test
69         contains a <!-- webkit-test-runner --> comment and insert it back if
70         needed in the new test.
71
72         For exporter, forbid creating a WPT PR if there are changes containing
73         the webkit-test-runner string.
74
75         * Scripts/webkitpy/w3c/test_converter.py:
76         (convert_for_webkit):
77         (_W3CTestConverter.__init__):
78         (_W3CTestConverter.add_webkit_test_runner_options_if_needed):
79         (_W3CTestConverter.handle_starttag):
80         (_W3CTestConverter.handle_comment):
81         (_W3CTestConverter.handle_decl):
82         (_W3CTestConverter.handle_pi):
83         * Scripts/webkitpy/w3c/test_exporter.py:
84         (WebPlatformTestExporter.write_git_patch_file):
85         (WebPlatformTestExporter.make_pull_request):
86         * Scripts/webkitpy/w3c/test_importer.py:
87         (TestImporter.webkit_test_runner_options):
88         (TestImporter):
89         (TestImporter.add_webkit_test_runner_options_to_content):
90         (TestImporter.copy_html_file):
91         (TestImporter.write_html_template):
92         (TestImporter.write_html_files_for_templated_js_tests):
93         (TestImporter.import_tests):
94         * Scripts/webkitpy/w3c/test_importer_unittest.py:
95         (test_manual_slow_test):
96         (test_webkit_test_runner_options):
97
98 2019-05-14  Aakash Jain  <aakash_jain@apple.com>
99
100         [ews-app] Status bubble should turn orange when any build step fails
101         https://bugs.webkit.org/show_bug.cgi?id=197812
102
103         Reviewed by Jonathan Bedard.
104
105         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
106         (StatusBubble._build_bubble): Turn status-bubble orange if there is any failed step in the on-going build.
107         (StatusBubble._does_build_contains_any_failed_step): Method to check if build contains any failed step.
108
109 2019-05-14  Alex Christensen  <achristensen@webkit.org>
110
111         Add a unit test for client certificate authentication
112         https://bugs.webkit.org/show_bug.cgi?id=197800
113
114         Reviewed by Youenn Fablet.
115
116         Make better abstractions for reading and writing from/to TCPServer.
117         Add a unit test that causes a client certificate authentication challenge to happen.
118
119         * TestWebKitAPI/TCPServer.cpp:
120         (TestWebKitAPI::TCPServer::TCPServer):
121         (TestWebKitAPI::TCPServer::read):
122         (TestWebKitAPI::TCPServer::write):
123         (TestWebKitAPI::TCPServer::respondWithChallengeThenOK):
124         (TestWebKitAPI::TCPServer::respondWithOK):
125         * TestWebKitAPI/TCPServer.h:
126         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
127         (credentialWithIdentity):
128         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
129         (TEST):
130         (-[ClientCertificateDelegate webView:didFinishNavigation:]):
131         (-[ClientCertificateDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
132         (-[ClientCertificateDelegate challengeCount]):
133         (TestWebKitAPI::TEST):
134         (respondWithChallengeThenOK): Deleted.
135         (credentialWithIdentityAndKeychainPath): Deleted.
136         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
137         (TEST):
138         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:
139         (TestWebKitAPI::TEST):
140         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
141         (TEST):
142         (readRequest): Deleted.
143         (writeResponse): Deleted.
144         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
145         (TestWebKitAPI::TEST):
146         (TestWebKitAPI::respondWithChallengeThenOK): Deleted.
147
148 2019-05-14  Said Abou-Hallawa  <sabouhallawa@apple.com>
149
150         [CG] Adding support for HEIF-sequence ('public.heics') images
151         https://bugs.webkit.org/show_bug.cgi?id=197384
152
153         Reviewed by Simon Fraser.
154
155         * DumpRenderTree/TestOptions.cpp:
156         (TestOptions::TestOptions):
157         * DumpRenderTree/TestOptions.h:
158         * DumpRenderTree/mac/DumpRenderTree.mm:
159         (resetWebViewToConsistentStateBeforeTesting):
160         Parse the new webkit-test-runner paramter: additionalSupportedImageTypes.
161         Make DRT call setAdditionalSupportedImageTypesForTesting() before starting
162         the test.
163
164         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
165         (WTR::InjectedBundle::stringForKey):
166         (WTR::InjectedBundle::beginTesting):
167         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
168         * WebKitTestRunner/TestController.cpp:
169         (WTR::TestController::resetStateToConsistentValues):
170         (WTR::updateTestOptionsFromTestHeader):
171         * WebKitTestRunner/TestInvocation.cpp:
172         (WTR::TestInvocation::createTestSettingsDictionary):
173         * WebKitTestRunner/TestOptions.h:
174         (WTR::TestOptions::hasSameInitializationOptions const):
175         Parse the new webkit-test-runner paramter: additionalSupportedImageTypes.
176         Make WTR call setAdditionalSupportedImageTypesForTesting() before starting
177         the test.
178
179 2019-05-12  Yusuke Suzuki  <ysuzuki@apple.com>
180
181         [JSC] Compress Watchpoint size by using enum type and Packed<> data structure
182         https://bugs.webkit.org/show_bug.cgi?id=197730
183
184         Reviewed by Filip Pizlo.
185
186         * TestWebKitAPI/CMakeLists.txt:
187         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
188         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
189         (TestWebKitAPI::TEST):
190         * TestWebKitAPI/Tests/WTF/Packed.cpp: Added.
191         (TestWebKitAPI::TEST):
192
193 2019-05-10  Chris Dumez  <cdumez@apple.com>
194
195         Unreviewed, fix ProcessSwap.OpenerLinkAfterAPIControlledProcessSwappingOfOpener API test
196
197         It became flaky after r245198.
198
199         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
200
201 2019-05-10  Youenn Fablet  <youenn@apple.com>
202
203         A service worker instance should be terminated when its SWServer is destroyed
204         https://bugs.webkit.org/show_bug.cgi?id=197801
205         <rdar://problem/50587270>
206
207         Reviewed by Chris Dumez.
208
209         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
210
211 2019-05-10  Chris Dumez  <cdumez@apple.com>
212
213         Do not wait until requestPermission() is called to fire deviceorientation events if permission was already granted
214         https://bugs.webkit.org/show_bug.cgi?id=197750
215
216         Reviewed by Geoffrey Garen.
217
218         Add API test coverage.
219
220         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:
221         (TEST):
222
223 2019-05-10  Keith Miller  <keith_miller@apple.com>
224
225         Remove legacy test262 import script
226         https://bugs.webkit.org/show_bug.cgi?id=197788
227
228         Reviewed by Yusuke Suzuki.
229
230         import-test262-tests doesn't work anymore. We should be using test262-import instead.
231
232         * Scripts/import-test262-tests: Removed.
233
234 2019-05-10  Charlie Turner  <cturner@igalia.com>
235
236         [WPE] Forward libepoxy cflags
237         https://bugs.webkit.org/show_bug.cgi?id=197784
238
239         Reviewed by Žan Doberšek.
240
241         Patch by Zan Dobersek.
242
243         * wpe/backends/CMakeLists.txt: This is required to keep
244         -DMESA_EGL_NO_X11_HEADERS in the build, if we don't do this, EGL ends
245         up trying to include X11 headers even when they're not present in the
246         environment.
247
248 2019-05-10  Michael Catanzaro  <mcatanzaro@igalia.com>
249
250         Fix a bunch of compiler warnings
251         https://bugs.webkit.org/show_bug.cgi?id=197785
252
253         Reviewed by Don Olmstead.
254
255         Add preprocessor guards to avoid -Wunused-function warnings.
256
257         * TestWebKitAPI/Tests/WebCore/FloatRect.cpp:
258         * TestWebKitAPI/Tests/WebCore/IntRect.cpp:
259         * TestWebKitAPI/Tests/WebCore/TransformationMatrix.cpp:
260
261 2019-05-10  Michael Catanzaro  <mcatanzaro@igalia.com>
262
263         [WPE][GTK] Add webkit_frame_get_id() API
264         https://bugs.webkit.org/show_bug.cgi?id=197270
265
266         Reviewed by Carlos Garcia Campos.
267
268         This was hard, but I added a test to verify that two different WebKitFrames of the same
269         WebKitWebPage return two different frame IDs.
270
271         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp:
272         (WebKitFrameTest::willSubmitFormCallback):
273         (WebKitFrameTest::testSubframe):
274         (registerTests):
275         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp:
276         (testWebKitFrameSubframe):
277         (beforeAll):
278         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
279         (willSubmitFormCallback):
280         * TestWebKitAPI/Tests/WebKitGLib/resources/form-in-frame.html: Added.
281         * TestWebKitAPI/Tests/WebKitGLib/resources/webkitglib-tests.gresource.xml:
282
283 2019-05-10  Michael Catanzaro  <mcatanzaro@igalia.com>
284
285         [WPE][GTK] Add WebKitWebPage::did-associate-form-controls-for-frame and deprecate original did-associate-form-controls
286         https://bugs.webkit.org/show_bug.cgi?id=197271
287
288         Reviewed by Youenn Fablet.
289
290         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
291         (formControlsAssociatedForFrameCallback):
292         (pageCreatedCallback):
293         (formControlsAssociatedCallback): Deleted.
294
295 2019-05-10  Adrian Perez de Castro  <aperez@igalia.com>
296
297         [Flatpak] Use the safe PyYAML loader if available
298         https://bugs.webkit.org/show_bug.cgi?id=197771
299
300         Reviewed by Philippe Normand.
301
302         * flatpak/flatpakutils.py:
303         (load_manifest): Use yaml.safe_load() if available, with yaml.load()
304         still used as fallback when the former is not provided by the module.
305
306 2019-05-09  Fujii Hironori  <Hironori.Fujii@sony.com>
307
308         WinCairo WebKitTestRunner should take platform/wk2/TestExpectations into account
309         https://bugs.webkit.org/show_bug.cgi?id=197734
310
311         Reviewed by Don Olmstead.
312
313         * Scripts/webkitpy/port/win.py:
314         (WinCairoPort._search_paths): Add 'wk2' and
315         additional_platform_directory to paths as well as other ports do.
316
317 2019-05-09  Daniel Bates  <dabates@apple.com>
318
319         [iOS] Numpad comma key has incorrect keyIdentifier property
320         https://bugs.webkit.org/show_bug.cgi?id=197753
321         <rdar://problem/50636274>
322
323         Reviewed by Brent Fulgham.
324
325         Recognize "numpadComma" and return the appropriate HID usage code.
326
327         * WebKitTestRunner/ios/HIDEventGenerator.mm:
328         (hidUsageCodeForCharacter):
329
330 2019-05-09  Eric Carlson  <eric.carlson@apple.com>
331
332         Refine AudioSession route sharing policy
333         https://bugs.webkit.org/show_bug.cgi?id=197742
334         <rdar://problem/50590818>
335
336         Reviewed by Darin Adler.
337
338         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
339         (TestWebKitAPI::TEST):
340
341 2019-05-09  Alex Christensen  <achristensen@webkit.org>
342
343         Remove unnecessary test SPI after r244883
344         https://bugs.webkit.org/show_bug.cgi?id=197575
345
346         Reviewed by Tim Horton.
347
348         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
349         (TEST):
350         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
351         (TestWebKitAPI::TEST):
352
353 2019-05-09  Aakash Jain  <aakash_jain@apple.com>
354
355         [ews-app] Add migrations file to repository
356         https://bugs.webkit.org/show_bug.cgi?id=197729
357
358         Reviewed by Jonathan Bedard.
359
360         * BuildSlaveSupport/ews-app/ews/migrations/0001_initial.py: Added. Auto-generated by Django based on models' information.
361
362 2019-05-09  Aakash Jain  <aakash_jain@apple.com>
363
364         [ews-build] Fix formatting issues and typos
365         https://bugs.webkit.org/show_bug.cgi?id=197737
366
367         Reviewed by Jonathan Bedard.
368
369         * BuildSlaveSupport/ews-build/steps.py:
370         (CompileWebKit.evaluateCommand): Removed extra empty line.
371         * BuildSlaveSupport/ews-build/steps_unittest.py:
372         (TestRunWebKitPerlTests): Fixed typo.
373         * BuildSlaveSupport/ews-app/ews/models/step.py:
374         (Step.save_step): Changed log level to info so that it is logged in production.
375
376 2019-05-09  Aakash Jain  <aakash_jain@apple.com>
377
378         [ews-app] Production and Development env should configure DEBUG appropriately
379         https://bugs.webkit.org/show_bug.cgi?id=197700
380
381         Reviewed by Jonathan Bedard.
382
383         * BuildSlaveSupport/ews-app/ews-app/settings.py:
384
385 2019-05-09  Xan López  <xan@igalia.com>
386
387         [CMake] Detect SSE2 at compile time
388         https://bugs.webkit.org/show_bug.cgi?id=196488
389
390         Reviewed by Carlos Garcia Campos.
391
392         * Scripts/webkitdirs.pm:
393         (generateBuildSystemFromCMakeProject): Do not add SSE2 flags here
394         for x86 builds. This is now handled in WebKitCompilerFlags.cmake.
395
396 2019-05-08  Adrian Perez de Castro  <aperez@igalia.com>
397
398         [WPE] Update dependencies to use libwpe + WPEBackend-fdo 1.3.0
399         https://bugs.webkit.org/show_bug.cgi?id=197697
400
401         Reviewed by Žan Doberšek.
402
403         * flatpak/org.webkit.WPEModules.yaml: Bump version and update checksums.
404         * wpe/jhbuild.modules: Ditto.
405
406 2019-05-08  Don Olmstead  <don.olmstead@sony.com>
407
408         Update ANGLE
409         https://bugs.webkit.org/show_bug.cgi?id=197676
410
411         Reviewed by Alex Christensen.
412
413         * TestWebKitAPI/PlatformWin.cmake:
414         Remove unnecessary library linkage.
415
416 2019-05-08  Stephan Szabo  <stephan.szabo@sony.com> and Fujii Hironori  <Hironori.Fujii@sony.com>
417
418         [Win] build-webkit should be ready for Visual Studio 2019
419         https://bugs.webkit.org/show_bug.cgi?id=196622
420
421         Reviewed by Ross Kirsling.
422
423         1. Accommodated to the new msbuild.exe location of VS 2019.
424         2. Removed the hard coded "Visual Studio 15" generator.
425
426         build-webkit is going to choose a Visual Studio generator version
427         matching with the latest installed VS. If you invoke vcvars.bat
428         before build-webkit, it chooses the corresponding Visual Studio
429         generator version by cheking 'VisualStudioVersion' env var which
430         is set by vcvars.bat.
431
432         * Scripts/webkitdirs.pm: Renamed $vcBuildPath to $msBuildPath. Removed $msBuildInstallDir.
433         (msBuildPath): When looking for MSBuild, look in
434         "MSBuild\Current\bin" (the new expected location) and fallback
435         to "MSBuild\15.0\bin" if we can't find an MSBuild.exe in the
436         first location.
437         (msBuildInstallDir): Renamed to msBuildPath.
438         (generateBuildSystemFromCMakeProject): Use -A switch to specify x64.
439         Add -G "Visual Studio " switch if a env var 'VisualStudioVersion'
440
441 2019-05-08  Don Olmstead  <don.olmstead@sony.com>
442
443         [PlayStation] Update port options
444         https://bugs.webkit.org/show_bug.cgi?id=197723
445
446         Reviewed by Ross Kirsling.
447
448         ICU headers were missing from TestWTF.
449
450         * TestWebKitAPI/PlatformPlayStation.cmake:
451
452 2019-05-08  Alex Christensen  <achristensen@webkit.org>
453
454         Don't crash when DOMNode.addEventListener:listener:useCapture: is called with a nil listener
455         https://bugs.webkit.org/show_bug.cgi?id=197712
456         <rdar://problem/50429770>
457
458         Reviewed by Tim Horton.
459
460         * TestWebKitAPI/Tests/WebKitLegacy/mac/DeallocWebViewInEventListener.mm:
461         (TestWebKitAPI::TEST):
462
463 2019-05-08  Jonathan Bedard  <jbedard@apple.com>
464
465         Change my status to be a WebKit reviewer.
466
467         * Scripts/webkitpy/common/config/contributors.json:
468
469 2019-05-08  Ryan Haddad  <ryanhaddad@apple.com>
470
471         Unreviewed, rolling out r244952.
472
473         Caused inspector to appear blank.
474
475         Reverted changeset:
476
477         "Web Inspector: Provide UIString descriptions to improve
478         localizations"
479         https://bugs.webkit.org/show_bug.cgi?id=195132
480         https://trac.webkit.org/changeset/244952
481
482 2019-05-08  Wenson Hsieh  <wenson_hsieh@apple.com>
483
484         TestRunnerWKWebView's menu callbacks should be cleared upon UI script completion
485         https://bugs.webkit.org/show_bug.cgi?id=197685
486
487         Reviewed by Alex Christensen.
488
489         Fixes a bug in the test runner wherein didShowMenuCallback and didHideMenuCallback are not reset upon UI script
490         completion. See LayoutTests/ChangeLog for more details.
491
492         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
493         (WTR::UIScriptController::platformClearAllCallbacks):
494
495 2019-05-07  Oriol Brufau  <obrufau@igalia.com>
496
497         Unreviewed. Add myself as a committer.
498
499         * Scripts/webkitpy/common/config/contributors.json:
500
501 2019-05-07  Ryan Haddad  <ryanhaddad@apple.com>
502
503         Unreviewed, rolling out r245038.
504
505         Breaks internal builds.
506
507         Reverted changeset:
508
509         "Add SPI to set a list of hosts to which to send custom header
510         fields cross-origin"
511         https://bugs.webkit.org/show_bug.cgi?id=197397
512         https://trac.webkit.org/changeset/245038
513
514 2019-05-07  Joonghun Park  <pjh0718@gmail.com>
515
516         Unreviewed. Add myself as a committer.
517
518         * Scripts/webkitpy/common/config/contributors.json:
519
520 2019-05-07  Eric Carlson  <eric.carlson@apple.com>
521
522         Define media buffering policy
523         https://bugs.webkit.org/show_bug.cgi?id=196979
524         <rdar://problem/28383861>
525
526         Reviewed by Jer Noble.
527
528         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
529         * TestWebKitAPI/Tests/WebKitCocoa/MediaBufferingPolicy.mm: Added.
530         (waitUntilBufferingPolicyIsEqualTo):
531         (TEST):
532
533 2019-05-07  Alex Christensen  <achristensen@webkit.org>
534
535         Add SPI to set a list of hosts to which to send custom header fields cross-origin
536         https://bugs.webkit.org/show_bug.cgi?id=197397
537
538         Reviewed by Geoff Garen.
539
540         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
541         (TEST):
542         (expectLegacyHeaders):
543         (expectHeaders):
544         (-[CustomHeaderFieldsDelegate webView:decidePolicyForNavigationAction:preferences:decisionHandler:]):
545         (-[CustomHeaderFieldsDelegate webView:startURLSchemeTask:]):
546         (-[CustomHeaderFieldsDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
547
548 2019-05-07  Keith Rollin  <krollin@apple.com>
549
550         Add option to build-webkit to control whether or not XCBuild is used
551         https://bugs.webkit.org/show_bug.cgi?id=197668
552         <rdar://problem/50549728>
553
554         Reviewed by Tim Horton.
555
556         Add --[no-]xcbuild to build-webkit to force the use of XCBuild or not.
557         Also update build-webkit and the makefiles with the foundation for
558         automatically using XCBuild when the conditions allow it. This latter
559         facility is currently turned off until Xcode fully supports building
560         WebKit with XCBuild.
561
562         * Scripts/build-webkit:
563         * Scripts/webkitdirs.pm:
564         (XcodeOptions):
565         (canUseXCBuild):
566
567 2019-05-07  Andy Estes  <aestes@apple.com>
568
569         run-bindings-tests should test global scope constructor generation
570         https://bugs.webkit.org/show_bug.cgi?id=197669
571
572         Reviewed by Alex Christensen.
573
574         * Scripts/webkitpy/bindings/main.py:
575         Updated to specify --testGlobalContextName and --testGlobalScopeConstructorsFile when
576         invoking preprocess-idls.pl.
577
578 2019-05-07  Youenn Fablet  <youenn@apple.com>
579
580         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageDefaultDirectories
581         https://bugs.webkit.org/show_bug.cgi?id=195997
582         <rdar://problem/50509884>
583
584         Reviewed by Chris Dumez.
585
586         Spin test until successful.
587
588         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
589
590 2019-05-07  Adrian Perez de Castro  <aperez@igalia.com>
591
592         [Flatpak] webkit-build fails due to missing GTK2 in build environment
593         https://bugs.webkit.org/show_bug.cgi?id=197352
594
595         Reviewed by Philippe Normand.
596
597         The Flatpak runtimes do not include GTK 2.x anymore, which means that we need
598         to build it ourselves on top in order to be able to build the GTK 2.x plugin
599         process.
600
601         * flatpak/org.webkit.GTK.yaml: Add gtk2 package.
602
603 2019-05-07  Wenson Hsieh  <wenson_hsieh@apple.com>
604
605         [macOS] Avoid crashing the UI process when writing empty data to the pasteboard
606         https://bugs.webkit.org/show_bug.cgi?id=197644
607         <rdar://problem/50526364>
608
609         Reviewed by Tim Horton.
610
611         Add a new API test to exercise a possible scenario where we may crash while writing data to the pasteboard.
612
613         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegate.mm:
614         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
615         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
616         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:pasteboardDataForRange:]):
617
618 2019-05-07  Carlos Garcia Campos  <cgarcia@igalia.com>
619
620         [GTK][WPE] MiniBrowser: load about:blank for new web views in automation mode
621         https://bugs.webkit.org/show_bug.cgi?id=197651
622
623         Reviewed by Žan Doberšek.
624
625         This is required since the process creation was delayed until something is loaded in the view.
626
627         * MiniBrowser/gtk/BrowserWindow.c:
628         (browser_window_get_or_create_web_view_for_automation):
629         * MiniBrowser/wpe/main.cpp:
630         (main):
631
632 2019-05-06  Tim Horton  <timothy_horton@apple.com>
633
634         _overrideViewportWithArguments does not work when called before loading
635         https://bugs.webkit.org/show_bug.cgi?id=197638
636         <rdar://problem/50505111>
637
638         Reviewed by Wenson Hsieh.
639
640         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm:
641         (TEST):
642
643 2019-05-04  Per Arne Vollan  <pvollan@apple.com>
644
645         -[WKWebsiteDataStore removeDataOfTypes:forDataRecords:completionHandler:] doesn't delete _WKWebsiteDataTypeCredentials
646         https://bugs.webkit.org/show_bug.cgi?id=197510
647
648         Reviewed by Alex Christensen.
649
650         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
651         (TestWebKitAPI::TEST):
652
653 2019-05-06  Keith Rollin  <krollin@apple.com>
654
655         Temporarily disable generate-xcfilelists
656         https://bugs.webkit.org/show_bug.cgi?id=197619
657         <rdar://problem/50507392>
658
659         Reviewed by Alex Christensen.
660
661         We need to perform a significant update to the generate-xcfilelist
662         scripts. This work involves coordinated work with another facility. If
663         the work does not occur in tandem, the build will be broken. To avoid
664         this, disable the invoking of the scripts during the transition. The
665         checking will be restored once the new scripts are in place.
666
667         * DumpRenderTree/Scripts/check-xcfilelists.sh:
668         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
669
670 2019-05-04  Alex Christensen  <achristensen@webkit.org>
671
672         Revert r244953 and r244954 because they broke internal builds.
673         https://bugs.webkit.org/show_bug.cgi?id=197534
674
675         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
676         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
677         * DumpRenderTree/mac/DumpRenderTree.mm:
678         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
679         * DumpRenderTree/mac/TestRunnerMac.mm:
680         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
681         * TestWebKitAPI/Tests/WebKitCocoa/CopyURL.mm:
682         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
683         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
684         * TestWebKitAPI/Tests/WebKitCocoa/SystemColors.mm:
685         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
686         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewFindString.mm:
687         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
688         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
689         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
690         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
691         * TestWebKitAPI/Tests/ios/ScrollViewInsetTests.mm:
692         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
693         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
694         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
695         * TestWebKitAPI/cocoa/TestWKWebView.mm:
696         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
697         * TestWebKitAPI/ios/UIKitSPI.h: Added.
698         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
699         * WebKitTestRunner/ios/GeneratedTouchesDebugWindow.mm:
700         * WebKitTestRunner/ios/HIDEventGenerator.h:
701         * WebKitTestRunner/ios/HIDEventGenerator.mm:
702         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
703         * WebKitTestRunner/ios/TestControllerIOS.mm:
704         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
705         * WebKitTestRunner/ios/mainIOS.mm:
706
707 2019-05-04  Alex Christensen  <achristensen@webkit.org>
708
709         Merge the three UIKitSPI.h files into a single one in PAL
710         https://bugs.webkit.org/show_bug.cgi?id=197534
711
712         Reviewed by Darin Adler.
713
714         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
715         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
716         * DumpRenderTree/mac/DumpRenderTree.mm:
717         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
718         * DumpRenderTree/mac/TestRunnerMac.mm:
719         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
720         * TestWebKitAPI/Tests/WebKitCocoa/CopyURL.mm:
721         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
722         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
723         * TestWebKitAPI/Tests/WebKitCocoa/SystemColors.mm:
724         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
725         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewFindString.mm:
726         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
727         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
728         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
729         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
730         * TestWebKitAPI/Tests/ios/ScrollViewInsetTests.mm:
731         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
732         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
733         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
734         * TestWebKitAPI/cocoa/TestWKWebView.mm:
735         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
736         * TestWebKitAPI/ios/UIKitSPI.h: Removed.
737         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
738         * WebKitTestRunner/ios/GeneratedTouchesDebugWindow.mm:
739         * WebKitTestRunner/ios/HIDEventGenerator.h:
740         * WebKitTestRunner/ios/HIDEventGenerator.mm:
741         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
742         * WebKitTestRunner/ios/TestControllerIOS.mm:
743         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
744         * WebKitTestRunner/ios/mainIOS.mm:
745
746 2019-05-04  Nikita Vasilyev  <nvasilyev@apple.com>
747
748         Web Inspector: Provide UIString descriptions to improve localizations
749         https://bugs.webkit.org/show_bug.cgi?id=195132
750         <rdar://problem/48457817>
751
752         Reviewed by Devin Rousso.
753
754         Allow WI.UIString to take:
755         - WI.UIString(string, key, comment)
756         - WI.UIString(string, comment)
757         - WI.UIString(string)
758
759         * Scripts/extract-localizable-js-strings:
760
761 2019-05-03  Wenson Hsieh  <wenson_hsieh@apple.com>
762
763         REGRESSION (r244897): Caret may appear wider than normal after zooming to focus an editable element
764         https://bugs.webkit.org/show_bug.cgi?id=197579
765
766         Reviewed by Tim Horton.
767
768         Fixes a couple of flaky layout tests (ModifyInputAssistantItemBarButtonGroups and
769         OverrideInputAssistantItemBarButtonGroups) by programmatically blurring focused elements and waiting for the
770         input session to change, rather than relying on -resignFirstResponder and -waitForNextPresentationUpdate to
771         ensure that the the focused element has been blurred.
772
773         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
774
775 2019-05-02  Alexey Proskuryakov  <ap@apple.com>
776
777         Add a tool to block spammer accounts
778         https://bugs.webkit.org/show_bug.cgi?id=197537
779
780         Reviewed by Darin Adler.
781
782         Usage: block-spammers email1 email2 ...
783
784         The tool finds and hides all bugs and comments from this account. Before any work
785         is done, these bugs and comments are displayed for confirmation.
786
787         * Scripts/block-spammers: Added.
788         (get_bugzilla_token):
789         (invalidate_bugzilla_token):
790         (get_user_info):
791         (get_user_info_self):
792         (can_use_this_tool):
793         (disable_user):
794         (get_bugs_created_by_user):
795         (get_bugs_commented_on_by_user):
796         (get_comments):
797         (hide_bug):
798         (hide_comments):
799         (ask_yes_no):
800         (sanitized_string):
801         (main):
802
803 2019-05-03  Jonathan Bedard  <jbedard@apple.com>
804
805         run-apit-tests: Add --iterations and --repeat-each
806         https://bugs.webkit.org/show_bug.cgi?id=197563
807
808         Reviewed by Aakash Jain.
809
810         * Scripts/webkitpy/api_tests/manager.py:
811         (Manager.run): Add --iterations and --repeat-each/
812         * Scripts/webkitpy/api_tests/run_api_tests.py:
813         (parse_args): Duplicate the test list based on --iterations and --repeat-each.
814
815 2019-05-03  Aakash Jain  <aakash_jain@apple.com>
816
817         New EWS: Clicking on white bubble navigates to page with only bubbles
818         https://bugs.webkit.org/show_bug.cgi?id=197520
819
820         Reviewed by Lucas Forschler.
821
822         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Disable clicking if bubble doesn't have any url.
823
824 2019-05-03  Daniel Bates  <dabates@apple.com>
825
826         [lldb-webkit] Support adding pretty-printing for qualified types
827         https://bugs.webkit.org/show_bug.cgi?id=197518
828
829         Reviewed by Darin Adler.
830
831         Remove all "::"s from the name of the specified type when computing the name for the Python classes
832         that will provide summary and synthetic details as LLDB is not happy about registering such classes
833         when they contain :: in their name.
834
835         * lldb/lldb_webkit.py:
836         (addSummaryAndSyntheticFormattersForRawBitmaskType):
837
838 2019-05-03  Aakash Jain  <aakash_jain@apple.com>
839
840         New EWS: patches on recently added queues listed as #1 for older bugs
841         https://bugs.webkit.org/show_bug.cgi?id=197496
842
843         Reviewed by Lucas Forschler.
844
845         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
846         (StatusBubble._build_bubble):
847         (StatusBubble._queue_position):
848
849 2019-05-03  Aakash Jain  <aakash_jain@apple.com>
850
851         webkit-patch --no-review upload does not submit patch to New EWS
852         https://bugs.webkit.org/show_bug.cgi?id=197519
853         <rdar://problem/50424887>
854
855         Reviewed by Lucas Forschler.
856
857         * Scripts/webkitpy/tool/steps/submittoews.py:
858         (SubmitToEWS.run): Submit to both old and new EWS.
859         * Scripts/webkitpy/common/config/urls.py: Added url for new EWS server.
860         * Scripts/webkitpy/common/net/ewsserver.py: Added.
861         (EWSServer._server_url): Method to return server url.
862         (EWSServer._post_patch_to_ews): Method to post patch to ews.
863         (EWSServer.submit_to_ews): Method to submit the patch to ews using NetworkTransaction.
864         * Scripts/webkitpy/common/net/ewsserver_mock.py: Added Mock EWS Server.
865         * Scripts/webkitpy/common/net/ewsserver_unittest.py: Added unit-test for EWS Server.
866         * Scripts/webkitpy/common/net/statusserver_mock.py:
867         (MockStatusServer.submit_to_ews): Updated the log text.
868         * Scripts/webkitpy/tool/commands/queues_unittest.py: Updated unit-tests.
869         * Scripts/webkitpy/tool/commands/upload_unittest.py: Ditto.
870         * Scripts/webkitpy/tool/main.py:
871         (WebKitPatch.__init__): Initialize ews_server. 
872         * Scripts/webkitpy/tool/mocktool.py:
873         (MockTool.__init__): Ditto.
874
875 2019-05-03  Chris Dumez  <cdumez@apple.com>
876
877         ASSERTION FAILED: [weakThis->m_view window] == weakThis->m_targetWindowForMovePreparation
878         https://bugs.webkit.org/show_bug.cgi?id=197574
879         <rdar://problem/50453181>
880
881         Reviewed by Tim Horton.
882
883         Add API test coverage.
884
885         * TestWebKitAPI/Tests/WebKitCocoa/PrepareForMoveToWindow.mm:
886         (TEST):
887
888 2019-05-03  Yusuke Suzuki  <ysuzuki@apple.com>
889
890         [JSC] Generator CodeBlock generation should be idempotent
891         https://bugs.webkit.org/show_bug.cgi?id=197552
892
893         Reviewed by Keith Miller.
894
895         * Scripts/run-javascriptcore-tests:
896         (runJSCStressTests):
897         * Scripts/run-jsc-stress-tests:
898
899 2019-05-03  Commit Queue  <commit-queue@webkit.org>
900
901         Unreviewed, rolling out r244881.
902         https://bugs.webkit.org/show_bug.cgi?id=197559
903
904         Breaks compilation of jsconly on linux, breaking compilation
905         for jsc-i386-ews, jsc-mips-ews and jsc-armv7-ews (Requested by
906         guijemont on #webkit).
907
908         Reverted changeset:
909
910         "[CMake] Refactor WEBKIT_MAKE_FORWARDING_HEADERS into
911         WEBKIT_COPY_FILES"
912         https://bugs.webkit.org/show_bug.cgi?id=197174
913         https://trac.webkit.org/changeset/244881
914
915 2019-05-03  Zan Dobersek  <zdobersek@igalia.com>
916
917         Unreviewed WPE build fix after r244898.
918
919         * WebKitTestRunner/wpe/TestControllerWPE.cpp:
920         (WTR::TestController::abortModal): Add the missing (no-op) definition.
921
922 2019-05-02  Alex Christensen  <achristensen@webkit.org>
923
924         Mark U+01C0 as a homograph of U+006C
925         https://bugs.webkit.org/show_bug.cgi?id=197526
926         <rdar://problem/50301904>
927
928         Reviewed by Tim Horton.
929
930         * TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm:
931         (TestWebKitAPI::TEST):
932
933 2019-05-02  Chris Dumez  <cdumez@apple.com>
934
935         Add test coverage for <rdar://problem/49731231>
936         https://bugs.webkit.org/show_bug.cgi?id=196730
937         <rdar://problem/49731231>
938
939         Reviewed by Ryosuke Niwa.
940
941         Add support for testRunner.abortModal() in macOS's WebKitTestRunner in order
942         to match DumpRenderTree.
943
944         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
945         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
946         (WTR::TestRunner::abortModal):
947         * WebKitTestRunner/InjectedBundle/TestRunner.h:
948         * WebKitTestRunner/TestController.cpp:
949         (WTR::TestController::runModal):
950         * WebKitTestRunner/TestController.h:
951         * WebKitTestRunner/TestInvocation.cpp:
952         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
953         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
954         (WTR::TestController::abortModal):
955         * WebKitTestRunner/ios/TestControllerIOS.mm:
956         (WTR::TestController::abortModal):
957         * WebKitTestRunner/mac/TestControllerMac.mm:
958         (WTR::TestController::abortModal):
959         * WebKitTestRunner/win/TestControllerWin.cpp:
960         (WTR::TestController::abortModal):
961
962 2019-05-02  Christopher Reid  <chris.reid@sony.com>
963
964         [CMake] Add support for LTO builds
965         https://bugs.webkit.org/show_bug.cgi?id=188986
966
967         Reviewed by Don Olmstead.
968
969         Add support to configure --lto-mode with cmake builds.
970
971         * Scripts/build-webkit:
972         * Scripts/webkitdirs.pm:
973         (generateBuildSystemFromCMakeProject):
974
975 2019-05-02  John Wilander  <wilander@apple.com>
976
977         Make both filterForRegistrableDomains() in WebKit::NetworkProcess use WebCore::RegistrableDomain::uncheckedCreateFromHost()
978         https://bugs.webkit.org/show_bug.cgi?id=197521
979         <rdar://problem/49651503>
980
981         Reviewed by Brent Fulgham.
982
983         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
984         (TestWebKitAPI::TEST):
985            Added a test for host strings with leading dots since they are
986            often used for the domain attribute in cookies.
987
988 2019-05-02  Per Arne Vollan  <pvollan@apple.com>
989
990         -[WKWebsiteDataStore removeDataOfTypes:forDataRecords:completionHandler:] doesn't delete _WKWebsiteDataTypeCredentials
991         https://bugs.webkit.org/show_bug.cgi?id=197510
992
993         Reviewed by Alex Christensen.
994
995         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
996         (TestWebKitAPI::TEST):
997
998 2019-05-02  Don Olmstead  <don.olmstead@sony.com>
999
1000         [CMake] Refactor WEBKIT_MAKE_FORWARDING_HEADERS into WEBKIT_COPY_FILES
1001         https://bugs.webkit.org/show_bug.cgi?id=197174
1002
1003         Reviewed by Alex Christensen.
1004
1005         Make TestJSC dependent on JavaScriptCorePrivateFrameworkHeaders.
1006
1007         * TestWebKitAPI/PlatformGTK.cmake:
1008         * TestWebKitAPI/PlatformWPE.cmake:
1009
1010 2019-05-02  Alex Christensen  <achristensen@webkit.org>
1011
1012         Build fix for internal branch.
1013
1014         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
1015         RetainPtr.h was not explicitly included.
1016
1017 2019-05-02  Jonathan Bedard  <jbedard@apple.com>
1018
1019         webkitpy: Ignore errors when shutting down an already shutdown simulator
1020         <https://bugs.webkit.org/show_bug.cgi?id=197514>
1021         <rdar://problem/50390247>
1022
1023         Reviewed by Lucas Forschler.
1024
1025         * Scripts/webkitpy/xcode/simulated_device.py:
1026         (SimulatedDevice._shut_down):
1027
1028 2019-05-02  Frederic Wang  <fwang@igalia.com>
1029
1030         [GTK][WPE] Disable "thin", "thick", "medium" values of mfrac@linethickness at runtime
1031         https://bugs.webkit.org/show_bug.cgi?id=196142
1032
1033         This patch introduces some experimental runtime flag to let users
1034         disable MathML features that are removed from MathML Core [1]. For now,
1035         these features are only disabled on GTK and WPE ports.
1036
1037         [1] https://mathml-refresh.github.io/mathml-core/
1038
1039         Reviewed by Rob Buis.
1040
1041         * DumpRenderTree/TestOptions.cpp:
1042         (TestOptions::TestOptions):
1043         * DumpRenderTree/TestOptions.h:
1044         * DumpRenderTree/mac/DumpRenderTree.mm:
1045         (setWebPreferencesForTestOptions):
1046
1047 2019-05-01  Don Olmstead  <don.olmstead@sony.com>
1048
1049         TestWebKitAPI config.h should be aware of what suite is being built
1050         https://bugs.webkit.org/show_bug.cgi?id=196583
1051
1052         Reviewed by Konstantin Tokarev.
1053
1054         Migrate to WEBKIT_EXECUTABLE to define the Test* executables. As an added
1055         benefit the macro defines BUILDING_* for the executable which allows the includes
1056         of the config.h to be tailored to the test suite being built. Because of that the
1057         dependencies of the Test* executable are specific to the test suite which may
1058         speed up the build.
1059
1060         Some source files were including "PlatformUtilities.h" which includes WebKit headers
1061         when "Utilities.h" is what was needed.
1062
1063         * TestWebKitAPI/CMakeLists.txt:
1064         * TestWebKitAPI/PlatformGTK.cmake:
1065         * TestWebKitAPI/PlatformJSCOnly.cmake:
1066         * TestWebKitAPI/PlatformMac.cmake:
1067         * TestWebKitAPI/PlatformPlayStation.cmake:
1068         * TestWebKitAPI/PlatformUtilities.h:
1069         * TestWebKitAPI/PlatformWPE.cmake:
1070         * TestWebKitAPI/PlatformWin.cmake:
1071         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
1072         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1073         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
1074         * TestWebKitAPI/Tests/WebCore/LineBreaking.mm:
1075         * TestWebKitAPI/Tests/WebCore/cocoa/SharedBuffer.mm:
1076         * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm:
1077         * TestWebKitAPI/config.h:
1078
1079 2019-05-01  Jiewen Tan  <jiewen_tan@apple.com>
1080
1081         Move Document::domainIsRegisterable to SecurityOrigin::isMatchingRegistrableDomainSuffix
1082         https://bugs.webkit.org/show_bug.cgi?id=181950
1083         <rdar://problem/43357371>
1084
1085         Reviewed by Brent Fulgham.
1086
1087         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
1088         (TestWebKitAPI::TEST_F):
1089
1090 2019-05-01  Aakash Jain  <aakash_jain@apple.com>
1091
1092         Remove webkitpy and bindings EWS queues from dashboard
1093         https://bugs.webkit.org/show_bug.cgi?id=197475
1094
1095         Reviewed by Alexey Proskuryakov.
1096
1097         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
1098
1099 2019-05-01  Aakash Jain  <aakash_jain@apple.com>
1100
1101         Remove webkitpy and bindings test queues from old EWS
1102         https://bugs.webkit.org/show_bug.cgi?id=197468
1103
1104         Reviewed by Alexey Proskuryakov.
1105
1106         * QueueStatusServer/config/queues.py:
1107
1108 2019-04-30  Tim Horton  <timothy_horton@apple.com>
1109
1110         Fix the WebKitTestRunner build
1111         https://bugs.webkit.org/show_bug.cgi?id=197449
1112         <rdar://problem/50334169>
1113
1114         Reviewed by Alexey Proskuryakov.
1115
1116         * WebKitTestRunner/mac/EventSenderProxy.mm:
1117         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
1118         (WTR::EventSenderProxy::mouseForceChanged):
1119         Use some SPI instead of IPI.
1120
1121 2019-04-30  Chris Dumez  <cdumez@apple.com>
1122
1123         Regression(PSON) URL scheme handlers can no longer respond asynchronously
1124         https://bugs.webkit.org/show_bug.cgi?id=197426
1125         <rdar://problem/50256169>
1126
1127         Reviewed by Brady Eidson.
1128
1129         Add API test coverage.
1130
1131         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1132         (-[PSONScheme setShouldRespondAsynchronously:]):
1133         (-[PSONScheme webView:startURLSchemeTask:]):
1134         (-[PSONScheme webView:stopURLSchemeTask:]):
1135
1136 2019-04-30  Chris Dumez  <cdumez@apple.com>
1137
1138         Unreviewed, rolling out r244802.
1139
1140         Caused an API test failure
1141
1142         Reverted changeset:
1143
1144         "Regression(PSON) URL scheme handlers can no longer respond
1145         asynchronously"
1146         https://bugs.webkit.org/show_bug.cgi?id=197426
1147         https://trac.webkit.org/changeset/244802
1148
1149 2019-04-30  Chris Dumez  <cdumez@apple.com>
1150
1151         Regression(PSON) URL scheme handlers can no longer respond asynchronously
1152         https://bugs.webkit.org/show_bug.cgi?id=197426
1153         <rdar://problem/50256169>
1154
1155         Reviewed by Brady Eidson.
1156
1157         Add API test coverage.
1158
1159         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1160         (-[PSONScheme setShouldRespondAsynchronously:]):
1161         (-[PSONScheme webView:startURLSchemeTask:]):
1162         (-[PSONScheme webView:stopURLSchemeTask:]):
1163
1164 2019-04-30  Chris Dumez  <cdumez@apple.com>
1165
1166         Only use a related page's process if that page has not been closed yet
1167         https://bugs.webkit.org/show_bug.cgi?id=197393
1168         <rdar://problem/50302423>
1169
1170         Reviewed by Tim Horton.
1171
1172         Add API test coverage.
1173
1174         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1175
1176 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
1177
1178         [ews-build] Enable Bindings tests queue on new EWS
1179         https://bugs.webkit.org/show_bug.cgi?id=197424
1180
1181         Reviewed by Lucas Forschler.
1182
1183         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1184         (StatusBubble):
1185         * BuildSlaveSupport/ews-build/config.json:
1186
1187 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
1188
1189         [ews-build] Configure ews151 for running various tests
1190         https://bugs.webkit.org/show_bug.cgi?id=197419
1191
1192         Reviewed by Lucas Forschler.
1193
1194         * BuildSlaveSupport/ews-build/config.json:
1195
1196 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
1197
1198         [ews-build] Parse and display bindings test failures
1199         https://bugs.webkit.org/show_bug.cgi?id=197423
1200
1201         Reviewed by Lucas Forschler.
1202
1203         * BuildSlaveSupport/ews-build/steps.py:
1204         (RunBindingsTests.__init__): Set timeout of 5 minutes.
1205         (RunBindingsTests.start): Initialize log_observer for json output.
1206         (RunBindingsTests.getResultSummary): Update step and build summary based on bindings test results.
1207         (RunBindingsTests._addToLog): Method to add message to log.
1208         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-test accordingly.
1209
1210 2019-04-30  Pablo Saavedra  <psaavedra@igalia.com>
1211
1212         Unreviewed. Add myself as a committer.
1213
1214         * Scripts/webkitpy/common/config/contributors.json:
1215
1216 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
1217
1218         [ews-build] Enable webkitpy queue on new EWS
1219         https://bugs.webkit.org/show_bug.cgi?id=197396
1220
1221         Reviewed by Lucas Forschler.
1222
1223         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1224         (StatusBubble):
1225         * BuildSlaveSupport/ews-build/config.json:
1226
1227 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
1228
1229         [ews-build] Parse and display webkitpy failures
1230         https://bugs.webkit.org/show_bug.cgi?id=197395
1231
1232         Reviewed by Lucas Forschler.
1233
1234         * BuildSlaveSupport/ews-build/steps.py:
1235         (RunWebKitPyTests.start): Initialize log_observer for json output.
1236         (RunWebKitPyTests.getResultSummary): Update step and build summary based on webkitpy results.
1237         (RunWebKitPyTests._addToLog): Method to add message to log.
1238         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-test accordingly.
1239
1240 2019-04-29  Alex Christensen  <achristensen@webkit.org>
1241
1242         <rdar://problem/50299396> Fix internal High Sierra build
1243         https://bugs.webkit.org/show_bug.cgi?id=197388
1244
1245         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1246         * MiniBrowser/Configurations/Base.xcconfig:
1247         * MobileMiniBrowser/Configurations/Base.xcconfig:
1248         * TestWebKitAPI/Configurations/Base.xcconfig:
1249         * WebKitTestRunner/Configurations/Base.xcconfig:
1250
1251 2019-04-29  Youenn Fablet  <youenn@apple.com>
1252
1253         Remove spurious GVA printf logging
1254         https://bugs.webkit.org/show_bug.cgi?id=197368
1255         <rdar://problem/35975256>
1256
1257         Reviewed by Alexey Proskuryakov.
1258
1259         * Scripts/webkitpy/port/mac.py:
1260         (MacPort.logging_patterns_to_strip):
1261
1262 2019-04-29  Youenn Fablet  <youenn@apple.com>
1263
1264         getDisplayMedia should be called on user gesture
1265         https://bugs.webkit.org/show_bug.cgi?id=197356
1266         <rdar://problem/50296074>
1267
1268         Reviewed by Eric Carlson.
1269
1270         Update test configuration to inject internals
1271         so that we can use it to simulate a user click to call getDisplayMedia.
1272
1273         * TestWebKitAPI/Tests/WebKit/getDisplayMedia.html:
1274         * TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm:
1275         (TestWebKitAPI::GetDisplayMediaTest::SetUp):
1276
1277 2019-04-26  Stephanie Lewis  <slewis@apple.com>
1278
1279         run-benchmarks should have an intial prep and restore env call for tasks that are too expensive to do for every iteration
1280         https://bugs.webkit.org/show_bug.cgi?id=197339
1281
1282         Reviewed by Dewei Zhu.
1283
1284         Add two new functions prepare_inital_env and restore_env_after_all_testing around the entire
1285         test run for setup steps that are too expensive to do every iteration.
1286
1287         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1288         (BenchmarkRunner._run_benchmark):
1289         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
1290         (BrowserDriver):
1291         (BrowserDriver.prepare_initial_env):
1292         (BrowserDriver.restore_env_after_all_testing):
1293         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
1294         (LinuxBrowserDriver.prepare_initial_env):
1295         (LinuxBrowserDriver.restore_env_after_all_testing):
1296         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
1297         (OSXBrowserDriver.prepare_initial_env):
1298         (OSXBrowserDriver.restore_env_after_all_testing):
1299
1300 2019-04-28  Andy Estes  <aestes@apple.com>
1301
1302         Fix the watchOS engineering build.
1303
1304         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm:
1305         (TestWebKitAPI::TEST): AVVideoPerformanceMetrics does not exist on watchOS.
1306
1307 2019-04-27  Chris Dumez  <cdumez@apple.com>
1308
1309         [WKTR] Move test timeout handling to the UIProcess
1310         https://bugs.webkit.org/show_bug.cgi?id=197333
1311
1312         Reviewed by Darin Adler.
1313
1314         Move test timeout handling in WebKitTestRunner to the UIProcess to play nicely with PSON. Previously,
1315         we'd start the timeout timer in the InjectedBundle, which would fail to account of the time spent in
1316         every WebContent process in the case of swapping.
1317
1318         Also, because of process caching, the timeout timer would sometime fire in a cached process and it
1319         would lead to crashes when firing the timer.
1320
1321         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1322         (WTR::InjectedBundle::didReceiveMessageToPage):
1323         (WTR::InjectedBundle::done):
1324         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1325         (WTR::InjectedBundle::shouldDumpPixels const):
1326         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1327         (WTR::TestRunner::TestRunner):
1328         (WTR::TestRunner::waitUntilDone):
1329         (WTR::TestRunner::setWaitUntilDone):
1330         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1331         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
1332         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1333         * WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp:
1334         * WebKitTestRunner/InjectedBundle/wpe/TestRunnerWPE.cpp:
1335         * WebKitTestRunner/TestInvocation.cpp:
1336         (WTR::TestInvocation::TestInvocation):
1337         (WTR::TestInvocation::createTestSettingsDictionary):
1338         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1339         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1340         (WTR::TestInvocation::initializeWaitToDumpWatchdogTimerIfNeeded):
1341         (WTR::TestInvocation::invalidateWaitToDumpWatchdogTimer):
1342         (WTR::TestInvocation::waitToDumpWatchdogTimerFired):
1343         (WTR::TestInvocation::setWaitUntilDone):
1344         (WTR::TestInvocation::done):
1345         * WebKitTestRunner/TestInvocation.h:
1346
1347 2019-04-25  Yusuke Suzuki  <ysuzuki@apple.com>
1348
1349         [JSC] linkPolymorphicCall now does GC
1350         https://bugs.webkit.org/show_bug.cgi?id=197306
1351
1352         Reviewed by Saam Barati.
1353
1354         The test is sensitive to allocations and even adding $vm makes it non-reproducible.
1355         To add this test, we add `runWithoutBaseOption`.
1356
1357         * Scripts/run-jsc-stress-tests:
1358
1359 2019-04-26  Alexey Proskuryakov  <ap@apple.com>
1360
1361         Update inactive reviewers' status to 'contributor'.
1362
1363         Accidentally skipped one at first.
1364
1365         * Scripts/webkitpy/common/config/contributors.json:
1366
1367 2019-04-26  Alexey Proskuryakov  <ap@apple.com>
1368
1369         Update inactive reviewers' status to 'contributor'.
1370
1371         * Scripts/webkitpy/common/config/contributors.json: The change.
1372
1373         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1374         * Scripts/webkitpy/common/checkout/checkout_mock.py:
1375         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1376         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
1377         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1378         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
1379         * Scripts/webkitpy/tool/commands/queries_unittest.py:
1380         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1381         Sadly, regression tests operate on a crazy mix of mock and live data for
1382         contributors.json. It would be a substantial project to mock all code paths,
1383         so changing the tests instead.
1384
1385 2019-04-26  Eric Carlson  <eric.carlson@apple.com>
1386
1387         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
1388         https://bugs.webkit.org/show_bug.cgi?id=197171
1389         <rdar://problem/47454979>
1390
1391         Reviewed by Youenn Fablet.
1392
1393         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1394         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
1395         (TestWebKitAPI::TEST):
1396
1397 2019-04-26  David Kilzer  <ddkilzer@apple.com>
1398
1399         WebKitTestRunner leaks an NSDictionary and multiple JSStringRef objects
1400         <https://webkit.org/b/197314>
1401         <rdar://problem/50245252>
1402
1403         Reviewed by Simon Fraser.
1404
1405         * WebKitTestRunner/UIScriptControllerCocoa.mm:
1406         (WTR::UIScriptController::lastUndoLabel const):
1407         (WTR::UIScriptController::firstRedoLabel const):
1408         - Use adopt(JSStringCreateWithCFString(...)) to fix leaks.
1409
1410         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1411         (-[HIDEventGenerator sendEventStream:completionBlock:]):
1412         - Call -autorelease to fix leak of NSDictionary.
1413
1414         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1415         (WTR::UIScriptController::accessibilitySpeakSelectionContent const):
1416         (WTR::UIScriptController::selectFormPopoverTitle const):
1417         (WTR::UIScriptController::textContentType const):
1418         (WTR::UIScriptController::formInputLabel const):
1419         (WTR::UIScriptController::scrollingTreeAsText const):
1420         - Use adopt(JSStringCreateWithCFString(...)) to fix leaks.
1421
1422 2019-04-26  Jonathan Bedard  <jbedard@apple.com>
1423
1424         webkitpy: Running a single test will always use the default device
1425         https://bugs.webkit.org/show_bug.cgi?id=195472
1426         <rdar://problem/48724825>
1427
1428         Reviewed by Lucas Forschler.
1429
1430         It makes more sense to have the Manager class handle the case where a user specifically requests a test which is
1431         skipped on the current configuration. This changes the behavior when running part of a test shard, now tests explicitly
1432         requested will be run regardless of what shard they are in.
1433
1434         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
1435         (LayoutTestFinder.skip_tests): Caller should manage running skipped tests which were explicitly requested.
1436         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1437         (Manager.run): If a test is marked as skipped for the configuration, but was specifically requested, run it anyways
1438         on the default device type.
1439         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1440         (RunTest.test_run_chunk): Explicitly requesting a test will override sharing behavior.
1441         (RunTest.test_run_part): Ditto.
1442
1443 2019-04-26  Alex Christensen  <achristensen@webkit.org>
1444
1445         Add ENABLE(CONTENT_EXTENSIONS) and namespace ContentExtensions to ResourceLoadInfo.h
1446         https://bugs.webkit.org/show_bug.cgi?id=197165
1447
1448         Reviewed by Youenn Fablet.
1449
1450         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1451
1452 2019-04-26  Ryan Haddad  <ryanhaddad@apple.com>
1453
1454         Replace iOS build queue hardware
1455         https://bugs.webkit.org/show_bug.cgi?id=197312
1456
1457         Reviewed by Aakash Jain.
1458
1459         * BuildSlaveSupport/build.webkit.org-config/config.json:
1460         Use newer hardware that supports macOS Mojave.
1461
1462 2019-04-26  Yoshiaki Jitsukawa  <yoshiaki.jitsukawa@sony.com>
1463
1464         check-webkit-style complains the first block in while loop.
1465         https://bugs.webkit.org/show_bug.cgi?id=197307
1466
1467         The style checker shouldn't complain about an open brace on
1468         its own line if the last non-whitespace character on the previous
1469         non-blank line is another open brace, because it's likely to
1470         indicate the begining of a nested code block.
1471
1472         Reviewed by Alex Christensen.
1473
1474         * Scripts/webkitpy/style/checkers/cpp.py:
1475         (check_braces):
1476         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1477         (WebKitStyleTest.test_braces):
1478
1479 2019-04-26  Sihui Liu  <sihui_liu@apple.com>
1480
1481         Stop IDB transactions to release locked database files when network process is ready to suspend
1482         https://bugs.webkit.org/show_bug.cgi?id=196372
1483         <rdar://problem/48930116>
1484
1485         Reviewed by Brady Eidson.
1486
1487         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1488         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBSuspendImminently.html: Added.
1489         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBSuspendImminently.mm: Added.
1490         (-[IndexedDBSuspendImminentlyMessageHandler userContentController:didReceiveScriptMessage:]):
1491         (runTestAndCheckResult):
1492         (keepNetworkProcessActive):
1493         (TEST):
1494
1495 2019-04-25  Simon Fraser  <simon.fraser@apple.com>
1496
1497         REGRESSION (r234330): 3 legacy-animation-engine/compositing tests are flaky failures
1498         https://bugs.webkit.org/show_bug.cgi?id=188357
1499         <rdar://problem/42986633>
1500
1501         Reviewed by Dean Jackson.
1502
1503         DumpRenderTree had no code that set page.setCompositingPolicyOverride() to Normal, so some
1504         tests would fall into low memory mode and have different behavior.
1505         
1506         Fix by moving the code that calls setCompositingPolicyOverride(Normal) from the WK2 layer
1507         to Internals, so it's shared by DRT and WTR.
1508         
1509         We no longer need the WK2 C SPI glue.
1510
1511         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1512         (WTR::InjectedBundlePage::prepare):
1513
1514 2019-04-25  Jonathan Bedard  <jbedard@apple.com>
1515
1516         webkitpy: Including skipped tests in the final count
1517         https://bugs.webkit.org/show_bug.cgi?id=197298
1518         <rdar://problem/49705424>
1519
1520         Reviewed by Lucas Forschler.
1521
1522         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
1523         (BuildBotPrinter.print_run_results): The total number of tests run should exclude delibrately skipped tests.
1524
1525 2019-04-25  Timothy Hatcher  <timothy@apple.com>
1526
1527         Disable date and time inputs on iOSMac.
1528         https://bugs.webkit.org/show_bug.cgi?id=197287
1529         rdar://problem/46794376
1530
1531         Reviewed by Wenson Hsieh.
1532
1533         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1534
1535 2019-04-25  Alex Christensen  <achristensen@webkit.org>
1536
1537         Fix test-webkitpy after r244653
1538         https://bugs.webkit.org/show_bug.cgi?id=197131
1539
1540         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
1541         Also use C++17.
1542
1543 2019-04-25  Per Arne Vollan  <pvollan@apple.com>
1544
1545         -[WKWebsiteDataStore fetchDataRecordsOfTypes:completionHandler:] never returns _WKWebsiteDataTypeCredentials
1546         https://bugs.webkit.org/show_bug.cgi?id=196991
1547         <rdar://problem/45507423>
1548
1549         Reviewed by Alex Christensen.
1550
1551         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
1552         (-[NavigationTestDelegate init]):
1553         (-[NavigationTestDelegate waitForDidFinishNavigation]):
1554         (-[NavigationTestDelegate webView:didFinishNavigation:]):
1555         (-[NavigationTestDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1556         (TestWebKitAPI::TEST):
1557         (TEST): Deleted.
1558
1559 2019-04-25  Alex Christensen  <achristensen@webkit.org>
1560
1561         Revert some code accidentally committed with r244653
1562         https://bugs.webkit.org/show_bug.cgi?id=197131
1563
1564         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:
1565         (TestWebKitAPI::TEST):
1566
1567 2019-04-25  Alex Christensen  <achristensen@webkit.org>
1568
1569         Start using C++17
1570         https://bugs.webkit.org/show_bug.cgi?id=197131
1571
1572         Reviewed by Darin Adler.
1573
1574         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1575         * MiniBrowser/Configurations/Base.xcconfig:
1576         * MobileMiniBrowser/Configurations/Base.xcconfig:
1577         * TestWebKitAPI/Configurations/Base.xcconfig:
1578         * WebKitTestRunner/Configurations/Base.xcconfig:
1579
1580 2019-04-25  Commit Queue  <commit-queue@webkit.org>
1581
1582         Unreviewed, rolling out r244627.
1583         https://bugs.webkit.org/show_bug.cgi?id=197282
1584
1585         Causing internal build failures (Requested by ShawnRoberts on
1586         #webkit).
1587
1588         Reverted changeset:
1589
1590         "Create AVFoundationSoftLink.{h,mm} to reduce duplicate code"
1591         https://bugs.webkit.org/show_bug.cgi?id=197171
1592         https://trac.webkit.org/changeset/244627
1593
1594 2019-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1595
1596         [GTK] Hardcoded text color in input fields
1597         https://bugs.webkit.org/show_bug.cgi?id=126907
1598
1599         Reviewed by Michael Catanzaro.
1600
1601         Add dark-mode command line option to MiniBrowser.
1602
1603         * MiniBrowser/gtk/main.c:
1604         (main):
1605
1606 2019-04-24  Zalan Bujtas  <zalan@apple.com>
1607
1608         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
1609         https://bugs.webkit.org/show_bug.cgi?id=196948
1610         <rdar://problem/49927131>
1611
1612         Reviewed by Tim Horton.
1613
1614         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
1615         (TEST):
1616         The expected order of incoming events is
1617         1. didInvalidateIntrinsicContentSize
1618         2. didFirstLayout
1619         At setRenderingProgressDidChange, we already check if didInvalidateIntrinsicContentSize comes in first.
1620         However it's not guaranteed that the milestone event is delayed until after TestWebKitAPI::Util::run() is finished
1621         (and remember, all we care about is ordering).
1622
1623 2019-04-24  Eric Carlson  <eric.carlson@apple.com>
1624
1625         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
1626         https://bugs.webkit.org/show_bug.cgi?id=197171
1627         <rdar://problem/47454979>
1628
1629         Reviewed by Youenn Fablet.
1630
1631         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1632         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
1633         (TestWebKitAPI::TEST):
1634
1635 2019-04-24  Brady Eidson  <beidson@apple.com>
1636
1637         XMLHTTPRequest POSTs to a custom WKURLSchemeHandler protocol are missing the HTTP body.
1638         https://bugs.webkit.org/show_bug.cgi?id=191362
1639
1640         Reviewed by Alex Christensen.
1641
1642         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm: Add a test that POSTs all sorts of things
1643           from an XHR to a custom protocol.
1644
1645 2019-04-25  Simon Fraser  <simon.fraser@apple.com>
1646
1647         DumpRenderTree doesn't call Internals::resetToConsistentState() before the first test
1648         https://bugs.webkit.org/show_bug.cgi?id=197273
1649
1650         Reviewed by Dean Jackson.
1651
1652         Reorder code so that we create gTestRunner before calling resetWebViewToConsistentStateBeforeTesting(),
1653         so that WebCoreTestSupport::resetInternalsObject() is always run.
1654
1655         * DumpRenderTree/mac/DumpRenderTree.mm:
1656         (resetWebViewToConsistentStateBeforeTesting):
1657         (runTest):
1658
1659 2019-04-24  John Wilander  <wilander@apple.com>
1660
1661         Age out unconverted Ad Click Attributions after one week.
1662         https://bugs.webkit.org/show_bug.cgi?id=197238
1663         <rdar://problem/50177349>
1664
1665         Reviewed by Chris Dumez.
1666
1667         This patch adds infrastructure to allow tests to expire all unconverted
1668         attributions early.
1669
1670         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1671         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1672         (WTR::TestRunner::markAdClickAttributionsAsExpiredForTesting):
1673         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1674         * WebKitTestRunner/TestController.cpp:
1675         (WTR::TestController::markAdClickAttributionsAsExpiredForTesting):
1676         * WebKitTestRunner/TestController.h:
1677         * WebKitTestRunner/TestInvocation.cpp:
1678         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1679
1680 2019-04-24  Chris Dumez  <cdumez@apple.com>
1681
1682         Fix flaky crashes in a couple of PSON API tests
1683         https://bugs.webkit.org/show_bug.cgi?id=197239
1684
1685         Reviewed by Tim Horton.
1686
1687         Do not adopt the NSURLRequest returned by [NSURLRequest requestWithURL:].
1688
1689         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1690
1691 2019-04-24  Simon Fraser  <simon.fraser@apple.com>
1692
1693         Make it possible to control the renderTreeAsText output by setting options on testRunner
1694         https://bugs.webkit.org/show_bug.cgi?id=197133
1695
1696         Reviewed by Sam Weinig.
1697
1698         Add testRunner.setRenderTreeDumpOptions() and expose the subset of RenderAsTextFlag flags
1699         that make sense in testing (those that don't dump unstable data like addresses), and plumb
1700         these flags through the various framework layers.
1701
1702         Convert RenderAsTextBehavior to an OptionSet<RenderAsTextFlag>.
1703
1704         Fix code generation in WebKitTestRunner to generate bindings for IDL const values,
1705         and hand-code DumpRenderTree bindings.
1706
1707         Some cleanup of the TestRunners, using member initializers.
1708
1709         * DumpRenderTree/TestRunner.cpp:
1710         (TestRunner::TestRunner):
1711         (setRenderTreeDumpOptionsCallback):
1712         (TestRunner::staticFunctions):
1713         (TestRunner::setRenderTreeDumpOptions):
1714         * DumpRenderTree/TestRunner.h:
1715         (TestRunner::renderTreeDumpOptions const):
1716         * DumpRenderTree/mac/DumpRenderTree.mm:
1717         (dump):
1718         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1719         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1720         (WTR::InjectedBundlePage::dump):
1721         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1722         (WTR::TestRunner::TestRunner):
1723         (WTR::TestRunner::setRenderTreeDumpOptions):
1724         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1725         (WTR::TestRunner::renderTreeDumpOptions const):
1726
1727 2019-04-24  Alex Christensen  <achristensen@webkit.org>
1728
1729         WKContentRuleLists should have a maximum FileProtection of CompleteUnlessOpen
1730         https://bugs.webkit.org/show_bug.cgi?id=197078
1731         <rdar://problem/49564348>
1732
1733         Reviewed by Geoff Garen.
1734
1735         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
1736         (TEST_F):
1737         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]): Deleted.
1738         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]): Deleted.
1739         Unfortunately, setting the NSFileProtectionKey attribute is only supported on iOS devices.
1740
1741 2019-04-24  Alex Christensen  <achristensen@webkit.org>
1742
1743         Add unit test for r239322
1744         https://bugs.webkit.org/show_bug.cgi?id=197236
1745
1746         Reviewed by Chris Dumez.
1747
1748         I initially developed this as a unit test for rdar://problem/48797895 but it seems that isn't quite ready.
1749         May as well add the test infrastructure which was needed before and will be needed in the future.
1750
1751         * TestWebKitAPI/TCPServer.cpp:
1752         (TestWebKitAPI::TCPServer::TCPServer):
1753         * TestWebKitAPI/TCPServer.h:
1754         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1755         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
1756         (TestWebKitAPI::TEST):
1757         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1758         (TestWebKitAPI::downloadAtRate):
1759         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
1760         (TEST):
1761         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm: Added.
1762         (-[ProxyDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1763         (-[ProxyDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1764         (TestWebKitAPI::TEST):
1765         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
1766         (TEST):
1767
1768 2019-04-24  Chris Dumez  <cdumez@apple.com>
1769
1770         URL set by document.open() is communicated with the WebPageProxy but not the WebFrameProxy
1771         https://bugs.webkit.org/show_bug.cgi?id=197214
1772         <rdar://problem/49237544>
1773
1774         Reviewed by Alex Christensen.
1775
1776         Extend API test coverage.
1777
1778         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
1779         (TEST):
1780
1781 2019-04-24  Philippe Normand  <pnormand@igalia.com>
1782
1783         [Build][GStreamer] Update to 1.16.0
1784         https://bugs.webkit.org/show_bug.cgi?id=197157
1785
1786         Reviewed by Xabier Rodriguez-Calvar.
1787
1788         The upstreamed patches were removed and a new one was added for a
1789         regression detected in the scaletempo GStreamer element. The GNOME
1790         Flatpak was migrated to 3.32 and I switched a few modules to Meson
1791         on the way, as it is the preferred build system now in GStreamer
1792         1.16.
1793
1794         * flatpak/files/httpd-autogen.sh:
1795         * flatpak/flatpakutils.py:
1796         (FlatpakPackage.install):
1797         (WebkitFlatpak.run_in_sandbox):
1798         * flatpak/org.webkit.CommonModules.yaml:
1799         * flatpak/org.webkit.WebKit.yaml:
1800         * gstreamer/jhbuild.modules:
1801         * gstreamer/patches/gst-plugins-bad-0001-aomenc-Add-support-for-10-12bit-decoding.patch: Removed.
1802         * gstreamer/patches/gst-plugins-bad-0002-aomenc-Handle-8-bit_depth-images-with-AOM_IMG_FMT_HI.patch: Removed.
1803         * gstreamer/patches/gst-plugins-bad-0003-fdkaacenc-Remove-MODE_2_1.patch: Removed.
1804         * gstreamer/patches/gst-plugins-bad-0004-fdkaacdec-Use-WAV-channel-mapping-instead-of-interleave-setting.patch: Removed.
1805         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Removed.
1806         * gstreamer/patches/gst-plugins-base-0001-parsebin-Post-STREAM_COLLECTION-on-EVENT_STREAM_COLL.patch: Removed.
1807         * gstreamer/patches/gst-plugins-good-0001-qtdemux-Detect-and-expose-CEA-608-708-Closed-Caption.patch: Removed.
1808         * gstreamer/patches/gst-plugins-good-0001-qtdemux-Do-not-run-the-preferred-decryptor-context-q.patch: Removed.
1809         * gstreamer/patches/gst-plugins-good-0002-qtdemux-Do-not-unref-a-NULL-stream_tags.patch: Removed.
1810         * gstreamer/patches/gst-plugins-good-0002-qtdemux-add-context-for-a-preferred-protection.patch: Removed.
1811         * gstreamer/patches/gst-plugins-good-0003-qtdemux-Clarify-field-name-about-stream-encryption-s.patch: Removed.
1812         * gstreamer/patches/gst-plugins-good-0003-qtdemux-also-push-buffers-without-encryption-info-in.patch: Removed.
1813         * gstreamer/patches/gst-plugins-good-0004-qtdemux-Add-initial-support-for-AV1-demuxing.patch: Removed.
1814         * gstreamer/patches/gst-plugins-good-0005-qtdemux-Extract-AV1-codec_data-and-put-it-in-the-cap.patch: Removed.
1815         * gstreamer/patches/gst-plugins-good-0006-qtdemux-Recognize-more-AV1-atoms.patch: Removed.
1816         * gstreamer/patches/gst-plugins-good-0011-matroska-Add-the-WebM-encrypted-content-support-in-m.patch: Removed.
1817         * gstreamer/patches/gst-plugins-good-0012-matroskdemux-do-not-use-MapInfo.data-after-unmapping.patch: Removed.
1818         * gstreamer/patches/gst-plugins-good-0013-Avoid-warning-when-reporting-about-decryptors.patch: Removed.
1819         * gstreamer/patches/gst-plugins-good-0014-pulse-Mark-default-devices-as-default.patch: Removed.
1820         * gstreamer/patches/gst-plugins-good-scaletempo-Advertise-interleaved-layout-in-caps-temp.patch: Added.
1821         * gstreamer/patches/gstreamer-0001-protection-Add-a-new-definition-for-unspecified-syst.patch: Removed.
1822         * gstreamer/patches/gstreamer-0002-protection-Fix-the-string-to-define-unspecified-syst.patch: Removed.
1823
1824 2019-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1825
1826         [GTK] MiniBrowser: also set the passed bg-color when receiving arguments
1827         https://bugs.webkit.org/show_bug.cgi?id=197156
1828
1829         Reviewed by Michael Catanzaro.
1830
1831         The background color is only set when MiniBrowser is launched without arguments. This regressed when tabs
1832         support was added.
1833
1834         * MiniBrowser/gtk/BrowserTab.c:
1835         (browser_tab_set_background_color): Set the passed in color as web view background color.
1836         * MiniBrowser/gtk/BrowserTab.h:
1837         * MiniBrowser/gtk/BrowserWindow.c:
1838         (browser_window_init): Initialize backgroundColor.
1839         (browser_window_append_view): Call browser_tab_set_background_color().
1840         (browser_window_set_background_color): Save the passed in color. This function should now be called before tabs
1841         are added.
1842         * MiniBrowser/gtk/main.c:
1843         (main): Call browser_window_set_background_color() before creating the tabs.
1844
1845 2019-04-23  John Wilander  <wilander@apple.com>
1846
1847         Move Ad Click Attribution from internal feature to experimental feature
1848         https://bugs.webkit.org/show_bug.cgi?id=197218
1849         <rdar://problem/47651691>
1850
1851         Reviewed by Brent Fulgham.
1852
1853         * DumpRenderTree/TestOptions.cpp:
1854         (TestOptions::TestOptions):
1855
1856 2019-04-23  Andy Estes  <aestes@apple.com>
1857
1858         [iOS] QuickLook documents loaded from file: URLs should be allowed to perform same-document navigations
1859         https://bugs.webkit.org/show_bug.cgi?id=196749
1860         <rdar://problem/35773454>
1861
1862         Reviewed by Daniel Bates.
1863
1864         Added a new QuickLook API test and added new expectations to existing QuickLook tests.
1865
1866         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
1867         (-[QuickLookDelegate webView:didStartProvisionalNavigation:]):
1868         (-[QuickLookDelegate webView:didFinishNavigation:]):
1869         (-[QuickLookDelegate _webView:didFailNavigation:withError:userInfo:]):
1870         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
1871         (runTest):
1872         (runTestDecideBeforeLoading):
1873         (runTestDecideAfterLoading):
1874         (TEST):
1875
1876 2019-04-23  John Wilander  <wilander@apple.com>
1877
1878         Remove Ad Click Attribution data when removing website data
1879         https://bugs.webkit.org/show_bug.cgi?id=197215
1880         <rdar://problem/47668988>
1881
1882         Reviewed by Chris Dumez.
1883
1884         This patch adds test infrastructure to delete Ad Click Attribution data
1885         through WebsiteDataStore::removeData().
1886
1887         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1888         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1889         (WTR::TestRunner::clearAdClickAttribution):
1890         (WTR::TestRunner::clearAdClickAttributionsThroughWebsiteDataRemoval):
1891         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1892         * WebKitTestRunner/TestController.cpp:
1893         (WTR::TestController::clearAdClickAttributionsThroughWebsiteDataRemoval):
1894         * WebKitTestRunner/TestController.h:
1895         * WebKitTestRunner/TestInvocation.cpp:
1896         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1897
1898 2019-04-23  Jonathan Bedard  <jbedard@apple.com>
1899
1900         webkitpy: Kill unresponsive worker processes
1901         https://bugs.webkit.org/show_bug.cgi?id=197205
1902         <rdar://problem/50104388>
1903
1904         Reviewed by Lucas Forschler.
1905
1906         * Scripts/webkitpy/common/message_pool.py:
1907         (_MessagePool.__init__): Add close timeout.
1908         (_MessagePool._close): Send termination before joining workers, kill unresponsive workers.
1909
1910 2019-04-23  Alex Christensen  <achristensen@webkit.org>
1911
1912         Add unit tests for WKWebView.serverTrust
1913         https://bugs.webkit.org/show_bug.cgi?id=197202
1914
1915         Reviewed by Youenn Fablet
1916
1917         * TestWebKitAPI/TCPServer.cpp:
1918         (TestWebKitAPI::deleter<BIO>::operator()):
1919         (TestWebKitAPI::deleter<SSL>::operator()):
1920         (TestWebKitAPI::deleter<X509>::operator()):
1921         (TestWebKitAPI::deleter<SSL_CTX>::operator()):
1922         (TestWebKitAPI::deleter<EVP_PKEY>::operator()):
1923         (TestWebKitAPI::TCPServer::TCPServer):
1924         (TestWebKitAPI::TCPServer::listenForConnections):
1925         * TestWebKitAPI/TCPServer.h:
1926         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1927         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
1928         (TestWebKitAPI::TEST):
1929         (verifyCertificateAndPublicKey):
1930         (-[ServerTrustDelegate webView:didFinishNavigation:]):
1931         (-[ServerTrustDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1932         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1933         (TestWebKitAPI::downloadAtRate):
1934         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
1935         (TEST):
1936         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
1937         (TEST):
1938
1939 2019-04-23  Commit Queue  <commit-queue@webkit.org>
1940
1941         Unreviewed, rolling out r244556.
1942         https://bugs.webkit.org/show_bug.cgi?id=197212
1943
1944         Causing build failures on multiple builders (Requested by
1945         ShawnRoberts on #webkit).
1946
1947         Reverted changeset:
1948
1949         "Create AVFoundationSoftLink.{h,mm} to reduce duplicate code"
1950         https://bugs.webkit.org/show_bug.cgi?id=197171
1951         https://trac.webkit.org/changeset/244556
1952
1953 2019-04-23  Alex Christensen  <achristensen@webkit.org>
1954
1955         Fix iOS build.
1956         https://bugs.webkit.org/show_bug.cgi?id=195537
1957
1958         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1959         (WTR::TestRunner::setOpenPanelFilesMediaIcon):
1960         AdoptWK constructor is private now.  Use adoptWK instead.
1961
1962 2019-04-23  Andres Gonzalez  <andresg_22@apple.com>
1963
1964         Accessibility text search and selection API enhancements.
1965         https://bugs.webkit.org/show_bug.cgi?id=197095
1966         <rdar://problem/48181791>
1967
1968         Reviewed by Chris Fleizach.
1969
1970         Added new API JS binding code for searchTextWithCriteria to both WTR and DRT.
1971
1972         * DumpRenderTree/AccessibilityTextMarker.h:
1973         * DumpRenderTree/AccessibilityUIElement.cpp:
1974         (searchTextWithCriteriaCallback):
1975         (AccessibilityUIElement::getJSClass):
1976         * DumpRenderTree/AccessibilityUIElement.h:
1977         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1978         (convertVectorToObjectArray):
1979         (convertNSArrayToVector):
1980         (searchTextParameterizedAttributeForCriteria):
1981         (AccessibilityUIElement::getLinkedUIElements):
1982         (AccessibilityUIElement::getDocumentLinks):
1983         (AccessibilityUIElement::getChildren):
1984         (AccessibilityUIElement::getChildrenWithRange):
1985         (AccessibilityUIElement::rowHeaders const):
1986         (AccessibilityUIElement::columnHeaders const):
1987         (AccessibilityUIElement::uiElementArrayAttributeValue const):
1988         (AccessibilityUIElement::searchTextWithCriteria):
1989         (AccessibilityUIElement::attributesOfColumnHeaders):
1990         (AccessibilityUIElement::attributesOfRowHeaders):
1991         (AccessibilityUIElement::attributesOfColumns):
1992         (AccessibilityUIElement::attributesOfRows):
1993         (AccessibilityUIElement::attributesOfVisibleCells):
1994         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1995         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1996         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1997         (WTR::convertVectorToObjectArray):
1998         (WTR::convertNSArrayToVector):
1999         (WTR::searchTextParameterizedAttributeForCriteria):
2000         (WTR::AccessibilityUIElement::getLinkedUIElements):
2001         (WTR::AccessibilityUIElement::getDocumentLinks):
2002         (WTR::AccessibilityUIElement::getUIElementsWithAttribute const):
2003         (WTR::AccessibilityUIElement::getChildren):
2004         (WTR::AccessibilityUIElement::getChildrenWithRange):
2005         (WTR::AccessibilityUIElement::rowHeaders const):
2006         (WTR::AccessibilityUIElement::columnHeaders const):
2007         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue const):
2008         (WTR::AccessibilityUIElement::searchTextWithCriteria):
2009         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
2010         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
2011         (WTR::AccessibilityUIElement::attributesOfColumns):
2012         (WTR::AccessibilityUIElement::attributesOfRows):
2013         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
2014         (WTR::convertElementsToObjectArray): Deleted.
2015
2016 2019-04-23  Guy Lewin  <guy@lewin.co.il>
2017
2018         Multiple File Input Icon Set Regardless of File List
2019         https://bugs.webkit.org/show_bug.cgi?id=195537
2020
2021         Reviewed by Alexey Proskuryakov.
2022
2023         Add setOpenPanelFilesMediaIcon to TestRunner in order to test icon and
2024         display string in iOS file inputs
2025
2026         * DumpRenderTree/TestRunner.cpp:
2027         (SetOpenPanelFilesMediaIconCallback):
2028         (TestRunner::staticFunctions):
2029         (TestRunner::setOpenPanelFilesMediaIcon):
2030         * DumpRenderTree/TestRunner.h:
2031         (TestRunner::openPanelFilesMediaIcon const):
2032         * DumpRenderTree/mac/UIDelegate.mm:
2033         (-[UIDelegate webView:runOpenPanelForFileButtonWithResultListener:allowMultipleFiles:]):
2034         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2035         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2036         (WTR::TestRunner::setOpenPanelFilesMediaIcon):
2037         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2038         * WebKitTestRunner/TestController.cpp:
2039         (WTR::runOpenPanel):
2040         (WTR::TestController::resetStateToConsistentValues):
2041         * WebKitTestRunner/TestController.h:
2042         (WTR::TestController::openPanelFileURLsMediaIcon const):
2043         (WTR::TestController::setOpenPanelFileURLsMediaIcon):
2044         * WebKitTestRunner/TestInvocation.cpp:
2045         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2046
2047 2019-04-23  Eric Carlson  <eric.carlson@apple.com>
2048
2049         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
2050         https://bugs.webkit.org/show_bug.cgi?id=197171
2051         <rdar://problem/47454979>
2052
2053         Reviewed by Youenn Fablet.
2054
2055         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2056         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
2057         (TestWebKitAPI::TEST):
2058
2059 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
2060
2061         [ews-build] Add unit tests for UnApplyPatchIfRequired
2062         https://bugs.webkit.org/show_bug.cgi?id=197197
2063
2064         Reviewed by Lucas Forschler.
2065
2066         * BuildSlaveSupport/ews-build/steps_unittest.py:
2067         (TestUnApplyPatchIfRequired):
2068         (TestUnApplyPatchIfRequired.test_success):
2069         (TestUnApplyPatchIfRequired.test_failure):
2070         (TestUnApplyPatchIfRequired.test_skip):
2071
2072 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
2073
2074         [ews-build] Add unit tests for CleanWorkingDirectory
2075         https://bugs.webkit.org/show_bug.cgi?id=197195
2076
2077         Reviewed by Lucas Forschler.
2078
2079         * BuildSlaveSupport/ews-build/steps_unittest.py:
2080         (TestCleanWorkingDirectory):
2081         (TestCleanWorkingDirectory.test_success):
2082         (TestCleanWorkingDirectory.test_failure):
2083
2084 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
2085
2086         [ews-build] Use explicit imports instead of wildcard imports
2087         https://bugs.webkit.org/show_bug.cgi?id=197194
2088
2089         Reviewed by Lucas Forschler.
2090
2091         * BuildSlaveSupport/ews-build/factories.py:
2092         * BuildSlaveSupport/ews-build/loadConfig.py:
2093         * BuildSlaveSupport/ews-build/steps_unittest.py:
2094
2095 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
2096
2097         [ews-build] Add unit tests for DownloadBuiltProduct
2098         https://bugs.webkit.org/show_bug.cgi?id=197193
2099
2100         Reviewed by Lucas Forschler.
2101
2102         * BuildSlaveSupport/ews-build/steps_unittest.py:
2103         (TestDownloadBuiltProduct):
2104         (TestDownloadBuiltProduct.setUp):
2105         (TestDownloadBuiltProduct.tearDown):
2106         (TestDownloadBuiltProduct.test_success):
2107         (TestDownloadBuiltProduct.test_failure):
2108
2109 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
2110
2111         [ews-app] Exception while loading status-bubble when no build step has started
2112         https://bugs.webkit.org/show_bug.cgi?id=196676
2113
2114         Reviewed by Lucas Forschler.
2115
2116         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2117         (StatusBubble.get_build_timestamp): Check if build step is present before accessing its timestamp.
2118
2119 2019-04-23  Stephan Szabo  <stephan.szabo@sony.com>
2120
2121         [PlayStation] Support running of JSC tests on remote playstation devices
2122         https://bugs.webkit.org/show_bug.cgi?id=197170
2123
2124         Reviewed by Ross Kirsling.
2125
2126         Script changes
2127
2128         * Scripts/run-javascriptcore-tests:
2129         (runJSCStressTests): Pass arguments for playstation to
2130         run-jsc-stress-tests
2131         * Scripts/run-jsc-stress-tests:
2132         Handle $hostOS=="playstation" for determineArchitecture, turning
2133         off $isFTLPlatform and runProfiler and defaulting test writer.
2134         * Scripts/webkitdirs.pm:
2135         (jscPath): PlayStation WebKit executables have .elf extension
2136         (executableProductDir): PlayStation builds on Windows hosts but
2137         uses bin directory rather than bin64/bin32 for executable output
2138         location.
2139         * Scripts/webkitruby/jsc-stress-test-writer-playstation.rb: Added.
2140
2141 2019-04-23  Don Olmstead  <don.olmstead@sony.com>
2142
2143         [CMake][Win] Use target oriented design for WebKit
2144         https://bugs.webkit.org/show_bug.cgi?id=197173
2145
2146         Reviewed by Alex Christensen.
2147
2148         * TestWebKitAPI/PlatformWin.cmake: Add WebKitFrameworkHeaders as a dependency.
2149         * TestWebKitAPI/Tests/WebKit/curl/Certificates.cpp: Remove unused header.
2150
2151 2019-04-23  Chris Dumez  <cdumez@apple.com>
2152
2153         [Process-Swap-On-Navigation] WebKit hangs when going back to a form submission's page due to Process-Swap-On-Navigation on iOS 12.2 and higher
2154         https://bugs.webkit.org/show_bug.cgi?id=197097
2155         <rdar://problem/50048318>
2156
2157         Reviewed by Alex Christensen.
2158
2159         Add API test coverage.
2160
2161         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2162         (-[PSONScheme webView:startURLSchemeTask:]):
2163
2164 2019-04-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2165
2166         [ATK] Implement AtkComponentIface scroll_to methods
2167         https://bugs.webkit.org/show_bug.cgi?id=196856
2168
2169         Reviewed by Michael Catanzaro.
2170
2171         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2172         (WTR::AccessibilityUIElement::scrollToMakeVisible): Call atk_component_scroll_to().
2173         (WTR::AccessibilityUIElement::scrollToGlobalPoint): Call atk_component_scroll_to_point().
2174         * gtk/jhbuild.modules: Bump atk, at-spi2-core and at-spi2-atk to their latest stable version.
2175
2176 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
2177
2178         [ews-build] Improve summary for UploadBuiltProduct step
2179         https://bugs.webkit.org/show_bug.cgi?id=197182
2180
2181         Reviewed by Lucas Forschler.
2182
2183         * BuildSlaveSupport/ews-build/steps.py:
2184         (UploadBuiltProduct): Added descriptionDone.
2185         (UploadBuiltProduct.getResultSummary): Overrided getResultSummary.
2186         * BuildSlaveSupport/ews-build/steps_unittest.py:
2187         (TestUploadBuiltProduct.test_success): Updated unit-test.
2188         (TestUploadBuiltProduct.test_failure): Added unit-test for failure case.
2189
2190 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
2191
2192         [ews-build] Trigger queues only after uploading the archive
2193         https://bugs.webkit.org/show_bug.cgi?id=197180
2194
2195         Reviewed by Lucas Forschler.
2196
2197         * BuildSlaveSupport/ews-build/factories.py:
2198         (Factory.__init__):
2199         (BuildFactory.__init__): Remove trigger step from factories.
2200         (BuildFactory.propertiesToPassToTriggers): Deleted.
2201         * BuildSlaveSupport/ews-build/steps.py:
2202         (ConfigureBuild.__init__): Confiure triggers property.
2203         (Trigger): Step to trigger other queues.
2204         (Trigger.propertiesToPassToTriggers): Method to construct properties to pass to triggerred builds.
2205         (UploadBuiltProduct.finished): Trigger builds after upload is successful.
2206
2207 2019-04-22  Alex Christensen  <achristensen@webkit.org>
2208
2209         Deprecate WKContextCreateWithInjectedBundlePath
2210         https://bugs.webkit.org/show_bug.cgi?id=197169
2211
2212         Reviewed by Youenn Fablet.
2213
2214         * TestWebKitAPI/PlatformUtilities.cpp:
2215         (TestWebKitAPI::Util::createContextWithInjectedBundle):
2216         Use WKContextCreateWithConfiguration instead of WKContextCreateWithInjectedBundlePath after having set its injected bundle path.
2217
2218 2019-04-22  Alex Christensen  <achristensen@webkit.org>
2219
2220         REGRESSION(r230681) Do not use stored credentials if WKBundlePageResourceLoadClient.shouldUseCredentialStorage returns false
2221         https://bugs.webkit.org/show_bug.cgi?id=197093
2222         <rdar://problem/49708268>
2223
2224         Reviewed by Chris Dumez.
2225
2226         Add a test that does two loads.  The first load shouldUseCredentialStorage returns true and we provide a persistent credential.
2227         The second load shouldUseCredentialStorage returns false and we verify that a challenge is received with no suggested credential.
2228         We also need to make the TCPServer able to handle more than one connection because we need these two loads to come from the same protection space,
2229         and our current Cocoa implementation of NetworkSession uses two NSURLSessions that don't share a connection cache, one for loads with credentials
2230         and one for loads without credentials, so there are two TCP connections to the same server in this test.
2231
2232         * TestWebKitAPI/TCPServer.cpp:
2233         (TestWebKitAPI::TCPServer::TCPServer):
2234         (TestWebKitAPI::TCPServer::~TCPServer):
2235         (TestWebKitAPI::TCPServer::socketBindListen):
2236         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests): Deleted.
2237         * TestWebKitAPI/TCPServer.h:
2238         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2239         * TestWebKitAPI/Tests/WebKitCocoa/BasicProposedCredentialPlugIn.mm: Added.
2240         (-[BasicProposedCredentialPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2241         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
2242         (respondWithChallengeThenOK):
2243         (TestWebKitAPI::TEST):
2244         (-[ProposedCredentialDelegate webView:didFinishNavigation:]):
2245         (-[ProposedCredentialDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
2246         (TEST):
2247
2248 2019-04-22  Chris Dumez  <cdumez@apple.com>
2249
2250         Delayed WebProcessLaunch may break the _relatedWebView SPI
2251         https://bugs.webkit.org/show_bug.cgi?id=197160
2252
2253         Reviewed by Alex Christensen.
2254
2255         Add API test coverage.
2256
2257         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2258
2259 2019-04-22  Dean Johnson  <dean_johnson@apple.com>
2260
2261         Use curl to download packages for webkitpy autoinstaller
2262         https://bugs.webkit.org/show_bug.cgi?id=197164
2263
2264         Reviewed by Darin Adler.
2265
2266         * Scripts/webkitpy/common/system/autoinstall.py:
2267         (AutoInstaller._download): Use curl(1) to download packages necessary for
2268         webkitpy/thirdparty/autoinstalled since Python2's urllib2 module can result in unnecessary
2269         errors which are not present when using curl(1).
2270
2271 2019-04-22  Chris Dumez  <cdumez@apple.com>
2272
2273         Unreviewed, rolling out r244502.
2274
2275         Caused crashes on the bots
2276
2277         Reverted changeset:
2278
2279         "Delayed WebProcessLaunch may break the _relatedWebView SPI"
2280         https://bugs.webkit.org/show_bug.cgi?id=197160
2281         https://trac.webkit.org/changeset/244502
2282
2283 2019-04-22  Ryan Haddad  <ryanhaddad@apple.com>
2284
2285         Unreviewed, rolling out r244437.
2286
2287         Still breaks internal tests.
2288
2289         Reverted changeset:
2290
2291         "InjectedBundle parameters often need initialization function
2292         called before unarchiving"
2293         https://bugs.webkit.org/show_bug.cgi?id=189709
2294         https://trac.webkit.org/changeset/244437
2295
2296 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
2297
2298         [ews-build] Use singular verb in failure description in case of single api test failure
2299         https://bugs.webkit.org/show_bug.cgi?id=197013
2300
2301         Reviewed by Lucas Forschler.
2302
2303         * BuildSlaveSupport/ews-build/steps.py:
2304         (AnalyzeAPITestsResults.analyzeResults):
2305
2306 2019-04-22  Chris Dumez  <cdumez@apple.com>
2307
2308         Delayed WebProcessLaunch may break the _relatedWebView SPI
2309         https://bugs.webkit.org/show_bug.cgi?id=197160
2310
2311         Reviewed by Alex Christensen.
2312
2313         Add API test coverage.
2314
2315         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2316
2317 2019-04-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2318
2319         REGRESSION(r241289): [GTK] accessibility/removed-continuation-element-causes-crash.html and accessibility/removed-anonymous-block-child-causes-crash.html crashes
2320         https://bugs.webkit.org/show_bug.cgi?id=194630
2321
2322         Reviewed by Michael Catanzaro.
2323
2324         Return early from getAttributeSet() is passed in accessible is nullptr.
2325
2326         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2327
2328 2019-04-21  Wenson Hsieh  <wenson_hsieh@apple.com>
2329
2330         Defer EditorState updates until the next layer tree flush in a few additional circumstances
2331         https://bugs.webkit.org/show_bug.cgi?id=197145
2332         <rdar://problem/50078170>
2333
2334         Reviewed by Darin Adler.
2335
2336         Adjusts several editing API tests to wait for a presentation update following a selection change, programmatic
2337         focus, or showing the font manager.
2338
2339         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
2340         (TestWebKitAPI::TEST):
2341         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewTargetForAction.mm:
2342         (TEST):
2343         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
2344         (TestWebKitAPI::TEST):
2345
2346 2019-04-21  Brian Burg  <bburg@apple.com>
2347
2348         WebDriver: add hooks to make it possible to easily run WPT WebDriver web server by itself
2349         https://bugs.webkit.org/show_bug.cgi?id=197125
2350         <rdar://problem/50061468>
2351
2352         Reviewed by Darin Adler.
2353
2354         Sometimes I want to run wptserve independently of tests. Make it easier to script that
2355         using this class rather than making our own ./wpt serve invocation.
2356
2357         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_web_server.py:
2358         (WebDriverW3CWebServer):
2359         (WebDriverW3CWebServer.document_root): Expose this to clients.
2360         (WebDriverW3CWebServer.wait): Add a method that blocks until the server dies.
2361
2362         (WebDriverW3CWebServer.__enter__):
2363         (WebDriverW3CWebServer.__exit__):
2364         Make it possible to use the web server with a 'with' statement.
2365
2366 2019-04-20  Don Olmstead  <don.olmstead@sony.com>
2367
2368         [CMake][Win] Use target oriented design for WebKitLegacy
2369         https://bugs.webkit.org/show_bug.cgi?id=197112
2370
2371         Reviewed by Konstantin Tokarev.
2372
2373         Fix includes and libraries for DumpRenderTree after changes to WebKitLegacy targets.
2374
2375         * DumpRenderTree/CMakeLists.txt:
2376         * DumpRenderTree/PlatformWin.cmake:
2377         * DumpRenderTree/win/EventSender.cpp:
2378
2379 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
2380
2381         Update text for old EWS submit button
2382         https://bugs.webkit.org/show_bug.cgi?id=197140
2383
2384         Reviewed by Alexey Proskuryakov.
2385
2386         * QueueStatusServer/templates/statusbubble.html:
2387
2388 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
2389
2390         [ews-app] New EWS should poll bugzilla more frequently
2391         https://bugs.webkit.org/show_bug.cgi?id=197138
2392
2393         Reviewed by Alexey Proskuryakov.
2394
2395         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2396         (FetchLoop.__init__):
2397
2398 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
2399
2400         [ews-app] Submit to EWS buttons are not aligned properly with status-bubbles
2401         https://bugs.webkit.org/show_bug.cgi?id=197139
2402
2403         Reviewed by Alexey Proskuryakov.
2404
2405         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
2406         * QueueStatusServer/templates/statusbubble.html:
2407
2408 2019-04-20  Chris Dumez  <cdumez@apple.com>
2409
2410         Unreviewed, fix iOS build with recent SDKs.
2411
2412         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2413
2414 2019-04-19  Keith Miller  <keith_miller@apple.com>
2415
2416         Add script to merge run_benchmark jsons
2417         https://bugs.webkit.org/show_bug.cgi?id=197107
2418
2419         Reviewed by Michael Saboff.
2420
2421         The script basically recursively decends through all json objects until it gets
2422         to an array or JSON primitive and concats or takes the first value, respectively.
2423
2424         This patch also adds +x bits to the compare-results script so it
2425         can be run directly from the command line. I had to add a new line so that svn
2426         will accept the change... yay svn!
2427
2428         * Scripts/compare-results:
2429         * Scripts/merge-result-jsons: Added.
2430         (readJSONFile):
2431         (deepAppend):
2432         (mergeJSONs):
2433         (main):
2434
2435 2019-04-18  Ryosuke Niwa  <rniwa@webkit.org>
2436
2437         Crash in FrameLoader::stopAllLoaders via [WebView dealloc] inside ~ObjCEventListener
2438         https://bugs.webkit.org/show_bug.cgi?id=197079
2439
2440         Reviewed by Darin Adler.
2441
2442         Added a regression test. It hits a slightly different backtrace but of the same class of issues.
2443
2444         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2445         * TestWebKitAPI/Tests/WebKitLegacy/mac/DeallocWebViewInEventListener.mm: Added.
2446
2447 2019-04-18  Commit Queue  <commit-queue@webkit.org>
2448
2449         Unreviewed, rolling out r244434.
2450         https://bugs.webkit.org/show_bug.cgi?id=197089
2451
2452         caused 1 API test failure (Requested by zalan on #webkit).
2453
2454         Reverted changeset:
2455
2456         "Regression (r244291): Broken API Test
2457         AutoLayoutRenderingProgressRelativeOrdering"
2458         https://bugs.webkit.org/show_bug.cgi?id=196948
2459         https://trac.webkit.org/changeset/244434
2460
2461 2019-04-18  Wenson Hsieh  <wenson_hsieh@apple.com>
2462
2463         Add new compatibility mode API on WKNavigation
2464         https://bugs.webkit.org/show_bug.cgi?id=197069
2465         <rdar://problem/50025800>
2466
2467         Reviewed by Tim Horton.
2468
2469         Add a block property for -didCommitNavigation to TestNavigationDelegate.
2470
2471         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
2472         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
2473         (-[TestNavigationDelegate webView:didCommitNavigation:]):
2474
2475 2019-04-18  Don Olmstead  <don.olmstead@sony.com>
2476
2477         [CMake] Make WebCore headers copies
2478         https://bugs.webkit.org/show_bug.cgi?id=182512
2479         <rdar://problem/37510435>
2480
2481         Reviewed by Alex Christensen.
2482
2483         Added WebCorePrivateFrameworkHeaders as a dependency of TestWebKitAPI for all
2484         ports.
2485
2486         WebCore now uses WebCore_PRIVATE_INCLUDE_DIRECTORIES for all ports. Any includes
2487         of WebCore headers using "*.h" were modified to <WebCore/*.h>
2488
2489         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
2490         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h:
2491         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h:
2492         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h:
2493         * TestWebKitAPI/CMakeLists.txt:
2494         * TestWebKitAPI/PlatformWin.cmake:
2495         * TestWebKitAPI/Tests/WebCore/AbortableTaskQueue.cpp:
2496         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp:
2497         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2498
2499 2019-04-18  Jer Noble  <jer.noble@apple.com>
2500
2501         Add support for parsing FairPlayStreaming PSSH boxes.
2502         https://bugs.webkit.org/show_bug.cgi?id=197064
2503
2504         Reviewed by Eric Carlson.
2505
2506         * TestWebKitAPI/Tests/WebCore/ISOBox.cpp:
2507         (TestWebKitAPI::TEST):
2508
2509 2019-04-18  Brent Fulgham  <bfulgham@apple.com>
2510
2511         InjectedBundle parameters often need initialization function called before unarchiving
2512         https://bugs.webkit.org/show_bug.cgi?id=189709
2513         <rdar://problem/44573653>
2514
2515         Reviewed by Ryosuke Niwa.
2516
2517         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
2518         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
2519
2520 2019-04-18  Zalan Bujtas  <zalan@apple.com>
2521
2522         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
2523         https://bugs.webkit.org/show_bug.cgi?id=196948
2524         <rdar://problem/49927131>
2525
2526         Reviewed by Tim Horton.
2527
2528         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
2529         (TEST): 
2530         The expected order of incoming events is
2531         1. didInvalidateIntrinsicContentSize
2532         2. didFirstLayout
2533         At setRenderingProgressDidChange, we already check if didInvalidateIntrinsicContentSize comes in first.
2534         However it's not guaranteed that the milestone event is delayed until after TestWebKitAPI::Util::run() is finished
2535         (and remember, all we care about is ordering).
2536
2537 2019-04-18  Ryan Haddad  <ryanhaddad@apple.com>
2538
2539         Unreviewed, rolling out r244299.
2540
2541         Breaks internal tests.
2542
2543         Reverted changeset:
2544
2545         "InjectedBundle parameters often need initialization function
2546         called before unarchiving"
2547         https://bugs.webkit.org/show_bug.cgi?id=189709
2548         https://trac.webkit.org/changeset/244299
2549
2550 2019-04-18  Yusuke Suzuki  <ysuzuki@apple.com>
2551
2552         [WTF] StringBuilder should set correct m_is8Bit flag when merging
2553         https://bugs.webkit.org/show_bug.cgi?id=197053
2554
2555         Reviewed by Saam Barati.
2556
2557         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2558         (TestWebKitAPI::TEST):
2559
2560 2019-04-17  Tim Horton  <timothy_horton@apple.com>
2561
2562         [iOS Sim Debug] REGRESSION (r244151) TestWebKitAPI.WebKit.OverrideViewportArguments is failing (197028)
2563         https://bugs.webkit.org/show_bug.cgi?id=197028
2564         <rdar://problem/49985290>
2565
2566         Reviewed by Wenson Hsieh.
2567
2568         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm:
2569         (TEST):
2570         Liberal application of waitForNextPresentationUpdate works around a race
2571         where if the page rapidly changes its viewport arguments (or an API client
2572         rapidly changes its viewport arguments), we'd get stuck thinking that the
2573         user had intentionally zoomed the page, and stop resetting the initial scale.
2574         This deserves a separate bug, but no need to keep the test failing while
2575         we think about it.
2576
2577 2019-04-17  Tim Horton  <timothy_horton@apple.com>
2578
2579         REGRESSION (r241988): Switching tabs is slow
2580         https://bugs.webkit.org/show_bug.cgi?id=197037
2581         <rdar://problem/49951473>
2582
2583         Reviewed by Simon Fraser.
2584
2585         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2586         * TestWebKitAPI/Tests/WebKitCocoa/ReparentWebViewTimeout.mm: Added.
2587         (TEST):
2588         * TestWebKitAPI/cocoa/TestWKWebView.h:
2589         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2590         (-[TestWKWebView addToTestWindow]):
2591         Add a test that hangs without this fix.
2592
2593 2019-04-17  Truitt Savell  <tsavell@apple.com>
2594
2595         Unreviewed, rolling out r244400.
2596
2597         Caused testing to exit early with assertionon Debug WK2
2598
2599         Reverted changeset:
2600
2601         "UI↔Web deadlock when printing with a JavaScript alert
2602         visible"
2603         https://bugs.webkit.org/show_bug.cgi?id=196839
2604         https://trac.webkit.org/changeset/244400
2605
2606 2019-04-17  Brady Eidson  <beidson@apple.com>
2607
2608         Link clicks in PDFs shouldn't send referrer headers.
2609         <rdar://problem/21142581> and https://bugs.webkit.org/show_bug.cgi?id=196980
2610
2611         Reviewed by Tim Horton.
2612
2613         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2614         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm: Added.
2615         (putPDFBytesCallback):
2616         (emptyReleaseInfoCallback):
2617         (createPDFWithLinkToURL):
2618         (TEST):
2619
2620 2019-04-17  Tim Horton  <timothy_horton@apple.com>
2621
2622         UI↔Web deadlock when printing with a JavaScript alert visible
2623         https://bugs.webkit.org/show_bug.cgi?id=196839
2624         <rdar://problem/49157642>
2625
2626         Reviewed by Andy Estes.
2627
2628         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2629         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewPrintFormatter.mm: Added.
2630         (-[PrintOnAlertUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2631         (TEST):
2632
2633 2019-04-17  Alex Christensen  <achristensen@webkit.org>
2634
2635         WKRetainPtr's adoption constructor should be private
2636         https://bugs.webkit.org/show_bug.cgi?id=197019
2637
2638         Reviewed by Tim Horton.
2639
2640         * DumpRenderTree/mac/DumpRenderTree.mm:
2641         (dumpFramesAsText):
2642         * TestWebKitAPI/InjectedBundleController.cpp:
2643         (TestWebKitAPI::InjectedBundleController::initialize):
2644         * TestWebKitAPI/PlatformUtilities.cpp:
2645         (TestWebKitAPI::Util::createContextWithInjectedBundle):
2646         (TestWebKitAPI::Util::createInitializationDictionaryForInjectedBundleTest):
2647         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
2648         (TestWebKitAPI::Util::toWK):
2649         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
2650         (TestWebKitAPI::TEST):
2651         * TestWebKitAPI/Tests/WebKit/CloseFromWithinCreatePage.cpp:
2652         (TestWebKitAPI::TEST):
2653         * TestWebKitAPI/Tests/WebKit/CloseThenTerminate.cpp:
2654         (TestWebKitAPI::TEST):
2655         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic.cpp:
2656         (TestWebKitAPI::TEST):
2657         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic_Bundle.cpp:
2658         (TestWebKitAPI::DOMWindowExtensionBasic::initialize):
2659         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache.cpp:
2660         (TestWebKitAPI::TEST):
2661         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache_Bundle.cpp:
2662         (TestWebKitAPI::DOMWindowExtensionNoCache::initialize):
2663         * TestWebKitAPI/Tests/WebKit/DeferredViewInWindowStateChange.mm:
2664         (TestWebKitAPI::TEST):
2665         * TestWebKitAPI/Tests/WebKit/DidNotHandleKeyDown.cpp:
2666         (TestWebKitAPI::TEST):
2667         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
2668         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
2669         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash.cpp:
2670         (TestWebKitAPI::TEST):
2671         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash_Bundle.cpp:
2672         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):
2673         * TestWebKitAPI/Tests/WebKit/EnumerateMediaDevices.cpp:
2674         (TestWebKitAPI::TEST):
2675         * TestWebKitAPI/Tests/WebKit/EphemeralSessionPushStateNoHistoryCallback.cpp:
2676         (TestWebKitAPI::TEST):
2677         * TestWebKitAPI/Tests/WebKit/EvaluateJavaScript.cpp:
2678         (TestWebKitAPI::TEST):
2679         * TestWebKitAPI/Tests/WebKit/EventModifiers.cpp:
2680         (TestWebKitAPI::TEST):
2681         * TestWebKitAPI/Tests/WebKit/FailedLoad.cpp:
2682         (TestWebKitAPI::TEST):
2683         * TestWebKitAPI/Tests/WebKit/Find.cpp:
2684         (TestWebKitAPI::TEST):
2685         * TestWebKitAPI/Tests/WebKit/FindMatches.mm:
2686         (TestWebKitAPI::TEST):
2687         * TestWebKitAPI/Tests/WebKit/FirstMeaningfulPaintMilestone.cpp:
2688         (TestWebKitAPI::TEST):
2689         * TestWebKitAPI/Tests/WebKit/ForceRepaint.cpp:
2690         (TestWebKitAPI::TEST):
2691         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp:
2692         (TestWebKitAPI::TEST):
2693         * TestWebKitAPI/Tests/WebKit/FrameMIMETypeHTML.cpp:
2694         (TestWebKitAPI::TEST):
2695         * TestWebKitAPI/Tests/WebKit/FrameMIMETypePNG.cpp:
2696         (TestWebKitAPI::TEST):
2697         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
2698         (TestWebKitAPI::TEST):
2699         * TestWebKitAPI/Tests/WebKit/GetInjectedBundleInitializationUserDataCallback.cpp:
2700         (TestWebKitAPI::TEST):
2701         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle.cpp:
2702         (TestWebKitAPI::TEST):
2703         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle_Bundle.cpp:
2704         (TestWebKitAPI::HitTestResultNodeHandleTest::getContextMenuFromDefaultMenu):
2705         * TestWebKitAPI/Tests/WebKit/InjectedBundleBasic.cpp:
2706         (TestWebKitAPI::TEST):
2707         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior.cpp:
2708         (TestWebKitAPI::TEST):
2709         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior_Bundle.cpp:
2710         (TestWebKitAPI::InjectedBundleNoDisableOverrideBuiltinsBehaviorTest::initialize):
2711         (TestWebKitAPI::InjectedBundleDisableOverrideBuiltinsBehaviorTest::initialize):
2712         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest.cpp:
2713         (TestWebKitAPI::TEST):
2714         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest_Bundle.cpp:
2715         (TestWebKitAPI::InjectedBundleFrameHitTestTest::frameLoadFinished):
2716         * TestWebKitAPI/Tests/WebKit/InjectedBundleInitializationUserDataCallbackWins.cpp:
2717         (TestWebKitAPI::TEST):
2718         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen.cpp:
2719         (TestWebKitAPI::TEST):
2720         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen_Bundle.cpp:
2721         (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize):
2722         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
2723         (TestWebKitAPI::TEST):
2724         * TestWebKitAPI/Tests/WebKit/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
2725         (TestWebKitAPI::loadAlternateHTMLString):
2726         (TestWebKitAPI::TEST):
2727         * TestWebKitAPI/Tests/WebKit/LoadCanceledNoServerRedirectCallback.cpp:
2728         (TestWebKitAPI::TEST):
2729         * TestWebKitAPI/Tests/WebKit/LoadPageOnCrash.cpp:
2730         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
2731         * TestWebKitAPI/Tests/WebKit/MenuTypesForMouseEvents.cpp:
2732         (TestWebKitAPI::buildAndPerformTest):
2733         * TestWebKitAPI/Tests/WebKit/ModalAlertsSPI.cpp:
2734         (TestWebKitAPI::TEST):
2735         * TestWebKitAPI/Tests/WebKit/MouseMoveAfterCrash.cpp:
2736         (TestWebKitAPI::TEST):
2737         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayout.cpp:
2738         (TestWebKitAPI::TEST):
2739         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFails.cpp:
2740         (TestWebKitAPI::TEST):
2741         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
2742         (TestWebKitAPI::TEST):
2743         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
2744         (TestWebKitAPI::TEST):
2745         * TestWebKitAPI/Tests/WebKit/PageLoadBasic.cpp:
2746         (TestWebKitAPI::TEST):
2747         * TestWebKitAPI/Tests/WebKit/PageLoadDidChangeLocationWithinPageForFrame.cpp:
2748         (TestWebKitAPI::TEST):
2749         * TestWebKitAPI/Tests/WebKit/PasteboardNotifications.mm:
2750         (TestWebKitAPI::TEST):
2751         * TestWebKitAPI/Tests/WebKit/PendingAPIRequestURL.cpp:
2752         (TestWebKitAPI::TEST):
2753         * TestWebKitAPI/Tests/WebKit/PreventEmptyUserAgent.cpp:
2754         (TestWebKitAPI::TEST):
2755         * TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp:
2756         (TestWebKitAPI::TEST):
2757         * TestWebKitAPI/Tests/WebKit/ProcessDidTerminate.cpp:
2758         (TestWebKitAPI::TEST):
2759         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
2760         (TestWebKitAPI::TEST):
2761         * TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:
2762         (TestWebKitAPI::TEST):
2763         * TestWebKitAPI/Tests/WebKit/ResizeWindowAfterCrash.cpp:
2764         (TestWebKitAPI::TEST):
2765         * TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp:
2766         (TestWebKitAPI::TEST):
2767         * TestWebKitAPI/Tests/WebKit/RestoreSessionStateContainingFormData.cpp:
2768         (TestWebKitAPI::TEST):
2769         * TestWebKitAPI/Tests/WebKit/ScrollPinningBehaviors.cpp:
2770         (TestWebKitAPI::TEST):
2771         * TestWebKitAPI/Tests/WebKit/ShouldKeepCurrentBackForwardListItemInList.cpp:
2772         (TestWebKitAPI::TEST):
2773         * TestWebKitAPI/Tests/WebKit/SpacebarScrolling.cpp:
2774         (TestWebKitAPI::TEST):
2775         * TestWebKitAPI/Tests/WebKit/StopLoadingDuringDidFailProvisionalLoad.cpp:
2776         (TestWebKitAPI::TEST):
2777         * TestWebKitAPI/Tests/WebKit/TerminateTwice.cpp:
2778         (TestWebKitAPI::TEST):
2779         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
2780         (TestWebKitAPI::TEST):
2781         * TestWebKitAPI/Tests/WebKit/WKPageCopySessionStateWithFiltering.cpp:
2782         (TestWebKitAPI::TEST):
2783         * TestWebKitAPI/Tests/WebKit/WKPageGetScaleFactorNotZero.cpp:
2784         (TestWebKitAPI::TEST):
2785         * TestWebKitAPI/Tests/WebKit/WKPageIsPlayingAudio.cpp:
2786         (TestWebKitAPI::TEST):
2787         * TestWebKitAPI/Tests/WebKit/WKPreferences.cpp:
2788         (TestWebKitAPI::TEST):
2789         * TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm:
2790         (TestWebKitAPI::TEST):
2791         * TestWebKitAPI/Tests/WebKit/WillSendSubmitEvent.cpp:
2792         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
2793         * TestWebKitAPI/Tests/WebKit/mac/AttributedSubstringForProposedRangeWithImage.mm:
2794         (TestWebKitAPI::TEST):
2795         * TestWebKitAPI/Tests/WebKit/mac/ContextMenuDownload.mm:
2796         (TestWebKitAPI::TEST):
2797         * TestWebKitAPI/Tests/WebKit/mac/CustomBundleParameter.mm:
2798         (TestWebKitAPI::TEST):
2799         * TestWebKitAPI/Tests/WebKit/mac/EditorCommands.mm:
2800         (TestWebKitAPI::TEST):
2801         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
2802         (TestWebKitAPI::TEST):
2803         * TestWebKitAPI/Tests/WebKit/mac/GetPIDAfterAbortedProcessLaunch.cpp:
2804         (TestWebKitAPI::TEST):
2805         * TestWebKitAPI/Tests/WebKit/mac/InjectedBundleAppleEvent.cpp:
2806         (TestWebKitAPI::TEST):
2807         * TestWebKitAPI/Tests/WebKit/mac/RestoreStateAfterTermination.mm:
2808         (TestWebKitAPI::TEST):
2809         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
2810         (TestWebKitAPI::TEST):
2811         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
2812         (TestWebKitAPI::TEST):
2813         * TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm:
2814         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm:
2815         (TEST):
2816         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2817         (TEST):
2818         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2819         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2820         (TEST):
2821         * TestWebKitAPI/Tests/mac/FirstResponderScrollingPosition.mm:
2822         (TestWebKitAPI::TEST):
2823         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
2824         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
2825         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2826         (WTR::getMenuItemTitleCallback):
2827         (WTR::createMouseMessageBody):
2828         (WTR::EventSendingController::mouseDown):
2829         (WTR::EventSendingController::mouseUp):
2830         (WTR::EventSendingController::mouseMoveTo):
2831         (WTR::EventSendingController::mouseForceClick):
2832         (WTR::EventSendingController::startAndCancelMouseForceClick):
2833         (WTR::EventSendingController::mouseForceDown):
2834         (WTR::EventSendingController::mouseForceUp):
2835         (WTR::EventSendingController::mouseForceChanged):
2836         (WTR::EventSendingController::leapForward):
2837         (WTR::EventSendingController::scheduleAsynchronousClick):
2838         (WTR::createKeyDownMessageBody):
2839         (WTR::EventSendingController::keyDown):
2840         (WTR::EventSendingController::scheduleAsynchronousKeyDown):
2841         (WTR::EventSendingController::mouseScrollBy):
2842         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
2843         (WTR::EventSendingController::continuousMouseScrollBy):
2844         (WTR::EventSendingController::addTouchPoint):
2845         (WTR::EventSendingController::updateTouchPoint):
2846         (WTR::EventSendingController::setTouchModifier):
2847         (WTR::EventSendingController::setTouchPointRadius):
2848         (WTR::EventSendingController::touchStart):
2849         (WTR::EventSendingController::touchMove):
2850         (WTR::EventSendingController::touchEnd):
2851         (WTR::EventSendingController::touchCancel):
2852         (WTR::EventSendingController::clearTouchPoints):
2853         (WTR::EventSendingController::releaseTouchPoint):
2854         (WTR::EventSendingController::cancelTouchPoint):
2855         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2856         (WTR::InjectedBundle::didCreatePage):
2857         (WTR::InjectedBundle::didReceiveMessage):
2858         (WTR::InjectedBundle::didReceiveMessageToPage):
2859         (WTR::InjectedBundle::booleanForKey):
2860         (WTR::InjectedBundle::done):
2861         (WTR::InjectedBundle::dumpToStdErr):
2862         (WTR::InjectedBundle::outputText):
2863         (WTR::InjectedBundle::postNewBeforeUnloadReturnValue):
2864         (WTR::InjectedBundle::postAddChromeInputField):
2865         (WTR::InjectedBundle::postRemoveChromeInputField):
2866         (WTR::InjectedBundle::postFocusWebView):
2867         (WTR::InjectedBundle::postSetBackingScaleFactor):
2868         (WTR::InjectedBundle::postSetWindowIsKey):
2869         (WTR::InjectedBundle::postSetViewSize):
2870         (WTR::InjectedBundle::postSimulateWebNotificationClick):
2871         (WTR::InjectedBundle::postSetAddsVisitedLinks):
2872         (WTR::InjectedBundle::setGeolocationPermission):
2873         (WTR::InjectedBundle::setMockGeolocationPosition):
2874         (WTR::InjectedBundle::setMockGeolocationPositionUnavailableError):
2875         (WTR::InjectedBundle::isGeolocationProviderActive const):
2876         (WTR::InjectedBundle::imageCountInGeneralPasteboard const):
2877         (WTR::InjectedBundle::setUserMediaPersistentPermissionForOrigin):
2878         (WTR::InjectedBundle::userMediaPermissionRequestCountForOrigin const):
2879         (WTR::InjectedBundle::resetUserMediaPermissionRequestCountForOrigin):
2880         (WTR::InjectedBundle::setCustomPolicyDelegate):
2881         (WTR::InjectedBundle::setHidden):
2882         (WTR::InjectedBundle::setCacheModel):
2883         (WTR::InjectedBundle::shouldProcessWorkQueue const):
2884         (WTR::InjectedBundle::processWorkQueue):
2885         (WTR::InjectedBundle::queueBackNavigation):
2886         (WTR::InjectedBundle::queueForwardNavigation):
2887         (WTR::InjectedBundle::queueLoad):
2888         (WTR::InjectedBundle::queueLoadHTMLString):
2889         (WTR::InjectedBundle::queueReload):
2890         (WTR::InjectedBundle::queueLoadingScript):
2891         (WTR::InjectedBundle::queueNonLoadingScript):
2892         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2893         (WTR::frameToStr):
2894         (WTR::InjectedBundlePage::InjectedBundlePage):
2895         (WTR::dumpFrameDescriptionSuitableForTestResult):
2896         (WTR::dumpFrameScrollPosition):
2897         (WTR::dumpDescendantFrameScrollPositions):
2898         (WTR::dumpFrameText):
2899         (WTR::dumpDescendantFramesText):
2900         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2901         (WTR::TestRunner::shouldDumpPixels const):
2902         (WTR::TestRunner::setDumpPixels):
2903         (WTR::TestRunner::whatToDump const):
2904         (WTR::TestRunner::setWhatToDump):
2905         (WTR::TestRunner::setWaitUntilDone):
2906         (WTR::TestRunner::shouldWaitUntilDone const):
2907         (WTR::TestRunner::setShouldDumpFrameLoadCallbacks):
2908         (WTR::TestRunner::shouldDumpFrameLoadCallbacks):
2909         (WTR::TestRunner::clearAllDatabases):
2910         (WTR::TestRunner::setIDBPerOriginQuota):
2911         (WTR::TestRunner::originsWithApplicationCache):
2912         (WTR::TestRunner::setCanOpenWindows):
2913         (WTR::TestRunner::setXSSAuditorEnabled):
2914         (WTR::TestRunner::setMediaDevicesEnabled):
2915         (WTR::TestRunner::setWebRTCMDNSICECandidatesEnabled):
2916         (WTR::TestRunner::setWebRTCUnifiedPlanEnabled):
2917         (WTR::TestRunner::setCustomUserAgent):
2918         (WTR::TestRunner::setWebAPIStatisticsEnabled):
2919         (WTR::TestRunner::setModernMediaControlsEnabled):
2920         (WTR::TestRunner::setWebGL2Enabled):
2921         (WTR::TestRunner::setWritableStreamAPIEnabled):
2922         (WTR::TestRunner::setReadableByteStreamAPIEnabled):
2923         (WTR::TestRunner::setEncryptedMediaAPIEnabled):
2924         (WTR::TestRunner::setAllowsAnySSLCertificate):
2925         (WTR::TestRunner::setPluginsEnabled):
2926         (WTR::TestRunner::setValueForUser):
2927         (WTR::TestRunner::setAudioResult):
2928         (WTR::TestRunner::didReceiveServerRedirectForProvisionalNavigation const):
2929         (WTR::TestRunner::clearDidReceiveServerRedirectForProvisionalNavigation):
2930         (WTR::TestRunner::setAlwaysAcceptCookies):
2931         (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
2932         (WTR::TestRunner::isDoingMediaCapture const):
2933         (WTR::TestRunner::queueLoad):
2934         (WTR::TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
2935         (WTR::TestRunner::setHandlesAuthenticationChallenges):
2936         (WTR::TestRunner::setShouldLogCanAuthenticateAgainstProtectionSpace):
2937         (WTR::TestRunner::setShouldLogDownloadCallbacks):
2938         (WTR::TestRunner::setAuthenticationUsername):
2939         (WTR::TestRunner::setAuthenticationPassword):
2940         (WTR::TestRunner::secureEventInputIsEnabled const):
2941         (WTR::TestRunner::setBlockAllPlugins):
2942         (WTR::TestRunner::setPluginSupportedMode):
2943         (WTR::TestRunner::setShouldDecideNavigationPolicyAfterDelay):
2944         (WTR::TestRunner::setShouldDecideResponsePolicyAfterDelay):
2945         (WTR::TestRunner::setNavigationGesturesEnabled):
2946         (WTR::TestRunner::setIgnoresViewportScaleLimits):
2947         (WTR::TestRunner::setShouldDownloadUndisplayableMIMETypes):
2948         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
2949         (WTR::TestRunner::terminateNetworkProcess):
2950         (WTR::TestRunner::terminateServiceWorkerProcess):
2951         (WTR::TestRunner::runUIScript):
2952         (WTR::TestRunner::setStatisticsDebugMode):
2953         (WTR::TestRunner::setStatisticsPrevalentResourceForDebugMode):
2954         (WTR::TestRunner::setStatisticsLastSeen):
2955         (WTR::TestRunner::setStatisticsPrevalentResource):
2956         (WTR::TestRunner::setStatisticsVeryPrevalentResource):
2957         (WTR::TestRunner::dumpResourceLoadStatistics):
2958         (WTR::TestRunner::isStatisticsPrevalentResource):
2959         (WTR::TestRunner::isStatisticsVeryPrevalentResource):
2960         (WTR::TestRunner::isStatisticsRegisteredAsSubresourceUnder):
2961         (WTR::TestRunner::isStatisticsRegisteredAsSubFrameUnder):
2962         (WTR::TestRunner::isStatisticsRegisteredAsRedirectingTo):
2963         (WTR::TestRunner::setStatisticsHasHadUserInteraction):
2964         (WTR::TestRunner::isStatisticsHasHadUserInteraction):
2965         (WTR::TestRunner::setStatisticsGrandfathered):
2966         (WTR::TestRunner::isStatisticsGrandfathered):
2967         (WTR::TestRunner::setStatisticsSubframeUnderTopFrameOrigin):
2968         (WTR::TestRunner::setStatisticsSubresourceUnderTopFrameOrigin):
2969         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectTo):
2970         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectFrom):
2971         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectTo):
2972         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectFrom):
2973         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
2974         (WTR::TestRunner::setStatisticsTimeToLiveUserInteraction):
2975         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback):
2976         (WTR::TestRunner::statisticsProcessStatisticsAndDataRecords):
2977         (WTR::TestRunner::statisticsUpdateCookieBlocking):
2978         (WTR::TestRunner::statisticsSubmitTelemetry):
2979         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
2980         (WTR::TestRunner::setStatisticsIsRunningTest):
2981         (WTR::TestRunner::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
2982         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
2983         (WTR::TestRunner::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
2984         (WTR::TestRunner::setStatisticsGrandfatheringTime):
2985         (WTR::TestRunner::setStatisticsMaxStatisticsEntries):
2986         (WTR::TestRunner::setStatisticsPruneEntriesDownTo):
2987         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
2988         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
2989         (WTR::TestRunner::statisticsClearThroughWebsiteDataRemoval):
2990         (WTR::TestRunner::statisticsDeleteCookiesForHost):
2991         (WTR::TestRunner::setStatisticsCacheMaxAgeCap):
2992         (WTR::TestRunner::statisticsResetToConsistentState):
2993         (WTR::TestRunner::setStorageAccessAPIEnabled):
2994         (WTR::TestRunner::getAllStorageAccessEntries):
2995         (WTR::TestRunner::addMockMediaDevice):
2996         (WTR::TestRunner::clearMockMediaDevices):
2997         (WTR::TestRunner::removeMockMediaDevice):
2998         (WTR::TestRunner::resetMockMediaDevices):
2999         (WTR::TestRunner::connectMockGamepad):
3000         (WTR::TestRunner::disconnectMockGamepad):
3001         (WTR::TestRunner::setMockGamepadDetails):
3002         (WTR::TestRunner::setMockGamepadAxisValue):
3003         (WTR::TestRunner::setMockGamepadButtonValue):
3004         (WTR::TestRunner::removeAllSessionCredentials):
3005         (WTR::TestRunner::clearDOMCache):
3006         (WTR::TestRunner::clearDOMCaches):
3007         (WTR::TestRunner::hasDOMCache):
3008         (WTR::TestRunner::domCacheSize):
3009         (WTR::TestRunner::setAllowStorageQuotaIncrease):
3010         (WTR::TestRunner::getApplicationManifestThen):
3011         (WTR::TestRunner::injectUserScript):
3012         (WTR::TestRunner::sendDisplayConfigurationChangedMessageForTesting):
3013         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
3014         (WTR::TestRunner::addTestKeyToKeychain):
3015         (WTR::TestRunner::cleanUpKeychain):
3016         (WTR::TestRunner::keyExistsInKeychain):
3017         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
3018         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
3019         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
3020         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
3021         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
3022         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
3023         * WebKitTestRunner/TestController.cpp:
3024         (WTR::TestController::initialize):
3025         (WTR::parseStringTestHeaderValueAsRelativePath):
3026         (WTR::updateTestOptionsFromTestHeader):
3027         (WTR::TestController::runTest):
3028         (WTR::TestController::didReceiveLiveDocumentsList):
3029         (WTR::TestController::didReceiveMessageFromInjectedBundle):
3030         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
3031         (WTR::TestController::didFinishNavigation):
3032         (WTR::TestController::didReceiveAuthenticationChallenge):
3033         * WebKitTestRunner/TestInvocation.cpp:
3034         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3035         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3036         (WTR::TestInvocation::uiScriptDidComplete):
3037         (WTR::TestInvocation::didReceiveAllStorageAccessEntries):
3038         * WebKitTestRunner/WebNotificationProvider.cpp:
3039         (WTR::WebNotificationProvider::closeWebNotification):
3040         * WebKitTestRunner/WorkQueueManager.cpp:
3041         (WTR::ScriptItem::ScriptItem):
3042         (WTR::WorkQueueManager::queueLoad):
3043         (WTR::WorkQueueManager::queueLoadHTMLString):
3044
3045 2019-04-17  Alex Christensen  <achristensen@webkit.org>
3046
3047         Add a comment to make my test from r244139 less mysterious.
3048         https://bugs.webkit.org/show_bug.cgi?id=196744
3049
3050         As suggested by Darin Adler.
3051
3052         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
3053         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
3054
3055 2019-04-17  Chris Dumez  <cdumez@apple.com>
3056
3057         Remember device orientation permission for the duration of the browsing session
3058         https://bugs.webkit.org/show_bug.cgi?id=196992
3059         <rdar://problem/49946067>
3060
3061         Reviewed by Alex Christensen.
3062
3063         Add API test coverage.
3064
3065         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:
3066         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3067         (TEST):
3068
3069 2019-04-17  Aakash Jain  <aakash_jain@apple.com>
3070
3071         [ews-app] Clicking 'submit to new ews' doesn't reload status-bubble
3072         https://bugs.webkit.org/show_bug.cgi?id=196675
3073
3074         Reviewed by Lucas Forschler.
3075
3076         * BuildSlaveSupport/ews-app/ews/views/submittoews.py:
3077         (SubmitToEWS): Added @xframe_options_exempt similar to statusbubble.py
3078
3079 2019-04-16  Wenson Hsieh  <wenson_hsieh@apple.com>
3080
3081         [iOS] [WebKit2] Add support for honoring -[UIMenuItem dontDismiss]
3082         https://bugs.webkit.org/show_bug.cgi?id=196919
3083         <rdar://problem/41630459>
3084
3085         Reviewed by Tim Horton.
3086
3087         Add iOS support for several new testing hooks. See below for more detail.
3088
3089         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3090         (WTR::UIScriptController::isDismissingMenu const):
3091
3092         Add a new script controller method to query whether the platform menu (on iOS, the callout bar) is done
3093         dismissing. We consider the menu to be dismissing in between the `-WillHide` and `-DidHide` notifications sent
3094         by UIKit when dismissing the callout bar (i.e. UIMenuController).
3095
3096         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3097         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3098         (WTR::UIScriptController::isDismissingMenu const):
3099         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3100         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3101         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3102         (WTR::InjectedBundle::didReceiveMessageToPage):
3103         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3104         (WTR::TestRunner::setAllowedMenuActions):
3105
3106         Add a new helper method to specify a list of allowed actions when bringing up the menu. On iOS, in the case of
3107         actions supported by the platform, this matches against method selector names (for instance, "SelectAll", or
3108         "Copy", or "Paste"). In the case of the custom actions installed via `installCustomMenuAction`, we instead match
3109         against the name of the custom action.
3110
3111         (WTR::TestRunner::installCustomMenuAction):
3112
3113         Add a new helper method to install a custom action for the context menu (on iOS, this is the callout bar). This
3114         takes the name of the action (which appears in a button in the callout bar), whether the action should cause
3115         the callout bar to automatically dismiss, and finally, a JavaScript callback that is invoked when the action is
3116         triggered.
3117
3118         (WTR::TestRunner::performCustomMenuAction):
3119
3120         Invoked when the custom menu action is triggered.
3121
3122         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3123         * WebKitTestRunner/TestController.cpp:
3124         (WTR::TestController::installCustomMenuAction):
3125         (WTR::TestController::setAllowedMenuActions):
3126         * WebKitTestRunner/TestController.h:
3127         * WebKitTestRunner/TestInvocation.cpp:
3128         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3129         (WTR::TestInvocation::performCustomMenuAction):
3130
3131         Add plumbing to call back into the injected bundle when performing the custom action.
3132
3133         * WebKitTestRunner/TestInvocation.h:
3134         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3135         (WTR::TestController::installCustomMenuAction):
3136         (WTR::TestController::setAllowedMenuActions):
3137         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3138         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3139         (-[TestRunnerWKWebView initWithFrame:configuration:]):
3140         (-[TestRunnerWKWebView becomeFirstResponder]):
3141         (-[TestRunnerWKWebView _addCustomItemToMenuControllerIfNecessary]):
3142
3143         Helper method that converts web view's current custom menu action info into a UIMenuItem, and adds it to the
3144         shared menu controller. This is also invoked when the web view becomes first responder, which matches behavior
3145         in the Mail app on iOS.
3146
3147         (-[TestRunnerWKWebView installCustomMenuAction:dismissesAutomatically:callback:]):
3148         (-[TestRunnerWKWebView setAllowedMenuActions:]):
3149         (-[TestRunnerWKWebView resetCustomMenuAction]):
3150         (-[TestRunnerWKWebView performCustomAction:]):
3151         (-[TestRunnerWKWebView canPerformAction:withSender:]):
3152         (-[TestRunnerWKWebView _willHideMenu]):
3153         (-[TestRunnerWKWebView _didHideMenu]):
3154         * WebKitTestRunner/ios/TestControllerIOS.mm:
3155         (WTR::TestController::platformResetStateToConsistentValues):
3156
3157         Reset both any custom installed actions on the shared menu controller, as well as the list of allowed actions,
3158         if specified.
3159
3160         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3161         (WTR::UIScriptController::isDismissingMenu const):
3162
3163 2019-04-16  Megan Gardner  <megan_gardner@apple.com>
3164
3165         Allow sharing from imageSheet on an image document
3166         https://bugs.webkit.org/show_bug.cgi?id=196891
3167         <rdar://problem/25377386>
3168
3169         Reviewed by Tim Horton.
3170
3171         Test to make sure that the correct imageURL is extracted from an image element.
3172
3173         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
3174         (TestWebKitAPI::TEST):
3175
3176 2019-04-16  Alex Christensen  <achristensen@webkit.org>
3177
3178         REGRESSION(r244162) Clearing website data from ephemeral WKWebsiteDataStore should finish instead of asserting or hanging
3179         https://bugs.webkit.org/show_bug.cgi?id=196995
3180
3181         Reviewed by Brady Eidson.
3182
3183         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
3184         (TEST):
3185
3186 2019-04-16  Chris Dumez  <cdumez@apple.com>
3187
3188         URL set by document.open() is not communicated to the UIProcess
3189         https://bugs.webkit.org/show_bug.cgi?id=196941
3190         <rdar://problem/49237544>
3191
3192         Reviewed by Geoff Garen.
3193
3194         Add API test coverage.
3195
3196         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3197         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
3198         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
3199         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
3200         (TEST):
3201
3202 2019-04-16  Commit Queue  <commit-queue@webkit.org>
3203
3204         Unreviewed, rolling out r244321.
3205         https://bugs.webkit.org/show_bug.cgi?id=196968
3206
3207         Causing all WK2 Debug builds to exit early after Assertion
3208         failures. (Requested by ShawnRoberts on #webkit).
3209
3210         Reverted changeset:
3211
3212         "URL set by document.open() is not communicated to the
3213         UIProcess"
3214         https://bugs.webkit.org/show_bug.cgi?id=196941
3215         https://trac.webkit.org/changeset/244321
3216
3217 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
3218
3219         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
3220         https://bugs.webkit.org/show_bug.cgi?id=196948
3221
3222         Reviewed by Zalan Bujtas.
3223
3224         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
3225         (TEST): Disabling the test for now to keep infrastructure happy, while the root-cause is being investigated.
3226
3227 2019-04-15  Chris Dumez  <cdumez@apple.com>
3228
3229         URL set by document.open() is not communicated to the UIProcess
3230         https://bugs.webkit.org/show_bug.cgi?id=196941
3231         <rdar://problem/49237544>
3232
3233         Reviewed by Geoffrey Garen.
3234
3235         Add API test coverage.
3236
3237         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3238         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
3239         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
3240         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
3241         (TEST):
3242
3243 2019-04-15  Dean Johnson  <dean_johnson@apple.com>
3244
3245         Using Tools/Scripts/clean-webkit should not install requests
3246         https://bugs.webkit.org/show_bug.cgi?id=196940
3247
3248         Reviewed by Lucas Forschler.
3249
3250         * Scripts/webkitpy/common/system/autoinstall.py: Drive-by fix for no logging handlers
3251         existing, depending on the path autoinstalled is run through.
3252         * Scripts/webkitpy/port/base.py: Import webkitpy.results.upload.Upload only where it's
3253         needed.
3254         (Port.configuration_for_upload):
3255         (Port.commits_for_upload):
3256
3257 2019-04-15  Alex Christensen  <achristensen@webkit.org>
3258
3259         Add a DiagnosticLogging method taking an arbitrary dictionary of values.
3260         https://bugs.webkit.org/show_bug.cgi?id=196773
3261
3262         Reviewed by Jer Noble.
3263
3264         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewDiagnosticLogging.mm:
3265         (-[TestLoggingDelegate _webView:logDiagnosticMessage:description:valueDictionary:]):
3266         (TEST):
3267
3268 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
3269
3270         ews-build should clearly indicate flaky test failures
3271         https://bugs.webkit.org/show_bug.cgi?id=196947
3272
3273         Reviewed by Lucas Forschler.
3274
3275         * BuildSlaveSupport/ews-build/steps.py:
3276         (AnalyzeAPITestsResults.analyzeResults):
3277
3278 2019-04-15  Brent Fulgham  <bfulgham@apple.com>
3279
3280         InjectedBundle parameters often need initialization function called before unarchiving
3281         https://bugs.webkit.org/show_bug.cgi?id=189709
3282         <rdar://problem/44573653>
3283
3284         Reviewed by Ryosuke Niwa.
3285
3286         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
3287         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
3288
3289 2019-04-12  Ryosuke Niwa  <rniwa@webkit.org>
3290
3291         HashTable::removeIf always shrinks the hash table by half even if there is nothing left
3292         https://bugs.webkit.org/show_bug.cgi?id=196681
3293
3294         Reviewed by Darin Adler.
3295
3296         Added tests.
3297
3298         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
3299         (WTF_HashSet.RemoveIf):
3300         (WTF_HashSet.RemoveIfShrinkToBestSize):
3301
3302 2019-04-15  John Wilander  <wilander@apple.com>
3303
3304         Send delayed Ad Click Attribution conversion requests to the click source
3305         https://bugs.webkit.org/show_bug.cgi?id=196838
3306         <rdar://problem/47650157>
3307
3308         Reviewed by Chris Dumez and Youenn Fablet.
3309
3310         This patch adds test infrastructure to override the default behavior in
3311         WebKit::NetworkAdClickAttribution.
3312
3313         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3314         (TestWebKitAPI::TEST):
3315         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3316         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3317         (WTR::TestRunner::dumpAdClickAttribution):
3318         (WTR::TestRunner::clearAdClickAttribution):
3319         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
3320         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
3321         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3322         * WebKitTestRunner/TestController.cpp:
3323         (WTR::TestController::setAdClickAttributionOverrideTimerForTesting):
3324         (WTR::TestController::setAdClickAttributionConversionURLForTesting):
3325         * WebKitTestRunner/TestController.h:
3326         * WebKitTestRunner/TestInvocation.cpp:
3327         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3328
3329 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
3330
3331         [ews-app] status-bubble should display position in queue
3332         https://bugs.webkit.org/show_bug.cgi?id=196607
3333
3334         Reviewed by Lucas Forschler.
3335
3336         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3337         (StatusBubble._build_bubble):
3338         (StatusBubble._queue_position): Method to calculate patch's position in queue.
3339
3340 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
3341
3342         [ews-build] Do not run clean build by default on EWS builders
3343         https://bugs.webkit.org/show_bug.cgi?id=196897
3344
3345         Reviewed by Lucas Forschler.
3346
3347         * BuildSlaveSupport/ews-build/steps.py:
3348         (ApplyPatch.start): Do not create .buildbot-patched file. This is a special file for Buildbot and if this
3349         file is present, during the Source checkout, Buildbot cleans the working directory completely (including removing 
3350         untracked directories like WebKitBuild).
3351         (CheckOutSource.__init__): Pass method=clean so that Buildbot clean the working directory. This does not remove
3352         untracked files/directories (like WebKitBuild).
3353
3354 2019-04-15  Per Arne Vollan  <pvollan@apple.com>
3355
3356         TestRunner::notifyDone() should be safely reentrant
3357         https://bugs.webkit.org/show_bug.cgi?id=196898
3358
3359         Reviewed by Darin Adler.
3360
3361         It is currently possible that TestRunner::notifyDone() will call itself, since
3362         notifyDone() will force a repaint, which can start executing JavaScript, which
3363         may call notifyDone() again. This can lead to test failures and flakiness.
3364         Fix this by setting the m_waitToDump flag before calling the dump() method.
3365
3366         * DumpRenderTree/mac/TestRunnerMac.mm:
3367         (TestRunner::notifyDone):
3368         (TestRunner::forceImmediateCompletion):
3369         * DumpRenderTree/win/TestRunnerWin.cpp:
3370         (TestRunner::notifyDone):
3371         (TestRunner::forceImmediateCompletion):
3372
3373 2019-04-15  Philippe Normand  <pnormand@igalia.com>
3374
3375         [GTK][WPE] Add enable-media websetting
3376         https://bugs.webkit.org/show_bug.cgi?id=196863
3377
3378         Reviewed by Michael Catanzaro.
3379
3380         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
3381         (testWebKitSettings): Add test for the enable-media web-setting.
3382
3383 2019-04-14  Wenson Hsieh  <wenson_hsieh@apple.com>
3384
3385         API test WKAttachmentTests.AddAttachmentToConnectedImageElement is a flaky failure on Mac Release builds
3386         https://bugs.webkit.org/show_bug.cgi?id=196905
3387         <rdar://problem/49886096>
3388
3389         Reviewed by Tim Horton.
3390
3391         This flaky test exercises a race condition between when attachment insertion updates are dispatched from the web
3392         process to the UI process, and when script is executed via -[WKWebView evaluateJavaScript:completionHandler:].
3393         Since attachment insertion and removal updates from the web process to the UI process are scheduled on a zero-
3394         delay timer, we end up with this sequence of events in the problematic (failure) case:
3395
3396         (a) [UI]    Run script #1 (which calls `HTMLAttachmentElement.getAttachmentIdentifier`)
3397             ...IPC from UI to web process...
3398         (b) [Web]   Evaluate script #1 in the web process, which schedules attachment updates on a zero-delay timer
3399             ...IPC from web to UI process...
3400         (c) [UI]    Invoke completion handler for script #1
3401         (d) [UI]    Run script #2 (which calls `document.querySelector('img').attachmentIdentifier`)
3402             ...IPC from UI to web process...
3403         (e) [Web]   Evaluate script #2 in the web process
3404         (f) [Web]   Zero-delay timer fires and dispatches attachment updates to the UI process
3405
3406         ...which means that script #2 will complete before the UI process has received the attachment updates sent in
3407         step (f). However, in the case where the flaky test succeeds, the zero-delay timer in (f) fires *before* script
3408         #2 is run in step (e).
3409
3410         This patch fixes the flaky test by waiting until attachment insertion updates are guaranteed to be received in
3411         the UI process by waiting on a script message posted by the web process, after attachment updates are
3412         dispatched.
3413
3414         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3415         (TestWebKitAPI::TEST):
3416
3417 2019-04-14  Aakash Jain  <aakash_jain@apple.com>
3418
3419         Disable Flaky API Test WKAttachmentTests.AddAttachmentToConnectedImageElement
3420         https://bugs.webkit.org/show_bug.cgi?id=196909
3421
3422         Reviewed by Wenson Hsieh.
3423
3424         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3425         (TestWebKitAPI::TEST):
3426
3427 2019-04-13  Tadeu Zagallo  <tzagallo@apple.com>
3428
3429         CodeCache should check that the UnlinkedCodeBlock was successfully created before caching it
3430         https://bugs.webkit.org/show_bug.cgi?id=196880
3431
3432         Reviewed by Yusuke Suzuki.
3433
3434         Add a new function for bytecode cache tests that does not forceDiskCache
3435         for the second run: runBytecodeCacheNoAssetion. This is necessary for the
3436         test added in this patch, since the code is invalid and therefore won't be
3437         cached. It should also be useful for tests that evaluate dynamically
3438         generated code.
3439
3440         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
3441         * Scripts/run-jsc-stress-tests:
3442
3443 2019-04-12  Eric Carlson  <eric.carlson@apple.com>
3444
3445         Update AudioSession route sharing policy
3446         https://bugs.webkit.org/show_bug.cgi?id=196776
3447         <rdar://problem/46501611>
3448
3449         Reviewed by Jer Noble.
3450
3451         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
3452         (TestWebKitAPI::routeSharingPolicyLongFormVideo):
3453         (TestWebKitAPI::routeSharingPolicyLongFormAudio):
3454         (TestWebKitAPI::TEST):
3455
3456 2019-04-12  Wenson Hsieh  <wenson_hsieh@apple.com>
3457
3458         [iOS] Software keyboard is shown too frequently on some websites
3459         https://bugs.webkit.org/show_bug.cgi?id=195856
3460         <rdar://problem/49191395>
3461
3462         Reviewed by Darin Adler.
3463
3464         Add support for attaching or detaching the hardware keyboard on iOS in layout tests.
3465
3466         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3467         (WTR::UIScriptController::setHardwareKeyboardAttached):
3468         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3469         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3470         (WTR::UIScriptController::setHardwareKeyboardAttached):
3471         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3472         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
3473
3474         Additionally link against GraphicsServices in WebKitTestRunner.
3475
3476         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3477         (WTR::TestController::platformResetStateToConsistentValues):
3478         (WTR::UIScriptController::setHardwareKeyboardAttached):
3479
3480 2019-04-12  Ludovico de Nittis  <ludovico.denittis@collabora.com>
3481
3482         [GTK][WPE] Fix pacman install-dependencies packages
3483         https://bugs.webkit.org/show_bug.cgi?id=196817
3484
3485         Reviewed by Žan Doberšek.
3486         
3487         python3-setuptools is called python-setuptools
3488         ruby-highline is only available on AUR
3489         libv4l-devel is incorporated in v4l-utils
3490
3491         * gtk/install-dependencies:
3492         * wpe/install-dependencies:
3493
3494 2019-04-11  Carlos Garcia Campos  <cgarcia@igalia.com>
3495
3496         [GTK] REGRESSION(r243860): Many tests failing
3497         https://bugs.webkit.org/show_bug.cgi?id=196791
3498
3499         Reviewed by Joanmarie Diggs.
3500
3501         Rework the accessibility unit test to use DBus for the communication with the server. This way we can load
3502         multiple documents and check that accessibility hierarchy is updated after a navigation.
3503
3504         * TestWebKitAPI/Tests/WebKitGtk/AccessibilityTestServer.cpp:
3505         (loadChangedCallback):
3506         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
3507         (AccessibilityTest::AccessibilityTest):
3508         (AccessibilityTest::~AccessibilityTest):
3509         (AccessibilityTest::loadHTMLAndWaitUntilFinished):
3510         (AccessibilityTest::findTestServerApplication):
3511         (AccessibilityTest::findDocumentWeb):
3512         (AccessibilityTest::findRootObject):
3513         (AccessibilityTest::waitUntilChildrenRemoved):
3514         (AccessibilityTest::ensureProxy):
3515         (testAtspiBasicHierarchy):
3516         (beforeAll):
3517         (afterAll):
3518
3519 2019-04-11  Aakash Jain  <aakash_jain@apple.com>
3520
3521         [ews-build] Handle bug titles with unicode characters
3522         https://bugs.webkit.org/show_bug.cgi?id=196802
3523
3524         Reviewed by Dewei Zhu.
3525
3526         * BuildSlaveSupport/ews-build/steps.py:
3527         (ValidatePatch._is_bug_closed):
3528
3529 2019-04-11  Michael Saboff  <msaboff@apple.com>
3530
3531         Improve the Inline Cache Stats code
3532         https://bugs.webkit.org/show_bug.cgi?id=196836
3533
3534         Reviewed by Saam Barati.
3535
3536         Added a new script to consolidate and arrange the output of --useICStats option.
3537
3538         This script merges the output from every group into one large table and sorts it from most common to
3539         least common.  It also counts the slow path GetById and PutById variants and then calculates the
3540         percentage of gets or puts for each unique base,property pair compared to all the gets and puts.
3541         Put together, this is useful to see what property accesses are not getting cached.
3542
3543         * Scripts/ic-stats.py: Added.
3544         (ICStats):
3545         (ICStats.__init__):
3546         (ICStats.parse):
3547         (ICStats.dumpStats):
3548         (usage):
3549
3550 2019-04-10  Alex Christensen  <achristensen@webkit.org>
3551
3552         WKNavigationResponse._downloadAttribute should be nil when no download attribute is present
3553         https://bugs.webkit.org/show_bug.cgi?id=196809
3554         <rdar://49800762>
3555
3556         Reviewed by Brady Eidson.
3557
3558         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
3559         (TEST):
3560
3561 2019-04-10  Said Abou-Hallawa  <sabouhallawa@apple.com>
3562
3563         requestAnimationFrame should execute before the next frame
3564         https://bugs.webkit.org/show_bug.cgi?id=177484
3565
3566         Reviewed by Simon Fraser.
3567
3568         Add trace points for the page RenderingUpdate.
3569
3570         * Tracing/SystemTracePoints.plist:
3571
3572 2019-04-10  Fujii Hironori  <Hironori.Fujii@sony.com>
3573
3574         [Win] Use a bundled vswhere.exe instead of downloading by update-vswhere.py
3575         https://bugs.webkit.org/show_bug.cgi?id=196760
3576
3577         Reviewed by Don Olmstead.
3578
3579         vswhere.exe has been bundled since Visual Studio 2017 version
3580         15.2. We shouldn't download vswhere.exe.
3581
3582         * Scripts/build-jsc: Do not call update-vswhere.py.
3583         * Scripts/build-webkit: Ditto.
3584         * Scripts/update-vswhere.py: Removed.
3585         * Scripts/webkitdirs.pm:
3586         (requireModulesForVSWhere): Deleted.
3587         (pickCurrentVisualStudioInstallation): Deleted.
3588         (visualStudioInstallDirVSWhere): Return the latest installed VS
3589         installation path by using the bundled vswhere.exe.
3590         (setupCygwinEnv): Removed a unused variable $visualStudioPath.
3591         (visualStudioInstallDirFallback): Removed.
3592
3593 2019-04-10  Aakash Jain  <aakash_jain@apple.com>
3594
3595         [ews-build] PrintConfiguration should display Xcode version instead of SDKVersion
3596         https://bugs.webkit.org/show_bug.cgi?id=196780
3597
3598         Reviewed by Alexey Proskuryakov.
3599
3600         * BuildSlaveSupport/ews-build/steps.py:
3601         * BuildSlaveSupport/ews-build/steps_unittest.py:
3602
3603 2019-04-10  Alex Christensen  <achristensen@webkit.org>
3604
3605         Add SPI WKNavigationResponse._downloadAttribute
3606         https://bugs.webkit.org/show_bug.cgi?id=196755
3607         <rdar://49587365>
3608
3609         Reviewed by Brady Eidson.
3610
3611         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
3612         (-[NavigationResponseTestDelegate navigationResponse]):
3613         (-[NavigationResponseTestDelegate waitForNavigationResponseCallback]):
3614         (-[NavigationResponseTestDelegate waitForNavigationFinishedCallback]):
3615         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3616         (-[NavigationResponseTestDelegate webView:didFinishNavigation:]):
3617         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3618         (readRequest):
3619         (writeResponse):
3620         (TEST):
3621
3622 2019-04-10  Tim Horton  <timothy_horton@apple.com>
3623
3624         Add modern API for overriding the page's specified viewport configuration
3625         https://bugs.webkit.org/show_bug.cgi?id=167734
3626         <rdar://problem/30331795>
3627
3628         Reviewed by Simon Fraser.
3629
3630         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3631         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm: Added.
3632
3633 2019-04-10  Tadeu Zagallo  <tzagallo@apple.com>
3634
3635         Add support for incremental bytecode cache updates
3636         https://bugs.webkit.org/show_bug.cgi?id=195000
3637
3638         Reviewed by Filip Pizlo.
3639
3640         Exit when the initial run to generate bytecode fails.
3641
3642         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
3643
3644 2019-04-10  Alex Christensen  <achristensen@webkit.org>
3645
3646         RemoteObjectRegistry message receiver should be removed when WebPage::close is called instead of waiting until dealloc
3647         https://bugs.webkit.org/show_bug.cgi?id=196744
3648         <rdar://49415309>
3649
3650         Reviewed by Chris Dumez.
3651
3652         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
3653         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
3654
3655 2019-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
3656
3657         Add a way to opt into modern compatibility mode in layout tests
3658         https://bugs.webkit.org/show_bug.cgi?id=196770