Add a test to ensure that we dispatch keydown and keyup events when multiple keys...
[WebKit-https.git] / Tools / ChangeLog
1 2019-08-12  Daniel Bates  <dabates@apple.com>
2
3         Add a test to ensure that we dispatch keydown and keyup events when multiple keys are pressed at the same time
4         https://bugs.webkit.org/show_bug.cgi?id=200548
5
6         Reviewed by Darin Adler.
7
8         Expose infrastructure to simulate a literal raw key down and a literal key up event.
9
10         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
11         * TestRunnerShared/UIScriptContext/UIScriptController.h:
12         (WTR::UIScriptController::rawKeyDown):
13         (WTR::UIScriptController::rawKeyUp):
14         * WebKitTestRunner/ios/UIScriptControllerIOS.h:
15         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
16         (WTR::UIScriptControllerIOS::rawKeyDown):
17         (WTR::UIScriptControllerIOS::rawKeyUp):
18
19 2019-08-12  Thibault Saunier  <tsaunier@igalia.com>
20
21         [GStreamer][WebRTC] Handle broken data in the libwebrtc GStreamer decoders
22         https://bugs.webkit.org/show_bug.cgi?id=200584
23
24         Reviewed by Philippe Normand.
25
26         Added a h264parse patch to post WARNING on the bus when a broken frame is detected.
27         Ignore style libwebrtc optionnal 'style issue'
28
29         * Scripts/webkitpy/style/checker.py:
30         * gstreamer/jhbuild.modules:
31         * gstreamer/patches/gst-plugins-bad-0001-h264parse-Post-a-WARNING-when-data-is-broken.patch: Added.
32
33 2019-08-12  Youenn Fablet  <youenn@apple.com>
34
35         Remove IDB-specific quota
36         https://bugs.webkit.org/show_bug.cgi?id=196545
37
38         Reviewed by Alex Christensen.
39
40         * DumpRenderTree/TestRunner.cpp:
41         (TestRunner::staticFunctions):
42         (setIDBPerOriginQuotaCallback): Deleted.
43         * DumpRenderTree/TestRunner.h:
44         * DumpRenderTree/mac/DumpRenderTree.mm:
45         (runTest):
46         * DumpRenderTree/mac/TestRunnerMac.mm:
47         (TestRunner::setIDBPerOriginQuota): Deleted.
48         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
49         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
50         (WTR::TestRunner::setIDBPerOriginQuota): Deleted.
51         * WebKitTestRunner/InjectedBundle/TestRunner.h:
52         * WebKitTestRunner/TestController.cpp:
53         (WTR::TestController::resetStateToConsistentValues):
54         (WTR::TestController::setIDBPerOriginQuota): Deleted.
55         * WebKitTestRunner/TestController.h:
56         * WebKitTestRunner/TestInvocation.cpp:
57         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
58
59 2019-08-10  Alexey Proskuryakov  <ap@apple.com>
60
61         WebKitTestRunner's InjectedBundle has too aggressive stripping, resulting in non-symbolicated crash logs
62         https://bugs.webkit.org/show_bug.cgi?id=200621
63
64         Reviewed by Dan Bernstein.
65
66         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
67
68 2019-08-09  Wenson Hsieh  <wenson_hsieh@apple.com>
69
70         KeyboardInputTests.CaretSelectionRectAfterRestoringFirstResponder API tests time out on iPad
71         https://bugs.webkit.org/show_bug.cgi?id=200604
72         <rdar://problem/51273130>
73
74         Reviewed by Megan Gardner.
75
76         Tweak some API tests so that they work on iPad simulator. These tests checked that the final caret rect was
77         {{16, 13}, {2, 15}}; however, this is only correct behavior on iPhone, where we will scale the page so that the
78         focused element's font size is legible. Note that when the page is scaled, we scale the height but not the
79         width of the caret, which is why the width of the caret (in content coordinates) decreases while the height
80         remains the same.
81
82         We don't have the same behavior on iPad, so the expected caret rect is {{16, 13}, {3, 15}}, which is equal to
83         the caret rect at initial scale 1.
84
85         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
86
87 2019-08-09  Ali Juma  <ajuma@chromium.org>
88
89         Don't allow cross-origin iframes to autofocus
90         https://bugs.webkit.org/show_bug.cgi?id=200515
91         <rdar://problem/54092988>
92
93         Reviewed by Ryosuke Niwa.
94
95         Make WebKit.FocusedFrameAfterCrash use same-origin iframes instead
96         of cross-origin iframes, since it depends on focusing one of the
97         frames.
98
99         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
100         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
101         (TestWebKitAPI::TEST):
102         * TestWebKitAPI/Tests/WebKit/many-same-origin-iframes.html: Added.
103
104 2019-08-09  Wenson Hsieh  <wenson_hsieh@apple.com>
105
106         [iOS 13] Google Docs/Slides/Sheets: paste often doesn't work and sometimes produces an error
107         https://bugs.webkit.org/show_bug.cgi?id=200591
108         <rdar://problem/54102238>
109
110         Reviewed by Ryosuke Niwa and Tim Horton.
111
112         Add a new API test to exercise -supportsImagePaste.
113
114         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
115         (TestWebKitAPI::TEST):
116         * TestWebKitAPI/ios/UIKitSPI.h:
117
118 2019-08-09  Aakash Jain  <aakash_jain@apple.com>
119
120         Follow-up commit to r248474 as webkit-patch did not commit the svn property changes.
121         [ews-build] Set svn:ignore to various EWS Buildbot files
122         https://bugs.webkit.org/show_bug.cgi?id=200581
123
124         Reviewed by Jonathan Bedard.
125
126         * BuildSlaveSupport/ews-build: Added property svn:ignore.
127
128 2019-08-09  Aakash Jain  <aakash_jain@apple.com>
129
130         [ews-build] Set svn:ignore to various EWS Buildbot files
131         https://bugs.webkit.org/show_bug.cgi?id=200581
132
133         Reviewed by Jonathan Bedard.
134
135         * BuildSlaveSupport/ews-build: Added property svn:ignore.
136
137 2019-08-09  Aakash Jain  <aakash_jain@apple.com>
138
139         [ews] Add buildbot.tac to repository
140         https://bugs.webkit.org/show_bug.cgi?id=200580
141
142         Reviewed by Jonathan Bedard.
143
144         * BuildSlaveSupport/ews-build/buildbot.tac: Added.
145
146 2019-08-09  Claudio Saavedra  <csaavedra@igalia.com>
147
148         [GTK] Add missing spellchecking packages to dependencies script
149         https://bugs.webkit.org/show_bug.cgi?id=200574
150
151         Reviewed by Philippe Normand.
152
153         These are needed for the spellchecking test in WebContext API tests.
154
155         * gtk/install-dependencies:
156
157 2019-08-08  Jon Lee  <jonlee@apple.com>
158
159         Unreviewed. Get rid of extraneous whitespace in ChangeLog.
160
161 2019-08-08  Jonathan Bedard  <jbedard@apple.com>
162
163         webkitpy: Disable shared clipboard between Simulators
164         https://bugs.webkit.org/show_bug.cgi?id=200546
165
166         Reviewed by Aakash Jain.
167
168         * Scripts/webkitpy/xcode/simulated_device.py:
169         (SimulatedDeviceManager.initialize_devices): Disable PasteboardAutomaticSync in Simulator.app
170         managed by run-webkit-tests.
171
172 2019-08-08  Brent Fulgham  <bfulgham@apple.com>
173
174         [FTW] Get WebKit, WebKit2, and MiniBrowser building and executing
175         https://bugs.webkit.org/show_bug.cgi?id=200539
176         <rdar://problem/54082550>
177
178         Reviewed by Dean Jackson.
179
180         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
181         * PlatformFTW.cmake: Added.
182
183 2019-08-08  Said Abou-Hallawa  <sabouhallawa@apple.com>
184
185         [iOS] Position image information should respect the image orientation
186         https://bugs.webkit.org/show_bug.cgi?id=200487
187
188         Reviewed by Simon Fraser.
189
190         Add an API test to verify the position image information is drawn rotated
191         because of respecting its image orientation.
192
193         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
194         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
195         (TestWebKitAPI::TEST):
196         * TestWebKitAPI/Tests/WebKitCocoa/exif-orientation-8-llo.jpg: Added.
197         * TestWebKitAPI/Tests/WebKitCocoa/img-with-rotated-image.html: Added.
198
199 2019-08-08  Claudio Saavedra  <csaavedra@igalia.com>
200
201         [GTK] Fix WebContext languages test
202         https://bugs.webkit.org/show_bug.cgi?id=200538
203
204         Reviewed by Alex Christensen.
205
206         This test broke after the format of Accepted-Languages
207         was changed in r238236, update.
208
209         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
210         (testWebContextLanguages):
211
212 2019-08-08  Claudio Saavedra  <csaavedra@igalia.com>
213
214         [GTK] Fix /webkit/WebKitWebsiteData/databases failure
215         https://bugs.webkit.org/show_bug.cgi?id=200536
216
217         Reviewed by Carlos Alberto Lopez Perez.
218
219         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
220         (testWebsiteDataDatabases): Databases take a moment to be written,
221         wait before fetching the data as it's done in other tests.
222
223 2019-08-08  Jonathan Bedard  <jbedard@apple.com>
224
225         results.webkit.org: Use canvas for timeline
226         https://bugs.webkit.org/show_bug.cgi?id=200172
227
228         Rubber-stamped by Aakash Jain.
229
230         * resultsdbpy/resultsdbpy/view/static/js/commit.js:
231         (Commit.constructor): Make uuid a member variable instead of a member function for efficiency.
232         (Commit.compare): Ditto.
233         (_CommitBank.commitByUuid): Ditto.
234         (_CommitBank._loadSiblings): Ditto.
235         (_CommitBank._load): Ditto.
236         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
237         (tickForCommit): Deleted.
238         (minimumUuidForResults): Given a dictionary of result lists, determine the minimum UUID
239         which encompasses all results. Crucially, this function must exclude an UUIDs which may
240         refer to results excluded because of the limit argument.
241         (renderTimeline): Deleted.
242         (commitsForResults): Given a dictionary of result lists, return a list of commits associated
243         with those results.
244         (scaleForCommits): Given a list of commits, generate a scale to be consumed by the canvas Timeline.
245         (repositoriesForCommits): Given a list of commits, return a sorted list of associated repository ids.
246         (xAxisFromScale): Create a canvas-based x-axis based on the provided scale and a repository id.
247         (inPlaceCombine): Combine result objects together.
248         (statsForSingleResult): Turn a single result into a stat object.
249         (combineResults): Given lists of results, combine these lists while keeping the original lists unchanged.
250         (Dot): Deleted.
251         (TimelineFromEndpoint): Renamed from Timeline.
252         (TimelineFromEndpoint.constructor): Canvas Timeline manages expansion and collapsing of nested timelines.
253         (TimelineFromEndpoint.teardown): Detach callbacks from CommitBank.
254         (TimelineFromEndpoint.update): Update with any new commit information, force a re-draw of the current
255         cache contents.
256         (TimelineFromEndpoint.reload): Remove management of nested timelines.
257         (TimelineFromEndpoint.render): Use canvas Timeline instead of html timeline to visualize results.
258         * resultsdbpy/resultsdbpy/view/templates/search.html: Use TimelineFromEndpoint class.
259         * resultsdbpy/resultsdbpy/view/templates/suite_results.html: Ditto.
260
261 2019-08-08  Brady Eidson  <beidson@apple.com>
262
263         Do not allow navigations of frames about to get replaced by the result of evaluating javascript: URLs
264         <rdar://problem/53788893> and https://bugs.webkit.org/show_bug.cgi?id=198786
265
266         Reviewed by Geoff Garen.
267
268         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
269         * TestWebKitAPI/Tests/mac/JavascriptURLNavigation.mm: Added.
270
271 2019-08-08  Rob Buis  <rbuis@igalia.com>
272
273         Add runtime flag for lazy image loading
274         https://bugs.webkit.org/show_bug.cgi?id=199794
275
276         Reviewed by Darin Adler.
277
278         Set lazyImageLoading preference as part of experimental features. Add
279         TestOption for lazy image loading.
280
281         * DumpRenderTree/TestOptions.cpp:
282         (TestOptions::TestOptions):
283         * DumpRenderTree/TestOptions.h:
284         * DumpRenderTree/mac/DumpRenderTree.mm:
285         (enableExperimentalFeatures):
286         (setWebPreferencesForTestOptions):
287         * DumpRenderTree/win/DumpRenderTree.cpp:
288         (enableExperimentalFeatures):
289
290 2019-08-08  Rob Buis  <rbuis@igalia.com>
291
292         Import lazy loading WPT tests
293         https://bugs.webkit.org/show_bug.cgi?id=199795
294
295         Reviewed by Darin Adler.
296
297         Only do loading/ exception for WebKit specific, non WPT tests.
298
299         * DumpRenderTree/mac/DumpRenderTree.mm:
300         (shouldLogFrameLoadDelegates):
301         * WebKitTestRunner/TestInvocation.cpp:
302         (WTR::TestInvocation::TestInvocation):
303
304 2019-08-07  Fujii Hironori  <Hironori.Fujii@sony.com>
305
306         [Win][MiniBrowser] Add key accelerators for reload and close window
307         https://bugs.webkit.org/show_bug.cgi?id=200497
308
309         Reviewed by Brent Fulgham.
310
311         Added short cuts Ctrl-W to close window, Ctrl-R to reload.
312
313         * MiniBrowser/win/MainWindow.cpp:
314         (MainWindow::WndProc): Added IDM_CLOSE_WINDOW case.
315         * MiniBrowser/win/MiniBrowserLib.rc: Added "Close" menu item. Added accelerators.
316         * MiniBrowser/win/MiniBrowserLibResource.h: Added IDM_CLOSE_WINDOW.
317
318 2019-08-07  Myles C. Maxfield  <mmaxfield@apple.com>
319
320         Add WHLSL and WebGPU to the watchlist file
321         https://bugs.webkit.org/show_bug.cgi?id=200509
322
323         Reviewed by Robin Morisset.
324
325         * Scripts/webkitpy/common/config/watchlist:
326
327 2019-08-07  Keith Rollin  <krollin@apple.com>
328
329         Unreviewed build fix after r248317 -- disable XCBuild because it
330         breaks incremental builds.
331
332         * Scripts/webkitdirs.pm:
333         (canUseXCBuild):
334
335 2019-08-06  Fujii Hironori  <Hironori.Fujii@sony.com>
336
337         ASSERTION FAILED: m_observers.isEmpty() if WKPageSetPageStateClient is used
338         https://bugs.webkit.org/show_bug.cgi?id=200465
339
340         Reviewed by Alex Christensen.
341
342         * TestWebKitAPI/Tests/WebKit/PageLoadState.cpp:
343         (TestWebKitAPI::WebKit.PageLoadState): Set PageStateClient before
344         finishing the test.
345         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
346         (TestWebKitAPI::PlatformWebView::~PlatformWebView): Release m_view.
347
348 2019-08-06  Jiewen Tan  <jiewen_tan@apple.com>
349
350         Unreviewed, a build fix after r248308
351
352         Don't use WK_ENGINEERING_CODE_SIGN_IDENTITY for Production build.
353
354         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
355
356 2019-08-06  Jiewen Tan  <jiewen_tan@apple.com>
357
358         Unreviewed, a build fix after r248319
359
360         Use HAVE(DATA_PROTECTION_KEYCHAIN) instead of HAVE_DATA_PROTECTION_KEYCHAIN.
361
362         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
363         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
364         (WTR::TestController::addTestKeyToKeychain):
365         (WTR::TestController::cleanUpKeychain):
366         (WTR::TestController::keyExistsInKeychain):
367
368 2019-08-06  Jiewen Tan  <jiewen_tan@apple.com>
369
370         Unreviewed, a build fix after r248308
371
372         Use kSecUseDataProtectionKeychain for iOS 13 and macOS Catalina or newer.
373
374         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
375         (WTR::TestController::addTestKeyToKeychain):
376         (WTR::TestController::cleanUpKeychain):
377         (WTR::TestController::keyExistsInKeychain):
378
379 2019-08-06  Keith Rollin  <krollin@apple.com>
380
381         Enable XCBuild for `make` and `build-webkit` builds
382         https://bugs.webkit.org/show_bug.cgi?id=200476
383         <rdar://problem/50771065>
384
385         Reviewed by Jonathan Bedard.
386
387         All projects have now been tested under XCBuild and successfully
388         build. Enable the use of XCBuild when performing builds with `make` or
389         `build-webkit` and when using a sufficient version of Xcode. We set
390         this version to Xcode 11 since Xcode 10 -- even though it supports
391         XCBuild -- does not support a build facility needed to build WebKit
392         (Bug 197072, Bug 197116, Bug 197340).
393
394         Do not enable XCBuild in the Xcode projects themselves since these
395         projects may need to be used under older versions of Xcode and there's
396         no way to make those project changes sensitive to the version of Xcode
397         being used. This means that builds performed in the Xcode IDE will not
398         use XCBuild.
399
400         * Scripts/webkitdirs.pm:
401         (canUseXCBuild):
402
403 2019-08-06  Chris Dumez  <cdumez@apple.com>
404
405         Fix inefficiency in HTTPHeaderMap::set(CFStringRef, const String&)
406         https://bugs.webkit.org/show_bug.cgi?id=200475
407
408         Reviewed by Darin Adler.
409
410         * TestWebKitAPI/Tests/WTF/StringView.cpp:
411         (TestWebKitAPI::stringViewFromLiteral):
412         (TestWebKitAPI::stringViewFromUTF8):
413
414 2019-08-06  Carlos Alberto Lopez Perez  <clopez@igalia.com>
415
416         Update my status in contributors.json to reviewer.
417
418         Regained the status after following the procedure for inactive contributors.
419         See r247136 for further explanation.
420
421         * Scripts/webkitpy/common/config/contributors.json:
422
423 2019-08-06  Jiewen Tan  <jiewen_tan@apple.com>
424
425         [WebAuthN] Enable LocalAuthenticator for macOS
426         https://bugs.webkit.org/show_bug.cgi?id=182772
427         <rdar://problem/43347920>
428
429         Reviewed by Brent Fulgham.
430
431         Add an entitlement file to WebKitTestRunner such that it can access
432         the modern macOS keychain.
433
434         * WebKitTestRunner/Configurations/WebKitTestRunner.entitlements: Added.
435         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
436         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
437         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
438         (WTR::TestController::addTestKeyToKeychain):
439         (WTR::TestController::cleanUpKeychain):
440         (WTR::TestController::keyExistsInKeychain):
441
442 2019-08-06  Zhifei Fang  <zhifei_fang@apple.com>
443
444         [results.webkit.org Timeline] Performance improvements
445         https://bugs.webkit.org/show_bug.cgi?id=200406
446
447         Reviewed by Jonathan Bedard.
448
449         1. Unhook the scroll event when a series/axis have been removed from the container
450         2. Fix the axis's cache data structure out of sync.
451         3. Use position:sticky to reduce the scrolling blink when update the presenter's transform
452         4. Use intersection observer to detect if the canvas on screen or not, if a canvas is not on the screen, we do nothing, this will eliminate render requests we send out.
453
454
455         * resultsdbpy/resultsdbpy/view/static/library/js/Ref.js:
456         (Signal.prototype.removeListener):
457         (prototype.stopAction): Unregsiter an action handler
458         (Ref):
459         (Ref.prototype.apply):
460         (Ref.prototype.destory):
461         * resultsdbpy/resultsdbpy/view/static/library/js/components/BaseComponents.js:
462         (ApplyNewChildren):
463         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
464         (Timeline.CanvasSeriesComponent):
465
466 2019-08-06  Jer Noble  <jer.noble@apple.com>
467
468         Add test for behavior introduced in r248174
469         https://bugs.webkit.org/show_bug.cgi?id=200446
470
471         Reviewed by Eric Carlson.
472
473         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
474         * TestWebKitAPI/Tests/ios/FullscreenTouchSecheuristicTests.cpp: Added.
475         (WebKit::configureSecheuristic):
476         (WebKit::TEST):
477
478 2019-08-05  Fujii Hironori  <Hironori.Fujii@sony.com>
479
480         [MiniBrowser][WK2] Unhandled key events should be bubbled up to the parent window
481         https://bugs.webkit.org/show_bug.cgi?id=200464
482
483         Reviewed by Ross Kirsling.
484
485         When WK2 WebView is focused, short cut keys (e.g. Alt-F to open File
486         menu, Alt-F4 to close window, and etc) don't work.
487
488         WK1 WebView doesn't have this issue because it processes key events
489         properly.
490
491         * MiniBrowser/win/WebKitBrowserWindow.cpp:
492         (WebKitBrowserWindow::WebKitBrowserWindow):
493         (WebKitBrowserWindow::didNotHandleKeyEvent): Added. Send the
494         unhandled key events to the main window.
495         * MiniBrowser/win/WebKitBrowserWindow.h:
496
497 2019-08-05  Simon Fraser  <simon.fraser@apple.com>
498
499         iOS 13: Overflow:hidden on body prevents PDF scroll
500         https://bugs.webkit.org/show_bug.cgi?id=200435
501         rdar://problem/53942888
502
503         Reviewed by Tim Horton.
504
505         When we navigate from an overflow:hidden HTML page to a custom view (like PDF), we need
506         to make sure that the scroll view is scrollable.
507
508         * TestWebKitAPI/Tests/ios/ScrollViewScrollabilityTests.mm:
509         (TestWebKitAPI::TEST):
510
511 2019-08-05  Aakash Jain  <aakash_jain@apple.com>
512
513         New EWS:mac-wk2 status-bubble shows waiting to run tests for all recent bugs
514         https://bugs.webkit.org/show_bug.cgi?id=200400
515
516         Reviewed by Jonathan Bedard.
517
518         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
519         (StatusBubble._build_bubble):
520         (StatusBubble._queue_position):
521
522 2019-08-05  Jonathan Bedard  <jbedard@apple.com>
523
524         run-webkit-tests asserts when the iPhone XR simulator is running
525         https://bugs.webkit.org/show_bug.cgi?id=200404
526         <rdar://problem/53878739>
527
528         Reviewed by Dean Jackson.
529
530         Support unicode in all logging statements tied to device model.
531
532         * Scripts/webkitpy/layout_tests/controllers/manager.py:
533         (Manager.run):
534         * Scripts/webkitpy/layout_tests/views/printing.py:
535         (Printer.print_baseline_search_path):
536         * Scripts/webkitpy/port/device.py:
537         (Device.__repr__):
538         * Scripts/webkitpy/port/device_port.py:
539         (DevicePort._install):
540         (DevicePort.setup_test_run):
541         (DevicePort.clean_up_test_run):
542         (DevicePort.configuration_for_upload):
543         * Scripts/webkitpy/port/ios.py:
544         (IOSPort.default_baseline_search_path):
545         * Scripts/webkitpy/xcode/device_type.py:
546         (DeviceType.__str__):
547         * Scripts/webkitpy/xcode/simulated_device.py:
548         (SimulatedDeviceManager.populate_available_devices):
549         (SimulatedDeviceManager._find_available_name):
550         (SimulatedDeviceManager._get_device_identifier_for_type):
551         (SimulatedDeviceManager._create_or_find_device_for_request):
552         (SimulatedDeviceManager._does_fulfill_request):
553         (SimulatedDeviceManager._wait_until_device_in_state):
554         (SimulatedDeviceManager._wait_until_device_is_usable):
555         (SimulatedDeviceManager._boot_device):
556         (SimulatedDeviceManager.initialize_devices):
557         (SimulatedDeviceManager.max_supported_simulators):
558         (SimulatedDeviceManager.swap):
559         (SimulatedDevice.is_usable):
560         (SimulatedDevice._shut_down):
561         (SimulatedDevice._delete):
562         (SimulatedDevice.launch_app):
563         (SimulatedDevice.__repr__):
564
565 2019-08-04  Chris Dumez  <cdumez@apple.com>
566
567         Ping loads should not prevent page caching
568         https://bugs.webkit.org/show_bug.cgi?id=200418
569         <rdar://problem/53901632>
570
571         Reviewed by Darin Adler.
572
573         Add TestOption to enable PageCache at UIProcess-level so that we can test
574         page caching when navigating cross-origin with PSON enabled.
575
576         * WebKitTestRunner/TestController.cpp:
577         (WTR::TestController::resetPreferencesToConsistentValues):
578         (WTR::updateTestOptionsFromTestHeader):
579         * WebKitTestRunner/TestOptions.h:
580         (WTR::TestOptions::hasSameInitializationOptions const):
581
582 2019-08-02  Keith Rollin  <krollin@apple.com>
583
584         Consistently use Obj-C boolean literals
585         https://bugs.webkit.org/show_bug.cgi?id=200405
586         <rdar://problem/53880043>
587
588         Reviewed by Simon Fraser, Joseph Pecoraro.
589
590         There are places where we use equivalent but different expressions for
591         Obj-C boolean objects. For example, we use both [NSNumber
592         numberWithBool:YES] and @YES. There are places where both are used in
593         the same function, such as -[WebPreferences initialize]. The boolean
594         literal is in greater use and is more succinct, so standardize on
595         that. Also, change @(YES/NO) to @YES/NO.
596
597         * DumpRenderTree/mac/ObjCController.m:
598         (-[ObjCController objectOfClass:]):
599         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegate.mm:
600         (TEST):
601         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
602         (overrideAddObserverForName):
603         * TestWebKitAPI/ios/mainIOS.mm:
604         (main):
605         * TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
606         (TestWebKitAPI::InjectedBundleController::platformInitialize):
607         * TestWebKitAPI/mac/mainMac.mm:
608         (main):
609         * WebKitLauncher/WebKitNightlyEnabler.m:
610         (enableWebKitNightlyBehaviour):
611
612 2019-08-02  Wenson Hsieh  <wenson_hsieh@apple.com>
613
614         TextAutosizingBoost.ChangeAutosizingBoostAtRuntime fails on iPad Simulator
615         https://bugs.webkit.org/show_bug.cgi?id=200402
616         <rdar://problem/53823368>
617
618         Reviewed by Tim Horton.
619
620         Make it possible to run this test using the iPad simulator.
621
622         * TestWebKitAPI/Tests/ios/TextAutosizingBoost.mm:
623
624         Two adjustments: (1) override the screen size to be 320 by 568 (so that the legacy text autosizing heuristic
625         doesn't avoid boosting this text), and (2) force text autosizing on, but disable idempotent text autosizing,
626         since this would result in differently sized text.
627
628         (mainScreenReferenceBoundsOverride):
629         * TestWebKitAPI/ios/UIKitSPI.h:
630
631 2019-08-02  Sihui Liu  <sihui_liu@apple.com>
632
633         API tests using permanent credentials should clear credentials left by previous tests
634         https://bugs.webkit.org/show_bug.cgi?id=199729
635
636         Reviewed by Alex Christensen.
637
638         We used to clear the permanent credentials created by API tests at the end of the API tests, to ensure those
639         credentials will not affect tests running after. There is a case where permanent credentials were left on the
640         system, so those API tests were timing out themselves before reaching to the cleanup, which caused cascading
641         failure. To prevent this from happening again, add cleanup at the begining of the tests.
642
643         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
644         (TEST):
645         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
646         (TestWebKitAPI::TEST):
647
648 2019-08-02  Andres Gonzalez  <andresg_22@apple.com>
649
650         Add accessibility object method to determine whether an element is inside a table cell. Needed for iOS accessibility client.
651         https://bugs.webkit.org/show_bug.cgi?id=200394
652         <rdar://problem/52914964>
653
654         Reviewed by Chris Fleizach.
655
656         Glue code to exercise new method [WebAccessibilityObjectWrapper _accessibilityIsInTableCell].
657
658         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
659         (WTR::AccessibilityUIElement::isInTableCell const):
660         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
661         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
662         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
663         (WTR::AccessibilityUIElement::isInTableCell const):
664
665 2019-08-02  Zhifei Fang  <zhifei_fang@apple.com>
666
667         [results.webkit.org Timeline] Using transform matrix to calculate the tag rotation position
668         https://bugs.webkit.org/show_bug.cgi?id=200397
669
670         Reviewed by Jonathan Bedard.
671
672         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
673
674 2019-08-02  Wenson Hsieh  <wenson_hsieh@apple.com>
675
676         [macOS 10.15] Image dragged from Safari does not appear in Notes
677         https://bugs.webkit.org/show_bug.cgi?id=188490
678         <rdar://problem/39462717>
679
680         Reviewed by Andy Estes.
681
682         Add a test to verify that promised image data can be delivered to multiple pasteboards when performing a drop.
683
684         * TestWebKitAPI/Tests/mac/DragAndDropTestsMac.mm:
685
686 2019-08-02  Alex Christensen  <achristensen@webkit.org>
687
688         Fix API test after r248139
689         https://bugs.webkit.org/show_bug.cgi?id=200102
690
691         * TestWebKitAPI/Tests/WebKitCocoa/AdditionalReadAccessAllowedURLsPlugin.mm:
692         (-[AdditionalReadAccessAllowedURLsPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
693         This was supposed to be removed as part of reverting r245322.
694
695 2019-08-01  Zhifei Fang  <zhifei_fang@apple.com>
696
697         results.webkit.org: Force update cache when timeline updated
698         https://bugs.webkit.org/show_bug.cgi?id=200363
699
700         Reviewed by Jonathan Bedard.
701
702         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
703         (offscreenCachedRenderFactory): Add ability to force the redraw.
704         (Timeline.CanvasSeriesComponent): Force redraw when scales or dots are updated.
705         (Timeline.CanvasXAxisComponent): Force redraw when scales are updated. Add missing exporter for export scales update API
706
707 2019-08-01  Alex Christensen  <achristensen@webkit.org>
708
709         Do not send NetworkProcessProxy::LogTestingEvent message if we are not testing
710         https://bugs.webkit.org/show_bug.cgi?id=200360
711
712         Reviewed by Tim Horton.
713
714         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
715         (cleanupITPDatabase):
716         (TEST):
717
718 2019-08-01  Alex Christensen  <achristensen@webkit.org>
719
720         Move FormData zip file generation to NetworkProcess and enable it for all WebKit clients for uploading directories
721         https://bugs.webkit.org/show_bug.cgi?id=200102
722         <rdar://problem/53275114>
723
724         Reviewed by Darin Adler.
725
726         Add an API test that is Mac-only right now because runOpenPanelWithParameters is only supported on Mac for some reason
727         and because clicking on a TestWKWebView only works on Mac.
728
729         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
730         * TestWebKitAPI/Tests/WebKitCocoa/UploadDirectory.mm: Added.
731         (-[UploadDelegate initWithDirectory:]):
732         (-[UploadDelegate webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]):
733         (-[UploadDelegate sentDirectory]):
734         (TEST):
735         * TestWebKitAPI/cocoa/TestWKWebView.h:
736         * TestWebKitAPI/cocoa/TestWKWebView.mm:
737         (-[TestWKWebView sendClickAtPoint:]):
738
739 2019-08-01  Zhifei Fang  <zhifei_fang@apple.com>
740
741         [results.webkit.org] Timeline.CanvasXAxisComponent height should be defined by option
742         https://bugs.webkit.org/show_bug.cgi?id=200321
743
744         Reviewed by Jonathan Bedard.
745
746         *resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
747         Let the axis' height be defined in the option. Timeine component will use this value as
748         padding-top for headers which allows headers start in the right position, even with multiple
749         top axises.
750         (Timeline.CanvasSeriesComponent):
751         (prototype.Timeline.CanvasContainer):
752
753 2019-08-01  Zhifei Fang  <zhifei_fang@apple.com>
754
755         results.webkit.org: Collision detection for dots is off by 2 * dotMargin
756         https://bugs.webkit.org/show_bug.cgi?id=200347
757
758         Reviewed by Jonathan Bedard.
759
760         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
761         (Timeline.CanvasSeriesComponent): Need to change it to dotMargin + radius other than use a fixed 3 * radius, which is for the old wide timeline
762
763 2019-08-01  Jiewen Tan  <jiewen_tan@apple.com>
764
765         Improve flakiness of SOAuthorizationRedirect tests
766         https://bugs.webkit.org/show_bug.cgi?id=200320
767         <rdar://problem/53767057>
768
769         Reviewed by Alex Christensen.
770
771         This patch replaces Util::sleep(0.5) in tests that expect a SOAuthorization session to wait when the corresponding WKWebView
772         is out of the window with a more precise boolean indicator: navigationPolicyDecided. The new boolean indicator is working and
773         better because the authorizationPerformed should be set in the same runloop when NavigationState::decidePolicyForNavigationAction
774         is executed.
775
776         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
777         (-[TestSOAuthorizationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
778         (resetState):
779         (TestWebKitAPI::TEST):
780
781 2019-08-01  Keith Rollin  <krollin@apple.com>
782
783         Update TestWebKitAPI for XCBuild
784         https://bugs.webkit.org/show_bug.cgi?id=200311
785         <rdar://problem/53773804>
786
787         Reviewed by Alex Christensen.
788
789         Bug 199728 (svn 247402) updated TestWebKitAPI to use the unified-build
790         technique. Now update WebKitLegacy to build under XCBuild after those
791         changes. This work involves adding an "Apply Configuration to
792         XCFileLists" build target, adding a check-xcfilelists.sh script,
793         adding a "Check xcfilelists" build phase that calls that script,
794         adding knowledge of the project to the generate-xcfilelists script,
795         creating new .xcfilelist files, and adding those to the project.
796
797         * Scripts/webkitpy/generate_xcfilelists_lib/application.py:
798         (Application.__init__):
799         * Scripts/webkitpy/generate_xcfilelists_lib/generators.py:
800         (WebKitTestRunnerGenerator._get_generate_derived_sources_script):
801         (TestWebKitAPIGenerator):
802         (TestWebKitAPIGenerator._get_project_file_path):
803         (TestWebKitAPIGenerator._get_generate_unified_sources_script):
804         * TestWebKitAPI/Scripts/check-xcfilelists.sh: Added.
805         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
806         * TestWebKitAPI/UnifiedSources-output.xcfilelist: Added.
807
808 2019-08-01  Youenn Fablet  <youenn@apple.com>
809
810         UserMediaPermissionRequestManagerProxy should not use audio+video denied requests to deny audio-only or video-only requests
811         https://bugs.webkit.org/show_bug.cgi?id=200317
812
813         Reviewed by Eric Carlson.
814
815         * TestWebKitAPI/Tests/WebKit/getUserMediaAudioVideoCapture.html: Added
816         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
817         * TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm:
818         (-[GetUserMediaOnlyAudioUIDelegate _webView:requestMediaCaptureAuthorization:decisionHandler:]):
819         (-[GetUserMediaOnlyAudioUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
820         (TestWebKitAPI::TEST):
821
822 2019-08-01  Aakash Jain  <aakash_jain@apple.com>
823
824         New EWS: Cannot see build status page when patch is waiting for tester
825         https://bugs.webkit.org/show_bug.cgi?id=200333
826
827         Reviewed by Jonathan Bedard.
828
829         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
830         (StatusBubble): While patch hasn't started processing on tester queue, display build information from builder queue.
831
832 2019-08-01  Carlos Garcia Campos  <cgarcia@igalia.com>
833
834         [SOUP] Switch to use libsoup WebSockets API
835         https://bugs.webkit.org/show_bug.cgi?id=200162
836
837         Reviewed by Michael Catanzaro.
838
839         Update libsoup version to 2.67.90.
840
841         * gtk/jhbuild.modules:
842         * wpe/jhbuild.modules:
843
844 2019-07-31  Andy Estes  <aestes@apple.com>
845
846         REGRESSION (r240942): first visually non-empty layout milestone is not reached in media documents until after the video finishes loading
847         https://bugs.webkit.org/show_bug.cgi?id=200293
848         <rdar://problem/52937749>
849
850         Reviewed by Alex Christensen.
851
852         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
853         * TestWebKitAPI/Tests/WebKitCocoa/FirstVisuallyNonEmptyMilestone.mm: Renamed from Tools/TestWebKitAPI/Tests/WebKit/FirstVisuallyNonEmptyMilestoneWithDeferredScript.mm.
854         (-[FirstPaintMessageHandler userContentController:didReceiveScriptMessage:]):
855         (-[RenderingProgressNavigationDelegate _webView:renderingProgressDidChange:]):
856         (-[RenderingProgressNavigationDelegate webView:didFinishNavigation:]):
857         (TEST):
858
859 2019-07-31  Aakash Jain  <aakash_jain@apple.com>
860
861         [ews-build] Enable all macOS queues on new EWS
862         https://bugs.webkit.org/show_bug.cgi?id=199944
863
864         Reviewed by Jonathan Bedard.
865
866         * BuildSlaveSupport/ews-build/config.json: Enabled the triggers for macOS queues.
867         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
868         (StatusBubble): Enabled status-bubbles for mac queues, separated builders and testers bubbles in separate lines. Also
869         removed mac-32bit and mac-32bit-wk2 bubbles, these queues were removed from Buildbot configuration previously.
870         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js: Removed mac queues from bot-watcher's dashboard.
871         * QueueStatusServer/config/queues.py: Removed mac queues from old EWS.
872
873 2019-07-31  Ryan Haddad  <ryanhaddad@apple.com>
874
875         Unreviewed test gardening, disable failing test for rdar://51752593.
876
877         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
878
879 2019-07-31  Jonathan Bedard  <jbedard@apple.com>
880
881         results.webkit.og: Timeline in canvas painting with wrong colors, cannot customize scale
882         https://bugs.webkit.org/show_bug.cgi?id=200318
883
884         Reviewed by Aakash Jain.
885
886         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
887         (Timeline.CanvasSeriesComponent): Reset draw context between dots.
888         (Timeline.CanvasXAxisComponent): Use getLabel function.
889
890 2019-07-31  Loïc Yhuel  <loic.yhuel@softathome.com>
891
892         [GTK][WPE] Fix gtkdoc build with "build-webkit --32-bit" on 64-bit hosts
893         https://bugs.webkit.org/show_bug.cgi?id=200306
894
895         Reviewed by Michael Catanzaro.
896
897         gtkdoc-scangobj calls scangobj.py, which only uses LDFLAGS on link (when producing
898         jsc-glib-4.0-scan for example).
899
900         * Scripts/webkitdirs.pm:
901         (generateBuildSystemFromCMakeProject):
902
903 2019-07-31  Ryan Haddad  <ryanhaddad@apple.com>
904
905         Unreviewed test gardening, disable failing test for rdar://52355829.
906
907         * TestWebKitAPI/Tests/WebKitCocoa/ContextMenus.mm:
908         (TEST):
909
910 2019-07-31  Keith Rollin  <krollin@apple.com>
911
912         Update WebKitLegacy for XCBuild
913         https://bugs.webkit.org/show_bug.cgi?id=200310
914         <rdar://problem/53773708>
915
916         Reviewed by Alex Christensen.
917
918         Bug 199771 (svn r247570) updated WebKitLegacy to use the unified-build
919         technique. Now update WebKitLegacy to build under XCBuild after those
920         changes. This work involves adding an "Apply Configuration to
921         XCFileLists" build target, adding a check-xcfilelists.sh script,
922         adding a "Check xcfilelists" build phase that calls that script,
923         adding knowledge of the project to the generate-xcfilelists script,
924         creating new .xcfilelist files, and adding those to the project.
925
926         * Scripts/webkitpy/generate_xcfilelists_lib/application.py:
927         (Application.__init__):
928         * Scripts/webkitpy/generate_xcfilelists_lib/generators.py:
929         (JavaScriptCoreGenerator):
930         (WebCoreGenerator):
931         (WebKitGenerator):
932         (WebKitGenerator._get_generate_unified_sources_script):
933         (WebKitLegacyGenerator):
934         (WebKitLegacyGenerator._get_project_file_path):
935         (WebKitLegacyGenerator._get_generate_unified_sources_script):
936
937 2019-07-31  Chris Dumez  <cdumez@apple.com>
938
939         REGRESSION (r247486?): Flaky API Test TestWebKitAPI.WKWebView.LocalStorageProcessSuspends
940         https://bugs.webkit.org/show_bug.cgi?id=200086
941         <rdar://problem/53501721>
942
943         Reviewed by Alex Christensen.
944
945         re-enable the API test.
946
947         * TestWebKitAPI/Tests/WebKitCocoa/LocalStoragePersistence.mm:
948         (TEST):
949
950 2019-07-31  Wenson Hsieh  <wenson_hsieh@apple.com>
951
952         [iOS 13] Safari crashes when closing a tab with a focused element if the unified field has focus
953         https://bugs.webkit.org/show_bug.cgi?id=200291
954         <rdar://problem/53717946>
955
956         Reviewed by Megan Gardner.
957
958         Add an API test to exercise the scenario of synchronously requesting the autocorrection context immediately
959         after closing the web view, while the web view's content view isn't the first responder.
960
961         * TestWebKitAPI/Tests/ios/AutocorrectionTestsIOS.mm:
962         * TestWebKitAPI/ios/UIKitSPI.h:
963
964 2019-07-31  Carlos Garcia Campos  <cgarcia@igalia.com>
965
966         [GTK] Datalist element support for TextFieldInputType
967         https://bugs.webkit.org/show_bug.cgi?id=98934
968
969         Reviewed by Michael Catanzaro.
970
971         Implement UIScriptControllerGtk::isShowingDataListSuggestions.
972
973         * WebKitTestRunner/gtk/UIScriptControllerGtk.cpp:
974         (WTR::UIScriptControllerGtk::isShowingDataListSuggestions const):
975         * WebKitTestRunner/gtk/UIScriptControllerGtk.h:
976
977 2019-07-30  Tim Horton  <timothy_horton@apple.com>
978
979         Remove some needless comments that snuck into the tree
980
981         * TestRunnerShared/UIScriptContext/UIScriptController.h:
982         (WTR::UIScriptController::setHardwareKeyboardAttached):
983         (WTR::UIScriptController::playBackEventStream):
984
985 2019-07-30  Fujii Hironori  <Hironori.Fujii@sony.com>
986
987         [WebKit] Add PageLoadState::Observer C API
988         https://bugs.webkit.org/show_bug.cgi?id=199848
989
990         Reviewed by Alex Christensen.
991
992         * MiniBrowser/win/WebKitBrowserWindow.cpp:
993         (WebKitBrowserWindow::WebKitBrowserWindow):
994         (WebKitBrowserWindow::didChangeTitle):
995         (WebKitBrowserWindow::didFinishNavigation): Deleted.
996         * MiniBrowser/win/WebKitBrowserWindow.h:
997         * TestWebKitAPI/CMakeLists.txt:
998         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
999         * TestWebKitAPI/Tests/WebKit/PageLoadState.cpp: Added.
1000         (TestWebKitAPI::PageLoadTestState::PageLoadTestState):
1001         (TestWebKitAPI::didChangeActiveURL):
1002         (TestWebKitAPI::didChangeCanGoBack):
1003         (TestWebKitAPI::didChangeCanGoForward):
1004         (TestWebKitAPI::didChangeCertificateInfo):
1005         (TestWebKitAPI::didChangeEstimatedProgress):
1006         (TestWebKitAPI::didChangeHasOnlySecureContent):
1007         (TestWebKitAPI::didChangeIsLoading):
1008         (TestWebKitAPI::didChangeNetworkRequestsInProgress):
1009         (TestWebKitAPI::didChangeTitle):
1010         (TestWebKitAPI::didChangeWebProcessIsResponsive):
1011         (TestWebKitAPI::didSwapWebProcesses):
1012         (TestWebKitAPI::willChangeActiveURL):
1013         (TestWebKitAPI::willChangeCanGoBack):
1014         (TestWebKitAPI::willChangeCanGoForward):
1015         (TestWebKitAPI::willChangeCertificateInfo):
1016         (TestWebKitAPI::willChangeEstimatedProgress):
1017         (TestWebKitAPI::willChangeHasOnlySecureContent):
1018         (TestWebKitAPI::willChangeIsLoading):
1019         (TestWebKitAPI::willChangeNetworkRequestsInProgress):
1020         (TestWebKitAPI::willChangeTitle):
1021         (TestWebKitAPI::willChangeWebProcessIsResponsive):
1022         (TestWebKitAPI::didFinishNavigation):
1023         (TestWebKitAPI::TEST):
1024
1025 2019-07-30  Jonathan Bedard  <jbedard@apple.com>
1026
1027         DumpRenderTree.app: Add CFBundleShortVersionString
1028         https://bugs.webkit.org/show_bug.cgi?id=200269
1029         <rdar://problem/53412596>
1030
1031         Rubber-stamped by Aakash Jain.
1032
1033         * DumpRenderTree/ios/Info.plist:
1034
1035 2019-07-29  Wenson Hsieh  <wenson_hsieh@apple.com>
1036
1037         Add layout test coverage for <https://webkit.org/b/200215>
1038         https://bugs.webkit.org/show_bug.cgi?id=200245
1039         <rdar://problem/52976965>
1040
1041         Reviewed by Tim Horton.
1042
1043         Add new testing infrastructure. See below for more details.
1044
1045         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1046         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
1047         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1048         (WTR::UIScriptController::setWillCreateNewPageCallback):
1049         (WTR::UIScriptController::willCreateNewPageCallback const):
1050
1051         Add platform-agnostic UIScriptController callback hooks to notify a test when a new page is being created. The
1052         new test in this patch uses this opportunity to remove and reinsert the web view into the window's hierarchy.
1053
1054         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1055         (WTR::UIScriptController::becomeFirstResponder):
1056
1057         Add and implement a Cocoa platform hook to make the web view first responder.
1058
1059         * WebKitTestRunner/TestController.cpp:
1060         (WTR::TestController::createOtherPage):
1061         * WebKitTestRunner/TestInvocation.cpp:
1062         (WTR::TestInvocation::willCreateNewPage):
1063         * WebKitTestRunner/TestInvocation.h:
1064         * WebKitTestRunner/cocoa/UIScriptControllerCocoa.h:
1065         * WebKitTestRunner/cocoa/UIScriptControllerCocoa.mm:
1066         (WTR::UIScriptControllerCocoa::becomeFirstResponder):
1067
1068 2019-07-29  Fujii Hironori  <Hironori.Fujii@sony.com>
1069
1070         [Win][MiniBrowser] Add 'reload' menu item and 'reload' toolbar button
1071         https://bugs.webkit.org/show_bug.cgi?id=200217
1072
1073         Reviewed by Alex Christensen.
1074
1075         * MiniBrowser/win/BrowserWindow.h:
1076         * MiniBrowser/win/MainWindow.cpp:
1077         (MainWindow::init):
1078         (MainWindow::resizeSubViews):
1079         (MainWindow::WndProc):
1080         * MiniBrowser/win/MainWindow.h: Added m_hReloadButtonWnd.
1081         * MiniBrowser/win/MiniBrowserLib.rc:
1082         * MiniBrowser/win/MiniBrowserLibResource.h: Added IDM_RELOAD.
1083         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1084         (WebKitBrowserWindow::reload):
1085         * MiniBrowser/win/WebKitBrowserWindow.h: Added reload() interface.
1086         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
1087         (WebKitLegacyBrowserWindow::reload):
1088         * MiniBrowser/win/WebKitLegacyBrowserWindow.h:
1089
1090 2019-07-29  Fujii Hironori  <Hironori.Fujii@sony.com>
1091
1092         [Win][MiniBrowser][WK2] Automatically supplement "file://" or "http://" for an input URL as well as WK1 browser window
1093         https://bugs.webkit.org/show_bug.cgi?id=200218
1094
1095         Reviewed by Alex Christensen.
1096
1097         Moved the scheme supplementing logic from
1098         WebKitLegacyBrowserWindow::loadURL to MainWindow::loadURL.
1099
1100         * MiniBrowser/win/MainWindow.cpp:
1101         (MainWindow::loadURL):
1102         (MainWindow::onURLBarEnter):
1103         * MiniBrowser/win/MainWindow.h:
1104         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
1105         (WebKitLegacyBrowserWindow::loadURL):
1106
1107 2019-07-29  Aakash Jain  <aakash_jain@apple.com>
1108
1109         Disable Flaky API Test TestWebKitAPI.WKWebView.LocalStorageProcessSuspends
1110         https://bugs.webkit.org/show_bug.cgi?id=200254
1111
1112         Unreviewed infrastructure fix.
1113
1114         * TestWebKitAPI/Tests/WebKitCocoa/LocalStoragePersistence.mm: Disabled the test.
1115
1116 2019-07-29  Zhifei Fang  <zhifei_fang@apple.com>
1117
1118         [Canvas Timeline] Compact canvas timeline
1119         https://bugs.webkit.org/show_bug.cgi?id=200177
1120
1121         Reviewed by Jonathan Bedard.
1122
1123         * resultsdbpy/resultsdbpy/view/static/library/js/components/BaseComponents.js:
1124         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
1125         (Timeline.CanvasSeriesComponent):
1126
1127 2019-07-29  Carlos Garcia Campos  <cgarcia@igalia.com>
1128
1129         Multiple context menu actions broken for YouTube videos
1130         https://bugs.webkit.org/show_bug.cgi?id=199999
1131
1132         Reviewed by Eric Carlson.
1133
1134         Add a test case to check copy link address, open in new window and download options are not included in the
1135         context menu for non-downloadable media.
1136
1137         * TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp:
1138         (writeNextChunk):
1139         (serverCallback):
1140         (testContextMenuLiveStream):
1141         (beforeAll):
1142         (afterAll):
1143
1144 2019-07-28  Tim Horton  <timothy_horton@apple.com>
1145
1146         Reorganize UIScriptController into platform-specific subclasses
1147         https://bugs.webkit.org/show_bug.cgi?id=200027
1148
1149         Reviewed by Simon Fraser.
1150
1151         Instead of a mishmash of #ifdefs and extraneous empty functions,
1152         reorganize UIScriptController so that we have a base class
1153         with functions that assert if called (to make it harder to
1154         accidentally write a test that depends on unimplemented
1155         functionality), and override them in platform specific subclasses
1156         as functionality is added.
1157
1158         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1159         * DumpRenderTree/ios/UIScriptControllerIOS.h: Added.
1160         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1161         * DumpRenderTree/mac/UIScriptControllerMac.h: Added.
1162         * DumpRenderTree/mac/UIScriptControllerMac.mm:
1163         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1164         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1165         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1166         * WebKitTestRunner/cocoa/UIScriptControllerCocoa.h: Added.
1167         * WebKitTestRunner/cocoa/UIScriptControllerCocoa.mm: Added.
1168         * WebKitTestRunner/gtk/UIScriptControllerGtk.cpp:
1169         * WebKitTestRunner/gtk/UIScriptControllerGtk.h: Added.
1170         * WebKitTestRunner/ios/UIScriptControllerIOS.h: Added.
1171         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1172         * WebKitTestRunner/mac/UIScriptControllerMac.h: Added.
1173         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1174
1175 2019-07-28  Fujii Hironori  <Hironori.Fujii@sony.com>
1176
1177         [Win][MiniBrowser] Remove PageLoadTestClient
1178         https://bugs.webkit.org/show_bug.cgi?id=200155
1179
1180         Reviewed by Brent Fulgham.
1181
1182         It is not used nowadays.
1183
1184         * MiniBrowser/win/CMakeLists.txt:
1185         * MiniBrowser/win/Common.cpp:
1186         (parseCommandLine):
1187         * MiniBrowser/win/Common.h:
1188         * MiniBrowser/win/MainWindow.cpp:
1189         (MainWindow::init):
1190         * MiniBrowser/win/MainWindow.h:
1191         * MiniBrowser/win/MiniBrowserWebHost.cpp:
1192         (MiniBrowserWebHost::updateAddressBar):
1193         (MiniBrowserWebHost::didFinishLoadForFrame):
1194         (MiniBrowserWebHost::didStartProvisionalLoadForFrame):
1195         (MiniBrowserWebHost::didFailLoadWithError):
1196         (MiniBrowserWebHost::didHandleOnloadEventsForFrame):
1197         (MiniBrowserWebHost::didFirstLayoutInFrame):
1198         * MiniBrowser/win/PageLoadTestClient.cpp: Removed.
1199         * MiniBrowser/win/PageLoadTestClient.h: Removed.
1200         * MiniBrowser/win/ResourceLoadDelegate.cpp:
1201         (ResourceLoadDelegate::identifierForInitialRequest):
1202         (ResourceLoadDelegate::willSendRequest):
1203         (ResourceLoadDelegate::didFinishLoadingFromDataSource):
1204         (ResourceLoadDelegate::didFailLoadingWithError):
1205         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1206         (WebKitBrowserWindow::create):
1207         (WebKitBrowserWindow::createNewPage):
1208         * MiniBrowser/win/WebKitBrowserWindow.h:
1209         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
1210         (WebKitLegacyBrowserWindow::create):
1211         (WebKitLegacyBrowserWindow::WebKitLegacyBrowserWindow):
1212         (WebKitLegacyBrowserWindow::exitProgram): Deleted.
1213         * MiniBrowser/win/WebKitLegacyBrowserWindow.h:
1214         (WebKitLegacyBrowserWindow::pageLoadTestClient): Deleted.
1215         * MiniBrowser/win/WinMain.cpp:
1216         (wWinMain):
1217
1218 2019-07-26  Jiewen Tan  <jiewen_tan@apple.com>
1219
1220         NavigationSOAuthorizationSession should check the active URL of the responding page after waking up from waiting
1221         https://bugs.webkit.org/show_bug.cgi?id=200150
1222         <rdar://problem/53280170>
1223
1224         Reviewed by Brent Fulgham.
1225
1226         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
1227         (TestWebKitAPI::TEST):
1228
1229 2019-07-26  Jonathan Bedard  <jbedard@apple.com>
1230
1231         Follow-up fix: results.webkit.org: Suite results shouldn't be the landing page
1232         https://bugs.webkit.org/show_bug.cgi?id=200090
1233
1234         Unreviewed follow-up fix.
1235
1236         * resultsdbpy/resultsdbpy/view/view_routes.py:
1237         (ViewRoutes.__init__): Keep /search endpoint for existing links
1238
1239 2019-07-26  Jonathan Bedard  <jbedard@apple.com>
1240
1241         results.webkit.org: Add switch to filter results by expectation
1242         https://bugs.webkit.org/show_bug.cgi?id=200134
1243
1244         Rubber-stamped by Aakash Jain.
1245
1246         Users of the results database should be able to easily differentiate tests which are expected
1247         to fail verse tests which are unexpectedly failing.
1248
1249         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
1250         (Timeline.render): Respect the willFilterExpected variable.
1251         (LegendLabel): Generates html for label in the legend.
1252         (Legend): Add switch for filter results.
1253         * resultsdbpy/resultsdbpy/view/templates/search.html: GIve Legend callback to re-render timelines.
1254         * resultsdbpy/resultsdbpy/view/templates/suite_results.html:
1255
1256 2019-07-26  Aakash Jain  <aakash_jain@apple.com>
1257
1258         [ews-build] Use update-webkit script in Style EWS
1259         https://bugs.webkit.org/show_bug.cgi?id=193196
1260
1261         Reviewed by Jonathan Bedard.
1262
1263         * BuildSlaveSupport/ews-build/factories.py:
1264         (StyleFactory): Updated to use CheckOutSource step as well.
1265         * BuildSlaveSupport/ews-build/steps.py: Added build-step to UpdateWorkingDirectory.
1266         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
1267
1268 2019-07-26  Jonathan Bedard  <jbedard@apple.com>
1269
1270         results.webkit.org: Support buildbot 0.8 CI links
1271         https://bugs.webkit.org/show_bug.cgi?id=200146
1272
1273         Reviewed by Aakash Jain.
1274
1275         * resultsdbpy/resultsdbpy/model/ci_context.py:
1276         (BuildbotEightURLFactory): Buildbot 0.8 link factory.
1277         (BuildbotEightURLFactory.__init__):
1278         (BuildbotEightURLFactory.url):
1279         * resultsdbpy/resultsdbpy/model/ci_context_unittest.py:
1280         (URLFactoryTest.test_old_builder_url):
1281         (URLFactoryTest):
1282         (URLFactoryTest.test_old_worker_url):
1283
1284 2019-07-26  Jonathan Bedard  <jbedard@apple.com>
1285
1286         results.webkit.org: Suite results shouldn't be the landing page
1287         https://bugs.webkit.org/show_bug.cgi?id=200090
1288
1289         Reviewed by Aakash Jain.
1290
1291         * resultsdbpy/resultsdbpy/view/templates/suite_results.html: Remove search bar.
1292         * resultsdbpy/resultsdbpy/view/view_routes.py:
1293         (ViewRoutes.__init__): Make search the landing page instead of suite results.
1294         * resultsdbpy/resultsdbpy/view/view_routes_unittest.py:
1295         (WebSiteUnittest.test_main):
1296
1297 2019-07-26  Jonathan Bedard  <jbedard@apple.com>
1298
1299         Follow-up fix: results.webkit.org: Color should be the worst result, count should include all results
1300         https://bugs.webkit.org/show_bug.cgi?id=200127
1301
1302         Unreviewed follow-up fix.
1303
1304         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
1305         (Dot.toString): Use self instead of this in render callback.
1306
1307 2019-07-24  Jiewen Tan  <jiewen_tan@apple.com>
1308
1309         WebPageProxy::receivedPolicyDecision should check navigation ID before clear pendingAPIRequest
1310         https://bugs.webkit.org/show_bug.cgi?id=200108
1311         <rdar://problem/53521238>
1312
1313         Reviewed by Chris Dumez.
1314
1315         Added an API test.
1316
1317         * TestWebKitAPI/Tests/WebKitCocoa/DecidePolicyForNavigationAction.mm:
1318         (-[DecidePolicyForNavigationActionController webView:decidePolicyForNavigationAction:decisionHandler:]):
1319         (TEST):
1320
1321 2019-07-25  Jonathan Bedard  <jbedard@apple.com>
1322
1323         results.webkit.org: Color should be the worst result, count should include all results
1324         https://bugs.webkit.org/show_bug.cgi?id=200127
1325
1326         Rubber-stamped by Aakash Jain.
1327
1328         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
1329         (Dot.prototype.toString): Do not differentiate the count based on the prevailing failure type.
1330
1331 2019-07-25  Zhifei Fang  <zhifei_fang@apple.com>
1332
1333         [Timeline]: Make timeline header width automatic, instead of fixed width
1334         https://bugs.webkit.org/show_bug.cgi?id=200059
1335
1336         Reviewed by Jonathan Bedard.
1337
1338         * resultsdbpy/resultsdbpy/view/static/css/timeline.css:
1339         (.dot.crash):
1340         (.timeline>.header): Deleted.
1341         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
1342         (.timeline>.content):
1343         (.timeline>.header):
1344
1345 2019-07-25  Ross Kirsling  <ross.kirsling@sony.com>
1346
1347         [ESNext] Implement nullish coalescing
1348         https://bugs.webkit.org/show_bug.cgi?id=200072
1349
1350         Reviewed by Darin Adler.
1351
1352         * Scripts/run-jsc-stress-tests:
1353
1354 2019-07-24  Fujii Hironori  <Hironori.Fujii@sony.com>
1355
1356         Add Takashi Komori and Tomoki Imai as contributors
1357
1358         Unreviewed.
1359
1360         * Scripts/webkitpy/common/config/contributors.json:
1361
1362 2019-07-24  Yusuke Suzuki  <ysuzuki@apple.com>
1363
1364         [bmalloc] Add IsoHeap test to ensure that IsoHeap pages are not allocating too large VA
1365         https://bugs.webkit.org/show_bug.cgi?id=200103
1366
1367         Reviewed by Mark Lam.
1368
1369         This patch adds tests to TestWTF IsoHeap tests to ensure that IsoHeap's component is not leaking pages or not allocating too large VAs for memory allocation.
1370         We use VMTag to get the system view of the allocated VAs and check whether it is not incredibly large.
1371
1372         While the tests are white-box tests (it means that this is a bit flaky to the implementation changes of IsoHeap), I adjusted some threshold to make this less-flaky
1373         to the future implementation changes while it catches the severe issues we had.
1374
1375         * TestWebKitAPI/Tests/WTF/bmalloc/IsoHeap.cpp:
1376         (assertEmptyPointerSet):
1377         (assertHasOnlyObjects):
1378         (assertClean):
1379         (TEST):
1380         (allocateAndDeallocate):
1381
1382 2019-07-24  Fujii Hironori  <fujii.hironori@gmail.com>
1383
1384         [CMake] CMAKE_SHARED_LINKER_FLAGS drops "-Wl,--no-undefined"
1385         https://bugs.webkit.org/show_bug.cgi?id=200074
1386
1387         Reviewed by Michael Catanzaro.
1388
1389         There was a latent issue. PluginTest::indicateTestFailure was
1390         using WTF::sleep without linking WTF.
1391
1392         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
1393         Added WebKit::WTF to WebKitTestNetscapePlugIn_LIBRARIES.
1394
1395 2019-07-24  Fujii Hironori  <fujii.hironori@gmail.com>
1396
1397         [GTK][WPE][CMake] failing to build TestWebKitAPIInjectedBundle due to missing forwarding headers
1398         https://bugs.webkit.org/show_bug.cgi?id=200073
1399
1400         Reviewed by Michael Catanzaro.
1401
1402         * TestWebKitAPI/PlatformGTK.cmake:
1403         * TestWebKitAPI/PlatformWPE.cmake:
1404         Added add_dependencies(TestWebKitAPIInjectedBundle TestWebKitAPI-forwarding-headers).
1405
1406 2019-07-24  Fujii Hironori  <Hironori.Fujii@sony.com>
1407
1408         [webkitperl] runCommand doesn't work in Windows Perl
1409         https://bugs.webkit.org/show_bug.cgi?id=199900
1410
1411         Reviewed by Don Olmstead.
1412
1413         runCommand was always failing implicit fork by using 'open' with
1414         '-|' in Windows Perl. Explicitly specify the command to 'open' not
1415         to do the implicit fork.
1416
1417         There is one more difference between Windows and Unix. 'open'
1418         successes on Windows even for non existent command while it fails
1419         on Unix. So, return the same error code on Unix as well as
1420         Windows.
1421
1422         * Scripts/VCSUtils.pm: Specified the command to 'open'.
1423         * Scripts/webkitperl/VCSUtils_unittest/runCommand.pl: 'echo'
1424         command is not available on Windows. Use Perl ($^X) instead.
1425
1426 2019-07-24  Priyanka Agarwal  <pagarwal999@apple.com>
1427
1428         Allow Clients to Add Fields to the AutoFillContext Dictionary.
1429         https://bugs.webkit.org/show_bug.cgi?id=199326
1430         rdar://problem/42816957
1431
1432         Reviewed by Wenson Hsieh.
1433
1434         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1435         (TestWebKitAPI::TEST): Created a test to check that the auto fill context
1436         is being properly populated with additional context dictionary.
1437
1438         * TestWebKitAPI/Tests/ios/TestInputDelegate.h:
1439         * TestWebKitAPI/Tests/ios/TestInputDelegate.mm:
1440         (-[TestInputDelegate setWebViewAdditionalContextForStrongPasswordAssistanceHandler:]): Setting the handler for the function
1441         which will populate the additional autofill context dictionary.
1442
1443         (-[TestInputDelegate webViewAdditionalContextForStrongPasswordAssistanceHandler]): Returns the handler for the function which
1444         populates the additional autofill context dictionary.
1445
1446         (-[TestInputDelegate _webViewAdditionalContextForStrongPasswordAssistance:]): Function which populates the additional autofill
1447         context dictionary.
1448
1449         (-[TestInputDelegate setFocusRequiresStrongPasswordAssistanceHandler:]): Setting the handler for the function which checks if the
1450         input field requires strong password work.
1451
1452         (-[TestInputDelegate focusRequiresStrongPasswordAssistanceHandler]): Returns the handler for the function which checks if the
1453         input field requires strong password work.
1454
1455         (-[TestInputDelegate _webView:focusRequiresStrongPasswordAssistance:]): Function which checks if the input field requires strong
1456         password work.
1457
1458 2019-07-24  Zhifei Fang  <zhifei_fang@apple.com>
1459
1460         run-javascriptcore-tests won't report test results for testmasm, testair, testb3, testdfg and test api
1461         https://bugs.webkit.org/show_bug.cgi?id=199489
1462
1463         Reviewed by Aakash Jain.
1464
1465         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1466         (RunJavaScriptCoreTests.start): Skip run jsc test binaries for mips, armv7, aarch64.
1467         (RunJavaScriptCoreTests.countFailures): Pick up the test binaires failure to total failures count
1468         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1469         * Scripts/run-javascriptcore-tests: The script now failed wether the run-jsc-stress-tests failed or test binaries failed.
1470         (runTest): Record test binary failure
1471         (reportTestFailures): Report test binary failure
1472         (runJSCStressTests):
1473         * Scripts/webkitpy/common/config/ports.py: Skip run jsc test binaries for those need to run remotely
1474         (JscOnlyPort.build_jsc_command):
1475         (JscOnlyPort):
1476         (JscOnlyPort.run_javascriptcore_tests_command):
1477         * Scripts/webkitpy/common/config/ports_unittest.py:
1478         (DeprecatedPortTest.test_jsconly_port):
1479
1480 2019-07-24  Zalan Bujtas  <zalan@apple.com>
1481
1482         ASSERTION FAILED: settings().textAutosizingEnabled() && settings().textAutosizingUsesIdempotentMode() in WebCore::Page::recomputeTextAutoSizingInAllFrames()
1483         https://bugs.webkit.org/show_bug.cgi?id=200079
1484         <rdar://problem/53474325>
1485
1486         Reviewed by Wenson Hsieh.
1487
1488         Reset textAutosizingUsesIdempotentMode when transitioning to a new test.
1489
1490         * WebKitTestRunner/ios/TestControllerIOS.mm:
1491         (WTR::TestController::platformResetPreferencesToConsistentValues):
1492
1493 2019-07-23  Fujii Hironori  <Hironori.Fujii@sony.com>
1494
1495         [webkitperl] prepare-ChangeLog_unittest/parser_unittests.pl is failing on Windows Perl
1496         https://bugs.webkit.org/show_bug.cgi?id=199927
1497
1498         Reviewed by Alex Christensen.
1499
1500         convertAbsolutepathToWebKitPath was failing to convert paths on
1501         Windows Perl due to path separators mismatch.
1502
1503         Renamed convertAbsolutepathToWebKitPath to
1504         convertAbsolutePathToRelativeUnixPath, and changed it to replace
1505         paths to relative Unix paths.
1506
1507         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
1508         (convertAbsolutePathToRelativeUnixPath): Added.
1509         (convertAbsolutepathToWebKitPath): Deleted.
1510
1511 2019-07-23  Alex Christensen  <achristensen@webkit.org>
1512
1513         Fix iOS API test after r247759
1514         https://bugs.webkit.org/show_bug.cgi?id=200045
1515
1516         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1517         (TEST):
1518         In the iOS simulator, the WebProcess was being started before we were setting the value on the WKProcessPool.
1519         To fix this, set the value on the WKProcessPool before making the WKWebView.  This makes the test always pass on Mac and iOS.
1520
1521 2019-07-23  Keith Rollin  <krollin@apple.com>
1522
1523         Remove rest of NavigatorContentUtils support
1524         https://bugs.webkit.org/show_bug.cgi?id=200052
1525         <rdar://problem/53467357>
1526
1527         Reviewed by Alex Christensen.
1528
1529         Bug 196070 removes most of the support for the never-used
1530         NavigatorContentUtils facility. However, there were still a couple of
1531         left-over references after that change. This patch sweeps those up.
1532
1533         * Scripts/webkitperl/FeatureList.pm:
1534
1535 2019-07-23  Alex Christensen  <achristensen@webkit.org>
1536
1537         Move javaScriptConfigurationDirectory SPI from _WKProcessPoolConfiguration to WKProcessPoolPrivate to make it runtime switchable
1538         https://bugs.webkit.org/show_bug.cgi?id=200045
1539
1540         Reviewed by Mark Lam.
1541
1542         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1543         (TEST):
1544
1545 2019-07-23  Russell Epstein  <repstein@apple.com>
1546
1547         Unreviewed, rolling out r247745.
1548
1549         This broke API test
1550         TestWebKitAPI.WKProcessPool.JavaScriptConfiguration as
1551         indicated by EWS
1552
1553         Reverted changeset:
1554
1555         "Move javaScriptConfigurationDirectory SPI from
1556         _WKProcessPoolConfiguration to WKProcessPoolPrivate to make it
1557         runtime switchable"
1558         https://bugs.webkit.org/show_bug.cgi?id=200045
1559         https://trac.webkit.org/changeset/247745
1560
1561 2019-07-23  Alex Christensen  <achristensen@webkit.org>
1562
1563         Move javaScriptConfigurationDirectory SPI from _WKProcessPoolConfiguration to WKProcessPoolPrivate to make it runtime switchable
1564         https://bugs.webkit.org/show_bug.cgi?id=200045
1565
1566         Reviewed by Mark Lam.
1567
1568         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1569         (TEST):
1570
1571 2019-07-23  Alex Christensen  <achristensen@webkit.org>
1572
1573         Add SPI for setting media cache and key location on _WKWebsiteDataStoreConfiguration
1574         https://bugs.webkit.org/show_bug.cgi?id=199972
1575
1576         Reviewed by Jer Noble.
1577
1578         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1579         (TEST):
1580
1581 2019-07-23  Alicia Boya García  <aboya@igalia.com>
1582
1583         [WTF] Add DataMutex and MainThreadData wrappers
1584         https://bugs.webkit.org/show_bug.cgi?id=199831
1585
1586         Reviewed by Alex Christensen.
1587
1588         Added a very simple test that checks that DataMutex<T> indeed takes
1589         the lock and indeed holds data.
1590
1591         * TestWebKitAPI/CMakeLists.txt:
1592         * TestWebKitAPI/Tests/WTF/DataMutex.cpp: Added.
1593         (TestWebKitAPI::TEST):
1594
1595 2019-07-23  Wenson Hsieh  <wenson_hsieh@apple.com>
1596
1597         [macOS 10.15] Web process crashes when attempting to show the font panel via Font > Show Fonts
1598         https://bugs.webkit.org/show_bug.cgi?id=200021
1599         <rdar://problem/53301325>
1600
1601         Reviewed by Ryosuke Niwa.
1602
1603         Add support for grabbing the child menu items of a context menu item.
1604
1605         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1606         (WTR::getMenuItemChildrenCallback):
1607
1608 2019-07-23  Ryosuke Niwa  <rniwa@webkit.org>
1609
1610         WebKit should strip away system font names from the pasted content
1611         https://bugs.webkit.org/show_bug.cgi?id=199975
1612         <rdar://problem/53336353>
1613
1614         Reviewed by Darin Adler.
1615
1616         Added a test to strip away system font names such as ".AppleSystemUIFont", ".SFUI-Regular", and ".SF UI Mono".
1617
1618         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1619         * TestWebKitAPI/Tests/WebKitCocoa/PasteHTML.mm:
1620         * TestWebKitAPI/Tests/WebKitCocoa/cocoa-writer-markup-with-system-fonts.html: Added.
1621
1622 2019-07-22  Aakash Jain  <aakash_jain@apple.com>
1623
1624         [ews-build] EWS fails to parse multi-line full_results.json
1625         https://bugs.webkit.org/show_bug.cgi?id=199992
1626
1627         Reviewed by Alexey Proskuryakov.
1628
1629         * BuildSlaveSupport/ews-build/layout_test_failures.py:
1630         (LayoutTestFailures.results_from_string): Concatenate content into single line.
1631         * BuildSlaveSupport/ews-build/steps_unittest.py:
1632         (test_parse_results_json_with_newlines): Unit-test to cover this scenario.
1633
1634 2019-07-22  Jonathan Bedard  <jbedard@apple.com>
1635
1636         resultsdbpy: Handle case where the previous commit doesn't have the changelog
1637         https://bugs.webkit.org/show_bug.cgi?id=200015
1638
1639         Reviewed by Aakash Jain.
1640
1641         * resultsdbpy/resultsdbpy/model/repository.py:
1642         (WebKitRepository.commit_for_id.diff_changelogs): Allow the previous_response to be None.
1643
1644 2019-07-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1645
1646         [iOS] [WK1] UIWebView always jumps to the top left corner when scrolling to reveal the selection
1647         https://bugs.webkit.org/show_bug.cgi?id=200013
1648         <rdar://problem/52526901>
1649
1650         Reviewed by Simon Fraser.
1651
1652         Add a new API test to verify that inserting text in UIWebView causes the document to scroll.
1653
1654         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1655         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollToRevealSelection.mm: Added.
1656         (-[LegacyLoadingDelegate webViewDidFinishLoad:]):
1657         (-[LegacyLoadingDelegate waitForDidFinishLoad]):
1658         * TestWebKitAPI/ios/UIKitSPI.h:
1659
1660 2019-07-22  Jer Noble  <jer.noble@apple.com>
1661
1662         REGRESSION(rUnknown): YouTube playback pauses when switching to a new tab
1663         https://bugs.webkit.org/show_bug.cgi?id=199971
1664         <rdar://problem/51951218>
1665
1666         Reviewed by Alex Christensen.
1667
1668         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1669         * TestWebKitAPI/Tests/WebKitCocoa/NoPauseWhenSwitchingTabs.mm: Added.
1670         (TestWebKitAPI::TEST):
1671
1672 2019-07-22  Aakash Jain  <aakash_jain@apple.com>
1673
1674         [ews-build] Add an EWS to run services tests
1675         https://bugs.webkit.org/show_bug.cgi?id=199994
1676
1677         Reviewed by Jonathan Bedard.
1678
1679         * BuildSlaveSupport/ews-build/config.json: Added Services-EWS configuration.
1680         * BuildSlaveSupport/ews-build/factories.py: Added ServicesFactory.
1681         * BuildSlaveSupport/ews-build/steps.py:
1682         (CheckPatchRelevance): Run this EWS only for patches with changes in relevant files.
1683         (RunEWSUnitTests): Build step to run EWS unit-tests.
1684         (RunEWSBuildbotCheckConfig): Build step to run buildbot checkconfig command.
1685         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
1686         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py: Added services status-bubble.
1687
1688 2019-07-22  Youenn Fablet  <youenn@apple.com>
1689
1690         Disable MediaRecorder for legacy WebKit
1691         https://bugs.webkit.org/show_bug.cgi?id=200001
1692         <rdar://problem/53400030>
1693
1694         Reviewed by Eric Carlson.
1695
1696         Enable MediaRecorder for testing purposes.
1697
1698         * DumpRenderTree/mac/DumpRenderTree.mm:
1699         (createWebViewAndOffscreenWindow):
1700
1701 2019-07-22  Jonathan Bedard  <jbedard@apple.com>
1702
1703         results.webkit.org: Timeline header is too small
1704         https://bugs.webkit.org/show_bug.cgi?id=199955
1705
1706         Reviewed by Aakash Jain.
1707
1708         * resultsdbpy/resultsdbpy/view/static/css/timeline.css:
1709         (.timeline>.header): Make timeline header larder to fit configuration names.
1710
1711 2019-07-22  Alex Christensen  <achristensen@webkit.org>
1712
1713         Add SPI to _WKWebsiteDataStoreConfiguration for configuring application cache storage location
1714         https://bugs.webkit.org/show_bug.cgi?id=199954
1715
1716         Reviewed by Geoff Garen.
1717
1718         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1719         (TEST):
1720
1721 2019-07-22  Alex Christensen  <achristensen@webkit.org>
1722
1723         Add SPI _WKProcessPoolConfiguration.javaScriptConfigurationDirectory
1724         https://bugs.webkit.org/show_bug.cgi?id=199917
1725
1726         Reviewed by Sam Weinig.
1727
1728         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1729         (TEST):
1730
1731 2019-07-22  Aakash Jain  <aakash_jain@apple.com>
1732
1733         [ews-build] ReRunWebKitTests should use similar logic for evaluateCommand as RunWebKitTests
1734         https://bugs.webkit.org/show_bug.cgi?id=199980
1735
1736         Reviewed by Jonathan Bedard.
1737
1738         * BuildSlaveSupport/ews-build/steps.py:
1739         (ReRunWebKitTests.evaluateCommand): Updatd to use similar logic as RunWebKitTests.
1740         * BuildSlaveSupport/ews-build/steps_unittest.py:
1741         (TestRunWebKitTests): Modified to make it generic so as to re-use tests.
1742         (TestReRunWebKitTests): Run all TestRunWebKitTests unit-tests for ReRunWebKitTests as well.
1743
1744 2019-07-22  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1745
1746         [webkitpy] Add an unit test for setting up the driver environment without starting it.
1747         https://bugs.webkit.org/show_bug.cgi?id=199945
1748
1749         Reviewed by Michael Catanzaro.
1750
1751         This adds an unit test for the change implemented in r247663.
1752
1753         * Scripts/webkitpy/port/driver_unittest.py:
1754         (DriverTest.test_setup_environ_base_vars):
1755         (DriverTest):
1756         (DriverTest.test_setup_environ_without_starting_driver):
1757
1758 2019-07-21  Wenson Hsieh  <wenson_hsieh@apple.com>
1759
1760         [iOS] [WebKit2] Add limited support for -isPosition:atBoundary:inDirection: in WKContentView
1761         https://bugs.webkit.org/show_bug.cgi?id=199993
1762         <rdar://problem/49523528>
1763
1764         Reviewed by Beth Dakin.
1765
1766         Add a new API test to verify the behavior of -isPosition:atBoundary:inDirection:.
1767
1768         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
1769         (TestWebKitAPI::TEST):
1770         * TestWebKitAPI/cocoa/TestWKWebView.h:
1771
1772 2019-07-21  Andres Gonzalez  <andresg_22@apple.com>
1773
1774         Add accessibilityInsertText for text insertion in edit fields.
1775         https://bugs.webkit.org/show_bug.cgi?id=199973
1776
1777         Reviewed by Chris Fleizach.
1778
1779         Renamed accessibilityInsertText to _accessibilityInsertText.
1780
1781         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1782         (AccessibilityUIElement::insertText):
1783         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1784         (AccessibilityUIElement::insertText):
1785         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1786         (WTR::AccessibilityUIElement::insertText):
1787         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1788         (WTR::AccessibilityUIElement::insertText):
1789
1790 2019-07-20  Chris Dumez  <cdumez@apple.com>
1791
1792         Speed up HashTable decoding by reserving capacity and avoiding rehashing
1793         https://bugs.webkit.org/show_bug.cgi?id=199982
1794
1795         Reviewed by Saam Barati.
1796
1797         Add API test coverage.
1798
1799         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
1800         (TestWebKitAPI::TEST):
1801
1802 2019-07-20  Andres Gonzalez  <andresg_22@apple.com>
1803
1804         Add accessibilityInsertText for text insertion in edit fields.
1805         https://bugs.webkit.org/show_bug.cgi?id=199973
1806
1807         Reviewed by Chris Fleizach.
1808
1809         Glue code to run new LayoutTests.
1810         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1811         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1812         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1813         (WTR::AccessibilityUIElement::insertText):
1814         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1815         (WTR::AccessibilityUIElement::insertText):
1816         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1817         (WTR::AccessibilityUIElement::insertText):
1818         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
1819         (WTR::AccessibilityUIElement::insertText):
1820
1821 2019-07-19  Zhifei Fang  <zhifei_fang@apple.com>
1822
1823         Move webkit.css to opensource to support resultsdbpy's frontend
1824         https://bugs.webkit.org/show_bug.cgi?id=199957
1825
1826         Reviewed by Jonathan Bedard.
1827
1828         * resultsdbpy/resultsdbpy/view/static/library/css/docs.yaml: Added.
1829         * resultsdbpy/resultsdbpy/view/static/library/css/generate-webkit-css-docs: Added.
1830         * resultsdbpy/resultsdbpy/view/static/library/css/index.html: Added.
1831         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css: Added.
1832
1833 2019-07-19  Zhifei Fang  <zhifei_fang@apple.com>
1834
1835         Move Ref.js to WebKit to support resultsdbpy's frontend
1836         https://bugs.webkit.org/show_bug.cgi?id=199956
1837
1838         Reviewed by Jonathan Bedard.
1839
1840         * resultsdbpy/resultsdbpy/view/static/js/drawer.js:
1841         * resultsdbpy/resultsdbpy/view/static/js/search.js:
1842         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
1843         * resultsdbpy/resultsdbpy/view/static/library/js/Ref.js: Added.
1844         * resultsdbpy/resultsdbpy/view/static/library/js/Utils.js: Added.
1845         * resultsdbpy/resultsdbpy/view/static/library/js/components/BaseComponents.js: Added.
1846         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js: Added.
1847         * resultsdbpy/resultsdbpy/view/templates/base.html:
1848         * resultsdbpy/resultsdbpy/view/templates/commits.html:
1849         * resultsdbpy/resultsdbpy/view/templates/documentation.html:
1850         * resultsdbpy/resultsdbpy/view/templates/search.html:
1851         * resultsdbpy/resultsdbpy/view/templates/suite_results.html:
1852         * resultsdbpy/resultsdbpy/view/view_routes.py:
1853
1854 2019-07-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1855
1856         [webkitpy] Allow the testrunner driver to setup the environment completely without needing to start the server process.
1857         https://bugs.webkit.org/show_bug.cgi?id=199945
1858
1859         Reviewed by Michael Catanzaro.
1860
1861         Refactor the code to create the Driver temporal directories inside Driver._setup_environ_for_driver().
1862         This allows external callers to setup the environment for running tests by calling that method without needing to start the server process.
1863         When this callers finish testing, it is enough with calling either Driver.stop() or Driver._delete_temporal_directories().
1864
1865         * Scripts/webkitpy/port/driver.py:
1866         (Driver._setup_environ_for_driver):
1867         (Driver._create_temporal_directories):
1868         (Driver):
1869         (Driver._start):
1870         (Driver._delete_temporal_directories):
1871         (Driver.stop):
1872         * Scripts/webkitpy/w3c/wpt_runner.py: Not needed anymore to start the driver since this doesnt need the server process running.
1873         (main):
1874         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py: Ditto.
1875         (WebDriverTestRunner.__init__):
1876         * glib/api_test_runner.py:
1877         (TestRunner._setup_testing_environment): Ditto.
1878
1879 2019-07-19  Aakash Jain  <aakash_jain@apple.com>
1880
1881         [ews-build] Display pre-existing Layout test failure names in the build summary
1882         https://bugs.webkit.org/show_bug.cgi?id=199941
1883
1884         Reviewed by Jonathan Bedard.
1885
1886         * BuildSlaveSupport/ews-build/steps.py:
1887         (AnalyzeLayoutTestsResults.report_pre_existing_failures):
1888
1889 2019-07-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1890
1891         [GTK][WPE] run-webkit-tests should run with a temporal homedir
1892         https://bugs.webkit.org/show_bug.cgi?id=199738
1893
1894         Reviewed by Michael Catanzaro.
1895
1896         Run the tests with an empty homedir that is created inside the driver tmpdir.
1897         The driver tmpdir is a random directory created for each test runner that is purged after the run.
1898
1899         This is done to ensure that the test results are not affected by the user settings of any library.
1900
1901         * Scripts/webkitpy/port/driver.py:
1902         (Driver._setup_environ_for_driver):
1903         * Scripts/webkitpy/port/driver_unittest.py:
1904         (DriverTest.test_setup_environ_base_vars):
1905         (DriverTest):
1906         (DriverTest.test_create_temporal_home_dir):
1907
1908 2019-07-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1909
1910         Remove pywebsockets from thirdparty
1911         https://bugs.webkit.org/show_bug.cgi?id=199710
1912
1913         Reviewed by Jonathan Bedard.
1914
1915         We have a very old version of pywebsocket in webkitpy thirdparty, but we are also importing pywebsocket as part
1916         of wpt tools. We can simply use the wpt one for all websocket tests and remove the old copy from sources.
1917
1918         * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
1919         (PyWebSocket._prepare_config): Use pywebsocket from imported w3c tools directory.
1920         * Scripts/webkitpy/thirdparty/mod_pywebsocket/COPYING: Removed.
1921         * Scripts/webkitpy/thirdparty/mod_pywebsocket/__init__.py: Removed.
1922         * Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_base.py: Removed.
1923         * Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_hixie75.py: Removed.
1924         * Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_hybi.py: Removed.
1925         * Scripts/webkitpy/thirdparty/mod_pywebsocket/common.py: Removed.
1926         * Scripts/webkitpy/thirdparty/mod_pywebsocket/dispatch.py: Removed.
1927         * Scripts/webkitpy/thirdparty/mod_pywebsocket/extensions.py: Removed.
1928         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/__init__.py: Removed.
1929         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/_base.py: Removed.
1930         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/hybi.py: Removed.
1931         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/hybi00.py: Removed.
1932         * Scripts/webkitpy/thirdparty/mod_pywebsocket/headerparserhandler.py: Removed.
1933         * Scripts/webkitpy/thirdparty/mod_pywebsocket/http_header_util.py: Removed.
1934         * Scripts/webkitpy/thirdparty/mod_pywebsocket/memorizingfile.py: Removed.
1935         * Scripts/webkitpy/thirdparty/mod_pywebsocket/msgutil.py: Removed.
1936         * Scripts/webkitpy/thirdparty/mod_pywebsocket/mux.py: Removed.
1937         * Scripts/webkitpy/thirdparty/mod_pywebsocket/standalone.py: Removed.
1938         * Scripts/webkitpy/thirdparty/mod_pywebsocket/stream.py: Removed.
1939         * Scripts/webkitpy/thirdparty/mod_pywebsocket/util.py: Removed.
1940
1941 2019-07-18  Jonathan Bedard  <jbedard@apple.com>
1942
1943         results.webkit.org: Move resultsdbpy to WebKit
1944         https://bugs.webkit.org/show_bug.cgi?id=199837
1945         <rdar://problem/53172130>
1946
1947         Rubber-stamped by Aakash Jain.
1948
1949         Moving the entirety of the resultsdbpy library, which provides utilities to build
1950         a database designed to store, visualize and organize test results, into WebKit.
1951
1952         * Scripts/webkitpy/style/checker.py:
1953         (CheckerDispatcher._create_checker): resulltsdbpy is a Python 3 library.
1954         * resultsdbpy: Added.
1955         * resultsdbpy/MANIFEST.in: Added.
1956         * resultsdbpy/README.md: Added.
1957         * resultsdbpy/resultsdbpy: Added.
1958         * resultsdbpy/resultsdbpy/__init__.py: Added.
1959         * resultsdbpy/resultsdbpy/controller: Added.
1960         * resultsdbpy/resultsdbpy/controller/__init__.py: Added.
1961         * resultsdbpy/resultsdbpy/controller/api_routes.py: Added.
1962         * resultsdbpy/resultsdbpy/controller/ci_controller.py: Added.
1963         * resultsdbpy/resultsdbpy/controller/ci_controller_unittest.py: Added.
1964         * resultsdbpy/resultsdbpy/controller/commit.py: Added.
1965         * resultsdbpy/resultsdbpy/controller/commit_controller.py: Added.
1966         * resultsdbpy/resultsdbpy/controller/commit_controller_unittest.py: Added.
1967         * resultsdbpy/resultsdbpy/controller/commit_unittest.py: Added.
1968         * resultsdbpy/resultsdbpy/controller/configuration.py: Added.
1969         * resultsdbpy/resultsdbpy/controller/configuration_controller.py: Added.
1970         * resultsdbpy/resultsdbpy/controller/configuration_controller_unittest.py: Added.
1971         * resultsdbpy/resultsdbpy/controller/configuration_unittest.py: Added.
1972         * resultsdbpy/resultsdbpy/controller/suite_controller.py: Added.
1973         * resultsdbpy/resultsdbpy/controller/suite_controller_unittest.py: Added.
1974         * resultsdbpy/resultsdbpy/controller/test_controller.py: Added.
1975         * resultsdbpy/resultsdbpy/controller/test_controller_unittest.py: Added.
1976         * resultsdbpy/resultsdbpy/controller/upload_controller.py: Added.
1977         * resultsdbpy/resultsdbpy/controller/upload_controller_unittest.py: Added.
1978         * resultsdbpy/resultsdbpy/flask_support: Added.
1979         * resultsdbpy/resultsdbpy/flask_support/__init__.py: Added.
1980         * resultsdbpy/resultsdbpy/flask_support/authed_blueprint.py: Added.
1981         * resultsdbpy/resultsdbpy/flask_support/flask_test_context.py: Added.
1982         * resultsdbpy/resultsdbpy/flask_support/flask_testcase.py: Added.
1983         * resultsdbpy/resultsdbpy/flask_support/util.py: Added.
1984         * resultsdbpy/resultsdbpy/flask_support/util_unittest.py: Added.
1985         * resultsdbpy/resultsdbpy/model: Added.
1986         * resultsdbpy/resultsdbpy/model/__init__.py: Added.
1987         * resultsdbpy/resultsdbpy/model/cassandra_context.py: Added.
1988         * resultsdbpy/resultsdbpy/model/cassandra_context_unittest.py: Added.
1989         * resultsdbpy/resultsdbpy/model/casserole.py: Added.
1990         * resultsdbpy/resultsdbpy/model/casserole_unittest.py: Added.
1991         * resultsdbpy/resultsdbpy/model/ci_context.py: Added.
1992         * resultsdbpy/resultsdbpy/model/ci_context_unittest.py: Added.
1993         * resultsdbpy/resultsdbpy/model/commit_context.py: Added.
1994         * resultsdbpy/resultsdbpy/model/commit_context_unittest.py: Added.
1995         * resultsdbpy/resultsdbpy/model/configuration_context.py: Added.
1996         * resultsdbpy/resultsdbpy/model/configuration_context_unittest.py: Added.
1997         * resultsdbpy/resultsdbpy/model/docker-compose.yml: Added.
1998         * resultsdbpy/resultsdbpy/model/docker.py: Added.
1999         * resultsdbpy/resultsdbpy/model/docker_unittest.py: Added.
2000         * resultsdbpy/resultsdbpy/model/mock_cassandra_context.py: Added.
2001         * resultsdbpy/resultsdbpy/model/mock_model_factory.py: Added.
2002         * resultsdbpy/resultsdbpy/model/mock_repository.py: Added.
2003         * resultsdbpy/resultsdbpy/model/model.py: Added.
2004         * resultsdbpy/resultsdbpy/model/partitioned_redis.py: Added.
2005         * resultsdbpy/resultsdbpy/model/partitioned_redis_unittest.py: Added.
2006         * resultsdbpy/resultsdbpy/model/redis_unittest.py: Added.
2007         * resultsdbpy/resultsdbpy/model/repository.py: Added.
2008         * resultsdbpy/resultsdbpy/model/repository_unittest.py: Added.
2009         * resultsdbpy/resultsdbpy/model/suite_context.py: Added.
2010         * resultsdbpy/resultsdbpy/model/suite_context_unittest.py: Added.
2011         * resultsdbpy/resultsdbpy/model/test_context.py: Added.
2012         * resultsdbpy/resultsdbpy/model/test_context_unittest.py: Added.
2013         * resultsdbpy/resultsdbpy/model/upload_context.py: Added.
2014         * resultsdbpy/resultsdbpy/model/upload_context_unittest.py: Added.
2015         * resultsdbpy/resultsdbpy/model/wait_for_docker_test_case.py: Added.
2016         * resultsdbpy/resultsdbpy/run-tests: Added.
2017         * resultsdbpy/resultsdbpy/view: Added.
2018         * resultsdbpy/resultsdbpy/view/__init__.py: Added.
2019         * resultsdbpy/resultsdbpy/view/ci_view.py: Added.
2020         * resultsdbpy/resultsdbpy/view/commit_view.py: Added.
2021         * resultsdbpy/resultsdbpy/view/commit_view_unittest.py: Added.
2022         * resultsdbpy/resultsdbpy/view/site_menu.py: Added.
2023         * resultsdbpy/resultsdbpy/view/static: Added.
2024         * resultsdbpy/resultsdbpy/view/static/css: Added.
2025         * resultsdbpy/resultsdbpy/view/static/css/commit.css: Added.
2026         * resultsdbpy/resultsdbpy/view/static/css/drawer.css: Added.
2027         * resultsdbpy/resultsdbpy/view/static/css/search.css: Added.
2028         * resultsdbpy/resultsdbpy/view/static/css/timeline.css: Added.
2029         * resultsdbpy/resultsdbpy/view/static/js: Added.
2030         * resultsdbpy/resultsdbpy/view/static/js/commit.js: Added.
2031         * resultsdbpy/resultsdbpy/view/static/js/common.js: Added.
2032         * resultsdbpy/resultsdbpy/view/static/js/configuration.js: Added.
2033         * resultsdbpy/resultsdbpy/view/static/js/drawer.js: Added.
2034         * resultsdbpy/resultsdbpy/view/static/js/search.js: Added.
2035         * resultsdbpy/resultsdbpy/view/static/js/timeline.js: Added.
2036         * resultsdbpy/resultsdbpy/view/suite_view.py: Added.
2037         * resultsdbpy/resultsdbpy/view/templates: Added.
2038         * resultsdbpy/resultsdbpy/view/templates/base.html: Added.
2039         * resultsdbpy/resultsdbpy/view/templates/commit.html: Added.
2040         * resultsdbpy/resultsdbpy/view/templates/commits.html: Added.
2041         * resultsdbpy/resultsdbpy/view/templates/documentation.html: Added.
2042         * resultsdbpy/resultsdbpy/view/templates/error.html: Added.
2043         * resultsdbpy/resultsdbpy/view/templates/search.html: Added.
2044         * resultsdbpy/resultsdbpy/view/templates/suite_results.html: Added.
2045         * resultsdbpy/resultsdbpy/view/view_routes.py: Added.
2046         * resultsdbpy/resultsdbpy/view/view_routes_unittest.py: Added.
2047         * resultsdbpy/setup.py: Added.
2048
2049 2019-07-18  Alex Christensen  <achristensen@webkit.org>
2050
2051         Add and test _WKWebsiteDataStoreConfiguration.deviceIdHashSaltsStorageDirectory SPI
2052         https://bugs.webkit.org/show_bug.cgi?id=199923
2053
2054         Reviewed by Youenn Fablet.
2055
2056         * TestWebKitAPI/Tests/WebKit/GetUserMediaNavigation.mm:
2057         (TestWebKitAPI::TEST):
2058
2059 2019-07-18  Aakash Jain  <aakash_jain@apple.com>
2060
2061         [ews-build] Enable iOS WK2 tester queue on new EWS
2062         https://bugs.webkit.org/show_bug.cgi?id=199867
2063
2064         Reviewed by Jonathan Bedard.
2065
2066         * BuildSlaveSupport/ews-build/config.json: Enabled the triggers for ios-wk2 queue.
2067         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py: Enabled ios-sim (builder) and ios-wk2 (tester) bubbles.
2068         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js: Removed ios-sim queue from bot-watcher's dashboard.
2069         * QueueStatusServer/config/queues.py: Removed ios-sim queue from old EWS.
2070
2071 2019-07-18  Aakash Jain  <aakash_jain@apple.com>
2072
2073         [ews-build] Add build step to AnalyzeLayoutTestsResults
2074         https://bugs.webkit.org/show_bug.cgi?id=199877
2075
2076         Reviewed by Jonathan Bedard.
2077
2078         Logic is ported from webkitpy/tool/bot/patchanalysistask.py::_retry_layout_tests()
2079
2080         * BuildSlaveSupport/ews-build/steps.py:
2081         (RunWebKitTestsWithoutPatch.evaluateCommand): invoke AnalyzeLayoutTestsResults step.
2082         (AnalyzeLayoutTestsResults): Build step to analyze layout-test results.
2083         (AnalyzeLayoutTestsResults.report_failure):
2084         (AnalyzeLayoutTestsResults.report_pre_existing_failures):
2085         (AnalyzeLayoutTestsResults.retry_build):
2086         (AnalyzeLayoutTestsResults._results_failed_different_tests):
2087         (AnalyzeLayoutTestsResults._report_flaky_tests):
2088         (AnalyzeLayoutTestsResults.start):
2089         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
2090
2091 2019-07-18  Alex Christensen  <achristensen@webkit.org>
2092
2093         Move NetworkCache ownership from NetworkProcess to NetworkSession
2094         https://bugs.webkit.org/show_bug.cgi?id=199817
2095
2096         Reviewed by Geoff Garen.
2097
2098         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2099         (TEST):
2100         * TestWebKitAPI/cocoa/TestWKWebView.h:
2101         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2102         (-[WKWebView synchronouslyLoadRequest:]):
2103
2104 2019-07-18  Youenn Fablet  <youenn@apple.com>
2105
2106         Make sure to set kCTFontFallbackOptionAttribute to kCTFontFallbackOptionSystem for system fonts
2107         https://bugs.webkit.org/show_bug.cgi?id=199769
2108         <rdar://problem/49390297>
2109
2110         Reviewed by Myles C. Maxfield.
2111
2112         Add a font containing one extended character not found in system fonts.
2113
2114         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2115         * WebKitTestRunner/fonts/FakeHelvetica-SingleExtendedCharacter.ttf: Added.
2116
2117 2019-07-18  Konstantin Tokarev  <annulen@yandex.ru>
2118
2119         Unreviewed, Add Olivier Blin as contributor
2120
2121         * Scripts/webkitpy/common/config/contributors.json:
2122
2123 2019-07-17  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2124
2125         [GTK][WPE][webkitpy] Refactor drivers to use the base driver for setting up the environment and start the drivers.
2126         https://bugs.webkit.org/show_bug.cgi?id=199855
2127
2128         Reviewed by Michael Catanzaro.
2129
2130         The webkitpy drivers for GTK and WPE use their own versions for setting
2131         up the environment and starting/stopping the drivers.
2132         This refactors those drivers to use the base class driver functions.
2133         As a benefit we get some fixes like support for setting the profiler
2134         environment variables, and a simpler code.
2135
2136         * Scripts/webkitpy/port/driver.py:
2137         (Driver._setup_environ_for_driver): This already correctly setups LOCAL_RESOURCE_ROOT and DUMPRENDERTREE_TEMP.
2138         Add the remaining environment variable XDG_CACHE_HOME that is needed for Linux.
2139         * Scripts/webkitpy/port/headlessdriver.py:
2140         (HeadlessDriver._setup_environ_for_test):
2141         * Scripts/webkitpy/port/waylanddriver.py:
2142         (WaylandDriver._setup_environ_for_test):
2143         * Scripts/webkitpy/port/westondriver.py:
2144         (WestonDriver._setup_environ_for_test):
2145         (WestonDriver.stop):
2146         * Scripts/webkitpy/port/westondriver_unittest.py: now mock _test_runner_process_constructor as base driver does.
2147         (WestonDriverTest.make_driver):
2148         * Scripts/webkitpy/port/xorgdriver.py:
2149         (XorgDriver._setup_environ_for_test):
2150         * Scripts/webkitpy/port/xvfbdriver.py: the xvfb binary is started with the port server env
2151         (XvfbDriver._setup_environ_for_test):
2152         * Scripts/webkitpy/port/xvfbdriver_unittest.py: rename the variable to make clearer that it uses the port server env.
2153         (XvfbDriverTest.make_driver):
2154         (XvfbDriverTest.test_start):
2155         (XvfbDriverTest.test_start_arbitrary_worker_number):
2156         * Scripts/webkitpy/w3c/wpt_runner.py:
2157         (main): Start the driver before trying to get its environment to define all the environment variables.
2158         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
2159         (WebDriverTestRunner.__init__): Ditto.
2160         * glib/api_test_runner.py:
2161         (TestRunner._setup_testing_environment): Ditto.
2162
2163 2019-07-17  Antoine Quint  <graouts@apple.com>
2164
2165         Disable Pointer Events prior to watchOS 6
2166         https://bugs.webkit.org/show_bug.cgi?id=199890
2167         <rdar://problem/53206113>
2168
2169         Reviewed by Dean Jackson.
2170
2171         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2172
2173 2019-07-17  Christopher Reid  <chris.reid@sony.com>
2174
2175         Bytecode cache should use FileSystem
2176         https://bugs.webkit.org/show_bug.cgi?id=199759
2177
2178         Reviewed by Yusuke Suzuki.
2179
2180         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
2181
2182 2019-07-17  Jonathan Bedard  <jbedard@apple.com>
2183
2184         check-webkit-style: Add limited Python3 support
2185         https://bugs.webkit.org/show_bug.cgi?id=199870
2186
2187         Rubber-stamped by Aakash Jain.
2188
2189         Since new services will be added in the near future which are Python 3, we
2190         need to support Python 3 style checks. For now, assume all Python files are
2191         Python 2 unless otherwise specified.
2192
2193         * Scripts/webkitpy/style/checker.py:
2194         (_all_categories): Add pycodestyle to valid categories for testing.
2195         (CheckerDispatcher._create_checker): Check that the provided Python file is in
2196         one of the declared Python 3 directories.
2197         * Scripts/webkitpy/style/checkers/python.py:
2198         (Python3Checker): Add Python 3 checker, which doesn't lint and uses pycodestyle
2199         instead of pep8.
2200         (Python3Checker.__init__):
2201         (Python3Checker.check):
2202         * Scripts/webkitpy/thirdparty/__init__.py:
2203         (AutoinstallImportHook.find_module): Support auto-installing pycodestyle.
2204         (AutoinstallImportHook._install_pycodestyle):
2205
2206 2019-07-17  Sam Weinig  <weinig@apple.com>
2207
2208         Add StringBuilder member function which allows makeString() style variadic argument construction
2209         https://bugs.webkit.org/show_bug.cgi?id=198997
2210
2211         Reviewed by Darin Adler.
2212
2213         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2214         Add basic test showing that StringBuilder::flexibleAppend can be used to
2215         append one or more string adaptable types.
2216
2217         * TestWebKitAPI/CMakeLists.txt:
2218         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2219         Add WTFStringUtilities.cpp
2220
2221         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2222         Add basic test showing that StringBuilder::flexibleAppend can be used to
2223         append one or more string adaptable types.
2224
2225         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
2226         * TestWebKitAPI/WTFStringUtilities.cpp: Added.
2227         * TestWebKitAPI/WTFStringUtilities.h:
2228         Move WTF_STRINGTYPEADAPTER_COPIED_WTF_STRING() and wtfStringCopyCount to WTFStringUtilities.h/cpp
2229         to allow for a single definition of StringTypeAdapter<String, void> which is required for ODR.
2230
2231 2019-07-17  Ryosuke Niwa  <rniwa@webkit.org>
2232
2233         Remove the file superfluously added in r247535.
2234
2235         * TestWebKitAPI/Tests/ios/SelectionModifyByParagraphBoundary.h: Removed.
2236         * TestWebKitAPI/Tests/ios/SelectionModifyByParagraphBoundary.mm:
2237
2238 2019-07-17  Alex Christensen  <achristensen@webkit.org>
2239
2240         Add a runtime-disabled dialog element skeleton
2241         https://bugs.webkit.org/show_bug.cgi?id=199839
2242
2243         Reviewed by Ryosuke Niwa.
2244
2245         * DumpRenderTree/mac/DumpRenderTree.mm:
2246         (resetWebPreferencesToConsistentValues):
2247         * WebKitTestRunner/TestController.cpp:
2248         (WTR::TestController::resetPreferencesToConsistentValues):
2249         Enable the dialog element for layout tests.
2250
2251 2019-07-17  Ryosuke Niwa  <rniwa@webkit.org>
2252
2253         [iOS] Option + Up or Down Arrow key doesn’t move cursor past paragraph boundaries in WebKit2
2254         https://bugs.webkit.org/show_bug.cgi?id=199851
2255
2256         Reviewed by Wenson Hsieh.
2257
2258         Added a regression test for iOS. Unfortunately, event sender, etc... doesn't work because
2259         this code is getting directly triggered from UIKeyboard's code.
2260
2261         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2262         * TestWebKitAPI/Tests/ios/SelectionModifyByParagraphBoundary.h: Added.
2263         * TestWebKitAPI/Tests/ios/SelectionModifyByParagraphBoundary.mm: Added.
2264         * TestWebKitAPI/ios/UIKitSPI.h:
2265
2266 2019-07-17  Commit Queue  <commit-queue@webkit.org>
2267
2268         Unreviewed, rolling out r247505.
2269         https://bugs.webkit.org/show_bug.cgi?id=199871
2270
2271         "Caused failed ASSERT in stress test" (Requested by creid on
2272         #webkit).
2273
2274         Reverted changeset:
2275
2276         "Bytecode cache should use FileSystem"
2277         https://bugs.webkit.org/show_bug.cgi?id=199759
2278         https://trac.webkit.org/changeset/247505
2279
2280 2019-07-17  Russell Epstein  <russell_e@apple.com>
2281
2282         Adding self to contributors.json
2283
2284         Unreviewed.
2285
2286         * Scripts/webkitpy/common/config/contributors.json:
2287
2288 2019-07-17  Aakash Jain  <aakash_jain@apple.com>
2289
2290         [ews-build] Parse full_results.json for layout-tests
2291         https://bugs.webkit.org/show_bug.cgi?id=199804
2292
2293         Reviewed by Jonathan Bedard.
2294
2295         * BuildSlaveSupport/ews-build/steps.py:
2296         (RunWebKitTests.start): Monitor json output.
2297         (RunWebKitTests.commandComplete): Read json output, parse the results and set Buildbot properties accordingly. These
2298         properties would be used in subsequent AnalyzeLayoutTests build step to determine whether the failures are introduced
2299         by the patch or are pre-existing.
2300         (ReRunWebKitTests.commandComplete): Ditto.
2301         (RunWebKitTestsWithoutPatch.commandComplete): Ditto.
2302         * BuildSlaveSupport/ews-build/steps_unittest.py:
2303         (BuildStepMixinAdditions.getProperty): Added.
2304         (TestRunWebKitTests.test_parse_results_json): Added unit-tests.
2305         * BuildSlaveSupport/ews-build/layout_test_failures.py: Parse full_results.json and generate list of failing tests.
2306
2307 2019-07-17  Michael Catanzaro  <mcatanzaro@igalia.com>
2308
2309         Unreviewed, rolling out r247512.
2310
2311         Broke API test runners
2312
2313         Reverted changeset:
2314
2315         "[GTK][WPE][webkitpy] Refactor drivers to use the base driver
2316         for setting up the environment and start the drivers."
2317         https://bugs.webkit.org/show_bug.cgi?id=199855
2318         https://trac.webkit.org/changeset/247512
2319
2320 2019-07-17  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2321
2322         [GTK][WPE][webkitpy] Refactor drivers to use the base driver for setting up the environment and start the drivers.
2323         https://bugs.webkit.org/show_bug.cgi?id=199855
2324
2325         Reviewed by Carlos Garcia Campos.
2326
2327         The webkitpy drivers for GTK and WPE use their own versions for setting
2328         up the environment and starting/stopping the drivers.
2329         This refactors those drivers to use the base class driver functions.
2330         As a benefit we get some fixes like support for setting the profiler
2331         environment variables, and a simpler code.
2332
2333         * Scripts/webkitpy/port/driver.py:
2334         (Driver._setup_environ_for_driver): This already correctly setups LOCAL_RESOURCE_ROOT and DUMPRENDERTREE_TEMP.
2335         Add the remaining environment variable XDG_CACHE_HOME that is needed for Linux.
2336         * Scripts/webkitpy/port/headlessdriver.py:
2337         (HeadlessDriver._setup_environ_for_test):
2338         * Scripts/webkitpy/port/waylanddriver.py:
2339         (WaylandDriver._setup_environ_for_test):
2340         * Scripts/webkitpy/port/westondriver.py:
2341         (WestonDriver._setup_environ_for_test):
2342         (WestonDriver.stop):
2343         * Scripts/webkitpy/port/westondriver_unittest.py: now mock _test_runner_process_constructor as base driver does.
2344         (WestonDriverTest.make_driver):
2345         * Scripts/webkitpy/port/xorgdriver.py:
2346         (XorgDriver._setup_environ_for_test):
2347         * Scripts/webkitpy/port/xvfbdriver.py: the xvfb binary is started with the port server env
2348         (XvfbDriver._setup_environ_for_test):
2349         * Scripts/webkitpy/port/xvfbdriver_unittest.py: rename the variable to make clearer that it uses the port server env.
2350         (XvfbDriverTest.make_driver):
2351         (XvfbDriverTest.test_start):
2352         (XvfbDriverTest.test_start_arbitrary_worker_number):
2353
2354 2019-07-16  Christopher Reid  <chris.reid@sony.com>
2355
2356         Bytecode cache should use FileSystem
2357         https://bugs.webkit.org/show_bug.cgi?id=199759
2358
2359         Reviewed by Yusuke Suzuki.
2360
2361         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
2362
2363 2019-07-16  Jonathan Bedard  <jbedard@apple.com>
2364
2365         svn-create-patch duplicates diffs when adding directories
2366         https://bugs.webkit.org/show_bug.cgi?id=199842
2367
2368         Reviewed by Dewei Zhu.
2369
2370         * Scripts/svn-create-patch:
2371         (findKind): Add function which returns what 'kind' of file the provided path is.
2372         (generateFileList): If the path is a directory and being added, don't add it.
2373         Instead, rely on the fact that its children will be added.
2374
2375 2019-07-16  Tim Horton  <timothy_horton@apple.com>
2376
2377         NSTextFinder holes don't scroll with the page
2378         https://bugs.webkit.org/show_bug.cgi?id=199815
2379         <rdar://problem/52280514>
2380
2381         Reviewed by Simon Fraser.
2382
2383         * MiniBrowser/mac/WK2BrowserWindowController.m:
2384         (-[MiniBrowserNSTextFinder performAction:]):
2385         (-[WK2BrowserWindowController awakeFromNib]):
2386         Adopt the WebKit UI in MiniBrowser. Also, override NSTextFinder's
2387         -performAction: so that we can intercept the close action and
2388         hide our own find UI, since there is no delegate for that action yet.
2389
2390         * TestWebKitAPI/Tests/WebKitCocoa/FindInPage.mm:
2391         (TEST):
2392
2393 2019-07-15  Keith Miller  <keith_miller@apple.com>
2394
2395         JSGlobalObject type macros should support feature flags and WeakRef should have one
2396         https://bugs.webkit.org/show_bug.cgi?id=199601
2397
2398         Reviewed by Mark Lam.
2399
2400         JSC options need to be set before the window is created for the test.
2401
2402         * DumpRenderTree/mac/DumpRenderTree.mm:
2403         (resetWebViewToConsistentStateBeforeTesting):
2404         * DumpRenderTree/win/DumpRenderTree.cpp:
2405         (setJSCOptions):
2406         (resetWebViewToConsistentStateBeforeTesting):
2407
2408 2019-07-15  Said Abou-Hallawa  <sabouhallawa@apple.com>
2409
2410         [ Mojave WK1 ] Some Image tests are flakey failures and are failing in tandem with zoomed in or blank image results
2411         https://bugs.webkit.org/show_bug.cgi?id=193108
2412
2413         Reviewed by Simon Fraser.
2414
2415         Add a workaround for <rdar://problem/17084993> in createBitmapContextFromWebView().
2416         Re-request the snapshot at kCGWindowImageNominalResolution if it was captured
2417         at the wrong scale.
2418
2419         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
2420         (takeWindowSnapshot):
2421         (createBitmapContextFromWebView):
2422
2423 2019-07-15  Brady Eidson  <beidson@apple.com>
2424
2425         Make WKURLSchemeTask thread safe.
2426         <rdar://problem/50471863> and https://bugs.webkit.org/show_bug.cgi?id=199764
2427
2428         Reviewed by Alex Christensen.
2429
2430         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
2431
2432 2019-07-15  Jiewen Tan  <jiewen_tan@apple.com>
2433
2434         Unreviewed, a build fix after r247437
2435
2436         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
2437         Added platform guard towards -[WKUIDelegate _presentingViewControllerForWebView:].
2438
2439 2019-07-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2440
2441         [macOS 10.15] Cannot unbold selected text when the system font is used
2442         https://bugs.webkit.org/show_bug.cgi?id=199788
2443         <rdar://problem/52142570>
2444
2445         Reviewed by Tim Horton.
2446
2447         Add a new API test to verify that bolding and unbolding updates the
2448         shared font manager's selected font.
2449
2450         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
2451         (TestWebKitAPI::TEST):
2452
2453 2019-07-15  Jiewen Tan  <jiewen_tan@apple.com>
2454
2455         [iOS] SOAuthorizationSession should tell AppSSO whether the UIClient is capable of showing the extension UI
2456         https://bugs.webkit.org/show_bug.cgi?id=199790
2457         <rdar://problem/52790112>
2458
2459         Reviewed by Brent Fulgham.
2460
2461         Add tests to check SOAuthorization.enableEmbeddedAuthorizationViewController accordingly.
2462
2463         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
2464         (-[TestSOAuthorizationDelegate _presentingViewControllerForWebView:]):
2465         (configureSOAuthorizationWebView):
2466         (TestWebKitAPI::TEST):
2467         (-[TestSOAuthorizationNavigationDelegate init]): Deleted.
2468         (-[TestSOAuthorizationNavigationDelegate webView:didFinishNavigation:]): Deleted.
2469         (-[TestSOAuthorizationNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
2470         (-[TestSOAuthorizationNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]): Deleted.
2471         (-[TestSOAuthorizationNavigationDelegate _webView:decidePolicyForSOAuthorizationLoadWithCurrentPolicy:forExtension:completionHandler:]): Deleted.
2472
2473 2019-07-15  Sihui Liu  <sihui_liu@apple.com>
2474
2475         window.openDatabase is not writable
2476         https://bugs.webkit.org/show_bug.cgi?id=199737
2477         <rdar://problem/52551332>
2478
2479         Reviewed by Chris Dumez.
2480
2481         * TestWebKitAPI/Tests/WebKitCocoa/WebSQLBasics.mm:
2482         (TEST):
2483         * TestWebKitAPI/Tests/WebKitCocoa/opendatabase-always-exists.html:
2484
2485 2019-07-15  Aakash Jain  <aakash_jain@apple.com>
2486
2487         [ews-build] Parse and display layout test failures
2488         https://bugs.webkit.org/show_bug.cgi?id=199709
2489
2490         Rubber-stamped by Jonathan Bedard.
2491
2492         * BuildSlaveSupport/ews-build/steps.py:
2493         (RunWebKitTests.start): Initialize log_observer.
2494         (RunWebKitTests._strip_python_logging_prefix): Copied from similar code in build.webkit.org buildbot config.
2495         (RunWebKitTests._parseRunWebKitTestsOutput): Ditto.
2496         (RunWebKitTests.commandComplete): Gather and parse the stdout and stderr logs.
2497         (RunWebKitTests.evaluateResult): Analyze the results and decide build status.
2498         (RunWebKitTests.getResultSummary): Update build and step summary.
2499         * BuildSlaveSupport/ews-build/steps_unittest.py: Added and updated unit-tests.
2500
2501 2019-07-15  Commit Queue  <commit-queue@webkit.org>
2502
2503         Unreviewed, rolling out r247393.
2504         https://bugs.webkit.org/show_bug.cgi?id=199797
2505
2506         broke mips and arm EWS (Requested by guijemont on #webkit).
2507
2508         Reverted changeset:
2509
2510         "run-javascriptcore-tests won't report test results for
2511         testmasm, testair, testb3, testdfg and test api"
2512         https://bugs.webkit.org/show_bug.cgi?id=199489
2513         https://trac.webkit.org/changeset/247393
2514
2515 2019-07-12  Andy Estes  <aestes@apple.com>
2516
2517         [Cocoa] -loadFileURL:allowingReadAccessToURL: should fully resolve file URLs
2518         https://bugs.webkit.org/show_bug.cgi?id=199768
2519         <rdar://problem/52002206>
2520
2521         Reviewed by Geoffrey Garen.
2522
2523         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm:
2524         (TEST):
2525
2526 2019-07-12  Aakash Jain  <aakash_jain@apple.com>
2527
2528         [ews-build] Remove wincairo queue from old EWS and dashboard
2529         https://bugs.webkit.org/show_bug.cgi?id=199776
2530
2531         Reviewed by Don Olmstead.
2532
2533         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2534         * QueueStatusServer/config/queues.py:
2535
2536 2019-07-12  Aakash Jain  <aakash_jain@apple.com>
2537
2538         [ews-build] Enable wincairo queue on new EWS
2539         https://bugs.webkit.org/show_bug.cgi?id=199593
2540
2541         Reviewed by Don Olmstead.
2542
2543         * BuildSlaveSupport/ews-build/config.json: Enabled the triggers for wincairo builder.
2544         * BuildSlaveSupport/ews-build/factories.py: Added required build steps for wincairo factory.
2545         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2546         (StatusBubble): Enable wincairo status-bubble.
2547
2548 2019-07-12  Aakash Jain  <aakash_jain@apple.com>
2549
2550         [ews-app] Enable logging for clicking SubmitToEWS button
2551         https://bugs.webkit.org/show_bug.cgi?id=199757
2552
2553         Unreviewed minor infrastructure fix.
2554
2555         * BuildSlaveSupport/ews-app/ews/views/submittoews.py:
2556         (SubmitToEWS.post): Change logging level from debug to info.
2557
2558 2019-07-12  Alex Christensen  <achristensen@webkit.org>
2559
2560         Enable client certificate authentication unit test
2561         https://bugs.webkit.org/show_bug.cgi?id=199735
2562
2563         Reviewed by Chris Dumez.
2564
2565         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
2566         (TEST):
2567         I originally wrote this in https://bugs.webkit.org/show_bug.cgi?id=197800 but it was disabled because it crashed.
2568         I found what was crashing.  I was reading out of bounds on my vector of 2 strings :(
2569
2570 2019-07-12  Alex Christensen  <achristensen@webkit.org>
2571
2572         Begin unifying TestWebKitAPI build
2573         https://bugs.webkit.org/show_bug.cgi?id=199728
2574
2575         Reviewed by Keith Miller.
2576
2577         * TestWebKitAPI/Configurations/Base.xcconfig:
2578         * TestWebKitAPI/Scripts/generate-unified-sources.sh: Added.
2579         * TestWebKitAPI/Sources.txt: Added.
2580         * TestWebKitAPI/SourcesCocoa.txt: Added.
2581         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2582
2583 2019-07-12  Zhifei Fang  <zhifei_fang@apple.com>
2584
2585         run-javascriptcore-tests won't report test results for testmasm, testair, testb3, testdfg and test api
2586         https://bugs.webkit.org/show_bug.cgi?id=199489
2587         <rdar://problem/47891081>
2588
2589         Reviewed by Aakash Jain.
2590
2591         * BuildSlaveSupport/build.webkit.org-config/steps.py:
2592         (RunJavaScriptCoreTests.countFailures):
2593         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
2594         * Scripts/run-javascriptcore-tests:
2595         (runTest):
2596         (reportTestFailures):
2597         (runJSCStressTests):
2598
2599 2019-07-12  Aakash Jain  <aakash_jain@apple.com>
2600
2601         [ews-build] Make layout-tests' full_results.json accessible in Buildbot
2602         https://bugs.webkit.org/show_bug.cgi?id=199743
2603
2604         Reviewed by Jonathan Bedard.
2605
2606         * BuildSlaveSupport/ews-build/steps.py:
2607         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
2608
2609 2019-07-11  Aakash Jain  <aakash_jain@apple.com>
2610
2611         Unreviewed follow-up fix to r247364.
2612         [ews-build] Add build step to clean up .git/index.lock file
2613         https://bugs.webkit.org/show_bug.cgi?id=199722
2614
2615         * BuildSlaveSupport/ews-build/steps.py:
2616         (CheckOutSource): CheckOutSource should not haltOnFailure since CleanUpGitIndexLock step needs
2617         to be run after this step.
2618
2619 2019-07-11  Yusuke Suzuki  <ysuzuki@apple.com>
2620
2621         Flaky API Test TestWTF.bmalloc.ScavengedMemoryShouldBeReused
2622         https://bugs.webkit.org/show_bug.cgi?id=199524
2623         <rdar://problem/52783816>
2624
2625         Reviewed by Saam Barati.
2626
2627         This test is white-box one and it has strong assumption how IsoHeap allocates pages.
2628         But this test has several problems.
2629
2630         1. IsoPage::numObjects is not the exact number of how many we allocate objects. This
2631            number is calculated by pageSize / sizeof(T), and this does not account the header
2632            size of IsoPage. So, # of objects per IsoPage is less than numObjects. Since sizeof(double)
2633            is very small, we can have many objects in one IsoPage. As a result, we need a large
2634            bitmap in IsoPage. This reduces # of objects in IsoPage largely. So, `ptrs.size()` becomes
2635            less than numObjects.
2636
2637         2. We now have lower tier of allocation in IsoHeap. It means that we allocate 8 objects in
2638            shared page (page is shared, but memory is pinned for a specific type) before using IsoHeap's
2639            page. This also makes the intention of this test wrong.
2640
2641         Due to (1), we access OoB of ptrs vector, passing a garbage to IsoHeap::deallocate, and crashing.
2642
2643         We make this test robust while we still keep this test white-box one to test the critical feature
2644         of IsoHeap. We first exhaust lower tier of IsoHeap, and after that, start testing the memory. We
2645         allocate many pointers, deallocate them, allocate one pointer while keeping pointers in the lower
2646         tier live, and check whether the deallocated memory is reused.
2647
2648         * TestWebKitAPI/Tests/WTF/bmalloc/IsoHeap.cpp:
2649         (TEST):
2650
2651 2019-07-11  Pablo Saavedra  <psaavedra@igalia.com>
2652
2653         [WPE][GTK] Build failure with ENABLE_ACCESSIBILITY=OFF
2654         https://bugs.webkit.org/show_bug.cgi?id=199625
2655
2656         Added ENABLE(ACCESSIBILITY) and replaced HAVE(ACCESSIBILITY)
2657         with ENABLE(ACCESSIBILITY) in the code.
2658
2659         Additionally, the TestRunner code generator now honors the
2660         Conditional IDL format.
2661
2662         Reviewed by Konstantin Tokarev.
2663
2664         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
2665         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.cpp:
2666         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.cpp:
2667         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2668         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
2669         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarker.idl:
2670         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarkerRange.idl:
2671         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2672         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
2673         (_generateImplementationFile):
2674
2675 2019-07-11  Aakash Jain  <aakash_jain@apple.com>
2676
2677         [ews-build] Add build step to clean up .git/index.lock file
2678         https://bugs.webkit.org/show_bug.cgi?id=199722
2679
2680         Reviewed by Jonathan Bedard.
2681
2682         * BuildSlaveSupport/ews-build/steps.py:
2683         (CheckOutSource.getResultSummary): Run CleanUpGitIndexLock step when CheckOutSource fails.
2684         (CleanUpGitIndexLock.__init__): Configure timeout and logEnviron.
2685         (CleanUpGitIndexLock.evaluateCommand): Always RETRY the build after this step is run.
2686         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
2687
2688 2019-07-11  Jonathan Bedard  <jbedard@apple.com>
2689
2690         [iOS 13] Enable WebKit build
2691         https://bugs.webkit.org/show_bug.cgi?id=199481
2692         <rdar://problem/52619048>
2693
2694         Reviewed by Tim Horton.
2695
2696         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig: Add iOS framework stubs.
2697
2698 2019-07-11  Ryan Haddad  <ryanhaddad@apple.com>
2699
2700         Add test expectations and baselines for iOS 13
2701         https://bugs.webkit.org/show_bug.cgi?id=199329
2702
2703         Reviewed by Jonathan Bedard.
2704
2705         * Scripts/webkitpy/port/ios.py:
2706         (IOSPort): Increment current version to 13.
2707         * Scripts/webkitpy/port/ios_device_unittest.py: Update unit tests.
2708         (IOSDeviceTest.test_layout_test_searchpath_with_apple_additions):
2709         (IOSDeviceTest.test_layout_test_searchpath_without_apple_additions):
2710         (IOSDeviceTest.test_layout_searchpath_wih_device_type):
2711         * Scripts/webkitpy/port/ios_simulator_unittest.py: Ditto.
2712         (IOSSimulatorTest.make_port):
2713         (IOSSimulatorTest.test_layout_test_searchpath_with_apple_additions):
2714         (IOSSimulatorTest.test_layout_test_searchpath_without_apple_additions):
2715         (IOSSimulatorTest.test_layout_searchpath_wih_device_type):
2716         * Scripts/webkitpy/port/ios_testcase.py: Ditto.
2717         (IOSTest.make_port):
2718
2719 2019-07-11  Joanmarie Diggs  <jdiggs@igalia.com>
2720
2721         AX: Implement support for ARIA roles insertion, deletion, subscript, superscript, and time
2722         https://bugs.webkit.org/show_bug.cgi?id=199692
2723
2724         Reviewed by Chris Fleizach.
2725
2726         Add support for output of AXDeletion and AXInsertion roles for tests.
2727         Update GTK and WPE jhbuild modules to use version of ATK and AT-SPI2
2728         which include ROLE_CONTENT_DELETION and ROLE_CONTENT_INSERTION.
2729
2730         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2731         * gtk/jhbuild.modules:
2732         * wpe/jhbuild.modules:
2733
2734 2019-07-11  Adrian Perez de Castro  <aperez@igalia.com>
2735
2736         [ews-build] Remove workers {ltilve,tanty}-gtk-wk2-ews from configuration
2737         https://bugs.webkit.org/show_bug.cgi?id=199707
2738
2739         Reviewed by Aakash Jain.
2740
2741         * BuildSlaveSupport/ews-build/config.json: Remove old unused workers.
2742
2743 2019-07-10  Simon Fraser  <simon.fraser@apple.com>
2744
2745         [iOS WK2] With modal overlay and body overflow:hidden, can't access all the content
2746         https://bugs.webkit.org/show_bug.cgi?id=199693
2747         rdar://problem/51930364
2748
2749         Reviewed by Tim Horton.
2750
2751         New API tests that test scrollability with various combinations of content, insets,
2752         input accessory bars etc.
2753
2754         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2755         * TestWebKitAPI/Tests/ios/ScrollViewScrollabilityTests.mm: Added.
2756         (TestWebKitAPI::webViewWithAutofocusedInput):
2757         (TestWebKitAPI::TEST):
2758
2759 2019-07-10  Tim Horton  <timothy_horton@apple.com>
2760
2761         Long pressing on attachments will crash the WebContent process
2762         https://bugs.webkit.org/show_bug.cgi?id=199696
2763         <rdar://problem/52920241>
2764
2765         Reviewed by Dean Jackson.
2766
2767         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
2768         (TestWebKitAPI::TEST):
2769         Add a test that previously crashed.
2770
2771 2019-07-10  Dean Jackson  <dino@apple.com>
2772
2773         Support MacCatalyst in run-webkit-app
2774         https://bugs.webkit.org/show_bug.cgi?id=199690
2775
2776         Reviewed by Tim Horton.
2777
2778         Add a --maccatalyst option to run-webkit-app that
2779         can launch MacCatalyst applications with a built WebKit.
2780
2781         * Scripts/webkitdirs.pm:
2782         (argumentsForConfiguration):
2783         (determineXcodeSDK):
2784         (xcodeSDKPlatformName):
2785         (determineConfigurationProductDir):
2786         (determinePortName):
2787         (isCatalystWebKit):
2788         (isAppleCocoaWebKit):
2789         (willUseCatalystSDK):
2790
2791 2019-07-10  Ryan Haddad  <ryanhaddad@apple.com>
2792
2793         [MacOS] Filter VPA info logged to stdout
2794         https://bugs.webkit.org/show_bug.cgi?id=199673
2795
2796         Reviewed by Eric Carlson.
2797
2798         * Scripts/webkitpy/port/mac.py:
2799         (MacPort.logging_patterns_to_strip):
2800
2801 2019-07-10  Ryan Haddad  <ryanhaddad@apple.com>
2802
2803         Unreviewed, rolling out r247286.
2804
2805         Caused TestWTF.WTF.StringOperators to fail on debug bots
2806
2807         Reverted changeset:
2808
2809         "Add StringBuilder member function which allows makeString()
2810         style variadic argument construction"
2811         https://bugs.webkit.org/show_bug.cgi?id=198997
2812         https://trac.webkit.org/changeset/247286
2813
2814 2019-07-10  Aakash Jain  <aakash_jain@apple.com>
2815
2816         [ews-build] Explicitly use perl or python while invoking scripts
2817         https://bugs.webkit.org/show_bug.cgi?id=199669
2818
2819         Reviewed by Jonathan Bedard.
2820
2821         * BuildSlaveSupport/ews-build/steps.py: Explicitly added perl or python while invoking scripts.
2822         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests accordingly.
2823
2824 2019-07-10  Guillaume Emont  <guijemont@igalia.com>
2825
2826         Run tests on mips EWS
2827         https://bugs.webkit.org/show_bug.cgi?id=196854
2828
2829         Reviewed by Carlos Garcia Campos.
2830
2831         * Scripts/webkitpy/common/config/ews.json:
2832
2833 2019-07-09  Michael Catanzaro  <mcatanzaro@igalia.com>
2834
2835         [WPE][GTK] GUniqueOutPtr::release should return a raw pointer
2836         https://bugs.webkit.org/show_bug.cgi?id=199579
2837
2838         Reviewed by Carlos Garcia Campos.
2839
2840         * TestWebKitAPI/Tests/WTF/glib/GUniquePtr.cpp:
2841         (TestWebKitAPI::TEST):
2842
2843 2019-07-09  Chris Dumez  <cdumez@apple.com>
2844
2845         Fix integer type encoding / decoding in WKRemoteObjectCoder
2846         https://bugs.webkit.org/show_bug.cgi?id=199643
2847         <rdar://problem/52732342>
2848
2849         Reviewed by Anders Carlsson.
2850
2851         Update API test coverage.
2852
2853         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.h:
2854         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.mm:
2855         (TEST):
2856         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistryPlugIn.mm:
2857         (-[RemoteObjectRegistryPlugIn takeUnsignedLongLong:completionHandler:]):
2858         (-[RemoteObjectRegistryPlugIn takeLongLong:completionHandler:]):
2859         (-[RemoteObjectRegistryPlugIn takeUnsignedLong:completionHandler:]):
2860         (-[RemoteObjectRegistryPlugIn takeLong:completionHandler:]):
2861
2862 2019-07-09  Sam Weinig  <weinig@apple.com>
2863
2864         Add StringBuilder member function which allows makeString() style variadic argument construction
2865         https://bugs.webkit.org/show_bug.cgi?id=198997
2866
2867         Reviewed by Darin Adler.
2868
2869         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2870         Add basic test showing that StringBuilder::flexibleAppend can be used to
2871         append one or more string adaptable types.
2872
2873 2019-07-09  Sihui Liu  <sihui_liu@apple.com>
2874
2875         Only allow fetching and removing session credentials from WebsiteDataStore
2876         https://bugs.webkit.org/show_bug.cgi?id=199385
2877         <rdar://problem/52622080>
2878
2879         Reviewed by Alex Christensen.
2880
2881         removeDataOfTypes will no longer remove persistent credentials. We should clear persistent credentials using
2882         the new SPI after each test that creates persistent credentials, otherwise the later tests may use credentials
2883         left by previous tests and didReceiveAuthenticationChallenge will not be invoked.
2884
2885         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
2886         (TEST):
2887         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
2888         (TestWebKitAPI::TEST):
2889
2890 2019-07-09  Alex Christensen  <achristensen@webkit.org>
2891
2892         When parsing an IPv4 address, wait until after deciding it is indeed an IPv4 address before reporting syntax violations
2893         https://bugs.webkit.org/show_bug.cgi?id=199628
2894
2895         Reviewed by Brady Eidson.
2896
2897         * TestWebKitAPI/Tests/WTF/URLParser.cpp:
2898         (TestWebKitAPI::TEST_F):
2899
2900 2019-07-09  Alex Christensen  <achristensen@webkit.org>
2901
2902         Remove invalid assertion in URLParser::domainToASCII
2903         https://bugs.webkit.org/show_bug.cgi?id=199624
2904
2905         Reviewed by Brady Eidson.
2906
2907         * TestWebKitAPI/Tests/WTF/URLParser.cpp:
2908         (TestWebKitAPI::TEST_F):
2909
2910 2019-07-09  Alex Christensen  <achristensen@webkit.org>
2911
2912         URLParser should reserialize IPv6 addresses that end with a colon
2913         https://bugs.webkit.org/show_bug.cgi?id=199627
2914
2915         Reviewed by Brady Eidson.
2916
2917         * TestWebKitAPI/Tests/WTF/URLParser.cpp:
2918         (TestWebKitAPI::TEST_F):
2919
2920 2019-07-08  Aakash Jain  <aakash_jain@apple.com>
2921
2922         [ews-build] Do not run unix commands for windows in PrintConfiguration
2923         https://bugs.webkit.org/show_bug.cgi?id=199605
2924
2925         Reviewed by Jonathan Bedard.
2926
2927         * BuildSlaveSupport/ews-build/steps.py:
2928
2929 2019-07-08  Fujii Hironori  <Hironori.Fujii@sony.com>
2930
2931         JSTestGlobalObject.cpp of bindings-generation-tests is failing for Windows Python
2932         https://bugs.webkit.org/show_bug.cgi?id=199487
2933
2934         Reviewed by Ross Kirsling.
2935
2936         In Windows Python, preprocessor.pm is using cl.exe. cl.exe was
2937         failing to open testglobalscope_constructors_file which was
2938         created by using tempfile.mkstemp() because it keeps the file
2939         open. Use tempfile.mkdtemp() to create temporary files in the
2940         temporary directory instead of tempfile.mkstemp().
2941
2942         * Scripts/webkitpy/bindings/main.py:
2943         (BindingsTests.run_tests):
2944         (BindingsTests.main):
2945         (BindingsTests.close_and_remove): Deleted.
2946
2947 2019-07-08  Aakash Jain  <aakash_jain@apple.com>
2948
2949         [ews-build] Add KillOldProcesses step before running API or Layout tests
2950         https://bugs.webkit.org/show_bug.cgi?id=199592
2951
2952         Reviewed by Jonathan Bedard.
2953
2954         * BuildSlaveSupport/ews-build/factories.py:
2955
2956 2019-07-08  Jonathan Bedard  <jbedard@apple.com>
2957
2958         test-webkitpy: Explicitly use Python 2.7 lldb library
2959         https://bugs.webkit.org/show_bug.cgi?id=199578
2960         <rdar://problem/51853557>
2961
2962         Reviewed by Aakash Jain.
2963
2964         * Scripts/webkitpy/common/system/systemhost.py:
2965         (SystemHost.path_to_lldb_python_directory): Explicitly use Python 2.7 lldb libary.
2966         * Scripts/webkitpy/test/main.py:
2967         (_supports_building_and_running_lldb_tests): Run lldb tests on Catalina again.
2968
2969 2019-07-08  Ryan Haddad  <ryanhaddad@apple.com>
2970
2971         Add test expectations and baselines for Catalina
2972         https://bugs.webkit.org/show_bug.cgi?id=199328
2973
2974         Reviewed by Jonathan Bedard.
2975
2976         * Scripts/webkitpy/port/mac.py:
2977         (MacPort): Increment current version to 10.15 so that baseline search paths are correctly constructed for High Sierra.
2978
2979 2019-07-08  Christopher Reid  <chris.reid@sony.com>
2980
2981         Implement MappedFileData for Windows
2982         https://bugs.webkit.org/show_bug.cgi?id=198269
2983
2984         Reviewed by Darin Adler.
2985
2986         * TestWebKitAPI/PlatformWin.cmake:
2987
2988 2019-07-08  Charlie Turner  <cturner@igalia.com>
2989
2990         REGRESSION(r243197): [GStreamer] Web process hangs when scrolling twitter timeline which contains HLS videos
2991         https://bugs.webkit.org/show_bug.cgi?id=197558
2992
2993         Reviewed by Xabier Rodriguez-Calvar.
2994
2995         On shutdown we can easily deadlock the web process if we don't
2996         ensure all network operations are completed before comitting state
2997         changes. In HLS, make sure the network operations are cancelled,
2998         and also prevent hlsdemux's retry logic from scuppering our
2999         efforts.
3000
3001         * gstreamer/jhbuild.modules: Include the patch.
3002         * gstreamer/patches/gst-plugins-bad-do-not-retry-downloads-during-shutdown.patch: Added.
3003
3004 2019-07-08  Antoine Quint  <graouts@apple.com>
3005
3006         [Pointer Events] Enable only on the most recent version of the supported iOS family
3007         https://bugs.webkit.org/show_bug.cgi?id=199562
3008         <rdar://problem/52766511>
3009
3010         Reviewed by Dean Jackson.
3011
3012         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3013
3014 2019-07-06  Simon Fraser  <simon.fraser@apple.com>
3015
3016         Long hang when loading a cnn.com page on iOS
3017         https://bugs.webkit.org/show_bug.cgi?id=199556
3018
3019         Reviewed by Zalan Bujtas.
3020
3021         Add code to load a page by default in MobileMiniBrowser so it's easy to hack it
3022         to load a test page of your choice.
3023
3024         * MobileMiniBrowser/MobileMiniBrowserFramework/WebViewController.m:
3025         (-[WebViewController viewDidLoad]):
3026
3027 2019-07-05  Ryosuke Niwa  <rniwa@webkit.org>
3028
3029         [iOS] Crash in WebKit::WebPage::positionInformation via Range::startPosition
3030         https://bugs.webkit.org/show_bug.cgi?id=199503
3031
3032         Reviewed by Wenson Hsieh.
3033
3034         Added UIScriptController.ensurePositionInformationIsUpToDateAt using the existing WKWebView SPI:
3035         _requestActivatedElementAtPosition
3036
3037         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3038         (WTR::UIScriptController::ensurePositionInformationIsUpToDateAt):
3039         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3040         (WTR::UIScriptController::ensurePositionInformationIsUpToDateAt):
3041         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3042         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3043         (WTR::UIScriptController::ensurePositionInformationIsUpToDateAt):
3044         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3045         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3046         (WTR::UIScriptController::ensurePositionInformationIsUpToDateAt):
3047         * WebKitTestRunner/ios/UIScriptControllerMac.mm:
3048         (WTR::UIScriptController::ensurePositionInformationIsUpToDateAt):
3049
3050 2019-07-05  Ryan Haddad  <ryanhaddad@apple.com>
3051
3052         Unreviewed, rolling out r247115.
3053
3054         Breaks lldbWebKitTester (and by extension, test-webkitpy)
3055
3056         Reverted changeset:
3057
3058         "[WHLSL] Standard library is too big to directly include in
3059         WebCore"
3060         https://bugs.webkit.org/show_bug.cgi?id=198186
3061         https://trac.webkit.org/changeset/247115
3062
3063 2019-07-05  Ryan Haddad  <ryanhaddad@apple.com>
3064
3065         Unreviewed, rolling out r247123.
3066
3067         Caused TestWebKitAPI.Challenge.BasicProposedCredential to
3068         fail.
3069
3070         Reverted changeset:
3071
3072         "Only allow fetching and removing session credentials from
3073         WebsiteDataStore"
3074         https://bugs.webkit.org/show_bug.cgi?id=199385
3075         https://trac.webkit.org/changeset/247123
3076
3077 2019-07-05  Wenson Hsieh  <wenson_hsieh@apple.com>
3078
3079         Touching media controls sometimes shows software keyboard
3080         https://bugs.webkit.org/show_bug.cgi?id=199490
3081         <rdar://problem/52076270>
3082
3083         Reviewed by Eric Carlson.
3084
3085         Adds plumbing for a new testing hook to check whether or not there is an active input session. See other
3086         ChangeLog entries for more detail.
3087
3088         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3089         (WTR::UIScriptController::hasInputSession const):
3090         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3091         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3092         (WTR::UIScriptController::hasInputSession const):
3093         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3094         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3095         (WTR::UIScriptController::hasInputSession const):
3096
3097 2019-07-04  Aakash Jain  <aakash_jain@apple.com>
3098
3099         [ews-build] Remove GTK and WPE queue from old EWS and dashboard
3100         https://bugs.webkit.org/show_bug.cgi?id=199458
3101
3102         Reviewed by Michael Catanzaro.
3103
3104         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3105         * QueueStatusServer/config/queues.py:
3106
3107 2019-07-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3108
3109         [GTK] Fix browserperfdash script after r239522
3110         https://bugs.webkit.org/show_bug.cgi?id=199496
3111
3112         Reviewed by Michael Catanzaro.
3113
3114         * Scripts/webkitpy/browserperfdash/browserperfdash_runner.py:
3115         (BrowserPerfDashRunner.run): Pass None for the new required BenchmarkRunner constructor.
3116
3117 2019-07-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3118
3119         [webkitpy] test-webkitpy is broken on Linux since r246662
3120         https://bugs.webkit.org/show_bug.cgi?id=199493
3121
3122         Reviewed by Michael Catanzaro.
3123
3124         * Scripts/webkitpy/test/main.py:
3125         (_supports_building_and_running_lldb_tests): Add a check for None before calling startswith().
3126
3127 2019-07-02  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3128
3129         [GTK][WPE] Not longer needed to build woff2 on the JHBuild
3130         https://bugs.webkit.org/show_bug.cgi?id=199406
3131
3132         Reviewed by Michael Catanzaro.
3133
3134         Install the Woff2 libraries and headers from the system package
3135         and stop building them on the JHBuild.
3136
3137         * gtk/install-dependencies:
3138         * gtk/jhbuild.modules:
3139         * wpe/install-dependencies:
3140         * wpe/jhbuild.modules:
3141
3142 2019-07-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3143
3144         [GTK][WPE][CMake] The CMake cache should be clean when the JHBuild is rebuilt
3145         https://bugs.webkit.org/show_bug.cgi?id=199449
3146
3147         Reviewed by Michael Catanzaro.
3148
3149         * Scripts/webkitdirs.pm:
3150         (shouldRemoveCMakeCache): Clean the CMake cache if we detect that the JHBuild has been rebuilt.
3151
3152 2019-07-01  Philippe Normand  <pnormand@igalia.com>
3153
3154         Unreviewed, GTK a11y tests fix after r247071
3155
3156         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3157         (WTR::AccessibilityUIElement::popupValue const):
3158
3159 2019-07-03  Aakash Jain  <aakash_jain@apple.com>
3160
3161         [ews-build] Enable WPE and GTK queues on new EWS
3162         https://bugs.webkit.org/show_bug.cgi?id=199234
3163
3164         Reviewed by Jonathan Bedard.
3165
3166         * BuildSlaveSupport/ews-build/config.json: Enabled the triggers for GTK and WPE builders.
3167         * BuildSlaveSupport/ews-build/factories.py: Added required build steps for GTKFactory and WPEFactory.
3168         * BuildSlaveSupport/ews-build/steps.py:
3169         (CompileWebKit.evaluateCommand): Added InstallGtkDependencies/InstallWpeDependencies step before Compiling WebKit without patch.
3170         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
3171         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3172         (StatusBubble): Enable gtk and wpe status-bubbles.
3173
3174 2019-07-03  Sihui Liu  <sihui_liu@apple.com>
3175
3176         Only allow fetching and removing session credentials from WebsiteDataStore
3177         https://bugs.webkit.org/show_bug.cgi?id=199385
3178
3179         Reviewed by Alex Christensen.
3180
3181         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
3182         (TestWebKitAPI::TEST):
3183
3184 2019-07-03  Tim Horton  <timothy_horton@apple.com>
3185
3186         UI process exception when dragging an <attachment> with no content type
3187         https://bugs.webkit.org/show_bug.cgi?id=199480
3188         <rdar://problem/44351353>
3189
3190         Reviewed by Wenson Hsieh.
3191
3192         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3193         (TestWebKitAPI::TEST):
3194         Add a test; before the change, it crashes.
3195
3196 2019-07-03  Jonathan Bedard  <jbedard@apple.com>
3197
3198         [Catalina] Enable WebKit build
3199         https://bugs.webkit.org/show_bug.cgi?id=199209
3200
3201         Reviewed by Darin Adler.
3202
3203         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig: Add Mac framework stubs.
3204
3205 2019-07-03  Sam Weinig  <weinig@apple.com>
3206
3207         Adopt simple structured bindings in more places
3208         https://bugs.webkit.org/show_bug.cgi?id=199247
3209
3210         Reviewed by Alex Christensen.
3211
3212         Replaces simple uses of std::tie() with structured bindings. Does not touch
3213         uses of std::tie() that are not initial declarations, use std::ignore or in
3214         case where the binding is captured by a lambda, as structured bindings don't
3215         work for those cases yet.
3216
3217         * TestWebKitAPI/ios/PreferredContentMode.mm:
3218         (TestWebKitAPI::TEST):
3219
3220 2019-07-03  Aakash Jain  <aakash_jain@apple.com>
3221
3222         Unreviewed follow-up fix to r247049, default the platform to '*' when platform property is not set.
3223
3224         * BuildSlaveSupport/ews-build/steps.py:
3225         (PrintConfiguration.run):
3226
3227 2019-07-02  Aakash Jain  <aakash_jain@apple.com>
3228
3229         [ews-build] Add build steps to Install Wpe and Gtk dependencies
3230         https://bugs.webkit.org/show_bug.cgi?id=199408
3231
3232         Reviewed by Michael Catanzaro.
3233
3234         * BuildSlaveSupport/ews-build/steps.py:
3235         (InstallGtkDependencies): Build step to install dependencies for GTK. Set haltOnFailure=False so that in case of failure, build isn't
3236         marked as failed (which would indicated patch failed EWS), instead subsequent steps would be run and the build would be marked as RETRY.
3237         (InstallWpeDependencies): Ditto for WPE.
3238         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
3239
3240 2019-07-02  Aakash Jain  <aakash_jain@apple.com>
3241
3242         [ews-build] Allow skipping uploading built product for few builders
3243         https://bugs.webkit.org/show_bug.cgi?id=199422
3244
3245         Reviewed by Michael Catanzaro.
3246
3247         * BuildSlaveSupport/ews-build/steps.py:
3248         (CompileWebKit.__init__): Added optional skipUpload parameter.
3249         (CompileWebKit.evaluateCommand): Allow to skip upload if there are no triggers and skipUpload is True.
3250
3251 2019-07-02  Tim Horton  <timothy_horton@apple.com>
3252
3253         REGRESSION (r243240): Unable to swipe back in Safari
3254         https://bugs.webkit.org/show_bug.cgi?id=199394
3255         <rdar://problem/51137447>
3256
3257         Reviewed by Wenson Hsieh.
3258
3259         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3260         Make sure that we actually end up with swipe gesture recognizers installed
3261         after process swap and crash.
3262
3263 2019-07-02  Andres Gonzalez  <andresg_22@apple.com>
3264
3265         Enhance support of aria-haspopup per ARIA 1.1 specification.
3266         https://bugs.webkit.org/show_bug.cgi?id=199216
3267         <rdar://problem/46221342>
3268
3269         Reviewed by Chris Fleizach.
3270
3271         * DumpRenderTree/AccessibilityUIElement.cpp:
3272         (getPopupValueCallback):
3273         (AccessibilityUIElement::getJSClass):
3274         * DumpRenderTree/AccessibilityUIElement.h:
3275         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3276         (AccessibilityUIElement::popupValue const):
3277         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3278         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3279         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3280         (WTR::AccessibilityUIElement::popupValue const):
3281         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3282         (WTR::AccessibilityUIElement::popupValue const):
3283
3284 2019-07-02  Aakash Jain  <aakash_jain@apple.com>
3285
3286         [ews-build] Do not print worker environment variables in each build step [part 2]
3287         https://bugs.webkit.org/show_bug.cgi?id=199405
3288
3289         Reviewed by Jonathan Bedard.
3290
3291         * BuildSlaveSupport/ews-build/steps.py:
3292         (CheckOutSpecificRevision.__init__): Disabled logging of environment variables.
3293         (CleanWorkingDirectory.__init__): Ditto.
3294         (RunBindingsTests.__init__): Ditto.
3295         (RunWebKitPerlTests.__init__): Ditto.
3296         (RunWebKitPyTests.__init__): Ditto.
3297         (CompileWebKit.__init__): Ditto.
3298         (ArchiveTestResults.__init__): Ditto.
3299         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
3300
3301 2019-07-02  Jer Noble  <jer.noble@apple.com>
3302
3303         Pipe suport for 'cenc' init data type into CDMFairPlayStreaming
3304         https://bugs.webkit.org/show_bug.cgi?id=199381
3305         <rdar://problem/52483103>
3306
3307         Reviewed by Eric Carlson.
3308
3309         * TestWebKitAPI/Tests/WebCore/ISOBox.cpp:
3310
3311 2019-07-02  Aakash Jain  <aakash_jain@apple.com>
3312
3313         [ews-build] Update bot configuration for WPE and GTK
3314         https://bugs.webkit.org/show_bug.cgi?id=199238
3315
3316         Reviewed by Michael Catanzaro.
3317
3318         * BuildSlaveSupport/ews-build/config.json:
3319
3320 2019-07-02  Aakash Jain  <aakash_jain@apple.com>
3321
3322         [ews-build] Make PrintConfiguration platform aware
3323         https://bugs.webkit.org/show_bug.cgi?id=196657
3324
3325         Reviewed by Lucas Forschler.
3326
3327         * BuildSlaveSupport/ews-build/steps.py:
3328         (PrintConfiguration): Specified platform-specific command lists.
3329         (PrintConfiguration.run): Override run method and specify platform specific commands.
3330         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
3331
3332 2019-07-01  Justin Michaud  <justin_michaud@apple.com>
3333
3334         [Wasm-References] Disable references by default
3335         https://bugs.webkit.org/show_bug.cgi?id=199390
3336
3337         Reviewed by Saam Barati.
3338
3339         * Scripts/run-jsc-stress-tests:
3340
3341 2019-07-01  Joonghun Park  <pjh0718@gmail.com>
3342
3343         Unreviewed. Revert r246965 to fix build break
3344         since r247019 reverted its related changes.
3345
3346         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3347         (WTR::AccessibilityUIElement::popupValue const): Deleted.
3348
3349 2019-07-01  Alex Christensen  <achristensen@webkit.org>
3350
3351         Add new decidePolicyForNavigationAction SPI with preferences and userInfo
3352         https://bugs.webkit.org/show_bug.cgi?id=199371
3353         <rdar://problem/52352905>
3354
3355         Reviewed by Tim Horton.
3356
3357         * TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
3358         (-[NavigationActionSPIDelegate webView:didFinishNavigation:]):
3359         (-[NavigationActionSPIDelegate _webView:decidePolicyForNavigationAction:preferences:userInfo:decisionHandler:]):
3360         (-[NavigationActionSPIDelegate spiCalled]):
3361         (TEST):
3362
3363 2019-07-01  Alex Christensen  <achristensen@webkit.org>
3364
3365         Deprecate _webView:showCustomSheetForElement: after transition to UIContextMenuInteraction
3366         https://bugs.webkit.org/show_bug.cgi?id=199296
3367         <rdar://problem/51041960>
3368
3369         Reviewed by Darin Adler.
3370
3371         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
3372         (-[DragAndDropSimulator _webView:showCustomSheetForElement:]):
3373
3374 2019-07-01  Truitt Savell  <tsavell@apple.com>
3375
3376         Unreviewed, rolling out r246958.
3377
3378         Broke inspector/dom/getAccessibilityPropertiesForNode.html
3379
3380         Reverted changeset:
3381
3382         "Enhance support of aria-haspopup per ARIA 1.1 specification."
3383         https://bugs.webkit.org/show_bug.cgi?id=199216
3384         https://trac.webkit.org/changeset/246958
3385
3386 2019-07-01  Philippe Normand  <pnormand@igalia.com>
3387
3388         Unreviewed, GTK a11y tests fix after r246958
3389
3390         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3391         (WTR::AccessibilityUIElement::popupValue const):
3392
3393 2019-06-30  Andres Gonzalez  <andresg_22@apple.com>
3394
3395         Enhance support of aria-haspopup per ARIA 1.1 specification.
3396         https://bugs.webkit.org/show_bug.cgi?id=199216
3397         <rdar://problem/46221342>
3398
3399         Reviewed by Chris Fleizach.
3400
3401         * DumpRenderTree/AccessibilityUIElement.cpp:
3402         (getPopupValueCallback):
3403         (AccessibilityUIElement::getJSClass):
3404         * DumpRenderTree/AccessibilityUIElement.h:
3405         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3406         (AccessibilityUIElement::popupValue const):
3407         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3408         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3409         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3410         (WTR::AccessibilityUIElement::popupValue const):
3411         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3412         (WTR::AccessibilityUIElement::popupValue const):
3413
3414 2019-06-28  Robin Morisset  <rmorisset@apple.com>
3415
3416         Adding myself as a reviewer to contributors.json.
3417
3418         Unreviewed.
3419
3420         * Scripts/webkitpy/common/config/contributors.json:
3421
3422 2019-06-28  Jer Noble  <jer.noble@apple.com>
3423
3424         Add new -[WKWebView _closeAllMediaPresentations] SPI
3425         https://bugs.webkit.org/show_bug.cgi?id=199294
3426         <rdar://problem/51965958>
3427
3428         Reviewed by Alex Christensen.
3429
3430         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3431         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewCloseAllMediaPresentations.mm: Added.
3432         (TEST):
3433
3434 2019-06-28  Sihui Liu  <sihui_liu@apple.com>
3435
3436         Add a regression test for change r246901
3437         https://bugs.webkit.org/show_bug.cgi?id=199290
3438
3439         Reviewed by Geoffrey Garen.
3440
3441         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3442         * TestWebKitAPI/Tests/WebKitCocoa/LocalStoragePersistence.mm:
3443         (-[LocalStorageNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
3444         (TEST):
3445         * TestWebKitAPI/Tests/WebKitCocoa/localstorage-open-window-private.html: Added.
3446
3447 2019-06-28  Konstantin Tokarev  <annulen@yandex.ru>
3448
3449         Remove traces of ENABLE_ICONDATABASE remaining after its removal in 219733
3450         https://bugs.webkit.org/show_bug.cgi?id=199317
3451
3452         Reviewed by Michael Catanzaro.
3453
3454         While IconDatabase and all code using it was removed,
3455         ENABLE_ICONDATABASE still exists as build option and C++ macro.
3456
3457         * Scripts/webkitperl/FeatureList.pm:
3458         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3459         * gtk/manifest.txt.in: Remove reference to unused urlIcon.png file.
3460         * wpe/manifest.txt.in: Remove reference to unused urlIcon.png file.
3461
3462 2019-06-28  Wenson Hsieh  <wenson_hsieh@apple.com>
3463
3464         -[WKContentView _selectionClipRects] returns a bogus value in -reloadInputViews when focusing an element
3465         https://bugs.webkit.org/show_bug.cgi?id=199310
3466         <rdar://problem/52292137>
3467
3468         Reviewed by Megan Gardner.
3469
3470         Add a new API test to verify that _selectionClipRects returns the correct value when invoked under the scope of
3471         _elementDidFocus.
3472
3473         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
3474         (TestWebKitAPI::TEST):
3475         * TestWebKitAPI/Tests/ios/TestInputDelegate.h:
3476         * TestWebKitAPI/Tests/ios/TestInputDelegate.mm:
3477         (-[TestInputDelegate setDidStartInputSessionHandler:]):
3478         (-[TestInputDelegate didStartInputSessionHandler]):
3479
3480         Add plumbing for a handler block in TestInputDelegate.
3481
3482         (-[TestInputDelegate setWillStartInputSessionHandler:]):
3483
3484         Drive-by style fixes to add a space between id and < for Objective-C protocols.
3485
3486         (-[TestInputDelegate willStartInputSessionHandler]):
3487         (-[TestInputDelegate _webView:willStartInputSession:]):
3488         (-[TestInputDelegate _webView:didStartInputSession:]):
3489         * TestWebKitAPI/cocoa/TestWKWebView.h:
3490         * TestWebKitAPI/ios/UIKitSPI.h:
3491
3492         Add a declaration for _selectionClipRects.
3493
3494 2019-06-27  Zalan Bujtas  <zalan@apple.com>
3495
3496         REGRESSION(r244633): e-mail with "height: 100%" causes unstable layout.
3497         https://bugs.webkit.org/show_bug.cgi?id=199303
3498         <rdar://problem/51340927>
3499
3500         Reviewed by Tim Horton.
3501
3502         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
3503         (TEST):
3504
3505 2019-06-27  Beth Dakin  <bdakin@apple.com>
3506
3507         Upstream use of MACCATALYST
3508         https://bugs.webkit.org/show_bug.cgi?id=199245
3509         rdar://problem/51687723
3510
3511         Reviewed by Tim Horton.
3512
3513         * ContentExtensionTester/Configurations/SDKVariant.xcconfig:
3514         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig:
3515         * ImageDiff/cg/Configurations/SDKVariant.xcconfig:
3516         * MiniBrowser/Configurations/SDKVariant.xcconfig:
3517         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig:
3518         * Scripts/webkitpy/generate_xcfilelists_lib/generators.py:
3519         (JavaScriptCoreGenerator):
3520         (WebCoreGenerator):
3521         (WebKitGenerator):
3522         * TestWebKitAPI/Configurations/Base.xcconfig:
3523         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3524         * TestWebKitAPI/Configurations/SDKVariant.xcconfig:
3525         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3526         * WebEditingTester/Configurations/SDKVariant.xcconfig:
3527         * WebKitLauncher/Configurations/SDKVariant.xcconfig:
3528         * WebKitTestRunner/Configurations/SDKVariant.xcconfig:
3529         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig:
3530
3531 2019-06-27  Saam Barati  <sbarati@apple.com>
3532
3533         Make WEBGPU enabled only on Mojave and later.
3534
3535         Rubber-stamped by Myles C. Maxfield.
3536
3537         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3538
3539 2019-06-27  Aakash Jain  <aakash_jain@apple.com>
3540
3541         [ews-build] Do not print worker environment variables in each build step
3542         https://bugs.webkit.org/show_bug.cgi?id=197319
3543
3544         Reviewed by Lucas Forschler.
3545
3546         * BuildSlaveSupport/ews-build/steps.py:
3547         (CheckOutSource.__init__): Disabled logging of environment variables.
3548         (ApplyPatch.__init__): Ditto.
3549         (KillOldProcesses.__init__): Ditto.
3550         (ArchiveBuiltProduct.__init__): Ditto.
3551         (DownloadBuiltProduct.__init__): Ditto.
3552         (ExtractBuiltProduct.__init__): Ditto.
3553         (RunAPITests.__init__): Ditto.
3554         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests accordingly.
3555
3556 2019-06-26  Jiewen Tan  <jiewen_tan@apple.com>
3557
3558         SubFrameSOAuthorizationSession should preserve the referrer header when fall back to web path
3559         https://bugs.webkit.org/show_bug.cgi?id=199232
3560         <rdar://problem/51718328>
3561
3562         Reviewed by Youenn Fablet.
3563
3564         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
3565         (TestWebKitAPI::TEST):
3566         Add a test that utilizes TCPServer as local files always omit referrer.
3567
3568 2019-06-26  Aakash Jain  <aakash_jain@apple.com>
3569
3570         [ews-build] Add configuration and architecture for WPE and GTK builders
3571         https://bugs.webkit.org/show_bug.cgi?id=199249
3572
3573         Reviewed by Jonathan Bedard.
3574
3575         * BuildSlaveSupport/ews-build/config.json:
3576
3577 2019-06-26  Aakash Jain  <aakash_jain@apple.com>
3578
3579         [ews-build] Add check for duplicate workers in config.json
3580         https://bugs.webkit.org/show_bug.cgi?id=199240
3581
3582         Reviewed by Jonathan Bedard.
3583
3584         * BuildSlaveSupport/ews-build/loadConfig.py:
3585         (checkWorkersAndBuildersForConsistency._find_worker_with_name): Check for duplicate worker entry.
3586         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
3587         (TestcheckWorkersAndBuildersForConsistency.test_duplicate_worker): Added unit-test.
3588
3589 2019-06-26  Ross Kirsling  <ross.kirsling@sony.com>
3590
3591         [Win] MiniBrowser should make better font choices
3592         https://bugs.webkit.org/show_bug.cgi?id=199244
3593
3594         Reviewed by Brent Fulgham.
3595
3596         * MiniBrowser/win/MainWindow.cpp:
3597         (MainWindow::updateDeviceScaleFactor):
3598         * MiniBrowser/win/MiniBrowserLib.rc:
3599
3600 2019-06-26  Alex Christensen  <achristensen@webkit.org>
3601
3602         testRunner.setAlwaysAcceptCookies should wait for cookie accept policy to be set
3603         https://bugs.webkit.org/show_bug.cgi?id=199230
3604         <rdar://51757107>
3605
3606         Reviewed by Andy Estes.
3607
3608         * TestWebKitAPI/Tests/WebKit/CookieManager.cpp:
3609         (TestWebKitAPI::didGetTestHTTPCookieAcceptPolicy):
3610         (TestWebKitAPI::didGetUserHTTPCookieAcceptPolicy):
3611         * WebKitTestRunner/TestController.cpp:
3612         (WTR::TestController::generatePageConfiguration):
3613         (WTR::TestController::createWebViewWithOptions):
3614         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundleWithListener):
3615         (WTR::TestController::didReceiveSynchronousPageMessageFromInjectedBundleWithListener):
3616         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
3617         (WTR::TestController::didReceiveSynchronousPageMessageFromInjectedBundle): Deleted.
3618         * WebKitTestRunner/TestController.h:
3619         * WebKitTestRunner/TestInvocation.cpp:
3620         (WTR::TestInvocation::invoke):
3621         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3622
3623 2019-06-26  Ross Kirsling  <ross.kirsling@sony.com>
3624
3625         [Win][MiniBrowser] Remove obsolete code after r246814.
3626         https://bugs.webkit.org/show_bug.cgi?id=199233
3627
3628         Reviewed by Fujii Hironori.
3629
3630         * MiniBrowser/win/MiniBrowserWebHost.cpp:
3631         (MiniBrowserWebHost::didFinishLoadForFrame):
3632         (SimpleEventListener::SimpleEventListener): Deleted.
3633         (SimpleEventListener::handleEvent): Deleted.
3634
3635 2019-06-25  Jiewen Tan  <jiewen_tan@apple.com>
3636
3637         Implement a new SPI to inform clients about AppSSO
3638         https://bugs.webkit.org/show_bug.cgi?id=199085
3639         <rdar://problem/50028246>
3640
3641         Reviewed by Geoffrey Garen.
3642
3643         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
3644         (-[TestSOAuthorizationBasicDelegate webView:didFinishNavigation:]):
3645         (-[TestSOAuthorizationNavigationDelegate init]):
3646         (-[TestSOAuthorizationNavigationDelegate _webView:decidePolicyForSOAuthorizationLoadWithCurrentPolicy:forExtension:completionHandler:]):
3647         (TestWebKitAPI::TEST):
3648
3649 2019-06-25  Aakash Jain  <aakash_jain@apple.com>
3650
3651         [ews-build] Retry Layout test in case of failures
3652         https://bugs.webkit.org/show_bug.cgi?id=199194
3653
3654         Reviewed by Jonathan Bedard.
3655