62bd97bd1f1d2f8595020239b8292e0d0f0d1854
[WebKit-https.git] / Tools / ChangeLog
1 2011-01-28  Pratik Solanki  <psolanki@apple.com>
2
3         Reviewed by David Kilzer.
4
5         Space not necessary for undefined feature
6         https://bugs.webkit.org/show_bug.cgi?id=53317
7
8         * Scripts/build-webkit:
9
10 2011-01-28  Chang Shu  <chang.shu@nokia.com>
11
12         Reviewed by Andreas Kling.
13
14         Reset NetworkAccessManager to clean up credentials from previous tests.
15         This change causes no performance overhead either.
16         https://bugs.webkit.org/show_bug.cgi?id=36688
17
18         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
19         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
20         (WebCore::DumpRenderTree::open):
21         * DumpRenderTree/qt/DumpRenderTreeQt.h:
22
23 2011-01-28  Zoltan Horvath  <zoltan@webkit.org>
24
25         Reviewed by Andreas Kling.
26
27         [Qt] Add Zoom Text Only action to MiniBrowser
28         https://bugs.webkit.org/show_bug.cgi?id=53297
29
30         Add Zoom Text Only action to MiniBrowser's view menu, change zoom levels to avoid unnecessary divides.
31
32         * MiniBrowser/qt/BrowserWindow.cpp:
33         (BrowserWindow::BrowserWindow):
34         (BrowserWindow::zoomIn):
35         (BrowserWindow::zoomOut):
36         (BrowserWindow::resetZoom):
37         (BrowserWindow::toggleZoomTextOnly):
38         (BrowserWindow::applyZoom):
39         * MiniBrowser/qt/BrowserWindow.h:
40
41 2011-01-28  Adam Barth  <abarth@webkit.org>
42
43         Reviewed by Eric Seidel.
44
45         Add webkit-patch roll-chromium-deps
46         https://bugs.webkit.org/show_bug.cgi?id=53288
47
48         This command updates the Source/WebKit/chromium/DEPS file with the
49         last-known good revision of Chromium (or a revision specified on the
50         command line).  I'd eventually like to turn this into a SheriffBot
51         command, but this is the first step.
52
53         This patch somewhat sprawled because I needed to move a bunch of code
54         out of ChangeLog that should never have been there in the first place.
55         Also, I had to fix a bug in MockUser in order to test the new command.
56
57         * Scripts/webkitpy/common/checkout/api.py:
58         * Scripts/webkitpy/common/checkout/changelog.py:
59         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
60         * Scripts/webkitpy/common/checkout/deps.py: Added.
61         * Scripts/webkitpy/common/config/urls.py:
62         * Scripts/webkitpy/tool/commands/__init__.py:
63         * Scripts/webkitpy/tool/commands/download_unittest.py:
64         * Scripts/webkitpy/tool/commands/roll.py: Added.
65         * Scripts/webkitpy/tool/commands/roll_unittest.py: Added.
66         * Scripts/webkitpy/tool/commands/upload_unittest.py:
67         * Scripts/webkitpy/tool/mocktool.py:
68         * Scripts/webkitpy/tool/steps/__init__.py:
69         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py: Added.
70         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
71         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py: Added.
72         * Scripts/webkitpy/tool/steps/suggestreviewers_unittest.py:
73         * Scripts/webkitpy/tool/steps/updatechromiumdeps.py: Added.
74         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
75
76 2011-01-27  Greg Coletta  <greg.coletta@nokia.com>
77
78         Reviewed by Laszlo Gombos.
79
80         Get rid of prefix header dependency for WebKit2 build system
81         https://bugs.webkit.org/show_bug.cgi?id=50174
82
83         Change the style checker so that it enforces config.h include for
84         WebKit2.
85
86         * Scripts/webkitpy/style/checker.py:
87
88 2011-01-27  Maciej Stachowiak  <mjs@apple.com>
89
90         Reviewed by Darin Adler.
91
92         execCommand("Paste") doesn't work in WebKitTestRunner
93         https://bugs.webkit.org/show_bug.cgi?id=52785
94
95         Enable both of the settings needed to allow paste.
96         
97         * WebKitTestRunner/TestController.cpp:
98         (WTR::TestController::resetStateToConsistentValues):
99
100 2011-01-27  Jacob Dinu  <dinu.jacob@nokia.com>
101
102         Reviewed by Andreas Kling.
103
104         [Qt] QtTestBrowser: User input lost when toggling use of QGraphicsView
105         https://bugs.webkit.org/show_bug.cgi?id=48440
106
107         Preserve user input when toggling use of QGraphicsView
108
109         * QtTestBrowser/launcherwindow.cpp:
110         (LauncherWindow::initializeView):
111         (LauncherWindow::loadFinished):
112         * QtTestBrowser/launcherwindow.h:
113         * QtTestBrowser/mainwindow.cpp:
114         (MainWindow::addressUrl):
115         * QtTestBrowser/mainwindow.h:
116
117 2011-01-27  Dirk Pranke  <dpranke@chromium.org>
118
119         Reviewed by Mihai Parparita.
120
121         new-run-webkit-tests: turn off pixel tests correctly by default
122         for webkit-based ports. r70013 (bug 47510) used
123         port.set_option_default() to attempt to set default values, but
124         that didn't work correctly. I have removed set_option_default
125         for now since it was only being used in two places and in three
126         useless unit tests. There is a separate bug open to fix the
127         option parsing (48095), so this workaround is fine for now.
128
129         https://bugs.webkit.org/show_bug.cgi?id=53217
130
131         * Scripts/webkitpy/layout_tests/port/webkit.py:
132         * Scripts/webkitpy/layout_tests/port/base.py:
133         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
134
135 2011-01-27  Balazs Kelemen  <kbalazs@webkit.org>
136
137         Rubber-stamped by Ariya Hidayat.
138
139         Trivial crash fix in WTR.
140
141         * WebKitTestRunner/TestController.cpp:
142         (WTR::TestController::initialize): Increase the size
143         of the vector by one to be able to store the null character.
144
145 2011-01-27  Balazs Kelemen  <kbalazs@webkit.org>
146
147         Reviewed by Csaba Osztrogonác.
148
149         [Qt][WK2] WTR should be initialized in the same way as DRT
150         https://bugs.webkit.org/show_bug.cgi?id=53240
151
152         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
153         (WTR::activateFonts): Added missing initialization steps.
154
155 2011-01-27  Joone Hur <joone.hur@collabora.co.uk>
156
157         Unreviewed. 
158
159         Adding myself to committers.py.
160
161         * Scripts/webkitpy/common/config/committers.py:
162
163 2011-01-27  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
164
165         Reviewed by Csaba Osztrogonác.
166
167         [Qt] [Symbian] Move project files into Source
168         https://bugs.webkit.org/show_bug.cgi?id=52891
169
170         Fix the Symbian build after the project files
171         are moved to Source directory. On Symbian qmake
172         needs to run in the same directory where the main
173         pro files (WebKit.pro, Tools.pro) are located.
174
175         * Scripts/webkitdirs.pm: Change to the directory where the pro file
176         is located before running qmake for Symbian. Qmake on Symbian
177         does not properly honor the "-o" option, work it around by setting
178         the name of the Makefile to bld.inf.
179
180 2011-01-27  Zoltan Horvath  <zoltan@webkit.org>
181
182         Reviewed by Andreas Kling.
183
184         [Qt] Add simple zooming features to MiniBrowser
185         https://bugs.webkit.org/show_bug.cgi?id=53231
186
187         Add View menu and Zoom In, Zoom Out, Zoom Reset actions to MiniBrowser.
188
189         * MiniBrowser/qt/BrowserWindow.cpp:
190         (BrowserWindow::BrowserWindow):
191         (BrowserWindow::zoomIn):
192         (BrowserWindow::zoomOut):
193         (BrowserWindow::resetZoom):
194         (BrowserWindow::updateUserAgentList):
195         (BrowserWindow::applyZoom):
196         * MiniBrowser/qt/BrowserWindow.h:
197
198 2011-01-26  Maciej Stachowiak  <mjs@apple.com>
199
200         Reviewed by Dan Bernstein.
201
202         WebKitTestRunner needs to support layoutTestController.evaluateInWebInspector
203         https://bugs.webkit.org/show_bug.cgi?id=42319
204         
205         Add evaluateInWebInspector and other APIs needed for inspector tests to run.
206
207         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
208         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
209         (WTR::LayoutTestController::showWebInspector):
210         (WTR::LayoutTestController::closeWebInspector):
211         (WTR::LayoutTestController::evaluateInWebInspector):
212         (WTR::LayoutTestController::setTimelineProfilingEnabled):
213         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
214         * WebKitTestRunner/TestInvocation.cpp:
215         (WTR::shouldOpenWebInspector):
216         (WTR::TestInvocation::invoke):
217         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
218
219 2011-01-26  Martin Robinson  <mrobinson@igalia.com>
220
221         Reviewed by Xan Lopez.
222
223         [GTK] Pixel dumps do not include scrollbars in output images
224         https://bugs.webkit.org/show_bug.cgi?id=53216
225
226         Show scrollbars in pixel dumps. This will fix pixel dumps for tests
227         that have scrollbars.
228
229         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
230         (createBitmapContextFromWebView): Take the snapshot of the containing GtkScrolledWindow
231         instead of the web view itself.
232
233 2011-01-26  Dirk Pranke  <dpranke@chromium.org>
234
235         Reviewed by Mihai Parparita.
236
237         Fix regression introduced in r76322 ... new-run-webkit-tests
238         was attempting to save the image diff output as a UTF-8-encoded
239         file.
240
241         https://bugs.webkit.org/show_bug.cgi?id=53210
242
243         * Scripts/webkitpy/layout_tests/port/webkit.py:
244
245 2011-01-26  Sheriff Bot  <webkit.review.bot@gmail.com>
246
247         Unreviewed, rolling out r76709.
248         http://trac.webkit.org/changeset/76709
249         https://bugs.webkit.org/show_bug.cgi?id=53194
250
251         "broke python tests on non-snowleopard platforms" (Requested
252         by dpranke on #webkit).
253
254         * Scripts/webkitpy/layout_tests/port/factory.py:
255         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Removed.
256         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Removed.
257
258 2011-01-26  Dirk Pranke  <dpranke@chromium.org>
259
260         Reviewed by Tony Chang.
261
262         new-run-webkit-tests: add a "mock DRT" port implementation
263         and a separate class that emulates what we expect the
264         DumpRenderTree behavior to be.
265
266         This will eventually replace port/dryrun.py and allow us to get
267         better test coverage of the new-run-webkit-tests code as well as
268         a reference for what new-run-webkit-tests expects from DRT.
269
270         This is the first attempt at this, and it is pretty bare-boned. It
271         really only has been tested on the 'mac' port (and a little on
272         the 'chromium-mac' port.
273
274         https://bugs.webkit.org/show_bug.cgi?id=53126
275
276         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Added.
277         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Added.
278         * Scripts/webkitpy/layout_tests/port/factory.py:
279
280 2011-01-26  Xianzhu Wang  <wangxianzhu@google.com>
281
282         Reviewed by Tony Chang.
283
284         Add '--no-timeout' option to Chromium DRT to ease debugging.
285         https://bugs.webkit.org/show_bug.cgi?id=52873
286
287         * DumpRenderTree/chromium/DumpRenderTree.cpp:
288         (main):
289
290 2011-01-26  Csaba Osztrogonác  <ossy@webkit.org>
291
292         Reviewed by Andreas Kling.
293
294         [Qt] Fix qt_minimal build
295         https://bugs.webkit.org/show_bug.cgi?id=53172
296
297         * QtTestBrowser/locationedit.h:
298
299 2011-01-26  Mansi Mithal  <mansi.mithal@nokia.com>
300
301         Reviewed by Antonio Gomes.
302
303         QtTestBrowser should have a UI Setting to disable plugins
304         https://bugs.webkit.org/show_bug.cgi?id=52408
305         
306         Added a new action item named "Disable Plugins"
307         under the "Settings" menu. 
308
309         * QtTestBrowser/launcherwindow.cpp:
310         (LauncherWindow::createChrome):
311         (LauncherWindow::togglePlugins):
312         * QtTestBrowser/launcherwindow.h:
313
314 2011-01-25  Patrick Gansterer  <paroga@webkit.org>
315
316         Reviewed by Adam Barth.
317
318         Move main CMakeLists.txt into Source directory
319         https://bugs.webkit.org/show_bug.cgi?id=52888
320
321         * Scripts/webkitdirs.pm:
322
323 2011-01-25  Patrick Gansterer  <paroga@webkit.org>
324
325         Reviewed by Eric Seidel.
326
327         Improve label text in submit-to-ews
328         https://bugs.webkit.org/show_bug.cgi?id=53130
329
330         * QueueStatusServer/templates/submittoews.html:
331
332 2011-01-25  Mansi Mithal  <mansi.mithal@nokia.com>
333
334         Reviewed by Antonio Gomes.
335
336         QtTestBrowser should have a UI Settings to prevent loading images
337         https://bugs.webkit.org/show_bug.cgi?id=52409
338         
339         Added a new action item named "DisableAutoLoadImages"
340         under the "Settings" menu 
341
342         * QtTestBrowser/launcherwindow.cpp:
343         (LauncherWindow::createChrome):
344         (LauncherWindow::toggleAutoLoadImages):
345         * QtTestBrowser/launcherwindow.h:
346
347 2011-01-25  Dirk Pranke  <dpranke@chromium.org>
348
349         Reviewed by Tony Chang.
350
351         Minor bug fixes and cleanup for filesystem wrappers, port/* test
352         classes, test_expectations.py. This change adds "test-win" and
353         "test-mac" variants to the test port so that we can better test
354         rebaselining, and adds a MockUser() object for reuse in testing.
355
356         https://bugs.webkit.org/show_bug.cgi?id=53036
357
358         * Scripts/webkitpy/common/system/filesystem.py:
359         * Scripts/webkitpy/common/system/filesystem_mock.py:
360         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
361         * Scripts/webkitpy/layout_tests/port/factory.py:
362         * Scripts/webkitpy/layout_tests/port/base.py:
363         * Scripts/webkitpy/layout_tests/port/test.py:
364         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
365         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
366         * Scripts/webkitpy/tool/mocktool.py:
367
368 2011-01-25  Tony Chang  <tony@chromium.org>
369
370         Reviewed by Dimitri Glazkov.
371
372         [chromium] remove unused layoutTestController callback
373         https://bugs.webkit.org/show_bug.cgi?id=53103
374
375         This method is used by a test_shell_test, but not needed by DRT.
376
377         * DumpRenderTree/chromium/LayoutTestController.cpp:
378         (LayoutTestController::LayoutTestController):
379         * DumpRenderTree/chromium/LayoutTestController.h:
380
381 2011-01-25  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
382
383         Reviewed by Andreas Kling.
384
385         [GTK] Remove 64 bits release bot from the buildbot master
386         https://bugs.webkit.org/show_bug.cgi?id=52899
387
388         Removes the 64 bits release slave from the buildbot configuration,
389         so that we can use it as an EWS.
390
391         * BuildSlaveSupport/build.webkit.org-config/config.json:
392
393 2011-01-24  Maciej Stachowiak  <mjs@apple.com>
394
395         Reviewed by Dan Bernstein.
396
397         Implement database quota callback to fix storage tests on WebKit2 bot
398         https://bugs.webkit.org/show_bug.cgi?id=53064
399
400         * WebKitTestRunner/TestController.cpp:
401         (WTR::exceededDatabaseQuota):
402         (WTR::TestController::createOtherPage):
403         (WTR::TestController::initialize):
404
405 2011-01-24  Maciej Stachowiak  <mjs@apple.com>
406
407         Reviewed by Anders Carlsson.
408
409         Use designated temp directory for the database for WebKit2
410         https://bugs.webkit.org/show_bug.cgi?id=53052
411         
412         Adopt the new WK2 API for this.
413
414         * WebKitTestRunner/TestController.cpp:
415         (WTR::TestController::libraryPathForTesting):
416         (WTR::TestController::initialize):
417         * WebKitTestRunner/TestController.h:
418         * WebKitTestRunner/mac/TestControllerMac.mm:
419         (WTR::TestController::platformLibraryPathForTesting):
420         * WebKitTestRunner/qt/TestControllerQt.cpp:
421         (WTR::TestController::platformLibraryPathForTesting):
422         * WebKitTestRunner/win/TestControllerWin.cpp:
423         (WTR::TestController::platformLibraryPathForTesting):
424
425 2011-01-24  Lucas Forschler  <lforschler@apple.com>
426
427         Reviewed by Stephanie Lewis.
428
429         Add a new Leopard test bot.
430
431         * BuildSlaveSupport/build.webkit.org-config/config.json:
432
433 2011-01-24  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
434
435         Reviewed by Adam Barth.
436
437         Add EFL Builder to core waterfall
438         https://bugs.webkit.org/show_bug.cgi?id=52704
439
440         Add EFL Builder to the core waterfall again.
441
442         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
443         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
444
445 2011-01-24  Xianzhu Wang  <wangxianzhu@google.com>
446
447         Reviewed by Tony Chang.
448
449         new-run-webkit-tests fails to start HTTP server if there are proxy settings
450         https://bugs.webkit.org/show_bug.cgi?id=52872
451
452         Force disabling proxy to resolve the problem.
453
454         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
455         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
456
457 2011-01-24  Andreas Kling  <kling@webkit.org>
458
459         Reviewed by Darin Adler.
460
461         check-webkit-style: Update exemptions following Source/ move.
462         https://bugs.webkit.org/show_bug.cgi?id=53017
463
464         * Scripts/webkitpy/style/checker.py:
465         * Scripts/webkitpy/style/checker_unittest.py:
466
467 2011-01-24  Andras Becsi  <abecsi@webkit.org>
468
469         Rubber-stamped by Csaba Osztrogonác.
470
471         [Qt] Move project files into Source
472         https://bugs.webkit.org/show_bug.cgi?id=52891
473
474         * DumpRenderTree/qt/ImageDiff.pro: Add missing "Source" to WebKit.pri path
475
476 2011-01-24  Mikhail Naganov  <mnaganov@chromium.org>
477
478         Reviewed by Yury Semikhatsky.
479
480         Web Inspector: Find duplicate strings in localizedStrings.js
481
482         https://bugs.webkit.org/show_bug.cgi?id=53005
483
484         * Scripts/check-inspector-strings:
485
486 2011-01-24  Zoltan Horvath  <zoltan@webkit.org>
487
488         Reviewed by Andreas Kling.
489
490         [Qt] Regroup MiniBrowser's menubar and add open file action
491         https://bugs.webkit.org/show_bug.cgi?id=53000
492
493         Add File and Develop menu to MiniBrowser's menubar and add open file action to File menu.
494
495         * MiniBrowser/qt/BrowserWindow.cpp:
496         (BrowserWindow::BrowserWindow):
497         (BrowserWindow::openFile):
498         (BrowserWindow::~BrowserWindow):
499         * MiniBrowser/qt/BrowserWindow.h:
500
501 2011-01-24  Csaba Osztrogonác  <ossy@webkit.org>
502
503         Unreviewed fix after r76496
504
505         [Qt] Move project files into Source
506         https://bugs.webkit.org/show_bug.cgi?id=52891
507
508         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Remove unnecessary "Source" from the path.
509         * BuildSlaveSupport/built-product-archive: Remove unnecessary "Source" from the path.
510         * Scripts/webkitdirs.pm: Add the accidentally removed slash to the path.
511
512 2011-01-24  Andras Becsi  <abecsi@webkit.org>
513
514         Reviewed by Csaba Osztrogonác.
515
516         [Qt] Move project files into Source
517         https://bugs.webkit.org/show_bug.cgi?id=52891
518
519         * DerivedSources.pro: Renamed from DerivedSources.pro.
520         * DumpRenderTree/qt/DumpRenderTree.pro:
521         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
522         * MiniBrowser/DerivedSources.pro:
523         * MiniBrowser/qt/MiniBrowser.pro:
524         * QtTestBrowser/QtTestBrowser.pro:
525         * Scripts/webkitdirs.pm:
526         * Tools.pro: Added.
527         * WebKitTestRunner/DerivedSources.pro:
528         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
529         * WebKitTestRunner/qt/WebKitTestRunner.pro:
530
531 2011-01-22  Geoffrey Garen  <ggaren@apple.com>
532
533         Reviewed by Dan Bernstein.
534
535         Beefed up --threaded mode to catch even more kinds of errors.
536         https://bugs.webkit.org/show_bug.cgi?id=52971
537
538         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Use a shared
539         context group to force JSC to mark multiple threads. (This used to be
540         the default, but it changed in SnowLeopard.)
541         (runJavaScriptThread): Do more locking and unlocking, and more allocation,
542         to give threading mistakes more chances to show themselves.
543         (startJavaScriptThreads):
544         (stopJavaScriptThreads):
545
546 2011-01-22  Robert Hogan  <robert@webkit.org>
547
548         Reviewed by Andreas Kling.
549
550         [Qt] Support layoutTestController.addURLToRedirect()
551         https://bugs.webkit.org/show_bug.cgi?id=52956
552
553         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
554         (LayoutTestController::addURLToRedirect):
555         * DumpRenderTree/qt/LayoutTestControllerQt.h:
556
557 2011-01-22  Robert Hogan  <robert@webkit.org>
558
559         Reviewed by Kenneth Rohde Christiansen.
560
561         [Qt] REGRESSION (r72360): http/tests/security/aboutBlank/xss-DENIED-* tests fail
562         https://bugs.webkit.org/show_bug.cgi?id=49802
563
564         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
565         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
566         (WebCore::DumpRenderTree::open):
567
568 2011-01-21  Adam Barth  <abarth@webkit.org>
569
570         Reviewed by Maciej Stachowiak.
571
572         Disable mac_unittest.py that fails on some of the Mac bots
573         https://bugs.webkit.org/show_bug.cgi?id=52947
574
575         As noted in the comment, this test does not appear to be correct
576         because the function this test is testing returns different results
577         depending on which flavor of Mac the test is run on.  This patch
578         disable the test.  Hopefully we can re-enable the test once we've
579         probably insulated the test from its environment.
580
581         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
582
583 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
584
585         Reviewed by Mihai Parparita.
586
587         Fix bug introduced in r76322 that caused NRWT to not actually
588         read the Skipped files properly.
589
590         https://bugs.webkit.org/show_bug.cgi?id=52771
591
592         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
593         * Scripts/webkitpy/layout_tests/port/webkit.py:
594         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
595
596 2011-01-21  Sam Weinig  <sam@webkit.org>
597
598         Reviewed by Geoffrey Sean Garen and Mark Rowe.
599
600         WebKitTestRunner needs the HOME environment variable to be set.
601         <rdar://problem/8896573>
602
603         * Scripts/old-run-webkit-tests: Set the HOME environment variable if
604         it exists.
605
606 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
607
608         Reviewed by Eric Seidel.
609
610         Suppress a few remaining integration tests so that none of the
611         layout_test unit tests ever read from the filesystem or launch
612         subprocesses that aren't part of the unit tests.
613
614         Also fix a minor bug in the printing unit tests that was
615         incorrectly relying on sys.argv.
616
617         https://bugs.webkit.org/show_bug.cgi?id=52863
618
619         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
620         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
621         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
622
623 2011-01-21  Darin Adler  <darin@apple.com>
624
625        Fix Mac build.
626
627         * MiniBrowser/mac/BrowserWindowController.m:
628         (-[BrowserWindowController awakeFromNib]): Pass 0 for runModal function.
629
630 2011-01-20  Darin Adler  <darin@apple.com>
631
632         Reviewed by Dan Bernstein.
633
634         WebKit2: Implement showModalDialog
635         https://bugs.webkit.org/show_bug.cgi?id=52855
636
637         This fixes WebKitTestRunner to compile, but more work is probably
638         needed to get it to pass the tests.
639
640         * WebKitTestRunner/TestController.cpp:
641         (WTR::TestController::runModal): Added. Calls through to the
642         platform-specific version of runModal.
643         (WTR::TestController::createOtherPage): Changed to be a private
644         static member function so it can refer to runModal, which is
645         a private static member function.
646         (WTR::TestController::initialize): Pass 0 for the runModal
647         function since we don't need to run the main window modal.
648         I suspect this is wrong and will need to change.
649         * WebKitTestRunner/TestController.h: Added declarations for
650         the functions added above.
651         * WebKitTestRunner/mac/TestControllerMac.mm:
652         (WTR::TestController::runModal): Added. Untested implementation.
653         * WebKitTestRunner/qt/TestControllerQt.cpp:
654         (WTR::TestController::runModal): Added.
655         * WebKitTestRunner/win/TestControllerWin.cpp:
656         (WTR::TestController::runModal): Added.
657
658 2011-01-21  Eric Seidel  <eric@webkit.org>
659
660         Reviewed by Adam Barth.
661
662         Split Host object off from WebKitPatch for easier re-use
663         https://bugs.webkit.org/show_bug.cgi?id=52284
664
665         new-run-webkit-tests and other tools are eventually going to want one of these.
666         Basically you need to inherit from this class if you want to pretend to be a
667         self.tool object for Steps/Commands.
668
669         * Scripts/webkitpy/common/host.py: Added.
670         * Scripts/webkitpy/tool/main.py:
671
672 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
673
674         Reviewed by Adam Barth.
675
676         Disable the tests that start and stop the http server and web
677         server, so that we don't have to worry about port collisions on
678         the bots.
679
680         https://bugs.webkit.org/show_bug.cgi?id=52861
681
682         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
683
684 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
685
686         Reviewed by Eric Seidel.
687
688         nrwt: rewrite google_chrome_unittest to use mock filesystem.
689         
690         https://bugs.webkit.org/show_bug.cgi?id=52772
691         
692         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
693
694 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
695
696         Reviewed by Eric Siedel.
697
698         nrwt: clean up almost all remaining port references, remove
699         unnecessary import clauses. The only remaining references are
700         in places where a mock filesystem makes no sense or can't be
701         used, and in one routine in port/google_chrome_unittest that
702         I'll rewrite in a separate patch.
703
704         https://bugs.webkit.org/show_bug.cgi?id=52771
705
706         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
707         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
708         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
709         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
710         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
711         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
712         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
713         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
714         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
715         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
716         * Scripts/webkitpy/layout_tests/port/gtk.py:
717         * Scripts/webkitpy/layout_tests/port/mac.py:
718         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
719         * Scripts/webkitpy/layout_tests/port/qt.py:
720         * Scripts/webkitpy/layout_tests/port/webkit.py:
721         * Scripts/webkitpy/layout_tests/port/win.py:
722         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
723
724 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
725
726         Reviewed by Mihai Parparita.
727
728         remove fs refs from run_webkit_tests, rebaseline_chromium_webkit_tests
729
730         https://bugs.webkit.org/show_bug.cgi?id=52762
731
732         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
733         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
734
735 2011-01-20  Tony Chang  <tony@chromium.org>
736
737         Reviewed by Ojan Vafai.
738
739         [chromium] fix the paths used for the rebaseline tool
740         https://bugs.webkit.org/show_bug.cgi?id=52857
741
742         Some of the bots were renamed so the path to grab the results zip
743         file has changed.
744
745         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
746
747 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
748
749         Reviewed by Tony Chang.
750
751         Fix bug introduced in r72688 / bug 52768 that broke the
752         generation of the output filename links in the results.html
753         output. Apparently none of the unit tests actually checked to
754         make sure the generated links were correct :(
755
756         https://bugs.webkit.org/show_bug.cgi?id=52854
757
758         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
759         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
760
761 2011-01-20  Alexey Proskuryakov  <ap@apple.com>
762
763         Reviewed by Darin Adler.
764
765         https://bugs.webkit.org/show_bug.cgi?id=52849
766         Make window.print work with WebKit2
767
768         * MiniBrowser/mac/BrowserWindowController.m:
769         (-[BrowserWindowController awakeFromNib]):
770         * WebKitTestRunner/TestController.cpp:
771         (WTR::createOtherPage):
772         (WTR::TestController::initialize):
773         Added zeroes to WKPageUIClient structures to avoid build failures.
774
775 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
776
777         Reviewed by Eric Seidel.
778
779         nrwt: remove fs refs from printing, test_failures, test_expectations, text_diff
780
781         https://bugs.webkit.org/show_bug.cgi?id=52756
782
783         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
784         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
785         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
786         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
787         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
788         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
789
790 2011-01-20  Mansi Mithal  <mansi.mithal@nokia.com>
791
792         Reviewed by Antonio Gomes.
793
794         QtTestBrowser should have a seperate menu for Settings
795         https://bugs.webkit.org/show_bug.cgi?id=52817
796         
797         Added a new menu item named "Settings"
798         and moved the "Enable interrupting js scripts" and "Enable js pop up windows" under the "Settings" menu 
799
800         * QtTestBrowser/launcherwindow.cpp:
801         (LauncherWindow::createChrome):
802
803 2011-01-20  Sam Weinig  <sam@webkit.org>
804
805         Reviewed by John Sullivan.
806
807         Update update-webkit-localizable-strings with new path to WebKit.
808
809         * Scripts/update-webkit-localizable-strings:
810
811 2011-01-20  James Robinson  <jamesr@chromium.org>
812
813         Reviewed by Darin Fisher.
814
815         Implement mozilla's requestAnimationFrame API
816         https://bugs.webkit.org/show_bug.cgi?id=51218
817
818         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
819
820         * DumpRenderTree/chromium/WebViewHost.cpp:
821         (invokeScheduleComposite):
822         (WebViewHost::scheduleAnimation):
823         (WebViewHost::paintInvalidatedRegion):
824         * DumpRenderTree/chromium/WebViewHost.h:
825
826 2011-01-20  Maciej Stachowiak  <mjs@apple.com>
827
828         Reviewed by Adam Roben.
829
830         WebKitTestRunner needs to support layoutTestController.evaluateScriptInIsolatedWorld
831         https://bugs.webkit.org/show_bug.cgi?id=42327
832
833         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Add support
834         for methods that take their normal arguments but also a JSContextRef.
835         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: IDL definition
836         for evaluateScriptInIsolatedWorld.
837         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
838         (WTR::InjectedBundlePage::didClearWindowForFrame): Set a magic variable only if
839         this call is for an isolated world.
840         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
841         (WTR::worldMap): Helper to create a world map.
842         (WTR::LayoutTestController::worldIDForWorld): Map from an ID to a world.
843         (WTR::LayoutTestController::evaluateScriptInIsolatedWorld): The newly
844         added LayoutTestController API.
845         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
846
847 2011-01-19  Adam Roben  <aroben@apple.com>
848
849         Convert paths in environment variables back to msys-style inside commit-log-editor
850
851         When this script gets run from inside git commit, msys-style paths in the environment will
852         have been turned into Windows-style paths with forward slashes. This screws up functions
853         like File::Spec->rel2abs, which seem to rely on $PWD having an msys-style path. We convert
854         the paths back to msys-style before doing anything else.
855
856         Fixes <http://webkit.org/b/48527> commit-log-editor uses full paths for section headers when
857         using msysgit's Perl and multiple ChangeLogs have been edited
858
859         Reviewed by David Kilzer.
860
861         * Scripts/commit-log-editor: Call fixEnvironment before doing anything else.
862         (fixEnvironment): Added. When run in msys in conjunction with git (i.e., when invoked from
863         inside git commit), convert Windows-style paths in the environment back to msys-style paths.
864
865 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
866
867         [Win] Unreviewed build fix after r76248.
868
869         * DumpRenderTree/ForwardingHeaders/wtf/FastAllocBase.h: Added.
870
871 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
872
873         Reviewed by Csaba Osztrogonác.
874
875         Refactoring of the custom allocation framework
876         https://bugs.webkit.org/show_bug.cgi?id=49897
877
878         Inheriting from FastAllocBase can result in objects getting larger (bug #33896, #46589).
879         The modification replaces Noncopyable and FastAllocBase classes and these inherits with their
880         equivalent macro implementation at the necessary places.
881 2011-01-20  Yi Shen  <yi.4.shen@nokia.com>
882
883         Unreviewed. 
884
885         Adding myself to committers.py.
886
887         * Scripts/webkitpy/common/config/committers.py:
888
889 2011-01-20  Adam Barth  <abarth@webkit.org>
890
891         Reviewed by Tony Chang.
892
893         Chromium builders don't delete unversioned directories when DEPS change
894         https://bugs.webkit.org/show_bug.cgi?id=52745
895
896         If we pass this option to gclient sync, gclient will delete directories
897         that are no longer part of DEPS instead of leaving them around to
898         confuse us later.  Apparently, the downstream buildbots use this option
899         already.
900
901         * Scripts/update-webkit-chromium:
902
903 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
904
905         Unreviewed, build fix - I pulled this patch in to fix an issue
906         revealed by r76195 running on some new bots). Also fix a couple
907         of other issues revealed in testing.
908
909         nrwt: remove fs refs from layout_package/json*
910
911         https://bugs.webkit.org/show_bug.cgi?id=52754
912
913         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
914         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
915         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
916         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
917         * Scripts/webkitpy/layout_tests/port/base.py:
918
919 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
920
921         Unreviewed, build fix.
922
923         Fix a couple of minor bugs discovered while bringing up new bots
924         for testing.
925
926         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
927         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
928
929 2011-01-19  James Robinson  <jamesr@chromium.org>
930
931         Unreviewed, rolling out r76194.
932         http://trac.webkit.org/changeset/76194
933         https://bugs.webkit.org/show_bug.cgi?id=51218
934
935         Caused mysterious compile failure on the chromium win
936         build.webkit.org bots
937
938         * DumpRenderTree/chromium/WebViewHost.cpp:
939         (WebViewHost::paintInvalidatedRegion):
940         * DumpRenderTree/chromium/WebViewHost.h:
941
942 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
943
944         Reviewed by Mihai Parparita.
945
946         remove fs refs from test_runner, dump_render_tree_thread
947
948         https://bugs.webkit.org/show_bug.cgi?id=52753
949
950         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
951         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
952         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
953         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
954
955 2011-01-19  James Robinson  <jamesr@chromium.org>
956
957         Reviewed by Darin Fisher.
958
959         Implement mozilla's requestAnimationFrame API
960         https://bugs.webkit.org/show_bug.cgi?id=51218
961
962         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
963
964         * DumpRenderTree/chromium/WebViewHost.cpp:
965         (invokeScheduleComposite):
966         (WebViewHost::scheduleAnimation):
967         (WebViewHost::paintInvalidatedRegion):
968         * DumpRenderTree/chromium/WebViewHost.h:
969
970 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
971
972         Unreviewed, build fix.
973
974         Fix a few incorrect "self._filesystem" references introduced in
975         r76184.
976
977         * Scripts/webkitpy/layout_tests/port/chromium.py:
978         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
979
980 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
981
982         Reviewed by Mihai Parparita.
983
984         add a .sep property, abspath(), isabs(), mtime(), and
985         open_text_file_for_writing() to filesystem modules. Some of
986         these properties are not needed in this patch but will be needed
987         in subsequent patches (I'm doing this to avoid having to track
988         multiple versions of a single file).
989
990         Also, change most of the port/* modules to use the filesystem
991         objects instead of referencing the filesystem directly.
992
993         https://bugs.webkit.org/show_bug.cgi?id=52748
994
995         * Scripts/webkitpy/common/system/filesystem.py:
996         * Scripts/webkitpy/common/system/filesystem_mock.py:
997         * Scripts/webkitpy/layout_tests/port/__init__.py:
998         * Scripts/webkitpy/layout_tests/port/base.py:
999         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1000         * Scripts/webkitpy/layout_tests/port/chromium.py:
1001         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1002         * Scripts/webkitpy/layout_tests/port/config.py:
1003         * Scripts/webkitpy/layout_tests/port/test.py:
1004         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
1005
1006 2011-01-19  Maciej Stachowiak  <mjs@apple.com>
1007
1008         Reviewed by Anders Carlsson.
1009
1010         If resetting between tests times out, treat it as a WebProcess crash
1011         https://bugs.webkit.org/show_bug.cgi?id=52757
1012
1013         * WebKitTestRunner/TestController.cpp:
1014         (WTR::TestController::runTest):
1015
1016 2011-01-19  Alexey Proskuryakov  <ap@apple.com>
1017
1018         Reviewed by Darin Adler.
1019
1020         https://bugs.webkit.org/show_bug.cgi?id=52739
1021         Make it possible for a WebKit2 client to print headers and footers
1022
1023         Added dummy implementations for new printing UIClient calls.
1024
1025         * MiniBrowser/mac/BrowserWindowController.m:
1026         (-[BrowserWindowController awakeFromNib]):
1027         * WebKitTestRunner/TestController.cpp:
1028         (WTR::createOtherPage):
1029         (WTR::TestController::initialize):
1030
1031 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1032
1033         Reviewed by Ojan Vafai.
1034
1035         Change webkitpy/layout_tests/port/test.py to use the
1036         in-memory filesystem for cleaner unit testing. This
1037         change allows us to kill a lot of code that was
1038         specific to the test port, at the cost of being a
1039         little less clear about how things would work if
1040         you didn't have a filesystem.
1041
1042         https://bugs.webkit.org/show_bug.cgi?id=52605
1043
1044         * Scripts/webkitpy/layout_tests/port/test.py:
1045
1046 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1047
1048         Unreviewed, build fix.
1049
1050         Fix test failure caused by committing attachment 79368 instead
1051         of attachment 79461 on bug 52604.
1052
1053         * Scripts/webkitpy/common/system/filesystem_mock.py:
1054
1055 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1056
1057         Reviewed by Mihai Parparita.
1058
1059         new-run-webkit-tests: remove use of os.walk, use mock filesystem for better
1060         unit testing. os.walk() is too much of a hassle to implement on
1061         top of the in-memory mock filesystem and adding the necessary
1062         interface to files_under() gives clients a cleaner API anyway
1063         (for this particular usage model).
1064
1065         https://bugs.webkit.org/show_bug.cgi?id=52691
1066
1067         * Scripts/webkitpy/common/system/filesystem.py:
1068         * Scripts/webkitpy/common/system/filesystem_mock.py:
1069         * Scripts/webkitpy/layout_tests/port/test_files.py:
1070         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
1071
1072 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1073
1074         Reviewed by Tony Chang.
1075
1076         Change more modules in the layout-tests code to use the
1077         filesystem wrapper for cleaner unit testing.
1078
1079         This patch also adds the glob() wrapper to the filesystem
1080         abstraction.
1081         
1082         https://bugs.webkit.org/show_bug.cgi?id=52604
1083
1084         * Scripts/webkitpy/layout_tests/port/test_files.py:
1085         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
1086         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
1087         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1088         * Scripts/webkitpy/common/system/filesystem.py:
1089         * Scripts/webkitpy/common/system/filesystem_mock.py:
1090
1091 2011-01-19  Levi Weintraub  <leviw@chromium.org>
1092
1093         Unreviewed.
1094
1095         Updating my email addresses and irc nick.
1096
1097         * Scripts/webkitpy/common/config/committers.py:
1098
1099 2011-01-19  Tony Chang  <tony@chromium.org>
1100
1101         Reviewed by Mihai Parparita.
1102
1103         [chromium] [linux] if check-sys-deps fails, output the failure reason
1104         https://bugs.webkit.org/show_bug.cgi?id=52671
1105
1106         * Scripts/webkitpy/common/system/executive_mock.py: Add support for
1107             error handler functions.
1108         * Scripts/webkitpy/layout_tests/port/chromium.py:
1109             output the error text from --check-sys-deps
1110         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1111
1112 2011-01-19  Aparna Nandyal  <aparna.nand@wipro.com>
1113
1114         Reviewed by Andreas Kling.
1115
1116         [Qt] QtTestBrowser crashes when closing if Facebook is opened
1117         https://bugs.webkit.org/show_bug.cgi?id=52554
1118         
1119         QtNetworkAccessManager is created in a thread and set as
1120         member variable in QWebPage. When the thread is destroyed
1121         the object is still used. So fix will set the object to
1122         NULL once the thread is destroyed.
1123
1124         * QtTestBrowser/launcherwindow.cpp:
1125         (LauncherWindow::~LauncherWindow):
1126
1127 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
1128
1129         Rubber stamped by Csaba Osztrogonac
1130
1131         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Removed unncessary inculde of WKStringCF.h
1132
1133 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
1134
1135         Reviewed by Tony Chang.
1136
1137         new-run-webkit-tests: add a --build-directory command line argument
1138
1139         Official Google Chrome builds use a non-standard build directory
1140         location. This patch adds a --build-directory argument that
1141         allows that location to be specified on the command line. Only
1142         Chromium-based builds will use this flag for now, but anyone can
1143         in the future.
1144
1145         There are no unit tests for this since it's difficult to test
1146         until mock filesystems are fully supported in the code. This was
1147         tested by hand for now.
1148
1149         https://bugs.webkit.org/show_bug.cgi?id=52694
1150
1151         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1152         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1153         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1154         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1155
1156 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
1157
1158         Not reviewed. Bot fix.
1159
1160         Remove an inadvertently committed debugging print.
1161
1162         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1163         (LayoutTestController::notifyDone):
1164
1165 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
1166
1167         Reviewed by Sam Weinig.
1168
1169         WebKitTestRunner should track loading more like DumpRenderTree
1170         https://bugs.webkit.org/show_bug.cgi?id=52692
1171
1172         Change load tracking to track the current top loading frame, in the manner of DumpRenderTree.
1173         This makes some tests that call notifyDone multiple times pass.
1174         
1175         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1176         (WTR::InjectedBundle::InjectedBundle):
1177         (WTR::InjectedBundle::done):
1178         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1179         (WTR::InjectedBundle::topLoadingFrame):
1180         (WTR::InjectedBundle::setTopLoadingFrame):
1181         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1182         (WTR::InjectedBundlePage::InjectedBundlePage):
1183         (WTR::InjectedBundlePage::stopLoading):
1184         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
1185         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
1186         (WTR::InjectedBundlePage::didFinishLoadForFrame):
1187         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
1188         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1189         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1190         (WTR::LayoutTestController::notifyDone):
1191         * WebKitTestRunner/TestController.cpp:
1192         (WTR::TestController::didReceiveMessageFromInjectedBundle):
1193
1194 2011-01-18  Mihai Parparita  <mihaip@chromium.org>
1195
1196         Reviewed by Kent Tamura.
1197
1198         [Chromium] NRWT looking for DRT binary in the wrong path on Mac
1199         https://bugs.webkit.org/show_bug.cgi?id=52678
1200         
1201         Update path now that WebKit is inside Source.
1202
1203         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1204
1205 2011-01-18  Robert Hogan  <robert@webkit.org>
1206
1207         Reviewed by Simon Hausmann.
1208
1209         [Qt] http/tests/incremental/slow-utf8-text.pl fails
1210         https://bugs.webkit.org/show_bug.cgi?id=44282
1211
1212         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1213         (WebCore::DumpRenderTree::dump):
1214
1215 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
1216
1217         Reviewed by Mihai Parparita.
1218
1219         Fix a small race condition that could cause the unit tests for
1220         new-run-webkit-tests to fail in a multithreaded environment.
1221         There was a small window in the code where one thread would
1222         check to see if a thread had raised an exception, do something,
1223         and then check to see if the thread was alive. If the other
1224         thread raised an exception and exited in between these two
1225         steps, the exception would be lost. Flipping the order of the
1226         two checks fixes the race, since we will now always check for an
1227         exception on the thread before exiting.
1228
1229         https://bugs.webkit.org/show_bug.cgi?id=51579
1230
1231         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
1232
1233 2011-01-18  Eric Seidel  <eric@webkit.org>
1234
1235         Reviewed by Adam Barth.
1236
1237         commit-queue dies when test archiving fails
1238         https://bugs.webkit.org/show_bug.cgi?id=52617
1239
1240         I looked at the machine and it had 10 archives already
1241         thus find_unused_name was returning None.  I've upped
1242         the limit to 100 (per bug) and tested the case where
1243         find_unused_name returns None (making archive return None).
1244
1245         * Scripts/webkitpy/common/system/workspace.py:
1246         * Scripts/webkitpy/common/system/workspace_unittest.py:
1247         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1248         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1249         * Scripts/webkitpy/tool/commands/queues.py:
1250
1251 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
1252
1253         Reviewed by Ojan Vafai.
1254
1255         Update rebaseline-chromium-webkit-tests unit tests to use a mock
1256         filesystem. Also fix a couple of "with" statements missed by
1257         r76050.
1258
1259         https://bugs.webkit.org/show_bug.cgi?id=52487
1260
1261         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1262
1263 2011-01-18  Sergio Villar Senin  <svillar@igalia.com>
1264
1265         Reviewed by Martin Robinson.
1266
1267         [Gtk] Build fixes for gtk3 build
1268         https://bugs.webkit.org/show_bug.cgi?id=52648
1269
1270         * DumpRenderTree/gtk/EventSender.cpp:
1271         (beginDragWithFilesCallback):
1272
1273 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
1274
1275         Reviewed by Mihai Parparita.
1276
1277         Update rebaseline-chromium-webkit-tests to use filesystem objects
1278         instead of direct references to os.path, shutil, tempfile, etc.
1279
1280         This patch doesn't change anything, but will allow subsequent
1281         patches to change the unit tests to no longer use the real
1282         filesystem.
1283
1284         This patch adds a bunch more methods to the filesystem object as
1285         well.
1286
1287         https://bugs.webkit.org/show_bug.cgi?id=52482
1288
1289         * Scripts/webkitpy/common/system/filesystem.py:
1290         * Scripts/webkitpy/common/system/filesystem_mock.py:
1291         * Scripts/webkitpy/tool/commands/queues.py:
1292         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1293         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1294
1295 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
1296
1297         Reviewed by Mihai Parparita.
1298
1299         new-run-webkit-tests shouldn't crash when you try to run a
1300         directory containing only skipped files.
1301
1302         https://bugs.webkit.org/show_bug.cgi?id=52478
1303         
1304         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1305         * Scripts/webkitpy/layout_tests/port/test.py:
1306         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1307
1308 2011-01-18  Adam Bergkvist  <adam.bergkvist@ericsson.com> and Martin Robinson  <mrobinson@igalia.com>
1309
1310         Reviewed by Gustavo Noronha Silva.
1311
1312         [GTK] The GTK+ EventSender needs support for beginDragWithFiles
1313         https://bugs.webkit.org/show_bug.cgi?id=40833
1314
1315         * DumpRenderTree/gtk/EventSender.cpp: Add a beginDragWithFiles implementation for the
1316         GTK+ event sender.
1317         (dragWithFilesDragDataGetCallback): Added.
1318         (dragWithFilesDragEndCallback): Added.
1319         (beginDragWithFilesCallback): Added.
1320
1321 2011-01-18  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1322
1323         Reviewed by Adam Barth.
1324
1325         ews: Add additional watcher to efl ews
1326         https://bugs.webkit.org/show_bug.cgi?id=52613
1327
1328         Add gyuyoung.kim@samsung.com to watcher list of efl-ews.
1329
1330         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1331
1332 2011-01-17  Tony Gentilcore  <tonyg@chromium.org>
1333
1334         Reviewed by Alexey Proskuryakov.
1335
1336         Fix some headers with missing or misspelled #ifndef guards
1337         https://bugs.webkit.org/show_bug.cgi?id=52545
1338
1339         * DumpRenderTree/chromium/TestEventPrinter.h:
1340         * DumpRenderTree/chromium/WebPreferences.h:
1341
1342 2011-01-17  Jessie Berlin  <jberlin@apple.com>
1343
1344         Reviewed by Anders Carlsson.
1345
1346         REGRESSION: Assertion failure in FrameLoader::continueLoadAfterWillSubmitForm() when
1347         navigating back to an unreachable URL
1348         https://bugs.webkit.org/show_bug.cgi?id=52388
1349
1350         Add a third parameter (unreachableURL) to queueLoadHTMLString.
1351
1352         * DumpRenderTree/LayoutTestController.cpp:
1353         (queueLoadHTMLStringCallback):
1354         (LayoutTestController::queueLoadHTMLString):
1355         (LayoutTestController::queueLoadAlternateHTMLString):
1356         * DumpRenderTree/LayoutTestController.h:
1357
1358         * DumpRenderTree/WorkQueueItem.h:
1359         (LoadHTMLStringItem::LoadHTMLStringItem):
1360
1361         * DumpRenderTree/chromium/LayoutTestController.cpp:
1362         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
1363         (WorkItemLoadHTMLString::run):
1364         (LayoutTestController::queueLoadHTMLString):
1365
1366         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
1367         (LoadHTMLStringItem::invoke):
1368         * DumpRenderTree/mac/WorkQueueItemMac.mm:
1369         (LoadHTMLStringItem::invoke):
1370         * DumpRenderTree/win/WorkQueueItemWin.cpp:
1371         (LoadHTMLStringItem::invoke):
1372
1373 2011-01-17  Dan Bernstein  <mitz@apple.com>
1374
1375         Rubber-stamped by Mark Rowe.
1376
1377         Update xcodeproj svn:ignore to include xcuserdata.
1378
1379         * DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
1380         * MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
1381         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
1382         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
1383         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
1384
1385 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
1386
1387         Unreviewed fix after r75908.
1388
1389         Move WebKit into Source
1390         https://bugs.webkit.org/show_bug.cgi?id=52530
1391
1392         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add Source to the path for Qt API tests.
1393
1394 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
1395
1396         Unreviewed.
1397
1398         Remove accidentally committed debug printing after r75908.
1399
1400         * Scripts/webkitdirs.pm:
1401
1402 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
1403
1404         Unreviewed.
1405
1406         Add myself to committers list
1407         https://bugs.webkit.org/show_bug.cgi?id=52566
1408
1409         * Scripts/webkitpy/common/config/committers.py:
1410
1411 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
1412
1413         Reviewed by Jeremy Orlow.
1414
1415         GeolocationController should call stopUpdating on destruction
1416         https://bugs.webkit.org/show_bug.cgi?id=52216
1417
1418         fast/dom/Geolocation/window-close-crash.html requires that a
1419         Geolocation watch be started in a secondary window. Consequently,
1420         we need to allow geolocation permission and provide a mock
1421         geolocation position for the secondary window's
1422         GeolocationClientMock.
1423
1424         * DumpRenderTree/chromium/LayoutTestController.cpp:
1425         (LayoutTestController::setGeolocationPermission):
1426         (LayoutTestController::setMockGeolocationPosition):
1427         (LayoutTestController::setMockGeolocationError):
1428         * DumpRenderTree/chromium/TestShell.h:
1429         (TestShell::windowList):
1430
1431 2011-01-16  Adam Barth  <abarth@webkit.org>
1432
1433         Update more include paths to reflect WebKit move.
1434
1435         * DumpRenderTree/chromium/EventSender.cpp:
1436         (EventSender::keyDown):
1437         (EventSender::needsShiftModifier):
1438         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
1439         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
1440
1441 2011-01-16  Kent Tamura  <tkent@chromium.org>
1442
1443         Unreviewed, Chromium build fix.
1444
1445         * Scripts/update-webkit-chromium: Webkit/chromium -> Source/WebKit/chromium
1446
1447 2011-01-16  Martin Robinson  <mrobinson@igalia.com>
1448
1449         Build fix for GTK+ after source directory movement.
1450
1451         * GNUmakefile.am: Correct include paths.
1452
1453 2011-01-16  Adam Barth  <abarth@webkit.org>
1454
1455         Teach svn-apply about WebKit move.
1456
1457         * Scripts/VCSUtils.pm:
1458
1459 2011-01-16  Adam Barth  <abarth@webkit.org>
1460
1461         Rubber-stamped by Eric Seidel.
1462
1463         Move WebKit into Source
1464         https://bugs.webkit.org/show_bug.cgi?id=52530
1465
1466         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
1467         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1468         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1469         * DumpRenderTree/qt/GCControllerQt.cpp:
1470         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1471         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
1472         * DumpRenderTree/qt/TextInputControllerQt.cpp:
1473         * DumpRenderTree/wscript:
1474         * QtTestBrowser/launcherwindow.h:
1475         * Scripts/build-webkit:
1476         * Scripts/webkitdirs.pm:
1477
1478 2011-01-15  Adam Barth  <abarth@webkit.org>
1479
1480         Teach svn-apply about WebKit2 move.
1481
1482         * Scripts/VCSUtils.pm:
1483
1484 2011-01-15  Adam Barth  <abarth@webkit.org>
1485
1486         Rubber-stamped by Eric Seidel.
1487
1488         Move WebKit2 into Source
1489         https://bugs.webkit.org/show_bug.cgi?id=52438
1490
1491         * MiniBrowser/qt/MiniBrowser.pro:
1492         * Scripts/build-webkit:
1493         * Scripts/do-file-rename:
1494         * Scripts/do-webcore-rename:
1495         * Scripts/test-webkitpy:
1496         * Scripts/webkitdirs.pm:
1497         * Scripts/webkitpy/style/checker.py:
1498         * WebKitTestRunner/DerivedSources.pro:
1499         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1500         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1501
1502 2011-01-15  Jochen Eisinger  <jochen@chromium.org>
1503
1504         Reviewed by David Levin.
1505
1506         [chromium] remove obsolete createView method
1507         https://bugs.webkit.org/show_bug.cgi?id=52437
1508
1509         * DumpRenderTree/chromium/WebViewHost.cpp:
1510         (WebViewHost::createView):
1511         * DumpRenderTree/chromium/WebViewHost.h:
1512
1513 2011-01-14  Brian Weinstein  <bweinstein@apple.com>
1514
1515         Reviewed by Geoff Garen.
1516
1517         ShouldLoadResourceForFrame should use strings, not URLs.
1518         https://bugs.webkit.org/show_bug.cgi?id=52476
1519
1520         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1521         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Update to use a WKStringRef.
1522         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1523
1524 2011-01-14  Tony Gentilcore  <tonyg@chromium.org>
1525
1526         Reviewed by David Levin.
1527
1528         Add Tony Gentilcore as a reviewer
1529         https://bugs.webkit.org/show_bug.cgi?id=52480
1530
1531         * Scripts/webkitpy/common/config/committers.py:
1532
1533 2011-01-14  David Levin  <levin@chromium.org>
1534
1535         Reviewed by Eric Seidel.
1536
1537         check-webkit-style: _FunctionState should keep track of where the function name starts.
1538         https://bugs.webkit.org/show_bug.cgi?id=52454
1539
1540         * Scripts/webkitpy/style/checkers/cpp.py: Added function_name_start_position to
1541         _FunctionState and logic for setting it correctly.
1542         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests.
1543
1544 2011-01-14  Vincent Scheib  <scheib@chromium.org>
1545
1546         Reviewed by David Levin.
1547
1548         Add support to DumpRenderTree to use the GPU rather than software renderer
1549         https://bugs.webkit.org/show_bug.cgi?id=52333
1550
1551         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1552         (main):
1553         * Scripts/webkitpy/layout_tests/port/chromium.py:
1554         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1555
1556 2011-01-14  Tony Chang  <tony@chromium.org>
1557
1558         Reviewed by Kent Tamura.
1559
1560         [chromium] update fonts.conf to fix 6 linux tests in drt
1561         https://bugs.webkit.org/show_bug.cgi?id=52411
1562
1563         * DumpRenderTree/chromium/fonts.conf: Update to match the copy in
1564             chromium's src/webkit/tools/test_shell/resources/fonts.conf
1565
1566 2011-01-14  Eric Seidel  <eric@webkit.org>
1567
1568         Original patch from Peter Gal  <galpater@inf.u-szeged.hu>
1569
1570         Reviewed by Adam Barth.
1571
1572         Fix when running Tools/Scripts/check-webkit-style without arguments.
1573         https://bugs.webkit.org/show_bug.cgi?id=52261#c16
1574
1575         * Scripts/webkitpy/common/checkout/scm.py: Handle None for changed_files argument better in Git.create_patch method.
1576         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1577
1578 2011-01-04  Jochen Eisinger  <jochen@chromium.org>
1579
1580         Reviewed by David Levin.
1581
1582         Store the tempdir object in a variable so it doesn't get deleted too early.
1583         https://bugs.webkit.org/show_bug.cgi?id=51875
1584
1585         * Scripts/update-webkit-auxiliary-libs:
1586         * Scripts/update-webkit-support-libs:
1587
1588 2011-01-14  Eric Seidel  <eric@webkit.org>
1589
1590         Unreviewed.  Make it work in python 2.5.
1591
1592         webkit-patch suggest-reviewers dies when ChangeLogs are missing
1593         https://bugs.webkit.org/show_bug.cgi?id=49158
1594
1595         * Scripts/webkitpy/common/checkout/api_unittest.py:
1596
1597 2011-01-14  Sheriff Bot  <webkit.review.bot@gmail.com>
1598
1599         Unreviewed, rolling out r75774.
1600         http://trac.webkit.org/changeset/75774
1601         https://bugs.webkit.org/show_bug.cgi?id=52431
1602
1603         gtk builds were broken (Requested by loislo2 on #webkit).
1604
1605         * Scripts/webkitpy/common/checkout/scm.py:
1606
1607 2011-01-14  David Levin  <levin@chromium.org>
1608
1609         Reviewed by Shinichiro Hamaji.
1610
1611         check-webkit-style: _FunctionState should detect pure functions.
1612         https://bugs.webkit.org/show_bug.cgi?id=52428
1613
1614         * Scripts/webkitpy/style/checkers/cpp.py: Added detection for if a function declaration
1615         is a pure virtual function.
1616         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests for verifying that pure
1617         virtual functions are correctly detected.
1618
1619 2011-01-13  Ilya Tikhonovsky  <loislo@chromium.org>
1620
1621         Reviewed by Yury Semikhatsky.
1622
1623         Just small fix for problem with check-webkit-style.
1624         It just didn't work for this patch.
1625         Old code can't concatenate a list of strings with None.
1626
1627         * Scripts/webkitpy/common/checkout/scm.py:
1628
1629 2011-01-13  David Levin  <levin@chromium.org>
1630
1631         Reviewed by Shinichiro Hamaji.
1632
1633         check-webkit-style: _FunctionState should use Position to know where items are.
1634         https://bugs.webkit.org/show_bug.cgi?id=52424
1635
1636         * Scripts/webkitpy/style/checkers/cpp.py:
1637         (_FunctionState.*): Changed _FunctionState to use Position instead of line numbers.
1638         (detect_functions): Changed to pass Position's to _FunctionState.begin and
1639         did some minor clean-up.
1640         (*): Other changes are simply about converting to use the Position's in_FunctionState
1641         instead of line numbers.
1642         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Changed the test code
1643         to verify the positions stored in _FunctionState.
1644
1645 2011-01-13  Eric Seidel  <eric@webkit.org>
1646
1647         Reviewed by David Levin.
1648
1649         webkit-patch suggest-reviewers dies when ChangeLogs are missing
1650         https://bugs.webkit.org/show_bug.cgi?id=49158
1651
1652         This is not the most elegant, but it is a very safe fix to this bug.
1653         One advantage of catching ScriptError like this instead of adding a
1654         new added_or_modified_files or fixing all changed_files callers
1655         to use a more specific change_files variant, is that we catch
1656         all kinds of ScriptErrors which might cause our (non-essential)
1657         suggest-reviewers code to fail out.  This should make passing
1658         --suggest-reviewers to webkit-patch upload much more robust
1659         and may even make it possible for us to make it default.
1660
1661         The root of the problem here is that SCM.changed_files includes
1662         deleted ChangeLog paths (from moves, etc) which then when we ask
1663         SVN/Git for the contents of the file at that revision, the command
1664         errors out and Executive.run_command raises a ScriptError.
1665
1666         In the future we might fix this differently by making all current
1667         callers of chagned_files use a more specific method for requesting
1668         what types of changes they're interested in (adds, modifies, deletes, etc.)
1669
1670         * Scripts/webkitpy/common/checkout/api.py:
1671         * Scripts/webkitpy/common/checkout/api_unittest.py:
1672
1673 2011-01-13  Dan Bernstein  <mitz@apple.com>
1674
1675         Reviewed by Alexey Proskuryakov.
1676
1677         <rdar://problem/8827065> REGRESSION (r71884): Cross-origin XHR fails if willSendRequest changes the URL
1678         https://bugs.webkit.org/show_bug.cgi?id=52419
1679
1680         Allow to further control the behavior of the willSendRequest delegate callback by making it
1681         set a different URL in the new request.
1682
1683         * DumpRenderTree/LayoutTestController.cpp:
1684         (addURLToRedirectCallback): Added.
1685         (LayoutTestController::staticFunctions): Added addURLToRedirect.
1686         (LayoutTestController::addURLToRedirect): Added. Adds the redirection to the map.
1687         (LayoutTestController::redirectionDestinationForURL): Added this getter.
1688         * DumpRenderTree/LayoutTestController.h:
1689         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1690         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): Check
1691         if there is a redirection for the request’s URL, established by addURLToRedirect(), and if so,
1692         change the URL in the new request to the redirect destination.
1693
1694 2011-01-13  Eric Seidel  <eric@webkit.org>
1695
1696         Reviewed by Mihai Parparita.
1697
1698         webkit-patch suggest-reviewers fails due to invalid utf8 in ChangeLog files
1699         https://bugs.webkit.org/show_bug.cgi?id=52416
1700
1701         Example: webkit-patch suggest-reviewers -g ca3890fe74d94d85d6bfa48f9ea497b094d8e717 
1702         UnicodeDecodeError: 'utf8' codec can't decode bytes in position 536-538: invalid data
1703
1704         I also added FIXMEs about the changed_files returning deleted files problem
1705         which is causing the other most common exception for suggest-reviewers
1706         (and is probably breaking sheriff-bots blame detection).
1707
1708         * Scripts/webkitpy/common/checkout/api.py:
1709         * Scripts/webkitpy/common/checkout/api_unittest.py:
1710         * Scripts/webkitpy/common/checkout/scm.py:
1711
1712 2011-01-13  Eric Seidel  <eric@webkit.org>
1713
1714         Reviewed by Adam Barth.
1715
1716         results archives from commit-queue are too large to upload
1717         https://bugs.webkit.org/show_bug.cgi?id=52405
1718
1719         * Scripts/webkitpy/common/system/filesystem.py:
1720         * Scripts/webkitpy/common/system/filesystem_mock.py:
1721         * Scripts/webkitpy/tool/commands/queues.py:
1722
1723 2011-01-13  Alejandro G. Castro  <alex@igalia.com>
1724
1725         Reviewed by Martin Robinson.
1726
1727         [gtk] Zero-sized font does not yet work
1728         https://bugs.webkit.org/show_bug.cgi?id=49793
1729
1730         Set minimum-font-size to 0 for the DRT.
1731
1732         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1733         (resetDefaultsToConsistentValues):
1734
1735 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
1736
1737         Reviewed by Darin Adler.
1738
1739         Make old-run-webkit-tests more robust on buildbots
1740         https://bugs.webkit.org/show_bug.cgi?id=52364
1741
1742         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Pass --exit-after-n-failures 500 to old-run-webkit-tests script.
1743
1744 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
1745
1746         Reviewed by Darin Adler.
1747
1748         Make old-run-webkit-tests more robust on buildbots
1749         https://bugs.webkit.org/show_bug.cgi?id=52364
1750
1751         * Scripts/old-run-webkit-tests: Ensure that testResultsDirectory is empty.
1752
1753 2011-01-13  Tony Chang  <tony@chromium.org>
1754
1755         Reviewed by Kent Tamura.
1756
1757         [chromium] fix plugins/plugin-javascript-access.html on Linux and Mac
1758         https://bugs.webkit.org/show_bug.cgi?id=52332
1759
1760         Forked Info.plist is not longer needed.
1761
1762         * DumpRenderTree/chromium/TestNetscapePlugIn/Info.plist: Removed.
1763
1764 2011-01-13  Mikhail Naganov  <mnaganov@chromium.org>
1765
1766         Reviewed by Timothy Hatcher.
1767
1768         Web Inspector: Cleanup after r75613 -- make all UI-facing strings
1769         to be passed directly to WebInspector.UIString
1770
1771         https://bugs.webkit.org/show_bug.cgi?id=52365
1772
1773         * Scripts/check-inspector-strings:
1774
1775 2011-01-13  Sheriff Bot  <webkit.review.bot@gmail.com>
1776
1777         Unreviewed, rolling out r74881.
1778         http://trac.webkit.org/changeset/74881
1779         https://bugs.webkit.org/show_bug.cgi?id=52357
1780
1781         The EFL builder has been red for days (Requested by abarth on
1782         #webkit).
1783
1784         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1785         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1786
1787 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
1788
1789         Reviewed by David Levin.
1790
1791         Add beforeunload support to WebKitTestRunner
1792         https://bugs.webkit.org/show_bug.cgi?id=52353
1793         
1794         This makes a number of currently failing tests pass.
1795
1796         * WebKitTestRunner/TestController.cpp:
1797         (WTR::runBeforeUnloadConfirmPanel):
1798         (WTR::createOtherPage):
1799         (WTR::TestController::initialize):
1800
1801 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
1802
1803         Reviewed by Sam Weinig.
1804
1805         Detect, identify and recover from WebProcess crashes in run-webkit-tests
1806         https://bugs.webkit.org/show_bug.cgi?id=52330
1807
1808         * Scripts/old-run-webkit-tests: Detect when the regression test tool reports
1809         a web process crash.
1810         * WebKitTestRunner/TestController.cpp:
1811         (WTR::TestController::initialize): Set up a processDidCrash
1812         callback.
1813         (WTR::TestController::processDidCrash): Report that the Web process
1814         crashed.
1815         * WebKitTestRunner/TestController.h:
1816
1817 2011-01-12  David Levin  <levin@chromium.org>
1818
1819         Reviewed by Shinichiro Hamaji.
1820
1821         check-webkit-style -- close_expression function doesn't work correctly.
1822         https://bugs.webkit.org/show_bug.cgi?id=52272
1823
1824         * Scripts/webkitpy/style/checkers/cpp.py:
1825         (Position.__str__): Added a way to convert it to a string which is useful in tests.
1826         (Position.__cmp__): Added a way to compare Position which is useful in tests and
1827         generally useful (for upcoming code changes).
1828         (close_expression): Changed to use Position for input and output.
1829         Also, fixed many bugs such as only working correctly for parenthesis,
1830         not working correctly if given an offset in a line and not finding
1831         the real closing element if there were multiple closing elements in
1832         the same line.
1833         (detect_functions): Adjusted due to the change in arguments for
1834         close_expression.
1835         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1836         (CppStyleTestBase.assert_positions_equal): Added a way to verify that
1837         two positions are the same.
1838         (CppStyleTest.test_position): Added tests for the __str_ and __cmp__ methods.
1839         (CppStyleTest.test_close_expression): Added tests to catch the issues
1840         that were fixed.
1841
1842 2011-01-12  Sheriff Bot  <webkit.review.bot@gmail.com>
1843
1844         Unreviewed, rolling out r75576.
1845         http://trac.webkit.org/changeset/75576
1846         https://bugs.webkit.org/show_bug.cgi?id=52304
1847
1848         broke rebaseline-chromium-webkit-test (Requested by thakis on
1849         #webkit).
1850
1851         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1852         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1853         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1854         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1855         * Scripts/webkitpy/layout_tests/port/base.py:
1856         * Scripts/webkitpy/layout_tests/port/chromium.py:
1857         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1858         * Scripts/webkitpy/layout_tests/port/test.py:
1859         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1860         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1861         * Scripts/webkitpy/style/checkers/test_expectations.py:
1862         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1863
1864 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
1865
1866         Reviewed by Darin Adler.
1867
1868         Add a no-build option to run-webkit-tests, to avoid building DRT/WKTR
1869         https://bugs.webkit.org/show_bug.cgi?id=52307
1870
1871         * Scripts/old-run-webkit-tests:
1872
1873 2011-01-12  Koan-Sin Tan  <koansin.tan@gmail.com>
1874
1875         Reviewed by Martin Robinson.
1876
1877         [Gtk] WebKitGtk+ doesn't build on Mac OS X 10.6
1878         https://bugs.webkit.org/show_bug.cgi?id=50867
1879
1880         Fixed library extention for Mac in webkitdirs.pm and type conflict in
1881         TestNetscapePlugin.cpp 
1882
1883         * GNUmakefile.am: Don't use AppKit when compiling TestNetscapePlugin for GTK+
1884         * Scripts/webkitdirs.pm:
1885
1886 2011-01-12  Mikhail Naganov  <mnaganov@chromium.org>
1887
1888         Reviewed by Pavel Feldman.
1889
1890         Add check-inspector-strings script.
1891
1892         https://bugs.webkit.org/show_bug.cgi?id=52295
1893
1894         * Scripts/check-inspector-strings: Added.
1895
1896 2011-01-12  Adam Roben  <aroben@apple.com>
1897
1898         Advertise the .testnetscape file extension on Windows
1899
1900         Fixes <http://webkit.org/b/52298>
1901         plugins/no-mime-with-valid-extension.html fails on Windows
1902
1903         Reviewed by Dan Bernstein.
1904
1905         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Added a
1906         FileExtents field to map the .testnetscape file extension to the
1907         application/x-webkit-test-netscape MIME type, just as we do on Mac.
1908
1909 2011-01-12  Adam Barth  <abarth@webkit.org>
1910
1911         Reviewed by Eric Seidel.
1912
1913         Make webkit-patch support subdirectories for SVN checkouts
1914         https://bugs.webkit.org/show_bug.cgi?id=52261
1915
1916         os.relpath does not exist on Python 2.5, so we need to call our version
1917         of the API.
1918
1919         * Scripts/webkitpy/common/checkout/scm.py:
1920
1921 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
1922
1923         Reviewed by Eric Seidel.
1924
1925         Close additional pages opened during a test once the test completes.
1926         https://bugs.webkit.org/show_bug.cgi?id=52276
1927
1928         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1929         (WTR::InjectedBundle::done):
1930
1931 2011-01-11  David Levin  <levin@chromium.org>
1932
1933         Reviewed by Eric Seidel.
1934
1935         Errors should be separated from the command line in bot messages.
1936         https://bugs.webkit.org/show_bug.cgi?id=52275
1937
1938         * Scripts/webkitpy/common/system/executive.py:
1939         (ScriptError.message_with_output): Added a newline to separate the command
1940         line from the errors.
1941         * Scripts/webkitpy/common/system/executive_unittest.py:
1942         (ScriptErrorTest.test_message_with_output): Added tests for the various code
1943         paths in message_with_output.
1944
1945 2011-01-11  Eric Seidel  <eric@webkit.org>
1946
1947         Unreviewed.
1948
1949         commit-queue should know how to upload archived results (for test flakes or general failures)
1950         https://bugs.webkit.org/show_bug.cgi?id=52048
1951
1952         The zips are mostly empty due to forgetting -r.
1953         Expected diffs were not being pulled from the archive due
1954         to the archive having longer paths than I realized.
1955
1956         * Scripts/webkitpy/common/system/workspace.py:
1957         * Scripts/webkitpy/common/system/workspace_unittest.py:
1958         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1959         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1960
1961 2011-01-11  Dirk Pranke  <dpranke@chromium.org>
1962
1963         Reviewed by Ojan Vafai.
1964
1965         The current modifier parsing code in test_expectations is
1966         fragile and hard-coded, so it's not easy to understand the logic
1967         or easily add new types of modifiers (like GPU vs. CPU testing
1968         for graphics tests, or 32-bit vs. 64-bit differences).
1969
1970         This is the first of two patches that will add in more generic
1971         support and then eliminate the GPU-specific test expectations
1972         files for Chromium.
1973
1974         This patch adds two standalone objects for handling modifiers. The
1975         rules for interpreting modifiers, precedence, and conflicts are
1976         given in the docstring to the ModifierMatcher class, which
1977         returns ModifierMatchResult objects.
1978         
1979         This patch also adds routines to the Port interface and a
1980         default set of values in the base object, in order to obtain the
1981         values needed on a given test run. These values are then passed
1982         to the expectation parser. This also allows us to clean up the
1983         logic used to lint all of the different configurations in a
1984         single test_expectations.txt file.
1985
1986         The next patch will merge in the separate GPU expectations file.
1987
1988         https://bugs.webkit.org/show_bug.cgi?id=51222
1989
1990         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1991         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1992         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1993         * Scripts/webkitpy/layout_tests/port/base.py:
1994         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1995         * Scripts/webkitpy/layout_tests/port/chromium.py:
1996         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1997         * Scripts/webkitpy/layout_tests/port/test.py:
1998         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1999         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2000
2001 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
2002
2003         Reviewed by Adam Barth.
2004
2005         Make webkit-patch support subdirectories for SVN checkouts
2006         https://bugs.webkit.org/show_bug.cgi?id=52261
2007
2008         * Scripts/webkitpy/common/checkout/scm.py:
2009         * Scripts/webkitpy/style_references.py:
2010         * Scripts/webkitpy/tool/main.py:
2011         * Scripts/webkitpy/tool/steps/preparechangelog.py:
2012
2013 2011-01-11  Eric Seidel  <eric@webkit.org>
2014
2015         Unreviewed.
2016
2017         commit-queue should know how to upload archived results (for test flakes or general failures)
2018         https://bugs.webkit.org/show_bug.cgi?id=52048
2019
2020         I changed the API for archive_last_layout_test_results w/o updating the implementation.  Oops.
2021         This fixes an exception seen on the commit-queue when attempting to report flaky tests.
2022
2023         * Scripts/webkitpy/common/system/workspace.py:
2024         * Scripts/webkitpy/common/system/workspace_unittest.py:
2025         * Scripts/webkitpy/tool/commands/queues.py:
2026
2027 2011-01-11  Sam Weinig  <sam@webkit.org>
2028
2029         Roll r75474 back in.
2030
2031 2011-01-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
2032
2033         Reviewed by Kenneth Rohde Christiansen.
2034
2035         [Qt] Remove uses of QFuture since it isn't supported on all platforms.
2036         https://bugs.webkit.org/show_bug.cgi?id=51204
2037
2038         * QtTestBrowser/webpage.h:
2039         (QtNAMThread::QtNAMThread):
2040         (QtNAMThread::networkAccessManager):
2041         (QtNAMThread::run):
2042
2043 2011-01-11  Peter Varga  <pvarga@webkit.org>
2044
2045         Unreviewed.
2046
2047         Add myself to committers' list.
2048
2049         * Scripts/webkitpy/common/config/committers.py:
2050
2051 2011-01-11  Eric Seidel  <eric@webkit.org>
2052
2053         Reviewed by Adam Barth.
2054
2055         commit-queue should know how to upload archived results (for test flakes or general failures)
2056         https://bugs.webkit.org/show_bug.cgi?id=52048
2057
2058         Now the queue will always upload results.  Either the entire zip, or just
2059         the diffs.txt in the case of text failures.
2060
2061         This should make understanding flakes much easier, and paves the way
2062         for having the EWS run layout tests (and upload failures).
2063
2064         In order to upload .zip files I had to teach bugzilla.py to autodetect
2065         mime types from the filename.  Since mimetypes.py doesn't include a mapping
2066         for .patch files, I have it add one before calling guess_type.
2067
2068         We may find that always uploading the whole zip instead of just the -diffs.txt
2069         file is preferable, but for now I'm keeping the old behavior because it makes
2070         quickly understanding text failures easy.
2071
2072         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2073         * Scripts/webkitpy/common/system/workspace.py: Added.
2074         * Scripts/webkitpy/common/system/workspace_unittest.py: Added.
2075         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2076         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2077         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2078         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2079         * Scripts/webkitpy/tool/commands/queues.py:
2080         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2081
2082 2011-01-10  Sheriff Bot  <webkit.review.bot@gmail.com>
2083
2084         Unreviewed, rolling out r75464.
2085         http://trac.webkit.org/changeset/75464
2086         https://bugs.webkit.org/show_bug.cgi?id=52193
2087
2088         Followup rollout for 75474 (Requested by Ossy on #webkit).
2089
2090         * MiniBrowser/mac/BrowserWindowController.m:
2091         (-[BrowserWindowController awakeFromNib]):
2092         * MiniBrowser/win/BrowserView.cpp:
2093         (BrowserView::create):
2094         * WebKitTestRunner/TestController.cpp:
2095         (WTR::createOtherPage):
2096         (WTR::TestController::initialize):
2097
2098 2011-01-10  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2099
2100         Reviewed by Csaba Osztrogonác.
2101
2102         [Qt] Baseline qt_minimal configuration
2103         https://bugs.webkit.org/show_bug.cgi?id=51313
2104
2105         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2106         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): Add
2107         QT_NO_UNDOSTACK guard.
2108
2109         * QtTestBrowser/launcherwindow.cpp:
2110         (LauncherWindow::createChrome): Add QT_NO_SHORTCUT and QT_NO_PRINTER
2111         guards.
2112         (LauncherWindow::applyZoom): Add QT_NO_ANIMATION guard.
2113         (LauncherWindow::screenshot): Add QT_NO_FILEDIALOG guard.
2114         (LauncherWindow::selectElements): Add QT_NO_INPUTDIALOG guard.
2115         (LauncherWindow::showUserAgentDialog): Add QT_NO_COMBOBOX guard.
2116
2117         * QtTestBrowser/launcherwindow.h:
2118         * QtTestBrowser/locationedit.cpp: Add QT_NO_INPUTDIALOG guard.
2119         * QtTestBrowser/locationedit.h: Ditto.
2120
2121         * QtTestBrowser/mainwindow.cpp:
2122         (MainWindow::buildUI): Add QT_NO_INPUTDIALOG, QT_NO_SHORTCUT and
2123         QT_NO_UNDOSTACK guards.
2124         (MainWindow::setAddressUrl): Add QT_NO_INPUTDIALOG guard.
2125         (MainWindow::changeLocation): Ditto.
2126         (MainWindow::openFile): Add QT_NO_FILEDIALOG guard.
2127         (MainWindow::openLocation): Add QT_NO_INPUTDIALOG guard.
2128
2129         * QtTestBrowser/webpage.cpp:
2130         (WebPage::openUrlInDefaultBrowser): Add QT_NO_DESKTOPSERVICES guard.
2131         (WebPage::authenticationRequired): Add QT_NO_LINEEDIT guard.
2132
2133         * QtTestBrowser/webview.cpp:
2134         (WebViewGraphicsBased::animatedFlip): Add QT_NO_ANIMATION guard.
2135         (WebViewGraphicsBased::animatedYFlip): Ditto.
2136
2137 2011-01-10  Sam Weinig  <sam@webkit.org>
2138
2139         Fix build.
2140
2141         * MiniBrowser/mac/BrowserWindowController.m:
2142         (-[BrowserWindowController awakeFromNib]):
2143         * MiniBrowser/win/BrowserView.cpp:
2144         (BrowserView::create):
2145         * WebKitTestRunner/TestController.cpp:
2146         (WTR::createOtherPage):
2147         (WTR::TestController::initialize):
2148
2149 2011-01-10  Eric Seidel  <eric@webkit.org>
2150
2151         Reviewed by Ojan Vafai.
2152
2153         style-queue messages are way too long for big patches
2154         https://bugs.webkit.org/show_bug.cgi?id=52161
2155
2156         We definitely could build much fancier list-to-string-with-limit functions
2157         but this should be sufficient for our needs at the moment.
2158
2159         * Scripts/webkitpy/common/system/executive.py:
2160         * Scripts/webkitpy/common/system/executive_unittest.py:
2161
2162 2011-01-10  Tony Chang  <tony@chromium.org>
2163
2164         Unreviewed, rolling out r75398.
2165         http://trac.webkit.org/changeset/75398
2166         https://bugs.webkit.org/show_bug.cgi?id=52008
2167
2168         Some layout tests are crashing on Chromium Win.
2169
2170         * DumpRenderTree/chromium/WebViewHost.cpp:
2171         (WebViewHost::updatePaintRect):
2172         * DumpRenderTree/chromium/WebViewHost.h:
2173
2174 2011-01-10  Adam Roben  <aroben@apple.com>
2175
2176         Roll out r75392
2177
2178         It isn't needed now that r75289 has been rolled out.
2179
2180         * Scripts/run-javascriptcore-tests:
2181
2182 2011-01-10  Maciej Stachowiak  <mjs@apple.com>
2183
2184         Reviewed by Anders Carlsson.
2185
2186         WebKitTestRunner uses crazy amounts of CPU, making layout tests slow and flaky
2187         https://bugs.webkit.org/show_bug.cgi?id=52160
2188
2189         * WebKitTestRunner/mac/TestControllerMac.mm:
2190         (WTR::TestController::platformRunUntil): Instead of busy-looping, wait for the timeout.
2191         Anything that can make runUntil() conditions turn true will happen on a run loop cycle
2192         anyway.
2193
2194 2011-01-10  Tony Chang  <tony@chromium.org>
2195
2196         Reviewed by Mihai Parparita.
2197
2198         [chromium] fix for animated gif layout tests
2199         https://bugs.webkit.org/show_bug.cgi?id=52008
2200
2201         * DumpRenderTree/chromium/WebViewHost.cpp: Schedule a paint when we update the paint rect
2202             to trigger gif animations.
2203         (WebViewHostPaintTask::WebViewHostPaintTask):
2204         (WebViewHostPaintTask::runIfValid):
2205         (WebViewHost::updatePaintRect):
2206         * DumpRenderTree/chromium/WebViewHost.h:
2207         (WebViewHost::taskList):
2208
2209 2011-01-10  Alejandro G. Castro  <alex@igalia.com>
2210
2211         Reviewed by Xan Lopez.
2212
2213         [GTK] Fix gtk2 compilation for master
2214         https://bugs.webkit.org/show_bug.cgi?id=51885
2215
2216         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
2217         (createBitmapContextFromWebView): Replaced the old
2218         gdk_drawable_get_size with gdk_pixmap_get_size.
2219
2220 2011-01-10  Patrick Gansterer  <paroga@webkit.org>
2221
2222         Reviewed by Laszlo Gombos.
2223
2224         [WINCE] Reenable NPAPI after r75203
2225         https://bugs.webkit.org/show_bug.cgi?id=52109
2226
2227         Remove the !isWinCE() check for ENABLE_NETSCAPE_PLUGIN_API and replace
2228         it with !isEfl(), because EFL port does not support NPAPI (yet).
2229
2230         * Scripts/build-webkit:
2231
2232 2011-01-10  Adam Roben  <aroben@apple.com>
2233
2234         Skip some asserting JS tests
2235
2236         See <http://webkit.org/b/52156>.
2237
2238         * Scripts/run-javascriptcore-tests:
2239
2240 2011-01-10  Martin Robinson  <mrobinson@igalia.com>
2241
2242         Reviewed by Xan Lopez.
2243
2244         [GTK] build-webkit disable Blob support via arguments passed to automake
2245         https://bugs.webkit.org/show_bug.cgi?id=52097
2246
2247         * Scripts/build-webkit: Enable Blob support when building WebKitGTK+ via
2248         build-webkit.
2249
2250 2011-01-10  Adam Roben  <aroben@apple.com>
2251
2252         Use the same name and description for TestNetscapePlugin on Windows and
2253         Mac
2254
2255         Fixes <http://webkit.org/b/52151>
2256         fast/frames/iframe-reparenting-plugins.html fails on Windows
2257
2258         Reviewed by Steve Falkenburg.
2259
2260         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Copied
2261         the name and description from Mac's Info.plist.
2262
2263 2011-01-10  Siddharth Mathur <siddharth.mathur@nokia.com>
2264
2265         Reviewed by Laszlo Gombos.
2266
2267         [Qt][WK2] Guard gcc-specific syntax
2268
2269         Non-gcc based compliers choke on the "-include"
2270         syntax for preinclude, place guard around it.
2271
2272         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2273         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2274
2275 2011-01-10  Andreas Kling  <kling@webkit.org>
2276
2277         Reviewed by Simon Hausmann.
2278
2279         [Qt] [WK2] MiniBrowser does not load pages opened in new windows
2280         https://bugs.webkit.org/show_bug.cgi?id=52111
2281
2282         When getting a createNewPage() callback from QWKPage, create the
2283         new page with the same QWKContext as the page that is passed to
2284         the callback.
2285
2286         * MiniBrowser/qt/BrowserView.h:
2287         * MiniBrowser/qt/BrowserWindow.cpp:
2288         (newPageFunction):
2289         (BrowserWindow::BrowserWindow):
2290         * MiniBrowser/qt/BrowserWindow.h:
2291
2292 2011-01-10  Andreas Kling  <kling@webkit.org>
2293
2294         Reviewed by Kenneth Rohde Christiansen.
2295
2296         [Qt] MiniBrowser: Remove superfluous createNewPage() callback
2297
2298         BrowserView set its own useless createNewPage() callback on QWKPage.
2299         This was immediately overridden by BrowserWindow anyway, so remove
2300         the BrowserView one.
2301
2302         * MiniBrowser/qt/BrowserView.cpp:
2303         (BrowserView::BrowserView):
2304
2305 2011-01-10  John Knottenbelt  <jknotten@chromium.org>
2306
2307         Reviewed by Jeremy Orlow.
2308
2309         [Chromium] Remove non-client-based Geolocation code
2310         https://bugs.webkit.org/show_bug.cgi?id=50921
2311
2312         * DumpRenderTree/chromium/LayoutTestController.cpp:
2313         (LayoutTestController::setGeolocationPermission):
2314         (LayoutTestController::setMockGeolocationPosition):
2315         (LayoutTestController::setMockGeolocationError):
2316         * DumpRenderTree/chromium/WebViewHost.cpp:
2317         (WebViewHost::geolocationClientMock):
2318         (WebViewHost::reset):
2319         * DumpRenderTree/chromium/WebViewHost.h:
2320
2321 2011-01-10  Eric Seidel  <eric@webkit.org>
2322
2323         Reviewed by Adam Barth.
2324
2325         Commit bot tried to land r? cq+ patch
2326         https://bugs.webkit.org/show_bug.cgi?id=36638
2327
2328         It should now be possible to post a patch with r? and cq+ and the
2329         commit-queue will correctly wait for the r+ before attempting to land the patch.
2330         (This was a feature requested by several users.)
2331
2332         One caveat: We don't actually reject r-, cq+ patches from the queue
2333         (we just ignore them), but I think that's OK for now.
2334
2335         I also noticed that setting r- once a commit-queue node had grabbed
2336         a patch would not properly cancel the landing.  That's fixed and
2337         tested in this patch.
2338
2339         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2340         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2341         * Scripts/webkitpy/tool/bot/feeders.py:
2342         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
2343
2344 2011-01-08  Benjamin Poulain  <benjamin.poulain@nokia.com>
2345
2346         Reviewed by Kenneth Rohde Christiansen.
2347
2348         [Qt] QtWebKit crashes when using XMLHttpRequest from the unload event
2349         https://bugs.webkit.org/show_bug.cgi?id=51934
2350
2351         When accessing the network from the destructor of QWebPage, the network access manager
2352         was already deleted because the object WebPage was already destructed.
2353
2354         This solve the problem by linking the lifetime of the network access manager to WebPage's QObject.
2355         The object is now destructed in the destructor of QObject.
2356
2357         * QtTestBrowser/webpage.cpp:
2358         (WebPage::WebPage):
2359         (WebPage::setQnamThreaded):
2360         * QtTestBrowser/webpage.h:
2361         (QtNAMThread::QtNAMThread):
2362
2363 2011-01-08  Eric Seidel  <eric@webkit.org>
2364
2365         Reviewed by Ojan Vafai.
2366
2367         test_failures.py should not mention TestShell (long live DumpRenderTree!)
2368         https://bugs.webkit.org/show_bug.cgi?id=52067
2369
2370         I ran test-webkitpy, but didn't bother adding a unit test for this string change.
2371         https://bugs.webkit.org/show_bug.cgi?id=51138#c3 is an example of why this is needed.
2372
2373         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2374
2375 2011-01-08  Eric Seidel  <eric@webkit.org>
2376
2377         Reviewed by Mihai Parparita.
2378
2379         commit-queue hangs when the ChangeLog diff is bad
2380         https://bugs.webkit.org/show_bug.cgi?id=52072
2381
2382         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
2383         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
2384
2385 2011-01-08  Adam Barth  <abarth@webkit.org>
2386
2387         Teach svn-apply how to re-write WebCore to Source/WebCore.
2388
2389         * Scripts/VCSUtils.pm:
2390
2391 2011-01-07  Adam Barth  <abarth@webkit.org>
2392
2393         Rubber-stamped by Eric Seidel.
2394
2395         Move WebCore to Source
2396         https://bugs.webkit.org/show_bug.cgi?id=52050
2397
2398         Update the tools to understand WebCore's new location.
2399
2400         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2401         * DumpRenderTree/wscript:
2402         * GNUmakefile.am:
2403         * Scripts/build-webkit:
2404         * Scripts/do-file-rename:
2405         * Scripts/do-webcore-rename:
2406         * Scripts/generate-qt-inspector-resource:
2407         * Scripts/prepare-ChangeLog:
2408         * Scripts/run-bindings-tests:
2409         * Scripts/update-iexploder-cssproperties:
2410         * Scripts/update-sources-list.py:
2411         * Scripts/update-webkit-localizable-strings:
2412         * Scripts/webkitdirs.pm:
2413         * Scripts/webkitpy/common/config/build.py:
2414         * Scripts/webkitpy/common/config/build_unittest.py:
2415         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
2416         * Scripts/webkitpy/style/checker.py:
2417         * Scripts/webkitpy/style/checker_unittest.py:
2418         * WebKitTestRunner/DerivedSources.pro:
2419         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2420         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh:
2421         * wx/browser/wscript:
2422         * wx/build/settings.py:
2423
2424 2011-01-07  Maciej Stachowiak  <mjs@apple.com>
2425
2426         Reviewed by Sam Weinig.
2427
2428         Make WebKitTestRunner rest between loads more robust to avoid test crashes
2429         https://bugs.webkit.org/show_bug.cgi?id=52086
2430
2431         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2432         (WTR::InjectedBundle::didReceiveMessage):
2433         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2434         (WTR::LayoutTestController::notifyDone):
2435         * WebKitTestRunner/TestController.cpp:
2436         (WTR::TestController::resetStateToConsistentValues):
2437         (WTR::TestController::run):
2438
2439 2011-01-07  James Robinson  <jamesr@chromium.org>
2440
2441         Revert "Implement mozilla's animationTime property"
2442         https://bugs.webkit.org/show_bug.cgi?id=51952
2443
2444         This approach isn't quite right.
2445
2446         * DumpRenderTree/chromium/WebViewHost.cpp:
2447         (WebViewHost::paintInvalidatedRegion):
2448
2449 2011-01-07  Adam Roben  <aroben@apple.com>
2450
2451         Build master fix
2452
2453         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2454         (RunWebKitTests.start): Don't try to concatenate a list and a string.
2455
2456 2011-01-07  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
2457
2458         Reviewed by Csaba Osztrogonác.
2459
2460         run-qtwebkit-tests should be able to kill a testsuite.
2461
2462         Add new option in the script that can setup a timeout for a test.
2463         If the test execution takes more then specified time then the test
2464         would be terminated.
2465
2466         [Qt] run-qtwebkit-tests needs timeout
2467         https://bugs.webkit.org/show_bug.cgi?id=51894
2468
2469         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2470         * Scripts/run-qtwebkit-tests:
2471
2472 2011-01-07  Csaba Osztrogonác  <ossy@webkit.org>
2473
2474         Unreviewed fix after r75233.
2475
2476         Based on idea from Eric Seidel.
2477
2478         Add remote zip file handling to webkitpy.
2479         https://bugs.webkit.org/show_bug.cgi?id=50901
2480
2481         * Scripts/webkitpy/common/system/fileset.py: Make python 2.5 happy.
2482
2483 2011-01-07  Shane Stephens  <shanestephens@google.com>
2484
2485         Reviewed by Eric Seidel.
2486
2487         svn-apply: should support git binary delta diffs
2488         https://bugs.webkit.org/show_bug.cgi?id=38864
2489
2490         * Scripts/VCSUtils.pm:
2491         * Scripts/svn-apply:
2492
2493 2011-01-06  Julie Parent  <jparent@chromium.org>
2494
2495         Reviewed by Eric Seidel.
2496
2497         Test Result Server not removing old results.
2498         https://bugs.webkit.org/show_bug.cgi?id=52012
2499
2500         * TestResultServer/model/jsonresults.py:
2501         Fix off-by-one: Truncate if >= num_runs, not just >.
2502         * TestResultServer/model/jsonresults_unittest.py:
2503         Add unit test to test that merging in a new result with the same value
2504         as the last result causes previous result to fall off.
2505
2506 2011-01-06  James Kozianski  <koz@chromium.org>
2507
2508         Reviewed by Mihai Parparita.
2509
2510         Add classes to provide a consistent interface to a set of files.
2511         https://bugs.webkit.org/show_bug.cgi?id=50901
2512
2513         These classes allow us to write code that is agnostic to whether a
2514         particular set of files resides in a local directory or in a zip file
2515         on a remote machine.
2516
2517         * Scripts/webkitpy/common/system/directoryfileset.py: Added.
2518         * Scripts/webkitpy/common/system/directoryfileset_unittest.py: Added.
2519         * Scripts/webkitpy/common/system/fileset.py: Added.
2520         * Scripts/webkitpy/common/system/filesystem.py:
2521         * Scripts/webkitpy/common/system/filesystem_mock.py:
2522         * Scripts/webkitpy/common/system/zipfileset.py: Added.
2523         * Scripts/webkitpy/common/system/zipfileset_unittest.py: Added.
2524
2525 2011-01-06  Eric Seidel  <eric@webkit.org>
2526
2527         Reviewed by Adam Barth.
2528
2529         NetworkTransaction should log the url it is retrying
2530         https://bugs.webkit.org/show_bug.cgi?id=52043
2531
2532         * Scripts/webkitpy/common/net/networktransaction.py:
2533         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
2534
2535 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
2536
2537         Windows build fix.
2538         Import os before using it.
2539
2540         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2541
2542 2011-01-06  Eric Seidel  <eric@webkit.org>
2543
2544         Reviewed by Adam Barth.
2545
2546         StyleQueue fails to report errors when patches have many files
2547         https://bugs.webkit.org/show_bug.cgi?id=52042
2548
2549         This is one of at least two errors preventing style error reporting at the moment.
2550         When we moved to passing the list of files to check explicitly,
2551         we started to exceed the 500 character TEXT field limit for our AppEngine model object.
2552         We could change the type of the QueueStatus.message type, or we could
2553         just teach statusserver.py how to clamp values (and warn when it does).
2554         I chose the latter path.
2555
2556         * Scripts/webkitpy/common/net/statusserver.py:
2557
2558 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
2559
2560         Reviewed by Stephanie Lewis.
2561         
2562         Fix syntax error in script.
2563
2564         Windows bots need to archive/unarchive builds to/from configuration-specific directories
2565         https://bugs.webkit.org/show_bug.cgi?id=51996
2566
2567         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2568
2569 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2570
2571         Unreviewed, fixing WinCE build after r75196.
2572
2573         WinCE port does not (yet) support NPAPI.
2574
2575         * Scripts/build-webkit:
2576
2577 2011-01-06  Xan Lopez  <xlopez@igalia.com>
2578
2579         Reviewed by Darin Adler.
2580
2581         File::Spec->rel2abs in sunspider-compare-results mangles parameters
2582         https://bugs.webkit.org/show_bug.cgi?id=52015
2583
2584         * Scripts/sunspider-compare-results: call rel2abs on our arguments
2585         after the platform has been detected, otherwise the script will
2586         mangle things like '--gtk' into '/a/path/--gtk', breaking the
2587         detection.
2588
2589 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2590
2591         Reviewed by Eric Seidel.
2592
2593         Add ENABLE_NETSCAPE_PLUGIN_API, ENABLE_ORIENTATION_EVENTS and ENABLE_TOUCH_EVENTS flags to build-webkit
2594         https://bugs.webkit.org/show_bug.cgi?id=51346
2595
2596         * Scripts/build-webkit:
2597
2598 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
2599
2600         Reviewed by Adam Roben.
2601
2602         Windows bots need to archive/unarchive builds to/from configuration-specific directories
2603         https://bugs.webkit.org/show_bug.cgi?id=51996
2604         
2605         After the configuration directory change, we were archiving the incorrect directory for
2606         build product, so we were running tests on the wrong binaries.
2607         
2608         This change archives the correct directory, and also unarchives it into a configuration-
2609         specific directory.
2610
2611         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Use a configuration-specific directory on Windows.
2612         * BuildSlaveSupport/built-product-archive: Unarchive/archive to/from proper directory.
2613
2614 2011-01-06  Eric Seidel  <eric@webkit.org>
2615
2616         Reviewed by Mihai Parparita.
2617
2618         commit-queue mentions "Text diff mismatch" 4 times instead of once per failure
2619         https://bugs.webkit.org/show_bug.cgi?id=52002
2620
2621         See an example of this here:
2622         https://bugs.webkit.org/show_bug.cgi?id=51314#c2
2623
2624         It's due to the fact that we pass around TestFailure() instance
2625         objects and yet expect them to all compare to be the same.
2626
2627         This is bad.  We should either have shared instances of these values
2628         or we should just pass around the class names.  There are already hacks
2629         in place to make TestFailure objects pass equality tests, I just added
2630         a __hash__ implementation so they can be used in sets as expected.
2631
2632         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2633         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2634
2635 2011-01-06  Evan Martin  <evan@chromium.org>
2636
2637         Reviewed by Tony Chang.
2638
2639         [gdb] handle inaccessible memory and UChar*
2640         https://bugs.webkit.org/show_bug.cgi?id=52003
2641
2642         To pretty-print a UChar*, we just grope around in the memory
2643         looking for a terminating NUL.  We need to handle the exception
2644         that can occur when we poke into an invalid location.
2645
2646         Additionally, the logic for choosing which pretty-printer would
2647         early return before hitting the point where we'd use the UChar*
2648         printer.  (Did this ever work?  How did it regress?)
2649
2650         * gdb/webkit.py:
2651
2652 2011-01-05  Brian Weinstein  <bweinstein@apple.com>
2653
2654         Reviewed by Ada Chan.
2655
2656         WebKit2: Should be able to call into injected bundle to ask if we should allow resource loads
2657         https://bugs.webkit.org/show_bug.cgi?id=51969
2658         
2659         Add shouldLoadResourceForFrame to WTR::InjectedBundlePage.
2660
2661         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2662         (WTR::InjectedBundlePage::InjectedBundlePage):
2663         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Stub implementation.
2664         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2665
2666 2011-01-06  James Robinson  <jamesr@chromium.org>
2667
2668         Reviewed by Simon Fraser.
2669
2670         Implement mozilla's animationTime property
2671         https://bugs.webkit.org/show_bug.cgi?id=51952
2672
2673         Chromium DRT support for webkitAnimationTime.
2674
2675         * DumpRenderTree/chromium/WebViewHost.cpp:
2676         (WebViewHost::paintInvalidatedRegion):
2677
2678 2011-01-06  Julie Parent  <jparent@chromium.org>
2679
2680         Reviewed by Tony Chang.
2681
2682         Test Result Server always truncates number of results to JSON_RESULTS_MAX_BUILDS
2683         https://bugs.webkit.org/show_bug.cgi?id=51217
2684
2685         * TestResultServer/model/jsonresults.py:
2686         Pass num_runs through to _remove_items_over_max_number_of_builds, and use the value.
2687         Adds missing documentation.
2688         * TestResultServer/model/jsonresults_unittest.py:
2689         Add unit test to test that truncation happens at smaller value than JSON_RESULTS_MAX_BUILDS.
2690         Update test_merge to take a number of builds to truncate at.
2691
2692 2011-01-06  Adam Barth  <abarth@webkit.org>
2693
2694         Reviewed by Eric Seidel.
2695
2696         The EWS should log outside of the working directory
2697         https://bugs.webkit.org/show_bug.cgi?id=51986
2698
2699         This patch prepare us for using git clean -x -d -f in the EWS wrapper
2700         script, which will actually clean the working copy back to a pristine
2701         state instead of leaving untracked directories and ignored files.
2702
2703         * Scripts/webkitpy/tool/commands/queues.py:
2704         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2705
2706 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
2707
2708         Windows build fix.
2709         Back out attempted change to built-product-archive.
2710
2711         * BuildSlaveSupport/built-product-archive:
2712
2713 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
2714
2715         Windows build fix.
2716         Include configuration name when unpacking a build archive.
2717
2718         Needed, since we split Windows build results into configuration-specific directories
2719         under WebKitOutputDir.
2720
2721         * BuildSlaveSupport/built-product-archive:
2722
2723 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
2724
2725         Reviewed by Darin Adler.
2726
2727         Debug and Release builds on Windows clobber each other
2728         https://bugs.webkit.org/show_bug.cgi?id=49185
2729
2730         Changes the structure of WebKitBuild build products directory so we
2731         completely separate each build configuration into independent directories.
2732         
2733         Although we previously had per-configuration directories for obj, this change adds
2734         per-configuration directories for bin, lib, obj, and include. Each configuration's
2735         build products are stored within a directory inside of WebKitBuild.
2736         
2737         Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
2738         defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).
2739
2740         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
2741         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd:
2742         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd:
2743         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
2744         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd:
2745         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd:
2746         * DumpRenderTree/win/ImageDiffCommon.vsprops:
2747         * DumpRenderTree/win/ImageDiffPostBuild.cmd:
2748         * DumpRenderTree/win/ImageDiffPreBuild.cmd:
2749         * FindSafari/FindSafari.vcproj:
2750         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
2751         * MiniBrowser/MiniBrowserPostBuild.cmd:
2752         * MiniBrowser/MiniBrowserPreBuild.cmd:
2753         * Scripts/webkitdirs.pm:
2754         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
2755         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops:
2756         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd:
2757         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd:
2758         * TestWebKitAPI/win/copy-resources.cmd:
2759         * WebKitAPITest/WebKitAPITestCommon.vsprops:
2760         * WebKitAPITest/WebKitAPITestPostBuild.cmd:
2761         * WebKitAPITest/WebKitAPITestPreBuild.cmd:
2762         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
2763         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
2764         * WebKitTestRunner/win/InjectedBundle.vcproj:
2765         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops:
2766         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd:
2767         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd:
2768         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd:
2769         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd:
2770         * WinLauncher/WinLauncherCommon.vsprops:
2771         * WinLauncher/WinLauncherPostBuild.cmd:
2772         * WinLauncher/WinLauncherPreBuild.cmd:
2773
2774 2011-01-05  Jan Erik Hanssen  <jhanssen@sencha.com>
2775
2776         Reviewed by Ariya Hidayat.
2777
2778         [Qt] TestNetscapePlugin doesn't link on OS X
2779         https://bugs.webkit.org/show_bug.cgi?id=51948
2780
2781         Only add a dependency on libX11 on X11 systems
2782
2783         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2784
2785 2011-01-05  Jeff Miller  <jeffm@apple.com>
2786
2787         Reviewed by Adam Roben.
2788
2789         check-webkit-style should allow unnecessary parameter names in WebKit2 APIs because we're matching CF's header style
2790         https://bugs.webkit.org/show_bug.cgi?id=51970
2791
2792         * Scripts/webkitpy/style/checker.py:
2793         Add -readability/naming for WebKit2 C API directories.
2794
2795 2011-01-05  Eric Seidel  <eric@webkit.org>
2796
2797         Unreviewed, just fixing one more log error from my previous python patch.
2798
2799         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
2800         https://bugs.webkit.org/show_bug.cgi?id=51802
2801
2802         webkit-patch failure-reason was logging about parsing errors
2803         due to my misunderstanding of how BeautifulSoup.findAll worked.
2804
2805         Fixed, and added a unit test.
2806
2807         * Scripts/webkitpy/common/net/layouttestresults.py:
2808         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2809
2810 2011-01-05  Benjamin Poulain  <benjamin.poulain@nokia.com>
2811
2812         Reviewed by Kenneth Rohde Christiansen.
2813
2814         [Qt] [WK2] Add the possibility to open window from the WebProcess in Minibrowser
2815         https://bugs.webkit.org/show_bug.cgi?id=51951
2816
2817         Set a function to QWKPage::setCreateNewPageFunction() in Minibrowser so there is a way
2818         to create new window from WebKit.
2819
2820         * MiniBrowser/qt/BrowserWindow.cpp:
2821         (newPageFunction):
2822         (BrowserWindow::BrowserWindow):
2823         (BrowserWindow::page): Added to avoid the indirect access to QWKPage spread in the class
2824         (BrowserWindow::newWindow):
2825         (BrowserWindow::updateUserAgentList):
2826         (BrowserWindow::showUserAgentDialog):
2827         * MiniBrowser/qt/BrowserWindow.h: Add the global variable backingStoreTypeForNewWindow to
2828         define the type of the backing store used for new windows.
2829         * MiniBrowser/qt/main.cpp:
2830         (main):
2831
2832 2011-01-05  Eric Seidel  <eric@webkit.org>
2833
2834         Reviewed by Ojan Vafai.
2835
2836         commit-queue should report failure type when reporting flaky tests
2837         https://bugs.webkit.org/show_bug.cgi?id=51900
2838
2839         This patch was a ridiculous amount of plumbing.  In the end I like
2840         the NRWT-style TestResult class even less.  But now we're passing
2841         a list of TestResult objects from the queue to the FlakyTestReporter.
2842         Thus the FlakyTestReporter can more easily report what type of failure
2843         occurred.
2844
2845         In the process, I found that I was not alone in finding TestResult
2846         cumbersome to use.  A bunch of code was trying to create a TestResult
2847         object with default values.  However since the constructor didn't make
2848         this easy, some places were getting it wrong (including the TestResult unit test)!
2849         I've fixed the TestResult constructor to have default values for non-essential
2850         arguments.
2851
2852         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2853         * Scripts/webkitpy/common/net/layouttestresults.py:
2854         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2855         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2856         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2857         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2858         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
2859         * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
2860         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2861         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2862         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2863         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2864         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2865         * Scripts/webkitpy/tool/commands/queues.py:
2866         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2867
2868 2011-01-05  Eric Seidel  <eric@webkit.org>
2869
2870         Unreviewed.
2871
2872         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
2873         https://bugs.webkit.org/show_bug.cgi?id=51802
2874
2875         Add another unit test to cover a previously missing import.
2876
2877         * Scripts/webkitpy/common/net/layouttestresults.py:
2878         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2879
2880 2011-01-05  Mihai Parparita  <mihaip@chromium.org>
2881
2882         Reviewed by David Levin.
2883
2884         Add mihaip@chromium.org as a reviewer
2885         https://bugs.webkit.org/show_bug.cgi?id=51966
2886         
2887         Add myself as a reviewer.
2888
2889         * Scripts/webkitpy/common/config/committers.py:
2890
2891 2011-01-05  James Simonsen  <simonjam@chromium.org>
2892
2893         Unreviewed. Adding myself to the list of committers.
2894
2895         * Scripts/webkitpy/common/config/committers.py:
2896
2897 2011-01-05  Eric Seidel  <eric@webkit.org>
2898
2899         Unreviewed.
2900
2901         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
2902         https://bugs.webkit.org/show_bug.cgi?id=51802
2903
2904         Fix two exceptions seen on the bots after my original commit.
2905
2906         * Scripts/webkitpy/common/net/layouttestresults.py:
2907         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2908
2909 2011-01-05  Kundu Suchismita  <suchi.kundu@nokia.com>
2910
2911         Reviewed by Andreas Kling.
2912
2913         [Qt]Add local storage settings to QtTestBrowser command line arguments 
2914         https://bugs.webkit.org/show_bug.cgi?id=51750
2915
2916         * QtTestBrowser/main.cpp:
2917         (LauncherApplication::handleUserOptions):
2918          Local storage settings can be enable form command line arguments for
2919          QtTestBrowser.
2920
2921 2011-01-05  Chris Fleizach  <cfleizach@apple.com>
2922
2923         Reviewed by Martin Robinson.
2924
2925         GTK: AX: DRT needs to use correct root object method.
2926         https://bugs.webkit.org/show_bug.cgi?id=51911
2927
2928         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
2929         (AccessibilityController::rootElement):
2930
2931 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
2932
2933         Rubber-stamped by Csaba Osztrogonác.
2934
2935         Based on idea from Péter Gál.
2936
2937         * Scripts/webkitpy/tool/bot/sheriff.py: Remove unnecessary apostrophes around revision numbers.
2938
2939 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
2940
2941         Reviewed by Adam Barth.
2942
2943         sheriff-bot should be able to do multi-revision rollouts
2944         https://bugs.webkit.org/show_bug.cgi?id=51176
2945
2946         * Scripts/webkitpy/tool/bot/irc_command.py:
2947         * Scripts/webkitpy/tool/bot/sheriff.py:
2948         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
2949
2950 2011-01-05  Eric Seidel  <eric@webkit.org>
2951
2952         Reviewed by Adam Barth.
2953
2954         queues.webkit.org should have per-bot status pages
2955         https://bugs.webkit.org/show_bug.cgi?id=51906
2956
2957         Just adds a /queue-status/QUEUE_NAME/bots/BOT_ID page to show
2958         statuses from a single queue.  Now that we have many bots servicing
2959         some queues (commit-queue, win-ews, etc.) its easy to have the messages
2960         you care about scroll off the end of the 15-message limit on the main page.
2961
2962         Eventually we should probably rename /queue-status to /queue or /queues,
2963         but that's fodder for another patch.
2964
2965         * QueueStatusServer/handlers/queuestatus.py:
2966         * QueueStatusServer/index.yaml:
2967         * QueueStatusServer/main.py:
2968         * QueueStatusServer/templates/includes/singlequeuestatus.html:
2969          - This probably should use a custom filter instead of hard-coding
2970            the URL scheme here, but I couldn't figure out how to easily
2971            create such a filter.  Most filters work with "strings" so we can't
2972            pass the status object.  We could add a method to the status
2973            object and call that, but that seemed a bit strange too.
2974         * QueueStatusServer/templates/queuestatus.html:
2975
2976 2011-01-05  Carlos Garcia Campos  <cgarcia@igalia.com>
2977
2978         Unreviewed. Adding myself to the list of committers.
2979
2980         * Scripts/webkitpy/common/config/committers.py:
2981
2982 2011-01-04  Koan-Sin Tan  <koansin.tan@gmail.com>
2983
2984         Reviewed by David Levin.
2985
2986         check-webkit-style treated some macros with parentheses after #elif as function calls
2987         https://bugs.webkit.org/show_bug.cgi?id=51695
2988
2989         Ingore function call space checking in any preprocessor directives
2990         (things starting with #). Change search() to match() because 
2991         preprocessor directives are supposed to be in the beginning of lines.
2992
2993         * Scripts/webkitpy/style/checkers/cpp.py:
2994         * Scripts/webkitpy/style/checkers/cpp_unittest.py: make sure there is no false positives for #elif cases
2995
2996 2011-01-04  Søren Gjesse  <sgjesse@chromium.org>
2997
2998         Reviewed by Tony Chang.
2999
3000         Change the --multi-load test option to --stress-opt
3001         https://bugs.webkit.org/show_bug.cgi?id=50751
3002
3003         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3004         (runTest):
3005         (main):
3006         * DumpRenderTree/chromium/TestShell.cpp:
3007         (TestShell::TestShell):
3008         * DumpRenderTree/chromium/TestShell.h:
3009         (TestShell::stressOpt):
3010         (TestShell::setStressOpt):
3011         (TestShell::stressDeopt):
3012         (TestShell::setStressDeopt):
3013         (TestShell::javaScriptFlags):
3014         (TestShell::setJavaScriptFlags):
3015         * Scripts/webkitpy/layout_tests/port/chromium.py:
3016         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3017
3018 2011-01-04  Chris Fleizach  <cfleizach@apple.com>
3019
3020         Reviewed by Sam Weinig.
3021
3022         WK2: Support Accessibility
3023         https://bugs.webkit.org/show_bug.cgi?id=51859
3024
3025         Use rootObject() method to get top of accessibility tree.
3026
3027         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
3028         (AccessibilityController::focusedElement):
3029         (AccessibilityController::rootElement):
3030
3031 2011-01-03  Martin Robinson  <mrobinson@igalia.com>
3032
3033         Reviewed by Darin Adler.
3034
3035         Remove the last non-GObject usage of PlatformRefPtr and move the code to GRefPtr
3036         https://bugs.webkit.org/show_bug.cgi?id=51846
3037
3038         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Change usage of PlatformRefPtr
3039         back to GRefPtr.
3040
3041 2011-01-04  Zhe Su  <suzhe@chromium.org>
3042
3043         Reviewed by Kenneth Russell.
3044
3045         Fix insertText, setMarkedText and unmarkText methods of
3046         TextInputController to call corresponding methods of WebKit::WebView
3047         rather than WebKit::WebFrame. This change matches the behavior of
3048         chromium browser.
3049         insertText corresponds to WebView::confirmComposition(text)
3050         setMarkedText corresponds to WebView::setComposition(...)
3051         unmarkText corresponds to WebView::confirmComposition()
3052         https://bugs.webkit.org/show_bug.cgi?id=51693
3053
3054         * DumpRenderTree/chromium/TextInputController.cpp:
3055         (TextInputController::insertText):
3056         (TextInputController::setMarkedText):
3057         (TextInputController::unmarkText):
3058
3059 2011-01-04  Dihan Wickremasuriya  <dihan.wickremasuriya@nokia.com>
3060
3061         Reviewed by Laszlo Gombos.
3062
3063         [Qt] [Symbian] Do not remove 0 byte sized files from productDir
3064
3065         On Symbian productDir points to the source directory. Removing all the
3066         empty files from the productDir directory corrupts the svn repository.
3067
3068         * Scripts/build-webkit:
3069
3070 2011-01-03  Yi Shen  <yi.4.shen@nokia.com>
3071
3072         Reviewed by Adam Barth.
3073
3074         [Qt] Add SelectAll option to the context menu for the editor
3075         https://bugs.webkit.org/show_bug.cgi?id=50049
3076
3077         Set shortcut for the SelectAll action.
3078
3079         * QtTestBrowser/mainwindow.cpp:
3080         (MainWindow::buildUI):
3081
3082 2011-01-03  David Levin  <levin@chromium.org>
3083
3084         Reviewed by Eric Seidel.
3085
3086         check-webkit-style shouldn't consider "value" automatically to be a meaningless name.
3087         https://bugs.webkit.org/show_bug.cgi?id=51842
3088
3089         * Scripts/webkitpy/style/checkers/cpp.py: Remove the check for value.
3090         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Remove the test for value.
3091
3092 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
3093
3094         Reviewed by David Kilzer.
3095
3096         [WINCE] Adds a build slave.
3097         https://bugs.webkit.org/show_bug.cgi?id=50523
3098
3099         * BuildSlaveSupport/build.webkit.org-config/config.json: Add an
3100         entry for a release build of the WinCE port.
3101         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add platform
3102         flag to build the WinCE port.
3103
3104 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
3105
3106         Reviewed by David Kilzer.
3107
3108         Add WinCE support to build-webkit
3109         https://bugs.webkit.org/show_bug.cgi?id=51642
3110
3111         * Scripts/build-webkit:
3112         * Scripts/webkitdirs.pm:
3113
3114 2011-01-03  Eric Seidel  <eric@webkit.org>
3115
3116         Reviewed by Adam Barth.
3117
3118         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
3119         https://bugs.webkit.org/show_bug.cgi?id=51802
3120
3121         I'm not the biggest fan of the test_failures or test_results classes,
3122         but it's better to have one shared set of classes, than separate ones
3123         for new vs. old run-webkit-test result handling.
3124
3125         This moves the ORWT results class "LayoutTestResults" over to using
3126         TestResult and TestFailure classes, making it easy for us to
3127         make all our sheriff-bot and other webkitpy code NRWT ready.
3128
3129         This also makes it a trivial patch to generate results.json information
3130         from ORWT results.html files (for flaky test analysis, etc.) as well
3131         as making it a one-liner to report test failure types when the
3132         commit-queue sees flaky tests.
3133
3134         This patch tried not to add new functionality, but only to replace
3135         the guts of LayoutTestResults, while adding unit tests and hoping
3136         not to break anything.
3137
3138         I also moved callers which assumed User.prompt* were static/class methods
3139         to using them as instance methods (since we'll eventually want to make them such).
3140
3141         In the process of re-writing things, I broke the rebaseline command, so I wrote
3142         a unit test to catch my breakage were I do do so again in the future.
3143
3144         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3145         * Scripts/webkitpy/common/net/layouttestresults.py:
3146         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3147         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
3148         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
3149         * Scripts/webkitpy/tool/commands/queries.py:
3150         * Scripts/webkitpy/tool/commands/rebaseline.py:
3151         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3152         * Scripts/webkitpy/tool/mocktool.py:
3153
3154 2011-01-03  Adam Barth  <abarth@webkit.org>
3155
3156         Reviewed by Simon Fraser.
3157
3158         webkit-patch shouldn't waste time cleaning a working directory that's already clean
3159         https://bugs.webkit.org/show_bug.cgi?id=51840
3160
3161         * Scripts/webkitpy/common/checkout/scm.py:
3162
3163 2011-01-03  Adam Barth  <abarth@webkit.org>
3164
3165         Reviewed by Simon Fraser.
3166
3167         webkit-patch should only hide update output if --quiet
3168         https://bugs.webkit.org/show_bug.cgi?id=51838
3169
3170         As requested by smfr.
3171
3172         * Scripts/webkitpy/tool/steps/update.py:
3173
3174 2011-01-03  Adam Barth  <abarth@webkit.org>
3175
3176         Reviewed by David Levin.
3177
3178         commit-queue shouldn't reject patches twice if two bots process the same patch
3179         https://bugs.webkit.org/show_bug.cgi?id=51805
3180
3181         Before raising an error, we first check whether the patch is still in
3182         the commit-queue.  This check is still racy, of course, but the time
3183         window is much smaller.
3184
3185         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3186
3187 2011-01-03  Sam Weinig  <sam@webkit.org>
3188
3189         Reviewed by Anders Carlsson.
3190
3191         Make run-api-tests less chatty.
3192         https://bugs.webkit.org/show_bug.cgi?id=51831
3193
3194         - Make script quiet by default and add --verbose option (replacing --quiet).
3195         - When not verbose, pipe stdout and stderr to devnull.
3196
3197         * Scripts/run-api-tests:
3198
3199 2011-01-03  Pratik Solanki  <psolanki@apple.com>
3200
3201         Unreviewed. Adding myself to committers.py.
3202
3203         * Scripts/webkitpy/common/config/committers.py:
3204
3205 2011-01-03  Koan-Sin Tan  <koansin.tan@gmail.com>
3206
3207         Reviewed by Xan Lopez.
3208
3209         "Tool/Scripts/run-launcher --gtk" stopped working after 74855
3210         https://bugs.webkit.org/show_bug.cgi?id=51806
3211
3212         Originally, the $libraryName is 'JavaScriptCore'. When building release 
3213         one, the $libraryDir was 'WebKitBuild/Release/JavaScriptCore/../.libs/'
3214         which doesn't exist anymore ('WebKitBuild/Release/JavaScriptCore'
3215         is 'WebKitBuild/Release/Source/JavaScriptCore' now), and 
3216         'WebKitBuild/Release/Source/JavaScriptCore/../../.libs' looks weird,
3217         so make it 'WebKitBuild/Release/.libs'
3218
3219         * Scripts/webkitdirs.pm: 
3220
3221 2011-01-02  Patrick Gansterer  <paroga@webkit.org>
3222
3223         Reviewed by Adam Barth.
3224
3225         Make EFL a core builder
3226         https://bugs.webkit.org/show_bug.cgi?id=51804
3227
3228         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
3229         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3230
3231 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
3232
3233         [Qt] Unreviewed fix after r74855 and r74875.
3234
3235         * BuildSlaveSupport/built-product-archive:
3236          - Create directories explicitly.
3237          - Pass shell=True to subprocess.call().
3238
3239 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
3240
3241         [Qt] Unreviewed fix after r74855.
3242
3243         Move JavaScriptCore to Source
3244         https://bugs.webkit.org/show_bug.cgi?id=51604
3245
3246         * BuildSlaveSupport/built-product-archive: JavaScriptCore -> Source/JavaScriptCore
3247
3248 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
3249
3250         [Qt] Unreviewed run-javasriptcore-tests fix after r74855.
3251
3252         Move JavaScriptCore to Source
3253         https://bugs.webkit.org/show_bug.cgi?id=51604
3254
3255         * Scripts/webkitdirs.pm:
3256
3257 2011-01-02  Robert Hogan  <robert@webkit.org>
3258
3259         Unreviewed, build fix.
3260
3261         [Qt] Fix DRT build after 74855
3262
3263         * DumpRenderTree/qt/DumpRenderTree.pro:
3264
3265 2011-01-01  Adam Barth  <abarth@webkit.org>
3266
3267         Remove the assumption from the Qt and Gtk builds that every project is
3268         in the root directory.
3269
3270         * Scripts/build-webkit:
3271
3272 2011-01-01  Adam Barth  <abarth@webkit.org>
3273
3274         Reviewed by Eric Seidel.
3275
3276         Teach svn-apply how to apply patches even though JavaScriptCore has moved
3277         https://bugs.webkit.org/show_bug.cgi?id=51796
3278
3279         After this change, svn-apply will magically apply patches to
3280         JavaScriptCore/foo to Source/JavaScriptCore/foo.
3281
3282         * Scripts/VCSUtils.pm:
3283
3284 2011-01-01  Adam Barth  <abarth@webkit.org>
3285
3286         Reviewed by Eric Seidel.
3287
3288         Move JavaScriptCore to Source
3289         https://bugs.webkit.org/show_bug.cgi?id=51604
3290
3291         Update references to JavaScriptCore to point to the new location.
3292
3293         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3294         * DumpRenderTree/qt/DumpRenderTree.pro:
3295         * DumpRenderTree/qt/ImageDiff.pro:
3296         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3297         * DumpRenderTree/wscript:
3298         * Scripts/build-jsc:
3299         * Scripts/build-webkit:
3300         * Scripts/do-file-rename:
3301         * Scripts/do-webcore-rename:
3302         * Scripts/run-javascriptcore-tests:
3303         * Scripts/update-javascriptcore-test-results:
3304         * Scripts/webkitdirs.pm:
3305         * Scripts/webkitpy/common/config/build_unittest.py:
3306         * Scripts/webkitpy/style/checker.py:
3307         * Scripts/webkitpy/style/checker_unittest.py:
3308         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3309         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3310         * WebKitTestRunner/qt/WebKitTestRunner.pro:
3311         * wx/build/settings.py:
3312
3313 2011-01-01  Adam Barth  <abarth@webkit.org>
3314
3315         Reviewed by Eric Seidel.
3316
3317         Move Sources to Source
3318         https://bugs.webkit.org/show_bug.cgi?id=51794
3319
3320         Update scripts to point to the new location.
3321
3322         * Scripts/build-webkit:
3323         * Scripts/do-file-rename:
3324         * Scripts/do-webcore-rename:
3325         * Scripts/webkitpy/common/config/build.py:
3326         * Scripts/webkitpy/common/config/build_unittest.py:
3327
3328 2010-12-31  Kent Tamura  <tkent@chromium.org>
3329
3330         Reviewed by Eric Seidel.
3331
3332         [DRT/Chromium] Enable mock spell checker on non-OSX
3333         https://bugs.webkit.org/show_bug.cgi?id=51401
3334
3335         * DumpRenderTree/chromium/WebViewHost.cpp:
3336         (WebViewHost::spellCheck):
3337
3338 2010-12-31  Adam Barth  <abarth@webkit.org>
3339
3340         Reviewed by Ariya Hidayat.
3341
3342         Remove Tools/Scripts/wkstyle
3343         https://bugs.webkit.org/show_bug.cgi?id=51774
3344
3345         This script appears to not have been touched in a while and seems to
3346         have been replaced by check-webkit-style.
3347
3348         * Scripts/wkstyle: Removed.
3349
3350 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
3351
3352         Unreviewed. Coding style fix.
3353
3354         * DumpRenderTree/chromium/TestShell.h:
3355
3356 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
3357
3358         Reviewed by Pavel Feldman.
3359
3360         Web Inspector: [Chromium] Inspector's tests are very slow on Win(Dbg).
3361
3362         It was a problem with Chromium DRT. DevToolsAgent object instance was
3363         attached not only to the inspected page but to the DevTools window too.
3364         As result all the inspector files were interpreted as a content of inspected page
3365         and were transfered to the DevTools scripts panel for debugging etc.
3366
3367         https://bugs.webkit.org/show_bug.cgi?id=51735
3368
3369         * DumpRenderTree/chromium/TestShell.cpp:
3370         (TestShell::TestShell):
3371         (TestShell::bindJSObjectsToWindow):
3372         (TestShell::createNewWindow):
3373         * DumpRenderTree/chromium/TestShell.h:
3374
3375 2010-12-31  Adam Barth  <abarth@webkit.org>
3376
3377         Rubber-stamped by Eric Seidel.
3378
3379         Move PageLoadTests to PerformanceTests/PageLoad
3380         https://bugs.webkit.org/show_bug.cgi?id=51771
3381
3382         Update references to PageLoadTests to point to the new location.
3383
3384         * Scripts/run-pageloadtest:
3385         * Scripts/webkitpy/common/config/build.py:
3386
3387 2010-12-31  Adam Barth  <abarth@webkit.org>
3388
3389         Rubber-stamped by Eric Seidel.
3390
3391         Move SunSpider into PerformanceTests
3392         https://bugs.webkit.org/show_bug.cgi?id=51769
3393
3394         Update these scripts to point to the new location.
3395
3396         * Scripts/run-sunspider:
3397         * Scripts/sunspider-compare-results:
3398
3399 2010-12-30  Mihai Parparita  <mihaip@chromium.org>
3400
3401         Reviewed by Kent Tamura.
3402
3403         [Chromium] Add WebThemeEngineDRTMac so that Chromium DRT scrollbar rendering can match the Mac port's
3404         https://bugs.webkit.org/show_bug.cgi?id=51728
3405         
3406         Add implementation of the Mac WebThemeEngine that uses an NSScroller
3407         to render top-level scrollbars. This makes them match the Mac port's
3408         use of an NSScrollView, which means that we'll be able to share more
3409         pixel baselines.
3410         
3411         The new rendering code will not be activated until the 
3412         USE_WEB_THEME_ENGINE_TO_PAINT_THUMB #define is fliped in
3413         ScrollbarThemeChromiumMac.
3414
3415         * DumpRenderTree/DumpRenderTree.gypi:
3416         * DumpRenderTree/chromium/TestShellMac.mm:
3417         (platformInit):
3418         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Added.
3419         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Added.
3420         (+[FakeActiveWindow alwaysActiveWindow]):
3421         (+[FakeActiveWindow alwaysInactiveWindow]):
3422         (-[FakeActiveWindow initWithActiveControls:]):
3423         (-[FakeActiveWindow _hasActiveControls]):
3424         (WebThemeEngineDRTMac::paintScrollbarThumb):
3425         (stateToHIEnableState):
3426         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
3427         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
3428
3429 2010-12-30  Konstantin Tokarev  <annulen@yandex.ru>
3430
3431         Reviewed by David Kilzer.
3432
3433         [Qt] Don't build wtf/TCSystemAlloc.cpp if --system-malloc option is
3434         used
3435         https://bugs.webkit.org/show_bug.cgi?id=51672
3436
3437         * DumpRenderTree/qt/DumpRenderTree.pro: Replaced USE_SYSTEM_MALLOC
3438         with USE_SYSTEM_MALLOC=1
3439         * WebKitTestRunner/qt/WebKitTestRunner.pro: Replaced USE_SYSTEM_MALLOC
3440         with USE_SYSTEM_MALLOC=1
3441
3442 2010-12-30  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3443
3444         Reviewed by David Kilzer.
3445
3446         [Qt] [Symbian] Fix build-webkit script for Symbian
3447         https://bugs.webkit.org/show_bug.cgi?id=51509
3448
3449         Set the OUTPUT_DIR for Symbian to be the same as the source
3450         directory.
3451
3452         * Scripts/webkitdirs.pm:
3453
3454 2010-12-30  Martin Robinson  <mrobinson@igalia.com>
3455
3456         Reviewed by Darin Adler.
3457
3458         check-webkit-style should ignore NULL usage in calls to gtk_widget_style_get
3459         https://bugs.webkit.org/show_bug.cgi?id=51758
3460
3461         Add a check-webkit-style exception for gtk_widget_style_get and NULL usage.
3462
3463         * Scripts/webkitpy/style/checkers/cpp.py: Add the exception.
3464         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add some tests for this.
3465
3466 2010-12-29  Patrick Gansterer  <paroga@webkit.org>
3467
3468         Unreviewed WinCE buildfix.
3469
3470         * WinCELauncher/main.cpp: Add missing include.
3471
3472 2010-12-29  Daniel Bates  <dbates@rim.com>
3473
3474         Reviewed by Darin Adler.
3475
3476         svn-apply updates date of wrong change log entry for a change log diff that
3477         contains two consecutive entries with the same author and date
3478         https://bugs.webkit.org/show_bug.cgi?id=46061
3479
3480         Fixes an issue where the date of the wrong change log entry may be modified.
3481         Moreover, changes fixChangeLogPatch() to move entries inserted earlier
3482         in a ChangeLog file to the top of the file.
3483
3484         Currently, fixChangeLogPatch() explicitly bails out and returns an unchanged
3485         diff when it detects that the diff inserts a change log entry earlier in a
3486         ChangeLog. It is unusual to land a patch that has such a deliberate ChangeLog
3487         change. With the advent of the commit-queue this functionality of bailing out
3488         and hence landing the patch as-is is harmful to the accuracy of the ChangeLog.
3489         Instead, we should always move the change log entry to the top of the ChangeLog file.
3490
3491         A side-effect of this change is that setChangeLogDateAndReviewer() now updates
3492         the date line of the correct change log entry in a ChangeLog diff.
3493
3494         * Scripts/VCSUtils.pm: Modified fixChangeLogPatch() to move entries inserted earlier to the top.
3495
3496         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
3497           Updated the following unit tests now that we move entries inserted earlier to the top:
3498           - "fixChangeLogPatch: New entry inserted in middle."
3499             (formerly named "fixChangeLogPatch: [no change] New entry inserted in middle.")
3500
3501           - "fixChangeLogPatch: New entry inserted earlier in the file, but after an entry with the same author and date."
3502             (formerly named "fixChangeLogPatch: [no change] New entry inserted earlier in the file, but after an entry with the same author and date.")
3503
3504         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatchThenSetChangeLogDateAndReviewer.pl: Added.
3505
3506 2010-12-29  Konstantin Tokarev  <annulen@yandex.ru>
3507
3508         Reviewed by Eric Seidel.
3509
3510         [Qt] Fixed compatibility with gold linker on X11 platforms
3511         https://bugs.webkit.org/show_bug.cgi?id=51700
3512
3513         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3514         Linked TestNetscapePlugin with libX11 on Unix platforms
3515
3516 2010-12-29  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
3517
3518         Reviewed by Darin Adler.
3519
3520         Circular dependency in webkitpy.common.checkout.changelog module
3521         https://bugs.webkit.org/show_bug.cgi?id=50475
3522
3523         Remove automatic import of api.Checkout module when any checkout/
3524         submodule is imported (e.g.: when checkout.scm.Git is imported).
3525
3526         * Scripts/webkitpy/common/checkout/__init__.py:
3527
3528 2010-12-29  Martin Robinson  <mrobinson@igalia.com>
3529
3530         Reviewed by Ojan Vafai.
3531
3532         prepare-ChangeLog should support the -g option for specifying the git-commit
3533         https://bugs.webkit.org/show_bug.cgi?id=51708
3534
3535         Add a -g shortcut for the --git-commit prepare-ChangeLog option. This matches
3536         webkit-patch, though the exact meaning of the two options remain different.
3537
3538         * Scripts/prepare-ChangeLog: Add -g.
3539
3540 2010-12-29  Kent Hansen  <kent.hansen@nokia.com>
3541
3542         Reviewed by Simon Hausmann.
3543
3544         [Qt] Fix compilation with Qt in namespace
3545         https://bugs.webkit.org/show_bug.cgi?id=51701
3546
3547         * QtTestBrowser/webview.h:
3548
3549 2010-12-28  Daniel Bates  <dbates@rim.com>
3550
3551         Reviewed by Sam Weinig.
3552
3553         Substitute // MARK: for compiler-specific #pragma mark
3554         https://bugs.webkit.org/show_bug.cgi?id=51657
3555
3556         Fix future compilation warnings about "#pragma mark" on GTK+ bots by
3557         substituting  "// MARK:" for "#pragma mark", which provides
3558         analogous code-bookmarking functionality under Xcode.
3559
3560         Also, for consistency, we should substitute "// MARK:" for compiler-
3561         specific "#pragma mark" in the source files for the Mac port.
3562
3563         * DumpRenderTree/AccessibilityTextMarker.cpp:
3564         * DumpRenderTree/cf/WebArchiveDumpSupport.h:
3565         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
3566         * DumpRenderTree/mac/ObjCController.m:
3567         * MiniBrowser/mac/AppDelegate.m:
3568         * MiniBrowser/mac/BrowserWindowController.m:
3569
3570 2010-12-28  Xan Lopez  <xlopez@igalia.com>
3571
3572         Reviewed by Eric Seidel.
3573
3574         Add --no-build option to run-sunspider
3575         https://bugs.webkit.org/show_bug.cgi?id=51658
3576
3577         * Scripts/run-sunspider: add --no-build flag to skip building
3578         phase.
3579
3580 2010-12-27  Daniel Bates  <dbates@rim.com>
3581
3582         Rubber-stamped by Martin Robinson.
3583
3584         Append the directory Tools/DumpRenderTree to the list of directories that
3585         do-webcore-rename should search so that it can rename DRT files and
3586         source code.
3587
3588         * Scripts/do-webcore-rename:
3589
3590 2010-12-27  Eric Seidel  <eric@webkit.org>
3591
3592         Reviewed by Adam Barth.
3593
3594         build-webkit should detect missing Java SDK and explain how to install it
3595         https://bugs.webkit.org/show_bug.cgi?id=51651
3596
3597         * Scripts/build-webkit:
3598
3599 2010-12-26  Martin Robinson  <mrobinson@igalia.com>
3600
3601         Reviewed by Daniel Bates.
3602
3603         [GTK] Add support for build-jsc
3604         https://bugs.webkit.org/show_bug.cgi?id=51625
3605
3606         Add GTK+ support to build-jsc now that building the jsc executable as
3607         a standalone target is easy.
3608
3609         * Scripts/build-jsc: Call buildGtkProject for the GTK+ case now.
3610         * Scripts/build-webkit: Pass in the proper target name to buildGtkProject.
3611         * Scripts/webkitdirs.pm: Actually process the project parameter in buildGtkProject
3612         and pass it along to buildAutotoolsProject.
3613
3614 2010-12-27  David Levin  <levin@chromium.org>
3615
3616         Reviewed by Eric Seidel.
3617
3618         check-webkit-style check for meaningless variable names in function declarations.
3619         https://bugs.webkit.org/show_bug.cgi?id=51523
3620
3621         * Scripts/webkitpy/style/checker.py: Exempted JavaScriptCore/jit/JITStubs.cpp
3622         from the new check and whitespace/parens because the syntax is unusual and
3623         produced a fair number of positives for these checks.
3624         * Scripts/webkitpy/style/checkers/cpp.py:
3625         (_convert_to_lower_with_underscores): Used as a canonical form for type names
3626         and parameter names when determining if the parameter name is useless.
3627         (_create_acronym): Used to check for redundant variable names in cases like "ExceptionCode ec"
3628         (Parameter.lower_with_underscores_name): Gives back the parameter name in a lower_with_underscore
3629         format.
3630         (_check_parameter_name_against_text):  Checks to see if the parameter name is in the
3631         text or an acronym of it.
3632         (check_function_definition): Checks function definitions for meaningless variable names.
3633         (process_line): Added call to check_function_definition.
3634         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3635         (CppFunctionsTest.test_convert_to_lower_with_underscores): Test for _convert_to_lower_with_underscores.
3636         (CppFunctionsTest.test_create_acronym): Test for _create_acronym.
3637         (CppFunctionsTest.test_check_parameter_against_text): Test for _check_parameter_against_text.
3638         (CppStyleTestBase.perform_single_line_lint): Removed the parameter name check
3639         because when only checking a snippet, there are a lot of bogus functions.
3640         (CppStyleTestBase.perform_multi_line_lint): Ditto and removed a bogus filter
3641         that I put there previously and just noticed.
3642         (WebKitStyleTest.test_parameter_names): Tests for the functionality -- both
3643         check_function_definition and process_line.
3644
3645 2010-12-27  Carlos Garcia Campos  <cgarcia@igalia.com>
3646
3647         Reviewed by Martin Robinson.
3648
3649         [GTK] Disable flash plugin in GtkLauncher when using gtk3
3650         https://bugs.webkit.org/show_bug.cgi?id=51591
3651
3652         Flash plugin uses gtk2 that is incompatible with gtk3 making
3653         webkit crash when it's built with gtk3.
3654
3655         * GtkLauncher/main.c:
3656         (main):
3657
3658 2010-12-25  Adam Barth  <abarth@webkit.org>
3659
3660         Reviewed by Eric Seidel.
3661
3662         Move ANGLE to Sources/ThirdParty
3663         https://bugs.webkit.org/show_bug.cgi?id=51605
3664
3665         * Scripts/build-webkit:
3666           - Point to the new ANGLE location.
3667
3668 2010-12-26  David Levin  <levin@chromium.org>
3669
3670         Reviewed by Eric Seidel.
3671
3672         check-webkit-style should be able to parse function declaration parameters.
3673         https://bugs.webkit.org/show_bug.cgi?id=51451
3674
3675         * Scripts/webkitpy/style/checkers/cpp.py:
3676         (Position.__init__): Holds simple position information (row, column).
3677         (Parameter.__init__): Holds information about a parameter.
3678         (SingleLineView.__init): Converts multiple lines into a single line for simpler searches.
3679         (SingleLineView.convert_column_to_row): Returns the original row given a column.
3680         (create_skeleton_parameters): Simplifies a parameter list for easier searching.
3681         (find_parameter_name_index): Finds where the parameter name is.
3682         (parameter_list): Generates the list of parameters for a function.
3683         (_FunctionState.begin): Added information to allow determining the parameters
3684         on demand.
3685         (_FunctionState.get_parameter_list): Returns a tuple of function parameters.
3686         (detect_functions): Improve function detection for operator functions and
3687         determine where the parameters end and pass that to _FunctionState.begin.
3688         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3689         (CppFunctionsTest.test_parameter): Verifies Parameter functionality.
3690         (CppFunctionsTest.test_single_line_view): Verifies SingleLineView functionality.
3691         (CppFunctionsTest.test_create_skeleton_parameters): Verifies create_skeleton_parameters.
3692         (CppFunctionsTest.test_find_parameter_name_index): Verifies find_parameter_name_index.
3693         (CppFunctionsTest.test_parameter_list): Does some minimal verification for parameter list.
3694         Much more thorough verification is done as part of FunctionDetectionTest.test_parameter_list.
3695         (FunctionDetectionTest.perform_function_detection): Added support for verifying
3696         the parameters found.
3697         (FunctionDetectionTest.test_function_declaration_detection): Added more function
3698         detection test to verify that we catch the operator functions.
3699         (FunctionDetectionTest.test_ignore_macros): Verify that function detection ignores macros.
3700         (FunctionDetectionTest.test_parameter_list): Added tests to verify the parameter parsing.
3701         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_bad_test_doesnt_break): Removed
3702         because the error. The test is about the bad function name. Fixing the name makes the test exactly like
3703         test_function_length_check_definition_severity1_for_test.
3704
3705 2010-12-25  Patrick Gansterer  <paroga@webkit.org>
3706
3707         Unreviewed WinCE buildfix after r74334.
3708
3709         * CMakeListsWinCE.txt:
3710
3711 2010-12-24  Sheriff Bot  <webkit.review.bot@gmail.com>
3712
3713         Unreviewed, rolling out r74632.
3714         http://trac.webkit.org/changeset/74632
3715         https://bugs.webkit.org/show_bug.cgi?id=51600
3716
3717         makes test-webkitpy hang forever on GTK (Requested by philn-tp
3718         on #webkit).
3719
3720         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
3721         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
3722
3723 2010-12-24  Ryuan Choi  <ryuan.choi@samsung.com>
3724
3725         Reviewed by Kenneth Rohde Christiansen.
3726
3727         [EFL] Screen doesn't be rendered when changing size of EWebLauncher
3728         https://bugs.webkit.org/show_bug.cgi?id=43528
3729
3730         Remove on_resize because ewk_view_fixed_layout_size_set should not be
3731         called on callback of EVAS_CALLBACK_RESIZE. As it change size of
3732         FrameView, rendering was ignored when _ewk_view_smart_calculate was
3733         called.
3734
3735         * EWebLauncher/main.c:
3736         (browserCreate):
3737
3738 2010-12-24  Eric Seidel  <eric@webkit.org>
3739
3740         Reviewed by Adam Barth.
3741
3742         webkit-patch (or a pre-commit hook) needs to prevent bad ChangeLog changes
3743         https://bugs.webkit.org/show_bug.cgi?id=28291
3744
3745         This is a start.  At least now webkit-patch will prompt when your ChangeLog looks questionable.
3746         We could do more advanced things, like parsing the ChangeLog (with changelog.py) and comparing that
3747         to strings with find in the diff.
3748         Since non-interactive always returns the default, this should cause patches with bad changelogs to fail on the commit-queue.
3749
3750         * Scripts/webkitpy/common/checkout/api.py:
3751         * Scripts/webkitpy/common/checkout/diff_parser.py:
3752         * Scripts/webkitpy/tool/steps/abstractstep.py:
3753         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
3754         * Scripts/webkitpy/tool/steps/validatechangelogs.py: Copied from Tools/Scripts/webkitpy/tool/steps/validatereviewer.py.
3755         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
3756         * Scripts/webkitpy/tool/steps/validatereviewer.py:
3757
3758 2010-12-24  Dirk Pranke  <dpranke@chromium.org>
3759
3760         Reviewed by Kenneth Russell.
3761
3762         Modify new-run-webkit-tests to shut up and exit when all the threads
3763         are wedged so that test runs complete faster and we don't end up
3764         w/ enormous log files.
3765
3766         https://bugs.webkit.org/show_bug.cgi?id=51572
3767
3768         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
3769         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
3770
3771 2010-12-24  Eric Seidel  <eric@webkit.org>
3772
3773         Reviewed by David Levin.
3774
3775         commit-queue should better explain how it will re-open bugs and follow duplicate chains
3776         https://bugs.webkit.org/show_bug.cgi?id=51549
3777
3778         I've had multiple people ask me about the commit-queue's behavior
3779         regarding reporting flaky tests.  I figured it would be best to just
3780         have the queue explain itself in the bugs it files.
3781
3782         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3783         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3784
3785 2010-12-24  Shinichiro Hamaji  <hamaji@chromium.org>
3786
3787         Reviewed by Eric Seidel.
3788
3789         check-webkit-style: should ignore "wrong" namings in JavaScriptCore/qt
3790         https://bugs.webkit.org/show_bug.cgi?id=51467
3791
3792         * Scripts/webkitpy/style/checker.py:
3793         * Scripts/webkitpy/style/checker_unittest.py:
3794
3795 2010-12-23  Adam Barth  <abarth@webkit.org>
3796
3797         Rubber-stamped by Eric Seidel.
3798
3799         Move JavaScriptGlue into Sources
3800         https://bugs.webkit.org/show_bug.cgi?id=51583
3801
3802         These tools refer to JavaScriptGlue and need to be updated to its new
3803         location.
3804
3805         * Scripts/build-webkit:
3806         * Scripts/do-file-rename:
3807         * Scripts/do-webcore-rename:
3808         * Scripts/webkitpy/common/config/build.py:
3809         * Scripts/webkitpy/common/config/build_unittest.py:
3810
3811 2010-12-23  Lucas Forschler  <lforschler@apple.com>
3812
3813         Reviewed by Eric Seidel.
3814
3815         Bug 51539 - update iexploder scripts to point to new location
3816
3817         * Scripts/run-iexploder-tests:
3818         * Scripts/update-iexploder-cssproperties:
3819
3820 2010-12-23  Evan Martin  <evan@chromium.org>
3821
3822         Reviewed by Ryosuke Niwa.
3823
3824         [chromium] LayoutTestController warning in float->int conversion
3825         https://bugs.webkit.org/show_bug.cgi?id=51553
3826
3827         Rather than reading an int, converting to a float, then getting a compiler
3828         warning on passing the float to something that expects an int, instead
3829         just pass around ints.
3830
3831         No tests, fixes a compiler warning.
3832
3833         * DumpRenderTree/chromium/LayoutTestController.cpp:
3834         (parsePageSizeParameters):
3835         (LayoutTestController::pageNumberForElementById):
3836         (LayoutTestController::numberOfPages):
3837
3838 2010-12-23  Lucas Forschler  <lforschler@apple.com>
3839
3840         Reviewed by Darin Adler.
3841
3842         Bug 51537 - iexploder needs cleanup
3843         
3844         * iExploder/htdocs: Removed.
3845         * iExploder/htdocs/config.rb: Removed.
3846         * iExploder/htdocs/cssproperties.in: Removed.
3847         * iExploder/htdocs/cssvalues.in: Removed.
3848         * iExploder/htdocs/htmlattrs.in: Removed.
3849         * iExploder/htdocs/htmltags.in: Removed.
3850         * iExploder/htdocs/htmlvalues.in: Removed.
3851         * iExploder/htdocs/iexploder.cgi: Removed.
3852         * iExploder/htdocs/iexploder.rb: Removed.
3853         * iExploder/htdocs/index.html: Removed.
3854         * iExploder/htdocs/webserver.rb: Removed.
3855         * iExploder/iexploder-1.7.2/output: Removed.
3856         * iExploder/tools: Removed.
3857         * iExploder/tools/lasthit.rb: Removed.
3858         * iExploder/tools/osx_last_crash.rb: Removed.
3859         * iExploder/tools/showtest.rb: Removed.
3860
3861 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
3862
3863         Reviewed by Kenneth Rohde Christiansen.
3864
3865         [EFL] Make 'single' the default backing store in EWebLauncher
3866         https://bugs.webkit.org/show_bug.cgi?id=51534
3867
3868         'single' is the simplest backing store and the one intended to be the
3869         default in the test browser. By mistake the tiled backing store was
3870         left as default in r72617.
3871
3872         * EWebLauncher/main.c:
3873         (browserCreate): ditto.
3874
3875 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
3876
3877         Reviewed by Kenneth Rohde Christiansen.
3878
3879         [EFL] Subject: [webkit 4/4] [EFL] Remove non-sense workaround
3880         https://bugs.webkit.org/show_bug.cgi?id=51533
3881
3882         There's no point in concatenating env("HOME") with "blah", so remove
3883         option from EWebLauncher.
3884
3885         * EWebLauncher/main.c:
3886         (main): ditto.
3887
3888 2010-12-23  Ilya Tikhonovsky  <loislo@chromium.org>
3889
3890         Reviewed by Eric Seidel.
3891
3892         Web Inspector: chromium: inspector's tests are quite slow especially at windows(Debug).
3893
3894         Almost all inspector's tests become flaky on chromium Win(dbg) after switching to DRT.
3895         I just discovered that we have two additional GC runs per each WebViewHost.
3896         Test_shell had no such calls.
3897         These gc runs eat 15% of cpu time.
3898
3899         https://bugs.webkit.org/show_bug.cgi?id=51479
3900
3901         * DumpRenderTree/chromium/WebViewHost.cpp:
3902         (WebViewHost::~WebViewHost):
3903
3904 2010-12-22  Dirk Pranke  <dpranke@chromium.org>
3905
3906         Reviewed by Ojan Vafai.
3907
3908         This change splits out the TestRunner class into its own file.
3909         When we fork the code for message passing, we will create a new
3910         TestRunner, and this change will allow that to be more modular.
3911
3912         While we're at it, split out TestInput and ResultSummary into
3913         their own files, to reduce the size of run_webkit_tests to
3914         something more managable.
3915
3916         https://bugs.webkit.org/show_bug.cgi?id=51092
3917
3918         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3919         * Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
3920         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3921         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
3922         * Scripts/webkitpy/layout_tests/layout_package/test_input.py:
3923         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3924         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3925
3926  2010-12-22  Dirk Pranke  <dpranke@chromium.org>
3927
3928         Reviewed by Ojan Vafai.
3929
3930         nrwt multiprocessing - start over, prepare to fork the code
3931  
3932         This code cleans up the signatures and implementation of the
3933         TestRunner class so we can easily fork it to run either the
3934         stable implementation or the new, unstable message-passing
3935         implementation. The two variants will have different
3936         implementations of the run_tests() method. We will switch
3937         between the two based on the setting for the '--worker-model'
3938         switch. We rename the two currently valid values to 'old-inline'
3939         and 'old-threads'.
3940
3941         https://bugs.webkit.org/show_bug.cgi?id=51081
3942
3943         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3944         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3945
3946 2010-12-22  Victor Wang  <victorw@chromium.org>
3947
3948         Reviewed by Darin Fisher.
3949
3950         [Chromium] Update chromium archive test result url in rebaseline script.
3951
3952         https://bugs.webkit.org/show_bug.cgi?id=51503
3953
3954         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3955
3956 2010-12-22  Lucas Forschler  <lforschler@apple.com>
3957
3958         Reviewed by Alice Liu.
3959
3960         <rdar://problem/8633222> record-memory-win needs to record memory used by the webprocess.
3961         Verified on Chrome, Safari, and IE.
3962         With this change, we will record memory from a parent browser window and all child processes.
3963
3964         * record-memory-win/main.cpp:
3965         (ProcessArgs):
3966         (PrintUsage):
3967         (getMemoryInfo):
3968         (printProcessInfo):
3969         (evalProcesses):
3970         (UseImage):
3971         (QueryContinuously):
3972         (ElapsedTime):
3973
3974 2010-12-22  Lucas Forschler  <lforschler@apple.com>
3975
3976         Unreviewed rollout r74489, because it was missing changelog.
3977
3978         * record-memory-win/main.cpp:
3979         
3980 2010-12-22  Ryosuke Niwa  <rniwa@webkit.org>
3981
3982         Adding myself as a reviewer.
3983
3984         * Scripts/webkitpy/common/config/committers.py:
3985
3986 2010-12-22  Andrew Scherkus  <scherkus@chromium.org>
3987
3988         Unreviewed.  Adding myself to committers.py.
3989
3990         * Scripts/webkitpy/common/config/committers.py:
3991
3992 2010-12-22  Ariya Hidayat  <ariya@sencha.com>
3993
3994         Reviewed by Kenneth Rohde Christiansen.
3995
3996         TestNetscapePlugIn should use #if defined
3997         https://bugs.webkit.org/show_bug.cgi?id=51471
3998
3999         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
4000         (NP_Initialize):
4001         (NPP_New):
4002
4003 2010-12-22  Ilya Tikhonovsky  <loislo@chromium.org>
4004
4005         Reviewed by Yury Semikhatsky.
4006
4007         Web Inspector: [chromium] DRT inspector layout tests are flaky in debug.
4008
4009         DevTools window should be closed explicitly because it has custom deinitialization code.
4010
4011         https://bugs.webkit.org/show_bug.cgi?id=50722
4012
4013         * DumpRenderTree/chromium/TestShell.cpp:
4014         (TestShell::closeRemainingWindows):
4015
4016 2010-12-22  David Levin  <levin@chromium.org>
4017
4018         Reviewed by Shinichiro Hamaji.
4019
4020         check-webkit-style shouldn't complaint about underscores in variables in objective C files.
4021         https://bugs.webkit.org/show_bug.cgi?id=51452
4022
4023         * Scripts/webkitpy/style/checkers/cpp.py:
4024         (_FileState.__init__): Added the information to determine if a file is C or Objective C.
4025         Using the file extension if possible but falling back to the file contents if we have a header file.
4026         (_FileState.is_objective_c): Determine if we have an Objective C by examining the file contents if needed.
4027         (_FileState.is_c_or_objective_c):
4028         (check_using_std): Changed to using _FileState to determine the file type.
4029         (check_max_min_macros): Ditto.
4030         (check_for_null): Ditto.
4031         (check_style): Changed the parameters to various calls since they now need _FileState
4032         to determine the file type.
4033         (check_language): Added the file_state parameter so it could be passed
4034         to check_identifier_name_in_declaration.
4035         (check_identifier_name_in_declaration): Don't warn about underscores in variables if
4036         this is an Objective C file.
4037         (_process_lines): Added information for the _FileState constructor (and moved the
4038         call to a place that had the information).
4039         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4040         (CppFunctionsTest.test_is_c_or_objective_c): Changed the tests to use FileState and exercise
4041         its functionality.
4042         (WebKitStyleTest.test_names): Add tests for underscores in Objective C files.
4043
4044 2010-12-21  Andy Estes  <aestes@apple.com>
4045
4046         Reviewed by Mark Rowe.
4047
4048         Do not build non-Intel architectures for WebKit2-related projects.
4049         https://bugs.webkit.org/show_bug.cgi?id=51440
4050
4051         * MiniBrowser/Configurations/Base.xcconfig: Only build for i386 and x86_64.
4052         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
4053         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
4054
4055 2010-12-21  Mihai Parparita  <mihaip@chromium.org>
4056
4057         Reviewed by Darin Fisher.
4058
4059         [Chromium] Rename WebThemeEngine/ControlDRT to WebThemeEngine/ControlDRTWin
4060         https://bugs.webkit.org/show_bug.cgi?id=51406 
4061         
4062         Rename WebThemeControlDRT to WebThemeControlDRTWin and WebThemeEngineDRT
4063         to WebThemeEngineDRTWin and update references everywhere.
4064
4065         * DumpRenderTree/DumpRenderTree.gypi:
4066         * DumpRenderTree/chromium/TestShellWin.cpp:
4067         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.cpp.
4068         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.h.
4069         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.cpp.
4070         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.h.
4071
4072 2010-12-21  Anders Carlsson  <andersca@apple.com>
4073
4074         Reviewed by John Sullivan.
4075
4076         Clicking missing plug-in text does not show a sheet
4077         https://bugs.webkit.org/show_bug.cgi?id=51403
4078
4079         Update for changes to the WebPageUIClient.
4080
4081         * MiniBrowser/mac/BrowserWindowController.m:
4082         (-[BrowserWindowController awakeFromNib]):
4083         * WebKitTestRunner/TestController.cpp:
4084         (WTR::createOtherPage):
4085         (WTR::TestController::initialize):
4086
4087 2010-12-21  Eric Seidel  <eric@webkit.org>
4088
4089         Reviewed by Adam Barth.
4090
4091         commit-queue will report constant failures as flaky if other tests flake
4092         https://bugs.webkit.org/show_bug.cgi?id=51272
4093
4094         This patch just removes functionality and adds testing.
4095         Previously we attempted to report flaky tests when we had
4096         two different tests fail in a row.  However, since we stop
4097         running the tests at the first failure, our code was wrong in
4098         trying to determine flakiness from the incomplete runs.
4099
4100         Originally I posted an alternate patch:
4101         https://bug-51272-attachments.webkit.org/attachment.cgi?id=77078
4102         which fixed our flaky logic in this case, however it was decided
4103         that that patch would be too difficult to maintain, so now
4104         I'm just removing the broken logic.
4105
4106         This will dramatically cut-down on our flaky-test false positives
4107         at the (small) cost of the queues being unable to report
4108         any flakiness if the tree is very flaky.  (With at least one test
4109         flaking on every run, we'll never report failures anymore.)  I think
4110         this is a tradeoff worth making.
4111
4112         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
4113         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
4114
4115 2010-12-20  Eric Seidel  <eric@webkit.org>
4116
4117         Reviewed by Adam Barth.
4118
4119         commit-queue wrongly rejects patches when it can't update itself
4120         https://bugs.webkit.org/show_bug.cgi?id=46636
4121
4122         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
4123         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
4124         * Scripts/webkitpy/tool/commands/queues_unittest.py:
4125
4126 2010-12-20  Adam Barth  <abarth@webkit.org>
4127
4128         Move web sites to Websites directory
4129         https://bugs.webkit.org/show_bug.cgi?id=51323
4130
4131         Update references to BugsSite to point to the new location.
4132
4133         This patch was never officially reviewed (because it was too large to
4134         upload to bugs.webkit.org), but it was discussed on webkit-dev and Mark
4135         Rowe gave me the green light.
4136
4137         * Scripts/old-run-webkit-tests:
4138         * Scripts/webkitpy/common/config/build.py:
4139         * Scripts/webkitpy/common/config/build_unittest.py:
4140         * Scripts/webkitpy/common/prettypatch.py:
4141         * Scripts/webkitpy/layout_tests/port/base.py:
4142         * Scripts/webkitpy/style/main.py:
4143
4144 2010-12-20  Adrienne Walker  <enne@google.com>
4145
4146         Unreviewed. Adding myself to the list of committers.
4147
4148         * webkitpy/common/config/committers.py:
4149
4150 2010-12-20  Mark Rowe  <mrowe@apple.com>
4151
4152         Reviewed by Dan Bernstein.
4153
4154         <rdar://problem/8757601> Don't install header files in to the Resources directory.
4155
4156         * Scripts/check-for-inappropriate-files-in-framework: Don't allow .h files in the
4157         Resources directory.
4158
4159 2010-12-20  Eric Seidel  <eric@webkit.org>
4160
4161         Reviewed by Adam Barth.
4162
4163         commit-queue should include bot id when attaching failure diffs
4164         https://bugs.webkit.org/show_bug.cgi?id=51280
4165
4166         This is a tiny change to include the bot id in the name of the attachment.
4167         Most of this diff is just changing the unit test expectations
4168         now that I hid the comment printing when the comment is None.
4169
4170         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
4171         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
4172         * Scripts/webkitpy/tool/commands/upload_unittest.py:
4173         * Scripts/webkitpy/tool/mocktool.py:
4174
4175 2010-12-20  Jeff Miller  <jeffm@apple.com>
4176
4177         Reviewed by Dan Bernstein.
4178
4179         Tools/vcbin/midl.exe needs to be rebuilt
4180         https://bugs.webkit.org/show_bug.cgi?id=51347
4181
4182         * vcbin/midl.exe: Rebuilt.
4183
4184 2010-12-20  David Levin  <levin@chromium.org>
4185
4186         Reviewed by Ariya Hidayat.
4187
4188         .gitignore and webkit-tools-completion.sh have references to WebKitTools that should be Tools.
4189         https://bugs.webkit.org/show_bug.cgi?id=51343
4190
4191         Follow up from the WebKitTools -> Tools rename.
4192
4193         * Scripts/webkit-tools-completion.sh:
4194
4195 2010-12-20  Cosmin Truta  <ctruta@chromium.org>
4196
4197         Reviewed by James Robinson.
4198
4199         new-run-webkit-tests ignores trailing EOL differences in text tests
4200         https://bugs.webkit.org/show_bug.cgi?id=36983
4201
4202         Changed the handling of new-line characters within new-run-webkit-tests
4203         to match old-run-webkit-tests.  Differences in leading and trailing empty
4204         lines in text expectation files are no longer ignored.
4205
4206         * Scripts/webkitpy/layout_tests/port/base.py:
4207         * Scripts/webkitpy/layout_tests/port/test.py:
4208         Added unit tests.  Removed old duplicate unit test entries.
4209         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
4210
4211 2010-12-20  David Levin  <levin@chromium.org>
4212
4213         Reviewed by Shinichiro Hamaji.
4214
4215         check-webkit-style should detect function declarations (and trivial functions).
4216         https://bugs.webkit.org/show_bug.cgi?id=51303
4217
4218         * Scripts/webkitpy/style/checkers/cpp.py:
4219         (_FunctionState.begin): Add is_declaration and changed the line count
4220         start to begin at -1 (which will keep the results consistent, since
4221         the starting line number passed in is one less in this change).
4222         (detect_functions): changed function detection to now catch trivial
4223         functions and declarations.
4224         (check_pass_ptr_usage): Don't check for Pass*Ptr on the first line
4225         of the function as this may look at return values (when processing
4226         a declaration).
4227         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4228         (FunctionDetectionTest.perform_function_detection): Basic mechanics
4229         of testing the function detection.
4230         (FunctionDetectionTest.test_basic_function_detection): Test a simple
4231         function.
4232         (FunctionDetectionTest.test_function_declaration_detection): Test a
4233         declaration.
4234         (FunctionDetectionTest.test_non_functions): A test case for a case
4235         that caused the code to fail due to the { being in quotes.
4236         (PassPtrTest.test_pass_ref_ptr_return_value): Added some more test
4237         cases to help catch false alarms for return values.
4238         (PassPtrTest.test_pass_ref_ptr_member_variable): Ensure that
4239         we don't get false alarms for member variables either.
4240
4241 2010-12-20  Ryuan Choi  <ryuan.choi@samsung.com>
4242
4243         Reviewed by Antonio Gomes.
4244
4245         [CMAKE] Rename WEBKITTOOLS_DIR to TOOLS_DIR
4246         https://bugs.webkit.org/show_bug.cgi?id=51319
4247
4248         * CMakeListsEfl.txt:
4249
4250 2010-12-18  Adam Barth  <abarth@webkit.org>
4251
4252         Reviewed by Sam Weinig.
4253
4254         Move WebKitExamplePlugins to Examples
4255         https://bugs.webkit.org/show_bug.cgi?id=51291
4256
4257         * Scripts/webkitpy/common/config/build.py:
4258
4259 2010-12-17  Csaba Osztrogonác  <ossy@webkit.org>
4260
4261         Unreviewed Qt buildfix after r74301.
4262
4263         Rename WebKitTools to Tools
4264         https://bugs.webkit.org/show_bug.cgi?id=49861
4265
4266         * MiniBrowser/DerivedSources.pro:
4267         * MiniBrowser/qt/MiniBrowser.pro:
4268
4269 2010-12-17  Dan Bernstein  <mitz@apple.com>
4270
4271         Reviewed by Simon Fraser.
4272
4273         Rename WebKitTools to Tools
4274         https://bugs.webkit.org/show_bug.cgi?id=49861
4275
4276         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4277         * CodeCoverage/README:
4278         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4279         (WebCore::DumpRenderTree::initializeFonts):
4280         * EWSTools/start-commit-queue.sh:
4281         * EWSTools/start-queue.sh:
4282         * GNUmakefile.am:
4283         * MIDLWrapper/MIDLWrapper.cpp:
4284         (wmain):
4285         * MiniBrowser/qt/MiniBrowser.pro:
4286         * Scripts/build-api-tests:
4287         * Scripts/build-dumprendertree:
4288         * Scripts/build-webkit:
4289         * Scripts/build-webkittestrunner:
4290         * Scripts/generate-coverage-data:
4291         * Scripts/old-run-webkit-tests:
4292         * Scripts/run-api-tests:
4293         * Scripts/run-iexploder-tests:
4294         * Scripts/run-javascriptcore-tests:
4295         * Scripts/run-mangleme-tests:
4296         * Scripts/run-sunspider:
4297         * Scripts/run-webkit-websocketserver:
4298         * Scripts/sunspider-compare-results:
4299         * Scripts/test-webkitperl:
4300         * Scripts/test-webkitpy:
4301         * Scripts/update-iexploder-cssproperties:
4302         * Scripts/update-webkit:
4303         * Scripts/update-webkit-localizable-strings:
4304         * Scripts/webkitdirs.pm:
4305         * Scripts/webkitpy/common/checkout/scm.py:
4306         * Scripts/webkitpy/common/checkout/scm_unittest.py:
4307         * Scripts/webkitpy/common/config/committervalidator.py:
4308         * Scripts/webkitpy/common/config/committervalidator_unittest.py:
4309         * Scripts/webkitpy/common/config/ports.py:
4310         * Scripts/webkitpy/common/config/ports_unittest.py:
4311         * Scripts/webkitpy/common/system/logutils_unittest.py:
4312         * Scripts/webkitpy/common/system/ospath_unittest.py:
4313         * Scripts/webkitpy/layout_tests/port/chromium.py:
4314         * Scripts/webkitpy/layout_tests/port/config.py:
4315         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
4316         * Scripts/webkitpy/layout_tests/port/http_server.py:
4317         * Scripts/webkitpy/layout_tests/port/test.py:
4318         * Scripts/webkitpy/style/checker.py:
4319         * Scripts/webkitpy/style/checker_unittest.py:
4320         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
4321         * Scripts/webkitpy/tool/commands/queues_unittest.py:
4322         * Scripts/webkitpy/tool/steps/steps_unittest.py:
4323         * WebKitTestRunner/DerivedSources.pro:
4324         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
4325         (WTR::activateFonts):
4326         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
4327         * wx/build/build_utils.py:
4328
4329 2010-12-16  Antonio Gomes  <agomes@rim.com>
4330
4331         Reviewed by Martin Robinson.
4332
4333         Settings::editingBehaviorType() incorrectly returns mac for the gtk build when running tests
4334         https://bugs.webkit.org/show_bug.cgi?id=51163
4335
4336         Since GTK+'s default editing behavior was changed to UNIX in r70975 (see webkitwebsettings.cpp),
4337         GTK+'s DRT should also reset to UNIX after each test execution.
4338
4339         * DumpRenderTree/gtk/DumpRenderTree.cpp:
4340         (resetDefaultsToConsistentValues):
4341
4342 2010-12-17  David Levin  <levin@chromium.org>
4343
4344         Reviewed by Eric Seidel.
4345
4346         check-webkit-style should understand WTF #include guards
4347         https://bugs.webkit.org/show_bug.cgi?id=44911
4348
4349         * Scripts/webkitpy/style/checkers/cpp.py:
4350         (get_header_guard_cpp_variable): modify to suggest the WTF style
4351         of header guard when appropriate.
4352         (check_for_header_guard): handle multiple return values from
4353         get_header_guard_cpp_variable
4354         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4355         (CppStyleTest.test_build_header_guard): Added tests for the WTF
4356         header style.
4357
4358 2010-12-16  David Levin  <levin@chromium.org>
4359
4360         Reviewed by Eric Seidel.
4361
4362         test-webkitpy: unittest for the xml.py checker displays a decprecation warning.
4363         https://bugs.webkit.org/show_bug.cgi?id=51210
4364
4365         The error only shows up when using python 2.6 or later.
4366
4367         * Scripts/webkitpy/style/checkers/xml.py: Replace the usage of
4368         the decprecated field error,message with something equivalent.
4369
4370 2010-12-16  Mihai Parparita  <mihaip@chromium.org>
4371
4372         Reviewed by Eric Seidel.
4373
4374         Add --exit-after-n-failures/crashes to NRWT
4375         https://bugs.webkit.org/show_bug.cgi?id=51160
4376         
4377         Abort test run (in a similar way to how control-C is handled) when
4378         --exit-after-n-failures/crashes-or-timeouts are passed and we've reached
4379         that number of unexpected failures/crashes/timeouts.
4380
4381         * Scripts/webkitpy/layout_tests/port/test.py:
4382         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4383         * Scripts/webkit