61ce0df96f2c7ed4f2e06718883b3595c9a4e90a
[WebKit-https.git] / Tools / ChangeLog
1 2011-04-04  Pavel Podivilov  <podivilov@chromium.org>
2
3         Unreviewed, fix exception in rebaseline tool.
4
5         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
6
7 2011-04-02  Beth Dakin  <bdakin@apple.com>
8
9         Rubber-stamped by Geoff Garen.
10
11         For Dan!
12         * DumpRenderTree/mac/DumpRenderTree.mm:
13         (resetWebViewToConsistentStateBeforeTesting):
14
15 2011-04-02  Beth Dakin  <bdakin@apple.com>
16
17         Rubber-stamped by Geoff Garen.
18
19         Need to reset the scale, much like zoom.
20         * DumpRenderTree/mac/DumpRenderTree.mm:
21         (resetWebViewToConsistentStateBeforeTesting):
22
23 2011-04-02  Sam Weinig  <sam@webkit.org>
24
25         Reviewed by Beth Dakin.
26
27         https://bugs.webkit.org/show_bug.cgi?id=57605
28         Frame::pageScaleFactor() should not affect getBoundingClientRect() or 
29         getClientRects()
30         -and corresponding-
31         <rdar://problem/9194541>
32
33         Add DRT support for the scaleWebView SPI.
34         * DumpRenderTree/mac/EventSendingController.mm:
35         (+[EventSendingController isSelectorExcludedFromWebScript:]):
36         (+[EventSendingController webScriptNameForSelector:]):
37         (-[EventSendingController scalePageBy:atX:andY:]):
38         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
39         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
40         (WTR::EventSendingController::scalePageBy):
41         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
42         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
43         (WTR::InjectedBundlePage::reset):
44
45 2011-04-02  Dominic Cooney  <dominicc@google.com>
46
47         Reviewed by Martin Robinson.
48
49         Add layoutTestController.shadowRoot to GTK DumpRenderTree.
50         https://bugs.webkit.org/show_bug.cgi?id=57551
51
52         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
53         (LayoutTestController::shadowRoot):
54
55 2011-04-02  Patrick Gansterer  <paroga@webkit.org>
56
57         Reviewed by Eric Seidel.
58
59         Remove AbstractStep._run_script and move script names to ports.py
60         https://bugs.webkit.org/show_bug.cgi?id=57704
61
62         Replace deprecated _run_script with _tool.executive.run_and_throw_if_fail.
63
64         * Scripts/webkitpy/common/config/ports.py:
65         * Scripts/webkitpy/tool/commands/download_unittest.py:
66         * Scripts/webkitpy/tool/commands/roll_unittest.py:
67         * Scripts/webkitpy/tool/commands/upload_unittest.py:
68         * Scripts/webkitpy/tool/steps/abstractstep.py:
69         * Scripts/webkitpy/tool/steps/checkstyle.py:
70         * Scripts/webkitpy/tool/steps/preparechangelog.py:
71         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py:
72         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
73
74 2011-04-02  Patrick Gansterer  <paroga@webkit.org>
75
76         Reviewed by Eric Seidel.
77
78         Emulate shebang on Win32
79         https://bugs.webkit.org/show_bug.cgi?id=55927
80
81         Scripts on Windows work only if they are called with the explicit interpreter.
82         Read the first line of scripts to detect the correct executable.
83
84         * Scripts/webkitpy/common/config/ports.py:
85         * Scripts/webkitpy/common/system/executive.py: Added interpreter_for_script().
86         * Scripts/webkitpy/common/system/executive_unittest.py:
87
88 2011-04-01  Adam Barth  <abarth@webkit.org>
89
90         Reviewed by Eric Seidel.
91
92         apos entities shouldn't show up in ChangeLogs when using webkit-patch
93         https://bugs.webkit.org/show_bug.cgi?id=57692
94
95         Previously, we were using BeautifulSoup to process XML from
96         bugs.webkit.org, but that's incorrect.  We should be using
97         BeautifulStoneSoup to process the XML.  We were getting the &apos;
98         entity wrong because &apos; is an XML entity but not an HTML entity.
99
100         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
101         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
102
103 2011-04-01  Sheriff Bot  <webkit.review.bot@gmail.com>
104
105         Unreviewed, rolling out r82721.
106         http://trac.webkit.org/changeset/82721
107         https://bugs.webkit.org/show_bug.cgi?id=57687
108
109         This patch introduced assertion failures on the GTK+ bots.
110         (Requested by mrobinson on #webkit).
111
112         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
113         (LayoutTestController::shadowRoot):
114
115 2011-04-01  Csaba Osztrogonác  <ossy@webkit.org>
116
117         Unreviewed buildfix.
118
119         [Qt][WK2] Build Webkit2 using "-2" option on Qt
120         https://bugs.webkit.org/show_bug.cgi?id=55074
121
122         * Scripts/build-webkit: Ensure that "-2" isn't passed to qmake.
123         (The isWK2() function removes it from @ARGV, but not from @options.)
124
125 2011-04-01  Keith Kyzivat  <keith.kyzivat@nokia.com>
126
127         Reviewed by Csaba Osztrogonác.
128
129         [Qt] [WK2] MiniBrowser.qrc not found - regression from rev 82671
130         https://bugs.webkit.org/show_bug.cgi?id=57666
131
132         * MiniBrowser/qt/MiniBrowser.qrc: Renamed from Tools/MiniBrowser/MiniBrowser.qrc.
133
134 2011-04-01  Dirk Pranke  <dpranke@chromium.org>
135
136         Reviewed by Adam Barth.
137
138         new-run-webkit-tests: fix feature detection, skipped platform lists on mac
139
140         We apparently never implemented the code to skip tests based on
141         what was compiled into DRT. Also, change the logic used to skip
142         platform directories to match what old-run-webkit-tests does: 
143         skip every test not in a directory in the baseline search path.
144
145         https://bugs.webkit.org/show_bug.cgi?id=57662
146
147         * Scripts/webkitpy/layout_tests/port/mac.py:
148         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
149         * Scripts/webkitpy/layout_tests/port/webkit.py:
150
151 2011-03-29  Mark Rowe  <mrowe@apple.com>
152
153         Reviewed by Jon Honeycutt.
154
155         <http://webkit.org/b/56730> new-run-webkit-tests fails on Lion seed
156
157         Teach new-run-webkit-tests about the concept of an unreleased version of Mac OS X.
158
159         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
160         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
161         * Scripts/webkitpy/layout_tests/port/mac.py:
162         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
163
164 2011-04-01  Chang Shu  <cshu@webkit.org>
165
166         Reviewed by Csaba Osztrogonác.
167
168         [Qt][WK2] Build Webkit2 using "-2" option on Qt
169         https://bugs.webkit.org/show_bug.cgi?id=55074
170
171         * Scripts/build-webkit:
172
173 2011-04-01  Dirk Pranke  <dpranke@chromium.org>
174
175         Reviewed by Tony Chang.
176
177         new-run-webkit-tests: remove spurious port version override in webkit.py
178         base.py provides a default implementation so this is just
179         breaking things.
180
181         https://bugs.webkit.org/show_bug.cgi?id=57667
182
183         * Scripts/webkitpy/layout_tests/port/webkit.py:
184         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
185
186 2011-04-01  Csaba Osztrogonác  <ossy@webkit.org>
187
188         Reviewed by Adam Roben.
189
190         Make view results on waterfall direct link to results.html
191         https://bugs.webkit.org/show_bug.cgi?id=57671
192
193         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add "/results.html" to the URL.
194         * Scripts/old-run-webkit-tests: Add links to httpd access and error logs.
195
196 2011-04-01  Sam Weinig  <sam@webkit.org>
197
198         Fix windows build.
199
200         * TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp:
201         (TestWebKitAPI::TEST):
202         * TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp:
203         (TestWebKitAPI::flushMessages):
204
205 2011-04-01  Sam Weinig  <sam@webkit.org>
206
207         Reviewed by Adam Roben.
208
209         Add adoptWK to WKRetainPtr.h
210         https://bugs.webkit.org/show_bug.cgi?id=57670
211
212         * TestWebKitAPI/PlatformUtilities.h:
213         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp:
214         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
215         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp:
216         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
217         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
218         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
219         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp:
220         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
221         (TestWebKitAPI::createSessionStateContainingFormData):
222         * WebKitTestRunner/StringFunctions.h:
223         Replace custom versions of adoptWK with the API on in WebKit2/WKRetainPtr.h.
224
225 2011-04-01  Sam Weinig  <sam@webkit.org>
226
227         Reviewed by Adam Roben.
228
229         Fix leak noticed by Adam Roben in LayoutTestController::shadowRoot.
230
231         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
232         (WTR::LayoutTestController::shadowRoot):
233         Make judicious use of adoptWK().
234
235 2011-04-01  Sam Weinig  <sam@webkit.org>
236
237         Reviewed by Timothy Hatcher.
238
239         Fix extract-localizable-strings for macro change from UI_STRING -> WEB_UI_STRING.
240
241         * Scripts/extract-localizable-strings:
242
243 2011-04-01  Anders Carlsson  <andersca@apple.com>
244
245         Reviewed by Sam Weinig.
246
247         Shockwave plug-in doesn't accept mouse events
248         https://bugs.webkit.org/show_bug.cgi?id=57653
249         <rdar://problem/8483273>
250
251         Add a plug-in test.
252
253         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
254         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
255         (PluginTest::indicateTestFailure):
256         Move code from NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject here.
257
258         (PluginTest::NPN_ConvertPoint):
259         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
260         * DumpRenderTree/TestNetscapePlugIn/Tests/NPDeallocateCalledBeforeNPShutdown.cpp:
261         (NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject):
262         Call indicateTestFailure.
263
264         * DumpRenderTree/TestNetscapePlugIn/Tests/mac: Added.
265         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/ConvertPoint.cpp: Added.
266         (ConvertPoint::ConvertPoint):
267         (ConvertPoint::testConvert):
268         (ConvertPoint::NPP_New):
269
270 2011-04-01  Dominic Cooney  <dominicc@google.com>
271
272         Reviewed by Martin Robinson.
273
274         Add layoutTestController.shadowRoot to GTK DumpRenderTree.
275         https://bugs.webkit.org/show_bug.cgi?id=57551
276
277         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
278         (LayoutTestController::shadowRoot):
279
280 2011-04-01  Sam Weinig  <sam@webkit.org>
281
282         Reviewed by Anders Carlsson.
283
284         WebKitTestRunner needs layoutTestController.shadowRoot
285         https://bugs.webkit.org/show_bug.cgi?id=57661
286
287         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
288         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
289         (WTR::LayoutTestController::shadowRoot):
290         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
291         Implement layoutTestController.shadowRoot for WebKit2.
292
293 2011-04-01  Chang Shu  <cshu@webkit.org>
294
295         Reviewed by Darin Adler.
296
297         WebKitTestRunner needs layoutTestController.setDatabaseQuota
298         https://bugs.webkit.org/show_bug.cgi?id=57568
299
300         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
301         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
302         (WTR::LayoutTestController::setDatabaseQuota):
303         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
304
305 2011-04-01  Dirk Pranke  <dpranke@chromium.org>
306
307         Reviewed by Tony Chang.
308
309         This patch completes the cleanup of
310         rebaseline-chromium-webkit-tests to work with all of the
311         variants of a platform (we can now rebaseline gpu- and non-gpu
312         files at the same time).
313
314         When the rebaselining is complete, any lines declared as
315         REBASELINE in the expectations file that matches a test that was
316         actually rebaselined will be deleted, even if only one of the
317         variants was actually rebaselined. This may cause odd problems,
318         but is better than where we're at today.
319
320         This change removes the -g flag and deprecates -w. The -g flag is gone
321         because GPU baselines are handled just like any other variant.
322         The -w flag is deprecated because this tool now only works
323         against the canaries, since that's the only place we have a full
324         set of bots. It will be trivial to change this to
325         build.webkit.org if we decide that's where we want them to be.
326
327         Also, this patch deletes a lot of cruft that is no longer needed
328         in the test_expectations code and the port-specific code.
329
330         https://bugs.webkit.org/show_bug.cgi?id=55191
331
332         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
333         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
334         * Scripts/webkitpy/layout_tests/port/base.py:
335         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
336         * Scripts/webkitpy/layout_tests/port/chromium.py:
337         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
338         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
339         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
340         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
341         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
342         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
343         * Scripts/webkitpy/layout_tests/port/mac.py:
344         * Scripts/webkitpy/layout_tests/port/test.py:
345         * Scripts/webkitpy/layout_tests/port/webkit.py:
346         * Scripts/webkitpy/layout_tests/port/win.py:
347         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
348         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
349
350 2011-04-01  Dirk Pranke  <dpranke@chromium.org>
351
352         Reviewed by Adam Barth.
353
354         rebaseline-chromium-webkit-tests does not work correctly with
355         version-specific baselines. This patch updates the tool to use
356         all of the version-specific bots on the canaries, and will now
357         attempt to rebaseline all of the versions by default, although
358         it will not update both GPU and CPU versions.
359         
360         Also, it will no longer modify the test_expectations.txt file
361         *at all*. You will have to manually delete the REBASELINE lines
362         after running the tool and determining that it did what you
363         wanted it to do. This should be fixed in a separate bug - see
364         webkit bug #55191.
365
366         https://bugs.webkit.org/show_bug.cgi?id=55608
367
368         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
369         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
370         * Scripts/webkitpy/layout_tests/port/chromium.py:
371         * Scripts/webkitpy/layout_tests/port/test.py:
372         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
373         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
374
375 2011-03-31  Tony Chang  <tony@chromium.org>
376
377         Reviewed by Ojan Vafai.
378
379         [chromium] update the rebaseline tool to know about pngs with checksums
380         https://bugs.webkit.org/show_bug.cgi?id=57481
381
382         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: Skip over .checksum files if the checksum is already in the png
383         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
384
385 2011-04-01  Adam Roben  <aroben@apple.com>
386
387         Retrieve revision numbers from the build's got_revision property in Leaks Viewer
388
389         Previously, we were getting the revision of the first revision that triggered a build.
390         Choosing the last revision would have been more accurate. But got_revision is what is used
391         everywhere else on build.webkit.org, and should work even when there were no changes that
392         triggered a build (e.g., if someone clicked the Force Build button).
393
394         Fixes <http://webkit.org/b/57630> Leaks viewer gets some revision numbers wrong in the
395         recent builds list
396
397         Reviewed by Anders Carlsson.
398
399         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
400         (RecentBuildsLoader.prototype.start): Pull the revision number out of the got_revision
401         property, rather than out of the first (i.e., earliest) change in the sourceStamp object.
402
403         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Utilities.js:
404         (Array.prototype.first): Added this helper function to return the first element in an array
405         that matches the given predicate, or null if no such element exists.
406
407 2011-03-31  Adam Roben  <aroben@apple.com>
408
409         Prefer (but don't require) bug URLs to be on their own line when parsing bug numbers from ChangeLogs
410
411         Fixes <http://webkit.org/b/57579> webkit-patch is too strict about bug URL formatting
412
413         Reviewed by Darin Adler.
414
415         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
416         (parse_bug_id_from_changelog): Fall back to parse_bug_id if we weren't able to find a bug
417         URL on its own line.
418
419         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
420         (BugzillaTest.test_parse_bug_id_from_changelog): Updated expected results for test
421         progression, and added a new test that uses a short bug URL while I was at it.
422
423 2011-04-01  Adam Roben  <aroben@apple.com>
424
425         Mark .vcproj/.vsprops/.sln files as being Windows-only
426
427         Fixes <http://webkit.org/b/57489> Mac builders built 82512, but shouldn't have
428
429         Reviewed by Anders Carlsson.
430
431         * Scripts/webkitpy/common/config/build.py:
432         (_should_file_trigger_build): Added patterns to mark .vcproj/.vsprops/.sln files and .vcproj
433         directories as Windows-only.
434
435         * Scripts/webkitpy/common/config/build_unittest.py:
436         (ShoulBuildTest): Added test cases for the above.
437
438 2011-04-01  Keith Kyzivat  <keith.kyzivat@nokia.com>
439
440         Reviewed by Laszlo Gombos.
441
442         [Qt] Build MiniBrowser for Symbian
443         https://bugs.webkit.org/show_bug.cgi?id=56319
444
445         Have MiniBrowser reference it's own copy of useragentlist.txt instead
446         of copying QtTestBrowser's.
447         Remove Tools/MiniBrowser/DerivedSources.pro
448         This reduces complexity in the Tools scripts due to Symbian limitations.
449
450         * DerivedSources.pro:
451         * MiniBrowser/DerivedSources.pro: Removed.
452         * MiniBrowser/MiniBrowser.qrc:
453         * MiniBrowser/qt/MiniBrowser.pro:
454         * Scripts/webkitdirs.pm:
455
456 2011-03-31  Chang Shu  <cshu@webkit.org>
457
458         Reviewed by Darin Adler.
459
460         WebKitTestRunner needs layoutTestController.clearAllDatabases
461         https://bugs.webkit.org/show_bug.cgi?id=42540
462
463         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
464         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
465         (WTR::InjectedBundle::beginTesting):
466         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
467         (WTR::LayoutTestController::clearAllDatabases):
468         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
469
470 2011-03-31  Chang Shu  <cshu@webkit.org>
471
472         Reviewed by Darin Adler.
473
474         WebKitTestRunner needs layoutTestController.setAllowUniversalAccessFromFileURLs
475         https://bugs.webkit.org/show_bug.cgi?id=42692
476
477         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
478
479 2011-03-31  Darin Adler  <darin@apple.com>
480
481         Reviewed by Sam Weinig.
482
483         Implement mouseDown, mouseUp, and mouseMoveTo in WebKitTestRunner
484         https://bugs.webkit.org/show_bug.cgi?id=57573
485
486         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
487         Added real definitions for mouseDown, mouseUp, mouseMoveTo and leapForward.
488         Removed fake definitions of keyDown and contextClick.
489
490         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
491         (WTR::operator==): Added. So we can compare two WKPoint structs.
492         (WTR::parseModifier): Added.
493         (WTR::parseModifierArray): Added.
494         (WTR::EventSendingController::EventSendingController): Initialize the
495         new data members.
496         (WTR::EventSendingController::mouseDown): Added. Calls
497         WKBundlePageSimulateMouseDown.
498         (WTR::EventSendingController::mouseUp): Added. Calls
499         WKBundlePageSimulateMouseUp.
500         (WTR::EventSendingController::mouseMoveTo): Added. Calls
501         WKBundlePageSimulateMouseMotion.
502         (WTR::EventSendingController::leapForward): Added.
503         (WTR::EventSendingController::updateClickCount): Added. Used by the
504         mouseDown/Up functions to create a click count.
505
506         * WebKitTestRunner/InjectedBundle/EventSendingController.h: Updated
507         for the changes above.
508
509 2011-03-31  Sergio Villar Senin  <svillar@igalia.com>
510
511         Reviewed by Martin Robinson.
512
513         [GTK] implement LayoutTestController::setWillSendRequestReturnsNull
514         https://bugs.webkit.org/show_bug.cgi?id=57362
515
516         Do not generate DRT output if willSendRequestReturnsNull is set.
517
518         * DumpRenderTree/gtk/DumpRenderTree.cpp:
519         (willSendRequestCallback):
520
521 2011-03-31  Vamshikrishna.Yellenki  <vamshi@motorola.com> and Alejandro G. Castro  <alex@igalia.com>
522
523         Reviewed by Martin Robinson.
524
525         Implement MiniBrowser for Gtk port.
526         https://bugs.webkit.org/show_bug.cgi?id=48512
527
528         Initial implementation of the Gtk MiniBrowser.
529
530         * MiniBrowser/gtk/GNUmakefile.am: Added.
531         * MiniBrowser/gtk/main.c: Added.
532         (activateUriEntryCallback):
533         (destroyCallback):
534         (goBackCallback):
535         (goForwardCallback):
536         (createToolbar):
537         (createWebView):
538         (createWindow):
539         (argumentToURL):
540         (main):
541
542 2011-03-30  Dominic Cooney  <dominicc@google.com>
543
544         Reviewed by Dimitri Glazkov.
545
546         Adds layoutTestController.shadowRoot accessor to Mac DRT.
547         https://bugs.webkit.org/show_bug.cgi?id=57415
548
549         * DumpRenderTree/LayoutTestController.cpp:
550         (shadowRootCallback):
551         (LayoutTestController::staticFunctions):
552         * DumpRenderTree/LayoutTestController.h:
553         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
554         (LayoutTestController::shadowRoot):
555         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
556         (LayoutTestController::shadowRoot):
557
558 2011-03-30  Matthew Delaney  <mdelaney@apple.com>
559
560         Reviewed by Chris Marrin.
561
562         Update fast/canvas tests to avoid dumping the render tree when possible
563         https://bugs.webkit.org/show_bug.cgi?id=57493
564
565         * DumpRenderTree/mac/DumpRenderTree.mm: Make DRT aware of new default values for
566           accelerated drawing and accelerated drawing for canvas
567
568 2011-03-30  Adam Roben  <aroben@apple.com>
569
570         Stop ignoring leaks in CGGradientCreateWithColorStops
571
572         Fixes <rdar://problem/7888547>.
573
574         Rubber-stamped by John Sullivan.
575
576         * Scripts/old-run-webkit-tests:
577         (countAndPrintLeaks): Removed some code to ignore those leaks.
578
579 2011-03-30  Timur Iskhodzhanov  <timurrrr@google.com>
580
581         Reviewed by Alexey Proskuryakov.
582
583         Add some dynamic annotations to JavaScriptCore/wtf
584         https://bugs.webkit.org/show_bug.cgi?id=53747
585
586         By using these annotations we can improve the precision of finding
587         WebKit errors using dynamic analysis tools like ThreadSanitizer and Valgrind.
588         These annotations don't affect the compiled binaries unless USE(DYNAMIC_ANNOTATIONS) is "1".
589
590         These files don't add new functionality, so don't need extra tests.
591
592         * DumpRenderTree/ForwardingHeaders/wtf/DynamicAnnotations.h: Added.
593
594 2011-03-30  Steve Falkenburg  <sfalken@apple.com>
595
596         Reviewed by Adam Roben.
597
598         Share most vsprops between Release and Production builds in releaseproduction.vsprops
599         https://bugs.webkit.org/show_bug.cgi?id=57508
600
601         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops:
602         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginRelease.vsprops:
603         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseCairoCFLite.vsprops:
604         * DumpRenderTree/win/DumpRenderTreeProduction.vsprops:
605         * DumpRenderTree/win/DumpRenderTreeRelease.vsprops:
606         * DumpRenderTree/win/DumpRenderTreeReleaseCairoCFLite.vsprops:
607         * DumpRenderTree/win/ImageDiffProduction.vsprops:
608         * DumpRenderTree/win/ImageDiffRelease.vsprops:
609         * DumpRenderTree/win/ImageDiffReleaseCairoCFLite.vsprops:
610         * FindSafari/FindSafariProduction.vsprops:
611         * FindSafari/FindSafariRelease.vsprops:
612         * FindSafari/FindSafariReleaseCairoCFLite.vsprops:
613         * FindSafari/FindSafariReleasePGO.vsprops:
614         * MiniBrowser/Configurations/MiniBrowserProduction.vsprops:
615         * MiniBrowser/Configurations/MiniBrowserRelease.vsprops:
616         * MiniBrowser/Configurations/MiniBrowserReleaseCairoCFLite.vsprops:
617         * TestWebKitAPI/Configurations/TestWebKitAPIRelease.vsprops:
618         * TestWebKitAPI/Configurations/TestWebKitAPIReleaseCairoCFLite.vsprops:
619         * WebKitAPITest/WebKitAPITestProduction.vsprops:
620         * WebKitAPITest/WebKitAPITestRelease.vsprops:
621         * WebKitAPITest/WebKitAPITestReleaseCairoCFLite.vsprops:
622         * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops:
623         * WebKitLauncherWin/WebKitLauncherWinRelease.vsprops:
624         * WebKitLauncherWin/WebKitLauncherWinReleaseCairoCFLite.vsprops:
625         * WebKitTestRunner/win/InjectedBundleProduction.vsprops:
626         * WebKitTestRunner/win/InjectedBundleRelease.vsprops:
627         * WebKitTestRunner/win/InjectedBundleReleaseCairoCFLite.vsprops:
628         * WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops:
629         * WebKitTestRunner/win/WebKitTestRunnerRelease.vsprops:
630         * WebKitTestRunner/win/WebKitTestRunnerReleaseCairoCFLite.vsprops:
631         * WinLauncher/WinLauncherProduction.vsprops:
632         * WinLauncher/WinLauncherRelease.vsprops:
633         * WinLauncher/WinLauncherReleaseCairoCFLite.vsprops:
634         * record-memory-win/record-memory-winProduction.vsprops:
635         * record-memory-win/record-memory-winRelease.vsprops:
636         * record-memory-win/record-memory-winReleaseCairoCFLite.vsprops:
637
638 2011-03-30  Steve Falkenburg  <sfalken@apple.com>
639
640         Reviewed by Adam Roben.
641
642         Update Windows production build logic for new production configurations
643         https://bugs.webkit.org/show_bug.cgi?id=57494
644
645         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops:
646         * DumpRenderTree/win/DumpRenderTreeProduction.vsprops:
647         * DumpRenderTree/win/ImageDiffProduction.vsprops:
648         * FindSafari/FindSafariProduction.vsprops:
649         * FindSafari/FindSafariReleasePGO.vsprops:
650         * MiniBrowser/Configurations/MiniBrowserProduction.vsprops:
651         * WebKitAPITest/WebKitAPITestProduction.vsprops:
652         * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops:
653         * WebKitTestRunner/win/InjectedBundleProduction.vsprops:
654         * WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops:
655         * WinLauncher/WinLauncherProduction.vsprops:
656         * record-memory-win/record-memory-winProduction.vsprops:
657
658 2011-03-30  Robert Hogan  <robert@webkit.org>
659
660         Reviewed by Antonio Gomes.
661
662         [Qt] Fix LoadHTMLStringItem::invoke() after r75966
663         Unskip http/tests/navigation/go-back-to-error-page.html
664
665         Also add the location of DumpRenderTreeSupportQt.h
666         to DRT's include paths.
667
668         https://bugs.webkit.org/show_bug.cgi?id=52614
669
670         * DumpRenderTree/qt/DumpRenderTree.pro:
671         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
672         * DumpRenderTree/qt/DumpRenderTreeQt.h:
673         * DumpRenderTree/qt/GCControllerQt.cpp:
674         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
675         (LayoutTestController::queueLoadHTMLString):
676         * DumpRenderTree/qt/LayoutTestControllerQt.h:
677         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
678         * DumpRenderTree/qt/TextInputControllerQt.cpp:
679         * DumpRenderTree/qt/WorkQueueItemQt.cpp:
680         (LoadAlternateHTMLStringItem::invoke):
681         * DumpRenderTree/qt/WorkQueueItemQt.h:
682         (LoadAlternateHTMLStringItem::LoadAlternateHTMLStringItem):
683         * QtTestBrowser/QtTestBrowser.pro:
684         * QtTestBrowser/launcherwindow.h:
685
686 2011-03-30  Adam Barth  <abarth@webkit.org>
687
688         Reviewed by Adam Roben.
689
690         SheriffBot rollouts take too long
691         https://bugs.webkit.org/show_bug.cgi?id=57498
692
693         We used to build before landing rollouts via the commit-queue to
694         prevent further breakage, but now that our individual commit-queue
695         machines are slower, building takes too long.  I can't remember the
696         last time a rollout broke compile.  It seems like just landing the
697         patch is the better trade-off.
698
699         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
700         * Scripts/webkitpy/tool/commands/queues_unittest.py:
701
702 2011-03-30  Adam Barth  <abarth@webkit.org>
703
704         Remove platform/chromium-mac-snowleopard
705         https://bugs.webkit.org/show_bug.cgi?id=57486
706
707         This directory no longer exists, so we can remove it from the fallback
708         chain.
709
710         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
711
712 2011-03-30  Steve Falkenburg  <sfalken@apple.com>
713
714         Reviewed by Adam Roben.
715
716         Rename Windows configuration Release_LTCG to Production for clarity
717         https://bugs.webkit.org/show_bug.cgi?id=57465
718
719         * DumpRenderTree/DumpRenderTree.sln:
720         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
721         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops: Copied from Tools/DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseLTCG.vsprops.
722         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseLTCG.vsprops: Removed.
723         * DumpRenderTree/win/DumpRenderTree.vcproj:
724         * DumpRenderTree/win/DumpRenderTreeProduction.vsprops: Copied from Tools/DumpRenderTree/win/DumpRenderTreeReleaseLTCG.vsprops.
725         * DumpRenderTree/win/DumpRenderTreeReleaseLTCG.vsprops: Removed.
726         * DumpRenderTree/win/ImageDiff.vcproj:
727         * DumpRenderTree/win/ImageDiffProduction.vsprops: Copied from Tools/DumpRenderTree/win/ImageDiffReleaseLTCG.vsprops.
728         * DumpRenderTree/win/ImageDiffReleaseLTCG.vsprops: Removed.
729         * FindSafari/FindSafari.vcproj:
730         * FindSafari/FindSafariProduction.vsprops: Copied from Tools/FindSafari/FindSafariReleaseLTCG.vsprops.
731         * FindSafari/FindSafariReleaseLTCG.vsprops: Removed.
732         * MiniBrowser/Configurations/MiniBrowserProduction.vsprops: Copied from Tools/MiniBrowser/Configurations/MiniBrowserReleaseLTCG.vsprops.
733         * MiniBrowser/Configurations/MiniBrowserReleaseLTCG.vsprops: Removed.
734         * MiniBrowser/MiniBrowser.vcproj:
735         * Scripts/webkitdirs.pm:
736         * TestWebKitAPI/win/TestWebKitAPI.sln:
737         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
738         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
739         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
740         * WebKitAPITest/WebKitAPITest.vcproj:
741         * WebKitAPITest/WebKitAPITestProduction.vsprops: Copied from Tools/WebKitAPITest/WebKitAPITestReleaseLTCG.vsprops.
742         * WebKitAPITest/WebKitAPITestReleaseLTCG.vsprops: Removed.
743         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
744         * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops: Copied from Tools/WebKitLauncherWin/WebKitLauncherWinReleaseLTCG.vsprops.
745         * WebKitLauncherWin/WebKitLauncherWinReleaseLTCG.vsprops: Removed.
746         * WebKitTestRunner/WebKitTestRunner.sln:
747         * WebKitTestRunner/win/InjectedBundle.vcproj:
748         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj:
749         * WebKitTestRunner/win/InjectedBundleProduction.vsprops: Copied from Tools/WebKitTestRunner/win/InjectedBundleReleaseLTCG.vsprops.
750         * WebKitTestRunner/win/InjectedBundleReleaseLTCG.vsprops: Removed.
751         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
752         * WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops: Copied from Tools/WebKitTestRunner/win/WebKitTestRunnerReleaseLTCG.vsprops.
753         * WebKitTestRunner/win/WebKitTestRunnerReleaseLTCG.vsprops: Removed.
754         * WinLauncher/WinLauncher.vcproj:
755         * WinLauncher/WinLauncherProduction.vsprops: Copied from Tools/WinLauncher/WinLauncherReleaseLTCG.vsprops.
756         * WinLauncher/WinLauncherReleaseLTCG.vsprops: Removed.
757         * record-memory-win/record-memory-win.vcproj:
758         * record-memory-win/record-memory-winProduction.vsprops: Copied from Tools/record-memory-win/record-memory-winReleaseLTCG.vsprops.
759         * record-memory-win/record-memory-winReleaseLTCG.vsprops: Removed.
760
761 2011-03-30  MORITA Hajime  <morrita@google.com>
762
763         Reviewed by Dimitri Glazkov.
764
765         [Chromium] Expose the shadow DOM to DumpRenderTree JS tests.
766         https://bugs.webkit.org/show_bug.cgi?id=56573
767
768         Added LayoutTestController.shadowRoot() to Chromium DRT.
769
770         * DumpRenderTree/chromium/LayoutTestController.cpp:
771         (LayoutTestController::LayoutTestController):
772         (LayoutTestController::shadowRoot):
773         * DumpRenderTree/chromium/LayoutTestController.h:
774
775 2011-03-30  Yuta Kitamura  <yutak@chromium.org>
776
777         Reviewed by Kent Tamura.
778
779         [Chromium] DumpRenderTree: Implement LayoutTestController::setPluginsEnabled
780         https://bugs.webkit.org/show_bug.cgi?id=57430
781
782         * DumpRenderTree/chromium/LayoutTestController.cpp:
783         (LayoutTestController::LayoutTestController):
784         (LayoutTestController::setPluginsEnabled):
785         * DumpRenderTree/chromium/LayoutTestController.h:
786
787 2011-03-30  Maciej Stachowiak  <mjs@apple.com>
788
789         Reviewed by Adam Barth.
790
791         make webkit-patch upload respect -d
792         https://bugs.webkit.org/show_bug.cgi?id=57425
793
794         * Scripts/webkitpy/common/checkout/scm.py:
795         * Scripts/webkitpy/tool/steps/commit.py:
796
797 2011-03-30  Maciej Stachowiak  <mjs@apple.com>
798
799         Reviewed by Adam Barth.
800
801         Make "webkit-patch --dry-run --verbose land" log the SVN command it's going to use
802         https://bugs.webkit.org/show_bug.cgi?id=57429
803
804         * Scripts/webkitpy/common/checkout/scm.py:
805
806 2011-03-29  Sheriff Bot  <webkit.review.bot@gmail.com>
807
808         Unreviewed, rolling out r82383.
809         http://trac.webkit.org/changeset/82383
810         https://bugs.webkit.org/show_bug.cgi?id=57417
811
812         "nrwt isn't shutting down cleanly" (Requested by dpranke on
813         #webkit).
814
815         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
816         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
817         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
818
819 2011-03-29  Kent Tamura  <tkent@chromium.org>
820
821         Reviewed by Dimitri Glazkov.
822
823         Make validation message bubble testable
824         https://bugs.webkit.org/show_bug.cgi?id=57290
825
826         * DumpRenderTree/mac/DumpRenderTree.mm:
827         (createWebViewAndOffscreenWindow): Change a setting so that validation
828           bubbles isn't hidden automatically.
829
830 2011-03-29  Dirk Pranke  <dpranke@chromium.org>
831
832         Reviewed by Ojan Vafai.
833
834         new-run-webkit-tests: use 'threads' on win instead of 'old-threads'
835
836         It's a bit unclear whether multiple threads or multiple
837         processes will be a better model on windows. This change will
838         test threads for now while we're still working out the bugs in
839         multiple-processes.
840
841         https://bugs.webkit.org/show_bug.cgi?id=57410
842
843         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
844         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
845         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
846
847 2011-03-29  David Levin  <levin@chromium.org>
848
849         Reviewed by Shinichiro Hamaji.
850
851         check-webkit-style confused by two ChangeLog entries in a row from same user
852         https://bugs.webkit.org/show_bug.cgi?id=57250
853
854         * Scripts/webkitpy/style/checker.py: Add the line should be checked function to ChangeLogChecker.
855         * Scripts/webkitpy/style/checker_unittest.py: Fix test due to that new function.
856         * Scripts/webkitpy/style/checkers/changelog.py: Made this code aware of what lines were being checked.
857           It basically assumes only one ChangeLog entry is being processed because that is the standard case and
858           checking more than that would be very messey.
859         * Scripts/webkitpy/style/checkers/changelog_unittest.py: Add testing to catch the broken case.
860         * Scripts/webkitpy/style/error_handlers.py: Added should_line_be_checked.
861
862 2011-03-29  Kent Tamura  <tkent@chromium.org>
863
864         Reviewed by Dimitri Glazkov.
865
866         [Mac] Enable interactive-validation tests on Mac DRT
867         https://bugs.webkit.org/show_bug.cgi?id=57308
868
869         * DumpRenderTree/mac/DumpRenderTree.mm:
870         (createWebViewAndOffscreenWindow): Enable the form interactive validation feature.
871
872 2011-03-29  Chang Shu  <cshu@webkit.org>
873
874         Reviewed by Kenneth Rohde Christiansen.
875
876         WebKitTestRunner needs layoutTestController.setAllowUniversalAccessFromFileURLs
877         https://bugs.webkit.org/show_bug.cgi?id=42692
878
879         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
880         (WTR::InjectedBundle::beginTesting):
881         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
882         (WTR::LayoutTestController::setAllowUniversalAccessFromFileURLs):
883         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
884
885 2011-03-24  Martin Robinson  <mrobinson@igalia.com>
886
887         Reviewed by Xan Lopez.
888
889         [GTK] [DRT] GtkScrolledWindow adds three pixels of padding between the WebView and the scrollbar
890         https://bugs.webkit.org/show_bug.cgi?id=57067
891
892         Eliminate extra spacing between the DRT GtkScrolledWindow and the DRT WebView. This
893         will allow WebKit1GTK+ and WebKit2GTK+ to share test results. Followup commits will
894         update DRT and pixel results as hundreds of results will need to be updated.
895
896         * DumpRenderTree/gtk/DumpRenderTree.cpp:
897         (setDefaultsToConsistentStateValuesForTesting): Eliminate spacing on the GtkScrolledWindow
898         by overriding the theme RC/CSS files.
899
900 2011-03-29  Steve Falkenburg  <sfalken@apple.com>
901
902         Reviewed by Adam Roben.
903
904         Use per-configuration vsprops in tools projects to avoid WebKitVSPropsRedirectionDir removal by MSVC IDE
905         https://bugs.webkit.org/show_bug.cgi?id=57394
906
907         Visual Studio's IDE was removing instances of $(WebKitVSPropsRedirectionDir) from
908         InheritedPropertySheet rules in our vcproj files when the vcproj was edited from within
909         the IDE. To avoid this, add a separate vsprops file for each project configuration that
910         contains the required inherited property sheets.
911
912         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
913         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebug.vsprops: Added.
914         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugAll.vsprops: Added.
915         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugCairoCFLite.vsprops: Added.
916         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginRelease.vsprops: Added.
917         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseCairoCFLite.vsprops: Added.
918         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseLTCG.vsprops: Added.
919         * DumpRenderTree/win/DumpRenderTree.vcproj:
920         * DumpRenderTree/win/DumpRenderTreeDebug.vsprops: Added.
921         * DumpRenderTree/win/DumpRenderTreeDebugAll.vsprops: Added.
922         * DumpRenderTree/win/DumpRenderTreeDebugCairoCFLite.vsprops: Added.
923         * DumpRenderTree/win/DumpRenderTreeRelease.vsprops: Added.
924         * DumpRenderTree/win/DumpRenderTreeReleaseCairoCFLite.vsprops: Added.
925         * DumpRenderTree/win/DumpRenderTreeReleaseLTCG.vsprops: Added.
926         * DumpRenderTree/win/ImageDiff.vcproj:
927         * DumpRenderTree/win/ImageDiffDebug.vsprops: Added.
928         * DumpRenderTree/win/ImageDiffDebugAll.vsprops: Added.
929         * DumpRenderTree/win/ImageDiffDebugCairoCFLite.vsprops: Added.
930         * DumpRenderTree/win/ImageDiffRelease.vsprops: Added.
931         * DumpRenderTree/win/ImageDiffReleaseCairoCFLite.vsprops: Added.
932         * DumpRenderTree/win/ImageDiffReleaseLTCG.vsprops: Added.
933         * FindSafari/FindSafari.vcproj:
934         * FindSafari/FindSafariDebug.vsprops: Added.
935         * FindSafari/FindSafariDebugAll.vsprops: Added.
936         * FindSafari/FindSafariDebugCairoCFLite.vsprops: Added.
937         * FindSafari/FindSafariRelease.vsprops: Added.
938         * FindSafari/FindSafariReleaseCairoCFLite.vsprops: Added.
939         * FindSafari/FindSafariReleaseLTCG.vsprops: Added.
940         * FindSafari/FindSafariReleasePGO.vsprops: Added.
941         * MiniBrowser/Configurations/MiniBrowserDebug.vsprops: Added.
942         * MiniBrowser/Configurations/MiniBrowserDebugAll.vsprops: Added.
943         * MiniBrowser/Configurations/MiniBrowserDebugCairoCFLite.vsprops: Added.
944         * MiniBrowser/Configurations/MiniBrowserRelease.vsprops: Added.
945         * MiniBrowser/Configurations/MiniBrowserReleaseCairoCFLite.vsprops: Added.
946         * MiniBrowser/Configurations/MiniBrowserReleaseLTCG.vsprops: Added.
947         * MiniBrowser/MiniBrowser.vcproj:
948         * WebKitAPITest/WebKitAPITest.vcproj:
949         * WebKitAPITest/WebKitAPITestDebug.vsprops: Added.
950         * WebKitAPITest/WebKitAPITestDebugAll.vsprops: Added.
951         * WebKitAPITest/WebKitAPITestDebugCairoCFLite.vsprops: Added.
952         * WebKitAPITest/WebKitAPITestRelease.vsprops: Added.
953         * WebKitAPITest/WebKitAPITestReleaseCairoCFLite.vsprops: Added.
954         * WebKitAPITest/WebKitAPITestReleaseLTCG.vsprops: Added.
955         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
956         * WebKitLauncherWin/WebKitLauncherWinDebug.vsprops: Added.
957         * WebKitLauncherWin/WebKitLauncherWinDebugAll.vsprops: Added.
958         * WebKitLauncherWin/WebKitLauncherWinDebugCairoCFLite.vsprops: Added.
959         * WebKitLauncherWin/WebKitLauncherWinRelease.vsprops: Added.
960         * WebKitLauncherWin/WebKitLauncherWinReleaseCairoCFLite.vsprops: Added.
961         * WebKitLauncherWin/WebKitLauncherWinReleaseLTCG.vsprops: Added.
962         * WebKitTestRunner/win/InjectedBundle.vcproj:
963         * WebKitTestRunner/win/InjectedBundleDebug.vsprops: Added.
964         * WebKitTestRunner/win/InjectedBundleDebugAll.vsprops: Added.
965         * WebKitTestRunner/win/InjectedBundleDebugCairoCFLite.vsprops: Added.
966         * WebKitTestRunner/win/InjectedBundleRelease.vsprops: Added.
967         * WebKitTestRunner/win/InjectedBundleReleaseCairoCFLite.vsprops: Added.
968         * WebKitTestRunner/win/InjectedBundleReleaseLTCG.vsprops: Added.
969         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
970         * WebKitTestRunner/win/WebKitTestRunnerDebug.vsprops: Added.
971         * WebKitTestRunner/win/WebKitTestRunnerDebugAll.vsprops: Added.
972         * WebKitTestRunner/win/WebKitTestRunnerDebugCairoCFLite.vsprops: Added.
973         * WebKitTestRunner/win/WebKitTestRunnerRelease.vsprops: Added.
974         * WebKitTestRunner/win/WebKitTestRunnerReleaseCairoCFLite.vsprops: Added.
975         * WebKitTestRunner/win/WebKitTestRunnerReleaseLTCG.vsprops: Added.
976         * WinLauncher/WinLauncher.vcproj:
977         * WinLauncher/WinLauncherDebug.vsprops: Added.
978         * WinLauncher/WinLauncherDebugAll.vsprops: Added.
979         * WinLauncher/WinLauncherDebugCairoCFLite.vsprops: Added.
980         * WinLauncher/WinLauncherRelease.vsprops: Added.
981         * WinLauncher/WinLauncherReleaseCairoCFLite.vsprops: Added.
982         * WinLauncher/WinLauncherReleaseLTCG.vsprops: Added.
983         * record-memory-win/record-memory-win.vcproj:
984         * record-memory-win/record-memory-winDebug.vsprops: Added.
985         * record-memory-win/record-memory-winDebugAll.vsprops: Added.
986         * record-memory-win/record-memory-winDebugCairoCFLite.vsprops: Added.
987         * record-memory-win/record-memory-winRelease.vsprops: Added.
988         * record-memory-win/record-memory-winReleaseCairoCFLite.vsprops: Added.
989         * record-memory-win/record-memory-winReleaseLTCG.vsprops: Added.
990
991 2011-03-29  Adam Barth  <abarth@webkit.org>
992
993         Reviewed by Darin Adler.
994
995         test_runner2.py can crash due to undefined variable
996         https://bugs.webkit.org/show_bug.cgi?id=57356
997
998         Replace reference to undefined variable with a variable that's actually
999         defined.  AFAICT, there's no way to test this code.
1000
1001         * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
1002
1003 2011-03-29  Tony Chang  <tony@chromium.org>
1004
1005         Reviewed by Eric Seidel.
1006
1007         cleanup rebaseline-chromium-webkit-tests
1008         https://bugs.webkit.org/show_bug.cgi?id=57375
1009
1010         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1011             - Split _extract_and_add_new_baselines into 3 functions
1012             - Reduce the amount of line wrapping (the file already has lines
1013               over 80 col, so may as well try to make the file consistent)
1014             - Remove unnecessary ()s
1015
1016 2011-03-29  Brent Fulgham  <bfulgham@webkit.org>
1017
1018         Reviewed by Adam Roben.
1019
1020         Make WinCairo a core builder.
1021         https://bugs.webkit.org/show_bug.cgi?id=57373
1022
1023         * Scripts/webkitpy/common/net/buildbot/buildbot.py: Add WinCairo.
1024         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py: Add WinCairo.
1025
1026 2011-03-29  Timothy Hatcher  <timothy@apple.com>
1027
1028         Update update-webkit-localizable-strings to understand that WebKit and
1029         WebKit2 strings go in WebCore.
1030
1031         Also make extract-localizable-strings optionally use an exclude file. No individual
1032         warnings are produced about unlocalized strings when there is no exclude file. This
1033         is needed for WebCore, since there are too many bare strings.
1034
1035         https://webkit.org/b/57354
1036
1037         Reviewed by Sam Weinig.
1038
1039         * Scripts/extract-localizable-strings: Support "-" to mean no exclude file.
1040         * Scripts/update-webkit-localizable-strings: Update paths to scan WebCore and WebKit2.
1041
1042 2011-03-29  Darin Adler  <darin@apple.com>
1043
1044         Reviewed by Adam Roben.
1045
1046         WebKit2 bundle page needs to offer generated file hooks
1047         https://bugs.webkit.org/show_bug.cgi?id=57279
1048
1049         (Land missing part of the original patch after r82289.)
1050
1051         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1052         (WTR::InjectedBundlePage::InjectedBundlePage): Added new callbacks.
1053
1054 2011-03-29  Tony Chang  <tony@chromium.org>
1055
1056         Reviewed by Ojan Vafai.
1057
1058         [chromium] NRWT should be able to read checksums from png comments
1059         https://bugs.webkit.org/show_bug.cgi?id=57280
1060
1061         * Scripts/read-checksum-from-png: Added. Utility script to read the checksum
1062             from a file.
1063         * Scripts/webkitpy/common/system/filesystem.py: Add open_binary_file_for_reading
1064         * Scripts/webkitpy/common/system/filesystem_mock.py:
1065         * Scripts/webkitpy/layout_tests/port/base.py: When loading a checksum,
1066             if the -checksum.txt file doesn't exist, try looking in the png.
1067         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1068         * Scripts/webkitpy/layout_tests/port/test.py:
1069         * Scripts/webkitpy/layout_tests/read_checksum_from_png.py: Added. Scan the first
1070             2k for a png comment with the checksum
1071         * Scripts/webkitpy/layout_tests/read_checksum_from_png_unittest.py: Added.
1072
1073 2011-03-29  Philippe Normand  <pnormand@igalia.com>
1074
1075         Rubber-stamped by Gustavo Noronha Silva.
1076
1077         [GTK] http/tests/uri/username-with-no-hostname.html fails
1078         https://bugs.webkit.org/show_bug.cgi?id=57325
1079
1080         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1081         (willSendRequestCallback): URI host value check done case-insensitively.
1082
1083 2011-03-29  Philippe Normand  <pnormand@igalia.com>
1084
1085         Reviewed by Martin Robinson.
1086
1087         [GTK] http/tests/uri/username-with-no-hostname.html fails
1088         https://bugs.webkit.org/show_bug.cgi?id=57325
1089
1090         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1091         (willSendRequestCallback): Check URI before submitting the request
1092         to WebCore.
1093
1094 2011-03-29  Noel Gordon  <noel.gordon@gmail.com>
1095
1096         Reviewed by Ojan Vafai.
1097
1098         [chromium] DRT EventSender: remove identity from dragTargetDragEnter() calls
1099         https://bugs.webkit.org/show_bug.cgi?id=57303
1100
1101         * DumpRenderTree/chromium/EventSender.cpp:
1102         (EventSender::doDragDrop):
1103         (EventSender::beginDragWithFiles):
1104
1105 2011-03-29  Zoltan Horvath  <zoltan@webkit.org>
1106
1107         Reviewed by Andreas Kling.
1108
1109         [Qt] Add -print-loaded-urls option to Qt's MiniBrowser and to QtTestBrowser
1110         https://bugs.webkit.org/show_bug.cgi?id=57314
1111
1112         Provide possibility to print loaded urls to the standard output.
1113
1114         * MiniBrowser/qt/BrowserWindow.cpp:
1115         (BrowserWindow::BrowserWindow):
1116         (BrowserWindow::printURL):
1117         * MiniBrowser/qt/BrowserWindow.h:
1118         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1119         (MiniBrowserApplication::handleUserOptions):
1120         * MiniBrowser/qt/MiniBrowserApplication.h:
1121         (WindowOptions::WindowOptions):
1122         * QtTestBrowser/launcherwindow.cpp:
1123         (LauncherWindow::initializeView):
1124         (LauncherWindow::printURL):
1125         (LauncherWindow::cloneWindow):
1126         * QtTestBrowser/launcherwindow.h:
1127         (WindowOptions::WindowOptions):
1128         * QtTestBrowser/main.cpp:
1129         (LauncherApplication::handleUserOptions):
1130
1131 2011-03-29  Gabor Loki  <loki@webkit.org>
1132
1133         Rubber-stamped by Csaba Osztrogonác.
1134
1135         [Qt] Teach build-jsc how to build JavaScriptCore on Qt
1136         https://bugs.webkit.org/show_bug.cgi?id=56918
1137
1138         * Scripts/build-jsc: Remove duplicated --qt options to avoid passing them to qmake.
1139
1140 2011-03-28  Gabor Loki  <loki@webkit.org>
1141
1142         Reviewed by Csaba Osztrogonác.
1143
1144         [Qt] Teach build-jsc how to build JavaScriptCore on Qt
1145         https://bugs.webkit.org/show_bug.cgi?id=56918
1146
1147         * Scripts/build-jsc:
1148         * Scripts/webkitdirs.pm:
1149
1150 2011-03-28  Andrew Foster  <andrewf@chromium.org>
1151
1152         Reviewed by Ojan Vafai.
1153
1154         webkit-patch should be more intelligent about whether a bug applies to a patch
1155         Create a new function, parse_bug_id_from_changelog() which determines
1156         that a bug is related to a patch by parsing the output generated from
1157         prepare-ChangeLog, rather than arbitrarily matching a URL to a bug in
1158         the description of a patch.
1159         https://bugs.webkit.org/show_bug.cgi?id=56989
1160
1161         * Scripts/webkitpy/common/checkout/api.py:
1162         * Scripts/webkitpy/common/checkout/changelog.py:
1163         * Scripts/webkitpy/common/net/bugzilla/__init__.py:
1164         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1165         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
1166         * Scripts/webkitpy/style/checkers/changelog.py:
1167         * Scripts/webkitpy/tool/commands/upload.py:
1168
1169 2011-03-28  Maciej Stachowiak  <mjs@apple.com>
1170
1171         Revert accidentally commited change.
1172
1173         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1174         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
1175
1176 2011-03-28  Tony Chang  <tony@chromium.org>
1177
1178         Reviewed by Adam Barth.
1179
1180         [chromium] have DRT write the png checksum into a png comment
1181         https://bugs.webkit.org/show_bug.cgi?id=57255
1182
1183         * DumpRenderTree/chromium/TestShell.cpp:
1184         (TestShell::dumpImage):
1185
1186 2011-03-28  Adele Peterson  <adele@apple.com>
1187
1188         Removing Qt stub, since it doesn't use the same header as the others.
1189
1190         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1191
1192 2011-03-28  Adele Peterson  <adele@apple.com>
1193
1194         Added a few more stubs.
1195
1196         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1197         (LayoutTestController::hasGrammarMarker):
1198         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1199         (LayoutTestController::hasGrammarMarker):
1200         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1201         (LayoutTestController::hasGrammarMarker):
1202
1203 2011-03-28  Adele Peterson  <adele@apple.com>
1204
1205         Build fix.
1206
1207         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1208         (LayoutTestController::hasGrammarMarker):
1209
1210 2011-03-28  Adele Peterson  <adele@apple.com>
1211
1212         Reviewed by Eric Seidel.
1213
1214         Testing support for <rdar://problem/9112694> REGRESSION (r79411): "Check grammar with spelling" context menu doesn't check as you type
1215         https://bugs.webkit.org/show_bug.cgi?id=57173
1216
1217         * DumpRenderTree/LayoutTestController.cpp:
1218         (hasGrammarMarkerCallback): Added.
1219         (LayoutTestController::staticFunctions): Added case for hasGrammarMarker.
1220         * DumpRenderTree/LayoutTestController.h:
1221         * DumpRenderTree/mac/DumpRenderTree.mm: (createWebViewAndOffscreenWindow): Call setGrammarCheckingEnabled.
1222         * DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::hasGrammarMarker): Added. Call new hasGrammarMarker method.
1223
1224 2011-03-28  Csaba Osztrogonác  <ossy@webkit.org>
1225
1226         Reviewed by Benjamin Poulain.
1227
1228         [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
1229         https://bugs.webkit.org/show_bug.cgi?id=57087
1230
1231         Trivial typo fix after r82082.
1232
1233         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1234         (WTR::activateFonts):
1235
1236 2011-03-28  Alexis Menard  <alexis.menard@openbossa.org>
1237
1238         Reviewed by Andreas Kling.
1239
1240         Add myself to the committers list.
1241
1242         * Scripts/webkitpy/common/config/committers.py:
1243
1244 2011-03-28  Simon Fraser  <simon.fraser@apple.com>
1245
1246         Reviewed by Sam Weinig.
1247
1248         WebKit2 unfortunately uses code from WebKit, so MiniBrowser needs
1249         to link against WebKit.framework for now.
1250
1251         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
1252
1253 2011-03-28  Benjamin Poulain  <benjamin.poulain@nokia.com>
1254
1255         Reviewed by Andreas Kling.
1256
1257         [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
1258         https://bugs.webkit.org/show_bug.cgi?id=57087
1259
1260         Disable QT_ASCII_CAST_WARNINGS for applications.
1261
1262         * DumpRenderTree/qt/DumpRenderTree.pro:
1263         * DumpRenderTree/qt/ImageDiff.pro:
1264         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1265         * MiniBrowser/qt/MiniBrowser.pro:
1266         * QtTestBrowser/QtTestBrowser.pro:
1267         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1268
1269 2011-03-28  Andreas Kling  <kling@webkit.org>
1270
1271         Reviewed by Kenneth Rohde Christiansen.
1272
1273         [Qt] QtTestBrowser doesn't reset its window title when opening about:blank
1274         https://bugs.webkit.org/show_bug.cgi?id=57224
1275
1276         * QtTestBrowser/mainwindow.cpp:
1277         (MainWindow::buildUI):
1278         (MainWindow::onTitleChanged):
1279         * QtTestBrowser/mainwindow.h:
1280
1281 2011-03-27  Jer Noble  <jer.noble@apple.com>
1282
1283         Reviewed by Maciej Stachowiak.
1284
1285         Full Screen: disable keyboard access by default
1286         https://bugs.webkit.org/show_bug.cgi?id=56684
1287
1288         Accept the withKeyboard parameter to supportsFullScreenForElement.
1289
1290         * DumpRenderTree/mac/UIDelegate.mm:
1291         (-[UIDelegate webView:supportsFullScreenForElement:withKeyboard:]):
1292
1293 2011-03-27  Patrick Gansterer  <paroga@webkit.org>
1294
1295         Reviewed by David Levin.
1296
1297         check-webkit-style should check ChangeLog for a valid bug number
1298         https://bugs.webkit.org/show_bug.cgi?id=57184
1299
1300         * Scripts/webkitpy/style/checker.py:
1301         * Scripts/webkitpy/style/checker_unittest.py:
1302         * Scripts/webkitpy/style/checkers/changelog.py: Added.
1303         * Scripts/webkitpy/style/checkers/changelog_unittest.py: Added.
1304
1305 2011-03-27  Benjamin Poulain  <benjamin.poulain@nokia.com>
1306
1307         Reviewed by Andreas Kling.
1308
1309         [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
1310         https://bugs.webkit.org/show_bug.cgi?id=57087
1311
1312         Use explicit conversion for string to avoid depending on the default codec
1313         installed by the user code.
1314
1315         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1316         (WTR::activateFonts):
1317
1318 2011-03-26  Maciej Stachowiak  <mjs@apple.com>
1319
1320         Revert inadvertantly committed changes.
1321
1322         * Scripts/old-run-webkit-tests:
1323         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1324
1325 2011-03-26  Andreas Kling  <kling@webkit.org>
1326
1327         Reviewed by Kenneth Rohde Christiansen.
1328
1329         [Qt] Show page icons (favicons) in QtTestBrowser location bar.
1330         https://bugs.webkit.org/show_bug.cgi?id=57162
1331
1332         * QtTestBrowser/QtTestBrowser.qrc:
1333         * QtTestBrowser/favicon.png: Added.
1334         * QtTestBrowser/locationedit.cpp:
1335         (defaultPageIcon):
1336         (LocationEdit::LocationEdit):
1337         (LocationEdit::setPageIcon):
1338         (LocationEdit::resizeEvent):
1339         (LocationEdit::updateInternalGeometry):
1340         * QtTestBrowser/locationedit.h:
1341         * QtTestBrowser/mainwindow.cpp:
1342         (MainWindow::buildUI):
1343         (MainWindow::onIconChanged):
1344         (MainWindow::onLoadStarted):
1345         * QtTestBrowser/mainwindow.h:
1346
1347 2011-03-23  Martin Robinson  <mrobinson@igalia.com>
1348
1349         Reviewed by Xan Lopez.
1350
1351         [GTK] Force DumpRenderTree to use 96 DPI
1352         https://bugs.webkit.org/show_bug.cgi?id=56866
1353
1354         Make sure that GTK+ is set to use 96 DPI when running tests. This ensures
1355         broader compatibility with WebKit2 and makes setting font sizes more straightforward.
1356
1357         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1358         (initializeGtkFontSettings): Set the screen resolution and GTK+ xft property to 96 DPI.
1359         (resetDefaultsToConsistentValues):Remove the call which repeatedly set the GDK screen resolution.
1360         (setDefaultsToConsistentStateValuesForTesting): Update the font sizes to reflect the new DPI.
1361
1362 2011-03-25  Andy Estes  <aestes@apple.com>
1363
1364         Reviewed by Adele Peterson.
1365
1366         REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
1367         https://bugs.webkit.org/show_bug.cgi?id=49016
1368
1369         TestNetscapePlugIn needs to register support for an image MIME type so
1370         we can test that the embed tag prefers plug-ins to render image MIME
1371         types.
1372
1373         * DumpRenderTree/TestNetscapePlugIn/mac/Info.plist: Register image/png.
1374         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1375         (NP_GetMIMEDescription): Ditto.
1376         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Ditto.
1377
1378 2011-03-25  Jessie Berlin  <jberlin@apple.com>
1379
1380         Reviewed by Sam Weinig.
1381
1382         WebKit2: Need to be able to set and get the Cookie Storage Policy.
1383         https://bugs.webkit.org/show_bug.cgi?id=50780
1384
1385         Add a test for getting and setting the HTTP Cookie Accept Policy in WebKit2.
1386
1387         The test is named "CookieManager" so that we can eventually exercise more of the
1388         CookieManager functionality in the test.
1389
1390         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp: Added.
1391         (TestWebKitAPI::didGetTestHTTPCookieAcceptPolicy):
1392         Assert that the policy returned is equal to the policy set in
1393         didGetUserHTTPCookieAcceptPolicy, and then restore the user's policy.
1394         (TestWebKitAPI::didGetUserHTTPCookieAcceptPolicy):
1395         Set the policy to something different than the user's policy and get the policy again.
1396         (TestWebKitAPI::didFinishLoadForFrame):
1397         Get the user's policy so that it can be restored at the end of the test.
1398         (TestWebKitAPI::TEST):
1399         Load about:blank so that the Web Process gets instatiated (needed to get the
1400         CookieManager).
1401
1402         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1403         Add CookieManager.cpp.
1404
1405 2011-03-24  Kevin Ollivier  <kevino@theolliviers.com>
1406
1407         [wx] Fix the build so that gcc-4.1 and up can be used to build on SnowLeopard.
1408
1409         * wx/build/settings.py:
1410
1411 2011-03-24  Ilya Sherman  <isherman@chromium.org>
1412
1413         Reviewed by Adam Roben.
1414
1415         Implement layoutTestController.setAutoFilled in DRT on Windows
1416         https://bugs.webkit.org/show_bug.cgi?id=56828
1417
1418         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1419         (LayoutTestController::setAutofilled): Implemented.
1420
1421 2011-03-24  Brent Fulgham  <bfulgham@webkit.org>
1422
1423         Unreviewed build correction.
1424
1425         Correct vsprops file for Debug variant of the CFLite build.
1426         Disable a CFNETWORK-specific test when building for CFLite.
1427
1428         * TestWebKitAPI/Configurations/TestWebKitAPIDebugCairoCFLite.vsprops:
1429         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1430
1431 2011-03-24  Dirk Pranke  <dpranke@chromium.org>
1432
1433         Reviewed by Adam Barth.
1434
1435         fix regressions introduced in 81908 - there were a couple of
1436         code paths that only fired under python 2.5 that I missed.
1437
1438         Also change a couple of 'python' references to sys.executable
1439         in order to handle runing test-webkitpy with a binary other than
1440         something called 'python'.
1441
1442         https://bugs.webkit.org/show_bug.cgi?id=57063
1443
1444         * Scripts/webkitpy/layout_tests/port/mac.py:
1445         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1446         * Scripts/webkitpy/test/cat.py:
1447         * Scripts/webkitpy/test/echo.py:
1448
1449 2011-03-24  Brent Fulgham  <bfulgham@webkit.org>
1450
1451         Unreviewed build correction.
1452
1453         Add a stub implementation of the TestInvocation dumping logic.
1454         Update project files to reflect new file.
1455
1456         * WebKitTestRunner/cairo: Added.
1457         * WebKitTestRunner/cairo/TestInvocationCairo.cpp: Added.
1458         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1459         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1460
1461 2011-03-24  Dirk Pranke  <dpranke@chromium.org>
1462
1463         Reviewed by Tony Chang.
1464
1465         new-run-webkit-tests: clean up worker model defaults. This
1466         changes the default behavior to 'threads' instead of
1467         'old-threads', and clarifies that chromium-win-* and
1468         chromium-mac-leopard are exceptions.
1469
1470         https://bugs.webkit.org/show_bug.cgi?id=56971
1471
1472         * Scripts/webkitpy/layout_tests/port/base.py:
1473         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1474         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1475         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1476         * Scripts/webkitpy/layout_tests/port/test.py:
1477         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1478
1479 2011-03-23  Leandro Gracia Gil  <leandrogracia@chromium.org>
1480
1481         Reviewed by Darin Adler.
1482
1483         Media Stream API: fix the order of the options in build-webkit.
1484         https://bugs.webkit.org/show_bug.cgi?id=56949
1485
1486         Fix the order of the options in build-webkit.
1487
1488         * Scripts/build-webkit:
1489
1490 2011-03-23  Adam Klein  <adamk@chromium.org>
1491
1492         Reviewed by Mihai Parparita.
1493
1494         Add an option to new-run-webkit-httpd to allow overriding the location of LayoutTests directory
1495         https://bugs.webkit.org/show_bug.cgi?id=56884
1496
1497         This option will be utilized by Chromium's ui_tests to allow
1498         referencing js-test-resources from a layout test over HTTP.
1499
1500         * Scripts/new-run-webkit-httpd:
1501         Added --layout_tests_dir option.
1502         * Scripts/webkitpy/layout_tests/port/http_server.py:
1503         Plumbed through as layout_tests_dir param.
1504
1505 2011-03-23  Dirk Pranke  <dpranke@chromium.org>
1506
1507         Reviewed by Mihai Parparita.
1508
1509         new-run-webkit-tests: run tests in ascending alphabetical order per
1510         dir. This is a second attempt at the fix; the first attempt, in 
1511         r81597, broke the behavior on the old-inline and old-threads
1512         worker models.
1513
1514         https://bugs.webkit.org/show_bug.cgi?id=56760
1515
1516         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1517         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1518         * Scripts/webkitpy/layout_tests/port/test.py:
1519         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1520
1521 2011-03-23  Mario Sanchez Prada  <msanchez@igalia.com>
1522
1523         Reviewed by Martin Robinson.
1524
1525         [GTK] GTK's DRT to ouput detail's string for the 'property-change' signal
1526         https://bugs.webkit.org/show_bug.cgi?id=56953
1527
1528         Print the string for the detail of 'property-change' signal.
1529
1530         * DumpRenderTree/gtk/AccessibilityCallbacks.cpp:
1531         (axObjectEventListener): Print the detail string.
1532
1533 2011-03-23  Yury Semikhatsky  <yurys@chromium.org>
1534
1535         Reviewed by Pavel Feldman.
1536
1537         [V8] Web Inspector: compile DebuggerScript.js into DebuggerScriptSource.h
1538         https://bugs.webkit.org/show_bug.cgi?id=56843
1539
1540         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
1541         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
1542
1543 2011-03-22  Eric Seidel  <eric@webkit.org>
1544
1545         Reviewed by Adam Barth.
1546
1547         Teach update-webkit about gyp
1548         https://bugs.webkit.org/show_bug.cgi?id=56881
1549
1550         This makes it possible for someone who builds from Xcode
1551         to just run update-webkit --gyp and have the project files
1552         generated after update automatically.
1553
1554         I also added a stand-alone "generate-project-files" script
1555         wrapping Source/gyp/configure.  This makes running gyp simpler
1556         since most people will not have gyp or Source/gyp in their path.
1557
1558         * Scripts/build-webkit:
1559         * Scripts/generate-project-files: Added.
1560         * Scripts/update-webkit:
1561
1562 2011-03-22  Anton D'Auria  <adauria@apple.com>
1563
1564         Reviewed by Alexey Proskuryakov.
1565
1566         Add +[WebApplicationCache getOriginsWithCache]
1567         https://bugs.webkit.org/show_bug.cgi?id=56722
1568
1569         * DumpRenderTree/LayoutTestController.cpp:
1570         (originsWithApplicationCacheCallback):
1571         (LayoutTestController::staticFunctions):
1572         * DumpRenderTree/LayoutTestController.h:
1573         * DumpRenderTree/chromium/LayoutTestController.cpp: Added stub.
1574         (LayoutTestController::originsWithApplicationCache):
1575         * DumpRenderTree/chromium/LayoutTestController.h:
1576         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added stub.
1577         (LayoutTestController::originsWithApplicationCache):
1578         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Pass array of origin's database identifiers.
1579         (originsArrayToJS): Helper function for converting array of WebSecurityOrigins to a JS array of origin identifiers.
1580         (LayoutTestController::originsWithApplicationCache):
1581         (LayoutTestController::originsWithLocalStorage):
1582         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added stub.
1583         (LayoutTestController::originsWithApplicationCache):
1584         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1585         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Added stub.
1586         (LayoutTestController::originsWithApplicationCache):
1587         * DumpRenderTree/wx/LayoutTestControllerWx.cpp: Added stub.
1588         (LayoutTestController::originsWithApplicationCache):
1589
1590 2011-03-22  Eric Seidel  <eric@webkit.org>
1591
1592         Reviewed by Adam Barth.
1593
1594         Add support to build-webkit for building with gyp-generated project files
1595         https://bugs.webkit.org/show_bug.cgi?id=56877
1596
1597         build-webkit is a cesspool.  This change just hacks in --gyp support for Mac.
1598         Eventually we'll want to support gyp-generated projects in a more general manner.
1599
1600         * Scripts/build-webkit:
1601
1602 2011-03-22  David Kilzer  <ddkilzer@apple.com>
1603
1604         <http://webkit.org/b/56781> Add --dsym switch to enable dsym generation when building with Xcode
1605
1606         Reviewed by Joseph Pecoraro.
1607
1608         * Scripts/build-webkit: Updated usage statement to include
1609         --dsym.
1610         * Scripts/webkitdirs.pm: Added $generateDsym variable.
1611         (generateDsym): Added. Call determineGenerateDsym() and
1612         return $generateDsym.
1613         (determineGenerateDsym): Added.  Parse @ARGV for --dsym and set
1614         $generateDsym.
1615         (argumentsForXcode): Added.  Returns additional arguments for
1616         xcodebuild based on command-line switches.
1617         (XcodeOptions): Updated to include argumentsForXcode() in the
1618         array returned.
1619
1620 2011-03-22  Adam Roben  <aroben@apple.com>
1621
1622         Make Leopard Debug bots and Windows XP Debug (Tests) core builders
1623
1624         These bots are consistently green again.
1625
1626         Fixes <http://webkit.org/b/56830> Leopard Debug bots and Windows XP Debug (Tests) should be
1627         core builders
1628
1629         Rubber-stamped by Antti Koivisto.
1630
1631         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1632         (BuildBot.__init__): Loosened the regexps for Leopard and Windows.
1633
1634         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1635         (BuildBotTest.test_builder_name_regexps): Updated expectations.
1636
1637 2011-03-21  Sheriff Bot  <webkit.review.bot@gmail.com>
1638
1639         Unreviewed, rolling out r81597.
1640         http://trac.webkit.org/changeset/81597
1641         https://bugs.webkit.org/show_bug.cgi?id=56801
1642
1643         Change results in lots of unexpected flaky on the dashboard.
1644         (Requested by pfeldman on #webkit).
1645
1646         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1647         * Scripts/webkitpy/layout_tests/port/test.py:
1648         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1649
1650 2011-03-21  Sam Weinig  <sam@webkit.org>
1651
1652         Fix failing tests on the WebKit2 bots.
1653
1654         * WebKitTestRunner/TestController.cpp:
1655         (WTR::TestController::resetStateToConsistentValues):
1656
1657 2011-03-21  Daniel Sievers  <sievers@google.com>
1658
1659         Reviewed by Simon Fraser.
1660
1661         [Chromium] Make RenderAsTextBehavior and LayerTreeAsTextBehavior tweakable from the DumpRenderTree commandline
1662         https://bugs.webkit.org/show_bug.cgi?id=56139
1663
1664         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1665         (main):
1666         * DumpRenderTree/chromium/LayoutTestController.cpp:
1667         (LayoutTestController::LayoutTestController):
1668         (LayoutTestController::layerTreeAsText):
1669         * DumpRenderTree/chromium/LayoutTestController.h:
1670         (LayoutTestController::setShowDebugLayerTree):
1671         * DumpRenderTree/chromium/TestShell.cpp:
1672         (TestShell::runFileTest):
1673         (TestShell::dump):
1674         * DumpRenderTree/chromium/TestShell.h:
1675         (TestParams::TestParams):
1676
1677 2011-03-21  Adam Roben  <aroben@apple.com>
1678
1679         Try again to get buildbot to show run-javascriptcore-tests's actual.html as an HTML file
1680
1681         Fixes <http://webkit.org/b/56746> build.webkit.org shows run-javascriptcore-tests's HTML
1682         output as plain text
1683
1684         Reviewed by David Kilzer.
1685
1686         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1687         (RunJavaScriptCoreTests): List actual.html as one of our log files so it will get uploaded
1688         to the master.
1689         (RunJavaScriptCoreTests.commandComplete): Reading the actual.html file here won't work,
1690         since we're running on the build master, not the slave. Instead, turn the raw source of
1691         actual.html which the build slave uploaded into an HTML log.
1692
1693 2011-03-21  Dirk Pranke  <dpranke@chromium.org>
1694
1695         Reviewed by Mihai Parparita.
1696
1697         new-run-webkit-tests: run tests in ascending alphabetical order per dir
1698         https://bugs.webkit.org/show_bug.cgi?id=56760
1699
1700         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1701         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1702         * Scripts/webkitpy/layout_tests/port/test.py:
1703
1704 2011-03-21  Leandro Gracia Gil  <leandrogracia@chromium.org>
1705
1706         Reviewed by Steve Block.
1707
1708         Media Stream API patch 0: adding compilation guards.
1709         https://bugs.webkit.org/show_bug.cgi?id=56458
1710
1711         Adding options to enable the media stream API feature in Chromium.
1712
1713         * Scripts/build-webkit:
1714
1715 2011-03-21  Qi Zhang  <qi.2.zhang@nokia.com>
1716
1717         Reviewed by Laszlo Gombos.
1718
1719         [Qt] Add a command line option to capture stdout and stderr for DumpRenderTree
1720         https://bugs.webkit.org/show_bug.cgi?id=56323
1721
1722         Using freopen to redirect STDOUT and STDERR when DumpRenderTree command line provide 
1723         "--stdout" or "--stderr" option.
1724
1725         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1726         (WebCore::DumpRenderTree::~DumpRenderTree):
1727         (WebCore::DumpRenderTree::processArgsLine):
1728         (WebCore::DumpRenderTree::loadNextTestInStandAloneMode):
1729         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1730         (WebCore::DumpRenderTree::setRedirectOutputFileName):
1731         (WebCore::DumpRenderTree::setRedirectErrorFileName):
1732         * DumpRenderTree/qt/main.cpp:
1733         (isOption):
1734         (takeOptionValue):
1735         (printUsage):
1736         (main):
1737
1738 2011-03-21  Adam Roben  <aroben@apple.com>
1739
1740         Fix exceptions on the buildbot due to my last change
1741
1742         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1743         (RunJavaScriptCoreTests.commandComplete): Catch exceptions due to actual.html not existing.
1744
1745 2011-03-21  Adam Roben  <aroben@apple.com>
1746
1747         Teach buildbot to treat run-javascriptcore-tests's actual.html as an HTML file
1748
1749         Fixes <http://webkit.org/b/56746> build.webkit.org shows run-javascriptcore-tests's HTML
1750         output as plain text
1751
1752         Reviewed by Darin Adler.
1753
1754         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1755         (RunJavaScriptCoreTests): Removed the logfiles variable, which can only handle plaintext
1756         logs.
1757         (RunJavaScriptCoreTests.commandComplete): Use the addHTMLLog method to upload actual.html to
1758         the build master. This will correctly treat it as HTML.
1759
1760 2011-03-20  Bill Budge  <bbudge@chromium.org>
1761
1762         Reviewed by Adam Barth.
1763
1764         Rename ThreadSafeShared to ThreadSafeRefCounted
1765         https://bugs.webkit.org/show_bug.cgi?id=56714
1766
1767         No new tests. Exposes no new functionality.
1768
1769         * DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeRefCounted.h: Copied from DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeShared.h.
1770         * DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeShared.h: Removed.
1771         * Scripts/do-webcore-rename:
1772
1773 2011-03-19  Anton D'Auria  <adauria@apple.com>
1774
1775         Reviewed by Dan Bernstein.
1776
1777         Add stub to LayoutTestControllerGtk.cpp to fix GTK build
1778         https://bugs.webkit.org/show_bug.cgi?id=56719
1779
1780         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Adding stub.
1781         (LayoutTestController::clearApplicationCacheForOrigin):
1782
1783 2011-03-19  Anton D'Auria  <adauria@apple.com>
1784
1785         Reviewed by Alexey Proskuryakov.
1786
1787         ApplicationCacheGroup is not obsolete after being deleted via ApplicationCacheStorage::deleteEntriesForOrigin
1788         https://bugs.webkit.org/show_bug.cgi?id=56415
1789
1790         * DumpRenderTree/LayoutTestController.cpp:
1791         (clearApplicationCacheForOriginCallback):
1792         (LayoutTestController::staticFunctions):
1793         * DumpRenderTree/LayoutTestController.h:
1794         * DumpRenderTree/chromium/LayoutTestController.cpp: Adding stubs.
1795         (LayoutTestController::LayoutTestController):
1796         (LayoutTestController::clearAllApplicationCaches):
1797         (LayoutTestController::clearApplicationCacheForOrigin): 
1798         * DumpRenderTree/chromium/LayoutTestController.h:
1799         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Adding stub.
1800         (LayoutTestController::clearApplicationCacheForOrigin):
1801         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Adding stub.
1802         (LayoutTestController::clearApplicationCacheForOrigin):
1803         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1804         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Adding stub.
1805         (LayoutTestController::clearApplicationCacheForOrigin):
1806         * DumpRenderTree/wx/LayoutTestControllerWx.cpp: Adding stub.
1807         (LayoutTestController::clearApplicationCacheForOrigin):
1808
1809 2011-03-18  Dan Bernstein  <mitz@apple.com>
1810
1811         Revised build fix for r81135.
1812
1813         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
1814         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1815
1816 2011-03-18  Adam Roben  <aroben@apple.com>
1817
1818         Windows build fix
1819
1820         * WebKitTestRunner/config.h: Add a missing #endif.
1821
1822 2011-03-18  Andreas Kling  <kling@webkit.org>
1823
1824         Unbreak Qt build after r81494.
1825
1826         * WebKitTestRunner/qt/TestInvocationQt.cpp:
1827         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1828
1829 2011-03-18  Sam Weinig  <sam@webkit.org>
1830
1831         Fix windows build. This was really Adam Roben's fault. I swear!
1832
1833         * WebKitTestRunner/config.h:
1834
1835 2011-03-18  Sam Weinig  <sam@webkit.org>
1836
1837         Reviewed by Adam Roben.
1838
1839         Pixel tests don't work in WebKitTestRunner on Windows
1840         https://bugs.webkit.org/show_bug.cgi?id=56630
1841
1842         Cross-platformize (Mac and Windows CG) the pixel dumping code in WebKitTestRunner to use WebKit2
1843         built-in snapshotting instead of using the window server on the Mac.
1844
1845         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1846         (WTR::InjectedBundle::InjectedBundle):
1847         (WTR::InjectedBundle::didReceiveMessage):
1848         (WTR::InjectedBundle::beginTesting):
1849         (WTR::InjectedBundle::done):
1850         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1851         (WTR::InjectedBundle::setPixelResult):
1852         (WTR::InjectedBundle::shouldDumpPixels):
1853         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1854         (WTR::InjectedBundlePage::dump):
1855         Take the snapshot in the bundle and send it to the UIProcess for dumping.
1856
1857         * WebKitTestRunner/TestInvocation.cpp:
1858         (WTR::TestInvocation::invoke):
1859         (WTR::TestInvocation::dump):
1860         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1861         * WebKitTestRunner/TestInvocation.h:
1862         * WebKitTestRunner/cg: Added.
1863         * WebKitTestRunner/cg/TestInvocationCG.cpp: Copied from WebKitTestRunner/mac/TestInvocationMac.mm.
1864         (WTR::createCGContextFromImage):
1865         (WTR::computeMD5HashStringForContext):
1866         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1867         * WebKitTestRunner/mac/TestInvocationMac.mm: Removed.
1868         Making pixel dumping code shared for CG ports. Also use the WTF/MD5 instead of platform specific code.
1869
1870         * WebKitTestRunner/win/TestInvocationWin.cpp:
1871         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1872         Keep stub for Cairo build.
1873
1874         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreGraphics.vsprops: Added.
1875         Add CG configuration.
1876
1877         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1878         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1879         Add new files.
1880
1881 2011-03-18  Adam Roben  <aroben@apple.com>
1882
1883         Don't allow Leaks Viewer's vertical scrollbar to cover up long function names
1884
1885         Rubber-stamped by Simon Fraser.
1886
1887         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
1888         (.data-grid .data-container): Use overflow-y:auto instead of the Inspector's default
1889         overflow-y:overlay so that the scrollbar doesn't overlay the content.
1890
1891 2011-03-18  Adam Roben  <aroben@apple.com>
1892
1893         Don't ellipsize long or indented function names in Leaks Viewer
1894
1895         Fixes <http://webkit.org/b/56037> Leaks viewer needs horizontal
1896         scrollbar
1897
1898         Reviewed by Simon Fraser.
1899
1900         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
1901         (.data-grid .data-container):
1902         (.data-grid td > div, .data-grid th > div):
1903         Allow the contents to extend to the right.
1904
1905 2011-03-18  Adam Roben  <aroben@apple.com>
1906
1907         Fix some leaks in DRT seen on the leaks bot
1908
1909         Fixes <http://webkit.org/b/56638> addURLToRedirectCallback and
1910         setWillSendRequestClearHeaderCallback in DRT are leaky
1911
1912         Reviewed by Alexey Proskuryakov.
1913
1914         * DumpRenderTree/ForwardingHeaders/wtf/OwnArrayPtr.h: Added.
1915
1916         * DumpRenderTree/LayoutTestController.cpp:
1917         (addURLToRedirectCallback):
1918         (setWillSendRequestClearHeaderCallback):
1919         Use OwnArrayPtr to cause the strings to be deleted.
1920
1921 2011-03-18  Adam Roben  <aroben@apple.com>
1922
1923         Fix a NSURLCredential leak seen on the leaks bot
1924
1925         Fixes <http://webkit.org/b/56637> -[SynchronousLoader
1926         connection:didReceiveAuthenticationChallenge:] is leaky
1927
1928         Reviewed by John Sullivan.
1929
1930         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1931         (-[SynchronousLoader connection:didReceiveAuthenticationChallenge:]): Use a RetainPtr to
1932         cause the NSURLCredential to be released.
1933
1934 2011-03-18  John Knottenbelt  <jknotten@chromium.org>
1935
1936         Unreviewed.
1937
1938         Remove unnecessary brackets around my email address.
1939
1940         * Scripts/webkitpy/common/config/committers.py:
1941
1942 2011-03-18  Adam Roben  <aroben@apple.com>
1943         
1944         Remove some files I accidentally added in r81454
1945
1946         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreGraphics.vsprops: Removed.
1947         * WebKitTestRunner/cg/TestInvocationCG.cpp: Removed.
1948
1949 2011-03-18  Adam Roben  <aroben@apple.com>
1950
1951         Ignore an NSNumberFormatter leak on SnowLeopard
1952
1953         * Scripts/old-run-webkit-tests:
1954         (countAndPrintLeaks): Ignore leaks in -[NSNumberFormatter
1955         getObjectValue:forString:errorDescription:].
1956
1957 2011-03-18  Adam Roben  <aroben@apple.com>
1958
1959         Fix a leak beneath LayoutTestController::authenticateSession seen on the bots
1960
1961         Rubber-stamped by Mark Rowe.
1962
1963         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1964         (LayoutTestController::authenticateSession): Use a RetainPtr to cause the NSURLRequest to be
1965         released.
1966
1967 2011-03-17  Adam Roben  <aroben@apple.com>
1968
1969         Address a review comment I missed in r81445
1970
1971         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:
1972         (LeaksParserWorker.prototype._parseLeaks): Anchor the RegExp used to find the number of
1973         leaked bytes to speed up searching on long lines.
1974
1975 2011-03-17  Adam Roben  <aroben@apple.com>
1976
1977         Mark leaky builds orange, even if all regression tests passed
1978
1979         Fixes <http://webkit.org/b/56609> SnowLeopard Intel Leaks bot appears green on
1980         build.webkit.org when all tests pass even though there are still leaks
1981
1982         Reviewed by Dan Bernstein.
1983
1984         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1985         (RunWebKitLeakTests): Set the warnOnWarnings property to True so that the entire build will
1986         be marked orange if this build step generates warnings.
1987
1988 2011-03-17  Adam Roben  <aroben@apple.com>
1989
1990         Allow values in Leaks Viewer to be shown as percentages
1991
1992         Double-clicking on a column will toggle between showing percentages and showing real values.
1993
1994         Fixes <http://webkit.org/b/56628> Would like to view values as percentages of the total
1995         number of leaked bytes in Leaks Viewer
1996
1997         Reviewed by Joe Pecoraro.
1998
1999         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:
2000         (LeaksParserWorker.prototype._incorporateLeaks): Calculate the (never-shown) top-level
2001         node's totalTime, which is used in calculating percentages.
2002
2003         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
2004         (monkeyPatchInspectorObjects): Only format values as bytes if we aren't supposed to be
2005         showing them as percentages.
2006
2007 2011-03-17  Adam Roben  <aroben@apple.com>
2008
2009         Show the number of leaked bytes, not just leaked allocations, in Leaks Viewer
2010
2011         The Self and Total columns now report the number of leaked bytes. The new Calls column shows
2012         the number of leaked allocations. And the new Average column shows the average number of
2013         leaked bytes per call.
2014
2015         Fixes <http://webkit.org/b/56344> Leaks Viewer should show how many bytes were leaked, not
2016         just how many allocations
2017
2018         Reviewed by Joe Pecoraro.
2019
2020         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:
2021         (LeaksParserWorker.prototype._parseLeaks): Parse the number of leaked bytes from the "Leak:"
2022         line and store it with the leak stack.
2023         (LeaksParserWorker.prototype._createNode): Initialize the averageTime and numberOfCalls
2024         properties.
2025         (LeaksParserWorker.prototype._incorporateLeaks): Updated to get the stack from the .stack
2026         property, and changed to store the number of leaked bytes in .selfTime/.totalTime.
2027         .numberOfCalls now holds the number of leaked allocations.
2028
2029         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
2030         (Preferences): Set samplingCPUProfiler to false so that the Average and Calls columns will
2031         appear.
2032         (monkeyPatchInspectorObjects): Format the values as bytes.
2033
2034 2011-03-17  Adam Roben  <aroben@apple.com>
2035
2036         Make Leaks Viewer able to count leaks in builds that didn't fail any regression tests
2037
2038         Fixes <http://webkit.org/b/56626> Leaks Viewer omits recent builds which didn't fail any
2039         regression tests
2040
2041         Reviewed by James Robinson.
2042
2043         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
2044         (RecentBuildsLoader.prototype.start): Get the number of leaks out of the "text" array, which
2045         is always populated, even when all regression tests pass.
2046
2047 2011-03-10  Hayato Ito  <hayato@chromium.org>
2048
2049         Reviewed by Tony Chang.
2050
2051         Add a check logic for reftests in case that a reftest is marked AS REBASELINE.
2052
2053         https://bugs.webkit.org/show_bug.cgi?id=56076
2054
2055         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2056
2057 2011-03-17  Adam Roben  <aroben@apple.com>
2058
2059         Skip a compositing-sensitive test when accelerated compositing is disabled
2060
2061         Reviewed by Sam Weinig.
2062
2063         * Scripts/old-run-webkit-tests: Skip media/media-document-audio-repaint.html when
2064         accelerated compositing is disabled.
2065
2066 2011-03-17  Adam Roben  <aroben@apple.com>
2067
2068         Start using PlatformSpecificScheduler for the Mac builders
2069
2070         The current set of file/directory patterns should work for Mac builders. We may discover
2071         that there are more files and directories we can exclude from the Mac builds, but they can
2072         be added later.
2073
2074         Fixes <http://webkit.org/b/56593> Mac builders do lots of unnecessary builds
2075
2076         Reviewed by Mark Rowe.
2077
2078         * BuildSlaveSupport/build.webkit.org-config/config.json: Moved the Mac builders into two
2079         PlatformSpecificSchedulers: one for Leopard, and one for SnowLeopard.
2080
2081         * Scripts/webkitpy/common/config/build.py:
2082         (_should_file_trigger_build): Allow "mac-leopard" and "mac-snowleopard" platforms, and
2083         cleaned up patterns a little bit.
2084
2085         * Scripts/webkitpy/common/config/build_unittest.py:
2086         (ShouldBuildTest): Fixed some expected results.
2087         (ShouldBuildTest.test_should_build): Start testing "mac-leopard" and "mac-snowleopard"
2088         platforms.
2089
2090 2011-03-17  Jeff Miller  <jeffm@apple.com>
2091
2092         Use a consistent set of file patterns in the svn:ignore property for all .xcodeproj directories, specifically:
2093         
2094         *.mode*
2095         *.pbxuser
2096         *.perspective*
2097         project.xcworkspace
2098         xcuserdata
2099
2100         * DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
2101         * MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
2102         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
2103         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
2104         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
2105
2106 2011-03-17  Adam Roben  <aroben@apple.com>
2107
2108         Make old-run-webkit-tests pick up mac-wk2 results when running in WebKit2 mode on Windows
2109
2110         Fixes <http://webkit.org/b/56563> Running WebKit2 tests on Windows should use results from
2111         mac-wk2
2112
2113         Reviewed by Anders Carlsson.
2114
2115         * Scripts/old-run-webkit-tests:
2116         (expectedDirectoryForTest): Clean up the code to search in extra Mac platform result
2117         directories on Windows. Add mac-wk2 to the set of extra platforms we look in on Windows when
2118         we're running in WebKit2 mode.
2119
2120 2011-03-17  Mikhail Naganov  <mnaganov@chromium.org>
2121
2122         Reviewed by Yury Semikhatsky.
2123
2124         Web Inspector: Clean up Inspector strings.
2125         https://bugs.webkit.org/show_bug.cgi?id=56557
2126
2127         Modify the script to deal correctly with "\xNN" escapes, and to
2128         check strings in Chromium's DevTools.js.
2129
2130         * Scripts/check-inspector-strings:
2131
2132 2011-03-17  Keith Kyzivat  <keith.kyzivat@nokia.com>
2133
2134         Reviewed by Benjamin Poulain.
2135
2136         Update autoinstall to install mechanize 0.2.4
2137         https://bugs.webkit.org/show_bug.cgi?id=56499
2138
2139         Newer versions of mechanize support HTTPS proxies, which is necessary
2140         for people using webkit-patch behind firewalls.
2141
2142         * Scripts/webkitpy/common/system/autoinstall.py:
2143         * Scripts/webkitpy/thirdparty/__init__.py:
2144
2145 2011-03-16  Sam Weinig  <sam@webkit.org>
2146
2147         Reviewed by Adam Roben.
2148
2149         REGRESSION (r81084): media/invalid-media-url-crash.html and editing/execCommand/indent-paragraphs.html failing on WebKit2
2150         https://bugs.webkit.org/show_bug.cgi?id=56541
2151
2152         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2153         (WTR::InjectedBundlePage::willSendRequestForFrame):
2154         Check for an empty host in addition to a null host.  This bug was introduced
2155         when porting off of the KURL code and onto the WKURLRef version.
2156
2157 2011-03-16  Sam Weinig  <sam@webkit.org>
2158
2159         Reviewed by Adam Roben.
2160
2161         Add Lucas Forschler to the list of WebKit committers.
2162
2163         * Scripts/webkitpy/common/config/committers.py:
2164
2165 2011-03-16  Sam Weinig  <sam@webkit.org>
2166
2167         Reviewed upon and dictated through Adam Roben.
2168
2169         Escape crashing function names in results.html. This fixes an issue
2170         when a crash involves a type with templates.
2171
2172         * Scripts/old-run-webkit-tests:
2173
2174 2011-03-16  Daniel Sievers  <sievers@google.com>
2175
2176         Reviewed by James Robinson.
2177
2178         Add setting to always force compositing mode
2179         https://bugs.webkit.org/show_bug.cgi?id=56156
2180
2181         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2182         (main):
2183         * DumpRenderTree/chromium/TestShell.cpp:
2184         (TestShell::TestShell):
2185         (TestShell::resetWebSettings):
2186         * DumpRenderTree/chromium/TestShell.h:
2187         (TestShell::setForceCompositingMode):
2188         * DumpRenderTree/chromium/WebPreferences.cpp:
2189         (WebPreferences::reset):
2190         (WebPreferences::applyTo):
2191         * DumpRenderTree/chromium/WebPreferences.h:
2192
2193 2011-03-15  Hayato Ito  <hayato@chromium.org>
2194
2195         Reviewed by Ojan Vafai.
2196
2197         Ignore files that will be used by reftests in old-run-webkit-tests.
2198
2199         https://bugs.webkit.org/show_bug.cgi?id=55936
2200
2201         * Scripts/old-run-webkit-tests:
2202
2203 2011-03-15  Felipe Oliveira da Silva Netto  <f.dachshund@gmail.com>
2204
2205         Reviewed by Adam Roben.
2206
2207         Function relativeScriptsDir doesn't return the correct relative
2208         Scripts directory.
2209
2210         * Scripts/webkitdirs.pm:
2211         (relativeScriptsDir): Ensure we use the directory that contains
2212         webkitdirs.pm, not the one that contains the original script that
2213         was invoked.
2214
2215 2011-03-15  Kevin Ollivier  <kevino@theolliviers.com>
2216
2217         [wx] Build fixes for long linker commands on Win and method return error, plus a Mac
2218         fix to link against the Security framework after recent WebKitSystemInterface changes.
2219
2220         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2221         (LayoutTestController::originsWithLocalStorage):
2222         * wx/build/settings.py:
2223         * wx/build/waf_extensions.py:
2224
2225 2011-03-15  Sam Weinig  <sam@webkit.org>
2226
2227         Reviewed by Darin Adler.
2228
2229         Add script to convert a patch to a prettypatch and show in the default browser
2230         https://bugs.webkit.org/show_bug.cgi?id=56416
2231
2232         This can be used either like
2233             $ svn-create-patch | show-pretty-diff
2234         or
2235             $ show-pretty-diff patch.diff
2236
2237         * Scripts/show-pretty-diff: Added.
2238
2239 2011-03-15  Brian Weinstein  <bweinstein@apple.com>
2240
2241         Rubber-stamped by Adam Roben.
2242
2243         Adding myself as a reviewer.
2244
2245         * Scripts/webkitpy/common/config/committers.py:
2246
2247 2011-03-15  Anders Carlsson  <andersca@apple.com>
2248
2249         Try to fix the Windows build.
2250
2251         * DumpRenderTree/TestNetscapePlugIn/Tests/NPDeallocateCalledBeforeNPShutdown.cpp:
2252         (NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject):
2253
2254 2011-03-15  Anders Carlsson  <andersca@apple.com>
2255
2256         Reviewed by Sam Weinig.
2257
2258         Make sure that NP_Shutdown is always the last NPP function called
2259         https://bugs.webkit.org/show_bug.cgi?id=56391
2260
2261         Add a test that times out if an NP_Deallocate object is called after NP_Shutdown.
2262
2263         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2264         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2265         (PluginTest::PluginTest):
2266         (PluginTest::NP_Shutdown):
2267         (PluginTest::registerNPShutdownFunction):
2268         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
2269         * DumpRenderTree/TestNetscapePlugIn/Tests/NPDeallocateCalledBeforeNPShutdown.cpp: Added.
2270         (NPDeallocateCalledBeforeNPShutdown::NPDeallocateCalledBeforeNPShutdown):
2271         (NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject):
2272         (NPDeallocateCalledBeforeNPShutdown::ScriptableObject::hasProperty):
2273         (NPDeallocateCalledBeforeNPShutdown::ScriptableObject::getProperty):
2274         (NPDeallocateCalledBeforeNPShutdown::NPP_New):
2275         (NPDeallocateCalledBeforeNPShutdown::NPP_GetValue):
2276         (NPDeallocateCalledBeforeNPShutdown::shutdown):
2277         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2278         (NP_Shutdown):
2279         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2280         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2281         * GNUmakefile.am:
2282
2283 2011-03-15  Ilya Sherman  <isherman@chromium.org>
2284
2285         Reviewed by Tony Chang.
2286
2287         Autofilled form elements are assigned fixed background color but not text color
2288         https://bugs.webkit.org/show_bug.cgi?id=48382
2289
2290         * DumpRenderTree/LayoutTestController.cpp:
2291         (setAutofilledCallback): Added.
2292         (LayoutTestController::staticFunctions):
2293         * DumpRenderTree/LayoutTestController.h:
2294         * DumpRenderTree/chromium/LayoutTestController.cpp:
2295         (LayoutTestController::LayoutTestController):
2296         (LayoutTestController::setAutofilled): Added.
2297         * DumpRenderTree/chromium/LayoutTestController.h:
2298         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2299         (LayoutTestController::setAutofilled): Added.
2300         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2301         (LayoutTestController::setAutofilled): Added.
2302         (LayoutTestController::setValueForUser): Style tweak.
2303         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2304         (LayoutTestController::setAutofilled): Added (stub).
2305         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2306         (LayoutTestController::setAutofilled): Added (stub).
2307
2308 2011-03-15  Dan Bernstein  <mitz@apple.com>
2309
2310         Build fix after r81135.
2311
2312         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
2313
2314 2011-03-15  Dan Bernstein  <mitz@apple.com>
2315
2316         Build fix after r81135.
2317
2318         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
2319         * WebKitTestRunner/mac/TestControllerMac.mm:
2320         * WebKitTestRunner/mac/TestInvocationMac.mm:
2321         * WebKitTestRunner/mac/main.mm:
2322
2323 2011-03-15  Balazs Kelemen  <kbalazs@webkit.org>
2324
2325         Reviewed by Adam Barth.
2326
2327         REGRESSION(80977): breaks Qt ARMv7 Linux Release bot
2328         https://bugs.webkit.org/show_bug.cgi?id=56349
2329
2330         * QtTestBrowser/QtTestBrowser.pro: Link against fontconfig
2331         on platforms where we use it. Copied from DumpRenderTree.pro.
2332
2333 2011-03-15  Dan Bernstein  <mitz@apple.com>
2334
2335         Build fix after r81135.
2336
2337         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
2338         * DumpRenderTree/mac/WebArchiveDumpSupportMac.mm:
2339
2340 2011-03-15  Kevin Ollivier  <kevino@theolliviers.com>
2341
2342         Reviewed by Darin Adler.
2343
2344         Introduce WTF_USE_EXPORT_MACROS, which will allow us to put shared library import/export
2345         info into the headers rather than in export symbol definition files, but disable it on 
2346         all platforms initially so we can deal with port build issues one port at a time.
2347         
2348         https://bugs.webkit.org/show_bug.cgi?id=27551
2349
2350         * DumpRenderTree/cg/ImageDiffCG.cpp:
2351         * DumpRenderTree/chromium/config.h:
2352         * DumpRenderTree/config.h:
2353         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2354         * TestWebKitAPI/TestWebKitAPIPrefix.h:
2355         * WebKitAPITest/HostWindow.cpp:
2356         * WebKitAPITest/TestsController.cpp:
2357         * WebKitAPITest/config.h: Added.
2358         * WebKitAPITest/main.cpp:
2359         * WebKitAPITest/tests/WebViewDestruction.cpp:
2360         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp:
2361         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2362         * WebKitTestRunner/InjectedBundle/GCController.cpp:
2363         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2364         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
2365         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2366         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2367         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2368         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
2369         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
2370         * WebKitTestRunner/InjectedBundle/win/ActivateFonts.cpp:
2371         * WebKitTestRunner/InjectedBundle/win/InjectedBundleWin.cpp:
2372         * WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp:
2373         * WebKitTestRunner/TestController.cpp:
2374         * WebKitTestRunner/TestInvocation.cpp:
2375         * WebKitTestRunner/config.h: Added.
2376         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2377         * WebKitTestRunner/qt/TestControllerQt.cpp:
2378         * WebKitTestRunner/qt/TestInvocationQt.cpp:
2379         * WebKitTestRunner/qt/main.cpp:
2380         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2381         * WebKitTestRunner/win/TestControllerWin.cpp:
2382         * WebKitTestRunner/win/TestInvocationWin.cpp:
2383         * WebKitTestRunner/win/main.cpp:
2384         * wx/build/settings.py:
2385
2386 2011-03-15  Hayato Ito  <hayato@chromium.org>
2387
2388         Reviewed by Shinichiro Hamaji.
2389
2390         [NRWT] Add support for reftests to new-run-webkit-tests.
2391
2392         https://bugs.webkit.org/show_bug.cgi?id=55457
2393
2394         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
2395         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2396         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
2397         * Scripts/webkitpy/layout_tests/port/base.py:
2398         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2399         * Scripts/webkitpy/layout_tests/port/test.py:
2400         * Scripts/webkitpy/layout_tests/port/test_files.py:
2401         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2402
2403 2011-03-15  Alejandro G. Castro  <alex@igalia.com>
2404
2405         Reviewed by Martin Robinson.
2406
2407         [GTK] Fix compilation warning after r80892
2408         https://bugs.webkit.org/show_bug.cgi?id=56302
2409
2410         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2411         (LayoutTestController::originsWithLocalStorage):
2412
2413 2011-03-15  Robert Hogan  <robert@webkit.org>
2414
2415         Reviewed by Adam Barth.
2416
2417         Document the qmakearg argument, and hint how to build webkit2 on Qt
2418         https://bugs.webkit.org/show_bug.cgi?id=56326
2419
2420         * Scripts/build-webkit: add --qmakearg to build-webkit --help
2421
2422 2011-03-15  Adam Roben  <aroben@apple.com>
2423
2424         Make Windows 7 Release (Tests) a core builder
2425
2426         We can probably make Windows XP Debug (Tests) a core builder, too, but we should probably
2427         give it a few more days of greenness first.
2428
2429         Fixes <http://webkit.org/b/55665> Windows 7 Release (Tests) should be a core builder
2430
2431         Reviewed by Sam Weinig.
2432
2433         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2434         (BuildBot): Added a regexp to match Windows 7 Release (Tests).
2435
2436         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2437         (BuildBotTest): Updated the list of builders to match the current list on build.webkit.org.
2438         Updated the core regexps to match the buildbot module. Updated the expected results to match
2439         the current set of core builders.
2440
2441 2011-03-14  Adam Roben  <aroben@apple.com>
2442
2443         Add forgotten file from r81116
2444
2445         * TestWebKitAPI/Configurations/TestWebKitAPICFNetwork.vsprops: Added.
2446
2447 2011-03-14  Sam Weinig  <sam@webkit.org>
2448
2449         Reviewed by Adam Roben.
2450
2451         about:blank fake responses don't get serialized when sent the UIProcess
2452         <rdar://problem/9108119>
2453         https://bugs.webkit.org/show_bug.cgi?id=56357
2454
2455         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp: Added.
2456         (TestWebKitAPI::decidePolicyForResponse):
2457         (TestWebKitAPI::TEST):
2458         Add test that loads of about:blank have a response with a MIMEType of text/html.
2459
2460         * TestWebKitAPI/PlatformUtilities.h:
2461         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
2462         (TestWebKitAPI::Util::MIMETypeForWKURLResponse):
2463         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
2464         (TestWebKitAPI::Util::MIMETypeForWKURLResponse):
2465         Add helper to get the MIMEType from a WKURLResponse.
2466
2467         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2468         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2469         Add new files.
2470
2471 2011-03-14  Jarkko Sakkinen  <jarkko.j.sakkinen@gmail.com>
2472
2473         Reviewed by Kenneth Rohde Christiansen.
2474
2475         [Qt] Command-line options for QGLWidget and WebGL to QtTestBrowser
2476         https://bugs.webkit.org/show_bug.cgi?id=56006
2477
2478         * QtTestBrowser/launcherwindow.cpp:
2479         (LauncherWindow::initializeView):
2480         * QtTestBrowser/main.cpp:
2481         (LauncherApplication::handleUserOptions):
2482
2483 2011-03-14  James Kozianski  <koz@chromium.org>
2484
2485         Reviewed by Ojan Vafai.
2486
2487         Add method to make BuildBot return test outputs
2488         https://bugs.webkit.org/show_bug.cgi?id=54374
2489
2490         The Builder.latest_cached_build will be used by the new rebaseline
2491         script to determine the build to use baselines from.
2492
2493         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2494         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2495
2496 2011-03-14  Adam Roben  <aroben@apple.com>
2497
2498         Test that WKBundlePageCanHandleRequest returns true for empty document URLs
2499
2500         Reviewed by Sam Weinig.
2501
2502         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp: Added.
2503         (TestWebKitAPI::didReceiveMessageFromInjectedBundle): Store the result of the test.
2504         (TestWebKitAPI::setInjectedBundleClient): Hook up our callback.
2505         (TestWebKitAPI::TEST): Register "emptyscheme" as an empty document scheme, load a page to
2506         ensure the web process is initialized, then ask the bundle to run the test and assert that
2507         it succeeded.
2508
2509         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp: Added.
2510         (TestWebKitAPI::CanHandleRequestTest::CanHandleRequestTest): Just call up to the base class.
2511         (TestWebKitAPI::canHandleURL): Helper function to test whether WebKit2 claims to be able to
2512         handle a given URL.
2513         (TestWebKitAPI::runTest): Check that empty document URLs can be handled (and that an unknown
2514         URL type cannot be handled).
2515         (TestWebKitAPI::CanHandleRequestTest::didReceiveMessage): Run the test and return the
2516         result.
2517
2518         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2519         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2520         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
2521         Added new files to the project.
2522
2523 2011-03-14  Sheriff Bot  <webkit.review.bot@gmail.com>
2524
2525         Unreviewed, rolling out r81094.
2526         http://trac.webkit.org/changeset/81094
2527         https://bugs.webkit.org/show_bug.cgi?id=56355
2528
2529         Broke the chromium DRT related build. (Requested by dave_levin
2530         on #webkit).
2531
2532         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2533         (main):
2534         * DumpRenderTree/chromium/LayoutTestController.cpp:
2535         (LayoutTestController::LayoutTestController):
2536         (LayoutTestController::layerTreeAsText):
2537         * DumpRenderTree/chromium/LayoutTestController.h:
2538         * DumpRenderTree/chromium/TestShell.cpp:
2539         (TestShell::runFileTest):
2540         (TestShell::dump):
2541         * DumpRenderTree/chromium/TestShell.h:
2542         (TestParams::TestParams):
2543
2544 2011-03-14  Daniel Sievers  <sievers@google.com>
2545
2546         Reviewed by Simon Fraser.
2547
2548         [Chromium] Make RenderAsTextBehavior and LayerTreeAsTextBehavior tweakable from the DumpRenderTree commandline
2549         https://bugs.webkit.org/show_bug.cgi?id=56139
2550
2551         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2552         (main):
2553         * DumpRenderTree/chromium/LayoutTestController.cpp:
2554         (LayoutTestController::LayoutTestController):
2555         (LayoutTestController::layerTreeAsText):
2556         * DumpRenderTree/chromium/LayoutTestController.h:
2557         (LayoutTestController::setShowDebugLayerTree):
2558         * DumpRenderTree/chromium/TestShell.cpp:
2559         (TestShell::runFileTest):
2560         (TestShell::dump):
2561         * DumpRenderTree/chromium/TestShell.h:
2562         (TestParams::TestParams):
2563
2564 2011-03-14  Balazs Kelemen  <kbalazs@webkit.org>
2565
2566         Reviewed by Adam Roben.
2567
2568         [Qt][WK2]Unbreak InjectedBundle on Qt
2569         https://bugs.webkit.org/show_bug.cgi?id=54109
2570
2571         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2572         (WTR::InjectedBundlePage::willSendRequestForFrame): Use new WebKit2
2573         API's instead of KURL to analyze the URL.
2574         * WebKitTestRunner/StringFunctions.h:
2575         (WTR::adoptWK): Moved from InjectedBundlePage.cpp to make it available globally
2576         in the WebKitTestRunner project.
2577         (WTR::toWK): Use adoptWK.
2578         (WTR::operator<<): Added helper for printing a WKURL.
2579         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Do not link
2580         against WebCore.
2581
2582 2011-03-14  Balazs Kelemen  <kbalazs@webkit.org>
2583
2584         Reviewed by Kenneth Rohde Christiansen.
2585
2586         check-webkit-style falsely should not complain about WebKit2 API headers in the Shared directory
2587         https://bugs.webkit.org/show_bug.cgi?id=56321
2588
2589         * Scripts/webkitpy/style/checker.py: Add the patch "Source/WebKit2/Shared/API/c"
2590         to the list of exceptions for WebKit2 C API headers.
2591
2592 2011-03-14  Adam Roben  <aroben@apple.com>
2593
2594         Show the list of recent leaky builds in reverse chronological order
2595
2596         Previously they were being shown in a deterministic but surprising order based on
2597         lexicographically sorting the build offsets (-1, -10, -2, -3...).
2598
2599         Fixes <http://webkit.org/b/56342> Leaks Viewer shows recent builds in a strange order
2600
2601         Reviewed by Darin Adler.
2602
2603         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
2604         (RecentBuildsLoader.prototype.start): Sort the builds by revision before passing them to our
2605         callback.
2606
2607 2011-03-14  Adam Roben  <aroben@apple.com>
2608
2609         Show a list of up to 10 recent leaky builds when Leaks Viewer loads
2610
2611         Fixes <http://webkit.org/b/56043> Leaks Viewer should present a list of recent builds to
2612         analyze
2613
2614         Reviewed by David Kilzer and Joe Pecoraro.
2615
2616         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
2617         (#url-prompt): Made this a bit taller to make room for the list of builds.
2618
2619         (#recent-builds-loading-indicator):
2620         (#recent-builds-list):
2621         Added styles for the build list and loading indicator.
2622
2623         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
2624         (LeaksViewer.loaded): Pass the URL from the query through decodeURIComponent before loading
2625         it. This will unescape it.
2626         (LeaksViewer.urlPromptButtonClicked): Moved code from here to _urlChosenFromPrompt.
2627         (LeaksViewer._didLoadRecentBuilds): Added. Stores the builds and updates the prompt.
2628         (LeaksViewer._displayURLPrompt): Start loading the recent leaky builds.
2629         (LeaksViewer._updateURLPrompt): Create a list of the recent leaky builds and add them to the
2630         prompt UI.
2631         (LeaksViewer._urlChosenFromPrompt): Added. Code came from urlPromptButtonClicked. This is
2632         now also used when a recent build is clicked.
2633
2634         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js: Added.
2635         (RecentBuildsLoader): Store the callback.
2636         (RecentBuildsLoader.prototype.start): Load the N most recent builds from the specified
2637         builder. Find the revision number, leak count, and results URL for each one. Pass the
2638         resulting info to our callback.
2639
2640         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Utilities.js:
2641         (range): Added this helper function to return an array containing the integers [0, n).
2642
2643         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html: Added
2644         RecentBuildsLoader.js and added text to the prompt UI to show the recent builds.
2645
2646 2011-03-14  Mark Rowe  <mrowe@apple.com>
2647
2648         Reviewed by Adam Roben.
2649
2650         Fix two memory leaks within LayoutTestController's storage support.
2651
2652         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2653         (LayoutTestController::originsWithLocalStorage): Don't leak the JSStringRef that is returned
2654         by JSStringCreateWithCFString.
2655         (LayoutTestController::deleteLocalStorageForOrigin): Don't leak the WebSecurityOrigin that we
2656         allocate.
2657
2658 2011-03-14  Mark Rowe  <mrowe@apple.com>
2659
2660         Reviewed by Oliver Hunt.
2661
2662         <http://webkit.org/b/56304> REGRESSION(r80892): 100,000+ leaks seen on the build bot
2663
2664         * DumpRenderTree/LayoutTestController.cpp:
2665         (LayoutTestController::staticFunctions): Remove duplicate entries.
2666
2667 2011-03-14  Alice Liu  <alice.liu@apple.com>
2668
2669         Reviewed by Dan Bernstein.
2670
2671         DumpRenderTree Perl Support fails to build with ARCHS="i386 x86_64"
2672
2673         * DumpRenderTree/mac/PerlSupport/Makefile:
2674         Add whitespace when joining "-arch" with the architectures passed in as arguments.
2675
2676 2011-03-14  Daniel Bates  <dbates@rim.com>
2677
2678         https://bugs.webkit.org/show_bug.cgi?id=55438
2679         Add double quotes around value of -DCMAKE_WINCE_SDK that I inadvertently did not add
2680         when landing changeset 81041 <http://trac.webkit.org/changeset/81041>.
2681
2682         * Scripts/build-webkit:
2683
2684 2011-03-14  Daniel Bates  <dbates@rim.com>
2685
2686         Reviewed by David Kilzer.
2687
2688         Cleanup: Separate port-specific implementation details from webkitdirs::buildCMakeProject()
2689         https://bugs.webkit.org/show_bug.cgi?id=55438
2690
2691         Separate out the EFL- and WinCE-specific logic from the port-independent logic in
2692         webkitdirs::buildCMakeProject(). Also, remove redundant code for generating the
2693         CMake arguments for feature defines.
2694
2695         * Scripts/build-webkit:
2696           - Added cMakeArgsFromFeatures() to convert the @features array to CMake arguments.
2697           - Modified EFL and WinCE-specific building logic to call buildCMakeProjectOrExit().
2698           - Sorted forward declarations.
2699           - Initialize $makeArgs with the empty string so as to simplify its use in string operations;
2700             Modified call sites as needed.
2701         * Scripts/webkitdirs.pm:
2702           - Added cleanCMakeGeneratedProject() to clean a CMake build.
2703           - Added buildCMakeGeneratedProject() to build using generated build system.
2704           - Added buildCMakeProjectOrExit() which is a facade for building a CMake project.
2705           - Added generateBuildSystemFromCMakeProject() to generate the build system from
2706             a CMake project.
2707           - Removed buildCMakeProject(). This functionality is in buildCMakeProjectOrExit().
2708
2709 2011-03-14  John Knottenbelt  <jknotten@chromium.org>
2710
2711         Reviewed by Steve Block.
2712
2713         Detach Geolocation from Frame when Page destroyed.
2714         https://bugs.webkit.org/show_bug.cgi?id=52877
2715
2716         Extend the layout test controller to expose the number of pending
2717         geolocation requests, so that we can test that the requests have
2718         been cancelled on page close.
2719
2720         * DumpRenderTree/LayoutTestController.cpp:
2721         (numberOfPendingGeolocationPermissionRequestsCallback):
2722         (LayoutTestController::staticFunctions):
2723         * DumpRenderTree/LayoutTestController.h:
2724         * DumpRenderTree/chromium/LayoutTestController.cpp:
2725         (LayoutTestController::LayoutTestController):
2726         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2727         * DumpRenderTree/chromium/LayoutTestController.h:
2728         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2729         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2730         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2731         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2732         * DumpRenderTree/mac/UIDelegate.h:
2733         * DumpRenderTree/mac/UIDelegate.mm:
2734         (-[UIDelegate numberOfPendingGeolocationPermissionRequests]):
2735         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2736         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2737         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2738         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2739         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2740         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2741         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2742
2743
2744 2011-03-14  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2745
2746         Unreviewed. Modify my email address in committers.py.
2747
2748         * Scripts/webkitpy/common/config/committers.py:
2749
2750 2011-03-13  Joe Wild  <joseph.wild@nokia.com>
2751
2752         Reviewed by Kenneth Rohde Christiansen.
2753
2754         [Qt] QtLauncher does not load the same set of fonts as the DRT
2755         https://bugs.webkit.org/show_bug.cgi?id=34959
2756
2757         This patch adds the option "-use-test-fonts" to the QtTestBrowser.
2758         When this option is used the webkit fonts are loaded the same
2759         as they are in DumpRenderTree.  This option can be used on
2760         QtTestBrowser and run-launcher.  It can only be used
2761         on Linux systems with FcInit and is configured as such.
2762
2763         * QtTestBrowser/launcherwindow.h:
2764         (WindowOptions::WindowOptions):
2765         * QtTestBrowser/main.cpp:
2766         (initWebKitTestFonts):
2767         (launcherMain):
2768         (LauncherApplication::handleUserOptions):
2769
2770 2011-03-12  Dan Bernstein  <mitz@apple.com>
2771
2772         Reviewed by Mark Rowe.
2773
2774         <rdar://problem/8995822> Build DumpRenderTree perl support only for the architectures
2775         DumpRenderTree is being built for.
2776
2777         * DumpRenderTree/mac/PerlSupport/Makefile:
2778
2779 2011-03-12  Dan Bernstein  <mitz@apple.com>
2780
2781         Suggested by Mark Rowe.
2782
2783         * DumpRenderTree/mac/Configurations/Base.xcconfig: Leave C++ exceptions enabled
2784         as they were before r80915.
2785
2786 2011-03-12  Anders Carlsson  <andersca@apple.com>
2787
2788         Reviewed by Sam Weinig.
2789
2790         Should be able to download a PDF to the Downloads folder
2791         https://bugs.webkit.org/show_bug.cgi?id=56256
2792
2793         * MiniBrowser/mac/BrowserWindowController.m:
2794         (-[BrowserWindowController awakeFromNib]):
2795         * WebKitTestRunner/TestController.cpp:
2796         (WTR::TestController::createOtherPage):
2797         (WTR::TestController::initialize):
2798         Update for API changes.
2799
2800 2011-03-11  Anton D'Auria  <adauria@apple.com>
2801
2802         Reviewed and landed by Brady Eidson.
2803
2804         https://bugs.webkit.org/show_bug.cgi?id=51878
2805         Add WebKit1 API to view and delete local storage
2806
2807         Added tests that write to LocalStorage, delete one origin, get list of origins with local storage, delete all origins.
2808
2809         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2810         * DumpRenderTree/LayoutTestController.cpp:
2811         (syncLocalStorageCallback):
2812         (observeStorageTrackerNotificationsCallback):
2813         (deleteAllLocalStorageCallback):
2814         (deleteLocalStorageForOriginCallback):
2815         (originsWithLocalStorageCallback):
2816         (LayoutTestController::staticFunctions):
2817         * DumpRenderTree/LayoutTestController.h:
2818         * DumpRenderTree/StorageTrackerDelegate.h: Added.
2819         * DumpRenderTree/StorageTrackerDelegate.mm: Added.
2820         (-[StorageTrackerDelegate init]):
2821         (-[StorageTrackerDelegate logNotifications:controller:]):
2822         (-[StorageTrackerDelegate originModified:]):
2823         (-[StorageTrackerDelegate dealloc]):
2824         (-[StorageTrackerDelegate setControllerToNotifyDone:]):
2825         * DumpRenderTree/chromium/LayoutTestController.cpp:
2826         (LayoutTestController::LayoutTestController):
2827         (LayoutTestController::deleteAllLocalStorage):
2828         (LayoutTestController::originsWithLocalStorage):
2829         (LayoutTestController::deleteLocalStorageForOrigin):
2830         (observeStorageTrackerNotifications):
2831         (syncLocalStorage):
2832         * DumpRenderTree/chromium/LayoutTestController.h:
2833         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2834         (LayoutTestController::originsWithLocalStorage):
2835         (LayoutTestController::deleteAllLocalStorage):
2836         (LayoutTestController::deleteLocalStorageForOrigin):
2837         (LayoutTestController::observeStorageTrackerNotifications):
2838         (LayoutTestController::syncLocalStorage):
2839         * DumpRenderTree/mac/DumpRenderTree.mm:
2840         (resetDefaultsToConsistentValues):
2841         (allocateGlobalControllers):
2842         (releaseGlobalControllers):
2843         * DumpRenderTree/mac/DumpRenderTreeMac.h:
2844         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2845         (LayoutTestController::syncLocalStorage):
2846         (LayoutTestController::observeStorageTrackerNotifications):
2847         (LayoutTestController::deleteAllLocalStorage):
2848         (LayoutTestController::originsWithLocalStorage):
2849         (LayoutTestController::deleteLocalStorageForOrigin):
2850         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2851         (LayoutTestController::originsWithLocalStorage):
2852         (LayoutTestController::deleteAllLocalStorage):
2853         (LayoutTestController::deleteLocalStorageForOrigin):
2854         (LayoutTestController::observeStorageTrackerNotifications):
2855         (LayoutTestController::syncLocalStorage):
2856         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2857         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2858         (LayoutTestController::clearAllApplicationCaches):
2859         (LayoutTestController::syncLocalStorage):
2860         (LayoutTestController::observeStorageTrackerNotifications):
2861         (LayoutTestController::clearAllDatabases):
2862         (LayoutTestController::deleteAllLocalStorage):
2863         (LayoutTestController::originsWithLocalStorage):
2864         (LayoutTestController::deleteLocalStorageForOrigin):
2865         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2866         (LayoutTestController::syncLocalStorage):
2867         (LayoutTestController::observeStorageTrackerNotifications):
2868         (LayoutTestController::clearAllDatabases):
2869         (LayoutTestController::deleteAllLocalStorage):
2870         (LayoutTestController::originsWithLocalStorage):
2871         (LayoutTestController::deleteLocalStorageForOrigin):
2872
2873 2011-03-11  Jessie Berlin  <jberlin@apple.com>
2874
2875         Reviewed by Adam Roben.
2876
2877         Crash calling WebContext::clearResourceCaches(InMemoryResourceCachesOnly) before the Web
2878         Process has finished launching.
2879         https://bugs.webkit.org/show_bug.cgi?id=56208
2880
2881         * TestWebKitAPI/Tests/WebKit2/SendingMessagesToTheWebProcessBeforeItIsValid.cpp: Added.
2882         (TestWebKitAPI::TEST):
2883         Test that calling WKContextClearResourceCaches works with both options when called before
2884         the Web Process is valid.
2885
2886         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2887         Add the new test.
2888         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2889         Ditto.
2890
2891 2011-03-11  Adam Roben  <aroben@apple.com>
2892
2893         Make it possible to view all leaks from a build at once in Leaks Viewer
2894
2895         You can now give Leaks Viewer the URL of a build results page (e.g.,
2896         <http://build.webkit.org/results/SnowLeopard%20Intel%20Leaks/r80847%20(15493)/>), and it
2897         will load all the leaks files from that build.
2898
2899         Fixes <http://webkit.org/b/56030> Leaks Viewer: Would like to be able to look at all leaks
2900         files from a particular build at once, rather than one at a time
2901
2902         Reviewed by David Kilzer.
2903
2904         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksLoader.js: Added.
2905         (LeaksLoader): Initialize our properties.
2906         (LeaksLoader.prototype.start): If the URL ends in .txt, assume it's a single leaks file and
2907         load it. Otherwise assume it's a build results page URL and start fetching the leaks files
2908         from that page.
2909         (LeaksLoader.prototype._loadLeaksFiles): Tell our client how many leaks files we're loading
2910         so it can provide feedback. Then load each one and pass it to the client.
2911         (LeaksLoader.prototype._loadLeaksFromResultsPage): Load the HTML of the results page, parse
2912         it into a DOM, pull out all the links to leaks files, and load each one.
2913
2914         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParser.js: Added.
2915         (LeaksParser): Initialize our worker.
2916         (LeaksParser.prototype.addLeaksFile): Tell the worker about the leaks file's contents.
2917
2918         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js: Added.
2919         This code mostly came from Worker.js.
2920         (LeaksParserWorker): Initialize our profile.
2921         (LeaksParserWorker.prototype.addLeaksFile): Parse the leaks file and incorporate it into our
2922         profile.
2923         (LeaksParserWorker.prototype._parseLeaks):
2924         (LeaksParserWorker.prototype._createNode):
2925         (LeaksParserWorker.prototype._incorporateLeaks):
2926         Moved these functions here from LeaksViewer. _incorporateLeaks is essentially just a renamed
2927         version of createProfile which adds to this.profile instead of making a new profile each
2928         time.
2929         (onmessage): Parse the file and send back the new profile.
2930
2931         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
2932         (#loading-indicator):
2933         (#spinner):
2934         (#loading-indicator-label):
2935         Tweaked styles to accomodate a longer label.
2936
2937         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
2938         (LeaksViewer.loaded): Set up a loader and parser.
2939
2940         (LeaksViewer.get filesLeftToParse):
2941         (LeaksViewer.set filesLeftToParse):
2942         Added these simple accessors.
2943
2944         (LeaksViewer._didCountLeaksFiles): Callback from LeaksLoader. Stores the count.
2945         (LeaksViewer._didLoadLeaksFile): Callback from LeaksLoader. Passes the file contents off to
2946         the parser.
2947         (LeaksViewer._didParseLeaksFile): Callback from LeaksParser. If all files have been parsed,
2948         tell the ProfilerAgent and mark that we're done loading. (Code came from the old
2949         _loadLeaksFromURL function).
2950         (LeaksViewer._loadLeaksFromURL): Now just calls through to the loader.
2951         (LeaksViewer._loadingIndicatorText): Added. Returns the text that should show up in the
2952         loading indicator, including the number of files being loaded.
2953         (LeaksViewer._loadingStatusChanged): Update the loading indicator's label, too.
2954         (LeaksViewer._updateLoadingIndicatorLabel): Added. Just updates the label!
2955         (LeaksViewer._updateTitle): Moved code to compute the "Loading" text to
2956         _loadingIndicatorText.
2957
2958         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Utilities.js: Added.
2959         (getResource): Moved here from LeaksViewer.js.
2960
2961         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Worker.js: Subsumed by
2962         LeaksParserWorker.js.
2963
2964         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html: Added new JS
2965         files, added a #loading-indicator-label element, and tweaked the prompt wording.
2966
2967 2011-03-11  Adam Roben  <aroben@apple.com>
2968
2969         Don't trigger a build when build.webkit.org's HTML files are modified
2970
2971         Fixes <http://webkit.org/b/56190> Windows bots shouldn't have built r80848/r80851, but did
2972
2973         Reviewed by Dan Bernstein.
2974
2975         * Scripts/webkitpy/common/config/build.py:
2976         (_should_file_trigger_build): Added build.webkit.org's public_html directory to the list of
2977         directories that shouldn't trigger builds. Re-sorted the list.
2978
2979         * Scripts/webkitpy/common/config/build_unittest.py:
2980         (ShouldBuildTest): Added a test to cover the above change.
2981
2982 2011-03-11  Adam Roben  <aroben@apple.com>
2983
2984         Roll out r80848
2985
2986         It was accidentally committed.
2987
2988         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
2989         (LeaksViewer._loadLeaksFromURL):
2990
2991 2011-03-11  Tony Chang  <tony@chromium.org>
2992
2993         Reviewed by Ojan Vafai.
2994
2995         kill hung lighttpd processes on the chromium win bot
2996         https://bugs.webkit.org/show_bug.cgi?id=56152
2997
2998         Sometimes this process doesn't exit and it holds on to
2999         a log file that we can't delete or copy, causing the tests
3000         to go red.
3001
3002         * BuildSlaveSupport/win/kill-old-processes:
3003
3004 2011-03-11  Ilya Sherman  <isherman@chromium.org>
3005
3006         Reviewed by Kent Tamura.
3007
3008         [Chromium] missing HTMLInputElement::setValueForUser() to tests
3009         https://bugs.webkit.org/show_bug.cgi?id=55854
3010
3011         * DumpRenderTree/chromium/LayoutTestController.cpp:
3012         (LayoutTestController::LayoutTestController):
3013         (LayoutTestController::setValueForUser): Added.
3014         * DumpRenderTree/chromium/LayoutTestController.h:
3015
3016 2011-03-10  Peter Kasting  <pkasting@google.com>
3017
3018         Reviewed by Dimitri Glazkov.
3019
3020         Clean up some gross code in TestShellWin.cpp.  No functional change.
3021         https://bugs.webkit.org/show_bug.cgi?id=56048
3022
3023         * DumpRenderTree/chromium/TestShellWin.cpp:
3024         (checkLayoutTestSystemDependencies):
3025
3026 2011-03-10  Keith Kyzivat  <keith.kyzivat@nokia.com>
3027
3028         Reviewed by Laszlo Gombos.
3029
3030         [Qt] Buildfix for platforms where X11 is not available (e.g. Symbian)
3031
3032         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
3033         (WTR::activateFonts): Guard X11-specific code with Q_WS_X11.
3034
3035 2011-03-10  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3036
3037         Reviewed by Kenneth Rohde Christiansen.
3038
3039         [EFL] Make single backing store the default for EWebLauncher
3040         https://bugs.webkit.org/show_bug.cgi?id=55753
3041
3042         Set single backing store the default for EWebLauncher.
3043
3044         * EWebLauncher/main.c:
3045         (main):
3046
3047 2011-03-10  Adam Roben  <aroben@apple.com>
3048
3049         Ignore errors from files being held open when creating a test result archive
3050
3051         Fixes <http://webkit.org/b/55581> Test results don't get uploaded if test-result-archive
3052         fails to delete the results directory
3053
3054         Reviewed by Mark Rowe.
3055
3056         * BuildSlaveSupport/test-result-archive:
3057         (archiveTestResults): Ignore errno 2 when deleting the results directory, since it can be
3058         thrown when a process is holding a file open.
3059
3060 2011-03-10  Sheriff Bot  <webkit.review.bot@gmail.com>
3061
3062         Unreviewed, rolling out r80701.
3063         http://trac.webkit.org/changeset/80701
3064         https://bugs.webkit.org/show_bug.cgi?id=56126
3065
3066         fast/dom/Geolocation/window-close-crash.html fails on Snow
3067         Leopard release builds (Requested by mihaip on #webkit).
3068
3069         * DumpRenderTree/LayoutTestController.cpp:
3070         (LayoutTestController::staticFunctions):
3071         * DumpRenderTree/LayoutTestController.h:
3072         * DumpRenderTree/chromium/LayoutTestController.cpp:
3073         (LayoutTestController::LayoutTestController):
3074         * DumpRenderTree/chromium/LayoutTestController.h:
3075         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3076         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3077         * DumpRenderTree/mac/UIDelegate.h:
3078         * DumpRenderTree/mac/UIDelegate.mm:
3079         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3080         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3081         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3082         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3083
3084 2011-03-10  Philippe Normand  <pnormand@igalia.com>
3085
3086         Reviewed by Gustavo Noronha Silva.
3087
3088         [GTK] run-gtk-tests doesn't fail if a test crashes
3089         https://bugs.webkit.org/show_bug.cgi?id=56089
3090
3091         * Scripts/run-gtk-tests: gtester -k exits with a 0 exit status
3092         even if a test crashes. So run the tests individually and if a
3093         test fails remember its exit code so run-gtk-test fails too, if
3094         required.
3095
3096 2011-01-26  John Knottenbelt  <jknotten@chromium.org>
3097
3098         Reviewed by Dmitry Titov.
3099
3100         Detach Geolocation from Frame when Page destroyed.
3101         https://bugs.webkit.org/show_bug.cgi?id=52877
3102
3103         Extend the layout test controller to expose the number of pending
3104         geolocation requests, so that we can test that the requests have
3105         been cancelled on page close.
3106
3107         * DumpRenderTree/LayoutTestController.cpp:
3108         (numberOfPendingGeolocationPermissionRequestsCallback):
3109         (LayoutTestController::staticFunctions):
3110         * DumpRenderTree/LayoutTestController.h:
3111         * DumpRenderTree/chromium/LayoutTestController.cpp:
3112         (LayoutTestController::LayoutTestController):
3113         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
3114         * DumpRenderTree/chromium/LayoutTestController.h:
3115         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3116         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
3117         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3118         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
3119         * DumpRenderTree/mac/UIDelegate.h:
3120         * DumpRenderTree/mac/UIDelegate.mm:
3121         (-[UIDelegate numberOfPendingGeolocationPermissionRequests]):
3122         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3123         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
3124         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3125         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3126         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
3127         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3128         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
3129
3130
3131 2011-03-09  Adam Roben  <aroben@apple.com>
3132
3133         Hide Leaks Viewer's URL prompt by default
3134
3135         We will show it as needed. I think I left it visible by default by accident after doing some
3136         testing.
3137
3138         Fixes <http://webkit.org/b/56031> Leaks Viewer: URL prompt overlay shouldn't appear when a
3139         URL is passed as a query parameter, but does
3140
3141         Reviewed by Simon Fraser.
3142
3143         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html:
3144
3145 2011-03-09  Adam Roben  <aroben@apple.com>
3146
3147         Don't use Element.classList or box-shadow in Leaks Viewer
3148
3149         They aren't supported by Safari 5. Luckily we have substitutes for them!
3150
3151         Fixes <http://webkit.org/b/56035> Leaks viewer doesn't work in Safari 5
3152
3153         Reviewed by Simon Fraser.
3154
3155         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
3156         (#url-prompt): Use -webkit-box-shadow instead of box-shadow.
3157
3158         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
3159         (LeaksViewer.urlPromptButtonClicked):
3160         (LeaksViewer._displayURLPrompt):
3161         (LeaksViewer._setLoadingIndicatorHidden):
3162         Use add/removeStyleClass (from utilities.js) instead of Element.classList.
3163
3164 2011-03-09  Adam Roben  <aroben@apple.com>
3165
3166         Add a link to the Leaks Viewer tool on the build.webkit.org homepage
3167
3168         Rubber-stamped by David Kilzer.
3169
3170         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
3171
3172 2011-03-09  Adam Roben  <aroben@apple.com>
3173
3174         Add a Leaks Viewer tool to build.webkit.org
3175
3176         This tool parses leaks from the files generated by the leaks bot and displays them in a
3177         view similar to the Web Inspector's Profiles pane (in fact, it uses the Web Inspector's
3178         code).
3179
3180         The URL of the leaks file can be entered in a prompt when the tools is first shown, or can
3181         be passed to the tool via the "url" query parameter.
3182
3183         Only one leaks file can be viewed at a time for now. Only the number of leaks, as opposed to
3184         the number of leaked bytes, is shown. And this tool has made apparent some bugs in the Web
3185         Inspector's Heavy profile view. But it's still pretty useful as-is.
3186
3187         Fixes <http://webkit.org/b/56028> Would like a Shark-like tool for viewing leaks from leak bots
3188
3189         Reviewed by Darin Adler.
3190
3191         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css: Added.
3192         (#url-prompt-container): This is the dark overlay that is shown behind the URL prompt.
3193         (#url-prompt): This is the prompt itself.
3194
3195         (#loading-indicator):
3196         (#loading-indicator > img):
3197         These show a spinner in the bottom-right when we're loading a leaks file.
3198
3199         (.percent-time-status-bar-item): Hide the Percent button since we never want to show leaks
3200         as percentages.
3201
3202         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js: Added.
3203         (LeaksViewer.loaded): Initialize ourselves and start loading the leaks file (or prompt for a
3204         URL if one wasn't given to us as a query parameter).
3205
3206         (LeaksViewer.get loading):
3207         (LeaksViewer.set loading):
3208         (LeaksViewer.get url):
3209         (LeaksViewer.set url):
3210         Pretty simple accessors.
3211
3212         (LeaksViewer.urlPromptButtonClicked): Start loading the URL from the prompt and hide the
3213         prompt.
3214         (LeaksViewer._displayURLPrompt): Show the prompt and focus the URL input.
3215         (LeaksViewer._loadLeaksFromURL): Start fetching the leaks file. When we've retrieved the
3216         file, hand it off to a Web Worker that will parse it into a fake "profile", then hand off
3217         the profile to the Web Inspector code once it's been created.
3218         (LeaksViewer._loadingStatusChanged): Update our loading indicator and title.
3219         (LeaksViewer._setLoadingIndicatorHidden): Simply hide or show the indicator.
3220         (LeaksViewer._updateTitle): Set our title based on our URL and loading status.
3221         (getResource): Helper function to fetch a resource via XHR and pass it to a callback.
3222
3223         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js: Added.
3224         (WebInspector.UIString): Just a simple implementation since this tool isn't localized.
3225         (ProfilerAgent.getProfile): Store the callback.
3226         (ProfilerAgent.profileReady): Call the callback.
3227         (monkeyPatchInspectorObjects): Fix up WebInspector.ProfileDataGridNode to show the self leak
3228         count and total leak counts as real values, not percentages or milliseconds.
3229
3230         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Worker.js: Added.
3231         (onmessage): Create a profile based on the leaks file and pass it back to our caller.
3232         (parseLeaks): Extract call stacks out of a leaks file.
3233         (createNode): Helper function to create a new empty profile node.
3234         (createProfile): Take the leak stacks and turn them into a fake "profile" for consumption by
3235         WebInspector.ProfileView.
3236
3237         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html: Added.
3238
3239 2011-03-09  Dan Bernstein  <mitz@apple.com>
3240
3241         Reviewed by Adam Roben.
3242
3243         Combine multiple --ignore-tests values
3244         https://bugs.webkit.org/show_bug.cgi?id=56016
3245
3246         * Scripts/old-run-webkit-tests:
3247
3248 2011-03-08  Kenji Imasaki  <imasaki@chromium.org>
3249
3250         Reviewed by David Levin.
3251
3252         Adding myself to the committer file.
3253
3254         * Scripts/webkitpy/common/config/committers.py:
3255
3256 2011-03-08  Jessie Berlin  <jberlin@apple.com>
3257
3258         Rubber-stamped by Adam Roben.
3259
3260         Fix two leaks I introduced into the API tests.
3261
3262         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
3263         (TestWebKitAPI::TEST):
3264
3265 2011-03-08  Jessie Berlin  <jberlin@apple.com>
3266
3267         Reviewed by Anders Carlsson.
3268
3269         Crash in CFNetwork visiting google.com
3270         https://bugs.webkit.org/show_bug.cgi?id=55958
3271
3272         Add a test for not trying to copy a null CFURLResponse.
3273
3274         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp: Added.
3275         (TestWebKitAPI::TEST):
3276         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3277
3278 2011-03-08  Hayato Ito  <hayato@chromium.org>
3279
3280         Reviewed by Ojan Vafai.
3281
3282         [NRWT] Renamed a FailureWithType class to a ComparisonTestFailure class.
3283
3284         FailureWithType is a confusing naming because we have removed test_type/* classes in r79840.
3285
3286         https://bugs.webkit.org/show_bug.cgi?id=55450
3287
3288         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
3289
3290 2011-03-08  Carlos Garcia Campos  <cgarcia@igalia.com>
3291
3292         Reviewed by Martin Robinson.
3293
3294         [GTK] Add layoutTestController.setValueForUser() after r80412
3295         https://bugs.webkit.org/show_bug.cgi?id=55862
3296
3297         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3298         (LayoutTestController::setValueForUser): Implement setValueForUser()
3299
3300 2011-03-08  Patrick Gansterer  <paroga@webkit.org>
3301
3302         Reviewed by Adam Barth.
3303
3304         Add script_shell_command to WebKitPort
3305         https://bugs.webkit.org/show_bug.cgi?id=55925
3306
3307         Add a central place where we generate the shell command from the script name.
3308         This function will be used later to detect the correct script interpreter on Win32.
3309
3310         * Scripts/webkitpy/common/config/ports.py:
3311         * Scripts/webkitpy/layout_tests/port/base.py:
3312         * Scripts/webkitpy/tool/steps/abstractstep.py:
3313         * Scripts/webkitpy/tool/steps/preparechangelog.py:
3314
3315 2011-03-07  Ojan Vafai  <ojan@chromium.org>
3316
3317         Reviewed by Adam Barth.
3318
3319         add webkit-patch attach-to-bug for posting to bugzilla from the commandline
3320         https://bugs.webkit.org/show_bug.cgi?id=55749
3321
3322         * Scripts/webkitpy/tool/commands/upload.py:
3323         * Scripts/webkitpy/tool/commands/upload_unittest.py:
3324         * Scripts/webkitpy/tool/steps/__init__.py:
3325         * Scripts/webkitpy/tool/steps/attachtobug.py: Added.
3326         * Scripts/webkitpy/tool/steps/options.py:
3327
3328 2011-03-07  Daniel Cheng  <dcheng@chromium.org>
3329
3330         Reviewed by David Levin.
3331
3332         Add support for DataTransferItems
3333         https://bugs.webkit.org/show_bug.cgi?id=55115
3334
3335         Enable data transfer items in DRT.
3336
3337         * DumpRenderTree/chromium/TestShell.cpp:
3338         (TestShell::TestShell):
3339
3340 2011-03-06  Ojan Vafai  <ojan@chromium.org>
3341
3342         Reviewed by Tony Chang.
3343
3344         [test dashboard] pull treemap files
3345         https://bugs.webkit.org/show_bug.cgi?id=55852
3346
3347         * TestResultServer/handlers/dashboardhandler.py:
3348
3349 2011-03-03  Hayato Ito  <hayato@chromium.org>
3350
3351         Reviewed by Mihai Parparita.
3352
3353         [NRWT] Clear output image file used by DumpRenderTree to make sure the
3354         previous image should not be used in the ChromiumDriver.
3355
3356         Also make sure that output image from the ChromiumDriver should be ''
3357         (empty string) if a test crashes for consistency with the WebKitDriver
3358         implementation.
3359
3360         https://bugs.webkit.org/show_bug.cgi?id=55746
3361
3362         * Scripts/webkitpy/layout_tests/port/chromium.py:
3363
3364 2011-03-07  Zan Dobersek  <zandobersek@gmail.com>
3365
3366         Reviewed by Martin Robinson.
3367
3368         [Gtk] fast/js/navigator-language.html fails locally
3369         https://bugs.webkit.org/show_bug.cgi?id=55880
3370
3371         Add LANG variable to the clean environment when running
3372         old-run-webkit-tests script.
3373
3374         * Scripts/old-run-webkit-tests:
3375
3376 2011-03-07  Tony Chang  <tony@chromium.org>
3377
3378         Reviewed by Mihai Parparita.
3379
3380         [Chromium] Find .checksum files without .pngs and vice-versa
3381         https://bugs.webkit.org/show_bug.cgi?id=55236
3382
3383         * Scripts/find-mismatched-layout-test-results: Added. A script for finding
3384             mismatched results.
3385
3386 2011-03-07  Chris Fleizach  <cfleizach@apple.com>
3387
3388         Reviewed by Beth Dakin.
3389
3390         AX: WK1 needs to use the ScrollView attachment for AXScrollArea, WK2 should not use this element.
3391         https://bugs.webkit.org/show_bug.cgi?id=55706
3392
3393         The rootElement in DRT should point to the scroll view. In WK1, that will be the parent of the rootObject.
3394
3395         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
3396         (AccessibilityController::focusedElement):
3397            Remove FIXME comment about caching the focusedElement. In fact, we shouldn't cache this 
3398            because it could change at any time.
3399         (AccessibilityController::rootElement):
3400
3401 2011-03-07  Sam Weinig  <sam@webkit.org>
3402
3403         Reviewed by Anders Carlsson.
3404
3405         Add unableToImplementPolicy callback for WebKit2 policy client
3406         <rdar://problem/9071902>
3407         https://bugs.webkit.org/show_bug.cgi?id=55884
3408
3409         * MiniBrowser/mac/BrowserWindowController.m:
3410         (-[BrowserWindowController awakeFromNib]):
3411         Update policy client initialization struct for new member.
3412
3413 2011-03-07  Sam Weinig  <sam@webkit.org>
3414
3415         Reviewed by Anders Carlsson.
3416
3417         Replace WebKit2's decidePolicyForMIMEType with decidePolicyForResponse
3418         https://bugs.webkit.org/show_bug.cgi?id=55827
3419
3420         * MiniBrowser/mac/BrowserWindowController.m:
3421         (decidePolicyForResponse):
3422         (-[BrowserWindowController awakeFromNib]):
3423         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
3424         (TestWebKitAPI::decidePolicyForResponse):
3425         (TestWebKitAPI::TEST):
3426         Update tools for new name.
3427
3428 2011-03-06  Daniel Bates  <dbates@rim.com>
3429
3430         Reviewed by Eric Seidel and David Kilzer.
3431
3432         Fix misspelled word in build-webkit's checkForJavaSDK() and sort forward declarations
3433         https://bugs.webkit.org/show_bug.cgi?id=55503
3434
3435         Fix misspelled word "Dowloads" [sic] in the message printed to standard output
3436         in checkForJavaSDK().
3437
3438         Also, remove extraneous space in function prototype for unlinkZeroFiles.
3439
3440         * Scripts/build-webkit:
3441
3442 2011-03-05  Brian Weinstein  <bweinstein@apple.com>
3443
3444         Reviewed by Sam Weinig.
3445
3446         Fix Web Process crashes caused by https://bugs.webkit.org/show_bug.cgi?id=53919.
3447
3448         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3449         (WTR::InjectedBundlePage::willSendRequestForFrame): Retain the WKURLRequestRef returned
3450             by willSendRequestForFrame. The API expects a retained reference to the URL request.
3451
3452 2011-03-05  Ilya Sherman  <isherman@chromium.org>
3453
3454         Reviewed by Darin Adler.
3455
3456         HTMLInputElement::setValue() should schedule change event when the element is focused
3457         In service of https://code.google.com/p/chromium/issues/detail?id=42716
3458         https://bugs.webkit.org/show_bug.cgi?id=53160
3459
3460         * DumpRenderTree/LayoutTestController.cpp:
3461         (setValueForUserCallback):
3462         (LayoutTestController::staticFunctions):
3463         * DumpRenderTree/LayoutTestController.h:
3464         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3465         (LayoutTestController::setValueForUser): Stubbed out; need real implementation.
3466         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3467         (LayoutTestController::setValueForUser): Expose HTMLInputElement::setValueForUser() to tests
3468         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3469         (LayoutTestController::setValueForUser): Stubbed out; need real implementation.
3470         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3471         (LayoutTestController::setValueForUser): Stubbed out; need real implementation.
3472         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3473         (LayoutTestController::setValueForUser): Stubbed out; need real implementation.
3474
3475 2011-03-04  Mark Rowe  <mrowe@apple.com>
3476
3477         Reviewed by Alexey Proskuryakov.
3478
3479         <rdar://problem/9055252> DumpRenderTree is crashing with GuardMalloc
3480
3481         GuardMalloc does not expect the memory containing its malloc_zone_t to ever be read-only.
3482         
3483         * DumpRenderTree/mac/CheckedMalloc.cpp:
3484         (protectionOfRegion): Retrieve the protection flags for the VM region containing the given address.
3485         (makeLargeMallocFailSilently): Save the initial protection flags, temporarily make the region writeable,
3486         and then restore the initial protection flags when we're done.
3487
3488 2011-03-04  Evan Martin  <evan@chromium.org>
3489
3490         Reviewed by Tony Chang.
3491
3492         [gdb] pretty-print KURL in gdb
3493         https://bugs.webkit.org/show_bug.cgi?id=55788
3494
3495         * gdb/webkit.py: extend the pretty-printers to print WTF::CString
3496         and KURLGooglePrivate.  As always, "p/r" can be used to sidestep
3497         pretty-printing.
3498
3499 2011-03-03  Timothy Hatcher  <timothy@apple.com>
3500
3501         Update the tests that use WKPageRunJavaScriptInMainFrame use the WKSerializedScriptValueRef.
3502
3503         Reviewed by Darin Adler.
3504
3505         * TestWebKitAPI/JavaScriptTest.cpp:
3506         (TestWebKitAPI::javaScriptCallback):
3507         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
3508         (TestWebKitAPI::didRunJavaScript):
3509         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
3510         (TestWebKitAPI::nullJavaScriptCallback):
3511         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
3512         (TestWebKitAPI::didRunJavaScript):
3513
3514 2011-03-03  Timothy Hatcher  <timothy@apple.com>
3515
3516         Make run-api-tests show failed if a test fails.
3517
3518         https://webkit.org/b/55725
3519
3520         Reviewed by Sam Weinig.
3521
3522         * Scripts/run-api-tests:
3523         (runTest): Remove "my" from the nested $result assignment so the
3524         check outside the condition sees the real result.
3525
3526 2011-03-02  MORITA Hajime  <morrita@google.com>
3527
3528         Reviewed by Kent Tamura.
3529
3530         [Chromium][DRT] WebTask should use webkit_support::TaskAdaptor
3531         https://bugs.webkit.org/show_bug.cgi?id=55434
3532
3533         Changed WebTask to be a subclass of webkit_support::TaskAdaptor
3534         and passed the object webkit_support::PostDelayedTask directly.
3535
3536         Note that the change keeps postTask() as is because it has a
3537         semantics taht webkit_support::PostDelayedTask() has; It jumps to
3538         the main thread.
3539
3540         * DumpRenderTree/chromium/Task.cpp:
3541         (postDelayedTask):
3542         * DumpRenderTree/chromium/Task.h:
3543         (WebTask::Run):
3544
3545 2011-03-03  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
3546
3547         Reviewed by Kenneth Rohde Christiansen.
3548
3549         [QT] Implement mock client-based geolocation for layout testing
3550         https://bugs.webkit.org/show_bug.cgi?id=54334
3551
3552         Implement testing for Client-Based geolocation for QtWebkit.
3553
3554         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3555         (WebCore::DumpRenderTree::DumpRenderTree):
3556         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3557         (LayoutTestController::reset):
3558         (LayoutTestController::setGeolocationPermission):
3559         (LayoutTestController::setMockGeolocationError):
3560         (LayoutTestController::setMockGeolocationPosition):
3561
3562 2011-03-03  Sheriff Bot  <webkit.review.bot@gmail.com>
3563
3564         Unreviewed, rolling out r80237.
3565         http://trac.webkit.org/changeset/80237
3566         https://bugs.webkit.org/show_bug.cgi?id=55714
3567
3568         Windows bots aren't ready to be core (Requested by aroben on
3569         #webkit).
3570
3571         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
3572         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3573
3574 2011-03-03  Mihai Parparita  <mihaip@chromium.org>
3575
3576         Reviewed by Tony Chang.
3577
3578         NRWT: AttributeError: TestRunner2 instance has no attribute '_cancel_workers'
3579         https://bugs.webkit.org/show_bug.cgi?id=55694
3580         
3581         Fixes for interruptions in NRWT:
3582         - Make TestRunInterruptedException be pickleable correctly (the base
3583           Exception class defines a __reduce__ that does not include the reason)
3584         - Fix ordering of returned arguments from TestRunner2._run_tests
3585           (interrupted and keyboard_interrupted were reversed)
3586         - Fix cancel_workers callsites (was using old name).
3587         - In handle_exception re-raise actual exception instance that was thrown
3588
3589         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3590         * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
3591         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
3592         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3593
3594 2011-03-03  Qi Zhang  <qi.2.zhang@nokia.com>
3595
3596         Unreviewed.
3597
3598         Adding myself as a committer.
3599
3600         * Scripts/webkitpy/common/config/committers.py:
3601
3602 2011-03-03  Tony Gentilcore  <tonyg@chromium.org>
3603
3604         Reviewed by Mihai Parparita.
3605
3606         Teach sheriffbot to answer whois commands
3607         https://bugs.webkit.org/show_bug.cgi?id=55687
3608
3609         * Scripts/webkitpy/tool/bot/irc_command.py:
3610         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
3611         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
3612
3613 2011-03-03  Victoria Kirst  <vrk@google.com>
3614
3615         Reviewed by Eric Carlson.
3616
3617         Enable media tests in chromium-gpu/test_expectations
3618         https://bugs.webkit.org/show_bug.cgi?id=53608
3619
3620         Add media folder to the list of GPU test paths.
3621
3622         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3623
3624 2011-03-03  Adam Roben  <aroben@apple.com>
3625
3626         Work around a bug in KURL's parsing of Windows-style absolute file: URLs
3627
3628         Fixes <http://webkit.org/b/55674> Many tests fail in WebKit2 mode on Windows due to
3629         incorrect parsing of absolute Windows-style file: URLs
3630
3631         Reviewed by Tim Hatcher.
3632
3633         * WebKitTestRunner/TestInvocation.cpp:
3634         (WTR::createWKURL): Add a "localhost" host to file: URLs we create to work around
3635         <http://webkit.org/b/55683>.
3636
3637 2011-03-03  Tony Chang  <tony@chromium.org>
3638
3639         Reviewed by Dimitri Glazkov.
3640
3641         [chromium] Run kill-old-processes on the chromium-win bot too
3642         https://bugs.webkit.org/show_bug.cgi?id=55630
3643
3644         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3645         * BuildSlaveSupport/win/kill-old-processes: Add wdiff.exe to the kill list.
3646
3647 2011-03-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3648
3649         Reviewed by Martin Robinson.
3650
3651         [GTK] DRT needs implementation of EventSender.scheduleAsynchronousClick
3652         https://bugs.webkit.org/show_bug.cgi?id=53960
3653
3654         * DumpRenderTree/gtk/EventSender.cpp:
3655         (sendClick):
3656         (scheduleAsynchronousClickCallback):
3657
3658 2011-03-03  Adam Roben  <aroben@apple.com>
3659
3660         Look for Windows-style paths when checking whether a test is an Inspector test
3661
3662         WTR part of <http://webkit.org/b/55672> <rdar://problem/9080867> All inspector tests time
3663         out or crash on Windows 7 Release (WebKit2 Tests)
3664
3665         Reviewed by Darin Adler.
3666
3667         * WebKitTestRunner/TestInvocation.cpp:
3668         (WTR::shouldOpenWebInspector): Also look for backslashes, since that's what we'll get on
3669         Windows.
3670
3671 2011-03-03  Adam Roben  <aroben@apple.com>
3672
3673         Make Windows 7 Release (Tests) a core builder
3674
3675         We can probably make Windows XP Debug (Tests) a core builder, too, but we should probably
3676         give it a few more days of greenness first.
3677
3678         Fixes <http://webkit.org/b/55665> Windows 7 Release (Tests) should be a core builder
3679
3680         Reviewed by Andreas Kling.
3681
3682         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
3683         (BuildBot): Added a regexp to match Windows 7 Release (Tests).
3684
3685         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3686         (BuildBotTest): Updated the list of builders to match the current list on build.webkit.org.
3687         Updated the core regexps to match the buildbot module. Updated the expected results to match
3688         the current set of core builders.
3689
3690 2011-03-03  Benjamin Poulain  <benjamin.poulain@nokia.com>
3691
3692         Reviewed by Andreas Kling.
3693
3694         Adding myself as a reviewer.
3695
3696         * Scripts/webkitpy/common/config/committers.py:
3697
3698 2011-03-03  Lukasz Slachciak  <l.slachciak@samsung.com>
3699
3700         Reviewed by Xan Lopez.
3701
3702         [GTK] Extended application cache database API and added unit tests file.
3703         https://bugs.webkit.org/show_bug.cgi?id=55335
3704
3705         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: removed external declaration
3706         of webkit_application_cache_set_maximum_size due to API exposal.
3707
3708 2011-03-02  Ojan Vafai  <ojan@chromium.org>
3709
3710         Reviewed by Adam Barth.
3711
3712         make webkit-patch upload work for security bugs
3713         https://bugs.webkit.org/show_bug.cgi?id=55655
3714
3715         The problem is that we shell out to prepare-ChangeLog,
3716         which does not authenticate with bugzilla. All it needs from
3717         bugzilla is the bug title though. We just pass it through from
3718         webkit-patch instead.
3719
3720         * Scripts/prepare-ChangeLog:
3721         * Scripts/webkitpy/common/net/bugzilla/bug.py:
3722         * Scripts/webkitpy/tool/steps/preparechangelog.py:
3723
3724 2011-03-01  Ojan Vafai  <ojan@chromium.org>
3725
3726         Reviewed by Tony Chang.
3727
3728         [test-dashboard] make gtest JSON match layout-tests JSON
3729         https://bugs.webkit.org/show_bug.cgi?id=55556
3730
3731         http://trac.webkit.org/changeset/80090 stopped converting time_ms to t.
3732         Make this code match.
3733
3734         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3735
3736 2011-03-02  Dirk Pranke  <dpranke@chromium.org>
3737
3738         Reviewed by Tony Chang.
3739
3740         NRWT - implement Linux Hardy 64-bit port support. This involves
3741         adding support for non-'x86' architectures and updating the
3742         "deduplicate_tests" script to correctly understand that
3743         port.name() is not always equal to basename(port.baseline_path()).
3744
3745         This change introduces two new port names: 'chromium-linux-x86'
3746         and 'chromium-linux-x86_64'. Using the prior 'chromium-linux'
3747         flag will cause the code to determine which one to use at
3748         runtime, just like we currently do with 'chromium-win'.
3749
3750         https://bugs.webkit.org/show_bug.cgi?id=55535
3751
3752         * Scripts/webkitpy/common/system/executive_mock.py:
3753           Handle 'return_stderr' keyword arg to run_command()
3754         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
3755         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
3756         * Scripts/webkitpy/layout_tests/port/base.py:
3757         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3758         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
3759         * Scripts/webkitpy/layout_tests/port/factory.py:
3760         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
3761
3762 2011-03-02  Kevin Ollivier  <kevino@theolliviers.com>
3763
3764         [wx] Build fix, make sure we put the wxWebKit dylib in the right directory and
3765         update symlinks accordingly.
3766
3767         * wx/packaging/build-mac-installer.py:
3768
3769 2011-03-02  Sheriff Bot  <webkit.review.bot@gmail.com>
3770
3771         Unreviewed, rolling out r80139.
3772         http://trac.webkit.org/changeset/80139
3773         https://bugs.webkit.org/show_bug.cgi?id=55620
3774
3775         failing and crashing tests on Snow Leopard bot (Requested by
3776         mihaip1 on #webkit).
3777
3778         * DumpRenderTree/LayoutTestController.cpp:
3779         (LayoutTestController::staticFunctions):
3780         * DumpRenderTree/LayoutTestController.h:
3781         * DumpRenderTree/chromium/LayoutTestController.cpp:
3782         (LayoutTestController::LayoutTestController):
3783         * DumpRenderTree/chromium/LayoutTestController.h:
3784         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3785         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3786         * DumpRenderTree/mac/UIDelegate.h:
3787         * DumpRenderTree/mac/UIDelegate.mm:
3788         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3789         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3790         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3791         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3792
3793 2011-03-02  Adam Roben  <aroben@apple.com>
3794
3795         Wait for force a paint in WebKitTestRunner until we're actually ready to dump the output
3796
3797         This matches DumpRenderTree on Windows.
3798
3799         Fixes <http://webkit.org/b/55469> <rdar://problem/9068539> REGRESSION (r79863): Lots of
3800         dom/html/level2/html/HTMLFrameElement*.html tests crashing in FrameView::paintOverhangAreas
3801         in WebKit2
3802
3803         Reviewed by Beth Dakin.
3804
3805         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3806         (WTR::InjectedBundlePage::dump): Moved code to force a paint here...
3807         (WTR::InjectedBundlePage::didFinishLoadForFrame): ...from here.
3808
3809 2011-03-02  Daniel Cheng  <dcheng@chromium.org>
3810
3811         Reviewed by David Levin.
3812
3813         Add feature define for data transfer items
3814         https://bugs.webkit.org/show_bug.cgi?id=55510
3815
3816         * Scripts/build-webkit:
3817
3818 2011-03-02  Adam Roben  <aroben@apple.com>
3819
3820         Look in the new-to-SnowLeopard location for crash logs on SnowLeopard and newer
3821
3822         ReportCrash saves logs to ~/Library/Logs/CrashReporter on Leopard, but to
3823         ~/Library/Logs/DiagnosticReports on SnowLeopard. old-run-webkit-tests was only looking in
3824         the former location, but was getting lucky on some SnowLeopard machines because symlinks
3825         were being created there pointing into DiagnosticReports. For machines without these
3826         symlinks, crash logs were not getting captured.
3827
3828         Fixes <http://webkit.org/b/55607> old-run-webkit-tests doesn't capture crash logs on some
3829         SnowLeopard machines
3830
3831         Reviewed by Eric Seidel.
3832
3833         * Scripts/old-run-webkit-tests:
3834         (captureSavedCrashLog): Look in ~/Library/Logs/DiagnosticReports on SnowLeopard and newer.
3835
3836 2011-03-02  Adam Roben  <aroben@apple.com>
3837
3838         Don't try to capture crash logs on platforms that haven't implemented that feature
3839
3840         Fixes <http://webkit.org/b/55504> Use of uninitialized value in numeric lt (<) at
3841         Tools/Scripts/old-run-webkit-tests line 1778 seen on Qt bots after a crash
3842
3843         Reviewed by Joseph Pecoraro.
3844
3845         * Scripts/old-run-webkit-tests:
3846         (captureSavedCrashLog): Bail if we don't have a crash log glob.
3847         (findNewestFileMatchingGlob): Fix a buggy test for when no paths match the glob. This isn't
3848         strictly required to fix bug 55504, but seems worthwhile.
3849
3850 2011-01-26  John Knottenbelt  <jknotten@chromium.org>
3851
3852         Reviewed by Dmitry Titov.
3853
3854         Detach Geolocation from Frame when Page destroyed.
3855         https://bugs.webkit.org/show_bug.cgi?id=52877
3856
3857         Extend the layout test controller to expose the number of pending
3858         geolocation requests, so that we can test that the requests have
3859         been cancelled on page close.
3860
3861         * DumpRenderTree/LayoutTestController.cpp:
3862         (numberOfPendingGeolocationPermissionRequestsCallback):
3863         (LayoutTestController::staticFunctions):
3864         * DumpRenderTree/LayoutTestController.h:
3865         * DumpRenderTree/chromium/LayoutTestController.cpp:
3866         (LayoutTestController::LayoutTestController):
3867         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
3868         * DumpRenderTree/chromium/LayoutTestController.h:
3869         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3870         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
3871         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3872         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
3873         * DumpRenderTree/mac/UIDelegate.h:
3874         * DumpRenderTree/mac/UIDelegate.mm:
3875         (-[UIDelegate numberOfPendingGeolocationPermissionRequests]):
3876         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3877         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
3878         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3879         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3880         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
3881         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3882         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
3883
3884
3885 2011-03-01  Kent Tamura  <tkent@chromium.org>
3886
3887         Reviewed by Dimitri Glazkov.
3888
3889         Assertion fails when a form validation bubble appears
3890         https://bugs.webkit.org/show_bug.cgi?id=55550
3891
3892         Test: fast/forms/interactive-validation-attach-assertion.html
3893
3894         * DumpRenderTree/chromium/WebPreferences.cpp:
3895         (WebPreferences::applyTo): Enable the interactive validation feature by
3896           default. This matches to Chromium browser.
3897
3898 2011-03-01  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3899
3900         Reviewed by Kent Tamura.
3901
3902         Remove efl port style exception of Webcore/JavaScriptCore
3903         https://bugs.webkit.org/show_bug.cgi?id=55549
3904
3905         WebCore and JavaScriptCore need to adhere WebKit coding style.
3906
3907         * Scripts/webkitpy/style/checker.py:
3908
3909 2011-03-01  Tony Chang  <tony@chromium.org>
3910
3911         Reviewed by Ojan Vafai.
3912
3913         [chromium] clean up temp files on chromium-mac builder too
3914         https://bugs.webkit.org/show_bug.cgi?id=55525
3915
3916         * BuildSlaveSupport/chromium/remove-crash-logs:
3917
3918 2011-02-28  Ojan Vafai  <ojan@chromium.org>
3919
3920         Reviewed by Tony Chang.
3921
3922         wrap json in a function call to afford cross-domain loading
3923         https://bugs.webkit.org/show_bug.cgi?id=55353
3924
3925         Also delete the code that compacts the JSON. It turns out this
3926         breaks the rebaseline tool and is probably a premature optimization anyways.
3927
3928         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3929         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3930         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3931         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
3932
3933 2011-03-01  Sheriff Bot  <webkit.review.bot@gmail.com>
3934
3935         Unreviewed, rolling out r80079.
3936         http://trac.webkit.org/changeset/80079
3937         https://bugs.webkit.org/show_bug.cgi?id=55547
3938
3939         "Broke the Win debug build?" (Requested by dcheng on #webkit).
3940
3941         * Scripts/build-webkit:
3942
3943 2011-03-01  Mark Rowe  <mrowe@apple.com>
3944
3945         Reviewed by Sam Weinig.
3946
3947         Update verification scripts to handle WebKit2.
3948
3949         * Scripts/check-for-global-initializers: Skip object files that use RefCountedLeakChecker.
3950         * Scripts/check-for-inappropriate-files-in-framework: Add some inappropriate file types for
3951         WebKit2.
3952
3953 2011-03-01  Daniel Cheng  <dcheng@chromium.org>
3954
3955         Reviewed by David Levin.
3956
3957         Add feature define for data transfer items
3958         https://bugs.webkit.org/show_bug.cgi?id=55510
3959
3960         * Scripts/build-webkit:
3961
3962 2011-02-23  Joseph Pecoraro  <joepeck@webkit.org>
3963
3964         Reviewed by Timothy Hatcher.
3965
3966         All Console Messages should be passed to ChromeClients.
3967         https://bugs.webkit.org/show_bug.cgi?id=54926
3968
3969         Update DumpRenderTree's UIDelegate to use the new console message delegate.
3970
3971         * DumpRenderTree/mac/UIDelegate.mm:
3972         (-[UIDelegate webView:addMessageToConsole:withSource:]):
3973
3974 2011-03-01  Dirk Pranke  <dpranke@chromium.org>
3975
3976         Reviewed by Adam Barth.
3977
3978         Tragically, we stopped running the python unit tests
3979         on Chromium Win just as I was getting them to be green.
3980         This patch turns them back on.
3981
3982         https://bugs.webkit.org/show_bug.cgi?id=55521
3983
3984         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3985
3986 2011-03-01  Dirk Pranke  <dpranke@chromium.org>
3987
3988         Reviewed by Adam Roben.
3989
3990         Disable
3991         webkitpy.common.system.executive_unittest.ExecutiveTest.\
3992            test_kill_all fails on win until it can be properly triaged.
3993
3994         https://bugs.webkit.org/show_bug.cgi?id=54790
3995
3996         * Scripts/webkitpy/common/system/executive_unittest.py:
3997
3998     2011-03-01  Helder Correia  <helder@sencha.com>
3999
4000             Unreviewed. Add myself to committers.py.
4001
4002             * Scripts/webkitpy/common/config/committers.py:
4003
4004 2011-03-01  Adam Roben  <aroben@apple.com>
4005
4006         Give up if a crash log for the web process is taking too long to be saved on Windows
4007
4008         This should keep the bots from getting stuck while waiting for a crash log, if writing a
4009         crash log ever hangs or the UI process for some reason doesn't notice it's finished.
4010
4011         Fixes <http://webkit.org/b/55499> WebKitTestRunner can hang forever waiting for a crash log
4012         to be saved for the web process
4013
4014         Reviewed by Steve Falkenburg.
4015
4016         * WebKitTestRunner/win/TestControllerWin.cpp:
4017         (WTR::runRunLoopUntil): Moved code to run the run loop here here from platformRunUntil.
4018         Generalized the code slightly to handle the optional object to wait on.
4019         (WTR::TestController::platformRunUntil): Use the new runRunLoopUntil function, and also use
4020         it (with a timeout) when waiting for a crash log for the web process to be saved. This will
4021         prevent us from waiting forever.
4022
4023 2011-03-01  Adam Roben  <aroben@apple.com>
4024
4025         Give WebKitLauncherWin's PDB file a name different from WebKit's
4026
4027         WebKitLauncherWin (which builds WebKit.exe) and WebKit (which builds WebKit.dll) were
4028         fighting over the same PDB file, meaning that one of them was going to lose and not have
4029         symbols. WebKitLauncherWin's PDB file is now named WebKitLauncherWin.pdb.
4030
4031         Fixes <http://webkit.org/b/55495> Crashes in WebKit.dll have bad backtraces for some test
4032         runs (due to missing symbols)
4033
4034         Reviewed by David Kilzer.
4035
4036         * WebKitLauncherWin/WebKitLauncherWinCommon.vsprops: Use the project name,
4037         "WebKitLauncherWin", instead of the target name, "WebKit", when naming the PDB file.
4038
4039 2011-03-01  Adam Roben  <aroben@apple.com>
4040
4041         Count web process crashes toward the --exit-after-n-crashes-or-timeouts limit
4042
4043         Fixes <http://webkit.org/b/55492> Web process crashes aren't counted toward the
4044         --exit-after-n-crashes-or-timeouts limit
4045
4046         Reviewed by David Kilzer.
4047
4048         * Scripts/old-run-webkit-tests:
4049         (stopRunningTestsEarlyIfNeeded): Include web process crashes in the computation, and print
4050         the number of tests that caused the web process to crash when exiting early.
4051
4052 2011-03-01  Adam Roben  <aroben@apple.com>
4053
4054         Save a crash log when the web process crashes
4055
4056         On Windows, WebKitTestRunner now detects when the web process is crashing and waits to exit
4057         until it has finished crashing, which guarantees that the crash log will have had time to be
4058         saved, too. On Mac, we always wait until ReportCrash has exited before capturing the crash
4059         log, so all we have to do is choose the right crash log out of the CrashReporter directory.
4060
4061         Fixes <http://webkit.org/b/44121> <rdar://problem/8320759> When the web process crashes and
4062         a crash log is being saved, WebKitTestRunner thinks the web process has become unresponsive
4063
4064         Reviewed by Sam Weinig.
4065
4066         * Scripts/old-run-webkit-tests:
4067         (testCrashedOrTimedOut): Don't kill WebKitTestRunner when the web process crashes. It will
4068         kill itself. On Windows, this will cause us to wait until the crash log has been saved. On
4069         Mac, it should have no effect. Capture saved crash logs for web process crashes, too.
4070         (captureSavedCrashLog): Added $webProcessCrashed argument. On Mac, look for
4071         WebProces_*.crash files when the web process crashes.
4072
4073         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4074         (WTR::InjectedBundle::initialize): Added an initializationUserData argument. Updated for
4075         initializePlatformDefaults -> platformInitialize rename. Pass the initializationUserData
4076         along to platformInitialize.
4077
4078         * WebKitTestRunner/InjectedBundle/InjectedBundle.h: See above.
4079
4080         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
4081         (WKBundleInitialize): Pass along the initializationUserData to the InjectedBundle.
4082
4083         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
4084         (WTR::InjectedBundle::platformInitialize):
4085         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
4086         (WTR::InjectedBundle::platformInitialize):
4087         Updated function signature.
4088
4089         * WebKitTestRunner/InjectedBundle/win/InjectedBundleWin.cpp:
4090         (WTR::exceptionFilter): Added. Tells the UI process we're crashing by signaling the
4091         webProcessCrashingEvent, then lets the crash continue as normal.
4092
4093         (WTR::InjectedBundle::platformInitialize): Hook up exceptionFilter. Retrieve the name of the
4094         event we should use to tell the UI process we're crashing from the initializationUserData,
4095         and get a handle to that event.
4096
4097         * WebKitTestRunner/TestController.cpp:
4098         (WTR::TestController::TestController): Initialize new members.
4099         (WTR::TestController::processDidCrash): Removed unnecessary WKPageRef argument. Changed to
4100         only print the "#CRASHED - WebProcess" message once, since this can be called more than once
4101         when a crash log is being saved on Windows. Exit right away if specified. (This is the
4102         default.)
4103
4104         * WebKitTestRunner/TestController.h: Added new members.
4105
4106         * WebKitTestRunner/win/TestControllerWin.cpp:
4107         (WTR::TestController::platformInitialize): Set up the event the web process will use to tell
4108         us it's crashing.
4109         (WTR::TestController::platformRunUntil): Pass MWMO_INPUTAVAILABLE to
4110         ::MsgWaitForMultipleObjectsEx so we'll process messages that have already been seen by
4111         ::PeekMessage. (This is unrelated to the bug fix.) Notice when the webProcessCrashingEvent
4112         has been signaled. When this happens, print the "#CRASHED - WebProcess" message right away
4113         so the test harness will know the web process has crashed and not try to kill us, then wait
4114         for the web process to finish crashing so a crash log will have time to be saved.
4115         (WTR::toWK): Simple hepler function.
4116         (WTR::TestController::platformInitializeContext): Pass along the name of the event the web
4117         process should use to tell us it is crashing in the context's initialization user data.
4118
4119 2011-03-01  Dimitri Glazkov  <dglazkov@chromium.org>
4120
4121         Reviewed by Tony Gentilcore.
4122
4123         Move the checks to exclude Python/Perl tests for Chromium Win build to the right place.
4124         https://bugs.webkit.org/show_bug.cgi?id=55476
4125
4126         Chromium Win uses BuildAndTestFactory, not TestFactory.
4127
4128         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Moved to the right place.
4129
4130 2011-03-01  Adam Roben  <aroben@apple.com>
4131
4132         Test that the WebKit2 responsiveness timer doesn't fire too early
4133
4134         Test for <http://webkit.org/b/55417> <rdar://problem/9065287> RunLoop::Timer fires 1000x too
4135         early on Windows
4136
4137         Reviewed by Anders Carlsson.
4138
4139         * TestWebKitAPI/PlatformUtilities.h: Added sleep().
4140
4141         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp: Added.
4142         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
4143         (TestWebKitAPI::didFinishLoadForFrame):
4144         (TestWebKitAPI::processDidBecomeUnresponsive):
4145         (TestWebKitAPI::setInjectedBundleClient):
4146         (TestWebKitAPI::setPageLoaderClient):
4147         Simple helper functions.
4148
4149         (TestWebKitAPI::TEST): Load an HTML file to make sure the web process is initialized. Then
4150         tell the web process to pause and press the spacebar key. The spacebar keypress should cause
4151         the responsiveness timer to start, but the web process should unpause before it has a chance
4152         to fire. Run until the web process has unpaused, and assert that the timer didn't fire.
4153
4154         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly_Bundle.cpp: Added.
4155         (TestWebKitAPI::ResponsivenessTimerDoesntFireEarlyTest::ResponsivenessTimerDoesntFireEarlyTest):
4156         Call up to the base class.
4157         (TestWebKitAPI::ResponsivenessTimerDoesntFireEarlyTest::didReceiveMessage): When asked to
4158         pause, sleep for 0.5 seconds, then send back a message saying we paused.
4159
4160         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
4161         (TestWebKitAPI::Util::sleep): Added. Calls through to usleep.
4162         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
4163         (TestWebKitAPI::Util::sleep): Added. Calls through to ::Sleep.
4164
4165         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4166         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
4167         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
4168         Added new files.
4169
4170 2011-03-01  Andras Becsi  <abecsi@webkit.org>
4171
4172         Reviewed by Csaba Osztrogonác.
4173
4174         [Qt] Clean up the project files and move common options to WebKit.pri.
4175
4176         * WebKitTestRunner/qt/WebKitTestRunner.pro: Deduplicate.
4177
4178
4179 2011-03-01  Adam Roben  <aroben@apple.com>
4180
4181         Skip another multiprocessing test on Windows
4182
4183         It is sometimes failing (and may be leaving child Python processes around).
4184         <http://webkit.org/b/55087> tracks the failure.
4185
4186         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py:
4187         (FuncitonTests.test_get__processes): Skip this test on Windows.
4188
4189 2011-03-01  Ilya Tikhonovsky  <loislo@chromium.org>
4190
4191         Reviewed by Pavel Feldman.
4192
4193         Web Inspector: reduce inspector tests flakiness.
4194         https://bugs.webkit.org/show_bug.cgi?id=55401
4195
4196         * DumpRenderTree/chromium/TestShell.cpp:
4197         (TestShell::runFileTest):
4198         * DumpRenderTree/chromium/WebPreferences.cpp:
4199         (WebPreferences::reset):
4200
4201 2011-02-28  Mihai Parparita  <mihaip@chromium.org>
4202
4203         Reviewed by James Robinson.
4204
4205         NRWT should still upload results when it exits early due to too many failures
4206         https://bugs.webkit.org/show_bug.cgi?id=55432
4207         
4208         Only keyboard interrupts should prevent results from being uploaded.
4209
4210         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
4211         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
4212
4213 2011-02-28  Alice Liu  <alice.liu@apple.com>
4214
4215         Reviewed by Adam Roben and Gavin Barraclough.
4216
4217         Test for https://bugs.webkit.org/show_bug.cgi?id=54898
4218         InjectedBundleNodeHandle dies too early in WKBundleHitTestResultGetNodeHandle.
4219
4220         * TestWebKitAPI/InjectedBundleController.h:
4221         (TestWebKitAPI::InjectedBundleController::bundle):
4222         * TestWebKitAPI/PlatformWebView.h:
4223         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp: Added.
4224         (TestWebKitAPI::didFinishLoadForFrame):
4225         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
4226         (TestWebKitAPI::setPageLoaderClient):
4227         (TestWebKitAPI::TEST):
4228         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp: Added.
4229         (TestWebKitAPI::HitTestResultNodeHandleTest::HitTestResultNodeHandleTest):
4230         (TestWebKitAPI::HitTestResultNodeHandleTest::getContextMenuFromDefaultMenu):
4231         (TestWebKitAPI::HitTestResultNodeHandleTest::didCreatePage):
4232         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
4233         (TestWebKitAPI::PlatformWebView::simulateRightClick):
4234         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
4235         (TestWebKitAPI::PlatformWebView::simulateRightClick):
4236         
4237         Added files to:
4238         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4239         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
4240         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
4241
4242 2011-02-28  Adam Roben  <aroben@apple.com>
4243
4244         Start running InjectedBundle API tests on Windows
4245
4246         A new project, TestWebKitAPIInjectedBundle, builds the injected bundle DLL.
4247
4248         Fixes <http://webkit.org/b/55420> run-api-tests doesn't run injected bundle tests on Windows
4249
4250         Reviewed by Darin Adler.
4251
4252         * TestWebKitAPI/Configurations/TestWebKitAPIDebug.vsprops: Added.
4253         * TestWebKitAPI/Configurations/TestWebKitAPIDebugAll.vsprops: Added.
4254         * TestWebKitAPI/Configurations/TestWebKitAPIDebugCairoCFLite.vsprops: Added.
4255         * TestWebKitAPI/Configurations/TestWebKitAPIRelease.vsprops: Added.
4256         * TestWebKitAPI/Configurations/TestWebKitAPIReleaseCairoCFLite.vsprops: Added.
4257         These are just extracted from TestWebKitAPI.vcproj.
4258
4259         * TestWebKitAPI/Configurations/TestWebKitAPIInjectedBundleCommon.vsprops: Added. Just sets
4260         up the DLL's filename.
4261
4262         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp: Fixed DLL name.
4263         (TestWebKitAPI::Util::createInjectedBundlePath): Changed to use kCFAllocatorNull instead of
4264         0 (== kCFAllocatorDefault) so that CF won't try to deallocate our C string.
4265
4266         * TestWebKitAPI/win/TestWebKitAPI.sln: Added TestWebKitAPIInjectedBundle. Removed the bogus
4267         "all" configuration.
4268
4269         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Changed to use the new .vsprops files. Added
4270         injected bundle tests. Let VS resort things.
4271
4272         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj: Copied from Tools/TestWebKitAPI/win/TestWebKitAPI.vcproj.
4273
4274 2011-02-28  Adam Roben  <aroben@apple.com>
4275
4276         Add a test for the paint rect passed via WM_PAINT to windowless plugins
4277
4278         Test for <http://webkit.org/b/55365> <rdar://problem/9031089> REGRESSION (r79040): WebKit2:
4279         Large portions of pages with plugins paint black
4280
4281         Reviewed by Anders Carlsson.
4282
4283         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
4284         (PluginTest::NPP_HandleEvent):
4285         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
4286         Added NPP_HandleEvent. Just returns 0 at this level.
4287
4288         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowlessPaintRectCoordinates.cpp: Added.
4289         (WindowlessPaintRectCoordinates::WindowlessPaintRectCoordinates): Call up to the base class.
4290         (WindowlessPaintRectCoordinates::NPP_New): Mark ourselves as windowless.
4291         (WindowlessPaintRectCoordinates::NPP_HandleEvent): Check that the paint rect passed via
4292         WM_PAINT has the expected coordinates.
4293
4294         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
4295         (NPP_HandleEvent): Give the PluginTest a chance to handle the event before doing anything
4296         else.
4297
4298         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Added new file, let VS
4299         resort things.
4300
4301         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4302         (WTR::InjectedBundlePage::didFinishLoadForFrame): Added a call to WKBundlePageForceRepaint.