61c47492bc9e94b77272003fcefaa40cd4482999
[WebKit-https.git] / Tools / ChangeLog
1 2011-05-25  Tony Chang  <tony@chromium.org>
2
3         Reviewed by Adam Barth.
4
5         webkitpy's NetworkTransaction shouldn't use mechanize
6         https://bugs.webkit.org/show_bug.cgi?id=61450
7
8         mechanize.HTTPError is just an alias for urllib2.HTTPError, so
9         use urllib2 directly.  Re-add NetworkTransaction to
10         test_results_uploader.py (reverting r87124).
11
12         * Scripts/webkitpy/common/net/networktransaction.py:
13         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
14
15 2011-05-25  Kevin Ollivier  <kevino@theolliviers.com>
16
17         [Chromium] Unreviewed build fix. Do not define WTF/JS_EXPORT_PRIVATE to JS_EXPORTDATA
18         until the port begins using those export macros.
19
20         * DumpRenderTree/chromium/config.h:
21
22 2011-05-25  Sheriff Bot  <webkit.review.bot@gmail.com>
23
24         Unreviewed, rolling out r87257.
25         http://trac.webkit.org/changeset/87257
26         https://bugs.webkit.org/show_bug.cgi?id=61457
27
28         This broke layout tests, see bug 61431. (Requested by
29         hwennborg on #webkit).
30
31         * DumpRenderTree/chromium/LayoutTestController.cpp:
32         (LayoutTestController::LayoutTestController):
33         (LayoutTestController::clearAllDatabases):
34         * DumpRenderTree/chromium/LayoutTestController.h:
35
36 2011-05-25  Qi Zhang  <qi.2.zhang@nokia.com>
37
38         Reviewed by Andreas Kling.
39
40         [Qt] fast/css/disabled-author-styles.html failed
41         https://bugs.webkit.org/show_bug.cgi?id=61438
42
43         Implemented API setAuthorAndUserStylesEnabled in LayoutTestControllerQt.
44
45         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
46         (WebCore::WebPage::resetSettings):
47         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
48         (LayoutTestController::setAuthorAndUserStylesEnabled):
49         * DumpRenderTree/qt/LayoutTestControllerQt.h:
50
51 2011-05-25  Adam Roben  <aroben@apple.com>
52
53         Identify, rather than skip, builds where run-webkit-tests exited early due to too many failures
54
55         Fixes <http://webkit.org/b/61441> TestFailures page should show when run-webkit-tests
56         started exiting early due to too many crashes, timeouts, or failures
57
58         Reviewed by David Kilzer.
59
60         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
61         (Builder.prototype.getNumberOfFailingTests): Rather than returning -1 ("unknown") when
62         run-webkit-tests exits early due to too many failures, pass that information in another
63         argument to the callback.
64         (Builder.prototype.startFetchingBuildHistory): Updated the documentation comment to reflect
65         the new structure of the object passed to the callback.
66         (Builder.prototype._getFailingTests): Updated to expect a tooManyFailures boolean from
67         getNumberOfFailingTests and to pass that along to our own callbacks.
68         (Builder.prototype._incorporateBuildHistory): Updated to expect a tooManyFailures boolean
69         from _getFailingTests and to store that value in the history object.
70
71         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
72         (.info): Added.
73
74         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
75         (ViewController.prototype._displayBuilder): Updated for change in structure to the history
76         object and to add a note when run-webkit-tests exited early due to too many failures.
77         (ViewController.prototype._displayTesters): Renamed testersAndFailureCounts to
78         latestBuildInfos since each entry now contains more than just the tester and failure count.
79         Now displays a message for testers where the latest build exited early due to too many
80         failures. Updated to expect a tooManyFailures boolean from getNumberOfFailingTests and to
81         store that value in latestBuildInfos.
82
83 2011-05-24  Keishi Hattori  <keishi@webkit.org>
84
85         Reviewed by Kent Tamura.
86
87         Disable textfield implementation of <input type=color>. Add INPUT_COLOR feature flag. Add input color sanitizer.
88         https://bugs.webkit.org/show_bug.cgi?id=61273
89
90         * Scripts/build-webkit: Added INPUT_COLOR feature flag.
91
92 2011-05-24  Greg Simon  <gregsimon@chromium.org>
93
94         Reviewed by Dimitri Glazkov.
95
96         Control Indexeddb backends from LayoutTestController
97         https://bugs.webkit.org/show_bug.cgi?id=61000
98
99         * DumpRenderTree/chromium/LayoutTestController.cpp:
100         (LayoutTestController::LayoutTestController):
101         (LayoutTestController::setOverrideIndexedDBBackingStore):
102         (LayoutTestController::clearAllDatabases):
103         * DumpRenderTree/chromium/LayoutTestController.h:
104
105 2011-05-24  Robert Hogan  <robert@webkit.org>
106
107         Reviewed by Ryosuke Niwa.
108
109         [Qt] Fix fast/events/selectstart-by-single-click-with-shift.html
110         https://bugs.webkit.org/show_bug.cgi?id=61393
111
112         * DumpRenderTree/qt/EventSenderQt.h:
113         * DumpRenderTree/qt/EventSenderQt.cpp:
114         (getModifiers): static function for interpreting modifiers
115         (EventSender::mouseDown): Respect keyboard modifiers
116         (EventSender::keyDown): use new static function
117         (EventSender::sendOrQueueEvent): whitespace fix
118
119 2011-05-24  Jay Civelli  <jcivelli@chromium.org>
120
121         Reviewed by Adam Barth.
122
123         Adding MHTML reading support.
124         https://bugs.webkit.org/show_bug.cgi?id=7168
125
126         * Scripts/build-webkit:
127         * Scripts/old-run-webkit-tests:
128         * Scripts/webkitperl/features.pm:
129         * Scripts/webkitpy/layout_tests/port/test_files.py:
130         * Scripts/webkitpy/layout_tests/port/webkit.py:
131
132 2011-05-24  Stephen White  <senorblanco@chromium.org>
133
134         Reviewed by Kenneth Russell.
135
136         Remove most style checks on Source/ThirdParty/glu, since it doesn't
137         follow WebKit style.
138         https://bugs.webkit.org/show_bug.cgi?id=61365
139
140         * Scripts/webkitpy/style/checker.py:
141
142 2011-05-24  Adam Roben  <aroben@apple.com>
143
144         Don't allow forcing builds through the build.webkit.org web interface
145
146         Someone has been forcing bogus builds.
147
148         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
149
150 2011-05-24  Qi Zhang  <qi.2.zhang@nokia.com>
151
152         Reviewed by Adam Roben.
153
154         WebKitTestRunner needs layoutTestController.setJavaScriptCanAccessClipboard
155         https://bugs.webkit.org/show_bug.cgi?id=42669
156
157         Fixes the regression issue caused by patch 94265. The patch didn't intialize the setting before the 
158         layouttest starting, it will make the test cases after editing/execCommand/clipboard-access.html failed.
159         Because that case changed the setting.
160
161         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
162         (WTR::InjectedBundle::beginTesting):
163
164 2011-05-24  Csaba Osztrogonác  <ossy@webkit.org>
165
166         Reviewed by Kenneth Rohde Christiansen.
167
168         [ORWT]Make --skipped=only option work with parameters with LayoutTests/ prefix
169         https://bugs.webkit.org/show_bug.cgi?id=61052
170
171         * Scripts/old-run-webkit-tests:
172
173 2011-05-24  Adam Roben  <aroben@apple.com>
174
175         Make TestFailures show how many tests are failing on each tester, and omit testers with no failures
176
177         Fixes <http://webkit.org/b/61063> <rdar://problem/9460533> TestFailures page shows testers
178         that don't have any failing tests, which isn't useful
179
180         Reviewed by David Kilzer.
181
182         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js:
183         (Buildbot.prototype.getTesters): Renamed from getTesterNames. Now returns Builder objects
184         instead of name strings.
185         (Buildbot.prototype._buildersForNames): Added. Helper function to convert an array of
186         builder names into an array of builders.
187
188         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
189         (Builder.prototype.getMostRecentCompletedBuildNumber): Added. Returns the build number of
190         the most recently completed build, or -1 if there is no such build.
191         (Builder.prototype.getNumberOfFailingTests): Added. Returns the number of tests that failed
192         in the given build, or -1 if the number could not be determined. Some of this code came from
193         _getFailingTests.
194         (Builder.prototype._getBuildJSON): Added. Code came from _getFailingTests.
195         (Builder.prototype._getFailingTests): Changed to use new _getBuildJSON and
196         getNumberOfFailingTests functions.
197
198         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
199         (ViewController.prototype._displayTesters): Get the current number of test failures for each
200         tester and show it in the list. Omit testers that have no failures at all. We keep the
201         testers and failure counts in an array and sort it before displaying the current data, as
202         the order in which data will be fetched is unpredictable.
203
204 2011-05-23  Tony Chang  <tony@chromium.org>
205
206         Reviewed by Ojan Vafai.
207
208         [nrwt] don't use NetworkTranslation when uploading results
209         https://bugs.webkit.org/show_bug.cgi?id=61315
210
211         This avoids autoinstalling mechanize.  It didn't matter anyway
212         because test_results_uploader.py wasn't using mechanize to make the
213         request so NetworkTransaction::run wasn't doing anything extra
214         (it only matters if it catches mechanize.HTTPError).
215
216         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
217
218 2011-05-23  Tony Chang  <tony@chromium.org>
219
220         Reviewed by Dirk Pranke.
221
222         [chromium] fix the rebaseline tool to work with Linux GPU failures
223         https://bugs.webkit.org/show_bug.cgi?id=61312
224
225         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
226
227 2011-05-23  Darin Adler  <darin@apple.com>
228
229         Ignore generated .pyc files in a directory full of python code.
230
231         * Scripts/webkitpy/common/checkout/scm: Added property svn:ignore.
232
233 2011-05-23  Adam Barth  <abarth@webkit.org>
234
235         Reviewed by Eric Seidel.
236
237         sheriffbot should give more details about the failures in IRC
238         https://bugs.webkit.org/show_bug.cgi?id=61233
239
240         With this patch, sheriffbot will annonce the set of failing tests,
241         which might help folks triage the problem.
242
243         * Scripts/webkitpy/tool/commands/sheriffbot.py:
244         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
245
246 2011-05-23  Sheriff Bot  <webkit.review.bot@gmail.com>
247
248         Unreviewed, rolling out r87078.
249         http://trac.webkit.org/changeset/87078
250         https://bugs.webkit.org/show_bug.cgi?id=61294
251
252         Patch contains errors and seems likely to break a bunch of
253         bots (Requested by abarth on #webkit).
254
255         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
256         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
257         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
258
259 2011-05-23  Alice Boxhall  <aboxhall@chromium.org>
260
261         Reviewed by Ojan Vafai.
262
263         Convert json_results_generator.py to output version 4 JSON.
264         https://bugs.webkit.org/show_bug.cgi?id=60869
265
266         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
267         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
268         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
269
270 2011-05-23  Patrick Gansterer  <paroga@webkit.org>
271
272         Reviewed by Adam Barth.
273
274         Move generation of shell_command from port to executive
275         https://bugs.webkit.org/show_bug.cgi?id=61251
276
277         After move it's possible to use the code in other places too.
278
279         * Scripts/webkitpy/common/config/ports.py:
280         * Scripts/webkitpy/common/system/executive.py:
281
282 2011-05-23  Qi Zhang  <qi.2.zhang@nokia.com>
283
284         Reviewed by Darin Adler.
285
286         WebKitTestRunner needs layoutTestController.setJavaScriptCanAccessClipboard
287         https://bugs.webkit.org/show_bug.cgi?id=42669
288
289         Implement setJavaScriptCanAccessClipboard in WebKitTestRunner.
290
291         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
292         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
293         (WTR::LayoutTestController::setJavaScriptCanAccessClipboard):
294         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
295
296 2011-05-22  Robert Hogan  <robert@webkit.org>
297
298         Reviewed by Kenneth Rohde Christiansen.
299
300         Fix policyDelegate in Qt DRT
301         https://bugs.webkit.org/show_bug.cgi?id=61247
302
303         Use the 'policy delegate' implemented in FrameLoaderClient
304         for layout tests. The partial implementation in DumpRenderTreeQt
305         is redundant, so remove it.
306
307         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
308         (WebCore::WebPage::acceptNavigationRequest):
309         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
310         (LayoutTestController::waitForPolicyDelegate):
311
312 2011-05-22  Patrick Gansterer  <paroga@webkit.org>
313
314         Reviewed by Darin Adler.
315
316         Use double quotes for filename arguments
317         https://bugs.webkit.org/show_bug.cgi?id=61250
318
319         Windows does not support single quotes on the command line,
320         so replace them with double quotes.
321
322         * Scripts/prepare-ChangeLog:
323
324 2011-05-20  Simon Fraser  <simon.fraser@apple.com>
325
326         Reviewed by Sam Weinig.
327
328         WebKitTestRunner needs layoutTestController.pauseTransitionAtTimeOnElementWithId
329         https://bugs.webkit.org/show_bug.cgi?id=42550
330         
331         Implement pauseTransitionAtTimeOnElementWithId in WebKitTestRunner.
332
333         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
334         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
335         Copy the code for pausing animations, FIXME comments and all.
336         (WTR::LayoutTestController::pauseTransitionAtTimeOnElementWithId):
337         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
338
339 2011-05-20  Alok Priyadarshi  <alokp@chromium.org>
340
341         Reviewed by Stephen White.
342
343         Adding myself to the committers list.
344
345         * Scripts/webkitpy/common/config/committers.py:
346
347 2011-05-19  Adam Roben  <aroben@apple.com>
348
349         Test that the WebKit2 UI process doesn't crash when starting a download
350
351         Test for <http://webkit.org/b/61142> <rdar://problem/9471680> REGRESSION (r86812): Crash
352         (preceded by assertion) in fastMalloc when downloading a file
353
354         Reviewed by Darin Adler.
355
356         * TestWebKitAPI/Tests/WebKit2/18-characters.html: Added.
357
358         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp: Added.
359         (TestWebKitAPI::decidePolicyForNavigationAction): Start a download.
360         (TestWebKitAPI::decideDestinationWithSuggestedFilename): Record that the download was
361         started, cancel the download, and return a bogus string.
362
363         (TestWebKitAPI::setContextDownloadClient):
364         (TestWebKitAPI::setPagePolicyClient):
365         Simple helper functions.
366
367         (TestWebKitAPI::TEST): Load 18-characters.html, which should trigger a download thanks to
368         our policy client, and run until we know that the download was started. If we haven't
369         crashed, we win!
370
371         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
372         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
373         * TestWebKitAPI/win/copy-resources.cmd:
374         Added new files.
375
376 2011-05-20  Kent Tamura  <tkent@chromium.org>
377
378         Reviewed by Ryosuke Niwa.
379
380         Fix style errors in DumpRenderTree/chromium/.
381         https://bugs.webkit.org/show_bug.cgi?id=61172
382
383         * DumpRenderTree/chromium/CppBoundClass.cpp:
384         (CppBoundClass::getAsCppVariant):
385         (CppBoundClass::bindToJavascript):
386         * DumpRenderTree/chromium/CppBoundClass.h:
387         (CppBoundClass::GetterCallback::~GetterCallback):
388         (CppBoundClass::CppBoundClass):
389         (CppBoundClass::Callback::~Callback):
390         (CppBoundClass::MemberCallback::MemberCallback):
391         (CppBoundClass::MemberCallback::~MemberCallback):
392         (CppBoundClass::MemberGetterCallback::MemberGetterCallback):
393         (CppBoundClass::MemberGetterCallback::~MemberGetterCallback):
394         * DumpRenderTree/chromium/CppVariant.h:
395         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
396         (DRTDevToolsAgent::~DRTDevToolsAgent):
397         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
398         (DRTDevToolsClient::sendFrontendLoaded):
399         * DumpRenderTree/chromium/DRTDevToolsClient.h:
400         * DumpRenderTree/chromium/DumpRenderTree.cpp:
401         (main):
402         * DumpRenderTree/chromium/EventSender.cpp:
403         (SavedEvent::SavedEvent):
404         (EventSender::EventSender):
405         (EventSender::keyDown):
406         * DumpRenderTree/chromium/EventSender.h:
407         * DumpRenderTree/chromium/ImageDiff.cpp:
408         (Image::Image):
409         * DumpRenderTree/chromium/LayoutTestController.cpp:
410         (LayoutTestController::LayoutTestController):
411         (LayoutTestController::WorkQueue::reset):
412         (WorkItemBackForward::WorkItemBackForward):
413         (WorkItemLoadingScript::WorkItemLoadingScript):
414         (WorkItemNonLoadingScript::WorkItemNonLoadingScript):
415         (WorkItemLoad::WorkItemLoad):
416         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
417         (LayoutTestController::pathToLocalResource):
418         * DumpRenderTree/chromium/LayoutTestController.h:
419         (LayoutTestController::WorkItem::~WorkItem):
420         (LayoutTestController::WorkQueue::WorkQueue):
421         * DumpRenderTree/chromium/MockSpellCheck.cpp:
422         (MockSpellCheck::MockSpellCheck):
423         (MockSpellCheck::~MockSpellCheck):
424         * DumpRenderTree/chromium/MockSpellCheck.h:
425         * DumpRenderTree/chromium/NotificationPresenter.h:
426         (NotificationPresenter::NotificationPresenter):
427         * DumpRenderTree/chromium/Task.cpp:
428         (WebTask::WebTask):
429         * DumpRenderTree/chromium/Task.h:
430         (TaskList::TaskList):
431         * DumpRenderTree/chromium/TestEventPrinter.cpp:
432         (DRTPrinter::DRTPrinter):
433         (TestShellPrinter::TestShellPrinter):
434         * DumpRenderTree/chromium/TestNavigationController.cpp:
435         (TestNavigationEntry::TestNavigationEntry):
436         (TestNavigationEntry::~TestNavigationEntry):
437         (TestNavigationController::TestNavigationController):
438         (TestNavigationController::reload):
439         (TestNavigationController::loadEntry):
440         (TestNavigationController::didNavigateToEntry):
441         * DumpRenderTree/chromium/TestNavigationController.h:
442         (TestShellExtraData::TestShellExtraData):
443         * DumpRenderTree/chromium/TestShell.cpp:
444         (dumpHistoryItem):
445         * DumpRenderTree/chromium/TestShell.h:
446         (TestParams::TestParams):
447         * DumpRenderTree/chromium/TestShellWin.cpp:
448         (TestShell::waitTestFinished):
449         * DumpRenderTree/chromium/TestWebWorker.h:
450         (TestWebWorker::startWorkerContext):
451         (TestWebWorker::terminateWorkerContext):
452         (TestWebWorker::postMessageToWorkerContext):
453         (TestWebWorker::clientDestroyed):
454         (TestWebWorker::postMessageToWorkerObject):
455         (TestWebWorker::postExceptionToWorkerObject):
456         (TestWebWorker::postConsoleMessageToWorkerObject):
457         (TestWebWorker::confirmMessageFromWorkerObject):
458         (TestWebWorker::reportPendingActivity):
459         (TestWebWorker::workerContextClosed):
460         (TestWebWorker::~TestWebWorker):
461         * DumpRenderTree/chromium/TextInputController.cpp:
462         * DumpRenderTree/chromium/WebThemeControlDRTWin.h:
463         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
464         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
465         (WebThemeEngineDRTWin::paintButton):
466         (WebThemeEngineDRTWin::paintMenuList):
467         (WebThemeEngineDRTWin::paintTrackbar):
468         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h:
469         (WebThemeEngineDRTWin::WebThemeEngineDRTWin):
470         * DumpRenderTree/chromium/WebViewHost.cpp:
471         (WebViewHost::navigate):
472         (WebViewHost::updateSessionHistory):
473         (WebViewHost::paintInvalidatedRegion):
474         * DumpRenderTree/chromium/WebViewHost.h:
475
476 2011-05-19  Dmitry Lomov  <dslomov@google.com>
477
478         Reviewed by Adam Roben.
479
480         Detect hangs in run-api-tests
481         https://bugs.webkit.org/show_bug.cgi?id=48043
482
483         * Scripts/run-api-tests: Added test timeouts
484
485 2011-05-19  Dmitry Lomov  <dslomov@google.com>
486
487         Reviewed by Adam Roben.
488
489         run-api-tests should run one test per process
490         https://bugs.webkit.org/show_bug.cgi?id=61088
491
492         * Scripts/run-api-tests: Resurrecting the previous revison of this file, with fixes to system call under Windows, 
493         return code, and parsing GTest output format.
494
495 2011-05-15  Robert Hogan  <robert@webkit.org>
496
497         Reviewed by Antonio Gomes.
498
499         [Qt][GTK] plugins/get-url-with-javascript-url.html fails
500         https://bugs.webkit.org/show_bug.cgi?id=60834
501         Fix unix test plugin for plugins/get-url-with-javascript-url.html
502
503         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
504         (webkit_test_plugin_new_stream):
505         (webkit_test_plugin_write_ready):
506         (webkit_test_plugin_write):
507
508 2011-05-19  Sheriff Bot  <webkit.review.bot@gmail.com>
509
510         Unreviewed, rolling out r86869, r86873, r86875, and r86877.
511         http://trac.webkit.org/changeset/86869
512         http://trac.webkit.org/changeset/86873
513         http://trac.webkit.org/changeset/86875
514         http://trac.webkit.org/changeset/86877
515         https://bugs.webkit.org/show_bug.cgi?id=61139
516
517         broke builds and debug DRT (Requested by rniwa on #webkit).
518
519         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
520         * DumpRenderTree/chromium/TestShell.cpp:
521         (TestShell::bindJSObjectsToWindow):
522         * DumpRenderTree/mac/FrameLoadDelegate.mm:
523         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
524
525 2011-05-18  Dimitri Glazkov  <dglazkov@chromium.org>
526
527         Reviewed by Darin Adler.
528
529         Add build logistics and plumbing for window.internals object.
530         https://bugs.webkit.org/show_bug.cgi?id=60313
531
532         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added linking new WebCoreTestSupport library.
533         * DumpRenderTree/chromium/TestShell.cpp:
534         (TestShell::bindJSObjectsToWindow): Added injection code.
535         * DumpRenderTree/mac/FrameLoadDelegate.mm:
536         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]): Ditto.
537
538 2011-05-19  Zsolt Fehér  <h490267@stud.u-szeged.hu>
539
540         Reviewed by Csaba Osztrogonác.
541
542         [Qt] Implement eventSender.scalePageBy
543         https://bugs.webkit.org/show_bug.cgi?id=60015
544
545         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
546         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
547         * DumpRenderTree/qt/EventSenderQt.cpp:
548         (EventSender::scalePageBy):
549         * DumpRenderTree/qt/EventSenderQt.h:
550
551 2011-05-19  Kenichi Ishibashi  <bashi@chromium.org>
552
553         Reviewed by Kent Tamura.
554
555         [Chromium] IME candidate window appears wrong position in an iframe
556         https://bugs.webkit.org/show_bug.cgi?id=61023
557
558         Call the focused frame's firstRectForCharacterRange() instead of the
559         main frame so that DRT behaves as the same as Chromium.
560
561         * DumpRenderTree/chromium/TextInputController.cpp:
562         (TextInputController::firstRectForCharacterRange):
563
564 2011-05-18  Adam Roben  <aroben@apple.com>
565
566         Add a new page to build.webkit.org to help find when tests started failing
567
568         The page is accessible at <http://build.webkit.org/TestFailures/>. It is pretty minimalist
569         right now, but already shows some useful information. It's somewhat similar to webkit-patch
570         failure-reason and sheriffbot, and perhaps can be combined with them eventually. It's a
571         little more convenient than either of them, though, because it's all done in the browser
572         (and thus it's easy to go directly to the relevant test results).
573
574         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js: Added.
575         (Buildbot): This class represents a Buildbot server.
576         (Buildbot.prototype.buildURL): Returns the URL for the summary page for a particular build.
577         (Buildbot.prototype.builderNamed): Returns a Builder with the given name.
578         (Buildbot.prototype.getTesterNames): Fetches the names of all testers and passes them to the
579         callback.
580         (Buildbot.prototype.parseBuildName): Breaks up a build name into its constituent parts. Must
581         be implemented by a derived class that understands this server's build naming scheme.
582         (Buildbot.prototype.resultsDirectoryURL): Returns the URL for the results directory for a
583         particular build.
584
585         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js: Added.
586         (Builder): This class represents one builder on the buildbot.
587         (Builder.prototype.buildURL): Returns the URL for the summary page for a particular build.
588         (Builder.prototype.failureDiagnosisTextAndURL): Returns data that provides a little more
589         information about a particular test failure.
590         (Builder.prototype.startFetchingBuildHistory): Periodically calls the callback with
591         information about when tests started failing.
592         (Builder.prototype.resultsDirectoryURL): Returns the URL for the results directory for a
593         particular build.
594         (Builder.prototype._getBuildNames): Fetches the names of all builds and passes them to the
595         callback.
596         (Builder.prototype._getFailingTests): Fetches the results.html page for the given build and
597         extracts all the failing tests listed in it, passing them to the callback.
598         (Builder.prototype._incorporateBuildHistory): Gets the failing tests for the specified
599         build, merges them into the build history, and calls the callback telling it whether the
600         next build should be fetched to provide more information.
601
602         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
603         Added. Just some simple styles.
604
605         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js: Added.
606         (createDefinitionList): Takes an array of pairs and turns them into a DL element.
607         (getResource): Wrapper around XMLHttpRequest.
608         (Array.prototype.findFirst): Finds the first element matching the given predicate and
609         returns it.
610         (Array.prototype.last): Returns the last element of the array.
611
612         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js: Added.
613         (ViewController): This class contains the main logic for displaying the page.
614         (ViewController.loaded): Just calls through to parseHash.
615         (ViewController.parseHash): Either starts analyzing failures on a particular builder, or
616         shows the list of all testers so one can be chosen. This function is called when the page
617         loads and whenever we get a hashchange event.
618         (ViewController._displayBuilder): Asks the builder to fetch build history, and displays it
619         as it is fetched. The display ends up grouping tests by when they started failing.
620         (ViewController._displayTesters): Gets the list of testers and displays it.
621
622         (ViewController._domForBuildName):
623         (ViewController._domForFailedTest):
624         Helper functions to create descriptions and links for a particular build or failed test.
625
626         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBuildbot.js: Added.
627         (WebKitBuildbot): Calls up to the base class constructor with the correct base URL.
628         (WebKitBuildbot.prototype.parseBuildName): Parses a build.webkit.org-style build name.
629
630         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Added. Just
631         loads all the files and sets up a ViewController, which does the rest.
632
633         * BuildSlaveSupport/build.webkit.org-config/templates/root.html: Added a link to the new
634         page.
635
636 2011-05-18  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
637
638         Reviewed by Csaba Osztrogonác.
639
640         [Qt] Implement layoutTestController.setValueForUser()
641         https://bugs.webkit.org/show_bug.cgi?id=60956
642
643         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
644         (LayoutTestController::setValueForUser):
645         * DumpRenderTree/qt/LayoutTestControllerQt.h:
646
647 2011-05-16  Robert Hogan  <robert@webkit.org>
648
649         Reviewed by Kenneth Rohde Christiansen.
650
651         plugins/invalidate_rect.html fails on linux ports
652
653         - Make the unix test netscape plugin recognize the onPaintEvent
654           and windowedPlugin parameters.
655
656         https://bugs.webkit.org/show_bug.cgi?id=54051
657
658         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
659         (handleEventX11):
660         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
661         (LayoutTestController::displayInvalidatedRegion):
662         * DumpRenderTree/qt/LayoutTestControllerQt.h:
663         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
664         (webkit_test_plugin_new_instance):
665         (webkit_test_plugin_handle_event):
666
667 2011-05-17  Tony Chang  <tony@chromium.org>
668
669         Reviewed by Ojan Vafai.
670
671         [chromium] move Lucid 64 bit results into LayoutTests/platform/chromium-linux
672         https://bugs.webkit.org/show_bug.cgi?id=60895
673
674         Update the tools to handle the move.  Lucid 32 results now go in
675         chromium-linux-x86 and the default platform on Linux is now x86_64.
676
677         * Scripts/webkitpy/layout_tests/deduplicate_tests.py: Default to x86_64
678         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
679         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py: Default to Lucid
680         * Scripts/webkitpy/layout_tests/port/base.py: ditto
681         * Scripts/webkitpy/layout_tests/port/chromium_linux.py: Update directory fallback and default to Lucid 64
682         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
683         * Scripts/webkitpy/layout_tests/port/test.py: Update tests to default to x86_64
684         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: Update bot names.
685         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py: Whitespace cleanup.
686
687 2011-05-17  Adam Roben  <aroben@apple.com>
688
689         Make run-api-tests work on Windows when there are spaces in the path
690
691         Fixes <http://webkit.org/b/60954> REGRESSION (r86511): run-api-tests fails if there are
692         spaces in the path to TestWebKitAPI.exe
693
694         Reviewed by David Levin.
695
696         * Scripts/run-api-tests:
697         (runTestTool): Use the "direct object" form of system() to avoid having the path to
698         TestWebKitAPI.exe be split by the shell.
699
700 2011-05-16  Ian Henderson  <ianh@apple.com>
701
702         Reviewed by Joseph Pecoraro.
703
704         Page::goToItem doesn't work while loading is deferred
705         https://bugs.webkit.org/show_bug.cgi?id=60412
706
707         Add setDefersLoading and goBack methods to LayoutTestController.  We
708         need to use goBack() instead of history.back() because the latter goes
709         through NavigationScheduler, hence doesn't exhibit the bug.
710
711         * DumpRenderTree/LayoutTestController.cpp:
712         (goBackCallback):
713         (setDefersLoadingCallback):
714         (LayoutTestController::staticFunctions):
715         * DumpRenderTree/LayoutTestController.h:
716         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
717         (LayoutTestController::goBack):
718         (LayoutTestController::setDefersLoading):
719         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
720         (LayoutTestController::goBack):
721         (LayoutTestController::setDefersLoading):
722         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
723         (LayoutTestController::goBack):
724         (LayoutTestController::setDefersLoading):
725         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
726         (LayoutTestController::goBack):
727         (LayoutTestController::setDefersLoading):
728
729 2011-05-16  Sam Weinig  <sam@webkit.org>
730
731         Reviewed by Anders Carlsson.
732
733         TestWebKitAPI should build with clang if it can
734         https://bugs.webkit.org/show_bug.cgi?id=60918
735
736         * TestWebKitAPI/Configurations/CompilerVersion.xcconfig:
737         Update CompilerVersion.xcconfig to match others.
738
739         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
740         Add CompilerVersion.xcconfig to the project.
741
742         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
743         (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame):
744         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
745         (TestWebKitAPI::didSameDocumentNavigationForFrame):
746         Add some casts to quiet warnings from clang.
747
748 2011-05-16  Dirk Pranke  <dpranke@chromium.org>
749
750         Reviewed by David Levin.
751
752         add dpranke as a reviewer
753         https://bugs.webkit.org/show_bug.cgi?id=60919
754
755         * Scripts/webkitpy/common/config/committers.py:
756
757 2011-05-16  Robert Hogan  <robert@webkit.org>
758
759         Reviewed by Anders Carlsson.
760
761         [Gtk] plugins/get-url-notify-with-url-that-fails-to-load.html crashes on buildbot
762
763         https://bugs.webkit.org/show_bug.cgi?id=60838
764
765         The unix test plugin needs to call the test's NPP_URLNotify
766         rather than the browsers.
767
768         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
769         (webkit_test_plugin_url_notify):
770
771 2011-05-16  Brent Fulgham  <bfulgham@webkit.org>
772
773         Rubber-stamped by Adam Roben.
774
775         Adding myself as a reviewer.
776         * Scripts/webkitpy/common/config/committers.py:
777
778 2011-05-16  Sam Weinig  <sam@webkit.org>
779
780         Fix typo pointed out by Dave Levin.
781
782         * TestWebKitAPI/PlatformUtilities.h:
783         (TestWebKitAPI::Util::assertWKStringEqual):
784         Strig -> String.
785
786 2011-05-16  Sam Weinig  <sam@webkit.org>
787
788         Reviewed by David Levin.
789
790         Convert api tester over to using gtest expectations directly
791         https://bugs.webkit.org/show_bug.cgi?id=60862
792
793         * TestWebKitAPI/PlatformUtilities.cpp:
794         (TestWebKitAPI::Util::toSTD):
795         * TestWebKitAPI/PlatformUtilities.h:
796         (TestWebKitAPI::Util::assertWKStrigEqual):
797         Add convenience macro to compare WK2 strings. Add some overloads of toSTD to make
798         the implementation of the macro simpler.
799
800         * TestWebKitAPI/Test.h:
801         Remove TEST_ASSERT forwarder.
802
803         [Test changes elided]
804
805 2011-05-16  David Kilzer  <ddkilzer@apple.com>
806
807         <http://webkit.org/b/60913> C++ exceptions should not be enabled when building with llvm-gcc-4.2
808         <rdar://problem/9446430>
809
810         Reviewed by Mark Rowe.
811
812         * MiniBrowser/Configurations/Base.xcconfig: Fixed typo.
813         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
814         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
815
816 2011-05-16  Jon Lee  <jonlee@apple.com>
817
818         Reviewed by Simon Fraser.
819
820         Can't horizontally scroll iframes and overflow because wheel events are always accepted
821         https://bugs.webkit.org/show_bug.cgi?id=60779
822
823         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
824         (WTR::InjectedBundlePage::InjectedBundlePage): Set new default method to nil.
825
826 2011-05-16  Ademar de Souza Reis Jr.  <ademar.reis@openbossa.org>
827
828         Reviewed by Csaba Osztrogonác.
829
830         [Qt] Tools.pro misses include(common.pri)
831         https://bugs.webkit.org/show_bug.cgi?id=60883
832
833         It includes features.pri, which depends on common.pri (the build is
834         not broken today with the default options, but this is the right
835         thing to do).
836
837         * Tools.pro:
838
839 2011-05-15  Dominic Cooney  <dominicc@chromium.org>
840
841         Unreviewed: adding myself to committers.py.
842
843         * Scripts/webkitpy/common/config/committers.py:
844
845 2011-05-15  Daniel Bates  <dbates@webkit.org>
846
847         Reviewed by Chris Jerdonek.
848
849         svn-apply can't handle Git diff that only changes executable bit
850         https://bugs.webkit.org/show_bug.cgi?id=60848
851
852         Fixes an issue where svn-{apply, unapply} fail to handle a Git diff for a file
853         that only has an executable bit change.
854
855         * Scripts/VCSUtils.pm:
856           - Modified regex $chunkRangeRegEx to match chunk range with ending text, say: @@ -2,6 +2,18 @@ foo().
857         (parseDiff): Modified to count the number of text chunks in the diff. This should also help towards
858         fixing <https://bugs.webkit.org/show_bug.cgi?id=29684>.
859         * Scripts/svn-apply:
860         (patch): Only use standard patch tool if the patch is non-empty and for a text file (i.e. not a binary patch).
861         * Scripts/svn-unapply:
862         (patch): Ditto.
863         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
864           - Updated expected results for test cases to account for numTextChunks.
865           - Fixed malformed chunk range in test cases: "Git: simple", and "Git: Git diff followed by SVN diff".
866           - Added test case "Git: file that only has an executable bit change".
867         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
868           - Updated expected results for test cases to account for numTextChunks.
869
870 2011-05-15  Sam Weinig  <sam@webkit.org>
871
872         Fix windows build.
873
874         * TestWebKitAPI/win/main.cpp:
875         (main):
876
877 2011-05-15  Sam Weinig  <sam@webkit.org>
878
879         Reviewed by David Levin.
880
881         Make API tester more gtest friendly
882         https://bugs.webkit.org/show_bug.cgi?id=60859
883
884         * Scripts/run-api-tests:
885         Numerous changes:
886         - Remove logic to run tests one at a time.
887         - Remove logic to build up a list of tests, instead just pass --gtest_list_tests to 
888           the test runner and allow gtest to print it for us.
889         - Forward stdout from the test tool to stdout, even in non-verbose runs.
890         - Run test tool from the current working directory instead of the root webkit
891           directory.
892
893         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
894         Move plist to be with other bundle sources.
895
896         * TestWebKitAPI/TestsController.cpp:
897         (TestWebKitAPI::TestsController::TestsController):
898         (TestWebKitAPI::TestsController::run):
899         * TestWebKitAPI/TestsController.h:
900         * TestWebKitAPI/mac/main.mm:
901         Simplify TestController down to a single run function. We should consider removing the class
902         entirely at some point.
903
904 2011-05-15  Sheriff Bot  <webkit.review.bot@gmail.com>
905
906         Unreviewed, rolling out r86504.
907         http://trac.webkit.org/changeset/86504
908         https://bugs.webkit.org/show_bug.cgi?id=60853
909
910         "Broke Qt EventSender in editing/selection tests" (Requested
911         by mwenge on #webkit).
912
913         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
914         (WebCore::WebPage::WebPage):
915         (WebCore::DumpRenderTree::DumpRenderTree):
916         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
917         (WebCore::DumpRenderTree::initJSObjects):
918         * DumpRenderTree/qt/DumpRenderTreeQt.h:
919         (WebCore::DumpRenderTree::eventSender):
920         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
921         (webkit_test_plugin_new_instance):
922         (webkit_test_plugin_set_window):
923         (webkit_test_plugin_handle_event):
924
925 2011-05-12  Robert Hogan  <robert@webkit.org>
926
927         Reviewed by Benjamin Poulain.
928
929         [Qt] fix http/tests/plugins/plugin-document-has-focus.html
930
931         The support for this test added to the unix test plugin here
932         may allow other platforms to pass it (nearly everyone
933         skips it). On Qt it required a bit of trickiness with
934         the page's EventSender object to get it working fully though,
935         so only unskipping Qt here.
936
937         https://bugs.webkit.org/show_bug.cgi?id=60722
938
939         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
940         (WebCore::WebPage::WebPage):
941         (WebCore::WebPage::eventSender):
942         (WebCore::DumpRenderTree::DumpRenderTree):
943         (WebCore::DumpRenderTree::initJSObjects):
944         (WebCore::DumpRenderTree::createWindow):
945         * DumpRenderTree/qt/DumpRenderTreeQt.h:
946         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
947         (webkit_test_plugin_new_instance):
948         (webkit_test_plugin_set_window):
949         (webkit_test_plugin_handle_event):
950
951 2011-05-14  Arno Renevier  <arno@renevier.net>
952
953         Reviewed by Martin Robinson.
954
955         make run-gtk-tests executable
956         https://bugs.webkit.org/show_bug.cgi?id=59278
957
958         * Scripts/run-gtk-tests:
959
960 2011-05-14  Anders Carlsson  <andersca@apple.com>
961
962         Reviewed by Kevin Decker.
963
964         NPP_URLNotify is not called if a URL passed to NPN_GetURLNotify fails to load
965         https://bugs.webkit.org/show_bug.cgi?id=60823
966         <rdar://problem/9430386>
967
968         Add test that calls NPN_GetURLNotify on a URL that can't be loaded, and checks if NPP_URLNotify is called.
969
970         * DumpRenderTree/DumpRenderTree.gypi:
971         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
972         * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLNotifyWithURLThatFailsToLoad.cpp: Added.
973         (GetURLNotifyWithURLThatFailsToLoad::GetURLNotifyWithURLThatFailsToLoad):
974         (GetURLNotifyWithURLThatFailsToLoad::NPP_New):
975         (GetURLNotifyWithURLThatFailsToLoad::NPP_URLNotify):
976         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
977         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
978         * GNUmakefile.am:
979
980 2011-05-14  Sheriff Bot  <webkit.review.bot@gmail.com>
981
982         Unreviewed, rolling out r86476.
983         http://trac.webkit.org/changeset/86476
984         https://bugs.webkit.org/show_bug.cgi?id=60832
985
986         It made plugins/get-url-notify-with-url-that-fails-to-
987         load.html crash on GTK (Requested by Ossy on #webkit).
988
989         * DumpRenderTree/DumpRenderTree.gypi:
990         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
991         * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLNotifyWithURLThatFailsToLoad.cpp: Removed.
992         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
993         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
994         * GNUmakefile.am:
995
996 2011-05-13  Anders Carlsson  <andersca@apple.com>
997
998         Reviewed by Sam Weinig.
999
1000         NPP_URLNotify is not called if a URL passed to NPN_GetURLNotify fails to load
1001         https://bugs.webkit.org/show_bug.cgi?id=60823
1002         <rdar://problem/9430386>
1003
1004         Add test that calls NPN_GetURLNotify on a URL that can't be loaded, and checks if NPP_URLNotify is called.
1005
1006         * DumpRenderTree/DumpRenderTree.gypi:
1007         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1008         * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLNotifyWithURLThatFailsToLoad.cpp: Added.
1009         (GetURLNotifyWithURLThatFailsToLoad::GetURLNotifyWithURLThatFailsToLoad):
1010         (GetURLNotifyWithURLThatFailsToLoad::NPP_New):
1011         (GetURLNotifyWithURLThatFailsToLoad::NPP_URLNotify):
1012         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1013         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1014         * GNUmakefile.am:
1015
1016 2011-05-13  Anders Carlsson  <andersca@apple.com>
1017
1018         Build fix.
1019
1020         * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLWithJavaScriptURL.cpp:
1021
1022 2011-05-13  Anders Carlsson  <andersca@apple.com>
1023
1024         Reviewed by Sam Weinig.
1025
1026         NPN_GetURL with a javascript: URL doesn't send back the result in the stream
1027         https://bugs.webkit.org/show_bug.cgi?id=60810
1028
1029         Add a test that calls NPN_GetURL on a javascript: URL and checks that it gets back the expected result.
1030
1031         * DumpRenderTree/DumpRenderTree.gypi:
1032         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1033         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1034         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1035         * GNUmakefile.am:
1036         Add files.
1037
1038         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
1039         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
1040         Add new NPN and NPP wrappers and sort them according to the order they appear in npfunctions.h
1041
1042         * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLWithJavaScriptURL.cpp: Added.
1043         (GetURLWithJavaScriptURL::GetURLWithJavaScriptURL):
1044         (GetURLWithJavaScriptURL::NPP_New):
1045         (GetURLWithJavaScriptURL::NPP_NewStream):
1046         (GetURLWithJavaScriptURL::NPP_DestroyStream):
1047         (GetURLWithJavaScriptURL::NPP_WriteReady):
1048         (GetURLWithJavaScriptURL::NPP_Write):
1049         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1050         (NPP_NewStream):
1051         (NPP_WriteReady):
1052         (NPP_Write):
1053         (NPP_URLNotify):
1054         call the PluginTest NPP wrappers.
1055
1056 2011-05-13  Sheriff Bot  <webkit.review.bot@gmail.com>
1057
1058         Unreviewed, rolling out r86447.
1059         http://trac.webkit.org/changeset/86447
1060         https://bugs.webkit.org/show_bug.cgi?id=60809
1061
1062         "Broke some uses of EventSender object on Qt" (Requested by
1063         mwenge on #webkit).
1064
1065         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1066         (WebCore::WebPage::WebPage):
1067         (WebCore::DumpRenderTree::DumpRenderTree):
1068         (WebCore::DumpRenderTree::initJSObjects):
1069         (WebCore::DumpRenderTree::createWindow):
1070         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1071         (WebCore::DumpRenderTree::eventSender):
1072         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1073         (webkit_test_plugin_new_instance):
1074         (webkit_test_plugin_set_window):
1075         (webkit_test_plugin_handle_event):
1076
1077 2011-05-13  Robert Hogan  <robert@webkit.org>
1078
1079         Reviewed by Benjamin Poulain.
1080
1081         [Qt] fix http/tests/plugins/plugin-document-has-focus.html
1082
1083         The support for this test added to the unix test plugin here
1084         may allow other platforms to pass it (nearly everyone
1085         skips it). On Qt it required a bit of trickiness with
1086         the page's EventSender object to get it working fully though,
1087         so only unskipping Qt here.
1088
1089         https://bugs.webkit.org/show_bug.cgi?id=60722
1090
1091         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1092         (WebCore::WebPage::WebPage):
1093         (WebCore::WebPage::eventSender):
1094         (WebCore::DumpRenderTree::DumpRenderTree):
1095         (WebCore::DumpRenderTree::initJSObjects):
1096         (WebCore::DumpRenderTree::createWindow):
1097         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1098         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1099         (webkit_test_plugin_new_instance):
1100         (webkit_test_plugin_set_window):
1101         (webkit_test_plugin_handle_event):
1102
1103 2011-05-13  Adam Roben  <aroben@apple.com>
1104
1105         Exclude the Leopard NRWT bot from the core builder set
1106
1107         Fixes <http://webkit.org/b/60392> Leopard Intel Release (NRWT) shouldn't be a core builder
1108
1109         Reviewed by Darin Adler.
1110
1111         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1112         (BuildBot.__init__): Tighten up the Leopard regexp to only allow the non-NRWT Leopard bots
1113         in the core builder set.
1114
1115         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1116         (BuildBotTest.test_builder_name_regexps): Updated to match the current set of builders and
1117         regexps.
1118
1119 2011-05-13  Adam Roben  <aroben@apple.com>
1120
1121         Group all the NRWT bots together
1122
1123         This also gets the new NRWT bots out of the middle of Apple's bots. Since these new NRWT
1124         bots are experimental, it seems best not to clutter up the non-experimental bots with
1125         experimental ones.
1126
1127         Fixes <http://webkit.org/b/60769> New "(NRWT)" bots are right in the middle of Apple's bots
1128         on build.webkit.org
1129
1130         Reviewed by Dan Bernstein.
1131
1132         * BuildSlaveSupport/build.webkit.org-config/config.json: Moved the "(NRWT)" bots next to the
1133         Chromium testers, which also use new-run-webkit-tests.
1134
1135 2011-05-13  Adam Roben  <aroben@apple.com>
1136
1137         Add a plugin test that dumps the plugin window's rect
1138
1139         Part of the test for <http://webkit.org/b/60194> <rdar://problem/9383760> REGRESSION
1140         (r79167): Windowed plugins in Google Reader don't move when the article list is scrolled
1141
1142         Reviewed by Dan Bernstein.
1143
1144         * DumpRenderTree/TestNetscapePlugIn/Tests/win/DumpWindowRect.cpp: Added.
1145         (DumpWindowRect::DumpWindowRect): Just call up to the base class.
1146         (DumpWindowRect::performWindowGeometryTest): Find our window rect relative to the test
1147         harness window and log it.
1148
1149         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Added DumpWindowRect.
1150
1151 2011-05-13  Adam Roben  <aroben@apple.com>
1152
1153         Move code required for most tests of plugin window geometry into a base class
1154
1155         WebKit2's asynchronous plugin window positioning makes testing window geometry tricky. By
1156         having all the trickiness in a shared base class, writing new window geometry tests will be
1157         much easier.
1158
1159         Fixes <http://webkit.org/b/60776> It's hard to write tests that check plugin window geometry
1160
1161         Reviewed by Anders Carlsson.
1162
1163         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowRegionIsSetToClipRect.cpp:
1164         (WindowRegionIsSetToClipRect::WindowRegionIsSetToClipRect): Changed to inherit from the new
1165         WindowGeometryTest base class. Most of the code from this class was moved to the new base
1166         class.
1167         (WindowRegionIsSetToClipRect::performWindowGeometryTest): Renamed from checkWindowRegion.
1168         This is called by the base class when it is safe to check the window's geometry. Note that
1169         the m_didCheckWindowRegion logic was removed completely; it has never been needed and was
1170         just vestigial code from an earlier version of this test.
1171
1172         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Added new
1173         WindowGeometryTest class.
1174
1175         * DumpRenderTree/TestNetscapePlugIn/win/WindowGeometryTest.cpp: Added. Code came from
1176         WindowRegionIsSetToClipRect.
1177         (WindowGeometryTest::finishTest): This is the only change from WindowRegionIsSetToClipRect.
1178         We now call the new virtual performWindowGeometryTest function instead of checkWindowRegion.
1179         Subclasses can implement that function to perform their own tests.
1180
1181         * DumpRenderTree/TestNetscapePlugIn/win/WindowGeometryTest.h: Added.
1182
1183 2011-05-13  Zoltan Herczeg  <zherczeg@webkit.org>
1184
1185         Reviewed by Csaba Osztrogonác.
1186
1187         Missing 2nd #EOF if WebProcess is killed.
1188         https://bugs.webkit.org/show_bug.cgi?id=60761
1189
1190         If the WebProcess is killed, only one #EOF is yielded
1191         by WebKitTestRunner. However, run-webkit-test wait for
1192         a second #EOF, which signals the finishing of pixel dump.
1193         Since this never happens, run-webkit-test waits forever.
1194
1195         * WebKitTestRunner/TestInvocation.cpp:
1196         (WTR::TestInvocation::dump):
1197         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1198         * WebKitTestRunner/TestInvocation.h:
1199
1200 2011-05-13  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
1201
1202         Reviewed by Csaba Osztrogonác.
1203
1204         [NRWT] chromium-linux tests shouldn't run on other platforms
1205         https://bugs.webkit.org/show_bug.cgi?id=60162
1206
1207         Remove _tests_for_other_platforms defs because r82753
1208         implemented it properly in the baseclass in webkit.py.
1209
1210         * Scripts/webkitpy/layout_tests/port/gtk.py:
1211         * Scripts/webkitpy/layout_tests/port/qt.py:
1212         * Scripts/webkitpy/layout_tests/port/win.py:
1213
1214 2011-05-12  Ryuan Choi  <ryuan.choi@samsung.com>
1215
1216         Reviewed by Antonio Gomes.
1217
1218         [EFL] Remove unused option of EWeblauncher
1219         https://bugs.webkit.org/show_bug.cgi?id=60747
1220
1221         Remove sudo-workaround option.
1222         This option is not used and make other option wrong.
1223
1224         * EWebLauncher/main.c:
1225
1226 2011-05-12  Lucas Forschler  <lforschler@apple.com>
1227
1228         Reviewed by Stephanie Lewis.
1229
1230         Fix config.json to address missing WK2 builder/tester config.
1231         Fix naming of machines (xserve not macpro)
1232
1233         * BuildSlaveSupport/build.webkit.org-config/config.json:
1234
1235 2011-05-12  Lucas Forschler  <lforschler@apple.com>
1236
1237         Reviewed by Stephanie Lewis.
1238
1239         Add SnowLeopard Debug builder and Test bot.
1240         apple-xserve-8 = SL Debug Tester.
1241         apple-xserve-9 = SL Debug Builder.
1242         
1243         * BuildSlaveSupport/build.webkit.org-config/config.json:
1244
1245 2011-05-12  Adam Barth  <abarth@webkit.org>
1246
1247         This patch disables sheriffbot's bug postings.  He's just been way too
1248         spammy recently due to test flakiness.
1249
1250         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1251         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
1252
1253 2011-05-11  Brian Weinstein  <bweinstein@apple.com>
1254
1255         Reviewed by Anders Carlsson.
1256
1257         After relaunching an unresponsive web process, web page stops responding to mouse movement
1258         https://bugs.webkit.org/show_bug.cgi?id=60669
1259         <rdar://problem/9409934>
1260         
1261         This test follows the steps needed to reproduce this bug:
1262         1) Hang the web process
1263         2) While the web process is hung, move the mouse (so WebPageProxy thinks it is processing a mouse move event)
1264         3) Kill and restart the WebProcess
1265         4) Move the mouse
1266         
1267         We are testing that we receive mouse move events after the WebProcess has restarted.
1268
1269         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp: Added.
1270         (TestWebKitAPI::didFinishLoadForFrame): Set a flag that we finished loading.
1271         (TestWebKitAPI::processDidBecomeUnresponsive): Kill the web process once we become unresponsive.
1272         (TestWebKitAPI::processDidCrash): Reload the page when the process crashes, which restarts the web process.
1273         (TestWebKitAPI::setPageLoaderClient):
1274         (TestWebKitAPI::TEST):
1275         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash_Bundle.cpp: Added.
1276         (TestWebKitAPI::MouseMoveAfterCrashTest::MouseMoveAfterCrashTest):
1277         (TestWebKitAPI::MouseMoveAfterCrashTest::didReceiveMessage):
1278         * TestWebKitAPI/Tests/WebKit2/mouse-move-listener.html: Added.
1279
1280         * TestWebKitAPI/PlatformWebView.h:
1281         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
1282         (TestWebKitAPI::PlatformWebView::simulateMouseMove): Sends the messages that simulate a mouse move.
1283         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
1284         (TestWebKitAPI::PlatformWebView::simulateMouseMove): Ditto.
1285
1286         Add new files.
1287         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1288         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1289         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
1290         * TestWebKitAPI/win/copy-resources.cmd:
1291
1292 2011-05-12  Tomasz Morawski  <t.morawski@samsung.com>
1293
1294         Reviewed by Antonio Gomes.
1295
1296         [EFL] Added initialization/shutdown for ecore_file library
1297         https://bugs.webkit.org/show_bug.cgi?id=60457
1298
1299         Added initialization and shuthown for ecore_file library and replaced
1300         realpath function to ecore_file_realpath.
1301
1302         * EWebLauncher/main.c:
1303         (quit):
1304         (findThemePath):
1305         (main):
1306
1307 2011-05-12  Young Han Lee  <joybro@company100.net>
1308
1309         Reviewed by Kenneth Rohde Christiansen.
1310
1311         [Qt] Implement layoutTestController.layerTreeAsText()
1312         https://bugs.webkit.org/show_bug.cgi?id=60367
1313
1314         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1315         (LayoutTestController::layerTreeAsText):
1316         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1317
1318 2011-05-11  Eric Seidel  <eric@webkit.org>
1319
1320         Reviewed by David Levin.
1321
1322         Teach validate-committer-lists how to validate committers bugzilla_email()
1323         https://bugs.webkit.org/show_bug.cgi?id=60651
1324
1325         It turns out we currently have 9 committers with invalid values for their
1326         bugzilla_email field (meaning we don't know what email is their bugzilla account).
1327         "Alexander Kellett" <lypanov@mac.com>
1328         "Andre Boule" <aboule@apple.com>
1329         "Cameron McCormack" <cam@webkit.org>
1330         "Chris Petersen" <cpetersen@apple.com>
1331         "Eli Fidler" <eli@staikos.net>
1332         "Matt Lilek" <webkit@mattlilek.com>
1333         "Pierre d'Herbemont" <pdherbemont@free.fr>
1334         "Scott Violet" <sky@chromium.org>
1335         "Adam Treat" <treat@kde.org>
1336
1337         Most of those haven't committed in a very long time, so it's not suprising
1338         that we haven't noticed that their bugzilla emails are bogus.
1339
1340         * Scripts/validate-committer-lists:
1341         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1342         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
1343
1344 2011-05-11  Dmitry Lomov  <dslomov@google.com>
1345
1346         Reviewed by David Levin.
1347
1348         https://bugs.webkit.org/show_bug.cgi?id=59561
1349         Switch TestWebKitAPI to GTest
1350
1351         Fixes Makefiles and WinCairo build as well
1352
1353         * Makefile:
1354         * Scripts/build-api-tests:
1355         * Scripts/run-api-tests:
1356         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
1357         * TestWebKitAPI/Test.h:
1358         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1359         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
1360         (TestWebKitAPI::TEST):
1361         * TestWebKitAPI/TestsController.cpp:
1362         (TestWebKitAPI::TestsController::TestsController):
1363         (TestWebKitAPI::TestsController::dumpTestNames):
1364         (TestWebKitAPI::TestsController::runTestNamed):
1365         (TestWebKitAPI::TestsController::runAllTests):
1366         * TestWebKitAPI/TestsController.h:
1367         * TestWebKitAPI/mac/main.mm:
1368         (main):
1369
1370 2011-05-11  Eric Seidel  <eric@webkit.org>
1371
1372         Reviewed by Alexey Proskuryakov.
1373
1374         Add Luke Macpherson to committers.py as a Contributor
1375         https://bugs.webkit.org/show_bug.cgi?id=60639
1376
1377         * Scripts/webkitpy/common/config/committers.py:
1378
1379 2011-05-11  Noam Rosenthal  <noam.rosenthal@nokia.com>
1380
1381         Reviewed by Kenneth Rohde Christiansen.
1382
1383         [Texmap][Qt] Upstream texture-mapper changes from Qt's WebKit2 branch
1384         https://bugs.webkit.org/show_bug.cgi?id=60439
1385
1386         Patch 4/12: Update the build script to enable 3D rendering by default for Qt.
1387
1388         * Scripts/build-webkit:
1389
1390 2011-05-11  Brian Weinstein  <bweinstein@apple.com>
1391
1392         Reviewed by Adam Roben.
1393
1394         REGRESSION (r86161): WKPreferences API test failing on Windows
1395         https://bugs.webkit.org/show_bug.cgi?id=60658
1396
1397         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
1398         (TestWebKitAPI::TEST):
1399
1400 2011-05-11  Alice Boxhall  <aboxhall@chromium.org>
1401
1402         Reviewed by Ojan Vafai.
1403
1404         Modify jsonresults_unittest.py to use a dict format for its test data, and modify jsonresults.py to flatten hierarchical directory structures in input JSON.
1405         https://bugs.webkit.org/show_bug.cgi?id=60521
1406
1407         First steps towards making the results JSON all hierarchical.
1408
1409         * TestResultServer/model/jsonresults.py:
1410         * TestResultServer/model/jsonresults_unittest.py:
1411
1412 2011-05-11  Kevin Ollivier  <kevino@theolliviers.com>
1413
1414         [wx] Build fix, adding new LayoutTestController method stubs.
1415
1416         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1417         (LayoutTestController::localStorageDiskUsageForOrigin):
1418         (LayoutTestController::applicationCacheDiskUsageForOrigin):
1419
1420 2011-05-11  Jessie Berlin  <jberlin@apple.com>
1421
1422         Reviewed by Darin Adler.
1423
1424         [WebKit2] exceededDatabaseQuota function on WKPageUIClient needs to provide information
1425         about the usage for both the origin overall and the database in question.
1426         https://bugs.webkit.org/show_bug.cgi?id=60573
1427
1428         * WebKitTestRunner/TestController.cpp:
1429         (WTR::exceededDatabaseQuota):
1430
1431 2011-05-10  Stephen White  <senorblanco@chromium.org>
1432
1433         Reviewed by David Levin.
1434
1435         Adding myself as a reviewer.
1436         https://bugs.webkit.org/show_bug.cgi?id=60587
1437
1438         * Scripts/webkitpy/common/config/committers.py:
1439
1440 2011-05-11  Eric Seidel  <eric@webkit.org>
1441
1442         Reviewed by Csaba Osztrogonác.
1443
1444         queues.webkit.org should show 1000+ instead of 1000 when we hit the query limit
1445         https://bugs.webkit.org/show_bug.cgi?id=60614
1446
1447         AppEngine has a result limit of 1000.  We hit that when trying
1448         to find out how many patches the style-queue (and other queues)
1449         have passed in the last 30 days.  So lets display 1000+ instead
1450         of 1000 to avoid confusion. (Ossy was asking about this in #webkit tonight.)
1451
1452         I also made the status pages show "never" instead of just "ago" when we
1453         haven't seen a pass or boot message in the last 1000 messages.
1454
1455         * QueueStatusServer/handlers/queuestatus.py:
1456         * QueueStatusServer/templates/queuestatus.html:
1457
1458 2011-05-11  Adam Barth  <abarth@webkit.org>
1459
1460         Reviewed by Eric Seidel.
1461
1462         sheriffbot shouldn't spam bugs when it can't figure out who to blame
1463         https://bugs.webkit.org/show_bug.cgi?id=60613
1464
1465         This patch limits the number of bugs sheriffbot will spam to three.
1466         Ideally, we'd come up with some smarter huerstics, but hopefully this
1467         will cut down on the bugmail spam for slow bots.
1468
1469         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1470
1471 2011-05-10  Eric Seidel  <eric@webkit.org>
1472
1473         Reviewed by Adam Barth.
1474
1475         EWS bots should be robust against test-webkitpy hangs
1476         https://bugs.webkit.org/show_bug.cgi?id=60579
1477
1478         Added a killAfterTimeout subroutine, which takes a child_pid
1479         and timeout, and will setup a watchdog process to kill that child
1480         after the timeout.  killAfterTimeout will waitpid on the child.
1481
1482         * EWSTools/start-queue.sh:
1483
1484 2011-05-10  MORITA Hajime  <morrita@google.com>
1485
1486         Unreviewed, moved myself to the reviewers list.
1487
1488         * Scripts/webkitpy/common/config/committers.py:
1489
1490 2011-05-10  Anton D'Auria  <adauria@apple.com>
1491
1492         Reviewed by David Levin.
1493
1494         StorageTracker should report actual local storage usage on disk
1495         https://bugs.webkit.org/show_bug.cgi?id=60558
1496
1497         * DumpRenderTree/LayoutTestController.cpp:
1498         (localStorageDiskUsageForOriginCallback):
1499         (LayoutTestController::staticFunctions):
1500         * DumpRenderTree/LayoutTestController.h:
1501         * DumpRenderTree/chromium/LayoutTestController.cpp:
1502         (LayoutTestController::LayoutTestController):
1503         (LayoutTestController::localStorageDiskUsageForOrigin):
1504         * DumpRenderTree/chromium/LayoutTestController.h:
1505         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1506         (LayoutTestController::localStorageDiskUsageForOrigin):
1507         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1508         (LayoutTestController::localStorageDiskUsageForOrigin):
1509         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1510         (LayoutTestController::localStorageDiskUsageForOrigin):
1511         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1512         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1513         (LayoutTestController::localStorageDiskUsageForOrigin):
1514
1515 2011-05-10  Anton D'Auria  <adauria@apple.com>
1516
1517         Reviewed by Alexey Proskuryakov.
1518
1519         Add ApplicationCache API to get disk usage per origin
1520         https://bugs.webkit.org/show_bug.cgi?id=57127
1521
1522         Added test that loads two frames with ~15Kb image, checks usage,
1523         deletes app cache, verifies usage is 0.
1524
1525         * DumpRenderTree/LayoutTestController.cpp:
1526         (applicationCacheDiskUsageForOriginCallback):
1527         (LayoutTestController::staticFunctions):
1528         * DumpRenderTree/LayoutTestController.h:
1529         * DumpRenderTree/chromium/LayoutTestController.cpp: Added stub.
1530         (LayoutTestController::LayoutTestController):
1531         (LayoutTestController::applicationCacheDiskUsageForOrigin):
1532         * DumpRenderTree/chromium/LayoutTestController.h:
1533         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added stub.
1534         (LayoutTestController::applicationCacheDiskUsageForOrigin):
1535         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1536         (LayoutTestController::applicationCacheDiskUsageForOrigin):
1537         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added stub.
1538         (LayoutTestController::applicationCacheDiskUsageForOrigin):
1539         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1540         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Added stub.
1541         (LayoutTestController::applicationCacheDiskUsageForOrigin):
1542
1543 2011-05-10  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
1544
1545         Unreviewed, adding Rafael Antognolli as a committer.
1546
1547         * Scripts/webkitpy/common/config/committers.py:
1548
1549 2011-05-10  Chris Evans  <cevans@chromium.org>
1550
1551         Reviewed by Adam Barth.
1552
1553         Add WebCore::Setting to block displaying and/or running insecure content on secure pages
1554         https://bugs.webkit.org/show_bug.cgi?id=58378
1555
1556         * DumpRenderTree/chromium/LayoutTestController.cpp:
1557         (LayoutTestController::LayoutTestController):
1558         (LayoutTestController::setAllowDisplayOfInsecureContent):
1559         (LayoutTestController::setAllowRunningOfInsecureContent):
1560         * DumpRenderTree/chromium/LayoutTestController.h:
1561         * DumpRenderTree/chromium/WebPreferences.cpp:
1562         (WebPreferences::reset):
1563         (WebPreferences::applyTo):
1564         * DumpRenderTree/chromium/WebPreferences.h:
1565         Add plumbing for new settings to Chromium DRT.
1566
1567 2011-05-10  Enrica Casucci  <enrica@apple.com>
1568
1569         Reviewed by Beth Dakin.
1570
1571         Added my name to the reviewers list and removed my name from
1572         to committer-only list.
1573
1574         * Scripts/webkitpy/common/config/committers.py:
1575
1576 2011-05-10  David Levin  <levin@chromium.org>
1577
1578         Reviewed by Shinichiro Hamaji.
1579
1580         check-webkit-style shouldn't filter the errors using the modified lines for the xml and test expectations checkers.
1581         https://bugs.webkit.org/show_bug.cgi?id=60466
1582
1583         * Scripts/webkitpy/style/checker.py: (unrelated) style fix.
1584         * Scripts/webkitpy/style/checker_unittest.py: Remove the file_path check since
1585           that property was removed.
1586         * Scripts/webkitpy/style/checkers/test_expectations.py: Turn off the line
1587           filtering for errors.
1588         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py: Add testing to
1589           verify that the line filtering is turned off.
1590         * Scripts/webkitpy/style/checkers/xml.py: Turn off the line filtering for errors
1591           and remove the unused file_path parameter.
1592         * Scripts/webkitpy/style/checkers/xml_unittest.py: Add testing to verify that the
1593           line filtering is turned off (and fix test_no_error).
1594         * Scripts/webkitpy/style/error_handlers.py: Added a way to turn off the filtering
1595           of errors based on the lines changed in the patch.
1596         * Scripts/webkitpy/style/error_handlers_unittest.py: Added a test for turning off
1597           the filtering.
1598
1599 2011-05-10  Adam Roben  <aroben@apple.com>
1600
1601         Update some plugin tests to work with WebKit2's asynchronous windowed plugin positioning on Windows
1602
1603         Fixes <http://webkit.org/b/60442> <rdar://problem/9403200> REGRESSION (r85795):
1604         platform/win/plugins/window-geometry-initialized-before-set-window.html and
1605         platform/win/plugins/window-region-is-set-to-clip-rect.html failing on Windows 7 Release
1606         (WebKit2 Tests)
1607
1608         Reviewed by Anders Carlsson.
1609
1610         * DumpRenderTree/TestNetscapePlugIn/Tests/win/NPNInvalidateRectInvalidatesWindow.cpp:
1611         (NPNInvalidateRectInvalidatesWindow::NPP_SetWindow): Moved some code from here to the new
1612         WindowedPluginTest::testHarnessWindow function.
1613
1614         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowGeometryInitializedBeforeSetWindow.cpp:
1615         (WindowGeometryInitializedBeforeSetWindow::NPP_SetWindow): Only check the window's size, not
1616         its position. In WebKit2, the position won't have been set yet, so we can't test it. But it
1617         turns out only the size mattered for <http://webkit.org/b/46716>, which this test was
1618         created for.
1619
1620         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowRegionIsSetToClipRect.cpp:
1621         (WindowRegionIsSetToClipRect::WindowRegionIsSetToClipRect): Converted to be a
1622         WindowedPluginTest, and initialized new members.
1623         (WindowRegionIsSetToClipRect::startTest): Make our plugin window visible, and set things up
1624         to ensure we get a WM_WINDOWPOSCHANGED message about it becoming visible.
1625         (WindowRegionIsSetToClipRect::finishTest): Check that the window region is what we expect,
1626         then clean up and tell the test harness we're done.
1627         (WindowRegionIsSetToClipRect::checkWindowRegion): Moved code to check the window region here
1628         from NPP_SetWindow. Changed to use the fancy new log() function instead of pluginLog().
1629         (WindowRegionIsSetToClipRect::showTestHarnessWindowIfNeeded): Show the test harness's window
1630         if it is hidden. This is needed to ensure we get a WM_WINDOWPOSCHANGED message when our own
1631         window becomes visible.
1632         (WindowRegionIsSetToClipRect::hideTestHarnessWindowIfNeeded): Hide the test harness's window
1633         if it was hidden at the start of the test.
1634         (WindowRegionIsSetToClipRect::wndProc): When our timer fires, tell the UI process to paint.
1635         This should cause our window to become visible and our window region to get set. When we get
1636         a WM_WINDOWPOSCHANGED message, we can finally finish the test.
1637         (WindowRegionIsSetToClipRect::NPP_GetValue): Return our script object.
1638         (WindowRegionIsSetToClipRect::ScriptObject::hasMethod): We only have one method:
1639         "startTest".
1640         (WindowRegionIsSetToClipRect::ScriptObject::invoke): Call through to the PluginTest object.
1641
1642         * DumpRenderTree/TestNetscapePlugIn/win/WindowedPluginTest.cpp:
1643         (WindowedPluginTest::testHarnessWindow):
1644         * DumpRenderTree/TestNetscapePlugIn/win/WindowedPluginTest.h:
1645         Added this helper function. Code came from NPNInvalidateRectInvalidatesWindow.
1646
1647 2011-05-10  Csaba Osztrogonác  <ossy@webkit.org>
1648
1649         Reviewed by Kenneth Rohde Christiansen.
1650
1651         [Qt] Add new qt-4.8 platform for layout testing
1652         https://bugs.webkit.org/show_bug.cgi?id=60544
1653
1654         * Scripts/old-run-webkit-tests:
1655         * Scripts/webkitdirs.pm:
1656
1657 2011-05-09  Sheriff Bot  <webkit.review.bot@gmail.com>
1658
1659         Unreviewed, rolling out r86108.
1660         http://trac.webkit.org/changeset/86108
1661         https://bugs.webkit.org/show_bug.cgi?id=60533
1662
1663         Broke makefile based builds and Cairo (Requested by weinig on
1664         #webkit).
1665
1666         * Scripts/build-api-tests:
1667         * Scripts/run-api-tests:
1668         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
1669         * TestWebKitAPI/Test.h:
1670         (TestWebKitAPI::Test::~Test):
1671         (TestWebKitAPI::Test::name):
1672         (TestWebKitAPI::Test::Register::Register):
1673         (TestWebKitAPI::Test::Register::create):
1674         (TestWebKitAPI::Test::Test):
1675         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1676         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
1677         (TestWebKitAPI::TEST):
1678         * TestWebKitAPI/TestsController.cpp:
1679         (TestWebKitAPI::TestsController::TestsController):
1680         (TestWebKitAPI::TestsController::dumpTestNames):
1681         (TestWebKitAPI::TestsController::runTestNamed):
1682         (TestWebKitAPI::TestsController::testFailed):
1683         (TestWebKitAPI::TestsController::registerCreateTestFunction):
1684         * TestWebKitAPI/TestsController.h:
1685         * TestWebKitAPI/mac/main.mm:
1686         (main):
1687
1688 2011-05-09  Hayato Ito  <hayato@chromium.org>
1689
1690         Reviewed by Ojan Vafai.
1691
1692         Skip reftests if pixel tests are disabled.
1693
1694         https://bugs.webkit.org/show_bug.cgi?id=59078
1695
1696         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
1697         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
1698         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
1699         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1700
1701 2011-05-09  Chang Shu  <cshu@webkit.org>
1702
1703         Reviewed by Kenneth Rohde Christiansen.
1704
1705         [Qt] DumpRenderTreeQt needs an implementation of unmarkText
1706         https://bugs.webkit.org/show_bug.cgi?id=60499
1707
1708         The implementation is similar to gtk.
1709
1710         * DumpRenderTree/qt/TextInputControllerQt.cpp:
1711         (TextInputController::unmarkText):
1712         * DumpRenderTree/qt/TextInputControllerQt.h:
1713
1714 2011-05-09  James Robinson  <jamesr@chromium.org>
1715
1716         Reviewed by Eric Seidel.
1717
1718         [chromium] Teach new-run-webkit-tests to follow symlinks when trying to determine the arch of DumpRenderTree on linux
1719         https://bugs.webkit.org/show_bug.cgi?id=60520
1720
1721         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1722
1723 2011-05-09  Dmitry Lomov  <dslomov@google.com>
1724
1725         Reviewed by Sam Weinig.
1726
1727         Switch TestWebKitAPI to GTest
1728         https://bugs.webkit.org/show_bug.cgi?id=59561
1729
1730         * Scripts/build-api-tests:
1731         * Scripts/run-api-tests:
1732         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
1733         * TestWebKitAPI/Test.h:
1734         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1735         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
1736         (TestWebKitAPI::TEST):
1737         * TestWebKitAPI/TestsController.cpp:
1738         (TestWebKitAPI::TestsController::TestsController):
1739         (TestWebKitAPI::TestsController::dumpTestNames):
1740         (TestWebKitAPI::TestsController::runTestNamed):
1741         (TestWebKitAPI::TestsController::runAllTests):
1742         * TestWebKitAPI/TestsController.h:
1743         * TestWebKitAPI/mac/main.mm:
1744         (main):
1745
1746 2011-05-09  Igor Oliveira  <igor.oliveira@openbossa.org>
1747
1748         Reviewed by Andreas Kling.
1749
1750         [Qt] DRT eventSender.addTouchPoint method is not setting the start position
1751         https://bugs.webkit.org/show_bug.cgi?id=60487
1752
1753         When adding a new touch point, the start position of this point needs to be set.
1754
1755         * DumpRenderTree/qt/EventSenderQt.cpp:
1756         (EventSender::addTouchPoint):
1757
1758 2011-05-09  Robert Hogan  <robert@webkit.org>
1759
1760         Reviewed by Adam Roben.
1761
1762         https://bugs.webkit.org/show_bug.cgi?id=57137
1763
1764         Unskip plugins/embed-prefers-plugins-for-images.html
1765
1766         Add image/png mime-type to test netscape plugin on Unix.
1767
1768         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1769         (NP_GetMIMEDescription):
1770
1771 2011-05-09  Alice Boxhall  <aboxhall@chromium.org>
1772
1773         Reviewed by Ojan Vafai.
1774
1775         Pull jsonresults_unittest test cases out into separate test methods.
1776         https://bugs.webkit.org/show_bug.cgi?id=60418
1777
1778         * TestResultServer/model/jsonresults_unittest.py:
1779
1780 2011-05-09  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
1781
1782         Reviewed by Andreas Kling.
1783
1784         [Qt] fix fast/dom/Geolocation/window-close-crash.html
1785         https://bugs.webkit.org/show_bug.cgi?id=60458
1786
1787         Update all pages with Mock position/error/permission.
1788
1789         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1790         (LayoutTestController::setGeolocationPermission):
1791         (LayoutTestController::setMockGeolocationError):
1792         (LayoutTestController::setMockGeolocationPosition):
1793
1794 2011-05-09  Shishir Agrawal  <shishir@chromium.org>
1795
1796         Reviewed by Tony Gentilcore.
1797
1798         Implement Page Visibility API.
1799         https://bugs.webkit.org/show_bug.cgi?id=54181
1800
1801         * DumpRenderTree/LayoutTestController.cpp:
1802         (setPageVisibilityCallback):
1803         (resetPageVisibilityCallback):
1804         (LayoutTestController::staticFunctions):
1805         * DumpRenderTree/LayoutTestController.h:
1806         (LayoutTestController::setPageVisibility):
1807         (LayoutTestController::resetPageVisibility):
1808         * DumpRenderTree/chromium/LayoutTestController.cpp:
1809         (LayoutTestController::LayoutTestController):
1810         (LayoutTestController::resetPageVisibility):
1811         (LayoutTestController::setPageVisibility):
1812         * DumpRenderTree/chromium/LayoutTestController.h:
1813
1814 2011-05-07  Adam Barth  <abarth@webkit.org>
1815
1816         Reviewed by Eric Seidel.
1817
1818         Testing EWS spins on patches with a large number of failures
1819         https://bugs.webkit.org/show_bug.cgi?id=60441
1820
1821         In cases where the tree has a small number of persistent failures but a
1822         patch has a large number of failures, we weren't believing any results.
1823         That lead to us retrying the patch forever while we waited for
1824         trustworthy results that would never come.
1825
1826         This patch loosens the semantics of unexpected_failures to return a
1827         subset (rather than the exact set) of unexpected failures.  In the case
1828         where the tree has a bounded number of failures and the patch has an
1829         unbounded number of failures, we can accurately compute such a subset
1830         and reject the patch.
1831
1832         * Scripts/webkitpy/tool/bot/expectedfailures.py:
1833         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py:
1834         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1835         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1836         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1837
1838 2011-05-07  Joe Mason  <jmason@rim.com>
1839
1840         Reviewed by Daniel Bates.
1841
1842         FrameLoader::isProcessingUserGesture is wrong in dispatchWillPerformClientRedirect
1843         https://bugs.webkit.org/show_bug.cgi?id=52211
1844
1845         Dump isUserProcessingGesture in willPerformClientRedirect so that the layout tests can be extended.
1846         (For the Mac and Chromium ports - other ports don't support dumping user gestures in DRT.)
1847
1848         * DumpRenderTree/chromium/WebViewHost.cpp:
1849         (WebViewHost::willPerformClientRedirect):
1850         (WebViewHost::didStartProvisionalLoad):
1851         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1852         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
1853
1854 2011-05-07  Daniel Bates  <dbates@webkit.org>
1855
1856         Attempt to fix the build; remove some more references to isTiger(), which was removed in changeset 86007
1857         <http://trac.webkit.org/changeset/86007> (bug #60438).
1858
1859         * Scripts/old-run-webkit-tests:
1860           - Removed reference to isTiger() from openDumpTool(), captureSavedCrashLog(), and
1861             file local variable. 
1862
1863 2011-05-07  Pratik Solanki  <psolanki@apple.com>
1864
1865         Reviewed by Darin Adler.
1866
1867         Remove references to Tiger in scripts
1868         https://bugs.webkit.org/show_bug.cgi?id=60438
1869
1870         Remove isTiger() and all of the code that depends on it.
1871
1872         * Scripts/build-webkit:
1873         * Scripts/ensure-valid-python:
1874         * Scripts/gdb-safari:
1875         * Scripts/webkitdirs.pm:
1876
1877 2011-05-06  David Grogan  <dgrogan@chromium.org>
1878
1879         Reviewed by Eric Seidel.
1880
1881         update link to message about mac 64bit git binaries
1882         https://bugs.webkit.org/show_bug.cgi?id=60411
1883
1884         The original message implied (correctly, at-the-time) that
1885         http://code.google.com/p/git-osx-installer/ doesn't provide 64-bit
1886         binaries. The new message notes that they do. This might prevent someone
1887         else from spending a few minutes confused.
1888
1889         * Scripts/webkitpy/common/checkout/scm/git.py:
1890
1891 2011-05-06  Dirk Pranke  <dpranke@chromium.org>
1892
1893         Reviewed by Ojan Vafai.
1894
1895         new-run-webkit-tests: crashes in race with crashing DRT
1896         https://bugs.webkit.org/show_bug.cgi?id=60238
1897
1898         This fixes a race where if we wrote the URL to DRT and
1899         DRT crashed immediately, we could get a broken pipe
1900         error back during the write() and not handle it correctly,
1901         causing NRWT to also crash.
1902
1903         * Scripts/webkitpy/layout_tests/port/server_process.py:
1904         * Scripts/webkitpy/layout_tests/port/webkit.py:
1905
1906 2011-05-06  Adam Barth  <abarth@webkit.org>
1907
1908         Reviewed by Eric Seidel.
1909
1910         Add a --skip-integrationtests mode to test-webkitpy
1911         https://bugs.webkit.org/show_bug.cgi?id=60354
1912
1913         These two test suites account for 2/3 of test-webkitpy's running time
1914         because they're not actually unit tests.  They're integration tests.
1915         This patch adds the ability to skip integration tests by passing a
1916         command line argument to test-webkitpy.  The buildbots will continue to
1917         run these integration tests to make sure they don't regress.  This
1918         option is for use by developers when working on parts of the code that
1919         are well-covered by unit tests.
1920
1921         * Scripts/webkitpy/common/system/file_lock_integrationtest.py: Copied from Tools/Scripts/webkitpy/common/system/file_lock_unittest.py.
1922         * Scripts/webkitpy/common/system/file_lock_unittest.py: Removed.
1923         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Copied from Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py.
1924         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: Removed.
1925         * Scripts/webkitpy/test/main.py:
1926
1927 2011-05-06  Adam Barth  <abarth@webkit.org>
1928
1929         Reviewed by Eric Seidel.
1930
1931         The results.zip generated by the Chromium EWS are too big
1932         https://bugs.webkit.org/show_bug.cgi?id=60352
1933
1934         Currently results.zip created by the Chromium EWS bot contain roughly
1935         1000 tests that we expect to fail.  These test results are not helpful
1936         to contributors.
1937
1938         There are several approaches to solving this problem:
1939
1940         1) We could be more selective about which files to include in the zip.
1941         2) We could ask new-run-webkit-tests not to generate results for
1942            expected failures.
1943         3) We could ask new-run-webkit-tests not to run tests that we expect to
1944            fail.
1945
1946         This patch takes approach (3).  Currently, we're ignoring the outcome
1947         of failing tests anyway, so there's not much point in actually running
1948         them.  As a side benefit, this will speed up the test run by about 6%.
1949         In the future, we might revisit this decision and choose another
1950         approach.
1951
1952         * Scripts/webkitpy/common/config/ports.py:
1953         * Scripts/webkitpy/common/config/ports_unittest.py:
1954
1955 2011-05-06  Gabor Rapcsanyi  <rgabor@webkit.org>
1956
1957         Reviewed by Csaba Osztrogonác.
1958
1959         [Qt] Use qt-arm platform instead of qt-linux on ARM platform.
1960
1961         * Scripts/old-run-webkit-tests:
1962
1963 2011-05-06  Adam Barth  <abarth@webkit.org>
1964
1965         Reviewed by Ojan Vafai.
1966
1967         Add an option to NRWT to skip failing tests
1968         https://bugs.webkit.org/show_bug.cgi?id=60295
1969
1970         This option is similar to the way old-run-webkit-tests works.  We're
1971         planning to use this option on the testing EWS bots because they don't
1972         use information from failing tests yet.
1973
1974         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
1975         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1976         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1977
1978 2011-05-04  Philippe Normand  <pnormand@igalia.com>
1979
1980         Reviewed by Dimitri Glazkov.
1981
1982         Implement LayoutTestController::pseudoShadowId()
1983         https://bugs.webkit.org/show_bug.cgi?id=60034
1984
1985         shadowPseudoId support in the various LayoutTestController
1986         implementations.
1987
1988         * DumpRenderTree/LayoutTestController.cpp:
1989         (shadowPseudoIdCallback):
1990         (LayoutTestController::staticFunctions):
1991         * DumpRenderTree/LayoutTestController.h:
1992         * DumpRenderTree/chromium/LayoutTestController.cpp:
1993         (LayoutTestController::LayoutTestController):
1994         (LayoutTestController::shadowPseudoId):
1995         * DumpRenderTree/chromium/LayoutTestController.h:
1996         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1997         (LayoutTestController::shadowPseudoId):
1998         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1999         (LayoutTestController::shadowPseudoId):
2000         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2001         (LayoutTestController::shadowPseudoId):
2002         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2003         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2004         (LayoutTestController::shadowPseudoId):
2005         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2006         (LayoutTestController::shadowPseudoId):
2007         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2008         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2009         (WTR::LayoutTestController::shadowPseudoId):
2010         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2011
2012 2011-05-06  Adam Barth  <abarth@webkit.org>
2013
2014         EWS can't reject patches
2015         https://bugs.webkit.org/show_bug.cgi?id=60345
2016
2017         We're supposed to use patch.id() for the attachment ID, silly.
2018
2019         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2020         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2021
2022 2011-05-05  Steve Lacey  <sjl@chromium.org>
2023
2024         Reviewed by Ojan Vafai.
2025
2026         Fix generation of results html file by passing relative path to scm
2027         methods.
2028         Generate diff images for results html file.
2029
2030         https://bugs.webkit.org/show_bug.cgi?id=60086
2031
2032         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2033         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2034
2035 2011-05-05  Andy Estes  <aestes@apple.com>
2036
2037         Reviewed by Daniel Bates.
2038
2039         update-webkit should handle Internal using a different VCS than OpenSource.
2040         https://bugs.webkit.org/show_bug.cgi?id=60310
2041
2042         isGit() and isSVN() cache their results, so Internal will always be
2043         updated using the VCS commands used for OpenSource. If Internal uses a
2044         different VCS, this will fail. Fix this by calling isGitDirectory() and
2045         isSVNDirectory() instead, which do not cache their results.
2046
2047         * Scripts/update-webkit:
2048
2049 2011-05-05  Dirk Pranke  <dpranke@chromium.org>
2050
2051         Reviewed by Ojan Vafai.
2052
2053         nrwt: revamp integration tests incl. tests for servers
2054         https://bugs.webkit.org/show_bug.cgi?id=59985
2055
2056         This change adds the ability to run "integration tests" that
2057         depend on (and affect) the local environment on your machine.
2058         These tests can be run manually by invoking python on the
2059         test file in question and passing the '-i' flag, but are
2060         not run automatically as part of test-webkitpy.
2061
2062         Integration tests are identified by being methods named as
2063         "integration_test_*" instead of "test_*", and we use a
2064         custom TestLoader instead of the default one provided by
2065         unittest.
2066
2067         This change also adds a protected "_default_to_apache" method
2068         to the port object so we can do the right thing when starting
2069         and stopping web servers with less mechanism.
2070
2071         * Scripts/webkitpy/layout_tests/port/base.py:
2072         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
2073         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
2074         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2075         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2076         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2077
2078 2011-05-05  Adam Roben  <aroben@apple.com>
2079
2080         Robustify DRT's pixel-dumping code against semi-random alpha channel values on Windows
2081
2082         DRT generates a pixel dump on Windows using the WM_PRINT message. This message (just like
2083         most of GDI) doesn't write anything meaningful into the alpha channel. In some cases, the
2084         alpha channel will even get filled with zeros (like when ::GradientFill is used). To
2085         safeguard against this, we fill the alpha channel with constant full opacity after the
2086         WM_PRINT message is handled to ensure we end up with an opaque image. (Note that we can't
2087         just ignore the alpha channel when creating the PNG; Mac's pixel results have an alpha
2088         channel, and we want to be able to compare Mac and Windows pixel results, so Windows pixel
2089         results need an alpha channel, too.)
2090
2091         Fixes <http://webkit.org/b/60300> draws-gradient.html's pixel results can't be correctly
2092         generated due to alpha channel weirdness
2093
2094         Reviewed by Sam Weinig.
2095
2096         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
2097         (makeAlphaChannelOpaque): Added this helper function to fill a bitmap's alpha channel with
2098         constant full opacity.
2099         (createBitmapContextFromWebView): Make the bitmap's alpha channel opaque before wrapping it
2100         in a CGContext or cairo_surface.
2101
2102 2011-05-05  Adam Roben  <aroben@apple.com>
2103
2104         Add support for layoutTestController.dumpAsText(true) to WebKitTestRunner
2105
2106         Passing true tells the test harness to dump pixels even though we're not dumping a render
2107         tree.
2108
2109         Fixes <http://webkit.org/b/60298> Calling layoutTestController.dumpAsText(true) in
2110         WebKitTestRunner doesn't result in pixel results being generated
2111
2112         Reviewed by Sam Weinig.
2113
2114         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added dumpPixels
2115         argument to dumpAsText.
2116
2117         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2118         (WTR::InjectedBundlePage::dump): Updated for dumpAsText change.
2119
2120         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2121         (WTR::LayoutTestController::dumpAsText): Store the dumpPixels argument.
2122
2123         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Updated for IDL change.
2124
2125         * WebKitTestRunner/win/InjectedBundle.vcproj: Added .idl files as a convenience for Windows
2126         developers.
2127
2128 2011-05-05  Dirk Pranke  <dpranke@chromium.org>
2129
2130         Reviewed by Ojan Vafai.
2131
2132         new-run-webkit-tests: merge os, version fields in test config
2133         https://bugs.webkit.org/show_bug.cgi?id=60004
2134
2135         This change removes the 'o/s' field from the TestConfiguration
2136         object, and changes the 'MAC', 'WIN', and 'LINUX' modifiers in
2137         the expectations file to macros that expand to the version names
2138         for each platform.
2139
2140         This means that you can once again put any subset of the
2141         operating system versions on a single line, e.g.:
2142           BUGX LEOPARD XP LINUX : fast/html/foo.html = FAIL
2143
2144         This change will break any existing test_expectations.txt
2145         file that uses the "OS-VERSION" macros, which are no longer
2146         needed. It turns out they were never needed, as just VERSION
2147         by itself was sufficient. The test_expectations.txt file should
2148         be updated accordingly prior to landing this change.
2149
2150         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2151         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2152         * Scripts/webkitpy/layout_tests/port/base.py:
2153
2154 2011-05-05  Tony Chang  <tony@chromium.org>
2155
2156         Reviewed by Adam Barth.
2157
2158         [chromium] switch from Lucida to free fonts for Hindi and Thai
2159         https://bugs.webkit.org/show_bug.cgi?id=60287
2160
2161         The fonts are provided by the ttf-thai-tlwg and ttf-indic-fonts
2162         packages on Lucid. There are actually multiple Thai fonts in the
2163         package, so I just picked one.
2164
2165         * DumpRenderTree/chromium/TestShellGtk.cpp:
2166         (setupFontconfig):
2167
2168 2011-05-05  Tony Chang  <tony@chromium.org>
2169
2170         Reviewed by Ojan Vafai.
2171
2172         [chromium] google-chrome-64 builds should now fallback to chromium-linux-x86_64 results
2173         https://bugs.webkit.org/show_bug.cgi?id=60290
2174
2175         It used to be that google-chrome-32 was hardy32, google-chrome-64 was
2176         hardy64, chromium-linux was hardy32 and chromium-linux-x86_64 was
2177         lucid64.  Because of that, google-chrome-64 used to skip the
2178         chromium-linux-x86_64 results since they were more incorrect.
2179
2180         Now that we're switching to lucid for google-chrome, we want
2181         google-chrome-64 to fall back to chromium-linux-x86_64.
2182
2183         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
2184
2185 2011-05-05  Dirk Pranke  <dpranke@chromium.org>
2186
2187         Reviewed by Ojan Vafai.
2188
2189         new-run-webkit-tests: merge TestExpectations, TestExpectationsFile classes
2190         https://bugs.webkit.org/show_bug.cgi?id=60002
2191
2192         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
2193         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2194         * Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
2195         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2196         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2197         * Scripts/webkitpy/style/checkers/test_expectations.py:
2198
2199 2011-05-05  Eric Seidel  <eric@webkit.org>
2200
2201         Reviewed by Adam Barth.
2202
2203         commit-queue should reject patches which fail ewses
2204         https://bugs.webkit.org/show_bug.cgi?id=47534
2205
2206         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2207         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2208         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2209
2210 2011-05-05  Chang Shu  <cshu@webkit.org>
2211
2212         Reviewed by Andreas Kling.
2213
2214         [Qt][WK2] Support PageGroup in QGraphicsWKView/QWKPage constructors
2215         https://bugs.webkit.org/show_bug.cgi?id=59638
2216
2217         1. Call QGraphicsWKView constructor with pageGroupRef.
2218         2. Disable setFontFamily calls as it breaks Qt test fonts.
2219
2220         * WebKitTestRunner/TestController.cpp:
2221         (WTR::TestController::resetStateToConsistentValues):
2222         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2223         (WTR::WebView::WebView):
2224         (WTR::PlatformWebView::PlatformWebView):
2225
2226 2011-05-05  Joseph Pecoraro  <joepeck@webkit.org>
2227
2228         Reviewed by David Kilzer.
2229
2230         Add --only-webkit option to build-webkit
2231         https://bugs.webkit.org/show_bug.cgi?id=60245
2232
2233         * Scripts/build-webkit: If --only-webkit was specified
2234         just build the WebKit project, and not its dependencies.
2235
2236 2011-05-05  Jeff Miller  <jeffm@apple.com>
2237
2238         Reviewed by Darin Adler.
2239
2240         Add didNotHandleWheelEvent callback to WKPageUIClient
2241         https://bugs.webkit.org/show_bug.cgi?id=60203
2242
2243         * MiniBrowser/gtk/BrowserWindow.c:
2244         (browserWindowUIClientInit): Stub out didNotHandleWheelEvent callback.
2245         * MiniBrowser/mac/BrowserWindowController.m:
2246         (-[BrowserWindowController awakeFromNib]): Stub out didNotHandleWheelEvent callback.
2247         * MiniBrowser/win/BrowserView.cpp:
2248         (BrowserView::create): Stub out didNotHandleWheelEvent callback.
2249         * WebKitTestRunner/TestController.cpp:
2250         (WTR::TestController::createOtherPage): Stub out didNotHandleWheelEvent callback.
2251         (WTR::TestController::initialize): Stub out didNotHandleWheelEvent callback.
2252
2253 2011-05-04  Eric Seidel  <eric@webkit.org>
2254
2255         Reviewed by Adam Barth.
2256
2257         Add more missing imports from scm refactor
2258         https://bugs.webkit.org/show_bug.cgi?id=60239
2259
2260         * Scripts/webkitpy/common/checkout/scm/git.py:
2261         * Scripts/webkitpy/common/checkout/scm/svn.py:
2262
2263 2011-05-04  Eric Seidel  <eric@webkit.org>
2264
2265         Reviewed by Adam Barth.
2266
2267         sheriff-bot is having more exception trouble
2268         https://bugs.webkit.org/show_bug.cgi?id=60233
2269
2270         A webpage-forced build was causing SB to throw an exception.
2271         We've long had this bug, but we just didn't notice it until now.
2272
2273         In debugging this I found we fetch an absurd amount of data now
2274         that we use buildbot's json (instead of xmlrpc), so I added
2275         the filter=1 parameter to reduce it a little.  That required
2276         me to handle the case where filter=1 would strip
2277         result=0 in some cases (it's unclear why it does that).
2278
2279         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2280         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2281
2282 2011-05-04  Cris Neckar  <cdn@chromium.org>
2283
2284         Unreviewed, Adding Cris Neckar as a committer
2285
2286         * Scripts/webkitpy/common/config/committers.py:
2287
2288 2011-05-04  Siddharth Mathur  <siddharth.mathur@nokia.com>
2289
2290         Reviewed by Laszlo Gombos.
2291
2292         [Qt][Wk2][Symbian] Capabilities for Qt MiniBrowser and QtWebProcess on Symbian
2293         https://bugs.webkit.org/show_bug.cgi?id=59462
2294
2295         * MiniBrowser/qt/MiniBrowser.pro: Add Symbian OS capabilities to executable. Also enable data paging. 
2296
2297 2011-05-04  Eric Seidel  <eric@webkit.org>
2298
2299         Reviewed by Adam Barth.
2300
2301         The testing EWS bots should upload layout-test-results.zip to bugs after failures
2302         https://bugs.webkit.org/show_bug.cgi?id=60223
2303
2304         This required sharing a bit of code between the commit-queue
2305         (which already knew how to do this) and the new EWS testing bots.
2306
2307         In the process I also cleaned up EWS testing a little and
2308         removed some dead code from the commit-queue.
2309
2310         * Scripts/webkitpy/common/config/committervalidator.py:
2311         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2312         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2313         * Scripts/webkitpy/tool/commands/queues.py:
2314         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2315
2316 2011-05-04  James Kozianski  <koz@chromium.org>
2317
2318         Reviewed by Eric Seidel.
2319
2320         Add method to make a Port able to retrieve TestOutputSets from its builders.
2321         https://bugs.webkit.org/show_bug.cgi?id=58211
2322
2323         This will be used in the new rebaseline script - TestOutputs are
2324         potential new baselines.
2325
2326         * Scripts/webkitpy/common/config/urls.py:
2327         * Scripts/webkitpy/layout_tests/port/base.py:
2328         * Scripts/webkitpy/layout_tests/port/chromium.py:
2329         * Scripts/webkitpy/layout_tests/port/factory.py:
2330         * Scripts/webkitpy/layout_tests/port/webkit.py:
2331
2332 2011-05-04  Eric Seidel  <eric@webkit.org>
2333
2334         Reviewed by Ojan Vafai.
2335
2336         sheriff-bot can't parse results.html
2337         https://bugs.webkit.org/show_bug.cgi?id=60196
2338
2339         The problem was that the NRWT bots are currently core
2340         and so sheriff-bot was trying to diagnose failures on
2341         them.  It was trying to parse their results.html file
2342         and BeautifulSoup was throwing an exception.
2343
2344         It seems our version of BeautifulSoup was quite old
2345         and unable to handle <script> tags correctly.
2346         This moves us to 3.2 which doesn't seem to have this bug.
2347
2348         * Scripts/webkitpy/thirdparty/BeautifulSoup.py:
2349
2350 2011-05-04  Adam Barth  <abarth@webkit.org>
2351
2352         Reviewed by Eric Seidel.
2353
2354         Make the EWS test logging less verbose
2355         https://bugs.webkit.org/show_bug.cgi?id=60201
2356
2357         This should help us generate less than a hundred MB of logs per hour.
2358
2359         * Scripts/webkitpy/common/config/ports.py:
2360         * Scripts/webkitpy/common/config/ports_unittest.py:
2361
2362 2011-05-04  Tao Bai  <michaelbai@chromium.org>
2363
2364         Reviewed by David Kilzer.
2365
2366         Populate touch-icon url to FrameLoaderClient
2367         https://bugs.webkit.org/show_bug.cgi?id=59143
2368
2369         Disable touch icon by default. 
2370
2371         * Scripts/build-webkit:
2372
2373 2011-05-04  Justin Novosad  <junov@chromium.org>
2374
2375         Reviewed by Kenneth Russell.
2376
2377         [Chromium] Add gpu acceleration flags to DumpRenderTree
2378         https://bugs.webkit.org/show_bug.cgi?id=60168
2379         Adding support for command line flags 
2380         enable-accelerated-2d-canvas an
2381         enable-accelerated-drawing in DumpRenderTree.
2382
2383         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2384         (main):
2385         * DumpRenderTree/chromium/TestShell.cpp:
2386         (TestShell::TestShell):
2387         (TestShell::resetWebSettings):
2388         * DumpRenderTree/chromium/TestShell.h:
2389         (TestShell::setLegacyAccelerated2dCanvasEnabled):
2390         (TestShell::setAcceleratedDrawingEnabled):
2391         * DumpRenderTree/chromium/WebPreferences.cpp:
2392         (WebPreferences::reset):
2393         (WebPreferences::applyTo):
2394         * DumpRenderTree/chromium/WebPreferences.h:
2395
2396 2011-05-04  Ademar de Souza Reis Jr.  <ademar.reis@openbossa.org>
2397
2398         Reviewed by Csaba Osztrogonác.
2399
2400         [Qt] run-qtwebkit-tests misses exec bit
2401         https://bugs.webkit.org/show_bug.cgi?id=60188
2402
2403         Also removing an unecessary import (mostly to let this bugfix goes
2404         through the system, as this is just a chmod).
2405
2406         * Scripts/run-qtwebkit-tests:
2407
2408 2011-05-04  Adam Barth  <abarth@webkit.org>
2409
2410         Fix import of ircproxy module to actually import the module.  I don't
2411         really understand how this code could have worked before.
2412
2413         * Scripts/webkitpy/common/host.py:
2414
2415 2011-05-04  Siddharth Mathur  <siddharth.mathur@nokia.com>
2416
2417         Reviewed by Andreas Kling.
2418
2419         [Qt][Wk2][Symbian] Minor UI facelift for MiniBrowser
2420         https://bugs.webkit.org/show_bug.cgi?id=60172
2421
2422         * MiniBrowser/qt/BrowserWindow.cpp: Bring in UI layout changes from QtTestBrowser
2423         (BrowserWindow::BrowserWindow):
2424
2425 2011-05-04  Mihai Parparita  <mihaip@chromium.org>
2426
2427         Reviewed by Ojan Vafai.
2428
2429         [NRWT] --new-baseline should put baselines in the directory specified by --additional-platform-directory
2430         https://bugs.webkit.org/show_bug.cgi?id=60088
2431         
2432         Makes --new-baseline put new baselines into the first entry in the
2433         baseline search path, including any additional directories passed in via
2434         --additional-platform-directory.
2435         
2436         Simplifies baseline_path() by making it return the first entry in the
2437         baseline search path instead of requiring each port to have an
2438         implementation (should not result in any behavior change).
2439
2440         * Scripts/webkitpy/layout_tests/port/base.py:
2441         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2442         * Scripts/webkitpy/layout_tests/port/chromium.py:
2443         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2444         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2445         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2446         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2447         * Scripts/webkitpy/layout_tests/port/mac.py:
2448         * Scripts/webkitpy/layout_tests/port/test.py:
2449         * Scripts/webkitpy/layout_tests/port/webkit.py:
2450
2451 2011-05-04  Adam Barth  <abarth@webkit.org>
2452
2453         Reviewed by Eric Seidel.
2454
2455         Fix circular dependency in webkitpy
2456         https://bugs.webkit.org/show_bug.cgi?id=60075
2457
2458         These functions don't belong in bugzilla.py.  They only exist there
2459         because they are old.  Really, these functions shouldn't be free
2460         functions at all, but that's a patch for another day.
2461
2462         * Scripts/webkitpy/common/checkout/changelog.py:
2463         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2464         * Scripts/webkitpy/common/checkout/checkout.py:
2465         * Scripts/webkitpy/common/config/urls.py:
2466         * Scripts/webkitpy/common/net/bugzilla/__init__.py:
2467         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2468         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
2469         * Scripts/webkitpy/style/checkers/changelog.py:
2470         * Scripts/webkitpy/tool/bot/irc_command.py:
2471         * Scripts/webkitpy/tool/bot/sheriff.py:
2472         * Scripts/webkitpy/tool/commands/upload.py:
2473
2474 2011-05-03  Pratik Solanki  <psolanki@apple.com>
2475
2476         Reviewed by Dan Bernstein.
2477
2478         https://bugs.webkit.org/show_bug.cgi?id=60141
2479         Remove reference to libWebKitSystemInterfaceTiger.a from build-webkit
2480
2481         * Scripts/build-webkit:
2482
2483 2011-05-03  Mihai Parparita  <mihaip@chromium.org>
2484
2485         Reviewed by Ojan Vafai.
2486
2487         Update rebaseline queue server to handle hierarchical test results
2488         https://bugs.webkit.org/show_bug.cgi?id=60063
2489         
2490         Update test result parsing done by the rebaseline queue server to handle
2491         the hierarchical test result output that is generated as of r85254.
2492
2493         * RebaselineQueueServer/templates/builder-queue-edit.html:
2494
2495 2011-05-03  Eric Seidel  <eric@webkit.org>
2496
2497         Reviewed by Adam Roben.
2498
2499         webkit-patch post-commits HEAD^.. throws an exception
2500         https://bugs.webkit.org/show_bug.cgi?id=60027
2501
2502         * Scripts/webkitpy/common/checkout/scm/git.py:
2503
2504 2011-05-03  Luiz Agostini  <luiz.agostini@openbossa.org>
2505
2506         Reviewed by Kenneth Rohde Christiansen.
2507
2508         [Qt] Layout tests may timeout if loadFinished receives false
2509         https://bugs.webkit.org/show_bug.cgi?id=60064
2510
2511         When using layoutTestController.queueLoad(), if QWebPage::loadFinished(bool) receives false
2512         then the layout test may timout. It happens that QWebPage::loadFinished() receives false when
2513         a response is ignored, like it should be for 204 responses. It is a problem for creating
2514         tests for 204 responses for example.
2515
2516         This change has been tested and it causes no regressions in layout tests.
2517
2518         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2519         (LayoutTestController::maybeDump):
2520
2521 2011-05-03  Dirk Pranke  <dpranke@chromium.org>
2522
2523         Unreviewed, rolling out r85659.
2524         http://trac.webkit.org/changeset/85659
2525         https://bugs.webkit.org/show_bug.cgi?id=59977
2526
2527         restarting isn't working correctly
2528
2529         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
2530         * Scripts/webkitpy/layout_tests/port/http_server.py:
2531         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
2532         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
2533
2534 2011-05-03  Dirk Pranke  <dpranke@chromium.org>
2535
2536         Reviewed by Ojan Vafai.
2537
2538         new-run-webkit-tests: fix http server startup/shutdown
2539
2540         Previous versions of the code had three problems that made startup
2541         and shutdown flaky. The first is that it would throw exceptions
2542         if it couldn't delete stale log files, which was overly
2543         paranoid. The second is that some of the exceptions weren't
2544         defined properly. The third, and most important, is that it was
2545         using urllib to check if ports were available, which was leaving
2546         sockets in a half-closed state, and keeping ports from being
2547         reused. By switching to raw sockets, we are able to now reliably
2548         restart.
2549
2550         This change also switches the code to using Executives to stop
2551         processes, which will let us delete a bunch of code in the
2552         port/* implementations and fix a weird layering problem in a
2553         subsequent patch.
2554
2555         https://bugs.webkit.org/show_bug.cgi?id=59977
2556
2557         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
2558         * Scripts/webkitpy/layout_tests/port/http_server.py:
2559         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
2560         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
2561
2562 2011-05-03  Dirk Pranke  <dpranke@chromium.org>
2563
2564         Reviewed by Adam Barth.
2565
2566         fix failing printing_unittest on win32
2567         https://bugs.webkit.org/show_bug.cgi?id=59963
2568
2569         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2570
2571 2011-05-03  Adam Roben  <aroben@apple.com>
2572
2573         Fix most strict PassOwnPtr violations on Windows
2574
2575         Fixes <http://webkit.org/b/60025> Windows should (almost) build with strict PassOwnPtr
2576         enabled
2577
2578         Reviewed by Anders Carlsson.
2579
2580         * WebKitAPITest/Test.h: Use adoptPtr.
2581
2582 2011-05-03  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
2583
2584         Reviewed by Andreas Kling.
2585
2586         Add myself to the committers list.
2587
2588         * Scripts/webkitpy/common/config/committers.py:
2589
2590 2011-05-03  James Robinson  <jamesr@chromium.org>
2591
2592         Reviewed by Kenneth Russell.
2593
2594         [chromium] Layout test animations/3d/replace-filling-transform.html failing
2595         https://bugs.webkit.org/show_bug.cgi?id=59839
2596
2597         Add animations/3d to the list of tests run in the chromium-gpu configuration since these tests exercise the compositor.
2598
2599         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2600
2601 2011-05-03  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
2602
2603         Unreviewed, rolling out r85471.
2604         http://trac.webkit.org/changeset/85471
2605         https://bugs.webkit.org/show_bug.cgi?id=59922
2606
2607         The rule of thumb in EFL is that you init in all the places
2608         you use it. So, if in your application you call ecore_evas_*
2609         functions, you have to call ecore_evas_init() first.
2610
2611         * EWebLauncher/main.c: always call *_init() functions when you use
2612         that namespace.
2613         (quit):
2614         (main):
2615
2616 2011-05-02  Ojan Vafai  <ojan@chromium.org>
2617
2618         Reviewed by Tony Chang.
2619
2620         remove no longer used method
2621         https://bugs.webkit.org/show_bug.cgi?id=59981
2622
2623         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2624         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
2625
2626 2011-05-02  Ojan Vafai  <ojan@chromium.org>
2627
2628         Reviewed by Tony Chang.
2629
2630         add image toggling behavior from old-run-webkit-tests
2631         https://bugs.webkit.org/show_bug.cgi?id=59978
2632
2633         Output -diffs.html files. This matches old-run-webkit-tests.
2634         In theory, we could use data urls in the results.html file, but
2635         data urls don't currently have access to local files.
2636
2637         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
2638
2639 2011-05-02  Tony Chang  <tony@chromium.org>
2640
2641         Reviewed by Ojan Vafai.
2642
2643         [nrwt] remove some obsolete references to .checksum files
2644         https://bugs.webkit.org/show_bug.cgi?id=59971
2645
2646         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2647         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
2648         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2649         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
2650         * Scripts/webkitpy/layout_tests/port/test.py:
2651         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2652
2653 2011-05-02  Adam Roben  <aroben@apple.com>
2654
2655         Take advantage of implicit nullptr_t -> PassOwnPtr conversion
2656
2657         Fixes <http://webkit.org/b/59964> Implicit conversion from std::nullptr_t to PassOwnPtr
2658         doesn't work, but should
2659
2660         Reviewed by Adam Barth.
2661
2662         * DumpRenderTree/chromium/CppBoundClass.h:
2663         * DumpRenderTree/chromium/WebViewHost.cpp:
2664
2665 2011-05-02  Martin Robinson  <mrobinson@igalia.com>
2666
2667         Reviewed by Xan Lopez.
2668
2669         [GTK] Compiler warning in Tools/MiniBrowser/main.c
2670         https://bugs.webkit.org/show_bug.cgi?id=59986
2671
2672         Remove a compiler warning.
2673
2674         * MiniBrowser/gtk/main.c: Use full array initializers to prevent some compilers
2675         from complaining.
2676
2677 2011-05-02  Adam Barth  <abarth@webkit.org>
2678
2679         Reviewed by Eric Seidel.
2680
2681         Add runtests_unittest.py
2682         https://bugs.webkit.org/show_bug.cgi?id=59955
2683
2684         I forgot to add this file in a previous patch.
2685
2686         * Scripts/webkitpy/tool/steps/runtests_unittest.py: Added.
2687
2688 2011-05-02  Adam Barth  <abarth@webkit.org>
2689
2690         Change the testing EWS to log failures explicitly to avoid an infinite loop.
2691
2692         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2693
2694 2011-05-02  Adrienne Walker  <enne@google.com>
2695
2696         Unreviewed, fix misspelled contributor name.
2697
2698         * Scripts/webkitpy/common/config/committers.py:
2699
2700 2011-05-02  Adam Barth  <abarth@webkit.org>
2701
2702         Reviewed by Eric Seidel.
2703
2704         cr-linux-ews should run tests
2705         https://bugs.webkit.org/show_bug.cgi?id=59272
2706
2707         This patch turns on testing for the cr-linux-ews.  Yay!
2708
2709         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
2710         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2711         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2712         * Scripts/webkitpy/tool/steps/runtests.py:
2713         * Scripts/webkitpy/tool/steps/steps_unittest.py:
2714
2715 2011-05-02  Martin Robinson  <mrobinson@igalia.com>
2716
2717         Incorporate a review comment that I mistakenly omitted from my last commit.
2718
2719         * DumpRenderTree/gtk/EventSender.cpp: Use unsigned here instead of unsigned int.
2720
2721 2011-05-02  Adam Barth  <abarth@webkit.org>
2722
2723         Reviewed by Eric Seidel.
2724
2725         EWS should report the list of unexpected failures
2726         https://bugs.webkit.org/show_bug.cgi?id=59923
2727
2728         We cache the results of the first layout test results run on the task
2729         so the EWS can grab them later.  Another option is to include them in
2730         the exception that's thrown, but this approach seemed slightly more
2731         aesthetic.
2732
2733         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2734         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
2735
2736 2011-05-02  Adam Barth  <abarth@webkit.org>
2737
2738         Reviewed by Eric Seidel.
2739
2740         Add base case for a test-running EWS
2741         https://bugs.webkit.org/show_bug.cgi?id=59920
2742
2743         Later I will subclass this to run the Chromium Linux EWS.
2744
2745         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py: Added.
2746         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2747         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2748
2749 2011-05-02  Anders Carlsson  <andersca@apple.com>
2750
2751         Build fix.
2752
2753         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2754         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2755
2756 2011-05-02  Nico Weber  <thakis@chromium.org>
2757
2758         Reviewed by Mihai Parparita.
2759
2760         Add --no-webkit2 to the output of "build-webkit -h"
2761         https://bugs.webkit.org/show_bug.cgi?id=59942
2762
2763         * Scripts/build-webkit:
2764
2765 2011-05-02  Martin Robinson  <mrobinson@igalia.com>
2766
2767         Reviewed by Xan Lopez.
2768
2769         [GTK] old-run-webkit-tests should disable the Ubuntu overlay scrollbar
2770         https://bugs.webkit.org/show_bug.cgi?id=59943
2771
2772         Disable the Ubuntu overlay scrollbar while testing, by injecting the
2773         LIBOVERLAY_SCROLLBAR=0 environment variable.
2774
2775         * Scripts/old-run-webkit-tests:
2776
2777 2011-05-02  Martin Robinson  <mrobinson@igalia.com>
2778
2779         Reviewed by Eric Seidel.
2780
2781         [GTK] editing/selection/select-out-of-editable.html failing after r83967
2782         https://bugs.webkit.org/show_bug.cgi?id=58667
2783
2784         Do not trigger mouse down events when the EventSender knows that a mouse button is
2785         already down. These type of situations can confuse Xvfb and cause dragging failures.
2786
2787         * DumpRenderTree/gtk/EventSender.cpp:
2788         (mouseDownCallback): Do not trigger another mouse button down event if the mouse button
2789         is already down. This can interfere with drags in Xvfb.
2790
2791 2011-05-02  Zsolt Fehér  <h490267@stud.u-szeged.hu>
2792
2793         Reviewed by Csaba Osztrogonác.
2794
2795         DRT sideeffect revealed by r71268.
2796         https://bugs.webkit.org/show_bug.cgi?id=48958
2797
2798         Reset QWebSettings::ZoomTextOnly attribute before all tests. 
2799
2800         Call setTextSizeMultiplier(1.0) to reset TextZoomFactor and 
2801         PageZoomFactor too. It should be done before resetsettings() 
2802         to guarantee resetting QWebSettings::ZoomTextOnly correctly.
2803
2804         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2805         (WebCore::WebPage::resetSettings):
2806         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2807
2808 2011-05-02  Sheriff Bot  <webkit.review.bot@gmail.com>
2809
2810         Unreviewed, rolling out r85469.
2811         http://trac.webkit.org/changeset/85469
2812         https://bugs.webkit.org/show_bug.cgi?id=59928
2813
2814         Broke  webkitpy-tests on Windows 7, GTK and Qt. (Requested by
2815         bbandix on #webkit).
2816
2817         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py: Removed.
2818         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2819         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2820
2821 2011-05-02  Tomasz Morawski  <t.morawski@samsung.com>
2822
2823         Reviewed by Kenneth Rohde Christiansen.
2824
2825         Cleanup EFL initialization/shutdown in the EWebLauncher
2826         https://bugs.webkit.org/show_bug.cgi?id=59922
2827
2828         Removed ecore_evas_init and edje_init form main function due to they
2829         are also called in the ewk_init. Moved ewk_shutdown to quit function.
2830
2831         * EWebLauncher/main.c:
2832         (quit):
2833         (main):
2834
2835 2011-05-02  Adam Barth  <abarth@webkit.org>
2836
2837         Reviewed by Eric Seidel.
2838
2839         Add base case for a test-running EWS
2840         https://bugs.webkit.org/show_bug.cgi?id=59920
2841
2842         Later I will subclass this to run the Chromium Linux EWS.
2843
2844         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py: Added.
2845         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2846         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2847
2848 2011-05-02  Adam Barth  <abarth@webkit.org>
2849
2850         Reviewed by Eric Seidel.
2851
2852         Add the ability to skip python and perl unit tests on EC2
2853         https://bugs.webkit.org/show_bug.cgi?id=59918
2854
2855         * Scripts/webkitpy/common/config/ports.py:
2856             - This is slightly ugly, but it's useful...
2857         * Scripts/webkitpy/common/config/ports_unittest.py:
2858         * Scripts/webkitpy/tool/mocktool.py:
2859         * Scripts/webkitpy/tool/steps/runtests.py:
2860
2861 2011-05-02  Adam Barth  <abarth@webkit.org>
2862
2863         Reviewed by Eric Seidel.
2864
2865         webkit-patch --non-interactive is incompatible with new-run-webkit-tests
2866         https://bugs.webkit.org/show_bug.cgi?id=59919
2867
2868         new-run-webkit-tests doesn't support --wait-for-httpd (because it
2869         always waits for HTTPD, as I understand things).  It turns out we're
2870         not really using this flag for anything, so we should just remove it.
2871
2872         * Scripts/webkitpy/tool/steps/runtests.py:
2873         * Scripts/webkitpy/tool/steps/steps_unittest.py:
2874
2875 2011-05-01  Eric Seidel  <eric@webkit.org>
2876
2877         Reviewed by Adam Barth.
2878
2879         The bots should learn from expected failures without having to retry
2880         https://bugs.webkit.org/show_bug.cgi?id=59279
2881
2882         Rather than re-trying the whole patch, we can just check whether we now
2883         expect the failures we see with the patch applied, saving a lot of time.
2884
2885         This patch also teaches the CommitQueue how to reject patches even
2886         when the tree is red using the new unexpected_failures() method on
2887         ExpectedFailures.
2888
2889         Finally in testing we found a bug in ExpectedFailures where it would
2890         "trust" results which had many many failures, due to using an
2891         equal sign instead of a less-than sign.
2892
2893         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py
2894         * Scripts/webkitpy/tool/bot/expectedfailures.py
2895         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py
2896         * Scripts/webkitpy/tool/bot/patchanalysistask.py
2897
2898
2899 2011-05-02  Adam Barth  <abarth@webkit.org>
2900
2901         Reviewed by Eric Seidel.
2902
2903         workspace.py fails to import ScriptError
2904         https://bugs.webkit.org/show_bug.cgi?id=59915
2905
2906         If the workspace fails to create a zip, webkitpy crashes instead of
2907         handling the error as expected.
2908
2909         * Scripts/webkitpy/common/system/workspace.py:
2910         * Scripts/webkitpy/common/system/workspace_unittest.py:
2911         * Scripts/webkitpy/tool/mocktool.py:
2912
2913 2011-05-01  Adam Barth  <abarth@webkit.org>
2914
2915         Remove unadvertantly added file.
2916
2917         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2918
2919 2011-05-01  Adam Barth  <abarth@webkit.org>
2920
2921         Reviewed by Eric Seidel.
2922
2923         expectedfailures.py should report the unexpected failures when asked
2924         https://bugs.webkit.org/show_bug.cgi?id=59916
2925
2926         This information is useful when the EWS runs tests.
2927
2928         * Scripts/webkitpy/tool/bot/expectedfailures.py:
2929         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py:
2930
2931 2011-05-01  Adam Barth  <abarth@webkit.org>
2932
2933         Reviewed by Eric Seidel.
2934
2935         JSONTestResult needs to handle multiple results
2936         https://bugs.webkit.org/show_bug.cgi?id=59269
2937
2938         This case occurs when a test is flaky because NRWT will run the test
2939         twice and report both results as "actual."
2940
2941         * Scripts/webkitpy/common/net/resultsjsonparser.py:
2942         * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
2943
2944 2011-05-01  Adam Barth  <abarth@webkit.org>
2945
2946         Reviewed by Eric Seidel.
2947
2948         Move checkout/api.py to checkout/checkout.py
2949         https://bugs.webkit.org/show_bug.cgi?id=59906
2950
2951         This is more consistent with Python style.
2952
2953         * Scripts/webkitpy/common/checkout/__init__.py:
2954         * Scripts/webkitpy/common/checkout/scm_unittest.py:
2955         * Scripts/webkitpy/common/host.py:
2956         * Scripts/webkitpy/tool/main.py:
2957
2958 2011-05-01  Eric Seidel  <eric@webkit.org>
2959
2960         Reviewed by Adam Barth.
2961
2962         scm.py should be split into many pieces
2963         https://bugs.webkit.org/show_bug.cgi?id=59908
2964
2965         Forgot an AuthenticationError import.
2966
2967         * Scripts/webkitpy/common/checkout/scm/git.py:
2968         * Scripts/webkitpy/common/checkout/scm/svn.py:
2969
2970 2011-05-01  Arno Renevier  <arno@renevier.net>
2971
2972         Reviewed by Eric Seidel.
2973
2974         wrong exception raised in Lighttpd start method
2975         https://bugs.webkit.org/show_bug.cgi?id=59283
2976
2977         raise standard Exception instead of non existent
2978         google.httpd_utils.HttpdNotStarted
2979
2980         * Scripts/webkitpy/layout_tests/port/http_server.py:
2981
2982 2011-05-01  Eric Seidel  <eric@webkit.org>
2983
2984         Reviewed by Adam Barth.
2985
2986         scm.py should be split into many pieces
2987         https://bugs.webkit.org/show_bug.cgi?id=59908
2988
2989         * Scripts/webkitpy/common/checkout/scm/__init__.py:
2990         * Scripts/webkitpy/common/checkout/scm/commitmessage.py: Added.
2991         * Scripts/webkitpy/common/checkout/scm/git.py: Added.
2992         * Scripts/webkitpy/common/checkout/scm/scm.py:
2993         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2994         * Scripts/webkitpy/common/checkout/scm/svn.py: Added.
2995
2996 2011-05-01  Eric Seidel  <eric@webkit.org>
2997
2998         Reviewed by Adam Barth.
2999
3000         Make most scm.py tests pass in preparation for splitting them up
3001         https://bugs.webkit.org/show_bug.cgi?id=59904
3002
3003         There is one remaining failure:
3004         webkitpy.common.checkout.scm.scm_unittest.GitTestWithMock.test_create_patch
3005         which identifies a difference between the SVN and Git versions of the
3006         SCM api.  I'm not going to bother fixing that until we split out all
3007         the tests.
3008
3009         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3010
3011 2011-05-01  Patrick Gansterer  <paroga@webkit.org>
3012
3013         [WIN] Unreviewed buildfix after r85440.
3014
3015         * DumpRenderTree/win/UIDelegate.cpp:
3016         (UIDelegate::UIDelegate): Removed accidental added adoptPtr.
3017
3018 2011-05-01  Patrick Gansterer  <paroga@webkit.org>
3019
3020         [WIN] Unreviewed buildfix after r85434.
3021
3022         * DumpRenderTree/win/FrameLoadDelegate.cpp: Added missing header.
3023         * DumpRenderTree/win/UIDelegate.cpp: Ditto.
3024
3025 2011-05-01  Patrick Gansterer  <paroga@webkit.org>
3026
3027         [WIN] Unreviewed buildfix after r85434.
3028
3029         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3030         (FrameLoadDelegate::FrameLoadDelegate):
3031         * DumpRenderTree/win/UIDelegate.cpp:
3032         (DRTUndoManager::DRTUndoManager):
3033         (UIDelegate::UIDelegate):
3034         (UIDelegate::resetUndoManager):
3035
3036 2011-05-01  Eric Seidel  <eric@webkit.org>
3037
3038         Reviewed by Adam Barth.
3039
3040         Move scm.py into its own module in preparation for splitting it up
3041         https://bugs.webkit.org/show_bug.cgi?id=59884
3042
3043         * Scripts/webkitpy/common/checkout/scm/__init__.py: Added.
3044         * Scripts/webkitpy/common/checkout/scm/scm.py: Moved.
3045         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py: Moved.
3046         * Scripts/webkitpy/test/main.py:
3047
3048 2011-05-01  Adam Barth  <abarth@webkit.org>
3049
3050         Reviewed by Eric Seidel.
3051
3052         webkit-patch fails when not run from root
3053         https://bugs.webkit.org/show_bug.cgi?id=59882
3054
3055         We need to set the CWD when running svn so that svn interprets file
3056         paths relative to the root of the working copy.
3057
3058         * Scripts/webkitpy/common/checkout/scm.py:
3059
3060 2011-04-29  Eric Seidel  <eric@webkit.org>
3061
3062         Reviewed by Adam Barth.
3063
3064         land-safely patches should show show their place in the commit-queue
3065         https://bugs.webkit.org/show_bug.cgi?id=59853
3066
3067         This complicated the "should we show the bubbles or the submit-to-ews button"
3068         logic substantially. :(  But now we'll show both the commit-queue position
3069         as well as the submit-to-ews button for land-safely (cq+ only) patches.
3070         Previously we would only show the submit-to-ews button.
3071
3072         * QueueStatusServer/handlers/statusbubble.py:
3073         * QueueStatusServer/templates/statusbubble.html:
3074
3075 2011-04-29  Naoki Takano  <takano.naoki@gmail.com>
3076
3077         Reviewed by Adam Barth.
3078
3079         Add my name to contributers.
3080         https://bugs.webkit.org/show_bug.cgi?id=59854
3081
3082         * Scripts/webkitpy/common/config/committers.py:
3083
3084 2011-04-29  Keith Kyzivat  <keith.kyzivat@nokia.com>
3085
3086         Reviewed by Csaba Osztrogonác.
3087
3088         [Qt] Don't build TestNetscapePlugin if ENABLE_NETSCAPE_PLUGIN_API=0
3089         https://bugs.webkit.org/show_bug.cgi?id=59772
3090
3091         * Tools.pro:
3092
3093 2011-04-29  Stephanie Lewis  <slewis@apple.com>
3094
3095         Rubber-stamped by Adam Roben.   
3096
3097         Remove the production configuration guard since installs only happen in production anyway.  
3098         Works around a bug in Xcode
3099
3100         * DumpRenderTree/mac/PerlSupport/Makefile:
3101
3102 2011-04-29  Adam Roben  <aroben@apple.com>
3103
3104         Remove a PHP setting that is now provided by httpd.conf
3105
3106         r85155 added this setting, but putting it in httpd.conf makes more sense (since the setting
3107         isn't dependent on paths that could be different on each user's machine).
3108
3109         Reviewed by Sam Weinig.
3110
3111         * Scripts/webkitperl/httpd.pm:
3112         (getDefaultConfigForTestDirectory): Removed log_errors setting.
3113
3114 2011-04-29  Jon Lee  <jonlee@apple.com>
3115
3116         Unreviewed, Adding Jon Lee as a committer
3117
3118         * Scripts/webkitpy/common/config/committers.py:
3119
3120 2011-04-28  Ojan Vafai  <ojan@chromium.org>
3121
3122         Reviewed by Tony Chang.
3123
3124         fix pretty_patch_available and wdiff_available
3125         https://bugs.webkit.org/show_bug.cgi?id=59761
3126
3127         These methods rely on the check_* method being called first.
3128         This would only happen when we actually tried to compute a diff,
3129         but computing the diff happens on a different process.
3130         
3131         Also fix setting _wdiff_avialable to True by default.
3132
3133         * Scripts/webkitpy/layout_tests/port/base.py:
3134         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3135         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
3136
3137 2011-04-29  Ojan Vafai  <ojan@chromium.org>
3138
3139         Reviewed by Eric Seidel.
3140
3141         exclude skipped tests from the summarized results
3142         https://bugs.webkit.org/show_bug.cgi?id=59813
3143
3144         If we find a need fo skipped tests later, we should either create
3145         a skipped.json file or expose this some other way. As it is, the data
3146         is unused and is hugely bloating the size of full_results.json.
3147
3148         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
3149
3150 2011-04-29  Adam Roben  <aroben@apple.com>
3151
3152         Make DumpRenderTreeSupport get installed when the default configuration is built
3153
3154         The default configuration is Production, but in that case the CONFIGURATION environment
3155         variable is set to the empty string.
3156
3157         Reviewed by Sam Weinig.
3158
3159         * DumpRenderTree/mac/PerlSupport/Makefile: Set CONFIGURATION to Production if it isn't
3160         already set so that later logic that depends on CONFIGURATION having that value will work.
3161
3162 2011-04-29  Dean Jackson  <dino@apple.com>
3163
3164         Reviewed by Simon Fraser.
3165
3166         Add ENABLE macro for WebKitAnimation
3167         https://bugs.webkit.org/show_bug.cgi?id=59729
3168
3169         Add new feature to toggle WebKit Animation API.
3170
3171         * Scripts/build-webkit:
3172
3173 2011-04-29  Sam Weinig  <sam@webkit.org>
3174
3175         Reviewed by Adam Roben.
3176
3177         Make production the default build type for WebKitTestRunner, matching
3178         all other projects.
3179
3180         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3181
3182 2011-04-29  Kevin Ollivier  <kevino@theolliviers.com>
3183
3184         [wx] Unreviewed build fix, add new directory to the build.
3185
3186         * waf/build/settings.py:
3187
3188 2011-04-29  Carlos Garcia Campos  <cgarcia@igalia.com>
3189
3190         Reviewed by Martin Robinson.
3191
3192         [GTK] Implement UI client in minibrowser
3193         https://bugs.webkit.org/show_bug.cgi?id=58416
3194
3195         It also allows to open more than one minibrowser window from the
3196         command line.
3197
3198         * MiniBrowser/gtk/BrowserWindow.c:
3199         (browserWindowFinalize):
3200         (browser_window_init):
3201         (browserWindowConstructed):
3202         (createNewPage):
3203         (showPage):
3204         (closePage):
3205         (runJavaScriptAlert):
3206         (browserWindowUIClientInit):
3207         * MiniBrowser/gtk/main.c:
3208         (loadURI):
3209         (main):
3210
3211 2011-04-29  Carlos Garcia Campos  <cgarcia@igalia.com>
3212
3213         Reviewed by Martin Robinson.
3214
3215         [GTK] Implement page loader client in MiniBrowser
3216         https://bugs.webkit.org/show_bug.cgi?id=58024
3217
3218         A new class BrowserWindow has been added to implement the page
3219         loader client. It makes supporting multiple windows easier. Window
3220         title and url entry are now updated during the loading process.
3221
3222         * MiniBrowser/gtk/BrowserWindow.c: Added.
3223         (activateUriEntryCallback):
3224         (goBackCallback):
3225         (goForwardCallback):
3226         (browserWindowFinalize):
3227         (browserWindowGetProperty):
3228         (browserWindowSetProperty):
3229         (browser_window_init):
3230         (browserWindowConstructed):
3231         (browser_window_class_init):
3232         (browserWindowUpdateTitle):
3233         (browserWindowSetTitle):
3234         (browserWindowSetLoadProgress):
3235         (browserWindowUpdateURL):
3236         (didStartProvisionalLoadForFrame):
3237         (didReceiveServerRedirectForProvisionalLoadForFrame):
3238         (didFailProvisionalLoadWithErrorForFrame):
3239         (didCommitLoadForFrame):
3240         (didFinishDocumentLoadForFrame):
3241         (didFinishLoadForFrame):
3242         (didFailLoadWithErrorForFrame):
3243         (didReceiveTitleForFrame):
3244         (didFirstLayoutForFrame):
3245         (didFirstVisuallyNonEmptyLayoutForFrame):
3246         (didRemoveFrameFromHierarchy):
3247         (didStartProgress):
3248         (didChangeProgress):
3249         (didFinishProgress):
3250         (didBecomeUnresponsive):
3251         (didBecomeResponsive):
3252         (browserWindowLoaderClientInit):
3253         (browser_window_new):
3254         (browser_window_get_view):
3255         * MiniBrowser/gtk/BrowserWindow.h: Added.
3256         * MiniBrowser/gtk/GNUmakefile.am:
3257         * MiniBrowser/gtk/main.c:
3258         (createWindow):
3259
3260 2011-04-28  Stephanie Lewis  <slewis@apple.com>
3261
3262         Reviewed by Mark Rowe.
3263
3264         http://bugs.webkit.org/show_bug.cgi?id=59743
3265         <rdar://problem/9040413> Add an install target for production builds.
3266
3267         * DumpRenderTree/mac/PerlSupport/Makefile:
3268
3269 2011-04-28  Adam Roben  <aroben@apple.com>
3270
3271         Stop and restart ATSServer before each test run on Leopard
3272
3273         This is to work around an ATSServer leak that eventually causes tests
3274         to fail.
3275
3276         Fixes <http://webkit.org/b/51807> <rdar://problem/9273894>
3277         fast/blockflow/broken-ideograph-[small-caps|font].html sometimes fails on Leopard buildbots
3278         (due to ATSServer leak)
3279
3280         Reviewed by Dan Bernstein.
3281
3282         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3283         (StopATSServer):
3284         (StartATSServer):
3285         Added these new commands to stop and start ATSServer.
3286
3287         (TestFactory.__init__): Stop and start ATSServer on Leopard before running tests.
3288
3289 2011-04-28  Dirk Pranke  <dpranke@chromium.org>
3290
3291         Reviewed by Adam Roben.
3292
3293         add Leopard NRWT bot to the scheduler
3294         https://bugs.webkit.org/show_bug.cgi?id=59766
3295
3296         * BuildSlaveSupport/build.webkit.org-config/config.json:
3297
3298 2011-04-28  Sam Weinig  <sam@webkit.org>
3299
3300         Fix WebKitTestRunner build.
3301
3302         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3303         The Derived Sources target needs a product name.
3304
3305 2011-04-28  Sam Weinig  <sam@webkit.org>
3306
3307         Reviewed by Mark Rowe.
3308
3309         Add install support for WebKitTestRunner.
3310         <rdar://problem/9349055>
3311
3312         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3313         Add missing CompilerVersion.xcconfig.
3314
3315         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
3316         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
3317         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3318         Add install path and tell it not to skip installation.
3319
3320         Add missing CompilerVersion.xcconfig.
3321
3322 2011-04-28  David Levin  <levin@chromium.org>
3323
3324         Reviewed by Adam Barth.
3325
3326         Remove IMAGE_RESIZER related code.
3327         https://bugs.webkit.org/show_bug.cgi?id=59735
3328
3329         * Scripts/build-webkit:
3330
3331 2011-04-28  Sam Weinig  <sam@webkit.org>
3332
3333         Reviewed by Adam Roben.
3334
3335         Make reading skipped files from additional platform
3336         directories work in WebKit2 mode.
3337
3338         * Scripts/old-run-webkit-tests:
3339         (buildPlatformTestHierarchy): Simplify logic to always use the first
3340         and last platforms in the build hierarchy as the test hierarchy, and to
3341         insert the WebKit2 platform in the middle if it exists. Yum.
3342
3343 2011-04-28  Adam Barth  <abarth@webkit.org>
3344
3345         Reviewed by Eric Seidel.
3346
3347         Remove WML
3348         https://bugs.webkit.org/show_bug.cgi?id=59678
3349
3350         Remove build system integration and test harness integration for WML.
3351
3352         * Scripts/build-webkit:
3353         * Scripts/old-run-webkit-tests:
3354         * Scripts/webkitperl/features.pm:
3355         * Scripts/webkitpy/layout_tests/port/webkit.py:
3356         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3357
3358 2011-04-28  Ojan Vafai  <ojan@chromium.org>
3359
3360         Reviewed by Mihai Parparita.
3361
3362         use a hierarchical data structure to store results json
3363         https://bugs.webkit.org/show_bug.cgi?id=59736
3364
3365         Instead of a map from test name to results dict, we now store a hierarchical
3366         data structure.
3367
3368         Old: { foo/bar/baz.html: results_dict, foo/bar/baz2.html: results_dict }
3369         New:
3370         { foo: {
3371             bar: {
3372               baz.html: results_dict,
3373               baz2.html: results_dict } } }
3374
3375         This cut ~52% of the size of times_ms.json. I expect it will cut
3376         30-40% of full_results.json and unexpected_results.json.
3377
3378         * Scripts/webkitpy/common/net/resultsjsonparser.py:
3379         * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
3380         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3381         Using os.sep was just wrong since relative_test_filename canonicalizes separators.
3382         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
3383         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
3384         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3385         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
3386         Instead of plumbing through the change to all of the rebaselineserver
3387         python and JS, just convert to the old format after reading in the json.
3388
3389 2011-04-28  Eric Seidel  <eric@webkit.org>
3390
3391         Reviewed by Adam Barth.
3392
3393         EWS Bubbles should show commit-queue position when patch is in the commit-queue
3394         https://bugs.webkit.org/show_bug.cgi?id=59744
3395
3396         Add target="_top" to the bubble links.  This was
3397         forgotten when I moved from using an onclick to a normal link.
3398
3399         * QueueStatusServer/templates/statusbubble.html:
3400
3401 2011-04-28  Eric Seidel  <eric@webkit.org>
3402
3403         Reviewed by Adam Barth.
3404
3405         EWS bubbles should show "submit to ews" button if they've not been processed
3406         https://bugs.webkit.org/show_bug.cgi?id=59751
3407
3408         * QueueStatusServer/handlers/statusbubble.py:
3409         * QueueStatusServer/handlers/submittoews.py:
3410         * QueueStatusServer/templates/statusbubble.html:
3411         * QueueStatusServer/templates/submittoews.html:
3412
3413 2011-04-28  Eric Seidel  <eric@webkit.org>
3414
3415         Reviewed by Adam Barth.
3416
3417         EWS Bubbles should show commit-queue position when patch is in the commit-queue
3418         https://bugs.webkit.org/show_bug.cgi?id=59744
3419
3420         This was actually just a 2 line change to statusbubble.py.
3421         I also cleaned up statusbubble.html a little while I was there
3422         (the links are now actual <a> tags and have hover).
3423
3424         * QueueStatusServer/handlers/statusbubble.py:
3425         * QueueStatusServer/templates/statusbubble.html:
3426
3427 2011-04-28  Dirk Pranke  <dpranke@chromium.org>
3428
3429         Reviewed by Eric Seidel.
3430
3431         add a mac leopard release NRWT bot
3432         https://bugs.webkit.org/show_bug.cgi?id=59733
3433
3434         * BuildSlaveSupport/build.webkit.org-config/config.json:
3435
3436 2011-04-28  Ojan Vafai  <ojan@chromium.org>
3437
3438         Avoid crashing when running new-run-webkit-tests outside of
3439         version control.
3440
3441         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
3442
3443 2011-04-28  Xan Lopez  <xlopez@igalia.com>
3444
3445         Unreviewed build fix.
3446
3447         * GNUmakefile.am:
3448
3449 2011-04-28  Ojan Vafai  <ojan@chromium.org>
3450
3451         Reviewed by Eric Seidel.
3452
3453         fix python printing test
3454         https://bugs.webkit.org/show_bug.cgi?id=59719
3455
3456         Now that we run scm commands in summarize_results, --verbose prints
3457         debug logging to stderr.
3458
3459         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3460
3461 2011-04-28  Ojan Vafai  <ojan@chromium.org>
3462
3463         Reviewed by Tony Chang.
3464
3465         link to tests at a specific revision in the results.html file
3466         https://bugs.webkit.org/show_bug.cgi?id=59711
3467
3468         * Scripts/webkitpy/common/checkout/scm.py:
3469         Add a method to get the head svn revision.
3470         * Scripts/webkitpy/common/checkout/scm_unittest.py:
3471         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
3472         Include the svn revision in the results json.
3473
3474 2011-04-28  Carlos Garcia Campos  <cgarcia@igalia.com>
3475
3476         Reviewed by Sam Weinig.
3477
3478         [GTK] Remove WKURLCreateWithURL()
3479         https://bugs.webkit.org/show_bug.cgi?id=59691
3480
3481         Use WKURLCreateWithUTF8CString() instead of WKURLCreateWithURL().
3482
3483         * MiniBrowser/gtk/main.c:
3484         (activateUriEntryCallback):
3485         (main):
3486
3487 2011-04-28  Carlos Garcia Campos  <cgarcia@igalia.com>
3488
3489         Reviewed by Martin Robinson.
3490
3491         [GTK] WKView should be a GtkWidget
3492         https://bugs.webkit.org/show_bug.cgi?id=59603
3493
3494         Don't use WKViewGetWindow(), use WKView as a GtkWidget instead.
3495
3496         * MiniBrowser/gtk/main.c:
3497         (createWindow):
3498         (main):
3499
3500 2011-04-28  Gabor Rapcsanyi  <rgabor@webkit.org>
3501
3502         Reviewed by Csaba Osztrogonác.
3503
3504         [Qt] Add ARM specific Skipped list
3505         https://bugs.webkit.org/show_bug.cgi?id=59680
3506
3507         * Scripts/old-run-webkit-tests:
3508         * Scripts/webkitdirs.pm:
3509
3510 2011-04-27  Eric Seidel  <eric@webkit.org>
3511
3512         Reviewed by Adam Barth.
3513
3514         error_log.txt should include PHP errors
3515         https://bugs.webkit.org/show_bug.cgi?id=59643
3516
3517         Turns out this was really easy after I finally learned
3518         enough about PHP to do it...
3519
3520         I'm adding this in hopes of better tracking down
3521         our random http failures.
3522
3523         * Scripts/webkitperl/httpd.pm:
3524
3525 2011-04-27  David Levin  <levin@chromium.org>
3526
3527         Reviewed by Adam Barth.
3528
3529         check-webkit-style should flags spacing errors for braces on the same line.
3530         https://bugs.webkit.org/show_bug.cgi?id=59665
3531
3532         * Scripts/webkitpy/style/checkers/cpp.py: Added the check.
3533         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added some tests for the check
3534           and fixed some test cases to not trigger this error since it isn't what they are verifying.
3535
3536 2011-04-27  David Levin  <levin@chromium.org>
3537
3538         Reviewed by Adam Barth.
3539
3540         check-webkit-style error for spaces after periods in a comment has a bad error
3541         message and warns about end of line spaces.
3542         https://bugs.webkit.org/show_bug.cgi?id=59663
3543
3544         * Scripts/webkitpy/style/checkers/cpp.py: Fix both issues.
3545         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests for spaces at the end of line
3546         and changed the error messages.
3547
3548 2011-04-27  Ojan Vafai  <ojan@chromium.org>
3549
3550         remove assertion now that platform/mac-tiger no longer exists
3551         https://bugs.webkit.org/show_bug.cgi?id=59660
3552
3553         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3554
3555 2011-04-27  Ojan Vafai  <ojan@chromium.org>
3556
3557         Reviewed by Eric Seidel.
3558
3559         remove test that didn't make sense
3560         https://bugs.webkit.org/show_bug.cgi?id=59658
3561
3562         It was artifically saying the test wasn't expected to pass,
3563         but the expectations string was empty. The case of unexpected
3564         passes with a real expectations string is tested later in the
3565         same test.
3566
3567         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3568
3569 2011-04-27  Sam Weinig  <sam@webkit.org>
3570
3571         Reviewed by Adam Roben.
3572
3573         WebKit2 needs to notify the client when a plugin fails to initialize
3574         https://bugs.webkit.org/show_bug.cgi?id=59657
3575
3576         * MiniBrowser/mac/BrowserWindowController.m:
3577         (-[BrowserWindowController awakeFromNib]):
3578         * WebKitTestRunner/TestController.cpp:
3579         (WTR::TestController::initialize):
3580         Add stubs.
3581
3582 2011-04-26  Sam Weinig  <sam@webkit.org>
3583
3584         Reviewed by David Levin.
3585
3586         Add a few more missing options to new-run-webkit-tests
3587         https://bugs.webkit.org/show_bug.cgi?id=59567
3588
3589         Add support for:
3590             --threaded
3591             --gc-between-tests
3592             --complex-text
3593
3594         * Scripts/webkitpy/layout_tests/port/webkit.py:
3595         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3596         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3597
3598 2011-04-27  Mark Rowe  <mrowe@apple.com>
3599
3600         Build fix.
3601
3602         Fix an OwnPtr-related issue that was missed before the strictness was turned on.
3603         
3604         * WebKitTestRunner/TestController.cpp:
3605         (WTR::TestController::runTest):
3606
3607 2011-04-27  Ojan Vafai  <ojan@chromium.org>
3608
3609         Forgot to upload the new times_ms.json file after splitting
3610         it out from full_results.json.
3611
3612         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
3613
3614 2011-04-27  Ojan Vafai  <ojan@chromium.org>
3615
3616         Fix snafu in generating the JSON for the chromium tests.
3617
3618         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3619
3620 2011-04-27  Ojan Vafai  <ojan@chromium.org>
3621
3622         Fix bad merge. This broke the chromium tests generating JSON files.
3623         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3624
3625 2011-04-27  Mark Rowe  <mrowe@apple.com>
3626
3627         Rubber-stamped by Geoff Garen.
3628
3629         Don't look for results in a location that no longer exists.
3630
3631         * Scripts/old-run-webkit-tests:
3632
3633 2011-04-27  Adrienne Walker  <enne@google.com>
3634
3635         Unreviewed, add Chrome GPU folks to contributors that I'm tired of manually CCing
3636
3637         * Scripts/webkitpy/common/config/committers.py:
3638
3639 2011-04-22  Ojan Vafai  <ojan@chromium.org>
3640
3641         Reviewed by Tony Chang.
3642
3643         only include failures in full_results.json
3644         https://bugs.webkit.org/show_bug.cgi?id=59256
3645
3646         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
3647
3648 2011-04-22  Ojan Vafai  <ojan@chromium.org>
3649
3650         Reviewed by Adam Roben.
3651
3652         move times into their own json file
3653         https://bugs.webkit.org/show_bug.cgi?id=59239
3654
3655         The test runtimes are the only case where we need an entry for
3656         every test that was run, including passing tests. Move them into
3657         their own json file so we can prune the other json files to only
3658         include failing tests.
3659
3660         Use a trie-like data structure to hold the tests to avoid including
3661         full test paths. This cuts 52% of the filesize. The end result is ~700k
3662         pre-gzip.
3663
3664         * Scripts/webkitpy/common/net/resultsjsonparser.py:
3665         Exclude times from the parsed TestResults.
3666         * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
3667         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3668         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
3669         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
3670
3671 2011-04-27  Anders Carlsson  <andersca@apple.com>
3672
3673         More casts and more clang++ build fixes.
3674
3675         * DumpRenderTree/mac/DumpRenderTree.mm:
3676         (createWebViewAndOffscreenWindow):
3677         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3678         (TestWebKitAPI::PlatformWebView::PlatformWebView):
3679         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3680         (WTR::PlatformWebView::PlatformWebView):
3681
3682 2011-04-27  Tony Chang  <tony@chromium.org>
3683
3684         Reviewed by Ojan Vafai.
3685
3686         lazily autoinstall thirdparty python libraries
3687         https://bugs.webkit.org/show_bug.cgi?id=55723
3688
3689         This helps by only having pywebsocket installed when the bots run.  It
3690         doesn't help much for devs since webkit-patch pulls in almost everything.
3691
3692         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3693         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
3694         * Scripts/webkitpy/common/net/networktransaction.py:
3695         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
3696         * Scripts/webkitpy/common/net/statusserver.py:
3697         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
3698         * Scripts/webkitpy/thirdparty/__init__.py: Add an import hook so we can install based on
3699             the import command rather than just installing everything.
3700         * Scripts/webkitpy/thirdparty/__init___unittest.py: Added.
3701
3702 2011-04-27  Girish Ramakrishnan  <girish@forwardbias.in>
3703
3704         Add my IRC nick.
3705
3706         * Scripts/webkitpy/common/config/committers.py:
3707
3708 2011-04-27  Eric Seidel  <eric@webkit.org>
3709
3710         Reviewed by Mihai Parparita.
3711
3712         sherrifbot create-bug shouldn't assign bugs to webkit.review.bot
3713         https://bugs.webkit.org/show_bug.cgi?id=59545
3714
3715         To do this, I needed a way to look up contributors by irc-name
3716         (since anyone in #webkit who might use this command may not be a committer).
3717         To lookup contributors, I had to make Contributor a real object.
3718         Which led me to redesign parts of committers.py...
3719         and finally fix one spot in changelog.py where we wanted to be
3720         looking up contributors and not committers.
3721
3722         Overall a pretty simple fix, once you wade through the yak-hair.
3723
3724         This may not prevent *all* possible ways that bugs would get assigned
3725         to webkit.review.bot.  If we don't recognize the requester we will
3726         go through the previous code path (which shouldn't change the assignee
3727         on the bug from the default as far as I can tell).
3728
3729         * Scripts/webkitpy/common/checkout/changelog.py:
3730         * Scripts/webkitpy/common/config/committers.py:
3731         * Scripts/webkitpy/common/config/committers_unittest.py:
3732         * Scripts/webkitpy/tool/bot/irc_command.py:
3733         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
3734
3735 2011-04-27  Yi Shen  <yi.4.shen@nokia.com>
3736
3737         Reviewed by Kenneth Rohde Christiansen.
3738
3739         [Qt] Upstream Symbian platform plugin
3740         https://bugs.webkit.org/show_bug.cgi?id=58435
3741
3742         Exempting directory WebKit/qt/symbian/platformplugin from style guide.
3743
3744         * Scripts/webkitpy/style/checker.py:
3745         * Scripts/webkitpy/style/checker_unittest.py:
3746
3747 2011-04-27  Jeff Miller  <jeffm@apple.com>
3748
3749         Correct my IRC nickname.
3750
3751         * Scripts/webkitpy/common/config/committers.py:
3752
3753 2011-04-27  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
3754
3755         Reviewed by Darin Adler.
3756
3757         Change the email used on bugzilla
3758         https://bugs.webkit.org/show_bug.cgi?id=59582
3759
3760         * Scripts/webkitpy/common/config/committers.py:
3761
3762 2011-04-27  James Kozianski  <koz@chromium.org>
3763
3764         Reviewed by Ojan Vafai.
3765
3766         Extract map from port to builder name.
3767         https://bugs.webkit.org/show_bug.cgi?id=58301
3768
3769         * Scripts/webkitpy/layout_tests/port/__init__.py:
3770         * Scripts/webkitpy/layout_tests/port/builders.py: Added.
3771         * Scripts/webkitpy/layout_tests/port/builders_unittest.py: Added.
3772         * Scripts/webkitpy/layout_tests/port/factory.py:
3773
3774 2011-04-27  Ryuan Choi  <ryuan.choi@samsung.com>
3775
3776         Reviewed by Martin Robinson.
3777
3778         [GTK] Add proxy support to GtkLauncher
3779         https://bugs.webkit.org/show_bug.cgi?id=58852
3780
3781         Add SOUP_TYPE_PROXY_RESOLVER_DEFAULT feature or set SOUP_SESSION_PROXY_URI for developers behind proxy.
3782
3783         * GNUmakefile.am:
3784         * GtkLauncher/main.c:
3785         (main):
3786
3787 2011-04-27  Annie Sullivan  <sullivan@chromium.org>
3788
3789         Reviewed by David Levin.
3790
3791         Adding myself as a Chromium contributor to committers.py.
3792
3793         https://bugs.webkit.org/show_bug.cgi?id=59576
3794
3795         * Scripts/webkitpy/common/config/committers.py:
3796
3797 2011-04-26  David Grogan  <dgrogan@chromium.org>
3798
3799         Reviewed by David Levin.
3800
3801         Adding myself to Chromium contributors list in committers.py
3802         https://bugs.webkit.org/show_bug.cgi?id=59565
3803
3804         * Scripts/webkitpy/common/config/committers.py:
3805
3806 2011-04-26  Chang Shu  <cshu@webkit.org>
3807
3808         Reviewed by Laszlo Gombos.
3809
3810         WebKitTestRunner needs layoutTestController.addOriginAccessWhitelistEntry
3811         https://bugs.webkit.org/show_bug.cgi?id=42544
3812
3813         Also implemented removeOriginAccessWhitelistEntry and resetOriginAccessWhitelists.
3814
3815         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3816         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3817         (WTR::InjectedBundle::beginTesting):
3818         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3819         (WTR::LayoutTestController::addOriginAccessWhitelistEntry):
3820         (WTR::LayoutTestController::removeOriginAccessWhitelistEntry):
3821         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3822
3823 2011-04-26  Chris Fleizach  <cfleizach@apple.com>
3824
3825         Reviewed by Adele Peterson.
3826
3827         AX: Add more text marker routines to DRT
3828         https://bugs.webkit.org/show_bug.cgi?id=58949
3829
3830         Add a few more methods to help test the text marker system, including nextMarker, previousMarker and
3831         stringForMarkerRange.
3832
3833         * DumpRenderTree/AccessibilityUIElement.cpp:
3834         (nextTextMarkerCallback):
3835         (previousTextMarkerCallback):
3836         (stringForTextMarkerRangeCallback):
3837         (AccessibilityUIElement::previousTextMarker):
3838         (AccessibilityUIElement::nextTextMarker):
3839         (AccessibilityUIElement::stringForTextMarkerRange):
3840         (AccessibilityUIElement::getJSClass):
3841         * DumpRenderTree/AccessibilityUIElement.h:
3842         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3843         (AccessibilityUIElement::previousTextMarker):
3844         (AccessibilityUIElement::nextTextMarker):
3845         (AccessibilityUIElement::stringForTextMarkerRange):
3846
3847 2011-04-26  Dan Bernstein  <mitz@apple.com>
3848
3849         Build fix.
3850
3851         * DumpRenderTree/mac/Configurations/CompilerVersion.xcconfig:
3852         * MiniBrowser/Configurations/CompilerVersion.xcconfig:
3853         * WebKitTestRunner/Configurations/CompilerVersion.xcconfig:
3854
3855 2011-04-26  Kevin Ollivier  <kevino@theolliviers.com>
3856
3857         Rubberstamped by Eric Seidel.
3858
3859         Enable waf to be used to build other ports
3860         https://bugs.webkit.org/show_bug.cgi?id=58213
3861
3862         * Scripts/build-webkit:
3863         * Scripts/webkitdirs.pm:
3864         * waf: Added.
3865         * waf/build: Added.
3866         * waf/build/build_utils.py: Added.
3867         * waf/build/settings.py: Added.
3868         * waf/build/waf_extensions.py: Added.
3869         * waf/build/wxpresets.py: Added.
3870
3871 2011-04-26  Sam Weinig  <sam@webkit.org>
3872
3873         Reviewed by David Hyatt.
3874
3875         Remove Datagrid from the tree
3876         https://bugs.webkit.org/show_bug.cgi?id=59543
3877
3878         * Scripts/build-webkit:
3879         Remove feature.
3880
3881         * iExploder/iexploder-1.3.2/htdocs/htmltags.in:
3882         * iExploder/iexploder-1.7.2/src/html-tags/webkit:
3883         Remove from fuzzer.
3884
3885 2011-04-26  Brent Fulgham  <bfulgham@webkit.org>
3886
3887         Reviewed by Adam Roben.
3888
3889         Update WinLauncher with command-line arguments to allow the
3890         transparency to be tested.  Use --transparent to create a
3891         transparent view.  Use --desktop to have the view fill the
3892         desktop area of the screen.
3893         https://bugs.webkit.org/show_bug.cgi?id=58300
3894
3895         * WinLauncher/WinLauncher.cpp:
3896         (usesLayeredWebView): New method to indicate that the
3897         program is running with layered windows (alpha-blended
3898         transparent windows).
3899         (shouldUseFullDesktop): New method to indicate that the
3900         program is running across the full desktop (less any
3901         task bars.)
3902         (resizeSubViews): Layered window mode doesn't have any
3903         winapi child windows, so this routine is exited early
3904         for that case.
3905         (subclassForLayeredWindow): Subclass the window so we can
3906         override its defaut message loop.
3907         (computeFullDesktopFrame): Convenience function to get the
3908         desktop region and update the frame dimensions appropriately.
3909         (_tWinMain): Updated to accept the new '--transparent' and
3910         '--desktop' arguments.
3911         (InitInstance): Modified to exit early for the transparent
3912         background case.  WebKit will construct our primary window (with
3913         appropriate settings) so we don't need to create one ourselves.
3914         (WndProc): 
3915         (TransparentWndProc): New message loop for transparent windows,
3916         since they need special handling to support dragging.
3917
3918 2011-04-26  Alexandre MAzari  <amazari@igalia.com>
3919
3920         Reviewed by Xan Lopez.
3921
3922         [Gtk] Implement LayoutTestController::setPluginsEnabled
3923         https://bugs.webkit.org/show_bug.cgi?id=59184
3924
3925         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3926         (LayoutTestController::setPluginsEnabled):
3927
3928 2011-04-26  Chang Shu  <cshu@webkit.org>
3929
3930         Reviewed by Laszlo Gombos.
3931
3932         WebKitTestRunner needs layoutTestController.setAllowFileAccessFromFileURLs
3933         https://bugs.webkit.org/show_bug.cgi?id=57572
3934
3935         Remove the unnecessary code that updates preference.
3936
3937         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3938         (WTR::InjectedBundle::beginTesting):
3939         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3940         (WTR::LayoutTestController::setAllowUniversalAccessFromFileURLs):
3941
3942 2011-04-26  Mario Sanchez Prada  <msanchez@igalia.com>
3943
3944         Reviewed by Eric Seidel.
3945
3946         [GTK] accessibility/aria-combobox-expected.txt
3947         https://bugs.webkit.org/show_bug.cgi?id=59399
3948
3949         Implement isExpanded(), as it's used in the layout test.
3950
3951         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3952         (AccessibilityUIElement::isExpanded): Implemented.
3953
3954 2011-04-26  Adrienne Walker  <enne@google.com>
3955
3956         Reviewed by Kent Tamura.
3957
3958         [chromium] Fix memory leak in DRT due to OwnPtr<T*>
3959         https://bugs.webkit.org/show_bug.cgi?id=59489
3960
3961         * DumpRenderTree/chromium/WebViewHost.h:
3962
3963 2011-04-26  Mario Sanchez Prada  <msanchez@igalia.com>
3964
3965         Reviewed by Eric Seidel.
3966
3967         [GTK] Implement isChecked in DRT
3968         https://bugs.webkit.org/show_bug.cgi?id=59385
3969
3970         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3971         (AccessibilityUIElement::isChecked): Implemented.
3972
3973 2011-04-26  Alejandro G. Castro  <alex@igalia.com>
3974
3975         Unreviewed, rolling out r84949.
3976         http://trac.webkit.org/changeset/84949
3977         https://bugs.webkit.org/show_bug.cgi?id=58852
3978
3979         Broke GTK+ compilation
3980
3981         * GtkLauncher/main.c:
3982         (main):
3983
3984 2011-04-26  Eric Seidel  <eric@webkit.org>
3985
3986         Reviewed by Mihai Parparita.
3987
3988         sheriff-bot should have a create-bug command
3989         https://bugs.webkit.org/show_bug.cgi?id=59491
3990
3991         This patch has some stderr unittest spew, but I will
3992         fix it after my live demo.
3993
3994         * Scripts/webkitpy/tool/bot/irc_command.py:
3995         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
3996         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
3997
3998 2011-04-26  Ryuan Choi  <ryuan.choi@samsung.com>
3999
4000         Reviewed by Martin Robinson.
4001
4002         [GTK] Add proxy support to GtkLauncher
4003         https://bugs.webkit.org/show_bug.cgi?id=58852
4004
4005         Add SOUP_TYPE_PROXY_RESOLVER_DEFAULT feature or set SOUP_SESSION_PROXY_URI for developers behind proxy.
4006
4007         * GtkLauncher/main.c:
4008         (main):
4009
4010 2011-04-26  Dan Bernstein  <mitz@apple.com>
4011
4012         Reviewed by Mark Rowe.
4013
4014         Choose the compiler based on the Xcode version for Snow Leopard debug builds.
4015
4016         * DumpRenderTree/mac/Configurations/Base.xcconfig:
4017         * DumpRenderTree/mac/Configurations/CompilerVersion.xcconfig: Added.
4018         * MiniBrowser/Configurations/Base.xcconfig:
4019         * MiniBrowser/Configurations/CompilerVersion.xcconfig: Added.
4020         * TestWebKitAPI/Configurations/Base.xcconfig:
4021         * TestWebKitAPI/Configurations/CompilerVersion.xcconfig: Added.
4022         * WebKitTestRunner/Configurations/Base.xcconfig:
4023         * WebKitTestRunner/Configurations/CompilerVersion.xcconfig: Added.
4024
4025 2011-04-26  Finnur Thorarinsson  <finnur.webkit@gmail.com>
4026
4027         Reviewed by David Levin.
4028
4029         Adding myself as a Chromium contributors to committers.py.
4030
4031         https://bugs.webkit.org/show_bug.cgi?id=59444
4032
4033         * Scripts/webkitpy/common/config/committers.py:
4034
4035 2011-04-26  Adam Barth  <abarth@webkit.org>
4036
4037         Reviewed by Eric Seidel.
4038
4039         DumpRenderTree/chromium should play nice with strict OwnPtrs
4040         https://bugs.webkit.org/show_bug.cgi?id=59458
4041
4042         All these changes are pretty straight forward.
4043
4044         * DumpRenderTree/chromium/CppBoundClass.cpp:
4045         (GetterPropertyCallback::GetterPropertyCallback):
4046         (CppBoundClass::bindGetterCallback):
4047         * DumpRenderTree/chromium/CppBoundClass.h:
4048         (CppBoundClass::bindProperty):
4049         (CppBoundClass::bindFallbackCallback):
4050         (CppBoundClass::bindFallbackMethod):
4051         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
4052         (DRTDevToolsClient::DRTDevToolsClient):
4053         * DumpRenderTree/chromium/TestEventPrinter.cpp:
4054         (TestEventPrinter::createDRTPrinter):
4055         (TestEventPrinter::createTestShellPrinter):
4056         * DumpRenderTree/chromium/TestEventPrinter.h:
4057         * DumpRenderTree/chromium/TestShell.cpp:
4058         (TestShell::TestShell):
4059         (TestShell::createMainWindow):
4060         (TestShell::createDRTDevToolsClient):
4061         * DumpRenderTree/chromium/WebViewHost.cpp:
4062         (WebViewHost::geolocationClientMock):
4063         (WebViewHost::speechInputController):
4064         (WebViewHost::deviceOrientationClientMock):
4065         (WebViewHost::reset):
4066         (WebViewHost::navigate):
4067         (WebViewHost::setPendingExtraData):
4068         (WebViewHost::canvas):
4069         * DumpRenderTree/chromium/WebViewHost.h:
4070
4071 2011-04-26  Adam Roben  <aroben@apple.com>
4072
4073         Make DRT/win log loading errors the same way DRT/mac does
4074
4075         Fixes <http://webkit.org/b/59303> [Windows WebKit1 Tests]
4076         http/tests/misc/will-send-request-returns-null-on-redirect.html failing since r84742
4077
4078         Reviewed by Alexey Proskuryakov.
4079
4080         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
4081         (ResourceLoadDelegate::descriptionSuitableForTestResult): Removed the workaround for
4082         <rdar://problem/5064234>, which has long since been fixed, and then made this function match
4083         -[NSError(DRTExtras) _drt_descriptionSuitableForTestResult] more closely.
4084
4085 2011-04-26  Dan Bernstein  <mitz@apple.com>
4086
4087         REGRESSION (84876): build-webkit produces an error message
4088         https://bugs.webkit.org/show_bug.cgi?id=59460
4089
4090         * Scripts/webkitdirs.pm:
4091
4092 2011-04-26  Mihai Parparita  <mihaip@chromium.org>
4093
4094         Reviewed by Eric Seidel.
4095
4096         Fix timestamp comparison in check-for-weak-vtables-and-externals
4097         https://bugs.webkit.org/show_bug.cgi?id=59416
4098         
4099         We should only re-run the check-for-weak-vtables-and-externals script
4100         if the executable is more recent than the last run.
4101
4102         * Scripts/check-for-weak-vtables-and-externals:
4103
4104 2011-04-26  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
4105
4106         Reviewed by Csaba Osztrogonác.
4107
4108         [Qt] Implement LayoutTestController::setAutofilled
4109         https://bugs.webkit.org/show_bug.cgi?id=59439
4110
4111         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
4112         (LayoutTestController::setAutofilled):
4113         * DumpRenderTree/qt/LayoutTestControllerQt.h:
4114
4115 2011-04-25  Dan Bernstein  <mitz@apple.com>
4116
4117         Reviewed by Mark Rowe.
4118
4119         Teach build-webkit where newer Xcode versions store the application-wide build settings user default.
4120
4121         * Scripts/webkitdirs.pm:
4122
4123 2011-04-25  Sam Weinig  <sam@webkit.org>
4124
4125         Reviewed by Adam Roben.
4126
4127         Leaks Viewer throws "Cannot post cyclic structures" in Safari 5
4128         https://bugs.webkit.org/show_bug.cgi?id=56090
4129
4130         Make LeaksViewer work with versions of browsers that don't support message
4131         passing of cyclic structures.
4132
4133         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParser.js:
4134         (LeaksParser.this._worker.onmessage):
4135         (LeaksParser):
4136         (LeaksParser.prototype.addLeaksFile):
4137         Use LeaksParserImpl directly if we don't support passing cyclic structures.
4138
4139         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserImpl.js: Copied from BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js.
4140         (LeaksParserImpl):
4141         (LeaksParserImpl.prototype.addLeaksFile):
4142         (LeaksParserImpl.prototype._incorporateLeaks):
4143         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:
4144         (onmessage):
4145         Factor out LeaksParser implementation into LeaksParserImpl.js.
4146
4147         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Utilities.js:
4148         (workersSupportCyclicStructures):
4149         Add function to detect if workers support passing cyclic structures.
4150
4151         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html:
4152         Add LeaksParserImpl.js include.
4153
4154 2011-04-25  Jeff Miller  <jeffm@apple.com>
4155
4156         Reviewed by Timothy Hatcher.
4157
4158         Treat strings defined with UI_STRING_LOCALIZE_LATER_KEY() as debugging strings in extract-localizable-strings
4159         https://bugs.webkit.org/show_bug.cgi?id=59373
4160
4161         * Scripts/extract-localizable-strings: Add UI_STRING_LOCALIZE_LATER_KEY() to isDebugMacro var.
4162
4163 2011-04-25  Andrew Scherkus  <scherkus@chromium.org>
4164
4165         Reviewed by Dimitri Glazkov.
4166
4167         Adding a few Chromium contributors to committers.py.
4168
4169         https://bugs.webkit.org/show_bug.cgi?id=59327
4170
4171         * Scripts/webkitpy/common/config/committers.py:
4172
4173 2011-04-23  Dominic Cooney  <dominicc@chromium.org>
4174
4175         Reviewed by Dimitri Glazkov.
4176
4177         [V8] Nodes in shadow DOM should not be GCed while their hosts are alive
4178         https://bugs.webkit.org/show_bug.cgi?id=59284
4179
4180         Chromium DRT over-refcounted the NPObject wrappers it used to
4181         marshal shadowRoot nodes back to tests (WebBindings::makeNode
4182         births NPObjects with referenceCount == 1). This masked the GC bug
4183         59284 in tests by making shadowRoot nodes live forever.
4184
4185         * DumpRenderTree/chromium/LayoutTestController.cpp:
4186         (LayoutTestController::shadowRoot):
4187         (LayoutTestController::ensureShadowRoot):
4188
4189 2011-04-23  Kevin Ollivier  <kevino@theolliviers.com>
4190
4191         [wx] Unreviewed build fixes. Add new methods to wx LayoutTestController,
4192         and update the URL for downloading waf.
4193         
4194         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
4195         (LayoutTestController::ensureShadowRoot):
4196         (LayoutTestController::removeShadowRoot):
4197         * Scripts/webkitdirs.pm:
4198
4199 2011-04-22  Sheriff Bot  <webkit.review.bot@gmail.com>
4200
4201         Unreviewed, rolling out r84627.
4202         http://trac.webkit.org/changeset/84627
4203         https://bugs.webkit.org/show_bug.cgi?id=59271
4204
4205         It broke Symbian build (Requested by Ossy on #webkit).
4206
4207         * Scripts/webkitpy/style/checker.py:
4208         * Scripts/webkitpy/style/checker_unittest.py:
4209
4210 2011-04-22  Dirk Pranke  <dpranke@chromium.org>
4211
4212         Reviewed by Adam Barth.
4213
4214         rebaseline-chromium-webkit-tests: clean up output
4215         https://bugs.webkit.org/show_bug.cgi?id=59240
4216
4217         This change dramatically changes the output the tool provides
4218         by default. The previous output (more or less) is still there
4219         in -v / verbose / debug mode, but the default output is
4220         way terser and more readable. It mostly says which files are
4221         updated, which are duplicates, and which are not found in an
4222         archive. Feedback desired :).
4223
4224         This change also adds a scm.exists() method to the SCM object
4225         so that we can cleanly figure out what we're doing while
4226         rebaselining.
4227
4228         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
4229         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
4230         * Scripts/webkitpy/common/system/filesystem_mock.py:
4231         * Scripts/webkitpy/common/checkout/scm.py:
4232         * Scripts/webkitpy/common/checkout/scm_unittest.py:
4233
4234 2011-04-22  Ilya Sherman  <isherman@chromium.org>
4235
4236         Reviewed by Alexey Proskuryakov.
4237
4238         Add Ilya Sherman (isherman@chromium.org) to the list of contributors
4239         https://bugs.webkit.org/show_bug.cgi?id=59231
4240
4241         * Scripts/webkitpy/common/config/committers.py:
4242
4243 2011-04-22  Yuta Kitamura  <yutak@chromium.org>
4244
4245         Reviewed by Ojan Vafai.
4246
4247         new-run-webkit-tests: Exception raised when stderr contains binary data
4248         https://bugs.webkit.org/show_bug.cgi?id=59083
4249
4250         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
4251         Use write_binary_file() instead of write_text_file().
4252
4253 2011-04-22  Chang Shu  <cshu@webkit.org>
4254
4255         Reviewed by Kenneth Rohde Christiansen.
4256
4257         WebKitTestRunner needs layoutTestController.setFrameFlatteningEnabled
4258         https://bugs.webkit.org/show_bug.cgi?id=42536
4259
4260         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
4261         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
4262         (WTR::LayoutTestController::setFrameFlatteningEnabled):
4263         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
4264
4265 2011-04-22  Adam Barth  <abarth@webkit.org>
4266
4267         Reviewed by Eric Seidel.
4268
4269         CommitQueue should remember the expected failures from patch to patch
4270         https://bugs.webkit.org/show_bug.cgi?id=59253
4271
4272         Previously, we stored the set of expected failures on the task object,
4273         which meant the commit-queue forgot about them after each patch.  This
4274         patch moves them to the CommitQueue object so they will have a longer
4275         lifetime.
4276
4277         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
4278         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
4279         * Scripts/webkitpy/tool/commands/queues.py:
4280
4281 2011-04-22  Sam Weinig  <sam@webkit.org>
4282
4283         Reviewed by Brian Weinstein.
4284
4285         WebKit2: Implement JavaScript unresponsiveness timer/callbacks
4286         https://bugs.webkit.org/show_bug.cgi?id=59248
4287
4288         Stub out shouldInterruptJavaScript callbacks.
4289
4290         * MiniBrowser/mac/BrowserWindowController.m:
4291         (-[BrowserWindowController awakeFromNib]):
4292         * MiniBrowser/win/BrowserView.cpp:
4293         (BrowserView::create):
4294         * WebKitTestRunner/TestController.cpp:
4295         (WTR::TestController::createOtherPage):
4296         (WTR::TestController::initialize):
4297
4298 2011-04-22  Daniel Bates  <dbates@webkit.org>
4299
4300         Reviewed by Csaba Osztrogonác.
4301
4302         webkit-patch land hangs if svn prompts for credentials
4303         https://bugs.webkit.org/show_bug.cgi?id=31500
4304
4305         Make has_authorization_for_realm() return True only if there exists a credentials file
4306         that contains either the word "password" or "passtype". We assume that these words don't
4307         coincide with the actual credential data (e.g. a person's username is "password").
4308
4309         * Scripts/webkitpy/common/checkout/scm.py:
4310         * Scripts/webkitpy/common/checkout/scm_unittest.py:
4311           - Added test cases:
4312             test_has_authorization_for_realm_using_credentials_with_passtype(),
4313             test_has_authorization_for_realm_using_credentials_with_password(),
4314             test_not_have_authorization_for_realm_with_credentials_missing_password_and_passtype()
4315           - Renamed test_not_have_authorization_for_realm() to test_not_have_authorization_for_realm_when_missing_credentials_file()
4316             to better describe what it's testing.
4317           - Repurposed test_has_authorization_for_realm() to take realm and credential data to use
4318             and return the result of calling has_authorization_for_realm() so that the caller can
4319             assert the result; Renamed to _test_has_authorization_for_realm_using_credentials() to
4320             better reflect its new purpose.
4321
4322 2011-04-22  Adam Barth  <abarth@webkit.org>
4323
4324         Remove double-negative.  (Sorry this was bugging me.)
4325
4326         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
4327
4328 2011-04-22  Adam Barth  <abarth@webkit.org>
4329
4330         Reviewed by Eric Seidel.
4331
4332         Factor LayoutTestResultsReader out of CommitQueue
4333         https://bugs.webkit.org/show_bug.cgi?id=59244
4334
4335         This code will be shared with the EWS when they start running tests.
4336
4337         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py: Added.
4338         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py: Added.
4339         * Scripts/webkitpy/tool/commands/queues.py:
4340         * Scripts/webkitpy/tool/commands/queues_unittest.py:
4341
4342 2011-04-22  Eric Seidel  <eric@webkit.org>
4343
4344         Reviewed by Dimitri Glazkov.
4345
4346         webkit-patch rebaseline is broken
4347         https://bugs.webkit.org/show_bug.cgi?id=59207
4348
4349         My recent changes to how LayoutTestResults.results_from_string
4350         uncovered a bug in our use of urllib2.
4351         We now are treating the return value from _fetch_results_html()
4352         (which returns urllib2.openurl()) as a string.  That's incorrect,
4353         the return value is a file-like object (which auto-converts to a
4354         string in most cases).
4355
4356         I've updated our urllib2-using code to correctly call .read() on the
4357         resulting object before treating it like a string.
4358         Unfortunately there is no easy way to test this mis-understanding
4359         of the openurl() semantics.
4360