Unreviewed, rolling out r196791.
[WebKit-https.git] / Tools / ChangeLog
1 2016-02-18  Commit Queue  <commit-queue@webkit.org>
2
3         Unreviewed, rolling out r196791.
4         https://bugs.webkit.org/show_bug.cgi?id=154438
5
6         broke windows build (Requested by alexchristensen on #webkit).
7
8         Reverted changeset:
9
10         "Extend HashCountedSet with a method to efficiently set the
11         count of an entry"
12         https://bugs.webkit.org/show_bug.cgi?id=154352
13         http://trac.webkit.org/changeset/196791
14
15 2016-02-18  Brent Fulgham  <bfulgham@apple.com>
16
17         Extend HashCountedSet with a method to efficiently set the count of an entry
18         https://bugs.webkit.org/show_bug.cgi?id=154352
19
20         Reviewed by Geoffrey Garen.
21
22         * TestWebKitAPI/CMakeLists.txt: Add new HashCountedSet test files.
23         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
24         * TestWebKitAPI/Tests/WTF/HashCountedSet.cpp: Added.
25
26 2016-02-18  Anders Carlsson  <andersca@apple.com>
27
28         Get rid of the --target-web-process and --use-web-process-xpc-service options.
29
30         Rubber-stamped by Dan Bernstein.
31
32         We now always use XPC, and --target-web-process is no longer supported.
33
34         * Scripts/webkitdirs.pm:
35         (execMacWebKitAppForDebugging):
36         (shouldTargetWebProcess): Deleted.
37         (determineShouldTargetWebProcess): Deleted.
38         (shouldUseXPCServiceForWebProcess): Deleted.
39         (determineShouldUseXPCServiceForWebProcess): Deleted.
40         (printHelpAndExitForRunAndDebugWebKitAppIfNeeded): Deleted.
41         (argumentsForRunAndDebugMacWebKitApp): Deleted.
42
43 2016-02-18  Ryan Haddad  <ryanhaddad@apple.com>
44
45         Skip API test WTF_ParkingLot.UnparkOneFiftyThenFiftyAll on ios-simulator
46         https://bugs.webkit.org/show_bug.cgi?id=153997
47
48         Reviewed by Filip Pizlo.
49
50         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
51
52 2016-02-18  Jer Noble  <jer.noble@apple.com>
53
54         run-webkit-httpd should use webkitpy to run httpd.
55         https://bugs.webkit.org/show_bug.cgi?id=154271
56
57         Reviewed by Alexey Proskuryakov.
58
59         Update run-webkit-httpd to use webkitpy.port to launch httpd. Pass on http_port and http_all_interface
60         options to match the current run-webkit-httpd (optional) behavior.
61
62         * Scripts/run-webkit-httpd:
63         (parse_args):
64         (main):
65         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
66         (LayoutTestApacheHttpd.__init__):
67         * Scripts/webkitpy/layout_tests/servers/http_server.py:
68         (Lighttpd._prepare_config):
69         * Scripts/webkitpy/port/base.py:
70         (Port.to.start_http_server):
71
72 2016-02-18  Filip Pizlo  <fpizlo@apple.com>
73
74         Remove remaining references to LLVM, and make sure comments refer to the backend as "B3" not "LLVM"
75         https://bugs.webkit.org/show_bug.cgi?id=154383
76
77         Reviewed by Saam Barati.
78
79         * Scripts/run-jsc-stress-tests:
80
81 2016-02-17  Filip Pizlo  <fpizlo@apple.com>
82
83         Remove LLVM dependencies from WebKit
84         https://bugs.webkit.org/show_bug.cgi?id=154323
85
86         Reviewed by Antti Koivisto and Benjamin Poulain.
87
88         * Scripts/copy-webkitlibraries-to-product-directory:
89         (isContentOfFileEqualToString):
90         (fileContains): Deleted.
91         (buildLLVM): Deleted.
92         (symlinkLLVMLibrariesIfNeeded): Deleted.
93
94 2016-02-16  Sam Weinig  <sam@webkit.org>
95
96         Add an ensure function on HashMap that takes a key and a function to make the lazy value initialization idiom easier
97         https://bugs.webkit.org/show_bug.cgi?id=134857
98
99         Reviewed by Geoffrey Garen.
100
101         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
102         Add tests for HashMap::ensure.
103
104 2016-02-17  Nan Wang  <n_wang@apple.com>
105
106         AX: Implement sentence related text marker functions using TextIterator
107         https://bugs.webkit.org/show_bug.cgi?id=154312
108
109         Reviewed by Chris Fleizach.
110
111         * DumpRenderTree/AccessibilityUIElement.cpp:
112         (nextParagraphEndTextMarkerForTextMarkerCallback):
113         (sentenceTextMarkerRangeForTextMarkerCallback):
114         (previousSentenceStartTextMarkerForTextMarkerCallback):
115         (nextSentenceEndTextMarkerForTextMarkerCallback):
116         (setSelectedVisibleTextRangeCallback):
117         (AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
118         (AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker):
119         (AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker):
120         (AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker):
121         (AccessibilityUIElement::getJSClass):
122         * DumpRenderTree/AccessibilityUIElement.h:
123         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
124         (AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
125         (AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker):
126         (AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker):
127         (AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker):
128         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
129         (AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
130         (AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker):
131         (AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker):
132         (AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker):
133         (AccessibilityUIElement::supportedActions):
134         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
135         (WTR::AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker):
136         (WTR::AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
137         (WTR::AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker):
138         (WTR::AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker):
139         (WTR::AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker):
140         (WTR::AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker):
141         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
142         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
143         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
144         (WTR::AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker):
145         (WTR::AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker):
146         (WTR::AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker):
147         (WTR::AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker):
148         (WTR::AccessibilityUIElement::mathPostscriptsDescription):
149         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
150         (WTR::AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
151         (WTR::AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker):
152         (WTR::AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker):
153         (WTR::AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker):
154         (WTR::_convertMathMultiscriptPairsToString):
155
156 2016-02-15  Brent Fulgham  <bfulgham@apple.com>
157
158         [Mac] Gather some rudimentary statistics during resource load 
159         https://bugs.webkit.org/show_bug.cgi?id=153575
160         <rdar://problem/24075254>
161
162         Reviewed by Brady Eidson.
163
164         * MiniBrowser/mac/SettingsController.h:
165         * MiniBrowser/mac/SettingsController.m:
166         (-[SettingsController _populateMenu]): Add menu item for new debug flag.
167         (-[SettingsController toggleResourceLoadStatisticsEnabled:]): Added.
168         (-[SettingsController resourceLoadStatisticsEnabled]): Added.
169         * MiniBrowser/mac/WK1BrowserWindowController.m:
170         (-[WK1BrowserWindowController didChangeSettings]): React to changes in
171         users's desire to track resource load statistics.
172
173 2016-02-15  Csaba Osztrogonác  <ossy@webkit.org>
174
175         [EFL] Update Tools/efl/install-dependencies
176         https://bugs.webkit.org/show_bug.cgi?id=154239
177
178         Reviewed by Michael Catanzaro.
179
180         * efl/install-dependencies:
181
182 2016-02-15  Alex Christensen  <achristensen@webkit.org>
183
184         Fix internal Windows build of projects built after WebKit
185         https://bugs.webkit.org/show_bug.cgi?id=154249
186         rdar://problem/24644805
187
188         Reviewed by Chris Dumez.
189
190         * DumpRenderTree/PlatformWin.cmake:
191         * MiniBrowser/win/CMakeLists.txt:
192         Don't include DerivedSources/WebKit/Interfaces to make MiniBrowser and DumpRenderTree
193         more like projects built internally after WebKit.  They should only need to use what
194         is in ForwardingHeaders/WebKit.
195
196 2016-02-12  Nan Wang  <n_wang@apple.com>
197
198         AX: Implement paragraph related text marker functions using TextIterator
199         https://bugs.webkit.org/show_bug.cgi?id=154098
200         <rdar://problem/24269675>
201
202         Reviewed by Chris Fleizach.
203
204         * DumpRenderTree/AccessibilityUIElement.cpp:
205         (nextWordEndTextMarkerForTextMarkerCallback):
206         (paragraphTextMarkerRangeForTextMarkerCallback):
207         (previousParagraphStartTextMarkerForTextMarkerCallback):
208         (nextParagraphEndTextMarkerForTextMarkerCallback):
209         (setSelectedVisibleTextRangeCallback):
210         (AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
211         (AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker):
212         (AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker):
213         (AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
214         (AccessibilityUIElement::getJSClass):
215         * DumpRenderTree/AccessibilityUIElement.h:
216         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
217         (AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
218         (AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker):
219         (AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker):
220         (AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
221         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
222         (AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
223         (AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker):
224         (AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker):
225         (AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
226         (AccessibilityUIElement::supportedActions):
227         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
228         (WTR::AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker):
229         (WTR::AccessibilityUIElement::previousWordStartTextMarkerForTextMarker):
230         (WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
231         (WTR::AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker):
232         (WTR::AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
233         (WTR::AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker):
234         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
235         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
236         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
237         (WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
238         (WTR::AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker):
239         (WTR::AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
240         (WTR::AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker):
241         (WTR::AccessibilityUIElement::mathPostscriptsDescription):
242         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
243         (WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
244         (WTR::AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker):
245         (WTR::AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker):
246         (WTR::AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
247         (WTR::_convertMathMultiscriptPairsToString):
248
249 2016-02-12  Jason Marcell  <jmarcell@apple.com>
250
251         Open source bot watcher's dashboard fails assertion in BuildbotQueue.prototype.compareIterationsByRevisions
252         https://bugs.webkit.org/show_bug.cgi?id=154180
253
254         Reviewed by Alexey Proskuryakov.
255
256         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js: Remove reference to Internal
257         repository.
258
259 2016-02-12  Jer Noble  <jer.noble@apple.com>
260
261         [Mac] Adopt MediaResourceLoader (instead of CachedResourceLoader) in WebCoreNSURLSession.
262         https://bugs.webkit.org/show_bug.cgi?id=154136
263
264         Reviewed by Alex Christensen.
265
266         Use a MediaResourceLoader instead of a CachedResourceLoader for WebCoreNSURLSession.
267
268         Drive-by fix: generate USE and ENABLE macros for TestWebKitAPI by adding FEATURE_DEFINES
269         to GCC_PREPROCESSOR_DEFINES.
270
271         * TestWebKitAPI/Configurations/Base.xcconfig:
272         * TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm:
273         (TestWebKitAPI::WebCoreNSURLSessionTest::SetUp):
274         (TestWebKitAPI::WebCoreNSURLSessionTest::TearDown):
275         (TestWebKitAPI::TEST_F):
276
277 2016-02-11  Dana Burkart  <dburkart@apple.com>
278
279         Large logs can bring down the webkit master
280         https://bugs.webkit.org/show_bug.cgi?id=122112
281
282         Reviewed by Lucas Forschler.
283
284         Implement the suggested fix of throwing away stdout / stderr.
285
286         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
287         (RunWebKit1LeakTests):
288
289 2016-02-10  Jason Marcell  <jmarcell@apple.com>
290
291         Remove calls to parseInt in order to work with non-integer revisions
292         https://bugs.webkit.org/show_bug.cgi?id=153820
293
294         Reviewed by Daniel Bates.
295
296         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
297         (BuildbotIteration.prototype.sourceStampChanges): Remove calls to parseInt in order to work with non-integer
298         revisions.
299         (BuildbotIteration.prototype._parseData): Ditto.
300         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
301         (BuildbotQueue.prototype.update): Ditto.
302         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueueView.js:
303         (MockBuildbotQueueView.prototype._latestProductiveIteration): Change integers to strings in test code.
304         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js:
305         (MockTrac.prototype.get oldestRecordedRevisionNumber): Ditto.
306         (MockTrac.prototype.get latestRecordedRevisionNumber): Ditto.
307         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Ditto.
308
309 2016-02-10  Jason Marcell  <jmarcell@apple.com>
310
311         Teach dashboard code to compare non-integer revisions
312         https://bugs.webkit.org/show_bug.cgi?id=152345
313
314         Reviewed by Daniel Bates.
315
316         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
317         (BuildbotQueue.prototype.compareIterationsByRevisions): Compare non-integer revisions.
318         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
319         (BuildbotQueueView.prototype._appendPendingRevisionCount): Use Trac.indexOfRevision in order to compare non-integer
320         revisions. Also uses new Trac.commitsOnBranchLaterThanRevision method.
321         (BuildbotQueueView.prototype._popoverLinesForCommitRange): Ditto.
322         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Use Trac.indexOfRevision in order to compare non-integer
323         revisions. Also uses new Trac.nextRevision method to calculate a revision range.
324         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Ditto.
325         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
326         (Trac.prototype._commitsOnBranch): Renamed this to indicate that it should be a private method used by the latter two new
327         methods.
328         (Trac.prototype.commitsOnBranchLaterThanRevision): Finds revisions on a branch later than the specified revision.
329         (Trac.prototype.commitsOnBranchInRevisionRange): Finds revisions on a branch within a specified range.
330         (Trac.prototype.nextRevision): Finds the next revision after a given revision on a specific branch.
331         (Trac.prototype.indexOfRevision): Finds the index of a given revision within the recordedCommits array.
332         (Trac.prototype.commitsOnBranch): Deleted. Renamed to _commitsOnBranch.
333         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added unit tests.
334
335 2016-02-09  Nan Wang  <n_wang@apple.com>
336
337         AX: Implement word related text marker functions using TextIterator
338         https://bugs.webkit.org/show_bug.cgi?id=153939
339         <rdar://problem/24269605>
340
341         Reviewed by Chris Fleizach.
342
343         * DumpRenderTree/AccessibilityUIElement.cpp:
344         (endTextMarkerCallback):
345         (leftWordTextMarkerRangeForTextMarkerCallback):
346         (rightWordTextMarkerRangeForTextMarkerCallback):
347         (previousWordStartTextMarkerForTextMarkerCallback):
348         (nextWordEndTextMarkerForTextMarkerCallback):
349         (setSelectedVisibleTextRangeCallback):
350         (AccessibilityUIElement::setSelectedVisibleTextRange):
351         (AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker):
352         (AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker):
353         (AccessibilityUIElement::previousWordStartTextMarkerForTextMarker):
354         (AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
355         (AccessibilityUIElement::getJSClass):
356         * DumpRenderTree/AccessibilityUIElement.h:
357         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
358         (AccessibilityUIElement::setSelectedVisibleTextRange):
359         (AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker):
360         (AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker):
361         (AccessibilityUIElement::previousWordStartTextMarkerForTextMarker):
362         (AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
363         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
364         (AccessibilityUIElement::setSelectedVisibleTextRange):
365         (AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker):
366         (AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker):
367         (AccessibilityUIElement::previousWordStartTextMarkerForTextMarker):
368         (AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
369         (AccessibilityUIElement::supportedActions):
370         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
371         (WTR::AccessibilityUIElement::setBoolAttributeValue):
372         (WTR::AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker):
373         (WTR::AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker):
374         (WTR::AccessibilityUIElement::previousWordStartTextMarkerForTextMarker):
375         (WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
376         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
377         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
378         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
379         (WTR::AccessibilityUIElement::endTextMarker):
380         (WTR::AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker):
381         (WTR::AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker):
382         (WTR::AccessibilityUIElement::previousWordStartTextMarkerForTextMarker):
383         (WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
384         (WTR::AccessibilityUIElement::mathPostscriptsDescription):
385         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
386         (WTR::AccessibilityUIElement::endTextMarker):
387         (WTR::AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker):
388         (WTR::AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker):
389         (WTR::AccessibilityUIElement::previousWordStartTextMarkerForTextMarker):
390         (WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
391         (WTR::_convertMathMultiscriptPairsToString):
392
393 2016-02-09  Csaba Osztrogonác  <ossy@webkit.org>
394
395         [EFL] Remove eail related cruft after r195725
396         https://bugs.webkit.org/show_bug.cgi?id=154030
397
398         Reviewed by Alex Christensen.
399
400         * efl/jhbuildrc:
401
402 2016-02-09  Csaba Osztrogonác  <ossy@webkit.org>
403
404         [EFL] Remove LLVM related cruft after r196077
405         https://bugs.webkit.org/show_bug.cgi?id=154031
406
407         Reviewed by Alex Christensen.
408
409         * efl/jhbuild.modules:
410         * efl/patches/llvm-elf-add-stackmaps-arm64.patch: Removed.
411         * efl/patches/llvm-elf-allow-fde-references-outside-the-2gb-range-arm64.patch: Removed.
412         * efl/patches/llvm-version-arm64.patch: Removed.
413
414 2016-02-05  Aakash Jain  <aakash_jain@apple.com>
415
416         tests fail if display sleeps while run-webkit-tests is running
417         https://bugs.webkit.org/show_bug.cgi?id=153919
418
419         Reviewed by Alexey Proskuryakov.
420
421         * DumpRenderTree/mac/LayoutTestHelper.m:
422         (addDisplaySleepAssertion): Add the assertion so that the display doesn't turn off.
423         (releaseDisplaySleepAssertion): Release the DisplaySleep Assertion.
424         (simpleSignalHandler): Release the DisplaySleepAssertion in case of any iterrupt.
425
426 2016-02-05  Alex Christensen  <achristensen@webkit.org>
427
428         Fix iOS API tests after r196082
429         https://bugs.webkit.org/show_bug.cgi?id=153900
430
431         Reviewed by Jer Noble.
432
433         * TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm:
434         (TestWebKitAPI::WebCoreNSURLSessionTest::SetUp):
435         [WebView initialize] doesn't call JSC::initializeThreading on iOS.
436
437 2016-02-04  Jason Marcell  <jmarcell@apple.com>
438
439         The status message for passing combined builder queues should say "all builds succeeded" when expanded.
440         https://bugs.webkit.org/show_bug.cgi?id=153882
441
442         Reviewed by Alexey Proskuryakov.
443
444         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
445         (BuildbotCombinedQueueView.prototype.update): Set status to "all builds succeeded" for combined builder queues
446         when expanded.
447
448 2016-02-03  Filip Pizlo  <fpizlo@apple.com>
449
450         run-jsc-stress-tests should be better at telling you details about test failures
451         https://bugs.webkit.org/show_bug.cgi?id=153845
452
453         Reviewed by Geoffrey Garen.
454
455         Here's an example of the contents of results/resultsByFamily, one of the new files that this
456         generates, for some local testing I'm doing.  Notice how it groups families of tests together.
457
458         You won't see this unless you cat results/resultsByFamily.
459
460         regress.yaml/Regress/radar-24289839.js:
461             regress.yaml/Regress/radar-24289839.js.default: PASS
462             regress.yaml/Regress/radar-24289839.js.ftl: PASS
463             regress.yaml/Regress/radar-24289839.js.ftl-no-cjit: FAIL
464             regress.yaml/Regress/radar-24289839.js.ftl-eager-no-cjit: FAIL
465         
466         regress.yaml/Regress/radar-24290639.js:
467             regress.yaml/Regress/radar-24290639.js.default: PASS
468             regress.yaml/Regress/radar-24290639.js.ftl: PASS
469             regress.yaml/Regress/radar-24290639.js.ftl-no-cjit: PASS
470             regress.yaml/Regress/radar-24290639.js.ftl-eager-no-cjit: FAIL
471         
472         regress.yaml/Regress/radar-24290670.js: FAILED
473         
474         * Scripts/run-jsc-stress-tests:
475
476 2016-02-03  Carlos Garcia Campos  <cgarcia@igalia.com>
477
478         [WTR] Crash in EventSendingController::contextClick() when context menu event is not handled
479         https://bugs.webkit.org/show_bug.cgi?id=153835
480
481         Reviewed by Martin Robinson.
482
483         WKBundlePageCopyContextMenuAtPointInWindow() returns nullptr when
484         the context menu event is not handled, but we are using the
485         returned value without null checking it.
486
487         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
488         (WTR::EventSendingController::contextClick):
489
490 2016-02-03  Jason Marcell  <jmarcell@apple.com>
491
492         Format revisions for display according to repository type
493         https://bugs.webkit.org/show_bug.cgi?id=153818
494
495         Reviewed by Alexey Proskuryakov.
496
497         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
498         (BuildbotQueueView.prototype._popoverLinesForCommitRange): Use new _formatRevisionForDisplay to display revisions according
499         to repository type.
500         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Ditto.
501         (BuildbotQueueView.prototype._formatRevisionForDisplay): Formats revisions for display according to repository type.
502         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added unit tests to test new
503         _formatRevisionForDisplay function.
504
505 2016-02-03  Aakash Jain  <aakash_jain@apple.com>
506
507         Logs/CoreSimulator filling up OS disk on WebKit testers
508         https://bugs.webkit.org/show_bug.cgi?id=153853
509         <rdar://problem/24496003>
510
511         Reviewed by Alexey Proskuryakov.
512
513         * Scripts/webkitpy/port/ios.py:
514         (IOSSimulatorPort.clean_up_test_run): Delete Logs during cleanup.
515
516 2016-02-03  Brian Burg  <bburg@apple.com>
517
518         git-add-reviewer should work when run from a subdirectory within the repository
519         https://bugs.webkit.org/show_bug.cgi?id=153842
520
521         Reviewed by David Kilzer.
522
523         There are two problems that needed to be fixed:
524
525          - We can't assume .git is in $PWD/.git
526          - We can't specify absolute paths to `git commit`
527
528         Fix these problems using the helpers in VCSUtils that were added to
529         fix this same issue for prepare-changeCogs.
530
531         * Scripts/VCSUtils.pm: Export gitDirectory()
532         * Scripts/git-add-reviewer:
533         (nonInteractive): Cache gitDirectory() result.
534         (addReviewer):
535         (commit):
536         (changeLogsForCommit): Make paths relative.
537
538 2016-02-03  Jer Noble  <jer.noble@apple.com>
539
540         Yet another Yosemite build fix.
541
542         * TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm:
543
544 2016-02-03  Jer Noble  <jer.noble@apple.com>
545
546         iOS build fix after Yosemite build fix broke iOS build.
547
548         * TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm:
549
550 2016-02-03  Jer Noble  <jer.noble@apple.com>
551
552         Yosemite build fix; hide the entire WebCoreNSURLSessionDataTask class from Yosemite and prior.
553
554         * TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm:
555
556 2016-02-03  Joonghun Park  <jh718.park@samsung.com>
557
558         [Tools] Remove $additionalCMakeArgs variable because without this variable --cmakeargs options works well
559         https://bugs.webkit.org/show_bug.cgi?id=153827
560
561         Reviewed by Michael Catanzaro.
562
563         When an array is passed to subroutines as argument in perl,
564         a list containing its element is returned from the array.
565         Currently @$ arguments are being passed, then it is going to be one list
566         including all the elements not only from @ but also from $.
567         As a result, --cmakeargs option's value is included in @cmakeArgs
568         at generateBuildSystemFromCMakeProject subroutine,
569         so $additionalCMakeArgs doesn't needed anymore.
570
571         * Scripts/webkitdirs.pm:
572         (generateBuildSystemFromCMakeProject):
573
574 2016-02-03  Jer Noble  <jer.noble@apple.com>
575
576         [Mac] Wrap a resource and resource loader in a NSURLSession-like object for use by lower level frameworks
577         https://bugs.webkit.org/show_bug.cgi?id=153669
578
579         Reviewed by Alex Christensen.
580
581         Add an API test for WebCoreNSURLSession, testing that it behaves like a regulare NSURLSession, including
582         calling appropriate NSURLSessionDelegate callbacks.
583
584         Drive-by fix: Add a FeatureDefines.xcconfig to TestWebKitAPI.  Without this, the ENABLE macros in WebCore
585         header files will not match the one used when compiling WebCore, leading to strange crashes and weird
586         inconsistencies when calling, e.g., inline methods.
587
588         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Added.
589         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
590         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
591         * TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm: Added.
592         (-[TestNSURLSessionLoaderDelegate webView:didCommitLoadForFrame:]):
593         (-[TestNSURLSessionDataDelegate URLSession:task:didCompleteWithError:]):
594         (-[TestNSURLSessionDataDelegate URLSession:dataTask:didReceiveResponse:completionHandler:]):
595         (-[TestNSURLSessionDataDelegate URLSession:dataTask:didReceiveData:]):
596         (TestWebKitAPI::WebCoreNSURLSessionTest::SetUp):
597         (TestWebKitAPI::WebCoreNSURLSessionTest::TearDown):
598         (TestWebKitAPI::TEST_F):
599
600 2016-02-03  Konstantin Tokarev  <annulen@yandex.ru>
601
602         [webkitdirs] Clarify logic behind is{PortName} functions.
603         https://bugs.webkit.org/show_bug.cgi?id=153554
604
605         Reviewed by Michael Catanzaro.
606
607         * Scripts/webkitdirs.pm:
608         (prohibitUnknownPort): This function makes determinePortName()
609         failure fatal.
610         (determinePortName): Added new function which decides which port are
611         we building based on command line switches and platform defaults.
612         (portName): Added getter for determined $portName.
613         (isEfl): Modified to use portName().
614         (isGtk): Ditto.
615         (isWinCairo): Ditto.
616         (isAppleMacWebKit): Ditto.
617         (isAppleWinWebKit): Ditto.
618         (isIOSWebKit): Ditto.
619         (cmakeBasedPortName): Return portName() with capitalized first letter.
620         (determineIsEfl): Deleted.
621         (determineIsGtk): Deleted.
622         (determineIsWinCairo): Deleted.
623
624         * Scripts/build-jsc: Call prohibitUnknownPort().
625         * Scripts/run-minibrowser: Ditto.
626         * Scripts/webkitperl/FeatureList.pm: Ditto.
627         * Scripts/update-webkit: Call determinePortName() instead of
628         determineIsWinCairo().
629
630 2016-02-02  Dan Bernstein  <mitz@apple.com>
631
632         Better fix for Layout Test fast/parser/external-entities-in-xslt.xml is flaky on El Capitan (but fails most of the time)
633         https://bugs.webkit.org/show_bug.cgi?id=153683
634
635         Reviewed by Darin Adler.
636
637         * Scripts/webkitpy/port/driver.py:
638         (Driver._setup_environ_for_driver): Reverted change from r196013. DUMPRENDERTREE_TEMP is not
639           used by any code in the Web Content process. If that ever changed, we should send it over
640           as a bundle parameter.
641
642         * Scripts/webkitpy/port/ios.py:
643         (IOSSimulatorPort.setup_environ_for_server): Reverted change from r196013.
644
645         * Scripts/webkitpy/port/mac.py:
646         (MacPort.setup_environ_for_server): Ditto.
647
648         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
649         (WTR::InjectedBundle::platformInitialize): Set XML_CATALOG_FILES in the Web Process
650           environment. This is early enough that libxml2 has not been initialized yet.
651
652         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
653         (WTR::InjectedBundle::platformInitialize): Ditto.
654
655 2016-02-02  Dan Bernstein  <mitz@apple.com>
656
657         Layout Test fast/parser/external-entities-in-xslt.xml is flaky on El Capitan (but fails most of the time)
658         https://bugs.webkit.org/show_bug.cgi?id=153683
659
660         Reviewed by Alexey Proskuryakov.
661
662         Ensure that XML_CATALOG_FILES is set in the Web Content service’s environment as well.
663
664         * Scripts/webkitpy/port/driver.py:
665         (Driver._setup_environ_for_driver): Also set __XPC_DUMPRENDERTREE_TEMP.
666         * Scripts/webkitpy/port/ios.py:
667         (IOSSimulatorPort.setup_environ_for_server): Set __XPC_XML_CATALOG_FILES.
668         * Scripts/webkitpy/port/mac.py:
669         (MacPort.setup_environ_for_server): Ditto.
670
671 2016-01-29 Grzegorz Czajkowski  <g.czajkowski@samsung.com>
672
673         [EFL] Virtual Keyboard overlaps MiniBrowser's WebView
674         https://bugs.webkit.org/show_bug.cgi?id=153009
675
676         Reviewed by Gyuyoung Kim.
677
678         On mobile, virtual keyboard represented by ecore_imf module appears on
679         the top of application layer usually covering bottom part of the screen.
680         If the web page contains the editable content on the bottom of the page
681         it will be overlapped by keyboard which prevents user from seeing the
682         typed text.
683
684         Pack MiniBrowser layout into conformant widget to allow EFL to guess
685         the space that will be required by the keyboard, finally resizing it
686         to the desired size. As a result, webview gets resized and scrolled
687         into focused elements which makes the editable elements visible while
688         typing.
689
690         More details about elm_conformant widger can be found at:
691         https://docs.enlightenment.org/elementary/1.15.0/group__Conformant.html
692         https://docs.enlightenment.org/elementary/1.15.0/conformant_example.html
693
694         * MiniBrowser/efl/main.c:
695         (window_create): pack a box into conformant widget.
696
697 2016-02-02  Alejandro G. Castro  <alex@igalia.com>
698
699         [GTK][EFL] Upgrade OpenWebRTC dependency
700         https://bugs.webkit.org/show_bug.cgi?id=153489
701
702         Reviewed by Philippe Normand.
703
704         * Scripts/run-gtk-tests:
705         (TestRunner): Avoid running the mediastream API test.
706         * Scripts/webkitperl/FeatureList.pm: Stop compiling mediastream by
707         default for gtk and efl.
708         * gtk/jhbuild-webrtc.modules: Added modules files with
709         dependencies required to compile and test the mediastream.
710
711 2016-02-01  Jason Marcell  <jmarcell@apple.com>
712
713         Add code to parse the git branches out of the Trac RSS feed
714         https://bugs.webkit.org/show_bug.cgi?id=153624
715
716         Reviewed by Daniel Bates.
717
718         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
719         (Trac.prototype.commitsOnBranch): Update filter to check for Git branches.
720         (Trac.prototype._convertCommitInfoElementToObject): Parse Git branches from the Trac RSS feed. Also changed "branchName" to
721         "branches" and updated the code to work with an array instead of a string.
722         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js:
723         (MockTrac): Refactored example commits out into a constant, MockTrac.EXAMPLE_TRAC_COMMITS.
724         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/test-fixture-git-trac-rss.xml: Added. Test
725         fixture that contains XML with a Git branch.
726         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added unit test to test parsing Git
727         branches from Trac RSS feed. Also updated code to work with the new MockTrac.EXAMPLE_TRAC_COMMITS constant.
728
729 2016-02-01  Brady Eidson  <beidson@apple.com>
730
731         Add command line flag to DRT to output the number of tests completed in server mode.
732         https://bugs.webkit.org/show_bug.cgi?id=153750
733
734         Reviewed by Darin Adler.
735
736         * DumpRenderTree/mac/DumpRenderTree.mm:
737         (initializeGlobalsFromCommandLineOptions):
738         (runTestingServerLoop):
739
740 2016-02-01  Jason Marcell  <jmarcell@apple.com>
741
742         Improvements to botwatcher's dashboard unit tests.
743         https://bugs.webkit.org/show_bug.cgi?id=153621
744
745         Reviewed by Darin Adler.
746
747         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/PopoverTracker.js:
748         (PopoverTracker): Retain a reference to the PopoverTracker so that we can make assertions about it in the unit tests.
749         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js:
750         (MockTrac): Changing revision 33019 to be on a different branch so that _appendPendingRevisionCount and
751         _popoverLinesForCommitRange have to traverse commits from different branches.
752         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Changing equal to strictEqual
753         in unit test for _appendPendingRevisionCount. Also added assertions for Popover in test for
754         _revisionContentWithPopoverForIteration.
755
756 2016-02-01  Jason Marcell  <jmarcell@apple.com>
757
758         Refactor to add event listeners and start periodic updates for all trac instances.
759         https://bugs.webkit.org/show_bug.cgi?id=153609
760
761         Reviewed by Darin Adler.
762
763         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
764         (BuildbotQueueView): Adding event listeners for all trac instances.
765         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Starting periodic updates
766         for all trac instances.
767
768 2016-01-31  Darin Adler  <darin@apple.com>
769
770         Replace CaseFoldingHash with ASCIICaseInsensitiveHash
771         https://bugs.webkit.org/show_bug.cgi?id=153639
772
773         Reviewed by Filip Pizlo.
774
775         * Scripts/do-webcore-rename: Use script to do this rename.
776
777 2016-01-30  Commit Queue  <commit-queue@webkit.org>
778
779         Unreviewed, rolling out r195911.
780         https://bugs.webkit.org/show_bug.cgi?id=153723
781
782         Caused frequent assertion failures on bots (Requested by ap on
783         #webkit).
784
785         Reverted changeset:
786
787         "Replace CaseFoldingHash with ASCIICaseInsensitiveHash"
788         https://bugs.webkit.org/show_bug.cgi?id=153639
789         http://trac.webkit.org/changeset/195911
790
791 2016-01-30  Darin Adler  <darin@apple.com>
792
793         Replace CaseFoldingHash with ASCIICaseInsensitiveHash
794         https://bugs.webkit.org/show_bug.cgi?id=153639
795
796         Reviewed by Filip Pizlo.
797
798         * Scripts/do-webcore-rename: Use script to do this rename.
799
800 2016-01-30  Ryosuke Niwa  <rniwa@webkit.org>
801
802         TouchList should be retargeted
803         https://bugs.webkit.org/show_bug.cgi?id=149592
804
805         Reviewed by Antti Koivisto.
806
807         Added touchDownAtPoint and liftUpAtPoint to UIScriptController so that we can test touch events with
808         multiple touch targets on iOS. fast/shadow-dom/touch-event-ios.html uses this new testing feature.
809
810         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
811         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
812         (WTR::UIScriptController::touchDownAtPoint): Added.
813         (WTR::UIScriptController::liftUpAtPoint): Added.
814         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
815         * WebKitTestRunner/ios/HIDEventGenerator.h:
816         * WebKitTestRunner/ios/HIDEventGenerator.mm:
817         (-[HIDEventGenerator touchDown:touchCount:completionBlock:]): Added. Sends touch down and waits.
818         (-[HIDEventGenerator liftUp:touchCount:completionBlock:]): Ditto for lift up.
819         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
820         (WTR::UIScriptController::touchDownAtPoint): Added.
821         (WTR::UIScriptController::liftUpAtPoint): Added.
822
823 2016-01-30  Yusuke Suzuki  <utatane.tea@gmail.com>
824
825         Enable SamplingProfiler on POSIX environment
826         https://bugs.webkit.org/show_bug.cgi?id=153584
827
828         Reviewed by Michael Saboff.
829
830         * Scripts/run-jsc-stress-tests:
831
832 2016-01-29  Nikos Andronikos  <nikos.andronikos-webkit@cisra.canon.com.au>
833
834         update-webkit-dependency fails to fetch updates through firewall on Windows
835         https://bugs.webkit.org/show_bug.cgi?id=153619
836
837         Reviewed by Myles C. Maxfield.
838
839         On Windows, when a firewall is present we need to read proxy settings
840         from environment variables.
841
842         This patch relies on the following environment variables being set:
843         HTTP_PROXY
844         HTTPS_PROXY
845
846         * Scripts/update-webkit-dependency:
847
848 2016-01-28  Dan Bernstein  <mitz@apple.com>
849
850         [Cocoa] Use the non-Development variants of XPC services for development
851         https://bugs.webkit.org/show_bug.cgi?id=152545
852
853         Reviewed by Darin Adler.
854
855         * Scripts/webkitdirs.pm:
856         (setUpGuardMallocIfNeeded): Ensure that libgmalloc is loaded into XPC services as well.
857
858         * Scripts/webkitpy/port/driver.py:
859         (Driver._setup_environ_for_driver): Ensure that the DYLD_LIBRARY_PATH and ASAN_OPTIONS are
860           set in the XPC services as well.
861
862         * Scripts/webkitpy/port/ios.py:
863         (IOSSimulatorPort.setup_environ_for_server): Ensure that malloc stack logging for leaks and
864           Guard Malloc are enabled in XPC services as well.
865
866         * Scripts/webkitpy/port/mac.py:
867         (MacPort.setup_environ_for_server): Ditto.
868
869 2016-01-28  Csaba Osztrogonác  <ossy@webkit.org>
870
871         Unreviewed buildfix after r195743.
872
873         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
874         (WTR::AccessibilityUIElement::isPressActionSupported):
875
876 2016-01-12  Jer Noble  <jer.noble@apple.com>
877
878         Custom protocol loading through AVFoundation does not support byte-range requests.
879         https://bugs.webkit.org/show_bug.cgi?id=152919
880         <rdar://problem/23664657>
881
882         Reviewed by Alex Christensen.
883
884         Add tests for new ParsedContntRange class.
885
886         * TestWebKitAPI/PlatformWin.cmake:
887         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
888         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
889         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
890         * TestWebKitAPI/Tests/WebCore/ParsedContentRange.cpp: Added.
891         (TestWebKitAPI::TEST):
892
893 2016-01-28  Konstantin Tokarev  <annulen@yandex.ru>
894
895         Use isAnyWindows() instead of isCygwin() || isWindows() in Perl scripts.
896         https://bugs.webkit.org/show_bug.cgi?id=153594
897
898         Reviewed by Alex Christensen.
899
900         * Scripts/webkitdirs.pm:
901         (determineNumberOfCPUs):
902         (jscPath):
903         (checkFrameworks):
904         (setupCygwinEnv):
905         (wrapperPrefixIfNeeded):
906         (cmakeGeneratedBuildfile):
907         (generateBuildSystemFromCMakeProject):
908         * Scripts/webkitperl/features.pm:
909         (libraryContainsSymbol):
910
911 2016-01-28  Chris Dumez  <cdumez@apple.com>
912
913         Unreviewed, rolling out r195742.
914
915         Broke EWS
916
917         Reverted changeset:
918
919         "[webkitdirs] Clarify logic behind is{PortName} functions."
920         https://bugs.webkit.org/show_bug.cgi?id=153554
921         http://trac.webkit.org/changeset/195742
922
923 2016-01-28  Darin Adler  <darin@apple.com>
924
925         Remove equalIgnoringCase since all callers really wanted equalIgnoringASCIICase
926         https://bugs.webkit.org/show_bug.cgi?id=153411
927
928         Reviewed by Ryosuke Niwa.
929
930         * Scripts/do-webcore-rename: Removed rename of equalIgnoringCase since we
931         have removed the function instead.
932
933         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
934         (TestWebKitAPI::TEST): Updated test since nullptr is now ambiguous since we
935         added overloads for const char*.
936
937         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
938         (WTR::AccessibilityUIElement::isPressActionSupported): Use equalLettersIgnoringASCIICase.
939         (WTR::AccessibilityUIElement::hasPopup): Ditto.
940         * WebKitTestRunner/cocoa/CrashReporterInfo.mm:
941         (WTR::testPathFromURL): Ditto.
942
943 2016-01-28  Konstantin Tokarev  <annulen@yandex.ru>
944
945         [webkitdirs] Clarify logic behind is{PortName} functions.
946         https://bugs.webkit.org/show_bug.cgi?id=153554
947
948         Reviewed by Darin Adler.
949
950         * Scripts/webkitdirs.pm:
951         (determinePortName): Added new function which decides which port are
952         we building based on command line switches and platform defaults.
953         (portName): Added getter for determined $portName.
954         (isEfl): Modified to use portName().
955         (isGtk): Ditto.
956         (isWinCairo): Ditto.
957         (isAppleMacWebKit): Ditto.
958         (isAppleWinWebKit): Ditto.
959         (isIOSWebKit): Ditto.
960         (cmakeBasedPortName): Code replaced with portName() call.
961         (determineIsEfl): Deleted.
962         (determineIsGtk): Deleted.
963         (determineIsWinCairo): Deleted.
964
965 2016-01-28  Konstantin Tokarev  <annulen@yandex.ru>
966
967         [webkitdirs] Don't pass cmakeBasedPortName around.
968         https://bugs.webkit.org/show_bug.cgi?id=153589
969
970         Reviewed by Darin Adler.
971
972         It should be local function of webkitdirs.pm instead.
973
974         * Scripts/build-jsc: Don't pass cmakeBasedPortName to
975         buildCMakeProjectOrExit().
976         * Scripts/build-webkit: Don't pass cmakeBasedPortName to
977         buildCMakeProjectOrExit() and generateBuildSystemFromCMakeProject().
978         * Scripts/run-efl-tests: Don't pass cmakeBasedPortName to
979         generateBuildSystemFromCMakeProject().
980         * Scripts/webkitdirs.pm: Don't export cmakeBasedPortName.
981         (generateBuildSystemFromCMakeProject): Removed $port argument as we
982         can get it from cmakeBasedPortName().
983         (buildCMakeProjectOrExit): Ditto.
984
985 2016-01-28  Gwang Yoon Hwang  <yoon@igalia.com>
986
987         [GStreamer] Clean up includes and headers related with GStreamerGL
988         https://bugs.webkit.org/show_bug.cgi?id=153590
989
990         Reviewed by Philippe Normand.
991
992         * Scripts/webkitpy/style/checker.py: Skips
993         include_order check for MediaPlayerPrivateGStreamerBase.cpp
994         Removes VideoSinkGStreamer1.cpp which doesn't exist anymore.
995
996 2016-01-27  Krzysztof Czech  <k.czech@samsung.com>
997
998         [EFL] Remove unused accessibility related code
999         https://bugs.webkit.org/show_bug.cgi?id=153543
1000
1001         Reviewed by Darin Adler.
1002
1003         Removed reference to EAIL library.
1004         It not going to be support anymore. There have been changes in
1005         EFL/Elementary in terms of the accessibility and we should
1006         follow those.
1007
1008         * efl/jhbuild-optional.modules:
1009
1010 2016-01-27  Daniel Bates  <dabates@apple.com>
1011
1012         Remove WebKitSystemInterface for iOS SDK < 9
1013         https://bugs.webkit.org/show_bug.cgi?id=153570
1014
1015         Reviewed by Andy Estes.
1016
1017         * Scripts/copy-webkitlibraries-to-product-directory:
1018
1019 2016-01-27  Jason Marcell  <jmarcell@apple.com>
1020
1021         Fix bugs caused by incorrect usage of "branch" vs. "branchName".
1022         https://bugs.webkit.org/show_bug.cgi?id=153330
1023
1024         Reviewed by Daniel Bates.
1025
1026         In an earlier patch we started using the name "branch" to indicate a branch object, whereas
1027         "branchName" implies that the variable or property in question is simply a string. We fixed some
1028         inconsistencies regarding this issue in 152982 but further bugs and inconsistencies were recently
1029         spotted in BuildbotQueueView.js.
1030
1031         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1032         (BuildbotQueueView.prototype._popoverLinesForCommitRange): Change branchName to branch in method signature.
1033         Changed branchName to branch.name in call to commitsOnBranch.
1034         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Change branch.name to branch in call to
1035         _popoverLinesForCommitRange.
1036         (BuildbotQueueView.prototype._presentPopoverForRevisionRange): Changed context.branchName to context.branch.name.
1037         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Changed branch.name to branch.
1038         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added tests to verify
1039         fix.
1040
1041 2016-01-27  Ryosuke Niwa  <rniwa@webkit.org>
1042
1043         Add API to access closed shadowRoot in InjectedBundle
1044         https://bugs.webkit.org/show_bug.cgi?id=153533
1045
1046         Reviewed by Antti Koivisto.
1047
1048         Added WebKit2 API test for WKBundleScriptWorldMakeAllShadowRootsOpen.
1049
1050         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1051         * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen.cpp: Added.
1052         (TestWebKitAPI::runJavaScriptAlert):
1053         (TestWebKitAPI::TEST):
1054         * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakrAllShadowRootOpen_Bundle.cpp: Added.
1055         (TestWebKitAPI::InjectedBundleMakrAllShadowRootOpenTest::InjectedBundleMakrAllShadowRootOpenTest):
1056         (TestWebKitAPI::InjectedBundleMakrAllShadowRootOpenTest::initialize):
1057
1058 2016-01-27  Jason Marcell  <jmarcell@apple.com>
1059
1060         Refactor logic for parsing Trac revisions into its own function and add logic for parsing git hashes.
1061         https://bugs.webkit.org/show_bug.cgi?id=153332
1062
1063         Reviewed by Alexey Proskuryakov.
1064
1065         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
1066         (Trac.prototype._xmlTimelineURL): Uses new function.
1067         (Trac.prototype._parseRevisionFromURL): Added. Pulled out logic for parsing revisions from a URL. Also added
1068         logic for parsing git hashes.
1069         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added tests for
1070         Trac._parseRevisionFromURL.
1071
1072 2016-01-27  Alexey Proskuryakov  <ap@apple.com>
1073
1074         Remove Mavericks from the flakiness dashboard
1075         https://bugs.webkit.org/show_bug.cgi?id=153521
1076
1077         Reviewed by Dan Bernstein.
1078
1079         * TestResultServer/static-dashboards/builders.jsonp:
1080         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1081
1082 2016-01-27  Alexey Proskuryakov  <ap@apple.com>
1083
1084         Remove ENABLE_CURRENTSRC
1085         https://bugs.webkit.org/show_bug.cgi?id=153545
1086
1087         Reviewed by Simon Fraser.
1088
1089         * Scripts/webkitperl/FeatureList.pm:
1090
1091 2016-01-26  Jason Marcell  <jmarcell@apple.com>
1092
1093         Sort incoming commits via date instead of revision number.
1094         https://bugs.webkit.org/show_bug.cgi?id=153467
1095
1096         Reviewed by Alexey Proskuryakov.
1097
1098         Future Trac instances may use Git or other revision control systems where we cannnot rely on the revision number
1099         for sorting revisions. Instead we use the commit date to sort revisions chronologically.
1100
1101         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
1102         (Trac.prototype._loaded): Sort via date instead of revision number.
1103         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js:
1104         (MockTrac): Fix up the mock data to look more like real-world data.
1105         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/test-fixture-trac-rss.xml: Added.
1106         Fake RSS feed that adds three more commits.
1107         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added unit tests to test
1108         Trac._loaded().
1109
1110 2016-01-26  I-Ting Liu  <iting_liu@apple.com>
1111
1112         Add a test for WebKit::stringMatchesWildcardString.
1113         https://bugs.webkit.org/show_bug.cgi?id=153090
1114
1115         Reviewed by Darin Adler.
1116
1117         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1118         Add the file to the project.
1119
1120         * TestWebKitAPI/Tests/WebKit2/mac/StringUtilities.mm: Added.
1121         (TestWebKitAPI::TEST):
1122         Test that a string matches another string that may contain wildcard characters.
1123
1124 2016-01-26  Konstantin Tokarev  <annulen@yandex.ru>
1125
1126         [webkitdirs] Removed check for bison, gperf, and flex.
1127         https://bugs.webkit.org/show_bug.cgi?id=153496
1128
1129         Reviewed by Alex Christensen.
1130
1131         This prerequisites are checked in WebKitCommon.cmake and don't
1132         have to be in $PATH.
1133
1134         * Scripts/webkitdirs.pm:
1135         (checkRequiredSystemConfig):
1136
1137 2016-01-26  Konstantin Tokarev  <annulen@yandex.ru>
1138
1139         [webkitdirs] isCMakeBuild should be true by default
1140         https://bugs.webkit.org/show_bug.cgi?id=153497
1141
1142         Reviewed by Michael Catanzaro.
1143
1144         * Scripts/webkitdirs.pm:
1145         (isCMakeBuild):
1146
1147 2016-01-26  Daniel Bates  <dabates@apple.com>
1148
1149         Add WebKitSystemInterface for iOS 9.2
1150         https://bugs.webkit.org/show_bug.cgi?id=153355
1151
1152         Rubber-stamped by David Kilzer.
1153
1154         * Scripts/copy-webkitlibraries-to-product-directory:
1155
1156 2016-01-26  Daniel Bates  <dabates@apple.com>
1157
1158         WebKitTestRunner: Credential cache is not cleared between tests
1159         https://bugs.webkit.org/show_bug.cgi?id=153407
1160         <rdar://problem/24280834>
1161
1162         Reviewed by Alexey Proskuryakov.
1163
1164         * WebKitTestRunner/TestController.cpp:
1165         (WTR::TestController::resetStateToConsistentValues): Call WKContextClearCachedCredentials()
1166         to clear cached credentials.
1167
1168 2016-01-26  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1169
1170         kill-old-processes: allow to specify on the environment of the bot a list of process that should be killed.
1171         https://bugs.webkit.org/show_bug.cgi?id=153483
1172
1173         Reviewed by Csaba Osztrogonác.
1174
1175         * BuildSlaveSupport/kill-old-processes:
1176         (main): Allow to specify extra tasks to kill via the environment variable WEBKITBOT_TASKSTOKILL
1177
1178 2016-01-25  Simon Fraser  <simon.fraser@apple.com>
1179
1180         Give the layout test results file a <title> showing the date and time the tests were run
1181         https://bugs.webkit.org/show_bug.cgi?id=153187
1182
1183         Reviewed by Darin Adler.
1184         
1185         Include a 'date' property in the JSON with the date and time the tests completed.
1186
1187         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1188         (summarize_results):
1189
1190 2016-01-25  Commit Queue  <commit-queue@webkit.org>
1191
1192         Unreviewed, rolling out r195543.
1193         https://bugs.webkit.org/show_bug.cgi?id=153451
1194
1195         regressed performance of test bots by ~6% (Requested by dydz
1196         on #webkit).
1197
1198         Reverted changeset:
1199
1200         "WebKitTestRunner: Credential cache is not cleared between
1201         tests"
1202         https://bugs.webkit.org/show_bug.cgi?id=153407
1203         http://trac.webkit.org/changeset/195543
1204
1205 2016-01-25  Aakash Jain  <aakash_jain@apple.com>
1206
1207         Failing to upload to flakiness dashboard should not be a hard error
1208         https://bugs.webkit.org/show_bug.cgi?id=153444
1209         <rdar://problem/22146294>
1210
1211         Reviewed by Alexey Proskuryakov.
1212
1213         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1214         (Manager._upload_json_files): If JSON file is not generated, do not try to upload it.
1215
1216 2016-01-25  Daniel Bates  <dabates@apple.com>
1217
1218         WebKitTestRunner: Credential cache is not cleared between tests
1219         https://bugs.webkit.org/show_bug.cgi?id=153407
1220         <rdar://problem/24280834>
1221
1222         Reviewed by Brady Eidson.
1223
1224         * WebKitTestRunner/TestController.cpp:
1225         (WTR::TestController::resetStateToConsistentValues): Reset testing network session
1226         to clear cached credentials.
1227
1228 2016-01-24  Dan Bernstein  <mitz@apple.com>
1229
1230         Added project.xcworkspace and xcuserdata to this project’s svn:ignore.
1231
1232         * LayoutTestRelay/LayoutTestRelay.xcodeproj: Added property svn:ignore.
1233
1234 2016-01-22  Enrica Casucci  <enrica@apple.com>
1235
1236         Unreviewed build fix after http://trac.webkit.org/changeset/195474.
1237
1238         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1239         (WTR::TestController::platformCreateWebView):
1240
1241 2016-01-22  Tim Horton  <timothy_horton@apple.com>
1242
1243         Add a test for iOS arrow-key repeat
1244         https://bugs.webkit.org/show_bug.cgi?id=152857
1245         <rdar://problem/24017380>
1246
1247         Reviewed by Darin Adler.
1248
1249         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
1250         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
1251         (WTR::UIScriptController::keyUpUsingHardwareKeyboard):
1252         (WTR::UIScriptController::keyDownUsingHardwareKeyboard):
1253         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
1254         * WebKitTestRunner/ios/HIDEventGenerator.h:
1255         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1256         (-[HIDEventGenerator keyPress:completionBlock:]):
1257         (-[HIDEventGenerator keyDown:completionBlock:]):
1258         (-[HIDEventGenerator keyUp:completionBlock:]):
1259         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1260         (WTR::UIScriptController::typeCharacterUsingHardwareKeyboard):
1261         (WTR::UIScriptController::keyDownUsingHardwareKeyboard):
1262         (WTR::UIScriptController::keyUpUsingHardwareKeyboard):
1263         Make it possible to independently send keyUp/keyDown, instead of just paired.
1264
1265 2016-01-22  Tim Horton  <timothy_horton@apple.com>
1266
1267         Reproducible "Unhanded web process message 'WebUserContentController:AddUserScripts'" and friends
1268         https://bugs.webkit.org/show_bug.cgi?id=153193
1269         <rdar://problem/24222034>
1270
1271         Reviewed by Darin Adler.
1272
1273         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
1274         (webViewForScriptMessageHandlerMultipleHandlerRemovalTest):
1275         (TEST):
1276         Add a test that exhibits the problems we're fixing here.
1277         Before, it would both log and assert in debug, and crash in release.
1278         Now it runs happily to completion.
1279
1280 2016-01-22  Enrica Casucci  <enrica@apple.com>
1281
1282         Add support for testing data detection.
1283         https://bugs.webkit.org/show_bug.cgi?id=153360
1284
1285         Reviewed by Tim Horton.
1286
1287         Adding a new testing option (useDataDetection) to turn on
1288         data detection when running the a test.
1289
1290         * WebKitTestRunner/TestController.cpp:
1291         (WTR::updateTestOptionsFromTestHeader):
1292         * WebKitTestRunner/TestOptions.h:
1293         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1294         (WTR::TestController::platformCreateWebView):
1295
1296 2016-01-21  Simon Fraser  <simon.fraser@apple.com>
1297
1298         Fix the lldb WebCoreLayoutUnitProvider to not dynamically look up the LayoutUnit denominator
1299         https://bugs.webkit.org/show_bug.cgi?id=153334
1300
1301         Reviewed by Zalan Bujtas.
1302         
1303         Evaluating expressions in the LayoutUnit summary provider seems to cause
1304         re-entrancy problems in lldb python bindings, so just hardcode the LayoutUnit
1305         denominator to 64.
1306
1307         * lldb/lldb_webkit.py:
1308         (WebCoreLayoutUnitProvider.to_string):
1309
1310 2016-01-21  Filip Pizlo  <fpizlo@apple.com>
1311
1312         display-profiler-output should be able to display code blocks sorted by machine counts
1313         https://bugs.webkit.org/show_bug.cgi?id=153298
1314
1315         Reviewed by Oliver Hunt.
1316
1317         * Scripts/display-profiler-output:
1318
1319 2016-01-21  Julien Isorce  <j.isorce@samsung.com>
1320
1321         Ensure to use compatible liborc version with wanted gstreamer version
1322         https://bugs.webkit.org/show_bug.cgi?id=153276
1323
1324         For example gst-plugins-base-1.4.4 fails to build with liborc-0.4.24.
1325         The user may have a very recent liborc installed on his system.
1326
1327         Reviewed by Philippe Normand.
1328
1329         * efl/jhbuild.modules: add liborc-0.4.17 and make it a gst dependency.
1330         * gtk/jhbuild.modules: add liborc-0.4.17 and make it a gst depencendy.
1331
1332 2016-01-21  Nan Wang  <n_wang@apple.com>
1333
1334         AX: [IOS] Implement next/previous text marker functions using TextIterator
1335         https://bugs.webkit.org/show_bug.cgi?id=153292
1336         <rdar://problem/24268243>
1337
1338         Reviewed by Chris Fleizach.
1339
1340         Made text marker tests available on iOS.
1341
1342         * DumpRenderTree/AccessibilityTextMarker.h:
1343         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1344         * DumpRenderTree/ios/AccessibilityTextMarkerIOS.mm: Added.
1345         (AccessibilityTextMarker::AccessibilityTextMarker):
1346         (AccessibilityTextMarker::~AccessibilityTextMarker):
1347         (AccessibilityTextMarker::isEqual):
1348         (AccessibilityTextMarker::platformTextMarker):
1349         (AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
1350         (AccessibilityTextMarkerRange::~AccessibilityTextMarkerRange):
1351         (AccessibilityTextMarkerRange::isEqual):
1352         (AccessibilityTextMarkerRange::platformTextMarkerRange):
1353         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1354         (AccessibilityUIElement::pathDescription):
1355         (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
1356         (AccessibilityUIElement::textMarkerRangeForElement):
1357         (AccessibilityUIElement::selectedTextMarkerRange):
1358         (AccessibilityUIElement::resetSelectedTextMarkerRange):
1359         (AccessibilityUIElement::textMarkerRangeLength):
1360         (AccessibilityUIElement::textMarkerRangeForMarkers):
1361         (AccessibilityUIElement::startTextMarkerForTextMarkerRange):
1362         (AccessibilityUIElement::endTextMarkerForTextMarkerRange):
1363         (AccessibilityUIElement::accessibilityElementForTextMarker):
1364         (AccessibilityUIElement::endTextMarkerForBounds):
1365         (AccessibilityUIElement::startTextMarkerForBounds):
1366         (AccessibilityUIElement::textMarkerForPoint):
1367         (AccessibilityUIElement::previousTextMarker):
1368         (AccessibilityUIElement::nextTextMarker):
1369         (AccessibilityUIElement::stringForTextMarkerRange):
1370         (AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
1371         (AccessibilityUIElement::indexForTextMarker):
1372         (AccessibilityUIElement::isTextMarkerValid):
1373         (AccessibilityUIElement::textMarkerForIndex):
1374         (AccessibilityUIElement::startTextMarker):
1375         (AccessibilityUIElement::endTextMarker):
1376         (AccessibilityUIElement::setSelectedVisibleTextRange):
1377         (AccessibilityUIElement::getLinkedUIElements):
1378         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
1379         (AccessibilityTextMarkerRange::platformTextMarkerRange):
1380         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1381         (AccessibilityUIElement::removeSelection):
1382         (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
1383         (AccessibilityUIElement::setSelectedVisibleTextRange):
1384         (AccessibilityUIElement::supportedActions):
1385         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1386         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
1387         (WTR::AccessibilityUIElement::textMarkerRangeLength):
1388         (WTR::AccessibilityUIElement::previousTextMarker):
1389         (WTR::AccessibilityUIElement::nextTextMarker):
1390         (WTR::AccessibilityUIElement::stringForTextMarkerRange):
1391         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
1392         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
1393         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
1394         (WTR::AccessibilityUIElement::endTextMarkerForBounds):
1395         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
1396         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
1397
1398 2016-01-20  Filip Pizlo  <fpizlo@apple.com>
1399
1400         Unreviewed, revert accidental unreviewed commit.
1401
1402         * Scripts/display-profiler-output:
1403
1404 2016-01-20  Jason Marcell  <jmarcell@apple.com>
1405
1406         Refactor compareIterations to remove duplicate code.
1407         https://bugs.webkit.org/show_bug.cgi?id=152913
1408
1409         Reviewed by Daniel Bates.
1410
1411         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1412         (BuildbotQueue.prototype.compareIterations): Refactored to remove duplicate code.
1413         (BuildbotQueue.prototype.sortIterations): Add binding to call to compareIterations.
1414         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added tests in order to ensure
1415         the same behavior before and after refactor.
1416
1417 2016-01-20  Dana Burkart  <dburkart@apple.com>
1418
1419         Botwatcher's dashboard should show an 'X' when the build is broken
1420         https://bugs.webkit.org/show_bug.cgi?id=152507
1421
1422         Reviewed by David Kilzer.
1423
1424         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotStaticAnalyzerQueueView.js:
1425         (BuildbotStaticAnalyzerQueueView.prototype.appendStaticAnalyzerQueueStatus):
1426         (BuildbotStaticAnalyzerQueueView.prototype.update):
1427
1428 2016-01-19  Jason Marcell  <jmarcell@apple.com>
1429
1430         Remove assertion from revisionContentForIteration that is causing errors on the dashboard.
1431         https://bugs.webkit.org/show_bug.cgi?id=153262
1432
1433         Reviewed by Alexey Proskuryakov.
1434
1435         Occasionaly some buildbot iterations will not have their "got_revisions" property populated. In
1436         such cases this revisionContentForIteration method does not have any content to return, thus the
1437         assertion fails.
1438
1439         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1440         (BuildbotQueueView.prototype.revisionContentForIteration): Removed assertion that was causing errors.
1441
1442 2016-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1443
1444         [GTK] Runtime critical warnings when loading a URL after a session restore
1445         https://bugs.webkit.org/show_bug.cgi?id=153233
1446
1447         Reviewed by Michael Catanzaro.
1448
1449         Add new test case.
1450
1451         * TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp:
1452         (viewLoadChanged):
1453         (testWebKitWebViewNavigationAfterSessionRestore):
1454         (beforeAll):
1455
1456 2016-01-19  Michael Catanzaro  <mcatanzaro@igalia.com>
1457
1458         [GTK] Remove jhbuild-optional.modules
1459         https://bugs.webkit.org/show_bug.cgi?id=152964
1460
1461         Reviewed by Alex Christensen.
1462
1463         * gtk/jhbuild-optional.modules: Removed.
1464         * gtk/jhbuild.modules:
1465
1466 2016-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1467
1468         [GTK] Add support to load/save session in MiniBrowser
1469         https://bugs.webkit.org/show_bug.cgi?id=153201
1470
1471         Reviewed by Michael Catanzaro.
1472
1473         It makes it easier to test the new WebView session API.
1474
1475         * MiniBrowser/gtk/BrowserWindow.c:
1476         (browserWindowFinalize): Free the session file path.
1477         (browserWindowSaveSession): Save the current WebView session if
1478         there's a session file path.
1479         (browserWindowDeleteEvent): Call browserWindowSaveSession().
1480         (browser_window_load_session): Try to load the session from the
1481         given file path, otherwise fall back to homepage and keep the
1482         session file to save the session on window close.
1483         * MiniBrowser/gtk/BrowserWindow.h:
1484         * MiniBrowser/gtk/main.c:
1485         (createBrowserWindow): Pass the given session file path when
1486         shouldLoadSession is TRUE.
1487         (main): Only allow to restore/save session when MiniBrowser is
1488         launched without URL arguments.
1489
1490 2016-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1491
1492         Unreviewed. Fix GTK+ test /webkit2/WebKitWebView/geolocation-permission-requests after r195075.
1493
1494         Geolocation is no longer allowed for unique origins after r195075.
1495
1496         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
1497         (testWebViewGeolocationPermissionRequests):
1498
1499 2016-01-18  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1500
1501         [GTK][EFL] Layout tests abort with PulseAudioSanitizer instance has no attribute '_pa_module_index' when the build is not ready.
1502         https://bugs.webkit.org/show_bug.cgi?id=153216
1503
1504         Reviewed by Michael Catanzaro.
1505
1506         * Scripts/webkitpy/port/pulseaudio_sanitizer.py:
1507         (PulseAudioSanitizer.__init__): initialize _pa_module_index in the constructor.
1508
1509 2016-01-18  Nan Wang  <n_wang@apple.com>
1510
1511         AX: [Mac] Implement next/previous text marker functions using TextIterator
1512         https://bugs.webkit.org/show_bug.cgi?id=152728
1513
1514         Reviewed by Chris Fleizach.
1515
1516         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1517         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
1518
1519 2016-01-18  Csaba Osztrogonác  <ossy@webkit.org>
1520
1521         [cmake] Add testair to the build system
1522         https://bugs.webkit.org/show_bug.cgi?id=153126
1523
1524         Reviewed by Michael Catanzaro.
1525
1526         * Scripts/build-jsc:
1527
1528 2016-01-16  Myles C. Maxfield  <mmaxfield@apple.com>
1529
1530         Remove TextRun::allowsRoundingHacks()
1531         https://bugs.webkit.org/show_bug.cgi?id=153185
1532
1533         Reviewed by Simon Fraser.
1534
1535         * DumpRenderTree/mac/DumpRenderTree.mm:
1536         (resetWebViewToConsistentStateBeforeTesting): Deleted.
1537
1538 2016-01-15  Konstantin Tokarev  <annulen@yandex.ru>
1539
1540         [webkitdirs] Avoid list form of open because it broke WinCairo
1541         https://bugs.webkit.org/show_bug.cgi?id=153106
1542
1543         Reviewed by Alex Christensen.
1544
1545         * Scripts/webkitdirs.pm:
1546         (determineArchitecture):
1547
1548 2016-01-15  Simon Fraser  <simon.fraser@apple.com>
1549
1550         Add kdebug_trace signposts for a few WebCore operations
1551         https://bugs.webkit.org/show_bug.cgi?id=153136
1552         rdar://problem/24208487
1553
1554         Reviewed by Sam Weinig.
1555         
1556         Plist used by kdebug_trace() viewing tools.
1557
1558         * Tracing/SystemTracePoints.plist: Added.
1559
1560 2016-01-14  Konstantin Tokarev  <annulen@yandex.ru>
1561
1562         [webkitdirs] Replaced grep invocation with perl code
1563         https://bugs.webkit.org/show_bug.cgi?id=153106
1564
1565         Reviewed by Alex Christensen.
1566
1567         * Scripts/webkitdirs.pm:
1568         (determineArchitecture):
1569
1570 2016-01-14  Brian Burg  <bburg@apple.com>
1571
1572         prepare-changelog does not read paths containing spaces properly
1573         https://bugs.webkit.org/show_bug.cgi?id=137982
1574
1575         Reviewed by Joseph Pecoraro.
1576
1577         Escape whitespace in filenames before passing the file path to other functions.
1578
1579         * Scripts/prepare-ChangeLog:
1580         (generateFunctionLists): Use the more explicit 3-argument form of 'open'.
1581
1582 2016-01-14  Jason Marcell  <jmarcell@apple.com>
1583
1584         Standardize the usage of "branch" vs. "branchName".
1585         https://bugs.webkit.org/show_bug.cgi?id=152982
1586
1587         Reviewed by Daniel Bates.
1588
1589         In an earlier patch we started using the name "branch" to indicate a branch object, whereas
1590         "branchName" implies that the variable or property in question is simply a string.
1591
1592         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1593         (BuildbotQueueView.prototype._popoverLinesForCommitRange): Change branch to branchName.
1594         (BuildbotQueueView.prototype._presentPopoverForRevisionRange): Change branch to branch.name.
1595         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Change branch to branchName.
1596         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
1597         (Trac.prototype.commitsOnBranch): Change branch to branchName.
1598         (Trac.prototype._convertCommitInfoElementToObject): Ditto.
1599         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js:
1600         (MockTrac): Ditto.
1601
1602 2016-01-14  Jason Marcell  <jmarcell@apple.com>
1603
1604         Add a unit test to test BuildbotQueueView._appendPendingRevisionCount.
1605         https://bugs.webkit.org/show_bug.cgi?id=152910
1606
1607         Reviewed by Daniel Bates.
1608
1609         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueue.js: Added.
1610         (MockBuildbotQueue): Added. Mock BuildbotQueue object that doesn't need to talk to an actual Buildbot server.
1611         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueueView.js: Added.
1612         (MockBuildbotQueueView): Added. Mock BuildbotQueueView object that returns a pre-specified _latestProductiveIteration without
1613         the need to talk to a real Buildbot server.
1614         (MockBuildbotQueueView.prototype._latestProductiveIteration): Added. Returns a pre-specified _latestProductiveIteration
1615         without the need to talk to a real Buildbot server.
1616         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js: Added.
1617         (MockTrac): Added. Mock Trac constructor that has pre-populated "recordedCommits" and does not need to talk to a real Trac
1618         server.
1619         (MockTrac.prototype.get oldestRecordedRevisionNumber): Added. Returns a pre-specified revision.
1620         (MockTrac.prototype.get latestRecordedRevisionNumber): Ditto.
1621         (MockTrac.prototype.loadMoreHistoricalData): Added. Overrides the real loadMoreHistoricalData so that we don't waste time
1622         trying to talk to Trac.
1623         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/index.html: Added. Web page container for
1624         QUnit unit tests.
1625         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added. QUnit unit tests.
1626
1627 2016-01-14  Nikos Andronikos  <nikos.andronikos-webkit@cisra.canon.com.au>
1628
1629         [CMake][GTK] CMake Error: Could not create named generator Eclipse CDT4 - Ninja
1630         https://bugs.webkit.org/show_bug.cgi?id=132599
1631
1632         Reviewed by Michael Catanzaro.
1633
1634         Check if cmake Ninja generators are installed.
1635
1636         * Scripts/webkitdirs.pm:
1637         (canUseNinjaGenerator):
1638         (canUseEclipseNinjaGenerator):
1639         (generateBuildSystemFromCMakeProject):
1640         (canUseEclipse): Deleted.
1641
1642 2016-01-13  Myles C. Maxfield  <mmaxfield@apple.com>
1643
1644         [Cocoa] Testing with font family name "System Font" is unused
1645         https://bugs.webkit.org/show_bug.cgi?id=153073
1646         <rdar://problem/24091683>
1647
1648         Reviewed by Brent Fulgham.
1649
1650         * DumpRenderTree/mac/DumpRenderTree.mm:
1651         (allowedFontFamilySet): Deleted.
1652         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
1653         (WTR::allowedFontFamilySet): Deleted.
1654         * WebKitTestRunner/mac/TestControllerMac.mm:
1655         (WTR::allowedFontFamilySet): Deleted.
1656
1657 2016-01-13  Daniel Bates  <dabates@apple.com>
1658
1659         [XSS Auditor] Add test when XSS payload is in the path portion of the URL
1660         https://bugs.webkit.org/show_bug.cgi?id=152871
1661
1662         Reviewed by Brent Fulgham.
1663
1664         Merged from Blink (patch by Tom Sepez <tsepez@chromium.org>):
1665         <https://src.chromium.org/viewvc/blink?revision=164746&view=revision>
1666
1667         * Scripts/webkitpy/layout_tests/servers/lighttpd.conf:
1668
1669 2016-01-08  Andy Estes  <aestes@apple.com>
1670
1671         [Content Filtering] Lazily load platform frameworks
1672         https://bugs.webkit.org/show_bug.cgi?id=152881
1673         rdar://problem/23270886
1674
1675         Reviewed by Brady Eidson.
1676
1677         Added an API test that verifies that the Parental Controls and Network Extension frameworks are loaded at the
1678         expected times. The test verifies that they are not loaded after creating a WKWebView, loading an HTML string,
1679         loading NSData, loading a file, or loading from a custom protocol. It verifies that Network Extension on Mac/iOS
1680         and Parental Controls on iOS are loaded after an HTTP request. It finally verifies that Parental Controls on Mac
1681         is loaded after an HTTPS request.
1682
1683         To accomplish this, TestProtocol was generalized to allow tests to specify the scheme they wish to use.
1684         Other tests that used TestProtocol were updated to account for this change. TestProtocol was removed from
1685         WebKit2.PreventImageLoadWithAutoResizingTest, which didn't actually need to use it. ContentFiltering tests were
1686         also re-enabled on iOS after mistakenly being disabled by r188892.
1687
1688         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1689         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
1690         (TestWebKitAPI::TEST):
1691         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.h: Added.
1692         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.html: Added.
1693         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
1694         (TEST):
1695         (downloadTest):
1696         (-[LazilyLoadPlatformFrameworksController init]):
1697         (-[LazilyLoadPlatformFrameworksController webView]):
1698         (-[LazilyLoadPlatformFrameworksController expectParentalControlsLoaded:networkExtensionLoaded:]):
1699         (-[LazilyLoadPlatformFrameworksController webView:didFinishNavigation:]):
1700         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
1701         (-[ContentFilteringPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1702         (-[ContentFilteringPlugIn observeValueForKeyPath:ofObject:change:context:]):
1703         (-[ContentFilteringPlugIn checkIfPlatformFrameworksAreLoaded:]):
1704         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
1705         (TestWebKitAPI::TEST):
1706         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
1707         (TestWebKitAPI::TEST): Deleted.
1708         * TestWebKitAPI/cocoa/TestProtocol.h:
1709         * TestWebKitAPI/cocoa/TestProtocol.mm:
1710         (+[TestProtocol registerWithScheme:]):
1711         (+[TestProtocol unregister]):
1712
1713 2016-01-12  Dewei Zhu  <dewei_zhu@apple.com>
1714
1715         Fix the Sunpider converage in slow device.
1716         https://bugs.webkit.org/show_bug.cgi?id=152938
1717         <rdar://problem/22511411>
1718
1719         Reviewed by Ryosuke Niwa.
1720
1721         Updated the patch for RunBenchmark to resume sunspider coverage by removing unused subresources in sub-tests.
1722
1723         * Scripts/webkitpy/benchmark_runner/data/patches/SunSpider.patch:
1724
1725 2016-01-12  Ryosuke Niwa  <rniwa@webkit.org>
1726
1727         Add a build flag for custom element
1728         https://bugs.webkit.org/show_bug.cgi?id=153005
1729
1730         Reviewed by Alex Christensen.
1731
1732         Added --custom-elements option to enable custom elements support.
1733
1734         * Scripts/webkitperl/FeatureList.pm:
1735
1736 2016-01-12  Benjamin Poulain  <bpoulain@apple.com>
1737
1738         [JSC] Add a help message when run-jsc-stress-tests fails
1739         https://bugs.webkit.org/show_bug.cgi?id=153014
1740
1741         Reviewed by Csaba Osztrogonác.
1742
1743         * Scripts/run-jsc-stress-tests:
1744
1745 2016-01-11  Saam barati  <sbarati@apple.com>
1746
1747         run-jsc-stress-tests should try to figure out a JSC path
1748         https://bugs.webkit.org/show_bug.cgi?id=152971
1749
1750         Reviewed by Yusuke Suzuki.
1751
1752         This patch now allows run-jsc-stress-tests to be run
1753         without a "--jsc <jsc-path>" argument. It tries
1754         to take its best guess at a <jsc-path> automagically.
1755         
1756         This makes it much easier to just run run-jsc-stress-tests
1757         with a directory or a yaml file as an argument.
1758         You now just do this:
1759         `run-jsc-stress-tests <path-to-yaml>`
1760         or
1761         `run-jsc-stress-tests <path-to-directory-of-js-files>`
1762         
1763         I wrote this patch because I'd often find myself hacking the 
1764         run-javascriptcore-tests file just to run a particular subset of tests.
1765         Because I always forget the arguments to run-jsc-stress-tests (which means
1766         I always forgot to provide a --jsc argument), I always found it easier to 
1767         just hack on that file instead of calling run-jsc-stress-tests directly.
1768         No longer is this true!
1769
1770         * Scripts/run-jsc-stress-tests:
1771
1772 2016-01-09  Andy Estes  <aestes@apple.com>
1773
1774         [Cocoa] Add SPI to opt out a URL scheme from the memory cache
1775         https://bugs.webkit.org/show_bug.cgi?id=152950
1776         rdar://problem/24066652
1777
1778         Reviewed by Tim Horton.
1779
1780         Added an API test.
1781
1782         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1783         * TestWebKitAPI/Tests/WebKit2Cocoa/AlwaysRevalidatedURLSchemes.mm: Added.
1784         (+[AlwaysRevalidatedURLSchemeProtocol canInitWithRequest:]):
1785         (+[AlwaysRevalidatedURLSchemeProtocol canonicalRequestForRequest:]):
1786         (+[AlwaysRevalidatedURLSchemeProtocol requestIsCacheEquivalent:toRequest:]):
1787         (-[AlwaysRevalidatedURLSchemeProtocol startLoading]):
1788         (-[AlwaysRevalidatedURLSchemeProtocol stopLoading]):
1789         (-[AlwaysRevalidatedURLSchemesDelegate webView:didFinishNavigation:]):
1790         (TEST):
1791
1792 2016-01-11  Commit Queue  <commit-queue@webkit.org>
1793
1794         Unreviewed, rolling out r194866.
1795         https://bugs.webkit.org/show_bug.cgi?id=152986
1796
1797         This change broke the mac build (Requested by ryanhaddad on
1798         #webkit).
1799
1800         Reverted changeset:
1801
1802         "[Cocoa] Add SPI to opt out a URL scheme from the memory
1803         cache"
1804         https://bugs.webkit.org/show_bug.cgi?id=152950
1805         http://trac.webkit.org/changeset/194866
1806
1807 2016-01-11  Andy Estes  <aestes@apple.com>
1808
1809         [Cocoa] Add SPI to opt out a URL scheme from the memory cache
1810         https://bugs.webkit.org/show_bug.cgi?id=152950
1811         rdar://problem/24066652
1812
1813         Reviewed by Tim Horton.
1814
1815         Added an API test.
1816
1817         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1818         * TestWebKitAPI/Tests/WebKit2Cocoa/AlwaysRevalidatedURLSchemes.mm: Added.
1819         (+[AlwaysRevalidatedURLSchemeProtocol canInitWithRequest:]):
1820         (+[AlwaysRevalidatedURLSchemeProtocol canonicalRequestForRequest:]):
1821         (+[AlwaysRevalidatedURLSchemeProtocol requestIsCacheEquivalent:toRequest:]):
1822         (-[AlwaysRevalidatedURLSchemeProtocol startLoading]):
1823         (-[AlwaysRevalidatedURLSchemeProtocol stopLoading]):
1824         (-[AlwaysRevalidatedURLSchemesDelegate webView:didFinishNavigation:]):
1825         (TEST):
1826
1827 2016-01-11  Konstantin Tokarev  <annulen@yandex.ru>
1828
1829         [webkitdirs] Use CMake to determine architecture on isCMakeBuild()
1830         https://bugs.webkit.org/show_bug.cgi?id=152959
1831
1832         Reviewed by Brent Fulgham.
1833
1834         * Scripts/webkitdirs.pm:
1835         (determineArchitecture):
1836
1837 2016-01-11  Michael Catanzaro  <mcatanzaro@igalia.com>
1838
1839         [GTK] W3C CSS2.1 anonymous table tests are failing
1840         https://bugs.webkit.org/show_bug.cgi?id=152455
1841
1842         Reviewed by Mario Sanchez Prada.
1843
1844         Add shared-mime-info to the jhbuild environment, since it affects the results of layout
1845         tests. Add upstream patches to fix detection of XHTML files.
1846
1847         * gtk/jhbuild.modules:
1848         * gtk/patches/shared-mime-info-xht-glob.patch: Added.
1849         * gtk/patches/shared-mime-info-xhtml-magic.patch: Added.
1850
1851 2016-01-10  Saam barati  <sbarati@apple.com>
1852
1853         Implement a sampling profiler
1854         https://bugs.webkit.org/show_bug.cgi?id=151713
1855
1856         Reviewed by Filip Pizlo.
1857
1858         * Scripts/run-jsc-stress-tests:
1859
1860 2016-01-10  Konstantin Tokarev  <annulen@yandex.ru>
1861
1862         [webkitdirs] Try arch and uname commands on non-windows OS
1863         https://bugs.webkit.org/show_bug.cgi?id=152958
1864
1865         Reviewed by Michael Catanzaro.
1866
1867         Right now, determineArchitecture()  uses `arch` and `uname -m`
1868         commands to determine architecture in case of condition (isGtk() ||
1869         isAppleMacWebKit() || isEfl()) is true. This should be !anyWindows()
1870         instead, because this code is applicable to any non-windows OS WebKit
1871         supports (even Haiku which once was supported is moderately
1872         POSIX-compliant and has uname command).
1873
1874         * Scripts/webkitdirs.pm:
1875         (determineArchitecture):
1876
1877 2016-01-08  Aakash Jain  <aakash_jain@apple.com>
1878
1879         run-webkit-tests mis-counts totals when there are other crashes
1880         https://bugs.webkit.org/show_bug.cgi?id=152894
1881         <rdar://problem/24098697>
1882
1883         Reviewed by Alexey Proskuryakov.
1884
1885         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1886         (TestRunResults.add): Do not update result counters for other crashes.
1887
1888 2016-01-08  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1889
1890         webkit-patch build-and-test should have an option to iterate over new tests
1891         https://bugs.webkit.org/show_bug.cgi?id=143093
1892
1893         Reviewed by Michael Catanzaro.
1894
1895         This patch introduces the --iterate-on-new-tests option to webkit-patch build-and-test.
1896         It allows running run-webkit-tests on modified or new paths in LayoutTests.
1897         Computation of new or modified tests is done by LayoutTestFinder.find_touched_tests
1898         It implements the translation of -expected.* paths to their related tests.
1899         It also implements the removal of skipped tests.
1900
1901         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
1902         (LayoutTestFinder.find_touched_tests):
1903         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py: Added.
1904         (MockPort):
1905         (MockPort.__init__):
1906         (MockPort.tests):
1907         (LayoutTestFinderTests):
1908         (LayoutTestFinderTests.touched_files):
1909         (LayoutTestFinderTests.test_touched_test):
1910         (LayoutTestFinderTests.test_expected_touched_test):
1911         (LayoutTestFinderTests.test_platform_expected_touched_test):
1912         (LayoutTestFinderTests.test_platform_duplicate_touched_test):
1913         (LayoutTestFinderTests.test_touched_but_skipped_test):
1914         * Scripts/webkitpy/port/base.py:
1915         (Port.potential_test_names_from_expected_file):
1916         * Scripts/webkitpy/tool/commands/download_unittest.py:
1917         (DownloadCommandsTest._default_options):
1918         * Scripts/webkitpy/tool/steps/options.py:
1919         (Options):
1920         * Scripts/webkitpy/tool/steps/runtests.py:
1921         (RunTests.options):
1922         (RunTests.run):
1923         (RunTests):
1924         (RunTests._new_or_modified_tests):
1925         (RunTests._run_webkit_tests):
1926         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
1927         (RunTestsTest.test_webkit_run_unit_tests):
1928         * Scripts/webkitpy/tool/steps/steps_unittest.py:
1929         (StepsTest._step_options):
1930
1931 2016-01-07  Joseph Pecoraro  <pecoraro@apple.com>
1932
1933         prepare-ChangeLog should include radar number
1934         https://bugs.webkit.org/show_bug.cgi?id=152839
1935         <rdar://problem/24093563>
1936
1937         Reviewed by Daniel Bates.
1938
1939         When running `prepare-ChangeLog -b ###`, check for a bugzilla comment that
1940         starts with a "<rdar://problem/####>" URL. If found, include that radar URL
1941         in the ChangeLog description after the bug URL.
1942
1943         * Scripts/prepare-ChangeLog:
1944         (main): Update signatures.
1945         (fetchBugXMLData): XML Data is now used for multiple reasons. Extract this to just get the data.
1946         (fetchBugDescriptionFromBugXMLData): Search data for <short_desc>.
1947         (fetchRadarURLFromBugXMLData): Search comment text for radar URL.
1948         (generateNewChangeLogs): Include radar URL if we found one.
1949
1950         * Scripts/webkitperl/prepare-ChangeLog_unittest/fetchRadarURLFromBugXMLData.pl: Added.
1951         Tests for the radar URL extraction.
1952
1953 2016-01-07  Alexey Proskuryakov  <ap@apple.com>
1954
1955         testRunner.runUIScript crashes while running multiple tests in a row that invokes the same UIScript
1956         https://bugs.webkit.org/show_bug.cgi?id=152390
1957         <rdar://problem/23948321>
1958
1959         Reviewed by Simon Fraser.
1960
1961         Fix two use-after-frees.
1962
1963         1. WKPageCallAfterNextPresentationUpdate's callback has a pointer to TestInvocation,
1964         but we may have already progressed to another test by the time the callback fires,
1965         having destroyed the TestInvocation.
1966         2. UIScriptController is a RefCounted object, but it has a raw pointer to
1967         UIScriptContext which has the same lifetime as a TestInvocation.
1968         As a result, completion blocks of UIScriptController actions would use a destroyed
1969         TestInvocation.
1970
1971         * WebKitTestRunner/TestInvocation.cpp:
1972         (WTR::TestInvocation::~TestInvocation):
1973         (WTR::TestInvocation::url):
1974         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1975         (WTR::TestInvocation::runUISideScriptAfterUpdateCallback):
1976         (WTR::TestInvocation::runUISideScript):
1977         * WebKitTestRunner/TestInvocation.h:
1978         * WebKitTestRunner/UIScriptContext/UIScriptContext.cpp:
1979         (UIScriptContext::UIScriptContext):
1980         (UIScriptContext::~UIScriptContext):
1981         (UIScriptContext::runUIScript):
1982         * WebKitTestRunner/UIScriptContext/UIScriptContext.h:
1983         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
1984         (WTR::UIScriptController::UIScriptController):
1985         (WTR::UIScriptController::contextDestroyed):
1986         (WTR::UIScriptController::makeWindowObject):
1987         (WTR::UIScriptController::setWillBeginZoomingCallback):
1988         (WTR::UIScriptController::willBeginZoomingCallback):
1989         (WTR::UIScriptController::setDidEndZoomingCallback):
1990         (WTR::UIScriptController::didEndZoomingCallback):
1991         (WTR::UIScriptController::setDidEndScrollingCallback):
1992         (WTR::UIScriptController::didEndScrollingCallback):
1993         (WTR::UIScriptController::setDidShowKeyboardCallback):
1994         (WTR::UIScriptController::didShowKeyboardCallback):
1995         (WTR::UIScriptController::setDidHideKeyboardCallback):
1996         (WTR::UIScriptController::didHideKeyboardCallback):
1997         (WTR::UIScriptController::uiScriptComplete):
1998         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
1999         (WTR::UIScriptController::create):
2000         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2001         (WTR::UIScriptController::doAsyncTask):
2002         (WTR::UIScriptController::zoomToScale):
2003         (WTR::UIScriptController::singleTapAtPoint):
2004         (WTR::UIScriptController::doubleTapAtPoint):
2005         (WTR::UIScriptController::typeCharacterUsingHardwareKeyboard):
2006         (WTR::UIScriptController::contentVisibleRect):
2007         (WTR::UIScriptController::platformSetWillBeginZoomingCallback):
2008         (WTR::UIScriptController::platformSetDidEndZoomingCallback):
2009         (WTR::UIScriptController::platformSetDidShowKeyboardCallback):
2010         (WTR::UIScriptController::platformSetDidHideKeyboardCallback):
2011         (WTR::UIScriptController::platformSetDidEndScrollingCallback):
2012         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
2013         (WTR::UIScriptController::doAsyncTask):
2014
2015 2016-01-07  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2016
2017         [buildbot] clean-build script should remove untracked files and revert local changes too
2018         https://bugs.webkit.org/show_bug.cgi?id=142400
2019
2020         Reviewed by Ryosuke Niwa.
2021
2022         This patch cleans the WebKit folder by reverting tracked files changes and deleting SCM untracked files, including SCM ignored files.
2023         A helper routine SCM.discard_untracked_files is added for that purpose.
2024
2025         * BuildSlaveSupport/clean-build:
2026         (main): Making call to Scripts/clean-webkit
2027         * Scripts/clean-webkit: Added.
2028         (main): Revert changes and delete untracked files.
2029         * Scripts/webkitpy/common/checkout/scm/scm.py:
2030         (SCM.discard_untracked_files): Helper function to discard untracked files or folders found by SCM.
2031         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2032         (SCMTest._shared_test_discard_untracked_files):
2033         (test_discard_untracked_files): Tests that untracked file and untracked folder get discarded correctly.
2034
2035 2016-01-06  Simon Fraser  <simon.fraser@apple.com>
2036
2037         Add a setting and preferences to enable display-list drawing. Does nothing yet.
2038         https://bugs.webkit.org/show_bug.cgi?id=152807
2039
2040         Reviewed by Zalan Bujtas.
2041         
2042         Add an item to the Settings menu to toggle display-list drawing.
2043
2044         * MiniBrowser/mac/SettingsController.h:
2045         * MiniBrowser/mac/SettingsController.m:
2046         (-[SettingsController _populateMenu]):
2047         (-[SettingsController validateMenuItem:]):
2048         (-[SettingsController toggleDisplayListDrawingEnabled:]):
2049         (-[SettingsController displayListDrawingEnabled]):
2050         * MiniBrowser/mac/WK2BrowserWindowController.m:
2051         (-[WK2BrowserWindowController didChangeSettings]):
2052
2053 2016-01-06  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2054
2055         Python SCM should be able to retrieve untracked files - Add GIT support
2056         https://bugs.webkit.org/show_bug.cgi?id=143135
2057
2058         Reviewed by Michael Catanzaro.
2059
2060         * Scripts/webkitpy/common/checkout/scm/git.py:
2061         (Git.untracked_files): Adding support for git.
2062         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2063         (GitTest.setUp):
2064         (GitTest.test_untracked_files): Adding test.
2065
2066 2016-01-05  Mark Lam  <mark.lam@apple.com>
2067
2068         Rename badly named JSC_timeout env var to JSCTEST_timeout.
2069         https://bugs.webkit.org/show_bug.cgi?id=152748
2070
2071         Reviewed by Geoffrey Garen.
2072
2073         Now that we validate JSC options, the badly named JSC_timeout env var causes the
2074         bots to have a bad time.
2075
2076         * Scripts/run-javascriptcore-tests:
2077         * Scripts/run-jsc-stress-tests:
2078
2079 2016-01-04  Carlos Garcia Campos  <cgarcia@igalia.com>
2080
2081         [GTK] Allow to save and restore session
2082         https://bugs.webkit.org/show_bug.cgi?id=115600
2083
2084         Reviewed by Michael Catanzaro.
2085
2086         Add test case to check the new session API.
2087
2088         * TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp:
2089         (testWebKitWebViewSessionState):
2090         (testWebKitWebViewSessionStateWithFormData):
2091         (beforeAll):
2092
2093 2016-01-04  Csaba Osztrogonác  <ossy@webkit.org>
2094
2095         [EFL] Bump EFL version to 1.16.1
2096         https://bugs.webkit.org/show_bug.cgi?id=152688
2097
2098         Reviewed by Gyuyoung Kim.
2099
2100         * efl/jhbuild.modules:
2101
2102 2016-01-04  Aakash Jain  <aakash_jain@apple.com>
2103
2104         error running layout tests on iOS simulator on latest build
2105         https://bugs.webkit.org/show_bug.cgi?id=152719
2106         <rdar://problem/24009549>
2107
2108         Reviewed by Alexey Proskuryakov.
2109
2110         * Scripts/webkitpy/xcode/simulator.py:
2111         (Simulator.wait_until_device_is_booted): Ensure that simulator device is in booted state
2112           before running simctl spawn command.
2113
2114 2016-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
2115
2116         Unreviewed, move Frédéric Wang to committers list
2117
2118         He seems to be on the contributors list by accident. He has been landing his own commits for
2119         about two years now.
2120
2121         * Scripts/webkitpy/common/config/contributors.json:
2122
2123 2016-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
2124
2125         Unreviewed, move Sebastian Dröge to committers list harder
2126
2127         He accidentally added himself to the reviewers list because the file is confusing. Then I
2128         accidentially moved him to the contributors list because the file is confusing, even though
2129         I knew the contributors list existed in this file and was attempting to add him to the
2130         committers list. Really move him to the committers list now.
2131
2132         * Scripts/webkitpy/common/config/contributors.json:
2133
2134 2016-01-02  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2135
2136         Python SCM should be able to retrieve untracked files - Add SVN support
2137         https://bugs.webkit.org/show_bug.cgi?id=152546
2138
2139         Reviewed by Michael Catanzaro.
2140
2141         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2142         (test_untracked_files): Activating test for SVN.
2143         * Scripts/webkitpy/common/checkout/scm/svn.py:
2144         (SVN.untracked_files): Implementing untracked files retrieval for SVN.
2145
2146 2015-12-31  Andy Estes  <aestes@apple.com>
2147
2148         Replace WTF::move with WTFMove
2149         https://bugs.webkit.org/show_bug.cgi?id=152601
2150
2151         Reviewed by Brady Eidson.
2152
2153         * DumpRenderTree/TestRunner.h:
2154         (TestRunner::setAllowedHosts):
2155         * DumpRenderTree/win/DRTDataObject.cpp:
2156         (DRTDataObject::SetData):
2157         * TestWebKitAPI/Tests/WTF/Deque.cpp:
2158         (TestWebKitAPI::TEST):
2159         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
2160         (TestWebKitAPI::TEST):
2161         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
2162         (TestWebKitAPI::TEST):
2163         * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
2164         (TestWebKitAPI::TEST):
2165         * TestWebKitAPI/Tests/WTF/Ref.cpp:
2166         (TestWebKitAPI::passWithRef):
2167         (TestWebKitAPI::TEST):
2168         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
2169         (TestWebKitAPI::TEST):
2170         * TestWebKitAPI/Tests/WTF/Vector.cpp:
2171         (TestWebKitAPI::TEST):
2172         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
2173         (TestWebKitAPI::TEST):
2174         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
2175         (TestWebKitAPI::TEST):
2176         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
2177         (TestWebKitAPI::createTestValue):
2178         (TestWebKitAPI::TEST):
2179         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2180         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
2181         (TestWebKitAPI::InMemoryCompiledContentExtension::create):
2182         (TestWebKitAPI::InMemoryCompiledContentExtension::InMemoryCompiledContentExtension):
2183         (TestWebKitAPI::createNFAs):
2184         (TestWebKitAPI::TEST_F):
2185         * TestWebKitAPI/Tests/WebCore/DFACombiner.cpp:
2186         (TestWebKitAPI::combine):
2187         * TestWebKitAPI/Tests/WebCore/DFAHelpers.h:
2188         (TestWebKitAPI::createNFAs):
2189         * TestWebKitAPI/Tests/WebKit2/cocoa/WeakObjCPtr.mm:
2190         (TEST):
2191         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
2192         (WebProcessTest::add):
2193
2194 2016-01-01  Michael Catanzaro  <mcatanzaro@igalia.com>
2195
2196         [SOUP] REGRESSION(r192761): Broke resource URIs for applications that use g_resource_load in a web extension
2197         https://bugs.webkit.org/show_bug.cgi?id=152634
2198
2199         Reviewed by Carlos Garcia Campos.
2200
2201         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
2202         (testLoadFromGResource): Added test.
2203         (beforeAll):
2204         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
2205         (registerGResource): Added.
2206         (webkit_web_extension_initialize_with_user_data): Load the test gresource.
2207         * TestWebKitAPI/Tests/WebKit2Gtk/resources/boring.html: Added.
2208         * TestWebKitAPI/Tests/WebKit2Gtk/resources/webkit2gtk-tests.gresource.xml: Add an HTML file.
2209
2210 2015-12-31  David Kilzer  <ddkilzer@apple.com>
2211
2212         REGRESSION (r194470): Fix warnings uncovered by migrating to WTF_MOVE
2213         <https://bugs.webkit.org/show_bug.cgi?id=152601>
2214
2215         Ignore unknown pragmas on older clangs.  Fixes the following
2216         build failure:
2217
2218             Tools/TestWebKitAPI/Tests/WTF/NakedPtr.cpp:184:34: error: unknown warning group '-Wself-move', ignored [-Werror,-Wunknown-pragmas]
2219             #pragma clang diagnostic ignored "-Wself-move"
2220                                              ^
2221             1 error generated.
2222
2223         * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
2224         (TestWebKitAPI::TEST):
2225         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
2226         (TestWebKitAPI::TEST):
2227
2228 2015-12-31  Andy Estes  <aestes@apple.com>
2229
2230         Update the style checker to advise using WTFMove() instead of WTF::move()
2231         https://bugs.webkit.org/show_bug.cgi?id=152601
2232
2233         Reviewed by Daniel Bates.
2234
2235         * Scripts/webkitpy/style/checkers/cpp.py:
2236         (check_wtf_move):
2237         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2238         (WebKitStyleTest.test_wtf_move):
2239
2240 2015-12-31  Andy Estes  <aestes@apple.com>
2241
2242         Fix warnings uncovered by migrating to WTF_MOVE
2243         https://bugs.webkit.org/show_bug.cgi?id=152601
2244
2245         Reviewed by Daniel Bates.
2246
2247         Ignored -Wself-move warnings in these two API tests. It's useful to test that these classes properly handle
2248         self-move, even if doing so would trigger a warning.
2249
2250         * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
2251         (TestWebKitAPI::TEST):
2252         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
2253         (TestWebKitAPI::TEST):
2254
2255 2015-12-31  Martin Robinson  <mrobinson@igalia.com>
2256
2257         [GTK] The install-dependencies script has a syntax error
2258         https://bugs.webkit.org/show_bug.cgi?id=152613
2259
2260         Reviewed by Michael Catanzaro.
2261
2262         * gtk/install-dependencies: Add the missing 'then.'
2263
2264 2015-12-30  Philippe Normand  <pnormand@igalia.com>
2265
2266         [Mac][GTK] Jhbuild support for OSX
2267         https://bugs.webkit.org/show_bug.cgi?id=150799
2268
2269         Reviewed by Michael Catanzaro.
2270
2271         * gtk/install-dependencies: Install dependencies on OSX with Homebrew.
2272         * gtk/jhbuild.modules: Moved platform-specific build settings in condition tags.
2273         * gtk/patches/foxbntconfig-fix-osx-cache.diff: Added.
2274         * gtk/jhbuildrc: GTK+ makeargs clean-up, the 3.0.12 hack is no longer needed.
2275
2276 2015-12-28  Michael Catanzaro  <mcatanzaro@igalia.com>
2277
2278         Unreviewed, move Sebastian Dröge to committers list
2279
2280         He accidentally added himself to the reviewers list because the file is confusing.
2281
2282         * Scripts/webkitpy/common/config/contributors.json:
2283
2284 2015-12-24  Simon Fraser  <simon.fraser@apple.com>
2285
2286         Remove the unused #define _USE_MATH_DEFINES
2287         https://bugs.webkit.org/show_bug.cgi?id=152034
2288
2289         Reviewed by Tim Horton.
2290         
2291         Update this test to use piDouble from MathExtras.h, and
2292         std::numeric_limits<>.
2293
2294         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
2295
2296 2015-12-24  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2297
2298         Python SCM should be able to retrieve untracked files - Generic changes
2299         https://bugs.webkit.org/show_bug.cgi?id=152536
2300
2301         Reviewed by Brent Fulgham.
2302
2303         This patch introduces SCM.untracked_files to retrieve a list of untracked files.
2304         No support is yet added to GIT and SVN specific implementations.
2305
2306         * Scripts/webkitpy/common/checkout/scm/scm.py:
2307         (SCM.untracked_files):
2308         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2309         (SCMTest._shared_test_untracked_files):
2310
2311 2015-12-23  Dewei Zhu  <dewei_zhu@apple.com>
2312
2313         SVN checkout used by RunBenchmark should be non-interactive
2314         https://bugs.webkit.org/show_bug.cgi?id=152542
2315
2316         Reviewed by Ryosuke Niwa.
2317
2318         RunBenchmark should not require user interaction while running.
2319
2320         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
2321         (BenchmarkBuilder._checkout_with_subversion):
2322
2323 2015-12-23  Brent Fulgham  <bfulgham@apple.com>
2324
2325         Web Inspector: add support for running protocol-test.js tests on Windows
2326         https://bugs.webkit.org/show_bug.cgi?id=148037
2327         <rdar://problem/22292237>
2328
2329         Reviewed by Simon Fraser.
2330
2331         * DumpRenderTree/win/TestRunnerWin.cpp:
2332         (TestRunner::inspectorTestStubURL): Provide implementation.
2333
2334 2015-12-23  Eric Carlson  <eric.carlson@apple.com>
2335
2336         [MediaStream] MediaDeviceInfo.label must be empty in some situations
2337         https://bugs.webkit.org/show_bug.cgi?id=152000
2338
2339         Reviewed by Brent Fulgham.
2340
2341         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2342         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2343         (WTR::InjectedBundle::setUserMediaPermission):
2344         (WTR::InjectedBundle::setUserMediaPermissionForOrigin): New.
2345         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2346
2347         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2348         (WTR::TestRunner::setUserMediaPermissionForOrigin): New.
2349         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2350
2351         * WebKitTestRunner/TestController.cpp:
2352         (WTR::TestController::setUserMediaPermissionForOrigin):
2353         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin): Add NULL check.
2354         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Don't add 
2355           persistent permission for origin, that can be done from script now.
2356         * WebKitTestRunner/TestController.h:
2357
2358         * WebKitTestRunner/TestInvocation.cpp:
2359         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Add support for
2360           SetUserMediaPermissionForOrigin.
2361
2362 2015-12-23  Brent Fulgham  <bfulgham@apple.com>
2363
2364         [Win] Unreviewed build fix: Recognize Windows 10 variants.
2365
2366         * Scripts/webkitpy/common/system/platforminfo.py:
2367         (PlatformInfo._determine_win_version):
2368
2369 2015-12-23  Chris Aljoudi <chris@chrismatic.io> and Alex Christensen <achristensen@webkit.org>
2370
2371         Content blockers should be able to promote http to https
2372         https://bugs.webkit.org/show_bug.cgi?id=148966
2373
2374         Reviewed by Benjamin Poulain.
2375
2376         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2377         (WebCore::ContentExtensions::operator<<):
2378         (TestWebKitAPI::TEST_F):
2379
2380 2015-12-22  Hunseop Jeong  <hs85.jeong@samsung.com>
2381
2382         [EFL] MiniBrowser should be able to choose the offline-web-application-cache option
2383         https://bugs.webkit.org/show_bug.cgi?id=152516
2384
2385         Reviewed by Gyuyoung Kim.
2386
2387         * MiniBrowser/efl/main.c:
2388
2389 2015-12-22  Brent Fulgham  <bfulgham@apple.com>
2390
2391         Unreviewed: Add John Wilander as a contributor.
2392
2393         * Scripts/webkitpy/common/config/contributors.json:
2394
2395 2015-12-22  Chris Fleizach  <cfleizach@apple.com>
2396
2397         [WK2] Looping in testcase: fast/dom/Window/property-access-on-cached-window-after-frame-removed.html
2398         https://bugs.webkit.org/show_bug.cgi?id=152482
2399
2400         Reviewed by Brent Fulgham.
2401
2402         vertical/horizontalScrollbar returns an accessibility element. That element can also be queried
2403         for the same property. On WK2, the element returned will not be valid, but is still present and
2404         that can lead to looping.
2405
2406         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2407         (AccessibilityUIElement::horizontalScrollbar):
2408         (AccessibilityUIElement::verticalScrollbar):
2409         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2410         (WTR::AccessibilityUIElement::horizontalScrollbar):
2411         (WTR::AccessibilityUIElement::verticalScrollbar):
2412
2413 2015-12-22  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2414
2415         Unreviewed.
2416
2417         * Scripts/webkitpy/common/config/contributors.json: Marking myself as reviewer.
2418
2419 2015-12-21  Hunseop Jeong  <hs85.jeong@samsung.com>
2420
2421         [EFL] test_ewk2_context failed after r192808
2422         https://bugs.webkit.org/show_bug.cgi?id=151846
2423
2424         Reviewed by Gyuyoung Kim.
2425
2426         Used the added ewk_context_web_process_count_limit_set api
2427         instead of the deprecated ewk_context_process_model_set.
2428
2429         * MiniBrowser/efl/main.c:
2430         (elm_main):
2431
2432 2015-12-21  Michael Catanzaro  <mcatanzaro@igalia.com>
2433
2434         Unreviewed, move myself to reviewer list.
2435
2436         * Scripts/webkitpy/common/config/contributors.json:
2437
2438 2015-12-21  Aakash Jain  <aakash_jain@apple.com>
2439
2440         Unreviewed, add myself to the committers list.
2441
2442         * Scripts/webkitpy/common/config/contributors.json:
2443
2444 2015-12-21  Michael Catanzaro  <mcatanzaro@igalia.com>
2445
2446         [GTK] jquery.min.js violates DFSG
2447         https://bugs.webkit.org/show_bug.cgi?id=152428
2448
2449         Reviewed by Joseph Pecoraro.
2450
2451         Stop distributing Source/WebInspectorUI/Tools. It is not needed in tarballs. This brings us
2452         into compliance with DFSG by removing a bundled, minified copy of jQuery from our tarball.
2453
2454         * gtk/manifest.txt.in:
2455
2456 2015-12-19  Dan Bernstein  <mitz@apple.com>
2457
2458         [Mac] WebKit contains dead source code for OS X Mavericks and earlier
2459         https://bugs.webkit.org/show_bug.cgi?id=152462
2460
2461         Reviewed by Alexey Proskuryakov.
2462
2463         - Removed definitions of MACOSX_DEPLOYMENT_TARGET and WEBKIT_SYSTEM_INTERFACE_LIBRARY for
2464           OS X 10.9:
2465
2466         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2467         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
2468         * MiniBrowser/Configurations/DebugRelease.xcconfig:
2469         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
2470         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2471
2472         - Simplified expressions involving __MAC_OS_X_VERSION_MIN_REQUIRED and removed code that was
2473           never getting compiled:
2474
2475         * DumpRenderTree/mac/TextInputController.m:
2476         * MiniBrowser/mac/BrowserWindowController.m:
2477         * TestWebKitAPI/Tests/mac/AttributedString.mm:
2478         * WebKitTestRunner/mac/EventSenderProxy.mm:
2479
2480 2015-12-18  Michael Catanzaro  <mcatanzaro@igalia.com>
2481
2482         Unreviewed, add WebKitGTK+ Bugzilla email to committers list
2483
2484         This is to make it easy to CC it on Bugzilla.
2485
2486         * Scripts/webkitpy/common/config/contributors.json:
2487
2488 2015-12-18  Aakash Jain  <aakash_jain@apple.com>
2489
2490         Pasteboard get messed up after running kill-old-processes
2491         https://bugs.webkit.org/show_bug.cgi?id=152426
2492
2493         Reviewed by Alexey Proskuryakov.
2494
2495         * BuildSlaveSupport/kill-old-processes:
2496         (main): Do not kill pasteboard anymore.
2497
2498 2015-12-17  Aakash Jain  <aakash_jain@apple.com>
2499
2500         run-webkit-tests shouldn't start multiple iOS simulators while only running one test
2501         https://bugs.webkit.org/show_bug.cgi?id=152157
2502         <rdar://problem/23851817>
2503
2504         Reviewed by Alexey Proskuryakov.
2505
2506         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
2507         (LayoutTestRunner.get_worker_count): Calculate required number of workers.
2508         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2509         (Manager._get_test_inputs): Common method to calculate test_inputs.
2510         (Manager._update_worker_count): Calculate and update required number of workers.
2511
2512 2015-12-16  Aakash Jain  <aakash_jain@apple.com>
2513
2514         run-webkit-tests fails to delete Simulator device during cleanup
2515         https://bugs.webkit.org/show_bug.cgi?id=152363
2516
2517         Reviewed by Alexey Proskuryakov.
2518
2519         * Scripts/webkitpy/xcode/simulator.py:
2520         (Simulator.delete_device): Ensure that device is Shutdown before deleting it.
2521
2522 2015-12-16  Tim Horton  <timothy_horton@apple.com>
2523
2524         [mac-wk2] fast/events force click tests crashing
2525         https://bugs.webkit.org/show_bug.cgi?id=152339
2526
2527         Reviewed by Beth Dakin.
2528
2529         * WebKitTestRunner/mac/EventSenderProxy.mm:
2530         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
2531         Set the NSEvent's _type member in addition to overriding -type,
2532         because there are assertions in touch event handling code that depend on it.
2533
2534 2015-12-16  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2535
2536         Enforce temporarily bots to sync WebKit and WPT testharness.js
2537         https://bugs.webkit.org/show_bug.cgi?id=152334
2538
2539         Reviewed by Darin Adler.
2540
2541         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2542         (WebPlatformTestServer._copy_webkit_test_files): Temporarily overwrite wpt testharness.js with WebKit testharness.js.
2543
2544 2015-12-16  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2545
2546         [Fetch API] Add fetch API compile time flag
2547         https://bugs.webkit.org/show_bug.cgi?id=152254
2548
2549         Reviewed by Darin Adler.
2550
2551         * Scripts/webkitperl/FeatureList.pm:
2552
2553 2015-12-16  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2554
2555         Unreviewed.
2556
2557         Added files that have impact in building Streams API to the watchlist.
2558
2559         * Scripts/webkitpy/common/config/watchlist:
2560
2561 2015-12-16  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2562
2563         Unreviewed.
2564
2565         Added imported tests to Streams API watchlist.
2566
2567         * Scripts/webkitpy/common/config/watchlist:
2568
2569 2015-12-16  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2570
2571         Remove default copy of wpt testharness.js when launching wpt server
2572         https://bugs.webkit.org/show_bug.cgi?id=152298
2573
2574         Reviewed by Darin Adler.
2575
2576         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2577         (WebPlatformTestServer._copy_webkit_test_files): Deleted default copy of WebKit testharness.js to WPT.
2578
2579 2015-12-15  David Kilzer  <ddkilzer@apple.com>
2580
2581         REGRESSION (r192375): DumpRenderTree.app exits immediately with no error
2582         <http://webkit.org/b/152314>
2583
2584         Reviewed by Daniel Bates.
2585
2586         The change to DumpRenderTreeMain.mm in r192375 caused the iOS
2587         code path to exit immediately when calling main().
2588         Unfortunately, DumpRenderTreeMain.mm was used for both
2589         DumpRenderTree command-line binary and DumpRenderTree.app, which
2590         meant that the app would exit immediately with no error code
2591         when run!
2592
2593         The workaround is to introduce a separate source file called
2594         DumpRenderTreeAppMain.mm, similar to what WebKitTestRunner
2595         already does.
2596
2597         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Add
2598         DumpRenderTreeAppMain.mm to the project.  Make it the only
2599         compiled source for the DumpRenderTree.app target.
2600         * DumpRenderTree/ios/DumpRenderTreeAppMain.mm: Copied from Tools/DumpRenderTree/mac/DumpRenderTreeMain.mm.
2601         (main): Call DumpRenderTreeMain() on iOS.  Assert on OS X in
2602         case someone tries mistakenly to use the app.
2603         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
2604         Link to JavaScriptCore.framework on iOS for the assert.
2605         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
2606         Link to JavaScriptCore.framework on OS X for the assert.  Remove
2607         unneeded EXCLUDED_SOURCE_FILE_NAMES setting.
2608         * DumpRenderTree/mac/DumpRenderTreeMain.mm:
2609         (main): Add assert for iOS so that a crash occurs if someone
2610         tries to run the wrong command.
2611
2612 2015-12-14  Tim Horton  <timothy_horton@apple.com>
2613
2614         Frequent crash under -[WKPDFView web_setMinimumSize:]_block_invoke
2615         https://bugs.webkit.org/show_bug.cgi?id=152266
2616         <rdar://problem/22092676>
2617
2618         Reviewed by Simon Fraser.
2619
2620         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2621         * TestWebKitAPI/Tests/WebKit2Cocoa/WKPDFViewResizeCrash.mm: Added.
2622         Add a test that crashed before this change, and doesn't crash after.
2623
2624 2015-12-14  Chris Fleizach  <cfleizach@apple.com>
2625
2626         AX: iOS: Text field variations do not have the correct traits
2627         https://bugs.webkit.org/show_bug.cgi?id=152237
2628
2629         Reviewed by Mario Sanchez Prada.
2630
2631         Add iOS calls for determing if an object is a search field or a text area.
2632
2633         * DumpRenderTree/AccessibilityUIElement.cpp:
2634         (getIsSearchFieldCallback):
2635         (getIsTextAreaCallback):
2636         (stringForSelectionCallback):
2637         (AccessibilityUIElement::getJSClass):
2638         * DumpRenderTree/AccessibilityUIElement.h:
2639         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2640         (AccessibilityUIElement::identifier):
2641         (AccessibilityUIElement::isTextArea):
2642         (AccessibilityUIElement::isSearchField):
2643         (AccessibilityUIElement::traits):
2644         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2645         (WTR::AccessibilityUIElement::scrollPageRight):
2646         (WTR::AccessibilityUIElement::hasContainedByFieldsetTrait):
2647         (WTR::AccessibilityUIElement::fieldsetAncestorElement):
2648         (WTR::AccessibilityUIElement::isSearchField):
2649         (WTR::AccessibilityUIElement::isTextArea):
2650         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2651         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2652         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2653         (WTR::AccessibilityUIElement::fieldsetAncestorElement):
2654         (WTR::AccessibilityUIElement::isTextArea):
2655         (WTR::AccessibilityUIElement::isSearchField):
2656         (WTR::AccessibilityUIElement::rowCount):
2657
2658 2015-12-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2659
2660         [GTK] [JHBuild] package libtool-bin is now required on Debian systems.
2661         https://bugs.webkit.org/show_bug.cgi?id=152252
2662
2663         Reviewed by Sergio Villar Senin.
2664
2665         * gtk/install-dependencies: Add libtool-bin to the list of packages required
2666         for building the JHBuild on Debian systems.
2667
2668 2015-12-11  Joseph Pecoraro  <pecoraro@apple.com>
2669
2670         check-for-inappropriate-objc-class-names should check all class names, not just externally visible ones
2671         https://bugs.webkit.org/show_bug.cgi?id=152156
2672
2673         Reviewed by Dan Bernstein.
2674
2675         Our frameworks should appropriately prefix all ObjC classes,
2676         not just external symbols.
2677
2678         * Scripts/check-for-inappropriate-objc-class-names:
2679         Remove the -g switch to check all ObjC class names.
2680
2681 2015-12-10  Eric Carlson  <eric.carlson@apple.com>
2682
2683         [MediaStream] Expose media capture devices persistent permissions to WebCore
2684         https://bugs.webkit.org/show_bug.cgi?id=152087
2685
2686         Add support for the new user media permission checker page UI client method.
2687
2688         Reviewed by Chris Dumez.
2689
2690         * WebKitTestRunner/TestController.cpp:
2691         (WTR::decidePolicyForUserMediaPermissionRequest):
2692         (WTR::checkUserMediaPermissionForOrigin):
2693         (WTR::TestController::createOtherPage): Add checkUserMediaPermissionForOrigin.
2694         (WTR::TestController::createWebViewWithOptions): Ditto.
2695         (WTR::TestController::resetStateToConsistentValues): Clear m_userMediaOriginPermissions.
2696         (WTR::originUserVisibleName): New, create a string for the origin.
2697         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin): Set the WKUserMediaPermissionCheckRef
2698           according to the state of the origin permission map.
2699         (WTR::TestController::handleUserMediaPermissionRequest): Remember both the origin and the
2700           request so we can update the origin permission map in decidePolicyForUserMediaPermissionRequestIfPossible.
2701         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Update the
2702           origin permission map.
2703         * WebKitTestRunner/TestController.h:
2704
2705 2015-12-10  Alex Christensen  <achristensen@webkit.org>
2706
2707         REGRESSION (r192796) WKBundlePageResourceLoadClient should be able to setHTTPBody in willSendRequestForFrame
2708         https://bugs.webkit.org/show_bug.cgi?id=152022
2709         rdar://problem/23763584
2710
2711         Reviewed by Darin Adler.
2712
2713         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2714         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2715         (WTR::InjectedBundlePage::willSendRequestForFrame):
2716         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2717         (WTR::TestRunner::setWillSendRequestReturnsNull):
2718         (WTR::TestRunner::willSendRequestReturnsNullOnRedirect):
2719         (WTR::TestRunner::setWillSendRequestReturnsNullOnRedirect):
2720         (WTR::TestRunner::setWillSendRequestAddsHTTPBody):
2721         (WTR::TestRunner::willSendRequestHTTPBody):
2722         Added setWillSendRequestAddsHTTPBody that uses new SPI for testing.
2723
2724 2015-12-10  Aakash Jain  <aakash_jain@apple.com>
2725
2726         Remove additional simulator checks before running layout-tests
2727         https://bugs.webkit.org/show_bug.cgi?id=152146
2728
2729         Reviewed by Darin Adler.
2730
2731         * Scripts/webkitpy/port/ios.py:
2732         (IOSSimulatorPort.check_sys_deps): Removed additional simulators verifications.
2733         * Scripts/webkitpy/xcode/simulator.py:
2734         (Simulator._boot_and_shutdown_simulator_device): Deleted.
2735         (Simulator.check_simulator_device_and_erase_if_needed): Deleted.
2736
2737 2015-12-09  Aakash Jain  <aakash_jain@apple.com>
2738
2739         Run atleast one simulator even if max process limit is low
2740         https://bugs.webkit.org/show_bug.cgi?id=152081
2741         <rdar://problem/23819694>
2742
2743         Reviewed by Alexey Proskuryakov.
2744
2745 2015-12-09  Mario Sanchez Prada  <mario@endlessm.com>
2746
2747         [GTK] Crash in WebProcess when loading large content with custom URI schemes
2748         https://bugs.webkit.org/show_bug.cgi?id=144262
2749
2750         Reviewed by Carlos Garcia Campos.
2751
2752         Added new unit test to check the additional scenarios we now
2753         handle for custom URI schemes.
2754
2755         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
2756         (generateHTMLContent): New helper function to generate big enough content.
2757         (testWebContextURIScheme): New unit test.
2758
2759 2015-12-09  Ryuan Choi  <ryuan.choi@navercorp.com>
2760
2761         [EFL] Fix unhandled web process message when launching MiniBrowser
2762         https://bugs.webkit.org/show_bug.cgi?id=152048
2763
2764         Reviewed by Gyuyoung Kim.
2765
2766         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp:
2767         (TestWebKitAPI::TEST):
2768
2769 2015-12-09  Carlos Garcia Campos  <cgarcia@igalia.com>
2770
2771         [GTK] Add API to handle beforeunload events
2772         https://bugs.webkit.org/show_bug.cgi?id=139090
2773
2774         Reviewed by Gustavo Noronha Silva.
2775
2776         * MiniBrowser/gtk/BrowserWindow.c:
2777         (browserWindowConstructed):
2778         (browserWindowDeleteEvent):
2779         (browser_window_class_init):
2780         Handle delete-event to prevent the window from being closed when
2781         the page has beforeunload handlers. Use
2782         webkit_web_view_try_close() when the window is requested to be
2783         closed.
2784         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
2785         (testWebViewJavaScriptDialogs):
2786         Add a test case for the WEBKIT_SCRIPT_DIALOG_BEFORE_UNLOAD_CONFIRM
2787         script dialog type.
2788
2789 2015-12-09  Mario Sanchez Prada  <mario@endlessm.com>
2790
2791         Refactored initialization code in LoadTrackingTest.
2792
2793         Rubber-stamped by Carlos Garcia Campos.
2794
2795         Small refactoring to make sure that the state of a LoadTrackingTest
2796         gets properly reset before loading new web content.
2797
2798         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h:
2799         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
2800         (LoadTrackingTest::reset): New, refactored code from *load*() and go*()
2801         functions and reset the remaining local variables.
2802         (LoadTrackingTest::loadURI): Call reset();
2803         (LoadTrackingTest::loadHtml): Ditto.
2804         (LoadTrackingTest::loadPlainText): Ditto.
2805         (LoadTrackingTest::loadBytes): Ditto.
2806         (LoadTrackingTest::loadRequest): Ditto.
2807         (LoadTrackingTest::reload): Ditto.
2808         (LoadTrackingTest::goBack): Ditto.
2809         (LoadTrackingTest::goForward): Ditto.
2810
2811 2015-12-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2812
2813         [EFL] REGRESSION(r193616): WKPreferences test has been failed since r193616
2814         https://bugs.webkit.org/show_bug.cgi?id=151942
2815
2816         Reviewed by Darin Adler.
2817
2818         * MiniBrowser/efl/main.c:
2819         (window_create): Enable offline web application cache feature on MiniBrowser.
2820         (elm_main):
2821
2822 2015-12-08  Aakash Jain  <aakash_jain@apple.com>
2823
2824         https://bugs.webkit.org/show_bug.cgi?id=151243
2825         <rdar://problem/22955197>
2826
2827         Reviewed by Alexey Proskuryakov.
2828
2829         * LayoutTestRelay/LayoutTestRelay/main.m:
2830         (getTestingSimDevice): Use separate testing device for each worker.
2831         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2832         (Manager.run): Perform cleanup even if setup fails.
2833         * Scripts/webkitpy/port/ios.py:
2834         (IOSSimulatorPort.default_child_processes): Calculate number of simulators to use.
2835         (IOSSimulatorPort.child_processes): Gets the number of simulators from options variable.
2836         (IOSSimulatorPort.setup_test_run): Handle mulitple simulators.
2837         (IOSSimulatorPort._quit_ios_simulator): Same
2838         (IOSSimulatorPort.clean_up_test_run): Same
2839         (IOSSimulatorPort.check_sys_deps): Same
2840         (IOSSimulatorPort.testing_device): Same
2841         (IOSSimulatorPort.reset_preferences): Same
2842         (IOSSimulatorPort.get_simulator_path): Return simulator path.
2843         (IOSSimulatorPort._createSimulatorApp): Create the copy of simulator app.
2844         * Scripts/webkitpy/xcode/simulator.py:
2845         (Device.delete): Delete the simulator device.
2846         (Simulator.delete_device): Same
2847         (Simulator.wait_until_device_is_booted): Wait for device booting.
2848
2849 2015-12-08  Ryuan Choi  <ryuan.choi@navercorp.com>
2850
2851         [EFL] Add API to provide preferences before creating ewk_view
2852         https://bugs.webkit.org/show_bug.cgi?id=151587
2853
2854         Reviewed by Gyuyoung Kim.
2855
2856         * MiniBrowser/efl/main.c:
2857         (on_key_down):
2858         (quit):
2859         (window_create):
2860         Moved settings related code to configuration() not to update settings
2861         whenever ewk_view is created.
2862         (configuration):
2863         (elm_main):
2864
2865 2015-12-08  Carlos Garcia Campos  <cgarcia@igalia.com>
2866
2867         Unreviewed. Fix GTK+ API tests after r193639.
2868
2869         The new jhbuild version needs some more variables ot be present in
2870         the builtin dict, even if they are set to None.
2871
2872         * jhbuild/jhbuildutils.py:
2873         (enter_jhbuild_environment_if_available):
2874
2875 2015-12-07  Gustavo Noronha Silva  <gns@gnome.org>
2876
2877         [GTK] Notify WebCore when notification is clicked
2878         https://bugs.webkit.org/show_bug.cgi?id=151951
2879
2880         Reviewed by Carlos Garcia Campos.
2881
2882         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2883         (testWebViewNotification): test the new API.
2884
2885 2015-12-07  Michael Catanzaro  <mcatanzaro@igalia.com>
2886
2887         'jhbuild build' should fail immediately when building any module fails
2888         https://bugs.webkit.org/show_bug.cgi?id=145697
2889
2890         Reviewed by Carlos Garcia Campos.
2891
2892         * efl/jhbuildrc: Update jhbuildrc to account for the removal of the use_lib64 option.
2893         * gtk/jhbuildrc: Update jhbuildrc to account for the removal of the use_lib64 option.
2894         Everything is placed under lib instead of lib64 now.
2895         * jhbuild/jhbuild-wrapper: Update jhbuild to the latest upstream commit, and pass
2896         --exit-on-error when running 'jhbuild build'.
2897         * jhbuild/jhbuildrc_common.py:
2898         (init): Don't override PKG_CONFIG_PATH, CMAKE_PREFIX_PATH, or CMAKE_LIBRARY_PATH. Modern
2899         jhbuild should be able to handle these for us without breaking things....
2900
2901 2015-12-07  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2902
2903         Add support to import w3c tests from a repository with a different root that the main repo dir
2904         https://bugs.webkit.org/show_bug.cgi?id=151751
2905
2906         Reviewed by Ryosuke Niwa and Youenn Fablet.
2907
2908         We should be able to import tests from repositories that are not pure test repositories and where tests are kept
2909         in a different directory than the repository root.
2910
2911         This patch introduces a new parameter tests_directory that we will use as root directory to search for
2912         tests. All paths will be flattened when copying tests to have a less complicated directory structure. This
2913         requires having the copy_path lists including tuples of origin and destination directories.
2914
2915         * Scripts/webkitpy/w3c/test_downloader.py:
2916         (TestDownloader._add_test_suite_paths): Adds the paths as a tuple of origin and destination directory.
2917         (TestDownloader.copy_tests): Uses the origin and destination tuple for the paths to copy when copying files.
2918         * Scripts/webkitpy/w3c/test_importer_unittest.py:
2919         (TestImporterTest.test_tests_directory): Test.
2920
2921 2015-12-07  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2922
2923         Mock TestRepositories in W3C importer tests
2924         https://bugs.webkit.org/show_bug.cgi?id=151938
2925
2926         Reviewed by Youenn Fablet.
2927
2928         The test importer tests should use a fake repository instead of using the real one. The reason why this happened
2929         is because the test repository method reading the file was using the filesystem directly instead of taking the
2930         host one. This patch changes that.
2931
2932         * Scripts/webkitpy/w3c/test_downloader.py:
2933         (TestDownloader.load_test_repositories): Take a filesystem and use it. If we get no filesystem, we use the
2934         default one.
2935         (TestDownloader.__init__): When loading the repositories, pass the host filesystem.
2936         * Scripts/webkitpy/w3c/test_importer_unittest.py:
2937         (TestImporterTest.test_harnesslinks_conversion):
2938         (TestImporterTest.test_submodules_generation): Use a fake test repository file.
2939
2940 2015-12-07  David Kilzer  <ddkilzer@apple.com>
2941
2942         TestNetscapePlugIn: Address review comment on 193607
2943         <http://webkit.org/b/151881>
2944
2945         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2946         (testSetStatus): Initializing std::unique_ptr<char[]> with
2947         nullptr is redundant.
2948
2949 2015-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
2950
2951         [GTK] Add webkit_uri_request_get_http_method
2952         https://bugs.webkit.org/show_bug.cgi?id=151601
2953
2954         Reviewed by Martin Robinson.
2955
2956         Add test case to check HTTP method of WebKitURIRequest.
2957
2958         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
2959         (testURIRequestHTTPMethod):
2960         (serverCallback):
2961         (beforeAll):
2962         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
2963         (sendRequestCallback):
2964
2965 2015-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
2966
2967         [GTK] Add WebKitWebPage::console-message-sent signal to Web Extensions API
2968         https://bugs.webkit.org/show_bug.cgi?id=79918
2969
2970         Reviewed by Gustavo Noronha Silva.
2971
2972         Add unit tests to check the different console messages.
2973
2974         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
2975         * TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp: Added.
2976         (ConsoleMessageTest::ConsoleMessage::operator==):
2977         (ConsoleMessageTest::consoleMessageReceivedCallback):
2978         (ConsoleMessageTest::ConsoleMessageTest):
2979         (ConsoleMessageTest::~ConsoleMessageTest):
2980         (ConsoleMessageTest::waitUntilConsoleMessageReceived):
2981         (testWebKitConsoleMessageConsoleAPI):
2982         (testWebKitConsoleMessageJavaScriptException):
2983         (testWebKitConsoleMessageNetworkError):
2984         (testWebKitConsoleMessageSecurityError):
2985         (beforeAll):
2986         (afterAll):
2987         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
2988         (consoleMessageSentCallback):
2989         (pageCreatedCallback):
2990
2991 2015-12-07  Ryuan Choi  <ryuan.choi@navercorp.com>
2992
2993         [EFL] MiniBrowser doesn't exit when called ewk_view_try_close()
2994         https://bugs.webkit.org/show_bug.cgi?id=151934
2995
2996         Reviewed by Csaba Osztrogonác.
2997
2998         * MiniBrowser/efl/main.c:
2999         (on_window_deletion): Revert the changes of r192767.
3000
3001 2015-12-07  Michael Catanzaro  <mcatanzaro@igalia.com>
3002
3003         [GTK] update-webkitgtk-libs cannot build mesa
3004         https://bugs.webkit.org/show_bug.cgi?id=151535
3005
3006         Reviewed by Martin Robinson.
3007
3008         Upgrade to newer mesa in order to build successfully against LLVM 3.7. Add missing
3009         dependency of mesa on LLVM, to ensure LLVM is built first. Build LLVM unconditionally, even
3010         on architectures where FTL is not supported, to ensure mesa is always buildable, since LLVM
3011         does not have a stable API and we cannot expect mesa to be buildable unless we control the
3012         LLVM version. Build mesa with --disable-egl since --enable-egl conflicts with
3013         --enable-xlib-glx. This fixes update-webkitgtk-libs on distros with LLVM 3.7.
3014
3015         * gtk/jhbuild.modules:
3016
3017 2015-12-07  Philippe Normand  <pnormand@igalia.com>
3018
3019         [GTK][Mac] libWebExtensionTest link error
3020         https://bugs.webkit.org/show_bug.cgi?id=150802
3021
3022         Reviewed by Carlos Garcia Campos.
3023
3024         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: add dependencies to the webextension library.
3025
3026 2015-12-06  David Kilzer  <ddkilzer@apple.com>
3027
3028         TestNetscapePlugIn: Fix leaks found by static analyzer
3029         <http://webkit.org/b/151881>
3030
3031         Reviewed by Darin Adler.
3032
3033         Fixes the following leaks found by the static analyzer:
3034             DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'path'
3035                     return false;
3036                            ^~~~~
3037             DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'target'
3038                     return false;
3039                            ^~~~~
3040             DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'url'
3041                     return false;
3042                            ^~~~~
3043
3044         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
3045         (toCString): Switch to returning std::unique_ptr<char[]>.  Add
3046         early return if allocation fails.
3047         (testPostURLFile): Switch to using std::unique_ptr<char[]>.
3048         Make sure to call fclose() on filehandle, even for an early
3049         return.
3050         (testSetStatus): Switch to using std::unique_ptr<char[]>.
3051
3052 2015-12-05  David Kilzer  <ddkilzer@apple.com>
3053
3054         prepare-ChangeLog: Fix some warning messages when using svn
3055         <http://webkit.org/b/151914>
3056
3057         Reviewed by Daniel Bates.
3058
3059         * Scripts/prepare-ChangeLog:
3060         (generateFunctionLists): Simplify logic so that we never call
3061         normalizePath() with an undefined value.
3062         (attributeCommand): Quote $subPath for the shell so that we
3063         don't try to run "svn propget" on invalid paths.
3064
3065 2015-12-04  David Kilzer  <ddkilzer@apple.com>
3066
3067         TestNetscapePlugIn: Fix remaining static analyzer warnings
3068         <http://webkit.org/b/151888>
3069
3070         Reviewed by Alexey Proskuryakov.
3071
3072         Fixes the following static analyzer warnings:
3073             Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:101:9: warning: Called function pointer is null (null dereference)
3074                     CRASH();
3075                     ^~~~~~~
3076             Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:46:5: note: expanded from macro 'CRASH'
3077                 ((void(*)())0)(); /* More reliable, but doesn't say BBADBEEF */ \
3078                 ^~~~~~~~~~~~~~~~
3079             Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:375:12: warning: Access to field 'pluginTest' results in a dereference of a null pointer (loaded from variable 'obj')
3080                 return obj->pluginTest->NPP_SetWindow(window);
3081                        ^~~~~~~~~~~~~~~
3082             2 warnings generated.
3083
3084         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3085         (CRASH): Use __builtin_trap() for gcc/clang.
3086         (NPP_SetWindow): Add early return if obj is nullptr.
3087
3088 2015-12-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3089
3090         [GTK] Test /webkit2/WebKitWebResource/get-data is flaky
3091         https://bugs.webkit.org/show_bug.cgi?id=151797
3092
3093         Reviewed by Martin Robinson.
3094
3095         Since we switched to use the network process to run the unit tests
3096         the test /webkit2/WebKitWebResource/get-data sometimes fails and
3097         sometimes passes. We are now also getting the notification for the
3098         css image. Since we wait for 3 resources, sometimes the css image
3099         is loaded before and then checkResourceData is called for it, but
3100         not handled. When the css image is the last one loaded the test
3101         passes. So, we just need to wait for the 4 resources.
3102
3103         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
3104         (testWebResourceGetData):
3105
3106 2015-12-03  David Kilzer  <ddkilzer@apple.com>
3107
3108         DumpRenderTree: Use-after-free in createBitmapContext() in PixelDumpSupportMac.mm
3109         <http://webkit.org/b/151845>
3110
3111         Reviewed by Simon Fraser.
3112
3113         Fixes the following static analyzer warning:
3114             DumpRenderTree/mac/PixelDumpSupportMac.mm:67:9: warning: Use of memory after it is freed
3115                     WTFLogAlways("DumpRenderTree: CGBitmapContextCreate(%p, %llu, %llu, 8, %llu, %p, 0x%x) failed\n", buffer, pixelsHigh, pixelsWide, rowBytes, colorSpace.get(), kCGImageAlphaPremultipliedFirst | kCGBitmapByteOrder32Host);
3116                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
3117
3118         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
3119         (createBitmapContext): Free 'buffer' after using it in logging
3120         to fix the use-after-free.  Assign a value of nullptr to buffer
3121         so we don't return with it set to a freed address.
3122
3123 2015-12-03  Jer Noble  <jer.noble@apple.com>
3124
3125         Expose WebCore's InvisibleAutoplayNotPermitted setting to WebKit & WebKit2
3126         https://bugs.webkit.org/show_bug.cgi?id=151830
3127
3128         Reviewed by Anders Carlsson.
3129
3130         Set invisibleAutoplayNotPermitted to NO by default both in WKTR and DRT.
3131
3132         * DumpRenderTree/mac/DumpRenderTree.mm:
3133         (resetWebPreferencesToConsistentValues):
3134         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3135         (WTR::initializeWebViewConfiguration):
3136
3137 2015-12-03  Anders Carlsson  <andersca@apple.com>
3138
3139         Remove Objective-C GC support
3140         https://bugs.webkit.org/show_bug.cgi?id=151819
3141         rdar://problem/23746991
3142
3143         Reviewed by Dan Bernstein.
3144
3145         * asan/asan.xcconfig:
3146
3147 2015-12-02  Yusuke Suzuki  <utatane.tea@gmail.com>
3148
3149         Allow nil for unspecified benchmark pathes
3150         https://bugs.webkit.org/show_bug.cgi?id=151784
3151
3152         Reviewed by Filip Pizlo.
3153
3154         `Pathname.new(nil)` will raise an error.
3155         Only generate Pathname if the benchmark path is specified.
3156
3157         * Scripts/run-jsc-benchmarks:
3158
3159 2015-12-02  Brent Fulgham  <bfulgham@apple.com>
3160
3161         [Win] Run non-http tests without Cygwin
3162         https://bugs.webkit.org/show_bug.cgi?id=151721
3163
3164         Reviewed by Andy Estes.
3165
3166         Support native 32-bit and 64-bit Python (and Perl) builds
3167         for running tests:
3168
3169         1. Use "startswith('win')", rather than "== 'win32'" to support
3170         various Windows build types.
3171         2. Supply full path for some native Windows utilities, since the
3172         path environment does not always have the specified, and they are
3173         guaranteed to exist in those specific locations.
3174         3. Make sure native Windows Python test runs pass proper environment
3175         variables to run programs.
3176         4. Append 'exe' suffix when running Windows executables.
3177         5. Use the _winreg Python module on Windows, since the Cygwin 'regtool'
3178         command doesn't exist.
3179         
3180         * Scripts/update-webkit: Use Perl $^X command to refer to the path of
3181         the current Perl executable, rather than requiring a new path search.
3182         * Scripts/webkitpy/common/find_files_unittest.py:
3183         (TestWinNormalize.test_win): Use startswith('win').
3184         * Scripts/webkitpy/common/prettypatch_unittest.py:
3185         (test_pretty_diff_encodings): Ditto.
3186         * Scripts/webkitpy/common/system/executive.py:
3187         (Executive._should_close_fds): Ditto.
3188         (Executive.shell_command_for_script): Use startswith('win').
3189         (Executive.kill_process): Use full path to killall executable.
3190         (Executive.check_running_pid): Use startswith('win').
3191         (Executive.running_pids): Ditto.
3192         (Executive.kill_all): Ditto. Also use path to 'killall' executable when
3193         running under native Windows Python.
3194         (Executive._child_process_encoding): Use startswith('win').
3195         (Executive._should_encode_child_process_arguments): Ditto.
3196         (Executive.popen): Recognize proper script engine on Windows, since it
3197         does not support the shebang syntax.
3198         (Executive.run_in_parallel): Use startswith('win').
3199         * Scripts/webkitpy/common/system/executive_unittest.py:
3200         (never_ending_command): Ditto.
3201         (ExecutiveTest.test_run_command_with_unicode): Ditto.
3202         (ExecutiveTest.serial_test_kill_process): Ditto.
3203         (ExecutiveTest.serial_test_kill_all): Ditto.
3204         (ExecutiveTest.serial_test_check_running_pid): Ditto.
3205         (ExecutiveTest.serial_test_run_in_parallel): Ditto.
3206         (main): Ditto.
3207         * Scripts/webkitpy/common/system/file_lock.py:
3208         (FileLock._create_lock): Ditto.
3209         (FileLock._remove_lock): Ditto.
3210         * Scripts/webkitpy/common/system/filesystem_unittest.py:
3211         (RealFileSystemTest.test_chdir): Ditto.
3212         (RealFileSystemTest.test_chdir__notexists): Ditto.
3213         (RealFileSystemTest.test_maybe_make_directory__failure): Ditto.
3214         * Scripts/webkitpy/common/system/path_unittest.py:
3215         (AbspathTest.test_abspath_to_uri_win): Ditto.
3216         * Scripts/webkitpy/common/system/platforminfo.py:
3217         (PlatformInfo._determine_os_name): Ditto.
3218         * Scripts/webkitpy/common/system/user.py: Ditto.
3219         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
3220         (ManagerTest.integration_test_needs_servers): Ditto.
3221         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
3222         (LayoutTestApacheHttpd.__init__): Handle upper and lower-case
3223         driver letters.
3224         (LayoutTestApacheHttpd._get_apache_config_file_path): Ditto.
3225         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
3226         (TestLayoutTestApacheHttpd.test_start_cmd): Ditto.
3227         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
3228         (HttpServerBase._check_that_all_ports_are_available): Ditto.
3229         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
3230         (TestHttpServer.test_start_cmd): Ditto.
3231         * Scripts/webkitpy/port/base.py:
3232         (Port.to.setup_environ_for_server): Include 'COMSPEC', 'SYSTEMDRIVE',
3233         and 'SYSTEMROOT' in environment passed to test runners.
3234         (Port._apache_config_file_name_for_platform): Use startswith('win').
3235         (Port._build_path): Ditto.
3236         (Port._path_to_driver): Include 'exe' suffix when running under native
3237         Windows.
3238         * Scripts/webkitpy/port/driver.py:
3239         (Driver._setup_environ_for_driver): Explicitly make some environment
3240         variables strings.
3241         * Scripts/webkitpy/port/server_process.py:
3242         (ServerProcess.__init__): Use startswith('win').
3243         * Scripts/webkitpy/port/win.py:
3244         (WinPort): Use the win32 registry utilities on Windows, and appropriate
3245         registry key formats.
3246         (WinPort._ntsd_location): Revise tool search paths for Windows 10.
3247         (WinPort.read_registry_value): Revise to use _winreg library on Windows,
3248         and regtool on Cygwin.
3249         (WinPort.write_registry_value): Ditto.
3250         (WinPort.setup_crash_log_saving): Ditto.
3251         (WinPort.restore_crash_log_saving): Ditto.
3252         (WinPort.prevent_error_dialogs): Ditto.
3253         (WinPort.allow_error_dialogs): Ditto.
3254         (WinPort.find_system_pid): Revise to use Windows management
3255         infrastructure on native Windows, continue using 'ps' on Cygwin.
3256         (WinPort.read_registry_string): Deleted.
3257         (WinPort.write_registry_string): Deleted.
3258         * Scripts/webkitpy/test/main.py:
3259         (main): Use startswith('win').
3260         (Tester._parse_args): Ditto.
3261
3262 2015-12-01  Yusuke Suzuki  <utatane.tea@gmail.com>
3263
3264         [ES6] Implement LLInt/Baseline Support for ES6 Generators and enable this feature
3265         https://bugs.webkit.org/show_bug.cgi?id=150792
3266
3267         Reviewed by Saam Barati.
3268
3269         * Scripts/webkitperl/FeatureList.pm:
3270
3271 2015-12-01  Commit Queue  <commit-queue@webkit.org>
3272
3273         Unreviewed, rolling out r192914.
3274         https://bugs.webkit.org/show_bug.cgi?id=151734
3275
3276         JSC tests for this change are failing on 32 and 64-bit bots
3277         (Requested by ryanhaddad on #webkit).
3278
3279         Reverted changeset:
3280
3281         "[ES6] Implement LLInt/Baseline Support for ES6 Generators and
3282         enable this feature"
3283         https://bugs.webkit.org/show_bug.cgi?id=150792
3284         http://trac.webkit.org/changeset/192914
3285
3286 2015-12-01  David Kilzer  <ddkilzer@apple.com>
3287
3288         EventSenderProxy::swipeGestureWithWheelAndMomentumPhases() leaks an EventSenderSyntheticEvent
3289         <http://webkit.org/b/151726>
3290
3291         Reviewed by Simon Fraser.
3292
3293         * WebKitTestRunner/mac/EventSenderProxy.mm:
3294         (WTR::EventSenderProxy::swipeGestureWithWheelAndMomentumPhases):
3295         Deploy RetainPtr<EventSenderSyntheticEvent> to fix leak.
3296
3297 2015-12-01  Myles C. Maxfield  <mmaxfield@apple.com>
3298
3299         Give String and AtomicString an existingHash() function
3300         https://bugs.webkit.org/show_bug.cgi?id=151717
3301
3302         Reviewed by Andreas Kling.
3303
3304         * TestWebKitAPI/Tests/WTF/AtomicString.cpp:
3305         (TestWebKitAPI::TEST):
3306         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
3307         (TestWebKitAPI::TEST):
3308
3309 2015-12-01  Yusuke Suzuki  <utatane.tea@gmail.com>
3310
3311         [ES6] Implement LLInt/Baseline Support for ES6 Generators and enable this feature
3312         https://bugs.webkit.org/show_bug.cgi?id=150792
3313
3314         Reviewed by Saam Barati.
3315
3316         * Scripts/webkitperl/FeatureList.pm:
3317
3318 2015-12-01  Sam Weinig  <sam@webkit.org>
3319
3320         Need completionHandler-based WebKit C SPI for alert, confirm, and prompt
3321         <rdar://problem/23320863>
3322         https://bugs.webkit.org/show_bug.cgi?id=151708
3323
3324         Reviewed by Anders Carlsson.
3325
3326         * WebKitTestRunner/TestController.cpp:
3327         (WTR::TestController::createOtherPage):
3328         (WTR::TestController::createWebViewWithOptions):
3329         Update for new WKPageUIClient.
3330
3331 2015-12-01  Anders Carlsson  <andersca@apple.com>
3332
3333         Remove WebKit2.framework
3334         https://bugs.webkit.org/show_bug.cgi?id=151715
3335
3336         Reviewed by Dan Bernstein.
3337
3338         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad.cpp:
3339         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad_bundle.cpp:
3340         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
3341         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
3342         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
3343         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
3344         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
3345
3346 2015-12-01  Joseph Pecoraro  <pecoraro@apple.com>
3347
3348         Unreviewed common typo fix "occurance" => "occurrence".
3349
3350         * Scripts/webkitpy/tool/commands/queries.py:
3351         (FindFlakyTests._print_statistics):
3352
3353 2015-11-30  Alex Christensen  <achristensen@webkit.org>
3354
3355         Make ProcessModel always MultipleSecondaryProcesses
3356         https://bugs.webkit.org/show_bug.cgi?id=151662
3357
3358         Reviewed by Antti Koivisto.
3359
3360         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
3361         (TestWebKitAPI::TEST):
3362         * WebKitTestRunner/TestController.cpp:
3363         (WTR::TestController::generatePageConfiguration):
3364
3365 2015-11-30  Alex Christensen  <achristensen@webkit.org>
3366
3367         Make usesNetworkProcess always true
3368         https://bugs.webkit.org/show_bug.cgi?id=151580
3369
3370         Reviewed by Darin Adler.
3371
3372         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
3373         (TestWebKitAPI::TEST):
3374         * TestWebKitAPI/Tests/WebKit2/mac/GetPIDAfterAbortedProcessLaunch.cpp:
3375         (TestWebKitAPI::TEST):
3376         * WebKitTestRunner/TestController.cpp:
3377         (WTR::TestController::generatePageConfiguration):
3378
3379 2015-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
3380
3381         Unreviewed. Skip GTK+ test /webkit2/WebKitWebView/editable/editable in Debug.
3382
3383         Add a way to skip unit tests only for Debug or Release builds and
3384         skipt the test /webkit2/WebKitWebView/editable/editable only for Debug.
3385
3386         * Scripts/run-gtk-tests:
3387         (SkippedTest):
3388         (SkippedTest.__init__):
3389         (SkippedTest.__str__):
3390         (SkippedTest.skip_entire_suite):
3391         (SkippedTest.skip_for_build_type):
3392         (TestRunner):
3393         (TestRunner.__init__):
3394
3395 2015-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
3396
3397         Unreviewed. Fix a crash in GTK+ test /webkit2/WebKitWebView/custom-charset.
3398
3399         It's an assert hit because we are reloading a view loaded with
3400         HTML data which is not supported. Use loadURI instead.
3401
3402         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
3403         (testWebViewCustomCharset):
3404
3405 2015-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
3406
3407         [GLIB] Remove GMainLoopSource and GThreadSafeMainLoopSource
3408         https://bugs.webkit.org/show_bug.cgi?id=151633
3409
3410         Reviewed by Csaba Osztrogonác.
3411
3412         * TestWebKitAPI/PlatformGTK.cmake:
3413         * TestWebKitAPI/Tests/WTF/glib/GMainLoopSource.cpp: Removed.
3414
3415 2015-11-27  Carlos Garcia Campos  <cgarcia@igalia.com>
3416
3417         [GTK] Remove the remaining uses of GMainLoopSource
3418         https://bugs.webkit.org/show_bug.cgi?id=151632
3419
3420         Reviewed by Žan Doberšek.
3421
3422         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
3423         (testWebViewSyncRequestOnMaxConns):
3424         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
3425         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3426         (WTR::TestRunner::TestRunner):
3427         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3428         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
3429         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
3430         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
3431         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
3432         (WTR::timeoutSource):
3433         (WTR::TestController::notifyDone):
3434         (WTR::TestController::platformRunUntil):
3435
3436 2015-11-27  Csaba Osztrogonác  <ossy@webkit.org>
3437
3438         [cmake] Add testb3 to the build system
3439         https://bugs.webkit.org/show_bug.cgi?id=151619
3440
3441         Reviewed by Gyuyoung Kim.
3442
3443         * Scripts/build-jsc:
3444
3445 2015-11-27  Csaba Osztrogonác  <ossy@webkit.org>
3446
3447         [jhbuild] Fix pixman build with clang
3448         https://bugs.webkit.org/show_bug.cgi?id=151441
3449
3450         Reviewed by Carlos Garcia Campos.
3451
3452         * efl/jhbuild.modules:
3453         * gtk/jhbuild.modules:
3454
3455 2015-11-26  David Kilzer  <ddkilzer@apple.com>
3456
3457         Extract prependToEnvironmentVariableList
3458         <http://webkit.org/b/151536>
3459
3460         Reviewed by Daniel Bates.
3461
3462         Tests: webkitdirs_unittest/appendToEnvironmentVariableList.pl
3463                webkitdirs_unittest/prependToEnvironmentVariableList.pl
3464
3465         * Scripts/webkitdirs.pm: Export appendToEnvironmentVariableList
3466         and prependToEnvironmentVariableList.
3467         (appendToEnvironmentVariableList): Simplify variable name.
3468         Switch to use $Config{path_sep}.
3469         (prependToEnvironmentVariableList): Add new method.
3470         (setupMacWebKitEnvironment): Switch to use
3471         prependToEnvironmentVariableList().
3472         (setupIOSWebKitEnvironment): Ditto.
3473
3474         * Scripts/webkitperl/webkitdirs_unittest/appendToEnvironmentVariableList.pl: Added.
3475         * Scripts/webkitperl/webkitdirs_unittest/prependToEnvironmentVariableList.pl: Added.
3476
3477 2015-11-24  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3478
3479         REGRESSION(r192053): MiniBrowser doesn't exit when clicking on the close-window button
3480         https://bugs.webkit.org/show_bug.cgi?id=151567
3481
3482         Reviewed by Darin Adler.
3483
3484         * MiniBrowser/efl/main.c: Call window_close() instead of ewk_view_try_close().
3485         (on_window_deletion):
3486
3487 2015-11-23  Carlos Garcia Campos  <cgarcia@igalia.com>
3488
3489         [GTK] Use the network process unconditionally
3490         https://bugs.webkit.org/show_bug.cgi?id=151541
3491
3492         Reviewed by Alex Christensen.
3493
3494         Fix TestInspectorServer test. Do not assume we already have the
3495         title we want when the page has been loaded, since the title is
3496         changed afterwards. So, check if the title has already been set,
3497         and if not wait for it.
3498
3499         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
3500         (openRemoteDebuggingSession):
3501
3502 2015-11-23  Alex Christensen  <achristensen@webkit.org>
3503
3504         Fix crash in ~WebProcessPool when using Geolocation with useNetworkProcess=true
3505         https://bugs.webkit.org/show_bug.cgi?id=151532
3506
3507         Reviewed by Benjamin Poulain.
3508
3509         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
3510         (TestWebKitAPI::GeolocationTransitionToHighAccuracyStateTracker::eventsChanged):
3511         (TestWebKitAPI::TEST):
3512         (TestWebKitAPI::GeolocationTransitionToLowAccuracyStateTracker::eventsChanged):
3513         (TestWebKitAPI::GeolocationTransitionToHighAccuracyStateTracker::GeolocationTransitionToHighAccuracyStateTracker): Deleted.
3514         (TestWebKitAPI::GeolocationTransitionToLowAccuracyStateTracker::GeolocationTransitionToLowAccuracyStateTracker): Deleted.
3515         Properly load about:blank in all WebViews to clean up.  Without this change, we had a 
3516         Geolocation provider stopping after its state tracker was destroyed with its stack frame,
3517         so it was calling a function on a test object that had gone out of scope.
3518         Also, call WKContextSetUsesNetworkProcess(context, true) to show what crash this fixed,
3519         but that will become the default soon and that call will be removed.
3520
3521 2015-11-22  David Kilzer  <ddkilzer@apple.com>
3522
3523         run-webkit-tests: http server for imported W3C tests doesn't work with --layout-tests-directory switch
3524         <http://webkit.org/b/151542>
3525
3526         Reviewed by Daniel Bates.
3527
3528         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
3529         (base_url): Use the Port object (already passed in) to give us
3530         the path to the LayoutTests directory, which already checks for a
3531         --layout-tests-directory command-line switch.
3532         (WebPlatformTestServer.__init__): Remove layout_test_results_dir
3533         argument since we can get this from the Port object already
3534         passed in via Port.results_directory().  Also switch to use
3535         Port.layout_tests_dir() to get the LayoutTests directory.
3536
3537         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
3538         (TestWebPlatformTestServer.test_custom_layout_tests_directory):
3539         Add test case for custom LayoutTests directory.
3540         (TestWebPlatformTestServer.test_previously_spawned_instance):
3541         Update Port object to set mock results directory as if it was
3542         set on the command-line.  Remove unneeded argument from
3543         WebPlatformTestServer constructor.
3544         (TestWebPlatformTestServer.test_corrupted_subserver_files): Ditto.
3545
3546         * Scripts/webkitpy/port/base.py:
3547         (Port.to.start_web_platform_test_server): Remove unneeded
3548         argument from WebPlatformTestServer constuctor.
3549
3550 2015-11-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3551
3552         [GTK] Some unit tests fail when using the network process
3553         https://bugs.webkit.org/show_bug.cgi?id=151490
3554
3555         Reviewed by Martin Robinson.
3556
3557         Run the soup server in a separate thread in TestResources test to
3558         avoid deadlocks.
3559
3560         This fixes /webkit2/WebKitWebView/sync-request-on-max-conns and
3561         /webkit2/WebKitWebResource/get-data when using the network process.
3562
3563         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
3564         (beforeAll): Create the WebKitTestServer with ServerRunInThread flag.
3565         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.cpp:
3566         (WebKitTestServer::WebKitTestServer): When ServerRunInThread is
3567         present, create a WorkQueue to run the server.
3568         (WebKitTestServer::run): Run the server in the work queue if it
3569         has been created.
3570         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.h: Convert server
3571         type into server options as flags.
3572
3573 2015-11-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3574
3575         [GTK] ImageDiff should normalize the diff image
3576         https://bugs.webkit.org/show_bug.cgi?id=151261
3577
3578         Reviewed by Sergio Villar Senin.
3579
3580         * ImageDiff/gtk/ImageDiff.cpp:
3581         (readPixbufFromStdin): Fix memory leak.
3582         (differenceImageFromDifferenceBuffer): Normalize diff buffer.
3583         (calculateDifference): Pass max distance to differenceImageFromDifferenceBuffer.
3584
3585 == Rolled over to ChangeLog-2015-11-21 ==