6191ba4c95381c88bd6a3f0d05ebd4203ab6cec4
[WebKit-https.git] / Tools / ChangeLog
1 2019-01-30  Thibault Saunier  <tsaunier@igalia.com>
2
3         [Flatpak] Add openjpeg support
4         https://bugs.webkit.org/show_bug.cgi?id=194019
5
6         Reviewed by Michael Catanzaro.
7
8         * flatpak/org.webkit.CommonModules.yaml:
9
10 2019-01-30  Commit Queue  <commit-queue@webkit.org>
11
12         Unreviewed, rolling out r240708.
13         https://bugs.webkit.org/show_bug.cgi?id=194022
14
15         It broke WPE build (Requested by KaL on #webkit).
16
17         Reverted changeset:
18
19         "[WPE] Bump font related dependencies to match the GTK+ port"
20         https://bugs.webkit.org/show_bug.cgi?id=194017
21         https://trac.webkit.org/changeset/240708
22
23 2019-01-30  Zalan Bujtas  <zalan@apple.com>
24
25         [LFC][IFC] nextBreakablePosition returns the same position on hyphen characters
26         https://bugs.webkit.org/show_bug.cgi?id=194001
27
28         Reviewed by Antti Koivisto.
29
30         * LayoutReloaded/misc/LFC-passing-tests.txt:
31
32 2019-01-30  Zalan Bujtas  <zalan@apple.com>
33
34         [LFC] Use the used margin values in outOfFlowReplacedVerticalGeometry consistently
35         https://bugs.webkit.org/show_bug.cgi?id=194020
36
37         Reviewed by Antti Koivisto.
38
39         * LayoutReloaded/misc/LFC-passing-tests.txt:
40
41 2019-01-30  Chris Fleizach  <cfleizach@apple.com>
42
43         AX: Support color well on iOS
44         https://bugs.webkit.org/show_bug.cgi?id=194010
45
46         Reviewed by Joanmarie Diggs.
47
48         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
49         (WTR::AccessibilityUIElement::stringAttributeValue):
50
51 2019-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
52
53         [WPE] Bump font related dependencies to match the GTK+ port
54         https://bugs.webkit.org/show_bug.cgi?id=194017
55
56         Reviewed by Žan Doberšek.
57
58         * wpe/jhbuild.modules:
59         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
60         * wpe/patches/icudata-stdlibs.patch: Added.
61
62 2019-01-29  Alexey Proskuryakov  <ap@apple.com>
63
64         [Mac] Update window scale API usage
65         https://bugs.webkit.org/show_bug.cgi?id=193991
66         rdar://problem/47614795
67
68         Reviewed by Tim Horton.
69
70         * DumpRenderTree/mac/DumpRenderTree.mm:
71         (changeWindowScaleIfNeeded):
72         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
73         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
74         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
75
76 2019-01-29  Chris Dumez  <cdumez@apple.com>
77
78         REGRESSION: ProcessSwap.DoSameSiteNavigationAfterCrossSiteProvisionalLoadStarted Failing on iOS
79         https://bugs.webkit.org/show_bug.cgi?id=193977
80         <rdar://problem/47643716>
81
82         Reviewed by Geoff Garen.
83
84         Update API test to address flakiness on iOS. Instead of doing the last navigation after receiving the
85         didStartProvisionalLoad, do we right after we answer the navigation policy request. Flakiness was due
86         to the previous provisional committing *before* we make the last load. 
87
88         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
89
90 2019-01-29  Youenn Fablet  <youenn@apple.com>
91
92         Adopt new SPI to evaluate server certificate trust
93         https://bugs.webkit.org/show_bug.cgi?id=193355
94
95         Reviewed by Alex Christensen.
96
97         Add infrastructure to handle HTTPS server trust evaluation testing.
98
99         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
100         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
101         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
102         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
103         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
104         * WebKitTestRunner/InjectedBundle/TestRunner.h:
105         * WebKitTestRunner/TestController.cpp:
106         (WTR::TestController::resetPreferencesToConsistentValues):
107         (WTR::TestController::didReceiveAuthenticationChallenge):
108         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
109         * WebKitTestRunner/TestController.h:
110         (WTR::TestController::serverTrustEvaluationCallbackCallsCount const):
111         * WebKitTestRunner/TestInvocation.cpp:
112         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
113         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
114         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
115
116 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
117
118         [ews-build] Add build step to print bot Configuration
119         https://bugs.webkit.org/show_bug.cgi?id=193887
120
121         Reviewed by Lucas Forschler.
122
123         * BuildSlaveSupport/ews-build/steps.py:
124         (PrintConfiguration): Build step to print configuration.
125         * BuildSlaveSupport/ews-build/factories.py:
126
127 2019-01-29  Chris Dumez  <cdumez@apple.com>
128
129         Regression (r240046): [PSON] Spurious changes to [WKWebView url] and [WKWebView loading] after [WKWebView loadRequest]
130         https://bugs.webkit.org/show_bug.cgi?id=193967
131         <rdar://problem/47635348>
132
133         Reviewed by Alex Christensen.
134
135         Add API test coverage.
136
137         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
138         (-[PSONLoadingObserver observeValueForKeyPath:ofObject:change:context:]):
139
140 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
141
142         [ews-app] Handle incoming results data
143         https://bugs.webkit.org/show_bug.cgi?id=193973
144
145         Reviewed by Lucas Forschler.
146
147         * BuildSlaveSupport/ews-app/ews/views/results.py:
148
149 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
150
151         [ews-app] Make the results url generic
152         https://bugs.webkit.org/show_bug.cgi?id=193928
153
154         Reviewed by Lucas Forschler.
155
156         * BuildSlaveSupport/ews-app/ews/urls.py:
157
158 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
159
160         [ews-build] Configure buildbot to send events to ews-app
161         https://bugs.webkit.org/show_bug.cgi?id=193968
162
163         Reviewed by Lucas Forschler.
164
165         * BuildSlaveSupport/ews-build/events.py: Added.
166         * BuildSlaveSupport/ews-build/master.cfg:
167
168 2019-01-29  Keith Rollin  <krollin@apple.com>
169
170         Add .xcfilelists to Run Script build phases
171         https://bugs.webkit.org/show_bug.cgi?id=193792
172         <rdar://problem/47201785>
173
174         Reviewed by Alex Christensen.
175
176         As part of supporting XCBuild, update the necessary Run Script build
177         phases in their Xcode projects to refer to their associated
178         .xcfilelist files.
179
180         Note that the addition of these files bumps the Xcode project version
181         number to something that's Xcode 10 compatible. This change means that
182         older versions of the Xcode IDE can't read these projects. Nor can it
183         fully load workspaces that refer to these projects (the updated
184         projects are shown as non-expandable placeholders). `xcodebuild` can
185         still build these projects; it's just that the IDE can't open them.
186
187         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
188         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
189
190 2019-01-29  John Wilander  <wilander@apple.com>
191
192         Add data abstraction and validation for Ad Click Attribution
193         https://bugs.webkit.org/show_bug.cgi?id=193916
194         <rdar://problem/47603481>
195
196         Reviewed by Daniel Bates, Brent Fulgham, and Alex Christensen.
197
198         Ad click attribution has two steps. First, the storage of an ad
199         campaign ID for a click that takes the user to a destination
200         site. Second, a conversion on the destination site that can be
201         attributed to the ad click.
202
203         This patch adds a class that represents a request for ad click
204         attribution. Validation makes sure that the bits of entropy
205         reported through this mechanism is limited.
206
207         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
208         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp: Added.
209         (TestWebKitAPI::TEST):
210
211 2019-01-29  Chris Dumez  <cdumez@apple.com>
212
213         REGRESSION (PSON): Twitter link gets stuck at t.co after navigating back in tab
214         https://bugs.webkit.org/show_bug.cgi?id=193932
215         <rdar://problem/47598947>
216
217         Reviewed by Brady Eidson.
218
219         Add API test coverage.
220
221         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
222
223 2019-01-29  Zalan Bujtas  <zalan@apple.com>
224
225         Adding new passing LFC tests.
226
227         Unreviewed test gardening.
228
229         * LayoutReloaded/misc/LFC-passing-tests.txt:
230
231 2019-01-29  Zalan Bujtas  <zalan@apple.com>
232
233         [LFC][BFC][MarginCollapsing] Remove incorrect downcast<Container>
234         https://bugs.webkit.org/show_bug.cgi?id=193964
235
236         Reviewed by Antti Koivisto.
237
238         * LayoutReloaded/misc/LFC-passing-tests.txt:
239
240 2019-01-29  Zalan Bujtas  <zalan@apple.com>
241
242         [LFC][BFC] Do not ignore next sibling box while laying out BFC.
243         https://bugs.webkit.org/show_bug.cgi?id=193954
244
245         Reviewed by Antti Koivisto.
246
247         * LayoutReloaded/misc/LFC-passing-tests.txt:
248
249 2019-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
250
251         WebDriver: add support for running subtests
252         https://bugs.webkit.org/show_bug.cgi?id=193904
253
254         Reviewed by Michael Catanzaro.
255
256         pytest already supports it by passing test.py::subtest, so we can do the same.
257
258         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
259         (get_item_name): Made this global.
260         (CollectRecorder.__init__): Receive the parameter to ignore.
261         (CollectRecorder.pytest_collectreport): Collect also the subtests.
262         (TestExpectationsMarker.pytest_collection_modifyitems): Use get_item_name().
263         (collect): Add parameter to ignore.
264         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
265         (WebDriverSeleniumExecutor.collect): Pass the driver name as parameter to ignore.
266         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
267         (WebDriverTestRunnerSelenium.collect_tests): Handle subtest name in test path.
268         (WebDriverTestRunnerSelenium.run): Ditto.
269         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
270         (WebDriverTestRunnerW3C.collect_tests): Ditto.
271         (WebDriverTestRunnerW3C.run): Ditto.
272
273 2019-01-28  Ryosuke Niwa  <rniwa@webkit.org>
274
275         User agent string override for navigator.userAgent should be site specific quirks
276         https://bugs.webkit.org/show_bug.cgi?id=193950
277
278         Reviewed by Brent Fulgham.
279
280         Updated per the _WKWebsitePolicies rename.
281
282         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
283         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
284
285 2019-01-28  Ross Kirsling  <ross.kirsling@sony.com>
286
287         Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
288         https://bugs.webkit.org/show_bug.cgi?id=193941
289
290         Reviewed by Alex Christensen.
291
292         * TestWebKitAPI/Tests/WTF/ConcurrentPtrHashSet.cpp:
293         * TestWebKitAPI/Tests/WTF/Condition.cpp:
294         * TestWebKitAPI/Tests/WTF/Lock.cpp:
295         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
296         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
297         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
298         * TestWebKitAPI/Tests/WTF/ScopedLambda.cpp:
299         * TestWebKitAPI/Tests/WTF/Time.cpp:
300         * TestWebKitAPI/Tests/WTF/UniqueArray.cpp:
301         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
302         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
303         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
304
305 2019-01-28  Yusuke Suzuki  <ysuzuki@apple.com>
306
307         Unreviewed, reorder my emails to fix autocomplete in bugzilla
308
309         * Scripts/webkitpy/common/config/contributors.json:
310
311 2019-01-28  Andy Estes  <aestes@apple.com>
312
313         [watchOS] Enable Parental Controls content filtering
314         https://bugs.webkit.org/show_bug.cgi?id=193939
315         <rdar://problem/46641912>
316
317         Reviewed by Ryosuke Niwa.
318
319         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
320
321 2019-01-28  David Kilzer  <ddkilzer@apple.com>
322
323         REGRESSION (r236481): Move soft-linking of LocalAuthentication.framework out of LocalAuthenticationSoftLink.h
324         <https://webkit.org/b/193884>
325
326         Reviewed by Jiewen Tan.
327
328         * Scripts/webkitpy/style/checkers/cpp.py:
329         (check_language): Add LocalAuthentication to
330         `frameworks_with_soft_links`.
331
332 2019-01-28  Fujii Hironori  <Hironori.Fujii@sony.com>
333
334         [Win][WebKitTestRunner] Error: test and reference images have different sizes. Test image is 784x561, reference image is 800x600
335         https://bugs.webkit.org/show_bug.cgi?id=193891
336
337         Reviewed by Ross Kirsling.
338
339         There were three problems in window sizes of WebView and the host window.
340         1. The sizes of pixel image output were incorrect.
341         2. The host window is going to appear after window.resize was invoked.
342         3. window.resize resized only the host window, not WebView.
343
344         This change solves them with a following approach.
345         a. PlatformWebView::PlatformWebView creates the initial host window as zero size.
346         b. Changes the host window style from WS_OVERLAPPEDWINDOW to WS_POPUP
347            as well as DumpRenderTree in order to match the client area and the window area.
348         c. PlatformWebView::resizeTo simply calls PlatformWebView::setWindowFrame as well as Mac port and GTK port.
349         d. PlatformWebView::setWindowFrame changes both window sizes.
350         e. PlatformWebView::setWindowFrame moves the host window to the out side of screen if m_options.shouldShowWebView.
351
352         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
353         (WTR::PlatformWebView::PlatformWebView): Create the host window
354         and WebView as zero size. Use WS_POPUP instead of WS_OVERLAPPEDWINDOW.
355         (WTR::PlatformWebView::resizeTo): Calls PlatformWebView::setWindowFrame.
356         (WTR::PlatformWebView::setWindowFrame): Change both window sizes.
357
358 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
359
360         [ews-app] Add method to save Step data to database
361         https://bugs.webkit.org/show_bug.cgi?id=193890
362
363         Reviewed by Lucas Forschler.
364
365         * BuildSlaveSupport/ews-app/ews/models/step.py:
366         (Step.save_step): Method to save step data.
367         (Step.update_step): Method to update step data.
368         (Step.get_existing_step): Method to fetch existing step from database.
369         (Step.is_valid_result): Method to validate valid step result.
370
371 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
372
373         [ews-app] Add method to save Build data to database
374         https://bugs.webkit.org/show_bug.cgi?id=193735
375
376         Reviewed by Lucas Forschler.
377
378         * BuildSlaveSupport/ews-app/ews/models/build.py:
379         (Build.save_build): Method to save build information to database.
380         (Build.get_existing_build): Method to fetch existing build from database.
381         (Build.is_valid_result): Method to validate build result.
382         * BuildSlaveSupport/ews-app/ews/common/util.py:
383         (is_valid_int_id): Method to validate valid id.
384
385 2019-01-28  Chris Dumez  <cdumez@apple.com>
386
387         Regression(PSON) Crash under WebPageProxy::didStartProgress()
388         https://bugs.webkit.org/show_bug.cgi?id=193915
389         <rdar://problem/47560907>
390
391         Reviewed by Alex Christensen.
392
393         Add API test coverage.
394
395         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
396
397 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
398
399         [ews-app] Rename id variables
400         https://bugs.webkit.org/show_bug.cgi?id=193883
401
402         Reviewed by Lucas Forschler.
403
404         * BuildSlaveSupport/ews-app/ews/models/build.py:
405         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
406         * BuildSlaveSupport/ews-app/ews/models/step.py:
407         * BuildSlaveSupport/ews-app/ews/urls.py:
408         * BuildSlaveSupport/ews-app/ews/views/patch.py:
409         * BuildSlaveSupport/ews-app/ews/views/results.py:
410         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
411
412 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
413
414         [ews-app] Allow certain fields to be empty
415         https://bugs.webkit.org/show_bug.cgi?id=193892
416
417         Reviewed by Lucas Forschler.
418
419         * BuildSlaveSupport/ews-app/ews/models/build.py:
420         * BuildSlaveSupport/ews-app/ews/models/step.py:
421
422 2019-01-28  Rob Buis  <rbuis@igalia.com>
423
424         Update MIME type parser
425         https://bugs.webkit.org/show_bug.cgi?id=180526
426
427         Reviewed by Frédéric Wang.
428
429         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
430         (TestWebKitAPI::TEST):
431
432 2019-01-28  Zalan Bujtas  <zalan@apple.com>
433
434         [LFC][MarginCollapsing][Quirks] Quirk margin values get propagated through margin collapsing
435         https://bugs.webkit.org/show_bug.cgi?id=193896
436
437         Reviewed by Antti Koivisto.
438
439         * LayoutReloaded/misc/LFC-passing-tests.txt:
440
441 2018-12-15  Darin Adler  <darin@apple.com>
442
443         Replace many uses of String::format with more type-safe alternatives
444         https://bugs.webkit.org/show_bug.cgi?id=192742
445
446         Reviewed by Mark Lam.
447
448         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
449         (WTR::cacheTestRunnerCallback): Use makeString.
450         * WebKitTestRunner/TestController.cpp:
451         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
452         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
453
454 2019-01-27  Jiewen Tan  <jiewen_tan@apple.com>
455
456         Use a load optimizer for some sites
457         https://bugs.webkit.org/show_bug.cgi?id=193881
458         <rdar://problem/46325455>
459
460         Reviewed by Brent Fulgham.
461
462         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
463         * TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm: Added.
464
465 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
466
467         AX: Introduce a static accessibility tree
468         https://bugs.webkit.org/show_bug.cgi?id=193348
469         <rdar://problem/47203295>
470
471         Reviewed by Ryosuke Niwa.
472
473         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
474
475 2019-01-26  Zalan Bujtas  <zalan@apple.com>
476
477         [LFC] The default values for top/bottom in contentHeightForFormattingContextRoot should not be 0.
478         https://bugs.webkit.org/show_bug.cgi?id=193867
479
480         Reviewed by Antti Koivisto.
481
482         * LayoutReloaded/misc/LFC-passing-tests.txt:
483
484 2019-01-26  Zalan Bujtas  <zalan@apple.com>
485
486         [LFC][BFC] Ignore last inflow child's collapsed through margin after when computing containing block's height.
487         https://bugs.webkit.org/show_bug.cgi?id=193865
488
489         Reviewed by Antti Koivisto.
490
491         * LayoutReloaded/misc/LFC-passing-tests.txt:
492
493 2019-01-25  Ryosuke Niwa  <rniwa@webkit.org>
494
495         Need a mechanism to override navigator.userAgent
496         https://bugs.webkit.org/show_bug.cgi?id=193762
497         <rdar://problem/47504939>
498
499         Reviewed by Brent Fulgham.
500
501         Added test cases for _WKWebsitePolicies.customJavaScriptUserAgent.
502
503         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
504         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
505         (-[CustomJavaScriptUserAgentDelegate webView:didFinishNavigation:]):
506
507 2019-01-25  Dean Jackson  <dino@apple.com>
508
509         REGRESSION: Some USDz from 3rd party websites don't go directly to AR QL
510         https://bugs.webkit.org/show_bug.cgi?id=193831
511         <rdar://problem/47399263>
512
513         Reviewed by Chris Dumez.
514
515         Two new tests that exercise cross-origin and same-origin System
516         Previews.
517
518         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
519
520 2019-01-25  Keith Rollin  <krollin@apple.com>
521
522         Update Xcode projects with "Check .xcfilelists" build phase
523         https://bugs.webkit.org/show_bug.cgi?id=193790
524         <rdar://problem/47201374>
525
526         Reviewed by Alex Christensen.
527
528         Support for XCBuild includes specifying inputs and outputs to various
529         Run Script build phases. These inputs and outputs are specified as
530         .xcfilelist files. Once created, these .xcfilelist files need to be
531         kept up-to-date. In order to check that they are up-to-date or not,
532         add an Xcode build step that invokes an external script that performs
533         the checking. If the .xcfilelists are found to be out-of-date, update
534         them, halt the build, and instruct the developer to restart the build
535         with up-to-date files.
536
537         At this time, the checking and regenerating is performed only if the
538         WK_ENABLE_CHECK_XCFILELISTS environment variable is set to 1. People
539         who want to use this facility can set this variable and test out the
540         checking/regenerating. Once it seems like there are no egregious
541         issues that upset a developer's workflow, we'll unconditionally enable
542         this facility.
543
544         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
545         * DumpRenderTree/Scripts/check-xcfilelists.sh: Added.
546         * WebKitTestRunner/Scripts/check-xcfilelists.sh: Added.
547         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
548
549 2019-01-25  Keith Rollin  <krollin@apple.com>
550
551         Update Xcode projects with "Apply Configuration to XCFileLists" build target
552         https://bugs.webkit.org/show_bug.cgi?id=193781
553         <rdar://problem/47201153>
554
555         Reviewed by Alex Christensen.
556
557         Part of generating the .xcfilelists used as part of adopting XCBuild
558         includes running `make DerivedSources.make` from a standalone script.
559         It’s important for this invocation to have the same environment as
560         when the actual build invokes `make DerivedSources.make`. If the
561         environments are different, then the two invocations will provide
562         different results. In order to get the same environment in the
563         standalone script, have the script launch xcodebuild targeting the
564         "Apply Configuration to XCFileLists" build target, which will then
565         re-invoke our standalone script. The script is now running again, this
566         time in an environment with all workspace, project, target, xcconfig
567         and other environment variables established.
568
569         The "Apply Configuration to XCFileLists" build target accomplishes
570         this task via a small embedded shell script that consists only of:
571
572             eval "${WK_SUBLAUNCH_SCRIPT_PARAMETERS[@]}"
573
574         The process that invokes "Apply Configuration to XCFileLists" first
575         sets WK_SUBLAUNCH_SCRIPT_PARAMETERS to an array of commands to be
576         evaluated and exports it into the shell environment. When xcodebuild
577         is invoked, it inherits the value of this variable and can `eval` the
578         contents of that variable. Our external standalone script can then set
579         WK_SUBLAUNCH_SCRIPT_PARAMETERS to the path to itself, along with a set
580         of command-line parameters needed to restart itself in the appropriate
581         state.
582
583         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
584         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
585
586 2019-01-25  Alex Christensen  <achristensen@webkit.org>
587
588         Add SPI to inform an application that "Go Back" has been clicked from a safe browsing warning
589         https://bugs.webkit.org/show_bug.cgi?id=193802
590         <rdar://problem/46010580>
591
592         Reviewed by Andy Estes.
593
594         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
595         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]):
596         (TEST):
597
598 2019-01-25  Daniel Bates  <dabates@apple.com>
599
600         [iOS] uiController.keyDown() does not translate Control modified key
601         https://bugs.webkit.org/show_bug.cgi?id=192898
602
603         Reviewed by Wenson Hsieh.
604
605         Implement uiController.keyDown() in terms of HIDEventGenerator so that UIKit performs
606         key translation, as applicable. Among other cases, key translation occurs when performing
607         a Control key modified key sequence. Writing uiController.keyDown() in terms of HIDEventGenerator
608         also makes the behavior of uiController.keyDown() more closely match the behavior of a
609         human pressing down and releasing key(s) using a hardware keyboard.
610
611         * WebKitTestRunner/ios/HIDEventGenerator.h:
612         * WebKitTestRunner/ios/HIDEventGenerator.mm:
613         (-[HIDEventGenerator sendMarkerHIDEventWithCompletionBlock:]): Renamed; formerly named _sendMarkerHIDEventWithCompletionBlock.
614
615         (-[HIDEventGenerator touchDown:touchCount:completionBlock:]):
616         (-[HIDEventGenerator liftUp:touchCount:completionBlock:]):
617         (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
618         (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
619         (-[HIDEventGenerator stylusUpAtPoint:completionBlock:]):
620         (-[HIDEventGenerator stylusTapAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
621         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
622         (-[HIDEventGenerator longPress:completionBlock:]):
623         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
624         Update code for above renaming.
625
626         (hidUsageCodeForCharacter): Translate \b to a backspace and teach this function to recognize the
627         DumpRenderTree EventSender-compatible modifier key names (e.g. "metaKey").
628
629         (-[HIDEventGenerator keyDown:]): Added.
630         (-[HIDEventGenerator keyUp:]): Added.
631         (-[HIDEventGenerator keyPress:completionBlock:]):
632         (-[HIDEventGenerator eventDispatchThreadEntry:]):
633         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]): Deleted; renamed to sendMarkerHIDEventWithCompletionBlock.
634         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
635         (WTR::parseModifierArray): Modified to return a vector of strings that represent the modifier keys to press.
636         (WTR::UIScriptController::keyDown): Write in terms of HIDEventGenerator.
637         (WTR::parseModifier): Deleted.
638
639 2019-01-25  Keith Rollin  <krollin@apple.com>
640
641         Complete the implementation of generate-xcfilelists
642         https://bugs.webkit.org/show_bug.cgi?id=193782
643
644         Reviewed by Alex Christensen.
645
646         A preliminary version of generate-xcfilelists was added in r238008.
647         This patch updates that script in order to:
648
649         - Support checking of .xcfilelists
650         - Perform better execution of `make DerivedSources.make` by
651           relaunching generate-xcfilelists under xcodebuild
652         - Support incremental generation and checking of .xcfilelists
653         - Support supplementary .xcfilelists files from WebKitAdditions
654         - Support being wrapped by parallel version of generate-xcfilelists in
655           Internal that adds support for (re)generating WebKit projects in
656           that repo.
657         - Support builds that have been performed in WebKitBuild as well as
658           ~/Library/Developer/code/DerivedData
659         - Increase robustness and debugging facilities.
660
661         * Scripts/generate-xcfilelists:
662
663 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
664
665         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
666         https://bugs.webkit.org/show_bug.cgi?id=193297
667         <rdar://problem/47158841>
668
669         Unreviewed test case fix.
670
671         These test cases require ResourceLoadStatistics to be active, so the feature must be turned on.
672         Previously, the default data store turned the feature on automatically, allowing these tests to pass.
673
674         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
675         (TEST):
676
677 2019-01-25  Keith Rollin  <krollin@apple.com>
678
679         Update existing .xcfilelists
680         https://bugs.webkit.org/show_bug.cgi?id=193791
681         <rdar://problem/47201706>
682
683         Reviewed by Alex Christensen.
684
685         Many .xcfilelist files were added in r238824 in order to support
686         XCBuild. Update these with recent changes to the set of build files
687         and with the current generate-xcfilelist script.
688
689         * DumpRenderTree/DerivedSources-input.xcfilelist:
690         * DumpRenderTree/DerivedSources-output.xcfilelist:
691         * WebKitTestRunner/DerivedSources-input.xcfilelist:
692         * WebKitTestRunner/DerivedSources-output.xcfilelist:
693
694 2019-01-25  Keith Rollin  <krollin@apple.com>
695
696         Fix missing dependencies in extract-dependencies-from-makefile
697         https://bugs.webkit.org/show_bug.cgi?id=193783
698         <rdar://problem/47201571>
699
700         Reviewed by Alex Christensen.
701
702         The extract-dependencies-from-makefile script generates .xcfilelists
703         for XCBuild by invoking a makefile in --debug mode, parsing the
704         dependency information in the output, and extracting information
705         regarding targets and dependents. However, the way `make` emits this
706         dependency information is not rigorous, and so we need to determine
707         what lines to look for and parse by trial and error. This approach
708         didn't coriginally atch all the information we needed to collect, so
709         update the script to look for the additional lines we now know to look
710         for.
711
712         * Scripts/extract-dependencies-from-makefile:
713         (Parser):
714         (Parser.addTarget):
715         (Parser.addPrereq):
716         (Parser.doParse):
717
718 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
719
720         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
721         https://bugs.webkit.org/show_bug.cgi?id=193297
722         <rdar://problem/47158841>
723
724         Reviewed by Alex Christensen.
725
726         * TestWebKitAPI/Tests/WebKit Cocoa/ResourceLoadStatistics.mm:
727             Revise tests to ensure a running NetworkProcess before attempting ResourceLoadStatistics operations.
728         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
729         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
730         activating the message used to trigger the callback when it is set.
731
732 2019-01-25  Alex Christensen  <achristensen@webkit.org>
733
734         WKWebView.goBack should reload if there is a safe browsing warning
735         https://bugs.webkit.org/show_bug.cgi?id=193805
736         <rdar://problem/46908216>
737
738         Reviewed by Geoff Garen.
739
740         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
741         (+[Simple3LookupContext sharedLookupContext]):
742         (-[Simple3LookupContext lookUpURL:completionHandler:]):
743         (-[WKWebViewGoBackNavigationDelegate webView:didFinishNavigation:]):
744         (TEST):
745
746 2019-01-25  Chris Dumez  <cdumez@apple.com>
747
748         Regression(PSON) cross-site provisional page is not canceled if a new same-site one is started
749         https://bugs.webkit.org/show_bug.cgi?id=193788
750         <rdar://problem/47531231>
751
752         Reviewed by Alex Christensen.
753
754         Add API test coverage.
755
756         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
757         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
758
759 2019-01-25  Jonathan Bedard  <jbedard@apple.com>
760
761         webkitpy: Missing PID in crashlog name should not be fatal (Follow-up fix)
762         https://bugs.webkit.org/show_bug.cgi?id=193771
763
764         Unreviewed infrastructure fix.
765
766         * Scripts/webkitpy/port/darwin.py:
767         (DarwinPort._merge_crash_logs): Correct syntax for catching multiple exception types.
768
769 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
770
771         * Scripts/webkitpy/common/config/contributors.json: Removing a stray comma.
772
773 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
774
775         Add contributors.json entries for Ling Ho and for a new bot watchers group.
776
777         * Scripts/webkitpy/common/config/contributors.json:
778
779 2019-01-25  Chris Dumez  <cdumez@apple.com>
780
781         Regression(PSON?) Crash under NavigationState::NavigationClient::decidePolicyForNavigationAction()
782         https://bugs.webkit.org/show_bug.cgi?id=193779
783         <rdar://problem/46170903>
784
785         Reviewed by Antti Koivisto.
786
787         Add API test that quickly navigates forward to a previous process without waiting for it to
788         suspend. I suspect the crash could have been happening due to receiving leftover IPC from
789         the process' previous page when reconnecting the it for the forward navigation.
790
791         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
792
793 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
794
795         Need a way for JavaScript (or bundle) code to participate in undo
796         https://bugs.webkit.org/show_bug.cgi?id=190009
797         <rdar://problem/44807048>
798
799         Reviewed by Ryosuke Niwa.
800
801         Add UIScriptController helpers to grab the platform undo and redo action labels. Currently only implemented for
802         Cocoa platforms in WebKit2. See other ChangeLogs for more detail.
803
804         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
805         (WTR::UIScriptController::lastUndoLabel const):
806         (WTR::UIScriptController::firstRedoLabel const):
807         (WTR::UIScriptController::platformUndoManager const):
808         * DumpRenderTree/mac/UIScriptControllerMac.mm:
809         (WTR::UIScriptController::lastUndoLabel const):
810         (WTR::UIScriptController::firstRedoLabel const):
811         (WTR::UIScriptController::platformUndoManager const):
812         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
813         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
814         (WTR::UIScriptController::lastUndoLabel const):
815         (WTR::UIScriptController::firstRedoLabel const):
816         * TestRunnerShared/UIScriptContext/UIScriptController.h:
817         * WebKitTestRunner/UIScriptControllerCocoa.mm:
818         (WTR::UIScriptController::lastUndoLabel const):
819         (WTR::UIScriptController::firstRedoLabel const):
820         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
821         (WTR::UIScriptController::platformUndoManager const):
822         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
823         (WTR::UIScriptController::platformUndoManager const):
824
825 2019-01-25  Zalan Bujtas  <zalan@apple.com>
826
827         [LFC][BFC][MarginCollapsing] Add "clear" to static position computation.
828         https://bugs.webkit.org/show_bug.cgi?id=193824
829
830         Reviewed by Antti Koivisto.
831
832         * LayoutReloaded/misc/LFC-passing-tests.txt:
833
834 2019-01-24  Ryan Haddad  <ryanhaddad@apple.com>
835
836         Update macOS JSC bot configurations
837         https://bugs.webkit.org/show_bug.cgi?id=193739
838
839         Reviewed by Alexey Proskuryakov.
840
841         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove 32-bit BuildAndTest queue.
842         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
843         (BubbleQueueServer): Move JSC EWS to Mojave section.
844         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
845         (WebKitBuildbot): Remove 32-bit BuildAndTest queue from dashboard.
846         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update unit test.
847
848 2019-01-24  Fujii Hironori  <Hironori.Fujii@sony.com>
849
850         [Win][WebKitTestRunner] Implement EventSenderProxy
851         https://bugs.webkit.org/show_bug.cgi?id=193755
852
853         Reviewed by Don Olmstead.
854
855         * WebKitTestRunner/EventSenderProxy.h: Removed unused members m_buttonState and m_mouseButtonsCurrentlyDown.
856         * WebKitTestRunner/win/EventSenderProxyWin.cpp:
857         (WTR::EventSenderProxy::dispatchMessage):
858         (WTR::EventSenderProxy::EventSenderProxy):
859         (WTR::EventSenderProxy::mouseDown):
860         (WTR::EventSenderProxy::mouseUp):
861         (WTR::EventSenderProxy::mouseMoveTo):
862         (WTR::EventSenderProxy::mouseScrollBy):
863         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
864
865 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
866
867         Unreviewed fix for API test failure after r240437.
868
869         TestWTF.WTF.StringOperators apparently can't deal with another test using String::operator+. This is fine...
870
871         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
872
873 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
874
875         [webkitdirs] iosSimulatorApplicationsPath may not have iOS.simruntime in its path
876         https://bugs.webkit.org/show_bug.cgi?id=193787
877         <rdar://problem/47497634>
878
879         Reviewed by Alexey Proskuryakov.
880
881         * Scripts/webkitdirs.pm:
882         (iosSimulatorApplicationsPath): Pick from available runtime directories.
883
884 2019-01-24  Truitt Savell  <tsavell@apple.com>
885
886         Unreviewed, rolling out r240446.
887
888         Casued 5 API failures
889
890         Reverted changeset:
891
892         "Activate the WebResourceLoadStatisticsStore in the
893         NetworkProcess and deactivate it in the UIProcess."
894         https://bugs.webkit.org/show_bug.cgi?id=193297
895         https://trac.webkit.org/changeset/240446
896
897 2019-01-24  Zalan Bujtas  <zalan@apple.com>
898
899         DidFirstVisuallyNonEmptyLayout milestone should always fire at some point.
900         https://bugs.webkit.org/show_bug.cgi?id=193741
901         <rdar://problem/47135030>
902
903         Reviewed by Antti Koivisto and Simon Fraser.
904
905         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
906         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
907         (TestWebKitAPI::TEST):
908
909 2019-01-24  Brent Fulgham  <bfulgham@apple.com>
910
911         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
912         https://bugs.webkit.org/show_bug.cgi?id=193297
913         <rdar://problem/47158841>
914
915         Reviewed by Alex Christensen.
916
917         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
918         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
919         activating the message used to trigger the callback when it is set.
920
921 2019-01-24  John Wilander  <wilander@apple.com>
922
923         Add Ad Click Attribution as an internal/experimental feature
924         https://bugs.webkit.org/show_bug.cgi?id=193685
925         <rdar://problem/47450399>
926
927         Reviewed by Brent Fulgham.
928
929         Added test option adClickAttributionEnabled.
930
931         * DumpRenderTree/TestOptions.cpp:
932         (TestOptions::TestOptions):
933         * DumpRenderTree/TestOptions.h:
934         * DumpRenderTree/mac/DumpRenderTree.mm:
935         (setWebPreferencesForTestOptions):
936
937 2019-01-24  Antti Koivisto  <antti@apple.com>
938
939         [PSON] Flash on back navigation on Mac
940         https://bugs.webkit.org/show_bug.cgi?id=193716
941         <rdar://problem/47148458>
942
943         Reviewed by Chris Dumez.
944
945         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
946
947         Closing of the previous page is delayed so waiting for didFinishNavigation is
948         not sufficient to guarantee we have received all the messages. Wait for them.
949
950 2019-01-24  Chris Dumez  <cdumez@apple.com>
951
952         Regression(PSON) Back/Forward list items' URL sometimes gets replaced with the URL of a subframe
953         https://bugs.webkit.org/show_bug.cgi?id=193761
954         <rdar://problem/47456405>
955
956         Reviewed by Alex Christensen.
957
958         Add API test coverage.
959
960         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
961
962 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
963
964         webkitpy: Missing PID in crashlog name should not be fatal
965         https://bugs.webkit.org/show_bug.cgi?id=193771
966
967         If we can't determine the PID of a crashlog, just ignore the crashlog instead
968         of raising an exception.
969
970         Reviewed by Lucas Forschler.
971
972         * Scripts/webkitpy/port/darwin.py:
973         (DarwinPort._merge_crash_logs):
974
975 2019-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
976
977         test_exporter.py: webkitpy.common.system.executive.ScriptError from create_branch_with_patch
978         https://bugs.webkit.org/show_bug.cgi?id=193746
979
980         Reviewed by Youenn Fablet.
981
982         It calls 'git apply --index --abort', but --abort is not a valid argument to 'git apply',
983         so we'd best just not call it.
984
985         * Scripts/webkitpy/w3c/test_exporter.py:
986         (WebPlatformTestExporter.create_branch_with_patch):
987
988 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
989
990         Move FileSystem to WTF
991         https://bugs.webkit.org/show_bug.cgi?id=193602
992
993         Reviewed by Yusuke Suzuki.
994
995         * DumpRenderTree/win/DumpRenderTree.cpp:
996         * TestWebKitAPI/CMakeLists.txt:
997         * TestWebKitAPI/PlatformGTK.cmake:
998         * TestWebKitAPI/PlatformJSCOnly.cmake:
999         * TestWebKitAPI/PlatformPlayStation.cmake:
1000         * TestWebKitAPI/PlatformWPE.cmake:
1001         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1002         * TestWebKitAPI/Tests/WTF/FileSystem.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp.
1003         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
1004         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
1005         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp:
1006         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
1007         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
1008         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1009         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
1010         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
1011
1012 2019-01-24  Philippe Normand  <pnormand@igalia.com>
1013
1014         [WPE] Remove hard dependency on subprocess32 for the API tests
1015
1016         Rubber-stamped by Carlos Garcia Campos.
1017
1018         * glib/api_test_runner.py:
1019         (TestRunner._run_test_qt): Lazily import subprocess32 and check
1020         its presence only when running WPEQt tests.
1021
1022 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1023
1024         [GLIB] Expose JavaScriptCore options in GLib public API
1025         https://bugs.webkit.org/show_bug.cgi?id=188742
1026
1027         Reviewed by Michael Catanzaro.
1028
1029         Add a test for the new API.
1030
1031         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1032         (testsJSCOptions):
1033         (main):
1034
1035 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1036
1037         [GTK][WPE] Support JPEG 2000 images
1038         https://bugs.webkit.org/show_bug.cgi?id=186272
1039
1040         Reviewed by Žan Doberšek.
1041
1042         Add OpenJPEG to jhbuild since 2.2.0 version is required and it's not available in debian stable.
1043
1044         * gtk/jhbuild.modules:
1045         * wpe/jhbuild.modules:
1046
1047 2019-01-23  David Kilzer  <ddkilzer@apple.com>
1048
1049         check-webkit-style should warn when using soft-linking macros in a header
1050         <https://webkit.org/b/193750>
1051
1052         Reviewed by Darin Adler.
1053
1054         * Scripts/webkitpy/style/checkers/cpp.py:
1055         (check_language): Add softlink/header check by refactoring the
1056         softlink/framework check.
1057         (CppChecker): Enable softlink/header check by default.
1058         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1059         (CppStyleTest.test_softlink_framework): Rename from
1060         CppStyleTest.test_softlink() and change test framework name in
1061         case AVFoundation gets its own AVFoundationSoftLink.{h,mm}
1062         files. Set file_name for macros that only appear in headers.
1063         (CppStyleTest.test_softlink_header): Add tests for using
1064         soft-link macros in headers.
1065
1066 2019-01-23  Chris Dumez  <cdumez@apple.com>
1067
1068         Deprecate API to limit the maximum number of WebProcesses
1069         https://bugs.webkit.org/show_bug.cgi?id=193725
1070         <rdar://problem/47464879>
1071
1072         Reviewed by Geoff Garen.
1073
1074         Update existing API tests to stop using deprecated API.
1075
1076         * MiniBrowser/mac/AppDelegate.m:
1077         (defaultConfiguration):
1078         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
1079         (TestWebKitAPI::TEST):
1080         * TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimer.mm:
1081         (TestWebKitAPI::TEST):
1082         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1083         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
1084         (TEST):
1085         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1086         (TEST):
1087
1088 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
1089
1090         [ews-app] Rename ews model buildermappings to buildermapping
1091         https://bugs.webkit.org/show_bug.cgi?id=193729
1092
1093         Reviewed by Lucas Forschler.
1094
1095         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/buildermappings.py.
1096         (BuilderMapping): Renamed BuildMappings to BuilderMapping.
1097         * BuildSlaveSupport/ews-app/ews/models/__init__.py: Ditto.
1098
1099 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
1100
1101         [ews-app] Rename ews model steps to step
1102         https://bugs.webkit.org/show_bug.cgi?id=193697
1103
1104         Reviewed by Lucas Forschler.
1105
1106         * BuildSlaveSupport/ews-app/ews/models/step.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/steps.py.
1107         (Step): Renamed Steps to Step.
1108
1109 2019-01-23  Sihui Liu  <sihui_liu@apple.com>
1110
1111         Clean up IndexedDB files between tests
1112         https://bugs.webkit.org/show_bug.cgi?id=192796
1113         <rdar://problem/46824999>
1114
1115         Reviewed by Geoffrey Garen.
1116
1117         * DumpRenderTree/mac/DumpRenderTree.mm:
1118         (runTest):
1119         * WebKitTestRunner/TestController.cpp:
1120         (WTR::TestController::resetStateToConsistentValues):
1121         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
1122         (WTR::RemoveAllIndexedDatabasesCallback):
1123         (WTR::TestController::ClearIndexedDatabases):
1124         * WebKitTestRunner/TestController.h:
1125         * WebKitTestRunner/TestInvocation.cpp:
1126         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1127
1128 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
1129
1130         [ews-app] Rename ews model Builds to Build
1131         https://bugs.webkit.org/show_bug.cgi?id=193695
1132
1133         Reviewed by Lucas Forschler.
1134
1135         * BuildSlaveSupport/ews-app/ews/models/build.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/builds.py.
1136         (Build): Renamed Builds to Build.
1137
1138 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
1139
1140         webkitpy: Wait longer when launching WebKitTestRunner
1141         https://bugs.webkit.org/show_bug.cgi?id=193734
1142
1143         Reviewed by Aakash Jain.
1144
1145         * Scripts/webkitpy/port/simulator_process.py:
1146         (SimulatorProcess._start): Increase timeout from 6 seconds to 15 seconds.
1147
1148 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
1149
1150         [iOS] fast/events/touch/ios/hover-when-style-change-is-async.html times out
1151         https://bugs.webkit.org/show_bug.cgi?id=193182
1152         <rdar://problem/47452154>
1153
1154         Reviewed by Tim Horton.
1155
1156         This test was timing out because one of its preceding tests (drag-to-autoscroll-in-single-line-editable.html)
1157         long presses and drags to select text, but does not end the touch by lifting up; subsequently, the tap gesture
1158         recognizer isn't fired when simulating a tap in hover-when-style-change-is-async.html.
1159
1160         To fix this, tweak the test runner to make it safe for tests to end while touching the web view without
1161         preventing later tests from recognizing gestures.
1162
1163         * WebKitTestRunner/ios/TestControllerIOS.mm:
1164         (WTR::TestController::platformResetStateToConsistentValues):
1165
1166         Cancel all touches in the UIApplication when resetting to a consistent state between tests.
1167
1168 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
1169
1170         webkitpy: Use correct config for --iphone-simulator and --ipad-simulator
1171         https://bugs.webkit.org/show_bug.cgi?id=193722
1172         <rdar://problem/47481475>
1173
1174         Reviewed by Lucas Forschler.
1175
1176         iPhone and iPad ports should both use the iOS config.
1177
1178         * Scripts/webkitpy/port/ios_simulator.py:
1179         (IPhoneSimulatorPort.__init__):
1180         (IPadSimulatorPort.__init__):
1181
1182 2019-01-23  Rob Buis  <rbuis@igalia.com>
1183
1184         Update MIME type parser
1185         https://bugs.webkit.org/show_bug.cgi?id=180526
1186
1187         Reviewed by Frédéric Wang.
1188
1189         Add unit tests for both parse modes of ParsedContentType.
1190
1191         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1192         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp: Added.
1193         (TestWebKitAPI::TEST):
1194
1195 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
1196
1197         [ews-app] fetch loop should not stop on network issues
1198         https://bugs.webkit.org/show_bug.cgi?id=193666
1199
1200         Reviewed by Lucas Forschler.
1201
1202         * BuildSlaveSupport/ews-app/ews/fetcher.py:
1203         (FetchLoop.run): Ensure that fetch loop doesn't exit on any exception.
1204
1205 2019-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1206
1207         [iOS] Multiple WKWebViewAutofillTests are flaky failures
1208         https://bugs.webkit.org/show_bug.cgi?id=189165
1209         <rdar://problem/47433765>
1210
1211         Reviewed by Tim Horton.
1212
1213         These tests are currently flaky because they expect an invocation of "Element.blur()" in the web process to
1214         immediately dispatch an IPC message to notify the UI process that the element has been blurred. In particular,
1215         the -textInputHasAutofillContext helper assumes that waiting for the next remote layer tree commit in the UI
1216         process in sufficient to ensure that any previous action that blurred the focused element in the web process
1217         would make its way to the UI process by the time the layer tree commit is finished.
1218
1219         However, WebPage::elementDidBlur sends its IPC message to the UI process asynchronously, using callOnMainThread.
1220         This means that if a layer tree flush was already scheduled in the web process before the element was blurred,
1221         the element blur IPC message to the UI process will lose the race against the layer tree commit, and the test
1222         will fail because it asks for -_autofillContext too early.
1223
1224         To fix this, we tweak these tests to actually wait until the intended input session change triggered by script
1225         is handled in the UI process.
1226
1227         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
1228
1229         Tweak some of these tests to wait for input session changes before checking for the presence of an autofill
1230         context. The only exception is an existing test that doesn't allow programmatic focus to begin input sessions
1231         by default; to fix this test, we simply wait for _WKInputDelegate to be invoked, instead of waiting for a new
1232         input session.
1233
1234         (-[AutofillTestView textInputHasAutofillContext]):
1235
1236         Remove the incorrect presentation update here. This helper now assumes that the UI process is up to date.
1237
1238         * TestWebKitAPI/cocoa/TestWKWebView.h:
1239         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1240         (nextInputSessionChangeCount):
1241
1242         Monotonically increasing identifier that's incremented whenever an input session is started in the UI process.
1243         This includes changing the focused element from one to another.
1244
1245         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
1246         (-[TestWKWebView didStartFormControlInteraction]):
1247         (-[TestWKWebView didEndFormControlInteraction]):
1248         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
1249
1250         Add a helper to evaluate JavaScript and wait for this script to cause some change in the input session. This
1251         handles three cases: (1) changing focus from an element that doesn't require an input session to one that does,
1252         (2) changing focus between elements that require input sessions, and (3) changing focus from an input session
1253         that doesn't require an input session to one that doesn't.
1254
1255 2019-01-22  David Kilzer  <ddkilzer@apple.com>
1256
1257         check-webkit-style reports false-positive whitespace/init warning in C++ initialization parameters
1258         <https://webkit.org/b/193676>
1259
1260         Reviewed by Alexey Proskuryakov.
1261
1262         * Scripts/webkitpy/style/checkers/cpp.py:
1263         (check_member_initialization_list):
1264         - Don't report missing whitespace around colon if the colon at
1265           the start of the line is formatted correctly.
1266         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1267         (WebKitStyleTest.test_member_initialization_list):
1268         - Add a test for a missing permutation of existing tests.
1269         - Add a test this false-positive.
1270         - Add blank lines between subtests to make them easier to read.
1271
1272 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
1273
1274         [build.webkit.org] Unit-test failure after r237113
1275         https://bugs.webkit.org/show_bug.cgi?id=193669
1276
1277         Reviewed by Michael Catanzaro.
1278
1279         * BuildSlaveSupport/build.webkit.org-config/factories.py:
1280         (Factory.__init__): Properly check for --no-experimental-features flag when additionalArguments has 
1281         multiple or zero flags.
1282
1283 2019-01-22  Tadeu Zagallo  <tzagallo@apple.com>
1284
1285         Cache bytecode to disk
1286         https://bugs.webkit.org/show_bug.cgi?id=192782
1287         <rdar://problem/46084932>
1288
1289         Reviewed by Keith Miller.
1290
1291         Add test helper to execute bytecode-cache tests: it executes each test
1292         twice, the first with JSC_diskCachePath set to a temporary directory
1293         and second with JSC_forceDiskCache=true (in addition to the cache path)
1294         to guarantee that only the disk cache is being used and no new
1295         UnlinkedCodeBlocks are being created.
1296
1297         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh: Added.
1298         * Scripts/run-jsc-stress-tests:
1299
1300 2019-01-22  Oriol Brufau  <obrufau@igalia.com>
1301
1302         [css-logical] Implement flow-relative margin, padding and border shorthands
1303         https://bugs.webkit.org/show_bug.cgi?id=188697
1304
1305         Reviewed by Simon Fraser and Antti Koivisto.
1306
1307         * DumpRenderTree/TestOptions.cpp:
1308         (TestOptions::TestOptions):
1309         * DumpRenderTree/TestOptions.h:
1310         * DumpRenderTree/mac/DumpRenderTree.mm:
1311         (setWebPreferencesForTestOptions):
1312         Allow tests to enable the CSSLogicalEnabled flag in WK1.
1313
1314         * Scripts/webkitpy/style/checkers/jsonchecker.py:
1315         (JSONCSSPropertiesChecker.check_codegen_properties):
1316         Allow CSS property definitions to have a 'runtime-flag' parameter which
1317         disables the property when the specified runtime flag is disabled.
1318
1319 2019-01-21  Fujii Hironori  <Hironori.Fujii@sony.com>
1320
1321         [GTK][WPE] libgcrypt-1.7.6 can't be compiled on Ubuntu 18.10
1322         https://bugs.webkit.org/show_bug.cgi?id=193643
1323
1324         Reviewed by Michael Catanzaro.
1325
1326         * gtk/jhbuild.modules: Bumped to libgcrypt-1.8.4.
1327         * wpe/jhbuild.modules: Ditto.
1328
1329 2019-01-21  Zalan Bujtas  <zalan@apple.com>
1330
1331         [LFC][Floats] Take float top position into account when computing containing block height.
1332         https://bugs.webkit.org/show_bug.cgi?id=193655
1333
1334         Reviewed by Antti Koivisto.
1335
1336         * LayoutReloaded/misc/LFC-passing-tests.txt:
1337
1338 2019-01-21  David Kilzer  <ddkilzer@apple.com>
1339
1340         Switch remaining VideoToolbox soft-linking in WebCore over to VideoToolboxSoftLink.{cpp,h}
1341         <https://webkit.org/b/193645>
1342         <rdar://problem/47421574>
1343
1344         Reviewed by Alex Christensen.
1345
1346         - Now checks for local soft-linking of all frameworks that have
1347           their own *SoftLinking.{cpp,h,mm} files.
1348         - Changes softlink/uikit warning to softlink/framework.
1349
1350         * Scripts/webkitpy/style/checkers/cpp.py:
1351         (check_language):
1352         (CppChecker):
1353         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1354         (CppStyleTest):
1355
1356 2019-01-20  Saam Barati  <sbarati@apple.com>
1357
1358         Rollout r240210: It broke tests on iOS
1359         https://bugs.webkit.org/show_bug.cgi?id=193640
1360
1361         Unreviewed.
1362
1363         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper:
1364         * Scripts/run-jsc-stress-tests:
1365
1366 2019-01-20  chris fleizach  <cfleizach@apple.com>
1367
1368         AX: Support returning relative frames for accessibility
1369         https://bugs.webkit.org/show_bug.cgi?id=193414
1370         <rdar://problem/47268501>
1371
1372         Reviewed by Zalan Bujtas.
1373
1374         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1375         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1376         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1377         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
1378         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1379         (WTR::attributesOfElement):
1380         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
1381
1382 2019-01-20  Yusuke Suzuki  <ysuzuki@apple.com>
1383
1384         Unreviewed, add my new email address
1385
1386         * Scripts/webkitpy/common/config/contributors.json:
1387
1388 2019-01-19  Zalan Bujtas  <zalan@apple.com>
1389
1390         [LFC][BFC] <body>'s overflow property value is propagated to viewport
1391         https://bugs.webkit.org/show_bug.cgi?id=193617
1392
1393         Reviewed by Antti Koivisto.
1394
1395         * LayoutReloaded/misc/LFC-passing-tests.txt:
1396
1397 2019-01-20  Michael Catanzaro  <mcatanzaro@igalia.com>
1398
1399         Unreviewed, rolling out r240209.
1400
1401         Broke GTK/WPE injected bundle
1402
1403         Reverted changeset:
1404
1405         "AX: Support returning relative frames for accessibility"
1406         https://bugs.webkit.org/show_bug.cgi?id=193414
1407         https://trac.webkit.org/changeset/240209
1408
1409 2019-01-12  Dan Bernstein  <mitz@apple.com>
1410
1411         [Cocoa] Avoid importing directly from subumbrella frameworks
1412         https://bugs.webkit.org/show_bug.cgi?id=186016
1413         <rdar://problem/40591038>
1414
1415         Reviewed by Sam Weinig.
1416
1417         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
1418           LaunchServices header.
1419         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
1420           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
1421         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
1422           when using SDKs earlier than 10.13.
1423         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
1424           and OTHER_CPLUSPLUSFLAGS.
1425         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
1426           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
1427         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
1428           LaunchServices header.
1429
1430 2019-01-20  Tadeu Zagallo  <tzagallo@apple.com>
1431
1432         Cache bytecode to disk
1433         https://bugs.webkit.org/show_bug.cgi?id=192782
1434         <rdar://problem/46084932>
1435
1436         Reviewed by Keith Miller.
1437
1438         Add test helper to execute bytecode-cache tests: it executes each test
1439         twice, the first with JSC_diskCachePath set to a temporary directory
1440         and second with JSC_forceDiskCache=true (in addition to the cache path)
1441         to guarantee that only the disk cache is being used and no new
1442         UnlinkedCodeBlocks are being created.
1443
1444         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper: Added.
1445         * Scripts/run-jsc-stress-tests:
1446
1447 2019-01-20  chris fleizach  <cfleizach@apple.com>
1448
1449         AX: Support returning relative frames for accessibility
1450         https://bugs.webkit.org/show_bug.cgi?id=193414
1451         <rdar://problem/47268501>
1452
1453         Reviewed by Zalan Bujtas.
1454
1455         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1456         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1457         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1458         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
1459         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1460         (WTR::attributesOfElement):
1461         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
1462
1463 2019-01-20  Antoine Quint  <graouts@apple.com>
1464
1465         Add a POINTER_EVENTS feature flag
1466         https://bugs.webkit.org/show_bug.cgi?id=193577
1467         <rdar://problem/47408511>
1468
1469         Unreviewed. Also enable Pointer Events for iosmac.
1470
1471         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1472
1473 2019-01-19  Zalan Bujtas  <zalan@apple.com>
1474
1475         [LFC][Floats] Ensure that floats in FloatingContext::m_floats are always horizontally ordered.
1476         https://bugs.webkit.org/show_bug.cgi?id=193613
1477
1478         Reviewed by Antti Koivisto.
1479
1480         * LayoutReloaded/misc/LFC-passing-tests.txt:
1481
1482 2019-01-19  Antoine Quint  <graouts@apple.com>
1483
1484         Add a POINTER_EVENTS feature flag
1485         https://bugs.webkit.org/show_bug.cgi?id=193577
1486
1487         Reviewed by Dean Jackson.
1488
1489         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1490
1491 2019-01-18  Zhifei FANG  <zhifei_fang@apple.com>
1492
1493         Disable the run-jsc-stress-test remote host key check [second round].
1494         https://bugs.webkit.org/show_bug.cgi?id=192988
1495
1496         Reviewed by Dewei Zhu.
1497
1498         * Scripts/run-jsc-stress-tests:
1499
1500 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
1501
1502         [build.webkit.org] unit-test failure Builder GTK Linux 32-bit Release doesn't exist
1503         https://bugs.webkit.org/show_bug.cgi?id=193597
1504
1505         Reviewed by Lucas Forschler.
1506
1507         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1508
1509 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
1510
1511         [build.webkit.org] api tests failures are incorrectly named as unit test failures
1512         https://bugs.webkit.org/show_bug.cgi?id=193595
1513
1514         Reviewed by Lucas Forschler.
1515
1516         * BuildSlaveSupport/build.webkit.org-config/factories.py: Renamed RunUnitTests to RunAPITests.
1517         * BuildSlaveSupport/build.webkit.org-config/steps.py: Ditto.
1518         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Ditto.
1519
1520 2019-01-18  Chris Dumez  <cdumez@apple.com>
1521
1522         Regression(PSON) Content blockers are sometimes lost on back navigation cross-site
1523         https://bugs.webkit.org/show_bug.cgi?id=193588
1524         <rdar://problem/47131566>
1525
1526         Reviewed by Alex Christensen.
1527
1528         Add layout test coverage.
1529
1530         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1531
1532 2019-01-18  Jer Noble  <jer.noble@apple.com>
1533
1534         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
1535         https://bugs.webkit.org/show_bug.cgi?id=189553
1536
1537         Reviewed by Tim Horton.
1538
1539         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
1540
1541         * ContentExtensionTester/Configurations/Base.xcconfig:
1542         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
1543         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1544         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
1545         * ImageDiff/cg/Configurations/Base.xcconfig:
1546         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
1547         * MiniBrowser/Configurations/Base.xcconfig:
1548         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
1549         * MobileMiniBrowser/Configurations/Base.xcconfig:
1550         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
1551         * Scripts/webkitpy/style/checker.py:
1552         (_all_categories):
1553         (FileType):
1554         (CheckerDispatcher._file_type):
1555         (CheckerDispatcher._create_checker):
1556         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
1557         (SDKVariantChecker):
1558         (SDKVariantChecker.__init__):
1559         (SDKVariantChecker.check):
1560         * TestWebKitAPI/Configurations/Base.xcconfig:
1561         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
1562         * WebEditingTester/Configurations/Base.xcconfig:
1563         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
1564         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
1565         * WebKitTestRunner/Configurations/Base.xcconfig:
1566         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
1567         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
1568         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
1569
1570 2019-01-18  David Kilzer  <ddkilzer@apple.com>
1571
1572         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
1573         <https://webkit.org/b/193568>
1574         <rdar://problem/47381130>
1575
1576         Reviewed by Alex Christensen.
1577
1578         Make sure no one re-introduces UIKit soft-linking by adding a
1579         style rule.
1580
1581         * Scripts/webkitpy/style/checkers/cpp.py:
1582         (check_language): Add softlink/uikit check.
1583         (CppChecker): Enable softlink/uikit check.
1584         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1585         (CppStyleTest): Add test for softlink/uikit.
1586
1587 2019-01-18  Joanmarie Diggs  <jdiggs@igalia.com>
1588
1589         [GTK] install-dependencies tool looks for libunistring-dev for dnf
1590         https://bugs.webkit.org/show_bug.cgi?id=193584
1591
1592         Change "-dev" to "-devel".
1593
1594         Reviewed by Michael Catanzaro.
1595
1596         * gtk/install-dependencies:
1597
1598 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
1599
1600         webkitpy: Add iPhone and iPad ports
1601         https://bugs.webkit.org/show_bug.cgi?id=193537
1602         <rdar://problem/47353390>
1603
1604         Reviewed by Lucas Forschler.
1605
1606         Add --iphone-simulator and --ipad-simulator commands to run-webkit-tests which separate iPhone and iPad into separate
1607         ports. Note that this separation is optional, the --ios-simulator command remains.
1608
1609         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1610         (RunTest.test_device_type_test_division): Drive-by fix.
1611         (RunTest.test_device_type_specific_listing): Ditto.
1612         (RunTest.test_ipad_test_division):
1613         (RunTest):
1614         (RunTest.test_ipad_listing):
1615         * Scripts/webkitpy/port/factory.py:
1616         (platform_options): Add --iphone-simulator and --ipad-simulator flags.
1617         (PortFactory):
1618         * Scripts/webkitpy/port/ios_simulator.py:
1619         (IPhoneSimulatorPort):
1620         (IPadSimulatorPort):
1621
1622 2019-01-18  Chris Dumez  <cdumez@apple.com>
1623
1624         Regression(PSON) Scroll position is not always restored properly when navigating back
1625         https://bugs.webkit.org/show_bug.cgi?id=193578
1626         <rdar://problem/47386331>
1627
1628         Reviewed by Tim Horton.
1629
1630         Add API test coverage.
1631
1632         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1633
1634 2019-01-18  Youenn Fablet  <youenn@apple.com>
1635
1636         Add a new SPI to request for cache storage quota increase
1637         https://bugs.webkit.org/show_bug.cgi?id=193323
1638
1639         Reviewed by Alex Christensen.
1640
1641         Implement WebsiteDataStore quota delegate to handle quota requests.
1642         By default, do not update quota.
1643         Update quota if test calls the new testRunner.allowCacheStorageQuotaIncrease method.
1644
1645         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1646         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1647         (WTR::TestRunner::allowCacheStorageQuotaIncrease):
1648         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1649         * WebKitTestRunner/TestController.cpp:
1650         (WTR::TestController::allowCacheStorageQuotaIncrease):
1651         * WebKitTestRunner/TestController.h:
1652         * WebKitTestRunner/TestInvocation.cpp:
1653         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1654         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1655         (-[CacheStorageQuotaManager init]):
1656         (-[CacheStorageQuotaManager _requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
1657         (WTR::initializeWebViewConfiguration):
1658         (WTR::TestController::cocoaResetStateToConsistentValues):
1659         (WTR::TestController::allowCacheStorageQuotaIncrease):
1660
1661 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
1662
1663         [ews-build] Pass owner to the triggered builds
1664         https://bugs.webkit.org/show_bug.cgi?id=193574
1665
1666         Reviewed by Lucas Forschler.
1667
1668         * BuildSlaveSupport/ews-build/factories.py:
1669         (BuildFactory.propertiesToPassToTriggers):
1670
1671 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
1672
1673         [ews-app] Send patch author as a build property
1674         https://bugs.webkit.org/show_bug.cgi?id=193560
1675
1676         Reviewed by Lucas Forschler.
1677
1678         * BuildSlaveSupport/ews-app/ews/fetcher.py:
1679         (BugzillaPatchFetcher.fetch):
1680
1681 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
1682
1683         webkitpy: Implement device type specific expected results (Follow-up fix)
1684         https://bugs.webkit.org/show_bug.cgi?id=192162
1685         <rdar://problem/46345449>
1686
1687         Unreviewed infrastructure fix.
1688
1689         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1690         (Manager.run): Don't boot a device if no tests are available to run on it.
1691
1692 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
1693
1694         webkitpy: Implement device type specific expected results (Follow-up fix)
1695         https://bugs.webkit.org/show_bug.cgi?id=192162
1696         <rdar://problem/46345449>
1697
1698         Unreviewed infrastructure fix.
1699
1700         * Scripts/webkitpy/api_tests/manager.py:
1701         (Manager._initialize_devices): Use DEVICE_TYPE when running API tests.
1702
1703 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
1704
1705         webkitpy: Implement device type specific expected results (Part 2)
1706         https://bugs.webkit.org/show_bug.cgi?id=192162
1707         <rdar://problem/46345449>
1708
1709         Rubber-stamped by Aakash Jain.
1710
1711         This change uses device_type to select a different set of TestExpectation files based on the type of device running
1712         tests. This requires multiple baseline search paths to be used in a single instantiation of run-webkit-tests. Note
1713         that while multiple baseline search paths are used, any single test will only ever be run on a single device type.
1714
1715         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
1716         (LayoutTestFinder.find_tests): Pass device_type through.
1717         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py:
1718         (LayoutTestFinderTests.test_touched_but_skipped_test): Allow device_type to be passed in.
1719         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1720         (Manager.__init__): Make _expectations an OrderedDict indexed by device_type, add current_device_type.
1721         (Manager._collect_tests): Pass device type to test finder.
1722         (Manager._needs_web_platform_test):
1723         (Manager._prepare_lists): Index _expectations by device type.
1724         (Manager._test_input_for_file):
1725         (Manager._test_is_slow): Ditto.
1726         (Manager._test_should_dump_jsconsolelog_in_stderr):
1727         (Manager._test_should_dump_jsconsolelog_in_stderr): Ditto.
1728         (Manager._get_test_inputs):
1729         (Manager._update_worker_count):
1730         (Manager._set_up_run): Use current_device_type instead of passing device_type in.
1731         (Manager.run): Re-write function to gather and parse expectations from multiple baseline search paths. In the event
1732         that a test can be run on multiple device types, the first device in the device type list which is eligible will be
1733         the one which runs the test.
1734         (Manager._run_test_subset):
1735         (Manager._run_tests): Index _expectations by current_device_type.
1736         (Manager._print_expectation_line_for_test): Ditto.
1737         (Manager._print_expectations_for_subset): Ditto.
1738         (Manager.print_expectations): Re-write function to gather and parse expectations from multiple baseline search paths.
1739         Unlike run, this function will behave the same regardless of what devices are available.
1740         (Manager._custom_device_for_test): Deleted.
1741         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1742         (ManagerTest.test_uses_custom_device): Deleted.
1743         (ManagerTest.test_uses_custom_device.get_manager): Deleted.
1744         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1745         (JSONLayoutResultsGenerator.__init__): Pass expectations as a dictionary indexed by device type.
1746         (JSONLayoutResultsGenerator._insert_failure_summaries): The number of fixable tests must take into consideration
1747         all of the expectations.
1748         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
1749         (FakePort.skipped_layout_tests): Allow device_type to be passed in.
1750         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1751         (TestExpectations.__init__): Allow device_type to be passed through.
1752         (TestExpectations.parse_all_expectations): Pick expectations_dict by device type.
1753         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Allow device_type to be passed in.
1754         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1755         (summarize_results):
1756         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
1757         (summarized_results): Expectations are stored in a dictionary indexed by device_type. When determining the expectation
1758         a test ran with, one must check all expectations to find the first non-skip expectation.
1759         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1760         (RunTest.test_device_type_test_division):
1761         (RunTest):
1762         (RunTest.test_device_type_specific_listing):
1763         * Scripts/webkitpy/port/base.py:
1764         (Port): Add default values for DEVICE_TYPE and DEFAULT_DEVICE_TYPES.
1765         (Port.supported_device_types): The result of this function will change based on what devices are available.
1766         * Scripts/webkitpy/port/device_port.py:
1767         (DevicePort._device_type_with_version): Replace DEFAULT_DEVICE_TYPE with DEVICE_TYPE.
1768         (DevicePort.default_child_processes): DEVICE_TYPE is a general type, so the built-in comparison of the DeviceType object
1769         can be used.
1770         (DevicePort.supported_device_types): Generates a list of device types determined by the available devices, if there are
1771         any, or the DEFAULT_DEVICE_TYPES of the port.
1772         * Scripts/webkitpy/port/ios.py:
1773         (IOSPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
1774         * Scripts/webkitpy/port/ios_simulator.py:
1775         (IOSSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the devices currently used to run layout tests.
1776         * Scripts/webkitpy/port/watch.py:
1777         (WatchPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
1778         * Scripts/webkitpy/port/watch_simulator.py:
1779         (WatchSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the device currently used to run layout tests.
1780         * Scripts/webkitpy/xcode/device_type.py:
1781         (DeviceType):
1782         (DeviceType.__hash__): Allow DeviceType to be used as a dictionary index.
1783
1784 2019-01-18  Philippe Normand  <pnormand@igalia.com>
1785
1786         [WPE] run-qt-wpe-minibrowser needlessly expects a --wpe argument
1787         https://bugs.webkit.org/show_bug.cgi?id=193575
1788
1789         Reviewed by Michael Catanzaro.
1790
1791         Allow the script to run without explicit port argument because
1792         it's specific to the WPE port anyway.
1793
1794         * Scripts/run-qt-wpe-minibrowser: Manually insert --wpe in argv
1795         and simplify the rest of the code accordingly.
1796
1797 2019-01-18  Charlie Turner  <cturner@igalia.com>
1798
1799         [GStreamer][EME][ClearKey] Request keys from CDMInstance rather than passing via bus messages
1800         https://bugs.webkit.org/show_bug.cgi?id=192229
1801
1802         Reviewed by Xabier Rodriguez-Calvar.
1803
1804         * MiniBrowser/wpe/main.cpp:
1805         (main): Enable encrypted-media by default.
1806
1807 2019-01-18  Philippe Normand  <pnormand@igalia.com>
1808
1809         [Flatpak] Missing KeyboardInterrupt exception handler
1810         https://bugs.webkit.org/show_bug.cgi?id=193570
1811
1812         Reviewed by Michael Catanzaro.
1813
1814         * flatpak/flatpakutils.py:
1815         (WebkitFlatpak.run_in_sandbox): Basic KeyboardInterrupt handling.
1816
1817 2019-01-18  Zalan Bujtas  <zalan@apple.com>
1818
1819         [LFC][BFC][MarginCollapsing] Collapsing through should not ignore floats.
1820         https://bugs.webkit.org/show_bug.cgi?id=193564
1821
1822         Reviewed by Antti Koivisto.
1823
1824         * LayoutReloaded/misc/LFC-passing-tests.txt:
1825
1826 2019-01-18  Zalan Bujtas  <zalan@apple.com>
1827
1828         [LFC] Do not skip float boxes that are not part of the current formatting context when computing bottom.
1829         https://bugs.webkit.org/show_bug.cgi?id=193562
1830
1831         Reviewed by Antti Koivisto.
1832
1833         * LayoutReloaded/misc/LFC-passing-tests.txt:
1834
1835 2019-01-18  Zalan Bujtas  <zalan@apple.com>
1836
1837         [LFC][BFC] Check for inflow children while computing height for block formatting context roots.
1838         https://bugs.webkit.org/show_bug.cgi?id=193555
1839
1840         Reviewed by Antti Koivisto.
1841
1842         * LayoutReloaded/misc/LFC-passing-tests.txt:
1843
1844 2019-01-18  Philippe Normand  <pnormand@igalia.com>
1845
1846         [WPE] Add Qt extension
1847         https://bugs.webkit.org/show_bug.cgi?id=191464
1848
1849         Reviewed by Carlos Garcia Campos.
1850
1851         MiniBrowser and API tests for the WPE Qt API. To run the
1852         MiniBrowser a new script is introduced. Example invocation:
1853
1854         $ run-qt-wpe-minibrowser -platform wayland https://webkit.org
1855
1856         Also note-worthy is the introduction of the python2-subprocess32
1857         dependency to run the GLib API tests.
1858
1859         * MiniBrowser/wpe/CMakeLists.txt:
1860         * MiniBrowser/wpe/qt/CMakeLists.txt: Added.
1861         * MiniBrowser/wpe/qt/main.cpp: Added.
1862         (main):
1863         * MiniBrowser/wpe/qt/main.qml: Added.
1864         * MiniBrowser/wpe/qt/qml.qrc: Added.
1865         * Scripts/run-gtk-tests:
1866         (GtkTestRunner.is_google_test):
1867         (GtkTestRunner):
1868         (GtkTestRunner.is_qt_test):
1869         * Scripts/run-qt-wpe-minibrowser: Added.
1870         * Scripts/run-wpe-tests:
1871         (WPETestRunner):
1872         (WPETestRunner.is_google_test):
1873         (WPETestRunner.is_qt_test):
1874         * TestWebKitAPI/Tests/WPEQt/TestLoad.cpp: Added.
1875         (TestLoad::main):
1876         * TestWebKitAPI/Tests/WPEQt/TestLoadHtml.cpp: Added.
1877         (TestLoadHtml::main):
1878         * TestWebKitAPI/Tests/WPEQt/TestLoadRequest.cpp: Added.
1879         (TestLoadRequest::main):
1880         * TestWebKitAPI/Tests/WPEQt/TestRunJavaScript.cpp: Added.
1881         (TestRunJavaScript::main):
1882         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.cpp: Added.
1883         (waitForSignal):
1884         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.h: Added.
1885         (LoadSpy::LoadSpy):
1886         (LoadSpy::~LoadSpy):
1887         (LoadSpy::onLoadingChanged):
1888         (LoadStartedCatcher::LoadStartedCatcher):
1889         (LoadStartedCatcher::~LoadStartedCatcher):
1890         (LoadStartedCatcher::onLoadingChanged):
1891         (waitForLoadSucceeded):
1892         (waitForLoadFailed):
1893         * TestWebKitAPI/glib/CMakeLists.txt:
1894         * flatpak/flatpakutils.py:
1895         (WebkitFlatpak.load_from_args):
1896         (WebkitFlatpak.__init__):
1897         (WebkitFlatpak.clean_args):
1898         (WebkitFlatpak.run_in_sandbox):
1899         * flatpak/org.webkit.CommonModules.yaml:
1900         * flatpak/org.webkit.WPE.yaml:
1901         * flatpak/org.webkit.WPEModules.yaml:
1902         * flatpak/org.webkit.WPEQT.yaml: Copied from Tools/flatpak/org.webkit.WebKit.yaml.
1903         * flatpak/org.webkit.WebKit.yaml:
1904         * glib/api_test_runner.py:
1905         (TestRunner._run_test_qt):
1906         (TestRunner.is_qt_test):
1907         (TestRunner._run_test):
1908
1909 2019-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
1910
1911         [iOS] Content offset jumps erratically when autoscrolling near scroll view content inset areas
1912         https://bugs.webkit.org/show_bug.cgi?id=193494
1913         <rdar://problem/46859627>
1914
1915         Reviewed by Simon Fraser and Tim Horton.
1916
1917         Add a new test option to add a top content inset to the test runner's WKWebView's scroll view, and automatically
1918         scroll to reveal this top content inset area when beginning the test (i.e., scroll to (0, -topContentInset)).
1919
1920         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1921         (WTR::UIScriptController::contentOffsetX const):
1922         (WTR::UIScriptController::contentOffsetY const):
1923         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1924         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1925         (WTR::UIScriptController::contentOffsetX const):
1926         (WTR::UIScriptController::contentOffsetY const):
1927         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1928
1929         Also add new UIScriptController methods to ask for the content offset of the platform scroll view.
1930
1931         * WebKitTestRunner/TestController.cpp:
1932         (WTR::updateTestOptionsFromTestHeader):
1933         * WebKitTestRunner/TestOptions.h:
1934         (WTR::TestOptions::hasSameInitializationOptions const):
1935         * WebKitTestRunner/ios/TestControllerIOS.mm:
1936         (WTR::TestController::platformResetStateToConsistentValues):
1937         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1938         (WTR::UIScriptController::contentOffsetX const):
1939         (WTR::UIScriptController::contentOffsetY const):
1940
1941 2019-01-17  Truitt Savell  <tsavell@apple.com>
1942
1943         Unreviewed, rolling out r240124.
1944
1945         This commit broke an internal build.
1946
1947         Reverted changeset:
1948
1949         "SDK_VARIANT build destinations should be separate from non-
1950         SDK_VARIANT builds"
1951         https://bugs.webkit.org/show_bug.cgi?id=189553
1952         https://trac.webkit.org/changeset/240124
1953
1954 2019-01-17  Alex Christensen  <achristensen@webkit.org>
1955
1956         Fix string concatenation API test after r239920
1957         https://bugs.webkit.org/show_bug.cgi?id=193551
1958         <rdar://problem/47359304>
1959
1960         Reviewed by Youenn Fablet.
1961
1962         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
1963         (TestWebKitAPI::TEST):
1964         Cocoa platforms' interpretation of UChar/unsigned short equality is not affected by ICU's recent change of UChar's type
1965         in WebKit's build configuration like it apparently is on Linux.
1966
1967 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
1968
1969         [ews-build] validate-patch should handle the case when bug_id is None
1970         https://bugs.webkit.org/show_bug.cgi?id=193547
1971
1972         Reviewed by Lucas Forschler.
1973
1974         * BuildSlaveSupport/ews-build/steps.py:
1975         (ValidatePatch._is_bug_closed): Gracefully handle the case when bug_id is None.
1976         (ValidatePatch.start): If bug_id is set as None in build properties, fetch it from the patch.
1977
1978 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
1979
1980         [ews-build] Add patch author information in build
1981         https://bugs.webkit.org/show_bug.cgi?id=193465
1982
1983         Reviewed by Lucas Forschler.
1984
1985         * BuildSlaveSupport/ews-build/steps.py:
1986         (ValidatePatch._is_patch_obsolete):
1987
1988 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
1989
1990         [ews-build] Pass bug_id to the triggered builds
1991         https://bugs.webkit.org/show_bug.cgi?id=193548
1992
1993         Reviewed by Lucas Forschler.
1994
1995         * BuildSlaveSupport/ews-build/factories.py:
1996         (BuildFactory.propertiesToPassToTriggers):
1997
1998 2019-01-17  Jer Noble  <jer.noble@apple.com>
1999
2000         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
2001         https://bugs.webkit.org/show_bug.cgi?id=189553
2002
2003         Reviewed by Tim Horton.
2004
2005         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
2006
2007         * ContentExtensionTester/Configurations/Base.xcconfig:
2008         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
2009         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2010         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
2011         * ImageDiff/cg/Configurations/Base.xcconfig:
2012         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
2013         * MiniBrowser/Configurations/Base.xcconfig:
2014         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
2015         * MobileMiniBrowser/Configurations/Base.xcconfig:
2016         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
2017         * Scripts/webkitpy/style/checker.py:
2018         (_all_categories):
2019         (FileType):
2020         (CheckerDispatcher._file_type):
2021         (CheckerDispatcher._create_checker):
2022         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
2023         (SDKVariantChecker):
2024         (SDKVariantChecker.__init__):
2025         (SDKVariantChecker.check):
2026         * TestWebKitAPI/Configurations/Base.xcconfig:
2027         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
2028         * WebEditingTester/Configurations/Base.xcconfig:
2029         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
2030         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
2031         * WebKitTestRunner/Configurations/Base.xcconfig:
2032         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
2033         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
2034         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
2035
2036 2019-01-17  Zalan Bujtas  <zalan@apple.com>
2037
2038         [LFC][BFC] An element with transform is a containing block for positioned descendants.
2039         https://bugs.webkit.org/show_bug.cgi?id=193534
2040
2041         Reviewed by Antti Koivisto.
2042
2043         * LayoutReloaded/misc/LFC-passing-tests.txt:
2044
2045 2019-01-17  Zalan Bujtas  <zalan@apple.com>
2046
2047         [LFC][BFC][Quirk] Take body padding and border into account when stretching height.
2048         https://bugs.webkit.org/show_bug.cgi?id=193528
2049
2050         Reviewed by Antti Koivisto.
2051
2052         * LayoutReloaded/misc/LFC-passing-tests.txt:
2053
2054 2019-01-17  Zalan Bujtas  <zalan@apple.com>
2055
2056         [LFC][BFC] For height computation, the bottom edge of the last line box value should include top border/padding
2057         https://bugs.webkit.org/show_bug.cgi?id=193520
2058
2059         Reviewed by Antti Koivisto.
2060
2061         * LayoutReloaded/misc/LFC-passing-tests.txt:
2062
2063 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
2064
2065         [ews-build] unapply-patch step should not update source
2066         https://bugs.webkit.org/show_bug.cgi?id=193234
2067
2068         Reviewed by Lucas Forschler.
2069
2070         * BuildSlaveSupport/ews-build/steps.py:
2071         (CleanWorkingDirectory): Use clean-webkit script to clean the working directory.
2072         (UnApplyPatchIfRequired): Use CleanWorkingDirectory as base class.
2073
2074 2019-01-16  Youenn Fablet  <youenn@apple.com>
2075
2076         Add a new SPI for controlling getUserMedia
2077         https://bugs.webkit.org/show_bug.cgi?id=192793
2078
2079         Reviewed by Eric Carlson.
2080
2081         * MiniBrowser/mac/WK2BrowserWindowController.m:
2082         (-[WK2BrowserWindowController _webView:requestUserMediaAuthorizationForFrame:devices:decisionHandler:]):
2083         (-[WK2BrowserWindowController _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
2084         * TestWebKitAPI/Tests/WebKit/GetUserMediaNavigation.mm:
2085         (-[NavigationWhileGetUserMediaPromptDisplayedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
2086         * TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm:
2087         (-[GetUserMediaRepromptUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
2088         * TestWebKitAPI/Tests/WebKit/MediaStreamTrackDetached.mm:
2089         (-[MediaStreamTrackDetachedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
2090         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
2091         (-[UserMediaUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
2092         (-[UserMediaUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
2093         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaSimulateFailedSandbox.mm:
2094         (-[SimulateFailedSandboxUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
2095         (-[SimulateFailedSandboxUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
2096
2097 2019-01-16  Zalan Bujtas  <zalan@apple.com>
2098
2099         [LFC][BFC] Inflow non-replaced used width should not be negative.
2100         https://bugs.webkit.org/show_bug.cgi?id=193495
2101
2102         Reviewed by Antti Koivisto.
2103
2104         * LayoutReloaded/misc/LFC-passing-tests.txt:
2105
2106 2019-01-16  Chris Dumez  <cdumez@apple.com>
2107
2108         Regression(PSON) View becomes blank after click a cross-site download link
2109         https://bugs.webkit.org/show_bug.cgi?id=193361
2110         <rdar://problem/47099573>
2111
2112         Reviewed by Geoffrey Garen.
2113
2114         Add API test coverage.
2115
2116         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2117         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2118
2119 2019-01-16  Zalan Bujtas  <zalan@apple.com>
2120
2121         [LFC][Out-of-flow] Set used vertical margin values when top/height/bottom are non-auto.
2122         https://bugs.webkit.org/show_bug.cgi?id=193470
2123
2124         Reviewed by Antti Koivisto.
2125
2126         * LayoutReloaded/misc/LFC-passing-tests.txt:
2127
2128 2019-01-16  Zalan Bujtas  <zalan@apple.com>
2129
2130         [LFC] Adjust margin box verification.
2131         https://bugs.webkit.org/show_bug.cgi?id=193482
2132
2133         Reviewed by Antti Koivisto.
2134
2135         * LayoutReloaded/misc/LFC-passing-tests.txt:
2136
2137 2019-01-15  Sihui Liu  <sihui_liu@apple.com>
2138
2139         Fix API test WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming after 193354
2140         https://bugs.webkit.org/show_bug.cgi?id=193451
2141
2142         Reviewed by Geoffrey Garen.
2143
2144         * TestWebKitAPI/Tests/WebKitCocoa/DuplicateCompletionHandlerCalls.mm:
2145         (TEST):
2146         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2147         (runWebsiteDataStoreCustomPaths):
2148
2149 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
2150
2151         webkitpy: Support boolean simctl isAvailable
2152         https://bugs.webkit.org/show_bug.cgi?id=193472
2153         <rdar://problem/47296150>
2154
2155         Reviewed by Ryosuke Niwa.
2156
2157         * Scripts/webkitpy/xcode/simulated_device.py:
2158         (SimulatedDeviceManager._create_runtimes):
2159         (SimulatedDeviceManager._create_device_with_runtime):
2160
2161 2019-01-15  Chris Dumez  <cdumez@apple.com>
2162
2163         Unreviewed, rolling out r239993, r239995, r239997, and
2164         r239999.
2165
2166         Caused assertions under
2167         ViewGestureController::disconnectFromProcess()
2168
2169         Reverted changesets:
2170
2171         "Regression(PSON) View becomes blank after click a cross-site
2172         download link"
2173         https://bugs.webkit.org/show_bug.cgi?id=193361
2174         https://trac.webkit.org/changeset/239993
2175
2176         "Unreviewed iOS build fix after r239993."
2177         https://trac.webkit.org/changeset/239995
2178
2179         "Fix iOS build after r239993"
2180         https://bugs.webkit.org/show_bug.cgi?id=193361
2181         https://trac.webkit.org/changeset/239997
2182
2183         "Unreviewed, revert part of r239997 as it is not needed to fix
2184         the build."
2185         https://trac.webkit.org/changeset/239999
2186
2187 2019-01-15  Tim Horton  <timothy_horton@apple.com>
2188
2189         Cannot tab out of WKWebView on macOS
2190         https://bugs.webkit.org/show_bug.cgi?id=161448
2191         <rdar://problem/28100085>
2192
2193         Reviewed by Dean Jackson.
2194
2195         Add a test that tabbing into and out of WKWebView works correctly.
2196
2197         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2198         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
2199         (WebKit2_CommandBackForwardTest::SetUp):
2200         (-[CommandBackForwardOffscreenWindow isKeyWindow]): Deleted.
2201         (-[CommandBackForwardOffscreenWindow isVisible]): Deleted.
2202         * TestWebKitAPI/Tests/WebKitCocoa/TabOutOfWebView.mm: Added.
2203         (-[FocusableView canBecomeKeyView]):
2204         (TEST):
2205         * TestWebKitAPI/mac/OffscreenWindow.h: Added.
2206         * TestWebKitAPI/mac/OffscreenWindow.mm: Added.
2207         (-[OffscreenWindow initWithSize:]):
2208         (-[OffscreenWindow isKeyWindow]):
2209         (-[OffscreenWindow isVisible]):
2210         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
2211         (TestWebKitAPI::PlatformWebView::initialize):
2212         (-[ActiveOffscreenWindow isKeyWindow]): Deleted.
2213         (-[ActiveOffscreenWindow isVisible]): Deleted.
2214         Factor ActiveOffscreenWindow out into OffscreenWindow and share it.
2215
2216 2019-01-15  Ryan Haddad  <ryanhaddad@apple.com>
2217
2218         Adjust the arguments passed to run-javascriptcore-tests for the 32-bit JSC bot
2219         https://bugs.webkit.org/show_bug.cgi?id=193459
2220
2221         Reviewed by Mark Lam.
2222
2223         * BuildSlaveSupport/build.webkit.org-config/steps.py:
2224         (Run32bitJSCTests): This queue should not run JIT, testair, testb3, or testmasm.
2225
2226 2019-01-15  Chris Dumez  <cdumez@apple.com>
2227
2228         Regression(PSON) View becomes blank after click a cross-site download link
2229         https://bugs.webkit.org/show_bug.cgi?id=193361
2230         <rdar://problem/47099573>
2231
2232         Reviewed by Geoff Garen.
2233
2234         Add API test coverage.
2235
2236         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2237         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2238
2239 2019-01-15  Zalan Bujtas  <zalan@apple.com>
2240
2241         [LFC][Out-of-flow] Ignore bottom when the vertical values are over-constrained
2242         https://bugs.webkit.org/show_bug.cgi?id=193448
2243
2244         Reviewed by Antti Koivisto.
2245
2246         * LayoutReloaded/misc/LFC-passing-tests.txt:
2247
2248 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
2249
2250         webkitpy: Implement device type specific expected results (Part 1)
2251         https://bugs.webkit.org/show_bug.cgi?id=192162
2252
2253         Reviewed by Lucas Forschler.
2254
2255         Device type specific expected results covers two related ideas. The first (covered by this change)
2256         is where to search for -expected.* files. The second is which tests to run based on the
2257         TestExpectations.txt file.
2258
2259         After this change, the baseline search path will be determined by the type of device running a
2260         test. Device type will be passed into any function which picks a file based on the baseline search
2261         path.
2262
2263         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
2264         (Worker._update_test_input): Pass device_type to self._port.reference_files(...).
2265         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2266         (Manager.run): Print baseline search path for each round of devices.
2267         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2268         (SingleTestRunner.__init__): Pass device_type into expected_*(...).
2269         (SingleTestRunner._expected_driver_output): Ditto.
2270         (SingleTestRunner._driver_input): Ditto.
2271         * Scripts/webkitpy/layout_tests/views/printing.py:
2272         (Printer.print_config): Move printing of baseline search path to a separate function.
2273         (Printer.print_baseline_search_path): Moved from Printer.print_config.
2274         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
2275         (Testprinter.test_print_config):
2276         (Testprinter.test_print_baseline_search_path):
2277         * Scripts/webkitpy/port/base.py:
2278         (Port.baseline_search_path): Pass device_type through.
2279         (Port._expected_baselines_for_suffixes): Ditto.
2280         (Port.expected_baselines): Ditto.
2281         (Port.expected_filename): Ditto.
2282         (Port.expected_checksum): Ditto.
2283         (Port.expected_image): Ditto.
2284         (Port.expected_audio): Ditto.
2285         (Port.expected_text): Ditto.
2286         (Port.reference_files): Ditto.
2287         (Port.tests): Ditto.
2288         (Port._expanded_paths): Ditto.
2289         (Port.skipped_layout_tests): Ditto.
2290         (Port.expectations_dict): Ditto.
2291         (Port._port_specific_expectations_files): Ditto.
2292         (Port.expectations_files): Ditto.
2293         (Port.test_search_path): Ditto.
2294         (Port._tests_for_other_platforms): Ditto.
2295         * Scripts/webkitpy/port/base_unittest.py:
2296         (PortTest.test_additional_platform_directory): Accept, but do not use, device_type.
2297         (PortTest.test_nonexistant_expectations): Ditto.
2298         (test_ref_tests_platform_directory): Ditto.
2299         * Scripts/webkitpy/port/darwin.py:
2300         (DarwinPort._port_specific_expectations_files): Accept device_type.
2301         * Scripts/webkitpy/port/driver.py:
2302         (DriverProxy):
2303         (DriverProxy.host): Expose _target_host for device_type information.
2304         * Scripts/webkitpy/port/gtk.py:
2305         (GtkPort._port_specific_expectations_files): Accept, but do not use, device_type.
2306         * Scripts/webkitpy/port/ios.py:
2307         (IOSPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
2308         * Scripts/webkitpy/port/mac.py:
2309         (MacPort. default_baseline_search_path): Ditto.
2310         * Scripts/webkitpy/port/port_testcase.py:
2311         (TestWebKitPort._tests_for_other_platforms): Accept, but do not use, device_type.
2312         * Scripts/webkitpy/port/test.py:
2313         * Scripts/webkitpy/port/watch.py:
2314         (WatchPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
2315         * Scripts/webkitpy/port/win.py:
2316         (WinPort.test_search_path): Accept, but do not use, device_type.
2317         * Scripts/webkitpy/port/wpe.py:
2318         (WPEPort._port_specific_expectations_files): Ditto.
2319         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
2320         (get_test_baselines.AllPlatformsPort.baseline_search_path): Ditto.
2321
2322 2019-01-15  Zalan Bujtas  <zalan@apple.com>
2323
2324         [LFC] Use the containing block's padding box to position out-of-flow elements.
2325         https://bugs.webkit.org/show_bug.cgi?id=193431
2326
2327         Reviewed by Antti Koivisto.
2328
2329         * LayoutReloaded/misc/LFC-passing-tests.txt:
2330
2331 2019-01-14  Tim Horton  <timothy_horton@apple.com>
2332
2333         Move a test implementation file that got misplaced in the Xcode project
2334
2335         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2336
2337 2019-01-14  Commit Queue  <commit-queue@webkit.org>
2338
2339         Unreviewed, rolling out r239901, r239909, r239910, r239912,
2340         r239913, and r239914.
2341         https://bugs.webkit.org/show_bug.cgi?id=193407
2342
2343         These revisions caused an internal failure (Requested by
2344         Truitt on #webkit).
2345
2346         Reverted changesets:
2347
2348         "[Cocoa] Avoid importing directly from subumbrella frameworks"
2349         https://bugs.webkit.org/show_bug.cgi?id=186016
2350         https://trac.webkit.org/changeset/239901
2351
2352         "Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901."
2353         https://trac.webkit.org/changeset/239909
2354
2355         "Tried to fix the build."
2356         https://trac.webkit.org/changeset/239910
2357
2358         "Fixed iOS builds after r239910."
2359         https://trac.webkit.org/changeset/239912
2360
2361         "More build fixing."
2362         https://trac.webkit.org/changeset/239913
2363
2364         "Tried to fix USE(APPLE_INTERNAL_SDK) 32-bit builds."
2365         https://trac.webkit.org/changeset/239914
2366
2367 2019-01-14  Mark Lam  <mark.lam@apple.com>
2368
2369         Re-enable ability to build --cloop builds.
2370         https://bugs.webkit.org/show_bug.cgi?id=192955
2371         <rdar://problem/46882363>
2372
2373         Reviewed by Saam barati and Keith Miller.
2374
2375         The --cloop build option was being ignored this whole time since r236381.
2376         This patch makes it possible to build CLoop builds again.
2377
2378         * Scripts/build-jsc:
2379         * Scripts/webkitperl/FeatureList.pm:
2380         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2381
2382 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
2383
2384         webkitpy: Expose device_type from host-like objects
2385         https://bugs.webkit.org/show_bug.cgi?id=193406
2386         <rdar://problem/47262305>
2387
2388         Reviewed by Lucas Forschler.
2389
2390         Devices should expose device_type. As a result, all host objects should
2391         provide a device_type property, even if they do not yet define a device_type.
2392
2393         * Scripts/webkitpy/common/system/systemhost.py:
2394         (SystemHost):
2395         (SystemHost.device_type):
2396         * Scripts/webkitpy/common/system/systemhost_mock.py:
2397         (MockSystemHost):
2398         (MockSystemHost.device_type):
2399         * Scripts/webkitpy/port/device.py:
2400         (Device):
2401         (Device.device_type):
2402         * Scripts/webkitpy/xcode/simulated_device.py:
2403         (SimulatedDeviceManager._find_exisiting_device_for_request):
2404         (SimulatedDeviceManager._disambiguate_device_type):
2405         (SimulatedDeviceManager._does_fulfill_request):
2406         (SimulatedDeviceManager.device_count_for_type):
2407         (SimulatedDeviceManager.initialize_devices):
2408         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
2409         (test_available_devices):
2410         (test_swapping_devices):
2411
2412 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
2413
2414         webkitpy: Support alternate simctl device list output (Follow-up fix)
2415         https://bugs.webkit.org/show_bug.cgi?id=193362
2416         <rdar://problem/47122965>
2417
2418         Rubber-stamped by Lucas Forschler.
2419
2420         * Scripts/webkitpy/xcode/simulated_device.py:
2421         (SimulatedDeviceManager.populate_available_devices):
2422
2423 2019-01-14  Wenson Hsieh  <wenson_hsieh@apple.com>
2424
2425         [iOS] Expose SPI to access the current sentence boundary and selection state
2426         https://bugs.webkit.org/show_bug.cgi?id=193398
2427         <rdar://problem/45893108>
2428
2429         Reviewed by Dean Jackson.
2430
2431         Add an API test to verify that an SPI client can observe changes in the `@"_selectionAttributes"` key path on
2432         WKWebView, and that inserting text, deleting, and changing the selection cause selection attributes to change as
2433         expected.
2434
2435         * TestWebKitAPI/EditingTestHarness.h:
2436         * TestWebKitAPI/EditingTestHarness.mm:
2437         (-[EditingTestHarness moveBackward]):
2438         (-[EditingTestHarness moveForward]):
2439         (-[EditingTestHarness moveForwardAndExpectEditorStateWith:]):
2440
2441         Add a couple of new helper methods on EditingTestHarness.
2442
2443         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
2444         (-[SelectionChangeObserver initWithWebView:]):
2445         (-[SelectionChangeObserver webView]):
2446         (-[SelectionChangeObserver observeValueForKeyPath:ofObject:change:context:]):
2447         (-[SelectionChangeObserver currentSelectionAttributes]):
2448
2449 2019-01-14  Zalan Bujtas  <zalan@apple.com>
2450
2451         [LFC][BFC] Add basic box-sizing support.
2452         https://bugs.webkit.org/show_bug.cgi?id=193392
2453
2454         Reviewed by Antti Koivisto.
2455
2456         * LayoutReloaded/misc/LFC-passing-tests.txt:
2457
2458 2019-01-14  Charlie Turner  <cturner@igalia.com>
2459
2460         [WPE] API test gardening
2461         https://bugs.webkit.org/show_bug.cgi?id=193319
2462
2463         Reviewed by Michael Catanzaro.
2464
2465         * TestWebKitAPI/glib/TestExpectations.json: Remove some now
2466         passing tests.
2467
2468 2019-01-14  Charlie Turner  <cturner@igalia.com>
2469
2470         [GStreamer] Add sharedBuffer utility to GstMappedBuffer, and a testsuite
2471         https://bugs.webkit.org/show_bug.cgi?id=192977
2472
2473         Reviewed by Carlos Garcia Campos.
2474
2475         * TestWebKitAPI/PlatformGTK.cmake: Build the new GStreamer test harness
2476         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
2477         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.cpp: Added.
2478         (TestWebKitAPI::GStreamerTest::SetUp):
2479         (TestWebKitAPI::GStreamerTest::TearDown):
2480         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.h: Added.
2481         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp: Added.
2482         (TestWebKitAPI::TEST_F):
2483
2484 2019-01-14  Charlie Turner  <cturner@igalia.com>
2485
2486         [WPE] Workaround for incorrect template specialization being selected when UChar=char16_t
2487         https://bugs.webkit.org/show_bug.cgi?id=193332
2488
2489         Reviewed by Michael Catanzaro.
2490
2491         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: When UChar is
2492         defined as a char16_t, which changed in ICU 59, the
2493         StringTypeAdapter<UnsignedInt, ...> overload catches casts to
2494         unsigned short. This test is relying on the behaviour that
2495         UChar=unsigned short, which doesn't hold across platforms and ICU
2496         library versions. The full fix would be a special syntax for
2497         literal characters so that these ambiguities do not arise. That
2498         work is proposed in https://bugs.webkit.org/show_bug.cgi?id=193101.
2499         (TestWebKitAPI::TEST):
2500
2501 2019-01-14  Carlos Garcia Campos  <cgarcia@igalia.com>
2502
2503         Unreviewed. [GTK][WPE] Run distcheck with gtkdoc and MiniBrowser enabled
2504
2505         * Scripts/make-dist:
2506         (Distcheck.configure):
2507
2508 2019-01-13  Aakash Jain  <aakash_jain@apple.com>
2509
2510         [ews-build] Update macOS queue configurations
2511         https://bugs.webkit.org/show_bug.cgi?id=193365
2512         <rdar://problem/47221073>
2513
2514         Unreviewed, renamed mac-high-sierra to mac-highsierra to match with build.webkit.org configuration.
2515
2516         * BuildSlaveSupport/ews-build/config.json:
2517
2518 2019-01-13  Zalan Bujtas  <zalan@apple.com>
2519
2520         [LFC] Adjust assert for statically positioned fixed elements
2521         https://bugs.webkit.org/show_bug.cgi?id=193385
2522
2523         Reviewed by Antti Koivisto.
2524
2525         * LayoutReloaded/misc/LFC-passing-tests.txt:
2526
2527 2019-01-13  Philippe Normand  <pnormand@igalia.com>
2528
2529         [WPE][MiniBrowser] Ephemeral WebContext leaks in automation mode
2530         https://bugs.webkit.org/show_bug.cgi?id=193387
2531
2532         Reviewed by Carlos Garcia Campos.
2533
2534         * MiniBrowser/wpe/main.cpp:
2535         (main):
2536
2537 2019-01-12  Timothy Hatcher  <timothy@apple.com>
2538
2539         Have prefers-color-scheme: light always match on macOS versions before Mojave.
2540         https://bugs.webkit.org/show_bug.cgi?id=191655
2541         rdar://problem/46074680
2542
2543         Reviewed by Megan Gardner.
2544
2545         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions.
2546         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
2547
2548 2019-01-12  Dan Bernstein  <mitz@apple.com>
2549
2550         [Cocoa] Avoid importing directly from subumbrella frameworks
2551         https://bugs.webkit.org/show_bug.cgi?id=186016
2552         <rdar://problem/40591038>
2553
2554         Reviewed by Sam Weinig.
2555
2556         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
2557           LaunchServices header.
2558         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
2559           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
2560         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
2561           when using SDKs earlier than 10.13.
2562         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
2563           and OTHER_CPLUSPLUSFLAGS.
2564         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
2565           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
2566         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
2567           LaunchServices header.
2568
2569 2019-01-11  John Wilander  <wilander@apple.com>
2570
2571         Compile out Web API Statistics Collection
2572         https://bugs.webkit.org/show_bug.cgi?id=193370
2573         <rdar://problem/45388584>
2574
2575         Reviewed by Brent Fulgham.
2576
2577         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2578             Defined ENABLE_WEB_API_STATISTICS, off by default.
2579
2580 2019-01-11  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
2581
2582         [WPE] Add gtk-doc
2583         https://bugs.webkit.org/show_bug.cgi?id=178900
2584
2585         Reviewed by Michael Catanzaro.
2586
2587         Add Tools/gtkdoc to manifest.txt.in files.
2588         This should have been done in r238853 and caused failure in building WebKitGTK+ unstable release 2.23.2.
2589
2590         * gtk/manifest.txt.in: Add Tools/gtkdoc directory.
2591         * wpe/manifest.txt.in: Add Tools/gtkdoc directory and uncomment lines to move documentation artifacts.
2592
2593 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2594
2595         [iOS] Precision drop state thrashes when dragging near the top edge of an editable element
2596         https://bugs.webkit.org/show_bug.cgi?id=193364
2597         <rdar://problem/47214117>
2598
2599         Reviewed by Tim Horton.
2600
2601         Add a test to verify that dragging near the top of a textarea element does not flag the drop proposal as
2602         precise, whereas dragging near the middle of the textarea does.
2603
2604         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
2605         (TestWebKitAPI::TEST):
2606
2607 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
2608
2609         webkitpy: Support alternate simctl device list output
2610         https://bugs.webkit.org/show_bug.cgi?id=193362
2611         <rdar://problem/47122965>
2612
2613         Reviewed by Lucas Forschler.
2614
2615         * Scripts/webkitpy/xcode/simulated_device.py:
2616         (SimulatedDeviceManager.populate_available_devices):
2617
2618 2019-01-11  Aakash Jain  <aakash_jain@apple.com>
2619
2620         [ews-build] Update macOS queue configurations
2621         https://bugs.webkit.org/show_bug.cgi?id=193365
2622
2623         Reviewed by Lucas Forschler.
2624
2625         * BuildSlaveSupport/ews-build/config.json:
2626
2627 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
2628
2629         webkitpy: Incorporate device type into baseline search path
2630         https://bugs.webkit.org/show_bug.cgi?id=193356
2631         <rdar://problem/47215515>
2632
2633         Reviewed by Lucas Forschler.
2634
2635         We need a way to include device type in the baseline search path for iOS to support device specific test expectations.
2636
2637         * Scripts/webkitpy/port/base.py:
2638         (Port.default_baseline_search_path): Allow device type to be passed in.
2639         * Scripts/webkitpy/port/gtk.py:
2640         (GtkPort.default_baseline_search_path): Ignore device type.
2641         * Scripts/webkitpy/port/ios.py:
2642         (IOSPort.default_baseline_search_path): Optionally allow device type to be incorporated into the baseline search path.
2643         (IOSPort.test_expectations_file_position): Update index for the additional device-type specific baseline search path.
2644         * Scripts/webkitpy/port/ios_device_unittest.py:
2645         (IOSDeviceTest):
2646         * Scripts/webkitpy/port/ios_simulator_unittest.py:
2647         (IOSSimulatorTest):
2648         * Scripts/webkitpy/port/mac.py:
2649         (MacPort.default_baseline_search_path): Ignore device type.
2650         * Scripts/webkitpy/port/watch.py:
2651         (WatchPort.default_baseline_search_path): Ditto.
2652         * Scripts/webkitpy/port/win.py:
2653         (WinPort.default_baseline_search_path): Ditto.
2654         (WinCairoPort.default_baseline_search_path): Ditto.
2655         * Scripts/webkitpy/port/wpe.py:
2656         (WPEPort.default_baseline_search_path): Ditto.
2657
2658 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
2659
2660         webkitpy: Print abbreviated baseline search path that includes only folders that exist
2661         https://bugs.webkit.org/show_bug.cgi?id=193352
2662         <rdar://problem/47210736>
2663
2664         Reviewed by Lucas Forschler.
2665
2666         * Scripts/webkitpy/layout_tests/views/printing.py:
2667         (Printer.print_config): Print list on only baseline search paths which exist. 
2668         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
2669         (Testprinter.test_print_config):
2670
2671 2019-01-11  Joseph Pecoraro  <pecoraro@apple.com>
2672
2673         Cleanup possible WK*Copy/Create leaks in WebKitTestRunner
2674         https://bugs.webkit.org/show_bug.cgi?id=193340
2675
2676         Reviewed by David Kilzer.
2677
2678         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2679         (WTR::InjectedBundle::didReceiveMessageToPage):
2680         Pull the strings out into a WKRetainPtr.
2681
2682         * WebKitTestRunner/WebNotificationProvider.cpp:
2683         (WTR::WebNotificationProvider::closeWebNotification):
2684         Adopt the created value into the WKRetainPtr.
2685
2686         * WebKitTestRunner/mac/TestControllerMac.mm:
2687         (WTR::generateWhitelist):
2688         Immediately adopt a created value to avoid potential mistakes.
2689
2690 2019-01-11  Dominik Infuehr  <dinfuehr@igalia.com>
2691
2692         Enable DFG on ARM/Linux again
2693         https://bugs.webkit.org/show_bug.cgi?id=192496
2694
2695         Reviewed by Yusuke Suzuki.
2696
2697         After changing the bytecode format DFG was disabled on all 32-bit
2698         architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
2699         on ARM by default.
2700
2701         * Scripts/run-jsc-stress-tests:
2702
2703 2019-01-11  Timothy Hatcher  <timothy@apple.com>
2704
2705         Unreviewed, fix #ifdef in API test added in r239851.
2706         https://bugs.webkit.org/show_bug.cgi?id=193327
2707         rdar://problem/47093222
2708
2709         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm:
2710
2711 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2712
2713         Introduce IDL files for runtime-enabled UndoManager and UndoItem JavaScript API
2714         https://bugs.webkit.org/show_bug.cgi?id=193109
2715         <rdar://problem/44807048>
2716
2717         Reviewed by Ryosuke Niwa.
2718
2719         Introduce and respect a test option to enable the UndoManager API.
2720
2721         * WebKitTestRunner/TestController.cpp:
2722         (WTR::updateTestOptionsFromTestHeader):
2723         * WebKitTestRunner/TestOptions.h:
2724         (WTR::TestOptions::hasSameInitializationOptions const):
2725         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2726         (WTR::TestController::platformCreateWebView):
2727
2728 2019-01-11  Zalan Bujtas  <zalan@apple.com>
2729
2730         [LFC][BFC][MarginCollapsing] Adjust vertical position when box margin collapses through.
2731         https://bugs.webkit.org/show_bug.cgi?id=193346
2732
2733         Reviewed by Antti Koivisto.
2734
2735         * LayoutReloaded/misc/LFC-passing-tests.txt:
2736
2737 2019-01-10  Ryan Haddad  <ryanhaddad@apple.com>
2738
2739         Unreviewed, fix typo that breaks dashboard link.
2740
2741         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2742         (WebKitBuildbot):
2743
2744 2019-01-10  Ryan Haddad  <ryanhaddad@apple.com>
2745
2746         Update macOS queue configurations
2747         https://bugs.webkit.org/show_bug.cgi?id=193329
2748
2749         Reviewed by Alexey Proskuryakov.
2750
2751         * BuildSlaveSupport/build.webkit.org-config/config.json:
2752         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2753         (BubbleQueueServer):
2754         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2755         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2756         (WebKitBuildbot):
2757         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2758         (table.queue-grid tr.platform.macos-sierra img.logo): Deleted.
2759         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
2760
2761 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
2762
2763         MiniBrowser should be able to navigate to about:blank
2764         https://bugs.webkit.org/show_bug.cgi?id=193345
2765
2766         Reviewed by Simon Fraser.
2767
2768         * MiniBrowser/mac/BrowserWindowController.m:
2769         (-[BrowserWindowController addProtocolIfNecessary:]):
2770         Don't prepend "http://" to "about:" prefixed URLs like "about:blank".
2771
2772         * MiniBrowser/mac/WK1BrowserWindowController.m:
2773         (-[WK1BrowserWindowController fetch:]):
2774         * MiniBrowser/mac/WK2BrowserWindowController.m:
2775         (-[WK2BrowserWindowController fetch:]):
2776         Clean up the code that uses this to match style.
2777
2778 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
2779
2780         Remove MiniBrowser custom "Process Swap" menu item which does not work
2781         https://bugs.webkit.org/show_bug.cgi?id=193344
2782
2783         Reviewed by Simon Fraser.
2784
2785         There is a menu item under the Experimental menu that does work.
2786
2787         * MiniBrowser/mac/AppDelegate.m:
2788         (defaultConfiguration):
2789         * MiniBrowser/mac/SettingsController.h:
2790         * MiniBrowser/mac/SettingsController.m:
2791         (-[SettingsController _populateMenu]):
2792         (-[SettingsController validateMenuItem:]):
2793         (-[SettingsController processSwapOnNavigationEnabled]): Deleted.
2794         (-[SettingsController toggleProcessSwapOnNavigation:]): Deleted.
2795
2796 2019-01-10  Timothy Hatcher  <timothy@apple.com>
2797
2798         Add WKBundlePage SPI to temporarily force light or dark appearance on a page.
2799         https://bugs.webkit.org/show_bug.cgi?id=193327
2800         rdar://problem/47093222
2801
2802         Reviewed by Tim Horton.
2803
2804         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2805         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm: Added.
2806         (TestWebKitAPI::didFinishNavigation):
2807         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
2808         (TestWebKitAPI::TEST):
2809         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm: Added.
2810         (TestWebKitAPI::ForceLightAppearanceInBundleTest::ForceLightAppearanceInBundleTest):
2811         (TestWebKitAPI::ForceLightAppearanceInBundleTest::didCreatePage):
2812         (TestWebKitAPI::ForceLightAppearanceInBundleTest::didReceiveMessage):
2813         * TestWebKitAPI/Tests/WebKit/mac/dark-mode.html: Added.
2814
2815 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
2816
2817         Leak of WKWebProcessPlugInHitTestResult (160 bytes) in com.apple.WebKit.WebContent running layout tests
2818         https://bugs.webkit.org/show_bug.cgi?id=193338
2819         <rdar://problem/46664774>
2820
2821         Reviewed by David Kilzer.
2822
2823         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2824         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
2825
2826 2019-01-10  Commit Queue  <commit-queue@webkit.org>
2827
2828         Unreviewed, rolling out r239825.
2829         https://bugs.webkit.org/show_bug.cgi?id=193330
2830
2831         Broke tests on armv7/linux bots (Requested by guijemont on
2832         #webkit).
2833
2834         Reverted changeset:
2835
2836         "Enable DFG on ARM/Linux again"
2837         https://bugs.webkit.org/show_bug.cgi?id=192496
2838         https://trac.webkit.org/changeset/239825
2839
2840 2019-01-10  Zhifei Fang  <zhifei_fang@apple.com>
2841
2842         Disable the run-jsc-stress-test remote host key check.
2843         https://bugs.webkit.org/show_bug.cgi?id=192988
2844
2845         Reviewed by Alexey Proskuryakov.
2846
2847         * Scripts/run-jsc-stress-tests:
2848
2849 2019-01-10  John Wilander  <wilander@apple.com>
2850
2851         Override the session configuration for cookieAcceptPolicy
2852         https://bugs.webkit.org/show_bug.cgi?id=190925
2853         <rdar://problem/45497382>
2854
2855         Reviewed by Alexey Proskuryakov and Alex Christensen.
2856
2857         Test infrastructure for setting a first-party-only cookie policy.
2858
2859         * DumpRenderTree/TestRunner.cpp:
2860         (setOnlyAcceptFirstPartyCookiesCallback):
2861         (TestRunner::staticFunctions):
2862         * DumpRenderTree/TestRunner.h:
2863         * DumpRenderTree/mac/TestRunnerMac.mm:
2864         (TestRunner::setOnlyAcceptFirstPartyCookies):
2865         * DumpRenderTree/win/TestRunnerWin.cpp:
2866         (TestRunner::setOnlyAcceptFirstPartyCookies):
2867         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2868         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2869         (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
2870         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2871         * WebKitTestRunner/TestInvocation.cpp:
2872         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2873
2874 2019-01-09  Matt Rajca  <mrajca@apple.com>
2875
2876         Put per-document autoplay behavior behind runtime website policies quirk instead of a compile time flag
2877         https://bugs.webkit.org/show_bug.cgi?id=193301
2878
2879         Reviewed by Jer Noble.
2880         
2881         Added API tests.
2882
2883         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2884         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2885         (TEST):
2886         * TestWebKitAPI/Tests/WebKitCocoa/autoplaying-multiple-media-elements.html: Added.
2887
2888 2019-01-10  Zalan Bujtas  <zalan@apple.com>
2889
2890         [LFC][BFC][MarginCollapsing] Take collapsed through siblings into account when computing vertical position
2891         https://bugs.webkit.org/show_bug.cgi?id=193310
2892
2893         Reviewed by Antti Koivisto.
2894
2895         * LayoutReloaded/misc/LFC-passing-tests.txt:
2896
2897 2019-01-10  Dominik Infuehr  <dinfuehr@igalia.com>
2898
2899         Enable DFG on ARM/Linux again
2900         https://bugs.webkit.org/show_bug.cgi?id=192496
2901
2902         Reviewed by Yusuke Suzuki.
2903
2904         After changing the bytecode format DFG was disabled on all 32-bit
2905         architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
2906         on ARM by default.
2907
2908         * Scripts/run-jsc-stress-tests:
2909
2910 2019-01-09  Fujii Hironori  <Hironori.Fujii@sony.com>
2911
2912         [Win][MiniBrowser] wchar_t strings shouldn't be treated as BSTR
2913         https://bugs.webkit.org/show_bug.cgi?id=193271
2914
2915         Reviewed by Brent Fulgham.
2916
2917         BSTR is a special data structure created by SysAllocString, not a
2918         wchar_t null-terminated string.
2919
2920         * DumpRenderTree/win/TestRunnerWin.cpp:
2921         (TestRunner::setDatabaseQuota): Use L"" instead of "" for _bstr_t.
2922         * MiniBrowser/win/MiniBrowserWebHost.cpp:
2923         (MiniBrowserWebHost::didFinishLoadForFrame): Use _bstr_t to create
2924         BSTR from wide string literals.
2925
2926 2019-01-09  Alexey Proskuryakov  <ap@apple.com>
2927
2928         Tweak wording for build/version_check style checker error
2929         https://bugs.webkit.org/show_bug.cgi?id=193256
2930
2931         Reviewed by Tim Horton.
2932
2933         * Scripts/webkitpy/style/checkers/cpp.py:
2934         (check_os_version_checks):
2935         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2936         (WebKitStyleTest.test_os_version_checks):
2937
2938 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
2939
2940         [ews-build] Add link to bug along with bug title
2941         https://bugs.webkit.org/show_bug.cgi?id=193293
2942
2943         Reviewed by Lucas Forschler.
2944
2945         * BuildSlaveSupport/ews-build/steps.py:
2946         (ValidatePatch._is_bug_closed): Fetch bug title from Bugzilla and add it to the build.
2947         (ConfigureBuild.add_bug_id_url): Deleted.
2948         (ConfigureBuild.getBugURL): Deleted.
2949
2950 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
2951
2952         [ews-build] Use https for ews-build server
2953         https://bugs.webkit.org/show_bug.cgi?id=193193
2954
2955         Reviewed by Lucas Forschler.
2956
2957         * BuildSlaveSupport/ews-build/steps.py:
2958
2959 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
2960
2961         [ews-build] Parse and display number of style failures
2962         https://bugs.webkit.org/show_bug.cgi?id=193280
2963
2964         Reviewed by Lucas Forschler.
2965
2966         * BuildSlaveSupport/ews-build/steps.py:
2967         (CheckStyle): Use TestWithFailureCount as base class.
2968         (CheckStyle.countFailures): Count the number of style failures.
2969
2970 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
2971
2972         [ews-build] use patch_id instead of ewspatchid
2973         https://bugs.webkit.org/show_bug.cgi?id=193235
2974
2975         Reviewed by Lucas Forschler.
2976
2977         * BuildSlaveSupport/ews-build/factories.py: Replaced ewspatchid with patch_id.
2978         * BuildSlaveSupport/ews-build/steps.py: Ditto.
2979         * BuildSlaveSupport/ews-build/steps_unittest.py: Ditto.
2980
2981 2019-01-09  Zalan Bujtas  <zalan@apple.com>
2982
2983         [LFC][BFC][MarginCollapsing] Add support for peculiar cases.
2984         https://bugs.webkit.org/show_bug.cgi?id=192625
2985
2986         Reviewed by Antti Koivisto.
2987
2988         * LayoutReloaded/misc/LFC-passing-tests.txt:
2989
2990 2019-01-09  Michael Catanzaro  <mcatanzaro@igalia.com>
2991
2992         [WPE][GTK] Purge use of g_assert() under TestWebKitAPI
2993         https://bugs.webkit.org/show_bug.cgi?id=192841
2994
2995         Reviewed by Carlos Garcia Campos.
2996
2997         There are separate g_assert_*() macros for use in tests, which we use inconsistently
2998         currently. Use them always. We'll get nicer error messages now when tests fail, and the
2999         assertions will now run during tests even if G_DISABLE_ASSERT is used when building.
3000
3001         Note that the documentation of g_assert() says that it is not to be used when writing tests.
3002
3003         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3004         * TestWebKitAPI/Tests/WebKitGLib/EditorTest.cpp:
3005         (WebKitWebEditorTest::testSelectionChanged):
3006         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp:
3007         (WebKitFrameTest::testMainFrame):
3008         (WebKitFrameTest::testURI):
3009         (WebKitFrameTest::testJavaScriptContext):
3010         (WebKitFrameTest::testJavaScriptValues):
3011         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
3012         (testWebViewAuthenticationRequest):
3013         (testWebViewAuthenticationLoadCancelled):
3014         (testWebViewAuthenticationFailure):
3015         (testWebViewAuthenticationStorage):
3016         (ProxyAuthenticationTest::ProxyAuthenticationTest):
3017         (testWebViewAuthenticationProxy):
3018         (testWebViewAuthenticationProxyHTTPS):
3019         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
3020         (testAutomationSessionRequestSession):
3021         * TestWebKitAPI/Tests/WebKitGLib/TestBackForwardList.cpp:
3022         (testBackForwardListNavigation):
3023         (testWebKitWebViewSessionState):
3024         (testWebKitWebViewSessionStateWithFormData):
3025         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
3026         (ConsoleMessageTest::consoleMessageReceivedCallback):
3027         (testWebKitConsoleMessageConsoleAPI):
3028         (testWebKitConsoleMessageJavaScriptException):
3029         (testWebKitConsoleMessageNetworkError):
3030         (testWebKitConsoleMessageSecurityError):
3031         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
3032         (testCookieManagerAcceptPolicy):
3033         (testCookieManagerCookiesChanged):
3034         (testCookieManagerPersistentStorage):
3035         (testCookieManagerPersistentStorageDeleteAll):
3036         (testCookieManagerEphemeral):
3037         * TestWebKitAPI/Tests/WebKitGLib/TestDOMElement.cpp:
3038         (testWebKitDOMElementAutoFill):
3039         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:
3040         (downloadLocalFileSuccessfully):
3041         (createFileAtDestination):
3042         (testDownloadOverwriteDestinationDisallowed):
3043         (testDownloadLocalFileError):
3044         (testDownloadRemoteFile):
3045         (testDownloadRemoteFileError):
3046         (testWebViewDownloadURI):
3047         (testPolicyResponseDownload):
3048         (testPolicyResponseDownloadCancel):
3049         (testDownloadMIMEType):
3050         (contextMenuCallback):
3051         (testContextMenuDownloadActions):
3052         (testBlobDownload):
3053         * TestWebKitAPI/Tests/WebKitGLib/TestEditor.cpp:
3054         (testWebKitWebEditorSelectionChanged):
3055         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp:
3056         (testWebKitFrameMainFrame):
3057         (testWebKitFrameURI):
3058         (testWebKitFrameJavaScriptContext):
3059         (testWebKitFrameJavaScriptValues):
3060         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
3061         (LoadStopTrackingTest::loadFailed):
3062         (testWebViewTitle):
3063         (testURIRequestHTTPHeaders):
3064         (testURIRequestHTTPMethod):
3065         (testURIResponseHTTPHeaders):
3066         (testRedirectToDataURI):
3067         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp:
3068         (testProcessPerWebView):
3069         (testWebProcessLimit):
3070         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
3071         (testWebViewResources):
3072         (testWebResourceLoading):
3073         (testWebResourceSuggestedFilename):
3074         (testWebResourceGetData):
3075         (testWebResourceGetDataError):
3076         (testWebViewResourcesHistoryCache):
3077         (testWebResourceSendRequest):
3078         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
3079         (testSSL):
3080         (testInsecureContent):
3081         (testTLSErrorsPolicy):
3082         (testTLSErrorsRedirect):
3083         (testTLSErrorsHTTPAuth):
3084         (testLoadFailedWithTLSErrors):
3085         (testSubresourceLoadFailedWithTLSErrors):
3086         (httpsServerCallback):
3087         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
3088         (testWebViewCreateNavigationData):
3089         (testWebViewJavaScriptDialogs):
3090         (testWebViewWindowProperties):
3091         (testWebViewMouseTarget):
3092         (testWebViewFileChooserRequest):
3093         (testWebViewColorChooserRequest):
3094         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
3095         (testWebExtensionGetTitle):
3096         (testDocumentLoadedSignal):
3097         (testWebKitWebViewProcessCrashed):
3098         (testWebExtensionWindowObjectCleared):
3099         (testWebExtensionIsolatedWorld):
3100         (permissionRequestCallback):
3101         (didAssociateFormControlsCallback):
3102         (testWebExtensionFormControlsAssociated):
3103         (FormSubmissionTest::FormSubmissionTest):
3104         (FormSubmissionTest::testFormSubmissionResult):
3105         (testWebExtensionFormSubmissionSteps):
3106         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
3107         (testNotInitialized):
3108         (testClearDatabase):
3109         (testPrivateBrowsing):
3110         (testGetFavicon):
3111         (testWebViewFavicon):
3112         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFindController.cpp:
3113         (testFindControllerTextFound):
3114         (testFindControllerTextNotFound):
3115         (testFindControllerMatchCount):
3116         (testFindControllerMaxMatchCount):
3117         (testFindControllerNext):
3118         (testFindControllerPrevious):
3119         (testFindControllerCountedMatches):
3120         (testFindControllerOptions):
3121         (testFindControllerHide):
3122         (testFindControllerInstance):
3123         (testFindControllerGetters):
3124         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitPolicyClient.cpp:
3125         (testNavigationPolicy):
3126         (testResponsePolicy):
3127         (testNewWindowPolicy):
3128         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSecurityOrigin.cpp:
3129         (testSecurityOriginBasicConstructor):
3130         (testSecurityOriginURIConstructor):
3131         (testSecurityOriginDefaultPort):
3132         (testSecurityOriginFileURI):
3133         (testOpaqueSecurityOrigin):
3134         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
3135         (testWebKitSettings):
3136         (testWebKitSettingsNewWithSettings):
3137         (testWebKitSettingsUserAgent):
3138         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
3139         (testWebViewNewWithUserContentManager):
3140         (isStyleSheetInjectedForURLAtPath):
3141         (isScriptInjectedForURLAtPath):
3142         (testUserContentManagerInjectedStyleSheet):
3143         (testUserContentManagerInjectedScript):
3144         (UserScriptMessageTest::scriptMessageReceived):
3145         (UserScriptMessageTest::waitUntilMessageReceived):
3146         (UserScriptMessageTest::runJavaScriptFinished):
3147         (testUserContentManagerScriptMessageReceived):
3148         (testUserContentManagerScriptMessageInWorldReceived):
3149         (testUserContentManagerScriptMessageFromDOMBindings):
3150         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
3151         (testWebContextDefault):
3152         (testWebContextEphemeral):
3153         (testWebContextGetPlugins):
3154         (testWebContextURIScheme):
3155         (testWebContextSpellChecker):
3156         (testWebContextLanguages):
3157         (consoleMessageReceivedCallback):
3158         (testWebContextSecurityFileXHR):
3159         (ProxyTest::ProxyTest):
3160         (testWebContextProxySettings):
3161         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
3162         (testWebViewWebContext):
3163         (testWebViewWebBackend):
3164         (testWebViewEphemeral):
3165         (testWebViewCustomCharset):
3166         (testWebViewSettings):
3167         (testWebViewRunJavaScript):
3168         (testWebViewCanShowMIMEType):
3169         (testWebViewSubmitForm):
3170         (testWebViewSave):
3171         (testWebViewPageVisibility):
3172         (testWebViewSnapshot):
3173         (testWebViewNotification):
3174         (testWebViewNotificationInitialPermissionAllowed):
3175         (testWebViewNotificationInitialPermissionDisallowed):
3176         (testWebViewIsPlayingAudio):
3177         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
3178         (WebsiteDataTest::WebsiteDataTest):
3179         (WebsiteDataTest::remove):
3180         (WebsiteDataTest::clear):
3181         (testWebsiteDataConfiguration):
3182         (testWebsiteDataEphemeral):
3183         (testWebsiteDataCache):
3184         (testWebsiteDataStorage):
3185         (testWebsiteDataDatabases):
3186         (testWebsiteDataAppcache):
3187         (testWebsiteDataCookies):
3188         (testWebsiteDataDeviceIdHashSalt):
3189         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
3190         (emitDocumentLoaded):
3191         (emitURIChanged):
3192         (sendRequestCallback):
3193         (contextMenuCallback):
3194         (consoleMessageSentCallback):
3195         (emitFormControlsAssociated):
3196         (formControlsAssociatedCallback):
3197         (emitFormSubmissionEvent):
3198         (willSubmitFormCallback):
3199         (windowObjectCleared):
3200         (methodCallCallback):
3201         (registerGResource):
3202         (webkit_web_extension_initialize_with_user_data):
3203         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.cpp:
3204         (checkLeaks):
3205         (WebProcessTest::create):
3206         (runTest):
3207         * TestWebKitAPI/Tests/WebKitGtk/AutocleanupsTest.cpp:
3208         (AutocleanupsTest::testWebProcessAutocleanups):
3209         * TestWebKitAPI/Tests/WebKitGtk/DOMClientRectTest.cpp:
3210         (WebKitDOMClientRectTest::testDivBoundingClientRectPosition):
3211         (WebKitDOMClientRectTest::testDivClientRectsPositionAndLength):
3212         * TestWebKitAPI/Tests/WebKitGtk/DOMDOMWindowTest.cpp:
3213         (WebKitDOMDOMWindowTest::testSignals):
3214         (WebKitDOMDOMWindowTest::testDispatchEvent):
3215         (WebKitDOMDOMWindowTest::testGetComputedStyle):
3216         * TestWebKitAPI/Tests/WebKitGtk/DOMNodeFilterTest.cpp:
3217         (WebKitDOMNodeFilterTest::testTreeWalker):
3218         (WebKitDOMNodeFilterTest::testNodeIterator):
3219         * TestWebKitAPI/Tests/WebKitGtk/DOMNodeTest.cpp:
3220         (WebKitDOMNodeTest::testHierarchyNavigation):
3221         (WebKitDOMNodeTest::testInsertion):
3222         (WebKitDOMNodeTest::testTagNamesNodeList):
3223         (WebKitDOMNodeTest::testTagNamesHTMLCollection):
3224         (WebKitDOMNodeTest::testDOMCache):
3225         * TestWebKitAPI/Tests/WebKitGtk/DOMXPathNSResolverTest.cpp:
3226         (WebKitDOMXPathNSResolverTest::evaluateFooChildTextAndCheckResult):
3227         (WebKitDOMXPathNSResolverTest::testXPathNSResolverNative):
3228         (WebKitDOMXPathNSResolverTest::testXPathNSResolverCustom):
3229         * TestWebKitAPI/Tests/WebKitGtk/TestAutocleanups.cpp:
3230         (testUIProcessAutocleanups):
3231         (testWebProcessAutocleanups):
3232         * TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp:
3233         (testContextMenuPopulateMenu):
3234         (testContextMenuDismissed):
3235         * TestWebKitAPI/Tests/WebKitGtk/TestDOMClientRect.cpp:
3236         (testWebKitDOMClientRectDivBoundingClientRectPosition):
3237         (testWebKitDOMClientRectDivClientRectsPositionAndLength):
3238         * TestWebKitAPI/Tests/WebKitGtk/TestDOMDOMWindow.cpp:
3239         (testWebKitDOMDOMWindowSignals):
3240         (testWebKitDOMDOMWindowDispatchEvent):
3241         (testWebKitDOMDOMWindowGetComputedStyle):
3242         * TestWebKitAPI/Tests/WebKitGtk/TestDOMNode.cpp:
3243         (testWebKitDOMNodeHierarchyNavigation):
3244         (testWebKitDOMNodeInsertion):
3245         (testWebKitDOMNodeTagNamesNodeList):
3246         (testWebKitDOMNodeTagNamesHTMLCollection):
3247         (testWebKitDOMObjectCache):
3248         * TestWebKitAPI/Tests/WebKitGtk/TestDOMNodeFilter.cpp:
3249         (testWebKitDOMNodeFilterTreeWalker):
3250         (testWebKitDOMNodeFilterNodeIterator):
3251         * TestWebKitAPI/Tests/WebKitGtk/TestDOMXPathNSResolver.cpp:
3252         (testWebKitDOMXPathNSResolverNative):
3253         (testWebKitDOMXPathNSResolverCustom):
3254         * TestWebKitAPI/Tests/WebKitGtk/TestInspector.cpp:
3255         (testInspectorDefault):
3256         (testInspectorManualAttachDetach):
3257         (testInspectorCustomContainerDestroyed):
3258         * TestWebKitAPI/Tests/WebKitGtk/TestInspectorServer.cpp:
3259         (startTestServer):
3260         (testInspectorServerPageList):
3261         * TestWebKitAPI/Tests/WebKitGtk/TestOptionMenu.cpp:
3262         (OptionMenuTest::showOptionMenuCallback):
3263         (OptionMenuTest::menuCloseCallback):
3264         (OptionMenuTest::close):
3265         (OptionMenuTest::activateItem):
3266         (OptionMenuTest::selectItem):
3267         (testOptionMenuSimple):
3268         (testOptionMenuGroups):
3269         (testOptionMenuActivate):
3270         (testOptionMenuSelect):
3271         * TestWebKitAPI/Tests/WebKitGtk/TestPrinting.cpp:
3272         (testPrintOperationPrintSettings):
3273         (webViewPrintCallback):
3274         (testPrintOperationPrint):
3275         (testPrintCustomWidget):
3276         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
3277         (checkAtspiAccessible):
3278         (testAtspiBasicHierarchy):
3279         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitVersion.cpp:
3280         (testWebKitCheckVersion):
3281         * TestWebKitAPI/Tests/WebKitGtk/TestWebViewEditor.cpp:
3282         (testWebViewEditorCutCopyPasteNonEditable):
3283         (testWebViewEditorCutCopyPasteEditable):
3284         (testWebViewEditorSelectAllNonEditable):
3285         (testWebViewEditorSelectAllEditable):
3286         (loadContentsAndTryToCutSelection):
3287         (testWebViewEditorNonEditable):
3288         (testWebViewEditorEditable):
3289         (testWebViewEditorEditorStateTypingAttributes):
3290         (testWebViewEditorInsertImage):
3291         (testWebViewEditorCreateLink):
3292         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp:
3293         (loadChangedCallback):
3294         (loadFailedCallback):
3295         (loadFailedWithTLSErrorsCallback):
3296         (LoadTrackingTest::LoadTrackingTest):
3297         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
3298         (registerGResource):
3299         (removeNonEmptyDirectory):
3300         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
3301         (Test::adoptView):
3302         (Test::~Test):
3303         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
3304         (WebKitTestBus::getOrCreateConnection):
3305         (WebKitTestBus::createProxy):
3306         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.cpp:
3307         (WebKitTestServer::getWebSocketURIForPath const):
3308         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
3309         (WebViewTest::initializeWebView):
3310         (WebViewTest::loadURI):
3311         (WebViewTest::loadHtml):
3312         (WebViewTest::loadPlainText):
3313         (WebViewTest::loadBytes):
3314         (WebViewTest::loadRequest):
3315         (WebViewTest::loadAlternateHTML):
3316         (WebViewTest::goBack):
3317         (WebViewTest::goForward):
3318         (WebViewTest::goToBackForwardListItem):
3319         (resourceGetDataCallback):
3320         (WebViewTest::mainResourceData):
3321         (WebViewTest::javascriptResultToCString):
3322         (WebViewTest::javascriptResultToNumber):
3323         (WebViewTest::javascriptResultToBoolean):
3324         (WebViewTest::javascriptResultIsNull):
3325         (WebViewTest::javascriptResultIsUndefined):
3326         (onSnapshotReady):
3327         (WebViewTest::runWebProcessTest):
3328         * TestWebKitAPI/glib/WebKitGLib/gtk/WebViewTestGtk.cpp:
3329         (WebViewTest::platformInitializeWebView):
3330         (WebViewTest::showInWindow):
3331         (WebViewTest::showInWindowAndWaitUntilMapped):
3332         (WebViewTest::mouseMoveTo):
3333         (WebViewTest::emitPopupMenuSignal):
3334         (WebViewTest::keyStroke):
3335         (WebViewTest::doMouseButtonEvent):
3336
3337 2019-01-09  Philippe Normand  <pnormand@igalia.com>
3338
3339         [WPE] API tests can't run in flatpak environment
3340         https://bugs.webkit.org/show_bug.cgi?id=193242
3341
3342         Reviewed by Michael Catanzaro.
3343
3344         * Scripts/run-wpe-tests: Add --wpe to arguments passed to
3345         flatpakutils so that it knows which port it's dealing with.
3346         * glib/common.py: Remove build_dir globals so that subsequent
3347         calls actually take args into account.
3348         (library_build_path):
3349         (binary_build_path):
3350
3351 2019-01-08  Dean Jackson  <dino@apple.com>
3352
3353         Blob references for System Previews don't get a correct file extension
3354         https://bugs.webkit.org/show_bug.cgi?id=193268
3355         <rdar://problem/47133037>
3356
3357         Reviewed by Tim Horton.
3358
3359         New test that a Blob download of a USDZ file gets named correctly.
3360
3361         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3362         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3363         (-[BlobWithUSDZExtensionDownloadDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
3364         (-[BlobWithUSDZExtensionDownloadDelegate _downloadDidFinish:]):
3365         (TEST):
3366         * TestWebKitAPI/Tests/WebKitCocoa/SystemPreviewBlobNaming.html: Added.
3367
3368 2019-01-08  Jiewen Tan  <jiewen_tan@apple.com>
3369
3370         [WebAuthN] Support U2F HID Authenticators on macOS
3371         https://bugs.webkit.org/show_bug.cgi?id=191535
3372         <rdar://problem/47102027>
3373
3374         Reviewed by Brent Fulgham.
3375
3376         This patch:
3377         1) adds support for U2F mocking mechanism;
3378         2) updates tests to reflect U2fCommandConstructor changes.
3379
3380         * TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp:
3381         (TestWebKitAPI::TEST):
3382         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
3383         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3384         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
3385
3386 2019-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
3387
3388         [iOS] Dispatch a synthetic mousedown event prior to starting drags
3389         https://bugs.webkit.org/show_bug.cgi?id=193229
3390         <rdar://problem/46717097>
3391
3392         Reviewed by Tim Horton.
3393
3394         Add a cross-platform drag and drop test to verify that calling `preventDefault()` on the mousedown event
3395         prevents a drag from starting.
3396
3397         * TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm:
3398         * TestWebKitAPI/Tests/WebKitCocoa/link-and-target-div.html:
3399
3400         Tweak this test to make it robust when dragging the link to the target element multiple times in a single test.
3401
3402 2019-01-08  Zhifei Fang  <zhifei_fang@apple.com>
3403   
3404         Layout test will generate a perf metric file to results dir.
3405         https://bugs.webkit.org/show_bug.cgi?id=192030
3406         <rdar://problem/32779516>
3407
3408         Reviewed by Aakash Jain.
3409
3410         Layout test running time will be collected to a perf metric file.
3411         For now, instead of outputing running time of all tests (which is huge),
3412         we aggregate them by test directories which are at most two level deep. 
3413
3414         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3415         (Manager._end_test_run):
3416         (Manager._output_perf_metrics):
3417         (Manager._print_expectation_line_for_test):
3418         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3419         (add_test_perf_metric):
3420         (test_perf_metrics):
3421         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
3422         (JSONGeneratorTest.test_test_timings_trie):
3423         (JSONGeneratorTest):
3424         (JSONGeneratorTest.test_test_perf_metrics):
3425         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3426         (RebaselineTest.test_reset_results):
3427         (RebaselineTest.test_missing_results):
3428         (RebaselineTest.test_new_baseline):
3429
3430 2019-01-08  Patrick Griffis  <pgriffis@igalia.com>
3431
3432         [WPE][GTK] Add php-json to install-dependencies
3433         https://bugs.webkit.org/show_bug.cgi?id=193233
3434
3435         Reviewed by Michael Catanzaro.
3436
3437         * gtk/install-dependencies:
3438         * wpe/install-dependencies:
3439
3440 2019-01-08  Chris Dumez  <cdumez@apple.com>
3441
3442         Regression(PSON-r239182): Blank view when navigating back and forth between google.com and stack overflow
3443         https://bugs.webkit.org/show_bug.cgi?id=193224
3444         <rdar://problem/47097726>
3445
3446         Reviewed by Alex Christensen.
3447
3448         Add API test coverage.
3449
3450         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3451
3452 2019-01-07  David Kilzer  <ddkilzer@apple.com>
3453
3454         Leak of ScrollCompletionCallbackData (16 bytes) in com.apple.WebKit.WebContent running WebKit layout tests
3455         <https://webkit.org/b/193222>
3456         <rdar://problem/46862309>
3457
3458         Reviewed by Joseph Pecoraro.
3459
3460         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3461         (WTR::executeCallback): Fix camel case of variable name.
3462         (WTR::EventSendingController::callAfterScrollingCompletes): If
3463         WKBundlePageRegisterScrollOperationCompletionCallback() returns
3464         false, make sure to release the ScrollCompletionCallbackData
3465         object.  This fixes the leak.
3466
3467 2019-01-07  Fujii Hironori  <Hironori.Fujii@sony.com>
3468
3469         [Win] EWS: wincairo-ews cannot apply a patch with *.png
3470         https://bugs.webkit.org/show_bug.cgi?id=193044
3471
3472         Reviewed by Daniel Bates.
3473
3474         WinCairo EWS bots are using Windows Perl. Binary files should be
3475         opened as binary mode.
3476
3477         * Scripts/svn-apply:
3478         (handleGitBinaryChange): Use 'binmode' for binary file handles.
3479
3480 2019-01-07  Don Olmstead  <don.olmstead@sony.com>
3481
3482         [CMake] Add ENABLE_CSS_TYPED_OM option
3483         https://bugs.webkit.org/show_bug.cgi?id=193216
3484
3485         Reviewed by Michael Catanzaro.
3486
3487         * Scripts/webkitperl/FeatureList.pm:
3488
3489 2019-01-07  David Kilzer  <ddkilzer@apple.com>
3490
3491         Prefer RetainPtr<NSObject> to RetainPtr<NSObject *>
3492         <https://webkit.org/b/193056>
3493
3494         Reviewed by Alex Christensen.
3495
3496         * Scripts/webkitpy/style/checker.py:
3497         - Ignore use of new runtime/retainptr check in
3498           Tools/TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm since it
3499           contains tests to ensure RetainPtr<NSObject *> is compatible
3500           with RetainPtr<NSObject>.
3501
3502         * Scripts/webkitpy/style/checkers/cpp.py:
3503         (check_language):
3504         (CppChecker):
3505         - Add checker for use of '*' in RetainPtr<> type.  A for loop
3506           was used instead of a single regex so that angle brackets
3507           could be matched up when checking the type contained within
3508           the RetainPtr<> type.
3509
3510         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3511         (CppStyleTest):
3512         - Add unit test for new runtime/retainptr check.
3513
3514         * TestRunnerShared/EventSerialization/mac/EventSerializerMac.h:
3515         * TestWebKitAPI/EditingTestHarness.h:
3516         - Remove '*' from RetainPtr<> type.
3517
3518         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3519         - Add cf/RetainPtr.cpp back to TestWTFLibrary target!  This
3520           regressed in r201938.
3521
3522         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp:
3523         (TestWebKitAPI::TEST):
3524         - Update tests to match RetainPtr.mm tests (except for the
3525           `*SimilarNSType` tests since there is no CF equivalent of
3526           RetainPtr<NSString> and RetainPtr<NSString *>).
3527
3528         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
3529         (TestWebKitAPI::TEST):
3530         - Update tests to:
3531           - Not conflict by name with equivalent CF tests in
3532             RetainPtr.cpp.
3533           - Add test cases for RetainPtr<NSObject>,
3534             RetainPtr<NSObject *> and RetainPtr<id> were appropriate.
3535           - Add `*SimilarNSType` tests for converting between
3536             RetainPtr<NSObject> and RetainPtr<NSObject *>.
3537           - Change `0` to `nil` as appropriate.
3538           - Re-alphabetize the tests by name.
3539           - Add Optional<RetainPtr<>> tests.
3540           - Add retainPtr() tests.
3541
3542         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
3543         (-[DownloadProgressTestRunner _download:decideDestinationWithSuggestedFilename:completionHandler:]):
3544         * TestWebKitAPI/Tests/WebKitCocoa/IconLoadingDelegate.mm:
3545         (TEST):
3546         - Remove '*' from RetainPtr<> type.
3547
3548         * TestWebKitAPI/Tests/WebKitCocoa/JITEnabled.mm:
3549         (TEST(WebKit, JITEnabled)):
3550         - Add missing WTFMove().  Apparently a temporary was being
3551           created before in the argument list due to mismatched
3552           RetainPtr<> types.
3553
3554         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3555         * TestWebKitAPI/Tests/WebKitCocoa/VideoControlsManager.mm:
3556         (TestWebKitAPI::setUpWebViewForTestingVideoControlsManager):
3557         (TestWebKitAPI::TEST):
3558         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3559         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
3560         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
3561         (WTR::resourcesDirectoryURL):
3562         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
3563         (WTR::InjectedBundle::platformInitialize):
3564         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3565         - Remove '*' from RetainPtr<> type.
3566
3567 2019-01-07  Eric Carlson  <eric.carlson@apple.com>
3568
3569         A MediaTime timescale must never be zero
3570         https://bugs.webkit.org/show_bug.cgi?id=193156
3571         <rdar://problem/32504501>
3572
3573         Reviewed by Jer Noble.
3574
3575         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
3576         (TestWebKitAPI::TEST): Add tests for zero timescale.
3577
3578 2019-01-07  Youenn Fablet  <youenn@apple.com>
3579
3580         API test broken: TestWebKitAPI.WebKit.CustomDataStorePathsVersusCompletionHandlers
3581         https://bugs.webkit.org/show_bug.cgi?id=193175
3582
3583         Reviewed by Chris Dumez.
3584
3585         Updated API test as we bumped the SW schema to version 4.
3586
3587         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3588         * TestWebKitAPI/Tests/WebKitCocoa/SimpleServiceWorkerRegistrations-4.sqlite3: Renamed from Tools/TestWebKitAPI/Tests/WebKitCocoa/SimpleServiceWorkerRegistrations-3.sqlite3.
3589         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3590         (TEST):
3591
3592 2019-01-06  Fujii Hironori  <Hironori.Fujii@sony.com>
3593
3594         [Win][Clang] Fix compilation warnings of MiniBrowser
3595         https://bugs.webkit.org/show_bug.cgi?id=193029
3596
3597         Reviewed by Ross Kirsling.
3598
3599         * MiniBrowser/win/MiniBrowserWebHost.h: Removed unused m_oldFont
3600         and m_URLBarFont. Reorder member variables to fix -Wreorder
3601         warning.
3602         * MiniBrowser/win/PageLoadTestClient.cpp:
3603         (PageLoadTestClient::PageLoadTestClient): Reorder the member initializer list.
3604         * MiniBrowser/win/PageLoadTestClient.h: Removed 'virtual' of
3605         pageLoadStartedAtTime and pageLoadEndedAtTime. Removed unused
3606         m_currentURLIndex.
3607         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3608         (WebKitBrowserWindow::WebKitBrowserWindow): Initialize
3609         navigationClient with '{ }' to fix the missing field warning.
3610         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
3611         (initDocStruct): Changed the argument type docname to const.
3612
3613 2019-01-06  Jiewen Tan  <jiewen_tan@apple.com>
3614
3615         [WebAuthN] Import U2F command/response converters from Chromium
3616         https://bugs.webkit.org/show_bug.cgi?id=193150
3617         <rdar://problem/47054028>
3618
3619         Reviewed by Brent Fulgham.
3620
3621         Adds API tests.
3622
3623         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3624         * TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp:
3625         (TestWebKitAPI::getTestAttestedCredentialDataBytes):
3626         (TestWebKitAPI::getTestAuthenticatorDataBytes):
3627         (TestWebKitAPI::getTestAttestationObjectBytes):
3628         (TestWebKitAPI::getTestSignResponse):
3629         (TestWebKitAPI::getTestU2fRegisterResponse):
3630         (TestWebKitAPI::TEST):
3631         (TestWebKitAPI::convertToVector): Deleted.
3632         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
3633         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp: Added.
3634         (TestWebKitAPI::constructMakeCredentialRequest):
3635         (TestWebKitAPI::constructGetAssertionRequest):
3636         (TestWebKitAPI::TEST):
3637
3638 2019-01-05  Oriol Brufau  <obrufau@igalia.com>
3639
3640         [GTK] Add python3-setuptools, libunistring-dev, bison and flex dependencies
3641         https://bugs.webkit.org/show_bug.cgi?id=193136
3642
3643         Reviewed by Michael Catanzaro.
3644
3645         * gtk/install-dependencies:
3646         Add python3-setuptools, libunistring-dev, bison and flex to install-dependencies,
3647         they are needed by update-webkitgtk-libs.
3648
3649 2019-01-05  Aakash Jain  <aakash_jain@apple.com>
3650
3651         Unreviewed follow-up fix to r239650
3652         https://bugs.webkit.org/show_bug.cgi?id=193140
3653         <rdar://problem/47063037>
3654
3655         Typecast patch_id to string.
3656
3657 &