61890aced8428a39cd123edc072f758472af1770
[WebKit-https.git] / Tools / ChangeLog
1 2016-11-19  Joanmarie Diggs  <jdiggs@igalia.com>
2
3         AX: [ATK] Expose aria-busy via ATK_STATE_BUSY
4         https://bugs.webkit.org/show_bug.cgi?id=164909
5
6         Reviewed by Chris Fleizach.
7
8         Implement boolAttributeValue() for ATK so we can test AXElementBusy.
9
10         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
11         (WTR::AccessibilityUIElement::boolAttributeValue):
12
13 2016-11-18  Simon Fraser  <simon.fraser@apple.com>
14
15         [iOS WK2] Eliminate a source of flakiness in layout tests by forcing WebPage into "responsive" mode for all tests, with an internals override
16         https://bugs.webkit.org/show_bug.cgi?id=164980
17
18         Reviewed by Chris Dumez.
19
20         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
21         (WTR::InjectedBundlePage::prepare):
22
23 2016-11-18  Dean Jackson  <dino@apple.com>
24
25         AX: "(inverted-colors)" media query only matches on page reload; should match on change
26         https://bugs.webkit.org/show_bug.cgi?id=163564
27         <rdar://problem/28807350>
28
29         Reviewed by Simon Fraser.
30
31         Add a UIScriptController method that tricks WebKit into thinking
32         it has received a notification that accessibility settings have
33         changed. Combined with our forced overrides, this allows us to
34         test if a page would react to the notifications.
35
36         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
37         (WTR::UIScriptController::simulateAccessibilitySettingsChangeNotification):
38         * DumpRenderTree/mac/UIScriptControllerMac.mm:
39         (WTR::UIScriptController::simulateAccessibilitySettingsChangeNotification):
40         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
41         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
42         (WTR::simulateAccessibilitySettingsChangeNotification):
43         * TestRunnerShared/UIScriptContext/UIScriptController.h:
44         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
45         (WTR::UIScriptController::simulateAccessibilitySettingsChangeNotification):
46         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
47         (WTR::UIScriptController::simulateAccessibilitySettingsChangeNotification):
48
49 2016-11-18  Alex Christensen  <achristensen@webkit.org>
50
51         Fix API test after r208902
52         https://bugs.webkit.org/show_bug.cgi?id=144194
53
54         * TestWebKitAPI/Tests/Cocoa/URLExtras.mm:
55         (TestWebKitAPI::TEST):
56         The fullwidth solidus, U+FF0F, changed encoding from IDN2003 to IDN2008, probably to prevent domains from using it
57         to spoof other domains.  https://webkit.org/blog/ and https://webkit.org\uFF0Fblog/ would otherwise look 
58         too similar when rendered.
59
60 2016-11-17  Alex Christensen  <achristensen@webkit.org>
61
62         Support IDN2008 with UTS #46 instead of IDN2003
63         https://bugs.webkit.org/show_bug.cgi?id=144194
64
65         Reviewed by Darin Adler.
66
67         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
68         (TestWebKitAPI::TEST_F):
69         Add some tests from http://unicode.org/faq/idn.html verifying that we follow UTS46's deviations from IDN2008.
70         Add some tests based on https://tools.ietf.org/html/rfc5893 verifying that we check for bidirectional text.
71         Add a test based on https://tools.ietf.org/html/rfc5892 verifying that we do not do ContextO check.
72         Add a test for U+321D and U+321E which have particularly interesting punycode encodings.  We match Firefox here now.
73         Also add a test from http://www.unicode.org/reports/tr46/#IDNAComparison verifying we are not using IDN2003.
74         We should consider importing all of http://www.unicode.org/Public/idna/9.0.0/IdnaTest.txt as URL domain tests.
75
76 2016-11-17  Carlos Garcia Campos  <cgarcia@igalia.com>
77
78         Downloads started by context menu actions should also have a web view associated
79         https://bugs.webkit.org/show_bug.cgi?id=164364
80
81         Reviewed by Michael Catanzaro.
82
83         Add a GTK+ unit tests to check that downloads started by the context menu have a web view associated.
84
85         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
86         (downloadLocalFileSuccessfully):
87         (testDownloadOverwriteDestinationDisallowed):
88         (testDownloadLocalFileError):
89         (testDownloadRemoteFile):
90         (testDownloadRemoteFileError):
91         (testDownloadMIMEType):
92         (contextMenuCallback):
93         (testContextMenuDownloadActions):
94         (beforeAll):
95
96 2016-11-17  Ryosuke Niwa  <rniwa@webkit.org>
97
98         Add an experimental API to find elements across shadow boundaries
99         https://bugs.webkit.org/show_bug.cgi?id=164851
100         <rdar://problem/28220092>
101
102         Reviewed by Sam Weinig.
103
104         Added test cases for window.collectMatchingElementsInFlatTree to WebKit2.InjectedBundleMakeAllShadowRootOpen.
105
106         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
107         * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRoot*s*Open_Bundle.cpp: Renamed
108         from InjectedBundleMakeAllShadowRootOpen_Bundle.cpp.
109         (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize): Added test cases for
110         window.collectMatchingElementsInFlatTree by calling alert() many times.
111         * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen.cpp:
112         (TestWebKitAPI::runJavaScriptAlert): Added expectations for multiple test cases. Each test case
113         finishes with a call to alert, and moves testNumber forward.
114         (TestWebKitAPI::TEST): Use the newly added closed-shadow-tree-test.html
115         * TestWebKitAPI/Tests/WebKit2/closed-shadow-tree-test.html: Added. Creates a shadow tree with slots
116         and tests that window.collectMatchingElementsInFlatTree is not present when
117         an event named "testnormalworld" is dispatched by the injected bundle.
118
119 2016-11-17  Brady Eidson  <beidson@apple.com>
120
121         Add _WKIconLoadingDelegate SPI.
122         https://bugs.webkit.org/show_bug.cgi?id=164894
123
124         Reviewed by Alex Christensen.
125
126         Add MiniBrowser support for this new SPI, configurable with a setting.
127
128         * MiniBrowser/mac/SettingsController.h:
129         * MiniBrowser/mac/SettingsController.m:
130         (-[SettingsController _populateMenu]):
131         (-[SettingsController validateMenuItem:]):
132         (-[SettingsController loadsAllSiteIcons]):
133         (-[SettingsController toggleLoadsAllSiteIcons:]):
134         * MiniBrowser/mac/WK2BrowserWindowController.m:
135         (-[WK2BrowserWindowController awakeFromNib]):
136         (-[WK2BrowserWindowController webView:shouldLoadIconWithParameters:completionHandler:]):
137
138 2016-11-17  Caitlin Potter  <caitp@igalia.com>
139
140         [JSC] remove leftover references to ES2017_ASYNCFUNCTION_SYNTAX flag
141         https://bugs.webkit.org/show_bug.cgi?id=164879
142
143         Reviewed by Alex Christensen.
144
145         The flag was referenced in FeatureList.pm and in one of the
146         FeatureDefines.xcconfig files, despite being removed.
147
148         * Scripts/webkitperl/FeatureList.pm:
149         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
150
151 2016-11-17  Per Arne Vollan  <pvollan@apple.com>
152
153         [Win] run-api-tests is failing.
154         https://bugs.webkit.org/show_bug.cgi?id=164818
155
156         Reviewed by Alexey Proskuryakov.
157
158         Make sure Visual Studio interprets string literal as utf8.
159  
160         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
161         (TestWebKitAPI::TEST_F):
162
163 2016-11-17  Yusuke Suzuki  <utatane.tea@gmail.com>
164
165         [JSC] WTF::TemporaryChange with WTF::SetForScope
166         https://bugs.webkit.org/show_bug.cgi?id=164761
167
168         Reviewed by Saam Barati.
169
170         * TestWebKitAPI/CMakeLists.txt:
171         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
172         * TestWebKitAPI/Tests/WTF/SetForScope.cpp: Renamed from Tools/TestWebKitAPI/Tests/WTF/TemporaryChange.cpp.
173         (TestWebKitAPI::TEST):
174         * WebKitTestRunner/TestController.cpp:
175         (WTR::TestController::resetStateToConsistentValues):
176
177 2016-11-16  Alexey Proskuryakov  <ap@apple.com>
178
179         REGRESSION (r208455): LayoutTests swipe/pushState-cached-back-swipe.html and swipe/main-frame-pinning-requirement.html are failing
180         https://bugs.webkit.org/show_bug.cgi?id=164572
181
182         Reviewed by Tim Horton.
183
184         * WebKitTestRunner/mac/TestControllerMac.mm: (WTR::TestController::platformResetStateToConsistentValues):
185         Use the correct constant.
186
187 2016-11-16  Yusuke Suzuki  <utatane.tea@gmail.com>
188
189         [ES6][WebCore] Change ES6_MODULES compile time flag to runtime flag
190         https://bugs.webkit.org/show_bug.cgi?id=164827
191
192         Reviewed by Ryosuke Niwa.
193
194         Enabled ES6 Modules in test runners.
195
196         * DumpRenderTree/mac/DumpRenderTree.mm:
197         (resetWebPreferencesToConsistentValues):
198         * DumpRenderTree/win/DumpRenderTree.cpp:
199         (resetWebPreferencesToConsistentValues):
200         * Scripts/webkitperl/FeatureList.pm:
201         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
202         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
203         (WTR::InjectedBundle::beginTesting):
204         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
205         (WTR::TestRunner::setES6ModulesEnabled):
206         * WebKitTestRunner/InjectedBundle/TestRunner.h:
207
208 2016-11-16  Simon Fraser  <simon.fraser@apple.com>
209
210         Hard to write reliable UIScriptController scrollingTreeAsText tests
211         https://bugs.webkit.org/show_bug.cgi?id=164764
212
213         Reviewed by Wenson Hsieh.
214
215         Fix one cause of flakiness by resetting the WKWebView's UIScrollView scale
216         and scroll position between tests.
217
218         * WebKitTestRunner/ios/TestControllerIOS.mm:
219         (WTR::TestController::platformResetStateToConsistentValues):
220
221 2016-11-16  Simon Fraser  <simon.fraser@apple.com>
222
223         UIScriptController: script with no async tasks fails if an earlier script registered a callback
224         https://bugs.webkit.org/show_bug.cgi?id=164762
225
226         Reviewed by Wenson Hsieh.
227         
228         Make TestRunner::callUIScriptCallback() async in DumpRenderTree to match WebKitTestRunner behavior.
229         This fixes ui-side-script-with-callback.html in WK1, which failed because the second runUIScript()
230         would occur inside the completion callback from the first. This no longer happens.
231
232         * DumpRenderTree/TestRunner.cpp:
233         (TestRunner::callUIScriptCallback):
234         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
235         (UIScriptContext::tryToCompleteUIScriptForCurrentParentCallback):
236
237 2016-11-16  Ryan Haddad  <ryanhaddad@apple.com>
238
239         Unreviewed, rolling out r208770.
240
241         The test added with this change is timing out on mac-wk1.
242
243         Reverted changeset:
244
245         "UIScriptController: script with no async tasks fails if an
246         earlier script registered a callback"
247         https://bugs.webkit.org/show_bug.cgi?id=164762
248         http://trac.webkit.org/changeset/208770
249
250 2016-11-16  Per Arne Vollan  <pvollan@apple.com>
251
252         [Win] WebCore test is failing.
253         https://bugs.webkit.org/show_bug.cgi?id=164772
254
255         Reviewed by Brent Fulgham.
256
257         The value of CGRectInfinite is not the same on Windows as on Mac.
258
259         * TestWebKitAPI/Tests/WebCore/FloatRect.cpp:
260         (TestWebKitAPI::TEST):
261
262 2016-11-15  Alexey Proskuryakov  <ap@apple.com>
263
264         Update Youenn's e-mail addresses.
265
266         * Scripts/webkitpy/common/config/contributors.json:
267
268 2016-11-15  Simon Fraser  <simon.fraser@apple.com>
269
270         UIScriptController: script with no async tasks fails if an earlier script registered a callback
271         https://bugs.webkit.org/show_bug.cgi?id=164762
272
273         Reviewed by Wenson Hsieh.
274         
275         UIScriptContext::runUIScript() considers a script to be "immediate" if that script doesn't
276         queue any async tasks. However, if an earlier UI script registered a callback, UIScriptContext::runUIScript()
277         would consider that an outstanding task.
278         
279         Fix by unregistering any callbacks associated with the current UI script when uiScriptComplete() is called.
280
281         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
282         (UIScriptContext::tryToCompleteUIScriptForCurrentParentCallback):
283
284 2016-11-15  Simon Fraser  <simon.fraser@apple.com>
285
286         UIScriptController: setting a callback to undefined should unregister it
287         https://bugs.webkit.org/show_bug.cgi?id=164796
288
289         Reviewed by Dean Jackson.
290         
291         "Immediate" UI scripts (those that don't schedule any async tasks) should return
292         immediately, without the need to call uiScriptComplete(). However, this is broken if
293         an earlier UI script registered a callback (since no-one clears that callback after the
294         first script completes).
295
296         Make possible the workaround of setting the callback to undefined, which previously did
297         not clear the callback registration.
298
299         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
300         (UIScriptContext::registerCallback):
301         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
302         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
303         (WTR::UIScriptController::platformClearAllCallbacks):
304
305 2016-11-14  Mark Lam  <mark.lam@apple.com>
306
307         Enhance run-jsc-stress-test script to allow optional test specific options to be added for all test run configurations.
308         https://bugs.webkit.org/show_bug.cgi?id=164695
309
310         Reviewed by Keith Miller.
311
312         This gives us more flexibility when specific tests needs to enable special JSC
313         options in order to exercise specific code paths to be tested.  It also saves us
314         from having to create duplicate test run configurations e.g. runMiscFTLNoCJITTest.
315         We can now just use runFTLNoCJIT in its place.
316
317         Also replaced the ifJSCArgIsntProvidedAreWeReleaseBuild variable with $buildType
318         so that we have the ability to skip certain tests for release or debug builds.
319         This will be needed in the upcoming patch for https://webkit.org/b/155145.
320
321         * Scripts/run-jsc-stress-tests:
322
323 2016-11-14  Joanmarie Diggs  <jdiggs@igalia.com>
324
325         AX: [ATK] Expose STATE_SINGLE_LINE and STATE_MULTI_LINE for ARIA searchbox role
326         https://bugs.webkit.org/show_bug.cgi?id=164712
327
328         Reviewed by Chris Fleizach.
329
330         Add AccessibilityUIElement::isSingleLine, AccessibilityUIElement::isMultiLine
331         to DRT and WKTR. Implement it for ATK.
332
333         * DumpRenderTree/AccessibilityUIElement.h:
334         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
335         (AccessibilityUIElement::isSingleLine):
336         (AccessibilityUIElement::isMultiLine):
337         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
338         (AccessibilityUIElement::isSingleLine):
339         (AccessibilityUIElement::isMultiLine):
340         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
341         (AccessibilityUIElement::isSingleLine):
342         (AccessibilityUIElement::isMultiLine):
343         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
344         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
345         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
346         (WTR::AccessibilityUIElement::isSingleLine):
347         (WTR::AccessibilityUIElement::isMultiLine):
348         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
349         (WTR::AccessibilityUIElement::isSingleLine):
350         (WTR::AccessibilityUIElement::isMultiLine):
351         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
352         (WTR::AccessibilityUIElement::isSingleLine):
353         (WTR::AccessibilityUIElement::isMultiLine):
354
355 2016-11-14  Youenn Fablet  <youenn@apple.com>
356
357         Support WPT templated tests
358         https://bugs.webkit.org/show_bug.cgi?id=164707
359
360         Reviewed by Sam Weinig.
361
362         * Scripts/webkitpy/w3c/test_importer.py:
363         (TestImporter.write_html_files_for_templated_js_tests): Generating empty HTML files for templated JS tests.
364         (TestImporter.import_tests):
365
366 2016-11-13  JF Bastien  <jfbastien@apple.com>
367
368         Implement WTF::Expected
369         https://bugs.webkit.org/show_bug.cgi?id=164526
370
371         Reviewed by Yusuke Suzuki.
372
373         std::expected isn't in C++17, and may be in C++20. It's a nice
374         complement to std::any / std::optional because it's a type-tagged
375         union which has a single expected result but could also contain an
376         error.
377
378         This would be useful in the WebAssembly parser, for example.
379
380         Using this implementation will allow us to provide feedback to the
381         standards committee and guide std::expected's design before it
382         gets standardized. I've already sent a bunch of feedback to the
383         author based on my experience implementing this.
384
385         This could supplement WTF::Either and WTF::ExceptionOr.
386
387         * TestWebKitAPI/CMakeLists.txt:
388         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
389         * TestWebKitAPI/Tests/WTF/Expected.cpp: Added.
390         (WTF::operator<<):
391         (TestWebKitAPI::TEST):
392         (TestWebKitAPI::foo::foo):
393         (TestWebKitAPI::foo::~foo):
394         (TestWebKitAPI::foo::operator==):
395         (TestWebKitAPI::operator<<):
396
397 2016-11-12  Simon Fraser  <simon.fraser@apple.com>
398
399         Add a way to get the UI-side scrolling tree as text via UIScriptController
400         https://bugs.webkit.org/show_bug.cgi?id=164697
401
402         Reviewed by Zalan Bujtas.
403
404         Add UIScriptController::scrollingTreeAsText(), which gets the state of the scrolling
405         tree in the UI process, including the current positions of CALayers. This will be used
406         to test UI-side scrolling and visual viewports.
407
408         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
409         (WTR::UIScriptController::scrollingTreeAsText):
410         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
411         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
412         (WTR::UIScriptController::scrollingTreeAsText):
413         * TestRunnerShared/UIScriptContext/UIScriptController.h:
414         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
415         (WTR::UIScriptController::scrollingTreeAsText):
416
417 2016-11-12  Wenson Hsieh  <wenson_hsieh@apple.com>
418
419         The main content heuristic should be robust when handling large media elements
420         https://bugs.webkit.org/show_bug.cgi?id=164676
421         <rdar://problem/29211503>
422
423         Reviewed by Eric Carlson.
424
425         Added a new test verifying that enormous video elements are handled gracefully when put through the main
426         content heuristic.
427
428         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
429         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
430         (TestWebKitAPI::TEST):
431         * TestWebKitAPI/Tests/WebKit2Cocoa/enormous-video-with-sound.html: Added.
432
433 2016-11-12  Dan Bernstein  <mitz@apple.com>
434
435         run-safari does not work for open source contributors
436         https://bugs.webkit.org/show_bug.cgi?id=164667
437         <rdar://problem/29229894>
438
439         Reviewed by Joseph Pecoraro.
440
441         * Scripts/run-api-tests:
442         (archCommandLineArgumentsForRestrictedEnvironmentVariables): Moved from here…
443         * Scripts/webkitdirs.pm:
444         (archCommandLineArgumentsForRestrictedEnvironmentVariables): …to here
445         (runMacWebKitApp): Have arch(1) carry the DYLD_* variables we set in our environmet over
446           to the environment of the app being run.
447
448 2016-11-11  Joseph Pecoraro  <pecoraro@apple.com>
449
450         Removed unused INCLUDE_OPTIONS_FOR_DEBUGGING
451         https://bugs.webkit.org/show_bug.cgi?id=164664
452
453         Reviewed by Dan Bernstein.
454
455         * Scripts/debug-minibrowser:
456         * Scripts/debug-safari:
457         * Scripts/debug-test-runner:
458         * Scripts/webkitdirs.pm:
459         (printHelpAndExitForRunAndDebugWebKitAppIfNeeded):
460         There are no debug specific options anymore.
461
462 2016-11-11  Wenson Hsieh  <wenson_hsieh@apple.com>
463
464         [WK2] autocorrect and autocapitalize attributes do not work in contenteditable elements
465         https://bugs.webkit.org/show_bug.cgi?id=164538
466         <rdar://problem/8418711>
467
468         Reviewed by Ryosuke Niwa.
469
470         Adds support for being able to test autocorrect and autocapitalize attributes in contenteditable areas. To do
471         this, we add removeAllDynamicDictionaries to UIScriptController in order to ensure that autocorrect suggestions
472         are reset to their defaults prior to running contenteditable-autocorrect-off.html.
473
474         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
475         (WTR::UIScriptController::removeAllDynamicDictionaries):
476         * Scripts/webkitpy/port/ios.py:
477         (IOSSimulatorPort._createSimulatorApp):
478         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
479         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
480         (WTR::UIScriptController::removeAllDynamicDictionaries):
481         * TestRunnerShared/UIScriptContext/UIScriptController.h:
482         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
483         (-[TestRunnerWKWebView _keyboardDidShow:]):
484         (-[TestRunnerWKWebView _keyboardDidHide:]):
485
486         Work around an issue where consecutive UIKeyboardDidShowNotification would cause keyboard appearance callbacks
487         to be fired multiple times. This was causing a single key press to cause two characters to be typed. While this
488         does not affect the correctness of existing tests, the new autocorrection test requires this workaround.
489
490         * WebKitTestRunner/ios/UIKitSPI.h:
491         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
492         (WTR::UIScriptController::waitForTextPredictionsViewAndSelectCandidateAtIndex):
493         (WTR::UIScriptController::removeAllDynamicDictionaries):
494
495 2016-11-11  Alex Christensen  <achristensen@webkit.org>
496
497         Build all Mac API tests
498         https://bugs.webkit.org/show_bug.cgi?id=164633
499
500         Reviewed by Gyuyoung Kim.
501
502         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
503         * TestWebKitAPI/Tests/mac/NavigatorLanguage.mm:
504
505 2016-11-11  Alex Christensen  <achristensen@webkit.org>
506
507         Allow mutable lambdas in HashMap::ensure
508         https://bugs.webkit.org/show_bug.cgi?id=164642
509
510         Reviewed by Sam Weinig.
511
512         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
513         (TestWebKitAPI::TEST):
514
515 2016-11-10  Wenson Hsieh  <wenson_hsieh@apple.com>
516
517         Composition state should be cleared when changing focus to a non-editable element
518         https://bugs.webkit.org/show_bug.cgi?id=164595
519         <rdar://problem/26412551>
520
521         Reviewed by Enrica Casucci.
522
523         Adds support for window.textInputController in DumpRenderTree on iOS. So far, only the methods needed for the
524         new layout test (editing/focus-change-with-marked-text.html) are supported. These are insertText, setMarkedText,
525         and markedRange.
526
527         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
528         * DumpRenderTree/TextInputController.h: Renamed from Tools/DumpRenderTree/mac/TextInputController.h.
529
530         Remove the PLATFORM(MAC) guard for defining the TextInputController. Also, move the TextInputController header
531         out of the /mac platform directory.
532
533         * DumpRenderTree/ios/TextInputControllerIOS.m: Added.
534         (+[TextInputController isSelectorExcludedFromWebScript:]):
535         (+[TextInputController webScriptNameForSelector:]):
536         (-[TextInputController initWithWebView:]):
537         (-[TextInputController markedRange]):
538         (-[TextInputController insertText:]):
539         (-[TextInputController setMarkedText:selectedFrom:length:]):
540
541         Introduces TextInputControllerIOS.m, which contains an iOS implementation of TextInputController. Only a subset
542         of the methods available on the Mac version will be available on iOS for now (see above).
543
544         * DumpRenderTree/mac/FrameLoadDelegate.mm:
545
546         Remove the PLATFORM(MAC) guard for initializing the TextInputController and binding it to the window object.
547
548         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
549         * DumpRenderTree/mac/TextInputControllerMac.m: Renamed from Tools/DumpRenderTree/mac/TextInputController.m.
550         (-[WebHTMLView interpretKeyEvents:]):
551         (-[WebNSRange initWithNSRange:]):
552         (-[WebNSRange location]):
553         (-[WebNSRange length]):
554         (+[WebNSRange isSelectorExcludedFromWebScript:]):
555         (+[NSMutableAttributedString isSelectorExcludedFromWebScript:]):
556         (+[NSMutableAttributedString webScriptNameForSelector:]):
557         (-[NSMutableAttributedString getLength]):
558         (-[NSMutableAttributedString ranges]):
559         (-[NSMutableAttributedString attributeNamesAtIndex:]):
560         (-[NSMutableAttributedString valueOfAttribute:atIndex:]):
561         (-[NSMutableAttributedString addAttribute:value:]):
562         (-[NSMutableAttributedString addAttribute:value:from:length:]):
563         (-[NSMutableAttributedString addColorAttribute:red:green:blue:alpha:]):
564         (-[NSMutableAttributedString addColorAttribute:red:green:blue:alpha:from:length:]):
565         (-[NSMutableAttributedString addFontAttribute:fontName:size:]):
566         (-[NSMutableAttributedString addFontAttribute:fontName:size:from:length:]):
567         (+[TextInputController isSelectorExcludedFromWebScript:]):
568         (+[TextInputController webScriptNameForSelector:]):
569         (-[TextInputController initWithWebView:]):
570         (-[TextInputController dealloc]):
571         (-[TextInputController textInput]):
572         (-[TextInputController insertText:]):
573         (-[TextInputController doCommand:]):
574         (-[TextInputController setMarkedText:selectedFrom:length:]):
575         (-[TextInputController unmarkText]):
576         (-[TextInputController hasMarkedText]):
577         (-[TextInputController conversationIdentifier]):
578         (-[TextInputController substringFrom:length:]):
579         (-[TextInputController attributedSubstringFrom:length:]):
580         (-[TextInputController legacyAttributedString:]):
581         (-[TextInputController markedRange]):
582         (-[TextInputController selectedRange]):
583         (-[TextInputController firstRectForCharactersFrom:length:]):
584         (-[TextInputController characterIndexForPointX:Y:]):
585         (-[TextInputController validAttributesForMarkedText]):
586         (-[TextInputController attributedStringWithString:]):
587         (-[TextInputController stringWithUndoGroupingInsertion:]):
588         (-[TextInputController dictatedStringWithPrimaryString:alternative:alternativeOffset:alternativeLength:]):
589         (-[TextInputController setInputMethodHandler:]):
590         (-[TextInputController interpretKeyEvents:withSender:]):
591
592         Fixes miscellaneous style issues.
593
594 2016-11-11  Philippe Normand  <pnormand@igalia.com>
595
596         [GTK][JHbuild] bump libnice version in openwebrtc.modules
597         https://bugs.webkit.org/show_bug.cgi?id=164586
598
599         Reviewed by Michael Catanzaro.
600
601         Update to a recent libnice git snapshot and remove patches already
602         upstream or not applying anymore. The patches not upstream yet
603         will be reported in Phabricator.
604
605         * gtk/openwebrtc.modules:
606         * gtk/patches/libnice-0001-agent-Remove-unnecessary-NULL-check.patch: Removed.
607         * gtk/patches/libnice-0002-Do-not-update-a-remote-candidate-s-type.patch: Removed.
608         * gtk/patches/libnice-0002-TURN-handle-437-Allocation-Mismatch-responses.patch: Removed.
609         * gtk/patches/libnice-0003-Do-not-compare-scope-for-IPv6-address-when-scope-is-.patch: Removed.
610         * gtk/patches/libnice-0004-Removing-no-op-assignment.patch: Removed.
611
612 2016-11-10  Alex Christensen  <achristensen@webkit.org>
613
614         Fix assertion after r208534.
615         https://bugs.webkit.org/show_bug.cgi?id=160497
616
617         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
618         * TestWebKitAPI/Tests/mac/MemoryPressureHandler.mm: Added.
619         (TestWebKitAPI::TEST):
620         Add a regression test.
621
622 2016-11-10  Chris Dumez  <cdumez@apple.com>
623
624         REGRESSION (r208522): LayoutTest fast/loader/reload-zero-byte-plugin.html is a flaky failure
625         https://bugs.webkit.org/show_bug.cgi?id=164570
626
627         Reviewed by Simon Fraser.
628
629         Properly reset TestController::m_shouldDownloadUndisplayableMIMETypes between tests to
630         avoid flakiness.
631
632         * WebKitTestRunner/TestController.cpp:
633         (WTR::TestController::resetStateToConsistentValues):
634
635 2016-11-10  Miguel Gomez  <magomez@igalia.com>
636
637         Unreviewed. Added myself to the list of committers.
638
639         * Scripts/webkitpy/common/config/contributors.json:
640
641 2016-10-27  Sergio Villar Senin  <svillar@igalia.com>
642
643         [GTK] New API to notify about dynamically added forms
644         https://bugs.webkit.org/show_bug.cgi?id=164050
645
646         Reviewed by Carlos Garcia Campos.
647
648         Added a new test case to verify that dinamically added forms correctly trigger the
649         "form-controls-associated" signal from WebPage.
650
651         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
652         (didAssociateFormControlsCallback):
653         (testWebExtensionFormControlsAssociated):
654         (beforeAll):
655         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
656         (DelayedSignal::DelayedSignal):
657         (emitFormControlsAssociated):
658         (formControlsAssociatedCallback):
659         (pageCreatedCallback):
660
661 2016-11-09  Ryosuke Niwa  <rniwa@webkit.org>
662
663         WebHTMLView's _attributeStringFromDOMRange should use HTMLConverter instead of NSAttributedString's _initWithDOMRange
664         https://bugs.webkit.org/show_bug.cgi?id=164501
665         <rdar://problem/29152282>
666
667         Reviewed by Sam Weinig.
668
669         * DumpRenderTree/mac/TextInputController.m:
670         (-[TextInputController legacyAttributedString:]):
671
672 2016-11-09  Chris Dumez  <cdumez@apple.com>
673
674         [WK2][NETWORK_SESSION] Add support for downloading file backed blobs
675         https://bugs.webkit.org/show_bug.cgi?id=164458
676         <rdar://problem/28905514>
677
678         Reviewed by Darin Adler.
679
680         Add testRunner.setShouldDownloadUndisplayableMIMETypes(bool) API so that layout
681         tests can request that such resources are downloaded instead of being ignored.
682
683         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
684         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
685         (WTR::TestRunner::setShouldDownloadUndisplayableMIMETypes):
686         * WebKitTestRunner/InjectedBundle/TestRunner.h:
687         * WebKitTestRunner/TestController.cpp:
688         (WTR::TestController::decidePolicyForNavigationResponse):
689         * WebKitTestRunner/TestController.h:
690         (WTR::TestController::setShouldDownloadUndisplayableMIMETypes):
691         * WebKitTestRunner/TestInvocation.cpp:
692         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
693
694 2016-11-09  Carlos Garcia Campos  <cgarcia@igalia.com>
695
696         NetworkSession: Network process crash when converting main resource to download
697         https://bugs.webkit.org/show_bug.cgi?id=164220
698
699         Reviewed by Alex Christensen.
700
701         Split /webkit2/Downloads/policy-decision-download in two, one to test the full load when main resource is
702         converted to a download and another one to test the cancellation as the test was doing before. When doing the
703         full load, delay a bit the decide destination to ensure the load is aborted before the data task has became a
704         download.
705
706         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
707         (testPolicyResponseDownload):
708         (testPolicyResponseDownloadCancel):
709         (beforeAll):
710
711 2016-11-09  KwangHyuk Kim  <hyuki.kim@samsung.com>
712
713         [EFL] fix error message caused by eina log
714         https://bugs.webkit.org/show_bug.cgi?id=164546
715
716         Reviewed by Gyuyoung Kim.
717
718         Fix error message caused by eina log when MiniBrowser is working with help option.
719
720         * MiniBrowser/efl/main.c:
721         (quit):
722
723 2016-11-09  Brent Fulgham  <bfulgham@apple.com>
724
725         Unreviewed build fix after r208509.
726
727         * DumpRenderTree/win/TestRunnerWin.cpp:
728         (TestRunner::setNeedsStorageAccessFromFileURLsQuirk): Add missing TestRunner implementation."
729
730 2016-11-09  Alex Christensen  <achristensen@webkit.org>
731
732         Unreviewed, rolling out r208438.
733
734         crashes
735
736         Reverted changeset:
737
738         "[WK2][NETWORK_SESSION] Add support for downloading file
739         backed blobs"
740         https://bugs.webkit.org/show_bug.cgi?id=164458
741         http://trac.webkit.org/changeset/208438
742
743 2016-11-04  Brent Fulgham  <bfulgham@apple.com>
744
745         Local HTML should be blocked from localStorage access unless "Disable Local File Restrictions" is checked
746         https://bugs.webkit.org/show_bug.cgi?id=155185
747         <rdar://problem/11101440>
748
749         Reviewed by Brady Eidson.
750
751         * DumpRenderTree/TestRunner.cpp:
752         (setNeedsLocalStorageQuirkCallback): Added.
753         (TestRunner::staticFunctions):
754         * DumpRenderTree/TestRunner.h:
755         * DumpRenderTree/mac/DumpRenderTree.mm:
756         (resetWebPreferencesToConsistentValues): Update for new quirk setting.
757         * DumpRenderTree/mac/TestRunnerMac.mm:
758         (TestRunner::setNeedsLocalStorageQuirk):
759         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
760         * TestWebKitAPI/Tests/WebKit2/CloseFromWithinCreatePage.cpp:
761         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
762         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.mm:
763         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageQuirkEnabled.html: Added.
764         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageQuirkTest.mm: Added.
765         (-[LocalStorageQuirkMessageHandler userContentController:didReceiveScriptMessage:]):
766         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
767         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
768         (WTR::InjectedBundle::beginTesting): Update for new quirk setting.
769         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
770         (WTR::TestRunner::setNeedsLocalStorageQuirk): Added.
771         * WebKitTestRunner/InjectedBundle/TestRunner.h:
772
773 2016-11-09  Alex Christensen  <achristensen@webkit.org>
774
775         URLParser should not consider path of URLs with no host to start at the first slash after the colon
776         https://bugs.webkit.org/show_bug.cgi?id=164555
777
778         Reviewed by Tim Horton.
779
780         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
781         (TestWebKitAPI::TEST_F):
782
783 2016-11-09  Jonathan Bedard  <jbedard@apple.com>
784
785         test-webkitpy failing test_create_patch_is_full_patch unit test
786         https://bugs.webkit.org/show_bug.cgi?id=164385
787
788         Reviewed by Darin Adler.
789
790         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py: Fixed expected output to match output.
791
792 2016-11-09  Chris Dumez  <cdumez@apple.com>
793
794         [Mac] Stop using deprecated AppKit enumeration values
795         https://bugs.webkit.org/show_bug.cgi?id=164494
796
797         Reviewed by Darin Adler.
798
799         Stop using deprecated AppKit enumeration values.
800
801         * DumpRenderTree/mac/EventSendingController.mm:
802         (eventTypeForMouseButtonAndAction):
803         (modifierFlags):
804         (-[EventSendingController mouseMoveToX:Y:]):
805         (-[EventSendingController contextClick]):
806         (-[EventSendingController keyDown:withModifiers:withLocation:]):
807         * DumpRenderTree/mac/TextInputController.m:
808         (-[TextInputController interpretKeyEvents:withSender:]):
809         * TestWebKitAPI/Tests/WebKit2Cocoa/CommandBackForward.mm:
810         (simulateCommandArrow):
811         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenDelegate.mm:
812         (TestWebKitAPI::TEST):
813         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenLayoutConstraints.mm:
814         (TestWebKitAPI::TEST):
815         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenTopContentInset.mm:
816         (TestWebKitAPI::TEST):
817         * TestWebKitAPI/Tests/WebKit2Cocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
818         (TEST):
819         * TestWebKitAPI/Tests/WebKit2Cocoa/UserInitiatedActionInNavigationAction.mm:
820         (UserInitiatedActionTest::SetUp):
821         (UserInitiatedActionTest::click):
822         * TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm:
823         (TestWebKitAPI::AcceptsFirstMouse::runTest):
824         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm:
825         (TestWebKitAPI::contextMenuCopyLink):
826         (TestWebKitAPI::TEST):
827         * TestWebKitAPI/Tests/mac/ContextMenuDefaultItemsHaveTags.mm:
828         (TestWebKitAPI::TEST):
829         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
830         (TestWebKitAPI::FullscreenZoomInitialFrame::runTest):
831         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
832         (TestWebKitAPI::TEST):
833         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
834         (TestWebKitAPI::Util::isKeyDown):
835         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
836         (TestWebKitAPI::PlatformWebView::initialize):
837         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
838         (TestWebKitAPI::PlatformWebView::simulateRightClick):
839         (TestWebKitAPI::PlatformWebView::simulateMouseMove):
840         (TestWebKitAPI::eventTypeForButton):
841         (TestWebKitAPI::modifierFlagsForWKModifiers):
842         * TestWebKitAPI/mac/TestWKWebViewMac.mm:
843         (__simulated_forceClickAssociatedEventsMask):
844         (-[TestWKWebViewHostWindow _mouseDownAtPoint:simulatePressure:]):
845         (-[TestWKWebView _setUpTestWindow:]):
846         (-[TestWKWebView typeCharacter:]):
847         * WebKitTestRunner/mac/EventSenderProxy.mm:
848         (WTR::eventTypeForMouseButtonAndAction):
849         (WTR::buildModifierFlags):
850         (WTR::EventSenderProxy::sendMouseDownToStartPressureEvents):
851         (WTR::EventSenderProxy::mouseForceClick):
852         (WTR::EventSenderProxy::startAndCancelMouseForceClick):
853         (WTR::EventSenderProxy::mouseMoveTo):
854         (WTR::EventSenderProxy::keyDown):
855         (WTR::EventSenderProxy::swipeGestureWithWheelAndMomentumPhases):
856         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
857         (WTR::PlatformWebView::PlatformWebView):
858         * WebKitTestRunner/mac/TestControllerMac.mm:
859         (WTR::TestController::platformResetStateToConsistentValues):
860
861 2016-11-09  Beth Dakin  <bdakin@apple.com>
862
863         Support TouchBar in WebKit
864         https://bugs.webkit.org/show_bug.cgi?id=164437
865         -and corresponding-
866         rdar://problem/28876524
867
868         Reviewed by Darin Adler.
869
870         This makes MiniBrowser support TouchBar customization. 
871
872         * MiniBrowser/mac/AppDelegate.m:
873         (-[BrowserAppDelegate awakeFromNib]):
874
875 2016-11-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
876
877         [EFL] Use libgcrypt instead of GnuTLS for CryptoDigest
878         https://bugs.webkit.org/show_bug.cgi?id=164461
879
880         Reviewed by Michael Catanzaro.
881
882         As GTK port in r208297, EFL port starts to use libgcrypt instead of GnuTLS as well.
883
884         * efl/install-dependencies: Add libgcript package dependecy.
885
886 2016-11-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
887
888         [EFL] Remove unused function in MiniBrowser
889         https://bugs.webkit.org/show_bug.cgi?id=164398
890
891         Reviewed by Darin Adler.
892
893         * MiniBrowser/efl/main.c:
894         (window_find_with_elm_window): Deleted because it is not used anywhere.
895
896 2016-11-09  Chris Dumez  <cdumez@apple.com>
897
898         [WK2][NETWORK_SESSION] Add support for downloading file backed blobs
899         https://bugs.webkit.org/show_bug.cgi?id=164458
900         <rdar://problem/28905514>
901
902         Reviewed by Darin Adler.
903
904         Add testRunner.setShouldDownloadUndisplayableMIMETypes(bool) API so that layout
905         tests can request that such resources are downloaded instead of being ignored.
906
907         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
908         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
909         (WTR::TestRunner::setShouldDownloadUndisplayableMIMETypes):
910         * WebKitTestRunner/InjectedBundle/TestRunner.h:
911         * WebKitTestRunner/TestController.cpp:
912         (WTR::TestController::decidePolicyForNavigationResponse):
913         * WebKitTestRunner/TestController.h:
914         (WTR::TestController::setShouldDownloadUndisplayableMIMETypes):
915         * WebKitTestRunner/TestInvocation.cpp:
916         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
917
918 2016-11-09  Jonathan Bedard  <jbedard@apple.com>
919
920         Make rpaths more robust for iOS Simulators
921         https://bugs.webkit.org/show_bug.cgi?id=164521
922
923         Reviewed by Simon Fraser.
924
925         * Scripts/webkitpy/port/ios.py:
926         (IOSSimulatorPort._createSimulatorApp): Added more robust path.
927
928 2016-11-09  Csaba Osztrogonác  <ossy@webkit.org>
929
930         Fix Tools build on case sensitive file systems
931         https://bugs.webkit.org/show_bug.cgi?id=164474
932
933         Unreviewed buildfix.
934
935         * DumpRenderTree/CMakeLists.txt:
936         * DumpRenderTree/PlatformMac.cmake:
937         * DumpRenderTree/PlatformWin.cmake:
938         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
939         * MiniBrowser/mac/CMakeLists.txt:
940
941 2016-11-04  Filip Pizlo  <fpizlo@apple.com>
942
943         WTF::ParkingLot should stop using std::chrono because std::chrono::duration casts are prone to overflows
944         https://bugs.webkit.org/show_bug.cgi?id=152045
945
946         Reviewed by Andy Estes.
947
948         * TestWebKitAPI/CMakeLists.txt:
949         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
950         * TestWebKitAPI/Tests/WTF/Condition.cpp:
951         (TestWebKitAPI::TEST):
952         * TestWebKitAPI/Tests/WTF/SynchronizedFixedQueue.cpp:
953         (TestWebKitAPI::ToUpperConverter::stopProducing):
954         (TestWebKitAPI::ToUpperConverter::stopConsuming):
955         * TestWebKitAPI/Tests/WTF/Time.cpp: Added.
956         (WTF::operator<<):
957         (TestWebKitAPI::TEST):
958
959 2016-11-04  Alex Christensen  <achristensen@webkit.org>
960
961         Unreviewed, rolling out r208293.
962
963         asserts in API tests.
964
965         Reverted changeset:
966
967         "NetworkSession: Network process crash when converting main
968         resource to download"
969         https://bugs.webkit.org/show_bug.cgi?id=164220
970         http://trac.webkit.org/changeset/208293
971
972 2016-11-04  Said Abou-Hallawa  <sabouhallawa@apple.com>
973
974         Add a setting and preferences to enable/disable async image decoding
975         https://bugs.webkit.org/show_bug.cgi?id=164417
976
977         Reviewed by Simon Fraser.
978
979         Pref and a menu item to toggle asyncImageDecodingEnabled for WebKits 1 and 2.
980
981         * MiniBrowser/mac/SettingsController.h:
982         * MiniBrowser/mac/SettingsController.m:
983         (-[SettingsController _populateMenu]):
984         (-[SettingsController validateMenuItem:]):
985         (-[SettingsController toggleAsyncImageDecodingEnabled:]):
986         (-[SettingsController asyncImageDecodingEnabled]):
987         * MiniBrowser/mac/WK1BrowserWindowController.m:
988         (-[WK1BrowserWindowController didChangeSettings]):
989         * MiniBrowser/mac/WK2BrowserWindowController.m:
990         (-[WK2BrowserWindowController didChangeSettings]):
991
992 2016-11-04  Brady Eidson  <beidson@apple.com>
993
994         REGRESSION (r208349) StringHasher::hashMemory behavior changed, causing API tests to fail
995         https://bugs.webkit.org/show_bug.cgi?id=164390
996
997         Reviewed by Geoffrey Garen.
998
999         Operating under the assumption that the behavior change is okay/desirable, this updates the test.
1000
1001         * TestWebKitAPI/Tests/WTF/StringHasher.cpp:
1002         (TestWebKitAPI::TEST):
1003
1004 2016-11-04  Joanmarie Diggs  <jdiggs@igalia.com>
1005
1006         AX: [ATK] Attempting to clear selection on ARIA listboxes results in crash
1007         https://bugs.webkit.org/show_bug.cgi?id=164331
1008
1009         Reviewed by Chris Fleizach.
1010
1011         Add AccessibilityUIElement::clearSelectedChildren() to DRT and WKTR.
1012         Implement it for ATK.
1013
1014         * DumpRenderTree/AccessibilityUIElement.h:
1015         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1016         (AccessibilityUIElement::clearSelectedChildren):
1017         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1018         (AccessibilityUIElement::clearSelectedChildren):
1019         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1020         (AccessibilityUIElement::clearSelectedChildren):
1021         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1022         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1023         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1024         (WTR::AccessibilityUIElement::clearSelectedChildren):
1025         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1026         (WTR::AccessibilityUIElement::clearSelectedChildren):
1027         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1028         (WTR::AccessibilityUIElement::clearSelectedChildren):
1029
1030 2016-11-04  Per Arne Vollan  <pvollan@apple.com>
1031
1032         [Win] Page visibility tests are timing out.
1033         https://bugs.webkit.org/show_bug.cgi?id=164363
1034
1035         Reviewed by Brent Fulgham.
1036
1037         Implement methods to set page visibility.
1038
1039         * DumpRenderTree/win/TestRunnerWin.cpp:
1040         (TestRunner::resetPageVisibility):
1041         (TestRunner::setPageVisibility):
1042
1043 2016-11-03  Simon Fraser  <simon.fraser@apple.com>
1044
1045         Give all the geometry classes a single-argument scale() function for consistency
1046         https://bugs.webkit.org/show_bug.cgi?id=164400
1047
1048         Reviewed by Zalan Bujtas.
1049         
1050         Test single-argument scale().
1051
1052         * TestWebKitAPI/Tests/WebCore/FloatPoint.cpp:
1053         (TestWebKitAPI::TEST):
1054
1055 2016-11-03  Chris Dumez  <cdumez@apple.com>
1056
1057         [WK2][Cocoa] Implement user interface for HTML form validation
1058         https://bugs.webkit.org/show_bug.cgi?id=164143
1059         <rdar://problem/28944652>
1060
1061         Reviewed by Simon Fraser.
1062
1063         Add support for UIScriptController::contentsOfUserInterfaceItem("validationBubble")
1064         on both Mac and iOS to retrieve the currently displayed validation message.
1065
1066         * DumpRenderTree/mac/UIScriptControllerMac.mm:
1067         (WTR::UIScriptController::contentsOfUserInterfaceItem):
1068         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1069         (WTR::UIScriptController::contentsOfUserInterfaceItem):
1070         (WTR::UIScriptController::selectFormAccessoryPickerRow):
1071         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1072         (WTR::UIScriptController::contentsOfUserInterfaceItem):
1073
1074 2016-11-03  Konstantin Tokarev  <annulen@yandex.ru>
1075
1076         Fixes to build JSCOnly on macOS
1077         https://bugs.webkit.org/show_bug.cgi?id=164379
1078
1079         Reviewed by Michael Catanzaro.
1080
1081         * TestWebKitAPI/PlatformJSCOnly.cmake: Moved BUILDING_JSCONLY__
1082         definition to OptionsJSCOnly.cmake
1083
1084 2016-11-03  Dan Bernstein  <mitz@apple.com>
1085
1086         WKWebView’s _observedRenderingProgressEvents not restored after web process crash
1087         https://bugs.webkit.org/show_bug.cgi?id=164368
1088         <rdar://problem/29091954>
1089
1090         Reviewed by Anders Carlsson.
1091
1092         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1093         * TestWebKitAPI/Tests/WebKit2Cocoa/ObservedRenderingProgressEventsAfterCrash.mm: Added.
1094         (TEST):
1095
1096 2016-11-03  Alex Christensen  <achristensen@webkit.org>
1097
1098         Purge PassRefPtr from Tools
1099         https://bugs.webkit.org/show_bug.cgi?id=164358
1100
1101         Reviewed by Michael Catanzaro.
1102
1103         * ImageDiff/efl/ImageDiff.cpp:
1104         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitAccessibility.cpp:
1105         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
1106         (WTR::AccessibilityController::create):
1107         (WTR::AccessibilityController::rootElement):
1108         (WTR::AccessibilityController::focusedElement):
1109         (WTR::AccessibilityController::elementAtPoint):
1110         (WTR::AccessibilityController::addNotificationListener): Deleted.
1111         (WTR::AccessibilityController::removeNotificationListener): Deleted.
1112         (WTR::AccessibilityController::accessibleElementById): Deleted.
1113         (WTR::AccessibilityController::logAccessibilityEvents): Deleted.
1114         (WTR::AccessibilityController::resetToConsistentState): Deleted.
1115         (WTR::AccessibilityController::platformName): Deleted.
1116         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
1117         (WTR::AccessibilityController::logAccessibilityEvents):
1118         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.cpp:
1119         (WTR::AccessibilityTextMarker::create):
1120         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.h:
1121         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.cpp:
1122         (WTR::AccessibilityTextMarkerRange::create):
1123         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.h:
1124         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1125         (WTR::AccessibilityUIElement::create):
1126         (WTR::AccessibilityUIElement::linkedElement):
1127         (WTR::AccessibilityUIElement::headerElementAtIndex):
1128         (WTR::AccessibilityUIElement::fieldsetAncestorElement):
1129         (WTR::AccessibilityUIElement::characterAtOffset):
1130         (WTR::AccessibilityUIElement::wordAtOffset):
1131         (WTR::AccessibilityUIElement::lineAtOffset):
1132         (WTR::AccessibilityUIElement::sentenceAtOffset):
1133         (WTR::AccessibilityUIElement::selectedTextMarkerRange):
1134         (WTR::AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker):
1135         (WTR::AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker):
1136         (WTR::AccessibilityUIElement::previousWordStartTextMarkerForTextMarker):
1137         (WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
1138         (WTR::AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker):
1139         (WTR::AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
1140         (WTR::AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker):
1141         (WTR::AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker):
1142         (WTR::AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker):
1143         (WTR::AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker):
1144         (WTR::AccessibilityUIElement::AccessibilityUIElement): Deleted.
1145         (WTR::AccessibilityUIElement::~AccessibilityUIElement): Deleted.
1146         (WTR::AccessibilityUIElement::isEqual): Deleted.
1147         (WTR::AccessibilityUIElement::elementAtPoint): Deleted.
1148         (WTR::AccessibilityUIElement::childAtIndex): Deleted.
1149         (WTR::AccessibilityUIElement::indexOfChild): Deleted.
1150         (WTR::AccessibilityUIElement::childrenCount): Deleted.
1151         (WTR::AccessibilityUIElement::titleUIElement): Deleted.
1152         (WTR::AccessibilityUIElement::parentElement): Deleted.
1153         (WTR::AccessibilityUIElement::takeFocus): Deleted.
1154         (WTR::AccessibilityUIElement::takeSelection): Deleted.
1155         (WTR::AccessibilityUIElement::addSelection): Deleted.
1156         (WTR::AccessibilityUIElement::removeSelection): Deleted.
1157         (WTR::AccessibilityUIElement::allAttributes): Deleted.
1158         (WTR::AccessibilityUIElement::attributesOfLinkedUIElements): Deleted.
1159         (WTR::AccessibilityUIElement::linkedUIElementAtIndex): Deleted.
1160         (WTR::AccessibilityUIElement::attributesOfDocumentLinks): Deleted.
1161         (WTR::AccessibilityUIElement::attributesOfChildren): Deleted.
1162         (WTR::AccessibilityUIElement::parameterizedAttributeNames): Deleted.
1163         (WTR::AccessibilityUIElement::increment): Deleted.
1164         (WTR::AccessibilityUIElement::decrement): Deleted.
1165         (WTR::AccessibilityUIElement::showMenu): Deleted.
1166         (WTR::AccessibilityUIElement::press): Deleted.
1167         (WTR::AccessibilityUIElement::stringAttributeValue): Deleted.
1168         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue): Deleted.
1169         (WTR::AccessibilityUIElement::uiElementAttributeValue): Deleted.
1170         (WTR::AccessibilityUIElement::numberAttributeValue): Deleted.
1171         (WTR::AccessibilityUIElement::boolAttributeValue): Deleted.
1172         (WTR::AccessibilityUIElement::isAttributeSupported): Deleted.
1173         (WTR::AccessibilityUIElement::isAttributeSettable): Deleted.
1174         (WTR::AccessibilityUIElement::isPressActionSupported): Deleted.
1175         (WTR::AccessibilityUIElement::isIncrementActionSupported): Deleted.
1176         (WTR::AccessibilityUIElement::isDecrementActionSupported): Deleted.
1177         (WTR::AccessibilityUIElement::role): Deleted.
1178         (WTR::AccessibilityUIElement::subrole): Deleted.
1179         (WTR::AccessibilityUIElement::roleDescription): Deleted.
1180         (WTR::AccessibilityUIElement::computedRoleString): Deleted.
1181         (WTR::AccessibilityUIElement::title): Deleted.
1182         (WTR::AccessibilityUIElement::description): Deleted.
1183         (WTR::AccessibilityUIElement::language): Deleted.
1184         (WTR::AccessibilityUIElement::stringValue): Deleted.
1185         (WTR::AccessibilityUIElement::accessibilityValue): Deleted.
1186         (WTR::AccessibilityUIElement::helpText): Deleted.
1187         (WTR::AccessibilityUIElement::orientation): Deleted.
1188         (WTR::AccessibilityUIElement::x): Deleted.
1189         (WTR::AccessibilityUIElement::y): Deleted.
1190         (WTR::AccessibilityUIElement::width): Deleted.
1191         (WTR::AccessibilityUIElement::height): Deleted.
1192         (WTR::AccessibilityUIElement::intValue): Deleted.
1193         (WTR::AccessibilityUIElement::minValue): Deleted.
1194         (WTR::AccessibilityUIElement::maxValue): Deleted.
1195         (WTR::AccessibilityUIElement::valueDescription): Deleted.
1196         (WTR::AccessibilityUIElement::insertionPointLineNumber): Deleted.
1197         (WTR::AccessibilityUIElement::selectedTextRange): Deleted.
1198         (WTR::AccessibilityUIElement::isEnabled): Deleted.
1199         (WTR::AccessibilityUIElement::isRequired): Deleted.
1200         (WTR::AccessibilityUIElement::isFocused): Deleted.
1201         (WTR::AccessibilityUIElement::isFocusable): Deleted.
1202         (WTR::AccessibilityUIElement::isSelected): Deleted.
1203         (WTR::AccessibilityUIElement::isSelectedOptionActive): Deleted.
1204         (WTR::AccessibilityUIElement::isSelectable): Deleted.
1205         (WTR::AccessibilityUIElement::isMultiSelectable): Deleted.
1206         (WTR::AccessibilityUIElement::setSelectedChild): Deleted.
1207         (WTR::AccessibilityUIElement::setSelectedChildAtIndex): Deleted.
1208         (WTR::AccessibilityUIElement::removeSelectionAtIndex): Deleted.
1209         (WTR::AccessibilityUIElement::selectedChildrenCount): Deleted.
1210         (WTR::AccessibilityUIElement::selectedChildAtIndex): Deleted.
1211         (WTR::AccessibilityUIElement::isExpanded): Deleted.
1212         (WTR::AccessibilityUIElement::isChecked): Deleted.
1213         (WTR::AccessibilityUIElement::isIndeterminate): Deleted.
1214         (WTR::AccessibilityUIElement::isVisible): Deleted.
1215         (WTR::AccessibilityUIElement::isOffScreen): Deleted.
1216         (WTR::AccessibilityUIElement::isCollapsed): Deleted.
1217         (WTR::AccessibilityUIElement::isIgnored): Deleted.
1218         (WTR::AccessibilityUIElement::hasPopup): Deleted.
1219         (WTR::AccessibilityUIElement::hierarchicalLevel): Deleted.
1220         (WTR::AccessibilityUIElement::clickPointX): Deleted.
1221         (WTR::AccessibilityUIElement::clickPointY): Deleted.
1222         (WTR::AccessibilityUIElement::documentEncoding): Deleted.
1223         (WTR::AccessibilityUIElement::documentURI): Deleted.
1224         (WTR::AccessibilityUIElement::url): Deleted.
1225         (WTR::AccessibilityUIElement::speak): Deleted.
1226         (WTR::AccessibilityUIElement::attributesOfColumnHeaders): Deleted.
1227         (WTR::AccessibilityUIElement::attributesOfRowHeaders): Deleted.
1228         (WTR::AccessibilityUIElement::attributesOfColumns): Deleted.
1229         (WTR::AccessibilityUIElement::attributesOfRows): Deleted.
1230         (WTR::AccessibilityUIElement::attributesOfVisibleCells): Deleted.
1231         (WTR::AccessibilityUIElement::attributesOfHeader): Deleted.
1232         (WTR::AccessibilityUIElement::indexInTable): Deleted.
1233         (WTR::AccessibilityUIElement::rowIndexRange): Deleted.
1234         (WTR::AccessibilityUIElement::columnIndexRange): Deleted.
1235         (WTR::AccessibilityUIElement::rowCount): Deleted.
1236         (WTR::AccessibilityUIElement::columnCount): Deleted.
1237         (WTR::AccessibilityUIElement::rowHeaders): Deleted.
1238         (WTR::AccessibilityUIElement::columnHeaders): Deleted.
1239         (WTR::AccessibilityUIElement::selectedRowAtIndex): Deleted.
1240         (WTR::AccessibilityUIElement::disclosedByRow): Deleted.
1241         (WTR::AccessibilityUIElement::disclosedRowAtIndex): Deleted.
1242         (WTR::AccessibilityUIElement::rowAtIndex): Deleted.
1243         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex): Deleted.
1244         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex): Deleted.
1245         (WTR::AccessibilityUIElement::ariaControlsElementAtIndex): Deleted.
1246         (WTR::AccessibilityUIElement::ariaIsGrabbed): Deleted.
1247         (WTR::AccessibilityUIElement::ariaDropEffects): Deleted.
1248         (WTR::AccessibilityUIElement::classList): Deleted.
1249         (WTR::AccessibilityUIElement::lineForIndex): Deleted.
1250         (WTR::AccessibilityUIElement::rangeForLine): Deleted.
1251         (WTR::AccessibilityUIElement::rangeForPosition): Deleted.
1252         (WTR::AccessibilityUIElement::boundsForRange): Deleted.
1253         (WTR::AccessibilityUIElement::setSelectedTextRange): Deleted.
1254         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange): Deleted.
1255         (WTR::AccessibilityUIElement::stringForRange): Deleted.
1256         (WTR::AccessibilityUIElement::attributedStringForRange): Deleted.
1257         (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled): Deleted.
1258         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate): Deleted.
1259         (WTR::AccessibilityUIElement::uiElementForSearchPredicate): Deleted.
1260         (WTR::AccessibilityUIElement::selectTextWithCriteria): Deleted.
1261         (WTR::AccessibilityUIElement::cellForColumnAndRow): Deleted.
1262         (WTR::AccessibilityUIElement::horizontalScrollbar): Deleted.
1263         (WTR::AccessibilityUIElement::verticalScrollbar): Deleted.
1264         (WTR::AccessibilityUIElement::addNotificationListener): Deleted.
1265         (WTR::AccessibilityUIElement::removeNotificationListener): Deleted.
1266         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker): Deleted.
1267         (WTR::AccessibilityUIElement::textMarkerRangeForElement): Deleted.
1268         (WTR::AccessibilityUIElement::textMarkerRangeLength): Deleted.
1269         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers): Deleted.
1270         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange): Deleted.
1271         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange): Deleted.
1272         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker): Deleted.
1273         (WTR::AccessibilityUIElement::endTextMarkerForBounds): Deleted.
1274         (WTR::AccessibilityUIElement::startTextMarkerForBounds): Deleted.
1275         (WTR::AccessibilityUIElement::textMarkerForPoint): Deleted.
1276         (WTR::AccessibilityUIElement::previousTextMarker): Deleted.
1277         (WTR::AccessibilityUIElement::nextTextMarker): Deleted.
1278         (WTR::AccessibilityUIElement::startTextMarker): Deleted.
1279         (WTR::AccessibilityUIElement::endTextMarker): Deleted.
1280         (WTR::AccessibilityUIElement::stringForTextMarkerRange): Deleted.
1281         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute): Deleted.
1282         (WTR::AccessibilityUIElement::indexForTextMarker): Deleted.
1283         (WTR::AccessibilityUIElement::isTextMarkerValid): Deleted.
1284         (WTR::AccessibilityUIElement::textMarkerForIndex): Deleted.
1285         (WTR::AccessibilityUIElement::scrollToMakeVisible): Deleted.
1286         (WTR::AccessibilityUIElement::scrollToGlobalPoint): Deleted.
1287         (WTR::AccessibilityUIElement::scrollToMakeVisibleWithSubFocus): Deleted.
1288         (WTR::AccessibilityUIElement::supportedActions): Deleted.
1289         (WTR::AccessibilityUIElement::mathPostscriptsDescription): Deleted.
1290         (WTR::AccessibilityUIElement::mathPrescriptsDescription): Deleted.
1291         (WTR::AccessibilityUIElement::pathDescription): Deleted.
1292         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1293         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1294         (WTR::EventSendingController::create):
1295         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
1296         * WebKitTestRunner/InjectedBundle/GCController.cpp:
1297         (WTR::GCController::create):
1298         * WebKitTestRunner/InjectedBundle/GCController.h:
1299         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1300         (WTR::InjectedBundle::beginTesting):
1301         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1302         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1303         (WTR::TestRunner::create):
1304         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1305         * WebKitTestRunner/InjectedBundle/TextInputController.cpp:
1306         (WTR::TextInputController::create):
1307         * WebKitTestRunner/InjectedBundle/TextInputController.h:
1308         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
1309         (WTR::AccessibilityController::accessibleElementById):
1310         (WTR::AccessibilityController::rootElement):
1311         (WTR::AccessibilityController::focusedElement):
1312         (WTR::AccessibilityController::logAccessibilityEvents): Deleted.
1313         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.h:
1314         (WTR::AccessibilityNotificationHandler::create):
1315         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1316         (WTR::AccessibilityUIElement::elementAtPoint):
1317         (WTR::AccessibilityUIElement::childAtIndex):
1318         (WTR::accessibilityElementAtIndex):
1319         (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
1320         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
1321         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
1322         (WTR::AccessibilityUIElement::ariaControlsElementAtIndex):
1323         (WTR::AccessibilityUIElement::disclosedRowAtIndex):
1324         (WTR::AccessibilityUIElement::rowAtIndex):
1325         (WTR::AccessibilityUIElement::selectedChildAtIndex):
1326         (WTR::AccessibilityUIElement::selectedRowAtIndex):
1327         (WTR::AccessibilityUIElement::titleUIElement):
1328         (WTR::AccessibilityUIElement::parentElement):
1329         (WTR::AccessibilityUIElement::disclosedByRow):
1330         (WTR::AccessibilityUIElement::uiElementAttributeValue):
1331         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1332         (WTR::AccessibilityUIElement::cellForColumnAndRow):
1333         (WTR::AccessibilityUIElement::horizontalScrollbar):
1334         (WTR::AccessibilityUIElement::verticalScrollbar):
1335         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
1336         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
1337         (WTR::AccessibilityUIElement::previousTextMarker):
1338         (WTR::AccessibilityUIElement::nextTextMarker):
1339         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
1340         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
1341         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
1342         (WTR::AccessibilityUIElement::endTextMarkerForBounds):
1343         (WTR::AccessibilityUIElement::startTextMarkerForBounds):
1344         (WTR::AccessibilityUIElement::textMarkerForPoint):
1345         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
1346         (WTR::AccessibilityUIElement::textMarkerForIndex):
1347         (WTR::AccessibilityUIElement::startTextMarker):
1348         (WTR::AccessibilityUIElement::endTextMarker):
1349         * WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm:
1350         (WTR::AccessibilityController::accessibleElementById):
1351         (WTR::AccessibilityController::logAccessibilityEvents): Deleted.
1352         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1353         (WTR::AccessibilityUIElement::headerElementAtIndex):
1354         (WTR::AccessibilityUIElement::linkedElement):
1355         (WTR::AccessibilityUIElement::elementAtPoint):
1356         (WTR::AccessibilityUIElement::childAtIndex):
1357         (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
1358         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
1359         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
1360         (WTR::AccessibilityUIElement::ariaControlsElementAtIndex):
1361         (WTR::AccessibilityUIElement::disclosedRowAtIndex):
1362         (WTR::AccessibilityUIElement::rowAtIndex):
1363         (WTR::AccessibilityUIElement::selectedChildAtIndex):
1364         (WTR::AccessibilityUIElement::selectedRowAtIndex):
1365         (WTR::AccessibilityUIElement::titleUIElement):
1366         (WTR::AccessibilityUIElement::parentElement):
1367         (WTR::AccessibilityUIElement::disclosedByRow):
1368         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue):
1369         (WTR::AccessibilityUIElement::uiElementAttributeValue):
1370         (WTR::AccessibilityUIElement::rangeForLine):
1371         (WTR::AccessibilityUIElement::rangeForPosition):
1372         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1373         (WTR::AccessibilityUIElement::fieldsetAncestorElement):
1374         (WTR::AccessibilityUIElement::cellForColumnAndRow):
1375         (WTR::AccessibilityUIElement::horizontalScrollbar):
1376         (WTR::AccessibilityUIElement::verticalScrollbar):
1377         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
1378         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
1379         (WTR::AccessibilityUIElement::previousTextMarker):
1380         (WTR::AccessibilityUIElement::nextTextMarker):
1381         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
1382         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
1383         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
1384         (WTR::AccessibilityUIElement::endTextMarkerForBounds):
1385         (WTR::AccessibilityUIElement::startTextMarkerForBounds):
1386         (WTR::AccessibilityUIElement::textMarkerForPoint):
1387         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
1388         (WTR::AccessibilityUIElement::textMarkerForIndex):
1389         (WTR::AccessibilityUIElement::startTextMarker):
1390         (WTR::AccessibilityUIElement::endTextMarker):
1391         (WTR::AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker):
1392         (WTR::AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker):
1393         (WTR::AccessibilityUIElement::previousWordStartTextMarkerForTextMarker):
1394         (WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
1395         (WTR::AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker):
1396         (WTR::AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
1397         (WTR::AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker):
1398         (WTR::AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker):
1399         (WTR::AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker):
1400         (WTR::AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker):
1401         (WTR::AccessibilityUIElement::mathPostscriptsDescription):
1402         (WTR::AccessibilityUIElement::mathPrescriptsDescription):
1403         (WTR::AccessibilityUIElement::supportedActions):
1404         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
1405         (WTR::AccessibilityController::accessibleElementById):
1406         (WTR::AccessibilityController::logAccessibilityEvents): Deleted.
1407         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
1408         (makeValueRefForValue):
1409         (-[AccessibilityNotificationHandler _notificationReceived:]):
1410         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1411         (WTR::AccessibilityUIElement::elementAtPoint):
1412         (WTR::AccessibilityUIElement::childAtIndex):
1413         (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
1414         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
1415         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
1416         (WTR::AccessibilityUIElement::ariaControlsElementAtIndex):
1417         (WTR::AccessibilityUIElement::disclosedRowAtIndex):
1418         (WTR::AccessibilityUIElement::rowAtIndex):
1419         (WTR::AccessibilityUIElement::selectedChildAtIndex):
1420         (WTR::AccessibilityUIElement::selectedRowAtIndex):
1421         (WTR::AccessibilityUIElement::titleUIElement):
1422         (WTR::AccessibilityUIElement::parentElement):
1423         (WTR::AccessibilityUIElement::disclosedByRow):
1424         (WTR::AccessibilityUIElement::uiElementAttributeValue):
1425         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1426         (WTR::AccessibilityUIElement::cellForColumnAndRow):
1427         (WTR::AccessibilityUIElement::horizontalScrollbar):
1428         (WTR::AccessibilityUIElement::verticalScrollbar):
1429         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
1430         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
1431         (WTR::AccessibilityUIElement::previousTextMarker):
1432         (WTR::AccessibilityUIElement::nextTextMarker):
1433         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
1434         (WTR::AccessibilityUIElement::selectedTextMarkerRange):
1435         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
1436         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
1437         (WTR::AccessibilityUIElement::endTextMarkerForBounds):
1438         (WTR::AccessibilityUIElement::startTextMarkerForBounds):
1439         (WTR::AccessibilityUIElement::textMarkerForPoint):
1440         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
1441         (WTR::AccessibilityUIElement::textMarkerForIndex):
1442         (WTR::AccessibilityUIElement::startTextMarker):
1443         (WTR::AccessibilityUIElement::endTextMarker):
1444         (WTR::AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker):
1445         (WTR::AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker):
1446         (WTR::AccessibilityUIElement::previousWordStartTextMarkerForTextMarker):
1447         (WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
1448         (WTR::AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker):
1449         (WTR::AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker):
1450         (WTR::AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
1451         (WTR::AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker):
1452         (WTR::AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker):
1453         (WTR::AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker):
1454         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
1455         (WTR::keyPadName):
1456         (WTR::keyName):
1457
1458 2016-11-02  Alex Christensen  <achristensen@webkit.org>
1459
1460         Remove Battery Status API from the tree
1461         https://bugs.webkit.org/show_bug.cgi?id=164213
1462
1463         Reviewed by Sam Weinig.
1464
1465         * Scripts/webkitperl/FeatureList.pm:
1466         * Scripts/webkitpy/common/config/watchlist:
1467
1468 2016-11-02  Olivier Blin  <olivier.blin@softathome.com>
1469
1470         [GTK] Use libgcrypt instead of GnuTLS for CryptoDigest and SubtleCrypto HMAC implementation
1471         https://bugs.webkit.org/show_bug.cgi?id=163125
1472
1473         Reviewed by Michael Catanzaro.
1474
1475         * gtk/install-dependencies: List libgcrypt for WebKitGTK+ build, and gnutls for jhbuild only.
1476         gnutls is useful for glib-networking in jhbuild.
1477
1478 2016-11-02  Carlos Garcia Campos  <cgarcia@igalia.com>
1479
1480         NetworkSession: Network process crash when converting main resource to download
1481         https://bugs.webkit.org/show_bug.cgi?id=164220
1482
1483         Reviewed by Alex Christensen.
1484
1485         Split /webkit2/Downloads/policy-decision-download in two, one to test the full load when main resource is
1486         converted to a download and another one to test the cancellation as the test was doing before. When doing the
1487         full load, delay a bit the decide destination to ensure the load is aborted before the data task has became a
1488         download.
1489
1490         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
1491         (testPolicyResponseDownload):
1492         (testPolicyResponseDownloadCancel):
1493         (beforeAll):
1494
1495 2016-11-01  Alex Christensen  <achristensen@webkit.org>
1496
1497         Remove PassRefPtr from DumpRenderTree
1498         https://bugs.webkit.org/show_bug.cgi?id=164307
1499
1500         Reviewed by Sam Weinig.
1501
1502         * DumpRenderTree/PixelDumpSupport.h:
1503         * DumpRenderTree/TestRunner.cpp:
1504         (TestRunner::create):
1505         * DumpRenderTree/TestRunner.h:
1506         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1507         (createBitmapContext):
1508         * DumpRenderTree/cg/PixelDumpSupportCG.h:
1509         (BitmapContext::createByAdoptingBitmapAndContext):
1510         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
1511         (createBitmapContextFromWebView):
1512         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1513         (createBitmapContextFromWebView):
1514         (createPagedBitmapContext):
1515         * DumpRenderTree/mac/TestRunnerMac.mm:
1516         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
1517         (createBitmapContextFromWebView):
1518         * DumpRenderTree/win/TextInputController.h:
1519
1520 2016-11-02  Carlos Garcia Campos  <cgarcia@igalia.com>
1521
1522         [GTK] Use GTestDBus instead of dbus-launch in WebKitTestBus.cpp
1523         https://bugs.webkit.org/show_bug.cgi?id=161481
1524
1525         Reviewed by Michael Catanzaro.
1526
1527         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.cpp:
1528         (WebKitTestBus::WebKitTestBus):
1529         (WebKitTestBus::~WebKitTestBus):
1530         (WebKitTestBus::run):
1531         (WebKitTestBus::getOrCreateConnection):
1532         (WebKitTestBus::createProxy):
1533         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.h:
1534
1535 2016-11-02  Carlos Garcia Campos  <cgarcia@igalia.com>
1536
1537         Unreviewed. Fix /webkit2/WebKitWebContext/get-plugins in the bots after r208273.
1538
1539         The test fails now if WEBKIT_TEST_PLUGIN_DIR contains symlinks, which is the case of the GTK+ bots.
1540
1541         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1542         (testWebContextGetPlugins): Use realpath with WEBKIT_TEST_PLUGIN_DIR when building the expected plugins path.
1543
1544 2016-11-02  Romain Bellessort  <romain.bellessort@crf.canon.fr>
1545
1546         [Readable Streams API] Enable creation of ReadableByteStreamController
1547         https://bugs.webkit.org/show_bug.cgi?id=164014
1548
1549         Reviewed by Youenn Fablet.
1550
1551         Enable the byte stream part of Readable Streams API by default.
1552
1553         * Scripts/webkitperl/FeatureList.pm:
1554         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1555
1556 2016-11-01  Ryosuke Niwa  <rniwa@webkit.org>
1557
1558         Remove CUSTOM_ELEMENTS build flag
1559         https://bugs.webkit.org/show_bug.cgi?id=164267
1560
1561         Reviewed by Antti Koivisto.
1562
1563         Removed the build flag.
1564
1565         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1566
1567 2016-11-01  Alex Christensen  <achristensen@webkit.org>
1568
1569         Percent-encode non-ASCII code points in hosts of URLs with unrecognized schemes
1570         https://bugs.webkit.org/show_bug.cgi?id=164290
1571
1572         Reviewed by Tim Horton.
1573
1574         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1575         (TestWebKitAPI::checkRelativeURL):
1576         (TestWebKitAPI::checkURLDifferences):
1577         (TestWebKitAPI::checkRelativeURLDifferences):
1578         Move helper functions to the top so I can use them from any tests.
1579         (TestWebKitAPI::shouldFail):
1580         (TestWebKitAPI::checkURL):
1581         (TestWebKitAPI::TEST_F):
1582
1583 2016-11-01  Hyowon Kim  <hw1008.kim@samsung.com>
1584
1585         [GTK] Failed to generate GeoClue2Interface files.
1586         https://bugs.webkit.org/show_bug.cgi?id=164270
1587
1588         Reviewed by Michael Catanzaro.
1589
1590         To generate codes for D-Bus interfaces,
1591         geoclue-2.0 package including D-Bus introspection XML files should be installed.
1592
1593         * gtk/install-dependencies: add geoclue-2.0 package.
1594
1595 2016-11-01  Fujii Hironori  <Hironori.Fujii@sony.com>
1596
1597         [CMake] generate-bindings-all.pl uses USES_TERMINAL which leaves a noisy line in interactive Ninja build
1598         https://bugs.webkit.org/show_bug.cgi?id=163868
1599
1600         Reviewed by Michael Catanzaro.
1601
1602         It takes long time for generate-bindings-all.pl to generate all
1603         bindings.  So, it shows the progress while running and
1604         USES_TERMINAL option of add_custom_target have been used to invoke
1605         the command.  However, USES_TERMINAL leaves a noisy line in
1606         Ninja's neat build log of interactive build.
1607
1608         A new CMake option SHOW_BINDINGS_GENERATION_PROGRESS is added to
1609         stop using USES_TERMINAL only in case of interactive Ninja build.
1610
1611         * Scripts/webkitdirs.pm:
1612         (generateBuildSystemFromCMakeProject): Enable
1613         SHOW_BINDINGS_GENERATION_PROGRESS not in case of interactive
1614         Ninja build.
1615
1616 2016-10-31  Simon Fraser  <simon.fraser@apple.com>
1617
1618         Add basic visual/layout viewport support for fixed position layout
1619         https://bugs.webkit.org/show_bug.cgi?id=164261
1620
1621         Reviewed by Dean Jackson.
1622
1623         Don't give tests in the "visual-viewport" directory a flexible viewport.
1624
1625         * DumpRenderTree/mac/DumpRenderTree.mm:
1626         (shouldMakeViewportFlexible):
1627         * WebKitTestRunner/TestOptions.cpp:
1628         (WTR::shouldMakeViewportFlexible):
1629
1630 2016-10-29  Filip Pizlo  <fpizlo@apple.com>
1631
1632         JSC should support SharedArrayBuffer
1633         https://bugs.webkit.org/show_bug.cgi?id=163986
1634
1635         Reviewed by Keith Miller.
1636         
1637         Use the right kind of typed array API.
1638
1639         * DumpRenderTree/TestRunner.cpp:
1640         (setAudioResultCallback):
1641
1642 2016-10-31  Simon Fraser  <simon.fraser@apple.com>
1643
1644         Make UIScriptController::zoomToScale() work on Mac WK1 and WK2
1645         https://bugs.webkit.org/show_bug.cgi?id=164238
1646
1647         Reviewed by Dean Jackson.
1648
1649         Implement UIScriptController::zoomToScale() for WTR and DRT on Mac.
1650
1651         * DumpRenderTree/mac/UIScriptControllerMac.mm:
1652         (WTR::UIScriptController::zoomToScale):
1653         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1654         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1655         (WTR::UIScriptController::zoomToScale):
1656
1657 2016-10-31  Dewei Zhu  <dewei_zhu@apple.com>
1658
1659         Update twisted version in webkitpy.thirdparty.autoinstalled module.
1660         https://bugs.webkit.org/show_bug.cgi?id=154667
1661
1662         Reviewed by Ryosuke Niwa.
1663
1664         Use twisted_15_5_0 for the twisted module used by run-benchmark because there is a bug in twisted 12.1.0 which sometimes stops the test.
1665         Installing twisted was introduced in https://bugs.webkit.org/show_bug.cgi?id=147082 for run-benchmark script.
1666         Since buildbot relies on twisted 12.1.0 and has not been verified the compatibility on twisted 15.5.0, it would be more secure to use an individual version for run-benchmark script.
1667
1668         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
1669         * Scripts/webkitpy/thirdparty/__init__.py:
1670         (AutoinstallImportHook.find_module):
1671         (AutoinstallImportHook._install_twisted_15_5_0):
1672         (AutoinstallImportHook._install_twisted): Deleted.
1673
1674 2016-10-31  Ryosuke Niwa  <rniwa@webkit.org>
1675
1676         Enable custom elements by default everywhere
1677         https://bugs.webkit.org/show_bug.cgi?id=164242
1678
1679         Reviewed by Antti Koivisto.
1680
1681         Enable custom elements API on every port by default.
1682
1683         * Scripts/webkitperl/FeatureList.pm:
1684
1685 2016-10-31  Nan Wang  <n_wang@apple.com>
1686
1687         AX: aria-sort is not exposed on iOS
1688         https://bugs.webkit.org/show_bug.cgi?id=164245
1689
1690         Reviewed by Chris Fleizach.
1691
1692         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1693         (AccessibilityUIElement::stringAttributeValue):
1694         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1695         (WTR::AccessibilityUIElement::stringAttributeValue):
1696
1697 2016-10-31  Simon Fraser  <simon.fraser@apple.com>
1698
1699         Implement IntersectionObserver
1700         https://bugs.webkit.org/show_bug.cgi?id=159475
1701
1702         Reviewed by Ryosuke Niwa.
1703         
1704         Add ENABLE_INTERSECTION_OBSERVER, enabled by default.
1705
1706         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1707
1708 2016-10-31  Ryan Haddad  <ryanhaddad@apple.com>
1709
1710         Unreviewed, rolling out r208154.
1711
1712         This change caused an assertion failure during API tests on
1713         macOS.
1714
1715         Reverted changeset:
1716
1717         "NetworkSession: Network process crash when converting main
1718         resource to download"
1719         https://bugs.webkit.org/show_bug.cgi?id=164220
1720         http://trac.webkit.org/changeset/208154
1721
1722 2016-10-31  Said Abou-Hallawa  <sabouhallawa@apple.com>
1723
1724         Unreviewed, change my status to be a WebKit reviewer
1725
1726         * Scripts/webkitpy/common/config/contributors.json:
1727
1728 2016-10-31  Carlos Garcia Campos  <cgarcia@igalia.com>
1729
1730         NetworkSession: Network process crash when converting main resource to download
1731         https://bugs.webkit.org/show_bug.cgi?id=164220
1732
1733         Reviewed by Alex Christensen.
1734
1735         Split /webkit2/Downloads/policy-decision-download in two, one to test the full load when main resource is
1736         converted to a download and another one to test the cancellation as the test was doing before. When doing the
1737         full load, delay a bit the decide destination to ensure the load is aborted before the data task has became a
1738         download.
1739
1740         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
1741         (testPolicyResponseDownload):
1742         (testPolicyResponseDownloadCancel):
1743         (beforeAll):
1744
1745 2016-10-31  Keith Miller  <keith_miller@apple.com>
1746
1747         Unreviewed, fix watchlist regexp for wasm.
1748
1749         * Scripts/webkitpy/common/config/watchlist:
1750
1751 2016-10-31  Keith Miller  <keith_miller@apple.com>
1752
1753         autogenerated files from wasm.json should be in derived sources.
1754         https://bugs.webkit.org/show_bug.cgi?id=164152
1755
1756         Reviewed by Filip Pizlo.
1757
1758         Add message to make sure that people keep the wasm.jsons up to date.
1759
1760         * Scripts/webkitpy/common/config/watchlist:
1761
1762 2016-10-31  Wenson Hsieh  <wenson_hsieh@apple.com>
1763
1764         Holding down a key to choose an accented character should fire "insertReplacementText" input events
1765         https://bugs.webkit.org/show_bug.cgi?id=164209
1766         <rdar://problem/29019305>
1767
1768         Reviewed by Darin Adler.
1769
1770         Adds test support for inserting replacement text on Mac. This is equivalent to holding down a vowel key (e.g.
1771         'a') to bring up the menu containing accented version of the character, then selecting an accented character to
1772         insert in place of the typed character. This is exposed via UIScriptController.insertText, which takes a string
1773         and an insertion range.
1774
1775         * DumpRenderTree/mac/UIScriptControllerMac.mm:
1776         (WTR::UIScriptController::insertText):
1777         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1778
1779         Note that there is no callback argument to insertText, since UIScriptController::insertText is synchronous in
1780         the UI process. The tests end when corresponding input events fired as a result of insertText have been received
1781         in the web process. Please see the new layout tests for more detail.
1782
1783         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1784         (WTR::UIScriptController::insertText):
1785         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1786         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1787         (WTR::nsStringFromJSString):
1788         (WTR::UIScriptController::insertText):
1789
1790 2016-10-30  Sam Weinig  <sam@webkit.org>
1791
1792         [WebIDL] Restructure IDLParser structs to better match modern WebIDL concepts
1793         https://bugs.webkit.org/show_bug.cgi?id=164208
1794
1795         Reviewed by Darin Adler.
1796
1797         * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm:
1798         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
1799         Update for new struct types.
1800
1801 2016-10-29  Darin Adler  <darin@apple.com>
1802
1803         Fix failing ExtendedColor tests.
1804
1805         * TestWebKitAPI/Tests/WebCore/ExtendedColor.cpp:
1806         Changed the tests in two ways: First, use EXPECT_EQ instead of EXPECT_TRUE
1807         for the string equality comparisons. This required including WTFStringUtilities.h.
1808         Second, change expected results to match what the code is currently generating,
1809         so alpha channels are "0.25" rather than "0.25 / 1". I'll let Dean fix both these
1810         tests and the code if these results are incorrect.
1811
1812 2016-10-29  Wenson Hsieh  <wenson_hsieh@apple.com>
1813
1814         UIScriptControllerIOS.mm should not be soft-linking UIKit
1815         https://bugs.webkit.org/show_bug.cgi?id=164171
1816
1817         Reviewed by Darin Adler.
1818
1819         Follow-up to r208090. Instead of soft-linking, we can simply grab UIKeyboardPredictionView by name instead.
1820
1821         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1822         (WTR::UIScriptController::waitForTextPredictionsViewAndSelectCandidateAtIndex):
1823
1824 2016-10-28  Darin Adler  <darin@apple.com>
1825
1826         Move all classes in the HTML directory from ExceptionCode to Exception
1827         https://bugs.webkit.org/show_bug.cgi?id=163876
1828
1829         Reviewed by Sam Weinig.
1830
1831         * TestWebKitAPI/Tests/WebCore/TimeRanges.cpp:
1832         (TestWebKitAPI::ToString): Updated for changes to the TimeRanges class.
1833         (TestWebKitAPI::TEST): Ditto.
1834
1835 2016-10-28  Devin Rousso  <dcrousso+webkit@gmail.com>
1836
1837         Unreviewed, changed Devin Rousso's email and nick.
1838
1839         * Scripts/webkitpy/common/config/contributors.json:
1840
1841 2016-10-28  Wenson Hsieh  <wenson_hsieh@apple.com>
1842
1843         Unreviewed, fix the iOS build after r208090.
1844
1845         Use soft-linking as needed in UIScriptControllerIOS.mm.
1846
1847         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1848         (WTR::UIScriptController::waitForTextPredictionsViewAndSelectCandidateAtIndex):
1849
1850 2016-10-28  Wenson Hsieh  <wenson_hsieh@apple.com>
1851
1852         iOS autocorrection does not trigger an input event of inputType "insertReplacementText"
1853         https://bugs.webkit.org/show_bug.cgi?id=164077
1854         <rdar://problem/28987810>
1855
1856         Reviewed by Simon Fraser.
1857
1858         Adds test support for inserting text candidates on iOS in the form of
1859         UIScriptController.selectTextCandidateAtIndex(index, callback), which selects the text candidate at a given
1860         index (this needs to be a value between 0-2 on iOS) and fires the callback when done.
1861
1862         To implement this, we wait for the text prediction view to have predictions (we determine this by polling at a
1863         given interval) and then tap the center of the text prediction view at the given index.
1864
1865         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1866         (WTR::UIScriptController::selectTextCandidateAtIndex):
1867         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1868         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1869         (WTR::UIScriptController::selectTextCandidateAtIndex):
1870         (WTR::UIScriptController::waitForTextPredictionsViewAndSelectCandidateAtIndex):
1871         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1872         * WebKitTestRunner/ios/UIKitSPI.h:
1873         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1874         (WTR::UIScriptController::selectTextCandidateAtIndex):
1875         (WTR::UIScriptController::waitForTextPredictionsViewAndSelectCandidateAtIndex):
1876
1877 2016-10-28  Commit Queue  <commit-queue@webkit.org>
1878
1879         Unreviewed, rolling out r207700.
1880         https://bugs.webkit.org/show_bug.cgi?id=164168
1881
1882         We are ready after r208086 (Requested by alexchristensen on
1883         #webkit).
1884
1885         Reverted changeset:
1886
1887         "Unreviewed, rolling out r207582."
1888         https://bugs.webkit.org/show_bug.cgi?id=163819
1889         http://trac.webkit.org/changeset/207700
1890
1891 2016-10-28  Alex Christensen  <achristensen@webkit.org>
1892
1893         Partially revert 207805 after resolution in URL spec issue 87
1894         https://bugs.webkit.org/show_bug.cgi?id=164142
1895
1896         Reviewed by Andy Estes.
1897
1898         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1899         (TestWebKitAPI::TEST_F):
1900
1901 2016-10-28  Alex Christensen  <achristensen@webkit.org>
1902
1903         URLParser should not try to interpret host of URLs with unrecognized schemes as IPv4 address
1904         https://bugs.webkit.org/show_bug.cgi?id=164154
1905
1906         Reviewed by Andy Estes.
1907
1908         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1909         (TestWebKitAPI::TEST_F):
1910
1911 2016-10-28  Sam Weinig  <sam@webkit.org>
1912
1913         [WebIDL] Update parser and code generators to only access type information through the type property
1914         https://bugs.webkit.org/show_bug.cgi?id=164141
1915
1916         Reviewed by Anders Carlsson.
1917
1918         * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm:
1919         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
1920         Update to always access type information through type accessors. Remove use of removed
1921         properties.
1922
1923 2016-10-28  Frederic Wang  <fwang@igalia.com>
1924
1925         [GTK] Upgrade HarfBuzz to version 1.3.3
1926         https://bugs.webkit.org/show_bug.cgi?id=162719
1927
1928         Reviewed by Michael Catanzaro.
1929
1930         * gtk/jhbuild.modules:
1931
1932 2016-10-27  Chris Dumez  <cdumez@apple.com>
1933
1934         Regression(r203601): Caused crashes in iBooks
1935         https://bugs.webkit.org/show_bug.cgi?id=164093
1936         <rdar://problem/28745634>
1937
1938         Reviewed by Darin Adler.
1939
1940         Add API test coverage.
1941
1942         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1943         * TestWebKitAPI/Tests/mac/DOMNode.mm: Added.
1944         (-[DOMNodeTest webView:didFinishLoadForFrame:]):
1945         (TestWebKitAPI::TEST):
1946
1947 2016-10-27  Sam Weinig  <sam@webkit.org>
1948
1949         [WebIDL] Move code generators off of domSignature::type and onto domSignature::idlType
1950         https://bugs.webkit.org/show_bug.cgi?id=164089
1951
1952         Reviewed by Alex Christensen.
1953
1954         * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm:
1955         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
1956         Update for the removal of domSignature::type, and new signatures of helper predicates.
1957
1958 2016-10-27  Commit Queue  <commit-queue@webkit.org>
1959
1960         Unreviewed, rolling out r207992.
1961         https://bugs.webkit.org/show_bug.cgi?id=164070
1962
1963         triggered aclocal version conflict (Requested by mcatanzaro on
1964         #webkit).
1965
1966         Reverted changeset:
1967
1968         "[GTK] Bump glib to 2.50.1 (or find alternative solution to
1969         Gtk+ CUPS build issue)"
1970         https://bugs.webkit.org/show_bug.cgi?id=163689
1971         http://trac.webkit.org/changeset/207992
1972
1973 2016-10-27  Joanmarie Diggs  <jdiggs@igalia.com>
1974
1975         [GTK] Bump glib to 2.50.1 (or find alternative solution to Gtk+ CUPS build issue)
1976         https://bugs.webkit.org/show_bug.cgi?id=163689
1977
1978         Reviewed by Michael Catanzaro.
1979
1980         In order to fix bug #163591, we need to apply an upstream patch to GTK+.
1981         But GTK+ won't build with that patch due to the following error:
1982
1983             m4_copy: won't overwrite defined macro: glib_DEFUN
1984
1985         There is an upstream GLib patch which solves that issue. We should apply
1986         that patch as well, until we bump GLib to 2.50.1 or later.
1987
1988         * gtk/jhbuild.modules: Apply upstream GLib patch.
1989         * gtk/patches/glib-deprecate-am-glib-gnu-gettext.patch: Added.
1990
1991 2016-10-27  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1992
1993         Unreviewed fix of GTK and EFL test bots.
1994
1995         * Scripts/webkitperl/FeatureList.pm: Deactivated media-source and
1996         legacy-encrypted-media by default for GTK and EFL.
1997
1998 2016-10-26  Yusuke Suzuki  <utatane.tea@gmail.com>
1999
2000         [GTK] JSC test wasm.yaml/wasm/js-api/test_basic_api.js.default-wasm and wasm.yaml/wasm/js-api/test_Module.js.default-wasm fail with Exception: ReferenceError: Can't find variable: WebAssembly
2001         https://bugs.webkit.org/show_bug.cgi?id=163846
2002
2003         Reviewed by Michael Catanzaro.
2004
2005         WebAssembly is now developed for Darwin right now.
2006         Disable WASM tests in the other platforms.
2007
2008         * Scripts/run-jsc-stress-tests:
2009
2010 2016-10-26  Enrique Ocaña González  <eocanha@igalia.com>
2011
2012         [cmake][GStreamer][MSE][EME] Build MSE and EME code after refactoring
2013         https://bugs.webkit.org/show_bug.cgi?id=162928
2014
2015         Reviewed by Xabier Rodriguez-Calvar.
2016
2017         Explicitly enable MSE and EME on WebKitGTK+ buildbots.
2018
2019         This patch is co-authored with Philippe Normand <philn@igalia.com> (EME support).
2020
2021         * Scripts/webkitperl/FeatureList.pm:
2022
2023 2016-10-25  Antoine Quint  <graouts@apple.com>
2024
2025         [Modern Media Controls] Media Controller: skip back support
2026         https://bugs.webkit.org/show_bug.cgi?id=163725
2027         <rdar://problem/27989480>
2028
2029         Reviewed by Dean Jackson.
2030
2031         * Scripts/webkitpy/layout_tests/servers/aliases.json: Adding a new alias such that we may
2032         access the modern-media-controls source files through the web server.
2033
2034 2016-10-19  Jer Noble  <jer.noble@apple.com>
2035
2036         Add WKWebView fullscreen delegate SPI
2037         https://bugs.webkit.org/show_bug.cgi?id=163674
2038
2039         Reviewed by Anders Carlsson.
2040
2041         Add a new API test which verifies that the fullscreen delegate receives notifications.
2042
2043         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenDelegate.mm:
2044         (-[FullscreenDelegateMessageHandler userContentController:didReceiveScriptMessage:]):
2045         (-[FullscreenDelegateMessageHandler _webViewWillEnterFullscreen:]):
2046         (-[FullscreenDelegateMessageHandler _webViewDidEnterFullscreen:]):
2047         (-[FullscreenDelegateMessageHandler _webViewWillExitFullscreen:]):
2048         (-[FullscreenDelegateMessageHandler _webViewDidExitFullscreen:]):
2049         (TestWebKitAPI::TEST):
2050
2051 2016-10-24  Alex Christensen  <achristensen@webkit.org>
2052
2053         URLParser should match old URL::parse with %2E in path
2054         https://bugs.webkit.org/show_bug.cgi?id=163929
2055
2056         Reviewed by Alexey Proskuryakov.
2057
2058         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2059         (TestWebKitAPI::TEST_F):
2060
2061 2016-10-24  Ryan Haddad  <ryanhaddad@apple.com>
2062
2063         Unreviewed, rolling out r207795.
2064
2065         Introduced API test failures on iOS and macOS.
2066
2067         Reverted changeset:
2068
2069         "URLParser should match old URL::parse with %2E in path"
2070         https://bugs.webkit.org/show_bug.cgi?id=163929
2071         http://trac.webkit.org/changeset/207795
2072
2073 2016-10-24  Alex Christensen  <achristensen@webkit.org>
2074
2075         URLParser should match old URL::parse with %2E in path
2076         https://bugs.webkit.org/show_bug.cgi?id=163929
2077
2078         Reviewed by Alexey Proskuryakov.
2079
2080         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2081         (TestWebKitAPI::TEST_F):
2082
2083 2016-10-21  Alex Christensen  <achristensen@webkit.org>
2084
2085         URL::port should return Optional<uint16_t>
2086         https://bugs.webkit.org/show_bug.cgi?id=163806
2087
2088         Reviewed by Darin Adler.
2089
2090         * TestWebKitAPI/Tests/WebCore/URL.cpp:
2091         (TestWebKitAPI::TEST_F):
2092         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2093         (TestWebKitAPI::checkURL):
2094         (TestWebKitAPI::checkRelativeURL):
2095         (TestWebKitAPI::checkURLDifferences):
2096         (TestWebKitAPI::checkRelativeURLDifferences):
2097         (TestWebKitAPI::TEST_F):
2098
2099 2016-10-24  Youenn Fablet  <youenn@apple.com>
2100
2101         Activate WEB_RTC compilation flags for Mac bots
2102         https://bugs.webkit.org/show_bug.cgi?id=163886
2103
2104         Reviewed by Eric Carlson.
2105
2106         * Scripts/webkitperl/FeatureList.pm:
2107         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2108
2109 2016-10-24  Wenson Hsieh  <wenson_hsieh@apple.com>
2110
2111         Unreviewed, add myself as a WebKit reviewer
2112
2113         * Scripts/webkitpy/common/config/contributors.json:
2114
2115 2016-10-22  Dan Bernstein  <mitz@apple.com>
2116
2117         Improve MiniBrowser window titles for URLs without paths and with no title
2118         <https://webkit.org/b/163843>
2119
2120         Reviewed by Darin Adler.
2121
2122         * MiniBrowser/mac/WK1BrowserWindowController.m:
2123         (-[WK1BrowserWindowController fetch:]): While we’re here, deploy
2124           +[NSURL _webkit_URLWithUserTypedString:] here to match the WK2BrowserWindowController
2125           version of this method.
2126         (-[WK1BrowserWindowController updateTitle:]): If the URL doesn’t have a lastPathComponent,
2127           use the entire URL.
2128         (-[WK1BrowserWindowController webView:didCommitLoadForFrame:]): Also while we’re here,
2129           deploy +[NSURL _web_userVisibleString] here to match the WK2BrowserWindowController
2130           behavior.
2131
2132         * MiniBrowser/mac/WK2BrowserWindowController.m:
2133         (-[WK2BrowserWindowController updateTitle:]): If the URL doesn’t have a lastPathComponent,
2134           use the entire URL.
2135
2136 2016-10-21  David Kilzer  <ddkilzer@apple.com>
2137
2138         Bug 163762: IntSize::area() should used checked arithmetic
2139         <https://webkit.org/b/163762>
2140
2141         Reviewed by Darin Adler.
2142
2143         * TestWebKitAPI/Tests/WebCore/IntRect.cpp:
2144         (TestWebKitAPI::TEST): Call unsafeGet().
2145         * TestWebKitAPI/Tests/WebCore/IntSize.cpp:
2146         (TestWebKitAPI::TEST): Ditto.
2147
2148 2016-10-21  James Craig  <jcraig@apple.com>
2149
2150         Unreviewed: Added Aaron Chu <aaron_chu@apple.com> to contributors list.
2151
2152         * Scripts/webkitpy/common/config/contributors.json:
2153
2154 2016-10-21  Commit Queue  <commit-queue@webkit.org>
2155
2156         Unreviewed, rolling out r207582.
2157         https://bugs.webkit.org/show_bug.cgi?id=163819
2158
2159         Not quite ready rdar://problem/28897179 (Requested by
2160         alexchristensen on #webkit).
2161
2162         Reverted changeset:
2163
2164         "Re-enable URLParser for non-Safari Cocoa apps after r207321"
2165         https://bugs.webkit.org/show_bug.cgi?id=163690
2166         http://trac.webkit.org/changeset/207582
2167
2168 2016-10-21  Jonathan Bedard  <jbedard@apple.com>
2169
2170         WebKitTestRunnerApp packages .idl file
2171         https://bugs.webkit.org/show_bug.cgi?id=163788
2172
2173         Reviewed by Darin Adler.
2174
2175         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Removed .idl file from app package, removed bad reference to app icon.
2176
2177 2016-10-21  Csaba Osztrogonác  <ossy@webkit.org>
2178
2179         [EFL] REGRESSION(r207616): Build is broken due to missing libgeoclue-dev package
2180         https://bugs.webkit.org/show_bug.cgi?id=163733
2181
2182         Reviewed by Gyuyoung Kim.
2183
2184         * efl/install-dependencies: Added geoclue-2.0 package.
2185
2186 2016-10-21  Commit Queue  <commit-queue@webkit.org>
2187
2188         Unreviewed, rolling out r207609.
2189         https://bugs.webkit.org/show_bug.cgi?id=163776
2190
2191         As glib bump was rollout, we need to rollout this too
2192         (Requested by rego on #webkit).
2193
2194         Reverted changeset:
2195
2196         "[GTK] Cannot build GTK+ with CUPS 2.* versions"
2197         https://bugs.webkit.org/show_bug.cgi?id=163591
2198         http://trac.webkit.org/changeset/207609
2199
2200 2016-10-20  Chris Dumez  <cdumez@apple.com>
2201
2202         "Download Linked File" context menu action should use 'download' attribute as suggested filename
2203         https://bugs.webkit.org/show_bug.cgi?id=163742
2204         <rdar://problem/28840734>
2205
2206         Reviewed by Darin Adler.
2207
2208         Add API test coverage.
2209
2210         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2211         * TestWebKitAPI/Tests/WebKit2/link-with-download-attribute.html: Added.
2212         * TestWebKitAPI/Tests/WebKit2/mac/ContextMenuDownload.mm: Added.
2213         (TestWebKitAPI::didFinishLoadForFrame):
2214         (TestWebKitAPI::getContextMenuFromProposedMenu):
2215         (TestWebKitAPI::decideDestinationWithSuggestedFilename):
2216         (TestWebKitAPI::TEST):
2217
2218 2016-10-20  Commit Queue  <commit-queue@webkit.org>
2219
2220         Unreviewed, rolling out r207589.
2221         https://bugs.webkit.org/show_bug.cgi?id=163765
2222
2223         Introduced 17 new layout test failures (Requested by
2224         mcatanzaro on #webkit).
2225
2226         Reverted changeset:
2227
2228         "[GTK] Bump glib to 2.50.1"
2229         https://bugs.webkit.org/show_bug.cgi?id=163689
2230         http://trac.webkit.org/changeset/207589
2231
2232 2016-10-19  Myles C. Maxfield  <mmaxfield@apple.com>
2233
2234         [macOS] [iOS] Disable variation fonts on macOS El Capitan and iOS 9
2235         https://bugs.webkit.org/show_bug.cgi?id=163374
2236
2237         Reviewed by Darin Adler.
2238
2239         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2240
2241 2016-10-20  Sam Weinig  <sam@webkit.org>
2242
2243         Add convenience function that combines WTF::visit(...) with WTF::makeVisitor(...)
2244         https://bugs.webkit.org/show_bug.cgi?id=163713
2245
2246         Reviewed by Dan Bernstein.
2247
2248         * TestWebKitAPI/Tests/WTF/Variant.cpp:
2249         Add test for WTF::switchOn()
2250
2251 2016-10-20  Fujii Hironori  <Hironori.Fujii@sony.com>
2252
2253         [CMake] CMake does not support the dep files for implicit dependency
2254         https://bugs.webkit.org/show_bug.cgi?id=161433
2255
2256         Reviewed by Brent Fulgham.
2257
2258         Created a Perl script to generate all IDL bindings for CMake.
2259         This script can regenerate outdated bindings by based on the
2260         supplemental dependency and dep files created by
2261         '--write-dependencies' switch of generate-bindings.pl.
2262
2263         add_custom_target is used to invoke the script instead of
2264         add_custom_command because Ninja deletes all output files before
2265         executing the command in case of add_custom_command.
2266
2267         USES_TERMINAL option of add_custom_target has two effects:
2268         1) Not buffering output of the command
2269         2) Invoking the command in the special Ninja pool which inhibits parallel build
2270         One needs to use CMake 3.2 or later to enable this feature.
2271
2272         * DumpRenderTree/CMakeLists.txt: Specified a target name for
2273         GENERATE_BINDINGS. Added dependency for the target.
2274         * WebKitTestRunner/CMakeLists.txt: Ditto.
2275
2276 2016-10-20  Manuel Rego Casasnovas  <rego@igalia.com>
2277
2278         [GTK] Cannot build GTK+ with CUPS 2.* versions
2279         https://bugs.webkit.org/show_bug.cgi?id=163591
2280
2281         Reviewed by Michael Catanzaro.
2282
2283         GTK+ is wrongly checking about the available CUPS version,
2284         so if you have CUPS 2.* the configure step fails.
2285
2286         This has been already fixed upstream and included in 2.30 series:
2287         https://git.gnome.org/browse/gtk+/commit/?id=631f6b536485829a0bd00532f5826ad302b4951b
2288
2289         Added patch on JHBuild so we can now build GTK+ with CUPS 2.*.
2290
2291         * gtk/jhbuild.modules: Applied patch and avoid using "configure" script directly
2292         as the patch modifies "configure.ac".
2293         * gtk/patches/configure-fix-detecting-CUPS-2.x.patch: Added.
2294
2295 2016-10-20  Manuel Rego Casasnovas  <rego@igalia.com>
2296
2297         [GTK] Bump glib to 2.50.1
2298         https://bugs.webkit.org/show_bug.cgi?id=163689
2299
2300         Reviewed by Michael Catanzaro.
2301
2302         This is need in order to fix GTK+ build with CUPS 2.* (bug #163591).
2303
2304         * gtk/jhbuild.modules: Bump glib version. Pass --disable-libmount to build properly.
2305         Also we don't need the patches anymore.
2306         * gtk/patches/gdate-suppress-string-format-literal-warning.patch: Removed.
2307         * gtk/patches/glib-warning-fix.patch: Removed.
2308
2309 2016-10-19  Alex Christensen  <achristensen@webkit.org>
2310
2311         Re-enable URLParser for non-Safari Cocoa apps after r207321
2312         https://bugs.webkit.org/show_bug.cgi?id=163690
2313
2314         Reviewed by Darin Adler.
2315
2316         * DumpRenderTree/mac/DumpRenderTree.mm:
2317         (DumpRenderTreeMain):
2318         * TestWebKitAPI/Tests/WebKit2Cocoa/LoadInvalidURLRequest.mm:
2319         (-[LoadInvalidURLNavigationActionDelegate webView:didFailProvisionalNavigation:withError:]):
2320         * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.mm:
2321         (TestWebKitAPI::TEST):
2322         * WebKitTestRunner/TestController.cpp:
2323         (WTR::TestController::TestController):
2324
2325 2016-10-19  Ryan Haddad  <ryanhaddad@apple.com>
2326
2327         Unreviewed, rolling out r207557.
2328
2329         This change caused animations/font-variations tests to time
2330         out on pre-Sierra Macs.
2331
2332         Reverted changeset:
2333
2334         "[macOS] [iOS] Disable variation fonts on macOS El Capitan and
2335         iOS 9"
2336         https://bugs.webkit.org/show_bug.cgi?id=163374
2337         http://trac.webkit.org/changeset/207557
2338
2339 2016-10-19  Andy Estes  <aestes@apple.com>
2340
2341         Crash in ASCIICaseInsensitiveHash::hash() when a response has a null MIME type
2342         https://bugs.webkit.org/show_bug.cgi?id=163476
2343         <rdar://problem/26941395>
2344
2345         Reviewed by Andreas Kling.
2346
2347         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2348         * TestWebKitAPI/Tests/WebKit2Cocoa/LoadDataWithNilMIMEType.mm: Added.
2349         (TEST): Added an API test that passes a nil MIMEType to
2350         -[WKWebView loadData:MIMEType:characterEncodingName:baseURL:].
2351
2352 2016-10-19  Jer Noble  <jer.noble@apple.com>
2353
2354         Modify testrunner to mute audio during tests
2355         https://bugs.webkit.org/show_bug.cgi?id=162582
2356
2357         Reviewed by Alexey Proskuryakov.
2358
2359         * DumpRenderTree/mac/DumpRenderTree.mm:
2360         (createWebViewAndOffscreenWindow):
2361         * WebKitTestRunner/TestController.cpp:
2362         (WTR::TestController::resetStateToConsistentValues):
2363
2364 2016-10-19  Joseph Pecoraro  <pecoraro@apple.com>
2365
2366         check-webkit-style: fix false-positive warnings about using #pragma once header guard
2367         https://bugs.webkit.org/show_bug.cgi?id=163575
2368
2369         Reviewed by Brady Eidson.
2370
2371         There were some false positive warnings about header guards
2372         for ObjC headers that don't need guards. This changes the
2373         style checker to no longer warn if there is no #pragma once.
2374         It only warns if there are #ifndef that should be #pragma once.
2375
2376         * Scripts/webkitpy/style/checkers/cpp.py:
2377         (check_for_header_guard):
2378         Change when we output an error.
2379
2380         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2381         (CppStyleTest.test_build_header_guard):
2382         Update tests.
2383
2384 2016-10-19  Myles C. Maxfield  <mmaxfield@apple.com>
2385
2386         [macOS] [iOS] Disable variation fonts on macOS El Capitan and iOS 9
2387         https://bugs.webkit.org/show_bug.cgi?id=163374
2388
2389         Reviewed by Darin Adler.
2390
2391         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2392
2393 2016-10-18  Philippe Normand  <pnormand@igalia.com>
2394
2395         WebRTC: [GTK] Update jhbuild environment for OpenWebRTC
2396         https://bugs.webkit.org/show_bug.cgi?id=163330
2397
2398         Reviewed by Michael Catanzaro.
2399
2400         Bring back the openwebrtc JHBuild moduleset in the time being. It
2401         should be removed after the bump to GStreamer 1.10 is complete and
2402         the libnice patches have been upstreamed. The GStreamer git
2403         snapshots used in this patch are the ones configured in Ericsson's
2404         GStreamer Cerbero fork.
2405
2406         * gtk/openwebrtc.modules: Added.
2407         * gtk/patches/libnice-0001-TURN-allow-REALM-to-be-empty.patch: Added.
2408         * gtk/patches/libnice-0001-agent-Remove-unnecessary-NULL-check.patch: Added.
2409         * gtk/patches/libnice-0001-nicesrc-spin-the-agent-mainloop-in-a-separate-thread.patch: Added.
2410         * gtk/patches/libnice-0002-Do-not-update-a-remote-candidate-s-type.patch: Added.
2411         * gtk/patches/libnice-0002-TURN-handle-437-Allocation-Mismatch-responses.patch: Added.
2412         * gtk/patches/libnice-0003-Do-not-compare-scope-for-IPv6-address-when-scope-is-.patch: Added.
2413         * gtk/patches/libnice-0004-Removing-no-op-assignment.patch: Added.
2414
2415 2016-10-18  Sam Weinig  <sam@webkit.org>
2416
2417         Replace std::experimental::variant with WTF::Variant (or similar)
2418         https://bugs.webkit.org/show_bug.cgi?id=163626
2419
2420         Reviewed by Chris Dumez.
2421
2422         Rename std::experimental::variant, Variant. Move helpers get/holds_alternative/etc.
2423         into the WTF namespace.
2424
2425         * TestWebKitAPI/Tests/WTF/Variant.cpp:
2426         (TestWebKitAPI::TEST):
2427
2428 2016-10-18  Simon Fraser  <simon.fraser@apple.com>
2429
2430         Add a MiniBrowser menu item to apply page scale in WK1 and WK2
2431         https://bugs.webkit.org/show_bug.cgi?id=163627
2432
2433         Reviewed by Dean Jackson.
2434
2435         Rename setScale: to setViewScale: and add setPageScale:, hooking it up for WK1 (via exisiting SPI)
2436         and WK2 (via new SPI).
2437
2438         * MiniBrowser/mac/BrowserWindowController.h:
2439         * MiniBrowser/mac/BrowserWindowController.m:
2440         (-[BrowserWindowController pageScaleForMenuItemTag:]):
2441         (-[BrowserWindowController setPageScale:]):
2442         (-[BrowserWindowController setViewScale:]):
2443         (-[BrowserWindowController setScale:]): Deleted.
2444         * MiniBrowser/mac/MainMenu.xib:
2445         * MiniBrowser/mac/WK1BrowserWindowController.m:
2446         (-[WK1BrowserWindowController setPageScale:]):
2447         (-[WK1BrowserWindowController setViewScale:]):
2448         (areEssentiallyEqual):
2449         (-[WK1BrowserWindowController validateMenuItem:]):
2450         (-[WK1BrowserWindowController setScale:]): Deleted.
2451         * MiniBrowser/mac/WK2BrowserWindowController.m:
2452         (-[WK2BrowserWindowController setPageScale:]):
2453         (-[WK2BrowserWindowController viewScaleForMenuItemTag:]):
2454         (-[WK2BrowserWindowController setViewScale:]):
2455         (areEssentiallyEqual):
2456         (-[WK2BrowserWindowController validateMenuItem:]):
2457         (viewScaleForMenuItemTag): Deleted.
2458         (-[WK2BrowserWindowController setScale:]): Deleted.
2459
2460 2016-10-18  Anders Carlsson  <andersca@apple.com>
2461
2462         Add an beforeunload alert to the WebKitLegacy MiniBrowser
2463         https://bugs.webkit.org/show_bug.cgi?id=163634
2464
2465         Reviewed by Sam Weinig.
2466
2467         * MiniBrowser/mac/WK1BrowserWindowController.m:
2468         (-[WK1BrowserWindowController webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:]):
2469
2470 2016-10-18  Commit Queue  <commit-queue@webkit.org>
2471
2472         Unreviewed, rolling out r207443.
2473         https://bugs.webkit.org/show_bug.cgi?id=163616
2474
2475         "Caused 5% PLT regression" (Requested by krollin on #webkit).
2476
2477         Reverted changeset:
2478
2479         "Crash in ASCIICaseInsensitiveHash::hash() when a response has
2480         a null MIME type"
2481         https://bugs.webkit.org/show_bug.cgi?id=163476
2482         http://trac.webkit.org/changeset/207443
2483
2484 2016-10-18  Eric Carlson  <eric.carlson@apple.com>
2485
2486         [MediaStream] Resolve constraints and enumerate devices in the UI process
2487         https://bugs.webkit.org/show_bug.cgi?id=162147
2488         <rdar://problem/28803569>
2489
2490         Reviewed by Darin Adler.
2491
2492         * WebKitTestRunner/TestController.cpp:
2493         (WTR::TestController::resetPreferencesToConsistentValues): Enable mock capture devices.
2494         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Update for API changes.
2495
2496 2016-10-17  Megan Gardner  <megan_gardner@apple.com>
2497
2498         Add test and infrastructure for link popover
2499         https://bugs.webkit.org/show_bug.cgi?id=163406
2500
2501         Reviewed by Simon Fraser.
2502
2503         Added functionality test for link popovers.
2504         Can query for what URL is loaded, and that the popover has appeared or has
2505         been dismissed.
2506         Added a link popover test.
2507
2508         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2509         (WTR::UIScriptController::platformSetDidShowForcePressPreviewCallback):
2510         (WTR::UIScriptController::platformSetDidDismissForcePressPreviewCallback):
2511         (WTR::UIScriptController::platformSetDidEndFormControlInteractionCallback): Deleted.
2512         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2513         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
2514         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2515         (WTR::UIScriptController::setDidShowForcePressPreviewCallback):
2516         (WTR::UIScriptController::didShowForcePressPreviewCallback):
2517         (WTR::UIScriptController::setDidDismissForcePressPreviewCallback):
2518         (WTR::UIScriptController::didDismissForcePressPreviewCallback):
2519         (WTR::UIScriptController::platformSetDidShowForcePressPreviewCallback):
2520         (WTR::UIScriptController::platformSetDidDismissForcePressPreviewCallback):
2521         (WTR::UIScriptController::didEndFormControlInteractionCallback): Deleted.
2522         (WTR::UIScriptController::platformSetDidEndFormControlInteractionCallback): Deleted.
2523         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2524         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2525         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2526         (-[TestRunnerWKWebView dealloc]):
2527         (-[TestRunnerWKWebView didShowForcePressPreview]):
2528         (-[TestRunnerWKWebView didDismissForcePressPreview]):
2529         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2530         (WTR::UIScriptController::platformSetDidShowForcePressPreviewCallback):
2531         (WTR::UIScriptController::platformSetDidDismissForcePressPreviewCallback):
2532         (WTR::UIScriptController::platformSetDidEndFormControlInteractionCallback): Deleted.
2533
2534 2016-10-17  Tim Horton  <timothy_horton@apple.com>
2535
2536         REGRESSION (r169805): WKWebView canGoBack returning YES when nothing is in the back-forward list after restoring session state
2537         https://bugs.webkit.org/show_bug.cgi?id=163573
2538         <rdar://problem/28744549>
2539
2540         Reviewed by Dan Bernstein.
2541
2542         * TestWebKitAPI/Tests/WebKit2/WKBackForwardList.mm:
2543         (TEST):
2544         Add a test ensuring that canGoBack returns NO after restoring session state without navigating.
2545
2546 2016-10-17  Andy Estes  <aestes@apple.com>
2547
2548         Crash in ASCIICaseInsensitiveHash::hash() when a response has a null MIME type
2549         https://bugs.webkit.org/show_bug.cgi?id=163476
2550         <rdar://problem/26941395>
2551
2552         Reviewed by Tim Horton.
2553
2554         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2555         * TestWebKitAPI/Tests/WebKit2Cocoa/LoadDataWithNilMIMEType.mm: Added.
2556         (TEST): Added an API test that passes a nil MIMEType to
2557         -[WKWebView loadData:MIMEType:characterEncodingName:baseURL:].
2558
2559 2016-10-17  Dean Jackson  <dino@apple.com>
2560
2561         Allow creation of ExtendedColors and make Color immutable
2562         https://bugs.webkit.org/show_bug.cgi?id=163557
2563         <rdar://problem/28805360>
2564
2565         Reviewed by Darin Adler and Dave Hyatt.
2566
2567         API tests for ExtendedColor.
2568
2569         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2570         * TestWebKitAPI/Tests/WebCore/ExtendedColor.cpp: Added.
2571         (TestWebKitAPI::TEST):
2572         (TestWebKitAPI::makeColor):
2573
2574 2016-10-17  JF Bastien  <jfbastien@apple.com>
2575
2576         WebAssembly JS API: implement basic stub
2577
2578         Implement the global WebAssembly JavaScript object, and its constructor +
2579         function properties as described in:
2580           https://github.com/WebAssembly/design/blob/master/JS.md
2581
2582         These don't do anything at the moment, the parent bug will take care of adding
2583         more functionality and associated tests.
2584
2585         WebAssembly JS API: implement basic stub
2586         https://bugs.webkit.org/show_bug.cgi?id=163404
2587
2588         Reviewed by Keith Miller.
2589
2590         * Scripts/run-jsc-stress-tests: use the new JSC option which exposes the WebAssembly object.
2591
2592 2016-10-17  Fujii Hironori  <Hironori.Fujii@sony.com>
2593
2594         resolve-ChangeLogs: Specify --no-page to git diff
2595         https://bugs.webkit.org/show_bug.cgi?id=163441
2596
2597         Reviewed by Darin Adler.
2598
2599         resolve-ChangeLogs shows the result after resolving by invoking
2600         'git diff'. It runs a pager for every ChangeLog if it is under
2601         TTY.
2602
2603         * Scripts/resolve-ChangeLogs:
2604         (showStatus): Specify '--no-page' to git diff.
2605
2606 2016-10-17  Michael Catanzaro  <mcatanzaro@igalia.com>
2607
2608         Move user agent quirks to cross-platform location
2609         https://bugs.webkit.org/show_bug.cgi?id=163508
2610
2611         Reviewed by Carlos Garcia Campos.
2612
2613         Move the test to a cross-platform location and improve it to better check the full list of
2614         sites we have defined quirks for.
2615
2616         * TestWebKitAPI/PlatformGTK.cmake:
2617         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/gtk/UserAgentQuirks.cpp.
2618         (TestWebKitAPI::assertUserAgentForURLHasChromeBrowserQuirk):
2619         (TestWebKitAPI::assertUserAgentForURLHasMacPlatformQuirk):
2620         (TestWebKitAPI::TEST):
2621
2622 2016-10-17  Carlos Garcia Campos  <cgarcia@igalia.com>
2623
2624         [SOUP] Downloads should always sniff contents
2625         https://bugs.webkit.org/show_bug.cgi?id=163538
2626
2627         Reviewed by Michael Catanzaro.
2628
2629         Add a test case to check that the MIME type is correctly guessed for downloads.
2630
2631         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
2632         (writeNextChunk):
2633         (serverCallback):
2634         (testDownloadMIMEType):
2635         (beforeAll):
2636         (writeNextChunkIdle): Deleted.
2637
2638 2016-10-16  Daniel Bates  <dabates@apple.com>
2639
2640         Fix Perl warning about masked variable following <http://trac.webkit.org/changeset/207382>
2641         (https://bugs.webkit.org/show_bug.cgi?id=163456)
2642
2643         * Scripts/prepare-ChangeLog:
2644         (actuallyGenerateFunctionLists):
2645
2646 2016-10-16  Carlos Garcia Campos  <cgarcia@igalia.com>
2647
2648         Unreviewed. Fix GTK+ unit test /webkit2/WebKitWebContext/languages after r206949.
2649
2650         After r206949 navigator.language returns en-US instead of en-us. Language tags in Accept-Language header are
2651         actually case-insensitive, so we should actually do case-insensitive comparisons, but we only have
2652         g_assert_cmpstr for tests.
2653
2654         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
2655         (testWebContextLanguages):
2656
2657 2016-10-16  Carlos Garcia Campos  <cgarcia@igalia.com>
2658
2659         [GTK] WebKitWebPage URI not updated after URI is modified by InjectedBundlePageResourceLoadClient::willSendRequestForFrame
2660         https://bugs.webkit.org/show_bug.cgi?id=163389
2661
2662         Reviewed by Michael Catanzaro.
2663
2664         Update /webkit2/WebKitWebPage/get-uri test to check that web view and page uri always match even when request is
2665         modified by WebKitWebPage::send-request signal.
2666
2667         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
2668         (testWebPageURI):
2669
2670 2016-10-16  Carlos Garcia Campos  <cgarcia@igalia.com>
2671
2672         Document request not updated after willSendRequest is called for a redirect
2673         https://bugs.webkit.org/show_bug.cgi?id=163436
2674
2675         Reviewed by Michael Catanzaro.
2676
2677         Update /webkit2/WebKitWebView/active-uri test to check the active URI also when modified by
2678         WebKitPage::send-request signal in a web extension.
2679
2680         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
2681         (testWebViewActiveURI):
2682         (serverCallback):
2683         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
2684         (sendRequestCallback):
2685         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
2686         (loadChangedCallback):
2687
2688 2016-10-15  Dan Bernstein  <mitz@apple.com>
2689
2690         REGRESSION (r191699): Contextual menu in Mail compose view doesn’t include any of the standard submenus
2691         https://bugs.webkit.org/show_bug.cgi?id=163492
2692         <rdar://problem/28654799>
2693
2694         Reviewed by Darin Adler.
2695
2696         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2697         * TestWebKitAPI/Tests/mac/ContextMenuDefaultItemsHaveTags.mm: Added.
2698         (-[ContextMenuDefaultItemsHaveTagsDelegate webView:didFinishLoadForFrame:]):
2699         (TestWebKitAPI::TEST):
2700
2701 2016-10-15  Daniel Bates  <dabates@apple.com>
2702
2703         prepare-ChangeLog erroneously said that a python __init__ method was deleted
2704         https://bugs.webkit.org/show_bug.cgi?id=163456
2705
2706         Reviewed by Simon Fraser.
2707
2708         Fixes an issue where prepare-ChangeLog may list as deleted functions that are
2709         immediately above added code.
2710
2711         Currently prepare-ChangeLog makes use of the same overlap detection algorithm
2712         to compute the list of deleted functions as it does to compute added and modified
2713         functions. We consider a function deleted if its entire function body and signature
2714         are removed. It is sufficient to compare the list of functions before the patch
2715         is applied and the list of functions are the patch is applied to identify
2716         these functions.
2717
2718         * Scripts/prepare-ChangeLog: Fix some style nits, including using Camel Case for
2719         variable names.
2720         (actuallyGenerateFunctionLists): Modified to call computeModifiedFunctions(). Always
2721         compute the list of functions in the file after the patch regardless of whether the
2722         patch only contains deletions. We will compare this list against the list of functions
2723         before the patch was applied to determine the deleted functions.
2724         (computeModifiedFunctions): Renamed; formerly named generateFunctionListsByRanges.
2725         Removed out argument for the seen functions as we no longer make use of when computing
2726         the list of deleted functions.
2727         (diffCommand): Update comment.
2728         (generateFunctionListsByRanges): Deleted.
2729         * Scripts/webkitperl/prepare-ChangeLog_unittest/generateFunctionLists.pl: Added more unit tests.
2730
2731 2016-10-14  Simon Fraser  <simon.fraser@apple.com>
2732
2733         REGRESSION (r206973): Running "webkit-patch suggest-reviewers" throws an AttributeError: 'NoneType' object has no attribute 'full_name'
2734         https://bugs.webkit.org/show_bug.cgi?id=163478
2735
2736         Reviewed by Daniel Bates.
2737         
2738         Handle a None other in Contributor.__eq__.
2739
2740         * Scripts/webkitpy/common/config/committers.py:
2741         (Contributor.__eq__):
2742
2743 2016-10-14  JF Bastien  <jfbastien@apple.com>
2744
2745         Basic WebAssembly testing
2746
2747         Create a small DSL in JavaScript which can build WebAssembly binary modules based on the JSON description of the format as described in:
2748         https://github.com/WebAssembly/design/blob/master/BinaryEncoding.md
2749
2750         This DSL can then be used to write small text description of valid and invalid WebAssembly binaries, making testing the JSC implementation much easier.
2751
2752         Details and example in README.md.
2753
2754         Basic WebAssembly testing
2755         https://bugs.webkit.org/show_bug.cgi?id=163267
2756
2757         Reviewed by Keith Miller.
2758
2759         * Scripts/run-javascriptcore-tests:
2760         (runJSCStressTests): run wasm.yaml tests
2761         * Scripts/run-jsc-stress-tests: add a WebAssembly-specific runner
2762
2763 2016-10-14  Simon Fraser  <simon.fraser@apple.com>
2764
2765         Annotate bots in contributors.json and don't show them on webkit.org/team
2766         https://bugs.webkit.org/show_bug.cgi?id=163317
2767
2768         Reviewed by Daniel Bates.
2769         
2770         Add "class" : "bot" for non-humans in contributors.json and round-trip it.
2771
2772         * Scripts/webkitpy/common/config/committers.py:
2773         (Contributor.__init__):
2774         (Contributor.as_dict):
2775         (Bot):
2776         (Bot.__init__):
2777         (CommitterList.load_json):
2778         * Scripts/webkitpy/common/config/contributors.json:
2779
2780 2016-10-14  Simon Fraser  <simon.fraser@apple.com>
2781
2782         Fix printing in WK2 MiniBrowser
2783         https://bugs.webkit.org/show_bug.cgi?id=163455
2784
2785         Reviewed by Tim Horton.
2786         
2787         Call the basic -_printOperationWithPrintInfo: which doens't require a frame argument.
2788
2789         * MiniBrowser/mac/WK2BrowserWindowController.m:
2790         (-[WK2BrowserWindowController printWebView:]):
2791
2792 2016-10-14  Commit Queue  <commit-queue@webkit.org>
2793
2794         Unreviewed, rolling out r207335.
2795         https://bugs.webkit.org/show_bug.cgi?id=163445
2796
2797         WebKit2.ProvisionalURLAfterWillSendRequestCallback is timing
2798         out on Mac bots (Requested by youenn on #webkit).
2799
2800         Reverted changeset:
2801
2802         "Add ProvisionalURLAfterWillSendRequestCallback.cpp and
2803         ProvisionalURLAfterWillSendRequestCallback_Bundle.cpp to Mac
2804         builds"
2805         https://bugs.webkit.org/show_bug.cgi?id=163440
2806         http://trac.webkit.org/changeset/207335
2807
2808 2016-10-14  Youenn Fablet  <youenn@apple.com>
2809
2810         Add ProvisionalURLAfterWillSendRequestCallback.cpp and ProvisionalURLAfterWillSendRequestCallback_Bundle.cpp to Mac builds
2811         https://bugs.webkit.org/show_bug.cgi?id=163440
2812
2813         Unreviewed.
2814
2815         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Adding new test files introduced in
2816         https://bugs.webkit.org/show_bug.cgi?id=146306 patch.
2817
2818 2016-10-13  Carlos Garcia Campos  <cgarcia@igalia.com>
2819
2820         Unreviewed. Removed myself from BindingsScripts watch list.
2821
2822         * Scripts/webkitpy/common/config/watchlist:
2823
2824 2016-10-13  Carlos Garcia Campos  <cgarcia@igalia.com>
2825
2826         WebView and WebPage URLs not updated after URL is modified by InjectedBundlePageResourceLoadClient::willSendRequestForFrame
2827         https://bugs.webkit.org/show_bug.cgi?id=146306
2828
2829         Reviewed by Darin Adler.
2830
2831         Add unit test to check that the committed URL is updated when changed in willSendRequest callback.
2832
2833         * TestWebKitAPI/CMakeLists.txt:
2834         * TestWebKitAPI/PlatformEfl.cmake:
2835         * TestWebKitAPI/PlatformGTK.cmake:
2836         * TestWebKitAPI/Tests/WebKit2/ProvisionalURLAfterWillSendRequestCallback.cpp: Added.
2837         (TestWebKitAPI::didCommitLoadForFrame):
2838         (TestWebKitAPI::TEST):
2839         * TestWebKitAPI/Tests/WebKit2/ProvisionalURLAfterWillSendRequestCallback_Bundle.cpp: Added.
2840         (TestWebKitAPI::ProvisionalURLAfterWillSendRequestCallbackTest::ProvisionalURLAfterWillSendRequestCallbackTest):
2841         (TestWebKitAPI::ProvisionalURLAfterWillSendRequestCallbackTest::willSendRequestForFrame):
2842         (TestWebKitAPI::ProvisionalURLAfterWillSendRequestCallbackTest::didCommitLoadForFrame):
2843
2844 2016-10-13  Alex Christensen  <achristensen@webkit.org>
2845
2846         Hosts of URLs with non-special schemes should be case-sensitive, and non-ASCII characters in such hosts should be punycode-encoded
2847         https://bugs.webkit.org/show_bug.cgi?id=163413
2848
2849         Reviewed by Tim Horton.
2850
2851         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2852         (TestWebKitAPI::TEST_F):
2853         Update parsing results.  There are now fewer differences between the new URLParser and the old URL::parse.
2854
2855 2016-10-13  Alex Christensen  <achristensen@webkit.org>
2856
2857         Rebase API tests after r207305.
2858
2859         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2860         Actually build Tests/mac/LoadInvalidURLRequest.mm so we are running the WebKit1.LoadInvalidURLRequest API test.
2861         * TestWebKitAPI/Tests/WebKit2Cocoa/LoadInvalidURLRequest.mm:
2862         (-[LoadInvalidURLNavigationActionDelegate webView:didFailProvisionalNavigation:withError:]):
2863         * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.mm:
2864         (-[LoadInvalidURLWebFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
2865         Change results back to what they were before r207162, r207167, and r207184.
2866
2867 2016-10-13  Alex Christensen  <achristensen@webkit.org>
2868
2869         Disable URLParser for non-Safari iOS and Mac apps for now
2870         https://bugs.webkit.org/show_bug.cgi?id=163397
2871
2872         Reviewed by Tim Horton.
2873
2874         * DumpRenderTree/mac/DumpRenderTree.mm:
2875         (DumpRenderTreeMain):
2876         * WebKitTestRunner/TestController.cpp:
2877         Enable the URLParser for testing.
2878         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
2879         Link with WebCoreTestSupport so we can find setURLParserEnabled.
2880
2881 2016-10-13  Ryan Haddad  <ryanhaddad@apple.com>
2882
2883         Unreviewed, rolling out r207297.
2884
2885         This change broke the iOS build.
2886
2887         Reverted changeset:
2888
2889         "Disable URLParser for non-Safari iOS and Mac apps for now"
2890         https://bugs.webkit.org/show_bug.cgi?id=163397
2891         http://trac.webkit.org/changeset/207297
2892
2893 2016-10-13  Alex Christensen  <achristensen@webkit.org>
2894
2895         Disable URLParser for non-Safari iOS and Mac apps for now
2896         https://bugs.webkit.org/show_bug.cgi?id=163397
2897
2898         Reviewed by Tim Horton.
2899
2900         * DumpRenderTree/mac/DumpRenderTree.mm:
2901         (DumpRenderTreeMain):
2902         * WebKitTestRunner/ios/mainIOS.mm:
2903         (main):
2904         * WebKitTestRunner/mac/main.mm:
2905         (main):
2906
2907 2016-10-12  Alex Christensen  <achristensen@webkit.org>
2908
2909         Fix out-of-bounds reading in URLParser when parsing improperly percent-encoded values
2910         https://bugs.webkit.org/show_bug.cgi?id=163376
2911
2912         Reviewed by Saam Barati.
2913
2914         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2915         (TestWebKitAPI::TEST_F):
2916
2917 2016-10-11  Dean Jackson  <dino@apple.com>
2918
2919         Add preliminary support for extended colors to WebCore::Color
2920         https://bugs.webkit.org/show_bug.cgi?id=162878
2921         <rdar://problem/28596413>
2922
2923         Reviewed by Darin Adler.
2924
2925         A new API test for Colors.
2926
2927         * TestWebKitAPI/Tests/WebCore/Color.cpp:
2928         (TestWebKitAPI::TEST):
2929
2930 2016-10-12  Ryan Haddad  <ryanhaddad@apple.com>
2931
2932         Unreviewed, rolling out r207225.
2933
2934         This change causes debug tests to exit early with crashes.
2935
2936         Reverted changeset:
2937
2938         "Optional's move-constructor and move-assignment operator
2939         don't disengage the value being moved from"
2940         https://bugs.webkit.org/show_bug.cgi?id=163309
2941         http://trac.webkit.org/changeset/207225
2942
2943 2016-10-12  Alex Christensen  <achristensen@webkit.org>
2944
2945         Fix assertion after switching to URLParser
2946         https://bugs.webkit.org/show_bug.cgi?id=163350
2947         rdar://problem/28739938
2948
2949         Reviewed by Brady Eidson.
2950
2951         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
2952         (TEST):
2953
2954 2016-10-11  Sam Weinig  <sam@webkit.org>
2955
2956         Optional's move-constructor and move-assignment operator don't disengage the value being moved from
2957         https://bugs.webkit.org/show_bug.cgi?id=163309
2958
2959         Reviewed by Anders Carlsson.
2960
2961         * TestWebKitAPI/Tests/WTF/Optional.cpp:
2962         (TestWebKitAPI::TEST):
2963         Add tests for Optional's move-constructor and move-assignment operator.
2964
2965 2016-10-12  Wenson Hsieh  <wenson_hsieh@apple.com>
2966
2967         Now playing media sessions are always cleared for the active foreground tab
2968         https://bugs.webkit.org/show_bug.cgi?id=163310
2969         <rdar://problem/28573301>
2970
2971         Reviewed by Jer Noble.
2972
2973         Tweaks existing unit tests to verify that media session info persists when backgrounding and foregrounding, but
2974         that media session info is correctly cleared out if the media session itself is no longer eligible for Now
2975         Playing (not accounting for foreground/active state). Previously, these tests were verifying that we would
2976         always clear out the information, but this is incorrect, and is the source of the problem.
2977
2978         * TestWebKitAPI/Tests/WebKit2Cocoa/NowPlayingControlsTests.mm:
2979         (-[NowPlayingTestWebView waitForNowPlayingInfoToChange]):
2980         (TestWebKitAPI::TEST):
2981
2982 2016-10-12  Per Arne Vollan  <pvollan@apple.com>
2983
2984         [Win] Parallel DRTs are sharing preferences and cache.
2985         https://bugs.webkit.org/show_bug.cgi?id=163013
2986
2987         Reviewed by Brent Fulgham.
2988
2989         Use separate cache and preferences for each DRT instance.
2990
2991         * DumpRenderTree/win/DumpRenderTree.cpp:
2992         (applicationId):
2993         (setApplicationId):
2994         (setCacheFolder):
2995         (setDefaultsToConsistentValuesForTesting):
2996         * Scripts/webkitpy/port/win.py:
2997         (WinPort.setup_test_run):
2998
2999 2016-10-11  Alex Christensen  <achristensen@webkit.org>
3000
3001         Update API test expectation after r207162.
3002        ​https://bugs.webkit.org/show_bug.cgi?id=162660
3003
3004         * TestWebKitAPI/Tests/WebKit2Cocoa/LoadInvalidURLRequest.mm:
3005         (-[LoadInvalidURLNavigationActionDelegate webView:didFailProvisionalNavigation:withError:]):
3006         Like r207167 but with a WebKit2 test.
3007         "https://www.example.com<>/" was an invalid URL with the old URL parser, is now valid with URLParser but not with NSURL's parser.
3008
3009 2016-10-11  Alex Christensen  <achristensen@webkit.org>
3010
3011         Update API test expectation after r207162.
3012         https://bugs.webkit.org/show_bug.cgi?id=162660
3013
3014         * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.mm:
3015         (-[LoadInvalidURLWebFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
3016         "https://www.example.com<>/" was an invalid URL with the old URL parser.
3017         It is now a valid URL, but NSURL still considers it invalid.
3018         This will be looked into more with https://bugs.webkit.org/show_bug.cgi?id=163127
3019
3020 2016-10-11  Edward O'Connor  <eoconnor@apple.com>
3021
3022         Update my name in contributors.json
3023         https://bugs.webkit.org/show_bug.cgi?id=163251
3024
3025         Reviewed by Simon Fraser.
3026
3027         * Scripts/webkitpy/common/config/contributors.json:
3028
3029 2016-10-11  Said Abou-Hallawa  <sabouhallawa@apple.com>
3030
3031         Add SynchronizedFixedQueue class
3032         https://bugs.webkit.org/show_bug.cgi?id=162478
3033
3034         Reviewed by Geoffrey Garen.
3035
3036         Add a new test for SynchronizedFixedQueue. The test defines a new class
3037         called ToUpperConverter which converts strings from lower case to upper
3038         case. It creates two threads : (1) produce thread and (2) consume thread.
3039         Here is what each thread does:
3040
3041         1. Main threads: Enqueues lower case strings into m_lowerQueue.
3042         2. Produce thread: Dequeues lower case strings from m_lowerQueue and 
3043            enqueue their upper case strings in the m_upperQueue.
3044         3. Consume thread: Dequeues upper case strings from m_upperQueue.
3045
3046         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3047         * TestWebKitAPI/Tests/WTF/SynchronizedFixedQueue.cpp: Added.
3048         (TestWebKitAPI::textItem): A helper function which returns a lower case string given an index.
3049         (TestWebKitAPI::toUpper): A helper function which Returns the upper case of a string.
3050         (TestWebKitAPI::ToUpperConverter::ToUpperConverter):
3051         (TestWebKitAPI::ToUpperConverter::produceQueue): Returns a workQueue for the produce thread.
3052         (TestWebKitAPI::ToUpperConverter::consumeQueue): Returns a workQueue for the consume thread.
3053         (TestWebKitAPI::ToUpperConverter::startProducing): Creates a thread for the producer.
3054         (TestWebKitAPI::ToUpperConverter::startConsuming): Creates a thread for the consumer.
3055         (TestWebKitAPI::ToUpperConverter::start): Starts both the producer and the consumer threads.
3056         (TestWebKitAPI::ToUpperConverter::stopProducing): Terminates the producer thread.
3057         (TestWebKitAPI::ToUpperConverter::stopConsuming): Terminates the consumer thread.
3058         (TestWebKitAPI::ToUpperConverter::stop): Terminates both the producer and the consumer threads.
3059         (TestWebKitAPI::ToUpperConverter::enqueueLower): Adds a lower case string to the m_lowerQueue on the main thread.
3060         (TestWebKitAPI::ToUpperConverter::isProducing): Returns whether the producing thread is active.
3061         (TestWebKitAPI::ToUpperConverter::isConsuming): Returns whether the consuming thread is active.
3062         (TestWebKitAPI::ToUpperConverter::produceCount): Returns the number of produced elements.
3063         (TestWebKitAPI::ToUpperConverter::consumeCount): Returns the number of consumed elements.
3064         (TestWebKitAPI::TEST):
3065
3066 2016-10-11  Megan Gardner  <megan_gardner@apple.com>
3067
3068         Extend event stream to include interpolated events and add a force press test that uses that interpolation
3069         https://bugs.webkit.org/show_bug.cgi?id=163161
3070
3071         Reviewed by Simon Fraser.
3072
3073         Added functionality to the event stream to allow for interpolated events.
3074         Can now do long press, as well as a better way to do drag and other time-based
3075         events that require a large stream of descrete HID events.
3076         Added a basic force touch test to demostrate this interpolation.
3077         Also updated the script to allow for iPhone 7 specific tests, as force touch
3078         needs to be on a device that had force touch.
3079
3080         * Scripts/webkitpy/port/ios.py:
3081         (IOSSimulatorPort):
3082         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3083         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3084         (linearInterpolation):
3085         (simpleCurveInterpolation):
3086         (calculateNextCurveLocation):
3087         (phaseFromString):
3088         (interpolationFromString):
3089         (-[HIDEventGenerator eventMaskFromEventInfo:]):
3090         (-[HIDEventGenerator _createIOHIDEventWithInfo:]):
3091         (-[HIDEventGenerator moveToPoints:touchCount:duration:]):
3092         (-[HIDEventGenerator interpolatedEvents:]):
3093         (-[HIDEventGenerator processEventsArray:withStartTime:]):
3094         (-[HIDEventGenerator eventDispatchThreadEntry:]):
3095         (simpleDragCurve): Deleted.
3096         (calculateNextLocation): Deleted.
3097
3098 2016-10-11  Alex Christensen  <achristensen@webkit.org>
3099
3100         URLParser should percent-encode non-ASCII and non-printable characters in fragment
3101         https://bugs.webkit.org/show_bug.cgi?id=163287
3102
3103         Reviewed by Brady Eidson.
3104
3105         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3106         (TestWebKitAPI::TEST_F):
3107
3108 2016-10-11  Alex Christensen  <achristensen@webkit.org>
3109
3110         Remove dead networking code
3111         https://bugs.webkit.org/show_bug.cgi?id=163263
3112
3113         Reviewed by Daniel Bates.
3114
3115         * DumpRenderTree/DumpRenderTree.h:
3116         * DumpRenderTree/config.h:
3117         * DumpRenderTree/win/DumpRenderTree.cpp:
3118         (main):
3119
3120 2016-10-11  John Wilander  <wilander@apple.com>
3121
3122         Modify check-webkit-style to prohibit sensitive phrases
3123         https://bugs.webkit.org/show_bug.cgi?id=163048
3124         <rdar://problem/28289755>
3125
3126         Terms considered or found to be too general to flag:
3127         ASSERT_WITH_SECURITY_IMPLICATION, bad cast, bug, bypass, crash,
3128         denial of service, dereference, disclosure, error, exploit,
3129         failure, heap, integer overflow, leak, null dereference,
3130         null pointer dereference, out of bounds, overflow,
3131         race condition, sensitive information, stack, type confusion.
3132
3133         Reviewed by Brent Fulgham.
3134
3135         * Scripts/webkitpy/style/checkers/changelog.py:
3136         (ChangeLogChecker.check_entry):
3137             Now calls ChangeLogChecker.check_for_unwanted_security_terms().
3138         (ChangeLogChecker):
3139         (ChangeLogChecker.check_for_unwanted_security_terms):
3140             New function to check for sensitive terms.
3141         (ChangeLogChecker.check_for_unwanted_security_terms.FoundUnwantedSecurityTerm):
3142         (ChangeLogChecker.check_for_unwanted_security_terms.FoundUnwantedSecurityTerm.__init__):
3143             Convenience class.
3144         * Scripts/webkitpy/style/checkers/changelog_unittest.py:
3145         (ChangeLogCheckerTest.test_unwanted_security_terms):
3146
3147 2016-10-11  Ryan Haddad  <ryanhaddad@apple.com>
3148
3149         Unreviewed, rolling out r207067.
3150
3151         This change caused webkitpy test failures.
3152
3153         Reverted changeset:
3154
3155         "[Win] Parallel DRTs are sharing preferences and cache."
3156         https://bugs.webkit.org/show_bug.cgi?id=163013
3157         http://trac.webkit.org/changeset/207067
3158
3159 2016-10-11  Per Arne Vollan  <pvollan@apple.com>
3160
3161         [Win] Parallel DRTs are sharing preferences and cache.
3162         https://bugs.webkit.org/show_bug.cgi?id=163013
3163
3164         Reviewed by Brent Fulgham.
3165
3166         Use separate cache and preferences for each DRT instance.
3167
3168         * DumpRenderTree/win/DumpRenderTree.cpp:
3169         (applicationId):
3170         (setApplicationId):
3171         (setCacheFolder):
3172         (setDefaultsToConsistentValuesForTesting):
3173         * Scripts/webkitpy/port/win.py:
3174         (WinPort.setup_test_run):
3175
3176 2016-10-10  Zan Dobersek  <zdobersek@igalia.com>
3177
3178         Add ENABLE_ENCRYPTED_MEDIA configuration option
3179         https://bugs.webkit.org/show_bug.cgi?id=163219
3180
3181         Reviewed by Darin Adler.
3182
3183         * Scripts/webkitperl/FeatureList.pm:
3184         Make the ENABLE_ENCRYPTED_MEDIA option overridable via build-webkit.
3185         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3186         Add the ENABLE_ENCRYPTED_MEDIA configuration option. It will be used
3187         to enable or disable the new EME implementation at build-time.
3188
3189 2016-10-10  Commit Queue  <commit-queue@webkit.org>
3190
3191         Unreviewed, rolling out r206972.
3192         https://bugs.webkit.org/show_bug.cgi?id=163227
3193
3194         Making EWS flaky (Requested by bfulgham_ on #webkit).
3195
3196         Reverted changeset:
3197
3198         "[CMake] CMake does not support the dep files for implicit
3199         dependency"
3200         https://bugs.webkit.org/show_bug.cgi?id=161433
3201         http://trac.webkit.org/changeset/206972
3202
3203 2016-10-10  Youenn Fablet  <youenn@apple.com>
3204
3205         W3C test downloader should be able to import specific files/sub-directories in a skipped directory
3206         https://bugs.webkit.org/show_bug.cgi?id=161789
3207
3208         Reviewed by Ryosuke Niwa.
3209
3210         Removed tests_directory option and corresponding test.
3211         This option was allowing to import a sub-directory from a test repository.
3212         We can readd it if necessary.
3213
3214         Adding support for finer-grained import rules.
3215         Previously skipped directories were fully removed.
3216         Now, directories may be skipped but sub directories of them may be imported.
3217         This currently happens in web-platform-tests repo.
3218
3219         * Scripts/webkitpy/w3c/test_downloader.py:
3220         (TestDownloader._add_test_suite_paths): Removing tests_directory option.
3221         (TestDownloader.copy_tests): Refactoring file copy by generating the list of all directories for which direct files should be imported.
3222         (TestDownloader.copy_tests.should_copy_dir):
3223         (TestDownloader.copy_tests.should_copy_file):
3224         * Scripts/webkitpy/w3c/test_importer_unittest.py:
3225         (TestImporterTest.test_tests_directory): Deleted.
3226         (TestImporterTest.test_skip_test_import): Added.
3227
3228 2016-10-09  Simon Fraser  <simon.fraser@apple.com>
3229
3230         Make validate-committer-lists show inactive reviewers
3231         https://bugs.webkit.org/show_bug.cgi?id=163193
3232
3233         Reviewed by Sam Weinig.
3234         
3235         In preparation for updating contributors.json with the WebKit policy of retiring
3236         inactive reviewers, make validate-committer-lists show the list of reviewers who
3237         have not reviewed in the past year.
3238         
3239         This list is computed by grepping the output of 'git log --since=1.year" for
3240         the reviewer line, and looking up reviewers via Contributor.mentioned_in_text(),
3241         which looks for full names, aliases, irc nicks and email addresses.
3242         
3243         Support for aliases is added to Contributor. Aliases are alternates
3244         or misspellings of the reviewer's name. Some common aliases were added to
3245         contributors.json by manual examination of "Reviewed by" lines.
3246
3247         * Scripts/validate-committer-lists:
3248         (CommitterListFromGit.possibly_expired_committers):
3249         (CommitterListFromGit):
3250         (CommitterListFromGit.possibly_inactive_reviewers):
3251         (CommitterListFromGit.print_possibly_expired_committers):
3252         (CommitterListFromGit.print_possibly_inactive_reviewers):
3253         * Scripts/webkitpy/common/config/committers.py:
3254         (Contributor.__init__):
3255         (Contributor.contains_string):
3256         (Contributor.mentioned_in_text):
3257         (Contributor.as_dict):
3258         (Committer.__init__):
3259         (Reviewer.__init__):
3260         (CommitterList.load_json):
3261         * Scripts/webkitpy/common/config/contributors.json:
3262
3263 2016-10-09  Simon Fraser  <simon.fraser@apple.com>
3264
3265         Convert contributors.json to a flat list
3266         https://bugs.webkit.org/show_bug.cgi?id=163183
3267
3268         Reviewed by Darin Adler.
3269         
3270         Make contributors.json easier to maintain by eliminating the big groupings ("Committers", "Reviewers" etc)
3271         and moving that data to a "status" property on each contributor.
3272
3273         * Scripts/webkitpy/common/config/committers.py:
3274         (Contributor.__eq__): Implement this to fix unit tests, now that load_json() is not @memoized.
3275         (Contributor.as_dict): Include status in the dict.
3276         (CommitterList.__init__): Clean up to make the testing code path more explicit.
3277         (CommitterList.load_json):
3278         (CommitterList.load_test_data):
3279         (CommitterList.as_json):
3280         (Contributor.__unicode__): Deleted.
3281         * Scripts/webkitpy/common/config/contributors.json:
3282         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
3283         (IRCCommandTest.test_whois): The ordering here is now alphabetical.
3284
3285 2016-10-09  Fujii Hironori  <Hironori.Fujii@sony.com>
3286
3287         [CMake] CMake does not support the dep files for implicit dependency
3288         https://bugs.webkit.org/show_bug.cgi?id=161433
3289
3290         Reviewed by Brent Fulgham.
3291
3292         Created a Perl script to generate all IDL bindings for CMake.
3293         This script can regenerate outdated bindings by based on the
3294         supplemental dependency and dep files created by
3295         '--write-dependencies' switch of generate-bindings.pl.
3296
3297         add_custom_target is used to invoke the script instead of
3298         add_custom_command because Ninja deletes all output files before
3299         executing the command in case of add_custom_command.
3300
3301         USES_TERMINAL option of add_custom_target has two effects:
3302         1) Not buffering output of the command
3303         2) Invoking the command in the special Ninja pool which inhibits parallel build
3304         One needs to use CMake 3.2 or later to enable this feature.
3305
3306         * DumpRenderTree/CMakeLists.txt: Specified a target name for
3307         GENERATE_BINDINGS. Added dependency for the target.
3308         * WebKitTestRunner/CMakeLists.txt: Ditto.
3309
3310 2016-10-09  Simon Fraser  <simon.fraser@apple.com>
3311
3312         Add support for canonicalizing contributors.json, and have check-webkit-style check the format.
3313         https://bugs.webkit.org/show_bug.cgi?id=163177
3314
3315         Follow-up fix.
3316         
3317         For unknown reasons, overriding Commiter.__dict__() caused mysterious test failures.
3318         Rename it to as_dict().
3319
3320         * Scripts/webkitpy/common/config/committers.py:
3321         (Contributor.as_dict):
3322         (CommitterList._contributor_list_to_dict):
3323         (Contributor.__dict__): Deleted.
3324
3325 2016-10-08  Simon Fraser  <simon.fraser@apple.com>
3326
3327         Add support for canonicalizing contributors.json, and have check-webkit-style check the format.
3328         https://bugs.webkit.org/show_bug.cgi?id=163177
3329
3330         Reviewed by Ryosuke Niwa.
3331         
3332         Make it possible to round-trip contributors.json through CommitterList, so we can
3333         support writing out contributors.json in canonical format. This requires saving
3334         the case-preserved email and expertise in Contributor. CommitterList also needs
3335         to be able to generate the "exclusive" lists, since it currently uses lists
3336         that are the union of, say, committers and reviewers.
3337         
3338         If contributors.json is malformed (invalid JSON), catch the Exception, report it
3339         and exit rather than allowing the exception to propagate. With an invalid file,
3340         an exception would be thrown before the JSON style checker reached this file, so
3341         the error was not correctly reported.
3342         
3343         Add style/checker/committer.py for checking that committers.json has the canonical format.
3344         
3345         Add support to validate-committer-lists to dump out the canonical json (-d) or update
3346         the file in-place (-c).
3347
3348         * Scripts/validate-committer-lists:
3349         (CommitterListFromGit._print_three_column_row):
3350         (CommitterListFromGit.possibly_expired_committers):
3351         (CommitterListFromGit):
3352         (CommitterListFromGit.print_possibly_expired_committers):
3353         (main):
3354         * Scripts/webkitpy/common/config/committers.py:
3355         (Contributor.__init__):
3356         (Contributor.__dict__):
3357         (Committer.__init__):
3358         (Reviewer.__init__):
3359         (CommitterList.load_json):
3360         (CommitterList):
3361         (CommitterList._contributor_list_to_dict):
3362         (CommitterList.as_json):
3363         (CommitterList.reformat_in_place):
3364         (CommitterList._exclusive_contributors):
3365         (CommitterList._exclusive_committers):
3366         (Contributor.matches_glob): Deleted.
3367         (CommitterList.contributors): Deleted.
3368         * Scripts/webkitpy/common/config/contributors.json:
3369         * Scripts/webkitpy/style/checker.py:
3370         (CheckerDispatcher._create_checker):
3371         * Scripts/webkitpy/style/checkers/contributors.py: Added.
3372         (ContributorsChecker):
3373         (ContributorsChecker.__init__):
3374         (ContributorsChecker.check):
3375         (ContributorsChecker._unidiff_output):
3376
3377 2016-10-06  Darin Adler  <darin@apple.com>
3378
3379         Next step on moving to modern way to return DOM exceptions
3380         https://bugs.webkit.org/show_bug.cgi?id=163016
3381
3382         Reviewed by Ryosuke Niwa.
3383
3384         * Scripts/do-webcore-rename: Add proposed name change of setDOMException
3385         to propagateException, since this function is primarily used to take an
3386         exception already effectively "thrown" by setting an ExceptionCode out
3387         argument and propagate it into the JavaScript engine's exception machinery.
3388
3389 2016-10-07  Alex Christensen  <achristensen@webkit.org>
3390
3391         Non-special URL fragments should percent-encode non-ASCII characters
3392         https://bugs.webkit.org/show_bug.cgi?id=163153
3393
3394         Reviewed by Tim Horton.
3395
3396         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3397         (TestWebKitAPI::TEST_F):
3398
3399 2016-10-07  Jonathan Bedard  <jbedard@apple.com>
3400
3401         Build fix for “Move functionality common to Darwin ports into a base class”
3402         https://bugs.webkit.org/show_bug.cgi?id=160709
3403
3404         Unreviewed build fix.
3405
3406         * Scripts/webkitpy/port/ios.py:
3407         (IOSSimulatorPort._get_crash_log): Added iOS implementation.
3408         * Scripts/webkitpy/port/mac.py:
3409         (MacPort._get_crash_log): Added Mac implementation.
3410
3411 2016-10-07  Chelsea Pugh  <cpugh@apple.com>
3412
3413         Unreviewed. Added myself to the list of committers.
3414
3415         * Scripts/webkitpy/common/config/contributors.json:
3416
3417 2016-10-07  Jonathan Bedard  <jbedard@apple.com>
3418
3419         Move functionality common to Darwin ports into a base class
3420         https://bugs.webkit.org/show_bug.cgi?id=160709
3421
3422         Reviewed by Darin Adler.
3423
3424         * Scripts/webkitpy/port/apple.py:
3425         (ApplePort.determine_full_port_name): Specific iOS port check.
3426         (ApplePort.__init__): Move leak detector to DarwinPort.
3427         (ApplePort._make_leak_detector): Moved to DarwinPort.
3428         (ApplePort.supports_per_test_timeout): Moved to Port.
3429         (ApplePort.check_for_leaks): Moved to DarwinPort.
3430         (ApplePort.print_leaks_summary): Moved to DarwinPort.
3431         (ApplePort._path_to_webcore_library): Moved to DarwinPort.
3432         (ApplePort.show_results_html_file): Moved to DarwinPort.
3433         (ApplePort._merge_crash_logs): Moved to DarwinPort.
3434         (ApplePort._look_for_all_crash_logs_in_log_dir): Moved to DarwinPort.
3435         (ApplePort._get_crash_log): Moved to DarwinPort.
3436         (ApplePort.look_for_new_crash_logs): Moved to DarwinPort.
3437         (ApplePort.sample_process): Moved to DarwinPort.
3438         (ApplePort.sample_file_path): Moved to DarwinPort.
3439         (ApplePort.look_for_new_samples): Moved to DarwinPort.
3440         * Scripts/webkitpy/port/base.py:
3441         (Port.supports_per_test_timeout): Return true for all ports.
3442         * Scripts/webkitpy/port/darwin.py: Added.
3443         (DarwinPort): Shared iOS and Mac functions.
3444         * Scripts/webkitpy/port/darwin_testcase.py: Added.
3445         (DarwinTest): Shared iOS and Mac testing.
3446         * Scripts/webkitpy/port/efl.py:
3447         (EflPort):
3448         (EflPort.supports_per_test_timeout): Moved to Port.
3449         * Scripts/webkitpy/port/gtk.py:
3450         (GtkPort._driver_class):
3451         (GtkPort):
3452         (GtkPort.supports_per_test_timeout): Moved to Port.
3453         * Scripts/webkitpy/port/ios.py:
3454         (IOSPort):
3455         (IOSPort.operating_system):
3456         (IOSSimulatorPort):
3457         (IOSSimulatorPort.__init__): Inherits from DarwinPort.
3458         (IOSSimulatorPort._port_specific_expectations_files): Moved to DarwinPort.
3459         (IOSSimulatorPort._get_crash_log): Deleted.
3460         (IOSSimulatorPort.xcrun_find): Deleted.
3461         * Scripts/webkitpy/port/ios_unittest.py: Added.
3462         (iosTest): Unit tests for the iOS port.
3463         * Scripts/webkitpy/port/mac.py:
3464         (MacPort):
3465         (MacPort.__init__): Inherits from DarwinPort.
3466         (MacPort._port_specific_expectations_files): Moved to DarwinPort.
3467         (MacPort.make_command): Moved to DarwinPort.
3468         (MacPort._get_crash_log): Moved to DarwinPort.
3469         (MacPort.nm_command): Moved to DarwinPort.
3470         * Scripts/webkitpy/port/mac_unittest.py:
3471         (MacTest):
3472         (MacTest.test_sdk_name): Added test.
3473         (MacTest.test_xcrun): Added test.
3474         (MacTest.assert_skipped_file_search_paths): Moved to DarwinTest.
3475         (MacTest.test_default_timeout_ms): Moved to DarwinTest.
3476         (MacTest.assert_name): Moved to DarwinTest.
3477         (MacTest.test_helper_starts): Moved to DarwinTest.
3478         (MacTest.test_helper_fails_to_start): Moved to DarwinTest.
3479         (MacTest.test_helper_fails_to_stop): Moved to DarwinTest.
3480         (MacTest.test_spindump): Moved to DarwinTest.
3481         (MacTest.test_sample_process): Moved to DarwinTest.
3482         (MacTest.test_sample_process_exception): Moved to DarwinTest.
3483         * Scripts/webkitpy/port/port_testcase.py:
3484         (PortTestCase):
3485         (PortTestCase.test_diff_image): Added is_simulator flag.
3486         (PortTestCase.test_diff_image): Skip test if on a simulator.
3487         (PortTestCase.test_diff_image_crashed): Skip test if on a simulator.
3488         * Scripts/webkitpy/port/win.py:
3489         (WinPort):
3490         (WinPort.look_for_new_samples): Used default, ApplePort no longer implements.
3491         (WinPort.sample_process): Ditto.
3492         (WinPort._make_leak_detector): Ditto.
3493         (WinPort.check_for_leaks): Ditto.
3494         (WinPort.print_leaks_summary): Ditto.
3495         (WinPort._path_to_webcore_library): Ditto.
3496
3497 2016-10-07  Anders Carlsson  <andersca@apple.com>
3498
3499         Get rid of WKPageSetSession
3500         https://bugs.webkit.org/show_bug.cgi?id=163129
3501
3502         Reviewed by Tim Horton.
3503
3504         Rewrite this test to use WKPageConfigurationRef and WKWebsiteDataStoreRef.
3505
3506         * TestWebKitAPI/Tests/WebKit2/EphemeralSessionPushStateNoHistoryCallback.cpp:
3507         (TestWebKitAPI::TEST):
3508
3509 2016-10-07  Andreas Kling  <akling@apple.com>
3510
3511         [WK2] didRemoveFrameFromHierarchy callback doesn't fire for subframes when evicting from PageCache.
3512         <https://webkit.org/b/163098>
3513         <rdar://problem/28663488>
3514
3515         Reviewed by Antti Koivisto.
3516
3517         Add an API test that puts a 10-subframe page into the page cache, then loads other pages
3518         until the first page gets kicked out. The test succeeds if we receive didRemoveFrameFromHierarchy
3519         callbacks for all the subframes.
3520
3521         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3522         * TestWebKitAPI/Tests/WebKit2/DidRemoveFrameFromHiearchyInPageCache.cpp: Added.
3523         (TestWebKitAPI::didFinishLoadForFrame):
3524         (TestWebKitAPI::setPageLoaderClient):
3525         (TestWebKitAPI::didReceivePageMessageFromInjectedBundle):
3526         (TestWebKitAPI::setInjectedBundleClient):
3527         (TestWebKitAPI::TEST):
3528         * TestWebKitAPI/Tests/WebKit2/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp: Added.
3529         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
3530         (TestWebKitAPI::DidRemoveFrameFromHiearchyInPageCacheTest::DidRemoveFrameFromHiearchyInPageCacheTest):
3531         (TestWebKitAPI::DidRemoveFrameFromHiearchyInPageCacheTest::didCreatePage):
3532         * TestWebKitAPI/Tests/WebKit2/many-iframes.html: Added.
3533
3534 2016-10-07  Emanuele Aina  <emanuele.aina@collabora.com>
3535
3536         Replace bug URL placeholders independently of the short desc one
3537         https://bugs.webkit.org/show_bug.cgi?id=161684
3538
3539         Reviewed by Darin Adler.
3540
3541         Instead of adding the bug URL when replacing the short description
3542         placeholder and then ignoring the bug URL placeholder, use the former
3543         to set the short description and the latter for the bug URL.
3544         This means that developers can fully prepare the changelog with short
3545         and long description before submission leaving the bug placeholder in
3546         place, and the changelog machinery will make sure to replace the
3547         latter with the URL of the newly created bug while submitting.
3548
3549         Note that this also means that the short description placeholder alone
3550         no longer causes the bug URL to be added.
3551
3552         * Scripts/webkitpy/common/checkout/changelog.py:
3553         (ChangeLog.set_short_description_and_bug_url):
3554         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3555         (test_set_short_description_and_bug_url):
3556
3557 2016-10-07  Jonathan Bedard  <jbedard@apple.com>
3558
3559         Style Checking Error when Objective C Blocks passed as Argument
3560         https://bugs.webkit.org/show_bug.cgi?id=162463
3561
3562         Reviewed by Darin Adler.
3563
3564         * Scripts/webkitpy/style/checkers/cpp.py:
3565         (regex_for_lambdas_and_blocks): Consider case where block is passed as a function argument.
3566         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3567         (CppStyleTest.test_objective_c_block_as_argument): Test case where block is passed as a function argument. 
3568
3569 2016-10-07  Philippe Normand  <pnormand@igalia.com>
3570
3571         [GTK] Docs build failure
3572         https://bugs.webkit.org/show_bug.cgi?id=163102
3573
3574         Reviewed by Carlos Garcia Campos.
3575
3576         * gtk/jhbuild.modules: Bump to gtk-doc 1.25 to fix build errors on Debian Testing.
3577
3578 2016-10-06  Joseph Pecoraro  <pecoraro@apple.com>
3579
3580         check-webkit-style: Enable the legal/copyright rule for cpp/h files
3581         https://bugs.webkit.org/show_bug.cgi?id=162707
3582
3583         Reviewed by Darin Adler.
3584
3585         * Scripts/webkitpy/style/checker.py:
3586         Enable this rule by default.
3587
3588 2016-10-06  Joseph Pecoraro  <pecoraro@apple.com>
3589
3590         Header guard style should be updated to be "#pragma once"
3591         https://bugs.webkit.org/show_bug.cgi?id=159785
3592
3593         Reviewed by Darin Adler.
3594
3595         * Scripts/webkitpy/style/checkers/cpp.py:
3596         (check_for_header_guard):
3597         (_process_lines):
3598         Simplify header_guard check to warn for a missing #pragma once
3599         in header files. For legacy files that contain an #ifndef only
3600         warn if the #ifndef line itself is changing.
3601
3602         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3603         (CppStyleTestBase.perform_header_guard_check):
3604         (CppStyleTestBase.assert_header_guard):
3605         Helpers for enabling just this warning.
3606
3607         (CppStyleTest.test_build_header_guard):
3608         Test different header guard cases.
3609
3610         * Scripts/webkitpy/style/error_handlers.py:
3611         (DefaultStyleErrorHandler.should_line_be_checked):
3612         Always allow warnings that output for "line 0" which won't be in
3613         the list of modified lines that are 1-based.
3614
3615 2016-10-06  Commit Queue  <commit-queue@webkit.org>
3616
3617         Unreviewed, rolling out r206713.
3618         https://bugs.webkit.org/show_bug.cgi?id=163097
3619
3620         triggers apparent codegen bug on ARM 32-bit (Requested by smfr
3621         on #webkit).
3622
3623         Reverted changeset:
3624
3625         "Support transitions/animations of background-position with
3626         right/bottom-relative values"
3627         https://bugs.webkit.org/show_bug.cgi?id=162048
3628         http://trac.webkit.org/changeset/206713
3629
3630 2016-10-06  Alex Christensen  <achristensen@webkit.org>
3631
3632         URLParser: Non-ASCII characters in Non-UTF-8 encoded queries of relative URLs with ws, wss, or nonspecial schemes should be UTF-8 encoded
3633         https://bugs.webkit.org/show_bug.cgi?id=163089
3634
3635         Reviewed by Tim Horton.
3636
3637         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3638         (TestWebKitAPI::checkURL):
3639         (TestWebKitAPI::TEST_F):
3640
3641 2016-10-06  Alex Christensen  <achristensen@webkit.org>
3642
3643         Skip tabs and newlines between end of query and beginning of fragment in non-UTF-8-encoded URLs
3644         https://bugs.webkit.org/show_bug.cgi?id=163071
3645
3646         Reviewed by Tim Horton.
3647
3648         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3649         (TestWebKitAPI::TEST_F):
3650
3651 2016-10-06  Alex Christensen  <achristensen@webkit.org>
3652
3653         URLParser should parse file URLs with ports consistently
3654         https://bugs.webkit.org/show_bug.cgi?id=163075
3655
3656         Reviewed by Brady Eidson.
3657
3658         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3659         (TestWebKitAPI::TEST_F):
3660
3661 2016-10-06  John Wilander  <wilander@apple.com>
3662
3663         Update Resource Load Statistics
3664         https://bugs.webkit.org/show_bug.cgi?id=162811
3665
3666         Reviewed by Alex Christensen.
3667
3668         * TestWebKitAPI/Tests/mac/PublicSuffix.mm:
3669             Change from USE(PUBLIC_SUFFIX_LIST) to ENABLE(PUBLIC_SUFFIX_LIST)
3670
3671 2016-10-05  Philippe Normand  <pnormand@igalia.com>
3672
3673         [GStreamer][OWR] GL rendering support
3674         https://bugs.webkit.org/show_bug.cgi?id=162972
3675
3676         Reviewed by Žan Doberšek.
3677
3678         When GStreamer-GL is enabled the GL context needs to be properly passed
3679         to the GStreamer pipeline running within the OpenWebRTC video renderer.
3680         This is now supported using a new OpenWebRTC API that allows the
3681         renderer to request the context from the application using a callback
3682         registered within the renderer.
3683
3684         * gtk/jhbuild.modules: Bump to latest OpenWebRTC for the new
3685         owr_video_renderer_set_request_context_callback API added
3686         recently.
3687
3688 2016-10-05  Youenn Fablet  <youenn@apple.com>
3689
3690         Reuse CodeGenerator::UpdateFile in Tools CodeGenerator
3691         https://bugs.webkit.org/show_bug.cgi?id=162960
3692
3693         Reviewed by Alex Christensen.
3694
3695         * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm:
3696         (WriteData): Using CodeGenerator::UpdateFile to do lazy generated file update when it is made feasible.
3697         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
3698         (WriteData): Ditto.
3699
3700 2016-10-05  Alex Christensen  <achristensen@webkit.org>
3701
3702         URLParser should parse IPv4 addresses as the last two pieces of an IPv6 address
3703         https://bugs.webkit.org/show_bug.cgi?id=162991
3704
3705         Reviewed by Saam Barati.
3706
3707         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3708         (TestWebKitAPI::TEST_F):
3709
3710 2016-10-05  Tim Horton  <timothy_horton@apple.com>
3711
3712         Avoid automatically re-taking snapshots for back-forward items that were never loaded into the view
3713         https://bugs.webkit.org/show_bug.cgi?id=162955
3714         <rdar://problem/27659173>
3715
3716         Reviewed by Simon Fraser.
3717
3718         * TestWebKitAPI/Tests/WebKit2Cocoa/SnapshotStore.mm:
3719         (-[SnapshotTestWKWebView init]):
3720         (forceRepaintCallback):
3721         (-[SnapshotTestWKWebView synchronouslyForceRepaint]):
3722         (-[SnapshotTestWKWebView synchronouslyLoadTestPageAndForceRepaint:]):
3723         (TEST):
3724         (makeRedSquareView):
3725         Add a test that restoring session state into a web view without navigating,
3726         then explicitly snapshotting and navigating away, leaves the original snapshot alone.
3727
3728         Adjust the existing test, as well, to ensure that it will reliably fail
3729         if the feature is broken. Use an explicitly added and removed red square
3730         instead of scrolling, because we can't scroll in the restore-without-navigating case.
3731
3732         Stop trying to override the window scale, because it's not working (we're getting partial snapshots)
3733         and isn't necessary; instead just multiply the expected value by the page scale.
3734
3735         (-[SnapshotTestWKWebView loadPageNamed:]): Deleted.
3736         * TestWebKitAPI/mac/TestWKWebViewMac.h:
3737         * TestWebKitAPI/mac/TestWKWebViewMac.mm:
3738         (-[TestWKWebView synchronouslyLoadTestPageNamed:]):
3739         Reorganize to reduce duplication.
3740
3741 2016-10-05  Tim Horton  <timothy_horton@apple.com>
3742
3743         Make it possible to test ViewSnapshotStore behaviors
3744         https://bugs.webkit.org/show_bug.cgi?id=162983
3745
3746         Reviewed by Simon Fraser.
3747
3748         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3749         * TestWebKitAPI/Tests/WebKit2Cocoa/SnapshotStore.mm: Added.
3750         (-[SnapshotTestWKWebView init]):
3751         (-[SnapshotTestWKWebView loadPageNamed:]):
3752         (imagesAreEqual):
3753         Add tests for existing basic snapshotting behavior:
3754
3755         - a back-forward item shouldn't have a snapshot
3756           until it is navigated away from
3757
3758         - causing a back-forward item to fall out of the
3759           back-forward list should remove the snapshot
3760
3761         - calling the explicit snapshotting SPI, then navigating away from the page,
3762           should result in the snapshot being retaken
3763
3764 2016-10-05  Chris Dumez  <cdumez@apple.com>
3765
3766         KeyboardEvent.getModifierState() should support "CapsLock" modifier
3767         https://bugs.webkit.org/show_bug.cgi?id=162861
3768
3769         Reviewed by Darin Adler.
3770
3771         Add support for 'capsLockKey' modifier for EventSender.keyDown() so
3772         that we can test this new modifier support for layout tests.
3773
3774         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3775         (TestWebKitAPI::modifierFlagsForWKModifiers):
3776         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3777         (WTR::parseModifier):
3778         * WebKitTestRunner/mac/EventSenderProxy.mm:
3779         (WTR::buildModifierFlags):
3780
3781 2016-10-05  Jeremy Jones  <jeremyj@apple.com>
3782
3783         Add MobileMiniBrowser tests for control center and looping fullscreen.
3784         https://bugs.webkit.org/show_bug.cgi?id=162748
3785
3786         Reviewed by Jer Noble.
3787
3788         Refactor existing MobileMiniBrowserTests and add new tests for 
3789         - fullscreen rotation
3790         - fullscreen looping (failing)
3791         - control center interruption (failing)
3792
3793         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
3794         * MobileMiniBrowser/MobileMiniBrowserFramework/Resources/looping2s.html: Added.
3795         * MobileMiniBrowser/MobileMiniBrowserFramework/test2s.mp4: Added.
3796         * MobileMiniBrowser/MobileMiniBrowserUITests/MobileMiniBrowserUITests.m:
3797         (-[MobileMiniBrowserUITests setUp]):
3798         (-[MobileMiniBrowserUITests waitToTapButtonNamed:forApp:]):
3799         (-[MobileMiniBrowserUITests loadURL:]):
3800         (-[MobileMiniBrowserUITests requireMinFPS:sampleDurationSeconds:message:]):
3801         (-[MobileMiniBrowserUITests ensureFullscreenControls]):
3802         (-[MobileMiniBrowserUITests timeForTimeString:]):
3803         (-[MobileMiniBrowserUITests testBasicVideoPlayback]):
3804         (-[MobileMiniBrowserUITests testBasicVideoFullscreen]):
3805         (-[MobileMiniBrowserUITests testVideoFullscreenAndRotationAnimation]):
3806         (-[MobileMiniBrowserUITests testVideoFullscreenControlCenter]):
3807         (-[MobileMiniBrowserUITests testLoopingFullscreenLockup]):
3808
3809 2016-10-05  Alex Christensen  <achristensen@webkit.org>
3810
3811         URLParser should correctly strip unnecessary 0's in IPv6 addresses
3812         https://bugs.webkit.org/show_bug.cgi?id=162979
3813
3814         Reviewed by Brady Eidson.
3815
3816         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3817         (TestWebKitAPI::TEST_F):
3818
3819 2016-10-05  Alex Christensen  <achristensen@webkit.org>
3820
3821         UTF-8 encode queries of nonspecial and websocket schemes
3822         https://bugs.webkit.org/show_bug.cgi?id=162956
3823
3824         Reviewed by Geoffrey Garen and Brady Eidson.
3825
3826         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3827         (TestWebKitAPI::TEST_F):
3828
3829 2016-10-05  Alex Christensen  <achristensen@webkit.org>
3830
3831         Prepare to enable URLParser
3832         https://bugs.webkit.org/show_bug.cgi?id=162974
3833
3834         Reviewed by Brady Eidson.
3835
3836         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3837         (TestWebKitAPI::TEST_F):
3838         Added some tests that are unrelated to the code change, but these are
3839         reflected in changed LayoutTest results when enabling the URLParser,
3840         and they weren't in the URLParser tests yet.  They should be.
3841
3842 2016-10-05  Zan Dobersek  <zdobersek@igalia.com>
3843
3844         Rename ENABLE_ENCRYPTED_MEDIA_V2 to ENABLE_LEGACY_ENCRYPTED_MEDIA
3845         https://bugs.webkit.org/show_bug.cgi?id=162903
3846
3847         Reviewed by Alex Christensen.
3848
3849         Rename build guards for the remaining implementation of the legacy EME API
3850         to ENABLE_LEGACY_ENCRYPTED_MEDIA. This will allow for the future implementation
3851         of the near-finished API to be guarded with the simple ENABLE_ENCRYPTED_MEDIA guards.
3852
3853         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Also remove the
3854         ENABLE_IOS_TEXT_AUTOSIZING feature define that was renamed in r206395 and was
3855         throwing up style checker errors.
3856
3857 2016-10-04  Andy Estes  <aestes@apple.com>
3858
3859         [iOS] Crash in WebResourceLoaderQuickLookDelegate when the client cancels the navigation to a QuickLook resource
3860         https://bugs.webkit.org/show_bug.cgi?id=162950
3861         <rdar://problem/23759114>
3862
3863         Reviewed by Brady Eidson.
3864
3865         Added a new API test.
3866
3867         * TestWebKitAPI/Tests/WebKit2Cocoa/QuickLook.mm: Sorted imports and removed redundant
3868         initialization of static bools.
3869         (runTest): Factored out the common test logic between QuickLook.NavigationDelegate and
3870         QuickLook.CancelNavigationAfterResponse.
3871         (TEST): Added QuickLook.CancelNavigationAfterResponse.
3872         (-[QuickLookDecidePolicyDelegate
3873         webView:decidePolicyForNavigationResponse:decisionHandler:]): Canceled the navigation.
3874         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Set
3875         isDone to true.
3876
3877 2016-10-04  Ryosuke Niwa  <rniwa@webkit.org>
3878
3879         Add the support for running ES6SampleBench to run-benchmark
3880         https://bugs.webkit.org/show_bug.cgi?id=162890
3881
3882         Reviewed by Saam Barati.
3883
3884         Added the support for running ES6SampleBench as "es6bench".
3885         e.g. ./Tools/Scripts/run-benchmark --platform osx --plan es6bench --browser safari
3886
3887         Instead of the default 10 iterations, run the test 4 iterations using 5 instances of browser
3888         for the total of 20 iterations.
3889
3890         * Scripts/webkitpy/benchmark_runner/data/patches/ES6SampleBench.patch: Added.
3891         * Scripts/webkitpy/benchmark_runner/data/plans/es6bench.plan: Added.
3892         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
3893         (start): Fixed the bug that the linter will complain about the presence of "debugOutput" by
3894         removing it if it's present.
3895
3896 2016-10-04  Simon Fraser  <simon.fraser@apple.com>
3897
3898         [iOS WK2] Make it possible for a test to describe a user gesture as a stream of events in JSON format
3899         https://bugs.webkit.org/show_bug.cgi?id=162934
3900
3901         Reviewed by Dean Jackson.
3902
3903         With this change, a test can describe a user gesture in an "event stream", which is
3904         some JSON describing an array of events with their underlying touches. The added
3905         test describes a single tap.
3906         
3907         The implementation fires up an NSThread, and sleeps the thread between events to dispatch
3908         them at close to real time.
3909         
3910         In future, HIDEventGenerator could use this internally for all of the "compound" interactions.
3911
3912         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3913         (WTR::UIScriptController::sendEventStream):
3914         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3915         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3916         (WTR::UIScriptController::sendEventStream):
3917         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3918         * WebKitTestRunner/ios/HIDEventGenerator.h:
3919         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3920         (transducerTypeFromString):
3921         (phaseFromString):
3922         (-[HIDEventGenerator eventMaskFromEventInfo:]):
3923         (-[HIDEventGenerator touchFromEventInfo:]):
3924         (-[HIDEventGenerator _createIOHIDEventWithInfo:]):
3925         (-[HIDEventGenerator dispatchEventWithInfo:]):
3926         (-[HIDEventGenerator eventDispatchThreadEntry:]):
3927         (-[HIDEventGenerator sendEventStream:completionBlock:]):
3928         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3929         (WTR::UIScriptController::sendEventStream):
3930
3931 2016-10-04  Megan Gardner  <megan_gardner@apple.com>
3932
3933         Add Megan to contributor's list
3934         https://bugs.webkit.org/show_bug.cgi?id=162944
3935
3936         Reviewed by Tim Horton.
3937
3938         Add Megan to the contributor's lists so that her e-mail autocompletes for CC
3939
3940         * Scripts/webkitpy/common/config/contributors.json:
3941
3942 2016-10-04  Alex Christensen  <achristensen@webkit.org>
3943
3944         Add tests verifying non-special URL hosts are parsed according to spec
3945         https://bugs.webkit.org/show_bug.cgi?id=162885
3946
3947         Reviewed by Sam Weinig.
3948
3949         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3950         (TestWebKitAPI::TEST_F):
3951
3952 2016-10-04  Anders Carlsson  <andersca@apple.com>
3953
3954         Properly kill web processes in the launching state
3955         https://bugs.webkit.org/show_bug.cgi?id=162938
3956
3957         Reviewed by Tim Horton.
3958
3959         * TestWebKitAPI/Tests/WebKit2/TerminateTwice.cpp:
3960         Enable this test again.
3961
3962 2016-10-04  Alex Christensen  <achristensen@webkit.org>
3963
3964         URLParser: query-only URLs relative to file URLs should just add a query
3965         https://bugs.webkit.org/show_bug.cgi?id=162888
3966
3967         Reviewed by Tim Horton.
3968
3969         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3970         (TestWebKitAPI::TEST_F):
3971
3972 2016-10-04  Alex Christensen  <achristensen@webkit.org>
3973
3974         URLParser should match URL::parse and other browsers when parsing a URL containing only scheme://
3975         https://bugs.webkit.org/show_bug.cgi?id=162909
3976
3977         Reviewed by Tim Horton.
3978
3979         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3980         (TestWebKitAPI::TEST_F):
3981
3982 2016-10-04  Yusuke Suzuki  <utatane.tea@gmail.com>
3983
3984         [DOMJIT] Introduce DOMJIT::GetterSetter to tell JIT information
3985         https://bugs.webkit.org/show_bug.cgi?id=162916
3986
3987         Reviewed by Filip Pizlo.
3988
3989         * DumpRenderTree/CMakeLists.txt:
3990
3991 2016-10-04  Wenson Hsieh  <wenson_hsieh@apple.com>
3992
3993         Media controls are displayed in the incorrect state momentarily after switching between tabs playing media
3994         https://bugs.webkit.org/show_bug.cgi?id=162766
3995         <rdar://problem/28533523>
3996
3997         Reviewed by Jer Noble.
3998
3999         Adds new tests and tweaks existing tests to verify last updated Now Playing information.
4000
4001         * TestWebKitAPI/Tests/WebKit2Cocoa/NowPlayingControlsTests.mm:
4002         (-[NowPlayingTestWebView _handleActiveNowPlayingSessionInfoResponse:title:duration:elapsedTime:]):
4003         (TestWebKitAPI::TEST):
4004         (-[NowPlayingTestWebView _handleActiveNowPlayingSessionInfoResponse:]): Deleted.
4005         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-test-now-playing.html:
4006
4007 2016-10-03  Alex Christensen  <achristensen@webkit.org>
4008
4009         URLParser should ignore tabs at all locations
4010         https://bugs.webkit.org/show_bug.cgi?id=162836
4011
4012         Reviewed by Geoffrey Garen.
4013
4014         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
4015         (TestWebKitAPI::checkURL):
4016         (TestWebKitAPI::checkRelativeURL):
4017         (TestWebKitAPI::checkURLDifferences):
4018         (TestWebKitAPI::checkRelativeURLDifferences):
4019         (TestWebKitAPI::TEST_F):
4020
4021 2016-10-03  Alex Christensen  <achristensen@webkit.org>
4022
4023         URLParser: fragment-only URLs relative to file URLs should just add a fragment
4024         https://bugs.webkit.org/show_bug.cgi?id=162871
4025
4026         Reviewed by Geoffrey Garen.
4027
4028         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
4029         (TestWebKitAPI::TEST_F):
4030
4031 2016-10-03  Per Arne Vollan  <pvollan@apple.com>
4032
4033         [Win] DRT temp folder is not used.
4034         https://bugs.webkit.org/show_bug.cgi?id=162863
4035
4036         Reviewed by Alex Christensen.
4037
4038         Convert DRT temp folder to DOS path, which DRT can use.
4039
4040         * Scripts/webkitpy/port/driver.py:
4041         (Driver._setup_environ_for_driver):
4042
4043 2016-10-03  Alex Christensen  <achristensen@webkit.org>
4044
4045         URLParser: empty relative URLs should not copy fragment from the base URL
4046         https://bugs.webkit.org/show_bug.cgi?id=162864
4047
4048         Reviewed by Chris Dumez.
4049
4050         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
4051         (TestWebKitAPI::TEST_F):
4052
4053 2016-10-03  Carlos Garcia Campos  <cgarcia@igalia.com>
4054
4055         [SOUP] Cleanup persistent credential storage code
4056         https://bugs.webkit.org/show_bug.cgi?id=162777
4057
4058         Reviewed by Alex Christensen.
4059
4060         Use USE(LIBSECRET) instead of ENABLE(CREDENTIAL_STORAGE).
4061
4062         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
4063         (testWebViewAuthenticationStorage):
4064
4065 2016-10-02  Darin Adler  <darin@apple.com>
4066
4067         Rename ExceptionCode-based exception handling to "legacy"
4068         https://bugs.webkit.org/show_bug.cgi?id=162859
4069
4070         Reviewed by Chris Dumez.
4071
4072         * Scripts/do-webcore-rename: Updated script to do this round of renames.
4073
4074 2016-10-02  Wenson Hsieh  <wenson_hsieh@apple.com>
4075
4076         Media controls for Soundcloud easily falls out of sync with what's actually playing
4077         https://bugs.webkit.org/show_bug.cgi?id=162843
4078         <rdar://problem/28176874>
4079
4080         Reviewed by Beth Dakin.
4081
4082         Adds two new tests simulating audio playback behavior on soundcloud. Also tweaks some of the WKWebView test
4083         message handling logic to support having multiple message-handler mappings.
4084
4085         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4086         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
4087         (TestWebKitAPI::TEST):
4088         * TestWebKitAPI/Tests/WebKit2Cocoa/play-audio-on-click.html: Added.
4089         * TestWebKitAPI/mac/TestWKWebViewMac.h:
4090         * TestWebKitAPI/mac/TestWKWebViewMac.mm:
4091         (-[TestMessageHandler addMessage:withHandler:]):
4092         (-[TestMessageHandler userContentController:didReceiveScriptMessage:]):
4093         (-[TestWKWebView performAfterReceivingMessage:action:]):
4094         (-[TestWKWebView performAfterLoading:]):
4095         (-[TestMessageHandler initWithMessage:handler:]): Deleted.
4096
4097 2016-09-30  Alex Christensen  <achristensen@webkit.org>
4098
4099         Fix off-by-one error in URLParser::parseIPv4Host
4100         https://bugs.webkit.org/show_bug.cgi?id=162789
4101
4102         Reviewed by Tim Horton.
4103
4104         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
4105         (TestWebKitAPI::TEST_F):
4106
4107 2016-09-30  Alex Christensen  <achristensen@webkit.org>
4108
4109         URLParser: parsing a URL with an empty host and a colon should fail
4110         https://bugs.webkit.org/show_bug.cgi?id=162795
4111
4112         Reviewed by Tim Horton.
4113
4114         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
4115         (TestWebKitAPI::TEST_F):
4116
4117 2016-09-30  Alex Christensen  <achristensen@webkit.org>
4118
4119         URLParser: handle syntax violations in non-UTF-8 encoded queries
4120         https://bugs.webkit.org/show_bug.cgi?id=162770
4121
4122         Reviewed by Tim Horton.
4123
4124         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
4125         (TestWebKitAPI::checkURL):
4126         (TestWebKitAPI::TEST_F):
4127         Tests with emoji change behavior when we insert a tab between the surrogates, so don't do the
4128         insert-tab-at-each-location verification that syntax violations are handled correctly.
4129
4130 2016-09-30  Megan Gardner  <megan_gardner@apple.com>
4131
4132         Make it possible to test web-related user-interface features
4133         https://bugs.webkit.org/show_bug.cgi?id=162657
4134
4135         Reviewed by Simon Fraser.
4136
4137         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4138         (WTR::UIScriptController::contentsOfUserInterfaceItem):
4139         (WTR::UIScriptController::selectFormAccessoryPickerRow): Deleted.
4140         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4141         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4142         (WTR::UIScriptController::contentsOfUserInterfaceItem):
4143         (WTR::UIScriptController::selectFormAccessoryPickerRow): Deleted.
4144         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4145         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4146         (WTR::UIScriptController::contentsOfUserInterfaceItem):
4147         (WTR::UIScriptController::selectFormAccessoryPickerRow): Deleted.
4148
4149 2016-09-29  Jiewen Tan  <jiewen_tan@apple.com>
4150
4151         Expose CryptoKey to web workers
4152         https://bugs.webkit.org/show_bug.cgi?id=162640
4153         <rdar://problem/28182204>
4154
4155         Reviewed by Brent Fulgham.
4156
4157         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4158         * TestWebKitAPI/Tests/WebCore/SerializedCryptoKeyWrap.mm: Added.
4159         (TestWebKitAPI::TEST_F):
4160         Add API tests for SerializedCryptoKeyWrap APIs.
4161
4162 2016-09-29  Alex Christensen  <achristensen@webkit.org>
4163
4164         Fix syntax violation handling in IPv4 address parsing
4165         https://bugs.webkit.org/show_bug.cgi?id=162756
4166
4167         Reviewed by Tim Horton.
4168
4169         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
4170         (TestWebKitAPI::TEST_F):
4171
4172 2016-09-29  Alex Christensen  <achristensen@webkit.org>
4173
4174         URLParser should correctly parse ports with leading 0's
4175         https://bugs.webkit.org/show_bug.cgi?id=162752
4176
4177         Reviewed by Tim Horton.
4178
4179         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
4180         (TestWebKitAPI::TEST_F):
4181
4182 2016-09-29  Alex Christensen  <achristensen@webkit.org>
4183
4184         URLParser: make parsing invalid IPv4 addresses more robust and correct
4185         https://bugs.webkit.org/show_bug.cgi?id=162746
4186
4187         Reviewed by Tim Horton.
4188
4189         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
4190         (TestWebKitAPI::TEST_F):
4191
4192 2016-09-29  Alex Christensen  <achristensen@webkit.org>
4193
4194         URLParser: IPv6 addresses followed by a colon are invalid
4195         https://bugs.webkit.org/show_bug.cgi?id=162747
4196
4197         Reviewed by Tim Horton.
4198
4199         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
4200         (TestWebKitAPI::TEST_F):
4201
4202 2016-09-29  Alexey Proskuryakov  <ap@apple.com>
4203
4204         Make WKTR short timeout dynamic
4205         https://bugs.webkit.org/show_bug.cgi?id=162733
4206
4207         Reviewed by Alex Christensen.
4208
4209         WebKitTestRunner has a hardcoded value for how long to wait for IPC responses,
4210         which is 5 seconds, or 10 seconds under ASan. But some of the operations can be
4211         fairly time consuming - e.g. launching Networking process on demand.
4212         These may take longer under load, especially with GuardMalloc.
4213
4214         * WebKitTestRunner/TestController.cpp:
4215         (WTR::TestController::resetStateToConsistentValues):
4216         (WTR::TestController::reattachPageToWebProcess):
4217         * WebKitTestRunner/TestController.h:
4218         * WebKitTestRunner/TestInvocation.cpp:
4219         (WTR::TestInvocation::shortTimeout):
4220         (WTR::TestInvocation::invoke):
4221         (WTR::TestInvocation::dumpResults):
4222
4223         * WebKitTestRunner/TestInvocation.h:
4224         (WTR::TestInvocation::customTimeout): Deleted, this function was unused.
4225
4226 2016-09-29  Alex Christensen  <achristensen@webkit.org>
4227
4228         URLParser should fail to parse unclosed IPv6 addresses
4229         https://bugs.webkit.org/show_bug.cgi?id=162715
4230
4231         Reviewed by Tim Horton.
4232
4233         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
4234         (TestWebKitAPI::TEST_F):
4235
4236 2016-09-29  Alex Christensen  <achristensen@webkit.org>
4237
4238         URLParser should ignore tabs at all possible locations
4239         https://bugs.webkit.org/show_bug.cgi?id=162711
4240
4241         Reviewed by Tim Horton.
4242
4243         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
4244         (TestWebKitAPI::ExpectedParts::isInvalid):
4245         (TestWebKitAPI::checkURL):
4246         (TestWebKitAPI::TEST_F):
4247
4248 2016-09-29  Gyuyoung Kim  <gyuyoung.kim@navercorp.com>
4249
4250         [EFL] Add search button to url bar in MiniBrowser
4251         https://bugs.webkit.org/show_bug.cgi?id=162716
4252
4253         Reviewed by Michael Catanzaro.
4254
4255         As a bug title, it would be good to add a search button to URL bar.
4256         Additionally this patch changes color of button to recognize the buttons.
4257
4258         * MiniBrowser/efl/main.c:
4259         (_search_button_clicked_cb):
4260         (_create_toolbar_button):
4261         (window_create):
4262         (create_toolbar_button): Deleted.
4263
4264 2016-09-28  Tim Horton  <timothy_horton@apple.com>
4265
4266         API test WebKit2.AutoLayoutIntegration is a flaky timeout
4267         https://bugs.webkit.org/show_bug.cgi?id=160284
4268
4269         Reviewed by Dan Bernstein.
4270
4271         * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:
4272         (-[AutoLayoutWKWebView load:withWidth:expectingContentSize:resettingWidth:]):
4273         (-[AutoLayoutWKWebView beginLayoutAtMinimumWidth:andExpectContentSizeChange:]):
4274         (-[AutoLayoutWKWebView waitForContentSizeChangeResettingWidth:]):
4275         (-[AutoLayoutWKWebView layoutAtMinimumWidth:andExpectContentSizeChange:resettingWidth:]):
4276         (-[AutoLayoutWKWebView invalidateIntrinsicContentSize]):
4277         (TEST):
4278         Make the autolayout tests a bit more flexible regarding the ordering of
4279         invalidateIntrinsicContentSize, to avoid a race between the load
4280         completing and the invalidation.
4281
4282         Also, move the newly added test to use its own WKWebView, since once in a