60ee5ff0169d82027434b483733bf42fc1736a7f
[WebKit-https.git] / Tools / ChangeLog
1 2011-06-13  Jaehun Lim  <ljaehun.lim@samsung.com>
2
3         Reviewed by Eric Seidel.
4
5         [EFL] Add load error handler to EWebLauncher
6         https://bugs.webkit.org/show_bug.cgi?id=62347
7
8         Add a handler function of "load,error" to EWebLauncher.
9         EWebLauncher now displays a simple error page on load errors.
10
11         * EWebLauncher/main.c:
12         (on_load_error):
13         (browserCreate):
14
15 2011-06-13  Martin Robinson  <mrobinson@igalia.com>
16
17         Reviewed by Eric Seidel.
18
19         [GTK] [Qt] Eliminate duplicate TestNetscapePlugin implementation
20         https://bugs.webkit.org/show_bug.cgi?id=62385
21
22         Remove duplicate TestNetscapePlugIn implementation. Having two copies
23         of this code makes keeping it in sync much more difficult. The files are
24         almost identical and this change ports the X11 changes to main.cpp.
25
26         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
27         (NPP_New): Do not set the plugin as windowless always. Doing this breaks
28         some results on Qt and this seems to be unnecessary for the moment.
29         (keyEventToChar): Added this helper which converts a X11 keycode into a char.
30         (handleEventX11): Use the handler to properly convert the keycode. Do not print
31         adjustCursorEvent output. The tests currently do not trigger this for Cocoa and thus
32         it should not be in the results.
33         (NPP_GetValue): Properly handle NPPVpluginNeedsXEmbed and make it clearer why the
34         XP_UNIX block is first by guarding against using a null instance.
35         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Update source list add
36         the XP_UNIX define for Linux.
37         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: Removed.
38         * GNUmakefile.am: Update source list.
39
40 2011-06-13  Sheriff Bot  <webkit.review.bot@gmail.com>
41
42         Unreviewed, rolling out r88671.
43         http://trac.webkit.org/changeset/88671
44         https://bugs.webkit.org/show_bug.cgi?id=62591
45
46         "didn't work" (Requested by dpranke on #webkit).
47
48         * Scripts/new-run-webkit-httpd:
49         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
50         * Scripts/webkitpy/layout_tests/port/http_server.py:
51         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
52         * Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py: Removed.
53         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
54         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
55
56 2011-06-13  Nate Chapin  <japhet@chromium.org>
57
58         Reviewed by Darin Fisher.
59
60         New test method on TestNetscapePlugin for https://bugs.webkit.org/show_bug.cgi?id=61482.
61
62         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
63
64 2011-06-13  Dirk Pranke  <dpranke@chromium.org>
65
66         Reviewed by Tony Chang.
67
68         webkitpy: add integration tests for new-run-webkit-httpd, stop calling shut_down_http_server
69         https://bugs.webkit.org/show_bug.cgi?id=62251
70
71         shut_down_http_server() was a total hack that was only used by
72         new-run-webkit-httpd, so I've moved the code there and switched
73         to using executive.kill_process() for the common case. The
74         method itself will be removed in the patch on bug 59993.
75
76         * Scripts/new-run-webkit-httpd:
77         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
78         * Scripts/webkitpy/layout_tests/port/http_server.py:
79         * Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py: Added.
80         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
81
82 2011-06-13  Tony Chang  <tony@chromium.org>
83
84         Reviewed by Dimitri Glazkov.
85
86         rename ENABLE_NEW_FLEXBOX to ENABLE_CSS3_FLEXBOX
87         https://bugs.webkit.org/show_bug.cgi?id=62578
88
89         * Scripts/build-webkit:
90
91 2011-06-13  Tony Chang  <tony@chromium.org>
92
93         Reviewed by Adam Barth.
94
95         rename ENABLE_FLEXBOX to ENABLE_NEW_FLEXBOX
96         https://bugs.webkit.org/show_bug.cgi?id=62545
97
98         * Scripts/build-webkit:
99
100 2011-06-13  Carlos Garcia Campos  <cgarcia@igalia.com>
101
102         Reviewed by Martin Robinson.
103
104         [GTK] Export an API similar to WebKit1
105         https://bugs.webkit.org/show_bug.cgi?id=57820
106
107         Build GtkLauncher2 for WebKit2. It's actually the same GtkLauncher
108         code, but linking to libwebkit2gtk.
109
110         * GNUmakefile.am:
111         * GtkLauncher/main.c:
112         (createBrowser):
113         (main):
114
115 2011-06-12  MORITA Hajime  <morrita@google.com>
116
117         Unreviewed, rolling out r88625.
118         http://trac.webkit.org/changeset/88625
119         https://bugs.webkit.org/show_bug.cgi?id=61073
120
121         Breaks SL Webkit2 Tests
122
123         * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops:
124         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
125         * WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops:
126         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
127         (WTR::InjectedBundlePage::didClearWindowForFrame):
128         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
129
130 2011-06-12  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
131
132         Reviewed by Antonio Gomes.
133
134         [Qt] LayoutTestController needs setTextDirection implementation
135         https://bugs.webkit.org/show_bug.cgi?id=62442
136
137         Implements LayoutController.setTextDirection.
138
139         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
140         (LayoutTestController::setTextDirection):
141         * DumpRenderTree/qt/LayoutTestControllerQt.h:
142
143 2011-06-12  Dominic Cooney  <dominicc@chromium.org>
144
145         Reviewed by Hajime Morita.
146
147         Add window.internals to WebKit2's WebKitTestRunner.
148         https://bugs.webkit.org/show_bug.cgi?id=61073
149
150         Test: fast/harness/internals-object.html
151
152         * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops:
153         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
154         * WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops:
155         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
156         (WTR::InjectedBundlePage::didClearWindowForFrame): initialize window.internals
157         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
158
159 2011-06-12  Sheriff Bot  <webkit.review.bot@gmail.com>
160
161         Unreviewed, rolling out r88616.
162         http://trac.webkit.org/changeset/88616
163         https://bugs.webkit.org/show_bug.cgi?id=62517
164
165         It broke editing/text-iterator/findString.html (Requested by
166         tonikitoo on #webkit).
167
168         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
169         * DumpRenderTree/qt/LayoutTestControllerQt.h:
170
171 2011-06-12  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
172
173         Reviewed by Antonio Gomes.
174
175         [Qt] LayoutTestController needs setTextDirection implementation
176         https://bugs.webkit.org/show_bug.cgi?id=62442
177
178         Implements LayoutController.setTextDirection.
179
180         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
181         (LayoutTestController::setTextDirection):
182         * DumpRenderTree/qt/LayoutTestControllerQt.h:
183
184 2011-06-10  Ryosuke Niwa  <rniwa@webkit.org>
185
186         Reviewed by Ojan Vafai.
187
188         new-run-webkit-tests: 'images' links on results.html don't work
189         https://bugs.webkit.org/show_bug.cgi?id=62194
190
191         Use relative path when generating images-diffs.html
192
193         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
194         Added _output_testname.
195
196 2011-06-10  Lucas Forschler  <lforschler@apple.com>
197
198         Reviewed by Stephanie Lewis.
199
200         Script to kill old processes on Mac.
201         This matches the windows version.
202         https://bugs.webkit.org/show_bug.cgi?id=62479  
203         
204         * BuildSlaveSupport/mac: Added.
205         * BuildSlaveSupport/mac/kill-old-processes: Added.
206
207 2011-06-10  Adam Barth  <abarth@webkit.org>
208
209         Reviewed by James Robinson.
210
211         When sheriffbot reports failures on IRC instead of saying "(and more..)" it should say the number of tests that are failing
212         https://bugs.webkit.org/show_bug.cgi?id=62489
213
214         * Scripts/webkitpy/tool/bot/sheriff.py:
215         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
216
217 2011-06-10  Tony Chang  <tony@chromium.org>
218
219         Reviewed by Ojan Vafai.
220
221         add a compile guard ENABLE(FLEXBOX)
222         https://bugs.webkit.org/show_bug.cgi?id=62049
223
224         * Scripts/build-webkit:
225
226 2011-06-10  Mark Rowe  <mrowe@apple.com>
227
228         Reviewed by Dimitri Glazkov.
229
230         <rdar://problem/9562114> Fix DumpRenderTree build for production configuration.
231
232         Ensure that DumpRenderTree can find libWebCoreTestSupport.dylib and the associated
233         header file.
234
235         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
236         * DumpRenderTree/mac/Configurations/Base.xcconfig:
237
238 2011-06-09  Csaba Osztrogonác  <ossy@webkit.org>
239
240         Unreviewed rolling out r88471, because it broke plugin tests on Qt.
241
242         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
243         (handleEventX11):
244         (NPP_GetValue):
245         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
246         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: Added.
247         (webkit_test_plugin_new_instance):
248         (webkit_test_plugin_destroy_instance):
249         (webkit_test_plugin_set_window):
250         (executeScript):
251         (webkit_test_plugin_new_stream):
252         (webkit_test_plugin_destroy_stream):
253         (webkit_test_plugin_stream_as_file):
254         (webkit_test_plugin_write_ready):
255         (webkit_test_plugin_write):
256         (webkit_test_plugin_print):
257         (keyEventToChar):
258         (webkit_test_plugin_handle_event):
259         (webkit_test_plugin_url_notify):
260         (webkit_test_plugin_get_value):
261         (webkit_test_plugin_set_value):
262         (NP_GetMIMEDescription):
263         (NP_Initialize):
264         (NP_Shutdown):
265         (NP_GetValue):
266         * GNUmakefile.am:
267
268 2011-06-09  Martin Robinson  <mrobinson@igalia.com>
269
270         Reviewed by Eric Seidel.
271
272         [GTK] Implement the next bit of the TextInputController (hasMarkedText and markedRange)
273         https://bugs.webkit.org/show_bug.cgi?id=55603
274
275         Add callbacks to support hasMarkedText and markedRange and also clean up existing 
276         TextInputController support.
277
278         * DumpRenderTree/gtk/TextInputController.cpp:
279         (setMarkedTextCallback): Accept parameters in terms of start and length, instead
280         of start and end. This matches the other ports. Do not use GLib style early returns.
281         (hasMarkedTextCallback): Added.
282         (markedRangeCallback): Added.
283         (insertTextCallback): Cleanup as described above.
284         (unmarkTextCallback): Cleanup as described above.
285         (firstRectForCharacterRangeCallback): Cleanup as described above.
286         (selectedRangeCallback): Cleanup as described above.
287
288 2011-06-09  Dirk Pranke  <dpranke@chromium.org>
289
290         Reviewed by Tony Chang.
291
292         nrwt: support webaudio in chromium driver
293         https://bugs.webkit.org/show_bug.cgi?id=62226
294
295         * Scripts/webkitpy/layout_tests/port/chromium.py:
296
297 2011-06-09  Dan Bernstein  <mitz@apple.com>
298
299         Reviewed by Anders Carlsson.
300
301         Added a test for Vector::reverse()
302         https://bugs.webkit.org/show_bug.cgi?id=62393
303
304         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
305         * TestWebKitAPI/Tests/WTF/VectorReverse.cpp: Added.
306         (TestWebKitAPI::TEST):
307         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
308
309 2011-06-09  Martin Robinson  <mrobinson@igalia.com>
310
311         Reviewed by Andreas Kling.
312
313         [GTK] [Qt] Eliminate duplicate TestNetscapePlugin implementation
314         https://bugs.webkit.org/show_bug.cgi?id=62385
315
316         Remove duplicate TestNetscapePlugIn implementation. Having two copies
317         of this code makes keeping it in sync much more difficult. The files are
318         almost identical and this change ports the X11 changes to main.cpp.
319
320         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
321         (keyEventToChar): Added this helper which converts a X11 keycode into a char.
322         (handleEventX11): Use the handler to properly convert the keycode. Do not print
323         adjustCursorEvent output. The tests currently do not trigger this for Cocoa and thus
324         it should not be in the results.
325         (NPP_GetValue): Properly handle NPPVpluginNeedsXEmbed.
326         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Update source list.
327         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: Removed.
328         * GNUmakefile.am: Update source list.
329
330 2011-06-09  Noel Gordon  <noel.gordon@gmail.com>
331
332         Reviewed by Tony Chang.
333
334         Test plugin should support event logging on the windows port.
335         https://bugs.webkit.org/show_bug.cgi?id=61721
336
337         The WebKit win port interprets a 0 return from plugin NPP_HandleEvent()
338         calls to mean the plugin handled the event.
339
340         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
341         (handleEventWin): Return 0 for each event on windows.
342
343 2011-06-09  Chang Shu  <cshu@webkit.org>
344
345         Reviewed by Andreas Kling.
346
347         [Qt] [WK2] Many editing tests failed on missing shouldBeginEditingInDOMRange:range printout
348         https://bugs.webkit.org/show_bug.cgi?id=62381
349
350         Activate QGraphicsScene and setFocus on QGraphicsItem to make sure the view has the focus.
351         QWKPagePrivate::isViewFocused() will check it later.
352
353         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
354         (WTR::PlatformWebView::PlatformWebView):
355
356 2011-06-09  Robert Hogan  <robert@webkit.org>
357
358         Reviewed by Andreas Kling.
359
360         Teach Qt about window.internals
361         https://bugs.webkit.org/show_bug.cgi?id=61074
362
363         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
364         (WebCore::DumpRenderTree::initJSObjects):
365
366 2011-06-09  Eric Seidel  <eric@webkit.org>
367
368         Reviewed by Adam Barth.
369
370         Disable running layout tests on Mac EWS bots (and fix cr-linux bots to run them again)
371         https://bugs.webkit.org/show_bug.cgi?id=62362
372
373         The mac bots are failing inspector tests.  We don't know why yet.
374         So for now, turning run-webkit-tests off for the mac-ews.
375
376         Also noticed that due to the wrong variable name the cr-linux
377         bots weren't running tests!
378
379         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
380
381 2011-06-09  Zoltan Herczeg  <zherczeg@inf.u-szeged.hu>
382
383         Reviewed by Csaba Osztrogonac.
384
385         [Qt][WK2] Canvas tests make css2.1 ones failing
386         https://bugs.webkit.org/show_bug.cgi?id=53427
387
388         Adding a workaround for this issue by mimicing the behaviour of DumpRenderTree.
389         Since the Qt port should eventually go to QRawFont, this issue will be resolved
390         in the future. Both clearMemoryCaches() and removeAllApplicationFonts() are
391         needed for the workaround.
392
393         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
394         (WTR::LayoutTestController::platformInitialize):
395
396 2011-06-09  Mario Sanchez Prada  <msanchez@igalia.com>
397
398         Reviewed by Chris Fleizach.
399
400         [GTK] Provide a way in DRT to check the platform name
401         https://bugs.webkit.org/show_bug.cgi?id=56855
402
403         Patch for adding 'platformName' static property to DRT's
404         LayoutController and provide platform specific implementations.
405
406         In principle, this feature will be only of interest for writing
407         accessibility tests, so that's why it's only implemented in the
408         Mac, Gtk and Win platforms.
409
410         * DumpRenderTree/LayoutTestController.h: New method platformName().
411         * DumpRenderTree/LayoutTestController.cpp:
412         (getPlatformNameCallback): New callback for 'platformName'.
413         (LayoutTestController::staticValues): New static property.
414
415         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
416         (LayoutTestController::platformName): Implemented.
417
418         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
419         (LayoutTestController::platformName): Implemented.
420
421         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
422         (LayoutTestController::platformName): Implemented.
423
424 2011-06-08  Mike Lawther  <mikelawther@chromium.org>
425
426         Reviewed by James Robinson.
427
428         Add mikelawther to committers.py
429         https://bugs.webkit.org/show_bug.cgi?id=62354
430
431         * Scripts/webkitpy/common/config/committers.py:
432
433 2011-06-08  Kent Tamura  <tkent@chromium.org>
434
435         [Chromium] Fix a typo.
436
437         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp:
438         (WebThemeControlDRTWin::draw):
439
440 2011-06-08  Kent Tamura  <tkent@chromium.org>
441
442         Reviewed by Hajime Morita.
443
444         [Chromium] Support vertical sliders in Windows DRT
445         https://bugs.webkit.org/show_bug.cgi?id=62352
446
447         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp:
448         (WebThemeControlDRTWin::draw):
449           Paint VerticalSliderThumbType and VerticalSliderTrackType.
450         * DumpRenderTree/chromium/WebThemeControlDRTWin.h:
451           Add VerticalSliderTrackType and VerticalSliderThumbType.
452         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
453         (WebThemeEngineDRTWin::paintTrackbar):
454           Convert Windows identifiers to the internal identifiers for vertical sliders.
455
456 2011-06-08  Ojan Vafai  <ojan@chromium.org>
457
458         Reviewed by Tony Chang.
459
460         add a short-flag for --experimental-fully-parallel
461         https://bugs.webkit.org/show_bug.cgi?id=62321
462
463         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
464
465 2011-06-08  Ryosuke Niwa  <rniwa@webkit.org>
466
467         Reviewed by Tony Chang.
468
469         new-run-webkit-tests: don't turn the tree red when there are new passes
470         https://bugs.webkit.org/show_bug.cgi?id=62311
471
472         Look for "new passes" instead of "passed unexpectedly" in evaluateCommand
473         to match commandComplete.
474
475         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
476
477 2011-06-08  Tom Hudson  <tomhudson@google.com>
478
479         Reviewed by Mihai Parparita.
480
481         Allow sorting in RebaselineServer based on 'metric' field in unexpected_results.json
482         https://bugs.webkit.org/show_bug.cgi?id=60964
483
484         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
485         Add 'Sort tests by metric' link.
486         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
487         (disableSorting): Activate 'Sort tests by metric' link.
488         (enableSorting): Deactivate 'Sort tests by metric' link.
489         (selectDirectory): Call enableSorting()/disableSorting() depending
490         on currently selected failure type, and sort tests if requested.
491         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
492         New .disabled-control class for deactivated links.
493
494 2011-06-08  Tom Sepez  <tsepez@chromium.org>
495
496         Reviewed by Adam Barth.
497
498         Add web permissions callbacks for mixed content blocking.
499         https://bugs.webkit.org/show_bug.cgi?id=61946
500
501         * DumpRenderTree/chromium/LayoutTestController.cpp:
502         (LayoutTestController::setAllowDisplayOfInsecureContent):
503         (LayoutTestController::setAllowRunningOfInsecureContent):
504         (LayoutTestController::overridePreference):
505         * DumpRenderTree/chromium/WebPermissions.cpp:
506         (WebPermissions::allowDisplayingInsecureContent):
507         (WebPermissions::allowRunningInsecureContent):
508         (WebPermissions::setDisplayingInsecureContentAllowed):
509         (WebPermissions::setRunningInsecureContentAllowed):
510         (WebPermissions::reset):
511         * DumpRenderTree/chromium/WebPermissions.h:
512
513 2011-06-08  Dirk Pranke  <dpranke@chromium.org>
514
515         Reviewed by Tony Chang.
516
517         webkitpy: fix typo causing us to skip the port unit tests in chromium_linux
518         https://bugs.webkit.org/show_bug.cgi?id=62259
519
520         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
521
522 2011-06-08  Ryosuke Niwa  <rniwa@webkit.org>
523
524         Reviewed by Tony Chang.
525
526         new-run-webkit-tests: master.cfg errors when nrwt successfully runs test
527         https://bugs.webkit.org/show_bug.cgi?id=62303
528
529         Access self.incorrectLayoutLines instead of incorrectLayoutLines in evaluateCommand.
530
531         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
532
533 2011-06-08  Greg Simon  <gregsimon@chromium.org>
534
535         Reviewed by Dimitri Glazkov.
536
537         Control Indexeddb backends from LayoutTestController
538         https://bugs.webkit.org/show_bug.cgi?id=61000
539
540         * DumpRenderTree/chromium/LayoutTestController.cpp:
541         (LayoutTestController::LayoutTestController):
542         (LayoutTestController::setOverrideIndexedDBBackingStore):
543         (LayoutTestController::clearAllDatabases):
544         * DumpRenderTree/chromium/LayoutTestController.h:
545
546 2011-06-08  Andreas Kling  <kling@webkit.org>
547
548         Add Pierre Rossi to contributors list for EZ-CC.
549
550         * Scripts/webkitpy/common/config/committers.py:
551
552 2011-06-08  Ilya Sherman  <isherman@chromium.org>
553
554         Reviewed by Andreas Kling.
555
556         Add Ilya Sherman to list of committers
557         https://bugs.webkit.org/show_bug.cgi?id=62270
558
559         * Scripts/webkitpy/common/config/committers.py:
560
561 2011-06-07  Ryosuke Niwa  <rniwa@webkit.org>
562
563         Reviewed by Tony Chang.
564
565         new-run-webkit-tests: Bot master should print useful information on waterfall/console for nrwt
566         https://bugs.webkit.org/show_bug.cgi?id=62178
567
568         Added commandComplete and evaluateCommand for NewRunWebKitTests class
569         to parse new-run-webkit-tests' results.
570
571         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
572
573 2011-06-07  Dirk Pranke  <dpranke@chromium.org>
574
575         Reviewed by Eric Seidel.
576
577         webkitpy: add a popen() call to executive
578         https://bugs.webkit.org/show_bug.cgi?id=62179
579
580         This change adds a popen() wrapper call to the Executive object.
581         This will allow other webkitpy scripts that currently call
582         subprocess directly to use Executive, instead.
583
584         No additional tests are necessary (the existing tests cover the code).
585
586         * Scripts/webkitpy/common/system/executive.py:
587
588 2011-06-07  Sam Weinig  <sam@webkit.org>
589
590         Reviewed by Anders Carlsson.
591
592         Remove repeated IPC traffic from SetRenderTreeSize message
593         https://bugs.webkit.org/show_bug.cgi?id=62244
594
595         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
596         (WTR::InjectedBundlePage::InjectedBundlePage):
597         Add stub for didLayoutForFrame.
598
599 2011-06-07  Dirk Pranke  <dpranke@chromium.org>
600
601         Reviewed by Tony Chang.
602
603         rebaseline-chromium-webkit-tests: fix baselining order for linux, linux_x86_64
604         https://bugs.webkit.org/show_bug.cgi?id=62241
605
606         * Scripts/webkitpy/layout_tests/port/chromium.py:
607
608 2011-06-07  Adam Barth  <abarth@webkit.org>
609
610         Rubber-stamped by Eric Seidel.
611
612         Enable tests on the mac-ews
613
614         When we bring the mac-ews back up, we're going to try running tests!
615
616         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
617
618 2011-06-07  Dmitry Lomov  <dslomov@google.com>
619
620         Reviewed by David Levin.
621
622         https://bugs.webkit.org/show_bug.cgi?id=62215
623         Allow comparisons with 0 in LIKELY and UNLIKELY macros.
624
625         * Scripts/webkitpy/style/checkers/cpp.py:
626         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
627
628 2011-06-07  Nico Weber  <thakis@chromium.org>
629
630         Reviewed by Dimitri Glazkov.
631
632         [chromium] -Wdelete-non-virtual-dtor pass for DumpRenderTree
633         https://bugs.webkit.org/show_bug.cgi?id=62210
634
635         The change to TestEventPrinter fixes a latent bug, because
636         objects are deleted through the TestEventPrinter type, but none
637         of the subclasses have destructors or non-POD members.
638
639         The changes to NotificationPresenter and WebViewHost do _not_ to fix a
640         real bug, they just make clang's -Wdelete-non-virtual-dtor happy. As
641         discussed at http://codereview.chromium.org/7094005/, we prefer making
642         leaf class destructors virtual over making the leaf classes final.
643
644         * DumpRenderTree/chromium/NotificationPresenter.cpp:
645         (NotificationPresenter::~NotificationPresenter):
646         * DumpRenderTree/chromium/NotificationPresenter.h:
647         * DumpRenderTree/chromium/TestEventPrinter.cpp:
648         (TestEventPrinter::~TestEventPrinter):
649         * DumpRenderTree/chromium/TestEventPrinter.h:
650         * DumpRenderTree/chromium/WebViewHost.h:
651
652 2011-06-06  Ryosuke Niwa  <rniwa@webkit.org>
653
654         Reviewed by Dirk Pranke.
655
656         [chromium] Chromium bots on build.webkit.org don't upload results.html
657         https://bugs.webkit.org/show_bug.cgi?id=61961
658
659         Don't fix the path on chromium port erroneously.
660
661         * BuildSlaveSupport/test-result-archive:
662
663 2011-06-06  Martin Robinson  <mrobinson@igalia.com>
664
665         Fix the GTK+ build by ensuring that the autogenerated sources
666         necessary for libWebCoreInternals are recorded in a predeclared
667         variable before assigning to BUILT_SOURCES.
668
669         * GNUmakefile.am: Predeclare libwebcoreinternals_built_sources.
670
671 2011-06-06  Yong Li  <yoli@rim.com>
672
673         Reviewed by Eric Seidel.
674
675         https://bugs.webkit.org/show_bug.cgi?id=62097
676         Fix the problem that integral bitfield check incorrectly barked at ?: expressions.
677
678         * Scripts/webkitpy/style/checkers/cpp.py:
679         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
680
681 2011-06-06  Xan Lopez  <xlopez@igalia.com>
682
683         Reviewed by Martin Robinson.
684
685         [GTK] Enable feature/symbol detection in NWRT/GTK
686         https://bugs.webkit.org/show_bug.cgi?id=62136
687
688         Disable feature detection through DRT, since we don't support it,
689         and set the libwebcore patch correctly so that symbol detection
690         through 'nm' works.
691
692         * Scripts/webkitpy/layout_tests/port/gtk.py:
693
694 2011-06-06  Shishir Agrawal  <shishir@chromium.org>
695
696         Reviewed by Tony Gentilcore.
697
698         Add a "prerender" state for page visibility.
699         https://bugs.webkit.org/show_bug.cgi?id=62062
700
701         * DumpRenderTree/chromium/LayoutTestController.cpp:
702         (LayoutTestController::setPageVisibility):
703
704 2011-06-06  Csaba Osztrogonác  <ossy@webkit.org>
705
706         [Qt] Implement download feature for QtTestBrowser
707         https://bugs.webkit.org/show_bug.cgi?id=61865
708
709         Buildfix for --minimal and CONFIG+=qt_minimal build after r88161.
710
711         * QtTestBrowser/launcherwindow.cpp:
712         (LauncherWindow::LauncherWindow):
713         * QtTestBrowser/launcherwindow.h:
714
715 2011-06-06  Barát Tibor  <Barat.Tibor@stud.u-szeged.hu>
716
717         Reviewed by Csaba Osztrogonác.
718
719         [Qt] Implement download feature for QtTestBrowser
720         https://bugs.webkit.org/show_bug.cgi?id=61865
721
722         * QtTestBrowser/launcherwindow.cpp:
723         (LauncherWindow::LauncherWindow):
724         (LauncherWindow::downloadRequest):
725         (LauncherWindow::fileDownloadFinished):
726         * QtTestBrowser/launcherwindow.h:
727
728 2011-06-04  Dominic Cooney  <dominicc@chromium.org>
729
730         Reviewed by Dimitri Glazkov.
731
732         Make DumpRenderTree initialize window.internals.
733         https://bugs.webkit.org/show_bug.cgi?id=61076
734
735         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops: link WebCoreTestSupport.
736         * DumpRenderTree/win/FrameLoadDelegate.cpp:
737         (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld):
738
739 2011-06-06  Alexandru Chiculita  <achicu@adobe.com>
740
741         Reviewed by Kent Tamura.
742
743         Add ENABLE_CSS_EXCLUSIONS support for build-webkit script
744         https://bugs.webkit.org/show_bug.cgi?id=61628
745
746         * Scripts/build-webkit:
747
748 2011-06-06  Mihnea Ovidenie  <mihnea@adobe.com>
749
750         Reviewed by Kent Tamura.
751
752         Add ENABLE(CSS_REGIONS) guard for CSS Regions support
753         https://bugs.webkit.org/show_bug.cgi?id=61631
754
755         * Scripts/build-webkit:
756
757 2011-06-06  Carlos Garcia Campos  <cgarcia@igalia.com>
758
759         Unreviewed. Fix the GTK+ build.
760
761         * GNUmakefile.am: Use javascriptcore_cflags when building libWebCoreInternals.
762
763 2011-06-05  Alexey Proskuryakov  <ap@apple.com>
764
765         Add an e-mail address for Cameron McCormack that matches Bugzilla (so that auto-completion
766         works properly).
767
768         * Scripts/webkitpy/common/config/committers.py:
769
770 2011-06-04  Kevin Ollivier  <kevino@theolliviers.com>
771
772         [wx] Unreviewed build fix. Update git branch build dir handling to match what other
773         WebKit scripts expect, so other scripts work properly with wx.
774
775         * waf/build/build_utils.py:
776         * waf/build/settings.py:
777
778 2011-06-04  Kevin Ollivier  <kevino@theolliviers.com>
779
780         [wx] Unreviewed build fix. Restore the PPC build and allow users to specify architectures
781         to build on Mac.
782
783         * waf/build/settings.py:
784         * wx/install-unix-extras:
785
786 2011-06-04  Kevin Ollivier  <kevino@theolliviers.com>
787
788         [wx] Unreviewed build fixes for recent trunk changes.
789
790         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
791         (LayoutTestController::setTextDirection):
792         * waf/build/settings.py:
793
794 2011-06-04  Martin Robinson  <mrobinson@igalia.com>
795
796         Fix the GTK+ build.
797
798         * GNUmakefile.am: Add some missing newline escape.
799
800 2011-06-03  Martin Robinson  <mrobinson@igalia.com>
801
802         Try to fix the GTK+ bulid.
803
804         * GNUmakefile.am: Add JSDOMWrapper.cpp to the libWebCoreInternals
805         source list.
806
807 2011-06-03  Dirk Pranke  <dpranke@chromium.org>
808
809         Reviewed by Adam Barth.
810
811         nrwt: should skip chromium test expectation overrides on upstream bots
812         https://bugs.webkit.org/show_bug.cgi?id=61888
813
814         * Scripts/webkitpy/layout_tests/port/chromium.py:
815         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
816
817 2011-06-03  Dirk Pranke  <dpranke@chromium.org>
818
819         Reviewed by Ojan Vafai.
820
821         new-run-webkit-tests: minor logging, code cleanup
822         https://bugs.webkit.org/show_bug.cgi?id=62055
823
824         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
825         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
826
827 2011-06-03  Martin Robinson  <mrobinson@igalia.com>
828
829         Try to fix the build failure on the GTK+ 32-bit Release bot.
830
831         * GNUmakefile.am: Add JSInternal.{cpp,h} to the BUILT_SOURCES list.
832
833 2011-05-31  Martin Robinson  <mrobinson@igalia.com>
834
835         Reviewed by Ryosuke Niwa.
836
837         [GTK] Support smart replace for the pasteboard
838         https://bugs.webkit.org/show_bug.cgi?id=61734
839
840         Call into the DumpRenderTreeSupportGtk hooks to toggle smart replace.
841         This is required to produce consistent test results.
842
843         * DumpRenderTree/gtk/DumpRenderTree.cpp:
844         (resetDefaultsToConsistentValues): Set the smart replace setting to on by default.
845         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
846         (LayoutTestController::setSmartInsertDeleteEnabled): Added an implementation of this
847         methods which calls into DumpRenderTreeSupportGtk.
848
849 2011-06-03  Martin Robinson  <mrobinson@igalia.com>
850
851         Reviewed by Dimitri Glazkov.
852
853         Teach Gtk build about window.internals
854         https://bugs.webkit.org/show_bug.cgi?id=61071
855
856         * DumpRenderTree/gtk/DumpRenderTree.cpp:
857         (webViewWindowObjectCleared): Inject the new internals object when the
858         window object clears.
859         * GNUmakefile.am: Add new source files and includes necessary for window.internals.
860         Also do a little bit of cleanup.
861
862 2011-06-03  Dirk Pranke  <dpranke@chromium.org>
863
864         Reviewed by Tony Chang.
865
866         Worker may not be stopped after LT.
867         https://bugs.webkit.org/show_bug.cgi?id=61847
868
869         Re-submit a variant of the first fix for this bug. It's possible
870         that actually calling cleanup() in the worker threads was taking
871         too long and we triggered the assertions in the manager thread.
872
873         I've bumped up the timeout in the manager and added better
874         diagnostics. I also cleaned up the cleanup() code a bit because
875         there was some unnecessary if-checks.
876
877         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
878         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
879
880 2011-06-03  Dirk Pranke  <dpranke@chromium.org>
881
882         Reviewed by Tony Chang.
883
884         nrwt: fix duplicate logging regression
885         https://bugs.webkit.org/show_bug.cgi?id=61981
886
887         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
888
889 2011-06-03  Robert Kroeger  <rjkroege@chromium.org>
890
891         Reviewed by Adam Barth.
892
893         Modified addTouchPoint to correctly re-use touchPoint id values starting
894         from the lowest not-un-use touchPoint id as is done by the embedder
895         APIs. (Fixes BUGCR36415)
896
897         https://bugs.webkit.org/show_bug.cgi?id=62016
898
899         * DumpRenderTree/chromium/EventSender.cpp:
900         (EventSender::addTouchPoint):
901
902 2011-06-03  Cary Clark  <caryclark@google.com>
903
904         Reviewed by Eric Seidel.
905
906         Draw DRT scroll bar thumb with CG when WebKit renders with Skia
907         https://bugs.webkit.org/show_bug.cgi?id=61534
908
909         Skia on Mac uses Skia to render WebKit, and CG
910         to render UI elements. The CG elements need a
911         transcribed graphics context that preserves the
912         canvas matrix, and the canvas clip.
913
914         The SkiaBitLocker utility class sets up a CGContext
915         from the SkCanvas, locks the bitmap's bits, and
916         releases the lock when the class goes out of scope.
917
918         The SkiaBitLocker implementation is described by
919         this patch:
920         http://codereview.chromium.org/7031006/
921
922         When WebKit uses Skia for rendering, the WebCanvas
923         is an SkCanvas. Create an equivalent CGContext to
924         draw the scrollbar thumb.
925
926         As the Chrome Mac port does not yet use Skia, this
927         patch has no effect and requires no tests.
928
929         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
930         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
931
932 2011-06-03  Andras Becsi  <abecsi@webkit.org>
933
934         Unreviewed build fix.
935
936         Fix typo.
937
938         * Scripts/old-run-webkit-tests:
939
940 2011-06-03  Andras Becsi  <abecsi@webkit.org>
941
942         Reviewed by Csaba Osztrogonác.
943
944         Print error message when there is no httpd present on the system
945         https://bugs.webkit.org/show_bug.cgi?id=61939
946
947         * Scripts/old-run-webkit-tests: Propose to run with --no-httpd.
948         * Scripts/webkitperl/httpd.pm:
949
950 2011-06-03  Mikhail Naganov  <mnaganov@chromium.org>
951
952         Reviewed by Yury Semikhatsky.
953
954         Web Inspector: [Chromium] cpu-profiler-profiling layout test is flaky on Linux Debug.
955         https://bugs.webkit.org/show_bug.cgi?id=61533
956
957         Skip cpu-profiler-profiling in debug, implement a fast headless alternative.
958
959         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
960         (DRTDevToolsAgent::setJavaScriptProfilingEnabled):
961         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
962         * DumpRenderTree/chromium/LayoutTestController.cpp:
963         (LayoutTestController::LayoutTestController):
964         (LayoutTestController::setJavaScriptProfilingEnabled):
965         * DumpRenderTree/chromium/LayoutTestController.h:
966         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
967         (LayoutTestController::setJavaScriptProfilingEnabled):
968         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
969         (WTR::LayoutTestController::setJavaScriptProfilingEnabled):
970         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
971
972 2011-06-02  Dirk Pranke  <dpranke@chromium.org>
973
974         Reviewed by Tony Chang.
975
976         NRWT needs a way to log to a file without including backspaces without needing --verbose
977         https://bugs.webkit.org/show_bug.cgi?id=60328
978
979         This change modifies NRWT so that if it can tell if it is
980         writing to a terminal, it will overwrite any messages printed
981         in the 'one-line-progress' and 'updates' print options, and if
982         not (or if --verbose was specified) the messages will be printed
983         without backspaces.
984
985         If the overwriting updates are disabled, one-line-progress will
986         only print every 10 seconds instead of on every update. This
987         ensures that we still get updates once in a while while the
988         tests are running, even if we're not in --verbose mode. Note
989         that one-line-progress will now still be printed in --verbose,
990         since it's useful as long as you're not flooded with the
991         updates.
992
993         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
994         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
995         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
996
997 2011-06-02  Martin Robinson  <mrobinson@igalia.com>
998
999         Reviewed by Gustavo Noronha Silva.
1000
1001         [GTK] autogen.sh is run twice for each buld on the bots
1002         https://bugs.webkit.org/show_bug.cgi?id=61951
1003
1004         * Scripts/webkitdirs.pm: Only check the previous autotools arguments
1005         for the WebKit project. This prevents build-jsc runs from forcing subsequent
1006         build-webkit runs to re-rerun autogen.sh.
1007
1008 2011-06-02  Sheriff Bot  <webkit.review.bot@gmail.com>
1009
1010         Unreviewed, rolling out r87946.
1011         http://trac.webkit.org/changeset/87946
1012         https://bugs.webkit.org/show_bug.cgi?id=61965
1013
1014         Cause NRWT to break (Requested by abarth|gardener on #webkit).
1015
1016         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
1017
1018 2011-06-02  Dimitri Glazkov  <dglazkov@chromium.org>
1019
1020         Reviewed by Darin Adler.
1021
1022         Add build logistics and plumbing for window.internals object.
1023         https://bugs.webkit.org/show_bug.cgi?id=60313
1024
1025         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added linking new WebCoreTestSupport library.
1026         * DumpRenderTree/chromium/TestShell.cpp:
1027         (TestShell::bindJSObjectsToWindow): Added injection code.
1028         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1029         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]): Ditto.
1030
1031 2011-06-02  Hao Zheng  <zhenghao@chromium.org>
1032
1033         Reviewed by Dirk Pranke.
1034
1035         Call cleanup() explicitly at the end of worker.run().
1036         https://bugs.webkit.org/show_bug.cgi?id=61847
1037
1038         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
1039
1040 2011-06-02  Dimitri Glazkov  <dglazkov@chromium.org>
1041
1042         Unreviewed, rolling out r87926.
1043         http://trac.webkit.org/changeset/87926
1044         https://bugs.webkit.org/show_bug.cgi?id=60313
1045
1046         Fails to find WebCoreTestSupport.dylib on bots.
1047
1048         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1049         * DumpRenderTree/chromium/TestShell.cpp:
1050         (TestShell::bindJSObjectsToWindow):
1051         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1052         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
1053
1054 2011-05-21  Dimitri Glazkov  <dglazkov@chromium.org>
1055
1056         Reviewed by Darin Adler.
1057
1058         Add build logistics and plumbing for window.internals object.
1059         https://bugs.webkit.org/show_bug.cgi?id=60313
1060
1061         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added linking new WebCoreTestSupport library.
1062         * DumpRenderTree/chromium/TestShell.cpp:
1063         (TestShell::bindJSObjectsToWindow): Added injection code.
1064         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1065         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]): Ditto.
1066
1067 2011-06-02  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1068
1069         Reviewed by Eric Seidel.
1070
1071         Adjust efl coding style to more efl directories
1072         https://bugs.webkit.org/show_bug.cgi?id=61903
1073
1074         * Scripts/webkitpy/style/checker.py: Adjust efl coding style to efl directories.
1075
1076 2011-06-01  Dirk Pranke  <dpranke@chromium.org>
1077
1078         Reviewed by Tony Chang.
1079
1080         old-run-webkit-tests: add support for audio files
1081         https://bugs.webkit.org/show_bug.cgi?id=57992
1082
1083         * Scripts/old-run-webkit-tests:
1084
1085 2011-06-01  Jochen Eisinger  <jochen@chromium.org>
1086
1087         Reviewed by Adam Barth.
1088
1089         Implement layoutTestController.setImagesAllowed for controlling the respective behavior of the WebPermissionClient
1090         https://bugs.webkit.org/show_bug.cgi?id=34314
1091
1092         * DumpRenderTree/DumpRenderTree.gypi:
1093         * DumpRenderTree/chromium/LayoutTestController.cpp:
1094         (LayoutTestController::LayoutTestController):
1095         (LayoutTestController::setImagesAllowed):
1096         (LayoutTestController::setStorageAllowed):
1097         * DumpRenderTree/chromium/LayoutTestController.h:
1098         * DumpRenderTree/chromium/WebPermissions.cpp: Copied from Tools/DumpRenderTree/chromium/WebPermissions.h.
1099         (WebPermissions::WebPermissions):
1100         (WebPermissions::~WebPermissions):
1101         (WebPermissions::allowImages):
1102         (WebPermissions::allowStorage):
1103         (WebPermissions::setImagesAllowed):
1104         (WebPermissions::setStorageAllowed):
1105         (WebPermissions::reset):
1106         * DumpRenderTree/chromium/WebPermissions.h:
1107
1108 2011-06-01  Noel Gordon  <noel.gordon@gmail.com>
1109
1110         Reviewed by Tony Chang.
1111
1112         Test plugin should support event logging on the windows port.
1113         https://bugs.webkit.org/show_bug.cgi?id=61721
1114
1115         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1116         (handleEventWin): Well, handle them.
1117
1118 2011-06-01  Daniel Cheng  <dcheng@chromium.org>
1119
1120         Reviewed by Tony Chang.
1121
1122         [chromium] Use correct file name for dragging out images.
1123         https://bugs.webkit.org/show_bug.cgi?id=24887
1124
1125         * DumpRenderTree/chromium/EventSender.cpp:
1126         (EventSender::EventSender):
1127         (EventSender::dumpFilenameBeingDragged):
1128         * DumpRenderTree/chromium/EventSender.h:
1129
1130 2011-06-01  Dirk Pranke  <dpranke@chromium.org>
1131
1132         Reviewed by Tony Chang.
1133
1134         nrwt: make webaudio work w/o content-length header
1135         https://bugs.webkit.org/show_bug.cgi?id=61819
1136
1137         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1138         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
1139         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
1140         * Scripts/webkitpy/layout_tests/port/webkit.py:
1141
1142 2011-06-01  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
1143
1144         Reviewed by Andreas Kling.
1145
1146         [Qt][WK2] Add QGLWidget viewport support to MiniBrowser
1147         https://bugs.webkit.org/show_bug.cgi?id=61802
1148
1149         Add command line parameter and menu item to MiniBrowser application 
1150         enabling use of QGLWidget for browser viewport.
1151
1152         * MiniBrowser/qt/BrowserWindow.cpp:
1153         (BrowserWindow::BrowserWindow):
1154         (BrowserWindow::toggleGLViewport):
1155         * MiniBrowser/qt/BrowserWindow.h:
1156         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1157         (MiniBrowserApplication::handleUserOptions):
1158         * MiniBrowser/qt/MiniBrowserApplication.h:
1159         (WindowOptions::WindowOptions):
1160
1161 2011-06-01  Martin Robinson  <mrobinson@igalia.com>
1162
1163         Reviewed by Xan Lopez.
1164
1165         Print out autogen arguments when they differ from the last set, to help
1166         with debugging build issues.
1167
1168         * Scripts/webkitdirs.pm: Print out previous and current build arguments
1169         when they differ.
1170
1171 2011-06-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1172
1173         Reviewed by Martin Robinson.
1174
1175         [GTK] run-launcher should run MiniBrowser in WebKit2
1176         https://bugs.webkit.org/show_bug.cgi?id=61858
1177
1178         * Scripts/run-launcher: Check whether -2 command line option has
1179         been passed and run MiniBrowser instead of GtkLauncher.
1180
1181 2011-05-31  Hao Zheng  <zhenghao@chromium.org>
1182
1183         Reviewed by Dirk Pranke.
1184
1185         Fix exception in verbose printing mode.
1186         https://bugs.webkit.org/show_bug.cgi?id=61723
1187
1188         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1189
1190 2011-05-31  Yong Li  <yoli@rim.com>
1191
1192         Reviewed by Eric Seidel.
1193
1194         https://bugs.webkit.org/show_bug.cgi?id=54807
1195         We have been assuming plain bitfields (like "int a : 31") are always signed integers.
1196         However some compilers can treat them as unsigned. For example, RVCT 4.0 states plain
1197         bitfields (declared without either signed or unsigned qualifiers) are treats as unsigned.
1198         http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0348c/Babjddhe.html
1199         Although we can use "--signed-bitfields" flag to make RVCT 4.0 behave as most other compilers,
1200         always using "signed"/"unsigned" qualifier to declare integral type bitfields is still a good
1201         rule we should have in order to make our code independent from compilers and compiler flags.
1202
1203         * Scripts/webkitpy/style/checkers/cpp.py:
1204
1205 2011-05-31  Hironori Bono  <hbono@chromium.org>
1206
1207         Reviewed by Eric Seidel.
1208
1209         Add a JavaScript function layoutTestController.setTextDirection().
1210         https://bugs.webkit.org/show_bug.cgi?id=50952
1211
1212         This change adds a new JavaScript function setTextDirection() to the
1213         LayoutTestController class of Safari and Chrome to write layout tests
1214         that changes the text direction of an editable element.
1215
1216         * DumpRenderTree/LayoutTestController.cpp:
1217         (setTextDirectionCallback):
1218         (LayoutTestController::staticFunctions):
1219         * DumpRenderTree/LayoutTestController.h:
1220         * DumpRenderTree/chromium/LayoutTestController.cpp:
1221         (LayoutTestController::LayoutTestController):
1222         (LayoutTestController::setTextDirection):
1223         * DumpRenderTree/chromium/LayoutTestController.h:
1224         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1225         (LayoutTestController::setTextDirection):
1226         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1227         (LayoutTestController::setTextDirection):
1228         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1229         (LayoutTestController::setTextDirection):
1230
1231 2011-05-31  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
1232
1233         Reviewed by Simon Hausmann.
1234
1235         [Qt] User-agent list of Qt test browsers is very outdated
1236         https://bugs.webkit.org/show_bug.cgi?id=61531
1237
1238         The user can edit the user-agent manually, so there's no need to have
1239         a super complete and up to date list, but it's nice to have it
1240         minimally updated.
1241
1242         * MiniBrowser/qt/useragentlist.txt:
1243         * QtTestBrowser/useragentlist.txt:
1244
1245 2011-03-30  Martin Robinson  <mrobinson@igalia.com>
1246
1247         Reviewed by Adam Roben.
1248
1249         [GTK] [WebKit2] Implement a basic WebKitTestRunner
1250         https://bugs.webkit.org/show_bug.cgi?id=57068
1251
1252         Add an implementation of WebKitTestRunner for GTK+.
1253
1254         * Scripts/build-webkittestrunner: Added knowledge of GTK+ TestRunner.
1255         * Scripts/old-run-webkit-tests: Ditto.
1256         * Scripts/run-launcher: Ditto.
1257         * Scripts/webkitdirs.pm: Ditto.
1258         * WebKitTestRunner/GNUmakefile.am: Added.
1259         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1260         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp: Added.
1261         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
1262         * WebKitTestRunner/InjectedBundle/gtk/LayoutTestControllerGtk.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
1263         * WebKitTestRunner/PlatformWebView.h:
1264         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp: Added.
1265         * WebKitTestRunner/gtk/TestControllerGtk.cpp: Added.
1266         * WebKitTestRunner/gtk/TestInvocationGtk.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
1267         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1268         * WebKitTestRunner/gtk/main.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
1269         (main): Added.
1270
1271 2011-05-31  Dirk Pranke  <dpranke@chromium.org>
1272
1273         Reviewed by Tony Chang.
1274
1275         new-run-webkit-tests: doesn't wait for children if it gets a ctrl-c
1276         https://bugs.webkit.org/show_bug.cgi?id=60241
1277
1278         * Scripts/new-run-webkit-tests:
1279
1280 2011-05-31  Eric Seidel  <eric@webkit.org>
1281
1282         Reviewed by David Kilzer.
1283
1284         webkitpy should create zips with zip -9
1285         https://bugs.webkit.org/show_bug.cgi?id=61789
1286
1287         Dave Kilzer suggested we add this to make zips uploaded to bugzilla smaller.
1288
1289         * Scripts/webkitpy/common/system/workspace.py:
1290         * Scripts/webkitpy/common/system/workspace_unittest.py:
1291
1292 2011-05-31  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
1293
1294         Reviewed by Csaba Osztrogonác.
1295
1296         [Qt] Implement find feature for QtTestBrowser
1297         https://bugs.webkit.org/show_bug.cgi?id=61425
1298
1299         Buildfix for --minimal and CONFIG+=qt_minimal build.
1300
1301         * QtTestBrowser/launcherwindow.cpp:
1302         (LauncherWindow::LauncherWindow):
1303         (LauncherWindow::createChrome):
1304         * QtTestBrowser/launcherwindow.h:
1305
1306 2011-05-31  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
1307
1308         Reviewed by Csaba Osztrogonác.
1309
1310         [Qt] Implement find feature for QtTestBrowser
1311         https://bugs.webkit.org/show_bug.cgi?id=61425
1312
1313         * QtTestBrowser/launcherwindow.cpp:
1314         (LauncherWindow::LauncherWindow):
1315         (LauncherWindow::createChrome):
1316         (LauncherWindow::showFindBar):
1317         (LauncherWindow::find):
1318         * QtTestBrowser/launcherwindow.h:
1319
1320 2011-05-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1321
1322         Reviewed by Martin Robinson.
1323
1324         [GTK] Implement JavaScript dialogs in MiniBrowser
1325         https://bugs.webkit.org/show_bug.cgi?id=61725
1326
1327         * MiniBrowser/gtk/BrowserWindow.c:
1328         (WKStringGetCString): Helper function to get a UTF-8 c string from
1329         a WKStringRef.
1330         (WKURLGetCString): Helper function to get a UTF-8 c string from a
1331         WKURLRef.
1332         (browserWindowUpdateURL): Update to use WKURLGetCString.
1333         (didReceiveTitleForFrame): Update to use WKStringGetCString.
1334         (createMessageDialog): Create a GtkMessageDialog.
1335         (runJavaScriptAlert):
1336         (runJavaScriptConfirm):
1337         (runJavaScriptPrompt):
1338         (browserWindowUIClientInit):
1339
1340 2011-05-29  Yuta Kitamura  <yutak@chromium.org>
1341
1342         Reviewed by Kent Tamura.
1343
1344         WebSocket closing handshake
1345         https://bugs.webkit.org/show_bug.cgi?id=35721
1346
1347         * Scripts/webkitpy/thirdparty/__init__.py:
1348         Pull in pywebsocket 0.6b1. We need to update pywebsocket
1349         to get the right behavior of closing handshake.
1350
1351 2011-05-29  Daniel Bates  <dbates@rim.com>
1352
1353         Reviewed by David Kilzer.
1354
1355         REGRESSION (r86515): svn-apply ignores diffs that omit line count in chunk range
1356         https://bugs.webkit.org/show_bug.cgi?id=61162
1357
1358         Fixes an issue where svn-apply may ignore a diff that contains a chunk range line
1359         that omits a line count. In particular, the chunk range regular expression does
1360         not match a chunk range line that omits a line count. GNU diff(1) will omit the
1361         line count in the chunk range if the line count is exactly 1. For example, appending
1362         a new line to the end of an existing file F that contains exactly one line of text will
1363         be represented in a diff with a chunk range line that omits the line count for F.
1364
1365         * Scripts/VCSUtils.pm:
1366           (parseChunkRange): Added.
1367         * Scripts/webkitperl/VCSUtils_unittest/parseChunkRange.pl: Added.
1368         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
1369           - Added unit test "Git: Append new line to the end of an existing file".
1370
1371 2011-05-28  Adam Barth  <abarth@webkit.org>
1372
1373         Reviewed by Eric Seidel.
1374
1375         EWS builds patches that fail to build twice, which seems useless and slows down the bots
1376         https://bugs.webkit.org/show_bug.cgi?id=55585
1377
1378         This patch switches all the early warning system bots over to the new
1379         PatchAnalysisTask-based infrastructure.  This patch makes these bots
1380         more efficient (in the case where patches fail to build) and paves the
1381         way for running tests on these bots!
1382
1383         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1384         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
1385         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1386         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1387         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1388         * Scripts/webkitpy/tool/commands/queues.py:
1389
1390 2011-05-28  Kenichi Ishibashi  <bashi@chromium.org>
1391
1392         Reviewed by Kent Tamura.
1393
1394         Add bashi as a committer.
1395
1396         https://bugs.webkit.org/show_bug.cgi?id=61685
1397
1398         * Scripts/webkitpy/common/config/committers.py:
1399
1400 2011-05-27  Adam Barth  <abarth@webkit.org>
1401
1402         Reviewed by Eric Seidel.
1403
1404         When checking whether the tree is red, the EWS posts a link to the wrong log
1405         https://bugs.webkit.org/show_bug.cgi?id=61072
1406
1407         We need to cache the original script error because that contains the
1408         failure log we want to upload.  If we don't cache that script error,
1409         self._script_error will get overwritten when we sanity check the clean
1410         tree (and it also has test failures).
1411
1412         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1413             - This testing approach is slightly goofy.  We'd like to use
1414               assertRaisesRegexp, but that's not available until Python 2.7.
1415         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1416
1417 2011-05-27  Jochen Eisinger  <jochen@chromium.org>
1418
1419         Reviewed by Adam Barth.
1420
1421         Add layoutTestController.setStorageAllowed() to control whether access
1422         to the localStorage API is enabled via the WebPermissionClient
1423         https://bugs.webkit.org/show_bug.cgi?id=61581
1424
1425         * DumpRenderTree/chromium/LayoutTestController.cpp:
1426         (LayoutTestController::LayoutTestController):
1427         (LayoutTestController::setStorageAllowed):
1428         * DumpRenderTree/chromium/LayoutTestController.h:
1429         * DumpRenderTree/chromium/TestShell.cpp:
1430         (TestShell::TestShell):
1431         (TestShell::createNewWindow):
1432         * DumpRenderTree/chromium/TestShell.h:
1433         * DumpRenderTree/chromium/WebPermissions.h: Added.
1434         (WebPermissions::WebPermissions):
1435         (WebPermissions::allowStorage):
1436         (WebPermissions::setStorageAllowed):
1437         (WebPermissions::reset):
1438
1439 2011-05-27  Dirk Pranke  <dpranke@chromium.org>
1440
1441         Reviewed by Eric Seidel.
1442
1443         NRWT: clean up metered_stream code in preparation for 'nooverwriting' patch
1444         https://bugs.webkit.org/show_bug.cgi?id=60326
1445
1446         This patch removes a lot of the complexity from the
1447         metered_stream implementation that was unnecessary since there
1448         was only one caller and the logic could be coordinated better.
1449
1450         There should be no functional changes in this patch, just code
1451         getting deleted and cleaned up.
1452
1453         * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
1454         * Scripts/webkitpy/layout_tests/layout_package/metered_stream_unittest.py:
1455         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1456         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1457
1458 2011-05-27  Dirk Pranke  <dpranke@chromium.org>
1459
1460         Reviewed by Eric Seidel.
1461
1462         NRWT: minor cleanup in printing module
1463         https://bugs.webkit.org/show_bug.cgi?id=60329
1464
1465         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1466
1467 2011-05-27  Steve Lacey  <sjl@chromium.org>
1468
1469         Reviewed by David Levin.
1470
1471         Add sjl@chromium.org as a committer.
1472
1473         https://bugs.webkit.org/show_bug.cgi?id=61672
1474
1475         * Scripts/webkitpy/common/config/committers.py:
1476
1477 2011-05-27  Dirk Pranke  <dpranke@chromium.org>
1478
1479         Reviewed by Adam Barth.
1480
1481         NRWT: remove --print detailed-progress
1482         https://bugs.webkit.org/show_bug.cgi?id=60324
1483
1484         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
1485         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1486         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1487         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1488
1489 2011-05-27  Dirk Pranke  <dpranke@chromium.org>
1490
1491         Reviewed by Ojan Vafai.
1492
1493         NRWT: debug messages from the workers are being logged twice
1494         https://bugs.webkit.org/show_bug.cgi?id=60428
1495
1496         It looks like when the workers are run in separate processes
1497         we end up getting two copies of every log message they print.
1498         This has to do with the multiprocessing module on UNIX cloning
1499         the log configuration in a way I wasn't expecting, and so two
1500         log handlers end up getting registered.
1501
1502         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
1503         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1504         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1505         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1506
1507 2011-05-27  Adam Roben  <aroben@apple.com>
1508
1509         Always decode tester names from location.hash
1510
1511         When navigating directly to a tester-specific URL (e.g.,
1512         <http://build.webkit.org/TestFailures/#/Windows%207%20Release%20(Tests)>), you could end up
1513         with a URL-encoded tester name in the page, and then the encoded name could make its way
1514         into Bugzilla bugs. Bad!
1515
1516         Reviewed by David Kilzer.
1517
1518         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
1519         (ViewController.prototype.parseHash): Pass the tester name we got from location.hash through
1520         decodeURIComponent before trying to use it.
1521
1522 2011-05-27  Adam Roben  <aroben@apple.com>
1523
1524         Remove testing code that snuck into r87528
1525
1526         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
1527         (ViewController.prototype._domForNewBugLink): Remove a line I was using for some testing.
1528
1529 2011-05-27  Adam Roben  <aroben@apple.com>
1530
1531         Add links to TestFailures to easily file bugs about failing tests
1532
1533         Fixes <http://webkit.org/b/61636> <rdar://problem/9514886> TestFailures page should have
1534         links to file bugs for failing tests
1535
1536         Reviewed by David Kilzer.
1537
1538         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
1539         (Builder.prototype.resultsPageURL): New helper function to return the URL to results.html
1540         for a particular build.
1541         (Builder.prototype._getFailingTests): Use resultsPageURL.
1542
1543         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
1544         (ViewController.prototype._displayBuilder): Add links to file bugs about each set of
1545         failures.
1546         (ViewController.prototype._domForBuildName): Use resultsPageURL.
1547         (ViewController.prototype._domForNewBugLink): Added. Creates an element that represents the
1548         new bug link. The bug has a title, description, and URL already filled in for you!
1549
1550 2011-05-27  Sheriff Bot  <webkit.review.bot@gmail.com>
1551
1552         Unreviewed, rolling out r87464.
1553         http://trac.webkit.org/changeset/87464
1554         https://bugs.webkit.org/show_bug.cgi?id=61643
1555
1556         client-close/server-close tests are flaky on Chromium Mac and
1557         Windows (Requested by aklein on #webkit).
1558
1559         * Scripts/webkitpy/thirdparty/__init__.py:
1560
1561 2011-05-27  Alexey Proskuryakov  <ap@apple.com>
1562
1563         Added Douglas Davidson to contributors list for easier CC'ing.
1564
1565         * Scripts/webkitpy/common/config/committers.py:
1566
1567 2011-05-26  Mihai Parparita  <mihaip@chromium.org>
1568
1569         Reviewed by Adam Barth.
1570
1571         Fix worldID and destinationDomain argument names
1572         https://bugs.webkit.org/show_bug.cgi?id=61571
1573
1574         As part of working on r87423, I noticed a couple of inconsistencies in
1575         argument names:
1576         - We would use worldId in .h files but worldID in .cpp files.
1577           Standardize on the latter
1578         - SecurityOrigin::addOriginAccessWhitelistEntry would take a
1579           destinationDomains argument, even though the actual parameter was for
1580           a single domain (renamed to be singular).
1581
1582         * DumpRenderTree/LayoutTestController.h:
1583         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1584         (LayoutTestController::evaluateScriptInIsolatedWorld):
1585
1586 2011-05-26  Yuta Kitamura  <yutak@chromium.org>
1587
1588         Reviewed by Kent Tamura.
1589
1590         WebSocket closing handshake
1591         https://bugs.webkit.org/show_bug.cgi?id=35721
1592
1593         * Scripts/webkitpy/thirdparty/__init__.py:
1594         Pull in pywebsocket 0.6b1. We need to update pywebsocket
1595         to get the right behavior of closing handshake.
1596
1597 2011-05-26  Qi Zhang  <qi.2.zhang@nokia.com>
1598
1599         Reviewed by Andreas Kling.
1600
1601         WebKitTestRunner needs layoutTestController.setAuthorAndUserStylesEnabled
1602         https://bugs.webkit.org/show_bug.cgi?id=42676
1603
1604         Implemented layoutTestController.setAuthorAndUserStylesEnabled for WebKitTestRunner.
1605
1606         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1607         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1608         (WTR::InjectedBundle::beginTesting):
1609         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1610         (WTR::LayoutTestController::setAuthorAndUserStylesEnabled):
1611         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1612
1613 2011-05-26  Ademar de Souza Reis Jr.  <ademar.reis@openbossa.org>
1614
1615         Reviewed by Andreas Kling.
1616
1617         [Qt] QtTestBrowser "Switch User Agent" dialog is broken
1618         https://bugs.webkit.org/show_bug.cgi?id=61527
1619
1620         The setMaximumHeight() call is unecessary and breaks the dialog at
1621         least on my setup.
1622
1623         * QtTestBrowser/launcherwindow.cpp:
1624         (LauncherWindow::showUserAgentDialog):
1625
1626 2011-05-02  Robert Hogan  <robert@webkit.org>
1627
1628         Reviewed by Adam Roben.
1629
1630         [Qt] Allow popup windows from plugins when initiated by a user gesture
1631
1632         https://bugs.webkit.org/show_bug.cgi?id=41292
1633
1634         Support parameters introduced in plugin-initiate-popup-window.html
1635
1636         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1637         (webkit_test_plugin_new_instance):
1638         (webkit_test_plugin_handle_event):
1639
1640 2011-05-26  Mihai Parparita  <mihaip@chromium.org>
1641
1642         Reviewed by Adam Barth.
1643
1644         Support cross-origin XMLHttpRequest in isolated worlds
1645         https://bugs.webkit.org/show_bug.cgi?id=59843
1646
1647         Expose setIsolatedWorldSecurityOrigin in LayoutTestController.
1648
1649         * DumpRenderTree/chromium/LayoutTestController.cpp:
1650         (LayoutTestController::LayoutTestController):
1651         (LayoutTestController::setIsolatedWorldSecurityOrigin):
1652         * DumpRenderTree/chromium/LayoutTestController.h:
1653
1654 2011-05-25  Brian Weinstein  <bweinstein@apple.com>
1655
1656         Reviewed by Adam Roben.
1657
1658         WebKit2: Status bar, toolbar, and menu bar checks should be in the injected bundle
1659         https://bugs.webkit.org/show_bug.cgi?id=61474
1660         <rdar://problem/9468337>
1661
1662         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1663         (WTR::InjectedBundlePage::InjectedBundlePage): Add empty entries in the WKBundlePageUIClient.
1664
1665 2011-05-26  Andreas Kling  <kling@webkit.org>
1666
1667         Unreviewed, correct address to webkit-committers mailing list.
1668
1669         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1670
1671 2011-05-25  Adam Roben  <aroben@apple.com>
1672
1673         Don't assume that builds finish in the order they were started
1674
1675         Fixes <http://webkit.org/b/61464> TestFailures page shows failures from a not-most-recent
1676         build when one slave is taking a long time to finish a build
1677
1678         Reviewed by Antti Koivisto.
1679
1680         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
1681         (Builder.prototype.getMostRecentCompletedBuildNumber): Don't assume that all builds that are
1682         newer than the oldest in-progress build are also themselves in progress. Just check whether
1683         each build is actually in progress (as signified by its presence in the currentBuilds set).
1684
1685 2011-05-25  Adam Roben  <aroben@apple.com>
1686
1687         Correctly detect cases where only a single test failed/crashed/timed out
1688
1689         Fixes <http://webkit.org/b/61463> TestFailures page doesn't show testers with only a single
1690         failing test
1691
1692         Reviewed by Darin Adler.
1693
1694         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
1695         (Builder.prototype.getNumberOfFailingTests): Don't require "test cases" to be plural. It
1696         will be singular when only a single test fails/crashes/times out.
1697
1698         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
1699         (ViewController.prototype._displayTesters): Only pluralize "test" when more than one test
1700         failed/crashed/timed out.
1701
1702 2011-05-26  Tom Hudson  <tomhudson@google.com>
1703
1704         Reviewed by Tony Chang.
1705
1706         Add flags to Chromium ImageDiff to write image comparison metrics on
1707         stdout.
1708         https://bugs.webkit.org/show_bug.cgi?id=60569
1709
1710         * DumpRenderTree/chromium/ImageDiff.cpp:
1711         (Image::createFromStdin): Fix spelling.
1712         (maxOf3): New function to do 3-way maximum.
1713         (getRedComponent): Extract red component from ABGR packed encoding.
1714         (getGreenComponent): Extract green component from ABGR packed encoding.
1715         (getBlueComponent): Extract blue component from ABGR packed encoding.
1716         (weightedPercentageDifferent): Determine % of pixels different in two
1717         images multiplied by intensity difference of each pixel.
1718         (printHelp): Document new arguments.
1719         (compareImages): Parameterize.
1720         (untestedCompareImages): Parameterize.
1721         (diffImages): Parameterize; write results on stdout if requested.
1722         (main): Parse new arguments.
1723
1724 2011-05-25  Qi Zhang  <qi.2.zhang@nokia.com>
1725
1726         Reviewed by Simon Hausmann.
1727
1728         WebKitTestRunner needs layoutTestController.setPrivateBrowsingEnabled
1729         https://bugs.webkit.org/show_bug.cgi?id=42697
1730
1731         Implemented layoutTestController.setPrivateBrowsingEnabled for WebKitTestRunner.
1732
1733         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1734         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1735         (WTR::InjectedBundle::beginTesting):
1736         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1737         (WTR::LayoutTestController::setPrivateBrowsingEnabled):
1738         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1739
1740 2011-05-25  Jon Honeycutt  <jhoneycutt@apple.com>
1741
1742         REGRESSION (WebKit2): Crash in Flash on USA Today photo gallery
1743         https://bugs.webkit.org/show_bug.cgi?id=61428
1744         <rdar://problem/9457006>
1745
1746         Reviewed by Adam Roben.
1747
1748         The crash occurs when Flash posts a message to a window that it
1749         creates, and in processing the message, it calls NPN_Evaluate to
1750         evaluate JavaScript that removes the plug-in from the page. Flash then
1751         crashes when we return to Flash code.
1752
1753         This test emulates that behavior.
1754
1755         * DumpRenderTree/TestNetscapePlugIn/win/CallJSThatDestroysPlugin.cpp: Added.
1756         (CallJSThatDestroysPlugin::CallJSThatDestroysPlugin):
1757         Initialize member vars.
1758         (CallJSThatDestroysPlugin::~CallJSThatDestroysPlugin):
1759         Remove our custom property from the message window, and destroy it.
1760         (CallJSThatDestroysPlugin::NPP_Destroy):
1761         Set m_isDestroyed, log that the plug-in was destroyed, and notify the
1762         layout test controller that we're done.
1763         (wndProc):
1764         Get the PluginTest object, and call its runTest() function.
1765         (CallJSThatDestroysPlugin::NPP_New):
1766         Setup the test: register a class for the message-only window, create
1767         it, and post a message to it to run the test.
1768         (CallJSThatDestroysPlugin::runTest):
1769         Execute JS that removes the plug-in from the page, and if we're not
1770         destroyed, log a success message.
1771
1772         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1773         Add new test to project.
1774
1775 2011-05-25  Tony Chang  <tony@chromium.org>
1776
1777         Reviewed by Adam Barth.
1778
1779         webkitpy's NetworkTransaction shouldn't use mechanize
1780         https://bugs.webkit.org/show_bug.cgi?id=61450
1781
1782         mechanize.HTTPError is just an alias for urllib2.HTTPError, so
1783         use urllib2 directly.  Re-add NetworkTransaction to
1784         test_results_uploader.py (reverting r87124).
1785
1786         * Scripts/webkitpy/common/net/networktransaction.py:
1787         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
1788
1789 2011-05-25  Kevin Ollivier  <kevino@theolliviers.com>
1790
1791         [Chromium] Unreviewed build fix. Do not define WTF/JS_EXPORT_PRIVATE to JS_EXPORTDATA
1792         until the port begins using those export macros.
1793
1794         * DumpRenderTree/chromium/config.h:
1795
1796 2011-05-25  Sheriff Bot  <webkit.review.bot@gmail.com>
1797
1798         Unreviewed, rolling out r87257.
1799         http://trac.webkit.org/changeset/87257
1800         https://bugs.webkit.org/show_bug.cgi?id=61457
1801
1802         This broke layout tests, see bug 61431. (Requested by
1803         hwennborg on #webkit).
1804
1805         * DumpRenderTree/chromium/LayoutTestController.cpp:
1806         (LayoutTestController::LayoutTestController):
1807         (LayoutTestController::clearAllDatabases):
1808         * DumpRenderTree/chromium/LayoutTestController.h:
1809
1810 2011-05-25  Qi Zhang  <qi.2.zhang@nokia.com>
1811
1812         Reviewed by Andreas Kling.
1813
1814         [Qt] fast/css/disabled-author-styles.html failed
1815         https://bugs.webkit.org/show_bug.cgi?id=61438
1816
1817         Implemented API setAuthorAndUserStylesEnabled in LayoutTestControllerQt.
1818
1819         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1820         (WebCore::WebPage::resetSettings):
1821         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1822         (LayoutTestController::setAuthorAndUserStylesEnabled):
1823         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1824
1825 2011-05-25  Adam Roben  <aroben@apple.com>
1826
1827         Identify, rather than skip, builds where run-webkit-tests exited early due to too many failures
1828
1829         Fixes <http://webkit.org/b/61441> TestFailures page should show when run-webkit-tests
1830         started exiting early due to too many crashes, timeouts, or failures
1831
1832         Reviewed by David Kilzer.
1833
1834         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
1835         (Builder.prototype.getNumberOfFailingTests): Rather than returning -1 ("unknown") when
1836         run-webkit-tests exits early due to too many failures, pass that information in another
1837         argument to the callback.
1838         (Builder.prototype.startFetchingBuildHistory): Updated the documentation comment to reflect
1839         the new structure of the object passed to the callback.
1840         (Builder.prototype._getFailingTests): Updated to expect a tooManyFailures boolean from
1841         getNumberOfFailingTests and to pass that along to our own callbacks.
1842         (Builder.prototype._incorporateBuildHistory): Updated to expect a tooManyFailures boolean
1843         from _getFailingTests and to store that value in the history object.
1844
1845         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
1846         (.info): Added.
1847
1848         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
1849         (ViewController.prototype._displayBuilder): Updated for change in structure to the history
1850         object and to add a note when run-webkit-tests exited early due to too many failures.
1851         (ViewController.prototype._displayTesters): Renamed testersAndFailureCounts to
1852         latestBuildInfos since each entry now contains more than just the tester and failure count.
1853         Now displays a message for testers where the latest build exited early due to too many
1854         failures. Updated to expect a tooManyFailures boolean from getNumberOfFailingTests and to
1855         store that value in latestBuildInfos.
1856
1857 2011-05-24  Keishi Hattori  <keishi@webkit.org>
1858
1859         Reviewed by Kent Tamura.
1860
1861         Disable textfield implementation of <input type=color>. Add INPUT_COLOR feature flag. Add input color sanitizer.
1862         https://bugs.webkit.org/show_bug.cgi?id=61273
1863
1864         * Scripts/build-webkit: Added INPUT_COLOR feature flag.
1865
1866 2011-05-24  Greg Simon  <gregsimon@chromium.org>
1867
1868         Reviewed by Dimitri Glazkov.
1869
1870         Control Indexeddb backends from LayoutTestController
1871         https://bugs.webkit.org/show_bug.cgi?id=61000
1872
1873         * DumpRenderTree/chromium/LayoutTestController.cpp:
1874         (LayoutTestController::LayoutTestController):
1875         (LayoutTestController::setOverrideIndexedDBBackingStore):
1876         (LayoutTestController::clearAllDatabases):
1877         * DumpRenderTree/chromium/LayoutTestController.h:
1878
1879 2011-05-24  Robert Hogan  <robert@webkit.org>
1880
1881         Reviewed by Ryosuke Niwa.
1882
1883         [Qt] Fix fast/events/selectstart-by-single-click-with-shift.html
1884         https://bugs.webkit.org/show_bug.cgi?id=61393
1885
1886         * DumpRenderTree/qt/EventSenderQt.h:
1887         * DumpRenderTree/qt/EventSenderQt.cpp:
1888         (getModifiers): static function for interpreting modifiers
1889         (EventSender::mouseDown): Respect keyboard modifiers
1890         (EventSender::keyDown): use new static function
1891         (EventSender::sendOrQueueEvent): whitespace fix
1892
1893 2011-05-24  Jay Civelli  <jcivelli@chromium.org>
1894
1895         Reviewed by Adam Barth.
1896
1897         Adding MHTML reading support.
1898         https://bugs.webkit.org/show_bug.cgi?id=7168
1899
1900         * Scripts/build-webkit:
1901         * Scripts/old-run-webkit-tests:
1902         * Scripts/webkitperl/features.pm:
1903         * Scripts/webkitpy/layout_tests/port/test_files.py:
1904         * Scripts/webkitpy/layout_tests/port/webkit.py:
1905
1906 2011-05-24  Stephen White  <senorblanco@chromium.org>
1907
1908         Reviewed by Kenneth Russell.
1909
1910         Remove most style checks on Source/ThirdParty/glu, since it doesn't
1911         follow WebKit style.
1912         https://bugs.webkit.org/show_bug.cgi?id=61365
1913
1914         * Scripts/webkitpy/style/checker.py:
1915
1916 2011-05-24  Adam Roben  <aroben@apple.com>
1917
1918         Don't allow forcing builds through the build.webkit.org web interface
1919
1920         Someone has been forcing bogus builds.
1921
1922         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1923
1924 2011-05-24  Qi Zhang  <qi.2.zhang@nokia.com>
1925
1926         Reviewed by Adam Roben.
1927
1928         WebKitTestRunner needs layoutTestController.setJavaScriptCanAccessClipboard
1929         https://bugs.webkit.org/show_bug.cgi?id=42669
1930
1931         Fixes the regression issue caused by patch 94265. The patch didn't intialize the setting before the 
1932         layouttest starting, it will make the test cases after editing/execCommand/clipboard-access.html failed.
1933         Because that case changed the setting.
1934
1935         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1936         (WTR::InjectedBundle::beginTesting):
1937
1938 2011-05-24  Csaba Osztrogonác  <ossy@webkit.org>
1939
1940         Reviewed by Kenneth Rohde Christiansen.
1941
1942         [ORWT]Make --skipped=only option work with parameters with LayoutTests/ prefix
1943         https://bugs.webkit.org/show_bug.cgi?id=61052
1944
1945         * Scripts/old-run-webkit-tests:
1946
1947 2011-05-24  Adam Roben  <aroben@apple.com>
1948
1949         Make TestFailures show how many tests are failing on each tester, and omit testers with no failures
1950
1951         Fixes <http://webkit.org/b/61063> <rdar://problem/9460533> TestFailures page shows testers
1952         that don't have any failing tests, which isn't useful
1953
1954         Reviewed by David Kilzer.
1955
1956         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js:
1957         (Buildbot.prototype.getTesters): Renamed from getTesterNames. Now returns Builder objects
1958         instead of name strings.
1959         (Buildbot.prototype._buildersForNames): Added. Helper function to convert an array of
1960         builder names into an array of builders.
1961
1962         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
1963         (Builder.prototype.getMostRecentCompletedBuildNumber): Added. Returns the build number of
1964         the most recently completed build, or -1 if there is no such build.
1965         (Builder.prototype.getNumberOfFailingTests): Added. Returns the number of tests that failed
1966         in the given build, or -1 if the number could not be determined. Some of this code came from
1967         _getFailingTests.
1968         (Builder.prototype._getBuildJSON): Added. Code came from _getFailingTests.
1969         (Builder.prototype._getFailingTests): Changed to use new _getBuildJSON and
1970         getNumberOfFailingTests functions.
1971
1972         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
1973         (ViewController.prototype._displayTesters): Get the current number of test failures for each
1974         tester and show it in the list. Omit testers that have no failures at all. We keep the
1975         testers and failure counts in an array and sort it before displaying the current data, as
1976         the order in which data will be fetched is unpredictable.
1977
1978 2011-05-23  Tony Chang  <tony@chromium.org>
1979
1980         Reviewed by Ojan Vafai.
1981
1982         [nrwt] don't use NetworkTranslation when uploading results
1983         https://bugs.webkit.org/show_bug.cgi?id=61315
1984
1985         This avoids autoinstalling mechanize.  It didn't matter anyway
1986         because test_results_uploader.py wasn't using mechanize to make the
1987         request so NetworkTransaction::run wasn't doing anything extra
1988         (it only matters if it catches mechanize.HTTPError).
1989
1990         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
1991
1992 2011-05-23  Tony Chang  <tony@chromium.org>
1993
1994         Reviewed by Dirk Pranke.
1995
1996         [chromium] fix the rebaseline tool to work with Linux GPU failures
1997         https://bugs.webkit.org/show_bug.cgi?id=61312
1998
1999         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2000
2001 2011-05-23  Darin Adler  <darin@apple.com>
2002
2003         Ignore generated .pyc files in a directory full of python code.
2004
2005         * Scripts/webkitpy/common/checkout/scm: Added property svn:ignore.
2006
2007 2011-05-23  Adam Barth  <abarth@webkit.org>
2008
2009         Reviewed by Eric Seidel.
2010
2011         sheriffbot should give more details about the failures in IRC
2012         https://bugs.webkit.org/show_bug.cgi?id=61233
2013
2014         With this patch, sheriffbot will annonce the set of failing tests,
2015         which might help folks triage the problem.
2016
2017         * Scripts/webkitpy/tool/commands/sheriffbot.py:
2018         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
2019
2020 2011-05-23  Sheriff Bot  <webkit.review.bot@gmail.com>
2021
2022         Unreviewed, rolling out r87078.
2023         http://trac.webkit.org/changeset/87078
2024         https://bugs.webkit.org/show_bug.cgi?id=61294
2025
2026         Patch contains errors and seems likely to break a bunch of
2027         bots (Requested by abarth on #webkit).
2028
2029         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2030         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2031         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
2032
2033 2011-05-23  Alice Boxhall  <aboxhall@chromium.org>
2034
2035         Reviewed by Ojan Vafai.
2036
2037         Convert json_results_generator.py to output version 4 JSON.
2038         https://bugs.webkit.org/show_bug.cgi?id=60869
2039
2040         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2041         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2042         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
2043
2044 2011-05-23  Patrick Gansterer  <paroga@webkit.org>
2045
2046         Reviewed by Adam Barth.
2047
2048         Move generation of shell_command from port to executive
2049         https://bugs.webkit.org/show_bug.cgi?id=61251
2050
2051         After move it's possible to use the code in other places too.
2052
2053         * Scripts/webkitpy/common/config/ports.py:
2054         * Scripts/webkitpy/common/system/executive.py:
2055
2056 2011-05-23  Qi Zhang  <qi.2.zhang@nokia.com>
2057
2058         Reviewed by Darin Adler.
2059
2060         WebKitTestRunner needs layoutTestController.setJavaScriptCanAccessClipboard
2061         https://bugs.webkit.org/show_bug.cgi?id=42669
2062
2063         Implement setJavaScriptCanAccessClipboard in WebKitTestRunner.
2064
2065         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2066         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2067         (WTR::LayoutTestController::setJavaScriptCanAccessClipboard):
2068         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2069
2070 2011-05-22  Robert Hogan  <robert@webkit.org>
2071
2072         Reviewed by Kenneth Rohde Christiansen.
2073
2074         Fix policyDelegate in Qt DRT
2075         https://bugs.webkit.org/show_bug.cgi?id=61247
2076
2077         Use the 'policy delegate' implemented in FrameLoaderClient
2078         for layout tests. The partial implementation in DumpRenderTreeQt
2079         is redundant, so remove it.
2080
2081         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2082         (WebCore::WebPage::acceptNavigationRequest):
2083         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2084         (LayoutTestController::waitForPolicyDelegate):
2085
2086 2011-05-22  Patrick Gansterer  <paroga@webkit.org>
2087
2088         Reviewed by Darin Adler.
2089
2090         Use double quotes for filename arguments
2091         https://bugs.webkit.org/show_bug.cgi?id=61250
2092
2093         Windows does not support single quotes on the command line,
2094         so replace them with double quotes.
2095
2096         * Scripts/prepare-ChangeLog:
2097
2098 2011-05-20  Simon Fraser  <simon.fraser@apple.com>
2099
2100         Reviewed by Sam Weinig.
2101
2102         WebKitTestRunner needs layoutTestController.pauseTransitionAtTimeOnElementWithId
2103         https://bugs.webkit.org/show_bug.cgi?id=42550
2104         
2105         Implement pauseTransitionAtTimeOnElementWithId in WebKitTestRunner.
2106
2107         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2108         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2109         Copy the code for pausing animations, FIXME comments and all.
2110         (WTR::LayoutTestController::pauseTransitionAtTimeOnElementWithId):
2111         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2112
2113 2011-05-20  Alok Priyadarshi  <alokp@chromium.org>
2114
2115         Reviewed by Stephen White.
2116
2117         Adding myself to the committers list.
2118
2119         * Scripts/webkitpy/common/config/committers.py:
2120
2121 2011-05-19  Adam Roben  <aroben@apple.com>
2122
2123         Test that the WebKit2 UI process doesn't crash when starting a download
2124
2125         Test for <http://webkit.org/b/61142> <rdar://problem/9471680> REGRESSION (r86812): Crash
2126         (preceded by assertion) in fastMalloc when downloading a file
2127
2128         Reviewed by Darin Adler.
2129
2130         * TestWebKitAPI/Tests/WebKit2/18-characters.html: Added.
2131
2132         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp: Added.
2133         (TestWebKitAPI::decidePolicyForNavigationAction): Start a download.
2134         (TestWebKitAPI::decideDestinationWithSuggestedFilename): Record that the download was
2135         started, cancel the download, and return a bogus string.
2136
2137         (TestWebKitAPI::setContextDownloadClient):
2138         (TestWebKitAPI::setPagePolicyClient):
2139         Simple helper functions.
2140
2141         (TestWebKitAPI::TEST): Load 18-characters.html, which should trigger a download thanks to
2142         our policy client, and run until we know that the download was started. If we haven't
2143         crashed, we win!
2144
2145         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2146         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2147         * TestWebKitAPI/win/copy-resources.cmd:
2148         Added new files.
2149
2150 2011-05-20  Kent Tamura  <tkent@chromium.org>
2151
2152         Reviewed by Ryosuke Niwa.
2153
2154         Fix style errors in DumpRenderTree/chromium/.
2155         https://bugs.webkit.org/show_bug.cgi?id=61172
2156
2157         * DumpRenderTree/chromium/CppBoundClass.cpp:
2158         (CppBoundClass::getAsCppVariant):
2159         (CppBoundClass::bindToJavascript):
2160         * DumpRenderTree/chromium/CppBoundClass.h:
2161         (CppBoundClass::GetterCallback::~GetterCallback):
2162         (CppBoundClass::CppBoundClass):
2163         (CppBoundClass::Callback::~Callback):
2164         (CppBoundClass::MemberCallback::MemberCallback):
2165         (CppBoundClass::MemberCallback::~MemberCallback):
2166         (CppBoundClass::MemberGetterCallback::MemberGetterCallback):
2167         (CppBoundClass::MemberGetterCallback::~MemberGetterCallback):
2168         * DumpRenderTree/chromium/CppVariant.h:
2169         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
2170         (DRTDevToolsAgent::~DRTDevToolsAgent):
2171         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
2172         (DRTDevToolsClient::sendFrontendLoaded):
2173         * DumpRenderTree/chromium/DRTDevToolsClient.h:
2174         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2175         (main):
2176         * DumpRenderTree/chromium/EventSender.cpp:
2177         (SavedEvent::SavedEvent):
2178         (EventSender::EventSender):
2179         (EventSender::keyDown):
2180         * DumpRenderTree/chromium/EventSender.h:
2181         * DumpRenderTree/chromium/ImageDiff.cpp:
2182         (Image::Image):
2183         * DumpRenderTree/chromium/LayoutTestController.cpp:
2184         (LayoutTestController::LayoutTestController):
2185         (LayoutTestController::WorkQueue::reset):
2186         (WorkItemBackForward::WorkItemBackForward):
2187         (WorkItemLoadingScript::WorkItemLoadingScript):
2188         (WorkItemNonLoadingScript::WorkItemNonLoadingScript):
2189         (WorkItemLoad::WorkItemLoad):
2190         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
2191         (LayoutTestController::pathToLocalResource):
2192         * DumpRenderTree/chromium/LayoutTestController.h:
2193         (LayoutTestController::WorkItem::~WorkItem):
2194         (LayoutTestController::WorkQueue::WorkQueue):
2195         * DumpRenderTree/chromium/MockSpellCheck.cpp:
2196         (MockSpellCheck::MockSpellCheck):
2197         (MockSpellCheck::~MockSpellCheck):
2198         * DumpRenderTree/chromium/MockSpellCheck.h:
2199         * DumpRenderTree/chromium/NotificationPresenter.h:
2200         (NotificationPresenter::NotificationPresenter):
2201         * DumpRenderTree/chromium/Task.cpp:
2202         (WebTask::WebTask):
2203         * DumpRenderTree/chromium/Task.h:
2204         (TaskList::TaskList):
2205         * DumpRenderTree/chromium/TestEventPrinter.cpp:
2206         (DRTPrinter::DRTPrinter):
2207         (TestShellPrinter::TestShellPrinter):
2208         * DumpRenderTree/chromium/TestNavigationController.cpp:
2209         (TestNavigationEntry::TestNavigationEntry):
2210         (TestNavigationEntry::~TestNavigationEntry):
2211         (TestNavigationController::TestNavigationController):
2212         (TestNavigationController::reload):
2213         (TestNavigationController::loadEntry):
2214         (TestNavigationController::didNavigateToEntry):
2215         * DumpRenderTree/chromium/TestNavigationController.h:
2216         (TestShellExtraData::TestShellExtraData):
2217         * DumpRenderTree/chromium/TestShell.cpp:
2218         (dumpHistoryItem):
2219         * DumpRenderTree/chromium/TestShell.h:
2220         (TestParams::TestParams):
2221         * DumpRenderTree/chromium/TestShellWin.cpp:
2222         (TestShell::waitTestFinished):
2223         * DumpRenderTree/chromium/TestWebWorker.h:
2224         (TestWebWorker::startWorkerContext):
2225         (TestWebWorker::terminateWorkerContext):
2226         (TestWebWorker::postMessageToWorkerContext):
2227         (TestWebWorker::clientDestroyed):
2228         (TestWebWorker::postMessageToWorkerObject):
2229         (TestWebWorker::postExceptionToWorkerObject):
2230         (TestWebWorker::postConsoleMessageToWorkerObject):
2231         (TestWebWorker::confirmMessageFromWorkerObject):
2232         (TestWebWorker::reportPendingActivity):
2233         (TestWebWorker::workerContextClosed):
2234         (TestWebWorker::~TestWebWorker):
2235         * DumpRenderTree/chromium/TextInputController.cpp:
2236         * DumpRenderTree/chromium/WebThemeControlDRTWin.h:
2237         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
2238         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
2239         (WebThemeEngineDRTWin::paintButton):
2240         (WebThemeEngineDRTWin::paintMenuList):
2241         (WebThemeEngineDRTWin::paintTrackbar):
2242         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h:
2243         (WebThemeEngineDRTWin::WebThemeEngineDRTWin):
2244         * DumpRenderTree/chromium/WebViewHost.cpp:
2245         (WebViewHost::navigate):
2246         (WebViewHost::updateSessionHistory):
2247         (WebViewHost::paintInvalidatedRegion):
2248         * DumpRenderTree/chromium/WebViewHost.h:
2249
2250 2011-05-19  Dmitry Lomov  <dslomov@google.com>
2251
2252         Reviewed by Adam Roben.
2253
2254         Detect hangs in run-api-tests
2255         https://bugs.webkit.org/show_bug.cgi?id=48043
2256
2257         * Scripts/run-api-tests: Added test timeouts
2258
2259 2011-05-19  Dmitry Lomov  <dslomov@google.com>
2260
2261         Reviewed by Adam Roben.
2262
2263         run-api-tests should run one test per process
2264         https://bugs.webkit.org/show_bug.cgi?id=61088
2265
2266         * Scripts/run-api-tests: Resurrecting the previous revison of this file, with fixes to system call under Windows, 
2267         return code, and parsing GTest output format.
2268
2269 2011-05-15  Robert Hogan  <robert@webkit.org>
2270
2271         Reviewed by Antonio Gomes.
2272
2273         [Qt][GTK] plugins/get-url-with-javascript-url.html fails
2274         https://bugs.webkit.org/show_bug.cgi?id=60834
2275         Fix unix test plugin for plugins/get-url-with-javascript-url.html
2276
2277         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2278         (webkit_test_plugin_new_stream):
2279         (webkit_test_plugin_write_ready):
2280         (webkit_test_plugin_write):
2281
2282 2011-05-19  Sheriff Bot  <webkit.review.bot@gmail.com>
2283
2284         Unreviewed, rolling out r86869, r86873, r86875, and r86877.
2285         http://trac.webkit.org/changeset/86869
2286         http://trac.webkit.org/changeset/86873
2287         http://trac.webkit.org/changeset/86875
2288         http://trac.webkit.org/changeset/86877
2289         https://bugs.webkit.org/show_bug.cgi?id=61139
2290
2291         broke builds and debug DRT (Requested by rniwa on #webkit).
2292
2293         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2294         * DumpRenderTree/chromium/TestShell.cpp:
2295         (TestShell::bindJSObjectsToWindow):
2296         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2297         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
2298
2299 2011-05-18  Dimitri Glazkov  <dglazkov@chromium.org>
2300
2301         Reviewed by Darin Adler.
2302
2303         Add build logistics and plumbing for window.internals object.
2304         https://bugs.webkit.org/show_bug.cgi?id=60313
2305
2306         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added linking new WebCoreTestSupport library.
2307         * DumpRenderTree/chromium/TestShell.cpp:
2308         (TestShell::bindJSObjectsToWindow): Added injection code.
2309         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2310         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]): Ditto.
2311
2312 2011-05-19  Zsolt Fehér  <h490267@stud.u-szeged.hu>
2313
2314         Reviewed by Csaba Osztrogonác.
2315
2316         [Qt] Implement eventSender.scalePageBy
2317         https://bugs.webkit.org/show_bug.cgi?id=60015
2318
2319         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2320         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2321         * DumpRenderTree/qt/EventSenderQt.cpp:
2322         (EventSender::scalePageBy):
2323         * DumpRenderTree/qt/EventSenderQt.h:
2324
2325 2011-05-19  Kenichi Ishibashi  <bashi@chromium.org>
2326
2327         Reviewed by Kent Tamura.
2328
2329         [Chromium] IME candidate window appears wrong position in an iframe
2330         https://bugs.webkit.org/show_bug.cgi?id=61023
2331
2332         Call the focused frame's firstRectForCharacterRange() instead of the
2333         main frame so that DRT behaves as the same as Chromium.
2334
2335         * DumpRenderTree/chromium/TextInputController.cpp:
2336         (TextInputController::firstRectForCharacterRange):
2337
2338 2011-05-18  Adam Roben  <aroben@apple.com>
2339
2340         Add a new page to build.webkit.org to help find when tests started failing
2341
2342         The page is accessible at <http://build.webkit.org/TestFailures/>. It is pretty minimalist
2343         right now, but already shows some useful information. It's somewhat similar to webkit-patch
2344         failure-reason and sheriffbot, and perhaps can be combined with them eventually. It's a
2345         little more convenient than either of them, though, because it's all done in the browser
2346         (and thus it's easy to go directly to the relevant test results).
2347
2348         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js: Added.
2349         (Buildbot): This class represents a Buildbot server.
2350         (Buildbot.prototype.buildURL): Returns the URL for the summary page for a particular build.
2351         (Buildbot.prototype.builderNamed): Returns a Builder with the given name.
2352         (Buildbot.prototype.getTesterNames): Fetches the names of all testers and passes them to the
2353         callback.
2354         (Buildbot.prototype.parseBuildName): Breaks up a build name into its constituent parts. Must
2355         be implemented by a derived class that understands this server's build naming scheme.
2356         (Buildbot.prototype.resultsDirectoryURL): Returns the URL for the results directory for a
2357         particular build.
2358
2359         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js: Added.
2360         (Builder): This class represents one builder on the buildbot.
2361         (Builder.prototype.buildURL): Returns the URL for the summary page for a particular build.
2362         (Builder.prototype.failureDiagnosisTextAndURL): Returns data that provides a little more
2363         information about a particular test failure.
2364         (Builder.prototype.startFetchingBuildHistory): Periodically calls the callback with
2365         information about when tests started failing.
2366         (Builder.prototype.resultsDirectoryURL): Returns the URL for the results directory for a
2367         particular build.
2368         (Builder.prototype._getBuildNames): Fetches the names of all builds and passes them to the
2369         callback.
2370         (Builder.prototype._getFailingTests): Fetches the results.html page for the given build and
2371         extracts all the failing tests listed in it, passing them to the callback.
2372         (Builder.prototype._incorporateBuildHistory): Gets the failing tests for the specified
2373         build, merges them into the build history, and calls the callback telling it whether the
2374         next build should be fetched to provide more information.
2375
2376         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
2377         Added. Just some simple styles.
2378
2379         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js: Added.
2380         (createDefinitionList): Takes an array of pairs and turns them into a DL element.
2381         (getResource): Wrapper around XMLHttpRequest.
2382         (Array.prototype.findFirst): Finds the first element matching the given predicate and
2383         returns it.
2384         (Array.prototype.last): Returns the last element of the array.
2385
2386         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js: Added.
2387         (ViewController): This class contains the main logic for displaying the page.
2388         (ViewController.loaded): Just calls through to parseHash.
2389         (ViewController.parseHash): Either starts analyzing failures on a particular builder, or
2390         shows the list of all testers so one can be chosen. This function is called when the page
2391         loads and whenever we get a hashchange event.
2392         (ViewController._displayBuilder): Asks the builder to fetch build history, and displays it
2393         as it is fetched. The display ends up grouping tests by when they started failing.
2394         (ViewController._displayTesters): Gets the list of testers and displays it.
2395
2396         (ViewController._domForBuildName):
2397         (ViewController._domForFailedTest):
2398         Helper functions to create descriptions and links for a particular build or failed test.
2399
2400         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBuildbot.js: Added.
2401         (WebKitBuildbot): Calls up to the base class constructor with the correct base URL.
2402         (WebKitBuildbot.prototype.parseBuildName): Parses a build.webkit.org-style build name.
2403
2404         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Added. Just
2405         loads all the files and sets up a ViewController, which does the rest.
2406
2407         * BuildSlaveSupport/build.webkit.org-config/templates/root.html: Added a link to the new
2408         page.
2409
2410 2011-05-18  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
2411
2412         Reviewed by Csaba Osztrogonác.
2413
2414         [Qt] Implement layoutTestController.setValueForUser()
2415         https://bugs.webkit.org/show_bug.cgi?id=60956
2416
2417         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2418         (LayoutTestController::setValueForUser):
2419         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2420
2421 2011-05-16  Robert Hogan  <robert@webkit.org>
2422
2423         Reviewed by Kenneth Rohde Christiansen.
2424
2425         plugins/invalidate_rect.html fails on linux ports
2426
2427         - Make the unix test netscape plugin recognize the onPaintEvent
2428           and windowedPlugin parameters.
2429
2430         https://bugs.webkit.org/show_bug.cgi?id=54051
2431
2432         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2433         (handleEventX11):
2434         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2435         (LayoutTestController::displayInvalidatedRegion):
2436         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2437         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2438         (webkit_test_plugin_new_instance):
2439         (webkit_test_plugin_handle_event):
2440
2441 2011-05-17  Tony Chang  <tony@chromium.org>
2442
2443         Reviewed by Ojan Vafai.
2444
2445         [chromium] move Lucid 64 bit results into LayoutTests/platform/chromium-linux
2446         https://bugs.webkit.org/show_bug.cgi?id=60895
2447
2448         Update the tools to handle the move.  Lucid 32 results now go in
2449         chromium-linux-x86 and the default platform on Linux is now x86_64.
2450
2451         * Scripts/webkitpy/layout_tests/deduplicate_tests.py: Default to x86_64
2452         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
2453         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py: Default to Lucid
2454         * Scripts/webkitpy/layout_tests/port/base.py: ditto
2455         * Scripts/webkitpy/layout_tests/port/chromium_linux.py: Update directory fallback and default to Lucid 64
2456         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
2457         * Scripts/webkitpy/layout_tests/port/test.py: Update tests to default to x86_64
2458         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: Update bot names.
2459         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py: Whitespace cleanup.
2460
2461 2011-05-17  Adam Roben  <aroben@apple.com>
2462
2463         Make run-api-tests work on Windows when there are spaces in the path
2464
2465         Fixes <http://webkit.org/b/60954> REGRESSION (r86511): run-api-tests fails if there are
2466         spaces in the path to TestWebKitAPI.exe
2467
2468         Reviewed by David Levin.
2469
2470         * Scripts/run-api-tests:
2471         (runTestTool): Use the "direct object" form of system() to avoid having the path to
2472         TestWebKitAPI.exe be split by the shell.
2473
2474 2011-05-16  Ian Henderson  <ianh@apple.com>
2475
2476         Reviewed by Joseph Pecoraro.
2477
2478         Page::goToItem doesn't work while loading is deferred
2479         https://bugs.webkit.org/show_bug.cgi?id=60412
2480
2481         Add setDefersLoading and goBack methods to LayoutTestController.  We
2482         need to use goBack() instead of history.back() because the latter goes
2483         through NavigationScheduler, hence doesn't exhibit the bug.
2484
2485         * DumpRenderTree/LayoutTestController.cpp:
2486         (goBackCallback):
2487         (setDefersLoadingCallback):
2488         (LayoutTestController::staticFunctions):
2489         * DumpRenderTree/LayoutTestController.h:
2490         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2491         (LayoutTestController::goBack):
2492         (LayoutTestController::setDefersLoading):
2493         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2494         (LayoutTestController::goBack):
2495         (LayoutTestController::setDefersLoading):
2496         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2497         (LayoutTestController::goBack):
2498         (LayoutTestController::setDefersLoading):
2499         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2500         (LayoutTestController::goBack):
2501         (LayoutTestController::setDefersLoading):
2502
2503 2011-05-16  Sam Weinig  <sam@webkit.org>
2504
2505         Reviewed by Anders Carlsson.
2506
2507         TestWebKitAPI should build with clang if it can
2508         https://bugs.webkit.org/show_bug.cgi?id=60918
2509
2510         * TestWebKitAPI/Configurations/CompilerVersion.xcconfig:
2511         Update CompilerVersion.xcconfig to match others.
2512
2513         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2514         Add CompilerVersion.xcconfig to the project.
2515
2516         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
2517         (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame):
2518         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
2519         (TestWebKitAPI::didSameDocumentNavigationForFrame):
2520         Add some casts to quiet warnings from clang.
2521
2522 2011-05-16  Dirk Pranke  <dpranke@chromium.org>
2523
2524         Reviewed by David Levin.
2525
2526         add dpranke as a reviewer
2527         https://bugs.webkit.org/show_bug.cgi?id=60919
2528
2529         * Scripts/webkitpy/common/config/committers.py:
2530
2531 2011-05-16  Robert Hogan  <robert@webkit.org>
2532
2533         Reviewed by Anders Carlsson.
2534
2535         [Gtk] plugins/get-url-notify-with-url-that-fails-to-load.html crashes on buildbot
2536
2537         https://bugs.webkit.org/show_bug.cgi?id=60838
2538
2539         The unix test plugin needs to call the test's NPP_URLNotify
2540         rather than the browsers.
2541
2542         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2543         (webkit_test_plugin_url_notify):
2544
2545 2011-05-16  Brent Fulgham  <bfulgham@webkit.org>
2546
2547         Rubber-stamped by Adam Roben.
2548
2549         Adding myself as a reviewer.
2550         * Scripts/webkitpy/common/config/committers.py:
2551
2552 2011-05-16  Sam Weinig  <sam@webkit.org>
2553
2554         Fix typo pointed out by Dave Levin.
2555
2556         * TestWebKitAPI/PlatformUtilities.h:
2557         (TestWebKitAPI::Util::assertWKStringEqual):
2558         Strig -> String.
2559
2560 2011-05-16  Sam Weinig  <sam@webkit.org>
2561
2562         Reviewed by David Levin.
2563
2564         Convert api tester over to using gtest expectations directly
2565         https://bugs.webkit.org/show_bug.cgi?id=60862
2566
2567         * TestWebKitAPI/PlatformUtilities.cpp:
2568         (TestWebKitAPI::Util::toSTD):
2569         * TestWebKitAPI/PlatformUtilities.h:
2570         (TestWebKitAPI::Util::assertWKStrigEqual):
2571         Add convenience macro to compare WK2 strings. Add some overloads of toSTD to make
2572         the implementation of the macro simpler.
2573
2574         * TestWebKitAPI/Test.h:
2575         Remove TEST_ASSERT forwarder.
2576
2577         [Test changes elided]
2578
2579 2011-05-16  David Kilzer  <ddkilzer@apple.com>
2580
2581         <http://webkit.org/b/60913> C++ exceptions should not be enabled when building with llvm-gcc-4.2
2582         <rdar://problem/9446430>
2583
2584         Reviewed by Mark Rowe.
2585
2586         * MiniBrowser/Configurations/Base.xcconfig: Fixed typo.
2587         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
2588         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
2589
2590 2011-05-16  Jon Lee  <jonlee@apple.com>
2591
2592         Reviewed by Simon Fraser.
2593
2594         Can't horizontally scroll iframes and overflow because wheel events are always accepted
2595         https://bugs.webkit.org/show_bug.cgi?id=60779
2596
2597         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2598         (WTR::InjectedBundlePage::InjectedBundlePage): Set new default method to nil.
2599
2600 2011-05-16  Ademar de Souza Reis Jr.  <ademar.reis@openbossa.org>
2601
2602         Reviewed by Csaba Osztrogonác.
2603
2604         [Qt] Tools.pro misses include(common.pri)
2605         https://bugs.webkit.org/show_bug.cgi?id=60883
2606
2607         It includes features.pri, which depends on common.pri (the build is
2608         not broken today with the default options, but this is the right
2609         thing to do).
2610
2611         * Tools.pro:
2612
2613 2011-05-15  Dominic Cooney  <dominicc@chromium.org>
2614
2615         Unreviewed: adding myself to committers.py.
2616
2617         * Scripts/webkitpy/common/config/committers.py:
2618
2619 2011-05-15  Daniel Bates  <dbates@webkit.org>
2620
2621         Reviewed by Chris Jerdonek.
2622
2623         svn-apply can't handle Git diff that only changes executable bit
2624         https://bugs.webkit.org/show_bug.cgi?id=60848
2625
2626         Fixes an issue where svn-{apply, unapply} fail to handle a Git diff for a file
2627         that only has an executable bit change.
2628
2629         * Scripts/VCSUtils.pm:
2630           - Modified regex $chunkRangeRegEx to match chunk range with ending text, say: @@ -2,6 +2,18 @@ foo().
2631         (parseDiff): Modified to count the number of text chunks in the diff. This should also help towards
2632         fixing <https://bugs.webkit.org/show_bug.cgi?id=29684>.
2633         * Scripts/svn-apply:
2634         (patch): Only use standard patch tool if the patch is non-empty and for a text file (i.e. not a binary patch).
2635         * Scripts/svn-unapply:
2636         (patch): Ditto.
2637         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
2638           - Updated expected results for test cases to account for numTextChunks.
2639           - Fixed malformed chunk range in test cases: "Git: simple", and "Git: Git diff followed by SVN diff".
2640           - Added test case "Git: file that only has an executable bit change".
2641         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
2642           - Updated expected results for test cases to account for numTextChunks.
2643
2644 2011-05-15  Sam Weinig  <sam@webkit.org>
2645
2646         Fix windows build.
2647
2648         * TestWebKitAPI/win/main.cpp:
2649         (main):
2650
2651 2011-05-15  Sam Weinig  <sam@webkit.org>
2652
2653         Reviewed by David Levin.
2654
2655         Make API tester more gtest friendly
2656         https://bugs.webkit.org/show_bug.cgi?id=60859
2657
2658         * Scripts/run-api-tests:
2659         Numerous changes:
2660         - Remove logic to run tests one at a time.
2661         - Remove logic to build up a list of tests, instead just pass --gtest_list_tests to 
2662           the test runner and allow gtest to print it for us.
2663         - Forward stdout from the test tool to stdout, even in non-verbose runs.
2664         - Run test tool from the current working directory instead of the root webkit
2665           directory.
2666
2667         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2668         Move plist to be with other bundle sources.
2669
2670         * TestWebKitAPI/TestsController.cpp:
2671         (TestWebKitAPI::TestsController::TestsController):
2672         (TestWebKitAPI::TestsController::run):
2673         * TestWebKitAPI/TestsController.h:
2674         * TestWebKitAPI/mac/main.mm:
2675         Simplify TestController down to a single run function. We should consider removing the class
2676         entirely at some point.
2677
2678 2011-05-15  Sheriff Bot  <webkit.review.bot@gmail.com>
2679
2680         Unreviewed, rolling out r86504.
2681         http://trac.webkit.org/changeset/86504
2682         https://bugs.webkit.org/show_bug.cgi?id=60853
2683
2684         "Broke Qt EventSender in editing/selection tests" (Requested
2685         by mwenge on #webkit).
2686
2687         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2688         (WebCore::WebPage::WebPage):
2689         (WebCore::DumpRenderTree::DumpRenderTree):
2690         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2691         (WebCore::DumpRenderTree::initJSObjects):
2692         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2693         (WebCore::DumpRenderTree::eventSender):
2694         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2695         (webkit_test_plugin_new_instance):
2696         (webkit_test_plugin_set_window):
2697         (webkit_test_plugin_handle_event):
2698
2699 2011-05-12  Robert Hogan  <robert@webkit.org>
2700
2701         Reviewed by Benjamin Poulain.
2702
2703         [Qt] fix http/tests/plugins/plugin-document-has-focus.html
2704
2705         The support for this test added to the unix test plugin here
2706         may allow other platforms to pass it (nearly everyone
2707         skips it). On Qt it required a bit of trickiness with
2708         the page's EventSender object to get it working fully though,
2709         so only unskipping Qt here.
2710
2711         https://bugs.webkit.org/show_bug.cgi?id=60722
2712
2713         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2714         (WebCore::WebPage::WebPage):
2715         (WebCore::WebPage::eventSender):
2716         (WebCore::DumpRenderTree::DumpRenderTree):
2717         (WebCore::DumpRenderTree::initJSObjects):
2718         (WebCore::DumpRenderTree::createWindow):
2719         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2720         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2721         (webkit_test_plugin_new_instance):
2722         (webkit_test_plugin_set_window):
2723         (webkit_test_plugin_handle_event):
2724
2725 2011-05-14  Arno Renevier  <arno@renevier.net>
2726
2727         Reviewed by Martin Robinson.
2728
2729         make run-gtk-tests executable
2730         https://bugs.webkit.org/show_bug.cgi?id=59278
2731
2732         * Scripts/run-gtk-tests:
2733
2734 2011-05-14  Anders Carlsson  <andersca@apple.com>
2735
2736         Reviewed by Kevin Decker.
2737
2738         NPP_URLNotify is not called if a URL passed to NPN_GetURLNotify fails to load
2739         https://bugs.webkit.org/show_bug.cgi?id=60823
2740         <rdar://problem/9430386>
2741
2742         Add test that calls NPN_GetURLNotify on a URL that can't be loaded, and checks if NPP_URLNotify is called.
2743
2744         * DumpRenderTree/DumpRenderTree.gypi:
2745         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2746         * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLNotifyWithURLThatFailsToLoad.cpp: Added.
2747         (GetURLNotifyWithURLThatFailsToLoad::GetURLNotifyWithURLThatFailsToLoad):
2748         (GetURLNotifyWithURLThatFailsToLoad::NPP_New):
2749         (GetURLNotifyWithURLThatFailsToLoad::NPP_URLNotify):
2750         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2751         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2752         * GNUmakefile.am:
2753
2754 2011-05-14  Sheriff Bot  <webkit.review.bot@gmail.com>
2755
2756         Unreviewed, rolling out r86476.
2757         http://trac.webkit.org/changeset/86476
2758         https://bugs.webkit.org/show_bug.cgi?id=60832
2759
2760         It made plugins/get-url-notify-with-url-that-fails-to-
2761         load.html crash on GTK (Requested by Ossy on #webkit).
2762
2763         * DumpRenderTree/DumpRenderTree.gypi:
2764         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2765         * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLNotifyWithURLThatFailsToLoad.cpp: Removed.
2766         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2767         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2768         * GNUmakefile.am:
2769
2770 2011-05-13  Anders Carlsson  <andersca@apple.com>
2771
2772         Reviewed by Sam Weinig.
2773
2774         NPP_URLNotify is not called if a URL passed to NPN_GetURLNotify fails to load
2775         https://bugs.webkit.org/show_bug.cgi?id=60823
2776         <rdar://problem/9430386>
2777
2778         Add test that calls NPN_GetURLNotify on a URL that can't be loaded, and checks if NPP_URLNotify is called.
2779
2780         * DumpRenderTree/DumpRenderTree.gypi:
2781         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2782         * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLNotifyWithURLThatFailsToLoad.cpp: Added.
2783         (GetURLNotifyWithURLThatFailsToLoad::GetURLNotifyWithURLThatFailsToLoad):
2784         (GetURLNotifyWithURLThatFailsToLoad::NPP_New):
2785         (GetURLNotifyWithURLThatFailsToLoad::NPP_URLNotify):
2786         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2787         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2788         * GNUmakefile.am:
2789
2790 2011-05-13  Anders Carlsson  <andersca@apple.com>
2791
2792         Build fix.
2793
2794         * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLWithJavaScriptURL.cpp:
2795
2796 2011-05-13  Anders Carlsson  <andersca@apple.com>
2797
2798         Reviewed by Sam Weinig.
2799
2800         NPN_GetURL with a javascript: URL doesn't send back the result in the stream
2801         https://bugs.webkit.org/show_bug.cgi?id=60810
2802
2803         Add a test that calls NPN_GetURL on a javascript: URL and checks that it gets back the expected result.
2804
2805         * DumpRenderTree/DumpRenderTree.gypi:
2806         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2807         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2808         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2809         * GNUmakefile.am:
2810         Add files.
2811
2812         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2813         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
2814         Add new NPN and NPP wrappers and sort them according to the order they appear in npfunctions.h
2815
2816         * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLWithJavaScriptURL.cpp: Added.
2817         (GetURLWithJavaScriptURL::GetURLWithJavaScriptURL):
2818         (GetURLWithJavaScriptURL::NPP_New):
2819         (GetURLWithJavaScriptURL::NPP_NewStream):
2820         (GetURLWithJavaScriptURL::NPP_DestroyStream):
2821         (GetURLWithJavaScriptURL::NPP_WriteReady):
2822         (GetURLWithJavaScriptURL::NPP_Write):
2823         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2824         (NPP_NewStream):
2825         (NPP_WriteReady):
2826         (NPP_Write):
2827         (NPP_URLNotify):
2828         call the PluginTest NPP wrappers.
2829
2830 2011-05-13  Sheriff Bot  <webkit.review.bot@gmail.com>
2831
2832         Unreviewed, rolling out r86447.
2833         http://trac.webkit.org/changeset/86447
2834         https://bugs.webkit.org/show_bug.cgi?id=60809
2835
2836         "Broke some uses of EventSender object on Qt" (Requested by
2837         mwenge on #webkit).
2838
2839         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2840         (WebCore::WebPage::WebPage):
2841         (WebCore::DumpRenderTree::DumpRenderTree):
2842         (WebCore::DumpRenderTree::initJSObjects):
2843         (WebCore::DumpRenderTree::createWindow):
2844         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2845         (WebCore::DumpRenderTree::eventSender):
2846         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2847         (webkit_test_plugin_new_instance):
2848         (webkit_test_plugin_set_window):
2849         (webkit_test_plugin_handle_event):
2850
2851 2011-05-13  Robert Hogan  <robert@webkit.org>
2852
2853         Reviewed by Benjamin Poulain.
2854
2855         [Qt] fix http/tests/plugins/plugin-document-has-focus.html
2856
2857         The support for this test added to the unix test plugin here
2858         may allow other platforms to pass it (nearly everyone
2859         skips it). On Qt it required a bit of trickiness with
2860         the page's EventSender object to get it working fully though,
2861         so only unskipping Qt here.
2862
2863         https://bugs.webkit.org/show_bug.cgi?id=60722
2864
2865         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2866         (WebCore::WebPage::WebPage):
2867         (WebCore::WebPage::eventSender):
2868         (WebCore::DumpRenderTree::DumpRenderTree):
2869         (WebCore::DumpRenderTree::initJSObjects):
2870         (WebCore::DumpRenderTree::createWindow):
2871         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2872         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2873         (webkit_test_plugin_new_instance):
2874         (webkit_test_plugin_set_window):
2875         (webkit_test_plugin_handle_event):
2876
2877 2011-05-13  Adam Roben  <aroben@apple.com>
2878
2879         Exclude the Leopard NRWT bot from the core builder set
2880
2881         Fixes <http://webkit.org/b/60392> Leopard Intel Release (NRWT) shouldn't be a core builder
2882
2883         Reviewed by Darin Adler.
2884
2885         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2886         (BuildBot.__init__): Tighten up the Leopard regexp to only allow the non-NRWT Leopard bots
2887         in the core builder set.
2888
2889         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2890         (BuildBotTest.test_builder_name_regexps): Updated to match the current set of builders and
2891         regexps.
2892
2893 2011-05-13  Adam Roben  <aroben@apple.com>
2894
2895         Group all the NRWT bots together
2896
2897         This also gets the new NRWT bots out of the middle of Apple's bots. Since these new NRWT
2898         bots are experimental, it seems best not to clutter up the non-experimental bots with
2899         experimental ones.
2900
2901         Fixes <http://webkit.org/b/60769> New "(NRWT)" bots are right in the middle of Apple's bots
2902         on build.webkit.org
2903
2904         Reviewed by Dan Bernstein.
2905
2906         * BuildSlaveSupport/build.webkit.org-config/config.json: Moved the "(NRWT)" bots next to the
2907         Chromium testers, which also use new-run-webkit-tests.
2908
2909 2011-05-13  Adam Roben  <aroben@apple.com>
2910
2911         Add a plugin test that dumps the plugin window's rect
2912
2913         Part of the test for <http://webkit.org/b/60194> <rdar://problem/9383760> REGRESSION
2914         (r79167): Windowed plugins in Google Reader don't move when the article list is scrolled
2915
2916         Reviewed by Dan Bernstein.
2917
2918         * DumpRenderTree/TestNetscapePlugIn/Tests/win/DumpWindowRect.cpp: Added.
2919         (DumpWindowRect::DumpWindowRect): Just call up to the base class.
2920         (DumpWindowRect::performWindowGeometryTest): Find our window rect relative to the test
2921         harness window and log it.
2922
2923         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Added DumpWindowRect.
2924
2925 2011-05-13  Adam Roben  <aroben@apple.com>
2926
2927         Move code required for most tests of plugin window geometry into a base class
2928
2929         WebKit2's asynchronous plugin window positioning makes testing window geometry tricky. By
2930         having all the trickiness in a shared base class, writing new window geometry tests will be
2931         much easier.
2932
2933         Fixes <http://webkit.org/b/60776> It's hard to write tests that check plugin window geometry
2934
2935         Reviewed by Anders Carlsson.
2936
2937         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowRegionIsSetToClipRect.cpp:
2938         (WindowRegionIsSetToClipRect::WindowRegionIsSetToClipRect): Changed to inherit from the new
2939         WindowGeometryTest base class. Most of the code from this class was moved to the new base
2940         class.
2941         (WindowRegionIsSetToClipRect::performWindowGeometryTest): Renamed from checkWindowRegion.
2942         This is called by the base class when it is safe to check the window's geometry. Note that
2943         the m_didCheckWindowRegion logic was removed completely; it has never been needed and was
2944         just vestigial code from an earlier version of this test.
2945
2946         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Added new
2947         WindowGeometryTest class.
2948
2949         * DumpRenderTree/TestNetscapePlugIn/win/WindowGeometryTest.cpp: Added. Code came from
2950         WindowRegionIsSetToClipRect.
2951         (WindowGeometryTest::finishTest): This is the only change from WindowRegionIsSetToClipRect.
2952         We now call the new virtual performWindowGeometryTest function instead of checkWindowRegion.
2953         Subclasses can implement that function to perform their own tests.
2954
2955         * DumpRenderTree/TestNetscapePlugIn/win/WindowGeometryTest.h: Added.
2956
2957 2011-05-13  Zoltan Herczeg  <zherczeg@webkit.org>
2958
2959         Reviewed by Csaba Osztrogonác.
2960
2961         Missing 2nd #EOF if WebProcess is killed.
2962         https://bugs.webkit.org/show_bug.cgi?id=60761
2963
2964         If the WebProcess is killed, only one #EOF is yielded
2965         by WebKitTestRunner. However, run-webkit-test wait for
2966         a second #EOF, which signals the finishing of pixel dump.
2967         Since this never happens, run-webkit-test waits forever.
2968
2969         * WebKitTestRunner/TestInvocation.cpp:
2970         (WTR::TestInvocation::dump):
2971         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2972         * WebKitTestRunner/TestInvocation.h:
2973
2974 2011-05-13  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
2975
2976         Reviewed by Csaba Osztrogonác.
2977
2978         [NRWT] chromium-linux tests shouldn't run on other platforms
2979         https://bugs.webkit.org/show_bug.cgi?id=60162
2980
2981         Remove _tests_for_other_platforms defs because r82753
2982         implemented it properly in the baseclass in webkit.py.
2983
2984         * Scripts/webkitpy/layout_tests/port/gtk.py:
2985         * Scripts/webkitpy/layout_tests/port/qt.py:
2986         * Scripts/webkitpy/layout_tests/port/win.py:
2987
2988 2011-05-12  Ryuan Choi  <ryuan.choi@samsung.com>
2989
2990         Reviewed by Antonio Gomes.
2991
2992         [EFL] Remove unused option of EWeblauncher
2993         https://bugs.webkit.org/show_bug.cgi?id=60747
2994
2995         Remove sudo-workaround option.
2996         This option is not used and make other option wrong.
2997
2998         * EWebLauncher/main.c:
2999
3000 2011-05-12  Lucas Forschler  <lforschler@apple.com>
3001
3002         Reviewed by Stephanie Lewis.
3003
3004         Fix config.json to address missing WK2 builder/tester config.
3005         Fix naming of machines (xserve not macpro)
3006
3007         * BuildSlaveSupport/build.webkit.org-config/config.json:
3008
3009 2011-05-12  Lucas Forschler  <lforschler@apple.com>
3010
3011         Reviewed by Stephanie Lewis.
3012
3013         Add SnowLeopard Debug builder and Test bot.
3014         apple-xserve-8 = SL Debug Tester.
3015         apple-xserve-9 = SL Debug Builder.
3016         
3017         * BuildSlaveSupport/build.webkit.org-config/config.json:
3018
3019 2011-05-12  Adam Barth  <abarth@webkit.org>
3020
3021         This patch disables sheriffbot's bug postings.  He's just been way too
3022         spammy recently due to test flakiness.
3023
3024         * Scripts/webkitpy/tool/commands/sheriffbot.py:
3025         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
3026
3027 2011-05-11  Brian Weinstein  <bweinstein@apple.com>
3028
3029         Reviewed by Anders Carlsson.
3030
3031         After relaunching an unresponsive web process, web page stops responding to mouse movement
3032         https://bugs.webkit.org/show_bug.cgi?id=60669
3033         <rdar://problem/9409934>
3034         
3035         This test follows the steps needed to reproduce this bug:
3036         1) Hang the web process
3037         2) While the web process is hung, move the mouse (so WebPageProxy thinks it is processing a mouse move event)
3038         3) Kill and restart the WebProcess
3039         4) Move the mouse
3040         
3041         We are testing that we receive mouse move events after the WebProcess has restarted.
3042
3043         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp: Added.
3044         (TestWebKitAPI::didFinishLoadForFrame): Set a flag that we finished loading.
3045         (TestWebKitAPI::processDidBecomeUnresponsive): Kill the web process once we become unresponsive.
3046         (TestWebKitAPI::processDidCrash): Reload the page when the process crashes, which restarts the web process.
3047         (TestWebKitAPI::setPageLoaderClient):
3048         (TestWebKitAPI::TEST):
3049         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash_Bundle.cpp: Added.
3050         (TestWebKitAPI::MouseMoveAfterCrashTest::MouseMoveAfterCrashTest):
3051         (TestWebKitAPI::MouseMoveAfterCrashTest::didReceiveMessage):
3052         * TestWebKitAPI/Tests/WebKit2/mouse-move-listener.html: Added.
3053
3054         * TestWebKitAPI/PlatformWebView.h:
3055         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3056         (TestWebKitAPI::PlatformWebView::simulateMouseMove): Sends the messages that simulate a mouse move.
3057         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
3058         (TestWebKitAPI::PlatformWebView::simulateMouseMove): Ditto.
3059
3060         Add new files.
3061         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3062         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3063         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
3064         * TestWebKitAPI/win/copy-resources.cmd:
3065
3066 2011-05-12  Tomasz Morawski  <t.morawski@samsung.com>
3067
3068         Reviewed by Antonio Gomes.
3069
3070         [EFL] Added initialization/shutdown for ecore_file library
3071         https://bugs.webkit.org/show_bug.cgi?id=60457
3072
3073         Added initialization and shuthown for ecore_file library and replaced
3074         realpath function to ecore_file_realpath.
3075
3076         * EWebLauncher/main.c:
3077         (quit):
3078         (findThemePath):
3079         (main):
3080
3081 2011-05-12  Young Han Lee  <joybro@company100.net>
3082
3083         Reviewed by Kenneth Rohde Christiansen.
3084
3085         [Qt] Implement layoutTestController.layerTreeAsText()
3086         https://bugs.webkit.org/show_bug.cgi?id=60367
3087
3088         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3089         (LayoutTestController::layerTreeAsText):
3090         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3091
3092 2011-05-11  Eric Seidel  <eric@webkit.org>
3093
3094         Reviewed by David Levin.
3095
3096         Teach validate-committer-lists how to validate committers bugzilla_email()
3097         https://bugs.webkit.org/show_bug.cgi?id=60651
3098
3099         It turns out we currently have 9 committers with invalid values for their
3100         bugzilla_email field (meaning we don't know what email is their bugzilla account).
3101         "Alexander Kellett" <lypanov@mac.com>
3102         "Andre Boule" <aboule@apple.com>
3103         "Cameron McCormack" <cam@webkit.org>
3104         "Chris Petersen" <cpetersen@apple.com>
3105         "Eli Fidler" <eli@staikos.net>
3106         "Matt Lilek" <webkit@mattlilek.com>
3107         "Pierre d'Herbemont" <pdherbemont@free.fr>
3108         "Scott Violet" <sky@chromium.org>
3109         "Adam Treat" <treat@kde.org>
3110
3111         Most of those haven't committed in a very long time, so it's not suprising
3112         that we haven't noticed that their bugzilla emails are bogus.
3113
3114         * Scripts/validate-committer-lists:
3115         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3116         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
3117
3118 2011-05-11  Dmitry Lomov  <dslomov@google.com>
3119
3120         Reviewed by David Levin.
3121
3122         https://bugs.webkit.org/show_bug.cgi?id=59561
3123         Switch TestWebKitAPI to GTest
3124
3125         Fixes Makefiles and WinCairo build as well
3126
3127         * Makefile:
3128         * Scripts/build-api-tests:
3129         * Scripts/run-api-tests:
3130         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
3131         * TestWebKitAPI/Test.h:
3132         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3133         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
3134         (TestWebKitAPI::TEST):
3135         * TestWebKitAPI/TestsController.cpp:
3136         (TestWebKitAPI::TestsController::TestsController):
3137         (TestWebKitAPI::TestsController::dumpTestNames):
3138         (TestWebKitAPI::TestsController::runTestNamed):
3139         (TestWebKitAPI::TestsController::runAllTests):
3140         * TestWebKitAPI/TestsController.h:
3141         * TestWebKitAPI/mac/main.mm:
3142         (main):
3143
3144 2011-05-11  Eric Seidel  <eric@webkit.org>
3145
3146         Reviewed by Alexey Proskuryakov.
3147
3148         Add Luke Macpherson to committers.py as a Contributor
3149         https://bugs.webkit.org/show_bug.cgi?id=60639
3150
3151         * Scripts/webkitpy/common/config/committers.py:
3152
3153 2011-05-11  Noam Rosenthal  <noam.rosenthal@nokia.com>
3154
3155         Reviewed by Kenneth Rohde Christiansen.
3156
3157         [Texmap][Qt] Upstream texture-mapper changes from Qt's WebKit2 branch
3158         https://bugs.webkit.org/show_bug.cgi?id=60439
3159
3160         Patch 4/12: Update the build script to enable 3D rendering by default for Qt.
3161
3162         * Scripts/build-webkit:
3163
3164 2011-05-11  Brian Weinstein  <bweinstein@apple.com>
3165
3166         Reviewed by Adam Roben.
3167
3168         REGRESSION (r86161): WKPreferences API test failing on Windows
3169         https://bugs.webkit.org/show_bug.cgi?id=60658
3170
3171         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
3172         (TestWebKitAPI::TEST):
3173
3174 2011-05-11  Alice Boxhall  <aboxhall@chromium.org>
3175
3176         Reviewed by Ojan Vafai.
3177
3178         Modify jsonresults_unittest.py to use a dict format for its test data, and modify jsonresults.py to flatten hierarchical directory structures in input JSON.
3179         https://bugs.webkit.org/show_bug.cgi?id=60521
3180
3181         First steps towards making the results JSON all hierarchical.
3182
3183         * TestResultServer/model/jsonresults.py:
3184         * TestResultServer/model/jsonresults_unittest.py:
3185
3186 2011-05-11  Kevin Ollivier  <kevino@theolliviers.com>
3187
3188         [wx] Build fix, adding new LayoutTestController method stubs.
3189
3190         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3191         (LayoutTestController::localStorageDiskUsageForOrigin):
3192         (LayoutTestController::applicationCacheDiskUsageForOrigin):
3193
3194 2011-05-11  Jessie Berlin  <jberlin@apple.com>
3195
3196         Reviewed by Darin Adler.
3197
3198         [WebKit2] exceededDatabaseQuota function on WKPageUIClient needs to provide information
3199         about the usage for both the origin overall and the database in question.
3200         https://bugs.webkit.org/show_bug.cgi?id=60573
3201
3202         * WebKitTestRunner/TestController.cpp:
3203         (WTR::exceededDatabaseQuota):
3204
3205 2011-05-10  Stephen White  <senorblanco@chromium.org>
3206
3207         Reviewed by David Levin.
3208
3209         Adding myself as a reviewer.
3210         https://bugs.webkit.org/show_bug.cgi?id=60587
3211
3212         * Scripts/webkitpy/common/config/committers.py:
3213
3214 2011-05-11  Eric Seidel  <eric@webkit.org>
3215
3216         Reviewed by Csaba Osztrogonác.
3217
3218         queues.webkit.org should show 1000+ instead of 1000 when we hit the query limit
3219         https://bugs.webkit.org/show_bug.cgi?id=60614
3220
3221         AppEngine has a result limit of 1000.  We hit that when trying
3222         to find out how many patches the style-queue (and other queues)
3223         have passed in the last 30 days.  So lets display 1000+ instead
3224         of 1000 to avoid confusion. (Ossy was asking about this in #webkit tonight.)
3225
3226         I also made the status pages show "never" instead of just "ago" when we
3227         haven't seen a pass or boot message in the last 1000 messages.
3228
3229         * QueueStatusServer/handlers/queuestatus.py:
3230         * QueueStatusServer/templates/queuestatus.html:
3231
3232 2011-05-11  Adam Barth  <abarth@webkit.org>
3233
3234         Reviewed by Eric Seidel.
3235
3236         sheriffbot shouldn't spam bugs when it can't figure out who to blame
3237         https://bugs.webkit.org/show_bug.cgi?id=60613
3238
3239         This patch limits the number of bugs sheriffbot will spam to three.
3240         Ideally, we'd come up with some smarter huerstics, but hopefully this
3241         will cut down on the bugmail spam for slow bots.
3242
3243         * Scripts/webkitpy/tool/commands/sheriffbot.py:
3244
3245 2011-05-10  Eric Seidel  <eric@webkit.org>
3246
3247         Reviewed by Adam Barth.
3248
3249         EWS bots should be robust against test-webkitpy hangs
3250         https://bugs.webkit.org/show_bug.cgi?id=60579
3251
3252         Added a killAfterTimeout subroutine, which takes a child_pid
3253         and timeout, and will setup a watchdog process to kill that child
3254         after the timeout.  killAfterTimeout will waitpid on the child.
3255
3256         * EWSTools/start-queue.sh:
3257
3258 2011-05-10  MORITA Hajime  <morrita@google.com>
3259
3260         Unreviewed, moved myself to the reviewers list.
3261
3262         * Scripts/webkitpy/common/config/committers.py:
3263
3264 2011-05-10  Anton D'Auria  <adauria@apple.com>
3265
3266         Reviewed by David Levin.
3267
3268         StorageTracker should report actual local storage usage on disk
3269         https://bugs.webkit.org/show_bug.cgi?id=60558
3270
3271         * DumpRenderTree/LayoutTestController.cpp:
3272         (localStorageDiskUsageForOriginCallback):
3273         (LayoutTestController::staticFunctions):
3274         * DumpRenderTree/LayoutTestController.h:
3275         * DumpRenderTree/chromium/LayoutTestController.cpp:
3276         (LayoutTestController::LayoutTestController):
3277         (LayoutTestController::localStorageDiskUsageForOrigin):
3278         * DumpRenderTree/chromium/LayoutTestController.h:
3279         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3280         (LayoutTestController::localStorageDiskUsageForOrigin):
3281         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3282         (LayoutTestController::localStorageDiskUsageForOrigin):
3283         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3284         (LayoutTestController::localStorageDiskUsageForOrigin):
3285         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3286         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3287         (LayoutTestController::localStorageDiskUsageForOrigin):
3288
3289 2011-05-10  Anton D'Auria  <adauria@apple.com>
3290
3291         Reviewed by Alexey Proskuryakov.
3292
3293         Add ApplicationCache API to get disk usage per origin
3294         https://bugs.webkit.org/show_bug.cgi?id=57127
3295
3296         Added test that loads two frames with ~15Kb image, checks usage,
3297         deletes app cache, verifies usage is 0.
3298
3299         * DumpRenderTree/LayoutTestController.cpp:
3300         (applicationCacheDiskUsageForOriginCallback):
3301         (LayoutTestController::staticFunctions):
3302         * DumpRenderTree/LayoutTestController.h:
3303         * DumpRenderTree/chromium/LayoutTestController.cpp: Added stub.
3304         (LayoutTestController::LayoutTestController):
3305         (LayoutTestController::applicationCacheDiskUsageForOrigin):
3306         * DumpRenderTree/chromium/LayoutTestController.h:
3307         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added stub.
3308         (LayoutTestController::applicationCacheDiskUsageForOrigin):
3309         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3310         (LayoutTestController::applicationCacheDiskUsageForOrigin):
3311         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added stub.
3312         (LayoutTestController::applicationCacheDiskUsageForOrigin):
3313         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3314         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Added stub.
3315         (LayoutTestController::applicationCacheDiskUsageForOrigin):
3316
3317 2011-05-10  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
3318
3319         Unreviewed, adding Rafael Antognolli as a committer.
3320
3321         * Scripts/webkitpy/common/config/committers.py:
3322
3323 2011-05-10  Chris Evans  <cevans@chromium.org>
3324
3325         Reviewed by Adam Barth.
3326
3327         Add WebCore::Setting to block displaying and/or running insecure content on secure pages
3328         https://bugs.webkit.org/show_bug.cgi?id=58378
3329
3330         * DumpRenderTree/chromium/LayoutTestController.cpp:
3331         (LayoutTestController::LayoutTestController):
3332         (LayoutTestController::setAllowDisplayOfInsecureContent):
3333         (LayoutTestController::setAllowRunningOfInsecureContent):
3334         * DumpRenderTree/chromium/LayoutTestController.h:
3335         * DumpRenderTree/chromium/WebPreferences.cpp:
3336         (WebPreferences::reset):
3337         (WebPreferences::applyTo):
3338         * DumpRenderTree/chromium/WebPreferences.h:
3339         Add plumbing for new settings to Chromium DRT.
3340
3341 2011-05-10  Enrica Casucci  <enrica@apple.com>
3342
3343         Reviewed by Beth Dakin.
3344
3345         Added my name to the reviewers list and removed my name from
3346         to committer-only list.
3347
3348         * Scripts/webkitpy/common/config/committers.py:
3349
3350 2011-05-10  David Levin  <levin@chromium.org>
3351
3352         Reviewed by Shinichiro Hamaji.
3353
3354         check-webkit-style shouldn't filter the errors using the modified lines for the xml and test expectations checkers.
3355         https://bugs.webkit.org/show_bug.cgi?id=60466
3356
3357         * Scripts/webkitpy/style/checker.py: (unrelated) style fix.
3358         * Scripts/webkitpy/style/checker_unittest.py: Remove the file_path check since
3359           that property was removed.
3360         * Scripts/webkitpy/style/checkers/test_expectations.py: Turn off the line
3361           filtering for errors.
3362         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py: Add testing to
3363           verify that the line filtering is turned off.
3364         * Scripts/webkitpy/style/checkers/xml.py: Turn off the line filtering for errors
3365           and remove the unused file_path parameter.
3366         * Scripts/webkitpy/style/checkers/xml_unittest.py: Add testing to verify that the
3367           line filtering is turned off (and fix test_no_error).
3368         * Scripts/webkitpy/style/error_handlers.py: Added a way to turn off the filtering
3369           of errors based on the lines changed in the patch.
3370         * Scripts/webkitpy/style/error_handlers_unittest.py: Added a test for turning off
3371           the filtering.
3372
3373 2011-05-10  Adam Roben  <aroben@apple.com>
3374
3375         Update some plugin tests to work with WebKit2's asynchronous windowed plugin positioning on Windows
3376
3377         Fixes <http://webkit.org/b/60442> <rdar://problem/9403200> REGRESSION (r85795):
3378         platform/win/plugins/window-geometry-initialized-before-set-window.html and
3379         platform/win/plugins/window-region-is-set-to-clip-rect.html failing on Windows 7 Release
3380         (WebKit2 Tests)
3381
3382         Reviewed by Anders Carlsson.
3383
3384         * DumpRenderTree/TestNetscapePlugIn/Tests/win/NPNInvalidateRectInvalidatesWindow.cpp:
3385         (NPNInvalidateRectInvalidatesWindow::NPP_SetWindow): Moved some code from here to the new
3386         WindowedPluginTest::testHarnessWindow function.
3387
3388         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowGeometryInitializedBeforeSetWindow.cpp:
3389         (WindowGeometryInitializedBeforeSetWindow::NPP_SetWindow): Only check the window's size, not
3390         its position. In WebKit2, the position won't have been set yet, so we can't test it. But it
3391         turns out only the size mattered for <http://webkit.org/b/46716>, which this test was
3392         created for.
3393
3394         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowRegionIsSetToClipRect.cpp:
3395         (WindowRegionIsSetToClipRect::WindowRegionIsSetToClipRect): Converted to be a
3396         WindowedPluginTest, and initialized new members.
3397         (WindowRegionIsSetToClipRect::startTest): Make our plugin window visible, and set things up
3398         to ensure we get a WM_WINDOWPOSCHANGED message about it becoming visible.
3399         (WindowRegionIsSetToClipRect::finishTest): Check that the window region is what we expect,
3400         then clean up and tell the test harness we're done.
3401         (WindowRegionIsSetToClipRect::checkWindowRegion): Moved code to check the window region here
3402         from NPP_SetWindow. Changed to use the fancy new log() function instead of pluginLog().
3403         (WindowRegionIsSetToClipRect::showTestHarnessWindowIfNeeded): Show the test harness's window
3404         if it is hidden. This is needed to ensure we get a WM_WINDOWPOSCHANGED message when our own
3405         window becomes visible.
3406         (WindowRegionIsSetToClipRect::hideTestHarnessWindowIfNeeded): Hide the test harness's window
3407         if it was hidden at the start of the test.
3408         (WindowRegionIsSetToClipRect::wndProc): When our timer fires, tell the UI process to paint.
3409         This should cause our window to become visible and our window region to get set. When we get
3410         a WM_WINDOWPOSCHANGED message, we can finally finish the test.
3411         (WindowRegionIsSetToClipRect::NPP_GetValue): Return our script object.
3412         (WindowRegionIsSetToClipRect::ScriptObject::hasMethod): We only have one method:
3413         "startTest".
3414         (WindowRegionIsSetToClipRect::ScriptObject::invoke): Call through to the PluginTest object.
3415
3416         * DumpRenderTree/TestNetscapePlugIn/win/WindowedPluginTest.cpp:
3417         (WindowedPluginTest::testHarnessWindow):
3418         * DumpRenderTree/TestNetscapePlugIn/win/WindowedPluginTest.h:
3419         Added this helper function. Code came from NPNInvalidateRectInvalidatesWindow.
3420
3421 2011-05-10  Csaba Osztrogonác  <ossy@webkit.org>
3422
3423         Reviewed by Kenneth Rohde Christiansen.
3424
3425         [Qt] Add new qt-4.8 platform for layout testing
3426         https://bugs.webkit.org/show_bug.cgi?id=60544
3427
3428         * Scripts/old-run-webkit-tests:
3429         * Scripts/webkitdirs.pm:
3430
3431 2011-05-09  Sheriff Bot  <webkit.review.bot@gmail.com>
3432
3433         Unreviewed, rolling out r86108.
3434         http://trac.webkit.org/changeset/86108
3435         https://bugs.webkit.org/show_bug.cgi?id=60533
3436
3437         Broke makefile based builds and Cairo (Requested by weinig on
3438         #webkit).
3439
3440         * Scripts/build-api-tests:
3441         * Scripts/run-api-tests:
3442         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
3443         * TestWebKitAPI/Test.h:
3444         (TestWebKitAPI::Test::~Test):
3445         (TestWebKitAPI::Test::name):
3446         (TestWebKitAPI::Test::Register::Register):
3447         (TestWebKitAPI::Test::Register::create):
3448         (TestWebKitAPI::Test::Test):
3449         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3450         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
3451         (TestWebKitAPI::TEST):
3452         * TestWebKitAPI/TestsController.cpp:
3453         (TestWebKitAPI::TestsController::TestsController):
3454         (TestWebKitAPI::TestsController::dumpTestNames):
3455         (TestWebKitAPI::TestsController::runTestNamed):
3456         (TestWebKitAPI::TestsController::testFailed):
3457         (TestWebKitAPI::TestsController::registerCreateTestFunction):
3458         * TestWebKitAPI/TestsController.h:
3459         * TestWebKitAPI/mac/main.mm:
3460         (main):
3461
3462 2011-05-09  Hayato Ito  <hayato@chromium.org>
3463
3464         Reviewed by Ojan Vafai.
3465
3466         Skip reftests if pixel tests are disabled.
3467
3468         https://bugs.webkit.org/show_bug.cgi?id=59078
3469
3470         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
3471         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
3472         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
3473         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3474
3475 2011-05-09  Chang Shu  <cshu@webkit.org>
3476
3477         Reviewed by Kenneth Rohde Christiansen.
3478
3479         [Qt] DumpRenderTreeQt needs an implementation of unmarkText
3480         https://bugs.webkit.org/show_bug.cgi?id=60499
3481
3482         The implementation is similar to gtk.
3483
3484         * DumpRenderTree/qt/TextInputControllerQt.cpp:
3485         (TextInputController::unmarkText):
3486         * DumpRenderTree/qt/TextInputControllerQt.h:
3487
3488 2011-05-09  James Robinson  <jamesr@chromium.org>
3489
3490         Reviewed by Eric Seidel.
3491
3492         [chromium] Teach new-run-webkit-tests to follow symlinks when trying to determine the arch of DumpRenderTree on linux
3493         https://bugs.webkit.org/show_bug.cgi?id=60520
3494
3495         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3496
3497 2011-05-09  Dmitry Lomov  <dslomov@google.com>
3498
3499         Reviewed by Sam Weinig.
3500
3501         Switch TestWebKitAPI to GTest
3502         https://bugs.webkit.org/show_bug.cgi?id=59561
3503
3504         * Scripts/build-api-tests:
3505         * Scripts/run-api-tests:
3506         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
3507         * TestWebKitAPI/Test.h:
3508         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3509         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
3510         (TestWebKitAPI::TEST):
3511         * TestWebKitAPI/TestsController.cpp:
3512         (TestWebKitAPI::TestsController::TestsController):
3513         (TestWebKitAPI::TestsController::dumpTestNames):
3514         (TestWebKitAPI::TestsController::runTestNamed):
3515         (TestWebKitAPI::TestsController::runAllTests):
3516         * TestWebKitAPI/TestsController.h:
3517         * TestWebKitAPI/mac/main.mm:
3518         (main):
3519
3520 2011-05-09  Igor Oliveira  <igor.oliveira@openbossa.org>
3521
3522         Reviewed by Andreas Kling.
3523
3524         [Qt] DRT eventSender.addTouchPoint method is not setting the start position
3525         https://bugs.webkit.org/show_bug.cgi?id=60487
3526
3527         When adding a new touch point, the start position of this point needs to be set.
3528
3529         * DumpRenderTree/qt/EventSenderQt.cpp:
3530         (EventSender::addTouchPoint):
3531
3532 2011-05-09  Robert Hogan  <robert@webkit.org>
3533
3534         Reviewed by Adam Roben.
3535
3536         https://bugs.webkit.org/show_bug.cgi?id=57137
3537
3538         Unskip plugins/embed-prefers-plugins-for-images.html
3539
3540         Add image/png mime-type to test netscape plugin on Unix.
3541
3542         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
3543         (NP_GetMIMEDescription):
3544
3545 2011-05-09  Alice Boxhall  <aboxhall@chromium.org>
3546
3547         Reviewed by Ojan Vafai.
3548
3549         Pull jsonresults_unittest test cases out into separate test methods.
3550         https://bugs.webkit.org/show_bug.cgi?id=60418
3551
3552         * TestResultServer/model/jsonresults_unittest.py:
3553
3554 2011-05-09  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
3555
3556         Reviewed by Andreas Kling.
3557
3558         [Qt] fix fast/dom/Geolocation/window-close-crash.html
3559         https://bugs.webkit.org/show_bug.cgi?id=60458
3560
3561         Update all pages with Mock position/error/permission.
3562
3563         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3564         (LayoutTestController::setGeolocationPermission):
3565         (LayoutTestController::setMockGeolocationError):
3566         (LayoutTestController::setMockGeolocationPosition):
3567
3568 2011-05-09  Shishir Agrawal  <shishir@chromium.org>
3569
3570         Reviewed by Tony Gentilcore.
3571
3572         Implement Page Visibility API.
3573         https://bugs.webkit.org/show_bug.cgi?id=54181
3574
3575         * DumpRenderTree/LayoutTestController.cpp:
3576         (setPageVisibilityCallback):
3577         (resetPageVisibilityCallback):
3578         (LayoutTestController::staticFunctions):
3579         * DumpRenderTree/LayoutTestController.h:
3580         (LayoutTestController::setPageVisibility):
3581         (LayoutTestController::resetPageVisibility):
3582         * DumpRenderTree/chromium/LayoutTestController.cpp:
3583         (LayoutTestController::LayoutTestController):
3584         (LayoutTestController::resetPageVisibility):
3585         (LayoutTestController::setPageVisibility):
3586         * DumpRenderTree/chromium/LayoutTestController.h:
3587
3588 2011-05-07  Adam Barth  <abarth@webkit.org>
3589
3590         Reviewed by Eric Seidel.
3591
3592         Testing EWS spins on patches with a large number of failures
3593         https://bugs.webkit.org/show_bug.cgi?id=60441
3594
3595         In cases where the tree has a small number of persistent failures but a
3596         patch has a large number of failures, we weren't believing any results.
3597         That lead to us retrying the patch forever while we waited for
3598         trustworthy results that would never come.
3599
3600         This patch loosens the semantics of unexpected_failures to return a
3601         subset (rather than the exact set) of unexpected failures.  In the case
3602         where the tree has a bounded number of failures and the patch has an
3603         unbounded number of failures, we can accurately compute such a subset
3604         and reject the patch.
3605
3606         * Scripts/webkitpy/tool/bot/expectedfailures.py:
3607         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py:
3608         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
3609         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3610         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3611
3612 2011-05-07  Joe Mason  <jmason@rim.com>
3613
3614         Reviewed by Daniel Bates.
3615
3616         FrameLoader::isProcessingUserGesture is wrong in dispatchWillPerformClientRedirect
3617         https://bugs.webkit.org/show_bug.cgi?id=52211
3618
3619         Dump isUserProcessingGesture in willPerformClientRedirect so that the layout tests can be extended.
3620         (For the Mac and Chromium ports - other ports don't support dumping user gestures in DRT.)
3621
3622         * DumpRenderTree/chromium/WebViewHost.cpp:
3623         (WebViewHost::willPerformClientRedirect):
3624         (WebViewHost::didStartProvisionalLoad):
3625         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3626         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
3627
3628 2011-05-07  Daniel Bates  <dbates@webkit.org>
3629
3630         Attempt to fix the build; remove some more references to isTiger(), which was removed in changeset 86007
3631         <http://trac.webkit.org/changeset/86007> (bug #60438).
3632
3633         * Scripts/old-run-webkit-tests:
3634           - Removed reference to isTiger() from openDumpTool(), captureSavedCrashLog(), and
3635             file local variable. 
3636
3637 2011-05-07  Pratik Solanki  <psolanki@apple.com>
3638
3639         Reviewed by Darin Adler.
3640
3641         Remove references to Tiger in scripts
3642         https://bugs.webkit.org/show_bug.cgi?id=60438
3643
3644         Remove isTiger() and all of the code that depends on it.
3645
3646         * Scripts/build-webkit:
3647         * Scripts/ensure-valid-python:
3648         * Scripts/gdb-safari:
3649         * Scripts/webkitdirs.pm:
3650
3651 2011-05-06  David Grogan  <dgrogan@chromium.org>
3652
3653         Reviewed by Eric Seidel.
3654
3655         update link to message about mac 64bit git binaries
3656         https://bugs.webkit.org/show_bug.cgi?id=60411
3657
3658         The original message implied (correctly, at-the-time) that
3659         http://code.google.com/p/git-osx-installer/ doesn't provide 64-bit
3660         binaries. The new message notes that they do. This might prevent someone
3661         else from spending a few minutes confused.
3662
3663         * Scripts/webkitpy/common/checkout/scm/git.py:
3664
3665 2011-05-06  Dirk Pranke  <dpranke@chromium.org>
3666
3667         Reviewed by Ojan Vafai.
3668
3669         new-run-webkit-tests: crashes in race with crashing DRT
3670         https://bugs.webkit.org/show_bug.cgi?id=60238
3671
3672         This fixes a race where if we wrote the URL to DRT and
3673         DRT crashed immediately, we could get a broken pipe
3674         error back during the write() and not handle it correctly,
3675         causing NRWT to also crash.
3676
3677         * Scripts/webkitpy/layout_tests/port/server_process.py:
3678         * Scripts/webkitpy/layout_tests/port/webkit.py:
3679
3680 2011-05-06  Adam Barth  <abarth@webkit.org>
3681
3682         Reviewed by Eric Seidel.
3683
3684         Add a --skip-integrationtests mode to test-webkitpy
3685         https://bugs.webkit.org/show_bug.cgi?id=60354
3686
3687         These two test suites account for 2/3 of test-webkitpy's running time
3688         because they're not actually unit tests.  They're integration tests.
3689         This patch adds the ability to skip integration tests by passing a
3690         command line argument to test-webkitpy.  The buildbots will continue to
3691         run these integration tests to make sure they don't regress.  This
3692         option is for use by developers when working on parts of the code that
3693         are well-covered by unit tests.
3694
3695         * Scripts/webkitpy/common/system/file_lock_integrationtest.py: Copied from Tools/Scripts/webkitpy/common/system/file_lock_unittest.py.
3696         * Scripts/webkitpy/common/system/file_lock_unittest.py: Removed.
3697         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Copied from Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py.
3698         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: Removed.
3699         * Scripts/webkitpy/test/main.py:
3700
3701 2011-05-06  Adam Barth  <abarth@webkit.org>
3702
3703         Reviewed by Eric Seidel.
3704
3705         The results.zip generated by the Chromium EWS are too big
3706         https://bugs.webkit.org/show_bug.cgi?id=60352
3707
3708         Currently results.zip created by the Chromium EWS bot contain roughly
3709         1000 tests that we expect to fail.  These test results are not helpful
3710         to contributors.
3711
3712         There are several approaches to solving this problem:
3713
3714         1) We could be more selective about which files to include in the zip.
3715         2) We could ask new-run-webkit-tests not to generate results for
3716            expected failures.
3717         3) We could ask new-run-webkit-tests not to run tests that we expect to
3718            fail.
3719
3720         This patch takes approach (3).  Currently, we're ignoring the outcome
3721         of failing tests anyway, so there's not much point in actually running
3722         them.  As a side benefit, this will speed up the test run by about 6%.
3723         In the future, we might revisit this decision and choose another
3724         approach.
3725
3726         * Scripts/webkitpy/common/config/ports.py:
3727         * Scripts/webkitpy/common/config/ports_unittest.py:
3728
3729 2011-05-06  Gabor Rapcsanyi  <rgabor@webkit.org>
3730
3731         Reviewed by Csaba Osztrogonác.
3732
3733         [Qt] Use qt-arm platform instead of qt-linux on ARM platform.
3734
3735         * Scripts/old-run-webkit-tests:
3736
3737 2011-05-06  Adam Barth  <abarth@webkit.org>
3738
3739         Reviewed by Ojan Vafai.
3740
3741         Add an option to NRWT to skip failing tests
3742         https://bugs.webkit.org/show_bug.cgi?id=60295
3743
3744         This option is similar to the way old-run-webkit-tests works.  We're
3745         planning to use this option on the testing EWS bots because they don't
3746         use information from failing tests yet.
3747
3748         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
3749         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3750         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3751
3752 2011-05-04  Philippe Normand  <pnormand@igalia.com>
3753
3754         Reviewed by Dimitri Glazkov.
3755
3756         Implement LayoutTestController::pseudoShadowId()
3757         https://bugs.webkit.org/show_bug.cgi?id=60034
3758
3759         shadowPseudoId support in the various LayoutTestController
3760         implementations.
3761
3762         * DumpRenderTree/LayoutTestController.cpp:
3763         (shadowPseudoIdCallback):
3764         (LayoutTestController::staticFunctions):
3765         * DumpRenderTree/LayoutTestController.h:
3766         * DumpRenderTree/chromium/LayoutTestController.cpp:
3767         (LayoutTestController::LayoutTestController):
3768         (LayoutTestController::shadowPseudoId):
3769         * DumpRenderTree/chromium/LayoutTestController.h:
3770         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3771         (LayoutTestController::shadowPseudoId):
3772         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3773         (LayoutTestController::shadowPseudoId):
3774         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3775         (LayoutTestController::shadowPseudoId):
3776         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3777         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3778         (LayoutTestController::shadowPseudoId):
3779         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3780         (LayoutTestController::shadowPseudoId):
3781         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3782         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3783         (WTR::LayoutTestController::shadowPseudoId):
3784         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3785
3786 2011-05-06  Adam Barth  <abarth@webkit.org>
3787
3788         EWS can't reject patches
3789         https://bugs.webkit.org/show_bug.cgi?id=60345
3790
3791         We're supposed to use patch.id() for the attachment ID, silly.
3792
3793         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3794         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3795
3796 2011-05-05  Steve Lacey  <sjl@chromium.org>
3797
3798         Reviewed by Ojan Vafai.
3799
3800         Fix generation of results html file by passing relative path to scm
3801         methods.
3802         Generate diff images for results html file.
3803
3804         https://bugs.webkit.org/show_bug.cgi?id=60086
3805
3806         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3807         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
3808
3809 2011-05-05  Andy Estes  <aestes@apple.com>
3810
3811         Reviewed by Daniel Bates.
3812
3813         update-webkit should handle Internal using a different VCS than OpenSource.
3814         https://bugs.webkit.org/show_bug.cgi?id=60310
3815
3816         isGit() and isSVN() cache their results, so Internal will always be
3817         updated using the VCS commands used for OpenSource. If Internal uses a
3818         different VCS, this will fail. Fix this by calling isGitDirectory() and
3819         isSVNDirectory() instead, which do not cache their results.
3820
3821         * Scripts/update-webkit:
3822
3823 2011-05-05  Dirk Pranke  <dpranke@chromium.org>
3824
3825         Reviewed by Ojan Vafai.
3826
3827         nrwt: revamp integration tests incl. tests for servers
3828         https://bugs.webkit.org/show_bug.cgi?id=59985
3829
3830         This change adds the ability to run "integration tests" that
3831         depend on (and affect) the local environment on your machine.
3832         These tests can be run manually by invoking python on the
3833         test file in question and passing the '-i' flag, but are
3834         not run automatically as part of test-webkitpy.
3835
3836         Integration tests are identified by being methods named as
3837         "integration_test_*" instead of "test_*", and we use a
3838         custom TestLoader instead of the default one provided by
3839         unittest.
3840
3841         This change also adds a protected "_default_to_apache" method
3842         to the port object so we can do the right thing when starting
3843         and stopping web servers with less mechanism.
3844
3845         * Scripts/webkitpy/layout_tests/port/base.py:
3846         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
3847         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
3848         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
3849         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3850         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3851
3852 2011-05-05  Adam Roben  <aroben@apple.com>
3853
3854         Robustify DRT's pixel-dumping code against semi-random alpha channel values on Windows
3855
3856         DRT generates a pixel dump on Windows using the WM_PRINT message. This message (just like
3857         most of GDI) doesn't write anything meaningful into the alpha channel. In some cases, the
3858         alpha channel will even get filled with zeros (like when ::GradientFill is used). To
3859         safeguard against this, we fill the alpha channel with constant full opacity after the
3860         WM_PRINT message is handled to ensure we end up with an opaque image. (Note that we can't
3861         just ignore the alpha channel when creating the PNG; Mac's pixel results have an alpha
3862         channel, and we want to be able to compare Mac and Windows pixel results, so Windows pixel
3863         results need an alpha channel, too.)
3864
3865         Fixes <http://webkit.org/b/60300> draws-gradient.html's pixel results can't be correctly
3866         generated due to alpha channel weirdness
3867
3868         Reviewed by Sam Weinig.
3869
3870         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
3871         (makeAlphaChannelOpaque): Added this helper function to fill a bitmap's alpha channel with
3872         constant full opacity.
3873         (createBitmapContextFromWebView): Make the bitmap's alpha channel opaque before wrapping it
3874         in a CGContext or cairo_surface.
3875
3876 2011-05-05  Adam Roben  <aroben@apple.com>
3877
3878         Add support for layoutTestController.dumpAsText(true) to WebKitTestRunner
3879
3880         Passing true tells the test harness to dump pixels even though we're not dumping a render
3881         tree.
3882
3883         Fixes <http://webkit.org/b/60298> Calling layoutTestController.dumpAsText(true) in
3884         WebKitTestRunner doesn't result in pixel results being generated
3885
3886         Reviewed by Sam Weinig.
3887
3888         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added dumpPixels
3889         argument to dumpAsText.
3890
3891         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3892         (WTR::InjectedBundlePage::dump): Updated for dumpAsText change.
3893
3894         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3895         (WTR::LayoutTestController::dumpAsText): Store the dumpPixels argument.
3896
3897         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Updated for IDL change.
3898
3899         * WebKitTestRunner/win/InjectedBundle.vcproj: Added .idl files as a convenience for Windows
3900         developers.
3901
3902 2011-05-05  Dirk Pranke  <dpranke@chromium.org>
3903
3904         Reviewed by Ojan Vafai.
3905
3906         new-run-webkit-tests: merge os, version fields in test config
3907         https://bugs.webkit.org/show_bug.cgi?id=60004
3908
3909         This change removes the 'o/s' field from the TestConfiguration
3910         object, and changes the 'MAC', 'WIN', and 'LINUX' modifiers in
3911         the expectations file to macros that expand to the version names
3912         for each platform.
3913
3914         This means that you can once again put any subset of the
3915         operating system versions on a single line, e.g.:
3916           BUGX LEOPARD XP LINUX : fast/html/foo.html = FAIL
3917
3918         This change will break any existing test_expectations.txt
3919         file that uses the "OS-VERSION" macros, which are no longer
3920         needed. It turns out they were never needed, as just VERSION
3921         by itself was sufficient. The test_expectations.txt file should
3922         be updated accordingly prior to landing this change.
3923
3924         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
3925         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
3926         * Scripts/webkitpy/layout_tests/port/base.py:
3927
3928 2011-05-05  Tony Chang  <tony@chromium.org>
3929
3930         Reviewed by Adam Barth.
3931
3932         [chromium] switch from Lucida to free fonts for Hindi and Thai
3933         https://bugs.webkit.org/show_bug.cgi?id=60287
3934
3935         The fonts are provided by the ttf-thai-tlwg and ttf-indic-fonts
3936         packages on Lucid. There are actually multiple Thai fonts in the
3937         package, so I just picked one.
3938
3939         * DumpRenderTree/chromium/TestShellGtk.cpp:
3940         (setupFontconfig):
3941
3942 2011-05-05  Tony Chang  <tony@chromium.org>
3943
3944         Reviewed by Ojan Vafai.
3945
3946         [chromium] google-chrome-64 builds should now fallback to chromium-linux-x86_64 results
3947         https://bugs.webkit.org/show_bug.cgi?id=60290
3948
3949         It used to be that google-chrome-32 was hardy32, google-chrome-64 was
3950         hardy64, chromium-linux was hardy32 and chromium-linux-x86_64 was
3951         lucid64.  Because of that, google-chrome-64 used to skip the
3952         chromium-linux-x86_64 results since they were more incorrect.
3953
3954         Now that we're switching to lucid for google-chrome, we want
3955         google-chrome-64 to fall back to chromium-linux-x86_64.
3956
3957         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
3958
3959 2011-05-05  Dirk Pranke  <dpranke@chromium.org>
3960
3961         Reviewed by Ojan Vafai.
3962
3963         new-run-webkit-tests: merge TestExpectations, TestExpectationsFile classes
3964         https://bugs.webkit.org/show_bug.cgi?id=60002
3965
3966         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
3967         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
3968         * Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
3969         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
3970         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
3971         * Scripts/webkitpy/style/checkers/test_expectations.py:
3972
3973 2011-05-05  Eric Seidel  <eric@webkit.org>
3974
3975         Reviewed by Adam Barth.
3976
3977         commit-queue should reject patches which fail ewses
3978         https://bugs.webkit.org/show_bug.cgi?id=47534
3979
3980         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3981         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3982         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3983
3984 2011-05-05  Chang Shu  <cshu@webkit.org>
3985
3986         Reviewed by Andreas Kling.
3987
3988         [Qt][WK2] Support PageGroup in QGraphicsWKView/QWKPage constructors
3989         https://bugs.webkit.org/show_bug.cgi?id=59638
3990
3991         1. Call QGraphicsWKView constructor with pageGroupRef.
3992         2. Disable setFontFamily calls as it breaks Qt test fonts.
3993
3994         * WebKitTestRunner/TestController.cpp:
3995         (WTR::TestController::resetStateToConsistentValues):
3996         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3997         (WTR::WebView::WebView):
3998         (WTR::PlatformWebView::PlatformWebView):
3999
4000 2011-05-05  Joseph Pecoraro  <joepeck@webkit.org>
4001
4002         Reviewed by David Kilzer.
4003
4004         Add --only-webkit option to build-webkit
4005         https://bugs.webkit.org/show_bug.cgi?id=60245
4006
4007         * Scripts/build-webkit: If --only-webkit was specified
4008         just build the WebKit project, and not its dependencies.
4009
4010 2011-05-05  Jeff Miller  <jeffm@apple.com>
4011
4012         Reviewed by Darin Adler.
4013
4014         Add didNotHandleWheelEvent callback to WKPageUIClient
4015         https://bugs.webkit.org/show_bug.cgi?id=60203
4016
4017         * MiniBrowser/gtk/BrowserWindow.c:
4018         (browserWindowUIClientInit): Stub out didNotHandleWheelEvent callback.
4019         * MiniBrowser/mac/BrowserWindowController.m:
4020         (-[BrowserWindowController awakeFromNib]): Stub out didNotHandleWheelEvent callback.
4021         * MiniBrowser/win/BrowserView.cpp:
4022         (BrowserView::create): Stub out didNotHandleWheelEvent callback.
4023         * WebKitTestRunner/TestController.cpp:
4024         (WTR::TestController::createOtherPage): Stub out didNotHandleWheelEvent callback.
4025         (WTR::TestController::initialize): Stub out didNotHandleWheelEvent callback.
4026
4027 2011-05-04  Eric Seidel  <eric@webkit.org>
4028
4029         Reviewed by Adam Barth.
4030
4031         Add more missing imports from scm refactor
4032         https://bugs.webkit.org/show_bug.cgi?id=60239
4033
4034         * Scripts/webkitpy/common/checkout/scm/git.py:
4035         * Scripts/webkitpy/common/checkout/scm/svn.py:
4036
4037 2011-05-04  Eric Seidel  <eric@webkit.org>
4038
4039         Reviewed by Adam Barth.
4040
4041         sheriff-bot is having more exception trouble
4042         https://bugs.webkit.org/show_bug.cgi?id=60233
4043
4044         A webpage-forced build was causing SB to throw an exception.
4045         We've long had this bug, but we just didn't notice it until now.
4046
4047         In debugging this I found we fetch an absurd amount of data now
4048         that we use buildbot's json (instead of xmlrpc), so I added
4049         the filter=1 parameter to reduce it a little.  That required
4050         me to handle the case where filter=1 would strip
4051         result=0 in some cases (it's unclear why it does that).
4052
4053         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
4054         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
4055
4056 2011-05-04  Cris Neckar  <cdn@chromium.org>
4057
4058         Unreviewed, Adding Cris Neckar as a committer
4059
4060         * Scripts/webkitpy/common/config/committers.py:
4061
4062 2011-05-04  Siddharth Mathur  <siddharth.mathur@nokia.com>
4063
4064         Reviewed by Laszlo Gombos.
4065
4066         [Qt][Wk2][Symbian] Capabilities for Qt MiniBrowser and QtWebProcess on Symbian
4067         https://bugs.webkit.org/show_bug.cgi?id=59462
4068
4069         * MiniBrowser/qt/MiniBrowser.pro: Add Symbian OS capabilities to executable. Also enable data paging. 
4070
4071 2011-05-04  Eric Seidel  <eric@webkit.org>
4072
4073         Reviewed by Adam Barth.
4074
4075         The testing EWS bots should upload layout-test-results.zip to bugs after failures
4076         https://bugs.webkit.org/show_bug.cgi?id=60223
4077
4078         This required sharing a bit of code between the commit-queue
4079         (which already knew how to do this) and the new EWS testing bots.
4080
4081         In the process I also cleaned up EWS testing a little and
4082         removed some dead code from the commit-queue.
4083
4084         * Scripts/webkitpy/common/config/committervalidator.py:
4085         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
4086         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
4087         * Scripts/webkitpy/tool/commands/queues.py:
4088         * Scripts/webkitpy/tool/commands/queues_unittest.py:
4089
4090 2011-05-04  James Kozianski  <koz@chromium.org>
4091
4092         Reviewed by Eric Seidel.
4093
4094         Add method to make a Port able to retrieve TestOutputSets from its builders.
4095         https://bugs.webkit.org/show_bug.cgi?id=58211
4096
4097         This will be used in the new rebaseline script - TestOutputs are
4098         potential new baselines.
4099
4100         * Scripts/webkitpy/common/config/urls.py:
4101         * Scripts/webkitpy/layout_tests/port/base.py:
4102         * Scripts/webkitpy/layout_tests/port/chromium.py:
4103         * Scripts/webkitpy/layout_tests/port/factory.py:
4104         * Scripts/webkitpy/layout_tests/port/webkit.py:
4105
4106 2011-05-04  Eric Seidel  <eric@webkit.org>
4107
4108         Reviewed by Ojan Vafai.
4109
4110         sheriff-bot can't parse results.html
4111         https://bugs.webkit.org/show_bug.cgi?id=60196
4112
4113         The problem was that the NRWT bots are currently core
4114         and so sheriff-bot was trying to diagnose failures on
4115         them.  It was trying to parse their results.html file
4116         and BeautifulSoup was throwing an exception.
4117
4118         It seems our version of BeautifulSoup was quite old
4119         and unable to handle <script> tags correctly.
4120         This moves us to 3.2 which doesn't seem to have this bug.
4121
4122         * Scripts/webkitpy/thirdparty/BeautifulSoup.py:
4123
4124 2011-05-04  Adam Barth  <abarth@webkit.org>
4125
4126         Reviewed by Eric Seidel.
4127
4128         Make the EWS test logging less verbose
4129         https://bugs.webkit.org/show_bug.cgi?id=60201
4130
4131         This should help us generate less than a hundred MB of logs per hour.
4132
4133         * Scripts/webkitpy/common/config/ports.py:
4134         * Scripts/webkitpy/common/config/ports_unittest.py:
4135
4136 2011-05-04  Tao Bai  <michaelbai@chromium.org>
4137
4138         Reviewed by David Kilzer.
4139
4140         Populate touch-icon url to FrameLoaderClient
4141         https://bugs.webkit.org/show_bug.cgi?id=59143
4142
4143         Disable touch icon by default. 
4144
4145         * Scripts/build-webkit:
4146
4147 2011-05-04  Justin Novosad  <junov@chromium.org>
4148
4149         Reviewed by Kenneth Russell.
4150
4151         [Chromium] Add gpu acceleration flags to DumpRenderTree
4152         https://bugs.webkit.org/show_bug.cgi?id=60168
4153         Adding support for command line flags 
4154         enable-accelerated-2d-canvas an
4155         enable-accelerated-drawing in DumpRenderTree.
4156
4157         * DumpRenderTree/chromium/DumpRenderTree.cpp:
4158         (main):
4159         * DumpRenderTree/chromium/TestShell.cpp:
4160         (TestShell::TestShell):
4161         (TestShell::resetWebSettings):
4162         * DumpRenderTree/chromium/TestShell.h:
4163         (TestShell::setLegacyAccelerated2dCanvasEnabled):
4164         (TestShell::setAcceleratedDrawingEnabled):
4165         * DumpRenderTree/chromium/WebPreferences.cpp:
4166         (WebPreferences::reset):
4167         (WebPreferences::applyTo):
4168         * DumpRenderTree/chromium/WebPreferences.h:
4169
4170 2011-05-04  Ademar de Souza Reis Jr.  <ademar.reis@openbossa.org>
4171
4172         Reviewed by Csaba Osztrogonác.
4173
4174         [Qt] run-qtwebkit-tests misses exec bit
4175         https://bugs.webkit.org/show_bug.cgi?id=60188
4176
4177         Also removing an unecessary import (mostly to let this bugfix goes
4178         through the system, as this is just a chmod).
4179
4180         * Scripts/run-qtwebkit-tests:
4181
4182 2011-05-04  Adam Barth  <abarth@webkit.org>
4183
4184         Fix import of ircproxy module to actually import the module.  I don't
4185         really understand how this code could have worked before.
4186
4187         * Scripts/webkitpy/common/host.py:
4188
4189 2011-05-04  Siddharth Mathur  <siddharth.mathur@nokia.com>
4190
4191         Reviewed by Andreas Kling.
4192
4193         [Qt][Wk2][Symbian] Minor UI facelift for MiniBrowser
4194         https://bugs.webkit.org/show_bug.cgi?id=60172
4195
4196         * MiniBrowser/qt/BrowserWindow.cpp: Bring in UI layout changes from QtTestBrowser
4197         (BrowserWindow::BrowserWindow):
4198
4199 2011-05-04  Mihai Parparita  <mihaip@chromium.org>
4200
4201         Reviewed by Ojan Vafai.
4202
4203         [NRWT] --new-baseline should put baselines in the directory specified by --additional-platform-directory
4204         https://bugs.webkit.org/show_bug.cgi?id=60088
4205         
4206         Makes --new-baseline put new baselines into the first entry in the
4207         baseline search path, including any additional directories passed in via
4208         --additional-platform-directory.
4209         
4210         Simplifies baseline_path() by making it return the first entry in the
4211         baseline search path instead of requiring each port to have an
4212         implementation (should not result in any behavior change).
4213
4214         * Scripts/webkitpy/layout_tests/port/base.py:
4215         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
4216         * Scripts/webkitpy/layout_tests/port/chromium.py:
4217         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
4218         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
4219         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
4220         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
4221         * Scripts/webkitpy/layout_tests/port/mac.py:
4222         * Scripts/webkitpy/layout_tests/port/test.py:
4223         * Scripts/webkitpy/layout_tests/port/webkit.py:
4224
4225 2011-05-04  Adam Barth  <abarth@webkit.org>
4226
4227         Reviewed by Eric Seidel.
4228
4229         Fix circular dependency in webkitpy
4230         https://bugs.webkit.org/show_bug.cgi?id=60075
4231
4232         These functions don't belong in bugzilla.py.  They only exist there
4233         because they are old.  Really, these functions shouldn't be free
4234         functions at all, but that's a patch for another day.
4235
4236         * Scripts/webkitpy/common/checkout/changelog.py:
4237         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
4238         * Scripts/webkitpy/common/checkout/checkout.py:
4239         * Scripts/webkitpy/common/config/urls.py:
4240         * Scripts/webkitpy/common/net/bugzilla/__init__.py:
4241         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
4242         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
4243         * Scripts/webkitpy/style/checkers/changelog.py:
4244         * Scripts/webkitpy/tool/bot/irc_command.py:
4245         * Scripts/webkitpy/tool/bot/sheriff.py:
4246         * Scripts/webkitpy/tool/commands/upload.py:
4247
4248 2011-05-03  Pratik Solanki  <psolanki@apple.com>
4249
4250         Reviewed by Dan Bernstein.
4251
4252         https://bugs.webkit.org/show_bug.cgi?id=60141
4253         Remove reference to libWebKitSystemInterfaceTiger.a from build-webkit
4254
4255         * Scripts/build-webkit:
4256
4257 2011-05-03  Mihai Parparita  <mihaip@chromium.org>
4258
4259         Reviewed by Ojan Vafai.
4260
4261         Update rebaseline queue server to handle hierarchical test results
4262         https://bugs.webkit.org/show_bug.cgi?id=60063
4263         
4264         Update test result parsing done by the rebaseline queue server to handle
4265         the hierarchical test result output that is generated as of r85254.
4266
4267         * RebaselineQueueServer/templates/builder-queue-edit.html:
4268
4269 2011-05-03  Eric Seidel  <eric@webkit.org>
4270
4271         Reviewed by Adam Roben.
4272
4273         webkit-patch post-commits HEAD^.. throws an exception
4274         https://bugs.webkit.org/show_bug.cgi?id=60027
4275
4276         * Scripts/webkitpy/common/checkout/scm/git.py:
4277
4278 2011-05-03  Luiz Agostini  <luiz.agostini@openbossa.org>
4279
4280         Reviewed by Kenneth Rohde Christiansen.
4281
4282         [Qt] Layout tests may timeout if loadFinished receives false
4283         https://bugs.webkit.org/show_bug.cgi?id=60064
4284
4285         When using layoutTestController.queueLoad(), if QWebPage::loadFinished(bool) receives false
4286         then the layout test may timout. It happens that QWebPage::loadFinished() receives false when
4287         a response is ignored, like it should be for 204 responses. It is a problem for creating
4288         tests for 204 responses for example.
4289
4290         This change has been tested and it causes no regressions in layout tests.
4291
4292         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
4293         (LayoutTestController::maybeDump):
4294
4295 2011-05-03  Dirk Pranke  <dpranke@chromium.org>
4296
4297         Unreviewed, rolling out r85659.
4298         http://trac.webkit.org/changeset/85659
4299         https://bugs.webkit.org/show_bug.cgi?id=59977
4300
4301         restarting isn't working correctly
4302
4303         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
4304         * Scripts/webkitpy/layout_tests/port/http_server.py:
4305         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
4306         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
4307
4308 2011-05-03  Dirk Pranke  <dpranke@chromium.org>
4309
4310         Reviewed by Ojan Vafai.
4311
4312         new-run-webkit-tests: fix http server startup/shutdown
4313
4314         Previous versions of the code had three problems that made startup
4315         and shutdown flaky. The first is that it would throw exceptions
4316         if it couldn't delete stale log files, which was overly
4317         paranoid. The second is that some of the exceptions weren't
4318         defined properly. The third, and most important, is that it was
4319         using urllib to check if ports were available, which was leaving
4320         sockets in a half-closed state, and keeping ports from being
4321         reused. By switching to raw sockets, we are able to now reliably
4322         restart.
4323
4324         This change also switches the code to using Executives to stop
4325         processes, which will let us delete a bunch of code in the
4326         port/* implementations and fix a weird layering problem in a
4327         subsequent patch.
4328
4329         https://bugs.webkit.org/show_bug.cgi?id=59977
4330
4331         * Scripts/webkitp