Remove default copy of wpt testharness.js when launching wpt server
[WebKit-https.git] / Tools / ChangeLog
1 2015-12-16  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2
3         Remove default copy of wpt testharness.js when launching wpt server
4         https://bugs.webkit.org/show_bug.cgi?id=152298
5
6         Reviewed by Darin Adler.
7
8         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
9         (WebPlatformTestServer._copy_webkit_test_files): Deleted default copy of WebKit testharness.js to WPT.
10
11 2015-12-15  David Kilzer  <ddkilzer@apple.com>
12
13         REGRESSION (r192375): DumpRenderTree.app exits immediately with no error
14         <http://webkit.org/b/152314>
15
16         Reviewed by Daniel Bates.
17
18         The change to DumpRenderTreeMain.mm in r192375 caused the iOS
19         code path to exit immediately when calling main().
20         Unfortunately, DumpRenderTreeMain.mm was used for both
21         DumpRenderTree command-line binary and DumpRenderTree.app, which
22         meant that the app would exit immediately with no error code
23         when run!
24
25         The workaround is to introduce a separate source file called
26         DumpRenderTreeAppMain.mm, similar to what WebKitTestRunner
27         already does.
28
29         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Add
30         DumpRenderTreeAppMain.mm to the project.  Make it the only
31         compiled source for the DumpRenderTree.app target.
32         * DumpRenderTree/ios/DumpRenderTreeAppMain.mm: Copied from Tools/DumpRenderTree/mac/DumpRenderTreeMain.mm.
33         (main): Call DumpRenderTreeMain() on iOS.  Assert on OS X in
34         case someone tries mistakenly to use the app.
35         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
36         Link to JavaScriptCore.framework on iOS for the assert.
37         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
38         Link to JavaScriptCore.framework on OS X for the assert.  Remove
39         unneeded EXCLUDED_SOURCE_FILE_NAMES setting.
40         * DumpRenderTree/mac/DumpRenderTreeMain.mm:
41         (main): Add assert for iOS so that a crash occurs if someone
42         tries to run the wrong command.
43
44 2015-12-14  Tim Horton  <timothy_horton@apple.com>
45
46         Frequent crash under -[WKPDFView web_setMinimumSize:]_block_invoke
47         https://bugs.webkit.org/show_bug.cgi?id=152266
48         <rdar://problem/22092676>
49
50         Reviewed by Simon Fraser.
51
52         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
53         * TestWebKitAPI/Tests/WebKit2Cocoa/WKPDFViewResizeCrash.mm: Added.
54         Add a test that crashed before this change, and doesn't crash after.
55
56 2015-12-14  Chris Fleizach  <cfleizach@apple.com>
57
58         AX: iOS: Text field variations do not have the correct traits
59         https://bugs.webkit.org/show_bug.cgi?id=152237
60
61         Reviewed by Mario Sanchez Prada.
62
63         Add iOS calls for determing if an object is a search field or a text area.
64
65         * DumpRenderTree/AccessibilityUIElement.cpp:
66         (getIsSearchFieldCallback):
67         (getIsTextAreaCallback):
68         (stringForSelectionCallback):
69         (AccessibilityUIElement::getJSClass):
70         * DumpRenderTree/AccessibilityUIElement.h:
71         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
72         (AccessibilityUIElement::identifier):
73         (AccessibilityUIElement::isTextArea):
74         (AccessibilityUIElement::isSearchField):
75         (AccessibilityUIElement::traits):
76         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
77         (WTR::AccessibilityUIElement::scrollPageRight):
78         (WTR::AccessibilityUIElement::hasContainedByFieldsetTrait):
79         (WTR::AccessibilityUIElement::fieldsetAncestorElement):
80         (WTR::AccessibilityUIElement::isSearchField):
81         (WTR::AccessibilityUIElement::isTextArea):
82         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
83         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
84         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
85         (WTR::AccessibilityUIElement::fieldsetAncestorElement):
86         (WTR::AccessibilityUIElement::isTextArea):
87         (WTR::AccessibilityUIElement::isSearchField):
88         (WTR::AccessibilityUIElement::rowCount):
89
90 2015-12-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
91
92         [GTK] [JHBuild] package libtool-bin is now required on Debian systems.
93         https://bugs.webkit.org/show_bug.cgi?id=152252
94
95         Reviewed by Sergio Villar Senin.
96
97         * gtk/install-dependencies: Add libtool-bin to the list of packages required
98         for building the JHBuild on Debian systems.
99
100 2015-12-11  Joseph Pecoraro  <pecoraro@apple.com>
101
102         check-for-inappropriate-objc-class-names should check all class names, not just externally visible ones
103         https://bugs.webkit.org/show_bug.cgi?id=152156
104
105         Reviewed by Dan Bernstein.
106
107         Our frameworks should appropriately prefix all ObjC classes,
108         not just external symbols.
109
110         * Scripts/check-for-inappropriate-objc-class-names:
111         Remove the -g switch to check all ObjC class names.
112
113 2015-12-10  Eric Carlson  <eric.carlson@apple.com>
114
115         [MediaStream] Expose media capture devices persistent permissions to WebCore
116         https://bugs.webkit.org/show_bug.cgi?id=152087
117
118         Add support for the new user media permission checker page UI client method.
119
120         Reviewed by Chris Dumez.
121
122         * WebKitTestRunner/TestController.cpp:
123         (WTR::decidePolicyForUserMediaPermissionRequest):
124         (WTR::checkUserMediaPermissionForOrigin):
125         (WTR::TestController::createOtherPage): Add checkUserMediaPermissionForOrigin.
126         (WTR::TestController::createWebViewWithOptions): Ditto.
127         (WTR::TestController::resetStateToConsistentValues): Clear m_userMediaOriginPermissions.
128         (WTR::originUserVisibleName): New, create a string for the origin.
129         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin): Set the WKUserMediaPermissionCheckRef
130           according to the state of the origin permission map.
131         (WTR::TestController::handleUserMediaPermissionRequest): Remember both the origin and the
132           request so we can update the origin permission map in decidePolicyForUserMediaPermissionRequestIfPossible.
133         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Update the
134           origin permission map.
135         * WebKitTestRunner/TestController.h:
136
137 2015-12-10  Alex Christensen  <achristensen@webkit.org>
138
139         REGRESSION (r192796) WKBundlePageResourceLoadClient should be able to setHTTPBody in willSendRequestForFrame
140         https://bugs.webkit.org/show_bug.cgi?id=152022
141         rdar://problem/23763584
142
143         Reviewed by Darin Adler.
144
145         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
146         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
147         (WTR::InjectedBundlePage::willSendRequestForFrame):
148         * WebKitTestRunner/InjectedBundle/TestRunner.h:
149         (WTR::TestRunner::setWillSendRequestReturnsNull):
150         (WTR::TestRunner::willSendRequestReturnsNullOnRedirect):
151         (WTR::TestRunner::setWillSendRequestReturnsNullOnRedirect):
152         (WTR::TestRunner::setWillSendRequestAddsHTTPBody):
153         (WTR::TestRunner::willSendRequestHTTPBody):
154         Added setWillSendRequestAddsHTTPBody that uses new SPI for testing.
155
156 2015-12-10  Aakash Jain  <aakash_jain@apple.com>
157
158         Remove additional simulator checks before running layout-tests
159         https://bugs.webkit.org/show_bug.cgi?id=152146
160
161         Reviewed by Darin Adler.
162
163         * Scripts/webkitpy/port/ios.py:
164         (IOSSimulatorPort.check_sys_deps): Removed additional simulators verifications.
165         * Scripts/webkitpy/xcode/simulator.py:
166         (Simulator._boot_and_shutdown_simulator_device): Deleted.
167         (Simulator.check_simulator_device_and_erase_if_needed): Deleted.
168
169 2015-12-09  Aakash Jain  <aakash_jain@apple.com>
170
171         Run atleast one simulator even if max process limit is low
172         https://bugs.webkit.org/show_bug.cgi?id=152081
173         <rdar://problem/23819694>
174
175         Reviewed by Alexey Proskuryakov.
176
177 2015-12-09  Mario Sanchez Prada  <mario@endlessm.com>
178
179         [GTK] Crash in WebProcess when loading large content with custom URI schemes
180         https://bugs.webkit.org/show_bug.cgi?id=144262
181
182         Reviewed by Carlos Garcia Campos.
183
184         Added new unit test to check the additional scenarios we now
185         handle for custom URI schemes.
186
187         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
188         (generateHTMLContent): New helper function to generate big enough content.
189         (testWebContextURIScheme): New unit test.
190
191 2015-12-09  Ryuan Choi  <ryuan.choi@navercorp.com>
192
193         [EFL] Fix unhandled web process message when launching MiniBrowser
194         https://bugs.webkit.org/show_bug.cgi?id=152048
195
196         Reviewed by Gyuyoung Kim.
197
198         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp:
199         (TestWebKitAPI::TEST):
200
201 2015-12-09  Carlos Garcia Campos  <cgarcia@igalia.com>
202
203         [GTK] Add API to handle beforeunload events
204         https://bugs.webkit.org/show_bug.cgi?id=139090
205
206         Reviewed by Gustavo Noronha Silva.
207
208         * MiniBrowser/gtk/BrowserWindow.c:
209         (browserWindowConstructed):
210         (browserWindowDeleteEvent):
211         (browser_window_class_init):
212         Handle delete-event to prevent the window from being closed when
213         the page has beforeunload handlers. Use
214         webkit_web_view_try_close() when the window is requested to be
215         closed.
216         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
217         (testWebViewJavaScriptDialogs):
218         Add a test case for the WEBKIT_SCRIPT_DIALOG_BEFORE_UNLOAD_CONFIRM
219         script dialog type.
220
221 2015-12-09  Mario Sanchez Prada  <mario@endlessm.com>
222
223         Refactored initialization code in LoadTrackingTest.
224
225         Rubber-stamped by Carlos Garcia Campos.
226
227         Small refactoring to make sure that the state of a LoadTrackingTest
228         gets properly reset before loading new web content.
229
230         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h:
231         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
232         (LoadTrackingTest::reset): New, refactored code from *load*() and go*()
233         functions and reset the remaining local variables.
234         (LoadTrackingTest::loadURI): Call reset();
235         (LoadTrackingTest::loadHtml): Ditto.
236         (LoadTrackingTest::loadPlainText): Ditto.
237         (LoadTrackingTest::loadBytes): Ditto.
238         (LoadTrackingTest::loadRequest): Ditto.
239         (LoadTrackingTest::reload): Ditto.
240         (LoadTrackingTest::goBack): Ditto.
241         (LoadTrackingTest::goForward): Ditto.
242
243 2015-12-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
244
245         [EFL] REGRESSION(r193616): WKPreferences test has been failed since r193616
246         https://bugs.webkit.org/show_bug.cgi?id=151942
247
248         Reviewed by Darin Adler.
249
250         * MiniBrowser/efl/main.c:
251         (window_create): Enable offline web application cache feature on MiniBrowser.
252         (elm_main):
253
254 2015-12-08  Aakash Jain  <aakash_jain@apple.com>
255
256         https://bugs.webkit.org/show_bug.cgi?id=151243
257         <rdar://problem/22955197>
258
259         Reviewed by Alexey Proskuryakov.
260
261         * LayoutTestRelay/LayoutTestRelay/main.m:
262         (getTestingSimDevice): Use separate testing device for each worker.
263         * Scripts/webkitpy/layout_tests/controllers/manager.py:
264         (Manager.run): Perform cleanup even if setup fails.
265         * Scripts/webkitpy/port/ios.py:
266         (IOSSimulatorPort.default_child_processes): Calculate number of simulators to use.
267         (IOSSimulatorPort.child_processes): Gets the number of simulators from options variable.
268         (IOSSimulatorPort.setup_test_run): Handle mulitple simulators.
269         (IOSSimulatorPort._quit_ios_simulator): Same
270         (IOSSimulatorPort.clean_up_test_run): Same
271         (IOSSimulatorPort.check_sys_deps): Same
272         (IOSSimulatorPort.testing_device): Same
273         (IOSSimulatorPort.reset_preferences): Same
274         (IOSSimulatorPort.get_simulator_path): Return simulator path.
275         (IOSSimulatorPort._createSimulatorApp): Create the copy of simulator app.
276         * Scripts/webkitpy/xcode/simulator.py:
277         (Device.delete): Delete the simulator device.
278         (Simulator.delete_device): Same
279         (Simulator.wait_until_device_is_booted): Wait for device booting.
280
281 2015-12-08  Ryuan Choi  <ryuan.choi@navercorp.com>
282
283         [EFL] Add API to provide preferences before creating ewk_view
284         https://bugs.webkit.org/show_bug.cgi?id=151587
285
286         Reviewed by Gyuyoung Kim.
287
288         * MiniBrowser/efl/main.c:
289         (on_key_down):
290         (quit):
291         (window_create):
292         Moved settings related code to configuration() not to update settings
293         whenever ewk_view is created.
294         (configuration):
295         (elm_main):
296
297 2015-12-08  Carlos Garcia Campos  <cgarcia@igalia.com>
298
299         Unreviewed. Fix GTK+ API tests after r193639.
300
301         The new jhbuild version needs some more variables ot be present in
302         the builtin dict, even if they are set to None.
303
304         * jhbuild/jhbuildutils.py:
305         (enter_jhbuild_environment_if_available):
306
307 2015-12-07  Gustavo Noronha Silva  <gns@gnome.org>
308
309         [GTK] Notify WebCore when notification is clicked
310         https://bugs.webkit.org/show_bug.cgi?id=151951
311
312         Reviewed by Carlos Garcia Campos.
313
314         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
315         (testWebViewNotification): test the new API.
316
317 2015-12-07  Michael Catanzaro  <mcatanzaro@igalia.com>
318
319         'jhbuild build' should fail immediately when building any module fails
320         https://bugs.webkit.org/show_bug.cgi?id=145697
321
322         Reviewed by Carlos Garcia Campos.
323
324         * efl/jhbuildrc: Update jhbuildrc to account for the removal of the use_lib64 option.
325         * gtk/jhbuildrc: Update jhbuildrc to account for the removal of the use_lib64 option.
326         Everything is placed under lib instead of lib64 now.
327         * jhbuild/jhbuild-wrapper: Update jhbuild to the latest upstream commit, and pass
328         --exit-on-error when running 'jhbuild build'.
329         * jhbuild/jhbuildrc_common.py:
330         (init): Don't override PKG_CONFIG_PATH, CMAKE_PREFIX_PATH, or CMAKE_LIBRARY_PATH. Modern
331         jhbuild should be able to handle these for us without breaking things....
332
333 2015-12-07  Xabier Rodriguez Calvar  <calvaris@igalia.com>
334
335         Add support to import w3c tests from a repository with a different root that the main repo dir
336         https://bugs.webkit.org/show_bug.cgi?id=151751
337
338         Reviewed by Ryosuke Niwa and Youenn Fablet.
339
340         We should be able to import tests from repositories that are not pure test repositories and where tests are kept
341         in a different directory than the repository root.
342
343         This patch introduces a new parameter tests_directory that we will use as root directory to search for
344         tests. All paths will be flattened when copying tests to have a less complicated directory structure. This
345         requires having the copy_path lists including tuples of origin and destination directories.
346
347         * Scripts/webkitpy/w3c/test_downloader.py:
348         (TestDownloader._add_test_suite_paths): Adds the paths as a tuple of origin and destination directory.
349         (TestDownloader.copy_tests): Uses the origin and destination tuple for the paths to copy when copying files.
350         * Scripts/webkitpy/w3c/test_importer_unittest.py:
351         (TestImporterTest.test_tests_directory): Test.
352
353 2015-12-07  Xabier Rodriguez Calvar  <calvaris@igalia.com>
354
355         Mock TestRepositories in W3C importer tests
356         https://bugs.webkit.org/show_bug.cgi?id=151938
357
358         Reviewed by Youenn Fablet.
359
360         The test importer tests should use a fake repository instead of using the real one. The reason why this happened
361         is because the test repository method reading the file was using the filesystem directly instead of taking the
362         host one. This patch changes that.
363
364         * Scripts/webkitpy/w3c/test_downloader.py:
365         (TestDownloader.load_test_repositories): Take a filesystem and use it. If we get no filesystem, we use the
366         default one.
367         (TestDownloader.__init__): When loading the repositories, pass the host filesystem.
368         * Scripts/webkitpy/w3c/test_importer_unittest.py:
369         (TestImporterTest.test_harnesslinks_conversion):
370         (TestImporterTest.test_submodules_generation): Use a fake test repository file.
371
372 2015-12-07  David Kilzer  <ddkilzer@apple.com>
373
374         TestNetscapePlugIn: Address review comment on 193607
375         <http://webkit.org/b/151881>
376
377         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
378         (testSetStatus): Initializing std::unique_ptr<char[]> with
379         nullptr is redundant.
380
381 2015-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
382
383         [GTK] Add webkit_uri_request_get_http_method
384         https://bugs.webkit.org/show_bug.cgi?id=151601
385
386         Reviewed by Martin Robinson.
387
388         Add test case to check HTTP method of WebKitURIRequest.
389
390         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
391         (testURIRequestHTTPMethod):
392         (serverCallback):
393         (beforeAll):
394         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
395         (sendRequestCallback):
396
397 2015-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
398
399         [GTK] Add WebKitWebPage::console-message-sent signal to Web Extensions API
400         https://bugs.webkit.org/show_bug.cgi?id=79918
401
402         Reviewed by Gustavo Noronha Silva.
403
404         Add unit tests to check the different console messages.
405
406         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
407         * TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp: Added.
408         (ConsoleMessageTest::ConsoleMessage::operator==):
409         (ConsoleMessageTest::consoleMessageReceivedCallback):
410         (ConsoleMessageTest::ConsoleMessageTest):
411         (ConsoleMessageTest::~ConsoleMessageTest):
412         (ConsoleMessageTest::waitUntilConsoleMessageReceived):
413         (testWebKitConsoleMessageConsoleAPI):
414         (testWebKitConsoleMessageJavaScriptException):
415         (testWebKitConsoleMessageNetworkError):
416         (testWebKitConsoleMessageSecurityError):
417         (beforeAll):
418         (afterAll):
419         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
420         (consoleMessageSentCallback):
421         (pageCreatedCallback):
422
423 2015-12-07  Ryuan Choi  <ryuan.choi@navercorp.com>
424
425         [EFL] MiniBrowser doesn't exit when called ewk_view_try_close()
426         https://bugs.webkit.org/show_bug.cgi?id=151934
427
428         Reviewed by Csaba Osztrogonác.
429
430         * MiniBrowser/efl/main.c:
431         (on_window_deletion): Revert the changes of r192767.
432
433 2015-12-07  Michael Catanzaro  <mcatanzaro@igalia.com>
434
435         [GTK] update-webkitgtk-libs cannot build mesa
436         https://bugs.webkit.org/show_bug.cgi?id=151535
437
438         Reviewed by Martin Robinson.
439
440         Upgrade to newer mesa in order to build successfully against LLVM 3.7. Add missing
441         dependency of mesa on LLVM, to ensure LLVM is built first. Build LLVM unconditionally, even
442         on architectures where FTL is not supported, to ensure mesa is always buildable, since LLVM
443         does not have a stable API and we cannot expect mesa to be buildable unless we control the
444         LLVM version. Build mesa with --disable-egl since --enable-egl conflicts with
445         --enable-xlib-glx. This fixes update-webkitgtk-libs on distros with LLVM 3.7.
446
447         * gtk/jhbuild.modules:
448
449 2015-12-07  Philippe Normand  <pnormand@igalia.com>
450
451         [GTK][Mac] libWebExtensionTest link error
452         https://bugs.webkit.org/show_bug.cgi?id=150802
453
454         Reviewed by Carlos Garcia Campos.
455
456         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: add dependencies to the webextension library.
457
458 2015-12-06  David Kilzer  <ddkilzer@apple.com>
459
460         TestNetscapePlugIn: Fix leaks found by static analyzer
461         <http://webkit.org/b/151881>
462
463         Reviewed by Darin Adler.
464
465         Fixes the following leaks found by the static analyzer:
466             DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'path'
467                     return false;
468                            ^~~~~
469             DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'target'
470                     return false;
471                            ^~~~~
472             DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'url'
473                     return false;
474                            ^~~~~
475
476         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
477         (toCString): Switch to returning std::unique_ptr<char[]>.  Add
478         early return if allocation fails.
479         (testPostURLFile): Switch to using std::unique_ptr<char[]>.
480         Make sure to call fclose() on filehandle, even for an early
481         return.
482         (testSetStatus): Switch to using std::unique_ptr<char[]>.
483
484 2015-12-05  David Kilzer  <ddkilzer@apple.com>
485
486         prepare-ChangeLog: Fix some warning messages when using svn
487         <http://webkit.org/b/151914>
488
489         Reviewed by Daniel Bates.
490
491         * Scripts/prepare-ChangeLog:
492         (generateFunctionLists): Simplify logic so that we never call
493         normalizePath() with an undefined value.
494         (attributeCommand): Quote $subPath for the shell so that we
495         don't try to run "svn propget" on invalid paths.
496
497 2015-12-04  David Kilzer  <ddkilzer@apple.com>
498
499         TestNetscapePlugIn: Fix remaining static analyzer warnings
500         <http://webkit.org/b/151888>
501
502         Reviewed by Alexey Proskuryakov.
503
504         Fixes the following static analyzer warnings:
505             Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:101:9: warning: Called function pointer is null (null dereference)
506                     CRASH();
507                     ^~~~~~~
508             Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:46:5: note: expanded from macro 'CRASH'
509                 ((void(*)())0)(); /* More reliable, but doesn't say BBADBEEF */ \
510                 ^~~~~~~~~~~~~~~~
511             Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:375:12: warning: Access to field 'pluginTest' results in a dereference of a null pointer (loaded from variable 'obj')
512                 return obj->pluginTest->NPP_SetWindow(window);
513                        ^~~~~~~~~~~~~~~
514             2 warnings generated.
515
516         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
517         (CRASH): Use __builtin_trap() for gcc/clang.
518         (NPP_SetWindow): Add early return if obj is nullptr.
519
520 2015-12-03  Carlos Garcia Campos  <cgarcia@igalia.com>
521
522         [GTK] Test /webkit2/WebKitWebResource/get-data is flaky
523         https://bugs.webkit.org/show_bug.cgi?id=151797
524
525         Reviewed by Martin Robinson.
526
527         Since we switched to use the network process to run the unit tests
528         the test /webkit2/WebKitWebResource/get-data sometimes fails and
529         sometimes passes. We are now also getting the notification for the
530         css image. Since we wait for 3 resources, sometimes the css image
531         is loaded before and then checkResourceData is called for it, but
532         not handled. When the css image is the last one loaded the test
533         passes. So, we just need to wait for the 4 resources.
534
535         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
536         (testWebResourceGetData):
537
538 2015-12-03  David Kilzer  <ddkilzer@apple.com>
539
540         DumpRenderTree: Use-after-free in createBitmapContext() in PixelDumpSupportMac.mm
541         <http://webkit.org/b/151845>
542
543         Reviewed by Simon Fraser.
544
545         Fixes the following static analyzer warning:
546             DumpRenderTree/mac/PixelDumpSupportMac.mm:67:9: warning: Use of memory after it is freed
547                     WTFLogAlways("DumpRenderTree: CGBitmapContextCreate(%p, %llu, %llu, 8, %llu, %p, 0x%x) failed\n", buffer, pixelsHigh, pixelsWide, rowBytes, colorSpace.get(), kCGImageAlphaPremultipliedFirst | kCGBitmapByteOrder32Host);
548                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
549
550         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
551         (createBitmapContext): Free 'buffer' after using it in logging
552         to fix the use-after-free.  Assign a value of nullptr to buffer
553         so we don't return with it set to a freed address.
554
555 2015-12-03  Jer Noble  <jer.noble@apple.com>
556
557         Expose WebCore's InvisibleAutoplayNotPermitted setting to WebKit & WebKit2
558         https://bugs.webkit.org/show_bug.cgi?id=151830
559
560         Reviewed by Anders Carlsson.
561
562         Set invisibleAutoplayNotPermitted to NO by default both in WKTR and DRT.
563
564         * DumpRenderTree/mac/DumpRenderTree.mm:
565         (resetWebPreferencesToConsistentValues):
566         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
567         (WTR::initializeWebViewConfiguration):
568
569 2015-12-03  Anders Carlsson  <andersca@apple.com>
570
571         Remove Objective-C GC support
572         https://bugs.webkit.org/show_bug.cgi?id=151819
573         rdar://problem/23746991
574
575         Reviewed by Dan Bernstein.
576
577         * asan/asan.xcconfig:
578
579 2015-12-02  Yusuke Suzuki  <utatane.tea@gmail.com>
580
581         Allow nil for unspecified benchmark pathes
582         https://bugs.webkit.org/show_bug.cgi?id=151784
583
584         Reviewed by Filip Pizlo.
585
586         `Pathname.new(nil)` will raise an error.
587         Only generate Pathname if the benchmark path is specified.
588
589         * Scripts/run-jsc-benchmarks:
590
591 2015-12-02  Brent Fulgham  <bfulgham@apple.com>
592
593         [Win] Run non-http tests without Cygwin
594         https://bugs.webkit.org/show_bug.cgi?id=151721
595
596         Reviewed by Andy Estes.
597
598         Support native 32-bit and 64-bit Python (and Perl) builds
599         for running tests:
600
601         1. Use "startswith('win')", rather than "== 'win32'" to support
602         various Windows build types.
603         2. Supply full path for some native Windows utilities, since the
604         path environment does not always have the specified, and they are
605         guaranteed to exist in those specific locations.
606         3. Make sure native Windows Python test runs pass proper environment
607         variables to run programs.
608         4. Append 'exe' suffix when running Windows executables.
609         5. Use the _winreg Python module on Windows, since the Cygwin 'regtool'
610         command doesn't exist.
611         
612         * Scripts/update-webkit: Use Perl $^X command to refer to the path of
613         the current Perl executable, rather than requiring a new path search.
614         * Scripts/webkitpy/common/find_files_unittest.py:
615         (TestWinNormalize.test_win): Use startswith('win').
616         * Scripts/webkitpy/common/prettypatch_unittest.py:
617         (test_pretty_diff_encodings): Ditto.
618         * Scripts/webkitpy/common/system/executive.py:
619         (Executive._should_close_fds): Ditto.
620         (Executive.shell_command_for_script): Use startswith('win').
621         (Executive.kill_process): Use full path to killall executable.
622         (Executive.check_running_pid): Use startswith('win').
623         (Executive.running_pids): Ditto.
624         (Executive.kill_all): Ditto. Also use path to 'killall' executable when
625         running under native Windows Python.
626         (Executive._child_process_encoding): Use startswith('win').
627         (Executive._should_encode_child_process_arguments): Ditto.
628         (Executive.popen): Recognize proper script engine on Windows, since it
629         does not support the shebang syntax.
630         (Executive.run_in_parallel): Use startswith('win').
631         * Scripts/webkitpy/common/system/executive_unittest.py:
632         (never_ending_command): Ditto.
633         (ExecutiveTest.test_run_command_with_unicode): Ditto.
634         (ExecutiveTest.serial_test_kill_process): Ditto.
635         (ExecutiveTest.serial_test_kill_all): Ditto.
636         (ExecutiveTest.serial_test_check_running_pid): Ditto.
637         (ExecutiveTest.serial_test_run_in_parallel): Ditto.
638         (main): Ditto.
639         * Scripts/webkitpy/common/system/file_lock.py:
640         (FileLock._create_lock): Ditto.
641         (FileLock._remove_lock): Ditto.
642         * Scripts/webkitpy/common/system/filesystem_unittest.py:
643         (RealFileSystemTest.test_chdir): Ditto.
644         (RealFileSystemTest.test_chdir__notexists): Ditto.
645         (RealFileSystemTest.test_maybe_make_directory__failure): Ditto.
646         * Scripts/webkitpy/common/system/path_unittest.py:
647         (AbspathTest.test_abspath_to_uri_win): Ditto.
648         * Scripts/webkitpy/common/system/platforminfo.py:
649         (PlatformInfo._determine_os_name): Ditto.
650         * Scripts/webkitpy/common/system/user.py: Ditto.
651         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
652         (ManagerTest.integration_test_needs_servers): Ditto.
653         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
654         (LayoutTestApacheHttpd.__init__): Handle upper and lower-case
655         driver letters.
656         (LayoutTestApacheHttpd._get_apache_config_file_path): Ditto.
657         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
658         (TestLayoutTestApacheHttpd.test_start_cmd): Ditto.
659         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
660         (HttpServerBase._check_that_all_ports_are_available): Ditto.
661         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
662         (TestHttpServer.test_start_cmd): Ditto.
663         * Scripts/webkitpy/port/base.py:
664         (Port.to.setup_environ_for_server): Include 'COMSPEC', 'SYSTEMDRIVE',
665         and 'SYSTEMROOT' in environment passed to test runners.
666         (Port._apache_config_file_name_for_platform): Use startswith('win').
667         (Port._build_path): Ditto.
668         (Port._path_to_driver): Include 'exe' suffix when running under native
669         Windows.
670         * Scripts/webkitpy/port/driver.py:
671         (Driver._setup_environ_for_driver): Explicitly make some environment
672         variables strings.
673         * Scripts/webkitpy/port/server_process.py:
674         (ServerProcess.__init__): Use startswith('win').
675         * Scripts/webkitpy/port/win.py:
676         (WinPort): Use the win32 registry utilities on Windows, and appropriate
677         registry key formats.
678         (WinPort._ntsd_location): Revise tool search paths for Windows 10.
679         (WinPort.read_registry_value): Revise to use _winreg library on Windows,
680         and regtool on Cygwin.
681         (WinPort.write_registry_value): Ditto.
682         (WinPort.setup_crash_log_saving): Ditto.
683         (WinPort.restore_crash_log_saving): Ditto.
684         (WinPort.prevent_error_dialogs): Ditto.
685         (WinPort.allow_error_dialogs): Ditto.
686         (WinPort.find_system_pid): Revise to use Windows management
687         infrastructure on native Windows, continue using 'ps' on Cygwin.
688         (WinPort.read_registry_string): Deleted.
689         (WinPort.write_registry_string): Deleted.
690         * Scripts/webkitpy/test/main.py:
691         (main): Use startswith('win').
692         (Tester._parse_args): Ditto.
693
694 2015-12-01  Yusuke Suzuki  <utatane.tea@gmail.com>
695
696         [ES6] Implement LLInt/Baseline Support for ES6 Generators and enable this feature
697         https://bugs.webkit.org/show_bug.cgi?id=150792
698
699         Reviewed by Saam Barati.
700
701         * Scripts/webkitperl/FeatureList.pm:
702
703 2015-12-01  Commit Queue  <commit-queue@webkit.org>
704
705         Unreviewed, rolling out r192914.
706         https://bugs.webkit.org/show_bug.cgi?id=151734
707
708         JSC tests for this change are failing on 32 and 64-bit bots
709         (Requested by ryanhaddad on #webkit).
710
711         Reverted changeset:
712
713         "[ES6] Implement LLInt/Baseline Support for ES6 Generators and
714         enable this feature"
715         https://bugs.webkit.org/show_bug.cgi?id=150792
716         http://trac.webkit.org/changeset/192914
717
718 2015-12-01  David Kilzer  <ddkilzer@apple.com>
719
720         EventSenderProxy::swipeGestureWithWheelAndMomentumPhases() leaks an EventSenderSyntheticEvent
721         <http://webkit.org/b/151726>
722
723         Reviewed by Simon Fraser.
724
725         * WebKitTestRunner/mac/EventSenderProxy.mm:
726         (WTR::EventSenderProxy::swipeGestureWithWheelAndMomentumPhases):
727         Deploy RetainPtr<EventSenderSyntheticEvent> to fix leak.
728
729 2015-12-01  Myles C. Maxfield  <mmaxfield@apple.com>
730
731         Give String and AtomicString an existingHash() function
732         https://bugs.webkit.org/show_bug.cgi?id=151717
733
734         Reviewed by Andreas Kling.
735
736         * TestWebKitAPI/Tests/WTF/AtomicString.cpp:
737         (TestWebKitAPI::TEST):
738         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
739         (TestWebKitAPI::TEST):
740
741 2015-12-01  Yusuke Suzuki  <utatane.tea@gmail.com>
742
743         [ES6] Implement LLInt/Baseline Support for ES6 Generators and enable this feature
744         https://bugs.webkit.org/show_bug.cgi?id=150792
745
746         Reviewed by Saam Barati.
747
748         * Scripts/webkitperl/FeatureList.pm:
749
750 2015-12-01  Sam Weinig  <sam@webkit.org>
751
752         Need completionHandler-based WebKit C SPI for alert, confirm, and prompt
753         <rdar://problem/23320863>
754         https://bugs.webkit.org/show_bug.cgi?id=151708
755
756         Reviewed by Anders Carlsson.
757
758         * WebKitTestRunner/TestController.cpp:
759         (WTR::TestController::createOtherPage):
760         (WTR::TestController::createWebViewWithOptions):
761         Update for new WKPageUIClient.
762
763 2015-12-01  Anders Carlsson  <andersca@apple.com>
764
765         Remove WebKit2.framework
766         https://bugs.webkit.org/show_bug.cgi?id=151715
767
768         Reviewed by Dan Bernstein.
769
770         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad.cpp:
771         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad_bundle.cpp:
772         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
773         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
774         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
775         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
776         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
777
778 2015-12-01  Joseph Pecoraro  <pecoraro@apple.com>
779
780         Unreviewed common typo fix "occurance" => "occurrence".
781
782         * Scripts/webkitpy/tool/commands/queries.py:
783         (FindFlakyTests._print_statistics):
784
785 2015-11-30  Alex Christensen  <achristensen@webkit.org>
786
787         Make ProcessModel always MultipleSecondaryProcesses
788         https://bugs.webkit.org/show_bug.cgi?id=151662
789
790         Reviewed by Antti Koivisto.
791
792         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
793         (TestWebKitAPI::TEST):
794         * WebKitTestRunner/TestController.cpp:
795         (WTR::TestController::generatePageConfiguration):
796
797 2015-11-30  Alex Christensen  <achristensen@webkit.org>
798
799         Make usesNetworkProcess always true
800         https://bugs.webkit.org/show_bug.cgi?id=151580
801
802         Reviewed by Darin Adler.
803
804         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
805         (TestWebKitAPI::TEST):
806         * TestWebKitAPI/Tests/WebKit2/mac/GetPIDAfterAbortedProcessLaunch.cpp:
807         (TestWebKitAPI::TEST):
808         * WebKitTestRunner/TestController.cpp:
809         (WTR::TestController::generatePageConfiguration):
810
811 2015-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
812
813         Unreviewed. Skip GTK+ test /webkit2/WebKitWebView/editable/editable in Debug.
814
815         Add a way to skip unit tests only for Debug or Release builds and
816         skipt the test /webkit2/WebKitWebView/editable/editable only for Debug.
817
818         * Scripts/run-gtk-tests:
819         (SkippedTest):
820         (SkippedTest.__init__):
821         (SkippedTest.__str__):
822         (SkippedTest.skip_entire_suite):
823         (SkippedTest.skip_for_build_type):
824         (TestRunner):
825         (TestRunner.__init__):
826
827 2015-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
828
829         Unreviewed. Fix a crash in GTK+ test /webkit2/WebKitWebView/custom-charset.
830
831         It's an assert hit because we are reloading a view loaded with
832         HTML data which is not supported. Use loadURI instead.
833
834         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
835         (testWebViewCustomCharset):
836
837 2015-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
838
839         [GLIB] Remove GMainLoopSource and GThreadSafeMainLoopSource
840         https://bugs.webkit.org/show_bug.cgi?id=151633
841
842         Reviewed by Csaba Osztrogonác.
843
844         * TestWebKitAPI/PlatformGTK.cmake:
845         * TestWebKitAPI/Tests/WTF/glib/GMainLoopSource.cpp: Removed.
846
847 2015-11-27  Carlos Garcia Campos  <cgarcia@igalia.com>
848
849         [GTK] Remove the remaining uses of GMainLoopSource
850         https://bugs.webkit.org/show_bug.cgi?id=151632
851
852         Reviewed by Žan Doberšek.
853
854         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
855         (testWebViewSyncRequestOnMaxConns):
856         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
857         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
858         (WTR::TestRunner::TestRunner):
859         * WebKitTestRunner/InjectedBundle/TestRunner.h:
860         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
861         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
862         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
863         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
864         (WTR::timeoutSource):
865         (WTR::TestController::notifyDone):
866         (WTR::TestController::platformRunUntil):
867
868 2015-11-27  Csaba Osztrogonác  <ossy@webkit.org>
869
870         [cmake] Add testb3 to the build system
871         https://bugs.webkit.org/show_bug.cgi?id=151619
872
873         Reviewed by Gyuyoung Kim.
874
875         * Scripts/build-jsc:
876
877 2015-11-27  Csaba Osztrogonác  <ossy@webkit.org>
878
879         [jhbuild] Fix pixman build with clang
880         https://bugs.webkit.org/show_bug.cgi?id=151441
881
882         Reviewed by Carlos Garcia Campos.
883
884         * efl/jhbuild.modules:
885         * gtk/jhbuild.modules:
886
887 2015-11-26  David Kilzer  <ddkilzer@apple.com>
888
889         Extract prependToEnvironmentVariableList
890         <http://webkit.org/b/151536>
891
892         Reviewed by Daniel Bates.
893
894         Tests: webkitdirs_unittest/appendToEnvironmentVariableList.pl
895                webkitdirs_unittest/prependToEnvironmentVariableList.pl
896
897         * Scripts/webkitdirs.pm: Export appendToEnvironmentVariableList
898         and prependToEnvironmentVariableList.
899         (appendToEnvironmentVariableList): Simplify variable name.
900         Switch to use $Config{path_sep}.
901         (prependToEnvironmentVariableList): Add new method.
902         (setupMacWebKitEnvironment): Switch to use
903         prependToEnvironmentVariableList().
904         (setupIOSWebKitEnvironment): Ditto.
905
906         * Scripts/webkitperl/webkitdirs_unittest/appendToEnvironmentVariableList.pl: Added.
907         * Scripts/webkitperl/webkitdirs_unittest/prependToEnvironmentVariableList.pl: Added.
908
909 2015-11-24  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
910
911         REGRESSION(r192053): MiniBrowser doesn't exit when clicking on the close-window button
912         https://bugs.webkit.org/show_bug.cgi?id=151567
913
914         Reviewed by Darin Adler.
915
916         * MiniBrowser/efl/main.c: Call window_close() instead of ewk_view_try_close().
917         (on_window_deletion):
918
919 2015-11-23  Carlos Garcia Campos  <cgarcia@igalia.com>
920
921         [GTK] Use the network process unconditionally
922         https://bugs.webkit.org/show_bug.cgi?id=151541
923
924         Reviewed by Alex Christensen.
925
926         Fix TestInspectorServer test. Do not assume we already have the
927         title we want when the page has been loaded, since the title is
928         changed afterwards. So, check if the title has already been set,
929         and if not wait for it.
930
931         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
932         (openRemoteDebuggingSession):
933
934 2015-11-23  Alex Christensen  <achristensen@webkit.org>
935
936         Fix crash in ~WebProcessPool when using Geolocation with useNetworkProcess=true
937         https://bugs.webkit.org/show_bug.cgi?id=151532
938
939         Reviewed by Benjamin Poulain.
940
941         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
942         (TestWebKitAPI::GeolocationTransitionToHighAccuracyStateTracker::eventsChanged):
943         (TestWebKitAPI::TEST):
944         (TestWebKitAPI::GeolocationTransitionToLowAccuracyStateTracker::eventsChanged):
945         (TestWebKitAPI::GeolocationTransitionToHighAccuracyStateTracker::GeolocationTransitionToHighAccuracyStateTracker): Deleted.
946         (TestWebKitAPI::GeolocationTransitionToLowAccuracyStateTracker::GeolocationTransitionToLowAccuracyStateTracker): Deleted.
947         Properly load about:blank in all WebViews to clean up.  Without this change, we had a 
948         Geolocation provider stopping after its state tracker was destroyed with its stack frame,
949         so it was calling a function on a test object that had gone out of scope.
950         Also, call WKContextSetUsesNetworkProcess(context, true) to show what crash this fixed,
951         but that will become the default soon and that call will be removed.
952
953 2015-11-22  David Kilzer  <ddkilzer@apple.com>
954
955         run-webkit-tests: http server for imported W3C tests doesn't work with --layout-tests-directory switch
956         <http://webkit.org/b/151542>
957
958         Reviewed by Daniel Bates.
959
960         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
961         (base_url): Use the Port object (already passed in) to give us
962         the path to the LayoutTests directory, which already checks for a
963         --layout-tests-directory command-line switch.
964         (WebPlatformTestServer.__init__): Remove layout_test_results_dir
965         argument since we can get this from the Port object already
966         passed in via Port.results_directory().  Also switch to use
967         Port.layout_tests_dir() to get the LayoutTests directory.
968
969         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
970         (TestWebPlatformTestServer.test_custom_layout_tests_directory):
971         Add test case for custom LayoutTests directory.
972         (TestWebPlatformTestServer.test_previously_spawned_instance):
973         Update Port object to set mock results directory as if it was
974         set on the command-line.  Remove unneeded argument from
975         WebPlatformTestServer constructor.
976         (TestWebPlatformTestServer.test_corrupted_subserver_files): Ditto.
977
978         * Scripts/webkitpy/port/base.py:
979         (Port.to.start_web_platform_test_server): Remove unneeded
980         argument from WebPlatformTestServer constuctor.
981
982 2015-11-22  Carlos Garcia Campos  <cgarcia@igalia.com>
983
984         [GTK] Some unit tests fail when using the network process
985         https://bugs.webkit.org/show_bug.cgi?id=151490
986
987         Reviewed by Martin Robinson.
988
989         Run the soup server in a separate thread in TestResources test to
990         avoid deadlocks.
991
992         This fixes /webkit2/WebKitWebView/sync-request-on-max-conns and
993         /webkit2/WebKitWebResource/get-data when using the network process.
994
995         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
996         (beforeAll): Create the WebKitTestServer with ServerRunInThread flag.
997         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.cpp:
998         (WebKitTestServer::WebKitTestServer): When ServerRunInThread is
999         present, create a WorkQueue to run the server.
1000         (WebKitTestServer::run): Run the server in the work queue if it
1001         has been created.
1002         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.h: Convert server
1003         type into server options as flags.
1004
1005 2015-11-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1006
1007         [GTK] ImageDiff should normalize the diff image
1008         https://bugs.webkit.org/show_bug.cgi?id=151261
1009
1010         Reviewed by Sergio Villar Senin.
1011
1012         * ImageDiff/gtk/ImageDiff.cpp:
1013         (readPixbufFromStdin): Fix memory leak.
1014         (differenceImageFromDifferenceBuffer): Normalize diff buffer.
1015         (calculateDifference): Pass max distance to differenceImageFromDifferenceBuffer.
1016
1017 == Rolled over to ChangeLog-2015-11-21 ==