[EFL] Remove non Coordinated Graphics code path from cmake build system after r142169
[WebKit-https.git] / Tools / ChangeLog
1 2014-08-29  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2
3         [EFL] Remove non Coordinated Graphics code path from cmake build system after r142169
4         https://bugs.webkit.org/show_bug.cgi?id=135560
5
6         Reviewed by Gyuyoung Kim.
7
8         * Scripts/webkitperl/FeatureList.pm: Removed TILED_BACKING_STORE guard.
9
10 2014-08-28  Daniel Bates  <dabates@apple.com>
11
12         [Win] update-webkit should update auxiliary libs by default
13
14         Reviewed by Dan Bernstein.
15
16         The change set <http://trac.webkit.org/changeset/172795> inadvertently prevented update-webkit
17         from updating the Windows auxiliary libs by default. We should make update-webkit update the
18         Windows auxiliary libs by default. This will make its behavior match its usage text.
19
20         * Scripts/update-webkit:
21
22 2014-08-28  Brian J. Burg  <burg@cs.washington.edu>
23
24         build-webkit --inspector-frontend tries to copy files from old inspector path
25         https://bugs.webkit.org/show_bug.cgi?id=136346
26
27         Reviewed by Timothy Hatcher.
28
29         Remove the old code path for copying inspector resources. It doesn't work.
30         Complain if this option is passed to CMake-based builds.
31
32         * Scripts/build-webkit:
33         * Scripts/webkitdirs.pm:
34         (copyInspectorFrontendFiles): Deleted.
35
36 2014-08-28  Alexey Proskuryakov  <ap@apple.com>
37
38         Dashboard metrics page could show longest stretch of red
39         https://bugs.webkit.org/show_bug.cgi?id=136334
40
41         Reviewed by Sam Weinig.
42
43         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
44         (Analyzer.prototype._updateStretchOfRedCounters):
45         (Analyzer.prototype._countPercentageOfGreen):
46         When counting percentage of green, also keep track of how long the page was red.
47
48         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsView.js:
49         (MetricsView.prototype._update.addDivider):
50         (MetricsView.prototype._update.appendQueueResults):
51         Show it in aggregate queues (can't think of a reason to have it in individual ones).
52
53         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Metrics.css:
54         Changed to use an explicit divider element between green time and performance groups,
55         as there are too many combinations to easily express in CSS.
56
57 2014-08-28  Carlos Garcia Campos  <cgarcia@igalia.com>
58
59         [GTK] Add webkit_uri_response_get_http_headers to WebKit2 GTK+ API
60         https://bugs.webkit.org/show_bug.cgi?id=136248
61
62         Reviewed by Gustavo Noronha Silva.
63
64         Add new test case for webkit_uri_response_get_http_headers().
65
66         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
67         (testURIResponseHTTPHeaders):
68         (serverCallback):
69         (beforeAll):
70
71 2014-08-27  Alexey Proskuryakov  <ap@apple.com>
72
73         EWS status link at build.webkit.org/dashboard is incorrect until EWS pop-up is opened
74         https://bugs.webkit.org/show_bug.cgi?id=131668
75
76         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js:
77         (EWSQueue.prototype.loadDetailedStatus): Fixed a typo in assertion.
78
79 2014-08-27  Zalan Bujtas  <zalan@apple.com>
80
81         Subpixel layout: Cleanup snapSizeToPixel/snapSizeToDevicePixel.
82         https://bugs.webkit.org/show_bug.cgi?id=136264
83
84         Reviewed by Simon Fraser.
85         
86         1. Align snapSizeToPixel()/snapSizeToDevicePixel() function names with the rest of snapping
87         functions. ->snappedIntSize()/snapSizeToDevicePixel().
88         2. Operate on LayoutSize/LayoutPoint instead of LayoutUnit/LayoutUnit to reflect functionality.
89
90         Covered by existing tests.
91
92         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
93         (TestWebKitAPI::TEST): Deleted.
94
95 2014-08-27  Alexey Proskuryakov  <ap@apple.com>
96
97         EWS status link at build.webkit.org/dashboard is incorrect until EWS pop-up is opened
98         https://bugs.webkit.org/show_bug.cgi?id=131668
99
100         Reviewed by Daniel Bates.
101
102         We used to fetch the URL from EWS detailed status JSON, but there isn't much reason
103         to not just hardcode.
104
105         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js:
106         (EWS.prototype.queueStatusURL): Added.
107
108         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js:
109         (EWSQueue.prototype.get statusPageURL): Use the above function.
110         (EWSQueue.prototype.loadDetailedStatus): Changed assignment to an assertion.
111
112         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js:
113         (EWSQueueView.prototype.update): While at it, made a popover show up even if there
114         are no patches in the queue. The popover has other useful information, such as charts
115         link and bot status.
116
117 2014-08-27  Alexey Proskuryakov  <ap@apple.com>
118
119         https://bugs.webkit.org/show_bug.cgi?id=136317
120         Dashboard metrics page sometimes shows 0 for best time
121
122         Reviewed by Tim Horton.
123
124         This also affects regular dashboard display in a good way - iterations that failed
125         due to infrastructure misbehavior will more reliably show up as yellow and not red.
126
127         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
128         (BuildbotIteration): Added a list of steps that we actually care about. It will need to be
129         updated if we rename steps.
130         (BuildbotIteration.prototype.get productive): Now that computation is more involved,
131         do it once.
132         (BuildbotIteration.prototype._parseData): Tweak computation of "productive" - builds
133         that failed e.g. at downloading built archive step are not productive.
134
135 2014-08-27  Brent Fulgham  <bfulgham@apple.com>
136
137         [Win] Unreviewed gardening.
138
139         * win/AssembleBuildLogs/AssembleLogs.cmd: Add some missing build logs to the set
140         of logs assembled into the final build output.
141
142 2014-08-27  Alexey Proskuryakov  <ap@apple.com>
143
144         build.webkit.org/dashboard: Add a metrics page with overall bot performance results
145         https://bugs.webkit.org/show_bug.cgi?id=136196
146
147         Reviewed by Timothy Hatcher.
148
149         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External: Added.
150         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External/daterangepicker.css: Added.
151         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External/jquery-1.11.1.min.js: Added.
152         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External/jquery.daterangepicker.js: Added.
153         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External/moment.min.js: Added.
154         A date range picker control with dependencies.
155         There are a few modifications from upstream at <https://github.com/longbill/jquery-date-range-picker>:
156         - Fixed a bug where selected dates were not at midnight the first time a range was chosen
157         (it didn't happen again upon re-opening the picker).
158         - Made made style tweaks to match Dashboard UI.
159
160         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
161         Don't create objects that are not needed by the given app, and thus are not loaded at all.
162
163         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js: Added.
164         Math to count all the things. Only supports open source tree and trunk at the moment,
165         but written with internal tree and branches in mind.
166
167         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js: Added.
168         Like dashboard Main.js, draws the UI and creates all necessary objects.
169
170         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsView.js: Added.
171         A view for table cells.
172
173         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
174         (Settings.prototype.toggleSettingsDisplay): Added an event for entering settings.
175         Metrics page has individual platforms initially scrolled away form the view, so 
176         it needs to scroll down to reveal what's being configured.
177
178         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
179         Added Array.prototype.average and Array.prototype.median.
180
181         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
182         Made gear icon fixed instead of absolute, so that it's visible on metrics page when
183         in settings mode.
184
185         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Metrics.css:
186         Additional style rules.
187
188         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/metrics.html:
189         The metrics page.
190
191 2014-08-27  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
192
193         Remove networkinfo watch category in watchlist
194         https://bugs.webkit.org/show_bug.cgi?id=136279
195
196         Reviewed by Alexey Proskuryakov.
197
198         Network info was removed. So, it is not needed anymore.
199
200         * Scripts/webkitpy/common/config/watchlist:
201
202 2014-08-26  Alexey Proskuryakov  <ap@apple.com>
203
204         build.webkit.org/dashboard: Poor performance when there are broken builds at initial load time
205         https://bugs.webkit.org/show_bug.cgi?id=136281
206
207         Reviewed by Tim Horton.
208
209         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
210         Track and expose whether the itertion is being loaded. Made update() a no-op if
211         the iteration is already being loaded.
212
213         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
214         (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus): Instead of
215         loading everything at once, ask the queue to load a little more. We can always repeat
216         if we still don't have enough data.
217
218         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
219         (BuildbotQueue.prototype.loadMoreHistoricalIterations): Added a function that loads
220         10 more iterations intelligently.
221
222 2014-08-26  Alexey Proskuryakov  <ap@apple.com>
223
224         build.webkit.org/dashboard raises an exception when Trac RSS fails to load
225         https://bugs.webkit.org/show_bug.cgi?id=136283
226
227         Reviewed by Tim Horton.
228
229         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
230         Don't.
231
232 2014-08-26  Alexey Proskuryakov  <ap@apple.com>
233
234         build.webkit.org/dashboard raises an exception after a hidden platform is removed
235         https://bugs.webkit.org/show_bug.cgi?id=136282
236
237         Reviewed by Tim Horton.
238
239         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
240         (updateHiddenPlatforms): Check that the platform is still valid.
241
242 2014-08-26  Matt Lilek  <mrl@apple.com>
243
244         Add WebKit SPI to control the navigator.standalone property
245         https://bugs.webkit.org/show_bug.cgi?id=136189
246
247         Reviewed by Andy Estes.
248
249         Add API test for WKPreferences
250
251         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
252         * TestWebKitAPI/Tests/WebKit2Cocoa/Preferences.mm:
253         (TEST):
254
255 2014-08-26  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
256
257         Remove ENABLE_DRT environment variable to enable SHARED_CORE
258         https://bugs.webkit.org/show_bug.cgi?id=136205
259
260         Reviewed by Andrei Bucur.
261
262         EFL port doesn't need to enable SHARED_CORE since r172894. Thus, we don't need to
263         use ENABLE_DRT enviroment variable, which enables SHARED_CORE.
264
265         * Scripts/webkitdirs.pm:
266         (generateBuildSystemFromCMakeProject):
267
268 2014-08-26  Brent Fulgham  <bfulgham@apple.com>
269
270         [Win] Version stamp should include package-level version
271         https://bugs.webkit.org/show_bug.cgi?id=136266
272         <rdar://problem/18134138>
273
274         Reviewed by David Kilzer.
275
276         * Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl: Add
277         tests for the full 3+ digit version.
278         * Scripts/webkitperl/auto-version_unittest/versionStampTests.pl:
279         Confirm that the final output DLL uses the 3+ digit version.
280
281 2014-08-26  Brent Fulgham  <bfulgham@apple.com>
282
283         [Win] WebKit IDL incorrectly passes HWND as OLE_HANDLE
284         https://bugs.webkit.org/show_bug.cgi?id=136258
285         <rdar://problem/18134138>
286
287         Reviewed by Tim Horton.
288
289         Avoid 32/64-bit truncation by preventing 64-bit HWND (and other)
290         values from passing through the 32-bit OLE_HANDLE data type.
291
292         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
293         (AccessibilityController::rootElement):
294         * DumpRenderTree/win/DumpRenderTree.cpp:
295         (resetWebViewToConsistentStateBeforeTesting):
296         (runTest):
297         (createWebViewAndOffscreenWindow):
298         * DumpRenderTree/win/FrameLoadDelegate.h:
299         (FrameLoadDelegate::didReceiveIcon):
300         * DumpRenderTree/win/TestRunnerWin.cpp:
301         (TestRunner::setWindowIsKey):
302         * DumpRenderTree/win/UIDelegate.cpp:
303         (UIDelegate::trackCustomPopupMenu):
304         (UIDelegate::drawHeaderInRect):
305         (UIDelegate::drawFooterInRect):
306         (UIDelegate::webViewClose):
307         (UIDelegate::webViewFocus):
308         (UIDelegate::webViewSetCursor):
309         (UIDelegate::drawBackground):
310         * DumpRenderTree/win/UIDelegate.h:
311         (UIDelegate::webViewFirstResponder):
312         (UIDelegate::makeFirstResponder):
313         (UIDelegate::contextMenuItemsForElement):
314         (UIDelegate::addCustomMenuDrawingData):
315         (UIDelegate::cleanUpCustomMenuDrawingData):
316         (UIDelegate::webViewLostFocus):
317         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp:
318         (TestWebKitAPI::WebViewDestructionWithHostWindow::SetUp):
319         * WinLauncher/PrintWebUIDelegate.cpp:
320         (PrintWebUIDelegate::drawHeaderInRect):
321         (PrintWebUIDelegate::drawFooterInRect):
322         * WinLauncher/PrintWebUIDelegate.h:
323         (PrintWebUIDelegate::webViewFirstResponder):
324         (PrintWebUIDelegate::makeFirstResponder):
325         (PrintWebUIDelegate::contextMenuItemsForElement):
326         (PrintWebUIDelegate::trackCustomPopupMenu):
327         (PrintWebUIDelegate::addCustomMenuDrawingData):
328         (PrintWebUIDelegate::cleanUpCustomMenuDrawingData):
329         * WinLauncher/WinLauncher.cpp:
330         (WinLauncher::prepareViews):
331         * WinLauncher/WinLauncherWebHost.h:
332         (WinLauncherWebHost::didReceiveIcon):
333
334 2014-08-26  Daniel Bates  <dabates@apple.com>
335
336         Only define WEBCORE_EXPORT when building DumpRenderTree for Windows and iOS
337
338         Rubber-stamped by Tim Horton.
339
340         The Windows and iOS ports are the only ports that make use of WebCore headers
341         in DumpRenderTree.
342
343         * DumpRenderTree/config.h:
344
345 2014-08-26  Dan Bernstein  <mitz@apple.com>
346
347         runSvnUpdateAndResolveChangeLogs() doesn’t work when invoked from a script outside Tools/Scripts
348         https://bugs.webkit.org/show_bug.cgi?id=136254
349
350         Reviewed by Tim Horton.
351
352         * Scripts/webkitdirs.pm:
353         (runSvnUpdateAndResolveChangeLogs): Locate resolve-ChangeLogs relative to the source tree,
354         not the invoking script.
355
356 2014-08-26  Krzysztof Czech  <k.czech@samsung.com>
357
358         [EFL] Utilize espeak as a synthesizer back-end for WebSpeech
359         https://bugs.webkit.org/show_bug.cgi?id=136127
360
361         Reviewed by Gyuyoung Kim.
362
363         Add espeak dependency.
364
365         * efl/install-dependencies:
366
367 2014-08-25  Alexey Proskuryakov  <ap@apple.com>
368
369         Remove a little more accidentally landed code from r172891.
370
371         iteration.branch also wasn't meant to be landed.
372
373         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
374         (BuildbotIteration.prototype._parseData):
375
376 2014-08-25  Alexey Proskuryakov  <ap@apple.com>
377
378         REGRESSION (r172891): Internal dashboard is broken.
379
380         Removing some accidentally landed code - I needed "changes" for another patch, but
381         not here, and then I decided to not use it anyway.
382
383         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
384         (BuildbotIteration.prototype._parseData):
385
386 2014-08-25  Daniel Bates  <dabates@apple.com>
387
388         Fix the iOS DumpRenderTree build after <http://trac.webkit.org/changeset/172814/>
389         (https://bugs.webkit.org/show_bug.cgi?id=136108)
390
391         Use a similar approach as in TestWebKitAPI/config.h and define a stub for the macro define WEBCORE_EXPORT
392         so that we can compile DumpRenderTree for iOS.
393
394         * DumpRenderTree/config.h:
395
396 2014-08-25  Alexey Proskuryakov  <ap@apple.com>
397
398         Make build.webkit.org/dashboard work with changeset_show_files=location
399         https://bugs.webkit.org/show_bug.cgi?id=136237
400
401         Reviewed by Tim Horton.
402
403         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
404         (Trac.prototype._convertCommitInfoElementToObject): Remove location information
405         from description before getting title, and also actually parse the location into
406         result object when available.
407
408         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
409         (String.prototype.startsWith): Added.
410
411 2014-08-25  Tanay C  <tanay.c@samsung.com>
412
413         [EFL][WK2] Minibrowser : Enhance application to be able to support history list navigation
414         https://bugs.webkit.org/show_bug.cgi?id=135795
415
416         Reviewed by Gyuyoung Kim.
417
418         * MiniBrowser/efl/main.c: Adding functionality for long press history list navigation
419         (history_list_hide): Hiding and dereferencing the history list and items
420         (on_key_down):
421         (on_mouse_down):
422         (on_back_button_clicked): Early return for longpress 
423         (on_forward_button_clicked): Early return for longpress 
424         (list_item_label_get): Populate item labels
425         (on_list_item_select): Navigates on selection from history list
426         (navigation_button_longpress_process): Populates the history list and displays it
427         (on_forward_button_longpress):
428         (on_back_button_longpress):
429         (window_create): Add the widget for history list
430
431 2014-08-25  Carlos Alberto Lopez Perez  <clopez@igalia.com>
432
433         [GTK] JHBuild module gst-plugins-base fails to build on x86 with GCC 4.9
434         https://bugs.webkit.org/show_bug.cgi?id=136152
435
436         Reviewed by Philippe Normand.
437
438         * gtk/jhbuild.modules: Apply gst-plugins-base-fix-build-gcc-4.9-x86.patch.
439         * gtk/patches/gst-plugins-base-fix-build-gcc-4.9-x86.patch: Added.
440         Cherry pick upstream patches daa194 and 4e3d101.
441
442 2014-08-24  Zan Dobersek  <zdobersek@igalia.com>
443
444         GenericHashTraits::peek() is producing copies of passed-in temporary values
445         https://bugs.webkit.org/show_bug.cgi?id=131461
446
447         Reviewed by Darin Adler.
448
449         Add a test case that checks the number of copies and moves of the mapped objects
450         when calling HashMap::get(). Exactly one copy of the mapped value should be
451         performed when there exists a value that is mapped to the specified key, and
452         exactly one move and no copies of the empty value should be performed when there
453         isn't any mapped value for the specified key.
454
455         * TestWebKitAPI/Tests/WTF/CopyMoveCounter.h: Added.
456         (CopyMoveCounter::TestingScope::TestingScope):
457         (CopyMoveCounter::CopyMoveCounter):
458         (CopyMoveCounter::operator=):
459         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
460         (TestWebKitAPI::TEST):
461
462 2014-08-24  Ryuan Choi  <ryuan.choi@samsung.com>
463
464         [EFL] Introduce DEVELOPER_MODE
465         https://bugs.webkit.org/show_bug.cgi?id=135884
466
467         Reviewed by Gyuyoung Kim.
468
469         * Scripts/webkitdirs.pm: Turn on DEVELOPER_MODE for the EFL port.
470         (generateBuildSystemFromCMakeProject):
471
472 2014-08-24  Alexey Proskuryakov  <ap@apple.com>
473
474         build.webkit.org/dashboard unnecessarily loads results of hidden queues
475         https://bugs.webkit.org/show_bug.cgi?id=136195
476
477         Reviewed by Tim Horton.
478
479         This patch also makes it possible to avoid any automatic loading, as needed for metrics view.
480
481         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
482         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js:
483         Don't start an update just because a queue object was created. Periodic updates
484         are triggered by views, so it only makes sense to do the same for the initial update.
485
486         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
487         Now that Trac object doesn't auto-load, start loading here.
488
489         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
490         (QueueView): Calling _updateHiddenState right away was wrong, because it accesses
491         a data member added by subclasses later. With this.platform being undefined, it
492         always looked like this queue was not hidden.
493         (QueueView.prototype._updateHiddenState): Start an immediate update, too.
494
495         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
496         (Trac): Don't load anything here, the client may choose to load a custom date range.
497         (Trac.prototype.startPeriodicUpdates): Added a function to start automatic loading.
498
499 2014-08-23  Alexey Proskuryakov  <ap@apple.com>
500
501         build.webkit.org/dashboard: Further improve Trac loading
502         https://bugs.webkit.org/show_bug.cgi?id=136174
503
504         Reviewed by Timothy Hatcher.
505
506         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
507         (Trac.prototype._xmlTimelineURL): Passing -1 as "max" resulted in an off by one
508         error, the oldest commit within the range wasn't returned. The correct argument for
509         "no limit" is 0.
510         (Trac.prototype.load): Added a function to load a specific time range.
511         (Trac.prototype._loaded): Updated to support loading revisions that are arbitrarily
512         positioned with regards to ones that were already known.
513
514 2014-08-23  Alexey Proskuryakov  <ap@apple.com>
515
516         build.webkit.org/dashboard: Make it possible to pull historic data from Buildbot
517         https://bugs.webkit.org/show_bug.cgi?id=136182
518
519         Reviewed by Timothy Hatcher.
520
521         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
522         Make it possible to create a complete BuildbotIteration object with JSON, not only by
523         loading data from the network.
524
525         An iteration has three states:
526         1. Just created, it only knows the revision, and whether it's already finished.
527         BuildbotIteration constructor used to create these.
528         2. A complete JSON report loaded from buildbot. The new constructor form creates these.
529         3. Data about tests is fetched.
530
531         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
532         Make it possible to pull all data from a buildbot queue. This needs to be better
533         optimized eventually, as it's somewhat slow.
534
535 2014-08-22  Renato Nagy  <nagy.renato@stud.u-szeged.hu>
536
537         Remove LevelDB.
538         https://bugs.webkit.org/show_bug.cgi?id=136170
539
540         Reviewed by Gyuyoung Kim.
541
542         * Scripts/webkitpy/common/config/watchlist:
543         * Scripts/webkitpy/style/checker.py:
544
545 2014-08-22  Carlos Alberto Lopez Perez  <clopez@igalia.com>
546
547         [GTK] install-dependencies don't installs Xvfb that is needed for the tests.
548         https://bugs.webkit.org/show_bug.cgi?id=136153
549
550         Reviewed by Martin Robinson.
551
552         * gtk/install-dependencies: Add Xvfb package to the list of dependencies necessary for running tests.
553
554 2014-08-21  Alex Christensen  <achristensen@webkit.org>
555
556         [Win] Another unreviewed build fix.
557
558         * DumpRenderTree/config.h:
559         Defined WEBCORE_EXPORT on Windows.
560
561 2014-08-21  Rohit Kumar  <kumar.rohit@samsung.com>
562
563         [EFL][WK2] Minibrowser : Add stop button to abort page load
564         https://bugs.webkit.org/show_bug.cgi?id=136122
565
566         Reviewed by Gyuyoung Kim.
567
568         * MiniBrowser/efl/main.c:
569         (on_key_down):
570         (on_stop_button_clicked): Callback for stop button press.
571         (window_create):
572
573 2014-08-21  Carlos Alberto Lopez Perez  <clopez@igalia.com>
574
575         [GTK] Load the llvmpipe (Mesa) libraries when running the tests with Xvfb.
576         https://bugs.webkit.org/show_bug.cgi?id=134070
577
578         Reviewed by Martin Robinson.
579
580         * Scripts/webkitpy/port/base.py:
581         (Port.__init__): Set default _jhbuild_wrapper variable.
582         (Port._should_use_jhbuild): Implement generic check.
583         * Scripts/webkitpy/port/efl.py: Rename to jhbuild_wrapper variable
584         to make it consistent with the other ports.
585         * Scripts/webkitpy/port/gtk.py:
586         (GtkPort.__init__): Use the new _should_use_jhbuild() method.
587         (GtkPort.setup_environ_for_server): Get the path for llvmpipe_libgl_path by
588         querying the jhbuild with printenv. Also check that the path contains
589         the libraries we expect. Preload this path only for XvfbDriver.
590         * Scripts/webkitpy/port/xvfbdriver.py:
591         (XvfbDriver.check_driver): Check for the jhbuild wrapper and use it.
592         (XvfbDriver._start): The environment for llvmpipe_libgl_path is now
593         configured at setup_environ_for_server()
594         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
595         (XvfbDriverTest.make_driver): Get the port default environment.
596         (XvfbDriverTest.test_start_no_pixel_tests): The expected log now
597         should include the environment that is passed when running Xvfb.
598         (XvfbDriverTest.test_start_pixel_tests): Ditto.
599         (XvfbDriverTest.test_start_arbitrary_worker_number): Ditto.
600         (XvfbDriverTest.test_start_next_worker): Ditto.
601         * gtk/jhbuild.modules: Rename checkoutdir to generic "Mesa" to
602         prevent future problems when the version is raised. Add also a
603         comment with a warning.
604         * gtk/jhbuildrc: The path LLVMPIPE_LIBGL_PATH should be the one
605         that has the llvm optimized Gallium libGL libraries.
606
607 2014-08-21  Renato Nagy  <nagy.renato@stud.u-szeged.hu>
608
609         Fix countFailures of RunLLINTCLoopTests and Run32bitJSCTests.
610         https://bugs.webkit.org/show_bug.cgi?id=136125
611
612         Reviewed by Csaba Osztrogonác.
613
614         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
615         (RunLLINTCLoopTests.countFailures):
616         (Run32bitJSCTests.countFailures):
617         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
618         (RunLLINTCLoopTestsTest):
619         (RunLLINTCLoopTestsTest.assertResults):
620         (RunLLINTCLoopTestsTest.test_failures):
621         (RunLLINTCLoopTestsTest.test_failure):
622         (RunLLINTCLoopTestsTest.test_no_failure):
623         (Run32bitJSCTestsTest):
624         (Run32bitJSCTestsTest.assertResults):
625         (Run32bitJSCTestsTest.test_failures):
626         (Run32bitJSCTestsTest.test_failure):
627         (Run32bitJSCTestsTest.test_no_failure):
628
629 2014-08-20  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
630
631         Unreviewed, EFL build fix since r172814.
632
633         * WebKitTestRunner/config.h: Define WEBCORE_EXPORT.
634
635 2014-08-20  Alex Christensen  <achristensen@webkit.org>
636
637         Introducing WEBCORE_EXPORT macro.
638         https://bugs.webkit.org/show_bug.cgi?id=136108
639
640         Reviewed by Antti Koivisto.
641
642         * TestWebKitAPI/config.h:
643         Added stub definition of WEBCORE_EXPORT defined to nothing to be able to compile with WebCore headers.
644
645 2014-08-20  Rebecca Hauck  <rhauck@adobe.com>
646
647         import-w3c-tests doesn't import .svg support files
648         https://bugs.webkit.org/show_bug.cgi?id=135928
649
650         Reviewed by Bem Jones-Bey.
651
652         This patch fixes the W3C import script to not treat all
653         files with an xml mimetype as convertible tests, which
654         was causing SVG support files to not be imported.
655
656         * Scripts/webkitpy/w3c/test_importer.py:
657         (TestImporter.find_importable_tests):
658
659 2014-08-19  Dan Bernstein  <mitz@apple.com>
660
661         update-webkit should not check for the presence of Apple’s Internal directory
662         Last part of https://bugs.webkit.org/show_bug.cgi?id=135815
663
664         Reviewed by Tim Horton.
665
666         * Scripts/update-webkit:
667
668 2014-08-19  Zalan Bujtas  <zalan@apple.com>
669
670         Remove ENABLE(SUBPIXEL_LAYOUT).
671         https://bugs.webkit.org/show_bug.cgi?id=136077
672
673         Reviewed by Simon Fraser.
674
675         Remove compile time flag SUBPIXEL_LAYOUT. All ports have it enabled for a while now.
676
677         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
678
679 2014-08-19  Akos Kiss  <akiss@inf.u-szeged.hu>
680
681         Let the caller define JSC_timeout for run-javascriptcore-tests
682         https://bugs.webkit.org/show_bug.cgi?id=136068
683
684         Reviewed by Csaba Osztrogonác.
685
686         Keep the 60 second timeout for jsc tests as the default setting but
687         don't override the value of JSC_timeout if already set.
688
689         * Scripts/run-javascriptcore-tests:
690
691 2014-08-19  Renato Nagy  <nagy.renato@stud.u-szeged.hu>
692
693         Remove obsolete run-javascriptcore-tests result parsing from master.cfg
694         https://bugs.webkit.org/show_bug.cgi?id=136039
695
696         Reviewed by Csaba Osztrogonác.
697
698         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
699         (RunJavaScriptCoreTests.commandComplete):
700         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
701         (RunJavaScriptCoreTestsTest.test_no_failure_new_output):
702         (RunJavaScriptCoreTestsTest.test_mozilla_failure_old_output):
703         (RunJavaScriptCoreTestsTest):
704         (RunJavaScriptCoreTestsTest.test_jsc_stress_failure_new_output):
705         (RunJavaScriptCoreTestsTest.test_mozilla_failure_new_output): Deleted.
706         (test_layout_failure_new_output): Deleted.
707         (test_layout_crash_new_output): Deleted.
708         (test_mozilla_and_layout_failure_new_output): Deleted.
709         (test_jsc_stress_failure_new_output): Deleted.
710         (test_js_crashes_and_jsc_stress_failures_new_output): Deleted.
711
712 2014-08-19  Alexey Proskuryakov  <ap@apple.com>
713
714         build.webkit.org/dashboard should not request 50 revisions from trac each time
715         https://bugs.webkit.org/show_bug.cgi?id=127130
716
717         build.webkit.org/dashboard sometimes fetches a Trac revision in an intermediate state, and never updates later
718         https://bugs.webkit.org/show_bug.cgi?id=127131
719
720         Reviewed by Timothy Hatcher.
721
722         Turns out that requesting 50 builds is much slower than requesting by date - even
723         if the request ends up returning more than 50 results. There is no way to only
724         request updates, but this change brings request time from 6-8 seconds down to
725         less than a second.
726
727         This patch generalizes date handling for later use in metrics code. As part of the
728         rewrite, I made newly fetched data update author e-mail in previously fetched
729         revisions, as it changes after commit queue first lands.
730
731         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
732         Updated for event rename. I changed the trac event to not contain the list of new
733         commits, as we now sometimes update old commits, and that couldn't be expressed
734         in event data. We never used the list anywhere in the first place.
735
736         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
737         (Trac.prototype._xmlTimelineURL): Made this function take arbitrary dates. When called
738         without arguments, return commits for today and yesterday.
739         (Trac.prototype._loaded):
740         (Trac.prototype.update): Moved the function for processing loaded results out of
741         here for clarity, and also because I'm going to have a separate loading code path
742         for metrics.
743
744 2014-08-18  Dan Bernstein  <mitz@apple.com>
745
746         Added an update-webkit option to override the ../Internal check.
747         Part of https://bugs.webkit.org/show_bug.cgi?id=135815
748
749         Reviewed by Tim Horton.
750
751         * Scripts/update-webkit:
752         Added an explicit --internal option to control updating ../Internal, defaulting to whether
753         ../Internal exists.
754         (runSvnUpdate): Moved to webkitdirs.pm.
755         (runGitUpdate): Ditto.
756         * Scripts/webkitdirs.pm:
757         (runSvnUpdateAndResolveChangeLogs): Moved runSvnUpdate from update-webkit and renamed to this.
758         (runGitUpdate): Moved from update-webkit.
759
760 2014-08-18  Pratik Solanki  <psolanki@apple.com>
761
762         Make update-webkit more lenient for pure git svn repositories
763         https://bugs.webkit.org/show_bug.cgi?id=135805
764
765         Reviewed by Oliver Hunt.
766
767         Make the call to git fetch be non fatal. If you have a pure git svn repository, then the
768         call to git fetch will fail and update-webkit will abort. The purpose of r72966 was to
769         provide an optimization when you have a git repository setup. We should not fail if the
770         git setup does not have svn-remote.svn.fetch set.
771
772         * Scripts/update-webkit:
773         (runGitUpdate):
774
775 2014-08-18  Simon Fraser  <simon.fraser@apple.com>
776
777         Enable Web Inspector in MiniBrowser WK2 windows
778         https://bugs.webkit.org/show_bug.cgi?id=136045
779
780         Reviewed by Tim Horton.
781         
782         Set the pref to enable developer extras for all WK2 windows.
783
784         * MiniBrowser/mac/WK2BrowserWindowController.m:
785         (-[WK2BrowserWindowController awakeFromNib]):
786
787 2014-08-18  Renato Nagy  <nagy.renato@stud.u-szeged.hu>
788
789         master.cfg should handle special return codes of run-perf-tests
790         https://bugs.webkit.org/show_bug.cgi?id=135974
791
792         Reviewed by Ryosuke Niwa.
793
794         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
795         (RunAndUploadPerfTests.getText2):
796         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
797         (RunAndUploadPerfTestsTest):
798         (RunAndUploadPerfTestsTest.assertResults):
799         (RunAndUploadPerfTestsTest.test_tests_failed):
800         (RunAndUploadPerfTestsTest.test_build_bad_build):
801         (RunAndUploadPerfTestsTest.test_build_bad_source_json):
802         (RunAndUploadPerfTestsTest.test_build_bad_marge):
803         (RunAndUploadPerfTestsTest.test_build_bad_failed_uploading):
804         (RunAndUploadPerfTestsTest.test_build_bad_preparation):
805
806 2014-08-17  Brent Fulgham  <bfulgham@apple.com>
807
808         [Win] Unreviewed change to force rebuild
809         (plus drive-by add an accessor I wanted for
810         some future tooling).
811
812         * WinLauncher/WinLauncher.h:
813         (WinLauncher::webView): Added.
814
815 2014-08-16  Mark Hahnenberg  <mhahnenb@gmail.com>
816
817         Update contributors.json for my new email
818         https://bugs.webkit.org/show_bug.cgi?id=136021
819
820         Reviewed by Filip Pizlo.
821
822         * Scripts/webkitpy/common/config/contributors.json:
823
824 2014-08-15  Alexey Proskuryakov  <ap@apple.com>
825
826         REGRESSION (r172660): WebKit2.TerminateTwice asserts
827         https://bugs.webkit.org/show_bug.cgi?id=136012
828
829         * TestWebKitAPI/Tests/WebKit2/TerminateTwice.cpp: Skipped the test in debug mode.
830
831 2014-08-15  Ryuan Choi  <ryuan.choi@samsung.com>
832
833         Unreviewed build fix attempt on the CMake based pots since r172665
834
835         * TestWebKitAPI/CMakeLists.txt: Added JavaScriptCore/interpreter to the include list.
836
837 2014-08-15  Brian J. Burg  <burg@cs.washington.edu>
838
839         Web Inspector: rewrite CodeGeneratorInspector to be modular and testable
840         https://bugs.webkit.org/show_bug.cgi?id=131596
841
842         Reviewed by Joseph Pecoraro.
843
844         * Scripts/run-inspector-generator-tests: Added.
845         (main):
846         * Scripts/webkitpy/inspector/__init__.py: Added.
847         * Scripts/webkitpy/inspector/main.py: Added.
848         (InspectorGeneratorTests):
849         (InspectorGeneratorTests.__init__):
850         (InspectorGeneratorTests.generate_from_json):
851         (InspectorGeneratorTests.write_error_file):
852         (InspectorGeneratorTests.detect_changes):
853         (InspectorGeneratorTests.run_tests):
854         (InspectorGeneratorTests.main):
855
856 2014-08-15  Rebecca Hauck  <rhauck@adobe.com>
857
858         run-webkit-tests should skip 'support' directories
859         https://bugs.webkit.org/show_bug.cgi?id=135910
860
861         Reviewed by Bem Jones-Bey.
862         
863         This patch adds the 'support' directory to the list
864         of dirs to skip when looking for runnable tests.
865         the W3C uses this name for support files, so tests
866         imported from the W3C will not work without this change
867         or without many edits.
868
869         * Scripts/webkitpy/port/base.py:
870         (Port._real_tests):
871
872 2014-08-14  Brent Fulgham  <bfulgham@apple.com>
873
874         [Win] Extend auto-version and version-stamp for RC_ProjectBuildVersion
875         https://bugs.webkit.org/show_bug.cgi?id=135948
876         <rdar://problem/18022221>
877
878         Reviewed by David Kilzer.
879
880         * Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl: Add tests
881         for RC_ProjectBuildVersion.
882
883 2014-08-05  David Farler  <dfarler@apple.com>
884
885         [iOS] run-webkit-tests runs webkit-build-directory on every test
886         https://bugs.webkit.org/show_bug.cgi?id=135409
887
888         Reviewed by Daniel Bates.
889
890         * Scripts/webkitpy/port/ios.py:
891         (IOSSimulatorPort.__init__): Cache Mac build directory.
892         (IOSSimulatorPort.relay_path): Use cached build directory.
893         (IOSSimulatorPort._path_to_image_diff): Use cached build directory.
894
895 2014-08-14  Zan Dobersek  <zdobersek@igalia.com>
896
897         Initialize a separate variable (TestWTF_SOURCES) with the list of files
898         that are built into the TestWTF executable and move it above the platform-specific
899         config file inclusion. This makes it possible to add platform-specific files to that
900         list (e.g. GUniquePtr.cpp for the GTK port).
901
902         Rubber-stamped by Carlos Garcia Campos.
903
904         * TestWebKitAPI/CMakeLists.txt:
905         * TestWebKitAPI/PlatformGTK.cmake:
906
907 2014-08-13  Akos Kiss  <akiss@inf.u-szeged.hu>
908
909         [EFL] Bump up and patch dependencies to allow building for aarch64
910         https://bugs.webkit.org/show_bug.cgi?id=135885
911
912         Reviewed by Gyuyoung Kim.
913
914         The currently used versions of pixman, libffi, glib, glib-networking,
915         and fontconfig fail to configure for aarch64, so they are bumped up to
916         the latest stable version.
917
918         Gstreamer-plugins-base configures for aarch64 but incorrectly recogizes
919         ARM NEON assembly support, so it is patched with a change that has been
920         accepted by upstream.
921
922         * efl/jhbuild.modules:
923         * efl/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch: Added.
924
925 2014-08-13  Mark Rowe  <mrowe@apple.com>
926
927         <https://webkit.org/b/135911> WebKit should build on Yosemite with the public SDK.
928
929         Reviewed by Darin Adler.
930
931         * DumpRenderTree/mac/TextInputController.m: Don't use extern "C" in a non-C++ file.
932
933 2014-08-13  Alex Christensen  <achristensen@webkit.org>
934
935         Progress towards CMake on Mac.
936         https://bugs.webkit.org/show_bug.cgi?id=135819
937
938         Reviewed by Laszlo Gombos.
939
940         * WebKitTestRunner/CMakeLists.txt:
941         Added new cpp parameter for the extension of the generated files.
942
943 2014-08-13  Renato Nagy  <nagy.renato@stud.u-szeged.hu>
944
945         Make check-webkit-style run sort-export-file
946         https://bugs.webkit.org/show_bug.cgi?id=135877
947
948         Reviewed by Csaba Osztrogonác.
949
950         * Scripts/webkitpy/style/checker.py:
951         (_all_categories):
952         (FileType):
953         (CheckerDispatcher._file_type):
954         (CheckerDispatcher._create_checker):
955         * Scripts/webkitpy/style/checkers/exportfile.py: Added.
956         (ExportFileChecker):
957         (ExportFileChecker.__init__):
958         (ExportFileChecker.check):
959         * Scripts/webkitpy/style/checkers/exportfile_unittest.py: Added.
960         (handle_style_error):
961         (MockErrorHandler):
962         (MockErrorHandler.__init__):
963         (MockErrorHandler.turn_off_line_filtering):
964         (MockErrorHandler.__call__):
965         (ExportFileTest):
966         (ExportFileTest.setUp):
967         (ExportFileTest.tearDown):
968         (ExportFileTest.test_sorted):
969         (ExportFileTest.test_non_sorted):
970         (ExportFileTest.test_parse_error):
971
972 2014-08-13  Jinwoo Song  <jinwoo7.song@samsung.com>
973
974         [EFL] Sets the persistent storage for cookies in MiniBrowser
975         https://bugs.webkit.org/show_bug.cgi?id=135875
976
977         Reviewed by Gyuyoung Kim.
978
979         In case of EWK_COOKIE_ACCEPT_POLICY_ALWAYS, sets the persistent storage
980         for non-session cookies can be stored persistently.
981
982         * MiniBrowser/efl/main.c:
983         (elm_main):
984
985 2014-08-12  Daniel Bates  <dabates@apple.com>
986
987         [iOS] build-webkit should not build WebKitSystemInterface and WebKitAdditions
988         https://bugs.webkit.org/show_bug.cgi?id=135845
989
990         Reviewed by Andy Estes.
991
992         Towards building the iOS WebKit port using the public SDK, remove the logic
993         added to build-webkit to build projects WebKitSystemInterface and
994         WebKitAdditions when building the iOS WebKit port.
995
996         * Scripts/build-webkit:
997
998 2014-08-12  Yusuke Suzuki  <utatane.tea@gmail.com>
999
1000         [GTK] Adds dependency for GnuTLS 3.0+ explicitly in gtk/install-dependencies
1001         https://bugs.webkit.org/show_bug.cgi?id=135850
1002
1003         Reviewed by Philippe Normand.
1004
1005         After r172433, GTK port requires GnuTLS 3.0+. In this time, libgnutls-dev is 2.x in
1006         Ubuntu(trusty) and Debian(sid). So added libgnutls28-dev explicitly.
1007
1008         * gtk/install-dependencies:
1009
1010 2014-08-12  Eduardo Lima Mitev  <elima@igalia.com>
1011
1012         [GTK] Subtle-crypto feature off by default and add a new configure flag to enable it
1013         https://bugs.webkit.org/show_bug.cgi?id=135798
1014
1015         Reviewed by Philippe Normand.
1016
1017         * Scripts/webkitperl/FeatureList.pm: Adds new flag --subtle-crypto to
1018             toggle SUBTLE_CRYPTO feature.
1019
1020 2014-08-12  Ryuan Choi  <ryuan.choi@samsung.com>
1021
1022         [EFL] Disable ecore logs about bad fd
1023         https://bugs.webkit.org/show_bug.cgi?id=135831
1024
1025         Reviewed by Gyuyoung Kim.
1026
1027         ecore checks EBADF and prints the warnings.
1028         But, it looks noise in layout test because it's not webkit issue.
1029         This patch disables it until we found right solution.
1030
1031         * efl/jhbuild.modules:
1032         * efl/patches/ecore_remove_warnings.patch: Added.
1033
1034 2014-08-12  Shivakumar JM  <shiva.jm@samsung.com>
1035
1036         [EFL][WK2] Minibrowser: Enhance the application to use download directory selector.
1037         https://bugs.webkit.org/show_bug.cgi?id=135791
1038
1039         Reviewed by Gyuyoung Kim.
1040
1041         Currently Minibrowser stores the downloaded files to /tmp directory, add support so that destination folder can be selected by the
1042         user.
1043
1044         * MiniBrowser/efl/main.c:
1045         (on_download_request):
1046
1047 2014-08-11  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
1048
1049         [EFL] Prevent the client from creating ewk_view when EWebkit is not initialized
1050         https://bugs.webkit.org/show_bug.cgi?id=135606
1051
1052         Reviewed by Gyuyoung Kim.
1053
1054         TestWebKitAPI does not initialize EWebkit using ewk_init()
1055         which is not recommended.
1056
1057         * TestWebKitAPI/efl/PlatformWebView.cpp:
1058         (TestWebKitAPI::createEcoreEvas):
1059         Renamed from initEcoreEvas() since it doesn't not initialize
1060         ecore evas.
1061
1062         (TestWebKitAPI::PlatformWebView::PlatformWebView):
1063         Call ewk_init() that initalizes all EFL modules needed by EWebKit
1064         instead of ecore_evas_init() only.
1065
1066         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
1067         Call ewk_shutdown() to finalize EWebkit.
1068         (TestWebKitAPI::initEcoreEvas): Deleted.
1069
1070 2014-08-11  Dan Bernstein  <mitz@apple.com>
1071
1072         Added an update-webkit option to update the auxiliary libraries or not.
1073         Part of https://bugs.webkit.org/show_bug.cgi?id=135815
1074
1075         Reviewed by Tim Horton.
1076
1077         * Scripts/update-webkit: Added --[no-]auxiliary-libs option, which defaults to yes unless
1078         an Internal directory exists alongside the WebKit root directory.
1079
1080 2014-08-11  Bem Jones-Bey  <bjonesbe@adobe.com>
1081
1082         Remove hg changeset from w3c-import.log
1083         https://bugs.webkit.org/show_bug.cgi?id=135735
1084
1085         Reviewed by Ryosuke Niwa.
1086
1087         Since the csswg's test suite is now accessible via github and it is
1088         possible to push changes by creating github pull requests, the hg
1089         changeset makes less sense, as many people will just use a clone of
1090         the git repo. There isn't an obvious thing to replace it with, so
1091         might as well remove it for now instead of having it just be set to
1092         UNKNOWN in imports.
1093
1094         This also adds a pointer to the github repo in the generated comments
1095         in the w3c-import.log.
1096
1097         * Scripts/webkitpy/w3c/test_importer.py:
1098         (TestImporter.__init__): Remove changeset handling.
1099         (TestImporter.do_import): Ditto.
1100         (TestImporter.write_import_log): Ditto.
1101         (TestImporter.load_changeset): Deleted.
1102
1103 2014-08-11  Carlos Garcia Campos  <cgarcia@igalia.com>
1104
1105         Unreviewed. Fix GTK+ make distcheck.
1106
1107         * gtk/manifest.txt: Remove Source/WebCore/Resources/inputSpeech.png.
1108
1109 2014-08-08  Simon Fraser  <simon.fraser@apple.com>
1110
1111         Unbreak webkitpy unit tests by checking for the existence of the image diff template
1112         file before trying to open it (as the tests do for results.html).
1113
1114         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1115         (TestResultWriter.write_image_diff_files):
1116
1117 2014-08-08  Simon Fraser  <simon.fraser@apple.com>
1118
1119         Load the layout test result image diff HTML from a file, rather than having it inline in webkitpy
1120         https://bugs.webkit.org/show_bug.cgi?id=135780
1121
1122         Reviewed by Dan Bates.
1123         
1124         Pull the HTML for the image diff file into a separate file, for easier hackability.
1125
1126         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1127         (TestResultWriter.write_image_diff_files):
1128
1129 2014-08-08  Mark Lam  <mark.lam@apple.com>
1130
1131         Gardening: fix Windows build after r172259.
1132
1133         Not reviewed.
1134
1135         * DumpRenderTree/win/TestRunnerWin.cpp:
1136         (TestRunner::addMockSpeechInputResult): Deleted.
1137         (TestRunner::setMockSpeechInputDumpRect): Deleted.
1138         (TestRunner::startSpeechInput): Deleted.
1139
1140 2014-08-08  Joseph Pecoraro  <pecoraro@apple.com>
1141
1142         make clean does not work in OpenSource, fails in WebKitLibraries
1143         https://bugs.webkit.org/show_bug.cgi?id=135734
1144
1145         Reviewed by David Kilzer.
1146
1147         * Scripts/copy-webkitlibraries-to-product-directory:
1148         Add a --clean switch that removes possible WebKitSystemInterface
1149         and LLVM libraries and headers that may have been copied to the
1150         product directory.
1151
1152 2014-08-08  Joseph Pecoraro  <pecoraro@apple.com>
1153
1154         commit-log-message has extra blank line at the top of pre-populated message
1155         https://bugs.webkit.org/show_bug.cgi?id=135744
1156
1157         Reviewed by Csaba Osztrogonác.
1158
1159         Do not add a blank leading line in single ChangeLog commit messages.
1160
1161         * Scripts/commit-log-editor:
1162         (createCommitMessage):
1163         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1164         (test_commit_message_for_one_reviewed_changelog):
1165         (test_commit_message_for_one_rollout_changelog):
1166
1167 2014-08-07  Brent Fulgham  <bfulgham@apple.com>
1168
1169         [Win] Unreviewed gardening.
1170
1171         Have 'Assemble Build Logs' step work properly for DebugSuffix target
1172         (both 32-bit and 64-bit).
1173
1174         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj:
1175
1176 2014-08-07  Benjamin Poulain  <bpoulain@apple.com>
1177
1178         Get rid of INPUT_SPEECH
1179         https://bugs.webkit.org/show_bug.cgi?id=135672
1180
1181         Reviewed by Andreas Kling.
1182
1183         * DumpRenderTree/TestRunner.cpp:
1184         (TestRunner::staticFunctions):
1185         (addMockSpeechInputResultCallback): Deleted.
1186         (setMockSpeechInputDumpRectCallback): Deleted.
1187         * DumpRenderTree/TestRunner.h:
1188         * DumpRenderTree/mac/TestRunnerMac.mm:
1189         (TestRunner::addMockSpeechInputResult): Deleted.
1190         (TestRunner::setMockSpeechInputDumpRect): Deleted.
1191         (TestRunner::startSpeechInput): Deleted.
1192
1193 2014-08-07  Bem Jones-Bey  <bjonesbe@adobe.com>
1194
1195         The support directory shouldn't be skipped unconditionally in test import
1196         https://bugs.webkit.org/show_bug.cgi?id=135660
1197
1198         Reviewed by Ryosuke Niwa.
1199
1200         The 'DIRS_TO_SKIP' should only be skipped when in the root directory
1201         of the test repo, as that's the only time they are special. In
1202         addition, instead of hardcoding .hg and .git as special, skip all
1203         directories that begin with '.', just like with files that begin with '.'.
1204         
1205         In order to make this work, the root directory must always be
1206         passed in, so the interface to the script has been changed to take the
1207         root directory, and if one wants to only import a subset of the tests,
1208         a new -t option can be used to limit the tests imported.
1209
1210         * Scripts/webkitpy/w3c/test_importer.py:
1211         (main): Remove repo_dir command line argument.
1212         (parse_args): Add -t option and set expected non-option args to 1.
1213         (TestImporter.__init__): Remove repo_dir.
1214         (TestImporter.do_import): Handle the varying number of import
1215             directories.
1216         (TestImporter.should_keep_subdir): Helper for find_importable_tests to
1217             determine if a subdirectory should be skipped.
1218         (TestImporter.find_importable_tests): Filter directories using new
1219             helper.
1220         (TestImporter.import_tests): Remove use of repo_dir.
1221         (TestImporter.setup_destination_directory): Unused, Deleted. 
1222         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1223         (TestImporterTest.test_import_dir_with_no_tests_and_no_hg): Update for
1224             new API.
1225         (TestImporterTest.test_import_dir_with_no_tests): Ditto.
1226
1227 2014-08-07  Carlos Garcia Campos  <cgarcia@igalia.com>
1228
1229         [GTK] Use WebKitNavigationAction also for WebKitNavigationPolicyDecision
1230         https://bugs.webkit.org/show_bug.cgi?id=135695
1231
1232         Reviewed by Gustavo Noronha Silva.
1233
1234         Use WebKitNavigationAction API.
1235
1236         * MiniBrowser/gtk/BrowserWindow.c:
1237         (webViewDecidePolicy):
1238         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitPolicyClient.cpp:
1239         (testNavigationPolicy):
1240
1241 2014-08-07  Carlos Garcia Campos  <cgarcia@igalia.com>
1242
1243         [GTK] Test /webkit2/WebKitUserContentManager/injected-script fails
1244         https://bugs.webkit.org/show_bug.cgi?id=135696
1245
1246         Reviewed by Sergio Villar Senin.
1247
1248         Don't assume the JavaScript result is always a valid pointer. In case of JavaScript
1249         exception (that happens when testing the script hasn't been injected) the JavaScript
1250         result is NULL.
1251
1252         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
1253         (isScriptInjectedForURLAtPath):
1254
1255 2014-08-07  Csaba Osztrogonác  <ossy@webkit.org>
1256
1257         [GTK] Disable IndexedDB
1258         https://bugs.webkit.org/show_bug.cgi?id=135692
1259
1260         Reviewed by Carlos Garcia Campos.
1261
1262         * Scripts/webkitperl/FeatureList.pm:
1263
1264 2014-08-06  Dean Jackson  <dino@apple.com>
1265
1266         ENABLE_CSS_TRANSFORMS_ANIMATIONS_UNPREFIXED is not used anywhere. Remove it.
1267         https://bugs.webkit.org/show_bug.cgi?id=135675
1268
1269         Reviewed by Sam Weinig.
1270
1271         * Scripts/webkitperl/FeatureList.pm:
1272
1273 2014-08-06  David Farler  <dfarler@apple.com>
1274
1275         Set DSYMUTIL_NUM_THREADS to the number of logical cores
1276         https://bugs.webkit.org/show_bug.cgi?id=135655
1277
1278         Reviewed by Mark Rowe.
1279
1280         * Scripts/webkitdirs.pm:
1281         (buildXCodeProject): Set before calling xcodebuild.
1282
1283 2014-08-06  Adrian Perez de Castro  <aperez@igalia.com>
1284
1285         [GTK] Add support for user scripts to WebKitUserContentManager
1286         https://bugs.webkit.org/show_bug.cgi?id=134738
1287
1288         Reviewed by Carlos Garcia Campos.
1289
1290         Add support for user scripts, to complement the user style sheet
1291         support already present in WebKitUserContentManager. Most of the
1292         moving parts are already present, so this just adds a boxed type
1293         for user scripts (WebKitUserScript) and the corresponding methods
1294         to add and remove scripts from the WebKitUserContentManager.
1295
1296         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
1297         Add test case for injected user scripts.
1298         (isScriptInjectedForURLAtPath):
1299         (removeOldInjectedContentAndResetLists):
1300         (testUserContentManagerInjectedStyleSheet):
1301         (testUserContentManagerInjectedScript):
1302         (beforeAll):
1303         (removeOldInjectedStyleSheetsAndResetLists): Deleted.
1304
1305 2014-08-06  Philippe Normand  <pnormand@igalia.com>
1306
1307         [GTK] run-launcher --gtk still fails
1308         https://bugs.webkit.org/show_bug.cgi?id=135642
1309
1310         Reviewed by Carlos Garcia Campos.
1311
1312         The perl interpreter is confused by the combination of string
1313         concatenation and a ternary in the same line. Using a separate
1314         variable to determine the library file extension fixes this issue.
1315
1316         * Scripts/webkitdirs.pm:
1317         (builtDylibPathForName): Use an intermediate variable, it's more
1318         readable and unambiguous.
1319
1320 2014-07-29  Filip Pizlo  <fpizlo@apple.com>
1321
1322         Merge r170564, r170571, r170604, r170628, r170672, r170680, r170724, r170728, r170729, r170819, r170821, r170836, r170855, r170860, r170890, r170907, r170929, r171052, r171106, r171152, r171153, r171214 from ftlopt.
1323
1324     2014-06-25  Filip Pizlo  <fpizlo@apple.com>
1325     
1326             [ftlopt] If a CodeBlock is jettisoned due to a watchpoint then it should be possible to figure out something about that watchpoint
1327             https://bugs.webkit.org/show_bug.cgi?id=134333
1328     
1329             Reviewed by Geoffrey Garen.
1330     
1331             * Scripts/display-profiler-output:
1332     
1333 2014-08-05  David Farler  <dfarler@apple.com>
1334
1335         [iOS] Run ImageDiff in the sim bootstrap
1336         https://bugs.webkit.org/show_bug.cgi?id=135624
1337
1338         Reviewed by David Kilzer.
1339
1340         * Scripts/webkitpy/port/image_diff.py:
1341         (ImageDiffer.stop):
1342         (IOSSimulatorImageDiffer):
1343         (IOSSimulatorImageDiffer._start):
1344         * Scripts/webkitpy/port/ios.py:
1345         (IOSSimulatorPort.diff_image):
1346
1347 2014-08-05  David Farler  <dfarler@apple.com>
1348
1349         [iOS] run-webkit-tests: defaults for --runtime and --device-type flags
1350         https://bugs.webkit.org/show_bug.cgi?id=135441
1351
1352         Reviewed by Tim Horton.
1353
1354         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1355         (parse_args):
1356         (_set_up_derived_options):
1357         If using the ios-simulator platform and runtime or device-type
1358         aren't defined, get the latest runtime from the active Xcode.app
1359         and pick a default device type based on the desired architecture:
1360         iPhone 5 for i386 and iPhone 5s for x86_64.
1361         * Scripts/webkitpy/xcode/__init__.py: Added.
1362         * Scripts/webkitpy/xcode/simulator.py: Added.
1363
1364 2014-08-05  David Farler  <dfarler@apple.com>
1365
1366         [iOS] simctl can hang if run quickly after shutting down CoreSimulator services
1367         https://bugs.webkit.org/show_bug.cgi?id=135626
1368
1369         Reviewed by Dan Bernstein.
1370
1371         * Scripts/webkitpy/port/ios.py:
1372         (IOSSimulatorPort.setup_test_run):
1373         Remove call to simctl shutdown <device> - telling the simulator app to quit
1374         will shut down all booted devices.
1375
1376 2014-08-05  Alexey Proskuryakov  <ap@apple.com>
1377
1378         Remove an unused argument from BuildbotQueue.update()
1379         https://bugs.webkit.org/show_bug.cgi?id=135623
1380
1381         Reviewed by Timothy Hatcher.
1382
1383         Also remaned a constant to better match what it means.
1384
1385         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1386
1387 2014-08-05  Vivek Galatage  <vivek.vg@samsung.com>
1388
1389         [gtk] Include llvm-dev(el) package to satisfy mesa build configuration
1390         https://bugs.webkit.org/show_bug.cgi?id=135555
1391
1392         Reviewed by Philippe Normand.
1393
1394         Initial setup of gtk on linux requires this package to be installed.
1395         This is required during the build configuration of mesa through jhbuild.
1396
1397         * gtk/install-dependencies:
1398
1399 2014-08-05  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1400
1401         Fix the commit-log-editor after r167243 and add more unit tests
1402         https://bugs.webkit.org/show_bug.cgi?id=131727
1403
1404         Reviewed by Csaba Osztrogonác.
1405
1406         * Scripts/commit-log-editor:
1407         (createCommitMessage):
1408         (removeLongestCommonPrefixEndingInNewline):
1409         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1410         (CommitMessageForThisCommitTest):
1411         (CommitMessageForThisCommitTest.mock_changelog):
1412         (CommitMessageForThisCommitTest.mock_checkout_for_test):
1413         (CommitMessageForThisCommitTest.test_commit_message_for_unreviewed_changelogs_with_different_messages):
1414         (test_commit_message_for_one_reviewed_changelog):
1415         (test_commit_message_for_changelogs_with_same_messages):
1416         (test_commit_message_for_changelogs_with_different_messages):
1417         (test_commit_message_for_one_rollout_changelog):
1418         (test_commit_message_for_rollout_changelogs_with_different_directories):
1419         (setUp): Deleted.
1420         (test_commit_message_for_this_commit): Deleted.
1421
1422 2014-08-04  Michael Catanzaro  <mcatanzaro@igalia.com>
1423
1424         [GTK] run-launcher --gtk is broken
1425         https://bugs.webkit.org/show_bug.cgi?id=135571
1426
1427         Reviewed by Martin Robinson.
1428
1429         * Scripts/webkitdirs.pm:
1430         (builtDylibPathForName): Search for libwebkit2gtk-4.0
1431
1432 2014-08-04  Matt Baker  <mattbaker@apple.com>
1433
1434         lldb_webkit.py throws exception when generating summary of null StringImpl
1435         https://bugs.webkit.org/show_bug.cgi?id=129448
1436
1437         Reviewed by Jer Noble.
1438
1439         Added checks for null StringImpl and 0 byte ReadMemory calls.
1440
1441         * lldb/lldb_webkit.py:
1442         (WTFStringImpl_SummaryProvider):
1443         (ustring_to_string):
1444         (lstring_to_string):
1445         (WTFStringImplProvider.to_string):
1446         (WTFStringImplProvider.is_initialized):
1447
1448 2014-08-03  Carlos Garcia Campos  <cgarcia@igalia.com>
1449
1450         [GTK] Do not include JavaScriptCore stress tests in release tarballs
1451         https://bugs.webkit.org/show_bug.cgi?id=135503
1452
1453         Reviewed by Martin Robinson.
1454
1455         * gtk/manifest.txt: Exclude Source/JavaScriptCore/tests dir.
1456
1457 2014-07-30  David Farler  <dfarler@apple.com>
1458
1459         build-webkittestrunner doesn't build the app target for iOS SDKs
1460         https://bugs.webkit.org/show_bug.cgi?id=135433
1461
1462         Reviewed by Dan Bernstein.
1463
1464         * Scripts/build-dumprendertree: Build the app target on iOS.
1465         * Scripts/build-webkittestrunner: Build the app target on iOS.
1466         * Scripts/webkitdirs.pm: Add -sdk flags when building for iOS.
1467         (buildXCodeProject):
1468         * Scripts/webkitpy/port/ios.py: Use --sdk flags instead of SDKROOT.
1469         (IOSSimulatorPort._build_driver_flags):
1470
1471 2014-07-30  David Farler  <dfarler@apple.com>
1472
1473         Remove iOS Perl DumpRenderTree support target
1474         https://bugs.webkit.org/show_bug.cgi?id=135271
1475
1476         Reviewed by Dan Bernstein.
1477
1478         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Remove the target.
1479         * DumpRenderTree/ios/PerlSupport/DumpRenderTreeSupport.c: Removed.
1480         * DumpRenderTree/ios/PerlSupport/DumpRenderTreeSupportPregenerated.pm: Removed.
1481         * DumpRenderTree/ios/PerlSupport/DumpRenderTreeSupport_wrapPregenerated.c: Removed.
1482         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/Changes: Removed.
1483         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/IPhoneSimulatorNotification.xs: Removed.
1484         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/MANIFEST: Removed.
1485         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/Makefile.PL: Removed.
1486         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/README: Removed.
1487         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/lib/IPhoneSimulatorNotification.pm: Removed.
1488         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/ppport.h: Removed.
1489         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/t/IPhoneSimulatorNotification.t: Removed.
1490         * DumpRenderTree/ios/PerlSupport/Makefile: Removed.
1491
1492 2014-07-30  David Farler  <dfarler@apple.com>
1493
1494         Remove old-run-webkit-tests
1495         https://bugs.webkit.org/show_bug.cgi?id=135374
1496
1497         Reviewed by Csaba Osztrogonác.
1498
1499         * Scripts/old-run-webkit-tests: Removed.
1500
1501 2014-08-02  Dan Bernstein  <mitz@apple.com>
1502
1503         prepare-ChangeLog --no-write shouldn’t require ChangeLog to exist
1504         https://bugs.webkit.org/show_bug.cgi?id=135542
1505
1506         Reviewed by Tim Horton.
1507
1508         * Scripts/prepare-ChangeLog:
1509         (main): Pass $writeChangeLogs for the new requireChangeLogToExist parameter of
1510         findChangeLogs.
1511         (findChangeLogs): Don’t require a ChangeLog file to exist if unless the
1512         requireChangeLogToExist argument is true.
1513
1514 2014-08-01  Dan Bernstein  <mitz@apple.com>
1515
1516         commit-log-editor uses a non-standard message format when git index contains no ChangeLog changes
1517         https://bugs.webkit.org/show_bug.cgi?id=135527
1518
1519         Reviewed by Tim Horton.
1520
1521         * Scripts/commit-log-editor:
1522         In the case of a git repository when there are no changed ChangeLog files, changed to pass
1523         the --delimiters option to prepare-ChangeLog, then process each entry in the output using
1524         commitMessageFromChangeLogEntry.
1525         (commitMessageFromChangeLogEntry): Factored out from createCommitMessage.
1526         (sortKey): Factored out from createCommitMessage.
1527         (createCommitMessage): Changed to use new sortKey and commitMessageFromChangeLogEntry
1528         subroutines.
1529
1530         * Scripts/prepare-ChangeLog:
1531         (main): Parse new --delimiters option.
1532         (generateNewChangeLogs): When --no-write and --delimiters are both specified, always print
1533         the label before each change log entry, and a "~" delimiter on a new line after each entry.
1534
1535 2014-08-01  Bear Travis  <betravis@adobe.com>
1536
1537         [Feature Queries] Enable Feature Queries on EFL/GTK
1538         https://bugs.webkit.org/show_bug.cgi?id=134902
1539
1540         Reviewed by Benjamin Poulain.
1541
1542         Turn the feature on by default for the build script.
1543
1544         * Scripts/webkitperl/FeatureList.pm:
1545
1546 2014-08-01  Timothy Horton  <timothy_horton@apple.com>
1547
1548         Build fix for 32-bit after r171926.
1549
1550         * MiniBrowser/mac/SettingsController.h:
1551         * MiniBrowser/mac/SettingsController.m:
1552
1553 2014-08-01  Tim Horton  <timothy_horton@apple.com>
1554
1555         Confusing build fix after r171926.
1556
1557         * MiniBrowser/mac/AppDelegate.h:
1558         * MiniBrowser/mac/AppDelegate.m:
1559         * MiniBrowser/mac/SettingsController.m:
1560
1561 2014-08-01  Tim Horton  <timothy_horton@apple.com>
1562
1563         Make it easer to add switches to MiniBrowser
1564         https://bugs.webkit.org/show_bug.cgi?id=135499
1565
1566         Reviewed by Simon Fraser.
1567
1568         Add a single class to manage a set of persistent, global settings for MiniBrowser.
1569         Add a new menu that contains items to toggle the aforementioned settings (moving them out of the Debug menu).
1570
1571         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
1572         Add SettingsController.{m, h}.
1573
1574         * MiniBrowser/mac/AppDelegate.h:
1575         Move _browserWindowControllers to the implementation.
1576         Get rid of toggleUseWebKit2ByDefault, because SettingsController now takes care
1577         of that; instead, we'll receive didChangeSettings.
1578
1579         * MiniBrowser/mac/AppDelegate.m:
1580         Move the default URL, default URL preference key, and use-WebKit2-by-default
1581         preference key into SettingsController.
1582
1583         (-[BrowserAppDelegate awakeFromNib]):
1584         Add the dynamically-generated SettingsController menu just to the left of the Debug menu.
1585
1586         (-[BrowserAppDelegate newWindow:]):
1587         Ask SettingsController if we should use WebKit2 by default, and what the initial URL to load is.
1588
1589         (-[BrowserAppDelegate applicationDidFinishLaunching:]):
1590         SettingsController now takes care of reading the default URL preference.
1591         WK1BrowserWindowController now takes care of enabling the developer extras, via WebPreferences.
1592
1593         (-[BrowserAppDelegate didChangeSettings]):
1594         When settings change, update the key equivalents for the new-window menu items, as they
1595         might have changed (as use-WebKit2-by-default is one of the settings).
1596
1597         Dispatch settings change notifications to all live BrowserControllers.
1598
1599         (-[BrowserAppDelegate _updateNewWindowKeyEquivalents]):
1600         (-[BrowserAppDelegate toggleUseWebKit2ByDefault:]): Deleted.
1601         (-[BrowserAppDelegate _useWebKit2ByDefault]): Deleted.
1602         (-[BrowserAppDelegate validateMenuItem:]): Deleted.
1603         All menu item validation for settings is moved into SettingsController.
1604
1605         * MiniBrowser/mac/BrowserWindowController.h:
1606         Simplify the BrowserWindowController interface; "toggling" settings will happen inside SettingsController,
1607         the BrowserWindowController subclasses will be able to a) know when any setting changes, b) query the current setting state.
1608
1609         * MiniBrowser/mac/MainMenu.xib:
1610         Remove the settings menu items from the "Debug" menu.
1611
1612         * MiniBrowser/mac/SettingsController.h: Added.
1613         * MiniBrowser/mac/SettingsController.m: Added.
1614         (+[SettingsController shared]):
1615         (-[SettingsController menu]):
1616
1617         (-[SettingsController _addItemWithTitle:action:indented:]):
1618         (-[SettingsController _addHeaderWithTitle:]):
1619         NSMenuItem-creating helpers.
1620
1621         (-[SettingsController _populateMenu]):
1622         Build the menu. Ideally this and the validation step would eventually be made more dynamic.
1623
1624         (-[SettingsController validateMenuItem:]):
1625         Validate menu items; since they can be used to toggle the default state of a setting,
1626         we'll always return YES. However, we will use this opportunity to set the 'checked' state
1627         of each item.
1628
1629
1630         (-[SettingsController _toggleBooleanDefault:]):
1631         Toggle the given boolean default, and notify BrowserAppDelegate that something changed.
1632
1633         (-[SettingsController toggleUseWebKit2ByDefault:]):
1634         (-[SettingsController useWebKit2ByDefault]):
1635         (-[SettingsController toggleUseTransparentWindows:]):
1636         (-[SettingsController useTransparentWindows]):
1637         (-[SettingsController toggleUsePaginatedMode:]):
1638         (-[SettingsController usePaginatedMode]):
1639         (-[SettingsController toggleUseUISideCompositing:]):
1640         (-[SettingsController useUISideCompositing]):
1641         (-[SettingsController toggleShowLayerBorders:]):
1642         (-[SettingsController layerBordersVisible]):
1643         (-[SettingsController toggleShowTiledScrollingIndicator:]):
1644         (-[SettingsController tiledScrollingIndicatorVisible]):
1645         (-[SettingsController toggleEnableSubPixelCSSOMMetrics:]):
1646         (-[SettingsController subPixelCSSOMMetricsEnabled]):
1647         (-[SettingsController defaultURL]):
1648         Toggle or return the current state of each preference.
1649
1650         * MiniBrowser/mac/WK1BrowserWindowController.m:
1651         (-[WK1BrowserWindowController awakeFromNib]):
1652         (-[WK1BrowserWindowController validateMenuItem:]):
1653         (-[WK1BrowserWindowController windowWillClose:]):
1654         (-[WK1BrowserWindowController find:]):
1655         (-[WK1BrowserWindowController dumpSourceToConsole:]):
1656         (-[WK1BrowserWindowController didChangeSettings]):
1657         (-[WK1BrowserWindowController webView:didReceiveTitle:forFrame:]):
1658         (-[WK1BrowserWindowController isPaginated]): Deleted.
1659         (-[WK1BrowserWindowController togglePaginationMode:]): Deleted.
1660         (-[WK1BrowserWindowController toggleTransparentWindow:]): Deleted.
1661         (-[WK1BrowserWindowController isSubpixelCSSOMElementMetricsEnabled]): Deleted.
1662         (-[WK1BrowserWindowController toggleSubpixelCSSOMElementMetricsEnabled:]): Deleted.
1663         (-[WK1BrowserWindowController layerBordersVisible]): Deleted.
1664         (-[WK1BrowserWindowController toggleLayerBordersVisibility:]): Deleted.
1665         * MiniBrowser/mac/WK2BrowserWindowController.m:
1666         (-[WK2BrowserWindowController awakeFromNib]):
1667         (-[WK2BrowserWindowController validateMenuItem:]):
1668         (-[WK2BrowserWindowController forceRepaint:]):
1669         (-[WK2BrowserWindowController windowWillClose:]):
1670         (-[WK2BrowserWindowController didChangeSettings]):
1671         (-[WK2BrowserWindowController isPaginated]): Deleted.
1672         (-[WK2BrowserWindowController togglePaginationMode:]): Deleted.
1673         (-[WK2BrowserWindowController toggleTransparentWindow:]): Deleted.
1674         (-[WK2BrowserWindowController isUISideCompositingEnabled]): Deleted.
1675         (-[WK2BrowserWindowController toggleUISideCompositing:]): Deleted.
1676         (-[WK2BrowserWindowController layerBordersVisible]): Deleted.
1677         (-[WK2BrowserWindowController toggleLayerBordersVisibility:]): Deleted.
1678         (-[WK2BrowserWindowController tiledScrollingIndicatorVisible]): Deleted.
1679         (-[WK2BrowserWindowController toggleTiledScrollingIndicatorVisibility:]): Deleted.
1680
1681 2014-08-01  Tim Horton  <timothy_horton@apple.com>
1682
1683         MiniBrowser doesn't support data URLs
1684         https://bugs.webkit.org/show_bug.cgi?id=135492
1685
1686         Reviewed by Simon Fraser.
1687
1688         * MiniBrowser/mac/BrowserWindowController.m:
1689         (-[BrowserWindowController addProtocolIfNecessary:]):
1690         Don't add http:// to data: URLs.
1691
1692         * MiniBrowser/mac/WK2BrowserWindowController.m:
1693         (-[WK2BrowserWindowController fetch:]):
1694         (-[WK2BrowserWindowController updateTextFieldFromURL:]):
1695         Percent-escape the contents of the address field before trying to make a URL.
1696         Percent-unescape the URL when displaying it in the address field.
1697         This is not great, but trivial and good-enough-for-Minibrowser.
1698
1699 2014-07-31  Ryuan Choi  <ryuan.choi@samsung.com>
1700
1701         [EFL][WK2] MiniBrower comes to crash when combo box is pressed
1702         https://bugs.webkit.org/show_bug.cgi?id=135378
1703
1704         Reviewed by Gyuyoung Kim.
1705
1706         "clicked" signal of elm_menu is emitted after EwkView calls popup_menu_hide
1707         and removes Ewk_Popup_Menu instance.
1708
1709         * MiniBrowser/efl/main.c:
1710         (on_popup_menu_show):
1711         (on_popup_menu_discarded): Deleted.
1712
1713 2014-07-31  Brent Fulgham  <bfulgham@apple.com>
1714
1715         [Win] Use RC_PROJECTBUILDVERSION as build portion of version
1716         https://bugs.webkit.org/show_bug.cgi?id=135478
1717
1718         Reviewed by David Kilzer.
1719
1720         Add new test suite for the version-stamp program.
1721
1722         * Scripts/webkitperl/auto-version_unittest/versionStampTests.pl: Added.
1723
1724 2014-07-31  Dan Bernstein  <mitz@apple.com>
1725
1726         Reverted r171893, because it broke http/tests/appcache/different-https-origin-resource-main.html,
1727         which loads HTTPS content without calling the delegate.
1728
1729         Rubber-stamped by Alexey Proskuryakov.
1730
1731         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
1732         (WTR::InjectedBundle::platformInitialize):
1733         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
1734         (WTR::InjectedBundle::platformInitialize):
1735
1736 2014-07-31  Brent Fulgham  <bfulgham@apple.com>
1737
1738         Unreviewed typo correction (and build fix).
1739
1740         * MiniBrowser/mac/WK2BrowserWindowController.m:
1741         (-[WK2BrowserWindowController awakeFromNib]): Use correct
1742         property name (_fullScreenIsEnabled -> _fullScreenEnabled)
1743
1744 2014-07-31  Brent Fulgham  <bfulgham@apple.com>
1745
1746         MiniBrowser Should Support Fullscreen Videos in WebKit2 Mode
1747         https://bugs.webkit.org/show_bug.cgi?id=135482
1748
1749         Reviewed by Simon Fraser.
1750
1751         * MiniBrowser/mac/WK2BrowserWindowController.m:
1752         (-[WK2BrowserWindowController awakeFromNib]): Activate the Fullscreen
1753         feature.
1754
1755 2014-07-31  Alexey Proskuryakov  <ap@apple.com>
1756
1757         [Mac, iOS] Remove -setAllowsAnyHTTPSCertificate calls
1758         https://bugs.webkit.org/show_bug.cgi?id=135472
1759
1760         Reviewed by Dan Bernstein.
1761
1762         We now handle server trust challenges, and don't need such hacks.
1763
1764         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
1765         (WTR::InjectedBundle::platformInitialize):
1766         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
1767         (WTR::InjectedBundle::platformInitialize):
1768
1769 2014-07-31  Alexey Proskuryakov  <ap@apple.com>
1770
1771         media/track/add-and-remove-track.html and media/media-fragments/TC0001.html are flaky
1772         on Mac WK2 EWS, asserting under TestRunner::removeAllWebNotificationPermissions
1773         https://bugs.webkit.org/show_bug.cgi?id=135418
1774
1775         Reviewed by Anders Carlsson.
1776
1777         This was only happening in shared web process mode, because WKBundlePostMessage
1778         has different behavior then. When there is no process, the message is dropped on
1779         the floor in multiple process mode, but it's stored to be delivered after launch
1780         in shared process mode.
1781
1782         So, calling resetStateToConsistentValues() resulted in storing a Reset bundle message
1783         that was delivered immediately after launch, when there was nothing to reset.
1784
1785         We don't actually need to reset anything at this point, as the previous call has
1786         already reset everything UI process side, and web process is brand new. All we need
1787         is to reattach the page to a process, as invoke() expects one to exist.
1788
1789         * WebKitTestRunner/TestController.cpp: (WTR::TestController::reattachPageToWebProcess):
1790         * WebKitTestRunner/TestController.h:
1791         * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::invoke):
1792
1793 2014-07-31  Dan Bernstein  <mitz@apple.com>
1794
1795         [WK2] Regression tests can't load HTTPS pages with NetworkProcess due to self-signed certificate
1796         https://bugs.webkit.org/show_bug.cgi?id=115282
1797
1798         Reviewed by Sam Weinig.
1799
1800         * WebKitTestRunner/TestController.cpp:
1801         (WTR::TestController::canAuthenticateAgainstProtectionSpaceInFrame): Return true for any
1802         local host server trust protection space.
1803         (WTR::TestController::didReceiveAuthenticationChallengeInFrame): Respond with a non-empty
1804         credential to server trust challenges.
1805
1806 2014-07-31  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
1807
1808         [webkitpy] Make diff_text generate correct diff if there is no newline at the end of file
1809         https://bugs.webkit.org/show_bug.cgi?id=135381
1810
1811         Reviewed by Csaba Osztrogonác.
1812
1813         * Scripts/webkitpy/port/base.py:
1814         (Port.diff_text):
1815         * Scripts/webkitpy/port/base_unittest.py:
1816         (PortTest.test_diff_text):
1817
1818 2014-07-31  Carlos Garcia Campos  <cgarcia@igalia.com>
1819
1820         Unreviewed. Fix GTK+ make distcheck.
1821
1822         * gtk/make-dist.py:
1823         (ensure_version_if_possible): Use 4.0 instead of 3.0 as binary
1824         version to find the pkg-config file.
1825         * gtk/manifest.txt: Add missing resource to the tarball.
1826
1827 2014-07-31  Carlos Garcia Campos  <cgarcia@igalia.com>
1828
1829         [GTK] make distcheck is building from sources dir instead of dist dir
1830         https://bugs.webkit.org/show_bug.cgi?id=135457
1831
1832         Reviewed by Philippe Normand.
1833
1834         * gtk/make-dist.py:
1835         (Distcheck.configure): Use dist_dir as source dir.
1836         (Distcheck.check): Pass dist_dir to configure().
1837
1838 2014-07-31  Carlos Garcia Campos  <cgarcia@igalia.com>
1839
1840         [GTK] Do not include files that are not in git in the tarball
1841         https://bugs.webkit.org/show_bug.cgi?id=134804
1842
1843         Reviewed by Philippe Normand.
1844
1845         Skip all files in the source tree that are not under version control
1846         except for files added from the build dir like the documentation.
1847
1848         * gtk/make-dist.py:
1849         (Directory.__init__): Initialize the list of files under control version.
1850         (Directory.list_cms_files): Helper function to list all files
1851         under the control version for the current source root.
1852         (Directory.should_skip_file): Return True for files that are not
1853         under control version only when the source root is also under
1854         control version.
1855         (Directory.get_files): Filter the files also using should_skip_file().
1856
1857 2014-07-29  David Farler  <dfarler@apple.com>
1858
1859         iOS Simulator LayoutTestRelay
1860         https://bugs.webkit.org/show_bug.cgi?id=135269
1861
1862         Reviewed by David Kilzer.
1863
1864         * LayoutTestRelay/Configurations/Base.xcconfig: Added.
1865         * LayoutTestRelay/Configurations/DebugRelease.xcconfig: Added.
1866         * LayoutTestRelay/LayoutTestRelay.xcodeproj/project.pbxproj: Added.
1867         * LayoutTestRelay/LayoutTestRelay/LTPipeRelay.h: Added.
1868         * LayoutTestRelay/LayoutTestRelay/LTPipeRelay.m: Added.
1869         (-[LTPipeRelay inPipePath]):
1870         (-[LTPipeRelay outPipePath]):
1871         (-[LTPipeRelay errorPipePath]):
1872         (-[LTPipeRelay outputStream]):
1873         (-[LTPipeRelay initWithPrefix:]):
1874         (-[LTPipeRelay setup]):
1875         (-[LTPipeRelay tearDown]):
1876         (-[LTPipeRelay connect]):
1877         (-[LTPipeRelay disconnect]):
1878         (-[LTPipeRelay createFIFOs]):
1879         (-[LTPipeRelay destroyFIFOs]):
1880         (-[LTPipeRelay relayStream:]):
1881         (-[LTPipeRelay stream:handleEvent:]):
1882         * LayoutTestRelay/LayoutTestRelay/LTRelay.h: Added.
1883         * LayoutTestRelay/LayoutTestRelay/LTRelayController.h: Added.
1884         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m: Added.
1885         (-[LTRelayController uniqueAppPath]):
1886         (-[LTRelayController uniqueAppURL]):
1887         (-[LTRelayController uniqueAppIdentifier]):
1888         (-[LTRelayController processName]):
1889         (-[LTRelayController initWithDevice:productDir:appPath:identifierSuffix:dumpToolArguments:]):
1890         (-[LTRelayController readFileHandle:]):
1891         (-[LTRelayController receivedStandardOutputData:]):
1892         (-[LTRelayController receivedStandardErrorData:]):
1893         (-[LTRelayController disconnected]):
1894         (-[LTRelayController connected]):
1895         (-[LTRelayController crashWithMessage:]):
1896         (-[LTRelayController launchSimulator]):
1897         (-[LTRelayController bootDevice]):
1898         (-[LTRelayController createUniqueApp]):
1899         (-[LTRelayController killApp]):
1900         (-[LTRelayController launchApp]):
1901         (-[LTRelayController start]):
1902         * LayoutTestRelay/LayoutTestRelay/main.m: Added.
1903         (usage):
1904         (getTestingSimDevice):
1905         (getRequiredStringArgument):
1906         (getRemainderArguments):
1907         (main):
1908         * LayoutTestRelay/Makefile: Added.
1909         * Tools/Scripts/build-layouttestrelay: Added.
1910
1911 2014-07-29  Brent Fulgham  <bfulgham@apple.com>
1912
1913         [Win] Modify version numbering scheme to support 5-tuple versions
1914         https://bugs.webkit.org/show_bug.cgi?id=135400
1915         <rdar://problem/17849033>
1916
1917         Reviewed by David Kilzer.
1918
1919         Update test cases to recognize that we can only support Major
1920         values from 0-65535, Minor values from 0-64, Tiny values from 0-999,
1921         Micro values from 0-64, and Nano values from 0-999.
1922
1923         * Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl: Update
1924         test expectations for physical limits.
1925
1926 2014-07-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1927
1928         [GTK] GLib tests fail with recent GTK+ due to runtime warning about deprecated properties
1929         https://bugs.webkit.org/show_bug.cgi?id=135411
1930
1931         Reviewed by Sergio Villar Senin.
1932
1933         Recent versions of GTK+ now warn at runtime when a deprecated
1934         property or signal is used. A diagnostic mode was added that is
1935         enabled by default, but that can be disabled by setting
1936         G_ENABLE_DIAGNOSTIC=0. Runtime warnings are considered test
1937         failures by gtester, so we need to run the tests with the
1938         diganostic mode disabled.
1939
1940         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.cpp:
1941         (main):
1942
1943 2014-07-29  Carlos Garcia Campos  <cgarcia@igalia.com>
1944
1945         [GTK] Remove WebKitCertificateInfo from WebKit2GTK+ API
1946         https://bugs.webkit.org/show_bug.cgi?id=134830
1947
1948         Reviewed by Gustavo Noronha Silva.
1949
1950         Update the SSL test for the API changes.
1951
1952         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
1953         (testLoadFailedWithTLSErrors):
1954
1955 2014-07-24  David Farler  <dfarler@apple.com>
1956
1957         Add knowledge of the iOS Simulator to webkitpy
1958         http://bugs.webkit.org/show_bug.cgi?id=133963
1959
1960         Reviewed by Simon Fraser.
1961
1962         * Scripts/webkitdirs.pm:
1963         (argumentsForConfiguration): Add --ios-sim*
1964         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1965         --runtime and --device-type args added.
1966         * Scripts/webkitpy/port/base.py:
1967         * Scripts/webkitpy/port/driver.py: Add simulator driver.
1968         (IOSSimulatorDriver): Added.
1969         * Scripts/webkitpy/port/factory.py: Add simulator platform.
1970         * Scripts/webkitpy/port/ios.py: Added.
1971
1972 2014-07-29  Alexey Proskuryakov  <ap@apple.com>
1973
1974         fast/borders/border-radius-on-subpixel-position-non-hidpi.html fails on Retina machines
1975         https://bugs.webkit.org/show_bug.cgi?id=135398
1976
1977         Reviewed by Zalan Bujtas.
1978
1979         * WebKitTestRunner/TestController.cpp: (WTR::TestController::updateWindowScaleForTest):
1980         "hidpi-" should be at the start. This allows "hidpi-" in both file and directory names.
1981
1982         * DumpRenderTree/mac/DumpRenderTree.mm: (changeWindowScaleIfNeeded): Same fix.
1983         For some reason, I wasn't seeing this test fail on WK1 even without the fix, not
1984         sure why.
1985
1986 2014-07-29  Alexey Proskuryakov  <ap@apple.com>
1987
1988         PPT: run-webkit-tests doesn't upload crash logs to bots
1989         https://bugs.webkit.org/show_bug.cgi?id=135391
1990
1991         Reviewed by Joseph Pecoraro.
1992
1993         * WebKitTestRunner/TestController.cpp: (WTR::TestController::processDidCrash):
1994         Not a fix to be proud of, but better than not having it work at all.
1995
1996 2014-07-29  Adrian Perez de Castro  <aperez@igalia.com>
1997
1998         [GTK] Remove WebKitWebViewGroup from WebKit2 GTK+ API
1999         https://bugs.webkit.org/show_bug.cgi?id=133729
2000
2001         Reviewed by Carlos Garcia Campos.
2002
2003         Removes WebKitWebViewGroup, effectively reverting the changes
2004         introduced by r149117. The motivation for WebKitWebViewGroup
2005         was using the user style sheet injection API, which has been
2006         moved into WebKitUserContentManager, rendering it unneeded.
2007
2008         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Remove tests
2009         for WebKitWebViewGroup.
2010         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2011         (testWebViewSettings):
2012         Restore the assertions that check that settings objects are
2013         released. Add test for webkit_web_view_new_with_settings().
2014         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebViewGroup.cpp: Removed.
2015
2016 2014-07-29  Carlos Garcia Campos  <cgarcia@igalia.com>
2017
2018         Implement webkit_web_view_load_string() in WebKit2
2019         https://bugs.webkit.org/show_bug.cgi?id=134735
2020
2021         Reviewed by Sergio Villar Senin.
2022
2023         Add /webkit2/WebKitWebView/load-bytes test case and simplify
2024         TestDOMXPathNSResolver by using webkit_web_view_load_bytes()
2025         instead of a soup server just to sent the Content-type header.
2026
2027         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMXPathNSResolver.cpp:
2028         (testWebKitDOMXPathNSResolverNative):
2029         (testWebKitDOMXPathNSResolverCustom):
2030         (beforeAll):
2031         (afterAll):
2032         (serverCallback): Deleted.
2033         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
2034         (testLoadBytes):
2035         (beforeAll):
2036         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
2037         (LoadTrackingTest::loadBytes):
2038         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h:
2039         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
2040         (WebViewTest::loadBytes):
2041         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
2042
2043 2014-07-28  Daniel Bates  <dabates@apple.com>
2044
2045         Add support for running the Clang static analyzer when building WebKit and JSC
2046         https://bugs.webkit.org/show_bug.cgi?id=134955
2047
2048         Reviewed by Brent Fulgham.
2049
2050         * Scripts/build-jsc: Added command line options -[no]-analyze (disabled by default).
2051         * Scripts/build-webkit: Add --analyze command line option to build-webkit to enable
2052         running the Clang static analyzer.
2053         * Scripts/webkitdirs.pm:
2054         (XcodeStaticAnalyzerOption): Added.
2055
2056 2014-07-24  David Farler  <dfarler@apple.com>
2057
2058         Allow for multiple DumpRenderTree and WebKitTestRunner instances in the iOS Simulator
2059         https://bugs.webkit.org/show_bug.cgi?id=135272
2060
2061         Reviewed by Simon Fraser.
2062
2063         * DumpRenderTree/mac/DumpRenderTree.mm:
2064         (dumpRenderTree): Remove hard-coding of FIFO paths.
2065         (-[DumpRenderTree applicationDidEnterBackground:]): Create background task.
2066         (DumpRenderTreeMain): Set DumpRenderTree as UIApplication delegate.
2067         * DumpRenderTree/mac/DumpRenderTreeMac.h: bgTask ivar.
2068         * Scripts/old-run-webkit-tests: Update FIFO paths for ORWT.
2069         * WebKitTestRunner/TestController.cpp: Remove hard-coding of FIFO paths.
2070         * WebKitTestRunner/ios/TestControllerIOS.mm: Move dup2 calls to platformInitialize
2071         * WebKitTestRunner/ios/mainIOS.mm: bgTask ivar.
2072         (-[WebKitTestRunnerApp applicationDidEnterBackground:]): Create background task.
2073         (main): Set WebKitTestRunnerApp as UIApplication delegate.
2074
2075 2014-07-24  David Farler  <dfarler@apple.com>
2076
2077         ImageDiff builds for the simulator when running iOS layout tests
2078         https://bugs.webkit.org/show_bug.cgi?id=135270
2079
2080         Reviewed by Simon Fraser.
2081
2082         * Scripts/build-imagediff: Added.
2083
2084 2014-07-28  Renato Nagy  <nagy.renato@stud.u-szeged.hu>
2085
2086         Followup fix after r171594
2087         https://bugs.webkit.org/show_bug.cgi?id=135048
2088
2089         Reviewed by Csaba Osztrogonác.
2090
2091         * Scripts/sort-export-file: Removed extra newlines from help.
2092
2093 2014-07-25  Anders Carlsson  <andersca@apple.com>
2094
2095         WKNavigation's properties are either always nil or don't behave as documented
2096         https://bugs.webkit.org/show_bug.cgi?id=135267
2097         <rdar://problem/17730536>
2098
2099         Reviewed by Andreas Kling.
2100
2101         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
2102         (-[NavigationDelegate webView:didStartProvisionalNavigation:]):
2103         (TEST):
2104         (-[DidFailProvisionalNavigationDelegate webView:didStartProvisionalNavigation:]):
2105         (-[DidFailProvisionalNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
2106
2107 2014-07-25  Michael Catanzaro  <mcatanzaro@igalia.com>
2108
2109         [GTK] install-dependencies needs to install perl-CGI on Fedora
2110         https://bugs.webkit.org/show_bug.cgi?id=135302
2111
2112         Reviewed by Martin Robinson.
2113
2114         * gtk/install-dependencies:
2115         Add perl-CGI to yum dependencies needed for tests
2116
2117 2014-07-25  Renato Nagy  <nagy.renato@stud.u-szeged.hu>
2118
2119         Add --dry-run option to sort-export-file
2120         https://bugs.webkit.org/show_bug.cgi?id=135048
2121
2122         Reviewed by Csaba Osztrogonác.
2123
2124         Added --dry-run option to sort-export-file. Running the script with --dry-run
2125         option does not sort the export files but creates a list of the files that
2126         need to be sorted.
2127
2128         * Scripts/sort-export-file:
2129         (sawError):
2130
2131 2014-07-24  Michael Catanzaro  <mcatanzaro@igalia.com>
2132
2133         GTK jhbuild modules needs to build xserver with --disable-local-transport
2134         https://bugs.webkit.org/show_bug.cgi?id=135262
2135
2136         Reviewed by Martin Robinson.
2137
2138         * gtk/jhbuild.modules:
2139         Build X server with --disable-local-transport, since local transport
2140         is only supported on Solaris, SCO, and System V. Fixes build on
2141         Fedora.
2142
2143 2014-07-24  Michael Catanzaro  <mcatanzaro@igalia.com>
2144
2145         [GTK] build-webkit script fails under jhbuild if ACLOCAL_FLAGS is unset
2146         https://bugs.webkit.org/show_bug.cgi?id=135065
2147
2148         Reviewed by Martin Robinson.
2149
2150         * jhbuild/jhbuild-wrapper:
2151         (ensure_jhbuild): do not assume jhbuild sets ACLOCAL_FLAGS
2152
2153 2014-07-23  Joseph Pecoraro  <pecoraro@apple.com>
2154
2155         Unreviewed iOS build fix after r171355.
2156
2157         * TestWebKitAPI/Configurations/Base.xcconfig:
2158         Since all the Tests/WebKit2Cocoa tests are already explicitly skipped on iOS,
2159         simplify to skipping all the tests in the directory. PlatformUtilities are not
2160         building on iOS, which means we are missing necessary Util functions.
2161
2162 2014-07-23  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
2163
2164         [EFL] Fix build after r171454
2165         https://bugs.webkit.org/show_bug.cgi?id=135191
2166
2167         Reviewed by Csaba Osztrogonác.
2168
2169         * MiniBrowser/efl/CMakeLists.txt: Add path to new EWebKit2.h location .
2170
2171 2014-07-23  Ryuan Choi  <ryuan.choi@samsung.com>
2172
2173         [EFL] Do not generate forwarding header for ewk headers
2174         https://bugs.webkit.org/show_bug.cgi?id=135147
2175
2176         Reviewed by Gyuyoung Kim.
2177
2178         * WebKitTestRunner/EventSenderProxy.h:
2179
2180 2014-07-21  Sam Weinig  <sam@webkit.org>
2181
2182         [Cocoa] WKScriptMessageHandlers don't seem to function properly after navigating
2183         https://bugs.webkit.org/show_bug.cgi?id=135148
2184
2185         Reviewed by Geoffrey Garen.
2186
2187         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2188         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm: Added.
2189         (-[SimpleNavigationDelegate webView:didFinishNavigation:]):
2190         (-[ScriptMessageHandler userContentController:didReceiveScriptMessage:]):
2191
2192 2014-07-22  Brent Fulgham  <bfulgham@apple.com>
2193
2194         Correct handling of __VERSION_TEXT__ for 4+-tuple versions
2195         https://bugs.webkit.org/show_bug.cgi?id=135161
2196         <rdar://problem/17763546>
2197
2198         Reviewed by David Kilzer.
2199
2200         * Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl:
2201         Add additional test cases to catch errors in multiple-tuple
2202         version string handling.
2203
2204 2014-07-18  Filip Pizlo  <fpizlo@apple.com>
2205
2206         Extend exception fuzzing to the LLInt
2207         https://bugs.webkit.org/show_bug.cgi?id=135076
2208
2209         Reviewed by Oliver Hunt.
2210
2211         * Scripts/jsc-stress-test-helpers/js-exception-fuzz:
2212
2213 2014-07-22  Jochen Eisinger  <jochen@chromium.org>
2214
2215         Fix my email address in contributors.json
2216         https://bugs.webkit.org/show_bug.cgi?id=135156
2217
2218         Reviewed by Gyuyoung Kim.
2219
2220         * Scripts/webkitpy/common/config/contributors.json:
2221
2222 2014-07-21  Brent Fulgham  <bfulgham@apple.com>
2223
2224         Unreviewed test fix.
2225
2226         * Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl: Revert
2227         to older Perl 5.8 syntax for iterating over hashes to allow tests to
2228         run on Mountain Lion bots.
2229
2230 2014-07-21  Alexey Proskuryakov  <ap@apple.com>
2231
2232         https://bugs.webkit.org/show_bug.cgi?id=135137
2233         build.webkit.org/dashboard: webkitperl failures show up as yellow, not red
2234
2235         Reviewed by Darin Adler.
2236
2237         webkitperl results are binary, handle them the same way we handle bindings test results.
2238
2239         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2240         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
2241         (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds):
2242
2243 2014-07-21  Brent Fulgham  <bfulgham@apple.com>
2244
2245         [Win] Follow-up for r171324.
2246
2247         * Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl: Cygwin
2248         perl reports itself as 'cygwin'; native Windows Perl reports as
2249         'MSWin32'. We need to handle both cases.
2250
2251 2014-07-21  Brent Fulgham  <bfulgham@apple.com>
2252
2253         Unreviewed build fix after r171319.
2254
2255         * Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl: This test should
2256         only execute on Windows. It will fail on other platforms, so give it a way to
2257         successfully exit.
2258
2259 2014-07-21  Brent Fulgham  <bfulgham@apple.com>
2260
2261         [Win] Extend auto-version.pl to support 5-tuple versions
2262         https://bugs.webkit.org/show_bug.cgi?id=135124
2263         <rdar://problem/17750334>
2264
2265         Reviewed by David Kilzer.
2266
2267         Add test cases for auto-version.pl.
2268
2269         * Scripts/webkitperl/auto-version_unittest: Added.
2270         * Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl: Added.
2271
2272 2014-07-21  Dean Jackson  <dino@apple.com>
2273
2274         Allow MiniBrowser WK1 to do element fullscreen
2275         https://bugs.webkit.org/show_bug.cgi?id=135125
2276
2277         Reviewed by Simon Fraser.
2278
2279         Allow WK1 windows to go fullscreen using the DOM API.
2280
2281         * MiniBrowser/mac/WK1BrowserWindowController.m:
2282         (-[WK1BrowserWindowController awakeFromNib]): Enable the preference for
2283         fullscreen.
2284
2285 2014-07-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2286
2287         [GTK] Documentation files are added twice to the tarball
2288         https://bugs.webkit.org/show_bug.cgi?id=135115
2289
2290         Reviewed by Sergio Villar Senin.
2291
2292         * gtk/manifest.txt: Remove duplicated rules.
2293
2294 2014-07-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2295
2296         [GTK] Simplify make-dist command line arguments
2297         https://bugs.webkit.org/show_bug.cgi?id=134832
2298
2299         Reviewed by Martin Robinson.
2300
2301         Remove --tarball-root and -o command line options and add
2302         --version, since the version can be used to build both, the
2303         tarball root and the output filename. When the version it's not
2304         provided, the pkg-config file is used to get the version. Also
2305         change the default value of build-dir to the current directory,
2306         since it's very common to call make-dist.py from the build dir.
2307
2308         * gtk/make-dist.py:
2309         (get_tarball_root_and_output_filename_from_arguments):
2310
2311 2014-07-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2312
2313         [GTK] Reduce the size of the tarball generated by distcheck
2314         https://bugs.webkit.org/show_bug.cgi?id=134802
2315
2316         Reviewed by Martin Robinson.
2317
2318         Add more rules to the manifest to decide what files to add:
2319
2320           - Do not include platform specific directories of other ports.
2321           - Do not include port specific cmake files.
2322           - Do not include Objective-C sources.
2323           - Do not include .orig and .rej files.
2324           - Do not include mac specific sandbox files.
2325           - Only include the resources we actually build.
2326
2327         * gtk/manifest.txt:
2328
2329 2014-07-20  KwangHyuk Kim  <hyuki.kim@samsung.com>
2330
2331         [EFL] Enable mpg123 feature for gst-plugin-bad.
2332         https://bugs.webkit.org/show_bug.cgi?id=135016
2333
2334         Reviewed by Laszlo Gombos.
2335
2336         enable-mpg123 feature is added to jhbuild in order to support playback of mp3 format.
2337
2338         * efl/install-dependencies:
2339         * efl/jhbuild.modules:
2340
2341 2014-07-20  Dan Bernstein  <mitz@apple.com>
2342
2343         Test for <rdar://problems/17742611> -[_WKActivatedElementInfo image] is often empty
2344         https://bugs.webkit.org/show_bug.cgi?id=135107
2345
2346         Reviewed by Sam Weinig.
2347
2348         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2349         * TestWebKitAPI/Tests/mac/RenderedImageFromDOMNode.mm: Added.
2350         (-[RenderedImageFromDOMNodeFrameLoadDelegate webView:didFinishLoadForFrame:]):
2351         (TestWebKitAPI::TEST):
2352
2353 2014-07-20  David Kilzer  <ddkilzer@apple.com>
2354
2355         Checker: Value stored to 'kernResult' is never read (LayoutTestHelper.m:164)
2356         <http://webkit.org/b/135096>
2357
2358         Reviewed by Alexey Proskuryakov.
2359
2360         * DumpRenderTree/mac/LayoutTestHelper.m:
2361         (lockDownDiscreteGraphics): Check the return values of
2362         IOServiceOpen() and IOObjectRelease(), and log if not
2363         KERN_SUCCESS.
2364
2365 2014-07-19  Anders Carlsson  <andersca@apple.com>
2366
2367         Update.
2368
2369         * Scripts/webkitpy/common/config/watchlist:
2370
2371 2014-07-18  Sam Weinig  <sam@webkit.org>
2372
2373         Revert accidental commit to MiniBrowser to make everything layer backed.
2374
2375         * MiniBrowser/mac/BrowserWindowController.m:
2376         (-[BrowserWindowController windowDidLoad]):
2377
2378 2014-07-18  Dana Burkart  <dburkart@apple.com>
2379
2380         Add a new 'analyze' target to the makefile. This will make use of a new
2381         'PATH_TO_SCAN_BUILD' which, if set will wrap xcodebuild in the clang
2382         static analyzer.
2383         https://bugs.webkit.org/show_bug.cgi?id=135057
2384         <rdar://problem/10193187>
2385
2386         Reviewed by David Kilzer.
2387
2388         * Makefile:
2389
2390 2014-07-18  Filip Pizlo  <fpizlo@apple.com>
2391
2392         Fix EFL+GTK.
2393
2394         * Scripts/run-jsc-stress-tests:
2395
2396 2014-07-18  Filip Pizlo  <fpizlo@apple.com>
2397
2398         Exception fuzzing should work on iOS
2399         https://bugs.webkit.org/show_bug.cgi?id=135070
2400
2401         Reviewed by Mark Hahnenberg.
2402
2403         * Scripts/jsc-stress-test-helpers/js-exception-fuzz:
2404         (fail):
2405         * Scripts/run-jsc-stress-tests:
2406
2407 2014-07-18  Filip Pizlo  <fpizlo@apple.com>
2408
2409         run-jsc-stress-tests should be able to run helper-based tests in remote mode
2410         https://bugs.webkit.org/show_bug.cgi?id=135064
2411
2412         Reviewed by Mark Hahnenberg.
2413
2414         * Scripts/run-jsc-stress-tests:
2415
2416 2014-07-18  Filip Pizlo  <fpizlo@apple.com>
2417
2418         run-jsc-stress-tests: rename $copy to $doNotMessWithVMPath
2419         https://bugs.webkit.org/show_bug.cgi?id=135061
2420
2421         Rubber stamped by Mark Hahnenberg.
2422
2423         * Scripts/run-jsc-stress-tests:
2424
2425 2014-07-18  Filip Pizlo  <fpizlo@apple.com>
2426
2427         Refactor run-jsc-stress-tests VM copying code to remove some abstractions
2428         https://bugs.webkit.org/show_bug.cgi?id=135059
2429
2430         Reviewed by Mark Lam.
2431         
2432         This is meant to make it easier for me to extend the copying functionality to copy things other than
2433         the framework.
2434
2435         * Scripts/run-jsc-stress-tests:
2436
2437 2014-07-18  Filip Pizlo  <fpizlo@apple.com>
2438
2439         Fix cloop build.
2440
2441         * Scripts/jsc-stress-test-helpers/js-exception-fuzz:
2442
2443 2014-07-18  Renato Nagy  <nagy.renato@stud.u-szeged.hu>
2444
2445         Fix -v|--verbose option in sort-export-file script.
2446         https://bugs.webkit.org/show_bug.cgi?id=135043
2447
2448         Reviewed by Tim Horton.
2449
2450         -v|--verbose option does not work. Option added to getOptionsResult.
2451
2452         * Scripts/sort-export-file:
2453
2454 2014-07-18  Filip Pizlo  <fpizlo@apple.com>
2455
2456         Really remove dependency on ShellQuote.
2457
2458         * Scripts/jsc-stress-test-helpers/js-exception-fuzz:
2459
2460 2014-07-18  Filip Pizlo  <fpizlo@apple.com>
2461
2462         Unreviewed, fix build for platforms that don't have ShellQuote.
2463         
2464         * Scripts/jsc-stress-test-helpers/js-exception-fuzz: Take a single argument that has the whole command string.
2465         * Scripts/run-jsc-stress-tests: Do the escaping in Ruby.
2466
2467 2014-07-15  Filip Pizlo  <fpizlo@apple.com>
2468
2469         Need ability to fuzz exception throwing
2470         https://bugs.webkit.org/show_bug.cgi?id=134945
2471         <rdar://problem/17722027>
2472
2473         Reviewed by Sam Weinig.
2474         
2475         Adds a new script, js-exception-fuzz, which will run some jsc command-line using
2476         exception fuzzing. This means that we will force exceptions to be thrown in random
2477         places to see how the engine reacts. This is now integrated with the various test
2478         drivers, so run-javascriptcore-tests will run some exception fuzzing tests by
2479         default.
2480
2481         * Scripts/jsc-stress-test-helpers/js-exception-fuzz: Added.
2482         (fail):
2483         * Scripts/run-javascriptcore-tests:
2484         * Scripts/run-jsc-stress-tests:
2485
2486 2014-07-17  Sam Weinig  <sam@webkit.org>
2487
2488         Fix failing API tests.
2489
2490         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
2491         (-[ActiveOffscreenWindow isVisible]):
2492         Override isVisible to make the NSWindows pretend they are visible.
2493
2494 2014-07-17  Alexey Proskuryakov  <ap@apple.com>
2495
2496         Disable button animations in regression tests
2497         https://bugs.webkit.org/show_bug.cgi?id=133647
2498         <rdar://problem/16677530>
2499
2500         Reviewed by Dean Jackson.
2501
2502         * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
2503         We already did this for WebKit2, let's do it for WebKit1 too.
2504
2505 2014-07-16  Alexey Proskuryakov  <ap@apple.com>
2506
2507         A test that hangs at cleanup stage confuses webkitpy hugely
2508         https://bugs.webkit.org/show_bug.cgi?id=122475
2509         <rdar://problem/17184354>
2510
2511         Reviewed by Anders Carlsson.
2512
2513         Terminate WebContent process if it freezes between tests. Ideally, we should report
2514         this somehow, but this is better than blaming the wrong test.
2515
2516         * WebKitTestRunner/TestController.cpp:
2517         (WTR::TestController::terminateWebContentProcess):
2518         * WebKitTestRunner/TestController.h:
2519         * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::invoke):
2520
2521 2014-07-16  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2522
2523         Change style check path with EFL WK2's path in checker_unittest.py
2524         https://bugs.webkit.org/show_bug.cgi?id=134967
2525
2526         Reviewed by Csaba Osztrogonác.
2527
2528         * Scripts/webkitpy/style/checker_unittest.py: Change ewk_view.h path.
2529         (GlobalVariablesTest.test_path_rules_specifier):
2530
2531 2014-07-16  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2532
2533         Unreviewed. Added myself to the list of committers.
2534
2535         * Scripts/webkitpy/common/config/contributors.json:
2536
2537 2014-07-15  Ryuan Choi  <ryuan.choi@samsung.com>
2538
2539         [EFL] Remove EFL WK1 directory from the checker.py
2540         https://bugs.webkit.org/show_bug.cgi?id=134954
2541
2542         Reviewed by Gyuyoung Kim.
2543
2544         * Scripts/webkitpy/style/checker.py:
2545
2546 2014-07-15  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2547
2548         Adding myself to contributors.json breaks a webkitpy test
2549         https://bugs.webkit.org/show_bug.cgi?id=134958
2550
2551         Reviewed by Ryosuke Niwa.
2552
2553         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2554         (IRCCommandTest.test_whois): Be more specific and include also the
2555         first name when asking for the whois of Xan in the unit test.
2556
2557 2014-07-14  Daniel Bates  <dabates@apple.com>
2558
2559         check-webkit-style should apply C++ rules to Objective-C++ files
2560         https://bugs.webkit.org/show_bug.cgi?id=134884
2561
2562         Reviewed by Joseph Pecoraro.
2563
2564         Fixes an issue where check-webkit-style doesn't apply applicable C++ rules to
2565         Objective-C++ files.
2566
2567         Currently check-webkit-style doesn't apply the following rules to Objective-C++
2568         files: build/using_std, runtime/max_min_macros, runtime/wtf_move, readability/null.
2569         Instead, we should teach check-webkit-style to apply these rules because, as
2570         its name implies, an Objective-C++ file may contain C++ code.
2571
2572         * Scripts/webkitpy/style/checkers/cpp.py:
2573         (_FileState.__init__): Add instance variable _is_objective_cpp to track whether a file has
2574         extension mm (i.e. an Objective-C++ file).
2575         (_FileState.is_objective_c_or_objective_cpp): Added; returns true if the file
2576         has extension m or mm or if the file has extension h and contains Objective-C directives.
2577         (check_for_null): No change in behavior; don't apply rule to Objective-C++ file.
2578         (check_identifier_name_in_declaration): Substitute _FileState.is_objective_c_or_objective_cpp() for
2579         _FileState.is_c_or_objective_c()
2580         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2581         (WebKitStyleTest.test_null_false_zero): Added test case for Objective-C++ file.
2582         (WebKitStyleTest.test_max_macro): Add test case for Objective-C and Objective-C++ file.
2583         (WebKitStyleTest.test_min_macro): Ditto.
2584         (WebKitStyleTest.test_wtf_move): Add test case for Objective-C++ file.
2585
2586 2014-07-14  Anders Carlsson  <andersca@apple.com>
2587
2588         Make shouldKeepCurrentBackForwardListItemInList part of WKPageLoaderClientV5 to avoid breaking ABI
2589         https://bugs.webkit.org/show_bug.cgi?id=134889
2590
2591         Reviewed by Beth Dakin.
2592
2593         Bump loader version number to 5.
2594
2595         * TestWebKitAPI/Tests/WebKit2/ShouldKeepCurrentBackForwardListItemInList.cpp:
2596         (TestWebKitAPI::setPageLoaderClient):
2597         * WebKitTestRunner/TestController.cpp:
2598         (WTR::TestController::createWebViewWithOptions):
2599
2600 2014-07-14  Daniel Bates  <dabates@apple.com>
2601
2602         Teach check-webkit-style to suggest WTF::move() when it sees std::move()
2603         https://bugs.webkit.org/show_bug.cgi?id=134620
2604
2605         Reviewed by Joseph Pecoraro.
2606
2607         * Scripts/webkitpy/style/checkers/cpp.py:
2608         (check_max_min_macros): Fix up comment so that it reads well.
2609         (check_wtf_move): Added.
2610         (check_style): Modified to call check_wtf_move().
2611         (CppChecker): Add category "runtime/wtf_move".
2612         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2613         (WebKitStyleTest.test_wtf_move): Added.
2614
2615 2014-07-12  Peter Szanka  <h868064@stud.u-szeged.hu>
2616
2617         Style checker complains about namespace indentation when there is no namespace
2618         https://bugs.webkit.org/show_bug.cgi?id=105427
2619
2620         Reviewed by Darin Adler.
2621
2622         * Scripts/webkitpy/style/checkers/cpp.py:
2623         (check_namespace_indentation):
2624         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2625         (WebKitStyleTest.test_indentation):
2626
2627         The indentation level depends on the parantheses too, to avoid false warning in case of several statements inside macros.
2628
2629 2014-07-12  Daker Fernandes Pinheiro  <daker.pinheiro@openbossa.org>
2630
2631         Remove excessive nesting from _EnumState.process_clean_line at cpp style checker
2632         https://bugs.webkit.org/show_bug.cgi?id=125317
2633
2634         Reviewed by Darin Adler.
2635
2636         * Scripts/webkitpy/style/checkers/cpp.py:
2637         (_EnumState.process_clean_line):
2638
2639 2014-07-12  Brian Holt  <brian.holt@samsung.com>
2640
2641         Style Checker should prevent enums in bitfields
2642         https://bugs.webkit.org/show_bug.cgi?id=57352
2643
2644         Reviewed by Darin Adler.
2645
2646         Added check that enums are not used as types for bitfields
2647         and a unit test.
2648
2649         * Scripts/webkitpy/style/checkers/cpp.py:
2650         (check_language):
2651         (CppChecker):
2652         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2653         (CppStyleTest):
2654         (CppStyleTest.test_enum_bitfields):
2655         (CppStyleTest.test_plain_integral_bitfields):
2656
2657 2014-07-10  Myles C. Maxfield  <mmaxfield@apple.com>
2658
2659         [iOS] Pasting rich content does not perform a two-step paste
2660         https://bugs.webkit.org/show_bug.cgi?id=134795
2661
2662         Reviewed by Benjamin Poulain.
2663
2664         Two-step paste requires setting InputViewObeysDOMFocus on the UIWebBrowserView.
2665
2666         * DumpRenderTree/mac/DumpRenderTree.mm:
2667         (createWebViewAndOffscreenWindow):
2668
2669 2014-07-10  Carlos Garcia Campos  <cgarcia@igalia.com> and Martin Robinson  <mrobinson@igalia.com>
2670
2671         [GTK][CMake] Add a 'distcheck' target
2672         https://bugs.webkit.org/show_bug.cgi?id=130675
2673
2674         Reviewed by Gustavo Noronha Silva.
2675
2676         Add --check option to make-dist script that builds and installs the tarball.
2677
2678         * gtk/make-dist.py:
2679         (Distcheck.__init__):
2680         (Distcheck.extract_tarball): Extratc the tarball.
2681         (Distcheck.configure): Run cmake.
2682         (Distcheck.configure.create_dir): Helper function to create a directory.
2683         (Distcheck.build): Run make.
2684         (Distcheck.install): Run make install.
2685         (Distcheck.clean): Clean up the extracted tarball.
2686         (Distcheck.check): Run all previous methods in order.
2687         * gtk/manifest.txt: Add missing file.
2688
2689 2014-07-10  Carlos Garcia Campos  <cgarcia@igalia.com>
2690
2691         [GTK] Use the same default options for production builds that previous stable releases
2692         https://bugs.webkit.org/show_bug.cgi?id=134589
2693
2694         Reviewed by Martin Robinson.
2695
2696         Make sure all features enabled in production builds are also
2697         enabled in developer mode.
2698
2699         * Scripts/webkitperl/FeatureList.pm: Enable ACCELERATED_2D_CANVAS
2700         and CSS_FILTERS for the GTK port.
2701
2702 2014-07-09  Brent Fulgham  <bfulgham@apple.com>
2703
2704         [Win] Remove uses of 'bash' in build system
2705         https://bugs.webkit.org/show_bug.cgi?id=134782
2706         <rdar://problem/17615533>
2707
2708         Reviewed by Dean Jackson.
2709
2710         Remove uses of 'bash' by replacing Windows-specific bash scripts
2711         with Perl equivalents.
2712
2713         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePreBuild.cmd:
2714         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffPreBuild.cmd:
2715         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginPreBuild.cmd:
2716         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIPreBuild.cmd:
2717         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd:
2718         * WinLauncher/WinLauncher.vcxproj/WinLauncherPreBuild.cmd:
2719
2720 2014-07-09  Brent Fulgham  <bfulgham@apple.com>
2721
2722         [Win] Remove use of 'grep' in build steps
2723         https://bugs.webkit.org/show_bug.cgi?id=134770
2724         <rdar://problem/17608783>
2725
2726         Reviewed by Tim Horton.
2727
2728         Replace uses of the grep command in Windows builds with the equivalent
2729         Perl program.
2730
2731         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePreBuild.cmd:
2732         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffPreBuild.cmd:
2733         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginPreBuild.cmd:
2734         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIPreBuild.cmd:
2735         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd:
2736         * WinLauncher/WinLauncher.vcxproj/WinLauncherPreBuild.cmd:
2737
2738 2014-07-09  Commit Queue  <commit-queue@webkit.org>
2739
2740         Unreviewed, rolling out r170889.
2741         https://bugs.webkit.org/show_bug.cgi?id=134754
2742
2743         This patch is wrong (Requested by philn on #webkit).
2744
2745         Reverted changeset:
2746
2747         "[GTK] Gstreamer missing from the install-dependencies script"
2748         https://bugs.webkit.org/show_bug.cgi?id=134727
2749         http://trac.webkit.org/changeset/170889
2750
2751 2014-07-08  Brian J. Burg  <burg@cs.washington.edu>
2752
2753         resolve-ChangeLogs fails when WebKit repository is a git submodule
2754         https://bugs.webkit.org/show_bug.cgi?id=134734
2755
2756         Reviewed by David Kilzer.
2757
2758         When using resolve-ChangeLogs in a WebKit git repository with a
2759         non-default arrangement of GIT_DIR and GIT_WORK_TREE, incorrect
2760         paths are computed and the script fails mysteriously.
2761
2762         We were naively computing GIT_WORK_TREE as being one level above
2763         GIT_DIR, but this is not the case for submodules or a manually
2764         configured GIT_WORK_TREE or GIT_DIR location.
2765
2766         * Scripts/VCSUtils.pm:
2767         (gitTreeDirectory): Added. Find the equivalent of GIT_WORK_TREE.
2768         (determineVCSRoot): Calculate the working tree root directly.
2769
2770 2014-07-08  Tim Horton  <timothy_horton@apple.com>
2771
2772         [WK2] Expose a few drawing/compositing settings on WKPreferences(Private)
2773         https://bugs.webkit.org/show_bug.cgi?id=134645
2774
2775         Reviewed by Dan Bernstein.
2776
2777         * MiniBrowser/mac/BrowserWindowController.h:
2778         * MiniBrowser/mac/MainMenu.xib:
2779         Add menu items for layer borders and the tiled scrolling indicator.
2780
2781         * MiniBrowser/mac/WK1BrowserWindowController.m:
2782         (-[WK1BrowserWindowController validateMenuItem:]):
2783         (-[WK1BrowserWindowController layerBordersAreVisible]):
2784         (-[WK1BrowserWindowController toggleLayerBordersVisibility:]):
2785         Add getters/setters/validators for layer borders.
2786
2787         * MiniBrowser/mac/WK2BrowserWindowController.m:
2788         (-[WK2BrowserWindowController awakeFromNib]):
2789         (-[WK2BrowserWindowController validateMenuItem:]):
2790         (-[WK2BrowserWindowController layerBordersAreVisible]):
2791         (-[WK2BrowserWindowController toggleLayerBordersVisibility:]):
2792         (-[WK2BrowserWindowController tiledScrollingIndicatorIsVisible]):
2793         (-[WK2BrowserWindowController toggleTiledScrollingIndicatorVisibility:]):
2794         Add getters/setters/validators for layer borders and the tiled scrolling indicator.
2795
2796         (-[WK2BrowserWindowController isSubpixelCSSOMElementMetricsEnabled]): Deleted.
2797         (-[WK2BrowserWindowController toggleSubpixelCSSOMElementMetricsEnabled:]): Deleted.
2798         Remove the WebKit2 version of the subpixel metrics pref, because it doesn't work, because
2799         nothing in WebKit2 reads this default, and there is no WebKit2 API for adjusting this preference.
2800
2801 2014-07-08  Adrian Perez de Castro  <aperez@igalia.com>
2802
2803         [GTK] Move user style sheet API out of WebKitWebViewGroup
2804         https://bugs.webkit.org/show_bug.cgi?id=134551
2805
2806         Reviewed by Carlos Garcia Campos.
2807
2808         Removes testing user style sheet injection from
2809         TestWebKitWebViewGroup and moves that into a new
2810         TestWebKitUserContentManager, adapting the existing tests to the new
2811         API. Also, it contains a new test case for
2812         webkit_web_view_new_with_user_content_manager().
2813
2814         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
2815         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp: Added.
2816         (UserContentManagerTest::UserContentManagerTest):
2817         (testWebViewNewWithUserContentManager):
2818         (isStyleSheetInjectedForURLAtPath):
2819         (fillURLListFromPaths):
2820         (removeOldInjectedStyleSheetsAndResetLists):
2821         (testUserContentManagerInjectedStyleSheet):
2822         (serverCallback):
2823         (beforeAll):
2824         (afterAll):
2825         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebViewGroup.cpp:
2826         (beforeAll):
2827         (afterAll):
2828         (isStyleSheetInjectedForURLAtPath): Deleted.
2829         (fillURLListFromPaths): Deleted.
2830         (removeOldInjectedStyleSheetsAndResetLists): Deleted.
2831         (testWebViewGroupInjectedStyleSheet): Deleted.
2832         (serverCallback): Deleted.
2833         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
2834         (WebViewTest::WebViewTest):
2835         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
2836
2837 2014-07-08  Ziran Sun  <ziran.sun@samsung.com>
2838
2839         [GTK] Gstreamer missing from the install-dependencies script
2840         https://bugs.webkit.org/show_bug.cgi?id=134727
2841
2842         Reviewed by Mario Sanchez Prada.
2843
2844         Added missing gstreamer dependencies for debian based systems.
2845
2846         * gtk/install-dependencies: Added 2 dependencies for apt-get.
2847
2848 2014-07-08  Myles C. Maxfield  <mmaxfield@apple.com>
2849
2850         Add myself to the watchlist for text-related files
2851         https://bugs.webkit.org/show_bug.cgi?id=134707
2852
2853         Reviewed by Timothy Horton.
2854
2855         * Scripts/webkitpy/common/config/watchlist:
2856
2857 2014-07-08  Gergo Balogh  <gbalogh.u-szeged@partner.samsung.com>
2858
2859         Add option to specify output file location in sunspider.
2860         https://bugs.webkit.org/show_bug.cgi?id=134339
2861
2862         Reviewed by Darin Adler.
2863
2864         * Scripts/run-sunspider:
2865
2866 2014-07-07  Alex Christensen  <achristensen@webkit.org>
2867
2868         Unreviewed build fix.
2869
2870         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
2871         Make Common.cpp excluded from both 32-bit and 64-bit builds.
2872
2873 2014-07-07  Simon Fraser  <simon.fraser@apple.com>
2874
2875         Have MiniBrowser log and reload if the Web Content Process crashes
2876         https://bugs.webkit.org/show_bug.cgi?id=134691
2877
2878         Reviewed by Tim Horton.
2879         
2880         Implement _webViewWebProcessDidCrash, log and reload when the web process
2881         crashes.
2882
2883         * MiniBrowser/mac/WK2BrowserWindowController.m:
2884         (-[WK2BrowserWindowController _webViewWebProcessDidCrash:]):
2885
2886 2014-07-07  Alberto Garcia  <berto@igalia.com>
2887
2888         update-webkitgtk-libs script fails by unsatisfied dependencies
2889         https://bugs.webkit.org/show_bug.cgi?id=134547
2890
2891         Reviewed by Martin Robinson.
2892
2893         Install libxcb-xfixes0-dev, needed to build Mesa.
2894
2895         * gtk/install-dependencies:
2896
2897 2014-07-06  Yoav Weiss  <yoav@yoav.ws>
2898
2899         Turn on img@sizes compile flag
2900         https://bugs.webkit.org/show_bug.cgi?id=134634
2901
2902         Reviewed by Benjamin Poulain.
2903
2904         * Scripts/webkitperl/FeatureList.pm: Turn on the img@sizes feature.
2905
2906 2014-07-06  Hyowon Kim  <hw1008.kim@samsung.com>
2907
2908         Unreviewed. Adding myself to committers.
2909
2910         * Scripts/webkitpy/common/config/contributors.json:
2911
2912 2014-07-05  KwangHyuk Kim  <hyuki.kim@samsung.com>
2913
2914         [EFL] Add libgeoclue-dev to Tools/efl/install-dependencies.
2915         https://bugs.webkit.org/show_bug.cgi?id=134648
2916
2917         Reviewed by Gyuyoung Kim.
2918
2919         As Geoclue is enabled for EFL, libgeoclue-dev is also added to Tools/efl/install-dependencies.
2920
2921         * efl/install-dependencies:
2922
2923 2014-07-04  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2924
2925         [EFL] Support Geolocation
2926         https://bugs.webkit.org/show_bug.cgi?id=134439
2927
2928         Reviewed by Antonio Gomes.
2929
2930         * Scripts/webkitperl/FeatureList.pm: Enable geolocation for EFL port.
2931
2932 2014-07-04  Shivakumar JM  <shiva.jm@samsung.com>
2933
2934         [EFL][WK2] Enhance the Minibrowser to show selected/highlighted text in search bar, if any.
2935         https://bugs.webkit.org/show_bug.cgi?id=134485
2936
2937         Reviewed by Gyuyoung Kim.
2938
2939         Use script_execute_callback to get selected/highlighted text and show in search bar.
2940
2941         * MiniBrowser/efl/main.c:
2942         (script_execute_callback):
2943         (on_key_down):
2944
2945 2014-07-04  Dan Bernstein  <mitz@apple.com>
2946
2947         Build fix after r170811.
2948
2949         * MiniBrowser/mac/WK2BrowserWindowController.m:
2950         (-[WK2BrowserWindowController reload:]):
2951
2952 2014-07-04  Timothy Horton  <timothy_horton@apple.com>
2953
2954         Typo in watchlist config means four specific people get Cc'd on everything
2955         https://bugs.webkit.org/show_bug.cgi?id=134626
2956
2957         Reviewed by Gyuyoung Kim.
2958
2959         * Scripts/webkitpy/common/config/watchlist:
2960         Remove leading pipe, which meant that this rule matched everything!
2961
2962 2014-07-03  Shivakumar JM  <shiva.jm@samsung.com>
2963
2964         [EFL][WK2] Enhance the Minibrowser to show text search count and close search bar.
2965         https://bugs.webkit.org/show_bug.cgi?id=134486
2966
2967         Reviewed by Gyuyoung Kim.
2968
2969         Use on_search_close_button_clicked() callback to close search bar and on_search_text_found() callback to show search count.
2970
2971         * MiniBrowser/efl/main.c:
2972         (search_box_show):
2973         (search_box_hide):
2974         (on_search_close_button_clicked):
2975         (on_search_text_found):
2976         (window_create):
2977
2978 2014-07-03  Daniel Bates  <dabates@apple.com>
2979
2980         Add WTF::move()
2981         https://bugs.webkit.org/show_bug.cgi?id=134500
2982
2983         Rubber-stamped by Anders Carlsson.
2984
2985         Substitute WTF::move() for std::move().
2986
2987         * DumpRenderTree/win/DRTDataObject.cpp:
2988         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
2989         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
2990         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
2991         * TestWebKitAPI/Tests/WTF/Vector.cpp:
2992         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
2993         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm: Added FIXME comments that explain that some of the sub-tests
2994         aren't actually testing move semantics in tests: MoveAssignmentFromSameType, MoveAssignmentFromSimilarType,
2995         ConstructionFromSameType, and ConstructionFromSimilarType.
2996         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
2997
2998 2014-07-03  László Langó  <llango.u-szeged@partner.samsung.com>
2999
3000         [JavaScriptCore] Add --cmakeargs option to build-jsc.
3001         https://bugs.webkit.org/show_bug.cgi?id=134590
3002
3003         Reviewed by Ryosuke Niwa.
3004
3005         * Scripts/build-jsc:
3006
3007 2014-07-03  Gergo Balogh  <gbalogh.u-szeged@partner.samsung.com>
3008
3009         Add option to specify jsc args in run-sunspider.
3010         https://bugs.webkit.org/show_bug.cgi?id=134341
3011
3012         Reviewed by Csaba Osztrogonác.
3013
3014         * Scripts/run-sunspider:
3015
3016 2014-07-02  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3017
3018         [GTK] Unreviewed gardening.
3019
3020         * Scripts/run-gtk-tests:
3021         (TestRunner): Report and mark flaky test WebKit2Gtk/TestCookieManager:persistent-storage
3022
3023 2014-07-02  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3024
3025         Clean up unused EFL buildbot information in BuildSlaveSupport and TestResultServer
3026         https://bugs.webkit.org/show_bug.cgi?id=134581
3027
3028         Reviewed by Tim Horton.
3029
3030         Should be removed unused EFL bot info.
3031
3032         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
3033         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js:
3034         (EWS):
3035         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3036         (WebKitBuildbot):
3037         * TestResultServer/static-dashboards/builders.jsonp:
3038         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3039         (test):
3040
3041 2014-07-02  Alex Christensen  <achristensen@webkit.org>
3042
3043         Unreviewed.  Moved self to reviewers list.
3044
3045         * Scripts/webkitpy/common/config/contributors.json:
3046         Moved self to reviewers list, added WebGL to expertise.
3047
3048 2014-07-02  Carlos Garcia Campos  <cgarcia@igalia.com>
3049
3050         [GTK] Make dist only works when run from the source directory
3051         https://bugs.webkit.org/show_bug.cgi?id=134543
3052
3053         Reviewed by Martin Robinson.
3054
3055         Since the paths in the manifest are relative to the source dir,
3056         and the script expects the current working directory to be the
3057         source directory, resolve all passed in relative paths while
3058         parsing the arguments and then change the current working
3059         directory.
3060
3061         * gtk/make-dist.py:
3062
3063 2014-07-02  Carlos Garcia Campos  <cgarcia@igalia.com>
3064
3065         [GTK] make dist is broken
3066         https://bugs.webkit.org/show_bug.cgi?id=134542
3067
3068         Reviewed by Martin Robinson.
3069
3070         * gtk/make-dist.py: Rename command line options to match what cmake uses.
3071         * gtk/manifest.txt: Remove WebKit1 references and add WebKitDOM documentation.
3072
3073 2014-07-02  Carlos Garcia Campos  <cgarcia@igalia.com>
3074
3075         [GTK] WebKitWebView::create should receive information about the navigation action
3076         https://bugs.webkit.org/show_bug.cgi?id=133680
3077
3078         Reviewed by Martin Robinson.
3079
3080         Add unit test to check the WebKitNavigationAction passed to
3081         WebKitWebView::create callback.
3082
3083         * MiniBrowser/gtk/BrowserWindow.c:
3084         (webViewCreate): Add WebKitNavigationAction parameter.
3085         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
3086         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
3087         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
3088         (testWebViewCreateNavigationData):
3089         (beforeAll):
3090         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitPolicyClient.cpp:
3091         (createCallback):
3092
3093 2014-07-02  Carlos Garcia Campos  <cgarcia@igalia.com>
3094
3095         [GTK] Do not add forward declaration of class struct for interfaces
3096         https://bugs.webkit.org/show_bug.cgi?id=134297
3097
3098         Reviewed by Martin Robinson.
3099
3100         Add Iface symbol to documentation instead of Class for interfaces.
3101
3102         * gtk/webkitdom.py:
3103         (WebKitDOMDocGeneratorSections.write_section):
3104
3105 2014-07-01  Carlos Garcia Campos  <cgarcia@igalia.com>
3106
3107         [GTK] XPathNSResolver should be exposed as an interface instead of as a class
3108         https://bugs.webkit.org/show_bug.cgi?id=134028
3109
3110         Reviewed by Gustavo Noronha Silva.
3111
3112         Add unit tests to check WebKitDOMXPathNSResolver API when using the
3113         native one and a user provided one.
3114
3115         * Scripts/webkitpy/style/checker.py: Add WebKitDOMXPathNSResolver
3116         to the list of GTK+ public API exceptions.
3117         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Add new files to compilation.
3118         * TestWebKitAPI/Tests/WebKit2Gtk/DOMXPathNSResolverTest.cpp: Added.
3119         (webkitXPathNSResolverLookupNamespaceURI):
3120         (webkitXPathNSResolverDOMXPathNSResolverIfaceInit):
3121         (webkit_xpath_ns_resolver_init):
3122         (webkit_xpath_ns_resolver_class_init):
3123         (WebKitDOMXPathNSResolverTest::create):
3124         (WebKitDOMXPathNSResolverTest::webPageFromArgs):
3125         (WebKitDOMXPathNSResolverTest::evaluateFooChildTextAndCheckResult):
3126         (WebKitDOMXPathNSResolverTest::testXPathNSResolverNative):
3127         (WebKitDOMXPathNSResolverTest::testXPathNSResolverCustom):
3128         (WebKitDOMXPathNSResolverTest::runTest):
3129         (registerTests):
3130         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMXPathNSResolver.cpp: Added.
3131         (runTest):
3132         (testWebKitDOMXPathNSResolverNative):
3133         (testWebKitDOMXPathNSResolverCustom):
3134         (serverCallback):
3135         (beforeAll):
3136         (afterAll):
3137         * gtk/webkitdom.py:
3138         (WebKitDOMDocGeneratorSections.write_section): Add
3139         WebKitDOMXPathNSResolver to the list of interfaces.
3140
3141 2014-07-01  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3142
3143         Fix build break on EFL and GTK ports since r170683
3144         https://bugs.webkit.org/show_bug.cgi?id=134536
3145
3146         Unreviewed, build fix.
3147
3148         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
3149
3150 2014-07-01  Sam Weinig  <sam@webkit.org>
3151
3152         [Cocoa][Mac] WKWebView should automatically set topContentInset when beneath a toolbar
3153         <rdar://problem/17523159>
3154         https://bugs.webkit.org/show_bug.cgi?id=134496
3155
3156         Reviewed by Beth Dakin.
3157
3158         * MiniBrowser/mac/BrowserWindowController.m:
3159         (-[BrowserWindowController windowDidLoad]):
3160         Use the NSFullSizeContentViewWindowMask bit on Yosemite and later to enable toolbar blurring.
3161
3162 2014-07-01  Zan Dobersek  <zdobersek@igalia.com>
3163
3164         [CMake] Add necessary support for building for the Wayland target
3165         https://bugs.webkit.org/show_bug.cgi?id=134160
3166
3167         Reviewed by Darin Adler.
3168
3169         * CMakeLists.txt: Only build the TestNetscapePlugIn target in case
3170         the X11 windowing target is enabled.
3171
3172 2014-07-01  Chris Fleizach  <cfleizach@apple.com>
3173
3174         AX: HTML indeterminate IDL attribute not mapped to checkbox value=2
3175         https://bugs.webkit.org/show_bug.cgi?id=134492
3176
3177         Reviewed by Andreas Kling.
3178
3179         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3180         (AccessibilityUIElement::isIndeterminate):
3181         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3182         (WTR::AccessibilityUIElement::isIndeterminate):
3183
3184 2014-07-01  Daniel Bates  <dabates@apple.com>
3185
3186         Remove unnecessary calls to std::move()
3187         https://bugs.webkit.org/show_bug.cgi?id=134493
3188
3189         Reviewed by Anders Carlsson.
3190
3191         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
3192         (TestWebKitAPI::TEST):
3193         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
3194         (TestWebKitAPI::TEST):
3195
3196 2014-07-01  Pratik Solanki  <psolanki@apple.com>
3197
3198         Unreviewed. Adding myself to the reviewers list to make commit bot happy.
3199
3200         * Scripts/webkitpy/common/config/contributors.json:
3201
3202 2014-07-01  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3203
3204         webkit-patch apply-from-bug / apply-attachment should not ask for credentials if none are required
3205         https://bugs.webkit.org/show_bug.cgi?id=40095
3206
3207         Reviewed by Csaba Osztrogonác.
3208
3209         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3210         (Bugzilla.fetch_attachment_contents): make a first fetch on bugzilla without authentication. If failing, use authentication (similar to fetch_bug_dictionary).
3211         (Bugzilla):
3212         (Bugzilla.bug_id_for_attachment_id): ditto.
3213
3214 2014-07-01  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3215
3216         [webkitpy] Refactor pluralizer in grammar.py
3217         https://bugs.webkit.org/show_bug.cgi?id=133067
3218
3219         Reviewed by Csaba Osztrogonác.
3220
3221         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
3222         (LayoutTestRunner.run_tests):
3223         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3224         (Manager.run):
3225         * Scripts/webkitpy/layout_tests/views/printing.py:
3226         (Printer.print_found):
3227         (Printer.print_workers_and_shards):
3228         (Printer._print_one_line_summary):
3229         * Scripts/webkitpy/test/printer.py:
3230         (Printer.print_result):
3231         * Scripts/webkitpy/tool/bot/feeders.py:
3232         (EWSFeeder.feed):
3233         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3234         (FlakyTestReporter._lookup_bug_for_flaky_test):
3235         * Scripts/webkitpy/tool/bot/irc_command.py:
3236         (Rollout._check_diff_failure):
3237         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
3238         (IRCCommandTest.test_rollout):
3239         * Scripts/webkitpy/tool/commands/download.py:
3240         (AbstractPatchProcessingCommand._process_patch.execute):
3241         (ProcessBugsMixin._fetch_list_of_patches_to_process):
3242         (ProcessURLsMixin._fetch_list_of_patches_to_process):
3243         * Scripts/webkitpy/tool/commands/queries.py:
3244         (WhatBroke.execute):
3245         * Scripts/webkitpy/tool/commands/suggestnominations.py:
3246         (SuggestNominations._print_nominations):
3247         (SuggestNominations._print_counts):
3248         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
3249         (_make_options):
3250         (test_basic):
3251         (test_with_verbose):
3252         * Scripts/webkitpy/tool/commands/upload.py:
3253         (PostCommits.execute):
3254         * Scripts/webkitpy/tool/grammar.py:
3255         (pluralize):
3256         * Scripts/webkitpy/tool/grammar_unittest.py:
3257         (GrammarTest.test_join_with_separators):
3258         (GrammarTest):
3259         (GrammarTest.test_plural):
3260         (GrammarTest.test_pluralize):
3261         * Scripts/webkitpy/tool/multicommandtool.py:
3262         (Command.check_arguments_and_execute):
3263         * Scripts/webkitpy/tool/steps/obsoletepatches.py:
3264         (ObsoletePatches.run):
3265         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
3266         (PrepareChangeLogForRevert._message_for_revert):
3267
3268 2014-06-30  Myles C. Maxfield  <mmaxfield@apple.com>
3269
3270         [iOS] GSFontAddCGFont is deprecated and we use it in DumpRenderTree
3271         https://bugs.webkit.org/show_bug.cgi?id=134133
3272
3273         Reviewed by Simon Fraser.
3274
3275         Replace it with CTFontManagerRegisterGraphicsFont
3276
3277         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3278         * DumpRenderTree/mac/DumpRenderTree.mm:
3279         (activateFontIOS):
3280
3281 2014-06-30  Michael Saboff  <msaboff@apple.com>
3282
3283         Add option to run-jsc-stress-testes to filter out tests that use large heaps
3284         https://bugs.webkit.org/show_bug.cgi?id=134458
3285
3286         Reviewed by Filip Pizlo.
3287
3288         Added new --memory-limited to filter out tests that have large heap usage.
3289         Such tests are either tagged with //@largeHeap or logic is added to their .yaml file.
3290
3291         * Scripts/run-jsc-stress-tests:
3292
3293 2014-06-30  Myles C. Maxfield  <mmaxfield@apple.com>
3294
3295         DRT in iOS sim crashes while loading fonts
3296         https://bugs.webkit.org/show_bug.cgi?id=134451
3297
3298         Reviewed by Geoffrey Garen.
3299
3300         The magic linker symbols had the same name, and were therefore being unified
3301         to a single font file. Then, adding the same file twice was failing.
3302
3303         * DumpRenderTree/mac/DumpRenderTree.mm:
3304         (activateFontsIOS):
3305
3306 2014-06-30  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
3307
3308         Remove Qt cruft from webkitpy
3309         https://bugs.webkit.org/show_bug.cgi?id=134445
3310
3311         Reviewed by Csaba Osztrogonác.
3312
3313         * Scripts/webkitpy/common/config/ports.py:
3314         (DeprecatedPort.port):
3315         (QtPort): Deleted.
3316         (QtPort.build_webkit_command): Deleted.
3317         (QtPort.run_webkit_tests_command): Deleted.
3318         (QtWK2Port): Deleted.
3319         (QtWK2Port.build_webkit_command): Deleted.
3320         (QtWK2Port.run_webkit_tests_command): Deleted.
3321         * Scripts/webkitpy/common/config/ports_unittest.py:
3322         (DeprecatedPortTest): Deleted.
3323         (DeprecatedPortTest.test_qt_port): Deleted.
3324         (DeprecatedPortTest.test_qt_wk2_port): Deleted.
3325
3326 2014-06-29  Yoav Weiss  <yoav@yoav.ws>
3327
3328         Add support for HTMLImageElement's sizes attribute
3329         https://bugs.webkit.org/show_bug.cgi?id=133620
3330
3331         Reviewed by Dean Jackson.
3332
3333         Added an ENABLE_PICTURE_SIZES compile flag.
3334
3335         * Scripts/webkitperl/FeatureList.pm:
3336
3337 2014-06-27  Tim Horton  <timothy_horton@apple.com>
3338
3339         check-webkit-style should check the order of #imports as well as #includes
3340         https://bugs.webkit.org/show_bug.cgi?id=134428
3341
3342         Reviewed by Dan Bernstein.
3343
3344         * Scripts/webkitpy/style/checkers/cpp.py:
3345         Allow "import" in addition to "include", so that the sort order of headers in ObjC files is checked.
3346
3347 2014-06-27  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
3348
3349         [EFL] Remove efl-wk2 from baseline search path
3350         https://bugs.webkit.org/show_bug.cgi?id=134391
3351
3352         Reviewed by Gyuyoung Kim.
3353
3354         As WebKit1 EFL is removed and platform/efl and platform/efl-wk2 baselines and test expectations files
3355         are merged efl-wk2 search path should be removed.
3356
3357         * Scripts/webkitpy/port/base.py:
3358         (Port.test_expectations_file_postion): Added method to determine port test expectations file position in expectations_dict.
3359         * Scripts/webkitpy/port/efl.py:
3360         (EflPort._search_paths): Changed baseline search paths from efl-wk2 -> wk2 -> efl -> generic is changed to: efl -> wk2 -> generic.
3361         (EflPort.test_expectations_file_postion): Added method to determine EFL port specific test expectation file position.
3362         * Scripts/webkitpy/port/port_testcase.py:
3363         (PortTestCase.test_expectations_ordering): Changed constant value to one returned from test_expectations_file_postion().
3364         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
3365         (TestExpectationsTestCase.test_determine_port_from_expectations_path): Removed efl-wk2 test case.
3366         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3367         (TestRebaselineTest.test_baseline_directory): Changed directory name in assertion from platform/efl-wk2 to platform/efl.
3368
3369 2014-06-26  Dan Bernstein  <mitz@apple.com>
3370
3371         prepare-ChangeLog outputs (NS_ENUM): entries for Cocoa enums
3372         https://bugs.webkit.org/show_bug.cgi?id=134387
3373
3374         Reviewed by Tim Horton.
3375
3376         * Scripts/prepare-ChangeLog:
3377         (get_function_line_ranges_for_cpp): Don’t consider {CF,NS}_{ENUM,OPTIONS} as function names.
3378
3379 2014-06-26  Dan Bernstein  <mitz@apple.com>
3380
3381         prepare-ChangeLog mangles Objective-C selectors for methods with parameter types that contain colons
3382         https://bugs.webkit.org/show_bug.cgi?id=134383
3383
3384         Reviewed by Tim Horton.
3385
3386         * Scripts/prepare-ChangeLog:
3387         (method_decl_to_selector): Strip out the return type and parameter types before splitting at
3388         colons.
3389
3390 2014-06-26  Brady Eidson  <beidson@apple.com>
3391
3392         MiniBrowser should support a preference to override the default URL
3393         https://bugs.webkit.org/show_bug.cgi?id=134373
3394
3395         Reviewed by Darin Adler.
3396
3397         * MiniBrowser/mac/AppDelegate.m:
3398         (-[BrowserAppDelegate applicationDidFinishLaunching:]): See if there’s a pref
3399           overriding the default URL, and use it if there is.
3400
3401 2014-06-26  Brent Fulgham  <bfulgham@apple.com>
3402
3403         [Win] Fix potential buffer overrun in DLLLauncher
3404         https://bugs.webkit.org/show_bug.cgi?id=134351
3405         <rdar://problem/17469185>
3406
3407         Reviewed by Darin Adler.
3408
3409         * win/DLLLauncher/DLLLauncherMain.cpp: Correct error
3410         in end-of-buffer calculation.
3411
3412 2014-06-26  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
3413
3414         [EFL] Missing dependency between freetype6 and fontconfig libs.
3415         https://bugs.webkit.org/show_bug.cgi?id=134190
3416
3417         Reviewed by Gyuyoung Kim.
3418
3419         The external dependencies contain the freetype6 and the fontconfig libs.
3420         The fontconfig lib requires freetype, but the dependency is not set in
3421         the efl/jhbuild.modules file. So, during building the external libs,
3422         fontconfig uses the freetype package of the system, while WebKit
3423         binaries will use freetype from the WebKitBuild/Dependency directory.
3424         There are more similar dependencies that were not indicated in the
3425         jhbuild.modules file.
3426
3427         * efl/jhbuild.modules:
3428           Added dependencies between libs.
3429
3430 2014-06-25  Brent Fulgham  <bfulgham@apple.com>
3431
3432         [Win] Expose Cache Information to WinLauncher
3433         https://bugs.webkit.org/show_bug.cgi?id=134318
3434
3435         Reviewed by Dean Jackson.
3436
3437         * WinLauncher/Common.cpp: Update for new dialog.
3438         * WinLauncher/WinLauncher.cpp: Add support for WebCache
3439         and WebCoreStatistics.
3440         * WinLauncher/WinLauncher.h:
3441         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc:
3442         Update for new Cache Dialog.
3443         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props: Link to
3444         WTF.lib
3445         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h: Update
3446         for new Dialog.
3447
3448 2014-06-26  Brent Fulgham  <bfulgham@apple.com>
3449
3450         [Win] Unreviewed gardening. Use consistent line-endings in file.
3451
3452         * WinLauncher/WinLauncher.h: Use '\n' EOL marker, not DOS-style
3453         '\r\n' EOL.
3454
3455 2014-06-25  László Langó  <llango.u-szeged@partner.samsung.com>
3456
3457         [JavaScriptCore] Make build-jsc output format better.
3458         https://bugs.webkit.org/show_bug.cgi?id=133547
3459
3460         Reviewed by Ryosuke Niwa.
3461
3462         * Scripts/build-jsc: Emit built time information on successful builds.
3463         (writeCongrats):
3464         * Scripts/build-webkit: Move formatBuildTime function into webkitdirs.pm.
3465         (cMakeArgsFromFeatures):
3466         (formatBuildTime): Deleted.
3467         * Scripts/webkitdirs.pm:
3468         (formatBuildTime):
3469
3470 2014-06-25  Chris Fleizach  <cfleizach@apple.com>
3471
3472         Add an undo group for each dictated utterance in WebKit
3473         https://bugs.webkit.org/show_bug.cgi?id=134086
3474
3475         Reviewed by Enrica Casucci.
3476
3477         Create a method for creating attributed strings with the undo insertion marker.
3478
3479         * DumpRenderTree/mac/TextInputController.m:
3480         (+[TextInputController isSelectorExcludedFromWebScript:]):
3481         (+[TextInputController webScriptNameForSelector:]):
3482         (-[TextInputController stringWithUndoGroupingInsertion:]):
3483
3484 2014-06-25  Michael Saboff  <msaboff@apple.com>
3485
3486         Provide javascript aware backtrace script for lldb
3487         https://bugs.webkit.org/show_bug.cgi?id=134276
3488
3489         Reviewed by Jer Noble.
3490
3491         * lldb/lldb_webkit.py:
3492         (__lldb_init_module):
3493         (btjs): New scripted command to display a backtrace that shows JavaScript frames with details.
3494
3495 2014-06-25  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
3496
3497         REGRESSION (r170426) Broke two python tests
3498         https://bugs.webkit.org/show_bug.cgi?id=134299
3499
3500         Reviewed by Csaba Osztrogonác.
3501
3502         * Scripts/webkitpy/port/efl.py:
3503         (EflPort._search_paths): Added search path for efl-wk2.
3504
3505 2014-06-25  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
3506
3507         [EFL] Remove WebKit1 related code from scripts
3508         https://bugs.webkit.org/show_bug.cgi?id=134195
3509
3510         Reviewed by Laszlo Gombos.
3511
3512         After removing WebKit1 from EFL port, still there is some code left related to DumpRenderTree, 
3513         EWebLauncher. Also running layout tests does not require adding -2/--webkit-test-runner switch.
3514
3515         * Scripts/run-launcher: MiniBrowser now runs as default without -2 switch.
3516         * Scripts/webkitdirs.pm:
3517         (builtDylibPathForName): Remove reference to libewebkit.so
3518         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3519         (_set_up_derived_options): Script runs WKTR by default.
3520         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3521         (PerfTestsRunner.__init__): Ditto.
3522         * Scripts/webkitpy/port/efl.py:
3523         (EflPort._search_paths): Remove efl-wk2 from baseline search path.
3524         (EflPort.show_results_html_file): Run MiniBrowser as result viewer.
3525
3526 2014-06-25  Laszlo Gombos  <l.gombos@samsung.com>
3527
3528         Remove build guard for progress element
3529         https://bugs.webkit.org/show_bug.cgi?id=134292
3530
3531         Reviewed by Benjamin Poulain.
3532
3533         * Scripts/webkitperl/FeatureList.pm:
3534
3535 2014-06-24  Tomas Popela  <tpopela@redhat.com>
3536
3537         [GTK] Some of DOM bindings macros are misnamed
3538         https://bugs.webkit.org/show_bug.cgi?id=121543
3539
3540         Reviewed by Carlos Garcia Campos.
3541
3542         As we are using WebKitDOM as a namespace we should unify all type macros
3543         to have WEBKIT_DOM_TYPE prefix instead of WEBKIT_TYPE_DOM. Also add
3544         more exceptions to decamelize function in GObject bindings generator
3545         to fix the names of bindings for BR, HR, UL, OL, DL and LI elements.
3546
3547         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeFilterTest.cpp:
3548         * gtk/webkitdom.py:
3549         (WebKitDOMDocGeneratorSections._dom_class_decamelize):
3550         (WebKitDOMDocGeneratorSections.write_section):
3551
3552 2014-06-24  Frédéric Wang  <fred.wang@free.fr>
3553
3554         [EFL] Install Latin Modern Math on the bots
3555         https://bugs.webkit.org/show_bug.cgi?id=134153
3556
3557         Reviewed by Gyuyoung Kim.
3558
3559         * efl/jhbuild.modules: Switch back to https://github.com/ for the webkitgtk-test-fonts.
3560
3561 2014-06-24  Frédéric Wang  <fred.wang@free.fr>
3562
3563         [EFL] [GTK] Use Latin Modern Math in the jhbuild environments.
3564         https://bugs.webkit.org/show_bug.cgi?id=134153
3565
3566         Reviewed by Martin Robinson.
3567
3568         * efl/jhbuild.modules: Use webkitgtk-test-fonts.git instead of the zip archive and upgrade to 0.0.5.
3569         * gtk/jhbuild.modules: Upgrade webkitgtk-test-fonts to 0.0.5.
3570
3571 2014-06-24  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3572
3573         Unreviewed, update my speciality.
3574
3575         * Scripts/webkitpy/common/config/contributors.json:
3576
3577 2014-06-24  Brent Fulgham  <bfulgham@apple.com>
3578
3579         [Win] Clean up and refactor WinLauncher
3580         https://bugs.webkit.org/show_bug.cgi?id=134209
3581
3582         Reviewed by Tim Thorton.
3583
3584         Relanding r170339 and r170340 with correct WinLauncher.h file.
3585
3586         * WinLauncher/Common.cpp: Copied from WinLauncher/WinLauncher.cpp.
3587         (PrintView):
3588         (ToggleMenuItem):
3589         (WndProc):
3590         (BackButtonProc):
3591         (ForwardButtonProc):
3592         (loadURL):
3593         (shouldUseFullDesktop): Deleted.
3594         (SimpleEventListener::SimpleEventListener): Deleted.
3595         (SimpleEventListener::handleEvent): Deleted.
3596         (WinLauncherWebHost::updateAddressBar): Deleted.
3597         (WinLauncherWebHost::didFailProvisionalLoadWithError): Deleted.
3598         (WinLauncherWebHost::QueryInterface): Deleted.
3599         (WinLauncherWebHost::AddRef): Deleted.
3600         (WinLauncherWebHost::Release): Deleted.
3601         (updateMenuItemForHistoryItem): Deleted.
3602         (showLastVisitedSites): Deleted.
3603         (WinLauncherWebHost::didFinishLoadForFrame): Deleted.
3604         (resizeSubViews): Deleted.
3605         (setToDefaultPreferences): Deleted.
3606         (wWinMain): Deleted.
3607         (MyRegisterClass): Deleted.
3608         (LaunchInspector): Deleted.
3609         (NavigateForwardOrBackward): Deleted.
3610         (NavigateToHistory): Deleted.
3611         * WinLauncher/DOMDefaultImpl.cpp: Copied from WinLauncher/DOMDefaultImpl.h.
3612         (DOMEventListener::Release):
3613         (WebScriptObject::WebScriptObject): Deleted.
3614         (WebScriptObject::~WebScriptObject): Deleted.
3615         (WebScriptObject::throwException): Deleted.
3616         (WebScriptObject::callWebScriptMethod): Deleted.
3617         (WebScriptObject::evaluateWebScript): Deleted.
3618         (WebScriptObject::removeWebScriptKey): Deleted.
3619         (WebScriptObject::stringRepresentation): Deleted.
3620         (WebScriptObject::webScriptValueAtIndex): Deleted.
3621         (WebScriptObject::setWebScriptValueAtIndex): Deleted.
3622         (WebScriptObject::setException): Deleted.
3623         (DOMEventListener::throwException): Deleted.
3624         (DOMEventListener::callWebScriptMethod): Deleted.
3625         (DOMEventListener::evaluateWebScript): Deleted.
3626         (DOMEventListener::removeWebScriptKey): Deleted.
3627         (DOMEventListener::stringRepresentation): Deleted.
3628         (DOMEventListener::webScriptValueAtIndex): Deleted.
3629         (DOMEventListener::setWebScriptValueAtIndex): Deleted.
3630         (DOMEventListener::setException): Deleted.
3631         (DOMEventListener::handleEvent): Deleted.
3632         * WinLauncher/DOMDefaultImpl.h:
3633         (WebScriptObject::QueryInterface): Deleted.
3634         (WebScriptObject::AddRef): Deleted.
3635         (WebScriptObject::Release): Deleted.
3636         (DOMObject::QueryInterface): Deleted.
3637         (DOMEventListener::QueryInterface): Deleted.
3638         (DOMEventListener::AddRef): Deleted.
3639         (DOMEventListener::Release): Deleted.
3640         * WinLauncher/WinLauncher.cpp:
3641         (WinLauncher::WinLauncher):
3642         (WinLauncher::init):
3643         (WinLauncher::prepareViews):
3644         (WinLauncher::setFrameLoadDelegate):
3645         (WinLauncher::setUIDelegate):
3646         (WinLauncher::setAccessibilityDelegate):
3647         (WinLauncher::mainFrame):
3648         (WinLauncher::seedInitialDefaultPreferences):
3649         (WinLauncher::setToDefaultPreferences):
3650         (updateMenuItemForHistoryItem):
3651         (WinLauncher::showLastVisitedSites):
3652         (WinLauncher::launchInspector):
3653         (WinLauncher::navigateForwardOrBackward):
3654         (WinLauncher::navigateToHistory):
3655         (WinLauncher::goBack):
3656         (WinLauncher::goForward):
3657         (WinLauncher::loadURL):
3658         (shouldUseFullDesktop): Deleted.
3659         (SimpleEventListener::SimpleEventListener): Deleted.
3660         (SimpleEventListener::handleEvent): Deleted.
3661         (WinLauncherWebHost::updateAddressBar): Deleted.
3662         (WinLauncherWebHost::didFailProvisionalLoadWithError): Deleted.
3663         (WinLauncherWebHost::QueryInterface): Deleted.
3664         (WinLauncherWebHost::AddRef): Deleted.
3665         (WinLauncherWebHost::Release): Deleted.
3666         (showLastVisitedSites): Deleted.
3667         (WinLauncherWebHost::didFinishLoadForFrame): Deleted.
3668         (resizeSubViews): Deleted.
3669         (sub