Tools/ChangeLog

   1 2016-09-02  Jonathan Bedard  <jbedard@apple.com>
   2
   3         Fix --no-sample-on-timeout command line argument
   4         https://bugs.webkit.org/show_bug.cgi?id=161507
   5
   6         Reviewed by Alexey Proskuryakov.
   7
   8         This patch fixes the —no-sample-on-timeout flag and correctly names spindumps as spindump.txt.
   9
  10         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  11         (parse_args): Fixed —-no-sample-on-timeout.
  12         * Scripts/webkitpy/port/apple.py:
  13         (ApplePort.sample_process): Use correct file name.
  14         (ApplePort.spindump_file_path): Spindump and sample file names are different.
  15         * Scripts/webkitpy/port/driver.py:
  16         (Driver._check_for_driver_timeout): Check “sample_on_timeout” flag.
  17         * Scripts/webkitpy/port/mac_unittest.py:
  18         (MacTest.test_spindump): Modified for correct filename.
  19
  20 2016-09-02  Jonathan Bedard  <jbedard@apple.com>
  21
  22         Unreviewed: moved myself to the reviewers list.
  23
  24         * Scripts/webkitpy/common/config/contributors.json:
  25
  26 2016-09-02  Tomas Popela  <tpopela@redhat.com>
  27
  28         [GTK] Fix compiler warning in MiniBrowser
  29         https://bugs.webkit.org/show_bug.cgi?id=161529
  30
  31         We were missing a return statement in decidePermissionRequest() and
  32         also there was unused variable in browserWindowConstructed().
  33
  34         Reviewed by Carlos Garcia Campos.
  35
  36         * MiniBrowser/gtk/BrowserTab.c:
  37         (decidePermissionRequest):
  38         * MiniBrowser/gtk/BrowserWindow.c:
  39         (browserWindowConstructed):
  40
  41 2016-09-01  Dan Bernstein  <mitz@apple.com>
  42
  43         Build fix.
  44
  45         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
  46
  47 2016-09-01  Tim Horton  <timothy_horton@apple.com>
  48
  49         Provide a TestWebKitAPI-wide WKNavigationDelegate to simplify tests
  50         https://bugs.webkit.org/show_bug.cgi?id=161413
  51
  52         Reviewed by Simon Fraser.
  53
  54         Add TestNavigationDelegate, which provides block properties to make
  55         writing tests feel a little more natural (the callbacks can be inline),
  56         and also add WKWebView _test_waitForDidFinishNavigation, so that many
  57         tests don't even need to manually allocate a navigation delegate at all.
  58
  59         Adopt in some of the simpler tests; there are a few navigation delegates
  60         left behind, which we can move to the new model in the future.
  61
  62         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  63         * TestWebKitAPI/Tests/WebKit2/WKBackForwardList.mm:
  64         (TEST):
  65         (-[WKBackForwardListTestNavigationDelegate webView:didFinishNavigation:]): Deleted.
  66         * TestWebKitAPI/Tests/WebKit2Cocoa/AlwaysRevalidatedURLSchemes.mm:
  67         (TEST):
  68         (-[AlwaysRevalidatedURLSchemesDelegate webView:didFinishNavigation:]): Deleted.
  69         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
  70         (animatedResizeWebView):
  71         (-[AnimatedResizeNavigationDelegate _webView:renderingProgressDidChange:]): Deleted.
  72         * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:
  73         (-[AutoLayoutWKWebView initWithFrame:configuration:]):
  74         (-[AutoLayoutWKWebView load:withWidth:expectingContentSize:resettingWidth:]):
  75         (TEST):
  76         (-[AutoLayoutNavigationDelegate webView:didFinishNavigation:]): Deleted.
  77         * TestWebKitAPI/Tests/WebKit2Cocoa/CancelFontSubresource.mm:
  78         (TEST):
  79         (-[CancelFontSubresourceNavigationDelegate webView:didFinishNavigation:]): Deleted.
  80         * TestWebKitAPI/Tests/WebKit2Cocoa/CommandBackForward.mm:
  81         (WebKit2_CommandBackForwardTestWKWebView::SetUp):
  82         (WebKit2_CommandBackForwardTestWKWebView::loadFiles):
  83         (TEST_F):
  84         (-[CommandBackForwardNavigationDelegate webView:didFinishNavigation:]): Deleted.
  85         * TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm:
  86         (expectLinkCount):
  87         (TEST):
  88         (-[DataDetectionNavigationDelegate webView:didFinishNavigation:]): Deleted.
  89         * TestWebKitAPI/Tests/WebKit2Cocoa/FindInPage.mm:
  90         (TEST):
  91         (-[FindInPageNavigationDelegate webView:didFinishNavigation:]): Deleted.
  92         * TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm:
  93         (TEST):
  94         (-[FixedLayoutSizeNavigationDelegate webView:didFinishNavigation:]): Deleted.
  95         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm:
  96         (TEST):
  97         (-[DatabaseProcessKillNavigationDelegate webView:didFinishNavigation:]): Deleted.
  98         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm:
  99         (-[IndexedDBNavigationDelegate webView:didFinishNavigation:]): Deleted.
 100         * TestWebKitAPI/Tests/WebKit2Cocoa/ProvisionalURLNotChange.mm:
 101         (TEST):
 102         (-[ProvisionalURLNotChangeController webView:didFinishNavigation:]): Deleted.
 103         (-[ProvisionalURLNotChangeController webView:didFailProvisionalNavigation:withError:]): Deleted.
 104         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
 105         (RequiresUserActionForPlaybackTest::createWebView):
 106         (RequiresUserActionForPlaybackTest::testVideoWithAudio):
 107         (RequiresUserActionForPlaybackTest::testVideoWithoutAudio):
 108         (RequiresUserActionForPlaybackTest::testAudioOnly):
 109         (-[RequiresUserActionForPlaybackNavigationDelegate webView:didFinishNavigation:]): Deleted.
 110         * TestWebKitAPI/Tests/WebKit2Cocoa/ShrinkToFit.mm:
 111         (TEST):
 112         (-[ShrinkToFitNavigationDelegate webView:didFinishNavigation:]): Deleted.
 113         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
 114         (TEST):
 115         (webViewForScriptMessageHandlerMultipleHandlerRemovalTest):
 116         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentWorld.mm:
 117         (TEST):
 118         (-[SimpleDelegate webView:didFinishNavigation:]): Deleted.
 119         * TestWebKitAPI/Tests/WebKit2Cocoa/WKPDFViewResizeCrash.mm:
 120         (TEST):
 121         (-[WKPDFViewResizeNavigationDelegate webView:didFinishNavigation:]): Deleted.
 122         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm:
 123         (TEST):
 124         (-[EvaluateJavaScriptNavigationDelegate webView:didFinishNavigation:]): Deleted.
 125         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewTextInput.mm:
 126         (TEST):
 127         (-[DummyNavigationDelegate webView:didFinishNavigation:]): Deleted.
 128         * TestWebKitAPI/cocoa/TestNavigationDelegate.h: Added.
 129         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm: Added.
 130         (-[TestNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
 131         (-[TestNavigationDelegate webView:didFinishNavigation:]):
 132         (-[TestNavigationDelegate _webView:renderingProgressDidChange:]):
 133         (-[TestNavigationDelegate waitForDidFinishNavigation]):
 134         (-[WKWebView _test_waitForDidFinishNavigation]):
 135
 136 2016-09-01  Ricky Mondello  <rmondello@apple.com>
 137
 138         YouTube Flash plug-in replacement facility should not insert showinfo=0 into iframe URLs
 139         https://bugs.webkit.org/show_bug.cgi?id=161478
 140         <rdar://problem/28050847>
 141
 142         Reviewed by Eric Carlson.
 143
 144         * TestWebKitAPI/Tests/WebCore/YouTubePluginReplacement.cpp:
 145         (TestWebKitAPI::TEST_F): Update expected results.
 146
 147 2016-09-01  Anders Carlsson  <andersca@apple.com>
 148
 149         add BlockPtr::fromCallable
 150         https://bugs.webkit.org/show_bug.cgi?id=161504
 151
 152         Reviewed by Tim Horton.
 153
 154         Add a test.
 155
 156         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 157         * TestWebKitAPI/Tests/WTF/BlockPtr.mm: Added.
 158         (TestWebKitAPI::TEST):
 159
 160 2016-09-01  Alex Christensen  <achristensen@webkit.org>
 161
 162         URLParser should handle . and .. in URL paths
 163         https://bugs.webkit.org/show_bug.cgi?id=161443
 164
 165         Reviewed by Brady Eidson.
 166
 167         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
 168         (TestWebKitAPI::eq):
 169         (TestWebKitAPI::TEST_F):
 170
 171 2016-09-01  Commit Queue  <commit-queue@webkit.org>
 172
 173         Unreviewed, rolling out r205295 and r205303.
 174         https://bugs.webkit.org/show_bug.cgi?id=161505
 175
 176         Broke the iOS build (Requested by ryanhaddad on #webkit).
 177
 178         Reverted changesets:
 179
 180         "Refactor MobileMiniBrowser into an application framework to
 181         allow external XCTesting"
 182         https://bugs.webkit.org/show_bug.cgi?id=161462
 183         http://trac.webkit.org/changeset/205295
 184
 185         "Unreviewed build-fix; don't specify an explicit deployment
 186         target."
 187         http://trac.webkit.org/changeset/205303
 188
 189 2016-09-01  Ricky Mondello  <rmondello@apple.com>
 190
 191         YouTube Flash plug-in replacement facility should more gracefully handle malformed queries
 192         https://bugs.webkit.org/show_bug.cgi?id=161476
 193         <rdar://problem/28050847>
 194
 195         Reviewed by Eric Carlson.
 196
 197         * TestWebKitAPI/Tests/WebCore/YouTubePluginReplacement.cpp:
 198         (TestWebKitAPI::TEST_F): New tests. The first two and second-to-last test cases cover the "malformed" query
 199             logic. A few other tests are added, too.
 200
 201 2016-09-01  Jer Noble  <jer.noble@apple.com>
 202
 203         Unreviewed build-fix; don't specify an explicit deployment target.
 204
 205         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
 206
 207 2016-08-31  Jer Noble  <jer.noble@apple.com>
 208
 209         Refactor MobileMiniBrowser into an application framework to allow external XCTesting
 210         https://bugs.webkit.org/show_bug.cgi?id=161462
 211
 212         Reviewed by Eric Carlson.
 213
 214         XCTest targets need to be in the same project as the application which they're testing. To facilitate
 215         having external projects with XCTest targets, move the application's implementation into a framework
 216         that can be included with a bare-bones application shell for testing.
 217
 218         Simultaneously, add the ability to load files from within the new framework's bundle by using a
 219         'bundle:/' URL scheme. Update the tests to use this new bundle URL and remove the dependency on
 220         an external server for testing.
 221
 222         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
 223         * MobileMiniBrowser/MobileMiniBrowser/Base.lproj/LaunchScreen.storyboard:
 224         * MobileMiniBrowser/MobileMiniBrowser/Info.plist:
 225         * MobileMiniBrowser/MobileMiniBrowser/main.m:
 226         * MobileMiniBrowser/MobileMiniBrowserFramework/AppDelegate.h: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/AppDelegate.h.
 227         * MobileMiniBrowser/MobileMiniBrowserFramework/AppDelegate.m: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/AppDelegate.m.
 228         (-[AppDelegate application:didFinishLaunchingWithOptions:]): Manually instantiate the main view
 229             controller from the framework's bundle.
 230         * MobileMiniBrowser/MobileMiniBrowserFramework/Assets.xcassets/AppIcon.appiconset/Contents.json: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/Assets.xcassets/AppIcon.appiconset/Contents.json.
 231         * MobileMiniBrowser/MobileMiniBrowserFramework/Base.lproj/Main.storyboard: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/Base.lproj/Main.storyboard.
 232         * MobileMiniBrowser/MobileMiniBrowserFramework/Info.plist: Added.
 233         * MobileMiniBrowser/MobileMiniBrowserFramework/MobileMiniBrowser.h: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/AppDelegate.h.
 234         * MobileMiniBrowser/MobileMiniBrowserFramework/TabViewController.h: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/TabViewController.h.
 235         * MobileMiniBrowser/MobileMiniBrowserFramework/TabViewController.m: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/TabViewController.m.
 236         * MobileMiniBrowser/MobileMiniBrowserFramework/WebViewController.h: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/WebViewController.h.
 237         * MobileMiniBrowser/MobileMiniBrowserFramework/WebViewController.m: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/WebViewController.m.
 238         (+[NSURL __bundleURLForFileURL:bundle:]): Add utility method.
 239         (+[NSURL __fileURLForBundleURL:bundle:]): Ditto.
 240         (-[WebViewController navigateTo:]): Support loading "bundle:/" URLs which are really just "file:" URLs
 241             pointing to the framework's resources directory.
 242         (-[WebViewController observeValueForKeyPath:ofObject:change:context:]): Ditto.
 243         * MobileMiniBrowser/MobileMiniBrowserUITests/MobileMiniBrowserUITests.m:
 244         (-[MobileMiniBrowserUITests testBasicVideoPlayback]):
 245
 246 2016-09-01  Carlos Garcia Campos  <cgarcia@igalia.com>
 247
 248         Unreviewed. Fix webkitpy unit tests after r205280.
 249
 250         * Scripts/webkitpy/style/checker_unittest.py:
 251         (GlobalVariablesTest.test_path_rules_specifier):
 252
 253 2016-08-31  Carlos Garcia Campos  <cgarcia@igalia.com>
 254
 255         [GTK] Move GObject DOM bindings to WebKit2 layer and stop auto generating them
 256         https://bugs.webkit.org/show_bug.cgi?id=161438
 257
 258         Reviewed by Michael Catanzaro.
 259
 260         Remove scripts related to the GObject DOM bindings auto-generation.
 261
 262         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
 263         (RunGtkAPITests.getText2):
 264         (TestFactory.__init__):
 265         (RunWebKit1Tests): Deleted.
 266         (RunWebKit1Tests.start): Deleted.
 267         (RunWebKit1LeakTests): Deleted.
 268         (RunWebKit1LeakTests.start): Deleted.
 269         (RunAndUploadPerfTests): Deleted.
 270         (RunAndUploadPerfTests.start): Deleted.
 271         (BuildAndRemoteJSCTestsFactory.__init__): Deleted.
 272         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
 273         (BuildStepsTest.test_unnecessary_expected_results):
 274         (RunAndUploadPerfTestsTest): Deleted.
 275         (RunAndUploadPerfTestsTest.assertResults): Deleted.
 276         (RunAndUploadPerfTestsTest.test_success): Deleted.
 277         (RunAndUploadPerfTestsTest.test_tests_failed): Deleted.
 278         (RunAndUploadPerfTestsTest.test_build_bad_build): Deleted.
 279         (RunAndUploadPerfTestsTest.test_build_bad_source_json): Deleted.
 280         (RunAndUploadPerfTestsTest.test_build_bad_marge): Deleted.
 281         (RunAndUploadPerfTestsTest.test_build_bad_failed_uploading): Deleted.
 282         (RunAndUploadPerfTestsTest.test_build_bad_preparation): Deleted.
 283         (RunAndUploadPerfTestsTest.test_buildbot_timeout): Deleted.
 284         (RunBenchmarkTest): Deleted.
 285         (RunBenchmarkTest.assertResults): Deleted.
 286         (RunBenchmarkTest.test_success): Deleted.
 287         * Scripts/run-bindings-tests:
 288         (main):
 289         * Scripts/webkitpy/style/checker.py:
 290         * gtk/check-for-webkitdom-api-breaks: Removed.
 291         * gtk/generate-gtkdoc:
 292         * gtk/webkitdom.py: Removed.
 293
 294 2016-08-31  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
 295
 296         [EFL] Small clean up in MiniBrowser
 297         https://bugs.webkit.org/show_bug.cgi?id=161428
 298
 299         Reviewed by Yusuke Suzuki.
 300
 301         This patch resizes MiniBrowser, add *char* constants for scheme,
 302         does line breaking, and remove unnecessary spaces.
 303
 304         * MiniBrowser/efl/main.c:
 305         (on_mouse_wheel):
 306         (history_list_hide):
 307         (script_execute_callback):
 308         (on_key_down):
 309         (on_url_changed):
 310         (on_error):
 311         (on_color_picker_request):
 312         (url_from_user_input):
 313         (url_load_from_user_input):
 314         (on_back_button_clicked):
 315         (on_search_case_option_changed):
 316         (on_search_word_start_option_changed):
 317         (on_list_item_select):
 318         (navigation_button_longpress_process):
 319         (on_navigation_policy_decision):
 320         (window_create):
 321         (parse_cookies_policy):
 322
 323 2016-08-31  Alex Christensen  <achristensen@webkit.org>
 324
 325         Implement IPv6 parsing in URLParser
 326         https://bugs.webkit.org/show_bug.cgi?id=161390
 327
 328         Reviewed by Darin Adler.
 329
 330         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
 331         (TestWebKitAPI::TEST_F):
 332         (TestWebKitAPI::checkURLDifferences):
 333
 334 2016-08-31  Brady Eidson  <beidson@apple.com>
 335
 336         WK2 Gamepad provider on iOS.
 337         https://bugs.webkit.org/show_bug.cgi?id=161412
 338
 339         Reviewed by Tim Horton.
 340
 341         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
 342
 343 2016-08-30  Ricky Mondello  <rmondello@apple.com>
 344
 345         YouTubePluginReplacementTest's URL transformation logic should have tests
 346         https://bugs.webkit.org/show_bug.cgi?id=161406
 347         <rdar://problem/28050847>
 348
 349         Reviewed by Eric Carlson.
 350
 351         Add some very basic tests. Future patches should expand on these to find and fix bugs.
 352
 353         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add YouTubePluginReplacement.cpp.
 354         * TestWebKitAPI/Tests/WebCore/YouTubePluginReplacement.cpp: Added.
 355         (TestWebKitAPI::test): Added.
 356         (TestWebKitAPI::TEST_F): Added.
 357
 358 2016-08-30  Brady Eidson  <beidson@apple.com>
 359
 360         GameController.framework backend for gamepad API.
 361         https://bugs.webkit.org/show_bug.cgi?id=161086
 362
 363         Reviewed by Alex Christensen.
 364
 365         * MiniBrowser/mac/AppDelegate.m:
 366         (-[BrowserAppDelegate awakeFromNib]):
 367
 368         * MiniBrowser/mac/SettingsController.h:
 369         * MiniBrowser/mac/SettingsController.m:
 370         (-[SettingsController _populateMenu]):
 371         (-[SettingsController validateMenuItem:]):
 372         (-[SettingsController usesGameControllerFramework]):
 373         (-[SettingsController toggleUsesGameControllerFramework:]):
 374
 375 2016-08-30  Brent Fulgham  <bfulgham@apple.com>
 376
 377         Use of uninitialised memory in TransformationMatrx::blend4()
 378         https://bugs.webkit.org/show_bug.cgi?id=134621
 379         <rdar://problem/27337539>
 380
 381         Reviewed by Dean Jackson.
 382
 383         Change is based on the Blink change (patch by <alancutter@chromium.org>):
 384         <https://src.chromium.org/viewvc/blink?revision=177453&view=revision>
 385
 386         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 387         * TestWebKitAPI/Tests/WebCore/TransformationMatrix.cpp: Added.
 388         (TestWebKitAPI::TEST):
 389
 390 2016-08-30  Alex Christensen  <achristensen@webkit.org>
 391
 392         URLParser should handle relative URLs that start with //
 393         https://bugs.webkit.org/show_bug.cgi?id=161364
 394
 395         Reviewed by Darin Adler.
 396
 397         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
 398         (TestWebKitAPI::checkRelativeURL):
 399         (TestWebKitAPI::TEST_F):
 400
 401 2016-08-29  Aakash Jain  <aakash_jain@apple.com>
 402
 403         EWS patch status page should indicate bot corresponding to each status message
 404         https://bugs.webkit.org/show_bug.cgi?id=161280
 405
 406         Reviewed by Alexey Proskuryakov.
 407
 408         * QueueStatusServer/templates/patch.html: Formatting changes.
 409
 410 2016-08-29  Aakash Jain  <aakash_jain@apple.com>
 411
 412         EWS should indicate which bot processed the patch
 413         https://bugs.webkit.org/show_bug.cgi?id=161222
 414
 415         Reviewed by Alexey Proskuryakov.
 416
 417         * QueueStatusServer/handlers/statusbubble.py:
 418         (StatusBubble._build_bubble): Remove the bot id from bubbles as it is confusing.
 419         bot ids are now displayed in patch status page.
 420
 421 2016-08-29  Alex Christensen  <achristensen@webkit.org>
 422
 423         URLParser should parse about:blank
 424         https://bugs.webkit.org/show_bug.cgi?id=161324
 425
 426         Reviewed by Brady Eidson.
 427
 428         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
 429         (TestWebKitAPI::TEST_F):
 430
 431 2016-08-29  JF Bastien  <jfbastien@apple.com>
 432
 433         Bug 161165 - check-webkit-style doesn't understand macros containing `else` or labels
 434         https://bugs.webkit.org/show_bug.cgi?id=161165
 435
 436         Reviewed by Geoffrey Garen.
 437
 438         Fix handling of `else` in a macro. Don't handle labels in a macro:
 439         the checker is already pretty messy in that area and it should be
 440         a rare thing.
 441
 442         * Scripts/webkitpy/style/checkers/cpp.py:
 443         (check_braces):
 444         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
 445         (CppStyleTest.test_else_clause_not_on_same_line_as_else):
 446
 447 2016-08-29  Alex Christensen  <achristensen@webkit.org>
 448
 449         API test URLParserTest.ParserFailures failing ASSERT_NOT_REACHED
 450         https://bugs.webkit.org/show_bug.cgi?id=161317
 451
 452         Reviewed by Brady Eidson.
 453
 454         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
 455         (TestWebKitAPI::TEST_F):
 456
 457 2016-08-29  Jer Noble  <jer.noble@apple.com>
 458
 459         Unreviewed gardening; only build MiniBrowser against iOS SDK targets.
 460
 461         * Makefile:
 462
 463 2016-08-29  Jonathan Bedard  <jbedard@apple.com>
 464
 465         Sample Process on notifyDone timed out
 466         https://bugs.webkit.org/show_bug.cgi?id=161063
 467
 468         Reviewed by Darin Adler.
 469
 470         * Scripts/webkitpy/port/driver.py:
 471         (Driver._check_for_driver_timeout):
 472         * WebKitTestRunner/InjectedBundle/TestRunner.cpp: Call sample_process during notifyDone timeouts.
 473         (WTR::TestRunner::waitToDumpWatchdogTimerFired):
 474         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm: Log pid and name for testing harness.
 475
 476 2016-08-29  Jonathan Bedard  <jbedard@apple.com>
 477
 478         Check-webkit-style does not work with Objective-C blocks
 479         https://bugs.webkit.org/show_bug.cgi?id=161247
 480
 481         Reviewed by Darin Adler.
 482
 483         * Scripts/webkitpy/style/checkers/cpp.py:
 484         (regex_for_lambda_functions): Changed to regex_for_lambdas_and_blocks.
 485         (regex_for_lambdas_and_blocks): Added check for Objective-C blocks.
 486         (check_spacing_for_function_call): Pass file state for lambda check.
 487         (check_spacing): Pass file state for lambda check.
 488         (check_braces): Pass file state for lambda check.
 489         (check_style): Pass file state for lambda check.
 490         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
 491         (CppStyleTest.test_cpp_lambda_functions): Changed from ‘test_lambda_functions’.
 492         (CppStyleTest.test_objective_c_block): Tests Objective-C blocks.
 493         (CppStyleTest.test_lambda_functions): Changed to ‘test_cpp_lambda_functions’.
 494
 495 2016-08-29  Aakash Jain  <aakash_jain@apple.com>
 496
 497         EWS patch status page should indicate bot corresponding to each status message
 498         https://bugs.webkit.org/show_bug.cgi?id=161280
 499
 500         Reviewed by Alexey Proskuryakov.
 501
 502         * QueueStatusServer/templates/patch.html: Added bot_id in the template so that bot id is displayed
 503         for each status message.
 504         * QueueStatusServer/stylesheets/common.css:
 505         (.status-bot): Added corresponding stylesheet class.
 506
 507 2016-08-29  Per Arne Vollan  <pvollan@apple.com>
 508
 509         Attempt to fix Windows build after r205090.
 510
 511         Unreviewed build fix.
 512
 513         * DumpRenderTree/win/DRTDataObject.cpp:
 514         (cfFileNameWFormat):
 515         (cfUrlWFormat):
 516
 517 2016-08-27  Alex Christensen  <achristensen@webkit.org>
 518
 519         URLParser should parse relative URLs
 520         https://bugs.webkit.org/show_bug.cgi?id=161282
 521
 522         Reviewed by Darin Adler.
 523
 524         * TestWebKitAPI/Tests/WTF/StringView.cpp:
 525         (TestWebKitAPI::TEST):
 526         Added some tests for the new operator=.
 527         Test saving iterators, restoring iterators, and even assigning iterators to new CodePoints objects.
 528         Using the same iterator to iterate multiple objects is bad practice, but it's possible and now tested.
 529         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
 530         (TestWebKitAPI::checkURL):
 531         (TestWebKitAPI::TEST_F):
 532         (TestWebKitAPI::checkRelativeURL):
 533         (TestWebKitAPI::checkURLDifferences):
 534         (TestWebKitAPI::shouldFail):
 535         Add some relative URL tests.
 536
 537 2016-08-27  Jonathan Bedard  <jbedard@apple.com>
 538
 539         WTR needs an implementation of setAutomaticLinkDetectionEnabled
 540         https://bugs.webkit.org/show_bug.cgi?id=87162
 541
 542         Reviewed by Darin Adler.
 543
 544         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Added setAutomaticLinkDetectionEnabled binding.
 545         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
 546         (WTR::InjectedBundle::beginTesting): Set automatic link detection to false by default.
 547         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
 548         (WTR::TestRunner::setAutomaticLinkDetectionEnabled): Added setAutomaticLinkDetectionEnabled definition.
 549         * WebKitTestRunner/InjectedBundle/TestRunner.h: Added setAutomaticLinkDetectionEnabled declaration.
 550
 551 2016-08-27  Joseph Pecoraro  <pecoraro@apple.com>
 552
 553         Web Inspector: Make localizedString.js diff and commit friendly (UTF16 -> UTF8)
 554         https://bugs.webkit.org/show_bug.cgi?id=28685
 555         <rdar://problem/16460975>
 556
 557         Reviewed by Darin Adler.
 558
 559         * Scripts/extract-localizable-js-strings:
 560         * Scripts/update-webkit-localizable-strings:
 561         WebInspectorUI localizedStrings.js is now UTF-8. Other clients of
 562         this script still use UTF-16, so keep that the default.
 563
 564 2016-08-27  Alexey Proskuryakov  <ap@apple.com>
 565
 566         REGRESSION (r204052): Popovers on bot watcher's dashboard are broken
 567         https://bugs.webkit.org/show_bug.cgi?id=161254
 568
 569         Reviewed by Darin Adler.
 570
 571         Simplify the CSS. My understanding that the CSS was correct, and the root cause
 572         is tracked in bug 160478.
 573
 574         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Popover.css:
 575
 576 2016-08-27  Simon Fraser  <simon.fraser@apple.com>
 577
 578         Add run-webkit-tests --print-expectations to show expectations for all or a subset of tests
 579         https://bugs.webkit.org/show_bug.cgi?id=161217
 580
 581         Reviewed by Ryosuke Niwa.
 582
 583         "run-webkit-tests --print-expectations" runs the same logic as running the tests, but
 584         dumps out the lists of tests that would be run and skipped, and, for each, the entry
 585         in TestExpectations that determines the expected outcome of the test.
 586
 587         This is an improved version of webkit-patch print-expectations.
 588
 589         See bug for sample output.
 590
 591         * Scripts/webkitpy/layout_tests/controllers/manager.py:
 592         (Manager._print_expectations_for_subset): Print out the list of tests and expected
 593         outcome for some subset of tests.
 594         (Manager.print_expectations): Do the same splitting by device class that running tests
 595         does, and for each subset of tests, call _print_expectations_for_subset.
 596         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
 597         (TestExpectationParser.expectation_for_skipped_test): Set the flag
 598         expectation_line.not_applicable_to_current_platform
 599         (TestExpectationLine.__init__): Init not_applicable_to_current_platform to False
 600         (TestExpectationLine.expected_behavior): line.expectation is ['PASS'] by default,
 601         even for skipped tests. This function returns a list relevant for display, taking the skipped
 602         modifier into account.
 603         (TestExpectationLine.create_passing_expectation): expectations is normally a list, not a set.
 604         (TestExpectations.readable_filename_and_line_number): Return something printable for
 605         lines with and without filenames
 606         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
 607         (main): Handle options.print_expectations
 608         (parse_args): Add support for --print-expectations
 609         (_print_expectations):
 610         * Scripts/webkitpy/port/ios.py:
 611         (IOSSimulatorPort.default_child_processes): Make this a debug log.
 612
 613 2016-08-26  Dan Bernstein  <mitz@apple.com>
 614
 615         Keep trying to fix the build after r205057.
 616
 617         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
 618
 619 2016-08-26  Dan Bernstein  <mitz@apple.com>
 620
 621         Keep trying to fix the build after r205057.
 622
 623         * MobileMiniBrowser/MobileMiniBrowser/AppDelegate.m: Don’t try to import nonexistent
 624           config.h. This file is only meant to be built with Xcode anyway.
 625         * MobileMiniBrowser/MobileMiniBrowser/Base.lproj/LaunchScreen.storyboard: Make this compile
 626           with Xcode 7.3 and deploy to iOS 9.0.
 627         * MobileMiniBrowser/MobileMiniBrowser/Base.lproj/Main.storyboard: Ditto.
 628         * MobileMiniBrowser/MobileMiniBrowser/TabViewController.m: Don’t try to import config.h.
 629         * MobileMiniBrowser/MobileMiniBrowser/WebViewController.m: Ditto.
 630
 631 2016-08-26  Dan Bernstein  <mitz@apple.com>
 632
 633         Start trying to fix the build after r205057.
 634
 635         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
 636
 637 2016-08-26  Alexey Proskuryakov  <ap@apple.com>
 638
 639         Remove Yosemite Leaks from the flakiness dashboard
 640         https://bugs.webkit.org/show_bug.cgi?id=161253
 641
 642         Reviewed by Anders Carlsson.
 643
 644         * TestResultServer/static-dashboards/builders.jsonp:
 645
 646 2016-08-26  Sam Weinig  <sam@webkit.org>
 647
 648         Remove support for ENABLE_LEGACY_WEB_AUDIO
 649         https://bugs.webkit.org/show_bug.cgi?id=161262
 650
 651         Reviewed by Anders Carlsson.
 652
 653         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
 654
 655 2016-08-26  Jer Noble  <jer.noble@apple.com>
 656
 657         Add a test harness for running UI tests on the iOS Simulator
 658         https://bugs.webkit.org/show_bug.cgi?id=161265
 659
 660         Reviewed by Simon Fraser.
 661
 662         Add a new iOS Simulator application which uses WKWebView to implement a basic browser, and which
 663         can serve as a test harness for WebKit UI tests.
 664
 665         Also add a basic media playback test which verifies that a <video> element will begin playing in
 666         fullscreen on an iPhone device, but will play inline on an iPad device.
 667
 668         * Makefile: Add MobileMiniBrowser as a Module for iOS builds.
 669         * MobileMiniBrowser/Configurations/Base.xcconfig: Added.
 670         * MobileMiniBrowser/Configurations/DebugRelease.xcconfig: Added.
 671         * MobileMiniBrowser/Configurations/MobileMiniBrowser.xcconfig: Added.
 672         * MobileMiniBrowser/Makefile: Added.
 673         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj: Added.
 674         * MobileMiniBrowser/MobileMiniBrowser/AppDelegate.h: Added.
 675         * MobileMiniBrowser/MobileMiniBrowser/AppDelegate.m: Added.
 676         (-[AppDelegate application:didFinishLaunchingWithOptions:]):
 677         (-[AppDelegate applicationWillResignActive:]):
 678         (-[AppDelegate applicationDidEnterBackground:]):
 679         (-[AppDelegate applicationWillEnterForeground:]):
 680         (-[AppDelegate applicationDidBecomeActive:]):
 681         (-[AppDelegate applicationWillTerminate:]):
 682         * MobileMiniBrowser/MobileMiniBrowser/Assets.xcassets/AppIcon.appiconset/Contents.json: Added.
 683         * MobileMiniBrowser/MobileMiniBrowser/Base.lproj/LaunchScreen.storyboard: Added.
 684         * MobileMiniBrowser/MobileMiniBrowser/Base.lproj/Main.storyboard: Added.
 685         * MobileMiniBrowser/MobileMiniBrowser/Info.plist: Added.
 686         * MobileMiniBrowser/MobileMiniBrowser/TabViewController.h: Added.
 687         * MobileMiniBrowser/MobileMiniBrowser/TabViewController.m: Added.
 688         (-[TabViewController dealloc]):
 689         (-[TabViewController viewDidLoad]):
 690         (-[TabViewController observeValueForKeyPath:ofObject:change:context:]):
 691         (-[TabViewController tableView:cellForRowAtIndexPath:]):
 692         (-[TabViewController tableView:numberOfRowsInSection:]):
 693         (-[TabViewController numberOfSectionsInTableView:]):
 694         (-[TabViewController tableView:canEditRowAtIndexPath:]):
 695         (-[TabViewController tableView:canMoveRowAtIndexPath:]):
 696         (-[TabViewController tableView:commitEditingStyle:forRowAtIndexPath:]):
 697         (-[TabViewController tableView:didSelectRowAtIndexPath:]):
 698         * MobileMiniBrowser/MobileMiniBrowser/WebViewController.h: Added.
 699         * MobileMiniBrowser/MobileMiniBrowser/WebViewController.m: Added.
 700         (-[WebViewController viewDidLoad]):
 701         (-[WebViewController didReceiveMemoryWarning]):
 702         (-[WebViewController reload:]):
 703         (-[WebViewController goBack:]):
 704         (-[WebViewController goForward:]):
 705         (-[WebViewController urlFieldEditingBegan:]):
 706         (-[WebViewController navigateTo:]):
 707         (-[WebViewController showTabs:]):
 708         (-[WebViewController selectWebViewAtIndex:]):
 709         (-[WebViewController removeWebViewAtIndex:]):
 710         (-[WebViewController addWebView]):
 711         (-[WebViewController createWebView]):
 712         (-[WebViewController removeWebView:]):
 713         (-[WebViewController setCurrentWebView:]):
 714         (-[WebViewController webView:didFailNavigation:withError:]):
 715         (-[WebViewController observeValueForKeyPath:ofObject:change:context:]):
 716         * MobileMiniBrowser/MobileMiniBrowser/main.m: Added.
 717         (main):
 718         * MobileMiniBrowser/MobileMiniBrowserUITests/Info.plist: Added.
 719         * MobileMiniBrowser/MobileMiniBrowserUITests/MobileMiniBrowserUITests.m: Added.
 720         (-[MobileMiniBrowserUITests setUp]):
 721         (-[MobileMiniBrowserUITests tearDown]):
 722         (-[MobileMiniBrowserUITests testBasicVideoPlayback]):
 723
 724 2016-08-26  Aakash Jain  <aakash_jain@apple.com>
 725
 726         webkit-queues queue-status page should should list more recent statuses
 727         https://bugs.webkit.org/show_bug.cgi?id=161220
 728
 729         Reviewed by Daniel Bates.
 730
 731         * QueueStatusServer/handlers/queuestatus.py:
 732         (QueueStatus._fetch_statuses): Increase the number of recent statuses from 15 to 50.
 733
 734 2016-08-26  Dan Bernstein  <mitz@apple.com>
 735
 736         [Cocoa] Infinite recursion calling -charValue on a WKNSNumber
 737         https://bugs.webkit.org/show_bug.cgi?id=161258
 738
 739         Reviewed by Anders Carlsson.
 740
 741         * TestWebKitAPI/Tests/WebKit2Cocoa/WKNSNumber.mm:
 742         (TestWebKitAPI::TEST):
 743
 744 2016-08-26  Csaba Osztrogonác  <ossy@webkit.org>
 745
 746         Fix the ENABLE(WEBASSEMBLY) build on Linux
 747         https://bugs.webkit.org/show_bug.cgi?id=161197
 748
 749         Reviewed by Mark Lam.
 750
 751         * Scripts/build-jsc:
 752
 753 2016-08-26  Carlos Alberto Lopez Perez  <clopez@igalia.com>
 754
 755         [GTK] run-gtk-tests should use the driver environment for checking the accessibility bus
 756         https://bugs.webkit.org/show_bug.cgi?id=161149
 757
 758         Reviewed by Carlos Garcia Campos.
 759
 760         Add a new function for waiting for the accesibility bus. It sets
 761         the test environment variables before starting the GLib mainloop.
 762         And restores the previous environment after it has finished.
 763         It also adds a timeout (5 seconds) to abort in case it has not
 764         been able to detect the accesibility bus before the timeout expires.
 765
 766         * Scripts/run-gtk-tests:
 767         (TestRunner):
 768         (TestRunner._wait_for_accessibility_bus):
 769         (TestRunner._wait_for_accessibility_bus.timeout_accessibility_bus):
 770         (TestRunner._start_accessibility_daemons):
 771         (TestRunner._get_tests_from_google_test_suite): Run this command also with the driver test environment.
 772
 773 2016-08-26  Per Arne Vollan  <pvollan@apple.com>
 774
 775         [Win] Warning fix.
 776         https://bugs.webkit.org/show_bug.cgi?id=161236
 777
 778         Reviewed by Brent Fulgham.
 779
 780         The & operator in the Test struct has no body.
 781
 782         * TestWebKitAPI/Tests/WTF/Vector.cpp:
 783         (TestWebKitAPI::TEST):
 784
 785 2016-08-26  Carlos Alberto Lopez Perez  <clopez@igalia.com>
 786
 787         [GTK] run-gtk-tests should use webkitpy.port.gtk and webkitpy.port.xvfbdriver
 788         https://bugs.webkit.org/show_bug.cgi?id=160736
 789
 790         Reviewed by Carlos Garcia Campos.
 791
 792         This plugs run-gtk-tests into the webkitpy testing infrastructure.
 793         As a benefit of this, run-gtk-tests now can be executed over any of
 794         the existing supported gtk test display servers (xvfb, weston-over-xvfb,
 795         or native xorg). A new command line switch --wayland is added for
 796         run-gtk-tests.
 797
 798         * Scripts/run-gtk-tests:
 799         (TestRunner.__init__): Remove the --display command line switch, its not longer useful.
 800         Add a --wayland command line switch.
 801         (TestRunner._start_accessibility_daemons):
 802         (TestRunner):
 803         (TestRunner.__init__):
 804         (TestRunner._run_xvfb): Deleted.
 805         (TestRunner._create_driver):
 806         (TestRunner._setup_testing_environment): Delete the environment variable definitions that
 807         are now done by driver._setup_environ_for_test().
 808         (TestRunner._tear_down_testing_environment):
 809         * Scripts/webkitpy/port/driver.py:
 810         (Driver.__init__): Define self._server_name in the constructor of the base class.
 811         It is used by several functions, so it makes sense to store once the value here.
 812         (Driver._setup_environ_for_test): Factorize setting the environment for a given test.
 813         (Driver._start): Get the environment from self._setup_environ_for_test()
 814         * Scripts/webkitpy/port/driver_unittest.py:
 815         (DriverTest):
 816         (DriverTest.test_setup_environ_for_test): Add unittest for driver._setup_environ_for_test()
 817         * Scripts/webkitpy/port/gtk.py: Move the inspection of the env var USE_NATIVE_XDISPLAY to the constructor.
 818         (GtkPort.__init__):
 819         (GtkPort._driver_class):
 820         * Scripts/webkitpy/port/westondriver.py: Define and use self._setup_environ_for_test()
 821         (WestonDriver._setup_environ_for_test):
 822         (WestonDriver._start):
 823         * Scripts/webkitpy/port/xorgdriver.py: Define and use self._setup_environ_for_test()
 824         (XorgDriver._setup_environ_for_test):
 825         (XorgDriver._start):
 826         * Scripts/webkitpy/port/xvfbdriver.py: Define and use self._setup_environ_for_test()
 827         (XvfbDriver._setup_environ_for_test):
 828         (XvfbDriver._start):
 829
 830 2016-08-26  Csaba Osztrogonác  <ossy@webkit.org>
 831
 832         [EFL][GTK] REGRESSION(204877): Fix the clean build
 833         https://bugs.webkit.org/show_bug.cgi?id=161240
 834
 835         Reviewed by Carlos Garcia Campos.
 836
 837         * WebKitTestRunner/PlatformEfl.cmake:
 838         * WebKitTestRunner/PlatformGTK.cmake:
 839
 840 2016-08-26  Aakash Jain  <aakash_jain@apple.com>
 841
 842         EWS should indicate which bot processed the patch
 843         https://bugs.webkit.org/show_bug.cgi?id=161222
 844
 845         Reviewed by Daniel Bates.
 846
 847         * QueueStatusServer/handlers/statusbubble.py:
 848         (StatusBubble._build_bubble): Display the bot id in status bubble. Also removed "Started processing" message since
 849         after bug fix of 161223, bots send the "Started processing patch" message and it would be displayed in Recent messages.
 850         Also added "Started processing patch" message to progress_statuses.
 851         I might consider displaying bot id in other statuses as well later on.
 852
 853 2016-08-26  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
 854
 855         [EFL] Change homepage url to www.ewebkit.org on MiniBrowser
 856         https://bugs.webkit.org/show_bug.cgi?id=161184
 857
 858         Reviewed by Carlos Garcia Campos.
 859
 860         * MiniBrowser/efl/main.c: Set www.ewebkit.org.
 861
 862 2016-08-25  Aakash Jain  <aakash_jain@apple.com>
 863
 864         ews queues should update status server when they start processing patch
 865         https://bugs.webkit.org/show_bug.cgi?id=161223
 866
 867         Reviewed by Daniel Bates.
 868
 869         * Scripts/webkitpy/tool/commands/queues.py:
 870         (AbstractReviewQueue.process_work_item): Update status server that the bot started processing the patch.
 871         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
 872         (EarlyWarningSystemTest._default_expected_logs): Updated the unit test accordingly.
 873         * Scripts/webkitpy/tool/commands/queues_unittest.py:
 874         (StyleQueueTest.test_style_queue_with_style_exception): Same.
 875         (test_style_queue_with_watch_list_exception): Same.
 876         (test_non_valid_patch): Same.
 877
 878 2016-08-25  Alex Christensen  <achristensen@webkit.org>
 879
 880         CMake build fix.
 881
 882         * DumpRenderTree/PlatformMac.cmake:
 883
 884 2016-08-25  Alex Christensen  <achristensen@webkit.org>
 885
 886         Fix URLParserTest with GuardMalloc
 887         https://bugs.webkit.org/show_bug.cgi?id=161214
 888         rdar://problem/28014390
 889
 890         Reviewed by Tim Horton.
 891
 892         The CString returned by String::utf8 was going out of scope before we were doing a string comparison on its data.
 893         This just does the comparison of the CStrings instead to keep them in scope during the comparison.
 894
 895         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
 896         (TestWebKitAPI::eq):
 897         (TestWebKitAPI::checkURL):
 898         (TestWebKitAPI::checkURLDifferences):
 899         (TestWebKitAPI::s): Deleted.
 900
 901 2016-08-25  Wenson Hsieh  <wenson_hsieh@apple.com>
 902
 903         Dragging against the end of the inline media scrubber causes the media scrubber to hide
 904         https://bugs.webkit.org/show_bug.cgi?id=161207
 905
 906         Reviewed by Eric Carlson.
 907
 908         Tweaks an existing WebKit API test covering this behavior change. After some discussion, rather than hide media
 909         controls in this case, we should actually continue showing them. This is because seeking due to user gestures
 910         similar to "scrubbing" are indistinguishable from gestures that immediately seek to the end.
 911
 912         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
 913         (TestWebKitAPI::TEST):
 914
 915 2016-08-25  Daniel Bates  <dabates@apple.com>
 916
 917         Watch more things.
 918
 919         * Scripts/webkitpy/common/config/watchlist:
 920
 921 2016-08-25  Daniel Bates  <dabates@apple.com>
 922
 923         Fix test failure on GTK Linux bots after <http://trac.webkit.org/changeset/204695>
 924         (https://bugs.webkit.org/show_bug.cgi?id=148437)
 925
 926         Remove use of module File::Slurp as it is not part of the standard Perl 5 distribution
 927         and is not installed on the GTK Linux bots.
 928
 929         * Scripts/webkitperl/prepare-ChangeLog_unittest/generateFunctionLists.pl:
 930         (writeFileWithContent): Added.
 931
 932 2016-08-25  Per Arne Vollan  <pvollan@apple.com>
 933
 934         [Win] run-api-tests is failing.
 935         https://bugs.webkit.org/show_bug.cgi?id=161140
 936
 937         Reviewed by Brent Fulgham.
 938
 939         Since the move constructor is called 3 more times on Windows, we will have 3 more destructor calls.
 940
 941         * TestWebKitAPI/Tests/WTF/CrossThreadTask.cpp:
 942         (TestWebKitAPI::TEST):
 943
 944 2016-08-24  Per Arne Vollan  <pvollan@apple.com>
 945
 946         [Win] run-api-tests is failing.
 947         https://bugs.webkit.org/show_bug.cgi?id=161140
 948
 949         Reviewed by Brent Fulgham.
 950
 951         The number of times the move constructor is called is different on Windows in this test. This seems
 952         to be caused by differences in MSVC's implementation of lambdas or std functions like std::make_tuple.
 953
 954         * TestWebKitAPI/Tests/WTF/CrossThreadTask.cpp:
 955         (TestWebKitAPI::TEST):
 956
 957 2016-08-24  Simon Fraser  <simon.fraser@apple.com>
 958
 959         Fix iOS DRT build.
 960
 961         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
 962         (WTR::UIScriptController::zoomToScale):
 963
 964 2016-08-24  Simon Fraser  <simon.fraser@apple.com>
 965
 966         [iOS DRT] Hook up uiController.zoomToScale() for DRT
 967         https://bugs.webkit.org/show_bug.cgi?id=161173
 968
 969         Reviewed by Tim Horton.
 970
 971         Make a UIWebScrollView subclass, DumpRenderTreeWebScrollView, which has an internal delegate to get
 972         UIScrollView delegate callbacks. Store the zoomToScaleCompletionHandler on it.
 973
 974         UIScriptController::zoomToScale() has to bounce the zoom to the main thread (no poking UIKit from
 975         the WebThread!), but queue up the callback first.
 976
 977         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
 978         * DumpRenderTree/ios/DumpRenderTreeBrowserView.mm:
 979         (-[DumpRenderTreeWebScrollView initWithFrame:]):
 980         (-[DumpRenderTreeWebScrollView dealloc]):
 981         (-[DumpRenderTreeWebScrollView zoomToScale:animated:completionHandler:]):
 982         (-[DumpRenderTreeWebScrollView completedZoomToScale]):
 983         (-[DumpRenderTreeWebScrollViewDelegate initWithScrollView:]):
 984         (-[DumpRenderTreeWebScrollViewDelegate viewForZoomingInScrollView:]): All UIScrollView delegates need to implement this.
 985         (-[DumpRenderTreeWebScrollViewDelegate scrollViewDidEndZooming:withView:atScale:]):
 986         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
 987         (WTR::UIScriptController::zoomToScale):
 988         * DumpRenderTree/mac/DumpRenderTree.mm:
 989         (createWebViewAndOffscreenWindow):
 990         * TestRunnerShared/UIScriptContext/UIScriptController.h:
 991         (WTR::UIScriptController::context):
 992
 993 2016-08-24  Ryan Haddad  <ryanhaddad@apple.com>
 994
 995         Attempt to fix Windows build after r204918.
 996
 997         Unreviewed build fix.
 998
 999         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1000         (ResourceLoadDelegate::willSendRequest):
1001
1002 2016-08-24  Simon Fraser  <simon.fraser@apple.com>
1003
1004         [iOS DRT] Get basic viewport tests working in DRT
1005         https://bugs.webkit.org/show_bug.cgi?id=161160
1006
1007         Reviewed by Tim Horton.
1008
1009         Hook up enough of UIScriptController in iOS DRT to be able to read viewport
1010         scale, and get the contentVisibleRect.
1011
1012         Requires exposing a bit of UIWebBrowserView SPI from UIKit, which in turn
1013         requires typing the gWebBrowserView as a DumpRenderTreeBrowserView * everywhere.
1014
1015         One test has different results between DRT and WTR, but DRT behavior seems to differ
1016         from UIWebView here, so just give it a WK1-specific result.
1017
1018         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
1019         * DumpRenderTree/ios/DumpRenderTreeBrowserView.mm:
1020         (-[DumpRenderTreeBrowserView documentVisibleRect]):
1021         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
1022         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1023         (WTR::UIScriptController::zoomScale):
1024         (WTR::UIScriptController::minimumZoomScale):
1025         (WTR::UIScriptController::maximumZoomScale):
1026         (WTR::UIScriptController::contentVisibleRect):
1027         * DumpRenderTree/mac/DumpRenderTree.mm:
1028         (createWebViewAndOffscreenWindow):
1029         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1030
1031 2016-08-24  Simon Fraser  <simon.fraser@apple.com>
1032
1033         Minor project rearrangement.
1034
1035         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1036
1037 2016-08-24  Simon Fraser  <simon.fraser@apple.com>
1038
1039         [iOS DRT] Make iOS DRT use the same window size as WebKitTestRunner for flexible viewport tests
1040         https://bugs.webkit.org/show_bug.cgi?id=161124
1041
1042         Reviewed by Daniel Bates.
1043
1044         Use the main UIScreen's bounds for the size of the window in flexible viewport mode,
1045         and remove the 'phoneBrowserAddressBarOffset' hack, so that it matches WTR.
1046
1047         Remove some unnecessary zero initializations of static variables.
1048
1049         Change _setVisibleSize to use the window size, which should not be a behavior change
1050         because this it just used for text autosizing, which is disabled by default,
1051         and only the width is consulted.
1052
1053         * DumpRenderTree/mac/DumpRenderTree.mm:
1054         (adjustWebDocumentForFlexibleViewport):
1055         (adjustWebDocumentForStandardViewport):
1056         (createWebViewAndOffscreenWindow):
1057
1058 2016-08-24  Jonathan Bedard  <jbedard@apple.com>
1059
1060         WebKit2 needs layoutTestController.setDeferMainResourceDataLoad
1061         https://bugs.webkit.org/show_bug.cgi?id=42777
1062
1063         Reviewed by Darin Adler.
1064
1065         The setDeferMainResourceDataLoad method was not correctly tested in DumpRenderTree and would pass even when setDeterMainResourceDataLoad was not called.  Removed function and test.
1066
1067         * DumpRenderTree/TestRunner.cpp:
1068         (setDeferMainResourceDataLoadCallback): Removed setDeferMainResourceDataLoad.
1069         * DumpRenderTree/TestRunner.h:
1070         (TestRunner::deferMainResourceDataLoad): Ditto.
1071         (TestRunner::setDeferMainResourceDataLoad): Ditto.
1072         * DumpRenderTree/mac/ResourceLoadDelegate.mm: Ditto.
1073
1074 2016-08-23  Anders Carlsson  <andersca@apple.com>
1075
1076         Add enum traits and use them in the IPC::Decoder
1077         https://bugs.webkit.org/show_bug.cgi?id=161103
1078
1079         Reviewed by Sam Weinig.
1080
1081         Add API test.
1082
1083         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1084         * TestWebKitAPI/Tests/WTF/EnumTraits.cpp: Added.
1085         (TestWebKitAPI::TEST):
1086
1087 2016-08-24  Filip Pizlo  <fpizlo@apple.com>
1088
1089         Unreviewed, roll out r204901, r204897, r204866, r204856, r204854.
1090
1091         * DumpRenderTree/TestRunner.cpp:
1092         * DumpRenderTree/mac/DumpRenderTree.mm:
1093         (DumpRenderTreeMain):
1094         * Scripts/run-jsc-stress-tests:
1095         * TestWebKitAPI/Tests/WTF/Vector.cpp:
1096         (TestWebKitAPI::TEST):
1097
1098 2016-08-24  Simon Fraser  <simon.fraser@apple.com>
1099
1100         Try to fix Production builds.
1101
1102         PRODUCTION_FRAMEWORKS_DIR was undefined here.
1103
1104         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1105
1106 2016-08-24  Dan Bernstein  <mitz@apple.com>
1107
1108         Add a convenience function for creating a WKFrameHandleRef from a WKFrameRef without going through WKFrameInfoRef
1109         https://bugs.webkit.org/show_bug.cgi?id=161152
1110
1111         Reviewed by Anders Carlsson.
1112
1113         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1114         * TestWebKitAPI/Tests/WebKit2/FrameHandle.cpp: Added.
1115         (TestWebKitAPI::didFinishLoadForFrame):
1116         (TestWebKitAPI::TEST):
1117
1118 2016-08-24  Nan Wang  <n_wang@apple.com>
1119
1120         AX: Add test for line text marker range on iOS
1121         https://bugs.webkit.org/show_bug.cgi?id=161108
1122         <rdar://problem/27976405>
1123
1124         Reviewed by Chris Fleizach.
1125
1126         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1127         (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
1128         (AccessibilityUIElement::textMarkerRangeForElement):
1129         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1130         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
1131         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
1132
1133 2016-08-24  Per Arne Vollan  <pvollan@apple.com>
1134
1135         [Win] Warning fixes.
1136         https://bugs.webkit.org/show_bug.cgi?id=161079
1137
1138         Reviewed by Brent Fulgham.
1139
1140         * MiniBrowser/win/WebDownloadDelegate.cpp:
1141         * MiniBrowser/win/WinMain.cpp:
1142         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
1143         (TestWebKitAPI::TEST):
1144
1145 2016-08-23  Simon Fraser  <simon.fraser@apple.com>
1146
1147         Fix Windows DRT build.
1148
1149         * DumpRenderTree/win/TestRunnerWin.cpp:
1150         (TestRunner::mainFrameJSContext):
1151
1152 2016-08-23  Simon Fraser  <simon.fraser@apple.com>
1153
1154         Try to fix Windows build.
1155
1156         Pass Tools/DumpRenderTree/Bindings as the working directory for the generate_bindings.pl
1157         so that perl finds CodeGeneratorDumpRenderTree.pm.
1158
1159         * DumpRenderTree/CMakeLists.txt:
1160
1161 2016-08-23  Simon Fraser  <simon.fraser@apple.com>
1162
1163         Hook up UIScriptController in DumpRenderTree
1164         https://bugs.webkit.org/show_bug.cgi?id=161064
1165
1166         Reviewed by Sam Weinig.
1167
1168         Add a skeleton implementation of UIScriptController to DumpRenderTree, building for both
1169         Mac and iOS. Currently this is sufficient to test doAsyncTask(), enabling two tests
1170         in fast/harness which test this.
1171
1172         Add a DerivedSources target to DumpRenderTree to invoke DerivedSources.make.
1173
1174         Move related code shared between WTR and DRT into Tools/TestRunnerShared, and cleanse it of
1175         WK2-isms. Fix the makefiles to refer to the new location.
1176
1177         Hook up TestRunner::runUIScript() for DumpRenderTree, which requires keeping track of callbacks
1178         by ID and firing them once they are complete.
1179
1180         * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm: Added (copied from WTR).
1181         * DumpRenderTree/CMakeLists.txt:
1182         * DumpRenderTree/DerivedSources.make: Copied from Tools/WebKitTestRunner/DerivedSources.make.
1183         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1184         * DumpRenderTree/TestRunner.cpp:
1185         (runUIScriptCallback):
1186         (TestRunner::staticFunctions):
1187         (TestRunner::cacheTestRunnerCallback):
1188         (TestRunner::callTestRunnerCallback):
1189         (TestRunner::clearTestRunnerCallbacks):
1190         (nextUIScriptCallbackID):
1191         (TestRunner::runUIScript):
1192         (TestRunner::callUIScriptCallback):
1193         (TestRunner::uiScriptDidComplete):
1194         (TestRunner::cleanup):
1195         * DumpRenderTree/TestRunner.h:
1196         * DumpRenderTree/ios/UIScriptControllerIOS.mm: Added.
1197         * DumpRenderTree/mac/Configurations/Base.xcconfig: DerivedSources.make needs WEBCORE_PRIVATE_HEADERS_DIR to be defined.
1198         * DumpRenderTree/mac/DumpRenderTree.mm:
1199         (runTest):
1200         * DumpRenderTree/mac/TestRunnerMac.mm:
1201         (TestRunner::mainFrameJSContext):
1202         * DumpRenderTree/mac/UIScriptControllerMac.mm: Copied from Tools/WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h.
1203         (WTR::UIScriptController::doAsyncTask):
1204         * DumpRenderTree/win/DumpRenderTree.cpp:
1205         * TestRunnerShared/Bindings/JSWrappable.h: Renamed from Tools/WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h.
1206         (WTR::JSWrappable::~JSWrappable):
1207         (WTR::JSValueMakeStringOrNull):
1208         * TestRunnerShared/Bindings/JSWrapper.cpp: Renamed from Tools/WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp.
1209         (WTR::JSWrapper::wrap):
1210         (WTR::JSWrapper::unwrap):
1211         (WTR::unwrapObject):
1212         (WTR::JSWrapper::initialize):
1213         (WTR::JSWrapper::finalize):
1214         * TestRunnerShared/Bindings/JSWrapper.h: Renamed from Tools/WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.h.
1215         (WTR::toJS):
1216         (WTR::setProperty):
1217         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl: Renamed from Tools/WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl.
1218         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp: Renamed from Tools/WebKitTestRunner/UIScriptContext/UIScriptContext.cpp.
1219         * TestRunnerShared/UIScriptContext/UIScriptContext.h: Renamed from Tools/WebKitTestRunner/UIScriptContext/UIScriptContext.h.
1220         (WTR::UIScriptContext::currentParentCallbackIsPendingCompletion):
1221         * TestRunnerShared/UIScriptContext/UIScriptController.cpp: Renamed from Tools/WebKitTestRunner/UIScriptContext/UIScriptController.cpp.
1222         * TestRunnerShared/UIScriptContext/UIScriptController.h: Renamed from Tools/WebKitTestRunner/UIScriptContext/UIScriptController.h.
1223         * WebKitTestRunner/CMakeLists.txt:
1224         * WebKitTestRunner/DerivedSources.make:
1225         * WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h:
1226         (WTR::JSWrappable::~JSWrappable): Deleted.
1227         (WTR::JSValueMakeStringOrNull): Deleted.
1228         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp:
1229         (WTR::JSWrapper::wrap): Deleted.
1230         (WTR::JSWrapper::unwrap): Deleted.
1231         (WTR::unwrapObject): Deleted.
1232         (WTR::JSWrapper::initialize): Deleted.
1233         (WTR::JSWrapper::finalize): Deleted.
1234         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.h:
1235         (WTR::toJS): Deleted.
1236         (WTR::setProperty): Deleted.
1237         * WebKitTestRunner/TestInvocation.cpp:
1238         (WTR::TestInvocation::runUISideScript):
1239         (WTR::TestInvocation::uiScriptDidComplete):
1240         * WebKitTestRunner/TestInvocation.h:
1241         * WebKitTestRunner/UIScriptContext/UIScriptContext.cpp: Moved
1242         * WebKitTestRunner/UIScriptContext/UIScriptContext.h: Moved
1243         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp: Moved
1244         * WebKitTestRunner/UIScriptContext/UIScriptController.h: Moved
1245         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1246         * WebKitTestRunner/config.h:
1247         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1248         (WTR::UIScriptController::contentVisibleRect):
1249
1250 2016-08-23  Saam Barati  <sbarati@apple.com>
1251
1252         JSC should have a "microbenchmarks" directory instead of "regress" directory
1253         https://bugs.webkit.org/show_bug.cgi?id=161096
1254
1255         Rubber stamped by Mark Lam.
1256
1257         This patch moves LayoutTests/js/regress/script-tests to the JSTests/microbenchmarks
1258         directory and removes all the related html and txt files. I did this because
1259         that directory was only there for microbenchmarks, and not for "regression"
1260         tests. I also changed the various scripts to point to it.
1261
1262         * Scripts/run-javascriptcore-tests:
1263         (runJSCStressTests):
1264         * Scripts/run-jsc-benchmarks:
1265
1266 2016-08-23  Alex Christensen  <achristensen@webkit.org>
1267
1268         Fix EFL build.
1269
1270         * TestWebKitAPI/CMakeLists.txt:
1271         Include new directory.
1272
1273 2016-08-22  Filip Pizlo  <fpizlo@apple.com>
1274
1275         Butterflies should be allocated in Auxiliary MarkedSpace instead of CopiedSpace and we should rewrite as much of the GC as needed to make this not a regression
1276         https://bugs.webkit.org/show_bug.cgi?id=160125
1277
1278         Reviewed by Geoffrey Garen.
1279
1280         * DumpRenderTree/TestRunner.cpp: Rewire some #includes.
1281         * Scripts/run-jsc-stress-tests: New test flag!
1282
1283 2016-08-23  Brady Eidson  <beidson@apple.com>
1284
1285         WK2 Gamepad layout test support.
1286         https://bugs.webkit.org/show_bug.cgi?id=134671
1287
1288         Reviewed by Alex Christensen.
1289
1290         Have the injected bundle expose the MockGamepadProvider to the UI process, which will then
1291         feed back into the UIGamepadProvider.
1292
1293         Also, fool NSApplication into treating the most recently created "isKeyWindow" of the test windows
1294         as the actual keyWindow for the test runner, which will allow the view to get gamepad updates.
1295
1296         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
1297
1298         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1299         (WTR::TestRunner::setMockGamepadDetails):
1300         (WTR::TestRunner::setMockGamepadAxisValue):
1301         (WTR::TestRunner::setMockGamepadButtonValue):
1302
1303         * WebKitTestRunner/PlatformWebView.h:
1304
1305         * WebKitTestRunner/TestController.cpp:
1306         (WTR::TestController::initialize):
1307
1308         * WebKitTestRunner/TestInvocation.cpp:
1309         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1310         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Deleted.
1311
1312         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1313
1314         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1315         (-[WebKitTestRunnerWindow initWithFrame:]):
1316         (-[WebKitTestRunnerWindow dealloc]):
1317         (WTR::PlatformWebView::keyWindow):
1318
1319         * WebKitTestRunner/ios/TestControllerIOS.mm:
1320         (WTR::wtr_NSApplication_keyWindow):
1321         (WTR::TestController::platformInitialize):
1322
1323         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1324         (+[WebKitTestRunnerWindow _WTR_keyWindow]):
1325         (-[WebKitTestRunnerWindow initWithContentRect:styleMask:backing:defer:]):
1326         (-[WebKitTestRunnerWindow dealloc]):
1327         (WTR::PlatformWebView::keyWindow):
1328
1329         * WebKitTestRunner/mac/TestControllerMac.mm:
1330         (WTR::wtr_NSApplication_keyWindow):
1331         (WTR::TestController::platformInitialize):
1332         * WebKitTestRunner/mac/main.mm:
1333
1334 2016-08-23  Alexey Proskuryakov  <ap@apple.com>
1335
1336         REGRESSION (PHP 5.6): http/tests/misc/bad-charset-alias.html fails
1337         https://bugs.webkit.org/show_bug.cgi?id=161047
1338         rdar://problem/27434307
1339
1340         Reviewed by Lucas Forschler.
1341
1342         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py: Specify a php.ini file.
1343
1344 2016-08-23  Chris Dumez  <cdumez@apple.com>
1345
1346         Unreviewed, rolling out r204243.
1347
1348         Caused some layout test failures
1349
1350         Reverted changeset:
1351
1352         "Write API test to cover crash fix in r204135"
1353         https://bugs.webkit.org/show_bug.cgi?id=160587
1354         http://trac.webkit.org/changeset/204243
1355
1356 2016-08-23  Rawinder Singh  <rawinder.singh-webkit@cisra.canon.com.au>
1357
1358         Order feature option list in FeatureList.pm
1359         https://bugs.webkit.org/show_bug.cgi?id=161074
1360
1361         Reviewed by Michael Catanzaro.
1362
1363         Reorder features in alphabetical order based on command line option. Also, sort variables in alphabetical order.
1364
1365         * Scripts/webkitperl/FeatureList.pm:
1366
1367 2016-08-22  Dewei Zhu  <dewei_zhu@apple.com>
1368
1369         Stop python icon bouncing in the dock while running browser benchmarks.
1370         https://bugs.webkit.org/show_bug.cgi?id=161066
1371
1372         Reviewed by Ryosuke Niwa.
1373
1374         Bouncing python icon may impact browser benchmark results.
1375         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
1376         (OSXBrowserDriver.prepare_env):
1377         (OSXBrowserDriver.restore_env):
1378
1379 2016-08-22  Simon Fraser  <simon.fraser@apple.com>
1380
1381         <select> menu on iPad causes shifting of hit-testing areas
1382         https://bugs.webkit.org/show_bug.cgi?id=150079
1383
1384         Reviewed by Tim Horton.
1385
1386         -isAssistingNode (aka the poorly named isEditable) is input into WebPageProxy::computeCustomFixedPositionRect(),
1387         so when it changes we have to update visible rects. We were doing this on focus, but failing
1388         to do it on blur.
1389
1390         Added the ability to test by:
1391         1. Making it possible to initiate an animated scroll in the UI process
1392         2. Adding callbacks for starting and ending interaction with a form control. Sadly
1393         the "ending interaction" for <select> popovers on iPad isn't late enough, since we
1394         have no way currently to know when the dimming view behind the popover animates out,
1395         so for now the test keeps trying to tap a button.
1396
1397         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
1398         * WebKitTestRunner/UIScriptContext/UIScriptContext.h:
1399         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
1400         (WTR::UIScriptController::setDidStartFormControlInteractionCallback):
1401         (WTR::UIScriptController::didStartFormControlInteractionCallback):
1402         (WTR::UIScriptController::setDidEndFormControlInteractionCallback):
1403         (WTR::UIScriptController::didEndFormControlInteractionCallback):
1404         (WTR::UIScriptController::scrollToOffset):
1405         (WTR::UIScriptController::platformSetDidStartFormControlInteractionCallback):
1406         (WTR::UIScriptController::platformSetDidEndFormControlInteractionCallback):
1407         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
1408         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1409         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1410         (-[TestRunnerWKWebView dealloc]):
1411         (-[TestRunnerWKWebView didStartFormControlInteraction]):
1412         (-[TestRunnerWKWebView didEndFormControlInteraction]):
1413         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1414         (WTR::contentOffsetBoundedInValidRange):
1415         (WTR::UIScriptController::scrollToOffset):
1416         (WTR::UIScriptController::platformSetDidStartFormControlInteractionCallback):
1417         (WTR::UIScriptController::platformSetDidEndFormControlInteractionCallback):
1418
1419 2016-08-22  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1420
1421         [EFL][GTK] Script process-linux-coredump is not needed, switch back to use the kernel core dumper instead.
1422         https://bugs.webkit.org/show_bug.cgi?id=160927
1423
1424         Reviewed by Daniel Bates.
1425
1426         * Scripts/process-linux-coredump: Removed.
1427         * Scripts/webkitpy/port/efl.py:
1428         (EflPort._get_crash_log):
1429         * Scripts/webkitpy/port/gtk.py:
1430         (GtkPort._get_crash_log):
1431         * Scripts/webkitpy/port/linux_get_crash_log.py:
1432         (GDBCrashLogGenerator.__init__):
1433         (GDBCrashLogGenerator.generate_crash_log):
1434         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
1435         (GDBCrashLogGeneratorTest.test_generate_crash_log):
1436
1437 2016-08-22  Jonathan Bedard  <jbedard@apple.com>
1438
1439         check-webkit-style does not work with Lambda functions in C++
1440         https://bugs.webkit.org/show_bug.cgi?id=160910
1441
1442         Reviewed by Darin Adler.
1443
1444         This change eliminates false positives on correctly styled lambda functions and includes a few basic checks on capture list.
1445
1446         * Scripts/webkitpy/style/checkers/cpp.py:
1447         (regex_for_lambda_functions): Added function which checks if a string is the start of a lambda function.
1448         (check_for_non_standard_constructs): Added lambda function check.
1449         (check_spacing_for_function_call): Added lambda function check.
1450         (check_braces): Added lambda function check.
1451         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1452         (CppStyleTest.test_lambda_functions): Added test function for lambda function style checks.
1453
1454 2016-08-21  Alex Christensen  <achristensen@webkit.org>
1455
1456         URLParser should parse IPv4 addresses
1457         https://bugs.webkit.org/show_bug.cgi?id=161023
1458
1459         Reviewed by Darin Adler.
1460
1461         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1462         (TestWebKitAPI::TEST_F):
1463         (TestWebKitAPI::checkURLDifferences):
1464         We are already getting differences between the old URL::parse and the new URLParser.
1465         (TestWebKitAPI::shouldFail):
1466
1467 2016-08-21  Daniel Bates  <dabates@apple.com>
1468
1469         prepare-ChangeLog lists unmodified functions as modified and marks functions with few changes as deleted
1470         https://bugs.webkit.org/show_bug.cgi?id=148437
1471
1472         Reviewed by Dan Bernstein.
1473
1474         * Scripts/prepare-ChangeLog:
1475         (diffCommand): When using a Subversion checkout, generate a unified diff without any context lines.
1476         This matches our behavior when using a Git checkout. The function overlap logic in generateFunctionListsByRanges()
1477         assumes that its line ranges were from a unified diff without any context lines.
1478         (extractLineRangeAfterChange): A deleted line should be represented with a ("begin line number", "end line number") = ("new starting line number", "new starting line number").
1479         (extractLineRangeBeforeChange): An added line should be represented with a ("begin line number", "end line number") = ("original starting line number", "original starting line number").
1480         * Scripts/webkitperl/prepare-ChangeLog_unittest/extractLineRangeBeforeAndAfterChange.pl: Update expected results
1481         based on changes to extractLineRangeAfterChange() and extractLineRangeBeforeChange().
1482         * Scripts/webkitperl/prepare-ChangeLog_unittest/generateFunctionLists.pl: Added.
1483         (discardOutput): Convenience function invokes the specified function redirecting standard output and standard error
1484         to /dev/null for the duration of the function call.
1485
1486 2016-08-20  Gyuyoung Kim  <gyuyoung.kim@navercorp.com>
1487
1488         [EFL] Remove unnecessary a patch to mute ecore warnings
1489         https://bugs.webkit.org/show_bug.cgi?id=160997
1490
1491         Reviewed by Darin Adler.
1492
1493         There is no warning messages during the layout test and perf test
1494         after bumping efl version from 1.17 to 1.18. Remove it.
1495
1496         * efl/patches/ecore_remove_warnings.patch: Removed.
1497
1498 2016-08-20  Simon Fraser  <simon.fraser@apple.com>
1499
1500         REGRESSION (r204477): Running LayoutTests on ios-simulator became ~15 minutes slower
1501         https://bugs.webkit.org/show_bug.cgi?id=160985
1502
1503         Re-land r204672, but don't check the result of 'xcrun simctl shutdown', because
1504         device shutdown seems to happen as result of killing Simulator.apps, and we're racing
1505         with that.
1506
1507         * Scripts/webkitpy/layout_tests/views/printing.py:
1508         (Printer.print_config):
1509         * Scripts/webkitpy/port/base.py:
1510         (Port.driver_cmd_line_for_logging):
1511         (Port.driver_cmd_line): Deleted.
1512         * Scripts/webkitpy/port/driver.py:
1513         (IOSSimulatorDriver.cmd_line):
1514         * Scripts/webkitpy/port/ios.py:
1515         (IOSSimulatorPort.__init__):
1516         (IOSSimulatorPort.driver_cmd_line_for_logging):
1517         (IOSSimulatorPort._create_simulators):
1518         (IOSSimulatorPort.setup_test_run):
1519         (IOSSimulatorPort._quit_ios_simulator):
1520         (IOSSimulatorPort.clean_up_test_run):
1521         (IOSSimulatorPort._create_device):
1522         (IOSSimulatorPort):
1523         (IOSSimulatorPort._remove_device):
1524         (IOSSimulatorPort._testing_device):
1525         (IOSSimulatorPort.device_id_for_worker_number):
1526         (IOSSimulatorPort._set_device_class): Deleted.
1527         (IOSSimulatorPort.testing_device): Deleted.
1528         * Scripts/webkitpy/port/port_testcase.py:
1529         (PortTestCase.test_driver_cmd_line):
1530         * Scripts/webkitpy/xcode/simulator.py:
1531         (Device.shutdown):
1532         (Device):
1533         (Device.delete):
1534         (Device.reset):
1535         (Simulator):
1536         (Simulator.create_device):
1537         (Simulator.remove_device):
1538         (Simulator.device_number):
1539         (Simulator.device_state_description):
1540         (Simulator.wait_until_device_is_in_state):
1541
1542 2016-08-19  Ryan Haddad  <ryanhaddad@apple.com>
1543
1544         Unreviewed, rolling out r204659.
1545
1546         This change appears to have caused ios-simulator LayoutTests
1547         to fail when shutting down the simulator
1548
1549         Reverted changeset:
1550
1551         "REGRESSION (r204477): Running LayoutTests on ios-simulator
1552         became ~15 minutes slower"
1553         https://bugs.webkit.org/show_bug.cgi?id=160985
1554         http://trac.webkit.org/changeset/204659
1555
1556 2016-08-19  Alexey Proskuryakov  <ap@apple.com>
1557
1558         Build fix for non-USE_SIM_SERVICE_CONTEXT builds
1559         * LayoutTestRelay/LayoutTestRelay/main.m: (main):
1560
1561 2016-08-18  Simon Fraser  <simon.fraser@apple.com>
1562
1563         REGRESSION (r204477): Running LayoutTests on ios-simulator became ~15 minutes slower
1564         https://bugs.webkit.org/show_bug.cgi?id=160985
1565
1566         Reviewed by Alexey Proskuryakov.
1567
1568         r204477 removed @memoized on a couple of ios.py functions, causing them to instantiate
1569         a Simulator() on every call, which causes 'xcrun simctl list' to run. The functions
1570         must not be @memoized, because their return value depends on the value of simulator_device_type().
1571
1572         Fix by adding some global state in simulator.py that tracks the created devices
1573         in a worker number -> Device dictionary. Explicitly create devices in _create_simulators(),
1574         and delete them in clean_up_test_run().
1575
1576         Also explicitly called 'xcrun simctl shutdown' to shut down devices, since it seems
1577         that killing the Simulator apps isn't enough.
1578
1579         Simulator tracks the devices in a global dictionary, since state needs to persist
1580         across different instances of IOSSimulatorPort.
1581
1582         Annoyingly, the "Command line:" dumping tried to access a device before we'd done
1583         any setup. Rather than implicitly creating a device here (which the old code did),
1584         override the more clearly named driver_cmd_line_for_logging() in IOSSimulatorPort
1585         and set flag to say that device_id_for_worker_number() doesn't need to return a real
1586         device id.
1587
1588         * Scripts/webkitpy/layout_tests/views/printing.py:
1589         (print_options):
1590         (Printer.print_config):
1591         * Scripts/webkitpy/port/base.py:
1592         (Port.driver_cmd_line_for_logging):
1593         (Port.driver_cmd_line): Deleted.
1594         * Scripts/webkitpy/port/driver.py:
1595         (IOSSimulatorDriver.cmd_line):
1596         * Scripts/webkitpy/port/ios.py:
1597         (IOSSimulatorPort.__init__):
1598         (IOSSimulatorPort.driver_cmd_line_for_logging):
1599         (IOSSimulatorPort._create_simulators):
1600         (IOSSimulatorPort.setup_test_run):
1601         (IOSSimulatorPort.clean_up_test_run):
1602         (IOSSimulatorPort._create_device):
1603         (IOSSimulatorPort):
1604         (IOSSimulatorPort._remove_device):
1605         (IOSSimulatorPort._testing_device):
1606         (IOSSimulatorPort.device_id_for_worker_number):
1607         (IOSSimulatorPort._set_device_class): Deleted.
1608         (IOSSimulatorPort.testing_device): Deleted.
1609         * Scripts/webkitpy/port/port_testcase.py:
1610         (PortTestCase.test_driver_cmd_line):
1611         * Scripts/webkitpy/xcode/simulator.py:
1612         (Device.shutdown):
1613         (Device.delete):
1614         (Device.reset):
1615         (Simulator.create_device):
1616         (Simulator.remove_device):
1617         (Simulator.device_number):
1618         (Simulator.device_state_description):
1619         (Simulator.wait_until_device_is_in_state):
1620
1621 2016-08-19  Alexey Proskuryakov  <ap@apple.com>
1622
1623         Adopt SimServiceContext in LayoutTestRelay
1624         https://bugs.webkit.org/show_bug.cgi?id=161000
1625         <rdar://problem/25765594>
1626
1627         Reviewed by Daniel Bates.
1628
1629         * LayoutTestRelay/LayoutTestRelay/CoreSimulatorSPI.h:
1630         * LayoutTestRelay/LayoutTestRelay/main.m:
1631
1632 2016-08-19  Lucas Forschler  <lforschler@apple.com>
1633
1634         Remove Yosemite Leaks bot after http://trac.webkit.org/projects/webkit/changeset/204629
1635
1636         Reviewed by Kocsen Chung.
1637
1638         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1639         (WebKitBuildbot):
1640
1641 2016-08-19  Alexey Proskuryakov  <ap@apple.com>
1642
1643         Partial revert of r203811 - this key is not needed.
1644
1645         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m: (-[LTRelayController installApp]):
1646
1647 2016-08-19  Daniel Bates  <dabates@apple.com>
1648
1649         Another attempt to fix the iOS 9.3 build
1650
1651         Define WK_EMPTY_, WK_NOT_, and WK_NOT_YES.
1652
1653         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1654         * WebKitTestRunner/Configurations/Base.xcconfig:
1655
1656 2016-08-19  Lucas Forschler  <lforschler@apple.com>
1657
1658         Remove Yosemite Leaks bot from config.json
1659
1660         Reviewed by Alexey Proskuryakov.
1661
1662         * BuildSlaveSupport/build.webkit.org-config/config.json:
1663
1664 2016-08-18  Dan Bernstein  <mitz@apple.com>
1665
1666         [Cocoa] API::Number needs to be wrapped by an NSNumber
1667         https://bugs.webkit.org/show_bug.cgi?id=160977
1668         <rdar://problem/27877735>
1669
1670         Reviewed by Anders Carlsson.
1671
1672         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1673         * TestWebKitAPI/Tests/WebKit2Cocoa/WKNSNumber.mm: Added.
1674         (TestWebKitAPI::TEST):
1675
1676 2016-08-17  Myles C. Maxfield  <mmaxfield@apple.com>
1677
1678         [Cocoa] Migrate off of deprecated CoreGraphics API CGContextSelectFont() and CGContextShowTextAtPoint()
1679         https://bugs.webkit.org/show_bug.cgi?id=160895
1680
1681         Reviewed by Dean Jackson.
1682
1683         Link to the existing CoreText framework.
1684
1685         * DumpRenderTree/PlatformWin.cmake:
1686         * TestWebKitAPI/PlatformWin.cmake:
1687
1688 2016-08-17  Brent Fulgham  <bfulgham@apple.com>
1689
1690         [Win] Remove old libraries from build inputs
1691         https://bugs.webkit.org/show_bug.cgi?id=160949
1692
1693         Reviewed by Dean Jackson.
1694
1695         Modify the download script to remove the old 'icuuc.lib' and
1696         'icuin.lib' files for Windows builds.
1697
1698         * Scripts/update-webkit-auxiliary-libs:
1699
1700 2016-08-17  Jonathan Bedard  <jbedard@apple.com>
1701
1702         Extra logging for crash reason
1703         https://bugs.webkit.org/show_bug.cgi?id=160943
1704
1705         Reviewed by Alexey Proskuryakov.
1706
1707         A number of tests have been erroneously marked as crashed, this should help diagnose these false crashes.
1708
1709         * Scripts/webkitpy/port/server_process.py:
1710         (ServerProcess.write): Add extra logging to determine why a process has been marked as crashed.
1711         (ServerProcess._wait_for_data_and_update_buffers_using_select): Ditto.
1712         (ServerProcess.has_crashed): Ditto.
1713
1714 2016-08-17  Dan Bernstein  <mitz@apple.com>
1715
1716         [Cocoa] -[NSString isEqualToString:] returns NO for any WKNSString argument
1717         https://bugs.webkit.org/show_bug.cgi?id=160938
1718         <rdar://problem/27876652>
1719
1720         Reviewed by Anders Carlsson.
1721
1722         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1723         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm: Added.
1724         (TestWebKitAPI::TEST):
1725
1726 2016-08-17  Chris Fleizach  <cfleizach@apple.com>
1727
1728         AX: Support abbreviations in iOS
1729         https://bugs.webkit.org/show_bug.cgi?id=160907
1730
1731         Reviewed by Joanmarie Diggs.
1732
1733         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1734         (AccessibilityUIElement::stringAttributeValue):
1735         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1736         (WTR::AccessibilityUIElement::stringAttributeValue):
1737
1738 2016-08-17  Gyuyoung Kim  <gyuyoung.kim@navercorp.com>
1739
1740         [EFL] Bump efl version from 1.17 to 1.18
1741         https://bugs.webkit.org/show_bug.cgi?id=160899
1742
1743         Reviewed by Antonio Gomes.
1744
1745         To use efl-1.18, EFL port needs to update install dependencies as well.
1746
1747         * efl/install-dependencies:
1748         * efl/jhbuild.modules:
1749
1750 2016-08-17  Per Arne Vollan  <pvollan@apple.com>
1751
1752         [Win] Add tests for linked fonts.
1753         https://bugs.webkit.org/show_bug.cgi?id=160898
1754
1755         Reviewed by Brent Fulgham.
1756
1757         Add tests for https://trac.webkit.org/changeset/204502.
1758
1759         * TestWebKitAPI/PlatformWin.cmake:
1760         * TestWebKitAPI/Tests/WebCore/win/LinkedFonts.cpp: Added.
1761         (TestWebKitAPI::TEST):
1762
1763 2016-08-16  Daniel Bates  <dabates@apple.com>
1764
1765         prepare-ChangeLog: Extract logic from generateFunctionLists() into a function that takes a delegate object
1766         https://bugs.webkit.org/show_bug.cgi?id=160924
1767
1768         Reviewed by Stephanie Lewis.
1769
1770         Towards adding unit tests for generateFunctionLists() we move its logic into actuallyGenerateFunctionLists()
1771         and have actuallyGenerateFunctionLists() take a delegate object to use to query the file system and SCM.
1772         We modify generateFunctionLists() to call actuallyGenerateFunctionLists(). This will make is possible to
1773         test the generate function list machinery without requiring a SCM checkout by substituting a delegate
1774         object that mocks out the file system and SCM operations.
1775
1776         * Scripts/VCSUtils.pm:
1777         (parseDiffStartLine): Parses an SVN or Git start line and returns the path to the target file.
1778         * Scripts/prepare-ChangeLog:
1779         (generateFunctionLists): Move functionality to actually generate the function lists to actuallyGenerateFunctionLists(),
1780         abstracting the logic to query the file system and SCM into functions on a delegate object that
1781         we pass to it.
1782         (actuallyGenerateFunctionLists): Extracted from generateFunctionLists().
1783         (diffHeaderFormat): Deleted.
1784
1785 2016-08-16  Alex Christensen  <achristensen@webkit.org>
1786
1787         URLParser should parse URLs without credentials
1788         https://bugs.webkit.org/show_bug.cgi?id=160913
1789
1790         Reviewed by Brady Eidson.
1791
1792         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1793         (TestWebKitAPI::s):
1794         (TestWebKitAPI::checkURL):
1795         (TestWebKitAPI::TEST_F):
1796
1797 2016-08-16  Anders Carlsson  <andersca@apple.com>
1798
1799         Add WTF::ScopeExit
1800         https://bugs.webkit.org/show_bug.cgi?id=160908
1801
1802         Reviewed by Geoffrey Garen.
1803
1804         * TestWebKitAPI/CMakeLists.txt:
1805         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1806         * TestWebKitAPI/Tests/WTF/Scope.cpp: Added.
1807         (TestWebKitAPI::TEST):
1808
1809 2016-08-16  Aakash Jain  <aakash_jain@apple.com>
1810
1811         EWS logs file are rotated too quickly
1812         https://bugs.webkit.org/show_bug.cgi?id=160724
1813
1814         Reviewed by Daniel Bates.
1815
1816         Currently we are rotating the log file after 10 iterations of queue. If the queue
1817         doesn't have any pending patches, these iterations result in very small amount of
1818         logs (1 KB log file). Even if the queue process some patches, logs are few KBs.
1819         This results in a lot of log files in a day. This patch ensures that we rotate the
1820         log file when its file size is greater than or equal to 100 KB.
1821
1822         * EWSTools/start-queue-mac.sh: Added check for file size before rotating log file.
1823
1824 2016-08-16  Daniel Bates  <dabates@apple.com>
1825
1826         WKSI static library should be named by major iOS revision, not individual updates
1827         https://bugs.webkit.org/show_bug.cgi?id=160727
1828         <rdar://problem/22274848>
1829
1830         Reviewed by Alexey Proskuryakov.
1831
1832         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1833         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1834         * Scripts/copy-webkitlibraries-to-product-directory:
1835         * WebKitTestRunner/Configurations/Base.xcconfig:
1836         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1837
1838 2016-08-16  Simon Fraser  <simon.fraser@apple.com>
1839
1840         Make it possible to test iOS select elements, and add iPhone and iPad tests for them
1841         https://bugs.webkit.org/show_bug.cgi?id=160909
1842
1843         Reviewed by Enrica Casucci.
1844
1845         Add functions to UIScriptController to dismiss the form accessory view for iOS,
1846         and to programmatically pick a row from a <select> picker.
1847
1848         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
1849         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
1850         (WTR::UIScriptController::dismissFormAccessoryView):
1851         (WTR::UIScriptController::selectFormAccessoryPickerRow):
1852         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
1853         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1854         (WTR::UIScriptController::dismissFormAccessoryView):
1855         (WTR::UIScriptController::selectFormAccessoryPickerRow):
1856
1857 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
1858
1859         [iOS] Add iPad viewport and form tests, and revert the iPad-testing part of r202132
1860         https://bugs.webkit.org/show_bug.cgi?id=160878
1861
1862         Reviewed by Tim Horton.
1863
1864         Remove testing-specific "forceIPadStyleZoomOnInputFocus" behavior added in r202132
1865         now that we have the ability to run tests in the iPad simulator.
1866
1867         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
1868         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
1869         (WTR::UIScriptController::forceIPadStyleZoomOnInputFocus): Deleted.
1870         (WTR::UIScriptController::setForceIPadStyleZoomOnInputFocus): Deleted.
1871         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
1872         * WebKitTestRunner/ios/TestControllerIOS.mm:
1873         (WTR::TestController::platformResetStateToConsistentValues): Deleted.
1874         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1875         (WTR::UIScriptController::forceIPadStyleZoomOnInputFocus): Deleted.
1876         (WTR::UIScriptController::setForceIPadStyleZoomOnInputFocus): Deleted.
1877
1878 2016-08-15  Anders Carlsson  <andersca@apple.com>
1879
1880         Add an address-of operator to RetainPtr
1881         https://bugs.webkit.org/show_bug.cgi?id=160879
1882
1883         Reviewed by Tim Horton.
1884
1885         Test HashMap and HashSet with an object whose operator& is deleted.
1886
1887         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1888         Sort the Xcode project.
1889
1890         * TestWebKitAPI/Tests/WTF/DeletedAddressOfOperator.h: Added.
1891         (DeletedAddressOfOperator::DeletedAddressOfOperator):
1892         (DeletedAddressOfOperator::value):
1893         (DeletedAddressOfOperator::operator==):
1894         (WTF::HashTraits<DeletedAddressOfOperator>::constructDeletedValue):
1895         (WTF::HashTraits<DeletedAddressOfOperator>::isDeletedValue):
1896         (WTF::DefaultHash<DeletedAddressOfOperator>::Hash::hash):
1897         (WTF::DefaultHash<DeletedAddressOfOperator>::Hash::equal):
1898         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
1899         (TestWebKitAPI::TEST):
1900         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
1901         (TestWebKitAPI::TEST):
1902
1903 2016-08-16  Jonathan Bedard  <jbedard@apple.com>
1904
1905         False crashes in fast/text/emoji-gender-* tests
1906         https://bugs.webkit.org/show_bug.cgi?id=160779
1907
1908         Reviewed by Alexey Proskuryakov.
1909
1910         Fix from <rdar://problem/27786762>, where timed out tests falsely report as crashed.
1911
1912         * Scripts/webkitpy/port/driver.py:
1913         (Driver._check_for_driver_crash_or_unresponsiveness): Change call to ‘write’ to disable crash flag.
1914         * Scripts/webkitpy/port/driver_unittest.py: Added 3 variable to test version of ‘write.’
1915         * Scripts/webkitpy/port/server_process.py:
1916         (ServerProcess.write): Allow caller to disable crash flag on exception.
1917
1918 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
1919
1920         webkitpy error in TestRunResults.merge()
1921         https://bugs.webkit.org/show_bug.cgi?id=160882
1922
1923         Reviewed by Daniel Bates.
1924
1925         The argument to TestRunResults.merge() can be None if there are no device-specifc
1926         initial results or retry results in Manager.run(), so just return early in that case.
1927
1928         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1929         (TestRunResults.merge):
1930
1931 2016-08-15  Sam Weinig  <sam@webkit.org>
1932
1933         Speed up compile times by not including wtf/Variant.h so much
1934         https://bugs.webkit.org/show_bug.cgi?id=160847
1935
1936         Reviewed by Alex Christensen and Saam Barati.
1937
1938         * TestWebKitAPI/Tests/WTF/Variant.cpp:
1939         (TestWebKitAPI::TEST):
1940         Explicitly use std::experimental::variant.
1941
1942 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
1943
1944         Allow a port to run tests with a custom device setup
1945         https://bugs.webkit.org/show_bug.cgi?id=160833
1946
1947         Reviewed by Daniel Bates.
1948
1949         These changes allow the IOSSimulator port to run tests in iPad mode.
1950
1951         This is made possible by allowing a platform to define CUSTOM_DEVICE_CLASSES,
1952         in this case 'ipad'. When specified, any test in a directory with a suffix that matches
1953         a custom device will be collected into a set, and run in that device's environment after
1954         the other tests have run.
1955
1956         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1957         (Manager._custom_device_for_test): If the test contains a directory matching a
1958         custom device suffix, return that custom device.
1959         (Manager._set_up_run): Push the custom device class, if any, into options so
1960         that the Worker can get to it.
1961         (Manager.run): Go through the list of tests, and break it down into device-generic
1962         tests, and tests for each device class. _run_test_subset is then called for
1963         each collection of tests, and the results merged.
1964         (Manager._run_test_subset): Some lines unwrapped.
1965         (Manager._end_test_run):
1966         (Manager._run_tests):
1967         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1968         (SingleTestRunner.__init__): Unwrapped a line.
1969         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1970         (TestRunResults.merge): Add this function to merge TestRunResults
1971         * Scripts/webkitpy/layout_tests/views/printing.py:
1972         (Printer.print_workers_and_shards): Print the custom device, if any.
1973         * Scripts/webkitpy/port/base.py:
1974         (Port): Base port has empty array of custom devices.
1975         (Port.setup_test_run): Add device_class argument.
1976         * Scripts/webkitpy/port/driver.py:
1977         (DriverInput.__repr__):
1978         (Driver.check_driver.implementation):
1979         * Scripts/webkitpy/port/efl.py:
1980         (EflPort.setup_test_run):
1981         * Scripts/webkitpy/port/gtk.py:
1982         (GtkPort.setup_test_run):
1983         * Scripts/webkitpy/port/ios.py:
1984         (IOSSimulatorPort): Add CUSTOM_DEVICE_CLASSES for ipad.
1985         (IOSSimulatorPort.__init__):
1986         (IOSSimulatorPort.simulator_device_type): Use a device name from the DEVICE_CLASS_MAP
1987         based on the custom device class.
1988         (IOSSimulatorPort._set_device_class):
1989         (IOSSimulatorPort._create_simulators): Factor some code into this function.
1990         (IOSSimulatorPort.setup_test_run):
1991         (IOSSimulatorPort.testing_device):
1992         (IOSSimulatorPort.reset_preferences): This used to create the simulator apps, but that
1993         seemed wrong for this function. That was moved to setup_test_run().
1994         (IOSSimulatorPort.check_sys_deps): This function used to create testing devices,
1995         but this happened too early, before we knew which kind of devices to create. Devices
1996         are now created in setup_test_run().
1997         * Scripts/webkitpy/port/win.py:
1998         (WinPort.setup_test_run):
1999
2000 2016-08-15  Daniel Bates  <dabates@apple.com>
2001
2002         Cannot build WebKit for iOS device using Xcode 7.3/iOS 9.3 public SDK due to missing
2003         private frameworks and libraries
2004         https://bugs.webkit.org/show_bug.cgi?id=155931
2005         <rdar://problem/25807989>
2006
2007         Reviewed by Dan Bernstein.
2008
2009         Add directory WebKitLibraries/WebKitPrivateFrameworkStubs/iOS/X to the framework search path
2010         where X is the major version of the active iOS SDK.
2011
2012         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2013         * WebKitTestRunner/Configurations/Base.xcconfig:
2014
2015 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
2016
2017         Add a setting and preferences to enable visual viewport mode
2018         https://bugs.webkit.org/show_bug.cgi?id=160843
2019
2020         Reviewed by Sam Weinig.
2021
2022         Pref and a menu item to toggle visualViewportEnabled for WebKits 1 and 2.
2023
2024         * MiniBrowser/mac/SettingsController.h:
2025         * MiniBrowser/mac/SettingsController.m:
2026         (-[SettingsController _populateMenu]):
2027         (-[SettingsController validateMenuItem:]):
2028         (-[SettingsController visualViewportEnabled]):
2029         (-[SettingsController toggleVisualViewportEnabled:]):
2030         * MiniBrowser/mac/WK1BrowserWindowController.m:
2031         (-[WK1BrowserWindowController didChangeSettings]):
2032         * MiniBrowser/mac/WK2BrowserWindowController.m:
2033         (-[WK2BrowserWindowController didChangeSettings]):
2034
2035 2016-08-15  Konstantin Tokarev  <annulen@yandex.ru>
2036
2037         Allow using make-dist with non-GTK ports
2038         https://bugs.webkit.org/show_bug.cgi?id=160842
2039
2040         Reviewed by Michael Catanzaro.
2041
2042         This patch adds support for setting base name of tarball and argument
2043         passed to cmake's -DPORT= via command line arguments.
2044
2045         * gtk/make-dist.py:
2046         (Distcheck.configure):
2047         (Distcheck.check):
2048         (get_tarball_root_and_output_filename_from_arguments):
2049
2050 2016-08-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2051
2052         [GTK] Install script lacks gstreamer related dependencies
2053         https://bugs.webkit.org/show_bug.cgi?id=160814
2054
2055         Reviewed by Carlos Garcia Campos.
2056
2057         * gtk/install-dependencies: Fedora case had already listed this dependencies,
2058         but both Arch and Debian/Ubuntu were missing them.
2059
2060 2016-08-13  Konstantin Tokarev  <annulen@yandex.ru>
2061
2062         make-dist.py should not allow unknown rules in manifest
2063         https://bugs.webkit.org/show_bug.cgi?id=160841
2064
2065         Reviewed by Carlos Garcia Campos.
2066
2067         * gtk/make-dist.py:
2068         (Manifest.process_line):
2069
2070 2016-08-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2071
2072         [EFL][GTK] Install script not working on Debian 9 (testing) and Ubuntu 16.10
2073         https://bugs.webkit.org/show_bug.cgi?id=160809
2074
2075         Reviewed by Carlos Garcia Campos.
2076
2077         * efl/install-dependencies: Factorize the previous logic for handling the php5/7
2078         case, and use it also for the new package names of libpng and libgeoclue.
2079         * gtk/install-dependencies: Ditto.
2080
2081 2016-08-12  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2082
2083         Skip to check directories existence in build-webkit
2084         https://bugs.webkit.org/show_bug.cgi?id=160691
2085
2086         Reviewed by Alex Christensen.
2087
2088         CMake checks if directories are there itself. So CMake ports
2089         don't need to check it in the build-webkit script.
2090
2091         * Scripts/build-webkit:
2092         * Scripts/webkitdirs.pm:
2093         (determineSourceDir):
2094         (isCMakeBuild):
2095
2096 2016-08-12  Alex Christensen  <achristensen@webkit.org>
2097
2098         Make URLParser work with URLs missing URL parts
2099         https://bugs.webkit.org/show_bug.cgi?id=160824
2100
2101         Reviewed by Brady Eidson.
2102
2103         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2104         (TestWebKitAPI::s):
2105         (TestWebKitAPI::checkURL):
2106         (TestWebKitAPI::TEST_F):
2107         (TestWebKitAPI::eq): Deleted.
2108
2109 2016-08-12  John Wilander  <wilander@apple.com>
2110
2111         Add HashCountedSet API tests to TestWTFLibrary target
2112         https://bugs.webkit.org/show_bug.cgi?id=160815
2113
2114         Reviewed by Alex Christensen.
2115
2116         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2117             Added HashCountedSet.cpp and sorted the file reference section
2118             according to UNIX sort.
2119
2120 2016-08-12  Ryosuke Niwa  <rniwa@webkit.org>
2121
2122         run-benchmark should run JetStream 1.1 instead of 1.0.1
2123         https://bugs.webkit.org/show_bug.cgi?id=160816
2124
2125         Reviewed by Filip Pizlo.
2126
2127         Use the latest JetStream 1.1 in run-benchmark.
2128
2129         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
2130         (BenchmarkBuilder.__exit__):
2131         * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Updated to apply against 1.1 directory.
2132         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Updated to use r190897, which is the last
2133         change to JetStream directory.
2134
2135 2016-08-12  Alex Christensen  <achristensen@webkit.org>
2136
2137         Initial URLParser implementation
2138         https://bugs.webkit.org/show_bug.cgi?id=160811
2139
2140         Reviewed by Brady Eidson.
2141
2142         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2143         (TestWebKitAPI::eq):
2144         (TestWebKitAPI::checkURL):
2145         (TestWebKitAPI::TEST_F):
2146
2147 2016-08-12  Brady Eidson  <beidson@apple.com>
2148
2149         Fix the 32-bit Mac build after:
2150         Add WK2 ExperimentalFeature support to MiniBrowser
2151         https://bugs.webkit.org/show_bug.cgi?id=160788
2152
2153         Unreviewed.
2154
2155         Sprinkle "#if WK_API_ENABLED"s liberally.
2156
2157         * MiniBrowser/mac/AppDelegate.m:
2158         (defaultConfiguration):
2159         * MiniBrowser/mac/SettingsController.m:
2160         (-[SettingsController _populateMenu]):
2161         (-[SettingsController validateMenuItem:]):
2162
2163 2016-08-12  Philippe Normand  <pnormand@igalia.com>
2164
2165         [GStreamer][OWR] Video rendering fixes
2166         https://bugs.webkit.org/show_bug.cgi?id=160764
2167
2168         Reviewed by Xabier Rodriguez-Calvar.
2169
2170         * gtk/jhbuild.modules: Bump to current OpenWebRTC master.
2171
2172 2016-08-12  Per Arne Vollan  <pvollan@apple.com>
2173
2174         Add missing return statement in convertFast function added in r204376.
2175
2176         Unreviewed.
2177
2178         * Scripts/webkitpy/common/system/path.py:
2179         (_CygPath.convertFast):
2180
2181 2016-08-11  Brady Eidson  <beidson@apple.com>
2182
2183         Add WK2 ExperimentalFeature support to MiniBrowser.
2184         https://bugs.webkit.org/show_bug.cgi?id=160788
2185
2186         Reviewed by Alex Christensen.
2187
2188         * MiniBrowser/mac/AppDelegate.h:
2189         * MiniBrowser/mac/AppDelegate.m:
2190         (defaultConfiguration):
2191         (defaultPreferences):
2192
2193         * MiniBrowser/mac/SettingsController.m:
2194         (-[SettingsController _populateMenu]):
2195         (-[SettingsController validateMenuItem:]):
2196         (-[SettingsController toggleExperimentalFeature:]):
2197
2198 2016-08-11  Aakash Jain  <aakash_jain@apple.com>
2199
2200         Keep EWS logs for longer
2201         https://bugs.webkit.org/show_bug.cgi?id=160776
2202
2203         Reviewed by Daniel Bates.
2204
2205         * EWSTools/start-queue-mac.sh: Keep logs for 30 days instead of 14 days.
2206
2207 2016-08-11  Simon Fraser  <simon.fraser@apple.com>
2208
2209         iOS DRT/WTR project cleanup
2210         https://bugs.webkit.org/show_bug.cgi?id=160778
2211
2212         Reviewed by Tim Horton.
2213
2214         Move TARGETED_DEVICE_FAMILY from the project to an xcconfig file.
2215
2216         Remove AppDelegate.* which were unused.
2217
2218         Exclude ios/Launch.storyboard on more platforms.
2219
2220         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2221         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
2222         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
2223         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2224         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.h: Removed.
2225         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.m: Removed.
2226         (-[AppDelegate application:didFinishLaunchingWithOptions:]): Deleted.
2227
2228 2016-08-11  Alex Christensen  <achristensen@webkit.org>
2229
2230         Fix Yosemite bots' cookie accept policies after r204365.
2231         https://bugs.webkit.org/show_bug.cgi?id=160758
2232
2233         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm:
2234         (TEST):
2235         This makes the test fully clean up after itself.
2236
2237 2016-08-11  Alex Christensen  <achristensen@webkit.org>
2238
2239         Fix Yosemite bots' cookie accept policies after r204365.
2240         https://bugs.webkit.org/show_bug.cgi?id=160758
2241
2242         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm:
2243         (TEST):
2244         I didn't restore the cookieAcceptPolicy of the sharedHTTPCookieStorage after changing it with this API test.
2245         On Yosemite, this is changing the cookieAcceptPolicy that DumpRenderTree uses.
2246         On more recent Cocoa platforms, it is only changing the cookieAcceptPolicy that TestWebKitAPI uses, which isn't
2247         causing any problems because there are no other API tests that do anything with cookies.
2248         My solution will be to restore the original cookieAcceptPolicy after running this API test to clean up,
2249         but first I am committing this patch setting the cookieAcceptPolicy to NSHTTPCookieAcceptPolicyOnlyFromMainDocumentDomain
2250         to reset any bots that have run tests since r204365.  I will commit a followup that sets it to originalCookieAcceptPolicy.
2251
2252 2016-08-11  Aakash Jain  <aakash_jain@apple.com>
2253
2254         EWS should check if the patch is still valid before executing every major step
2255         https://bugs.webkit.org/show_bug.cgi?id=160739
2256         rdar://problem/27768813
2257
2258         Reviewed by Alexey Proskuryakov.
2259
2260         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2261         (CommitQueueTask.run): validate method is now executed in base class.
2262         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
2263         (EarlyWarningSystemTask.run): validate method is now executed in base class.
2264         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
2265         (StyleQueueTask.validate): Raise an PatchIsNotValid exception instead of returning False.
2266         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
2267         (PatchAnalysisTask._run_command): validate the patch before executing any command. This is to ensure
2268         that we do not waste time on any patch which has become invalid (e.g.: obsolete, r-).
2269         * Scripts/webkitpy/tool/commands/perfalizer.py:
2270         (PerfalizerTask.validate): Added.
2271         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2272         (test_manual_reject_during_processing): Updated test case.
2273
2274 2016-08-11  Alex Christensen  <achristensen@webkit.org>
2275
2276         Add URLParser stub
2277         https://bugs.webkit.org/show_bug.cgi?id=160770
2278
2279         Reviewed by Sam Weinig.
2280
2281         * TestWebKitAPI/PlatformGTK.cmake:
2282         * TestWebKitAPI/PlatformWin.cmake:
2283         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2284         * TestWebKitAPI/Tests/WebCore/URLParser.cpp: Added.
2285         (TestWebKitAPI::TEST_F):
2286
2287 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
2288
2289         [iOS DRT] Allow DRT to be iPad-sized in the iPad simulator
2290         https://bugs.webkit.org/show_bug.cgi?id=160761
2291
2292         Reviewed by Tim Horton.
2293
2294         Give iOS DRT a Launch storyboard.
2295
2296         Have it use a UIViewController so future forms testing works correctly.
2297
2298         Add TARGETED_DEVICE_FAMILY = "1,2" to the build settings for the .app, so that it
2299         can run in iPad mode.
2300
2301         Remove empty InfoPlist.strings files.
2302
2303         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2304         * DumpRenderTree/ios/Info.plist:
2305         * DumpRenderTree/ios/Launch.storyboard: Added.
2306         * DumpRenderTree/mac/DumpRenderTree.mm:
2307         (createWebViewAndOffscreenWindow):
2308         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2309         * WebKitTestRunner/WebKitTestRunnerApp/en.lproj/InfoPlist.strings: Removed.
2310         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2311         (WTR::PlatformWebView::PlatformWebView): Drive-by leak fix.
2312
2313 2016-08-11  Per Arne Vollan  <pvollan@apple.com>
2314
2315         [Win] Unable to reliably run tests in parallel
2316         https://bugs.webkit.org/show_bug.cgi?id=140914
2317
2318         Reviewed by Brent Fulgham.
2319
2320         The cygpath utility function can fail badly when running with multiple DumpRenderTree
2321         processes. We can use string replacement to convert the Cygwin path to a Windows path
2322         instead.
2323
2324         * Scripts/webkitpy/common/system/path.py:
2325         (cygpathFast):
2326         * Scripts/webkitpy/port/driver.py:
2327         (Driver._command_from_driver_input):
2328
2329 2016-08-10  Alex Christensen  <achristensen@webkit.org>
2330
2331         Fix crash when changing cookie accept policy after r204327
2332         https://bugs.webkit.org/show_bug.cgi?id=160758
2333
2334         Reviewed by Simon Fraser.
2335
2336         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2337         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm: Added.
2338         (-[CookieAcceptPolicyMessageHandler userContentController:didReceiveScriptMessage:]):
2339         (TEST):
2340         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieMessage.html: Added.
2341
2342 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
2343
2344         [iOS WK2] Have WebKitTestRunnerApp.app use a UIViewController, and fix to avoid the status bar
2345         https://bugs.webkit.org/show_bug.cgi?id=160757
2346
2347         Reviewed by Tim Horton.
2348
2349         When programmatically creating the test UIWindow, make a root UIViewController and parent
2350         the WKWebView in its view. This makes the app more like a normal UIKit application.
2351
2352         Move the WKWebView down 20px to avoid the status bar.
2353
2354         Give the UIWindow a gray background so it's obvious where the window and view positioned.
2355
2356         Sorted the project file. Removed the link to UIKit which showed red, and wasn't necessary.
2357
2358         Remove duplicate references to Launch.storyboard.
2359
2360         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2361         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.h: Add license.
2362         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.m: Add license.
2363         (-[AppDelegate applicationWillResignActive:]): Deleted.
2364         (-[AppDelegate applicationDidEnterBackground:]): Deleted.
2365         (-[AppDelegate applicationWillEnterForeground:]): Deleted.
2366         (-[AppDelegate applicationDidBecomeActive:]): Deleted.
2367         (-[AppDelegate applicationWillTerminate:]): Deleted.
2368         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2369         (WTR::viewRectForWindowRect):
2370         (WTR::PlatformWebView::PlatformWebView):
2371         (WTR::PlatformWebView::setWindowFrame):
2372
2373 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
2374
2375         [iOS WK2] Use the simulated device's screen size, rather than a harcoded size
2376         https://bugs.webkit.org/show_bug.cgi?id=160748
2377
2378         Reviewed by Tim Horton.
2379
2380         Use the main UIScreen's bounds for the window size if we're using a flexible viewport. This
2381         opens the door for tests using other device sizes.
2382
2383         * WebKitTestRunner/ios/TestControllerIOS.mm:
2384         (WTR::TestController::platformConfigureViewForTest):
2385
2386 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
2387
2388         Sort the feature flags in the FEATURE_DEFINES lines
2389         https://bugs.webkit.org/show_bug.cgi?id=160742
2390
2391         Reviewed by Anders Carlsson.
2392
2393         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2394
2395 2016-08-09  Simon Fraser  <simon.fraser@apple.com>
2396
2397         Logging and other minor improvements to iOS webkitpy
2398         https://bugs.webkit.org/show_bug.cgi?id=160722
2399
2400         Reviewed by Dan Bates.
2401
2402         Fix --debug-rwt-logging to log all the calls to simctl as well as device state information,
2403         to make it easier to debug launching issues.
2404
2405         Have reset_preferences() reset the device, rather than just nuking the data
2406         directory (which broke some versions of the simulator).
2407
2408         Make the Simulator.app launch in the background with open -g.
2409
2410         Wait for the simulator device to be in a known state in some more places.
2411
2412         * Scripts/webkitpy/port/ios.py:
2413         (IOSSimulatorPort.setup_test_run):
2414         (IOSSimulatorPort._quit_ios_simulator):
2415         (IOSSimulatorPort.clean_up_test_run):
2416         (IOSSimulatorPort.setup_environ_for_server):
2417         (IOSSimulatorPort.reset_preferences):
2418         * Scripts/webkitpy/xcode/simulator.py:
2419         (Device.create):
2420         (Device.delete):
2421         (Device):
2422         (Device.reset):
2423         (Simulator.wait_until_device_is_booted):
2424         (Simulator.wait_until_device_is_in_state):
2425         (Simulator):
2426         (Simulator.delete_device):
2427         (Simulator.reset_device):
2428         (Simulator.lookup_or_create_device):
2429
2430 2016-08-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2431
2432         [GTK][EFL] ALSA_CARD environment variable is not passed for layout tests.
2433         https://bugs.webkit.org/show_bug.cgi?id=160697
2434
2435         Reviewed by Antonio Gomes.
2436
2437         * Scripts/webkitpy/port/base.py:
2438         (Port.to.setup_environ_for_server): Add ALSA_CARD and sort the Linux
2439         list of environment variables to copy.
2440
2441 2016-08-09  George Ruan  <gruan@apple.com>
2442
2443         Implement functionality of media capture on iOS
2444         https://bugs.webkit.org/show_bug.cgi?id=158945
2445         <rdar://problem/26893343>
2446
2447         Reviewed by Tim Horton.
2448
2449         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Enable Media
2450         Capture feature on iOS.
2451
2452 2016-08-09  Saam Barati  <sbarati@apple.com>
2453
2454         Parser<LexerType>::parseFunctionInfo() has the wrong info about captured vars when a function is not cached.
2455         https://bugs.webkit.org/show_bug.cgi?id=160671
2456         <rdar://problem/27756112>
2457
2458         Reviewed by Mark Lam.
2459
2460         * Scripts/run-jsc-stress-tests:
2461
2462 2016-08-09  Alexey Proskuryakov  <ap@apple.com>
2463
2464         Make directory reading code in iOSSimulatorDevices() more strict
2465         https://bugs.webkit.org/show_bug.cgi?id=160702
2466
2467         Reviewed by Tim Horton.
2468
2469         * Scripts/webkitdirs.pm:
2470         (iOSSimulatorDevices):
2471
2472 2016-08-06  Sam Weinig  <sam@webkit.org>
2473
2474         Replace NodeOrString with std::variant<RefPtr<Node>, String>
2475         https://bugs.webkit.org/show_bug.cgi?id=160638
2476
2477         Reviewed by Anders Carlsson.
2478
2479         * TestWebKitAPI/CMakeLists.txt:
2480         * TestWebKitAPI/Tests/WTF/Variant.cpp:
2481         Add additional tests for the initial state of std::variant and using
2482         makeVisitor for visiting.
2483
2484 2016-08-09  Aakash Jain  <aakash_jain@apple.com>
2485
2486         EWS logging should ensure the logging to file is stopped on queue termination
2487         https://bugs.webkit.org/show_bug.cgi?id=160698
2488         rdar://problem/24464570
2489
2490         Reviewed by Daniel Bates.
2491
2492         * Scripts/webkitpy/tool/bot/queueengine.py:
2493         (QueueEngine._stopping): Stop logging to file on queue termination.
2494         (QueueEngine._begin_logging): Configure the Python logger to log to file.
2495         * Scripts/webkitpy/common/system/logutils.py:
2496         (configure_logger_to_log_to_file): Return the handler so as to enable caller to remove it later.
2497         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
2498         (QueueEngineTest._run_engine): Removed extra newline character to improve log readability.
2499         * Scripts/webkitpy/tool/commands/queues.py:
2500         (AbstractQueue._log_directory): Reverting to os.path.join as we don't have host object.
2501         (AbstractQueue.queue_log_path): Same.
2502         (AbstractQueue.begin_work_queue): Removed logging initialization, it is now being done in QueueEngine.
2503         (AbstractQueue.__init__): Removed host parameter, not required anymore, it was required by logging initialization
2504         which moved to QueueEngine now.
2505         (PatchProcessingQueue.__init__): Same.
2506         (CommitQueue.__init__): Same.
2507         (AbstractReviewQueue.__init__): Same.
2508         (StyleQueue.__init__): Same.
2509         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2510         (TestCommitQueue): Removed host parameter.
2511         (TestCommitQueue.__init__): Same.
2512         (AbstractPatchQueueTest.test_next_patch): Same.
2513         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Same.
2514         (test_commit_queue_failure): Same.
2515         (mock_run_webkit_patch):
2516         (MockCommitQueueTask.results_from_patch_test_run): Same.
2517         (test_rollout_lands): Same.
2518         (test_non_valid_patch): Same.
2519         (test_auto_retry): Same.
2520         (test_style_queue_with_watch_list_exception): Same.
2521         (TestQueue.__init__): Deleted.
2522         (TestReviewQueue.__init__): Deleted.
2523         (TestFeederQueue.__init__): Deleted.
2524
2525 2016-08-09  Konstantin Tokarev  <annulen@yandex.ru>
2526
2527         webkit-gtk tarball fails to build due to missing files
2528         https://bugs.webkit.org/show_bug.cgi?id=160684
2529
2530         Reviewed by Alex Christensen.
2531
2532         * gtk/manifest.txt.in: Added back spi directories.
2533
2534 2016-08-09  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2535
2536         [GTK] Build the jhbuild with -O2 optimization level by default
2537         https://bugs.webkit.org/show_bug.cgi?id=160544
2538
2539         Reviewed by Michael Catanzaro.
2540
2541         * gtk/jhbuildrc: Pass -O2 when building the JHBuild, as also -g1
2542         which don't increases the required disk space significatively and
2543         provides better debug information than no passing it.
2544
2545 2016-08-09  Csaba Osztrogonác  <ossy@webkit.org>
2546
2547         Allow more --cmakeargs option in build-jsc and build-webkit
2548         https://bugs.webkit.org/show_bug.cgi?id=160340
2549
2550         Reviewed by Michael Catanzaro.
2551
2552         * Scripts/build-jsc:
2553         * Scripts/build-webkit:
2554
2555 2016-08-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2556
2557         Do not check if WebKitLibraries folder exists on EFL and GTK
2558         https://bugs.webkit.org/show_bug.cgi?id=160659
2559
2560         Reviewed by Csaba Osztrogonác.
2561
2562         Though WebKitLibraries is only needed by mac and win ports,
2563         EFL and GTK ports have checked whether it exists.
2564
2565         * Scripts/build-webkit:
2566
2567 2016-08-08  Aakash Jain  <aakash_jain@apple.com>
2568
2569         Some EWS console logs doesn't go to log file
2570         https://bugs.webkit.org/show_bug.cgi?id=160585
2571         rdar://problem/24464570
2572
2573         Reviewed by Daniel Bates.
2574
2575         * Scripts/webkitpy/common/system/logutils.py:
2576         (FileSystemHandler._open): Ensure that we open logfile in append mode in order to avoid
2577         any possible overwriting.
2578         * Scripts/webkitpy/common/system/filesystem.py:
2579         (FileSystem.open_text_file_for_writing): Add should_append parameter to append to file.
2580         * Scripts/webkitpy/common/system/filesystem_mock.py:
2581         (MockFileSystem.open_text_file_for_writing): Same.
2582         * Scripts/webkitpy/common/system/filesystem_unittest.py:
2583         (RealFileSystemTest.test_read_and_write_text_file): Removed unused variable 'hex_equivalent'.
2584         (RealFileSystemTest.test_append_to_text_file): Added new unit test for testing append functionality.
2585         * Scripts/webkitpy/tool/commands/queues.py:
2586         (AbstractQueue.begin_work_queue): Configure the logger for overall webkitpy to log to file.
2587         This will ensure that all the sub-modules inside webkitpy will log to file.
2588
2589 2016-08-08  Simon Fraser  <simon.fraser@apple.com>
2590
2591         Have the iOS platform interit from the Apple platform in webkitpy
2592         https://bugs.webkit.org/show_bug.cgi?id=160672
2593
2594         Reviewed by Dan Bates.
2595
2596         The IOSSimulatorPort used to inherit from Port, rather than ApplePort.
2597         Fix this, and move duplicated code from IOSSimulatorPort and MacPort into
2598         ApplePort.
2599
2600         Since WinPort also inherits from ApplePort, it needs to stub out some things
2601         that are unavailable on Windows (leaks, sampling).
2602
2603         Some SnowLeopard-related code and the associated test were removed.
2604
2605         * Scripts/webkitpy/port/apple.py:
2606         (ApplePort.__init__):
2607         (ApplePort):
2608         (ApplePort._make_leak_detector):
2609         (ApplePort.default_timeout_ms):
2610         (ApplePort.supports_per_test_timeout):
2611         (ApplePort.should_retry_crashes):
2612         (ApplePort._generate_all_test_configurations):
2613         (ApplePort.check_for_leaks):
2614         (ApplePort.print_leaks_summary):
2615         (ApplePort._path_to_webcore_library):
2616         (ApplePort.show_results_html_file):
2617         (ApplePort._merge_crash_logs):
2618         (ApplePort._look_for_all_crash_logs_in_log_dir):
2619         (ApplePort._get_crash_log):
2620         (ApplePort.look_for_new_crash_logs):
2621         (ApplePort.sample_process):
2622         (ApplePort.sample_file_path):
2623         (ApplePort.look_for_new_samples):
2624         (ApplePort._path_to_helper):
2625         (ApplePort.determine_full_port_name): Deleted.
2626         * Scripts/webkitpy/port/ios.py:
2627         (IOSSimulatorPort):
2628         (IOSSimulatorPort.__init__):
2629         (IOSSimulatorPort.default_timeout_ms): Deleted.
2630         (IOSSimulatorPort.supports_per_test_timeout): Deleted.
2631         (IOSSimulatorPort.should_retry_crashes): Deleted.
2632         (IOSSimulatorPort.check_for_leaks): Deleted.
2633         (IOSSimulatorPort.print_leaks_summary): Deleted.
2634         (IOSSimulatorPort._path_to_webcore_library): Deleted.
2635         (IOSSimulatorPort.show_results_html_file): Deleted.
2636         (IOSSimulatorPort.sample_file_path): Deleted.
2637         (IOSSimulatorPort._merge_crash_logs): Deleted.
2638         (IOSSimulatorPort._look_for_all_crash_logs_in_log_dir): Deleted.
2639         (IOSSimulatorPort.look_for_new_crash_logs): Deleted.
2640         (IOSSimulatorPort.look_for_new_samples): Deleted.
2641         (IOSSimulatorPort.sample_process): Deleted.
2642         (IOSSimulatorPort._path_to_helper): Deleted.
2643         (IOSSimulatorPort.make_command): Deleted.
2644         * Scripts/webkitpy/port/mac.py:
2645         (MacPort.__init__):
2646         (MacPort.make_command):
2647         (MacPort._build_java_test_support):
2648         (MacPort): Deleted.
2649         (MacPort.default_timeout_ms): Deleted.
2650         (MacPort.supports_per_test_timeout): Deleted.
2651         (MacPort.should_retry_crashes): Deleted.
2652         (MacPort.default_child_processes): Deleted.
2653         (MacPort.check_for_leaks): Deleted.
2654         (MacPort.print_leaks_summary): Deleted.
2655         (MacPort._path_to_webcore_library): Deleted.
2656         (MacPort.show_results_html_file): Deleted.
2657         (MacPort.sample_file_path): Deleted.
2658         (MacPort._merge_crash_logs): Deleted.
2659         (MacPort._look_for_all_crash_logs_in_log_dir): Deleted.
2660         (MacPort.look_for_new_crash_logs): Deleted.
2661         (MacPort.look_for_new_samples): Deleted.
2662         (MacPort.sample_process): Deleted.
2663         (MacPort._path_to_helper): Deleted.
2664         * Scripts/webkitpy/port/mac_unittest.py:
2665         (MacTest.test_default_child_processes): Deleted.
2666         * Scripts/webkitpy/port/win.py:
2667         (WinPort.look_for_new_samples):
2668         (WinPort):
2669         (WinPort.sample_process):
2670         (WinPort._make_leak_detector):
2671         (WinPort.check_for_leaks):
2672         (WinPort.print_leaks_summary):
2673         (WinPort._path_to_webcore_library):
2674
2675 2016-08-08  Matt Baker  <mattbaker@apple.com>
2676
2677         Unreviewed: moved myself to the reviewers list.
2678
2679         * Scripts/webkitpy/common/config/contributors.json:
2680
2681 2016-08-08  Chris Dumez  <cdumez@apple.com>
2682
2683         Update API tests in mac/SetDocumentURI.mm after r204247
2684         https://bugs.webkit.org/show_bug.cgi?id=160660
2685
2686         Reviewed by Alex Christensen.
2687
2688         * TestWebKitAPI/Tests/mac/SetDocumentURI.mm:
2689         (TestWebKitAPI::TEST):
2690
2691 2016-08-08  Jonathan Bedard  <jbedard@apple.com>
2692
2693         run-webkit-tests should trigger a spindump when WebContent process is unresponsive
2694         https://bugs.webkit.org/show_bug.cgi?id=159827
2695
2696         Reviewed by Daniel Bates.
2697
2698         This change was spurred by a process hang which occurred between tests and did
2699         not produce a meaningful crashlog.
2700
2701         * Scripts/webkitpy/port/driver.py:
2702         (Driver._check_for_driver_crash_or_unresponsiveness): Notify test controller when finished through stdin.
2703
2704          * Scripts/webkitpy/port/ios.py:
2705         (IOSSimulatorPort):
2706         (IOSSimulatorPort.sample_process): Attempt spindump, but use sample if spindump fails.
2707         * Scripts/webkitpy/port/mac.py:
2708         (MacPort):
2709         (MacPort.sample_process): Attempt spindump, but use sample if spindump fails.
2710
2711         * Scripts/webkitpy/port/mac_unittest.py: Changed expected values to match spindump calls, added specific spindump test.
2712         * Scripts/webkitpy/port/driver_unittest.py: Added dummy write function.
2713
2714         * WebKitTestRunner/TestController.h:
2715         (WTR::TestController::usingServerMode): Added accessor for m_usingServerMode.
2716         * WebKitTestRunner/TestInvocation.cpp:
2717         (WTR::TestInvocation::dumpWebProcessUnresponsiveness): Wait for stdin before continuing when in server mode.
2718
2719 2016-08-07  Dan Bernstein  <mitz@apple.com>
2720
2721         [Cocoa] Reply block leaks if the remote object doesn’t call it
2722         https://bugs.webkit.org/show_bug.cgi?id=160642
2723
2724         Reviewed by Sam Weinig.
2725
2726         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h: Declared a new method.
2727         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
2728         (TEST): Added a test case that checks that the reply block is released even when it’s not
2729           called.
2730         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
2731         (-[RemoteObjectRegistryPlugIn doNotCallCompletionHandler:]): Implement new method by not
2732           calling the completion handler.
2733
2734 2016-08-07  Chris Dumez  <cdumez@apple.com>
2735
2736         Write API test to cover crash fix in r204135
2737         https://bugs.webkit.org/show_bug.cgi?id=160587
2738
2739         Reviewed by Darin Adler.
2740
2741         Add API test to cover crash fix in r204135. This reproduces the crash
2742         by destroying a related WKWebView in the webViewWebContentProcessDidTerminate
2743         callback.
2744
2745         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
2746         (-[NavigationDelegate webViewWebContentProcessDidTerminate:]):
2747         (TEST):
2748
2749 2016-08-06  Chris Dumez  <cdumez@apple.com>
2750
2751         Unreviewed, rolling out r204226.
2752
2753         Broke some API tests
2754
2755         Reverted changeset:
2756
2757         "Write API test to cover crash fix in r204135"
2758         https://bugs.webkit.org/show_bug.cgi?id=160587
2759         http://trac.webkit.org/changeset/204226
2760
2761 2016-08-06  Aakash Jain  <aakash_jain@apple.com>
2762
2763         EWS Style Queue fails to process patches which fails validation
2764         https://bugs.webkit.org/show_bug.cgi?id=160632
2765
2766         Reviewed by Alexey Proskuryakov.
2767
2768         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
2769         (StyleQueueTask.validate): Add more information about validation failure.
2770         (StyleQueueTask.run): Pass the error details in the PatchIsNotValid exception.
2771         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2772         (test_non_valid_patch): Add a unit test to test the above code path.
2773
2774 2016-08-06  Sam Weinig  <sam@webkit.org>
2775
2776         WTF needs a variant implementation
2777         https://bugs.webkit.org/show_bug.cgi?id=160618
2778
2779         Reviewed by Darin Adler.
2780
2781         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2782         * TestWebKitAPI/Tests/WTF/Variant.cpp: Added.
2783         Add tests for the variant implementation.
2784
2785 2016-08-06  Chris Dumez  <cdumez@apple.com>
2786
2787         Write API test to cover crash fix in r204135
2788         https://bugs.webkit.org/show_bug.cgi?id=160587
2789
2790         Reviewed by Darin Adler.
2791
2792         Add API test to cover crash fix in r204135. This reproduces the crash
2793         by destroying a related WKWebView in the webViewWebContentProcessDidTerminate
2794         callback.
2795
2796         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
2797         (-[NavigationDelegate webViewWebContentProcessDidTerminate:]):
2798         (TEST):
2799
2800 2016-08-05  Tim Horton  <timothy_horton@apple.com>
2801
2802         run-api-tests should use a headed simulator
2803         https://bugs.webkit.org/show_bug.cgi?id=160611
2804
2805         Reviewed by Sam Weinig.
2806
2807         CADisplayLink doesn't work in a headless simulator, but is
2808         vital for the proper functioning of WebKit2 painting on iOS.
2809         So, we should not use a headless simulator.
2810
2811         * Scripts/run-api-tests:
2812         Launch a simulator app, don't just boot the simulator.
2813
2814         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
2815         Re-enable a test that works now.
2816
2817 2016-08-05  Dan Bernstein  <mitz@apple.com>
2818
2819         [Cocoa] WKRemoteObjectCoder doesn’t handle NSRange
2820         https://bugs.webkit.org/show_bug.cgi?id=160589
2821
2822         Reviewed by Tim Horton.
2823
2824         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h:
2825         (remoteObjectInterface): Fixed a mistake in the set of allowed classes in one of the reply
2826           blocks, which wasn’t caught because the test wasn’t run correctly.
2827         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
2828         (TEST): Fixed the -selectionAndClickInformationForClickAtPoint:completionHandler: test, and
2829           added a test that sends over an NSRange.
2830         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
2831         (-[RemoteObjectRegistryPlugIn takeRange:completionHandler:]): Added. Calls the completion
2832           handler with the range‘s location and length.
2833
2834 2016-08-05  Enrica Casucci  <enrica@apple.com>
2835
2836         Fixing tests failing after r204175.
2837
2838         Unreviewed.
2839
2840         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig:
2841
2842 2016-08-05  Enrica Casucci  <enrica@apple.com>
2843
2844         Build fix after 204053.
2845
2846         Unreviewed.
2847
2848         * TestWebKitAPI/Configurations/Base.xcconfig:
2849         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
2850         (-[MockContentFilterEnabler initWithCoder:]):
2851         (-[MockContentFilterEnabler dealloc]):
2852
2853 2016-08-05  Konstantin Tokarev  <annulen@yandex.ru>
2854
2855         Print test name in "Last character read from DRT..." error message.
2856         https://bugs.webkit.org/show_bug.cgi?id=160559
2857
2858         Reviewed by Michael Catanzaro.
2859
2860         * Scripts/webkitpy/port/driver.py:
2861         (Driver.run_test):
2862         (Driver._read_first_block):
2863         (Driver._read_optional_image_block):
2864         (Driver._read_block):
2865         * Scripts/webkitpy/port/driver_unittest.py:
2866         (DriverTest.test_read_block):
2867         (DriverTest.test_read_binary_block):
2868         (DriverTest.test_read_base64_block):
2869
2870 2016-08-05  Commit Queue  <commit-queue@webkit.org>
2871
2872         Unreviewed, rolling out r204123.
2873         https://bugs.webkit.org/show_bug.cgi?id=160597
2874
2875         Caused layout test timeouts on Windows. (Requested by perarne
2876         on #webkit).
2877
2878         Reverted changeset:
2879
2880         "[Win] Unable to reliably run tests in parallel"
2881         https://bugs.webkit.org/show_bug.cgi?id=140914
2882         http://trac.webkit.org/changeset/204123
2883
2884 2016-08-04  Saam Barati  <sbarati@apple.com>
2885
2886         Restore CodeBlock jettison code to jettison when a CodeBlock has been alive for a long time
2887         https://bugs.webkit.org/show_bug.cgi?id=151241
2888
2889         Reviewed by Benjamin Poulain.
2890
2891         * Scripts/run-jsc-stress-tests:
2892
2893 2016-08-04  Dean Johnson  <dean_johnson@apple.com>
2894
2895         UI improvements to Flakiness Dashboard.
2896         https://bugs.webkit.org/show_bug.cgi?id=153295
2897
2898         Reviewed by Alexey Proskuryakov.
2899
2900         * TestResultServer/static-dashboards/flakiness_dashboard.css:
2901         (td.options-container): Center text in most fields.
2902         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2903         (createBugHTML): Text/Grammar updates.
2904         (tableHeaders): Ditto.
2905         (htmlForSingleTestRow): Ditto.
2906         (headerForTestTableHtml): Ditto.
2907         * TestResultServer/static-dashboards/ui.js: Removed the "Group: " and "Test type: " headings.
2908         (ui.html.testTypeSwitcher): Deleted. Removes the "Group:" heading.
2909
2910 2016-08-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2911
2912         [GTK] install-dependencies script misses libxslt as build-dependency and some python libs for the run-benchmark script
2913         https://bugs.webkit.org/show_bug.cgi?id=160518
2914
2915         Reviewed by Michael Catanzaro.
2916
2917         * Scripts/webkitpy/thirdparty/__init__.py:
2918         (AutoinstallImportHook._install_twisted): Twisted requires zope.interface.
2919         * gtk/install-dependencies:
2920
2921 2016-08-04  Alexey Proskuryakov  <ap@apple.com>
2922
2923         Optimize bot watcher's dashboard a little
2924         https://bugs.webkit.org/show_bug.cgi?id=160515
2925         rdar://problem/26096900
2926
2927         Reviewed by Lucas Forschler.
2928
2929         Made re-sorting after loading an iteration more efficient.
2930
2931         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2932         (BuildbotIteration.prototype._updateWithData):
2933         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2934         (BuildbotQueue.prototype.updateIterationPosition):
2935
2936 2016-08-04  Per Arne Vollan  <pvollan@apple.com>
2937
2938         [Win] Unable to reliably run tests in parallel
2939         https://bugs.webkit.org/show_bug.cgi?id=140914
2940
2941         Reviewed by Brent Fulgham.
2942
2943         The cygpath utility function can fail badly when running with multiple DumpRenderTree
2944         processes. We can use string replacement to convert the Cygwin path to a Windows path
2945         instead.
2946
2947         * Scripts/webkitpy/common/system/path.py:
2948         (cygpathFast):
2949         * Scripts/webkitpy/port/driver.py:
2950         (Driver._command_from_driver_input):
2951
2952 2016-08-03  Aakash Jain  <aakash_jain@apple.com>
2953
2954         Document instructions for increasing process and file limits
2955         https://bugs.webkit.org/show_bug.cgi?id=160528
2956         rdar://problem/24777576
2957
2958         Reviewed by Alexey Proskuryakov.
2959
2960         * Scripts/webkitpy/port/ios.py:
2961         (IOSSimulatorPort.default_child_processes):
2962
2963 2016-08-03  Anders Carlsson  <andersca@apple.com>
2964
2965         Remove the Objective-C bindings generator
2966         https://bugs.webkit.org/show_bug.cgi?id=160526
2967
2968         Reviewed by Sam Weinig.
2969
2970         * Scripts/run-bindings-tests:
2971         Update test.
2972
2973 2016-08-03  Tim Horton  <timothy_horton@apple.com>
2974
2975         Revise a TestWebKitAPI comment to mention the actual underlying problem
2976
2977         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
2978         Note that this is because of https://bugs.webkit.org/show_bug.cgi?id=160516
2979
2980 2016-08-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2981
2982         Benchmark test content-animation timeouts always
2983         https://bugs.webkit.org/show_bug.cgi?id=160057
2984
2985         Reviewed by Simon Fraser.
2986
2987         * Scripts/webkitpy/benchmark_runner/data/plans/Skipped: Added.
2988         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
2989         (start):
2990
2991 2016-08-02  Nan Wang  <n_wang@apple.com>
2992
2993         AX: Simulated touch events are not working on iOS
2994         https://bugs.webkit.org/show_bug.cgi?id=160395
2995         <rdar://problem/27633597>
2996
2997         Reviewed by Chris Fleizach.
2998
2999         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3000         (WTR::AccessibilityUIElement::press):
3001         (WTR::AccessibilityUIElement::setSelectedChild):
3002
3003 2016-08-02  Filip Pizlo  <fpizlo@apple.com>
3004
3005         run-javascriptcore-tests should accept multiple --extra-tests
3006         https://bugs.webkit.org/show_bug.cgi?id=160486
3007
3008         Reviewed by Saam Barati.
3009
3010         We want to be able to pass --extra-tests multiple times, to supply an arbitrary number of extra
3011         test suites. This does it by using GetOpt::Long's array support.
3012
3013         * Scripts/run-javascriptcore-tests:
3014         (runJSCStressTests):
3015
3016 2016-08-02  Enrica Casucci  <enrica@apple.com>
3017
3018         Allow building with content filtering disabled.
3019         https://bugs.webkit.org/show_bug.cgi?id=160454
3020
3021         Reviewed by Simon Fraser.
3022
3023         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3024
3025 2016-08-02  Brady Eidson  <beidson@apple.com>
3026
3027         Removing IndexedDB WebsiteData can fail for some users.
3028         https://bugs.webkit.org/show_bug.cgi?id=160463
3029
3030         Reviewed by Alex Christensen.
3031
3032         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm:
3033
3034 2016-08-01  Alex Christensen  <achristensen@webkit.org>
3035
3036         _WKDownloadDelegate.didReceiveResponse should be called before decideDestinationWithSuggestedFilename
3037         https://bugs.webkit.org/show_bug.cgi?id=160437
3038         <rdar://problem/27578272>
3039
3040         Reviewed by Brady Eidson.
3041
3042         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
3043         (-[DownloadDelegate _download:didReceiveResponse:]):
3044         (-[DownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
3045         (runTest):
3046         Add a boolean to make sure that didReceiveResponse is called before decideDestinationWithSuggestedFilename.
3047
3048 2016-08-01  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3049
3050         [Tools] The GDB backtrace report tool don't checks the gdb return code.
3051         https://bugs.webkit.org/show_bug.cgi?id=160414
3052
3053         Reviewed by Michael Catanzaro.
3054
3055         * Scripts/webkitpy/port/linux_get_crash_log.py:
3056         (GDBCrashLogGenerator._wait_for_corefile):
3057
3058 2016-08-01  Youenn Fablet  <youenn@apple.com>
3059
3060         Make wpt server generate its certificates in layout test results folder
3061         https://bugs.webkit.org/show_bug.cgi?id=160422
3062
3063         Reviewed by Chris Dumez.
3064
3065         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
3066         (WebPlatformTestServer._copy_webkit_test_files): Setting certificate folder to layout tests results directory.
3067
3068 2016-08-01  Jonathan Bedard  <jbedard@apple.com>
3069
3070         Function Call on NULL Object
3071         https://bugs.webkit.org/show_bug.cgi?id=160325
3072
3073         Reviewed by Darin Adler.
3074
3075         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3076         (WTR::InjectedBundle::didReceiveMessageToPage): Changed removeAllWebNotificationPermissions() call to static function call.
3077         * WebKitTestRunner/InjectedBundle/TestRunner.h: Made all web-notification functions static.
3078
3079 2016-08-01  Keith Miller  <keith_miller@apple.com>
3080
3081         We should not keep the JavaScript tests inside the Source/JavaScriptCore/ directory.
3082         https://bugs.webkit.org/show_bug.cgi?id=160372
3083
3084         Rubber stamped by Geoffrey Garen.
3085
3086         This patch moves all the JavaScript tests from Source/JavaScriptCore/tests to
3087         a new top level directory, JSTests. Having the tests in the Source directory
3088         was both confusing an inconvenient for people that just want to checkout the
3089         source code of WebKit. Since there is no other obvious place to put all the
3090         JavaScript tests a new top level directory seemed the most sensible.
3091
3092         * Scripts/import-test262-tests:
3093         * Scripts/run-javascriptcore-tests:
3094         * Scripts/update-javascriptcore-test-res:
3095
3096 2016-07-31  Nan Wang  <n_wang@apple.com>
3097
3098         AX: Add a check for touch event listener on iOS accessibility object
3099         https://bugs.webkit.org/show_bug.cgi?id=160388
3100
3101         Reviewed by Chris Fleizach.
3102
3103         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3104         (AccessibilityUIElement::boolAttributeValue):
3105         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3106         (WTR::AccessibilityUIElement::boolAttributeValue):
3107
3108 2016-07-30  Manuel Rego Casasnovas  <rego@igalia.com>
3109
3110         Unreviewed: add myself to the reviewers list.
3111
3112         * Scripts/webkitpy/common/config/contributors.json:
3113
3114 2016-07-29  Alexey Proskuryakov  <ap@apple.com>
3115
3116         Undo r203939, and copy over a rule that clips the logos.
3117
3118         Sierra wasn't the only logo without transparency.
3119
3120         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra.png:
3121         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra@2x.png:
3122         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3123
3124 2016-07-29  Alan Sien Wei Hshieh  <hshieh@apple.com>
3125
3126         The Sierra asset at build.webkit.org/dashboard/images/Sierra*.png has a white background
3127         https://bugs.webkit.org/show_bug.cgi?id=160377
3128
3129         Reviewed by Brian Weinstein.
3130
3131         Update assets to remove the white background and use a transparent background instead.
3132
3133         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra.png:
3134         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra@2x.png:
3135
3136 2016-07-29  David Kilzer  <ddkilzer@apple.com>
3137
3138         Ignore most check-webkit-style checks for ANGLE project
3139         <https://webkit.org/b/160333>
3140
3141         Reviewed by Daniel Bates.
3142
3143         * Scripts/webkitpy/style/checker.py: Ignore all checkers except:
3144         - No tabs.
3145         - No spaces at the end of lines.
3146         - No carriage returns (DOS line endings).
3147
3148 2016-07-29  Wenson Hsieh  <wenson_hsieh@apple.com>
3149
3150         Media controls are not displayed for some autoplaying videos at certain browser dimensions
3151         https://bugs.webkit.org/show_bug.cgi?id=160360
3152         <rdar://problem/27179484>
3153
3154         Reviewed by Myles C. Maxfield.
3155
3156         Adds two tests verifying that videos may be considered main content as long as they
3157         are large enough and cover a majority of the mainframe's viewport.
3158
3159         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3160         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
3161         (TestWebKitAPI::TEST):
3162         * TestWebKitAPI/Tests/WebKit2Cocoa/full-size-autoplaying-video-with-audio.html: Added.
3163         * TestWebKitAPI/Tests/WebKit2Cocoa/skinny-autoplaying-video-with-audio.html: Added.
3164
3165 2016-07-29  Mark Lam  <mark.lam@apple.com>
3166
3167         Gardening: removed unused variable.
3168
3169         Not reviewed.
3170
3171         * TestWebKitAPI/Tests/WTF/StringView.cpp:
3172         (TestWebKitAPI::TEST):
3173
3174 2016-07-29  Wenson Hsieh  <wenson_hsieh@apple.com>
3175
3176         Add TestWebKitAPI support for interacting with media controls
3177         https://bugs.webkit.org/show_bug.cgi?id=160342
3178         <rdar://problem/27610246>
3179
3180         Reviewed by Beth Dakin.
3181
3182         Adds support for testing interaction with some media controls, as well as a basic test
3183         verifying that media control teardown after interaction does not result in a crash.
3184
3185         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
3186         (-[WKWebView mouseDownAtPoint:]):
3187         (-[WKWebView performAfterLoading:]):
3188         (TestWebKitAPI::TEST):
3189
3190 2016-07-29  Jonathan Bedard  <jbedard@apple.com>
3191
3192         Crash Log Clobbering on Unbound Crashes
3193         https://bugs.webkit.org/show_bug.cgi?id=160198
3194         <rdar://problem/27472618>
3195
3196         Reviewed by Alexey Proskuryakov.
3197
3198         * Scripts/webkitpy/common/system/crashlogs.py:
3199         (CrashLogs): Fix header order.
3200         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
3201         (TestResultWriter.output_filename): Only remove file extension if it is clearly a file extension.
3202
3203 2016-07-29  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
3204
3205         Update for contributors.json
3206         https://bugs.webkit.org/show_bug.cgi?id=160294
3207
3208         * Scripts/webkitpy/common/config/contributors.json:
3209
3210 2016-07-28  Myles C. Maxfield  <mmaxfield@apple.com>
3211
3212         Remove deprecated SPI for video inline / fullscreen controls
3213         https://bugs.webkit.org/show_bug.cgi?id=160318
3214
3215         Reviewed by Tim Horton.
3216
3217         * DumpRenderTree/mac/DumpRenderTree.mm:
3218         (setDefaultsToConsistentValuesForTesting): Deleted.
3219         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
3220         (RequiresUserActionForPlaybackTest::SetUp): Deleted.
3221         * WebKitTestRunner/TestController.cpp:
3222         (WTR::TestController::resetPreferencesToConsistentValues): Deleted.
3223         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3224         (WTR::initializeWebViewConfiguration): Deleted.
3225
3226 2016-07-28  Daniel Bates  <dabates@apple.com>
3227
3228         [iOS] TestWebKitAPI bundle targets are not code signed
3229         https://bugs.webkit.org/show_bug.cgi?id=160328
3230         <rdar://problem/27409246>
3231
3232         Reviewed by Andy Estes.
3233
3234         Workaround <rdar://problem/27459890> by explicitly defining Xcode build settings
3235         CODE_SIGNING_ALLOWED and AD_HOC_CODE_SIGNING_ALLOWED to be YES so as to allow the
3236         the TestWebKitAPI bundle targets to be code signed when building for the iOS simulator.
3237
3238         * TestWebKitAPI/Configurations/Base.xcconfig:
3239
3240 2016-07-28  Tim Horton  <timothy_horton@apple.com>
3241
3242         Disable WebKit2.ResizeWithHiddenContentDoesNotHang for now
3243
3244         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
3245         (animatedResizeWebView):
3246         (TEST):
3247         This test times out only when run in the WebKit Testing simulator environment,
3248         but not in a fresh simulator. Disabling to keep the bots green while under investigation.
3249
3250 2016-07-28  Tim Horton  <timothy_horton@apple.com>
3251
3252         Frequent animation lags when interacting with Safari (sidebar, tab switching, etc.)
3253         https://bugs.webkit.org/show_bug.cgi?id=160289
3254         <rdar://problem/27553464>
3255
3256         Reviewed by Simon Fraser.
3257
3258         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
3259         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3260         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm: Added.
3261         (-[AnimatedResizeNavigationDelegate _webView:renderingProgressDidChange:]):
3262         (-[AnimatedResizeWebView _endAnimatedResize]):
3263         (animatedResizeWebView):
3264         (TEST):
3265         * TestWebKitAPI/Tests/WebKit2Cocoa/blinking-div.html: Added.
3266         Add two tests that ensure that hidden-content and animated resizes
3267         don't cause unnecessary synchronous waits. Only the hidden-content
3268         one fails before my patch, but it seemed reasonable to add both anyway.
3269
3270 2016-07-28  David Kilzer  <ddkilzer@apple.com>
3271
3272         webkit-patch upload --suggest-reviewers shouldn't break in the presence of deleted or moved files
3273         <https://webkit.org/b/83342>
3274
3275         Reviewed by Ryosuke Niwa.
3276
3277         * Scripts/webkitpy/common/checkout/scm/git.py:
3278         (Git.revisions_changing_file): Remove code to raise an exception
3279         when the file doesn't exist.  If a file was moved or renamed,
3280         then this caused the script to terminate, which was very
3281         frustrating when you wanted a list of reviewers.
3282         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3283         (SCMTest._shared_test_revisions_changing_file): Update test
3284         expectation to return an empty list of revisions.
3285         (test_create_patch_is_full_patch): Drive-by fix when running all
3286         webkitpy tests (including scm tests).
3287         * Scripts/webkitpy/common/checkout/scm/svn.py:
3288         (SVN.revisions_changing_file): Catch ScriptError exceptions and
3289         return an empty array of revisions if this occurs.
3290
3291 2016-07-28  Aakash Jain  <aakash_jain@apple.com>
3292
3293         EWS error message "Error: * did not process patch" should include explanation
3294         https://bugs.webkit.org/show_bug.cgi?id=159903
3295         <rdar://problem/27410788>
3296
3297         Reviewed by Alexey Proskuryakov.
3298
3299         * QueueStatusServer/handlers/statusbubble.py:
3300         (StatusBubble._build_bubble): Display more detailed error message on bubbles when patch
3301         is not processed.
3302         * QueueStatusServer/handlers/processingtimesjson.py:
3303         (ProcessingTimesJSON._resultFromFinalStatus): Updated error message to match with rest
3304         of the code.
3305         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3306         (CommitQueueTask.validate): Add more information about validation failure.
3307         (CommitQueueTask.run): Pass the error details in the PatchIsNotValid exception.
3308         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
3309         (EarlyWarningSystemTask.validate): Add more information about validation failure.
3310         (EarlyWarningSystemTask.run): Pass the error details in the PatchIsNotValid exception.
3311         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
3312         (PatchIsNotValid.__init__): Add the failure_message argument.
3313         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3314         (AbstractEarlyWarningSystem.review_patch): Re-word the error message and include
3315         failure details.
3316         * Scripts/webkitpy/tool/commands/queues.py:
3317         (CommitQueue.process_work_item): Same.
3318         (StyleQueue.review_patch): Same.
3319         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3320         (test_non_valid_patch): Updated test-cases messages to match the above changes.
3321
3322 2016-07-27  Alexey Proskuryakov  <ap@apple.com>
3323
3324         LayoutTestRelay should wait for WebKitTestRunnerApp installation to complete
3325         https://bugs.webkit.org/show_bug.cgi?id=160262
3326
3327         Reviewed by Daniel Bates.
3328
3329         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
3330         (-[LTRelayController installApp]):
3331
3332 2016-07-27  Ryan Haddad  <ryanhaddad@apple.com>
3333
3334         Disable WebCoreNSURLSessionTest API tests on ios-simulator
3335         https://bugs.webkit.org/show_bug.cgi?id=160225
3336
3337         Reviewed by Alexey Proskuryakov.
3338
3339         * TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm:
3340
3341 2016-07-27  Miguel Gomez  <magomez@igalia.com>
3342
3343         [GTK] Fix some video/canvas tests that should be passing
3344         https://bugs.webkit.org/show_bug.cgi?id=160023
3345
3346         Reviewed by Carlos Garcia Campos.
3347
3348         Add a platform identifier to the TestRunner's page user agent when the tests are run on the
3349         EFL or GTK platforms.
3350
3351         * WebKitTestRunner/efl/TestControllerEfl.cpp:
3352         (WTR::TestController::platformConfigureViewForTest):
3353         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
3354         (WTR::TestController::platformConfigureViewForTest):
3355
3356 2016-07-27  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3357
3358         [Tools] The built product doesn't contains the dwo files when DEBUG_FISSION is enabled.
3359         https://bugs.webkit.org/show_bug.cgi?id=160247
3360
3361         Reviewed by Michael Catanzaro.
3362
3363         * BuildSlaveSupport/built-product-archive:
3364         (createZip):
3365         (dirContainsdwo):
3366         (archiveBuiltProduct):
3367
3368 2016-07-26  Alex Christensen  <achristensen@webkit.org>
3369
3370         Fix tests after r203743.
3371         https://bugs.webkit.org/show_bug.cgi?id=156947
3372
3373         * WebKitTestRunner/TestController.cpp:
3374         (WTR::TestController::resetStateToConsistentValues):
3375         Reset the new boolean m_rejectsProtectionSpaceAndContinueForAuthenticationChallenges.
3376
3377 2016-07-26  Myles C. Maxfield  <mmaxfield@apple.com>
3378
3379         [iPhone] Playing a video on tudou.com plays only sound, no video
3380         https://bugs.webkit.org/show_bug.cgi?id=160178
3381         <rdar://problem/27535468>
3382
3383         Reviewed by Dan Bernstein.
3384
3385         * DumpRenderTree/mac/DumpRenderTree.mm:
3386         (setDefaultsToConsistentValuesForTesting):
3387         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
3388         (RequiresUserActionForPlaybackTest::SetUp):
3389         * WebKitTestRunner/TestController.cpp:
3390         (WTR::TestController::resetPreferencesToConsistentValues):
3391         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3392         (WTR::initializeWebViewConfiguration):
3393
3394 2016-07-26  Simon Fraser  <simon.fraser@apple.com>
3395
3396         Allow LOG macros to be used outside the namespace, and other logging cleanup
3397         https://bugs.webkit.org/show_bug.cgi?id=160216
3398
3399         Reviewed by Anders Carlsson.
3400
3401         initializeLoggingChannelsIfNecessary -> initializeLogChannelsIfNecessary
3402
3403         * DumpRenderTree/TestRunner.cpp:
3404         * DumpRenderTree/mac/DumpRenderTree.mm:
3405         (resetWebViewToConsistentStateBeforeTesting):
3406
3407 2016-07-26  David Kilzer <ddkilzer@apple.com>
3408
3409         Networking process crash due to missing -[WebCoreAuthenticationClientAsChallengeSender performDefaultHandlingForAuthenticationChallenge:] implementation
3410         https://bugs.webkit.org/show_bug.cgi?id=156947
3411         <rdar://problem/23325160>
3412
3413         Reviewed by Alex Christensen.
3414
3415         * DumpRenderTree/TestRunner.cpp:
3416         (TestRunner::TestRunner):
3417         (setRejectsProtectionSpaceAndContinueForAuthenticationChallengesCallback):
3418         * DumpRenderTree/TestRunner.h:
3419         (TestRunner::rejectsProtectionSpaceAndContinueForAuthenticationChallenges):
3420         (TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
3421         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
3422         (-[ResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]):
3423         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3424         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3425         (WTR::TestRunner::queueNonLoadingScript):
3426         (WTR::TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
3427         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3428         * WebKitTestRunner/TestController.cpp:
3429         (WTR::TestController::didReceiveAuthenticationChallenge):
3430         * WebKitTestRunner/TestController.h:
3431         (WTR::TestController::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
3432         * WebKitTestRunner/TestInvocation.cpp:
3433         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3434         Add TestRunner.setRejectsProtectionSpaceAndContinueForAuthenticationChallenges to use for testing.
3435
3436 2016-07-26  David Kilzer  <ddkilzer@apple.com>
3437
3438         check-for-exit-time-destructors should be usable outside Xcode
3439         <https://webkit.org/b/160195>
3440
3441         Reviewed by Darin Adler.
3442
3443         * Scripts/check-for-exit-time-destructors: Update to parse
3444         -h|--help switch, or to take one argument to a binary to check
3445         for exit time destructors on the command-line.  The clang
3446         compiler will find these at compile-time with the
3447         -Wexit-time-destructors switch, but this script will check for
3448         them after-the-fact.
3449
3450 2016-07-26  Lucas Forschler  <lforschler@apple.com>
3451
3452         Test svn.webkit.org functionality after maintenance.
3453
3454 2016-07-25  Brady Eidson  <beidson@apple.com>
3455
3456         Modern IDB: Make sure IndexedDB works from file:// url documents by default
3457         https://bugs.webkit.org/show_bug.cgi?id=153783
3458
3459         Reviewed by Alex Christensen.
3460
3461         Previously, to grant IndexedDB access to file:// urls for testing purposes,
3462         we had to call the SPI [WKWebViewConfiguration _setAllowUniversalAccessFromFileURLs:].
3463
3464         As of https://trac.webkit.org/changeset/203695 this is no longer required.
3465
3466         Change the relevant API tests to make sure this continues to be no longer required.
3467
3468         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm:
3469         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm:
3470         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
3471         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm:
3472         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm:
3473         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
3474
3475 2016-07-25  Wenson Hsieh  <wenson_hsieh@apple.com>
3476
3477         Media controls should not be displayed for a video until it starts playing
3478         https://bugs.webkit.org/show_bug.cgi?id=160092
3479         <rdar://problem/26986673>
3480
3481         Reviewed by Beth Dakin.
3482
3483         Verify that multiple videos do or don't show the media controller depending on whether videos
3484         are playing. Also tweaks an existing API test (VideoControlsManagerSingleLargeVideo) that was
3485         passing because we were always showing media controls for large videos with audio, even if they
3486         had not played back yet. This change ensures that large videos with audio show media controls
3487         only after they begin to play back, and not by virtue of being large enough for main content.
3488
3489         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3490         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
3491         (TestWebKitAPI::TEST):
3492         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-with-audio.html:
3493         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-with-audio-autoplay.html: Added.
3494         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-with-audio.html: Added.
3495
3496 2016-07-25  Wenson Hsieh  <wenson_hsieh@apple.com>
3497
3498         Media controls on apple.com don't disappear when movie finishes playing
3499         https://bugs.webkit.org/show_bug.cgi?id=160068
3500         <rdar://problem/26668526>
3501
3502         Reviewed by Darin Adler.
3503
3504         Adds new API tests. Please see WebCore ChangeLog for more details.
3505
3506         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3507         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
3508         (-[MediaPlaybackMessageHandler initWithWKWebView:finalMessageString:]):
3509         (-[MediaPlaybackMessageHandler userContentController:didReceiveScriptMessage:]):
3510         (TestWebKitAPI::TEST):
3511         (-[DidPlayMessageHandler initWithWKWebView:]): Deleted.
3512         (-[DidPlayMessageHandler userContentController:didReceiveScriptMessage:]): Deleted.
3513         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-hides-controls-after-seek-to-end.html: Added.
3514         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-seek-after-ending.html: Added.
3515         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-seek-to-beginning-and-play-after-ending.html: Added.
3516
3517 2016-07-25  Philippe Normand  <pnormand@igalia.com>
3518
3519         Unreviewed, fix test-webkitpy after r203674.
3520
3521         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
3522         (GDBCrashLogGeneratorTest.test_generate_crash_log):
3523
3524 2016-07-24  Philippe Normand  <pnormand@igalia.com>
3525
3526         Unreviewed, forgot to commit this file in r203674.
3527
3528         * Scripts/process-linux-coredump: Added.
3529         (main):
3530
3531 2016-07-25  Philippe Normand  <pnormand@igalia.com>
3532
3533         Improve GDB backtrace generation for GTK/EFL
3534         https://bugs.webkit.org/show_bug.cgi?id=128928
3535
3536         Reviewed by Carlos Garcia Campos.
3537
3538         The PID of the crashed process is now correctly supplied to the
3539         crash log reporter. The kernel core_pattern needs to be updated
3540         after this change to something like:
3541
3542         echo "|/home/phil/WebKit/Tools/Scripts/process-linux-coredump /tmp/core-pid_%p.dump" > /proc/sys/kernel/core_pattern
3543
3544         * Scripts/process-linux-coredump: Added.
3545         (main): Minimal python script reading coredump data on stdin and writing it to a file in /tmp/.
3546         * Scripts/webkitpy/port/efl.py:
3547         (EflPort._get_crash_log): Supply path of the process-linux-coredump script.
3548         * Scripts/webkitpy/port/gtk.py:
3549         (GtkPort._get_crash_log): Ditto.
3550         * Scripts/webkitpy/port/linux_get_crash_log.py:
3551         (GDBCrashLogGenerator.__init__): New argument for supplying the path of a coredump processor script.
3552         (GDBCrashLogGenerator.generate_crash_log): Update error message, the core_pattern should now be set to pipe coredumps to a script.
3553         (GDBCrashLogGenerator): Deleted.
3554         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
3555         (GDBCrashLogGeneratorTest.test_generate_crash_log): Update test expectations.
3556         * WebKitTestRunner/TestController.cpp:
3557         (WTR::TestController::networkProcessDidCrash): Supply PID of crash process.
3558         (WTR::TestController::databaseProcessDidCrash): Ditto.
3559         (WTR::TestController::processDidCrash): Ditto.
3560
3561 2016-07-23  Youenn Fablet  <youenn@apple.com>
3562
3563         WPT stash server should be kept running when launching wpt server
3564         https://bugs.webkit.org/show_bug.cgi?id=160052
3565
3566         Reviewed by Sam Weinig.
3567
3568         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
3569         (main): waiting to read stdin while stash server is started.
3570
3571 2016-07-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3572
3573         Media controls should be displayed for media in media documents
3574         https://bugs.webkit.org/show_bug.cgi?id=160104
3575         <rdar://problem/27438936>
3576
3577         Reviewed by Myles C. Maxfield.
3578
3579         Verifies that even a small video with audio in a media document gets media controls.
3580
3581         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
3582         (TestWebKitAPI::TEST):
3583
3584 2016-07-22  Michael Saboff  <msaboff@apple.com>
3585
3586         REGRESSION(203616): no FTL testing was inadvertently removed
3587         https://bugs.webkit.org/show_bug.cgi?id=160100
3588
3589         Rubber-stamped by Filip Pizlo.
3590
3591         Added runNoFTL back into the set of tests we run on FTL enabled platforms.
3592         Renamed runLayoutTestNoFTL to runLayoutTestDefault.  Restructured the test
3593         logic for the runLayout and runNoisy variants to match the run test logic,
3594         that is we always invoke runXXXDefault and invoke runXXXNoFTL for FTL
3595         enabled platforms.
3596
3597         * Scripts/run-jsc-stress-tests:
3598
3599 2016-07-22  Brady Eidson  <beidson@apple.com>
3600
3601         Removing IndexedDatabases that have stored blobs doesn't remove the blob files.
3602         https://bugs.webkit.org/show_bug.cgi?id=160089
3603
3604         Reviewed by Darin Adler.
3605
3606         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3607         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm: Added.
3608         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobToBeDeleted.html: Added.
3609
3610 2016-07-22  Konstantin Tokarev  <annulen@yandex.ru>
3611
3612         [GTK] Improved exclusion patterns in make-dist.py manifest.
3613         https://bugs.webkit.org/show_bug.cgi?id=160094
3614
3615         Reviewed by Michael Catanzaro.
3616
3617         * gtk/manifest.txt.in:
3618         Exclude Platform*.cmake files for more ports.
3619         Removed obsolete .gyp and .pro.user patterns.
3620         Exclude 'Configurations' and 'spi' directories.
3621         Exclude CMakeLists.txt.user (Qt Creator IDE).
3622
3623 2016-07-22  Michael Saboff  <msaboff@apple.com>
3624
3625         Don't run FTL related JSC stress tests on non-FTL platforms
3626         https://bugs.webkit.org/show_bug.cgi?id=160033
3627
3628         Reviewed by Mark Lam.
3629
3630         Added check for running tests on platforms that don't enable FTL to not run FTL tests.
3631         Refactored several of the runXXX test methods to always runXXXDefault and made those
3632         runXXXDefault to pass FTL_OPTIONS.  For platforms that don't enable the FTL, FTL_OPTIONS
3633         doesn't cause a problem.
3634
3635         * Scripts/run-jsc-stress-tests:
3636
3637 2016-07-22  Per Arne Vollan  <pvollan@apple.com>
3638
3639         IWebView::mainFrame crashes if called after IWebView::close
3640         https://bugs.webkit.org/show_bug.cgi?id=32868
3641
3642         Reviewed by Brent Fulgham.
3643
3644         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp:
3645         (TestWebKitAPI::TEST_F): Added test.
3646
3647 2016-07-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3648
3649         [GTK] Enable threaded compositor by default
3650         https://bugs.webkit.org/show_bug.cgi?id=160079
3651
3652         Reviewed by Žan Doberšek.
3653
3654         * Scripts/webkitperl/FeatureList.pm:
3655
3656 2016-07-22  Youenn Fablet  <youenn@apple.com>
3657
3658         run-builtins-generator-tests should be able to test WebCore builtins wrapper with more than one file
3659         https://bugs.webkit.org/show_bug.cgi?id=159921
3660
3661         Reviewed by Brian Burg.
3662
3663         Updated builtin generator test runner to generate WebCore wrapper files based on all WebCore valid separate files.
3664
3665         * Scripts/webkitpy/codegen/main.py:
3666         (BuiltinsGeneratorTests.generate_from_js_builtins): Passing a list of builtin files to the script.
3667         (BuiltinsGeneratorTests):
3668         (BuiltinsGeneratorTests.single_builtin_test): Added to handle the case of single builtin generation.
3669         (BuiltinsGeneratorTests.wrappers_builtin_test): Added to handle the case of WebCore wrappers builtin generation.
3670         (BuiltinsGeneratorTests.run_test): Helper routine to run a test in reset mode or normal check mode.
3671         (BuiltinsGeneratorTests.run_tests): Updated to add WebCore wrappers builtin generation test.
3672
3673 2016-07-21  Dan Bernstein  <mitz@apple.com>
3674
3675         [Mac] webkitdirs.pm contains unused code to support outdated OS X and Xcode versions
3676         https://bugs.webkit.org/show_bug.cgi?id=160072
3677
3678         Reviewed by Andy Estes.
3679
3680         * Scripts/webkitdirs.pm:
3681         (readXcodeUserDefault): Changed to take a defaults key rather than a suffix. Removed support
3682           for old Xcode versions.
3683         (determineBaseProductDir): Removed support for old Xcode versions. Updated for the change
3684           to readXcodeUserDefault.
3685         (debugger): Deleted. This was only used for Darwin, where LLDB is now the only supported
3686           debugger.
3687         (determineDebugger): Ditto.
3688         (checkRequiredSystemConfig): Updated to require at least OS X Yosemite v10.10.5 and Xcode
3689           7.0.
3690         (printHelpAndExitForRunAndDebugWebKitAppIfNeeded): Removed --use-gdb and --use-lldb
3691           switches.
3692         (execMacWebKitAppForDebugging): Removed support for GDB.
3693
3694 2016-07-21  Myles C. Maxfield  <mmaxfield@apple.com>
3695
3696         Remove support for deprecated SPI inlineMediaPlaybackRequiresPlaysInlineAttribute
3697         https://bugs.webkit.org/show_bug.cgi?id=160066
3698
3699         Reviewed by Dean Jackson.
3700
3701         * DumpRenderTree/mac/DumpRenderTree.mm:
3702         (setDefaultsToConsistentValuesForTesting): Deleted.
3703         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
3704         (RequiresUserActionForPlaybackTest::SetUp): Deleted.
3705         * WebKitTestRunner/TestController.cpp:
3706         (WTR::TestController::resetPreferencesToConsistentValues): Deleted.
3707         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3708         (WTR::initializeWebViewConfiguration): Deleted.
3709
3710 2016-07-21  Chelsea Pugh  <cpugh@apple.com>
3711
3712         [iOS] Apps using WKWebView will crash if they set the scroll view's delegate and don't nil it out later
3713         https://bugs.webkit.org/show_bug.cgi?id=159980
3714         rdar://problem/27450825
3715
3716         Reviewed by Dan Bernstein.
3717
3718         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3719         * TestWebKitAPI/Tests/ios/WKScrollViewDelegateCrash.mm: Added.
3720         (-[TestDelegateForScrollView dealloc]): Update delegateIsDeallocated to true so that we can tell
3721         when our delegate has hit -dealloc.
3722         (TestWebKitAPI::TEST): Ensure that after an object has been set as the scroll view's delegate,
3723         and has then been deallocated, that the scroll view's delegate is nil and the deallocated delegate
3724         will not be messaged.
3725
3726 2016-07-21  Myles C. Maxfield  <mmaxfield@apple.com>
3727
3728         Follow-up patch to r203520
3729         https://bugs.webkit.org/show_bug.cgi?id=159967
3730         <rdar://problem/26964090>
3731
3732         Unreviewed.
3733
3734         * DumpRenderTree/mac/DumpRenderTree.mm:
3735         (setDefaultsToConsistentValuesForTesting):
3736         * WebKitTestRunner/TestController.cpp:
3737         (WTR::TestController::resetPreferencesToConsistentValues):
3738
3739 2016-07-21  Myles C. Maxfield  <mmaxfield@apple.com>
3740
3741         [iPhone] Playing a video on tudou.com plays only sound, no video
3742         https://bugs.webkit.org/show_bug.cgi?id=159967
3743         <rdar://problem/26964090>
3744
3745         Reviewed by Jon Lee, Jeremy Jones, and Anders Carlsson.
3746
3747         Migrate tests to use new SPI.
3748
3749         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
3750         (RequiresUserActionForPlaybackTest::SetUp):
3751         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3752         (WTR::initializeWebViewConfiguration):
3753
3754 2016-07-21  Csaba Osztrogonác  <ossy@webkit.org>
3755
3756         Clarify testing mode names in run-jsc-stress-tests
3757         https://bugs.webkit.org/show_bug.cgi?id=160021
3758
3759         Reviewed by Mark Lam.
3760
3761         Default should mean really default, not default with disabled FTL, renamed
3762         - runMozillaTestDefault to runMozillaTestNoFTL
3763         - runMozillaTestDefaultFTL to runMozillaTestDefault
3764         - runDefault to runNoFTL
3765         - runDefaultFTL to runDefault
3766         - runLayoutTestDefault to runLayoutTestNoFTL
3767         - runLayoutTestDefaultFTL to runLayoutTestDefault
3768         - runNoisyTestDefault to runNoisyTestNoFTL
3769         - runNoisyTestDefaultFTL to runNoisyTestDefault
3770
3771         * Scripts/run-jsc-stress-tests:
3772
3773 2016-07-21  Yongjun Zhang  <yongjun_zhang@apple.com>
3774
3775         WebBackForwardList's currentIndex could get out of bounds when filtering items.
3776         https://bugs.webkit.org/show_bug.cgi?id=159986
3777
3778         Add a test to verify filtering out 2 items from a 3-item list will set the currentIndex
3779         to 0.
3780
3781         Reviewed by Dan Bernstein.
3782
3783         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3784         * TestWebKitAPI/Tests/WebKit2/WKBackForwardList.mm: Added.
3785         (-[WKBackForwardListTestNavigationDelegate webView:didFinishNavigation:]):
3786         (TEST):
3787
3788 2016-07-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3789
3790         [GTK] Web view background colors don't work in accelerated compositing mode
3791         https://bugs.webkit.org/show_bug.cgi?id=159455
3792
3793         Reviewed by Michael Catanzaro.
3794
3795         Set always RGBA visual to the view widget when setting a background color.
3796
3797         * MiniBrowser/gtk/BrowserWindow.c:
3798         (browser_window_set_background_color):
3799
3800 2016-07-20  Youenn Fablet  <youenn@apple.com>
3801
3802         Bots should run built-ins generator tests
3803         https://bugs.webkit.org/show_bug.cgi?id=159971
3804
3805         Reviewed by Alexey Proskuryakov.
3806
3807         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3808         (RunBuiltinsTests): New step to run built-in generator tests.
3809         (TestFactory.__init__): Adding an additional step for bultin generator tests.
3810         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Rebasing expectations.
3811         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: Adding additional step for proper display.
3812
3813 2016-07-20  Aakash Jain  <aakash_jain@apple.com>
3814
3815         Revert temporary fix r203417
3816         https://bugs.webkit.org/show_bug.cgi?id=160001
3817
3818         Reviewed by Alexey Proskuryakov.
3819
3820         * EWSTools/start-queue-mac.sh: Revert the temporary fix.
3821
3822 2016-07-20  Aakash Jain  <aakash_jain@apple.com>
3823
3824         REGRESSION(r148588): ews classes might get garbage collected
3825         https://bugs.webkit.org/show_bug.cgi?id=159990
3826
3827         Reviewed by Ryosuke Niwa.
3828
3829         * Scripts/webkitpy/tool/commands/__init__.py: Store the loaded ews classes
3830         in a variable so that they do not get garbage collected.
3831
3832 2016-07-20  Jeremy Jones  <jeremyj@apple.com>
3833
3834         Add API test for layout constraints after exit fullscreen
3835         https://bugs.webkit.org/show_bug.cgi?id=159900
3836
3837         Reviewed by Jon Lee.
3838
3839         Added Fullscreen.LaytoutConstraints API test.
3840         Tests fix from https://bugs.webkit.org/show_bug.cgi?id=159731
3841
3842         This test compares layout constraints on the web view before and after fullscreen to make sure
3843         they are preserved.
3844
3845         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenLayoutConstraints.html: Added.
3846         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenLayoutConstraints.mm: Added.
3847         (-[FullscreenStateChangeMessageHandler userContentController:didReceiveScriptMessage:]):
3848         (TestWebKitAPI::TEST):
3849
3850 2016-07-20  Ryan Haddad  <ryanhaddad@apple.com>
3851
3852         Disable two failing API tests.
3853
3854         Unreviewed test gardening.
3855
3856         * TestWebKitAPI/Tests/mac/CandidateTests.mm:
3857         (TestWebKitAPI::TEST):
3858
3859 2016-07-20  Wenson Hsieh  <wenson_hsieh@apple.com>
3860
3861         Unreviewed iOS build fix.
3862
3863         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm: Only import Carbon.h on Mac.
3864
3865 2016-07-20  Wenson Hsieh  <wenson_hsieh@apple.com>
3866
3867         Media controls don't appear when pausing a small autoplaying video
3868         https://bugs.webkit.org/show_bug.cgi?id=159972
3869         <rdar://problem/27180657>
3870
3871         Reviewed by Beth Dakin.
3872
3873         Adds a new test that verifies media controls show up when pausing a small autoplayed video. Also adds mechanisms
3874         for simulating basic user interaction in VideoControlsManager.
3875
3876         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3877         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
3878         (-[WKWebView mouseDownAtPoint:]):
3879         (-[DidPlayMessageHandler userContentController:didReceiveScriptMessage:]):
3880         (-[OnLoadMessageHandler initWithWKWebView:handler:]):
3881         (-[OnLoadMessageHandler userContentController:didReceiveScriptMessage:]):
3882         (TestWebKitAPI::TEST):
3883         * TestWebKitAPI/Tests/WebKit2Cocoa/autoplaying-video-with-audio.html: Added.
3884
3885 2016-07-20  Per Arne Vollan  <pvollan@apple.com>
3886
3887         [Win] MathML fonts are not found.
3888         https://bugs.webkit.org/show_bug.cgi?id=159920
3889
3890         Reviewed by Alex Christensen.
3891
3892         When looking up a font in the registry, use the /v option of the Windows 'reg query' command to query
3893         for a specific registry key value.
3894
3895         * Scripts/webkitdirs.pm:
3896         (fontExists):
3897
3898 2016-07-20  Joseph Pecoraro  <pecoraro@apple.com>
3899
3900         Improve prepare-ChangeLog for @media blocks
3901         https://bugs.webkit.org/show_bug.cgi?id=159907
3902
3903         Reviewed by Timothy Hatcher.
3904
3905         * Scripts/prepare-ChangeLog:
3906         (get_selector_line_ranges_for_css):
3907         Get a range for @media blocks just like a selector.
3908             Start Line = line with '{'
3909             End line = line with '}'
3910             Name = "@media ..."
3911
3912         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests_warning-expected.txt:
3913         Improved error messages for unbalanced portions.
3914
3915         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests-expected.txt:
3916         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests.css:
3917         (.media-query::before):
3918         (@media only screen and (max-width: 980px)):
3919         (.media-query a):
3920         (@media (-webkit-min-device-pixel-ratio: 2)):
3921         (.both a):
3922         (.both b):
3923         (.media-query b):
3924         (.media-query::after):
3925
3926 2016-07-20  Csaba Osztrogonác  <ossy@webkit.org>
3927
3928         Fix expectedFailErrorHandler in run-jsc-stress-tests
3929         https://bugs.webkit.org/show_bug.cgi?id=159811
3930
3931         Reviewed by Yusuke Suzuki.
3932
3933         * Scripts/run-jsc-stress-tests:
3934
3935 2016-07-20  Csaba Osztrogonác  <ossy@webkit.org>
3936
3937         Unreviewed Mac cmake buildfix after r203426. Just for fun.
3938
3939         * TestWebKitAPI/PlatformMac.cmake:
3940
3941 2016-07-19  Filip Pizlo  <fpizlo@apple.com>
3942
3943         The default testing mode should not involve disabling the FTL JIT
3944         https://bugs.webkit.org/show_bug.cgi?id=159929
3945
3946         Rubber stamped by Mark Lam and Saam Barati.
3947
3948         It used to be the case that most actively maintained ports did not have the FTL JIT enabled.
3949         Heck, for most of the FTL's initial development, it wasn't enabled anywhere. So, testing the
3950         FTL was not the default. You had to enable it with an option.
3951
3952         For some reason we have kept this arrangement even though the FTL JIT is now the default on
3953         all of the major ports. This has become a serious pain. For example, it's useful to be able
3954         to say that a test should only run in the default config that is representative of what a
3955         normal user would see if they ran JSC. Clearly, this would be a config that does not
3956         explicitly disable the FTL JIT on the command line. However, if you try to specify this then
3957         your test won't run at all if the --ftl-jit option is not passed. That's dangerous!
3958
3959         So, this change gets rid of all of this logic. I think it's better to get rid of it then to
3960         try to fix it, because:
3961
3962         - I don't know what the fix would look like. Presumably it would ensure that ports that don't
3963           have the FTL enabled never run any tests that explicitly disable the FTL, since that
3964           doesn't do anything. The code is not really structured to allow this.
3965
3966         - It benefits a minority of clients. Three build bots run tests in a config that has the FTL
3967           disabled in testing. On the other hand there are already build bots that do FTL tests
3968           despite having the FTL disabled by virtue of being a 32-bit platform. So, maybe rather than
3969           preserving this broken feature, we should create something that (a) acknowledges the fact
3970           that the FTL is the default on those platforms that support it and (b) avoids running
3971           no-ftl tests on precisely those platforms that don't have FTL.
3972
3973         - To the extent that some bots benefited from disabling FTL tests, they were doing it by
3974           relying on a feature that was never meant to stick around. The FTL JIT is meant to be the
3975           default configuration. Disabling the FTL JIT is the non-default. So, we shouldn't be
3976           pretending that the FTL JIT is not the default just because some bots used that as an
3977           optimization.
3978
3979         This change allows me to speed up some debug tests and paint some bots green.
3980
3981         * Scripts/run-javascriptcore-tests:
3982         (runJSCStressTests):
3983         * Scripts/run-jsc-stress-tests:
3984
3985 2016-07-19  Alex Christensen  <achristensen@webkit.org>
3986
3987         Fix API test after r203426.
3988         https://bugs.webkit.org/show_bug.cgi?id=159949
3989
3990         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
3991         (TEST):
3992         If there is website data already on disk, the initial count after putting the AppCache data in place will not be exactly 1.
3993         This is no problem.  We want to verify that it is a nonzero number and that it decrements by one when we remove the 1 AppCache data.
3994
3995 2016-07-19  Andy Estes  <aestes@apple.com>
3996
3997         Move WebKitErrorFrameLoadBlockedByContentFilter from WebKitErrors.h to WebKitErrorsPrivate.h
3998         https://bugs.webkit.org/show_bug.cgi?id=159956
3999
4000         Reviewed by Dan Bernstein.
4001
4002         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm: Included WKErrorRef.h.
4003         (-[LoadAlternateNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
4004         Used kWKErrorCodeFrameLoadBlockedByContentFilter instead of WebKitErrorFrameLoadBlockedByContentFilter.
4005         * TestWebKitAPI/Tests/mac/ContentFiltering.mm: Included WebKitErrorsPrivate.h instead of WebKitErrors.h.
4006
4007 2016-07-19  Alex Christensen  <achristensen@webkit.org>
4008
4009         Add regression test for r203392
4010         https://bugs.webkit.org/show_bug.cgi?id=159949
4011
4012         Reviewed by Brady Eidson.
4013
4014         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
4015         (fileSize):
4016         (swizzledBundleIdentifierWebBookmarksD):
4017         (defaultApplicationCacheDirectory):
4018         (TEST):
4019         (swizzledBundleIdentifierMobileSafari): Deleted.
4020         This actually tests that webbookmarksd uses the path quirk in WebsiteDataStore::defaultApplicationCacheDirectory.
4021         I wanted to verify that it uses the same path as MobileSafari, but swizzling out the bundleIdentifier twice caused
4022         problems with the static bools that are set once in RuntimeApplicationChecks.mm.
4023
4024 2016-07-19  Alex Christensen  <achristensen@webkit.org>
4025
4026         Add regression test for r203392
4027         https://bugs.webkit.org/show_bug.cgi?id=159949
4028
4029         Reviewed by Brady Eidson.
4030
4031         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4032         * TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db: Added.
4033         * TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db-shm: Added.
4034         * TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db-wal: Added.
4035         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
4036         (TEST):
4037         (fileSize):
4038         (swizzledBundleIdentifierMobileSafari):
4039         (swizzledBundleIdentifierWebBookmarksD):
4040         (defaultApplicationCacheDirectory):
4041         * TestWebKitAPI/cocoa/InstanceMethodSwizzler.h: Copied from TestWebKitAPI/mac/InstanceMethodSwizzler.h.
4042         * TestWebKitAPI/cocoa/InstanceMethodSwizzler.mm: Copied from TestWebKitAPI/mac/InstanceMethodSwizzler.mm.
4043         * TestWebKitAPI/mac/InstanceMethodSwizzler.h: Removed.
4044         * TestWebKitAPI/mac/InstanceMethodSwizzler.mm: Removed.
4045
4046 2016-07-19  Keith Miller  <keith_miller@apple.com>
4047
4048         Test262 should have a file with the revision and url
4049         https://bugs.webkit.org/show_bug.cgi?id=159937
4050
4051         Reviewed by Mark Lam.
4052
4053         The import script should update the information from
4054         the path to the test262 repository it gets.
4055
4056         * Scripts/import-test262-tests:
4057
4058 2016-07-19  Alexey Proskuryakov  <ap@apple.com>
4059
4060         Temporary workaround for iOS EWS failing after the fix for bug 159539.
4061         To be deleted once the root cause is found and addressed.
4062
4063         * EWSTools/start-queue-mac.sh:
4064
4065 2016-07-19  Frederic Wang  <fwang@igalia.com>
4066
4067         [win] Fixup the register name for STIX Math and Latin Modern Math
4068
4069         Unreviewed follow-up of r203406
4070
4071         * Scripts/webkitdirs.pm:
4072         (checkInstalledTools):
4073
4074 2016-07-19  Frederic Wang  <fwang@igalia.com>
4075
4076         [win] Update the list of MathML fonts
4077         https://bugs.webkit.org/show_bug.cgi?id=156838
4078
4079         The set of recommended math fonts is now described at
4080         https://trac.webkit.org/wiki/MathML/Fonts
4081         We update the Perl script to use the latest list of fonts.
4082
4083         Reviewed by Brent Fulgham.
4084
4085         * Scripts/webkitdirs.pm:
4086         (checkInstalledTools):
4087
4088 2016-07-19  Per Arne Vollan  <pvollan@apple.com>
4089
4090         [Win] The test fast/scrolling/overflow-scroll-past-max.html is timing out.
4091         https://bugs.webkit.org/show_bug.cgi?id=159342
4092
4093         Reviewed by Darin Adler.
4094
4095         Implement required functions in event sender.
4096
4097         * DumpRenderTree/PlatformWin.cmake:
4098         * DumpRenderTree/win/EventSender.cpp:
4099         (monitorWheelEvents): Added.
4100         (callAfterScrollingCompletes): Added.
4101
4102 2016-07-19  Youenn Fablet  <youenn@apple.com>
4103
4104         Add new aliases to http test server
4105         https://bugs.webkit.org/show_bug.cgi?id=159878
4106
4107         Reviewed by Darin Adler.
4108
4109         Adding testharness.css, testharness.js and testharnessreport.js new aliases to http test servers.
4110         Adding explicitly these links to perl script.
4111         Extracting default alias in an aliases.json file.
4112         Reading that file from python scripts to initialize aliases from that file.
4113
4114         Python script changes covered by unit tests and changed layout test.
4115
4116         * Scripts/webkitperl/httpd.pm:
4117         (getDefaultConfigForTestDirectory): Adding 3 new aliases
4118         * Scripts/webkitpy/layout_tests/servers/aliases.json: Added.
4119         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
4120         (LayoutTestApacheHttpd.__init__): Setting upper class tests_dir member if needed and according constructor parameter.
4121         Adding -c directives for each alias.
4122         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
4123         (TestLayoutTestApacheHttpd.test_start_cmd): Adding aliases.json mock-up file.
4124         * Scripts/webkitpy/layout_tests/servers/http_server.py:
4125         (Lighttpd.__init__): Setting upper class tests_dir member if needed and according constructor parameter.
4126         Adding alias directive for each alias.
4127         (Lighttpd._prepare_config):
4128         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
4129         (HttpServerBase.__init__): Adding tests_dir member with a default value being layout tests directory.
4130         (HttpServerBase.aliases): Computing of alias from the json file, paths to the real files being relative to
4131         layout tests directory.
4132         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
4133         (TestHttpServer.test_start_cmd): Adding aliases.json mock-up file and updating test expectation.
4134         (TestHttpServer.test_win32_start_and_stop): Adding aliases.json mock-up file.
4135
4136 2016-07-18  Aakash Jain  <aakash_jain@apple.com>
4137
4138         EWS console logs doesn't go to log file
4139         https://bugs.webkit.org/show_bug.cgi?id=159539
4140         <rdar://problem/24464570>
4141
4142         Reviewed by David Kilzer.
4143
4144         * Scripts/webkitpy/common/system/logutils.py:
4145         (configure_logger_to_log_to_file): Added method to configure the logger to log to file.
4146         (FileSystemHandler): Added class which uses logging.FileHandler as base class and supports writing
4147         to filesystem. It also supports passing MockFilesystem.
4148         (FileSystemHandler.__init__): Initialize the class and calls base class __init__.
4149         (FileSystemHandler._open): Overrides the base class _open method to use filesystem object.
4150         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
4151         (AbstractEarlyWarningSystemTest.test_failing_tests_message): Added MockHost() parameter.
4152         (_test_ews): Same.
4153         * Scripts/webkitpy/tool/commands/queues.py:
4154         (AbstractQueue.begin_work_queue): Configure the logger to log to file.
4155         (AbstractQueue._log_directory): Using filesystem object instead of os.
4156         (AbstractQueue.queue_log_path): Same.
4157         (AbstractQueue.__init__): Passed host parameter.
4158         (PatchProcessingQueue.__init__): Same.
4159         (CommitQueue.__init__): Same.
4160         (AbstractReviewQueue.__init__): Same.
4161         (StyleQueue.__init__): Same.
4162         * Scripts/webkitpy/tool/commands/queues_unittest.py:
4163         (TestCommitQueue): Passed MockHost() as host.
4164         (TestCommitQueue.__init__): Same.
4165         (TestQueue.__init__): Same.
4166         (TestReviewQueue.__init__): Same.
4167         (TestFeederQueue.__init__): Same.
4168         (AbstractPatchQueueTest.test_next_patch): Same.
4169         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Same.
4170         (test_commit_queue_failure): Same.
4171         (MockCommitQueueTask.results_from_patch_test_run): Same.
4172         (test_rollout_lands): Same.
4173         (test_non_valid_patch): Same.
4174         (test_auto_retry): Same.
4175         (test_style_queue_with_watch_list_exception): Same.
4176
4177 2016-07-02  Filip Pizlo  <fpizlo@apple.com>
4178
4179         WTF::Lock should be fair eventually
4180         https://bugs.webkit.org/show_bug.cgi?id=159384
4181
4182         Reviewed by Geoffrey Garen.
4183
4184         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
4185
4186 2016-07-17  Sam Weinig  <sam@webkit.org>
4187
4188         [WebKit API] Add SPI to track multiple navigations caused by a single user gesture
4189         <rdar://problem/26554137>
4190         https://bugs.webkit.org/show_bug.cgi?id=159856
4191
4192         Reviewed by Dan Bernstein.
4193
4194         * MiniBrowser/mac/WK2BrowserWindowController.m:
4195         (-[WK2BrowserWindowController webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
4196         Add basic window.open implementation.
4197
4198         (-[WK2BrowserWindowController webView:decidePolicyForNavigationAction:decisionHandler:]):
4199         Add basic navigation policy implementation which implements a rule where a user gesture is only allowed
4200         to open a single non-web URL, all others are dropped.
4201
4202         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4203         * TestWebKitAPI/Tests/WebKit2Cocoa/UserInitiatedActionInNavigationAction.mm: Added.
4204         * TestWebKitAPI/Tests/WebKit2Cocoa/open-multiple-external-url.html: Added.
4205         Add API for the new SPI.
4206
4207 2016-07-17  Yusuke Suzuki  <utatane.tea@gmail.com>
4208
4209         [JSC] Enable test262 module tests
4210         https://bugs.webkit.org/show_bug.cgi?id=159854
4211
4212         Reviewed by Saam Barati.
4213
4214         Use --module-file instead.
4215
4216         * Scripts/run-jsc-stress-tests:
4217
4218 2016-07-16  Chris Dumez  <cdumez@apple.com>
4219
4220         Unreviewed, rolling out r203318.
4221
4222         Regressed most JS Benchmarks on MacBook Air by ~2% (7% on
4223         SunSpider)
4224
4225         Reverted changeset:
4226
4227         "[JSC] Change some parameters based on a random search"
4228         https://bugs.webkit.org/show_bug.cgi?id=158514
4229         http://trac.webkit.org/changeset/203318
4230
4231 2016-07-16  Chris Dumez  <cdumez@apple.com>
4232
4233         Add move constructor / assignment operator to ListHashSet
4234         https://bugs.webkit.org/show_bug.cgi?id=159837
4235
4236         Reviewed by Darin Adler.
4237
4238         Add API tests.
4239
4240         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
4241         (TestWebKitAPI::TEST):
4242
4243 2016-07-15  Benjamin Poulain  <bpoulain@apple.com>
4244
4245         [JSC] Change some parameters based on a random search
4246         https://bugs.webkit.org/show_bug.cgi?id=158514
4247
4248         Reviewed by Saam Barati.
4249
4250         * Scripts/run-jsc-stress-tests:
4251
4252 2016-07-15  Jon Davis  <jond@apple.com>
4253
4254         Changed the start page URL for WebKit Nightly builds.
4255         https://bugs.webkit.org/show_bug.cgi?id=159816
4256
4257         Reviewed by Timothy Hatcher.
4258
4259         * WebKitLauncher/start.html:
4260
4261 2016-07-15  Per Arne Vollan  <pvollan@apple.com>
4262
4263         Uninitialized variable in DIBPixelData can cause a dangerous memory write
4264         https://bugs.webkit.org/show_bug.cgi?id=159414
4265
4266         Reviewed by Brent Fulgham.
4267
4268         Add test to check that DIBPixelData::setRGBABitmapAlpha does not cause a crash
4269         when the HDC parameter is invalid.
4270
4271         * TestWebKitAPI/PlatformWin.cmake:
4272         * TestWebKitAPI/Tests/WebCore/win/DIBPixelData.cpp: Added.
4273         (TestWebKitAPI::TEST):
4274
4275 2016-07-15  Carlos Garcia Campos  <cgarcia@igalia.com>
4276
4277         [GTK] Add basic tabs support to MiniBrowser
4278         https://bugs.webkit.org/show_bug.cgi?id=159803