5e6cde97bffda1b5882e0e5b832a6442cdc8dc8d
[WebKit-https.git] / Tools / ChangeLog
1 2012-09-22  Dominic Mazzoni  <dmazzoni@google.com>
2
3         AX: Layout tests would be easier to write if AccessibilityController could find an element by id
4         https://bugs.webkit.org/show_bug.cgi?id=97301
5
6         Reviewed by Chris Fleizach.
7
8         Adds a new accessibleElementById method to AccessibilityController, to make it
9         easier to write cross-platform layout tests.
10
11         Implemented for Chromium and for Mac (DRT and WKTR).
12
13         * DumpRenderTree/AccessibilityController.cpp:
14         (getAccessibleElementByIdCallback):
15         (AccessibilityController::getJSClass):
16         * DumpRenderTree/AccessibilityController.h:
17         (AccessibilityController):
18         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
19         * DumpRenderTree/chromium/TestRunner/AccessibilityControllerChromium.cpp:
20         (AccessibilityController::AccessibilityController):
21         (AccessibilityController::findAccessibleElementByIdRecursive):
22         (AccessibilityController::getAccessibleElementById):
23         (AccessibilityController::accessibleElementByIdGetterCallback):
24         * DumpRenderTree/chromium/TestRunner/AccessibilityControllerChromium.h:
25         (AccessibilityController):
26         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
27         (AccessibilityController::accessibleElementById):
28         * DumpRenderTree/mac/AccessibilityCommonMac.h: added
29         * DumpRenderTree/mac/AccessibilityCommonMac.mm: added
30         (+[NSString stringWithJSStringRef:]):
31         (-[NSString createJSStringRef]):
32         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
33         (findAccessibleObjectById):
34         (AccessibilityController::accessibleElementById):
35         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
36         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
37         (AccessibilityController::accessibleElementById):
38         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
39         (WTR::AccessibilityController::accessibleElementById):
40         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
41         (AccessibilityController):
42         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
43         * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.h: added
44         * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.mm: added
45         (+[NSString stringWithJSStringRef:]):
46         (-[NSString createJSStringRef]):
47         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
48         (WTR::findAccessibleObjectById):
49         (WTR):
50         (WTR::AccessibilityController::accessibleElementById):
51         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
52         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
53
54 2012-09-22  Zan Dobersek  <zandobersek@gmail.com>
55
56         Unexpected reftest passes are only reported when pixel testing is enabled
57         https://bugs.webkit.org/show_bug.cgi?id=97242
58
59         Reviewed by Dirk Pranke.
60
61         LayoutTestRunner should know whether the finished test it's handling is
62         a reftest. This is necessary when updating result summary for reftests
63         when pixel testing is not enabled - in these circumstances an unexpectedly
64         passing reftest was not reported as such due to pixel testing then being
65         determined by searching for reftest failures in failures list, which were
66         not found in an empty failure list of a passing test. Now the TestResult
67         objects have a member variable indicating the test is a reftest whenever
68         that's the case.
69
70         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
71         (LayoutTestRunner._update_summary_with_result):
72         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
73         (LayoutTestRunnerTests.test_update_summary_with_result):
74         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
75         (SingleTestRunner.run):
76         (SingleTestRunner._run_reftest):
77         * Scripts/webkitpy/layout_tests/models/test_results.py:
78         (TestResult.__init__):
79
80 2012-09-21  Sam Weinig  <sam@webkit.org>
81
82         WebProcess XPC services need have their environment set without disrupting all other XPC services
83         https://bugs.webkit.org/show_bug.cgi?id=95161
84
85         Reviewed by Anders Carlsson.
86
87         Remove setting the __XPC_* environment variables.
88
89         * Scripts/webkitdirs.pm:
90         (setUpGuardMallocIfNeeded):
91         (runMacWebKitApp):
92         (execMacWebKitAppForDebugging):
93
94 2012-09-21  Dirk Pranke  <dpranke@chromium.org>
95
96         Fix typo in additional-platform-directory patch just landed
97         https://bugs.webkit.org/show_bug.cgi?id=97380
98         
99         Unreviewed, build fix.
100
101         * Scripts/webkitpy/layout_tests/port/base.py:
102         (Port.relative_test_filename):
103         (Port.relative_perf_test_filename):
104
105 2012-09-21  Dirk Pranke  <dpranke@chromium.org>
106
107         nrwt: don't require additional-platform-directory to be an abspath or live under LayoutTests
108         https://bugs.webkit.org/show_bug.cgi?id=97380
109
110         Reviewed by Ojan Vafai.
111
112         There doesn't seem to be a good reason for this restriction and
113         it's useful to be able to point to directories outside the
114         checkout for results (e.g., for local failures due to a 10.7.4
115         install ;).
116
117         * Scripts/webkitpy/layout_tests/port/base.py:
118         (Port.relative_test_filename):
119         (Port.relative_perf_test_filename):
120         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
121         (ChromiumAndroidDriver._command_from_driver_input):
122         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
123         (_set_up_derived_options):
124         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
125         (MainTest.test_additional_platform_directory):
126
127 2012-09-21  Dirk Pranke  <dpranke@chromium.org>
128
129         webkitpy: drop support for old TestExpectations syntax
130         https://bugs.webkit.org/show_bug.cgi?id=97364
131
132         Reviewed by Ryosuke Niwa.
133
134         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
135         (TestExpectationParser._collect_matching_tests):
136         (TestExpectationParser):
137         (TestExpectationParser._tokenize_line):
138         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
139         (SkippedTests.test_skipped_entry_dont_exist):
140         (ExpectationSyntaxTests.assert_tokenize_exp):
141         (ExpectationSyntaxTests.test_bare_name):
142         (ExpectationSyntaxTests.test_bare_name_and_bugs):
143         (ExpectationSyntaxTests.test_comments):
144         (ExpectationSyntaxTests.test_config_modifiers):
145         (ExpectationSyntaxTests.test_unknown_config):
146         (ExpectationSyntaxTests.test_unknown_expectation):
147         (ExpectationSyntaxTests.test_skip):
148         (ExpectationSyntaxTests.test_slow):
149         (ExpectationSyntaxTests.test_wontfix):
150         (ExpectationSyntaxTests.test_blank_line):
151         (ExpectationSyntaxTests.test_warnings):
152         (RebaseliningTest.test_no_get_rebaselining_failures):
153
154 2012-09-21  Simon Fraser  <simon.fraser@apple.com>
155
156         Improve WTR unresponsiveness output a little
157         https://bugs.webkit.org/show_bug.cgi?id=97370
158
159         Reviewed by Timothy Horton.
160
161         Distinguish between conditions that already set the errorMessage,
162         and unresponsiveness due to slow about:blank loads when WTR
163         reports unresponsiveness.
164
165         * WebKitTestRunner/TestInvocation.cpp:
166         (WTR::TestInvocation::invoke):
167
168 2012-09-21  Chris Rogers  <crogers@google.com>
169
170         Add Web Audio support for deprecated/legacy APIs
171         https://bugs.webkit.org/show_bug.cgi?id=97050
172
173         Reviewed by Eric Carlson.
174
175         * Scripts/webkitperl/FeatureList.pm:
176
177 2012-09-21  Dirk Pranke  <dpranke@chromium.org>
178
179         webkitpy: update remaining tests to use the new expectation syntax
180         https://bugs.webkit.org/show_bug.cgi?id=97362
181
182         Reviewed by Ojan Vafai.
183
184         This patch updates all the unit tests that were still using the
185         old TestExpectations syntax to use the new syntax *except* for
186         the tests that were specifically testing that we parsed the old
187         syntax correctly.
188
189         Also, a block of tests for the new syntax were duplicated, so
190         I've deleted the duplicate.
191
192         Note that the old syntax is still supported so this change should
193         produce no visible changes.
194
195         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
196         (MiscTests.test_multiple_results):
197         (MiscTests.test_category_expectations):
198         (MiscTests.test_error_on_different_platform):
199         (MiscTests.test_error_on_different_build_type):
200         (MiscTests.test_overrides):
201         (MiscTests.test_overrides__directory):
202         (MiscTests.test_overrides__duplicate):
203         (MiscTests.test_more_specific_override_resets_skip):
204         (SkippedTests.check):
205         (SkippedTests.test_duplicate_skipped_test_fails_lint):
206         (SkippedTests.test_skipped_file_overrides_expectations):
207         (SkippedTests.test_skipped_dir_overrides_expectations):
208         (SkippedTests.test_skipped_file_overrides_overrides):
209         (SkippedTests.test_skipped_dir_overrides_overrides):
210         (ExpectationSyntaxTests.disabled_test_missing_expectation):
211         (ExpectationSyntaxTests.disabled_test_missing_colon):
212         (ExpectationSyntaxTests.disabled_test_too_many_colons):
213         (ExpectationSyntaxTests.disabled_test_too_many_equals_signs):
214         (ExpectationSyntaxTests):
215         (ExpectationSyntaxTests.test_unrecognized_expectation):
216         (ExpectationSyntaxTests.test_macro):
217         (SemanticTests.test_bug_format):
218         (SemanticTests.test_bad_bugid):
219         (SemanticTests.test_missing_bugid):
220         (SemanticTests.test_slow_and_timeout):
221         (SemanticTests.test_rebaseline):
222         (test_missing_file):
223         (test_ambiguous):
224         (test_more_modifiers):
225         (test_order_in_file):
226         (test_macro_overrides):
227         (OldExpectationParserTests):
228         (OldExpectationParserTests._tokenize):
229         (OldExpectationParserTests.test_tokenize_extra_colon):
230         (OldExpectationParserTests.test_tokenize_missing_equal):
231         (OldExpectationParserTests.test_tokenize_extra_equal):
232         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
233         (MainTest.test_skip_failing_tests):
234         (MainTest.test_additional_expectations):
235         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
236         (TestExpectationsTestCase.test_valid_expectations):
237         (TestExpectationsTestCase.test_invalid_expectations):
238         (TestExpectationsTestCase.test_tab):
239
240 2012-09-21  Benjamin Poulain  <bpoulain@apple.com>
241
242         [WK2] Add basic testing support for Geolocation
243         https://bugs.webkit.org/show_bug.cgi?id=97278
244
245         Reviewed by Kenneth Rohde Christiansen.
246
247         Update the Geolocation testing to use the proper API in the UIProcess.
248
249         * WebKitTestRunner/CMakeLists.txt:
250         * WebKitTestRunner/GNUmakefile.am:
251
252         * WebKitTestRunner/GeolocationProviderMock.cpp: Added.
253         (WTR::startUpdatingCallback):
254         (WTR::stopUpdatingCallback):
255         (WTR::GeolocationProviderMock::GeolocationProvierMock):
256         (WTR::GeolocationProviderMock::setMockGeolocationPosition):
257         (WTR::GeolocationProviderMock::startUpdating):
258         (WTR::GeolocationProviderMock::stopUpdating):
259         (GeolocationProviderMock):
260         The GeolocationProvider store the location update and deliver them as needed.
261
262         WebCore GeolocationController do not support asynchronous update on start/stop. This is not
263         a problem in this case because all the messages between the WebProcess and the UIProcess are
264         asynchronous. Because of this, unlike GeolocationClientMock, we do not use a timer for event
265         delivery.
266
267         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
268         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
269         (WTR::InjectedBundle::setGeolocationPermission):
270         (WTR::InjectedBundle::setMockGeolocationPosition):
271         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
272         (InjectedBundle):
273         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
274         (WTR::TestRunner::setGeolocationPermission):
275         (WTR::TestRunner::setMockGeolocationPosition):
276         From the InjectedBundle, we now pass the information to the UIProcess so that
277         GeolocationProvider and the TestController can respond appropriately.
278
279         * WebKitTestRunner/InjectedBundle/TestRunner.h:
280         (TestRunner):
281         * WebKitTestRunner/Target.pri:
282         * WebKitTestRunner/TestController.cpp:
283         (WTR::TestController::TestController):
284         (WTR::decidePolicyForGeolocationPermissionRequest):
285         (WTR::TestController::createOtherPage):
286         (WTR::TestController::initialize):
287         (WTR::TestController::setMockGeolocationPosition):
288         * WebKitTestRunner/TestController.h:
289         (TestController):
290         (WTR::TestController::setGeolocationPermission):
291         (WTR::TestController::isGeolocationPermissionAllowed):
292         * WebKitTestRunner/TestInvocation.cpp:
293         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
294         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
295         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
296
297 2012-09-21  Joanmarie Diggs  <jdiggs@igalia.com>
298
299         REGRESSION (r127882): accessibility/spinbutton-value.html failing on GTK
300         https://bugs.webkit.org/show_bug.cgi?id=96196
301
302         Reviewed by Martin Robinson.
303
304         The "regression" is that a new test was added but the support was missing
305         in the Gtk port for spin buttons.
306
307         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
308         (AccessibilityUIElement::valueDescription): Updated the FIXME comment to
309         indicate that this cannot be implemented until it is implemented in ATK.
310         URL of the newly-filed ATK bug included for reference.
311
312 2012-09-21  Dirk Pranke  <dpranke@chromium.org>
313
314         Fix test_skip_and_wontfix failure
315         https://bugs.webkit.org/show_bug.cgi?id=97225
316
317         Unreviewed, build fix.
318
319         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
320         (SemanticTests.test_skip_and_wontfix):
321
322 2012-09-21  Carlos Garcia Campos  <cgarcia@igalia.com>
323
324         [GTK] Implement ViewState methods in PageClientImpl in WebKit2
325         https://bugs.webkit.org/show_bug.cgi?id=97202
326
327         Reviewed by Martin Robinson.
328
329         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
330         (WTR::PlatformWebView::focus): Focus the view.
331
332 2012-09-21  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
333
334         [WTR] Memory leaks in InjectedBundleController::initialize()
335         https://bugs.webkit.org/show_bug.cgi?id=97329
336
337         Reviewed by Alexey Proskuryakov.
338
339         Fix leaks in InjectedBundleController::initialize() by adopting
340         strings created with WKStringCreateWithUTF8CString().
341
342         * TestWebKitAPI/InjectedBundleController.cpp:
343         (TestWebKitAPI::InjectedBundleController::initialize):
344
345 2012-09-21  Marcelo Lira  <marcelo.lira@openbossa.org>
346
347         [Qt][WK2] Removed duplicated code from EventSenderProxy::keyDown
348         https://bugs.webkit.org/show_bug.cgi?id=97235
349
350         Reviewed by Luiz Agostini.
351
352         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
353         (WTR::EventSenderProxy::keyDown):
354
355 2012-09-21  Gergely Kis  <gergely@homejinni.com>
356
357         Add MIPS build slave to build.webkit.org
358         https://bugs.webkit.org/show_bug.cgi?id=96713
359
360         Reviewed by Csaba Osztrogonác.
361
362         Added a build slave for MIPS, and enabled a builder for 
363         Qt Linux MIPS32R2 little-endian release build.
364
365         * BuildSlaveSupport/build.webkit.org-config/config.json:
366
367 2012-09-21  Peter Beverloo  <peter@chromium.org>
368
369         [Chromium] Switch back to a fixed fifo path for Android
370         https://bugs.webkit.org/show_bug.cgi?id=97230
371
372         Reviewed by Tony Chang.
373
374         Because not all external storage cards will be formated using a file
375         system that supports named pipes, Chromium has been changed to creating
376         the pipes in a temporary folder on the internal storage. Adapt this in
377         WebKit so we can continue to run layout tests.
378
379         This also includes an *unreviewed* fix for a breakage in the webkitpy
380         tests I made in r129221. Two lines and related to this code, so I decided
381         to include it in this change.
382
383         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
384         (ChromiumAndroidDriver.__init__):
385         (ChromiumAndroidDriver._setup_test):
386         (ChromiumAndroidDriver._update_version):
387
388 2012-09-20  Peter Beverloo  <peter@chromium.org>
389
390         Leverage Chromium's code to set up FIFOs for Chromium Android layout tests
391         https://bugs.webkit.org/show_bug.cgi?id=97227
392
393         Reviewed by Tony Chang.
394
395         We switched Chromium to using FIFOs in order to achieve better consistency,
396         which was done by Marcus in r157541. Remove all custom WebKit code in
397         favor of Chromium's implementation.
398
399         Remove more FIFO code in the test runner itself, including the code in
400         DumpRenderTree that invoked it. We can now switch to Chromium's brand
401         new FIFO-creating code, which is being set-up for all test targets build
402         for Android, including DumpRenderTree, TestWebKitAPI and webkit_unit_tests.
403
404         This also changes the ChromiumAndroidDriver._remove_all_pipes method to
405         delete the files individually. "rm" would fail if one of the earlier files
406         does not exist, and the "-f" argument doesn't seem to be reliable.
407
408         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
409         * DumpRenderTree/chromium/TestShellAndroid.cpp:
410         (platformInit):
411         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
412         (ChromiumAndroidDriver.__init__):
413         (ChromiumAndroidDriver._setup_test):
414         (ChromiumAndroidDriver._get_external_storage):
415         (ChromiumAndroidDriver._drt_cmd_line):
416         (ChromiumAndroidDriver._remove_all_pipes):
417         (ChromiumAndroidDriver.stop):
418         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
419
420 2012-09-21  Christophe Dumez  <christophe.dumez@intel.com>
421
422         [WK2][WKTR] EventSender needs to implement scheduleAsynchronousClick
423         https://bugs.webkit.org/show_bug.cgi?id=97326
424
425         Reviewed by Kenneth Rohde Christiansen.
426
427         Implement scheduleAsynchronousClick() in WebKitTestRunner's
428         EventSender by sending a "MouseDown" and a "MouseUp" message
429         asynchronously to the WebProcess.
430
431         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
432         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
433         (WTR::createMouseMessageBody):
434         (WTR):
435         (WTR::EventSendingController::mouseDown):
436         (WTR::EventSendingController::mouseUp):
437         (WTR::EventSendingController::scheduleAsynchronousClick):
438         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
439         (EventSendingController):
440         * WebKitTestRunner/TestController.cpp:
441         (WTR::TestController::didReceiveMessageFromInjectedBundle):
442
443 2012-09-21  Simon Hausmann  <simon.hausmann@digia.com>
444
445         [Qt] Error out early if we don't have ICU available
446
447         Reviewed by Tor Arne Vestbø.
448
449         * qmake/mkspecs/features/configure.prf:
450
451 2012-09-21  Simon Hausmann  <simon.hausmann@digia.com>
452
453         [Qt] Bail out when trying to build WebKit with Qt != 5
454
455         Reviewed by Tor Arne Vestbø.
456
457         Moved check for Qt version out of default_pre into top-level WebKit.pro,
458         because we never reach default_pre.prf due to the lack of .qmake.conf support
459         in older versions of Qt/QMake.
460
461         * qmake/mkspecs/features/default_pre.prf:
462
463 2012-09-21  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
464
465         WebKitTestRunner needs to print frame load delegate information
466         https://bugs.webkit.org/show_bug.cgi?id=42705
467
468         Reviewed by Kenneth Rohde Christiansen.
469
470         Added missing dumping from WTR::InjectedBundlePage::didFailLoadWithErrorForFrame.
471
472         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
473         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
474
475 2012-09-21  Christophe Dumez  <christophe.dumez@intel.com>
476
477         [EFL] EventSender should mimic CTRL+o emacs shortcut
478         https://bugs.webkit.org/show_bug.cgi?id=97224
479
480         Reviewed by Kenneth Rohde Christiansen.
481
482         Add support for mimicking CTRL+o emacs shortcut in EFL's
483         EventSender in DumpRenderTree and WebKitTestRunner.
484
485         * DumpRenderTree/efl/EventSender.cpp:
486         (sendKeyDown):
487         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
488         (WTR::EventSenderProxy::keyDown):
489
490 2012-09-21  Simon Hausmann  <simon.hausmann@digia.com>
491
492         [Qt] Re-fix clean builds
493
494         Reviewed by Tor Arne Vestbø.
495
496         Re-introduce the sanitization for LIBS when creating a module to use
497         LIBS_PRIVATE and otherwise do _not_ use LIBS_PRIVATE. We decided to
498         continue to use QT, LIBS and PKGCONFIG instead of their _PRIVATE variants
499         throughout the code base, so just using LIBS_PRIVATE in linkAgainstLibrary()
500         causes build issues when depending system libraries end up in LIBS before
501         LIBS_PRIVATE.
502
503         * qmake/mkspecs/features/default_post.prf:
504         * qmake/mkspecs/features/functions.prf:
505
506 2012-09-20  Simon Fraser  <simon.fraser@apple.com>
507
508         Comment out a failing webkitpy unit test until Dirk can fix it.
509
510         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
511         (SemanticTests.test_skip_and_wontfix):
512
513 2012-09-20  Dirk Pranke  <dpranke@chromium.org>
514
515         make Skip, WontFix be the only expectations on a line
516         https://bugs.webkit.org/show_bug.cgi?id=97225
517
518         Reviewed by Ojan Vafai.
519
520         It is now incorrect in the new syntax to have a line like:
521
522             foo.html [ WontFix Crash ]
523
524         This will generate a lint warning and be treated as an invalid
525         line. Fixing this caused a whole bunch of unit tests to need updating
526         to no longer be marked as WontFix :). Also, this patch adjusts
527         the warnings so that missing Bug() identifiers will cause lint
528         warnings but will *not* cause the line to be treated as invalid.
529         Fixing these issues also revealed that test_hung_thread was no
530         longer testing the right logic, so I adjusted the timeouts in
531         test.py to make that test work again.
532
533         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
534         (Worker._run_test_in_another_thread):
535         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
536         (ResultSummaryTest.test_summarized_results_wontfix):
537         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
538         (TestExpectationParser._parse_modifiers):
539         (TestExpectationParser._tokenize_line_using_new_format):
540         (TestExpectationLine.is_invalid):
541         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
542         (BasicTests.test_basic):
543         (test_get_test_set):
544         (test_parse_warning):
545         (test_pixel_tests_flag):
546         (SemanticTests.test_missing_bugid):
547         (SemanticTests):
548         (SemanticTests.test_skip_and_wontfix):
549         * Scripts/webkitpy/layout_tests/port/test.py:
550         (TestDriver.run_test):
551         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
552         (MainTest.test_hung_thread):
553         * Scripts/webkitpy/tool/commands/queries_unittest.py:
554         (PrintExpectationsTest.test_basic):
555         (PrintExpectationsTest.test_multiple):
556         (PrintExpectationsTest.test_full):
557         (PrintExpectationsTest.test_exclude):
558         (PrintExpectationsTest.test_csv):
559
560 2012-09-20  Lucas Forschler  <lforschler@apple.com>
561
562         Unreviewed.  Start running tests on the mac-ews.
563         
564         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
565         (MacEWS):
566
567 2012-09-20  Tony Chang  <tony@chromium.org>
568
569         [chromium] Enable more clang warnings
570         https://bugs.webkit.org/show_bug.cgi?id=97257
571
572         Reviewed by James Robinson.
573
574         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Add -Wunused-parameter. Don't add -Wglobal-constructors because
575         there are lots of violations in these files.
576
577 2012-09-19  Ryosuke Niwa  <rniwa@webkit.org>
578
579         run-perf-tests should record individual value instead of statistics
580         https://bugs.webkit.org/show_bug.cgi?id=97155
581
582         Reviewed by Hajime Morita.
583
584         Parse the list of individual value reported by tests and include them as "values".
585         We strip "values" from the output JSON when uploading it to the perf-o-matic
586         since it doesn't know how to parse "values" or ignore it.
587
588         * Scripts/webkitpy/performance_tests/perftest.py:
589         (PerfTest):
590         (PerfTest.parse_output): Parse and report "values".
591         (PageLoadingPerfTest.run): Report indivisual page loading time in "values".
592         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
593         (MainTest.test_parse_output):
594         (MainTest.test_parse_output_with_failing_line):
595         (TestPageLoadingPerfTest.test_run):
596         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
597         (PerfTestsRunner._generate_and_show_results): Strip "values" from each result
598         until we update perf-o-matic.
599         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
600         (test_run_memory_test):
601         (test_run_with_json_output):
602         (test_run_with_description):
603         (test_run_with_slave_config_json):
604         (test_run_with_multiple_repositories):
605
606 2012-09-20  Simon Hausmann  <simon.hausmann@digia.com>
607
608         [Qt] Fix production builds
609
610         Unreviewed trivial fix: Follow up r129119 and avoid clobbering LIBS through the use of LIBS_PRIVATE.
611
612         Otherwise the libQtWebKit.prl file for example contains -lWebKit1 -lWebCore, etc.
613
614         * qmake/mkspecs/features/functions.prf:
615
616 2012-09-20  Dirk Pranke  <dpranke@chromium.org>
617
618         REGRESSION: layout test results doesn't show diffs
619         https://bugs.webkit.org/show_bug.cgi?id=97182
620
621         Reviewed by Ojan Vafai.
622
623         Go back to storing TEXT, AUDIO, and IMAGE+TEXT in results.json
624         so that results.html (and hopefully garden-o-matic) can
625         determine which things actually failed. However, we keep mapping
626         these results to Failure so that we still only have a single
627         expectation type for them.
628
629         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
630         (JSONLayoutResultsGenerator):
631         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
632         (TestExpectationParser):
633         (TestExpectations):
634         (TestExpectations.result_was_expected):
635         * Scripts/webkitpy/layout_tests/models/test_failures.py:
636         (determine_result_type):
637         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
638         (MainTest.test_missing_and_unexpected_results):
639         (MainTest.test_retrying_and_flaky_tests):
640
641 2012-09-20  Tommy Widenflycht  <tommyw@google.com>
642
643         MediaStream API: Extend UserMediaRequest with a ownerDocument method
644         https://bugs.webkit.org/show_bug.cgi?id=97095
645
646         Reviewed by Adam Barth.
647
648         Extending WebUserMediaClientMock to check that the owning document is valid,
649         and that the document has a frame.
650
651         * DumpRenderTree/chromium/WebUserMediaClientMock.cpp:
652         (WebKit::WebUserMediaClientMock::requestUserMedia):
653
654 2012-09-20  Stephen Chenney  <schenney@chromium.org>
655
656         [Chromium] DRT does not support --dump-all-pixels flag
657         https://bugs.webkit.org/show_bug.cgi?id=95098
658
659         Reviewed by Dirk Pranke.
660
661         Add support for the --pixel-tests and shorthand -p option in Chromium DumpRenderTree. Use
662         of this flag causes pixel results to be created for all tests, regardless of
663         individual test options. If an individual test provides a pixel hash it will be used,
664         otherwise the hash will be empty. This replaces a previously defined but unused option
665         --dump-all-pixels, and is useful primarily when debugging DRT instances.
666
667         * DumpRenderTree/chromium/DumpRenderTree.cpp:
668         (runTest): Add a parameter and code to force pixel results for the test.
669         (main): Add parameter handling for --pixels-test and -p, and remove --dump-all-pixels.
670
671 2012-09-20  Carlos Garcia Campos  <cgarcia@igalia.com>
672
673         [GTK] run-api-tests should not buffer test stdout
674         https://bugs.webkit.org/show_bug.cgi?id=88474
675
676         Reviewed by Philippe Normand.
677
678         * Scripts/run-gtk-tests:
679         (TestRunner._run_test_command): Use os.forkpty() instead of
680         subprocess.Popen() so that gtest sends the output with colors to
681         stdout. Use common.parse_output_lines() to parse the output and
682         write it to stdout while it's read.
683         (TestRunner._run_test_command.parse_line): Parse the line to get
684         the test pid and write the line to stdout.
685         (TestRunner._run_test_command.waitpid): Helper function to call
686         waitpid handling EINTR.
687         (TestRunner._run_test_command.return_code_from_exit_status):
688         Helper function to convert exit status of test commands to a
689         return code.
690         * gtk/common.py:
691         (parse_output_lines): Helper function that uses select to read
692         the given file descriptor and call the given callback for every
693         line read.
694
695 2012-09-20  Simon Hausmann  <simon.hausmann@digia.com>
696
697         [Qt] Fix initial build
698
699         Reviewed by Tor Arne Vestbø.
700
701         When building QtWebKit the first time there is no qt_webkit.pri module pri file, and therefore
702         $$QT.webkit.name isn't set and so creating_module isn't set. That has all sorts of implications
703         causing incorrect linking for Makefile.api, etc.
704
705         Fix the determination by simply checking if MODULE is set, which only happens in api.pri.
706
707         * qmake/mkspecs/features/webkit_modules.prf:
708
709 2012-09-20  Sheriff Bot  <webkit.review.bot@gmail.com>
710
711         Unreviewed, rolling out r129091.
712         http://trac.webkit.org/changeset/129091
713         https://bugs.webkit.org/show_bug.cgi?id=97205
714
715         It broke perf tests everywhere (Requested by Ossy on #webkit).
716
717         * Scripts/webkitpy/performance_tests/perftest.py:
718         (PerfTest):
719         (PerfTest.parse_output):
720         (PageLoadingPerfTest.run):
721         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
722         (MainTest.test_parse_output):
723         (MainTest.test_parse_output_with_failing_line):
724         (TestPageLoadingPerfTest.test_run):
725         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
726         (PerfTestsRunner._generate_and_show_results):
727         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
728         (test_run_memory_test):
729         (test_run_with_json_output):
730         (test_run_with_description):
731         (test_run_with_slave_config_json):
732         (test_run_with_multiple_repositories):
733
734 2012-09-20  Simon Hausmann  <simon.hausmann@digia.com>
735
736         [Qt] QtWebKit module header includes private dependencies
737
738         Reviewed by Tor Arne Vestbø.
739
740         * qmake/mkspecs/features/default_post.prf: Don't try to sanitize LIBS, because we can make sure
741         that LIBS_PRIVATE is set from the beginning. Moved the creating_module and PKGCONFIG/QT(_PRIVATE)
742         sanitization into webkit_modules.prf. creating_module determination requires TARGET to be set, so
743         we can't do it in default_pre.
744         * qmake/mkspecs/features/webkit_modules.prf:
745
746 2012-09-20  Simon Hausmann  <simon.hausmann@digia.com>
747
748         [Qt] Fix build with MingW
749
750         Reviewed by Tor Arne Vestbø.
751
752         Don't try to compile WebCore, etc. with debug symbols for production
753         builds, it's just too big.
754
755         * qmake/mkspecs/features/production_build.prf:
756
757 2012-09-20  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
758
759         [EFL][DRT]DumpRenderTree needs to reset focus state when test starts.
760         https://bugs.webkit.org/show_bug.cgi?id=97087
761
762         Reviewed by Gyuyoung Kim.
763
764         Add focusing a main frame on settings reset.
765         After editing/undo/undo-iframe-location-change was executed a frame
766         was left in unfocused state. This caused flakiness in two tests results.
767
768         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
769         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
770
771 2012-09-20  Allan Sandfeld Jensen  <allan.jensen@digia.com>
772
773         [Qt] Add eventSender.gestureTap
774         https://bugs.webkit.org/show_bug.cgi?id=66173
775
776         Reviewed by Kenneth Rohde Christiansen.
777
778         Implement support for sending raw QGesture events.
779
780         * DumpRenderTree/qt/EventSenderQt.cpp:
781         (EventSender::EventSender):
782         (EventSender::gestureTap):
783         * DumpRenderTree/qt/EventSenderQt.h:
784         (EventSender):
785
786 2012-09-19  Sheriff Bot  <webkit.review.bot@gmail.com>
787
788         Unreviewed, rolling out r129007.
789         http://trac.webkit.org/changeset/129007
790         https://bugs.webkit.org/show_bug.cgi?id=97172
791
792         It broke the build on the Qt bots (Requested by Ossy on
793         #webkit).
794
795         * qmake/config.tests/gccdepends/empty.cpp:
796         * qmake/config.tests/gccdepends/gccdepends.pro:
797         * qmake/mkspecs/features/default_pre.prf:
798
799 2012-09-19  Ryosuke Niwa  <rniwa@webkit.org>
800
801         run-perf-tests should record indivisual value instead of statistics
802         https://bugs.webkit.org/show_bug.cgi?id=97155
803
804         Reviewed by Hajime Morita.
805
806         Parse the list of indivisual value reported by tests and include them as "values".
807         We strip "values" from the output JSON when uploading it to the perf-o-matic
808         since it doesn't know how to parse "values" or ignore it.
809
810         * Scripts/webkitpy/performance_tests/perftest.py:
811         (PerfTest):
812         (PerfTest.parse_output): Parse and report "values".
813         (PageLoadingPerfTest.run): Report indivisual page loading time in "values".
814         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
815         (MainTest.test_parse_output):
816         (MainTest.test_parse_output_with_failing_line):
817         (TestPageLoadingPerfTest.test_run):
818         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
819         (PerfTestsRunner._generate_and_show_results): Strip "values" from each result
820         until we update perf-o-matic.
821         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
822         (test_run_memory_test):
823         (test_run_with_json_output):
824         (test_run_with_description):
825         (test_run_with_slave_config_json):
826         (test_run_with_multiple_repositories):
827
828 2012-09-19  Dirk Pranke  <dpranke@chromium.org>
829
830         Fix regex groups for bug matching in flakiness dashboard.
831         https://bugs.webkit.org/show_bug.cgi?id=97152
832
833         Unreviewed, build fix.
834
835         * TestResultServer/static-dashboards/flakiness_dashboard.js:
836         (htmlForBugs):
837
838 2012-09-19  Dirk Pranke  <dpranke@chromium.org>
839
840         nrwt: print unexpected results using new TestExpectations syntax
841         https://bugs.webkit.org/show_bug.cgi?id=97159
842
843         Unreviewed, build fix.
844
845         Change new-run-webkit-tests to print out failures using the new
846         syntax when there are unexpected results, e.g.:
847
848         52 tests ran as expected, 19 didn't:
849
850
851         Regressions: Unexpected failures : (2)
852           failures/flaky/text.html [ Failure ]
853           failures/unexpected/text-image-checksum.html [ Failure ]
854
855         and so forth
856
857         * Scripts/webkitpy/layout_tests/views/printing.py:
858         (Printer._print_unexpected_results):
859
860 2012-09-19  Dirk Pranke  <dpranke@chromium.org>
861
862         update flakiness dashboard after cutover to new test expectations syntax
863         https://bugs.webkit.org/show_bug.cgi?id=97152
864
865         Unreviewed, build fix.
866
867         Handle (??) the new Bug notations as well. Hopefully we don't
868         still need the old ones.
869
870         * TestResultServer/static-dashboards/flakiness_dashboard.js:
871         (filterBugs):
872         (htmlForBugs):
873         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
874
875 2012-09-19  Dirk Pranke  <dpranke@chromium.org>
876
877         update flakiness dashboard after cutover to new test expectations syntax
878         https://bugs.webkit.org/show_bug.cgi?id=97152
879
880         Reviewed by Ryosuke Niwa.
881
882         This change clones the TestExpectation parsing state machine
883         from python into javascript.
884
885         * TestResultServer/static-dashboards/flakiness_dashboard.js:
886         (parsedExpectations.lines.forEach):
887         (parsedExpectations):
888         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
889
890 2012-09-19  Dana Jansens  <danakj@chromium.org>
891
892         Add backer@chromium.org as contributor
893         https://bugs.webkit.org/show_bug.cgi?id=97150
894
895         * Scripts/webkitpy/common/config/committers.py:
896
897 2012-09-19  Dirk Pranke  <dpranke@chromium.org>
898
899         fix MISSING after TestExpectations conversion
900         https://bugs.webkit.org/show_bug.cgi?id=97148
901
902         Unreviewed, expectations change / build fix.
903
904         * Scripts/convert-test-expectations:
905         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
906         (TestExpectationParser):
907
908 2012-09-19  Dirk Pranke  <dpranke@chromium.org>
909
910         nrwt: convert chromium TestExpectations to the new syntax
911         https://bugs.webkit.org/show_bug.cgi?id=97139
912
913         Reviewed by Ryosuke Niwa.
914     
915         Add in a file temporarily that does the conversion of
916         test expectations formats
917
918         * Tools/Scripts/convert-test-expectations: Added.
919
920 2012-09-19  Ryosuke Niwa  <rniwa@webkit.org>
921
922         REGRESSION: run-perf-tests no longer reports the total test time
923         https://bugs.webkit.org/show_bug.cgi?id=97138
924
925         Reviewed by Tony Chang.
926
927         Report the finished time as a info-level log as opposed to a debug level log.
928
929         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
930         (PerfTestsRunner._run_single_test):
931         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
932         (MainTest.normalizeFinishedTime): Added. It replaces all finished times by 0.1 seconds.
933         (test_run_test_pause_before_testing):
934         (test_run_test_set_for_parser_tests):
935         (test_run_memory_test):
936         (_test_run_with_json_output):
937
938 2012-09-19  Dirk Pranke  <dpranke@chromium.org>
939
940         Support new TestExpectations format alongside old one
941         https://bugs.webkit.org/show_bug.cgi?id=96588
942
943         Reviewed by Ojan Vafai.
944
945         This patch adds support for actually reading in lines formatted
946         in the new style, and when we re-serialize/write out the file,
947         all lines will be written in the new style. Note that reading in
948         the old style is still supported, and no updates are being made
949         to the actual TestExpectations files as part of this change.
950
951         This change updates most but not all of the unit tests to use
952         the new syntax. I will update the rest when (or before where
953         possible) I drop support for the old format.
954
955         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
956         (TestExpectationParser):
957         (TestExpectationParser._tokenize_line):
958         (TestExpectationParser._tokenize_line_using_new_format):
959         (TestExpectationLine.to_string):
960         (TestExpectationLine._format_line):
961         (TestExpectations):
962         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
963         (test_parse_warning):
964         (SkippedTests.test_skipped_entry_dont_exist):
965         (NewExpectationSyntaxTests.test_warnings):
966         (RemoveConfigurationsTest.test_remove):
967         (test_remove_line):
968         (RebaseliningTest.test_remove):
969         (RebaseliningTest.test_no_get_rebaselining_failures):
970         (TestExpectationParserTests.test_tokenize_blank):
971         (TestExpectationParserTests.test_tokenize_extra_colon):
972         (TestExpectationParserTests.test_tokenize_missing_equal):
973         (TestExpectationParserTests.test_tokenize_extra_equal):
974         (TestExpectationSerializationTests.test_unparsed_to_string):
975         (TestExpectationSerializationTests.test_unparsed_list_to_string):
976         (TestExpectationSerializationTests.test_parsed_to_string):
977         (TestExpectationSerializationTests.test_format_line):
978         (TestExpectationSerializationTests.test_string_roundtrip):
979         (TestExpectationSerializationTests.test_list_roundtrip):
980         (TestExpectationSerializationTests.test_reconstitute_only_these):
981         (TestExpectationSerializationTests.test_string_whitespace_stripping):
982         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
983         (LintTest.test_lint_test_files__errors):
984         * Scripts/webkitpy/tool/commands/queries_unittest.py:
985         (PrintExpectationsTest.test_basic):
986         (PrintExpectationsTest.test_multiple):
987         (PrintExpectationsTest.test_full):
988         (PrintExpectationsTest.test_exclude):
989         * Scripts/webkitpy/tool/commands/rebaseline.py:
990         (RebaselineExpectations.execute):
991         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
992         (TestRebaseline.test_rebaseline_updates_expectations_file_noop):
993         (test_rebaseline_updates_expectations_file):
994         (test_rebaseline_does_not_include_overrides):
995         (test_rebaseline_expectations_noop):
996         (test_overrides_are_included_correctly):
997
998 2012-09-19  Dirk Pranke  <dpranke@chromium.org>
999
1000         implement first part of support for the new TestExpectations syntax
1001         https://bugs.webkit.org/show_bug.cgi?id=96569
1002
1003         Reviewed by Ryosuke Niwa.
1004
1005         This patch implements support for parsing a line of the new
1006         format for the TestExpectations file and converting it back into
1007         the old format for compatibility. This routine is not yet used
1008         by anything.
1009
1010         The new format is documented at:
1011           http://trac.webkit.org/wiki/TestExpectations
1012
1013         but, in short:
1014
1015           [bugs] [ "[" modifiers "]" ] test_name [ "[" expectations "]" ]
1016
1017         - Comments are indicated with "#" instead of "//"
1018         - If no expectations are specified we default to Skip for
1019           compatibility with the Skipped files (these two changes make
1020           Skipped files a subset of TestExpectations files)
1021
1022         - All of the tokens are now CamelCase instead of ALLCAPS.
1023         - FAIL -> Failure
1024         - IMAGE -> ImageOnlyFailure
1025         - WONTFIX -> WontFix
1026         - modifiers refer to just the platforms and configurations
1027           (release/debug) that the line applies to.
1028         - WontFix, Rebaseline, Slow, and Skip move to the right-hand side as
1029           expectations
1030         - expectations will typically be written out in lexicographic order
1031         - We use webkit.org/b/12345, crbug.com/12345, and Bug(dpranke)
1032           instead of BUGWK12345, BUGCR12345, and BUGDPRANKE.
1033
1034         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1035         (TestExpectationParser):
1036         (TestExpectationParser._tokenize_line_using_new_format):
1037         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1038         (NewExpectationSyntaxTests):
1039         (NewExpectationSyntaxTests.assert_exp):
1040         (NewExpectationSyntaxTests.test_bare_name):
1041         (NewExpectationSyntaxTests.test_bare_name_and_bugs):
1042         (NewExpectationSyntaxTests.test_comments):
1043         (NewExpectationSyntaxTests.test_config_modifiers):
1044         (NewExpectationSyntaxTests.test_unknown_config):
1045         (NewExpectationSyntaxTests.test_unknown_expectation):
1046         (NewExpectationSyntaxTests.test_skip):
1047         (NewExpectationSyntaxTests.test_slow):
1048         (NewExpectationSyntaxTests.test_wontfix):
1049         (NewExpectationSyntaxTests.test_blank_line):
1050         (NewExpectationSyntaxTests.test_warnings):
1051
1052 2012-09-19  Dirk Pranke  <dpranke@chromium.org>
1053
1054         nrwt: replace TEXT, AUDIO, and IMAGE+TEXT with FAIL
1055         https://bugs.webkit.org/show_bug.cgi?id=96845
1056
1057         Reviewed by Ojan Vafai.
1058
1059         In preparation for the new TestExpectations syntax, we replace
1060         all TEXT, IMAGE+TEXT, and AUDIO failures with FAIL. This will
1061         make switching to the new syntax lossless (i.e., we lose
1062         information now, not then).
1063
1064         Note that we can still parse in results.json files that have the
1065         old data for backwards compatibility.
1066         
1067
1068         * Scripts/webkitpy/common/net/resultsjsonparser.py:
1069         (JSONTestResult._failure_types_from_actual_result):
1070         * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
1071         (ResultsJSONParserTest):
1072         (test_basic):
1073         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1074         (ResultSummaryTest.test_summarized_results_wontfix):
1075         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1076         (JSONLayoutResultsGenerator):
1077         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1078         (TestExpectations):
1079         (TestExpectations.remove_pixel_failures):
1080         (TestExpectations.has_pixel_failures):
1081         (TestExpectations.suffixes_for_expectations):
1082         (TestExpectations.get_rebaselining_failures):
1083         (TestExpectations.remove_configuration_from_test):
1084         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1085         (assert_bad_expectations):
1086         (BasicTests):
1087         (BasicTests.test_basic):
1088         (MiscTests):
1089         (MiscTests.test_multiple_results):
1090         (MiscTests.test_result_was_expected):
1091         (MiscTests.test_remove_pixel_failures):
1092         (MiscTests.test_suffixes_for_expectations):
1093         (test_get_expectations_string):
1094         (test_parse_warning):
1095         (test_error_on_different_platform):
1096         (test_error_on_different_build_type):
1097         (test_overrides):
1098         (test_overrides__directory):
1099         (test_overrides__duplicate):
1100         (test_pixel_tests_flag):
1101         (test_more_specific_override_resets_skip):
1102         (SkippedTests.test_skipped_file_overrides_expectations):
1103         (SkippedTests.test_skipped_dir_overrides_expectations):
1104         (SkippedTests.test_skipped_file_overrides_overrides):
1105         (SkippedTests.test_skipped_dir_overrides_overrides):
1106         (ExpectationSyntaxTests.test_missing_colon):
1107         (ExpectationSyntaxTests.test_too_many_equals_signs):
1108         (SemanticTests.test_bug_format):
1109         (SemanticTests.test_bad_bugid):
1110         (SemanticTests.test_missing_bugid):
1111         (SemanticTests.test_rebaseline):
1112         (test_missing_file):
1113         (test_more_modifiers):
1114         (test_order_in_file):
1115         (test_macro_overrides):
1116         (RemoveConfigurationsTest.test_remove):
1117         (test_remove_line):
1118         (RebaseliningTest.test_remove):
1119         (TestExpectationSerializationTests.test_serialize_parsed_expectations):
1120         * Scripts/webkitpy/layout_tests/models/test_failures.py:
1121         (determine_result_type):
1122         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1123         (test_test_expectations):
1124         * Scripts/webkitpy/layout_tests/port/test.py:
1125         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1126         (MainTest.test_missing_and_unexpected_results):
1127         (MainTest.test_retrying_and_flaky_tests):
1128         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1129         (TestExpectationsTestCase.test_valid_expectations):
1130         * Scripts/webkitpy/tool/commands/queries_unittest.py:
1131         (PrintExpectationsTest.test_basic):
1132         (PrintExpectationsTest.test_multiple):
1133         (PrintExpectationsTest.test_full):
1134         (PrintExpectationsTest.test_exclude):
1135         (PrintExpectationsTest.test_csv):
1136         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1137         (test_rebaseline_does_not_include_overrides):
1138         (test_overrides_are_included_correctly):
1139
1140 2012-09-19  Dominic Mazzoni  <dmazzoni@google.com>
1141
1142         AX: A few control types are returning the wrong answer for isReadOnly
1143         https://bugs.webkit.org/show_bug.cgi?id=96735
1144
1145         Reviewed by Chris Fleizach.
1146
1147         Exposing isReadOnly in an AccessibilityObject to DumpRenderTree.
1148
1149         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
1150         (AccessibilityUIElement::AccessibilityUIElement):
1151         (AccessibilityUIElement::isReadOnlyGetterCallback):
1152         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.h:
1153         (AccessibilityUIElement):
1154
1155 2012-09-19  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
1156
1157         [WTR] Memory leaks in TestRunner::deliverWebIntent()
1158         https://bugs.webkit.org/show_bug.cgi?id=97111
1159
1160         Reviewed by Kenneth Rohde Christiansen.
1161
1162         Fix memory leaks in deliverWebIntent() by adopting strings
1163         created with WKStringCreateWithUTF8CString().
1164
1165         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1166         (WTR::TestRunner::deliverWebIntent):
1167
1168 2012-09-19  Simon Hausmann  <simon.hausmann@digia.com>
1169
1170         [Qt] Fix incremental builds with all-in-one-files and gccdepends
1171
1172         Reviewed by Tor Arne Vestbø.
1173
1174         Pass -MP to gcc when we use the gcc depends feature, to ensure that implicit rules
1175         are not only created for header files but also for .cpp files. AllInOne.cpp files
1176         include other .cpp files, and when those are removed we need those dummy rules to
1177         avoid a "No rule to make Foo.cpp required by AllInOne.o" error.
1178
1179         * qmake/config.tests/gccdepends/empty.cpp:
1180         (main):
1181         * qmake/config.tests/gccdepends/gccdepends.pro:
1182         * qmake/mkspecs/features/default_pre.prf:
1183
1184 2012-09-19  Rick Byers  <rbyers@chromium.org>
1185
1186         Do touch adjustment on GestureTapDown
1187         https://bugs.webkit.org/show_bug.cgi?id=96677
1188
1189         Reviewed by Antonio Gomes.
1190
1191         Allow radius to be set for GestureTapDown events.
1192         * DumpRenderTree/chromium/TestRunner/EventSender.cpp:
1193         (EventSender::gestureEvent):
1194
1195 2012-09-19  Christophe Dumez  <christophe.dumez@intel.com>
1196
1197         [EFL] EFL's DRT does not support overriding 'WebKitCSSRegionsEnabled' preference
1198         https://bugs.webkit.org/show_bug.cgi?id=97100
1199
1200         Reviewed by Gyuyoung Kim.
1201
1202         EFL's DRT now supports overriding the 'WebKitCSSRegionsEnabled'
1203         preference, in order to match WebKitTestRunner functionality.
1204
1205         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1206         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
1207         * DumpRenderTree/efl/TestRunnerEfl.cpp:
1208         (TestRunner::overridePreference):
1209
1210 2012-09-18  Kangil Han  <kangil.han@samsung.com>
1211
1212         [WK2][WTR] CodeGeneratorTestRunner could keep original copyright.
1213         https://bugs.webkit.org/show_bug.cgi?id=96181
1214
1215         Reviewed by Daniel Bates.
1216
1217         This patch enabled derived files, in DerivedSources/InjectedBundle, to keep original copyright.
1218
1219         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
1220         (new):
1221         (_parseLicenseBlock):
1222         (_parseLicenseBlockFromFile):
1223         (_defaultLicenseBlock):
1224         (_licenseBlock):
1225         (_generateHeaderFile):
1226         (_generateImplementationFile):
1227
1228 2012-09-18  Byungwoo Lee  <bw80.lee@samsung.com>
1229
1230         Title string should be changed when document.title is set to ''.
1231         https://bugs.webkit.org/show_bug.cgi?id=96793
1232
1233         Reviewed by Kenneth Rohde Christiansen.
1234
1235         Change dump format of dumpTitleChanges more understandable.
1236         Uses single quotation marks for the title string.
1237
1238         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
1239         (BlackBerry::WebKit::DumpRenderTree::didReceiveTitleForFrame):
1240         * DumpRenderTree/chromium/WebViewHost.cpp:
1241         (WebViewHost::didReceiveTitle):
1242         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1243         (DumpRenderTreeChrome::onFrameTitleChanged):
1244         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1245         (webViewTitleChanged):
1246         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1247         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
1248         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1249         (WebCore::DumpRenderTree::titleChanged):
1250         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1251         (FrameLoadDelegate::didReceiveTitle):
1252         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
1253         (LayoutWebViewEventHandler::OnReceivedTitleEvent):
1254         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1255         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
1256
1257 2012-09-18  Szilard Ledan  <szledan@inf.u-szeged.hu>
1258
1259         EWS shouldn't sleep if there are new patches in its queue
1260         https://bugs.webkit.org/show_bug.cgi?id=83038
1261
1262         Reviewed by Eric Seidel.
1263
1264         EWS tries to process a security patch. Of course it can't, because the EWS isn't
1265         the member of the security group. But the problem is that after it can't process
1266         the attachment, it says that queue is empty (but it isn't!) and it sleeps 2 minutes
1267         and push the security patch to the end of the queue.
1268         Now it stays in the loop until it finds a patch or the queue gets empty.
1269
1270         * Scripts/webkitpy/tool/commands/queues.py:
1271         (AbstractPatchQueue._next_patch):
1272         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1273         (AbstractPatchQueueTest.test_next_patch):
1274
1275 2012-09-18  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1276
1277         [WK2][WTR] InjectedBundle::booleanForKey() should handle literals effectively
1278         https://bugs.webkit.org/show_bug.cgi?id=97014
1279
1280         Reviewed by Kenneth Rohde Christiansen.
1281
1282         According to http://trac.webkit.org/wiki/EfficientStrings WTF::StringBuilder::appendLiteral() shall
1283         be used for literals rather than WTF::StringBuilder::append().
1284
1285         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1286         (WTR::InjectedBundle::booleanForKey):
1287
1288 2012-09-18  Simon Hausmann  <simon.hausmann@digia.com>
1289
1290         Update my e-mail address.
1291
1292         * Scripts/webkitpy/common/config/committers.py:
1293
1294 2012-09-18  Andras Becsi  <andras.becsi@digia.com>
1295
1296         Update my e-mail address.
1297
1298         Unreviewed.
1299
1300         * Scripts/webkitpy/common/config/committers.py:
1301
1302 2012-09-18  Andras Becsi  <andras.becsi@digia.com>
1303
1304         [Qt] qt_webkit.pri should not be listed in Tools.pro
1305
1306         Reviewed and rubber-stamped by Simon Hausmann and Tor Arne Vestbø.
1307
1308         Since r128751 the module pri file is auto-generated
1309         but it was still listed in OTHER_FILES.
1310
1311         * Tools.pro: Remove unneeded line.
1312
1313 2012-09-18  Simon Hausmann  <simon.hausmann@digia.com>
1314
1315         [Qt] Fix build with some versions of the gold linker
1316
1317         Reviewed by Tor Arne Vestbø.
1318
1319         Don't unconditionally pass --no-keep-memory to the linker, some versions might not support it.
1320         Instead run a compile/link test first to see if it works.
1321
1322         * qmake/config.tests/gnuld/gnuld.pro: Added.
1323         * qmake/config.tests/gnuld/main.cpp: Added.
1324         (main):
1325         * qmake/mkspecs/features/unix/default_post.prf:
1326
1327 2012-09-18  Simon Hausmann  <simon.hausmann@digia.com>
1328
1329         [Qt] Remove forced use of gold.
1330
1331         Reviewed by Tor Arne Vestbø.
1332
1333         The choice of what linker to use with WebKit should be taken by Qt's build system and ideally the same for all
1334         modules of Qt. Then in turn it is usually up to the administrator of the machine. Recent Debian based systems
1335         often offer the automatic use of gold through a symlink and a dpkg-diversion when installing the gold package.
1336
1337         * qmake/mkspecs/features/unix/default_post.prf:
1338
1339 2012-09-18  Simon Hausmann  <simon.hausmann@digia.com>
1340
1341         [Qt] Prospective Qt/Windows cross-compiling fix
1342
1343         Reviewed by Tor Arne Vestbø.
1344
1345         The win32 scope is not set when cross-compiling from Linux to Windows.
1346
1347         * qmake/mkspecs/features/functions.prf:
1348
1349 2012-09-18  Seokju Kwon  <seokju.kwon@samsung.com>
1350
1351         [EFL] Remove background view on EWebLauncher and MiniBrowser
1352         https://bugs.webkit.org/show_bug.cgi?id=96905
1353
1354         Reviewed by Gyuyoung Kim.
1355
1356         The size of webview was changed after adding url bar.
1357         And the background view is not necessary anymore, since it was used for debugging back in the day.
1358
1359         * EWebLauncher/main.c:
1360         (_ELauncher):
1361         (on_ecore_evas_resize):
1362         (browserCreate):
1363         * MiniBrowser/efl/main.c:
1364         (_MiniBrowser):
1365         (on_ecore_evas_resize):
1366         (browserCreate):
1367
1368 2012-09-18  Sergio Villar Senin  <svillar@igalia.com>
1369
1370         [GTK] run-webkit-tests unable to find TestExpectations for WK2
1371         https://bugs.webkit.org/show_bug.cgi?id=96998
1372
1373         Reviewed by Philippe Normand.
1374
1375         We should look for TestExpectations files in all the locations where
1376         we currently look for Skipped files. This will allow
1377         run-webkit-tests to look for TestExpectations files in
1378         platform/gtk-wk2 and platform/wk2 if the "-2" flag is used.
1379
1380         * Scripts/webkitpy/layout_tests/port/gtk.py:
1381         (GtkPort.expectations_files):
1382
1383 2012-09-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1384
1385         [Qt] Fix build without the QtQuick module
1386
1387         Reviewed by Simon Hausmann.
1388
1389         * qmake/mkspecs/features/features.prf:
1390
1391 2012-09-18  Stephanie Lewis  <slewis@apple.com>
1392
1393         Build fix after http://trac.webkit.org/projects/webkit/changeset/128852.
1394
1395         Unreviewed.
1396
1397         * DumpRenderTree/mac/DumpRenderTree.mm:
1398         (poseAsClass):
1399
1400 2012-09-18  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
1401
1402         Unreviewed update of email addresses for Berlin QtWebKit office.
1403
1404         * Scripts/webkitpy/common/config/committers.py:
1405
1406 2012-09-17  Zan Dobersek  <zandobersek@gmail.com>
1407
1408         [GTK] fast/loader/display-image-unset-can-block-image-and-can-reload-in-place.html failing after r128645
1409         https://bugs.webkit.org/show_bug.cgi?id=96899
1410
1411         Reviewed by Martin Robinson.
1412
1413         When overriding the 'WebKitDisplayImageKey' preference, use the
1414         'auto-load-images' property of WebKitWebSettings as the property which
1415         should be updated with the corresponding preference value.
1416
1417         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1418         (resetDefaultsToConsistentValues):
1419         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
1420         (TestRunner::overridePreference):
1421
1422 2012-09-17  Pratik Solanki  <psolanki@apple.com>
1423
1424         DumpRenderTree and WebKitTestRunner should compile with -Wundef on Mac
1425         https://bugs.webkit.org/show_bug.cgi?id=96973
1426
1427         Reviewed by Dan Bernstein.
1428
1429         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1430         * WebKitTestRunner/Configurations/Base.xcconfig:
1431         * WebKitTestRunner/PlatformWebView.h: Use #ifdef __OBJC__ and not #if.
1432
1433 2012-09-17  Dirk Pranke  <dpranke@chromium.org>
1434
1435         nrwt: remove "unexpected EOF" warnings
1436         https://bugs.webkit.org/show_bug.cgi?id=96970
1437
1438         Reviewed by Ojan Vafai.
1439
1440         After debugging this a bit, it looks like there aren't any cases
1441         that I can reproduce where a read() of zero indicates something
1442         actually wrong; either it is a prelude to a crash, or a false
1443         negative. So, I'm removing these warnings and adding a comment.
1444
1445         * Scripts/webkitpy/layout_tests/port/server_process.py:
1446         (ServerProcess._wait_for_data_and_update_buffers_using_select):
1447
1448 2012-09-17  Dirk Pranke  <dpranke@chromium.org>
1449
1450         [chromium] ASAN bot is crashing at the end of the run
1451         https://bugs.webkit.org/show_bug.cgi?id=96967
1452
1453         Reviewed by Abhishek Arya.
1454
1455         The ASAN bot is crashing attempting to decode some output into
1456         UTF-8; there's no reason to do this, so let's not do this and
1457         see if something else is going on as well.
1458
1459         * Scripts/webkitpy/layout_tests/port/chromium.py:
1460         (ChromiumPort._get_crash_log):
1461
1462 2012-09-17  Dirk Pranke  <dpranke@chromium.org>
1463
1464         nrwt: --results-directory isn't getting printed properly
1465         https://bugs.webkit.org/show_bug.cgi?id=96965
1466
1467         Reviewed by Ojan Vafai.
1468
1469         options.results_directory isn't actually initialized with the
1470         default values until after we call print_config(), so this
1471         changes things to print the value directly.
1472
1473         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1474         (run):
1475         * Scripts/webkitpy/layout_tests/views/printing.py:
1476         (Printer.print_config):
1477         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
1478         (Testprinter.test_print_config):
1479
1480 2012-09-17  Rob Buis  <rbuis@rim.com>
1481
1482         [BlackBerry] Enable VIDEO_TRACK
1483         https://bugs.webkit.org/show_bug.cgi?id=96949
1484
1485         Reviewed by Antonio Gomes.
1486
1487         * Scripts/webkitperl/FeatureList.pm:
1488
1489 2012-09-17  Rick Byers  <rbyers@chromium.org>
1490
1491         Add handling of new GestureTapCancel in DRT
1492
1493         https://bugs.webkit.org/show_bug.cgi?id=96183
1494
1495         Reviewed by Antonio Gomes.
1496
1497         * DumpRenderTree/chromium/TestWebPlugin.cpp:
1498         (TestWebPlugin::handleInputEvent):
1499         * DumpRenderTree/chromium/EventSender.cpp:
1500         (EventSender::gestureTapCancel):
1501
1502 2012-09-17  Philip Rogers  <pdr@google.com>
1503
1504         Teach style checker about preprocessor directive indentation rules
1505         https://bugs.webkit.org/show_bug.cgi?id=96874
1506
1507         Reviewed by Adam Barth.
1508
1509         Preprocessor directives (#ifdef, #include, #define, etc.) should not be indented.
1510         This is not explicit in our style guide but is generally followed in our code.
1511         Searching for violations in our codebase shows these are rarely indented:
1512             #include - indented in 6 files
1513             #ifdef - indented in 0 files
1514             #ifndef - indented in 1 file
1515             #define - indented in 11 files
1516             #if - indented in 7 files
1517
1518         * Scripts/webkitpy/style/checkers/cpp.py:
1519         (check_directive_indentation):
1520
1521             This is the simple test where we look for spaces followed by a #.
1522
1523         (check_style):
1524         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1525
1526             A few tests needed to be modified because they had unintentionally indented
1527             preprocessor directives.
1528
1529         (CppStyleTest.test_build_class.Foo):
1530         (CppStyleTest.test_build_class):
1531         (CppStyleTest.test_build_class.DERIVE_FROM_GOO):
1532         (WebKitStyleTest.test_line_breaking):
1533         (WebKitStyleTest.test_directive_indentation):
1534
1535 2012-09-17  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1536
1537         [Qt] Auto-generate the module pri file for QtWebKit
1538
1539         Reviewed by Simon Hausmann.
1540
1541         * qmake/qt_webkit.pri: Removed.
1542
1543 2012-09-14  Dirk Pranke  <dpranke@chromium.org>
1544
1545         nrwt: --additional-platform-dir is broken on chromium ports
1546         https://bugs.webkit.org/show_bug.cgi?id=96840
1547
1548         Reviewed by Ojan Vafai.
1549
1550         Looks like I broke this when cleaning things up as part of
1551         adding ML support. Fixing and adding a test.
1552
1553         * Scripts/webkitpy/layout_tests/port/chromium.py:
1554         (ChromiumPort.default_baseline_search_path):
1555         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1556         (ChromiumAndroidPort.default_baseline_search_path):
1557         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1558         (ChromiumLinuxPort.default_baseline_search_path):
1559         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1560         (ChromiumMacPort.__init__):
1561         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1562         (ChromiumWinPort.setup_environ_for_server):
1563         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1564         (test_check_build):
1565         (test_additional_platform_directory):
1566
1567 2012-09-13  Stephanie Lewis  <slewis@apple.com>
1568
1569         mac-future ignores previous platform TestExpectations.
1570         https://bugs.webkit.org/show_bug.cgi?id=96718.
1571
1572         Reviewed by Dirk Pranke.
1573
1574         TestExpectations match an expectation's configuraton against a list of configurations that are 
1575         valid for that port.  That list does not contain mac-future so none of the expectations can be
1576         applied.
1577
1578         * Scripts/webkitpy/layout_tests/port/apple.py:
1579         (ApplePort._generate_all_test_configurations):
1580
1581 2012-09-14  Adam Barth  <abarth@webkit.org>
1582
1583         Remove webkitPostMessage
1584         https://bugs.webkit.org/show_bug.cgi?id=96577
1585
1586         Reviewed by Ojan Vafai.
1587
1588         Add ENABLE_LEGACY_VENDOR_PREFIXES flag.
1589
1590         * Scripts/webkitperl/FeatureList.pm:
1591         * qmake/mkspecs/features/features.pri:
1592
1593 2012-09-14  Alexey Proskuryakov  <ap@apple.com>
1594
1595         [WK2] webarchive/loading/javascript-url-iframe-crash.html fails
1596         https://bugs.webkit.org/show_bug.cgi?id=96817
1597
1598         Reviewed by Kenneth Rohde Christiansen.
1599
1600         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1601         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame): This callback
1602         got overlooked when adding logging elsewhere.
1603
1604 2012-09-14  Peter Beverloo  <peter@chromium.org>
1605
1606         [Chromium] Build fix for DumpRenderTree following r128628
1607         https://bugs.webkit.org/show_bug.cgi?id=96808
1608
1609         Reviewed by Tony Chang.
1610
1611         When building DumpRenderTree from the Chromium project, a compile error
1612         shows up because including the header ForwardIOStreamsAndroid.h cannot
1613         be located. TestWebKitAPI does this correctly.
1614
1615         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1616
1617 2012-09-14  Dana Jansens  <danakj@chromium.org>
1618
1619         Change cc-bugs@google.com watchlist to cc-bugs@chromium.org
1620         https://bugs.webkit.org/show_bug.cgi?id=96805
1621
1622         Reviewed by Dirk Pranke.
1623
1624         * Scripts/webkitpy/common/config/committers.py:
1625         * Scripts/webkitpy/common/config/watchlist:
1626
1627 2012-09-14  Peter Beverloo  <peter@chromium.org>
1628
1629         [Chromium] Support the --{in,out,err}-fifo arguments on TestWebKitAPI and webkit_unit_tests
1630         https://bugs.webkit.org/show_bug.cgi?id=96687
1631
1632         Reviewed by Tony Chang.
1633
1634         Android's DumpRenderTree currently supports these arguments, implemented
1635         as part of TestShellAndroid:
1636         http://trac.webkit.org/browser/trunk/Tools/DumpRenderTree/chromium/TestShellAndroid.cpp?rev=128496
1637
1638         They're used by the layout test runner to get the STDOUT and STDERR while
1639         a layout test run is in process, which is a safer alternative to parsing
1640         all the logcat output manually. The implementation can be seen here:
1641         http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py?rev=128496#L590
1642
1643         This patch generalizes parsing of and applying the effects of these arguments
1644         so that they can be used for TestWebKitAPI and webkit_unit_tests as well.
1645         After this patch, this will make it possible to pull out the output-reading
1646         code from Android's layout test port and generalize it so it can be re-used
1647         in the new test-runner for the other two test suites.
1648
1649         This has no effect when compiling and running these tests as part of Chromium
1650         code, which has a much more advanced test-runner that does parse complete log
1651         output, but also directly depends on code licensed under Apache 2.
1652
1653         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1654         * DumpRenderTree/chromium/TestShellAndroid.cpp:
1655         (platformInit):
1656         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
1657
1658 2012-09-14  Zoltan Horvath  <zoltan@webkit.org>
1659
1660         check-webkit-style should not warn in case of NONCOPYABLE and FAST_ALLOCATED macros
1661         https://bugs.webkit.org/show_bug.cgi?id=96656
1662
1663         Reviewed by Adam Barth.
1664
1665         We should allow to use WTF_MAKE_NONCOPYABLE(ClassName) and WTF_MAKE_FAST_ALLOCATED
1666         macros in 1 line.
1667
1668         * Scripts/webkitpy/style/checkers/cpp.py:
1669         (check_style.definitions):
1670         (check_style): Add rule.
1671         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1672         (WebKitStyleTest.test_line_breaking): Add unittest.
1673
1674 2012-09-14  Christophe Dumez  <christophe.dumez@intel.com>
1675
1676         WebKitTestRunner needs layoutTestController.dumpDatabaseCallbacks
1677         https://bugs.webkit.org/show_bug.cgi?id=57570
1678
1679         Reviewed by Kenneth Rohde Christiansen.
1680
1681         Implement testRunner.dumpDatabaseCallbacks in WebKitTestRunner
1682         and dump the information expected by the test cases.
1683
1684         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1685         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1686         (WTR::InjectedBundle::beginTesting): Explicitly set the default
1687         database quota.
1688         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1689         (WTR::securityOriginToStr): New convenience function to convert
1690         a security origin to the string expected in test results.
1691         (WTR):
1692         (WTR::InjectedBundlePage::InjectedBundlePage):
1693         (WTR::InjectedBundlePage::didExceedDatabaseQuota):
1694         (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota): Minor
1695         refactoring to share code with didExceedDatabaseQuota.
1696         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1697         (InjectedBundlePage):
1698         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1699         (WTR::TestRunner::TestRunner):
1700         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1701         (WTR::TestRunner::dumpDatabaseCallbacks):
1702         (WTR::TestRunner::shouldDumpDatabaseCallbacks):
1703         (TestRunner):
1704
1705 2012-09-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1706
1707         [Qt] Set force_static_libs_as_shared early enough to be caught by configure
1708
1709         Rubber-stamped by Simon Hausmann.
1710
1711         * qmake/mkspecs/features/default_post.prf:
1712
1713 2012-09-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1714
1715         [Qt] Remove old cruft from the qmake build system
1716
1717         Rubber-stamped by Simon Hausmann.
1718
1719         * DumpRenderTree/qt/DumpRenderTree.pro:
1720         * qmake/mkspecs/features/default_post.prf:
1721
1722 2012-09-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1723
1724         [Qt] Enable force_static_libs_as_shared for development
1725
1726         Not enabled for buildbots or production-builds (part of Qt5)
1727
1728         Reviewed by Simon Hausmann.
1729
1730         * qmake/mkspecs/features/default_post.prf:
1731
1732 2012-09-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1733
1734         [Qt] Make force_static_libs_as_shared work on Mac OS
1735
1736         We had to move a few LIBS += around that were in the wrong place,
1737         and not caught when everything was just linked into the final
1738         QtWebKit library.
1739
1740         Reviewed by Simon Hausmann.
1741
1742         * qmake/mkspecs/features/default_post.prf:
1743         * qmake/mkspecs/features/force_static_libs_as_shared.prf:
1744
1745 2012-09-14  Simon Hausmann  <simon.hausmann@nokia.com>
1746
1747         [Qt] Fix build of WTR on Windows
1748
1749         Reviewed by Tor Arne Vestbø.
1750
1751         WTR/qt/main.cpp includes TestController.h, which lives in just WTR/
1752         With qmake's unix makefile generator as well as with the MingW generator,
1753         the directory where the pro file lives (WTR/) is automatically added to
1754         the include search path, but not so with MSVC. Instead of relying on qmake's
1755         implicit feature here, add WTR/ explicitly to the include search path.
1756
1757         * WebKitTestRunner/Target.pri:
1758
1759 2012-09-14  Christophe Dumez  <christophe.dumez@intel.com>
1760
1761         WebKitTestRunner needs layoutTestController.setStopProvisionalFrameLoads
1762         https://bugs.webkit.org/show_bug.cgi?id=42691
1763
1764         Reviewed by Kenneth Rohde Christiansen.
1765
1766         Add implementation for testrunner.setStopProvisionalFrameLoads()
1767         in WebKitTestRunner.
1768
1769         Original patch by Alexey Proskuryakov.
1770
1771         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1772         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1773         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
1774         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1775         (WTR::TestRunner::TestRunner):
1776         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1777         (TestRunner):
1778         (WTR::TestRunner::setStopProvisionalFrameLoads):
1779         (WTR::TestRunner::shouldStopProvisionalFrameLoads):
1780
1781 2012-09-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1782
1783         [Qt] Fix handling of debug/release/debug_and_release/build_all
1784
1785         We now pick up the defaults from Qt, in default_pre (CONFIG already
1786         contains the appropriate values for debug and release). We then let
1787         the command line arguments to qmake, or the project files themselves,
1788         override the configuration, and finally we sanitize the configuration
1789         in default_post.
1790
1791         Reviewed by Simon Hausmann.
1792
1793         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1794         * Scripts/webkitdirs.pm:
1795         (buildQMakeProjects):
1796         * qmake/mkspecs/features/default_post.prf:
1797         * qmake/mkspecs/features/default_pre.prf:
1798         * qmake/mkspecs/features/mac/default_pre.prf:
1799
1800 2012-09-14  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1801
1802         WebKitTestRunner needs layoutTestController.setTabKeyCyclesThroughElements
1803         https://bugs.webkit.org/show_bug.cgi?id=42687
1804
1805         Reviewed by Kenneth Rohde Christiansen.
1806
1807         Implement testRunner.setTabKeyCyclesThroughElements for
1808         WebKitTestRunner.
1809
1810         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1811         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1812         (WTR::InjectedBundle::beginTesting):
1813         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1814         (WTR::TestRunner::setTabKeyCyclesThroughElements):
1815         (WTR):
1816         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1817         (TestRunner):
1818
1819 2012-09-14  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1820
1821         EventSendingController::keyDown does not support non-array modifier arguments
1822         https://bugs.webkit.org/show_bug.cgi?id=96727
1823
1824         Reviewed by Kenneth Rohde Christiansen.
1825
1826         Add support for handling a string as modifier argument to
1827         EventSendingController::keyDown.
1828
1829         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1830         (WTR::parseModifierArray):
1831
1832 2012-09-14  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1833
1834         WebKitTestRunner needs layoutTestController.setCustomPolicyDelegate
1835         https://bugs.webkit.org/show_bug.cgi?id=42546
1836
1837         Reviewed by Kenneth Rohde Christiansen.
1838
1839         Exported TestRunner::setCustomPolicyDelegate() method.
1840         Allowed Policy Delegate dumping even if we're not in 'waitUntilDone' mode.
1841
1842         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1843         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1844         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
1845
1846 2012-09-14  Zan Dobersek  <zandobersek@gmail.com>
1847
1848         [GTK] Clear application cache between tests in DumpRenderTree
1849         https://bugs.webkit.org/show_bug.cgi?id=96543
1850
1851         Reviewed by Philippe Normand.
1852
1853         Call the new DumpRenderTreeSupportGtk method to clear application cache
1854         after each test in DumpRenderTree.
1855
1856         Set the XDG_CACHE_HOME environment variable when running DumpRenderTree
1857         as well. It's now being set in XvfbDriver._start so that each driver is assigned
1858         a cache directory that's constructed out of the driver's name and its worker
1859         number. These directories are located in the layout tests results directory.
1860         At least on the builders this ensures a driver-specific empty cache directory
1861         with each test run.
1862
1863         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1864         (runTest):
1865         * Scripts/webkitpy/layout_tests/port/gtk.py:
1866         (GtkPort.setup_environ_for_server):
1867         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
1868         (XvfbDriver._start):
1869
1870 2012-09-14  Simon Hausmann  <simon.hausmann@nokia.com>
1871
1872         [Qt] Fix linking on Windows
1873
1874         Reviewed by Tor Arne Vestbø.
1875
1876         When compiling code _after_ QtWebKit.dll, we need to make sure that the QWEBKIT_EXPORT
1877         macro turns into an import macro, which means QT_MAKEDLL should only be set _up until_
1878         the QtWebKit.dll creation in the build process and be off afterwards. This is done in
1879         win32/default_post.prf using a !contains(QT, webkit): DEFINES += QT_MAKEDLL.
1880
1881         r128450 sanitized the values of QT and PKGCONFIG to only contain the dependencies we
1882         want for QtWebKit.dll, but unfortunately that code was applied to any binary built also
1883         after the module. Therefore QT did never contain webkit anymore and we always passed
1884         QT_MAKEDLL to DEFINES, resulting in QWEBKIT_EXPORT to _not_ turn into an import macro.
1885
1886         This patch introduces a creating_module configuration that is used to
1887         scope the qt/pkgconfig sanitization.
1888
1889         * qmake/mkspecs/features/default_post.prf:
1890
1891 2012-09-14  Christophe Dumez  <christophe.dumez@intel.com>
1892
1893         [WK2][WKTR] TestRunner is not dumping some frame load callbacks information
1894         https://bugs.webkit.org/show_bug.cgi?id=96740
1895
1896         Reviewed by Kenneth Rohde Christiansen.
1897
1898         Dump information expected by the test cases about the following
1899         frame load callbacks:
1900         "didDisplayInsecureContentForFrame"
1901         "didRunInsecureContentForFrame"
1902         "didDetectXSSForFrame"
1903
1904         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1905         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame): Print a URL
1906         as expected by test results by calling pathSuitableForTestResult() instead
1907         of printing raw URL.
1908         (WTR::InjectedBundlePage::didDisplayInsecureContentForFrame):
1909         (WTR::InjectedBundlePage::didRunInsecureContentForFrame):
1910         (WTR::InjectedBundlePage::didDetectXSSForFrame):
1911
1912 2012-09-14  Peter Beverloo  <peter@chromium.org>
1913
1914         The runtime/unsigned category should be valid in the cpp style-checker.
1915         https://bugs.webkit.org/show_bug.cgi?id=96748
1916
1917         Reviewed by Csaba Osztrogonác.
1918
1919         This is causing the webkitpy tests to fail because it's not listed in the
1920         category array. Furthermore, change an "int" to "long" because it's
1921         throwing a double error in one of the earlier asserts.
1922
1923         * Scripts/webkitpy/style/checkers/cpp.py:
1924         (CppChecker):
1925         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1926         (WebKitStyleTest.test_names):
1927
1928 2012-09-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1929
1930         Evas_Object* is a ref'ed structure, so tread it as such
1931         https://bugs.webkit.org/show_bug.cgi?id=96659
1932
1933         Reviewed by Adam Barth.
1934
1935         Replace OwnPtr<Evas_Object> with RefPtr.
1936
1937         * DumpRenderTree/efl/ImageDiff.cpp:
1938         (calculateDifference):
1939         (printImageDifferences):
1940         (readImageFromStdin):
1941         (main):
1942
1943 2012-09-14  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1944
1945         Unreviewed, rolling out r128507.
1946         http://trac.webkit.org/changeset/128507
1947         https://bugs.webkit.org/show_bug.cgi?id=96659
1948
1949         Revert. r128507 makes too many crashes in EFL layout test bots.
1950
1951         * DumpRenderTree/efl/ImageDiff.cpp:
1952         (calculateDifference):
1953         (printImageDifferences):
1954         (readImageFromStdin):
1955         (main):
1956
1957 2012-09-13  Kevin Funk  <kevin.funk@kdab.com>
1958
1959         Make compile with both OS(WINCE) and PLATFORM(QT) support
1960         https://bugs.webkit.org/show_bug.cgi?id=95536
1961
1962         Reviewed by Simon Hausmann.
1963
1964         Fix wince support in qmake files
1965
1966         * Tools.pro:
1967         * qmake/mkspecs/features/configure.prf:
1968         * qmake/mkspecs/features/default_post.prf:
1969         * qmake/mkspecs/features/features.prf:
1970         * qmake/mkspecs/features/functions.prf:
1971
1972 2012-09-13  KwangYong Choi  <ky0.choi@samsung.com>
1973
1974         [WK2] Add color picker API support for WebKit2
1975         https://bugs.webkit.org/show_bug.cgi?id=95058
1976
1977         Reviewed by Gyuyoung Kim.
1978
1979         Initialization code for color picker callbacks in UI client.
1980
1981         * MiniBrowser/mac/BrowserWindowController.m:
1982         (-[BrowserWindowController awakeFromNib]):
1983         * MiniBrowser/win/BrowserView.cpp:
1984         (BrowserView::create):
1985         * WebKitTestRunner/TestController.cpp:
1986         (WTR::TestController::createOtherPage):
1987         (WTR::TestController::initialize):
1988
1989 2012-09-13  Yuta Kitamura  <yutak@chromium.org>
1990
1991         Upgrade yutak to reviewer
1992         https://bugs.webkit.org/show_bug.cgi?id=96721
1993
1994         Reviewed by Kent Tamura.
1995
1996         * Scripts/webkitpy/common/config/committers.py:
1997
1998 2012-09-13  Adenilson Cavalcanti  <cavalcantii@gmail.com>
1999
2000         Make the style checker report usage of "unsigned int"
2001         https://bugs.webkit.org/show_bug.cgi?id=96693
2002
2003         Reviewed by Dirk Pranke.
2004
2005         Add a rule to check for uses of unsigned int, as the updated coding style recomends.
2006
2007         * Scripts/webkitpy/style/checkers/cpp.py:
2008         (check_language):
2009
2010 2012-09-13  Philip Rogers  <pdr@google.com>
2011
2012         Add gender-neutral form of webkit-patch land-cowboy
2013         https://bugs.webkit.org/show_bug.cgi?id=96709
2014
2015         Reviewed by Adam Barth.
2016
2017         Add webkit-patch land-cowhand, the confident and courageous form of webkit-patch for everyone.
2018
2019         * Scripts/webkitpy/tool/commands/download.py:
2020         (LandCowhand):
2021
2022 2012-09-13  Seokju Kwon  <seokju.kwon@samsung.com>
2023
2024         [EFL] Remove some parameters in browserCreate()
2025         https://bugs.webkit.org/show_bug.cgi?id=96499
2026
2027         Reviewed by Kenneth Rohde Christiansen.
2028
2029         There are too many parameters in browserCreate(). Lots of it seems like settings from command line argument.
2030         And I have moved some parameters into User_Arguments.
2031
2032         * EWebLauncher/main.c:
2033         (_User_Arguments):
2034         (_ELauncher):
2035         (on_key_down):
2036         (browserCreate):
2037         (findThemePath):
2038         (parseUserArguments):
2039         (main):
2040
2041 2012-09-13  Mark Lam  <mark.lam@apple.com>
2042
2043         Unreviewed. Adding myself to the committers list.
2044
2045         * Scripts/webkitpy/common/config/committers.py:
2046
2047 2012-09-13  Ryosuke Niwa  <rniwa@webkit.org>
2048
2049         run-perf-tests output cryptic error when the config file is missing.
2050         https://bugs.webkit.org/show_bug.cgi?id=96453
2051
2052         Reviewed by Tony Chang.
2053
2054         Add a special error message when a configuration file is missing.
2055
2056         Also update the help message of --source-json-path to signify the fact it specifies
2057         the configuration file on performance tests bots.
2058
2059         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2060         (PerfTestsRunner._parse_args):
2061         (PerfTestsRunner._generate_and_show_results):
2062         (PerfTestsRunner._merge_slave_config_json):
2063         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2064         (_test_run_with_json_output): Make upload to fail by default and assert the result
2065         in the function so that we can return logs instead.
2066         (_test_run_with_json_output.mock_upload_json):
2067         (test_run_with_json_output):
2068         (test_run_with_description):
2069         (test_run_respects_no_results):
2070         (test_run_with_slave_config_json):
2071         (test_run_with_bad_slave_config_json):
2072         (test_run_with_multiple_repositories):
2073
2074 2012-09-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2075
2076         Evas_Object* is a ref'ed structure, so tread it as such
2077         https://bugs.webkit.org/show_bug.cgi?id=96659
2078
2079         Reviewed by Adam Barth.
2080
2081         Replace OwnPtr<Evas_Object> with RefPtr.
2082
2083         * DumpRenderTree/efl/ImageDiff.cpp:
2084         (calculateDifference):
2085         (printImageDifferences):
2086         (readImageFromStdin):
2087         (main):
2088
2089 2012-09-13  Csaba Osztrogonác  <ossy@webkit.org>
2090
2091         One more unreviewed trivial fix after r128399.
2092
2093         * BuildSlaveSupport/build.webkit.org-config/config.json: Fix URLs of the SVN mirror server.
2094
2095 2012-09-13  Csaba Osztrogonác  <ossy@webkit.org>
2096
2097         Unreviewed trivial fix after r128399.
2098
2099         * BuildSlaveSupport/wait-for-SVN-server.py: Renamed from Tools/BuildSlaveSupport/build.webkit.org-config/wait-for-SVN-server.py.
2100         (getLatestSVNRevision):
2101         (waitForSVNRevision):
2102
2103 2012-09-13  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2104
2105         [WK2][WTR] WebKitTestRunner needs testRunner.callShouldCloseOnWebView
2106         https://bugs.webkit.org/show_bug.cgi?id=96366
2107
2108         Reviewed by Anders Carlsson.
2109
2110         Implement testRunner.callShouldCloseOnWebView for WebKitTestRunner
2111         by calling shouldClose() on the FrameLoader.
2112
2113         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2114         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2115         (WTR::TestRunner::callShouldCloseOnWebView):
2116         (WTR):
2117         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2118         (TestRunner):
2119
2120 2012-09-13  Sheriff Bot  <webkit.review.bot@gmail.com>
2121
2122         Unreviewed, rolling out r128453.
2123         http://trac.webkit.org/changeset/128453
2124         https://bugs.webkit.org/show_bug.cgi?id=96681
2125
2126         Having tests use the same appcache directory leads to timeouts
2127         (Requested by zdobersek on #webkit).
2128
2129         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2130         (runTest):
2131         * Scripts/webkitpy/layout_tests/port/gtk.py:
2132         (GtkPort.setup_environ_for_server):
2133
2134 2012-09-13  James Robinson  <jamesr@chromium.org>
2135
2136         [chromium] Temporarily remove Android Builder (dbg) from garden-o-matic view
2137         https://bugs.webkit.org/show_bug.cgi?id=96678
2138
2139         Reviewed by Dirk Pranke.
2140
2141         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
2142         (.):
2143
2144 2012-09-13  Rob Buis  <rbuis@rim.com>
2145
2146         Unreviewed changes to watchlist.
2147
2148         - Add myself to BlackBerry bugs
2149
2150         * Scripts/webkitpy/common/config/watchlist:
2151
2152 2012-09-13  Stephen Chenney  <schenney@chromium.org>
2153
2154         Add an SVG entry to the watchlist
2155
2156         Unreviewed config change.
2157
2158         * Scripts/webkitpy/common/config/watchlist:
2159         - Created a new SVG watchlist label covering WebCore/svg and WebCore/rendering/svg
2160         - Added myself and pdr as watchers
2161
2162 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
2163
2164         [Qt] Make WebKit2 work on Windows with Qt 5
2165         https://bugs.webkit.org/show_bug.cgi?id=76776
2166
2167         Reviewed by Tor Arne Vestbø.
2168
2169         WebKit2 should compile with Qt on Windows now, so enable it. This patch in fact corrects
2170         the check to disable WebKit when we don't have USE_3D_GRAPHICS available, because we need
2171         that for the GL TextureMapper (it's only built when that feature is set).
2172
2173         * qmake/mkspecs/features/configure.prf:
2174
2175 2012-09-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2176
2177         [Qt] Ensure that QT is finalized before loading qt_module.prf
2178
2179         As qt_module.prf does dependency tracking based on the content of the
2180         QT variable. The intermediate WebKit modules modify the variable in
2181         their .pri files, so we have to ensure we've loaded all the modules
2182         before loading qt_module.
2183
2184         Reviewed by Tor Arne Vestbø.
2185         Patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2012-09-13
2186
2187         * qmake/mkspecs/features/default_post.prf:
2188         * qmake/mkspecs/features/webkit_modules.prf: Added.
2189
2190 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
2191
2192         [Qt] Fix build of Qt WTR/MiniBrowser with MSVC and nmake
2193         https://bugs.webkit.org/show_bug.cgi?id=96633
2194
2195         Reviewed by Csaba Osztrogonác.
2196
2197         WTR and MiniBrowser both have DRT in their include path (for the shared font stuff). Batch
2198         builds with MSVC and nmake result in nmake picking up main.cpp from the wrong directory.
2199         It's the usual problem and the usual solution is to rename one of the conflicting files.
2200         This patch chooses to rename DRT instead of WTR and MBR.
2201
2202         Fixed include order at the same time to match style guide.
2203
2204         * DumpRenderTree/qt/DumpRenderTree.pro:
2205         * DumpRenderTree/qt/DumpRenderTreeMain.cpp: Renamed from Tools/DumpRenderTree/qt/main.cpp.
2206         (messageHandler):
2207         (isOption):
2208         (takeOptionValue):
2209         (printUsage):
2210         (main):
2211
2212 2012-09-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2213
2214         The Script run-launcher should support -2 in combination with --efl
2215         https://bugs.webkit.org/show_bug.cgi?id=96639
2216
2217         Reviewed by Simon Hausmann.
2218
2219         Support running the MiniBrowser then supplied -2 as argument.
2220
2221         * Scripts/run-launcher:
2222
2223 2012-09-13  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2224
2225         Unreviewed, add my Intel email address to the list.
2226
2227         * Scripts/webkitpy/common/config/committers.py:
2228
2229 2012-09-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2230
2231         [Qt] Don't overwrite LIBS_PRIVATE when sanitizing LIBS
2232
2233         Reviewed by Ossy.
2234
2235         * qmake/mkspecs/features/default_post.prf:
2236
2237 2012-09-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2238
2239         [EFL][DRT] Implement LayoutTestController::layerTreeAsText
2240         https://bugs.webkit.org/show_bug.cgi?id=82294
2241
2242         Reviewed by Gyuyoung Kim.
2243
2244         Implement layerTreeAsText using the DumpRenderTreeSupportEfl method.
2245
2246         * DumpRenderTree/efl/TestRunnerEfl.cpp:
2247         (TestRunner::layerTreeAsText):
2248
2249 2012-09-13  Zan Dobersek  <zandobersek@gmail.com>
2250
2251         [GTK] Clear application cache between tests in DumpRenderTree
2252         https://bugs.webkit.org/show_bug.cgi?id=96543
2253
2254         Reviewed by Philippe Normand.
2255
2256         Call the new DumpRenderTreeSupportGtk method to clear application cache
2257         after each test.
2258
2259         Set the XDG_CACHE_HOME environment variable when running DumpRenderTree
2260         as well. Currently it points to a subdirectory in the layout tests results
2261         directory. At least on the builders this ensures an empty cache directory
2262         with each test run.
2263
2264         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2265         (runTest):
2266         * Scripts/webkitpy/layout_tests/port/gtk.py:
2267         (GtkPort.setup_environ_for_server):
2268
2269 2012-09-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2270
2271         [Qt] Make sure LIBS, PKGCONFIG, and QT, do not affect QtWebKit's prl file
2272
2273         Unless it's actually a dependency of the public QtWebKit API.
2274
2275         We could replace every occurance of LIBS, PKGCONFIG, and QT, in the pri
2276         files with their _PRIVATE equivivalent, but that's likely to break when
2277         someone adds a new QT/LIBS/PKGCONFIG += foo line somewhere. Instead we
2278         clean up the variables in default_post.
2279
2280         This means that the CONFIG -= explicitlib in linkAgainstLibrary() is no
2281         longer needed, as it was a workaround for the intermediate libraries ending
2282         up in the prl file. And, since CONFIG -= staticlib was there to support
2283         the explicitlib option, we can remove that too (as well as the exception
2284         for gprof, since it would be empty). If gprof needs tweaks to always link
2285         statically they should go in gprof.prf.
2286
2287         Reviewed by Simon Hausmann.
2288
2289         * qmake/mkspecs/features/default_post.prf:
2290         * qmake/mkspecs/features/functions.prf:
2291
2292 2012-09-13  Mario Sanchez Prada  <msanchez@igalia.com>
2293
2294         [GTK] "Infinite" loop in AccessibilityUIElementGtk.cpp
2295         https://bugs.webkit.org/show_bug.cgi?id=96632
2296
2297         Reviewed by Carlos Garcia Campos.
2298
2299         Fix this by using atk_object_get_n_accessible_children instead of
2300         calling getChildren() from childCount.
2301
2302         * WebKitTestRunner/InjectedBundle/gtk/AccessibilityUIElementGtk.cpp:
2303         (WTR::AccessibilityUIElement::childrenCount): Avoid the infinite
2304         loop by using atk_object_get_n_accessible_children().
2305
2306 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
2307
2308         [Qt][Win] Enable USE(3D_GRAPHICS)
2309         https://bugs.webkit.org/show_bug.cgi?id=90879
2310
2311         Reviewed by Kenneth Rohde Christiansen.
2312
2313         Enable it on Windows as well as on QNX (bug fixed).
2314
2315         * qmake/mkspecs/features/features.prf:
2316
2317 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
2318
2319         [Qt] The ANGLE build on Windows breaks with GnuWin32's flex because it is too old
2320         https://bugs.webkit.org/show_bug.cgi?id=96359
2321
2322         Reviewed by Tor Arne Vestbø.
2323
2324         GnuWin32's flex is 2.5.4 and that is too old for ANGLE's preprocessor
2325         lexer. The only viable alternative I could find on Windows that provides
2326         binaries is the winflexbison distribution (http://sourceforge.net/projects/winflexbison/),
2327         so let's use that one instead.
2328
2329         * Scripts/webkitdirs.pm:
2330         (checkRequiredSystemConfig):
2331         * qmake/mkspecs/features/default_pre.prf:
2332
2333 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
2334
2335         [Qt] Add configuration for production builds
2336         https://bugs.webkit.org/show_bug.cgi?id=96607
2337
2338         Reviewed by Kenneth Rohde Christiansen.
2339
2340         Add configuration tweaks for production builds, to ease memory pressure with the GNU toolchain
2341         and enable all-in-one-files optimizations.
2342
2343         * qmake/mkspecs/features/production_build.prf: Added.
2344
2345 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
2346
2347         [Qt] GStreamer detection does not work when cross-compiling
2348         https://bugs.webkit.org/show_bug.cgi?id=96608
2349
2350         Reviewed by Kenneth Rohde Christiansen.
2351
2352         When cross-compiling it is not safe to just use system(pkg-config),
2353         because there is a high probability that it will find packages in the
2354         host system instead of in the target one. Instead use qmake's new
2355         packagesExist() function that takes care of this delicate aspect of
2356         cross compilation by setting PKG_CONFIG_SYSROOT_DIR and
2357         PKG_CONFIG_LIBDIR accordingly.
2358
2359         * qmake/mkspecs/features/features.prf:
2360
2361 2012-09-13  Christophe Dumez  <christophe.dumez@intel.com>
2362
2363         [WK2][WTR] More efficient string handling in InjectedBundlePage
2364         https://bugs.webkit.org/show_bug.cgi?id=96609
2365
2366         Reviewed by Kenneth Rohde Christiansen.
2367
2368         Update StringBuilder usage in InjectedBundlePage to follow
2369         the latest recommandations for efficient string handling:
2370         http://trac.webkit.org/wiki/EfficientStrings
2371
2372         This involves using appendLiteral() or appendNumber()
2373         instead of append() whenever possible.
2374
2375         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2376         (WTR::dumpPath):
2377         (WTR::rangeToStr):
2378         (WTR::styleDecToStr):
2379         (WTR::frameToStr):
2380         (WTR::dumpResourceURL):
2381         (WTR):
2382         (WTR::dumpFrameDescriptionSuitableForTestResult):
2383         (WTR::dumpRequestDescriptionSuitableForTestResult):
2384         (WTR::dumpResponseDescriptionSuitableForTestResult):
2385         (WTR::dumpErrorDescriptionSuitableForTestResult):
2386         (WTR::InjectedBundlePage::didReceiveIntentForFrame):
2387         (WTR::InjectedBundlePage::registerIntentServiceForFrame):
2388         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
2389         (WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
2390         (WTR::InjectedBundlePage::didCommitLoadForFrame):
2391         (WTR::InjectedBundlePage::didFinishProgress):
2392         (WTR::dumpFrameScrollPosition):
2393         (WTR::dumpFrameText):
2394         (WTR::dumpDescendantFramesText):
2395         (WTR::InjectedBundlePage::didFinishLoadForFrame):
2396         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
2397         (WTR::InjectedBundlePage::didCancelClientRedirectForFrame):
2398         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame):
2399         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
2400         (WTR::InjectedBundlePage::didHandleOnloadEventsForFrame):
2401         (WTR::InjectedBundlePage::willSendRequestForFrame):
2402         (WTR::InjectedBundlePage::didReceiveResponseForResource):
2403         (WTR::InjectedBundlePage::didFinishLoadForResource):
2404         (WTR::InjectedBundlePage::didFailLoadForResource):
2405         (WTR::InjectedBundlePage::shouldCacheResponse):
2406         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
2407         (WTR::InjectedBundlePage::willAddMessageToConsole):
2408         (WTR::InjectedBundlePage::willSetStatusbarText):
2409         (WTR::InjectedBundlePage::willRunJavaScriptAlert):
2410         (WTR::InjectedBundlePage::willRunJavaScriptConfirm):
2411         (WTR::InjectedBundlePage::willRunJavaScriptPrompt):
2412         (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota):
2413         (WTR::InjectedBundlePage::shouldBeginEditing):
2414         (WTR::InjectedBundlePage::shouldEndEditing):
2415         (WTR::InjectedBundlePage::shouldInsertNode):
2416         (WTR::InjectedBundlePage::shouldInsertText):
2417         (WTR::InjectedBundlePage::shouldDeleteRange):
2418         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
2419         (WTR::InjectedBundlePage::shouldApplyStyle):
2420         (WTR::InjectedBundlePage::didBeginEditing):
2421         (WTR::InjectedBundlePage::didEndEditing):
2422         (WTR::InjectedBundlePage::didChange):
2423         (WTR::InjectedBundlePage::didChangeSelection):
2424         (WTR::InjectedBundlePage::supportsFullScreen):
2425         (WTR::InjectedBundlePage::enterFullScreenForElement):
2426         (WTR::InjectedBundlePage::exitFullScreenForElement):
2427         (WTR::InjectedBundlePage::beganEnterFullScreen):
2428         (WTR::InjectedBundlePage::beganExitFullScreen):
2429         (WTR::InjectedBundlePage::closeFullScreen):
2430         (WTR::dumpBackForwardListItem):
2431         (WTR::InjectedBundlePage::dumpBackForwardList):
2432
2433 2012-09-13  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2434
2435         [Qt][WK2] Memory leaks in Qt's TestRunner
2436         https://bugs.webkit.org/show_bug.cgi?id=96603
2437
2438         Reviewed by Csaba Osztrogonác.
2439
2440         Fix memory leaks in Qt's TestRunner code by adopting WKString
2441         created with WKStringCreateWithUTF8CString().
2442
2443         * WebKitTestRunner/qt/TestControllerQt.cpp:
2444         (WTR::TestController::initializeInjectedBundlePath):
2445         (WTR::TestController::initializeTestPluginDirectory):
2446
2447 2012-09-13  Zan Dobersek  <zandobersek@gmail.com>
2448
2449         [GTK][NRWT] Lower timeout value to 6 seconds (12 for debug configuration)
2450         https://bugs.webkit.org/show_bug.cgi?id=96506
2451
2452         Reviewed by Dirk Pranke.
2453
2454         Lower the timeout value to 6 seconds for release configuration and 12 seconds
2455         for debug configuration. These are the same values the Chromium port uses.
2456
2457         Currently the value is lowered only for the DumpRenderTree, WebKitTestRunner (and
2458         the layout tests under WebKit2 generally) requires more attention and gardening
2459         than what the current effort produces.
2460
2461         The unit test is updated as well to test these changes.
2462
2463         * Scripts/webkitpy/layout_tests/port/gtk.py:
2464         (GtkPort.default_timeout_ms):
2465         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
2466         (GtkPortTest.test_default_timeout_ms):
2467         (GtkPortTest.assertLinesEqual):
2468
2469 2012-09-12  Csaba Osztrogonác  <ossy@webkit.org>
2470
2471         Add SVN mirror handling feature to build.webkit.org
2472         https://bugs.webkit.org/show_bug.cgi?id=85887
2473
2474         Reviewed by Dirk Pranke.
2475
2476         * BuildSlaveSupport/build.webkit.org-config/config.json: Add SVN mirrors for Qt buildslaves hosted in Szeged.
2477         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2478         (ConfigureBuild.__init__): Add SVNMirror property to be able to watch which slaves use which mirror on build.webkit.org.
2479         (ConfigureBuild.start):
2480         (CheckOutSource.__init__): Set baseURL to the SVNMirror or the default http://svn.webkit.org/repository/webkit/
2481         (WaitForSVNServer): Add new buildstep for waiting the SVNMirror to be in sync with http://svn.webkit.org/repository/webkit/
2482         (Factory.__init__):
2483         (BuildFactory.__init__):
2484         (TestFactory.__init__):
2485         (BuildAndTestFactory.__init__):
2486         (BuildAndPerfTestFactory.__init__):
2487         (BuildAndPerfTestWebKit2Factory.__init__):
2488         (DownloadAndPerfTestFactory.__init__):
2489         (DownloadAndPerfTestWebKit2Factory.__init__):
2490         (loadBuilderConfig): Use kwargs instead of args to be able to add the optional SVNMirror factory argument.
2491         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2492         (SVNMirrorTest):
2493         (SVNMirrorTest.setUp): Load config.json once at startup.
2494         (SVNMirrorTest.get_SVNMirrorFromConfig): Get the SVNMirror from config.json for a given buildslave.
2495         (SVNMirrorTest.test_CheckOutSource): Compare CheckOutSource.baseURL with SVNMirror in config.json for all builders
2496         * BuildSlaveSupport/build.webkit.org-config/wait-for-SVN-server.py: Added.
2497         (getLatestSVNRevision): Get the latest SVN revison from the given server.
2498         (waitForSVNRevision): Wait until the given SVN revision is committed to the given server. It doesn't wait if the
2499                               SVN revision is empty (force build triggered without revision) or the server is unavailable.
2500
2501 2012-09-12  Kangil Han  <kangil.han@samsung.com>
2502
2503         [WK2][WTR] Set waitUntilDone watchdog timer value equal to WK1.
2504         https://bugs.webkit.org/show_bug.cgi?id=81606
2505
2506         Reviewed by Tim Horton.
2507
2508         6 seconds is harsh for some jquery test cases.
2509         Therefore, adjust the value to match DumpRenderTree.
2510
2511         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2512         (WTR):
2513
2514 2012-09-12  KyungTae Kim  <ktf.kim@samsung.com>
2515
2516         [EFL] Support download attribute feature
2517         https://bugs.webkit.org/show_bug.cgi?id=96462
2518
2519         Reviewed by Gyuyoung Kim.
2520
2521         Enable DOWNLOAD_ATTRIBUTE feature for EFL port,
2522         and add "download,request" callback to the DumpRenderTree for EFL.
2523
2524         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2525         (DumpRenderTreeChrome::createView):
2526         (DumpRenderTreeChrome::onDownloadRequest):
2527         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
2528         (DumpRenderTreeChrome):
2529         * Scripts/webkitperl/FeatureList.pm:
2530
2531 2012-09-12  Stephanie Lewis  <slewis@apple.com>
2532
2533         Reduce parallism on the wk2 testers.
2534         https://bugs.webkit.org/show_bug.cgi?id=95906
2535
2536         Reviewed by Dirk Pranke.
2537
2538         The wk2 testers on Mountain Lion are getting stuck and timing out.  The problem appears to be due to
2539         resource contention.  Reducing the number of processes alleviates the issue.  
2540
2541         Starting by reducing 25%.
2542
2543         * Scripts/webkitpy/layout_tests/port/mac.py:
2544         (MacPort.default_child_processes):
2545
2546 2012-09-12  Brady Eidson  <beidson@apple.com>
2547
2548         Assert in NetscapePlugin::destroy() with async plugin init
2549         <rdar://problem/12277595> and https://bugs.webkit.org/show_bug.cgi?id=96576
2550
2551         Reviewed by Anders Carlsson.
2552
2553         Expose NPN_Invoke to plug-in tests:
2554         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2555         (PluginTest::NPN_Invoke):
2556         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
2557         (PluginTest):
2558
2559         Add a test that uses NPN_Invoke on the window object from inside NPP_New to remove the plug-in element:
2560         * DumpRenderTree/TestNetscapePlugIn/Tests/InvokeDestroysPluginWithinNPP_New.cpp: Added.
2561         (InvokeDestroysPluginWithinNPP_New):
2562         (InvokeDestroysPluginWithinNPP_New::InvokeDestroysPluginWithinNPP_New):
2563         (InvokeDestroysPluginWithinNPP_New::NPP_New):
2564         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2565
2566 2012-09-12  Dirk Pranke  <dpranke@chromium.org>
2567
2568         refactor TestExpectations tokenization slightly in preparation for the new syntax
2569         https://bugs.webkit.org/show_bug.cgi?id=96564
2570
2571         Reviewed by Ojan Vafai.
2572
2573         This change changes how we will tokenize/lex the
2574         TestExpectations files, in preparation for supporting both the
2575         old syntax and the new one. This change by itself should be a
2576         no-op.
2577
2578         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2579         (TestExpectationParser._tokenize_line):
2580         (TestExpectationParser):
2581         (TestExpectationParser._tokenize_line_using_old_format):
2582         (TestExpectationParser._tokenize_line_using_new_format):
2583
2584 2012-09-12  Dirk Pranke  <dpranke@chromium.org>
2585
2586         remove unused testexpectations editing code from webkitpy, garden-o-matic
2587         https://bugs.webkit.org/show_bug.cgi?id=96562
2588
2589         Reviewed by Adam Barth.
2590
2591         This code was prototyped but never fully realized. Removing
2592         until it reanimates :).
2593
2594         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
2595         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
2596         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor.py: Removed.
2597         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py: Removed.
2598         * Scripts/webkitpy/tool/servers/gardeningserver.py:
2599         (BuildCoverageExtrapolator.extrapolate_test_configurations):
2600         (GardeningHTTPRequestHandler._run_webkit_patch):
2601         (GardeningHTTPRequestHandler.ping):
2602         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
2603         (BuildCoverageExtrapolatorTest.test_extrapolate):
2604         (GardeningServerTest.test_rebaseline_new_port):
2605
2606 2012-09-12  Lucas Forschler  <lforschler@apple.com>
2607
2608         Remove unused bot, apple-xserve-1.
2609         https://bugs.webkit.org/show_bug.cgi?id=96570
2610         
2611         Reviewed by Stephanie Lewis.
2612
2613         * BuildSlaveSupport/build.webkit.org-config/config.json:
2614
2615 2012-09-12  Xan Lopez  <xlopez@igalia.com>
2616
2617         [GTK] We attempt to rebase documentation even if it's not present
2618         https://bugs.webkit.org/show_bug.cgi?id=96553
2619
2620         Reviewed by Martin Robinson.
2621
2622         Do not make the documentation rebase step fatal. This allows make
2623         install to succeed when there's no documentation generated.
2624
2625         * gtk/generate-gtkdoc:
2626
2627 2012-09-12  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2628
2629         Respect WEBKITOUTPUTDIR when running EFL tests
2630         https://bugs.webkit.org/show_bug.cgi?id=96528
2631
2632         Reviewed by Dirk Pranke.
2633
2634         Expose user set WEBKITOUTPUTDIR to the web process.
2635
2636         * Scripts/webkitpy/layout_tests/port/driver.py:
2637         (Driver._start): Add WEBKITOUTPUTDIR to the environment
2638         of the web process and its potential jhbuild wrapper.
2639
2640 2012-09-12  Dirk Pranke  <dpranke@chromium.org>
2641
2642         webkitdirs: fix uname version handling for cygwin
2643         https://bugs.webkit.org/show_bug.cgi?id=96436
2644
2645         Reviewed by Jon Honeycutt.
2646
2647         Newer versions of cygwin embed an additional version string
2648         inside parentheses, so you get "1.7.16(0.249/5/3)" instead of "1.7.16".
2649         Update the code to handle that.
2650
2651         * Scripts/webkitdirs.pm:
2652         (setupAppleWinEnv):
2653
2654 2012-09-12  Christophe Dumez  <christophe.dumez@intel.com>
2655
2656         Regression(r128338): Broke Windows build
2657         https://bugs.webkit.org/show_bug.cgi?id=96537
2658
2659         Unreviewed build fix.
2660
2661         Fix Apple-Win build by allocating array dynamically
2662         since its size is not constant.
2663
2664         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2665         (WTR::stringArrayToJS):
2666
2667 2012-09-12  Alex Sakhartchouk  <alexst@chromium.org>
2668
2669         [chromium] Add a virtual test suite for fast/hidpi
2670         https://bugs.webkit.org/show_bug.cgi?id=90192
2671
2672         Reviewed by Dirk Pranke.
2673
2674         Add a virtual test suite to make sure the pixel tests in fast/hidpi give the same result
2675         on the hardware accelerated path as the software path.
2676
2677         * DumpRenderTree/chromium/WebPreferences.cpp:
2678         (WebPreferences::applyTo):
2679         * Scripts/webkitpy/layout_tests/port/chromium.py:
2680         (ChromiumPort.virtual_test_suites):
2681
2682 2012-09-12  Adam Klein  <adamk@chromium.org>
2683
2684         [chromium] Add content_browsertests to the flakiness dashboard
2685         https://bugs.webkit.org/show_bug.cgi?id=96535
2686
2687         Reviewed by Ojan Vafai.
2688
2689         * TestResultServer/static-dashboards/dashboard_base.js:
2690
2691 2012-09-12  Christophe Dumez  <christophe.dumez@intel.com>
2692
2693         [WK2][WKTR] TestRunner needs to implement originsWithApplicationCache
2694         https://bugs.webkit.org/show_bug.cgi?id=96496
2695
2696         Reviewed by Kenneth Rohde Christiansen.
2697
2698         Add implementation for originsWithApplicationCache to
2699         WebKitTestRunner.
2700
2701         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2702         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2703         (WTR::stringArrayToJS):
2704         (WTR):
2705         (WTR::TestRunner::originsWithApplicationCache):
2706         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2707         (TestRunner):
2708
2709 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
2710
2711         Fix Qt/Windows build with Python3
2712         https://bugs.webkit.org/show_bug.cgi?id=96473
2713
2714         Reviewed by Csaba Osztrogonác.
2715
2716         In Python 3 print is a real function, so we must use parentheses around
2717         the function parameters. This is backwards compatible with Python 2.
2718
2719         * Scripts/generate-win32-export-forwards:
2720
2721 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
2722
2723         Unreviewed trivial build fix for Qt/Windows after bug #96358.
2724
2725         As pointed out by Kevin, we should inject the "set PATH=..." statement
2726         to add the GnuWin32 directory only if that directory actually exists.
2727
2728         * qmake/mkspecs/features/default_post.prf:
2729
2730 2012-09-12  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2731
2732         [EFL] [WK2] Memory leaks in TestControllerEfl
2733         https://bugs.webkit.org/show_bug.cgi?id=96525
2734
2735         Reviewed by Kenneth Rohde Christiansen.
2736
2737         Fix memory leaks in EFL's TestRunner code by adopting an allocation
2738         of WKString created with WKStringCreateWithUTF8CString().
2739
2740         * WebKitTestRunner/efl/TestControllerEfl.cpp:
2741         (WTR::TestController::initializeInjectedBundlePath):
2742         (WTR::TestController::initializeTestPluginDirectory):
2743
2744 2012-09-12  Christophe Dumez  <christophe.dumez@intel.com>
2745
2746         [WK2][WKTR] TestRunner needs to implement dumpApplicationCacheDelegateCallbacks
2747         https://bugs.webkit.org/show_bug.cgi?id=96374
2748
2749         Reviewed by Kenneth Rohde Christiansen.
2750
2751         Implement support for dumpApplicationCacheDelegateCallbacks
2752         and disallowIncreaseForApplicationCacheQuota in
2753         WebKitTestRunner and properly dump the information
2754         expected by the tests.
2755
2756         If the application cache quota is reached for a given
2757         security origin, WebKitTestRunner will reset the quota
2758         to its default value, unless intructed not to via
2759         disallowIncreaseForApplicationCacheQuota().
2760
2761         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2762         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2763         (WTR::InjectedBundlePage::InjectedBundlePage):
2764         (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota):
2765         (WTR):
2766         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2767         (InjectedBundlePage):
2768         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2769         (WTR::TestRunner::TestRunner):
2770         (WTR::TestRunner::disallowIncreaseForApplicationCacheQuota):
2771         (WTR):
2772         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2773         (WTR::TestRunner::dumpApplicationCacheDelegateCallbacks):
2774         (TestRunner):
2775         (WTR::TestRunner::shouldDisallowIncreaseForApplicationCacheQuota):
2776         (WTR::TestRunner::shouldDumpApplicationCacheDelegateCallbacks):
2777
2778 2012-09-12  Jochen Eisinger  <jochen@chromium.org>
2779
2780         [chromium] remove deprecated and unused sets import from chromium_android driver
2781         https://bugs.webkit.org/show_bug.cgi?id=96485
2782
2783         Reviewed by Dirk Pranke.
2784
2785         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2786
2787 2012-09-12  Zan Dobersek  <zandobersek@gmail.com>
2788
2789         Flakiness dashboard doesn't recognize new Chromium Android test builder
2790         https://bugs.webkit.org/show_bug.cgi?id=96523
2791
2792         Reviewed by Ojan Vafai.
2793
2794         Properly return 'ANDROID' as the Chromium platform for Android builders.
2795
2796         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2797         (chromiumPlatform):
2798         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2799         (test):
2800
2801 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
2802
2803         [Qt] Build on Windows requires bison/flex in PATH
2804         https://bugs.webkit.org/show_bug.cgi?id=96358
2805
2806         Reviewed by Tor Arne Vestbø.
2807
2808         The build requires flex, bison, etc. and they need to be in the PATH when building. On Mac OS X
2809         and Linux that is rarely a problem given how easily available the tools are. On Windows however
2810         a separate installation of various GNU tools is required as the operating system doesn't come with
2811         them. To make the development more convenient, Qt 5 provides a copy of the most essential tools in
2812         the gnuwin32 directory of the qt5.git top-level repository.
2813
2814         This patch tries to detect the presence of those tools and prepends them to the PATH if found.
2815
2816         This is required in preparation for the elimination of qt5/qtwebkit.pri, which currently expands
2817         PATH before calling build-webkit. It it also required for the upcoming introduction of win_flex
2818         as dependency over flex, which can be done with less hassle when qt5's gnuwin32 directory has been
2819         updated with the new tool.
2820
2821         * Scripts/webkitdirs.pm:
2822         (checkRequiredSystemConfig):
2823         * qmake/mkspecs/features/default_post.prf:
2824
2825 2012-09-12  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2826
2827         [Qt] Update build-jsc after r128174
2828
2829         Reviewed by Ossy.
2830
2831         * Scripts/build-jsc:
2832
2833 2012-09-12  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2834
2835         [Qt] Teach addStrictSubdirOrderBetween to handle more than two targets
2836
2837         By hard-coding the names of the targets we defined we ended up just
2838         redefining the previous target when using addStrictSubdirOrderBetween
2839         more than once in a single project file.
2840
2841         We now embed the two base targets into the target names.
2842
2843         Reviewed by Simon Hausmann.
2844
2845         * qmake/mkspecs/features/functions.prf:
2846
2847 2012-09-12  Philippe Liard  <pliard@google.com>
2848
2849         Depend on {base,net} GYP targets rather than {base,net}_java.
2850         https://bugs.webkit.org/show_bug.cgi?id=95690
2851
2852         Reviewed by Adam Barth.
2853
2854         {base,net}_java became 'private' targets on the Chromium side that
2855         clients should not depend on (see
2856         https://chromiumcodereview.appspot.com/10913083/).
2857         This removes a bunch of trailing white spaces additionally in
2858         TestWebkitAPI.gyp (which includes non-trailing white space changes).
2859
2860         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2861         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
2862
2863 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
2864
2865         [Qt] Fix the build with ENABLE_NETSCAPE_PLUGIN_API=0
2866         https://bugs.webkit.org/show_bug.cgi?id=96494
2867
2868         Reviewed by Tor Arne Vestbø.
2869
2870         WK2's ENABLE_PLUGIN_PROCESS uses the NPAPI functions unconditionally, so disable the
2871         plugin process feature if we don't have NPAPI.
2872
2873         * qmake/mkspecs/features/features.prf:
2874
2875 2012-09-12  Sheriff Bot  <webkit.review.bot@gmail.com>
2876
2877         Unreviewed, rolling out r128280.
2878         http://trac.webkit.org/changeset/128280
2879         https://bugs.webkit.org/show_bug.cgi?id=96498
2880
2881         it broke compilation on windows debug bot (Requested by loislo
2882         on #webkit).
2883
2884         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2885         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2886         (WTR::InjectedBundlePage::InjectedBundlePage):
2887         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2888         (InjectedBundlePage):
2889         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2890         (WTR::TestRunner::TestRunner):
2891         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2892         (TestRunner):
2893
2894 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
2895
2896         [Qt] Make it possible to build with "make release" and "make debug" on Windows
2897         https://bugs.webkit.org/show_bug.cgi?id=96488
2898
2899         Reviewed by Tor Arne Vestbø.
2900
2901         A "make debug" is passed through recursively and currently it aborts at Makefile.DerivedSources
2902         because there are no such targets. We want the generated sources to be independent from release
2903         or debug build configurations, so it is sufficient to provide fake debug and release targets that
2904         redirect to the same general-purpose target (first) of creating the derived sources.
2905
2906         * qmake/mkspecs/features/default_post.prf:
2907
2908 2012-09-12  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2909
2910         [EFL] Make DumpRenderTree smarter at finding the fonts
2911         http://webkit.org/b/96281
2912
2913         Reviewed by Gyuyoung Kim.
2914
2915         Respect WEBKITOUTPUTDIR and expand the font dir from it.
2916         Use CString consistently.
2917
2918         * DumpRenderTree/efl/FontManagement.cpp:
2919         (buildPath):
2920         (getCoreFontFiles):
2921         (addFontDirectory):
2922         (addFontFiles):
2923         (getCustomBuildDir):
2924         (getPlatformFontsPath):
2925         (addFontsToEnvironment):
2926
2927 2012-09-12  Christophe Dumez  <christophe.dumez@intel.com>
2928
2929         [WK2][WKTR] TestRunner needs to implement dumpApplicationCacheDelegateCallbacks
2930         https://bugs.webkit.org/show_bug.cgi?id=96374
2931
2932         Reviewed by Kenneth Rohde Christiansen.
2933
2934         Implement support for dumpApplicationCacheDelegateCallbacks
2935         and disallowIncreaseForApplicationCacheQuota in
2936         WebKitTestRunner and properly dump the information
2937         expected by the tests.
2938
2939         If the application cache quota is reached for a given
2940         security origin, WebKitTestRunner will reset the quota
2941         to its default value, unless intructed not to via
2942         disallowIncreaseForApplicationCacheQuota().
2943
2944         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2945         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2946         (WTR::InjectedBundlePage::InjectedBundlePage):
2947         (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota):
2948         (WTR):
2949         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2950         (InjectedBundlePage):
2951         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2952         (WTR::TestRunner::TestRunner):
2953         (WTR::TestRunner::disallowIncreaseForApplicationCacheQuota):
2954         (WTR):
2955         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2956         (WTR::TestRunner::dumpApplicationCacheDelegateCallbacks):
2957         (TestRunner):
2958         (WTR::TestRunner::shouldDisallowIncreaseForApplicationCacheQuota):
2959         (WTR::TestRunner::shouldDumpApplicationCacheDelegateCallbacks):
2960
2961 2012-09-12  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2962
2963         [WK2] [WTR] WebKitTestRunner needs TestRunner.workerThreadCount
2964         https://bugs.webkit.org/show_bug.cgi?id=96388
2965
2966         Reviewed by Kenneth Rohde Christiansen.
2967
2968         Exported TestRunner.workerThreadCount as readonly attribute.
2969
2970         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2971         * WebKitTestRunner/InjectedBundle/TestRunner.cpp: Added workerThreadCount() method implementation.
2972         (WTR::TestRunner::workerThreadCount): Returns count of worker threads.
2973         (WTR):
2974         * WebKitTestRunner/InjectedBundle/TestRunner.h: Added workerThreadCount() method. 
2975         (TestRunner):
2976
2977 2012-09-12  Jochen Eisinger  <jochen@chromium.org>
2978
2979         [chromium] Consume a user gesture when creating a new view.
2980         https://bugs.webkit.org/show_bug.cgi?id=96373
2981
2982         Reviewed by Adam Barth.
2983
2984         * DumpRenderTree/chromium/WebViewHost.cpp:
2985         (WebViewHost::createView):
2986
2987 2012-09-12  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2988
2989         [WK2][WTR] Some of TestRunner special options are not reset before testing
2990         https://bugs.webkit.org/show_bug.cgi?id=96384
2991
2992         Reviewed by Kenneth Rohde Christiansen.
2993
2994         Now values of the following special options are reset:
2995         void setAcceptsEditing(in boolean value);
2996         void setCloseRemainingWindowsWhenComplete(in boolean value);
2997         void setXSSAuditorEnabled(in boolean value);
2998         void setAllowFileAccessFromFileURLs(in boolean value);
2999         void setPluginsEnabled(in boolean value);
3000         void setPopupBlockingEnabled(in boolean value);
3001
3002         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3003         (WTR::InjectedBundle::beginTesting):
3004
3005 2012-09-11  Ryuan Choi  <ryuan.choi@samsung.com>
3006
3007         [CMAKE] Supply feature defines to CodeGeneratorTestRunner.
3008         https://bugs.webkit.org/show_bug.cgi?id=96273
3009
3010         Reviewed by Gyuyoung Kim.
3011
3012         Passed FEATURE_DEFINES_WITH_SPACE_SEPARATOR to CodeGeneratorTestRunner
3013         in order to distinguish compile time options such as ENABLE(TOUCH_EVENTS).
3014
3015         * WebKitTestRunner/CMakeLists.txt:
3016
3017 2012-09-11  Dirk Pranke  <dpranke@chromium.org>
3018
3019         [chromium] rename webkit_resources
3020         https://bugs.webkit.org/show_bug.cgi?id=95874
3021
3022         Reviewed by James Robinson.
3023
3024         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3025
3026 2012-09-11  Jochen Eisinger  <jochen@chromium.org>
3027
3028         [chromium] don't include content shell builders in the garden-o-matic view
3029         https://bugs.webkit.org/show_bug.cgi?id=96418
3030
3031         Reviewed by James Robinson.
3032
3033         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
3034
3035 2012-09-11  Adam Klein  <adamk@chromium.org>
3036
3037         Garden-o-matic should ignore a wider variety of warnings in buildbot json
3038         https://bugs.webkit.org/show_bug.cgi?id=96411
3039
3040         Reviewed by Adam Barth.
3041
3042         Previously only the exact string "warning" was treated as a warning
3043         result. This patch treats any string with "warning" as a substring
3044         as a warning (e.g., "warnings", as seen on the cr-win buildbots).
3045
3046         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
3047         (.):
3048         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
3049
3050 2012-09-11  Marcelo Lira  <marcelo.lira@openbossa.org>
3051
3052         Restore original value of mock scrollbars enabled in InternalSettings
3053         https://bugs.webkit.org/show_bug.cgi?id=87680
3054
3055         Reviewed by Adam Barth.
3056
3057         Added backup support for mock scrollbars state in
3058         InternalSettings::Backup, and removed support for these
3059         from Qt's DumpRenderTree.
3060
3061         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3062         (WebCore::WebPage::resetSettings):
3063         * DumpRenderTree/qt/TestRunnerQt.cpp:
3064         (TestRunner::setFrameFlatteningEnabled):
3065         * DumpRenderTree/qt/TestRunnerQt.h:
3066         (TestRunner):
3067
3068 2012-09-11  Dan Bernstein  <mitz@apple.com>
3069
3070         Fixed a bug where kill-old-processes failed to kill clang++.
3071
3072         Rubber-stamped by Alexey Proskuryakov.
3073
3074         * BuildSlaveSupport/kill-old-processes: Escape the + signs in "clang++"
3075         where it is passed as a regular expression to killall.
3076
3077 2012-09-11  Philippe Liard  <pliard@google.com>
3078
3079         Make sure that md5sum is not setup on non-Chromium Android platforms.
3080         https://bugs.webkit.org/show_bug.cgi?id=96393
3081
3082         Reviewed by Adam Barth.
3083
3084         Previously md5sum was setup in ChromiumAndroidDriver's constructor
3085         which is also invoked on non-Chromium Android platforms. The following patch
3086         moves this logic to _startup_test() which is guaranteed to be invoked
3087         only on Android.
3088
3089         This also updates the prompt unit test in chromium_android_unittest.py.
3090
3091         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3092         (ChromiumAndroidDriver.__init__):
3093         (ChromiumAndroidDriver._setup_md5sum_and_push_data_if_needed):
3094         (ChromiumAndroidDriver._setup_test):
3095
3096 2012-09-11  Raphael Kubo da Costa  <rakuco@webkit.org>
3097
3098         [EFL] Rewrite the EFL-related Find modules
3099         https://bugs.webkit.org/show_bug.cgi?id=95237
3100
3101         Reviewed by Kenneth Rohde Christiansen.
3102
3103         * DumpRenderTree/efl/CMakeLists.txt: Stop setting the LINK_FLAGS
3104         property and include all the Enlightenment Foundation Libraries
3105         required by the target.
3106         * EWebLauncher/CMakeLists.txt: Ditto.
3107         * MiniBrowser/efl/CMakeLists.txt: Ditto.
3108         * TestWebKitAPI/PlatformEfl.cmake: Add missing include directories
3109         now that they are not added implicitly.
3110         * WebKitTestRunner/CMakeLists.txt: Stop setting the LINK_FLAGS
3111         property.
3112         * WebKitTestRunner/PlatformEfl.cmake: Stop setting the LINK_FLAGS
3113         property and include all the Enlightenment Foundation Libraries
3114         required by the target.
3115
3116 2012-09-11  Christophe Dumez  <christophe.dumez@intel.com>
3117
3118         [WK2][WKTR] TestRunner needs to implement setApplicationCacheOriginQuota
3119         https://bugs.webkit.org/show_bug.cgi?id=96379
3120
3121         Reviewed by Kenneth Rohde Christiansen.
3122
3123         Add implementation for setApplicationCacheOriginQuota
3124         to WebKitTestRunner.
3125
3126         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3127         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3128         (WTR::TestRunner::setApplicationCacheOriginQuota):
3129         (WTR):
3130         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3131         (TestRunner):
3132
3133 2012-09-11  Luciano Wolf  <luciano.wolf@openbossa.org>
3134
3135         [Qt] [WK2] editing/inserting/typing-tab-designmode tests are failing
3136         https://bugs.webkit.org/show_bug.cgi?id=91988
3137
3138         Reviewed by Kenneth Rohde Christiansen.
3139
3140         Regular key events generated by Qt for the tab key fill both
3141         keyCode and keyText, so we should do the same for our fake events.
3142
3143         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
3144         (WTR::EventSenderProxy::keyDown):
3145
3146 2012-09-11  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3147
3148         [WK2][WTR] WebKitTestRunner needs testRunner.setSpatialNavigationEnabled
3149         https://bugs.webkit.org/show_bug.cgi?id=96269
3150
3151         Reviewed by Kenneth Rohde Christiansen.
3152
3153         Exported missing testRunner.setSpatialNavigationEnabled() method.
3154
3155         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3156         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3157         (WTR::InjectedBundle::beginTesting):
3158         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3159         (WTR::TestRunner::setSpatialNavigationEnabled):
3160         (WTR):
3161         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3162         (TestRunner):
3163
3164 2012-09-11  Philippe Liard  <pliard@chromium.org>
3165
3166         Support LayoutTests on non-rooted devices for Chromium Android.
3167         https://bugs.webkit.org/show_bug.cgi?id=95346
3168
3169         Reviewed by Dirk Pranke.
3170
3171         We were requiring root permissions to sync resource files with the
3172         device by comparing host and device files' timestamp after we
3173         synchronized the device and host clocks.
3174         We now rely on md5sum provided by Chromium to handle data files
3175         synchronization.
3176
3177         * Scripts/webkitpy/layout_tests/port/chromium.py:
3178         (ChromiumPort._check_driver_build_up_to_date):
3179         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3180         (ChromiumAndroidDriver.__init__):
3181         (ChromiumAndroidDriver._setup_test):
3182         (ChromiumAndroidDriver._push_executable):
3183         (ChromiumAndroidDriver._push_test_resources):
3184         (ChromiumAndroidDriver._read_prompt):
3185
3186 2012-09-11  Simon Hausmann  <simon.hausmann@nokia.com>
3187
3188         [Qt] Fix output paths on Windows
3189
3190         Reviewed by Tor Arne Vestbø.
3191
3192         BUILD_ROOT_RELATIVE_TO_OUT_PWD was calculated incorrectly Windows, resulting in an incorrect
3193         DESTDIR transformation at the end of default_post.prf. The calculation should be baased no qmake
3194         paths, which can use drive letters but always use forward slashes. So the use of QMAKE_DIR_SEP is
3195         incorrect here and instead for the calculation we should use forward slashes.
3196
3197         * qmake/mkspecs/features/default_pre.prf:
3198
3199 2012-09-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3200
3201         [Qt] Fix passing of defines from the build system
3202
3203         We explicitly have to pass -DENABLE_FOO=0 for every single feature
3204         that's not explicitly enabled in WEBKIT_CONFIG, since Platform.h
3205         will add it's own defaults if the features are not defined.
3206
3207         At some point we might want to run a configure-test to inspect what
3208         Platform.h will do, so we can sync up the build system's view of
3209         the feature-defines with the compile-time situation.
3210
3211         Reviewed by Simon Hausmann.
3212
3213         * qmake/mkspecs/features/functions.prf:
3214
3215 2012-09-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3216
3217         [Qt] Fix --qt option to build-webkit
3218
3219         Reviewed by Ossy.
3220
3221         * Scripts/webkitdirs.pm:
3222         (buildQMakeProjects):
3223
3224 2012-09-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3225
3226         [Qt] Add a configure step to the Qt build system
3227
3228         This allows building the Qt port using just 'qmake WebKit.pro'. Using
3229         the build-webkit script is still supported, and will add slightly more
3230         logic to the build, such as detecting the need for clean or incremental
3231         builds.
3232
3233         Internally, the build system now uses a new variable, WEBKIT_CONFIG, for
3234         all things related to configuring the build, such as use/have/enable flags,
3235         and these are translated to defines in default_post. Project files should
3236         no longer check contains(DEFINES,...) to detect features, but use the new
3237         enable?(), use?(), and have?() functions. The no_webkit1 and no_webkit2
3238         options have been translated into WEBKIT_CONFIG options as well, and can
3239         be checked using build?().
3240
3241         Reviewed by Simon Hausmann.
3242
3243         * DumpRenderTree/qt/DumpRenderTree.pro:
3244         * MiniBrowser/qt/MiniBrowser.pro:
3245         * QtTestBrowser/QtTestBrowser.pro:
3246         * Scripts/build-webkit:
3247         * Scripts/webkitdirs.pm:
3248         (qtFeatureDefaults):
3249         (buildQMakeProjects):
3250         * Tools.pro:
3251         * WebKitTestRunner/InjectedBundle/DerivedSources.pri:
3252         * WebKitTestRunner/InjectedBundle/Target.pri:
3253         * WebKitTestRunner/Target.pri:
3254         * qmake/.qmake.cache: Added.
3255         * qmake/configure.pri: Removed.
3256         * qmake/configure.pro: Removed.
3257         * qmake/dump-features: Added.
3258         * qmake/mkspecs/features/configure.prf: Added.
3259         * qmake/mkspecs/features/default_post.prf:
3260         * qmake/mkspecs/features/default_pre.prf:
3261         * qmake/mkspecs/features/features.prf:
3262         * qmake/mkspecs/features/features.pri:
3263         * qmake/mkspecs/features/functions.prf:
3264         * qmake/mkspecs/features/gprof.prf:
3265         * qmake/mkspecs/features/mac/default_pre.prf:
3266         * qmake/mkspecs/features/win32/default_pre.prf:
3267
3268 2012-09-11  Christophe Dumez  <christophe.dumez@intel.com>
3269
3270         [WK2][WKTR] TestRunner needs to implement clearApplicationCacheForOrigin
3271         https://bugs.webkit.org/show_bug.cgi?id=96372
3272
3273         Reviewed by Kenneth Rohde Christiansen.
3274
3275         Implement clearApplicationCacheForOrigin() in WebKitTestRunner.
3276
3277         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3278         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3279         (WTR::TestRunner::clearApplicationCacheForOrigin):
3280         (WTR):
3281         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3282         (TestRunner):
3283
3284 2012-09-11  Peter Beverloo  <peter@chromium.org>
3285
3286         Don't ignore .pak files when making an archive for Android
3287         https://bugs.webkit.org/show_bug.cgi?id=96375
3288
3289         Reviewed by Jochen Eisinger.
3290
3291         The .pak files do need to be pushed to the device, which is currently
3292         preventing the layout test runner from correctly pushing all files.
3293
3294         * BuildSlaveSupport/built-product-archive:
3295         (archiveBuiltProduct):
3296
3297 2012-09-11  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3298
3299         [WK2][WTR] WebKitTestRunner needs layoutTestController.setMinimumTimerInterval
3300         https://bugs.webkit.org/show_bug.cgi?id=96256
3301
3302         Reviewed by Kenneth Rohde Christiansen.
3303
3304         Exported TestRunner::setMinimumTimerInterval() method.
3305
3306         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3307         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3308         (WTR::InjectedBundle::beginTesting):
3309         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3310         (WTR::TestRunner::setMinimumTimerInterval):
3311         (WTR):
3312         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3313         (TestRunner):
3314
3315 2012-09-11  Tommy Widenflycht  <tommyw@google.com>
3316
3317         MediaStream API: add RTCPeerConnection::onnegotiationneeded
3318         https://bugs.webkit.org/show_bug.cgi?id=96097
3319
3320         Reviewed by Adam Barth.
3321
3322         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
3323         (MockWebRTCPeerConnectionHandler::addStream):
3324         (MockWebRTCPeerConnectionHandler::removeStream):
3325
3326 2012-09-11  Peter Beverloo  <peter@chromium.org>
3327
3328         Recognize the "--chromium-android" argument in run-webkit-tests
3329         https://bugs.webkit.org/show_bug.cgi?id=96369
3330
3331         Reviewed by Jochen Eisinger.
3332
3333         Chromium for the Android platform cannot determine the platform based on
3334         the host itself, so we'll use the --chromium-android argument as the build
3335         master passes to run-webkit-tests. Make sure the layout test runner
3336         can pick the right port when doing so.
3337
3338         * Scripts/run-webkit-tests:
3339         * Scripts/webkitpy/layout_tests/port/factory.py:
3340         (port_options):
3341
3342 2012-09-11  Simon Hausmann  <simon.hausmann@nokia.com>
3343
3344         [QT] Fix build with newer qmake from Qt 5
3345
3346         Rubber-stamped by Tor Arne Vestbø.
3347
3348         Support for "qmake -query QMAKE_MKSPECS" was removed from qmake. Replace
3349         it with the use of QT_HOST_DATA/mkspecs.
3350         Based on patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com>.
3351
3352         * Scripts/webkitdirs.pm:
3353         (builtDylibPathForName):
3354         (qtMakeCommand):
3355
3356 2012-09-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3357
3358         [Qt] Remove Qt 4 syncqt, no longer needed
3359
3360         Reviewed by Simon Hausmann.
3361
3362         * qmake/syncqt-4.8: Removed.
3363
3364 2012-09-11  Andras Becsi  <andras.becsi@nokia.com>
3365
3366         [Qt][WK2] Fix the build with recent Qt5
3367         https://bugs.webkit.org/show_bug.cgi?id=96283
3368
3369         Reviewed by Simon Hausmann.
3370
3371         We should not use deprecated Qt API because doing that results
3372         in build failure since all the deprecated API was disabled
3373         in qtbase (https://codereview.qt-project.org/#change,24890).
3374
3375         * DumpRenderTree/qt/main.cpp:
3376         (main):
3377         * MiniBrowser/qt/MiniBrowserApplication.cpp:
3378         (MiniBrowserApplication::notify):
3379         * MiniBrowser/qt/raw/View.cpp:
3380         (View::exposeEvent):
3381         (main):
3382
3383 2012-09-11  Christophe Dumez  <christophe.dumez@intel.com>
3384
3385         WTR needs an implementation of applicationCacheDiskUsageForOrigin
3386         https://bugs.webkit.org/show_bug.cgi?id=87188
3387
3388         Reviewed by Kenneth Rohde Christiansen.
3389
3390         Add implementation for applicationCacheDiskUsageForOrigin()
3391         in WebKitTestRunner.
3392
3393         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3394         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3395         (WTR::TestRunner::applicationCacheDiskUsageForOrigin):
3396         (WTR):
3397         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3398         (TestRunner):
3399
3400 2012-09-10  Joanmarie Diggs  <jdiggs@igalia.com>
3401
3402         Properly expose <legend> elements to ATs
3403         https://bugs.webkit.org/show_bug.cgi?id=84137
3404
3405         Reviewed by Chris Fleizach.
3406
3407         Created a new WebCore Accessibility Role, LegendRole. Used it to map to
3408         the expected platform role, ATK_ROLE_LABEL. Also established the needed
3409         AtkRelation pair, label-for/labelled-by between the legend and fieldset.
3410
3411         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
3412         (roleToString): added "Legend" string for WebAccessibilityRoleLegend
3413
3414 2012-09-10  Jer Noble  <jer.noble@apple.com>
3415
3416         Unreviewed; rolling out r128081.
3417         http://trac.webkit.org/changeset/128081
3418         https://bugs.webkit.org/show_bug.cgi?id=96134
3419
3420         New test http/tests/media/video-donottrack.html fails to run on Apple test bots.
3421
3422         * DumpRenderTree/TestRunner.cpp:
3423         (TestRunner::TestRunner):
3424         (TestRunner::staticFunctions):
3425         * DumpRenderTree/TestRunner.h:
3426         (TestRunner):
3427         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3428         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3429         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3430         (WTR::InjectedBundlePage::InjectedBundlePage):
3431         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3432         (InjectedBundlePage):
3433         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3434         (WTR::TestRunner::TestRunner):
3435         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3436         (TestRunner):
3437
3438 2012-09-10  Christophe Dumez  <christophe.dumez@intel.com>
3439
3440         TestExpectationsChecker._determine_port_from_expectations_path() does not support cascaded TestExpectations
3441         https://bugs.webkit.org/show_bug.cgi?id=96205
3442
3443         Reviewed by Tony Chang.
3444
3445         _determine_port_from_expectations_path() was calling port.path_to_test_expectations_file()
3446         internally, which means that it would support only 1 TestExpectations file per port. This
3447         is an issue for ports such as EFL that support cascased TestExpectations (efl-wk2 -> efl
3448         and efl-wk1 -> efl).
3449
3450         This patch makes _determine_port_from_expectations_path() call port.expectations_files()
3451         instead so that all the ports TestExpectations are recognized. The ports are also
3452         constructed twice, with "webkit_test_runner" option set to True and False so that we
3453         retrieve the TestExpectations paths for both WebKit1 and WebKit2.
3454
3455         * Scripts/webkitpy/style/checkers/test_expectations.py:
3456         (TestExpectationsChecker._determine_port_from_expectations_path):
3457         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py: Add corresponding unit test.
3458         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
3459
3460 2012-09-10  Ryuan Choi  <ryuan.choi@samsung.com>
3461
3462         [WTR] Generated source files should include config.h
3463         https://bugs.webkit.org/show_bug.cgi?id=96254
3464
3465         Reviewed by Benjamin Poulain.
3466
3467         Current coding style has encouraged to include config.h at the first position,
3468         But derived sources, generated by CodeGeneratorTestRunner.pm, don't follow
3469         this rule.
3470         Therefore, this patch added it.
3471
3472         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
3473         (_generateImplementationFile):
3474
3475 2012-09-10  Rick Byers  <rbyers@chromium.org>
3476
3477         Add handling of new GestureTapCancel in DRT
3478         
3479         https://bugs.webkit.org/show_bug.cgi?id=96183
3480
3481         Reviewed by Adam Barth.
3482
3483         * DumpRenderTree/chromium/TestWebPlugin.cpp:
3484         (TestWebPlugin::handleInputEvent):
3485
3486 2012-09-10  Brady Eidson  <beidson@apple.com>
3487
3488         Javascript in foreground tabs should not wait synchronously for plug-ins to load
3489         <rdar://problem/12067415> and https://bugs.webkit.org/show_bug.cgi?id=96167
3490
3491         Reviewed by Geoff Garen.
3492
3493         Enhance the "Slow NPP_New" plug-in to also be able to return properties to javascript.
3494
3495         * DumpRenderTree/TestNetscapePlugIn/Tests/SlowNPPNew.cpp:
3496         (PluginObject):
3497         (SlowNPPNew::PluginObject::PluginObject):
3498         (SlowNPPNew::PluginObject::~PluginObject):
3499         (SlowNPPNew::PluginObject::hasProperty):
3500         (SlowNPPNew::PluginObject::getProperty):
3501         (SlowNPPNew::NPP_GetValue):
3502         (SlowNPPNew):
3503
3504 2012-09-10  Tim Horton  <timothy_horton@apple.com>
3505
3506         WKTR often reports an unresponsive WebProcess on Mac bots
3507         https://bugs.webkit.org/show_bug.cgi?id=95906
3508
3509         Reviewed by Dan Bernstein.
3510
3511         Attempt to work around resource contention issues by increasing the NRWT
3512         timeout when running against WKTR, as well as WKTR's own WebProcess timeout.
3513
3514         * Scripts/webkitpy/layout_tests/port/base.py:
3515         (Port.default_timeout_ms): Default timeout when using WKTR -> 80 seconds.
3516         * WebKitTestRunner/TestController.cpp:
3517         (WTR): LongTimeout (used when waiting for WebProcess to finish) -> 60 seconds.
3518
3519 2012-09-07  Jer Noble  <jer.noble@apple.com>
3520
3521         <audio> and <video> should send Do Not Track when appropriate
3522         https://bugs.webkit.org/show_bug.cgi?id=96134
3523
3524         Reviewed by Eric Carlson.
3525
3526         Add a testRunner JS API for calling setShouldSendDoNotTrackHTTPHeader to DRT and 
3527         WTR. Add FrameLoaderClient client methods for retrieving that value.
3528
3529         * DumpRenderTree/TestRunner.cpp:
3530         (setShouldSendDoNotTrackHTTPHeaderCallback): Pass through to the TestRunner.
3531         (TestRunner::staticFunctions): Add the setShouldSendDoNotTrackHTTPHeader function.
3532         * DumpRenderTree/TestRunner.h:
3533         (TestRunner::setShouldSendDoNotTrackHTTPHeader): Simple setter.
3534         (TestRunner::shouldSendDoNotTrackHTTPHeader): Simple getter.
3535         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3536         (-[FrameLoadDelegate webViewShouldSendDoNotTrackHTTPHeader:]): 
3537             Pass the question on to the TestRunner.
3538         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3539         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3540         (WTR::InjectedBundlePage::InjectedBundlePage):
3541             Add the setShouldSendDoNotTrackHTTPHeader client function.
3542         (WTR::InjectedBundlePage::shouldSendDoNotTrackHTTPHeader):
3543             Pass the question on to the TestRunner.
3544         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3545         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3546         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3547         (WTR::TestRunner::shouldSendDoNotTrackHTTPHeader): Simple getter.
3548         (WTR::TestRunner::setShouldSendDoNotTrackHTTPHeader): Simple Setter.
3549
3550 2012-09-10  Ojan Vafai  <ojan@chromium.org>
3551
3552         Make EFL bots work on the flakiness dashboard
3553         https://bugs.webkit.org/show_bug.cgi?id=96164
3554
3555         Reviewed by Tony Chang.
3556
3557         Also, update outdated unittests that had started failing.
3558
3559         * TestResultServer/static-dashboards/builders.js:
3560         (isWebkitTestRunner):
3561         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3562         (nonChromiumPlatform):
3563         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3564         (test):
3565
3566 2012-09-10  Tommy Widenflycht  <tommyw@google.com>
3567
3568         [chromium] MediaStream API: Remove the Descriptor postfix
3569         https://bugs.webkit.org/show_bug.cgi?id=96268
3570
3571         Reviewed by Adam Barth.
3572
3573         After consideration I realized that there is no need whatsoever in using the Descriptor prefix
3574         in the WekKit embedder API. Removed from WebRTCSessionDescription and WebRTCICECandidate to start with.
3575
3576         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
3577         (RTCSessionDescriptionRequestSuccededTask::RTCSessionDescriptionRequestSuccededTask):
3578         (MockWebRTCPeerConnectionHandler::createOffer):
3579         (MockWebRTCPeerConnectionHandler::createAnswer):
3580         (MockWebRTCPeerConnectionHandler::setLocalDescription):
3581         (MockWebRTCPeerConnectionHandler::setRemoteDescription):
3582         (MockWebRTCPeerConnectionHandler::localDescription):
3583         (MockWebRTCPeerConnectionHandler::remoteDescription):
3584         (MockWebRTCPeerConnectionHandler::addICECandidate):
3585         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
3586         (MockWebRTCPeerConnectionHandler):
3587
3588 2012-09-10  Arnaud Renevier  <a.renevier@sisa.samsung.com>
3589
3590         [Gtk] failure to build jhbuild dependencies with cups 1.6
3591         https://bugs.webkit.org/show_bug.cgi?id=95991
3592
3593         Reviewed by Gustavo Noronha Silva.
3594
3595         Bump gtk+ and gnome-themes-standard dependencies to 3.4.2 to allow
3596         building with cups >= 1.6 [GNOME #670373].
3597
3598         * gtk/jhbuild.modules:
3599
3600 2012-09-10  Christophe Dumez  <christophe.dumez@intel.com>
3601
3602         [EFL][DRT] Encoding issue in printed console messages
3603         https://bugs.webkit.org/show_bug.cgi?id=96263
3604
3605         Reviewed by Kenneth Rohde Christiansen.
3606
3607         Correctly handle CONSOLE messages that contain non-ascii
3608         characters in EFL's DRT. We need to use String::fromUTF8()
3609         to construct a WTF::String from a raw string.
3610
3611         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
3612         (onConsoleMessage):
3613
3614 2012-09-10  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3615
3616         [WK2][WTR] User style sheet location should be reset before each test
3617         https://bugs.webkit.org/show_bug.cgi?id=96262
3618
3619         Reviewed by Kenneth Rohde Christiansen.
3620
3621         User style sheet location is reset before each test now.
3622
3623         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3624         (WTR::InjectedBundle::beginTesting):
3625
3626 2012-09-10  Simon Hausmann  <simon.hausmann@nokia.com>
3627
3628         Fix build of WTR with Qt on Windows
3629         https://bugs.webkit.org/show_bug.cgi?id=96249
3630
3631         Reviewed by Kenneth Rohde Christiansen.
3632
3633         Windows loves to define min and max as macros, which beautifully
3634         clashes in many places where min and max are used as variable or method
3635         names. It can be convinced not to do this when min and max are already
3636         define as macros (expanding to themselves). We have this kind of
3637         workaround in config.h files all over WebKit and as it turns out when
3638         building WTR with Qt on Windows we do end up with such a clash. Therefore
3639         we need the same workaround.
3640
3641         * WebKitTestRunner/config.h:
3642
3643 2012-09-10  Christophe Dumez  <christophe.dumez@intel.com>
3644
3645         [WK2] New fast/forms/number/number-interactive-validation-required.html fails
3646         https://bugs.webkit.org/show_bug.cgi?id=95936
3647
3648         Reviewed by Kenneth Rohde Christiansen.
3649
3650         Enable interactive form validation setting in WebKitTestRunner as
3651         we are currently doing in DumpRenderTree. This is needed for some
3652         tests to pass.
3653
3654         * WebKitTestRunner/TestController.cpp:
3655         (WTR::TestController::resetStateToConsistentValues):
3656
3657 2012-09-09  Zan Dobersek  <zandobersek@gmail.com>
3658
3659         Clean up the code in XvfbDriver
3660         https://bugs.webkit.org/show_bug.cgi?id=96202
3661
3662         Reviewed by Philippe Normand.
3663
3664         Changes:
3665         - Remove unneeded imports,
3666         - assign the _lock_file member variable when the display number is determined,
3667         - no need for parentheses around a single string format argument,
3668         - use FileSystem.exists method when checking if lock file is present as it
3669         makes the intention much more clearer.
3670
3671         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
3672         (XvfbDriver._start):
3673         (XvfbDriver.stop):
3674
3675 2012-09-09  Patrick Gansterer  <paroga@webkit.org>
3676
3677         Make the String initialization on the function side of String::number()
3678         https://bugs.webkit.org/show_bug.cgi?id=95940
3679
3680         Reviewed by Benjamin Poulain.
3681
3682         * TestWebKitAPI/Tests/WTF/IntegerToStringConversion.cpp:
3683         (testBoundaries):
3684         (testNumbers):
3685
3686 2012-09-09  Pierre Rossi  <pierre.rossi@gmail.com>
3687
3688         [WK2] expose element rect for color input type
3689         https://bugs.webkit.org/show_bug.cgi?id=91664
3690
3691         Reviewed by Simon Hausmann.
3692
3693         Update the QML logic in MiniBrowser to take advantage of this.
3694         The picker size is now hardcoded and we try to place it below the
3695         input element if possible.
3696
3697         * MiniBrowser/qt/qml/ColorChooser.qml:
3698
3699 2012-09-08  Christophe Dumez  <christophe.dumez@intel.com>
3700
3701         [WK2] New fast/events/tab-focus-link-in-canvas fails from r126908
3702         https://bugs.webkit.org/show_bug.cgi?id=95329
3703
3704         Reviewed by Kenneth Rohde Christiansen.
3705
3706         Explicitely disable TabToLinks setting in WebKitTestRunner.
3707         Tests override the "WebKitTabToLinksPreferenceKey" preference
3708         to enable it.
3709
3710         * WebKitTestRunner/TestController.cpp:
3711         (WTR::TestController::resetStateToConsistentValues):
3712
3713 2012-09-08  Kenichi Ishibashi  <bashi@chromium.org>
3714
3715         webkit.py gdb pretty printer can't print CString
3716         https://bugs.webkit.org/show_bug.cgi?id=96068
3717
3718         Reviewed by Tony Chang.
3719
3720         Update WTFCStringPrinter to follow r126191.
3721
3722         * gdb/webkit.py:
3723         (WTFCStringPrinter.to_string):
3724
3725 2012-09-07  Benjamin Poulain  <bpoulain@apple.com>
3726
3727         Rename the ustring() accessor to string()
3728         https://bugs.webkit.org/show_bug.cgi?id=95919
3729
3730         Reviewed by Geoffrey Garen.
3731
3732         Update EFL's DRT.
3733
3734         Fix some string conversion that have been made useless
3735         with recent changes.
3736
3737         * DumpRenderTree/efl/EventSender.cpp:
3738         (keyPadNameFromJSValue):
3739         (keyNameFromJSValue):
3740         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3741         (TestRunner::queueLoad):
3742         (TestRunner::addOriginAccessWhitelistEntry):
3743         (TestRunner::removeOriginAccessWhitelistEntry):
3744         (TestRunner::setUserStyleSheetLocation):
3745         (TestRunner::setValueForUser):
3746         (TestRunner::elementDoesAutoCompleteForElementWithId):
3747         (TestRunner::execCommand):
3748         (TestRunner::findString):
3749         (TestRunner::isCommandEnabled):
3750         (TestRunner::clearApplicationCacheForOrigin):
3751         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
3752         (TestRunner::pauseAnimationAtTimeOnElementWithId):
3753         (TestRunner::pauseTransitionAtTimeOnElementWithId):
3754         (toInt):
3755         (TestRunner::overridePreference):
3756         (TestRunner::addUserScript):
3757         (TestRunner::addUserStyleSheet):
3758         (TestRunner::evaluateInWebInspector):
3759         (TestRunner::evaluateScriptInIsolatedWorld):
3760         (TestRunner::setTextDirection):
3761         * DumpRenderTree/efl/WorkQueueItemEfl.cpp:
3762         (LoadItem::invoke):
3763         (LoadHTMLStringItem::invoke):
3764         (ScriptItem::invoke):
3765
3766 2012-09-06  Jeffrey Pfau  <jpfau@apple.com>
3767
3768         Extend third-party storage blocking API to optionally allow blocking all storage
3769         https://bugs.webkit.org/show_bug.cgi?id=95915
3770
3771         Reviewed by Brady Eidson.
3772
3773         Modified API test to use new revised API.
3774
3775         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
3776         (TestWebKitAPI::TEST):
3777
3778 2012-09-07  Dominic Mazzoni  <dmazzoni@google.com>
3779
3780         AX: WebCore accessibility roles should be cross-platform
3781         https://bugs.webkit.org/show_bug.cgi?id=94870
3782
3783         Reviewed by Chris Fleizach.
3784
3785         Add debug strings to Chromium for new accessibility roles.
3786
3787         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
3788         (roleToString):
3789
3790 2012-09-07  Dominic Mazzoni  <dmazzoni@google.com>
3791
3792         AX: Chromium needs access to canvasHasFallbackContent
3793         https://bugs.webkit.org/show_bug.cgi?id=96124
3794
3795         Reviewed by Chris Fleizach.
3796
3797         Distinguish between canvas roles with and without fallback
3798         content on Chromium.
3799
3800         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
3801         (getRole):
3802
3803 2012-09-07  Ojan Vafai  <ojan@chromium.org>
3804
3805         Handle non-existant TestExpectations files gracefully
3806         https://bugs.webkit.org/show_bug.cgi?id=96149
3807
3808         Reviewed by Eric Seidel.
3809
3810         Even when we get rid of Skipped files, we shouldn't have each port
3811         require a TestExpectations file for each platform if it doesn't
3812         need one.
3813
3814         * Scripts/webkitpy/layout_tests/port/base.py:
3815         (Port.expectations_dict):
3816         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3817         (PortTest.test_nonexistant_expectations):
3818
3819 2012-09-07  Tony Chang  <tony@chromium.org>
3820
3821         Regression: check-webkit-style no longer checks TestExpectations for syntax errors
3822         https://bugs.webkit.org/show_bug.cgi?id=96136
3823
3824         Reviewed by Ojan Vafai.
3825
3826         When we renamed the file to TestExpectations, it was no longer considered a text file so
3827         it was no longer being checked. Since then, test_expectations_overrides() has been removed
3828         from the port object, so I've removed that from the check. I'm not sure what it was
3829         supposed to do.
3830
3831         * Scripts/webkitpy/style/checker.py:
3832         (CheckerDispatcher._file_type): Mark TestExpectations as a text file.
3833         * Scripts/webkitpy/style/checkers/test_expectations.py:
3834         (TestExpectationsChecker.check_test_expectations): Remove overrides param.
3835         (TestExpectationsChecker.check): Remove overrides param.
3836         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
3837         (TestExpectationsTestCase.assert_lines_lint): Remove overrides param.
3838
3839 2012-09-07  Christophe Dumez  <christophe.dumez@intel.com>
3840
3841         [EFL] Use same default minimum logical font size in DRT and WTR
3842         https://bugs.webkit.org/show_bug.cgi?id=96116
3843
3844         Reviewed by Martin Robinson.
3845
3846         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3847         (DumpRenderTreeChrome::resetDefaultsToConsistentValues): Set minimum
3848         logical font size to 9 to match the value used in WTR.
3849         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3850         (WTR::InjectedBundle::beginTesting): Explicitly set the minimum
3851         logical font size to 9 (default value in WK2)
3852
3853 2012-09-07  Tommy Widenflycht  <tommyw@google.com>
3854
3855         MediaStream API: add RTCPeerConnection::createAnswer
3856         https://bugs.webkit.org/show_bug.cgi?id=96092
3857
3858         Reviewed by Adam Barth.
3859
3860         Expanding and enhancing MockWebRTCPeerConnectionHandler.
3861
3862         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
3863         (MockWebRTCPeerConnectionHandler::createOffer):
3864         (MockWebRTCPeerConnectionHandler::createAnswer):
3865         (MockWebRTCPeerConnectionHandler::setLocalDescription):
3866         (MockWebRTCPeerConnectionHandler::setRemoteDescription):
3867         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
3868         (MockWebRTCPeerConnectionHandler):
3869
3870 2012-09-07  Dean Jackson  <dino@apple.com>
3871
3872         Unreviewed changes to watchlist.
3873
3874         - Add new WebGL and Filters definitions
3875         - Add myself to OpenGL bugs
3876
3877         * Scripts/webkitpy/common/config/watchlist:
3878
3879 2012-09-07  Peter Beverloo  <peter@chromium.org>
3880
3881         Actually trigger the Android Tester
3882         https://bugs.webkit.org/show_bug.cgi?id=96118
3883
3884         Reviewed by Adam Barth.
3885
3886         * BuildSlaveSupport/build.webkit.org-config/config.json:
3887
3888 2012-09-07  Dominic Mazzoni <dmazzoni@google.com>
3889
3890         New time input needs accessibility
3891         https://bugs.webkit.org/show_bug.cgi?id=96032
3892
3893         Reviewed by Chris Fleizach.
3894
3895         Add support for valueDescription for testing.
3896
3897         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
3898         (getValueDescription):
3899         (AccessibilityUIElement::AccessibilityUIElement):
3900         (AccessibilityUIElement::valueDescriptionGetterCallback):
3901         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.h:
3902         (AccessibilityUIElement):
3903
3904 2012-09-07  Peter Beverloo  <peter@chromium.org>
3905
3906         Add the google-android-tests build slave to the master's config
3907         https://bugs.webkit.org/show_bug.cgi?id=96113
3908
3909         Reviewed by Csaba Osztrogonác.
3910
3911         * BuildSlaveSupport/build.webkit.org-config/config.json:
3912
3913 2012-09-07  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
3914
3915         [WK2] [EFL] Set theme for WebKit2 API test runner
3916         https://bugs.webkit.org/show_bug.cgi?id=96100
3917
3918         Reviewed by Kenneth Rohde Christiansen.
3919
3920         Set the theme generated by the build for the WebKit2 API test runner.
3921
3922         * TestWebKitAPI/PlatformEfl.cmake:
3923         * TestWebKitAPI/efl/PlatformWebView.cpp:
3924         (TestWebKitAPI::PlatformWebView::PlatformWebView):
3925
3926 2012-09-07  Csaba Osztrogonác  <ossy@webkit.org>
3927
3928         Unreviewed. Add Gábor Ballabás as contributor.
3929
3930         * Scripts/webkitpy/common/config/committers.py:
3931
3932 2012-09-07  Zoltan Arvai  <zarvai@inf.u-szeged.hu>
3933
3934         [Qt] Fix ROOT_BUILD_DIR on Windows MSVC build.
3935         https://bugs.webkit.org/show_bug.cgi?id=96078
3936
3937         Reviewed by Tor Arne Vestbø.
3938
3939         Correct JSC, DumpRenderTree, ImageDiff, QtTestBrowser binaries location by adding $$toSystemPath to ROOT_BUILD_DIR generation.
3940
3941         * qmake/mkspecs/features/default_pre.prf:
3942
3943 2012-09-07  Christophe Dumez  <christophe.dumez@intel.com>
3944
3945         [EFL] Add TestExpectations file for efl-wk1
3946         https://bugs.webkit.org/show_bug.cgi?id=96019
3947
3948         Reviewed by Gyuyoung Kim.
3949
3950         Update TestExpectations cascading for EFL port
3951         so that we use efl-wk1 -> efl search paths
3952         for WebKit1 EFL.
3953
3954         * Scripts/webkitpy/layout_tests/port/efl.py:
3955         (EflPort._search_paths):
3956
3957 2012-09-07  Zan Dobersek  <zandobersek@gmail.com>
3958
3959         [NRWT] XvfbDriver should stop the Xvfb more aggressively
3960         https://bugs.webkit.org/show_bug.cgi?id=95097
3961
3962         Reviewed by Dirk Pranke.
3963
3964         The Xvfb process is now killed when the XvfbDriver is stopping. Simply
3965         terminating the process does not always work as expected, leading to timeouts
3966         in run-webkit-tests on the buildbot. The lock file Xvfb creates is also removed
3967         as it's not removed by the killed Xvfb process.
3968
3969         Also included is a thorough unittest for XvfbDriver. Proper starting of the driver
3970         is tested in different circumstances - whether pixel tests are enabled or not,
3971         with an arbitrary worker number or with an Xorg process already running on the system.
3972         The stopping of the driver is tested by checking that the Xvfb process is truly killed
3973         and then set to None.
3974
3975         * BuildSlaveSupport/kill-old-processes:
3976         Kill any stale Xvfb processes at the start of the build cycle so no Xvfb
3977         is left running, potentially clogging up a display at a certain position.
3978         * Scripts/webkitpy/common/system/executive_mock.py:
3979         (MockExecutive.__init__):
3980         The _running_pids is now a dictionary with process names as keys and pids
3981         as values.
3982         (MockExecutive.check_running_pid):
3983         Check whether the passed-in pid is in the _running_pids dictionary's values.
3984         (MockExecutive):
3985         (MockExecutive.running_pids):
3986         This method returns the list of all the process pids of which the name passes
3987         through the process_name_filter.
3988         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
3989         Use the Executive object of the port's host to check for running pids and open
3990         new subprocesses or kill them throughout the class.
3991         (XvfbDriver._start):
3992         Use the _server_process_constructor to make testing the XvfbDriver possible. Also,
3993         start the server process after it's created.
3994         (XvfbDriver.stop):
3995         Now kills the Xvfb process instead of terminating it and waiting for it to close.
3996         * Scripts/webkitpy/layout_tests/port/xvfbdriver_unittest.py: Added.
3997         (XvfbDriverTest):
3998         (XvfbDriverTest.make_driver):
3999         (XvfbDriverTest.assertDriverStartSuccessful):
4000         (XvfbDriverTest.test_start_no_pixel_tests):
4001         (XvfbDriverTest.test_start_pixel_tests):
4002         (XvfbDriverTest.test_start_arbitrary_worker_number):
4003         (XvfbDriverTest.test_start_existing_xorg_process):
4004         (XvfbDriverTest.test_stop):
4005         (XvfbDriverTest.test_stop.FakeXvfbProcess):
4006
4007 2012-09-06  Peter Beverloo  <peter@chromium.org>
4008
4009         Introduce the Chromium Android Release (Tests) bot
4010         https://bugs.webkit.org/show_bug.cgi?id=95980
4011
4012         Reviewed by Adam Barth.
4013
4014         This adds the Chromium Android Release (Tests) bot to the WebKit waterfall,
4015         which will be running layout tests on actual Android devices. Right now,
4016         four Galaxy Nexus phones are attached.
4017
4018         * BuildSlaveSupport/build.webkit.org-config/config.json:
4019
4020 2012-09-06  James Robinson  <jamesr@chromium.org>
4021
4022         [chromium] Use WebCompositorSupport functions instead of WebCompositor statics
4023         https://bugs.webkit.org/show_bug.cgi?id=96007
4024
4025         Reviewed by Adrienne Walker.
4026
4027         Fixes initialization / settings code to use WebCompositorSupport.
4028
4029         * DumpRenderTree/chromium/DumpRenderTree.cpp:
4030         (main):
4031         * DumpRenderTree/chromium/TestShell.cpp:
4032         (TestShell::initialize):
4033         (TestShell::setPerTilePaintingEnabled):
4034
4035 2012-09-06  Christophe Dumez  <christophe.dumez@intel.com>
4036
4037         [EFL][WK2] Provide implementation for PlatformWebView::windowFrame()
4038         https://bugs.webkit.org/show_bug.cgi?id=95995
4039
4040         Reviewed by Kenneth Rohde Christiansen.
4041
4042         Provide proper implementation for PlatformWebView::windowFrame()
4043         in EFL's WebKitTestRunner.
4044
4045         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
4046         (WTR::PlatformWebView::windowFrame):
4047
4048 2012-09-06  Fady Samuel  <fsamuel@chromium.org>
4049
4050         Fix WTF.Lrint on 32-bit platforms
4051         https://bugs.webkit.org/show_bug.cgi?id=96003
4052
4053         Reviewed by Benjamin Poulain.
4054
4055         Fixed failing WTF.Lrint test on 32-bit platforms.
4056
4057         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
4058         (TestWebKitAPI::TEST):
4059
4060 2012-09-06  Tommy Widenflycht  <tommyw@google.com>
4061
4062         MediaStream API: Add the local and remote description functionality to RTCPeerConnection
4063         https://bugs.webkit.org/show_bug.cgi?id=95839
4064
4065         Reviewed by Adam Barth.
4066
4067         In addition to adding the new methods to MockWebRTCPeerConnectionHandler I cleaned
4068         up the task definitions a bit. There was no need to have them in the header file.
4069
4070         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
4071         (RTCSessionDescriptionRequestSuccededTask):
4072         (RTCSessionDescriptionRequestSuccededTask::RTCSessionDescriptionRequestSuccededTask):
4073         (RTCSessionDescriptionRequestFailedTask):
4074         (RTCSessionDescriptionRequestFailedTask::RTCSessionDescriptionRequestFailedTask):
4075         (RTCVoidRequestTask):
4076         (RTCVoidRequestTask::RTCVoidRequestTask):
4077         (MockWebRTCPeerConnectionHandler::createOffer):
4078         (MockWebRTCPeerConnectionHandler::setLocalDescription):
4079         (MockWebRTCPeerConnectionHandler::setRemoteDescription):
4080         (MockWebRTCPeerConnectionHandler::localDescription):
4081         (MockWebRTCPeerConnectionHandler::remoteDescription):
4082         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
4083         (MockWebRTCPeerConnectionHandler):
4084
4085 2012-09-06  Simon Hausmann  <simon.hausmann@nokia.com>
4086
4087         [Qt] Fix build on Mac OS X 10.6
4088         https://bugs.webkit.org/show_bug.cgi?id=95200
4089
4090         Reviewed by Tor Arne Vestbø.
4091
4092         The build on Mac OS X 10.6 is broken when using QuickTime. Enable it only for
4093         10.7 and newer.
4094
4095         * qmake/mkspecs/features/features.prf:
4096
4097 2012-09-06  Christophe Dumez  <christophe.dumez@intel.com>
4098
4099         [WKTR] addSelectionKey should be mapped to "Control" modifiers on other OSes than Mac
4100         https://bugs.webkit.org/show_bug.cgi?id=95973
4101
4102         Reviewed by Kenneth Rohde Christiansen.
4103
4104         Correctly map "addSelectionKey" to "Control" modifier
4105         in WKTR's EventSender on other OSes than Mac OS X,
4106         instead of mapping it to the "Meta" modifier.
4107
4108         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
4109         (WTR::parseModifier):
4110
4111 2012-09-06  Balazs Kelemen  <kbalazs@webkit.org>
4112
4113         [nrwt] Harden against empty stdout/stderr after stopping a crashed/timed out driver
4114         https://bugs.webkit.org/show_bug.cgi?id=95710
4115
4116         Reviewed by Dirk Pranke.
4117
4118         The stdout / stderr output can be None so make sure
4119         we won't raise an exception in this case.
4120
4121         * Scripts/webkitpy/layout_tests/port/driver.py:
4122         (Driver.run_test):
4123
4124 2012-09-06  Christophe Dumez  <christophe.dumez@intel.com>
4125
4126         [EFL] Sanitize URLs in EWebLauncher / Minibrowser
4127         https://bugs.webkit.org/show_bug.cgi?id=95849
4128
4129         Reviewed by Kenneth Rohde Christiansen.
4130
4131         Sanitize URLs passed by the user as program
4132         argument or typed in the URL bar in order to
4133         be more tolerant.
4134
4135         * EWebLauncher/CMakeLists.txt:
4136         * EWebLauncher/main.c:
4137         (main):
4138         * EWebLauncher/url_bar.c:
4139         (_url_bar_url_get_with_protocol):
4140         (on_urlbar_key_down):
4141         * EWebLauncher/url_utils.c: Added.
4142         (has_scheme):
4143         (url_from_user_input): Add utility function to construct a
4144         URL from user input.
4145         * EWebLauncher/url_utils.h: Added.
4146         * MiniBrowser/efl/CMakeLists.txt:
4147         * MiniBrowser/efl/main.c:
4148         (main):
4149
4150 2012-09-06  Simon Hausmann  <simon.hausmann@nokia.com>
4151
4152         [Qt] Various small Windows / MSVC build fixes
4153         https://bugs.webkit.org/show_bug.cgi?id=95934
4154
4155         Reviewed by Kenneth Rohde Christiansen.
4156
4157         setFocus takes a boolean as argument: Don't try to implicitly convert
4158         an enum to a boolean, MSVC doesn't like that. The intent here is to
4159         enable focus, so just pass true.
4160
4161         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
4162         (WTR::PlatformWebView::focus):
4163
4164 2012-09-06  Simon Hausmann  <simon.hausmann@nokia.com>
4165
4166         [Qt] Fix build with ANGLE on platforms that provide EGL/GLESv2
4167         https://bugs.webkit.org/show_bug.cgi?id=95965
4168
4169         Reviewed by Tor Arne Vestbø.
4170
4171         Add ANGLE as a static library module to the Qt WebKit build system.
4172
4173         * qmake/mkspecs/features/default_post.prf:
4174         * qmake/mkspecs/modules/angle.prf: Added.
4175
4176 2012-09-06  Andras Becsi  <andras.becsi@nokia.com>
4177
4178         [WK2] Make [Qt]ViewportHandler cross platform
4179         https://bugs.webkit.org/show_bug.cgi?id=91257
4180
4181         Reviewed by Kenneth Rohde Christiansen.
4182
4183         Remove initial scale from viewport info item since it is
4184         set to -1 after applied thus it does not hold any valuable
4185         information.
4186
4187         * MiniBrowser/qt/qml/ViewportInfoItem.qml:
4188
4189 2012-09-05  Tony Chang  <tony@chromium.org>
4190
4191         [chromium] Remove dependency on webkit_user_agent
4192         https://bugs.webkit.org/show_bug.cgi?id=95886
4193
4194         Reviewed by Adam Barth.
4195
4196         The code isn't used by DumpRenderTree.
4197
4198         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
4199
4200 2012-09-05  Rick Byers  <rbyers@chromium.org>
4201
4202         Update chromium DumpRenderTree for new WebGestureEvent fields
4203         https://bugs.webkit.org/show_bug.cgi?id=95573
4204
4205         Reviewed by James Robinson.
4206
4207         Update EventSender to write gesture details into the appropriate
4208         type-specific WebGestureEvent fields.
4209         * DumpRenderTree/chromium/TestRunner/EventSender.cpp:
4210         (EventSender::gestureEvent):
4211         (EventSender::gestureFlingStart):
4212
4213 2012-09-05  Dirk Pranke  <dpranke@chromium.org>
4214
4215         NRWT lies about the number of tests that it's skipping when used with --repeat-each
4216         https://bugs.webkit.org/show_bug.cgi?id=95789
4217
4218         Reviewed by Ojan Vafai.
4219
4220         Fix miscalculation in log message.
4221
4222         * Scripts/webkitpy/layout_tests/views/printing.py:
4223         (Printer.print_found):
4224
4225 2012-09-05  Kenichi Ishibashi  <bashi@chromium.org>
4226
4227         Unreviewed, rolling out r127612, r127660, and r127664.
4228         http://trac.webkit.org/changeset/127612
4229         http://trac.webkit.org/changeset/127660
4230         http://trac.webkit.org/changeset/127664
4231         https://bugs.webkit.org/show_bug.cgi?id=95920
4232
4233         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
4234         (MockWebRTCPeerConnectionHandler::SuccessCallbackTask::SuccessCallbackTask):
4235         (MockWebRTCPeerConnectionHandler::SuccessCallbackTask::runIfValid):
4236         (MockWebRTCPeerConnectionHandler::FailureCallbackTask::FailureCallbackTask):
4237         (MockWebRTCPeerConnectionHandler::FailureCallbackTask::runIfValid):
4238         (MockWebRTCPeerConnectionHandler::createOffer):
4239         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
4240         (MockWebRTCPeerConnectionHandler):
4241         (SuccessCallbackTask):
4242         (FailureCallbackTask):
4243
4244 2012-09-05  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
4245
4246         Ignore-metrics includes scroll offsets.
4247         https://bugs.webkit.org/show_bug.cgi?id=95845
4248
4249         Reviewed by Dirk Pranke.
4250
4251         Strip scroll-offsets the same way scroll-height and scroll-width is stripped.
4252
4253         * Scripts/old-run-webkit-tests:
4254         (stripMetrics):
4255         * Scripts/webkitpy/layout_tests/port/driver.py:
4256         (DriverOutput):
4257
4258 2012-09-05  Zan Dobersek  <zandobersek@gmail.com>
4259
4260         Unreviewed test fix.
4261
4262         Including a plugin source file into the build that was added in r127595.
4263
4264         * GNUmakefile.am:
4265
4266 2012-09-05  Tommy Widenflycht  <tommyw@google.com>
4267
4268         MediaStream API: Add the local and remote description functionality to RTCPeerConnection
4269         https://bugs.webkit.org/show_bug.cgi?id=95839
4270
4271         Reviewed by Adam Barth.
4272
4273         In addition to adding the new methods to MockWebRTCPeerConnectionHandler I cleaned
4274         up the task definitions a bit. There was no need to have them in the header file.
4275
4276         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
4277         (RTCSessionDescriptionRequestSuccededTask):
4278         (RTCSessionDescriptionRequestSuccededTask::RTCSessionDescriptionRequestSuccededTask):
4279         (RTCSessionDescriptionRequestFailedTask):
4280         (RTCSessionDescriptionRequestFailedTask::RTCSessionDescriptionRequestFailedTask):
4281         (RTCVoidRequestTask):
4282         (RTCVoidRequestTask::RTCVoidRequestTask):
4283         (MockWebRTCPeerConnectionHandler::createOffer):
4284         (MockWebRTCPeerConnectionHandler::setLocalDescription):
4285         (MockWebRTCPeerConnectionHandler::setRemoteDescription):
4286         (MockWebRTCPeerConnectionHandler::localDescription):
4287         (MockWebRTCPeerConnectionHandler::remoteDescription):
4288         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
4289         (MockWebRTCPeerConnectionHandler):
4290
4291 2012-09-05  Kangil Han  <kangil.han@samsung.com>
4292
4293         [EFL] Remove '+=' usage in String
4294         https://bugs.webkit.org/show_bug.cgi?id=95808
4295
4296         Reviewed by Benjamin Poulain.
4297
4298         Replaced use of String operator '+=' with StringBuilder.append*() in order to adopt efficient String concatenation.
4299
4300         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
4301         (descriptionSuitableForTestResult):
4302
4303 2012-09-05  Christophe Dumez  <christophe.dumez@intel.com>
4304
4305         [EFL][WK2] Provide implementation for TestRunner::pathToLocalResource()
4306         https://bugs.webkit.org/show_bug.cgi?id=95842
4307
4308         Reviewed by Kenneth Rohde Christiansen.
4309
4310         Provide proper implementation for TestRunner::pathToLocalResource()
4311         in EFL WKTR, identical to the one for DumpRenderTree.
4312
4313         Map /tmp to ${DUMPRENDERTREE_TEMP} environment variable and
4314         /tmp/LayoutTests to ${LOCAL_RESOURCE_ROOT} so that local resources
4315         are found my WebKitTestRunner.
4316
4317         * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp:
4318         (WTR::TestRunner::pathToLocalResource):
4319
4320 2012-09-05  Brady Eidson  <beidson@apple.com>
4321
4322         Frequent crashes in PluginView::scriptObject under runtimeObjectCustomGetOwnPropertySlot
4323         <rdar://problem/12142226> and https://bugs.webkit.org/show_bug.cgi?id=95026
4324
4325         Reviewed by Andy Estes.
4326
4327         Add a plug-in that always fails to initialize:
4328         * DumpRenderTree/TestNetscapePlugIn/Tests/NPPNewFails.cpp: Added.
4329         (NPPNewFails):
4330         (NPPNewFails::NPPNewFails):
4331         (NPPNewFails::NPP_New):
4332
4333         Add it to all the project files:
4334         * DumpRenderTree/DumpRenderTree.gypi:
4335         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4336         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
4337         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
4338         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
4339
4340 2012-09-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
4341
4342         [Qt] Fix makefile race condition between derived sources and target
4343