5e57aed234d2128c88fb361836f8dcd972cf4f16
[WebKit-https.git] / Tools / ChangeLog
1 2014-12-07  Csaba Osztrogonác  <ossy@webkit.org>
2
3         [EFL][jhbuild] Fix libsoup build with clang
4         https://bugs.webkit.org/show_bug.cgi?id=139088
5
6         Reviewed by Gyuyoung Kim.
7
8         * efl/jhbuild.modules:
9         * efl/patches/soup-clang-warning-fix1.patch: Added.
10         * efl/patches/soup-clang-warning-fix2.patch: Added.
11
12 2014-12-06  Alexey Proskuryakov  <ap@apple.com>
13
14         [Mac] DumpRenderTree sets storage directory incorrectly
15         https://bugs.webkit.org/show_bug.cgi?id=139347
16
17         Reviewed by Dan Bernstein.
18
19         * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
20         Don't use user defaults to pass per-instance paths, as user defaults are shared
21         across all instances.
22
23 2014-12-05  Chris Fleizach  <cfleizach@apple.com>
24
25         AX: I cannot activate links on the mobile version of news.google.com
26         https://bugs.webkit.org/show_bug.cgi?id=139330
27
28         Reviewed by Simon Fraser.
29
30         Implement press for iOS.
31
32         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
33         (AccessibilityUIElement::press):
34
35 2014-12-05  Daniel Bates  <dabates@apple.com>
36
37         [iOS] Query -[WAKWindow screenScale] instead of using WKGetScreenScaleFactor()
38         https://bugs.webkit.org/show_bug.cgi?id=139326
39
40         Reviewed by Anders Carlsson.
41
42         Ask the window for its screen scale factor instead of calling WKGetScreenScaleFactor()
43         to query the OS for it. This approach will ensure DumpRenderTree takes the snapshot
44         using the same scale factor as used in WebKit.
45
46         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
47         (createBitmapContextFromWebView):
48
49 2014-12-05  Anders Carlsson  <andersca@apple.com>
50
51         REGRESSION (r176677): All tests crash on Windows
52         https://bugs.webkit.org/show_bug.cgi?id=139321
53
54         Reviewed by Alexey Proskuryakov.
55
56         * DumpRenderTree/win/DumpRenderTree.cpp:
57         (runTest):
58         Don't call CFRelease on the url while we have an outstanding pointer to its string,
59         and use the right number of bytes when allocating the testURL buffer.
60
61 2014-12-05  Daniel Bates  <dabates@apple.com>
62
63         [iOS] DumpRenderTree produces many reference test mismatches
64         https://bugs.webkit.org/show_bug.cgi?id=139314
65
66         Reviewed by Simon Fraser.
67
68         Fixes an issue where the scale factor used to render the snapshot taken by
69         DumpRenderTree may differ from the device scale factor. In particular, the
70         scale factor used to render a snapshot of a test may differ from the scale
71         factor used to render the snapshot of its expected result.
72
73         Currently DumpRenderTree uses SPI, -[UIView newSnapshotForRect], on iOS to
74         snapshot the UIWebBrowserView. This SPI always render using a scale factor
75         of one when the backing store for the LegacyTileLayer objects were out-of-
76         date regardless of the device scale factor. Instead we should use UIImage
77         and CALayer API to perform the snapshot with respect to the device scale
78         factor.
79
80         Additionally write iOS pixel dump support logic in terms of existing
81         DumpRenderTree abstractions so as to support generating and comparing
82         pixel dump checksums as well as make the iOS code more consistent with
83         the logic used by other ports.
84
85         * DumpRenderTree/PixelDumpSupport.cpp:
86         (dumpWebViewAsPixelsAndCompareWithExpected): Removed !PLATFORM(IOS)-guard.
87         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
88         (BitmapContext::createFromUIImage): Added.
89         (BitmapContext::pixelData): Added.
90         (BitmapContext::BitmapContext): Added.
91         (computeMD5HashStringForBitmapContext): Added.
92         (dumpBitmap): Added.
93         (createBitmapContextFromWebView): Moved logic from dumpWebViewAsPixelsAndCompareWithExpected() to here.
94         (dumpWebViewAsPixelsAndCompareWithExpected): Deleted.
95
96 2014-12-05  Anders Carlsson  <andersca@apple.com>
97
98         Give all web pages a website data store
99         https://bugs.webkit.org/show_bug.cgi?id=139317
100
101         Reviewed by Tim Horton.
102
103         * MiniBrowser/mac/AppDelegate.m:
104         (-[BrowserAppDelegate newPrivateWindow:]):
105         Don't release the controller - it's implicitly retained by the window.
106
107 2014-12-05  Daniel Bates  <dabates@apple.com>
108
109         [iOS] DumpRenderTree fails to render every other test when pixel tests are on
110         https://bugs.webkit.org/show_bug.cgi?id=137581
111         <rdar://problem/18642906>
112
113         Reviewed by Simon Fraser.
114
115         Fixes an issue where the DumpRenderTree snapshot may reflect the rendered content
116         of the test that proceeded the currently running test.
117
118         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
119         (dumpWebViewAsPixelsAndCompareWithExpected): Ensure that UIKit has performed a layout
120         of the UIWebBrowserView view. Also, remove unnecessary call to -[UIWebDocumentView layoutTilesNow]
121         as -[UIWebDocumentView newSnapshotWithRect] will layout the tiles.
122
123 2014-12-05  Jer Noble  <jer.noble@apple.com>
124
125         [WTF] MediaTime should support round-tripping from and to doubles.
126         https://bugs.webkit.org/show_bug.cgi?id=139248
127
128         Reviewed by Eric Carlson.
129
130         Add API tests for new features of MediaTime. Update the LLDB python provider to correctly display
131         the MediaTimes after this change.
132
133         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
134         (WTF::operator<<):
135         (TestWebKitAPI::TEST):
136         * lldb/lldb_webkit.py:
137         (WTFMediaTime_SummaryProvider):
138         (WTFMediaTimeProvider.timeValueAsDouble):
139         (WTFMediaTimeProvider.isIndefinite):
140         (WTFMediaTimeProvider):
141         (WTFMediaTimeProvider.hasDoubleValue):
142
143 2014-12-05  Anders Carlsson  <andersca@apple.com>
144
145         Add a private browsing mode to MiniBrowser
146         https://bugs.webkit.org/show_bug.cgi?id=139308
147
148         Reviewed by Sam Weinig.
149
150         * MiniBrowser/mac/AppDelegate.m:
151         (defaultConfiguration):
152         (-[BrowserAppDelegate newWindow:]):
153         (-[BrowserAppDelegate newPrivateWindow:]):
154         * MiniBrowser/mac/MainMenu.xib:
155         * MiniBrowser/mac/WK2BrowserWindowController.h:
156         * MiniBrowser/mac/WK2BrowserWindowController.m:
157         (-[WK2BrowserWindowController awakeFromNib]):
158         (-[WK2BrowserWindowController initWithConfiguration:]):
159         (-[WK2BrowserWindowController dealloc]):
160         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
161
162 2014-12-04  Alexey Proskuryakov  <ap@apple.com>
163
164         Run http tests parallel
165         https://bugs.webkit.org/show_bug.cgi?id=138958
166
167         Reviewed by Daniel Bates.
168
169         Remove the concept of "locked shard". Now http tests are just like any other tests.
170         We start HTTP and WebSocket servers at the start if we need them, and terminate them
171         when done with all the tests (not when the last http test runs, which is unnecessarily
172         unpredictable).
173
174         This makes debug tests run in 8 minutes and 12 seconds on my Mac Pro. Without the
175         patch, they used to take over 15 minutes.
176
177         As part of the fix, we no longer pass the number of servers to Apache. I don't
178         think that these parameters did what we wanted them to do; Apache handles the load
179         just fine without them.
180
181         The change applies to all platforms. I fixed everything I could find on Mac, and
182         Ossy told me that he's been running http tests in parallel for a long time. If
183         there is increased instability for some ports, it will need to be fixed - there is
184         generally nothing special about http tests at this point, and most code is
185         cross-platform in WebKit2.
186
187         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
188         (LayoutTestRunner.__init__):
189         (LayoutTestRunner.run_tests):
190         (LayoutTestRunner.start_servers_with_lock):
191         (LayoutTestRunner._handle_started_test):
192         (Worker.handle):
193         (Sharder.__init__):
194         (Sharder.shard_tests):
195         (Sharder._shard_every_file):
196         (Sharder._shard_by_directory):
197         (LayoutTestRunner._handle_finished_test_list): Deleted.
198         (LayoutTestRunner._handle_finished_test_list.find): Deleted.
199         (Sharder._shard_in_two): Deleted.
200         (Sharder): Deleted.
201         (Sharder._resize_shards): Deleted.
202         (Sharder._resize_shards.divide_and_round_up): Deleted.
203         (Sharder._resize_shards.extract_and_flatten): Deleted.
204         (Sharder._resize_shards.split_at): Deleted.
205         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
206         (FakePrinter.print_workers_and_shards):
207         (LayoutTestRunnerTests.test_servers_started.start_http_server):
208         (LayoutTestRunnerTests.test_servers_started):
209         (SharderTests.get_shards):
210         (SharderTests.test_shard_by_dir):
211         (SharderTests.test_shard_every_file):
212         (SharderTests): Deleted.
213         (SharderTests.test_shard_in_two): Deleted.
214         (SharderTests.test_shard_in_two_has_no_locked_shards): Deleted.
215         (SharderTests.test_shard_in_two_has_no_unlocked_shards): Deleted.
216         (SharderTests.test_multiple_locked_shards): Deleted.
217         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
218         (ManagerTest.test_needs_servers.get_manager):
219         (ManagerTest.integration_test_needs_servers.get_manager):
220         (ManagerTest.test_look_for_new_crash_logs.get_manager):
221         (ManagerTest):
222         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
223         (_set_up_derived_options):
224         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
225         (RunTest.test_batch_size):
226         (RunTest.test_max_locked_shards): Deleted.
227         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
228         (LayoutTestApacheHttpd.__init__):
229         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
230         (TestLayoutTestApacheHttpd.test_start_cmd):
231         * Scripts/webkitpy/layout_tests/servers/http_server.py:
232         (Lighttpd.__init__):
233         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
234         (HttpServerBase.__init__):
235         * Scripts/webkitpy/layout_tests/views/printing.py:
236         (Printer.print_workers_and_shards):
237         * Scripts/webkitpy/port/base.py:
238         (Port.default_child_processes):
239         (Port.to.start_http_server):
240         (Port.default_max_locked_shards): Deleted.
241         * Scripts/webkitpy/port/port_testcase.py:
242         (PortTestCase.make_port):
243         (PortTestCase.test_default_max_locked_shards): Deleted.
244         * Scripts/webkitpy/port/test.py:
245         (TestPort.start_http_server):
246
247 2014-12-04  Alexey Proskuryakov  <ap@apple.com>
248
249         Don't lock perf tests in run-webkit-tests
250         https://bugs.webkit.org/show_bug.cgi?id=139264
251
252         Reviewed by Daniel Bates.
253
254         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
255         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
256         * Scripts/webkitpy/layout_tests/controllers/manager.py:
257         * Scripts/webkitpy/layout_tests/models/test_input.py:
258         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
259
260 2014-12-03  Alexey Proskuryakov  <ap@apple.com>
261
262         http/tests/security/mixedContent/about-blank-iframe-in-main-frame.html fails unless certain other tests run before it
263         https://bugs.webkit.org/show_bug.cgi?id=139243
264
265         Reviewed by Anders Carlsson.
266
267         We didn't get WKPageLoaderClient calls in secondary windows, so we didn't have a
268         chance to allow untrusted certificates.
269
270         * WebKitTestRunner/TestController.cpp: (WTR::TestController::createOtherPage):
271         Set up more client objects for secondary windows. We may be able to share some of the
272         code with main view creation function, but it's not exactly the same (notably, we
273         do not focus a secondary window when it's done loading).
274
275 2014-12-03  Joanmarie Diggs  <jdiggs@igalia.com>
276
277         AX: [ATK] Inline text elements with accessible object attributes and/or event handlers are not exposed
278         https://bugs.webkit.org/show_bug.cgi?id=139071
279
280         Reviewed by Chris Fleizach.
281
282         Add string value for ATK_ROLE_STATIC in roleToString.
283
284         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
285
286 2014-12-03  Renato Nagy  <rnagy@inf.u-szeged.hu>
287
288         check-webkit-style is confused by ternary expression inside first member initializer
289         https://bugs.webkit.org/show_bug.cgi?id=136442
290
291         Reviewed by Csaba Osztrogonác.
292
293         * Scripts/webkitpy/style/checkers/cpp.py:
294         (check_member_initialization_list):
295
296 2014-12-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
297
298         [GTK] [JHBuild] gst-plugins-bad fails to build if the GNUStep libraries are installed.
299         https://bugs.webkit.org/show_bug.cgi?id=139220
300
301         Reviewed by Philippe Normand.
302
303         * gtk/jhbuild.modules:
304         * gtk/patches/gst-plugins-bad-remove-gnustep-support.patch: Added.
305
306 2014-12-03  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
307
308         Remove unused JSC runtime options
309         https://bugs.webkit.org/show_bug.cgi?id=133070
310
311         Reviewed by Csaba Osztrogonác.
312
313         * Scripts/run-jsc-stress-tests:
314
315 2014-12-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
316
317         [EFL] Add subtle crypto to the build system
318         https://bugs.webkit.org/show_bug.cgi?id=138612
319
320         Reviewed by Csaba Osztrogonác.
321
322         * Scripts/webkitperl/FeatureList.pm:
323
324 2014-12-02  Joanmarie Diggs  <jdiggs@igalia.com>
325
326         AX: [ATK] Table captions and table rows are missing from the accessible hierarchy
327         https://bugs.webkit.org/show_bug.cgi?id=139005
328
329         Reviewed by Chris Fleizach.
330
331         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
332         Add mapping for ATK_ROLE_CAPTION to roleToString
333
334 2014-12-02  Alexey Proskuryakov  <ap@apple.com>
335
336         http/tests/appcache/main-resource-fallback-for-network-error-crash.html can break subsequent tests
337         https://bugs.webkit.org/show_bug.cgi?id=139149
338
339         Reviewed by Anders Carlsson.
340
341         WebKit2 already cleared application caches between runs (although it wasn't entirely
342         effective without WebCore changes in this patch).
343
344         * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Clear applicaiton caches between runs.
345
346         * DumpRenderTree/win/DumpRenderTree.cpp: (runTest): Ditto (unfortunately, this
347         function is not implemented on Windows, see below).
348
349         * DumpRenderTree/win/TestRunnerWin.cpp: (TestRunner::clearAllApplicationCaches):
350         Ameded a FIXME.
351
352 2014-12-02  Gavin Barraclough  <barraclough@apple.com>
353
354         Generalize PageActivityAssertionToken
355         https://bugs.webkit.org/show_bug.cgi?id=139106
356
357         Reviewed by Sam Weinig.
358
359         Add an API test for WTF::RefCounter.
360
361         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
362         * TestWebKitAPI/Tests/WTF/RefCounter.cpp: Added.
363         (TestWebKitAPI::TEST):
364             - added RefCounter test.
365
366 2014-12-02  Alexey Proskuryakov  <ap@apple.com>
367
368         [Mac, iOS] Crash log application information contains latest main frame URL instead of test URL
369         https://bugs.webkit.org/show_bug.cgi?id=139174
370
371         Reviewed by Simon Fraser.
372
373         * DumpRenderTree/TestRunner.cpp:
374         * DumpRenderTree/TestRunner.h:
375         Renamed testPathOrURL to testURL, because this variable always contains a URL.
376
377         * DumpRenderTree/mac/DumpRenderTree.mm:
378         (sizeWebViewForCurrentTest): Updated for testPathOrURL renaming.
379         (testPathFromURL): Moved from FrameLoadDelegate.mm.
380         (runTest): Set crash reporter information here, as we know the exact test URL.
381
382         * DumpRenderTree/mac/FrameLoadDelegate.mm:
383         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]): Don't set crash
384         reporter information here.
385
386         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
387         * DumpRenderTree/mac/TestRunnerMac.mm:
388         Updated for testPathOrURL renaming.
389
390         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
391         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame): WebProcess doesn't know
392         test URL until load starts, so save it into TestRunner now. A new TestRunner object
393         is created for each test.
394
395         * WebKitTestRunner/InjectedBundle/TestRunner.h:
396         (WTR::TestRunner::testURL):
397         (WTR::TestRunner::setTestURL):
398         Make TestRunner know the test name. For now, it's good enough to have it once load
399         starts, but if we ever need it earlier, we can send it with BeginTest message.
400
401         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
402         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame):
403         Use test URL, not currently loading URL for CrashReporter.
404
405         * WebKitTestRunner/cocoa/CrashReporterInfo.mm:
406         (WTR::setCrashReportApplicationSpecificInformationToURL): Added a space after colon
407         (WebKit1 already had it right).
408
409         * DumpRenderTree/win/DumpRenderTree.cpp:
410         (sizeWebViewForCurrentTest):
411         (runTest):
412         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
413         (ResourceLoadDelegate::willSendRequest):
414         Changed Windows DumpRenderTree to also use URL in TestRunner.
415
416 2014-12-02  Daniel Bates  <dabates@apple.com>
417
418         [iOS] run-webkit-tests records most DumpRenderTree.app crashes as time-outs
419         https://bugs.webkit.org/show_bug.cgi?id=139143
420
421         Reviewed by David Kilzer.
422
423         Similar to the Windows-specific fix in <https://bugs.webkit.org/show_bug.cgi?id=37859>,
424         teach DumpRenderTree for iOS to write "#CRASHED" to the standard error stream when it
425         crashes. Run-webkit-tests will record as crashing the test associated with the
426         DumpRenderTree instance that wrote that string.
427
428         Currently almost all of the DumpRenderTree.app crashes are recorded by run-
429         webkit-tests as a time-out because ReportCrash(8) delays delivery of the
430         process exit notification for DumpRenderTree.app to LayoutTestRelay, which
431         launched DumpRenderTree.app, past the time-out time limit. Notice LayoutTestRelay
432         was launched by run-webkit-tests. So, run-webkit-tests kills LayoutTestRelay
433         (since it exceeded the time-out time limit) before it can inform rub-webkit-tests
434         about a crash.
435
436         Additionally, update the crash message format written to standard error when LayoutTestRelay
437         detects that {WebKitTestRunner, DumpRenderTree}.app crashed so as to be similar to the
438         crash message format used by WebKitTestRunner when it detects that the WebProcess crashed.
439         Then run-webkit-tests will collect the crash logs for {WebKitTestRunner, DumpRenderTree}.app
440         when they crash in their test machinery logic/UI process code.
441
442         * DumpRenderTree/mac/DumpRenderTree.mm:
443         (writeCrashedMessageOnFatalError): Added.
444         (dumpRenderTree): Register signal handler, writeCrashedMessageOnFatalError(), for signals:
445         SIGILL, SIGFPE, SIGBUS and SIGSEGV.
446         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
447         (-[LTRelayController didCrashWithMessage:]): Emit a crash message with a format
448         similar to the format used by WebKitTestRunner so that run-webkit-tests will collect
449         the crash logs for WebKitTestRunner/DumpRenderTree.app.
450         * Scripts/webkitpy/port/driver.py:
451         (Driver.__init__): Update comment.
452         (Driver._check_for_driver_crash): Ditto.
453         * Scripts/webkitpy/port/ios.py:
454         (IOSSimulatorPort): Add class constant SUBPROCESS_CRASH_REGEX, which represents a compiled
455         regular expression. This constant is used as an optimization to avoid compiling the same
456         regular expression across invocations of _get_crash_log().
457         (IOSSimulatorPort._get_crash_log): Modified to parse the WebKitTestRunner-like crash message
458         for the subprocess name and pid. Also, moved variables crash_log, crash_logs, and now to be
459         closer to where they are used.
460
461 2014-12-01  Anders Carlsson  <andersca@apple.com>
462
463         Remove WKBundleRemoveAllVisitedLinks
464         https://bugs.webkit.org/show_bug.cgi?id=139163
465
466         Reviewed by Sam Weinig.
467
468         Remove the call to WKBundleRemoveAllVisitedLinks and add a FIXME instead.
469
470         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
471         (WTR::InjectedBundle::beginTesting):
472         * WebKitTestRunner/TestInvocation.cpp:
473         (WTR::TestInvocation::invoke):
474
475 2014-12-02  Anders Carlsson  <andersca@apple.com>
476
477         Fix Windows build.
478
479         * DumpRenderTree/win/DumpRenderTree.cpp:
480         (setAlwaysAcceptCookies):
481
482 2014-12-02  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
483
484         [EFL] Remove edbus dependency from jhbuild
485         https://bugs.webkit.org/show_bug.cgi?id=139130
486
487         Reviewed by Gyuyoung Kim.
488
489         After http://trac.webkit.org/changeset/176555 we
490         don't need it anymore.
491
492         * efl/jhbuild.modules:
493
494 2014-12-02  Philippe Normand  <pnormand@igalia.com>
495
496         [jhbuild] wrong Dependencies path
497         https://bugs.webkit.org/show_bug.cgi?id=139176
498
499         Reviewed by Martin Robinson.
500
501         * Scripts/webkitpy/port/base.py:
502         (Port._should_use_jhbuild):
503
504 2014-12-02  Philippe Normand  <pnormand@igalia.com>
505
506         [GStreamer] Bump internal jhbuild versions to 1.4.4
507         https://bugs.webkit.org/show_bug.cgi?id=138866
508
509         Reviewed by Carlos Garcia Campos.
510
511         * gtk/jhbuild.modules:
512         * gtk/patches/gst-events-arent-gstobjects.patch: Removed.
513         * gtk/patches/gst-plugins-base-fix-build-gcc-4.9-x86.patch: Removed.
514         * gtk/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch: Removed.
515
516 2014-12-01  Commit Queue  <commit-queue@webkit.org>
517
518         Unreviewed, rolling out r176566.
519         https://bugs.webkit.org/show_bug.cgi?id=139124
520
521         It broke the GTK performance tests. (Requested by clopez on
522         #webkit).
523
524         Reverted changeset:
525
526         "[GTK] Use GMainLoopSource in WebKitTestRunner"
527         https://bugs.webkit.org/show_bug.cgi?id=138831
528         http://trac.webkit.org/changeset/176566
529
530 2014-11-29  Anders Carlsson  <andersca@apple.com>
531
532         Crash when calling WKPageClose on the originated page from within createNewPage callback
533         https://bugs.webkit.org/show_bug.cgi?id=139099
534         <rdar://problem/19052564>
535
536         Reviewed by Sam Weinig.
537
538         Add a test.
539
540         * TestWebKitAPI/PlatformWebView.h:
541         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
542         * TestWebKitAPI/Tests/WebKit2/CloseFromWithinCreatePage.cpp: Added.
543         (TestWebKitAPI::runJavaScriptAlert):
544         (TestWebKitAPI::createNewPage):
545         (TestWebKitAPI::TEST):
546         * TestWebKitAPI/Tests/WebKit2/close-from-within-create-page.html: Added.
547         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
548         (TestWebKitAPI::PlatformWebView::PlatformWebView):
549
550 2014-11-28  Commit Queue  <commit-queue@webkit.org>
551
552         Unreviewed, rolling out r176564.
553         https://bugs.webkit.org/show_bug.cgi?id=139093
554
555         massive failures on release test bot (Requested by philn on
556         #webkit).
557
558         Reverted changeset:
559
560         "[GStreamer] Bump internal jhbuild versions to 1.4.4"
561         https://bugs.webkit.org/show_bug.cgi?id=138866
562         http://trac.webkit.org/changeset/176564
563
564 2014-11-28  Carlos Garcia Campos  <cgarcia@igalia.com>
565
566         [GTK] Use GMainLoopSource in WebKitTestRunner
567         https://bugs.webkit.org/show_bug.cgi?id=138831
568
569         Reviewed by Sergio Villar Senin.
570
571         * WebKitTestRunner/InjectedBundle/TestRunner.h:
572         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
573         (WTR::TestRunner::platformInitialize):
574         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
575         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
576         (WTR::waitToDumpWatchdogTimerCallback): Deleted.
577         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
578         (WTR::TestController::notifyDone):
579         (WTR::TestController::platformRunUntil):
580         (WTR::cancelTimeout): Deleted.
581
582 2014-11-24  Philippe Normand  <pnormand@igalia.com>
583
584         [GStreamer] Bump internal jhbuild versions to 1.4.4
585         https://bugs.webkit.org/show_bug.cgi?id=138866
586
587         Reviewed by Carlos Garcia Campos.
588
589         * gtk/jhbuild.modules:
590         * gtk/patches/gst-events-arent-gstobjects.patch: Removed.
591         * gtk/patches/gst-plugins-base-fix-build-gcc-4.9-x86.patch: Removed.
592         * gtk/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch: Removed.
593
594 2014-11-28  Carlos Garcia Campos  <cgarcia@igalia.com>
595
596         [GTK] Use custom JavaScript instead of DBus to implement WebProcess tests
597         https://bugs.webkit.org/show_bug.cgi?id=138834
598
599         Reviewed by Sergio Villar Senin.
600
601         It makes everyting simpler and the tests run faster too, since we
602         don't need to spawn the private bus and wait until the DBus name
603         is registered. The web extension registers a new JavaSCript class
604         with a status method to run the tests, similar to the DBus
605         method. In the UI process side, tests use webkit_web_view_run_java_script()
606         instead of sending a DBus message.
607
608         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
609         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeFilterTest.cpp:
610         (WebKitDOMNodeFilterTest::create):
611         (WebKitDOMNodeFilterTest::testTreeWalker):
612         (WebKitDOMNodeFilterTest::testNodeIterator):
613         (WebKitDOMNodeFilterTest::webPageFromArgs): Deleted.
614         (WebKitDOMNodeFilterTest::runTest): Deleted.
615         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
616         (WebKitDOMNodeTest::create):
617         (WebKitDOMNodeTest::testHierarchyNavigation):
618         (WebKitDOMNodeTest::testInsertion):
619         (WebKitDOMNodeTest::testTagNames):
620         (WebKitDOMNodeTest::webPageFromArgs): Deleted.
621         (WebKitDOMNodeTest::runTest): Deleted.
622         * TestWebKitAPI/Tests/WebKit2Gtk/DOMXPathNSResolverTest.cpp:
623         (WebKitDOMXPathNSResolverTest::create):
624         (WebKitDOMXPathNSResolverTest::testXPathNSResolverNative):
625         (WebKitDOMXPathNSResolverTest::testXPathNSResolverCustom):
626         (WebKitDOMXPathNSResolverTest::webPageFromArgs): Deleted.
627         (WebKitDOMXPathNSResolverTest::runTest): Deleted.
628         * TestWebKitAPI/Tests/WebKit2Gtk/FrameTest.cpp:
629         (WebKitFrameTest::create):
630         (WebKitFrameTest::testMainFrame):
631         (WebKitFrameTest::testURI):
632         (WebKitFrameTest::testJavaScriptContext):
633         (WebKitFrameTest::webPageFromArgs): Deleted.
634         (WebKitFrameTest::runTest): Deleted.
635         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
636         (testWebKitDOMNodeHierarchyNavigation):
637         (testWebKitDOMNodeInsertion):
638         (testWebKitDOMNodeTagNames):
639         (beforeAll):
640         (afterAll):
641         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNodeFilter.cpp:
642         (runTest):
643         (beforeAll):
644         (afterAll):
645         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMXPathNSResolver.cpp:
646         (testWebKitDOMXPathNSResolverNative):
647         (testWebKitDOMXPathNSResolverCustom):
648         (beforeAll):
649         (afterAll):
650         (runTest): Deleted.
651         * TestWebKitAPI/Tests/WebKit2Gtk/TestFrame.cpp:
652         (webkitFrameTestRun):
653         (beforeAll):
654         (afterAll):
655         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
656         (testsMap):
657         (WebProcessTest::add):
658         (WebProcessTest::create):
659         (runTest):
660         (windowObjectClearedCallback):
661         (webkit_web_extension_initialize):
662         (methodCallCallback): Deleted.
663         (webkit_web_extension_initialize_with_user_data): Deleted.
664         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h:
665         * TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.cpp: Removed.
666         * TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.h: Removed.
667         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
668         (WebViewTest::runWebProcessTest):
669         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
670
671 2014-11-28  Csaba Osztrogonác  <ossy@webkit.org>
672
673         [EFL] libseccomp should pick up CC environment variable to be conform to other jhbuild modules
674         https://bugs.webkit.org/show_bug.cgi?id=139086
675
676         Reviewed by Gyuyoung Kim.
677
678         * efl/jhbuild.modules:
679         * efl/patches/libseccomp-pick-up-CC.patch: Added.
680
681 2014-11-28  Bartlomiej Gajda  <b.gajda@samsung.com>
682
683         [EFL] Add warning if CMake version is too old for building with ninja.
684         https://bugs.webkit.org/show_bug.cgi?id=139055
685
686         Reviewed by Gyuyoung Kim.
687
688         CMake need to be >= 2.8.10 to build WebKit using ninja, some repos don't have
689         that version in their repositories.
690
691         * efl/install-dependencies:
692
693 2014-11-28  Andrzej Badowski  <a.badowski@samsung.com>
694
695         [ATK] Allowing the use of AccessibilityUIElement::columnHeaders method for table.
696         https://bugs.webkit.org/show_bug.cgi?id=139044
697
698         Reviewed by Chris Fleizach.
699
700         ATK method AccessibilityUIElement::columnHeaders currently focused only on the object table cell.
701         The proposed solution will enable the use of this method for the object table.
702         Existing test shows the result.
703
704         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
705         (WTR::AccessibilityUIElement::columnHeaders):
706
707 2014-11-27  Ryuan Choi  <ryuan.choi@navercorp.com>
708
709         [EFL] Remove E_Dbus dependency
710         https://bugs.webkit.org/show_bug.cgi?id=136355
711
712         Reviewed by Gyuyoung Kim.
713
714         * MiniBrowser/efl/CMakeLists.txt: Removed E_DBUS includes.
715
716 2014-11-26  Akos Kiss  <akiss@inf.u-szeged.hu>
717
718         [EFL][GTK] Bump up FDE relocation fixing patch to version accepted to LLVM trunk.
719         https://bugs.webkit.org/show_bug.cgi?id=139047
720
721         Reviewed by Carlos Garcia Campos.
722
723         * efl/jhbuild.modules:
724         * efl/patches/llvm-elf-allow-fde-references-outside-the-2gb-range.patch: Added.
725         * efl/patches/llvm-elf-fix-x86_64-fdecfiencoding.patch: Removed.
726         * gtk/jhbuild-optional.modules:
727         * gtk/patches/llvm-elf-allow-fde-references-outside-the-2gb-range.patch: Added.
728         * gtk/patches/llvm-elf-fix-x86_64-fdecfiencoding.patch: Removed.
729
730 2014-11-25  Tanay C  <tanay.c@samsung.com>
731
732         [GTK] Minibrowser: Add support for zoom using Control Key + Mouse scroll
733         https://bugs.webkit.org/show_bug.cgi?id=138090
734
735         Reviewed by Carlos Garcia Campos.
736
737         * MiniBrowser/gtk/BrowserWindow.c: Implementing zoom using Cntrl + Mouse scroll
738         (browserWindowZoomIn): Added.
739         (browserWindowZoomOut): Added.
740         (scrollEventCallback): Added.
741         (zoomInCallback): Modified.
742         (zoomOutCallback): Modified.
743         (browserWindowConstructed): Modified.
744
745 2014-11-25  Csaba Osztrogonác  <ossy@webkit.org>
746
747         [EFL] REGRESSION(r176514): It made performance tests fail
748         https://bugs.webkit.org/show_bug.cgi?id=139037
749
750         Reviewed by Gyuyoung Kim.
751
752         * Scripts/webkitpy/port/efl.py:
753         (EflPort.setup_environ_for_server): Pass ACCESSIBILITY_EAIL_LIBRARY_PATH environment variable to WTR.
754         * efl/jhbuildrc: Set ACCESSIBILITY_EAIL_LIBRARY_PATH to point to DependenciesEFL/lib/libeail.so
755         only if ACCESSIBILITY_EAIL_LIBRARY_PATH isn't already set and DependenciesEFL/lib/libeail.so exists.
756
757 2014-11-24  Michael Catanzaro  <mcatanzaro@igalia.com>
758
759         [GTK] update-webkitgtk-libs fails to build fontconfig
760         https://bugs.webkit.org/show_bug.cgi?id=139032
761
762         Reviewed by Martin Robinson.
763
764         On Fedora, if docbook-utils is installed but docbook-utils-pdf is not,
765         fontconfig will try to generate documentation and fail.
766
767         * gtk/install-dependencies:
768
769 2014-11-24  Carlos Garcia Campos  <cgarcia@igalia.com>
770
771         Unreviewed. Fix GTK+ make distcheck.
772
773         * gtk/manifest.txt: Remove deleted files.
774
775 2014-11-24  Krzysztof Czech  <k.czech@samsung.com>
776
777         [EFL] Utilize Eail library to support accessibility in EFL
778         https://bugs.webkit.org/show_bug.cgi?id=137742
779
780         Reviewed by Gyuyoung Kim.
781
782         Eail, atk-bridge, at-spi2 are not mandatory modules for webkit-efl. They are rather optional.
783
784         * efl/jhbuild-optional.modules: Added.
785         * efl/jhbuild.modules:
786
787 2014-11-24  Carlos Garcia Campos  <cgarcia@igalia.com>
788
789         [GTK] WebKitWebView is created with the wrong web context when using webkit_web_view_new_with_related_view()
790         https://bugs.webkit.org/show_bug.cgi?id=139023
791
792         Reviewed by Sergio Villar Senin.
793
794         Rename WebKitWebView/default-context as WebKitWebView/web-context
795         and check we are always using the right context for new web views.
796
797         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
798         (testWebViewWebContext):
799         (beforeAll):
800         (testWebViewDefaultContext): Deleted.
801
802 2014-11-23  Carlos Garcia Campos  <cgarcia@igalia.com>
803
804         [GTK] Add API to override the default local storage directory
805         https://bugs.webkit.org/show_bug.cgi?id=138828
806
807         Reviewed by Gustavo Noronha Silva.
808
809         Add test to check that the local storage directory is created at
810         the path given on construction.
811
812         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
813         (testWebContextConfiguration):
814         (beforeAll):
815         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
816         (Test::Test):
817         (Test::~Test): Deleted.
818
819 2014-11-21  Zalan Bujtas  <zalan@apple.com>
820
821         Simple line layout: Add "show simple line layout debug borders" setting to MiniBrowser.
822         https://bugs.webkit.org/show_bug.cgi?id=138981
823
824         Reviewed by Simon Fraser.
825
826         * MiniBrowser/mac/SettingsController.h:
827         * MiniBrowser/mac/SettingsController.m:
828         (-[SettingsController _populateMenu]):
829         (-[SettingsController validateMenuItem:]):
830         (-[SettingsController toggleSimpleLineLayoutDebugBordersEnabled:]):
831         (-[SettingsController simpleLineLayoutDebugBordersEnabled]):
832         * MiniBrowser/mac/WK1BrowserWindowController.m:
833         (-[WK1BrowserWindowController didChangeSettings]):
834         * MiniBrowser/mac/WK2BrowserWindowController.m:
835         (-[WK2BrowserWindowController didChangeSettings]):
836
837 2014-11-21  Csaba Osztrogonác  <ossy@webkit.org>
838
839         Remove http lock code from webkitperl
840         https://bugs.webkit.org/show_bug.cgi?id=138959
841
842         Reviewed by Alexey Proskuryakov.
843
844         * Scripts/webkitperl/httpd.pm:
845         (cleanUp):
846         (extractLockNumber): Deleted.
847         (getLockFiles): Deleted.
848         (getNextAvailableLockNumber): Deleted.
849         (getLockNumberForCurrentRunning): Deleted.
850         (waitForHTTPDLock): Deleted.
851         (scheduleHttpTesting): Deleted.
852         (getWaitTime): Deleted.
853
854 2014-11-20  Hunseop Jeong  <hs85.jeong@samsung.com>
855
856         [EFL] The option value of fixed layout is false in MiniBrowser
857         https://bugs.webkit.org/show_bug.cgi?id=138830
858
859         Reviewed by Gyuyoung Kim.
860
861         Changed the option value of fixed layout to EINA_TRUE in MiniBrowser.
862
863         * MiniBrowser/efl/main.c:
864
865 2014-11-20  Adrian Perez de Castro  <aperez@igalia.com>
866
867         [GTK] Provide convenience API in DOM bindings to post messages to user message handlers
868         https://bugs.webkit.org/show_bug.cgi?id=138871
869
870         Reviewed by Carlos Garcia Campos.
871
872         Add a test case for the convenience API for posting user messages
873         added to the DOM bindings.
874
875         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
876         (testUserContentManagerMessageFromConvenienceDOMBindings):
877         (beforeAll):
878         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
879         (documentLoadedCallback):
880
881 2014-11-19  Dana Burkart  <dburkart@apple.com>
882
883         Work around the fact that different masters may have different names for their codebases.
884         https://bugs.webkit.org/show_bug.cgi?id=138878
885
886         Reviewed by Mark Rowe.
887
888         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
889         (parseRevisionProperty): Changed.
890         Take a "fallback key" in addition to the primary key, so we can deal with inconsistencies in
891         opensource / internal codebase naming convention.
892
893 2014-11-19  Chris Fleizach  <cfleizach@apple.com>
894
895         AX: Screen braille input doesn't work on forms.
896         https://bugs.webkit.org/show_bug.cgi?id=138804
897
898         Unreviewed build fix.
899
900         * DumpRenderTree/AccessibilityUIElement.cpp:
901         (AccessibilityUIElement::setValue):
902
903 2014-11-19  Chris Fleizach  <cfleizach@apple.com>
904
905         AX: Screen braille input doesn't work on forms.
906         https://bugs.webkit.org/show_bug.cgi?id=138804
907
908         Reviewed by Mario Sanchez Prada.
909
910         Add a method to setValue through the AX API in DRT.
911
912         * DumpRenderTree/AccessibilityUIElement.cpp:
913         (setValueCallback):
914         (AccessibilityUIElement::getJSClass):
915         * DumpRenderTree/AccessibilityUIElement.h:
916         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
917         (AccessibilityUIElement::setValue):
918         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
919         (AccessibilityUIElement::setValue):
920
921 2014-11-18  Csaba Osztrogonác  <ossy@webkit.org>
922
923         Remove the WinCairo buildbot
924         https://bugs.webkit.org/show_bug.cgi?id=138805
925
926         Reviewed by Alex Christensen.
927
928         * BuildSlaveSupport/build.webkit.org-config/config.json:
929         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
930         (appendCustomBuildFlags):
931         * BuildSlaveSupport/test-result-archive:
932         (archiveTestResults):
933
934 2014-11-18  Daniel Bates  <dabates@apple.com>
935
936         [iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions, MobileGestalt
937         SPI are not available in public SDK
938         https://bugs.webkit.org/show_bug.cgi?id=138802
939
940         Reviewed by David Kilzer.
941
942         Include header MachVMSPI.h instead of including the private header mach/mach_vm.h.
943
944         * DumpRenderTree/mac/CheckedMalloc.cpp:
945
946 2014-11-18  Carlos Garcia Campos  <cgarcia@igalia.com>
947
948         Unreviewed. Fix after /webkit2/WebKitWebView/default-context r176256.
949
950         Forgot to fix this test before landing.
951
952         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
953         (testWebViewDefaultContext):
954
955 2014-11-18  Carlos Garcia Campos  <cgarcia@igalia.com>
956
957         [GTK] Add API to create a WebKitWebContext
958         https://bugs.webkit.org/show_bug.cgi?id=138826
959
960         Reviewed by Gustavo Noronha Silva.
961
962         Use a different WebKitWebContext for every test to ensure test
963         cases are independent to each other. Tests using DBus to
964         communicate with the injected bundle extension now use a unique
965         name for the well known DBus name.
966
967         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
968         (beforeAll): Remove comment about the order of the tests and
969         move the success test before the failed one now that tests don't
970         depend on each others.
971         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
972         (beforeAll): Remove call to set the web extensions directory,
973         since this is now done for all test in the Test constructor.
974         * TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp:
975         (beforeAll): Do not create a temporary directory, a temporary data
976         directory is now created for all tests.
977         (afterAll):
978         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
979         (testWebKitDOMNodeHierarchyNavigation): Pass the web extension ID
980         to the web process test runner.
981         (testWebKitDOMNodeInsertion): Ditto.
982         (testWebKitDOMNodeTagNames): Ditto.
983         (beforeAll): Remove call to set the web extensions directory.
984         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNodeFilter.cpp:
985         (runTest): Pass the web extension ID to the web process test runner.
986         (beforeAll): Remove call to set the web extensions directory.
987         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMXPathNSResolver.cpp:
988         (runTest): Pass the web extension ID to the web process test runner.
989         (beforeAll): Remove call to set the web extensions directory.
990         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
991         (createFileAtDestination): Use Test::dataDirectory() as base dir
992         for temporary files.
993         (beforeAll): Do not create a temporary directory.
994         (afterAll):
995         * TestWebKitAPI/Tests/WebKit2Gtk/TestFrame.cpp:
996         (webkitFrameTestRun): Pass the web extension ID to the web process
997         test runner.
998         (beforeAll): Remove call to set the web extensions directory.
999         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
1000         (beforeAll): Remove call to set the web extensions directory.
1001         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
1002         (testProcessPerWebView): Use local member instead of global variable.
1003         (testMultiprocessWebViewCreateReadyClose): Ditto.
1004         (beforeAll): Do not connect to initialize-web-extensions, Test now
1005         connects to the signal for all tests and calls a virtual method
1006         that test can override.
1007         (afterAll):
1008         (initializeWebExtensions): Deleted.
1009         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
1010         (testPrintOperationPrint): Use Test::dataDirectory() as base dir
1011         for temporary files.
1012         (beforeAll): Do not create a temporary directory.
1013         (afterAll):
1014         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
1015         (beforeAll): Remove call to set the web extensions directory.
1016         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
1017         (beforeAll): Remove comment about the tests order.
1018         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
1019         (testWebExtensionGetTitle): Build the DBus service name using the
1020         web extension ID.
1021         (testDocumentLoadedSignal): Ditto.
1022         (testWebKitWebViewProcessCrashed): Ditto.
1023         (testWebExtensionIsolatedWorld): Ditto.
1024         (beforeAll): Remove initialization-user-data test, since now all
1025         tests are passing user data to the web extension.
1026         (testWebExtensionInitializationUserData): Deleted.
1027         (initializeWebExtensions): Deleted.
1028         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
1029         (testSetDirectory): Use the web context member inherited from Test.
1030         (testClearDatabase): Ditto.
1031         (testGetFaviconURI): Ditto.
1032         (beforeAll): Do not create a temporary directory.
1033         (afterAll):
1034         (webkitFaviconDatabaseFinalizedCallback): Deleted.
1035         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
1036         (UserContentManagerTest::UserContentManagerTest):
1037         (beforeAll): Remove call to set the web extensions directory.
1038         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1039         (testWebContextDefault): Check also that a newly create web
1040         context is not the default web context.
1041         (testWebContextSpellChecker): Use the web context member inherited
1042         from Test.
1043         (testWebContextLanguages): Ditto.
1044         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1045         (methodCallCallback): Remove GetInitializationUserData method.
1046         (webkit_web_extension_initialize_with_user_data): Always create
1047         the DBus name using the user data provided.
1048         (makeBusName): Deleted.
1049         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
1050         (webkit_web_extension_initialize_with_user_data): Create the DBus
1051         name using the user data provided.
1052         (webkit_web_extension_initialize): Deleted.
1053         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.cpp:
1054         (Test::dataDirectory): Return the temporary data directory.
1055         (removeNonEmptyDirectory): Also remove directories recursively.
1056         (main): Remove the disk cache directory initialization, since this
1057         is now done in the Test constructor.
1058         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
1059         (Test::initializeWebExtensionsCallback): Call the virtual method
1060         initializeWebExtensions()
1061         (Test::Test): Create a new WebKitWebContext and initialize it.
1062         (Test::~Test): Disconnect initialize-web-extensions signal.
1063         (Test::initializeWebExtensions): Set the web extensions directory
1064         and user data.
1065         * TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.cpp:
1066         (WebProcessTestRunner::~WebProcessTestRunner): Use nullptr.
1067         (WebProcessTestRunner::runTest): Build the DBus proxy using a
1068         unique name created with the Test web extension ID.
1069         (WebProcessTestRunner::proxy): Deleted.
1070         * TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.h:
1071         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
1072         (WebViewTest::WebViewTest): Create the web view with the Test web
1073         context.
1074         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h: Add optional user
1075         content manager parameter to the constructor.
1076
1077 2014-11-18  ChangSeok Oh  <changseok.oh@collabora.com>
1078
1079         [GTK] Mesa build fails over llvm-3.5
1080         https://bugs.webkit.org/show_bug.cgi?id=138825
1081
1082         Reviewed by Gustavo Noronha Silva.
1083
1084         OwningPtr.h have been removed in llvm-3.5. Instread we should use std::unique_ptr for mesa build.
1085
1086         * gtk/jhbuild.modules:
1087         * gtk/patches/mesa-gallivm-Fix-build-after-LLVM-commit-211259.patch: Added.
1088
1089 2014-11-17  Daniel Bates  <dabates@apple.com>
1090
1091         Unreviewed, rolling out r176232.
1092
1093         Broke the Mac build. Will investigate offline.
1094
1095         Reverted changeset:
1096
1097         "[iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions,
1098         MobileGestalt"
1099         https://bugs.webkit.org/show_bug.cgi?id=138802
1100         http://trac.webkit.org/changeset/176232
1101
1102 2014-11-17  Daniel Bates  <dabates@apple.com>
1103
1104         [iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions, MobileGestalt
1105         SPI are not available in public SDK
1106         https://bugs.webkit.org/show_bug.cgi?id=138802
1107
1108         Reviewed by David Kilzer.
1109
1110         Include header MachVMSPI.h instead of including the private header mach/mach_vm.h.
1111
1112         * DumpRenderTree/mac/CheckedMalloc.cpp:
1113
1114 2014-11-17  Jake Nielsen  <jacob_nielsen@apple.com>
1115
1116         Having 30+ flaky failures breaks EWS
1117         https://bugs.webkit.org/show_bug.cgi?id=138743
1118
1119         Reviewed by Alexey Proskuryakov.
1120
1121         Adds tests to ensure that the problem has been solved.
1122         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1123         (test_first_failure_limit):
1124         (test_first_failure_limit_with_some_tree_redness):
1125         (test_second_failure_limit):
1126         (test_tree_failure_limit_with_patch_that_potentially_fixes_some_redness):
1127         (test_first_and_second_failure_limit):
1128         (test_first_and_clean_failure_limit):
1129         (test_first_second_and_clean_failure_limit):
1130         (test_very_red_tree_retry): Deleted.
1131         Really this was renamed to test_first_second_and_clean_failure_limit.
1132         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1133         Makes the appropriate changes to PatchAnalysisTask to make sure that
1134         even when the first test run hits the failure limit, it will still try
1135         a second run.
1136         (PatchAnalysisTask._results_failed_different_tests):
1137         (PatchAnalysisTask._test_patch):
1138         (PatchAnalysisTask._continue_testing_patch_that_exceeded_failure_limit_on_first_or_second_try): Deleted.
1139
1140 2014-11-17  Ting-Wei Lan  <lantw44@gmail.com>
1141
1142         [GTK] Add library search paths from LDFLAGS before pkg-config --libs
1143         https://bugs.webkit.org/show_bug.cgi?id=136018
1144
1145         Reviewed by Carlos Garcia Campos.
1146
1147         It is possible that the order of -L arguments in the output of
1148         pkg-config is wrong, which causes the linker to find the wrong
1149         version (usually older version) of libraries when running
1150         gtkdoc-scangobj.
1151
1152         * gtk/gtkdoc.py:
1153         (GTKDoc._run_gtkdoc_scangobj):
1154
1155 2014-11-17  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1156
1157         Bump EFL version to 1.12.0
1158         https://bugs.webkit.org/show_bug.cgi?id=138733
1159
1160         Reviewed by Gyuyoung Kim.
1161
1162         * efl/jhbuild.modules:
1163
1164 2014-11-16  Joanmarie Diggs  <jdiggs@igalia.com>
1165
1166         AX: [ATK] Expose the blockquote element using ATK_ROLE_BLOCK_QUOTE
1167         https://bugs.webkit.org/show_bug.cgi?id=138771
1168
1169         Reviewed by Chris Fleizach.
1170
1171         Add mapping for ATK_ROLE_BLOCK_QUOTE in roleToString()
1172
1173         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1174
1175 2014-11-15  Joanmarie Diggs  <jdiggs@igalia.com>
1176
1177         AX: [ATK] Video and audio elements should be exposed using ATK's video and audio roles.
1178         https://bugs.webkit.org/show_bug.cgi?id=138767
1179
1180         Reviewed by Chris Fleizach.
1181
1182         Add mappings for ATK_ROLE_AUDIO and ATK_ROLE_VIDEO to roleToString().
1183
1184         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1185
1186 2014-11-14  Alexey Proskuryakov  <ap@apple.com>
1187
1188         Add shortcut macros to Mac TestExpectations
1189         https://bugs.webkit.org/show_bug.cgi?id=138729
1190
1191         Reviewed by Simon Fraser.
1192
1193         * Scripts/webkitpy/port/mac.py: (MacPort.configuration_specifier_macros):
1194         Add version macros for current OS versions.
1195
1196 2014-11-13  Alexey Proskuryakov  <ap@apple.com>
1197
1198         https://bugs.webkit.org/show_bug.cgi?id=138628
1199         A patch that doesn't apply is stuck in commit queue
1200
1201         Rubber-stamped by David Kilzer.
1202
1203         This also hopefully fixes other issues:
1204         - a patch that has cq+ flag set by a non-committer kills commit queue;
1205         - EWS never reports failing tests, and keeps spinning instead.
1206
1207         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1208         (Bugzilla.set_flag_on_attachment):
1209         (Bugzilla.obsolete_attachment):
1210         Apply the fix from r174797 to more places.
1211
1212 2014-11-13  Dan Bernstein  <mitz@apple.com>
1213
1214         Policy client not called for navigations through the page cache
1215         https://bugs.webkit.org/show_bug.cgi?id=138703
1216
1217         Reviewed by Alexey Proskuryakov.
1218
1219         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
1220         (-[DecidePolicyForPageCacheNavigationDelegate webView:didFinishNavigation:]):
1221         (-[DecidePolicyForPageCacheNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1222
1223 2014-11-13  Joanmarie Diggs  <jdiggs@igalia.com>
1224
1225         AX: [ATK] Do not return ATK_ROLE_UNKNOWN for null or otherwise invalid accessible objects
1226         https://bugs.webkit.org/show_bug.cgi?id=137867
1227
1228         Reviewed by Chris Fleizach.
1229
1230         Add ATK_ROLE_INVALID to roleToString. Remove the null AtkRole check in
1231         AccessibilityUIElement::role: ATK_ROLE_INVALID = 0, and we need to be
1232         able to test for the presence of ATK_ROLE_INVALID.
1233
1234         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1235         (WTR::AccessibilityUIElement::role):
1236
1237 2014-11-13  Juergen Ributzka  <juergen@apple.com>
1238
1239         Update the "combineModules" script to handel more LLVM metadata.
1240         https://bugs.webkit.org/show_bug.cgi?id=138514
1241
1242         Reviewed by Filip Pizlo.
1243
1244         * ReducedFTL/combineModules.rb:
1245
1246 2014-11-13  Myles C. Maxfield  <mmaxfield@apple.com>
1247
1248         Allow constructing a base PassRef with a derived Ref
1249         https://bugs.webkit.org/show_bug.cgi?id=138701
1250
1251         Reviewed by Andreas Kling
1252
1253         * TestWebKitAPI/Tests/WTF/Ref.cpp:
1254         (TestWebKitAPI::passWithPassRef):
1255         (TestWebKitAPI::passWithPassRefPtr):
1256         (TestWebKitAPI::TEST):
1257
1258 2014-11-05  Ada Chan  <adachan@apple.com>
1259
1260         Implement new plug-in API for muting plug-ins
1261         https://bugs.webkit.org/show_bug.cgi?id=138105
1262
1263         Reviewed by Anders Carlsson.
1264
1265         Add a new plug-in test for the mute API.
1266
1267         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1268         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SetMuted.cpp: Added.
1269         (SetMuted::SetMuted):
1270         (SetMuted::isMuted):
1271         (SetMuted::cachedIsMuted):
1272         (SetMuted::ScriptableObject::hasProperty):
1273         (SetMuted::ScriptableObject::getProperty):
1274         (SetMuted::ScriptableObject::pluginTest):
1275         (SetMuted::NPP_New):
1276         (SetMuted::NPP_GetValue):
1277         (SetMuted::NPP_SetValue):
1278
1279 2014-11-12  Philippe Normand  <pnormand@igalia.com>
1280
1281         Unreviewed, GTK gardening.
1282
1283         * Scripts/run-gtk-tests:
1284         (TestRunner): Skip the UserMediaBasic test because it depends on
1285         constraints validation which is going to be fixed in bug #136449.
1286
1287 2014-11-12  Carlos Garcia Campos  <cgarcia@igalia.com>
1288
1289         [GTK] Expose user script messages to GObject DOM bindings
1290         https://bugs.webkit.org/show_bug.cgi?id=138411
1291
1292         Reviewed by Philippe Normand.
1293
1294         Add a test case to check that user script messages sent using the
1295         DOM bindings API are also received in the UI process.
1296
1297         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
1298         (UserScriptMessageTest::waitUntilMessageReceived):
1299         (UserScriptMessageTest::postMessageAndWaitUntilReceived):
1300         (testUserContentManagerScriptMessageFromDOMBindings):
1301         (beforeAll):
1302         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1303         (documentLoadedCallback):
1304
1305 2014-11-12  Carlos Garcia Campos  <cgarcia@igalia.com>
1306
1307         Unreviewed. Fix GTK+ clean build after r175930.
1308
1309         Partial rollout of r175930 to not build the new unit test that
1310         broke clean builds in GTK+ port.
1311
1312         * TestWebKitAPI/PlatformGTK.cmake:
1313
1314 2014-09-01  Philippe Normand  <pnormand@igalia.com>
1315
1316         [WK2] UserMediaClient support
1317         https://bugs.webkit.org/show_bug.cgi?id=123158
1318
1319         Reviewed by Benjamin Poulain.
1320
1321         Simple API test for the UserMedia permission request API. The
1322         required test infrastructure is also added, inspired by the
1323         Geolocation infrastructure.
1324
1325         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: New API test for UserMedia
1326         Permission request.
1327         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp: Added.
1328         (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack):
1329         (TestWebKitAPI::TEST):
1330         * TestWebKitAPI/Tests/WebKit2/getUserMedia.html: Added.
1331         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: new
1332         helper method to set the permission request result without user interaction.
1333         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: Ditto.
1334         (WTR::InjectedBundle::setUserMediaPermission):
1335         * WebKitTestRunner/InjectedBundle/InjectedBundle.h: Ditto.
1336         * WebKitTestRunner/InjectedBundle/TestRunner.cpp: Ditto.
1337         (WTR::TestRunner::setUserMediaPermission):
1338         * WebKitTestRunner/InjectedBundle/TestRunner.h: Ditto.
1339         * WebKitTestRunner/TestController.cpp:
1340         (WTR::decidePolicyForUserMediaPermissionRequest): Permission
1341         request handler.
1342         (WTR::TestController::createOtherPage): Enable the new UserMedia
1343         permission request handler.
1344         (WTR::TestController::createWebViewWithOptions): Ditto.
1345         (WTR::TestController::resetPreferencesToConsistentValues): Enable
1346         MediaStream support, this is needed for getUserMedia.
1347         (WTR::TestController::resetStateToConsistentValues): clear
1348         UserMedia permissions list and flags.
1349         (WTR::TestController::setUserMediaPermission): Set permission
1350         request result and distpatch it.
1351         (WTR::TestController::handleUserMediaPermissionRequest): Save
1352         request and dispatch it.
1353         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible):
1354         Dispatch cached permission requests.
1355         * WebKitTestRunner/TestController.h:
1356         * WebKitTestRunner/TestInvocation.cpp:
1357         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1358
1359 2014-11-11  David Kilzer  <ddkilzer@apple.com>
1360
1361         webkit-patch --suggest-reviewers is broken with newer versions of git
1362         <http://webkit.org/b/138627>
1363
1364         Reviewed by Michael Saboff with feedback from Daniel Bates.
1365
1366         * Scripts/webkitpy/common/checkout/scm/git.py:
1367         (Git._changes_files_for_commit): Strip blank lines instead of
1368         assuming there is always a blank line at the beginning of the
1369         list.
1370
1371 2014-11-11  Alexey Proskuryakov  <ap@apple.com>
1372
1373         DRT and WKTR touch disk cache
1374         https://bugs.webkit.org/show_bug.cgi?id=138622
1375
1376         Reviewed by Geoffrey Garen.
1377
1378         * DumpRenderTree/mac/DumpRenderTree.mm: (prepareConsistentTestingEnvironment):
1379         Set a shared cache before calling -_switchNetworkLoaderToNewTestingSession, not after,
1380         because this function uses the shared cache.
1381
1382         * WebKitTestRunner/mac/TestControllerMac.mm: (WTR::TestController::platformInitializeContext):
1383         Create an empty shared cache to prevent a default one from being created on disk.
1384
1385 2014-10-07  Sergio Villar Senin  <svillar@igalia.com>
1386
1387         [CSS Grid Layout] Limit the size of explicit/implicit grid
1388         https://bugs.webkit.org/show_bug.cgi?id=136217
1389
1390         Reviewed by Andreas Kling.
1391
1392         Added a new unit test for the CSS parser. Right now it only checks
1393         that we properly clamp the maximum number of tracks on a grid to a
1394         maximum of 1 million.
1395
1396         * TestWebKitAPI/CMakeLists.txt:
1397         * TestWebKitAPI/PlatformEfl.cmake:
1398         * TestWebKitAPI/PlatformGTK.cmake:
1399         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1400         * TestWebKitAPI/Tests/WebCore/CSSParser.cpp: Added.
1401         (TestWebKitAPI::computeNumberOfTracks): Helper function.
1402         (TestWebKitAPI::TEST): Added a
1403         CSSPropertyParserTest.GridTrackLimits test case.
1404
1405 2014-11-11  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1406
1407         webkitpy test fix after r175867
1408         https://bugs.webkit.org/show_bug.cgi?id=138607
1409
1410         Reviewed by Philippe Normand.
1411
1412         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
1413         (GDBCrashLogGeneratorTest.test_generate_crash_log):
1414
1415 2014-11-10  Philippe Normand  <pnormand@igalia.com>
1416
1417         webkitpy: demangle C++ symbols from crash log stderr
1418         https://bugs.webkit.org/show_bug.cgi?id=138565
1419
1420         Reviewed by Alexey Proskuryakov.
1421
1422         * Scripts/webkitpy/port/linux_get_crash_log.py:
1423         (GDBCrashLogGenerator.generate_crash_log): Process stderr output
1424         with c++filt.
1425
1426 2014-11-10  Philippe Normand  <pnormand@igalia.com>
1427
1428         [GTK] fix up the GDB backtrace report tool
1429         https://bugs.webkit.org/show_bug.cgi?id=138564
1430
1431         Reviewed by Carlos Garcia Campos.
1432
1433         * Scripts/webkitpy/port/gtk.py:
1434         (GtkPort._get_crash_log): Match the process name reported by the
1435         driver with the GTK port WebProcess executable filename.
1436         * Scripts/webkitpy/port/linux_get_crash_log.py:
1437         (GDBCrashLogGenerator._get_gdb_output): Invoke gdb for the crashed
1438         program.
1439         (GDBCrashLogGenerator.generate_crash_log): Use %E in the core
1440         pattern to workaround the 16 characters size limit of %e.
1441
1442 2014-11-10  Conrad Shultz  <conrad_shultz@apple.com>
1443
1444         Unreviewed, moved myself to the list of committers.
1445
1446         * Scripts/webkitpy/common/config/contributors.json:
1447
1448 2014-11-10  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1449
1450         [EFL] Fix the test font path after r175555.
1451
1452         Reviewed by Csaba Osztrogonác.
1453
1454         * WebKitTestRunner/PlatformEfl.cmake: Dependencies -> DependenciesEFL
1455
1456 2014-11-10  Akos Kiss  <akiss@inf.u-szeged.hu>
1457
1458         Fix the exception fuzz helper to generate targets in the correct range
1459         https://bugs.webkit.org/show_bug.cgi?id=138544
1460
1461         Reviewed by Filip Pizlo.
1462
1463         Currently, the script generates exception fuzz targets in the range of
1464         0..($checkCount-1). However, target 0 is never hit, while target 1 is
1465         always outside of the outermost try block of the tests, which therefore
1466         prints unexpected output and results in false failures when fired at.
1467         Additionally, target $checkCount is never generated.
1468
1469         This patch fixes the script to generate targets in the range of
1470         2..$checkCount.
1471
1472         * Scripts/jsc-stress-test-helpers/js-exception-fuzz:
1473
1474 2014-11-09  Csaba Osztrogonác  <ossy@webkit.org>
1475
1476         make-passwords-json.py should generarate everything needed for testing
1477         https://bugs.webkit.org/show_bug.cgi?id=138503
1478
1479         Reviewed by Ryosuke Niwa.
1480
1481         * BuildSlaveSupport/build.webkit.org-config/make_passwords_json.py:
1482         Renamed from make-passwords-json.py to be able included from mastercfg_unittest.py.
1483         Additionally generate auth.json, credentials.cfg and committers.cfg too.
1484         (create_mock_slave_passwords_dict): Moved from mastercfg_unittest.py
1485         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1486         (BuildBotConfigLoader._mock_open): Use make_passwords_json.create_mock_slave_passwords_dict() to avoid duplication.
1487         (BuildBotConfigLoader._create_mock_passwords_dict): Deleted.
1488
1489 2014-11-09  Carlos Garcia Campos  <cgarcia@igalia.com>
1490
1491         [GTK] generate-gtkdoc should ignore invalid files
1492         https://bugs.webkit.org/show_bug.cgi?id=138542
1493
1494         Reviewed by Darin Adler.
1495
1496         * gtk/generate-gtkdoc:
1497         (files_to_ignore.file_should_be_ignored): Return True to ignore
1498         invalid files.
1499
1500 2014-11-08  Alexey Proskuryakov  <ap@apple.com>
1501
1502         Delete cookies between tests
1503         https://bugs.webkit.org/show_bug.cgi?id=138528
1504
1505         Reviewed by Sam Weinig.
1506
1507         * DumpRenderTree/mac/DumpRenderTree.mm:
1508         (resetWebPreferencesToConsistentValues):
1509         * WebKitTestRunner/TestController.cpp:
1510         (WTR::TestController::resetPreferencesToConsistentValues):
1511         Do it.
1512
1513         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1514         (WTR::InjectedBundle::beginTesting):
1515         Added a FIXME.
1516
1517 2014-11-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1518
1519         [GTK] Run layout tests using the network process
1520         https://bugs.webkit.org/show_bug.cgi?id=138428
1521
1522         Reviewed by Martin Robinson.
1523
1524         Shared secondary process is the default in the GTK+ port, but we
1525         should run the tests using the network process to ensure
1526         everything works with the network process. In the future, the
1527         shared secondary process model might be a special case of multiple
1528         processes with 1 as maximum number of processes, but always using
1529         the network process.
1530
1531         * WebKitTestRunner/TestController.cpp:
1532         (WTR::TestController::initialize):
1533
1534 2014-11-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1535
1536         [GTK] Allow to create a view with a related page in WTR
1537         https://bugs.webkit.org/show_bug.cgi?id=138501
1538
1539         Reviewed by Martin Robinson.
1540
1541         * TestWebKitAPI/gtk/PlatformWebViewGtk.cpp:
1542         (TestWebKitAPI::PlatformWebView::PlatformWebView): Pass nullptr as
1543         related page to WKViewCreate.
1544         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1545         (WTR::PlatformWebView::PlatformWebView): Pass the given related
1546         page to WKViewCreate.
1547
1548 2014-11-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1549
1550         WTR crashes after running a test when NetworkProcess enabled
1551         https://bugs.webkit.org/show_bug.cgi?id=138500
1552
1553         Reviewed by Alexey Proskuryakov.
1554
1555         WebNotificationProvider destructor is calling
1556         WKNotificationManagerSetProvider, but m_notificationManager is
1557         null because removeNotificationManager was already called.
1558
1559         * WebKitTestRunner/WebNotificationProvider.cpp:
1560         (WTR::WebNotificationProvider::~WebNotificationProvider): Check
1561         m_notificationManager is not null before calling WKNotificationManagerSetProvider.
1562
1563 2014-11-06  Jake Nielsen  <jacob_nielsen@apple.com>
1564
1565         Remove duplicate code from PatchAnalysisTask._test_patch and fix bug
1566         regarding incorrect call to PatchAnalysisTask.report_failure
1567         https://bugs.webkit.org/show_bug.cgi?id=138229
1568
1569         Reviewed by Daniel Bates.
1570
1571         * Scripts/webkitpy/common/net/layouttestresults.py:
1572         Makes sure test_results returns a list.
1573         (LayoutTestResults.test_results):
1574         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1575         Makes unit tests also check to make sure
1576         task.results_from_patch_test_run() and
1577         task.results_from_test_run_without_patch return instances of
1578         LayoutTestResults.
1579         (CommitQueueTaskTest._run_and_expect_patch_analysis_result):
1580         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1581         Condenses duplicate code into _should_defer_patch_or_throw, and
1582         removes the now-unused _clean_tree_results member.
1583         (PatchAnalysisTask.__init__):
1584         (PatchAnalysisTask._continue_testing_patch_that_exceeded_failure_limit_on_first_or_second_try):
1585         (PatchAnalysisTask._should_defer_patch_or_throw):
1586         (PatchAnalysisTask._test_patch):
1587         (PatchAnalysisTask.results_from_patch_test_run):
1588         (PatchAnalysisTask.results_from_test_run_without_patch): Deleted.
1589         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1590         Removes needless call to results_from_test_run_without_patch
1591         (AbstractEarlyWarningSystem._failing_tests_message):
1592         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1593         Changes order of test failure messages to be in the order that they
1594         appear.
1595         (AbstractEarlyWarningSystemTest.test_failing_tests_message):
1596         * Scripts/webkitpy/tool/commands/queues.py:
1597         Removes needless call to results_from_test_run_without_patch.
1598         (CommitQueue._failing_tests_message):
1599         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1600         (MockCommitQueueTask.results_from_test_run_without_patch): Deleted.
1601
1602 2014-11-06  Ryuan Choi  <ryuan.choi@navercorp.com>
1603
1604         Unreviewed. Reorder my e-mail addresses in contributors.json
1605
1606         * Scripts/webkitpy/common/config/contributors.json:
1607
1608 2014-11-06  Matthew Hanson  <matthew_hanson@apple.com>
1609
1610         Remove code that prepends a leading 'r' to the first argument of _run_git_svn_find_rev
1611         https://bugs.webkit.org/show_bug.cgi?id=138475
1612
1613         Reviewed by Ryosuke Niwa.
1614
1615         The change in https://trac.webkit.org/175603 introduced broke compatibility with svn_revision_from_git_commit.
1616         This patch reverts the part of that change that broke compatibility. In addition, this patch adds a comment to
1617         explain that SVN revisions require a leading 'r', moves an existing comment to a more appropriate location and
1618         renames the positional argument to better reflect that it can represent either an SVN revision or a Git tree-ish.
1619
1620         * Scripts/webkitpy/common/checkout/scm/git.py:
1621         (Git._run_git_svn_find_rev):
1622         Add comment mentioning that svn_revisions need to begin with 'r'.
1623         Move comment (explaining that git svn find-rev exits with code 0 when no match is found) to a more appropriate location.
1624         Rename the argument 'revision' to 'revision_or_treeish' to reflect the dual form that argument can take.
1625         Remove code that coerced the revision/treeish into a string and prepended an 'r'.
1626
1627 2014-11-06  Carlos Garcia Campos  <cgarcia@igalia.com>
1628
1629         [GTK] Add context menu API to Web Process Extensions
1630         https://bugs.webkit.org/show_bug.cgi?id=138311
1631
1632         Reviewed by Gustavo Noronha Silva.
1633
1634         Add tests cases for WebKitWebPage::context-menu signal.
1635
1636         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
1637         (testContextMenuWebExtensionMenu):
1638         (testContextMenuWebExtensionNode):
1639         (beforeAll):
1640         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1641         (serializeContextMenu):
1642         (serializeNode):
1643         (contextMenuCallback):
1644         (pageCreatedCallback):
1645
1646 2014-11-06  Commit Queue  <commit-queue@webkit.org>
1647
1648         Unreviewed, rolling out r175690.
1649         https://bugs.webkit.org/show_bug.cgi?id=138460
1650
1651         We are not ready to run layout tests using the network process
1652         yet (Requested by KaL on #webkit).
1653
1654         Reverted changeset:
1655
1656         "[GTK] Run layout tests using the network process"
1657         https://bugs.webkit.org/show_bug.cgi?id=138428
1658         http://trac.webkit.org/changeset/175690
1659
1660 2014-11-06  Carlos Garcia Campos  <cgarcia@igalia.com>
1661
1662         [GTK] Run layout tests using the network process
1663         https://bugs.webkit.org/show_bug.cgi?id=138428
1664
1665         Reviewed by Martin Robinson.
1666
1667         Shared secondary process is the default in the GTK+ port, but we
1668         should run the tests using the network process to ensure
1669         everything works with the network process. In the future, the
1670         shared secondary process model might be a special case of multiple
1671         processes with 1 as maximum number of processes, but always using
1672         the network process.
1673
1674         * WebKitTestRunner/TestController.cpp:
1675         (WTR::TestController::initialize):
1676
1677 2014-11-05  Dan Bernstein  <mitz@apple.com>
1678
1679         Remove the unused deletion UI feature
1680         https://bugs.webkit.org/show_bug.cgi?id=138442
1681
1682         Rubber-stamped by Alexey Proskuryakov.
1683
1684         * DumpRenderTree/mac/EditingDelegate.mm:
1685         (-[EditingDelegate webView:shouldShowDeleteInterfaceForElement:]): Deleted implementation of
1686         delegate method that’s been removed.
1687
1688 2014-11-05  Alexey Proskuryakov  <ap@apple.com>
1689
1690         fast/dom/remove-body-during-body-replacement2.html fails on WK2
1691         https://bugs.webkit.org/show_bug.cgi?id=138334
1692
1693         Reviewed by Anders Carlsson.
1694
1695         Reset focus to main frame between tests. DumpRenderTree does this via -makeFirstResponder
1696         calls, which works because each frame is an NSView in WK1. WK2 makes equivalent
1697         -makeFirstResponder calls, which may or may not be needed for other reasons, but
1698         it also needs to reset internal focus explicitly.
1699
1700         It's not clear if this is the right long-term fix or a workaround for a WebKit bug.
1701         WebKit behavior appears wrong, but it matches Firefox.
1702
1703         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1704         (WTR::InjectedBundlePage::resetAfterTest):
1705
1706 2014-11-05  Carlos Garcia Campos  <cgarcia@igalia.com>
1707
1708         [GTK] Add WebKitWebResource::failed-with-tls-errors signal
1709         https://bugs.webkit.org/show_bug.cgi?id=137862
1710
1711         Reviewed by Gustavo Noronha Silva.
1712
1713         Add a test case to check that WebKitWebResource::failed-with-tls-errors
1714         is emitted when a subresource load fails due to TLS errors.
1715
1716         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
1717         (TLSSubresourceTest::resourceLoadStartedCallback):
1718         (TLSSubresourceTest::TLSSubresourceTest):
1719         (TLSSubresourceTest::subresourceFailedCallback):
1720         (TLSSubresourceTest::subresourceFailedWithTLSErrorsCallback):
1721         (TLSSubresourceTest::subresourceLoadStarted):
1722         (TLSSubresourceTest::subresourceFailedWithTLSErrors):
1723         (TLSSubresourceTest::waitUntilSubresourceLoadFail):
1724         (testSubresourceLoadFailedWithTLSErrors):
1725         (httpsServerCallback):
1726         (httpServerCallback):
1727         (beforeAll):
1728
1729 2014-11-05  Alexey Proskuryakov  <ap@apple.com>
1730
1731         Build fix for some compiler versions.
1732
1733         * TestWebKitAPI/Tests/mac/TypingStyleCrash.mm: (TestWebKitAPI::TEST): Compiler was
1734         unhappy because this is a getter, and these shouldn't have side effects.
1735
1736 2014-11-04  Matthew Hanson  <matthew_hanson@apple.com>
1737
1738         Add a method for performing cherrypick-merges.
1739         https://bugs.webkit.org/show_bug.cgi?id=138375
1740
1741         Reviewed by Ryosuke Niwa.
1742
1743         Adds support for cherrypick-merges.
1744
1745         * Scripts/webkitpy/common/checkout/scm/git.py:
1746         (Git.cherrypick_merge): Added.
1747
1748 2014-11-04  Matthew Hanson  <matthew_hanson@apple.com>
1749
1750         Add a way to ascertain the SVN URL associated with a Git branch.
1751         https://bugs.webkit.org/show_bug.cgi?id=138374
1752
1753         Reviewed by Ryosuke Niwa.
1754
1755         The svn_url method returns the SVN URL associated with the current Git branch.
1756
1757         * Scripts/webkitpy/common/checkout/scm/git.py:
1758         (Git.svn_url): Added.
1759
1760 2014-11-04  Matthew Hanson  <matthew_hanson@apple.com>
1761
1762         Add the ability to search for modifications that are staged for commit.
1763         https://bugs.webkit.org/show_bug.cgi?id=138373
1764
1765         Reviewed by Ryosuke Niwa and Daniel Bates.
1766
1767         This makes is easy to do identify files that require merge post-processing,
1768         in addition to stand-alone utility.
1769
1770         * Scripts/webkitpy/common/checkout/scm/git.py:
1771         (Git.modifications_staged_for_commit): Added.
1772
1773 2014-11-04  Matthew Hanson  <matthew_hanson@apple.com>
1774
1775         Add a branch keyword argument to _run_git_svn_find_rev.
1776         https://bugs.webkit.org/show_bug.cgi?id=138372
1777
1778         Reviewed by Ryosuke Niwa.
1779
1780         The addition of this keyword argument allows clients to determine the Git hash
1781         of commits made on an SVN branch, provided that branch has been fetched locally.
1782
1783         * Scripts/webkitpy/common/checkout/scm/git.py:
1784         (Git._run_git_svn_find_rev):
1785         Add a branch keyword argument that is added to the end of the command, if present.
1786
1787 2014-11-04  Chris Dumez  <cdumez@apple.com>
1788
1789         Add ptr() method to Ref class
1790         https://bugs.webkit.org/show_bug.cgi?id=138361
1791
1792         Reviewed by Darin Adler.
1793
1794         Use the new Ref::ptr() method.
1795
1796         * TestWebKitAPI/Tests/WTF/Ref.cpp:
1797         (TestWebKitAPI::TEST):
1798
1799 2014-11-04  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
1800
1801         [jhbuild] Make it possible to build GTK/EFL in same repository
1802         https://bugs.webkit.org/show_bug.cgi?id=137448
1803
1804         Reviewed by Martin Robinson.
1805
1806         * Scripts/webkitdirs.pm:
1807         (getJhbuildPath):
1808         * WebKitTestRunner/InjectedBundle/efl/FontManagement.cpp:
1809         (getPlatformFontsPath):
1810         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1811         (WTR::getFontsPath):
1812         * jhbuild/jhbuild-wrapper:
1813         (determine_platform):
1814         (install_jhbuild):
1815         * jhbuild/jhbuildrc_common.py:
1816         (init):
1817
1818 2014-11-04  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
1819
1820         [EFL] Bump LLVM to version 3.5.0
1821         https://bugs.webkit.org/show_bug.cgi?id=138312
1822
1823         Reviewed by Csaba Osztrogonác.
1824
1825         * efl/jhbuild.modules:
1826         * efl/patches/llvm-elf-add-stackmaps.patch: Added.
1827         * efl/patches/llvm-elf-fix-x86_64-fdecfiencoding.patch: Added.
1828
1829 2014-11-03  Simon Fraser  <simon.fraser@apple.com>
1830
1831         Add page overlays that show regions with mouseWheel event handlers, and the non-fast-scrollable region, and code to toggle them in MiniBrowser WK2
1832         https://bugs.webkit.org/show_bug.cgi?id=138257
1833
1834         Reviewed by Tim Horton.
1835         
1836         Add a "Debug Overlays" submenu item under "WebKit2-only Settings" which allows
1837         the user to toggle region page overlays on and off. Two overlays are available,
1838         for the non-fast scrollable region, and the region of element with wheel
1839         event handlers.
1840
1841         * MiniBrowser/mac/SettingsController.h:
1842         * MiniBrowser/mac/SettingsController.m:
1843         (-[SettingsController _populateMenu]):
1844         (-[SettingsController validateMenuItem:]):
1845         (-[SettingsController nonFastScrollableRegionOverlayVisible]):
1846         (-[SettingsController wheelEventHandlerRegionOverlayVisible]):
1847         (-[SettingsController preferenceKeyForRegionOverlayTag:]):
1848         (-[SettingsController toggleDebugOverlay:]):
1849         (-[SettingsController debugOverlayVisible:]):
1850         * MiniBrowser/mac/WK2BrowserWindowController.m:
1851         (-[WK2BrowserWindowController didChangeSettings]):
1852
1853 2014-11-03  Alexey Proskuryakov  <ap@apple.com>
1854
1855         REGRESSION (Subpixel layout): Bubbles don't fit in Bugzilla review page
1856         https://bugs.webkit.org/show_bug.cgi?id=138323
1857
1858         Reviewed by Zalan Bujtas.
1859
1860         * QueueStatusServer/templates/statusbubble.html: Round the sizes up, not down.
1861
1862 2014-11-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1863
1864         [ninja] Don't remove response files for verbose builds
1865         https://bugs.webkit.org/show_bug.cgi?id=137816
1866
1867         Reviewed by Csaba Osztrogonác.
1868
1869         * Scripts/webkitdirs.pm:
1870         (determineNinjaVersion):
1871         (buildCMakeGeneratedProject):
1872
1873 2014-11-02  Akos Kiss  <akiss@inf.u-szeged.hu>
1874
1875         [GTK] Fix the build of FTL JIT
1876         https://bugs.webkit.org/show_bug.cgi?id=138298
1877
1878         Reviewed by Carlos Garcia Campos.
1879
1880         * gtk/jhbuild-optional.modules:
1881         Bump up LLVM version to 3.5.0 release and apply patches.
1882         * gtk/patches/llvm-elf-add-stackmaps.patch:
1883         Added. Adds .llvm_stackmaps section to ELF files. Backported from LLVM
1884         trunk.
1885         * gtk/patches/llvm-elf-fix-x86_64-fdecfiencoding.patch:
1886         Added. Ensures that PC-relative relocations in EH frames are not
1887         truncated to 32 bits on x86_64.
1888
1889 2014-10-31  Michael Saboff  <msaboff@apple.com>
1890
1891         No way to specify target os or architecture when using the --no-copy option with run-jsc-stress-tests
1892         https://bugs.webkit.org/show_bug.cgi?id=138268
1893
1894         Reviewed by Andreas Kling.
1895
1896         Added a --arch and --os option to set or override the values that are
1897         normally computed based on examining the JavaScriptCore we want to test.
1898
1899         * Scripts/run-jsc-stress-tests:
1900
1901 2014-10-31  Dan Bernstein  <mitz@apple.com>
1902
1903         llvmForJSC build emits a linker warning that it can't find usr/local/LLVMForJavaScriptCore/lib under the build directory
1904         https://bugs.webkit.org/show_bug.cgi?id=138259
1905
1906         Reviewed by Geoff Garen.
1907
1908         * Scripts/copy-webkitlibraries-to-product-directory: Create this directory even if it’s
1909         going to be empty to silence the warning.
1910
1911 2014-10-31  Adrian Perez de Castro  <aperez@igalia.com>
1912
1913         [GTK] Support script message handlers WebKitUserContentManager
1914         https://bugs.webkit.org/show_bug.cgi?id=133730
1915
1916         Reviewed by Carlos Garcia Campos.
1917
1918         Support user script message handlers in WebKitUserContentManager.
1919         This needs building with ENABLE_USER_MESSAGE_HANDLERS, for which
1920         an option is added to the CMake build files. The option is disabled
1921         globally by default, and the WebKitGTK port enables it. On the API
1922         level, two new methods to register and unregister names are provided
1923         in the "window.webkit" namespace, and on message reception the
1924         "WebKitUserContentManager::script-message-received" signal is
1925         emitted, using the registered names as signal detail.
1926
1927         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
1928         Add test case for user script message handlers.
1929         (scriptMessageReceived):
1930         (testUserContentManagerScriptMessageReceived):
1931         (beforeAll):
1932
1933 2014-10-30  Matthew Hanson  <matthew_hanson@apple.com>
1934
1935         bisect-builds should support WebKit clients other than Safari
1936         https://bugs.webkit.org/show_bug.cgi?id=138225
1937
1938         This patch adds support for bisecting WebKit nightly builds with clients other than Safari.
1939
1940         The -a / --application optional argument allows the user to specify which application (or application bundle)
1941         should be run against the WebKit nightly builds.
1942
1943         Reviewed by David Kilzer.
1944
1945         * Scripts/bisect-builds:
1946         Swap out $safariPath for the more general $applicationPath
1947         Leave --safari-path as a commandline option for backwards compatibility
1948         (mountAndRunNightly):
1949         Use File::Spec->cat correctly (one directory per argument)
1950         Use open --wait-apps instead of running the target application directly
1951
1952 2014-10-30  Dana Burkart  <dburkart@apple.com>
1953
1954         <rdar://problem/18821260> Perpare for the mysterious future
1955
1956         Reviewed by Lucas Forschler.
1957
1958         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1959         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1960         * LayoutTestRelay/Configurations/Base.xcconfig:
1961         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
1962         * MiniBrowser/Configurations/Base.xcconfig:
1963         * MiniBrowser/Configurations/DebugRelease.xcconfig:
1964         * TestWebKitAPI/Configurations/Base.xcconfig:
1965         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
1966         * WebKitLauncher/Configurations/Base.xcconfig:
1967         * WebKitTestRunner/Configurations/Base.xcconfig:
1968         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1969
1970 2014-10-30  Matthew Hanson  <matthew_hanson@apple.com>
1971
1972         Update safariVersion to safariVersionString
1973         https://bugs.webkit.org/show_bug.cgi?id=138193
1974
1975         The preceding change updated safariVersion to safariVersionString for the "4 Public Beta" check in OS X 10.5.x,
1976         but it should have also been done for the "4 Public Beta" check in OS X 10.4.x.
1977
1978         Rubber-stamped by David Kilzer.
1979
1980         * Scripts/bisect-builds:
1981         (makeNightlyList):
1982         Compare safariVersionString to a string literal, instead of safariVersion.
1983
1984 2014-10-30  Rohit Kumar  <kumar.rohit@samsung.com>
1985
1986         [GTK] Minibrowser : Add window fullscreen support for Minibrowser
1987         https://bugs.webkit.org/show_bug.cgi?id=137775
1988
1989         Reviewed by Carlos Garcia Campos.
1990
1991         * MiniBrowser/gtk/BrowserWindow.c:
1992         (toggleFullScreen): Callback to toggle window fullscreen on pressing F11 key.
1993         (browser_window_init):
1994
1995 2014-10-29  Jake Nielsen  <jacob_nielsen@apple.com>
1996
1997         CommitQueue and EWS should reject any patches that result in consistent test
1998         failures that aren't present on the tree.
1999         https://bugs.webkit.org/show_bug.cgi?id=138184
2000
2001         Reviewed by Alexey Proskuryakov.
2002
2003         * Scripts/webkitpy/layout_tests/models/test_results.py:
2004         Adds a simple hashing function to allow for set operations to handle
2005         TestResult objects properly.
2006         (TestResult.__hash__):
2007         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2008         Adds one unit test, and modifies others to agree with the notion that
2009         patches that introduce new test failures (but also have flakyness)
2010         should be rejected rather than spin.
2011         (MockCommitQueue.report_flaky_tests):
2012         (CommitQueueTaskTest._run_and_expect_patch_analysis_result):
2013         (test_double_flaky_test_failure):
2014         (test_two_flaky_tests):
2015         (test_very_flaky_patch):
2016         (test_very_flaky_patch_with_some_tree_redness):
2017         (test_different_test_failures):
2018         (test_different_test_failures_with_some_tree_redness):
2019         (test_different_test_failures_with_some_tree_redness_and_some_fixes):
2020         (test_mildly_flaky_patch):
2021         (test_mildly_flaky_patch_with_some_tree_redness):
2022         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
2023         Makes PatchAnalysisTask reject said patches.
2024         (PatchAnalysisTask._test_patch):
2025
2026 2014-10-29  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2027
2028         WinCairoRequirements.zip cannot be downloaded from dropbox
2029         https://bugs.webkit.org/show_bug.cgi?id=138113
2030
2031         Reviewed by Alexey Proskuryakov.
2032
2033         * Scripts/update-webkit-dependency: Removing --sslv3 option from curl
2034
2035 2014-10-29  Matthew Hanson  <matthew_hanson@apple.com>
2036
2037         bisect-builds should filter out nightlies that predate the introduction of an OS X operating system
2038         https://bugs.webkit.org/show_bug.cgi?id=138193
2039
2040         This patch restricts the set of nightles to bisect to only those nightlies that ship with frameworks
2041         for the target OS (only support for OS X Yosemite, Mavericks and Mountain Lion was added.)
2042
2043         It also does a bit of refactoring, including distinguishing between versions and version strings and
2044         saving versions to local variables instead of using eval in each conditional.
2045
2046         Reviewed by David Kilzer.
2047
2048         * Scripts/bisect-builds:
2049         (makeNightlyList):
2050         Restrict the set of nightlies to r174650 and above when running Yosemite.
2051         Restrict the set of nightlies to r157846 and above when running Mavericks.
2052         Restrict the set of nightlies to r122421 and above when running Mountain Lion.
2053
2054 2014-10-29  Csaba Osztrogonác  <ossy@webkit.org>
2055
2056         [EFL] build-webkit should try harder to avoid re-running cmake
2057         https://bugs.webkit.org/show_bug.cgi?id=137949
2058
2059         Reviewed by Martin Robinson.
2060
2061         * Scripts/webkitdirs.pm:
2062         (shouldRemoveCMakeCache): Don't remove CMakeCache unconditionally for EFL.
2063         (generateBuildSystemFromCMakeProject): Comment fix after r174681.
2064
2065 2014-10-28  Daniel Bates  <dabates@apple.com>
2066
2067         Unify logic in RunTests.run() to run the Python unit tests
2068         https://bugs.webkit.org/show_bug.cgi?id=138160
2069
2070         Reviewed by Martin Robinson.
2071
2072         Unify the interactive and non-interactive code path for running the Python unit tests
2073         in step RunTests so as to remove duplicate code to compute the the path to the script
2074         test-webkitpy and log an informative message ("Running Python unit tests") to the console.
2075
2076         No new tests since no functionality was changed.
2077
2078         * Scripts/webkitpy/port/base.py:
2079         (Port.python_unittest_results_directory):
2080         * Scripts/webkitpy/tool/steps/runtests.py:
2081         (RunTests.run):
2082
2083 2014-10-28  Jake Nielsen  <jacob_nielsen@apple.com>
2084
2085         Make runtest.py call test-webkitpy with the --json flag when in
2086         non-interactive mode.
2087         https://bugs.webkit.org/show_bug.cgi?id=137667
2088
2089         Reviewed by Daniel Bates.
2090
2091         * Scripts/webkitpy/port/base.py:
2092         Adds the python_unittest_results_directory method.
2093         (Port.python_unittest_results_directory):
2094         * Scripts/webkitpy/tool/steps/runtests.py:
2095         Changes RunTests to call test-webkitpy with the --json flag if the
2096         --non-interactive flag is set.
2097         (RunTests):
2098         (RunTests.run):
2099
2100 2014-10-28  Rebecca Hauck  <rhauck@adobe.com>
2101
2102         import-w3c-tests should use re.escape() wherever it's handling file paths
2103         https://bugs.webkit.org/show_bug.cgi?id=137934
2104
2105         This patch adds re.escape() to a few places where we're doing string
2106         conversions. This prevents errors when attribute values coincidentally
2107         have character sequences that can be interpreted as regular expressions.
2108
2109         Reviewed by Bem Jones-Bey.
2110
2111         * Scripts/webkitpy/w3c/test_converter.py:
2112         (_W3CTestConverter.convert_attributes_if_needed):
2113
2114 2014-10-28  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
2115
2116         [EFL] Remove an unused include from Tools/WebKitTestRunner/efl/PlatformWebViewEfl.cpp
2117         https://bugs.webkit.org/show_bug.cgi?id=138130
2118
2119         Reviewed by Csaba Osztrogonác.
2120
2121         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2122
2123 2014-10-25  Raniere Silva  <raniere@ime.unicamp.br>
2124
2125         Fix link to Arch Linux Wiki
2126         https://bugs.webkit.org/show_bug.cgi?id=138010
2127
2128         Reviewed by Benjamin Poulain.
2129
2130         * gtk/install-dependencies:
2131
2132 2014-10-25  Alexey Proskuryakov  <ap@apple.com>
2133
2134         Test regressions are not detected when image result is missing
2135         https://bugs.webkit.org/show_bug.cgi?id=138070
2136
2137         Reviewed by Simon Fraser.
2138
2139         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2140         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
2141         Count these as regressions, not as flaky tests.
2142
2143         * Scripts/webkitpy/port/test.py:
2144         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2145         Test it.
2146
2147 2014-10-24  Timothy Horton  <timothy_horton@apple.com>
2148
2149         Add Conrad Shultz to the contributors list.
2150
2151         * Scripts/webkitpy/common/config/contributors.json:
2152
2153 2014-10-24  Dan Bernstein  <mitz@apple.com>
2154
2155         build.webkit.org/dashboard immediately retries a request to buildbot when the response is 404
2156         https://bugs.webkit.org/show_bug.cgi?id=138046
2157
2158         Reviewed by Alexey Proskuryakov.
2159
2160         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2161         (BuildbotQueue.prototype._load): Only consider retrying immediately if the error code was
2162         401. Otherwise, we’ll retry normally in 45 seconds.
2163
2164 2014-10-24  Marcos Chavarría Teijeiro  <chavarria1991@gmail.com>
2165
2166         [GTK] Implement is_selected method on WebKitHitTestResult
2167         https://bugs.webkit.org/show_bug.cgi?id=137110
2168
2169         Reviewed by Tim Horton.
2170
2171         Add tests for new context SELECTION on WebKitHitTestResult.
2172
2173         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
2174         (testContextMenuDefaultMenu):
2175         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
2176         (testWebViewMouseTarget):
2177
2178 2014-10-23  Roger Fong  <roger_fong@apple.com>
2179
2180         [Win] Skip failing JSC tests following r175078
2181         https://bugs.webkit.org/show_bug.cgi?id=130967.
2182
2183         * Scripts/run-javascriptcore-tests:
2184
2185 2014-10-22  Jake Nielsen  <jacob_nielsen@apple.com>
2186
2187         commitqueuetask_unittest.py should be made more concise.
2188         https://bugs.webkit.org/show_bug.cgi?id=137985
2189
2190         Reviewed by Alexey Proskuryakov.
2191
2192         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2193         Refactors tests to use MockSimpleTestPlanCommitQueue where possible.
2194         (MockCommitQueue.__init__):
2195         (MockCommitQueue.report_flaky_tests):
2196         (MockCommitQueue):
2197         (MockCommitQueue.get_reported_flaky_tests):
2198         (MockSimpleTestPlanCommitQueue.__init__):
2199         (MockSimpleTestPlanCommitQueue.run_command):
2200         (MockSimpleTestPlanCommitQueue.did_run_clean_tests):
2201         (CommitQueueTaskTest._run_and_expect_patch_analysis_result):
2202         (test_land_failure):
2203         (test_failed_archive):
2204         (test_double_flaky_test_failure):
2205         (test_test_failure):
2206         (test_red_test_failure):
2207         (test_very_red_tree_retry):
2208         (test_red_tree_patch_rejection):
2209         (test_one_flaky_test):
2210         (test_tree_more_red_than_patch):
2211         (MockCommitQueue.test_results): Deleted.
2212         (test_simple_flaky_test_failure): Deleted.
2213         (_expect_validate): Deleted.
2214         (_expect_validate.MockDelegate): Deleted.
2215         (_expect_validate.MockDelegate.refetch_patch): Deleted.
2216         (_expect_validate.MockDelegate.expected_failures): Deleted.
2217         (_mock_patch): Deleted.
2218         (test_validate): Deleted.
2219         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
2220         Fixes a bug that slipped through the cracks prior to this change.
2221         (PatchAnalysisTask._test_patch):
2222
2223 2014-10-22  Alexey Proskuryakov  <ap@apple.com>
2224
2225         Flakiness dashboard should support OS X Yosemite
2226         https://bugs.webkit.org/show_bug.cgi?id=137986
2227
2228         Reviewed by Ryosuke Niwa.
2229
2230         * TestResultServer/app.yaml:
2231         * TestResultServer/static-dashboards/builders.jsonp:
2232         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2233
2234 2014-10-22  Jake Nielsen  <jacob_nielsen@apple.com>
2235
2236         commitqueuetask should include more tests to ensure that the behavior
2237         of PatchAnalysisTask._test_patch() is well defined
2238         https://bugs.webkit.org/show_bug.cgi?id=137977
2239
2240         Reviewed by Alexey Proskuryakov.
2241
2242         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2243         Adds the MockSimpleTestPlanCommitQueue class, which makes it easier
2244         and more readable to define tests that are meant to test the behaviour
2245         of PatchAnalysisTask._test_patch(), and adds several unit tests.
2246         (FailingTestCommitQueue.test_results):
2247         (PatchAnalysisResult):
2248         (MockSimpleTestPlanCommitQueue):
2249         (MockSimpleTestPlanCommitQueue.__init__):
2250         (MockSimpleTestPlanCommitQueue.run_command):
2251         (MockSimpleTestPlanCommitQueue._mock_test_result):
2252         (MockSimpleTestPlanCommitQueue.test_results):
2253         (CommitQueueTaskTest._run_and_expect_patch_analysis_result):
2254         (test_flaky_test_failure):
2255         (test_failed_archive):
2256         (test_two_flaky_tests):
2257         (test_one_flaky_test):
2258         (test_very_flaky_patch):
2259         (test_very_flaky_patch_with_some_tree_redness):
2260         (test_different_test_failures):
2261         (test_different_test_failures_with_some_tree_redness):
2262         (test_mildly_flaky_patch):
2263         (test_mildly_flaky_patch_with_some_tree_redness):
2264         (test_tree_more_red_than_patch):
2265
2266 2014-10-22  Jake Nielsen  <jacob_nielsen@apple.com>
2267
2268         PatchAnalysisTask._test_patch() needs refactoring
2269         https://bugs.webkit.org/show_bug.cgi?id=137904
2270
2271         Reviewed by Alexey Proskuryakov.
2272
2273         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2274         Fixes several small bugs, and makes minor changes to accomodate the
2275         changes in PatchAnalysisTask.
2276         (MockCommitQueue.refetch_patch):
2277         (MockCommitQueue.test_results):
2278         (test_flaky_test_failure):
2279         (test_failed_archive):
2280         (test_very_red_tree_retry):
2281         (_expect_validate.MockDelegate.refetch_patch):
2282         (MockCommitQueue.expected_failures): Deleted.
2283         (_expect_validate.MockDelegate.expected_failures): Deleted.
2284         * Scripts/webkitpy/tool/bot/expectedfailures.py: Removed.
2285         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py: Removed.
2286         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
2287         Removes the unexpected_failures member, adds the _clean_tree_results
2288         member, adds a helper function for _test_patch, and refactors
2289         _test_patch to be more readable.
2290         (PatchAnalysisTask.__init__):
2291         (PatchAnalysisTask._continue_testing_patch_that_exceeded_failure_limit_on_first_or_second_try):
2292         (PatchAnalysisTask._test_patch):
2293         (PatchAnalysisTask.results_from_test_run_without_patch):
2294         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2295         Removes AbstractEarlyWarningSystem's dependancy on ExpectedFailures. 
2296         (AbstractEarlyWarningSystem.begin_work_queue):
2297         (AbstractEarlyWarningSystem._failing_tests_message):
2298         (AbstractEarlyWarningSystem.command_failed):
2299         (AbstractEarlyWarningSystem.expected_failures): Deleted.
2300         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2301         Makes changes to accomodate the changes made to PatchAnalysisTask.
2302         (AbstractEarlyWarningSystemTest.test_failing_tests_message):
2303         * Scripts/webkitpy/tool/commands/perfalizer.py:
2304         Removes Perfalizer's dependancy on ExpectedFailures. 
2305         (PerfalizerTask.refetch_patch):
2306         (PerfalizerTask.expected_failures): Deleted.
2307         * Scripts/webkitpy/tool/commands/queues.py:
2308         Removes CommitQueue's dependancy on ExpectedFailures, and adds an
2309         initializer to allow for mock injection.
2310         (CommitQueue.__init__):
2311         (CommitQueue.begin_work_queue):
2312         (CommitQueue.process_work_item):
2313         (CommitQueue._failing_tests_message):
2314         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2315         Removes dependancy on ExpectedFailures, and instead uses mock
2316         injection.
2317         (MockCommitQueueTask):
2318         (MockCommitQueueTask.results_from_patch_test_run):
2319         (MockCommitQueueTask.results_from_test_run_without_patch):
2320         (mock_run_webkit_patch):
2321
2322 2014-10-22  Rohit Kumar  <kumar.rohit@samsung.com>
2323
2324         [EFL][WK2] Minibrowser : Add support for mouse middle button to open links in new window
2325         https://bugs.webkit.org/show_bug.cgi?id=136736
2326
2327         Reviewed by Gyuyoung Kim.
2328
2329         * MiniBrowser/efl/main.c:
2330         (on_navigation_policy_decision): Check whether it's a link clicked with the middle mouse button and load the request in a new window.
2331         (window_create):
2332
2333 2014-10-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2334
2335         [GTK] Move GtkInputMethodFilter from Platform to WebKit2
2336         https://bugs.webkit.org/show_bug.cgi?id=137884
2337
2338         Reviewed by Gustavo Noronha Silva.
2339
2340         Move InputMethodFilter test from WebCore tests to WebKit2 tests
2341         and adapt it to use the new InputMethodFilter WebKit class. Instead
2342         of having virtual methods just for testing, it has a testing mode
2343         that logs the events.
2344
2345         * TestWebKitAPI/PlatformGTK.cmake:
2346         * TestWebKitAPI/Tests/WebKit2/gtk/InputMethodFilter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/gtk/InputMethodFilter.cpp.
2347         (TestWebKitAPI::TestInputMethodFilter::TestInputMethodFilter):
2348         (TestWebKitAPI::TestInputMethodFilter::~TestInputMethodFilter):
2349         (TestWebKitAPI::TestInputMethodFilter::sendKeyEventToFilter):
2350         (TestWebKitAPI::TestInputMethodFilter::sendPressAndReleaseKeyEventPairToFilter):
2351         (TestWebKitAPI::TEST):
2352         (TestWebKitAPI::temporaryGetPreeditStringOverride):
2353         (TestWebKitAPI::temporaryResetOverride):
2354         (TestWebKitAPI::verifyCanceledComposition):
2355
2356 2014-10-21  Alexey Proskuryakov  <ap@apple.com>
2357
2358         build.webkit.org/dashboard: Cannot click on green tester bubbles
2359         https://bugs.webkit.org/show_bug.cgi?id=137909
2360
2361         Reviewed by Darin Adler.
2362
2363         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2364         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
2365
2366 2014-10-21  Brent Fulgham  <bfulgham@apple.com>
2367
2368         [Win] Run DumpRenderTree using native controls, not SafariTheme.dll.
2369         https://bugs.webkit.org/show_bug.cgi?id=137932
2370
2371         Reviewed by Simon Fraser.
2372
2373         This is the first step in moving over to native Windows rendering for our layout tests.
2374         Once this change lands, approximately 300 tests will start failing on Windows. I will
2375         rebaseline these changes against our test hardware and update this bug with the
2376         commits related to that work.
2377
2378         * DumpRenderTree/win/DumpRenderTree.cpp:
2379         (resetDefaultsToConsistentValues): Call 'setShouldPaintNativeControls(TRUE)' so that
2380         we use native Windows drawing style.
2381
2382 2014-10-21  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
2383
2384         Fix FTL Native Inlining for EFL
2385         https://bugs.webkit.org/show_bug.cgi?id=137774
2386
2387         Reviewed by Michael Saboff.
2388
2389         Added Clang as an optional module to jhbuild.
2390
2391         * efl/jhbuild.modules:
2392
2393 2014-10-20  Michael Catanzaro  <mcatanzaro@igalia.com>
2394
2395         Change the default TLS errors policy to WEBKIT_TLS_ERRORS_POLICY_FAIL
2396         https://bugs.webkit.org/show_bug.cgi?id=137832
2397
2398         Reviewed by Carlos Garcia Campos.
2399
2400         Ensure each test sets the TLS errors policy that it really needs.
2401         Have each test except testTLSErrorsPolicy stash and restore the original
2402         TLS errors policy. Update testTLSErrorsPolicy to account for the new
2403         default policy.
2404
2405         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
2406         (testSSL):
2407         (testInsecureContent):
2408         (testTLSErrorsPolicy):
2409         (testTLSErrorsRedirect):
2410         (testTLSErrorsHTTPAuth):
2411         (testLoadFailedWithTLSErrors):
2412         (beforeAll):
2413
2414 2014-10-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2415
2416         Unreviewed. Unskip inspector server unit tests.
2417
2418         They should pass now.
2419
2420         * Scripts/run-gtk-tests:
2421         (TestRunner):
2422
2423 2014-10-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2424
2425         [GTK] Test TestWebKitAPI/WebKit2Gtk/TestInspectorServer fails
2426         https://bugs.webkit.org/show_bug.cgi?id=132044
2427
2428         Reviewed by Brian Burg.
2429
2430         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
2431         (openRemoteDebuggingSession): Remove trailing slash when
2432         concatenating base inspector URL with the page, because the
2433         inspector returns the relative paths with a leading slash.
2434
2435 2014-10-20  Tanay C  <tanay.c@samsung.com>
2436
2437         [EFL][WK2] Minibrowser : Add support for Case sensitive and word start search
2438         https://bugs.webkit.org/show_bug.cgi?id=137023
2439
2440         Reviewed by Gyuyoung Kim.
2441
2442         * MiniBrowser/efl/main.c: Added functionality to support case sensitive and word start search
2443         (search_box_show): Modified.
2444         (search_box_hide): Modified.
2445         (on_search_field_activated): Modified.
2446         (on_search_backward_button_clicked): Modified.
2447         (on_search_forward_button_clicked): Modified.
2448         (on_search_case_option_changed): Added.
2449         (on_search_word_start_option_changed): Added.
2450         (window_create): Modified.
2451
2452 2014-10-20  Tanay C  <tanay.c@samsung.com>
2453
2454         [GTK][Minibrowser] Escape key does not hide the search box
2455         https://bugs.webkit.org/show_bug.cgi?id=137734
2456
2457         Reviewed by Philippe Normand.
2458
2459         * MiniBrowser/gtk/BrowserWindow.c: Added the check to handle search box hide
2460         (stopPageLoad): Modified.
2461
2462 2014-10-18  Antti Koivisto  <antti@apple.com>
2463
2464         REGRESSION (r173356): Safari can't install a profile, gets 'Download Failed error
2465         https://bugs.webkit.org/show_bug.cgi?id=137855
2466
2467         Reviewed by Dan Bernstein.
2468
2469         Test and warn if the dumped response mime type differs from the platform response mime type.
2470
2471         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2472         (WTR::InjectedBundlePage::didReceiveResponseForResource):
2473         (WTR::InjectedBundlePage::platformResponseMimeType):
2474         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2475         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
2476         (WTR::InjectedBundlePage::platformResponseMimeType):
2477
2478 2014-10-17  Joseph Pecoraro  <pecoraro@apple.com>
2479
2480         Remove run-inspector-perf-tests.py there is no PerformanceTests/inspector anymore
2481         https://bugs.webkit.org/show_bug.cgi?id=137835
2482
2483         Reviewed by Andreas Kling.
2484
2485         * Scripts/run-inspector-perf-tests.py: Removed.
2486         This script is stale, as PerformanceTests/inspector no longer exists.
2487
2488 2014-10-17  Simon Fraser  <simon.fraser@apple.com>
2489
2490         Fix typo: should be ios-simulator-wk2, not ios-simulator_wk2.
2491
2492         * Scripts/webkitpy/port/ios.py:
2493         (IOSSimulatorPort.default_baseline_search_path):
2494
2495 2014-10-17  Simon Fraser  <simon.fraser@apple.com>
2496
2497         [iOS] Simplify test fallback paths for iOS Simulator testing
2498         https://bugs.webkit.org/show_bug.cgi?id=137830
2499
2500         Reviewed by Zalan Bujtas.
2501         
2502         Make the fallback paths be:
2503             ios-simulator -> generic
2504             ios-simulator-wk2->ios-simulator -> generic
2505         
2506         so don't include mac in the fallback path. Also remove the
2507         version handling for simplicity.
2508
2509         * Scripts/webkitpy/port/ios.py:
2510         (IOSSimulatorPort):
2511         (IOSSimulatorPort.default_baseline_search_path):
2512
2513 2014-10-17  Dana Burkart  <dburkart@apple.com>
2514
2515         Fix typos in the dashboard config file.
2516
2517         Unreviewed.
2518
2519         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2520         (WebKitBuildbot):
2521
2522 2014-10-17  Brent Fulgham  <bfulgham@apple.com>
2523
2524         [Win] Allow WinLauncher to specify Custom User Agent strings
2525         https://bugs.webkit.org/show_bug.cgi?id=137828
2526
2527         Reviewed by Dean Jackson.
2528
2529         * WinLauncher/Common.cpp: Add support for custom user agent strings.
2530         * WinLauncher/WinLauncher.cpp: Add some convenience methods to get
2531         and set the user agent strings.
2532         * WinLauncher/WinLauncher.h:
2533         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Add new menu
2534         resources and dialog for setting custom User Agent strings.
2535         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h:
2536
2537 2014-10-16  Simon Fraser  <simon.fraser@apple.com>
2538
2539         [iOS] Turn off font autosizing for iOS WebKitTestRunner
2540         https://bugs.webkit.org/show_bug.cgi?id=137806
2541
2542         Reviewed by Sam Weinig.
2543
2544         Confusingly, WKPreferencesSetTextAutosizingEnabled() does nothing on iOS.
2545         Instead, we have to add WKPreferencesSetMinimumZoomFontSize() and set it to 0
2546         to disable font autosizing.
2547         
2548         Add platformResetPreferencesToConsistentValues() and implement it in the iOS
2549         test controller to set platform-specific prefs.
2550
2551         * WebKitTestRunner/TestController.cpp:
2552         (WTR::TestController::resetPreferencesToConsistentValues):
2553         (WTR::TestController::platformResetPreferencesToConsistentValues):
2554         * WebKitTestRunner/TestController.h:
2555         * WebKitTestRunner/ios/TestControllerIOS.mm:
2556         (WTR::TestController::platformResetPreferencesToConsistentValues):
2557         * WebKitTestRunner/mac/TestControllerMac.mm:
2558         (WTR::TestController::platformResetPreferencesToConsistentValues):
2559
2560 2014-10-16  Dan Bernstein  <mitz@apple.com>
2561
2562         OSObjectPtr is missing leakRef()
2563         https://bugs.webkit.org/show_bug.cgi?id=137798
2564
2565         Reviewed by Sam Weinig.
2566
2567         * TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp:
2568         (TestWebKitAPI::TEST(OSObjectPtr, LeakRef)): Added.
2569
2570 2014-10-16  Lucas Forschler  <lforschler@apple.com>
2571
2572         Update target platform to remove Leopard, Snow Leopard, Lion.
2573         Add Yosemite. 
2574         
2575         Unreviewed.
2576
2577         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
2578         (_should_file_trigger_build):
2579
2580 2014-10-16  David Kilzer  <ddkilzer@apple.com>
2581
2582         commit-queue: fails to replace OO-PS! with reviewer name
2583         <http://webkit.org/b/137795>
2584
2585         Reviewed by Alexey Proskuryakov.
2586
2587         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2588         (Bugzilla.fetch_bug_dictionary): Bugzilla 4.2.x never gives out
2589         email addresses to unauthenticated page loads, so we must always
2590         authenticate before getting bug data so we get full email
2591         addresses.
2592
2593 2014-10-16  David Kilzer  <ddkilzer@apple.com>
2594
2595         commit-queue: fails to close bugs after successfully landing patches
2596         <http://webkit.org/b/137794>
2597
2598         Reviewed by Alexey Proskuryakov.
2599
2600         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2601         (Bugzilla.clear_attachment_flags): Change 'nr=0' to 'nr=1' to
2602         tell Mechanize to use the second <textarea> on the page with
2603         name="comment".
2604
2605 2014-10-16  Brent Fulgham  <bfulgham@apple.com>
2606
2607         [Win] Update DRT to match Mac Logic
2608         https://bugs.webkit.org/show_bug.cgi?id=137787
2609
2610         Reviewed by Dean Jackson.
2611
2612         * DumpRenderTree/win/DumpRenderTree.cpp:
2613         (initialize): 0 -> nullptr
2614         (runTest): Initialize MSG structure before using.
2615         (main): Add CRT debug flags if building DRT with debug malloc on Windows.
2616         Also, cleanly shut down COM when exiting.
2617         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2618         (FrameLoadDelegate::didChangeLocationWithinPageForFrame): Move from
2619         header and add printf to match Mac.
2620         (FrameLoadDelegate::windowScriptObjectAvailable): Ditto.
2621         * DumpRenderTree/win/FrameLoadDelegate.h:
2622         (FrameLoadDelegate::didChangeLocationWithinPageForFrame): Deleted.
2623         (FrameLoadDelegate::windowScriptObjectAvailable): Deleted.
2624         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
2625         (isLocalhost): Added.
2626         (hostIsUsedBySomeTestsToGenerateError): Added.
2627         (ResourceLoadDelegate::willSendRequest): Add logic to mimic Mac's use
2628         of certain error and redirect host names.
2629         * DumpRenderTree/win/UIDelegate.cpp:
2630         (UIDelegate::runJavaScriptAlertPanelWithMessage): Use 'done' flag to decide if
2631         anything should be output to the console. This modifies behavior to match the Mac.
2632         (UIDelegate::runJavaScriptConfirmPanelWithMessage): Ditto.
2633         (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Ditto.
2634         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage): Ditto.
2635         (UIDelegate::webViewAddMessageToConsole): Ditto.
2636         * WinLauncher/PageLoadTestClient.cpp:
2637         (PageLoadTestClient::pageLoadEndedAtTime): Drive-by-fix for an assertion that I
2638         added last week.
2639
2640 2014-10-16  Commit Queue  <commit-queue@webkit.org>
2641
2642         Unreviewed, rolling out r174754.
2643         https://bugs.webkit.org/show_bug.cgi?id=137789
2644
2645         Speculative fix for Windows test was ineffective. (Requested
2646         by rfong on #webkit).
2647
2648         Reverted changeset:
2649
2650         "[Windows] Add some more logging to debug Windows test
2651         issues."
2652         http://trac.webkit.org/changeset/174754
2653
2654 2014-10-15  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2655
2656         Unreviewed, add myself to CoordinatedGraphics watchers.
2657
2658         * Scripts/webkitpy/common/config/watchlist:
2659
2660 2014-10-15  Roger Fong  <roger_fong@apple.com>
2661
2662         [Windows] Speculative Windows test fix.
2663
2664         * DumpRenderTree/win/DumpRenderTree.cpp: Make sure that OLEAUT32.dll doesn't cache BSTRs.
2665
2666 2014-10-15  Rebecca Hauck  <rhauck@adobe.com>
2667
2668         import-w3c-test rewrites relative src paths in ref files incorrectly
2669         https://bugs.webkit.org/show_bug.cgi?id=137586
2670
2671         This patch fixes a bug in test_converter.py where src paths were getting 
2672         rewritten as ../../some-path instead of <script src="../../some-path>". 
2673         It also adds support for rewriting src paths in style  elements, which was 
2674         missing before and it adds tests for this case.
2675
2676         Reviewed by Bem Jones-Bey.
2677
2678         * Scripts/webkitpy/w3c/test_converter.py:
2679         (_W3CTestConverter.convert_attributes_if_needed):
2680         * Scripts/webkitpy/w3c/test_converter_unittest.py:
2681         (test_convert_attributes_if_needed):
2682         (verify_reference_relative_paths):
2683
2684 2014-10-15  Jake Nielsen  <jacob_nielsen@apple.com>
2685
2686         Add --json flag to test-webkitpy to emit JSON formatted test results
2687         to stdout
2688         https://bugs.webkit.org/show_bug.cgi?id=137353
2689
2690         Reviewed by Daniel Bates.
2691
2692         * Scripts/webkitpy/port/server_process_unittest.py:
2693         Adds the read method to MockFile to allow the stdout of test_webkitpy
2694         to be redirected without causing erroneous test failures.
2695         In particular,
2696         webkitpy.port.server_process_unittest.TestServerProcess.test_broken_pipe
2697         and
2698         webkitpy.port.server_process_unittest.TestServerProcess.test_cleanup
2699         because when redirecting to a file, the
2700         _wait_for_data_and_update_buffers_using_select method in 
2701         server_process.py will find that there is a read file descriptor in
2702         its call to select.select, which eventually leads to it calling read()
2703         on the MockFile object.
2704         (MockFile.read):
2705         * Scripts/webkitpy/test/main.py:
2706         Adds the _print_results_as_json method and the --json flag which
2707         determines whether _print_results_as_json will get called.
2708         (Tester._parse_args):
2709         (Tester._print_results_as_json):
2710         (Tester._print_results_as_json.result_dict_from_tuple):
2711         (Tester._run_tests):
2712
2713 2014-10-13  David Farler  <dfarler@apple.com>
2714
2715         [iOS] LayoutTestRelay: Detect broken pipe when reading simulator app's stdout and stderr.
2716         https://bugs.webkit.org/show_bug.cgi?id=137662
2717
2718         Reviewed by Darin Adler.
2719
2720         The layout test harness can close LayoutTestRelay's subprocess
2721         stdout and stderr in the case of a timeout or if a run is
2722         cancelled and the FIFOs are cleaned up. If LayoutTestRelay
2723         finds that no one is listening to its stdout/stderr (broken
2724         pipe), then just exit(1), there is nothing to report.
2725
2726         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
2727         (-[LTRelayController didReceiveStdoutData:]):
2728         Add @try/@catch for NSFileHandleOperationException.
2729         (-[LTRelayController didReceiveStderrData:]):
2730         Add @try/@catch for NSFileHandleOperationException.
2731
2732 2014-10-15  Rohit Kumar  <kumar.rohit@samsung.com>
2733
2734         [GTK] Minibrowser : Add keyboard support for zoom in , zoom out and default zoom in GTK Minibrowser
2735         https://bugs.webkit.org/show_bug.cgi?id=137060
2736
2737         Reviewed by Philippe Normand.
2738
2739         Add keyboard support for zoom in , zoom out and default zoom using 'Ctrl' + '+', 'Ctrl' + '-' and 'Ctrl' + '0' respectively.
2740
2741         * MiniBrowser/gtk/BrowserWindow.c:
2742         (zoomInCallback):
2743         (zoomOutCallback):
2744         (defaultZoomCallback): Callback for default zoom keyboard support.
2745         (browser_window_init):
2746
2747 2014-10-14  Simon Fraser  <simon.fraser@apple.com>
2748
2749         [Mac] DRT stderr logging after the test completes gets attributed to the next test
2750
2751         Reviewed by Alexey Proskuryakov.
2752         
2753         DRT would send "#EOF" to stderr just after doing so to stdout, which cause any later
2754         logging to stderr to get associated with the next test.
2755         
2756         Fix by logging #EOF to stderr later, after we've completely finished with this test.
2757
2758         * DumpRenderTree/mac/DumpRenderTree.mm:
2759         (dumpTestResults):
2760         (runTest):
2761
2762 2014-10-14  Brent Fulgham  <bfulgham@apple.com>
2763
2764         [Win] Unreviewed gardening. Ignore Visual Studio *.sdf temporary files.
2765
2766         * DumpRenderTree/DumpRenderTree.vcxproj: Modified property svn:ignore.
2767
2768 2014-10-14  Csaba Osztrogonác  <ossy@webkit.org>
2769
2770         [cmake] Fix the make build after r174683
2771         https://bugs.webkit.org/show_bug.cgi?id=137703
2772
2773         Reviewed by Martin Robinson.
2774
2775         * Scripts/webkitdirs.pm:
2776         (buildCMakeGeneratedProject):
2777
2778 2014-10-14  Myles C. Maxfield  <mmaxfield@apple.com>
2779
2780         Adding myself to the watchlist to CachedFont
2781
2782         Unreviewed.
2783
2784         * Scripts/webkitpy/common/config/watchlist:
2785
2786 2014-10-14  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2787
2788         [EFL][GTK] Make it possible to get verbose output with ninja
2789         https://bugs.webkit.org/show_bug.cgi?id=137606
2790
2791         Reviewed by Csaba Osztrogonác.
2792
2793         * Scripts/webkitdirs.pm:
2794         (buildCMakeGeneratedProject):
2795
2796 2014-10-14  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2797
2798         [EFL] Make it possible to use ninja for EFL build too
2799         https://bugs.webkit.org/show_bug.cgi?id=137605
2800
2801         Reviewed by Csaba Osztrogonác.
2802
2803         * Scripts/webkitdirs.pm:
2804         (generateBuildSystemFromCMakeProject):
2805         * efl/install-dependencies:
2806
2807 2014-10-14  Rohit Kumar  <kumar.rohit@samsung.com>
2808
2809         [GTK] Minibrowser : Add home buton and keyboard support for home page load
2810         https://bugs.webkit.org/show_bug.cgi?id=137486
2811
2812         Reviewed by Philippe Normand.
2813
2814         * MiniBrowser/gtk/BrowserWindow.c:
2815         (loadHomePage): Callback for home page load.
2816         (browser_window_init):
2817         * MiniBrowser/gtk/BrowserWindow.h:
2818         * MiniBrowser/gtk/main.c:
2819         (main):
2820
2821 2014-10-14  Manuel Rego Casasnovas  <rego@igalia.com>
2822
2823         import-w3c-tests doesn't prefix property values
2824         https://bugs.webkit.org/show_bug.cgi?id=137600
2825
2826         Reviewed by Bem Jones-Bey.
2827
2828         Some property values are prefixed in WebKit. Modified the W3C import
2829         script in order to prefix property values and not only properties.
2830         The patch re-uses most of the already existent logic to prefix
2831         properties.
2832
2833         * Scripts/webkitpy/w3c/test_converter.py: Read prefixed property values
2834         from CSSValueKeywords.in and adapt converter to modify both properties
2835         and property values.
2836         (convert_for_webkit):
2837         (_W3CTestConverter.__init__):
2838         (_W3CTestConverter.output):
2839         (_W3CTestConverter.read_webkit_prefixed_css_property_list):
2840         (_W3CTestConverter):
2841         (_W3CTestConverter.add_webkit_prefix_to_unprefixed_properties_and_values):
2842         (_W3CTestConverter.add_webkit_prefix_following_regex):
2843         (_W3CTestConverter.convert_reference_relpaths):
2844         (_W3CTestConverter.convert_style_data):
2845         (_W3CTestConverter.convert_attributes_if_needed):
2846         (_W3CTestConverter.add_webkit_prefix_to_unprefixed_properties): Deleted.
2847         * Scripts/webkitpy/w3c/test_converter_unittest.py: Updated unit test to
2848         include checks for property values too.
2849         (W3CTestConverterTest.test_read_prefixed_property_list):
2850         (verify_no_conversion_happened):
2851         (verify_prefixed_properties):
2852         (verify_prefixed_property_values):
2853         (generate_test_content_properties_and_values):
2854         (generate_test_content):
2855         * Scripts/webkitpy/w3c/test_importer.py: Modified importer to manage
2856         prefixed property values and inform about them.
2857         (TestImporter.import_tests):
2858         (TestImporter.write_import_log):
2859
2860 2014-10-13  Jer Noble  <jer.noble@apple.com>
2861
2862         MediaPlayer::characteristicChanged() is not called when new tracks are found in SourceBufferPrivateAVFObjC
2863         https://bugs.webkit.org/show_bug.cgi?id=137533
2864
2865         Reviewed by Andy Estes.
2866
2867         Follow up patch; bail out of the test early (without failing) if the platform does not support MSE.
2868
2869         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
2870         (TestWebKitAPI::isMSEEnabledCallback):
2871         (TestWebKitAPI::TEST):
2872
2873 2014-10-13  Brent Fulgham  <bfulgham@apple.com>
2874
2875         [Win] Implement a page load profiling tool
2876         https://bugs.webkit.org/show_bug.cgi?id=137673
2877
2878         Reviewed by Dean Jackson.
2879
2880         Add a tool to capture and summarize page load statistics.
2881
2882         * WinLauncher/Common.cpp:
2883         (parseCommandLine): Move from WinMain.cpp so that it can
2884         be shared with internal tools.
2885         * WinLauncher/PageLoadTestClient.cpp: Added.
2886         (PageLoadTestClient::PageLoadTestClient):
2887         (PageLoadTestClient::pageLoadStartedAtTime):
2888         (PageLoadTestClient::didStartProvisionalLoad):
2889         (PageLoadTestClient::didCommitLoad):
2890         (PageLoadTestClient::didFirstLayoutForMainFrame):
2891         (PageLoadTestClient::didHandleOnLoadEvents):
2892         (PageLoadTestClient::didFinishLoad):
2893         (PageLoadTestClient::didFailLoad):
2894         (PageLoadTestClient::didInitiateResourceLoad):
2895         (PageLoadTestClient::didEndResourceLoad):
2896         (PageLoadTestClient::pageLoadEndedAtTime):
2897         (PageLoadTestClient::endPageLoad):
2898         (PageLoadTestClient::clearPageLoadState):
2899         (PageLoadTestClient::shouldConsiderPageLoadEnded):
2900         (PageLoadTestClient::maybeEndPageLoadSoon):
2901         (PageLoadTestClient::setPageURL):
2902         (PageLoadTestClient::dumpRunStatistics):
2903         * WinLauncher/PrintWebUIDelegate.cpp:
2904         (PrintWebUIDelegate::createWebViewWithRequest): Handle
2905         nullptr URL properly.
2906         * WinLauncher/ResourceLoadDelegate.cpp: Added.
2907         (ResourceLoadDelegate::QueryInterface):
2908         (ResourceLoadDelegate::AddRef):
2909         (ResourceLoadDelegate::Release):
2910         (ResourceLoadDelegate::identifierForInitialRequest):
2911         (ResourceLoadDelegate::willSendRequest):
2912         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
2913         (ResourceLoadDelegate::didCancelAuthenticationChallenge):
2914         (ResourceLoadDelegate::didReceiveResponse):
2915         (ResourceLoadDelegate::didReceiveContentLength):
2916         (ResourceLoadDelegate::didFinishLoadingFromDataSource):
2917         (ResourceLoadDelegate::didFailLoadingWithError):
2918         (ResourceLoadDelegate::plugInFailedWithError):
2919         * WinLauncher/ResourceLoadDelegate.h: Added.
2920         (ResourceLoadDelegate::ResourceLoadDelegate):
2921         * WinLauncher/WinLauncher.cpp:
2922         (WinLauncher::WinLauncher): Accept argument to indicate we want to capture
2923         page loading statistics.
2924         (WinLauncher::setFrameLoadDelegatePrivate): Get rid of stub implementation
2925         and set private load delegate state.
2926         (WinLauncher::setResourceLoadDelegate): Replace stub with a full implementation
2927         that sets the view's resource load delegate.
2928         (WinLauncher::loadURL): If no URL is passed, load the test document.
2929         * WinLauncher/WinLauncher.h:
2930         (WinLauncher::pageLoadTestClient):
2931         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Updated for new source files.
2932         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters: Ditto.
2933         * WinLauncher/WinLauncherWebHost.cpp:
2934         (WinLauncherWebHost::updateAddressBar): Hook into page load statistics routine.
2935         (WinLauncherWebHost::loadURL): Moved 'SendMessage' call to its own method so that
2936         it could be used from other source files.
2937         (WinLauncherWebHost::didFinishLoadForFrame): Added overload to capture statistics.
2938         (WinLauncherWebHost::didStartProvisionalLoadForFrame): Ditto.
2939         (WinLauncherWebHost::didFailLoadWithError): Ditto.
2940         (WinLauncherWebHost::didHandleOnloadEventsForFrame): Ditto.
2941         (WinLauncherWebHost::didFirstLayoutInFrame): Ditto.
2942         (WinLauncherWebHost::didFinishDocumentLoadForFrame): Ditto.
2943         (WinLauncherWebHost::didFirstVisuallyNonEmptyLayoutInFrame): Ditto.
2944         (WinLauncherWebHost::didStartProvisionalLoadForFrame): Deleted.
2945         * WinLauncher/WinLauncherWebHost.h:
2946         * WinLauncher/WinMain.cpp:
2947         (wWinMain): Create and use new delegates for gathering page load data.
2948         * WinLauncher/stdafx.h: Need to add <wtf/Platform> include for various macros used in build.
2949
2950 2014-10-13  Simon Fraser  <simon.fraser@apple.com>
2951
2952         Improve the test image diffs page
2953         https://bugs.webkit.org/show_bug.cgi?id=137674
2954
2955         Reviewed by Alexey Proskuryakov.
2956         
2957         Don't treat the input file as a format string, otherwise we have to escape special
2958         characters. Just do a couple of replaces.
2959
2960         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2961         (TestResultWriter.write_image_diff_files):
2962
2963 2014-10-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2964
2965         [XvfbDriver] Regular expression used to match running X servers fails on Fedora 21.
2966         https://bugs.webkit.org/show_bug.cgi?id=137659
2967
2968         Reviewed by Martin Robinson.
2969
2970         * Scripts/webkitpy/port/xvfbdriver.py:
2971         (XvfbDriver._next_free_display): Update the regular expression to also match Xorg.bin
2972
2973 2014-10-13  Alexey Proskuryakov  <ap@apple.com>
2974
2975         Add more detailed wait time information to EWS metrics
2976         https://bugs.webkit.org/show_bug.cgi?id=137649
2977
2978         Reviewed by Daniel Bates.
2979
2980         Added average and worst time (we used to only have median), and also a percentage
2981         of patches that took a non-trivial time to start. Non-trivial is defined as 3 minutes.
2982
2983         There is always some wait due to the polling nature of the queues, which is well understood
2984         and doesn't need to be measured. What needs to be measured is whether there is enough
2985         bot machines to process patches as soon as they are submitted.
2986
2987         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
2988         (Analyzer.prototype._analyzeBubblePerformance):
2989         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsBubbleView.js:
2990         (MetricsBubbleView.prototype._update):
2991
2992 2014-10-11  Jer Noble  <jer.noble@apple.com>
2993
2994         MediaPlayer::characteristicChanged() is not called when new tracks are found in SourceBufferPrivateAVFObjC
2995         https://bugs.webkit.org/show_bug.cgi?id=137533
2996
2997         Reviewed by Darin Adler.
2998
2999         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3000         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
3001         (TestWebKitAPI::TEST):
3002         * TestWebKitAPI/Tests/WebKit2/file-with-mse.html: Added.
3003         * TestWebKitAPI/Tests/WebKit2/test-mse.mp4: Added.
3004
3005 2014-10-13  Simon Fraser  <simon.fraser@apple.com>
3006
3007         iOS DRT snapshots are limited to the page visible area
3008         https://bugs.webkit.org/show_bug.cgi?id=137650
3009
3010         Reviewed by Daniel Bates.
3011         
3012         LegacyTileCache drawing was limited to the window's visible area, found by
3013         crawling up the layer hierarchy to the root layer. This caused test snapshots to
3014         be missing non-composited content outside the iPhone visible area, which hinders
3015         testing.
3016         
3017         Fix by adding a test-only mode where the window visible area is the entire window.
3018         
3019         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
3020         (dumpWebViewAsPixelsAndCompareWithExpected): Drive-by RetainPtr fix.
3021         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
3022         (-[DumpRenderTreeWindow initWithLayer:]): Call setEntireWindowVisibleForTesting:YES
3023         for the DRT window.
3024         
3025
3026 2014-10-12  Simon Fraser  <simon.fraser@apple.com>
3027
3028         Page not fully rendered in iOS DRT snapshots
3029         https://bugs.webkit.org/show_bug.cgi?id=137638
3030
3031         Reviewed by Tim Horton.
3032         
3033         In iOS DumpRenderTree, we need to wait for a cycle of the WebThread runloop
3034         to ensure that the page has laid out and is rendered by the time we take
3035         the snapshot.
3036
3037         * DumpRenderTree/mac/DumpRenderTree.mm:
3038         (-[DumpRenderTree _webThreadEventLoopHasRun]): Moved.
3039         (-[DumpRenderTree _webThreadInvoked]): Moved.
3040         (-[DumpRenderTree _waitForWebThreadThenDump]):
3041         (dump): Use a performSelectorOnMainThread:withObject:waitUntilDone:NO to wait
3042         for a cycle of the WebThrewd runloop. We can't just call _waitForWebThread because
3043         that blocks on a delegate callback, and we can't dispatch_async because _waitForWebThread
3044         relies on dispatch_async too, and the inner block won't complete until the outer block
3045         has completed.
3046         (dumpTestResults): Move the guts of dump() here.
3047         (runTest): Whitespace.
3048
3049 2014-10-12  Alexey Proskuryakov  <ap@apple.com>
3050
3051         Adding svn:ignore so that .pyc files don't show up as new.
3052
3053         * Scripts/webkitpy/xcode: Added property svn:ignore.
3054
3055 2014-10-12  Ryuan Choi  <ryuan.choi@gmail.com>
3056
3057         [EFL] Introduce EWebKit_Extension
3058         https://bugs.webkit.org/show_bug.cgi?id=134921
3059
3060         Reviewed by Gyuyoung Kim.
3061
3062         * MiniBrowser/efl/main.c: Added x option to test extension path.
3063         (window_create):
3064         (elm_main):
3065         * Scripts/webkitpy/common/config/watchlist:
3066         Added Source/WebKit2/WebProcess/InjectedBundle/API/efl/ into EFLWebKit2PublicAPI.
3067         * Scripts/webkitpy/style/checker.py:
3068         Added Source/WebKit2/WebProcess/InjectedBundle/API/efl/ into EFL exceptions.
3069
3070 2014-10-11  Simon Fraser  <simon.fraser@apple.com>
3071
3072         After r174628 we send the test process a SIGTERM before the SIGKILL.
3073
3074         * Scripts/webkitpy/common/system/executive_unittest.py:
3075         (ExecutiveTest.serial_test_kill_process):
3076
3077 2014-10-11  KwangHyuk Kim  <hyuki.kim@samsung.com>
3078
3079         [EFL] Enable WebP support.
3080         https://bugs.webkit.org/show_bug.cgi?id=136156
3081
3082         Reviewed by Gyuyoung Kim.
3083
3084         Include libwebp-dev package to support WebP for WK2 Efl.
3085
3086         * efl/install-dependencies:
3087
3088 2014-10-11  Carlos Garcia Campos  <cgarcia@igalia.com>
3089
3090         [GLIB] Split GMainLoopSource moving thread safe implementation to its own class GThreadSafeMainLoopSource
3091         https://bugs.webkit.org/show_bug.cgi?id=137485
3092
3093         Reviewed by Sergio Villar Senin.
3094
3095         Update GMainLoopSource tests. Most of the tests are now run twice,
3096         first with a GMainLoopSource and then with a
3097         GThreadSafeMainLoopSource, since both should have the same
3098         behaviour. The threading test uses GThreadSafeMainLoopSource and
3099         the delete on destroy test uses GMainLoopSource. The tests
3100         themselves haven't changed, since there's no change in behaviour.
3101
3102         * TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp:
3103         (TestWebKitAPI::GMainLoopSourceTest::source):
3104         (TestWebKitAPI::basicRescheduling):
3105         (TestWebKitAPI::TEST):
3106         (TestWebKitAPI::reentrantRescheduling):
3107         (TestWebKitAPI::cancelRepeatingSourceDuringDispatch):
3108         (TestWebKitAPI::basicDestroyCallbacks):
3109         (TestWebKitAPI::destroyCallbacksAfterCancellingDuringDispatch):
3110         (TestWebKitAPI::destroyCallbacksAfterReschedulingDuringDispatch):
3111
3112 2014-10-10  Dana Burkart  <dburkart@apple.com>
3113
3114         Fix fat-fingered function name in git-add-reviewer.
3115
3116         Unreviewed.
3117
3118         * Scripts/git-add-reviewer:
3119         (getConfigValue):
3120
3121 2014-10-10  David Farler  <dfarler@apple.com>
3122
3123         [iOS] LayoutTestRelay should ensure its DRT/WKTR dies when receiving kill/term signals
3124         https://bugs.webkit.org/show_bug.cgi?id=137528
3125
3126         Reviewed by Simon Fraser.
3127
3128         Catch SIGINT and SIGTERM signals in the LayoutTestRelay
3129         and SIGKILL the paired simulator app before exiting cleanly.
3130
3131         webkitpy only uses SIGKILL to kill processes which you cannot
3132         catch. Send SIGTERM to the process and give it chance to do
3133         its thing before sending SIGKILL. Sending a SIGKILL to an already
3134         dead PID is safe.
3135
3136         * LayoutTestRelay/LayoutTestRelay/LTRelayController.h:
3137         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
3138         (-[LTRelayController finish]):
3139         * LayoutTestRelay/LayoutTestRelay/main.m:
3140         (receivedSignal):
3141         (main):
3142
3143 2014-10-10  David Farler  <dfarler@apple.com>
3144
3145         [iOS] LayoutTestRelay should detect EOF and properly signal underlying DRT/WKTR
3146         https://bugs.webkit.org/show_bug.cgi?id=137527
3147
3148         Reviewed by Simon Fraser.
3149
3150         NSFileHandle doesn't notify of EOF in its readability handler.
3151         Use a dispatch_source_t and an event handler that is called when reading is possible.
3152         In the handler block, do a run-of-the-mill read(2) from standard input and
3153         detect EOF in the usual way by checking that zero bytes were read.
3154
3155         Once an EOF is received, the FIFOs are disconnected, the simulator app
3156         is killed, and the relay exits with status 0.
3157
3158         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
3159         (-[LTRelayController initWithDevice:productDir:appPath:identifierSuffix:dumpToolArguments:]):
3160         (-[LTRelayController didDisconnect]):
3161         (-[LTRelayController didConnect]):
3162         (-[LTRelayController launchApp]):
3163         Rename "dispatchSource" to "simulatorAppExitDispatchSource" to prevent any
3164         confusion with this new dispatch source, called "standardInputDispatchSource".
3165         (-[LTRelayController finish]): Added.
3166         (-[LTRelayController readFileHandle:]): Deleted.
3167
3168 2014-10-10  KwangHyuk Kim  <hyuki.kim@samsung.com>
3169
3170         [EFL] Crash on facebook.com
3171         https://bugs.webkit.org/show_bug.cgi?id=137562
3172
3173         Reviewed by Chris Dumez.
3174
3175         Crash occurs on the facebook.com when the webview is resized
3176         after the <select> item is clicked but no item is chosen.
3177         This crash is just caused by the reference of invalidated variable.
3178         From the EwkView::closePopupMenu(), ewk_menu is just invalidated.
3179         Therefore ewk_menu variable is not available anymore when on_popup_menu_hide()
3180         on MiniBrowser is called.
3181         As a result, just set ewk_menu to NULL in order to prevent crash condition.
3182
3183         * MiniBrowser/efl/main.c:
3184         (on_popup_menu_hide):
3185
3186 2014-10-10  Alexey Proskuryakov  <ap@apple.com>
3187
3188         A small wording change for clarity.
3189
3190         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsBubbleView.js:
3191         (MetricsBubbleView.prototype._update):
3192
3193 2014-10-10  Alexey Proskuryakov  <ap@apple.com>
3194
3195         Dashboard metrics page should have EWS statistics
3196         https://bugs.webkit.org/show_bug.cgi?id=137626
3197
3198         Reviewed by Ryosuke Niwa.
3199
3200         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueue.js:
3201         (BubbleQueue): Put shortName in the object, so that it's actually useful.
3202
3203         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3204         (BubbleQueueServer): Re-ordered queues to match bubble order.
3205         (BubbleQueueServer.prototype.jsonProcessingTimesURL): Added URL for the new handler.
3206         (BubbleQueueServer.prototype.loadProcessingTimes): Load the data from webkit-queues.
3207
3208         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
3209         Added analysis for bubble queues.
3210
3211         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsBubbleView.js: Added.
3212
3213         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
3214         (buildBubbleQueuesTable): Build the UI.
3215
3216         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/metrics.html:
3217         Added JS sources to load.
3218
3219         * QueueStatusServer/app.yaml: To update app version.
3220
3221         * QueueStatusServer/handlers/processingtimesjson.py: Added.
3222
3223         * QueueStatusServer/main.py: Added a handler for processing-times-json.
3224
3225 2014-10-10  Alexey Proskuryakov  <ap@apple.com>
3226
3227         REGRESSION: Commit queue doesn't process rollouts
3228         https://bugs.webkit.org/show_bug.cgi?id=137623
3229
3230         Reviewed by Tim Horton.
3231
3232         * QueueStatusServer/app.yaml:
3233         * QueueStatusServer/handlers/updateworkitems.py:
3234         (UpdateWorkItems._work_items_from_request):
3235
3236 2014-10-10  Simon Fraser  <simon.fraser@apple.com>
3237
3238         Fix syntax error after r174601.
3239
3240         * Scripts/run-javascriptcore-tests:
3241
3242 2014-10-10  Michael Saboff  <msaboff@apple.com>
3243
3244         Add ability to select tarfile name in run-jsc-stress-tests
3245         https://bugs.webkit.org/show_bug.cgi?id=137614
3246
3247         Reviewed by Mark Hahnenberg.
3248
3249         Added optional file name argument to the --tarball option.  
3250
3251         * Scripts/run-javascriptcore-tests: Added "--" to terminate options so the first
3252         extra test given after the options wont be used for the optional tarball file name.
3253         * Scripts/run-jsc-stress-tests:
3254
3255 2014-10-10  Chris Dumez  <cdumez@apple.com>
3256
3257         Unreviewed, update my information in contributors.json
3258
3259         Use my preferred first name and update my expertise areas.
3260
3261         * Scripts/webkitpy/common/config/contributors.json:
3262
3263 2014-10-10  Adrien Destugues  <pulkomandy@gmail.com>
3264
3265         Fix perl scripts to run with env on Linux
3266         https://bugs.webkit.org/show_bug.cgi?id=137601
3267
3268         Reviewed by Csaba Osztrogonác.
3269
3270         Use of arguments in #! is nonstandard and does not behave the same on
3271         different systems. Linux would look for an executable named "perl -w" 
3272         "use warnings;" does the same things in a more portable way.
3273
3274         * Scripts/commit-log-editor:
3275         * Scripts/num-cpus:
3276         * Scripts/prepare-ChangeLog:
3277         * Scripts/run-launcher:
3278         * Scripts/svn-create-patch:
3279
3280 2014-10-10  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
3281
3282         [jhbuild] We should be able to disable wiping on configuration change
3283         https://bugs.webkit.org/show_bug.cgi?id=137446
3284
3285         Reviewed by Csaba Osztrogonác.
3286
3287         The default behaviour isn't changed, wiping on configuration change feature can be disabled with
3288         setting JHBUILD_WIPE_ON_CHANGE=0 environment variable
3289         or passing --no-wipe-on-change command line option.
3290
3291         * Scripts/update-webkit-libs-jhbuild:
3292
3293 2014-10-09  Andy Estes  <aestes@apple.com>
3294
3295         Teach webkitpy about OS X Yosemite
3296         https://bugs.webkit.org/show_bug.cgi?id=137585
3297
3298         Reviewed by Simon Fraser.
3299
3300         * Scripts/webkitpy/common/system/platforminfo.py:
3301         (PlatformInfo._determine_mac_version):
3302         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
3303         (TestPlatformInfo.test_os_version):
3304         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3305         (TestExpectationParser):
3306         * Scripts/webkitpy/port/builders.py:
3307         * Scripts/webkitpy/port/mac.py:
3308         (MacPort):
3309         * Scripts/webkitpy/port/mac_unittest.py:
3310         (test_versions):
3311         (test_baseline_search_path):
3312         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3313         (TestRebaselineTest.test_baseline_directory):
3314         (TestRebaselineExpectations.test_rebaseline_expectations):
3315
3316 2014-10-09  Dana Burkart  <dburkart@apple.com>
3317
3318         Add Mac OS Yosemite dashboard support.
3319
3320         Rubber-stamped by Lucas Forschler.
3321
3322         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Yosemite.png: Added.
3323         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Yosemite@2x.png: Added.
3324         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3325         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3326         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3327
3328 2014-10-08  Ryosuke Niwa  <rniwa@webkit.org>
3329
3330         Add Babak to contributors.json and add historical email addresses for some contributors
3331         https://bugs.webkit.org/show_bug.cgi?id=137546
3332
3333         Reviewed by Christophe Dumez.
3334
3335         contributors.json is used to analyze historical commit data and change logs.
3336
3337         Add back historical email addresses for some contributors and also add Babak (Shafiei).
3338
3339         * Scripts/webkitpy/common/config/contributors.json:
3340
3341 2014-10-09  Lucas Forschler  <lforschler@apple.com>
3342
3343         Add Mac OS Yosemite webkit build infrastructure.
3344         
3345         This patch adds 15 bots to our build.webkit.org configuration.
3346         We are matching the current Mavericks machines 1:1.
3347         
3348         This patch includes some minor spacing changes to the buildslaves section to make everything similar.
3349         
3350         Reviewed by Matt Hanson.
3351
3352         * BuildSlaveSupport/build.webkit.org-config/config.json:
3353
3354 2014-10-09  Dana Burkart  <dburkart@apple.com>
3355
3356         Don't use backticks when running commands, as we run into sh-related
3357         interpolation issues. Also, fix our usage of system() to properly
3358         retrieve the status code.
3359         https://bugs.webkit.org/show_bug.cgi?id=137541
3360
3361         Reviewed by Darin Adler.
3362
3363         * Scripts/git-add-reviewer:
3364         (interactive):
3365         (nonInteractive):
3366         (requireCleanWorkTree):
3367         (cherryPick):
3368         (commit):
3369         (addReviewerToFile):
3370         (head):
3371         (isAncestor):
3372         (toCommit):
3373         (changeLogsForCommit):
3374         (resetToCommit):
3375         (getConfigValue):
3376         (runCommandWithOutput):
3377
3378 2014-10-09  Tim Horton  <timothy_horton@apple.com>
3379
3380         Add a WebKit1 preference for selection services
3381         https://bugs.webkit.org/show_bug.cgi?id=137498
3382         <rdar://problem/18572699>
3383
3384         Reviewed by Simon Fraser.
3385
3386         * MiniBrowser/mac/WK1BrowserWindowController.m:
3387         (-[WK1BrowserWindowController awakeFromNib]):
3388         Turn on image and selection services in the Legacy WebKit MiniBrowser.
3389
3390 2014-10-09  Adrien Destugues  <pulkomandy@gmail.com>
3391
3392         Get the patch scripts running on Haiku
3393         https://bugs.webkit.org/show_bug.cgi?id=137559
3394
3395         Reviewed by Benjamin Poulain.
3396
3397         Use /usr/bin/env instead of hardcoding path to perl.
3398         Declare haiku platform in platforminfo.py to avoid check-webkit-style
3399         failure.
3400
3401         * Scripts/commit-log-editor:
3402         * Scripts/num-cpus:
3403         * Scripts/prepare-ChangeLog:
3404         * Scripts/run-launcher:
3405         * Scripts/svn-create-patch:
3406         * Scripts/webkitpy/common/system/platforminfo.py:
3407         (PlatformInfo._determine_os_name):
3408
3409 2014-10-08  Jake Nielsen  <jacob_nielsen@apple.com>
3410
3411         StyleQueue should throw a PatchIsNotValid exception to achieve
3412         consistency with CommitQueue and EWS
3413         https://bugs.webkit.org/show_bug.cgi?id=137500
3414
3415         Reviewed by Alexey Proskuryakov.
3416
3417         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
3418         Adds a call to validate() in run().
3419         (StyleQueueTask.run):
3420         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3421         Adds a return False in the patch is not valid exception statement.
3422         (AbstractEarlyWarningSystem.review_patch):
3423         * Scripts/webkitpy/tool/commands/queues.py:
3424         Adds a return False in the patch is not valid exception statement in
3425         commit queue, and adds an except statement to catch PatchIsNotValid
3426         exceptions in style queue.
3427         (CommitQueue.process_work_item):
3428         (StyleQueue.review_patch):
3429
3430 2014-10-08  Carlos Garcia Campos  <cgarcia@igalia.com>
3431
3432         Race condition with WebKitWebView:is-loading after starting page load
3433         https://bugs.webkit.org/show_bug.cgi?id=136692
3434
3435         Reviewed by Gustavo Noronha Silva.
3436
3437         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
3438         (loadChangedCallback): Only check is-loading is false when load
3439         has finished if the load didn't fail due to a cancellation.
3440         (loadFailedCallback): Only check is-loading is false if the load
3441         didn't fail due to a cancellation.
3442         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
3443         (WebViewTest::loadURI): Check is-loading is true and active URI is
3444         the requested one rigth after requesting the load.
3445         (WebViewTest::loadHtml): Ditto.
3446         (WebViewTest::loadPlainText): Ditto.
3447         (WebViewTest::loadBytes): Ditto.
3448         (WebViewTest::loadRequest): Ditto.
3449         (WebViewTest::loadAlternateHTML): Ditto.
3450         (WebViewTest::goBack): Ditto.
3451         (WebViewTest::goForward): Ditto.
3452         (WebViewTest::goToBackForwardListItem): Ditto.
3453
3454 2014-10-08  Brent Fulgham  <bfulgham@apple.com>
3455
3456         [Win] Resolve various static analyzer warnings in Tools.
3457         https://bugs.webkit.org/show_bug.cgi?id=137534
3458
3459         Reviewed by Dean Jackson.
3460
3461         * DumpRenderTree/cg/ImageDiffCG.cpp:
3462         (main): User proper printf specifiers.
3463         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3464         (AccessibilityUIElement::childrenCount): Handle possibility that
3465         gcc_accChildCount returns with an error.
3466         (accessibilityState): Ditto for gcc_accState.
3467         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
3468         (DRTDesktopNotificationPresenter::showDesktopNotification): Use proper
3469         check for return value from 'isHTML'. HRESULT is not a boolean and cannot
3470         be treated as such.
3471         * DumpRenderTree/win/DumpRenderTree.cpp:
3472         (DumpRenderTreeWndProc): Avoid possible infinite loop on teardown caused
3473         by comparing an unsigned value as being greater-than zero.
3474         * DumpRenderTree/win/EditingDelegate.cpp:
3475         (dump): Pass proper character pointer type to printf.
3476         (EditingDelegate::shouldBeginEditingInDOMRange): Ditto.
3477         (EditingDelegate::shouldEndEditingInDOMRange): Ditto.
3478         (EditingDelegate::shouldInsertNode): Ditto.
3479         (EditingDelegate::shouldInsertText): Ditto.
3480         (EditingDelegate::shouldDeleteDOMRange): Ditto.
3481         (EditingDelegate::shouldChangeSelectedDOMRange): Ditto.
3482         (EditingDelegate::shouldApplyStyle): Ditto.
3483         * DumpRenderTree/win/EventSender.cpp:
3484         (beginDragWithFilesCallback): Handle possible error case for GlobalAlloc.
3485         * DumpRenderTree/win/EventSender.h: Add proper declaration for HRESULT to match
3486         system headers.
3487         * DumpRenderTree/win/PixelDumpSupportWin.cpp: Handle possible failure
3488         from CreateDIBSection.
3489         * DumpRenderTree/win/UIDelegate.cpp: Ensure proper type is passed to printf.
3490         * TestWebKitAPI/Tests/WTF/MediaTime.cpp: Get rid of workaround for NaN under
3491         older versions of MSVC we no longer support.
3492         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp: Use proper types and API
3493         for 64-bit builds.
3494         * TestWebKitAPI/TestsController.cpp: Use NeverDestroyed like a good citizen.
3495         * TestWebKitAPI/TestsController.h: Ditto.
3496         * WinLauncher/Common.cpp: Handle possible failure from GetModuleFileName.
3497         * WinLauncher/WinLauncher.cpp: Make order of operations explicit to avoid
3498         performing bitwise | before the comparison is done.
3499
3500 2014-10-08  Ada Chan  <adachan@apple.com>
3501
3502         Add a test for WKPageIsPlayingAudio().
3503         https://bugs.webkit.org/show_bug.cgi?id=137048
3504
3505         Reviewed by Darin Adler.
3506
3507         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3508         Add file-with-video.html, test.mp4, and WKPageIsPlayingAudio.cpp to the project.
3509         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp: Added.
3510         (TestWebKitAPI::nullJavaScriptCallback):
3511         (TestWebKitAPI::didFinishLoadForFrame):
3512         (TestWebKitAPI::isPlayingAudioDidChangeCallback):
3513         (TestWebKitAPI::setUpClients):
3514         (TestWebKitAPI::TEST):
3515         This test loads a page with a video in it. When the page is loaded, we first check that
3516         WKPageIsPlayingAudio() returns false for the page. Then we call a method to start the video.
3517         When the WKPageUIClient::isPlayingAudioDidChange callback gets called, check that WKPageIsPlayingAudio()
3518         now returns true for the page.
3519         * TestWebKitAPI/Tests/WebKit2/file-with-video.html: Added.
3520         * TestWebKitAPI/Tests/WebKit2/test.mp4: Added.
3521         This is a video copied from LayoutTests/media/content.
3522
3523 2014-10-08  Csaba Osztrogonác  <ossy@webkit.org>
3524
3525         [webkitpy] Use python-irclib-0.4.8.tar.gz instead of zip in AutoInstaller
3526         https://bugs.webkit.org/show_bug.cgi?id=137516
3527
3528         Reviewed by Alexey Proskuryakov.
3529
3530         * Scripts/webkitpy/thirdparty/__init__.py:
3531         (AutoinstallImportHook._install_irc):
3532
3533 2014-10-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3534
3535         [GTK] install-dependencies should install libjpeg-turbo on Debian and derivatives.
3536         https://bugs.webkit.org/show_bug.cgi?id=137520
3537
3538         Reviewed by Philippe Normand.
3539
3540         Debian is switching is default JPEG library to libjpeg-turbo <https://wiki.debian.org/LJTTransition#Text>
3541         For other distributions, we are already installing libjpeg-turbo.
3542         So, do the same for Debian and derivatives.
3543
3544         * gtk/install-dependencies: Install libjpeg-dev that depends on the default implementation of libjpeg.
3545
3546 2014-10-08  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3547
3548         [webkitpy] Add back the workaround to replace ZipFile.extractall()
3549         https://bugs.webkit.org/show_bug.cgi?id=137519
3550
3551         Reviewed by Csaba Osztrogonác.
3552
3553         It was removed by <http://trac.webkit.org/changeset/174266>,
3554         because the comment stated it is a workaround for buggy python
3555         2.6.1 which shipped on Snow Leopard. But it turned out the bug
3556         is still valid with python 2.7 shipped on the latest Ubuntu
3557         (12.04 and 14.04) and OS X 10.9.
3558
3559         * Scripts/webkitpy/common/system/autoinstall.py:
3560         (AutoInstaller):
3561         (AutoInstaller._extract_all):
3562         (AutoInstaller._unzip):
3563
3564 2014-10-08  Commit Queue  <commit-queue@webkit.org>
3565
3566         Unreviewed, rolling out r174335.
3567         https://bugs.webkit.org/show_bug.cgi?id=137515
3568
3569         It broke EFL layout test totally (Requested by gyuyoung on
3570         #webkit).
3571
3572         Reverted changeset:
3573
3574         "[EFL] Introduce EWebKit_Extension"
3575         https://bugs.webkit.org/show_bug.cgi?id=134921
3576         http://trac.webkit.org/changeset/174335
3577
3578 2014-10-08  Carlos Garcia Campos  <cgarcia@igalia.com>
3579
3580         [GTK] Make forwarding headers generation depend on source code
3581         https://bugs.webkit.org/show_bug.cgi?id=137394
3582
3583         Reviewed by Philippe Normand.
3584
3585         * TestWebKitAPI/CMakeLists.txt: Add missing dependency rule.
3586         * TestWebKitAPI/PlatformGTK.cmake: Only run
3587         generate-forwarding-headers.pl when source code changes.
3588         * WebKitTestRunner/PlatformGTK.cmake: Ditto.
3589
3590 2014-10-07  Tanay C  <tanay.c@samsung.com>
3591
3592         Remove build warnings in Hashmap API tests
3593         https://bugs.webkit.org/show_bug.cgi?id=137484
3594
3595         Reviewed by Darin Adler.
3596
3597         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
3598         (TestWebKitAPI::TEST): Changed EXPECT_EQ(false, addResult.isNewEntry) to EXPECT_FALSE(addResult.isNewEntry) 
3599
3600 2014-10-07  Jake Nielsen  <jacob_nielsen@apple.com>
3601
3602         Commit queue doesn't drop obsolete patches sometimes
3603         https://bugs.webkit.org/show_bug.cgi?id=137460
3604
3605         Reviewed by Alexey Proskuryakov.
3606
3607         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
3608         Adds another test patch for use in queues_unittest.py.
3609         courtesy of Csaba Osztrogonác <ossy@webkit.org>
3610         (MockBugzilla):
3611         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3612         Raises a PatchIsNotValid exception in the case of validate() returning
3613         false.
3614         (CommitQueueTask.run):
3615         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
3616         Raises a PatchIsNotValid exception in the case of validate() returning
3617         false.
3618         (EarlyWarningSystemTask.run):
3619         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
3620         Defines PatchIsNotValid exception. 
3621         (PatchIsNotValid):
3622         (PatchIsNotValid.__init__):
3623         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3624         Remove call to validate() and instead catches the PatchIsNotValid
3625         exception.
3626         (AbstractEarlyWarningSystem.review_patch):
3627         * Scripts/webkitpy/tool/commands/queues.py:
3628         Adds logic to catch the PatchIsNotValid exception.
3629         (CommitQueue.process_work_item):
3630         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3631         Adds the test_non_valid_patch test to ensure that invalid patches are
3632         handled properly, and don't just result in indefinite spinning.
3633         courtesy of Csaba Osztrogonác <ossy@webkit.org>
3634         (test_non_valid_patch):
3635
3636 2014-10-07  Daniel Bates  <dabates@apple.com>
3637
3638         [iOS] Teach run-webkit-tests to honor TestExpectation file for iOS Simulator 64-bit builds
3639         https://bugs.webkit.org/show_bug.cgi?id=137499
3640
3641         Reviewed by Simon Fraser.
3642
3643         Fixes an issue where the TestExpectation file for the iOS Simulator platform was only
3644         honored when running run-webkit-tests with a 32-bit simulator build of iOS WebKit. We
3645         should honor the TestExpectation file for the iOS Simulator platform for both 32- and 64-
3646         bit simulator builds of iOS WebKit.
3647
3648         * Scripts/webkitpy/port/ios.py:
3649         (IOSSimulatorPort._generate_all_test_configurations):
3650
3651 2014-10-07  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3652
3653         [GTK] jhbuild modules should build xserver with the --without-dtrace option.
3654         https://bugs.webkit.org/show_bug.cgi?id=137482
3655
3656         Reviewed by Martin Robinson.
3657
3658         * gtk/jhbuild.modules: Added --without-dtrace option to xserver jhbuild.modules config.
3659
3660 2014-10-07  Carlos Garcia Campos  <cgarcia@igalia.com>
3661
3662         [SOUP] TLS errors should take precedence over HTTP authentication
3663         https://bugs.webkit.org/show_bug.cgi?id=137300
3664
3665         Reviewed by Sergio Villar Senin.
3666
3667         Add a test case to check that authenticate signal is not emitted
3668         in case of TLS errors, and the load fails instead.
3669
3670         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
3671         (webViewAuthenticationCallback):
3672         (testTLSErrorsHTTPAuth):
3673         (httpsServerCallback):
3674         (beforeAll):
3675
3676 2014-10-06  Ryosuke Niwa  <rniwa@webkit.org>
3677
3678         Make webkit-patch find-users useful
3679         https://bugs.webkit.org/show_bug.cgi?id=137475
3680
3681         Reviewed by Alexey Proskuryakov.
3682
3683         Make find-users use the CommitterList instead of accessing Bugzilla.
3684
3685         This essentially exposes the same functionality as webkitbot's whois command.
3686
3687         * Scripts/webkitpy/tool/commands/findusers.py:
3688         (FindUsers.execute):
3689
3690 2014-10-06  Chris Fleizach  <cfleizach@apple.com>
3691
3692         AX: iOS8: Crash at -[WebAccessibilityObjectWrapper accessibilityElementAtIndex:]
3693         https://bugs.webkit.org/show_bug.cgi?id=137289
3694
3695         Unreviewed build fix.
3696
3697         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3698         (AccessibilityUIElement::getChildrenWithRange):
3699
3700 2014-10-06  Alexey Proskuryakov  <ap@apple.com>
3701
3702         build.webkit.org/dashboard: Add commit queue
3703         https://bugs.webkit.org/show_bug.cgi?id=137462
3704
3705         Reviewed by Tim Horton.
3706
3707         Generalizes EWS into "bubble queue", which also includes commit queue and style queue.
3708         Style queue is still invisible, as it doesn't have an associated platform, and also
3709         we never have problems with it anyway, so it's not worth watching.
3710
3711         The UI now allows for adding more bots to the Other column (such as leaks bot).
3712         To make that actually happen, we'll need to refactor QueueView, allowing for multiple
3713         sources of data in a cell.
3714
3715         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueue.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js.
3716         (BubbleQueue):
3717         (BubbleQueue.prototype.get statusPageURL):
3718         (BubbleQueue.prototype.update):
3719         (BubbleQueue.prototype.loadDetailedStatus):
3720         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js.
3721         (BubbleQueueServer):
3722         (BubbleQueueServer.prototype.jsonQueueLengthURL):
3723         (BubbleQueueServer.prototype.jsonQueueStatusURL):
3724         (BubbleQueueServer.prototype.queueStatusURL):
3725         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueView.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js.
3726         (BubbleQueueView):
3727         (BubbleQueueView.prototype.update.appendQueue):
3728         (BubbleQueueView.prototype.update):
3729         (BubbleQueueView.prototype._addQueueHeadingToPopover):
3730         (BubbleQueueView.prototype._popoverContentForBubbleQueue):
3731         (BubbleQueueView.prototype._presentPopoverForBubbleQueue):
3732         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js: Removed.
3733         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js: Removed.
3734         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js: Removed.
3735         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
3736         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
3737         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
3738         (.bubble-server-popover .popover-queue-heading .queue-charts-link):
3739         (.bubble-server-popover .latest-status-no-link):
3740         (.bubble-server-popover .bot-status-description):
3741         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
3742
3743         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
3744         (buildAggregateTable):
3745         (buildQueuesTable):
3746         Removed dysfunctional support for EWS for now. It will be different.
3747
3748 2014-10-06  Alexey Proskuryakov  <ap@apple.com>
3749
3750         One more case of incorrect comparison in recordpatchevent.py
3751         https://bugs.webkit.org/show_bug.cgi?id=137459
3752
3753         Reviewed by Tim Horton.
3754
3755         * QueueStatusServer/app.yaml:
3756         * QueueStatusServer/loggers/recordpatchevent.py:
3757         (RecordPatchEvent.started):
3758
3759 2014-10-06  Alexey Proskuryakov  <ap@apple.com>
3760
3761         webkit-queues PatchLog is incorrect for patches that took less than a second
3762         https://bugs.webkit.org/show_bug.cgi?id=137453
3763
3764         Reviewed by Tim Horton.
3765
3766         * QueueStatusServer/app.yaml: Updated app version.
3767
3768         * QueueStatusServer/loggers/recordpatchevent.py: (RecordPatchEvent.stopped):
3769         Don't bail out for patches that took 0 seconds to process (as frequently happens
3770         when a patch is obsolete).
3771
3772 2014-10-06  Csaba Osztrogonác  <ossy@webkit.org>
3773
3774         EWS bubble hover shows wrong timestamps
3775         https://bugs.webkit.org/show_bug.cgi?id=137252
3776
3777         Reviewed by Alexey Proskuryakov.
3778
3779         Add "Z" suffix to timestamps to make sure if it is handled as UTC time.
3780
3781         * QueueStatusServer/handlers/queuestatusjson.py:
3782         (QueueStatusJSON.get):
3783         * QueueStatusServer/handlers/statusbubble.py:
3784         (StatusBubble._iso_time):
3785
3786 2014-10-06  Mario Sanchez Prada  <mario@webkit.org>
3787
3788         Unreviewed, updated list of email addresses in contributors.json
3789
3790         * Scripts/webkitpy/common/config/contributors.json: Added my former
3791         email address in Igalia, for the sake of completeness.
3792
3793 2014-10-06  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
3794
3795         Unreviewed, moved myself to the list of committers.
3796
3797         * Scripts/webkitpy/common/config/contributors.json:
3798
3799 2014-10-05  Ryuan Choi  <ryuan.choi@gmail.com>
3800
3801         [EFL] Introduce EWebKit_Extension
3802         https://bugs.webkit.org/show_bug.cgi?id=134921
3803
3804         Reviewed by Gyuyoung Kim.
3805
3806         * MiniBrowser/efl/main.c: Added x option to test extension path.
3807         (window_create):
3808         (elm_main):
3809         * Scripts/webkitpy/common/config/watchlist:
3810         Added Source/WebKit2/WebProcess/InjectedBundle/API/efl/ into EFLWebKit2PublicAPI.
3811         * Scripts/webkitpy/style/checker.py:
3812         Added Source/WebKit2/WebProcess/InjectedBundle/API/efl/ into EFL exceptions.
3813
3814 2014-10-04  Csaba Osztrogonác  <ossy@webkit.org>
3815
3816         [jhbuild] Simplify platform detection in update-webkit-libs-jhbuild
3817         https://bugs.webkit.org/show_bug.cgi?id=137390
3818
3819         Reviewed by Carlos Garcia Campos.
3820
3821         * Scripts/update-webkit-libs-jhbuild:
3822
3823 2014-10-04  Carlos Garcia Campos  <cgarcia@igalia.com>
3824
3825         [GTK] Do not generate webkit2gtk-tests-resources.gresource unconditionally
3826         https://bugs.webkit.org/show_bug.cgi?id=137391
3827
3828         Reviewed by Martin Robinson.
3829
3830         Add a custom command to only re-generate
3831         webkit2gtk-tests-resources.gresource when any of its dependencies changes.
3832
3833         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
3834
3835 2014-10-04  Carlos Garcia Campos  <cgarcia@igalia.com>
3836
3837         [GTK] generate-gtkdoc crashes when generating HTML due to encoding issues
3838         https://bugs.webkit.org/show_bug.cgi?id=135502
3839
3840         Reviewed by Martin Robinson.
3841
3842         When writing to stdout/stderr fails due to a UnicodeDecodeError
3843         exception, try again without encoding the output.
3844
3845         * gtk/gtkdoc.py:
3846         (GTKDoc._run_command):
3847
3848 2014-10-03  Alexey Proskuryakov  <ap@apple.com>
3849
3850         Bugzilla status bubble displays an exception showing attachment 175738
3851         https://bugs.webkit.org/show_bug.cgi?id=137410
3852
3853         Reviewed by Tim Horton.
3854
3855         * QueueStatusServer/app.yaml: Update version.
3856
3857         * QueueStatusServer/handlers/statusbubble.py: (StatusBubble._build_bubble):
3858         Don't fail even if expected status message is missing.
3859
3860         * QueueStatusServer/model/patchlog.py: (PatchLog): Quick unrelated fix - define
3861         the field in the same way it's defined in QueueStatus table.
3862
3863 2014-10-03  Alexey Proskuryakov  <ap@apple.com>
3864
3865         Record latest message in PatchLog for quick access
3866         https://bugs.webkit.org/show_bug.cgi?id=137405
3867
3868         Fixing a typo.
3869
3870         * QueueStatusServer/app.yaml:
3871         * QueueStatusServer/handlers/releasepatch.py:
3872
3873 2014-10-03  Alexey Proskuryakov  <ap@apple.com>
3874
3875         Record latest message in PatchLog for quick access
3876         https://bugs.webkit.org/show_bug.cgi?id=137405
3877
3878         Reviewed by Ryosuke Niwa.
3879
3880         It's no SQL...
3881
3882         * QueueStatusServer/handlers/releasepatch.py:
3883         * QueueStatusServer/handlers/updatestatus.py:
3884         * QueueStatusServer/loggers/recordpatchevent.py:
3885         * QueueStatusServer/model/patchlog.py:
3886
3887 2014-10-02  David Farler  <dfarler@apple.com>
3888
3889         -asan-blacklist option also renamed to generic -fsanitize-blacklist
3890         https://bugs.webkit.org/show_bug.cgi?id=137377
3891
3892         Reviewed by Daniel Bates.
3893
3894         * asan/asan.xcconfig:
3895         -asan-blacklist -> -fsanitize-blacklist
3896
3897         http://llvm.org/viewvc/llvm-project?view=revision&revision=212505
3898
3899 2014-10-03  Roger Fong  <roger_fong@apple.com>
3900
3901         [Windows] Include batch size argument to layout tests on Windows.
3902
3903         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3904         (RunWebKitTests.start): 
3905         This is a speculative fix for the the inconsistent crashes we are seeing on Windows.
3906         These crashes seem to happen on random tests though generally in a spread out fashion.
3907         It seems possible that the DRT instance is being clobbered somehow after running too many
3908         tests in a row so we will try to mitigate this by just forcing DRT to restart periodically.
3909
3910 2014-10-03  Roger Fong  <roger_fong@apple.com>
3911
3912         [Windows] Settle for 2 chid processes running NRWT on Windows.
3913
3914         * Scripts/webkitpy/port/win.py:
3915         (WinPort.default_child_processes): 3 child processes reintroduces the sporadic crashing, will settle for 2.
3916
3917 2014-10-03  Akos Kiss  <akiss@inf.u-szeged.hu>
3918
3919         [GTK] Bump up and patch dependencies to allow building for aarch64
3920         https://bugs.webkit.org/show_bug.cgi?id=137147
3921
3922         Reviewed by Martin Robinson.
3923
3924         The currently used versions of pixman, libffi, librsvg, glib,
3925         glib-networking, fontconfig, libxml2, gst-plugins-base fail to configure
3926         and/or build for aarch64, so they are bumped up and patched where
3927         necessary. Wherever possible, the same versions and patches were used as
3928         for the EFL port bump-up
3929         (https://bugs.webkit.org/show_bug.cgi?id=135885).
3930
3931         After the bump-up, a hitherto hidden bug in gst-plugins-good caused a
3932         regression by crashing http/tests/media/video-redirect.html . A patch
3933         already in upstream fixes that bug.
3934
3935         This change does not touch xserver, which also needs bumping up, but 
3936         will be dealt with later.
3937
3938         * gtk/jhbuild.modules:
3939         Specified versions and patches necessary to correctly build for aarch64.
3940         * gtk/patches/gst-events-arent-gstobjects.patch:
3941         Added. Patches gst-plugins-good to fix a bug in .mov file demuxing.
3942         * gtk/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch:
3943         Added. Patches gst-plugins-base to configure correctly for aarch64.
3944         * gtk/patches/librsvg-2.36.1-bump-up-config.guess-to-support-aarch64.patch:
3945         Added. Bumps up config.guess and config.sub in librsvg to recognize
3946         aarch64.
3947         * gtk/patches/libxml2-2.9.0-dtd.patch:
3948         Removed. Not necessary for libxml2 v2.9.1 anymore.
3949
3950 2014-09-28  Sam Weinig  <sam@webkit.org>
3951
3952         Remove RefPtrHashMap
3953         https://bugs.webkit.org/show_bug.cgi?id=137200
3954
3955         Reviewed by Darin Adler.
3956
3957         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
3958         (TestWebKitAPI::TEST):
3959         Add tests for using a HashMap with RefPtr keys, focusing on ensuring that
3960         a minimum of refcount churn occurs.
3961
3962 2014-10-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3963
3964         Remove workarounds for versions of Python before 2.7
3965         https://bugs.webkit.org/show_bug.cgi?id=137338
3966
3967         Reviewed by Csaba Osztrogonác.
3968
3969         * Scripts/webkitpy/common/system/autoinstall.py:
3970         (AutoInstaller._extract_targz):
3971         (AutoInstaller._unzip):
3972         (AutoInstaller): Deleted.
3973         (AutoInstaller._extract_all): Deleted.
3974         * Scripts/webkitpy/common/webkitunittest.py:
3975         (TestCase.setUp): Deleted.
3976         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
3977         (TestConfigurationConverter.collapse_macros):
3978         (TestConfigurationConverter.to_specifiers_list.try_collapsing):
3979         (TestConfigurationConverter.to_specifiers_list.try_abbreviating):
3980         (TestConfigurationConverter):
3981         (TestConfigurationConverter.combinations): Deleted.
3982         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
3983         * Scripts/webkitpy/port/base.py:
3984
3985 2014-10-03  Commit Queue  <commit-queue@webkit.org>
3986
3987         Unreviewed, rolling out r174264.
3988         https://bugs.webkit.org/show_bug.cgi?id=137392
3989
3990         It broke run-webkit-tests (Requested by ebalazsfalvi on
3991         #webkit).
3992
3993         Reverted changeset:
3994
3995         "Remove workarounds for versions of Python before 2.7"
3996         https://bugs.webkit.org/show_bug.cgi?id=137338
3997         http://trac.webkit.org/changeset/174264
3998
3999 2014-10-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
4000
4001         Remove workarounds for versions of Python before 2.7
4002         https://bugs.webkit.org/show_bug.cgi?id=137338
4003
4004         Reviewed by Csaba Osztrogonác.
4005
4006         * Scripts/webkitpy/common/system/autoinstall.py:
4007         (AutoInstaller._extract_targz):
4008         (AutoInstaller._unzip):
4009         (AutoInstaller): Deleted.
4010         (AutoInstaller._extract_all): Deleted.
4011         * Scripts/webkitpy/common/webkitunittest.py:
4012         (TestCase.setUp): Deleted.
4013         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
4014         (TestConfigurationConverter.collapse_macros):
4015         (TestConfigurationConverter.to_specifiers_list.try_collapsing):
4016         (TestConfigurationConverter.to_specifiers_list.try_abbreviating):
4017         (TestConfigurationConverter):
4018         (TestConfigurationConverter.combinations): Deleted.
4019         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
4020         * Scripts/webkitpy/port/base.py:
4021         * Scripts/webkitpy/port/driver.py:
4022         (ContentBlock.__init__):
4023         * Scripts/webkitpy/port/server_process.py:
4024         (ServerProcess._reset):
4025
4026 2014-10-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
4027
4028         Remove autoinstaller workaround for python 2.6
4029         https://bugs.webkit.org/show_bug.cgi?id=137343
4030
4031         Reviewed by Daniel Bates.
4032
4033         Reverting <http://trac.webkit.org/changeset/124928>, neither Python
4034         2.6, nor Snow Leopard is supported anymore, so the workaround is not
4035         needed anymore.
4036
4037         * Scripts/webkitpy/common/system/autoinstall.py:
4038         (AutoInstaller.install):
4039         * Scripts/webkitpy/test/main.py:
4040         (Tester._run_tests):
4041         * Scripts/webkitpy/thirdparty/__init__.py:
4042         (AutoinstallImportHook._install_mechanize):
4043         (AutoinstallImportHook._install_pep8):
4044         (AutoinstallImportHook._install_pylint):
4045         (AutoinstallImportHook._install_buildbot):
4046         (AutoinstallImportHook._install_coverage):
4047         (AutoinstallImportHook._install_eliza):
4048         (AutoinstallImportHook._install_irc):
4049         (AutoinstallImportHook._install):
4050         (autoinstall_everything):
4051
4052 2014-10-02  Daniel Bates  <dabates@apple.com>
4053
4054         Use version number 101000 instead of 10100 for OS X Yosemite
4055         https://bugs.webkit.org/show_bug.cgi?id=137372
4056
4057         Reviewed by Mark Rowe.
4058
4059         The version number for OS X Yosemite is 101000.
4060
4061         * DumpRenderTree/mac/TextInputController.m:
4062
4063 2014-10-02  Alexey Proskuryakov  <ap@apple.com>
4064
4065         update-work-items should never delete items
4066         https://bugs.webkit.org/show_bug.cgi?id=137366
4067
4068         Reviewed by Ryosuke Niwa.
4069
4070         As we don't just replace the whole list any more, indicate which items are high
4071         priority, and which are not. Hight priority ones will be prepended to the queue,
4072         others will be appended.
4073
4074         This creates a bit of unfairness in that high priority item queue becomes a LIFO.
4075         But hopefully we will never have many rollouts competing like that.
4076
4077         * QueueStatusServer/app.yaml: Update version.
4078
4079         * QueueStatusServer/handlers/updateworkitems.py: Never remove items. Pass high
4080         priority and regular items separately. Removed some error handling that used to
4081         end up in returning status 500 - an uncaught exception does that automatically.
4082
4083         * QueueStatusServer/main.py: Removed unnecessary regexps from URL matching code.
4084
4085         * QueueStatusServer/model/workitems.py: Added a way to add high priority items.
4086
4087         * QueueStatusServer/templates/updateworkitems.html: Added a field for high
4088         priority items.
4089
4090         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
4091         (BugzillaQueries._parse_attachment_ids_request_query): Removed an annoying log
4092         line that complicated testing.
4093
4094         * Scripts/webkitpy/common/net/statusserver.py: Pass high priority items separately.
4095
4096         * Scripts/webkitpy/tool/bot/feeders.py: For commit queue, split high and regular
4097         priority items into separate lists.
4098
4099         * Scripts/webkitpy/common/net/statusserver_mock.py:
4100         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
4101         * Scripts/webkitpy/tool/commands/queues_unittest.py:
4102         Updated tests.
4103
4104 2014-10-02  Brendan Long  <b.long@cablelabs.com>
4105
4106         Annoying build warnings in WTFString API tests
4107         https://bugs.webkit.org/show_bug.cgi?id=137360
4108
4109         Reviewed by Darin Adler.
4110
4111         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
4112         (TestWebKitAPI::TEST): Change EXPECT_EQ(false, ok) to EXPECT_FALSE(ok) and EXPECT_EQ(true, ok) to EXPECT_TRUE(ok).
4113
4114 2014-10-02  Roger Fong  <roger_fong@apple.com>
4115
4116         [Windows] The number of processes did not affect the crash inconsistency, increase number of child processes again.
4117
4118         * Scripts/webkitpy/port/win.py:
4119         (WinPort.default_child_processes): Ambitiously try 3 processes the testers are too slow now.
4120
4121 2014-10-02  David Farler  <dfarler@apple.com>
4122
4123         Move ASan arguments from LLVM (-mllvm) to the frontend
4124         https://bugs.webkit.org/show_bug.cgi?id=137365
4125
4126         Reviewed by David Kilzer.
4127
4128         * asan/asan.xcconfig:
4129         Remove the -mllvm prefix to the asan-blacklist argument, moving it
4130         to the clang frontend.
4131
4132         http://llvm.org/viewvc/llvm-project?view=revision&revision=212505
4133
4134 2014-10-02  Commit Queue  <commit-queue@webkit.org>
4135
4136         Unreviewed, rolling out r174120.
4137         https://bugs.webkit.org/show_bug.cgi?id=137350
4138
4139         While number of failures is reasonable with 2 processes, test
4140         results seem to be inconsistent between runs (Requested by
4141         rfong on #webkit).
4142
4143         Reverted changeset:
4144
4145         "[Windows] Back to 2 child processes for NRWT on Windows."
4146         http://trac.webkit.org/changeset/174120
4147
4148 2014-10-02  Jeff Miller  <jeffm@apple.com>
4149
4150         DumpRenderTree and WebKitTestRunner should use WebKitystemInterfaceYosemite when building on Yosemite
4151         https://bugs.webkit.org/show_bug.cgi?id=137347
4152
4153         Reviewed by Dan Bernstein.
4154
4155         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
4156         Use WebKitSystemInterfaceYosemite on OS X 10.10.
4157
4158         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
4159         Ditto.
4160
4161 2014-10-02  Carlos Alberto Lopez Perez  <clopez@igalia.com>
4162
4163         [GTK] [JHBuild] Switch sourceware.org mirror to http.
4164
4165         Unreviewed.
4166
4167         The ftp access is recently failing to work as expected, and the
4168         bots fail to download the file.
4169         The same mirror is available via http and seems to work better.
4170
4171         * gtk/jhbuild.modules:
4172
4173 2014-10-01  Commit Queue  <commit-queue@webkit.org>
4174
4175         Unreviewed, rolling out r174185.
4176         https://bugs.webkit.org/show_bug.cgi?id=137334
4177
4178         Patch that adds logging causes webkitpy failures (Requested by
4179         rfong on #webkit).
4180
4181         Reverted changeset:
4182
4183         "commitqueuetasks_unittest references a non-existent member
4184         variable"
4185         https://bugs.webkit.org/show_bug.cgi?id=137303
4186         http://trac.webkit.org/changeset/174185
4187
4188 2014-10-01  Jake Nielsen  <jacob_nielsen@apple.com>
4189
4190         EWS and Commit Queue should know better than to spew 500 failed
4191         results in the case of extremely red patches.
4192         https://bugs.webkit.org/show_bug.cgi?id=137324
4193
4194         Reviewed by Alexey Proskuryakov.
4195
4196         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
4197         Adds a check for did_exceed_test_failure_limit.
4198         (AbstractEarlyWarningSystem._failing_tests_message):
4199         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
4200         Alters the task mock to respond properly to
4201         results_from_patch_test_run(patch)
4202         (AbstractEarlyWarningSystemTest.test_failing_tests_message):
4203         * Scripts/webkitpy/tool/commands/queues.py:
4204         Adds a check for did_exceed_test_failure_limit.
4205         (CommitQueue._failing_tests_message):
4206
4207 2014-10-01  Daniel Bates  <dabates@apple.com>
4208
4209         Unreviewed, rolling out r174192.
4210
4211         Revert the unit test fix in r174192 since we reverted r174187
4212         in r174194 due to correctness issues. See
4213         <http://webkit.org/b/137329> for more details.
4214
4215         Reverted changeset:
4216
4217         "Test fix after r174187"
4218         http://trac.webkit.org/changeset/174192
4219
4220 2014-10-01  Mark Rowe  <mrowe@apple.com>
4221
4222         <https://webkit.org/b/137308> WebKit should build on OS X Yosemite for external users
4223
4224         Reviewed by Dan Bernstein.
4225
4226         * Scripts/copy-webkitlibraries-to-product-directory: Copy libWebKitSystemInterfaceYosemite.a
4227         into the build directory. Use LLVMIncludesYosemite.tar.bz2 and LLVMLibrariesYosemite.tar.bz2
4228         for the LLVM components when on Yosemite.
4229
4230 2014-10-01  Commit Queue  <commit-queue@webkit.org>
4231
4232         Unreviewed, rolling out r174187.
4233         https://bugs.webkit.org/show_bug.cgi?id=137329
4234
4235         webkitpy failures, and thorton says the patch is wrong
4236         (Requested by dethbakin on #webkit).
4237
4238         Reverted changeset:
4239
4240         "[Windows] Increase layout test timeout for Windows following
4241         r174162."
4242         http://trac.webkit.org/changeset/174187
4243
4244 2014-10-01  Brent Fulgham  <bfulgham@apple.com>
4245
4246         Test fix after r174187
4247
4248         * Scripts/webkitpy/port/win_unittest.py:
4249         (WinPortTest.test_default_timeout_ms): Expect the new 50000 ms timeout for Windows tests.
4250
4251 2014-10-01  Roger Fong  <roger_fong@apple.com>
4252
4253         [Windows] Increase layout test timeout for Windows following r174162.
4254
4255         * Scripts/webkitpy/port/win.py:
4256         (WinPort.default_timeout_ms):
4257
4258 2014-10-01  Jake Nielsen  <jacob_nielsen@apple.com>
4259
4260         commitqueuetasks_unittest references a non-existent member variable
4261         when mock-reporting flaky tests.
4262         https://bugs.webkit.org/show_bug.cgi?id=137303
4263
4264         Reviewed by Daniel Bates.
4265
4266         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
4267         (MockCommitQueue.report_flaky_tests):
4268         Makes the appropriate name change.
4269         (test_simple_flaky_test_failure):
4270         Adds a unit test to make sure that the code is excercised.
4271
4272 2014-10-01  Jake Nielsen  <jacob_nielsen@apple.com>
4273
4274         EWS is inconclusively spinning forever on a patch that breaks 500+
4275         tests
4276         https://bugs.webkit.org/show_bug.cgi?id=137223
4277
4278         Reviewed by Tim Horton.
4279
4280         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
4281         Checks to see whether the tests have exceeded the failure limit, and
4282         only spins off another test if they have not exceeded the limit.
4283         (PatchAnalysisTask._test_patch):
4284
4285 2014-10-01  Brian J. Burg  <burg@cs.washington.edu>
4286
4287         Unreviewed, add Katie Madonna as a contributor.
4288
4289         * Scripts/webkitpy/common/config/contributors.json:
4290
4291 2014-10-01  Jake Nielsen  <jacob_nielsen@apple.com>
4292
4293         commitqueuetasks_unittest does not construct FailingTestCommitQueue
4294         objects properly in its test cases.
4295         https://bugs.webkit.org/show_bug.cgi?id=137281
4296
4297         Reviewed by Daniel Bates.
4298
4299         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
4300         (FailingTestCommitQueue.test_results):
4301         Adds an assert t