5dc6da1b4a1356f96d9a1e83f25b403188f149ea
[WebKit-https.git] / Tools / ChangeLog
1 2018-05-18  Fujii Hironori  <Hironori.Fujii@sony.com>
2
3         [Win][MiniBrowser] Create MainWindow even in transparent mode
4         https://bugs.webkit.org/show_bug.cgi?id=185597
5
6         Reviewed by Per Arne Vollan.
7
8         The current implementations doesn't create the MainWindow in
9         transparent mode. The screenshot is in Bug 58300.
10
11         There were three problems:
12         - Can't control the WebView. ie. going backward and forward.
13         - Can't quit the program.
14         - It makes implementation complicated.
15
16         * MiniBrowser/win/Common.cpp (resizeSubViews): Resize sub views
17         even in the transparent mode.
18         * MiniBrowser/win/WinMain.cpp:
19         (wWinMain): Create the main window even in the transparent mode.
20
21 2018-05-18  Antoine Quint  <graouts@apple.com>
22
23         [Web Animations] Turn Web Animations with CSS integration on for test runners
24         https://bugs.webkit.org/show_bug.cgi?id=184819
25         <rdar://problem/39597337>
26
27         Reviewed by Jon Lee.
28
29         Make the test runners turn both the main Web Animations flag and the Web Animations CSS
30         integration flag on.
31
32         We also remove the ability to toggle the Web Animations CSS integration flag using an HTML
33         comment directly at the top of the file since test runners now set the flag on by default
34         and a dedicated directory exists for tests that need to run with this flag off.
35
36         * DumpRenderTree/TestOptions.cpp:
37         (TestOptions::TestOptions):
38         * DumpRenderTree/TestOptions.h:
39         * DumpRenderTree/mac/DumpRenderTree.mm:
40         (shouldOverrideAndDisableWebAnimationsCSSIntegrationPreference):
41         (runTest):
42         * WebKitTestRunner/TestController.cpp:
43         (WTR::TestController::resetPreferencesToConsistentValues):
44         (WTR::updateTestOptionsFromTestHeader):
45         * WebKitTestRunner/TestOptions.cpp:
46         (WTR::isLegacyAnimationEngineTestPath):
47         (WTR::TestOptions::TestOptions):
48         * WebKitTestRunner/TestOptions.h:
49
50 2018-05-17  Nan Wang  <n_wang@apple.com>
51
52         AX: [macOS] Expose the primary screen height through AX API
53         https://bugs.webkit.org/show_bug.cgi?id=185742
54
55         Reviewed by Chris Fleizach.
56
57         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
58         (attributesOfElement):
59         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
60         (WTR::attributesOfElement):
61
62 2018-05-17  Commit Queue  <commit-queue@webkit.org>
63
64         Unreviewed, rolling out r231912.
65         https://bugs.webkit.org/show_bug.cgi?id=185750
66
67         It is prompting the user when there is no WPT changes
68         (Requested by bmac on #webkit).
69
70         Reverted changeset:
71
72         "Export changes to web-platform-test as part of the webkit-
73         patch upload workflow"
74         https://bugs.webkit.org/show_bug.cgi?id=184914
75         https://trac.webkit.org/changeset/231912
76
77 2018-05-17  Valerie R Young  <valerie@bocoup.com>
78
79         test262/Runner.pm: expand $INC to find webkitdirs.pm
80         https://bugs.webkit.org/show_bug.cgi?id=185739
81
82         Reviewed by Michael Saboff.
83
84         * Scripts/test262/Runner.pm:
85         (getBuildPath):
86
87 2018-05-17  Carlos Alberto Lopez Perez  <clopez@igalia.com>
88
89         [WPE] Implement and enable FULLSCREEN_API
90         https://bugs.webkit.org/show_bug.cgi?id=185676
91
92         Reviewed by Žan Doberšek.
93
94         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
95         (testWebViewFullScreen):
96
97 2018-05-17  Brendan McLoughlin  <brendan@bocoup.com>
98
99         Export changes to web-platform-test as part of the webkit-patch upload workflow
100         https://bugs.webkit.org/show_bug.cgi?id=184914
101
102         Reviewed by Youenn Fablet.
103
104         * Scripts/webkitpy/tool/commands/upload.py:
105         (Upload):
106         (CreateBug.execute):
107         (WPTChangeExport):
108         * Scripts/webkitpy/tool/steps/__init__.py:
109         * Scripts/webkitpy/tool/steps/wptchangeexport.py: Added.
110         (WPTChangeExport):
111         (WPTChangeExport.options):
112         (WPTChangeExport.run):
113         * Scripts/webkitpy/w3c/common.py:
114         * Scripts/webkitpy/w3c/test_exporter.py:
115         (WebPlatformTestExporter):
116         (WebPlatformTestExporter.__init__):
117         (WebPlatformTestExporter.username):
118         (WebPlatformTestExporter.token):
119         (WebPlatformTestExporter._github):
120         (WebPlatformTestExporter._wpt_fork_branch_github_url):
121         (WebPlatformTestExporter._wpt_fork_remote):
122         (WebPlatformTestExporter._wpt_fork_push_url):
123         (WebPlatformTestExporter._git):
124         (WebPlatformTestExporter._branch_name):
125         (WebPlatformTestExporter._public_branch_name):
126         (WebPlatformTestExporter.has_wpt_changes):
127         (WebPlatformTestExporter._create_patch):
128         (WebPlatformTestExporter.create_git_patch):
129         (WebPlatformTestExporter._prompt_for_token):
130         (WebPlatformTestExporter._prompt_for_username):
131         (WebPlatformTestExporter._ensure_username_and_token):
132         (WebPlatformTestExporter._validate_and_save_token):
133         (WebPlatformTestExporter.push_to_wpt_fork):
134         (WebPlatformTestExporter.make_pull_request):
135         (WebPlatformTestExporter.delete_local_branch):
136         (parse_args):
137         (TestExporter): Deleted.
138         (TestExporter.__init__): Deleted.
139         (TestExporter._ensure_wpt_repository): Deleted.
140         (TestExporter._fetch_wpt_repository): Deleted.
141         (TestExporter._ensure_new_branch_name): Deleted.
142         (TestExporter.download_and_commit_patch): Deleted.
143         (TestExporter.clean): Deleted.
144         (TestExporter.create_branch_with_patch): Deleted.
145         (TestExporter.push_to_wpt_fork): Deleted.
146         (TestExporter.make_pull_request): Deleted.
147         (TestExporter.create_wpt_pull_request): Deleted.
148         (TestExporter.delete_local_branch): Deleted.
149         (TestExporter.create_git_patch): Deleted.
150         (TestExporter.create_upload_remote_if_needed): Deleted.
151         (TestExporter.do_export): Deleted.
152         * Scripts/webkitpy/w3c/test_exporter_unittest.py:
153         (TestExporterTest.test_export):
154         (TestExporterTest.test_export_with_specific_branch):
155         (TestExporterTest):
156         (TestExporterTest.test_export_interactive_mode):
157         (TestExporterTest.test_export_invalid_token):
158         (TestExporterTest.test_export_wrong_token):
159
160 2018-05-17  Valerie R Young  <valerie@bocoup.com>
161
162         test262/Runner.pm: look for jsc in path if cannot call webkit-build-directory
163         https://bugs.webkit.org/show_bug.cgi?id=185650
164
165         Reviewed by Michael Saboff.
166
167         First, use jsc from CLI arg, then try to use webkit-build-directory,
168         if that doesn't work, look for jsc in the $PATH
169
170         * Scripts/test262/Runner.pm:
171         (processCLI):
172         (getBuildPath):
173         (runTest):
174
175 2018-05-16  Leo Balter  <leonardo.balter@gmail.com>
176
177         Test262-Runner: Adds a --timeout option
178         https://bugs.webkit.org/show_bug.cgi?id=185696
179
180         Reviewed by Michael Saboff.
181
182         The timeout option is used to set a timeout execution in ms for each test run in JSC.
183         The passed value - if defined - will be used as the value for the JSC --watchdog arg.
184         * Scripts/test262/Runner.pm:
185         (processCLI):
186         (runTest):
187
188 2018-05-16  Leo Balter  <leonardo.balter@gmail.com>
189
190         Test262-Runner: Set timer for each test run
191         https://bugs.webkit.org/show_bug.cgi?id=185692
192
193         Reviewed by Michael Saboff.
194
195         Sets a high resolution timer for each execution call of JSC, reporting
196         the time in the results report to allow identifying slow tests.
197         * Scripts/test262/Runner.pm:
198         (main):
199         (processFile):
200         (runTest):
201         (processResult):
202
203 2018-05-16  Andy VanWagoner  <andy@vanwagoner.family>
204
205         Add support for Intl NumberFormat formatToParts
206         https://bugs.webkit.org/show_bug.cgi?id=185375
207
208         Reviewed by Yusuke Suzuki.
209
210         Add flag for NumberFormat formatToParts.
211
212         * Scripts/webkitperl/FeatureList.pm:
213         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
214
215 2018-05-14  Yusuke Suzuki  <utatane.tea@gmail.com>
216
217         [Win] Use C++17 in MSVC
218         https://bugs.webkit.org/show_bug.cgi?id=185232
219
220         Reviewed by Alex Christensen.
221
222         Do not use `using namespace std;`. In C++17, we have std::byte. This "byte"
223         conflicts with ::byte defined in Windows' header.
224
225         * DumpRenderTree/TestNetscapePlugIn/win/WindowedPluginTest.cpp:
226         (WindowedPluginTest::WindowedPluginTest):
227         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
228         (logEventProc):
229         (stringEvent):
230         (AccessibilityController::winNotificationReceived):
231         * DumpRenderTree/win/TextInputController.cpp:
232         (markedRangeCallback):
233         (firstRectForCharacterRangeCallback):
234         (selectedRangeCallback):
235         * DumpRenderTree/win/TextInputController.h:
236         * DumpRenderTree/win/TextInputControllerWin.cpp:
237         (TextInputController::markedRange):
238         (TextInputController::firstRectForCharacterRange):
239         (TextInputController::selectedRange):
240
241 2018-05-16  Sihui Liu  <sihui_liu@apple.com>
242
243         Session cookies aren't reliably set when using default WKWebSiteDataStore
244         https://bugs.webkit.org/show_bug.cgi?id=185624
245         <rdar://problem/39111626>
246
247         Reviewed by Geoffrey Garen.
248
249         Modified and enabled WebKit.WKHTTPCookieStoreWithoutProcessPool.
250
251         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
252         (-[CookieUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
253         (TEST):
254
255 2018-05-16  Valerie R Young  <valerie@bocoup.com>
256
257         test262/Runner.pm: save to supplied expectation file if supplied
258         https://bugs.webkit.org/show_bug.cgi?id=185660
259
260         Reviewed by Michael Saboff.
261
262         * Scripts/test262/Runner.pm:
263         (processCLI):
264         (main):
265
266 2018-05-15  Ryan Haddad  <ryanhaddad@apple.com>
267
268         Unreviewed, rolling out r231763.
269
270         The test added with this change is failing an assertion.
271
272         Reverted changeset:
273
274         "NSEvent event trackers don't work from WebKitTestRunner"
275         https://bugs.webkit.org/show_bug.cgi?id=185383
276         https://trac.webkit.org/changeset/231763
277
278 2018-05-15  David Kilzer  <ddkilzer@apple.com>
279
280         TestWebKitAPI: Fix warnings found by new clang compiler
281         <https://webkit.org/b/185631>
282
283         Reviewed by Michael Catanzaro.
284
285         * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
286         (TestWebKitAPI::TEST):
287         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
288         (TestWebKitAPI::TEST):
289         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp:
290         (TestWebKitAPI::TEST):
291         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
292         (TestWebKitAPI::TEST):
293         - Add #pragma statements to ignore the new
294           -Wself-assign-overloaded warning and to ignore
295           this as an unknown warning on older clang versions.  We want
296           to keep these self assigments as this code is designed to test
297           that use case.
298
299         * TestWebKitAPI/Tests/WebKit/FindMatches.mm:
300         (TestWebKitAPI::didFindStringMatches):
301         - Replace the "rect = rect;" statement that was used to avoid an
302           unused variable warning with two expectations.
303
304         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
305         (-[PinnedStateObserver observeValueForKeyPath:ofObject:change:context:]):
306         - Switch from -integerValue to -unsignedIntegerValue when
307           comparing against _WKRectEdgeAll since it's an enum declared
308           as an NSUInteger.
309
310 2018-05-15  Michael Catanzaro  <mcatanzaro@igalia.com>
311
312         Unreviewed, rolling out r230749
313
314         This did not work as desired.
315
316         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
317         (TestWebKitAPI::TEST):
318
319 2018-05-15  Antoine Quint  <graouts@apple.com>
320
321         [Web Animations] Expose Web Animations CSS integration as an experimental feature
322         https://bugs.webkit.org/show_bug.cgi?id=185647
323
324         Reviewed by Dean Jackson.
325
326         Rename the Web Animations CSS integration flag.
327
328         * DumpRenderTree/TestOptions.cpp:
329         (TestOptions::TestOptions):
330         * DumpRenderTree/TestOptions.h:
331         * DumpRenderTree/mac/DumpRenderTree.mm:
332         (setWebPreferencesForTestOptions):
333         * WebKitTestRunner/TestController.cpp:
334         (WTR::TestController::resetPreferencesToConsistentValues):
335         (WTR::updateTestOptionsFromTestHeader):
336         * WebKitTestRunner/TestOptions.h:
337         (WTR::TestOptions::hasSameInitializationOptions const):
338
339 2018-05-14  Brady Eidson  <beidson@apple.com>
340
341         Add an API test to guard against regressions while re-entering setDefersLoading:.
342         <rdar://problem/37033737> and https://bugs.webkit.org/show_bug.cgi?id=185630
343
344         Reviewed by Chris Dumez.
345
346         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
347         * TestWebKitAPI/Tests/WebKitCocoa/DoubleDefersLoading.mm: Added.
348         (-[DoubleDefersNavigationDelegate _webView:navigation:didSameDocumentNavigation:]):
349         (-[DoubleDefersNavigationDelegate webView:didFinishNavigation:]):
350         (-[DefersScheme initWithBytes:]):
351         (-[DefersScheme webView:startURLSchemeTask:]):
352         (-[DefersScheme webView:stopURLSchemeTask:]):
353         * TestWebKitAPI/Tests/WebKitCocoa/DoubleDefersLoadingPlugin.mm: Added.
354         (-[DoubleDefersLoadingPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
355         (-[DoubleDefersLoadingPlugIn webProcessPlugInBrowserContextController:didSameDocumentNavigation:forFrame:]):
356         (-[DoubleDefersLoadingPlugIn dealloc]):
357
358 2018-05-14  Daniel Bates  <dabates@apple.com>
359
360         [iOS] Add a test to ensure that setTimeout() does not fire more than expected when using UIWebView
361         https://bugs.webkit.org/show_bug.cgi?id=185599
362         <rdar://problem/22493890>
363
364         Reviewed by Simon Fraser.
365
366         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
367         * TestWebKitAPI/Tests/ios/SetTimeoutFunction.mm: Added.
368         (-[SetTimeoutFunctionWebViewDelegate webViewDidFinishLoad:]):
369         (-[SetTimeoutFunctionWebViewDelegate webView:didFailLoadWithError:]):
370         (-[SetTimeoutFunctionWebViewDelegate webView:shouldStartLoadWithRequest:navigationType:]):
371         (TestWebKitAPI::TEST):
372         * TestWebKitAPI/ios/set-timeout-function.html: Added.
373
374 2018-05-14  Valerie R Young  <valerie@bocoup.com>
375
376         test262/Runner.pm: small bugs in CLI and error codes
377         https://bugs.webkit.org/show_bug.cgi?id=185629
378
379         Reviewed by Michael Saboff.
380
381         Fix two commandline args with use '-f', correct
382         error code of failures.
383
384         * Scripts/test262/Runner.pm:
385         (processCLI):
386         (main):
387
388 2018-05-14  Ryan Haddad  <ryanhaddad@apple.com>
389
390         Disable API tests that time out after pointer poisioning was disabled.
391         https://bugs.webkit.org/show_bug.cgi?id=185586
392
393         Unreviewed test gardening.
394
395         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
396         (TestWebKitAPI::TEST):
397         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
398         (TestWebKitAPI::TEST):
399         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp:
400         (TestWebKitAPI::TEST):
401         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp:
402         (TestWebKitAPI::TEST):
403
404 2018-05-14  Leo Balter  <leonardo.balter@gmail.com>
405
406         Test262-Runner: Fix RegExp for capturing tests metadata"
407         https://bugs.webkit.org/show_bug.cgi?id=185622
408
409         Reviewed by Michael Saboff.
410
411         This patch fixes the RegExp used to capture each test metadata regarding their EOL characters for
412         both LF and CRLF forms.
413
414         The fix also allows the runner to capture the proper results from two specific files using CR and
415         CRLF line terminators. They are updated in the expectations file.
416         * Scripts/test262/Runner.pm:
417         (parseData):
418
419 2018-05-14  Jeremy Jones  <jeremyj@apple.com>
420
421         NSEvent event trackers don't work from WebKitTestRunner
422         https://bugs.webkit.org/show_bug.cgi?id=185383
423         rdar://problem/40025045
424
425         Reviewed by Simon Fraser.
426
427         Post simulated wheel events to _sendEventToObservers: so they can be handled by NSEvent observers.
428         NSEvent swipe tracking is used for webkit swipe navigation.
429
430         * WebKitTestRunner/mac/EventSenderProxy.mm:
431         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
432
433 2018-05-11  Leo Balter  <leonardo.balter@gmail.com>
434
435         Test262 Runner should search for the Debug JSC by default
436         https://bugs.webkit.org/show_bug.cgi?id=185562
437
438         Reviewed by Michael Saboff.
439
440         The Test262 Runner is now searching for the Debug build of JSC by
441         default, not the Release build.
442
443         This fix allows a similar call from the previous runner, making
444         it compatible with the current build bot configuration parameters.
445
446         This patch also adds some minor improvements the verbose mode output.
447
448         * Scripts/test262/Runner.pm:
449         (processCLI):
450         (main):
451         (getBuildPath):
452         (processResult):
453
454 2018-05-11  Charles Vazac  <cvazac@gmail.com>
455
456         Runtime feature flag for Server-Timing
457         https://bugs.webkit.org/show_bug.cgi?id=184758
458
459         Reviewed by Youenn Fablet.
460
461         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: added ENABLE_SERVER_TIMING.
462         * DumpRenderTree/win/DumpRenderTree.cpp: enable Server Timing
463
464 2018-05-11  Fujii Hironori  <Hironori.Fujii@sony.com>
465
466         [Win][MiniBrowser] Move WK1 related code into MiniBrowser
467         https://bugs.webkit.org/show_bug.cgi?id=185418
468
469         Reviewed by Alex Christensen.
470
471         All WK1 related code should be moved into MiniBrowser for the preparation
472         of Bug 184770.
473
474         This change moves the initilization code of MiniBrowse into MiniBrowser::init().
475
476         * MiniBrowser/win/Common.cpp:
477         (getAppDataFolder): Removed `static` keyword to be called from MiniBrowser.cpp.
478         (setCacheFolder): This is only for WK1. Moved into MiniBrowser.cpp.
479         * MiniBrowser/win/Common.h: Added.
480         * MiniBrowser/win/MiniBrowser.cpp:
481         (MiniBrowser::init): Moved the initilization code from wWinMain.
482         (MiniBrowser::setCacheFolder): Moved from Common.cpp and made it a method.
483         * MiniBrowser/win/MiniBrowser.h:
484         (MiniBrowser::setCacheFolder): Changed to a private method.
485         (MiniBrowser::subclassForLayeredWindow): Changed to a private method.
486         * MiniBrowser/win/WinMain.cpp:
487         (wWinMain): Moved MiniBrowse initilization code into MiniBrowser.cpp.
488
489 2018-05-11  Brady Eidson  <beidson@apple.com>
490
491         Make sure history navigations reuse the existing process when necessary.
492         <rdar://problem/39746516> and https://bugs.webkit.org/show_bug.cgi?id=185532
493
494         Reviewed by Ryosuke Niwa.
495
496         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
497
498 2018-05-10  Carlos Garcia Campos  <cgarcia@igalia.com>
499
500         [JSC][GLIB] Add introspectable alternatives to functions using vargars
501         https://bugs.webkit.org/show_bug.cgi?id=185508
502
503         Reviewed by Michael Catanzaro.
504
505         Add test cases for the new API.
506
507         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
508         (testJSCFunction):
509         (testJSCObject):
510
511 2018-05-10  Leo Balter  <leonardo.balter@gmail.com>
512
513         [Build Bot] Restore configuration options to the Test262 Runner
514
515         During the switch from the previous Test262 runner to the new one,
516         a call for an extra configurations options got removed.
517
518         This call is important to inform the script to find the debug or
519         release build of JSC. It's being restored in this patch.
520
521         https://bugs.webkit.org/show_bug.cgi?id=185513
522
523         Reviewed by Yusuke Suzuki.
524
525         * BuildSlaveSupport/build.webkit.org-config/steps.py:
526         (RunTest262Tests):
527
528 2018-05-10  Jonathan Bedard  <jbedard@apple.com>
529
530         REGRESSION (r230998): Cannot stream API test output
531         https://bugs.webkit.org/show_bug.cgi?id=185090
532
533         Reviewed by Ryosuke Niwa.
534
535         Change run-api-tests so that the stdout and stderr of a test will be printed
536         before it's result. If -v is passed, the output of single test runs will be
537         streamed. 
538
539         * Scripts/webkitpy/api_tests/run_api_tests.py:
540         (run): Use print_timestamps flag.
541         (parse_args): Add timestamps option to print timestamps in the log.
542         * Scripts/webkitpy/api_tests/runner.py:
543         (Runner): Add running status.
544         (Runner.__init__): Add number of workers and a flag to detect if a newline
545         is needed at the beginning of a log line.
546         (Runner.run): Turn off most logging coming from server process since it is
547         not constructive for API tests.
548         (Runner.handle): Add new log message to stream stdout and stderr instead of
549         caching values until the test run finished.
550         (_Worker._run_single_test): Log stdout and stderr in real time.
551         (_Worker._run_shard_with_binary): Log stderr and stdout buffer before ending
552         the test.
553         (_Worker.post): Provide a post with explicitly enumerated argument names.
554         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
555         (MeteredStream.__init__): Differentiate verbose logging and logging with timestamps.
556         (MeteredStream.write): Allow for verbose logging without timestamps.
557         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
558         (RegularTest): Add print_timestamps flag.
559         (RegularTest.setUp):
560         (RegularTest.test_logging_not_included):
561         (VerboseTest.test_log_args):
562         (VerboseWithOutTimestamp):
563         (VerboseWithOutTimestamp.test_basic): Add test for verbose logging without timestamps.
564
565 2018-05-10  Ryosuke Niwa  <rniwa@webkit.org>
566
567         build-webkit can erroneously warn about Xcode being too old
568         https://bugs.webkit.org/show_bug.cgi?id=185533
569
570         Reviewed by Dan Bernstein.
571
572         Don't assume the version number is always a single digit.
573
574         * Scripts/webkitdirs.pm:
575         (determineXcodeVersion):
576
577 2018-05-10  Ross Kirsling  <ross.kirsling@sony.com>
578
579         [WinCairo][Buildbot] Test bots need to acquire WinCairoRequirements.
580         https://bugs.webkit.org/show_bug.cgi?id=185528
581
582         Reviewed by Lucas Forschler.
583
584         * BuildSlaveSupport/build.webkit.org-config/factories.py:
585         (TestFactory.__init__):
586         * BuildSlaveSupport/build.webkit.org-config/steps.py:
587         (InstallWinCairoDependencies):
588
589 2018-05-10  Michael Catanzaro  <mcatanzaro@igalia.com>
590
591         Fix some -Wstring-op-truncation warnings
592         https://bugs.webkit.org/show_bug.cgi?id=185496
593
594         Reviewed by Alex Christensen.
595
596         We have an off-by-one in the use of strncpy. The strings would not be null-terminated if
597         the input was too long. Ensure the buffers are zero-initialized so we don't need to manually
598         set the last bucket to NUL.
599
600         * TestWebKitAPI/Tests/WTF/AtomicString.cpp:
601         (TestWebKitAPI::testAtomicStringNumber):
602         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
603         (TestWebKitAPI::testStringNumberFixedPrecision):
604         (TestWebKitAPI::testStringNumberFixedWidth):
605         (TestWebKitAPI::testStringNumber):
606
607 2018-05-10  Fujii Hironori  <Hironori.Fujii@sony.com>
608
609         [Win][MiniBrowser] Add a separate WndProc for the layered window
610         https://bugs.webkit.org/show_bug.cgi?id=185460
611
612         Reviewed by Brent Fulgham.
613
614         All WK1 related code should be moved into MiniBrowser for the
615         preparation of Bug 184770.
616
617         The layered window was using WndProc of the main window. The
618         layered window is specific only for WK1. the main window will be
619         shared among WK1 and WK2.
620
621         This change add a new WndProc for the layer window.
622
623         * MiniBrowser/win/Common.cpp:
624         (WndProc): Removed code for the layered windows.
625         (subclassForLayeredWindow): Moved into MiniBrowser.cpp.
626         * MiniBrowser/win/MiniBrowser.cpp:
627         (MiniBrowser::prepareViews): Removed the fourth argument `viewHwnd`.
628         (viewWndProc): New WndProc for the layered windows.
629         (MiniBrowser::subclassForLayeredWindow): Moved from Common.cpp.
630         * MiniBrowser/win/MiniBrowser.h:
631         (MiniBrowser::hwnd):
632         * MiniBrowser/win/WinMain.cpp:
633         (wWinMain): Added m_viewWnd.
634
635 2018-05-10  Stephan Szabo  <stephan.szabo@sony.com>
636
637         Support --verbose in run-javascriptcore-tests
638         https://bugs.webkit.org/show_bug.cgi?id=185492
639
640         Reviewed by Daniel Bates.
641
642         * Scripts/run-javascriptcore-tests:
643         (runJSCStressTests):
644
645 2018-05-10  Valerie R Young  <valerie@bocoup.com>
646
647         test262/Runner.pm: --failing-files uses results file not expectations
648         https://bugs.webkit.org/show_bug.cgi?id=185395
649
650         Reviewed by Michael Saboff.
651
652         --failing-files arg now uses results file to find failing tests
653         to rerun. It will look in the test262-results directory from whereever
654         the script is run, or a results.yaml file can be supplied via command
655         line argument.
656         --expectations arg added for suppling expectation file.
657
658         * Scripts/test262/Runner.pm:
659         (processCLI):
660         (main):
661         (loadImportFile):
662         (findAllFailing):
663
664 2018-05-10  Carlos Garcia Campos  <cgarcia@igalia.com>
665
666         [GTK] Add support for settings cookies policy and storage type in MiniBrowser
667         https://bugs.webkit.org/show_bug.cgi?id=185506
668
669         Reviewed by Philippe Normand.
670
671         Useful for testing and debugging.
672
673         * MiniBrowser/gtk/main.c:
674         (main):
675
676 2018-05-09  Chris Dumez  <cdumez@apple.com>
677
678         Unreviewed Windows build fix after r231622.
679
680         * DumpRenderTree/win/DumpRenderTree.cpp:
681         (enableExperimentalFeatures):
682
683 2018-05-09  Sihui Liu  <sihui_liu@apple.com>
684
685         Update WebKit.WebsiteDataStoreCustomPaths after r231536
686         https://bugs.webkit.org/show_bug.cgi?id=185486
687         <rdar://problem/37214391>
688
689         Reviewed by Chris Dumez.
690
691         Update WebKit.WebsiteDataStoreCustomPaths as _syncNetworkProcessCookies is async now.
692
693         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
694         (TEST):
695
696 2018-05-09  Leo Balter  <leonardo.balter@gmail.com>
697
698         Test262-Runner: Improve the verbose output
699         https://bugs.webkit.org/show_bug.cgi?id=185491
700
701         Reviewed by Michael Saboff.
702
703         * Scripts/test262/Import.pm:
704         (transferFiles):
705         * Scripts/test262/Runner.pm:
706         (processResult):
707
708 2018-05-09  Leo Balter  <leonardo.balter@gmail.com>
709
710         Fix Test262 Runner to have DYLD_FRAMEWORK_PATH always set
711         https://bugs.webkit.org/show_bug.cgi?id=185488
712
713         Reviewed by Michael Saboff.
714
715         * Scripts/test262/Runner.pm:
716         (processCLI):
717         (getBuildPath):
718         (runTest):
719
720 2018-05-09  Richard Houle  <rhoule@apple.com>
721
722         [Cocoa] Some fields are not identified as [WKWebProcessPlugInNodeHandle isTextField]
723         https://bugs.webkit.org/show_bug.cgi?id=185260
724         <rdar://problem/39290394>
725
726         Reviewed by Tim Horton.
727
728         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
729         * TestWebKitAPI/Tests/WebKitCocoa/InjectedBundleNodeHandleIsTextField.mm: Added.
730         (-[InjectedBundleNodeHandleIsTextField isTextFieldForHTMLInputType:document:jsContext:]):
731         (-[InjectedBundleNodeHandleIsTextField webProcessPlugIn:didCreateBrowserContextController:]):
732         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
733         (-[InjectedBundleNodeHandleIsTextFieldDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
734
735 2018-05-09  Thibault Saunier  <tsaunier@igalia.com>
736
737         [tests][GStreamer]: Pass USE_PLAYBIN3 to the tests subprocess
738         https://bugs.webkit.org/show_bug.cgi?id=185481
739
740         Reviewed by Philippe Normand.
741
742         [tests][GStreamer]: Pass USE_PLAYBIN3 to the tests subprocess
743
744         * Scripts/webkitpy/port/gtk.py:
745         (GtkPort.setup_environ_for_server):
746
747 2018-05-09  Leo Balter  <leonardo.balter@gmail.com>
748
749         Set build.webkit.org to use the new Test262-runner
750         https://bugs.webkit.org/show_bug.cgi?id=184933
751
752         Reviewed by Aakash Jain.
753
754         * BuildSlaveSupport/build.webkit.org-config/steps.py:
755         (RunTest262Tests):
756         (RunTest262Tests.countFailures):
757         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
758
759 2018-05-09  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
760
761         [GTK][JHBuild] LLVM 3.7.0 build is broken with GCC 8.1
762         https://bugs.webkit.org/show_bug.cgi?id=185461
763
764         Reviewed by Michael Catanzaro.
765
766         JHBuild now compiles LLVM 6 and Mesa 18.0.3.
767
768         * gtk/jhbuild.modules:
769
770 2018-05-09  Michael Catanzaro  <mcatanzaro@igalia.com>
771
772         Unreviewed. Update OptionsWPE.cmake and NEWS for 2.21.1 release.
773
774         * wpe/manifest.txt.in: Distribute the NEWS.
775
776 2018-05-09  Michael Catanzaro  <mcatanzaro@igalia.com>
777
778         [WPE] Build cleanly with GCC 8 and ICU 60
779         https://bugs.webkit.org/show_bug.cgi?id=185462
780
781         Reviewed by Carlos Alberto Lopez Perez.
782
783         * TestWebKitAPI/CMakeLists.txt: Fix weird build failure, we were missing a directory. Not
784         sure why this was never noticed until now or why the bots are OK.
785         * gtk/jhbuild.modules: Add upstream patch to avoid warnings inside G_DEFINE_TYPE.
786         * gtk/patches/glib-cast-function-type.patch: Added.
787         * wpe/jhbuild.modules: Add upstream patch to avoid warnings inside G_DEFINE_TYPE.
788         * wpe/patches/glib-cast-function-type.patch: Added.
789
790 2018-05-06  Yusuke Suzuki  <utatane.tea@gmail.com>
791
792         [JSC][GTK][JSCONLY] Use capstone disassembler
793         https://bugs.webkit.org/show_bug.cgi?id=185283
794
795         Reviewed by Michael Catanzaro.
796
797         * gtk/manifest.txt.in:
798         * wpe/manifest.txt.in:
799
800 2018-05-09  Antti Koivisto  <antti@apple.com>
801
802         Add OptionSet::operator& and operator bool
803         https://bugs.webkit.org/show_bug.cgi?id=185306
804
805         Reviewed by Anders Carlsson.
806
807         * TestWebKitAPI/Tests/WTF/OptionSet.cpp:
808         (TestWebKitAPI::TEST):
809
810 2018-05-08  Wenson Hsieh  <wenson_hsieh@apple.com>
811
812         Consolidate WebContentReaderIOS and WebContentReaderMac into WebContentReaderCocoa
813         https://bugs.webkit.org/show_bug.cgi?id=185340
814
815         Reviewed by Tim Horton.
816
817         Adds a new API test to verify that URLs written using -[NSPasteboard writeObjects:] are pasted as anchors with
818         non-empty text in a contenteditable.
819
820         * TestWebKitAPI/Tests/WebKitCocoa/PasteMixedContent.mm:
821         (TestWebKitAPI::TEST):
822
823 2018-05-08  Valerie R Young  <valerie@bocoup.com>
824
825         test262/Runner.pm: create results dir for results of test262 run
826         https://bugs.webkit.org/show_bug.cgi?id=185392
827
828         Reviewed by Michael Saboff.
829
830         New directory test262-results created from where ever script is
831         called.
832
833         * Scripts/test262/Runner.pm:
834         (processCLI):
835
836 2018-05-08  Valerie R Young  <valerie@bocoup.com>
837
838         test262/Runner.pm: lower number of processes per core
839         https://bugs.webkit.org/show_bug.cgi?id=185426
840
841         Reviewed by Michael Saboff.
842
843         * Scripts/test262/Runner.pm:
844         (getProcesses):
845
846 2018-05-08  Leo Balter  <leonardo.balter@gmail.com>
847
848         Test262-Runner: Add base Perl UnicodeData
849         https://bugs.webkit.org/show_bug.cgi?id=185444
850
851         Reviewed by Michael Saboff.
852
853         * Scripts/test262/local/lib/perl5/unicore/lib/gc_sc/SpacePer.pl: Added.
854         * Scripts/test262/local/lib/perl5/unicore/lib/gc_sc/Word.pl: Added.
855
856 2018-05-08  Daniel Bates  <dabates@apple.com>
857
858         Add tests to ensure that the Strong Password appearance is removed on form reset
859         https://bugs.webkit.org/show_bug.cgi?id=185440
860
861         Reviewed by Ryosuke Niwa.
862
863         * TestWebKitAPI/Tests/WebKitCocoa/DidResignInputElementStrongPasswordAppearance.mm:
864         (-[DidResignInputElementStrongPasswordAppearance webProcessPlugIn:didCreateBrowserContextController:]):
865         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
866         (TEST):
867
868 2018-05-08  Daniel Bates  <dabates@apple.com>
869
870         Resign Strong Password appearance when text field value changes
871         https://bugs.webkit.org/show_bug.cgi?id=185433
872         <rdar://problem/39958508>
873
874         Reviewed by Ryosuke Niwa.
875
876         Add a unit test to ensure the injected bundle API and WebKit UI delegate SPI is invoked
877         when the field has the Strong Password button and its value changes.
878
879         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
880         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
881         (TEST):
882
883 2018-05-06  Filip Pizlo  <fpizlo@apple.com>
884
885         InPlaceAbstractState::beginBasicBlock shouldn't have to clear any abstract values
886         https://bugs.webkit.org/show_bug.cgi?id=185365
887
888         Reviewed by Saam Barati.
889         
890         Make it possible to measure compile times.
891         
892         Rolling back in after fixing cloop builds.
893
894         * Scripts/run-jsc-benchmarks:
895
896 2018-05-08  Wenson Hsieh  <wenson_hsieh@apple.com>
897
898         [iOS] WKAttachmentTestsIOS.InsertDroppedItemProvidersInOrder fails after r231396
899         https://bugs.webkit.org/show_bug.cgi?id=185414
900
901         Reviewed by Tim Horton.
902
903         Adjust a test expectation to check that the resulting DOM contains an attachment element,
904         anchor element, and another attachment element in that order. This ensures that the test
905         still passes, even after the anchor element is followed by a line break.
906
907         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
908         (TestWebKitAPI::TEST):
909
910 2018-05-08  Commit Queue  <commit-queue@webkit.org>
911
912         Unreviewed, rolling out r231491.
913         https://bugs.webkit.org/show_bug.cgi?id=185434
914
915         Setting the Created key on a cookie does not work yet, due a
916         bug in CFNetwork (Requested by ggaren on #webkit).
917
918         Reverted changeset:
919
920         "[WKHTTPCookieStore getAllCookies] returns inconsistent
921         creation time"
922         https://bugs.webkit.org/show_bug.cgi?id=185041
923         https://trac.webkit.org/changeset/231491
924
925 2018-05-08  Valerie R Young  <valerie@bocoup.com>
926
927         test262/Runner.pm: move input files to JSTests/test262
928         https://bugs.webkit.org/show_bug.cgi?id=185389
929
930         Reviewed by Michael Saboff.
931
932         * Scripts/test262/Runner.pm:
933         (processCLI):
934
935 2018-05-08  Chris Dumez  <cdumez@apple.com>
936
937         Unreviewed, simplify Speedometer fixes landed in r231489, r231483 & r231474.
938
939         * Scripts/webkitpy/performance_tests/perftest.py:
940         (PerfTest):
941
942 2018-05-08  Ryan Haddad  <ryanhaddad@apple.com>
943
944         Unreviewed, rolling out r231468.
945
946         Broke the CLoop build
947
948         Reverted changeset:
949
950         "InPlaceAbstractState::beginBasicBlock shouldn't have to clear
951         any abstract values"
952         https://bugs.webkit.org/show_bug.cgi?id=185365
953         https://trac.webkit.org/changeset/231468
954
955 2018-05-08  Sihui Liu  <sihui_liu@apple.com>
956
957         [WKHTTPCookieStore getAllCookies] returns inconsistent creation time
958         https://bugs.webkit.org/show_bug.cgi?id=185041
959         <rdar://problem/34684214>
960
961         Reviewed by Geoffrey Garen.
962
963         Add API test Coverage.
964
965         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
966         (TEST):
967
968 2018-05-08  Chris Dumez  <cdumez@apple.com>
969
970         Unreviewed, fix issue with running Speedometer PerfTest after r231450.
971
972         * Scripts/webkitpy/performance_tests/perftest.py:
973         (PerfTest):
974
975 2018-05-08  Chris Dumez  <cdumez@apple.com>
976
977         Unreviewed, fix issue with running Speedometer PerfTest after r231450.
978
979         * Scripts/webkitpy/performance_tests/perftest.py:
980         (PerfTest):
981
982 2018-05-07  Chris Dumez  <cdumez@apple.com>
983
984         Unreviewed, fix issue with running Speedometer PerfTest after r231450.
985
986         * Scripts/webkitpy/performance_tests/perftest.py:
987         (PerfTest):
988
989 2018-05-06  Filip Pizlo  <fpizlo@apple.com>
990
991         InPlaceAbstractState::beginBasicBlock shouldn't have to clear any abstract values
992         https://bugs.webkit.org/show_bug.cgi?id=185365
993
994         Reviewed by Saam Barati.
995         
996         Make it possible to measure compile times.
997
998         * Scripts/run-jsc-benchmarks:
999
1000 2018-05-07  Leo Balter  <leonardo.balter@gmail.com>
1001
1002         Test262-Runner: Add base module to the local deps - unicore/Exact.pl
1003         https://bugs.webkit.org/show_bug.cgi?id=185390
1004
1005         Reviewed by Michael Saboff.
1006
1007         * Scripts/test262/local/lib/perl5/unicore/Exact.pl: Added.
1008
1009 2018-05-07  Jonathan Bedard  <jbedard@apple.com>
1010
1011         Check for com.apple.datamigrator before declaring simulators booted
1012         https://bugs.webkit.org/show_bug.cgi?id=185315
1013         <rdar://problem/39986261>
1014
1015         Reviewed by David Kilzer.
1016
1017         * Scripts/webkitdirs.pm:
1018         (waitUntilProcessNotRunning): Wait until a process is not found.
1019         (relaunchIOSSimulator): Wait until com.apple.datamigrator stops running to declare
1020         a simulator booted.
1021         * Scripts/webkitpy/common/system/executive_mock.py:
1022         (MockExecutive2.__init__): Define _running_pids.
1023         * Scripts/webkitpy/xcode/simulated_device.py:
1024         (SimulatedDeviceManager.initialize_devices): Call wait_until_data_migration_is_done before
1025         declaring that devices have been booted, increase the timeout since data migration will frequently
1026         take longer than 60 seconds, especially with multiple simulators booting.
1027         (SimulatedDeviceManager.swap): Ditto.
1028         (SimulatedDeviceManager):
1029         (SimulatedDeviceManager.wait_until_data_migration_is_done): Wait until there are no com.apple.datamigrator
1030         processes running.
1031
1032 2018-05-07  Daniel Bates  <dabates@apple.com>
1033
1034         REGRESSION (r229955): run-webkit-tests runs tests in skipped directories and subdirectories of directory given on command line
1035         https://bugs.webkit.org/show_bug.cgi?id=185054
1036         <rdar://problem/39773209>
1037
1038         Reviewed by Ryosuke Niwa.
1039
1040         Fallback to MacPort.CURRENT_VERSION if we are not using a known named macOS and do not have Apple Additions.
1041
1042         Darwin-based ports have OS version-specific test expectations and are certified to support running tests using
1043         the currently shipping OS by way of a hardcoded class variable CURRENT_VERSION. The run-webkit-tests script
1044         depends on the OS version to find the applicable TestExpectations files to parse to compute the list of skipped
1045         tests for the port.
1046
1047         * Scripts/webkitpy/port/mac.py:
1048         (MacPort.__init__): Fall back to MacPort.CURRENT_VERSION if we are not using a known named macOS and do not
1049         have Apple Additions.
1050         * Scripts/webkitpy/port/mac_unittest.py:
1051         (MacTest.test_factory_with_future_version): Added.
1052         (MacTest.test_factory_with_future_version_and_apple_additions): Renamed from MacTest.test_factory_with_future_version()
1053         and added code to use the mock Apple Additions so that running this code with- and without- the real Apple Additions
1054         produces consistent results now that the Mac port's OS version falls back to MacPort.CURRENT_VERSION when Apple Additions
1055         is absent.
1056
1057 2018-05-07  Brian Burg  <bburg@apple.com>
1058
1059         Web Inspector: opt out of process swap on navigation if a Web Inspector frontend is connected
1060         https://bugs.webkit.org/show_bug.cgi?id=184861
1061         <rdar://problem/39153768>
1062
1063         Reviewed by Timothy Hatcher.
1064
1065         Add a new test that checks whether a new process is used for navigation when
1066         an Inspector is shown. Also check that the behavior reverts to normal after
1067         the Inspector has been closed.
1068
1069         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1070
1071 2018-05-04  Wenson Hsieh  <wenson_hsieh@apple.com>
1072
1073         [iOS] Multiple links in Mail are dropped in a single line, and are difficult to tell apart
1074         https://bugs.webkit.org/show_bug.cgi?id=185289
1075         <rdar://problem/35756912>
1076
1077         Reviewed by Tim Horton and Darin Adler.
1078
1079         Augment and rebaseline some iOS drag-and-drop API tests that handle dropping URLs as a part of multi-item drop
1080         sessions.
1081
1082         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1083         (TestWebKitAPI::TEST):
1084
1085 2018-05-04  Timothy Hatcher  <timothy@apple.com>
1086
1087         Deprecate legacy WebView and friends
1088         https://bugs.webkit.org/show_bug.cgi?id=185279
1089         rdar://problem/33268700
1090
1091         Reviewed by Tim Horton.
1092
1093         * MiniBrowser/Configurations/Base.xcconfig: Added GCC_PREPROCESSOR_DEFINITIONS
1094         to define DISABLE_LEGACY_WEBKIT_DEPRECATIONS.
1095
1096 2018-05-04  Leo Balter  <leonardo.balter@gmail.com>
1097
1098         Test262-Runner: Add base module to the local deps - unicore/PVA.pl
1099         https://bugs.webkit.org/show_bug.cgi?id=185314
1100
1101         Reviewed by Michael Saboff.
1102
1103         * Scripts/test262/local/lib/perl5/unicore/PVA.pl: Added.
1104
1105 2018-05-04  Wenson Hsieh  <whsieh@berkeley.edu>
1106
1107         REGRESSION: [ios-simulator] 3 WKWebViewAutofillTests API test failures seen with 11.3 SDK
1108         https://bugs.webkit.org/show_bug.cgi?id=184196
1109         <rdar://problem/39054481>
1110
1111         Reviewed by Tim Horton.
1112
1113         Removes some unnecessary workarounds to enable running app autofill tests against iOS versions
1114         earlier than 11.3. Also re-enables these tests.
1115
1116         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
1117         (TestWebKitAPI::TEST):
1118         (-[UITextAutofillSuggestion initWithUsername:password:]): Deleted.
1119         (+[UITextAutofillSuggestion autofillSuggestionWithUsername:password:]): Deleted.
1120
1121 2018-05-04  Myles C. Maxfield  <mmaxfield@apple.com>
1122
1123         Text shaping in the simple path is flipped in the y direction
1124         https://bugs.webkit.org/show_bug.cgi?id=185062
1125         <rdar://problem/39778678>
1126
1127         Reviewed by Simon Fraser.
1128
1129         Huge thanks to Ulrike Rausch of LiebeFonts for contributing the test fonts!!!
1130
1131         * Scripts/webkitpy/common/config/contributors.json:
1132
1133 2018-05-04  Leo Balter  <leonardo.balter@gmail.com>
1134
1135         Test262-Runner: place the processCLI inside the main call
1136         https://bugs.webkit.org/show_bug.cgi?id=185304
1137
1138         Reviewed by Michael Saboff.
1139
1140         * Scripts/test262/Runner.pm:
1141         (main):
1142
1143 2018-05-04  Carlos Garcia Campos  <cgarcia@igalia.com>
1144
1145         [GTK] Epiphany (GNOME Web) says "Error downloading: Service Unavailable." when trying to download an image from discogs.com
1146         https://bugs.webkit.org/show_bug.cgi?id=174730
1147
1148         Reviewed by Michael Catanzaro.
1149
1150         Update unit tests to check that User-Agent header is included in HTTP download requests.
1151
1152         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:
1153         (testDownloadRemoteFile):
1154         (testWebViewDownloadURI):
1155         (testPolicyResponseDownload):
1156         (testPolicyResponseDownloadCancel):
1157         (testDownloadMIMEType):
1158         (testContextMenuDownloadActions):
1159
1160 2018-05-03  Ross Kirsling  <ross.kirsling@sony.com>
1161
1162         [WinCairo] Test archive must use Python zipfile, just like build product.
1163         https://bugs.webkit.org/show_bug.cgi?id=185265
1164
1165         Reviewed by Per Arne Vollan.
1166
1167         * BuildSlaveSupport/test-result-archive:
1168         (archive_test_results):
1169         Copy over Win32-oriented archiving logic from built-product-archive.
1170
1171 2018-05-03  Leo Balter  <leonardo.balter@gmail.com>
1172
1173         cleanup modules usage for the Test262-Runner
1174         https://bugs.webkit.org/show_bug.cgi?id=185263
1175
1176         Reviewed by Michael Saboff.
1177
1178         * Scripts/test262-runner:
1179         * Scripts/test262/Runner.pm:
1180         (processCLI):
1181
1182 2018-05-03  Valerie R Young  <valerie@bocoup.com>
1183
1184         test262/Runner.pm: minor fixes
1185         https://bugs.webkit.org/show_bug.cgi?id=185250
1186
1187         Reviewed by Michael Saboff.
1188
1189         Add comments, change output and fix bug: unintended interpolation
1190         of filename when running jsc.
1191
1192         * Scripts/test262/Runner.pm:
1193         (processCLI):
1194         (main):
1195         (runTest):
1196
1197 2018-05-03  Chris Dumez  <cdumez@apple.com>
1198
1199         Load hangs if the WebProcess fails to launch
1200         https://bugs.webkit.org/show_bug.cgi?id=185225
1201         <rdar://problem/38249058>
1202
1203         Reviewed by Geoff Garen.
1204
1205         Add API test coverage.
1206
1207         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1208         * TestWebKitAPI/Tests/WebKitCocoa/WebContentProcessDidTerminate.mm: Added.
1209         (-[CrashOnStartNavigationDelegate _webView:webContentProcessDidTerminateWithReason:]):
1210         (-[CrashOnStartNavigationDelegate webView:didFinishNavigation:]):
1211         (-[CrashRecoveryScriptMessageHandler userContentController:didReceiveScriptMessage:]):
1212         (TEST):
1213
1214 2018-05-03  Don Olmstead  <don.olmstead@sony.com>
1215
1216         [WinCairo] Add JSC test bots
1217         https://bugs.webkit.org/show_bug.cgi?id=185234
1218
1219         Reviewed by Per Arne Vollan.
1220
1221         * BuildSlaveSupport/build.webkit.org-config/config.json:
1222         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1223         (RunJavaScriptCoreTests.start):
1224
1225 2018-05-03  Michael Catanzaro  <mcatanzaro@igalia.com>
1226
1227         WebKit should send fake macOS user agent to docs.google.com
1228         https://bugs.webkit.org/show_bug.cgi?id=185165
1229
1230         Reviewed by Carlos Garcia Campos.
1231
1232         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1233         (TestWebKitAPI::TEST):
1234
1235 2018-05-03  Valerie R Young  <valerie@bocoup.com>
1236
1237         test262/Runner.pm: performance improvements
1238         https://bugs.webkit.org/show_bug.cgi?id=185202
1239
1240         Reviewed by Michael Saboff.
1241
1242         Batch the tests by the number of processes, and give each process
1243         a file to save results to to avoid threading. Do not parallelize
1244         when running small sets of tests.
1245
1246         * Scripts/test262/Runner.pm:
1247         (processCLI):
1248         (main):
1249         (processFile):
1250         (processResult):
1251
1252 2018-05-03  Ryan Haddad  <ryanhaddad@apple.com>
1253
1254         Unreviewed, rolling out r231253.
1255
1256         The API test added with this change is crashing on the bots.
1257
1258         Reverted changeset:
1259
1260         "Web Inspector: opt out of process swap on navigation if a Web
1261         Inspector frontend is connected"
1262         https://bugs.webkit.org/show_bug.cgi?id=184861
1263         https://trac.webkit.org/changeset/231253
1264
1265 2018-05-03  Carlos Garcia Campos  <cgarcia@igalia.com>
1266
1267         REGRESSION(r222772): [GTK][WPE] WebProcess from WebKitGtk+ 2.19.9x SIGSEVs in WebKit::WebProcess::ensureNetworkProcessConnection() at Source/WebKit/WebProcess/WebProcess.cpp:1127
1268         https://bugs.webkit.org/show_bug.cgi?id=183348
1269
1270         Reviewed by Michael Catanzaro.
1271
1272         Add a test case to reproduce the crash.
1273
1274         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
1275         (testWebViewCloseQuickly):
1276         (beforeAll):
1277
1278 2018-05-02  Aditya Keerthi  <akeerthi@apple.com>
1279
1280         Can't copy and paste URLs that have no title into Mail (macOS)
1281         https://bugs.webkit.org/show_bug.cgi?id=185205
1282         <rdar://problem/36352406>
1283
1284         Reviewed by Tim Horton.
1285
1286         Added test to verify behavior when copying and pasting a URL without a title.
1287
1288         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.html:
1289         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm:
1290         (TestWebKitAPI::TEST):
1291
1292 2018-05-02  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1293
1294         [GTK] Generate a JSC bundle on the 64 and 32 bit release bots and upload it to webkitgtk.org (follow-up fix)
1295         https://bugs.webkit.org/show_bug.cgi?id=184699
1296
1297         Unreviewed follow-up fix after r231230.
1298
1299         * Scripts/generate-jsc-bundle:
1300         (generate_wrapper_script): Quote the arguments passed to jsc.
1301
1302 2018-05-02  Brian Burg  <bburg@apple.com>
1303
1304         Web Inspector: opt out of process swap on navigation if a Web Inspector frontend is connected
1305         https://bugs.webkit.org/show_bug.cgi?id=184861
1306         <rdar://problem/39153768>
1307
1308         Reviewed by Ryosuke Niwa.
1309
1310         Add a new test that checks whether a new process is used for navigation when
1311         an Inspector is shown. Also check that the behavior reverts to normal after
1312         the Inspector has been closed.
1313
1314         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1315
1316 2018-05-02  Valerie R Young  <valerie@bocoup.com>
1317
1318         test262/Runner.pm: save summary to file
1319         https://bugs.webkit.org/show_bug.cgi?id=185200
1320
1321         Reviewed by Michael Saboff.
1322
1323         * Scripts/test262/Runner.pm:
1324         (processCLI):
1325         (main):
1326         (summarizeResults):
1327
1328 2018-05-02  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1329
1330         [GTK] Generate a JSC bundle on the 64 and 32 bit release bots and upload it to webkitgtk.org
1331         https://bugs.webkit.org/show_bug.cgi?id=184699
1332
1333         Reviewed by Gustavo Noronha Silva.
1334
1335         This adds a new step for the GTK 64-bit release build bot and the
1336         GTK 32-bit release build&test bot.
1337
1338         This step will be run as one of the lasts ones (after the product
1339         is built) and will execute the script generate-jsc-bundle.
1340         This script will take care of creating a JSC bundle and uploading
1341         it to a server defined on a configuration file that has to be
1342         deployed on the bots with the required server data and credentials
1343         for this upload.
1344
1345         In this case, the built products should then be accessible at
1346         <https://webkitgtk.org/jsc-built-products>. But the implementation
1347         is not tied to any specific server. All the details about where
1348         to upload the file is done in configuration file that is kept
1349         private on each bot outside of the WebKit source tree.
1350
1351         The script also supports generating a JSC bundle locally and not
1352         uploading it anywhere. This is the default mode of running.
1353         The remote upload will only be activated if a --remote-config-file
1354         parameter is passed (which is done from the buildbot config)
1355
1356         * BuildSlaveSupport/build.webkit.org-config/config.json:
1357         * BuildSlaveSupport/build.webkit.org-config/factories.py:
1358         (BuildFactory):
1359         (BuildFactory.__init__):
1360         (TestFactory):
1361         (TestFactory.__init__):
1362         (BuildAndGenerateJSCBundleFactory):
1363         (BuildAndNonLayoutTestAndGenerateJSCBundleFactory):
1364         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1365         (GenerateJSCBundle):
1366         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1367         * Scripts/generate-jsc-bundle: Added.
1368         (ldd_get_libs_and_interpreter):
1369         (generate_readme):
1370         (generate_wrapper_script):
1371         (copy_and_remove_rpath):
1372         (createJSCBundle):
1373         (sha256sum):
1374         (uploadJSCBundle):
1375         (main):
1376
1377 2018-05-01  Ryosuke Niwa  <rniwa@webkit.org>
1378
1379         PSON: Make WebKitTestRunner work with process swap on navigation turned on
1380         https://bugs.webkit.org/show_bug.cgi?id=185111
1381
1382         Reviewed by Chris Dumez.
1383
1384         Add the basic support for running layout tests with process-swap-on-navigation turned on.
1385
1386         First, move m_whatToDump, m_dumpPixels, m_waitToDump, and m_dumpFrameLoadCallbacks from WebContent process
1387         to UI process so that calls to waitUntilDone, dumpAsText, etc... persist across process swaps.
1388
1389         In addition, initialize the injected bundle inside a new WebContent process when the first page is created.
1390         This instantiates objects such as TestRunner, GCController, etc... in the new process. The initialization
1391         can't be done in InjectedBundle::beginTesting because some steps in InjectedBundle::initialize require
1392         the current PageGroup and Page objects. We avoid clearing databases and app cache in this case.
1393
1394         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1395         (WTR::InjectedBundle::didCreatePage): Send "Initialization" message to UI process. This message returns
1396         all the dictionary values usually present in "BeginTest" message from UI process as well as "ResumeTesting"
1397         boolean which is set when this process was created as a result of a process swap on navgation. Invoke
1398         beginTesting with BegingTestingMode::Resume when this boolean is set.
1399         (WTR::InjectedBundle::didReceiveMessageToPage):
1400         (WTR::InjectedBundle::beginTesting): Don't clear database, app cache, etc... when initializing an injected
1401         bundle after a process swap on navigation.
1402         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1403         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1404         (WTR::InjectedBundlePage::dump):
1405         (WTR::InjectedBundlePage::frameDidChangeLocation):
1406         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1407         (WTR::TestRunner::TestRunner):
1408         (WTR::TestRunner::shouldDumpPixels const): Added.
1409         (WTR::TestRunner::setDumpPixels): Added.
1410         (WTR::TestRunner::dumpAsText):
1411         (WTR::TestRunner::whatToDump const): Added.
1412         (WTR::TestRunner::setWhatToDump): Added.
1413         (WTR::TestRunner::waitUntilDone):
1414         (WTR::TestRunner::setWaitUntilDone): Added.
1415         (WTR::TestRunner::shouldWaitUntilDone): Added.
1416         (WTR::TestRunner::notifyDone):
1417         (WTR::TestRunner::forceImmediateCompletion):
1418         (WTR::TestRunner::setShouldDumpFrameLoadCallbacks): Added.
1419         (WTR::TestRunner::shouldDumpFrameLoadCallbacks): Added.
1420         (WTR::TestRunner::setAudioResult):
1421         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1422         (WTR::TestRunner::dumpChildFramesAsText):
1423         (WTR::TestRunner::dumpDOMAsWebArchive):
1424         (WTR::TestRunner::setShouldDumpFrameLoadCallbacks): Moved to cpp.
1425         (WTR::TestRunner::whatToDump const): Moved to cpp.
1426         (WTR::TestRunner::shouldDumpMainFrameScrollPosition const):
1427         (WTR::TestRunner::shouldDumpPixels const): Moved to cpp.
1428         (WTR::TestRunner::shouldDumpFrameLoadCallbacks const): Moved to cpp.
1429         (WTR::TestRunner::waitToDump const): Renamed to shouldWaitUntilDone and moved to cpp.
1430         * WebKitTestRunner/TestInvocation.cpp:
1431         (WTR::TestInvocation::TestInvocation): Initialize m_dumpFrameLoadCallbacks here.
1432         (WTR::TestInvocation::shouldLogFrameLoadDelegates const): Deleted.
1433         (WTR::TestInvocation::createTestSettingsDictionary): Extracted from invoke().
1434         (WTR::TestInvocation::invoke): Sets m_startedTesting to true immediately afte sending "BeginTest" message.
1435         m_startedTesting is later used in didReceiveSynchronousMessageFromInjectedBundle to detect whether a given
1436         "Initialization" message is sent from a regular WebContent process (m_startedTesting is false) or the one
1437         started as a result of a process swap on navigation (m_startedTesting is true).
1438         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle): Added a bunch of new messgaes to
1439         support initializing the injected bundle in a process swapped after navigation and set/get messages for
1440         the states which must persist across process swaps within a test.
1441         * WebKitTestRunner/TestInvocation.h:
1442         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1443         * Tools/WebKitTestRunner/WhatToDump.h:
1444         (WTR::WhatToDump): Added.
1445
1446 2018-05-01  Leo Balter  <leonardo.balter@gmail.com>
1447
1448         Auto save the results for Test262
1449         https://bugs.webkit.org/show_bug.cgi?id=184926
1450
1451         Reviewed by Michael Saboff.
1452
1453         * Scripts/test262/Runner.pm:
1454         (processCLI):
1455         (main):
1456         (parseError):
1457         (processResult):
1458         (summarizeResults):
1459         * Scripts/test262/config.yaml: Renamed from Tools/Scripts/test262/test262-config.yaml.
1460
1461 2018-05-01  Jonathan Bedard  <jbedard@apple.com>
1462
1463         webkitpy: SIGKILL right after SIGTERM causes orphaned processes with 'xcrun simctl spawn'
1464         https://bugs.webkit.org/show_bug.cgi?id=185164
1465
1466         Reviewed by David Kilzer.
1467
1468         * Scripts/webkitpy/common/system/executive.py:
1469         (Executive.kill_process): First attempt will always send a SIGTERM, all subsequent attempts will
1470         send a SIGKILL. A SIGKILL with not be sent if the process is not running to avoid orphaning childen.
1471
1472 2018-05-01  Chris Dumez  <cdumez@apple.com>
1473
1474         REGRESSION (r230919): API test WebKit.AutoLayoutIntegration is a flaky failure
1475         https://bugs.webkit.org/show_bug.cgi?id=184918
1476         <rdar://problem/39705516>
1477
1478         Reviewed by Wenson Hsieh.
1479
1480         Make sure provisional load has started before calling beginLayoutAtMinimumWidth
1481         on the AutoLayoutWKWebView to restore pre-r230919 behavior. The load now starts
1482         asynchronously because we ask the client if it is OK to do the load and the policy
1483         delegates are asynchronous nowadays.
1484
1485         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
1486         (-[AutoLayoutWKWebView load:withWidth:expectingContentSize:resettingWidth:]):
1487         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
1488         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
1489         (-[TestNavigationDelegate webView:didStartProvisionalNavigation:]):
1490         (-[TestNavigationDelegate waitForDidStartProvisionalNavigation]):
1491         (-[WKWebView _test_waitForDidStartProvisionalNavigation]):
1492
1493 2018-05-01  Ross Kirsling  <ross.kirsling@sony.com>
1494
1495         [WinCairo] Align buildbot test stages with AppleWin.
1496         https://bugs.webkit.org/show_bug.cgi?id=185094
1497
1498         Reviewed by Brent Fulgham.
1499
1500         * BuildSlaveSupport/build.webkit.org-config/factories.py:
1501         (TestFactory.__init__):
1502         Do run API tests, don't run dashboard tests.
1503
1504         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1505         (RunUnitTests):
1506         Call run-api-tests with Python, not Perl (bugfix for r230998).
1507
1508         * Scripts/webkitpy/port/win.py:
1509         (WinPort.environment_for_api_tests):
1510         Retrieve necessary Windows environment variables.
1511
1512 2018-05-01  Eric Carlson  <eric.carlson@apple.com>
1513
1514         [MediaStream] remove WK1 support
1515         https://bugs.webkit.org/show_bug.cgi?id=185136
1516
1517         Reviewed by Youenn Fablet.
1518
1519         * DumpRenderTree/mac/UIDelegate.mm:
1520         (-[UIDelegate webView:decidePolicyForUserMediaRequestFromOrigin:listener:]): Deleted.
1521
1522 2018-05-01  Chris Dumez  <cdumez@apple.com>
1523
1524         [WKTR] Move navigation policy for response decision from InjectedBundle to UIProcess
1525         https://bugs.webkit.org/show_bug.cgi?id=185157
1526
1527         Reviewed by Geoffrey Garen.
1528
1529         Move navigation policy for response decision from InjectedBundle to UIProcess. This is a more
1530         common configuration and should therefore be the configuration we test by default.
1531
1532         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1533         (WTR::InjectedBundlePage::decidePolicyForResponse):
1534
1535 2018-05-01  Oleksandr Skachkov  <gskachkov@gmail.com>
1536
1537         WebAssembly: add support for stream APIs - JavaScript API
1538         https://bugs.webkit.org/show_bug.cgi?id=183442
1539
1540         Reviewed by Yusuke Suzuki and JF Bastien.
1541
1542         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1543
1544 2018-04-30  Mark Lam  <mark.lam@apple.com>
1545
1546         Apply PtrTags to the MetaAllocator and friends.
1547         https://bugs.webkit.org/show_bug.cgi?id=185110
1548         <rdar://problem/39533895>
1549
1550         Reviewed by Saam Barati.
1551
1552         Update the test to match MetaAllocator changes in WTF.
1553
1554         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
1555         (TestWebKitAPI::TEST_F):
1556         (WTF::tagForPtr):
1557         (WTF::ptrTagName):
1558
1559 2018-04-30  Alex Christensen  <achristensen@webkit.org>
1560
1561         Add WKUIDelegatePrivate equivalent of WKPageContextMenuClient getContextMenuFromProposedMenuAsync
1562         https://bugs.webkit.org/show_bug.cgi?id=180955
1563
1564         Reviewed by Andy Estes.
1565
1566         * TestWebKitAPI/Tests/WebKit/mac/ContextMenuImgWithVideo.mm:
1567         (-[ContextMenuImgWithVideoDelegate _webView:contextMenu:forElement:]):
1568         (-[ContextMenuImgWithVideoDelegate _webView:getContextMenuFromProposedMenu:forElement:userInfo:completionHandler:]):
1569
1570 2018-04-30  JF Bastien  <jfbastien@apple.com>
1571
1572         Use some C++17 features
1573         https://bugs.webkit.org/show_bug.cgi?id=185135
1574
1575         Reviewed by Alex Christensen.
1576
1577         * DumpRenderTree/PlatformMac.cmake:
1578         * gtk/ycm_extra_conf.py:
1579         (FlagsForFile):
1580
1581 2018-04-30  Yusuke Suzuki  <utatane.tea@gmail.com>
1582
1583         Use WordLock instead of std::mutex for Threading
1584         https://bugs.webkit.org/show_bug.cgi?id=185121
1585
1586         Reviewed by Geoffrey Garen.
1587
1588         * TestWebKitAPI/Tests/WTF/Signals.cpp:
1589         (TEST):
1590
1591 2018-04-30  Michael Catanzaro  <mcatanzaro@igalia.com>
1592
1593         [GTK] Webkit should spoof as Safari on a Mac when on Chase.com
1594         https://bugs.webkit.org/show_bug.cgi?id=185103
1595
1596         Reviewed by Carlos Garcia Campos.
1597
1598         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1599         (TestWebKitAPI::TEST):
1600
1601 2018-04-28  Sihui Liu  <sihui_liu@apple.com>
1602
1603         [Cocoa] Set HTTPOnly flag when converting Cookie to NSHTTPCookie
1604         https://bugs.webkit.org/show_bug.cgi?id=185052
1605
1606         Reviewed by Geoffrey Garen.
1607
1608         Modified API test to provide correct test cases for HTTPOnly flag.
1609
1610         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
1611         (TEST):
1612
1613 2018-04-28  Rick Waldron  <waldron.rick@gmail.com>
1614
1615         Token misspelled "tocken" in error message string
1616         https://bugs.webkit.org/show_bug.cgi?id=185030
1617
1618         Reviewed by Saam Barati.
1619
1620         * Scripts/test262/test262-expectations.yaml: Fix typo "tocken" => "token"
1621
1622 2018-04-27  Stephan Szabo  <stephan.szabo@sony.com>
1623
1624         [WinCairo] Support --no-copy for jsc tests in wincairo tests, add copying of dlls for copy case
1625         https://bugs.webkit.org/show_bug.cgi?id=185049
1626
1627         Reviewed by Keith Miller.
1628
1629         * Scripts/run-javascriptcore-tests:
1630         (runJSCStressTests):
1631         * Scripts/run-jsc-stress-tests:
1632
1633 2018-04-26  Ryosuke Niwa  <rniwa@webkit.org>
1634
1635         PSON: Triggering a navigation to an invalid URL creates a new WebContent process
1636         https://bugs.webkit.org/show_bug.cgi?id=185066
1637
1638         Reviewed by Youenn Fablet.
1639
1640         Added a new test case (ProcessSwap.NavigateToInvalidURL) for navigating to an invalid URL.
1641         WebKit should not swap WebContent process in this case.
1642
1643         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1644         (-[PSONNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
1645         (-[PSONUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1646
1647 2018-04-27  Nan Wang  <n_wang@apple.com>
1648
1649         AX: Accessibility needs to know which part of the content view is visible on iOS
1650         https://bugs.webkit.org/show_bug.cgi?id=185085
1651         <rdar://problem/39801363>
1652
1653         Reviewed by Chris Fleizach.
1654
1655         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1656         (WTR::AccessibilityUIElement::stringAttributeValue):
1657
1658 2018-04-27  Wenson Hsieh  <wenson_hsieh@apple.com>
1659
1660         [Extra zoom mode] Add a mechanism to override default viewport behaviors in extra zoom mode
1661         https://bugs.webkit.org/show_bug.cgi?id=185050
1662         <rdar://problem/39624038>
1663
1664         Reviewed by Tim Horton.
1665
1666         Remove a test that's no longer useful, now that the SPI it was testing is gone. This functionality is now
1667         tested by the layout test added in this patch.
1668
1669         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1670         * TestWebKitAPI/Tests/ios/ViewportSizingTests.mm: Removed.
1671
1672 2018-04-26  Ryan Haddad  <ryanhaddad@apple.com>
1673
1674         REGRESSION (r231039): RunUnitTests step reports disabled tests as failures
1675         https://bugs.webkit.org/show_bug.cgi?id=185061
1676
1677         Reviewed by Aakash Jain.
1678
1679         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1680         (RunUnitTests.countFailures): Return the difference between the total number of tests run and the number that passed.
1681         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Add a test.
1682
1683 2018-04-26  Ross Kirsling  <ross.kirsling@sony.com>
1684
1685         Add release bots for WinCairo.
1686         https://bugs.webkit.org/show_bug.cgi?id=185042
1687
1688         Reviewed by Lucas Forschler.
1689
1690         * BuildSlaveSupport/build.webkit.org-config/config.json:
1691         Add a release build bot and two test bots, replacing the outdated WinCairo release bots.
1692
1693 2018-04-26  Sihui Liu  <sihui_liu@apple.com>
1694
1695         -[WKHTTPCookieStore deleteCookie:completionHandler:] doesn't delete cookies
1696         https://bugs.webkit.org/show_bug.cgi?id=184938
1697         <rdar://problem/34737395>
1698
1699         Reviewed by Geoffrey Garen.
1700
1701         Add API test coverage.
1702
1703         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
1704         (TEST):
1705
1706 2018-04-26  Ross Kirsling  <ross.kirsling@sony.com>
1707
1708         WinCairo test bots should run JSC tests with options for Windows command prompt.
1709         https://bugs.webkit.org/show_bug.cgi?id=185019
1710
1711         Reviewed by Per Arne Vollan.
1712
1713         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1714         (RunJavaScriptCoreTests.start):
1715
1716 2018-04-26  Ross Kirsling  <ross.kirsling@sony.com>
1717
1718         WinCairo WKL Debug Test bot is not using DRT.
1719         https://bugs.webkit.org/show_bug.cgi?id=185009
1720
1721         Reviewed by Per Arne Vollan.
1722
1723         * BuildSlaveSupport/build.webkit.org-config/config.json:
1724
1725 2018-04-26  Per Arne Vollan  <pvollan@apple.com>
1726
1727         Disable content filtering in minimal simulator mode
1728         https://bugs.webkit.org/show_bug.cgi?id=185027
1729         <rdar://problem/39736091>
1730
1731         Reviewed by Jer Noble.
1732
1733         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1734
1735 2018-04-26  Brady Eidson  <beidson@apple.com>
1736
1737         Add a setting for keeping around all processes and always reusing them per-origin.
1738         <rdar://problem/39695798> and https://bugs.webkit.org/show_bug.cgi?id=185020
1739
1740         Reviewed by Andy Estes.
1741
1742         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1743
1744 2018-04-26  Andy VanWagoner  <thetalecrafter@gmail.com>
1745
1746         [INTL] Implement Intl.PluralRules
1747         https://bugs.webkit.org/show_bug.cgi?id=184312
1748
1749         Reviewed by JF Bastien.
1750
1751         Added Intl.PluralRules feature flag.
1752
1753         * Scripts/webkitperl/FeatureList.pm:
1754         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1755
1756 2018-04-25  Michael Catanzaro  <mcatanzaro@igalia.com>
1757
1758         [WPE] Build and link against latest WPEBackend and WPEBackend-fdo
1759         https://bugs.webkit.org/show_bug.cgi?id=184643
1760
1761         Reviewed by Žan Doberšek.
1762
1763         Add missing INCLUDE_DIRS in many places.
1764
1765         Adapt to single-header WPE includes.
1766
1767         Null-initialize padding to silence -Wmissing-field-initializers. (Yuck.)
1768
1769         * TestWebKitAPI/PlatformWPE.cmake:
1770         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
1771         (testWebViewWebBackend):
1772         * TestWebKitAPI/glib/PlatformWPE.cmake:
1773         * WebKitTestRunner/EventSenderProxy.h:
1774         * WebKitTestRunner/PlatformWPE.cmake:
1775         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
1776         * wpe/HeadlessViewBackend/CMakeLists.txt:
1777         * wpe/HeadlessViewBackend/HeadlessViewBackend.cpp:
1778         * wpe/HeadlessViewBackend/HeadlessViewBackend.h:
1779         * wpe/jhbuild.modules:
1780
1781 2018-04-25  Jonathan Bedard  <jbedard@apple.com>
1782
1783         REGRESSION (r230998): Bot watcher's dashboard doesn't display number of API test failures
1784         https://bugs.webkit.org/show_bug.cgi?id=184982
1785
1786         Rubber-stamped by Aakash Jain.
1787
1788         Correctly count the number of API test failures.
1789
1790         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1791         (RunUnitTests.countFailures): Count the number of test failures for the new run-api-tests.
1792         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1793         * Scripts/webkitpy/api_tests/manager.py:
1794         (Manager.run): Disabled tests are not run.
1795
1796 2018-04-25  Jiewen Tan  <jiewen_tan@apple.com>
1797
1798         Remove access to keychain from the WebContent process
1799         https://bugs.webkit.org/show_bug.cgi?id=184428
1800         <rdar://problem/13150903>
1801
1802         Reviewed by Brent Fulgham.
1803
1804         This patch does the followings:
1805         1. Added an API test for this patch.
1806         2. Instrument DumpRenderTree and WebKitTestRunner to take advantages of new SPIs.
1807
1808         * DumpRenderTree/mac/UIDelegate.mm:
1809         (-[UIDelegate signedPublicKeyAndChallengeStringForWebView:]):
1810         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1811         * TestWebKitAPI/Tests/mac/SSLKeyGenerator.mm: Added.
1812         (TestWebKitAPI::SSLKeyGeneratorTest::SetUp):
1813         (TestWebKitAPI::SSLKeyGeneratorTest::TearDown):
1814         (TestWebKitAPI::TEST_F):
1815         * WebKitTestRunner/TestController.cpp:
1816         (WTR::copySignedPublicKeyAndChallengeString):
1817         (WTR::TestController::createOtherPage):
1818         (WTR::TestController::createWebViewWithOptions):
1819
1820 2018-04-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1821
1822         [Extra zoom mode] The search field on www.bing.com is missing label text
1823         https://bugs.webkit.org/show_bug.cgi?id=184975
1824         <rdar://problem/39723081>
1825
1826         Reviewed by Tim Horton.
1827
1828         Adds UIScriptController.formInputLabel, which asynchronously requests the input label text for the currently
1829         focused element in extra zoom mode.
1830
1831         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1832         (WTR::UIScriptController::formInputLabel const):
1833         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1834         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1835         (WTR::UIScriptController::formInputLabel const):
1836         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1837         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1838         (WTR::UIScriptController::formInputLabel const):
1839
1840 2018-04-25  Michael Catanzaro  <mcatanzaro@igalia.com>
1841
1842         [WPE] Should load injected bundle from builddir in developer builds
1843         https://bugs.webkit.org/show_bug.cgi?id=184983
1844
1845         Reviewed by Carlos Alberto Lopez Perez.
1846
1847         Set WEBKIT_INJECTED_BUNDLE_PATH when running WPE MiniBrowser.
1848
1849         * Scripts/run-minibrowser:
1850
1851 2018-04-25  Michael Catanzaro  <mcatanzaro@igalia.com>
1852
1853         [WPE] libgstggtk.so broken in jhbuild environment
1854         https://bugs.webkit.org/show_bug.cgi?id=184984
1855
1856         Reviewed by Carlos Alberto Lopez Perez.
1857
1858         Don't pass --enable-glx=no when building libepoxy, to ensure it's compatible with
1859         gst-plugins-good.
1860
1861         * wpe/jhbuild.modules:
1862
1863 2018-04-25  Ryosuke Niwa  <rniwa@webkit.org>
1864
1865         PSON: Don't create a new process when navigating to a blob URL, data URL, and about:blank
1866         https://bugs.webkit.org/show_bug.cgi?id=184962
1867
1868         Reviewed by Youenn Fablet.
1869
1870         Added four test cases for navigating to a blob URL, data URL, and about:blank with process-swap-on-navigation turned on.
1871
1872         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1873         (ProcessSwap.SameOriginBlobNavigation): Added.
1874         (ProcessSwap.CrossOriginBlobNavigation): Added.
1875         (ProcessSwap.NavigateToAboutBlank): Added.
1876         (ProcessSwap.NavigateToDataURL): Added.
1877
1878 2018-04-25  Michael Catanzaro  <mcatanzaro@igalia.com>
1879
1880         [WPE] Remove deprecated functions and properties from the API
1881         https://bugs.webkit.org/show_bug.cgi?id=179295
1882
1883         Reviewed by Žan Doberšek.
1884
1885         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
1886         (testWebViewAuthenticationStorage): Disable this test for now. It will require some effort
1887         to rewrite LoadTrackingTest to not require the web view at construction time.
1888         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
1889         (testWebKitSettings): Don't test private browsing setting, which is gone.
1890         * TestWebKitAPI/glib/CMakeLists.txt: Disable TestCookieManager for now.
1891
1892 2018-04-25  Andy Estes  <aestes@apple.com>
1893
1894         [Mac] Number of drop items is always 0 when performing a DHTML drag
1895         https://bugs.webkit.org/show_bug.cgi?id=184943
1896
1897         Reviewed by Ryosuke Niwa.
1898
1899         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1900         * TestWebKitAPI/Tests/mac/DragAndDropPasteboardTests.mm:
1901         (-[DragInfo numberOfValidItemsForDrop]):
1902         (-[DragInfo setNumberOfValidItemsForDrop:]):
1903         (TestWebKitAPI::TEST):
1904         * TestWebKitAPI/Tests/mac/full-page-dropzone.html: Added.
1905
1906 2018-04-25  Jonathan Bedard  <jbedard@apple.com>
1907
1908         API test harness should be Python
1909         https://bugs.webkit.org/show_bug.cgi?id=181043
1910         <rdar://problem/36164410>
1911
1912         Reviewed by David Kilzer.
1913
1914         Run API tests from a Python script rather than Perl. The Python API tests have
1915         the same structure as the layout tests.
1916
1917         * Scripts/run-api-tests: Changed from Perl to Python.
1918         * Scripts/webkitpy/api_tests: Added.
1919         * Scripts/webkitpy/api_tests/__init__.py: Added.
1920         * Scripts/webkitpy/api_tests/manager.py: Added.
1921         (Manager):
1922         (Manager.__init__):
1923         (Manager._test_list_from_output): Construct a list of tests from the output of
1924         TestWTF and TestWebKitAPI.
1925         (Manager._find_test_subset): Given a list of all possible tests and command line
1926         arguments, return a list of tests which match the provided arguments.
1927         (Manager._collect_tests): Run TestWTF and TestWebKitAPI with --gtest_list_tests
1928         to determine which tests will be run.
1929         (Manager._print_test_result): Formatted print of a test with it's output.
1930         (Manager._print_tests_result_with_status): Print all tests and output for tests
1931         which ran with a specified exit status.
1932         (Manager.run): Collect all tests, run them and then print results from the run.
1933         * Scripts/webkitpy/api_tests/run_api_tests.py: Added.
1934         (main): Parse arguments, construct a port, early exit for illegal ports and
1935         then run tests.
1936         (run): Setup logging and printing before using the Manager to run tests.
1937         (parse_args): Use argparse to define all options used by run-api-tests.
1938         * Scripts/webkitpy/api_tests/runner.py: Added.
1939         (Runner):
1940         (Runner.__init__):
1941         (Runner._shard_tests): Split tests so that each suite runs together.
1942         (Runner.command_for_port): Run a command on the device specified by the given
1943         port object. Once <https://bugs.webkit.org/show_bug.cgi?id=175204> is completed,
1944         this function would be entirely replaced by the server_process factory owned
1945         by the port object.
1946         (Runner.run): Run all shards in the message_pool.
1947         (Runner.handle): Handle reports from child processes.
1948         (Runner.result_map_by_status): Return a mapping of tests to output for tests
1949         which exit with a specific status.
1950         (_Worker):
1951         (_Worker.__init__):
1952         (_Worker._filter_noisy_output): Filter out objc warnings since these polite the log.
1953         (_Worker._run_single_test): Runs a single test in a single child process.
1954         (_Worker._run_shard_with_binary): Attempts to run a group of tests in the same
1955         child process. If this technique fails, the remaining tests are run singly.
1956         (_Worker.handle): Run the specified shard.
1957         * Scripts/webkitpy/port/base.py:
1958         (Port):
1959         (Port.check_api_test_build): Check if TestWTF and TestWebKitAPI are built.
1960         (Port.environment_for_api_tests): Return the environment needed to run
1961         the TestWebKitAPI binary.
1962         (Port. path_to_api_test_binaries): Return a list of the path to all binaries
1963         used when running API tests.
1964         (Port._build_api_tests): Build TestWTF and TestWebKitAPI if required.
1965         * Scripts/webkitpy/port/mac.py:
1966         (MacPort.environment_for_api_tests): Enable GuardMalloc for API tests.
1967         * Scripts/webkitpy/port/server_process.py: 
1968         (ServerProcess.pop_all_buffered_stdout):
1969
1970 2018-04-25  Carlos Garcia Campos  <cgarcia@igalia.com>
1971
1972         Incorrect number of WebDriver test failures shown in the bots
1973         https://bugs.webkit.org/show_bug.cgi?id=184959
1974
1975         Reviewed by Michael Catanzaro.
1976
1977         The regular expression we are using to get the number of failures from the log is matching a particular test
1978         error output. Improve the regular expression to avoid matching other strings in the log. Ensure that only
1979         matches at the beginning of lines and add spaces after Unexpected and before the (<failures>).
1980
1981         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1982         (RunWebDriverTests.commandComplete):
1983
1984 2018-04-25  Carlos Garcia Campos  <cgarcia@igalia.com>
1985
1986         [GTK] Implement MouseEvent.buttons
1987         https://bugs.webkit.org/show_bug.cgi?id=184913
1988
1989         Reviewed by Žan Doberšek.
1990
1991         Include the mouse buttons state in WTR synthesized events.
1992
1993         * WebKitTestRunner/EventSenderProxy.h:
1994         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
1995         (WTR::EventSenderProxy::EventSenderProxy):
1996         (WTR::EventSenderProxy::createMouseButtonEvent):
1997         (WTR::EventSenderProxy::mouseDown):
1998         (WTR::EventSenderProxy::mouseUp):
1999         (WTR::EventSenderProxy::mouseMoveTo):
2000
2001 2018-04-24  Pablo Saavedra  <psaavedra@igalia.com>
2002
2003         [GTK][WPE] Fix triggered bot name on the WPE Debug Build bot
2004         https://bugs.webkit.org/show_bug.cgi?id=184954
2005
2006         Reviewed by Michael Catanzaro.
2007
2008         * BuildSlaveSupport/build.webkit.org-config/config.json:
2009
2010 2018-04-24  Saam Barati  <sbarati@apple.com>
2011
2012         Keep around a pre-warmed process when doing process swap on navigation
2013         https://bugs.webkit.org/show_bug.cgi?id=184765
2014         <rdar://problem/39685099>
2015
2016         Reviewed by Ryosuke Niwa and Brady Eidson.
2017
2018         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2019
2020 2018-04-24  Aakash Jain  <aakash_jain@apple.com>
2021
2022         [build.webkit.org] unit-tests fail when passwords.json is missing
2023         https://bugs.webkit.org/show_bug.cgi?id=180390
2024
2025         Reviewed by Carlos Alberto Lopez Perez.
2026
2027         * BuildSlaveSupport/build.webkit.org-config/loadConfig.py:
2028         (loadBuilderConfig): Add support for test_mode. Load mock passwords in test_mode.
2029         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
2030         (BuildBotConfigLoader._add_dependant_modules_to_sys_modules): Call _add_webkitpy_to_sys_path as well.
2031         (BuildBotConfigLoader._mock_open): Deleted.
2032         (BuildBotConfigLoader.load_config): Deleted.
2033
2034 2018-04-24  John Wilander  <wilander@apple.com>
2035
2036         From-Origin: Support for 'same' and 'same-site' response header, nested frame origin check
2037         https://bugs.webkit.org/show_bug.cgi?id=184560
2038         <rdar://problem/38901344>
2039
2040         Reviewed by Youenn Fablet and Daniel Bates.
2041
2042         This patch implements significant parts of https://github.com/whatwg/fetch/issues/687.
2043         We consume the From-Origin response header and only load the resource if:
2044         - The header is non-existent, empty, or invalid.
2045         - The header specifies 'same' and the resource's origin matches the originating
2046           document's origin and the origins up the frame tree.
2047         - The header specifies 'same-site' and the resource's eTLD+1 matches the originating
2048           document's eTLD+1 and the eTLD+1 of the documents up the frame tree.
2049
2050         This feature is experimental and off by default.
2051
2052         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2053         * TestWebKitAPI/Tests/WebCore/HTTPParsers.cpp: Added.
2054         (TestWebKitAPI::TEST):
2055             Tests for From-Origin header parsing.
2056
2057 2018-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2058
2059         Unreviewed. Update W3C WebDriver imported tests.
2060
2061         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:
2062         (WebDriverW3CExecutor.__init__):
2063
2064 2018-04-24  Zan Dobersek  <zdobersek@igalia.com>
2065
2066         [WPE] Remove libgbm dependency
2067         https://bugs.webkit.org/show_bug.cgi?id=184906
2068
2069         Reviewed by Carlos Garcia Campos.
2070
2071         Stop searching for libgbm, using its compiler flags for the
2072         HeadlessViewBackend compilation and linking against the .so object.
2073         This is not necessary anymore after r230562 switched to a different
2074         backend implementation for testing.
2075
2076         * wpe/HeadlessViewBackend/CMakeLists.txt:
2077         * wpe/install-dependencies:
2078
2079 2018-04-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2080
2081         [GLIB] Make it possible to use a different timeout for slow test cases in GLib tests
2082         https://bugs.webkit.org/show_bug.cgi?id=184816
2083
2084         Reviewed by Michael Catanzaro.
2085
2086         Pass a function from api test runner to glib test runner to check if a test is slow and use the given slow
2087         timeout.
2088
2089         * TestWebKitAPI/glib/TestExpectations.json:
2090         * glib/api_test_runner.py:
2091         (TestRunner._run_test_glib.is_slow_test):
2092         (TestRunner._run_test_glib):
2093         * glib/glib_test_runner.py:
2094         (GLibTestRunner.__init__):
2095         (GLibTestRunner._stop_timeout):
2096         (GLibTestRunner._subtest_start):
2097         (GLibTestRunner._subtest_end):
2098
2099 2018-04-23  Wenson Hsieh  <wenson_hsieh@apple.com>
2100
2101         [Extra zoom mode] REGRESSION(230860) Unable to change time input values using UI
2102         https://bugs.webkit.org/show_bug.cgi?id=184901
2103         <rdar://problem/39664797>
2104
2105         Reviewed by Tim Horton.
2106
2107         Introduce a new UIScriptController method to set the value of a currently focused input of type time, by
2108         interacting with the UI. See WebKit ChangeLogs for more detail.
2109
2110         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2111         (WTR::UIScriptController::setTimePickerValue):
2112         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2113         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2114         (WTR::UIScriptController::setTimePickerValue):
2115         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2116         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2117         (WTR::UIScriptController::setTimePickerValue):
2118
2119 2018-04-23  Zalan Bujtas  <zalan@apple.com>
2120
2121         [LayoutFormattingContext] Initial commit.
2122         https://bugs.webkit.org/show_bug.cgi?id=184896
2123
2124         Reviewed by Antti Koivisto.
2125
2126         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2127
2128 2018-04-23  Chris Dumez  <cdumez@apple.com>
2129
2130         [WKTR] Move navigation policy decision from the injected bundle to the UIProcess
2131         https://bugs.webkit.org/show_bug.cgi?id=184801
2132
2133         Reviewed by Geoffrey Garen.
2134
2135         Move navigation policy decision from the injected bundle to the UIProcess in WebKitTestRunner.
2136         This is a more common configuration and therefore should be the default testing configuration.
2137
2138         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2139         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
2140         Always respond with 'PassThrough' in the InjectedBundle so the UIProcess
2141         is now asked for the policy decision.
2142
2143 2018-04-23  Pablo Saavedra  <psaavedra@igalia.com>
2144
2145         [GTK][WPE] Add Debug bots (build and tests) for WPE
2146         https://bugs.webkit.org/show_bug.cgi?id=184887
2147
2148         Reviewed by Carlos Alberto Lopez Perez.
2149
2150         Deployed 2 new bots for WPE Debug: wpe-linux-bot-3 and
2151         wpe-linux-bot-4
2152
2153         Both bots have already the credentials ready to authenticated against
2154         build.webkit.org. They provides the bots for the "debug" configuration over
2155         the "WPE" platform and building for the "x86_64" architecture:
2156         WPE Linux 64-bit Debug (Build) and WPE Linux 64-bit Debug (Tests) 
2157
2158         * BuildSlaveSupport/build.webkit.org-config/config.json:
2159         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
2160
2161 2018-04-23  Chris Dumez  <cdumez@apple.com>
2162
2163         HTML String load cannot be prevented by responding 'Cancel' asynchronously in decidePolicyForNavigationAction
2164         https://bugs.webkit.org/show_bug.cgi?id=184848
2165         <rdar://problem/39145306>
2166
2167         Reviewed by Brady Eidson.
2168
2169         Add API test coverage.
2170
2171         * TestWebKitAPI/Tests/WebKitCocoa/DecidePolicyForNavigationAction.mm:
2172         (-[DecidePolicyForNavigationActionController webView:decidePolicyForNavigationAction:decisionHandler:]):
2173         (TEST):
2174
2175 2018-04-23  Michael Catanzaro  <mcatanzaro@igalia.com>
2176
2177         [GTK][WPE] TestSSL fails due to additional TLS errors returned
2178         https://bugs.webkit.org/show_bug.cgi?id=184860
2179
2180         Reviewed by Carlos Garcia Campos.
2181
2182         Add script and config file for regenerating the test certificate.
2183         Regenerate it. TestSSL no longer fails on my machine.
2184
2185         I do see a ton of network process crashes and JavaScript errors, none of
2186         which prevent the test from passing, but this commit only claims to fix
2187         the certificate validation portion of the test.
2188
2189         * TestWebKitAPI/Tests/WebKitGLib/resources/generate-test-cert.sh: Added.
2190         * TestWebKitAPI/Tests/WebKitGLib/resources/test-cert.conf: Added.
2191         * TestWebKitAPI/Tests/WebKitGLib/resources/test-cert.pem:
2192
2193 2018-04-20  Carlos Garcia Campos  <cgarcia@igalia.com>
2194
2195         [GLIB] ERROR: Thread was unable to be detached when running /jsc/vm test in debug
2196         https://bugs.webkit.org/show_bug.cgi?id=184815
2197
2198         Reviewed by Michael Catanzaro.
2199
2200         This is because in the test we are calling both join and detach. We should only call join.
2201
2202         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2203         (testsJSCVirtualMachine):
2204
2205 2018-04-20  Carlos Garcia Campos  <cgarcia@igalia.com>
2206
2207         [GLIB] Test /jsc/prototypes crashes in debug
2208         https://bugs.webkit.org/show_bug.cgi?id=184814
2209
2210         Reviewed by Michael Catanzaro.
2211
2212         We should also call the constructor/destructor of Bar struct to ensure Foo is constructed.
2213
2214         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2215         (barCreate):
2216         (barFree):
2217
2218 2018-04-20  Michael Catanzaro  <mcatanzaro@igalia.com>
2219
2220         REGRESSION(r228088): [SOUP] Check TLS errors for WebSockets on GTlsConnection::accept-certificate
2221         https://bugs.webkit.org/show_bug.cgi?id=184804
2222
2223         Reviewed by Carlos Garcia Campos.
2224
2225         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
2226         (WebSocketTest::WebSocketTest):
2227         (WebSocketTest::~WebSocketTest):
2228         (WebSocketTest::serverWebSocketCallback):
2229         (WebSocketTest::webSocketTestResultCallback):
2230         (WebSocketTest::connectToServerAndWaitForEvents):
2231         (testWebSocketTLSErrors):
2232         (beforeAll):
2233
2234 2018-04-20  Chris Dumez  <cdumez@apple.com>
2235
2236         Unreviewed, update 2 more API tests after r230876.
2237
2238         * TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:
2239         (TEST):
2240         * TestWebKitAPI/Tests/ios/ScrollViewInsetTests.mm:
2241         (TestWebKitAPI::TEST):
2242
2243 2018-04-20  Tim Horton  <timothy_horton@apple.com>
2244
2245         Adjust geolocation feature flag
2246         https://bugs.webkit.org/show_bug.cgi?id=184856
2247
2248         Reviewed by Wenson Hsieh.
2249
2250         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2251
2252 2018-04-20  Chris Dumez  <cdumez@apple.com>
2253
2254         REGRESSION (r229828): web view doesn’t update or respond to resizing until client calls policy decision handler
2255         https://bugs.webkit.org/show_bug.cgi?id=184210
2256         <rdar://problem/39072354>
2257
2258         Reviewed by Wenson Hsieh.
2259
2260         * TestWebKitAPI/Tests/WebKit/large-red-square-image.html:
2261         * TestWebKitAPI/Tests/WebKitCocoa/dragstart-change-selection-offscreen.html:
2262         Add viewport meta tags.
2263
2264         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
2265         (-[WKWebView _test_waitForDidFinishNavigation]):
2266         Update _test_waitForDidFinishNavigation to wait for the next presentation update
2267         to make iOS API tests happy without having to modify each of them.
2268
2269 2018-04-20  Timothy Hatcher  <timothy@apple.com>
2270
2271         REGRESSION: API test WebKit.BackgroundColorSystemColor is failing
2272
2273         https://bugs.webkit.org/show_bug.cgi?id=184849
2274         rdar://problem/39386405
2275
2276         Reviewed by Brian Burg.
2277
2278         * TestWebKitAPI/Tests/mac/BackgroundColor.mm:
2279         (TestWebKitAPI::TEST): Use CGColorEqualToColor since we might get a different
2280         CGColor pointer from NSColor each time.
2281
2282 2018-04-20  Wenson Hsieh  <wenson_hsieh@apple.com>
2283
2284         [Extra zoom mode] Injected bundle form client should be notified when editing text fields
2285         https://bugs.webkit.org/show_bug.cgi?id=184822
2286         <rdar://problem/38807319>
2287
2288         Reviewed by Tim Horton.
2289
2290         Add WebKitTestRunner support for listening to form editing SPI hooks in the injected bundle. The new layout test
2291         installs callbacks that listen for "begin editing", "end editing", and "text changed" calls to injected bundle
2292         SPI. See other ChangeLogs for more detail.
2293
2294         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2295         (WTR::UIScriptController::enterText):
2296         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2297
2298         Add UIScriptController support for simulating text entry in the currently focused element.
2299
2300         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2301         (WTR::UIScriptController::enterText):
2302         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2303         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2304
2305         Add TestRunner bindings for registering injected bundle form client callbacks.
2306
2307         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2308         (WTR::handleTextDidChangeInTextField):
2309         (WTR::handleTextFieldDidBeginEditing):
2310         (WTR::handleTextFieldDidEndEditing):
2311         (WTR::InjectedBundle::didCreatePage):
2312
2313         Set the injected bundle form editor client.
2314
2315         (WTR::InjectedBundle::setUpInjectedBundleClients):
2316         (WTR::InjectedBundle::textDidChangeInTextField):
2317         (WTR::InjectedBundle::textFieldDidBeginEditing):
2318         (WTR::InjectedBundle::textFieldDidEndEditing):
2319         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2320         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2321         (WTR::TestRunner::installTextDidChangeInTextFieldCallback):
2322         (WTR::TestRunner::textDidChangeInTextFieldCallback):
2323         (WTR::TestRunner::installTextFieldDidBeginEditingCallback):
2324         (WTR::TestRunner::textFieldDidBeginEditingCallback):
2325         (WTR::TestRunner::installTextFieldDidEndEditingCallback):
2326         (WTR::TestRunner::textFieldDidEndEditingCallback):
2327         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2328         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2329         (WTR::UIScriptController::enterText):
2330
2331 2018-04-20  Youenn Fablet  <youenn@apple.com>
2332
2333         WebPage sometimes incorrectly rules out PDF as a mime type that can be showed
2334         https://bugs.webkit.org/show_bug.cgi?id=184369
2335
2336         Reviewed by Chris Dumez.
2337
2338         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
2339         (TEST):
2340
2341 2018-04-20  Daniel Bates  <dabates@apple.com>
2342
2343         Remove Strong Password decoration when text field type changes
2344         https://bugs.webkit.org/show_bug.cgi?id=184795
2345         <rdar://problem/38325108>
2346
2347         Reviewed by Antti Koivisto.
2348
2349         Add a unit test to ensure the injected bundle API and WebKit UI delegate SPI is invoked
2350         when the field has the Strong Password button and its type changes.
2351
2352         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2353         * TestWebKitAPI/Tests/WebKitCocoa/DidResignInputElementStrongPasswordAppearance.mm: Added.
2354         (didResignInputElementStrongPasswordAppearance):
2355         (-[DidResignInputElementStrongPasswordAppearance webProcessPlugIn:didCreateBrowserContextController:]):
2356         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2357         (-[DidResignInputElementStrongPasswordAppearanceDelegate _webView:didResignInputElementStrongPasswordAppearanceWithUserInfo:]):
2358         (-[DidResignInputElementStrongPasswordAppearanceDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2359         (TEST):
2360
2361 2018-04-20  Brady Eidson  <beidson@apple.com>
2362
2363         Add a test to verify load/unload/pageshow/pagehide all work with process swapping.
2364         https://bugs.webkit.org/show_bug.cgi?id=184807
2365
2366         Reviewed by Chris Dumez.
2367
2368         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2369         (-[PSONMessageHandler userContentController:didReceiveScriptMessage:]):
2370
2371 2018-04-20  Carlos Garcia Campos  <cgarcia@igalia.com>
2372
2373         Unreviewed. Mark TestJSC as slow in debug.
2374
2375         Only /jsc/vm is slow, but GLib API test runner only checks the test binary for GLib tests.
2376
2377         * TestWebKitAPI/glib/TestExpectations.json:
2378
2379 2018-04-20  Carlos Garcia Campos  <cgarcia@igalia.com>
2380
2381         [GTK] Local cross references are broken in API documentation
2382         https://bugs.webkit.org/show_bug.cgi?id=184771
2383
2384         Reviewed by Michael Catanzaro.
2385
2386         The problem is that gtkdoc-fixxref expects the links to be in the form html/modulename (like the installed
2387         ones), but we generate the documentation as modulename/html. So, links to WebKitDOM or JSC are generated as
2388         ../html/Foo. The rebase command considers html to be the module name in this case, creating broken links in all
2389         the cases.
2390
2391         * gtk/gtkdoc.py:
2392         (GTKDoc._copy_doc_files_to_output_dir): We don't have any html dir in the source tree so, we are not copying
2393         anything here.
2394         (GTKDoc._run_gtkdoc_mkhtml): Create the html dir here using html/modulename instead now.
2395         (GTKDoc._run_gtkdoc_fixxref): Pass the new directory as module dir to gtkdoc-fixxref and fix several links for
2396         which gtkdoc-fixxref always uses absolute paths.
2397         * gtk/manifest.txt.in: Update the documentation html paths and include the JSC GLib API in the tarball too.
2398
2399 2018-04-19  Brady Eidson  <beidson@apple.com>
2400
2401         Make back forward cache work with process swapping.
2402         <rdar://problem/38676604> and https://bugs.webkit.org/show_bug.cgi?id=184793
2403
2404         Reviewed by Chris Dumez.
2405
2406         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2407
2408 2018-04-19  David Kilzer  <ddkilzer@apple.com>
2409
2410         Enable Objective-C weak references
2411         <https://webkit.org/b/184789>
2412         <rdar://problem/39571716>
2413
2414         Reviewed by Dan Bernstein.
2415
2416         * ContentExtensionTester/Configurations/Base.xcconfig:
2417         (CLANG_ENABLE_OBJC_WEAK): Enable.
2418         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2419         (CLANG_ENABLE_OBJC_WEAK): Enable.
2420         * ImageDiff/cg/Configurations/Base.xcconfig:
2421         (CLANG_ENABLE_OBJC_WEAK): Enable.
2422         * MiniBrowser/Configurations/Base.xcconfig:
2423         (CLANG_ENABLE_OBJC_WEAK): Enable.
2424         * TestWebKitAPI/Configurations/Base.xcconfig:
2425         (CLANG_ENABLE_OBJC_WEAK): Enable.
2426         * WebEditingTester/Configurations/Base.xcconfig:
2427         (CLANG_ENABLE_OBJC_ARC): Re-order.
2428         * WebKitLauncher/Configurations/Base.xcconfig: Add newline at
2429         end of file.
2430         (CLANG_ENABLE_OBJC_WEAK): Enable.
2431         * WebKitTestRunner/Configurations/Base.xcconfig:
2432         (CLANG_ENABLE_OBJC_WEAK): Enable.
2433
2434 2018-04-19  Chris Dumez  <cdumez@apple.com>
2435
2436         REGRESSION (r229133): decidePolicyForNavigationAction not called for loading an HTML string
2437         https://bugs.webkit.org/show_bug.cgi?id=184209
2438         <rdar://problem/39145306>
2439
2440         Reviewed by Ryosuke Niwa.
2441
2442         Add API test coverage.
2443
2444         * TestWebKitAPI/Tests/WebKitCocoa/DecidePolicyForNavigationAction.mm:
2445         (TEST):
2446
2447 2018-04-18  Ross Kirsling  <ross.kirsling@sony.com>
2448
2449         [WinCairo][EWS] Build bot should clean user temp directory each time.
2450         https://bugs.webkit.org/show_bug.cgi?id=184761
2451
2452         Reviewed by Lucas Forschler.
2453
2454         * EWSTools/Start-Queue.ps1:
2455         Clean user's temp directory before each build, so that Windows git doesn't fill it up over time.
2456
2457 2018-04-18  Ross Kirsling  <ross.kirsling@sony.com>
2458
2459         Buildbots using Python zipfile should enable compression
2460         https://bugs.webkit.org/show_bug.cgi?id=184759
2461
2462         Reviewed by Lucas Forschler.
2463
2464         * BuildSlaveSupport/built-product-archive:
2465         (createZipManually):
2466         Default is to archive without compressing, so tell it to compress as well. 
2467
2468 2018-04-18  Nan Wang  <n_wang@apple.com>
2469
2470         AX: [macOS] WebKit hangs when triggering an alert from an AOM increment event
2471         https://bugs.webkit.org/show_bug.cgi?id=184742
2472
2473         Reviewed by Chris Fleizach.
2474
2475         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2476         (AccessibilityUIElement::increment):
2477         (AccessibilityUIElement::decrement):
2478         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2479         (WTR::AccessibilityUIElement::asyncIncrement):
2480         (WTR::AccessibilityUIElement::asyncDecrement):
2481         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2482         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2483         (WTR::AccessibilityUIElement::increment):
2484         (WTR::AccessibilityUIElement::decrement):
2485         (WTR::AccessibilityUIElement::asyncIncrement):
2486         (WTR::AccessibilityUIElement::asyncDecrement):
2487
2488 2018-04-18  Ross Kirsling  <ross.kirsling@sony.com>
2489
2490         Fix archive step for WinCairo build bot.
2491         https://bugs.webkit.org/show_bug.cgi?id=184715
2492
2493         Reviewed by Lucas Forschler.
2494
2495         * BuildSlaveSupport/built-product-archive:
2496         (archiveBuiltProduct):
2497         (extractBuiltProduct):
2498
2499 2018-04-18  Sihui Liu  <sihui_liu@apple.com>
2500
2501         REGRESSION: Using the reload button while offline pushes identical pages onto the back/forward list
2502         https://bugs.webkit.org/show_bug.cgi?id=184570
2503         <rdar://problem/34807323>
2504
2505         Reviewed by Chris Dumez.
2506
2507         Add API test coverage.
2508
2509         * TestWebKitAPI/Tests/WebKitCocoa/LoadAlternateHTMLString.mm:
2510         (TEST):
2511
2512 2018-04-18  Chris Dumez  <cdumez@apple.com>
2513
2514         Add support for converting a local window to a remote window
2515         https://bugs.webkit.org/show_bug.cgi?id=184515
2516         <rdar://problem/39011318>
2517
2518         Reviewed by Ryosuke Niwa.
2519
2520         * MiniBrowser/mac/AppDelegate.m:
2521         (defaultConfiguration):
2522         * MiniBrowser/mac/SettingsController.h:
2523         * MiniBrowser/mac/SettingsController.m:
2524         (-[SettingsController _populateMenu]):
2525         (-[SettingsController validateMenuItem:]):
2526         (-[SettingsController processSwapOnWindowOpenWithOpenerEnabled]):
2527         (-[SettingsController toggleProcessSwapOnWindowOpenWithOpener:]):
2528         Add menu entry in minibrowser to turn on process swap on cross-origin window.open().
2529
2530         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2531         Turn on process swap on cross-origin window.open() for corresponding test and update
2532         test to expect that a new WebProcess is created.
2533
2534         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2535         (WTR::InjectedBundlePage::decidePolicyForResponse):
2536         Add null checks for injectedBundle.testRunner(). When we swap process on navigation,
2537         the InjectedBundlePage::decidePolicyForResponse() gets called in the new process.
2538         In this new process, we have constructed a InjectedBundlePage for the page but we
2539         have not initialized the InjectedBundle members such as testRunner.
2540
2541         * WebKitTestRunner/TestController.cpp:
2542         (WTR::TestController::createWebViewWithOptions):
2543         (WTR::updateTestOptionsFromTestHeader):
2544         * WebKitTestRunner/TestOptions.h:
2545         (WTR::TestOptions::hasSameInitializationOptions const):
2546         Add a way for layout tests to turn on process swap on navigation via a test header.
2547
2548 2018-04-18  Yusuke Suzuki  <utatane.tea@gmail.com>
2549
2550         Unreviewed, reland r230697, r230720, and r230724.
2551         https://bugs.webkit.org/show_bug.cgi?id=184600
2552
2553         * Scripts/run-jsc-stress-tests:
2554
2555 2018-04-17  Carlos Garcia Campos  <cgarcia@igalia.com>
2556
2557         [GLIB] Make it possible to handle JSCClass external properties not added to the prototype
2558         https://bugs.webkit.org/show_bug.cgi?id=184687
2559
2560         Reviewed by Michael Catanzaro.
2561
2562         Add test cases for the new API.
2563
2564         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2565         (fooCreate):
2566         (fooFree):
2567         (fooGetProperty):
2568         (fooSetProperty):
2569         (testJSCPromises):
2570         (testJSCGarbageCollector):
2571         (testsJSCVirtualMachine):
2572         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.cpp:
2573         (windowObjectClearedCallback):
2574
2575 2018-04-17  Wenson Hsieh  <wenson_hsieh@apple.com>
2576
2577         [Extra zoom mode] Programmatically changing focus when an element already has focus is a confusing experience
2578         https://bugs.webkit.org/show_bug.cgi?id=184635
2579         <rdar://problem/39440642>
2580
2581         Reviewed by Tim Horton.
2582
2583         Add plumbing to support invoking `didHideKeyboardCallback` and `didShowKeyboardCallback` when (respectively)
2584         dismissing or presenting fullscreen input view controllers in extra zoom mode.
2585
2586         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2587         (-[TestRunnerWKWebView initWithFrame:configuration:]):
2588         (-[TestRunnerWKWebView dealloc]):
2589         (-[TestRunnerWKWebView _invokeShowKeyboardCallbackIfNecessary]):
2590         (-[TestRunnerWKWebView _invokeHideKeyboardCallbackIfNecessary]):
2591         (-[TestRunnerWKWebView _keyboardDidShow:]):
2592         (-[TestRunnerWKWebView _keyboardDidHide:]):
2593         (-[TestRunnerWKWebView _webView:didPresentFocusedElementViewController:]):
2594         (-[TestRunnerWKWebView _webView:didDismissFocusedElementViewController:]):
2595
2596 2018-04-17  Michael Catanzaro  <mcatanzaro@igalia.com>
2597
2598         [GTK] Webkit should spoof as Safari on a Mac for Outlook.com
2599         https://bugs.webkit.org/show_bug.cgi?id=184573
2600
2601         Reviewed by Carlos Alberto Lopez Perez.
2602
2603         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
2604         (TestWebKitAPI::TEST):
2605
2606 2018-04-17  Fujii Hironori  <Hironori.Fujii@sony.com>
2607
2608         [WinCairo][TestWebKitAPI] Implement PlatformWebView for TestWebKit
2609         https://bugs.webkit.org/show_bug.cgi?id=184524
2610
2611         Reviewed by Alex Christensen.
2612
2613         Resurrect PlatformWebView for Windows port which was removed in Bug 104607.
2614
2615         * TestWebKitAPI/PlatformWebView.h:
2616         * TestWebKitAPI/PlatformWin.cmake:
2617         * TestWebKitAPI/win/InjectedBundleControllerWin.cpp: Added.
2618         (TestWebKitAPI::InjectedBundleController::platformInitialize):
2619         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp: Added.
2620         (TestWebKitAPI::Util::moduleDirectory):
2621         (TestWebKitAPI::Util::createInjectedBundlePath):
2622         (TestWebKitAPI::Util::createURLForResource):
2623         (TestWebKitAPI::Util::URLForNonExistentResource):
2624         (TestWebKitAPI::Util::isKeyDown):
2625         * TestWebKitAPI/win/PlatformWebViewWin.cpp: Added.
2626         (TestWebKitAPI::PlatformWebView::registerWindowClass):
2627         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2628         (TestWebKitAPI::PlatformWebView::initialize):
2629         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
2630         (TestWebKitAPI::PlatformWebView::page const):
2631         (TestWebKitAPI::PlatformWebView::resizeTo):
2632         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
2633         (TestWebKitAPI::PlatformWebView::simulateAltKeyPress):
2634         (TestWebKitAPI::PlatformWebView::simulateRightClick):
2635         (TestWebKitAPI::PlatformWebView::simulateMouseMove):
2636         (TestWebKitAPI::PlatformWebView::wndProc):
2637         * TestWebKitAPI/win/UtilitiesWin.cpp: Added.
2638         (TestWebKitAPI::Util::run):
2639         (TestWebKitAPI::Util::spinRunLoop):
2640         (TestWebKitAPI::Util::sleep):
2641
2642 2018-04-17  Jonathan Bedard  <jbedard@apple.com>
2643
2644         Fix hasher tests for system with 32 bit longs
2645         https://bugs.webkit.org/show_bug.cgi?id=184708
2646         <rdar://problem/39459977>
2647
2648         Reviewed by Mark Lam.
2649
2650         Some systems have 32 bit longs. The Hasher WTF tests should handle this case.
2651
2652         * TestWebKitAPI/Tests/WTF/Hasher.cpp:
2653         (TestWebKitAPI::TEST):
2654
2655 2018-04-17  Commit Queue  <commit-queue@webkit.org>
2656
2657         Unreviewed, rolling out r230697, r230720, and r230724.
2658         https://bugs.webkit.org/show_bug.cgi?id=184717
2659
2660         These caused multiple failures on the Test262 testers.
2661         (Requested by mlewis13 on #webkit).
2662
2663         Reverted changesets:
2664
2665         "[WebAssembly][Modules] Prototype wasm import"
2666         https://bugs.webkit.org/show_bug.cgi?id=184600
2667         https://trac.webkit.org/changeset/230697
2668
2669         "[WebAssembly][Modules] Implement function import from wasm
2670         modules"
2671         https://bugs.webkit.org/show_bug.cgi?id=184689
2672         https://trac.webkit.org/changeset/230720
2673
2674         "[JSC] Rename runWebAssembly to runWebAssemblySuite"
2675         https://bugs.webkit.org/show_bug.cgi?id=184703
2676         https://trac.webkit.org/changeset/230724
2677
2678 2018-04-17  Jonathan Bedard  <jbedard@apple.com>
2679
2680         Unreviewed rollout of r230632. Regression in memory usage.
2681
2682         That bug tracked in https://bugs.webkit.org/show_bug.cgi?id=184569.
2683
2684         * DumpRenderTree/TestOptions.h:
2685         * DumpRenderTree/mac/DumpRenderTree.mm:
2686         (runTest):
2687         (shouldOverrideAndDisableCSSAnimationsAndCSSTransitionsBackedByWebAnimationsPreference): Deleted.
2688         * WebKitTestRunner/TestController.cpp:
2689         (WTR::TestController::resetPreferencesToConsistentValues):
2690         * WebKitTestRunner/TestOptions.cpp:
2691         (WTR::TestOptions::TestOptions):
2692         (WTR::isLegacyAnimationEngineTestPath): Deleted.
2693         * WebKitTestRunner/TestOptions.h:
2694
2695 2018-04-17  Yusuke Suzuki  <utatane.tea@gmail.com>
2696
2697         [JSC] Rename runWebAssembly to runWebAssemblySuite
2698         https://bugs.webkit.org/show_bug.cgi?id=184703
2699
2700         Reviewed by JF Bastien.
2701
2702         * Scripts/run-jsc-stress-tests:
2703
2704 2018-04-17  Yusuke Suzuki  <utatane.tea@gmail.com>
2705
2706         [WebAssembly][Modules] Implement function import from wasm modules
2707         https://bugs.webkit.org/show_bug.cgi?id=184689
2708
2709         Reviewed by JF Bastien.
2710
2711         Add runWebAssemblyDirect, which runs wasm file directly.
2712
2713         * Scripts/run-jsc-stress-tests:
2714
2715 2018-04-17  Saam Barati  <sbarati@apple.com>
2716
2717         Add system trace points for process launch and for initializeWebProcess
2718         https://bugs.webkit.org/show_bug.cgi?id=184669
2719
2720         Reviewed by Simon Fraser.
2721
2722         * Tracing/SystemTracePoints.plist:
2723
2724 2018-04-17  Ross Kirsling  <ross.kirsling@sony.com>
2725
2726         Add debug bots for WinCairo.
2727         https://bugs.webkit.org/show_bug.cgi?id=184663
2728
2729         Reviewed by Lucas Forschler.
2730
2731         * BuildSlaveSupport/build.webkit.org-config/config.json:
2732         Add a debug build bot and two debug test bots.
2733
2734         * BuildSlaveSupport/build.webkit.org-config/loadConfig.py:
2735         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
2736         Add a WinCairo category to build.webkit.org.
2737
2738 2018-04-17  Zalan Bujtas  <zalan@apple.com>
2739
2740         [LayoutReloaded] Set inline-block box position.
2741         https://bugs.webkit.org/show_bug.cgi?id=184690
2742
2743         Reviewed by Antti Koivisto.
2744
2745         * LayoutReloaded/FormattingContext/InlineFormatting/InlineFormattingContext.js:
2746         (InlineFormattingContext.prototype._handleInlineBlock):
2747         * LayoutReloaded/Utils.js:
2748         (Utils._dumpBox):
2749         * LayoutReloaded/test/inline-block-with-fixed-width-height.html:
2750
2751 2018-04-17  Carlos Garcia Campos  <cgarcia@igalia.com>
2752
2753         [GLIB] Add API to clear JSCContext uncaught exception
2754         https://bugs.webkit.org/show_bug.cgi?id=184685
2755
2756         Reviewed by Žan Doberšek.
2757
2758         Add test cases for the new API.
2759
2760         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2761         (testJSCExceptions):
2762
2763 2018-04-17  Carlos Garcia Campos  <cgarcia@igalia.com>
2764
2765         [GLIB] Add API to query, delete and enumerate properties
2766         https://bugs.webkit.org/show_bug.cgi?id=184647
2767
2768         Reviewed by Michael Catanzaro.
2769
2770         Add test cases for the new API.
2771
2772         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2773         (testJSCObject):
2774         (testJSCClass):
2775         (testJSCPrototypes):
2776
2777 2018-04-16  Zalan Bujtas  <zalan@apple.com>
2778
2779         [LayoutReloaded] Add support for replaced box.
2780         https://bugs.webkit.org/show_bug.cgi?id=184680
2781
2782         Reviewed by Antti Koivisto.
2783
2784         Basic support for inline replaced.
2785
2786         * LayoutReloaded/FormattingContext/InlineFormatting/InlineFormattingContext.js:
2787         (InlineFormattingContext.prototype._handleInlineBox):
2788         (InlineFormattingContext.prototype._handleInlineBlock):
2789         (InlineFormattingContext.prototype._handleReplaced):
2790         * LayoutReloaded/FormattingContext/InlineFormatting/Line.js:
2791         (Line.prototype.lastLineBox):
2792         (Line.prototype.addInlineBox):
2793         (Line.prototype.addInlineContainerBox): Deleted.
2794         * LayoutReloaded/TreeBuilder.js:
2795         (TreeBuilder.prototype._createAndAttachBox):
2796         * LayoutReloaded/Utils.js:
2797         (Utils._dumpBox):
2798         * LayoutReloaded/test/index.html:
2799         * LayoutReloaded/test/inline-simple-replaced.html: Added.
2800
2801 2018-04-16  Zalan Bujtas  <zalan@apple.com>
2802
2803         [LayoutReloaded] Minor InlineFormattingContext::layout() cleanup.
2804         https://bugs.webkit.org/show_bug.cgi?id=184679
2805
2806         Reviewed by Antti Koivisto.
2807
2808         * LayoutReloaded/FormattingContext/InlineFormatting/InlineFormattingContext.js:
2809         (InlineFormattingContext):
2810         (InlineFormattingContext.prototype.layout):
2811         (InlineFormattingContext.prototype._handleInlineContainer):
2812         (InlineFormattingContext.prototype._handleInlineContent):
2813         (InlineFormattingContext.prototype._handleInlineBlock):
2814         (InlineFormattingContext.prototype._handleReplacedBox):
2815         (InlineFormattingContext.prototype._clearNeedsLayoutAndMoveToNextSibling):
2816         (InlineFormattingContext.prototype._handleInlineBlockContainer): Deleted.
2817         (InlineFormattingContext.prototype._clearAndMoveToNext): Deleted.
2818
2819 2018-04-16  Zalan Bujtas  <zalan@apple.com>
2820
2821         [LayoutReloaded] Introduce fragmentation state/context.
2822         https://bugs.webkit.org/show_bug.cgi?id=184677
2823
2824         Reviewed by Antti Koivisto.
2825
2826         State/context for fragmented content (multicol, regions, pagination etc).
2827
2828         * LayoutReloaded/FormattingContext/FragmentationContext.js: Added.
2829         (FragmentationContext):
2830         * LayoutReloaded/FormattingState/FragmentationState.js: Added.
2831         (FragmentationState):
2832         (FragmentationState.prototype.formattingState):
2833
2834 2018-04-16  Andy Estes  <aestes@apple.com>
2835
2836         [iOS] Enable WKPDFView by default
2837         https://bugs.webkit.org/show_bug.cgi?id=184675
2838         <rdar://problem/27885452>
2839
2840         Reviewed by Darin Adler.
2841
2842         * TestWebKitAPI/Tests/WebKitCocoa/WKPDFView.mm:
2843
2844 2018-04-16  Leo Balter  <leonardo.balter@gmail.com>
2845
2846         Perl-based Test262 runner
2847         https://bugs.webkit.org/show_bug.cgi?id=183343
2848
2849         Reviewed by Michael Saboff.
2850
2851         * Scripts/test262-helpers/README.md: Added.
2852         * Scripts/test262-helpers/agent.js: Added.
2853         (262.getGlobal):
2854         (262.setGlobal):
2855         (262.destroy):
2856         (262.IsHTMLDDA):
2857         * Scripts/test262-helpers/cpanfile: Added.
2858         * Scripts/test262-helpers/cpanfile.snapshot: Added.
2859         * Scripts/test262-helpers/test262-runner.pl: Added.
2860         (main):
2861         (processFile):
2862         (getScenarios):
2863         (addScenario):
2864         (compileTest):
2865         (runTest):
2866         (processResult):
2867         (getTempFile):
2868         (getContents):
2869         (parseData):
2870         (getHarness):
2871         * Scripts/test262-helpers/tests.log: Added.
2872
2873 2018-04-15  Andy Estes  <aestes@apple.com>
2874
2875         [iOS] Add API tests for PDF find-in-page
2876         https://bugs.webkit.org/show_bug.cgi?id=184634
2877
2878         Reviewed by Dan Bernstein.
2879
2880         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2881         * TestWebKitAPI/Tests/WebKit/find.pdf: Added.
2882         * TestWebKitAPI/Tests/WebKitCocoa/WKPDFView.mm:
2883         (-[TestFindDelegate findString]):
2884         (-[TestFindDelegate _webView:didCountMatches:forString:]):
2885         (-[TestFindDelegate _webView:didFindMatches:forString:withMatchIndex:]):
2886         (-[TestFindDelegate _webView:didFailToFindString:]):
2887         (loadWebView):
2888         (TEST):
2889
2890 2018-04-13  Zalan Bujtas  <zalan@apple.com>
2891
2892         [LayoutReloaded] Update class documentation
2893         https://bugs.webkit.org/show_bug.cgi?id=184625
2894
2895         Reviewed by Antti Koivisto.
2896
2897         * LayoutReloaded/DisplayTree/Box.js:
2898         * LayoutReloaded/FormattingContext/BlockFormatting/BlockFormattingContext.js:
2899         * LayoutReloaded/FormattingContext/BlockFormatting/BlockMarginCollapse.js:
2900         * LayoutReloaded/FormattingContext/FloatingContext.js:
2901         * LayoutReloaded/FormattingContext/FormattingContext.js:
2902         * LayoutReloaded/FormattingContext/InlineFormatting/InlineFormattingContext.js:
2903         * LayoutReloaded/FormattingContext/InlineFormatting/Line.js:
2904         * LayoutReloaded/FormattingState/BlockFormattingState.js:
2905         * LayoutReloaded/FormattingState/FloatingState.js:
2906         * LayoutReloaded/FormattingState/FormattingState.js:
2907         * LayoutReloaded/FormattingState/InlineFormattingState.js:
2908         * LayoutReloaded/LayoutState.js:
2909         * LayoutReloaded/LayoutTree/BlockContainer.js:
2910         * LayoutReloaded/LayoutTree/Box.js:
2911         * LayoutReloaded/LayoutTree/Container.js:
2912         * LayoutReloaded/LayoutTree/InlineBox.js:
2913         * LayoutReloaded/LayoutTree/InlineContainer.js:
2914         * LayoutReloaded/LayoutTree/Text.js:
2915         * LayoutReloaded/misc/headers/BlockContainer.h: Removed.
2916         * LayoutReloaded/misc/headers/BlockFormattingContext.h: Removed.
2917         * LayoutReloaded/misc/headers/BlockMarginCollapse.h: Removed.
2918         * LayoutReloaded/misc/headers/Box.h: Removed.
2919         * LayoutReloaded/misc/headers/Container.h: Removed.
2920         * LayoutReloaded/misc/headers/FloatingContext.h: Removed.
2921         * LayoutReloaded/misc/headers/FormattingContext.h: Removed.
2922         * LayoutReloaded/misc/headers/InitialBlockContainer.h: Removed.
2923         * LayoutReloaded/misc/headers/InlineBox.h: Removed.
2924         * LayoutReloaded/misc/headers/LayoutContext.h: Removed.
2925         * LayoutReloaded/misc/headers/Line.h: Removed.
2926         * LayoutReloaded/misc/headers/Text.h: Removed.
2927
2928 2018-04-13  Zalan Bujtas  <zalan@apple.com>
2929
2930         [LayoutReloaded] Add simple implementation for FormattingState::markNeedsLayout()
2931         https://bugs.webkit.org/show_bug.cgi?id=184621
2932
2933         Reviewed by Antti Koivisto.
2934
2935         This is just a simple, mark ancestors dirty implementation.
2936
2937         * LayoutReloaded/FormattingState/FormattingState.js:
2938         (FormattingState.prototype.markNeedsLayout):
2939         * LayoutReloaded/LayoutState.js:
2940         (LayoutState.prototype.markNeedsLayout):
2941         (LayoutState.prototype.setNeedsLayoutById): Deleted.
2942         (LayoutState.prototype.setNeedsLayout): Deleted.
2943         * LayoutReloaded/TreeBuilder.js:
2944         (TreeBuilder.prototype._createAndAttachBox):
2945         (TreeBuilder.prototype._findBox): Deleted.
2946         * LayoutReloaded/Utils.js:
2947         (Utils.layoutBoxById):
2948         * LayoutReloaded/test/index.html:
2949         * LayoutReloaded/test/simple-incremental-layout-with-static-content.html:
2950
2951 2018-04-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2952
2953         [WPE] [webkitpy] The driver requirements should be checked before starting the tests
2954         https://bugs.webkit.org/show_bug.cgi?id=184595
2955
2956         Reviewed by Michael Catanzaro.
2957
2958         Ensure Driver.check_driver() is checked at check_sys_deps() time.
2959
2960         * Scripts/webkitpy/port/wpe.py:
2961         (WPEPort.check_sys_deps):
2962
2963 2018-04-13  Zalan Bujtas  <zalan@apple.com>
2964
2965         Rebaseline LayoutReloaded patch file (collectRenderersWithNeedsLayout).
2966
2967         * LayoutReloaded/misc/LayoutReloadedWebKit.patch:
2968
2969 2018-04-13  Jonathan Bedard  <jbedard@apple.com>
2970
2971         Boot fewer simulators in CI/EWS machines
2972         https://bugs.webkit.org/show_bug.cgi?id=184594
2973         <rdar://problem/39188082>
2974
2975         Reviewed by Alexey Proskuryakov.
2976
2977         This is a temporary workaround fro <rdar://problem/39393590>.
2978
2979         * Scripts/webkitpy/xcode/simulated_device.py:
2980         (SimulatedDeviceManager): Treat simulators as taking 6 gigs instead of 2.
2981
2982 2018-04-13  Brady Eidson  <beidson@apple.com>
2983
2984         Introduce SuspendedPageProxy to keep old web processes around after their WebPageProxy has been swapped to a new one.
2985         https://bugs.webkit.org/show_bug.cgi?id=184559
2986
2987         Reviewed by Alex Christensen.
2988
2989         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2990
2991 2018-04-13  Chris Dumez  <cdumez@apple.com>
2992
2993         input.webkitEntries does not work as expected when folder contains accented chars
2994         https://bugs.webkit.org/show_bug.cgi?id=184517
2995         <rdar://problem/39265537>
2996
2997         Reviewed by Alex Christensen.
2998
2999         Add API test coverage.
3000
3001         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp:
3002         (TestWebKitAPI::TEST_F):
3003
3004 2018-04-13  Thibault Saunier  <tsaunier@igalia.com>
3005
3006         Update my emails ordering in contributors.json
3007         https://bugs.webkit.org/show_bug.cgi?id=184587
3008
3009         Rubber-stamped by Philippe Normand.
3010
3011         Bugzilla seems to pick up tsaunier@igalia.com which is not the one I use there.
3012
3013         * Scripts/webkitpy/common/config/contributors.json:
3014
3015 2018-04-13  Michael Catanzaro  <mcatanzaro@igalia.com>
3016
3017         [WPE] xkbcommon: ERROR: failed to add default include path /home/mcatanzaro/Projects/WebKit/WebKitBuild/DependenciesWPE/Root/share/X11/xkb
3018         https://bugs.webkit.org/show_bug.cgi?id=184388
3019
3020         Reviewed by Carlos Alberto Lopez Perez.
3021
3022         Remove libxkbcommon from the JHBuild environment. We could alternatively add
3023         xkeyboard-config, but there doesn't seem to be any need to build libxkbcommon because I do
3024         not believe it depends on anything else in the JHBuild environment.
3025
3026         * wpe/install-dependencies:
3027         * wpe/jhbuild.modules:
3028
3029 2018-04-12  Antoine Quint  <graouts@apple.com>
3030
3031         [Web Animations] Turn CSS Animations and CSS Transitions as Web Animations on by default
3032         https://bugs.webkit.org/show_bug.cgi?id=184569
3033         <rdar://problem/38671301>
3034
3035         Reviewed by Jon Lee.
3036
3037         We set the default value for the CSS Animations and CSS Transitions as Web Animations flag to true
3038         but override it to be false always in the LayoutTests/legacy-animation-engine directory.
3039
3040         * DumpRenderTree/TestOptions.h:
3041         * DumpRenderTree/mac/DumpRenderTree.mm:
3042         (shouldOverrideAndDisableCSSAnimationsAndCSSTransitionsBackedByWebAnimationsPreference):
3043         (runTest):
3044         * WebKitTestRunner/TestController.cpp:
3045         (WTR::TestController::resetPreferencesToConsistentValues):
3046         * WebKitTestRunner/TestOptions.cpp:
3047         (WTR::isLegacyAnimationEngineTestPath):
3048         (WTR::TestOptions::TestOptions):
3049         * WebKitTestRunner/TestOptions.h:
3050
3051 2018-04-13  Carlos Garcia Campos  <cgarcia@igalia.com>
3052
3053         [GLIB] Tests WTF_RefPtr.ReleaseInNonMainThread and WTF_RefPtr.ReleaseInNonMainThreadDestroyInMainThread are crashing since they were added
3054         https://bugs.webkit.org/show_bug.cgi?id=184531
3055
3056         Reviewed by Michael Catanzaro.
3057
3058         It's not a bug in WebKit, but in the tests. The problem is that those tests are using RunLoop::main() but main
3059         run loop hasn't been initialized. ReleaseInNonMainThread doesn't really need to initialize the main run loop if
3060         we change Util::run() to always use RunLop::current() instead of RunLoop::main(). But
3061         ReleaseInNonMainThreadDestroyInMainThread ends up scheduling a task to the main thread, and the generic
3062         implementation fo that uses RunLoop::main(), so we need to initialize the main loop in this case.
3063
3064         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
3065         (TestWebKitAPI::TEST): Call RunLoop::initializeMainRunLoop().
3066         * TestWebKitAPI/glib/UtilitiesGLib.cpp:
3067         (TestWebKitAPI::Util::run): Use RunLop::current() to stop the current run loop.
3068         (TestWebKitAPI::Util::sleep): Ditto.
3069
3070 2018-04-12  Zalan Bujtas  <zalan@apple.com>
3071
3072         [LayoutReloaded] Add support for incremental layout
3073         https://bugs.webkit.org/show_bug.cgi?id=184578
3074
3075         Reviewed by Antti Koivisto.
3076
3077         * LayoutReloaded/Layout.js:
3078         (layout):
3079         * LayoutReloaded/LayoutState.js:
3080         (LayoutState.prototype.rootContainer):
3081         (LayoutState.prototype.setNeedsLayoutById):
3082         * LayoutReloaded/Utils.js:
3083         (Utils.layoutTreeDump):
3084         * LayoutReloaded/test/TestHarness.js:
3085         (verifyLayout):
3086         (runLayout):
3087         (verifyLayoutTreeDump): Deleted.
3088         * LayoutReloaded/test/index.html:
3089         * LayoutReloaded/test/simple-incremental-layout-with-static-content.html: Added.
3090
3091 2018-04-12  Zalan Bujtas  <zalan@apple.com>
3092
3093         [LayoutReloaded] Move root container ownership to layout state
3094         https://bugs.webkit.org/show_bug.cgi?id=184575
3095
3096         Reviewed by Antti Koivisto.
3097
3098         Now the root container is on the associated layout state (ICB only at this point though).
3099
3100         * LayoutReloaded/FormattingContext/BlockFormatting/BlockFormattingContext.js:
3101         (BlockFormattingContext.prototype.layout):
3102         * LayoutReloaded/FormattingContext/FormattingContext.js:
3103         (FormattingContext.prototype._layoutOutOfFlowDescendants):
3104         * LayoutReloaded/FormattingContext/InlineFormatting/InlineFormattingContext.js:
3105         (InlineFormattingContext.prototype._handleInlineBlockContainer):
3106         (InlineFormattingContext.prototype._handleFloatingBox):
3107         * LayoutReloaded/Layout.js:
3108         (layout):
3109         * LayoutReloaded/LayoutState.js:
3110         (LayoutState):
3111         (LayoutState.prototype.formattingContext):
3112         (LayoutState.prototype.establishedFormattingState):
3113         (LayoutState.prototype.formattingStateForBox):
3114         (LayoutState.prototype.needsLayout):
3115         (LayoutState.prototype.displayBox):
3116         (LayoutState.prototype._formattingContext):
3117         (LayoutState.prototype.layout): Deleted.
3118         (LayoutState.prototype.formattingStates): Deleted.
3119         (LayoutState.prototype.initialDisplayBox): Deleted.
3120         * LayoutReloaded/Utils.js:
3121         (Utils._dumpBox):
3122         (Utils._findDisplayBox): Deleted.
3123
3124 2018-04-12  Jonathan Bedard  <jbedard@apple.com>
3125
3126         Fix --build-directory flag for run-webkit-tests
3127         https://bugs.webkit.org/show_bug.cgi?id=184545
3128         <rdar://problem/39385080>
3129
3130         Rubber-stamped by Aakash Jain.
3131
3132         The --build-directory path does not work with iOS-Simulator.
3133
3134         * Scripts/webkitpy/port/base.py:
3135         (Port._build_path): Use the port configuration to calculate the root directory.
3136         * Scripts/webkitpy/port/base_unittest.py:
3137         (PortTest.test_build_path): Test build directories for embedded configurations.
3138
3139 2018-04-12  Ross Kirsling  <ross.kirsling@sony.com>
3140
3141         pemfile.py should not assume POSIX line endings
3142         https://bugs.webkit.org/show_bug.cgi?id=184507
3143
3144         Reviewed by Daniel Bates.
3145
3146         * Scripts/webkitpy/common/system/pemfile.py:
3147         (_parse_pem_format):
3148         * Scripts/webkitpy/common/system/pemfile_unittest.py:
3149         (PemFileTest.test_parse_crlf):
3150         (PemFileTest.test_parse_cr):
3151
3152 2018-04-12  Zalan Bujtas  <zalan@apple.com>
3153
3154         [LayoutReloaded] Minor cleanup in LayoutSate
3155         https://bugs.webkit.org/show_bug.cgi?id=184546
3156
3157         Reviewed by Antti Koivisto.
3158
3159         * LayoutReloaded/FormattingContext/FormattingContext.js:
3160         (FormattingContext.isInFormattingContext):
3161         * LayoutReloaded/FormattingState/FormattingState.js:
3162         (FormattingState.prototype.displayBoxes):
3163         (FormattingState.prototype.displayBox):
3164         (FormattingState.prototype._markSubTreeNeedsLayout):
3165         (FormattingState):
3166         (FormattingState.prototype.displayBoxMap): Deleted.
3167         * LayoutReloaded/LayoutState.js:
3168         (LayoutState.prototype.formattingStateForBox):
3169         (LayoutState.prototype.needsLayout):
3170         (LayoutState.prototype.displayBox):
3171         (LayoutState.prototype._createFormattingState):
3172         (LayoutState):
3173         * LayoutReloaded/LayoutTree/Box.js:
3174         (Layout.Box.prototype.isFormattingContextDescendant): Deleted.
3175         * LayoutReloaded/LayoutTree/Container.js:
3176         (Layout.Container.prototype.isContainingBlockDescendant): Deleted.
3177         * LayoutReloaded/Utils.js:
3178         (Utils._findDisplayBox):
3179
3180 2018-04-12  Zalan Bujtas  <zalan@apple.com>
3181
3182         [LayoutReloaded] Introduce needsLayout to InlineFormattingContext
3183         https://bugs.webkit.org/show_bug.cgi?id=184538
3184
3185         Reviewed by Antti Koivisto.
3186
3187         * LayoutReloaded/FormattingContext/BlockFormatting/BlockFormattingContext.js:
3188         (BlockFormattingContext.prototype._adjustBottomWithFIXME):
3189         (BlockFormattingContext):
3190         (BlockFormattingContext.prototype._firstInFlowChildWithNeedsLayout): Deleted.
3191         (BlockFormattingContext.prototype._nextInFlowSiblingWithNeedsLayout): Deleted.
3192         * LayoutReloaded/FormattingContext/FormattingContext.js:
3193         (FormattingContext.prototype._firstInFlowChildWithNeedsLayout):
3194         (FormattingContext.prototype._nextInFlowSiblingWithNeedsLayout):
3195         (FormattingContext):
3196         * LayoutReloaded/FormattingContext/InlineFormatting/InlineFormattingContext.js:
3197         (InlineFormattingContext.prototype.layout):
3198         (InlineFormattingContext.prototype._handleInlineContainer):
3199         (InlineFormattingContext.prototype._handleInlineBlockContainer):
3200         (InlineFormattingContext.prototype._handleInlineContent):
3201         (InlineFormattingContext.prototype._clearAndMoveToNext):
3202         (InlineFormattingContext):
3203
3204 2018-04-12  Xabier Rodriguez Calvar  <calvaris@igalia.com>
3205
3206         [GStreamer] Speed up GStreamer dependency build by removing examples compilation
3207         https://bugs.webkit.org/show_bug.cgi?id=184528
3208
3209         Reviewed by Philippe Normand.
3210
3211         * gstreamer/jhbuild.modules: Added --disable-examples for GStreamer package.
3212
3213 2018-04-12  Zan Dobersek  <zdobersek@igalia.com>
3214
3215         [WPE] Switch testing process to using WPEBackend-fdo
3216         https://bugs.webkit.org/show_bug.cgi?id=184357
3217
3218         Reviewed by Carlos Alberto Lopez Perez.
3219
3220         Switch WPE testing to using the WPEBackend-fdo implementation that
3221         depends on the WL_bind_wayland_display EGL extension, as defined under
3222         the freedesktop.org project.
3223         https://cgit.freedesktop.org/mesa/mesa/tree/docs/specs/WL_bind_wayland_display.spec
3224
3225         HeadlessViewBackend is refactored to use the WPEBackend-fdo API, but
3226         otherwise is not changed in functionality.
3227
3228         Unit tests now have to unconditionally use HeadlessViewBackend as a
3229         wpe_view_backend provider, since WPEBackend-fdo does not provide a
3230         default wpe_view_backend implementation. Unit tests covering that are
3231         adjusted to instead use a mock wpe_view_backend interface.
3232
3233         * Scripts/webkitdirs.pm:
3234         (builtDylibPathForName): Fix the libWPEWebKit.so name to also include
3235         the API version that was added in r230449.
3236         * Scripts/webkitpy/port/waylanddriver.py:
3237         (WaylandDriver._setup_environ_for_test): Export EGL_PLATFORM=wayland.
3238         * Scripts/webkitpy/port/wpe.py:
3239         (WPEPort._driver_class): Use WaylandDriver by default.
3240         * TestWebKitAPI/PlatformWebView.h:
3241         (): Deleted.
3242         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
3243         (testWebViewWebBackend):
3244         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
3245         (Test::createWebViewBackend):
3246         * TestWebKitAPI/wpe/PlatformWebViewWPE.cpp:
3247         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
3248         (TestWebKitAPI::PlatformWebView::initialize):
3249         * wpe/HeadlessViewBackend/CMakeLists.txt:
3250         * wpe/HeadlessViewBackend/HeadlessViewBackend.cpp:
3251         (getEGLDisplay):
3252         (HeadlessViewBackend::HeadlessViewBackend):
3253         (HeadlessViewBackend::~HeadlessViewBackend):
3254         (HeadlessViewBackend::backend const):
3255         (HeadlessViewBackend::createSnapshot):
3256         (HeadlessViewBackend::performUpdate):
3257         (HeadlessViewBackend::makeCurrent): Deleted.
3258         * wpe/HeadlessViewBackend/HeadlessViewBackend.h:
3259         * wpe/jhbuild.modules: Module name cleanup. Dyz version is bumped.
3260
3261 2018-04-12  Carlos Garcia Campos  <cgarcia@igalia.com>
3262
3263         [GTK] Switch to use always complex text code path
3264         https://bugs.webkit.org/show_bug.cgi?id=183285
3265
3266         Reviewed by Michael Catanzaro.
3267
3268         Keep the auto mode for the layout tests to avoid having to rebaseline a lot of tests.
3269
3270         * WebKitTestRunner/gtk/main.cpp:
3271         (main): Set WEBKIT_FORCE_COMPLEX_TEXT to 0 unless it's already present in the environment.
3272
3273 2018-04-11  Carlos Garcia Campos  <cgarcia@igalia.com>
3274
3275         [GLIB] Handle strings containing null characters
3276         https://bugs.webkit.org/show_bug.cgi?id=184450
3277
3278         Reviewed by Michael Catanzaro.
3279
3280         Add test case for strings with null characters and update all calls to evaluate to pass the script length.
3281
3282         * TestWebKitAPI/PlatformGTK.cmake:
3283         * TestWebKitAPI/PlatformWPE.cmake:
3284         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3285         (testJSCBasic):
3286         (testJSCFunction):
3287         (testJSCObject):
3288         (testJSCClass):
3289         (testJSCPrototypes):
3290         (testJSCExceptions):
3291         (testJSCPromises):
3292         (testJSCGarbageCollector):
3293         (testJSCWeakValue):
3294         (testsJSCVirtualMachine):
3295         (testsJSCAutocleanups):
3296         * TestWebKitAPI/Tests/JavaScriptCore/glib/script.js: Added.
3297         * TestWebKitAPI/Tests/WebKitGLib/DOMElementTest.cpp:
3298         (DOMElementTest::testAutoFill):
3299         * TestWebKitAPI/Tests/WebKitGLib/EditorTest.cpp:
3300         (WebKitWebEditorTest::testSelectionChanged):
3301         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp:
3302         (WebKitFrameTest::testJavaScriptValues):
3303         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
3304         (consoleMessageSentCallback):
3305         (methodCallCallback):
3306
3307 2018-04-11  Zan Dobersek  <zdobersek@igalia.com>
3308
3309         [WPE] Make WebKitWebViewBackend object mandatory for webkit_web_view_new*() constructors
3310         https://bugs.webkit.org/show_bug.cgi?id=184513
3311
3312         Reviewed by Michael Catanzaro.
3313
3314         Update the WPE-specific testWebViewWebBackend() test case, removing the
3315         test that passes a null WebKitWebViewBackend object to the
3316         webkit_web_view_new() call.
3317
3318         Helper createWebViewBackend() that's called via Test::createWebView()
3319         variations is updated to, in case of not using the headless backend,
3320         return a WebKitWebViewBackend instance that wraps around a
3321         default wpe_view_backend object.
3322
3323         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
3324         (testWebViewWebBackend):
3325         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
3326         (Test::createWebViewBackend):
3327
3328 2018-04-11  Zalan Bujtas  <zalan@apple.com>
3329
3330         [LayoutReloaded] Introduce needsLayout flag
3331         https://bugs.webkit.org/show_bug.cgi?id=184527
3332
3333         Reviewed by Antti Koivisto.
3334
3335         Use the formatting state to mark boxes dirty.
3336
3337         * LayoutReloaded/FormattingContext/BlockFormatting/BlockFormattingContext.js:
3338         (BlockFormattingContext.prototype.layout):
3339         (BlockFormattingContext.prototype._firstInFlowChildWithNeedsLayout):
3340         (BlockFormattingContext.prototype._nextInFlowSiblingWithNeedsLayout):
3341         (BlockFormattingContext):
3342         * LayoutReloaded/FormattingContext/FormattingContext.js:
3343         (FormattingContext.prototype._layoutOutOfFlowDescendants):
3344         * LayoutReloaded/FormattingState/FormattingState.js:
3345         (FormattingState):
3346         (FormattingState.prototype.markNeedsLayout):
3347         (FormattingState.prototype.clearNeedsLayout):
3348         (FormattingState.prototype.needsLayout):
3349         (FormattingState.prototype.layoutNeeded):
3350         (FormattingState.prototype._markSubTreeNeedsLayout):
3351         * LayoutReloaded/LayoutState.js:
3352         (LayoutState.prototype.formattingStateForBox):
3353         (LayoutState.prototype.setNeedsLayout):
3354         (LayoutState.prototype.needsLayout):
3355         * LayoutReloaded/LayoutTree/Box.js:
3356         (Layout.Box.prototype.isFormattingContextDescendant):
3357         * LayoutReloaded/LayoutTree/Container.js:
3358         (Layout.Container.prototype.isContainingBlockDescendant):
3359
3360 2018-04-11  Jonathan Bedard  <jbedard@apple.com>
3361
3362         Fix TestInvocation class for newer versions of clang.
3363         https://bugs.webkit.org/show_bug.cgi?id=184508
3364         <rdar://problem/39328648>
3365
3366         Reviewed by Alexey Proskuryakov.
3367
3368         Declare TestInvocation to be final so it does not require a virtual destructor.
3369
3370         * WebKitTestRunner/TestInvocation.h:
3371
3372 2018-04-10  Alex Christensen  <achristensen@webkit.org>
3373
3374         IDN spoofing with Hebrew combining characters
3375         https://bugs.webkit.org/show_bug.cgi?id=184472
3376         <rdar://problem/39148687>
3377
3378         Reviewed by Brent Fulgham.
3379
3380         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
3381         (TestWebKitAPI::TEST):
3382
3383 2018-04-11  Wenson Hsieh  <wenson_hsieh@apple.com>
3384
3385         [Extra zoom mode] Missing label when focusing a <select> with a title attribute but no associated <label>
3386         https://bugs.webkit.org/show_bug.cgi?id=184352
3387         <rdar://problem/39237683>
3388
3389         Reviewed by Andy Estes.
3390
3391         Add support for UIScriptController::selectFormPopoverTitle, which returns the title of the current select
3392         popover's UITableViewController (for testing purposes).
3393
3394         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3395         (WTR::UIScriptController::selectFormPopoverTitle const):
3396         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3397         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3398         (WTR::UIScriptController::selectFormPopoverTitle const):
3399         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3400         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3401         (WTR::UIScriptController::selectFormPopoverTitle const):
3402
3403 2018-04-10  Nan Wang  <n_wang@apple.com>
3404
3405         AX: Expose strong password fields on iOS
3406         https://bugs.webkit.org/show_bug.cgi?id=184465
3407         <rdar://problem/39325104>
3408
3409         Reviewed by Chris Fleizach.
3410
3411         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3412         (AccessibilityUIElement::boolAttributeValue):
3413         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3414         (WTR::AccessibilityUIElement::boolAttributeValue):
3415
3416 2018-04-10  Zalan Bujtas  <zalan@apple.com>
3417
3418         [LayoutReloaded] Add support for out-of-flow descendants in inline formatting context.
3419         https://bugs.webkit.org/show_bug.cgi?id=184454
3420
3421         Reviewed by Antti Koivisto.
3422
3423         When the containing block of an out-of-flow positioned element establishes an inline formatting context.
3424         This is mostly about moving out-of-flow logic from BlockFormattingContext to the base class.
3425
3426         * LayoutReloaded/FormattingContext/BlockFormatting/BlockFormattingContext.js:
3427         (BlockFormattingContext.prototype._adjustBottomWithFIXME):
3428         (BlockFormattingContext):
3429         (BlockFormattingContext.prototype._layoutOutOfFlowDescendants): Deleted.
3430         (BlockFormattingContext.prototype._computeOutOfFlowWidth): Deleted.
3431         (BlockFormattingContext.prototype._computeInFlowWidth): Deleted.
3432         (BlockFormattingContext.prototype._computeOutOfFlowHeight): Deleted.
3433         (BlockFormattingContext.prototype._computeOutOfFlowPosition): Deleted.
3434         (BlockFormattingContext.prototype._shrinkToFitWidth): Deleted.
3435         * LayoutReloaded/FormattingContext/FormattingContext.js:
3436         (FormattingContext.prototype._placeInFlowPositionedChildren):
3437         (FormattingContext.prototype._computeInFlowWidth):
3438         (FormattingContext.prototype._layoutOutOfFlowDescendants):
3439         (FormattingContext.prototype._computeOutOfFlowWidth):
3440         (FormattingContext.prototype._computeOutOfFlowHeight):
3441         (FormattingContext.prototype._computeOutOfFlowPosition):
3442         (FormattingContext.prototype._shrinkToFitWidth):
3443         * LayoutReloaded/FormattingContext/InlineFormatting/InlineFormattingContext.js:
3444         (InlineFormattingContext.prototype.layout):
3445         (InlineFormattingContext.prototype._handleInlineContainer):
3446         (InlineFormattingContext.prototype._handleInlineBlockContainer):
3447         (InlineFormattingContext.prototype._placeOutOfFlowDescendants): Deleted.
3448         * LayoutReloaded/test/index.html:
3449         * LayoutReloaded/test/inline-with-out-of-flow-descendant.html: Added.
3450
3451 2018-04-09  Zan Dobersek  <zdobersek@igalia.com>
3452
3453         WKTR: Enable DOM cache, SW registration directory cleanup on non-Cocoa platforms
3454         https://bugs.webkit.org/show_bug.cgi?id=184414
3455
3456         Reviewed by Michael Catanzaro.
3457
3458         Enable clearServiceWorkerRegistrations(), clearDOMCache() and
3459         clearDOMCaches() implementations in WebKitTestRunner's TestController
3460         class for non-Cocoa platforms. Implementations depend on the generic
3461         WK2 C API that other ports can leverage as well.
3462
3463         The clearDOMCache() and clearDOMCaches() calls are now operational for
3464         tests that invoke them. clearServiceWorkerRegistrations() and
3465         clearDOMCaches() are also called between each test, cleaning up relevant
3466         resources.
3467
3468         The TestController::getAllStorageAccessEntries() stub for non-Cocoa
3469         platforms is moved into the main !PLATFORM(COCOA) block.
3470
3471         * WebKitTestRunner/TestController.cpp:
3472         (WTR::TestController::getAllStorageAccessEntries):
3473         (WTR::clearServiceWorkerRegistrationsCallback):
3474         (WTR::TestController::clearServiceWorkerRegistrations):
3475         (WTR::clearDOMCacheCallback):
3476         (WTR::TestController::clearDOMCache):
3477         (WTR::TestController::clearDOMCaches):
3478
3479 2018-04-09  Zalan Bujtas  <zalan@apple.com>
3480
3481         [LayoutReloaded] Add support for relatively positioned containers in inline formatting context.
3482         https://bugs.webkit.org/show_bug.cgi?id=184439
3483
3484         Reviewed by Antti Koivisto.
3485
3486         * LayoutReloaded/FormattingContext/BlockFormatting/BlockFormattingContext.js:
3487         (BlockFormattingContext.prototype._placeInFlowPositionedChildren): Deleted.
3488         (BlockFormattingContext.prototype._computeInFlowPositionedPosition): Deleted.
3489         * LayoutReloaded/FormattingContext/FormattingContext.js:
3490         (FormattingContext.prototype._computeInFlowPositionedPosition):
3491         (FormattingContext.prototype._placeInFlowPositionedChildren):
3492         * LayoutReloaded/FormattingContext/InlineFormatting/InlineFormattingContext.js:
3493         (InlineFormattingContext.prototype._placeInFlowPositionedChildren): Deleted.
3494         * LayoutReloaded/Utils.js:
3495         (Utils._dumpBox):
3496         (Utils._dumpLines.):
3497         (Utils._dumpLines):
3498         (Utils.precisionRoundWithDecimals):
3499         (Utils.precisionRound):
3500         (Utils):
3501         * LayoutReloaded/test/index.html:
3502         * LayoutReloaded/test/inline-with-relative-positioning.html: Added.
3503
3504 2018-04-09  Zalan Bujtas  <zalan@apple.com>
3505
3506         [LayoutReloaded] Remove Layout.InitialContainingBlock class
3507         https://bugs.webkit.org/show_bug.cgi?id=184436
3508
3509         Reviewed by Antti Koivisto.
3510
3511         * LayoutReloaded/LayoutTree/Box.js:
3512         (Layout.Box.prototype.establishesBlockFormattingContext):
3513         * LayoutReloaded/LayoutTree/InitialBlockContainer.js: Removed.
3514         * LayoutReloaded/TreeBuilder.js:
3515         (TreeBuilder.prototype.createTree):
3516         * LayoutReloaded/test/index.html:
3517
3518 2018-04-09  Zalan Bujtas  <zalan@apple.com>
3519
3520         [LayoutReloaded] Add support for inline-block.
3521         https://bugs.webkit.org/show_bug.cgi?id=184434
3522
3523         Reviewed by Antti Koivisto.
3524
3525         * LayoutReloaded/FormattingContext/InlineFormatting/InlineFormattingContext.js:
3526         (InlineFormattingContext):
3527         (InlineFormattingContext.prototype.layout):
3528         (InlineFormattingContext.prototype._handleInlineContainer):
3529         (InlineFormattingContext.prototype._handleInlineBlockContainer):
3530         (InlineFormattingContext.prototype._handleInlineContent):
3531         * LayoutReloaded/FormattingContext/InlineFormatting/Line.js:
3532         (Line.prototype.addInlineContainerBox):
3533         (Line.prototype.addTextLineBox):
3534         (Line):
3535         * LayoutReloaded/LayoutTree/Box.js:
3536         (Layout.Box.prototype.isInlineBlockBox):
3537         * LayoutReloaded/Utils.js:
3538         (LayoutRect.prototype.growHorizontally):
3539         (Utils.isBlockContainerElement):
3540         (Utils.isInlineBlockElement):
3541         (Utils._dumpLines.):
3542         (Utils._dumpLines):
3543         * LayoutReloaded/test/index.html:
3544         * LayoutReloaded/test/inline-block-with-fixed-width-height.html: Added.
3545
3546 2018-04-09  Timothy Hatcher  <timothy@apple.com>
3547
3548         Add support for setting a background color on WKWebView and WKView
3549         https://bugs.webkit.org/show_bug.cgi?id=184426
3550
3551         Reviewed by Wenson Hsieh.
3552
3553         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3554         * TestWebKitAPI/Tests/mac/BackgroundColor.mm: Added.
3555
3556 2018-04-09  Charlie Turner  <cturner@igalia.com>
3557
3558         [WPE] Add some missing install dependencies
3559         https://bugs.webkit.org/show_bug.cgi?id=184383
3560
3561         Reviewed by Michael Catanzaro.
3562
3563         * wpe/install-dependencies:
3564
3565 2018-04-09  Sihui Liu  <sihui_liu@apple.com>
3566
3567         REGRESSION(r229929): localStorage is broken for WebInspector
3568         https://bugs.webkit.org/show_bug.cgi?id=184382
3569         <rdar://problem/39257355>
3570
3571         Reviewed by Chris Dumez.
3572
3573         * TestWebKitAPI/Tests/WebKitCocoa/LocalStoragePersistence.mm:
3574         (TEST):
3575         * TestWebKitAPI/Tests/WebKitCocoa/localstorage-empty-string-value.html:
3576
3577 2018-04-09  Zan Dobersek  <zdobersek@igalia.com>
3578
3579         Unreviewed follow-up to r230389.
3580
3581         * WebKitTestRunner/TestController.cpp:
3582         (WTR::TestController::platformAdjustContext): Use the 'ServiceWorkers'
3583         subdirectory for the temporary testing-purpose SW registration directory
3584         like it's used in Cocoa's TestController, addressing the review comment
3585         that I forgot about.
3586
3587 2018-04-08  Zan Dobersek  <zdobersek@igalia.com>
3588
3589         Non-Cocoa ports use default directory for ServiceWorker data during testing
3590         https://bugs.webkit.org/show_bug.cgi?id=183784
3591
3592         Reviewed by Youenn Fablet.
3593
3594         * WebKitTestRunner/TestController.cpp:
3595         (WTR::TestController::platformAdjustContext): Set the service worker registration
3596         directory through the new WKWebsiteDataStore API for non-Cocoa ports.
3597
3598 2018-04-08  Zalan Bujtas  <zalan@apple.com>
3599
3600         [LayoutReloaded] Adjust line with inline container's margin border and padding
3601         https://bugs.webkit.org/show_bug.cgi?id=184409
3602
3603         Reviewed by Antti Koivisto.
3604
3605         * LayoutReloaded/FormattingContext/InlineFormatting/InlineFormattingContext.js:
3606         (InlineFormattingContext.prototype.layout):
3607         (InlineFormattingContext.prototype._handleFloatingBox):
3608         (InlineFormattingContext.prototype._adjustLineForInlineContainerStart):
3609         (InlineFormattingContext.prototype._adjustLineForInlineContainerEnd):
3610         * LayoutReloaded/FormattingContext/InlineFormatting/Line.js:
3611         (Line.prototype.shrink):
3612         (Line.prototype.adjustWithOffset):
3613         (Line.prototype.moveContentHorizontally):
3614         (Line.prototype.addTextLineBox):
3615         (Line):
3616         (Line.prototype.addFloatingBox): Deleted.
3617         * LayoutReloaded/misc/LayoutReloadedWebKit.patch:
3618         * LayoutReloaded/test/index.html:
3619         * LayoutReloaded/test/inline-with-padding-border-margin-offsets.html: Added.
3620
3621 2018-04-07  Zalan Bujtas  <zalan@apple.com>
3622
3623         [LayoutReloaded] Add support for InlineContainer
3624         https://bugs.webkit.org/show_bug.cgi?id=184394
3625
3626         Reviewed by Antti Koivisto.
3627
3628         * LayoutReloaded/FormattingContext/FormattingContext.js:
3629         (FormattingContext.prototype._addToLayoutQueue):
3630         * LayoutReloaded/FormattingContext/InlineFormatting/InlineFormattingContext.js:
3631         (InlineFormattingContext.prototype.layout):
3632         (InlineFormattingContext.prototype._handleInlineContent):
3633         (InlineFormattingContext.prototype._handleFloatingBox):
3634         (InlineFormattingContext.prototype._adjustLineForInlineContainerStart):
3635         (InlineFormattingContext.prototype._adjustLineForInlineContainerEnd):
3636         (InlineFormattingContext.prototype._placeInFlowPositionedChildren):
3637         (InlineFormattingContext.prototype._placeOutOfFlowDescendants):
3638         (InlineFormattingContext.prototype._createNewLine):
3639         (InlineFormattingContext.prototype._handleContent): Deleted.
3640         * LayoutReloaded/LayoutState.js:
3641         (LayoutState.prototype._createFormattingState):
3642         * LayoutReloaded/LayoutTree/Box.js:
3643         (Layout.Box.prototype.isContainer):
3644         (Layout.Box.prototype.isInlineContainer):
3645         (Layout.Box.prototype.isInlineBox):
3646         * LayoutReloaded/LayoutTree/Container.js:
3647         (Layout.Container.prototype.isContainer): Deleted.
3648         * LayoutReloaded/LayoutTree/InlineContainer.js: Added.
3649         (Layout.InlineContainer):
3650         * LayoutReloaded/TreeBuilder.js:
3651         (TreeBuilder.prototype._createAndAttachBox):
3652         * LayoutReloaded/Utils.js:
3653         (Utils._dumpBox):
3654         (Utils.precisionRound):
3655         (Utils):
3656         * LayoutReloaded/test/index.html:
3657         * LayoutReloaded/test/inline-content-simple2.html: Added.
3658         * LayoutReloaded/test/inline-floating1.html: Added.
3659         * LayoutReloaded/test/inline-formatting-context-floats1.html: Added.
3660         * LayoutReloaded/test/inline-formatting-context-floats2.html: Added.
3661
3662 2018-04-07  Timothy Hatcher  <timothy@apple.com>
3663
3664         Use the system's link color when system appearance is desired for a WebView.
3665
3666         https://bugs.webkit.org/show_bug.cgi?id=184353
3667         rdar://problem/9420053
3668
3669         Reviewed by Wenson Hsieh.
3670
3671         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3672         * TestWebKitAPI/Tests/WebKitCocoa/SystemColors.mm: Added.
3673         (TestWebKitAPI::WebKit::LinkColor):
3674         (TestWebKitAPI::WebKit::LinkColorWithSystemAppearance):
3675
3676 2018-04-06  Zalan Bujtas  <zalan@apple.com>
3677
3678         Rebaseline LayoutReloaded patch file.
3679
3680         * LayoutReloaded/misc/LayoutReloadedWebKit.patch:
3681
3682 2018-04-06  Fujii Hironori  <Hironori.Fujii@sony.com>
3683
3684         [Win][WebCore] Expose a constant for scrollbar pixels per line (cScrollbarPixelsPerLine)
3685         https://bugs.webkit.org/show_bug.cgi?id=184296
3686
3687         Reviewed by Alex Christensen.
3688
3689         * DumpRenderTree/win/EventSender.cpp:
3690         (mouseScrollBy): Removed the duplicated cScrollbarPixelsPerLine
3691         definition. Use WebCore::cScrollbarPixelsPerLine.
3692
3693 2018-04-06  Zalan Bujtas  <zalan@apple.com>
3694
3695         Rebaseline LayoutReloaded patch file.
3696
3697         * LayoutReloaded/misc/LayoutReloadedWebKit.patch:
3698
3699 2018-04-05  Youenn Fablet  <youenn@apple.com>
3700
3701         Test expectation updater should handle Win bot results
3702         https://bugs.webkit.org/show_bug.cgi?id=184274
3703
3704         Reviewed by Ryosuke Niwa.
3705
3706         Add processing of win bot results.
3707         They will update platform/win results.
3708
3709         Updated the script so that if there is no mac-wk2 results, it will still process specific results.
3710
3711         * Scripts/webkitpy/common/net/bugzilla/test_expectation_updater.py:
3712         (TestExpectationUpdater.__init__):
3713         (TestExpectationUpdater._bot_type):
3714         (TestExpectationUpdater.do_update):
3715         * Scripts/webkitpy/common/net/bugzilla/test_expectation_updater_unittest.py:
3716         (MockAttachment):
3717         (MockAttachment.__init__):
3718         (MockAttachment.contents):
3719         (MockBugzilla):
3720         (MockBugzilla.__init__):
3721         (MockBugzilla.fetch_bug):
3722         (MockBugzilla.attachments):
3723         (MockZip):
3724         (MockZip.__init__):
3725         (MockZip.unzip):
3726         (MockZip.read):
3727         (TestExpectationUpdaterTest.test_update_test_expectations):
3728         (TestExpectationUpdaterTest):
3729         (TestExpectationUpdaterTest.test_update_win_future_test_expectations):
3730
3731 2018-04-05  Zalan Bujtas  <zalan@apple.com>
3732
3733         [LayoutReloaded] Fix static position for floating boxes when they don't fit the current line
3734         https://bugs.webkit.org/show_bug.cgi?id=184354
3735
3736         Reviewed by Antti Koivisto.
3737
3738         Do not shrink the current line with the floating box unless it is on the current line.
3739
3740         * LayoutReloaded/FormattingContext/InlineFormatting/InlineFormattingContext.js:
3741         (InlineFormattingContext.prototype._handleFloatingBox):
3742         (InlineFormattingContext.prototype._mapFloatingVerticalPosition):
3743         * LayoutReloaded/FormattingContext/InlineFormatting/Line.js:
3744         (Line.prototype.addFloatingBox):
3745         (Line):
3746         * LayoutReloaded/test/index.html:
3747         * LayoutReloaded/test/inline-with-right-floats3.html: Added.
3748
3749 2018-04-05  Zalan Bujtas  <zalan@apple.com>
3750
3751         [LayoutReloaded] Add support for right floating boxes in inline formatting context
3752         https://bugs.webkit.org/show_bug.cgi?id=184351
3753
3754         Reviewed by Antti Koivisto.
3755
3756         * LayoutReloaded/FormattingContext/InlineFormatting/InlineFormattingContext.js:
3757         (InlineFormattingContext.prototype._handleFloatingBox):
3758         (InlineFormattingContext.prototype._mapFloatingVerticalPosition):
3759         * LayoutReloaded/FormattingContext/InlineFormatting/Line.js:
3760         (Line.prototype.addFloatingBox):
3761         (Line):
3762         * LayoutReloaded/test/index.html:
3763         * LayoutReloaded/test/inline-with-right-float-simple.html: Added.
3764         * LayoutReloaded/test/inline-with-right-floats2.html: Added.
3765
3766 2018-04-05  Zalan Bujtas  <zalan@apple.com>
3767
3768         [LayoutReloaded] Move floating box to the next line when needed
3769         https://bugs.webkit.org/show_bug.cgi?id=184349
3770
3771         Reviewed by Antti Koivisto.
3772
3773         * LayoutReloaded/FormattingContext/InlineFormatting/InlineFormattingContext.js:
3774         (InlineFormattingContext.prototype.layout):
3775         (InlineFormattingContext.prototype._handleContent):
3776         (InlineFormattingContext.prototype._handleText):
3777         (InlineFormattingContext.prototype._handleFloatingBox):
3778         (InlineFormattingContext.prototype._mapFloatingHorizontalPosition):
3779         (InlineFormattingContext):
3780         (InlineFormattingContext.prototype._handleFloatingBoxes): Deleted.
3781         (InlineFormattingContext.prototype._floatingBoxes): Deleted.
3782         * LayoutReloaded/FormattingContext/InlineFormatting/Line.js:
3783         (Line.prototype.addTextLineBox):
3784         (Line.prototype.addFloatingBox):
3785         (Line):
3786         * LayoutReloaded/Utils.js:
3787         (LayoutRect.prototype.moveHorizontally):
3788         (LayoutRect.prototype.moveVertically):
3789         * LayoutReloaded/test/index.html:
3790         * LayoutReloaded/test/inline-with-floats-when-they-dont-fit.html: Added.
3791
3792 2018-04-05  Brady Eidson  <beidson@apple.com>
3793
3794         Process Swap on Navigation causes many webpages to hang due to attempted process swap for iframe navigations.
3795         <rdar://problem/39162236> and https://bugs.webkit.org/show_bug.cgi?id=184318
3796
3797         Reviewed by Andy Estes.
3798
3799         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3800         (-[PSONMessageHandler userContentController:didReceiveScriptMessage:]):
3801         (-[PSONScheme addMappingFromURLString:toData:]):
3802         (-[PSONScheme webView:startURLSchemeTask:]):
3803
3804 2018-04-05  Yusuke Suzuki  <utatane.tea@gmail.com>
3805
3806         [WTF] Remove StaticLock
3807         https://bugs.webkit.org/show_bug.cgi?id=184332
3808
3809         Reviewed by Mark Lam.
3810
3811         * DumpRenderTree/JavaScriptThreading.cpp:
3812
3813 2018-04-05  Zalan Bujtas  <zalan@apple.com>
3814
3815         [LayoutReloaded] Find the correct left edge for a line when floating boxes are in parent formatting context.
3816         https://bugs.webkit.org/show_bug.cgi?id=184330
3817
3818         Reviewed by Antti Koivisto.
3819
3820         In inline formatting context, the floating boxes can come from the parent (block) formatting context. Let's
3821         take them into account when computing the line edges.
3822
3823         * LayoutReloaded/FormattingContext/FloatingContext.js:
3824         (FloatingContext.prototype.left):
3825         (FloatingContext.prototype.right):
3826         * LayoutReloaded/FormattingContext/InlineFormatting/InlineFormattingContext.js:
3827         (InlineFormattingContext.prototype._createNewLine):
3828         (InlineFormattingContext.prototype._mapFloatingVerticalPosition):
3829         (InlineFormattingContext.prototype._mapFloatingHorizontalPosition):
3830         (InlineFormattingContext.prototype._mapFloatingPosition): Deleted.
3831         * LayoutReloaded/test/index.html:
3832         * LayoutReloaded/test/multiple-left-floats-on-line-from-parent-formatting-context.html: Added.
3833
3834 2018-04-05  Zalan Bujtas  <zalan@apple.com>
3835
3836         [LayoutReloaded] Collect floating boxes in inline formatting context and layout them first.
3837         https://bugs.webkit.org/show_bug.cgi?id=184329
3838
3839         Reviewed by Antti Koivisto.
3840
3841         Let's do this for now. There might be some cases where this violates layout.
3842
3843         * LayoutReloaded/FormattingContext/FormattingContext.js:
3844         (FormattingContext.prototype._outOfFlowDescendants):
3845         (FormattingContext):
3846         * LayoutReloaded/FormattingContext/InlineFormatting/InlineFormattingContext.js:
3847         (InlineFormattingContext.prototype.layout):
3848         (InlineFormattingContext.prototype._handleFloatingBoxes):
3849         (InlineFormattingContext.prototype._handleFloatingBox):
3850         (InlineFormattingContext.prototype._floatingBoxes):
3851         (InlineFormattingContext):
3852         * LayoutReloaded/test/index.html:
3853         * LayoutReloaded/test/multiple-left-floats-on-line-simple.html: Added.
3854
3855 2018-04-04  Youenn Fablet  <youenn@apple.com>
3856
3857         WebRTC data channel only applications require capture permissions for direct connections
3858         https://bugs.webkit.org/show_bug.cgi?id=174500
3859         <rdar://problem/34134281>
3860
3861         Reviewed by Eric Carlson.
3862
3863         Adding options to enable MDNS ICE candidates.
3864
3865         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3866         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3867         (WTR::TestRunner::setMediaDevicesEnabled):
3868         (WTR::TestRunner::setMDNSICECandidatesEnabled):
3869         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3870         * WebKitTestRunner/TestController.cpp:
3871         (WTR::TestController::resetPreferencesToConsistentValues):
3872
3873 2018-04-04  Ryan Haddad  <ryanhaddad@apple.com>
3874
3875         Disable failing WKWebViewAutofillTests
3876         https://bugs.webkit.org/show_bug.cgi?id=184196
3877
3878         Unreviewed test gardening.
3879
3880         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
3881         (TestWebKitAPI::TEST):
3882
3883 2018-04-04  Youenn Fablet  <youenn@apple.com>
3884
3885         Introduce a ThreadSafeRefCounted parameter to ensure being destroyed on the main thread
3886         https://bugs.webkit.org/show_bug.cgi?id=183988
3887
3888         Reviewed by Darin Adler.
3889
3890         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
3891         (TestWebKitAPI::ThreadSafeRefCountedObject::create):
3892         (TestWebKitAPI::ThreadSafeRefCountedObject::~ThreadSafeRefCountedObject):
3893         (TestWebKitAPI::MainThreadSafeRefCountedObject::create):
3894         (TestWebKitAPI::MainThreadSafeRefCountedObject::~MainThreadSafeRefCountedObject):
3895         (TestWebKitAPI::TEST):
3896
3897 2018-04-04  Ms2ger  <Ms2ger@igalia.com>
3898
3899         Test gardening for GTK.
3900         https://bugs.webkit.org/show_bug.cgi?id=184298
3901
3902         Unreviewed test gardening.
3903
3904         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Add pointer to
3905         https://bugs.webkit.org/show_bug.cgi?id=184295.
3906
3907 2018-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3908
3909         ASSERTION FAILED: !m_mainFrame->coreFrame()->loader().frameHasLoaded() || !m_pendingNavigationID when reloading page while a page is loading
3910         https://bugs.webkit.org/show_bug.cgi?id=153210
3911
3912         Reviewed by Alex Christensen.
3913
3914         Add unit tests to WebKit C API and WebKitGLib.
3915
3916         * TestWebKitAPI/Tests/WebKit/PageLoadBasic.cpp:
3917         (TestWebKitAPI::TEST):
3918         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
3919         (LoadTwiceAndReloadTest::reloadOnFinishLoad):
3920         (LoadTwiceAndReloadTest::LoadTwiceAndReloadTest):
3921         (LoadTwiceAndReloadTest::~LoadTwiceAndReloadTest):
3922         (LoadTwiceAndReloadTest::waitUntilFinished):
3923         (testWebViewLoadTwiceAndReload):
3924         (beforeAll):
3925
3926 2018-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3927
3928         [GTK] Test /webkit/WebKitWebPage/context-menu is failing since r229831
3929         https://bugs.webkit.org/show_bug.cgi?id=184260
3930
3931         Reviewed by Michael Catanzaro.
3932
3933         This is not a regression introduced in r229831, though, it's a bug in the test itself revealed by r229831. We
3934         should wait for the load to complete before trying to show the context menu.
3935
3936         * TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp:
3937         (testContextMenuWebExtensionMenu):
3938
3939 2018-04-03  Zalan Bujtas  <zalan@apple.com>
3940
3941         [LayoutReloaded] Introduce floating to InlineFormattingContext
3942         https://bugs.webkit.org/show_bug.cgi?id=184288
3943
3944         Reviewed by Antti Koivisto.
3945
3946         * LayoutReloaded/FormattingContext/BlockFormatting/BlockFormattingContext.js:
3947         (BlockFormattingContext.prototype._computeFloatingWidth): Deleted.
3948         (BlockFormattingContext.prototype._computeFloatingHeight): Deleted.
3949         * LayoutReloaded/FormattingContext/FormattingContext.js:
3950         (FormattingContext.prototype._computeFloatingWidth):
3951         (FormattingContext.prototype._computeFloatingHeight):
3952         * LayoutReloaded/FormattingContext/InlineFormatting/InlineFormattingContext.js:
3953         (InlineFormattingContext.prototype.layout):
3954         (InlineFormattingContext.prototype._handleFloatingBox):
3955         * LayoutReloaded/FormattingContext/InlineFormatting/Line.js:
3956         (Line.prototype.addFloatingBox):
3957         (Line):
3958         * LayoutReloaded/test/float-is-inside-inline-formatting-context-simple.html: Added.
3959         * LayoutReloaded/test/index.html:
3960
3961 2018-04-03  Youenn Fablet  <youenn@apple.com>
3962
3963         NetworkResourceLoader does not need to expose all redirect response headers
3964         https://bugs.webkit.org/show_bug.cgi?id=184114
3965         <rdar://problem/39010557>
3966
3967         Reviewed by Ryosuke Niwa.
3968
3969         Add an option to dump the number of headers in a response.
3970         This allows validating that filtering does happen or not.
3971
3972         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3973         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3974         (WTR::dumpResponseDescriptionSuitableForTestResult):
3975         (WTR::InjectedBundlePage::responseHeaderCount):
3976         (WTR::InjectedBundlePage::willSendRequestForFrame):
3977         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3978         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3979         (WTR::TestRunner::dumpAllHTTPRedirectedResponseHeaders):
3980         (WTR::TestRunner::shouldDumpAllHTTPRedirectedResponseHeaders const):
3981         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
3982         (WTR::InjectedBundlePage::responseHeaderCount):
3983         * WebKitTestRunner/TestController.cpp:
3984         (WTR::TestController::resetPreferencesToConsistentValues):
3985
3986 2018-04-03  Andy Estes  <aestes@apple.com>
3987
3988         [Mac] Prioritize file promises over filenames during drag and drop
3989         https://bugs.webkit.org/show_bug.cgi?id=184237
3990         <rdar://problem/38278076>
3991
3992         Reviewed by Wenson Hsieh.
3993
3994         * DumpRenderTree/mac/EventSendingController.mm:
3995         (-[EventSendingController beginDragWithFilePromises:]):
3996
3997 2018-04-03  Brady Eidson  <beidson@apple.com>
3998
3999         Make SessionStorage work with process swapping.
4000         https://bugs.webkit.org/show_bug.cgi?id=184270
4001
4002         Reviewed by Andy Estes.
4003
4004         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4005         (-[PSONMessageHandler userContentController:didReceiveScriptMessage:]):
4006
4007 2018-04-03  Chris Dumez  <cdumez@apple.com>
4008
4009         Drop MainFrame class
4010         https://bugs.webkit.org/show_bug.cgi?id=184191
4011
4012         Reviewed by Darin Adler.
4013
4014         * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm:
4015
4016 2018-04-03  Charlie Turner  <cturner@igalia.com>
4017
4018         [WPE] Add WPE port to garden-o-matic
4019         https://bugs.webkit.org/show_bug.cgi?id=182998
4020
4021         Reviewed by Michael Catanzaro.
4022
4023         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
4024         Add WPE as a port to check.
4025         (config.kPlatforms.string_appeared_here._builderApplies): Use less
4026         surprising equality operator.
4027         (config.kPlatforms.string_appeared_here.resultsDirectoryNameFromBuilderName):
4028         Ditto.
4029         (config.kPlatforms.string_appeared_here.resultsDirectoryForBuildNumber):
4030         Ditto.
4031
4032 2018-04-03  Adrian Perez de Castro  <aperez@igalia.com>
4033
4034         [GTK][JHBuild] Tools/gtk/install-dependencies: Replace libxfont with libxfont2 in Arch Linux
4035         https://bugs.webkit.org/show_bug.cgi?id=184258
4036
4037         Reviewed by Carlos Alberto Lopez Perez.
4038
4039         * gtk/install-dependencies: Use libxfont2 on Arch Linux as well.
4040
4041 2018-04-02  Brady Eidson  <beidson@apple.com>
4042
4043         Process swapping on navigation needs to handle server redirects.
4044         <rdar://problem/38690465> and https://bugs.webkit.org/show_bug.cgi?id=184142
4045
4046         Reviewed by Alex Christensen.
4047
4048         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4049         (-[PSONNavigationDelegate webView:didFinishNavigation:]):
4050         (-[PSONNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
4051         (-[PSONNavigationDelegate webView:didReceiveServerRedirectForProvisionalNavigation:]):
4052         (-[PSONScheme addRedirectFromURLString:toURLString:]):
4053         (-[PSONScheme webView:startURLSchemeTask:]):
4054
4055 2018-04-02  Daniel Bates  <dabates@apple.com>
4056
4057         Add infrastructure to relax SSL for allowed hosts in DumpRenderTree and WebKitTestRunner
4058         https://bugs.webkit.org/show_bug.cgi?id=184239
4059
4060         Reviewed by Alexey Proskuryakov.
4061
4062         Adds a new optional command line option --allow-any-certificate-for-allowed-hosts (defaults to disabled)
4063         to allow the allowed hosts to accept any HTTPS certificate. You can specify an allowed host
4064         by using the existing command line option --allowed-host.
4065
4066         Currently both DumpRenderTree and WebKitTestRunner relax SSL certificate validation
4067         for 127.0.0.1 and localhost so that we can run HTTPS tests from these hosts using
4068         a self-signed certificate. They do not relax these restrictions for any allowed host,
4069         specified using the optional command line option --allowed-host. For testing purposes
4070         it is useful to be able to run a local HTTPS server with a self-signed certificate and
4071         mimic a non-localhost hostname (by adding an alias(es) for 127.0.0.1 to /etc/hosts).
4072         We should support relaxing SSL restrictions for such testing purposes.
4073
4074         For example, to allow host example.test to present any HTTPS certificate when running
4075         tests you would invoke:
4076
4077             run-webkit-tests --allowed-host example.test --additional-drt-flag '--allow-any-certificate-for-allowed-hosts'
4078
4079         * DumpRenderTree/mac/DumpRenderTree.mm:
4080         (initializeGlobalsFromCommandLineOptions): Parse the command line option --allow-any-certificate-for-allowed-hosts.
4081         (dumpRenderTree): Allow any HTTPS certificate from each allowed host.
4082         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4083         (WTR::InjectedBundle::didReceiveMessageToPage): Clear out the existing list of allowed hosts
4084         before appending entries to it to avoid growing the list of allowed hosts without bound. Call
4085         platformAllowAnyHTTPSCertificateForAllowedHosts() to apply SSL relaxation for each allowed host.
4086         * WebKitTestRunner/Options.cpp:
4087         (WTR::handleOptionAllowAnyHTTPSCertificateForAllowedHosts): Added.
4088         (WTR::handleOptionAllowedHost): Update code as needed now that Options::allowedHosts is a std::set.
4089         (WTR::OptionsHandler::OptionsHandler):
4090         * WebKitTestRunner/Options.h: Change the data type of allowedHosts from a std::vector to a std::set
4091         so that we can make use of the convenience functon std::set::find() in TestController::canAuthenticateAgainstProtectionSpace().
4092         * WebKitTestRunner/TestController.cpp:
4093         (WTR::TestController::initialize):
4094         (WTR::TestController::canAuthenticateAgainstProtectionSpace): Allow any HTTPS certificate from each allowed host.
4095         * WebKitTestRunner/TestController.h:
4096
4097 2018-04-02  Ryan Haddad  <ryanhaddad@apple.com>
4098
4099         Unreviewed, rolling out r230174.
4100
4101         Caused LayoutTests to exit early with assertion failures.
4102
4103         Reverted changeset:
4104
4105         "Process swapping on navigation needs to handle server
4106         redirects."
4107         https://bugs.webkit.org/show_bug.cgi?id=184142
4108         https://trac.webkit.org/changeset/230174
4109
4110 2018-04-02  Daniel Bates  <dabates@apple.com>
4111
4112         Remove pre-Network Session code path for allowing any HTTPS certificate on Mac and iOS
4113         https://bugs.webkit.org/show_bug.cgi?id=184242
4114
4115         Reviewed by Alexey Proskuryakov.
4116
4117         Following r227364 we use the Network Session (NSURLSession) code path by default in
4118         modern WebKit on Mac and iOS. That is, we no longer use {CF, NS}URLConnection in modern
4119         WebKit on these platforms. So, we can remove code that used NSURLRequest SPI to allow
4120         any HTTPS certificate from localhost and 127.0.0.1 when using {CF, NS}URLConnection.
4121         The equivalent functionality is implemented in TestController::canAuthenticateAgainstProtectionSpace().
4122
4123         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
4124         (WTR::InjectedBundle::platformInitialize):
4125         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
4126         (WTR::InjectedBundle::platformInitialize):
4127
4128 2018-04-02  Brady Eidson  <beidson@apple.com>
4129
4130         Process swapping on navigation needs to handle server redirects.
4131         <rdar://problem/38690465> and https://bugs.webkit.org/show_bug.cgi?id=184142
4132
4133         Reviewed by Alex Christensen.
4134
4135         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4136         (-[PSONNavigationDelegate webView:didFinishNavigation:]):
4137         (-[PSONNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
4138         (-[PSONNavigationDelegate webView:didReceiveServerRedirectForProvisionalNavigation:]):
4139         (-[PSONScheme addRedirectFromURLString:toURLString:]):
4140         (-[PSONScheme webView:startURLSchemeTask:]):
4141
4142 2018-04-02  Thibault Saunier  <tsaunier@igalia.com>
4143
4144         webkitpy: Use current environment value for GST_DEBUG(_FILE) and DOT_DIR env vars
4145         https://bugs.webkit.org/show_bug.cgi?id=184036
4146
4147         Reviewed by Philippe Normand.
4148
4149         Those variables are for debug purpose and should not change the behaviour
4150         itself, and developers expect them to have effect.
4151
4152         * Scripts/webkitpy/port/gtk.py:
4153         (GtkPort.setup_environ_for_server):
4154
4155 2018-04-02  Daniel Bates  <dabates@apple.com>
4156
4157         Remove Options constructor and use internal linkage for option handlers
4158         https://bugs.webkit.org/show_bug.cgi?id=184229
4159
4160         Reviewed by Andy Estes.
4161
4162         Use C++11 default initializer syntax to remove the need to explicitly have a constructor
4163         for the struct Options. Use internal linkage for option handler functions as these
4164         are never invoked outside the translation unit they are defined in.
4165
4166         * WebKitTestRunner/Options.cpp:
4167         (WTR::handleOptionNoTimeout):
4168         (WTR::handleOptionVerbose):
4169         (WTR::handleOptionGcBetweenTests):
4170         (WTR::handleOptionPixelTests):
4171         (WTR::handleOptionPrintSupportedFeatures):
4172         (WTR::handleOptionComplexText):
4173         (WTR::handleOptionAcceleratedDrawing):
4174         (WTR::handleOptionRemoteLayerTree):
4175         (WTR::handleOptionShowWebView):
4176         (WTR::handleOptionShowTouches):
4177         (WTR::handleOptionAllowedHost):
4178         (WTR::handleOptionUnmatched):
4179         (WTR::Options::Options): Deleted.
4180         * WebKitTestRunner/Options.h:
4181
4182 2018-04-02  Alejandro G. Castro  <alex@igalia.com>
4183
4184         Unreviewed GTK port dependencies fix after r230152.
4185
4186         Add alsa library dependency for gtk.
4187
4188         * gtk/install-dependencies:
4189
4190 2018-04-02  Alejandro G. Castro  <alex@igalia.com>
4191
4192         [GTK] Make libwebrtc backend buildable for GTK  port
4193         https://bugs.webkit.org/show_bug.cgi?id=178860
4194
4195         Reviewed by Youenn Fablet.
4196
4197         * gstreamer/jhbuild.modules: Modified the libvpx module for the
4198         libwebrtc compilation.
4199         * gtk/install-dependencies: Add libevent as a system requirement.
4200         * Scripts/webkitpy/style/checker.py: Added libwebrtc to the list of third
4201         party libraries with reduced style checks.
4202
4203 2018-04-01  Zalan Bujtas  <zalan@apple.com>
4204
4205         [LayoutReloaded] Use containing block's contentBox left edge when the float is to the right.
4206         https://bugs.webkit.org/show_bug.cgi?id=184230
4207
4208         Reviewed by Antti Koivisto.
4209
4210         * LayoutReloaded/FormattingContext/InlineFormatting/InlineFormattingContext.js:
4211         (InlineFormattingContext.prototype._mapFloatingPosition):
4212         (InlineFormattingContext):
4213         * LayoutReloaded/test/index.html:
4214         * LayoutReloaded/test/inline-formatting-context-with-floats2.html: Added.
4215
4216 2018-04-01  Zalan Bujtas  <zalan@apple.com>
4217
4218         [LayoutReloaded] Right floating box reduces available line width.
4219         https://bugs.webkit.org/show_bug.cgi?id=184226
4220
4221         Reviewed by Antti Koivisto.
4222
4223         * LayoutReloaded/FormattingContext/InlineFormatting/InlineFormattingContext.js:
4224         (InlineFormattingContext.prototype._createNewLine):
4225         * LayoutReloaded/test/index.html:
4226         * LayoutReloaded/test/inline-with-floats-right-left-simple.html: Added.
4227
4228 2018-03-31  Zalan Bujtas  <zalan@apple.com>
4229
4230         [LayoutReloaded] Floating box reduces line with in inline formatting context
4231         https://bugs.webkit.org/show_bug.cgi?id=184223
4232
4233         Reviewed by Antti Koivisto.
4234
4235         * LayoutReloaded/FormattingContext/FloatingContext.js:
4236         (FloatingContext.prototype.left):
4237         (FloatingContext.prototype.right):
4238         (FloatingContext.prototype._mapDisplayMarginBoxToFormattingRoot):
4239         (FloatingContext.prototype._mapBorderBoxToFormattingRoot):
4240         (FloatingContext.prototype._mapContentBoxToFormattingRoot):
4241         (FloatingContext.prototype.formattingRoot):
4242         (FloatingContext.prototype._floatingState):
4243         (FloatingContext.prototype._formattingRoot): Deleted.
4244         * LayoutReloaded/FormattingContext/InlineFormatting/InlineFormattingContext.js:
4245         (InlineFormattingContext.prototype._createNewLine):
4246         (InlineFormattingContext.prototype._mapFloatingPosition):
4247         (InlineFormattingContext):
4248         * LayoutReloaded/FormattingState/FormattingState.js:
4249         (FormattingState.prototype.displayBox):
4250         (FormattingState):
4251         * LayoutReloaded/test/index.html:
4252         * LayoutReloaded/test/inline-formatting-context-with-floats.html: Added.
4253
4254 2018-03-31  Zalan Bujtas  <zalan@apple.com>
4255
4256         [LayoutReloaded] InlineFormattingState should inherit the floating state from its parent formatting state
4257         https://bugs.webkit.org/show_bug.cgi?id=184220
4258
4259         Reviewed by Antti Koivisto.
4260
4261         If the block container box that initiates an inline formatting context also establishes a block context,
4262         create a new float state, otherwise use the existing one.
4263
4264         * LayoutReloaded/FormattingContext/BlockFormatting/BlockFormattingContext.js:
4265         (BlockFormattingContext.prototype._contentHeight):
4266         * LayoutReloaded/FormattingState/InlineFormattingState.js:
4267         (InlineFormattingState):
4268         * LayoutReloaded/LayoutState.js:
4269         (LayoutState.prototype.establishedFormattingState):
4270         (LayoutState.prototype.formattingStateForBox):
4271         (LayoutState.prototype.formattingState): Deleted.
4272         * LayoutReloaded/Utils.js:
4273
4274 2018-03-31  Zalan Bujtas  <zalan@apple.com>
4275
4276         [LayoutReloaded] FloatingContext does not need a parent formatting context.
4277         https://bugs.webkit.org/show_bug.cgi?id=184219
4278
4279         Reviewed by Antti Koivisto.
4280
4281         We don't need the formatting context in the FloatingContext now that margins are moved over to Display.Box.
4282         This is in preparation for being able to create a FloatingContext for an inline formatting context,
4283         when the inline context actually inherits the floating state from its formatting root.
4284
4285         * LayoutReloaded/FormattingContext/FloatingContext.js:
4286         (FloatingContext):
4287         (FloatingContext.prototype._availableSpace):
4288         (FloatingContext.prototype._adjustedFloatingPosition):
4289         (FloatingContext.prototype._addFloatingBox):
4290         (FloatingContext.prototype._formattingContext): Deleted.
4291         * LayoutReloaded/FormattingContext/FormattingContext.js:
4292         (FormattingContext):
4293
4294 2018-03-31  Zalan Bujtas  <zalan@apple.com>
4295
4296         [LayoutReloaded] Do not clone Display.Box for FloatingState stacks.
4297         https://bugs.webkit.org/show_bug.cgi?id=184218
4298
4299         Reviewed by Antti Koivisto.
4300
4301         Now that Display.Box is in a tree context, we can't just clone it for the purpose of caching its absolute position.
4302
4303         * LayoutReloaded/DisplayTree/Box.js:
4304         (Display.Box.prototype.clone): Deleted.
4305         * LayoutReloaded/FormattingContext/FloatingContext.js:
4306         (FloatingContext.prototype._positionForFloating):
4307         (FloatingContext.prototype._moveToNextVerticalPosition):
4308         (FloatingContext.prototype._availableSpace):
4309         (FloatingContext.prototype._findFloatingAtVerticalPosition):
4310         (FloatingContext.prototype._adjustedFloatingPosition):
4311         (FloatingContext.prototype._bottom):
4312         (FloatingContext.prototype._addFloatingBox):
4313         (FloatingContext.prototype._mapMarginBoxToFormattingRoot):
4314         (FloatingContext.prototype._mapDisplayMarginBoxToFormattingRoot):
4315         * LayoutReloaded/FormattingState/FloatingState.js:
4316         (FloatingState.prototype.addFloating):
4317
4318 2018-03-31  Zalan Bujtas  <zalan@apple.com>
4319
4320         [LayoutReloaded] Remove all FormattingContext::absolute*Box functions.
4321         https://bugs.webkit.org/show_bug.cgi?id=184215
4322
4323         Reviewed by Antti Koivisto.
4324
4325         Use Display.Box instead.
4326
4327         * LayoutReloaded/FormattingContext/BlockFormatting/BlockFormattingContext.js:
4328         (BlockFormattingContext.prototype._computeOutOfFlowPosition):
4329         * LayoutReloaded/FormattingContext/FloatingContext.js:
4330         (FloatingContext.prototype._availableSpace):
4331         (FloatingContext.prototype._adjustedFloatingPosition):
4332         (FloatingContext.prototype._mapBorderBoxToFormattingRoot):
4333         (FloatingContext.prototype._mapContentBoxToFormattingRoot):
4334         * LayoutReloaded/FormattingContext/FormattingContext.js:
4335         (FormattingContext.prototype.absoluteBorderBox): Deleted.
4336         (FormattingContext.prototype.absolutePaddingBox): Deleted.
4337         (FormattingContext.prototype.absoluteContentBox): Deleted.
4338         (FormattingContext.prototype._toAbsolutePosition): Deleted.
4339         (FormattingContext.prototype._toRootAbsolutePosition): Deleted.