[watchOS] Remove unused Proximity Networking code
[WebKit-https.git] / Tools / ChangeLog
1 2019-03-24  Andy Estes  <aestes@apple.com>
2
3         [watchOS] Remove unused Proximity Networking code
4         https://bugs.webkit.org/show_bug.cgi?id=196188
5
6         Reviewed by Tim Horton.
7
8         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
9         (TEST):
10
11 2019-03-23  Keith Miller  <keith_miller@apple.com>
12
13         Refactor clz/ctz and fix getLSBSet.
14         https://bugs.webkit.org/show_bug.cgi?id=196162
15
16         Reviewed by Saam Barati.
17
18         Add tests for clz, ctz, getLSBSet, and getMSBSet.
19
20         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
21         (TestWebKitAPI::TEST):
22
23 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
24
25         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
26         https://bugs.webkit.org/show_bug.cgi?id=196143
27
28         Reviewed by Michael Catanzaro.
29
30         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
31         directories.
32
33         * Scripts/webkitpy/style/checkers/cpp.py:
34         (check_identifier_name_in_declaration):
35         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
36         (WebKitStyleTest.test_names):
37
38 2019-03-22  Philippe Normand  <pnormand@igalia.com>
39
40         [Flatpak] Manifest expanding fails for qt WPE extension
41         https://bugs.webkit.org/show_bug.cgi?id=196148
42
43         Reviewed by Alex Christensen.
44
45         * flatpak/flatpakutils.py:
46         (expand_submodules_recurse): The last recurse manifest expand
47         iteration might lead to a single module so take it into account
48         and don't try to recurse further.
49
50 2019-03-22  Chris Dumez  <cdumez@apple.com>
51
52         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
53         https://bugs.webkit.org/show_bug.cgi?id=195348
54         <rdar://problem/48622090>
55
56         Reviewed by Alex Christensen.
57
58         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
59         to NO when test.options().shouldIgnoreMetaViewport is false.
60
61         * WebKitTestRunner/ios/TestControllerIOS.mm:
62         (WTR::TestController::platformConfigureViewForTest):
63
64 2019-03-22  Chris Dumez  <cdumez@apple.com>
65
66         Prewarmed processes should be usable with any website data store
67         https://bugs.webkit.org/show_bug.cgi?id=196104
68
69         Reviewed by Alex Christensen.
70
71         Add API test coverage.
72
73         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
74         (runInitialWarmedProcessUsedTest):
75         (TEST):
76
77 2019-03-22  David Kilzer  <ddkilzer@apple.com>
78
79         Back out local changes to Alex's Subversion working directory
80
81         They were accidentally committed.
82
83         * Scripts/webkitpy/common/system/abstractexecutive.py:
84         (AbstractExecutive.wait_newest):
85         * Scripts/webkitpy/common/system/executive.py:
86         (Executive.running_pids):
87         * Scripts/webkitpy/common/system/executive_mock.py:
88         (MockExecutive.running_pids):
89         * Scripts/webkitpy/common/system/executive_unittest.py:
90         (ExecutiveTest.serial_test_running_pids):
91         * Scripts/webkitpy/port/darwin.py:
92         (DarwinPort.check_for_leaks):
93         * Scripts/webkitpy/port/leakdetector.py:
94         (LeakDetector.check_for_leaks):
95         - This was the hack attached to Bug 193772.
96
97         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
98         (+[WebKitTestRunnerEvent mouseLocation]):
99         - This works around a crash on an internal build.
100
101 2019-03-22  Tim Horton  <timothy_horton@apple.com>
102
103         Fix the build after r243354
104         https://bugs.webkit.org/show_bug.cgi?id=196138
105         <rdar://problem/49145951>
106
107         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
108         (TEST):
109         * TestWebKitAPI/ios/UIKitSPI.h:
110
111 2019-03-21  Tim Horton  <timothy_horton@apple.com>
112
113         Adopt UIWKDocumentContext
114         https://bugs.webkit.org/show_bug.cgi?id=196040
115         <rdar://problem/48642440>
116
117         Reviewed by Ryosuke Niwa.
118
119         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
120         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
121         (makeRequest):
122         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
123         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
124         (applyStyle):
125         (TEST):
126         Add tests for UIWKDocumentContext.
127
128         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
129         (TEST):
130         (recursiveFindWKContentView): Deleted.
131         * TestWebKitAPI/cocoa/TestWKWebView.h:
132         * TestWebKitAPI/cocoa/TestWKWebView.mm:
133         (recursiveFindWKContentView):
134         (-[TestWKWebView wkContentView]):
135         * TestWebKitAPI/ios/UIKitSPI.h:
136         Share the WKContentView finding code between tests.
137
138 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
139
140         [iOS WK2] Turn on async overflow scrolling by default
141         https://bugs.webkit.org/show_bug.cgi?id=196011
142         rdar://problem/48453859
143
144         Reviewed by Antti Koivisto.
145         
146         Explicitly turn off the async overflow scrolling internal feature for tests by default,
147         since so many basic layout tests have different results when compositing is triggered for
148         overflow.
149         
150         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
151
152         * WebKitTestRunner/TestController.cpp:
153         (WTR::TestController::resetPreferencesToConsistentValues):
154
155 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
156
157         [ews-build] Retry API test in case of failures
158         https://bugs.webkit.org/show_bug.cgi?id=196004
159
160         Reviewed by Lucas Forschler.
161
162         * BuildSlaveSupport/ews-build/steps.py:
163         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
164         (CompileWebKitToT.doStepIf): Ditto.
165         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
166         (ReRunAPITests): Re-run API tests.
167         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
168         (RunAPITestsWithoutPatch): Run API tests without patch.
169         (RunAPITestsWithoutPatch.doStepIf):
170         (RunAPITestsWithoutPatch.hideStepIf):
171         (RunAPITestsWithoutPatch.evaluateCommand):
172         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
173         (AnalyzeAPITestsResults.start):
174         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
175         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
176         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
177         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
178
179 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
180
181         [ews-build] Update queues configurations
182         https://bugs.webkit.org/show_bug.cgi?id=196074
183
184         Reviewed by Dewei Zhu.
185
186         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
187         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
188
189 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
190
191         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
192         https://bugs.webkit.org/show_bug.cgi?id=195680
193         <rdar://problem/48903534>
194
195         Unreviewed infrastructure fix.
196
197         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
198         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
199
200 2019-03-21  Andy Estes  <aestes@apple.com>
201
202         [iOS] Apple Pay should be available in documents with no user agent scripts
203         https://bugs.webkit.org/show_bug.cgi?id=196061
204         <rdar://problem/48649391>
205
206         Reviewed by Brady Eidson.
207
208         Added API tests and related infrastructure.
209
210         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
211         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
212         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
213         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
214         (TestWebKitAPI::TEST):
215         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
216         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
217         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
218         * TestWebKitAPI/cocoa/TestProtocol.mm:
219         (-[TestProtocol startLoading]):
220         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
221         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
222         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
223         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
224
225 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
226
227         REGRESSSION (r243297): webkitpy tests broken
228         https://bugs.webkit.org/show_bug.cgi?id=196108
229
230         Reviewed by Aakash Jain.
231
232         r243297 updated contributors.json, which broke a few unit tests.
233
234         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
235         (IRCCommandTest.test_whois):
236         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
237
238 2019-03-21  Chris Dumez  <cdumez@apple.com>
239
240         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
241         https://bugs.webkit.org/show_bug.cgi?id=196041
242         <rdar://problem/49083230>
243
244         Reviewed by Alex Christensen.
245
246         Add API test coverage.
247
248         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
249         (TEST):
250
251 2019-03-21  Alex Christensen  <achristensen@webkit.org>
252
253         Add SPI to inform applications of WKContentRuleList actions
254         https://bugs.webkit.org/show_bug.cgi?id=195965
255         <rdar://problem/42664365>
256
257         Reviewed by Geoff Garen.
258
259         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
260         (TestWebKitAPI::allActionsForResourceLoad):
261         (TestWebKitAPI::testRequest):
262         (TestWebKitAPI::TEST_F):
263         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
264         (Notification::description):
265         (Notification::operator== const):
266         (toVector):
267         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
268         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
269         (makeContentRuleList):
270         (TEST):
271         (makeWarnContentRuleList): Deleted.
272
273 2019-03-21  Timothy Hatcher  <timothy@apple.com>
274
275         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
276         https://bugs.webkit.org/show_bug.cgi?id=196088
277
278         Reviewed by Brian Burg.
279
280         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
281         Support checks when only one platform is specified. Also deprecate macosx() and
282         force the use of macos() instead.
283
284         * Scripts/webkitpy/style/checkers/cpp.py:
285         (check_min_versions_of_wk_api_available):
286         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
287         (WebKitStyleTest.test_min_versions_of_wk_api_available):
288
289 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
290
291         Update status inactive committers' status to 'contributor'.
292
293         * Scripts/webkitpy/common/config/contributors.json:
294
295 2019-03-21  Xan Lopez  <xan@igalia.com>
296
297         [JSC][x86] Drop support for x87 floating point
298         https://bugs.webkit.org/show_bug.cgi?id=194853
299
300         Reviewed by Don Olmstead.
301
302         Force SSE2 on x86/32bit builds.
303
304         * Scripts/webkitdirs.pm:
305         (generateBuildSystemFromCMakeProject):
306
307 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
308
309         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
310         https://bugs.webkit.org/show_bug.cgi?id=196073
311
312         Reviewed by Michael Catanzaro.
313
314         Add test cases to check functions and constructors with no arguments but receiving user data.
315
316         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
317         (checkUserData):
318         (testJSCFunction):
319         (fooCreateWithUserData):
320         (testJSCClass):
321
322 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
323
324         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
325
326         Add g_assert_cmpfloat_with_epsilon macro if not defined.
327
328         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
329
330 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
331
332         [GTK][WPE] Add API to provide geolocation information
333         https://bugs.webkit.org/show_bug.cgi?id=195940
334
335         Reviewed by Michael Catanzaro.
336
337         Add a new test to check the new API.
338
339         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
340         (testGeolocationManagerCurrentPosition):
341         (testGeolocationManagerWatchPosition):
342         (beforeAll):
343         (afterAll):
344         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
345         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
346         (beforeAll): Ditto.
347         * TestWebKitAPI/glib/CMakeLists.txt:
348
349 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
350
351         [GLib] Returning G_TYPE_OBJECT from a method does not work
352         https://bugs.webkit.org/show_bug.cgi?id=195574
353
354         Reviewed by Michael Catanzaro.
355
356         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
357
358         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
359         (getGFile):
360         (getParent):
361         (createGString):
362         (getGString):
363         (getGStringCopyWillRaise):
364         (getGStringCopy):
365         (getGStringStr):
366         (getGStringLen):
367         (freeGString):
368         (testJSCClass):
369
370 2019-03-20  Saam Barati  <sbarati@apple.com>
371
372         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
373         https://bugs.webkit.org/show_bug.cgi?id=195721
374
375         Reviewed by Filip Pizlo.
376
377         * Scripts/run-javascriptcore-tests:
378
379 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
380
381         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
382         https://bugs.webkit.org/show_bug.cgi?id=196049
383
384         Reviewed by Tim Horton.
385
386         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
387         overflow scrolling in general, so rename it.
388
389         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
390
391 2019-03-20  Daniel Bates  <dabates@apple.com>
392
393         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
394         https://bugs.webkit.org/show_bug.cgi?id=196031
395         <rdar://problem/49078172>
396
397         Reviewed by Tim Horton.
398
399         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
400         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
401         same code path used when the Done button is pressed to dismiss the <select> picker.
402
403         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
404         (TestWebKitAPI::TEST):
405
406 2019-03-20  Chris Dumez  <cdumez@apple.com>
407
408         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
409         https://bugs.webkit.org/show_bug.cgi?id=196029
410         <rdar://problem/48954651>
411
412         Reviewed by Tim Horton.
413
414         Add API test coverage.
415
416         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
417
418 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
419
420         [ews-build] Improve failure summary string for ApplyPatch step
421         https://bugs.webkit.org/show_bug.cgi?id=195995
422
423         Reviewed by Alexey Proskuryakov.
424
425         * BuildSlaveSupport/ews-build/steps.py:
426         (ApplyPatch.getResultSummary): Override getResultSummary.
427
428 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
429
430         AX: Implement support for new meter ARIA role
431         https://bugs.webkit.org/show_bug.cgi?id=195966
432
433         Reviewed by Chris Fleizach.
434
435         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
436         to AXLevelIndicator.
437
438         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
439
440 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
441
442         [WebAuthN] Implement FIDO AppID extension
443         https://bugs.webkit.org/show_bug.cgi?id=143491
444         <rdar://problem/48298273>
445
446         Reviewed by Brent Fulgham.
447
448         Add a test that covers the new flag of convertToU2fSignCommand.
449
450         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
451         (TestWebKitAPI::TEST):
452         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
453         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
454         (TestWebKitAPI::TEST):
455
456 2019-03-19  Keith Rollin  <krollin@apple.com>
457
458         Add support for more platforms to generate-xcfilelists
459         https://bugs.webkit.org/show_bug.cgi?id=195977
460
461         Reviewed by Alexey Proskuryakov.
462
463         generate-xcfilelists incorrectly complains when involved with building
464         WebKit for iphonesimulator:
465
466             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
467             …
468             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
469
470         Address this by teaching generate-xcfilelists about more platforms.
471
472         * Scripts/generate-xcfilelists:
473
474 2019-03-19  John Wilander  <wilander@apple.com>
475
476         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
477         https://bugs.webkit.org/show_bug.cgi?id=195923
478         <rdar://problem/49001272>
479
480         Reviewed by Alex Christensen.
481
482         This patch does the following to the TestRunner:
483         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
484         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
485         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
486
487         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
488         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
489         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
490         * WebKitTestRunner/InjectedBundle/TestRunner.h:
491         * WebKitTestRunner/TestController.cpp:
492         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
493         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
494         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
495         * WebKitTestRunner/TestController.h:
496         * WebKitTestRunner/TestInvocation.cpp:
497         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
498
499 2019-03-19  Christopher Reid  <chris.reid@sony.com>
500
501         [CMake] Support more clang and gcc sanitizers
502         https://bugs.webkit.org/show_bug.cgi?id=195956
503
504         Reviewed by Michael Catanzaro.
505
506         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
507
508 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
509
510         [ews-build] Improve summary for PrintConfiguration step
511         https://bugs.webkit.org/show_bug.cgi?id=195945
512
513         Reviewed by Lucas Forschler.
514
515         * BuildSlaveSupport/ews-build/steps.py:
516         (PrintConfiguration.getResultSummary): Override getResultSummary.
517
518 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
519
520         [ews-build] Improve summary for CheckOutSource step
521         https://bugs.webkit.org/show_bug.cgi?id=195963
522
523         Reviewed by Lucas Forschler.
524
525         * BuildSlaveSupport/ews-build/steps.py:
526         (CheckOutSource.getResultSummary):
527
528 2019-03-19  Daniel Bates  <dabates@apple.com>
529
530         [iOS] Focus not preserved when switching between tabs
531         https://bugs.webkit.org/show_bug.cgi?id=195820
532         <rdar://problem/43614450>
533
534         Reviewed by Brent Fulgham.
535
536         Add tests to ensure that we restore focus when resigning and becoming first responder.
537
538         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
539         (TestWebKitAPI::TEST):
540
541 2019-03-19  Alex Christensen  <achristensen@webkit.org>
542
543         Make WTFLogChannelState and WTFLogLevel enum classes
544         https://bugs.webkit.org/show_bug.cgi?id=195904
545
546         Reviewed by Eric Carlson.
547
548         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
549         (TestWebKitAPI::TEST_F):
550
551 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
552
553         [GStreamer][EME] Backported mssdemux protection data crash fix
554         https://bugs.webkit.org/show_bug.cgi?id=195918
555
556         Reviewed by Philippe Normand.
557
558         * gstreamer/jhbuild.modules:
559         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
560
561 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
562
563         Unreviewed, rolling out r243132.
564
565         Broke GTK build
566
567         Reverted changeset:
568
569         "Make WTFLogChannelState and WTFLogLevel enum classes"
570         https://bugs.webkit.org/show_bug.cgi?id=195904
571         https://trac.webkit.org/changeset/243132
572
573 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
574
575         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
576
577         * Scripts/webkitdirs.pm:
578         (builtDylibPathForName): Adjust the shared library name that's changed
579         with the API version bump in r243073.
580
581 2019-03-18  Alex Christensen  <achristensen@webkit.org>
582
583         Make WTFLogChannelState and WTFLogLevel enum classes
584         https://bugs.webkit.org/show_bug.cgi?id=195904
585
586         Reviewed by Eric Carlson.
587
588         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
589         (TestWebKitAPI::TEST_F):
590
591 2019-03-18  Alex Christensen  <achristensen@webkit.org>
592
593         Disable flaky test added in r2431100
594         https://webkit.org/b/195785
595
596         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
597         (TestWebKitAPI::TEST):
598         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
599
600 2019-03-18  Timothy Hatcher  <timothy@apple.com>
601
602         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
603         https://bugs.webkit.org/show_bug.cgi?id=195916
604
605         Reviewed by Tim Horton.
606
607         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
608         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
609
610 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
611
612         Add a secondary e-mail address for Fujii Hironori to make tools happier.
613
614         * Scripts/webkitpy/common/config/contributors.json:
615
616 2019-03-18  Alex Christensen  <achristensen@webkit.org>
617
618         Implement DownloadMonitor to prevent long-running slow downloads from background apps
619         https://bugs.webkit.org/show_bug.cgi?id=195785
620
621         Reviewed by Geoffrey Garen.
622
623         * TestWebKitAPI/TCPServer.cpp: Added.
624         (TestWebKitAPI::TCPServer::TCPServer):
625         (TestWebKitAPI::TCPServer::~TCPServer):
626         (TestWebKitAPI::TCPServer::socketBindListen):
627         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
628         * TestWebKitAPI/TCPServer.h: Added.
629         (TestWebKitAPI::TCPServer::port const):
630         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
631         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
632         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
633         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
634         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
635         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
636         (TestWebKitAPI::respondSlowly):
637         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
638         (TestWebKitAPI::downloadAtRate):
639         (TestWebKitAPI::TEST):
640
641 2019-03-18  Saam Barati  <sbarati@apple.com>
642
643         Add a plan file for JetStream 2
644         https://bugs.webkit.org/show_bug.cgi?id=190734
645
646         Reviewed by Mark Lam.
647
648         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
649
650 2019-03-18  Chris Dumez  <cdumez@apple.com>
651
652         Delay WebProcess launch until a load is triggered in a Web view
653         https://bugs.webkit.org/show_bug.cgi?id=195758
654         <rdar://problem/48126013>
655
656         Reviewed by Geoff Garen.
657
658         Add API test coverage. Also update some existing API tests to not expect
659         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
660
661         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
662         (TestWebKitAPI::TEST):
663         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
664         (TestWebKitAPI::TEST):
665         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
666         (TEST):
667         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
668         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
669         (TEST):
670         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
671         (TEST):
672         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
673
674 2019-03-18  Xan Lopez  <xan@igalia.com>
675
676         [CMake] Prevent potential warning when determining $architecture
677         https://bugs.webkit.org/show_bug.cgi?id=195891
678
679         Reviewed by Michael Catanzaro.
680
681         It's possible for generateBuildSystemForCMakeProject to be called
682         before determineArchitecture() is ever called. This will make the
683         first eq check with $architecture to be bogus (and print a
684         warning). Change that to an eq check with architecture(), which
685         implicitly calls determineArchitecture() if needed, and change all
686         the other similar cases in the method in the same way to prevent
687         future bugs like this one.
688
689         * Scripts/webkitdirs.pm:
690         (generateBuildSystemFromCMakeProject):
691
692 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
693
694         [WPE] Tarballs generated with “make dist” cannot build documentation
695         https://bugs.webkit.org/show_bug.cgi?id=195885
696
697         Reviewed by Carlos Garcia Campos.
698
699         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
700
701 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
702
703         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
704         https://bugs.webkit.org/show_bug.cgi?id=195883
705
706         Reviewed by Carlos Garcia Campos.
707
708         * gtkdoc/gtkdoc.py:
709         (GTKDoc._run_command): When commands fail to run, include the full command line for
710         the program invocation and the output it has generated on the standard error stream.
711
712 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
713
714         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
715         https://bugs.webkit.org/show_bug.cgi?id=195786
716
717         Reviewed by Philippe Normand.
718
719         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
720         * wpe/jhbuild.modules: Ditto.
721
722 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
723
724         [ews-build] Don't run clean builds on EWS builders
725         https://bugs.webkit.org/show_bug.cgi?id=195851
726
727         Reviewed by Geoffrey Garen.
728
729         * BuildSlaveSupport/ews-build/factories.py:
730
731 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
732
733         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
734         https://bugs.webkit.org/show_bug.cgi?id=195849
735
736         Reviewed by Chris Dumez.
737
738         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
739
740         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
741         (runWebsiteDataStoreCustomPaths):
742
743 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
744
745         webkitpy: Upload test results
746         https://bugs.webkit.org/show_bug.cgi?id=195755
747         <rdar://problem/48896182>
748
749         Reviewed by Aakash Jain.
750
751         Establish a new format for uploading results that is not tied to layout tests, apply
752         that format to webkitpy tests.
753
754         * Scripts/webkitpy/common/checkout/scm/git.py:
755         (Git.native_branch): Return what branch the current checkout is on.
756         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
757         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
758         * Scripts/webkitpy/common/checkout/scm/svn.py:
759         (SVN.native_branch): Ditto.
760         * Scripts/webkitpy/common/system/platforminfo.py:
761         (PlatformInfo.build_version): Return a build version for Mac.
762         * Scripts/webkitpy/common/system/platforminfo_mock.py:
763         (MockPlatformInfo.__init__):
764         (MockPlatformInfo.build_version):
765         * Scripts/webkitpy/results: Added.
766         * Scripts/webkitpy/results/__init__.py: Added.
767         * Scripts/webkitpy/results/options.py: Added.
768         (upload_options): OptParse list for upload options.
769         * Scripts/webkitpy/results/upload.py: Added.
770         (Upload): Class which enforces the upload format expected by the results server.
771         (Upload.Expectations):
772         (Upload.create_configuration):
773         (Upload.create_commit):
774         (Upload.create_details):
775         (Upload.create_run_stats):
776         (Upload.create_test_result):
777         (Upload.__init__):
778         (Upload.Encoder): Encode Upload object as json.
779         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
780         * Scripts/webkitpy/results/upload_unittest.py: Added.
781         * Scripts/webkitpy/test/main.py:
782         (Tester._parse_args): Add upload arguments.
783         (Tester._run_tests): Allow results to be uploaded.
784         * Scripts/webkitpy/test/runner.py:
785         (Runner.__init__): Record which tests were run, rather than just counting them.
786         (Runner.handle):
787         * Scripts/webkitpy/test/runner_unittest.py:
788         (RunnerTest.test_run):
789         * Scripts/webkitpy/thirdparty/__init__.py:
790         (AutoinstallImportHook.find_module): Add requests auto-install.
791         (AutoinstallImportHook._install_requests):
792         * Scripts/webkitpy/tool/commands/queues_unittest.py:
793         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
794
795 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
796
797         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
798         https://bugs.webkit.org/show_bug.cgi?id=195810
799
800         Reviewed by Tim Horton.
801
802         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
803         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
804         ending certain layout tests.
805
806         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
807         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
808         (-[TestRunnerWKWebView dealloc]):
809         (-[TestRunnerWKWebView resetInteractionCallbacks]):
810
811         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
812         helper method when destroying the web view, and when resetting state between tests.
813
814         * WebKitTestRunner/ios/TestControllerIOS.mm:
815         (WTR::TestController::platformResetStateToConsistentValues):
816
817         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
818
819 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
820
821         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
822         https://bugs.webkit.org/show_bug.cgi?id=190350
823         <rdar://problem/45089503>
824
825         Reviewed by Geoffrey Garen.
826
827         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
828         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
829         (TEST):
830         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
831         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
832         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
833         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
834         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
835         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
836         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
837         (runTest):
838         (createDirectories):
839         (TEST):
840         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
841         (TEST):
842         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
843         (TEST):
844
845 2019-03-15  Timothy Hatcher  <timothy@apple.com>
846
847         Add support to WebPage for getting the contents as an attributed string.
848         https://bugs.webkit.org/show_bug.cgi?id=195636
849         rdar://problem/45055697
850
851         Reviewed by Tim Horton.
852
853         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
854         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
855
856 2019-03-15  Chris Dumez  <cdumez@apple.com>
857
858         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
859         https://bugs.webkit.org/show_bug.cgi?id=195747
860
861         Reviewed by Geoff Garen.
862
863         Add API test coverage.
864
865         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
866
867 2019-03-15  Shawn Roberts  <sroberts@apple.com>
868
869         Unreviewed, rolling out r242952.
870
871         Causing API failures on iOS Simulator
872
873         Reverted changeset:
874
875         "[PSON] Make sure the WebProcessCache is leverage when
876         relaunching a process after termination"
877         https://bugs.webkit.org/show_bug.cgi?id=195747
878         https://trac.webkit.org/changeset/242952
879
880 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
881
882         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
883         https://bugs.webkit.org/show_bug.cgi?id=195740
884
885         Reviewed by Ross Kirsling.
886
887         window.open doesn't work for WebKitBrowserWindow because it is not
888         implemented yet.
889
890         1. Implemented createNewPage callback of WKPageUIClient.
891         2. Changed MainWindow to take a BrowserWindow factory function
892           instead of BrowserWindowType to be flexible to create
893           BrowserWindow with extra settings.
894         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
895           because it is not relevant with MainWindow anymore.
896
897         * MiniBrowser/win/Common.cpp:
898         (parseCommandLine):
899         * MiniBrowser/win/Common.h:
900         (CommandLineOptions::CommandLineOptions):
901         * MiniBrowser/win/MainWindow.cpp:
902         (MainWindow::MainWindow):
903         (MainWindow::create):
904         (MainWindow::init):
905         (MainWindow::WndProc):
906         * MiniBrowser/win/MainWindow.h:
907         * MiniBrowser/win/PrintWebUIDelegate.cpp:
908         (PrintWebUIDelegate::createWebViewWithRequest):
909         * MiniBrowser/win/WebKitBrowserWindow.cpp:
910         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
911         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
912         (WebKitBrowserWindow::updateProxySettings):
913         (WebKitBrowserWindow::createNewPage):
914         * MiniBrowser/win/WebKitBrowserWindow.h:
915         * MiniBrowser/win/WinMain.cpp:
916         (wWinMain):
917
918 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
919
920         Make it possible to test scrolling tree layer manipulation more easily
921         https://bugs.webkit.org/show_bug.cgi?id=195780
922
923         Reviewed by Tim Horton.
924         
925         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
926         cuts off communication of scrolling tree scrolls back to the web process
927         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
928         allows tests to trigger scrolls which run the scrolling tree layer positioning
929         logic, but never get another commit from the web process that might mask
930         scrolling tree bugs.
931         
932         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
933         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
934         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
935
936         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
937         (WTR::UIScriptController::scrollUpdatesDisabled const):
938         (WTR::UIScriptController::setScrollUpdatesDisabled):
939         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
940         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
941         (WTR::UIScriptController::scrollUpdatesDisabled const):
942         (WTR::UIScriptController::setScrollUpdatesDisabled):
943         * TestRunnerShared/UIScriptContext/UIScriptController.h:
944         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
945         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
946         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
947         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
948         * WebKitTestRunner/ios/TestControllerIOS.mm:
949         (WTR::TestController::platformResetStateToConsistentValues):
950         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
951         (WTR::UIScriptController::scrollUpdatesDisabled const):
952         (WTR::UIScriptController::setScrollUpdatesDisabled):
953
954 2019-03-14  Youenn Fablet  <youenn@apple.com>
955
956         Move IDB storage in private browsing mode to NetworkProcess
957         https://bugs.webkit.org/show_bug.cgi?id=195602
958
959         Reviewed by Brady Eidson.
960
961         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
962         (TEST):
963
964 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
965
966         [ews-build] Make descriptionDone messages more readable
967         https://bugs.webkit.org/show_bug.cgi?id=195760
968
969         Reviewed by Lucas Forschler.
970
971         * BuildSlaveSupport/ews-build/steps.py:
972         * BuildSlaveSupport/ews-build/steps_unittest.py:
973
974 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
975
976         [ews-build] Generate status-bubble hover-over messages
977         https://bugs.webkit.org/show_bug.cgi?id=195680
978
979         Reviewed by Lucas Forschler.
980
981         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
982         (StatusBubble):
983         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
984         on hover-over.
985         (StatusBubble._iso_time):
986         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
987         hover-over message.
988         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
989
990 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
991
992         [ews-app] Gracefully handle the case when state_string is None
993         https://bugs.webkit.org/show_bug.cgi?id=195753
994
995         Reviewed by Lucas Forschler.
996
997         * BuildSlaveSupport/ews-app/ews/models/build.py:
998         * BuildSlaveSupport/ews-app/ews/models/step.py:
999
1000 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
1001
1002         [ews-app] Status bubble display pending for currently running build step
1003         https://bugs.webkit.org/show_bug.cgi?id=195744
1004
1005         Reviewed by Lucas Forschler.
1006
1007         * BuildSlaveSupport/ews-build/events.py:
1008         (Events.stepStarted): If state_string is pending, replace it with step name.
1009
1010 2019-03-14  Chris Dumez  <cdumez@apple.com>
1011
1012         Add WebsitePolicy for the client to specify the device orientation & motion access policy
1013         https://bugs.webkit.org/show_bug.cgi?id=195750
1014
1015         Reviewed by Geoffrey Garen.
1016
1017         Add API test coverage.
1018
1019         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1020         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
1021         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1022         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
1023
1024 2019-03-14  Chris Dumez  <cdumez@apple.com>
1025
1026         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
1027         https://bugs.webkit.org/show_bug.cgi?id=195747
1028
1029         Reviewed by Geoff Garen.
1030
1031         Add API test coverage.
1032
1033         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1034
1035 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
1036
1037         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
1038         https://bugs.webkit.org/show_bug.cgi?id=195725
1039         <rdar://problem/48545062>
1040
1041         Reviewed by Tim Horton.
1042
1043         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
1044         handler is nil.
1045
1046         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1047         (TestWebKitAPI::TEST):
1048
1049 2019-03-13  Sam Weinig  <sam@webkit.org>
1050
1051         Add utility function to allow easy reverse range-based iteration of a container
1052         https://bugs.webkit.org/show_bug.cgi?id=195542
1053
1054         Reviewed by Antti Koivisto.
1055
1056         * TestWebKitAPI/CMakeLists.txt:
1057         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1058         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
1059         (TestWebKitAPI::TEST):
1060         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
1061
1062 2019-03-13  Chris Dumez  <cdumez@apple.com>
1063
1064         Use a ServiceWorker process per registrable domain
1065         https://bugs.webkit.org/show_bug.cgi?id=195649
1066
1067         Reviewed by Youenn Fablet.
1068
1069         Update API test coverage.
1070
1071         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1072
1073 2019-03-13  Chris Dumez  <cdumez@apple.com>
1074
1075         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
1076         https://bugs.webkit.org/show_bug.cgi?id=195684
1077         <rdar://problem/48294714>
1078
1079         Reviewed by Antti Koivisto.
1080
1081         Add API test coverage.
1082
1083         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1084
1085 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
1086
1087         [ews-app] Remove unused patch view
1088         https://bugs.webkit.org/show_bug.cgi?id=195669
1089
1090         Reviewed by Lucas Forschler.
1091
1092         * BuildSlaveSupport/ews-app/ews/urls.py:
1093         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
1094
1095 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
1096
1097         [ews-app] Use Buildbot result code variables
1098         https://bugs.webkit.org/show_bug.cgi?id=195668
1099
1100         Reviewed by Alexey Proskuryakov.
1101
1102         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
1103         (Buildbot): Added Buildbot result code variables.
1104         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1105         (StatusBubble._build_bubble): Used Buildbot result code variables.
1106
1107 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
1108
1109         [Flatpak] Expand submodule recursively
1110         https://bugs.webkit.org/show_bug.cgi?id=195672
1111
1112         Building WPE with flatpak was impossible without that as it was raising an exception.
1113         Also update wpebackend-fdo to match what is built in jhbuild
1114
1115         Reviewed by Philippe Normand.
1116
1117         * flatpak/flatpakutils.py:
1118         (expand_submodules_recurse):
1119         (expand_manifest):
1120         * flatpak/org.webkit.WPEModules.yaml:
1121
1122 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
1123
1124         [ews-app] status bubble should be hidden for certain builds
1125         https://bugs.webkit.org/show_bug.cgi?id=194597
1126
1127         Reviewed by Dewei Zhu.
1128
1129         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1130         (StatusBubble._build_bubble):
1131         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
1132         because the patch didn't have relevant changes.
1133         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
1134         in production yet.
1135
1136 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
1137
1138         [Win] Fix a slew of simple clang-cl warnings.
1139         https://bugs.webkit.org/show_bug.cgi?id=195652
1140
1141         Reviewed by Don Olmstead.
1142
1143         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1144         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
1145
1146 2019-03-12  Justin Fan  <justin_fan@apple.com>
1147
1148         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
1149         https://bugs.webkit.org/show_bug.cgi?id=195518
1150         <rdar://problem/46322356>
1151
1152         Reviewed by Myles C. Maxfield.
1153
1154         * DumpRenderTree/DerivedSources-input.xcfilelist:
1155         * DumpRenderTree/DerivedSources-output.xcfilelist:
1156
1157 2019-03-12  Commit Queue  <commit-queue@webkit.org>
1158
1159         Unreviewed, rolling out r242825.
1160         https://bugs.webkit.org/show_bug.cgi?id=195648
1161
1162         "Broke webkitpy tests with my change to
1163         lldb_dump_class_layout.py" (Requested by rmorisset on
1164         #webkit).
1165
1166         Reverted changeset:
1167
1168         "Alter Tools/Scripts/dump-class-layout to be able to dump all
1169         classes with suspicious padding"
1170         https://bugs.webkit.org/show_bug.cgi?id=195573
1171         https://trac.webkit.org/changeset/242825
1172
1173 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
1174
1175         [ews-build] Show status bubbles while the patch is waiting in queue
1176         https://bugs.webkit.org/show_bug.cgi?id=195618
1177
1178         Reviewed by Lucas Forschler.
1179
1180         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1181         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
1182         enabled in initial deployment.
1183         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
1184         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
1185         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
1186         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
1187         (StatusBubble._build_bubbles_for_patch):
1188
1189 2019-03-12  Robin Morisset  <rmorisset@apple.com>
1190
1191         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
1192         https://bugs.webkit.org/show_bug.cgi?id=195573
1193
1194         Reviewed by Simon Fraser.
1195
1196         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
1197
1198         * Scripts/dump-class-layout:
1199         (main):
1200         * lldb/lldb_dump_class_layout.py:
1201         (ClassLayout.__init__):
1202         (ClassLayout._compute_padding_recursive):
1203         (LLDBDebuggerInstance.dump_layout_for_classname):
1204         (LLDBDebuggerInstance):
1205         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
1206         (LLDBDebuggerInstance.layout_for_classname): Deleted.
1207
1208 2019-03-12  Chris Dumez  <cdumez@apple.com>
1209
1210         Device Orientation access permission should be denied unless explicitly granted by the client
1211         https://bugs.webkit.org/show_bug.cgi?id=195625
1212
1213         Reviewed by Youenn Fablet.
1214
1215         add API test coverage.
1216
1217         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1218         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
1219         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
1220         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
1221         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
1222         (runDeviceOrientationTest):
1223         (TEST):
1224         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1225         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
1226
1227 2019-03-12  Jer Noble  <jer.noble@apple.com>
1228
1229         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
1230         https://bugs.webkit.org/show_bug.cgi?id=195137
1231         <rdar://problem/48810307>
1232
1233         Reviewed by Eric Carlson.
1234
1235         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
1236         (TestWebKitAPI::TEST):
1237
1238 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
1239
1240         [ews-build] Change urls from uat to production
1241         https://bugs.webkit.org/show_bug.cgi?id=195566
1242
1243         Reviewed by Lucas Forschler.
1244
1245         * BuildSlaveSupport/ews-app/ews/config.py:
1246         * BuildSlaveSupport/ews-build/events.py:
1247         * BuildSlaveSupport/ews-build/steps.py:
1248
1249 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
1250
1251         [ews-build] change max_builds for local-worker to 1
1252         https://bugs.webkit.org/show_bug.cgi?id=195568
1253
1254         Reviewed by Lucas Forschler.
1255
1256         * BuildSlaveSupport/ews-build/loadConfig.py:
1257
1258 2019-03-12  Tim Horton  <timothy_horton@apple.com>
1259
1260         Fix the build
1261
1262         * TestRunnerShared/spi/PencilKitTestSPI.h:
1263         * TestWebKitAPI/ios/PencilKitTestSPI.h:
1264
1265 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
1266
1267         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
1268         https://bugs.webkit.org/show_bug.cgi?id=194131
1269
1270         Reviewed by Michael Catanzaro.
1271
1272         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
1273         (uriChanged):
1274         (testUnfinishedSubresourceLoad):
1275         (serverCallback):
1276         (beforeAll):
1277
1278 2019-03-11  Alex Christensen  <achristensen@webkit.org>
1279
1280         WTF::Expected should use std::addressof instead of operator&
1281         https://bugs.webkit.org/show_bug.cgi?id=195604
1282
1283         Reviewed by Myles Maxfield.
1284
1285         * TestWebKitAPI/Tests/WTF/Expected.cpp:
1286         (TestWebKitAPI::Unique::Unique):
1287         (TestWebKitAPI::Unique::operator&):
1288         (TestWebKitAPI::TEST):
1289
1290 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
1291
1292         Add Optional to Forward.h.
1293         https://bugs.webkit.org/show_bug.cgi?id=195586
1294
1295         Reviewed by Darin Adler.
1296
1297         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
1298         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
1299         Remove unnecessary includes from headers.
1300
1301 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
1302
1303         Add testing API to hit-test and scroll overflow scrollers
1304         https://bugs.webkit.org/show_bug.cgi?id=195278
1305
1306         Reviewed by Antti Koivisto.
1307         
1308         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
1309         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
1310         
1311         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
1312
1313         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1314         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
1315         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1316         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1317         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
1318         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1319         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1320         (WTR::enclosingScrollViewIncludingSelf):
1321         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
1322
1323 2019-03-11  Tim Horton  <timothy_horton@apple.com>
1324
1325         API test WebKit.RequestTextInputContext fails on iOS
1326         https://bugs.webkit.org/show_bug.cgi?id=195585
1327
1328         Reviewed by Wenson Hsieh and Simon Fraser.
1329
1330         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
1331         (applyStyle):
1332         (TEST):
1333         Add a viewport, so that the coordinates match up on iOS.
1334         Scroll by moving the UIScrollView's contentOffset.
1335
1336 2019-03-11  Chris Dumez  <cdumez@apple.com>
1337
1338         Assert in WebPageProxy::suspendCurrentPageIfPossible()
1339         https://bugs.webkit.org/show_bug.cgi?id=195506
1340         <rdar://problem/48733477>
1341
1342         Reviewed by Alex Christensen.
1343
1344         Add API test coverage.
1345
1346         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1347
1348 2019-03-11  Shawn Roberts  <sroberts@apple.com>
1349
1350         Adding myself to contributors.json
1351
1352         Unreviewed, addming myself to contributors.json .
1353
1354         * Scripts/webkitpy/common/config/contributors.json:
1355
1356 2019-03-11  Alex Christensen  <achristensen@webkit.org>
1357
1358         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
1359         https://bugs.webkit.org/show_bug.cgi?id=195511
1360         <rdar://problem/44873269>
1361
1362         Reviewed by Darin Adler.
1363
1364         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
1365         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
1366         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
1367         (TEST_F):
1368
1369 2019-03-11  Chris Dumez  <cdumez@apple.com>
1370
1371         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
1372         https://bugs.webkit.org/show_bug.cgi?id=195561
1373
1374         Reviewed by Youenn Fablet.
1375
1376         Make sure the JS in the test requests for permission to receive device orientation events.
1377
1378         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1379
1380 2019-03-11  Youenn Fablet  <youenn@apple.com>
1381
1382         Allow storage quota increase by default in WTR
1383         https://bugs.webkit.org/show_bug.cgi?id=195541
1384
1385         Reviewed by Geoffrey Garen.
1386
1387         Allow storage quota increase by default in WTR.
1388         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
1389         Use this for tests that explicitly need cache increase.
1390
1391         Instead of increasing quota by 2, make sure the next request is
1392         granted by adding all given parameters.
1393
1394         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1395         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1396         (WTR::TestRunner::setAllowStorageQuotaIncrease):
1397         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
1398         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1399         * WebKitTestRunner/TestController.cpp:
1400         (WTR::TestController::setAllowStorageQuotaIncrease):
1401         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
1402         * WebKitTestRunner/TestController.h:
1403         * WebKitTestRunner/TestInvocation.cpp:
1404         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1405         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1406         (WTR::TestController::cocoaResetStateToConsistentValues):
1407         (WTR::TestController::setAllowStorageQuotaIncrease):
1408         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
1409         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
1410         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
1411
1412 2019-03-11  Xan Lopez  <xan@igalia.com>
1413
1414         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
1415         https://bugs.webkit.org/show_bug.cgi?id=194147
1416
1417         Reviewed by Michael Saboff.
1418
1419         To make --32-bit work correctly on Linux/64bit we need to:
1420
1421         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
1422         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
1423         unfortunately CMake only allows us to do this during
1424         crosscompilation, which is overkill here.
1425         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
1426         pkg-config detection module uses the x86 .pc files instead of the
1427         x86_64 ones.
1428         - Set the -m32 flags for the compiler.
1429
1430         * Scripts/webkitdirs.pm:
1431         (generateBuildSystemFromCMakeProject):
1432
1433 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
1434
1435         Add MotionMark-1.1 plan file for run-benchmark script.
1436         https://bugs.webkit.org/show_bug.cgi?id=195481
1437
1438         Rubber-stamped by Darin Adler.
1439
1440         Run-benchmark script should support MontionMark-1.1.
1441
1442         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
1443
1444 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
1445
1446         [ews-app] Add support for submit-to-ews url
1447         https://bugs.webkit.org/show_bug.cgi?id=195477
1448
1449         Reviewed by Lucas Forschler.
1450
1451         * BuildSlaveSupport/ews-app/ews/fetcher.py:
1452         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
1453         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
1454         * BuildSlaveSupport/ews-app/ews/urls.py:
1455         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
1456
1457 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
1458
1459         Unreviewed, rolling out r242688, r242643, r242624.
1460
1461         Caused multiple layout test failures and crashes on iOS and macOS.
1462
1463         Reverted changeset:
1464
1465         "requestAnimationFrame should execute before the next frame"
1466         https://bugs.webkit.org/show_bug.cgi?id=177484
1467         https://trac.webkit.org/changeset/242624/webkit
1468
1469         * Tracing/SystemTracePoints.plist:
1470
1471 2019-03-11  John Wilander  <wilander@apple.com>
1472
1473         Resource Load Statistics: Make it possible exclude localhost from classification
1474         https://bugs.webkit.org/show_bug.cgi?id=195474
1475         <rdar://problem/47520577>
1476
1477         Reviewed by Brent Fulgham.
1478
1479         This patch allows for localhost to be excluded from classification and
1480         treatment as a prevalent resource.
1481
1482         The WebKit Tools change adds a new function called
1483         testRunner.setStatisticsIsRunningTest() which can be used to control this
1484         behavior.
1485
1486         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1487         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1488         (WTR::TestRunner::setStatisticsIsRunningTest):
1489         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1490         * WebKitTestRunner/TestController.cpp:
1491         (WTR::TestController::setStatisticsIsRunningTest):
1492         * WebKitTestRunner/TestController.h:
1493         * WebKitTestRunner/TestInvocation.cpp:
1494         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1495
1496 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
1497
1498         [ews-build] Disable waterfall and console view for ews-build.webkit.org
1499         https://bugs.webkit.org/show_bug.cgi?id=195560
1500
1501         Reviewed by Lucas Forschler.
1502
1503         * BuildSlaveSupport/ews-build/master.cfg:
1504
1505 2019-03-11  Alex Christensen  <achristensen@webkit.org>
1506
1507         Unreviewed, rolling out r242698.
1508
1509         API test crashes on bots.
1510
1511         Reverted changeset:
1512
1513         "Add a WKContentRuleList variant that uses copied memory
1514         instead of mmap'd shared memory for class A containerized
1515         apps"
1516         https://bugs.webkit.org/show_bug.cgi?id=195511
1517         https://trac.webkit.org/changeset/242698
1518
1519 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
1520
1521         [WPE] Enable web process sandbox
1522         https://bugs.webkit.org/show_bug.cgi?id=195169
1523
1524         Reviewed by Daniel Bates.
1525
1526         * wpe/install-dependencies:
1527         * wpe/jhbuild.modules:
1528
1529 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
1530
1531         [ews-app] Use port 17000 for worker communication
1532         https://bugs.webkit.org/show_bug.cgi?id=195558
1533
1534         Reviewed by Lucas Forschler.
1535
1536         * BuildSlaveSupport/ews-build/master.cfg:
1537
1538 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
1539
1540         [ews-build] unit-tests fail when passwords.json is missing
1541         https://bugs.webkit.org/show_bug.cgi?id=195557
1542
1543         Reviewed by Lucas Forschler.
1544
1545         * BuildSlaveSupport/ews-build/loadConfig.py:
1546         (loadBuilderConfig):
1547         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
1548         (ConfigDotJSONTest.test_configuration):
1549         * BuildSlaveSupport/ews-build/master.cfg:
1550
1551 2019-03-11  Truitt Savell  <tsavell@apple.com>
1552
1553         Unreviewed, rolling out r242702.
1554
1555         Broke High Sierra builders.
1556
1557         Reverted changeset:
1558
1559         "Add utility function to allow easy reverse range-based
1560         iteration of a container"
1561         https://bugs.webkit.org/show_bug.cgi?id=195542
1562         https://trac.webkit.org/changeset/242702
1563
1564 2019-03-11  Sam Weinig  <sam@webkit.org>
1565
1566         Add utility function to allow easy reverse range-based iteration of a container
1567         https://bugs.webkit.org/show_bug.cgi?id=195542
1568
1569         Reviewed by Antti Koivisto.
1570
1571         * TestWebKitAPI/CMakeLists.txt:
1572         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1573         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
1574         (TestWebKitAPI::TEST):
1575         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
1576
1577 2019-03-10  Alex Christensen  <achristensen@webkit.org>
1578
1579         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
1580         https://bugs.webkit.org/show_bug.cgi?id=195511
1581         <rdar://problem/44873269>
1582
1583         Reviewed by Darin Adler.
1584
1585         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
1586         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
1587         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
1588         (TEST_F):
1589
1590 2019-03-10  Tim Horton  <timothy_horton@apple.com>
1591
1592         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
1593         https://bugs.webkit.org/show_bug.cgi?id=195499
1594
1595         Reviewed by Darin Adler.
1596
1597         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1598         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
1599         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
1600         (-[WKWebView synchronouslyFocusTextInputContext:]):
1601         (applyStyle):
1602         (applyIframe):
1603         (TEST):
1604         Add some tests for this SPI.
1605
1606 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
1607
1608         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
1609         https://bugs.webkit.org/show_bug.cgi?id=181151
1610
1611         Reviewed by Don Olmstead.
1612
1613         * TestWebKitAPI/CMakeLists.txt:
1614         * TestWebKitAPI/PlatformWin.cmake:
1615         Enable TestWTF RunLoop tests in all platforms.
1616
1617         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
1618         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
1619         (TestWebKitAPI::DerivedOneShotTimer::fired):
1620         (TestWebKitAPI::TEST):
1621         Only a few platforms support nested RunLoop.
1622
1623         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
1624         (TestWebKitAPI::DerivedRepeatingTimer::fired):
1625
1626 2019-03-10  David Quesada  <david_quesada@apple.com>
1627
1628         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
1629         https://bugs.webkit.org/show_bug.cgi?id=152480
1630
1631         Reviewed by Chris Dumez.
1632
1633         Add a unit test based on Daniel Bates's test case that starts a download, ensures
1634         there are no additional references to the process pool besides the one held by
1635         the download, waits for the download to finish (in the sense that the
1636         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
1637         measure, also check that the process pool has been deallocated at the end of the
1638         test. The test wouldn't be meaningful if the process pool were still alive.
1639
1640         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1641         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
1642         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
1643             The download will be canceled because the delegate does not implement the
1644             method to decide the download's destination, so this is where we know the
1645             DownloadProxyMap is done with the DownloadProxy.
1646         (TEST):
1647
1648 2019-03-08  Chris Dumez  <cdumez@apple.com>
1649
1650         Add support for Device Orientation / Motion permission API
1651         https://bugs.webkit.org/show_bug.cgi?id=195329
1652         <rdar://problem/47645367>
1653
1654         Reviewed by Geoffrey Garen.
1655
1656         Add test infrastructure to help test the Device Orientation / Motion permission API.
1657
1658         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1659         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1660         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
1661         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1662         * WebKitTestRunner/TestController.cpp:
1663         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
1664         (WTR::TestController::createWebViewWithOptions):
1665         (WTR::TestController::resetStateToConsistentValues):
1666         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
1667         * WebKitTestRunner/TestController.h:
1668         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
1669         * WebKitTestRunner/TestInvocation.cpp:
1670         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1671
1672 2019-03-08  Saam barati  <sbarati@apple.com>
1673
1674         Add a compare-results script to compare benchmark results
1675         https://bugs.webkit.org/show_bug.cgi?id=195486
1676         <rdar://problem/48723397>
1677
1678         Reviewed by Geoffrey Garen.
1679
1680         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
1681         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
1682         to extend it to learn about our other benchmarks.
1683
1684         * Scripts/compare-results: Added.
1685         (readJSONFile):
1686         (detectJetStream2):
1687         (JetStream2Results):
1688         (detectSpeedometer2):
1689         (Speedometer2Results):
1690         (detectPLT5):
1691         (PLT5Results):
1692         (detectBenchmark):
1693         (biggerIsBetter):
1694         (ttest):
1695         (getOptions):
1696         (main):
1697
1698 2019-03-08  Stephanie Lewis  <slewis@apple.com>
1699
1700         Ensure old tab state is cleared between iterations of run-benchmark
1701         https://bugs.webkit.org/show_bug.cgi?id=195393
1702         <rdar://problem/46885583>
1703
1704         Reviewed by Dewei Zhu.
1705
1706         a) ensure the default to restore state is not set
1707         b) terminate Safari correctly
1708         c) Set the system default to ignore Persistent State in Safari
1709
1710         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
1711         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
1712         (OSXBrowserDriver.prepare_env): 
1713         (OSXBrowserDriver.restore_env):
1714         (OSXBrowserDriver.close_browsers):
1715         (OSXBrowserDriver._terminate_processes):
1716         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
1717         (OSXChromeDriver):
1718         (OSXChromeCanaryDriver):
1719         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
1720         (OSXFirefoxDriver):
1721         (OSXFirefoxNightlyDriver):
1722         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
1723         (OSXSafariDriver):
1724         (OSXSafariDriver.prepare_env):
1725
1726 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
1727
1728         [GTK] Several InputMethodFilter tests are failing
1729         https://bugs.webkit.org/show_bug.cgi?id=195408
1730
1731         Reviewed by Carlos Garcia Campos.
1732
1733         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
1734         Regressed in r241751.
1735         Hexadecimal values of keycodes are expressed now in upper letters.
1736         Composited characters should be cast to UTF8 strings.
1737
1738         (TestWebKitAPI::TEST):
1739
1740 2019-03-07  Tomas Popela  <tpopela@redhat.com>
1741
1742         [GTK] Make Tools/gtkdoc python3 compatible
1743         https://bugs.webkit.org/show_bug.cgi?id=195359
1744
1745         Reviewed by Carlos Garcia Campos.
1746
1747         * gtkdoc/generate-gtkdoc:
1748         ConfigParser was reworked in Python 3.2 so we have adapt the code to
1749         work with Python 2 and 3.
1750         (get_gtkdoc_module_paths):
1751         The iteritems() was removed in Python 3, so let's use items() that's
1752         available in Python 2 and 3.
1753         (get_generator_for_config):
1754         * gtkdoc/gtkdoc.py:
1755         (GTKDoc._run_command):
1756         The sys.stdout.write() is expecting str in Python 3 and not bytes
1757         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
1758         for passing the bytes there.
1759
1760 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
1761
1762         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
1763         https://bugs.webkit.org/show_bug.cgi?id=195346
1764         <rdar://problem/48667048>
1765
1766         Unreviewed build fix for clang-cl.
1767
1768         * DumpRenderTree/win/DumpRenderTree.cpp:
1769         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
1770
1771 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
1772
1773         requestAnimationFrame should execute before the next frame
1774         https://bugs.webkit.org/show_bug.cgi?id=177484
1775
1776         Reviewed by Simon Fraser.
1777
1778         Add trace points for the page RenderingUpdate.
1779
1780         * Tracing/SystemTracePoints.plist:
1781
1782 2019-03-07  Zalan Bujtas  <zalan@apple.com>
1783
1784         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
1785         https://bugs.webkit.org/show_bug.cgi?id=195353
1786         <rdar://problem/48626394>
1787
1788         Reviewed by Simon Fraser.
1789
1790         * WebKitTestRunner/ios/TestControllerIOS.mm:
1791         (WTR::TestController::platformResetPreferencesToConsistentValues):
1792
1793 2019-03-07  John Wilander  <wilander@apple.com>
1794
1795         Resource Load Statistics: Make it possible to purge only script-accessible cookies
1796         https://bugs.webkit.org/show_bug.cgi?id=195383
1797         <rdar://problem/48570136>
1798
1799         Reviewed by Brent Fulgham.
1800
1801         This patch adds test infrastructure to purge only script-accessible cookies,
1802         including a new testRunner function called statisticsDeleteCookiesForHost().git a
1803
1804         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1805         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1806         (WTR::TestRunner::statisticsDeleteCookiesForHost):
1807         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1808         * WebKitTestRunner/TestController.cpp:
1809         (WTR::TestController::statisticsDeleteCookiesForHost):
1810         * WebKitTestRunner/TestController.h:
1811         * WebKitTestRunner/TestInvocation.cpp:
1812         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1813
1814 2019-03-07  Commit Queue  <commit-queue@webkit.org>
1815
1816         Unreviewed, rolling out r242354.
1817         https://bugs.webkit.org/show_bug.cgi?id=195402
1818
1819         breaks layout tests in all configurations (Requested by
1820         zdobersek on #webkit).
1821
1822         Reverted changeset:
1823
1824         "[WPE] Enable web process sandbox"
1825         https://bugs.webkit.org/show_bug.cgi?id=195169
1826         https://trac.webkit.org/changeset/242354
1827
1828 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
1829
1830         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
1831         https://bugs.webkit.org/show_bug.cgi?id=195346
1832
1833         Reviewed by Fujii Hironori.
1834
1835         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
1836         (TestWebKitAPI::TEST):
1837         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
1838
1839         * DumpRenderTree/win/DumpRenderTree.cpp:
1840         (findFontFallback):
1841         (addFontFallbackIfPresent):
1842         (removeFontFallbackIfPresent):
1843         (main):
1844         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
1845         (TestWebKitAPI::Util::moduleDirectory):
1846         (TestWebKitAPI::Util::createInjectedBundlePath):
1847         Use wchar helpers as needed.
1848
1849 2019-03-06  Rob Buis  <rbuis@igalia.com>
1850
1851         Consider supporting the `referrerpolicy` attribute.
1852         https://bugs.webkit.org/show_bug.cgi?id=179053
1853
1854         Reviewed by Darin Adler.
1855
1856         Add a runtime flag for referrerpolicy attribute.
1857
1858         * DumpRenderTree/mac/DumpRenderTree.mm:
1859         (enableExperimentalFeatures):
1860
1861 2019-03-05  Daniel Bates  <dabates@apple.com>
1862
1863         Update expected API test result following r242379
1864         (https://bugs.webkit.org/show_bug.cgi?id=195125)
1865
1866         Update expected x-coordinate of selection rect now that the left padding of
1867         a textarea is sized in ems (so dependent on the font size) just like the left
1868         padding of a text field.
1869
1870         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
1871         (TestWebKitAPI::TEST):
1872
1873 2019-03-05  David Quesada  <david_quesada@apple.com>
1874
1875         [WK2] It should be possible to follow links with 'download' attributes
1876         https://bugs.webkit.org/show_bug.cgi?id=195145
1877         rdar://problem/48462642
1878
1879         Reviewed by Alex Christensen.
1880
1881         Add a unit test to verify that activating links with 'download' attributes now
1882         navigates to the linked resource, rather than starts downloading it. Add another
1883         to verify that it is still possible to explicitly download the link via the
1884         'Download' navigation action policy.
1885
1886         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1887         (-[DownloadAttributeTestDelegate init]):
1888         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
1889         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
1890         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
1891         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
1892         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1893         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
1894         (TEST):
1895         * WebKitTestRunner/TestController.cpp:
1896         (WTR::TestController::decidePolicyForNavigationAction):
1897         * WebKitTestRunner/TestController.h:
1898
1899 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
1900
1901         [Curl] Implement Cookie Accept Policy.
1902         https://bugs.webkit.org/show_bug.cgi?id=191645
1903
1904         Reviewed by Fujii Hironori.
1905
1906         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
1907         (TestWebKitAPI::Curl::TEST_F):
1908
1909 2019-03-05  Youenn Fablet  <youenn@apple.com>
1910
1911         Rename requestCacheStorageSpace to requestStorageSpace
1912         https://bugs.webkit.org/show_bug.cgi?id=195282
1913
1914         Reviewed by Chris Dumez.
1915
1916         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
1917         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
1918         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
1919
1920 2019-03-05  Brady Eidson  <beidson@apple.com>
1921
1922         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
1923         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
1924
1925         Reviewed by Tim Horton.
1926
1927         Loading a file: URL into a WKWebView and then loading another file: url from a completely
1928         different directory into that same WKWebView should work.
1929
1930         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1931         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
1932
1933 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
1934
1935         Add WeakHashSet
1936         https://bugs.webkit.org/show_bug.cgi?id=195152
1937
1938         Reviewed by Antti Koivisto.
1939
1940         Added tests for WeakHashSet.
1941
1942         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
1943         (TestWebKitAPI::Base::Base): Moved.
1944         (TestWebKitAPI::Derived::foo): Moved.
1945         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
1946         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
1947         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
1948         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
1949
1950 2019-03-04  Chris Dumez  <cdumez@apple.com>
1951
1952         Do not share WebProcesses between private and regular sessions
1953         https://bugs.webkit.org/show_bug.cgi?id=195189
1954         <rdar://problem/48421064>
1955
1956         Reviewed by Alex Christensen.
1957
1958         Add API test coverage.
1959
1960         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1961         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1962
1963 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
1964
1965         [WPE] Enable web process sandbox
1966         https://bugs.webkit.org/show_bug.cgi?id=195169
1967
1968         Reviewed by Daniel Bates.
1969
1970         * wpe/install-dependencies:
1971         * wpe/jhbuild.modules:
1972
1973 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
1974
1975         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
1976         https://bugs.webkit.org/show_bug.cgi?id=195206
1977
1978         Reviewed by Žan Doberšek.
1979
1980         Add a new test case.
1981
1982         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1983         (testJSCClass):
1984
1985 2019-03-04  Charlie Turner  <cturner@igalia.com>
1986
1987         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
1988         https://bugs.webkit.org/show_bug.cgi?id=194898
1989
1990         Reviewed by Žan Doberšek.
1991
1992         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
1993         a GCC extension that permits arithmetic on void* pointer. Inline
1994         the macro until this issue is fixed upstream.
1995
1996 2019-03-03  Tim Horton  <timothy_horton@apple.com>
1997
1998         Rid the world of WK_API_ENABLED
1999         https://bugs.webkit.org/show_bug.cgi?id=195263
2000
2001         Reviewed by Dan Bernstein.
2002
2003         List of changed files elided because it's useless.
2004
2005 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
2006
2007         Unreviewed follow-up to r242292.
2008
2009         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
2010
2011         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
2012         (TestWebKitAPI::testStrip): Renamed from strip.
2013         (TestWebKitAPI::TEST):
2014
2015 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
2016
2017         Unreviewed, remove accidentally-committed URLHelpers.cpp test
2018
2019         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
2020         and bug #194272 for details.
2021
2022         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
2023
2024 2019-03-03  Tim Horton  <timothy_horton@apple.com>
2025
2026         Remove some more unused 32-bit code
2027         https://bugs.webkit.org/show_bug.cgi?id=195255
2028
2029         Reviewed by Darin Adler.
2030
2031         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2032         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
2033         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2034         (NPP_New):
2035         (NPP_HandleEvent):
2036         (handleEventCarbon): Deleted.
2037
2038 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
2039
2040         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
2041
2042         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
2043         (TestWebKitAPI::TEST):
2044
2045 2019-03-01  Darin Adler  <darin@apple.com>
2046
2047         Finish removing String::format
2048         https://bugs.webkit.org/show_bug.cgi?id=194893
2049
2050         Reviewed by Daniel Bates.
2051 '
2052         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
2053
2054 2019-03-01  Alex Christensen  <achristensen@webkit.org>
2055
2056         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
2057         https://bugs.webkit.org/show_bug.cgi?id=195229
2058         <rdar://problem/48520362>
2059
2060         Reviewed by Chris Dumez.
2061
2062         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2063         (TEST):
2064
2065 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
2066
2067         Add a system trace scope for event region building
2068         https://bugs.webkit.org/show_bug.cgi?id=195226
2069
2070         Reviewed by Jon Lee.
2071
2072         This trace scope measures the time spend converting element rects into Region objects,
2073         which can be large on some pages.
2074
2075         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
2076
2077         * Tracing/SystemTracePoints.plist:
2078
2079 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
2080
2081         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
2082         https://bugs.webkit.org/show_bug.cgi?id=194612
2083
2084         Reviewed by Alex Christensen.
2085
2086         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
2087         Just test the new string-processing function and don't touch the actual environment.
2088         (Test cases are all as before, but based on operator== instead of strcmp.)
2089
2090 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
2091
2092         [ews-app] Update primary keys for handling multiple Buildbot instances
2093         https://bugs.webkit.org/show_bug.cgi?id=195120
2094
2095         Reviewed by Stephanie Lewis.
2096
2097         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
2098         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
2099         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
2100
2101         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
2102         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
2103         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
2104         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
2105         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
2106         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
2107
2108 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
2109
2110         [WinCairo] Enable service worker
2111         https://bugs.webkit.org/show_bug.cgi?id=188318
2112
2113         Reviewed by Youenn Fablet.
2114
2115         * DumpRenderTree/DumpRenderTreePrefix.h:
2116         * TestWebKitAPI/PlatformWin.cmake:
2117         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
2118         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
2119         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
2120
2121 2019-03-01  Justin Fan  <justin_fan@apple.com>
2122
2123         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
2124         https://bugs.webkit.org/show_bug.cgi?id=195191
2125
2126         Rubber-stamped by Dean Jackson.
2127
2128         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
2129
2130         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2131
2132 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
2133
2134         Unreviewed, fix lldb webkitpy tests
2135         https://bugs.webkit.org/show_bug.cgi?id=194375
2136
2137         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
2138
2139         * lldb/lldb_webkit.py:
2140         (WTFStringImplProvider.is_8bit):
2141
2142 2019-02-28  David Quesada  <david_quesada@apple.com>
2143
2144         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
2145         https://bugs.webkit.org/show_bug.cgi?id=195121
2146         rdar://problem/48450302
2147
2148         Reviewed by Alex Christensen.
2149
2150         Add API tests for -WKNavigationAction._shouldPerformDownload in various
2151         configurations where the 'download' attribute is absent, blank, or populated
2152         with a filename, and where the anchor element is same-origin or cross-origin
2153         (meaning the 'download' attribute shouldn't be honored).
2154
2155         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2156         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
2157         (-[NavigationActionTestDelegate init]):
2158         (-[NavigationActionTestDelegate navigationAction]):
2159         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
2160         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
2161         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2162         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
2163         (TEST):
2164
2165 2019-02-28  Antoine Quint  <graouts@apple.com>
2166
2167         Enable the Pointer Events runtime flag by default
2168         https://bugs.webkit.org/show_bug.cgi?id=195156
2169
2170         Reviewed by Dean Jackson.
2171
2172         * DumpRenderTree/mac/DumpRenderTree.mm:
2173         (enableExperimentalFeatures):
2174
2175 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
2176
2177         Several PasteImage API tests are flaky
2178         https://bugs.webkit.org/show_bug.cgi?id=195160
2179
2180         Reviewed by Tim Horton.
2181
2182         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
2183         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
2184         listening for a "load" event after image load is already complete.
2185
2186         To address this, make these tests first register a "load" event handler, then run script to insert an image
2187         element into the document, and finally wait until the load event is observed before checking image size.
2188
2189         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
2190
2191 2019-02-28  Chris Dumez  <cdumez@apple.com>
2192
2193         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
2194         https://bugs.webkit.org/show_bug.cgi?id=195107
2195
2196         Reviewed by Alex Christensen.
2197
2198         Give some time for the zoom level to get restored.
2199
2200         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2201
2202 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
2203
2204         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
2205         https://bugs.webkit.org/show_bug.cgi?id=194958
2206
2207         Reviewed by Geoffrey Garen.
2208
2209         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
2210         (TEST):
2211
2212 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
2213
2214         [ews-app] Update method to save build to handle builder_display_name
2215         https://bugs.webkit.org/show_bug.cgi?id=195047
2216
2217         Reviewed by Dewei Zhu.
2218
2219         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
2220         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
2221
2222 2019-02-28  Justin Fan  <justin_fan@apple.com>
2223
2224         [Web GPU] Enable Web GPU only on 64-bit
2225         https://bugs.webkit.org/show_bug.cgi?id=195139
2226
2227         Because Metal is only supported on 64 bit apps.
2228
2229         Unreviewed build fix.
2230
2231         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2232
2233 2019-02-27  Youenn Fablet  <youenn@apple.com>
2234
2235         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
2236         https://bugs.webkit.org/show_bug.cgi?id=194959
2237
2238         Reviewed by Chris Dumez.
2239
2240         Spin loop until getting the condition to remove flakiness.
2241
2242         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2243
2244 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
2245
2246         [ews-build] Buildbot should include builder_display_name in the build events
2247         https://bugs.webkit.org/show_bug.cgi?id=195045
2248
2249         Reviewed by Dewei Zhu.
2250
2251         * BuildSlaveSupport/ews-build/events.py:
2252         (Events.buildStarted): Included builder_display_name in event data. Also renamed
2253         buildername to builder_name to be consistent in naming style.
2254         (Events.buildFinished): Ditto.
2255
2256 2019-02-27  Chris Dumez  <cdumez@apple.com>
2257
2258         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
2259         https://bugs.webkit.org/show_bug.cgi?id=194480
2260
2261         Reviewed by Brady Eidson.
2262
2263         Update existing API test to make it more likely to reproduce the issue.
2264
2265         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2266
2267 2019-02-27  Brady Eidson  <beidson@apple.com>
2268
2269         Universal links from Google search results pages don't open the app.
2270         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
2271
2272         Reviewed by Geoffrey Garen.
2273
2274         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
2275         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
2276         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
2277         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2278
2279 2019-02-27  Chris Dumez  <cdumez@apple.com>
2280
2281         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
2282         https://bugs.webkit.org/show_bug.cgi?id=195102
2283
2284         Reviewed by Geoffrey Garen.
2285
2286         If the number of processes is not yet what we expect, wait a bit and check again to give
2287         processes some time to exit.
2288
2289         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2290
2291 2019-02-27  Chris Dumez  <cdumez@apple.com>
2292
2293         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
2294         https://bugs.webkit.org/show_bug.cgi?id=194545
2295
2296         Reviewed by Brady Eidson.
2297
2298         Make sure the test navigates forward and then back only once. Previously, navigating
2299         back would trigger a navigation again in a timer.
2300
2301         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2302
2303 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
2304
2305         High Sierra Debug JSC test queue should use faster hardware
2306         https://bugs.webkit.org/show_bug.cgi?id=194603
2307
2308         Rubber-stamped by Alexey Proskuryakov.
2309
2310         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
2311
2312         * BuildSlaveSupport/build.webkit.org-config/config.json:
2313         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2314         (BubbleQueueServer):
2315         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2316         (WebKitBuildbot):
2317         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
2318         * QueueStatusServer/config/queues.py:
2319         * Scripts/webkitpy/common/config/ews.json:
2320         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2321         (test_ews_name):
2322
2323 2019-02-27  John Wilander  <wilander@apple.com>
2324
2325         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
2326         https://bugs.webkit.org/show_bug.cgi?id=195071
2327         <rdar://problem/48417690>
2328
2329         Reviewed by Alex Christensen and Brent Fulgham.
2330
2331         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
2332         (TestWebKitAPI::createURL):
2333             Convenience function.
2334         (TestWebKitAPI::TEST):
2335             WebCore::AdClickAttribution now takes a URL when creating Source and
2336             Destination.
2337         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
2338         (TestWebKitAPI::TEST):
2339             WebCore::AdClickAttribution now takes a URL when creating Source and
2340             Destination.
2341
2342 2019-02-27  Antoine Quint  <graouts@apple.com>
2343
2344         Support Pointer Events on macOS
2345         https://bugs.webkit.org/show_bug.cgi?id=195008
2346         <rdar://problem/47454419>
2347
2348         Reviewed by Dean Jackson.
2349
2350         * DumpRenderTree/mac/DumpRenderTree.mm:
2351         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
2352         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2353
2354 2019-02-26  Mark Lam  <mark.lam@apple.com>
2355
2356         Remove remaining poisoning code.
2357         https://bugs.webkit.org/show_bug.cgi?id=194138
2358
2359         Reviewed by Saam Barati.
2360
2361         * TestWebKitAPI/CMakeLists.txt:
2362         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2363         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
2364         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
2365         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
2366         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
2367         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
2368         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
2369
2370 2019-02-26  Alex Christensen  <achristensen@webkit.org>
2371
2372         Move ephemeral local storage from WebProcess to UIProcess
2373         https://bugs.webkit.org/show_bug.cgi?id=195074
2374         <rdar://problem/47937975>
2375
2376         Reviewed by Geoff Garen.
2377
2378         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2379
2380 2019-02-20  Jer Noble  <jer.noble@apple.com>
2381
2382         [Cocoa] Media elements will restart network buffering just before suspending
2383         https://bugs.webkit.org/show_bug.cgi?id=193691
2384
2385         Reviewed by Eric Carlson.
2386
2387         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2388         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
2389         (TEST):
2390
2391 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
2392
2393         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
2394         https://bugs.webkit.org/show_bug.cgi?id=191652
2395
2396         Reviewed by Alex Christensen.
2397
2398         Fix WinCairo MiniBrowser behavior of authentication dialog.
2399
2400         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2401         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
2402
2403 2019-02-26  Youenn Fablet  <youenn@apple.com>
2404
2405         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
2406         https://bugs.webkit.org/show_bug.cgi?id=195028
2407         <rdar://problem/48243733>
2408
2409         Reviewed by Eric Carlson.
2410
2411         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2412
2413 2019-02-26  Philippe Normand  <pnormand@igalia.com>
2414
2415         [WPE] Add API for webview background color configuration
2416         https://bugs.webkit.org/show_bug.cgi?id=192305
2417
2418         Reviewed by Michael Catanzaro.
2419
2420         * MiniBrowser/wpe/main.cpp:
2421         (main): Add a new option to configure the webview background
2422         color. Example: --bg-color=transparent.
2423         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
2424         (testWebViewBackgroundColor): Enable background color API tests for WPE.
2425         (beforeAll): Ditto.
2426
2427 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
2428
2429         scalableNativeWebpageParameters() is not preserved on new page navigation.
2430         https://bugs.webkit.org/show_bug.cgi?id=194892
2431         <rdar://problem/47538280>
2432
2433         Reviewed by Wenson Hsieh.
2434         
2435         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
2436
2437         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2438         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
2439         * DumpRenderTree/mac/UIScriptControllerMac.mm:
2440         (WTR::UIScriptController::allowsViewportShrinkToFit):
2441         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2442         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2443         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
2444         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2445         * WebKitTestRunner/UIScriptControllerCocoa.mm:
2446         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
2447
2448 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
2449
2450         [ews-app] Add model for handling multiple Buildbot instances
2451         https://bugs.webkit.org/show_bug.cgi?id=194863
2452
2453         Reviewed by Stephanie Lewis.
2454
2455         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
2456
2457 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
2458
2459         [ews-app] Remove BuilderMapping table
2460         https://bugs.webkit.org/show_bug.cgi?id=194961
2461
2462         Reviewed by Stephanie Lewis.
2463
2464         Store builder name directly in build table, instead of having a separate
2465         table for it.
2466
2467         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
2468         * BuildSlaveSupport/ews-app/ews/models/build.py:
2469         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
2470         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2471
2472 2019-02-25  John Wilander  <wilander@apple.com>
2473
2474         Introduce and adopt new class RegistrableDomain for eTLD+1
2475         https://bugs.webkit.org/show_bug.cgi?id=194791
2476         <rdar://problem/48179240>
2477
2478         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
2479
2480         This patch adds an API test and replaces two instances of
2481         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
2482
2483         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2484         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
2485         (TestWebKitAPI::TEST):
2486             Changed two strings to make sure the registrable domains are still considered
2487             invalid and pass the test.
2488         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
2489         (TestWebKitAPI::TEST):
2490         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2491         (WTR::InjectedBundle::didReceiveMessageToPage):
2492
2493 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
2494
2495         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
2496         https://bugs.webkit.org/show_bug.cgi?id=195001
2497
2498         Reviewed by Carlos Garcia Campos.
2499
2500         API version 1.0 always includes the functionality previously guarded with
2501         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
2502         unconditionally.
2503
2504         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
2505         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
2506         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
2507         (WebViewTest::showInWindow): Ditto.
2508         (WebViewTest::hideView): Ditto.
2509         * wpe/backends/HeadlessViewBackend.cpp:
2510         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
2511         * wpe/backends/ViewBackend.cpp:
2512         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
2513         * wpe/backends/WindowViewBackend.cpp:
2514         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
2515         WPE_BACKEND_CHECK_VERSION().
2516         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
2517
2518 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
2519
2520         [Flatpak] Add support for flatpak > 1.1.2
2521         https://bugs.webkit.org/show_bug.cgi?id=194088
2522
2523         Flatpak 1.2 is now out so we need to support that
2524         version now.
2525
2526         Reviewed by Michael Catanzaro.
2527
2528         * flatpak/flatpakutils.py:
2529         (check_flatpak):
2530         (FlatpakPackages.__init__):
2531         (FlatpakPackages.__detect_packages):
2532         (FlatpakPackages.__detect_packages.in):
2533         (FlatpakRepos.update):
2534
2535 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
2536
2537         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
2538         https://bugs.webkit.org/show_bug.cgi?id=194998
2539
2540         Reviewed by Carlos Garcia Campos.
2541
2542         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
2543         to a Git checkout and using the latest commit containing various fixes
2544         and improvements.
2545
2546 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
2547
2548         [WPE][GTK] Remove user agent quirk for washingtonpost.com
2549         https://bugs.webkit.org/show_bug.cgi?id=194981
2550
2551         Reviewed by Žan Doberšek.
2552
2553         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
2554         (TestWebKitAPI::TEST):
2555
2556 2019-02-23  Keith Miller  <keith_miller@apple.com>
2557
2558         Add new mac target numbers
2559         https://bugs.webkit.org/show_bug.cgi?id=194955
2560
2561         Reviewed by Tim Horton.
2562
2563         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2564         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2565         * MiniBrowser/Configurations/Base.xcconfig:
2566         * TestWebKitAPI/Configurations/Base.xcconfig:
2567         * WebKitTestRunner/Configurations/Base.xcconfig:
2568
2569 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
2570
2571         [WinCairo] Enable wk1/wk2 suffix for platform search path.
2572         https://bugs.webkit.org/show_bug.cgi?id=194846
2573
2574         Reviewed by Don Olmstead.
2575
2576         Added _search_paths() and _port_specific_expectations_files() for
2577         WinCairoPort.
2578
2579         * Scripts/webkitpy/port/win.py:
2580         (WinCairoPort.default_baseline_search_path):
2581         (WinCairoPort):
2582         (WinCairoPort._port_specific_expectations_files):
2583         (WinCairoPort._search_paths):
2584
2585 2019-02-22  Tim Horton  <timothy_horton@apple.com>
2586
2587         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
2588         https://bugs.webkit.org/show_bug.cgi?id=194963
2589
2590         Reviewed by Dean Jackson.
2591
2592         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2593         Do a `contains` check instead of `equals`, because in debug builds we
2594         put the GraphicsLayer pointer in a prefix.
2595
2596 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2597
2598         [iOS] Callout menu overlaps in-page controls when editing a comment in github.com's issue tracker
2599         https://bugs.webkit.org/show_bug.cgi?id=194873
2600         <rdar://problem/46701974>
2601
2602         Reviewed by Tim Horton.
2603
2604         Add a couple of UIScriptController methods to make callout menu testing on iOS easier (see below).
2605
2606         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2607         (WTR::UIScriptController::menuRect const):
2608         (WTR::UIScriptController::isShowingMenu const):
2609         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2610         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2611         (WTR::UIScriptController::menuRect const):
2612
2613         Add a function to query the bounds of the callout menu in content coordinates.
2614
2615         (WTR::UIScriptController::isShowingMenu const):
2616
2617         Add a function to query whether the callout menu is shown (i.e., has finished its appearance animation).
2618
2619         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2620         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2621         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2622         (WTR::UIScriptController::rectForMenuAction const):
2623         (WTR::UIScriptController::menuRect const):
2624         (WTR::UIScriptController::isShowingMenu const):
2625         (WTR::findViewInHierarchyOfType): Deleted.
2626
2627 2019-02-22  Chris Dumez  <cdumez@apple.com>
2628
2629         Regression(PSON) Unable to preview password-protected documents on iCloud.com
2630         https://bugs.webkit.org/show_bug.cgi?id=194954
2631         <rdar://problem/48127957>
2632
2633         Reviewed by Alex Christensen.
2634
2635         Add API test coverage.
2636
2637         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2638         (-[PSONNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
2639         (-[PSONNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
2640         (-[PSONNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
2641
2642 2019-02-22  Chris Dumez  <cdumez@apple.com>
2643
2644         REGRESSION(PSON) Scroll position is sometimes not restored on history navigation
2645         https://bugs.webkit.org/show_bug.cgi?id=194924
2646         <rdar://problem/48216125>
2647
2648         Reviewed by Geoffrey Garen.
2649
2650         Add API test coverage.
2651
2652         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2653
2654 2019-02-22  Chris Dumez  <cdumez@apple.com>
2655
2656         Unreviewed, disable API test added in r241928 on iOS.
2657
2658         The cache is not enabled on devices with less than 3GB of RAM.
2659
2660         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2661
2662 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
2663
2664         Hardcode Visual Viewports on everywhere except iOS WK1
2665         https://bugs.webkit.org/show_bug.cgi?id=194928
2666
2667         Reviewed by Zalan Bujtas.
2668
2669         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
2670         change the default value of the Setting to 'true', and hardcode WebView on iOS to
2671         set it to false. The setting has shipped for several years and there's no need to turn
2672         it off now.
2673
2674         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
2675         Visual Viewports are not enabled.
2676         
2677         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
2678         that only runs in WK2
2679
2680         * MiniBrowser/mac/SettingsController.h:
2681         * MiniBrowser/mac/SettingsController.m:
2682         (-[SettingsController init]):
2683         (-[SettingsController _populateMenu]):
2684         (-[SettingsController validateMenuItem:]):
2685         (-[SettingsController visualViewportEnabled]): Deleted.
2686         (-[SettingsController toggleVisualViewportEnabled:]): Deleted.
2687         * MiniBrowser/mac/WK1BrowserWindowController.m:
2688         (-[WK1BrowserWindowController didChangeSettings]):
2689         * MiniBrowser/mac/WK2BrowserWindowController.m:
2690         (-[WK2BrowserWindowController didChangeSettings]):
2691
2692 2019-02-21  Ryosuke Niwa  <rniwa@webkit.org>
2693
2694         Discard cached processes when clearing website data store
2695         https://bugs.webkit.org/show_bug.cgi?id=194894
2696
2697         Reviewed by Chris Dumez.
2698
2699         Added a test case.
2700
2701         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2702         (TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses): Added.
2703
2704 2019-02-21  Alex Christensen  <achristensen@webkit.org>
2705
2706         Clicking "Go Back" on a safe browsing warning before a WKWebView has loaded any page should request to close the WKWebView
2707         https://bugs.webkit.org/show_bug.cgi?id=194914
2708         <rdar://problem/47586889>
2709
2710         Reviewed by Geoffrey Garen.
2711
2712         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2713         (-[SafeBrowsingNavigationDelegate webViewDidClose:]):
2714         (TEST):
2715         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]): Deleted.
2716
2717 2019-02-21  David Kilzer  <ddkilzer@apple.com>
2718
2719         Leak of CFErrorRef objects (1.92 Kbytes) in com.apple.WebKit.WebContent.Development running WebKit layout tests on iOS Simulator
2720         <https://webkit.org/b/194761>
2721
2722         Reviewed by Myles Maxfield.
2723
2724         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
2725         (WTR::activateSystemCoreWebFonts): Log `error` to console if
2726         CTFontManagerRegisterFontsForURL() fails (macOS only).  Update
2727         to use ARC-compliant cast.
2728         (WTR::activateFonts): Change `0` to `nullptr`.  Update to use
2729         ARC-compliant cast.
2730         (WTR::installFakeHelvetica): Log `error` to console if
2731         CTFontManagerRegisterFontsForURL() fails, but only on supported
2732         platforms (macOS Mojave/iOS 12 and newer, not iOS Simulator).
2733         Call CFRelease() on `error` to fix the leak.  Update to use
2734         ARC-compliant cast.
2735         (WTR::uninstallFakeHelvetica): Update to use ARC-compliant
2736         cast.
2737
2738 2019-02-21  Chris Dumez  <cdumez@apple.com>
2739
2740         Flaky API Test: TestWebKitAPI.ProcessSwap.SuspendedPageLimit
2741         https://bugs.webkit.org/show_bug.cgi?id=194481
2742
2743         Reviewed by Alex Christensen.
2744
2745         Give the processes a chance to shutdown and wait until we reached the expected number
2746         of processes.
2747
2748         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2749
2750 2019-02-21  Tim Horton  <timothy_horton@apple.com>
2751
2752         Fix the macOS build
2753
2754         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2755
2756 2019-02-21  Tim Horton  <timothy_horton@apple.com>
2757
2758         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
2759
2760         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2761         I am a backwards.
2762
2763 2019-02-21  Tim Horton  <timothy_horton@apple.com>
2764
2765         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
2766
2767         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2768         We can't find the UI-side layer on macOS because we don't use UI-side compositing.
2769         We could force on UI-side compositing, but I feel like the test might be more
2770         valuable exercising the normal path on each platform (though the original
2771         bug was also UI-side specific). Though we can't validate that the overlay
2772         layer was installed successfully, there are layout tests that do that.
2773
2774 2019-02-21  Tim Horton  <timothy_horton@apple.com>
2775
2776         Crash under RemoteLayerTreePropertyApplier::applyProperties when reattaching to old process
2777         https://bugs.webkit.org/show_bug.cgi?id=194845
2778         <rdar://problem/47944579>
2779
2780         Reviewed by Antti Koivisto.
2781
2782         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2783         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2784
2785 2019-02-21  Zalan Bujtas  <zalan@apple.com>
2786
2787         [LFC][Floats] Add support for placing formatting roots in-between floats.
2788         https://bugs.webkit.org/show_bug.cgi?id=194902
2789
2790         Reviewed by Antti Koivisto.
2791
2792         * LayoutReloaded/misc/LFC-passing-tests.txt:
2793
2794 2019-02-21  Adrian Perez de Castro  <aperez@igalia.com>
2795
2796         [WPE] Do not hardcode WPEBackend-fdo library name for linking tests
2797         https://bugs.webkit.org/show_bug.cgi?id=194901
2798
2799         Unreviewed build fix.
2800
2801         * TestWebKitAPI/PlatformWPE.cmake: Set TestWebKitAPIBase to be linked
2802         against the detected ${WPEBACKEND_FDO_LIBRARIES} instead of hardcoding
2803         WPEBackend-fdo-0.1 as library name.
2804
2805 2019-02-21  Rob Buis  <rbuis@igalia.com>
2806
2807         Update MIME type parser
2808         https://bugs.webkit.org/show_bug.cgi?id=180526
2809
2810         Reviewed by Darin Adler.
2811
2812         Add tests involving leading and trailing whitespace, non-token
2813         characters and quoted strings.
2814
2815         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
2816         (TestWebKitAPI::TEST):
2817
2818 2019-02-20  Don Olmstead  <don.olmstead@sony.com>
2819
2820         [CMake][Win] Only build DumpRenderTree when WebKit Legacy is enabled
2821         https://bugs.webkit.org/show_bug.cgi?id=194884
2822
2823         Reviewed by Michael Catanzaro.
2824
2825         * PlatformWin.cmake:
2826
2827 2019-02-20  Chris Dumez  <cdumez@apple.com>
2828
2829         Add API test for <rdar://problem/47471222>
2830         https://bugs.webkit.org/show_bug.cgi?id=194847
2831
2832         Reviewed by Alex Christensen.
2833
2834         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2835
2836 2019-02-20  Chris Dumez  <cdumez@apple.com>
2837
2838         Regression(PSON) "Reload without content extensions" does not work when the main resource is blocked
2839         https://bugs.webkit.org/show_bug.cgi?id=194872
2840         <rdar://problem/47924500>
2841
2842         Reviewed by Alex Christensen.
2843
2844         Add API test coverage.
2845
2846         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2847
2848 2019-02-20  Jer Noble  <jer.noble@apple.com>
2849
2850         Add a git utility method that allows the caller to determine if a specific commitish is within a specified range of commits.
2851         https://bugs.webkit.org/show_bug.cgi?id=191332
2852
2853         Reviewed by Dean Jackson.
2854
2855         * Scripts/git-is-in-range: Added.
2856
2857 2019-02-20  Andy Estes  <aestes@apple.com>
2858
2859         [Xcode] Add SDKVariant.xcconfig to various Xcode projects
2860         https://bugs.webkit.org/show_bug.cgi?id=194869
2861
2862         Rubber-stamped by Jer Noble.
2863
2864         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2865         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
2866         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
2867         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
2868         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2869         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2870
2871 2019-02-20  Chris Dumez  <cdumez@apple.com>
2872
2873         Regression(PSON) Crash under WebKit::WebPageProxy::decidePolicyForNavigationActionSync
2874         https://bugs.webkit.org/show_bug.cgi?id=194857
2875         <rdar://problem/47759323>
2876
2877         Reviewed by Alex Christensen.
2878
2879         Add API test coverage.
2880
2881         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2882
2883 2019-02-20  Chris Dumez  <cdumez@apple.com>
2884
2885         [WKTR] Avoid starting new NetworkProcesses unnecessarily when running the layout tests
2886         https://bugs.webkit.org/show_bug.cgi?id=194829
2887         <rdar://problem/47889906>
2888
2889         Reviewed by Alexey Proskuryakov.
2890
2891         Every time the TestOptions were changing we were creating both a new Web view and
2892         a new WKContext, which would start a new Network process. In most cases, we only
2893         need to contruct a new Web view and we do can keep reusing the same WKContext.
2894         This patch implements this optimization and thus avoids spinning a lot of new
2895         Network processes while running the layout tests.
2896
2897         * WebKitTestRunner/TestController.cpp:
2898         (WTR::TestController::generateContextConfiguration const):
2899         (WTR::TestController::generatePageConfiguration):
2900         (WTR::TestController::createWebViewWithOptions):
2901         (WTR::TestController::resetPreferencesToConsistentValues):
2902         (WTR::updateTestOptionsFromTestHeader):
2903         * WebKitTestRunner/TestController.h:
2904         * WebKitTestRunner/TestOptions.h:
2905         (WTR::TestOptions::ContextOptions::hasSameInitializationOptions const):
2906         (WTR::TestOptions::ContextOptions::shouldEnableProcessSwapOnNavigation const):
2907         (WTR::TestOptions::hasSameInitializationOptions const):
2908         (WTR::TestOptions::shouldEnableProcessSwapOnNavigation const): Deleted.
2909         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2910         (WTR::TestController::platformAddTestOptions const):
2911
2912 2019-02-20  Adrian Perez de Castro  <aperez@igalia.com>
2913
2914         [WPE][GTK] Enable support for CONTENT_EXTENSIONS
2915         https://bugs.webkit.org/show_bug.cgi?id=167941
2916
2917         Reviewed by Carlos Garcia Campos.
2918
2919         * MiniBrowser/gtk/main.c:
2920         (filterSavedCallback): Added.
2921         (main): Support loading a JSON rule set file for content filtering.
2922         * MiniBrowser/wpe/main.cpp:
2923         (filterSavedCallback): Added.
2924         (main): Support loading a JSON rule set file for content filtering.
2925         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentFilterStore.cpp: Added.
2926         (WTF::refGPtr): Added locally for WebKitUserContentFilter, as it would not be used anywhere else.
2927         (WTF::derefGPtr): Ditto.
2928         (testEmptyStore):
2929         (testSaveInvalidFilter):
2930         (testSaveLoadFilter):
2931         (testSavedFilterIdentifierMatch):
2932         (testRemoveFilter):
2933         (testSaveMultipleFilters):
2934         (testSaveFilterFromFile):
2935         (testFilterPersistence):
2936         (beforeAll):
2937         (afterAll):
2938         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
2939         (removeOldInjectedContentAndResetLists): Also reset content filters.
2940         (isCSSBlockedForURLAtPath): Added. Tests whether the test filter, which blocks a
2941         CSS style sheet, has blocked the load of the CSS by looking at the resulting style of
2942         the element affected by the style sheet.
2943         (getUserContentFilter): Added. Stores the test filter in a WebKitUserContentFilterStore
2944         and returns it to be used by tests.
2945         (testUserContentManagerContentFilter): Added. Tests whether adding and removing a filter
2946         from the WebKitUserContentManager results in the a CSS style sheet being blocked.
2947         (serverCallback): Add support for serving a CSS style sheet for testing.
2948         (beforeAll): Add call to testUserContentManagerContentFilter().
2949         * TestWebKitAPI/glib/CMakeLists.txt: Added TestWebKitUserContentFilterStore.
2950
2951 2019-02-19  Keith Rollin  <krollin@apple.com>
2952
2953         Add timing information to build output
2954         https://bugs.webkit.org/show_bug.cgi?id=194839
2955         <rdar://problem/48219609>
2956
2957         Reviewed by Alexey Proskuryakov.
2958
2959         Configure xcodebuild with -ShowBuildOperationDuration, causing it to
2960         emit each project's build time to its output. E.g.,
2961
2962             ** BUILD SUCCEEDED ** [0.132 sec]
2963
2964         * Scripts/webkitdirs.pm:
2965         (XcodeOptions):
2966
2967 2019-02-19  Truitt Savell  <tsavell@apple.com>
2968
2969         Unreviewed, rolling out r241784.
2970
2971         Broke all OpenSource builds.
2972
2973         Reverted changeset:
2974
2975         "Web Inspector: Improve ES6 Class instances in Heap Snapshot
2976         instances view"
2977         https://bugs.webkit.org/show_bug.cgi?id=172848
2978         https://trac.webkit.org/changeset/241784
2979
2980 2019-02-19  Zalan Bujtas  <zalan@apple.com>
2981
2982         [LFC][Floats] Remove redundant intersecting logic
2983         https://bugs.webkit.org/show_bug.cgi?id=194804
2984
2985         Reviewed by Antti Koivisto.
2986
2987         * LayoutReloaded/misc/LFC-passing-tests.txt:
2988
2989 2019-02-19  Dean Jackson  <dino@apple.com>
2990
2991         Clean-up output from generate-xcfilelists so it can be filtered
2992         https://bugs.webkit.org/show_bug.cgi?id=194795
2993
2994         Reviewed by Joseph Pecoraro (and Keith Rollin).
2995
2996         Replace the "..." with "GXCF:" in generate-xcfilelists output, and
2997         make a slight tweak to filter-build-webkit so such lines are marked
2998         as plain.
2999
3000         * Scripts/filter-build-webkit:
3001         * Scripts/generate-xcfilelists:
3002
3003 2019-02-19  Pablo Saavedra  <psaavedra@igalia.com>
3004
3005         pytest is not correctly auto-installed
3006         https://bugs.webkit.org/show_bug.cgi?id=194707
3007
3008         Reviewed by Carlos Garcia Campos.
3009
3010         * Scripts/webkitpy/thirdparty/__init__.py:
3011         (AutoinstallImportHook._install_pytest):
3012
3013 2019-02-18  Chris Dumez  <cdumez@apple.com>
3014
3015         REGRESSION (PSON): Can't access optumbank.com from myuhc.com
3016         https://bugs.webkit.org/show_bug.cgi?id=194797
3017         <rdar://problem/48055151>
3018
3019         Reviewed by Geoffrey Garen.
3020
3021         Add API test coverage.
3022
3023         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3024
3025 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
3026
3027         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
3028         https://bugs.webkit.org/show_bug.cgi?id=194670
3029         <rdar://problem/39066529>
3030
3031         Reviewed by Tim Horton.
3032
3033         Remove code and tests for subresource URL replacement, and also add a new test to verify that copied data can be
3034         pasted in an editable area as attachment elements.
3035
3036         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
3037         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
3038         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]): Deleted.
3039         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3040         (TestWebKitAPI::TEST):
3041         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3042         (WTR::InjectedBundlePage::InjectedBundlePage):
3043
3044 2019-02-18  Alex Christensen  <achristensen@webkit.org>
3045
3046         Fix API test after r241728
3047        ​https://bugs.webkit.org/show_bug.cgi?id=194723
3048
3049         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3050         (TEST):
3051         The test should check the default preference value, not make sure the preference is NO after setting it to YES :/
3052
3053 2019-02-18  Daniel Bates  <dabates@apple.com>
3054
3055         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
3056         https://bugs.webkit.org/show_bug.cgi?id=192824
3057         <rdar://problem/47100332>
3058
3059         Reviewed by Wenson Hsieh.
3060
3061         Fix a bug where the wrong usage code was used for F13 thru F24.
3062
3063         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3064         (keyCodeForDOMFunctionKey):
3065
3066 2019-02-18  Tadeu Zagallo  <tzagallo@apple.com>
3067
3068         Bytecode cache should a have a boot-specific validation
3069         https://bugs.webkit.org/show_bug.cgi?id=194769
3070         <rdar://problem/48149509>
3071
3072         Reviewed by Keith Miller.
3073
3074         Add test for WTF::bootSessionUUIDString()
3075
3076         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3077         * TestWebKitAPI/Tests/WTF/UUID.cpp: Added.
3078         (TEST):
3079
3080 2019-02-18  Alex Christensen  <achristensen@webkit.org>
3081
3082         Disable safe browsing in WKWebView and remove its WKPreferences API
3083         https://bugs.webkit.org/show_bug.cgi?id=194723
3084         <rdar://problem/48122993>
3085
3086         Reviewed by Geoffrey Garen.
3087
3088         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3089         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3090         (TEST):
3091         (safeBrowsingView):
3092         Make tests use SPI instead of API.
3093
3094 2019-02-17  Fujii Hironori  <Hironori.Fujii@sony.com>
3095
3096         Use dumpJSConsoleLogInStdErr=true webkit-test-runner option for non-imported tests instead of using DumpJSConsoleLogInStdErr expectation in TestExpectations
3097         https://bugs.webkit.org/show_bug.cgi?id=194586
3098
3099         Reviewed by Ross Kirsling.
3100
3101         * DumpRenderTree/win/DumpRenderTree.cpp:
3102         (runTest): Pass true to setDumpJSConsoleLogInStdErr if options.dumpJSConsoleLogInStdErr is true.
3103         * Scripts/webkitpy/port/driver.py:
3104         (Driver._command_from_driver_input): Convert Cygwin absolute path of tests to Windows path.
3105
3106 2019-02-17  David Kilzer  <ddkilzer@apple.com>
3107
3108         Unreviewed, rolling out r241620.
3109
3110         "Causes use-after-free crashes running layout tests with ASan and GuardMalloc."
3111         (Requested by ddkilzer on #webkit.)
3112
3113         Reverted changeset:
3114
3115         "[WTF] Add environment variable helpers"
3116         https://bugs.webkit.org/show_bug.cgi?id=192405
3117         https://trac.webkit.org/changeset/241620
3118
3119 2019-02-16  Zalan Bujtas  <zalan@apple.com>
3120
3121         [LFC] RenderImage's default intrinsic size is 0.
3122         https://bugs.webkit.org/show_bug.cgi?id=194745
3123
3124         Reviewed by Antti Koivisto.
3125
3126         * LayoutReloaded/misc/LFC-passing-tests.txt:
3127
3128 2019-02-16  Zalan Bujtas  <zalan@apple.com>
3129
3130         [LFC][BFC] Add support for block replaced intrinsic width.
3131         https://bugs.webkit.org/show_bug.cgi?id=194705
3132
3133         Reviewed by Simon Fraser.
3134
3135         * LayoutReloaded/misc/LFC-passing-tests.txt:
3136
3137 2019-02-16  Zalan Bujtas  <zalan@apple.com>
3138
3139         [LFC] Apply min/max width constraints to preferred width computation
3140         https://bugs.webkit.org/show_bug.cgi?id=194739
3141
3142         Reviewed by Simon Fraser.
3143
3144         * LayoutReloaded/misc/LFC-passing-tests.txt:
3145
3146 2019-02-15  Ross Kirsling  <ross.kirsling@sony.com>
3147
3148         [WTF] Add environment variable helpers
3149         https://bugs.webkit.org/show_bug.cgi?id=192405
3150
3151         Reviewed by Michael Catanzaro.
3152
3153         * DumpRenderTree/mac/DumpRenderTree.mm:
3154         (libraryPathForDumpRenderTree):
3155         * DumpRenderTree/win/DumpRenderTree.cpp:
3156         (libraryPathForDumpRenderTree):
3157         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
3158         (setUpIOSLayoutTestCommunication):
3159         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
3160         (beforeAll):
3161         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
3162         (main):
3163         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
3164         (WebKitTestBus::run):
3165         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
3166         (WTR::getOutputDir):
3167         (WTR::initializeFontConfigSetting):
3168         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
3169         (WTR::InjectedBundle::platformInitialize):
3170         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
3171         (WTR::topLevelPath):
3172         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
3173         (WTR::topLevelPath):
3174         (WTR::getOutputDir):
3175         (WTR::activateFonts):
3176         * WebKitTestRunner/TestController.cpp:
3177         (WTR::TestController::libraryPathForTesting):
3178         (WTR::TestController::generateContextConfiguration const):
3179         (WTR::TestController::generatePageConfiguration):
3180         (WTR::TestController::decideDestinationWithSuggestedFilename):
3181         (WTR::TestController::platformAdjustContext):
3182         * WebKitTestRunner/TestController.h:
3183         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3184         (WTR::TestController::cocoaPlatformInitialize):
3185         (WTR::TestController::platformAdjustContext):
3186         * WebKitTestRunner/gtk/main.cpp:
3187         (main):
3188         * WebKitTestRunner/mac/TestControllerMac.mm:
3189         (WTR::TestController::configureContentExtensionForTest):
3190         * WebKitTestRunner/wpe/main.cpp:
3191         (main):
3192         Utilize WTF::Environment where possible.
3193
3194 2019-02-15  Wenson Hsieh  <wenson_hsieh@apple.com>
3195
3196         [iOS] WKWebView callout bar is missing Change Writing Direction item
3197         https://bugs.webkit.org/show_bug.cgi?id=190015
3198         <rdar://problem/44810366>
3199
3200         Reviewed by Tim Horton.
3201
3202         Make an existing API test that exercises platform SPI to change the inline text writing direction run only on
3203         macOS, and add a new API test that uses similarly named SPI on iOS to change the base writing direction.
3204
3205         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
3206         (TestWebKitAPI::TEST):
3207
3208 2019-02-15  Chris Dumez  <cdumez@apple.com>
3209
3210         Regression(PSON) Navigating quickly back and forth can lead to getting 'about:blank' in the backforward list
3211         https://bugs.webkit.org/show_bug.cgi?id=194717
3212         <rdar://problem/47884404>
3213
3214         Reviewed by Brady Eidson.
3215
3216         Add API test coverage.
3217
3218         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3219
3220 2019-02-15  Youenn Fablet  <youenn@apple.com>
3221
3222         Make navigator.mediaDevices SecureContext
3223         https://bugs.webkit.org/show_bug.cgi?id=194666
3224
3225         Reviewed by Eric Carlson.
3226
3227         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
3228         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
3229         (TEST_F):
3230
3231 2019-02-15  Brian Burg  <bburg@apple.com>
3232
3233         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
3234         https://bugs.webkit.org/show_bug.cgi?id=194411
3235         <rdar://problem/47787614>
3236
3237         Reviewed by Joseph Pecoraro.
3238
3239         Remove unnecessary soft linking macro usage.
3240
3241         * DumpRenderTree/mac/TestRunnerMac.mm:
3242         (TestRunner::inspectorTestStubURL):
3243         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
3244         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
3245         (WTR::TestRunner::inspectorTestStubURL):
3246
3247 2019-02-15  Commit Queue  <commit-queue@webkit.org>
3248
3249         Unreviewed, rolling out r241559 and r241566.
3250         https://bugs.webkit.org/show_bug.cgi?id=194710
3251
3252         Causes layout test crashes under GuardMalloc (Requested by
3253         ryanhaddad on #webkit).
3254
3255         Reverted changesets:
3256
3257         "[WTF] Add environment variable helpers"
3258         https://bugs.webkit.org/show_bug.cgi?id=192405
3259         https://trac.webkit.org/changeset/241559
3260
3261         "Unreviewed build fix for WinCairo Debug after r241559."
3262         https://trac.webkit.org/changeset/241566
3263
3264 2019-02-15  Zalan Bujtas  <zalan@apple.com>
3265
3266         [LFC] Out-of-flow box is never a float box
3267         https://bugs.webkit.org/show_bug.cgi?id=194704
3268
3269         Reviewed by Antti Koivisto.
3270
3271         * LayoutReloaded/misc/LFC-passing-tests.txt:
3272
3273 2019-02-10  Darin Adler  <darin@apple.com>
3274
3275         Replace more uses of String::format with StringConcatenate (mostly non-Apple platform-specific cases)
3276         https://bugs.webkit.org/show_bug.cgi?id=194487
3277
3278         Reviewed by Daniel Bates.
3279
3280         * DumpRenderTree/win/DumpRenderTree.cpp:
3281         (applicationId): Use makeString instead of String::format.
3282         (main): Ditto.
3283         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3284         (TestWebKitAPI::Util::createURLForResource): Ditto.
3285         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
3286         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Ditto.
3287
3288         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3289         (WTR::attributeSetToString): Use StringBuilder functions directly instead of g_strconcat.
3290         (WTR::attributesOfElement): Use StringBuilder functions directly instead of String::format.
3291         (WTR::createStringWithAttributes): Use appendLiteral.
3292         (WTR::AccessibilityUIElement::helpText const): Ditto.
3293         (WTR::AccessibilityUIElement::attributedStringForRange): Use StringBuilder functions
3294         directly instead of using String::format.
3295         (WTR::AccessibilityUIElement::url): Use makeString instead of String::format.
3296         (WTR::stringAtOffset): Use StringBuilder::appendNumber instead of String::format.
3297
3298 2019-02-15  Truitt Savell  <tsavell@apple.com>
3299
3300         Unreviewed, rolling out r241564.
3301
3302         Caused 50+ Timeouts on Mac WK2, mostly in the http/ directory
3303
3304         Reverted changeset:
3305
3306         "[Mac] WebInspectorUI.framework does not need to be soft-
3307         linked anymore"
3308         https://bugs.webkit.org/show_bug.cgi?id=194411
3309         https://trac.webkit.org/changeset/241564
3310
3311 2019-02-15  Saam barati  <sbarati@apple.com>
3312
3313         [WebAssembly] Write a new register allocator for Air O0 and make BBQ use it
3314         https://bugs.webkit.org/show_bug.cgi?id=194036
3315
3316         Reviewed by Yusuke Suzuki.
3317
3318         * Scripts/run-jsc-stress-tests:
3319
3320 2019-02-14  Tim Horton  <timothy_horton@apple.com>
3321
3322         Fix the build.
3323
3324         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3325         (WTR::UIScriptController::drawSquareInEditableImage):
3326         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3327         (TestWebKitAPI::drawSquareInEditableImage):
3328
3329 2019-02-14  Tim Horton  <timothy_horton@apple.com>
3330
3331         Fix the build.
3332
3333         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3334         (WTR::UIScriptController::drawSquareInEditableImage):
3335         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3336         (TestWebKitAPI::drawSquareInEditableImage):
3337
3338 2019-02-14  Brian Burg  <bburg@apple.com>
3339
3340         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
3341         https://bugs.webkit.org/show_bug.cgi?id=194411
3342         <rdar://problem/47787614>
3343
3344         Reviewed by Joseph Pecoraro.
3345
3346         Remove unnecessary soft linking macro usage.
3347
3348         * DumpRenderTree/mac/TestRunnerMac.mm:
3349         (TestRunner::inspectorTestStubURL):
3350         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
3351         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
3352         (WTR::TestRunner::inspectorTestStubURL):
3353
3354 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
3355
3356         [ews-app] status bubble should fetch builder name info from BuilderMapping table
3357         https://bugs.webkit.org/show_bug.cgi?id=194599
3358
3359         Reviewed by Lucas Forschler.
3360
3361         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3362         (StatusBubble._build_bubble):
3363
3364 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
3365
3366         [ews-app] Set Foreign Key in Django build model
3367         https://bugs.webkit.org/show_bug.cgi?id=194667
3368
3369         Reviewed by Lucas Forschler.
3370
3371         * BuildSlaveSupport/ews-app/ews/models/build.py:
3372         (Build):
3373
3374 2019-02-14  Ross Kirsling  <ross.kirsling@sony.com>
3375
3376         [WTF] Add environment variable helpers
3377         https://bugs.webkit.org/show_bug.cgi?id=192405
3378
3379         Reviewed by Michael Catanzaro.
3380
3381         * DumpRenderTree/mac/DumpRenderTree.mm:
3382         (libraryPathForDumpRenderTree):
3383         * DumpRenderTree/win/DumpRenderTree.cpp:
3384         (libraryPathForDumpRenderTree):
3385         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
3386         (setUpIOSLayoutTestCommunication):
3387         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3388         (TestWebKitAPI::strip):
3389         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
3390         (beforeAll):
3391         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
3392         (main):
3393         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
3394         (WebKitTestBus::run):
3395         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
3396         (WTR::getOutputDir):
3397         (WTR::initializeFontConfigSetting):
3398         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
3399         (WTR::InjectedBundle::platformInitialize):
3400         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
3401         (WTR::topLevelPath):
3402         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
3403         (WTR::topLevelPath):
3404         (WTR::getOutputDir):
3405         (WTR::activateFonts):
3406         * WebKitTestRunner/TestController.cpp:
3407         (WTR::TestController::libraryPathForTesting):
3408         (WTR::TestController::generateContextConfiguration const):
3409         (WTR::TestController::generatePageConfiguration):
3410         (WTR::TestController::decideDestinationWithSuggestedFilename):
3411         (WTR::TestController::platformAdjustContext):
3412         * WebKitTestRunner/TestController.h:
3413         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3414         (WTR::TestController::cocoaPlatformInitialize):
3415         (WTR::TestController::platformAdjustContext):
3416         * WebKitTestRunner/gtk/main.cpp:
3417         (main):
3418         * WebKitTestRunner/mac/TestControllerMac.mm:
3419         (WTR::TestController::configureContentExtensionForTest):
3420         * WebKitTestRunner/wpe/main.cpp:
3421         (main):
3422         Utilize WTF::Environment where possible.
3423
3424 2019-02-14  Chris Dumez  <cdumez@apple.com>
3425
3426         [PSON] Introduce a WebContent Process cache
3427         https://bugs.webkit.org/show_bug.cgi?id=194594
3428         <rdar://problem/46793397>
3429
3430         Reviewed by Geoff Garen.
3431
3432         Update API tests to turn on the WebContent Process cache.
3433
3434         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3435
3436 2019-02-14  Jiewen Tan  <jiewen_tan@apple.com>
3437
3438         Unreviewed, build fix after r241480
3439
3440         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
3441         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
3442         (-[DragAndDropSimulator initWithWebView:]):
3443
3444 2019-02-14  Chris Fleizach  <cfleizach@apple.com>
3445
3446         AX: ARIA Reflection was disabled in error
3447         https://bugs.webkit.org/show_bug.cgi?id=194647
3448         <rdar://problem/48068336>
3449
3450         Reviewed by Ryosuke Niwa.
3451
3452         Remove test override now that this feature should be enabled by default.
3453
3454         * WebKitTestRunner/TestController.cpp:
3455         (WTR::TestController::resetPreferencesToConsistentValues):
3456
3457 2019-02-14  Commit Queue  <commit-queue@webkit.org>
3458
3459         Unreviewed, rolling out r241486.
3460         https://bugs.webkit.org/show_bug.cgi?id=194655
3461
3462         causing API failures in builds (Requested by ShawnRoberts on
3463         #webkit).
3464
3465         Reverted changeset:
3466
3467         "[Cocoa] Media elements will restart network buffering just
3468         before suspending"
3469         https://bugs.webkit.org/show_bug.cgi?id=193691
3470         https://trac.webkit.org/changeset/241486
3471
3472 2019-02-14  Zalan Bujtas  <zalan@apple.com>
3473
3474         [LFC][BFC][MarginCollapse] Replaced boxes don't collapse through their margins
3475         https://bugs.webkit.org/show_bug.cgi?id=194622
3476
3477         Reviewed by Antti Koivisto.
3478
3479         * LayoutReloaded/misc/LFC-passing-tests.txt:
3480
3481 2019-02-14  Zalan Bujtas  <zalan@apple.com>
3482
3483         [LFC] Shrink-to-fit-width should be constrained by min/max width
3484         https://bugs.webkit.org/show_bug.cgi?id=194653
3485
3486         Reviewed by Antti Koivisto.
3487
3488         * LayoutReloaded/misc/LFC-passing-tests.txt:
3489
3490 2019-02-13  Ryosuke Niwa  <rniwa@webkit.org>
3491
3492         Crash in WKBundleFrameGetParentFrame when called inside didRemoveFrameFromHierarchy
3493         https://bugs.webkit.org/show_bug.cgi?id=194641
3494
3495         Reviewed by Geoffrey Garen.
3496
3497         Added a call to WKBundleFrameGetParentFrame to an existing test for didRemoveFrameFromHierarchy
3498         so that the test would fail without this fix.
3499
3500         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
3501         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
3502
3503 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
3504
3505         [ews-app] Change log level for a log statement
3506
3507         Unreviewed minor fix.
3508
3509         * BuildSlaveSupport/ews-app/ews/models/patch.py:
3510         (Patch.save_patch):
3511
3512 2019-02-13  Jer Noble  <jer.noble@apple.com>
3513
3514         [Cocoa] Media elements will restart network buffering just before suspending
3515         https://bugs.webkit.org/show_bug.cgi?id=193691
3516
3517         Reviewed by Eric Carlson.
3518
3519         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3520         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
3521         (TEST):
3522
3523 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
3524
3525         [ews-app] Fetch builder id to name mapping
3526         https://bugs.webkit.org/show_bug.cgi?id=194355
3527
3528         Reviewed by Lucas Forschler.
3529
3530         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
3531         (Buildbot.get_builder_id_to_name_mapping):
3532         (Buildbot._get_display_name_from_builder_name):
3533
3534 2019-02-12  Jiewen Tan  <jiewen_tan@apple.com>
3535
3536         Further restricting webarchive loads
3537         https://bugs.webkit.org/show_bug.cgi?id=194567
3538         <rdar://problem/47610130>
3539
3540         Reviewed by Youenn Fablet.
3541
3542         Besides adding API tests, this patch also enhances DragAndDropSimulator to allow
3543         navigations on drop.
3544
3545         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3546         * TestWebKitAPI/Tests/mac/LoadWebArchive.mm: Added.
3547         (-[TestLoadWebArchiveNavigationDelegate webView:didFinishNavigation:]):
3548         (-[TestLoadWebArchiveNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
3549         (-[TestLoadWebArchiveNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
3550         (TestWebKitAPI::TEST):
3551         * TestWebKitAPI/Tests/mac/helloworld.webarchive: Added.
3552         * TestWebKitAPI/Tests/mac/load-web-archive-1.html: Added.
3553         * TestWebKitAPI/Tests/mac/load-web-archive-2.html: Added.
3554         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
3555         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
3556         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
3557         (-[DragAndDropSimulator _webView:dragDestinationActionMaskForDraggingInfo:]):
3558
3559 2019-02-13  John Wilander  <wilander@apple.com>
3560
3561         Store Ad Click Attribution requests in the network process
3562         https://bugs.webkit.org/show_bug.cgi?id=194510
3563         <rdar://problem/47650118>
3564
3565         Reviewed by Alex Christensen and Daniel Bates.
3566
3567         This patch adds two TestRunner functions:
3568         - dumpAdClickAttribution()
3569         - clearAdClickAttribution()
3570
3571         They call into the network process to dump and clear Ad Click
3572         Attribution state, respectively.
3573
3574         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3575         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3576         (WTR::TestRunner::dumpAdClickAttribution):
3577         (WTR::TestRunner::clearAdClickAttribution):
3578         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3579         * WebKitTestRunner/TestController.cpp:
3580         (WTR::TestController::resetStateToConsistentValues):
3581         (WTR::AdClickAttributionStringResultCallbackContext::AdClickAttributionStringResultCallbackContext):
3582         (WTR::adClickAttributionStringResultCallback):
3583         (WTR::TestController::dumpAdClickAttribution):
3584         (WTR::AdClickAttributionVoidCallbackContext::AdClickAttributionVoidCallbackContext):
3585         (WTR::adClickAttributionVoidCallback):
3586         (WTR::TestController::clearAdClickAttribution):
3587         * WebKitTestRunner/TestController.h:
3588         * WebKitTestRunner/TestInvocation.cpp:
3589         (WTR::TestInvocation::dumpResults):
3590         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3591         (WTR::TestInvocation::dumpAdClickAttribution):
3592         * WebKitTestRunner/TestInvocation.h:
3593
3594 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
3595
3596         [ews-app] Generate status-bubble
3597         https://bugs.webkit.org/show_bug.cgi?id=194572
3598
3599         Reviewed by Lucas Forschler.
3600
3601         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3602         (StatusBubble._build_bubble):
3603         (StatusBubble._should_show_bubble_for):
3604         (StatusBubble._build_bubbles_for_patch):
3605
3606 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
3607
3608         [ews-app] Add status bubble html template
3609         https://bugs.webkit.org/show_bug.cgi?id=194571
3610
3611         Reviewed by Lucas Forschler.
3612
3613         * BuildSlaveSupport/ews-app/ews/templates: Added.
3614         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Copied from QueueStatusServer/templates/statusbubble.html.
3615
3616 2019-02-12  Chris Dumez  <cdumez@apple.com>
3617
3618         Regression(PSON) MESSAGE_CHECK() hit under WebPageProxy::didFailProvisionalLoadForFrameShared()
3619         https://bugs.webkit.org/show_bug.cgi?id=194568
3620         <rdar://problem/47944490>
3621
3622         Reviewed by Ryosuke Niwa.
3623
3624         Add API test coverage.
3625
3626         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3627         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
3628
3629 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
3630
3631         webkitpy: Remove bug_dummy from parsed test expectations
3632         https://bugs.webkit.org/show_bug.cgi?id=194562
3633         <rdar://problem/47853999>
3634
3635         Reviewed by Lucas Forschler.
3636
3637         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3638         (TestExpectationParser):
3639         (TestExpectationParser.expectation_for_skipped_test): Remove DUMMY_BUG_MODIFIER from
3640         skipped tests.
3641         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
3642
3643 2019-02-12  Aakash Jain  <aakash_jain@apple.com>
3644
3645         [ews-app] Add method to fetch patch
3646         https://bugs.webkit.org/show_bug.cgi?id=194518
3647
3648         Reviewed by Lucas Forschler.
3649
3650         * BuildSlaveSupport/ews-app/ews/models/patch.py:
3651         (Patch.get_patch):
3652
3653 2019-02-12  Zalan Bujtas  <zalan@apple.com>
3654
3655         [LFC] Expand tests coverage (60 new tests -> 860)
3656
3657         Unreviewed test gardening (run-singly, --child-processes=1).
3658
3659         * LayoutReloaded/misc/LFC-passing-tests.txt:
3660
3661 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
3662
3663         Allow pages to trigger programmatic paste from script on iOS
3664         https://bugs.webkit.org/show_bug.cgi?id=194271
3665         <rdar://problem/47808810>
3666
3667         Reviewed by Tim Horton.
3668
3669         Add support for interacting with the callout bar on iOS during layout tests. See below for more detail.
3670
3671         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3672         (WTR::UIScriptController::platformSetDidShowMenuCallback):
3673         (WTR::UIScriptController::platformSetDidHideMenuCallback):
3674         (WTR::UIScriptController::rectForMenuAction const):
3675
3676         Add new mechanisms to make it possible to interact with and query the state of the callout menu on iOS. This
3677         includes determining the rect (in content view coordinates) of the menu's controls, and callbacks to register
3678         for when the menu is shown or hidden.
3679
3680         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3681         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
3682         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3683         (WTR::UIScriptController::setDidShowMenuCallback):
3684         (WTR::UIScriptController::didShowMenuCallback const):
3685         (WTR::UIScriptController::setDidHideMenuCallback):
3686         (WTR::UIScriptController::didHideMenuCallback const):
3687         (WTR::UIScriptController::platformSetDidShowMenuCallback):
3688         (WTR::UIScriptController::platformSetDidHideMenuCallback):
3689         (WTR::UIScriptController::rectForMenuAction const):
3690         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3691         * WebKitTestRunner/TestController.cpp:
3692         (WTR::TestController::resetPreferencesToConsistentValues):
3693         (WTR::updateTestOptionsFromTestHeader):
3694         * WebKitTestRunner/TestOptions.h:
3695
3696         Add a new test option to determine whether DOM paste is enabled. DOM paste is currently enabled everywhere by
3697         default, but these new programmatic paste tests require it to be disabled in order for confirmation UI to show.
3698
3699         (WTR::TestOptions::hasSameInitializationOptions const):
3700         * WebKitTestRunner/UIScriptControllerCocoa.mm:
3701         (WTR::UIScriptController::calendarType const):
3702         (WTR::UIScriptController::platformUndoManager const):
3703         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3704         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3705         (-[TestRunnerWKWebView initWithFrame:configuration:]):
3706         (-[TestRunnerWKWebView dealloc]):
3707         (-[TestRunnerWKWebView _didShowMenu]):
3708         (-[TestRunnerWKWebView _didHideMenu]):
3709
3710         Listen to when the callout bar is presented and dismissed, and invoke testing callbacks as needed.
3711<