Tools/ChangeLog

   1 2013-10-28  Simon Fraser  <simon.fraser@apple.com>
   2
   3         Tidy up main http://build.webkit.org page
   4         https://bugs.webkit.org/show_bug.cgi?id=123413
   5
   6         Reviewed by Alexey Proskuryakov.
   7
   8         Break the list of links into sections. Add some font style.
   9
  10         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
  11
  12 2013-10-28  Myles C. Maxfield  <mmaxfield@apple.com>
  13
  14         Parsing support for -webkit-text-decoration-skip: ink
  15         https://bugs.webkit.org/show_bug.cgi?id=123358
  16
  17         Reviewed by Dean Jackson.
  18
  19         Adding ENABLE(CSS3_TEXT_DECORATION)
  20
  21         * Scripts/webkitperl/FeatureList.pm:
  22
  23 2013-10-28  Lucas Forschler  <lforschler@apple.com>
  24
  25         Add additional Apple Mavericks test bots.
  26
  27         Unreviewed.
  28
  29         * BuildSlaveSupport/build.webkit.org-config/config.json:
  30
  31 2013-10-28  Bastien Nocera <hadess@hadess.net>
  32
  33         Name all the GLib timeout sources
  34         https://bugs.webkit.org/show_bug.cgi?id=123229
  35
  36         Reviewed by Anders Carlsson.
  37
  38         Give a name to GLib timeout sources, this is helpful when
  39         profiling WebKitGTK applications.
  40
  41 2013-10-28  Bastien Nocera <hadess@hadess.net>
  42
  43         Replace 0 timeouts g_timeout_add() by g_idle_add()
  44         https://bugs.webkit.org/show_bug.cgi?id=123260
  45
  46         Reviewed by Carlos Garcia Campos.
  47
  48         A zero timeout should be equivalent to using g_idle_add_full(G_PRIORITY_DEFAULT, ...)
  49         without the nagging feeling that the wrong API was used.
  50
  51         * DumpRenderTree/gtk/DumpRenderTree.cpp: Use g_idle_add() instead
  52         of 0-timer.
  53         (topLoadingFrameLoadFinished):
  54         * DumpRenderTree/gtk/EventSender.cpp: Ditto.
  55         (scheduleAsynchronousClickCallback):
  56         (scheduleAsynchronousKeyDownCallback):
  57
  58 2013-10-25  Anton Obzhirov  <a.obzhirov@samsung.com>
  59
  60         [GTK] [WebKit2] CanHandleRequest API test fails
  61         https://bugs.webkit.org/show_bug.cgi?id=88453
  62
  63         Reviewed by Martin Robinson.
  64
  65         * Scripts/run-gtk-tests:
  66         (TestRunner):
  67
  68 2013-10-25  Ryosuke Niwa  <rniwa@webkit.org>
  69
  70         Build fix after r157815. Don't resolve the path from webkit_base. Use the relative path as is.
  71
  72         * Scripts/webkitpy/port/base.py:
  73         (Port.repository_paths):
  74
  75 2013-10-25  Jer Noble  <jer.noble@apple.com>
  76
  77         [WTF] Add a multiplication operator (and a few others) to MediaTime
  78         https://bugs.webkit.org/show_bug.cgi?id=123137
  79
  80         Reviewed by Eric Carlson.
  81
  82         Add tests for new MediaTime operators.
  83
  84         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
  85         (TestWebKitAPI::TEST):
  86
  87 2013-10-24  Mark Rowe  <mrowe@apple.com>
  88
  89         Remove references to OS X 10.7 from Xcode configuration settings.
  90
  91         Now that we're not building for OS X 10.7 they're no longer needed.
  92
  93         Reviewed by Anders Carlsson.
  94
  95         * DumpRenderTree/mac/Configurations/Base.xcconfig:
  96         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
  97         * MiniBrowser/Configurations/Base.xcconfig:
  98         * MiniBrowser/Configurations/DebugRelease.xcconfig:
  99         * TestWebKitAPI/Configurations/Base.xcconfig:
 100         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
 101         * WebKitLauncher/Configurations/Base.xcconfig:
 102         * WebKitTestRunner/Configurations/Base.xcconfig:
 103         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
 104
 105 2013-10-24  Mark Rowe  <mrowe@apple.com>
 106
 107         <rdar://problem/15312643> Prepare for the mysterious future.
 108
 109         Reviewed by David Kilzer.
 110
 111         * DumpRenderTree/mac/Configurations/Base.xcconfig:
 112         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
 113         * MiniBrowser/Configurations/Base.xcconfig:
 114         * MiniBrowser/Configurations/DebugRelease.xcconfig:
 115         * TestWebKitAPI/Configurations/Base.xcconfig:
 116         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
 117         * WebKitLauncher/Configurations/Base.xcconfig:
 118         * WebKitTestRunner/Configurations/Base.xcconfig:
 119         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
 120
 121 2013-10-24  Daniel Bates  <dabates@apple.com>
 122
 123         Crash in WebCore::NavigationScheduler::startTimer()
 124         https://bugs.webkit.org/show_bug.cgi?id=123288
 125         <rdar://problem/14055644>
 126
 127         Reviewed by Alexey Proskuryakov.
 128
 129         Add API test.
 130
 131         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 132         * TestWebKitAPI/Tests/mac/WillPerformClientRedirectToURLCrash.html: Added.
 133         * TestWebKitAPI/Tests/mac/WillPerformClientRedirectToURLCrash.mm: Added.
 134
 135 2013-10-24  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
 136
 137         [GTK] Disable css-image-orientation
 138         https://bugs.webkit.org/show_bug.cgi?id=123257
 139
 140         Reviewed by Martin Robinson.
 141
 142         CSS image orientation isn't stable yet. So, test regression happen since r157909.
 143         This feature should be enabled again after it is stable.
 144
 145         * Scripts/webkitperl/FeatureList.pm:
 146
 147 2013-10-24  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
 148
 149         Fix argument passing for jhbuild.
 150         https://bugs.webkit.org/show_bug.cgi?id=123253
 151
 152         Reviewed by Gustavo Noronha Silva.
 153
 154         The update-webkit-libs-jhbuild previously didn't allowed
 155         extra arguments to be passed to jhbuild.
 156
 157         * Scripts/update-webkit-libs-jhbuild:
 158         (runJhbuild):
 159         * Scripts/update-webkitefl-libs:
 160
 161 2013-10-24  Sanghyup Lee  <sh53.lee@samsung.com>
 162
 163         [EFL] Compilation warning in DumpRenderTreeView.cpp on 64-Bit
 164         https://bugs.webkit.org/show_bug.cgi?id=123251
 165
 166         Reviewed by Csaba Osztrogonác.
 167
 168         Replace %llu by PRIu64 macro to print an uint64_t value and silent a
 169         compilation warning on 64-Bit.
 170
 171         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
 172         (onExceededDatabaseQuota):
 173
 174 2013-10-24  Ryuan Choi  <ryuan.choi@samsung.com>
 175
 176         [EFL] Build break with latest EFL 1.8 libraries.
 177         https://bugs.webkit.org/show_bug.cgi?id=123245
 178
 179         Reviewed by Gyuyoung Kim.
 180
 181         After fixed build break on EFL 1.8 at r138326, EFL libraries are changed
 182         Eo typedef and splitted header files which contain version macro.
 183
 184         * TestWebKitAPI/PlatformWebView.h: Changed Eo typedef.
 185         * WebKitTestRunner/InjectedBundle/TestRunner.h: Ditto.
 186         * WebKitTestRunner/PlatformWebView.h: Ditto.
 187
 188 2013-10-24  Carlos Garcia Campos  <cgarcia@igalia.com>
 189
 190         [GObject bindings] Make EventTarget interface introspectable
 191         https://bugs.webkit.org/show_bug.cgi?id=77835
 192
 193         Reviewed by Gustavo Noronha Silva.
 194
 195         * Scripts/webkitpy/style/checker.py: Add exceptions for custom
 196         GObject DOM bindings headers.
 197
 198 2013-10-23  Lucas Forschler  <lforschler@apple.com>
 199
 200         Add two more mac bots to the Mavericks Test Queue.
 201
 202         Unreviewed.
 203
 204         * BuildSlaveSupport/build.webkit.org-config/config.json:
 205
 206 2013-10-23  Filip Pizlo  <fpizlo@apple.com>
 207
 208         Have a way of dealing with slow tests in run-jsc-stress-tests
 209         https://bugs.webkit.org/show_bug.cgi?id=123221
 210
 211         Reviewed by Mark Hahnenberg.
 212
 213         If you add the slow! command to //@ then all subsequent plans are prepended to the run list
 214         rather than appended to it. This means that slow tests get queued up first and are less likely
 215         to block completion.
 216
 217         * Scripts/run-jsc-stress-tests:
 218
 219 2013-10-23  Alex Christensen  <achristensen@webkit.org>
 220
 221         Explicitly build Win32 or x64 configuration on Windows.
 222         https://bugs.webkit.org/show_bug.cgi?id=123206
 223
 224         Reviewed by Brent Fulgham.
 225
 226         * Scripts/webkitdirs.pm:
 227         (jscPath):
 228         (determineConfigurationForVisualStudio):
 229         (determinePassedConfiguration):
 230         Add |Win32 to the end of 32-bit Visual Studio build configurations.
 231         (safariPath):
 232         * Scripts/build-webkit:
 233         * Scripts/old-run-webkit-tests:
 234         * Scripts/run-api-tests:
 235         (testToolPath):
 236         * Scripts/run-javascriptcore-tests:
 237         (testapiPath):
 238         * Scripts/run-regexp-tests:
 239         (testapiPath):
 240         * Scripts/sunspider-compare-results:
 241         (pathToBuiltJSC):
 242         Use configuration instead of configurationForVisualStudio, which are now always different.
 243
 244 2013-10-23  Mark Lam  <mark.lam@apple.com>
 245
 246         Re-instate ProposedDatabases needed by detailsForNameAndOrigin().
 247         https://bugs.webkit.org/show_bug.cgi?id=123131.
 248
 249         Reviewed by Geoffrey Garen.
 250
 251         Updated these files to allow database quotas to grow within a limit for
 252         testing purposes.
 253
 254         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
 255         (BlackBerry::WebKit::DumpRenderTree::exceededDatabaseQuota):
 256         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
 257         (onExceededDatabaseQuota):
 258         * DumpRenderTree/mac/UIDelegate.mm:
 259         (-[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:]):
 260         * DumpRenderTree/win/UIDelegate.cpp:
 261         (UIDelegate::exceededDatabaseQuota):
 262         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
 263         (WTR::InjectedBundlePage::didExceedDatabaseQuota):
 264         * WebKitTestRunner/TestController.cpp:
 265         (WTR::exceededDatabaseQuota):
 266
 267 2013-10-23  Simon Fraser  <simon.fraser@apple.com>
 268
 269         It's valid to have a build ID of 0.
 270
 271         Reviewed by Tim Hatcher.
 272
 273         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
 274         (BuildbotIteration):
 275
 276 2013-10-23  Simon Fraser  <simon.fraser@apple.com>
 277
 278         Remove Lion bots from the Dashboard.
 279
 280         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
 281         (WebKitBuildbot):
 282
 283 2013-10-23  Mario Sanchez Prada  <mario.prada@samsung.com>
 284
 285         [GTK] Expose image links properly
 286         https://bugs.webkit.org/show_bug.cgi?id=84044
 287
 288         Reviewed by Chris Fleizach.
 289
 290         Expose the accessible URL if present, as yet another attribute
 291         for the AccessibilityUIElement wrapper. For coherence with what
 292         the Mac port does (and what you would expect as the output of
 293         the layout test), we strip the absolute URL path for relative
 294         references, if it's the case, leaving the base of the URL path
 295         out of the exposed string.
 296
 297         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
 298         (attributesOfElement): Print the AXURL, if available.
 299         (AccessibilityUIElement::url): Expose the URL if present. That
 300         is, if the wrapped AtkObject implements AtkHyperlinkImpl.
 301         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
 302         (attributesOfElement): Print the AXURL, if available.
 303         (WTR::AccessibilityUIElement::url): Expose the URL if present.
 304         That is, if the wrapped AtkObject implements AtkHyperlinkImpl.
 305
 306 2013-10-23  Simon Fraser  <simon.fraser@apple.com>
 307
 308         Remove Lion bots.
 309
 310         * BuildSlaveSupport/build.webkit.org-config/config.json:
 311
 312 2013-10-22  Simon Fraser  <simon.fraser@apple.com>
 313
 314         Dashboard repaints constantly
 315         https://bugs.webkit.org/show_bug.cgi?id=122133
 316
 317         Reviewed by Tim Horton.
 318
 319         Pulsing shadows are really bad for battery life.
 320
 321         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
 322         (.status-line.bad .bubble):
 323         (.status-line.bad .message):
 324
 325 2013-10-22  Commit Queue  <commit-queue@webkit.org>
 326
 327         Unreviewed, rolling out r157835.
 328         http://trac.webkit.org/changeset/157835
 329         https://bugs.webkit.org/show_bug.cgi?id=123192
 330
 331         broke 32-bit builds (Requested by smfr on #webkit).
 332
 333         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
 334         (TestWebKitAPI::TEST):
 335
 336 2013-10-22  Jer Noble  <jer.noble@apple.com>
 337
 338         [WTF] Add a multiplication operator (and a few others) to MediaTime
 339         https://bugs.webkit.org/show_bug.cgi?id=123137
 340
 341         Reviewed by Eric Carlson.
 342
 343         Add tests for new MediaTime operators.
 344
 345         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
 346         (TestWebKitAPI::TEST):
 347
 348 2013-10-22  Simon Fraser  <simon.fraser@apple.com>
 349
 350         Educate webkitpy about Mavericks.
 351
 352         Reviewed by Ryosuke Niwa.
 353
 354         * Scripts/webkitpy/common/system/platforminfo.py:
 355         (PlatformInfo._determine_mac_version):
 356         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
 357         (TestPlatformInfo.test_os_version):
 358         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
 359         (TestExpectationParser):
 360         * Scripts/webkitpy/port/builders.py:
 361         * Scripts/webkitpy/port/mac.py:
 362         (MacPort):
 363         * Scripts/webkitpy/port/mac_unittest.py:
 364         (test_versions):
 365         (test_baseline_search_path):
 366         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
 367         (TestRebaselineTest.test_baseline_directory):
 368         (TestRebaselineExpectations.test_rebaseline_expectations):
 369
 370 2013-10-22  Stephanie Lewis  <slewis@apple.com>
 371
 372         Update the build trigger list for Mavericks.
 373
 374         Unreviewed.
 375
 376         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
 377         (_should_file_trigger_build):
 378
 379 2013-10-22  Simon Fraser  <simon.fraser@apple.com>
 380
 381         Add Mavericks bots to the dashboard.
 382
 383         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
 384         (WebKitBuildbot):
 385
 386 2013-10-22  Samuel White  <samuel_white@apple.com>
 387
 388         AX: Add paramAttrs to fetch start and end text markers in a given rect.
 389         https://bugs.webkit.org/show_bug.cgi?id=122164
 390
 391         Reviewed by Chris Fleizach.
 392
 393         Added accessibility element hooks to test endTextMarkerForBounds and startTextMarkerForBounds.
 394
 395         * DumpRenderTree/AccessibilityUIElement.cpp:
 396         (endTextMarkerForBoundsCallback):
 397         (startTextMarkerForBoundsCallback):
 398         (AccessibilityUIElement::endTextMarkerForBounds):
 399         (AccessibilityUIElement::startTextMarkerForBounds):
 400         (AccessibilityUIElement::getJSClass):
 401         * DumpRenderTree/AccessibilityUIElement.h:
 402         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
 403         (AccessibilityUIElement::endTextMarkerForBounds):
 404         (AccessibilityUIElement::startTextMarkerForBounds):
 405         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
 406         (WTR::AccessibilityUIElement::endTextMarkerForBounds):
 407         (WTR::AccessibilityUIElement::startTextMarkerForBounds):
 408         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
 409         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
 410         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
 411         (WTR::AccessibilityUIElement::endTextMarkerForBounds):
 412         (WTR::AccessibilityUIElement::startTextMarkerForBounds):
 413         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
 414         (WTR::AccessibilityUIElement::endTextMarkerForBounds):
 415         (WTR::AccessibilityUIElement::startTextMarkerForBounds):
 416
 417 2013-10-22  Ryosuke Niwa  <rniwa@webkit.org>
 418
 419         There should be a way to specify additional repository paths in NRWT
 420         https://bugs.webkit.org/show_bug.cgi?id=123135
 421
 422         Reviewed by Alexey Proskuryakov.
 423
 424         Added --additional-repository-name and --additional-repository-path options to NRWT.
 425         These options allow us to submit addtional repository information, such as of Safari's
 426         to the new flakiness dashboard.
 427
 428         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
 429         (parse_args):
 430         * Scripts/webkitpy/port/base.py:
 431         (Port.repository_paths):
 432
 433 2013-10-22  Commit Queue  <commit-queue@webkit.org>
 434
 435         Unreviewed, rolling out r157774.
 436         http://trac.webkit.org/changeset/157774
 437         https://bugs.webkit.org/show_bug.cgi?id=123167
 438
 439         causes python test to fail (Requested by smfr on #webkit).
 440
 441         * Scripts/webkitpy/layout_tests/controllers/manager.py:
 442         (Manager.run):
 443         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
 444         (TestExpectations.__init__):
 445         (TestExpectations._add_expectations):
 446         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
 447         (parse_args):
 448         (_set_up_derived_options):
 449
 450 2013-10-22  Lucas Forschler  <lforschler@apple.com>
 451
 452         Prepare WebKit Buildbot master for Mavericks.
 453         This adds the following bot configurations:
 454             Mavericks Release/Debug builders
 455             Mavericks Release/Debug WK1 Testers
 456             Mavericks Release/Debug WK2 Testers
 457
 458         Unreviewed.
 459
 460         * BuildSlaveSupport/build.webkit.org-config/config.json:
 461
 462 2013-10-21  Tamas Gergely  <gertom@inf.u-szeged.hu>
 463
 464         Run tests as if they are expected to pass when --force is given.
 465         https://bugs.webkit.org/show_bug.cgi?id=112890
 466
 467         Reviewed by Ryosuke Niwa.
 468
 469         The --force switch of new-run-webkit-tests is now forces all tests to
 470         be run with 'PASS' as expected result.
 471
 472         * Scripts/webkitpy/layout_tests/controllers/manager.py:
 473         (Manager.run):
 474         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
 475         (TestExpectations.__init__):
 476         (TestExpectations._add_expectations):
 477         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
 478         (parse_args):
 479         (_set_up_derived_options):
 480
 481 2013-10-21  Mark Rowe  <mrowe@apple.com>
 482
 483         Add a version of WebKitSystemInterface for Mavericks.
 484
 485         Reviewed by Ryosuke Niwa.
 486
 487         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
 488         * Scripts/copy-webkitlibraries-to-product-directory:
 489         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
 490
 491 2013-10-21  Anders Carlsson  <andersca@apple.com>
 492
 493         Navigation policy callback not called when performing the same fragment navigation twice
 494         https://bugs.webkit.org/show_bug.cgi?id=123121
 495         <rdar://problem/15230466>
 496
 497         Reviewed by Beth Dakin.
 498
 499         Add a test.
 500
 501         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 502         * TestWebKitAPI/Tests/mac/FragmentNavigation.html: Added.
 503         * TestWebKitAPI/Tests/mac/FragmentNavigation.mm: Added.
 504         (+[WebKit1FragmentNavigationTestDelegate shared]):
 505         (-[WebKit1FragmentNavigationTestDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
 506         (-[WebKit1FragmentNavigationTestDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
 507         (-[WebKit1FragmentNavigationTestDelegate webView:didFinishLoadForFrame:]):
 508         (-[WebKit1FragmentNavigationTestDelegate _runNextTestWithWebView:]):
 509         (TestWebKitAPI::TEST):
 510
 511 2013-10-21  Dan Bernstein  <mitz@apple.com>
 512
 513         Style checker should allow a space after the @property keyword
 514         https://bugs.webkit.org/show_bug.cgi?id=123117
 515
 516         Reviewed by Anders Carlsson.
 517
 518         * Scripts/webkitpy/style/checkers/cpp.py:
 519         (check_spacing_for_function_call): Allow a space between @property and the following (
 520         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
 521         (CppStyleTest.test_spacing_for_fncall): Added a test case.
 522
 523 2013-10-21  peavo@outlook.com  <peavo@outlook.com>
 524
 525         [WinCairo] Build does not start.
 526         https://bugs.webkit.org/show_bug.cgi?id=123059
 527
 528         Reviewed by Csaba Osztrogonác.
 529
 530         The function isAppleWinWebKit() does no longer return true for WinCairo, need to add isWinCairo() checks instead.
 531
 532         * Scripts/build-webkit:
 533
 534 2013-10-21  Zan Dobersek  <zdobersek@igalia.com>
 535
 536         [Jhbuild] Bump the required Jhbuild revision
 537         https://bugs.webkit.org/show_bug.cgi?id=123089
 538
 539         Reviewed by Carlos Garcia Campos.
 540
 541         * jhbuild/jhbuild-wrapper: Latest versions of the gnome-common tools produce failures when configuring Jhbuild
 542         due to the configure.ac script using both IT_PROG_INTLTOOL and AM_GNU_GETTEXT macros. This is already fixed
 543         in the Jhbuild source so a more recent revision of it should be used.
 544
 545 2013-10-19  Alexey Proskuryakov  <ap@apple.com>
 546
 547         Mac build fix.
 548
 549         * DumpRenderTree/mac/DumpRenderTree.mm: Cast the length for %lu specifier.
 550
 551 2013-10-19  Alexey Proskuryakov  <ap@apple.com>
 552
 553         Enable webaudio/ tests on DRT/Mac
 554         https://bugs.webkit.org/show_bug.cgi?id=86914
 555
 556         Reviewed by Darin Adler.
 557
 558         * DumpRenderTree/ForwardingHeaders/runtime/ArrayBufferView.h: Copied from Source/WebCore/ForwardingHeaders/runtime/ArrayBufferView.h.
 559         * DumpRenderTree/ForwardingHeaders/runtime/JSArrayBufferView.h: Copied from Source/WebCore/ForwardingHeaders/runtime/JSArrayBufferView.h.
 560         * DumpRenderTree/ForwardingHeaders/runtime/TypedArrayInlines.h: Copied from Source/WebCore/ForwardingHeaders/runtime/TypedArrayInlines.h.
 561         There is no way to efficiently get TypedArray buffer using API, so we need some internal headers.
 562
 563         * DumpRenderTree/TestRunner.cpp:
 564         (setAudioResultCallback):
 565         (TestRunner::staticFunctions):
 566         * DumpRenderTree/TestRunner.h:
 567         (TestRunner::audioResult):
 568         (TestRunner::setAudioResult):
 569         The function has a different name and argument type now, updated accordingly.
 570         Changed buffer from std::string to std::vector<char>, because it's more idiomatic.
 571
 572         * DumpRenderTree/mac/DumpRenderTree.mm:
 573         (dumpAudio): Updated for the new name of audioResult accessor.
 574         (dump): Print the result in the format webkitpy currently expects.
 575
 576         * WebKitTestRunner/TestInvocation.cpp:
 577         (WTR::TestInvocation::dumpAudio): fwrite the whole block at once, splitting into
 578         chunks made no sense.
 579
 580         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
 581         (WTR::TestRunner::setAudioResult): Added a FIXME about getting off WKBundle SPI.
 582
 583         * DumpRenderTree/CMakeLists.txt: Added JavaScriptCore/parser to include search list,
 584         so that "SourceProvider.h" can be found.
 585
 586 2013-10-19  Ryosuke Niwa  <rniwa@webkit.org>
 587
 588         run-webkit-tests should submit time and modifiers to the new flakiness dashboard
 589         https://bugs.webkit.org/show_bug.cgi?id=123070
 590
 591         Reviewed by Alexey Proskuryakov.
 592
 593         * Scripts/webkitpy/layout_tests/controllers/manager.py:
 594         (Manager.run):
 595         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
 596         (summarize_results): Added include_time_and_modifiers. Report test_run_time and modifiers
 597         in the test expectations when this argument is set to true.
 598
 599 2013-10-19  Alexey Proskuryakov  <ap@apple.com>
 600
 601         Mac DumpRenderTree builds without NDEBUG even in release mode
 602         https://bugs.webkit.org/show_bug.cgi?id=123066
 603
 604         Reviewed by Dan Bernstein.
 605
 606         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
 607         * DumpRenderTree/mac/Configurations/Base.xcconfig:
 608         Use the same pattern as WebCore and WebKitTestRunner.
 609
 610 2013-10-19  Zan Dobersek  <zdobersek@igalia.com>
 611
 612         REGRESSION(r155373): Mac WK2 EWS bots is actually Mac WK1 debug
 613         https://bugs.webkit.org/show_bug.cgi?id=123064
 614
 615         Reviewed by Ryosuke Niwa.
 616
 617         Revert r155373 as it is causing incorrect port/platform deduction for the Mac EWS systems.
 618
 619         * Scripts/webkitpy/common/config/ports.py: Added.
 620         (DeprecatedPort):
 621         (DeprecatedPort.name):
 622         (DeprecatedPort.flag):
 623         (DeprecatedPort.script_path):
 624         (DeprecatedPort.script_shell_command):
 625         (DeprecatedPort.port):
 626         (DeprecatedPort.makeArgs):
 627         (DeprecatedPort.update_webkit_command):
 628         (DeprecatedPort.check_webkit_style_command):
 629         (DeprecatedPort.prepare_changelog_command):
 630         (DeprecatedPort.build_webkit_command):
 631         (DeprecatedPort.run_javascriptcore_tests_command):
 632         (DeprecatedPort.run_webkit_unit_tests_command):
 633         (DeprecatedPort.run_webkit_tests_command):
 634         (DeprecatedPort.run_python_unittests_command):
 635         (DeprecatedPort.run_perl_unittests_command):
 636         (DeprecatedPort.run_bindings_tests_command):
 637         (MacPort):
 638         (MacWK2Port):
 639         (MacWK2Port.run_webkit_tests_command):
 640         (WinPort):
 641         (WinPort.run_bindings_tests_command):
 642         (GtkPort):
 643         (GtkPort.build_webkit_command):
 644         (GtkPort.run_webkit_tests_command):
 645         (GtkWK2Port):
 646         (GtkWK2Port.build_webkit_command):
 647         (GtkWK2Port.run_webkit_tests_command):
 648         (QtPort):
 649         (QtPort.build_webkit_command):
 650         (QtPort.run_webkit_tests_command):
 651         (QtWK2Port):
 652         (QtWK2Port.build_webkit_command):
 653         (QtWK2Port.run_webkit_tests_command):
 654         (EflPort):
 655         (EflPort.build_webkit_command):
 656         (EflWK2Port):
 657         (EflWK2Port.build_webkit_command):
 658         * Scripts/webkitpy/common/config/ports_mock.py: Added.
 659         (MockPort):
 660         (MockPort.name):
 661         (MockPort.check_webkit_style_command):
 662         (MockPort.update_webkit_command):
 663         (MockPort.build_webkit_command):
 664         (MockPort.prepare_changelog_command):
 665         (MockPort.run_python_unittests_command):
 666         (MockPort.run_perl_unittests_command):
 667         (MockPort.run_javascriptcore_tests_command):
 668         (MockPort.run_webkit_unit_tests_command):
 669         (MockPort.run_webkit_tests_command):
 670         (MockPort.run_bindings_tests_command):
 671         * Scripts/webkitpy/common/config/ports_unittest.py: Added.
 672         (DeprecatedPortTest):
 673         (DeprecatedPortTest.test_mac_port):
 674         (DeprecatedPortTest.test_gtk_port):
 675         (DeprecatedPortTest.test_gtk_wk2_port):
 676         (DeprecatedPortTest.test_efl_port):
 677         (DeprecatedPortTest.test_qt_port):
 678         (DeprecatedPortTest.test_qt_wk2_port):
 679         * Scripts/webkitpy/port/base.py:
 680         (Port._port_flag_for_scripts):
 681         (Port._wk2_port_name):
 682         * Scripts/webkitpy/port/base_unittest.py:
 683         (PortTest.test_build_path):
 684         * Scripts/webkitpy/port/efl_unittest.py:
 685         (EflPortTest.test_show_results_html_file):
 686         * Scripts/webkitpy/port/gtk_unittest.py:
 687         (GtkPortTest.test_get_crash_log):
 688         * Scripts/webkitpy/port/mac_unittest.py:
 689         (test_64bit):
 690         * Scripts/webkitpy/port/test.py:
 691         (TestPort.virtual_test_suites):
 692         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
 693         (FlakyTestReporter.__init__):
 694         * Scripts/webkitpy/tool/bot/irc_command.py:
 695         (Rollout._update_working_copy):
 696         * Scripts/webkitpy/tool/commands/download_unittest.py:
 697         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
 698         (AbstractEarlyWarningSystem.run_command):
 699         * Scripts/webkitpy/tool/commands/queues.py:
 700         (PatchProcessingQueue.begin_work_queue):
 701         (CommitQueue.run_command):
 702         * Scripts/webkitpy/tool/main.py:
 703         (WebKitPatch.__init__):
 704         (WebKitPatch.deprecated_port):
 705         (WebKitPatch.handle_global_options):
 706         * Scripts/webkitpy/tool/mocktool.py:
 707         (MockTool.__init__):
 708         (MockTool.deprecated_port):
 709         * Scripts/webkitpy/tool/steps/build.py:
 710         (Build.build):
 711         * Scripts/webkitpy/tool/steps/checkstyle.py:
 712         (CheckStyle.run):
 713         * Scripts/webkitpy/tool/steps/commit.py:
 714         (Commit._check_test_expectations):
 715         * Scripts/webkitpy/tool/steps/preparechangelog.py:
 716         (PrepareChangeLog.run):
 717         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
 718         (PrepareChangeLogForRevert.run):
 719         * Scripts/webkitpy/tool/steps/runtests.py:
 720         (RunTests.run):
 721         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
 722         (RunTestsTest.test_webkit_run_unit_tests):
 723         * Scripts/webkitpy/tool/steps/steps_unittest.py:
 724         (StepsTest.test_runtests_args):
 725         * Scripts/webkitpy/tool/steps/update.py:
 726         (Update._update_command):
 727         * Scripts/webkitpy/tool/steps/update_unittest.py:
 728         (UpdateTest.test_update_command_non_interactive):
 729         (UpdateTest.test_update_command_interactive):
 730
 731 2013-10-19  Andreas Kling  <akling@apple.com>
 732
 733         RefPtr::releaseNonNull() incorrectly increments the refcount.
 734         <https://webkit.org/b/123063>
 735
 736         Add an API test to verify that no extra refs are added when calling
 737         RefPtr::releaseNonNull().
 738
 739         Reviewed by Anders Carlsson.
 740
 741 2013-10-18  Rik Cabanier <cabanier@adobe.com>
 742         Add Rik Cabanier to list of committers
 743         https://bugs.webkit.org/show_bug.cgi?id=123031
 744
 745         reviewed by Dirk Schulze.
 746
 747         * Tools/Scripts/webkitpy/common/config/contributors.json: Added name.
 748
 749 2013-10-18  Denis Nomiyama  <d.nomiyama@samsung.com>
 750
 751         [ATK] Fix invalid signal to set objects to an unknown state "layout-complete"
 752         https://bugs.webkit.org/show_bug.cgi?id=122970
 753
 754         Reviewed by Mario Sanchez Prada.
 755
 756         Removed an invalid signal to set an object state to layout-complete
 757         that does not exist. It was replaced by ATK:AtkDocument:load-complete.
 758
 759         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
 760         (axObjectEventListener): Replaced layout-complete with load-complete.
 761         (connectAccessibilityCallbacks): Connect callback to new listener for
 762         ATK:AtkDocument:load-complete.
 763         (disconnectAccessibilityCallbacks): Disconnect callback to new listener
 764         for ATK:AtkDocument:load-complete.
 765         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
 766         (axObjectEventListener): Replaced layout-complete with load-complete.
 767         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks):
 768         Connect callback to new listener for ATK:AtkDocument:load-complete.
 769         (WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks):
 770         Disconnect callback to new listener for ATK:AtkDocument:load-complete.
 771
 772 2013-10-18  Carlos Garcia Campos  <cgarcia@igalia.com>
 773
 774         [GTK] Generate API documentation for GObject DOM bindings
 775         https://bugs.webkit.org/show_bug.cgi?id=121538
 776
 777         Reviewed by Gustavo Noronha Silva.
 778
 779         The .symbols file that is now generated for checking GObject DOM
 780         bindings API compatibility while building can also be used to
 781         generate the files needed to produce the gtk-doc
 782         documentation. The new script generate-webkitdom-doc-files can
 783         generate the docs.sgml and sections.txt files from the given list
 784         of .symbols files.
 785
 786         * gtk/GNUmakefile.am: Add rules to generate webkitdomgtk-docs.sgml
 787         and webkitdomgtk-sections.txt as well as rules to install the
 788         generated WebKitDOMGTK documentation.
 789         * gtk/generate-gtkdoc:
 790         (webkitdom_docs_html_path): New helper function that returns the
 791         path where the DOM API documentation has been generated.
 792         (get_webkit2_options): Include DOM API docs to the list of xref
 793         dependencies.
 794         (get_webkit1_options): Ditto.
 795         (get_webkitdom_options): Return the gtk-doc options to generate
 796         the DOM API docs.
 797         (get_webkitdom_options.derived_sources_path):
 798         (get_webkitdom_options.src_path):
 799         * gtk/generate-webkitdom-doc-files: Added.
 800         (WebKitDOMDocGenerator):
 801         (WebKitDOMDocGenerator.write_header):
 802         (WebKitDOMDocGenerator.write_section):
 803         (WebKitDOMDocGenerator.write_footer):
 804         (WebKitDOMDocGeneratorDocs):
 805         (WebKitDOMDocGeneratorDocs.write_header):
 806         (write_section):
 807         (write_footer):
 808         (WebKitDOMDocGeneratorSections):
 809         (WebKitDOMDocGeneratorSections.__init__):
 810         (WebKitDOMDocGeneratorSections._dom_class):
 811         (WebKitDOMDocGeneratorSections._dom_class_decamelize):
 812         (WebKitDOMDocGeneratorSections._symbol_list):
 813         (WebKitDOMDocGeneratorSections.write_section):
 814
 815 2013-10-17  Alex Christensen  <achristensen@webkit.org>
 816
 817         Run JavaScriptCore tests again on Windows.
 818         https://bugs.webkit.org/show_bug.cgi?id=122787
 819
 820         Reviewed by Tim Horton.
 821
 822         * Scripts/build-jsc:
 823         (buildMyProject): Use JavaScriptCore.sln to build JavaScriptCore and WTF.
 824         * Scripts/run-javascriptcore-tests: Don't run stress tests on WinCairo.
 825         * Scripts/webkitdirs.pm:
 826         (determineConfigurationForVisualStudio):
 827         (determineConfigurationProductDir):
 828         Build directory should end with bin64 and configuration should end with |x64 on Win64.
 829         (isAppleWinWebKit):
 830         (copyInspectorFrontendFiles):
 831         (setPathForRunningWebKitApp):
 832         Separated WinCairo directories and options from AppleWin.
 833
 834 2013-10-17  Mihnea Ovidenie  <mihnea@adobe.com>
 835
 836         Unreviewed. Add myself as a reviewer.
 837
 838         * Scripts/webkitpy/common/config/contributors.json:
 839
 840 2013-10-17  Andreas Kling  <akling@apple.com>
 841
 842         Make it possible to assign a PassRef to a RefPtr.
 843         <https://webkit.org/b/122943>
 844
 845         Added a small API test for RefPtr=(PassRef) so we know this code
 846         will compile (and work.)
 847
 848         Reviewed by Antti Koivisto.
 849
 850 2013-10-16  Filip Pizlo  <fpizlo@apple.com>
 851
 852         We need test coverage for just the Baseline JIT
 853         https://bugs.webkit.org/show_bug.cgi?id=122929
 854
 855         Reviewed by Sam Weinig.
 856
 857         Adds no-LLInt versions of all tests. For the Mozilla tests, also add a BaselineJIT-only
 858         variant.
 859
 860         * Scripts/run-jsc-stress-tests:
 861
 862 2013-10-16  Ryosuke Niwa  <rniwa@webkit.org>
 863
 864         Support multiple repositories in submitting results to --results-server-host
 865         https://bugs.webkit.org/show_bug.cgi?id=122935
 866
 867         Reviewed by Anders Carlsson.
 868
 869         Remoevd --got-revision and added the logic to extract revision information
 870         from multiple repositories as done in run-perf-tests.
 871
 872         * Scripts/webkitpy/layout_tests/controllers/manager.py:
 873         (Manager.upload_results):
 874         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
 875         (parse_args):
 876
 877 2013-10-16  Darin Adler  <darin@apple.com>
 878
 879         Add PassRef and createRefCounted so we can improve creation of RefCounted objects
 880         https://bugs.webkit.org/show_bug.cgi?id=122904
 881
 882         Reviewed by Anders Carlsson.
 883
 884         * TestWebKitAPI/Tests/WTF/Ref.cpp: Added some basic tests for adoptRef and PassRef.
 885
 886 2013-10-16  Darin Adler  <darin@apple.com>
 887
 888         Need tests for RefPtr self-assignment and self-move-assignment.
 889
 890         * TestWebKitAPI/Tests/WTF/RefPtr.cpp: Added tests.
 891
 892 2013-10-16  Robert Plociennik  <r.plociennik@samsung.com>
 893
 894         [EFL] Minibrowser can't load child window's location
 895         https://bugs.webkit.org/show_bug.cgi?id=122485
 896
 897         Reviewed by Gyuyoung Kim.
 898
 899         * MiniBrowser/efl/main.c: Now calling window_create() without the url parameter
 900             followed by an explicit call to ewk_view_url_set() where appropriate.
 901         (on_key_down):
 902         (on_window_create):
 903         (window_create):
 904         (elm_main):
 905
 906 2013-10-15  Sergio Correia  <sergio.correia@openbossa.org>
 907
 908         [EFL][WK2] Make SeccompFilters build again after r156349 and r156353
 909         https://bugs.webkit.org/show_bug.cgi?id=122872
 910
 911         Reviewed by Anders Carlsson.
 912
 913         * TestWebKitAPI/PlatformEfl.cmake: Mark SeccompFilters API test as
 914         failing.
 915
 916 2013-10-15  Dean Jackson  <dino@apple.com>
 917
 918         Add ENABLE_WEB_ANIMATIONS flag
 919         https://bugs.webkit.org/show_bug.cgi?id=122871
 920
 921         Reviewed by Tim Horton.
 922
 923         Eventually might be http://dev.w3.org/fxtf/web-animations/
 924         but this is just engine-internal work at the moment.
 925
 926         * Scripts/webkitperl/FeatureList.pm:
 927
 928 2013-10-15  Darin Adler  <darin@apple.com>
 929
 930         Add some API tests for Vector, RefPtr, and Ref
 931         https://bugs.webkit.org/show_bug.cgi?id=122840
 932
 933         Reviewed by Andreas Kling.
 934
 935         * TestWebKitAPI/CMakeLists.txt: Added new files.
 936         * TestWebKitAPI/GNUmakefile.am: Ditto.
 937         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Ditto.
 938         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters: Ditto.
 939         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
 940
 941         * TestWebKitAPI/Tests/WTF/Ref.cpp: Added.
 942         * TestWebKitAPI/Tests/WTF/RefLogger.h: Added.
 943         * TestWebKitAPI/Tests/WTF/RefPtr.cpp: Added.
 944         * TestWebKitAPI/Tests/WTF/Vector.cpp: Added move-only insert tests.
 945
 946 2013-10-14  Roger Fong  <roger_fong@apple.com>
 947
 948         Adding myself to CC list for some components.
 949
 950         * Scripts/webkitpy/common/config/watchlist:
 951
 952 2013-10-13  Darin Adler  <darin@apple.com>
 953
 954         Deprecate or remove deleteAllValues functions; there are only a few call sites left
 955         https://bugs.webkit.org/show_bug.cgi?id=122738
 956
 957         Reviewed by Anders Carlsson.
 958
 959         * DumpRenderTree/win/DRTDataObject.cpp:
 960         (DRTDataObject::~DRTDataObject):
 961         * DumpRenderTree/win/UIDelegate.cpp:
 962         (DRTUndoStack::~DRTUndoStack):
 963         (DRTUndoStack::clear):
 964         Renamed deleteAllValues to deprecatedDeleteAllValues.
 965
 966         * Scripts/do-webcore-rename: Updated to perform this rename, as is traditional.
 967
 968 2013-10-13  Alexey Proskuryakov  <ap@apple.com>
 969
 970         build.webkit.org/dashboard incorrectly shows interrupted builds as green
 971         https://bugs.webkit.org/show_bug.cgi?id=122732
 972
 973         Reviewed by Tim Hatcher.
 974
 975         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
 976         (BuildbotIteration.prototype.update): Removed a special case for status 4 (EXCEPTION).
 977         I don't see it occur any time in recent history, but judging from what happens for
 978         status 5 (RETRY), we can just finish this function normally.
 979         Record overall text description for iteration as BuildbotIteration.text.
 980
 981         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
 982         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): If an iteration is a failure,
 983         but no tests failed, make it yellow, and use buildbot-provided description for it.
 984
 985 2013-10-13  Alexey Proskuryakov  <ap@apple.com>
 986
 987         Remove Chromium specific code from flakiness dashboard
 988         https://bugs.webkit.org/show_bug.cgi?id=122714
 989
 990         Reviewed by Sam Weinig.
 991
 992         Also removed code related to GPU tests and virtual suites.
 993         "Fallbacks map" was chromium only too, not sure why they needed special handling there.
 994
 995         * TestResultServer/model/jsonresults_unittest.py:
 996         * TestResultServer/static-dashboards/builders.js:
 997         * TestResultServer/static-dashboards/dashboard_base.js:
 998         * TestResultServer/static-dashboards/flakiness_dashboard.html:
 999         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1000         * TestResultServer/static-dashboards/flakiness_dashboard_tests.css:
1001         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1002         * TestResultServer/static-dashboards/history.js:
1003         * TestResultServer/static-dashboards/loader.js:
1004         * TestResultServer/static-dashboards/ui.js:
1005         * TestResultServer/templates/uploadform.html:
1006
1007 2013-10-11  Timothy Hatcher  <timothy@apple.com>
1008
1009         Remove preference support for picking the old Web Inspector.
1010         https://bugs.webkit.org/show_bug.cgi?id=122655
1011
1012         Reviewed by Alexey Proskuryakov.
1013
1014         * WebKitTestRunner/TestController.cpp:
1015         (WTR::TestController::resetStateToConsistentValues):
1016
1017 2013-10-11  Filip Pizlo  <fpizlo@apple.com>
1018
1019         Fix 64-bit build on everything but Windows.
1020
1021         Rubber stamped by Brent Fulgham.
1022
1023         * Scripts/webkitdirs.pm:
1024         (argumentsForConfiguration):
1025
1026 2013-10-11  Alexey Proskuryakov  <ap@apple.com>
1027
1028         Touch a file to see how auto-update works.
1029
1030         Rubber-stamped by Tim Hatcher.
1031
1032         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
1033
1034 2013-10-11  Alexey Proskuryakov  <ap@apple.com>
1035
1036         LeaksViewer fails to present recent results list if current build is still updating svn
1037         https://bugs.webkit.org/show_bug.cgi?id=122670
1038
1039         Fixed an obvious mistake in the previous patch.
1040
1041         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
1042         (RecentBuildsLoader.prototype.start):
1043
1044 2013-10-11  Alexey Proskuryakov  <ap@apple.com>
1045
1046         LeaksViewer fails to present recent results list if current build is still updating svn
1047         https://bugs.webkit.org/show_bug.cgi?id=122670
1048
1049         Reviewed by Adam Roben.
1050
1051         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
1052         (RecentBuildsLoader.prototype.start): Skip builds that don't have an svn revision yet.
1053
1054 2013-10-11  Brent Fulgham  <bfulgham@apple.com>
1055
1056         Unreviewed build fix for --64-bit target.
1057
1058         * Scripts/webkitdirs.pm:
1059         (argumentsForConfiguration): Use 'isWin64' test, since @ARGV value may have
1060         been removed by this point.
1061         (hasArgument): Remove unused temporary.
1062
1063 2013-10-10  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
1064
1065         webkit-patch failure-reason has a quite low limit for 'too many failures'
1066         https://bugs.webkit.org/show_bug.cgi?id=122556
1067
1068         Reviewed by Darin Adler.
1069
1070         * Scripts/webkitpy/tool/commands/queries.py:
1071         (FailureReason._explain_failures_for_builder): adjust the number of too many failures
1072         to match what the layout test runners use these days.
1073
1074 2013-10-10  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
1075
1076         webkit-patch failure-reason should allow specifying failures one is interested in
1077         https://bugs.webkit.org/show_bug.cgi?id=122554
1078
1079         Reviewed by Darin Adler.
1080
1081         * Scripts/webkitpy/tool/commands/queries.py:
1082         (FailureReason):
1083         (FailureReason._explain_failures_for_builder): keep track of explained failures and drop out of the
1084         loop if the ones we're interested in been explained.
1085         (FailureReason._done_explaining): check the failures we're interested in have been explained, if any.
1086         (FailureReason.execute): initialize failures to explain and the explained set.
1087
1088 2013-10-10  Filip Pizlo  <fpizlo@apple.com>
1089
1090         Make sure that DataTypes.h is in the binary drop.
1091
1092         Rubber stamped by Michael Saboff.
1093
1094         * Scripts/export-llvm-build:
1095
1096 2013-10-10  Filip Pizlo  <fpizlo@apple.com>
1097
1098         FTL: Soft-link LLVM as a workaround for LLVM's static initializers and exit-time destructors
1099         https://bugs.webkit.org/show_bug.cgi?id=122566
1100
1101         Reviewed by Mark Rowe.
1102
1103         * Scripts/configure-llvm:
1104
1105 2013-10-10  Mark Rowe  <mrowe@apple.com>
1106
1107         <rdar://problem/13341666> WebKit should always build against an SDK.
1108
1109         Have all projects default to building against the OS X Internal SDK for the Production
1110         configuration. For the Debug and Release configurations, look for UseInternalSDK.xcconfig
1111         to determine whether the OS X Internal SDK should be used. If not, use the normal OS X SDK.
1112
1113         Reviewed by Dan Bernstein.
1114
1115         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1116         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1117         * MiniBrowser/Configurations/Base.xcconfig:
1118         * MiniBrowser/Configurations/DebugRelease.xcconfig:
1119         * TestWebKitAPI/Configurations/Base.xcconfig:
1120         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
1121         * WebKitTestRunner/Configurations/Base.xcconfig:
1122         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1123
1124 2013-10-10  Gustavo Noronha Silva  <gns@gnome.org>
1125
1126         Unreviewed gardening, the inspector protocol timeouts are also affecting TestInspectorServer.
1127
1128         * Scripts/run-gtk-tests:
1129         (TestRunner): skip TestInspectorServer.
1130
1131 2013-10-10  Andres Gomez  <agomez@igalia.com>
1132
1133         [GTK] Provide search functionality to MiniBrowser
1134         https://bugs.webkit.org/show_bug.cgi?id=117631
1135
1136         Reviewed by Carlos Garcia Campos.
1137
1138         Adds a search bar to MiniBrowser with the minimum functionality
1139         and a new button to the toolbar for showing the new search
1140         bar. Typical keyboard shortcuts are also added.
1141
1142         * MiniBrowser/gtk/BrowserSearchBar.c: Added.
1143         (doSearch):
1144         (searchNext):
1145         (searchPrevious):
1146         (searchCloseButtonClickedCallback):
1147         (searchEntryMenuIconPressedCallback):
1148         (searchEntryClearIconReleasedCallback):
1149         (searchEntryChangedCallback):
1150         (searchEntryActivatedCallback):
1151         (searchPrevButtonClickedCallback):
1152         (searchNextButtonClickedCallback):
1153         (searchMenuCheckButtonToggledCallback):
1154         (browser_search_bar_init):
1155         (browserSearchBarFinalize):
1156         (browser_search_bar_class_init):
1157         (browser_search_bar_new):
1158         (browser_search_bar_add_accelerators):
1159         (browser_search_bar_open):
1160         (browser_search_bar_close):
1161         * MiniBrowser/gtk/BrowserSearchBar.h: Added.
1162         * MiniBrowser/gtk/BrowserWindow.c:
1163         (webViewEnterFullScreen): Closes new search bar.
1164         (webViewLeaveFullScreen): Opens new search bar if previously
1165         visible.
1166         (searchCallback): Added. Shows and hides the new search bar.
1167         (browser_window_init): Added search button to the toolbar.
1168         (browserWindowConstructed): Creates the new search bar.
1169         * MiniBrowser/gtk/GNUmakefile.am: Added new files to compilation.
1170
1171 2013-10-09  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
1172
1173         webkit-patch failure-reason fails with UnicodeDecodeError when name has non-ascii characters
1174         https://bugs.webkit.org/show_bug.cgi?id=122552
1175
1176         Reviewed by Darin Adler.
1177
1178         * Scripts/webkitpy/common/checkout/commitinfo.py:
1179         (CommitInfo.blame_string): ensure objects are made into unicode strings, not regular ones that
1180         will cause UnicodeDecodeError for non-ascii characters.
1181
1182 2013-10-09  Alexey Proskuryakov  <ap@apple.com>
1183
1184         Would like a link to dashboard from build.webkit.org main page
1185         https://bugs.webkit.org/show_bug.cgi?id=122577
1186
1187         Reviewed by Tim Hatcher.
1188
1189         * BuildSlaveSupport/build.webkit.org-config/templates/root.html: Added.
1190
1191 2013-10-09  Brent Fulgham  <bfulgham@apple.com>
1192
1193         [Win] Check for MathML fonts and warn user if they are missing.
1194         https://bugs.webkit.org/show_bug.cgi?id=122568
1195
1196         Reviewed by Tim Horton.
1197
1198         * Scripts/webkitdirs.pm:
1199         (checkRequiredSystemConfig): Use common gperf/bison/flex tests, rather than
1200         Windows-specific code I added previously.
1201         (fontExists): Added
1202         (checkInstalledTools): Add check for MathML fonts.
1203
1204 2013-10-09  Alexey Proskuryakov  <ap@apple.com>
1205
1206         http://build.webkit.org/dashboard/ doesn't link to webkitpy failures
1207         https://bugs.webkit.org/show_bug.cgi?id=122471
1208
1209         Reviewed by Tim Hatcher.
1210
1211         Added links to webkitpy, webkitperl and bindings-tests results.
1212
1213         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
1214         (Buildbot.prototype.apiTestResultsURLForIteration):
1215         (Buildbot.prototype.webkitpyTestResultsURLForIteration):
1216         (Buildbot.prototype.webkitperlTestResultsURLForIteration):
1217         (Buildbot.prototype.bindingsTestResultsURLForIteration):
1218         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1219         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
1220
1221 2013-10-09  Alexey Proskuryakov  <ap@apple.com>
1222
1223         Move some functions from WebKitBuildbot to Buildbot class.
1224
1225         Suggested by Tim Hatcher.
1226
1227         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
1228         (Buildbot.prototype.javascriptTestResultsURLForIteration):
1229         (Buildbot.prototype.apiTestResultsURLForIteration):
1230         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1231         (WebKitBuildbot.prototype.layoutTestResultsURLForIteration):
1232
1233 2013-10-09  Timothy Hatcher  <timothy@apple.com>
1234
1235         Add API tests to the Dashbord page.
1236
1237         https://bugs.webkit.org/show_bug.cgi?id=122283
1238
1239         Reviewed by Timothy Hatcher.
1240
1241         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1242         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
1243         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1244         (WebKitBuildbot.prototype.apiTestResultsURLForIteration):
1245
1246 2013-10-09  Timothy Hatcher  <timothy@apple.com>
1247
1248         Attempt to fix faulty Dashboard iteration updating by always rebuilding test result objects.
1249
1250         https://bugs.webkit.org/show_bug.cgi?id=122515
1251
1252         Reviewed by Alexey Proskuryakov.
1253
1254         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1255         (BuildbotIteration.prototype.update):
1256
1257 2013-10-09  Alexey Proskuryakov  <ap@apple.com>
1258
1259         build.webkit.org/dashboard doesn't provide a results link when there issues at multiple steps
1260         https://bugs.webkit.org/show_bug.cgi?id=122573
1261
1262         Reviewed by Tim Hatcher.
1263
1264         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1265         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): Provide a URL.
1266
1267         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
1268         (Buildbot.prototype.buildPageURLForIteration): Added.
1269
1270 2013-10-09  Alexey Proskuryakov  <ap@apple.com>
1271
1272         http://build.webkit.org/dashboard/ links to a wrong jscore-test results page
1273         https://bugs.webkit.org/show_bug.cgi?id=122569
1274
1275         Reviewed by Tim Hatcher.
1276
1277         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1278         (WebKitBuildbot.prototype.javascriptTestResultsURLForIteration): "actual.html" used
1279         to be produced by the old Mozilla test harness that we don't use any more.
1280
1281 2013-10-09  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
1282
1283         Add GTK 64 bits release to the buildbot dashboard
1284         https://bugs.webkit.org/show_bug.cgi?id=122548
1285
1286         Reviewed by Darin Adler.
1287
1288         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/GTK.png: Added.
1289         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1290         (WebKitBuildbot): add 64 bits release wk2 and wk1 testers.
1291         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1292         (table.queue-grid tr.platform.linux-gtk img.logo): use the GTK+ logo in its dashboard line.
1293
1294 2013-10-09  Mario Sanchez Prada  <mario.prada@samsung.com>
1295
1296         [ATK] Implement new API in AtkText: atk_text_get_string_at_offset()
1297         https://bugs.webkit.org/show_bug.cgi?id=120638
1298
1299         Reviewed by Gustavo Noronha Silva.
1300
1301         * gtk/jhbuild.modules: Raised ATK and AT-SPI versions to 2.10.0, so we
1302         can check both the old and new APIs to retrieve text at a given offset.
1303
1304 2013-10-08  Alex Christensen  <achristensen@webkit.org>
1305
1306         Improved WinLauncher.
1307         https://bugs.webkit.org/show_bug.cgi?id=122536
1308
1309         Reviewed by Brent Fulgham.
1310
1311         * WinLauncher/PrintWebUIDelegate.cpp:
1312         (PrintWebUIDelegate::runJavaScriptAlertPanelWithMessage): Added.
1313         (PrintWebUIDelegate::runJavaScriptConfirmPanelWithMessage): Added.
1314         * WinLauncher/PrintWebUIDelegate.h: Removed stubs.
1315         * WinLauncher/WinLauncher.cpp:
1316         (createCrashReport): Use the executable name instead of "WinLauncher".
1317         * WinLauncher/WinLauncher.vcxproj/WinLauncher.exe.manifest: Removed.
1318         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props: Link to Wininet.lib.
1319         * win/DLLLauncher/DLLLauncherMain.cpp: Remove VS2005 dependency for WinCairo.
1320
1321 2013-10-08  Mark Lam  <mark.lam@apple.com>
1322
1323         Fix ruby LoadError when running run-javascriptcore-tests.
1324         https://bugs.webkit.org/show_bug.cgi?id=122519.
1325
1326         Reviewed by Mark Hahnenberg.
1327
1328         The scripts needed to explicitly require 'rubygems' for older versions of ruby
1329         (versions before 1.9).
1330
1331         * Scripts/jsc-stress-test-helpers/profiler-test-helper:
1332         * Scripts/run-jsc-stress-tests:
1333
1334 2013-10-08  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1335
1336         Unreviewed, add my new email to contributors.json.
1337
1338         * Scripts/webkitpy/common/config/contributors.json:
1339
1340 2013-10-08  Brent Fulgham  <bfulgham@apple.com>
1341
1342         Unreviewed build correction.
1343
1344         * Scripts/webkitpy/port/win.py:
1345         (WinPort.write_registry_value): Use string representation of error message to avoid
1346         format conversion problem.
1347
1348 2013-10-07  Brent Fulgham  <bfulgham@apple.com>
1349
1350         [Win] Add checks for proper build and test environment
1351         https://bugs.webkit.org/show_bug.cgi?id=122466
1352
1353         Reviewed by Darin Adler.
1354
1355         This patch makes two changes:
1356         1. Update webkitdirs.pm to check for some common misconfigurations and provide helpful warnings or
1357            error messages so that people know what to fix to get things working.
1358         2. Modify the win.py port to handle the 32-bit and 64-bit test environments, as well as making sure
1359            the various environment settings are properly configured for our test environment.
1360
1361         * Scripts/webkitdirs.pm:
1362         (checkInstalledTools): Add checks for some common Cygwin configuration problems that have
1363         caused problems in the past.
1364         (setupAppleWinEnv):
1365         * Scripts/webkitpy/port/win.py:
1366         (WinPort):
1367         (WinPort.read_registry_string): Parameterize for run architecture and registry root.
1368         (WinPort.write_registry_value): Parameterize registry writing by data type (string versus
1369         DWORD, etc.)
1370         (WinPort.write_registry_string): Revise to call new generic registry write function.
1371         (WinPort.setup_crash_log_saving): Revise for new API
1372         (WinPort.restore_crash_log_saving): Ditto
1373         (WinPort.prevent_error_dialogs): Add new methods to prevent Windows dialogs that block our test
1374         servers from running.
1375         (WinPort.allow_error_dialogs): Ditto.
1376         (WinPort.setup_test_run): Call new API to turn off user input dialogs on program failure.
1377         (WinPort.clean_up_test_run): Call new API to reactivatea user input dialogs after test run finished.
1378
1379 2013-10-08  Philippe Normand  <pnormand@igalia.com>
1380
1381         [GStreamer] enable v4l2 plugin
1382         https://bugs.webkit.org/show_bug.cgi?id=122503
1383
1384         Reviewed by Martin Robinson.
1385
1386         * gtk/jhbuild.modules: Enable the plugin, it now builds fine since
1387         we updated our GStreamer version to 1.0.8.
1388
1389 2013-10-08  Mario Sanchez Prada  <mario.prada@samsung.com>
1390
1391         [ATK] Expose state of aria-invalid as ATK_STATE_INVALID_ENTRY
1392         https://bugs.webkit.org/show_bug.cgi?id=122104
1393
1394         Reviewed by Chris Fleizach.
1395
1396         Updated stringAttributeValue to double check that the exposure of
1397         aria-invalid as a state is consistent with its exposure as a text
1398         attribute as well, when it applies (implementations of AtkText).
1399
1400         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1401         (AccessibilityUIElement::stringAttributeValue): Add double check.
1402         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1403         (WTR::AccessibilityUIElement::stringAttributeValue): Ditto.
1404
1405 2013-10-07  Filip Pizlo  <fpizlo@apple.com>
1406
1407         run-jsc-stress-tests progress meter should update more quickly on older Rubies
1408         https://bugs.webkit.org/show_bug.cgi?id=122459
1409
1410         Reviewed by Darin Adler.
1411
1412         * Scripts/run-jsc-stress-tests:
1413
1414 2013-10-07  Gustavo Noronha Silva  <gns@gnome.org>
1415
1416         [buildbot] parse tests that are reported as crashed correctly for GTK+
1417         https://bugs.webkit.org/show_bug.cgi?id=122476
1418
1419         Reviewed by Martin Robinson.
1420
1421         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1422         (RunGtkAPITests.commandComplete): parse the crashed tests output so that is reported
1423         as a failure of the API tests.
1424
1425 2013-10-07  Gustavo Noronha Silva  <gns@gnome.org>
1426
1427         Unreviewed. Skipping API test that is causing the next one to crash,
1428         see https://bugs.webkit.org/show_bug.cgi?id=121970.
1429
1430         * Scripts/run-gtk-tests:
1431         (TestRunner):
1432
1433 2013-10-07  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
1434
1435         [GTK] run-gtk-tests does not distinguish between failure and crashes
1436         https://bugs.webkit.org/show_bug.cgi?id=122135
1437
1438         Reviewed by Martin Robinson.
1439
1440         The GTK+ API test runner does not distinguish between failures and crashes. This change
1441         makes it do that, so it's easier for us to spot the more important/higher priority crash
1442         case.
1443
1444         * Scripts/run-gtk-tests:
1445         (TestRunner._run_test_command): return the exit code instead of a boolean true/false,
1446         so we have more information on how the process ended.
1447         (TestRunner._run_test): check the exit code to distinguish between crashes and failures.
1448         (TestRunner.run_tests): report crashes.
1449
1450 2013-10-07  Gustavo Noronha Silva  <gns@gnome.org>
1451
1452         [GTK] Missing packages for APT on install-dependencies
1453         https://bugs.webkit.org/show_bug.cgi?id=121555
1454
1455         Reviewed by Martin Robinson.
1456
1457         * gtk/install-dependencies: add packages that are needed for
1458         building WebKit itself and the jhbuild dependencies.
1459
1460 2013-10-07  Anders Carlsson  <andersca@apple.com>
1461
1462         Fix test failures.
1463
1464         * Scripts/webkitpy/port/base.py:
1465         (Port.to.start_helper):
1466         * Scripts/webkitpy/port/mock_drt.py:
1467         (MockDRTPort.start_helper):
1468
1469 2013-10-07  Anders Carlsson  <andersca@apple.com>
1470
1471         Always force discrete mode when running layout tests
1472         https://bugs.webkit.org/show_bug.cgi?id=122465
1473
1474         Reviewed by Tim Horton.
1475
1476         This should speed up WebGL tests and hopefully prevent race conditions that may cause window server crashes from happening.
1477
1478         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1479         Link with IOKit.
1480
1481         * DumpRenderTree/mac/LayoutTestHelper.m:
1482         (installLayoutTestColorProfile):
1483         Check installColorProfile.
1484
1485         (restoreUserColorProfile):
1486         Check installColorProfile.
1487
1488         (lockDownDiscreteGraphics):
1489         New function to force discrete graphics.
1490
1491         (main):
1492         Add '--install-color-profile' option.
1493
1494         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1495         (Manager._set_up_run):
1496         Always start the helper, but pass self._options.pixel_tests to it.
1497
1498         * Scripts/webkitpy/port/mac.py:
1499         (MacPort.start_helper):
1500         Pass --install-color-profile' to the helper if pixel_tests is true.
1501
1502 2013-10-07  Timothy Hatcher  <timothy@apple.com>
1503
1504         Properly count binding test failures as failures.
1505
1506         Fix the total for multiple failures in different steps too by avoiding undefined.
1507
1508         https://bugs.webkit.org/show_bug.cgi?id=122232
1509
1510         Reviewed by Alexey Proskuryakov.
1511
1512         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
1513         (BuildbotTestResults):
1514         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1515         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
1516
1517 2013-10-07  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
1518
1519         [GTK] Fails to build with jhbuild with newer system glib
1520         https://bugs.webkit.org/show_bug.cgi?id=122132
1521
1522         Reviewed by Martin Robinson.
1523
1524         Newer glib includes new symbols that some system libraries which we depend on, such as pango, have
1525         started relying on. glib is not a dependency that should change test results, and is provided in
1526         jhbuild with the intention of supporting the other bits that do, so using a newer stable release
1527         should not be an issue.
1528
1529         * gtk/jhbuild.modules:
1530
1531 2013-10-06  Filip Pizlo  <fpizlo@apple.com>
1532
1533         run-jsc-stress-tests shouldn't print its goofy progress meter when running on the bots
1534         https://bugs.webkit.org/show_bug.cgi?id=122437
1535
1536         Reviewed by Antoine Quint.
1537
1538         * Scripts/run-jsc-stress-tests:
1539
1540 2013-10-06  Filip Pizlo  <fpizlo@apple.com>
1541
1542         Unreviewed, fix build on old Rubies.
1543
1544         * Scripts/run-jsc-stress-tests:
1545
1546 2013-10-06  Filip Pizlo  <fpizlo@apple.com>
1547
1548         Unified test infrastructure via the jsc shell
1549         https://bugs.webkit.org/show_bug.cgi?id=120696
1550
1551         Reviewed by Oliver Hunt.
1552
1553         Make run-jsc-stress-tests smart enough to be able to handle different styles of test
1554         output (silent or noisy) and different styles of test failure (just bad exit code,
1555         text diff, filtering for some magical text, etc.). This allows me to get rid of the
1556         layout-test-helper. It also allows me to switch all of the old Mozilla tests to
1557         running in run-jsc-stress-tests.
1558
1559         Also removes all of the code paths that defended against not having shellwords. Just
1560         install the shellwords gem if you want to run tests.
1561
1562         Also removes the non-parallel test running code. No reason for it to exist anymore.
1563
1564         This is a massive increase in test coverage. It uncovered bugs. I fixed two of them
1565         as part of this patch, and left three more as new bugzillas.
1566
1567         * Scripts/create-mozilla-js-test-list: Added.
1568         * Scripts/jsc-stress-test-helpers/check-mozilla-failure: Added.
1569         * Scripts/jsc-stress-test-helpers/layout-test-helper: Removed.
1570         * Scripts/run-javascriptcore-tests:
1571         * Scripts/run-jsc-stress-tests:
1572
1573 2013-10-05  Filip Pizlo  <fpizlo@apple.com>
1574
1575         run-jsc-stress-tests should be less verbose
1576         https://bugs.webkit.org/show_bug.cgi?id=122397
1577
1578         Reviewed by Sam Weinig.
1579
1580         It now just prints something like:
1581
1582          965/1831 ....
1583
1584         Where the first number is the number of tests that completed, the second number is the
1585         number of tests total, and the dots are the number of tests running right now - which is
1586         useful towards the end when you're waiting for the last slow tests to finish.
1587
1588         It will also print out the output from failing tests and it will print a line for skipped
1589         tests (to annoy you into getting them into a shape where they can be unskipped). For
1590         example, for LayoutTests, it will print just the diff, if the test fails. It's cool.
1591
1592         * Scripts/run-jsc-stress-tests:
1593
1594 2013-10-05  Filip Pizlo  <fpizlo@apple.com>
1595
1596         Allow skipping of run-jsc-stress-tests that are configured using yaml files
1597         https://bugs.webkit.org/show_bug.cgi?id=122385
1598
1599         Reviewed by Sam Wieinig.
1600
1601         Make tests run via YAML be able to do the parse-for-commands trick that allows
1602         us to skip tests and do other custom per-test stuff.
1603
1604         * Scripts/jsc-stress-test-helpers/layout-test-helper:
1605         * Scripts/run-jsc-stress-tests:
1606
1607 2013-10-05  Filip Pizlo  <fpizlo@apple.com>
1608
1609         Unreviewed, fix tests on older Rubies.
1610
1611         * Scripts/run-jsc-stress-tests:
1612
1613 2013-10-05  Anders Carlsson  <andersca@apple.com>
1614
1615         Don't filter the weak symbols.
1616
1617         * Scripts/check-for-weak-vtables-and-externals:
1618
1619 2013-10-04  Filip Pizlo  <fpizlo@apple.com>
1620
1621         Have run-javascriptcore-tests run JS LayoutTests using run-jsc-stress-tests so that it runs in parallel
1622         https://bugs.webkit.org/show_bug.cgi?id=122376
1623
1624         Reviewed by Mark Hahnenberg.
1625
1626         * Scripts/jsc-stress-test-helpers/layout-test-helper: Added.
1627         * Scripts/run-javascriptcore-tests:
1628         (printThingsFound):
1629         * Scripts/run-jsc-stress-tests:
1630
1631 2013-10-04  Filip Pizlo  <fpizlo@apple.com>
1632
1633         It should be even easier to run and debug a failing JSC stress test
1634         https://bugs.webkit.org/show_bug.cgi?id=122337
1635
1636         Reviewed by Oliver Hunt.
1637
1638         If a test fails, you can now just say:
1639
1640         sh WebKitBuild/Debug/jsc-stress-results/regress/script-tests/emscripten-cube2hash.js.ftl-eager-no-cjit
1641
1642         and get the reproduction. You don't have to set any environment variables like before.
1643         Also if you want to debug the failing test you can now just say:
1644
1645         sh WebKitBuild/Debug/jsc-stress-results/regress/script-tests/emscripten-cube2hash.js.ftl-eager-no-cjit lldb --
1646
1647         Broadly, any arguments passed to the reproduction script are prepended to the command to
1648         run the test. This is sort of quirky and won't work for some tests (for example the
1649         profiler tests run a ruby script that runs some other stuff) but it'll work for most of
1650         them and that's good enough for now.
1651
1652         * Scripts/run-jsc-stress-tests:
1653
1654 2013-10-04  Brent Fulgham  <bfulgham@apple.com>
1655
1656         [Windows] Correct run-path when using 64-bit binaries.
1657
1658         Reviewed by David Kilzer.
1659
1660         * Scripts/webkitdirs.pm:
1661         (determineConfigurationProductDir): If running in 64-bit mode, use the 'bin64'
1662         directory. Otherwise use the existing 'bin32' directory.
1663
1664 2013-10-04  Brent Fulgham  <bfulgham@apple.com>
1665
1666         Teach webkitdirs.pm to honor the --64-bit flag
1667         https://bugs.webkit.org/show_bug.cgi?id=122357
1668
1669         Reviewed by David Kilzer.
1670
1671         * Scripts/webkitdirs.pm:
1672         (argumentsForConfiguration): Modify to check if --64-bit is supplied
1673         by the user.
1674         (findMatchingArguments): Added.
1675         (hasArgument): Added.
1676         (checkForArgumentAndRemoveFromArrayRef): Refactor to use the new
1677         findMatchingArguments subroutine.
1678
1679 2013-10-04  Alexey Proskuryakov  <ap@apple.com>
1680
1681         Update svn-config for new Visual Studio extensions
1682         https://bugs.webkit.org/show_bug.cgi?id=122344
1683
1684         Reviewed by Brent Fulgham.
1685
1686         * svn-config: Add new Visual Studio extensions.
1687
1688 2013-10-04  Alex Christensen  <achristensen@webkit.org>
1689
1690         Made WinLauncher have better error handling, crash reporting, and modifiability.
1691         https://bugs.webkit.org/show_bug.cgi?id=122319
1692
1693         Reviewed by Brent Fulgham.
1694
1695         * WinLauncher/WinLauncher.cpp:
1696         (WinLauncherWebHost::didFailProvisionalLoadWithError):
1697         Don't display the numerous "Cancelled" messages that are obviously from the user.
1698         (createCrashReport): Added.
1699         (dllLauncherEntryPoint):
1700         Made main loop back into while loop and write a crash report if it crashes.
1701         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
1702         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters:
1703         Added WinLauncherReplace.h.
1704         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props:
1705         Added linking to DbgHelp.lib.
1706         * WinLauncher/WinLauncherReplace.h:
1707         Added to make modifying WinLauncher behaviour and appearance easy.
1708         (processCrashDump): Added.
1709
1710 2013-10-04  Dirk Pranke  <dpranke@chromium.org>
1711
1712         remove dpranke from webkitpy watchlist
1713         https://bugs.webkit.org/show_bug.cgi?id=122331
1714
1715         Reviewed by Brent Fulgham.
1716
1717         * Scripts/webkitpy/common/config/watchlist:
1718
1719 2013-10-04  Tim Horton  <timothy_horton@apple.com>
1720
1721         [mac][wk2] ScrollPinningBehaviors, SpacebarScrolling, and ScrollByLineCommands fail after r156793
1722         https://bugs.webkit.org/show_bug.cgi?id=122299
1723
1724         Reviewed by Beth Dakin.
1725
1726         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
1727         * TestWebKitAPI/Tests/WebKit2/mac/EditorCommands.mm:
1728         The last fix didn't work; instead of trying to block, turn off threaded scrolling for all three tests.
1729
1730 2013-10-04  Alexey Proskuryakov  <ap@apple.com>
1731
1732         Watchlist is broken after <http://trac.webkit.org/r156880>
1733
1734         * Scripts/webkitpy/common/config/watchlist: Remove an incorrect change.
1735
1736 2013-10-04  Brent Fulgham  <bfulgham@apple.com>
1737
1738         Remove Qt features from build and test tools
1739         https://bugs.webkit.org/show_bug.cgi?id=122312
1740
1741         Reviewed by Anders Carlsson.
1742
1743         * Scripts/build-dumprendertree:
1744         * Scripts/build-jsc:
1745         * Scripts/build-webkit:
1746         * Scripts/build-webkittestrunner:
1747         * Scripts/old-run-webkit-tests:
1748         (openDumpTool):
1749         (buildPlatformResultHierarchy):
1750         (buildPlatformTestHierarchy):
1751         (readSkippedFiles):
1752         * Scripts/run-launcher:
1753         * Scripts/run-qtwebkit-tests: Removed.
1754         * Scripts/run-webkit-tests:
1755         (useNewRunWebKitTests):
1756         * Scripts/update-webkit:
1757         * Scripts/webkit-build-directory:
1758         * Scripts/webkitdirs.pm:
1759         (argumentsForConfiguration):
1760         (jscProductDir):
1761         (builtDylibPathForName):
1762         (isAppleWebKit):
1763         (launcherPath):
1764         (launcherName):
1765         (checkRequiredSystemConfig):
1766         (setupCygwinEnv):
1767         (copyInspectorFrontendFiles):
1768         (setPathForRunningWebKitApp):
1769         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
1770         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
1771         (BaselineOptimizerTest.test_mac_future):
1772         (BaselineOptimizerTest.test_win_does_not_drop_to_win_7sp0):
1773         (BaselineOptimizerTest.test_common_directory_includes_root):
1774         (BaselineOptimizerTest.test_virtual_ports_filtered):
1775         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1776         (test_parse_reviewer_text):
1777         * Scripts/webkitpy/common/config/watchlist:
1778         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1779         (PortTest.disabled_test_chromium_mac_lion_in_test_shell_mode):
1780         * Scripts/webkitpy/port/base.py:
1781         (Port.__init__):
1782         (Port._port_flag_for_scripts):
1783         (Port._wk2_port_name):
1784         * Scripts/webkitpy/port/builders.py:
1785         * Scripts/webkitpy/port/factory.py:
1786         (platform_options):
1787         (PortFactory):
1788         (PortFactory._default_port):
1789         * Scripts/webkitpy/port/factory_unittest.py:
1790         (FactoryTest.test_gtk):
1791         * Scripts/webkitpy/port/qt.py: Removed.
1792         * Scripts/webkitpy/port/qt_unittest.py: Removed.
1793         * Scripts/webkitpy/style/checker.py:
1794         * Scripts/webkitpy/style/checker_unittest.py:
1795         (GlobalVariablesTest.test_path_rules_specifier):
1796         * Scripts/webkitpy/style/checkers/cmake.py:
1797         (CMakeChecker):
1798         * Scripts/webkitpy/style/checkers/cpp.py:
1799         (_classify_include):
1800         (check_include_line):
1801         (check_identifier_name_in_declaration):
1802         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1803         (OrderOfIncludesTest.test_classify_include):
1804         (WebKitStyleTest.test_names):
1805         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1806         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
1807         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1808         (TestRebaselineTest.test_baseline_directory):
1809         * Scripts/webkitpy/tool/main.py:
1810         (WebKitPatch):
1811
1812 2013-10-03  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1813
1814         Unreviewed. Add myself to some watchlists.
1815
1816         * Scripts/webkitpy/common/config/watchlist:
1817
1818 2013-10-03  Ryosuke Niwa  <rniwa@webkit.org>
1819
1820         Remove Qt builders from the flakiness dashboard.
1821
1822         * TestResultServer/static-dashboards/builders.jsonp:
1823         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1824         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1825         * TestResultServer/static-dashboards/loader_unittests.js:
1826
1827 2013-10-03  Tim Horton  <timothy_horton@apple.com>
1828
1829         [mac][wk2] ScrollPinningBehaviors, SpacebarScrolling, and ScrollByLineCommands fail after r156793
1830         https://bugs.webkit.org/show_bug.cgi?id=122299
1831
1832         Reviewed by Beth Dakin.
1833
1834         * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:
1835         Disable threaded scrolling.
1836
1837         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
1838         * TestWebKitAPI/Tests/WebKit2/mac/EditorCommands.mm:
1839         Synchronously wait for the scrolling thread to inform the main thread of the new scroll position.
1840
1841 2013-10-03  Anders Carlsson  <andersca@apple.com>
1842
1843         Use numeric strings in the OS version dictionary
1844         https://bugs.webkit.org/show_bug.cgi?id=122300
1845
1846         Reviewed by Mark Rowe.
1847
1848         * Scripts/webkitpy/common/system/platforminfo.py:
1849         (PlatformInfo._determine_mac_version):
1850
1851 2013-10-03  Alexey Proskuryakov  <ap@apple.com>
1852
1853         Fix LeaksViewer to load leaks results from MountainLion, not Lion.
1854
1855         Rubber-stamped by Tim Horton.
1856
1857         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
1858         (LeaksViewer._displayURLPrompt):
1859
1860 2013-10-03  Dan Bernstein  <mitz@apple.com>
1861
1862         REGRESSION (r156811): Objective-C JavaScriptCore API test failing on Mountain Lion bots
1863         https://bugs.webkit.org/show_bug.cgi?id=122260
1864
1865         Reviewed by Alexey Proskuryakov.
1866
1867         For the API to work, the tests need to be compiled with a newer version of the LLVM
1868         compiler. Until the bots are updated to that version, disable the tests on 10.8.
1869
1870         * TestWebKitAPI/Tests/mac/WebViewDidCreateJavaScriptContext.mm:
1871
1872 2013-10-02  Mario Sanchez Prada  <mario.prada@samsung.com>
1873
1874         [ATK] Expose aria-invalid as a text attribute (not object attribute)
1875         https://bugs.webkit.org/show_bug.cgi?id=122015
1876
1877         Reviewed by Chris Fleizach.
1878
1879         Adapted DRT and WKTR to check the exposure of the aria-invalid
1880         attribute as a text attribute, instead of an object attribute.
1881
1882         Also, done some refactoring of the code to try to keep things
1883         simpler and more coherent, by defining new helper functions,
1884         simplifying code, moving static variables and functions into
1885         unnammed namespaces and so on, without altering the logic other
1886         than for checking the text attribute for aria-invalid.
1887
1888         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1889         (coreAttributeToAtkAttribute): Consider 'invalid' as the name of
1890         the attribute exposed by the ATK wrapper, not 'aria-invalid'.
1891         Also, never return an empty string if not falling through any of
1892         the cases checked here, and return the original attribute instead.
1893         (atkAttributeValueToCoreAttributeValue): New helper function to
1894         match the attributes values returned by the ATK wrapper with the
1895         values expected by the layout tests. Moved the mappings for the
1896         values of AXSortDirection here as well.
1897         (getAttributeSet): New helper function to retrieve a list of
1898         attributes (an AtkAttributeSet) from an AtkObject using the right
1899         API depending on whether we want the object attributes or the text
1900         attributes (in case the object implements AtkText).
1901         (getAttributeSetValueForId): Simplified by using getAttributeSet
1902         and atkAttributeValueToCoreAttributeValue. Also, added a new
1903         parameter to indicater whether we are interested in object
1904         attributes or text attributes.
1905         (getAtkAttributeSetAsString): Ditto.
1906         (attributesOfElement): Updated to pass the new required parameter
1907         to getAtkAttributeSetAsString, indicating that we want the object
1908         attributes in this case, for backwards compatibility.
1909         (indexRangeInTable): Moved up in the file into the unnammed namespace.
1910         (alterCurrentValue): Ditto.
1911         (AccessibilityUIElement::stringAttributeValue): After moving most
1912         of the code here to the new helper functions, simplified it by
1913         just checking whether the required attribute is provided as an
1914         object attribute or, if that's not the case, as a text attribute.
1915         (AccessibilityUIElement::isAttributeSupported): Ditto.
1916         (AccessibilityUIElement::intValue): Updated to pass the new
1917         required parameter to getAttributeSetValueForId, indicating that
1918         we want the object attributes in this case.
1919         (AccessibilityUIElement::hasPopup): Ditto.
1920
1921         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1922         (WTR::coreAttributeToAtkAttribute): Same changes than for DRT.
1923         (WTR::atkAttributeValueToCoreAttributeValue): Ditto.
1924         (WTR::getAttributeSet): Ditto.
1925         (WTR::getAttributeSetValueForId): Ditto.
1926         (WTR::getAtkAttributeSetAsString): Ditto.
1927         (WTR::attributesOfElement): Ditto.
1928         (WTR::AccessibilityUIElement::stringAttributeValue): Ditto.
1929         (WTR::AccessibilityUIElement::isAttributeSupported): Ditto.
1930         (WTR::AccessibilityUIElement::intValue): Ditto.
1931         (WTR::AccessibilityUIElement::hasPopup): Ditto.
1932
1933 2013-10-02  Ryosuke Niwa  <rniwa@webkit.org>
1934
1935         EWS build fix after the Qt EWS removal.
1936
1937         * QueueStatusServer/model/attachment.py:
1938         (Attachment._calculate_queue_positions):
1939
1940 2013-10-02  Anders Carlsson  <andersca@apple.com>
1941
1942         Remove Qt code from Tools/
1943         https://bugs.webkit.org/show_bug.cgi?id=122227
1944
1945         Reviewed by Andreas Kling.
1946
1947         * DumpRenderTree/WorkQueue.cpp:
1948         * DumpRenderTree/blackberry/src.pro: Removed.
1949         * DumpRenderTree/qt/DumpRenderTree.pro: Removed.
1950         * DumpRenderTree/qt/DumpRenderTree.qrc: Removed.
1951         * DumpRenderTree/qt/DumpRenderTreeMain.cpp: Removed.
1952         * DumpRenderTree/qt/DumpRenderTreeQt.cpp: Removed.
1953         * DumpRenderTree/qt/DumpRenderTreeQt.h: Removed.
1954         * DumpRenderTree/qt/EventSenderQt.cpp: Removed.
1955         * DumpRenderTree/qt/EventSenderQt.h: Removed.
1956         * DumpRenderTree/qt/GCControllerQt.cpp: Removed.
1957         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Removed.
1958         * DumpRenderTree/qt/TestRunnerQt.cpp: Removed.
1959         * DumpRenderTree/qt/TestRunnerQt.h: Removed.
1960         * DumpRenderTree/qt/TextInputControllerQt.cpp: Removed.
1961         * DumpRenderTree/qt/TextInputControllerQt.h: Removed.
1962         * DumpRenderTree/qt/WorkQueueItemQt.cpp: Removed.
1963         * DumpRenderTree/qt/WorkQueueItemQt.h: Removed.
1964         * DumpRenderTree/qt/fonts/AHEM____.TTF: Removed.
1965         * DumpRenderTree/qt/resources/user.css: Removed.
1966         * DumpRenderTree/qt/testplugin.cpp: Removed.
1967         * DumpRenderTree/qt/testplugin.h: Removed.
1968         * ImageDiff/ImageDiff.pro: Removed.
1969         * ImageDiff/qt/ImageDiff.cpp: Removed.
1970         * MiniBrowser/qt/BrowserWindow.cpp: Removed.
1971         * MiniBrowser/qt/BrowserWindow.h: Removed.
1972         * MiniBrowser/qt/MiniBrowser.pro: Removed.
1973         * MiniBrowser/qt/MiniBrowser.qrc: Removed.
1974         * MiniBrowser/qt/MiniBrowserApplication.cpp: Removed.
1975         * MiniBrowser/qt/MiniBrowserApplication.h: Removed.
1976         * MiniBrowser/qt/UrlLoader.cpp: Removed.
1977         * MiniBrowser/qt/UrlLoader.h: Removed.
1978         * MiniBrowser/qt/icons/checkbox_checked.png: Removed.
1979         * MiniBrowser/qt/icons/checkbox_unchecked.png: Removed.
1980         * MiniBrowser/qt/icons/contents_width.png: Removed.
1981         * MiniBrowser/qt/icons/favicon.png: Removed.
1982         * MiniBrowser/qt/icons/find.png: Removed.
1983         * MiniBrowser/qt/icons/folder.png: Removed.
1984         * MiniBrowser/qt/icons/info.png: Removed.
1985         * MiniBrowser/qt/icons/next.png: Removed.
1986         * MiniBrowser/qt/icons/plus.png: Removed.
1987         * MiniBrowser/qt/icons/previous.png: Removed.
1988         * MiniBrowser/qt/icons/refresh.png: Removed.
1989         * MiniBrowser/qt/icons/stop.png: Removed.
1990         * MiniBrowser/qt/icons/titlebar.png: Removed.
1991         * MiniBrowser/qt/icons/touch.png: Removed.
1992         * MiniBrowser/qt/icons/touchpoint.png: Removed.
1993         * MiniBrowser/qt/icons/up.png: Removed.
1994         * MiniBrowser/qt/js/MultiSelect.js: Removed.
1995         * MiniBrowser/qt/main.cpp: Removed.
1996         * MiniBrowser/qt/qml/AlertDialog.qml: Removed.
1997         * MiniBrowser/qt/qml/AuthenticationDialog.qml: Removed.
1998         * MiniBrowser/qt/qml/BrowserWindow.qml: Removed.
1999         * MiniBrowser/qt/qml/CheckBox.qml: Removed.
2000         * MiniBrowser/qt/qml/ColorChooser.qml: Removed.
2001         * MiniBrowser/qt/qml/ConfirmDialog.qml: Removed.
2002         * MiniBrowser/qt/qml/Dialog.qml: Removed.
2003         * MiniBrowser/qt/qml/DialogButton.qml: Removed.
2004         * MiniBrowser/qt/qml/DialogLineInput.qml: Removed.
2005         * MiniBrowser/qt/qml/FilePicker.qml: Removed.
2006         * MiniBrowser/qt/qml/ItemSelector.qml: Removed.
2007         * MiniBrowser/qt/qml/MockTouchPoint.qml: Removed.
2008         * MiniBrowser/qt/qml/PromptDialog.qml: Removed.
2009         * MiniBrowser/qt/qml/ProxyAuthenticationDialog.qml: Removed.
2010         * MiniBrowser/qt/qml/ScrollIndicator.qml: Removed.
2011         * MiniBrowser/qt/qml/ViewportInfoItem.qml: Removed.
2012         * MiniBrowser/qt/raw/DerivedSources.pri: Removed.
2013         * MiniBrowser/qt/raw/MiniBrowserRaw.pro: Removed.
2014         * MiniBrowser/qt/raw/Target.pri: Removed.
2015         * MiniBrowser/qt/raw/View.cpp: Removed.
2016         * MiniBrowser/qt/raw/View.h: Removed.
2017         * MiniBrowser/qt/utils.cpp: Removed.
2018         * MiniBrowser/qt/utils.h: Removed.
2019         * QtTestBrowser/QtTestBrowser.pro: Removed.
2020         * QtTestBrowser/QtTestBrowser.qrc: Removed.
2021         * QtTestBrowser/cookiejar.cpp: Removed.
2022         * QtTestBrowser/cookiejar.h: Removed.
2023         * QtTestBrowser/favicon.png: Removed.
2024         * QtTestBrowser/fpstimer.cpp: Removed.
2025         * QtTestBrowser/fpstimer.h: Removed.
2026         * QtTestBrowser/launcherwindow.cpp: Removed.
2027         * QtTestBrowser/launcherwindow.h: Removed.
2028         * QtTestBrowser/locationedit.cpp: Removed.
2029         * QtTestBrowser/locationedit.h: Removed.
2030         * QtTestBrowser/mainwindow.cpp: Removed.
2031         * QtTestBrowser/mainwindow.h: Removed.
2032         * QtTestBrowser/qttestbrowser.cpp: Removed.
2033         * QtTestBrowser/urlloader.cpp: Removed.
2034         * QtTestBrowser/urlloader.h: Removed.
2035         * QtTestBrowser/useragentlist.txt: Removed.
2036         * QtTestBrowser/utils.cpp: Removed.
2037         * QtTestBrowser/utils.h: Removed.
2038         * QtTestBrowser/webinspector.h: Removed.
2039         * QtTestBrowser/webpage.cpp: Removed.
2040         * QtTestBrowser/webpage.h: Removed.
2041         * QtTestBrowser/webview.cpp: Removed.
2042         * QtTestBrowser/webview.h: Removed.
2043         * TestWebKitAPI/DerivedSources.pri: Removed.
2044         * TestWebKitAPI/InjectedBundle.pri: Removed.
2045         * TestWebKitAPI/PlatformWebView.h:
2046         * TestWebKitAPI/TestWebKitAPI.pri: Removed.
2047         * TestWebKitAPI/TestWebKitAPI.pro: Removed.
2048         * TestWebKitAPI/Tests.pri: Removed.
2049         * TestWebKitAPI/Tests/JavaScriptCore/JavaScriptCore.pro: Removed.
2050         * TestWebKitAPI/Tests/WTF/IntegerToStringConversion.cpp:
2051         * TestWebKitAPI/Tests/WTF/WTF.pro: Removed.
2052         * TestWebKitAPI/Tests/WebKit2/WebKit2.pro: Removed.
2053         * TestWebKitAPI/qt/InjectedBundleControllerQt.cpp: Removed.
2054         * TestWebKitAPI/qt/PlatformUtilitiesQt.cpp: Removed.
2055         * TestWebKitAPI/qt/PlatformWebViewQt.cpp: Removed.
2056         * TestWebKitAPI/qt/main.cpp: Removed.
2057         * Tools.pro: Removed.
2058         * WebKitTestRunner/DerivedSources.pri: Removed.
2059         * WebKitTestRunner/EventSenderProxy.h:
2060         * WebKitTestRunner/InjectedBundle/DerivedSources.pri: Removed.
2061         * WebKitTestRunner/InjectedBundle/InjectedBundle.pro: Removed.
2062         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2063         (WTR::InjectedBundlePage::resetAfterTest):
2064         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
2065         (WTR::InjectedBundlePage::didClearWindowForFrame):
2066         * WebKitTestRunner/InjectedBundle/Target.pri: Removed.
2067         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2068         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp: Removed.
2069         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp: Removed.
2070         * WebKitTestRunner/InjectedBundle/qt/TestRunnerQt.cpp: Removed.
2071         * WebKitTestRunner/PlatformWebView.h:
2072         * WebKitTestRunner/Target.pri: Removed.
2073         * WebKitTestRunner/TestController.cpp:
2074         (WTR::TestController::resetStateToConsistentValues):
2075         * WebKitTestRunner/TestController.h:
2076         * WebKitTestRunner/WebKitTestRunner.pro: Removed.
2077         * WebKitTestRunner/qt/EventSenderProxyQt.cpp: Removed.
2078         * WebKitTestRunner/qt/PlatformWebViewQt.cpp: Removed.
2079         * WebKitTestRunner/qt/TestControllerQt.cpp: Removed.
2080         * WebKitTestRunner/qt/TestInvocationQt.cpp: Removed.
2081         * WebKitTestRunner/qt/WebKitTestRunner.qrc: Removed.
2082         * WebKitTestRunner/qt/main.cpp: Removed.
2083         * WebKitTestRunner/qt/resources/user.css: Removed.
2084         * qmake/.qmake.cache: Removed.
2085         * qmake/.qmake.conf: Removed.
2086         * qmake/README: Removed.
2087         * qmake/config.tests/README: Removed.
2088         * qmake/config.tests/fontconfig/fontconfig.cpp: Removed.
2089         * qmake/config.tests/fontconfig/fontconfig.pro: Removed.
2090         * qmake/config.tests/gccdepends/empty.cpp: Removed.
2091         * qmake/config.tests/gccdepends/gccdepends.pro: Removed.
2092         * qmake/config.tests/glx/glx.cpp: Removed.
2093         * qmake/config.tests/glx/glx.pro: Removed.
2094         * qmake/config.tests/gnuld/gnuld.pro: Removed.
2095         * qmake/config.tests/gnuld/main.cpp: Removed.
2096         * qmake/config.tests/libXcomposite/libXcomposite.cpp: Removed.
2097         * qmake/config.tests/libXcomposite/libXcomposite.pro: Removed.
2098         * qmake/config.tests/libXrender/libXrender.cpp: Removed.
2099         * qmake/config.tests/libXrender/libXrender.pro: Removed.
2100         * qmake/config.tests/libwebp/libwebp.cpp: Removed.
2101         * qmake/config.tests/libwebp/libwebp.pro: Removed.
2102         * qmake/config.tests/libxml2/libxml2.cpp: Removed.
2103         * qmake/config.tests/libxml2/libxml2.pro: Removed.
2104         * qmake/config.tests/libxslt/libxslt.cpp: Removed.
2105         * qmake/config.tests/libxslt/libxslt.pro: Removed.
2106         * qmake/config.tests/libzlib/libzlib.cpp: Removed.
2107         * qmake/config.tests/libzlib/libzlib.pro: Removed.
2108         * qmake/dump-features.pl: Removed.
2109         * qmake/mkspecs/features/configure.prf: Removed.
2110         * qmake/mkspecs/features/default_post.prf: Removed.
2111         * qmake/mkspecs/features/default_pre.prf: Removed.
2112         * qmake/mkspecs/features/features.prf: Removed.
2113         * qmake/mkspecs/features/features.pri: Removed.
2114         * qmake/mkspecs/features/force_static_libs_as_shared.prf: Removed.
2115         * qmake/mkspecs/features/functions.prf: Removed.
2116         * qmake/mkspecs/features/gprof.prf: Removed.
2117         * qmake/mkspecs/features/mac/default_post.prf: Removed.
2118         * qmake/mkspecs/features/mac/default_pre.prf: Removed.
2119         * qmake/mkspecs/features/minimal_qt.prf: Removed.
2120         * qmake/mkspecs/features/production_build.prf: Removed.
2121         * qmake/mkspecs/features/rpath.prf: Removed.
2122         * qmake/mkspecs/features/unix/default_post.prf: Removed.
2123         * qmake/mkspecs/features/unix/default_pre.prf: Removed.
2124         * qmake/mkspecs/features/unix/icc.prf: Removed.
2125         * qmake/mkspecs/features/use_all_in_one_files.prf: Removed.
2126         * qmake/mkspecs/features/valgrind.prf: Removed.
2127         * qmake/mkspecs/features/webkit_modules.prf: Removed.
2128         * qmake/mkspecs/features/win32/default_post.prf: Removed.
2129         * qmake/mkspecs/features/win32/default_pre.prf: Removed.
2130         * qmake/mkspecs/modules/angle.prf: Removed.
2131         * qmake/mkspecs/modules/javascriptcore.prf: Removed.
2132         * qmake/mkspecs/modules/webcore.prf: Removed.
2133         * qmake/mkspecs/modules/webkit1.prf: Removed.
2134         * qmake/mkspecs/modules/webkit2.prf: Removed.
2135         * qmake/mkspecs/modules/wtf.prf: Removed.
2136
2137 2013-10-02  Tim Horton  <timothy_horton@apple.com>
2138
2139         [mac] Stop using DrawingAreaImpl on PLATFORM(MAC)
2140         https://bugs.webkit.org/show_bug.cgi?id=121859
2141         <rdar://problem/15069359>
2142
2143         Reviewed by Anders Carlsson.
2144
2145         * WebKitTestRunner/TestInvocation.cpp:
2146         (WTR::shouldUseThreadedScrolling):
2147         (WTR::updateThreadedScrollingForCurrentTest):
2148         (WTR::TestInvocation::invoke):
2149         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2150         (-[TestRunnerWKView initWithFrame:contextRef:pageGroupRef:relatedToPage:useThreadedScrolling:]):
2151         (WTR::PlatformWebView::PlatformWebView):
2152         (WTR::PlatformWebView::viewSupportsOptions):
2153         Rename the tiled drawing switch to threaded scrolling, since that's really
2154         all it switches now that we use tiled drawing everywhere.
2155
2156         Use an unbuffered window, as well, to avoid snapshotting issues on some platforms
2157         and to more closely match the case we're interested in testing.
2158
2159 2013-10-02  Anders Carlsson  <andersca@apple.com>
2160
2161         Move AHEM____.TTF from qt/fonts/ to fonts/.
2162
2163         Rubber-stamped by Andreas Kling.
2164
2165         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2166         * DumpRenderTree/fonts/AHEM____.TTF: Renamed from Tools/DumpRenderTree/qt/fonts/AHEM____.TTF.
2167
2168 2013-10-02  Ádám Kallai  <kadam@inf.u-szeged.hu>
2169
2170         Remove Qt bots and EWS from trunk.
2171         https://bugs.webkit.org/show_bug.cgi?id=122210.
2172
2173         Reviewed by Allan Sandfeld Jensen.
2174
2175         Remove Qt buil dbots.
2176
2177         * BuildSlaveSupport/build.webkit.org-config/config.json:
2178         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2179         (appendCustomBuildFlags):
2180         (RunGtkAPITests.getText2):
2181         (Factory.__init__):
2182         (TestFactory.__init__):
2183         (BuildAndTestFactory.__init__):
2184         (loadBuilderConfig):
2185         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2186
2187 2013-10-02  Ádám Kallai  <kadam@inf.u-szeged.hu>
2188
2189         Remove Qt bots and EWS from trunk.
2190         https://bugs.webkit.org/show_bug.cgi?id=122210.
2191
2192         Reviewed by Allan Sandfeld Jensen.
2193
2194         Remove Qt EWS bots.
2195
2196         * QueueStatusServer/config/queues.py:
2197         * Scripts/webkitpy/common/config/ews.json:
2198
2199 2013-10-01  Timothy Hatcher  <timothy@apple.com>
2200
2201         Fix singular labels for test failures.
2202
2203         https://bugs.webkit.org/show_bug.cgi?id=122200
2204
2205         Reviewed by Joseph Pecoraro.
2206
2207         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2208         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
2209
2210 2013-10-01  Timothy Hatcher  <timothy@apple.com>
2211
2212         Don't keep appending iterations each time the queue updates.
2213
2214         https://bugs.webkit.org/show_bug.cgi?id=122198
2215
2216         Reviewed by Joseph Pecoraro.
2217
2218         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2219         (BuildbotQueue.prototype.update):
2220
2221 2013-10-01  Timothy Hatcher  <timothy@apple.com>
2222
2223         Properly sort iterations in the Dashboard by revision for out-of-order queues.
2224
2225         https://bugs.webkit.org/show_bug.cgi?id=122196
2226
2227         Reviewed by Brent Fulgham.
2228
2229         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2230         (BuildbotIteration):
2231         (BuildbotIteration.prototype.update):
2232         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2233         (BuildbotQueue.prototype.update):
2234         (BuildbotQueue.prototype.sortIterations):
2235
2236 2013-10-01  Timothy Hatcher  <timothy@apple.com>
2237
2238         Fix some exceptions seen in the Buildbot Dashboard when looking at unloaded iterations.
2239
2240         Also fix some URLs to not have extras slashes and add a page title.
2241
2242         https://bugs.webkit.org/show_bug.cgi?id=122192
2243
2244         Reviewed by Joseph Pecoraro.
2245
2246         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2247         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
2248         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2249         (WebKitBuildbot.prototype.buildLogURLForIteration):
2250         (WebKitBuildbot.prototype.layoutTestResultsURLForIteration):
2251         (WebKitBuildbot.prototype.javascriptTestResultsURLForIteration):
2252         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
2253
2254 2013-10-01  Alexey Proskuryakov  <ap@apple.com>
2255
2256         [Mac] Set NSApplication current event while sending events directly to views
2257         https://bugs.webkit.org/show_bug.cgi?id=122179
2258
2259         Reviewed by Darin Adler.
2260
2261         DumpRenderTree and WebKitTestRunner send events directly to WebHMTLView or WKView,
2262         which doesn't update [NSApp currentEvent]. But there are many places in WebKit that
2263         use the current event.
2264
2265         * DumpRenderTree/mac/EventSendingController.mm:
2266         (-[EventSendingController mouseDown:withModifiers:]):
2267         (-[EventSendingController mouseUp:withModifiers:]):
2268         (-[EventSendingController mouseMoveToX:Y:]):
2269         (-[EventSendingController mouseScrollByX:andY:continuously:]):
2270         (-[EventSendingController contextClick]):
2271         (-[EventSendingController keyDown:withModifiers:withLocation:]):
2272         * WebKitTestRunner/mac/EventSenderProxy.mm:
2273         (WTR::EventSenderProxy::mouseDown):
2274         (WTR::EventSenderProxy::mouseUp):
2275         (WTR::EventSenderProxy::mouseMoveTo):
2276         (WTR::EventSenderProxy::keyDown):
2277         (WTR::EventSenderProxy::mouseScrollBy):
2278         Update the current event. We were already using the SPI in WebKit.
2279
2280 2013-10-01  Joseph Pecoraro  <pecoraro@apple.com>
2281
2282         Buildbot Dashboard: Fix JSHint issue: 'perlTestResults' used out of scope.
2283         https://bugs.webkit.org/show_bug.cgi?id=122183
2284
2285         Reviewed by Timothy Hatcher.
2286
2287         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2288         (BuildbotIteration.prototype.update):
2289
2290 2013-10-01  Timothy Hatcher  <timothy@apple.com>
2291
2292         Tweaks to the Buildbot Dashboard
2293
2294         https://bugs.webkit.org/show_bug.cgi?id=122169
2295
2296         Reviewed by Alexey Proskuryakov.
2297
2298         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
2299         (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus):
2300         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2301         (BuildbotQueueView.prototype.revisionLinksForIteration):
2302         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2303         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
2304         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js: Added.
2305         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
2306         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2307         (WebKitBuildbot.prototype.buildLogURLForIteration):
2308         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
2309
2310 2013-10-01  Commit Queue  <commit-queue@webkit.org>
2311
2312         Unreviewed, rolling out r156725.
2313         http://trac.webkit.org/changeset/156725
2314         https://bugs.webkit.org/show_bug.cgi?id=122176
2315
2316         broke all the mismatch tests again (Requested by thorton on
2317         #webkit).
2318
2319         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2320         (WTR::PlatformWebView::PlatformWebView):
2321
2322 2013-10-01  Alex Christensen  <achristensen@webkit.org>
2323
2324         Implemented createWebViewWithRequest in WinLauncher.
2325         https://bugs.webkit.org/show_bug.cgi?id=122069
2326
2327         Reviewed by Brent Fulgham.
2328
2329         * WinLauncher/PrintWebUIDelegate.cpp:
2330         (PrintWebUIDelegate::createWebViewWithRequest): Added.
2331         * WinLauncher/PrintWebUIDelegate.h:
2332         Removed createWebViewWithRequest stub.
2333
2334 2013-10-01  Tim Horton  <timothy_horton@apple.com>
2335
2336         [wk2] WebKitTestRunner's window snapshots are blank with tiled drawing
2337         https://bugs.webkit.org/show_bug.cgi?id=122006
2338         <rdar://problem/15095197>
2339
2340         Reviewed by Dean Jackson.
2341
2342         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2343         (WTR::PlatformWebView::PlatformWebView):
2344         Layer-back the root view in WebKitTestRunner's window, to work around a bug
2345         where the window server snapshot API returns blank snapshots.
2346
2347         Re-landing after r156724, this should not break everything now.
2348
2349 2013-10-01  Tim Horton  <timothy_horton@apple.com>
2350
2351         [mac] 1x emulation on Retina hardware shouldn't use SPI
2352         https://bugs.webkit.org/show_bug.cgi?id=122152
2353         <rdar://problem/15119384>
2354
2355         Reviewed by Anders Carlsson.
2356
2357         * DumpRenderTree/mac/DumpRenderTree.mm:
2358         (createWebViewAndOffscreenWindow):
2359         (main):
2360         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
2361         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
2362         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2363         (WTR::PlatformWebView::PlatformWebView):
2364         * WebKitTestRunner/mac/main.mm:
2365         (main):
2366         Register for AppleMagnifiedMode instead of using _setWindowResolution:displayIfChanged:.
2367
2368 2013-09-30  Sam Weinig  <sam@webkit.org>
2369
2370         check-webkit-style should not warn about use of C++11 “>>”  instead of “> >"
2371         https://bugs.webkit.org/show_bug.cgi?id=116474
2372
2373         Reviewed by Ryosuke Niwa.
2374
2375         * Scripts/webkitpy/style/checkers/cpp.py:
2376         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2377
2378 2013-09-30  Sam Weinig  <sam@webkit.org>
2379
2380         Remove support for DOMFileSystem
2381         https://bugs.webkit.org/show_bug.cgi?id=122137
2382
2383         Reviewed by Anders Carlsson.
2384
2385         * Scripts/webkitperl/FeatureList.pm:
2386         * Scripts/webkitpy/style/checkers/cpp.py:
2387         (check_spacing):
2388         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2389         (CppStyleTest.test_spacing_for_binary_ops):
2390         * qmake/mkspecs/features/features.pri:
2391
2392 2013-09-30  Mark Rowe  <mrowe@apple.com>
2393
2394         More build fixage for builds with SDKs.
2395
2396         * WebKitTestRunner/Configurations/Base.xcconfig:
2397         * WebKitTestRunner/Configurations/BaseTarget.xcconfig:
2398
2399 2013-09-30  Timothy Hatcher  <timothy@apple.com>
2400
2401         Add initial version of a new Buildbot dashboard view.
2402
2403         https://bugs.webkit.org/show_bug.cgi?id=122131
2404
2405         Reviewed by Alexey Proskuryakov.
2406
2407         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Lion.png: Added.
2408         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Lion@2x.png: Added.
2409         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mavericks.png: Added.
2410         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mavericks@2x.png: Added.
2411         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion.png: Added.
2412         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion@2x.png: Added.
2413         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/PlatformRing.png: Added.
2414         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/PlatformRing@2x.png: Added.
2415         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows7.png: Added.
2416         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows7@2x.png: Added.
2417         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows8.png: Added.
2418         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows8@2x.png: Added.
2419         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WindowsXP.png: Added.
2420         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WindowsXP@2x.png: Added.
2421         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BaseObject.js: Added.
2422         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js: Added.
2423         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js: Added.
2424         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: Added.
2425         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js: Added.
2426         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js: Added.
2427         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js: Added.
2428         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js: Added.
2429         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Added.
2430         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js: Added.
2431         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js: Added.
2432         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js: Added.
2433         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotBuilderQueueView.css: Added.
2434         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotQueueView.css: Added.
2435         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotTesterQueueView.css: Added.
2436         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css: Added.
2437         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css: Added.
2438         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html: Added.
2439
2440 2013-09-30  Benjamin Poulain  <benjamin@webkit.org>
2441
2442         Remove the code guarded by STYLE_SCOPED
2443         https://bugs.webkit.org/show_bug.cgi?id=122123
2444
2445         Reviewed by Anders Carlsson.
2446
2447         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2448         (resetDefaultsToConsistentValues):
2449         * Scripts/webkitperl/FeatureList.pm:
2450         * qmake/mkspecs/features/features.pri:
2451
2452 2013-09-30  Mark Rowe  <mrowe@apple.com>
2453
2454         Fix the build when building against an SDK.
2455
2456         Xcode helpfully prepends $(SDKROOT) to the paths in FRAMEWORK_SEARCH_PATHS when generating
2457         the compiler command lines. It can't know to do this for the system framework search paths
2458         we add manually via OTHER_CFLAGS though, so we need to prefix them with $(SDKROOT) ourself.
2459
2460         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig:
2461         * WebKitTestRunner/Configurations/BaseTarget.xcconfig:
2462
2463 2013-09-30  Brent Fulgham  <bfulgham@apple.com>
2464
2465         [Windows] Unreviewed test fix. Prevent crash when changing URL paths during testing.
2466
2467         A shared BSTR value (_bstr_t) was being reallocated outside the smart pointer, causing
2468         it to be double-freed.
2469
2470         * WinLauncher/WinLauncher.cpp:
2471         (EditProc): Be explicit about type passed to loadURL.
2472         (loadURL): Create a shallow copy of the BSTR so we only allocate memory if needed. Use _bstr_t so
2473         that reallocating the BSTR is done with the knowledge of the smart pointer.
2474
2475 2013-09-30  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2476
2477         [Qt] Fix force_static_libs_as_shared in WebKit2
2478         https://bugs.webkit.org/show_bug.cgi?id=121961
2479
2480         Reviewed by Csaba Osztrogonác.
2481
2482         Get rid of the unused WebKit2QML library
2483
2484         * qmake/mkspecs/features/webkit_modules.prf:
2485         * qmake/mkspecs/modules/webkit2qml.prf: Removed.
2486
2487 2013-09-30  Krzysztof Wolanski  <k.wolanski@samsung.com>
2488
2489         [EFL] Fix incorrect click counting in EventSenderProxy
2490         https://bugs.webkit.org/show_bug.cgi?id=122098
2491
2492         Reviewed by Gyuyoung Kim.
2493
2494         Previously used two types of recording time, which conflicted with each other.
2495
2496         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
2497         (WTR::EventSenderProxy::mouseUp):
2498
2499 2013-09-30  Zan Dobersek  <zdobersek@igalia.com>
2500
2501         [webkitpy] Make the Xvfb screen depth overridable
2502         https://bugs.webkit.org/show_bug.cgi?id=122089
2503
2504         Reviewed by Gyuyoung Kim.
2505
2506         Make the Xvfb screen depth overridable by checking if the XVFB_SCREEN_DEPTH environment variable
2507         was set. The default value that's used if the variable wasn't set is 24.
2508
2509         * Scripts/webkitpy/port/xvfbdriver.py:
2510         (XvfbDriver._xvfb_screen_depth):
2511         (XvfbDriver._start):
2512         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
2513         (XvfbDriverTest.make_driver):
2514         (XvfbDriverTest.test_start_no_pixel_tests):
2515         (XvfbDriverTest.test_start_pixel_tests):
2516         (XvfbDriverTest.test_start_arbitrary_worker_number):
2517         (XvfbDriverTest.test_next_free_display):
2518         (XvfbDriverTest.test_start_next_worker):
2519
2520 2013-09-29  Mark Rowe  <mrowe@apple.com>
2521
2522         Fix the Lion build.
2523
2524         Ensure that C++ and Objective-C++ files build with the right compiler flags.
2525
2526         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig:
2527         * WebKitTestRunner/Configurations/BaseTarget.xcconfig:
2528
2529 2013-09-28  Mark Rowe  <mrowe@apple.com>
2530
2531         Fix some failures with newer versions of clang.
2532
2533         Some CoreGraphics headers generate warnings under newer versions of clang. Since they're system headers the warnings would
2534         usually be suppressed, but we're adding the frameworks to the non-system framework search path so they're no longer treated
2535         as system headers. We address this by removing the system paths from FRAMEWORK_SEARCH_PATHS and using the -iframework compiler
2536         flag in OTHER_CFLAGS to add the paths to the system framework search path. We have to set OTHER_CFLAGS at the target level
2537         in order for it to coexist with the ASAN-related OTHER_CFLAGS that's set in DebugRelease.xcconfig.
2538
2539         Reviewed by Dan Bernstein.
2540
2541         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2542         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: A new .xcconfig file that's included by all target-specific .xcconfig files.
2543         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2544         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
2545         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig:
2546         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig:
2547         * WebKitTestRunner/Configurations/Base.xcconfig:
2548         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: A new .xcconfig file that's included by all target-specific .xcconfig files.
2549         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2550         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
2551         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
2552
2553 2013-09-27  Commit Queue  <commit-queue@webkit.org>
2554
2555         Unreviewed, rolling out r156569.
2556         http://trac.webkit.org/changeset/156569
2557         https://bugs.webkit.org/show_bug.cgi?id=122035
2558
2559         broke a lot of mismatch tests (Requested by thorton on
2560         #webkit).
2561
2562         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2563         (WTR::PlatformWebView::PlatformWebView):
2564
2565 2013-09-27  Alexey Proskuryakov  <ap@apple.com>
2566
2567         Don't retry failures on Apple MountainLion Release WK1 tester
2568         https://bugs.webkit.org/show_bug.cgi?id=122026
2569
2570         Reviewed by Mark Rowe.
2571
2572         * BuildSlaveSupport/build.webkit.org-config/config.json: Added --no-retry-failures
2573         on this bot.
2574
2575 2013-09-27  Alexey Proskuryakov  <ap@apple.com>
2576
2577         Don't hardcode builder specific configuration in buildbot master.cfg
2578         https://bugs.webkit.org/show_bug.cgi?id=122023
2579
2580         Reviewed by Mark Rowe.
2581
2582         * BuildSlaveSupport/build.webkit.org-config/config.json: Added an additionalArguments
2583         property to Qt Mountain Lion Release, making it run pixel tests.
2584
2585         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2586         (RunWebKitTests.start): Use additionalArguments.
2587         (RunWebKit2Tests.start): Don't hardcode individual bot behavior here.
2588
2589 2013-09-27  Tim Horton  <timothy_horton@apple.com>
2590
2591         [wk2] WebKitTestRunner's window snapshots are blank with tiled drawing
2592         https://bugs.webkit.org/show_bug.cgi?id=122006
2593         <rdar://problem/15095197>
2594
2595         Reviewed by Dean Jackson.
2596
2597         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2598         (WTR::PlatformWebView::PlatformWebView):
2599         Layer-back the root view in WebKitTestRunner's window, to work around a bug
2600         where the window server snapshot API returns blank snapshots.
2601
2602 2013-09-27  Mario Sanchez Prada  <mario.prada@samsung.com>
2603
2604         [GTK] GTK does not expose heading level correctly. Was: accessibility/heading-level.html is failing
2605         https://bugs.webkit.org/show_bug.cgi?id=106924
2606
2607         Reviewed by Chris Fleizach.
2608
2609         Consider headings levels as values to be returned in intValue()
2610         both in DRT and WKTR, so we can share more tests with other ports.
2611
2612         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2613         (AccessibilityUIElement::intValue): Consider headings too.
2614         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2615         (WTR::AccessibilityUIElement::intValue): Ditto.
2616
2617 2013-09-26  Darin Adler  <darin@apple.com>
2618
2619         rename KURL to URL
2620         https://bugs.webkit.org/show_bug.cgi?id=16214
2621
2622         Reviewed by Andreas Kling.
2623
2624         * many files: Renamed, using script.
2625
2626 2013-09-27  Darin Adler  <darin@apple.com>
2627
2628         Fix Python scripts test failures.
2629
2630         * Scripts/webkitpy/style/checkers/cpp.py:
2631         (_FunctionState.modifiers_and_return_type): Added this back. Used only by tests
2632         now, not by the checker itself.
2633
2634 2013-09-27  Denis Nomiyama  <d.nomiyama@samsung.com>
2635
2636         [GTK][WK2] Logging of accessibility events is not disabled between tests
2637         https://bugs.webkit.org/show_bug.cgi?id=121957
2638
2639         Reviewed by Mario Sanchez Prada.
2640
2641         Fixed an issue in AccessibilityNotificationHandler where the destructor
2642         was not disconnecting accessibility event callbacks if logging was on.
2643         The decision of disconnecting events can solely rely on the existence of
2644         notification handlers because logging uses the global notification
2645         handler.
2646
2647         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
2648         (WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks): Fixed
2649         disconnection when logging is on.
2650
2651 2013-09-27  Patrick Gansterer  <paroga@webkit.org>
2652
2653         Add general CMakeLists.txt for DRT
2654         https://bugs.webkit.org/show_bug.cgi?id=119268
2655
2656         Reviewed by Gyuyoung Kim.
2657
2658         The new file allows better sharing between ports.
2659
2660         * CMakeLists.txt:
2661         * DumpRenderTree/CMakeLists.txt: Added.
2662         * DumpRenderTree/PlatformEfl.cmake: Added.
2663         * DumpRenderTree/efl/CMakeLists.txt: Removed.
2664
2665 2013-09-27  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2666
2667         [Qt] Fix force_static_libs_as_shared in WebKit2
2668         https://bugs.webkit.org/show_bug.cgi?id=121961
2669
2670         Reviewed by Csaba Osztrogonác.
2671
2672         Reenable force_static_libs_as_shared when building WebKit2.
2673
2674         * qmake/mkspecs/features/default_post.prf:
2675
2676 2013-09-27  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2677
2678         [Qt] Mock implementations of positioning and orientation not used
2679         https://bugs.webkit.org/show_bug.cgi?id=121956
2680
2681         Reviewed by Csaba Osztrogonác.
2682
2683         Move production_build checks to sanitizeFeatures where its value is actually known.
2684
2685         * qmake/mkspecs/features/features.prf:
2686         * qmake/mkspecs/features/features.pri:
2687
2688 2013-09-27  Mario Sanchez Prada  <mario.prada@samsung.com>
2689
2690         [ATK] Normalize checks in entry points for DRT and WKTR
2691         https://bugs.webkit.org/show_bug.cgi?id=121959
2692
2693         Reviewed by Chris Fleizach.
2694
2695         Always check if we have a proper instance of AtkObject,
2696         implementing the interfaces that we might need for each case, at
2697         the entry point of every method of AccessibilityUIElement for ATK,
2698         and do those checks in an uniform way across DRT and WKTR, to
2699         avoid confusion and issues when modifying these files in the future.
2700
2701         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2702         (AccessibilityUIElement::getChildren): Use normalized checks.
2703         (AccessibilityUIElement::getChildrenWithRange): Ditto.
2704         (AccessibilityUIElement::rowCount): Ditto.
2705         (AccessibilityUIElement::columnCount): Ditto.
2706         (AccessibilityUIElement::childrenCount): Ditto.
2707         (AccessibilityUIElement::elementAtPoint): Ditto.
2708         (AccessibilityUIElement::getChildAtIndex): Ditto.
2709         (AccessibilityUIElement::allAttributes): Ditto.
2710         (AccessibilityUIElement::titleUIElement): Ditto.
2711         (AccessibilityUIElement::parentElement): Ditto.
2712         (AccessibilityUIElement::attributesOfChildren): Ditto.
2713         (AccessibilityUIElement::role): Ditto.
2714         (AccessibilityUIElement::title): Ditto.
2715         (AccessibilityUIElement::description): Ditto.
2716         (AccessibilityUIElement::stringValue): Ditto.
2717         (AccessibilityUIElement::language): Ditto.
2718         (AccessibilityUIElement::x): Ditto.
2719         (AccessibilityUIElement::y): Ditto.
2720         (AccessibilityUIElement::width): Ditto.
2721         (AccessibilityUIElement::height): Ditto.
2722         (AccessibilityUIElement::orientation): Ditto.
2723         (AccessibilityUIElement::intValue): Ditto.
2724         (AccessibilityUIElement::minValue): Ditto.
2725         (AccessibilityUIElement::maxValue): Ditto.
2726         (indexRangeInTable): Ditto.
2727         (AccessibilityUIElement::cellForColumnAndRow): Ditto.
2728         (AccessibilityUIElement::stringAttributeValue): Ditto.
2729         (alterCurrentValue): Ditto.
2730         (AccessibilityUIElement::press): Ditto.
2731         (AccessibilityUIElement::documentEncoding): Ditto.
2732         (AccessibilityUIElement::documentURI): Ditto.
2733         (AccessibilityUIElement::hasPopup): Ditto.
2734
2735         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2736         (WTR::indexRangeInTable): Use normalized checks.
2737         (WTR::alterCurrentValue): Ditto.
2738         (WTR::AccessibilityUIElement::getChildren): Ditto.
2739         (WTR::AccessibilityUIElement::getChildrenWithRange): Ditto.
2740         (WTR::AccessibilityUIElement::childrenCount): Ditto.
2741         (WTR::AccessibilityUIElement::elementAtPoint): Ditto.
2742         (WTR::AccessibilityUIElement::indexOfChild): Ditto.
2743         (WTR::AccessibilityUIElement::childAtIndex): Ditto.
2744         (WTR::AccessibilityUIElement::titleUIElement): Ditto.
2745         (WTR::AccessibilityUIElement::parentElement): Ditto.
2746         (WTR::AccessibilityUIElement::attributesOfChildren): Ditto.
2747         (WTR::AccessibilityUIElement::allAttributes): Ditto.
2748         (WTR::AccessibilityUIElement::stringAttributeValue): Ditto.
2749         (WTR::AccessibilityUIElement::role): Ditto.
2750         (WTR::AccessibilityUIElement::title): Ditto.
2751         (WTR::AccessibilityUIElement::description): Ditto.
2752         (WTR::AccessibilityUIElement::orientation): Ditto.
2753         (WTR::AccessibilityUIElement::stringValue): Ditto.
2754         (WTR::AccessibilityUIElement::language): Ditto.
2755         (WTR::AccessibilityUIElement::x): Ditto.
2756         (WTR::AccessibilityUIElement::y): Ditto.
2757         (WTR::AccessibilityUIElement::width): Ditto.
2758         (WTR::AccessibilityUIElement::height): Ditto.
2759         (WTR::AccessibilityUIElement::intValue): Ditto.
2760         (WTR::AccessibilityUIElement::minValue): Ditto.
2761         (WTR::AccessibilityUIElement::maxValue): Ditto.
2762         (WTR::AccessibilityUIElement::rowCount): Ditto.
2763         (WTR::AccessibilityUIElement::columnCount): Ditto.
2764         (WTR::AccessibilityUIElement::cellForColumnAndRow): Ditto.
2765         (WTR::AccessibilityUIElement::press): Ditto.
2766         (WTR::AccessibilityUIElement::documentEncoding): Ditto.
2767         (WTR::AccessibilityUIElement::documentURI): Ditto.
2768         (WTR::AccessibilityUIElement::hasPopup): Ditto.
2769
2770 2013-09-27  Mario Sanchez Prada  <mario.prada@samsung.com>
2771
2772         [ATK] accessibility/aria-sort.html is failing after r156409
2773         https://bugs.webkit.org/show_bug.cgi?id=121947
2774
2775         Reviewed by Chris Fleizach.
2776
2777         Implement AccessibilityUIElement::isSupported for the ATK
2778         platforms, just by checking whether we have an associated object
2779         attribute exposed for the wrapper object matching the required
2780         attribute in the layout test (e.g "AXSortDirection" -> "sort").
2781
2782         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2783         (AccessibilityUIElement::isAttributeSupported): Implemented.
2784         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2785         (WTR::AccessibilityUIElement::isAttributeSupported): Implemented.
2786
2787 2013-09-26  Eric Carlson  <eric.carlson@apple.com>
2788
2789         [MediaStream] make MediaStream testable
2790         https://bugs.webkit.org/show_bug.cgi?id=121967
2791
2792         Reviewed by Dean Jackson.
2793
2794         * DumpRenderTree/mac/UIDelegate.mm:
2795         (-[UIDelegate webView:decidePolicyForUserMediaRequestFromOrigin:listener:]): Add a very permissive
2796             user media request policy delegate.
2797
2798 2013-09-26  Brian J. Burg  <burg@cs.washington.edu>
2799
2800         build-webkit --inspector-frontend should copy WebInspectorUI files
2801         https://bugs.webkit.org/show_bug.cgi?id=117851
2802
2803         Reviewed by Joseph Pecoraro.
2804
2805         Change the --inspector-frontend build option to additionally build/copy
2806         WebInspectorUI by setting it as the only project that needs to be built.
2807
2808         * Scripts/build-webkit:
2809
2810 2013-09-26  Zan Dobersek  <zdobersek@igalia.com>
2811
2812         XvfbDriver should set up Xvfb instances providing screens of 8-bit depth
2813         https://bugs.webkit.org/show_bug.cgi?id=121951
2814
2815         Reviewed by Carlos Garcia Campos.
2816
2817         Screens with 24-bit depth are causing problems as it doesn't seem to be possible to fall back to
2818         software rendering successfully on the GTK 64-bit release builder, resulting in crashes in almost
2819         500 layout tests that trigger accelerated compositing to be used.
2820
2821         * Scripts/webkitpy/port/xvfbdriver.py:
2822         (XvfbDriver._start):
2823         * Scripts/webkitpy/port/xvfbdriver_unittest.py: Update unit test baselines.
2824         (XvfbDriverTest.test_start_no_pixel_tests):
2825         (XvfbDriverTest.test_start_pixel_tests):
2826         (XvfbDriverTest.test_start_arbitrary_worker_number):
2827         (XvfbDriverTest.test_next_free_display):
2828         (XvfbDriverTest.test_start_next_worker):
2829
2830 2013-09-26  Tim Horton  <timothy_horton@apple.com>
2831
2832         Tiled drawing should not imply threaded scrolling
2833         https://bugs.webkit.org/show_bug.cgi?id=121874
2834         <rdar://problem/15071494>
2835
2836         Reviewed by Sam Weinig.
2837
2838         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2839         (WTR::PlatformWebView::PlatformWebView):
2840         The existing tiled-drawing layout tests require threaded scrolling to be enabled.
2841
2842 2013-09-26  Commit Queue  <commit-queue@webkit.org>
2843
2844         Unreviewed, rolling out r156457.
2845         http://trac.webkit.org/changeset/156457
2846         https://bugs.webkit.org/show_bug.cgi?id=121960
2847
2848         Broke webkitpy tests. (Requested by kling on #webkit).
2849
2850         * Scripts/webkitpy/port/xvfbdriver.py:
2851         (XvfbDriver._start):
2852
2853 2013-09-26  Zan Dobersek  <zdobersek@igalia.com>
2854
2855         XvfbDriver should set up Xvfb instances providing screens of 8-bit depth
2856         https://bugs.webkit.org/show_bug.cgi?id=121951
2857
2858         Reviewed by Carlos Garcia Campos.
2859
2860         Screens with 24-bit depth are causing problems as it doesn't seem to be possible to fall back to
2861         software rendering successfully on the GTK 64-bit release builder, resulting in crashes in almost
2862         500 layout tests that trigger accelerated compositing to be used.
2863
2864         * Scripts/webkitpy/port/xvfbdriver.py:
2865         (XvfbDriver._start):
2866
2867 2013-09-25  Alex Christensen  <achristensen@webkit.org>
2868
2869         Removed check for Apple Application Support directory in WinCairo port.
2870         https://bugs.webkit.org/show_bug.cgi?id=121869
2871
2872         Reviewed by Brent Fulgham.
2873
2874         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
2875         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
2876         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
2877         Use DLLLauncherWinCairo.props for WinCairo ports.
2878         * win/DLLLauncher/DLLLauncherMain.cpp:
2879         (wWinMain):
2880         Don't call modifyPath to check for AAS in the WinCairo port.
2881         * win/DLLLauncher/DLLLauncherWinCairo.props: Added to define WIN_CAIRO.
2882
2883 2013-09-25  Alex Christensen  <achristensen@webkit.org>
2884
2885         Enabled AssembleBuildLogs on WinCairo port.
2886         https://bugs.webkit.org/show_bug.cgi?id=121923
2887
2888         Reviewed by Brent Fulgham.
2889
2890         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj:
2891         Fixed reference to README, added WinCairo configurations.
2892         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj.filters:
2893         Fixed reference to README.
2894         * win/AssembleBuildLogs/AssembleLogs.cmd:
2895         Added ANGLE projects, skipped QTMovieWin for WinCairo, use PlatformArchitecture for Win64.
2896         * win/AssembleBuildLogs/README: Fixed spelling.
2897
2898 2013-09-25  Patrick Gansterer  <paroga@webkit.org>
2899
2900         [WIN] Fix MSVC C4146 compiler warning
2901         https://bugs.webkit.org/show_bug.cgi?id=121838
2902
2903         Reviewed by Brent Fulgham.
2904
2905         Fix some variables from unsinged to int to fix the compiler warning
2906         "unary minus operator applied to unsigned type, result still unsigned".
2907
2908         * DumpRenderTree/WorkQueueItem.h:
2909         (BackItem::BackItem):
2910         (ForwardItem::ForwardItem):
2911         * DumpRenderTree/win/DumpRenderTree.cpp:
2912         (createWebViewAndOffscreenWindow):
2913
2914 2013-09-25  Zan Dobersek  <zdobersek@igalia.com>
2915
2916         [GTK] Switch the 64-bit Release builder to testing layout tests under WK2
2917         https://bugs.webkit.org/show_bug.cgi?id=121256
2918
2919         Reviewed by Martin Robinson.
2920
2921         Switch the GTK 64-bit Release builder to testing the layout tests under WebKit2.
2922         The GTK 64-bit Release WK2 testing builder is switched to now run layout tests under WebKit1.
2923
2924         * BuildSlaveSupport/build.webkit.org-config/config.json:
2925
2926 2013-09-25  Patrick Gansterer  <paroga@webkit.org>
2927
2928         Add style checker for CMake lists
2929         https://bugs.webkit.org/show_bug.cgi?id=121764
2930
2931         Reviewed by Ryosuke Niwa.
2932
2933         Add an additional check to make sure that list of files are sorted.
2934         Exclude lists of include directories for now, since the order
2935         can be importent for compilation of some files.
2936
2937         * Scripts/webkitpy/style/checkers/cmake.py:
2938         (CMakeChecker.check):
2939         (CMakeChecker._check_indent):
2940         (CMakeChecker):
2941         (CMakeChecker._check_list_order):
2942         (CMakeChecker._list_item_path):
2943         * Scripts/webkitpy/style/checkers/cmake_unittest.py:
2944         (CMakeCheckerTest.test_check):
2945
2946 2013-09-25  Patrick Gansterer  <paroga@webkit.org>
2947
2948         CMakeChecker takes unusually long time to run
2949         https://bugs.webkit.org/show_bug.cgi?id=105662
2950
2951         Reviewed by Ryosuke Niwa.
2952
2953         Move the caching mechanism for regular expression of the C++ checker into
2954         a common file and use it for the CMake and ChangeLog checkers too.
2955
2956         * Scripts/webkitpy/style/checkers/changelog.py:
2957         (ChangeLogChecker.check_entry):
2958         * Scripts/webkitpy/style/checkers/cmake.py:
2959         (CMakeChecker._process_line):
2960         (CMakeChecker._check_no_space_cmds):
2961         (CMakeChecker._check_one_space_cmds):
2962         (CMakeChecker._check_non_lowercase_cmd):
2963         * Scripts/webkitpy/style/checkers/common.py:
2964         (match):
2965         (search):
2966         (searchIgnorecase):
2967         (sub):
2968         (subn):
2969         * Scripts/webkitpy/style/checkers/cpp.py:
2970
2971 2013-09-25  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2972
2973         [Qt] Fix build with Qt 5.2 QtPosition module
2974         https://bugs.webkit.org/show_bug.cgi?id=121089
2975
2976         Reviewed by Simon Hausmann.
2977
2978         QtLocation -> QtPositioning. Make sure we set build type before doing configure checks
2979         that might depend on them.
2980
2981         * qmake/mkspecs/features/default_pre.prf:
2982         * qmake/mkspecs/features/features.prf:
2983
2984 2013-09-25  Mario Sanchez Prada  <mario.prada@samsung.com>
2985
2986         [ATK] Fix style issues in AccessibilityUIElementAtk
2987         https://bugs.webkit.org/show_bug.cgi?id=121898
2988
2989         Reviewed by Chris Fleizach.
2990
2991         Avoid the '.f' suffix for float literals and use G_VALUE_INIT
2992         instead of { 0, { { 0 } } } to initialize a GValue.
2993
2994         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2995         (AccessibilityUIElement::clickPointX): Remove suffix.
2996         (AccessibilityUIElement::clickPointY): Ditto.
2997         (AccessibilityUIElement::intValue): Use G_VALUE_INIT and remove suffix.
2998         (AccessibilityUIElement::minValue): Ditto.
2999         (AccessibilityUIElement::maxValue): Ditto.
3000         (AccessibilityUIElement::numberAttributeValue): Remove suffix.
3001         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3002         (WTR::AccessibilityUIElement::numberAttributeValue): Remove suffix.
3003         (WTR::AccessibilityUIElement::x): Ditto.
3004         (WTR::AccessibilityUIElement::y): Ditto.
3005         (WTR::AccessibilityUIElement::width): Ditto.
3006         (WTR::AccessibilityUIElement::height): Ditto.
3007         (WTR::AccessibilityUIElement::clickPointX): Ditto.
3008         (WTR::AccessibilityUIElement::clickPointY): Ditto.
3009         (WTR::AccessibilityUIElement::intValue): Ditto.
3010         (WTR::AccessibilityUIElement::minValue): Ditto.
3011         (WTR::AccessibilityUIElement::maxValue): Ditto.
3012
3013 2013-09-25  Krzysztof Czech  <k.czech@samsung.com>
3014
3015         [EFL] accessibility/loading-iframe-sends-notification.html is failing
3016         https://bugs.webkit.org/show_bug.cgi?id=112003
3017
3018         Reviewed by Mario Sanchez Prada.
3019
3020         Enabled addNotificationListener and removeNotificationListener for EFL port.
3021
3022         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
3023         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
3024         (WTR::AccessibilityController::removeNotificationListener):
3025
3026 2013-09-24  Filip Pizlo  <fpizlo@apple.com>
3027
3028         Crashing under JSC::DFG::SpeculativeJIT::spill visiting citicards.com
3029         https://bugs.webkit.org/show_bug.cgi?id=121844
3030
3031         Reviewed by Mark Hahnenberg.
3032
3033         * Scripts/run-javascriptcore-tests: Be more clear about what test suite failed.
3034
3035 2013-09-24  Alexey Proskuryakov  <ap@apple.com>
3036
3037         [Mac][WK2] Multiple font tests fail is there is a global setting for font antialiasing threshold
3038         https://bugs.webkit.org/show_bug.cgi?id=121854
3039
3040         Reviewed by Anders Carlsson.
3041
3042         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3043         (WTR::InjectedBundle::platformInitialize): Post a notification to update cached
3044         settings in underlying frameworks.
3045
3046 2013-09-24  Mark Rowe  <mrowe@apple.com>
3047
3048         <rdar://problem/14971518> WebKit should build against the Xcode default toolchain when targeting OS X 10.8
3049
3050         Reviewed by Dan Bernstein.
3051
3052         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3053         * MiniBrowser/Configurations/Base.xcconfig:
3054         * TestWebKitAPI/Configurations/Base.xcconfig:
3055         * WebKitLauncher/Configurations/Base.xcconfig:
3056         * WebKitTestRunner/Configurations/Base.xcconfig:
3057
3058 2013-09-24  Denis Nomiyama  <d.nomiyama@samsung.com>
3059
3060         [ATK] Missing WTR AccessibilityController::addNotificationListener implementation
3061         https://bugs.webkit.org/show_bug.cgi?id=121674
3062
3063         Reviewed by Mario Sanchez Prada.
3064
3065         Implemented the global notification listener for
3066         AccessibilityController. The signal is generated by
3067         AXObjectCache::postPlatformNotification() and received by
3068         axObjectEventListener(). axObjectEventListener will then invoke
3069         JSObjectCallAsFunction() with the respective callback function.
3070
3071         There is no additional test for this patch since its implementation will
3072         be tested by an accessibility layout test that is currently failing
3073         (accessibility/loading-iframe-sends-notification.html).
3074
3075         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp: Removed
3076         stub implementations of addNotificationListener and
3077         removeNotificationListener for the GTK port.
3078         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
3079         (WTR::AccessibilityController::addNotificationListener): Creates the
3080         notification handler and sets the notification function callback.
3081         (WTR::AccessibilityController::removeNotificationListener): Removes the
3082         global handler.
3083
3084 2013-09-24  Anton Obzhirov  <a.obzhirov@samsung.com>
3085
3086         [GTK] fast/images/exif-orientation-composited.html is failing
3087         https://bugs.webkit.org/show_bug.cgi?id=119731
3088
3089         Reviewed by Carlos Garcia Campos.
3090
3091         Add handling respect image orientation property in DRT.
3092
3093         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
3094         (TestRunner::overridePreference):
3095
3096 2013-09-24  Zan Dobersek  <zdobersek@igalia.com>
3097
3098         [GTK] Bump the GTK+ dependency in the Wayland-specific Jhbuild moduleset
3099         https://bugs.webkit.org/show_bug.cgi?id=121787
3100
3101         Reviewed by Gustavo Noronha Silva.
3102
3103         * gtk/jhbuild-wayland.modules: Bump the GTK+ dependency that's intended for use when building
3104         with the Wayland target enabled to version 3.10.0.
3105
3106 2013-09-23  Patrick Gansterer  <paroga@webkit.org>
3107
3108         use NOMINMAX instead of #define min min
3109         https://bugs.webkit.org/show_bug.cgi?id=73563
3110
3111         Reviewed by Brent Fulgham.
3112
3113         Use NOMINMAX instead of #define min/max as a cleaner
3114         way of ensuring that Windows system header files don't
3115         define min/max as macro in the first place.
3116
3117         * DumpRenderTree/DumpRenderTreePrefix.h:
3118         * DumpRenderTree/cg/ImageDiffCG.cpp:
3119         * DumpRenderTree/config.h:
3120         * DumpRenderTree/win/ImageDiffCairo.cpp:
3121         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
3122         * WebKitTestRunner/config.h:
3123
3124 2013-09-23  Benjamin Poulain  <benjamin@webkit.org>
3125
3126         Delete TestWebKitAPI domain or some keys before running TestWebKitAPI
3127         https://bugs.webkit.org/show_bug.cgi?id=121715 & <rdar://problem/14269434>
3128
3129         Reviewed by Alexey Proskuryakov.
3130
3131         Previously, initalizing a WebPreference would change the cache model
3132         to WebCacheModelDocumentBrowser. That behavior was due to a stale
3133         preference file on disk.
3134
3135         This patch fixes the tests by resetting the default, and using the proper
3136         default values after initializing WebPreference.
3137
3138         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
3139         (TestWebKitAPI::TEST): Use the proper initial value, unrelated
3140         to the previous runs.
3141
3142         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
3143         (TestWebKitAPI::TEST): This test needs b/f cache to be enabled, so change
3144         cache model to the one required.
3145
3146         * TestWebKitAPI/ios/mainIOS.mm:
3147         (main): Reset the preferences before testing.
3148         * TestWebKitAPI/mac/mainMac.mm:
3149         (main): Ditto.
3150
3151 2013-09-23  Benjamin Poulain  <benjamin@webkit.org>
3152
3153         Delete TestWebKitAPI domain or some keys before running TestWebKitAPI
3154         https://bugs.webkit.org/show_bug.cgi?id=121715 & <rdar://problem/14269434>
3155
3156         Reviewed by Alexey Proskuryakov.
3157
3158         Previously, initalizing a WebPreference would change the cache model
3159         to WebCacheModelDocumentBrowser. That behavior was due to a stale
3160         preference file on disk.
3161
3162         This patch fixes the tests by resetting the default, and using the proper
3163         default values after initializing WebPreference.
3164
3165         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
3166         (TestWebKitAPI::TEST): Use the proper initial value, unrelated
3167         to the previous runs.
3168
3169         * TestWebKitAPI/ios/mainIOS.mm:
3170         (main): Reset the preferences before testing.
3171         * TestWebKitAPI/mac/mainMac.mm:
3172         (main): Ditto.
3173
3174 2013-09-23  Anders Carlsson  <andersca@apple.com>
3175
3176         ListHashSet should work with move-only types
3177         https://bugs.webkit.org/show_bug.cgi?id=121802
3178
3179         Reviewed by Andreas Kling.
3180
3181         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
3182         (TestWebKitAPI::TEST):
3183         Add a test for move-only types.
3184
3185 2013-09-23  Alex Christensen  <alex.christensen@flexsim.com>
3186
3187         Added --64-bit option for Windows build.
3188         https://bugs.webkit.org/show_bug.cgi?id=121799
3189
3190         Reviewed by Brent Fulgham.
3191
3192         * Scripts/webkitdirs.pm:
3193         (determinePassedConfiguration): Add "|x64" for 64-bit configuration.
3194         (isWin64): Added.
3195         (determineIsWin64): Added.
3196
3197 2013-09-23  Anders Carlsson  <andersca@apple.com>
3198
3199         ListHashSet should use std::reverse_iterator for reverse iterators
3200         https://bugs.webkit.org/show_bug.cgi?id=121795
3201
3202         Reviewed by Antti Koivisto.
3203
3204         Add test for reverse iterators.
3205
3206         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
3207         (TestWebKitAPI::TEST):
3208
3209 2013-09-23  Krzysztof Czech  <k.czech@samsung.com>
3210
3211         [EFL] accessibility/aria-invalid is failing
3212         https://bugs.webkit.org/show_bug.cgi?id=111986
3213
3214         Reviewed by Mario Sanchez Prada.
3215
3216         Adds possibility to retrieve JS context.
3217         This is part of the implementation of AccessibilityUIElement::addNotificationListener
3218         from 119883 and 120421.
3219
3220         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
3221         (axObjectEventListener):
3222         (addAccessibilityNotificationHandler):
3223         (removeAccessibilityNotificationHandler):
3224         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
3225         (WTR::AccessibilityNotificationHandler::setNotificationFunctionCallback):
3226         (WTR::AccessibilityNotificationHandler::removeAccessibilityNotificationHandler):
3227
3228 2013-09-20  Mark Rowe  <mrowe@apple.com>
3229
3230         <https://webkit.org/b/90090> build-webkit should verify that your tools are up-to-date
3231
3232         Enforce a minimum OS version of 10.7.5 and Xcode version of 4.6.
3233
3234         Reviewed by David Kilzer.
3235
3236         * Scripts/webkitdirs.pm:
3237         (checkRequiredSystemConfig):
3238
3239 2013-09-20  Mario Sanchez Prada  <mario.prada@samsung.com>
3240
3241         [ATK] Do not expose aria-help in ATK based platforms
3242         https://bugs.webkit.org/show_bug.cgi?id=121675
3243
3244         Reviewed by Chris Fleizach.
3245
3246         Remove the implementations for AccessibilityUIElement::helpText()
3247         from DRT and WKTR for GTK and EFL, since they are based on the
3248         AccessibilityObject::helpText() method and the 'aria-help'
3249         attributes, which is wrong since they should not depend on that
3250         but in ATK specific API (see also http://webkit.org/b/121684).
3251
3252         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3253         (AccessibilityUIElement::helpText): Added a new and empty
3254         implementation, now that we are no longer using this in ATK.
3255         * DumpRenderTree/efl/AccessibilityUIElementEfl.cpp: Removed file
3256         as the only function provided here was helpText().
3257         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Ditto.
3258         * DumpRenderTree/efl/CMakeLists.txt: AccessibilityUIElementEfl.cpp
3259         removed from the list of sources to compile.
3260         * GNUmakefile.am: Likewise, but for AccessibilityUIElementGtk.cpp.
3261         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3262         (WTR::AccessibilityUIElement::helpText): Replaced old implementation
3263         based in DumpRenderTreeSupportGtk with an empty one.
3264
3265 2013-09-20  Dan Bernstein  <mitz@apple.com>
3266
3267         Make extract-localizable-strings available to WebCore clients
3268         https://bugs.webkit.org/show_bug.cgi?id=121699
3269
3270         Reviewed by Darin Adler.
3271
3272         * Scripts/extract-localizable-strings: Copied to
3273         Soure/WebCore/extract-localizaebl-strings.pl, and changed this into a shell script that
3274         executes the script from its new location. This is a temporary measure until certain code
3275         that is external to WebKit is adapted to the new location.
3276         * Scripts/update-webkit-localizable-strings: Changed to call extract-localizable-strings.pl
3277         from its new location.
3278
3279 2013-09-20  Patrick Gansterer  <paroga@webkit.org>
3280
3281         Nuke remaining VS2005 tools from the tree.
3282         https://bugs.webkit.org/show_bug.cgi?id=121691
3283
3284         Reviewed by Brent Fulgham.
3285
3286         * CLWrapper/CLWrapper.cpp: Removed.
3287         * CLWrapper/CLWrapper.sln: Removed.
3288         * CLWrapper/CLWrapper.vcproj: Removed.
3289         * MIDLWrapper/MIDLWrapper.cpp: Removed.
3290         * MIDLWrapper/MIDLWrapper.sln: Removed.
3291         * MIDLWrapper/MIDLWrapper.vcproj: Removed.
3292         * Scripts/parallelcl: Removed.
3293         * vcbin/cl.exe: Removed.
3294         * vcbin/midl.exe: Removed.
3295
3296 2013-09-20  Mario Sanchez Prada  <mario.prada@samsung.com>
3297
3298         [GTK] socket_embed_hook hitting NULL-check assertion running TestWebKit2
3299         https://bugs.webkit.org/show_bug.cgi?id=121294
3300
3301         Reviewed by Martin Robinson.
3302
3303         Provide a new patch to deal with the issue in the GTK+ module from
3304         the internal jhbuild environment. This issue has been reported
3305         upstream (see https://bugzilla.gnome.org/show_bug.cgi?id=708024).
3306
3307         * gtk/jhbuild.modules: Apply the new patch to the GTK+ module.
3308         * gtk/patches/gtk-3.6-do-not-shutdown-accessibility.patch: Added.
3309
3310 2013-09-20  Denis Nomiyama  <d.nomiyama@samsung.com>
3311
3312         [ATK][WTR] accessibility/aria-invalid.html times out
3313         https://bugs.webkit.org/show_bug.cgi?id=121668
3314
3315         Reviewed by Mario Sanchez Prada.
3316
3317         Fixed WTR::AccessibilityUIElement::stringAttributeValue() to return
3318         false in case of aria-invalid event with empty value.
3319
3320         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3321         (WTR::AccessibilityUIElement::stringAttributeValue): Returns false in
3322         case of aria-invalid event with empty value.
3323
3324 2013-09-20  Denis Nomiyama  <d.nomiyama@samsung.com>
3325
3326         [ATK] Missing WTR AccessibilityUIElement::addNotificationListener implementation
3327         https://bugs.webkit.org/show_bug.cgi?id=120421
3328
3329         Reviewed by Mario Sanchez Prada.
3330
3331         Implemented the notification listener for AccessibilityUIElement for
3332         WebKitTestRunner. The signal is generated by
3333         AXObjectCache::postPlatformNotification() and received by
3334         axObjectEventListener(). axObjectEventListener() will then invoke
3335         JSObjectCallAsFunction() with the respective callback function. The
3336         notification handlers are stored in HashMap in
3337         AccessibilityNotificationHandlerAtk.cpp.
3338
3339         Moved ATK signal handling (printAccessibilityEvent and
3340         axObjectEventListener) to AccessibilityNotificationHandlerAtk.cpp.
3341
3342         * WebKitTestRunner/CMakeLists.txt: Added InjectedBundle/atk to the
3343         include path.
3344         * WebKitTestRunner/GNUmakefile.am:
3345         Added AccessibilityNotificationHandlerAtk.cpp/h.
3346         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp: Moved
3347         listener IDs to AccessibilityNotificationHandlerAtk.cpp.
3348         * WebKitTestRunner/InjectedBundle/AccessibilityController.h: Moved
3349         listener IDs to AccessibilityNotificationHandlerAtk.cpp.
3350         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h: Added a
3351         notification handler for GTK+ and EFL.
3352         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
3353         Moved printAccessibilityEvent and axObjectEventListener to
3354         AccessibilityNotificationHandlerAtk.cpp.
3355         (WTR::AccessibilityController::logAccessibilityEvents): Moved listener
3356         IDs to AccessibilityNotificationHandlerAtk.cpp.
3357         (WTR::AccessibilityController::resetToConsistentState): Moved listener
3358         IDs to AccessibilityNotificationHandlerAtk.cpp.
3359         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp: Added.
3360         (WTR::printAccessibilityEvent): Prints accessibility events. This
3361         function was moved from AccessibilityControllerAtk.cpp.
3362         (WTR::axObjectEventListener): Callback for signals. This function was
3363         moved from AccessibilityControllerAtk.cpp.
3364         (WTR::AccessibilityNotificationHandler::AccessibilityNotificationHandler):
3365         Initialize element and function callback.
3366         (WTR::AccessibilityNotificationHandler::~AccessibilityNotificationHandler):
3367         Removes handler from HashMap and disconnects callbacks if necessary.
3368         (WTR::AccessibilityNotificationHandler::logAccessibilityEvents): Sets
3369         logging mode and connects callbacks.
3370         (WTR::AccessibilityNotificationHandler::setNotificationFunctionCallback):
3371         Sets the notification callback and connects callback to signals.
3372         (WTR::AccessibilityNotificationHandler::removeAccessibilityNotificationHandler):
3373         Removes the notification callback from HashMap.
3374         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks):
3375         Connects axObjectEventListener to ATK signals.
3376         (WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks):
3377         Disconnects callback.
3378         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.h: Added.
3379         (WTR::AccessibilityNotificationHandler::create): Creates a new instance
3380         of AccessibilityNotificationHandler.
3381         (WTR::AccessibilityNotificationHandler::setPlatformElement): Sets the
3382         element.
3383         (WTR::AccessibilityNotificationHandler::platformElement): Gets the
3384         element.
3385         (WTR::AccessibilityNotificationHandler::notificationFunctionCallback):
3386         Gets the notification callback.
3387         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3388         (WTR::AccessibilityUIElement::addNotificationListener): Creates
3389         notification handler, set the platform element and the notification
3390         callback.
3391         (WTR::AccessibilityUIElement::removeNotificationListener): Deletes the
3392         notification handler.
3393         * WebKitTestRunner/PlatformEfl.cmake:
3394         Added AccessibilityNotificationHandlerAtk.cpp.
3395
3396 2013-09-20  Allan Sandfeld Jensen  <allan.jensen@digia.com>
3397
3398         Update features.pri
3399         https://bugs.webkit.org/show_bug.cgi?id=121670
3400
3401         Reviewed by Jocelyn Turcotte.
3402
3403         Remove feature flags that no longer exists and new ones added to FeatureList.pm
3404
3405         * qmake/mkspecs/features/features.pri:
3406
3407 2013-09-20  Krzysztof Czech  <k.czech@samsung.com>
3408
3409         [GTK][WK2] accessibility/selection-states.html is failing
3410         https://bugs.webkit.org/show_bug.cgi?id=116972
3411
3412         Reviewed by Mario Sanchez Prada.
3413
3414         isSelectable() was not exposed in Accessibility.
3415
3416         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3417
3418 2013-09-19  Dan Bernstein  <mitz@apple.com>
3419
3420         Attempted build fix after r156114.
3421
3422         * Scripts/copy-webkitlibraries-to-product-directory: Removed references to WebCoreSQLite3.
3423
3424 2013-09-19  Alexey Proskuryakov  <ap@apple.com>
3425
3426         REGRESSION (r129451): run-safari --no-saved-state is broken
3427         https://bugs.webkit.org/show_bug.cgi?id=121566
3428
3429         Undo a last minute change that doesn't actually work.
3430
3431         * Scripts/webkitdirs.pm: (argumentsForRunAndDebugMacWebKitApp): "-1" cannot be passed
3432         via command line, <rdar://problem/15032886>.
3433
3434 2013-09-19  Dan Bernstein  <mitz@apple.com>
3435
3436         Add a style guideline regarding spacing in range-based for loops
3437         https://bugs.webkit.org/show_bug.cgi?id=121620
3438
3439         Reviewed by Anders Carlsson.
3440
3441         * Scripts/webkitpy/style/checkers/cpp.py:
3442         (check_spacing): Added checking that there are spaces around the colon in a range-based for
3443         loop.
3444         (CppChecker): Added whitespace/colon to the categories set.
3445         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3446         (WebKitStyleTest.test_spacing): Added two tests for the new check.
3447
3448 2013-09-18  Sam Weinig  <sam@webkit.org>
3449
3450         Replace use of OwnArrayPtr<Foo> with std::unique_ptr<Foo[]> in Tools
3451         https://bugs.webkit.org/show_bug.cgi?id=121588
3452
3453         Reviewed by Anders Carlsson.
3454
3455         * DumpRenderTree/TestRunner.cpp:
3456         * ImageDiff/efl/ImageDiff.cpp:
3457         * TestWebKitAPI/JavaScriptTest.cpp:
3458         * TestWebKitAPI/PlatformUtilities.cpp:
3459         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
3460         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3461         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3462         * WebKitTestRunner/StringFunctions.h:
3463         * WebKitTestRunner/TestInvocation.cpp:
3464         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
3465         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
3466
3467 2013-09-18  Bem Jones-Bey  <bjonesbe@adobe.com>
3468
3469         W3C Test Import script reformats test HTML
3470         https://bugs.webkit.org/show_bug.cgi?id=119159
3471
3472         Reviewed by Dirk Pranke.
3473
3474         Completely rewrite the test conversion process to minimize
3475         reformatting when adding prefixes, etc. This isn't 100% perfect, there
3476         are still places where it will end up changing the formatting, but it
3477         is much better than before. Most notably, the public interface to the
3478         test converter has changed: now one calls a method instead of creating
3479         an instance of the test converter class. This is because the test
3480         converter class now has state, so one really needs a new instance for
3481         each test.
3482
3483         Note that this also lays some simple groundwork for being able to use
3484         a MockHost in the tests.
3485
3486         * Scripts/webkitpy/w3c/test_converter.py:
3487         (convert_for_webkit):
3488         (_W3CTestConverter):
3489         (_W3CTestConverter.__init__):
3490         (_W3CTestConverter.output):
3491         (_W3CTestConverter.add_webkit_prefix_to_unprefixed_properties):
3492         (_W3CTestConverter.convert_style_data):
3493         (_W3CTestConverter.convert_attributes_if_needed):
3494         (_W3CTestConverter.handle_starttag):
3495         (_W3CTestConverter.handle_endtag):
3496         (_W3CTestConverter.handle_startendtag):
3497         (_W3CTestConverter.handle_data):
3498         (_W3CTestConverter.handle_entityref):
3499         (_W3CTestConverter.handle_charref):
3500         (_W3CTestConverter.handle_comment):
3501         (_W3CTestConverter.handle_decl):
3502         (_W3CTestConverter.handle_pi):
3503         * Scripts/webkitpy/w3c/test_converter_unittest.py:
3504         (W3CTestConverterTest):
3505         (W3CTestConverterTest.fake_dir_path):
3506         (W3CTestConverterTest.test_read_prefixed_property_list):
3507         (verify_no_conversion_happened):
3508         * Scripts/webkitpy/w3c/test_importer.py:
3509         (TestImporter.import_tests):
3510
3511 2013-09-18  Filip Pizlo  <fpizlo@apple.com>
3512
3513         Get rid of the jsc-test-list by moving all not-jsc-capable tests into js/dom
3514         https://bugs.webkit.org/show_bug.cgi?id=121578
3515
3516         Rubber stamped by Geoffrey Garen.
3517
3518         * Scripts/run-layout-jsc:
3519
3520 2013-09-18  Filip Pizlo  <fpizlo@apple.com>
3521
3522         Unreviewed, fix for Ruby 1.8.
3523
3524         * Scripts/run-jsc-stress-tests:
3525
3526 2013-09-17  Filip Pizlo  <fpizlo@apple.com>
3527
3528         run-jsc-stress-tests should make it easier to look at error spew from tests
3529         https://bugs.webkit.org/show_bug.cgi?id=121531
3530
3531         Reviewed by Mark Hahnenberg.
3532
3533         This makes two changes:
3534
3535         - The out/err spew from each test is now saved to a .out file in jsc-stress-results.
3536
3537         - The same spew also goes to the console but is prefixed by the test's name.
3538
3539         This required some tee and awk hacks, and then some sh hacks to work around the fact
3540         that if you do "(foo | bar) || baz", and foo fails, then baz won't run - the ||
3541         operator will only see a failure of bar failed. So to pass output to tee and awk, I
3542         needed to do weird things.
3543
3544         * Scripts/run-jsc-stress-tests:
3545
3546 2013-09-18  Alexey Proskuryakov  <ap@apple.com>
3547
3548         REGRESSION (r129451): run-safari --no-saved-state is broken
3549         https://bugs.webkit.org/show_bug.cgi?id=121566
3550
3551         Reviewed by Mark Rowe.
3552
3553         * Scripts/webkitdirs.pm: (argumentsForRunAndDebugMacWebKitApp):
3554         Check arguments, not the newly created empty array. Pass a value that silences warnings.
3555         While at it, removed a check for Snow Leopard.
3556
3557 2013-09-18  Alex Christensen  <achristensen@webkit.org>
3558
3559         Improved WinLauncher's URL handling.
3560         https://bugs.webkit.org/show_bug.cgi?id=121535
3561
3562         Reviewed by Brent Fulgham.
3563
3564         * WinLauncher/WinLauncher.cpp:
3565         (EditProc):
3566         Use INTERNET_MAX_URL_LENGTH instead of our MAX_URL_LENGTH.
3567         (loadURL):
3568         Prepend "http://" to URLs with no scheme.
3569
3570 2013-09-18  Filip Pizlo  <fpizlo@apple.com>
3571
3572         DFG should support Int52 for local variables
3573         https://bugs.webkit.org/show_bug.cgi?id=121064
3574
3575         Reviewed by Oliver Hunt.
3576
3577         * Scripts/run-jsc-stress-tests:
3578
3579 2013-09-18  peavo@outlook.com  <peavo@outlook.com>
3580
3581         [Win] TestWebKitAPI does not compile.
3582         https://bugs.webkit.org/show_bug.cgi?id=121485
3583
3584         Reviewed by Brent Fulgham.
3585
3586         It is no longer possible to inherit from WebCore::BitmapImage, which the test relies on.
3587         Instead, load a bitmap, then destroy the decoded data, which will cause WebCore::frameAtIndex()
3588         to return null, which is the case we want to test.
3589
3590         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:
3591         (TestWebKitAPI::TEST):
3592
3593 2013-09-18  Mario Sanchez Prada  <mario.prada@samsung.com>
3594
3595         [ATK] Expose aria-haspopup and aria-sort without the 'aria-' prefix
3596         https://bugs.webkit.org/show_bug.cgi?id=121495
3597
3598         Reviewed by Chris Fleizach.
3599
3600         Adapted DRT and WKTR to deal with the new names for the ATK object
3601         attributes being exposed for 'aria-haspopup' and 'aria-sort'.
3602
3603         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3604         (coreAttributeToAtkAttribute): Updated translation between ATK and DRT.
3605         (AccessibilityUIElement::stringAttributeValue): Ditto.
3606         (AccessibilityUIElement::hasPopup): Ditto.
3607         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3608         (WTR::coreAttributeToAtkAttribute): Updated translation between ATK and WKTR.
3609         (WTR::AccessibilityUIElement::stringAttributeValue): Ditto.
3610         (WTR::AccessibilityUIElement::hasPopup): Ditto.
3611
3612 2013-09-18  Commit Queue  <commit-queue@webkit.org>
3613
3614         Unreviewed, rolling out r156019 and r156020.
3615         http://trac.webkit.org/changeset/156019
3616         http://trac.webkit.org/changeset/156020
3617         https://bugs.webkit.org/show_bug.cgi?id=121540
3618
3619         Broke tests (Requested by ap on #webkit).
3620
3621         * Scripts/run-jsc-stress-tests:
3622
3623 2013-09-17  Gwang Yoon Hwang  <ryumiel@company100.net>
3624
3625         Unreviewed. Add myself as a committer.
3626
3627         * Scripts/webkitpy/common/config/contributors.json:
3628
3629 2013-09-17  Jae Hyun Park  <jae.park@company100.net>
3630
3631         Unreviewed. Add myself as a committer.
3632
3633         * Scripts/webkitpy/common/config/contributors.json:
3634
3635 2013-09-17  Filip Pizlo  <fpizlo@apple.com>
3636
3637         DFG should support Int52 for local variables
3638         https://bugs.webkit.org/show_bug.cg