5d589597e0a63845e40776bc6efba869caa0115a
[WebKit-https.git] / Tools / ChangeLog
1 2019-05-02  Alex Christensen  <achristensen@webkit.org>
2
3         Build fix for internal branch.
4
5         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
6         RetainPtr.h was not explicitly included.
7
8 2019-05-02  Jonathan Bedard  <jbedard@apple.com>
9
10         webkitpy: Ignore errors when shutting down an already shutdown simulator
11         <https://bugs.webkit.org/show_bug.cgi?id=197514>
12         <rdar://problem/50390247>
13
14         Reviewed by Lucas Forschler.
15
16         * Scripts/webkitpy/xcode/simulated_device.py:
17         (SimulatedDevice._shut_down):
18
19 2019-05-02  Frederic Wang  <fwang@igalia.com>
20
21         [GTK][WPE] Disable "thin", "thick", "medium" values of mfrac@linethickness at runtime
22         https://bugs.webkit.org/show_bug.cgi?id=196142
23
24         This patch introduces some experimental runtime flag to let users
25         disable MathML features that are removed from MathML Core [1]. For now,
26         these features are only disabled on GTK and WPE ports.
27
28         [1] https://mathml-refresh.github.io/mathml-core/
29
30         Reviewed by Rob Buis.
31
32         * DumpRenderTree/TestOptions.cpp:
33         (TestOptions::TestOptions):
34         * DumpRenderTree/TestOptions.h:
35         * DumpRenderTree/mac/DumpRenderTree.mm:
36         (setWebPreferencesForTestOptions):
37
38 2019-05-01  Don Olmstead  <don.olmstead@sony.com>
39
40         TestWebKitAPI config.h should be aware of what suite is being built
41         https://bugs.webkit.org/show_bug.cgi?id=196583
42
43         Reviewed by Konstantin Tokarev.
44
45         Migrate to WEBKIT_EXECUTABLE to define the Test* executables. As an added
46         benefit the macro defines BUILDING_* for the executable which allows the includes
47         of the config.h to be tailored to the test suite being built. Because of that the
48         dependencies of the Test* executable are specific to the test suite which may
49         speed up the build.
50
51         Some source files were including "PlatformUtilities.h" which includes WebKit headers
52         when "Utilities.h" is what was needed.
53
54         * TestWebKitAPI/CMakeLists.txt:
55         * TestWebKitAPI/PlatformGTK.cmake:
56         * TestWebKitAPI/PlatformJSCOnly.cmake:
57         * TestWebKitAPI/PlatformMac.cmake:
58         * TestWebKitAPI/PlatformPlayStation.cmake:
59         * TestWebKitAPI/PlatformUtilities.h:
60         * TestWebKitAPI/PlatformWPE.cmake:
61         * TestWebKitAPI/PlatformWin.cmake:
62         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
63         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
64         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
65         * TestWebKitAPI/Tests/WebCore/LineBreaking.mm:
66         * TestWebKitAPI/Tests/WebCore/cocoa/SharedBuffer.mm:
67         * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm:
68         * TestWebKitAPI/config.h:
69
70 2019-05-01  Jiewen Tan  <jiewen_tan@apple.com>
71
72         Move Document::domainIsRegisterable to SecurityOrigin::isMatchingRegistrableDomainSuffix
73         https://bugs.webkit.org/show_bug.cgi?id=181950
74         <rdar://problem/43357371>
75
76         Reviewed by Brent Fulgham.
77
78         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
79         (TestWebKitAPI::TEST_F):
80
81 2019-05-01  Aakash Jain  <aakash_jain@apple.com>
82
83         Remove webkitpy and bindings EWS queues from dashboard
84         https://bugs.webkit.org/show_bug.cgi?id=197475
85
86         Reviewed by Alexey Proskuryakov.
87
88         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
89
90 2019-05-01  Aakash Jain  <aakash_jain@apple.com>
91
92         Remove webkitpy and bindings test queues from old EWS
93         https://bugs.webkit.org/show_bug.cgi?id=197468
94
95         Reviewed by Alexey Proskuryakov.
96
97         * QueueStatusServer/config/queues.py:
98
99 2019-04-30  Tim Horton  <timothy_horton@apple.com>
100
101         Fix the WebKitTestRunner build
102         https://bugs.webkit.org/show_bug.cgi?id=197449
103         <rdar://problem/50334169>
104
105         Reviewed by Alexey Proskuryakov.
106
107         * WebKitTestRunner/mac/EventSenderProxy.mm:
108         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
109         (WTR::EventSenderProxy::mouseForceChanged):
110         Use some SPI instead of IPI.
111
112 2019-04-30  Chris Dumez  <cdumez@apple.com>
113
114         Regression(PSON) URL scheme handlers can no longer respond asynchronously
115         https://bugs.webkit.org/show_bug.cgi?id=197426
116         <rdar://problem/50256169>
117
118         Reviewed by Brady Eidson.
119
120         Add API test coverage.
121
122         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
123         (-[PSONScheme setShouldRespondAsynchronously:]):
124         (-[PSONScheme webView:startURLSchemeTask:]):
125         (-[PSONScheme webView:stopURLSchemeTask:]):
126
127 2019-04-30  Chris Dumez  <cdumez@apple.com>
128
129         Unreviewed, rolling out r244802.
130
131         Caused an API test failure
132
133         Reverted changeset:
134
135         "Regression(PSON) URL scheme handlers can no longer respond
136         asynchronously"
137         https://bugs.webkit.org/show_bug.cgi?id=197426
138         https://trac.webkit.org/changeset/244802
139
140 2019-04-30  Chris Dumez  <cdumez@apple.com>
141
142         Regression(PSON) URL scheme handlers can no longer respond asynchronously
143         https://bugs.webkit.org/show_bug.cgi?id=197426
144         <rdar://problem/50256169>
145
146         Reviewed by Brady Eidson.
147
148         Add API test coverage.
149
150         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
151         (-[PSONScheme setShouldRespondAsynchronously:]):
152         (-[PSONScheme webView:startURLSchemeTask:]):
153         (-[PSONScheme webView:stopURLSchemeTask:]):
154
155 2019-04-30  Chris Dumez  <cdumez@apple.com>
156
157         Only use a related page's process if that page has not been closed yet
158         https://bugs.webkit.org/show_bug.cgi?id=197393
159         <rdar://problem/50302423>
160
161         Reviewed by Tim Horton.
162
163         Add API test coverage.
164
165         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
166
167 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
168
169         [ews-build] Enable Bindings tests queue on new EWS
170         https://bugs.webkit.org/show_bug.cgi?id=197424
171
172         Reviewed by Lucas Forschler.
173
174         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
175         (StatusBubble):
176         * BuildSlaveSupport/ews-build/config.json:
177
178 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
179
180         [ews-build] Configure ews151 for running various tests
181         https://bugs.webkit.org/show_bug.cgi?id=197419
182
183         Reviewed by Lucas Forschler.
184
185         * BuildSlaveSupport/ews-build/config.json:
186
187 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
188
189         [ews-build] Parse and display bindings test failures
190         https://bugs.webkit.org/show_bug.cgi?id=197423
191
192         Reviewed by Lucas Forschler.
193
194         * BuildSlaveSupport/ews-build/steps.py:
195         (RunBindingsTests.__init__): Set timeout of 5 minutes.
196         (RunBindingsTests.start): Initialize log_observer for json output.
197         (RunBindingsTests.getResultSummary): Update step and build summary based on bindings test results.
198         (RunBindingsTests._addToLog): Method to add message to log.
199         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-test accordingly.
200
201 2019-04-30  Pablo Saavedra  <psaavedra@igalia.com>
202
203         Unreviewed. Add myself as a committer.
204
205         * Scripts/webkitpy/common/config/contributors.json:
206
207 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
208
209         [ews-build] Enable webkitpy queue on new EWS
210         https://bugs.webkit.org/show_bug.cgi?id=197396
211
212         Reviewed by Lucas Forschler.
213
214         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
215         (StatusBubble):
216         * BuildSlaveSupport/ews-build/config.json:
217
218 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
219
220         [ews-build] Parse and display webkitpy failures
221         https://bugs.webkit.org/show_bug.cgi?id=197395
222
223         Reviewed by Lucas Forschler.
224
225         * BuildSlaveSupport/ews-build/steps.py:
226         (RunWebKitPyTests.start): Initialize log_observer for json output.
227         (RunWebKitPyTests.getResultSummary): Update step and build summary based on webkitpy results.
228         (RunWebKitPyTests._addToLog): Method to add message to log.
229         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-test accordingly.
230
231 2019-04-29  Alex Christensen  <achristensen@webkit.org>
232
233         <rdar://problem/50299396> Fix internal High Sierra build
234         https://bugs.webkit.org/show_bug.cgi?id=197388
235
236         * DumpRenderTree/mac/Configurations/Base.xcconfig:
237         * MiniBrowser/Configurations/Base.xcconfig:
238         * MobileMiniBrowser/Configurations/Base.xcconfig:
239         * TestWebKitAPI/Configurations/Base.xcconfig:
240         * WebKitTestRunner/Configurations/Base.xcconfig:
241
242 2019-04-29  Youenn Fablet  <youenn@apple.com>
243
244         Remove spurious GVA printf logging
245         https://bugs.webkit.org/show_bug.cgi?id=197368
246         <rdar://problem/35975256>
247
248         Reviewed by Alexey Proskuryakov.
249
250         * Scripts/webkitpy/port/mac.py:
251         (MacPort.logging_patterns_to_strip):
252
253 2019-04-29  Youenn Fablet  <youenn@apple.com>
254
255         getDisplayMedia should be called on user gesture
256         https://bugs.webkit.org/show_bug.cgi?id=197356
257         <rdar://problem/50296074>
258
259         Reviewed by Eric Carlson.
260
261         Update test configuration to inject internals
262         so that we can use it to simulate a user click to call getDisplayMedia.
263
264         * TestWebKitAPI/Tests/WebKit/getDisplayMedia.html:
265         * TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm:
266         (TestWebKitAPI::GetDisplayMediaTest::SetUp):
267
268 2019-04-26  Stephanie Lewis  <slewis@apple.com>
269
270         run-benchmarks should have an intial prep and restore env call for tasks that are too expensive to do for every iteration
271         https://bugs.webkit.org/show_bug.cgi?id=197339
272
273         Reviewed by Dewei Zhu.
274
275         Add two new functions prepare_inital_env and restore_env_after_all_testing around the entire
276         test run for setup steps that are too expensive to do every iteration.
277
278         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
279         (BenchmarkRunner._run_benchmark):
280         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
281         (BrowserDriver):
282         (BrowserDriver.prepare_initial_env):
283         (BrowserDriver.restore_env_after_all_testing):
284         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
285         (LinuxBrowserDriver.prepare_initial_env):
286         (LinuxBrowserDriver.restore_env_after_all_testing):
287         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
288         (OSXBrowserDriver.prepare_initial_env):
289         (OSXBrowserDriver.restore_env_after_all_testing):
290
291 2019-04-28  Andy Estes  <aestes@apple.com>
292
293         Fix the watchOS engineering build.
294
295         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm:
296         (TestWebKitAPI::TEST): AVVideoPerformanceMetrics does not exist on watchOS.
297
298 2019-04-27  Chris Dumez  <cdumez@apple.com>
299
300         [WKTR] Move test timeout handling to the UIProcess
301         https://bugs.webkit.org/show_bug.cgi?id=197333
302
303         Reviewed by Darin Adler.
304
305         Move test timeout handling in WebKitTestRunner to the UIProcess to play nicely with PSON. Previously,
306         we'd start the timeout timer in the InjectedBundle, which would fail to account of the time spent in
307         every WebContent process in the case of swapping.
308
309         Also, because of process caching, the timeout timer would sometime fire in a cached process and it
310         would lead to crashes when firing the timer.
311
312         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
313         (WTR::InjectedBundle::didReceiveMessageToPage):
314         (WTR::InjectedBundle::done):
315         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
316         (WTR::InjectedBundle::shouldDumpPixels const):
317         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
318         (WTR::TestRunner::TestRunner):
319         (WTR::TestRunner::waitUntilDone):
320         (WTR::TestRunner::setWaitUntilDone):
321         * WebKitTestRunner/InjectedBundle/TestRunner.h:
322         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
323         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
324         * WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp:
325         * WebKitTestRunner/InjectedBundle/wpe/TestRunnerWPE.cpp:
326         * WebKitTestRunner/TestInvocation.cpp:
327         (WTR::TestInvocation::TestInvocation):
328         (WTR::TestInvocation::createTestSettingsDictionary):
329         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
330         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
331         (WTR::TestInvocation::initializeWaitToDumpWatchdogTimerIfNeeded):
332         (WTR::TestInvocation::invalidateWaitToDumpWatchdogTimer):
333         (WTR::TestInvocation::waitToDumpWatchdogTimerFired):
334         (WTR::TestInvocation::setWaitUntilDone):
335         (WTR::TestInvocation::done):
336         * WebKitTestRunner/TestInvocation.h:
337
338 2019-04-25  Yusuke Suzuki  <ysuzuki@apple.com>
339
340         [JSC] linkPolymorphicCall now does GC
341         https://bugs.webkit.org/show_bug.cgi?id=197306
342
343         Reviewed by Saam Barati.
344
345         The test is sensitive to allocations and even adding $vm makes it non-reproducible.
346         To add this test, we add `runWithoutBaseOption`.
347
348         * Scripts/run-jsc-stress-tests:
349
350 2019-04-26  Alexey Proskuryakov  <ap@apple.com>
351
352         Update inactive reviewers' status to 'contributor'.
353
354         Accidentally skipped one at first.
355
356         * Scripts/webkitpy/common/config/contributors.json:
357
358 2019-04-26  Alexey Proskuryakov  <ap@apple.com>
359
360         Update inactive reviewers' status to 'contributor'.
361
362         * Scripts/webkitpy/common/config/contributors.json: The change.
363
364         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
365         * Scripts/webkitpy/common/checkout/checkout_mock.py:
366         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
367         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
368         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
369         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
370         * Scripts/webkitpy/tool/commands/queries_unittest.py:
371         * Scripts/webkitpy/tool/commands/upload_unittest.py:
372         Sadly, regression tests operate on a crazy mix of mock and live data for
373         contributors.json. It would be a substantial project to mock all code paths,
374         so changing the tests instead.
375
376 2019-04-26  Eric Carlson  <eric.carlson@apple.com>
377
378         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
379         https://bugs.webkit.org/show_bug.cgi?id=197171
380         <rdar://problem/47454979>
381
382         Reviewed by Youenn Fablet.
383
384         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
385         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
386         (TestWebKitAPI::TEST):
387
388 2019-04-26  David Kilzer  <ddkilzer@apple.com>
389
390         WebKitTestRunner leaks an NSDictionary and multiple JSStringRef objects
391         <https://webkit.org/b/197314>
392         <rdar://problem/50245252>
393
394         Reviewed by Simon Fraser.
395
396         * WebKitTestRunner/UIScriptControllerCocoa.mm:
397         (WTR::UIScriptController::lastUndoLabel const):
398         (WTR::UIScriptController::firstRedoLabel const):
399         - Use adopt(JSStringCreateWithCFString(...)) to fix leaks.
400
401         * WebKitTestRunner/ios/HIDEventGenerator.mm:
402         (-[HIDEventGenerator sendEventStream:completionBlock:]):
403         - Call -autorelease to fix leak of NSDictionary.
404
405         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
406         (WTR::UIScriptController::accessibilitySpeakSelectionContent const):
407         (WTR::UIScriptController::selectFormPopoverTitle const):
408         (WTR::UIScriptController::textContentType const):
409         (WTR::UIScriptController::formInputLabel const):
410         (WTR::UIScriptController::scrollingTreeAsText const):
411         - Use adopt(JSStringCreateWithCFString(...)) to fix leaks.
412
413 2019-04-26  Jonathan Bedard  <jbedard@apple.com>
414
415         webkitpy: Running a single test will always use the default device
416         https://bugs.webkit.org/show_bug.cgi?id=195472
417         <rdar://problem/48724825>
418
419         Reviewed by Lucas Forschler.
420
421         It makes more sense to have the Manager class handle the case where a user specifically requests a test which is
422         skipped on the current configuration. This changes the behavior when running part of a test shard, now tests explicitly
423         requested will be run regardless of what shard they are in.
424
425         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
426         (LayoutTestFinder.skip_tests): Caller should manage running skipped tests which were explicitly requested.
427         * Scripts/webkitpy/layout_tests/controllers/manager.py:
428         (Manager.run): If a test is marked as skipped for the configuration, but was specifically requested, run it anyways
429         on the default device type.
430         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
431         (RunTest.test_run_chunk): Explicitly requesting a test will override sharing behavior.
432         (RunTest.test_run_part): Ditto.
433
434 2019-04-26  Alex Christensen  <achristensen@webkit.org>
435
436         Add ENABLE(CONTENT_EXTENSIONS) and namespace ContentExtensions to ResourceLoadInfo.h
437         https://bugs.webkit.org/show_bug.cgi?id=197165
438
439         Reviewed by Youenn Fablet.
440
441         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
442
443 2019-04-26  Ryan Haddad  <ryanhaddad@apple.com>
444
445         Replace iOS build queue hardware
446         https://bugs.webkit.org/show_bug.cgi?id=197312
447
448         Reviewed by Aakash Jain.
449
450         * BuildSlaveSupport/build.webkit.org-config/config.json:
451         Use newer hardware that supports macOS Mojave.
452
453 2019-04-26  Yoshiaki Jitsukawa  <yoshiaki.jitsukawa@sony.com>
454
455         check-webkit-style complains the first block in while loop.
456         https://bugs.webkit.org/show_bug.cgi?id=197307
457
458         The style checker shouldn't complain about an open brace on
459         its own line if the last non-whitespace character on the previous
460         non-blank line is another open brace, because it's likely to
461         indicate the begining of a nested code block.
462
463         Reviewed by Alex Christensen.
464
465         * Scripts/webkitpy/style/checkers/cpp.py:
466         (check_braces):
467         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
468         (WebKitStyleTest.test_braces):
469
470 2019-04-26  Sihui Liu  <sihui_liu@apple.com>
471
472         Stop IDB transactions to release locked database files when network process is ready to suspend
473         https://bugs.webkit.org/show_bug.cgi?id=196372
474         <rdar://problem/48930116>
475
476         Reviewed by Brady Eidson.
477
478         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
479         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBSuspendImminently.html: Added.
480         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBSuspendImminently.mm: Added.
481         (-[IndexedDBSuspendImminentlyMessageHandler userContentController:didReceiveScriptMessage:]):
482         (runTestAndCheckResult):
483         (keepNetworkProcessActive):
484         (TEST):
485
486 2019-04-25  Simon Fraser  <simon.fraser@apple.com>
487
488         REGRESSION (r234330): 3 legacy-animation-engine/compositing tests are flaky failures
489         https://bugs.webkit.org/show_bug.cgi?id=188357
490         <rdar://problem/42986633>
491
492         Reviewed by Dean Jackson.
493
494         DumpRenderTree had no code that set page.setCompositingPolicyOverride() to Normal, so some
495         tests would fall into low memory mode and have different behavior.
496         
497         Fix by moving the code that calls setCompositingPolicyOverride(Normal) from the WK2 layer
498         to Internals, so it's shared by DRT and WTR.
499         
500         We no longer need the WK2 C SPI glue.
501
502         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
503         (WTR::InjectedBundlePage::prepare):
504
505 2019-04-25  Jonathan Bedard  <jbedard@apple.com>
506
507         webkitpy: Including skipped tests in the final count
508         https://bugs.webkit.org/show_bug.cgi?id=197298
509         <rdar://problem/49705424>
510
511         Reviewed by Lucas Forschler.
512
513         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
514         (BuildBotPrinter.print_run_results): The total number of tests run should exclude delibrately skipped tests.
515
516 2019-04-25  Timothy Hatcher  <timothy@apple.com>
517
518         Disable date and time inputs on iOSMac.
519         https://bugs.webkit.org/show_bug.cgi?id=197287
520         rdar://problem/46794376
521
522         Reviewed by Wenson Hsieh.
523
524         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
525
526 2019-04-25  Alex Christensen  <achristensen@webkit.org>
527
528         Fix test-webkitpy after r244653
529         https://bugs.webkit.org/show_bug.cgi?id=197131
530
531         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
532         Also use C++17.
533
534 2019-04-25  Per Arne Vollan  <pvollan@apple.com>
535
536         -[WKWebsiteDataStore fetchDataRecordsOfTypes:completionHandler:] never returns _WKWebsiteDataTypeCredentials
537         https://bugs.webkit.org/show_bug.cgi?id=196991
538         <rdar://problem/45507423>
539
540         Reviewed by Alex Christensen.
541
542         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
543         (-[NavigationTestDelegate init]):
544         (-[NavigationTestDelegate waitForDidFinishNavigation]):
545         (-[NavigationTestDelegate webView:didFinishNavigation:]):
546         (-[NavigationTestDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
547         (TestWebKitAPI::TEST):
548         (TEST): Deleted.
549
550 2019-04-25  Alex Christensen  <achristensen@webkit.org>
551
552         Revert some code accidentally committed with r244653
553         https://bugs.webkit.org/show_bug.cgi?id=197131
554
555         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:
556         (TestWebKitAPI::TEST):
557
558 2019-04-25  Alex Christensen  <achristensen@webkit.org>
559
560         Start using C++17
561         https://bugs.webkit.org/show_bug.cgi?id=197131
562
563         Reviewed by Darin Adler.
564
565         * DumpRenderTree/mac/Configurations/Base.xcconfig:
566         * MiniBrowser/Configurations/Base.xcconfig:
567         * MobileMiniBrowser/Configurations/Base.xcconfig:
568         * TestWebKitAPI/Configurations/Base.xcconfig:
569         * WebKitTestRunner/Configurations/Base.xcconfig:
570
571 2019-04-25  Commit Queue  <commit-queue@webkit.org>
572
573         Unreviewed, rolling out r244627.
574         https://bugs.webkit.org/show_bug.cgi?id=197282
575
576         Causing internal build failures (Requested by ShawnRoberts on
577         #webkit).
578
579         Reverted changeset:
580
581         "Create AVFoundationSoftLink.{h,mm} to reduce duplicate code"
582         https://bugs.webkit.org/show_bug.cgi?id=197171
583         https://trac.webkit.org/changeset/244627
584
585 2019-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
586
587         [GTK] Hardcoded text color in input fields
588         https://bugs.webkit.org/show_bug.cgi?id=126907
589
590         Reviewed by Michael Catanzaro.
591
592         Add dark-mode command line option to MiniBrowser.
593
594         * MiniBrowser/gtk/main.c:
595         (main):
596
597 2019-04-24  Zalan Bujtas  <zalan@apple.com>
598
599         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
600         https://bugs.webkit.org/show_bug.cgi?id=196948
601         <rdar://problem/49927131>
602
603         Reviewed by Tim Horton.
604
605         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
606         (TEST):
607         The expected order of incoming events is
608         1. didInvalidateIntrinsicContentSize
609         2. didFirstLayout
610         At setRenderingProgressDidChange, we already check if didInvalidateIntrinsicContentSize comes in first.
611         However it's not guaranteed that the milestone event is delayed until after TestWebKitAPI::Util::run() is finished
612         (and remember, all we care about is ordering).
613
614 2019-04-24  Eric Carlson  <eric.carlson@apple.com>
615
616         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
617         https://bugs.webkit.org/show_bug.cgi?id=197171
618         <rdar://problem/47454979>
619
620         Reviewed by Youenn Fablet.
621
622         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
623         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
624         (TestWebKitAPI::TEST):
625
626 2019-04-24  Brady Eidson  <beidson@apple.com>
627
628         XMLHTTPRequest POSTs to a custom WKURLSchemeHandler protocol are missing the HTTP body.
629         https://bugs.webkit.org/show_bug.cgi?id=191362
630
631         Reviewed by Alex Christensen.
632
633         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm: Add a test that POSTs all sorts of things
634           from an XHR to a custom protocol.
635
636 2019-04-25  Simon Fraser  <simon.fraser@apple.com>
637
638         DumpRenderTree doesn't call Internals::resetToConsistentState() before the first test
639         https://bugs.webkit.org/show_bug.cgi?id=197273
640
641         Reviewed by Dean Jackson.
642
643         Reorder code so that we create gTestRunner before calling resetWebViewToConsistentStateBeforeTesting(),
644         so that WebCoreTestSupport::resetInternalsObject() is always run.
645
646         * DumpRenderTree/mac/DumpRenderTree.mm:
647         (resetWebViewToConsistentStateBeforeTesting):
648         (runTest):
649
650 2019-04-24  John Wilander  <wilander@apple.com>
651
652         Age out unconverted Ad Click Attributions after one week.
653         https://bugs.webkit.org/show_bug.cgi?id=197238
654         <rdar://problem/50177349>
655
656         Reviewed by Chris Dumez.
657
658         This patch adds infrastructure to allow tests to expire all unconverted
659         attributions early.
660
661         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
662         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
663         (WTR::TestRunner::markAdClickAttributionsAsExpiredForTesting):
664         * WebKitTestRunner/InjectedBundle/TestRunner.h:
665         * WebKitTestRunner/TestController.cpp:
666         (WTR::TestController::markAdClickAttributionsAsExpiredForTesting):
667         * WebKitTestRunner/TestController.h:
668         * WebKitTestRunner/TestInvocation.cpp:
669         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
670
671 2019-04-24  Chris Dumez  <cdumez@apple.com>
672
673         Fix flaky crashes in a couple of PSON API tests
674         https://bugs.webkit.org/show_bug.cgi?id=197239
675
676         Reviewed by Tim Horton.
677
678         Do not adopt the NSURLRequest returned by [NSURLRequest requestWithURL:].
679
680         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
681
682 2019-04-24  Simon Fraser  <simon.fraser@apple.com>
683
684         Make it possible to control the renderTreeAsText output by setting options on testRunner
685         https://bugs.webkit.org/show_bug.cgi?id=197133
686
687         Reviewed by Sam Weinig.
688
689         Add testRunner.setRenderTreeDumpOptions() and expose the subset of RenderAsTextFlag flags
690         that make sense in testing (those that don't dump unstable data like addresses), and plumb
691         these flags through the various framework layers.
692
693         Convert RenderAsTextBehavior to an OptionSet<RenderAsTextFlag>.
694
695         Fix code generation in WebKitTestRunner to generate bindings for IDL const values,
696         and hand-code DumpRenderTree bindings.
697
698         Some cleanup of the TestRunners, using member initializers.
699
700         * DumpRenderTree/TestRunner.cpp:
701         (TestRunner::TestRunner):
702         (setRenderTreeDumpOptionsCallback):
703         (TestRunner::staticFunctions):
704         (TestRunner::setRenderTreeDumpOptions):
705         * DumpRenderTree/TestRunner.h:
706         (TestRunner::renderTreeDumpOptions const):
707         * DumpRenderTree/mac/DumpRenderTree.mm:
708         (dump):
709         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
710         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
711         (WTR::InjectedBundlePage::dump):
712         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
713         (WTR::TestRunner::TestRunner):
714         (WTR::TestRunner::setRenderTreeDumpOptions):
715         * WebKitTestRunner/InjectedBundle/TestRunner.h:
716         (WTR::TestRunner::renderTreeDumpOptions const):
717
718 2019-04-24  Alex Christensen  <achristensen@webkit.org>
719
720         WKContentRuleLists should have a maximum FileProtection of CompleteUnlessOpen
721         https://bugs.webkit.org/show_bug.cgi?id=197078
722         <rdar://problem/49564348>
723
724         Reviewed by Geoff Garen.
725
726         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
727         (TEST_F):
728         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]): Deleted.
729         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]): Deleted.
730         Unfortunately, setting the NSFileProtectionKey attribute is only supported on iOS devices.
731
732 2019-04-24  Alex Christensen  <achristensen@webkit.org>
733
734         Add unit test for r239322
735         https://bugs.webkit.org/show_bug.cgi?id=197236
736
737         Reviewed by Chris Dumez.
738
739         I initially developed this as a unit test for rdar://problem/48797895 but it seems that isn't quite ready.
740         May as well add the test infrastructure which was needed before and will be needed in the future.
741
742         * TestWebKitAPI/TCPServer.cpp:
743         (TestWebKitAPI::TCPServer::TCPServer):
744         * TestWebKitAPI/TCPServer.h:
745         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
746         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
747         (TestWebKitAPI::TEST):
748         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
749         (TestWebKitAPI::downloadAtRate):
750         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
751         (TEST):
752         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm: Added.
753         (-[ProxyDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
754         (-[ProxyDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
755         (TestWebKitAPI::TEST):
756         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
757         (TEST):
758
759 2019-04-24  Chris Dumez  <cdumez@apple.com>
760
761         URL set by document.open() is communicated with the WebPageProxy but not the WebFrameProxy
762         https://bugs.webkit.org/show_bug.cgi?id=197214
763         <rdar://problem/49237544>
764
765         Reviewed by Alex Christensen.
766
767         Extend API test coverage.
768
769         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
770         (TEST):
771
772 2019-04-24  Philippe Normand  <pnormand@igalia.com>
773
774         [Build][GStreamer] Update to 1.16.0
775         https://bugs.webkit.org/show_bug.cgi?id=197157
776
777         Reviewed by Xabier Rodriguez-Calvar.
778
779         The upstreamed patches were removed and a new one was added for a
780         regression detected in the scaletempo GStreamer element. The GNOME
781         Flatpak was migrated to 3.32 and I switched a few modules to Meson
782         on the way, as it is the preferred build system now in GStreamer
783         1.16.
784
785         * flatpak/files/httpd-autogen.sh:
786         * flatpak/flatpakutils.py:
787         (FlatpakPackage.install):
788         (WebkitFlatpak.run_in_sandbox):
789         * flatpak/org.webkit.CommonModules.yaml:
790         * flatpak/org.webkit.WebKit.yaml:
791         * gstreamer/jhbuild.modules:
792         * gstreamer/patches/gst-plugins-bad-0001-aomenc-Add-support-for-10-12bit-decoding.patch: Removed.
793         * gstreamer/patches/gst-plugins-bad-0002-aomenc-Handle-8-bit_depth-images-with-AOM_IMG_FMT_HI.patch: Removed.
794         * gstreamer/patches/gst-plugins-bad-0003-fdkaacenc-Remove-MODE_2_1.patch: Removed.
795         * gstreamer/patches/gst-plugins-bad-0004-fdkaacdec-Use-WAV-channel-mapping-instead-of-interleave-setting.patch: Removed.
796         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Removed.
797         * gstreamer/patches/gst-plugins-base-0001-parsebin-Post-STREAM_COLLECTION-on-EVENT_STREAM_COLL.patch: Removed.
798         * gstreamer/patches/gst-plugins-good-0001-qtdemux-Detect-and-expose-CEA-608-708-Closed-Caption.patch: Removed.
799         * gstreamer/patches/gst-plugins-good-0001-qtdemux-Do-not-run-the-preferred-decryptor-context-q.patch: Removed.
800         * gstreamer/patches/gst-plugins-good-0002-qtdemux-Do-not-unref-a-NULL-stream_tags.patch: Removed.
801         * gstreamer/patches/gst-plugins-good-0002-qtdemux-add-context-for-a-preferred-protection.patch: Removed.
802         * gstreamer/patches/gst-plugins-good-0003-qtdemux-Clarify-field-name-about-stream-encryption-s.patch: Removed.
803         * gstreamer/patches/gst-plugins-good-0003-qtdemux-also-push-buffers-without-encryption-info-in.patch: Removed.
804         * gstreamer/patches/gst-plugins-good-0004-qtdemux-Add-initial-support-for-AV1-demuxing.patch: Removed.
805         * gstreamer/patches/gst-plugins-good-0005-qtdemux-Extract-AV1-codec_data-and-put-it-in-the-cap.patch: Removed.
806         * gstreamer/patches/gst-plugins-good-0006-qtdemux-Recognize-more-AV1-atoms.patch: Removed.
807         * gstreamer/patches/gst-plugins-good-0011-matroska-Add-the-WebM-encrypted-content-support-in-m.patch: Removed.
808         * gstreamer/patches/gst-plugins-good-0012-matroskdemux-do-not-use-MapInfo.data-after-unmapping.patch: Removed.
809         * gstreamer/patches/gst-plugins-good-0013-Avoid-warning-when-reporting-about-decryptors.patch: Removed.
810         * gstreamer/patches/gst-plugins-good-0014-pulse-Mark-default-devices-as-default.patch: Removed.
811         * gstreamer/patches/gst-plugins-good-scaletempo-Advertise-interleaved-layout-in-caps-temp.patch: Added.
812         * gstreamer/patches/gstreamer-0001-protection-Add-a-new-definition-for-unspecified-syst.patch: Removed.
813         * gstreamer/patches/gstreamer-0002-protection-Fix-the-string-to-define-unspecified-syst.patch: Removed.
814
815 2019-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
816
817         [GTK] MiniBrowser: also set the passed bg-color when receiving arguments
818         https://bugs.webkit.org/show_bug.cgi?id=197156
819
820         Reviewed by Michael Catanzaro.
821
822         The background color is only set when MiniBrowser is launched without arguments. This regressed when tabs
823         support was added.
824
825         * MiniBrowser/gtk/BrowserTab.c:
826         (browser_tab_set_background_color): Set the passed in color as web view background color.
827         * MiniBrowser/gtk/BrowserTab.h:
828         * MiniBrowser/gtk/BrowserWindow.c:
829         (browser_window_init): Initialize backgroundColor.
830         (browser_window_append_view): Call browser_tab_set_background_color().
831         (browser_window_set_background_color): Save the passed in color. This function should now be called before tabs
832         are added.
833         * MiniBrowser/gtk/main.c:
834         (main): Call browser_window_set_background_color() before creating the tabs.
835
836 2019-04-23  John Wilander  <wilander@apple.com>
837
838         Move Ad Click Attribution from internal feature to experimental feature
839         https://bugs.webkit.org/show_bug.cgi?id=197218
840         <rdar://problem/47651691>
841
842         Reviewed by Brent Fulgham.
843
844         * DumpRenderTree/TestOptions.cpp:
845         (TestOptions::TestOptions):
846
847 2019-04-23  Andy Estes  <aestes@apple.com>
848
849         [iOS] QuickLook documents loaded from file: URLs should be allowed to perform same-document navigations
850         https://bugs.webkit.org/show_bug.cgi?id=196749
851         <rdar://problem/35773454>
852
853         Reviewed by Daniel Bates.
854
855         Added a new QuickLook API test and added new expectations to existing QuickLook tests.
856
857         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
858         (-[QuickLookDelegate webView:didStartProvisionalNavigation:]):
859         (-[QuickLookDelegate webView:didFinishNavigation:]):
860         (-[QuickLookDelegate _webView:didFailNavigation:withError:userInfo:]):
861         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
862         (runTest):
863         (runTestDecideBeforeLoading):
864         (runTestDecideAfterLoading):
865         (TEST):
866
867 2019-04-23  John Wilander  <wilander@apple.com>
868
869         Remove Ad Click Attribution data when removing website data
870         https://bugs.webkit.org/show_bug.cgi?id=197215
871         <rdar://problem/47668988>
872
873         Reviewed by Chris Dumez.
874
875         This patch adds test infrastructure to delete Ad Click Attribution data
876         through WebsiteDataStore::removeData().
877
878         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
879         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
880         (WTR::TestRunner::clearAdClickAttribution):
881         (WTR::TestRunner::clearAdClickAttributionsThroughWebsiteDataRemoval):
882         * WebKitTestRunner/InjectedBundle/TestRunner.h:
883         * WebKitTestRunner/TestController.cpp:
884         (WTR::TestController::clearAdClickAttributionsThroughWebsiteDataRemoval):
885         * WebKitTestRunner/TestController.h:
886         * WebKitTestRunner/TestInvocation.cpp:
887         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
888
889 2019-04-23  Jonathan Bedard  <jbedard@apple.com>
890
891         webkitpy: Kill unresponsive worker processes
892         https://bugs.webkit.org/show_bug.cgi?id=197205
893         <rdar://problem/50104388>
894
895         Reviewed by Lucas Forschler.
896
897         * Scripts/webkitpy/common/message_pool.py:
898         (_MessagePool.__init__): Add close timeout.
899         (_MessagePool._close): Send termination before joining workers, kill unresponsive workers.
900
901 2019-04-23  Alex Christensen  <achristensen@webkit.org>
902
903         Add unit tests for WKWebView.serverTrust
904         https://bugs.webkit.org/show_bug.cgi?id=197202
905
906         Reviewed by Youenn Fablet
907
908         * TestWebKitAPI/TCPServer.cpp:
909         (TestWebKitAPI::deleter<BIO>::operator()):
910         (TestWebKitAPI::deleter<SSL>::operator()):
911         (TestWebKitAPI::deleter<X509>::operator()):
912         (TestWebKitAPI::deleter<SSL_CTX>::operator()):
913         (TestWebKitAPI::deleter<EVP_PKEY>::operator()):
914         (TestWebKitAPI::TCPServer::TCPServer):
915         (TestWebKitAPI::TCPServer::listenForConnections):
916         * TestWebKitAPI/TCPServer.h:
917         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
918         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
919         (TestWebKitAPI::TEST):
920         (verifyCertificateAndPublicKey):
921         (-[ServerTrustDelegate webView:didFinishNavigation:]):
922         (-[ServerTrustDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
923         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
924         (TestWebKitAPI::downloadAtRate):
925         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
926         (TEST):
927         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
928         (TEST):
929
930 2019-04-23  Commit Queue  <commit-queue@webkit.org>
931
932         Unreviewed, rolling out r244556.
933         https://bugs.webkit.org/show_bug.cgi?id=197212
934
935         Causing build failures on multiple builders (Requested by
936         ShawnRoberts on #webkit).
937
938         Reverted changeset:
939
940         "Create AVFoundationSoftLink.{h,mm} to reduce duplicate code"
941         https://bugs.webkit.org/show_bug.cgi?id=197171
942         https://trac.webkit.org/changeset/244556
943
944 2019-04-23  Alex Christensen  <achristensen@webkit.org>
945
946         Fix iOS build.
947         https://bugs.webkit.org/show_bug.cgi?id=195537
948
949         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
950         (WTR::TestRunner::setOpenPanelFilesMediaIcon):
951         AdoptWK constructor is private now.  Use adoptWK instead.
952
953 2019-04-23  Andres Gonzalez  <andresg_22@apple.com>
954
955         Accessibility text search and selection API enhancements.
956         https://bugs.webkit.org/show_bug.cgi?id=197095
957         <rdar://problem/48181791>
958
959         Reviewed by Chris Fleizach.
960
961         Added new API JS binding code for searchTextWithCriteria to both WTR and DRT.
962
963         * DumpRenderTree/AccessibilityTextMarker.h:
964         * DumpRenderTree/AccessibilityUIElement.cpp:
965         (searchTextWithCriteriaCallback):
966         (AccessibilityUIElement::getJSClass):
967         * DumpRenderTree/AccessibilityUIElement.h:
968         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
969         (convertVectorToObjectArray):
970         (convertNSArrayToVector):
971         (searchTextParameterizedAttributeForCriteria):
972         (AccessibilityUIElement::getLinkedUIElements):
973         (AccessibilityUIElement::getDocumentLinks):
974         (AccessibilityUIElement::getChildren):
975         (AccessibilityUIElement::getChildrenWithRange):
976         (AccessibilityUIElement::rowHeaders const):
977         (AccessibilityUIElement::columnHeaders const):
978         (AccessibilityUIElement::uiElementArrayAttributeValue const):
979         (AccessibilityUIElement::searchTextWithCriteria):
980         (AccessibilityUIElement::attributesOfColumnHeaders):
981         (AccessibilityUIElement::attributesOfRowHeaders):
982         (AccessibilityUIElement::attributesOfColumns):
983         (AccessibilityUIElement::attributesOfRows):
984         (AccessibilityUIElement::attributesOfVisibleCells):
985         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
986         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
987         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
988         (WTR::convertVectorToObjectArray):
989         (WTR::convertNSArrayToVector):
990         (WTR::searchTextParameterizedAttributeForCriteria):
991         (WTR::AccessibilityUIElement::getLinkedUIElements):
992         (WTR::AccessibilityUIElement::getDocumentLinks):
993         (WTR::AccessibilityUIElement::getUIElementsWithAttribute const):
994         (WTR::AccessibilityUIElement::getChildren):
995         (WTR::AccessibilityUIElement::getChildrenWithRange):
996         (WTR::AccessibilityUIElement::rowHeaders const):
997         (WTR::AccessibilityUIElement::columnHeaders const):
998         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue const):
999         (WTR::AccessibilityUIElement::searchTextWithCriteria):
1000         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
1001         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
1002         (WTR::AccessibilityUIElement::attributesOfColumns):
1003         (WTR::AccessibilityUIElement::attributesOfRows):
1004         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
1005         (WTR::convertElementsToObjectArray): Deleted.
1006
1007 2019-04-23  Guy Lewin  <guy@lewin.co.il>
1008
1009         Multiple File Input Icon Set Regardless of File List
1010         https://bugs.webkit.org/show_bug.cgi?id=195537
1011
1012         Reviewed by Alexey Proskuryakov.
1013
1014         Add setOpenPanelFilesMediaIcon to TestRunner in order to test icon and
1015         display string in iOS file inputs
1016
1017         * DumpRenderTree/TestRunner.cpp:
1018         (SetOpenPanelFilesMediaIconCallback):
1019         (TestRunner::staticFunctions):
1020         (TestRunner::setOpenPanelFilesMediaIcon):
1021         * DumpRenderTree/TestRunner.h:
1022         (TestRunner::openPanelFilesMediaIcon const):
1023         * DumpRenderTree/mac/UIDelegate.mm:
1024         (-[UIDelegate webView:runOpenPanelForFileButtonWithResultListener:allowMultipleFiles:]):
1025         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1026         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1027         (WTR::TestRunner::setOpenPanelFilesMediaIcon):
1028         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1029         * WebKitTestRunner/TestController.cpp:
1030         (WTR::runOpenPanel):
1031         (WTR::TestController::resetStateToConsistentValues):
1032         * WebKitTestRunner/TestController.h:
1033         (WTR::TestController::openPanelFileURLsMediaIcon const):
1034         (WTR::TestController::setOpenPanelFileURLsMediaIcon):
1035         * WebKitTestRunner/TestInvocation.cpp:
1036         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1037
1038 2019-04-23  Eric Carlson  <eric.carlson@apple.com>
1039
1040         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
1041         https://bugs.webkit.org/show_bug.cgi?id=197171
1042         <rdar://problem/47454979>
1043
1044         Reviewed by Youenn Fablet.
1045
1046         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1047         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
1048         (TestWebKitAPI::TEST):
1049
1050 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
1051
1052         [ews-build] Add unit tests for UnApplyPatchIfRequired
1053         https://bugs.webkit.org/show_bug.cgi?id=197197
1054
1055         Reviewed by Lucas Forschler.
1056
1057         * BuildSlaveSupport/ews-build/steps_unittest.py:
1058         (TestUnApplyPatchIfRequired):
1059         (TestUnApplyPatchIfRequired.test_success):
1060         (TestUnApplyPatchIfRequired.test_failure):
1061         (TestUnApplyPatchIfRequired.test_skip):
1062
1063 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
1064
1065         [ews-build] Add unit tests for CleanWorkingDirectory
1066         https://bugs.webkit.org/show_bug.cgi?id=197195
1067
1068         Reviewed by Lucas Forschler.
1069
1070         * BuildSlaveSupport/ews-build/steps_unittest.py:
1071         (TestCleanWorkingDirectory):
1072         (TestCleanWorkingDirectory.test_success):
1073         (TestCleanWorkingDirectory.test_failure):
1074
1075 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
1076
1077         [ews-build] Use explicit imports instead of wildcard imports
1078         https://bugs.webkit.org/show_bug.cgi?id=197194
1079
1080         Reviewed by Lucas Forschler.
1081
1082         * BuildSlaveSupport/ews-build/factories.py:
1083         * BuildSlaveSupport/ews-build/loadConfig.py:
1084         * BuildSlaveSupport/ews-build/steps_unittest.py:
1085
1086 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
1087
1088         [ews-build] Add unit tests for DownloadBuiltProduct
1089         https://bugs.webkit.org/show_bug.cgi?id=197193
1090
1091         Reviewed by Lucas Forschler.
1092
1093         * BuildSlaveSupport/ews-build/steps_unittest.py:
1094         (TestDownloadBuiltProduct):
1095         (TestDownloadBuiltProduct.setUp):
1096         (TestDownloadBuiltProduct.tearDown):
1097         (TestDownloadBuiltProduct.test_success):
1098         (TestDownloadBuiltProduct.test_failure):
1099
1100 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
1101
1102         [ews-app] Exception while loading status-bubble when no build step has started
1103         https://bugs.webkit.org/show_bug.cgi?id=196676
1104
1105         Reviewed by Lucas Forschler.
1106
1107         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1108         (StatusBubble.get_build_timestamp): Check if build step is present before accessing its timestamp.
1109
1110 2019-04-23  Stephan Szabo  <stephan.szabo@sony.com>
1111
1112         [PlayStation] Support running of JSC tests on remote playstation devices
1113         https://bugs.webkit.org/show_bug.cgi?id=197170
1114
1115         Reviewed by Ross Kirsling.
1116
1117         Script changes
1118
1119         * Scripts/run-javascriptcore-tests:
1120         (runJSCStressTests): Pass arguments for playstation to
1121         run-jsc-stress-tests
1122         * Scripts/run-jsc-stress-tests:
1123         Handle $hostOS=="playstation" for determineArchitecture, turning
1124         off $isFTLPlatform and runProfiler and defaulting test writer.
1125         * Scripts/webkitdirs.pm:
1126         (jscPath): PlayStation WebKit executables have .elf extension
1127         (executableProductDir): PlayStation builds on Windows hosts but
1128         uses bin directory rather than bin64/bin32 for executable output
1129         location.
1130         * Scripts/webkitruby/jsc-stress-test-writer-playstation.rb: Added.
1131
1132 2019-04-23  Don Olmstead  <don.olmstead@sony.com>
1133
1134         [CMake][Win] Use target oriented design for WebKit
1135         https://bugs.webkit.org/show_bug.cgi?id=197173
1136
1137         Reviewed by Alex Christensen.
1138
1139         * TestWebKitAPI/PlatformWin.cmake: Add WebKitFrameworkHeaders as a dependency.
1140         * TestWebKitAPI/Tests/WebKit/curl/Certificates.cpp: Remove unused header.
1141
1142 2019-04-23  Chris Dumez  <cdumez@apple.com>
1143
1144         [Process-Swap-On-Navigation] WebKit hangs when going back to a form submission's page due to Process-Swap-On-Navigation on iOS 12.2 and higher
1145         https://bugs.webkit.org/show_bug.cgi?id=197097
1146         <rdar://problem/50048318>
1147
1148         Reviewed by Alex Christensen.
1149
1150         Add API test coverage.
1151
1152         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1153         (-[PSONScheme webView:startURLSchemeTask:]):
1154
1155 2019-04-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1156
1157         [ATK] Implement AtkComponentIface scroll_to methods
1158         https://bugs.webkit.org/show_bug.cgi?id=196856
1159
1160         Reviewed by Michael Catanzaro.
1161
1162         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1163         (WTR::AccessibilityUIElement::scrollToMakeVisible): Call atk_component_scroll_to().
1164         (WTR::AccessibilityUIElement::scrollToGlobalPoint): Call atk_component_scroll_to_point().
1165         * gtk/jhbuild.modules: Bump atk, at-spi2-core and at-spi2-atk to their latest stable version.
1166
1167 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
1168
1169         [ews-build] Improve summary for UploadBuiltProduct step
1170         https://bugs.webkit.org/show_bug.cgi?id=197182
1171
1172         Reviewed by Lucas Forschler.
1173
1174         * BuildSlaveSupport/ews-build/steps.py:
1175         (UploadBuiltProduct): Added descriptionDone.
1176         (UploadBuiltProduct.getResultSummary): Overrided getResultSummary.
1177         * BuildSlaveSupport/ews-build/steps_unittest.py:
1178         (TestUploadBuiltProduct.test_success): Updated unit-test.
1179         (TestUploadBuiltProduct.test_failure): Added unit-test for failure case.
1180
1181 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
1182
1183         [ews-build] Trigger queues only after uploading the archive
1184         https://bugs.webkit.org/show_bug.cgi?id=197180
1185
1186         Reviewed by Lucas Forschler.
1187
1188         * BuildSlaveSupport/ews-build/factories.py:
1189         (Factory.__init__):
1190         (BuildFactory.__init__): Remove trigger step from factories.
1191         (BuildFactory.propertiesToPassToTriggers): Deleted.
1192         * BuildSlaveSupport/ews-build/steps.py:
1193         (ConfigureBuild.__init__): Confiure triggers property.
1194         (Trigger): Step to trigger other queues.
1195         (Trigger.propertiesToPassToTriggers): Method to construct properties to pass to triggerred builds.
1196         (UploadBuiltProduct.finished): Trigger builds after upload is successful.
1197
1198 2019-04-22  Alex Christensen  <achristensen@webkit.org>
1199
1200         Deprecate WKContextCreateWithInjectedBundlePath
1201         https://bugs.webkit.org/show_bug.cgi?id=197169
1202
1203         Reviewed by Youenn Fablet.
1204
1205         * TestWebKitAPI/PlatformUtilities.cpp:
1206         (TestWebKitAPI::Util::createContextWithInjectedBundle):
1207         Use WKContextCreateWithConfiguration instead of WKContextCreateWithInjectedBundlePath after having set its injected bundle path.
1208
1209 2019-04-22  Alex Christensen  <achristensen@webkit.org>
1210
1211         REGRESSION(r230681) Do not use stored credentials if WKBundlePageResourceLoadClient.shouldUseCredentialStorage returns false
1212         https://bugs.webkit.org/show_bug.cgi?id=197093
1213         <rdar://problem/49708268>
1214
1215         Reviewed by Chris Dumez.
1216
1217         Add a test that does two loads.  The first load shouldUseCredentialStorage returns true and we provide a persistent credential.
1218         The second load shouldUseCredentialStorage returns false and we verify that a challenge is received with no suggested credential.
1219         We also need to make the TCPServer able to handle more than one connection because we need these two loads to come from the same protection space,
1220         and our current Cocoa implementation of NetworkSession uses two NSURLSessions that don't share a connection cache, one for loads with credentials
1221         and one for loads without credentials, so there are two TCP connections to the same server in this test.
1222
1223         * TestWebKitAPI/TCPServer.cpp:
1224         (TestWebKitAPI::TCPServer::TCPServer):
1225         (TestWebKitAPI::TCPServer::~TCPServer):
1226         (TestWebKitAPI::TCPServer::socketBindListen):
1227         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests): Deleted.
1228         * TestWebKitAPI/TCPServer.h:
1229         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1230         * TestWebKitAPI/Tests/WebKitCocoa/BasicProposedCredentialPlugIn.mm: Added.
1231         (-[BasicProposedCredentialPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1232         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
1233         (respondWithChallengeThenOK):
1234         (TestWebKitAPI::TEST):
1235         (-[ProposedCredentialDelegate webView:didFinishNavigation:]):
1236         (-[ProposedCredentialDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1237         (TEST):
1238
1239 2019-04-22  Chris Dumez  <cdumez@apple.com>
1240
1241         Delayed WebProcessLaunch may break the _relatedWebView SPI
1242         https://bugs.webkit.org/show_bug.cgi?id=197160
1243
1244         Reviewed by Alex Christensen.
1245
1246         Add API test coverage.
1247
1248         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1249
1250 2019-04-22  Dean Johnson  <dean_johnson@apple.com>
1251
1252         Use curl to download packages for webkitpy autoinstaller
1253         https://bugs.webkit.org/show_bug.cgi?id=197164
1254
1255         Reviewed by Darin Adler.
1256
1257         * Scripts/webkitpy/common/system/autoinstall.py:
1258         (AutoInstaller._download): Use curl(1) to download packages necessary for
1259         webkitpy/thirdparty/autoinstalled since Python2's urllib2 module can result in unnecessary
1260         errors which are not present when using curl(1).
1261
1262 2019-04-22  Chris Dumez  <cdumez@apple.com>
1263
1264         Unreviewed, rolling out r244502.
1265
1266         Caused crashes on the bots
1267
1268         Reverted changeset:
1269
1270         "Delayed WebProcessLaunch may break the _relatedWebView SPI"
1271         https://bugs.webkit.org/show_bug.cgi?id=197160
1272         https://trac.webkit.org/changeset/244502
1273
1274 2019-04-22  Ryan Haddad  <ryanhaddad@apple.com>
1275
1276         Unreviewed, rolling out r244437.
1277
1278         Still breaks internal tests.
1279
1280         Reverted changeset:
1281
1282         "InjectedBundle parameters often need initialization function
1283         called before unarchiving"
1284         https://bugs.webkit.org/show_bug.cgi?id=189709
1285         https://trac.webkit.org/changeset/244437
1286
1287 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
1288
1289         [ews-build] Use singular verb in failure description in case of single api test failure
1290         https://bugs.webkit.org/show_bug.cgi?id=197013
1291
1292         Reviewed by Lucas Forschler.
1293
1294         * BuildSlaveSupport/ews-build/steps.py:
1295         (AnalyzeAPITestsResults.analyzeResults):
1296
1297 2019-04-22  Chris Dumez  <cdumez@apple.com>
1298
1299         Delayed WebProcessLaunch may break the _relatedWebView SPI
1300         https://bugs.webkit.org/show_bug.cgi?id=197160
1301
1302         Reviewed by Alex Christensen.
1303
1304         Add API test coverage.
1305
1306         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1307
1308 2019-04-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1309
1310         REGRESSION(r241289): [GTK] accessibility/removed-continuation-element-causes-crash.html and accessibility/removed-anonymous-block-child-causes-crash.html crashes
1311         https://bugs.webkit.org/show_bug.cgi?id=194630
1312
1313         Reviewed by Michael Catanzaro.
1314
1315         Return early from getAttributeSet() is passed in accessible is nullptr.
1316
1317         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1318
1319 2019-04-21  Wenson Hsieh  <wenson_hsieh@apple.com>
1320
1321         Defer EditorState updates until the next layer tree flush in a few additional circumstances
1322         https://bugs.webkit.org/show_bug.cgi?id=197145
1323         <rdar://problem/50078170>
1324
1325         Reviewed by Darin Adler.
1326
1327         Adjusts several editing API tests to wait for a presentation update following a selection change, programmatic
1328         focus, or showing the font manager.
1329
1330         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
1331         (TestWebKitAPI::TEST):
1332         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewTargetForAction.mm:
1333         (TEST):
1334         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
1335         (TestWebKitAPI::TEST):
1336
1337 2019-04-21  Brian Burg  <bburg@apple.com>
1338
1339         WebDriver: add hooks to make it possible to easily run WPT WebDriver web server by itself
1340         https://bugs.webkit.org/show_bug.cgi?id=197125
1341         <rdar://problem/50061468>
1342
1343         Reviewed by Darin Adler.
1344
1345         Sometimes I want to run wptserve independently of tests. Make it easier to script that
1346         using this class rather than making our own ./wpt serve invocation.
1347
1348         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_web_server.py:
1349         (WebDriverW3CWebServer):
1350         (WebDriverW3CWebServer.document_root): Expose this to clients.
1351         (WebDriverW3CWebServer.wait): Add a method that blocks until the server dies.
1352
1353         (WebDriverW3CWebServer.__enter__):
1354         (WebDriverW3CWebServer.__exit__):
1355         Make it possible to use the web server with a 'with' statement.
1356
1357 2019-04-20  Don Olmstead  <don.olmstead@sony.com>
1358
1359         [CMake][Win] Use target oriented design for WebKitLegacy
1360         https://bugs.webkit.org/show_bug.cgi?id=197112
1361
1362         Reviewed by Konstantin Tokarev.
1363
1364         Fix includes and libraries for DumpRenderTree after changes to WebKitLegacy targets.
1365
1366         * DumpRenderTree/CMakeLists.txt:
1367         * DumpRenderTree/PlatformWin.cmake:
1368         * DumpRenderTree/win/EventSender.cpp:
1369
1370 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
1371
1372         Update text for old EWS submit button
1373         https://bugs.webkit.org/show_bug.cgi?id=197140
1374
1375         Reviewed by Alexey Proskuryakov.
1376
1377         * QueueStatusServer/templates/statusbubble.html:
1378
1379 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
1380
1381         [ews-app] New EWS should poll bugzilla more frequently
1382         https://bugs.webkit.org/show_bug.cgi?id=197138
1383
1384         Reviewed by Alexey Proskuryakov.
1385
1386         * BuildSlaveSupport/ews-app/ews/fetcher.py:
1387         (FetchLoop.__init__):
1388
1389 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
1390
1391         [ews-app] Submit to EWS buttons are not aligned properly with status-bubbles
1392         https://bugs.webkit.org/show_bug.cgi?id=197139
1393
1394         Reviewed by Alexey Proskuryakov.
1395
1396         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
1397         * QueueStatusServer/templates/statusbubble.html:
1398
1399 2019-04-20  Chris Dumez  <cdumez@apple.com>
1400
1401         Unreviewed, fix iOS build with recent SDKs.
1402
1403         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1404
1405 2019-04-19  Keith Miller  <keith_miller@apple.com>
1406
1407         Add script to merge run_benchmark jsons
1408         https://bugs.webkit.org/show_bug.cgi?id=197107
1409
1410         Reviewed by Michael Saboff.
1411
1412         The script basically recursively decends through all json objects until it gets
1413         to an array or JSON primitive and concats or takes the first value, respectively.
1414
1415         This patch also adds +x bits to the compare-results script so it
1416         can be run directly from the command line. I had to add a new line so that svn
1417         will accept the change... yay svn!
1418
1419         * Scripts/compare-results:
1420         * Scripts/merge-result-jsons: Added.
1421         (readJSONFile):
1422         (deepAppend):
1423         (mergeJSONs):
1424         (main):
1425
1426 2019-04-18  Ryosuke Niwa  <rniwa@webkit.org>
1427
1428         Crash in FrameLoader::stopAllLoaders via [WebView dealloc] inside ~ObjCEventListener
1429         https://bugs.webkit.org/show_bug.cgi?id=197079
1430
1431         Reviewed by Darin Adler.
1432
1433         Added a regression test. It hits a slightly different backtrace but of the same class of issues.
1434
1435         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1436         * TestWebKitAPI/Tests/WebKitLegacy/mac/DeallocWebViewInEventListener.mm: Added.
1437
1438 2019-04-18  Commit Queue  <commit-queue@webkit.org>
1439
1440         Unreviewed, rolling out r244434.
1441         https://bugs.webkit.org/show_bug.cgi?id=197089
1442
1443         caused 1 API test failure (Requested by zalan on #webkit).
1444
1445         Reverted changeset:
1446
1447         "Regression (r244291): Broken API Test
1448         AutoLayoutRenderingProgressRelativeOrdering"
1449         https://bugs.webkit.org/show_bug.cgi?id=196948
1450         https://trac.webkit.org/changeset/244434
1451
1452 2019-04-18  Wenson Hsieh  <wenson_hsieh@apple.com>
1453
1454         Add new compatibility mode API on WKNavigation
1455         https://bugs.webkit.org/show_bug.cgi?id=197069
1456         <rdar://problem/50025800>
1457
1458         Reviewed by Tim Horton.
1459
1460         Add a block property for -didCommitNavigation to TestNavigationDelegate.
1461
1462         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
1463         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
1464         (-[TestNavigationDelegate webView:didCommitNavigation:]):
1465
1466 2019-04-18  Don Olmstead  <don.olmstead@sony.com>
1467
1468         [CMake] Make WebCore headers copies
1469         https://bugs.webkit.org/show_bug.cgi?id=182512
1470         <rdar://problem/37510435>
1471
1472         Reviewed by Alex Christensen.
1473
1474         Added WebCorePrivateFrameworkHeaders as a dependency of TestWebKitAPI for all
1475         ports.
1476
1477         WebCore now uses WebCore_PRIVATE_INCLUDE_DIRECTORIES for all ports. Any includes
1478         of WebCore headers using "*.h" were modified to <WebCore/*.h>
1479
1480         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
1481         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h:
1482         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h:
1483         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h:
1484         * TestWebKitAPI/CMakeLists.txt:
1485         * TestWebKitAPI/PlatformWin.cmake:
1486         * TestWebKitAPI/Tests/WebCore/AbortableTaskQueue.cpp:
1487         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp:
1488         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1489
1490 2019-04-18  Jer Noble  <jer.noble@apple.com>
1491
1492         Add support for parsing FairPlayStreaming PSSH boxes.
1493         https://bugs.webkit.org/show_bug.cgi?id=197064
1494
1495         Reviewed by Eric Carlson.
1496
1497         * TestWebKitAPI/Tests/WebCore/ISOBox.cpp:
1498         (TestWebKitAPI::TEST):
1499
1500 2019-04-18  Brent Fulgham  <bfulgham@apple.com>
1501
1502         InjectedBundle parameters often need initialization function called before unarchiving
1503         https://bugs.webkit.org/show_bug.cgi?id=189709
1504         <rdar://problem/44573653>
1505
1506         Reviewed by Ryosuke Niwa.
1507
1508         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
1509         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
1510
1511 2019-04-18  Zalan Bujtas  <zalan@apple.com>
1512
1513         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
1514         https://bugs.webkit.org/show_bug.cgi?id=196948
1515         <rdar://problem/49927131>
1516
1517         Reviewed by Tim Horton.
1518
1519         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
1520         (TEST): 
1521         The expected order of incoming events is
1522         1. didInvalidateIntrinsicContentSize
1523         2. didFirstLayout
1524         At setRenderingProgressDidChange, we already check if didInvalidateIntrinsicContentSize comes in first.
1525         However it's not guaranteed that the milestone event is delayed until after TestWebKitAPI::Util::run() is finished
1526         (and remember, all we care about is ordering).
1527
1528 2019-04-18  Ryan Haddad  <ryanhaddad@apple.com>
1529
1530         Unreviewed, rolling out r244299.
1531
1532         Breaks internal tests.
1533
1534         Reverted changeset:
1535
1536         "InjectedBundle parameters often need initialization function
1537         called before unarchiving"
1538         https://bugs.webkit.org/show_bug.cgi?id=189709
1539         https://trac.webkit.org/changeset/244299
1540
1541 2019-04-18  Yusuke Suzuki  <ysuzuki@apple.com>
1542
1543         [WTF] StringBuilder should set correct m_is8Bit flag when merging
1544         https://bugs.webkit.org/show_bug.cgi?id=197053
1545
1546         Reviewed by Saam Barati.
1547
1548         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
1549         (TestWebKitAPI::TEST):
1550
1551 2019-04-17  Tim Horton  <timothy_horton@apple.com>
1552
1553         [iOS Sim Debug] REGRESSION (r244151) TestWebKitAPI.WebKit.OverrideViewportArguments is failing (197028)
1554         https://bugs.webkit.org/show_bug.cgi?id=197028
1555         <rdar://problem/49985290>
1556
1557         Reviewed by Wenson Hsieh.
1558
1559         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm:
1560         (TEST):
1561         Liberal application of waitForNextPresentationUpdate works around a race
1562         where if the page rapidly changes its viewport arguments (or an API client
1563         rapidly changes its viewport arguments), we'd get stuck thinking that the
1564         user had intentionally zoomed the page, and stop resetting the initial scale.
1565         This deserves a separate bug, but no need to keep the test failing while
1566         we think about it.
1567
1568 2019-04-17  Tim Horton  <timothy_horton@apple.com>
1569
1570         REGRESSION (r241988): Switching tabs is slow
1571         https://bugs.webkit.org/show_bug.cgi?id=197037
1572         <rdar://problem/49951473>
1573
1574         Reviewed by Simon Fraser.
1575
1576         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1577         * TestWebKitAPI/Tests/WebKitCocoa/ReparentWebViewTimeout.mm: Added.
1578         (TEST):
1579         * TestWebKitAPI/cocoa/TestWKWebView.h:
1580         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1581         (-[TestWKWebView addToTestWindow]):
1582         Add a test that hangs without this fix.
1583
1584 2019-04-17  Truitt Savell  <tsavell@apple.com>
1585
1586         Unreviewed, rolling out r244400.
1587
1588         Caused testing to exit early with assertionon Debug WK2
1589
1590         Reverted changeset:
1591
1592         "UI↔Web deadlock when printing with a JavaScript alert
1593         visible"
1594         https://bugs.webkit.org/show_bug.cgi?id=196839
1595         https://trac.webkit.org/changeset/244400
1596
1597 2019-04-17  Brady Eidson  <beidson@apple.com>
1598
1599         Link clicks in PDFs shouldn't send referrer headers.
1600         <rdar://problem/21142581> and https://bugs.webkit.org/show_bug.cgi?id=196980
1601
1602         Reviewed by Tim Horton.
1603
1604         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1605         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm: Added.
1606         (putPDFBytesCallback):
1607         (emptyReleaseInfoCallback):
1608         (createPDFWithLinkToURL):
1609         (TEST):
1610
1611 2019-04-17  Tim Horton  <timothy_horton@apple.com>
1612
1613         UI↔Web deadlock when printing with a JavaScript alert visible
1614         https://bugs.webkit.org/show_bug.cgi?id=196839
1615         <rdar://problem/49157642>
1616
1617         Reviewed by Andy Estes.
1618
1619         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1620         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewPrintFormatter.mm: Added.
1621         (-[PrintOnAlertUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1622         (TEST):
1623
1624 2019-04-17  Alex Christensen  <achristensen@webkit.org>
1625
1626         WKRetainPtr's adoption constructor should be private
1627         https://bugs.webkit.org/show_bug.cgi?id=197019
1628
1629         Reviewed by Tim Horton.
1630
1631         * DumpRenderTree/mac/DumpRenderTree.mm:
1632         (dumpFramesAsText):
1633         * TestWebKitAPI/InjectedBundleController.cpp:
1634         (TestWebKitAPI::InjectedBundleController::initialize):
1635         * TestWebKitAPI/PlatformUtilities.cpp:
1636         (TestWebKitAPI::Util::createContextWithInjectedBundle):
1637         (TestWebKitAPI::Util::createInitializationDictionaryForInjectedBundleTest):
1638         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
1639         (TestWebKitAPI::Util::toWK):
1640         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
1641         (TestWebKitAPI::TEST):
1642         * TestWebKitAPI/Tests/WebKit/CloseFromWithinCreatePage.cpp:
1643         (TestWebKitAPI::TEST):
1644         * TestWebKitAPI/Tests/WebKit/CloseThenTerminate.cpp:
1645         (TestWebKitAPI::TEST):
1646         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic.cpp:
1647         (TestWebKitAPI::TEST):
1648         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic_Bundle.cpp:
1649         (TestWebKitAPI::DOMWindowExtensionBasic::initialize):
1650         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache.cpp:
1651         (TestWebKitAPI::TEST):
1652         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache_Bundle.cpp:
1653         (TestWebKitAPI::DOMWindowExtensionNoCache::initialize):
1654         * TestWebKitAPI/Tests/WebKit/DeferredViewInWindowStateChange.mm:
1655         (TestWebKitAPI::TEST):
1656         * TestWebKitAPI/Tests/WebKit/DidNotHandleKeyDown.cpp:
1657         (TestWebKitAPI::TEST):
1658         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
1659         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
1660         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash.cpp:
1661         (TestWebKitAPI::TEST):
1662         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash_Bundle.cpp:
1663         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):
1664         * TestWebKitAPI/Tests/WebKit/EnumerateMediaDevices.cpp:
1665         (TestWebKitAPI::TEST):
1666         * TestWebKitAPI/Tests/WebKit/EphemeralSessionPushStateNoHistoryCallback.cpp:
1667         (TestWebKitAPI::TEST):
1668         * TestWebKitAPI/Tests/WebKit/EvaluateJavaScript.cpp:
1669         (TestWebKitAPI::TEST):
1670         * TestWebKitAPI/Tests/WebKit/EventModifiers.cpp:
1671         (TestWebKitAPI::TEST):
1672         * TestWebKitAPI/Tests/WebKit/FailedLoad.cpp:
1673         (TestWebKitAPI::TEST):
1674         * TestWebKitAPI/Tests/WebKit/Find.cpp:
1675         (TestWebKitAPI::TEST):
1676         * TestWebKitAPI/Tests/WebKit/FindMatches.mm:
1677         (TestWebKitAPI::TEST):
1678         * TestWebKitAPI/Tests/WebKit/FirstMeaningfulPaintMilestone.cpp:
1679         (TestWebKitAPI::TEST):
1680         * TestWebKitAPI/Tests/WebKit/ForceRepaint.cpp:
1681         (TestWebKitAPI::TEST):
1682         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp:
1683         (TestWebKitAPI::TEST):
1684         * TestWebKitAPI/Tests/WebKit/FrameMIMETypeHTML.cpp:
1685         (TestWebKitAPI::TEST):
1686         * TestWebKitAPI/Tests/WebKit/FrameMIMETypePNG.cpp:
1687         (TestWebKitAPI::TEST):
1688         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
1689         (TestWebKitAPI::TEST):
1690         * TestWebKitAPI/Tests/WebKit/GetInjectedBundleInitializationUserDataCallback.cpp:
1691         (TestWebKitAPI::TEST):
1692         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle.cpp:
1693         (TestWebKitAPI::TEST):
1694         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle_Bundle.cpp:
1695         (TestWebKitAPI::HitTestResultNodeHandleTest::getContextMenuFromDefaultMenu):
1696         * TestWebKitAPI/Tests/WebKit/InjectedBundleBasic.cpp:
1697         (TestWebKitAPI::TEST):
1698         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior.cpp:
1699         (TestWebKitAPI::TEST):
1700         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior_Bundle.cpp:
1701         (TestWebKitAPI::InjectedBundleNoDisableOverrideBuiltinsBehaviorTest::initialize):
1702         (TestWebKitAPI::InjectedBundleDisableOverrideBuiltinsBehaviorTest::initialize):
1703         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest.cpp:
1704         (TestWebKitAPI::TEST):
1705         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest_Bundle.cpp:
1706         (TestWebKitAPI::InjectedBundleFrameHitTestTest::frameLoadFinished):
1707         * TestWebKitAPI/Tests/WebKit/InjectedBundleInitializationUserDataCallbackWins.cpp:
1708         (TestWebKitAPI::TEST):
1709         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen.cpp:
1710         (TestWebKitAPI::TEST):
1711         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen_Bundle.cpp:
1712         (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize):
1713         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
1714         (TestWebKitAPI::TEST):
1715         * TestWebKitAPI/Tests/WebKit/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
1716         (TestWebKitAPI::loadAlternateHTMLString):
1717         (TestWebKitAPI::TEST):
1718         * TestWebKitAPI/Tests/WebKit/LoadCanceledNoServerRedirectCallback.cpp:
1719         (TestWebKitAPI::TEST):
1720         * TestWebKitAPI/Tests/WebKit/LoadPageOnCrash.cpp:
1721         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
1722         * TestWebKitAPI/Tests/WebKit/MenuTypesForMouseEvents.cpp:
1723         (TestWebKitAPI::buildAndPerformTest):
1724         * TestWebKitAPI/Tests/WebKit/ModalAlertsSPI.cpp:
1725         (TestWebKitAPI::TEST):
1726         * TestWebKitAPI/Tests/WebKit/MouseMoveAfterCrash.cpp:
1727         (TestWebKitAPI::TEST):
1728         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayout.cpp:
1729         (TestWebKitAPI::TEST):
1730         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFails.cpp:
1731         (TestWebKitAPI::TEST):
1732         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
1733         (TestWebKitAPI::TEST):
1734         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
1735         (TestWebKitAPI::TEST):
1736         * TestWebKitAPI/Tests/WebKit/PageLoadBasic.cpp:
1737         (TestWebKitAPI::TEST):
1738         * TestWebKitAPI/Tests/WebKit/PageLoadDidChangeLocationWithinPageForFrame.cpp:
1739         (TestWebKitAPI::TEST):
1740         * TestWebKitAPI/Tests/WebKit/PasteboardNotifications.mm:
1741         (TestWebKitAPI::TEST):
1742         * TestWebKitAPI/Tests/WebKit/PendingAPIRequestURL.cpp:
1743         (TestWebKitAPI::TEST):
1744         * TestWebKitAPI/Tests/WebKit/PreventEmptyUserAgent.cpp:
1745         (TestWebKitAPI::TEST):
1746         * TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp:
1747         (TestWebKitAPI::TEST):
1748         * TestWebKitAPI/Tests/WebKit/ProcessDidTerminate.cpp:
1749         (TestWebKitAPI::TEST):
1750         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1751         (TestWebKitAPI::TEST):
1752         * TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:
1753         (TestWebKitAPI::TEST):
1754         * TestWebKitAPI/Tests/WebKit/ResizeWindowAfterCrash.cpp:
1755         (TestWebKitAPI::TEST):
1756         * TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp:
1757         (TestWebKitAPI::TEST):
1758         * TestWebKitAPI/Tests/WebKit/RestoreSessionStateContainingFormData.cpp:
1759         (TestWebKitAPI::TEST):
1760         * TestWebKitAPI/Tests/WebKit/ScrollPinningBehaviors.cpp:
1761         (TestWebKitAPI::TEST):
1762         * TestWebKitAPI/Tests/WebKit/ShouldKeepCurrentBackForwardListItemInList.cpp:
1763         (TestWebKitAPI::TEST):
1764         * TestWebKitAPI/Tests/WebKit/SpacebarScrolling.cpp:
1765         (TestWebKitAPI::TEST):
1766         * TestWebKitAPI/Tests/WebKit/StopLoadingDuringDidFailProvisionalLoad.cpp:
1767         (TestWebKitAPI::TEST):
1768         * TestWebKitAPI/Tests/WebKit/TerminateTwice.cpp:
1769         (TestWebKitAPI::TEST):
1770         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
1771         (TestWebKitAPI::TEST):
1772         * TestWebKitAPI/Tests/WebKit/WKPageCopySessionStateWithFiltering.cpp:
1773         (TestWebKitAPI::TEST):
1774         * TestWebKitAPI/Tests/WebKit/WKPageGetScaleFactorNotZero.cpp:
1775         (TestWebKitAPI::TEST):
1776         * TestWebKitAPI/Tests/WebKit/WKPageIsPlayingAudio.cpp:
1777         (TestWebKitAPI::TEST):
1778         * TestWebKitAPI/Tests/WebKit/WKPreferences.cpp:
1779         (TestWebKitAPI::TEST):
1780         * TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm:
1781         (TestWebKitAPI::TEST):
1782         * TestWebKitAPI/Tests/WebKit/WillSendSubmitEvent.cpp:
1783         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
1784         * TestWebKitAPI/Tests/WebKit/mac/AttributedSubstringForProposedRangeWithImage.mm:
1785         (TestWebKitAPI::TEST):
1786         * TestWebKitAPI/Tests/WebKit/mac/ContextMenuDownload.mm:
1787         (TestWebKitAPI::TEST):
1788         * TestWebKitAPI/Tests/WebKit/mac/CustomBundleParameter.mm:
1789         (TestWebKitAPI::TEST):
1790         * TestWebKitAPI/Tests/WebKit/mac/EditorCommands.mm:
1791         (TestWebKitAPI::TEST):
1792         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
1793         (TestWebKitAPI::TEST):
1794         * TestWebKitAPI/Tests/WebKit/mac/GetPIDAfterAbortedProcessLaunch.cpp:
1795         (TestWebKitAPI::TEST):
1796         * TestWebKitAPI/Tests/WebKit/mac/InjectedBundleAppleEvent.cpp:
1797         (TestWebKitAPI::TEST):
1798         * TestWebKitAPI/Tests/WebKit/mac/RestoreStateAfterTermination.mm:
1799         (TestWebKitAPI::TEST):
1800         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
1801         (TestWebKitAPI::TEST):
1802         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
1803         (TestWebKitAPI::TEST):
1804         * TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm:
1805         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm:
1806         (TEST):
1807         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
1808         (TEST):
1809         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1810         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1811         (TEST):
1812         * TestWebKitAPI/Tests/mac/FirstResponderScrollingPosition.mm:
1813         (TestWebKitAPI::TEST):
1814         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
1815         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
1816         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1817         (WTR::getMenuItemTitleCallback):
1818         (WTR::createMouseMessageBody):
1819         (WTR::EventSendingController::mouseDown):
1820         (WTR::EventSendingController::mouseUp):
1821         (WTR::EventSendingController::mouseMoveTo):
1822         (WTR::EventSendingController::mouseForceClick):
1823         (WTR::EventSendingController::startAndCancelMouseForceClick):
1824         (WTR::EventSendingController::mouseForceDown):
1825         (WTR::EventSendingController::mouseForceUp):
1826         (WTR::EventSendingController::mouseForceChanged):
1827         (WTR::EventSendingController::leapForward):
1828         (WTR::EventSendingController::scheduleAsynchronousClick):
1829         (WTR::createKeyDownMessageBody):
1830         (WTR::EventSendingController::keyDown):
1831         (WTR::EventSendingController::scheduleAsynchronousKeyDown):
1832         (WTR::EventSendingController::mouseScrollBy):
1833         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
1834         (WTR::EventSendingController::continuousMouseScrollBy):
1835         (WTR::EventSendingController::addTouchPoint):
1836         (WTR::EventSendingController::updateTouchPoint):
1837         (WTR::EventSendingController::setTouchModifier):
1838         (WTR::EventSendingController::setTouchPointRadius):
1839         (WTR::EventSendingController::touchStart):
1840         (WTR::EventSendingController::touchMove):
1841         (WTR::EventSendingController::touchEnd):
1842         (WTR::EventSendingController::touchCancel):
1843         (WTR::EventSendingController::clearTouchPoints):
1844         (WTR::EventSendingController::releaseTouchPoint):
1845         (WTR::EventSendingController::cancelTouchPoint):
1846         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1847         (WTR::InjectedBundle::didCreatePage):
1848         (WTR::InjectedBundle::didReceiveMessage):
1849         (WTR::InjectedBundle::didReceiveMessageToPage):
1850         (WTR::InjectedBundle::booleanForKey):
1851         (WTR::InjectedBundle::done):
1852         (WTR::InjectedBundle::dumpToStdErr):
1853         (WTR::InjectedBundle::outputText):
1854         (WTR::InjectedBundle::postNewBeforeUnloadReturnValue):
1855         (WTR::InjectedBundle::postAddChromeInputField):
1856         (WTR::InjectedBundle::postRemoveChromeInputField):
1857         (WTR::InjectedBundle::postFocusWebView):
1858         (WTR::InjectedBundle::postSetBackingScaleFactor):
1859         (WTR::InjectedBundle::postSetWindowIsKey):
1860         (WTR::InjectedBundle::postSetViewSize):
1861         (WTR::InjectedBundle::postSimulateWebNotificationClick):
1862         (WTR::InjectedBundle::postSetAddsVisitedLinks):
1863         (WTR::InjectedBundle::setGeolocationPermission):
1864         (WTR::InjectedBundle::setMockGeolocationPosition):
1865         (WTR::InjectedBundle::setMockGeolocationPositionUnavailableError):
1866         (WTR::InjectedBundle::isGeolocationProviderActive const):
1867         (WTR::InjectedBundle::imageCountInGeneralPasteboard const):
1868         (WTR::InjectedBundle::setUserMediaPersistentPermissionForOrigin):
1869         (WTR::InjectedBundle::userMediaPermissionRequestCountForOrigin const):
1870         (WTR::InjectedBundle::resetUserMediaPermissionRequestCountForOrigin):
1871         (WTR::InjectedBundle::setCustomPolicyDelegate):
1872         (WTR::InjectedBundle::setHidden):
1873         (WTR::InjectedBundle::setCacheModel):
1874         (WTR::InjectedBundle::shouldProcessWorkQueue const):
1875         (WTR::InjectedBundle::processWorkQueue):
1876         (WTR::InjectedBundle::queueBackNavigation):
1877         (WTR::InjectedBundle::queueForwardNavigation):
1878         (WTR::InjectedBundle::queueLoad):
1879         (WTR::InjectedBundle::queueLoadHTMLString):
1880         (WTR::InjectedBundle::queueReload):
1881         (WTR::InjectedBundle::queueLoadingScript):
1882         (WTR::InjectedBundle::queueNonLoadingScript):
1883         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1884         (WTR::frameToStr):
1885         (WTR::InjectedBundlePage::InjectedBundlePage):
1886         (WTR::dumpFrameDescriptionSuitableForTestResult):
1887         (WTR::dumpFrameScrollPosition):
1888         (WTR::dumpDescendantFrameScrollPositions):
1889         (WTR::dumpFrameText):
1890         (WTR::dumpDescendantFramesText):
1891         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1892         (WTR::TestRunner::shouldDumpPixels const):
1893         (WTR::TestRunner::setDumpPixels):
1894         (WTR::TestRunner::whatToDump const):
1895         (WTR::TestRunner::setWhatToDump):
1896         (WTR::TestRunner::setWaitUntilDone):
1897         (WTR::TestRunner::shouldWaitUntilDone const):
1898         (WTR::TestRunner::setShouldDumpFrameLoadCallbacks):
1899         (WTR::TestRunner::shouldDumpFrameLoadCallbacks):
1900         (WTR::TestRunner::clearAllDatabases):
1901         (WTR::TestRunner::setIDBPerOriginQuota):
1902         (WTR::TestRunner::originsWithApplicationCache):
1903         (WTR::TestRunner::setCanOpenWindows):
1904         (WTR::TestRunner::setXSSAuditorEnabled):
1905         (WTR::TestRunner::setMediaDevicesEnabled):
1906         (WTR::TestRunner::setWebRTCMDNSICECandidatesEnabled):
1907         (WTR::TestRunner::setWebRTCUnifiedPlanEnabled):
1908         (WTR::TestRunner::setCustomUserAgent):
1909         (WTR::TestRunner::setWebAPIStatisticsEnabled):
1910         (WTR::TestRunner::setModernMediaControlsEnabled):
1911         (WTR::TestRunner::setWebGL2Enabled):
1912         (WTR::TestRunner::setWritableStreamAPIEnabled):
1913         (WTR::TestRunner::setReadableByteStreamAPIEnabled):
1914         (WTR::TestRunner::setEncryptedMediaAPIEnabled):
1915         (WTR::TestRunner::setAllowsAnySSLCertificate):
1916         (WTR::TestRunner::setPluginsEnabled):
1917         (WTR::TestRunner::setValueForUser):
1918         (WTR::TestRunner::setAudioResult):
1919         (WTR::TestRunner::didReceiveServerRedirectForProvisionalNavigation const):
1920         (WTR::TestRunner::clearDidReceiveServerRedirectForProvisionalNavigation):
1921         (WTR::TestRunner::setAlwaysAcceptCookies):
1922         (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
1923         (WTR::TestRunner::isDoingMediaCapture const):
1924         (WTR::TestRunner::queueLoad):
1925         (WTR::TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
1926         (WTR::TestRunner::setHandlesAuthenticationChallenges):
1927         (WTR::TestRunner::setShouldLogCanAuthenticateAgainstProtectionSpace):
1928         (WTR::TestRunner::setShouldLogDownloadCallbacks):
1929         (WTR::TestRunner::setAuthenticationUsername):
1930         (WTR::TestRunner::setAuthenticationPassword):
1931         (WTR::TestRunner::secureEventInputIsEnabled const):
1932         (WTR::TestRunner::setBlockAllPlugins):
1933         (WTR::TestRunner::setPluginSupportedMode):
1934         (WTR::TestRunner::setShouldDecideNavigationPolicyAfterDelay):
1935         (WTR::TestRunner::setShouldDecideResponsePolicyAfterDelay):
1936         (WTR::TestRunner::setNavigationGesturesEnabled):
1937         (WTR::TestRunner::setIgnoresViewportScaleLimits):
1938         (WTR::TestRunner::setShouldDownloadUndisplayableMIMETypes):
1939         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
1940         (WTR::TestRunner::terminateNetworkProcess):
1941         (WTR::TestRunner::terminateServiceWorkerProcess):
1942         (WTR::TestRunner::runUIScript):
1943         (WTR::TestRunner::setStatisticsDebugMode):
1944         (WTR::TestRunner::setStatisticsPrevalentResourceForDebugMode):
1945         (WTR::TestRunner::setStatisticsLastSeen):
1946         (WTR::TestRunner::setStatisticsPrevalentResource):
1947         (WTR::TestRunner::setStatisticsVeryPrevalentResource):
1948         (WTR::TestRunner::dumpResourceLoadStatistics):
1949         (WTR::TestRunner::isStatisticsPrevalentResource):
1950         (WTR::TestRunner::isStatisticsVeryPrevalentResource):
1951         (WTR::TestRunner::isStatisticsRegisteredAsSubresourceUnder):
1952         (WTR::TestRunner::isStatisticsRegisteredAsSubFrameUnder):
1953         (WTR::TestRunner::isStatisticsRegisteredAsRedirectingTo):
1954         (WTR::TestRunner::setStatisticsHasHadUserInteraction):
1955         (WTR::TestRunner::isStatisticsHasHadUserInteraction):
1956         (WTR::TestRunner::setStatisticsGrandfathered):
1957         (WTR::TestRunner::isStatisticsGrandfathered):
1958         (WTR::TestRunner::setStatisticsSubframeUnderTopFrameOrigin):
1959         (WTR::TestRunner::setStatisticsSubresourceUnderTopFrameOrigin):
1960         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectTo):
1961         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectFrom):
1962         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectTo):
1963         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectFrom):
1964         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
1965         (WTR::TestRunner::setStatisticsTimeToLiveUserInteraction):
1966         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback):
1967         (WTR::TestRunner::statisticsProcessStatisticsAndDataRecords):
1968         (WTR::TestRunner::statisticsUpdateCookieBlocking):
1969         (WTR::TestRunner::statisticsSubmitTelemetry):
1970         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
1971         (WTR::TestRunner::setStatisticsIsRunningTest):
1972         (WTR::TestRunner::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
1973         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
1974         (WTR::TestRunner::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
1975         (WTR::TestRunner::setStatisticsGrandfatheringTime):
1976         (WTR::TestRunner::setStatisticsMaxStatisticsEntries):
1977         (WTR::TestRunner::setStatisticsPruneEntriesDownTo):
1978         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
1979         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
1980         (WTR::TestRunner::statisticsClearThroughWebsiteDataRemoval):
1981         (WTR::TestRunner::statisticsDeleteCookiesForHost):
1982         (WTR::TestRunner::setStatisticsCacheMaxAgeCap):
1983         (WTR::TestRunner::statisticsResetToConsistentState):
1984         (WTR::TestRunner::setStorageAccessAPIEnabled):
1985         (WTR::TestRunner::getAllStorageAccessEntries):
1986         (WTR::TestRunner::addMockMediaDevice):
1987         (WTR::TestRunner::clearMockMediaDevices):
1988         (WTR::TestRunner::removeMockMediaDevice):
1989         (WTR::TestRunner::resetMockMediaDevices):
1990         (WTR::TestRunner::connectMockGamepad):
1991         (WTR::TestRunner::disconnectMockGamepad):
1992         (WTR::TestRunner::setMockGamepadDetails):
1993         (WTR::TestRunner::setMockGamepadAxisValue):
1994         (WTR::TestRunner::setMockGamepadButtonValue):
1995         (WTR::TestRunner::removeAllSessionCredentials):
1996         (WTR::TestRunner::clearDOMCache):
1997         (WTR::TestRunner::clearDOMCaches):
1998         (WTR::TestRunner::hasDOMCache):
1999         (WTR::TestRunner::domCacheSize):
2000         (WTR::TestRunner::setAllowStorageQuotaIncrease):
2001         (WTR::TestRunner::getApplicationManifestThen):
2002         (WTR::TestRunner::injectUserScript):
2003         (WTR::TestRunner::sendDisplayConfigurationChangedMessageForTesting):
2004         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
2005         (WTR::TestRunner::addTestKeyToKeychain):
2006         (WTR::TestRunner::cleanUpKeychain):
2007         (WTR::TestRunner::keyExistsInKeychain):
2008         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
2009         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
2010         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
2011         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
2012         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
2013         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
2014         * WebKitTestRunner/TestController.cpp:
2015         (WTR::TestController::initialize):
2016         (WTR::parseStringTestHeaderValueAsRelativePath):
2017         (WTR::updateTestOptionsFromTestHeader):
2018         (WTR::TestController::runTest):
2019         (WTR::TestController::didReceiveLiveDocumentsList):
2020         (WTR::TestController::didReceiveMessageFromInjectedBundle):
2021         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
2022         (WTR::TestController::didFinishNavigation):
2023         (WTR::TestController::didReceiveAuthenticationChallenge):
2024         * WebKitTestRunner/TestInvocation.cpp:
2025         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2026         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2027         (WTR::TestInvocation::uiScriptDidComplete):
2028         (WTR::TestInvocation::didReceiveAllStorageAccessEntries):
2029         * WebKitTestRunner/WebNotificationProvider.cpp:
2030         (WTR::WebNotificationProvider::closeWebNotification):
2031         * WebKitTestRunner/WorkQueueManager.cpp:
2032         (WTR::ScriptItem::ScriptItem):
2033         (WTR::WorkQueueManager::queueLoad):
2034         (WTR::WorkQueueManager::queueLoadHTMLString):
2035
2036 2019-04-17  Alex Christensen  <achristensen@webkit.org>
2037
2038         Add a comment to make my test from r244139 less mysterious.
2039         https://bugs.webkit.org/show_bug.cgi?id=196744
2040
2041         As suggested by Darin Adler.
2042
2043         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
2044         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2045
2046 2019-04-17  Chris Dumez  <cdumez@apple.com>
2047
2048         Remember device orientation permission for the duration of the browsing session
2049         https://bugs.webkit.org/show_bug.cgi?id=196992
2050         <rdar://problem/49946067>
2051
2052         Reviewed by Alex Christensen.
2053
2054         Add API test coverage.
2055
2056         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:
2057         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2058         (TEST):
2059
2060 2019-04-17  Aakash Jain  <aakash_jain@apple.com>
2061
2062         [ews-app] Clicking 'submit to new ews' doesn't reload status-bubble
2063         https://bugs.webkit.org/show_bug.cgi?id=196675
2064
2065         Reviewed by Lucas Forschler.
2066
2067         * BuildSlaveSupport/ews-app/ews/views/submittoews.py:
2068         (SubmitToEWS): Added @xframe_options_exempt similar to statusbubble.py
2069
2070 2019-04-16  Wenson Hsieh  <wenson_hsieh@apple.com>
2071
2072         [iOS] [WebKit2] Add support for honoring -[UIMenuItem dontDismiss]
2073         https://bugs.webkit.org/show_bug.cgi?id=196919
2074         <rdar://problem/41630459>
2075
2076         Reviewed by Tim Horton.
2077
2078         Add iOS support for several new testing hooks. See below for more detail.
2079
2080         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2081         (WTR::UIScriptController::isDismissingMenu const):
2082
2083         Add a new script controller method to query whether the platform menu (on iOS, the callout bar) is done
2084         dismissing. We consider the menu to be dismissing in between the `-WillHide` and `-DidHide` notifications sent
2085         by UIKit when dismissing the callout bar (i.e. UIMenuController).
2086
2087         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2088         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2089         (WTR::UIScriptController::isDismissingMenu const):
2090         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2091         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2092         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2093         (WTR::InjectedBundle::didReceiveMessageToPage):
2094         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2095         (WTR::TestRunner::setAllowedMenuActions):
2096
2097         Add a new helper method to specify a list of allowed actions when bringing up the menu. On iOS, in the case of
2098         actions supported by the platform, this matches against method selector names (for instance, "SelectAll", or
2099         "Copy", or "Paste"). In the case of the custom actions installed via `installCustomMenuAction`, we instead match
2100         against the name of the custom action.
2101
2102         (WTR::TestRunner::installCustomMenuAction):
2103
2104         Add a new helper method to install a custom action for the context menu (on iOS, this is the callout bar). This
2105         takes the name of the action (which appears in a button in the callout bar), whether the action should cause
2106         the callout bar to automatically dismiss, and finally, a JavaScript callback that is invoked when the action is
2107         triggered.
2108
2109         (WTR::TestRunner::performCustomMenuAction):
2110
2111         Invoked when the custom menu action is triggered.
2112
2113         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2114         * WebKitTestRunner/TestController.cpp:
2115         (WTR::TestController::installCustomMenuAction):
2116         (WTR::TestController::setAllowedMenuActions):
2117         * WebKitTestRunner/TestController.h:
2118         * WebKitTestRunner/TestInvocation.cpp:
2119         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2120         (WTR::TestInvocation::performCustomMenuAction):
2121
2122         Add plumbing to call back into the injected bundle when performing the custom action.
2123
2124         * WebKitTestRunner/TestInvocation.h:
2125         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2126         (WTR::TestController::installCustomMenuAction):
2127         (WTR::TestController::setAllowedMenuActions):
2128         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2129         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2130         (-[TestRunnerWKWebView initWithFrame:configuration:]):
2131         (-[TestRunnerWKWebView becomeFirstResponder]):
2132         (-[TestRunnerWKWebView _addCustomItemToMenuControllerIfNecessary]):
2133
2134         Helper method that converts web view's current custom menu action info into a UIMenuItem, and adds it to the
2135         shared menu controller. This is also invoked when the web view becomes first responder, which matches behavior
2136         in the Mail app on iOS.
2137
2138         (-[TestRunnerWKWebView installCustomMenuAction:dismissesAutomatically:callback:]):
2139         (-[TestRunnerWKWebView setAllowedMenuActions:]):
2140         (-[TestRunnerWKWebView resetCustomMenuAction]):
2141         (-[TestRunnerWKWebView performCustomAction:]):
2142         (-[TestRunnerWKWebView canPerformAction:withSender:]):
2143         (-[TestRunnerWKWebView _willHideMenu]):
2144         (-[TestRunnerWKWebView _didHideMenu]):
2145         * WebKitTestRunner/ios/TestControllerIOS.mm:
2146         (WTR::TestController::platformResetStateToConsistentValues):
2147
2148         Reset both any custom installed actions on the shared menu controller, as well as the list of allowed actions,
2149         if specified.
2150
2151         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2152         (WTR::UIScriptController::isDismissingMenu const):
2153
2154 2019-04-16  Megan Gardner  <megan_gardner@apple.com>
2155
2156         Allow sharing from imageSheet on an image document
2157         https://bugs.webkit.org/show_bug.cgi?id=196891
2158         <rdar://problem/25377386>
2159
2160         Reviewed by Tim Horton.
2161
2162         Test to make sure that the correct imageURL is extracted from an image element.
2163
2164         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
2165         (TestWebKitAPI::TEST):
2166
2167 2019-04-16  Alex Christensen  <achristensen@webkit.org>
2168
2169         REGRESSION(r244162) Clearing website data from ephemeral WKWebsiteDataStore should finish instead of asserting or hanging
2170         https://bugs.webkit.org/show_bug.cgi?id=196995
2171
2172         Reviewed by Brady Eidson.
2173
2174         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
2175         (TEST):
2176
2177 2019-04-16  Chris Dumez  <cdumez@apple.com>
2178
2179         URL set by document.open() is not communicated to the UIProcess
2180         https://bugs.webkit.org/show_bug.cgi?id=196941
2181         <rdar://problem/49237544>
2182
2183         Reviewed by Geoff Garen.
2184
2185         Add API test coverage.
2186
2187         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2188         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
2189         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
2190         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2191         (TEST):
2192
2193 2019-04-16  Commit Queue  <commit-queue@webkit.org>
2194
2195         Unreviewed, rolling out r244321.
2196         https://bugs.webkit.org/show_bug.cgi?id=196968
2197
2198         Causing all WK2 Debug builds to exit early after Assertion
2199         failures. (Requested by ShawnRoberts on #webkit).
2200
2201         Reverted changeset:
2202
2203         "URL set by document.open() is not communicated to the
2204         UIProcess"
2205         https://bugs.webkit.org/show_bug.cgi?id=196941
2206         https://trac.webkit.org/changeset/244321
2207
2208 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
2209
2210         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
2211         https://bugs.webkit.org/show_bug.cgi?id=196948
2212
2213         Reviewed by Zalan Bujtas.
2214
2215         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
2216         (TEST): Disabling the test for now to keep infrastructure happy, while the root-cause is being investigated.
2217
2218 2019-04-15  Chris Dumez  <cdumez@apple.com>
2219
2220         URL set by document.open() is not communicated to the UIProcess
2221         https://bugs.webkit.org/show_bug.cgi?id=196941
2222         <rdar://problem/49237544>
2223
2224         Reviewed by Geoffrey Garen.
2225
2226         Add API test coverage.
2227
2228         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2229         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
2230         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
2231         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2232         (TEST):
2233
2234 2019-04-15  Dean Johnson  <dean_johnson@apple.com>
2235
2236         Using Tools/Scripts/clean-webkit should not install requests
2237         https://bugs.webkit.org/show_bug.cgi?id=196940
2238
2239         Reviewed by Lucas Forschler.
2240
2241         * Scripts/webkitpy/common/system/autoinstall.py: Drive-by fix for no logging handlers
2242         existing, depending on the path autoinstalled is run through.
2243         * Scripts/webkitpy/port/base.py: Import webkitpy.results.upload.Upload only where it's
2244         needed.
2245         (Port.configuration_for_upload):
2246         (Port.commits_for_upload):
2247
2248 2019-04-15  Alex Christensen  <achristensen@webkit.org>
2249
2250         Add a DiagnosticLogging method taking an arbitrary dictionary of values.
2251         https://bugs.webkit.org/show_bug.cgi?id=196773
2252
2253         Reviewed by Jer Noble.
2254
2255         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewDiagnosticLogging.mm:
2256         (-[TestLoggingDelegate _webView:logDiagnosticMessage:description:valueDictionary:]):
2257         (TEST):
2258
2259 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
2260
2261         ews-build should clearly indicate flaky test failures
2262         https://bugs.webkit.org/show_bug.cgi?id=196947
2263
2264         Reviewed by Lucas Forschler.
2265
2266         * BuildSlaveSupport/ews-build/steps.py:
2267         (AnalyzeAPITestsResults.analyzeResults):
2268
2269 2019-04-15  Brent Fulgham  <bfulgham@apple.com>
2270
2271         InjectedBundle parameters often need initialization function called before unarchiving
2272         https://bugs.webkit.org/show_bug.cgi?id=189709
2273         <rdar://problem/44573653>
2274
2275         Reviewed by Ryosuke Niwa.
2276
2277         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
2278         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
2279
2280 2019-04-12  Ryosuke Niwa  <rniwa@webkit.org>
2281
2282         HashTable::removeIf always shrinks the hash table by half even if there is nothing left
2283         https://bugs.webkit.org/show_bug.cgi?id=196681
2284
2285         Reviewed by Darin Adler.
2286
2287         Added tests.
2288
2289         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
2290         (WTF_HashSet.RemoveIf):
2291         (WTF_HashSet.RemoveIfShrinkToBestSize):
2292
2293 2019-04-15  John Wilander  <wilander@apple.com>
2294
2295         Send delayed Ad Click Attribution conversion requests to the click source
2296         https://bugs.webkit.org/show_bug.cgi?id=196838
2297         <rdar://problem/47650157>
2298
2299         Reviewed by Chris Dumez and Youenn Fablet.
2300
2301         This patch adds test infrastructure to override the default behavior in
2302         WebKit::NetworkAdClickAttribution.
2303
2304         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
2305         (TestWebKitAPI::TEST):
2306         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2307         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2308         (WTR::TestRunner::dumpAdClickAttribution):
2309         (WTR::TestRunner::clearAdClickAttribution):
2310         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
2311         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
2312         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2313         * WebKitTestRunner/TestController.cpp:
2314         (WTR::TestController::setAdClickAttributionOverrideTimerForTesting):
2315         (WTR::TestController::setAdClickAttributionConversionURLForTesting):
2316         * WebKitTestRunner/TestController.h:
2317         * WebKitTestRunner/TestInvocation.cpp:
2318         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2319
2320 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
2321
2322         [ews-app] status-bubble should display position in queue
2323         https://bugs.webkit.org/show_bug.cgi?id=196607
2324
2325         Reviewed by Lucas Forschler.
2326
2327         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2328         (StatusBubble._build_bubble):
2329         (StatusBubble._queue_position): Method to calculate patch's position in queue.
2330
2331 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
2332
2333         [ews-build] Do not run clean build by default on EWS builders
2334         https://bugs.webkit.org/show_bug.cgi?id=196897
2335
2336         Reviewed by Lucas Forschler.
2337
2338         * BuildSlaveSupport/ews-build/steps.py:
2339         (ApplyPatch.start): Do not create .buildbot-patched file. This is a special file for Buildbot and if this
2340         file is present, during the Source checkout, Buildbot cleans the working directory completely (including removing 
2341         untracked directories like WebKitBuild).
2342         (CheckOutSource.__init__): Pass method=clean so that Buildbot clean the working directory. This does not remove
2343         untracked files/directories (like WebKitBuild).
2344
2345 2019-04-15  Per Arne Vollan  <pvollan@apple.com>
2346
2347         TestRunner::notifyDone() should be safely reentrant
2348         https://bugs.webkit.org/show_bug.cgi?id=196898
2349
2350         Reviewed by Darin Adler.
2351
2352         It is currently possible that TestRunner::notifyDone() will call itself, since
2353         notifyDone() will force a repaint, which can start executing JavaScript, which
2354         may call notifyDone() again. This can lead to test failures and flakiness.
2355         Fix this by setting the m_waitToDump flag before calling the dump() method.
2356
2357         * DumpRenderTree/mac/TestRunnerMac.mm:
2358         (TestRunner::notifyDone):
2359         (TestRunner::forceImmediateCompletion):
2360         * DumpRenderTree/win/TestRunnerWin.cpp:
2361         (TestRunner::notifyDone):
2362         (TestRunner::forceImmediateCompletion):
2363
2364 2019-04-15  Philippe Normand  <pnormand@igalia.com>
2365
2366         [GTK][WPE] Add enable-media websetting
2367         https://bugs.webkit.org/show_bug.cgi?id=196863
2368
2369         Reviewed by Michael Catanzaro.
2370
2371         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2372         (testWebKitSettings): Add test for the enable-media web-setting.
2373
2374 2019-04-14  Wenson Hsieh  <wenson_hsieh@apple.com>
2375
2376         API test WKAttachmentTests.AddAttachmentToConnectedImageElement is a flaky failure on Mac Release builds
2377         https://bugs.webkit.org/show_bug.cgi?id=196905
2378         <rdar://problem/49886096>
2379
2380         Reviewed by Tim Horton.
2381
2382         This flaky test exercises a race condition between when attachment insertion updates are dispatched from the web
2383         process to the UI process, and when script is executed via -[WKWebView evaluateJavaScript:completionHandler:].
2384         Since attachment insertion and removal updates from the web process to the UI process are scheduled on a zero-
2385         delay timer, we end up with this sequence of events in the problematic (failure) case:
2386
2387         (a) [UI]    Run script #1 (which calls `HTMLAttachmentElement.getAttachmentIdentifier`)
2388             ...IPC from UI to web process...
2389         (b) [Web]   Evaluate script #1 in the web process, which schedules attachment updates on a zero-delay timer
2390             ...IPC from web to UI process...
2391         (c) [UI]    Invoke completion handler for script #1
2392         (d) [UI]    Run script #2 (which calls `document.querySelector('img').attachmentIdentifier`)
2393             ...IPC from UI to web process...
2394         (e) [Web]   Evaluate script #2 in the web process
2395         (f) [Web]   Zero-delay timer fires and dispatches attachment updates to the UI process
2396
2397         ...which means that script #2 will complete before the UI process has received the attachment updates sent in
2398         step (f). However, in the case where the flaky test succeeds, the zero-delay timer in (f) fires *before* script
2399         #2 is run in step (e).
2400
2401         This patch fixes the flaky test by waiting until attachment insertion updates are guaranteed to be received in
2402         the UI process by waiting on a script message posted by the web process, after attachment updates are
2403         dispatched.
2404
2405         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2406         (TestWebKitAPI::TEST):
2407
2408 2019-04-14  Aakash Jain  <aakash_jain@apple.com>
2409
2410         Disable Flaky API Test WKAttachmentTests.AddAttachmentToConnectedImageElement
2411         https://bugs.webkit.org/show_bug.cgi?id=196909
2412
2413         Reviewed by Wenson Hsieh.
2414
2415         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2416         (TestWebKitAPI::TEST):
2417
2418 2019-04-13  Tadeu Zagallo  <tzagallo@apple.com>
2419
2420         CodeCache should check that the UnlinkedCodeBlock was successfully created before caching it
2421         https://bugs.webkit.org/show_bug.cgi?id=196880
2422
2423         Reviewed by Yusuke Suzuki.
2424
2425         Add a new function for bytecode cache tests that does not forceDiskCache
2426         for the second run: runBytecodeCacheNoAssetion. This is necessary for the
2427         test added in this patch, since the code is invalid and therefore won't be
2428         cached. It should also be useful for tests that evaluate dynamically
2429         generated code.
2430
2431         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
2432         * Scripts/run-jsc-stress-tests:
2433
2434 2019-04-12  Eric Carlson  <eric.carlson@apple.com>
2435
2436         Update AudioSession route sharing policy
2437         https://bugs.webkit.org/show_bug.cgi?id=196776
2438         <rdar://problem/46501611>
2439
2440         Reviewed by Jer Noble.
2441
2442         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
2443         (TestWebKitAPI::routeSharingPolicyLongFormVideo):
2444         (TestWebKitAPI::routeSharingPolicyLongFormAudio):
2445         (TestWebKitAPI::TEST):
2446
2447 2019-04-12  Wenson Hsieh  <wenson_hsieh@apple.com>
2448
2449         [iOS] Software keyboard is shown too frequently on some websites
2450         https://bugs.webkit.org/show_bug.cgi?id=195856
2451         <rdar://problem/49191395>
2452
2453         Reviewed by Darin Adler.
2454
2455         Add support for attaching or detaching the hardware keyboard on iOS in layout tests.
2456
2457         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2458         (WTR::UIScriptController::setHardwareKeyboardAttached):
2459         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2460         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2461         (WTR::UIScriptController::setHardwareKeyboardAttached):
2462         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2463         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
2464
2465         Additionally link against GraphicsServices in WebKitTestRunner.
2466
2467         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2468         (WTR::TestController::platformResetStateToConsistentValues):
2469         (WTR::UIScriptController::setHardwareKeyboardAttached):
2470
2471 2019-04-12  Ludovico de Nittis  <ludovico.denittis@collabora.com>
2472
2473         [GTK][WPE] Fix pacman install-dependencies packages
2474         https://bugs.webkit.org/show_bug.cgi?id=196817
2475
2476         Reviewed by Žan Doberšek.
2477         
2478         python3-setuptools is called python-setuptools
2479         ruby-highline is only available on AUR
2480         libv4l-devel is incorporated in v4l-utils
2481
2482         * gtk/install-dependencies:
2483         * wpe/install-dependencies:
2484
2485 2019-04-11  Carlos Garcia Campos  <cgarcia@igalia.com>
2486
2487         [GTK] REGRESSION(r243860): Many tests failing
2488         https://bugs.webkit.org/show_bug.cgi?id=196791
2489
2490         Reviewed by Joanmarie Diggs.
2491
2492         Rework the accessibility unit test to use DBus for the communication with the server. This way we can load
2493         multiple documents and check that accessibility hierarchy is updated after a navigation.
2494
2495         * TestWebKitAPI/Tests/WebKitGtk/AccessibilityTestServer.cpp:
2496         (loadChangedCallback):
2497         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
2498         (AccessibilityTest::AccessibilityTest):
2499         (AccessibilityTest::~AccessibilityTest):
2500         (AccessibilityTest::loadHTMLAndWaitUntilFinished):
2501         (AccessibilityTest::findTestServerApplication):
2502         (AccessibilityTest::findDocumentWeb):
2503         (AccessibilityTest::findRootObject):
2504         (AccessibilityTest::waitUntilChildrenRemoved):
2505         (AccessibilityTest::ensureProxy):
2506         (testAtspiBasicHierarchy):
2507         (beforeAll):
2508         (afterAll):
2509
2510 2019-04-11  Aakash Jain  <aakash_jain@apple.com>
2511
2512         [ews-build] Handle bug titles with unicode characters
2513         https://bugs.webkit.org/show_bug.cgi?id=196802
2514
2515         Reviewed by Dewei Zhu.
2516
2517         * BuildSlaveSupport/ews-build/steps.py:
2518         (ValidatePatch._is_bug_closed):
2519
2520 2019-04-11  Michael Saboff  <msaboff@apple.com>
2521
2522         Improve the Inline Cache Stats code
2523         https://bugs.webkit.org/show_bug.cgi?id=196836
2524
2525         Reviewed by Saam Barati.
2526
2527         Added a new script to consolidate and arrange the output of --useICStats option.
2528
2529         This script merges the output from every group into one large table and sorts it from most common to
2530         least common.  It also counts the slow path GetById and PutById variants and then calculates the
2531         percentage of gets or puts for each unique base,property pair compared to all the gets and puts.
2532         Put together, this is useful to see what property accesses are not getting cached.
2533
2534         * Scripts/ic-stats.py: Added.
2535         (ICStats):
2536         (ICStats.__init__):
2537         (ICStats.parse):
2538         (ICStats.dumpStats):
2539         (usage):
2540
2541 2019-04-10  Alex Christensen  <achristensen@webkit.org>
2542
2543         WKNavigationResponse._downloadAttribute should be nil when no download attribute is present
2544         https://bugs.webkit.org/show_bug.cgi?id=196809
2545         <rdar://49800762>
2546
2547         Reviewed by Brady Eidson.
2548
2549         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
2550         (TEST):
2551
2552 2019-04-10  Said Abou-Hallawa  <sabouhallawa@apple.com>
2553
2554         requestAnimationFrame should execute before the next frame
2555         https://bugs.webkit.org/show_bug.cgi?id=177484
2556
2557         Reviewed by Simon Fraser.
2558
2559         Add trace points for the page RenderingUpdate.
2560
2561         * Tracing/SystemTracePoints.plist:
2562
2563 2019-04-10  Fujii Hironori  <Hironori.Fujii@sony.com>
2564
2565         [Win] Use a bundled vswhere.exe instead of downloading by update-vswhere.py
2566         https://bugs.webkit.org/show_bug.cgi?id=196760
2567
2568         Reviewed by Don Olmstead.
2569
2570         vswhere.exe has been bundled since Visual Studio 2017 version
2571         15.2. We shouldn't download vswhere.exe.
2572
2573         * Scripts/build-jsc: Do not call update-vswhere.py.
2574         * Scripts/build-webkit: Ditto.
2575         * Scripts/update-vswhere.py: Removed.
2576         * Scripts/webkitdirs.pm:
2577         (requireModulesForVSWhere): Deleted.
2578         (pickCurrentVisualStudioInstallation): Deleted.
2579         (visualStudioInstallDirVSWhere): Return the latest installed VS
2580         installation path by using the bundled vswhere.exe.
2581         (setupCygwinEnv): Removed a unused variable $visualStudioPath.
2582         (visualStudioInstallDirFallback): Removed.
2583
2584 2019-04-10  Aakash Jain  <aakash_jain@apple.com>
2585
2586         [ews-build] PrintConfiguration should display Xcode version instead of SDKVersion
2587         https://bugs.webkit.org/show_bug.cgi?id=196780
2588
2589         Reviewed by Alexey Proskuryakov.
2590
2591         * BuildSlaveSupport/ews-build/steps.py:
2592         * BuildSlaveSupport/ews-build/steps_unittest.py:
2593
2594 2019-04-10  Alex Christensen  <achristensen@webkit.org>
2595
2596         Add SPI WKNavigationResponse._downloadAttribute
2597         https://bugs.webkit.org/show_bug.cgi?id=196755
2598         <rdar://49587365>
2599
2600         Reviewed by Brady Eidson.
2601
2602         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
2603         (-[NavigationResponseTestDelegate navigationResponse]):
2604         (-[NavigationResponseTestDelegate waitForNavigationResponseCallback]):
2605         (-[NavigationResponseTestDelegate waitForNavigationFinishedCallback]):
2606         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2607         (-[NavigationResponseTestDelegate webView:didFinishNavigation:]):
2608         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2609         (readRequest):
2610         (writeResponse):
2611         (TEST):
2612
2613 2019-04-10  Tim Horton  <timothy_horton@apple.com>
2614
2615         Add modern API for overriding the page's specified viewport configuration
2616         https://bugs.webkit.org/show_bug.cgi?id=167734
2617         <rdar://problem/30331795>
2618
2619         Reviewed by Simon Fraser.
2620
2621         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2622         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm: Added.
2623
2624 2019-04-10  Tadeu Zagallo  <tzagallo@apple.com>
2625
2626         Add support for incremental bytecode cache updates
2627         https://bugs.webkit.org/show_bug.cgi?id=195000
2628
2629         Reviewed by Filip Pizlo.
2630
2631         Exit when the initial run to generate bytecode fails.
2632
2633         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
2634
2635 2019-04-10  Alex Christensen  <achristensen@webkit.org>
2636
2637         RemoteObjectRegistry message receiver should be removed when WebPage::close is called instead of waiting until dealloc
2638         https://bugs.webkit.org/show_bug.cgi?id=196744
2639         <rdar://49415309>
2640
2641         Reviewed by Chris Dumez.
2642
2643         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
2644         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2645
2646 2019-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
2647
2648         Add a way to opt into modern compatibility mode in layout tests
2649         https://bugs.webkit.org/show_bug.cgi?id=196770
2650         <rdar://problem/49777550>
2651
2652         Reviewed by Antoine Quint.
2653
2654         Add a new test option to enable modern compatibility mode in layout tests.
2655
2656         * WebKitTestRunner/TestController.cpp:
2657         (WTR::updateTestOptionsFromTestHeader):
2658         * WebKitTestRunner/TestController.h:
2659         * WebKitTestRunner/TestOptions.h:
2660         (WTR::TestOptions::hasSameInitializationOptions const):
2661         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2662         (WTR::TestController::platformCreateWebView):
2663         (WTR::TestController::enableModernCompatibilityMode):
2664
2665 2019-04-10  Andy Estes  <aestes@apple.com>
2666
2667         Try to fix the 32-bit watchOS build.
2668
2669         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2670         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
2671
2672 2019-04-10  Antoine Quint  <graouts@apple.com>
2673
2674         Enable Pointer Events on watchOS
2675         https://bugs.webkit.org/show_bug.cgi?id=196771
2676         <rdar://problem/49040909>
2677
2678         Reviewed by Dean Jackson.
2679
2680         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2681
2682 2019-04-10  Philippe Normand  <pnormand@igalia.com>
2683
2684         Unreviewed. Fix WPE accessibility tests after r244059.
2685
2686         We are failing to load the injected bundle due to undefined symbol
2687         AccessibilityUIElement::replaceTextInRange().
2688
2689         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
2690         (WTR::AccessibilityUIElement::replaceTextInRange):
2691
2692 2019-04-10  Takashi Komori  <Takashi.Komori@sony.com>
2693
2694         [WinCairo][MiniBrowser] Pull down menu "Disable JavaScript" doesn't work.
2695         https://bugs.webkit.org/show_bug.cgi?id=196727
2696
2697         Reviewed by Fujii Hironori.
2698
2699         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2700         (WebKitBrowserWindow::create):
2701
2702 2019-04-09  Aakash Jain  <aakash_jain@apple.com>
2703
2704         [ews-build] Add unit tests for PrintConfiguration
2705         https://bugs.webkit.org/show_bug.cgi?id=196752
2706
2707         Reviewed by Dewei Zhu.
2708
2709         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
2710
2711 2019-04-09  Keith Rollin  <krollin@apple.com>
2712
2713         Unreviewed build maintenance -- update .xcfilelists.
2714
2715         * DumpRenderTree/DerivedSources-input.xcfilelist:
2716         * DumpRenderTree/DerivedSources-output.xcfilelist:
2717
2718 2019-04-09  Zalan Bujtas  <zalan@apple.com>
2719
2720         [AutoSizing] Avoid making text paragraphs scroll horizontally when there is a wide table
2721         https://bugs.webkit.org/show_bug.cgi?id=196743
2722         <rdar://problem/43897551>
2723
2724         Reviewed by Tim Horton.
2725
2726         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm: expected behavior change.
2727         (TEST):
2728
2729 2019-04-09  Youenn Fablet  <youenn@apple.com>
2730
2731         Close service worker database on network process suspension
2732         https://bugs.webkit.org/show_bug.cgi?id=196623
2733         <rdar://problem/48930869>
2734
2735         Reviewed by Alex Christensen.
2736
2737         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2738
2739 2019-04-09  Daniel Bates  <dabates@apple.com>
2740
2741         [iPad] Should open popover when the spacebar is pressed
2742         https://bugs.webkit.org/show_bug.cgi?id=196360
2743         <rdar://problem/49389129>
2744
2745         Reviewed by Brent Fulgham.
2746
2747         Add testing infrastructure to support waiting for a popover to be presented or dismissed.
2748
2749         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2750         (WTR::UIScriptController::isShowingPopover const): Added.
2751         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
2752         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
2753         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2754         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
2755         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2756         (WTR::UIScriptController::setWillPresentPopoverCallback): Added.
2757         (WTR::UIScriptController::willPresentPopoverCallback const): Added.
2758         (WTR::UIScriptController::setDidDismissPopoverCallback): Added.
2759         (WTR::UIScriptController::didDismissPopoverCallback const): Added.
2760         (WTR::UIScriptController::isShowingPopover const): Added.
2761         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
2762         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
2763         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2764         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2765         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2766         (-[TestRunnerWKWebView initWithFrame:configuration:]): Update some state.
2767         (-[TestRunnerWKWebView resetInteractionCallbacks]): Ditto.
2768         (-[TestRunnerWKWebView _willPresentPopover]): Added.
2769         (-[TestRunnerWKWebView _didDismissPopover]): Added.
2770         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2771         (WTR::UIScriptController::isShowingPopover const): Added.
2772         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
2773         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
2774
2775 2019-04-09  Alex Christensen  <achristensen@webkit.org>
2776
2777         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
2778         https://bugs.webkit.org/show_bug.cgi?id=196665
2779         <rdar://45115669>
2780
2781         Reviewed by Geoff Garen.
2782
2783         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2784         (goBack):
2785         (+[SimpleLookupContext sharedLookupContext]):
2786         (-[SimpleLookupContext lookUpURL:completionHandler:]):
2787         (TEST):
2788         (+[Simple3LookupContext sharedLookupContext]): Deleted.
2789         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
2790
2791 2019-04-09  John Wilander  <wilander@apple.com>
2792
2793         Pick up Ad Click Attribution conversions in NetworkResourceLoader::willSendRedirectedRequest()
2794         https://bugs.webkit.org/show_bug.cgi?id=196558
2795         <rdar://problem/47650245>
2796
2797         Reviewed by Youenn Fablet.
2798
2799         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
2800         (TestWebKitAPI::TEST):
2801             Added tests of WebCore::AdClickAttribution::parseConversionRequest().
2802
2803 2019-04-09  Don Olmstead  <don.olmstead@sony.com>
2804
2805         [CMake] Apple builds should use ICU_INCLUDE_DIRS
2806         https://bugs.webkit.org/show_bug.cgi?id=196720
2807
2808         Reviewed by Konstantin Tokarev.
2809
2810         * TestWebKitAPI/PlatformMac.cmake:
2811
2812 2019-04-09  Jonathan Bedard  <jbedard@apple.com>
2813
2814         iOS 12 Simulator Release WK2 frequently timing out while running layout tests
2815         https://bugs.webkit.org/show_bug.cgi?id=196694
2816         <rdar://problem/48388734>
2817
2818         Rubber-stamped by Aakash Jain.
2819
2820         * Scripts/webkitpy/port/image_diff.py:
2821         (ImageDiffer.diff_image): If the ImageDiff process has data, kill it before running again.
2822         * Scripts/webkitpy/port/server_process.py:
2823         (ServerProcess.has_available_stdout): Check if stdout has data in it.
2824         (ServerProcess._wait_for_data_and_update_buffers_using_select):
2825         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
2826         * Scripts/webkitpy/port/server_process_mock.py:
2827         (MockServerProcess.has_available_stdout):
2828         * Scripts/webkitpy/port/server_process_unittest.py:
2829         (TestServerProcess.serial_test_basic):
2830
2831 2019-04-09  Jer Noble  <jer.noble@apple.com>
2832
2833         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
2834         https://bugs.webkit.org/show_bug.cgi?id=196097
2835
2836         Reviewed by Eric Carlson.
2837
2838         Drive-by bug fix: allow tests to play audio without a user gesture by default.
2839
2840         * DumpRenderTree/mac/DumpRenderTree.mm:
2841         (resetWebPreferencesToConsistentValues):
2842         * WebKitTestRunner/TestController.cpp:
2843         (WTR::TestController::resetPreferencesToConsistentValues):
2844
2845 2019-04-09  Pablo Saavedra  <psaavedra@igalia.com>
2846
2847         [JSCOnly] Add an i386 JSCOnly EWS that runs tests
2848         https://bugs.webkit.org/show_bug.cgi?id=196690
2849
2850         Reviewed by Michael Catanzaro.
2851
2852         * QueueStatusServer/config/queues.py:
2853         * Scripts/webkitpy/common/config/ews.json:
2854         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2855         (test_ews_name):
2856
2857 2019-04-09  Chris Dumez  <cdumez@apple.com>
2858
2859         Loads using loadHTMLString() cause flashing when process-swapping
2860         https://bugs.webkit.org/show_bug.cgi?id=196714
2861         <rdar://problem/49637354>
2862
2863         Reviewed by Antti Koivisto.
2864
2865         Add API test coverage.
2866
2867         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2868
2869 2019-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
2870
2871         Unreviewed. Fix ATK accessibility tests after r244059.
2872
2873         We are failing to load the injected bundle due to undefined symbol
2874         AccessibilityUIElement::replaceTextInRange().
2875
2876         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2877         (WTR::AccessibilityUIElement::replaceTextInRange):
2878
2879 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
2880
2881         AX: Support API: accessibilityReplaceRange:withText
2882         https://bugs.webkit.org/show_bug.cgi?id=196636
2883
2884         Unreviewed build fix for Windows port.
2885
2886         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
2887         (WTR::AccessibilityUIElement::replaceTextInRange): Added.
2888
2889 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
2890
2891         [CMake][WinCairo] Separate copied headers into different directories
2892         https://bugs.webkit.org/show_bug.cgi?id=196655
2893
2894         Reviewed by Michael Catanzaro.
2895
2896         * DumpRenderTree/CMakeLists.txt:
2897         * MiniBrowser/win/CMakeLists.txt:
2898         * TestWebKitAPI/CMakeLists.txt:
2899         * TestWebKitAPI/PlatformWin.cmake:
2900
2901 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
2902
2903         Log stack-trace for run-webkit-tests when interrupted
2904         https://bugs.webkit.org/show_bug.cgi?id=176393
2905         <rdar://problem/34262310>
2906
2907         Reviewed by Lucas Forschler.
2908
2909         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
2910         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
2911         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
2912         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
2913         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
2914         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2915         (main): Set handlers to log stack trace on interruption.
2916
2917 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
2918
2919         AX: Support API: accessibilityReplaceRange:withText
2920         https://bugs.webkit.org/show_bug.cgi?id=196636
2921
2922         Unreviewed build fix for Windows port.
2923
2924         * DumpRenderTree/AccessibilityUIElement.cpp:
2925         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
2926
2927 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
2928
2929         [ews-build] Scripts using Buildbot API have CORS error
2930         https://bugs.webkit.org/show_bug.cgi?id=196709
2931
2932         Reviewed by Alexey Proskuryakov.
2933
2934         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
2935
2936 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
2937
2938         AX: Support API: accessibilityReplaceRange:withText
2939         https://bugs.webkit.org/show_bug.cgi?id=196636
2940
2941         Reviewed by Daniel Bates.
2942
2943         * DumpRenderTree/AccessibilityUIElement.cpp:
2944         (replaceTextInRangeCallback):
2945         (AccessibilityUIElement::replaceTextInRange):
2946         (AccessibilityUIElement::getJSClass):
2947         * DumpRenderTree/AccessibilityUIElement.h:
2948         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2949         (AccessibilityUIElement::replaceTextInRange):
2950         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2951         (AccessibilityUIElement::replaceTextInRange):
2952         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2953         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2954         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2955         (WTR::AccessibilityUIElement::replaceTextInRange):
2956         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2957         (WTR::AccessibilityUIElement::replaceTextInRange):
2958
2959 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
2960
2961         [iOS] Do not allow starting selection drags when selection views are not visible
2962         https://bugs.webkit.org/show_bug.cgi?id=196686
2963         <rdar://problem/49399192>
2964
2965         Reviewed by Tim Horton.
2966
2967         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
2968         also add some new API tests to cover scenarios where the web view is not first responder.
2969
2970         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
2971         (TestWebKitAPI::TEST):
2972         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
2973
2974         Add a switch to optionally make the web view first responder when starting the simulated drag.
2975
2976         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2977         (-[DragAndDropSimulator initWithWebView:]):
2978         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
2979
2980 2019-04-08  Justin Fan  <justin_fan@apple.com>
2981
2982         [Web GPU] Fix Web GPU experimental feature on iOS
2983         https://bugs.webkit.org/show_bug.cgi?id=196632
2984
2985         Reviewed by Myles C. Maxfield.
2986
2987         Properly make Web GPU available on iOS 11+.
2988
2989         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2990
2991 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
2992
2993         [ews-build] Do not upload archive when Compile Fails
2994         https://bugs.webkit.org/show_bug.cgi?id=196674
2995
2996         Reviewed by Alexey Proskuryakov.
2997
2998         * BuildSlaveSupport/ews-build/factories.py:
2999         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
3000         * BuildSlaveSupport/ews-build/steps.py:
3001         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
3002         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
3003         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
3004
3005 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
3006
3007         Enable DFG on MIPS
3008         https://bugs.webkit.org/show_bug.cgi?id=196689
3009
3010         Reviewed by Žan Doberšek.
3011
3012         Since the bytecode change, we enabled the baseline JIT on mips in
3013         r240432, but DFG is still missing. With this change, all tests are
3014         passing on a ci20 board.
3015
3016         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
3017
3018 2019-04-08  Philippe Normand  <pnormand@igalia.com>
3019
3020         [Flatpak] Second run update-webkitwpe-flatpak fails
3021         https://bugs.webkit.org/show_bug.cgi?id=192702
3022
3023         Reviewed by Carlos Garcia Campos.
3024
3025         * flatpak/flatpakutils.py:
3026         (FlatpakObject.flatpak): Fix typo.
3027         (FlatpakPackage.install): When installing, also update to the configured remote commit.
3028         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
3029
3030 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
3031
3032         [GTK][WPE] outlook.live.com displays old-fashioned UI
3033         https://bugs.webkit.org/show_bug.cgi?id=196642
3034
3035         Reviewed by Carlos Garcia Campos.
3036
3037         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3038         (TestWebKitAPI::TEST): New Mac platform quirk test.
3039
3040 2019-04-07  Commit Queue  <commit-queue@webkit.org>
3041
3042         Unreviewed, rolling out r243956.
3043         https://bugs.webkit.org/show_bug.cgi?id=196688
3044
3045         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
3046         by aakashjain on #webkit).
3047
3048         Reverted changeset:
3049
3050         "Clicking "Go Back" from a safe browsing warning from an
3051         iframe should navigate the WKWebView back to the previous
3052         page"
3053         https://bugs.webkit.org/show_bug.cgi?id=196665
3054         https://trac.webkit.org/changeset/243956
3055
3056 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
3057
3058         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
3059         https://bugs.webkit.org/show_bug.cgi?id=196669
3060
3061         Reviewed by Geoffrey Garen.
3062
3063         Added three new unit tests for WeakHashSet.
3064
3065         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3066         (WTF_WeakPtr.WeakHashSetConstObjects):
3067         (WTF_WeakPtr.WeakHashSetComputesEmpty):
3068         (WTF_WeakPtr.WeakHashSetComputeSize):
3069
3070 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
3071
3072         Hide next and previous form control buttons when WKWebView is editable
3073         https://bugs.webkit.org/show_bug.cgi?id=196672
3074         <rdar://problem/35625321>
3075
3076         Reviewed by Tim Horton.
3077
3078         Add a new API test.
3079
3080         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
3081         (-[TestWKWebView lastTrailingBarButtonGroup]):
3082         (TestWebKitAPI::TEST):
3083         * TestWebKitAPI/ios/UIKitSPI.h:
3084
3085 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
3086
3087         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
3088         https://bugs.webkit.org/show_bug.cgi?id=196077
3089         <rdar://problem/49108202>
3090
3091         Reviewed by Chris Dumez.
3092
3093         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
3094         on new web view.
3095
3096         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3097
3098 2019-04-05  Saam Barati  <sbarati@apple.com>
3099
3100         Make compare-results understand MotionMark
3101         https://bugs.webkit.org/show_bug.cgi?id=196666
3102
3103         Reviewed by Yusuke Suzuki.
3104
3105         * Scripts/compare-results:
3106         (PLT5Results):
3107         (detectMotionMark):
3108         (detectMotionMark1_1):
3109         (motionMarkResults):
3110         (motionMark1_1Results):
3111         (detectBenchmark):
3112         (biggerIsBetter):
3113         (main):
3114
3115 2019-04-05  Alex Christensen  <achristensen@webkit.org>
3116
3117         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
3118         https://bugs.webkit.org/show_bug.cgi?id=196665
3119         <rdar://45115669>
3120
3121         Reviewed by Geoff Garen.
3122
3123         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3124         (goBack):
3125         (+[SimpleLookupContext sharedLookupContext]):
3126         (-[SimpleLookupContext lookUpURL:completionHandler:]):
3127         (TEST):
3128         (+[Simple3LookupContext sharedLookupContext]): Deleted.
3129         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
3130
3131 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
3132
3133         [ews-build] Add configuration and architecture for windows builders
3134         https://bugs.webkit.org/show_bug.cgi?id=196660
3135
3136         Reviewed by Lucas Forschler.
3137
3138         * BuildSlaveSupport/ews-build/config.json:
3139
3140 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
3141
3142         webkitpy: Don't run subsequent rounds if interrupted
3143         https://bugs.webkit.org/show_bug.cgi?id=196646
3144
3145         Reviewed by Aakash Jain.
3146
3147         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3148         (Manager.run): Bail out if interrupted.
3149
3150 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
3151
3152         Test sessionStorage in PSON private browsing mode
3153         https://bugs.webkit.org/show_bug.cgi?id=196561
3154
3155         Reviewed by Alex Christensen.
3156
3157         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3158
3159 2019-04-05  Commit Queue  <commit-queue@webkit.org>
3160
3161         Unreviewed, rolling out r243833.
3162         https://bugs.webkit.org/show_bug.cgi?id=196645
3163
3164         This change breaks build of WPE and GTK ports (Requested by
3165         annulen on #webkit).
3166
3167         Reverted changeset:
3168
3169         "[CMake][WTF] Mirror XCode header directories"
3170         https://bugs.webkit.org/show_bug.cgi?id=191662
3171         https://trac.webkit.org/changeset/243833
3172
3173 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
3174
3175         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
3176         https://bugs.webkit.org/show_bug.cgi?id=196635
3177
3178         Reviewed by Antti Koivisto.
3179         
3180         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
3181         for a test to enable async frame scrolling via:
3182             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
3183         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
3184         
3185         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
3186
3187         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3188         (WTR::InjectedBundle::beginTesting):
3189         * WebKitTestRunner/TestController.cpp:
3190         (WTR::TestController::resetPreferencesToConsistentValues):
3191
3192 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
3193
3194         Use a correct LC_RPATH when building with ASan
3195         https://bugs.webkit.org/show_bug.cgi?id=196576
3196
3197         Reviewed by David Kilzer.
3198
3199         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
3200         so that ../Frameworks is checked. This is simpler and more reliable than updating
3201         each SPC service xcconfig.
3202
3203 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
3204
3205         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
3206         https://bugs.webkit.org/show_bug.cgi?id=196629
3207
3208         Reviewed by Lucas Forschler.
3209
3210         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
3211
3212 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
3213
3214         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
3215         https://bugs.webkit.org/show_bug.cgi?id=196618
3216
3217         Reviewed by Lucas Forschler.
3218
3219         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3220         (StatusBubble): Added QUEUE_TRIGGERS.
3221         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
3222         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
3223         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
3224         its parent(builder).
3225
3226 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
3227
3228         [ews-app] Status-bubble steps are sometimes displayed in reverse order
3229         https://bugs.webkit.org/show_bug.cgi?id=196625
3230
3231         Reviewed by Lucas Forschler.
3232
3233         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3234         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
3235
3236 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
3237
3238         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
3239         https://bugs.webkit.org/show_bug.cgi?id=196630
3240
3241         Reviewed by Wenson Hsieh.
3242
3243         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
3244
3245 2019-04-04  Youenn Fablet  <youenn@apple.com>
3246
3247         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
3248         https://bugs.webkit.org/show_bug.cgi?id=196543
3249
3250         Reviewed by Alex Christensen.
3251
3252         * WebKitTestRunner/TestController.cpp:
3253         (WTR::TestController::generatePageConfiguration):
3254
3255 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
3256
3257         [ews-app] Status bubble should not display skipped buildbot steps
3258         https://bugs.webkit.org/show_bug.cgi?id=196584
3259
3260         Reviewed by Lucas Forschler.
3261
3262         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3263
3264 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
3265
3266         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
3267         https://bugs.webkit.org/show_bug.cgi?id=196620
3268
3269         Reviewed by Lucas Forschler.
3270
3271         * BuildSlaveSupport/ews-app/ews/config.py:
3272
3273 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
3274
3275         [Win] DumpRenderTreeWatchDog.py is not checked into source
3276         https://bugs.webkit.org/show_bug.cgi?id=196567
3277         <rdar://problem/49525901>
3278
3279         Reviewed by Lucas Forschler.
3280
3281         This script is used on Win EWS bots to terminate hanging DRT processes.
3282
3283         * EWSTools/dumprendertreewatchdog.py: Added.
3284
3285 2019-04-04  Chris Dumez  <cdumez@apple.com>
3286
3287         Unreviewed, roll out r243858 which made tests time out.
3288
3289         Disable new API tests on Windows instead.
3290
3291         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
3292         (TestWebKitAPI::TEST):
3293
3294 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3295
3296         [ATK] Cleanup WebPageAccessibilityObjectAtk
3297         https://bugs.webkit.org/show_bug.cgi?id=196537
3298
3299         Reviewed by Michael Catanzaro.
3300
3301         Also consider files under atk directories as exceptions for GObject conventions.
3302
3303         * Scripts/webkitpy/style/checkers/cpp.py:
3304         (check_identifier_name_in_declaration):
3305
3306 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
3307
3308         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
3309         https://bugs.webkit.org/show_bug.cgi?id=196588
3310         <rdar://problem/49365787>
3311
3312         Unreviewed build fix for Windows port.
3313
3314         error C3861: 'kill': identifier not found
3315
3316         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
3317         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
3318
3319 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
3320
3321         [ews-build] Cancel build and similar operations should have authentication
3322         https://bugs.webkit.org/show_bug.cgi?id=196520
3323
3324         Reviewed by Dewei Zhu.
3325
3326         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
3327         environment variables.
3328
3329 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
3330
3331         [ews-build] Do not trigger queues which are not in production yet
3332         https://bugs.webkit.org/show_bug.cgi?id=196581
3333
3334         Reviewed by Dewei Zhu.
3335
3336         * BuildSlaveSupport/ews-build/config.json:
3337
3338 2019-04-03  Chris Dumez  <cdumez@apple.com>
3339
3340         Unreviewed, fix typo in the name of API test added in r243848.
3341
3342         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
3343         (TestWebKitAPI::TEST):
3344
3345 2019-04-03  Chris Dumez  <cdumez@apple.com>
3346
3347         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
3348         https://bugs.webkit.org/show_bug.cgi?id=196588
3349         <rdar://problem/49365787>
3350
3351         Reviewed by Ryosuke Niwa.
3352
3353         Add API test coverage.
3354
3355         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
3356         (TestWebKitAPI::nullJavaScriptCallback):
3357         (TestWebKitAPI::didCrashCheckFrames):
3358         (TestWebKitAPI::TEST):
3359
3360 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
3361
3362         run-webkit-tests: Upload test results (new results database)
3363         https://bugs.webkit.org/show_bug.cgi?id=196577
3364         <rdar://problem/34841155>
3365
3366         Reviewed by Lucas Forschler.
3367
3368         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3369         (Manager.run): Upload results after each device shard, since the configuration will be
3370         different for each device.
3371         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
3372         uploaded to a results database.
3373         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3374         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
3375
3376 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
3377
3378         -apple-trailing-word is needed for browser detection
3379         https://bugs.webkit.org/show_bug.cgi?id=196575
3380
3381         Unreviewed.
3382
3383         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3384
3385 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
3386
3387         [CMake][WTF] Mirror XCode header directories
3388         https://bugs.webkit.org/show_bug.cgi?id=191662
3389
3390         Reviewed by Konstantin Tokarev.
3391
3392         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
3393         builds.
3394
3395         * CMakeLists.txt:
3396         * DumpRenderTree/CMakeLists.txt:
3397         * DumpRenderTree/PlatformWin.cmake:
3398         * MiniBrowser/win/CMakeLists.txt:
3399         * TestWebKitAPI/CMakeLists.txt:
3400         * TestWebKitAPI/PlatformWin.cmake:
3401         * WebKitTestRunner/PlatformGTK.cmake:
3402         * WebKitTestRunner/PlatformWin.cmake:
3403
3404 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
3405
3406         [ews-app] Status bubble should not display certain infrastructure status messages
3407         https://bugs.webkit.org/show_bug.cgi?id=196550
3408
3409         Reviewed by Lucas Forschler.
3410
3411         Do not display the steps which are un-needed for end-user. This information is still avaiable
3412         if the user click on the bubble and look at the Buildbot build.
3413         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3414         (StatusBubble._steps_messages):
3415         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
3416
3417 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
3418
3419         [ews-build] Use https for sending data to ews-app
3420         https://bugs.webkit.org/show_bug.cgi?id=196492
3421
3422         Reviewed by Lucas Forschler.
3423
3424         * BuildSlaveSupport/ews-build/events.py:
3425
3426 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
3427
3428         Remove support for -apple-trailing-word
3429         https://bugs.webkit.org/show_bug.cgi?id=196525
3430
3431         Reviewed by Zalan Bujtas.
3432
3433         This CSS property is nonstandard and not used.
3434
3435         * Scripts/webkitperl/FeatureList.pm:
3436         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3437
3438 2019-04-03  Youenn Fablet  <youenn@apple.com>
3439
3440         Add a test for DOMCache on multiple browsing in case of private browsing
3441         https://bugs.webkit.org/show_bug.cgi?id=196524
3442
3443         Reviewed by Alex Christensen.
3444
3445         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3446         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
3447
3448 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
3449
3450         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
3451         https://bugs.webkit.org/show_bug.cgi?id=196540
3452
3453         Reviewed by Aakash Jain.
3454
3455         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
3456
3457 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
3458
3459         Add plumbing for a compatibility mode preference in WebKit
3460         https://bugs.webkit.org/show_bug.cgi?id=196005
3461
3462         Reviewed by Tim Horton.
3463
3464         Add new API tests.
3465
3466         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3467         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
3468
3469 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
3470
3471         [WPE][GTK] Update libsrtp dependency package for Debian
3472         https://bugs.webkit.org/show_bug.cgi?id=196528
3473
3474         Reviewed by Frédéric Wang.
3475
3476         * gtk/install-dependencies:
3477         * wpe/install-dependencies:
3478
3479 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
3480
3481         [WK2] Add support for Window's beforeprint / afterprint events
3482         https://bugs.webkit.org/show_bug.cgi?id=196478
3483         <rdar://problem/49535124>
3484
3485         Unreviewed build fix for MSVC.
3486
3487         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
3488
3489         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
3490
3491         * WebKitTestRunner/TestController.cpp:
3492         (WTR::printFrame): Use int and float literals.
3493
3494 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
3495
3496         [ews-build] Reassign bots to queues
3497
3498         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
3499
3500 2019-04-02  Chris Dumez  <cdumez@apple.com>
3501
3502         [WK2] Add support for Window's beforeprint / afterprint events
3503         https://bugs.webkit.org/show_bug.cgi?id=196478
3504
3505         Reviewed by Alex Christensen.
3506
3507         Add minimal implementation for printFrame in WebKitTestRunner.
3508
3509         * WebKitTestRunner/TestController.cpp:
3510         (WTR::printFrame):
3511         (WTR::TestController::createOtherPage):
3512         (WTR::TestController::createWebViewWithOptions):
3513
3514 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
3515
3516         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
3517         https://bugs.webkit.org/show_bug.cgi?id=196491
3518
3519         Reviewed by Lucas Forschler.
3520
3521         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3522
3523 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
3524
3525         [ews-build] Configure buildbot try credentials in environment variables
3526         https://bugs.webkit.org/show_bug.cgi?id=196501
3527
3528         Reviewed by Lucas Forschler.
3529
3530         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
3531         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
3532         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
3533
3534 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
3535
3536         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
3537         https://bugs.webkit.org/show_bug.cgi?id=196496
3538         <rdar://problem/49521634>
3539
3540         Reviewed by Chris Dumez.
3541
3542         Add new API tests (see WebKit ChangeLog for more detail).
3543
3544         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3545         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3546         (TEST):
3547
3548 2019-04-02  David Kilzer  <ddkilzer@apple.com>
3549
3550         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
3551         <https://webkit.org/b/196499>
3552
3553         Reviewed by Alexey Proskuryakov.
3554
3555         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
3556         ENABLE_ADDRESS_SANITIZER.
3557
3558 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
3559
3560         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
3561         https://bugs.webkit.org/show_bug.cgi?id=182757
3562
3563         Reviewed by Don Olmstead.
3564
3565         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
3566         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
3567
3568 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
3569
3570         run-api-tests: Upload test results
3571         https://bugs.webkit.org/show_bug.cgi?id=196323
3572         <rdar://problem/49356714>
3573
3574         Reviewed by Lucas Forschler.
3575
3576         * Scripts/webkitpy/api_tests/manager.py:
3577         (Manager):
3578         (Manager.run): Upload results to a results database.
3579         * Scripts/webkitpy/api_tests/run_api_tests.py:
3580         (parse_args): Add upload arguments.
3581         * Scripts/webkitpy/port/base.py:
3582         (Port):
3583         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
3584         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
3585         with commits from any other associated repositories.
3586         * Scripts/webkitpy/port/device.py:
3587         (Device):
3588         (Device.build_version): Access build_versoin of underlying platform device.
3589         * Scripts/webkitpy/port/ios_simulator_unittest.py:
3590         (IOSSimulatorTest):
3591         (IOSSimulatorTest.test_configuration_for_upload):
3592         * Scripts/webkitpy/port/device_port.py:
3593         (DevicePort):
3594         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
3595         the same as the machine uploading results.
3596         * Scripts/webkitpy/port/mac.py:
3597         (MacPort):
3598         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
3599         * Scripts/webkitpy/port/mac_unittest.py:
3600         (MacTest):
3601         (MacTest.test_configuration_for_upload):
3602         * Scripts/webkitpy/xcode/simulated_device.py:
3603         (SimulatedDeviceManager._create_device_with_runtime):
3604         (SimulatedDevice.__init__): Create simulated device with a build_version.
3605         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
3606         (test_existing_simulator):
3607
3608 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
3609
3610         Remove extra newline characters (Follow-up fix to r243707)
3611
3612         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3613
3614 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
3615
3616         [ews-app] Use API_KEY to accept results data
3617         https://bugs.webkit.org/show_bug.cgi?id=196461
3618
3619         Reviewed by Dewei Zhu.
3620
3621         * BuildSlaveSupport/ews-app/ews/views/results.py:
3622         (Results.post): Validate EWS_API_KEY before accepting any data.
3623         * BuildSlaveSupport/ews-build/events.py:
3624         (Events.sendData): Send EWS_API_KEY if available along with event data.
3625
3626 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
3627
3628         Unable to copy and paste a PDF from Notes into Mail compose body
3629         https://bugs.webkit.org/show_bug.cgi?id=196442
3630         <rdar://problem/48573098>
3631
3632         Reviewed by Tim Horton.
3633
3634         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
3635         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
3636         to be specified on the item providers.
3637
3638         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3639         (TestWebKitAPI::mapItemForTesting):
3640         (TestWebKitAPI::contactItemForTesting):
3641
3642 2019-04-01  Tim Horton  <timothy_horton@apple.com>
3643
3644         Make UIWKDocumentContext rects per-character instead of per-word
3645         https://bugs.webkit.org/show_bug.cgi?id=196459
3646
3647         Reviewed by Wenson Hsieh.
3648
3649         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
3650         (TEST):
3651         Adjust test results due to switching to per-character rects.
3652
3653 2019-04-01  Chris Dumez  <cdumez@apple.com>
3654
3655         UIProcess crash when a prewarmed process is terminated
3656         https://bugs.webkit.org/show_bug.cgi?id=196451
3657         <rdar://problem/49245471>
3658
3659         Reviewed by Geoffrey Garen.
3660
3661         Add API test coverage.
3662
3663         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
3664         (TEST):
3665
3666 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
3667
3668         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
3669         https://bugs.webkit.org/show_bug.cgi?id=196449
3670
3671         Reviewed by Lucas Forschler.
3672
3673         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3674         (StatusBubble.get_os_details): Method to get OS and Xcode details.
3675         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
3676         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
3677
3678 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
3679
3680         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
3681         https://bugs.webkit.org/show_bug.cgi?id=196444
3682
3683         Reviewed by Lucas Forschler.
3684
3685         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
3686
3687 2019-04-01  Alex Christensen  <achristensen@webkit.org>
3688
3689         Add SPI to canonicalize NSURLs with WTF::URL
3690         https://bugs.webkit.org/show_bug.cgi?id=196415
3691         <rdar://problem/44980271>
3692
3693         Reviewed by Darin Adler.
3694
3695         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3696         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
3697         (TestWebKitAPI::TEST):
3698
3699 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
3700
3701         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
3702         https://bugs.webkit.org/show_bug.cgi?id=196441
3703
3704         Reviewed by Carlos Garcia Campos.
3705
3706         Don't cache the wpe_view_backend object that might not exist yet at the
3707         time of EventSenderProxy constructor invocation, but instead retrieve
3708         that object whenever it's required for event dispatching. This should
3709         avoid crashes in this constructor now that it's invoked before any
3710         PlatformWindow has been set up (as changed in r243496).
3711
3712         * WebKitTestRunner/EventSenderProxy.h:
3713         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
3714         (WTR::viewBackend):
3715         (WTR::EventSenderProxy::EventSenderProxy):
3716         (WTR::EventSenderProxy::mouseDown):
3717         (WTR::EventSenderProxy::mouseUp):
3718         (WTR::EventSenderProxy::mouseMoveTo):
3719         (WTR::EventSenderProxy::mouseScrollBy):
3720         (WTR::EventSenderProxy::keyDown):
3721         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
3722
3723 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
3724
3725         [Win][WebKit] MiniBrowser should support high DPI display
3726         https://bugs.webkit.org/show_bug.cgi?id=196391
3727
3728         Reviewed by Alex Christensen.
3729
3730         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3731         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
3732         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
3733         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
3734
3735 2019-03-31  Sam Weinig  <weinig@apple.com>
3736
3737         Remove more i386 specific configurations
3738         https://bugs.webkit.org/show_bug.cgi?id=196430
3739
3740         Reviewed by Alexey Proskuryakov.
3741
3742         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3743         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
3744
3745 2019-03-31  Andy Estes  <aestes@apple.com>
3746
3747         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
3748         https://bugs.webkit.org/show_bug.cgi?id=196433
3749         <rdar://problem/49293305>
3750
3751         Reviewed by Tim Horton.
3752
3753         Enhanced API test coverage to include all navigation response policy decisions in both
3754         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
3755
3756         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3757         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
3758         (TestWebKitAPI::TEST):
3759         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
3760         (readFile):
3761         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
3762         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
3763         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3764         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
3765         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
3766         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
3767         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
3768         (-[QuickLookDelegate _downloadDidStart:]):
3769         (-[QuickLookDelegate _download:didReceiveResponse:]):
3770         (-[QuickLookDelegate _download:didReceiveData:]):
3771         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
3772         (-[QuickLookDelegate _downloadDidFinish:]):
3773         (-[QuickLookDelegate _download:didFailWithError:]):
3774         (-[QuickLookDelegate _downloadDidCancel:]):
3775         (-[QuickLookDelegate verifyDownload]):
3776         (runTest):
3777         (runTestDecideBeforeLoading):
3778         (runTestDecideAfterLoading):
3779         (TEST):
3780         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3781         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
3782         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
3783         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
3784         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
3785         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
3786         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
3787         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
3788         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
3789         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
3790         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
3791         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
3792         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
3793         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
3794
3795 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
3796
3797         [CMake] add testdfg as target with build-jsc
3798         https://bugs.webkit.org/show_bug.cgi?id=196393
3799
3800         Reviewed by Saam Barati.
3801
3802         Added testdfg as one of the targets to build when
3803         using CMake.
3804
3805         * Scripts/build-jsc:
3806
3807 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
3808
3809         Delete WebMetal implementation in favor of WebGPU
3810         https://bugs.webkit.org/show_bug.cgi?id=195418
3811
3812         Reviewed by Dean Jackson.
3813
3814         * DumpRenderTree/mac/DumpRenderTree.mm:
3815         (enableExperimentalFeatures):
3816         (resetWebPreferencesToConsistentValues):
3817         * Scripts/webkitperl/FeatureList.pm:
3818         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3819         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3820         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
3821         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
3822         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
3823         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
3824         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
3825         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
3826         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
3827         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3828         (WTR::InjectedBundle::beginTesting):
3829         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3830         (WTR::TestRunner::setWebMetalEnabled): Deleted.
3831         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3832
3833 2019-03-29  Chris Dumez  <cdumez@apple.com>
3834
3835         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
3836         https://bugs.webkit.org/show_bug.cgi?id=196405
3837         <rdar://problem/49428130>
3838
3839         Reviewed by Wenson Hsieh.
3840
3841         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
3842         the popover presentation methods to be no-ops. Use this in the new test added in
3843         r243523 so that we do not swizzle those methods for all tests. This is needed because
3844         those WatchOS tests rely on the popover getting presented and interactive.
3845
3846         * WebKitTestRunner/TestController.cpp:
3847         (WTR::updateTestOptionsFromTestHeader):
3848         * WebKitTestRunner/TestController.h:
3849         * WebKitTestRunner/TestOptions.h:
3850         (WTR::TestOptions::hasSameInitializationOptions const):
3851         * WebKitTestRunner/ios/TestControllerIOS.mm:
3852         (WTR::TestController::platformInitialize):
3853         (WTR::TestController::platformResetStateToConsistentValues):
3854
3855 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
3856
3857         [Curl] Add Server Trust Evaluation Support.
3858         https://bugs.webkit.org/show_bug.cgi?id=191646
3859
3860         Reviewed by Fujii Hironori.
3861
3862         Implemented MiniBrowser UI for asking if user trusts the server.
3863
3864         * MiniBrowser/win/Common.cpp:
3865         (askServerTrustEvaluation):
3866         (replaceString):
3867         * MiniBrowser/win/Common.h:
3868         * MiniBrowser/win/MiniBrowserLib.rc:
3869         * MiniBrowser/win/MiniBrowserLibResource.h:
3870         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3871         (createPEMString):
3872         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
3873         (WebKitBrowserWindow::canTrustServerCertificate):
3874         * MiniBrowser/win/WebKitBrowserWindow.h:
3875
3876 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
3877
3878         Implement ResizeObserver.
3879         https://bugs.webkit.org/show_bug.cgi?id=157743
3880
3881         Reviewed by Simon Fraser.
3882
3883         Support resizeObserverEnabled webPreferences.
3884
3885         * DumpRenderTree/TestOptions.cpp:
3886         (TestOptions::TestOptions):
3887         * DumpRenderTree/TestOptions.h:
3888         * DumpRenderTree/mac/DumpRenderTree.mm:
3889         (setWebPreferencesForTestOptions):
3890         * DumpRenderTree/win/DumpRenderTree.cpp:
3891         (enableExperimentalFeatures):
3892         * Scripts/webkitperl/FeatureList.pm:
3893         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3894
3895 2019-03-28  John Wilander  <wilander@apple.com>
3896
3897         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
3898         https://bugs.webkit.org/show_bug.cgi?id=196281
3899         <rdar://problem/48938748>
3900
3901         Reviewed by Alex Christensen.
3902
3903         This patch adds the function isStatisticsHasLocalStorage() to the
3904         TestRunner. With it, the page can query the WebsiteDataStore in the
3905         UI process to make sure that it sees LocalStorage.
3906
3907         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3908         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3909         (WTR::TestRunner::isStatisticsHasLocalStorage):
3910         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3911         * WebKitTestRunner/TestController.cpp:
3912         (WTR::TestController::isStatisticsHasLocalStorage):
3913         * WebKitTestRunner/TestController.h:
3914         * WebKitTestRunner/TestInvocation.cpp:
3915         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3916
3917 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
3918
3919         API::Data::createWithoutCopying should do a null check before calling CFRelease
3920         https://bugs.webkit.org/show_bug.cgi?id=196276
3921         <rdar://problem/48059859>
3922
3923         Reviewed by Alex Christensen.
3924
3925         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
3926
3927         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3928         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
3929         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
3930         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
3931         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3932         (TestWebKitAPI::TEST):
3933
3934 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
3935
3936         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
3937         https://bugs.webkit.org/show_bug.cgi?id=186276
3938
3939         Reviewed by Carlos Garcia Campos.
3940
3941         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
3942         (webViewLoadChanged):
3943         (testWebResourceGetDataError):
3944         (testWebResourceGetDataEmpty):
3945         (beforeAll):
3946         (webViewloadChanged): Deleted.
3947
3948 2019-03-27  Andy Estes  <aestes@apple.com>
3949
3950         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
3951         https://bugs.webkit.org/show_bug.cgi?id=196317
3952
3953         Reviewed by Dan Bernstein.
3954
3955         package-root copies built products into a staging directory using ditto(1), which does not
3956         follow symbolic links as it traverses a directory. Now that the files in
3957         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
3958         itself, these become broken links when ditto'd into the staging directory.
3959
3960         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
3961
3962         * Scripts/package-root:
3963
3964 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
3965
3966         [ews-app] Update display text of Submit for ews analysis
3967         https://bugs.webkit.org/show_bug.cgi?id=196309
3968
3969         Reviewed by Dewei Zhu.
3970
3971         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
3972
3973 2019-03-27  David Kilzer  <ddkilzer@apple.com>
3974
3975         run-webkit-tests should check for leaks in WebKit processes
3976         <https://webkit.org/b/193772>
3977         <rdar://problem/46526680>
3978
3979         Reviewed by Ryosuke Niwa.
3980
3981         This works by doing the following:
3982         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
3983           The list of child processes are returned one per line:
3984           process.name: pid
3985         - Run the "#LIST CHILD PROCESSES" command just before the
3986           "#CHECK FOR WORLD LEAKS" command, and store the list of child
3987           processes on the ServerProcess object.
3988         - When the `--leaks` switch is handled, run check_for_leaks() on
3989           each child process after the main test harness.
3990
3991         * DumpRenderTree/mac/DumpRenderTree.mm:
3992         (handleControlCommand):
3993         - Use strncmp() instead of strcmp().
3994         - Add support for handling "#LIST CHILD PROCESSES" command.
3995
3996         * Scripts/webkitpy/port/base.py:
3997         (Port.check_for_leaks):
3998         * Scripts/webkitpy/port/darwin.py:
3999         (DarwinPort.check_for_leaks):
4000         - Rename redundant 'process_pid' argument to 'process_id'.
4001
4002         * Scripts/webkitpy/port/driver.py:
4003         (Driver.do_post_tests_work):
4004         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
4005           longer the only command this sends to WebKitTestRunner.
4006         - If the `--leaks` switch is present, send the
4007           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
4008           result using Port.set_webkit_processes().
4009         (Driver._parse_child_processes_output):
4010         - Add helper method to parse list of child process names and
4011           process IDs returned from WebKitTestRunner.
4012
4013         * Scripts/webkitpy/port/ios_device.py:
4014         (IOSDevicePort.check_for_leaks):
4015         - Rename redundant 'process_pid' argument to 'process_id'.
4016
4017         * Scripts/webkitpy/port/leakdetector.py:
4018         (LeakDetector._parse_leaks_output):
4019         - Return early if there is no leaks_output.
4020         (LeakDetector.check_for_leaks):
4021         - Rename redundant 'process_pid' argument to 'process_id'.
4022
4023         * Scripts/webkitpy/port/server_process.py:
4024         (ServerProcess.__init__):
4025         (ServerProcess.child_processes):
4026         (ServerProcess.set_child_processes):
4027         - Add instance variable to Port to store list of child process
4028           names and process IDs returned from WebKitTestRunner.
4029         (ServerProcess._start):
4030         - Clear self._child_processes.
4031         (ServerProcess.stop):
4032         - If self._child_processes is set, call
4033           self._port.check_for_leaks() for each child process.
4034
4035         * Scripts/webkitpy/port/server_process_unittest.py:
4036         (TrivialMockPort.check_for_leaks):
4037         - Rename redundant 'process_pid' argument to 'process_id'.
4038
4039         * Scripts/webkitpy/port/simulator_process.py:
4040         (SimulatorProcess.stop):
4041         - If self._child_processes is set, call
4042           self._port.check_for_leaks() for each child process.
4043
4044         * Scripts/webkitpy/port/watch_device.py:
4045         (WatchDevicePort.check_for_leaks):
4046         - Rename redundant 'process_pid' argument to 'process_id'.
4047
4048         * WebKitTestRunner/TestController.cpp:
4049         (WTR::TestController::dumpResponse):
4050         - Extract method from findAndDumpWorldLeaks() so that it may be
4051           reused by findAndDumpWebKitProcessIdentifiers().
4052         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
4053         - Add method to output process name and process ID of both the
4054           WebContent and Networking processes.
4055         (WTR::TestController::findAndDumpWorldLeaks):
4056         - Fix missing newline in output when there were no abandoned
4057           documents.
4058         - Call dumpResponse() for extracted code.
4059         (WTR::TestController::handleControlCommand):
4060         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
4061         - Use strncmp() instead of strcmp().
4062         - Call findAndDumpWebKitProcessIdentifiers() when
4063           "#LIST CHILD PROCESSES" command is sent.
4064         * WebKitTestRunner/TestController.h:
4065         (WTR::TestController::dumpResponse):
4066         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
4067         - Declare methods.
4068
4069 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
4070
4071         Unreviewed. Add GLib API test cases after r243434.
4072
4073         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
4074         (testWebViewActiveURI):
4075         (serverCallback):
4076         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
4077         (sendRequestCallback):
4078
4079 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
4080
4081         Geolocation request not complete when watch request was started in a different web process
4082         https://bugs.webkit.org/show_bug.cgi?id=195996
4083
4084         Reviewed by Alex Christensen.
4085
4086         Add a test case.
4087
4088         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
4089         (TestWebKitAPI::runJavaScriptAlert):
4090         (TestWebKitAPI::TEST):
4091
4092 2019-03-26  Keith Rollin  <krollin@apple.com>
4093
4094         Update the way generate-xcfilelists returns strings from functions
4095         https://bugs.webkit.org/show_bug.cgi?id=195975
4096         <rdar://problem/49040807>
4097
4098         Reviewed by Dean Jackson.
4099
4100         There are places where generate-xcfilelists executes assignments with
4101         statements like:
4102
4103             FOO=$(some_function)
4104
4105         where "some_function" return a string by echoing it. E.g.
4106
4107             some_function()
4108             {
4109                 echo "Hello, World"
4110             }
4111
4112         This is a common idiom, but it has a problem if "some_function" needs
4113         to call "exit" in an attempt to halt the entire script right then and
4114         there. Since "some_function" is called inside of $(), it's being
4115         executed in a sub-shell. Calling exit in that sub-shell simply exits
4116         that shell; it doesn't not exit the outer shell in which the main part
4117         of the script is still running. As such, the main script keeps
4118         executing when the intent was for the script to halt.
4119
4120         The solution to this is to use a different idiom for returning
4121         strings. The one we now is to pass in the name of the variable to
4122         receive the string result:
4123
4124             some_function()
4125             {
4126                 variable_name=$1
4127                 eval $variable_name ="Hello, World"
4128             }
4129
4130         The call site now looks like
4131
4132             some_function FOO
4133
4134         Because there's no invocation of a sub-shell, some_function can now
4135         call "exit" if it wants to, and the entire script will exit at that
4136         point.
4137
4138         * Scripts/generate-xcfilelists:
4139
4140 2019-03-26  Chris Dumez  <cdumez@apple.com>
4141
4142         Add basic layout test coverage for File Picker on iOS
4143         https://bugs.webkit.org/show_bug.cgi?id=196265
4144
4145         Reviewed by Wenson Hsieh.
4146
4147         Add layout test infrastructure to test the file picker on iOS.
4148
4149         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4150         (WTR::UIScriptController::dismissFilePicker):
4151         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4152         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4153         (WTR::UIScriptController::dismissFilePicker):
4154         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4155         * WebKitTestRunner/TestController.cpp:
4156         (WTR::TestController::createWebViewWithOptions):
4157         (WTR::updateTestOptionsFromTestHeader):
4158         * WebKitTestRunner/TestOptions.h:
4159         (WTR::TestOptions::hasSameInitializationOptions const):
4160         * WebKitTestRunner/ios/TestControllerIOS.mm:
4161         (overridePresentViewController):
4162         (WTR::TestController::platformInitialize):
4163         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4164         (WTR::UIScriptController::dismissFilePicker):
4165
4166 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
4167
4168         Implement async paste method on UIWKInteractionViewProtocol
4169         https://bugs.webkit.org/show_bug.cgi?id=196267
4170         <rdar://problem/49236346>
4171
4172         Reviewed by Tim Horton.
4173
4174         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
4175         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
4176         are now a part of all iOS 12 internal SDKs.
4177
4178         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
4179
4180         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
4181         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
4182
4183         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
4184         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
4185         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
4186         * TestWebKitAPI/ios/UIKitSPI.h:
4187
4188 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
4189
4190         [ews-build] Use PostgreSQL for ews.webkit.org database
4191         https://bugs.webkit.org/show_bug.cgi?id=196270
4192
4193         Reviewed by Lucas Forschler.
4194
4195         * BuildSlaveSupport/ews-app/ews-app/settings.py:
4196
4197 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
4198
4199         [ews] Reset simctl states on reboot
4200         https://bugs.webkit.org/show_bug.cgi?id=196260
4201
4202         Rubber-stamped by Aakash Jain.
4203
4204         * EWSTools/start-queue-mac.sh:
4205
4206 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
4207
4208         [ews-build] Use PostgreSQL for ews-build database
4209         https://bugs.webkit.org/show_bug.cgi?id=196229
4210
4211         Reviewed by Lucas Forschler.
4212
4213         * BuildSlaveSupport/ews-build/master.cfg:
4214
4215 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
4216
4217         [ews-build] Get master_hostname dynamically in master.cfg
4218         https://bugs.webkit.org/show_bug.cgi?id=196255
4219
4220         Reviewed by Lucas Forschler.
4221
4222         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
4223         send events data in test mode.
4224
4225 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
4226
4227         [ews-app] Set db_constraint to False for Foreign Keys
4228         https://bugs.webkit.org/show_bug.cgi?id=196252
4229
4230         Reviewed by Lucas Forschler.
4231
4232         * BuildSlaveSupport/ews-app/ews/models/build.py:
4233         * BuildSlaveSupport/ews-app/ews/models/step.py:
4234
4235 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
4236
4237         [ews-build] is_test_mode_enabled should default to True
4238         https://bugs.webkit.org/show_bug.cgi?id=196248
4239
4240         Reviewed by Lucas Forschler.
4241
4242         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
4243
4244 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
4245
4246         [ews-app] Add webkitperl to ENABLED_QUEUES
4247         https://bugs.webkit.org/show_bug.cgi?id=196253
4248
4249         Reviewed by Lucas Forschler.
4250
4251         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4252
4253 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
4254
4255         Address NSWindow sometimes using WebKitTestRunnerEvent too early
4256         https://bugs.webkit.org/show_bug.cgi?id=196211
4257         rdar://problem/49110552
4258
4259         Reviewed by Tim Horton.
4260
4261         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
4262         Make sure that EventSenderProxy always exists when running tests. We used to create
4263         it when resetting before the first test, which is a bit too late.
4264
4265         * WebKitTestRunner/TestController.h:
4266         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
4267         (WTR::TestController::platformCreateWebView):
4268         (WTR::TestController::platformCreateOtherPage):
4269         (WTR::TestController::finishCreatingPlatformWebView):
4270         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
4271         (WTR::PlatformWebView::PlatformWebView):
4272         Moved some code that made NSWindow use NSEvent during web view creation. We may
4273         need to move more if some other case us found, but this is enough for now.
4274
4275 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
4276
4277         Unreviewed. Fix typo in GLib geolocation API after r243285.
4278
4279         gelocation -> geolocation.
4280
4281         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
4282         (testGeolocationManagerWatchPosition):
4283
4284 2019-03-25  Alex Christensen  <achristensen@webkit.org>
4285
4286         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
4287         https://bugs.webkit.org/show_bug.cgi?id=196213
4288
4289         Reviewed by Geoff Garen.
4290
4291         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4292         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
4293         (credentialWithIdentityAndKeychainPath):
4294         (-[ChallengeDelegate webView:didFinishNavigation:]):
4295         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
4296         (TestWebKitAPI::TEST):
4297
4298 2019-03-25  Alex Christensen  <achristensen@webkit.org>
4299
4300         Expected shouldn't assume its contained types are copyable
4301         https://bugs.webkit.org/show_bug.cgi?id=195986
4302
4303         Reviewed by JF Bastien.
4304
4305         * TestWebKitAPI/Tests/WTF/Expected.cpp:
4306         (TestWebKitAPI::NonCopyable::operator== const):
4307         (TestWebKitAPI::NonCopyable::operator!= const):
4308         (TestWebKitAPI::TEST):
4309
4310 2019-03-25  Tim Horton  <timothy_horton@apple.com>
4311
4312         Remove some now-unnecessary dynamic class lookup
4313         https://bugs.webkit.org/show_bug.cgi?id=196237
4314
4315         Reviewed by Simon Fraser.
4316
4317         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
4318         (makeRequest):
4319         (TEST):
4320
4321 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
4322
4323         Unreviewed, rolling out r243450.
4324
4325         AppleWin and WinCairo port builds get broken.
4326
4327         Reverted changeset:
4328
4329         "Add test for fix of #196095"