[jhbuild] wrong Dependencies path
[WebKit-https.git] / Tools / ChangeLog
1 2014-12-02  Philippe Normand  <pnormand@igalia.com>
2
3         [jhbuild] wrong Dependencies path
4         https://bugs.webkit.org/show_bug.cgi?id=139176
5
6         Reviewed by Martin Robinson.
7
8         * Scripts/webkitpy/port/base.py:
9         (Port._should_use_jhbuild):
10
11 2014-12-02  Philippe Normand  <pnormand@igalia.com>
12
13         [GStreamer] Bump internal jhbuild versions to 1.4.4
14         https://bugs.webkit.org/show_bug.cgi?id=138866
15
16         Reviewed by Carlos Garcia Campos.
17
18         * gtk/jhbuild.modules:
19         * gtk/patches/gst-events-arent-gstobjects.patch: Removed.
20         * gtk/patches/gst-plugins-base-fix-build-gcc-4.9-x86.patch: Removed.
21         * gtk/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch: Removed.
22
23 2014-12-01  Commit Queue  <commit-queue@webkit.org>
24
25         Unreviewed, rolling out r176566.
26         https://bugs.webkit.org/show_bug.cgi?id=139124
27
28         It broke the GTK performance tests. (Requested by clopez on
29         #webkit).
30
31         Reverted changeset:
32
33         "[GTK] Use GMainLoopSource in WebKitTestRunner"
34         https://bugs.webkit.org/show_bug.cgi?id=138831
35         http://trac.webkit.org/changeset/176566
36
37 2014-11-29  Anders Carlsson  <andersca@apple.com>
38
39         Crash when calling WKPageClose on the originated page from within createNewPage callback
40         https://bugs.webkit.org/show_bug.cgi?id=139099
41         <rdar://problem/19052564>
42
43         Reviewed by Sam Weinig.
44
45         Add a test.
46
47         * TestWebKitAPI/PlatformWebView.h:
48         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
49         * TestWebKitAPI/Tests/WebKit2/CloseFromWithinCreatePage.cpp: Added.
50         (TestWebKitAPI::runJavaScriptAlert):
51         (TestWebKitAPI::createNewPage):
52         (TestWebKitAPI::TEST):
53         * TestWebKitAPI/Tests/WebKit2/close-from-within-create-page.html: Added.
54         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
55         (TestWebKitAPI::PlatformWebView::PlatformWebView):
56
57 2014-11-28  Commit Queue  <commit-queue@webkit.org>
58
59         Unreviewed, rolling out r176564.
60         https://bugs.webkit.org/show_bug.cgi?id=139093
61
62         massive failures on release test bot (Requested by philn on
63         #webkit).
64
65         Reverted changeset:
66
67         "[GStreamer] Bump internal jhbuild versions to 1.4.4"
68         https://bugs.webkit.org/show_bug.cgi?id=138866
69         http://trac.webkit.org/changeset/176564
70
71 2014-11-28  Carlos Garcia Campos  <cgarcia@igalia.com>
72
73         [GTK] Use GMainLoopSource in WebKitTestRunner
74         https://bugs.webkit.org/show_bug.cgi?id=138831
75
76         Reviewed by Sergio Villar Senin.
77
78         * WebKitTestRunner/InjectedBundle/TestRunner.h:
79         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
80         (WTR::TestRunner::platformInitialize):
81         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
82         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
83         (WTR::waitToDumpWatchdogTimerCallback): Deleted.
84         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
85         (WTR::TestController::notifyDone):
86         (WTR::TestController::platformRunUntil):
87         (WTR::cancelTimeout): Deleted.
88
89 2014-11-24  Philippe Normand  <pnormand@igalia.com>
90
91         [GStreamer] Bump internal jhbuild versions to 1.4.4
92         https://bugs.webkit.org/show_bug.cgi?id=138866
93
94         Reviewed by Carlos Garcia Campos.
95
96         * gtk/jhbuild.modules:
97         * gtk/patches/gst-events-arent-gstobjects.patch: Removed.
98         * gtk/patches/gst-plugins-base-fix-build-gcc-4.9-x86.patch: Removed.
99         * gtk/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch: Removed.
100
101 2014-11-28  Carlos Garcia Campos  <cgarcia@igalia.com>
102
103         [GTK] Use custom JavaScript instead of DBus to implement WebProcess tests
104         https://bugs.webkit.org/show_bug.cgi?id=138834
105
106         Reviewed by Sergio Villar Senin.
107
108         It makes everyting simpler and the tests run faster too, since we
109         don't need to spawn the private bus and wait until the DBus name
110         is registered. The web extension registers a new JavaSCript class
111         with a status method to run the tests, similar to the DBus
112         method. In the UI process side, tests use webkit_web_view_run_java_script()
113         instead of sending a DBus message.
114
115         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
116         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeFilterTest.cpp:
117         (WebKitDOMNodeFilterTest::create):
118         (WebKitDOMNodeFilterTest::testTreeWalker):
119         (WebKitDOMNodeFilterTest::testNodeIterator):
120         (WebKitDOMNodeFilterTest::webPageFromArgs): Deleted.
121         (WebKitDOMNodeFilterTest::runTest): Deleted.
122         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
123         (WebKitDOMNodeTest::create):
124         (WebKitDOMNodeTest::testHierarchyNavigation):
125         (WebKitDOMNodeTest::testInsertion):
126         (WebKitDOMNodeTest::testTagNames):
127         (WebKitDOMNodeTest::webPageFromArgs): Deleted.
128         (WebKitDOMNodeTest::runTest): Deleted.
129         * TestWebKitAPI/Tests/WebKit2Gtk/DOMXPathNSResolverTest.cpp:
130         (WebKitDOMXPathNSResolverTest::create):
131         (WebKitDOMXPathNSResolverTest::testXPathNSResolverNative):
132         (WebKitDOMXPathNSResolverTest::testXPathNSResolverCustom):
133         (WebKitDOMXPathNSResolverTest::webPageFromArgs): Deleted.
134         (WebKitDOMXPathNSResolverTest::runTest): Deleted.
135         * TestWebKitAPI/Tests/WebKit2Gtk/FrameTest.cpp:
136         (WebKitFrameTest::create):
137         (WebKitFrameTest::testMainFrame):
138         (WebKitFrameTest::testURI):
139         (WebKitFrameTest::testJavaScriptContext):
140         (WebKitFrameTest::webPageFromArgs): Deleted.
141         (WebKitFrameTest::runTest): Deleted.
142         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
143         (testWebKitDOMNodeHierarchyNavigation):
144         (testWebKitDOMNodeInsertion):
145         (testWebKitDOMNodeTagNames):
146         (beforeAll):
147         (afterAll):
148         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNodeFilter.cpp:
149         (runTest):
150         (beforeAll):
151         (afterAll):
152         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMXPathNSResolver.cpp:
153         (testWebKitDOMXPathNSResolverNative):
154         (testWebKitDOMXPathNSResolverCustom):
155         (beforeAll):
156         (afterAll):
157         (runTest): Deleted.
158         * TestWebKitAPI/Tests/WebKit2Gtk/TestFrame.cpp:
159         (webkitFrameTestRun):
160         (beforeAll):
161         (afterAll):
162         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
163         (testsMap):
164         (WebProcessTest::add):
165         (WebProcessTest::create):
166         (runTest):
167         (windowObjectClearedCallback):
168         (webkit_web_extension_initialize):
169         (methodCallCallback): Deleted.
170         (webkit_web_extension_initialize_with_user_data): Deleted.
171         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h:
172         * TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.cpp: Removed.
173         * TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.h: Removed.
174         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
175         (WebViewTest::runWebProcessTest):
176         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
177
178 2014-11-28  Csaba Osztrogonác  <ossy@webkit.org>
179
180         [EFL] libseccomp should pick up CC environment variable to be conform to other jhbuild modules
181         https://bugs.webkit.org/show_bug.cgi?id=139086
182
183         Reviewed by Gyuyoung Kim.
184
185         * efl/jhbuild.modules:
186         * efl/patches/libseccomp-pick-up-CC.patch: Added.
187
188 2014-11-28  Bartlomiej Gajda  <b.gajda@samsung.com>
189
190         [EFL] Add warning if CMake version is too old for building with ninja.
191         https://bugs.webkit.org/show_bug.cgi?id=139055
192
193         Reviewed by Gyuyoung Kim.
194
195         CMake need to be >= 2.8.10 to build WebKit using ninja, some repos don't have
196         that version in their repositories.
197
198         * efl/install-dependencies:
199
200 2014-11-28  Andrzej Badowski  <a.badowski@samsung.com>
201
202         [ATK] Allowing the use of AccessibilityUIElement::columnHeaders method for table.
203         https://bugs.webkit.org/show_bug.cgi?id=139044
204
205         Reviewed by Chris Fleizach.
206
207         ATK method AccessibilityUIElement::columnHeaders currently focused only on the object table cell.
208         The proposed solution will enable the use of this method for the object table.
209         Existing test shows the result.
210
211         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
212         (WTR::AccessibilityUIElement::columnHeaders):
213
214 2014-11-27  Ryuan Choi  <ryuan.choi@navercorp.com>
215
216         [EFL] Remove E_Dbus dependency
217         https://bugs.webkit.org/show_bug.cgi?id=136355
218
219         Reviewed by Gyuyoung Kim.
220
221         * MiniBrowser/efl/CMakeLists.txt: Removed E_DBUS includes.
222
223 2014-11-26  Akos Kiss  <akiss@inf.u-szeged.hu>
224
225         [EFL][GTK] Bump up FDE relocation fixing patch to version accepted to LLVM trunk.
226         https://bugs.webkit.org/show_bug.cgi?id=139047
227
228         Reviewed by Carlos Garcia Campos.
229
230         * efl/jhbuild.modules:
231         * efl/patches/llvm-elf-allow-fde-references-outside-the-2gb-range.patch: Added.
232         * efl/patches/llvm-elf-fix-x86_64-fdecfiencoding.patch: Removed.
233         * gtk/jhbuild-optional.modules:
234         * gtk/patches/llvm-elf-allow-fde-references-outside-the-2gb-range.patch: Added.
235         * gtk/patches/llvm-elf-fix-x86_64-fdecfiencoding.patch: Removed.
236
237 2014-11-25  Tanay C  <tanay.c@samsung.com>
238
239         [GTK] Minibrowser: Add support for zoom using Control Key + Mouse scroll
240         https://bugs.webkit.org/show_bug.cgi?id=138090
241
242         Reviewed by Carlos Garcia Campos.
243
244         * MiniBrowser/gtk/BrowserWindow.c: Implementing zoom using Cntrl + Mouse scroll
245         (browserWindowZoomIn): Added.
246         (browserWindowZoomOut): Added.
247         (scrollEventCallback): Added.
248         (zoomInCallback): Modified.
249         (zoomOutCallback): Modified.
250         (browserWindowConstructed): Modified.
251
252 2014-11-25  Csaba Osztrogonác  <ossy@webkit.org>
253
254         [EFL] REGRESSION(r176514): It made performance tests fail
255         https://bugs.webkit.org/show_bug.cgi?id=139037
256
257         Reviewed by Gyuyoung Kim.
258
259         * Scripts/webkitpy/port/efl.py:
260         (EflPort.setup_environ_for_server): Pass ACCESSIBILITY_EAIL_LIBRARY_PATH environment variable to WTR.
261         * efl/jhbuildrc: Set ACCESSIBILITY_EAIL_LIBRARY_PATH to point to DependenciesEFL/lib/libeail.so
262         only if ACCESSIBILITY_EAIL_LIBRARY_PATH isn't already set and DependenciesEFL/lib/libeail.so exists.
263
264 2014-11-24  Michael Catanzaro  <mcatanzaro@igalia.com>
265
266         [GTK] update-webkitgtk-libs fails to build fontconfig
267         https://bugs.webkit.org/show_bug.cgi?id=139032
268
269         Reviewed by Martin Robinson.
270
271         On Fedora, if docbook-utils is installed but docbook-utils-pdf is not,
272         fontconfig will try to generate documentation and fail.
273
274         * gtk/install-dependencies:
275
276 2014-11-24  Carlos Garcia Campos  <cgarcia@igalia.com>
277
278         Unreviewed. Fix GTK+ make distcheck.
279
280         * gtk/manifest.txt: Remove deleted files.
281
282 2014-11-24  Krzysztof Czech  <k.czech@samsung.com>
283
284         [EFL] Utilize Eail library to support accessibility in EFL
285         https://bugs.webkit.org/show_bug.cgi?id=137742
286
287         Reviewed by Gyuyoung Kim.
288
289         Eail, atk-bridge, at-spi2 are not mandatory modules for webkit-efl. They are rather optional.
290
291         * efl/jhbuild-optional.modules: Added.
292         * efl/jhbuild.modules:
293
294 2014-11-24  Carlos Garcia Campos  <cgarcia@igalia.com>
295
296         [GTK] WebKitWebView is created with the wrong web context when using webkit_web_view_new_with_related_view()
297         https://bugs.webkit.org/show_bug.cgi?id=139023
298
299         Reviewed by Sergio Villar Senin.
300
301         Rename WebKitWebView/default-context as WebKitWebView/web-context
302         and check we are always using the right context for new web views.
303
304         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
305         (testWebViewWebContext):
306         (beforeAll):
307         (testWebViewDefaultContext): Deleted.
308
309 2014-11-23  Carlos Garcia Campos  <cgarcia@igalia.com>
310
311         [GTK] Add API to override the default local storage directory
312         https://bugs.webkit.org/show_bug.cgi?id=138828
313
314         Reviewed by Gustavo Noronha Silva.
315
316         Add test to check that the local storage directory is created at
317         the path given on construction.
318
319         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
320         (testWebContextConfiguration):
321         (beforeAll):
322         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
323         (Test::Test):
324         (Test::~Test): Deleted.
325
326 2014-11-21  Zalan Bujtas  <zalan@apple.com>
327
328         Simple line layout: Add "show simple line layout debug borders" setting to MiniBrowser.
329         https://bugs.webkit.org/show_bug.cgi?id=138981
330
331         Reviewed by Simon Fraser.
332
333         * MiniBrowser/mac/SettingsController.h:
334         * MiniBrowser/mac/SettingsController.m:
335         (-[SettingsController _populateMenu]):
336         (-[SettingsController validateMenuItem:]):
337         (-[SettingsController toggleSimpleLineLayoutDebugBordersEnabled:]):
338         (-[SettingsController simpleLineLayoutDebugBordersEnabled]):
339         * MiniBrowser/mac/WK1BrowserWindowController.m:
340         (-[WK1BrowserWindowController didChangeSettings]):
341         * MiniBrowser/mac/WK2BrowserWindowController.m:
342         (-[WK2BrowserWindowController didChangeSettings]):
343
344 2014-11-21  Csaba Osztrogonác  <ossy@webkit.org>
345
346         Remove http lock code from webkitperl
347         https://bugs.webkit.org/show_bug.cgi?id=138959
348
349         Reviewed by Alexey Proskuryakov.
350
351         * Scripts/webkitperl/httpd.pm:
352         (cleanUp):
353         (extractLockNumber): Deleted.
354         (getLockFiles): Deleted.
355         (getNextAvailableLockNumber): Deleted.
356         (getLockNumberForCurrentRunning): Deleted.
357         (waitForHTTPDLock): Deleted.
358         (scheduleHttpTesting): Deleted.
359         (getWaitTime): Deleted.
360
361 2014-11-20  Hunseop Jeong  <hs85.jeong@samsung.com>
362
363         [EFL] The option value of fixed layout is false in MiniBrowser
364         https://bugs.webkit.org/show_bug.cgi?id=138830
365
366         Reviewed by Gyuyoung Kim.
367
368         Changed the option value of fixed layout to EINA_TRUE in MiniBrowser.
369
370         * MiniBrowser/efl/main.c:
371
372 2014-11-20  Adrian Perez de Castro  <aperez@igalia.com>
373
374         [GTK] Provide convenience API in DOM bindings to post messages to user message handlers
375         https://bugs.webkit.org/show_bug.cgi?id=138871
376
377         Reviewed by Carlos Garcia Campos.
378
379         Add a test case for the convenience API for posting user messages
380         added to the DOM bindings.
381
382         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
383         (testUserContentManagerMessageFromConvenienceDOMBindings):
384         (beforeAll):
385         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
386         (documentLoadedCallback):
387
388 2014-11-19  Dana Burkart  <dburkart@apple.com>
389
390         Work around the fact that different masters may have different names for their codebases.
391         https://bugs.webkit.org/show_bug.cgi?id=138878
392
393         Reviewed by Mark Rowe.
394
395         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
396         (parseRevisionProperty): Changed.
397         Take a "fallback key" in addition to the primary key, so we can deal with inconsistencies in
398         opensource / internal codebase naming convention.
399
400 2014-11-19  Chris Fleizach  <cfleizach@apple.com>
401
402         AX: Screen braille input doesn't work on forms.
403         https://bugs.webkit.org/show_bug.cgi?id=138804
404
405         Unreviewed build fix.
406
407         * DumpRenderTree/AccessibilityUIElement.cpp:
408         (AccessibilityUIElement::setValue):
409
410 2014-11-19  Chris Fleizach  <cfleizach@apple.com>
411
412         AX: Screen braille input doesn't work on forms.
413         https://bugs.webkit.org/show_bug.cgi?id=138804
414
415         Reviewed by Mario Sanchez Prada.
416
417         Add a method to setValue through the AX API in DRT.
418
419         * DumpRenderTree/AccessibilityUIElement.cpp:
420         (setValueCallback):
421         (AccessibilityUIElement::getJSClass):
422         * DumpRenderTree/AccessibilityUIElement.h:
423         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
424         (AccessibilityUIElement::setValue):
425         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
426         (AccessibilityUIElement::setValue):
427
428 2014-11-18  Csaba Osztrogonác  <ossy@webkit.org>
429
430         Remove the WinCairo buildbot
431         https://bugs.webkit.org/show_bug.cgi?id=138805
432
433         Reviewed by Alex Christensen.
434
435         * BuildSlaveSupport/build.webkit.org-config/config.json:
436         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
437         (appendCustomBuildFlags):
438         * BuildSlaveSupport/test-result-archive:
439         (archiveTestResults):
440
441 2014-11-18  Daniel Bates  <dabates@apple.com>
442
443         [iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions, MobileGestalt
444         SPI are not available in public SDK
445         https://bugs.webkit.org/show_bug.cgi?id=138802
446
447         Reviewed by David Kilzer.
448
449         Include header MachVMSPI.h instead of including the private header mach/mach_vm.h.
450
451         * DumpRenderTree/mac/CheckedMalloc.cpp:
452
453 2014-11-18  Carlos Garcia Campos  <cgarcia@igalia.com>
454
455         Unreviewed. Fix after /webkit2/WebKitWebView/default-context r176256.
456
457         Forgot to fix this test before landing.
458
459         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
460         (testWebViewDefaultContext):
461
462 2014-11-18  Carlos Garcia Campos  <cgarcia@igalia.com>
463
464         [GTK] Add API to create a WebKitWebContext
465         https://bugs.webkit.org/show_bug.cgi?id=138826
466
467         Reviewed by Gustavo Noronha Silva.
468
469         Use a different WebKitWebContext for every test to ensure test
470         cases are independent to each other. Tests using DBus to
471         communicate with the injected bundle extension now use a unique
472         name for the well known DBus name.
473
474         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
475         (beforeAll): Remove comment about the order of the tests and
476         move the success test before the failed one now that tests don't
477         depend on each others.
478         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
479         (beforeAll): Remove call to set the web extensions directory,
480         since this is now done for all test in the Test constructor.
481         * TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp:
482         (beforeAll): Do not create a temporary directory, a temporary data
483         directory is now created for all tests.
484         (afterAll):
485         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
486         (testWebKitDOMNodeHierarchyNavigation): Pass the web extension ID
487         to the web process test runner.
488         (testWebKitDOMNodeInsertion): Ditto.
489         (testWebKitDOMNodeTagNames): Ditto.
490         (beforeAll): Remove call to set the web extensions directory.
491         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNodeFilter.cpp:
492         (runTest): Pass the web extension ID to the web process test runner.
493         (beforeAll): Remove call to set the web extensions directory.
494         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMXPathNSResolver.cpp:
495         (runTest): Pass the web extension ID to the web process test runner.
496         (beforeAll): Remove call to set the web extensions directory.
497         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
498         (createFileAtDestination): Use Test::dataDirectory() as base dir
499         for temporary files.
500         (beforeAll): Do not create a temporary directory.
501         (afterAll):
502         * TestWebKitAPI/Tests/WebKit2Gtk/TestFrame.cpp:
503         (webkitFrameTestRun): Pass the web extension ID to the web process
504         test runner.
505         (beforeAll): Remove call to set the web extensions directory.
506         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
507         (beforeAll): Remove call to set the web extensions directory.
508         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
509         (testProcessPerWebView): Use local member instead of global variable.
510         (testMultiprocessWebViewCreateReadyClose): Ditto.
511         (beforeAll): Do not connect to initialize-web-extensions, Test now
512         connects to the signal for all tests and calls a virtual method
513         that test can override.
514         (afterAll):
515         (initializeWebExtensions): Deleted.
516         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
517         (testPrintOperationPrint): Use Test::dataDirectory() as base dir
518         for temporary files.
519         (beforeAll): Do not create a temporary directory.
520         (afterAll):
521         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
522         (beforeAll): Remove call to set the web extensions directory.
523         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
524         (beforeAll): Remove comment about the tests order.
525         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
526         (testWebExtensionGetTitle): Build the DBus service name using the
527         web extension ID.
528         (testDocumentLoadedSignal): Ditto.
529         (testWebKitWebViewProcessCrashed): Ditto.
530         (testWebExtensionIsolatedWorld): Ditto.
531         (beforeAll): Remove initialization-user-data test, since now all
532         tests are passing user data to the web extension.
533         (testWebExtensionInitializationUserData): Deleted.
534         (initializeWebExtensions): Deleted.
535         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
536         (testSetDirectory): Use the web context member inherited from Test.
537         (testClearDatabase): Ditto.
538         (testGetFaviconURI): Ditto.
539         (beforeAll): Do not create a temporary directory.
540         (afterAll):
541         (webkitFaviconDatabaseFinalizedCallback): Deleted.
542         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
543         (UserContentManagerTest::UserContentManagerTest):
544         (beforeAll): Remove call to set the web extensions directory.
545         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
546         (testWebContextDefault): Check also that a newly create web
547         context is not the default web context.
548         (testWebContextSpellChecker): Use the web context member inherited
549         from Test.
550         (testWebContextLanguages): Ditto.
551         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
552         (methodCallCallback): Remove GetInitializationUserData method.
553         (webkit_web_extension_initialize_with_user_data): Always create
554         the DBus name using the user data provided.
555         (makeBusName): Deleted.
556         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
557         (webkit_web_extension_initialize_with_user_data): Create the DBus
558         name using the user data provided.
559         (webkit_web_extension_initialize): Deleted.
560         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.cpp:
561         (Test::dataDirectory): Return the temporary data directory.
562         (removeNonEmptyDirectory): Also remove directories recursively.
563         (main): Remove the disk cache directory initialization, since this
564         is now done in the Test constructor.
565         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
566         (Test::initializeWebExtensionsCallback): Call the virtual method
567         initializeWebExtensions()
568         (Test::Test): Create a new WebKitWebContext and initialize it.
569         (Test::~Test): Disconnect initialize-web-extensions signal.
570         (Test::initializeWebExtensions): Set the web extensions directory
571         and user data.
572         * TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.cpp:
573         (WebProcessTestRunner::~WebProcessTestRunner): Use nullptr.
574         (WebProcessTestRunner::runTest): Build the DBus proxy using a
575         unique name created with the Test web extension ID.
576         (WebProcessTestRunner::proxy): Deleted.
577         * TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.h:
578         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
579         (WebViewTest::WebViewTest): Create the web view with the Test web
580         context.
581         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h: Add optional user
582         content manager parameter to the constructor.
583
584 2014-11-18  ChangSeok Oh  <changseok.oh@collabora.com>
585
586         [GTK] Mesa build fails over llvm-3.5
587         https://bugs.webkit.org/show_bug.cgi?id=138825
588
589         Reviewed by Gustavo Noronha Silva.
590
591         OwningPtr.h have been removed in llvm-3.5. Instread we should use std::unique_ptr for mesa build.
592
593         * gtk/jhbuild.modules:
594         * gtk/patches/mesa-gallivm-Fix-build-after-LLVM-commit-211259.patch: Added.
595
596 2014-11-17  Daniel Bates  <dabates@apple.com>
597
598         Unreviewed, rolling out r176232.
599
600         Broke the Mac build. Will investigate offline.
601
602         Reverted changeset:
603
604         "[iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions,
605         MobileGestalt"
606         https://bugs.webkit.org/show_bug.cgi?id=138802
607         http://trac.webkit.org/changeset/176232
608
609 2014-11-17  Daniel Bates  <dabates@apple.com>
610
611         [iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions, MobileGestalt
612         SPI are not available in public SDK
613         https://bugs.webkit.org/show_bug.cgi?id=138802
614
615         Reviewed by David Kilzer.
616
617         Include header MachVMSPI.h instead of including the private header mach/mach_vm.h.
618
619         * DumpRenderTree/mac/CheckedMalloc.cpp:
620
621 2014-11-17  Jake Nielsen  <jacob_nielsen@apple.com>
622
623         Having 30+ flaky failures breaks EWS
624         https://bugs.webkit.org/show_bug.cgi?id=138743
625
626         Reviewed by Alexey Proskuryakov.
627
628         Adds tests to ensure that the problem has been solved.
629         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
630         (test_first_failure_limit):
631         (test_first_failure_limit_with_some_tree_redness):
632         (test_second_failure_limit):
633         (test_tree_failure_limit_with_patch_that_potentially_fixes_some_redness):
634         (test_first_and_second_failure_limit):
635         (test_first_and_clean_failure_limit):
636         (test_first_second_and_clean_failure_limit):
637         (test_very_red_tree_retry): Deleted.
638         Really this was renamed to test_first_second_and_clean_failure_limit.
639         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
640         Makes the appropriate changes to PatchAnalysisTask to make sure that
641         even when the first test run hits the failure limit, it will still try
642         a second run.
643         (PatchAnalysisTask._results_failed_different_tests):
644         (PatchAnalysisTask._test_patch):
645         (PatchAnalysisTask._continue_testing_patch_that_exceeded_failure_limit_on_first_or_second_try): Deleted.
646
647 2014-11-17  Ting-Wei Lan  <lantw44@gmail.com>
648
649         [GTK] Add library search paths from LDFLAGS before pkg-config --libs
650         https://bugs.webkit.org/show_bug.cgi?id=136018
651
652         Reviewed by Carlos Garcia Campos.
653
654         It is possible that the order of -L arguments in the output of
655         pkg-config is wrong, which causes the linker to find the wrong
656         version (usually older version) of libraries when running
657         gtkdoc-scangobj.
658
659         * gtk/gtkdoc.py:
660         (GTKDoc._run_gtkdoc_scangobj):
661
662 2014-11-17  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
663
664         Bump EFL version to 1.12.0
665         https://bugs.webkit.org/show_bug.cgi?id=138733
666
667         Reviewed by Gyuyoung Kim.
668
669         * efl/jhbuild.modules:
670
671 2014-11-16  Joanmarie Diggs  <jdiggs@igalia.com>
672
673         AX: [ATK] Expose the blockquote element using ATK_ROLE_BLOCK_QUOTE
674         https://bugs.webkit.org/show_bug.cgi?id=138771
675
676         Reviewed by Chris Fleizach.
677
678         Add mapping for ATK_ROLE_BLOCK_QUOTE in roleToString()
679
680         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
681
682 2014-11-15  Joanmarie Diggs  <jdiggs@igalia.com>
683
684         AX: [ATK] Video and audio elements should be exposed using ATK's video and audio roles.
685         https://bugs.webkit.org/show_bug.cgi?id=138767
686
687         Reviewed by Chris Fleizach.
688
689         Add mappings for ATK_ROLE_AUDIO and ATK_ROLE_VIDEO to roleToString().
690
691         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
692
693 2014-11-14  Alexey Proskuryakov  <ap@apple.com>
694
695         Add shortcut macros to Mac TestExpectations
696         https://bugs.webkit.org/show_bug.cgi?id=138729
697
698         Reviewed by Simon Fraser.
699
700         * Scripts/webkitpy/port/mac.py: (MacPort.configuration_specifier_macros):
701         Add version macros for current OS versions.
702
703 2014-11-13  Alexey Proskuryakov  <ap@apple.com>
704
705         https://bugs.webkit.org/show_bug.cgi?id=138628
706         A patch that doesn't apply is stuck in commit queue
707
708         Rubber-stamped by David Kilzer.
709
710         This also hopefully fixes other issues:
711         - a patch that has cq+ flag set by a non-committer kills commit queue;
712         - EWS never reports failing tests, and keeps spinning instead.
713
714         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
715         (Bugzilla.set_flag_on_attachment):
716         (Bugzilla.obsolete_attachment):
717         Apply the fix from r174797 to more places.
718
719 2014-11-13  Dan Bernstein  <mitz@apple.com>
720
721         Policy client not called for navigations through the page cache
722         https://bugs.webkit.org/show_bug.cgi?id=138703
723
724         Reviewed by Alexey Proskuryakov.
725
726         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
727         (-[DecidePolicyForPageCacheNavigationDelegate webView:didFinishNavigation:]):
728         (-[DecidePolicyForPageCacheNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
729
730 2014-11-13  Joanmarie Diggs  <jdiggs@igalia.com>
731
732         AX: [ATK] Do not return ATK_ROLE_UNKNOWN for null or otherwise invalid accessible objects
733         https://bugs.webkit.org/show_bug.cgi?id=137867
734
735         Reviewed by Chris Fleizach.
736
737         Add ATK_ROLE_INVALID to roleToString. Remove the null AtkRole check in
738         AccessibilityUIElement::role: ATK_ROLE_INVALID = 0, and we need to be
739         able to test for the presence of ATK_ROLE_INVALID.
740
741         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
742         (WTR::AccessibilityUIElement::role):
743
744 2014-11-13  Juergen Ributzka  <juergen@apple.com>
745
746         Update the "combineModules" script to handel more LLVM metadata.
747         https://bugs.webkit.org/show_bug.cgi?id=138514
748
749         Reviewed by Filip Pizlo.
750
751         * ReducedFTL/combineModules.rb:
752
753 2014-11-13  Myles C. Maxfield  <mmaxfield@apple.com>
754
755         Allow constructing a base PassRef with a derived Ref
756         https://bugs.webkit.org/show_bug.cgi?id=138701
757
758         Reviewed by Andreas Kling
759
760         * TestWebKitAPI/Tests/WTF/Ref.cpp:
761         (TestWebKitAPI::passWithPassRef):
762         (TestWebKitAPI::passWithPassRefPtr):
763         (TestWebKitAPI::TEST):
764
765 2014-11-05  Ada Chan  <adachan@apple.com>
766
767         Implement new plug-in API for muting plug-ins
768         https://bugs.webkit.org/show_bug.cgi?id=138105
769
770         Reviewed by Anders Carlsson.
771
772         Add a new plug-in test for the mute API.
773
774         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
775         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SetMuted.cpp: Added.
776         (SetMuted::SetMuted):
777         (SetMuted::isMuted):
778         (SetMuted::cachedIsMuted):
779         (SetMuted::ScriptableObject::hasProperty):
780         (SetMuted::ScriptableObject::getProperty):
781         (SetMuted::ScriptableObject::pluginTest):
782         (SetMuted::NPP_New):
783         (SetMuted::NPP_GetValue):
784         (SetMuted::NPP_SetValue):
785
786 2014-11-12  Philippe Normand  <pnormand@igalia.com>
787
788         Unreviewed, GTK gardening.
789
790         * Scripts/run-gtk-tests:
791         (TestRunner): Skip the UserMediaBasic test because it depends on
792         constraints validation which is going to be fixed in bug #136449.
793
794 2014-11-12  Carlos Garcia Campos  <cgarcia@igalia.com>
795
796         [GTK] Expose user script messages to GObject DOM bindings
797         https://bugs.webkit.org/show_bug.cgi?id=138411
798
799         Reviewed by Philippe Normand.
800
801         Add a test case to check that user script messages sent using the
802         DOM bindings API are also received in the UI process.
803
804         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
805         (UserScriptMessageTest::waitUntilMessageReceived):
806         (UserScriptMessageTest::postMessageAndWaitUntilReceived):
807         (testUserContentManagerScriptMessageFromDOMBindings):
808         (beforeAll):
809         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
810         (documentLoadedCallback):
811
812 2014-11-12  Carlos Garcia Campos  <cgarcia@igalia.com>
813
814         Unreviewed. Fix GTK+ clean build after r175930.
815
816         Partial rollout of r175930 to not build the new unit test that
817         broke clean builds in GTK+ port.
818
819         * TestWebKitAPI/PlatformGTK.cmake:
820
821 2014-09-01  Philippe Normand  <pnormand@igalia.com>
822
823         [WK2] UserMediaClient support
824         https://bugs.webkit.org/show_bug.cgi?id=123158
825
826         Reviewed by Benjamin Poulain.
827
828         Simple API test for the UserMedia permission request API. The
829         required test infrastructure is also added, inspired by the
830         Geolocation infrastructure.
831
832         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: New API test for UserMedia
833         Permission request.
834         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp: Added.
835         (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack):
836         (TestWebKitAPI::TEST):
837         * TestWebKitAPI/Tests/WebKit2/getUserMedia.html: Added.
838         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: new
839         helper method to set the permission request result without user interaction.
840         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: Ditto.
841         (WTR::InjectedBundle::setUserMediaPermission):
842         * WebKitTestRunner/InjectedBundle/InjectedBundle.h: Ditto.
843         * WebKitTestRunner/InjectedBundle/TestRunner.cpp: Ditto.
844         (WTR::TestRunner::setUserMediaPermission):
845         * WebKitTestRunner/InjectedBundle/TestRunner.h: Ditto.
846         * WebKitTestRunner/TestController.cpp:
847         (WTR::decidePolicyForUserMediaPermissionRequest): Permission
848         request handler.
849         (WTR::TestController::createOtherPage): Enable the new UserMedia
850         permission request handler.
851         (WTR::TestController::createWebViewWithOptions): Ditto.
852         (WTR::TestController::resetPreferencesToConsistentValues): Enable
853         MediaStream support, this is needed for getUserMedia.
854         (WTR::TestController::resetStateToConsistentValues): clear
855         UserMedia permissions list and flags.
856         (WTR::TestController::setUserMediaPermission): Set permission
857         request result and distpatch it.
858         (WTR::TestController::handleUserMediaPermissionRequest): Save
859         request and dispatch it.
860         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible):
861         Dispatch cached permission requests.
862         * WebKitTestRunner/TestController.h:
863         * WebKitTestRunner/TestInvocation.cpp:
864         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
865
866 2014-11-11  David Kilzer  <ddkilzer@apple.com>
867
868         webkit-patch --suggest-reviewers is broken with newer versions of git
869         <http://webkit.org/b/138627>
870
871         Reviewed by Michael Saboff with feedback from Daniel Bates.
872
873         * Scripts/webkitpy/common/checkout/scm/git.py:
874         (Git._changes_files_for_commit): Strip blank lines instead of
875         assuming there is always a blank line at the beginning of the
876         list.
877
878 2014-11-11  Alexey Proskuryakov  <ap@apple.com>
879
880         DRT and WKTR touch disk cache
881         https://bugs.webkit.org/show_bug.cgi?id=138622
882
883         Reviewed by Geoffrey Garen.
884
885         * DumpRenderTree/mac/DumpRenderTree.mm: (prepareConsistentTestingEnvironment):
886         Set a shared cache before calling -_switchNetworkLoaderToNewTestingSession, not after,
887         because this function uses the shared cache.
888
889         * WebKitTestRunner/mac/TestControllerMac.mm: (WTR::TestController::platformInitializeContext):
890         Create an empty shared cache to prevent a default one from being created on disk.
891
892 2014-10-07  Sergio Villar Senin  <svillar@igalia.com>
893
894         [CSS Grid Layout] Limit the size of explicit/implicit grid
895         https://bugs.webkit.org/show_bug.cgi?id=136217
896
897         Reviewed by Andreas Kling.
898
899         Added a new unit test for the CSS parser. Right now it only checks
900         that we properly clamp the maximum number of tracks on a grid to a
901         maximum of 1 million.
902
903         * TestWebKitAPI/CMakeLists.txt:
904         * TestWebKitAPI/PlatformEfl.cmake:
905         * TestWebKitAPI/PlatformGTK.cmake:
906         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
907         * TestWebKitAPI/Tests/WebCore/CSSParser.cpp: Added.
908         (TestWebKitAPI::computeNumberOfTracks): Helper function.
909         (TestWebKitAPI::TEST): Added a
910         CSSPropertyParserTest.GridTrackLimits test case.
911
912 2014-11-11  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
913
914         webkitpy test fix after r175867
915         https://bugs.webkit.org/show_bug.cgi?id=138607
916
917         Reviewed by Philippe Normand.
918
919         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
920         (GDBCrashLogGeneratorTest.test_generate_crash_log):
921
922 2014-11-10  Philippe Normand  <pnormand@igalia.com>
923
924         webkitpy: demangle C++ symbols from crash log stderr
925         https://bugs.webkit.org/show_bug.cgi?id=138565
926
927         Reviewed by Alexey Proskuryakov.
928
929         * Scripts/webkitpy/port/linux_get_crash_log.py:
930         (GDBCrashLogGenerator.generate_crash_log): Process stderr output
931         with c++filt.
932
933 2014-11-10  Philippe Normand  <pnormand@igalia.com>
934
935         [GTK] fix up the GDB backtrace report tool
936         https://bugs.webkit.org/show_bug.cgi?id=138564
937
938         Reviewed by Carlos Garcia Campos.
939
940         * Scripts/webkitpy/port/gtk.py:
941         (GtkPort._get_crash_log): Match the process name reported by the
942         driver with the GTK port WebProcess executable filename.
943         * Scripts/webkitpy/port/linux_get_crash_log.py:
944         (GDBCrashLogGenerator._get_gdb_output): Invoke gdb for the crashed
945         program.
946         (GDBCrashLogGenerator.generate_crash_log): Use %E in the core
947         pattern to workaround the 16 characters size limit of %e.
948
949 2014-11-10  Conrad Shultz  <conrad_shultz@apple.com>
950
951         Unreviewed, moved myself to the list of committers.
952
953         * Scripts/webkitpy/common/config/contributors.json:
954
955 2014-11-10  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
956
957         [EFL] Fix the test font path after r175555.
958
959         Reviewed by Csaba Osztrogonác.
960
961         * WebKitTestRunner/PlatformEfl.cmake: Dependencies -> DependenciesEFL
962
963 2014-11-10  Akos Kiss  <akiss@inf.u-szeged.hu>
964
965         Fix the exception fuzz helper to generate targets in the correct range
966         https://bugs.webkit.org/show_bug.cgi?id=138544
967
968         Reviewed by Filip Pizlo.
969
970         Currently, the script generates exception fuzz targets in the range of
971         0..($checkCount-1). However, target 0 is never hit, while target 1 is
972         always outside of the outermost try block of the tests, which therefore
973         prints unexpected output and results in false failures when fired at.
974         Additionally, target $checkCount is never generated.
975
976         This patch fixes the script to generate targets in the range of
977         2..$checkCount.
978
979         * Scripts/jsc-stress-test-helpers/js-exception-fuzz:
980
981 2014-11-09  Csaba Osztrogonác  <ossy@webkit.org>
982
983         make-passwords-json.py should generarate everything needed for testing
984         https://bugs.webkit.org/show_bug.cgi?id=138503
985
986         Reviewed by Ryosuke Niwa.
987
988         * BuildSlaveSupport/build.webkit.org-config/make_passwords_json.py:
989         Renamed from make-passwords-json.py to be able included from mastercfg_unittest.py.
990         Additionally generate auth.json, credentials.cfg and committers.cfg too.
991         (create_mock_slave_passwords_dict): Moved from mastercfg_unittest.py
992         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
993         (BuildBotConfigLoader._mock_open): Use make_passwords_json.create_mock_slave_passwords_dict() to avoid duplication.
994         (BuildBotConfigLoader._create_mock_passwords_dict): Deleted.
995
996 2014-11-09  Carlos Garcia Campos  <cgarcia@igalia.com>
997
998         [GTK] generate-gtkdoc should ignore invalid files
999         https://bugs.webkit.org/show_bug.cgi?id=138542
1000
1001         Reviewed by Darin Adler.
1002
1003         * gtk/generate-gtkdoc:
1004         (files_to_ignore.file_should_be_ignored): Return True to ignore
1005         invalid files.
1006
1007 2014-11-08  Alexey Proskuryakov  <ap@apple.com>
1008
1009         Delete cookies between tests
1010         https://bugs.webkit.org/show_bug.cgi?id=138528
1011
1012         Reviewed by Sam Weinig.
1013
1014         * DumpRenderTree/mac/DumpRenderTree.mm:
1015         (resetWebPreferencesToConsistentValues):
1016         * WebKitTestRunner/TestController.cpp:
1017         (WTR::TestController::resetPreferencesToConsistentValues):
1018         Do it.
1019
1020         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1021         (WTR::InjectedBundle::beginTesting):
1022         Added a FIXME.
1023
1024 2014-11-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1025
1026         [GTK] Run layout tests using the network process
1027         https://bugs.webkit.org/show_bug.cgi?id=138428
1028
1029         Reviewed by Martin Robinson.
1030
1031         Shared secondary process is the default in the GTK+ port, but we
1032         should run the tests using the network process to ensure
1033         everything works with the network process. In the future, the
1034         shared secondary process model might be a special case of multiple
1035         processes with 1 as maximum number of processes, but always using
1036         the network process.
1037
1038         * WebKitTestRunner/TestController.cpp:
1039         (WTR::TestController::initialize):
1040
1041 2014-11-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1042
1043         [GTK] Allow to create a view with a related page in WTR
1044         https://bugs.webkit.org/show_bug.cgi?id=138501
1045
1046         Reviewed by Martin Robinson.
1047
1048         * TestWebKitAPI/gtk/PlatformWebViewGtk.cpp:
1049         (TestWebKitAPI::PlatformWebView::PlatformWebView): Pass nullptr as
1050         related page to WKViewCreate.
1051         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1052         (WTR::PlatformWebView::PlatformWebView): Pass the given related
1053         page to WKViewCreate.
1054
1055 2014-11-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1056
1057         WTR crashes after running a test when NetworkProcess enabled
1058         https://bugs.webkit.org/show_bug.cgi?id=138500
1059
1060         Reviewed by Alexey Proskuryakov.
1061
1062         WebNotificationProvider destructor is calling
1063         WKNotificationManagerSetProvider, but m_notificationManager is
1064         null because removeNotificationManager was already called.
1065
1066         * WebKitTestRunner/WebNotificationProvider.cpp:
1067         (WTR::WebNotificationProvider::~WebNotificationProvider): Check
1068         m_notificationManager is not null before calling WKNotificationManagerSetProvider.
1069
1070 2014-11-06  Jake Nielsen  <jacob_nielsen@apple.com>
1071
1072         Remove duplicate code from PatchAnalysisTask._test_patch and fix bug
1073         regarding incorrect call to PatchAnalysisTask.report_failure
1074         https://bugs.webkit.org/show_bug.cgi?id=138229
1075
1076         Reviewed by Daniel Bates.
1077
1078         * Scripts/webkitpy/common/net/layouttestresults.py:
1079         Makes sure test_results returns a list.
1080         (LayoutTestResults.test_results):
1081         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1082         Makes unit tests also check to make sure
1083         task.results_from_patch_test_run() and
1084         task.results_from_test_run_without_patch return instances of
1085         LayoutTestResults.
1086         (CommitQueueTaskTest._run_and_expect_patch_analysis_result):
1087         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1088         Condenses duplicate code into _should_defer_patch_or_throw, and
1089         removes the now-unused _clean_tree_results member.
1090         (PatchAnalysisTask.__init__):
1091         (PatchAnalysisTask._continue_testing_patch_that_exceeded_failure_limit_on_first_or_second_try):
1092         (PatchAnalysisTask._should_defer_patch_or_throw):
1093         (PatchAnalysisTask._test_patch):
1094         (PatchAnalysisTask.results_from_patch_test_run):
1095         (PatchAnalysisTask.results_from_test_run_without_patch): Deleted.
1096         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1097         Removes needless call to results_from_test_run_without_patch
1098         (AbstractEarlyWarningSystem._failing_tests_message):
1099         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1100         Changes order of test failure messages to be in the order that they
1101         appear.
1102         (AbstractEarlyWarningSystemTest.test_failing_tests_message):
1103         * Scripts/webkitpy/tool/commands/queues.py:
1104         Removes needless call to results_from_test_run_without_patch.
1105         (CommitQueue._failing_tests_message):
1106         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1107         (MockCommitQueueTask.results_from_test_run_without_patch): Deleted.
1108
1109 2014-11-06  Ryuan Choi  <ryuan.choi@navercorp.com>
1110
1111         Unreviewed. Reorder my e-mail addresses in contributors.json
1112
1113         * Scripts/webkitpy/common/config/contributors.json:
1114
1115 2014-11-06  Matthew Hanson  <matthew_hanson@apple.com>
1116
1117         Remove code that prepends a leading 'r' to the first argument of _run_git_svn_find_rev
1118         https://bugs.webkit.org/show_bug.cgi?id=138475
1119
1120         Reviewed by Ryosuke Niwa.
1121
1122         The change in https://trac.webkit.org/175603 introduced broke compatibility with svn_revision_from_git_commit.
1123         This patch reverts the part of that change that broke compatibility. In addition, this patch adds a comment to
1124         explain that SVN revisions require a leading 'r', moves an existing comment to a more appropriate location and
1125         renames the positional argument to better reflect that it can represent either an SVN revision or a Git tree-ish.
1126
1127         * Scripts/webkitpy/common/checkout/scm/git.py:
1128         (Git._run_git_svn_find_rev):
1129         Add comment mentioning that svn_revisions need to begin with 'r'.
1130         Move comment (explaining that git svn find-rev exits with code 0 when no match is found) to a more appropriate location.
1131         Rename the argument 'revision' to 'revision_or_treeish' to reflect the dual form that argument can take.
1132         Remove code that coerced the revision/treeish into a string and prepended an 'r'.
1133
1134 2014-11-06  Carlos Garcia Campos  <cgarcia@igalia.com>
1135
1136         [GTK] Add context menu API to Web Process Extensions
1137         https://bugs.webkit.org/show_bug.cgi?id=138311
1138
1139         Reviewed by Gustavo Noronha Silva.
1140
1141         Add tests cases for WebKitWebPage::context-menu signal.
1142
1143         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
1144         (testContextMenuWebExtensionMenu):
1145         (testContextMenuWebExtensionNode):
1146         (beforeAll):
1147         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1148         (serializeContextMenu):
1149         (serializeNode):
1150         (contextMenuCallback):
1151         (pageCreatedCallback):
1152
1153 2014-11-06  Commit Queue  <commit-queue@webkit.org>
1154
1155         Unreviewed, rolling out r175690.
1156         https://bugs.webkit.org/show_bug.cgi?id=138460
1157
1158         We are not ready to run layout tests using the network process
1159         yet (Requested by KaL on #webkit).
1160
1161         Reverted changeset:
1162
1163         "[GTK] Run layout tests using the network process"
1164         https://bugs.webkit.org/show_bug.cgi?id=138428
1165         http://trac.webkit.org/changeset/175690
1166
1167 2014-11-06  Carlos Garcia Campos  <cgarcia@igalia.com>
1168
1169         [GTK] Run layout tests using the network process
1170         https://bugs.webkit.org/show_bug.cgi?id=138428
1171
1172         Reviewed by Martin Robinson.
1173
1174         Shared secondary process is the default in the GTK+ port, but we
1175         should run the tests using the network process to ensure
1176         everything works with the network process. In the future, the
1177         shared secondary process model might be a special case of multiple
1178         processes with 1 as maximum number of processes, but always using
1179         the network process.
1180
1181         * WebKitTestRunner/TestController.cpp:
1182         (WTR::TestController::initialize):
1183
1184 2014-11-05  Dan Bernstein  <mitz@apple.com>
1185
1186         Remove the unused deletion UI feature
1187         https://bugs.webkit.org/show_bug.cgi?id=138442
1188
1189         Rubber-stamped by Alexey Proskuryakov.
1190
1191         * DumpRenderTree/mac/EditingDelegate.mm:
1192         (-[EditingDelegate webView:shouldShowDeleteInterfaceForElement:]): Deleted implementation of
1193         delegate method that’s been removed.
1194
1195 2014-11-05  Alexey Proskuryakov  <ap@apple.com>
1196
1197         fast/dom/remove-body-during-body-replacement2.html fails on WK2
1198         https://bugs.webkit.org/show_bug.cgi?id=138334
1199
1200         Reviewed by Anders Carlsson.
1201
1202         Reset focus to main frame between tests. DumpRenderTree does this via -makeFirstResponder
1203         calls, which works because each frame is an NSView in WK1. WK2 makes equivalent
1204         -makeFirstResponder calls, which may or may not be needed for other reasons, but
1205         it also needs to reset internal focus explicitly.
1206
1207         It's not clear if this is the right long-term fix or a workaround for a WebKit bug.
1208         WebKit behavior appears wrong, but it matches Firefox.
1209
1210         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1211         (WTR::InjectedBundlePage::resetAfterTest):
1212
1213 2014-11-05  Carlos Garcia Campos  <cgarcia@igalia.com>
1214
1215         [GTK] Add WebKitWebResource::failed-with-tls-errors signal
1216         https://bugs.webkit.org/show_bug.cgi?id=137862
1217
1218         Reviewed by Gustavo Noronha Silva.
1219
1220         Add a test case to check that WebKitWebResource::failed-with-tls-errors
1221         is emitted when a subresource load fails due to TLS errors.
1222
1223         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
1224         (TLSSubresourceTest::resourceLoadStartedCallback):
1225         (TLSSubresourceTest::TLSSubresourceTest):
1226         (TLSSubresourceTest::subresourceFailedCallback):
1227         (TLSSubresourceTest::subresourceFailedWithTLSErrorsCallback):
1228         (TLSSubresourceTest::subresourceLoadStarted):
1229         (TLSSubresourceTest::subresourceFailedWithTLSErrors):
1230         (TLSSubresourceTest::waitUntilSubresourceLoadFail):
1231         (testSubresourceLoadFailedWithTLSErrors):
1232         (httpsServerCallback):
1233         (httpServerCallback):
1234         (beforeAll):
1235
1236 2014-11-05  Alexey Proskuryakov  <ap@apple.com>
1237
1238         Build fix for some compiler versions.
1239
1240         * TestWebKitAPI/Tests/mac/TypingStyleCrash.mm: (TestWebKitAPI::TEST): Compiler was
1241         unhappy because this is a getter, and these shouldn't have side effects.
1242
1243 2014-11-04  Matthew Hanson  <matthew_hanson@apple.com>
1244
1245         Add a method for performing cherrypick-merges.
1246         https://bugs.webkit.org/show_bug.cgi?id=138375
1247
1248         Reviewed by Ryosuke Niwa.
1249
1250         Adds support for cherrypick-merges.
1251
1252         * Scripts/webkitpy/common/checkout/scm/git.py:
1253         (Git.cherrypick_merge): Added.
1254
1255 2014-11-04  Matthew Hanson  <matthew_hanson@apple.com>
1256
1257         Add a way to ascertain the SVN URL associated with a Git branch.
1258         https://bugs.webkit.org/show_bug.cgi?id=138374
1259
1260         Reviewed by Ryosuke Niwa.
1261
1262         The svn_url method returns the SVN URL associated with the current Git branch.
1263
1264         * Scripts/webkitpy/common/checkout/scm/git.py:
1265         (Git.svn_url): Added.
1266
1267 2014-11-04  Matthew Hanson  <matthew_hanson@apple.com>
1268
1269         Add the ability to search for modifications that are staged for commit.
1270         https://bugs.webkit.org/show_bug.cgi?id=138373
1271
1272         Reviewed by Ryosuke Niwa and Daniel Bates.
1273
1274         This makes is easy to do identify files that require merge post-processing,
1275         in addition to stand-alone utility.
1276
1277         * Scripts/webkitpy/common/checkout/scm/git.py:
1278         (Git.modifications_staged_for_commit): Added.
1279
1280 2014-11-04  Matthew Hanson  <matthew_hanson@apple.com>
1281
1282         Add a branch keyword argument to _run_git_svn_find_rev.
1283         https://bugs.webkit.org/show_bug.cgi?id=138372
1284
1285         Reviewed by Ryosuke Niwa.
1286
1287         The addition of this keyword argument allows clients to determine the Git hash
1288         of commits made on an SVN branch, provided that branch has been fetched locally.
1289
1290         * Scripts/webkitpy/common/checkout/scm/git.py:
1291         (Git._run_git_svn_find_rev):
1292         Add a branch keyword argument that is added to the end of the command, if present.
1293
1294 2014-11-04  Chris Dumez  <cdumez@apple.com>
1295
1296         Add ptr() method to Ref class
1297         https://bugs.webkit.org/show_bug.cgi?id=138361
1298
1299         Reviewed by Darin Adler.
1300
1301         Use the new Ref::ptr() method.
1302
1303         * TestWebKitAPI/Tests/WTF/Ref.cpp:
1304         (TestWebKitAPI::TEST):
1305
1306 2014-11-04  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
1307
1308         [jhbuild] Make it possible to build GTK/EFL in same repository
1309         https://bugs.webkit.org/show_bug.cgi?id=137448
1310
1311         Reviewed by Martin Robinson.
1312
1313         * Scripts/webkitdirs.pm:
1314         (getJhbuildPath):
1315         * WebKitTestRunner/InjectedBundle/efl/FontManagement.cpp:
1316         (getPlatformFontsPath):
1317         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1318         (WTR::getFontsPath):
1319         * jhbuild/jhbuild-wrapper:
1320         (determine_platform):
1321         (install_jhbuild):
1322         * jhbuild/jhbuildrc_common.py:
1323         (init):
1324
1325 2014-11-04  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
1326
1327         [EFL] Bump LLVM to version 3.5.0
1328         https://bugs.webkit.org/show_bug.cgi?id=138312
1329
1330         Reviewed by Csaba Osztrogonác.
1331
1332         * efl/jhbuild.modules:
1333         * efl/patches/llvm-elf-add-stackmaps.patch: Added.
1334         * efl/patches/llvm-elf-fix-x86_64-fdecfiencoding.patch: Added.
1335
1336 2014-11-03  Simon Fraser  <simon.fraser@apple.com>
1337
1338         Add page overlays that show regions with mouseWheel event handlers, and the non-fast-scrollable region, and code to toggle them in MiniBrowser WK2
1339         https://bugs.webkit.org/show_bug.cgi?id=138257
1340
1341         Reviewed by Tim Horton.
1342         
1343         Add a "Debug Overlays" submenu item under "WebKit2-only Settings" which allows
1344         the user to toggle region page overlays on and off. Two overlays are available,
1345         for the non-fast scrollable region, and the region of element with wheel
1346         event handlers.
1347
1348         * MiniBrowser/mac/SettingsController.h:
1349         * MiniBrowser/mac/SettingsController.m:
1350         (-[SettingsController _populateMenu]):
1351         (-[SettingsController validateMenuItem:]):
1352         (-[SettingsController nonFastScrollableRegionOverlayVisible]):
1353         (-[SettingsController wheelEventHandlerRegionOverlayVisible]):
1354         (-[SettingsController preferenceKeyForRegionOverlayTag:]):
1355         (-[SettingsController toggleDebugOverlay:]):
1356         (-[SettingsController debugOverlayVisible:]):
1357         * MiniBrowser/mac/WK2BrowserWindowController.m:
1358         (-[WK2BrowserWindowController didChangeSettings]):
1359
1360 2014-11-03  Alexey Proskuryakov  <ap@apple.com>
1361
1362         REGRESSION (Subpixel layout): Bubbles don't fit in Bugzilla review page
1363         https://bugs.webkit.org/show_bug.cgi?id=138323
1364
1365         Reviewed by Zalan Bujtas.
1366
1367         * QueueStatusServer/templates/statusbubble.html: Round the sizes up, not down.
1368
1369 2014-11-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1370
1371         [ninja] Don't remove response files for verbose builds
1372         https://bugs.webkit.org/show_bug.cgi?id=137816
1373
1374         Reviewed by Csaba Osztrogonác.
1375
1376         * Scripts/webkitdirs.pm:
1377         (determineNinjaVersion):
1378         (buildCMakeGeneratedProject):
1379
1380 2014-11-02  Akos Kiss  <akiss@inf.u-szeged.hu>
1381
1382         [GTK] Fix the build of FTL JIT
1383         https://bugs.webkit.org/show_bug.cgi?id=138298
1384
1385         Reviewed by Carlos Garcia Campos.
1386
1387         * gtk/jhbuild-optional.modules:
1388         Bump up LLVM version to 3.5.0 release and apply patches.
1389         * gtk/patches/llvm-elf-add-stackmaps.patch:
1390         Added. Adds .llvm_stackmaps section to ELF files. Backported from LLVM
1391         trunk.
1392         * gtk/patches/llvm-elf-fix-x86_64-fdecfiencoding.patch:
1393         Added. Ensures that PC-relative relocations in EH frames are not
1394         truncated to 32 bits on x86_64.
1395
1396 2014-10-31  Michael Saboff  <msaboff@apple.com>
1397
1398         No way to specify target os or architecture when using the --no-copy option with run-jsc-stress-tests
1399         https://bugs.webkit.org/show_bug.cgi?id=138268
1400
1401         Reviewed by Andreas Kling.
1402
1403         Added a --arch and --os option to set or override the values that are
1404         normally computed based on examining the JavaScriptCore we want to test.
1405
1406         * Scripts/run-jsc-stress-tests:
1407
1408 2014-10-31  Dan Bernstein  <mitz@apple.com>
1409
1410         llvmForJSC build emits a linker warning that it can't find usr/local/LLVMForJavaScriptCore/lib under the build directory
1411         https://bugs.webkit.org/show_bug.cgi?id=138259
1412
1413         Reviewed by Geoff Garen.
1414
1415         * Scripts/copy-webkitlibraries-to-product-directory: Create this directory even if it’s
1416         going to be empty to silence the warning.
1417
1418 2014-10-31  Adrian Perez de Castro  <aperez@igalia.com>
1419
1420         [GTK] Support script message handlers WebKitUserContentManager
1421         https://bugs.webkit.org/show_bug.cgi?id=133730
1422
1423         Reviewed by Carlos Garcia Campos.
1424
1425         Support user script message handlers in WebKitUserContentManager.
1426         This needs building with ENABLE_USER_MESSAGE_HANDLERS, for which
1427         an option is added to the CMake build files. The option is disabled
1428         globally by default, and the WebKitGTK port enables it. On the API
1429         level, two new methods to register and unregister names are provided
1430         in the "window.webkit" namespace, and on message reception the
1431         "WebKitUserContentManager::script-message-received" signal is
1432         emitted, using the registered names as signal detail.
1433
1434         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
1435         Add test case for user script message handlers.
1436         (scriptMessageReceived):
1437         (testUserContentManagerScriptMessageReceived):
1438         (beforeAll):
1439
1440 2014-10-30  Matthew Hanson  <matthew_hanson@apple.com>
1441
1442         bisect-builds should support WebKit clients other than Safari
1443         https://bugs.webkit.org/show_bug.cgi?id=138225
1444
1445         This patch adds support for bisecting WebKit nightly builds with clients other than Safari.
1446
1447         The -a / --application optional argument allows the user to specify which application (or application bundle)
1448         should be run against the WebKit nightly builds.
1449
1450         Reviewed by David Kilzer.
1451
1452         * Scripts/bisect-builds:
1453         Swap out $safariPath for the more general $applicationPath
1454         Leave --safari-path as a commandline option for backwards compatibility
1455         (mountAndRunNightly):
1456         Use File::Spec->cat correctly (one directory per argument)
1457         Use open --wait-apps instead of running the target application directly
1458
1459 2014-10-30  Dana Burkart  <dburkart@apple.com>
1460
1461         <rdar://problem/18821260> Perpare for the mysterious future
1462
1463         Reviewed by Lucas Forschler.
1464
1465         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1466         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1467         * LayoutTestRelay/Configurations/Base.xcconfig:
1468         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
1469         * MiniBrowser/Configurations/Base.xcconfig:
1470         * MiniBrowser/Configurations/DebugRelease.xcconfig:
1471         * TestWebKitAPI/Configurations/Base.xcconfig:
1472         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
1473         * WebKitLauncher/Configurations/Base.xcconfig:
1474         * WebKitTestRunner/Configurations/Base.xcconfig:
1475         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1476
1477 2014-10-30  Matthew Hanson  <matthew_hanson@apple.com>
1478
1479         Update safariVersion to safariVersionString
1480         https://bugs.webkit.org/show_bug.cgi?id=138193
1481
1482         The preceding change updated safariVersion to safariVersionString for the "4 Public Beta" check in OS X 10.5.x,
1483         but it should have also been done for the "4 Public Beta" check in OS X 10.4.x.
1484
1485         Rubber-stamped by David Kilzer.
1486
1487         * Scripts/bisect-builds:
1488         (makeNightlyList):
1489         Compare safariVersionString to a string literal, instead of safariVersion.
1490
1491 2014-10-30  Rohit Kumar  <kumar.rohit@samsung.com>
1492
1493         [GTK] Minibrowser : Add window fullscreen support for Minibrowser
1494         https://bugs.webkit.org/show_bug.cgi?id=137775
1495
1496         Reviewed by Carlos Garcia Campos.
1497
1498         * MiniBrowser/gtk/BrowserWindow.c:
1499         (toggleFullScreen): Callback to toggle window fullscreen on pressing F11 key.
1500         (browser_window_init):
1501
1502 2014-10-29  Jake Nielsen  <jacob_nielsen@apple.com>
1503
1504         CommitQueue and EWS should reject any patches that result in consistent test
1505         failures that aren't present on the tree.
1506         https://bugs.webkit.org/show_bug.cgi?id=138184
1507
1508         Reviewed by Alexey Proskuryakov.
1509
1510         * Scripts/webkitpy/layout_tests/models/test_results.py:
1511         Adds a simple hashing function to allow for set operations to handle
1512         TestResult objects properly.
1513         (TestResult.__hash__):
1514         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1515         Adds one unit test, and modifies others to agree with the notion that
1516         patches that introduce new test failures (but also have flakyness)
1517         should be rejected rather than spin.
1518         (MockCommitQueue.report_flaky_tests):
1519         (CommitQueueTaskTest._run_and_expect_patch_analysis_result):
1520         (test_double_flaky_test_failure):
1521         (test_two_flaky_tests):
1522         (test_very_flaky_patch):
1523         (test_very_flaky_patch_with_some_tree_redness):
1524         (test_different_test_failures):
1525         (test_different_test_failures_with_some_tree_redness):
1526         (test_different_test_failures_with_some_tree_redness_and_some_fixes):
1527         (test_mildly_flaky_patch):
1528         (test_mildly_flaky_patch_with_some_tree_redness):
1529         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1530         Makes PatchAnalysisTask reject said patches.
1531         (PatchAnalysisTask._test_patch):
1532
1533 2014-10-29  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1534
1535         WinCairoRequirements.zip cannot be downloaded from dropbox
1536         https://bugs.webkit.org/show_bug.cgi?id=138113
1537
1538         Reviewed by Alexey Proskuryakov.
1539
1540         * Scripts/update-webkit-dependency: Removing --sslv3 option from curl
1541
1542 2014-10-29  Matthew Hanson  <matthew_hanson@apple.com>
1543
1544         bisect-builds should filter out nightlies that predate the introduction of an OS X operating system
1545         https://bugs.webkit.org/show_bug.cgi?id=138193
1546
1547         This patch restricts the set of nightles to bisect to only those nightlies that ship with frameworks
1548         for the target OS (only support for OS X Yosemite, Mavericks and Mountain Lion was added.)
1549
1550         It also does a bit of refactoring, including distinguishing between versions and version strings and
1551         saving versions to local variables instead of using eval in each conditional.
1552
1553         Reviewed by David Kilzer.
1554
1555         * Scripts/bisect-builds:
1556         (makeNightlyList):
1557         Restrict the set of nightlies to r174650 and above when running Yosemite.
1558         Restrict the set of nightlies to r157846 and above when running Mavericks.
1559         Restrict the set of nightlies to r122421 and above when running Mountain Lion.
1560
1561 2014-10-29  Csaba Osztrogonác  <ossy@webkit.org>
1562
1563         [EFL] build-webkit should try harder to avoid re-running cmake
1564         https://bugs.webkit.org/show_bug.cgi?id=137949
1565
1566         Reviewed by Martin Robinson.
1567
1568         * Scripts/webkitdirs.pm:
1569         (shouldRemoveCMakeCache): Don't remove CMakeCache unconditionally for EFL.
1570         (generateBuildSystemFromCMakeProject): Comment fix after r174681.
1571
1572 2014-10-28  Daniel Bates  <dabates@apple.com>
1573
1574         Unify logic in RunTests.run() to run the Python unit tests
1575         https://bugs.webkit.org/show_bug.cgi?id=138160
1576
1577         Reviewed by Martin Robinson.
1578
1579         Unify the interactive and non-interactive code path for running the Python unit tests
1580         in step RunTests so as to remove duplicate code to compute the the path to the script
1581         test-webkitpy and log an informative message ("Running Python unit tests") to the console.
1582
1583         No new tests since no functionality was changed.
1584
1585         * Scripts/webkitpy/port/base.py:
1586         (Port.python_unittest_results_directory):
1587         * Scripts/webkitpy/tool/steps/runtests.py:
1588         (RunTests.run):
1589
1590 2014-10-28  Jake Nielsen  <jacob_nielsen@apple.com>
1591
1592         Make runtest.py call test-webkitpy with the --json flag when in
1593         non-interactive mode.
1594         https://bugs.webkit.org/show_bug.cgi?id=137667
1595
1596         Reviewed by Daniel Bates.
1597
1598         * Scripts/webkitpy/port/base.py:
1599         Adds the python_unittest_results_directory method.
1600         (Port.python_unittest_results_directory):
1601         * Scripts/webkitpy/tool/steps/runtests.py:
1602         Changes RunTests to call test-webkitpy with the --json flag if the
1603         --non-interactive flag is set.
1604         (RunTests):
1605         (RunTests.run):
1606
1607 2014-10-28  Rebecca Hauck  <rhauck@adobe.com>
1608
1609         import-w3c-tests should use re.escape() wherever it's handling file paths
1610         https://bugs.webkit.org/show_bug.cgi?id=137934
1611
1612         This patch adds re.escape() to a few places where we're doing string
1613         conversions. This prevents errors when attribute values coincidentally
1614         have character sequences that can be interpreted as regular expressions.
1615
1616         Reviewed by Bem Jones-Bey.
1617
1618         * Scripts/webkitpy/w3c/test_converter.py:
1619         (_W3CTestConverter.convert_attributes_if_needed):
1620
1621 2014-10-28  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
1622
1623         [EFL] Remove an unused include from Tools/WebKitTestRunner/efl/PlatformWebViewEfl.cpp
1624         https://bugs.webkit.org/show_bug.cgi?id=138130
1625
1626         Reviewed by Csaba Osztrogonác.
1627
1628         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1629
1630 2014-10-25  Raniere Silva  <raniere@ime.unicamp.br>
1631
1632         Fix link to Arch Linux Wiki
1633         https://bugs.webkit.org/show_bug.cgi?id=138010
1634
1635         Reviewed by Benjamin Poulain.
1636
1637         * gtk/install-dependencies:
1638
1639 2014-10-25  Alexey Proskuryakov  <ap@apple.com>
1640
1641         Test regressions are not detected when image result is missing
1642         https://bugs.webkit.org/show_bug.cgi?id=138070
1643
1644         Reviewed by Simon Fraser.
1645
1646         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1647         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
1648         Count these as regressions, not as flaky tests.
1649
1650         * Scripts/webkitpy/port/test.py:
1651         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1652         Test it.
1653
1654 2014-10-24  Timothy Horton  <timothy_horton@apple.com>
1655
1656         Add Conrad Shultz to the contributors list.
1657
1658         * Scripts/webkitpy/common/config/contributors.json:
1659
1660 2014-10-24  Dan Bernstein  <mitz@apple.com>
1661
1662         build.webkit.org/dashboard immediately retries a request to buildbot when the response is 404
1663         https://bugs.webkit.org/show_bug.cgi?id=138046
1664
1665         Reviewed by Alexey Proskuryakov.
1666
1667         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1668         (BuildbotQueue.prototype._load): Only consider retrying immediately if the error code was
1669         401. Otherwise, we’ll retry normally in 45 seconds.
1670
1671 2014-10-24  Marcos Chavarría Teijeiro  <chavarria1991@gmail.com>
1672
1673         [GTK] Implement is_selected method on WebKitHitTestResult
1674         https://bugs.webkit.org/show_bug.cgi?id=137110
1675
1676         Reviewed by Tim Horton.
1677
1678         Add tests for new context SELECTION on WebKitHitTestResult.
1679
1680         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
1681         (testContextMenuDefaultMenu):
1682         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
1683         (testWebViewMouseTarget):
1684
1685 2014-10-23  Roger Fong  <roger_fong@apple.com>
1686
1687         [Win] Skip failing JSC tests following r175078
1688         https://bugs.webkit.org/show_bug.cgi?id=130967.
1689
1690         * Scripts/run-javascriptcore-tests:
1691
1692 2014-10-22  Jake Nielsen  <jacob_nielsen@apple.com>
1693
1694         commitqueuetask_unittest.py should be made more concise.
1695         https://bugs.webkit.org/show_bug.cgi?id=137985
1696
1697         Reviewed by Alexey Proskuryakov.
1698
1699         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1700         Refactors tests to use MockSimpleTestPlanCommitQueue where possible.
1701         (MockCommitQueue.__init__):
1702         (MockCommitQueue.report_flaky_tests):
1703         (MockCommitQueue):
1704         (MockCommitQueue.get_reported_flaky_tests):
1705         (MockSimpleTestPlanCommitQueue.__init__):
1706         (MockSimpleTestPlanCommitQueue.run_command):
1707         (MockSimpleTestPlanCommitQueue.did_run_clean_tests):
1708         (CommitQueueTaskTest._run_and_expect_patch_analysis_result):
1709         (test_land_failure):
1710         (test_failed_archive):
1711         (test_double_flaky_test_failure):
1712         (test_test_failure):
1713         (test_red_test_failure):
1714         (test_very_red_tree_retry):
1715         (test_red_tree_patch_rejection):
1716         (test_one_flaky_test):
1717         (test_tree_more_red_than_patch):
1718         (MockCommitQueue.test_results): Deleted.
1719         (test_simple_flaky_test_failure): Deleted.
1720         (_expect_validate): Deleted.
1721         (_expect_validate.MockDelegate): Deleted.
1722         (_expect_validate.MockDelegate.refetch_patch): Deleted.
1723         (_expect_validate.MockDelegate.expected_failures): Deleted.
1724         (_mock_patch): Deleted.
1725         (test_validate): Deleted.
1726         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1727         Fixes a bug that slipped through the cracks prior to this change.
1728         (PatchAnalysisTask._test_patch):
1729
1730 2014-10-22  Alexey Proskuryakov  <ap@apple.com>
1731
1732         Flakiness dashboard should support OS X Yosemite
1733         https://bugs.webkit.org/show_bug.cgi?id=137986
1734
1735         Reviewed by Ryosuke Niwa.
1736
1737         * TestResultServer/app.yaml:
1738         * TestResultServer/static-dashboards/builders.jsonp:
1739         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1740
1741 2014-10-22  Jake Nielsen  <jacob_nielsen@apple.com>
1742
1743         commitqueuetask should include more tests to ensure that the behavior
1744         of PatchAnalysisTask._test_patch() is well defined
1745         https://bugs.webkit.org/show_bug.cgi?id=137977
1746
1747         Reviewed by Alexey Proskuryakov.
1748
1749         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1750         Adds the MockSimpleTestPlanCommitQueue class, which makes it easier
1751         and more readable to define tests that are meant to test the behaviour
1752         of PatchAnalysisTask._test_patch(), and adds several unit tests.
1753         (FailingTestCommitQueue.test_results):
1754         (PatchAnalysisResult):
1755         (MockSimpleTestPlanCommitQueue):
1756         (MockSimpleTestPlanCommitQueue.__init__):
1757         (MockSimpleTestPlanCommitQueue.run_command):
1758         (MockSimpleTestPlanCommitQueue._mock_test_result):
1759         (MockSimpleTestPlanCommitQueue.test_results):
1760         (CommitQueueTaskTest._run_and_expect_patch_analysis_result):
1761         (test_flaky_test_failure):
1762         (test_failed_archive):
1763         (test_two_flaky_tests):
1764         (test_one_flaky_test):
1765         (test_very_flaky_patch):
1766         (test_very_flaky_patch_with_some_tree_redness):
1767         (test_different_test_failures):
1768         (test_different_test_failures_with_some_tree_redness):
1769         (test_mildly_flaky_patch):
1770         (test_mildly_flaky_patch_with_some_tree_redness):
1771         (test_tree_more_red_than_patch):
1772
1773 2014-10-22  Jake Nielsen  <jacob_nielsen@apple.com>
1774
1775         PatchAnalysisTask._test_patch() needs refactoring
1776         https://bugs.webkit.org/show_bug.cgi?id=137904
1777
1778         Reviewed by Alexey Proskuryakov.
1779
1780         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1781         Fixes several small bugs, and makes minor changes to accomodate the
1782         changes in PatchAnalysisTask.
1783         (MockCommitQueue.refetch_patch):
1784         (MockCommitQueue.test_results):
1785         (test_flaky_test_failure):
1786         (test_failed_archive):
1787         (test_very_red_tree_retry):
1788         (_expect_validate.MockDelegate.refetch_patch):
1789         (MockCommitQueue.expected_failures): Deleted.
1790         (_expect_validate.MockDelegate.expected_failures): Deleted.
1791         * Scripts/webkitpy/tool/bot/expectedfailures.py: Removed.
1792         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py: Removed.
1793         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1794         Removes the unexpected_failures member, adds the _clean_tree_results
1795         member, adds a helper function for _test_patch, and refactors
1796         _test_patch to be more readable.
1797         (PatchAnalysisTask.__init__):
1798         (PatchAnalysisTask._continue_testing_patch_that_exceeded_failure_limit_on_first_or_second_try):
1799         (PatchAnalysisTask._test_patch):
1800         (PatchAnalysisTask.results_from_test_run_without_patch):
1801         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1802         Removes AbstractEarlyWarningSystem's dependancy on ExpectedFailures. 
1803         (AbstractEarlyWarningSystem.begin_work_queue):
1804         (AbstractEarlyWarningSystem._failing_tests_message):
1805         (AbstractEarlyWarningSystem.command_failed):
1806         (AbstractEarlyWarningSystem.expected_failures): Deleted.
1807         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1808         Makes changes to accomodate the changes made to PatchAnalysisTask.
1809         (AbstractEarlyWarningSystemTest.test_failing_tests_message):
1810         * Scripts/webkitpy/tool/commands/perfalizer.py:
1811         Removes Perfalizer's dependancy on ExpectedFailures. 
1812         (PerfalizerTask.refetch_patch):
1813         (PerfalizerTask.expected_failures): Deleted.
1814         * Scripts/webkitpy/tool/commands/queues.py:
1815         Removes CommitQueue's dependancy on ExpectedFailures, and adds an
1816         initializer to allow for mock injection.
1817         (CommitQueue.__init__):
1818         (CommitQueue.begin_work_queue):
1819         (CommitQueue.process_work_item):
1820         (CommitQueue._failing_tests_message):
1821         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1822         Removes dependancy on ExpectedFailures, and instead uses mock
1823         injection.
1824         (MockCommitQueueTask):
1825         (MockCommitQueueTask.results_from_patch_test_run):
1826         (MockCommitQueueTask.results_from_test_run_without_patch):
1827         (mock_run_webkit_patch):
1828
1829 2014-10-22  Rohit Kumar  <kumar.rohit@samsung.com>
1830
1831         [EFL][WK2] Minibrowser : Add support for mouse middle button to open links in new window
1832         https://bugs.webkit.org/show_bug.cgi?id=136736
1833
1834         Reviewed by Gyuyoung Kim.
1835
1836         * MiniBrowser/efl/main.c:
1837         (on_navigation_policy_decision): Check whether it's a link clicked with the middle mouse button and load the request in a new window.
1838         (window_create):
1839
1840 2014-10-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1841
1842         [GTK] Move GtkInputMethodFilter from Platform to WebKit2
1843         https://bugs.webkit.org/show_bug.cgi?id=137884
1844
1845         Reviewed by Gustavo Noronha Silva.
1846
1847         Move InputMethodFilter test from WebCore tests to WebKit2 tests
1848         and adapt it to use the new InputMethodFilter WebKit class. Instead
1849         of having virtual methods just for testing, it has a testing mode
1850         that logs the events.
1851
1852         * TestWebKitAPI/PlatformGTK.cmake:
1853         * TestWebKitAPI/Tests/WebKit2/gtk/InputMethodFilter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/gtk/InputMethodFilter.cpp.
1854         (TestWebKitAPI::TestInputMethodFilter::TestInputMethodFilter):
1855         (TestWebKitAPI::TestInputMethodFilter::~TestInputMethodFilter):
1856         (TestWebKitAPI::TestInputMethodFilter::sendKeyEventToFilter):
1857         (TestWebKitAPI::TestInputMethodFilter::sendPressAndReleaseKeyEventPairToFilter):
1858         (TestWebKitAPI::TEST):
1859         (TestWebKitAPI::temporaryGetPreeditStringOverride):
1860         (TestWebKitAPI::temporaryResetOverride):
1861         (TestWebKitAPI::verifyCanceledComposition):
1862
1863 2014-10-21  Alexey Proskuryakov  <ap@apple.com>
1864
1865         build.webkit.org/dashboard: Cannot click on green tester bubbles
1866         https://bugs.webkit.org/show_bug.cgi?id=137909
1867
1868         Reviewed by Darin Adler.
1869
1870         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1871         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
1872
1873 2014-10-21  Brent Fulgham  <bfulgham@apple.com>
1874
1875         [Win] Run DumpRenderTree using native controls, not SafariTheme.dll.
1876         https://bugs.webkit.org/show_bug.cgi?id=137932
1877
1878         Reviewed by Simon Fraser.
1879
1880         This is the first step in moving over to native Windows rendering for our layout tests.
1881         Once this change lands, approximately 300 tests will start failing on Windows. I will
1882         rebaseline these changes against our test hardware and update this bug with the
1883         commits related to that work.
1884
1885         * DumpRenderTree/win/DumpRenderTree.cpp:
1886         (resetDefaultsToConsistentValues): Call 'setShouldPaintNativeControls(TRUE)' so that
1887         we use native Windows drawing style.
1888
1889 2014-10-21  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
1890
1891         Fix FTL Native Inlining for EFL
1892         https://bugs.webkit.org/show_bug.cgi?id=137774
1893
1894         Reviewed by Michael Saboff.
1895
1896         Added Clang as an optional module to jhbuild.
1897
1898         * efl/jhbuild.modules:
1899
1900 2014-10-20  Michael Catanzaro  <mcatanzaro@igalia.com>
1901
1902         Change the default TLS errors policy to WEBKIT_TLS_ERRORS_POLICY_FAIL
1903         https://bugs.webkit.org/show_bug.cgi?id=137832
1904
1905         Reviewed by Carlos Garcia Campos.
1906
1907         Ensure each test sets the TLS errors policy that it really needs.
1908         Have each test except testTLSErrorsPolicy stash and restore the original
1909         TLS errors policy. Update testTLSErrorsPolicy to account for the new
1910         default policy.
1911
1912         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
1913         (testSSL):
1914         (testInsecureContent):
1915         (testTLSErrorsPolicy):
1916         (testTLSErrorsRedirect):
1917         (testTLSErrorsHTTPAuth):
1918         (testLoadFailedWithTLSErrors):
1919         (beforeAll):
1920
1921 2014-10-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1922
1923         Unreviewed. Unskip inspector server unit tests.
1924
1925         They should pass now.
1926
1927         * Scripts/run-gtk-tests:
1928         (TestRunner):
1929
1930 2014-10-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1931
1932         [GTK] Test TestWebKitAPI/WebKit2Gtk/TestInspectorServer fails
1933         https://bugs.webkit.org/show_bug.cgi?id=132044
1934
1935         Reviewed by Brian Burg.
1936
1937         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
1938         (openRemoteDebuggingSession): Remove trailing slash when
1939         concatenating base inspector URL with the page, because the
1940         inspector returns the relative paths with a leading slash.
1941
1942 2014-10-20  Tanay C  <tanay.c@samsung.com>
1943
1944         [EFL][WK2] Minibrowser : Add support for Case sensitive and word start search
1945         https://bugs.webkit.org/show_bug.cgi?id=137023
1946
1947         Reviewed by Gyuyoung Kim.
1948
1949         * MiniBrowser/efl/main.c: Added functionality to support case sensitive and word start search
1950         (search_box_show): Modified.
1951         (search_box_hide): Modified.
1952         (on_search_field_activated): Modified.
1953         (on_search_backward_button_clicked): Modified.
1954         (on_search_forward_button_clicked): Modified.
1955         (on_search_case_option_changed): Added.
1956         (on_search_word_start_option_changed): Added.
1957         (window_create): Modified.
1958
1959 2014-10-20  Tanay C  <tanay.c@samsung.com>
1960
1961         [GTK][Minibrowser] Escape key does not hide the search box
1962         https://bugs.webkit.org/show_bug.cgi?id=137734
1963
1964         Reviewed by Philippe Normand.
1965
1966         * MiniBrowser/gtk/BrowserWindow.c: Added the check to handle search box hide
1967         (stopPageLoad): Modified.
1968
1969 2014-10-18  Antti Koivisto  <antti@apple.com>
1970
1971         REGRESSION (r173356): Safari can't install a profile, gets 'Download Failed error
1972         https://bugs.webkit.org/show_bug.cgi?id=137855
1973
1974         Reviewed by Dan Bernstein.
1975
1976         Test and warn if the dumped response mime type differs from the platform response mime type.
1977
1978         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1979         (WTR::InjectedBundlePage::didReceiveResponseForResource):
1980         (WTR::InjectedBundlePage::platformResponseMimeType):
1981         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1982         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
1983         (WTR::InjectedBundlePage::platformResponseMimeType):
1984
1985 2014-10-17  Joseph Pecoraro  <pecoraro@apple.com>
1986
1987         Remove run-inspector-perf-tests.py there is no PerformanceTests/inspector anymore
1988         https://bugs.webkit.org/show_bug.cgi?id=137835
1989
1990         Reviewed by Andreas Kling.
1991
1992         * Scripts/run-inspector-perf-tests.py: Removed.
1993         This script is stale, as PerformanceTests/inspector no longer exists.
1994
1995 2014-10-17  Simon Fraser  <simon.fraser@apple.com>
1996
1997         Fix typo: should be ios-simulator-wk2, not ios-simulator_wk2.
1998
1999         * Scripts/webkitpy/port/ios.py:
2000         (IOSSimulatorPort.default_baseline_search_path):
2001
2002 2014-10-17  Simon Fraser  <simon.fraser@apple.com>
2003
2004         [iOS] Simplify test fallback paths for iOS Simulator testing
2005         https://bugs.webkit.org/show_bug.cgi?id=137830
2006
2007         Reviewed by Zalan Bujtas.
2008         
2009         Make the fallback paths be:
2010             ios-simulator -> generic
2011             ios-simulator-wk2->ios-simulator -> generic
2012         
2013         so don't include mac in the fallback path. Also remove the
2014         version handling for simplicity.
2015
2016         * Scripts/webkitpy/port/ios.py:
2017         (IOSSimulatorPort):
2018         (IOSSimulatorPort.default_baseline_search_path):
2019
2020 2014-10-17  Dana Burkart  <dburkart@apple.com>
2021
2022         Fix typos in the dashboard config file.
2023
2024         Unreviewed.
2025
2026         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2027         (WebKitBuildbot):
2028
2029 2014-10-17  Brent Fulgham  <bfulgham@apple.com>
2030
2031         [Win] Allow WinLauncher to specify Custom User Agent strings
2032         https://bugs.webkit.org/show_bug.cgi?id=137828
2033
2034         Reviewed by Dean Jackson.
2035
2036         * WinLauncher/Common.cpp: Add support for custom user agent strings.
2037         * WinLauncher/WinLauncher.cpp: Add some convenience methods to get
2038         and set the user agent strings.
2039         * WinLauncher/WinLauncher.h:
2040         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Add new menu
2041         resources and dialog for setting custom User Agent strings.
2042         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h:
2043
2044 2014-10-16  Simon Fraser  <simon.fraser@apple.com>
2045
2046         [iOS] Turn off font autosizing for iOS WebKitTestRunner
2047         https://bugs.webkit.org/show_bug.cgi?id=137806
2048
2049         Reviewed by Sam Weinig.
2050
2051         Confusingly, WKPreferencesSetTextAutosizingEnabled() does nothing on iOS.
2052         Instead, we have to add WKPreferencesSetMinimumZoomFontSize() and set it to 0
2053         to disable font autosizing.
2054         
2055         Add platformResetPreferencesToConsistentValues() and implement it in the iOS
2056         test controller to set platform-specific prefs.
2057
2058         * WebKitTestRunner/TestController.cpp:
2059         (WTR::TestController::resetPreferencesToConsistentValues):
2060         (WTR::TestController::platformResetPreferencesToConsistentValues):
2061         * WebKitTestRunner/TestController.h:
2062         * WebKitTestRunner/ios/TestControllerIOS.mm:
2063         (WTR::TestController::platformResetPreferencesToConsistentValues):
2064         * WebKitTestRunner/mac/TestControllerMac.mm:
2065         (WTR::TestController::platformResetPreferencesToConsistentValues):
2066
2067 2014-10-16  Dan Bernstein  <mitz@apple.com>
2068
2069         OSObjectPtr is missing leakRef()
2070         https://bugs.webkit.org/show_bug.cgi?id=137798
2071
2072         Reviewed by Sam Weinig.
2073
2074         * TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp:
2075         (TestWebKitAPI::TEST(OSObjectPtr, LeakRef)): Added.
2076
2077 2014-10-16  Lucas Forschler  <lforschler@apple.com>
2078
2079         Update target platform to remove Leopard, Snow Leopard, Lion.
2080         Add Yosemite. 
2081         
2082         Unreviewed.
2083
2084         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
2085         (_should_file_trigger_build):
2086
2087 2014-10-16  David Kilzer  <ddkilzer@apple.com>
2088
2089         commit-queue: fails to replace OO-PS! with reviewer name
2090         <http://webkit.org/b/137795>
2091
2092         Reviewed by Alexey Proskuryakov.
2093
2094         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2095         (Bugzilla.fetch_bug_dictionary): Bugzilla 4.2.x never gives out
2096         email addresses to unauthenticated page loads, so we must always
2097         authenticate before getting bug data so we get full email
2098         addresses.
2099
2100 2014-10-16  David Kilzer  <ddkilzer@apple.com>
2101
2102         commit-queue: fails to close bugs after successfully landing patches
2103         <http://webkit.org/b/137794>
2104
2105         Reviewed by Alexey Proskuryakov.
2106
2107         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2108         (Bugzilla.clear_attachment_flags): Change 'nr=0' to 'nr=1' to
2109         tell Mechanize to use the second <textarea> on the page with
2110         name="comment".
2111
2112 2014-10-16  Brent Fulgham  <bfulgham@apple.com>
2113
2114         [Win] Update DRT to match Mac Logic
2115         https://bugs.webkit.org/show_bug.cgi?id=137787
2116
2117         Reviewed by Dean Jackson.
2118
2119         * DumpRenderTree/win/DumpRenderTree.cpp:
2120         (initialize): 0 -> nullptr
2121         (runTest): Initialize MSG structure before using.
2122         (main): Add CRT debug flags if building DRT with debug malloc on Windows.
2123         Also, cleanly shut down COM when exiting.
2124         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2125         (FrameLoadDelegate::didChangeLocationWithinPageForFrame): Move from
2126         header and add printf to match Mac.
2127         (FrameLoadDelegate::windowScriptObjectAvailable): Ditto.
2128         * DumpRenderTree/win/FrameLoadDelegate.h:
2129         (FrameLoadDelegate::didChangeLocationWithinPageForFrame): Deleted.
2130         (FrameLoadDelegate::windowScriptObjectAvailable): Deleted.
2131         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
2132         (isLocalhost): Added.
2133         (hostIsUsedBySomeTestsToGenerateError): Added.
2134         (ResourceLoadDelegate::willSendRequest): Add logic to mimic Mac's use
2135         of certain error and redirect host names.
2136         * DumpRenderTree/win/UIDelegate.cpp:
2137         (UIDelegate::runJavaScriptAlertPanelWithMessage): Use 'done' flag to decide if
2138         anything should be output to the console. This modifies behavior to match the Mac.
2139         (UIDelegate::runJavaScriptConfirmPanelWithMessage): Ditto.
2140         (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Ditto.
2141         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage): Ditto.
2142         (UIDelegate::webViewAddMessageToConsole): Ditto.
2143         * WinLauncher/PageLoadTestClient.cpp:
2144         (PageLoadTestClient::pageLoadEndedAtTime): Drive-by-fix for an assertion that I
2145         added last week.
2146
2147 2014-10-16  Commit Queue  <commit-queue@webkit.org>
2148
2149         Unreviewed, rolling out r174754.
2150         https://bugs.webkit.org/show_bug.cgi?id=137789
2151
2152         Speculative fix for Windows test was ineffective. (Requested
2153         by rfong on #webkit).
2154
2155         Reverted changeset:
2156
2157         "[Windows] Add some more logging to debug Windows test
2158         issues."
2159         http://trac.webkit.org/changeset/174754
2160
2161 2014-10-15  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2162
2163         Unreviewed, add myself to CoordinatedGraphics watchers.
2164
2165         * Scripts/webkitpy/common/config/watchlist:
2166
2167 2014-10-15  Roger Fong  <roger_fong@apple.com>
2168
2169         [Windows] Speculative Windows test fix.
2170
2171         * DumpRenderTree/win/DumpRenderTree.cpp: Make sure that OLEAUT32.dll doesn't cache BSTRs.
2172
2173 2014-10-15  Rebecca Hauck  <rhauck@adobe.com>
2174
2175         import-w3c-test rewrites relative src paths in ref files incorrectly
2176         https://bugs.webkit.org/show_bug.cgi?id=137586
2177
2178         This patch fixes a bug in test_converter.py where src paths were getting 
2179         rewritten as ../../some-path instead of <script src="../../some-path>". 
2180         It also adds support for rewriting src paths in style  elements, which was 
2181         missing before and it adds tests for this case.
2182
2183         Reviewed by Bem Jones-Bey.
2184
2185         * Scripts/webkitpy/w3c/test_converter.py:
2186         (_W3CTestConverter.convert_attributes_if_needed):
2187         * Scripts/webkitpy/w3c/test_converter_unittest.py:
2188         (test_convert_attributes_if_needed):
2189         (verify_reference_relative_paths):
2190
2191 2014-10-15  Jake Nielsen  <jacob_nielsen@apple.com>
2192
2193         Add --json flag to test-webkitpy to emit JSON formatted test results
2194         to stdout
2195         https://bugs.webkit.org/show_bug.cgi?id=137353
2196
2197         Reviewed by Daniel Bates.
2198
2199         * Scripts/webkitpy/port/server_process_unittest.py:
2200         Adds the read method to MockFile to allow the stdout of test_webkitpy
2201         to be redirected without causing erroneous test failures.
2202         In particular,
2203         webkitpy.port.server_process_unittest.TestServerProcess.test_broken_pipe
2204         and
2205         webkitpy.port.server_process_unittest.TestServerProcess.test_cleanup
2206         because when redirecting to a file, the
2207         _wait_for_data_and_update_buffers_using_select method in 
2208         server_process.py will find that there is a read file descriptor in
2209         its call to select.select, which eventually leads to it calling read()
2210         on the MockFile object.
2211         (MockFile.read):
2212         * Scripts/webkitpy/test/main.py:
2213         Adds the _print_results_as_json method and the --json flag which
2214         determines whether _print_results_as_json will get called.
2215         (Tester._parse_args):
2216         (Tester._print_results_as_json):
2217         (Tester._print_results_as_json.result_dict_from_tuple):
2218         (Tester._run_tests):
2219
2220 2014-10-13  David Farler  <dfarler@apple.com>
2221
2222         [iOS] LayoutTestRelay: Detect broken pipe when reading simulator app's stdout and stderr.
2223         https://bugs.webkit.org/show_bug.cgi?id=137662
2224
2225         Reviewed by Darin Adler.
2226
2227         The layout test harness can close LayoutTestRelay's subprocess
2228         stdout and stderr in the case of a timeout or if a run is
2229         cancelled and the FIFOs are cleaned up. If LayoutTestRelay
2230         finds that no one is listening to its stdout/stderr (broken
2231         pipe), then just exit(1), there is nothing to report.
2232
2233         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
2234         (-[LTRelayController didReceiveStdoutData:]):
2235         Add @try/@catch for NSFileHandleOperationException.
2236         (-[LTRelayController didReceiveStderrData:]):
2237         Add @try/@catch for NSFileHandleOperationException.
2238
2239 2014-10-15  Rohit Kumar  <kumar.rohit@samsung.com>
2240
2241         [GTK] Minibrowser : Add keyboard support for zoom in , zoom out and default zoom in GTK Minibrowser
2242         https://bugs.webkit.org/show_bug.cgi?id=137060
2243
2244         Reviewed by Philippe Normand.
2245
2246         Add keyboard support for zoom in , zoom out and default zoom using 'Ctrl' + '+', 'Ctrl' + '-' and 'Ctrl' + '0' respectively.
2247
2248         * MiniBrowser/gtk/BrowserWindow.c:
2249         (zoomInCallback):
2250         (zoomOutCallback):
2251         (defaultZoomCallback): Callback for default zoom keyboard support.
2252         (browser_window_init):
2253
2254 2014-10-14  Simon Fraser  <simon.fraser@apple.com>
2255
2256         [Mac] DRT stderr logging after the test completes gets attributed to the next test
2257
2258         Reviewed by Alexey Proskuryakov.
2259         
2260         DRT would send "#EOF" to stderr just after doing so to stdout, which cause any later
2261         logging to stderr to get associated with the next test.
2262         
2263         Fix by logging #EOF to stderr later, after we've completely finished with this test.
2264
2265         * DumpRenderTree/mac/DumpRenderTree.mm:
2266         (dumpTestResults):
2267         (runTest):
2268
2269 2014-10-14  Brent Fulgham  <bfulgham@apple.com>
2270
2271         [Win] Unreviewed gardening. Ignore Visual Studio *.sdf temporary files.
2272
2273         * DumpRenderTree/DumpRenderTree.vcxproj: Modified property svn:ignore.
2274
2275 2014-10-14  Csaba Osztrogonác  <ossy@webkit.org>
2276
2277         [cmake] Fix the make build after r174683
2278         https://bugs.webkit.org/show_bug.cgi?id=137703
2279
2280         Reviewed by Martin Robinson.
2281
2282         * Scripts/webkitdirs.pm:
2283         (buildCMakeGeneratedProject):
2284
2285 2014-10-14  Myles C. Maxfield  <mmaxfield@apple.com>
2286
2287         Adding myself to the watchlist to CachedFont
2288
2289         Unreviewed.
2290
2291         * Scripts/webkitpy/common/config/watchlist:
2292
2293 2014-10-14  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2294
2295         [EFL][GTK] Make it possible to get verbose output with ninja
2296         https://bugs.webkit.org/show_bug.cgi?id=137606
2297
2298         Reviewed by Csaba Osztrogonác.
2299
2300         * Scripts/webkitdirs.pm:
2301         (buildCMakeGeneratedProject):
2302
2303 2014-10-14  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2304
2305         [EFL] Make it possible to use ninja for EFL build too
2306         https://bugs.webkit.org/show_bug.cgi?id=137605
2307
2308         Reviewed by Csaba Osztrogonác.
2309
2310         * Scripts/webkitdirs.pm:
2311         (generateBuildSystemFromCMakeProject):
2312         * efl/install-dependencies:
2313
2314 2014-10-14  Rohit Kumar  <kumar.rohit@samsung.com>
2315
2316         [GTK] Minibrowser : Add home buton and keyboard support for home page load
2317         https://bugs.webkit.org/show_bug.cgi?id=137486
2318
2319         Reviewed by Philippe Normand.
2320
2321         * MiniBrowser/gtk/BrowserWindow.c:
2322         (loadHomePage): Callback for home page load.
2323         (browser_window_init):
2324         * MiniBrowser/gtk/BrowserWindow.h:
2325         * MiniBrowser/gtk/main.c:
2326         (main):
2327
2328 2014-10-14  Manuel Rego Casasnovas  <rego@igalia.com>
2329
2330         import-w3c-tests doesn't prefix property values
2331         https://bugs.webkit.org/show_bug.cgi?id=137600
2332
2333         Reviewed by Bem Jones-Bey.
2334
2335         Some property values are prefixed in WebKit. Modified the W3C import
2336         script in order to prefix property values and not only properties.
2337         The patch re-uses most of the already existent logic to prefix
2338         properties.
2339
2340         * Scripts/webkitpy/w3c/test_converter.py: Read prefixed property values
2341         from CSSValueKeywords.in and adapt converter to modify both properties
2342         and property values.
2343         (convert_for_webkit):
2344         (_W3CTestConverter.__init__):
2345         (_W3CTestConverter.output):
2346         (_W3CTestConverter.read_webkit_prefixed_css_property_list):
2347         (_W3CTestConverter):
2348         (_W3CTestConverter.add_webkit_prefix_to_unprefixed_properties_and_values):
2349         (_W3CTestConverter.add_webkit_prefix_following_regex):
2350         (_W3CTestConverter.convert_reference_relpaths):
2351         (_W3CTestConverter.convert_style_data):
2352         (_W3CTestConverter.convert_attributes_if_needed):
2353         (_W3CTestConverter.add_webkit_prefix_to_unprefixed_properties): Deleted.
2354         * Scripts/webkitpy/w3c/test_converter_unittest.py: Updated unit test to
2355         include checks for property values too.
2356         (W3CTestConverterTest.test_read_prefixed_property_list):
2357         (verify_no_conversion_happened):
2358         (verify_prefixed_properties):
2359         (verify_prefixed_property_values):
2360         (generate_test_content_properties_and_values):
2361         (generate_test_content):
2362         * Scripts/webkitpy/w3c/test_importer.py: Modified importer to manage
2363         prefixed property values and inform about them.
2364         (TestImporter.import_tests):
2365         (TestImporter.write_import_log):
2366
2367 2014-10-13  Jer Noble  <jer.noble@apple.com>
2368
2369         MediaPlayer::characteristicChanged() is not called when new tracks are found in SourceBufferPrivateAVFObjC
2370         https://bugs.webkit.org/show_bug.cgi?id=137533
2371
2372         Reviewed by Andy Estes.
2373
2374         Follow up patch; bail out of the test early (without failing) if the platform does not support MSE.
2375
2376         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
2377         (TestWebKitAPI::isMSEEnabledCallback):
2378         (TestWebKitAPI::TEST):
2379
2380 2014-10-13  Brent Fulgham  <bfulgham@apple.com>
2381
2382         [Win] Implement a page load profiling tool
2383         https://bugs.webkit.org/show_bug.cgi?id=137673
2384
2385         Reviewed by Dean Jackson.
2386
2387         Add a tool to capture and summarize page load statistics.
2388
2389         * WinLauncher/Common.cpp:
2390         (parseCommandLine): Move from WinMain.cpp so that it can
2391         be shared with internal tools.
2392         * WinLauncher/PageLoadTestClient.cpp: Added.
2393         (PageLoadTestClient::PageLoadTestClient):
2394         (PageLoadTestClient::pageLoadStartedAtTime):
2395         (PageLoadTestClient::didStartProvisionalLoad):
2396         (PageLoadTestClient::didCommitLoad):
2397         (PageLoadTestClient::didFirstLayoutForMainFrame):
2398         (PageLoadTestClient::didHandleOnLoadEvents):
2399         (PageLoadTestClient::didFinishLoad):
2400         (PageLoadTestClient::didFailLoad):
2401         (PageLoadTestClient::didInitiateResourceLoad):
2402         (PageLoadTestClient::didEndResourceLoad):
2403         (PageLoadTestClient::pageLoadEndedAtTime):
2404         (PageLoadTestClient::endPageLoad):
2405         (PageLoadTestClient::clearPageLoadState):
2406         (PageLoadTestClient::shouldConsiderPageLoadEnded):
2407         (PageLoadTestClient::maybeEndPageLoadSoon):
2408         (PageLoadTestClient::setPageURL):
2409         (PageLoadTestClient::dumpRunStatistics):
2410         * WinLauncher/PrintWebUIDelegate.cpp:
2411         (PrintWebUIDelegate::createWebViewWithRequest): Handle
2412         nullptr URL properly.
2413         * WinLauncher/ResourceLoadDelegate.cpp: Added.
2414         (ResourceLoadDelegate::QueryInterface):
2415         (ResourceLoadDelegate::AddRef):
2416         (ResourceLoadDelegate::Release):
2417         (ResourceLoadDelegate::identifierForInitialRequest):
2418         (ResourceLoadDelegate::willSendRequest):
2419         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
2420         (ResourceLoadDelegate::didCancelAuthenticationChallenge):
2421         (ResourceLoadDelegate::didReceiveResponse):
2422         (ResourceLoadDelegate::didReceiveContentLength):
2423         (ResourceLoadDelegate::didFinishLoadingFromDataSource):
2424         (ResourceLoadDelegate::didFailLoadingWithError):
2425         (ResourceLoadDelegate::plugInFailedWithError):
2426         * WinLauncher/ResourceLoadDelegate.h: Added.
2427         (ResourceLoadDelegate::ResourceLoadDelegate):
2428         * WinLauncher/WinLauncher.cpp:
2429         (WinLauncher::WinLauncher): Accept argument to indicate we want to capture
2430         page loading statistics.
2431         (WinLauncher::setFrameLoadDelegatePrivate): Get rid of stub implementation
2432         and set private load delegate state.
2433         (WinLauncher::setResourceLoadDelegate): Replace stub with a full implementation
2434         that sets the view's resource load delegate.
2435         (WinLauncher::loadURL): If no URL is passed, load the test document.
2436         * WinLauncher/WinLauncher.h:
2437         (WinLauncher::pageLoadTestClient):
2438         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Updated for new source files.
2439         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters: Ditto.
2440         * WinLauncher/WinLauncherWebHost.cpp:
2441         (WinLauncherWebHost::updateAddressBar): Hook into page load statistics routine.
2442         (WinLauncherWebHost::loadURL): Moved 'SendMessage' call to its own method so that
2443         it could be used from other source files.
2444         (WinLauncherWebHost::didFinishLoadForFrame): Added overload to capture statistics.
2445         (WinLauncherWebHost::didStartProvisionalLoadForFrame): Ditto.
2446         (WinLauncherWebHost::didFailLoadWithError): Ditto.
2447         (WinLauncherWebHost::didHandleOnloadEventsForFrame): Ditto.
2448         (WinLauncherWebHost::didFirstLayoutInFrame): Ditto.
2449         (WinLauncherWebHost::didFinishDocumentLoadForFrame): Ditto.
2450         (WinLauncherWebHost::didFirstVisuallyNonEmptyLayoutInFrame): Ditto.
2451         (WinLauncherWebHost::didStartProvisionalLoadForFrame): Deleted.
2452         * WinLauncher/WinLauncherWebHost.h:
2453         * WinLauncher/WinMain.cpp:
2454         (wWinMain): Create and use new delegates for gathering page load data.
2455         * WinLauncher/stdafx.h: Need to add <wtf/Platform> include for various macros used in build.
2456
2457 2014-10-13  Simon Fraser  <simon.fraser@apple.com>
2458
2459         Improve the test image diffs page
2460         https://bugs.webkit.org/show_bug.cgi?id=137674
2461
2462         Reviewed by Alexey Proskuryakov.
2463         
2464         Don't treat the input file as a format string, otherwise we have to escape special
2465         characters. Just do a couple of replaces.
2466
2467         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2468         (TestResultWriter.write_image_diff_files):
2469
2470 2014-10-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2471
2472         [XvfbDriver] Regular expression used to match running X servers fails on Fedora 21.
2473         https://bugs.webkit.org/show_bug.cgi?id=137659
2474
2475         Reviewed by Martin Robinson.
2476
2477         * Scripts/webkitpy/port/xvfbdriver.py:
2478         (XvfbDriver._next_free_display): Update the regular expression to also match Xorg.bin
2479
2480 2014-10-13  Alexey Proskuryakov  <ap@apple.com>
2481
2482         Add more detailed wait time information to EWS metrics
2483         https://bugs.webkit.org/show_bug.cgi?id=137649
2484
2485         Reviewed by Daniel Bates.
2486
2487         Added average and worst time (we used to only have median), and also a percentage
2488         of patches that took a non-trivial time to start. Non-trivial is defined as 3 minutes.
2489
2490         There is always some wait due to the polling nature of the queues, which is well understood
2491         and doesn't need to be measured. What needs to be measured is whether there is enough
2492         bot machines to process patches as soon as they are submitted.
2493
2494         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
2495         (Analyzer.prototype._analyzeBubblePerformance):
2496         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsBubbleView.js:
2497         (MetricsBubbleView.prototype._update):
2498
2499 2014-10-11  Jer Noble  <jer.noble@apple.com>
2500
2501         MediaPlayer::characteristicChanged() is not called when new tracks are found in SourceBufferPrivateAVFObjC
2502         https://bugs.webkit.org/show_bug.cgi?id=137533
2503
2504         Reviewed by Darin Adler.
2505
2506         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2507         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
2508         (TestWebKitAPI::TEST):
2509         * TestWebKitAPI/Tests/WebKit2/file-with-mse.html: Added.
2510         * TestWebKitAPI/Tests/WebKit2/test-mse.mp4: Added.
2511
2512 2014-10-13  Simon Fraser  <simon.fraser@apple.com>
2513
2514         iOS DRT snapshots are limited to the page visible area
2515         https://bugs.webkit.org/show_bug.cgi?id=137650
2516
2517         Reviewed by Daniel Bates.
2518         
2519         LegacyTileCache drawing was limited to the window's visible area, found by
2520         crawling up the layer hierarchy to the root layer. This caused test snapshots to
2521         be missing non-composited content outside the iPhone visible area, which hinders
2522         testing.
2523         
2524         Fix by adding a test-only mode where the window visible area is the entire window.
2525         
2526         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
2527         (dumpWebViewAsPixelsAndCompareWithExpected): Drive-by RetainPtr fix.
2528         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
2529         (-[DumpRenderTreeWindow initWithLayer:]): Call setEntireWindowVisibleForTesting:YES
2530         for the DRT window.
2531         
2532
2533 2014-10-12  Simon Fraser  <simon.fraser@apple.com>
2534
2535         Page not fully rendered in iOS DRT snapshots
2536         https://bugs.webkit.org/show_bug.cgi?id=137638
2537
2538         Reviewed by Tim Horton.
2539         
2540         In iOS DumpRenderTree, we need to wait for a cycle of the WebThread runloop
2541         to ensure that the page has laid out and is rendered by the time we take
2542         the snapshot.
2543
2544         * DumpRenderTree/mac/DumpRenderTree.mm:
2545         (-[DumpRenderTree _webThreadEventLoopHasRun]): Moved.
2546         (-[DumpRenderTree _webThreadInvoked]): Moved.
2547         (-[DumpRenderTree _waitForWebThreadThenDump]):
2548         (dump): Use a performSelectorOnMainThread:withObject:waitUntilDone:NO to wait
2549         for a cycle of the WebThrewd runloop. We can't just call _waitForWebThread because
2550         that blocks on a delegate callback, and we can't dispatch_async because _waitForWebThread
2551         relies on dispatch_async too, and the inner block won't complete until the outer block
2552         has completed.
2553         (dumpTestResults): Move the guts of dump() here.
2554         (runTest): Whitespace.
2555
2556 2014-10-12  Alexey Proskuryakov  <ap@apple.com>
2557
2558         Adding svn:ignore so that .pyc files don't show up as new.
2559
2560         * Scripts/webkitpy/xcode: Added property svn:ignore.
2561
2562 2014-10-12  Ryuan Choi  <ryuan.choi@gmail.com>
2563
2564         [EFL] Introduce EWebKit_Extension
2565         https://bugs.webkit.org/show_bug.cgi?id=134921
2566
2567         Reviewed by Gyuyoung Kim.
2568
2569         * MiniBrowser/efl/main.c: Added x option to test extension path.
2570         (window_create):
2571         (elm_main):
2572         * Scripts/webkitpy/common/config/watchlist:
2573         Added Source/WebKit2/WebProcess/InjectedBundle/API/efl/ into EFLWebKit2PublicAPI.
2574         * Scripts/webkitpy/style/checker.py:
2575         Added Source/WebKit2/WebProcess/InjectedBundle/API/efl/ into EFL exceptions.
2576
2577 2014-10-11  Simon Fraser  <simon.fraser@apple.com>
2578
2579         After r174628 we send the test process a SIGTERM before the SIGKILL.
2580
2581         * Scripts/webkitpy/common/system/executive_unittest.py:
2582         (ExecutiveTest.serial_test_kill_process):
2583
2584 2014-10-11  KwangHyuk Kim  <hyuki.kim@samsung.com>
2585
2586         [EFL] Enable WebP support.
2587         https://bugs.webkit.org/show_bug.cgi?id=136156
2588
2589         Reviewed by Gyuyoung Kim.
2590
2591         Include libwebp-dev package to support WebP for WK2 Efl.
2592
2593         * efl/install-dependencies:
2594
2595 2014-10-11  Carlos Garcia Campos  <cgarcia@igalia.com>
2596
2597         [GLIB] Split GMainLoopSource moving thread safe implementation to its own class GThreadSafeMainLoopSource
2598         https://bugs.webkit.org/show_bug.cgi?id=137485
2599
2600         Reviewed by Sergio Villar Senin.
2601
2602         Update GMainLoopSource tests. Most of the tests are now run twice,
2603         first with a GMainLoopSource and then with a
2604         GThreadSafeMainLoopSource, since both should have the same
2605         behaviour. The threading test uses GThreadSafeMainLoopSource and
2606         the delete on destroy test uses GMainLoopSource. The tests
2607         themselves haven't changed, since there's no change in behaviour.
2608
2609         * TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp:
2610         (TestWebKitAPI::GMainLoopSourceTest::source):
2611         (TestWebKitAPI::basicRescheduling):
2612         (TestWebKitAPI::TEST):
2613         (TestWebKitAPI::reentrantRescheduling):
2614         (TestWebKitAPI::cancelRepeatingSourceDuringDispatch):
2615         (TestWebKitAPI::basicDestroyCallbacks):
2616         (TestWebKitAPI::destroyCallbacksAfterCancellingDuringDispatch):
2617         (TestWebKitAPI::destroyCallbacksAfterReschedulingDuringDispatch):
2618
2619 2014-10-10  Dana Burkart  <dburkart@apple.com>
2620
2621         Fix fat-fingered function name in git-add-reviewer.
2622
2623         Unreviewed.
2624
2625         * Scripts/git-add-reviewer:
2626         (getConfigValue):
2627
2628 2014-10-10  David Farler  <dfarler@apple.com>
2629
2630         [iOS] LayoutTestRelay should ensure its DRT/WKTR dies when receiving kill/term signals
2631         https://bugs.webkit.org/show_bug.cgi?id=137528
2632
2633         Reviewed by Simon Fraser.
2634
2635         Catch SIGINT and SIGTERM signals in the LayoutTestRelay
2636         and SIGKILL the paired simulator app before exiting cleanly.
2637
2638         webkitpy only uses SIGKILL to kill processes which you cannot
2639         catch. Send SIGTERM to the process and give it chance to do
2640         its thing before sending SIGKILL. Sending a SIGKILL to an already
2641         dead PID is safe.
2642
2643         * LayoutTestRelay/LayoutTestRelay/LTRelayController.h:
2644         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
2645         (-[LTRelayController finish]):
2646         * LayoutTestRelay/LayoutTestRelay/main.m:
2647         (receivedSignal):
2648         (main):
2649
2650 2014-10-10  David Farler  <dfarler@apple.com>
2651
2652         [iOS] LayoutTestRelay should detect EOF and properly signal underlying DRT/WKTR
2653         https://bugs.webkit.org/show_bug.cgi?id=137527
2654
2655         Reviewed by Simon Fraser.
2656
2657         NSFileHandle doesn't notify of EOF in its readability handler.
2658         Use a dispatch_source_t and an event handler that is called when reading is possible.
2659         In the handler block, do a run-of-the-mill read(2) from standard input and
2660         detect EOF in the usual way by checking that zero bytes were read.
2661
2662         Once an EOF is received, the FIFOs are disconnected, the simulator app
2663         is killed, and the relay exits with status 0.
2664
2665         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
2666         (-[LTRelayController initWithDevice:productDir:appPath:identifierSuffix:dumpToolArguments:]):
2667         (-[LTRelayController didDisconnect]):
2668         (-[LTRelayController didConnect]):
2669         (-[LTRelayController launchApp]):
2670         Rename "dispatchSource" to "simulatorAppExitDispatchSource" to prevent any
2671         confusion with this new dispatch source, called "standardInputDispatchSource".
2672         (-[LTRelayController finish]): Added.
2673         (-[LTRelayController readFileHandle:]): Deleted.
2674
2675 2014-10-10  KwangHyuk Kim  <hyuki.kim@samsung.com>
2676
2677         [EFL] Crash on facebook.com
2678         https://bugs.webkit.org/show_bug.cgi?id=137562
2679
2680         Reviewed by Chris Dumez.
2681
2682         Crash occurs on the facebook.com when the webview is resized
2683         after the <select> item is clicked but no item is chosen.
2684         This crash is just caused by the reference of invalidated variable.
2685         From the EwkView::closePopupMenu(), ewk_menu is just invalidated.
2686         Therefore ewk_menu variable is not available anymore when on_popup_menu_hide()
2687         on MiniBrowser is called.
2688         As a result, just set ewk_menu to NULL in order to prevent crash condition.
2689
2690         * MiniBrowser/efl/main.c:
2691         (on_popup_menu_hide):
2692
2693 2014-10-10  Alexey Proskuryakov  <ap@apple.com>
2694
2695         A small wording change for clarity.
2696
2697         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsBubbleView.js:
2698         (MetricsBubbleView.prototype._update):
2699
2700 2014-10-10  Alexey Proskuryakov  <ap@apple.com>
2701
2702         Dashboard metrics page should have EWS statistics
2703         https://bugs.webkit.org/show_bug.cgi?id=137626
2704
2705         Reviewed by Ryosuke Niwa.
2706
2707         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueue.js:
2708         (BubbleQueue): Put shortName in the object, so that it's actually useful.
2709
2710         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2711         (BubbleQueueServer): Re-ordered queues to match bubble order.
2712         (BubbleQueueServer.prototype.jsonProcessingTimesURL): Added URL for the new handler.
2713         (BubbleQueueServer.prototype.loadProcessingTimes): Load the data from webkit-queues.
2714
2715         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
2716         Added analysis for bubble queues.
2717
2718         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsBubbleView.js: Added.
2719
2720         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
2721         (buildBubbleQueuesTable): Build the UI.
2722
2723         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/metrics.html:
2724         Added JS sources to load.
2725
2726         * QueueStatusServer/app.yaml: To update app version.
2727
2728         * QueueStatusServer/handlers/processingtimesjson.py: Added.
2729
2730         * QueueStatusServer/main.py: Added a handler for processing-times-json.
2731
2732 2014-10-10  Alexey Proskuryakov  <ap@apple.com>
2733
2734         REGRESSION: Commit queue doesn't process rollouts
2735         https://bugs.webkit.org/show_bug.cgi?id=137623
2736
2737         Reviewed by Tim Horton.
2738
2739         * QueueStatusServer/app.yaml:
2740         * QueueStatusServer/handlers/updateworkitems.py:
2741         (UpdateWorkItems._work_items_from_request):
2742
2743 2014-10-10  Simon Fraser  <simon.fraser@apple.com>
2744
2745         Fix syntax error after r174601.
2746
2747         * Scripts/run-javascriptcore-tests:
2748
2749 2014-10-10  Michael Saboff  <msaboff@apple.com>
2750
2751         Add ability to select tarfile name in run-jsc-stress-tests
2752         https://bugs.webkit.org/show_bug.cgi?id=137614
2753
2754         Reviewed by Mark Hahnenberg.
2755
2756         Added optional file name argument to the --tarball option.  
2757
2758         * Scripts/run-javascriptcore-tests: Added "--" to terminate options so the first
2759         extra test given after the options wont be used for the optional tarball file name.
2760         * Scripts/run-jsc-stress-tests:
2761
2762 2014-10-10  Chris Dumez  <cdumez@apple.com>
2763
2764         Unreviewed, update my information in contributors.json
2765
2766         Use my preferred first name and update my expertise areas.
2767
2768         * Scripts/webkitpy/common/config/contributors.json:
2769
2770 2014-10-10  Adrien Destugues  <pulkomandy@gmail.com>
2771
2772         Fix perl scripts to run with env on Linux
2773         https://bugs.webkit.org/show_bug.cgi?id=137601
2774
2775         Reviewed by Csaba Osztrogonác.
2776
2777         Use of arguments in #! is nonstandard and does not behave the same on
2778         different systems. Linux would look for an executable named "perl -w" 
2779         "use warnings;" does the same things in a more portable way.
2780
2781         * Scripts/commit-log-editor:
2782         * Scripts/num-cpus:
2783         * Scripts/prepare-ChangeLog:
2784         * Scripts/run-launcher:
2785         * Scripts/svn-create-patch:
2786
2787 2014-10-10  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
2788
2789         [jhbuild] We should be able to disable wiping on configuration change
2790         https://bugs.webkit.org/show_bug.cgi?id=137446
2791
2792         Reviewed by Csaba Osztrogonác.
2793
2794         The default behaviour isn't changed, wiping on configuration change feature can be disabled with
2795         setting JHBUILD_WIPE_ON_CHANGE=0 environment variable
2796         or passing --no-wipe-on-change command line option.
2797
2798         * Scripts/update-webkit-libs-jhbuild:
2799
2800 2014-10-09  Andy Estes  <aestes@apple.com>
2801
2802         Teach webkitpy about OS X Yosemite
2803         https://bugs.webkit.org/show_bug.cgi?id=137585
2804
2805         Reviewed by Simon Fraser.
2806
2807         * Scripts/webkitpy/common/system/platforminfo.py:
2808         (PlatformInfo._determine_mac_version):
2809         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
2810         (TestPlatformInfo.test_os_version):
2811         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2812         (TestExpectationParser):
2813         * Scripts/webkitpy/port/builders.py:
2814         * Scripts/webkitpy/port/mac.py:
2815         (MacPort):
2816         * Scripts/webkitpy/port/mac_unittest.py:
2817         (test_versions):
2818         (test_baseline_search_path):
2819         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2820         (TestRebaselineTest.test_baseline_directory):
2821         (TestRebaselineExpectations.test_rebaseline_expectations):
2822
2823 2014-10-09  Dana Burkart  <dburkart@apple.com>
2824
2825         Add Mac OS Yosemite dashboard support.
2826
2827         Rubber-stamped by Lucas Forschler.
2828
2829         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Yosemite.png: Added.
2830         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Yosemite@2x.png: Added.
2831         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2832         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2833         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2834
2835 2014-10-08  Ryosuke Niwa  <rniwa@webkit.org>
2836
2837         Add Babak to contributors.json and add historical email addresses for some contributors
2838         https://bugs.webkit.org/show_bug.cgi?id=137546
2839
2840         Reviewed by Christophe Dumez.
2841
2842         contributors.json is used to analyze historical commit data and change logs.
2843
2844         Add back historical email addresses for some contributors and also add Babak (Shafiei).
2845
2846         * Scripts/webkitpy/common/config/contributors.json:
2847
2848 2014-10-09  Lucas Forschler  <lforschler@apple.com>
2849
2850         Add Mac OS Yosemite webkit build infrastructure.
2851         
2852         This patch adds 15 bots to our build.webkit.org configuration.
2853         We are matching the current Mavericks machines 1:1.
2854         
2855         This patch includes some minor spacing changes to the buildslaves section to make everything similar.
2856         
2857         Reviewed by Matt Hanson.
2858
2859         * BuildSlaveSupport/build.webkit.org-config/config.json:
2860
2861 2014-10-09  Dana Burkart  <dburkart@apple.com>
2862
2863         Don't use backticks when running commands, as we run into sh-related
2864         interpolation issues. Also, fix our usage of system() to properly
2865         retrieve the status code.
2866         https://bugs.webkit.org/show_bug.cgi?id=137541
2867
2868         Reviewed by Darin Adler.
2869
2870         * Scripts/git-add-reviewer:
2871         (interactive):
2872         (nonInteractive):
2873         (requireCleanWorkTree):
2874         (cherryPick):
2875         (commit):
2876         (addReviewerToFile):
2877         (head):
2878         (isAncestor):
2879         (toCommit):
2880         (changeLogsForCommit):
2881         (resetToCommit):
2882         (getConfigValue):
2883         (runCommandWithOutput):
2884
2885 2014-10-09  Tim Horton  <timothy_horton@apple.com>
2886
2887         Add a WebKit1 preference for selection services
2888         https://bugs.webkit.org/show_bug.cgi?id=137498
2889         <rdar://problem/18572699>
2890
2891         Reviewed by Simon Fraser.
2892
2893         * MiniBrowser/mac/WK1BrowserWindowController.m:
2894         (-[WK1BrowserWindowController awakeFromNib]):
2895         Turn on image and selection services in the Legacy WebKit MiniBrowser.
2896
2897 2014-10-09  Adrien Destugues  <pulkomandy@gmail.com>
2898
2899         Get the patch scripts running on Haiku
2900         https://bugs.webkit.org/show_bug.cgi?id=137559
2901
2902         Reviewed by Benjamin Poulain.
2903
2904         Use /usr/bin/env instead of hardcoding path to perl.
2905         Declare haiku platform in platforminfo.py to avoid check-webkit-style
2906         failure.
2907
2908         * Scripts/commit-log-editor:
2909         * Scripts/num-cpus:
2910         * Scripts/prepare-ChangeLog:
2911         * Scripts/run-launcher:
2912         * Scripts/svn-create-patch:
2913         * Scripts/webkitpy/common/system/platforminfo.py:
2914         (PlatformInfo._determine_os_name):
2915
2916 2014-10-08  Jake Nielsen  <jacob_nielsen@apple.com>
2917
2918         StyleQueue should throw a PatchIsNotValid exception to achieve
2919         consistency with CommitQueue and EWS
2920         https://bugs.webkit.org/show_bug.cgi?id=137500
2921
2922         Reviewed by Alexey Proskuryakov.
2923
2924         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
2925         Adds a call to validate() in run().
2926         (StyleQueueTask.run):
2927         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2928         Adds a return False in the patch is not valid exception statement.
2929         (AbstractEarlyWarningSystem.review_patch):
2930         * Scripts/webkitpy/tool/commands/queues.py:
2931         Adds a return False in the patch is not valid exception statement in
2932         commit queue, and adds an except statement to catch PatchIsNotValid
2933         exceptions in style queue.
2934         (CommitQueue.process_work_item):
2935         (StyleQueue.review_patch):
2936
2937 2014-10-08  Carlos Garcia Campos  <cgarcia@igalia.com>
2938
2939         Race condition with WebKitWebView:is-loading after starting page load
2940         https://bugs.webkit.org/show_bug.cgi?id=136692
2941
2942         Reviewed by Gustavo Noronha Silva.
2943
2944         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
2945         (loadChangedCallback): Only check is-loading is false when load
2946         has finished if the load didn't fail due to a cancellation.
2947         (loadFailedCallback): Only check is-loading is false if the load
2948         didn't fail due to a cancellation.
2949         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
2950         (WebViewTest::loadURI): Check is-loading is true and active URI is
2951         the requested one rigth after requesting the load.
2952         (WebViewTest::loadHtml): Ditto.
2953         (WebViewTest::loadPlainText): Ditto.
2954         (WebViewTest::loadBytes): Ditto.
2955         (WebViewTest::loadRequest): Ditto.
2956         (WebViewTest::loadAlternateHTML): Ditto.
2957         (WebViewTest::goBack): Ditto.
2958         (WebViewTest::goForward): Ditto.
2959         (WebViewTest::goToBackForwardListItem): Ditto.
2960
2961 2014-10-08  Brent Fulgham  <bfulgham@apple.com>
2962
2963         [Win] Resolve various static analyzer warnings in Tools.
2964         https://bugs.webkit.org/show_bug.cgi?id=137534
2965
2966         Reviewed by Dean Jackson.
2967
2968         * DumpRenderTree/cg/ImageDiffCG.cpp:
2969         (main): User proper printf specifiers.
2970         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2971         (AccessibilityUIElement::childrenCount): Handle possibility that
2972         gcc_accChildCount returns with an error.
2973         (accessibilityState): Ditto for gcc_accState.
2974         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
2975         (DRTDesktopNotificationPresenter::showDesktopNotification): Use proper
2976         check for return value from 'isHTML'. HRESULT is not a boolean and cannot
2977         be treated as such.
2978         * DumpRenderTree/win/DumpRenderTree.cpp:
2979         (DumpRenderTreeWndProc): Avoid possible infinite loop on teardown caused
2980         by comparing an unsigned value as being greater-than zero.
2981         * DumpRenderTree/win/EditingDelegate.cpp:
2982         (dump): Pass proper character pointer type to printf.
2983         (EditingDelegate::shouldBeginEditingInDOMRange): Ditto.
2984         (EditingDelegate::shouldEndEditingInDOMRange): Ditto.
2985         (EditingDelegate::shouldInsertNode): Ditto.
2986         (EditingDelegate::shouldInsertText): Ditto.
2987         (EditingDelegate::shouldDeleteDOMRange): Ditto.
2988         (EditingDelegate::shouldChangeSelectedDOMRange): Ditto.
2989         (EditingDelegate::shouldApplyStyle): Ditto.
2990         * DumpRenderTree/win/EventSender.cpp:
2991         (beginDragWithFilesCallback): Handle possible error case for GlobalAlloc.
2992         * DumpRenderTree/win/EventSender.h: Add proper declaration for HRESULT to match
2993         system headers.
2994         * DumpRenderTree/win/PixelDumpSupportWin.cpp: Handle possible failure
2995         from CreateDIBSection.
2996         * DumpRenderTree/win/UIDelegate.cpp: Ensure proper type is passed to printf.
2997         * TestWebKitAPI/Tests/WTF/MediaTime.cpp: Get rid of workaround for NaN under
2998         older versions of MSVC we no longer support.
2999         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp: Use proper types and API
3000         for 64-bit builds.
3001         * TestWebKitAPI/TestsController.cpp: Use NeverDestroyed like a good citizen.
3002         * TestWebKitAPI/TestsController.h: Ditto.
3003         * WinLauncher/Common.cpp: Handle possible failure from GetModuleFileName.
3004         * WinLauncher/WinLauncher.cpp: Make order of operations explicit to avoid
3005         performing bitwise | before the comparison is done.
3006
3007 2014-10-08  Ada Chan  <adachan@apple.com>
3008
3009         Add a test for WKPageIsPlayingAudio().
3010         https://bugs.webkit.org/show_bug.cgi?id=137048
3011
3012         Reviewed by Darin Adler.
3013
3014         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3015         Add file-with-video.html, test.mp4, and WKPageIsPlayingAudio.cpp to the project.
3016         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp: Added.
3017         (TestWebKitAPI::nullJavaScriptCallback):
3018         (TestWebKitAPI::didFinishLoadForFrame):
3019         (TestWebKitAPI::isPlayingAudioDidChangeCallback):
3020         (TestWebKitAPI::setUpClients):
3021         (TestWebKitAPI::TEST):
3022         This test loads a page with a video in it. When the page is loaded, we first check that
3023         WKPageIsPlayingAudio() returns false for the page. Then we call a method to start the video.
3024         When the WKPageUIClient::isPlayingAudioDidChange callback gets called, check that WKPageIsPlayingAudio()
3025         now returns true for the page.
3026         * TestWebKitAPI/Tests/WebKit2/file-with-video.html: Added.
3027         * TestWebKitAPI/Tests/WebKit2/test.mp4: Added.
3028         This is a video copied from LayoutTests/media/content.
3029
3030 2014-10-08  Csaba Osztrogonác  <ossy@webkit.org>
3031
3032         [webkitpy] Use python-irclib-0.4.8.tar.gz instead of zip in AutoInstaller
3033         https://bugs.webkit.org/show_bug.cgi?id=137516
3034
3035         Reviewed by Alexey Proskuryakov.
3036
3037         * Scripts/webkitpy/thirdparty/__init__.py:
3038         (AutoinstallImportHook._install_irc):
3039
3040 2014-10-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3041
3042         [GTK] install-dependencies should install libjpeg-turbo on Debian and derivatives.
3043         https://bugs.webkit.org/show_bug.cgi?id=137520
3044
3045         Reviewed by Philippe Normand.
3046
3047         Debian is switching is default JPEG library to libjpeg-turbo <https://wiki.debian.org/LJTTransition#Text>
3048         For other distributions, we are already installing libjpeg-turbo.
3049         So, do the same for Debian and derivatives.
3050
3051         * gtk/install-dependencies: Install libjpeg-dev that depends on the default implementation of libjpeg.
3052
3053 2014-10-08  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3054
3055         [webkitpy] Add back the workaround to replace ZipFile.extractall()
3056         https://bugs.webkit.org/show_bug.cgi?id=137519
3057
3058         Reviewed by Csaba Osztrogonác.
3059
3060         It was removed by <http://trac.webkit.org/changeset/174266>,
3061         because the comment stated it is a workaround for buggy python
3062         2.6.1 which shipped on Snow Leopard. But it turned out the bug
3063         is still valid with python 2.7 shipped on the latest Ubuntu
3064         (12.04 and 14.04) and OS X 10.9.
3065
3066         * Scripts/webkitpy/common/system/autoinstall.py:
3067         (AutoInstaller):
3068         (AutoInstaller._extract_all):
3069         (AutoInstaller._unzip):
3070
3071 2014-10-08  Commit Queue  <commit-queue@webkit.org>
3072
3073         Unreviewed, rolling out r174335.
3074         https://bugs.webkit.org/show_bug.cgi?id=137515
3075
3076         It broke EFL layout test totally (Requested by gyuyoung on
3077         #webkit).
3078
3079         Reverted changeset:
3080
3081         "[EFL] Introduce EWebKit_Extension"
3082         https://bugs.webkit.org/show_bug.cgi?id=134921
3083         http://trac.webkit.org/changeset/174335
3084
3085 2014-10-08  Carlos Garcia Campos  <cgarcia@igalia.com>
3086
3087         [GTK] Make forwarding headers generation depend on source code
3088         https://bugs.webkit.org/show_bug.cgi?id=137394
3089
3090         Reviewed by Philippe Normand.
3091
3092         * TestWebKitAPI/CMakeLists.txt: Add missing dependency rule.
3093         * TestWebKitAPI/PlatformGTK.cmake: Only run
3094         generate-forwarding-headers.pl when source code changes.
3095         * WebKitTestRunner/PlatformGTK.cmake: Ditto.
3096
3097 2014-10-07  Tanay C  <tanay.c@samsung.com>
3098
3099         Remove build warnings in Hashmap API tests
3100         https://bugs.webkit.org/show_bug.cgi?id=137484
3101
3102         Reviewed by Darin Adler.
3103
3104         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
3105         (TestWebKitAPI::TEST): Changed EXPECT_EQ(false, addResult.isNewEntry) to EXPECT_FALSE(addResult.isNewEntry) 
3106
3107 2014-10-07  Jake Nielsen  <jacob_nielsen@apple.com>
3108
3109         Commit queue doesn't drop obsolete patches sometimes
3110         https://bugs.webkit.org/show_bug.cgi?id=137460
3111
3112         Reviewed by Alexey Proskuryakov.
3113
3114         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
3115         Adds another test patch for use in queues_unittest.py.
3116         courtesy of Csaba Osztrogonác <ossy@webkit.org>
3117         (MockBugzilla):
3118         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3119         Raises a PatchIsNotValid exception in the case of validate() returning
3120         false.
3121         (CommitQueueTask.run):
3122         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
3123         Raises a PatchIsNotValid exception in the case of validate() returning
3124         false.
3125         (EarlyWarningSystemTask.run):
3126         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
3127         Defines PatchIsNotValid exception. 
3128         (PatchIsNotValid):
3129         (PatchIsNotValid.__init__):
3130         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3131         Remove call to validate() and instead catches the PatchIsNotValid
3132         exception.
3133         (AbstractEarlyWarningSystem.review_patch):
3134         * Scripts/webkitpy/tool/commands/queues.py:
3135         Adds logic to catch the PatchIsNotValid exception.
3136         (CommitQueue.process_work_item):
3137         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3138         Adds the test_non_valid_patch test to ensure that invalid patches are
3139         handled properly, and don't just result in indefinite spinning.
3140         courtesy of Csaba Osztrogonác <ossy@webkit.org>
3141         (test_non_valid_patch):
3142
3143 2014-10-07  Daniel Bates  <dabates@apple.com>
3144
3145         [iOS] Teach run-webkit-tests to honor TestExpectation file for iOS Simulator 64-bit builds
3146         https://bugs.webkit.org/show_bug.cgi?id=137499
3147
3148         Reviewed by Simon Fraser.
3149
3150         Fixes an issue where the TestExpectation file for the iOS Simulator platform was only
3151         honored when running run-webkit-tests with a 32-bit simulator build of iOS WebKit. We
3152         should honor the TestExpectation file for the iOS Simulator platform for both 32- and 64-
3153         bit simulator builds of iOS WebKit.
3154
3155         * Scripts/webkitpy/port/ios.py:
3156         (IOSSimulatorPort._generate_all_test_configurations):
3157
3158 2014-10-07  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3159
3160         [GTK] jhbuild modules should build xserver with the --without-dtrace option.
3161         https://bugs.webkit.org/show_bug.cgi?id=137482
3162
3163         Reviewed by Martin Robinson.
3164
3165         * gtk/jhbuild.modules: Added --without-dtrace option to xserver jhbuild.modules config.
3166
3167 2014-10-07  Carlos Garcia Campos  <cgarcia@igalia.com>
3168
3169         [SOUP] TLS errors should take precedence over HTTP authentication
3170         https://bugs.webkit.org/show_bug.cgi?id=137300
3171
3172         Reviewed by Sergio Villar Senin.
3173
3174         Add a test case to check that authenticate signal is not emitted
3175         in case of TLS errors, and the load fails instead.
3176
3177         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
3178         (webViewAuthenticationCallback):
3179         (testTLSErrorsHTTPAuth):
3180         (httpsServerCallback):
3181         (beforeAll):
3182
3183 2014-10-06  Ryosuke Niwa  <rniwa@webkit.org>
3184
3185         Make webkit-patch find-users useful
3186         https://bugs.webkit.org/show_bug.cgi?id=137475
3187
3188         Reviewed by Alexey Proskuryakov.
3189
3190         Make find-users use the CommitterList instead of accessing Bugzilla.
3191
3192         This essentially exposes the same functionality as webkitbot's whois command.
3193
3194         * Scripts/webkitpy/tool/commands/findusers.py:
3195         (FindUsers.execute):
3196
3197 2014-10-06  Chris Fleizach  <cfleizach@apple.com>
3198
3199         AX: iOS8: Crash at -[WebAccessibilityObjectWrapper accessibilityElementAtIndex:]
3200         https://bugs.webkit.org/show_bug.cgi?id=137289
3201
3202         Unreviewed build fix.
3203
3204         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3205         (AccessibilityUIElement::getChildrenWithRange):
3206
3207 2014-10-06  Alexey Proskuryakov  <ap@apple.com>
3208
3209         build.webkit.org/dashboard: Add commit queue
3210         https://bugs.webkit.org/show_bug.cgi?id=137462
3211
3212         Reviewed by Tim Horton.
3213
3214         Generalizes EWS into "bubble queue", which also includes commit queue and style queue.
3215         Style queue is still invisible, as it doesn't have an associated platform, and also
3216         we never have problems with it anyway, so it's not worth watching.
3217
3218         The UI now allows for adding more bots to the Other column (such as leaks bot).
3219         To make that actually happen, we'll need to refactor QueueView, allowing for multiple
3220         sources of data in a cell.
3221
3222         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueue.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js.
3223         (BubbleQueue):
3224         (BubbleQueue.prototype.get statusPageURL):
3225         (BubbleQueue.prototype.update):
3226         (BubbleQueue.prototype.loadDetailedStatus):
3227         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js.
3228         (BubbleQueueServer):
3229         (BubbleQueueServer.prototype.jsonQueueLengthURL):
3230         (BubbleQueueServer.prototype.jsonQueueStatusURL):
3231         (BubbleQueueServer.prototype.queueStatusURL):
3232         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueView.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js.
3233         (BubbleQueueView):
3234         (BubbleQueueView.prototype.update.appendQueue):
3235         (BubbleQueueView.prototype.update):
3236         (BubbleQueueView.prototype._addQueueHeadingToPopover):
3237         (BubbleQueueView.prototype._popoverContentForBubbleQueue):
3238         (BubbleQueueView.prototype._presentPopoverForBubbleQueue):
3239         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js: Removed.
3240         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js: Removed.
3241         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js: Removed.
3242         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
3243         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
3244         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
3245         (.bubble-server-popover .popover-queue-heading .queue-charts-link):
3246         (.bubble-server-popover .latest-status-no-link):
3247         (.bubble-server-popover .bot-status-description):
3248         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
3249
3250         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
3251         (buildAggregateTable):
3252         (buildQueuesTable):
3253         Removed dysfunctional support for EWS for now. It will be different.
3254
3255 2014-10-06  Alexey Proskuryakov  <ap@apple.com>
3256
3257         One more case of incorrect comparison in recordpatchevent.py
3258         https://bugs.webkit.org/show_bug.cgi?id=137459
3259
3260         Reviewed by Tim Horton.
3261
3262         * QueueStatusServer/app.yaml:
3263         * QueueStatusServer/loggers/recordpatchevent.py:
3264         (RecordPatchEvent.started):
3265
3266 2014-10-06  Alexey Proskuryakov  <ap@apple.com>
3267
3268         webkit-queues PatchLog is incorrect for patches that took less than a second
3269         https://bugs.webkit.org/show_bug.cgi?id=137453
3270
3271         Reviewed by Tim Horton.
3272
3273         * QueueStatusServer/app.yaml: Updated app version.
3274
3275         * QueueStatusServer/loggers/recordpatchevent.py: (RecordPatchEvent.stopped):
3276         Don't bail out for patches that took 0 seconds to process (as frequently happens
3277         when a patch is obsolete).
3278
3279 2014-10-06  Csaba Osztrogonác  <ossy@webkit.org>
3280
3281         EWS bubble hover shows wrong timestamps
3282         https://bugs.webkit.org/show_bug.cgi?id=137252
3283
3284         Reviewed by Alexey Proskuryakov.
3285
3286         Add "Z" suffix to timestamps to make sure if it is handled as UTC time.
3287
3288         * QueueStatusServer/handlers/queuestatusjson.py:
3289         (QueueStatusJSON.get):
3290         * QueueStatusServer/handlers/statusbubble.py:
3291         (StatusBubble._iso_time):
3292
3293 2014-10-06  Mario Sanchez Prada  <mario@webkit.org>
3294
3295         Unreviewed, updated list of email addresses in contributors.json
3296
3297         * Scripts/webkitpy/common/config/contributors.json: Added my former
3298         email address in Igalia, for the sake of completeness.
3299
3300 2014-10-06  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
3301
3302         Unreviewed, moved myself to the list of committers.
3303
3304         * Scripts/webkitpy/common/config/contributors.json:
3305
3306 2014-10-05  Ryuan Choi  <ryuan.choi@gmail.com>
3307
3308         [EFL] Introduce EWebKit_Extension
3309         https://bugs.webkit.org/show_bug.cgi?id=134921
3310
3311         Reviewed by Gyuyoung Kim.
3312
3313         * MiniBrowser/efl/main.c: Added x option to test extension path.
3314         (window_create):
3315         (elm_main):
3316         * Scripts/webkitpy/common/config/watchlist:
3317         Added Source/WebKit2/WebProcess/InjectedBundle/API/efl/ into EFLWebKit2PublicAPI.
3318         * Scripts/webkitpy/style/checker.py:
3319         Added Source/WebKit2/WebProcess/InjectedBundle/API/efl/ into EFL exceptions.
3320
3321 2014-10-04  Csaba Osztrogonác  <ossy@webkit.org>
3322
3323         [jhbuild] Simplify platform detection in update-webkit-libs-jhbuild
3324         https://bugs.webkit.org/show_bug.cgi?id=137390
3325
3326         Reviewed by Carlos Garcia Campos.
3327
3328         * Scripts/update-webkit-libs-jhbuild:
3329
3330 2014-10-04  Carlos Garcia Campos  <cgarcia@igalia.com>
3331
3332         [GTK] Do not generate webkit2gtk-tests-resources.gresource unconditionally
3333         https://bugs.webkit.org/show_bug.cgi?id=137391
3334
3335         Reviewed by Martin Robinson.
3336
3337         Add a custom command to only re-generate
3338         webkit2gtk-tests-resources.gresource when any of its dependencies changes.
3339
3340         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
3341
3342 2014-10-04  Carlos Garcia Campos  <cgarcia@igalia.com>
3343
3344         [GTK] generate-gtkdoc crashes when generating HTML due to encoding issues
3345         https://bugs.webkit.org/show_bug.cgi?id=135502
3346
3347         Reviewed by Martin Robinson.
3348
3349         When writing to stdout/stderr fails due to a UnicodeDecodeError
3350         exception, try again without encoding the output.
3351
3352         * gtk/gtkdoc.py:
3353         (GTKDoc._run_command):
3354
3355 2014-10-03  Alexey Proskuryakov  <ap@apple.com>
3356
3357         Bugzilla status bubble displays an exception showing attachment 175738
3358         https://bugs.webkit.org/show_bug.cgi?id=137410
3359
3360         Reviewed by Tim Horton.
3361
3362         * QueueStatusServer/app.yaml: Update version.
3363
3364         * QueueStatusServer/handlers/statusbubble.py: (StatusBubble._build_bubble):
3365         Don't fail even if expected status message is missing.
3366
3367         * QueueStatusServer/model/patchlog.py: (PatchLog): Quick unrelated fix - define
3368         the field in the same way it's defined in QueueStatus table.
3369
3370 2014-10-03  Alexey Proskuryakov  <ap@apple.com>
3371
3372         Record latest message in PatchLog for quick access
3373         https://bugs.webkit.org/show_bug.cgi?id=137405
3374
3375         Fixing a typo.
3376
3377         * QueueStatusServer/app.yaml:
3378         * QueueStatusServer/handlers/releasepatch.py:
3379
3380 2014-10-03  Alexey Proskuryakov  <ap@apple.com>
3381
3382         Record latest message in PatchLog for quick access
3383         https://bugs.webkit.org/show_bug.cgi?id=137405
3384
3385         Reviewed by Ryosuke Niwa.
3386
3387         It's no SQL...
3388
3389         * QueueStatusServer/handlers/releasepatch.py:
3390         * QueueStatusServer/handlers/updatestatus.py:
3391         * QueueStatusServer/loggers/recordpatchevent.py:
3392         * QueueStatusServer/model/patchlog.py:
3393
3394 2014-10-02  David Farler  <dfarler@apple.com>
3395
3396         -asan-blacklist option also renamed to generic -fsanitize-blacklist
3397         https://bugs.webkit.org/show_bug.cgi?id=137377
3398
3399         Reviewed by Daniel Bates.
3400
3401         * asan/asan.xcconfig:
3402         -asan-blacklist -> -fsanitize-blacklist
3403
3404         http://llvm.org/viewvc/llvm-project?view=revision&revision=212505
3405
3406 2014-10-03  Roger Fong  <roger_fong@apple.com>
3407
3408         [Windows] Include batch size argument to layout tests on Windows.
3409
3410         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3411         (RunWebKitTests.start): 
3412         This is a speculative fix for the the inconsistent crashes we are seeing on Windows.
3413         These crashes seem to happen on random tests though generally in a spread out fashion.
3414         It seems possible that the DRT instance is being clobbered somehow after running too many
3415         tests in a row so we will try to mitigate this by just forcing DRT to restart periodically.
3416
3417 2014-10-03  Roger Fong  <roger_fong@apple.com>
3418
3419         [Windows] Settle for 2 chid processes running NRWT on Windows.
3420
3421         * Scripts/webkitpy/port/win.py:
3422         (WinPort.default_child_processes): 3 child processes reintroduces the sporadic crashing, will settle for 2.
3423
3424 2014-10-03  Akos Kiss  <akiss@inf.u-szeged.hu>
3425
3426         [GTK] Bump up and patch dependencies to allow building for aarch64
3427         https://bugs.webkit.org/show_bug.cgi?id=137147
3428
3429         Reviewed by Martin Robinson.
3430
3431         The currently used versions of pixman, libffi, librsvg, glib,
3432         glib-networking, fontconfig, libxml2, gst-plugins-base fail to configure
3433         and/or build for aarch64, so they are bumped up and patched where
3434         necessary. Wherever possible, the same versions and patches were used as
3435         for the EFL port bump-up
3436         (https://bugs.webkit.org/show_bug.cgi?id=135885).
3437
3438         After the bump-up, a hitherto hidden bug in gst-plugins-good caused a
3439         regression by crashing http/tests/media/video-redirect.html . A patch
3440         already in upstream fixes that bug.
3441
3442         This change does not touch xserver, which also needs bumping up, but 
3443         will be dealt with later.
3444
3445         * gtk/jhbuild.modules:
3446         Specified versions and patches necessary to correctly build for aarch64.
3447         * gtk/patches/gst-events-arent-gstobjects.patch:
3448         Added. Patches gst-plugins-good to fix a bug in .mov file demuxing.
3449         * gtk/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch:
3450         Added. Patches gst-plugins-base to configure correctly for aarch64.
3451         * gtk/patches/librsvg-2.36.1-bump-up-config.guess-to-support-aarch64.patch:
3452         Added. Bumps up config.guess and config.sub in librsvg to recognize
3453         aarch64.
3454         * gtk/patches/libxml2-2.9.0-dtd.patch:
3455         Removed. Not necessary for libxml2 v2.9.1 anymore.
3456
3457 2014-09-28  Sam Weinig  <sam@webkit.org>
3458
3459         Remove RefPtrHashMap
3460         https://bugs.webkit.org/show_bug.cgi?id=137200
3461
3462         Reviewed by Darin Adler.
3463
3464         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
3465         (TestWebKitAPI::TEST):
3466         Add tests for using a HashMap with RefPtr keys, focusing on ensuring that
3467         a minimum of refcount churn occurs.
3468
3469 2014-10-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3470
3471         Remove workarounds for versions of Python before 2.7
3472         https://bugs.webkit.org/show_bug.cgi?id=137338
3473
3474         Reviewed by Csaba Osztrogonác.
3475
3476         * Scripts/webkitpy/common/system/autoinstall.py:
3477         (AutoInstaller._extract_targz):
3478         (AutoInstaller._unzip):
3479         (AutoInstaller): Deleted.
3480         (AutoInstaller._extract_all): Deleted.
3481         * Scripts/webkitpy/common/webkitunittest.py:
3482         (TestCase.setUp): Deleted.
3483         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
3484         (TestConfigurationConverter.collapse_macros):
3485         (TestConfigurationConverter.to_specifiers_list.try_collapsing):
3486         (TestConfigurationConverter.to_specifiers_list.try_abbreviating):
3487         (TestConfigurationConverter):
3488         (TestConfigurationConverter.combinations): Deleted.
3489         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
3490         * Scripts/webkitpy/port/base.py:
3491
3492 2014-10-03  Commit Queue  <commit-queue@webkit.org>
3493
3494         Unreviewed, rolling out r174264.
3495         https://bugs.webkit.org/show_bug.cgi?id=137392
3496
3497         It broke run-webkit-tests (Requested by ebalazsfalvi on
3498         #webkit).
3499
3500         Reverted changeset:
3501
3502         "Remove workarounds for versions of Python before 2.7"
3503         https://bugs.webkit.org/show_bug.cgi?id=137338
3504         http://trac.webkit.org/changeset/174264
3505
3506 2014-10-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3507
3508         Remove workarounds for versions of Python before 2.7
3509         https://bugs.webkit.org/show_bug.cgi?id=137338
3510
3511         Reviewed by Csaba Osztrogonác.
3512
3513         * Scripts/webkitpy/common/system/autoinstall.py:
3514         (AutoInstaller._extract_targz):
3515         (AutoInstaller._unzip):
3516         (AutoInstaller): Deleted.
3517         (AutoInstaller._extract_all): Deleted.
3518         * Scripts/webkitpy/common/webkitunittest.py:
3519         (TestCase.setUp): Deleted.
3520         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
3521         (TestConfigurationConverter.collapse_macros):
3522         (TestConfigurationConverter.to_specifiers_list.try_collapsing):
3523         (TestConfigurationConverter.to_specifiers_list.try_abbreviating):
3524         (TestConfigurationConverter):
3525         (TestConfigurationConverter.combinations): Deleted.
3526         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
3527         * Scripts/webkitpy/port/base.py:
3528         * Scripts/webkitpy/port/driver.py:
3529         (ContentBlock.__init__):
3530         * Scripts/webkitpy/port/server_process.py:
3531         (ServerProcess._reset):
3532
3533 2014-10-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3534
3535         Remove autoinstaller workaround for python 2.6
3536         https://bugs.webkit.org/show_bug.cgi?id=137343
3537
3538         Reviewed by Daniel Bates.
3539
3540         Reverting <http://trac.webkit.org/changeset/124928>, neither Python
3541         2.6, nor Snow Leopard is supported anymore, so the workaround is not
3542         needed anymore.
3543
3544         * Scripts/webkitpy/common/system/autoinstall.py:
3545         (AutoInstaller.install):
3546         * Scripts/webkitpy/test/main.py:
3547         (Tester._run_tests):
3548         * Scripts/webkitpy/thirdparty/__init__.py:
3549         (AutoinstallImportHook._install_mechanize):
3550         (AutoinstallImportHook._install_pep8):
3551         (AutoinstallImportHook._install_pylint):
3552         (AutoinstallImportHook._install_buildbot):
3553         (AutoinstallImportHook._install_coverage):
3554         (AutoinstallImportHook._install_eliza):
3555         (AutoinstallImportHook._install_irc):
3556         (AutoinstallImportHook._install):
3557         (autoinstall_everything):
3558
3559 2014-10-02  Daniel Bates  <dabates@apple.com>
3560
3561         Use version number 101000 instead of 10100 for OS X Yosemite
3562         https://bugs.webkit.org/show_bug.cgi?id=137372
3563
3564         Reviewed by Mark Rowe.
3565
3566         The version number for OS X Yosemite is 101000.
3567
3568         * DumpRenderTree/mac/TextInputController.m:
3569
3570 2014-10-02  Alexey Proskuryakov  <ap@apple.com>
3571
3572         update-work-items should never delete items
3573         https://bugs.webkit.org/show_bug.cgi?id=137366
3574
3575         Reviewed by Ryosuke Niwa.
3576
3577         As we don't just replace the whole list any more, indicate which items are high
3578         priority, and which are not. Hight priority ones will be prepended to the queue,
3579         others will be appended.
3580
3581         This creates a bit of unfairness in that high priority item queue becomes a LIFO.
3582         But hopefully we will never have many rollouts competing like that.
3583
3584         * QueueStatusServer/app.yaml: Update version.
3585
3586         * QueueStatusServer/handlers/updateworkitems.py: Never remove items. Pass high
3587         priority and regular items separately. Removed some error handling that used to
3588         end up in returning status 500 - an uncaught exception does that automatically.
3589
3590         * QueueStatusServer/main.py: Removed unnecessary regexps from URL matching code.
3591
3592         * QueueStatusServer/model/workitems.py: Added a way to add high priority items.
3593
3594         * QueueStatusServer/templates/updateworkitems.html: Added a field for high
3595         priority items.
3596
3597         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3598         (BugzillaQueries._parse_attachment_ids_request_query): Removed an annoying log
3599         line that complicated testing.
3600
3601         * Scripts/webkitpy/common/net/statusserver.py: Pass high priority items separately.
3602
3603         * Scripts/webkitpy/tool/bot/feeders.py: For commit queue, split high and regular
3604         priority items into separate lists.
3605
3606         * Scripts/webkitpy/common/net/statusserver_mock.py:
3607         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
3608         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3609         Updated tests.
3610
3611 2014-10-02  Brendan Long  <b.long@cablelabs.com>
3612
3613         Annoying build warnings in WTFString API tests
3614         https://bugs.webkit.org/show_bug.cgi?id=137360
3615
3616         Reviewed by Darin Adler.
3617
3618         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
3619         (TestWebKitAPI::TEST): Change EXPECT_EQ(false, ok) to EXPECT_FALSE(ok) and EXPECT_EQ(true, ok) to EXPECT_TRUE(ok).
3620
3621 2014-10-02  Roger Fong  <roger_fong@apple.com>
3622
3623         [Windows] The number of processes did not affect the crash inconsistency, increase number of child processes again.
3624
3625         * Scripts/webkitpy/port/win.py:
3626         (WinPort.default_child_processes): Ambitiously try 3 processes the testers are too slow now.
3627
3628 2014-10-02  David Farler  <dfarler@apple.com>
3629
3630         Move ASan arguments from LLVM (-mllvm) to the frontend
3631         https://bugs.webkit.org/show_bug.cgi?id=137365
3632
3633         Reviewed by David Kilzer.
3634
3635         * asan/asan.xcconfig:
3636         Remove the -mllvm prefix to the asan-blacklist argument, moving it
3637         to the clang frontend.
3638
3639         http://llvm.org/viewvc/llvm-project?view=revision&revision=212505
3640