1 2012-03-26 Dirk Pranke <dpranke@chromium.org>
3 clean up NRWT logging/metering, be less verbose
4 https://bugs.webkit.org/show_bug.cgi?id=73846
6 Reviewed by Ojan Vafai.
8 Re-land r112014 with a build fix for Python 2.6 compatibility.
10 * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
11 (ManagerTest.test_http_locking):
12 * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
14 * Scripts/webkitpy/layout_tests/controllers/worker.py:
16 (Worker._set_up_logging):
18 (Worker._set_up_host_and_port):
21 * Scripts/webkitpy/layout_tests/controllers/worker_unittest.py:
22 (WorkerTest.test_default_platform_in_worker):
23 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
26 * Scripts/webkitpy/layout_tests/views/metered_stream.py:
28 (MeteredStream.implements):
29 (MeteredStream._erasure):
30 (MeteredStream._ensure_newline):
31 (MeteredStream.__init__):
32 (MeteredStream.__del__):
33 (MeteredStream.cleanup):
34 (MeteredStream.write_throttled_update):
35 (MeteredStream.write_update):
36 (MeteredStream.write):
37 (MeteredStream.writeln):
38 (MeteredStream._erase_last_partial_line):
40 (_LogHandler.__init__):
42 * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
45 (RegularTest.tearDown):
46 (RegularTest.time_fn):
47 (RegularTest.test_logging_not_included):
49 (RegularTest.test_basic):
50 (RegularTest._log_after_update):
51 (RegularTest.test_log_after_update):
54 (TtyTest.test_log_after_update):
56 (VerboseTest.test_basic):
57 (VerboseTest.test_log_after_update):
58 * Scripts/webkitpy/layout_tests/views/printing.py:
59 (parse_print_options):
62 (Printer.print_progress):
63 (Printer.print_update):
65 * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
66 (Testprinter.get_printer):
67 (Testprinter.test_print_progress):
68 * Scripts/webkitpy/performance_tests/perftestsrunner.py:
69 (PerfTestsRunner.__init__):
70 * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
71 (test_run_test_pause_before_testing):
73 2012-03-26 Raphael Kubo da Costa <rakuco@FreeBSD.org>
75 [jhbuild] Revert $MAKE environment hack introduced in r101929.
76 https://bugs.webkit.org/show_bug.cgi?id=82234
78 Reviewed by Martin Robinson.
80 The problem it was supposedly fixing was fixed in jhbuild itself
81 in git revision da8944d8ca987ca48c91b350257a530050406092, so we
82 can remove the workaround added to the script.
84 * jhbuild/jhbuild-wrapper:
87 2012-03-26 Leo Yang <leo.yang@torchmobile.com.cn>
89 [BlackBerry] Skeleton code of AsyncFileSystemBlackBerry.cpp
90 https://bugs.webkit.org/show_bug.cgi?id=82157
94 * Scripts/build-webkit:
95 Make ENABLE_FILE_SYSTEM default on for blackberry.
97 2012-03-26 Raphael Kubo da Costa <rakuco@FreeBSD.org>
99 [jhbuild] Explicitly disable DTrace when building glib.
100 https://bugs.webkit.org/show_bug.cgi?id=82145
102 Reviewed by Gustavo Noronha Silva.
104 DTrace support is not really needed by WebKit, so disabling it
105 helps avoid some build errors on more exotic platforms (such as
108 * efl/jhbuild.modules:
109 * gtk/jhbuild.modules:
111 2012-03-26 Sheriff Bot <webkit.review.bot@gmail.com>
113 Unreviewed, rolling out r111993.
114 http://trac.webkit.org/changeset/111993
115 https://bugs.webkit.org/show_bug.cgi?id=82184
117 It broke layout and API tests and made WTR crash (Requested by
120 * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
121 (WTR::PlatformWebView::PlatformWebView):
123 2012-03-25 Kevin Ollivier <kevino@theolliviers.com>
125 [wx] Unreviewed build fix. Move WTF to its own static lib build.
127 * waf/build/settings.py:
130 2012-03-24 Chris Fleizach <cfleizach@apple.com>
132 AX: Support solution to handle invalid ax text marker
133 https://bugs.webkit.org/show_bug.cgi?id=82023
135 Reviewed by Oliver Hunt.
137 * DumpRenderTree/AccessibilityUIElement.cpp:
138 (indexForTextMarkerCallback):
139 (isTextMarkerValidCallback):
140 (textMarkerForIndexCallback):
141 (AccessibilityUIElement::indexForTextMarker):
142 (AccessibilityUIElement::isTextMarkerValid):
143 (AccessibilityUIElement::textMarkerForIndex):
144 (AccessibilityUIElement::getJSClass):
145 * DumpRenderTree/AccessibilityUIElement.h:
146 (AccessibilityUIElement):
147 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
148 (AccessibilityUIElement::indexForTextMarker):
149 (AccessibilityUIElement::textMarkerForIndex):
150 (AccessibilityUIElement::isTextMarkerValid):
151 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
152 (WTR::AccessibilityUIElement::indexForTextMarker):
153 (WTR::AccessibilityUIElement::isTextMarkerValid):
154 (WTR::AccessibilityUIElement::textMarkerForIndex):
156 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
157 (AccessibilityUIElement):
158 * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
159 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
161 (WTR::AccessibilityUIElement::indexForTextMarker):
162 (WTR::AccessibilityUIElement::isTextMarkerValid):
163 (WTR::AccessibilityUIElement::textMarkerForIndex):
165 2012-03-24 Sheriff Bot <webkit.review.bot@gmail.com>
167 Unreviewed, rolling out r112014.
168 http://trac.webkit.org/changeset/112014
169 https://bugs.webkit.org/show_bug.cgi?id=82138
171 Broke SnowLeopard, Chromium and GTK+ bots (Requested by kov on
174 * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
175 (ManagerTest.test_http_locking):
176 * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
177 (AbstractWorker.run):
178 * Scripts/webkitpy/layout_tests/controllers/worker.py:
183 * Scripts/webkitpy/layout_tests/controllers/worker_unittest.py:
184 (WorkerTest.test_default_platform_in_worker):
185 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
188 * Scripts/webkitpy/layout_tests/views/metered_stream.py:
191 (MeteredStream.__init__):
192 (MeteredStream.write):
193 (MeteredStream.update):
194 (MeteredStream._overwrite):
195 (MeteredStream._reset):
196 * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
198 (TestMeteredStream.test_regular):
199 * Scripts/webkitpy/layout_tests/views/printing.py:
200 (_configure_logging):
204 (Printer.print_progress):
205 (Printer.print_update):
209 * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
210 (TestUtilityFunctions.assertEmpty):
211 (TestUtilityFunctions):
212 (TestUtilityFunctions.assertNotEmpty):
213 (TestUtilityFunctions.assertWritten):
214 (TestUtilityFunctions.test_configure_logging):
215 (Testprinter.get_printer):
216 (Testprinter.test_print_progress):
217 (Testprinter.test_print_progress.mock_time):
218 * Scripts/webkitpy/performance_tests/perftestsrunner.py:
219 (PerfTestsRunner.__init__):
220 * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
221 (test_run_test_pause_before_testing):
223 2012-03-24 Kevin Ollivier <kevino@theolliviers.com>
225 [wx] Unreviewed. Fix the build after WTF move.
227 * waf/build/build_utils.py:
229 (get_excludes_in_dirs):
230 * waf/build/settings.py:
234 2012-03-24 Dirk Pranke <dpranke@chromium.org>
236 clean up NRWT logging/metering, be less verbose
237 https://bugs.webkit.org/show_bug.cgi?id=73846
239 Reviewed by Ojan Vafai.
241 This patch totally rewrites the metered_stream module and
242 changes the way it and the printing module now interact with the
245 The printing module becomes a dumb layout_tests-specific wrapper around
246 the metered stream. All of the intelligence of how and when to
247 actually write (or erase) lines and how things interact with
248 logging moves into the metered stream.
250 As of now, anything written to the metered stream *bypasses the
251 logging system*. If a logger is passed to the meter constructor,
252 the metered stream will also attach a log handler so that all
253 messages fed to the logger will also be written to the metered
254 stream. This detangles the logic that used to exist where
255 sometimes the meter would write to the logger and sometimes the
256 logger would write to the meter.
258 All of this makes the logic generic and reusable for
259 test-webkitpy (coming in another patch). It also helps clarify
260 what the mysterious "configure_logging" parameter to the printer
261 constructor used to do (that parameter itself is gone now, and
262 by default the printer and metered_stream will not ever touch
263 the logging system; this makes a bunch of tests less fragile).
265 All of the above should produce no user-visible changes.
267 However, to also fix the bug in question, we change the message
268 format in --verbose mode to %H:%M:%S.%frac %pid %message,
269 eliminating the date, file:lineno, and level parameters. I am
270 making this change at the same time because it would be
271 difficult to write things consistently between the logs and the
272 metered stream if we were still logging the file:lineno.
274 * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
275 Remove the configure_logging parameter
276 * Scripts/webkitpy/layout_tests/controllers/worker.py:
277 Use metered stream to configure the logging (we don't need a printer)
278 and be careful about when and how we manipulate the log level
279 and handlers on the root logger.
280 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
281 Pass in the root logger so that log messages are formatted
282 properly, and set the log level outside of any routines called
283 by unit tests so as to not interfere.
284 * Scripts/webkitpy/layout_tests/views/manager_worker_broker.py:
285 remove a duplicate log message.
286 * Scripts/webkitpy/layout_tests/views/metered_stream.py:
288 * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
290 * Scripts/webkitpy/layout_tests/views/printing.py:
291 move the logging configuration into metered_stream, and also
292 move the "when should I log progress messages" into metered stream.
293 * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
294 remove tests that are no longer necessary.
295 * Scripts/webkitpy/performance_tests/perftestsrunner.py:
296 remove the configure_logging parameter.
297 * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
298 update the test; since the printer no longer writes to the log,
299 we need to check what is written to the regular_output instead.
300 (test_run_test_pause_before_testing):
302 2012-03-24 Gustavo Noronha Silva <gns@gnome.org>
304 Add myself and Martin Robinson to:
306 * GtkWebKit2PublicAPI
308 and to the newly created WebKitGTKTranslations.
310 Rubber-stamped by Martin Robinson.
312 * Scripts/webkitpy/common/config/watchlist:
314 2012-03-24 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
316 [Qt][WK2] Implement PageClient::isViewWindowActive()
317 https://bugs.webkit.org/show_bug.cgi?id=81143
319 Reviewed by Kenneth Rohde Christiansen.
321 Fix the WrapperWindow from our PlatformWebView
322 so it correctly creates the platform related
323 stuff for QWindow, which is not created unless
324 QWindow::setVisible() or QWindow::show() are called.
326 * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
327 (WTR::PlatformWebView::PlatformWebView):
329 2012-03-23 Dirk Pranke <dpranke@chromium.org>
331 nrwt: don't wait for safari to exit before exiting after showing the results file
332 https://bugs.webkit.org/show_bug.cgi?id=81845
334 Reviewed by Ryosuke Niwa.
336 Prior to this change, if you ran new-run-webkit-tests and
337 displayed the HTML results file at the end, we would block
338 waiting for the user to quit the browser. There doesn't seem to
339 be a need for that, and the Chromium ports don't do this.
341 Also, update the mac tests to capture the output and be quiet :).
343 * Scripts/webkitpy/common/system/executive_mock.py:
344 Make popen() testable, implement should_log for it.
345 * Scripts/webkitpy/layout_tests/port/mac.py:
346 (MacPort.show_results_html_file):
347 * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
348 Silence some of the tests via outputcapture.
350 2012-03-23 Gustavo Noronha Silva <gns@gnome.org>
352 [GTK] libgcrypt and p11-kit should not be in jhbuild modules
353 https://bugs.webkit.org/show_bug.cgi?id=82073
355 Reviewed by Martin Robinson.
357 * Scripts/webkitdirs.pm:
358 (jhbuildConfigurationChanged): new function that isolates the
359 jhbuild configuration change checking from the autogen logic.
360 (mustReRunAutogen): code for the new function lived here.
361 (buildAutotoolsProject): now calls jhbuildConfigurationChanged
362 itself, and cleans up the jhbuild root if configuration has
363 changed; it also forces autogen to be run in that case, to
364 make sure the new libraries are used.
365 * gtk/jhbuild.modules: removed libgcrypt and p11-kit.
366 * jhbuild/jhbuild-wrapper:
367 (ensure_jhbuild): this might be run inside a jhbuild environment,
368 in which case aclocal fails when trying to use the now deleted
369 aclocal directory in the jhbuild prefix, so work around that.
371 2012-03-23 Ojan Vafai <ojan@chromium.org>
373 garden-o-matic scrolls to the top of the page when you click an accordion item
374 https://bugs.webkit.org/show_bug.cgi?id=82088
376 Reviewed by Adam Barth.
378 Check the scroll position and make sure that the clicked accordion item is visible.
380 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
382 2012-03-23 Dirk Pranke <dpranke@chromium.org>
384 LayoutTestHelper could get torn down earlier (mostly to reset color profile)
385 https://bugs.webkit.org/show_bug.cgi?id=80567
387 Reviewed by Ryosuke Niwa.
389 Move clean_up_run to occur right after we finish testing and
390 before we start processing the results. Also makes set_up_run()
391 and clean_up_run() private since there's no real need for
392 callers to be aware of them.
394 * Scripts/webkitpy/layout_tests/controllers/manager.py:
395 (Manager._set_up_run):
397 (Manager._clean_up_run):
398 * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
399 (ManagerTest.test_http_locking):
400 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
403 2012-03-23 Dean Jackson <dino@apple.com>
405 Disable CSS_SHADERS in Apple builds
406 https://bugs.webkit.org/show_bug.cgi?id=81996
408 Reviewed by Simon Fraser.
410 Default enableCSSShaders to be 0 on all builds that use
411 this script. Use the flag to turn it back on.
413 * Scripts/build-webkit:
415 2012-03-23 Tony Chang <tony@chromium.org>
417 [chromium] rename newwtf target back to wtf
418 https://bugs.webkit.org/show_bug.cgi?id=82064
420 Reviewed by Adam Barth.
422 * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
424 2012-03-23 Jessie Berlin <jberlin@apple.com>
426 Assertion failure in PlatformPasteboardMac constructor causing multiple tests to "crash" on
427 the Lion Intel WebKit2 Debug bots.
428 https://bugs.webkit.org/show_bug.cgi?id=81012.
430 Rubber-stamped by Dan Bernstein.
432 Add a step to kill the pasteboard server while we investigate what is causing these
433 assertion failures (to get the bots green).
435 * BuildSlaveSupport/kill-old-processes:
437 2012-03-22 Martin Robinson <mrobinson@igalia.com>
439 [check-webkit-style] Alphabetical sorting errors in headers are reported for the line after the first out of order header
440 https://bugs.webkit.org/show_bug.cgi?id=81986
442 Reviewed by David Levin.
444 Track whether or not errors are filtered in error handlers. If an
445 alphabetical sorting error is reported for a header and filtered, try
446 reporting it for the other potential source of the error. This ensures
447 that the style bot can still find new sorting errors in both potential
450 #include <foo.h> <-- 1. edited line
451 #include <baz.h> <-- 2. edited line
453 * Scripts/webkitpy/style/checkers/cpp.py:
454 (check_include_line): Potentially report the error for both lines,
455 if the first error is filtered.
456 * Scripts/webkitpy/style/checkers/cpp_unittest.py: Implement a new style of
457 test that allows only reporting errors for certain lines. This verifies that
458 when one line of an ordering error is filtered, the error is reported on the
460 (ErrorCollector.__init__):
461 (ErrorCollector.__call__):
462 (CppStyleTestBase.perform_lint):
463 (CppStyleTestBase.perform_language_rules_check):
464 (CppStyleTestBase.assert_language_rules_check):
465 (OrderOfIncludesTest.test_check_alphabetical_include_order_errors_reported_for_both_lines):
466 Added a new test that verifies that when one line of the two lines of an ordering
467 error occur, the error is reported on the other line.
468 * Scripts/webkitpy/style/checkers/jsonchecker_unittest.py:
469 (MockErrorHandler.__call__): Report True because the error is handled.
470 * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
471 (ErrorCollector.__call__): Ditto.
472 * Scripts/webkitpy/style/checkers/watchlist_unittest.py:
473 (MockErrorHandler.__call__): Ditto.
474 * Scripts/webkitpy/style/checkers/xcodeproj_unittest.py:
475 (TestErrorHandler.__call__): Ditto.
476 * Scripts/webkitpy/style/checkers/xml_unittest.py:
477 (MockErrorHandler.__call__): Ditto.
478 * Scripts/webkitpy/style/error_handlers.py:
479 (DefaultStyleErrorHandler.__call__): Report True if the error is handled
480 and False if it is filtered.
482 2012-03-23 Patrick Gansterer <paroga@webkit.org>
484 Build fix for WinCE after r111778.
486 * WinCELauncher/CMakeLists.txt:
488 2012-03-23 Peter Beverloo <peter@chromium.org>
490 Unreviewed buildfix for the Chromium Android builder.
492 Disable the ImageDiff target for now. Android needs to build this for
493 host rather than for target (as other configurations do), but since the
494 WTF move the dependency chain got significantly more complicated.
496 I'll work out a proper fix in the following bug, but since several
497 things are broken due to this, this buildfix should be landed first.
498 https://bugs.webkit.org/show_bug.cgi?id=82039
500 * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
502 2012-03-23 Grzegorz Czajkowski <g.czajkowski@samsung.com>
504 [EFL][DRT] Implement LayoutTestController's methods related with editing.
505 https://bugs.webkit.org/show_bug.cgi?id=80136
507 Reviewed by Ryosuke Niwa.
509 Implements EFL's LayoutTestController methods e.i. setSmartInsertDeleteEnabled,
510 setSelectTrailingWhitespaceEnabled.
512 * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
513 (LayoutTestController::setSmartInsertDeleteEnabled):
514 (LayoutTestController::setSelectTrailingWhitespaceEnabled):
516 2012-03-22 Gyuyoung Kim <gyuyoung.kim@samsung.com>
518 Convert hasGrammarMarker to use Internals interface
519 https://bugs.webkit.org/show_bug.cgi?id=82004
521 Reviewed by Ryosuke Niwa.
523 Remove hasGrammarMarker functions, because it is able to work in the
524 cross-port way through the Internals interface.
526 * DumpRenderTree/LayoutTestController.cpp:
527 (LayoutTestController::staticFunctions):
528 * DumpRenderTree/LayoutTestController.h:
529 (LayoutTestController):
530 * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
531 * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
532 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
533 * DumpRenderTree/mac/LayoutTestControllerMac.mm:
534 * DumpRenderTree/win/LayoutTestControllerWin.cpp:
535 * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
537 2012-03-22 Adam Barth <abarth@webkit.org>
539 sync-master-with-upstream creates non-linear git history
540 https://bugs.webkit.org/show_bug.cgi?id=82006
542 Reviewed by Julien Chaffraix.
544 Previously this script would create a merge commit at the HEAD of
545 origin/master, causing your fork of WebKit to diverge from upstream.
546 The new version of this script pushes directly from upstream to origin
547 (without round-tripping through any local branches), avoiding this
550 * Scripts/sync-master-with-upstream:
552 2012-03-22 Gustavo Noronha Silva <gns@gnome.org>
554 Unreviewed build fix. Add knowledge of the WTF project to
555 the autotools build system scripts so that build-jsc works
558 * Scripts/webkitdirs.pm:
559 (buildAutotoolsProject): handle the WTF project, build the
561 (buildGtkProject): add WTF to the list of supported projects.
563 2012-03-22 Eric Seidel <eric@webkit.org>
565 Make svn-apply re-write JavaScriptCore/wtf to WTF/wtf
566 https://bugs.webkit.org/show_bug.cgi?id=81984
568 Reviewed by Adam Barth.
570 * Scripts/VCSUtils.pm:
571 (adjustPathForRecentRenamings):
573 2012-03-22 Raphael Kubo da Costa <rakuco@FreeBSD.org>
575 [CMake] Fix build-jsc after r111778 and r111797.
576 https://bugs.webkit.org/show_bug.cgi?id=82001
578 Reviewed by Filip Pizlo.
580 Contrary to the comment in build-jsc, buildCMakeProjectOrExit()
581 does return if no error occurred, and build-jsc failed with
582 "building not defined for this platform".
584 * Scripts/build-jsc: Always exit after caling
585 buildCMakeProjectOrExit().
586 * Scripts/webkitdirs.pm:
587 (buildCMakeProjectOrExit): Return 0 if no error occurred.
589 2012-03-22 Raphael Kubo da Costa <rakuco@FreeBSD.org>
591 [CMake] Unreviewed build fix after r111778.
593 * DumpRenderTree/efl/CMakeLists.txt: Replace
594 ${JAVASCRIPTCORE_DIR}/wtf with ${WTF_DIR}/wtf in the include
596 * DumpRenderTree/efl/LayoutTestControllerEfl.cpp: Use the right
598 * DumpRenderTree/efl/WorkQueueItemEfl.cpp: Ditto.
599 * WinCELauncher/CMakeLists.txt: Replace ${JAVASCRIPTCORE_DIR}/wtf
600 with ${WTF_DIR}/wtf in the include paths.
602 2012-03-22 Filip Pizlo <fpizlo@apple.com>
604 Tools/Scripts/build-jsc doesn't work after WTF move
605 https://bugs.webkit.org/show_bug.cgi?id=81999
607 Reviewed by Eric Seidel.
609 For ports that require WTF and JSC to be built as two projects and where
610 the machinery to build both does not already exist, teach the tool to do
616 2012-03-22 Ojan Vafai <ojan@chromium.org>
618 Fix accidental missing line in r111793.
620 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
621 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
622 Remove base.values. It was unused and duplicates the builtin Object.values.
623 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
624 Accidentally deleted this line before committing r111793.
626 2012-03-22 Ojan Vafai <ojan@chromium.org>
628 Move garden-o-matic progress feedback from non-modal dialogs to a status console anchored to the bottom of the page
629 https://bugs.webkit.org/show_bug.cgi?id=81983
631 Reviewed by Adam Barth.
633 The dialogs get in the way if you are doing multiple rebaselines. Also,
634 a number of people didn't realize that you could do multiple rebaselines
635 in parallel. A non-modal dialog is just confusing.
637 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
638 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
639 If we're only rebaselining 1 test, show the test name in the initial message. Otherwise,
640 show the number of tests being rebaselined.
642 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
643 Turn MessageBox into StatusArea. StatusArea is a singleton and messages in the StatusArea are grouped
644 by ID. That way, the results of each UI action (e.g. clicking rebaseline) are grouped together
647 Once addFinalMessage has been called for all IDs, we show the close button. Clicking close
648 also serves to clear all teh content in the StatusArea.
650 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
651 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
653 2012-03-22 Tony Chang <tony@chromium.org>
655 Unreviewed, fix chromium build after wtf move.
657 Only use newwtf, remove references to wtf.
659 * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
661 2012-03-22 Csaba Osztrogonác <ossy@webkit.org>
663 Actually move WTF files to their new home
664 https://bugs.webkit.org/show_bug.cgi?id=81844
666 [Qt] Unreviewed buildfix after r111778.
668 * DumpRenderTree/qt/DumpRenderTree.pro:
670 2012-03-22 Dan Bernstein <mitz@apple.com>
672 Font fallback in WebKitTestRunner depends on user settings
673 https://bugs.webkit.org/show_bug.cgi?id=81978
675 Reviewed by Jessie Berlin.
677 * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
678 (WTR::InjectedBundle::platformInitialize): Added an AppleLanguages key
679 with a value consisting of the array ("en") to the override defaults
680 dictionary. This is the same value used in DumpRenderTree, and it
681 ensures that font fallback follows a consistent path that is not
682 affected by the language preferences of the user running the test.
684 2012-03-22 Andy Estes <aestes@apple.com>
686 check-for-inappropriate-objc-class-names should ignore the class defined by libarclite.
687 https://bugs.webkit.org/show_bug.cgi?id=81971
689 Reviewed by Dan Bernstein.
691 Xcode will automatically link ObjC binaries against libarclite in some
692 cases, which defines a class called __ARCLite__.
693 check-for-inappropriate-objc-class-names shouldn't complain about this
696 * Scripts/check-for-inappropriate-objc-class-names:
698 2012-03-22 Dirk Pranke <dpranke@chromium.org>
700 new-run-webkit-tests blames the wrong test for crashing
701 https://bugs.webkit.org/show_bug.cgi?id=81951
703 Reviewed by Adam Barth.
705 NRWT wasn't extracting the WebProcess pid correct; should've
706 used re.search instead of re.match :(. Add more tests!
708 * Scripts/webkitpy/layout_tests/port/mac.py:
709 (MacPort._get_crash_log):
710 * Scripts/webkitpy/layout_tests/port/webkit.py:
711 (WebKitDriver.has_crashed):
712 (WebKitDriver._check_for_driver_crash):
713 * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
714 (WebKitDriverTest.test_no_timeout):
716 (WebKitDriverTest.test_check_for_driver_crash):
717 (WebKitDriverTest.test_check_for_driver_crash.FakeServerProcess):
718 (WebKitDriverTest.test_check_for_driver_crash.FakeServerProcess.__init__):
719 (WebKitDriverTest.test_check_for_driver_crash.FakeServerProcess.pid):
720 (WebKitDriverTest.test_check_for_driver_crash.FakeServerProcess.name):
721 (WebKitDriverTest.test_check_for_driver_crash.FakeServerProcess.has_crashed):
722 (WebKitDriverTest.test_check_for_driver_crash.assert_crash):
724 2012-03-22 Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com>
726 [EFL] [DRT] Implement LayoutTestController::markerTextForListItem()
727 https://bugs.webkit.org/show_bug.cgi?id=81512
729 Adding missing implementation markerTextForListItem to EFL's
730 LayoutTestController so that we can unskip related tests from
733 Reviewed by Antonio Gomes.
735 * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
736 (LayoutTestController::markerTextForListItem): Implemented.
738 2012-03-22 Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com>
740 [EFL] Enable view mode media feature layout tests
741 https://bugs.webkit.org/show_bug.cgi?id=81205
743 Adding missing implementation setViewModeMediaFeature to EFL's
744 LayoutTestController so that we can unskip view mode
745 media feature layout tests.
747 Reviewed by Antonio Gomes.
749 * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
750 (LayoutTestController::setViewModeMediaFeature): Implemented.
752 2012-03-22 Dirk Pranke <dpranke@chromium.org>
754 nrwt: crash while stopping layout test helper on apple mac lion
755 https://bugs.webkit.org/show_bug.cgi?id=81949
757 Reviewed by Eric Seidel.
759 stop_helper() didn't work right if the helper process wasn't
760 still running or didn't respond properly to being shut down. Fix
761 this and add some tests. Also add code to MockExecutive() to be
762 able to mock executive.popen() properly.
764 * Scripts/webkitpy/common/system/executive_mock.py:
765 (MockProcess.__init__):
767 (MockExecutive.__init__):
768 (MockExecutive.popen):
769 * Scripts/webkitpy/common/system/systemhost_mock.py:
770 (MockSystemHost.__init__):
771 * Scripts/webkitpy/layout_tests/port/mac.py:
772 (MacPort.start_helper):
773 (MacPort.stop_helper):
774 * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
775 (test_get_crash_log):
776 (test_helper_starts):
777 (test_helper_fails_to_start):
778 (test_helper_fails_to_stop):
779 (test_helper_fails_to_stop.bad_waiter):
781 2012-03-22 Gustavo Noronha Silva <gns@gnome.org>
783 [GTK] Add make to the jhbuild moduleset
784 https://bugs.webkit.org/show_bug.cgi?id=81769
786 Reviewed by Martin Robinson.
788 Mostly based on a patch by Carlos Garcia Campos <cgarcia@igalia.com>.
789 Add GNU make with custom patches to fix several issues:
791 - make-3.82-arg-list-length.patch: Patch by Ralf Wildenhues to
792 fix the argument list limit of GNU make when running make
794 - make-3.82-parallel-build.patch: Patch by Kamil Mierzejewski
795 and Jeremy Devenport to fix parallel build issues present in
798 * gtk/jhbuild.modules: Added make with patches.
799 * gtk/patches/make-3.82-arg-list-length.patch: Added.
800 * gtk/patches/make-3.82-parallel-build.patch: Added.
802 2012-03-22 Kevin Ollivier <kevino@theolliviers.com>
804 [wx] Unreviewed. Adding Source/WTF to the build and updating
807 * DumpRenderTree/wscript:
808 * waf/build/settings.py:
810 2012-03-22 Dirk Pranke <dpranke@chromium.org>
812 Re-land fix for r81603 yet again (!) with latest build fix.
813 https://bugs.webkit.org/show_bug.cgi?id=81603
815 Unreviewed, build fix.
817 The latest problem was a bad sprintf() in
818 BasePort._get_crash_log(). I've reworked that routine and added
819 unit tests for coverage.
821 * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
822 (SingleTestRunner._handle_error):
823 * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
825 (TestResultWriter.write_crash_log):
826 * Scripts/webkitpy/layout_tests/port/base.py:
828 (Port._get_crash_log):
829 * Scripts/webkitpy/layout_tests/port/chromium.py:
830 (ChromiumDriver.run_test):
831 * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
832 (ChromiumDriverTest.test_crash_log):
833 * Scripts/webkitpy/layout_tests/port/driver.py:
834 (DriverOutput.__init__):
835 * Scripts/webkitpy/layout_tests/port/mac.py:
837 (MacPort._get_crash_log):
838 * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
839 (test_default_child_processes):
840 (test_get_crash_log):
841 * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
842 (MockDRTPortTest.test_get_crash_log):
843 * Scripts/webkitpy/layout_tests/port/port_testcase.py:
844 (PortTestCase.test_get_crash_log):
845 * Scripts/webkitpy/layout_tests/port/test.py:
846 (TestDriver.run_test):
847 * Scripts/webkitpy/layout_tests/port/webkit.py:
848 (WebKitDriver.__init__):
849 (WebKitDriver._start):
850 (WebKitDriver.has_crashed):
851 (WebKitDriver._check_for_driver_crash):
852 (WebKitDriver.run_test):
854 2012-03-22 Alexander Færøy <alexander.faeroy@nokia.com>
856 [Qt] Enable support for handling database quota's in the MiniBrowser
857 https://bugs.webkit.org/show_bug.cgi?id=81928
859 Reviewed by Simon Hausmann.
861 * MiniBrowser/qt/qml/BrowserWindow.qml:
863 2012-03-22 Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com>
865 [EFL] Implement LayoutTestController::setEditingBehavior
866 https://bugs.webkit.org/show_bug.cgi?id=81124
868 Adding missing implementation setEditingBehavior to EFL's
869 LayoutTestController. This implementation allows us to
870 unskip some tests from the skip list.
872 Reviewed by Martin Robinson.
874 * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
875 (LayoutTestController::setEditingBehavior): Implemented.
877 2012-03-22 Carlos Garcia Campos <cgarcia@bb-webkit-rel-64.local.igalia.com>
879 [GTK] Use the angle-bracket form to include wtf headers
880 https://bugs.webkit.org/show_bug.cgi?id=81884
882 Reviewed by Eric Seidel.
884 Use #include <wtf/foo> instead of #include "foo".
886 * DumpRenderTree/gtk/AccessibilityCallbacks.cpp:
887 * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
888 * DumpRenderTree/gtk/DumpRenderTree.cpp:
889 * DumpRenderTree/gtk/EditingCallbacks.cpp:
890 * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
891 * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
893 2012-03-22 Alexander Færøy <alexander.faeroy@nokia.com>
895 Unreviewed, add Michael BrĂĽning and Allan Jensen to committers.py.
897 * Scripts/webkitpy/common/config/committers.py:
899 2012-03-22 Allan Sandfeld Jensen <allan.jensen@nokia.com>
901 [Qt] Enable FAST_MOBILE_SCROLLING when scrolling is delegated.
902 https://bugs.webkit.org/show_bug.cgi?id=81889
904 Reviewed by Kenneth Rohde Christiansen.
906 Enable FAST_MOBILE_SCROLLING feature.
908 * qmake/mkspecs/features/features.prf:
910 2012-03-22 Raphael Kubo da Costa <rakuco@FreeBSD.org>
912 [EFL] DRT: Do not pass a relative path to DOWNLOADED_FONTS_DIR.
913 https://bugs.webkit.org/show_bug.cgi?id=81900
915 Reviewed by Gustavo Noronha Silva.
917 r111598 added the DOWNLOADED_FONTS_DIR define, but it used a relative
918 path which assumed a certain directory structure for the build
919 directory which may noy be true.
921 Instead, hardcode the path to the downloaded fonts starting from the
922 top-level source directory. While this solution is also far from
923 perfect, it makes it more consistent and reliable, and easier to
924 tackle at once with the rest of bug 81475.
926 * DumpRenderTree/efl/CMakeLists.txt:
928 2012-03-22 Carlos Garcia Campos <cgarcia@igalia.com>
930 [GTK] Allow to run any jhbuild command with jhbuild-wrapper script
931 https://bugs.webkit.org/show_bug.cgi?id=81888
933 Reviewed by Philippe Normand.
935 * Scripts/update-webkit-libs-jhbuild:
936 (runJhbuild): Helper function to run jhbuild with a given command.
937 Instead of running jhbuild directly, use the jhbuild-wrapper, so
938 that we don't need to run it first to check whether jhbuild is
940 * efl/run-with-jhbuild: Call jhbuild-wrapper with run command.
941 * gtk/run-with-jhbuild: Ditto.
942 * jhbuild/jhbuild-wrapper: Allow to execute any jhbuild command,
945 2012-03-22 Philippe Normand <pnormand@igalia.com>
947 Unreviewed, test-webkitpy fix after r111661.
949 * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
950 (MainTest.test_crash_log):
951 (MainTest.test_web_process_crash_log):
953 2012-03-22 Philippe Normand <pnormand@igalia.com>
955 Unreviewed, test-webkitpy fix after r111642.
957 * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
958 (ChromiumDriverTest.setUp):
959 (ChromiumDriverTest.test_two_drivers):
961 2012-03-22 Csaba Osztrogonác <ossy@webkit.org>
963 webkitpy: clean up actually getting crash logs from DRT/WTR crashes
964 https://bugs.webkit.org/show_bug.cgi?id=81603
966 Unreviewed rolling out r111609 and part of r111615,
967 because it broke NRWT on Qt-WK2 platform.
969 * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
970 (SingleTestRunner._handle_error):
971 * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
973 (TestResultWriter.write_crash_report):
974 * Scripts/webkitpy/layout_tests/port/base.py:
975 (Port.is_crash_reporter):
976 (Port._driver_class):
977 * Scripts/webkitpy/layout_tests/port/chromium.py:
978 (ChromiumDriver.run_test):
979 * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
980 (ChromiumDriverTest.test_crashed_process_name):
981 * Scripts/webkitpy/layout_tests/port/driver.py:
982 (DriverOutput.__init__):
983 * Scripts/webkitpy/layout_tests/port/mac.py:
985 (MacPort.is_crash_reporter):
986 (MacPort.release_http_lock):
987 * Scripts/webkitpy/layout_tests/port/test.py:
988 (TestDriver.run_test):
989 * Scripts/webkitpy/layout_tests/port/webkit.py:
990 (WebKitDriver.__init__):
991 (WebKitDriver._start):
992 (WebKitDriver.has_crashed):
993 (WebKitDriver._check_for_driver_crash):
994 (WebKitDriver.run_test):
996 2012-03-22 Csaba Osztrogonác <ossy@webkit.org>
998 [Qt] Add full platforms to Qt buildslaves
999 https://bugs.webkit.org/show_bug.cgi?id=81877
1001 Reviewed by Ryosuke Niwa.
1003 * BuildSlaveSupport/build.webkit.org-config/config.json:
1005 2012-03-21 Johnny Ding <jnd@chromium.org>
1007 Customize layout test timeout value for different ports.
1008 https://bugs.webkit.org/show_bug.cgi?id=79859
1010 Reviewed by Ojan Vafai.
1012 * Scripts/webkitpy/layout_tests/controllers/manager.py:
1014 * Scripts/webkitpy/layout_tests/port/base.py:
1015 (Port.default_test_timeout_ms):
1016 * Scripts/webkitpy/layout_tests/port/chromium.py:
1017 (ChromiumDriver.stop):
1018 * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1019 (ChromiumAndroidPort.default_test_timeout_ms):
1020 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1021 (_set_up_derived_options):
1023 2012-03-21 Mark Rowe <mrowe@apple.com>
1027 Ensure that our test tools don't try and use RTTI unnecessarily.
1029 * DumpRenderTree/mac/Configurations/Base.xcconfig:
1030 * TestWebKitAPI/Configurations/Base.xcconfig:
1031 * WebKitTestRunner/Configurations/Base.xcconfig:
1033 2012-03-21 Adam Barth <abarth@webkit.org>
1035 WebKit should have some scripts to smooth interactions with GitHub
1036 https://bugs.webkit.org/show_bug.cgi?id=81842
1038 Reviewed by Eric Seidel.
1040 These scripts support the workflow in
1041 https://trac.webkit.org/wiki/UsingGitHub by automating the
1042 configuration and syncing operations needed for a GitHub fork of WebKit
1043 to track the main WebKit repository.
1045 * Scripts/configure-github-as-upstream: Added.
1046 * Scripts/sync-master-with-upstream: Added.
1048 2012-03-21 Dirk Pranke <dpranke@chromium.org>
1050 WTR - log the pid of a crashing WebProcess
1051 https://bugs.webkit.org/show_bug.cgi?id=81575
1053 Reviewed by Alexey Proskuryakov.
1055 This allows run-webkit-tests to find the right crash log for a
1056 given crashed WebProcess in WebKit2.
1058 * WebKitTestRunner/TestController.cpp:
1059 (WTR::exceededDatabaseQuota):
1060 (WTR::TestController::createOtherPage):
1061 (WTR::TestController::initialize):
1062 (WTR::TestController::resetStateToConsistentValues):
1063 (WTR::TestController::runTest):
1064 (WTR::TestController::processDidCrash):
1066 2012-03-21 Enrica Casucci <enrica@apple.com>
1068 WebKitURLWithTitles pasteboard format should support URLs containing Emoji characters.
1069 https://bugs.webkit.org/show_bug.cgi?id=81835
1070 <rdar://problem/11082749>
1072 Reviewed by Brady Eidson.
1074 * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.html:
1075 * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm:
1076 (TestWebKitAPI::contextMenuCopyLink):
1078 2012-03-21 Alexandru Chiculita <achicu@adobe.com>
1080 [CSS Shaders] Make CSS Shaders compile on Chromium
1081 https://bugs.webkit.org/show_bug.cgi?id=81435
1083 Reviewed by Stephen White.
1085 I've added WebKitCSSCustomFilterEnabled support for the layoutTestController.overridePreference function.
1087 * DumpRenderTree/chromium/LayoutTestController.cpp:
1088 (LayoutTestController::overridePreference):
1089 * DumpRenderTree/chromium/WebPreferences.cpp:
1090 (WebPreferences::reset):
1091 (WebPreferences::applyTo):
1092 * DumpRenderTree/chromium/WebPreferences.h:
1095 2012-03-21 Dirk Pranke <dpranke@chromium.org>
1097 fix regression on gtk port introduced by r111609
1098 https://bugs.webkit.org/show_bug.cgi?id=81839
1100 Reviewed by Philippe Normand.
1102 r111609 should've initialized a couple of missing fields in
1103 WebKitDriver, and also should've checked for method overrides
1104 in the other ports :(.
1106 * Scripts/webkitpy/layout_tests/port/gtk.py:
1108 * Scripts/webkitpy/layout_tests/port/webkit.py:
1109 (WebKitDriver.__init__):
1110 * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1111 (MainTest.test_crash_log):
1112 (MainTest.test_web_process_crash_log):
1114 2012-03-21 Dirk Pranke <dpranke@chromium.org>
1116 webkitpy: clean up actually getting crash logs from DRT/WTR crashes
1117 https://bugs.webkit.org/show_bug.cgi?id=81603
1119 Reviewed by Adam Barth.
1121 Add a new _get_crash_log() overridable method on the Port
1122 object to customize how we fetch crash logs per port.
1123 Mac will now slow-spin with a timeout waiting for the crash log, rather
1124 than waiting for the ReportCrash process to exit (it appears
1125 that the mac will manage multiple crashes with a single
1126 ReportCrash process, the process waits around longer than
1127 necessary, presumably to avoid thrashing if processes are
1128 repeatedly crashing).
1130 Also, add the DriverOutput should contain the crash log and other info,
1131 which is created in a port-specific manner but can then be
1132 treated generically. Previously single_test_runner would get
1133 told that something crashed and attempt to do something to get
1134 the crash log, but it didn't have the information it needed to
1135 od the right thing; better to make the driver hand back the
1138 * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1139 (SingleTestRunner._handle_error):
1140 * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1141 (write_test_result):
1142 (TestResultWriter.write_crash_log):
1143 * Scripts/webkitpy/layout_tests/port/base.py:
1145 (Port._get_crash_log):
1146 * Scripts/webkitpy/layout_tests/port/chromium.py:
1147 (ChromiumDriver.run_test):
1148 * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1149 (ChromiumDriverTest.test_crash_log):
1150 * Scripts/webkitpy/layout_tests/port/driver.py:
1151 (DriverOutput.__init__):
1152 * Scripts/webkitpy/layout_tests/port/mac.py:
1154 (MacPort._get_crash_log):
1155 * Scripts/webkitpy/layout_tests/port/test.py:
1156 (TestDriver.run_test):
1157 * Scripts/webkitpy/layout_tests/port/webkit.py:
1158 (WebKitDriver.__init__):
1159 (WebKitDriver._start):
1160 (WebKitDriver.has_crashed):
1161 (WebKitDriver._check_for_driver_crash):
1162 (WebKitDriver.run_test):
1164 2012-03-21 Dominik Röttsches <dominik.rottsches@linux.intel.com>
1166 [EFL] Use jhbuild downloaded fonts instead of hardcoded system font paths
1167 https://bugs.webkit.org/show_bug.cgi?id=81507
1169 Now that we're only loading from one directory, no need to
1170 iterate over a list of directories anymore.
1172 Reviewed by Martin Robinson.
1174 * DumpRenderTree/efl/CMakeLists.txt:
1175 * DumpRenderTree/efl/FontManagement.cpp:
1177 (addFontsToEnvironment):
1179 2012-03-21 Dirk Pranke <dpranke@chromium.org>
1181 webkitpy: get ServerProcess out of the reportcrash business
1182 https://bugs.webkit.org/show_bug.cgi?id=81600
1184 Unreviewed, build fix.
1186 Re-land r111307 and r111293 with another fix for a crash in NRWT;
1187 we need to check if the driver has crashed before attempting to
1191 * Scripts/webkitpy/layout_tests/port/server_process.py:
1192 (ServerProcess._reset):
1193 (ServerProcess._handle_possible_interrupt):
1194 (ServerProcess.write):
1195 (ServerProcess.read_stdout):
1196 (ServerProcess.has_crashed):
1197 (ServerProcess._read):
1198 (ServerProcess.stop):
1199 * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
1200 (TrivialMockPort.check_for_leaks):
1201 (TestServerProcess.test_broken_pipe):
1202 * Scripts/webkitpy/layout_tests/port/webkit.py:
1203 (WebKitPort._read_image_diff):
1204 (WebKitDriver.has_crashed):
1205 (WebKitDriver._check_for_driver_crash):
1206 (WebKitDriver.run_test):
1207 (WebKitDriver._read_block):
1208 * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1209 (MockServerProcess.__init__):
1210 (MockServerProcess):
1211 (MockServerProcess.has_crashed):
1213 2012-03-21 Zeno Albisser <zeno@webkit.org>
1215 [Qt][Mac] ranlib segfaults when creating symbol tables for libWebCore.a.
1216 https://bugs.webkit.org/show_bug.cgi?id=81750
1218 Building WebCore on mac currently creates an archive that is bigger than
1219 4GB. But ranlib fails to create a symbol table for such a big archive,
1220 even on 64bit machines.
1221 Therefore we start using SVGAllInOne.cpp when building debug
1222 on mac. This reduces the size of the archive by about 300MB.
1224 Reviewed by Tor Arne Vestbø.
1226 * qmake/mkspecs/features/mac/default_pre.prf:
1228 2012-03-21 Szilard Ledan <szledan@inf.u-szeged.hu>
1230 Updated the address list of committers.py.
1232 Reviewed by Csaba Osztrogonác.
1234 * Scripts/webkitpy/common/config/committers.py:
1236 2012-03-21 W. James MacLean <wjmaclean@chromium.org>
1238 Updating my nick in committers file.
1242 * Scripts/webkitpy/common/config/committers.py:
1244 2012-03-21 Peter Beverloo <peter@chromium.org>
1246 [Chromium] Remove Android build-fix when the proper fix rolled into WebKit
1247 https://bugs.webkit.org/show_bug.cgi?id=80861
1249 Reviewed by Tony Chang.
1251 Remove most Android-specific logic from webkitdirs.pm in favor of
1252 handling this during project generation time.
1254 * Scripts/webkitdirs.pm:
1255 (buildChromiumMakefile):
1257 2012-03-21 Carlos Garcia Campos <cgarcia@igalia.com>
1259 [GTK] Allow running javascript from location bar in MiniBrowser
1260 https://bugs.webkit.org/show_bug.cgi?id=81331
1262 Reviewed by Martin Robinson.
1264 * MiniBrowser/gtk/BrowserWindow.c:
1265 (activateUriEntryCallback): Use browser_window_load_uri().
1266 (browser_window_load_uri): Check whether uri starts with
1267 javascript: and run the given script, or just call
1268 webkit_web_view_load_uri() to load the given uri.
1269 * MiniBrowser/gtk/BrowserWindow.h:
1270 * MiniBrowser/gtk/main.c:
1271 (createBrowserWindow): Use browser_window_load_uri().
1273 2012-03-21 Carlos Garcia Campos <cgarcia@igalia.com>
1275 [GTK] Add webkit_web_view_run_javascript() to WebKit2 GTK+
1276 https://bugs.webkit.org/show_bug.cgi?id=75543
1278 Reviewed by Martin Robinson.
1280 * MiniBrowser/gtk/GNUmakefile.am: Add javascriptcore_cppflags to
1281 MiniBrowser CPP flags.
1283 2012-03-20 Eric Seidel <eric@webkit.org>
1285 Move wtf/Platform.h from JavaScriptCore to Source/WTF/wtf
1286 https://bugs.webkit.org/show_bug.cgi?id=80911
1288 Reviewed by Adam Barth.
1290 Update include paths for Source/WTF.
1292 * DumpRenderTree/efl/CMakeLists.txt:
1293 * DumpRenderTree/qt/DumpRenderTree.pro:
1294 * QtTestBrowser/QtTestBrowser.pro:
1295 * Scripts/build-webkit: Build Source/WTF on AppleWin as well.
1297 2012-03-20 Adam Barth <abarth@webkit.org>
1299 svn-apply should move inflight patches from WebCore/webaudio to WebCore/Modules/webaudio
1300 https://bugs.webkit.org/show_bug.cgi?id=81567
1302 Reviewed by Eric Seidel.
1304 This temporary measure should help us avoid disrupting the folks
1305 working on WebAudio when we move the webaudio directory to Modules.
1307 * Scripts/VCSUtils.pm:
1308 (adjustPathForRecentRenamings):
1309 (parseGitDiffHeader):
1310 (parseSvnDiffHeader):
1312 2012-03-20 Dirk Pranke <dpranke@chromium.org>
1314 Unreviewed, rolling out r111453.
1315 http://trac.webkit.org/changeset/111453
1316 https://bugs.webkit.org/show_bug.cgi?id=81600
1320 * Scripts/webkitpy/layout_tests/port/server_process.py:
1321 (ServerProcess._reset):
1322 (ServerProcess.handle_interrupt):
1323 (ServerProcess.write):
1324 (ServerProcess._check_for_crash):
1325 (ServerProcess._handle_timeout):
1326 (ServerProcess._check_for_abort):
1327 (ServerProcess._read):
1328 (ServerProcess.stop):
1330 (ServerProcess.set_crashed):
1331 * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
1332 (TrivialMockPort.is_crash_reporter):
1333 (TestServerProcess.test_broken_pipe):
1334 * Scripts/webkitpy/layout_tests/port/webkit.py:
1335 (WebKitPort._read_image_diff):
1336 (WebKitDriver.has_crashed):
1337 (WebKitDriver._check_for_driver_crash):
1339 (WebKitDriver._detected_crash):
1340 (WebKitDriver._subprocess_crashed):
1341 (WebKitDriver._crashed_process_name):
1342 (WebKitDriver.run_test):
1343 (WebKitDriver._read_block):
1344 * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1345 (MockServerProcess.__init__):
1347 2012-03-20 Dirk Pranke <dpranke@chromium.org>
1349 webkitpy: get ServerProcess out of the reportcrash business
1350 https://bugs.webkit.org/show_bug.cgi?id=81600
1352 Unreviewed, build fix.
1354 Re-land r111307 and r111293 with fix for crash in NRWT; I
1355 was failing to set the crashing process name.
1357 * Scripts/webkitpy/layout_tests/port/server_process.py:
1358 (ServerProcess._reset):
1359 (ServerProcess._handle_possible_interrupt):
1360 (ServerProcess.write):
1361 (ServerProcess.read_stdout):
1362 (ServerProcess.has_crashed):
1363 (ServerProcess._read):
1364 (ServerProcess.stop):
1365 * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
1366 (TrivialMockPort.check_for_leaks):
1367 (TestServerProcess.test_broken_pipe):
1368 * Scripts/webkitpy/layout_tests/port/webkit.py:
1369 (WebKitPort._read_image_diff):
1370 (WebKitDriver.has_crashed):
1371 (WebKitDriver._check_for_driver_crash):
1372 (WebKitDriver.run_test):
1373 (WebKitDriver._read_block):
1374 * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1375 (MockServerProcess.__init__):
1376 (MockServerProcess):
1377 (MockServerProcess.has_crashed):
1379 2012-03-20 Tim Horton <timothy_horton@apple.com>
1381 [mac] Restore color space switching code to run-webkit-tests
1382 https://bugs.webkit.org/show_bug.cgi?id=80571
1383 <rdar://problem/11008529>
1385 Reviewed by Simon Fraser.
1387 http://trac.webkit.org/changeset/111429 broke tools build on Snow Leopard.
1389 Use the old CM* API on Snow Leopard, since CGDisplayCreateUUIDFromDisplayID
1390 didn't exist until Lion.
1392 * DumpRenderTree/mac/LayoutTestHelper.m:
1393 (installLayoutTestColorProfile):
1394 (restoreUserColorProfile):
1396 2012-03-20 Adele Peterson <adele@apple.com>
1398 Update the last test to use EXPECT_WK_STREQ.
1400 Reviewed by Dan Bernstein.
1402 * TestWebKitAPI/Tests/mac/AttributedString.mm: (TestWebKitAPI::TEST):
1404 2012-03-20 Adele Peterson <adele@apple.com>
1406 "Attempt to insert nil value " exception when calling attributed string APIs on content with a custom font
1407 https://bugs.webkit.org/show_bug.cgi?id=81630
1408 <rdar://problem/10650660>
1410 Reviewed by Alexey Proskuryakov.
1412 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1413 * TestWebKitAPI/Tests/mac/Ahem.ttf: Added.
1414 * TestWebKitAPI/Tests/mac/AttributedString.mm: Added.
1415 (-[AttributedStringTest webView:didFinishLoadForFrame:]):
1417 (TestWebKitAPI::didFinishLoadForFrame):
1418 (TestWebKitAPI::TEST):
1419 * TestWebKitAPI/Tests/mac/attributedStringCustomFont.html: Added.
1421 2012-03-20 Eric Seidel <eric@webkit.org>
1423 Add link on queues.webkit.org to kov's fancy queue-depth graph
1424 https://bugs.webkit.org/show_bug.cgi?id=81690
1426 Reviewed by Adam Barth.
1428 * QueueStatusServer/templates/recentstatus.html:
1430 2012-03-20 Tim Horton <timothy_horton@apple.com>
1432 [mac] Restore color space switching code to run-webkit-tests
1433 https://bugs.webkit.org/show_bug.cgi?id=80571
1434 <rdar://problem/11008529>
1436 Reviewed by Simon Fraser.
1438 Make use of the layout test helper hooks to restore the Mac system-wide
1439 color profile switching code. This makes WkTR and DRT results match, and
1440 causes the main display's color profile to not affect results on Lion.
1442 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1443 * DumpRenderTree/mac/LayoutTestHelper.m: Added.
1444 (installLayoutTestColorProfile):
1445 (restoreUserColorProfile):
1446 (simpleSignalHandler):
1448 * Scripts/webkitpy/layout_tests/port/mac.py:
1449 (MacPort.release_http_lock):
1451 (MacPort._path_to_helper):
1452 (MacPort.start_helper):
1453 (MacPort.stop_helper):
1454 * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1455 (WTR::PlatformWebView::PlatformWebView):
1456 (WTR::PlatformWebView::windowSnapshotImage):
1458 2012-02-24 Darin Fisher <darin@chromium.org>
1460 Add more Chromium WebKit API reviewers
1461 https://bugs.webkit.org/show_bug.cgi?id=81576
1463 Reviewed by Adam Barth and David Levin.
1465 Simplify watchlist to lump all WebKit API into one.
1467 * Scripts/webkitpy/common/config/watchlist:
1469 2012-03-20 Gyuyoung Kim <gyuyoung.kim@samsung.com>
1471 Convert hasSpellingMarker to use Internals interface.
1472 https://bugs.webkit.org/show_bug.cgi?id=81300
1474 Reviewed by Ryosuke Niwa.
1476 Remove hasSpellingMarker functions, because it is able to work in the
1477 cross-port way through the Internals interface.
1479 * DumpRenderTree/LayoutTestController.cpp:
1480 (LayoutTestController::staticFunctions):
1481 * DumpRenderTree/LayoutTestController.h:
1482 (LayoutTestController):
1483 * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
1484 * DumpRenderTree/chromium/LayoutTestController.cpp:
1485 (LayoutTestController::LayoutTestController):
1486 * DumpRenderTree/chromium/LayoutTestController.h:
1487 (LayoutTestController):
1488 * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1489 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1490 * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1491 * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1492 * DumpRenderTree/qt/LayoutTestControllerQt.h:
1493 * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1494 * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1496 2012-03-20 Csaba Osztrogonác <ossy@webkit.org>
1498 Add new Qt-WK2 performance tester bot to build.webkit.org
1499 https://bugs.webkit.org/show_bug.cgi?id=80842
1501 Reviewed by Ryosuke Niwa.
1503 * BuildSlaveSupport/build.webkit.org-config/config.json:
1504 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1505 (RunAndUploadPerfTestsWebKit2):
1506 (RunAndUploadPerfTestsWebKit2.start):
1507 (BuildAndPerfTestWebKit2Factory):
1508 (BuildAndPerfTestWebKit2Factory.__init__):
1509 (DownloadAndPerfTestWebKit2Factory):
1510 (DownloadAndPerfTestWebKit2Factory.__init__):
1512 2012-03-20 Peter Beverloo <peter@chromium.org>
1514 [Chromium] Update to Android NDK r7b
1515 https://bugs.webkit.org/show_bug.cgi?id=81005
1517 Reviewed by Adam Barth.
1519 Update to version r7b of the Android NDK, release notes of which are
1520 available on the following page:
1521 http://developer.android.com/sdk/ndk/index.html
1523 * Scripts/update-webkit-chromium:
1525 2012-03-20 Csaba Osztrogonác <ossy@webkit.org>
1527 x86 GCC bug triggers a compilation error in generated copy constructor of CollapsedBorderValue
1528 https://bugs.webkit.org/show_bug.cgi?id=81502
1532 * qmake/mkspecs/features/unix/default_post.prf: Reenable Werror after r111171.
1534 2012-03-19 Jessie Berlin <jberlin@apple.com>
1536 Unreviewed; roll out http://trac.webkit.org/changeset/111307 and http://trac.webkit.org/changeset/111293
1537 because they broke running the layout tests on mac.
1539 * Scripts/webkitpy/layout_tests/port/webkit.py:
1540 (WebKitDriver._check_for_driver_crash):
1542 2012-03-16 Martin Robinson <mrobinson@igalia.com>
1544 [GTK] Allow running run-gtk-tests during 'make distcheck'
1545 https://bugs.webkit.org/show_bug.cgi?id=81415
1547 Reviewed by Philippe Normand.
1549 Modify the build and run-gtk-tests so that it can run during 'make distcheck'
1551 * GNUmakefile.am: Distribute run-gtk-tests during 'make dist' and make it the
1552 main command run during 'make check.'
1553 * Scripts/run-gtk-tests: Refactored run-gtk-tests so that jhbuild is no longer
1554 a requirement to run it. If jhbuild isn't around it will simply not start the
1555 SPI daemons and skip the WebKit2 accessibility test. Remove test runs from the
1556 main loop and simply use the main loop in a synchronous method to start SPI
1557 daemons. Did a bunch of general cleanup around these tasks.
1559 2012-03-19 Raphael Kubo da Costa <rakuco@FreeBSD.org>
1561 jhbuild: Use the multiprocessing module to get the number of CPUs.
1562 https://bugs.webkit.org/show_bug.cgi?id=81585
1564 Reviewed by Martin Robinson.
1566 Now that support for Python 2.5 has been dropped, we can safely
1567 use multiprocessing.cpu_count() to obtain the current number of
1568 CPUs in the system instead of running a webkitperl script for
1578 2012-03-19 Ojan Vafai <ojan@chromium.org>
1580 We should only add a live event listener once, not once per TestSelector.
1581 Adding one per TestSelector would cause accordion('option', 'active') to
1582 incorrectly be "false" if you examine multiple sets of tests.
1584 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
1586 2012-03-19 Dirk Pranke <dpranke@chromium.org>
1588 Fix typo introduced in r111293.
1590 Unreviewed, build fix.
1592 * Scripts/webkitpy/layout_tests/port/webkit.py:
1593 (WebKitDriver._check_for_driver_crash):
1595 2012-03-19 Dirk Pranke <dpranke@chromium.org>
1597 webkitpy: get ServerProcess out of the reportcrash business
1598 https://bugs.webkit.org/show_bug.cgi?id=81600
1600 Reviewed by Adam Barth.
1602 ServerProcess was half-aware that ReportCrash might run
1603 sometimes, and that the process ServerProcess was talking to
1604 might have its own crashing subprocesses; neither of these
1605 things really worked right and it made the logic convoluted, so
1606 this change makes handling crashes completely separate from the
1607 server_process code, so that it can focus on just I/O to the
1610 There should be no functional changes resulting from this patch.
1612 * Scripts/webkitpy/layout_tests/port/server_process.py:
1613 (ServerProcess._reset):
1614 (ServerProcess._handle_possible_interrupt):
1615 (ServerProcess.write):
1616 (ServerProcess.read_stdout):
1617 (ServerProcess.has_crashed):
1618 (ServerProcess._read):
1619 (ServerProcess.stop):
1620 * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
1621 (TrivialMockPort.check_for_leaks):
1622 (TestServerProcess.test_broken_pipe):
1623 * Scripts/webkitpy/layout_tests/port/webkit.py:
1624 (WebKitPort._read_image_diff):
1625 (WebKitDriver.has_crashed):
1626 (WebKitDriver._check_for_driver_crash):
1627 (WebKitDriver.run_test):
1628 (WebKitDriver._read_block):
1629 * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1630 (MockServerProcess.__init__):
1631 (MockServerProcess):
1632 (MockServerProcess.has_crashed):
1634 2012-03-19 Dirk Pranke <dpranke@chromium.org>
1636 webkitpy: crashlog parsing is broken
1637 https://bugs.webkit.org/show_bug.cgi?id=81586
1639 Reviewed by Adam Barth.
1641 Seeking on a file opened through codecs() appears to not work
1642 correctly (at least on SL).
1644 The code was more complicated than it needed to be, so I have
1645 revamped it to just read a full crashlog at once and then look
1648 I have also added the ability to optionally propagate
1649 errors back (which can be helpful to debug races when ReportCrash is
1650 still running and you need to see that you couldn't open some
1651 files, rather than just ignoring them).
1653 * Scripts/webkitpy/common/system/crashlogs.py:
1654 (CrashLogs.find_newest_log):
1655 (CrashLogs._find_newest_log_darwin):
1656 * Scripts/webkitpy/common/system/crashlogs_unittest.py:
1657 (CrashLogsTest.test_find_log_darwin):
1659 2012-03-19 Dirk Pranke <dpranke@chromium.org>
1661 webkitpy: clean up some port._filesystem references to not reference private members
1662 https://bugs.webkit.org/show_bug.cgi?id=81595
1664 Reviewed by Eric Seidel.
1666 There should be no functional changes in this patch, just some
1667 refactoring. Also, fixes a minor nit in write_image_diff_files(()
1669 * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1670 (SingleTestRunner.__init__):
1671 (SingleTestRunner._run_compare_test):
1672 (SingleTestRunner._run_rebaseline):
1673 (SingleTestRunner._save_baseline_data):
1674 (SingleTestRunner._handle_error):
1675 (SingleTestRunner._run_reftest):
1676 * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1677 (write_test_result):
1678 (TestResultWriter.__init__):
1679 (TestResultWriter._make_output_directory):
1680 (TestResultWriter.output_filename):
1681 (TestResultWriter._output_testname):
1682 (TestResultWriter.write_output_files):
1683 (TestResultWriter.write_stderr):
1684 (TestResultWriter.write_crash_report):
1685 (TestResultWriter.create_text_diff_and_write_result):
1686 (TestResultWriter.write_image_diff_files):
1688 * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
1689 (TestResultWriterTest.test_reftest_diff_image):
1691 2012-03-19 Dirk Pranke <dpranke@chromium.org>
1693 webkitpy: fix nit - incorrect reference to DRT in test_expectations.py
1694 https://bugs.webkit.org/show_bug.cgi?id=81598
1696 Reviewed by Eric Seidel.
1698 "DumpRenderTree" shouldn't be hard-coded here, since some other
1699 process may actually be crashing (WebKitTestRunner, WebProcess, etc.)
1701 * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1704 2012-03-19 Dirk Pranke <dpranke@chromium.org>
1706 webkitpy: allow instance data in TestFailure objects
1707 https://bugs.webkit.org/show_bug.cgi?id=81580
1709 Reviewed by Tony Chang.
1711 Current TestFailures are basically enums, but it would be nice,
1712 especially for crashes, if they contained the name and pid of
1713 the process that crashed.
1715 * Scripts/webkitpy/layout_tests/models/test_failures.py:
1716 (TestFailure.message):
1717 (FailureTimeout.message):
1719 (FailureCrash.__init__):
1720 (FailureCrash.message):
1721 (FailureMissingResult.message):
1722 (FailureTextMismatch.message):
1723 (FailureMissingImageHash.message):
1724 (FailureMissingImage.message):
1725 (FailureImageHashMismatch.message):
1726 (FailureImageHashIncorrect.message):
1727 (FailureReftestMismatch.message):
1728 (FailureReftestMismatchDidNotOccur.message):
1729 (FailureReftestNoImagesGenerated.message):
1730 (FailureMissingAudio.message):
1731 (FailureAudioMismatch.message):
1732 * Scripts/webkitpy/layout_tests/models/test_failures_unittest.py:
1733 (TestFailuresTest.test_equals):
1735 (TestFailuresTest.test_crashes):
1737 2012-03-19 Brady Eidson <beidson@apple.com>
1739 <rdar://problem/10917120> and https://bugs.webkit.org/show_bug.cgi?id=81066
1740 Crash in 3rd party WebKit apps under XHR/Cache code
1742 Reviewed by Antti Koivisto.
1744 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1745 * TestWebKitAPI/Tests/mac/MemoryCachePruneWithinResourceLoadDelegate.html: Added.
1746 * TestWebKitAPI/Tests/mac/MemoryCachePruneWithinResourceLoadDelegate.mm: Added.
1747 (-[MemoryCachePruneTestResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
1748 (-[MemoryCachePruneTestResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
1749 (-[MemoryCachePruneTestResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
1750 (-[MemoryCachePruneTestResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
1752 (TestWebKitAPI::TEST):
1754 2012-03-19 Brady Eidson <beidson@apple.com>
1756 <rdar://problem/10848575> and https://bugs.webkit.org/show_bug.cgi?id=81516
1757 REGRESSION (r107435) URLs copied from WebKit apps aren't in the right pasteboard format
1759 Reviewed by Enrica Casucci.
1761 Bring up a context menu on a link, copy the link, then verify the pasteboard contents
1762 are in the correct format.
1764 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1765 * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.html: Added.
1766 * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm: Added.
1767 (-[ContextMenuCanCopyURLDelegate webView:didFinishLoadForFrame:]):
1768 (TestWebKitAPI::contextMenuCopyLink):
1769 (TestWebKitAPI::TEST):
1771 2012-03-19 Ojan Vafai <ojan@chromium.org>
1773 Make the selected item in the accordion a link to the flakiness dashboard
1774 https://bugs.webkit.org/show_bug.cgi?id=81571
1776 Reviewed by Dimitri Glazkov.
1778 Also, make it so that you can select the text of the link, instead of the current behavior
1779 of acting as if you had clicked on the accordion header.
1781 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
1782 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
1784 2012-03-19 Dirk Pranke <dpranke@chromium.org>
1786 NRWT runs some tests that are skipped with -i command line option
1787 https://bugs.webkit.org/show_bug.cgi?id=81535
1789 Reviewed by Ojan Vafai.
1791 This change modifies the interaction of Skipped files and
1792 test_expectations files so that entries in Skipped files (and
1793 the -i command line) override *everything* in the expectations
1796 Specifically, a directory in a Skipped file will cause all of
1797 the tests in the dir to be skipped even if individual tests in
1798 the dir are listed in the test_expectations.txt.
1800 Skipped files also override anything in an overrides files.
1802 This seems to make more intuitive sense, since if you list
1803 something in the Skips file (and even more specify it on the
1804 command line) you probably want it to be universally applied.
1806 Theoretically we could add more precedence levels and have full
1807 paths in an expectations file override dirs in a Skipped file
1808 (but not the command line), but I don't know yet that that level
1809 of complexity is justified.
1811 * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1812 (TestExpectations.__init__):
1813 (TestExpectations._add_skipped_tests):
1814 (TestExpectations._add_test):
1815 (TestExpectations._add_expectations):
1816 (TestExpectations._add_expectation_line):
1817 (TestExpectations._already_seen_better_match):
1818 * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1819 (test_more_specific_override_resets_skip):
1821 (SkippedTests.get_exp):
1822 (SkippedTests.assert_exp):
1823 (SkippedTests.test_skipped_tests_work):
1824 (SkippedTests.test_duplicate_skipped_test_fails_lint):
1825 (SkippedTests.test_skipped_file_overrides_expectations):
1826 (SkippedTests.test_skipped_dir_overrides_expectations):
1827 (SkippedTests.test_skipped_file_overrides_overrides):
1828 (SkippedTests.test_skipped_dir_overrides_overrides):
1830 2012-03-19 Eric Seidel <eric@webkit.org>
1832 Fix WTF header include discipline in Chromium WebKit
1833 https://bugs.webkit.org/show_bug.cgi?id=81281
1835 Reviewed by James Robinson.
1837 * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1838 * Scripts/update-webkit-chromium: Made it possible to run this from a directory other than the root.
1840 2012-03-19 Andy Chen <andchen@rim.com>
1842 [BlackBerry] Add new layout test for text match marker
1843 https://bugs.webkit.org/show_bug.cgi?id=81531
1845 Make the LayoutTestControllerBlackBerry::findString to test the
1846 BlackBerry port implementation.
1848 Reviewed by Rob Buis.
1850 * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
1851 (LayoutTestController::findString):
1853 2012-03-19 Ojan Vafai <ojan@chromium.org>
1855 Don't show WONTFIX tests in garden-o-matic
1856 https://bugs.webkit.org/show_bug.cgi?id=81554
1858 Reviewed by Dimitri Glazkov.
1860 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
1861 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
1863 2012-03-19 Chris Fleizach <cfleizach@apple.com>
1865 platform/mac/accessibility/selected-rows-table.html failing on Lion Intel Debug WebKit2 testers
1866 https://bugs.webkit.org/show_bug.cgi?id=81530
1868 Reviewed by Jessie Berlin.
1870 Add rowAtIndex to WebKitTestRunner.
1872 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1873 (WTR::AccessibilityUIElement::rowAtIndex):
1874 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1875 (AccessibilityUIElement):
1876 * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1877 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1879 (WTR::AccessibilityUIElement::rowAtIndex):
1881 2012-03-19 Ojan Vafai <ojan@chromium.org>
1883 Change garden-o-matic All Failures tab to Expected Failures
1884 https://bugs.webkit.org/show_bug.cgi?id=81540
1886 Reviewed by Dimitri Glazkov.
1888 Also, fix some broken unittests that had just gotten stale.
1890 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
1891 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers/rebaseline.js:
1892 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
1893 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
1894 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
1895 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
1896 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
1897 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
1898 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
1899 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
1901 2012-03-19 Hao Zheng <zhenghao@chromium.org>
1903 [chromium] DRT crashes at shutdown.
1904 https://bugs.webkit.org/show_bug.cgi?id=81504
1906 Reviewed by James Robinson.
1908 WebCompositor must be destroyed after WebView is properly destroyed,
1909 or some compositor objects like CCLayerTreeHost may not be destroyed.
1910 However, it is really hard to make the destruction order correct
1911 explicitly in ~TestShell. So move it out to DumpRenderTree.
1913 * DumpRenderTree/chromium/DumpRenderTree.cpp:
1915 * DumpRenderTree/chromium/TestShell.cpp:
1916 (TestShell::~TestShell):
1918 2012-03-19 Dirk Pranke <dpranke@chromium.org>
1920 add dpranke to webkitpy watchlist
1921 https://bugs.webkit.org/show_bug.cgi?id=81433
1923 Reviewed by Benjamin Poulain.
1925 * Scripts/webkitpy/common/config/watchlist:
1927 2012-03-19 Dirk Pranke <dpranke@chromium.org>
1929 test-webkitpy is failing on SL/Python 2.6.1
1930 https://bugs.webkit.org/show_bug.cgi?id=81533
1932 Reviewed by Ojan Vafai.
1934 It appears that itertools.combinations() is buggy in 2.6.1; this
1935 backports the implementation from 2.7.
1937 * Scripts/webkitpy/layout_tests/models/test_configuration.py:
1938 (TestConfigurationConverter.collapse_macros):
1939 (TestConfigurationConverter):
1940 (TestConfigurationConverter.combinations):
1942 2012-03-19 David Michael Barr <davidbarr@google.com>
1944 Optimize the cleanup sequence in the start-queue.sh script
1945 https://github.com/abarth/webkit/pull/1
1947 Reviewed by Adam Barth.
1949 Updating the working copy is an expensive operation
1950 for a repository the size of WebKit.
1951 Attempt to reset only to the target revision.
1953 * EWSTools/start-queue.sh:
1955 2012-03-19 Raphael Kubo da Costa <kubo@profusion.mobi>
1957 Adjust architecture type of the EFL build bot.
1958 https://bugs.webkit.org/show_bug.cgi?id=81452
1960 Reviewed by Tony Chang.
1962 * BuildSlaveSupport/build.webkit.org-config/config.json: The
1963 buildslave is a 64-bit machine, therefore describe it as being
1966 2012-03-19 Alexander Færøy <alexander.faeroy@nokia.com>
1968 [Qt] printLoadedUrls prints "Object" instead of the actual URL.
1969 https://bugs.webkit.org/show_bug.cgi?id=81514
1971 Reviewed by Simon Hausmann.
1973 * MiniBrowser/qt/qml/BrowserWindow.qml:
1975 2012-03-19 Raphael Kubo da Costa <rakuco@FreeBSD.org>
1977 [EFL] jhbuild: Set CMAKE_PREFIX_PATH in jhbuildrc.
1978 https://bugs.webkit.org/show_bug.cgi?id=81491
1980 Reviewed by Philippe Normand.
1982 For the find_path(), find_library() etc CMake calls to find the
1983 dependencies built with jhbuild, CMAKE_PREFIX_PATH must be properly
1984 set, otherwise CMake cannot know the dependencies exist and will only
1985 look in the standard directories.
1987 * efl/jhbuildrc: Set the CMAKE_PREFIX_PATH environment variable with
1988 the jhbuild Root directory.
1990 2012-03-19 Dominik Röttsches <dominik.rottsches@linux.intel.com>
1992 [EFL] Add XDG env vars to jhbuildrc
1993 https://bugs.webkit.org/show_bug.cgi?id=81510
1995 Needed to ensure correct glib behaviour in jhbuild environment.
1997 Reviewed by Philippe Normand.
2001 2012-03-19 Allan Sandfeld Jensen <allan.jensen@nokia.com>
2003 Select best target for tap gesture.
2004 https://bugs.webkit.org/show_bug.cgi?id=78801
2006 Reviewed by Kenneth Rohde Christiansen.
2008 Add TOUCH_ADJUSTMENT to enabled features.
2010 * qmake/mkspecs/features/features.prf:
2012 2012-03-19 Robert Kroeger <rjkroege@chromium.org>
2014 [chromium] synthesize wheel events for fling on main thread
2015 https://bugs.webkit.org/show_bug.cgi?id=81458
2017 Added the ability to dispatch GestureFlingStart and GestureFlingCancel from EventSender.
2019 Reviewed by James Robinson.
2021 * DumpRenderTree/chromium/EventSender.cpp:
2022 (EventSender::EventSender):
2023 (EventSender::gestureFlingCancel):
2024 (EventSender::gestureFlingStart):
2025 * DumpRenderTree/chromium/EventSender.h:
2028 2012-03-19 Alexander Færøy <alexander.faeroy@nokia.com>
2030 [Qt] Add command line option to set the user agent in the MiniBrowser
2031 https://bugs.webkit.org/show_bug.cgi?id=81508
2033 Reviewed by Simon Hausmann.
2035 * MiniBrowser/qt/BrowserWindow.cpp:
2036 (BrowserWindow::BrowserWindow):
2037 (BrowserWindow::webViewExperimental):
2038 * MiniBrowser/qt/BrowserWindow.h:
2040 * MiniBrowser/qt/MiniBrowserApplication.cpp:
2042 (MiniBrowserApplication::handleUserOptions):
2043 * MiniBrowser/qt/MiniBrowserApplication.h:
2044 (WindowOptions::WindowOptions):
2045 (WindowOptions::setUserAgent):
2046 (WindowOptions::userAgent):
2049 2012-03-19 Alexander Færøy <alexander.faeroy@nokia.com>
2051 [Qt] Remove dead user agent code from the MiniBrowser.
2053 Reviewed by Simon Hausmann.
2055 * MiniBrowser/qt/BrowserWindow.cpp:
2056 * MiniBrowser/qt/BrowserWindow.h:
2058 * MiniBrowser/qt/MiniBrowser.qrc:
2059 * MiniBrowser/qt/useragentlist.txt: Removed.
2061 2012-03-19 Raphael Kubo da Costa <rakuco@FreeBSD.org>
2063 jhbuild: Call jhbuild's autogen.sh via bash.
2064 https://bugs.webkit.org/show_bug.cgi?id=81485
2066 Reviewed by Philippe Normand.
2068 jhbuild's autogen.sh uses "/bin/bash" in the shebang line, however
2069 this is usually true only on Linux systems, and even then bash for
2070 some reason might not be available in that location. It is safer to
2071 call bash directly and pass autogen.sh to it instead.
2073 * jhbuild/jhbuild-wrapper:
2076 2012-03-19 Philippe Normand <pnormand@igalia.com>
2078 [GTK] Prefix run-launcher with run-with-jhbuild
2079 https://bugs.webkit.org/show_bug.cgi?id=81503
2081 Reviewed by Hajime Morita.
2083 * Scripts/run-launcher:
2085 2012-03-19 Dominik Röttsches <dominik.rottsches@linux.intel.com>
2087 [EFL] Prefix run-launcher with run-with-jhbuild
2088 https://bugs.webkit.org/show_bug.cgi?id=80026
2090 Reviewed by Hajime Morita.
2092 * Scripts/run-launcher:
2094 2012-03-18 Csaba Osztrogonác <ossy@webkit.org>
2096 [Qt] Unreviewed. Disable -Werror on x86 until proper fix.
2097 https://bugs.webkit.org/show_bug.cgi?id=81498
2099 * qmake/mkspecs/features/unix/default_post.prf:
2101 2012-03-17 Raphael Kubo da Costa <rakuco@FreeBSD.org>
2103 Unreviewed; switch to using my FreeBSD.org email address, the
2104 other one is going to disappear soon.
2106 * Scripts/webkitpy/common/config/committers.py:
2107 * Scripts/webkitpy/common/config/watchlist:
2109 2012-03-17 Raphael Kubo da Costa <kubo@profusion.mobi>
2111 Unreviewed; fix webkitpy unit test failures after r111116.
2113 It turns out that cmd_line in the patch in bug 80025 had the right
2114 signature when it was submitted, but r109242 added a few more
2115 required parameters, and since the method (and EflDriver) did not
2116 exist at the time we ended up committing a broken method.
2118 * Scripts/webkitpy/layout_tests/port/efl.py:
2119 (EflDriver.cmd_line): Add the `pixel_tests' and `per_test_args'
2122 2012-03-17 Charles Wei <charles.wei@torchmobile.com.cn>
2124 [BlackBerry] Enable Web Timing for performance profiling and improvement.
2125 https://bugs.webkit.org/show_bug.cgi?id=81085
2127 Reviewed by Rob Buis.
2129 * Scripts/build-webkit:
2131 2012-03-17 Dominik Röttsches <dominik.rottsches@linux.intel.com>
2133 Add a dependencies installation step for EFL to buildbot master.cfg
2134 https://bugs.webkit.org/show_bug.cgi?id=81337
2136 Reviewed by Gustavo Noronha Silva.
2138 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2139 (InstallEflDependencies):
2142 2012-03-17 Dominik Röttsches <dominik.rottsches@linux.intel.com>
2144 [EFL] Prefixing run-webkit-tests with run-with-jhbuild
2145 https://bugs.webkit.org/show_bug.cgi?id=80025
2147 Reviewed by Gustavo Noronha Silva.
2149 * Scripts/webkitpy/layout_tests/port/efl.py:
2151 (EflDriver.cmd_line):
2152 (EflPort._driver_class):
2154 2012-03-17 Dominik Röttsches <dominik.rottsches@linux.intel.com>
2156 [EFL] Add and use run-with-jhbuild and update-webkitefl-libs scripts for EFL
2157 https://bugs.webkit.org/show_bug.cgi?id=79904
2159 build-webkit --efl will use jhbuild for fetching and building dependencies.
2161 Reviewed by Gustavo Noronha Silva.
2163 * Scripts/update-webkitefl-libs: Added.
2164 * Scripts/webkitdirs.pm:
2165 (jhbuildWrapperPrefixIfNeeded):
2166 (generateBuildSystemFromCMakeProject):
2167 (buildCMakeGeneratedProject):
2168 * efl/common.py: Added.
2172 * efl/jhbuild.modules: Added.
2173 * efl/jhbuildrc: Added.
2174 * efl/run-with-jhbuild: Added.
2176 2012-03-16 Stephanie Lewis <slewis@apple.com>
2178 https://bugs.webkit.org/show_bug.cgi?id=81065
2179 <rdar://problem/10944309> CrashTracer: [USER] 111 crashes in WebProcess at WebKitTestRunnerInjectedBundle: WTR::InjectedBundle::done + 142
2180 Fix crash preventing WebKitTestRunner from working in Release.
2181 WebKitTestRunner used ostringstream to collect output from the test. ostringstream is incompatible with our
2182 FastMalloc overrides. When copying strings out ostringstream a new string is allocated with FastMalloc because
2183 the allocation is inlined. When that string is freed is uses the system malloc because that call is not inlined.
2185 I removed ostringstream in favor of StringBuilder.
2187 Properly set NDEBUG on Release builds so we don't crash when when we free the strings StringBuilder created.
2189 Reviewed by Geoff Garen.
2191 Add DEBUG_DEFINES to set NDEBUG on release builds.
2192 * WebKitTestRunner/Configurations/Base.xcconfig:
2193 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2195 Remove ostringstream member in favor of StringBuilder.
2196 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2197 (WTR::InjectedBundle::initialize):
2198 (WTR::InjectedBundle::beginTesting):
2199 (WTR::InjectedBundle::done):
2200 * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2202 (WTR::InjectedBundle::stringBuilder):
2205 Append output to StringBuilder.
2206 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2210 (WTR::styleDecToStr):
2212 (WTR::dumpFrameScrollPosition):
2213 (WTR::dumpFrameText):
2214 (WTR::dumpDescendantFramesText):
2215 (WTR::InjectedBundlePage::dump):
2216 (WTR::InjectedBundlePage::didReceiveTitleForFrame):
2217 (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
2218 (WTR::InjectedBundlePage::willSendRequestForFrame):
2219 (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
2220 (WTR::lastFileURLPathComponent):
2221 (WTR::InjectedBundlePage::willAddMessageToConsole):
2222 (WTR::InjectedBundlePage::willSetStatusbarText):
2223 (WTR::InjectedBundlePage::willRunJavaScriptAlert):
2224 (WTR::InjectedBundlePage::willRunJavaScriptConfirm):
2225 (WTR::InjectedBundlePage::willRunJavaScriptPrompt):
2226 (WTR::InjectedBundlePage::shouldBeginEditing):
2227 (WTR::InjectedBundlePage::shouldEndEditing):
2228 (WTR::InjectedBundlePage::shouldInsertNode):
2229 (WTR::InjectedBundlePage::shouldInsertText):
2230 (WTR::InjectedBundlePage::shouldDeleteRange):
2231 (WTR::InjectedBundlePage::shouldChangeSelectedRange):
2232 (WTR::InjectedBundlePage::shouldApplyStyle):
2233 (WTR::InjectedBundlePage::didBeginEditing):
2234 (WTR::InjectedBundlePage::didEndEditing):
2235 (WTR::InjectedBundlePage::didChange):
2236 (WTR::InjectedBundlePage::didChangeSelection):
2237 (WTR::InjectedBundlePage::supportsFullScreen):
2238 (WTR::InjectedBundlePage::enterFullScreenForElement):
2239 (WTR::InjectedBundlePage::exitFullScreenForElement):
2240 (WTR::InjectedBundlePage::beganEnterFullScreen):
2241 (WTR::InjectedBundlePage::beganExitFullScreen):
2242 (WTR::dumpBackForwardListItem):
2243 (WTR::InjectedBundlePage::dumpBackForwardList):
2244 * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2245 (WTR::LayoutTestController::waitToDumpWatchdogTimerFired):
2246 (WTR::LayoutTestController::dumpConfigurationForViewport):
2248 Convert between WTF::String and WKStringRef.
2249 * WebKitTestRunner/StringFunctions.h:
2252 * WebKitTestRunner/TestInvocation.cpp:
2253 (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2255 2012-03-16 Eric Seidel <eric@webkit.org>
2257 Add a land-from-url command
2258 https://bugs.webkit.org/show_bug.cgi?id=81411
2260 Reviewed by Adam Barth.
2262 Very basic so far. The goal is to make it landing smarter
2263 so that users don't have to bother to parse out the ids out of the urls.
2265 * Scripts/webkitpy/common/config/urls.py:
2267 (parse_attachment_id):
2268 * Scripts/webkitpy/common/config/urls_unittest.py:
2269 (URLsTest.test_parse_bug_id):
2271 (URLsTest.test_parse_attachment_id):
2272 * Scripts/webkitpy/tool/commands/download.py:
2274 (ProcessURLsMixin._fetch_list_of_patches_to_process):
2276 * Scripts/webkitpy/tool/commands/download_unittest.py:
2277 (test_land_from_bug):
2278 (test_land_from_url):
2280 2012-03-16 Dave Tharp <dtharp@codeaurora.org>
2282 build-webkit launcher instructions use wrong relative path for Qt
2283 https://bugs.webkit.org/show_bug.cgi?id=81357
2285 Reviewed by Eric Seidel.
2287 Ensure we are at the proper directory before generating run-launcher
2290 * Scripts/build-webkit:
2292 2012-03-16 Brady Eidson <beidson@apple.com>
2294 <rdar://problem/11027997> and https://bugs.webkit.org/show_bug.cgi?id=81412
2295 REGRESSION (r107435) Copy a link and paste to Mail: Nothing is pasted
2297 Reviewed by Geoff Garen.
2299 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2300 * TestWebKitAPI/Tests/mac/WebViewCanPasteURL.mm: Added.
2302 2012-03-16 Ojan Vafai <ojan@chromium.org>
2304 Mark wontfix tests in full_results.json so we can ignore them in garden-o-matic
2305 https://bugs.webkit.org/show_bug.cgi?id=81407
2307 Reviewed by Adam Barth.
2309 * Scripts/webkitpy/layout_tests/controllers/manager.py:
2310 (summarize_results):
2311 * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2312 (ResultSummaryTest.summarized_results):
2313 (ResultSummaryTest.test_no_svn_revision):
2314 (ResultSummaryTest.test_svn_revision):
2315 (ResultSummaryTest):
2316 (ResultSummaryTest.test_summarized_results_wontfix):
2318 2012-03-16 Ojan Vafai <ojan@chromium.org>
2320 Have webkit-patch rebaseline-test update test_expectations.txt
2321 https://bugs.webkit.org/show_bug.cgi?id=81054
2323 Recommit http://trac.webkit.org/changeset/110783 now that
2324 http://trac.webkit.org/changeset/111034 has landed.
2326 * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2327 (TestExpectations.remove_configuration_from_test):
2328 * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2329 (RemoveConfigurationsTest):
2330 (RemoveConfigurationsTest.test_remove):
2332 * Scripts/webkitpy/tool/commands/rebaseline.py:
2333 (RebaselineTest._update_expectations_file):
2334 (RebaselineTest._rebaseline_test_and_update_expectations):
2336 (RebaselineTest.execute):
2337 * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2338 (TestRebaseline.test_rebaseline_updates_expectations_file_noop):
2339 (test_rebaseline_updates_expectations_file):
2341 2012-03-15 Ojan Vafai <ojan@chromium.org>
2343 Specifier collapsing when writing test expectations lines gets a number of cases wrong
2344 https://bugs.webkit.org/show_bug.cgi?id=81309
2346 Reviewed by Dimitri Glazkov.
2348 I've run this over all the lines in the current Chromium test_expectations.txt file,
2349 so I'm relatively confident we now cover all the cases.
2351 * Scripts/webkitpy/layout_tests/models/test_configuration.py:
2352 (TestConfigurationConverter.__init__):
2353 (TestConfigurationConverter.collapse_macros):
2354 (TestConfigurationConverter.collapse_macros.collapse_individual_specifier_set):
2355 (TestConfigurationConverter):
2356 (TestConfigurationConverter.intersect_combination):
2357 (TestConfigurationConverter.symmetric_difference):
2358 (TestConfigurationConverter.to_specifiers_list):
2359 (TestConfigurationConverter.to_specifiers_list.try_collapsing):
2360 (TestConfigurationConverter.to_specifiers_list.try_abbreviating):
2361 * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py:
2362 (make_mock_all_test_configurations_set):
2363 (TestConfigurationConverterTest.test_symmetric_difference):
2364 (TestConfigurationConverterTest.test_to_config_set):
2365 (TestConfigurationConverterTest.test_macro_expansion):
2366 (TestConfigurationConverterTest.test_to_specifier_lists):
2367 (TestConfigurationConverterTest.test_converter_macro_collapsing):
2368 * Scripts/webkitpy/layout_tests/port/chromium.py:
2370 * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2371 (ChromiumAndroidPort.__init__):
2372 The android port uses "arm" as it's architecture, which is technically correct,
2373 but considerably complicates making collapsing work. We probably should kill
2374 the concept of architecture entirely. The benefits are not worth the code
2377 * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2378 (ChromiumPortTest.test_all_test_configurations):
2379 * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2380 (TestRebaseline.test_rebaseline_updates_expectations_file_noop):
2381 (test_rebaseline_updates_expectations_file):
2383 2012-03-16 Dinu Jacob <dinu.jacob@nokia.com>
2385 [Qt][Wk2] Assertion Failure and crash on file upload
2386 https://bugs.webkit.org/show_bug.cgi?id=80854
2388 Reviewed by Simon Hausmann.
2390 Added filePicker to WebView using experimental API.
2392 * MiniBrowser/qt/MiniBrowser.qrc:
2393 * MiniBrowser/qt/icons/folder.png: Added.
2394 * MiniBrowser/qt/icons/titlebar.png: Added.
2395 * MiniBrowser/qt/icons/up.png: Added.
2396 * MiniBrowser/qt/qml/BrowserWindow.qml:
2397 * MiniBrowser/qt/qml/FilePicker.qml: Added.
2399 2012-03-16 Mahesh Kulkarni <mahesh.kulkarni@nokia.com>
2401 Updating email for committer.py script.
2403 * Scripts/webkitpy/common/config/committers.py:
2405 2012-03-16 Robert Kroeger <rjkroege@chromium.org>
2407 [chromium] DRT: Add support for sending gesture scrolls without a begin
2408 https://bugs.webkit.org/show_bug.cgi?id=81292
2410 Reviewed by Kent Tamura.
2412 * DumpRenderTree/chromium/EventSender.cpp:
2413 (EventSender::EventSender):
2414 (EventSender::gestureScrollFirstPoint):
2415 * DumpRenderTree/chromium/EventSender.h:
2418 2012-03-02 Carlos Garcia Campos <cgarcia@igalia.com> and Sergio Villar Senin <svillar@igalia.com>
2420 [GTK] WebKitIconDatabase doesn't keep icons cached
2421 https://bugs.webkit.org/show_bug.cgi?id=56200
2423 Reviewed by Martin Robinson.
2425 Add support for favicons in GtkLauncher.
2427 * GtkLauncher/main.c:
2428 (activateUriEntryCb):
2432 2012-03-16 Adam Barth <abarth@webkit.org>
2434 Remove sheriff-bot's last-green-revision command
2435 https://bugs.webkit.org/show_bug.cgi?id=81314
2437 Reviewed by Eric Seidel.
2439 This command is a cruel joke. WebKit doesn't really ever have a
2440 last-green-revision.
2442 * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2443 (BuildBot._find_green_revision):
2444 * Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:
2445 (MockBuildBot.builder_statuses):
2446 * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2447 (test_find_green_revision):
2448 * Scripts/webkitpy/tool/bot/irc_command.py:
2449 (IRCCommand.execute):
2450 * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
2451 (SheriffIRCBotTest.test_help):
2452 * Scripts/webkitpy/tool/commands/queries.py:
2453 (PatchesToReview.execute):
2455 2012-03-16 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
2457 [Qt] Make gccdepends test aware of broken icecream deps generation
2459 Icecream seems to build the files without passing -o to gcc with
2460 the original destination path, which means the target name in the
2461 dependency file is wrong.
2463 Also, echo something to the final file instead of just touching it,
2464 so it's not deleted on every build.
2466 Reviewed by Simon Hausmann.
2468 * qmake/config.tests/gccdepends/gccdepends.pro:
2470 2012-03-16 Kihong Kwon <kihong.kwon@samsung.com>
2472 Support for Battery Status API
2473 https://bugs.webkit.org/show_bug.cgi?id=62698
2475 Add include directory and file.
2476 http://www.w3.org/TR/battery-status/
2478 Reviewed by Adam Barth.
2480 * Scripts/build-webkit:
2482 2012-03-16 Kishore Bolisetty <kbolisetty@innominds.com>
2484 check-webkit-style fails on LayoutTests/platform/efl/test_expectations.txt
2485 https://bugs.webkit.org/show_bug.cgi?id=81007
2487 Reviewed by Adam Barth.
2489 A dedidcated build slave is available for efl on build.webkit.org.
2490 This change add's an entry for the elf port in list of available port builders.
2491 This is required because test_expectations.py when triggered, looks for a valid port object for the specified port.
2493 * Scripts/webkitpy/layout_tests/port/builders.py:
2495 2012-03-16 Adam Barth <abarth@webkit.org>
2497 [webkitpy] StatusServer.next_work_item has an incorrectly named local variable
2498 https://bugs.webkit.org/show_bug.cgi?id=81302
2500 Reviewed by Eric Seidel.
2502 This is a trivial patch, but the variable name turned up in a grep of
2503 webkitpy and looks like copy pasta.
2505 * Scripts/webkitpy/common/net/statusserver.py:
2506 (StatusServer.next_work_item):
2508 2012-03-16 Andrew Lo <anlo@rim.com>
2510 [BlackBerry] Enable PAGE_VISIBILITY_API
2511 https://bugs.webkit.org/show_bug.cgi?id=81257
2513 Enable Page Visibility API for BlackBerry.
2515 Reviewed by Rob Buis.
2517 * Scripts/build-webkit:
2519 2012-03-16 Zan Dobersek <zandobersek@gmail.com>
2521 [Gtk] Add computedStyleIncludingVisitedInfo to DumpRenderTreeSupport
2522 https://bugs.webkit.org/show_bug.cgi?id=81232
2524 Reviewed by Philippe Normand.
2526 Use the newly-added helper method in DumpRenderTreeSupportGtk.
2528 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2529 (LayoutTestController::computedStyleIncludingVisitedInfo):
2531 2012-03-15 Eric Seidel <eric@webkit.org>
2533 Move parse_bug_id into config/urls in preparation for re-use elsewhere.
2534 https://bugs.webkit.org/show_bug.cgi?id=81313
2536 Reviewed by Adam Barth.
2538 * Scripts/webkitpy/common/checkout/changelog.py:
2539 (parse_bug_id_from_changelog):
2540 * Scripts/webkitpy/common/config/urls.py:
2542 * Scripts/webkitpy/common/config/urls_unittest.py: Copied from Tools/Scripts/webkitpy/common/config/urls.py.
2544 (URLsTest.test_parse_bug_id):
2545 * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
2546 (test_parse_bug_id):
2547 * Scripts/webkitpy/tool/bot/irc_command.py:
2548 (_post_error_and_check_for_bug_url):
2549 * Scripts/webkitpy/tool/bot/sheriff.py:
2550 (Sheriff.post_rollout_patch):
2551 (Sheriff.post_chromium_deps_roll):
2553 2012-03-15 Adam Barth <abarth@webkit.org>
2555 The commit-queue should fast-track patches that have already passed the testing EWS bots
2556 https://bugs.webkit.org/show_bug.cgi?id=81305
2558 Reviewed by Eric Seidel.
2560 If a patch has already passed the testing EWS bots (currently only the
2561 chromium-ews bot), we should be able to land the patch without running
2562 the tests again. This patch is somewhat risky in that the tests might
2563 have been broken between when the EWS bots ran and when the
2564 commit-queue is processing the patch. If that turns out to be a
2565 problem in practice, we'll tighten up this fast-track in some way,
2566 likely by making sure that the pass status is recent.
2568 * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2569 (CommitQueueTaskDelegate.did_pass_testing_ews):
2570 (CommitQueueTask._did_pass_tests_recently):
2571 (CommitQueueTask.run):
2572 * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2573 (MockCommitQueue.did_pass_testing_ews):
2574 (test_fast_success_case):
2575 * Scripts/webkitpy/tool/commands/queues.py:
2576 (CommitQueue.did_pass_testing_ews):
2577 * Scripts/webkitpy/tool/commands/queues_unittest.py:
2578 (test_did_pass_testing_ews):
2580 2012-03-15 Kentaro Hara <haraken@chromium.org>
2582 [PerformanceTests] run-perf-tests should output correct units
2583 https://bugs.webkit.org/show_bug.cgi?id=78303
2585 Reviewed by Ryosuke Niwa.
2587 Previously run-perf-tests just supported "ms" for units.
2588 Consequently, Dromaeo perf tests had been reporting runs/s as "ms".
2589 This patch fixes run-perf-tests so that they can support custom units.
2590 The default unit is "ms".
2592 The test result looks like this:
2594 $ ./Tools/Scripts/run-perf-tests Dromaeo/dom-attr.html
2595 RESULT Dromaeo: dom-attr= 6465.9525483 runs/s
2596 median= 0.0 runs/s, stdev= 24.2983433436 runs/s, min= 6435.87649402 runs/s, max= 6515.63693392 runs/s
2598 * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2599 (PerfTestsRunner._process_parser_test_result):
2601 2012-03-15 Brent Fulgham <bfulgham@webkit.org>
2603 [WinCairo] Unreviewed build change after wtf path changes.
2605 * DumpRenderTree/win/ImageDiffWinCairoCommon.vsprops: Updated include
2606 directories to look at the private header directory to find 'wtf'.
2608 2012-03-15 Kent Tamura <tkent@chromium.org>
2610 REGRESSION(r110595): webkit-patch suggest-reviewers doesn't work
2611 https://bugs.webkit.org/show_bug.cgi?id=81293
2613 Reviewed by Adam Barth.
2615 r110595 introduced new format of the author field of ChangeLog entry:
2616 "Adam Barth <abarth@webkit.org> && Benjamin Poulain <bpoulain@apple.com>"
2617 Updte chanelog.py to support it.
2619 * Scripts/webkitpy/common/checkout/changelog.py:
2620 (ChangeLogEntry._split_contributor_names):
2621 * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2622 (test_parse_authors):
2624 2012-03-15 Lynn Neir <lynn.neir@skype.net>
2626 Implement LayoutTestController::setValueForUser on Windows https://bugs.webkit.org/show_bug.cgi?id=55834
2628 Implemented setValueForUser in both DumpRenderTree and WebKitTestRunner.
2630 Reviewed by Jessie Berlin.
2632 * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2633 (LayoutTestController::setValueForUser):
2634 * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2635 * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2636 (WTR::LayoutTestController::setValueForUser):
2638 * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2639 (LayoutTestController):
2641 2012-03-15 Adam Barth <abarth@webkit.org>
2643 Update the start-queue.sh script to match what we're using on the bots
2644 https://bugs.webkit.org/show_bug.cgi?id=81277
2646 Reviewed by Eric Seidel.
2648 Over time we've added more magic git commands to clean up the local repo after
2649 it has been borked in various ways. The idea behind this sequence is to clear
2650 out any changes in the working copy and then to rebuild the master branch from
2653 This patch also removes the watchdog timer that we've stopped using on the
2656 This patch was reviewed on <https://github.com/eseidel/webkit/pull/1>.
2657 Note: Eric and I are experimenting with GitHub to see if it might be
2658 useful for WebKit. If you have thoughts on this topic, please feel
2659 free to grab Eric or me on #webkit to chat. I assume that he and I are
2660 the only ones who care about this file so using this alternative
2661 process for this patch shouldn't cause any trouble.
2663 * EWSTools/start-queue.sh:
2665 2012-03-15 Adam Barth <abarth@webkit.org>
2667 The commit-queue can hang when the test_expectations.txt style check fails during commit
2668 https://bugs.webkit.org/show_bug.cgi?id=81251
2670 Reviewed by Eric Seidel.
2672 We forgot to check the --non-interactive flag, so we end up prompting
2673 the "user" who doesn't exist on the bot. We might consider teaching
2674 the User class about non-interactive if we have this sort of bug again.
2676 * Scripts/webkitpy/tool/steps/commit.py:
2678 (Commit._check_test_expectations):
2680 * Scripts/webkitpy/tool/steps/commit_unittest.py:
2681 (CommitTest.test_check_test_expectations):
2683 2012-03-15 Jessie Berlin <jberlin@apple.com>
2685 fast/dom/Window/window-properties.html and fast/dom/prototype-inheritance-2.html failing on
2686 Mac WK2 because WebAudio is not enabled
2687 https://bugs.webkit.org/show_bug.cgi?id=81259
2689 Reviewed by Dan Bernstein.
2691 Enable WebAudio so that it appears in the window object in the tests.
2692 The webaudio tests are all still skipped in the Mac Skipped list.
2694 * WebKitTestRunner/TestController.cpp:
2695 (WTR::TestController::resetStateToConsistentValues):
2697 2012-03-15 David Levin <levin@chromium.org>
2699 Various autoresize fixes.
2700 https://bugs.webkit.org/show_bug.cgi?id=81199
2702 Reviewed by Darin Fisher.
2704 * DumpRenderTree/chromium/LayoutTestController.cpp:
2705 (LayoutTestController::reset): Stop using the deprecated api that was removed.
2707 2012-03-15 Carlos Garcia Campos <cgarcia@igalia.com>
2709 [GTK] Actually use --release and --debug command line options in run-gtk-test
2710 https://bugs.webkit.org/show_bug.cgi?id=81234
2712 Reviewed by Philippe Normand.
2714 Actually handle --release and --debug command line options to
2715 create the build directory, falling back to current hack to detect
2716 whether it's a Release or Debug build when both options are missed.
2718 * Scripts/run-gtk-tests:
2719 (TestRunner.__init__): Receive options too.
2720 (TestRunner._get_top_level_directory): Helper function to get the
2721 top level directory.
2722 (TestRunner._get_build_directory): Helper function to get the
2723 build directory depending on --release/--debug command line
2724 options or gessing it if both options are missing.
2725 (TestRunner._ensure_accessibility_daemon_is_running): Use
2727 (TestRunner.run): Ditto.
2728 (TestRunner.run.run_tests): Pass options to the constructor
2731 2012-03-15 Carlos Garcia Campos <cgarcia@igalia.com>
2733 [GTK] Run unit tests with --verbose in the bots
2734 https://bugs.webkit.org/show_bug.cgi?id=81230
2736 Reviewed by Martin Robinson.
2738 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2739 (RunGtkAPITests): Add --verbose to run-gtk-test command.
2741 2012-03-15 Kevin Ollivier <kevino@theolliviers.com>
2743 Move wx port to using export macros
2744 https://bugs.webkit.org/show_bug.cgi?id=77279
2746 Reviewed by Hajime Morita.
2748 * waf/build/settings.py:
2751 2012-03-15 Philippe Normand <pnormand@igalia.com>
2753 Unreviewed, GTK build fix attempt after r110845.
2755 * Scripts/run-gtk-tests: Added --release and --debug options.
2757 2012-03-15 Dominik Röttsches <dominik.rottsches@linux.intel.com>
2759 Parametrize run-with-jhbuild and update-webkitgtk-libs with platform --gtk/--efl
2760 https://bugs.webkit.org/show_bug.cgi?id=79673
2762 Preparatory work for bringing jhbuild enabled build to EFL port.
2764 Reviewed by Philippe Normand.
2766 * Scripts/update-webkit-libs-jhbuild: Copied from Tools/Scripts/update-webkitgtk-libs.
2767 * Scripts/update-webkitgtk-libs:
2768 * gtk/run-with-jhbuild:
2769 * jhbuild/jhbuild-wrapper: Copied from Tools/gtk/run-with-jhbuild.
2771 (jhbuild_installed):
2773 (jhbuild_at_expected_revision):
2777 (update_webkit_libs_jhbuild):
2778 (determine_platform):
2781 2012-03-15 Carlos Garcia Campos <cgarcia@igalia.com>
2783 [GTK] Add command line options to run-gtk-tests script
2784 https://bugs.webkit.org/show_bug.cgi?id=81218
2786 Reviewed by Philippe Normand.
2788 Following command line options have been added:
2790 -v, --verbose: to run gtester with --verbose. That would be used
2791 by the bots to make it easier to know which test case it failing.
2793 --display: to use a different display for Xvfb
2795 It's also possible to pass one or more tests as arguments.
2797 * Scripts/run-gtk-tests:
2798 (TestRunner.__init__): Receive command line arguments.
2799 (TestRunner._get_tests): Get all the tests or the ones passed by
2800 command line arguments.
2801 (TestRunner._ensure_accessibility_daemon_is_running): Use display
2802 command line argument.
2803 (TestRunner.run): Pas command line options.
2804 (TestRunner.run.run_tests): Pass command line arguments.
2806 2012-03-15 Carlos Garcia Campos <cgarcia@igalia.com>
2808 [GTK] WebKit2APITests/TestPrinting timeout in the bots
2809 https://bugs.webkit.org/show_bug.cgi?id=81211
2811 Reviewed by Philippe Normand.
2813 Add gtk+ patch to fix timeout in the bots. A similar patch has
2814 already landed in updatream gtk+, see
2815 http://git.gnome.org/browse/gtk+/commit/?id=5ebfad5d091f4c9d9c6e60364fad4c60842f027f
2817 * gtk/jhbuild.modules:
2818 * gtk/patches/gtk+-3.0.12-gtkprinter.patch: Added.
2820 2012-03-14 Gustavo Noronha Silva <gns@gnome.org>
2822 sheriffbot should also be addressable with a comma in addition to colon
2823 https://bugs.webkit.org/show_bug.cgi?id=81101
2825 Reviewed by Adam Barth.
2827 * Scripts/webkitpy/common/net/irc/ircbot.py:
2830 2012-03-15 Alexander Færøy <alexander.faeroy@nokia.com>
2832 [Qt] MiniBrowser scroll indicators should not scroll out of view
2833 https://bugs.webkit.org/show_bug.cgi?id=81131
2835 Reviewed by Kenneth Rohde Christiansen.
2837 * MiniBrowser/qt/qml/ScrollIndicator.qml:
2839 2012-03-14 Chris Fleizach <cfleizach@apple.com>
2841 AX: ARIA tables need to support selected rows attribute/select rows changed notification
2842 https://bugs.webkit.org/show_bug.cgi?id=79821
2844 Reviewed by Beth Dakin.
2846 * DumpRenderTree/AccessibilityUIElement.cpp:
2847 (rowAtIndexCallback):
2848 (AccessibilityUIElement::getJSClass):
2849 * DumpRenderTree/AccessibilityUIElement.h:
2850 (AccessibilityUIElement):
2851 * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
2852 (AccessibilityUIElement::rowAtIndex):
2853 * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2854 (AccessibilityUIElement::rowAtIndex):
2855 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2856 (AccessibilityUIElement::rowAtIndex):
2857 * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2858 (AccessibilityUIElement::rowAtIndex):
2860 2012-03-14 Tim Horton <timothy_horton@apple.com>
2862 NRWT should respect --additional-platform-directory's Skipped list
2863 https://bugs.webkit.org/show_bug.cgi?id=81172
2865 Reviewed by Timothy Hatcher.
2867 Respect the Skipped file inside all paths included via the --additional-platform-directory option. Test results
2868 from said path are already used, but the Skipped file is ignored.
2870 * Scripts/webkitpy/layout_tests/port/webkit.py:
2871 (WebKitPort._skipped_file_search_paths):
2872 * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2873 (test_skipped_file_search_paths):
2875 2012-03-14 Ojan Vafai <ojan@chromium.org>
2877 Unreviewed, rolling out r110783.
2878 http://trac.webkit.org/changeset/110783
2879 https://bugs.webkit.org/show_bug.cgi?id=81054
2881 Caused existing test expectation lines to expand to one for
2882 each test configuration.
2884 * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2885 (TestExpectations.has_warnings):
2886 * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2887 (test_macro_overrides):
2888 * Scripts/webkitpy/tool/commands/rebaseline.py:
2889 (RebaselineTest._save_baseline):
2890 (RebaselineTest._rebaseline_test):
2891 (RebaselineTest.execute):
2892 * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2893 (TestRebaseline.test_tests_to_update):
2895 2012-03-13 Jon Lee <jonlee@apple.com>
2897 Separate NOTIFICATIONS and LEGACY_NOTIFICATIONS
2898 https://bugs.webkit.org/show_bug.cgi?id=80922
2899 <rdar://problem/11035082>
2901 Reviewed by Jian Li.
2903 You can include either NOTIFICATIONS or LEGACY_NOTIFICATIONS and have a complete API.
2904 LEGACY_NOTIFICATIONS should cover all of the previous functionality, and NOTIFICATIONS will cover the
2905 new API. Therefore, APIs that are common between the two will have:
2906 #if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS)
2908 This patch initially sets both to be exactly the same. As other bugs with patches begin to migrate to
2909 the new API, the defines will begin to split. This allows ports to decide which set of APIs to include.
2911 Update everything to be #if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS)
2912 * DumpRenderTree/chromium/LayoutTestController.cpp:
2913 (LayoutTestController::grantDesktopNotificationPermission):
2914 (LayoutTestController::simulateDesktopNotificationClick):
2915 * DumpRenderTree/chromium/NotificationPresenter.cpp:
2916 * DumpRenderTree/chromium/TestShell.cpp:
2917 (TestShell::TestShell):
2918 (TestShell::resetTestController):
2919 * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
2920 (DRTDesktopNotificationPresenter::checkNotificationPermission):
2922 2012-03-13 Ojan Vafai <ojan@chromium.org>
2924 Have webkit-patch rebaseline-test update test_expectations.txt
2925 https://bugs.webkit.org/show_bug.cgi?id=81054
2927 Reviewed by Dirk Pranke.
2929 This will allow us to use the All Failures tab in garden-o-matic
2930 to rebaseline tests without making test_expectations.txt stale.
2932 It's conservative and only removes lines if the test is
2933 not flaky and fails in a way the rebaseline would fix (e.g.
2934 CRASH/TIMEOUT will not be touched).
2936 * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2937 (TestExpectations.remove_configuration_from_test):
2938 * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2939 (RemoveConfigurationsTest):
2940 (RemoveConfigurationsTest.test_remove):
2942 * Scripts/webkitpy/tool/commands/rebaseline.py:
2943 (RebaselineTest._is_supported_port):
2945 (RebaselineTest._update_expectations_file):
2946 (RebaselineTest._rebaseline_test_and_update_expectations):
2947 (RebaselineTest.execute):
2948 * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2949 (TestRebaseline.test_rebaseline_updates_expectations_file):
2951 2012-03-14 Jessie Berlin <jberlin@apple.com>
2953 Crash in WKTR under addChromeInputField due to using 0 as a key in a HashMap
2954 https://bugs.webkit.org/show_bug.cgi?id=81167
2956 Reviewed by Sam Weinig.
2958 Do not use 0 as a key in a HashMap.
2960 * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2961 cacheLayoutTestControllerCallback uses the enum as keys for the callback map.
2963 2012-03-14 Ojan Vafai <ojan@chromium.org>
2965 Add the chromium lion bot to garden-o-matic and remove
2966 the platform_move_to in builders.py since the Chromium Lion
2967 port is now a normal port.
2969 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
2970 * Scripts/webkitpy/layout_tests/port/builders.py:
2972 2012-03-14 Dirk Pranke <dpranke@chromium.org>
2974 Fix regression/crash introduced in r110724 - bad type passed from skipped_tests() by default.
2976 Unreviewed, build fix.
2978 * Scripts/webkitpy/layout_tests/port/base.py:
2979 (Port.skipped_tests):
2981 2012-03-14 Dirk Pranke <dpranke@chromium.org>
2983 Please add a way to manually skip some tests in NRWT
2984 https://bugs.webkit.org/show_bug.cgi?id=81019
2986 Reviewed by Ojan Vafai.
2988 This patch implements the -i / --ignore-tests flag from ORWT
2989 and refactors the test_expectations.py code slightly to handle
2992 * Scripts/webkitpy/layout_tests/controllers/manager.py:
2993 (Manager.parse_expectations):
2994 * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2995 (TestExpectations.__init__):
2996 * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2997 (test_add_skipped_tests):
2998 (test_add_skipped_tests_duplicate):
2999 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3001 * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3002 (MainTest.test_ignore_tests):
3003 (MainTest.test_ignore_tests.assert_ignored):
3005 2012-03-14 Dirk Pranke <dpranke@chromium.org>
3007 nrwt: run with no args on lion, is putting baselines in platform/mac-lion, not platform/mac
3008 https://bugs.webkit.org/show_bug.cgi?id=81028
3010 Reviewed by Ojan Vafai.
3012 The mac port had incorrect lookups for 'mac-lion' and
3013 'mac-future' in some places. This patch fixes that and adds a
3016 * Scripts/webkitpy/layout_tests/port/mac.py:
3017 (MacPort.baseline_path):
3018 * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3019 (MacTest.assert_skipped_file_search_paths):
3020 (MacTest.test_skipped_file_search_paths):
3021 (_assert_search_path):
3022 (test_baseline_search_path):
3023 * Scripts/webkitpy/layout_tests/port/webkit.py:
3024 (WebKitPort._skipped_file_search_paths):
3026 2012-03-13 Jer Noble <jer.noble@apple.com>
3028 Lion Intel Debug WebKit2 Tests crashing under [WKFullScreenWindowController _startEnterFullScreenAnimationWithDuration:]
3029 https://bugs.webkit.org/show_bug.cgi?id=81056
3031 Reviewed by Jessie Berlin.
3033 Intercept beganEnterFullScreen and beganExitFullScreen and turn them into no-ops (plus logging).
3035 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3036 (WTR::InjectedBundlePage::InjectedBundlePage):
3037 (WTR::InjectedBundlePage::beganEnterFullScreen):
3038 (WTR::InjectedBundlePage::beganExitFullScreen):
3040 2012-03-14 Alexander Færøy <alexander.faeroy@nokia.com>
3042 The width and height of the scroll indicators in the MiniBrowser does
3043 not consider the offset margins.
3044 https://bugs.webkit.org/show_bug.cgi?id=81112
3046 Reviewed by Kenneth Rohde Christiansen.
3048 This patch fixes the issue by withdrawing two times the anchor
3051 * MiniBrowser/qt/qml/ScrollIndicator.qml:
3053 2012-03-14 Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com>
3055 [EFL] Implement LayoutTestController::clearBackForwardList
3056 https://bugs.webkit.org/show_bug.cgi?id=80142
3058 Adding missing implementation clearBackForwardList to EFL's
3059 LayoutTestController. This implementation allows us to unskip
3060 tests connected with history.
3062 Reviewed by Antonio Gomes.
3064 * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
3065 (LayoutTestController::clearBackForwardList): Implemented.
3067 2012-03-13 Thiago Marcos P. Santos <thiago.santos@intel.com>
3069 [EFL][DRT] Expose window.internals object
3070 https://bugs.webkit.org/show_bug.cgi?id=79900
3072 Exposes window.internals for EFL's DRT. Makes possible to
3073 remove some tests from the skip list.
3075 Reviewed by Antonio Gomes.
3077 * DumpRenderTree/efl/CMakeLists.txt:
3078 * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3079 (DumpRenderTreeChrome::onWindowObjectCleared):
3081 2012-03-13 Adam Barth <abarth@webkit.org> && Benjamin Poulain <bpoulain@apple.com>
3083 Always enable ENABLE(CLIENT_BASED_GEOLOCATION)
3084 https://bugs.webkit.org/show_bug.cgi?id=78853
3086 Reviewed by Adam Barth.
3088 * Scripts/build-webkit:
3089 * qmake/mkspecs/features/features.prf:
3091 2012-03-12 Antonio Gomes <agomes@rim.com>
3093 Convert nodesFromRect tests to use Internals interface
3094 https://bugs.webkit.org/show_bug.cgi?id=80886
3096 Reviewed by Ryosuke Niwa.
3098 This clean up allows to remove port specific bits of each
3099 DRT implementation that supports testing Document::nodesFromRect,
3100 in favor of making use of the 'Internals' interface to test it.
3102 This makes its code conveniently more expansible and cleaner.
3104 Also removed stubs from Win and EFL DRTs.
3106 * DumpRenderTree/LayoutTestController.cpp:
3107 (LayoutTestController::staticFunctions):
3108 * DumpRenderTree/LayoutTestController.h:
3109 (LayoutTestController):
3110 * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
3111 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3112 * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3113 * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3114 * DumpRenderTree/qt/LayoutTestControllerQt.h:
3115 (LayoutTestController):
3116 * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3118 2012-03-13 Ojan Vafai <ojan@chromium.org>
3120 Rebaselining for a new port doesn't work right with multiple fallback ports
3121 https://bugs.webkit.org/show_bug.cgi?id=80932
3123 Reviewed by Adam Barth.
3125 Since chromium-leopard also falls back to mac-leopard, we need to
3126 copy the existing result for both chromium-leopard and chromium-snowleopard
3127 before doing lion rebaselines.
3129 * Scripts/webkitpy/layout_tests/port/builders.py:
3130 (fallback_port_names_for_new_port):
3131 * Scripts/webkitpy/tool/commands/rebaseline.py:
3133 (RebaselineTest._copy_existing_baseline):
3134 (RebaselineTest._rebaseline_test):
3135 (RebaselineTest.execute):
3136 * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3137 * Scripts/webkitpy/tool/servers/gardeningserver.py:
3138 (GardeningHTTPRequestHandler.rebaseline):
3139 * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
3140 (GardeningServerTest.test_rebaseline_new_port):
3142 2012-03-13 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
3144 [Qt] Tweak minibrowser UI
3146 Add some margins to the scroll indicators, and set a dark background
3147 color so you see the page dimensions.
3149 Reviewed by Antonio Gomes.
3151 * MiniBrowser/qt/qml/BrowserWindow.qml:
3152 * MiniBrowser/qt/qml/ScrollIndicator.qml:
3154 2012-03-13 ChangSeok Oh <shivamidow@gmail.com>
3156 [EFL] [DRT] Implement scheduleAsynchronousKeyDown.
3157 https://bugs.webkit.org/show_bug.cgi?id=79601
3159 Reviewed by Gustavo Noronha Silva.
3161 Extracted shareable code from keyDownCallback and then added createKeyEventInfo.
3162 createKeyEventInfo creates a new structure KeyEventInfo that has keyName and modifiers
3163 and is taken over to sendKeyDown.
3164 Added sendKeyDown and sendAsynchronousKeyDown to evaluate keyDown event directly
3165 and asynchronously. Eventually, sendAsynchronousKeyDown calls sendKeyDown.
3167 * DumpRenderTree/efl/EventSender.cpp:
3168 (KeyEventInfo::KeyEventInfo):
3170 (createKeyEventInfo):
3173 (sendAsynchronousKeyDown):
3174 (scheduleAsynchronousKeyDownCallback):
3176 2012-03-12 Ojan Vafai <ojan@chromium.org>
3178 webkit-patch optimize-baselines sometimes creates a mac-future result
3179 https://bugs.webkit.org/show_bug.cgi?id=80717
3181 Reviewed by Adam Barth.
3183 * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
3184 (_baseline_search_hypergraph):
3185 (BaselineOptimizer._find_optimal_result_placement):
3186 (BaselineOptimizer._filter_virtual_ports):
3187 * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
3188 (BaselineOptimizerTest.test_no_add_mac_future):
3190 2012-03-12 Jessie Berlin <jberlin@apple.com>
3192 More Windows build fixing.
3194 * DumpRenderTree/win/WorkQueueItemWin.cpp:
3196 2012-03-12 Jessie Berlin <jberlin@apple.com>
3198 More Windows build fixing.
3200 * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3201 * DumpRenderTree/win/EditingDelegate.cpp:
3202 * DumpRenderTree/win/EventSender.cpp:
3203 * DumpRenderTree/win/FrameLoadDelegate.cpp:
3204 * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3205 * DumpRenderTree/win/UIDelegate.cpp:
3207 2012-03-12 Dirk Pranke <dpranke@chromium.org>
3209 remove the 'gpu' group from the flakiness dashboard
3210 https://bugs.webkit.org/show_bug.cgi?id=80353
3212 Reviewed by Adam Barth.
3214 Since those bots are obsolete, we don't need this any more.
3216 * TestResultServer/static-dashboards/builders.js:
3217 * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
3218 (testPlatformAndBuildType):
3219 (testHtmlForTestTypeSwitcherGroup):
3221 2012-03-12 Dirk Pranke <dpranke@chromium.org>
3223 remove graphics_type from webkitpy.layout_tests.models.test_configuration
3224 https://bugs.webkit.org/show_bug.cgi?id=80643
3226 Reviewed by Ojan Vafai.
3228 Now that the chromium-gpu ports are gone, there's no need for
3229 the graphics_type CPU/GPU distinction. Most of this change is
3230 just updating tests accordingly.
3232 * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:
3233 (TestExpectationEditorTests):
3234 * Scripts/webkitpy/layout_tests/models/test_configuration.py:
3235 (TestConfiguration.__init__):
3236 (TestConfiguration.category_order):
3237 (TestConfiguration.__str__):
3238 (TestConfiguration.__repr__):
3239 (TestConfiguration.__hash__):
3240 (TestConfigurationConverter.to_specifiers_list):
3241 * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py:
3242 (make_mock_all_test_configurations_set):
3243 (TestConfigurationTest.test_items):
3244 (TestConfigurationTest.test_keys):
3245 (TestConfigurationTest.test_str):
3246 (TestConfigurationTest.test_repr):
3247 (TestConfigurationTest.test_hash):
3248 (TestConfigurationTest.test_hash.query_unknown_key):
3249 (TestConfigurationTest.test_eq):
3250 (TestConfigurationTest.test_values):
3251 (SpecifierSorterTest.test_specifier_priority):
3252 (SpecifierSorterTest.test_sort_specifiers):
3253 (TestConfigurationConverterTest.test_to_config_set):
3254 (TestConfigurationConverterTest.test_macro_expansion):
3255 (TestConfigurationConverterTest.test_to_specifier_lists):
3256 (TestConfigurationConverterTest.test_converter_macro_collapsing):
3257 * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
3258 (test_error_on_different_build_type):
3259 (TestExpectationSerializerTests.test_parsed_to_string):
3260 (TestExpectationSerializerTests.test_reconstitute_only_these):
3261 * Scripts/webkitpy/layout_tests/port/apple.py:
3262 (ApplePort._generate_all_test_configurations):
3263 * Scripts/webkitpy/layout_tests/port/base.py:
3267 (Port.test_configuration):
3268 * Scripts/webkitpy/layout_tests/port/builders.py:
3269 * Scripts/webkitpy/layout_tests/port/chromium.py:
3271 (ChromiumPort._generate_all_test_configurations):
3272 * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3273 (ChromiumLinuxPort.__init__):
3274 * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
3275 (ChromiumLinuxPortTest.test_check_illegal_port_names):
3276 * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
3277 (ChromiumMacPortTest.test_baseline_path):
3278 * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3279 (ChromiumPortTest.test_all_test_configurations):
3280 * Scripts/webkitpy/layout_tests/port/efl.py:
3281 (EflPort._generate_all_test_configurations):
3282 * Scripts/webkitpy/layout_tests/port/gtk.py:
3283 (GtkPort._generate_all_test_configurations):
3284 * Scripts/webkitpy/layout_tests/port/qt.py:
3285 (QtPort._generate_all_test_configurations):
3286 * Scripts/webkitpy/layout_tests/port/test.py:
3287 (TestPort.all_test_configurations):
3288 (TestPort._all_build_types):
3289 * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3290 * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
3291 (BuildCoverageExtrapolatorTest.test_extrapolate):
3292 (GardeningExpectationsUpdaterTest.test_unknown_failure_type):
3293 (GardeningExpectationsUpdaterTest.test_add_new_expectation):
3294 (GardeningExpectationsUpdaterTest.test_replace_old_expectation):
3295 (GardeningExpectationsUpdaterTest.test_pass_expectation):
3296 (GardeningExpectationsUpdaterTest.test_supplement_old_expectation):
3297 (GardeningExpectationsUpdaterTest.test_spurious_updates):
3299 2012-03-12 Dirk Pranke <dpranke@chromium.org>
3301 _runtime_feature_list isn't supported on Apple Mac DRT
3302 https://bugs.webkit.org/show_bug.cgi?id=80906
3304 Reviewed by Eric Seidel.
3306 It looks like this feature is actually only supported on the Win
3307 DRT port, so this patch reworks the code to make that clearer
3308 and reduce unnecessary overrides.
3310 * Scripts/webkitpy/layout_tests/port/efl.py:
3311 (EflPort._path_to_webcore_library):
3312 * Scripts/webkitpy/layout_tests/port/gtk.py:
3313 (GtkPort._path_to_webcore_library):
3314 * Scripts/webkitpy/layout_tests/port/qt.py:
3315 (QtPort._skipped_file_search_paths):
3316 * Scripts/webkitpy/layout_tests/port/webkit.py:
3317 (WebKitPort._runtime_feature_list):
3318 * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3319 (TestWebKitPort.__init__):
3320 (TestWebKitPort.all_test_configurations):
3321 (test_skipped_directories_for_features):
3322 * Scripts/webkitpy/layout_tests/port/win.py:
3324 (WinPort._runtime_feature_list):
3325 * Scripts/webkitpy/layout_tests/port/win_unittest.py:
3326 (WinPortTest.test_operating_system):
3328 (WinPortTest.test_runtime_feature_list):
3330 2012-03-12 Peter Beverloo <peter@chromium.org>
3332 [Chromium] Temporary build-fix for the Android bot
3333 https://bugs.webkit.org/show_bug.cgi?id=80862
3335 Reviewed by Adam Barth.
3337 Manually set the environmental variables required to compile source
3338 files through the Android NDK instead of relying on the envsetup.sh
3339 script. A proper fix will be landed to Chromium ASAP, and following
3340 a Chromium roll into WebKit this code will be removed.
3342 * Scripts/webkitdirs.pm:
3343 (buildChromiumMakefile):
3345 2012-03-12 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
3347 [Qt] Use right construct to detect config_test_gccdepends
3349 Reviewed by Andreas Kling.
3351 * qmake/mkspecs/features/default_pre.prf:
3353 2012-03-12 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
3355 [Qt] Expose location of WebKit's bin and imports dir through module file
3357 Reviewed by Andreas Kling.
3359 * qmake/qt_webkit.pri:
3361 2012-03-12 Andras Becsi <andras.becsi@nokia.com>
3363 [Qt][WK2] Add support for rudimentary scroll indicators in MiniBrowser
3364 https://bugs.webkit.org/show_bug.cgi?id=80832
3366 Reviewed by Tor Arne Vestbø.
3368 Add a basic scroll indicator component to MiniBrowser so that it
3369 behaves similar to the ScrollDecorator QML component.
3371 * MiniBrowser/qt/MiniBrowser.qrc:
3372 * MiniBrowser/qt/qml/BrowserWindow.qml:
3373 * MiniBrowser/qt/qml/ScrollIndicator.qml: Added.
3375 2012-03-12 C Anthony Risinger <anthony@xtfx.me>
3377 [GTK] r110296 included an extra $ in @$(AM_V_GEN)
3378 https://bugs.webkit.org/show_bug.cgi?id=80809
3380 Reviewed by Philippe Normand.
3382 * GNUmakefile.am: Add `$` to @(AM_V_GEN), else /bin/sh syntax error
3384 2012-03-12 Ming Xie <mxie@rim.com>
3386 [BlackBerry] build-webkit doesn't recognize "--cmakearg" for the BlackBerry port
3387 https://bugs.webkit.org/show_bug.cgi?id=80812
3389 Reviewed by Rob Buis.
3391 * Scripts/build-webkit: Add $cmakeArgs to buildCMakeProjectOrExit()
3392 * Scripts/webkitdirs.pm:
3393 (blackberryCMakeArguments): Remove "PUBLIC_BUILD=0" define
3396 2012-03-12 Simon Hausmann <simon.hausmann@nokia.com>
3398 [Qt] Fix build with newer Qt 5.
3400 Reviewed by Tor Arne Vestbø.
3402 Newer Qt 5 renames QDeclarativeFoo to QQmlFoo and provides backwards compatible
3403 renames, which however do trigger a #warning. Until we _require_ a newer Qt 5
3404 we should disable -Werror.
3406 Also load(moc) for the availability of QMAKE_MOC in various derived sources. The
3407 implicit load was removed recently.
3409 * qmake/mkspecs/features/default_pre.prf:
3410 * qmake/mkspecs/features/unix/default_post.prf:
3412 2012-03-11 Maciej Stachowiak <mjs@apple.com>
3414 Add --instruments option to sunspider to profile with Instruments
3415 https://bugs.webkit.org/show_bug.cgi?id=80783
3417 Reviewed by Filip Pizlo.
3419 * Scripts/run-sunspider:
3421 2012-03-11 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>
3423 [Qt] [WK2] Support threaded renderer in WK2
3424 https://bugs.webkit.org/show_bug.cgi?id=76661
3426 Remove disabling of threaded rendering.
3428 Reviewed by Noam Rosenthal.
3430 * MiniBrowser/qt/main.cpp:
3433 2012-03-09 Zan Dobersek <zandobersek@gmail.com>
3435 [WK2] run-perf-tests should be able to run with WTR
3436 https://bugs.webkit.org/show_bug.cgi?id=80042
3438 Reviewed by Martin Robinson.
3440 Add an option to PerfTestRunner to use WebKitTestRunner instead of
3441 DumpRenderTree and add the '--no-timeout' flag to WebKitTestRunner
3442 to avoid timing out when running performance tests.
3444 * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3445 (PerfTestsRunner._parse_args):
3446 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3447 (WTR::InjectedBundle::InjectedBundle): Initialize m_useWaitToDumpWatchdogTimer
3449 (WTR::InjectedBundle::didReceiveMessage): Unpack the 'BeginTest' message
3450 as a dictionary containing DumpPixels and UseWaitToDumpWatchdogTimer keys.
3451 * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3452 (WTR::InjectedBundle::useWaitToDumpWatchdogTimer): Make m_useWaitToDumpWatchdogTimer
3453 publicly accessible.
3454 * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3455 (WTR::LayoutTestController::waitUntilDone): Only initialize the watchdog if it
3457 * WebKitTestRunner/TestController.cpp:
3458 (WTR::TestController::TestController): Initialize m_useWaitToDumpWatchdogTimer
3460 (WTR::TestController::initialize): Set m_useWaitToDumpWatchdogTimer to false
3461 if '--no-timeout' option is present.
3462 (WTR::TestController::runUntil): Translate TimeoutDuration to a proper timeout
3463 value, or -1.0 if timeout should not occur.
3464 * WebKitTestRunner/TestController.h:
3465 (WTR::TestController::useWaitToDumpWatchdogTimer): Make m_useWaitToDumpWatchdogTimer
3466 publicly accessible.
3467 * WebKitTestRunner/TestInvocation.cpp:
3468 (WTR::TestInvocation::invoke): Pack the 'BeginTest' message as a dictionary,
3469 containing DumpPixels and UseWaitToDumpWatchdogTimer keys and corresponding values.
3470 Waiting for final message should not time out if not necessary.
3471 * WebKitTestRunner/gtk/TestControllerGtk.cpp:
3472 (WTR::TestController::platformRunUntil): Only set up a timeout if necessary.
3473 * WebKitTestRunner/qt/TestControllerQt.cpp:
3474 (WTR::TestController::platformRunUntil): Ditto.
3475 * WebKitTestRunner/mac/TestControllerMac.mm:
3476 (WTR::TestController::platformRunUntil): Add a FIXME, indicating functionality
3478 * WebKitTestRunner/win/TestControllerWin.cpp:
3479 (WTR::TestController::platformRunUntil): Ditto.
3481 2012-03-09 Jon Lee <jonlee@apple.com>
3483 Rename NotificationPresenter to NotificationClient
3484 https://bugs.webkit.org/show_bug.cgi?id=80488
3485 <rdar://problem/10965558>
3487 Reviewed by Kentaro Hara.
3489 Refactor to use renamed WebCore::NotificationClient.
3490 * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
3491 (DRTDesktopNotificationPresenter::checkNotificationPermission):
3493 2012-03-07 James Robinson <jamesr@chromium.org>
3495 [chromium] Deprecate renderDirectlyToWebView parameter of WebViewClient::createGraphicsContext3D()
3496 https://bugs.webkit.org/show_bug.cgi?id=80523
3498 Reviewed by Darin Fisher.
3500 * DumpRenderTree/chromium/WebViewHost.cpp:
3501 (WebViewHost::createGraphicsContext3D):
3502 * DumpRenderTree/chromium/WebViewHost.h:
3505 2012-03-09 Eric Seidel <eric@webkit.org>
3507 build-webkit should build Source/WTF on Mac
3508 https://bugs.webkit.org/show_bug.cgi?id=80728
3510 Reviewed by Adam Barth.
3512 We'll add other ports to this list in future commits.
3514 * Scripts/build-webkit:
3516 2012-03-09 Jon Lee <jonlee@apple.com>
3518 Add support for ENABLE(LEGACY_NOTIFICATIONS)
3519 https://bugs.webkit.org/show_bug.cgi?id=80497
3521 Reviewed by Adam Barth.
3523 Prep for b80472: Update API for Web Notifications
3524 * Scripts/build-webkit:
3525 * qmake/mkspecs/features/features.prf:
3527 2012-03-09 Ashod Nakashian <ashodnakashian@yahoo.com>
3529 Bash scripts should support LF endings only
3530 https://bugs.webkit.org/show_bug.cgi?id=79509
3532 Reviewed by David Kilzer.
3534 * EWSTools/boot.sh: Added properties svn:executable and svn:eol-style.
3535 * EWSTools/start-queue.sh: Added property svn:eol-style.
3536 * Scripts/webkit-tools-completion.sh: Added properties svn:executable and svn:eol-style.
3537 * WebKitTestRunner/win/build-generated-files.sh: Added properties svn:executable and svn:eol-style.
3538 * iExploder/iexploder-1.7.2/tools/release_src.sh: Added property svn:eol-style.
3539 * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh: Added property svn:eol-style.
3541 2012-03-09 Ionut Biru <ibiru@archlinux.org>
3543 [BUILD] use detected python to run generate-gtkdoc
3544 https://bugs.webkit.org/show_bug.cgi?id=80695
3546 Reviewed by Gustavo Noronha Silva.
3548 * GNUmakefile.am: Use $(PYTHON) instead of plain `python`
3550 2012-03-09 Nat Duca <nduca@chromium.org>
3552 Make check-webkit-style complain about "no new tests" lines in changelogs
3553 https://bugs.webkit.org/show_bug.cgi?id=80582
3555 Reviewed by David Levin.
3557 * Scripts/webkitpy/style/checkers/changelog.py:
3558 (ChangeLogChecker.check_entry):
3559 * Scripts/webkitpy/style/checkers/changelog_unittest.py:
3560 (ChangeLogCheckerTest.test_no_new_tests):
3562 2012-03-09 Sheriff Bot <webkit.review.bot@gmail.com>
3564 Unreviewed, rolling out r110250.
3565 http://trac.webkit.org/changeset/110250
3566 https://bugs.webkit.org/show_bug.cgi?id=80682
3568 It made NRWT ignore test_expectations.txt on Qt-WK2 and ignore
3569 qt-linux at all. (Requested by Ossy on #webkit).
3571 * Scripts/old-run-webkit-tests:
3572 * Scripts/webkitpy/layout_tests/port/qt.py:
3574 (QtPort.determine_full_port_name):
3575 (QtPort.baseline_search_path):
3576 * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
3578 (QtPortTest._assert_search_path):
3579 (QtPortTest.test_baseline_search_path):
3581 2012-03-08 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
3583 [Qt] Use Qt's module system for install rules and depending on QtWebKit
3585 Instead of rolling our own install rules we now use the same approach as
3586 every other Qt module, by loading qt_module.prf and qt_module_config.prf.
3588 This ensures that we follow the same semantics as the rest of Qt on
3589 what sort of config options are enabled by default (create_cmake eg.).
3590 It also allows us to use QT += webkit instead of the workaround we had
3591 with CONFIG += qtwebkit.
3593 We do however force Qt to always treat our build as a non-developer build,
3594 so the libraries will end up in the WebKit lib directory instead of the
3595 qtbase directory (as with a normal developer-build). This allows us to
3596 keep the webkit-build self-contained. If Qt is a developer build we still
3597 copy the module file manually to Qt, so that you don't have to install
3598 WebKit to make it available.
3600 For non-developer builds of Qt, it is still possible to use the built
3601 WebKit libraries without having to install them, by having the variable
3602 QMAKE_EXTRA_MODULE_FORWARDS set in the project's .qmake.cache file,
3603 pointing to $WEBKITOUTUTDIR/$CONFIGURATION/modules.
3605 https://bugs.webkit.org/show_bug.cgi?id=80590
3607 Reviewed by Simon Hausmann.
3609 * DumpRenderTree/qt/DumpRenderTree.pro:
3610 * MiniBrowser/qt/BrowserWindow.cpp:
3611 * MiniBrowser/qt/MiniBrowser.pro:
3612 * MiniBrowser/qt/MiniBrowserApplication.cpp:
3613 * MiniBrowser/qt/UrlLoader.cpp:
3614 * QtTestBrowser/QtTestBrowser.pro:
3616 * WebKitTestRunner/InjectedBundle/Target.pri:
3617 * WebKitTestRunner/Target.pri:
3618 * qmake/mkspecs/features/default_post.prf:
3619 * qmake/mkspecs/features/default_pre.prf:
3620 * qmake/mkspecs/features/functions.prf:
3621 * qmake/mkspecs/features/qtwebkit-private.prf: Removed.
3622 * qmake/mkspecs/features/qtwebkit.prf:
3623 * qmake/mkspecs/features/rpath.prf:
3624 * qmake/mkspecs/modules/qt_webkit.pri: Removed.
3625 * qmake/qt_webkit.pri: Added.
3627 2012-03-08 Igor Oliveira <igor.o@sisa.samsung.com>
3629 Unreviewed. Update my email.
3631 * Scripts/webkitpy/common/config/committers.py:
3633 2012-03-08 Xianzhu Wang <wangxianzhu@chromium.org>
3635 Recent changes to chromium.py etc. broke chromium_android.py
3636 https://bugs.webkit.org/show_bug.cgi?id=80623
3638 Reviewed by Dirk Pranke.
3640 * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3641 (ChromiumAndroidDriver.__init__):
3642 (ChromiumAndroidDriver._start):
3644 2012-03-08 Xianzhu Wang <wangxianzhu@chromium.org>
3646 [Chromium] Exception running reftest with --no-pixel-tests
3647 https://bugs.webkit.org/show_bug.cgi?id=80642
3649 Reviewed by Dirk Pranke.
3651 * Scripts/webkitpy/layout_tests/port/chromium.py:
3652 (ChromiumDriver.__init__):
3653 (ChromiumDriver._wrapper_options):
3655 2012-03-08 Rafael Brandao <rafael.lobo@openbossa.org>
3657 [NRWT] Fix --platform=qt-5.0 --new-baseline combo
3658 https://bugs.webkit.org/show_bug.cgi?id=72489
3660 Reviewed by Dirk Pranke.
3662 NRWT: The default platform name for Qt combined with --webkit-test-runner is now
3663 "qt-5.0-wk2" instead of "qt-linux" and that name is now prefered for tests.
3664 --platform will override the platform name and then we'll use it.
3666 ORWT: We check for qt version and use platform name "qt-4.8" if the version is lower
3667 than 5.0.0, and then we choose between "qt-5.0