Unreviewed. Removing .swp file checked in by mistake.
[WebKit-https.git] / Tools / ChangeLog
1 2011-01-28  Pratik Solanki  <psolanki@apple.com>
2
3         Unreviewed. Removing .swp file checked in by mistake.
4
5         * Scripts/.webkitdirs.pm.swp: Removed.
6
7 2011-01-28  Pratik Solanki  <psolanki@apple.com>
8
9         Reviewed by David Kilzer.
10
11         Space not necessary for undefined feature
12         https://bugs.webkit.org/show_bug.cgi?id=53317
13
14         * Scripts/build-webkit:
15
16 2011-01-28  Chang Shu  <chang.shu@nokia.com>
17
18         Reviewed by Andreas Kling.
19
20         Reset NetworkAccessManager to clean up credentials from previous tests.
21         This change causes no performance overhead either.
22         https://bugs.webkit.org/show_bug.cgi?id=36688
23
24         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
25         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
26         (WebCore::DumpRenderTree::open):
27         * DumpRenderTree/qt/DumpRenderTreeQt.h:
28
29 2011-01-28  Zoltan Horvath  <zoltan@webkit.org>
30
31         Reviewed by Andreas Kling.
32
33         [Qt] Add Zoom Text Only action to MiniBrowser
34         https://bugs.webkit.org/show_bug.cgi?id=53297
35
36         Add Zoom Text Only action to MiniBrowser's view menu, change zoom levels to avoid unnecessary divides.
37
38         * MiniBrowser/qt/BrowserWindow.cpp:
39         (BrowserWindow::BrowserWindow):
40         (BrowserWindow::zoomIn):
41         (BrowserWindow::zoomOut):
42         (BrowserWindow::resetZoom):
43         (BrowserWindow::toggleZoomTextOnly):
44         (BrowserWindow::applyZoom):
45         * MiniBrowser/qt/BrowserWindow.h:
46
47 2011-01-28  Adam Barth  <abarth@webkit.org>
48
49         Reviewed by Eric Seidel.
50
51         Add webkit-patch roll-chromium-deps
52         https://bugs.webkit.org/show_bug.cgi?id=53288
53
54         This command updates the Source/WebKit/chromium/DEPS file with the
55         last-known good revision of Chromium (or a revision specified on the
56         command line).  I'd eventually like to turn this into a SheriffBot
57         command, but this is the first step.
58
59         This patch somewhat sprawled because I needed to move a bunch of code
60         out of ChangeLog that should never have been there in the first place.
61         Also, I had to fix a bug in MockUser in order to test the new command.
62
63         * Scripts/webkitpy/common/checkout/api.py:
64         * Scripts/webkitpy/common/checkout/changelog.py:
65         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
66         * Scripts/webkitpy/common/checkout/deps.py: Added.
67         * Scripts/webkitpy/common/config/urls.py:
68         * Scripts/webkitpy/tool/commands/__init__.py:
69         * Scripts/webkitpy/tool/commands/download_unittest.py:
70         * Scripts/webkitpy/tool/commands/roll.py: Added.
71         * Scripts/webkitpy/tool/commands/roll_unittest.py: Added.
72         * Scripts/webkitpy/tool/commands/upload_unittest.py:
73         * Scripts/webkitpy/tool/mocktool.py:
74         * Scripts/webkitpy/tool/steps/__init__.py:
75         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py: Added.
76         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
77         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py: Added.
78         * Scripts/webkitpy/tool/steps/suggestreviewers_unittest.py:
79         * Scripts/webkitpy/tool/steps/updatechromiumdeps.py: Added.
80         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
81
82 2011-01-27  Greg Coletta  <greg.coletta@nokia.com>
83
84         Reviewed by Laszlo Gombos.
85
86         Get rid of prefix header dependency for WebKit2 build system
87         https://bugs.webkit.org/show_bug.cgi?id=50174
88
89         Change the style checker so that it enforces config.h include for
90         WebKit2.
91
92         * Scripts/webkitpy/style/checker.py:
93
94 2011-01-27  Maciej Stachowiak  <mjs@apple.com>
95
96         Reviewed by Darin Adler.
97
98         execCommand("Paste") doesn't work in WebKitTestRunner
99         https://bugs.webkit.org/show_bug.cgi?id=52785
100
101         Enable both of the settings needed to allow paste.
102         
103         * WebKitTestRunner/TestController.cpp:
104         (WTR::TestController::resetStateToConsistentValues):
105
106 2011-01-27  Jacob Dinu  <dinu.jacob@nokia.com>
107
108         Reviewed by Andreas Kling.
109
110         [Qt] QtTestBrowser: User input lost when toggling use of QGraphicsView
111         https://bugs.webkit.org/show_bug.cgi?id=48440
112
113         Preserve user input when toggling use of QGraphicsView
114
115         * QtTestBrowser/launcherwindow.cpp:
116         (LauncherWindow::initializeView):
117         (LauncherWindow::loadFinished):
118         * QtTestBrowser/launcherwindow.h:
119         * QtTestBrowser/mainwindow.cpp:
120         (MainWindow::addressUrl):
121         * QtTestBrowser/mainwindow.h:
122
123 2011-01-27  Dirk Pranke  <dpranke@chromium.org>
124
125         Reviewed by Mihai Parparita.
126
127         new-run-webkit-tests: turn off pixel tests correctly by default
128         for webkit-based ports. r70013 (bug 47510) used
129         port.set_option_default() to attempt to set default values, but
130         that didn't work correctly. I have removed set_option_default
131         for now since it was only being used in two places and in three
132         useless unit tests. There is a separate bug open to fix the
133         option parsing (48095), so this workaround is fine for now.
134
135         https://bugs.webkit.org/show_bug.cgi?id=53217
136
137         * Scripts/webkitpy/layout_tests/port/webkit.py:
138         * Scripts/webkitpy/layout_tests/port/base.py:
139         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
140
141 2011-01-27  Balazs Kelemen  <kbalazs@webkit.org>
142
143         Rubber-stamped by Ariya Hidayat.
144
145         Trivial crash fix in WTR.
146
147         * WebKitTestRunner/TestController.cpp:
148         (WTR::TestController::initialize): Increase the size
149         of the vector by one to be able to store the null character.
150
151 2011-01-27  Balazs Kelemen  <kbalazs@webkit.org>
152
153         Reviewed by Csaba Osztrogonác.
154
155         [Qt][WK2] WTR should be initialized in the same way as DRT
156         https://bugs.webkit.org/show_bug.cgi?id=53240
157
158         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
159         (WTR::activateFonts): Added missing initialization steps.
160
161 2011-01-27  Joone Hur <joone.hur@collabora.co.uk>
162
163         Unreviewed. 
164
165         Adding myself to committers.py.
166
167         * Scripts/webkitpy/common/config/committers.py:
168
169 2011-01-27  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
170
171         Reviewed by Csaba Osztrogonác.
172
173         [Qt] [Symbian] Move project files into Source
174         https://bugs.webkit.org/show_bug.cgi?id=52891
175
176         Fix the Symbian build after the project files
177         are moved to Source directory. On Symbian qmake
178         needs to run in the same directory where the main
179         pro files (WebKit.pro, Tools.pro) are located.
180
181         * Scripts/webkitdirs.pm: Change to the directory where the pro file
182         is located before running qmake for Symbian. Qmake on Symbian
183         does not properly honor the "-o" option, work it around by setting
184         the name of the Makefile to bld.inf.
185
186 2011-01-27  Zoltan Horvath  <zoltan@webkit.org>
187
188         Reviewed by Andreas Kling.
189
190         [Qt] Add simple zooming features to MiniBrowser
191         https://bugs.webkit.org/show_bug.cgi?id=53231
192
193         Add View menu and Zoom In, Zoom Out, Zoom Reset actions to MiniBrowser.
194
195         * MiniBrowser/qt/BrowserWindow.cpp:
196         (BrowserWindow::BrowserWindow):
197         (BrowserWindow::zoomIn):
198         (BrowserWindow::zoomOut):
199         (BrowserWindow::resetZoom):
200         (BrowserWindow::updateUserAgentList):
201         (BrowserWindow::applyZoom):
202         * MiniBrowser/qt/BrowserWindow.h:
203
204 2011-01-26  Maciej Stachowiak  <mjs@apple.com>
205
206         Reviewed by Dan Bernstein.
207
208         WebKitTestRunner needs to support layoutTestController.evaluateInWebInspector
209         https://bugs.webkit.org/show_bug.cgi?id=42319
210         
211         Add evaluateInWebInspector and other APIs needed for inspector tests to run.
212
213         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
214         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
215         (WTR::LayoutTestController::showWebInspector):
216         (WTR::LayoutTestController::closeWebInspector):
217         (WTR::LayoutTestController::evaluateInWebInspector):
218         (WTR::LayoutTestController::setTimelineProfilingEnabled):
219         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
220         * WebKitTestRunner/TestInvocation.cpp:
221         (WTR::shouldOpenWebInspector):
222         (WTR::TestInvocation::invoke):
223         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
224
225 2011-01-26  Martin Robinson  <mrobinson@igalia.com>
226
227         Reviewed by Xan Lopez.
228
229         [GTK] Pixel dumps do not include scrollbars in output images
230         https://bugs.webkit.org/show_bug.cgi?id=53216
231
232         Show scrollbars in pixel dumps. This will fix pixel dumps for tests
233         that have scrollbars.
234
235         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
236         (createBitmapContextFromWebView): Take the snapshot of the containing GtkScrolledWindow
237         instead of the web view itself.
238
239 2011-01-26  Dirk Pranke  <dpranke@chromium.org>
240
241         Reviewed by Mihai Parparita.
242
243         Fix regression introduced in r76322 ... new-run-webkit-tests
244         was attempting to save the image diff output as a UTF-8-encoded
245         file.
246
247         https://bugs.webkit.org/show_bug.cgi?id=53210
248
249         * Scripts/webkitpy/layout_tests/port/webkit.py:
250
251 2011-01-26  Sheriff Bot  <webkit.review.bot@gmail.com>
252
253         Unreviewed, rolling out r76709.
254         http://trac.webkit.org/changeset/76709
255         https://bugs.webkit.org/show_bug.cgi?id=53194
256
257         "broke python tests on non-snowleopard platforms" (Requested
258         by dpranke on #webkit).
259
260         * Scripts/webkitpy/layout_tests/port/factory.py:
261         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Removed.
262         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Removed.
263
264 2011-01-26  Dirk Pranke  <dpranke@chromium.org>
265
266         Reviewed by Tony Chang.
267
268         new-run-webkit-tests: add a "mock DRT" port implementation
269         and a separate class that emulates what we expect the
270         DumpRenderTree behavior to be.
271
272         This will eventually replace port/dryrun.py and allow us to get
273         better test coverage of the new-run-webkit-tests code as well as
274         a reference for what new-run-webkit-tests expects from DRT.
275
276         This is the first attempt at this, and it is pretty bare-boned. It
277         really only has been tested on the 'mac' port (and a little on
278         the 'chromium-mac' port.
279
280         https://bugs.webkit.org/show_bug.cgi?id=53126
281
282         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Added.
283         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Added.
284         * Scripts/webkitpy/layout_tests/port/factory.py:
285
286 2011-01-26  Xianzhu Wang  <wangxianzhu@google.com>
287
288         Reviewed by Tony Chang.
289
290         Add '--no-timeout' option to Chromium DRT to ease debugging.
291         https://bugs.webkit.org/show_bug.cgi?id=52873
292
293         * DumpRenderTree/chromium/DumpRenderTree.cpp:
294         (main):
295
296 2011-01-26  Csaba Osztrogonác  <ossy@webkit.org>
297
298         Reviewed by Andreas Kling.
299
300         [Qt] Fix qt_minimal build
301         https://bugs.webkit.org/show_bug.cgi?id=53172
302
303         * QtTestBrowser/locationedit.h:
304
305 2011-01-26  Mansi Mithal  <mansi.mithal@nokia.com>
306
307         Reviewed by Antonio Gomes.
308
309         QtTestBrowser should have a UI Setting to disable plugins
310         https://bugs.webkit.org/show_bug.cgi?id=52408
311         
312         Added a new action item named "Disable Plugins"
313         under the "Settings" menu. 
314
315         * QtTestBrowser/launcherwindow.cpp:
316         (LauncherWindow::createChrome):
317         (LauncherWindow::togglePlugins):
318         * QtTestBrowser/launcherwindow.h:
319
320 2011-01-25  Patrick Gansterer  <paroga@webkit.org>
321
322         Reviewed by Adam Barth.
323
324         Move main CMakeLists.txt into Source directory
325         https://bugs.webkit.org/show_bug.cgi?id=52888
326
327         * Scripts/webkitdirs.pm:
328
329 2011-01-25  Patrick Gansterer  <paroga@webkit.org>
330
331         Reviewed by Eric Seidel.
332
333         Improve label text in submit-to-ews
334         https://bugs.webkit.org/show_bug.cgi?id=53130
335
336         * QueueStatusServer/templates/submittoews.html:
337
338 2011-01-25  Mansi Mithal  <mansi.mithal@nokia.com>
339
340         Reviewed by Antonio Gomes.
341
342         QtTestBrowser should have a UI Settings to prevent loading images
343         https://bugs.webkit.org/show_bug.cgi?id=52409
344         
345         Added a new action item named "DisableAutoLoadImages"
346         under the "Settings" menu 
347
348         * QtTestBrowser/launcherwindow.cpp:
349         (LauncherWindow::createChrome):
350         (LauncherWindow::toggleAutoLoadImages):
351         * QtTestBrowser/launcherwindow.h:
352
353 2011-01-25  Dirk Pranke  <dpranke@chromium.org>
354
355         Reviewed by Tony Chang.
356
357         Minor bug fixes and cleanup for filesystem wrappers, port/* test
358         classes, test_expectations.py. This change adds "test-win" and
359         "test-mac" variants to the test port so that we can better test
360         rebaselining, and adds a MockUser() object for reuse in testing.
361
362         https://bugs.webkit.org/show_bug.cgi?id=53036
363
364         * Scripts/webkitpy/common/system/filesystem.py:
365         * Scripts/webkitpy/common/system/filesystem_mock.py:
366         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
367         * Scripts/webkitpy/layout_tests/port/factory.py:
368         * Scripts/webkitpy/layout_tests/port/base.py:
369         * Scripts/webkitpy/layout_tests/port/test.py:
370         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
371         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
372         * Scripts/webkitpy/tool/mocktool.py:
373
374 2011-01-25  Tony Chang  <tony@chromium.org>
375
376         Reviewed by Dimitri Glazkov.
377
378         [chromium] remove unused layoutTestController callback
379         https://bugs.webkit.org/show_bug.cgi?id=53103
380
381         This method is used by a test_shell_test, but not needed by DRT.
382
383         * DumpRenderTree/chromium/LayoutTestController.cpp:
384         (LayoutTestController::LayoutTestController):
385         * DumpRenderTree/chromium/LayoutTestController.h:
386
387 2011-01-25  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
388
389         Reviewed by Andreas Kling.
390
391         [GTK] Remove 64 bits release bot from the buildbot master
392         https://bugs.webkit.org/show_bug.cgi?id=52899
393
394         Removes the 64 bits release slave from the buildbot configuration,
395         so that we can use it as an EWS.
396
397         * BuildSlaveSupport/build.webkit.org-config/config.json:
398
399 2011-01-24  Maciej Stachowiak  <mjs@apple.com>
400
401         Reviewed by Dan Bernstein.
402
403         Implement database quota callback to fix storage tests on WebKit2 bot
404         https://bugs.webkit.org/show_bug.cgi?id=53064
405
406         * WebKitTestRunner/TestController.cpp:
407         (WTR::exceededDatabaseQuota):
408         (WTR::TestController::createOtherPage):
409         (WTR::TestController::initialize):
410
411 2011-01-24  Maciej Stachowiak  <mjs@apple.com>
412
413         Reviewed by Anders Carlsson.
414
415         Use designated temp directory for the database for WebKit2
416         https://bugs.webkit.org/show_bug.cgi?id=53052
417         
418         Adopt the new WK2 API for this.
419
420         * WebKitTestRunner/TestController.cpp:
421         (WTR::TestController::libraryPathForTesting):
422         (WTR::TestController::initialize):
423         * WebKitTestRunner/TestController.h:
424         * WebKitTestRunner/mac/TestControllerMac.mm:
425         (WTR::TestController::platformLibraryPathForTesting):
426         * WebKitTestRunner/qt/TestControllerQt.cpp:
427         (WTR::TestController::platformLibraryPathForTesting):
428         * WebKitTestRunner/win/TestControllerWin.cpp:
429         (WTR::TestController::platformLibraryPathForTesting):
430
431 2011-01-24  Lucas Forschler  <lforschler@apple.com>
432
433         Reviewed by Stephanie Lewis.
434
435         Add a new Leopard test bot.
436
437         * BuildSlaveSupport/build.webkit.org-config/config.json:
438
439 2011-01-24  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
440
441         Reviewed by Adam Barth.
442
443         Add EFL Builder to core waterfall
444         https://bugs.webkit.org/show_bug.cgi?id=52704
445
446         Add EFL Builder to the core waterfall again.
447
448         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
449         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
450
451 2011-01-24  Xianzhu Wang  <wangxianzhu@google.com>
452
453         Reviewed by Tony Chang.
454
455         new-run-webkit-tests fails to start HTTP server if there are proxy settings
456         https://bugs.webkit.org/show_bug.cgi?id=52872
457
458         Force disabling proxy to resolve the problem.
459
460         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
461         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
462
463 2011-01-24  Andreas Kling  <kling@webkit.org>
464
465         Reviewed by Darin Adler.
466
467         check-webkit-style: Update exemptions following Source/ move.
468         https://bugs.webkit.org/show_bug.cgi?id=53017
469
470         * Scripts/webkitpy/style/checker.py:
471         * Scripts/webkitpy/style/checker_unittest.py:
472
473 2011-01-24  Andras Becsi  <abecsi@webkit.org>
474
475         Rubber-stamped by Csaba Osztrogonác.
476
477         [Qt] Move project files into Source
478         https://bugs.webkit.org/show_bug.cgi?id=52891
479
480         * DumpRenderTree/qt/ImageDiff.pro: Add missing "Source" to WebKit.pri path
481
482 2011-01-24  Mikhail Naganov  <mnaganov@chromium.org>
483
484         Reviewed by Yury Semikhatsky.
485
486         Web Inspector: Find duplicate strings in localizedStrings.js
487
488         https://bugs.webkit.org/show_bug.cgi?id=53005
489
490         * Scripts/check-inspector-strings:
491
492 2011-01-24  Zoltan Horvath  <zoltan@webkit.org>
493
494         Reviewed by Andreas Kling.
495
496         [Qt] Regroup MiniBrowser's menubar and add open file action
497         https://bugs.webkit.org/show_bug.cgi?id=53000
498
499         Add File and Develop menu to MiniBrowser's menubar and add open file action to File menu.
500
501         * MiniBrowser/qt/BrowserWindow.cpp:
502         (BrowserWindow::BrowserWindow):
503         (BrowserWindow::openFile):
504         (BrowserWindow::~BrowserWindow):
505         * MiniBrowser/qt/BrowserWindow.h:
506
507 2011-01-24  Csaba Osztrogonác  <ossy@webkit.org>
508
509         Unreviewed fix after r76496
510
511         [Qt] Move project files into Source
512         https://bugs.webkit.org/show_bug.cgi?id=52891
513
514         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Remove unnecessary "Source" from the path.
515         * BuildSlaveSupport/built-product-archive: Remove unnecessary "Source" from the path.
516         * Scripts/webkitdirs.pm: Add the accidentally removed slash to the path.
517
518 2011-01-24  Andras Becsi  <abecsi@webkit.org>
519
520         Reviewed by Csaba Osztrogonác.
521
522         [Qt] Move project files into Source
523         https://bugs.webkit.org/show_bug.cgi?id=52891
524
525         * DerivedSources.pro: Renamed from DerivedSources.pro.
526         * DumpRenderTree/qt/DumpRenderTree.pro:
527         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
528         * MiniBrowser/DerivedSources.pro:
529         * MiniBrowser/qt/MiniBrowser.pro:
530         * QtTestBrowser/QtTestBrowser.pro:
531         * Scripts/webkitdirs.pm:
532         * Tools.pro: Added.
533         * WebKitTestRunner/DerivedSources.pro:
534         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
535         * WebKitTestRunner/qt/WebKitTestRunner.pro:
536
537 2011-01-22  Geoffrey Garen  <ggaren@apple.com>
538
539         Reviewed by Dan Bernstein.
540
541         Beefed up --threaded mode to catch even more kinds of errors.
542         https://bugs.webkit.org/show_bug.cgi?id=52971
543
544         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Use a shared
545         context group to force JSC to mark multiple threads. (This used to be
546         the default, but it changed in SnowLeopard.)
547         (runJavaScriptThread): Do more locking and unlocking, and more allocation,
548         to give threading mistakes more chances to show themselves.
549         (startJavaScriptThreads):
550         (stopJavaScriptThreads):
551
552 2011-01-22  Robert Hogan  <robert@webkit.org>
553
554         Reviewed by Andreas Kling.
555
556         [Qt] Support layoutTestController.addURLToRedirect()
557         https://bugs.webkit.org/show_bug.cgi?id=52956
558
559         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
560         (LayoutTestController::addURLToRedirect):
561         * DumpRenderTree/qt/LayoutTestControllerQt.h:
562
563 2011-01-22  Robert Hogan  <robert@webkit.org>
564
565         Reviewed by Kenneth Rohde Christiansen.
566
567         [Qt] REGRESSION (r72360): http/tests/security/aboutBlank/xss-DENIED-* tests fail
568         https://bugs.webkit.org/show_bug.cgi?id=49802
569
570         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
571         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
572         (WebCore::DumpRenderTree::open):
573
574 2011-01-21  Adam Barth  <abarth@webkit.org>
575
576         Reviewed by Maciej Stachowiak.
577
578         Disable mac_unittest.py that fails on some of the Mac bots
579         https://bugs.webkit.org/show_bug.cgi?id=52947
580
581         As noted in the comment, this test does not appear to be correct
582         because the function this test is testing returns different results
583         depending on which flavor of Mac the test is run on.  This patch
584         disable the test.  Hopefully we can re-enable the test once we've
585         probably insulated the test from its environment.
586
587         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
588
589 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
590
591         Reviewed by Mihai Parparita.
592
593         Fix bug introduced in r76322 that caused NRWT to not actually
594         read the Skipped files properly.
595
596         https://bugs.webkit.org/show_bug.cgi?id=52771
597
598         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
599         * Scripts/webkitpy/layout_tests/port/webkit.py:
600         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
601
602 2011-01-21  Sam Weinig  <sam@webkit.org>
603
604         Reviewed by Geoffrey Sean Garen and Mark Rowe.
605
606         WebKitTestRunner needs the HOME environment variable to be set.
607         <rdar://problem/8896573>
608
609         * Scripts/old-run-webkit-tests: Set the HOME environment variable if
610         it exists.
611
612 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
613
614         Reviewed by Eric Seidel.
615
616         Suppress a few remaining integration tests so that none of the
617         layout_test unit tests ever read from the filesystem or launch
618         subprocesses that aren't part of the unit tests.
619
620         Also fix a minor bug in the printing unit tests that was
621         incorrectly relying on sys.argv.
622
623         https://bugs.webkit.org/show_bug.cgi?id=52863
624
625         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
626         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
627         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
628
629 2011-01-21  Darin Adler  <darin@apple.com>
630
631        Fix Mac build.
632
633         * MiniBrowser/mac/BrowserWindowController.m:
634         (-[BrowserWindowController awakeFromNib]): Pass 0 for runModal function.
635
636 2011-01-20  Darin Adler  <darin@apple.com>
637
638         Reviewed by Dan Bernstein.
639
640         WebKit2: Implement showModalDialog
641         https://bugs.webkit.org/show_bug.cgi?id=52855
642
643         This fixes WebKitTestRunner to compile, but more work is probably
644         needed to get it to pass the tests.
645
646         * WebKitTestRunner/TestController.cpp:
647         (WTR::TestController::runModal): Added. Calls through to the
648         platform-specific version of runModal.
649         (WTR::TestController::createOtherPage): Changed to be a private
650         static member function so it can refer to runModal, which is
651         a private static member function.
652         (WTR::TestController::initialize): Pass 0 for the runModal
653         function since we don't need to run the main window modal.
654         I suspect this is wrong and will need to change.
655         * WebKitTestRunner/TestController.h: Added declarations for
656         the functions added above.
657         * WebKitTestRunner/mac/TestControllerMac.mm:
658         (WTR::TestController::runModal): Added. Untested implementation.
659         * WebKitTestRunner/qt/TestControllerQt.cpp:
660         (WTR::TestController::runModal): Added.
661         * WebKitTestRunner/win/TestControllerWin.cpp:
662         (WTR::TestController::runModal): Added.
663
664 2011-01-21  Eric Seidel  <eric@webkit.org>
665
666         Reviewed by Adam Barth.
667
668         Split Host object off from WebKitPatch for easier re-use
669         https://bugs.webkit.org/show_bug.cgi?id=52284
670
671         new-run-webkit-tests and other tools are eventually going to want one of these.
672         Basically you need to inherit from this class if you want to pretend to be a
673         self.tool object for Steps/Commands.
674
675         * Scripts/webkitpy/common/host.py: Added.
676         * Scripts/webkitpy/tool/main.py:
677
678 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
679
680         Reviewed by Adam Barth.
681
682         Disable the tests that start and stop the http server and web
683         server, so that we don't have to worry about port collisions on
684         the bots.
685
686         https://bugs.webkit.org/show_bug.cgi?id=52861
687
688         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
689
690 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
691
692         Reviewed by Eric Seidel.
693
694         nrwt: rewrite google_chrome_unittest to use mock filesystem.
695         
696         https://bugs.webkit.org/show_bug.cgi?id=52772
697         
698         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
699
700 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
701
702         Reviewed by Eric Siedel.
703
704         nrwt: clean up almost all remaining port references, remove
705         unnecessary import clauses. The only remaining references are
706         in places where a mock filesystem makes no sense or can't be
707         used, and in one routine in port/google_chrome_unittest that
708         I'll rewrite in a separate patch.
709
710         https://bugs.webkit.org/show_bug.cgi?id=52771
711
712         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
713         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
714         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
715         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
716         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
717         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
718         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
719         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
720         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
721         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
722         * Scripts/webkitpy/layout_tests/port/gtk.py:
723         * Scripts/webkitpy/layout_tests/port/mac.py:
724         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
725         * Scripts/webkitpy/layout_tests/port/qt.py:
726         * Scripts/webkitpy/layout_tests/port/webkit.py:
727         * Scripts/webkitpy/layout_tests/port/win.py:
728         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
729
730 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
731
732         Reviewed by Mihai Parparita.
733
734         remove fs refs from run_webkit_tests, rebaseline_chromium_webkit_tests
735
736         https://bugs.webkit.org/show_bug.cgi?id=52762
737
738         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
739         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
740
741 2011-01-20  Tony Chang  <tony@chromium.org>
742
743         Reviewed by Ojan Vafai.
744
745         [chromium] fix the paths used for the rebaseline tool
746         https://bugs.webkit.org/show_bug.cgi?id=52857
747
748         Some of the bots were renamed so the path to grab the results zip
749         file has changed.
750
751         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
752
753 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
754
755         Reviewed by Tony Chang.
756
757         Fix bug introduced in r72688 / bug 52768 that broke the
758         generation of the output filename links in the results.html
759         output. Apparently none of the unit tests actually checked to
760         make sure the generated links were correct :(
761
762         https://bugs.webkit.org/show_bug.cgi?id=52854
763
764         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
765         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
766
767 2011-01-20  Alexey Proskuryakov  <ap@apple.com>
768
769         Reviewed by Darin Adler.
770
771         https://bugs.webkit.org/show_bug.cgi?id=52849
772         Make window.print work with WebKit2
773
774         * MiniBrowser/mac/BrowserWindowController.m:
775         (-[BrowserWindowController awakeFromNib]):
776         * WebKitTestRunner/TestController.cpp:
777         (WTR::createOtherPage):
778         (WTR::TestController::initialize):
779         Added zeroes to WKPageUIClient structures to avoid build failures.
780
781 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
782
783         Reviewed by Eric Seidel.
784
785         nrwt: remove fs refs from printing, test_failures, test_expectations, text_diff
786
787         https://bugs.webkit.org/show_bug.cgi?id=52756
788
789         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
790         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
791         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
792         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
793         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
794         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
795
796 2011-01-20  Mansi Mithal  <mansi.mithal@nokia.com>
797
798         Reviewed by Antonio Gomes.
799
800         QtTestBrowser should have a seperate menu for Settings
801         https://bugs.webkit.org/show_bug.cgi?id=52817
802         
803         Added a new menu item named "Settings"
804         and moved the "Enable interrupting js scripts" and "Enable js pop up windows" under the "Settings" menu 
805
806         * QtTestBrowser/launcherwindow.cpp:
807         (LauncherWindow::createChrome):
808
809 2011-01-20  Sam Weinig  <sam@webkit.org>
810
811         Reviewed by John Sullivan.
812
813         Update update-webkit-localizable-strings with new path to WebKit.
814
815         * Scripts/update-webkit-localizable-strings:
816
817 2011-01-20  James Robinson  <jamesr@chromium.org>
818
819         Reviewed by Darin Fisher.
820
821         Implement mozilla's requestAnimationFrame API
822         https://bugs.webkit.org/show_bug.cgi?id=51218
823
824         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
825
826         * DumpRenderTree/chromium/WebViewHost.cpp:
827         (invokeScheduleComposite):
828         (WebViewHost::scheduleAnimation):
829         (WebViewHost::paintInvalidatedRegion):
830         * DumpRenderTree/chromium/WebViewHost.h:
831
832 2011-01-20  Maciej Stachowiak  <mjs@apple.com>
833
834         Reviewed by Adam Roben.
835
836         WebKitTestRunner needs to support layoutTestController.evaluateScriptInIsolatedWorld
837         https://bugs.webkit.org/show_bug.cgi?id=42327
838
839         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Add support
840         for methods that take their normal arguments but also a JSContextRef.
841         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: IDL definition
842         for evaluateScriptInIsolatedWorld.
843         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
844         (WTR::InjectedBundlePage::didClearWindowForFrame): Set a magic variable only if
845         this call is for an isolated world.
846         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
847         (WTR::worldMap): Helper to create a world map.
848         (WTR::LayoutTestController::worldIDForWorld): Map from an ID to a world.
849         (WTR::LayoutTestController::evaluateScriptInIsolatedWorld): The newly
850         added LayoutTestController API.
851         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
852
853 2011-01-19  Adam Roben  <aroben@apple.com>
854
855         Convert paths in environment variables back to msys-style inside commit-log-editor
856
857         When this script gets run from inside git commit, msys-style paths in the environment will
858         have been turned into Windows-style paths with forward slashes. This screws up functions
859         like File::Spec->rel2abs, which seem to rely on $PWD having an msys-style path. We convert
860         the paths back to msys-style before doing anything else.
861
862         Fixes <http://webkit.org/b/48527> commit-log-editor uses full paths for section headers when
863         using msysgit's Perl and multiple ChangeLogs have been edited
864
865         Reviewed by David Kilzer.
866
867         * Scripts/commit-log-editor: Call fixEnvironment before doing anything else.
868         (fixEnvironment): Added. When run in msys in conjunction with git (i.e., when invoked from
869         inside git commit), convert Windows-style paths in the environment back to msys-style paths.
870
871 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
872
873         [Win] Unreviewed build fix after r76248.
874
875         * DumpRenderTree/ForwardingHeaders/wtf/FastAllocBase.h: Added.
876
877 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
878
879         Reviewed by Csaba Osztrogonác.
880
881         Refactoring of the custom allocation framework
882         https://bugs.webkit.org/show_bug.cgi?id=49897
883
884         Inheriting from FastAllocBase can result in objects getting larger (bug #33896, #46589).
885         The modification replaces Noncopyable and FastAllocBase classes and these inherits with their
886         equivalent macro implementation at the necessary places.
887 2011-01-20  Yi Shen  <yi.4.shen@nokia.com>
888
889         Unreviewed. 
890
891         Adding myself to committers.py.
892
893         * Scripts/webkitpy/common/config/committers.py:
894
895 2011-01-20  Adam Barth  <abarth@webkit.org>
896
897         Reviewed by Tony Chang.
898
899         Chromium builders don't delete unversioned directories when DEPS change
900         https://bugs.webkit.org/show_bug.cgi?id=52745
901
902         If we pass this option to gclient sync, gclient will delete directories
903         that are no longer part of DEPS instead of leaving them around to
904         confuse us later.  Apparently, the downstream buildbots use this option
905         already.
906
907         * Scripts/update-webkit-chromium:
908
909 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
910
911         Unreviewed, build fix - I pulled this patch in to fix an issue
912         revealed by r76195 running on some new bots). Also fix a couple
913         of other issues revealed in testing.
914
915         nrwt: remove fs refs from layout_package/json*
916
917         https://bugs.webkit.org/show_bug.cgi?id=52754
918
919         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
920         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
921         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
922         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
923         * Scripts/webkitpy/layout_tests/port/base.py:
924
925 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
926
927         Unreviewed, build fix.
928
929         Fix a couple of minor bugs discovered while bringing up new bots
930         for testing.
931
932         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
933         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
934
935 2011-01-19  James Robinson  <jamesr@chromium.org>
936
937         Unreviewed, rolling out r76194.
938         http://trac.webkit.org/changeset/76194
939         https://bugs.webkit.org/show_bug.cgi?id=51218
940
941         Caused mysterious compile failure on the chromium win
942         build.webkit.org bots
943
944         * DumpRenderTree/chromium/WebViewHost.cpp:
945         (WebViewHost::paintInvalidatedRegion):
946         * DumpRenderTree/chromium/WebViewHost.h:
947
948 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
949
950         Reviewed by Mihai Parparita.
951
952         remove fs refs from test_runner, dump_render_tree_thread
953
954         https://bugs.webkit.org/show_bug.cgi?id=52753
955
956         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
957         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
958         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
959         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
960
961 2011-01-19  James Robinson  <jamesr@chromium.org>
962
963         Reviewed by Darin Fisher.
964
965         Implement mozilla's requestAnimationFrame API
966         https://bugs.webkit.org/show_bug.cgi?id=51218
967
968         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
969
970         * DumpRenderTree/chromium/WebViewHost.cpp:
971         (invokeScheduleComposite):
972         (WebViewHost::scheduleAnimation):
973         (WebViewHost::paintInvalidatedRegion):
974         * DumpRenderTree/chromium/WebViewHost.h:
975
976 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
977
978         Unreviewed, build fix.
979
980         Fix a few incorrect "self._filesystem" references introduced in
981         r76184.
982
983         * Scripts/webkitpy/layout_tests/port/chromium.py:
984         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
985
986 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
987
988         Reviewed by Mihai Parparita.
989
990         add a .sep property, abspath(), isabs(), mtime(), and
991         open_text_file_for_writing() to filesystem modules. Some of
992         these properties are not needed in this patch but will be needed
993         in subsequent patches (I'm doing this to avoid having to track
994         multiple versions of a single file).
995
996         Also, change most of the port/* modules to use the filesystem
997         objects instead of referencing the filesystem directly.
998
999         https://bugs.webkit.org/show_bug.cgi?id=52748
1000
1001         * Scripts/webkitpy/common/system/filesystem.py:
1002         * Scripts/webkitpy/common/system/filesystem_mock.py:
1003         * Scripts/webkitpy/layout_tests/port/__init__.py:
1004         * Scripts/webkitpy/layout_tests/port/base.py:
1005         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1006         * Scripts/webkitpy/layout_tests/port/chromium.py:
1007         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1008         * Scripts/webkitpy/layout_tests/port/config.py:
1009         * Scripts/webkitpy/layout_tests/port/test.py:
1010         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
1011
1012 2011-01-19  Maciej Stachowiak  <mjs@apple.com>
1013
1014         Reviewed by Anders Carlsson.
1015
1016         If resetting between tests times out, treat it as a WebProcess crash
1017         https://bugs.webkit.org/show_bug.cgi?id=52757
1018
1019         * WebKitTestRunner/TestController.cpp:
1020         (WTR::TestController::runTest):
1021
1022 2011-01-19  Alexey Proskuryakov  <ap@apple.com>
1023
1024         Reviewed by Darin Adler.
1025
1026         https://bugs.webkit.org/show_bug.cgi?id=52739
1027         Make it possible for a WebKit2 client to print headers and footers
1028
1029         Added dummy implementations for new printing UIClient calls.
1030
1031         * MiniBrowser/mac/BrowserWindowController.m:
1032         (-[BrowserWindowController awakeFromNib]):
1033         * WebKitTestRunner/TestController.cpp:
1034         (WTR::createOtherPage):
1035         (WTR::TestController::initialize):
1036
1037 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1038
1039         Reviewed by Ojan Vafai.
1040
1041         Change webkitpy/layout_tests/port/test.py to use the
1042         in-memory filesystem for cleaner unit testing. This
1043         change allows us to kill a lot of code that was
1044         specific to the test port, at the cost of being a
1045         little less clear about how things would work if
1046         you didn't have a filesystem.
1047
1048         https://bugs.webkit.org/show_bug.cgi?id=52605
1049
1050         * Scripts/webkitpy/layout_tests/port/test.py:
1051
1052 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1053
1054         Unreviewed, build fix.
1055
1056         Fix test failure caused by committing attachment 79368 instead
1057         of attachment 79461 on bug 52604.
1058
1059         * Scripts/webkitpy/common/system/filesystem_mock.py:
1060
1061 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1062
1063         Reviewed by Mihai Parparita.
1064
1065         new-run-webkit-tests: remove use of os.walk, use mock filesystem for better
1066         unit testing. os.walk() is too much of a hassle to implement on
1067         top of the in-memory mock filesystem and adding the necessary
1068         interface to files_under() gives clients a cleaner API anyway
1069         (for this particular usage model).
1070
1071         https://bugs.webkit.org/show_bug.cgi?id=52691
1072
1073         * Scripts/webkitpy/common/system/filesystem.py:
1074         * Scripts/webkitpy/common/system/filesystem_mock.py:
1075         * Scripts/webkitpy/layout_tests/port/test_files.py:
1076         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
1077
1078 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1079
1080         Reviewed by Tony Chang.
1081
1082         Change more modules in the layout-tests code to use the
1083         filesystem wrapper for cleaner unit testing.
1084
1085         This patch also adds the glob() wrapper to the filesystem
1086         abstraction.
1087         
1088         https://bugs.webkit.org/show_bug.cgi?id=52604
1089
1090         * Scripts/webkitpy/layout_tests/port/test_files.py:
1091         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
1092         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
1093         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1094         * Scripts/webkitpy/common/system/filesystem.py:
1095         * Scripts/webkitpy/common/system/filesystem_mock.py:
1096
1097 2011-01-19  Levi Weintraub  <leviw@chromium.org>
1098
1099         Unreviewed.
1100
1101         Updating my email addresses and irc nick.
1102
1103         * Scripts/webkitpy/common/config/committers.py:
1104
1105 2011-01-19  Tony Chang  <tony@chromium.org>
1106
1107         Reviewed by Mihai Parparita.
1108
1109         [chromium] [linux] if check-sys-deps fails, output the failure reason
1110         https://bugs.webkit.org/show_bug.cgi?id=52671
1111
1112         * Scripts/webkitpy/common/system/executive_mock.py: Add support for
1113             error handler functions.
1114         * Scripts/webkitpy/layout_tests/port/chromium.py:
1115             output the error text from --check-sys-deps
1116         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1117
1118 2011-01-19  Aparna Nandyal  <aparna.nand@wipro.com>
1119
1120         Reviewed by Andreas Kling.
1121
1122         [Qt] QtTestBrowser crashes when closing if Facebook is opened
1123         https://bugs.webkit.org/show_bug.cgi?id=52554
1124         
1125         QtNetworkAccessManager is created in a thread and set as
1126         member variable in QWebPage. When the thread is destroyed
1127         the object is still used. So fix will set the object to
1128         NULL once the thread is destroyed.
1129
1130         * QtTestBrowser/launcherwindow.cpp:
1131         (LauncherWindow::~LauncherWindow):
1132
1133 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
1134
1135         Rubber stamped by Csaba Osztrogonac
1136
1137         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Removed unncessary inculde of WKStringCF.h
1138
1139 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
1140
1141         Reviewed by Tony Chang.
1142
1143         new-run-webkit-tests: add a --build-directory command line argument
1144
1145         Official Google Chrome builds use a non-standard build directory
1146         location. This patch adds a --build-directory argument that
1147         allows that location to be specified on the command line. Only
1148         Chromium-based builds will use this flag for now, but anyone can
1149         in the future.
1150
1151         There are no unit tests for this since it's difficult to test
1152         until mock filesystems are fully supported in the code. This was
1153         tested by hand for now.
1154
1155         https://bugs.webkit.org/show_bug.cgi?id=52694
1156
1157         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1158         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1159         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1160         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1161
1162 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
1163
1164         Not reviewed. Bot fix.
1165
1166         Remove an inadvertently committed debugging print.
1167
1168         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1169         (LayoutTestController::notifyDone):
1170
1171 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
1172
1173         Reviewed by Sam Weinig.
1174
1175         WebKitTestRunner should track loading more like DumpRenderTree
1176         https://bugs.webkit.org/show_bug.cgi?id=52692
1177
1178         Change load tracking to track the current top loading frame, in the manner of DumpRenderTree.
1179         This makes some tests that call notifyDone multiple times pass.
1180         
1181         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1182         (WTR::InjectedBundle::InjectedBundle):
1183         (WTR::InjectedBundle::done):
1184         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1185         (WTR::InjectedBundle::topLoadingFrame):
1186         (WTR::InjectedBundle::setTopLoadingFrame):
1187         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1188         (WTR::InjectedBundlePage::InjectedBundlePage):
1189         (WTR::InjectedBundlePage::stopLoading):
1190         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
1191         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
1192         (WTR::InjectedBundlePage::didFinishLoadForFrame):
1193         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
1194         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1195         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1196         (WTR::LayoutTestController::notifyDone):
1197         * WebKitTestRunner/TestController.cpp:
1198         (WTR::TestController::didReceiveMessageFromInjectedBundle):
1199
1200 2011-01-18  Mihai Parparita  <mihaip@chromium.org>
1201
1202         Reviewed by Kent Tamura.
1203
1204         [Chromium] NRWT looking for DRT binary in the wrong path on Mac
1205         https://bugs.webkit.org/show_bug.cgi?id=52678
1206         
1207         Update path now that WebKit is inside Source.
1208
1209         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1210
1211 2011-01-18  Robert Hogan  <robert@webkit.org>
1212
1213         Reviewed by Simon Hausmann.
1214
1215         [Qt] http/tests/incremental/slow-utf8-text.pl fails
1216         https://bugs.webkit.org/show_bug.cgi?id=44282
1217
1218         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1219         (WebCore::DumpRenderTree::dump):
1220
1221 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
1222
1223         Reviewed by Mihai Parparita.
1224
1225         Fix a small race condition that could cause the unit tests for
1226         new-run-webkit-tests to fail in a multithreaded environment.
1227         There was a small window in the code where one thread would
1228         check to see if a thread had raised an exception, do something,
1229         and then check to see if the thread was alive. If the other
1230         thread raised an exception and exited in between these two
1231         steps, the exception would be lost. Flipping the order of the
1232         two checks fixes the race, since we will now always check for an
1233         exception on the thread before exiting.
1234
1235         https://bugs.webkit.org/show_bug.cgi?id=51579
1236
1237         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
1238
1239 2011-01-18  Eric Seidel  <eric@webkit.org>
1240
1241         Reviewed by Adam Barth.
1242
1243         commit-queue dies when test archiving fails
1244         https://bugs.webkit.org/show_bug.cgi?id=52617
1245
1246         I looked at the machine and it had 10 archives already
1247         thus find_unused_name was returning None.  I've upped
1248         the limit to 100 (per bug) and tested the case where
1249         find_unused_name returns None (making archive return None).
1250
1251         * Scripts/webkitpy/common/system/workspace.py:
1252         * Scripts/webkitpy/common/system/workspace_unittest.py:
1253         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1254         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1255         * Scripts/webkitpy/tool/commands/queues.py:
1256
1257 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
1258
1259         Reviewed by Ojan Vafai.
1260
1261         Update rebaseline-chromium-webkit-tests unit tests to use a mock
1262         filesystem. Also fix a couple of "with" statements missed by
1263         r76050.
1264
1265         https://bugs.webkit.org/show_bug.cgi?id=52487
1266
1267         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1268
1269 2011-01-18  Sergio Villar Senin  <svillar@igalia.com>
1270
1271         Reviewed by Martin Robinson.
1272
1273         [Gtk] Build fixes for gtk3 build
1274         https://bugs.webkit.org/show_bug.cgi?id=52648
1275
1276         * DumpRenderTree/gtk/EventSender.cpp:
1277         (beginDragWithFilesCallback):
1278
1279 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
1280
1281         Reviewed by Mihai Parparita.
1282
1283         Update rebaseline-chromium-webkit-tests to use filesystem objects
1284         instead of direct references to os.path, shutil, tempfile, etc.
1285
1286         This patch doesn't change anything, but will allow subsequent
1287         patches to change the unit tests to no longer use the real
1288         filesystem.
1289
1290         This patch adds a bunch more methods to the filesystem object as
1291         well.
1292
1293         https://bugs.webkit.org/show_bug.cgi?id=52482
1294
1295         * Scripts/webkitpy/common/system/filesystem.py:
1296         * Scripts/webkitpy/common/system/filesystem_mock.py:
1297         * Scripts/webkitpy/tool/commands/queues.py:
1298         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1299         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1300
1301 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
1302
1303         Reviewed by Mihai Parparita.
1304
1305         new-run-webkit-tests shouldn't crash when you try to run a
1306         directory containing only skipped files.
1307
1308         https://bugs.webkit.org/show_bug.cgi?id=52478
1309         
1310         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1311         * Scripts/webkitpy/layout_tests/port/test.py:
1312         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1313
1314 2011-01-18  Adam Bergkvist  <adam.bergkvist@ericsson.com> and Martin Robinson  <mrobinson@igalia.com>
1315
1316         Reviewed by Gustavo Noronha Silva.
1317
1318         [GTK] The GTK+ EventSender needs support for beginDragWithFiles
1319         https://bugs.webkit.org/show_bug.cgi?id=40833
1320
1321         * DumpRenderTree/gtk/EventSender.cpp: Add a beginDragWithFiles implementation for the
1322         GTK+ event sender.
1323         (dragWithFilesDragDataGetCallback): Added.
1324         (dragWithFilesDragEndCallback): Added.
1325         (beginDragWithFilesCallback): Added.
1326
1327 2011-01-18  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1328
1329         Reviewed by Adam Barth.
1330
1331         ews: Add additional watcher to efl ews
1332         https://bugs.webkit.org/show_bug.cgi?id=52613
1333
1334         Add gyuyoung.kim@samsung.com to watcher list of efl-ews.
1335
1336         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1337
1338 2011-01-17  Tony Gentilcore  <tonyg@chromium.org>
1339
1340         Reviewed by Alexey Proskuryakov.
1341
1342         Fix some headers with missing or misspelled #ifndef guards
1343         https://bugs.webkit.org/show_bug.cgi?id=52545
1344
1345         * DumpRenderTree/chromium/TestEventPrinter.h:
1346         * DumpRenderTree/chromium/WebPreferences.h:
1347
1348 2011-01-17  Jessie Berlin  <jberlin@apple.com>
1349
1350         Reviewed by Anders Carlsson.
1351
1352         REGRESSION: Assertion failure in FrameLoader::continueLoadAfterWillSubmitForm() when
1353         navigating back to an unreachable URL
1354         https://bugs.webkit.org/show_bug.cgi?id=52388
1355
1356         Add a third parameter (unreachableURL) to queueLoadHTMLString.
1357
1358         * DumpRenderTree/LayoutTestController.cpp:
1359         (queueLoadHTMLStringCallback):
1360         (LayoutTestController::queueLoadHTMLString):
1361         (LayoutTestController::queueLoadAlternateHTMLString):
1362         * DumpRenderTree/LayoutTestController.h:
1363
1364         * DumpRenderTree/WorkQueueItem.h:
1365         (LoadHTMLStringItem::LoadHTMLStringItem):
1366
1367         * DumpRenderTree/chromium/LayoutTestController.cpp:
1368         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
1369         (WorkItemLoadHTMLString::run):
1370         (LayoutTestController::queueLoadHTMLString):
1371
1372         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
1373         (LoadHTMLStringItem::invoke):
1374         * DumpRenderTree/mac/WorkQueueItemMac.mm:
1375         (LoadHTMLStringItem::invoke):
1376         * DumpRenderTree/win/WorkQueueItemWin.cpp:
1377         (LoadHTMLStringItem::invoke):
1378
1379 2011-01-17  Dan Bernstein  <mitz@apple.com>
1380
1381         Rubber-stamped by Mark Rowe.
1382
1383         Update xcodeproj svn:ignore to include xcuserdata.
1384
1385         * DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
1386         * MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
1387         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
1388         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
1389         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
1390
1391 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
1392
1393         Unreviewed fix after r75908.
1394
1395         Move WebKit into Source
1396         https://bugs.webkit.org/show_bug.cgi?id=52530
1397
1398         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add Source to the path for Qt API tests.
1399
1400 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
1401
1402         Unreviewed.
1403
1404         Remove accidentally committed debug printing after r75908.
1405
1406         * Scripts/webkitdirs.pm:
1407
1408 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
1409
1410         Unreviewed.
1411
1412         Add myself to committers list
1413         https://bugs.webkit.org/show_bug.cgi?id=52566
1414
1415         * Scripts/webkitpy/common/config/committers.py:
1416
1417 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
1418
1419         Reviewed by Jeremy Orlow.
1420
1421         GeolocationController should call stopUpdating on destruction
1422         https://bugs.webkit.org/show_bug.cgi?id=52216
1423
1424         fast/dom/Geolocation/window-close-crash.html requires that a
1425         Geolocation watch be started in a secondary window. Consequently,
1426         we need to allow geolocation permission and provide a mock
1427         geolocation position for the secondary window's
1428         GeolocationClientMock.
1429
1430         * DumpRenderTree/chromium/LayoutTestController.cpp:
1431         (LayoutTestController::setGeolocationPermission):
1432         (LayoutTestController::setMockGeolocationPosition):
1433         (LayoutTestController::setMockGeolocationError):
1434         * DumpRenderTree/chromium/TestShell.h:
1435         (TestShell::windowList):
1436
1437 2011-01-16  Adam Barth  <abarth@webkit.org>
1438
1439         Update more include paths to reflect WebKit move.
1440
1441         * DumpRenderTree/chromium/EventSender.cpp:
1442         (EventSender::keyDown):
1443         (EventSender::needsShiftModifier):
1444         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
1445         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
1446
1447 2011-01-16  Kent Tamura  <tkent@chromium.org>
1448
1449         Unreviewed, Chromium build fix.
1450
1451         * Scripts/update-webkit-chromium: Webkit/chromium -> Source/WebKit/chromium
1452
1453 2011-01-16  Martin Robinson  <mrobinson@igalia.com>
1454
1455         Build fix for GTK+ after source directory movement.
1456
1457         * GNUmakefile.am: Correct include paths.
1458
1459 2011-01-16  Adam Barth  <abarth@webkit.org>
1460
1461         Teach svn-apply about WebKit move.
1462
1463         * Scripts/VCSUtils.pm:
1464
1465 2011-01-16  Adam Barth  <abarth@webkit.org>
1466
1467         Rubber-stamped by Eric Seidel.
1468
1469         Move WebKit into Source
1470         https://bugs.webkit.org/show_bug.cgi?id=52530
1471
1472         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
1473         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1474         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1475         * DumpRenderTree/qt/GCControllerQt.cpp:
1476         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1477         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
1478         * DumpRenderTree/qt/TextInputControllerQt.cpp:
1479         * DumpRenderTree/wscript:
1480         * QtTestBrowser/launcherwindow.h:
1481         * Scripts/build-webkit:
1482         * Scripts/webkitdirs.pm:
1483
1484 2011-01-15  Adam Barth  <abarth@webkit.org>
1485
1486         Teach svn-apply about WebKit2 move.
1487
1488         * Scripts/VCSUtils.pm:
1489
1490 2011-01-15  Adam Barth  <abarth@webkit.org>
1491
1492         Rubber-stamped by Eric Seidel.
1493
1494         Move WebKit2 into Source
1495         https://bugs.webkit.org/show_bug.cgi?id=52438
1496
1497         * MiniBrowser/qt/MiniBrowser.pro:
1498         * Scripts/build-webkit:
1499         * Scripts/do-file-rename:
1500         * Scripts/do-webcore-rename:
1501         * Scripts/test-webkitpy:
1502         * Scripts/webkitdirs.pm:
1503         * Scripts/webkitpy/style/checker.py:
1504         * WebKitTestRunner/DerivedSources.pro:
1505         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1506         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1507
1508 2011-01-15  Jochen Eisinger  <jochen@chromium.org>
1509
1510         Reviewed by David Levin.
1511
1512         [chromium] remove obsolete createView method
1513         https://bugs.webkit.org/show_bug.cgi?id=52437
1514
1515         * DumpRenderTree/chromium/WebViewHost.cpp:
1516         (WebViewHost::createView):
1517         * DumpRenderTree/chromium/WebViewHost.h:
1518
1519 2011-01-14  Brian Weinstein  <bweinstein@apple.com>
1520
1521         Reviewed by Geoff Garen.
1522
1523         ShouldLoadResourceForFrame should use strings, not URLs.
1524         https://bugs.webkit.org/show_bug.cgi?id=52476
1525
1526         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1527         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Update to use a WKStringRef.
1528         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1529
1530 2011-01-14  Tony Gentilcore  <tonyg@chromium.org>
1531
1532         Reviewed by David Levin.
1533
1534         Add Tony Gentilcore as a reviewer
1535         https://bugs.webkit.org/show_bug.cgi?id=52480
1536
1537         * Scripts/webkitpy/common/config/committers.py:
1538
1539 2011-01-14  David Levin  <levin@chromium.org>
1540
1541         Reviewed by Eric Seidel.
1542
1543         check-webkit-style: _FunctionState should keep track of where the function name starts.
1544         https://bugs.webkit.org/show_bug.cgi?id=52454
1545
1546         * Scripts/webkitpy/style/checkers/cpp.py: Added function_name_start_position to
1547         _FunctionState and logic for setting it correctly.
1548         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests.
1549
1550 2011-01-14  Vincent Scheib  <scheib@chromium.org>
1551
1552         Reviewed by David Levin.
1553
1554         Add support to DumpRenderTree to use the GPU rather than software renderer
1555         https://bugs.webkit.org/show_bug.cgi?id=52333
1556
1557         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1558         (main):
1559         * Scripts/webkitpy/layout_tests/port/chromium.py:
1560         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1561
1562 2011-01-14  Tony Chang  <tony@chromium.org>
1563
1564         Reviewed by Kent Tamura.
1565
1566         [chromium] update fonts.conf to fix 6 linux tests in drt
1567         https://bugs.webkit.org/show_bug.cgi?id=52411
1568
1569         * DumpRenderTree/chromium/fonts.conf: Update to match the copy in
1570             chromium's src/webkit/tools/test_shell/resources/fonts.conf
1571
1572 2011-01-14  Eric Seidel  <eric@webkit.org>
1573
1574         Original patch from Peter Gal  <galpater@inf.u-szeged.hu>
1575
1576         Reviewed by Adam Barth.
1577
1578         Fix when running Tools/Scripts/check-webkit-style without arguments.
1579         https://bugs.webkit.org/show_bug.cgi?id=52261#c16
1580
1581         * Scripts/webkitpy/common/checkout/scm.py: Handle None for changed_files argument better in Git.create_patch method.
1582         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1583
1584 2011-01-04  Jochen Eisinger  <jochen@chromium.org>
1585
1586         Reviewed by David Levin.
1587
1588         Store the tempdir object in a variable so it doesn't get deleted too early.
1589         https://bugs.webkit.org/show_bug.cgi?id=51875
1590
1591         * Scripts/update-webkit-auxiliary-libs:
1592         * Scripts/update-webkit-support-libs:
1593
1594 2011-01-14  Eric Seidel  <eric@webkit.org>
1595
1596         Unreviewed.  Make it work in python 2.5.
1597
1598         webkit-patch suggest-reviewers dies when ChangeLogs are missing
1599         https://bugs.webkit.org/show_bug.cgi?id=49158
1600
1601         * Scripts/webkitpy/common/checkout/api_unittest.py:
1602
1603 2011-01-14  Sheriff Bot  <webkit.review.bot@gmail.com>
1604
1605         Unreviewed, rolling out r75774.
1606         http://trac.webkit.org/changeset/75774
1607         https://bugs.webkit.org/show_bug.cgi?id=52431
1608
1609         gtk builds were broken (Requested by loislo2 on #webkit).
1610
1611         * Scripts/webkitpy/common/checkout/scm.py:
1612
1613 2011-01-14  David Levin  <levin@chromium.org>
1614
1615         Reviewed by Shinichiro Hamaji.
1616
1617         check-webkit-style: _FunctionState should detect pure functions.
1618         https://bugs.webkit.org/show_bug.cgi?id=52428
1619
1620         * Scripts/webkitpy/style/checkers/cpp.py: Added detection for if a function declaration
1621         is a pure virtual function.
1622         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests for verifying that pure
1623         virtual functions are correctly detected.
1624
1625 2011-01-13  Ilya Tikhonovsky  <loislo@chromium.org>
1626
1627         Reviewed by Yury Semikhatsky.
1628
1629         Just small fix for problem with check-webkit-style.
1630         It just didn't work for this patch.
1631         Old code can't concatenate a list of strings with None.
1632
1633         * Scripts/webkitpy/common/checkout/scm.py:
1634
1635 2011-01-13  David Levin  <levin@chromium.org>
1636
1637         Reviewed by Shinichiro Hamaji.
1638
1639         check-webkit-style: _FunctionState should use Position to know where items are.
1640         https://bugs.webkit.org/show_bug.cgi?id=52424
1641
1642         * Scripts/webkitpy/style/checkers/cpp.py:
1643         (_FunctionState.*): Changed _FunctionState to use Position instead of line numbers.
1644         (detect_functions): Changed to pass Position's to _FunctionState.begin and
1645         did some minor clean-up.
1646         (*): Other changes are simply about converting to use the Position's in_FunctionState
1647         instead of line numbers.
1648         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Changed the test code
1649         to verify the positions stored in _FunctionState.
1650
1651 2011-01-13  Eric Seidel  <eric@webkit.org>
1652
1653         Reviewed by David Levin.
1654
1655         webkit-patch suggest-reviewers dies when ChangeLogs are missing
1656         https://bugs.webkit.org/show_bug.cgi?id=49158
1657
1658         This is not the most elegant, but it is a very safe fix to this bug.
1659         One advantage of catching ScriptError like this instead of adding a
1660         new added_or_modified_files or fixing all changed_files callers
1661         to use a more specific change_files variant, is that we catch
1662         all kinds of ScriptErrors which might cause our (non-essential)
1663         suggest-reviewers code to fail out.  This should make passing
1664         --suggest-reviewers to webkit-patch upload much more robust
1665         and may even make it possible for us to make it default.
1666
1667         The root of the problem here is that SCM.changed_files includes
1668         deleted ChangeLog paths (from moves, etc) which then when we ask
1669         SVN/Git for the contents of the file at that revision, the command
1670         errors out and Executive.run_command raises a ScriptError.
1671
1672         In the future we might fix this differently by making all current
1673         callers of chagned_files use a more specific method for requesting
1674         what types of changes they're interested in (adds, modifies, deletes, etc.)
1675
1676         * Scripts/webkitpy/common/checkout/api.py:
1677         * Scripts/webkitpy/common/checkout/api_unittest.py:
1678
1679 2011-01-13  Dan Bernstein  <mitz@apple.com>
1680
1681         Reviewed by Alexey Proskuryakov.
1682
1683         <rdar://problem/8827065> REGRESSION (r71884): Cross-origin XHR fails if willSendRequest changes the URL
1684         https://bugs.webkit.org/show_bug.cgi?id=52419
1685
1686         Allow to further control the behavior of the willSendRequest delegate callback by making it
1687         set a different URL in the new request.
1688
1689         * DumpRenderTree/LayoutTestController.cpp:
1690         (addURLToRedirectCallback): Added.
1691         (LayoutTestController::staticFunctions): Added addURLToRedirect.
1692         (LayoutTestController::addURLToRedirect): Added. Adds the redirection to the map.
1693         (LayoutTestController::redirectionDestinationForURL): Added this getter.
1694         * DumpRenderTree/LayoutTestController.h:
1695         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1696         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): Check
1697         if there is a redirection for the request’s URL, established by addURLToRedirect(), and if so,
1698         change the URL in the new request to the redirect destination.
1699
1700 2011-01-13  Eric Seidel  <eric@webkit.org>
1701
1702         Reviewed by Mihai Parparita.
1703
1704         webkit-patch suggest-reviewers fails due to invalid utf8 in ChangeLog files
1705         https://bugs.webkit.org/show_bug.cgi?id=52416
1706
1707         Example: webkit-patch suggest-reviewers -g ca3890fe74d94d85d6bfa48f9ea497b094d8e717 
1708         UnicodeDecodeError: 'utf8' codec can't decode bytes in position 536-538: invalid data
1709
1710         I also added FIXMEs about the changed_files returning deleted files problem
1711         which is causing the other most common exception for suggest-reviewers
1712         (and is probably breaking sheriff-bots blame detection).
1713
1714         * Scripts/webkitpy/common/checkout/api.py:
1715         * Scripts/webkitpy/common/checkout/api_unittest.py:
1716         * Scripts/webkitpy/common/checkout/scm.py:
1717
1718 2011-01-13  Eric Seidel  <eric@webkit.org>
1719
1720         Reviewed by Adam Barth.
1721
1722         results archives from commit-queue are too large to upload
1723         https://bugs.webkit.org/show_bug.cgi?id=52405
1724
1725         * Scripts/webkitpy/common/system/filesystem.py:
1726         * Scripts/webkitpy/common/system/filesystem_mock.py:
1727         * Scripts/webkitpy/tool/commands/queues.py:
1728
1729 2011-01-13  Alejandro G. Castro  <alex@igalia.com>
1730
1731         Reviewed by Martin Robinson.
1732
1733         [gtk] Zero-sized font does not yet work
1734         https://bugs.webkit.org/show_bug.cgi?id=49793
1735
1736         Set minimum-font-size to 0 for the DRT.
1737
1738         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1739         (resetDefaultsToConsistentValues):
1740
1741 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
1742
1743         Reviewed by Darin Adler.
1744
1745         Make old-run-webkit-tests more robust on buildbots
1746         https://bugs.webkit.org/show_bug.cgi?id=52364
1747
1748         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Pass --exit-after-n-failures 500 to old-run-webkit-tests script.
1749
1750 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
1751
1752         Reviewed by Darin Adler.
1753
1754         Make old-run-webkit-tests more robust on buildbots
1755         https://bugs.webkit.org/show_bug.cgi?id=52364
1756
1757         * Scripts/old-run-webkit-tests: Ensure that testResultsDirectory is empty.
1758
1759 2011-01-13  Tony Chang  <tony@chromium.org>
1760
1761         Reviewed by Kent Tamura.
1762
1763         [chromium] fix plugins/plugin-javascript-access.html on Linux and Mac
1764         https://bugs.webkit.org/show_bug.cgi?id=52332
1765
1766         Forked Info.plist is not longer needed.
1767
1768         * DumpRenderTree/chromium/TestNetscapePlugIn/Info.plist: Removed.
1769
1770 2011-01-13  Mikhail Naganov  <mnaganov@chromium.org>
1771
1772         Reviewed by Timothy Hatcher.
1773
1774         Web Inspector: Cleanup after r75613 -- make all UI-facing strings
1775         to be passed directly to WebInspector.UIString
1776
1777         https://bugs.webkit.org/show_bug.cgi?id=52365
1778
1779         * Scripts/check-inspector-strings:
1780
1781 2011-01-13  Sheriff Bot  <webkit.review.bot@gmail.com>
1782
1783         Unreviewed, rolling out r74881.
1784         http://trac.webkit.org/changeset/74881
1785         https://bugs.webkit.org/show_bug.cgi?id=52357
1786
1787         The EFL builder has been red for days (Requested by abarth on
1788         #webkit).
1789
1790         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1791         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1792
1793 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
1794
1795         Reviewed by David Levin.
1796
1797         Add beforeunload support to WebKitTestRunner
1798         https://bugs.webkit.org/show_bug.cgi?id=52353
1799         
1800         This makes a number of currently failing tests pass.
1801
1802         * WebKitTestRunner/TestController.cpp:
1803         (WTR::runBeforeUnloadConfirmPanel):
1804         (WTR::createOtherPage):
1805         (WTR::TestController::initialize):
1806
1807 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
1808
1809         Reviewed by Sam Weinig.
1810
1811         Detect, identify and recover from WebProcess crashes in run-webkit-tests
1812         https://bugs.webkit.org/show_bug.cgi?id=52330
1813
1814         * Scripts/old-run-webkit-tests: Detect when the regression test tool reports
1815         a web process crash.
1816         * WebKitTestRunner/TestController.cpp:
1817         (WTR::TestController::initialize): Set up a processDidCrash
1818         callback.
1819         (WTR::TestController::processDidCrash): Report that the Web process
1820         crashed.
1821         * WebKitTestRunner/TestController.h:
1822
1823 2011-01-12  David Levin  <levin@chromium.org>
1824
1825         Reviewed by Shinichiro Hamaji.
1826
1827         check-webkit-style -- close_expression function doesn't work correctly.
1828         https://bugs.webkit.org/show_bug.cgi?id=52272
1829
1830         * Scripts/webkitpy/style/checkers/cpp.py:
1831         (Position.__str__): Added a way to convert it to a string which is useful in tests.
1832         (Position.__cmp__): Added a way to compare Position which is useful in tests and
1833         generally useful (for upcoming code changes).
1834         (close_expression): Changed to use Position for input and output.
1835         Also, fixed many bugs such as only working correctly for parenthesis,
1836         not working correctly if given an offset in a line and not finding
1837         the real closing element if there were multiple closing elements in
1838         the same line.
1839         (detect_functions): Adjusted due to the change in arguments for
1840         close_expression.
1841         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1842         (CppStyleTestBase.assert_positions_equal): Added a way to verify that
1843         two positions are the same.
1844         (CppStyleTest.test_position): Added tests for the __str_ and __cmp__ methods.
1845         (CppStyleTest.test_close_expression): Added tests to catch the issues
1846         that were fixed.
1847
1848 2011-01-12  Sheriff Bot  <webkit.review.bot@gmail.com>
1849
1850         Unreviewed, rolling out r75576.
1851         http://trac.webkit.org/changeset/75576
1852         https://bugs.webkit.org/show_bug.cgi?id=52304
1853
1854         broke rebaseline-chromium-webkit-test (Requested by thakis on
1855         #webkit).
1856
1857         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1858         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1859         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1860         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1861         * Scripts/webkitpy/layout_tests/port/base.py:
1862         * Scripts/webkitpy/layout_tests/port/chromium.py:
1863         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1864         * Scripts/webkitpy/layout_tests/port/test.py:
1865         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1866         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1867         * Scripts/webkitpy/style/checkers/test_expectations.py:
1868         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1869
1870 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
1871
1872         Reviewed by Darin Adler.
1873
1874         Add a no-build option to run-webkit-tests, to avoid building DRT/WKTR
1875         https://bugs.webkit.org/show_bug.cgi?id=52307
1876
1877         * Scripts/old-run-webkit-tests:
1878
1879 2011-01-12  Koan-Sin Tan  <koansin.tan@gmail.com>
1880
1881         Reviewed by Martin Robinson.
1882
1883         [Gtk] WebKitGtk+ doesn't build on Mac OS X 10.6
1884         https://bugs.webkit.org/show_bug.cgi?id=50867
1885
1886         Fixed library extention for Mac in webkitdirs.pm and type conflict in
1887         TestNetscapePlugin.cpp 
1888
1889         * GNUmakefile.am: Don't use AppKit when compiling TestNetscapePlugin for GTK+
1890         * Scripts/webkitdirs.pm:
1891
1892 2011-01-12  Mikhail Naganov  <mnaganov@chromium.org>
1893
1894         Reviewed by Pavel Feldman.
1895
1896         Add check-inspector-strings script.
1897
1898         https://bugs.webkit.org/show_bug.cgi?id=52295
1899
1900         * Scripts/check-inspector-strings: Added.
1901
1902 2011-01-12  Adam Roben  <aroben@apple.com>
1903
1904         Advertise the .testnetscape file extension on Windows
1905
1906         Fixes <http://webkit.org/b/52298>
1907         plugins/no-mime-with-valid-extension.html fails on Windows
1908
1909         Reviewed by Dan Bernstein.
1910
1911         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Added a
1912         FileExtents field to map the .testnetscape file extension to the
1913         application/x-webkit-test-netscape MIME type, just as we do on Mac.
1914
1915 2011-01-12  Adam Barth  <abarth@webkit.org>
1916
1917         Reviewed by Eric Seidel.
1918
1919         Make webkit-patch support subdirectories for SVN checkouts
1920         https://bugs.webkit.org/show_bug.cgi?id=52261
1921
1922         os.relpath does not exist on Python 2.5, so we need to call our version
1923         of the API.
1924
1925         * Scripts/webkitpy/common/checkout/scm.py:
1926
1927 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
1928
1929         Reviewed by Eric Seidel.
1930
1931         Close additional pages opened during a test once the test completes.
1932         https://bugs.webkit.org/show_bug.cgi?id=52276
1933
1934         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1935         (WTR::InjectedBundle::done):
1936
1937 2011-01-11  David Levin  <levin@chromium.org>
1938
1939         Reviewed by Eric Seidel.
1940
1941         Errors should be separated from the command line in bot messages.
1942         https://bugs.webkit.org/show_bug.cgi?id=52275
1943
1944         * Scripts/webkitpy/common/system/executive.py:
1945         (ScriptError.message_with_output): Added a newline to separate the command
1946         line from the errors.
1947         * Scripts/webkitpy/common/system/executive_unittest.py:
1948         (ScriptErrorTest.test_message_with_output): Added tests for the various code
1949         paths in message_with_output.
1950
1951 2011-01-11  Eric Seidel  <eric@webkit.org>
1952
1953         Unreviewed.
1954
1955         commit-queue should know how to upload archived results (for test flakes or general failures)
1956         https://bugs.webkit.org/show_bug.cgi?id=52048
1957
1958         The zips are mostly empty due to forgetting -r.
1959         Expected diffs were not being pulled from the archive due
1960         to the archive having longer paths than I realized.
1961
1962         * Scripts/webkitpy/common/system/workspace.py:
1963         * Scripts/webkitpy/common/system/workspace_unittest.py:
1964         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1965         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1966
1967 2011-01-11  Dirk Pranke  <dpranke@chromium.org>
1968
1969         Reviewed by Ojan Vafai.
1970
1971         The current modifier parsing code in test_expectations is
1972         fragile and hard-coded, so it's not easy to understand the logic
1973         or easily add new types of modifiers (like GPU vs. CPU testing
1974         for graphics tests, or 32-bit vs. 64-bit differences).
1975
1976         This is the first of two patches that will add in more generic
1977         support and then eliminate the GPU-specific test expectations
1978         files for Chromium.
1979
1980         This patch adds two standalone objects for handling modifiers. The
1981         rules for interpreting modifiers, precedence, and conflicts are
1982         given in the docstring to the ModifierMatcher class, which
1983         returns ModifierMatchResult objects.
1984         
1985         This patch also adds routines to the Port interface and a
1986         default set of values in the base object, in order to obtain the
1987         values needed on a given test run. These values are then passed
1988         to the expectation parser. This also allows us to clean up the
1989         logic used to lint all of the different configurations in a
1990         single test_expectations.txt file.
1991
1992         The next patch will merge in the separate GPU expectations file.
1993
1994         https://bugs.webkit.org/show_bug.cgi?id=51222
1995
1996         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1997         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1998         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1999         * Scripts/webkitpy/layout_tests/port/base.py:
2000         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2001         * Scripts/webkitpy/layout_tests/port/chromium.py:
2002         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2003         * Scripts/webkitpy/layout_tests/port/test.py:
2004         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2005         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2006
2007 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
2008
2009         Reviewed by Adam Barth.
2010
2011         Make webkit-patch support subdirectories for SVN checkouts
2012         https://bugs.webkit.org/show_bug.cgi?id=52261
2013
2014         * Scripts/webkitpy/common/checkout/scm.py:
2015         * Scripts/webkitpy/style_references.py:
2016         * Scripts/webkitpy/tool/main.py:
2017         * Scripts/webkitpy/tool/steps/preparechangelog.py:
2018
2019 2011-01-11  Eric Seidel  <eric@webkit.org>
2020
2021         Unreviewed.
2022
2023         commit-queue should know how to upload archived results (for test flakes or general failures)
2024         https://bugs.webkit.org/show_bug.cgi?id=52048
2025
2026         I changed the API for archive_last_layout_test_results w/o updating the implementation.  Oops.
2027         This fixes an exception seen on the commit-queue when attempting to report flaky tests.
2028
2029         * Scripts/webkitpy/common/system/workspace.py:
2030         * Scripts/webkitpy/common/system/workspace_unittest.py:
2031         * Scripts/webkitpy/tool/commands/queues.py:
2032
2033 2011-01-11  Sam Weinig  <sam@webkit.org>
2034
2035         Roll r75474 back in.
2036
2037 2011-01-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
2038
2039         Reviewed by Kenneth Rohde Christiansen.
2040
2041         [Qt] Remove uses of QFuture since it isn't supported on all platforms.
2042         https://bugs.webkit.org/show_bug.cgi?id=51204
2043
2044         * QtTestBrowser/webpage.h:
2045         (QtNAMThread::QtNAMThread):
2046         (QtNAMThread::networkAccessManager):
2047         (QtNAMThread::run):
2048
2049 2011-01-11  Peter Varga  <pvarga@webkit.org>
2050
2051         Unreviewed.
2052
2053         Add myself to committers' list.
2054
2055         * Scripts/webkitpy/common/config/committers.py:
2056
2057 2011-01-11  Eric Seidel  <eric@webkit.org>
2058
2059         Reviewed by Adam Barth.
2060
2061         commit-queue should know how to upload archived results (for test flakes or general failures)
2062         https://bugs.webkit.org/show_bug.cgi?id=52048
2063
2064         Now the queue will always upload results.  Either the entire zip, or just
2065         the diffs.txt in the case of text failures.
2066
2067         This should make understanding flakes much easier, and paves the way
2068         for having the EWS run layout tests (and upload failures).
2069
2070         In order to upload .zip files I had to teach bugzilla.py to autodetect
2071         mime types from the filename.  Since mimetypes.py doesn't include a mapping
2072         for .patch files, I have it add one before calling guess_type.
2073
2074         We may find that always uploading the whole zip instead of just the -diffs.txt
2075         file is preferable, but for now I'm keeping the old behavior because it makes
2076         quickly understanding text failures easy.
2077
2078         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2079         * Scripts/webkitpy/common/system/workspace.py: Added.
2080         * Scripts/webkitpy/common/system/workspace_unittest.py: Added.
2081         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2082         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2083         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2084         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2085         * Scripts/webkitpy/tool/commands/queues.py:
2086         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2087
2088 2011-01-10  Sheriff Bot  <webkit.review.bot@gmail.com>
2089
2090         Unreviewed, rolling out r75464.
2091         http://trac.webkit.org/changeset/75464
2092         https://bugs.webkit.org/show_bug.cgi?id=52193
2093
2094         Followup rollout for 75474 (Requested by Ossy on #webkit).
2095
2096         * MiniBrowser/mac/BrowserWindowController.m:
2097         (-[BrowserWindowController awakeFromNib]):
2098         * MiniBrowser/win/BrowserView.cpp:
2099         (BrowserView::create):
2100         * WebKitTestRunner/TestController.cpp:
2101         (WTR::createOtherPage):
2102         (WTR::TestController::initialize):
2103
2104 2011-01-10  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2105
2106         Reviewed by Csaba Osztrogonác.
2107
2108         [Qt] Baseline qt_minimal configuration
2109         https://bugs.webkit.org/show_bug.cgi?id=51313
2110
2111         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2112         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): Add
2113         QT_NO_UNDOSTACK guard.
2114
2115         * QtTestBrowser/launcherwindow.cpp:
2116         (LauncherWindow::createChrome): Add QT_NO_SHORTCUT and QT_NO_PRINTER
2117         guards.
2118         (LauncherWindow::applyZoom): Add QT_NO_ANIMATION guard.
2119         (LauncherWindow::screenshot): Add QT_NO_FILEDIALOG guard.
2120         (LauncherWindow::selectElements): Add QT_NO_INPUTDIALOG guard.
2121         (LauncherWindow::showUserAgentDialog): Add QT_NO_COMBOBOX guard.
2122
2123         * QtTestBrowser/launcherwindow.h:
2124         * QtTestBrowser/locationedit.cpp: Add QT_NO_INPUTDIALOG guard.
2125         * QtTestBrowser/locationedit.h: Ditto.
2126
2127         * QtTestBrowser/mainwindow.cpp:
2128         (MainWindow::buildUI): Add QT_NO_INPUTDIALOG, QT_NO_SHORTCUT and
2129         QT_NO_UNDOSTACK guards.
2130         (MainWindow::setAddressUrl): Add QT_NO_INPUTDIALOG guard.
2131         (MainWindow::changeLocation): Ditto.
2132         (MainWindow::openFile): Add QT_NO_FILEDIALOG guard.
2133         (MainWindow::openLocation): Add QT_NO_INPUTDIALOG guard.
2134
2135         * QtTestBrowser/webpage.cpp:
2136         (WebPage::openUrlInDefaultBrowser): Add QT_NO_DESKTOPSERVICES guard.
2137         (WebPage::authenticationRequired): Add QT_NO_LINEEDIT guard.
2138
2139         * QtTestBrowser/webview.cpp:
2140         (WebViewGraphicsBased::animatedFlip): Add QT_NO_ANIMATION guard.
2141         (WebViewGraphicsBased::animatedYFlip): Ditto.
2142
2143 2011-01-10  Sam Weinig  <sam@webkit.org>
2144
2145         Fix build.
2146
2147         * MiniBrowser/mac/BrowserWindowController.m:
2148         (-[BrowserWindowController awakeFromNib]):
2149         * MiniBrowser/win/BrowserView.cpp:
2150         (BrowserView::create):
2151         * WebKitTestRunner/TestController.cpp:
2152         (WTR::createOtherPage):
2153         (WTR::TestController::initialize):
2154
2155 2011-01-10  Eric Seidel  <eric@webkit.org>
2156
2157         Reviewed by Ojan Vafai.
2158
2159         style-queue messages are way too long for big patches
2160         https://bugs.webkit.org/show_bug.cgi?id=52161
2161
2162         We definitely could build much fancier list-to-string-with-limit functions
2163         but this should be sufficient for our needs at the moment.
2164
2165         * Scripts/webkitpy/common/system/executive.py:
2166         * Scripts/webkitpy/common/system/executive_unittest.py:
2167
2168 2011-01-10  Tony Chang  <tony@chromium.org>
2169
2170         Unreviewed, rolling out r75398.
2171         http://trac.webkit.org/changeset/75398
2172         https://bugs.webkit.org/show_bug.cgi?id=52008
2173
2174         Some layout tests are crashing on Chromium Win.
2175
2176         * DumpRenderTree/chromium/WebViewHost.cpp:
2177         (WebViewHost::updatePaintRect):
2178         * DumpRenderTree/chromium/WebViewHost.h:
2179
2180 2011-01-10  Adam Roben  <aroben@apple.com>
2181
2182         Roll out r75392
2183
2184         It isn't needed now that r75289 has been rolled out.
2185
2186         * Scripts/run-javascriptcore-tests:
2187
2188 2011-01-10  Maciej Stachowiak  <mjs@apple.com>
2189
2190         Reviewed by Anders Carlsson.
2191
2192         WebKitTestRunner uses crazy amounts of CPU, making layout tests slow and flaky
2193         https://bugs.webkit.org/show_bug.cgi?id=52160
2194
2195         * WebKitTestRunner/mac/TestControllerMac.mm:
2196         (WTR::TestController::platformRunUntil): Instead of busy-looping, wait for the timeout.
2197         Anything that can make runUntil() conditions turn true will happen on a run loop cycle
2198         anyway.
2199
2200 2011-01-10  Tony Chang  <tony@chromium.org>
2201
2202         Reviewed by Mihai Parparita.
2203
2204         [chromium] fix for animated gif layout tests
2205         https://bugs.webkit.org/show_bug.cgi?id=52008
2206
2207         * DumpRenderTree/chromium/WebViewHost.cpp: Schedule a paint when we update the paint rect
2208             to trigger gif animations.
2209         (WebViewHostPaintTask::WebViewHostPaintTask):
2210         (WebViewHostPaintTask::runIfValid):
2211         (WebViewHost::updatePaintRect):
2212         * DumpRenderTree/chromium/WebViewHost.h:
2213         (WebViewHost::taskList):
2214
2215 2011-01-10  Alejandro G. Castro  <alex@igalia.com>
2216
2217         Reviewed by Xan Lopez.
2218
2219         [GTK] Fix gtk2 compilation for master
2220         https://bugs.webkit.org/show_bug.cgi?id=51885
2221
2222         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
2223         (createBitmapContextFromWebView): Replaced the old
2224         gdk_drawable_get_size with gdk_pixmap_get_size.
2225
2226 2011-01-10  Patrick Gansterer  <paroga@webkit.org>
2227
2228         Reviewed by Laszlo Gombos.
2229
2230         [WINCE] Reenable NPAPI after r75203
2231         https://bugs.webkit.org/show_bug.cgi?id=52109
2232
2233         Remove the !isWinCE() check for ENABLE_NETSCAPE_PLUGIN_API and replace
2234         it with !isEfl(), because EFL port does not support NPAPI (yet).
2235
2236         * Scripts/build-webkit:
2237
2238 2011-01-10  Adam Roben  <aroben@apple.com>
2239
2240         Skip some asserting JS tests
2241
2242         See <http://webkit.org/b/52156>.
2243
2244         * Scripts/run-javascriptcore-tests:
2245
2246 2011-01-10  Martin Robinson  <mrobinson@igalia.com>
2247
2248         Reviewed by Xan Lopez.
2249
2250         [GTK] build-webkit disable Blob support via arguments passed to automake
2251         https://bugs.webkit.org/show_bug.cgi?id=52097
2252
2253         * Scripts/build-webkit: Enable Blob support when building WebKitGTK+ via
2254         build-webkit.
2255
2256 2011-01-10  Adam Roben  <aroben@apple.com>
2257
2258         Use the same name and description for TestNetscapePlugin on Windows and
2259         Mac
2260
2261         Fixes <http://webkit.org/b/52151>
2262         fast/frames/iframe-reparenting-plugins.html fails on Windows
2263
2264         Reviewed by Steve Falkenburg.
2265
2266         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Copied
2267         the name and description from Mac's Info.plist.
2268
2269 2011-01-10  Siddharth Mathur <siddharth.mathur@nokia.com>
2270
2271         Reviewed by Laszlo Gombos.
2272
2273         [Qt][WK2] Guard gcc-specific syntax
2274
2275         Non-gcc based compliers choke on the "-include"
2276         syntax for preinclude, place guard around it.
2277
2278         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2279         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2280
2281 2011-01-10  Andreas Kling  <kling@webkit.org>
2282
2283         Reviewed by Simon Hausmann.
2284
2285         [Qt] [WK2] MiniBrowser does not load pages opened in new windows
2286         https://bugs.webkit.org/show_bug.cgi?id=52111
2287
2288         When getting a createNewPage() callback from QWKPage, create the
2289         new page with the same QWKContext as the page that is passed to
2290         the callback.
2291
2292         * MiniBrowser/qt/BrowserView.h:
2293         * MiniBrowser/qt/BrowserWindow.cpp:
2294         (newPageFunction):
2295         (BrowserWindow::BrowserWindow):
2296         * MiniBrowser/qt/BrowserWindow.h:
2297
2298 2011-01-10  Andreas Kling  <kling@webkit.org>
2299
2300         Reviewed by Kenneth Rohde Christiansen.
2301
2302         [Qt] MiniBrowser: Remove superfluous createNewPage() callback
2303
2304         BrowserView set its own useless createNewPage() callback on QWKPage.
2305         This was immediately overridden by BrowserWindow anyway, so remove
2306         the BrowserView one.
2307
2308         * MiniBrowser/qt/BrowserView.cpp:
2309         (BrowserView::BrowserView):
2310
2311 2011-01-10  John Knottenbelt  <jknotten@chromium.org>
2312
2313         Reviewed by Jeremy Orlow.
2314
2315         [Chromium] Remove non-client-based Geolocation code
2316         https://bugs.webkit.org/show_bug.cgi?id=50921
2317
2318         * DumpRenderTree/chromium/LayoutTestController.cpp:
2319         (LayoutTestController::setGeolocationPermission):
2320         (LayoutTestController::setMockGeolocationPosition):
2321         (LayoutTestController::setMockGeolocationError):
2322         * DumpRenderTree/chromium/WebViewHost.cpp:
2323         (WebViewHost::geolocationClientMock):
2324         (WebViewHost::reset):
2325         * DumpRenderTree/chromium/WebViewHost.h:
2326
2327 2011-01-10  Eric Seidel  <eric@webkit.org>
2328
2329         Reviewed by Adam Barth.
2330
2331         Commit bot tried to land r? cq+ patch
2332         https://bugs.webkit.org/show_bug.cgi?id=36638
2333
2334         It should now be possible to post a patch with r? and cq+ and the
2335         commit-queue will correctly wait for the r+ before attempting to land the patch.
2336         (This was a feature requested by several users.)
2337
2338         One caveat: We don't actually reject r-, cq+ patches from the queue
2339         (we just ignore them), but I think that's OK for now.
2340
2341         I also noticed that setting r- once a commit-queue node had grabbed
2342         a patch would not properly cancel the landing.  That's fixed and
2343         tested in this patch.
2344
2345         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2346         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2347         * Scripts/webkitpy/tool/bot/feeders.py:
2348         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
2349
2350 2011-01-08  Benjamin Poulain  <benjamin.poulain@nokia.com>
2351
2352         Reviewed by Kenneth Rohde Christiansen.
2353
2354         [Qt] QtWebKit crashes when using XMLHttpRequest from the unload event
2355         https://bugs.webkit.org/show_bug.cgi?id=51934
2356
2357         When accessing the network from the destructor of QWebPage, the network access manager
2358         was already deleted because the object WebPage was already destructed.
2359
2360         This solve the problem by linking the lifetime of the network access manager to WebPage's QObject.
2361         The object is now destructed in the destructor of QObject.
2362
2363         * QtTestBrowser/webpage.cpp:
2364         (WebPage::WebPage):
2365         (WebPage::setQnamThreaded):
2366         * QtTestBrowser/webpage.h:
2367         (QtNAMThread::QtNAMThread):
2368
2369 2011-01-08  Eric Seidel  <eric@webkit.org>
2370
2371         Reviewed by Ojan Vafai.
2372
2373         test_failures.py should not mention TestShell (long live DumpRenderTree!)
2374         https://bugs.webkit.org/show_bug.cgi?id=52067
2375
2376         I ran test-webkitpy, but didn't bother adding a unit test for this string change.
2377         https://bugs.webkit.org/show_bug.cgi?id=51138#c3 is an example of why this is needed.
2378
2379         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2380
2381 2011-01-08  Eric Seidel  <eric@webkit.org>
2382
2383         Reviewed by Mihai Parparita.
2384
2385         commit-queue hangs when the ChangeLog diff is bad
2386         https://bugs.webkit.org/show_bug.cgi?id=52072
2387
2388         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
2389         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
2390
2391 2011-01-08  Adam Barth  <abarth@webkit.org>
2392
2393         Teach svn-apply how to re-write WebCore to Source/WebCore.
2394
2395         * Scripts/VCSUtils.pm:
2396
2397 2011-01-07  Adam Barth  <abarth@webkit.org>
2398
2399         Rubber-stamped by Eric Seidel.
2400
2401         Move WebCore to Source
2402         https://bugs.webkit.org/show_bug.cgi?id=52050
2403
2404         Update the tools to understand WebCore's new location.
2405
2406         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2407         * DumpRenderTree/wscript:
2408         * GNUmakefile.am:
2409         * Scripts/build-webkit:
2410         * Scripts/do-file-rename:
2411         * Scripts/do-webcore-rename:
2412         * Scripts/generate-qt-inspector-resource:
2413         * Scripts/prepare-ChangeLog:
2414         * Scripts/run-bindings-tests:
2415         * Scripts/update-iexploder-cssproperties:
2416         * Scripts/update-sources-list.py:
2417         * Scripts/update-webkit-localizable-strings:
2418         * Scripts/webkitdirs.pm:
2419         * Scripts/webkitpy/common/config/build.py:
2420         * Scripts/webkitpy/common/config/build_unittest.py:
2421         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
2422         * Scripts/webkitpy/style/checker.py:
2423         * Scripts/webkitpy/style/checker_unittest.py:
2424         * WebKitTestRunner/DerivedSources.pro:
2425         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2426         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh:
2427         * wx/browser/wscript:
2428         * wx/build/settings.py:
2429
2430 2011-01-07  Maciej Stachowiak  <mjs@apple.com>
2431
2432         Reviewed by Sam Weinig.
2433
2434         Make WebKitTestRunner rest between loads more robust to avoid test crashes
2435         https://bugs.webkit.org/show_bug.cgi?id=52086
2436
2437         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2438         (WTR::InjectedBundle::didReceiveMessage):
2439         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2440         (WTR::LayoutTestController::notifyDone):
2441         * WebKitTestRunner/TestController.cpp:
2442         (WTR::TestController::resetStateToConsistentValues):
2443         (WTR::TestController::run):
2444
2445 2011-01-07  James Robinson  <jamesr@chromium.org>
2446
2447         Revert "Implement mozilla's animationTime property"
2448         https://bugs.webkit.org/show_bug.cgi?id=51952
2449
2450         This approach isn't quite right.
2451
2452         * DumpRenderTree/chromium/WebViewHost.cpp:
2453         (WebViewHost::paintInvalidatedRegion):
2454
2455 2011-01-07  Adam Roben  <aroben@apple.com>
2456
2457         Build master fix
2458
2459         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2460         (RunWebKitTests.start): Don't try to concatenate a list and a string.
2461
2462 2011-01-07  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
2463
2464         Reviewed by Csaba Osztrogonác.
2465
2466         run-qtwebkit-tests should be able to kill a testsuite.
2467
2468         Add new option in the script that can setup a timeout for a test.
2469         If the test execution takes more then specified time then the test
2470         would be terminated.
2471
2472         [Qt] run-qtwebkit-tests needs timeout
2473         https://bugs.webkit.org/show_bug.cgi?id=51894
2474
2475         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2476         * Scripts/run-qtwebkit-tests:
2477
2478 2011-01-07  Csaba Osztrogonác  <ossy@webkit.org>
2479
2480         Unreviewed fix after r75233.
2481
2482         Based on idea from Eric Seidel.
2483
2484         Add remote zip file handling to webkitpy.
2485         https://bugs.webkit.org/show_bug.cgi?id=50901
2486
2487         * Scripts/webkitpy/common/system/fileset.py: Make python 2.5 happy.
2488
2489 2011-01-07  Shane Stephens  <shanestephens@google.com>
2490
2491         Reviewed by Eric Seidel.
2492
2493         svn-apply: should support git binary delta diffs
2494         https://bugs.webkit.org/show_bug.cgi?id=38864
2495
2496         * Scripts/VCSUtils.pm:
2497         * Scripts/svn-apply:
2498
2499 2011-01-06  Julie Parent  <jparent@chromium.org>
2500
2501         Reviewed by Eric Seidel.
2502
2503         Test Result Server not removing old results.
2504         https://bugs.webkit.org/show_bug.cgi?id=52012
2505
2506         * TestResultServer/model/jsonresults.py:
2507         Fix off-by-one: Truncate if >= num_runs, not just >.
2508         * TestResultServer/model/jsonresults_unittest.py:
2509         Add unit test to test that merging in a new result with the same value
2510         as the last result causes previous result to fall off.
2511
2512 2011-01-06  James Kozianski  <koz@chromium.org>
2513
2514         Reviewed by Mihai Parparita.
2515
2516         Add classes to provide a consistent interface to a set of files.
2517         https://bugs.webkit.org/show_bug.cgi?id=50901
2518
2519         These classes allow us to write code that is agnostic to whether a
2520         particular set of files resides in a local directory or in a zip file
2521         on a remote machine.
2522
2523         * Scripts/webkitpy/common/system/directoryfileset.py: Added.
2524         * Scripts/webkitpy/common/system/directoryfileset_unittest.py: Added.
2525         * Scripts/webkitpy/common/system/fileset.py: Added.
2526         * Scripts/webkitpy/common/system/filesystem.py:
2527         * Scripts/webkitpy/common/system/filesystem_mock.py:
2528         * Scripts/webkitpy/common/system/zipfileset.py: Added.
2529         * Scripts/webkitpy/common/system/zipfileset_unittest.py: Added.
2530
2531 2011-01-06  Eric Seidel  <eric@webkit.org>
2532
2533         Reviewed by Adam Barth.
2534
2535         NetworkTransaction should log the url it is retrying
2536         https://bugs.webkit.org/show_bug.cgi?id=52043
2537
2538         * Scripts/webkitpy/common/net/networktransaction.py:
2539         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
2540
2541 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
2542
2543         Windows build fix.
2544         Import os before using it.
2545
2546         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2547
2548 2011-01-06  Eric Seidel  <eric@webkit.org>
2549
2550         Reviewed by Adam Barth.
2551
2552         StyleQueue fails to report errors when patches have many files
2553         https://bugs.webkit.org/show_bug.cgi?id=52042
2554
2555         This is one of at least two errors preventing style error reporting at the moment.
2556         When we moved to passing the list of files to check explicitly,
2557         we started to exceed the 500 character TEXT field limit for our AppEngine model object.
2558         We could change the type of the QueueStatus.message type, or we could
2559         just teach statusserver.py how to clamp values (and warn when it does).
2560         I chose the latter path.
2561
2562         * Scripts/webkitpy/common/net/statusserver.py:
2563
2564 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
2565
2566         Reviewed by Stephanie Lewis.
2567         
2568         Fix syntax error in script.
2569
2570         Windows bots need to archive/unarchive builds to/from configuration-specific directories
2571         https://bugs.webkit.org/show_bug.cgi?id=51996
2572
2573         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2574
2575 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2576
2577         Unreviewed, fixing WinCE build after r75196.
2578
2579         WinCE port does not (yet) support NPAPI.
2580
2581         * Scripts/build-webkit:
2582
2583 2011-01-06  Xan Lopez  <xlopez@igalia.com>
2584
2585         Reviewed by Darin Adler.
2586
2587         File::Spec->rel2abs in sunspider-compare-results mangles parameters
2588         https://bugs.webkit.org/show_bug.cgi?id=52015
2589
2590         * Scripts/sunspider-compare-results: call rel2abs on our arguments
2591         after the platform has been detected, otherwise the script will
2592         mangle things like '--gtk' into '/a/path/--gtk', breaking the
2593         detection.
2594
2595 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2596
2597         Reviewed by Eric Seidel.
2598
2599         Add ENABLE_NETSCAPE_PLUGIN_API, ENABLE_ORIENTATION_EVENTS and ENABLE_TOUCH_EVENTS flags to build-webkit
2600         https://bugs.webkit.org/show_bug.cgi?id=51346
2601
2602         * Scripts/build-webkit:
2603
2604 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
2605
2606         Reviewed by Adam Roben.
2607
2608         Windows bots need to archive/unarchive builds to/from configuration-specific directories
2609         https://bugs.webkit.org/show_bug.cgi?id=51996
2610         
2611         After the configuration directory change, we were archiving the incorrect directory for
2612         build product, so we were running tests on the wrong binaries.
2613         
2614         This change archives the correct directory, and also unarchives it into a configuration-
2615         specific directory.
2616
2617         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Use a configuration-specific directory on Windows.
2618         * BuildSlaveSupport/built-product-archive: Unarchive/archive to/from proper directory.
2619
2620 2011-01-06  Eric Seidel  <eric@webkit.org>
2621
2622         Reviewed by Mihai Parparita.
2623
2624         commit-queue mentions "Text diff mismatch" 4 times instead of once per failure
2625         https://bugs.webkit.org/show_bug.cgi?id=52002
2626
2627         See an example of this here:
2628         https://bugs.webkit.org/show_bug.cgi?id=51314#c2
2629
2630         It's due to the fact that we pass around TestFailure() instance
2631         objects and yet expect them to all compare to be the same.
2632
2633         This is bad.  We should either have shared instances of these values
2634         or we should just pass around the class names.  There are already hacks
2635         in place to make TestFailure objects pass equality tests, I just added
2636         a __hash__ implementation so they can be used in sets as expected.
2637
2638         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2639         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2640
2641 2011-01-06  Evan Martin  <evan@chromium.org>
2642
2643         Reviewed by Tony Chang.
2644
2645         [gdb] handle inaccessible memory and UChar*
2646         https://bugs.webkit.org/show_bug.cgi?id=52003
2647
2648         To pretty-print a UChar*, we just grope around in the memory
2649         looking for a terminating NUL.  We need to handle the exception
2650         that can occur when we poke into an invalid location.
2651
2652         Additionally, the logic for choosing which pretty-printer would
2653         early return before hitting the point where we'd use the UChar*
2654         printer.  (Did this ever work?  How did it regress?)
2655
2656         * gdb/webkit.py:
2657
2658 2011-01-05  Brian Weinstein  <bweinstein@apple.com>
2659
2660         Reviewed by Ada Chan.
2661
2662         WebKit2: Should be able to call into injected bundle to ask if we should allow resource loads
2663         https://bugs.webkit.org/show_bug.cgi?id=51969
2664         
2665         Add shouldLoadResourceForFrame to WTR::InjectedBundlePage.
2666
2667         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2668         (WTR::InjectedBundlePage::InjectedBundlePage):
2669         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Stub implementation.
2670         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2671
2672 2011-01-06  James Robinson  <jamesr@chromium.org>
2673
2674         Reviewed by Simon Fraser.
2675
2676         Implement mozilla's animationTime property
2677         https://bugs.webkit.org/show_bug.cgi?id=51952
2678
2679         Chromium DRT support for webkitAnimationTime.
2680
2681         * DumpRenderTree/chromium/WebViewHost.cpp:
2682         (WebViewHost::paintInvalidatedRegion):
2683
2684 2011-01-06  Julie Parent  <jparent@chromium.org>
2685
2686         Reviewed by Tony Chang.
2687
2688         Test Result Server always truncates number of results to JSON_RESULTS_MAX_BUILDS
2689         https://bugs.webkit.org/show_bug.cgi?id=51217
2690
2691         * TestResultServer/model/jsonresults.py:
2692         Pass num_runs through to _remove_items_over_max_number_of_builds, and use the value.
2693         Adds missing documentation.
2694         * TestResultServer/model/jsonresults_unittest.py:
2695         Add unit test to test that truncation happens at smaller value than JSON_RESULTS_MAX_BUILDS.
2696         Update test_merge to take a number of builds to truncate at.
2697
2698 2011-01-06  Adam Barth  <abarth@webkit.org>
2699
2700         Reviewed by Eric Seidel.
2701
2702         The EWS should log outside of the working directory
2703         https://bugs.webkit.org/show_bug.cgi?id=51986
2704
2705         This patch prepare us for using git clean -x -d -f in the EWS wrapper
2706         script, which will actually clean the working copy back to a pristine
2707         state instead of leaving untracked directories and ignored files.
2708
2709         * Scripts/webkitpy/tool/commands/queues.py:
2710         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2711
2712 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
2713
2714         Windows build fix.
2715         Back out attempted change to built-product-archive.
2716
2717         * BuildSlaveSupport/built-product-archive:
2718
2719 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
2720
2721         Windows build fix.
2722         Include configuration name when unpacking a build archive.
2723
2724         Needed, since we split Windows build results into configuration-specific directories
2725         under WebKitOutputDir.
2726
2727         * BuildSlaveSupport/built-product-archive:
2728
2729 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
2730
2731         Reviewed by Darin Adler.
2732
2733         Debug and Release builds on Windows clobber each other
2734         https://bugs.webkit.org/show_bug.cgi?id=49185
2735
2736         Changes the structure of WebKitBuild build products directory so we
2737         completely separate each build configuration into independent directories.
2738         
2739         Although we previously had per-configuration directories for obj, this change adds
2740         per-configuration directories for bin, lib, obj, and include. Each configuration's
2741         build products are stored within a directory inside of WebKitBuild.
2742         
2743         Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
2744         defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).
2745
2746         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
2747         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd:
2748         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd:
2749         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
2750         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd:
2751         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd:
2752         * DumpRenderTree/win/ImageDiffCommon.vsprops:
2753         * DumpRenderTree/win/ImageDiffPostBuild.cmd:
2754         * DumpRenderTree/win/ImageDiffPreBuild.cmd:
2755         * FindSafari/FindSafari.vcproj:
2756         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
2757         * MiniBrowser/MiniBrowserPostBuild.cmd:
2758         * MiniBrowser/MiniBrowserPreBuild.cmd:
2759         * Scripts/webkitdirs.pm:
2760         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
2761         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops:
2762         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd:
2763         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd:
2764         * TestWebKitAPI/win/copy-resources.cmd:
2765         * WebKitAPITest/WebKitAPITestCommon.vsprops:
2766         * WebKitAPITest/WebKitAPITestPostBuild.cmd:
2767         * WebKitAPITest/WebKitAPITestPreBuild.cmd:
2768         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
2769         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
2770         * WebKitTestRunner/win/InjectedBundle.vcproj:
2771         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops:
2772         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd:
2773         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd:
2774         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd:
2775         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd:
2776         * WinLauncher/WinLauncherCommon.vsprops:
2777         * WinLauncher/WinLauncherPostBuild.cmd:
2778         * WinLauncher/WinLauncherPreBuild.cmd:
2779
2780 2011-01-05  Jan Erik Hanssen  <jhanssen@sencha.com>
2781
2782         Reviewed by Ariya Hidayat.
2783
2784         [Qt] TestNetscapePlugin doesn't link on OS X
2785         https://bugs.webkit.org/show_bug.cgi?id=51948
2786
2787         Only add a dependency on libX11 on X11 systems
2788
2789         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2790
2791 2011-01-05  Jeff Miller  <jeffm@apple.com>
2792
2793         Reviewed by Adam Roben.
2794
2795         check-webkit-style should allow unnecessary parameter names in WebKit2 APIs because we're matching CF's header style
2796         https://bugs.webkit.org/show_bug.cgi?id=51970
2797
2798         * Scripts/webkitpy/style/checker.py:
2799         Add -readability/naming for WebKit2 C API directories.
2800
2801 2011-01-05  Eric Seidel  <eric@webkit.org>
2802
2803         Unreviewed, just fixing one more log error from my previous python patch.
2804
2805         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
2806         https://bugs.webkit.org/show_bug.cgi?id=51802
2807
2808         webkit-patch failure-reason was logging about parsing errors
2809         due to my misunderstanding of how BeautifulSoup.findAll worked.
2810
2811         Fixed, and added a unit test.
2812
2813         * Scripts/webkitpy/common/net/layouttestresults.py:
2814         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2815
2816 2011-01-05  Benjamin Poulain  <benjamin.poulain@nokia.com>
2817
2818         Reviewed by Kenneth Rohde Christiansen.
2819
2820         [Qt] [WK2] Add the possibility to open window from the WebProcess in Minibrowser
2821         https://bugs.webkit.org/show_bug.cgi?id=51951
2822
2823         Set a function to QWKPage::setCreateNewPageFunction() in Minibrowser so there is a way
2824         to create new window from WebKit.
2825
2826         * MiniBrowser/qt/BrowserWindow.cpp:
2827         (newPageFunction):
2828         (BrowserWindow::BrowserWindow):
2829         (BrowserWindow::page): Added to avoid the indirect access to QWKPage spread in the class
2830         (BrowserWindow::newWindow):
2831         (BrowserWindow::updateUserAgentList):
2832         (BrowserWindow::showUserAgentDialog):
2833         * MiniBrowser/qt/BrowserWindow.h: Add the global variable backingStoreTypeForNewWindow to
2834         define the type of the backing store used for new windows.
2835         * MiniBrowser/qt/main.cpp:
2836         (main):
2837
2838 2011-01-05  Eric Seidel  <eric@webkit.org>
2839
2840         Reviewed by Ojan Vafai.
2841
2842         commit-queue should report failure type when reporting flaky tests
2843         https://bugs.webkit.org/show_bug.cgi?id=51900
2844
2845         This patch was a ridiculous amount of plumbing.  In the end I like
2846         the NRWT-style TestResult class even less.  But now we're passing
2847         a list of TestResult objects from the queue to the FlakyTestReporter.
2848         Thus the FlakyTestReporter can more easily report what type of failure
2849         occurred.
2850
2851         In the process, I found that I was not alone in finding TestResult
2852         cumbersome to use.  A bunch of code was trying to create a TestResult
2853         object with default values.  However since the constructor didn't make
2854         this easy, some places were getting it wrong (including the TestResult unit test)!
2855         I've fixed the TestResult constructor to have default values for non-essential
2856         arguments.
2857
2858         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2859         * Scripts/webkitpy/common/net/layouttestresults.py:
2860         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2861         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2862         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2863         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2864         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
2865         * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
2866         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2867         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2868         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2869         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2870         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2871         * Scripts/webkitpy/tool/commands/queues.py:
2872         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2873
2874 2011-01-05  Eric Seidel  <eric@webkit.org>
2875
2876         Unreviewed.
2877
2878         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
2879         https://bugs.webkit.org/show_bug.cgi?id=51802
2880
2881         Add another unit test to cover a previously missing import.
2882
2883         * Scripts/webkitpy/common/net/layouttestresults.py:
2884         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2885
2886 2011-01-05  Mihai Parparita  <mihaip@chromium.org>
2887
2888         Reviewed by David Levin.
2889
2890         Add mihaip@chromium.org as a reviewer
2891         https://bugs.webkit.org/show_bug.cgi?id=51966
2892         
2893         Add myself as a reviewer.
2894
2895         * Scripts/webkitpy/common/config/committers.py:
2896
2897 2011-01-05  James Simonsen  <simonjam@chromium.org>
2898
2899         Unreviewed. Adding myself to the list of committers.
2900
2901         * Scripts/webkitpy/common/config/committers.py:
2902
2903 2011-01-05  Eric Seidel  <eric@webkit.org>
2904
2905         Unreviewed.
2906
2907         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
2908         https://bugs.webkit.org/show_bug.cgi?id=51802
2909
2910         Fix two exceptions seen on the bots after my original commit.
2911
2912         * Scripts/webkitpy/common/net/layouttestresults.py:
2913         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2914
2915 2011-01-05  Kundu Suchismita  <suchi.kundu@nokia.com>
2916
2917         Reviewed by Andreas Kling.
2918
2919         [Qt]Add local storage settings to QtTestBrowser command line arguments 
2920         https://bugs.webkit.org/show_bug.cgi?id=51750
2921
2922         * QtTestBrowser/main.cpp:
2923         (LauncherApplication::handleUserOptions):
2924          Local storage settings can be enable form command line arguments for
2925          QtTestBrowser.
2926
2927 2011-01-05  Chris Fleizach  <cfleizach@apple.com>
2928
2929         Reviewed by Martin Robinson.
2930
2931         GTK: AX: DRT needs to use correct root object method.
2932         https://bugs.webkit.org/show_bug.cgi?id=51911
2933
2934         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
2935         (AccessibilityController::rootElement):
2936
2937 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
2938
2939         Rubber-stamped by Csaba Osztrogonác.
2940
2941         Based on idea from Péter Gál.
2942
2943         * Scripts/webkitpy/tool/bot/sheriff.py: Remove unnecessary apostrophes around revision numbers.
2944
2945 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
2946
2947         Reviewed by Adam Barth.
2948
2949         sheriff-bot should be able to do multi-revision rollouts
2950         https://bugs.webkit.org/show_bug.cgi?id=51176
2951
2952         * Scripts/webkitpy/tool/bot/irc_command.py:
2953         * Scripts/webkitpy/tool/bot/sheriff.py:
2954         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
2955
2956 2011-01-05  Eric Seidel  <eric@webkit.org>
2957
2958         Reviewed by Adam Barth.
2959
2960         queues.webkit.org should have per-bot status pages
2961         https://bugs.webkit.org/show_bug.cgi?id=51906
2962
2963         Just adds a /queue-status/QUEUE_NAME/bots/BOT_ID page to show
2964         statuses from a single queue.  Now that we have many bots servicing
2965         some queues (commit-queue, win-ews, etc.) its easy to have the messages
2966         you care about scroll off the end of the 15-message limit on the main page.
2967
2968         Eventually we should probably rename /queue-status to /queue or /queues,
2969         but that's fodder for another patch.
2970
2971         * QueueStatusServer/handlers/queuestatus.py:
2972         * QueueStatusServer/index.yaml:
2973         * QueueStatusServer/main.py:
2974         * QueueStatusServer/templates/includes/singlequeuestatus.html:
2975          - This probably should use a custom filter instead of hard-coding
2976            the URL scheme here, but I couldn't figure out how to easily
2977            create such a filter.  Most filters work with "strings" so we can't
2978            pass the status object.  We could add a method to the status
2979            object and call that, but that seemed a bit strange too.
2980         * QueueStatusServer/templates/queuestatus.html:
2981
2982 2011-01-05  Carlos Garcia Campos  <cgarcia@igalia.com>
2983
2984         Unreviewed. Adding myself to the list of committers.
2985
2986         * Scripts/webkitpy/common/config/committers.py:
2987
2988 2011-01-04  Koan-Sin Tan  <koansin.tan@gmail.com>
2989
2990         Reviewed by David Levin.
2991
2992         check-webkit-style treated some macros with parentheses after #elif as function calls
2993         https://bugs.webkit.org/show_bug.cgi?id=51695
2994
2995         Ingore function call space checking in any preprocessor directives
2996         (things starting with #). Change search() to match() because 
2997         preprocessor directives are supposed to be in the beginning of lines.
2998
2999         * Scripts/webkitpy/style/checkers/cpp.py:
3000         * Scripts/webkitpy/style/checkers/cpp_unittest.py: make sure there is no false positives for #elif cases
3001
3002 2011-01-04  Søren Gjesse  <sgjesse@chromium.org>
3003
3004         Reviewed by Tony Chang.
3005
3006         Change the --multi-load test option to --stress-opt
3007         https://bugs.webkit.org/show_bug.cgi?id=50751
3008
3009         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3010         (runTest):
3011         (main):
3012         * DumpRenderTree/chromium/TestShell.cpp:
3013         (TestShell::TestShell):
3014         * DumpRenderTree/chromium/TestShell.h:
3015         (TestShell::stressOpt):
3016         (TestShell::setStressOpt):
3017         (TestShell::stressDeopt):
3018         (TestShell::setStressDeopt):
3019         (TestShell::javaScriptFlags):
3020         (TestShell::setJavaScriptFlags):
3021         * Scripts/webkitpy/layout_tests/port/chromium.py:
3022         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3023
3024 2011-01-04  Chris Fleizach  <cfleizach@apple.com>
3025
3026         Reviewed by Sam Weinig.
3027
3028         WK2: Support Accessibility
3029         https://bugs.webkit.org/show_bug.cgi?id=51859
3030
3031         Use rootObject() method to get top of accessibility tree.
3032
3033         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
3034         (AccessibilityController::focusedElement):
3035         (AccessibilityController::rootElement):
3036
3037 2011-01-03  Martin Robinson  <mrobinson@igalia.com>
3038
3039         Reviewed by Darin Adler.
3040
3041         Remove the last non-GObject usage of PlatformRefPtr and move the code to GRefPtr
3042         https://bugs.webkit.org/show_bug.cgi?id=51846
3043
3044         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Change usage of PlatformRefPtr
3045         back to GRefPtr.
3046
3047 2011-01-04  Zhe Su  <suzhe@chromium.org>
3048
3049         Reviewed by Kenneth Russell.
3050
3051         Fix insertText, setMarkedText and unmarkText methods of
3052         TextInputController to call corresponding methods of WebKit::WebView
3053         rather than WebKit::WebFrame. This change matches the behavior of
3054         chromium browser.
3055         insertText corresponds to WebView::confirmComposition(text)
3056         setMarkedText corresponds to WebView::setComposition(...)
3057         unmarkText corresponds to WebView::confirmComposition()
3058         https://bugs.webkit.org/show_bug.cgi?id=51693
3059
3060         * DumpRenderTree/chromium/TextInputController.cpp:
3061         (TextInputController::insertText):
3062         (TextInputController::setMarkedText):
3063         (TextInputController::unmarkText):
3064
3065 2011-01-04  Dihan Wickremasuriya  <dihan.wickremasuriya@nokia.com>
3066
3067         Reviewed by Laszlo Gombos.
3068
3069         [Qt] [Symbian] Do not remove 0 byte sized files from productDir
3070
3071         On Symbian productDir points to the source directory. Removing all the
3072         empty files from the productDir directory corrupts the svn repository.
3073
3074         * Scripts/build-webkit:
3075
3076 2011-01-03  Yi Shen  <yi.4.shen@nokia.com>
3077
3078         Reviewed by Adam Barth.
3079
3080         [Qt] Add SelectAll option to the context menu for the editor
3081         https://bugs.webkit.org/show_bug.cgi?id=50049
3082
3083         Set shortcut for the SelectAll action.
3084
3085         * QtTestBrowser/mainwindow.cpp:
3086         (MainWindow::buildUI):
3087
3088 2011-01-03  David Levin  <levin@chromium.org>
3089
3090         Reviewed by Eric Seidel.
3091
3092         check-webkit-style shouldn't consider "value" automatically to be a meaningless name.
3093         https://bugs.webkit.org/show_bug.cgi?id=51842
3094
3095         * Scripts/webkitpy/style/checkers/cpp.py: Remove the check for value.
3096         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Remove the test for value.
3097
3098 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
3099
3100         Reviewed by David Kilzer.
3101
3102         [WINCE] Adds a build slave.
3103         https://bugs.webkit.org/show_bug.cgi?id=50523
3104
3105         * BuildSlaveSupport/build.webkit.org-config/config.json: Add an
3106         entry for a release build of the WinCE port.
3107         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add platform
3108         flag to build the WinCE port.
3109
3110 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
3111
3112         Reviewed by David Kilzer.
3113
3114         Add WinCE support to build-webkit
3115         https://bugs.webkit.org/show_bug.cgi?id=51642
3116
3117         * Scripts/build-webkit:
3118         * Scripts/webkitdirs.pm:
3119
3120 2011-01-03  Eric Seidel  <eric@webkit.org>
3121
3122         Reviewed by Adam Barth.
3123
3124         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
3125         https://bugs.webkit.org/show_bug.cgi?id=51802
3126
3127         I'm not the biggest fan of the test_failures or test_results classes,
3128         but it's better to have one shared set of classes, than separate ones
3129         for new vs. old run-webkit-test result handling.
3130
3131         This moves the ORWT results class "LayoutTestResults" over to using
3132         TestResult and TestFailure classes, making it easy for us to
3133         make all our sheriff-bot and other webkitpy code NRWT ready.
3134
3135         This also makes it a trivial patch to generate results.json information
3136         from ORWT results.html files (for flaky test analysis, etc.) as well
3137         as making it a one-liner to report test failure types when the
3138         commit-queue sees flaky tests.
3139
3140         This patch tried not to add new functionality, but only to replace
3141         the guts of LayoutTestResults, while adding unit tests and hoping
3142         not to break anything.
3143
3144         I also moved callers which assumed User.prompt* were static/class methods
3145         to using them as instance methods (since we'll eventually want to make them such).
3146
3147         In the process of re-writing things, I broke the rebaseline command, so I wrote
3148         a unit test to catch my breakage were I do do so again in the future.
3149
3150         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3151         * Scripts/webkitpy/common/net/layouttestresults.py:
3152         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3153         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
3154         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
3155         * Scripts/webkitpy/tool/commands/queries.py:
3156         * Scripts/webkitpy/tool/commands/rebaseline.py:
3157         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3158         * Scripts/webkitpy/tool/mocktool.py:
3159
3160 2011-01-03  Adam Barth  <abarth@webkit.org>
3161
3162         Reviewed by Simon Fraser.
3163
3164         webkit-patch shouldn't waste time cleaning a working directory that's already clean
3165         https://bugs.webkit.org/show_bug.cgi?id=51840
3166
3167         * Scripts/webkitpy/common/checkout/scm.py:
3168
3169 2011-01-03  Adam Barth  <abarth@webkit.org>
3170
3171         Reviewed by Simon Fraser.
3172
3173         webkit-patch should only hide update output if --quiet
3174         https://bugs.webkit.org/show_bug.cgi?id=51838
3175
3176         As requested by smfr.
3177
3178         * Scripts/webkitpy/tool/steps/update.py:
3179
3180 2011-01-03  Adam Barth  <abarth@webkit.org>
3181
3182         Reviewed by David Levin.
3183
3184         commit-queue shouldn't reject patches twice if two bots process the same patch
3185         https://bugs.webkit.org/show_bug.cgi?id=51805
3186
3187         Before raising an error, we first check whether the patch is still in
3188         the commit-queue.  This check is still racy, of course, but the time
3189         window is much smaller.
3190
3191         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3192
3193 2011-01-03  Sam Weinig  <sam@webkit.org>
3194
3195         Reviewed by Anders Carlsson.
3196
3197         Make run-api-tests less chatty.
3198         https://bugs.webkit.org/show_bug.cgi?id=51831
3199
3200         - Make script quiet by default and add --verbose option (replacing --quiet).
3201         - When not verbose, pipe stdout and stderr to devnull.
3202
3203         * Scripts/run-api-tests:
3204
3205 2011-01-03  Pratik Solanki  <psolanki@apple.com>
3206
3207         Unreviewed. Adding myself to committers.py.
3208
3209         * Scripts/webkitpy/common/config/committers.py:
3210
3211 2011-01-03  Koan-Sin Tan  <koansin.tan@gmail.com>
3212
3213         Reviewed by Xan Lopez.
3214
3215         "Tool/Scripts/run-launcher --gtk" stopped working after 74855
3216         https://bugs.webkit.org/show_bug.cgi?id=51806
3217
3218         Originally, the $libraryName is 'JavaScriptCore'. When building release 
3219         one, the $libraryDir was 'WebKitBuild/Release/JavaScriptCore/../.libs/'
3220         which doesn't exist anymore ('WebKitBuild/Release/JavaScriptCore'
3221         is 'WebKitBuild/Release/Source/JavaScriptCore' now), and 
3222         'WebKitBuild/Release/Source/JavaScriptCore/../../.libs' looks weird,
3223         so make it 'WebKitBuild/Release/.libs'
3224
3225         * Scripts/webkitdirs.pm: 
3226
3227 2011-01-02  Patrick Gansterer  <paroga@webkit.org>
3228
3229         Reviewed by Adam Barth.
3230
3231         Make EFL a core builder
3232         https://bugs.webkit.org/show_bug.cgi?id=51804
3233
3234         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
3235         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3236
3237 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
3238
3239         [Qt] Unreviewed fix after r74855 and r74875.
3240
3241         * BuildSlaveSupport/built-product-archive:
3242          - Create directories explicitly.
3243          - Pass shell=True to subprocess.call().
3244
3245 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
3246
3247         [Qt] Unreviewed fix after r74855.
3248
3249         Move JavaScriptCore to Source
3250         https://bugs.webkit.org/show_bug.cgi?id=51604
3251
3252         * BuildSlaveSupport/built-product-archive: JavaScriptCore -> Source/JavaScriptCore
3253
3254 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
3255
3256         [Qt] Unreviewed run-javasriptcore-tests fix after r74855.
3257
3258         Move JavaScriptCore to Source
3259         https://bugs.webkit.org/show_bug.cgi?id=51604
3260
3261         * Scripts/webkitdirs.pm:
3262
3263 2011-01-02  Robert Hogan  <robert@webkit.org>
3264
3265         Unreviewed, build fix.
3266
3267         [Qt] Fix DRT build after 74855
3268
3269         * DumpRenderTree/qt/DumpRenderTree.pro:
3270
3271 2011-01-01  Adam Barth  <abarth@webkit.org>
3272
3273         Remove the assumption from the Qt and Gtk builds that every project is
3274         in the root directory.
3275
3276         * Scripts/build-webkit:
3277
3278 2011-01-01  Adam Barth  <abarth@webkit.org>
3279
3280         Reviewed by Eric Seidel.
3281
3282         Teach svn-apply how to apply patches even though JavaScriptCore has moved
3283         https://bugs.webkit.org/show_bug.cgi?id=51796
3284
3285         After this change, svn-apply will magically apply patches to
3286         JavaScriptCore/foo to Source/JavaScriptCore/foo.
3287
3288         * Scripts/VCSUtils.pm:
3289
3290 2011-01-01  Adam Barth  <abarth@webkit.org>
3291
3292         Reviewed by Eric Seidel.
3293
3294         Move JavaScriptCore to Source
3295         https://bugs.webkit.org/show_bug.cgi?id=51604
3296
3297         Update references to JavaScriptCore to point to the new location.
3298
3299         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3300         * DumpRenderTree/qt/DumpRenderTree.pro:
3301         * DumpRenderTree/qt/ImageDiff.pro:
3302         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3303         * DumpRenderTree/wscript:
3304         * Scripts/build-jsc:
3305         * Scripts/build-webkit:
3306         * Scripts/do-file-rename:
3307         * Scripts/do-webcore-rename:
3308         * Scripts/run-javascriptcore-tests:
3309         * Scripts/update-javascriptcore-test-results:
3310         * Scripts/webkitdirs.pm:
3311         * Scripts/webkitpy/common/config/build_unittest.py:
3312         * Scripts/webkitpy/style/checker.py:
3313         * Scripts/webkitpy/style/checker_unittest.py:
3314         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3315         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3316         * WebKitTestRunner/qt/WebKitTestRunner.pro:
3317         * wx/build/settings.py:
3318
3319 2011-01-01  Adam Barth  <abarth@webkit.org>
3320
3321         Reviewed by Eric Seidel.
3322
3323         Move Sources to Source
3324         https://bugs.webkit.org/show_bug.cgi?id=51794
3325
3326         Update scripts to point to the new location.
3327
3328         * Scripts/build-webkit:
3329         * Scripts/do-file-rename:
3330         * Scripts/do-webcore-rename:
3331         * Scripts/webkitpy/common/config/build.py:
3332         * Scripts/webkitpy/common/config/build_unittest.py:
3333
3334 2010-12-31  Kent Tamura  <tkent@chromium.org>
3335
3336         Reviewed by Eric Seidel.
3337
3338         [DRT/Chromium] Enable mock spell checker on non-OSX
3339         https://bugs.webkit.org/show_bug.cgi?id=51401
3340
3341         * DumpRenderTree/chromium/WebViewHost.cpp:
3342         (WebViewHost::spellCheck):
3343
3344 2010-12-31  Adam Barth  <abarth@webkit.org>
3345
3346         Reviewed by Ariya Hidayat.
3347
3348         Remove Tools/Scripts/wkstyle
3349         https://bugs.webkit.org/show_bug.cgi?id=51774
3350
3351         This script appears to not have been touched in a while and seems to
3352         have been replaced by check-webkit-style.
3353
3354         * Scripts/wkstyle: Removed.
3355
3356 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
3357
3358         Unreviewed. Coding style fix.
3359
3360         * DumpRenderTree/chromium/TestShell.h:
3361
3362 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
3363
3364         Reviewed by Pavel Feldman.
3365
3366         Web Inspector: [Chromium] Inspector's tests are very slow on Win(Dbg).
3367
3368         It was a problem with Chromium DRT. DevToolsAgent object instance was
3369         attached not only to the inspected page but to the DevTools window too.
3370         As result all the inspector files were interpreted as a content of inspected page
3371         and were transfered to the DevTools scripts panel for debugging etc.
3372
3373         https://bugs.webkit.org/show_bug.cgi?id=51735
3374
3375         * DumpRenderTree/chromium/TestShell.cpp:
3376         (TestShell::TestShell):
3377         (TestShell::bindJSObjectsToWindow):
3378         (TestShell::createNewWindow):
3379         * DumpRenderTree/chromium/TestShell.h:
3380
3381 2010-12-31  Adam Barth  <abarth@webkit.org>
3382
3383         Rubber-stamped by Eric Seidel.
3384
3385         Move PageLoadTests to PerformanceTests/PageLoad
3386         https://bugs.webkit.org/show_bug.cgi?id=51771
3387
3388         Update references to PageLoadTests to point to the new location.
3389
3390         * Scripts/run-pageloadtest:
3391         * Scripts/webkitpy/common/config/build.py:
3392
3393 2010-12-31  Adam Barth  <abarth@webkit.org>
3394
3395         Rubber-stamped by Eric Seidel.
3396
3397         Move SunSpider into PerformanceTests
3398         https://bugs.webkit.org/show_bug.cgi?id=51769
3399
3400         Update these scripts to point to the new location.
3401
3402         * Scripts/run-sunspider:
3403         * Scripts/sunspider-compare-results:
3404
3405 2010-12-30  Mihai Parparita  <mihaip@chromium.org>
3406
3407         Reviewed by Kent Tamura.
3408
3409         [Chromium] Add WebThemeEngineDRTMac so that Chromium DRT scrollbar rendering can match the Mac port's
3410         https://bugs.webkit.org/show_bug.cgi?id=51728
3411         
3412         Add implementation of the Mac WebThemeEngine that uses an NSScroller
3413         to render top-level scrollbars. This makes them match the Mac port's
3414         use of an NSScrollView, which means that we'll be able to share more
3415         pixel baselines.
3416         
3417         The new rendering code will not be activated until the 
3418         USE_WEB_THEME_ENGINE_TO_PAINT_THUMB #define is fliped in
3419         ScrollbarThemeChromiumMac.
3420
3421         * DumpRenderTree/DumpRenderTree.gypi:
3422         * DumpRenderTree/chromium/TestShellMac.mm:
3423         (platformInit):
3424         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Added.
3425         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Added.
3426         (+[FakeActiveWindow alwaysActiveWindow]):
3427         (+[FakeActiveWindow alwaysInactiveWindow]):
3428         (-[FakeActiveWindow initWithActiveControls:]):
3429         (-[FakeActiveWindow _hasActiveControls]):
3430         (WebThemeEngineDRTMac::paintScrollbarThumb):
3431         (stateToHIEnableState):
3432         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
3433         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
3434
3435 2010-12-30  Konstantin Tokarev  <annulen@yandex.ru>
3436
3437         Reviewed by David Kilzer.
3438
3439         [Qt] Don't build wtf/TCSystemAlloc.cpp if --system-malloc option is
3440         used
3441         https://bugs.webkit.org/show_bug.cgi?id=51672
3442
3443         * DumpRenderTree/qt/DumpRenderTree.pro: Replaced USE_SYSTEM_MALLOC
3444         with USE_SYSTEM_MALLOC=1
3445         * WebKitTestRunner/qt/WebKitTestRunner.pro: Replaced USE_SYSTEM_MALLOC
3446         with USE_SYSTEM_MALLOC=1
3447
3448 2010-12-30  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3449
3450         Reviewed by David Kilzer.
3451
3452         [Qt] [Symbian] Fix build-webkit script for Symbian
3453         https://bugs.webkit.org/show_bug.cgi?id=51509
3454
3455         Set the OUTPUT_DIR for Symbian to be the same as the source
3456         directory.
3457
3458         * Scripts/webkitdirs.pm:
3459
3460 2010-12-30  Martin Robinson  <mrobinson@igalia.com>
3461
3462         Reviewed by Darin Adler.
3463
3464         check-webkit-style should ignore NULL usage in calls to gtk_widget_style_get
3465         https://bugs.webkit.org/show_bug.cgi?id=51758
3466
3467         Add a check-webkit-style exception for gtk_widget_style_get and NULL usage.
3468
3469         * Scripts/webkitpy/style/checkers/cpp.py: Add the exception.
3470         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add some tests for this.
3471
3472 2010-12-29  Patrick Gansterer  <paroga@webkit.org>
3473
3474         Unreviewed WinCE buildfix.
3475
3476         * WinCELauncher/main.cpp: Add missing include.
3477
3478 2010-12-29  Daniel Bates  <dbates@rim.com>
3479
3480         Reviewed by Darin Adler.
3481
3482         svn-apply updates date of wrong change log entry for a change log diff that
3483         contains two consecutive entries with the same author and date
3484         https://bugs.webkit.org/show_bug.cgi?id=46061
3485
3486         Fixes an issue where the date of the wrong change log entry may be modified.
3487         Moreover, changes fixChangeLogPatch() to move entries inserted earlier
3488         in a ChangeLog file to the top of the file.
3489
3490         Currently, fixChangeLogPatch() explicitly bails out and returns an unchanged
3491         diff when it detects that the diff inserts a change log entry earlier in a
3492         ChangeLog. It is unusual to land a patch that has such a deliberate ChangeLog
3493         change. With the advent of the commit-queue this functionality of bailing out
3494         and hence landing the patch as-is is harmful to the accuracy of the ChangeLog.
3495         Instead, we should always move the change log entry to the top of the ChangeLog file.
3496
3497         A side-effect of this change is that setChangeLogDateAndReviewer() now updates
3498         the date line of the correct change log entry in a ChangeLog diff.
3499
3500         * Scripts/VCSUtils.pm: Modified fixChangeLogPatch() to move entries inserted earlier to the top.
3501
3502         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
3503           Updated the following unit tests now that we move entries inserted earlier to the top:
3504           - "fixChangeLogPatch: New entry inserted in middle."
3505             (formerly named "fixChangeLogPatch: [no change] New entry inserted in middle.")
3506
3507           - "fixChangeLogPatch: New entry inserted earlier in the file, but after an entry with the same author and date."
3508             (formerly named "fixChangeLogPatch: [no change] New entry inserted earlier in the file, but after an entry with the same author and date.")
3509
3510         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatchThenSetChangeLogDateAndReviewer.pl: Added.
3511
3512 2010-12-29  Konstantin Tokarev  <annulen@yandex.ru>
3513
3514         Reviewed by Eric Seidel.
3515
3516         [Qt] Fixed compatibility with gold linker on X11 platforms
3517         https://bugs.webkit.org/show_bug.cgi?id=51700
3518
3519         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3520         Linked TestNetscapePlugin with libX11 on Unix platforms
3521
3522 2010-12-29  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
3523
3524         Reviewed by Darin Adler.
3525
3526         Circular dependency in webkitpy.common.checkout.changelog module
3527         https://bugs.webkit.org/show_bug.cgi?id=50475
3528
3529         Remove automatic import of api.Checkout module when any checkout/
3530         submodule is imported (e.g.: when checkout.scm.Git is imported).
3531
3532         * Scripts/webkitpy/common/checkout/__init__.py:
3533
3534 2010-12-29  Martin Robinson  <mrobinson@igalia.com>
3535
3536         Reviewed by Ojan Vafai.
3537
3538         prepare-ChangeLog should support the -g option for specifying the git-commit
3539         https://bugs.webkit.org/show_bug.cgi?id=51708
3540
3541         Add a -g shortcut for the --git-commit prepare-ChangeLog option. This matches
3542         webkit-patch, though the exact meaning of the two options remain different.
3543
3544         * Scripts/prepare-ChangeLog: Add -g.
3545
3546 2010-12-29  Kent Hansen  <kent.hansen@nokia.com>
3547
3548         Reviewed by Simon Hausmann.
3549
3550         [Qt] Fix compilation with Qt in namespace
3551         https://bugs.webkit.org/show_bug.cgi?id=51701
3552
3553         * QtTestBrowser/webview.h:
3554
3555 2010-12-28  Daniel Bates  <dbates@rim.com>
3556
3557         Reviewed by Sam Weinig.
3558
3559         Substitute // MARK: for compiler-specific #pragma mark
3560         https://bugs.webkit.org/show_bug.cgi?id=51657
3561
3562         Fix future compilation warnings about "#pragma mark" on GTK+ bots by
3563         substituting  "// MARK:" for "#pragma mark", which provides
3564         analogous code-bookmarking functionality under Xcode.
3565
3566         Also, for consistency, we should substitute "// MARK:" for compiler-
3567         specific "#pragma mark" in the source files for the Mac port.
3568
3569         * DumpRenderTree/AccessibilityTextMarker.cpp:
3570         * DumpRenderTree/cf/WebArchiveDumpSupport.h:
3571         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
3572         * DumpRenderTree/mac/ObjCController.m:
3573         * MiniBrowser/mac/AppDelegate.m:
3574         * MiniBrowser/mac/BrowserWindowController.m:
3575
3576 2010-12-28  Xan Lopez  <xlopez@igalia.com>
3577
3578         Reviewed by Eric Seidel.
3579
3580         Add --no-build option to run-sunspider
3581         https://bugs.webkit.org/show_bug.cgi?id=51658
3582
3583         * Scripts/run-sunspider: add --no-build flag to skip building
3584         phase.
3585
3586 2010-12-27  Daniel Bates  <dbates@rim.com>
3587
3588         Rubber-stamped by Martin Robinson.
3589
3590         Append the directory Tools/DumpRenderTree to the list of directories that
3591         do-webcore-rename should search so that it can rename DRT files and
3592         source code.
3593
3594         * Scripts/do-webcore-rename:
3595
3596 2010-12-27  Eric Seidel  <eric@webkit.org>
3597
3598         Reviewed by Adam Barth.
3599
3600         build-webkit should detect missing Java SDK and explain how to install it
3601         https://bugs.webkit.org/show_bug.cgi?id=51651
3602
3603         * Scripts/build-webkit:
3604
3605 2010-12-26  Martin Robinson  <mrobinson@igalia.com>
3606
3607         Reviewed by Daniel Bates.
3608
3609         [GTK] Add support for build-jsc
3610         https://bugs.webkit.org/show_bug.cgi?id=51625
3611
3612         Add GTK+ support to build-jsc now that building the jsc executable as
3613         a standalone target is easy.
3614
3615         * Scripts/build-jsc: Call buildGtkProject for the GTK+ case now.
3616         * Scripts/build-webkit: Pass in the proper target name to buildGtkProject.
3617         * Scripts/webkitdirs.pm: Actually process the project parameter in buildGtkProject
3618         and pass it along to buildAutotoolsProject.
3619
3620 2010-12-27  David Levin  <levin@chromium.org>
3621
3622         Reviewed by Eric Seidel.
3623
3624         check-webkit-style check for meaningless variable names in function declarations.
3625         https://bugs.webkit.org/show_bug.cgi?id=51523
3626
3627         * Scripts/webkitpy/style/checker.py: Exempted JavaScriptCore/jit/JITStubs.cpp
3628         from the new check and whitespace/parens because the syntax is unusual and
3629         produced a fair number of positives for these checks.
3630         * Scripts/webkitpy/style/checkers/cpp.py:
3631         (_convert_to_lower_with_underscores): Used as a canonical form for type names
3632         and parameter names when determining if the parameter name is useless.
3633         (_create_acronym): Used to check for redundant variable names in cases like "ExceptionCode ec"
3634         (Parameter.lower_with_underscores_name): Gives back the parameter name in a lower_with_underscore
3635         format.
3636         (_check_parameter_name_against_text):  Checks to see if the parameter name is in the
3637         text or an acronym of it.
3638         (check_function_definition): Checks function definitions for meaningless variable names.
3639         (process_line): Added call to check_function_definition.
3640         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3641         (CppFunctionsTest.test_convert_to_lower_with_underscores): Test for _convert_to_lower_with_underscores.
3642         (CppFunctionsTest.test_create_acronym): Test for _create_acronym.
3643         (CppFunctionsTest.test_check_parameter_against_text): Test for _check_parameter_against_text.
3644         (CppStyleTestBase.perform_single_line_lint): Removed the parameter name check
3645         because when only checking a snippet, there are a lot of bogus functions.
3646         (CppStyleTestBase.perform_multi_line_lint): Ditto and removed a bogus filter
3647         that I put there previously and just noticed.
3648         (WebKitStyleTest.test_parameter_names): Tests for the functionality -- both
3649         check_function_definition and process_line.
3650
3651 2010-12-27  Carlos Garcia Campos  <cgarcia@igalia.com>
3652
3653         Reviewed by Martin Robinson.
3654
3655         [GTK] Disable flash plugin in GtkLauncher when using gtk3
3656         https://bugs.webkit.org/show_bug.cgi?id=51591
3657
3658         Flash plugin uses gtk2 that is incompatible with gtk3 making
3659         webkit crash when it's built with gtk3.
3660
3661         * GtkLauncher/main.c:
3662         (main):
3663
3664 2010-12-25  Adam Barth  <abarth@webkit.org>
3665
3666         Reviewed by Eric Seidel.
3667
3668         Move ANGLE to Sources/ThirdParty
3669         https://bugs.webkit.org/show_bug.cgi?id=51605
3670
3671         * Scripts/build-webkit:
3672           - Point to the new ANGLE location.
3673
3674 2010-12-26  David Levin  <levin@chromium.org>
3675
3676         Reviewed by Eric Seidel.
3677
3678         check-webkit-style should be able to parse function declaration parameters.
3679         https://bugs.webkit.org/show_bug.cgi?id=51451
3680
3681         * Scripts/webkitpy/style/checkers/cpp.py:
3682         (Position.__init__): Holds simple position information (row, column).
3683         (Parameter.__init__): Holds information about a parameter.
3684         (SingleLineView.__init): Converts multiple lines into a single line for simpler searches.
3685         (SingleLineView.convert_column_to_row): Returns the original row given a column.
3686         (create_skeleton_parameters): Simplifies a parameter list for easier searching.
3687         (find_parameter_name_index): Finds where the parameter name is.
3688         (parameter_list): Generates the list of parameters for a function.
3689         (_FunctionState.begin): Added information to allow determining the parameters
3690         on demand.
3691         (_FunctionState.get_parameter_list): Returns a tuple of function parameters.
3692         (detect_functions): Improve function detection for operator functions and
3693         determine where the parameters end and pass that to _FunctionState.begin.
3694         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3695         (CppFunctionsTest.test_parameter): Verifies Parameter functionality.
3696         (CppFunctionsTest.test_single_line_view): Verifies SingleLineView functionality.
3697         (CppFunctionsTest.test_create_skeleton_parameters): Verifies create_skeleton_parameters.
3698         (CppFunctionsTest.test_find_parameter_name_index): Verifies find_parameter_name_index.
3699         (CppFunctionsTest.test_parameter_list): Does some minimal verification for parameter list.
3700         Much more thorough verification is done as part of FunctionDetectionTest.test_parameter_list.
3701         (FunctionDetectionTest.perform_function_detection): Added support for verifying
3702         the parameters found.
3703         (FunctionDetectionTest.test_function_declaration_detection): Added more function
3704         detection test to verify that we catch the operator functions.
3705         (FunctionDetectionTest.test_ignore_macros): Verify that function detection ignores macros.