Tools/ChangeLog

   1 2013-01-29  Michael Brüning  <michael.bruning@digia.com>
   2
   3         Unreviewed, updated my email information.
   4
   5         * Scripts/webkitpy/common/config/committers.py:
   6
   7 2013-01-29  Jochen Eisinger  <jochen@chromium.org>
   8
   9         [chromium] delete DRTTestRunner
  10         https://bugs.webkit.org/show_bug.cgi?id=108082
  11
  12         Reviewed by Adam Barth.
  13
  14         * DumpRenderTree/DumpRenderTree.gypi:
  15         * DumpRenderTree/chromium/DRTTestRunner.cpp: Removed.
  16         * DumpRenderTree/chromium/DRTTestRunner.h: Removed.
  17         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
  18         (WebTestRunner::WebTestDelegate::testFinished):
  19         (WebTestRunner::WebTestDelegate::testTimedOut):
  20         (WebTestRunner::WebTestDelegate::isBeingDebugged):
  21         (WebTestRunner::WebTestDelegate::layoutTestTimeout):
  22         (WebTestRunner::WebTestDelegate::closeRemainingWindows):
  23         (WebTestRunner::WebTestDelegate::navigationEntryCount):
  24         (WebTestRunner::WebTestDelegate::windowCount):
  25         (WebTestRunner::WebTestDelegate::setCustomPolicyDelegate):
  26         (WebTestRunner::WebTestDelegate::waitForPolicyDelegate):
  27         (WebTestRunner::WebTestDelegate::goToOffset):
  28         (WebTestRunner::WebTestDelegate::reload):
  29         (WebTestRunner::WebTestDelegate::loadURLForFrame):
  30         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
  31         (WebTestRunner::WebTestRunner::policyDelegateDone):
  32         (WebTestRunner::WebTestRunner::shouldInterceptPostMessage):
  33         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
  34         (WebTestRunner::TestRunner::WorkQueue::~WorkQueue):
  35         (WebTestRunner):
  36         (WebTestRunner::TestRunner::WorkQueue::processWorkSoon):
  37         (WebTestRunner::TestRunner::WorkQueue::processWork):
  38         (WebTestRunner::TestRunner::WorkQueue::reset):
  39         (WebTestRunner::TestRunner::WorkQueue::addWork):
  40         (WebTestRunner::TestRunner::TestRunner):
  41         (WebTestRunner::TestRunner::reset):
  42         (WebTestRunner::TestRunner::policyDelegateDone):
  43         (WebTestRunner::TestRunner::shouldInterceptPostMessage):
  44         (WebTestRunner::TestRunner::waitUntilDone):
  45         (WebTestRunner::TestRunner::notifyDone):
  46         (WebTestRunner::TestRunner::completeNotifyDone):
  47         (WorkItemBackForward):
  48         (WebTestRunner::WorkItemBackForward::WorkItemBackForward):
  49         (WebTestRunner::WorkItemBackForward::run):
  50         (WebTestRunner::TestRunner::queueBackNavigation):
  51         (WebTestRunner::TestRunner::queueForwardNavigation):
  52         (WorkItemReload):
  53         (WebTestRunner::WorkItemReload::run):
  54         (WebTestRunner::TestRunner::queueReload):
  55         (WorkItemLoadingScript):
  56         (WebTestRunner::WorkItemLoadingScript::WorkItemLoadingScript):
  57         (WebTestRunner::WorkItemLoadingScript::run):
  58         (WorkItemNonLoadingScript):
  59         (WebTestRunner::WorkItemNonLoadingScript::WorkItemNonLoadingScript):
  60         (WebTestRunner::WorkItemNonLoadingScript::run):
  61         (WebTestRunner::TestRunner::queueLoadingScript):
  62         (WebTestRunner::TestRunner::queueNonLoadingScript):
  63         (WorkItemLoad):
  64         (WebTestRunner::WorkItemLoad::WorkItemLoad):
  65         (WebTestRunner::WorkItemLoad::run):
  66         (WebTestRunner::TestRunner::queueLoad):
  67         (WorkItemLoadHTMLString):
  68         (WebTestRunner::WorkItemLoadHTMLString::WorkItemLoadHTMLString):
  69         (WebTestRunner::WorkItemLoadHTMLString::run):
  70         (WebTestRunner::TestRunner::queueLoadHTMLString):
  71         (WebTestRunner::TestRunner::locationChangeDone):
  72         (WebTestRunner::TestRunner::windowCount):
  73         (WebTestRunner::TestRunner::setCloseRemainingWindowsWhenComplete):
  74         (WebTestRunner::TestRunner::setCustomPolicyDelegate):
  75         (WebTestRunner::TestRunner::waitForPolicyDelegate):
  76         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
  77         (TestRunner):
  78         (WorkItem):
  79         (WebTestRunner::TestRunner::WorkItem::~WorkItem):
  80         (WorkQueue):
  81         (WebTestRunner::TestRunner::WorkQueue::WorkQueue):
  82         (WebTestRunner::TestRunner::WorkQueue::setFrozen):
  83         (WebTestRunner::TestRunner::WorkQueue::isEmpty):
  84         (WebTestRunner::TestRunner::WorkQueue::taskList):
  85         * DumpRenderTree/chromium/TestShell.cpp:
  86         (TestShell::initialize):
  87         (TestShell::runFileTest):
  88         (TestShell::loadURL):
  89         (TestShell::createNewWindow):
  90         * DumpRenderTree/chromium/TestShell.h:
  91         (TestShell::testRunner):
  92         (TestShell):
  93         * DumpRenderTree/chromium/WebViewHost.cpp:
  94         (WebViewHost::testFinished):
  95         (WebViewHost::testTimedOut):
  96         (WebViewHost::isBeingDebugged):
  97         (WebViewHost::layoutTestTimeout):
  98         (WebViewHost::closeRemainingWindows):
  99         (WebViewHost::navigationEntryCount):
 100         (WebViewHost::windowCount):
 101         (WebViewHost::setCustomPolicyDelegate):
 102         (WebViewHost::waitForPolicyDelegate):
 103         (WebViewHost::goToOffset):
 104         (WebViewHost::reload):
 105         (WebViewHost::loadURLForFrame):
 106         (WebViewHost::shutdown):
 107         (WebViewHost::testRunner):
 108         * DumpRenderTree/chromium/WebViewHost.h:
 109         (WebTestRunner):
 110         (WebViewHost):
 111
 112 2013-01-28  Timothy Loh  <timloh@chromium.com>
 113
 114         Refactor ChangeLog and PrepareChangeLog to use FileSystem objects
 115         https://bugs.webkit.org/show_bug.cgi?id=107903
 116
 117         Reviewed by Eric Seidel.
 118
 119         To make ChangeLog and PrepareChangeLog easier to test, we can use
 120         FileSystem objects instead of just passing around paths.
 121
 122         * Scripts/webkitpy/common/checkout/changelog.py:
 123         (ChangeLog.__init__):
 124         (ChangeLog.parse_latest_entry_from_file):
 125         (ChangeLog.parse_entries_from_file):
 126         (ChangeLog.latest_entry):
 127         (ChangeLog.update_with_unreviewed_message):
 128         (ChangeLog.set_reviewer):
 129         (ChangeLog.set_short_description_and_bug_url):
 130         (ChangeLog.delete_entries):
 131         (ChangeLog.prepend_text):
 132         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
 133         (ChangeLogTest):
 134         (test_parse_log_entries_from_changelog):
 135         (test_latest_entry_parse_single_entry):
 136         (test_set_reviewer):
 137         (test_set_short_description_and_bug_url):
 138         (test_delete_entries):
 139         (test_prepend_text):
 140         * Scripts/webkitpy/common/system/filesystem_mock.py:
 141         (ReadableTextFileObject.__init__):
 142         * Scripts/webkitpy/tool/steps/preparechangelog.py:
 143         (PrepareChangeLog._ensure_bug_url):
 144         (PrepareChangeLog._resolve_existing_entry):
 145         (PrepareChangeLog.run):
 146         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
 147         (test_ensure_bug_url):
 148         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
 149         (_assert_message_for_revert_output):
 150
 151 2013-01-28  Raymond Toy  <rtoy@google.com>
 152
 153         Add myself to committers.py
 154         https://bugs.webkit.org/show_bug.cgi?id=107992
 155
 156         Reviewed by kbr@google.com.
 157
 158         * Scripts/webkitpy/common/config/committers.py:
 159
 160 2013-01-28  Joseph Pecoraro  <pecoraro@apple.com>
 161
 162         [Mac] Update PageVisibilityState when WebView is hidden / visible
 163         https://bugs.webkit.org/show_bug.cgi?id=107509
 164
 165         Reviewed by Sam Weinig.
 166
 167         Add a test that PageVisibility of WK1 WebViews and WK2 WKViews
 168         automatically changes between hidden and visible as the view is added
 169         and removed from window, or when it is in a window that changes
 170         visibility, for instance by minimizing / deminimizing.
 171
 172         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 173         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.html: Added.
 174         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm: Added.
 175         (-[PageVisibilityStateDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
 176         (runJavaScriptAlert):
 177         (PageVisibilityStateWithWindowChanges):
 178         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::initializeView):
 179         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::teardownView):
 180         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):
 181         (TestWebKitAPI::TEST_F):
 182         Test visibility state of a page in a WebView/WKView with different window states.
 183
 184         * TestWebKitAPI/mac/WebKitAgnosticTest.h:
 185         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
 186         (TestWebKitAPI::WebKitAgnosticTest::teardownView):
 187         (TestWebKitAPI::WebKitAgnosticTest::runWebKit1Test):
 188         (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):
 189         Add a WK1 and WK2 teardownView to balance initializeView.
 190
 191 2013-01-28  Joseph Pecoraro  <pecoraro@apple.com>
 192
 193         Improve PageVisibility API with enums
 194         https://bugs.webkit.org/show_bug.cgi?id=107364
 195
 196         Reviewed by Sam Weinig.
 197
 198         * DumpRenderTree/mac/TestRunnerMac.mm:
 199         (TestRunner::resetPageVisibility):
 200         (TestRunner::setPageVisibility):
 201         Update the WK1 test code to use the new WK1 enums.
 202
 203         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
 204         (WTR::InjectedBundle::setVisibilityState):
 205         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
 206         (InjectedBundle):
 207         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
 208         (WTR::TestRunner::setPageVisibility):
 209         (WTR::TestRunner::resetPageVisibility):
 210         * WebKitTestRunner/TestController.cpp:
 211         (WTR::TestController::setVisibilityState):
 212         * WebKitTestRunner/TestController.h:
 213         (TestController):
 214         * WebKitTestRunner/TestInvocation.cpp:
 215         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
 216         Update the WK2 test code to use the new WK2 API and enums.
 217
 218         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 219         * TestWebKitAPI/Tests/WebKit2/PageVisibilityState.cpp: Added.
 220         (TestWebKitAPI):
 221         (TestWebKitAPI::setPageVisibilityStateWithEvalContinuation):
 222         (TestWebKitAPI::assertSerializedScriptValueIsStringValue):
 223         (TestWebKitAPI::didRunStep1StateChangeVisibleToHidden):
 224         (TestWebKitAPI::didRunStep2StateChangeHiddenToPrerender):
 225         (TestWebKitAPI::didRunStep3StateChangePrerenderToPreview):
 226         (TestWebKitAPI::didRunStep4InStatePreview):
 227         (TestWebKitAPI::TEST):
 228         Test the new WK2 API with all enum types.
 229
 230 2013-01-28  Jochen Eisinger  <jochen@chromium.org>
 231
 232         [chromium] remove temporary define used for updating TestRunner API
 233
 234         Unreviewed. Clean-up change.
 235
 236         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
 237
 238 2013-01-28  James Craig  <james@cookiecrook.com>
 239
 240         HTML5 promotes DL from specific 'definition list' to superset 'description list'; accessibility strings and accessors should be updated to match.
 241         https://bugs.webkit.org/show_bug.cgi?id=107650
 242
 243         Reviewed by Chris Fleizach.
 244
 245         Updating accessibility strings and accessors for DL/DT/DD.
 246
 247         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Utilities.js:
 248         (createDescriptionList):
 249         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ViewController.js:
 250         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
 251
 252 2013-01-28  Manuel Rego Casasnovas  <rego@igalia.com>
 253
 254         [GTK][WTR] Update layoutTestController.pathToLocalResource
 255         https://bugs.webkit.org/show_bug.cgi?id=107538
 256
 257         Reviewed by Martin Robinson.
 258
 259         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
 260         (WTR::TestRunner::pathToLocalResource): Update implementation based on
 261         DRT code.
 262
 263 2013-01-28  Manuel Rego Casasnovas  <rego@igalia.com>
 264
 265         [GTK][WTR] Move getTopLevelPath() to utilities file
 266         https://bugs.webkit.org/show_bug.cgi?id=107541
 267
 268         Reviewed by Martin Robinson.
 269
 270         * WebKitTestRunner/GNUmakefile.am: Add new files.
 271         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
 272         (WTR::getOutputDir): Uses the moved method from InjectedBundleUtilities.
 273         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp: Added.
 274         (WTR):
 275         (WTR::topLevelPath): Implementation moved from ActivateFontsGtk.
 276         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.h: Added.
 277         (WTR): Add new method header and documentation.
 278
 279 2013-01-28  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
 280
 281         [EFL] Include Ecore_Getopt.h in MiniBrowser.
 282         https://bugs.webkit.org/show_bug.cgi?id=108067
 283
 284         Reviewed by Kenneth Rohde Christiansen.
 285
 286         Be explicit and include Ecore_Getopt.h since we use it for parsing
 287         command line options. It is safer than relying on other headers
 288         including it for us.
 289
 290         * MiniBrowser/efl/main.c:
 291
 292 2013-01-28  Renata Hodovan  <reni@webkit.org>
 293
 294         [WK2] Putting QtWebProcess into a chrooted sandbox
 295         https://bugs.webkit.org/show_bug.cgi?id=90005
 296
 297         Reviewed by Anders Carlsson and  Zoltan Herczeg.
 298
 299         Add feature flag for suid sandbox in linux.
 300
 301         * Scripts/webkitperl/FeatureList.pm:
 302
 303 2013-01-27  David Farler  <dfarler@apple.com>
 304
 305         REGRESSION (r140912): Broke specifying non-trivial ARCHS value to make / build-webkit
 306         https://bugs.webkit.org/show_bug.cgi?id=108028
 307
 308         Reviewed by Dan Bernstein.
 309
 310         * DumpRenderTree/Makefile: Reverted.
 311         * Makefile: Reverted.
 312         * Scripts/webkitdirs.pm: Reverted.
 313
 314 2013-01-27  Zoltan Arvai  <zarvai@inf.u-szeged.hu>
 315
 316         Fixing atomicIncrement implementation for Windows by dropping support before XP SP2.
 317         https://bugs.webkit.org/show_bug.cgi?id=106740
 318
 319         Reviewed by Benjamin Poulain.
 320
 321         * DumpRenderTree/config.h:
 322         * WinLauncher/stdafx.h:
 323
 324 2013-01-26  David Farler  <dfarler@apple.com>
 325
 326         Makefiles should work for arbitrary SDKs and architectures on Apple ports
 327         https://bugs.webkit.org/show_bug.cgi?id=107863
 328
 329         Reviewed by David Kilzer.
 330
 331         * Makefile:
 332         Added temporary filters for projects not yet building on iOS.
 333         * DumpRenderTree/Makefile:
 334         Building with iOS SDKs -> -target All-iOS
 335         * Scripts/webkitdirs.pm:
 336         (determineConfiguration):
 337         Added --configuration switch detection.
 338         (determineArchitecture):
 339         Added --architecture and ARCH=(.*) switch detection.
 340         (argumentsForConfiguration):
 341         (determineXcodeSDK):
 342         Look for --device, --simulator, and --sdk switches.
 343         (xcodeSDK):
 344         Added.
 345         (XcodeOptions):
 346         Determine Xcode SDK and generate -arch switches.
 347
 348 2013-01-25  Jochen Eisinger  <jochen@chromium.org>
 349
 350         [chromium] move tracking of the top loading frame to TestRunner library
 351         https://bugs.webkit.org/show_bug.cgi?id=107948
 352
 353         Reviewed by Adam Barth.
 354
 355         * DumpRenderTree/chromium/DRTTestRunner.cpp:
 356         (DRTTestRunner::WorkQueue::processWorkSoon):
 357         (DRTTestRunner::WorkQueue::processWork):
 358         (DRTTestRunner::completeNotifyDone):
 359         * DumpRenderTree/chromium/DRTTestRunner.h:
 360         (DRTTestRunner):
 361         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
 362         (WebTestProxyBase):
 363         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
 364         (WebTestRunner::WebTestRunner::setTopLoadingFrame):
 365         (WebTestRunner::WebTestRunner::topLoadingFrame):
 366         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
 367         (WebTestRunner::TestRunner::TestRunner):
 368         (WebTestRunner::TestRunner::reset):
 369         (WebTestRunner::TestRunner::setTopLoadingFrame):
 370         (WebTestRunner):
 371         (WebTestRunner::TestRunner::topLoadingFrame):
 372         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
 373         (TestRunner):
 374         (WebTestRunner::TestRunner::locationChangeDone):
 375         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
 376         (WebTestRunner::WebTestProxyBase::didStartProvisionalLoad):
 377         (WebTestRunner::WebTestProxyBase::didFailProvisionalLoad):
 378         (WebTestRunner::WebTestProxyBase::didFailLoad):
 379         (WebTestRunner::WebTestProxyBase::didFinishLoad):
 380         (WebTestRunner::WebTestProxyBase::locationChangeDone):
 381         (WebTestRunner):
 382         * DumpRenderTree/chromium/WebViewHost.cpp:
 383         (WebViewHost::reset):
 384         (WebViewHost::updateURL):
 385         * DumpRenderTree/chromium/WebViewHost.h:
 386         (WebViewHost):
 387
 388 2013-01-25  Sheriff Bot  <webkit.review.bot@gmail.com>
 389
 390         Unreviewed, rolling out r140774.
 391         http://trac.webkit.org/changeset/140774
 392         https://bugs.webkit.org/show_bug.cgi?id=107932
 393
 394          Tests ScrollingCoordinatorChromiumTest.fastScrollingByDefault
 395         and fastScrollingForFixedPosition are failing (Requested by
 396         keishi on #webkit).
 397
 398         * DumpRenderTree/chromium/WebViewHost.cpp:
 399         (WebViewHost::initializeLayerTreeView):
 400         (WebViewHost::setWebWidget):
 401
 402 2013-01-25  Alan Cutter  <alancutter@chromium.org>
 403
 404         Quick fix for Chromium EWS bots running out of space due to a tmp file leak
 405         https://bugs.webkit.org/show_bug.cgi?id=107905
 406
 407         Reviewed by Eric Seidel.
 408
 409         Added line to EWS loop to clear /tmp of known Chromium test leak.
 410         Directories named ".org.chromium.Chromium.XXXXXX" not getting cleaned up.
 411
 412         * EWSTools/start-queue.sh:
 413
 414 2013-01-25  Ryosuke Niwa  <rniwa@webkit.org>
 415
 416         Update Anne's email address
 417         https://bugs.webkit.org/show_bug.cgi?id=107866
 418
 419         Reviewed by Adam Barth.
 420
 421         * Scripts/webkitpy/common/config/committers.py:
 422
 423 2013-01-24  Alan Cutter  <alancutter@chromium.org>
 424
 425         HTTP 500 error between QueueStatusServer and bot(s)
 426         https://bugs.webkit.org/show_bug.cgi?id=107184
 427
 428         Reviewed by Adam Barth.
 429
 430         Removed the use of memcache which was the source of the exception.
 431
 432         * QueueStatusServer/handlers/updatestatus.py:
 433         (UpdateStatus.post):
 434         * QueueStatusServer/model/attachment.py:
 435         (Attachment):
 436         (Attachment.summary):
 437
 438 2013-01-24  Sheriff Bot  <webkit.review.bot@gmail.com>
 439
 440         Unreviewed, rolling out r140653.
 441         http://trac.webkit.org/changeset/140653
 442         https://bugs.webkit.org/show_bug.cgi?id=107916
 443
 444         Causes a temp file leak on the bots (Requested by abarth on
 445         #webkit).
 446
 447         * DumpRenderTree/chromium/TestShell.cpp:
 448         (TestShell::resetTestController):
 449
 450 2013-01-24  Eric Seidel  <eric@webkit.org>
 451
 452         Skip haslanded_unittest.py on systems which do not have interdiff installed
 453         https://bugs.webkit.org/show_bug.cgi?id=106402
 454
 455         Unreviewed.
 456
 457         * Scripts/webkitpy/tool/steps/haslanded_unittest.py:
 458         (HasLandedTest):
 459
 460 2013-01-24  Ryosuke Niwa  <rniwa@webkit.org>
 461
 462         Disable the failing webkitpy test for now.
 463
 464         * Scripts/webkitpy/tool/steps/haslanded_unittest.py:
 465
 466 2013-01-24  Tim 'mithro' Ansell  <mithro@mithis.com>
 467
 468         Fixing the diff_parser to correctly identify git diffs even with leading comments.
 469         https://bugs.webkit.org/show_bug.cgi?id=107871
 470
 471         Reviewed by Eric Seidel.
 472
 473         * Scripts/webkitpy/common/checkout/diff_parser.py:
 474         * Scripts/webkitpy/common/checkout/diff_parser_unittest.py:
 475         * Scripts/webkitpy/tool/steps/haslanded.py:
 476
 477 2013-01-24  James Robinson  <jamesr@chromium.org>
 478
 479         [chromium] Remove dead transitional code from WebViewImpl
 480         https://bugs.webkit.org/show_bug.cgi?id=107889
 481
 482         Reviewed by Adrienne Walker.
 483
 484         * DumpRenderTree/chromium/WebViewHost.cpp:
 485         (WebViewHost::initializeLayerTreeView):
 486         (WebViewHost::setWebWidget):
 487
 488 2013-01-24  Joshua Bell  <jsbell@chromium.org>
 489
 490         Add watchlist for IndexedDB development, and add myself and others.
 491
 492         Unreviewed.
 493
 494         * Scripts/webkitpy/common/config/watchlist:
 495
 496 2013-01-24  Martin Robinson  <mrobinson@igalia.com>
 497
 498         Abstract the logic for appending a UChar32 onto StringBuilder
 499         https://bugs.webkit.org/show_bug.cgi?id=107505
 500
 501         Reviewed by Darin Adler.
 502
 503         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
 504         (TestWebKitAPI::TEST): Added a simple test for appending UChar32.
 505
 506 2013-01-24  Erik Arvidsson  <arv@chromium.org>
 507
 508         Unreviewed, rolling out r140703.
 509         http://trac.webkit.org/changeset/140703
 510         https://bugs.webkit.org/show_bug.cgi?id=107556
 511
 512         r140561 was not the reason for the Android breakage
 513
 514         * DumpRenderTree/chromium/TestShell.cpp:
 515         (TestShell::~TestShell):
 516         (TestShell::closeWindow):
 517         * DumpRenderTree/chromium/WebViewHost.cpp:
 518         (WebViewHost::WebViewHost):
 519         (WebViewHost::~WebViewHost):
 520         (WebViewHost::shutdown):
 521         * DumpRenderTree/chromium/WebViewHost.h:
 522         (WebViewHost):
 523
 524 2013-01-24  Dean Jackson  <dino@apple.com>
 525
 526         Allow some plugin snapshot UI content to come from Injected Bundle
 527         https://bugs.webkit.org/show_bug.cgi?id=107852
 528
 529         Reviewed by Anders Carlsson.
 530
 531         Null implementations of plugInStartLabelTitle, plugInStartLabelSubtitle and
 532         plugInExtraStyleSheet.
 533
 534         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
 535         (WTR::InjectedBundlePage::InjectedBundlePage):
 536
 537 2013-01-24  Erik Arvidsson  <arv@chromium.org>
 538
 539         Unreviewed, rolling out r140561.
 540         http://trac.webkit.org/changeset/140561
 541         https://bugs.webkit.org/show_bug.cgi?id=107556
 542
 543         Suspected to break Android which prevens WebKit roll
 544
 545         * DumpRenderTree/chromium/TestShell.cpp:
 546         (TestShell::~TestShell):
 547         (TestShell::closeWindow):
 548         * DumpRenderTree/chromium/WebViewHost.cpp:
 549         (WebViewHost::WebViewHost):
 550         (WebViewHost::~WebViewHost):
 551         * DumpRenderTree/chromium/WebViewHost.h:
 552         (WebViewHost):
 553
 554 2013-01-24  Tim 'mithro' Ansell  <mithro@mithis.com>
 555
 556         Adding "has-landed" command to webkit-patch which compares a
 557         committed patch to the changes which exist locally (ignoring the
 558         ChangeLog file).
 559
 560         https://bugs.webkit.org/show_bug.cgi?id=106402
 561
 562         Reviewed by Eric Seidel.
 563
 564         * Scripts/webkitpy/common/checkout/diff_parser.py:
 565         (git_diff_to_svn_diff):
 566         * Scripts/webkitpy/common/net/bugzilla/bug.py:
 567         (Bug.commit_revision):
 568         * Scripts/webkitpy/common/net/bugzilla/bug_unittest.py:
 569         (BugTest.test_is_in_comments):
 570         (BugTest):
 571         (BugTest.test_commit_revision):
 572         * Scripts/webkitpy/tool/commands/upload.py:
 573         (HasLanded):
 574         * Scripts/webkitpy/tool/steps/__init__.py:
 575         * Scripts/webkitpy/tool/steps/haslanded.py: Added.
 576         (HasLanded):
 577         (HasLanded.convert_to_svn):
 578         (HasLanded.strip_change_log):
 579         (run):
 580
 581         * Scripts/webkitpy/common/net/bugzilla/bug.py:
 582         (Bug.commit_revision):
 583         * Scripts/webkitpy/common/net/bugzilla/bug_unittest.py:
 584         (BugTest.test_is_in_comments):
 585         (BugTest):
 586         (BugTest.test_commit_revision):
 587         * Scripts/webkitpy/tool/commands/upload.py:
 588         (HasLanded):
 589         * Scripts/webkitpy/tool/steps/__init__.py:
 590         * Scripts/webkitpy/tool/steps/haslanded.py: Added.
 591         (HasLanded):
 592         (HasLanded.convert_to_svn):
 593         (HasLanded.strip_change_log):
 594         (HasLanded.diff_diff):
 595         (HasLanded.run):
 596         * Scripts/webkitpy/tool/steps/haslanded_unittest.py: Added.
 597         (HasLandedTest):
 598         (HasLandedTest.test_run):
 599         (test_convert_to_svn_and_strip_change_log):
 600
 601 2013-01-24  Dan Carney  <dcarney@google.com>
 602
 603         [chromium] move most WebViewHost printf calls to WebTestProxy
 604         https://bugs.webkit.org/show_bug.cgi?id=107553
 605
 606         Reviewed by Jochen Eisinger.
 607
 608         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
 609         (WebKit):
 610         (WebTestProxyBase):
 611         (WebTestRunner::WebTestProxy::unableToImplementPolicyWithError):
 612         (WebTestRunner::WebTestProxy::didAddMessageToConsole):
 613         (WebTestRunner::WebTestProxy::runModalAlertDialog):
 614         (WebTestRunner::WebTestProxy::runModalConfirmDialog):
 615         (WebTestRunner::WebTestProxy::runModalPromptDialog):
 616         (WebTestRunner::WebTestProxy::runModalBeforeUnloadDialog):
 617         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
 618         (WebTestRunner::WebTestProxyBase::WebTestProxyBase):
 619         (WebTestRunner::WebTestProxyBase::reset):
 620         (WebTestRunner::WebTestProxyBase::setLogConsoleOutput):
 621         (WebTestRunner):
 622         (WebTestRunner::WebTestProxyBase::unableToImplementPolicyWithError):
 623         (WebTestRunner::WebTestProxyBase::didAddMessageToConsole):
 624         (WebTestRunner::WebTestProxyBase::runModalAlertDialog):
 625         (WebTestRunner::WebTestProxyBase::runModalConfirmDialog):
 626         (WebTestRunner::WebTestProxyBase::runModalPromptDialog):
 627         (WebTestRunner::WebTestProxyBase::runModalBeforeUnloadDialog):
 628         * DumpRenderTree/chromium/TestShell.cpp:
 629         (TestShell::showDevTools):
 630         * DumpRenderTree/chromium/WebViewHost.cpp:
 631         (WebViewHost::didAddMessageToConsole):
 632         (WebViewHost::runModalAlertDialog):
 633         (WebViewHost::runModalConfirmDialog):
 634         (WebViewHost::runModalPromptDialog):
 635         (WebViewHost::runModalBeforeUnloadDialog):
 636         (WebViewHost::unableToImplementPolicyWithError):
 637         (WebViewHost::reset):
 638         * DumpRenderTree/chromium/WebViewHost.h:
 639         (WebViewHost):
 640
 641 2013-01-23  Mark Pilgrim  <pilgrim@chromium.org>
 642
 643         [Chromium] Give webkit_support a chance to reset state between layout test runs
 644         https://bugs.webkit.org/show_bug.cgi?id=107132
 645
 646         Reviewed by Adam Barth.
 647
 648         We currently only have need for this on OS(ANDROID), but now it
 649         would be useful to have a hook for resetting state on all
 650         platforms. Will soon be using this for IDBFactory initialization.
 651
 652         * DumpRenderTree/chromium/TestShell.cpp:
 653         (TestShell::resetTestController): Call webkit_support::ResetTestEnvironment()
 654
 655 2013-01-23  Alan Cutter  <alancutter@chromium.org>
 656
 657         QueueStatusServer crashes in production on next-patch
 658         https://bugs.webkit.org/show_bug.cgi?id=107775
 659
 660         Reviewed by Adam Barth.
 661
 662         Replaced Python 2.5 incompatible call to timedelta.total_seconds().
 663
 664         * QueueStatusServer/app.yaml:
 665         * QueueStatusServer/model/patchlog.py:
 666         (PatchLog.calculate_wait_duration):
 667         (PatchLog.calculate_process_duration):
 668         (PatchLog):
 669         (PatchLog._time_delta_to_seconds):
 670
 671 2013-01-23  Ryosuke Niwa  <rniwa@webkit.org>
 672
 673         The previous patch wasn't complete. Finish reverting r139998 for real.
 674
 675         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
 676         (ProfilerAgent.getProfile):
 677
 678 2013-01-23  Ryosuke Niwa  <rniwa@webkit.org>
 679
 680         Revert r139998 for now since the Leaks Viewer pulls in a specific version of Inspector code.
 681
 682         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
 683         (ProfilerAgent.getProfile):
 684
 685 2013-01-23  Mark Pilgrim  <pilgrim@chromium.org>
 686
 687         [Chromium] Remove unused header files in chromium/public/platform/
 688         https://bugs.webkit.org/show_bug.cgi?id=107741
 689
 690         Reviewed by James Robinson.
 691
 692         These header files have migrated to the new Platform directory.
 693         This patch updates the remaining #include references and removes
 694         the old files that did nothing but redirect to the new ones.
 695
 696         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.cpp:
 697         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h:
 698
 699 2013-01-23  Martin Robinson  <mrobinson@igalia.com>
 700
 701         [GTK] Bump webkitgtk-test-fonts dependency to cover fallbacks for Tamil, Bengali, and others
 702         https://bugs.webkit.org/show_bug.cgi?id=107727
 703
 704         Reviewed by Gustavo Noronha Silva.
 705
 706         * gtk/jhbuild.modules: Update the JHBuild moduleset to point to the new webkitgtk-test-fonts.
 707         We are using the git repository now that github has deprecated the downloads feature.
 708
 709 2013-01-23  Tony Chang  <tony@chromium.org>
 710
 711         Unreviewed, set svn:eol-style to CRLF on Windows .sln files.
 712
 713         * CLWrapper/CLWrapper.sln: Modified property svn:eol-style.
 714         * DumpRenderTree/DumpRenderTree.sln: Modified property svn:eol-style.
 715         * MIDLWrapper/MIDLWrapper.sln: Modified property svn:eol-style.
 716         * WebKitTestRunner/WebKitTestRunner.sln: Modified property svn:eol-style.
 717
 718 2013-01-23  Mark Pilgrim  <pilgrim@chromium.org>
 719
 720         [Chromium] Update some #includes in DumpRenderTree for headers in the new Platform directory
 721         https://bugs.webkit.org/show_bug.cgi?id=107145
 722
 723         Reviewed by Adam Barth.
 724
 725         Part of a larger refactoring series; see tracking bug 82948.
 726
 727         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
 728         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
 729         * DumpRenderTree/chromium/DRTDevToolsClient.h:
 730         * DumpRenderTree/chromium/DRTTestRunner.cpp:
 731         * DumpRenderTree/chromium/DRTTestRunner.h:
 732         * DumpRenderTree/chromium/MockWebPrerenderingSupport.h:
 733         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
 734         * DumpRenderTree/chromium/MockWebSpeechInputController.h:
 735         * DumpRenderTree/chromium/NotificationPresenter.cpp:
 736         * DumpRenderTree/chromium/TestNavigationController.h:
 737         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.cpp:
 738         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
 739         * DumpRenderTree/chromium/TestRunner/src/CppBoundClass.cpp:
 740         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
 741         (WebTestRunner):
 742         * DumpRenderTree/chromium/TestRunner/src/EventSender.h:
 743         * DumpRenderTree/chromium/TestRunner/src/GamepadController.h:
 744         * DumpRenderTree/chromium/TestRunner/src/TestDelegate.h:
 745         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
 746         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
 747         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
 748         * DumpRenderTree/chromium/TestRunner/src/TextInputController.cpp:
 749         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.cpp:
 750         * DumpRenderTree/chromium/TestRunner/src/WebTestPlugin.cpp:
 751         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
 752         * DumpRenderTree/chromium/TestShell.cpp:
 753         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
 754         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
 755         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
 756         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h:
 757         * DumpRenderTree/chromium/WebViewHost.cpp:
 758
 759 2013-01-23  Jochen Eisinger  <jochen@chromium.org>
 760
 761         [chromium] Use after free in plugins/geturlnotify-during-document-teardown.html
 762         https://bugs.webkit.org/show_bug.cgi?id=107556
 763
 764         Reviewed by Tony Chang.
 765
 766         WebViewHost initiates a navigation to about:blank in its destructor.
 767         However, since WebTestProxy inherits from WebViewHost, at this point
 768         the WebViewClient and WebFrameClient interfaces are already partially
 769         destructed resulting in the use after free.
 770
 771         This does not affect the chromium implementation since it doesn't
 772         invoke WebKit API methods in its destructor.
 773
 774         * DumpRenderTree/chromium/TestShell.cpp:
 775         (TestShell::~TestShell):
 776         (TestShell::closeWindow):
 777         * DumpRenderTree/chromium/WebViewHost.cpp:
 778         (WebViewHost::WebViewHost):
 779         (WebViewHost::~WebViewHost):
 780         (WebViewHost::shutdown):
 781         * DumpRenderTree/chromium/WebViewHost.h:
 782         (WebViewHost):
 783
 784 2013-01-23  Andrei Bucur  <abucur@adobe.com>
 785
 786         [CSS Regions] Create Regions watchlist
 787         https://bugs.webkit.org/show_bug.cgi?id=107281
 788
 789         Reviewed by Adam Barth.
 790
 791         This patch adds 4 new definitions:
 792         - RegionsDevelopment - used to track the development progress for regions
 793         - RegionsExpectationsMore and RegionsExpectationsLess - used to track expectations changes for the regions tests
 794         - RegionsUsage - used to track changes that make use of regions in all the code base
 795
 796         For now, the Adobe internal tracker is the only email address listening for these patterns.
 797
 798         * Scripts/webkitpy/common/config/watchlist:
 799
 800 2013-01-22  Pavel Feldman  <pfeldman@chromium.org>
 801
 802         Web Inspector: only allow evaluateForTestInFrontend for front-ends under test.
 803         https://bugs.webkit.org/show_bug.cgi?id=107523
 804
 805         Reviewed by Yury Semikhatsky.
 806
 807         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
 808         (DRTDevToolsClient::isUnderTest):
 809         (DRTDevToolsClient::call):
 810         * DumpRenderTree/chromium/DRTDevToolsClient.h:
 811         (DRTDevToolsClient):
 812
 813 2013-01-23  Tim 'mithro' Ansell  <mithro@mithis.com>
 814
 815         Removing command line shortening as it makes it difficult to see the command during errors.
 816         https://bugs.webkit.org/show_bug.cgi?id=107643
 817
 818         Reviewed by Eric Seidel.
 819
 820         * Scripts/webkitpy/common/system/executive.py:
 821         (ScriptError):
 822         (ScriptError.__init__):
 823         * Scripts/webkitpy/common/system/executive_unittest.py:
 824
 825 2013-01-23  Tim 'mithro' Ansell  <mithro@mithis.com>
 826
 827         Adding myself as contributor in committers.py (as requested by eseidel).
 828         https://bugs.webkit.org/show_bug.cgi?id=107647
 829
 830         Reviewed by Eric Seidel.
 831
 832         * Scripts/webkitpy/common/config/committers.py:
 833
 834 2013-01-22  Alan Cutter  <alancutter@chromium.org>
 835
 836         Add monitoring of patches and queues to the QueueStatusServer
 837         https://bugs.webkit.org/show_bug.cgi?id=107612
 838
 839         Reviewed by Adam Barth.
 840
 841         Created classes for recording events into the datastore and integrated them into the existing handlers.
 842         Code for presenting the recorded data will come in a separate patch.
 843
 844         * QueueStatusServer/app.yaml:
 845         * QueueStatusServer/config/__init__.py: Added.
 846         * QueueStatusServer/config/logging.py: Copied from Tools/QueueStatusServer/model/queuestatus.py.
 847         * QueueStatusServer/config/messages.py: Copied from Tools/QueueStatusServer/model/queuestatus.py.
 848         * QueueStatusServer/handlers/nextpatch.py:
 849         (NextPatch.get):
 850         (NextPatch._assign_patch):
 851         * QueueStatusServer/handlers/releasepatch.py:
 852         (ReleasePatch.post):
 853         * QueueStatusServer/handlers/updatestatus.py:
 854         (UpdateStatus.post):
 855         * QueueStatusServer/handlers/updateworkitems.py:
 856         (UpdateWorkItems._parse_work_items_string):
 857         (UpdateWorkItems):
 858         (UpdateWorkItems._update_work_items_from_request):
 859         (UpdateWorkItems._queue_from_request):
 860         (UpdateWorkItems.post):
 861         * QueueStatusServer/loggers/__init__.py: Added.
 862         * QueueStatusServer/loggers/recordbotevent.py: Copied from Tools/QueueStatusServer/model/queuestatus.py.
 863         (RecordBotEvent):
 864         (RecordBotEvent.activity):
 865         * QueueStatusServer/loggers/recordpatchevent.py: Added.
 866         (RecordPatchEvent):
 867         (RecordPatchEvent.added):
 868         (RecordPatchEvent.retrying):
 869         (RecordPatchEvent.started):
 870         (RecordPatchEvent.stopped):
 871         (RecordPatchEvent.updated):
 872         (RecordPatchEvent._get_patches_waiting):
 873         * QueueStatusServer/model/patchlog.py: Copied from Tools/QueueStatusServer/model/queuestatus.py.
 874         (PatchLog):
 875         (PatchLog.lookup):
 876         (PatchLog.calculate_wait_duration):
 877         (PatchLog.calculate_process_duration):
 878         * QueueStatusServer/model/queuelog.py: Copied from Tools/QueueStatusServer/handlers/nextpatch.py.
 879         (QueueLog):
 880         (QueueLog.get_current):
 881         (QueueLog.create_key):
 882         * QueueStatusServer/model/queuestatus.py:
 883         (QueueStatus.is_retry_request):
 884
 885 2013-01-22  Timothy Loh  <timloh@chromium.com>
 886
 887         prepare-Changelog should support updating the list of changed files
 888         https://bugs.webkit.org/show_bug.cgi?id=74358
 889
 890         Reviewed by Eric Seidel.
 891
 892         Needing to re-make ChangeLog entries when the list of files/functions
 893         changes is a bit annoying, it'd be nice to have this more automated.
 894         This patch makes `webkit-patch update' update the date line and bug
 895         description if needed, and if the list of changed files/functions has
 896         changed, either updates the list (if there are no annotations), or
 897         otherwise appends the new list below.
 898
 899         * Scripts/webkitpy/tool/steps/preparechangelog.py:
 900         (PrepareChangeLog._resolve_existing_entry):
 901         (PrepareChangeLog):
 902         (PrepareChangeLog._merge_entries):
 903         (PrepareChangeLog.run):
 904         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
 905         (PrepareChangeLogTest.test_resolve_existing_entry):
 906         (make_entry):
 907         (test_ensure_bug_url):
 908
 909 2013-01-22  Tim 'mithro' Ansell  <mithro@mithis.com>
 910
 911         Use Python 2.7 unittest syntax in our unittests
 912         https://bugs.webkit.org/show_bug.cgi?id=105607
 913
 914         Reviewed by Eric Seidel.
 915
 916         * Scripts/webkitpy/**/*_unittest.py:
 917
 918 2013-01-22  Tim 'mithro' Ansell  <mithro@mithis.com>
 919
 920         Convert disable-msg to disable for new pylint.
 921         https://bugs.webkit.org/show_bug.cgi?id=107627
 922
 923         Reviewed by Eric Seidel.
 924
 925         * Scripts/webkitpy/common/checkout/scm/svn.py:
 926         (SVNRepository.has_authorization_for_realm):
 927         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
 928         (Builder.force_build):
 929         * Scripts/webkitpy/common/system/executive_mock.py:
 930         (MockExecutive2.run_command):
 931         * Scripts/webkitpy/layout_tests/port/base.py:
 932         (Port.reference_files):
 933         * Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:
 934         (ChromiumPortTestCase.test_default_configuration):
 935         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
 936         (PortTestCase.test_expectations_ordering):
 937         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
 938         (HttpServerBase._check_that_all_ports_are_available):
 939         * Scripts/webkitpy/tool/commands/abstractlocalservercommand.py:
 940         (AbstractLocalServerCommand.execute):
 941         * Scripts/webkitpy/tool/commands/download.py:
 942         (AbstractPatchProcessingCommand):
 943         * Scripts/webkitpy/tool/commands/rebaseline.py:
 944         (AbstractRebaseliningCommand):
 945         (AbstractParallelRebaselineCommand):
 946         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
 947         (_BaseTestCase.setUp):
 948         (TestAnalyzeBaselines.setUp):
 949
 950 2013-01-22  Frank Farzan  <frankf@chromium.org>
 951
 952         Flakiness dashboard: update builders.jsonp
 953         https://bugs.webkit.org/show_bug.cgi?id=107610
 954
 955         Reviewed by Ojan Vafai.
 956
 957         * TestResultServer/static-dashboards/builders.jsonp:
 958
 959 2013-01-22  Frank Farzan  <frankf@chromium.org>
 960
 961         Add Android instrumentation tests from ChromiumLinux waterfall
 962         https://bugs.webkit.org/show_bug.cgi?id=107597
 963
 964         Reviewed by Ojan Vafai.
 965
 966         * TestResultServer/static-dashboards/builders.js:
 967         (loadBuildersList):
 968
 969 2013-01-21  Kentaro Hara  <haraken@chromium.org>
 970
 971         Implement UIEvent constructor
 972         https://bugs.webkit.org/show_bug.cgi?id=107430
 973
 974         Reviewed by Adam Barth.
 975
 976         Editor's draft: https://dvcs.w3.org/hg/d4e/raw-file/tip/source_respec.htm
 977
 978         UIEvent constructor is implemented under a DOM4_EVENTS_CONSTRUCTOR flag,
 979         which is enabled on Safari and Chromium for now.
 980
 981         * Scripts/webkitperl/FeatureList.pm:
 982
 983 2013-01-22  Timothy Loh  <timloh@chromium.com>
 984
 985         Add functions to ChangeLog - parse bug desc/changed functions, delete/prepend entries
 986         https://bugs.webkit.org/show_bug.cgi?id=107478
 987
 988         Reviewed by Eric Seidel.
 989
 990         On the road to resolving Bug 74358, we need a few more functions in
 991         changelog.py.
 992         To make things easier to mock, change @staticmethods to @classmethods.
 993
 994         * Scripts/webkitpy/common/checkout/changelog.py:
 995         (ChangeLogEntry):
 996         (ChangeLogEntry._parse_reviewer_text):
 997         (ChangeLogEntry._split_contributor_names):
 998         (ChangeLogEntry._parse_author_name_and_email):
 999         (ChangeLogEntry._parse_author_text):
1000         (ChangeLogEntry._parse_touched_functions):
1001         (ChangeLogEntry._parse_bug_description):
1002         (ChangeLogEntry._parse_entry):
1003         (ChangeLogEntry.date_line):
1004         (ChangeLogEntry.bug_description):
1005         (ChangeLogEntry.touched_functions):
1006         (ChangeLogEntry.touched_files_text):
1007         (ChangeLogEntry.is_touched_files_text_clean):
1008         (ChangeLog):
1009         (ChangeLog.parse_latest_entry_from_file):
1010         (ChangeLog._separate_revision_and_line):
1011         (ChangeLog.parse_entries_from_file):
1012         (ChangeLog.set_short_description_and_bug_url):
1013         (ChangeLog.delete_entries):
1014         (ChangeLog.prepend_text):
1015         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1016         (test_parse_log_entries_from_changelog):
1017         (test_latest_entry_parse):
1018         (test_set_short_description_and_bug_url):
1019         (test_delete_entries):
1020         (test_prepend_text):
1021
1022 2013-01-22  Lucas Forschler  <lforschler@apple.com>
1023
1024         Create a MAC EWS startup shell script.
1025
1026         Reviewed by Ryosuke Niwa.
1027
1028         * EWSTools/start-queue-mac.sh: Added.
1029
1030 2013-01-22  Joseph Pecoraro  <pecoraro@apple.com>
1031
1032         [Mac] Enable Page Visibility (PAGE_VISIBILITY_API)
1033         https://bugs.webkit.org/show_bug.cgi?id=107230
1034
1035         Reviewed by David Kilzer.
1036
1037         * DumpRenderTree/mac/TestRunnerMac.mm:
1038         (TestRunner::resetPageVisibility):
1039         Fix a typo in the original implementation. resetPageVisibility should
1040         pass initialState YES so an event is not dispatched, which causes
1041         issues in multiple tests. This now matches other ports.
1042
1043 2013-01-22  Zan Dobersek  <zandobersek@gmail.com>
1044
1045         [GTK] Enable CSS Image Orientation feature
1046         https://bugs.webkit.org/show_bug.cgi?id=99040
1047
1048         Reviewed by Martin Robinson.
1049
1050         Enable the CSS Image Orientation feature in the development
1051         builds of the GTK port. The feature is still disabled in the release
1052         builds.
1053
1054         * Scripts/webkitperl/FeatureList.pm:
1055
1056 2013-01-22  Zan Dobersek  <zandobersek@gmail.com>
1057
1058         [GTK] Enable the <template> element support in development builds
1059         https://bugs.webkit.org/show_bug.cgi?id=106575
1060
1061         Reviewed by Martin Robinson.
1062
1063         Enable the <template> element support in the development builds of the GTK port.
1064
1065         * Scripts/webkitperl/FeatureList.pm:
1066
1067 2013-01-22  Zan Dobersek  <zandobersek@gmail.com>
1068
1069         Prettify the output of the override-feature-defines script
1070         https://bugs.webkit.org/show_bug.cgi?id=106542
1071
1072         Reviewed by Martin Robinson.
1073
1074         The output now clearly lists the feature defines being overridden
1075         along with the default and overriding values for each feature define.
1076
1077         * gtk/override-feature-defines:
1078         (adjust_feature_defines_makefile):
1079         (adjust_feature_defines_makefile.override_feature_define):
1080
1081 2013-01-22  Zan Dobersek  <zdobersek@igalia.com>
1082
1083         Remove uses of deprecated unittest.TestCase aliases
1084         https://bugs.webkit.org/show_bug.cgi?id=102252
1085
1086         Reviewed by Adam Barth.
1087
1088         Replace the deprecated assertEquals method of the TestCase interface
1089         used in some webkitpy unittests with the assertEqual method.
1090
1091         * Scripts/webkitpy/common/system/profiler_unittest.py:
1092         (ProfilerFactoryTest._assert_default_profiler_name):
1093         (ProfilerFactoryTest.test_default_profiler_output):
1094         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
1095         (GtkPortTest.test_expectations_files):
1096         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
1097         (TestHttpServer.test_win32_start_and_stop):
1098
1099 2013-01-22  Jer Noble  <jer.noble@apple.com>
1100
1101         REGRESSION(r140344): Repeated crashes in WKTR PlatformWebView::viewSupportsOptions().
1102         https://bugs.webkit.org/show_bug.cgi?id=107562
1103
1104         Rubber-stamped by Alexy Proskuryakov.
1105
1106         The input to WKBooleanGetValue() is not NULL-safe, so NULL check its inputs before calling.
1107
1108         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1109         (WTR::PlatformWebView::PlatformWebView):
1110         (WTR::PlatformWebView::viewSupportsOptions):
1111
1112 2013-01-22  Alexey Proskuryakov  <ap@apple.com>
1113
1114         One is not allowed to use commit-queue to make oneself a committer.
1115
1116         * Scripts/webkitpy/common/config/committers.py: Removing eustas@chromium.org.
1117
1118 2013-01-22  Eugene Klyuchnikov  <eustas@chromium.org>
1119
1120         Add myself to commiters.py
1121         https://bugs.webkit.org/show_bug.cgi?id=107546
1122
1123         Reviewed by Kentaro Hara.
1124
1125         * Scripts/webkitpy/common/config/committers.py:
1126
1127 2013-01-22  Manuel Rego Casasnovas  <rego@igalia.com>
1128
1129         [GTK] Implement TestRunner::setTextDirection
1130         https://bugs.webkit.org/show_bug.cgi?id=107131
1131
1132         Reviewed by Philippe Normand.
1133
1134         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1135         (resetDefaultsToConsistentValues): Reset direction to default value.
1136         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
1137         (TestRunner::setTextDirection): Implement method using
1138         gtk_widget_set_direction.
1139
1140 2013-01-22  Jochen Eisinger  <jochen@chromium.org>
1141
1142         [chromium] move spell checking mocks to TestRunner library
1143         https://bugs.webkit.org/show_bug.cgi?id=107455
1144
1145         Reviewed by Kent Tamura.
1146
1147         The content module doesn't provide its own WebSpellCheckClient.
1148
1149         * DumpRenderTree/DumpRenderTree.gypi:
1150         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1151         (WebTestRunner::WebTestDelegate::fillSpellingSuggestionList):
1152         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
1153         (WebKit):
1154         (WebTestRunner):
1155         (WebTestProxyBase):
1156         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
1157         (WebTestRunner):
1158         (WebTestRunner::makeMenuItemStringsFor):
1159         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.cpp: Renamed from Tools/DumpRenderTree/chromium/MockGrammarCheck.cpp.
1160         (MockGrammarCheck::checkGrammarOfString):
1161         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.h: Renamed from Tools/DumpRenderTree/chromium/MockGrammarCheck.h.
1162         (WebKit):
1163         (MockGrammarCheck):
1164         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp: Renamed from Tools/DumpRenderTree/chromium/MockSpellCheck.cpp.
1165         (MockSpellCheck::MockSpellCheck):
1166         (MockSpellCheck::~MockSpellCheck):
1167         (isNotASCIIAlpha):
1168         (MockSpellCheck::spellCheckWord):
1169         (MockSpellCheck::fillSuggestionList):
1170         (MockSpellCheck::initializeIfNeeded):
1171         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h: Renamed from Tools/DumpRenderTree/chromium/MockSpellCheck.h.
1172         (MockSpellCheck):
1173         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.cpp: Added.
1174         (WebTestRunner::SpellCheckClient::SpellCheckClient):
1175         (WebTestRunner):
1176         (WebTestRunner::SpellCheckClient::~SpellCheckClient):
1177         (WebTestRunner::SpellCheckClient::setDelegate):
1178         (WebTestRunner::SpellCheckClient::spellCheck):
1179         (WebTestRunner::SpellCheckClient::checkTextOfParagraph):
1180         (WebTestRunner::SpellCheckClient::requestCheckingOfText):
1181         (WebTestRunner::SpellCheckClient::finishLastTextCheck):
1182         (WebTestRunner::SpellCheckClient::autoCorrectWord):
1183         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/TestDelegate.h.
1184         (WebTestRunner):
1185         (SpellCheckClient):
1186         (WebTestRunner::SpellCheckClient::taskList):
1187         (WebTestRunner::SpellCheckClient::mockSpellCheck):
1188         * DumpRenderTree/chromium/TestRunner/src/TestDelegate.h:
1189         (TestDelegate):
1190         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
1191         (WebTestInterfaces::Internal):
1192         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
1193         (WebTestRunner::WebTestProxyBase::WebTestProxyBase):
1194         (WebTestRunner::WebTestProxyBase::~WebTestProxyBase):
1195         (WebTestRunner::WebTestProxyBase::setDelegate):
1196         (WebTestRunner::WebTestProxyBase::spellCheckClient):
1197         (WebTestRunner):
1198         * DumpRenderTree/chromium/WebViewHost.cpp:
1199         (WebViewHost::WebViewHost):
1200         (WebViewHost::setWebWidget):
1201         * DumpRenderTree/chromium/WebViewHost.h:
1202         (WebViewHost):
1203
1204 2013-01-22  Krzysztof Czech  <k.czech@samsung.com>
1205
1206         [EFL] Adds Accessibility support to wk1
1207         https://bugs.webkit.org/show_bug.cgi?id=107440
1208
1209         Reviewed by Gyuyoung Kim.
1210
1211         * DumpRenderTree/efl/CMakeLists.txt: Adds ATK headers and libraries.
1212
1213 2013-01-21  Joseph Pecoraro  <pecoraro@apple.com>
1214
1215         [Mac] WK1 MiniBrowser should clear delegates before releasing webview
1216         https://bugs.webkit.org/show_bug.cgi?id=107506
1217
1218         Reviewed by Dan Bernstein.
1219
1220         * MiniBrowser/mac/WK1BrowserWindowController.m:
1221         (-[WK1BrowserWindowController dealloc]):
1222
1223 2013-01-21  Dirk Schulze  <dschulze@adobe.com>
1224
1225         Add build flag for Canvas's Path object (disabled by default)
1226         https://bugs.webkit.org/show_bug.cgi?id=107473
1227
1228         Reviewed by Dean Jackson.
1229
1230         Add CANVAS_PATH build flag to build systems.
1231
1232         * Scripts/webkitperl/FeatureList.pm:
1233
1234 2013-01-21  Jinwoo Song  <jinwoo7.song@samsung.com>
1235
1236         [EFL][WK2] Add APIs to set/get view source mode
1237         https://bugs.webkit.org/show_bug.cgi?id=106633
1238
1239         Reviewed by Gyuyoung Kim.
1240
1241         Added a shotcut 'F8' in Minibrowser to display a source code
1242         of the web page in a new window.
1243
1244        * MiniBrowser/efl/main.c:
1245         (on_key_down):
1246         (on_window_create):
1247         (window_create):
1248         (elm_main):
1249
1250 2013-01-21  Nico Weber  <thakis@chromium.org>
1251
1252         [chromium] Don't archive generated source files.
1253         https://bugs.webkit.org/show_bug.cgi?id=106736
1254
1255         Reviewed by Eric Seidel.
1256
1257         They shouldn't be needed to run tests. They don't need a lot of space,
1258         but add many lines to the "extracting" stdout. This attempts to reduce
1259         that noise a bit.
1260
1261         * BuildSlaveSupport/built-product-archive:
1262         (archiveBuiltProduct):
1263
1264 2013-01-21  Benjamin Poulain  <benjamin@webkit.org>
1265
1266         Mac DumpRenderTree's installSignalHandlers() is unreachable code
1267         https://bugs.webkit.org/show_bug.cgi?id=107383
1268
1269         Reviewed by Sam Weinig.
1270
1271         The CrashHandler of DumpRenderTree were originally used for restoring
1272         the color profile of the main display even if DRT crashes.
1273
1274         That feature was later limited to pixel tests only in r29999.
1275
1276         In r104351, the DRT was changed to use device color space. Making the crash
1277         handlers useless, but they were left in the code since the error reporting
1278         code was still reachable.
1279
1280         Later, r124581 refactored the code and dumpPixelsForCurrentTest
1281         is being used before being assigned its value.
1282         This did cause any regression because the code had become useless with the previous change.
1283
1284         * DumpRenderTree/mac/DumpRenderTree.mm:
1285         Remove crashHandler() and installSignalHandlers() as they have become useless and
1286         have been unreachable code for 6 months.
1287         (dumpRenderTree):
1288         Remove the code that was unreachable due to dumpPixelsForCurrentTest being always false
1289         at those points.
1290
1291 2013-01-21  Nico Weber  <thakis@chromium.org>
1292
1293         Make ninja the default build system for build-webkit --chromium on mac
1294         https://bugs.webkit.org/show_bug.cgi?id=106737
1295
1296         Reviewed by Eric Seidel.
1297
1298         * Scripts/update-webkit-chromium:
1299
1300 2013-01-21  Christophe Dumez  <christophe.dumez@intel.com>
1301
1302         Regression(r140262): Causes a lot of flakiness
1303         https://bugs.webkit.org/show_bug.cgi?id=107454
1304
1305         Reviewed by Alexey Proskuryakov.
1306
1307         r140262 introduced a lot of flakiness due to fixed layout mode
1308         not getting disabled on the view after being enabled for
1309         specific test cases. This patch makes sure fixed layout mode
1310         properly gets reset in WebKitTestRunner to avoid flakiness.
1311
1312         * WebKitTestRunner/TestInvocation.cpp:
1313         (WTR::updateLayoutType):
1314
1315 2013-01-21  Gustavo Noronha Silva  <gns@gnome.org>
1316
1317         REGRESSION (r140285): GTK uses WKPageResourceLoadClient which was removed
1318         https://bugs.webkit.org/show_bug.cgi?id=107421
1319
1320         Unreviewed build fix.
1321
1322         * Scripts/run-gtk-tests:
1323         (TestRunner): skip Resource tests.
1324
1325 2013-01-21  Christophe Dumez  <christophe.dumez@intel.com>
1326
1327         [EFL][WKTR] platformRunUntil() should keep the main loop running
1328         https://bugs.webkit.org/show_bug.cgi?id=107442
1329
1330         Reviewed by Noam Rosenthal.
1331
1332         EFL's implementation of platformRunUntil() should keep the main loop
1333         running and avoid calling sleep() between calls to
1334         ecore_main_loop_iterate(). This call to sleep seems to be a source
1335         of deadlocks (see Bug 106884).
1336
1337         * WebKitTestRunner/efl/TestControllerEfl.cpp:
1338         (WTR::TestController::platformRunUntil):
1339
1340 2013-01-21  Vivek Galatage  <vivek.vg@samsung.com>
1341
1342         QtTestBrowser should provide way to clear selected elements
1343         https://bugs.webkit.org/show_bug.cgi?id=107437
1344
1345         Reviewed by Simon Hausmann.
1346
1347         Provide a way to "Clear selection" in the "Develop" menu to clear the previous search highlight.
1348         Invoke the clearSelection prior to highlighting new elements.
1349
1350         * QtTestBrowser/launcherwindow.cpp:
1351         (ElementHighlight):
1352         (LauncherWindow::createChrome):
1353         (LauncherWindow::selectElements):
1354         (LauncherWindow::clearSelection):
1355         * QtTestBrowser/launcherwindow.h:
1356         (LauncherWindow):
1357
1358 2013-01-21  Jochen Eisinger  <jochen@chromium.org>
1359
1360         [chromium] move methods interacting with willSendRequest to TestRunner
1361         https://bugs.webkit.org/show_bug.cgi?id=107270
1362
1363         Reviewed by Kent Tamura.
1364
1365         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1366         (DRTTestRunner::DRTTestRunner):
1367         (DRTTestRunner::waitForPolicyDelegate):
1368         * DumpRenderTree/chromium/DRTTestRunner.h:
1369         (DRTTestRunner):
1370         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
1371         (WebTestRunner::WebTestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
1372         (WebTestRunner::WebTestRunner::httpHeadersToClear):
1373         (WebTestRunner::WebTestRunner::shouldBlockRedirects):
1374         (WebTestRunner::WebTestRunner::willSendRequestShouldReturnNull):
1375         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1376         (WebTestRunner::TestRunner::TestRunner):
1377         (WebTestRunner::TestRunner::reset):
1378         (WebTestRunner::TestRunner::httpHeadersToClear):
1379         (WebTestRunner):
1380         (WebTestRunner::TestRunner::shouldBlockRedirects):
1381         (WebTestRunner::TestRunner::willSendRequestShouldReturnNull):
1382         (WebTestRunner::TestRunner::setWillSendRequestClearHeader):
1383         (WebTestRunner::TestRunner::setWillSendRequestReturnsNullOnRedirect):
1384         (WebTestRunner::TestRunner::setWillSendRequestReturnsNull):
1385         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1386         (TestRunner):
1387         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
1388         (WebTestRunner::WebTestProxyBase::willSendRequest):
1389         * DumpRenderTree/chromium/WebViewHost.cpp:
1390         (WebViewHost::willSendRequest):
1391         (WebViewHost::reset):
1392         * DumpRenderTree/chromium/WebViewHost.h:
1393         (WebViewHost):
1394
1395 2013-01-21  Zan Dobersek  <zdobersek@igalia.com>
1396
1397         [GTK] Stop building WebKit2 on GTK EWSs
1398         https://bugs.webkit.org/show_bug.cgi?id=107435
1399
1400         Reviewed by Philippe Normand.
1401
1402         The WebKit2 build of the GTK is at the moment not efficiently maintainable,
1403         so stop building it on GTK EWSs.
1404
1405         * Scripts/webkitpy/common/config/ports.py:
1406         (GtkPort.build_webkit_command):
1407         * Scripts/webkitpy/common/config/ports_unittest.py:
1408         (DeprecatedPortTest.test_gtk_port):
1409
1410 2013-01-21  Tommy Widenflycht  <tommyw@google.com>
1411
1412         MediaStream API: Update the RTCPeerConnection states to match the latest specification
1413         https://bugs.webkit.org/show_bug.cgi?id=107120
1414
1415         Reviewed by Adam Barth.
1416
1417         Updating mock to use the new states.
1418
1419         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
1420         (RTCPeerConnectionStateTask::RTCPeerConnectionStateTask):
1421         (MockWebRTCPeerConnectionHandler::initialize):
1422         (MockWebRTCPeerConnectionHandler::updateICE):
1423
1424 2013-01-20  Tim 'mithro' Ansell  <mithro@mithis.com>
1425
1426         Extend diff_parser to support the --full-index output.
1427         https://bugs.webkit.org/show_bug.cgi?id=107408
1428
1429         Reviewed by Maciej Stachowiak.
1430
1431         * Scripts/webkitpy/common/checkout/diff_parser.py:
1432         (git_diff_to_svn_diff):
1433         * Scripts/webkitpy/common/checkout/diff_parser_unittest.py:
1434         (DiffParserTest):
1435         (DiffParserTest.test_git_diff_to_svn_diff):
1436         (git_diff_to_svn_diff):
1437
1438 2013-01-20  Yoshifumi Inoue  <yosin@chromium.org>
1439
1440         Dragging over an element with scrollbars should scroll the element when dragging near edges
1441         https://bugs.webkit.org/show_bug.cgi?id=39725
1442
1443         Reviewed by Hajime Morita.
1444
1445         This patch introduces canceling drag-and-drop by escape key for testing
1446         behavior after cancellation drag-and-drop.
1447
1448         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
1449         (WebTestRunner):
1450         (WebTestRunner::EventSender::doMouseUp):
1451         (WebTestRunner::EventSender::finishDragAndDrop):
1452         (WebTestRunner::EventSender::keyDown):
1453         * DumpRenderTree/chromium/TestRunner/src/EventSender.h:
1454         (EventSender):
1455         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.h: Added VKEY_ESCAPE.
1456
1457 2013-01-20  Jochen Eisinger  <jochen@chromium.org>
1458
1459         [chromium] move frame generation related methods to TestRunner
1460         https://bugs.webkit.org/show_bug.cgi?id=107268
1461
1462         Reviewed by Adam Barth.
1463
1464         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1465         (DRTTestRunner::DRTTestRunner):
1466         (DRTTestRunner::setWillSendRequestReturnsNull):
1467         * DumpRenderTree/chromium/DRTTestRunner.h:
1468         (DRTTestRunner):
1469         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1470         (WebTestRunner::WebTestDelegate::display):
1471         (WebTestRunner::WebTestDelegate::displayInvalidatedRegion):
1472         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1473         (WebTestRunner::TestRunner::TestRunner):
1474         (WebTestRunner::TestRunner::display):
1475         (WebTestRunner):
1476         (WebTestRunner::TestRunner::displayInvalidatedRegion):
1477         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1478         (TestRunner):
1479         * DumpRenderTree/chromium/WebViewHost.cpp:
1480         (WebViewHost::display):
1481         (WebViewHost::displayInvalidatedRegion):
1482         * DumpRenderTree/chromium/WebViewHost.h:
1483
1484 2013-01-20  Jochen Eisinger  <jochen@chromium.org>
1485
1486         [chromium] move speech related methods to TestRunner library
1487         https://bugs.webkit.org/show_bug.cgi?id=107266
1488
1489         Reviewed by Adam Barth.
1490
1491         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1492         (DRTTestRunner::DRTTestRunner):
1493         (DRTTestRunner::displayInvalidatedRegion):
1494         * DumpRenderTree/chromium/DRTTestRunner.h:
1495         (DRTTestRunner):
1496         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1497         (WebTestDelegate):
1498         (WebTestRunner::WebTestDelegate::addMockSpeechInputResult):
1499         (WebTestRunner::WebTestDelegate::setMockSpeechInputDumpRect):
1500         (WebTestRunner::WebTestDelegate::addMockSpeechRecognitionResult):
1501         (WebTestRunner::WebTestDelegate::setMockSpeechRecognitionError):
1502         (WebTestRunner::WebTestDelegate::wasMockSpeechRecognitionAborted):
1503         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1504         (WebTestRunner::TestRunner::TestRunner):
1505         (WebTestRunner):
1506         (WebTestRunner::TestRunner::addMockSpeechInputResult):
1507         (WebTestRunner::TestRunner::setMockSpeechInputDumpRect):
1508         (WebTestRunner::TestRunner::addMockSpeechRecognitionResult):
1509         (WebTestRunner::TestRunner::setMockSpeechRecognitionError):
1510         (WebTestRunner::TestRunner::wasMockSpeechRecognitionAborted):
1511         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1512         (TestRunner):
1513         * DumpRenderTree/chromium/WebViewHost.cpp:
1514         (WebViewHost::addMockSpeechInputResult):
1515         (WebViewHost::setMockSpeechInputDumpRect):
1516         (WebViewHost::addMockSpeechRecognitionResult):
1517         (WebViewHost::setMockSpeechRecognitionError):
1518         (WebViewHost::wasMockSpeechRecognitionAborted):
1519         * DumpRenderTree/chromium/WebViewHost.h:
1520
1521 2013-01-20  Jochen Eisinger  <jochen@chromium.org>
1522
1523         [chromium] move notification related methods to TestRunner
1524         https://bugs.webkit.org/show_bug.cgi?id=107269
1525
1526         Reviewed by Adam Barth.
1527
1528         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1529         (DRTTestRunner::DRTTestRunner):
1530         * DumpRenderTree/chromium/DRTTestRunner.h:
1531         (DRTTestRunner):
1532         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1533         (WebTestDelegate):
1534         (WebTestRunner::WebTestDelegate::grantWebNotificationPermission):
1535         (WebTestRunner::WebTestDelegate::simulateLegacyWebNotificationClick):
1536         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1537         (WebTestRunner::TestRunner::TestRunner):
1538         (WebTestRunner):
1539         (WebTestRunner::TestRunner::grantWebNotificationPermission):
1540         (WebTestRunner::TestRunner::simulateLegacyWebNotificationClick):
1541         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1542         (TestRunner):
1543         * DumpRenderTree/chromium/WebViewHost.cpp:
1544         (WebViewHost::grantWebNotificationPermission):
1545         (WebViewHost::simulateLegacyWebNotificationClick):
1546         * DumpRenderTree/chromium/WebViewHost.h:
1547
1548 2013-01-20  Jochen Eisinger  <jochen@chromium.org>
1549
1550         [chromium] move geolocation related methods to TestRunner
1551         https://bugs.webkit.org/show_bug.cgi?id=107267
1552
1553         Reviewed by Adam Barth.
1554
1555         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1556         (DRTTestRunner::DRTTestRunner):
1557         * DumpRenderTree/chromium/DRTTestRunner.h:
1558         (DRTTestRunner):
1559         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1560         (WebTestRunner::WebTestDelegate::numberOfPendingGeolocationPermissionRequests):
1561         (WebTestRunner::WebTestDelegate::setGeolocationPermission):
1562         (WebTestRunner::WebTestDelegate::setMockGeolocationPosition):
1563         (WebTestRunner::WebTestDelegate::setMockGeolocationPositionUnavailableError):
1564         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1565         (WebTestRunner::TestRunner::TestRunner):
1566         (WebTestRunner::TestRunner::numberOfPendingGeolocationPermissionRequests):
1567         (WebTestRunner):
1568         (WebTestRunner::TestRunner::setGeolocationPermission):
1569         (WebTestRunner::TestRunner::setMockGeolocationPosition):
1570         (WebTestRunner::TestRunner::setMockGeolocationPositionUnavailableError):
1571         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1572         (TestRunner):
1573         * DumpRenderTree/chromium/WebViewHost.cpp:
1574         (WebViewHost::numberOfPendingGeolocationPermissionRequests):
1575         (WebViewHost::setGeolocationPermission):
1576         (WebViewHost::setMockGeolocationPosition):
1577         (WebViewHost::setMockGeolocationPositionUnavailableError):
1578         * DumpRenderTree/chromium/WebViewHost.h:
1579
1580 2013-01-19  Zan Dobersek  <zdobersek@igalia.com>
1581
1582         Unreviewed build fix for Qt WK2 after r140258.
1583         Use the size_t type instead of unsigned for the variable
1584         which holds the position of the first null character in the
1585         console message.
1586
1587         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1588         (WTR::InjectedBundlePage::willAddMessageToConsole):
1589
1590 2013-01-19  Sheriff Bot  <webkit.review.bot@gmail.com>
1591
1592         Unreviewed, rolling out r140260.
1593         http://trac.webkit.org/changeset/140260
1594         https://bugs.webkit.org/show_bug.cgi?id=107387
1595
1596         breaks fast/text/hyphens.html, fast/text/hyphenate-* (but
1597         nothing else) (Requested by thakis__ on #webkit).
1598
1599         * Scripts/update-webkit-chromium:
1600
1601 2013-01-19  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1602
1603         Delegated scrolling: Assertion on attempt to show a CSS sticky element
1604         https://bugs.webkit.org/show_bug.cgi?id=106890
1605
1606         Reviewed by Kenneth Rohde Christiansen.
1607
1608         Enabled fixed layout mode in WTR for 'fast/css/sticky' tests.
1609
1610         * WebKitTestRunner/TestInvocation.cpp:
1611         (WTR::shouldUseFixedLayout):
1612         (WTR):
1613         (WTR::updateLayoutType):
1614
1615 2013-01-19  Nico Weber  <thakis@chromium.org>
1616
1617         Make ninja the default build system for build-webkit --chromium on mac
1618         https://bugs.webkit.org/show_bug.cgi?id=106737
1619
1620         Reviewed by Eric Seidel.
1621
1622         * Scripts/update-webkit-chromium:
1623
1624 2013-01-19  Zan Dobersek  <zdobersek@igalia.com>
1625
1626         [WK2] svg/dom/fuzz-path-parser.html is failing
1627         https://bugs.webkit.org/show_bug.cgi?id=107133
1628
1629         Reviewed by Alexey Proskuryakov.
1630
1631         Console messages can contain null characters before the end of string.
1632         Appending such message to the StringBuilder as a WTFString appends the
1633         complete string, including the null character. This later cuts off everything
1634         after the null character when the string is being printed out to the test
1635         output.
1636
1637         To avoid this, truncate the string up to the first null character. This
1638         preserves the newline character appended immediately after this and
1639         stops giving incorrect output.
1640
1641         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1642         (WTR::InjectedBundlePage::willAddMessageToConsole):
1643
1644 2013-01-19  Eric Seidel  <eric@webkit.org>
1645
1646         Update error regexps so that Parser/html-parser-srcdoc.html can "pass"
1647         https://bugs.webkit.org/show_bug.cgi?id=107367
1648
1649         Reviewed by Ryosuke Niwa.
1650
1651         Using srcdoc instead of document.write changes the error output
1652         ever so slightly.  Clearly we were already trying to ignore these
1653         messages, just not succeeding.  This change makes this new test "pass" correctly.
1654
1655         * Scripts/webkitpy/performance_tests/perftest.py:
1656         (PerfTest):
1657
1658 2013-01-18  Dan Winship  <danw@gnome.org>
1659
1660         REGRESSION (r139071): run-webkit-httpd complains at launch
1661         https://bugs.webkit.org/show_bug.cgi?id=107310
1662
1663         Reviewed by Alexey Proskuryakov.
1664
1665         * Scripts/webkitperl/httpd.pm:
1666         (getApacheVersion): use preferred perl syntax
1667
1668 2013-01-18  Julie Parent  <jparent@chromium.org>
1669
1670         Add back 'group' as a default cross dashboard parameter, but with null as its value.
1671         https://bugs.webkit.org/show_bug.cgi?id=107336
1672
1673         We need to have 'group' listed as a parameter, else we never parse it,
1674         as we only parse parameters with defaults.
1675
1676         Reviewed by Ojan Vafai.
1677
1678         * TestResultServer/static-dashboards/dashboard_base.js:
1679
1680 2013-01-18  Emil A Eklund  <eae@chromium.org>
1681
1682         Update LayoutUnit rounding unit test
1683         https://bugs.webkit.org/show_bug.cgi?id=107322
1684
1685         Reviewed by Levi Weintraub.
1686
1687         Update the LayoutUnitRounding test to use fromFloatRound for
1688         values that cannot accurately be represented as a LayoutUnit
1689         (the default behavior is to floor the value to the nearest
1690         LayoutUnit).
1691
1692         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
1693         (TestWebKitAPI::TEST):
1694
1695 2013-01-18  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1696
1697         VCSUtils.pm: Stop calling git repo-config.
1698         https://bugs.webkit.org/show_bug.cgi?id=107294
1699
1700         Reviewed by Dirk Pranke.
1701
1702         The `repo-config' git command has been deprecated since early
1703         2008, and recent versions have started warning it is deprecated.
1704
1705         Basically revert r27870 and use the `config' command all the time.
1706
1707         * Scripts/VCSUtils.pm:
1708         (gitConfig):
1709
1710 2013-01-18  Levi Weintraub  <leviw@chromium.org>
1711
1712         LayoutUnit should round half consistently, not away from zero
1713         https://bugs.webkit.org/show_bug.cgi?id=107208
1714
1715         Reviewed by Eric Seidel.
1716
1717         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp: Updating to reflect and
1718         cover this change in rounding behavior.
1719
1720 2013-01-18  Tim Horton  <timothy_horton@apple.com>
1721
1722         [mac] DumpRenderTree/WebKitTestRunner should not participate in Exposé/Mission Control
1723         https://bugs.webkit.org/show_bug.cgi?id=107234
1724
1725         Reviewed by Simon Fraser.
1726
1727         * DumpRenderTree/mac/DumpRenderTree.mm:
1728         (createWebViewAndOffscreenWindow): Disable participation in Exposé via NSWindowCollectionBehaviorStationary.
1729         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1730         (WTR::PlatformWebView::PlatformWebView): Ditto.
1731
1732 2013-01-18  Tim Horton  <timothy_horton@apple.com>
1733
1734         [mac] DumpRenderTree/WebKitTestRunner should disable NSBeep
1735         https://bugs.webkit.org/show_bug.cgi?id=107251
1736
1737         Reviewed by Simon Fraser.
1738
1739         Disable NSBeep in DumpRenderTree and WebKitTestRunner using NSSound SPI.
1740
1741         * DumpRenderTree/mac/DumpRenderTree.mm:
1742         (dumpRenderTree):
1743         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
1744         (WTR::InjectedBundle::platformInitialize):
1745
1746 2013-01-18  Martin Robinson  <mrobinson@igalia.com>
1747
1748         [GTK] Enable indexed database for development builds
1749         https://bugs.webkit.org/show_bug.cgi?id=107299
1750
1751         Reviewed by Gustavo Noronha Silva.
1752
1753         * Scripts/webkitperl/FeatureList.pm: Enable indexed database by default
1754         for GTK+ development builds.
1755
1756 2013-01-18  Dominic Mazzoni  <dmazzoni@google.com>
1757
1758         AX: Improve table-guessing heuristics
1759         https://bugs.webkit.org/show_bug.cgi?id=107042
1760
1761         Reviewed by Chris Fleizach.
1762
1763         Implement parentElementCallback on Chromium to make testing easier.
1764
1765         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
1766         (WebTestRunner::AccessibilityUIElement::parentElementCallback):
1767
1768 2013-01-18  Martin Robinson  <mrobinson@igalia.com>
1769
1770         [GTK] Add property for IndexedDB database path to WebKitGTK+
1771         https://bugs.webkit.org/show_bug.cgi?id=106136
1772
1773         Reviewed by Gustavo Noronha Silva.
1774
1775         During testing, set the web database directory to DUMPRENDERTREE_TEMP
1776         before falling back to the old default. This is necessary because
1777         indexed database tests require that each DRT shard is using a different
1778         IDB database location.
1779
1780         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1781         (temporaryDatabaseDirectory): Added this helper for getting the
1782         database directory.
1783         (setDefaultsToConsistentStateValuesForTesting): Use the new helper.
1784
1785 2013-01-18  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
1786
1787         [EFL][WK2] Enable API test InjectedBundleFrameHitTest on EFL
1788         https://bugs.webkit.org/show_bug.cgi?id=107264
1789
1790         Reviewed by Laszlo Gombos.
1791
1792         Enable API test InjectedBundleFrameHitTest for hit-testing,
1793         since it is now passing on both Debug and Release builds.
1794
1795         * TestWebKitAPI/CMakeLists.txt:
1796         * TestWebKitAPI/PlatformEfl.cmake:
1797
1798 2013-01-18  Manuel Rego Casasnovas  <rego@igalia.com>
1799
1800         [GTK] Implement TestRunner::addUserScript
1801         https://bugs.webkit.org/show_bug.cgi?id=107275
1802
1803         Reviewed by Philippe Normand.
1804
1805         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
1806         (TestRunner::addUserScript): Implement method using
1807         DumpRenderTreeSupportGtk::addUserScript.
1808
1809 2013-01-18  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
1810
1811         Unreviewed, add my secondary email address to the list.
1812
1813         * Scripts/webkitpy/common/config/committers.py:
1814
1815 2013-01-18  Dan Carney  <dcarney@google.com>
1816
1817         [chromium] move pointerlock functions to TestRunner library
1818         https://bugs.webkit.org/show_bug.cgi?id=107241
1819
1820         Reviewed by Jochen Eisinger.
1821
1822         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1823         (DRTTestRunner::DRTTestRunner):
1824         * DumpRenderTree/chromium/DRTTestRunner.h:
1825         (DRTTestRunner):
1826         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1827         (WebTestRunner::WebTestDelegate::didAcquirePointerLock):
1828         (WebTestRunner::WebTestDelegate::didNotAcquirePointerLock):
1829         (WebTestRunner::WebTestDelegate::didLosePointerLock):
1830         (WebTestRunner::WebTestDelegate::setPointerLockWillRespondAsynchronously):
1831         (WebTestRunner::WebTestDelegate::setPointerLockWillFailSynchronously):
1832         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1833         (WebTestRunner::TestRunner::TestRunner):
1834         (WebTestRunner):
1835         (WebTestRunner::TestRunner::didAcquirePointerLock):
1836         (WebTestRunner::TestRunner::didNotAcquirePointerLock):
1837         (WebTestRunner::TestRunner::didLosePointerLock):
1838         (WebTestRunner::TestRunner::setPointerLockWillRespondAsynchronously):
1839         (WebTestRunner::TestRunner::setPointerLockWillFailSynchronously):
1840         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1841         (TestRunner):
1842         * DumpRenderTree/chromium/WebViewHost.h:
1843         (WebViewHost):
1844
1845 2013-01-14  Dominik Röttsches  <dominik.rottsches@intel.com>
1846
1847         [EFL] Update freetype in jhbuild to 2.4.11 and activate subpixel layout
1848         https://bugs.webkit.org/show_bug.cgi?id=106774
1849
1850         Reviewed by Martin Robinson.
1851
1852         In order to fix a long standing linespacing/font ascent & descent issue
1853         we found that FreeType commit b0962ac34e660 solves that problem.
1854         Let's update FreeType accordingly, but bump it to 2.4.11 due to the
1855         maintainer recommending several security updates after that said commit.
1856
1857         Also, in order to avoid extra rebaselining, let's activate subpixel
1858         layout at the same time.
1859
1860         * efl/jhbuild.modules: New freetype 2.4.11
1861
1862 2013-01-17  Xiaobo Wang  <xbwang@torchmobile.com.cn>
1863
1864         [BlackBerry] DRT - Accept http/file URL when running drt-launcher from command line
1865         https://bugs.webkit.org/show_bug.cgi?id=107107
1866         PR 282192
1867
1868         Reviewed by Rob Buis.
1869
1870         The DRT application will convert relative/absolute file path to
1871         file://<real-file-path> format, so we only check for http/file prefix.
1872
1873         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
1874         (BlackBerry::WebKit::isFullUrl):
1875         (WebKit):
1876         (BlackBerry::WebKit::DumpRenderTree::runCurrentTest):
1877
1878 2013-01-17  Frank Farzan  <frankf@chromium.org>
1879
1880         Flakiness dashboard: Add ChromiumFYI master
1881         https://bugs.webkit.org/show_bug.cgi?id=107180
1882
1883         Reviewed by Ojan Vafai.
1884
1885         This is needed to enable Chrome Android bots
1886         to upload results for instrumentation tests.
1887
1888         * TestResultServer/generate_builders_json.py:
1889         (main):
1890         * TestResultServer/static-dashboards/builders.jsonp:
1891
1892 2013-01-17  Frank Farzan  <frankf@chromium.org>
1893
1894         Add Chrome on Android instrumentation test types to flakiness dashboard
1895         https://bugs.webkit.org/show_bug.cgi?id=106964
1896
1897         Reviewed by Ojan Vafai.
1898
1899         Specifically, add these test types:
1900
1901          androidwebview_instrumentation_tests
1902          chromiumtestshell_instrumentation_tests
1903          contentshell_instrumentation_tests
1904
1905         Also, add ChromiumFYI to the list of masters.
1906
1907         * TestResultServer/static-dashboards/builders.js:
1908         (loadBuildersList):
1909         * TestResultServer/static-dashboards/dashboard_base.js:
1910         (currentBuilderGroupCategory):
1911
1912 2013-01-17  Tim 'mithro' Ansell  <mithro@mithis.com>
1913
1914         Fixing webkitpy's SCM unit tests.
1915         https://bugs.webkit.org/show_bug.cgi?id=106429
1916
1917         Reviewed by Eric Seidel.
1918
1919         * Scripts/webkitpy/common/checkout/scm/detection_unittest.py:
1920         (SCMDetectorTest.test_detect_scm_system):
1921         * Scripts/webkitpy/common/checkout/scm/git.py:
1922         (Git.in_working_directory):
1923         (Git.read_git_config):
1924         (Git._assert_can_squash):
1925         (Git.remote_branch_ref):
1926         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1927         (GitSVNTest.test_commit_with_message_multiple_local_commits_always_squash):
1928         (GitTestWithMock):
1929         (GitTestWithMock.make_scm):
1930         (GitTestWithMock.test_create_patch):
1931         * Scripts/webkitpy/common/system/outputcapture.py:
1932         (OutputCapture.assert_outputs):
1933         (OutputCaptureTestCaseBase):
1934         * Scripts/webkitpy/test/printer.py:
1935         (Printer.configure):
1936
1937 2013-01-17  Julie Parent  <jparent@chromium.org>
1938
1939         Flakiness dashboard assumes there must be ToT tests
1940         https://bugs.webkit.org/show_bug.cgi?id=107155
1941
1942         Remove group as a default parameter, since we can't actually know
1943         the name of a group initially.  Instead, introduces
1944         currentBuilderGroupName which returns the current builder group
1945         if it has been explicitly set, or picks the first one available
1946         as a default. Allows us to remove some extra code tracking this
1947         stuff as well.
1948
1949         Reviewed by Ojan Vafai.
1950
1951         * TestResultServer/static-dashboards/dashboard_base.js:
1952         (parseCrossDashboardParameters):
1953         (currentBuilderGroupName):
1954         (currentBuilderGroup):
1955         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1956         (platformAndBuildType):
1957         * TestResultServer/static-dashboards/loader.js:
1958         (.):
1959
1960 2013-01-16  Ryosuke Niwa  <rniwa@webkit.org>
1961
1962         Remove NodeListsNodeData when it's no longer needed
1963         https://bugs.webkit.org/show_bug.cgi?id=107074
1964
1965         Reviewed by Darin Adler.
1966
1967         Generalize the warning a little so that it's also ignored on PerformanceTests/DOM/TraverseChildNodes.html
1968
1969         * Scripts/webkitpy/performance_tests/perftest.py:
1970         (PerfTest):
1971
1972 2013-01-17  Simon Fraser  <simon.fraser@apple.com>
1973
1974         Ref test images are upside-down in WebKit2
1975         https://bugs.webkit.org/show_bug.cgi?id=105457
1976
1977         Reviewed by Sam "Speedy" Weinig.
1978
1979         The bitmap context created in TestInvocation::dumpPixelsAndCompareWithExpected()
1980         from the window snapshot contained a flipped copy of the image, causing all ref
1981         and pixel images to be upside-down.
1982
1983         * WebKitTestRunner/cg/TestInvocationCG.cpp:
1984         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1985
1986 2013-01-17  Timothy Loh  <timloh@google.com>
1987
1988         Replaced specifiers variable with is_debug in builders.py
1989         https://bugs.webkit.org/show_bug.cgi?id=107057
1990
1991         Reviewed by Dirk Pranke.
1992
1993         Replaced specifiers variable with is_debug in builders.py to simplify
1994         Bug 106259. The other specifiers are not used elsewhere in the code.
1995         Fixed builder_name_for_port_name to return a debug builder if we don't
1996         have a release builder.
1997
1998         * Scripts/webkitpy/layout_tests/port/builders.py:
1999         (all_port_names):
2000         (builder_name_for_port_name):
2001         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2002         (TestRebaselineExpectations.test_rebaseline_expectations):
2003
2004 2013-01-17  Martin Robinson  <mrobinson@igalia.com>
2005
2006         [GTK] Build with LevelDB when IndexedDB is enabled
2007         https://bugs.webkit.org/show_bug.cgi?id=103220
2008
2009         Reviewed by Gustavo Noronha Silva.
2010
2011         * Scripts/webkitpy/style/checker.py: Do not style check the leveldb source code
2012         as it does not conform to WebKit style.
2013
2014 2013-01-17  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
2015
2016         [EFL][WK2] Fix misuse of ASSERT on ecore_evas_init()
2017         https://bugs.webkit.org/show_bug.cgi?id=107119
2018
2019         Reviewed by Laszlo Gombos.
2020
2021         Do not use ASSERT on ecore_evas_init(), since the expression inside
2022         the macro compiles out of release builds.
2023
2024         * TestWebKitAPI/PlatformEfl.cmake: Enable API test UserMessage.
2025         * TestWebKitAPI/efl/PlatformWebView.cpp:
2026         (TestWebKitAPI::initEcoreEvas): Remove ASSERT on ecore_evas_init().
2027
2028 2013-01-17  Eugene Klyuchnikov  <eustas@chromium.org>
2029
2030         Web Inspector: Profiler: split "getProfile" to "getCPUProfile" and "loadHeapSnapshot"
2031         https://bugs.webkit.org/show_bug.cgi?id=104545
2032
2033         Reviewed by Yury Semikhatsky.
2034
2035         Adopt signature changes.
2036
2037         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
2038         (ProfilerAgent.getCPUProfile): Renamed.
2039         (ProfilerAgent.getHeapSnapshot): Added.
2040
2041 2013-01-17  Zan Dobersek  <zdobersek@igalia.com>
2042
2043         [GTK][EFL] NWRT should check that Xvfb is installed
2044         https://bugs.webkit.org/show_bug.cgi?id=71767
2045
2046         Reviewed by Dirk Pranke.
2047
2048         EFL and GTK ports now check that Xvfb is installed before running
2049         layout tests. The command line used to check whether Xvfb is present
2050         is a simple `which Xvfb` that should return 0 as the exit code upon
2051         success.
2052
2053         * Scripts/webkitpy/layout_tests/port/efl.py:
2054         (EflPort.show_results_html_file):
2055         (EflPort):
2056         (EflPort.check_sys_deps):
2057         * Scripts/webkitpy/layout_tests/port/gtk.py:
2058         (GtkPort.check_sys_deps):
2059         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
2060         (XvfbDriver):
2061         (XvfbDriver.check_xvfb):
2062
2063 2013-01-16  Alan Cutter  <alancutter@chromium.org>
2064
2065         sheriffbot can't tell me who "kov" is
2066         https://bugs.webkit.org/show_bug.cgi?id=106184
2067
2068         Reviewed by Eric Seidel.
2069
2070         Added glob style searching to the CommitterList contributors_by_search_string function so exact matches are favoured.
2071
2072         * Scripts/webkitpy/common/config/committers.py:
2073         (Account.matches_glob):
2074         (CommitterList.contributors_by_search_string):
2075         * Scripts/webkitpy/common/config/committers_unittest.py:
2076         (CommittersTest.test_committer_lookup):
2077         * Scripts/webkitpy/tool/bot/irc_command.py:
2078         (Whois):
2079
2080 2013-01-16  David Kilzer  <ddkilzer@apple.com>
2081
2082         Use xcrun to find path to make for Mac port
2083         <http://webkit.org/b/107091>
2084
2085         Reviewed by Dan Bernstein.
2086
2087         * Scripts/webkitpy/layout_tests/port/mac.py:
2088         (MacPort._build_java_test_support): Call self.make_command().
2089         (MacPort.make_command): Add.  Call xcrun_find().
2090         (MacPort.nm_command): Use self.xcrun_find().
2091         (MacPort.xcrun_find): Add.  Extract from nm_command().
2092
2093 2013-01-16  Sam Weinig  <sam@webkit.org>
2094
2095         Make debug-safari --target-web-process work again
2096         https://bugs.webkit.org/show_bug.cgi?id=107088
2097
2098         Reviewed by Anders Carlsson.
2099
2100         * Scripts/webkitdirs.pm:
2101         (execMacWebKitAppForDebugging):
2102         The shim is now called SecItemShim.
2103
2104 2013-01-16  Alan Cutter  <alancutter@chromium.org>
2105
2106         GCE build scripts don't take working directory into account when calling findzone.sh
2107         https://bugs.webkit.org/show_bug.cgi?id=106962
2108
2109         Reviewed by Adam Barth.
2110
2111         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
2112         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
2113         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh:
2114
2115 2013-01-16  Alan Cutter  <alancutter@chromium.org>
2116
2117         start-queue.sh does not pass remaining parameters correctly
2118         https://bugs.webkit.org/show_bug.cgi?id=107054
2119
2120         Reviewed by Adam Barth.
2121
2122         start-queue.sh now passes all remaining params to the webkit-patch command.
2123         Previously only one additional queue parameter could be sent.
2124
2125         * EWSTools/start-queue.sh:
2126
2127 2013-01-16  Xueqing Huang  <huangxueqing@baidu.com>
2128
2129         check-webkit-style script cannot running in Chinese windows.
2130         https://bugs.webkit.org/show_bug.cgi?id=87548
2131
2132         Reviewed by Darin Adler.
2133
2134         * Scripts/webkitpy/common/system/platforminfo.py:
2135         (PlatformInfo._win_version_tuple_from_cmd):
2136
2137 2013-01-16  Dirk Pranke  <dpranke@chromium.org>
2138
2139         Delete an extraneous print statement.
2140         https://bugs.webkit.org/show_bug.cgi?id=106562
2141
2142         Delete the extraneous print statement introduced in r139841.
2143
2144         * Scripts/webkitpy/layout_tests/views/printing.py:
2145         (Printer.print_found):
2146
2147 2013-01-16  Zan Dobersek  <zdobersek@igalia.com>
2148
2149         Please reinstate --pixel
2150         https://bugs.webkit.org/show_bug.cgi?id=101995
2151
2152         Reviewed by Dirk Pranke.
2153
2154         Add the '--pixel' and '--no-pixel' options for NRWT as aliases for
2155         the '--pixel-tests' (or '-p') and '--no-pixel-tests' options respectively.
2156         Some developers are still used to these options that were available in the ORWT.
2157
2158         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2159         (parse_args):
2160
2161 2013-01-16  Eric Seidel  <eric@webkit.org>
2162
2163         Remove --shark* support from sunspider/run-sunspider now that Shark is dead
2164         https://bugs.webkit.org/show_bug.cgi?id=99512
2165
2166         Reviewed by Darin Adler.
2167
2168         * Scripts/run-sunspider:
2169
2170 2013-01-16  Eric Seidel  <eric@webkit.org>
2171
2172         Remove webkitpy Visual Studio files, as core developers are not interested in maintaining them
2173         https://bugs.webkit.org/show_bug.cgi?id=106036
2174
2175         Reviewed by Darin Adler.
2176
2177         * Scripts/webkitpy/webkitpy.pyproj: Removed.
2178         * Scripts/webkitpy/webkitpy.sln: Removed.
2179
2180 2013-01-16  Chris Hopman  <cjhopman@chromium.org>
2181
2182         [Chromium] Remove hardcoded chromium_*.jar in gyp files
2183         https://bugs.webkit.org/show_bug.cgi?id=104049
2184
2185         Reviewed by Eric Seidel.
2186
2187         Targets with dependencies (direct/indirect) on a java target receive
2188         the chromium_*.jar paths in the variable input_jars_paths. Targets
2189         should use that rather than hardcoding where they think the jar will
2190         be. These can be passed directly to ant as INPUT_JARS_PATHS rather
2191         than as --jars to generate_native_test.py.
2192
2193         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2194         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
2195
2196 2013-01-16  Dan Carney  <dcarney@google.com>
2197
2198         [chromium] move setMockDeviceOrientation to TestRunner library
2199         https://bugs.webkit.org/show_bug.cgi?id=106895
2200
2201         Reviewed by Jochen Eisinger.
2202
2203         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2204         (DRTTestRunner::DRTTestRunner):
2205         * DumpRenderTree/chromium/DRTTestRunner.h:
2206         (DRTTestRunner):
2207         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2208         (WebKit):
2209         (WebTestRunner::WebTestDelegate::setDeviceOrientation):
2210         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2211         (WebTestRunner::TestRunner::TestRunner):
2212         (WebTestRunner::TestRunner::setMockDeviceOrientation):
2213         (WebTestRunner):
2214         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2215         (TestRunner):
2216         * DumpRenderTree/chromium/WebViewHost.cpp:
2217         (WebViewHost::setDeviceOrientation):
2218         * DumpRenderTree/chromium/WebViewHost.h:
2219         (WebViewHost):
2220
2221 2013-01-16  Jochen Eisinger  <jochen@chromium.org>
2222
2223         [chromium] route more webkit_support and webviewhost callbacks through WebTestDelegate
2224         https://bugs.webkit.org/show_bug.cgi?id=106904
2225
2226         Reviewed by Adam Barth.
2227
2228         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2229         (DRTTestRunner::DRTTestRunner):
2230         (DRTTestRunner::notifyDone):
2231         (DRTTestRunner::reset):
2232         * DumpRenderTree/chromium/DRTTestRunner.h:
2233         (DRTTestRunner):
2234         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2235         (WebTestRunner::WebTestDelegate::setDeviceScaleFactor):
2236         (WebTestRunner::WebTestDelegate::setFocus):
2237         (WebTestRunner::WebTestDelegate::setAcceptAllCookies):
2238         (WebTestRunner::WebTestDelegate::pathToLocalResource):
2239         (WebTestRunner::WebTestDelegate::setLocale):
2240         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2241         (WebTestRunner::TestRunner::TestRunner):
2242         (WebTestRunner::TestRunner::reset):
2243         (WebTestRunner::TestRunner::setAlwaysAcceptCookies):
2244         (WebTestRunner):
2245         (WebTestRunner::TestRunner::setWindowIsKey):
2246         (WebTestRunner::TestRunner::pathToLocalResource):
2247         (WebTestRunner::TestRunner::setBackingScaleFactor):
2248         (WebTestRunner::TestRunner::setPOSIXLocale):
2249         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2250         (WebTestRunner::TestRunner::taskList):
2251         (TestRunner):
2252         * DumpRenderTree/chromium/WebViewHost.cpp:
2253         (WebViewHost::setDeviceScaleFactor):
2254         (WebViewHost::setFocus):
2255         (WebViewHost::setAcceptAllCookies):
2256         (WebViewHost::pathToLocalResource):
2257         (WebViewHost::setLocale):
2258         * DumpRenderTree/chromium/WebViewHost.h:
2259         (WebViewHost):
2260
2261 2013-01-16  Sergio Villar Senin  <svillar@igalia.com>
2262
2263         [GTK] build-webkit fails if the jhbuild wrapper is not used
2264         https://bugs.webkit.org/show_bug.cgi?id=106769
2265
2266         Reviewed by Martin Robinson.
2267
2268         Return an empty array instead of "" in
2269         jhbuildWrapperPrefixIfNeeded() because otherwise that empty string
2270         will not be recognized as a valid command when the returned array
2271         is directly passed to perl's system() call.
2272
2273         * Scripts/webkitdirs.pm:
2274         (jhbuildWrapperPrefixIfNeeded):
2275
2276 2013-01-16  Jochen Eisinger  <jochen@chromium.org>
2277
2278         [chromium] add title text direction attribute to TestRunner
2279         https://bugs.webkit.org/show_bug.cgi?id=106907
2280
2281         Reviewed by Adam Barth.
2282
2283         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2284         (DRTTestRunner::DRTTestRunner):
2285         (DRTTestRunner::reset):
2286         * DumpRenderTree/chromium/DRTTestRunner.h:
2287         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
2288         (WebTestRunner::WebTestRunner::setTitleTextDirection):
2289         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2290         (WebTestRunner::TestRunner::TestRunner):
2291         (WebTestRunner::TestRunner::reset):
2292         (WebTestRunner::TestRunner::setTitleTextDirection):
2293         (WebTestRunner):
2294         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2295         (TestRunner):
2296         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
2297         (WebTestRunner::WebTestProxyBase::didReceiveTitle):
2298         * DumpRenderTree/chromium/WebViewHost.cpp:
2299         (WebViewHost::didReceiveTitle):
2300
2301 2013-01-16  Jussi Kukkonen  <jussi.kukkonen@intel.com>
2302
2303         NRWT still confused about test count with --repeat-each and --iterations
2304         https://bugs.webkit.org/show_bug.cgi?id=106562
2305
2306         Reviewed by Dirk Pranke.
2307
2308         Fix the printed unique test count and skipped count. This
2309         seems to have broken in r127688 ("NRWT lies about the number
2310         of tests that it's skipping when used with --repeat-each").
2311
2312         Also add a test for print_found()
2313
2314         * Scripts/webkitpy/layout_tests/views/printing.py:
2315         (Printer.print_found):
2316         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
2317         (Testprinter.test_details):
2318         (Testprinter):
2319         (Testprinter.test_found):
2320
2321 2013-01-15  Zan Dobersek  <zdobersek@igalia.com>
2322
2323         Unreviewed follow-up to r139769.
2324
2325         Note that omitting the WebKit1 code from the build now
2326         works for GTK as well.
2327
2328         * Scripts/build-webkit:
2329
2330 2013-01-15  Dirk Pranke  <dpranke@chromium.org>
2331
2332         test-webkitpy: truncate output to the terminal width when necessary
2333         https://bugs.webkit.org/show_bug.cgi?id=106973
2334
2335         Reviewed by Ojan Vafai.
2336
2337         this implements the same logic for test-webkitpy that we have
2338         for run-webkit-tests (and ninja).
2339
2340         No tests written as this is exercised by running test-webkitpy itself.
2341
2342         * Scripts/webkitpy/test/printer.py:
2343         (Printer.configure):
2344         (Printer._test_line):
2345
2346 2013-01-15  Dirk Pranke  <dpranke@chromium.org>
2347
2348         remove extraneous output in test-webkitpy
2349         https://bugs.webkit.org/show_bug.cgi?id=106971
2350
2351         Reviewed by Ojan Vafai.
2352
2353         We weren't ignoring or capturing the echoed output from
2354         these two tests, and getting noise in the logs as a result.
2355
2356         * Scripts/webkitpy/common/system/executive_unittest.py:
2357         (ExecutiveTest.test_auto_stringify_args):
2358         (ExecutiveTest.test_popen_args):
2359
2360 2013-01-15  Dirk Pranke  <dpranke@chromium.org>
2361
2362         webkitpy.layout_tests.servers.http_server_unittest.TestHttpServer.test_win32_start_and_stop is flaky
2363         https://bugs.webkit.org/show_bug.cgi?id=106974
2364
2365         Reviewed by Ryosuke Niwa.
2366
2367         I forgot to stub out the call to check to ensure that the ports were
2368         available, so this test could fail if something was listening on 8000 or
2369         8443 on the machine.
2370
2371         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
2372         (TestHttpServer.test_win32_start_and_stop):
2373
2374 2013-01-15  Levi Weintraub  <leviw@chromium.org>
2375
2376         Unreviewed, rolling out r139792.
2377         http://trac.webkit.org/changeset/139792
2378         https://bugs.webkit.org/show_bug.cgi?id=106970
2379
2380         Broke the windows build.
2381
2382         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2383         (DRTTestRunner::DRTTestRunner):
2384         (DRTTestRunner::notifyDone):
2385         (DRTTestRunner::reset):
2386         (DRTTestRunner::setAlwaysAcceptCookies):
2387         (DRTTestRunner::setWindowIsKey):
2388         (DRTTestRunner::pathToLocalResource):
2389         (DRTTestRunner::setPOSIXLocale):
2390         (InvokeCallbackTask):
2391         (InvokeCallbackTask::InvokeCallbackTask):
2392         (InvokeCallbackTask::runIfValid):
2393         (DRTTestRunner::setBackingScaleFactor):
2394         * DumpRenderTree/chromium/DRTTestRunner.h:
2395         (DRTTestRunner):
2396         (DRTTestRunner::taskList):
2397         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2398         (WebTestRunner::WebTestDelegate::setDatabaseQuota):
2399         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2400         (WebTestRunner::TestRunner::TestRunner):
2401         (WebTestRunner::TestRunner::reset):
2402         (WebTestRunner::TestRunner::setDatabaseQuota):
2403         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2404         (TestRunner):
2405         * DumpRenderTree/chromium/WebViewHost.cpp:
2406         (WebViewHost::setPendingExtraData):
2407         (WebViewHost::setDeviceScaleFactor):
2408         * DumpRenderTree/chromium/WebViewHost.h:
2409         (WebViewHost):
2410
2411 2013-01-15  Ryosuke Niwa  <rniwa@webkit.org>
2412
2413         Build fix after r139357. The port name of MacWK2EWS should be 'mac-wk2'.
2414
2415         * Scripts/webkitpy/common/config/ports.py:
2416         (MacWK2Port):
2417
2418 2013-01-15  Alan Cutter  <alancutter@chromium.org>
2419
2420         Extend sheriffbot's "help" command to be able to get help on individual commands
2421         https://bugs.webkit.org/show_bug.cgi?id=106629
2422
2423         Reviewed by Eric Seidel.
2424
2425         Added a help command to sheriffbot.
2426         Fixed some style issues and ordered the commands alphabetically.
2427
2428         * Scripts/webkitpy/tool/bot/irc_command.py:
2429         (IRCCommand):
2430         (IRCCommand.execute):
2431         (IRCCommand.usage):
2432         (IRCCommand.help):
2433         (CreateBug):
2434         (CreateBug.execute):
2435         (Help):
2436         (Help.execute):
2437         (Help._post_command_help):
2438         (Hi):
2439         (Hi.execute):
2440         (Restart):
2441         (RollChromiumDEPS):
2442         (RollChromiumDEPS._parse_args):
2443         (RollChromiumDEPS._expand_irc_nickname):
2444         (RollChromiumDEPS.execute):
2445         (Rollout):
2446         (Rollout._extract_revisions):
2447         (Rollout.execute):
2448         (Sheriffs):
2449         (Sheriffs.execute):
2450         (Whois):
2451         (Whois.execute):
2452         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
2453         (IRCBotTest.test_help):
2454
2455 2013-01-15  Enrica Casucci  <enrica@apple.com>
2456
2457         Add a new set of WebKit2 APIs for text search and
2458         search results management.
2459         https://bugs.webkit.org/show_bug.cgi?id=106834.
2460         <rdar://problem/12597159>
2461
2462         Added new test for the new WebKit2 API for
2463         text search.
2464
2465         Reviewed by Simon Fraser.
2466
2467         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2468         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm: Added.
2469
2470 2013-01-15  Levi Weintraub  <leviw@chromium.org>
2471
2472         [chromium] route more webkit_support and webviewhost callbacks through WebTestDelegate
2473         https://bugs.webkit.org/show_bug.cgi?id=106904
2474
2475         Reverting 139794. It broke the build. It appears that a header file,
2476         WebTextDirection.h, was left out.
2477
2478         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2479         (DRTTestRunner::DRTTestRunner):
2480         (DRTTestRunner::reset):
2481         * DumpRenderTree/chromium/DRTTestRunner.h:
2482         (DRTTestRunner::setTitleTextDirection):
2483         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
2484         (WebTestRunner::WebTestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
2485         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2486         (WebTestRunner::TestRunner::TestRunner):
2487         (WebTestRunner::TestRunner::reset):
2488         (WebTestRunner::TestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
2489         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2490         (TestRunner):
2491         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
2492         (WebTestRunner::WebTestProxyBase::didReceiveTitle):
2493         * DumpRenderTree/chromium/WebViewHost.cpp:
2494         (WebViewHost::didReceiveTitle):
2495
2496 2013-01-15  Jochen Eisinger  <jochen@chromium.org>
2497
2498         [chromium] route more webkit_support and webviewhost callbacks through WebTestDelegate
2499         https://bugs.webkit.org/show_bug.cgi?id=106904
2500
2501         Reviewed by Adam Barth.
2502
2503         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2504         (DRTTestRunner::DRTTestRunner):
2505         (DRTTestRunner::notifyDone):
2506         (DRTTestRunner::reset):
2507         * DumpRenderTree/chromium/DRTTestRunner.h:
2508         (DRTTestRunner):
2509         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2510         (WebTestRunner::WebTestDelegate::setDeviceScaleFactor):
2511         (WebTestRunner::WebTestDelegate::setFocus):
2512         (WebTestRunner::WebTestDelegate::setAcceptAllCookies):
2513         (WebTestRunner::WebTestDelegate::pathToLocalResource):
2514         (WebTestRunner::WebTestDelegate::setLocale):
2515         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2516         (WebTestRunner::TestRunner::TestRunner):
2517         (WebTestRunner::TestRunner::reset):
2518         (WebTestRunner::TestRunner::setAlwaysAcceptCookies):
2519         (WebTestRunner):
2520         (WebTestRunner::TestRunner::setWindowIsKey):
2521         (WebTestRunner::TestRunner::pathToLocalResource):
2522         (WebTestRunner::TestRunner::setBackingScaleFactor):
2523         (WebTestRunner::TestRunner::setPOSIXLocale):
2524         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2525         (WebTestRunner::TestRunner::taskList):
2526         (TestRunner):
2527         * DumpRenderTree/chromium/WebViewHost.cpp:
2528         (WebViewHost::setDeviceScaleFactor):
2529         (WebViewHost::setFocus):
2530         (WebViewHost::setAcceptAllCookies):
2531         (WebViewHost::pathToLocalResource):
2532         (WebViewHost::setLocale):
2533         * DumpRenderTree/chromium/WebViewHost.h:
2534         (WebViewHost):
2535
2536 2013-01-15  Zan Dobersek  <zdobersek@igalia.com>
2537
2538         Tests with WontFix expectation are (indirectly) skipped
2539         https://bugs.webkit.org/show_bug.cgi?id=105860
2540
2541         Reviewed by Dirk Pranke.
2542
2543         Only skip the WontFix expectation if there are no other layout test
2544         expectations (like Failure, ImageOnlyFailure) listed for the test.
2545         This makes it possible to run an expected failure for which there
2546         is no reason or interest to fix. There are some ports that would like
2547         to exercise this behavior as well as specific test cases that should use
2548         such expectations.
2549
2550         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2551         (TestExpectationParser._tokenize_line): Only add the SKIP modifier for a
2552         WONTFIX test if there are no expectations listed. The warning is adjusted
2553         to reflect the new behavior.
2554         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Add
2555         and adjust test cases for these changes.
2556         (ExpectationSyntaxTests.test_wontfix):
2557         (SemanticTests.test_skip_and_wontfix):
2558
2559 2013-01-15  Jochen Eisinger  <jochen@chromium.org>
2560
2561         [chromium] add title text direction attribute to TestRunner
2562         https://bugs.webkit.org/show_bug.cgi?id=106907
2563
2564         Reviewed by Adam Barth.
2565
2566         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2567         (DRTTestRunner::DRTTestRunner):
2568         (DRTTestRunner::reset):
2569         * DumpRenderTree/chromium/DRTTestRunner.h:
2570         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
2571         (WebTestRunner::WebTestRunner::setTitleTextDirection):
2572         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2573         (WebTestRunner::TestRunner::TestRunner):
2574         (WebTestRunner::TestRunner::reset):
2575         (WebTestRunner::TestRunner::setTitleTextDirection):
2576         (WebTestRunner):
2577         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2578         (TestRunner):
2579         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
2580         (WebTestRunner::WebTestProxyBase::didReceiveTitle):
2581         * DumpRenderTree/chromium/WebViewHost.cpp:
2582         (WebViewHost::didReceiveTitle):
2583
2584 2013-01-15  Dirk Pranke  <dpranke@chromium.org>
2585
2586         nrwt: change the default # of locked shards on chromium_win to 1
2587         https://bugs.webkit.org/show_bug.cgi?id=106938
2588
2589         Reviewed by Eric Seidel.
2590
2591         It looks like LigHTTPd might be buggy or unstable if we are
2592         running multiple http tests in parallel; see
2593         http://code.google.com/p/chromium/issues/detail?id=169530 for more
2594         context as well. This change will stop running http tests in parallel
2595         and we can see if this fixes things.
2596
2597         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2598         (ChromiumWinPort.default_max_locked_shards):
2599         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2600         (ChromiumWinTest.test_path_to_image_diff):
2601         (ChromiumWinTest):
2602         (ChromiumWinTest.test_default_max_locked_shards):
2603
2604 2013-01-15  Jochen Eisinger  <jochen@chromium.org>
2605
2606         [chromium] move WebDatabase related methods to TestRunner library
2607         https://bugs.webkit.org/show_bug.cgi?id=106905
2608
2609         Reviewed by Adam Barth.
2610
2611         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2612         (DRTTestRunner::DRTTestRunner):
2613         (DRTTestRunner::reset):
2614         * DumpRenderTree/chromium/DRTTestRunner.h:
2615         (DRTTestRunner):
2616         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2617         (WebTestRunner::WebTestDelegate::clearAllDatabases):
2618         (WebTestRunner::WebTestDelegate::setDatabaseQuota):
2619         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2620         (WebTestRunner::TestRunner::TestRunner):
2621         (WebTestRunner::TestRunner::reset):
2622         (WebTestRunner::TestRunner::clearAllDatabases):
2623         (WebTestRunner):
2624         (WebTestRunner::TestRunner::setDatabaseQuota):
2625         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2626         (TestRunner):
2627         * DumpRenderTree/chromium/WebViewHost.cpp:
2628         (WebViewHost::clearAllDatabases):
2629         (WebViewHost::setDatabaseQuota):
2630         * DumpRenderTree/chromium/WebViewHost.h:
2631         (WebViewHost):
2632
2633 2013-01-15  Tim 'mithro' Ansell  <mithro@mithis.com>
2634
2635         Renaming CleanWorkingDirectory step to DiscardLocalChanges to make
2636         functionality match the name.
2637         https://bugs.webkit.org/show_bug.cgi?id=106870
2638
2639         Reviewed by Adam Barth.
2640
2641         * Scripts/webkitpy/tool/commands/download.py:
2642         (Clean):
2643         (Update):
2644         (Build):
2645         (BuildAndTest):
2646         (CheckStyle):
2647         (BuildAttachment):
2648         (BuildAndTestAttachment):
2649         (AbstractPatchApplyingCommand):
2650         (ApplyWatchList):
2651         (AbstractPatchLandingCommand):
2652         (CreateRollout):
2653         * Scripts/webkitpy/tool/steps/__init__.py:
2654         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
2655         (CleanWorkingDirectory.options):
2656         (CleanWorkingDirectory.run):
2657         * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py:
2658         * Scripts/webkitpy/tool/steps/discardlocalchanges.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
2659         * Scripts/webkitpy/tool/steps/discardlocalchanges_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py.
2660
2661 2013-01-15  Zan Dobersek  <zandobersek@gmail.com>
2662
2663         [Autotools] Add support for WebKit2-only builds
2664         https://bugs.webkit.org/show_bug.cgi?id=106889
2665
2666         Reviewed by Gustavo Noronha Silva.
2667
2668         * GNUmakefile.am: Only build the GtkLauncher and DumpRenderTree if building WebKit1.
2669         * Scripts/build-webkit: Pass along the information on whether to build WebKit1 when
2670         building the GTK port through build-webkit.
2671         * Scripts/webkitdirs.pm:
2672         (buildAutotoolsProject): Add the --disable-webkit1 configuration flag to the build
2673         arguments when not building WebKit1.
2674         (buildGtkProject): Pass along the information on whether to build WebKit1 when building
2675         through the Autotools build system.
2676
2677 2013-01-15  Zan Dobersek  <zandobersek@gmail.com>
2678
2679         [GTK] Enable Performance Timeline, Resource Timing, Navigation Timing features
2680         https://bugs.webkit.org/show_bug.cgi?id=106197
2681
2682         Reviewed by Martin Robinson.
2683
2684         * Scripts/webkitperl/FeatureList.pm: Add the configuration options for all three
2685         features. Enable them on GTK, meaning they will be enabled in development builds
2686         (i.e. when building with build-webkit).
2687
2688 2013-01-15  Zan Dobersek  <zandobersek@gmail.com>
2689
2690         [GTK] Enable CSS Image Resolution feature
2691         https://bugs.webkit.org/show_bug.cgi?id=99038
2692
2693         Reviewed by Gustavo Noronha Silva.
2694
2695         Enable the CSS Image Resolution feature for the development
2696         builds of the GTK port.
2697
2698         * Scripts/webkitperl/FeatureList.pm:
2699
2700 2013-01-15  Zan Dobersek  <zandobersek@gmail.com>
2701
2702         [GTK] Stop passing the unstable features flag to configure script when using build-webkit
2703         https://bugs.webkit.org/show_bug.cgi?id=106579
2704
2705         Reviewed by Gustavo Noronha Silva.
2706
2707         The --enable-unstable-features flag is not required to be passed anymore
2708         to the configure script as it was removed in r138252.
2709
2710         * Scripts/webkitdirs.pm:
2711         (buildAutotoolsProject):
2712
2713 2013-01-15  Tony Chang  <tony@chromium.org>
2714
2715         [chromium] Unreviewed, fix a bug where we don't properly shutdown lighttpd.
2716
2717         * Scripts/webkitpy/layout_tests/servers/http_server.py:
2718         (Lighttpd._check_and_kill): Pass /pid so taskkill.exe doesn't error out on us.
2719         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
2720         (TestHttpServer.test_win32_start_and_stop):
2721
2722 2013-01-15  Joshua Bell  <jsbell@chromium.org>
2723
2724         Unreviewed. Adding Michael Pruett as contributor.
2725
2726         * Scripts/webkitpy/common/config/committers.py:
2727
2728 2013-01-15  Victor Carbune  <victor@rosedu.org>
2729
2730         Unreviewed. Update my email addresses.
2731
2732         * Scripts/webkitpy/common/config/committers.py:
2733
2734 2013-01-15  Zan Dobersek  <zdobersek@igalia.com>
2735
2736         [GTK] Waiting on the gdb process will lead to deadlock
2737         https://bugs.webkit.org/show_bug.cgi?id=106906
2738
2739         Reviewed by Philippe Normand.
2740
2741         Use communicate() rather than wait() on the Popen object that's running the gdb
2742         command. This avoids the deadlock that occurs on the GTK builders.
2743
2744         * Scripts/webkitpy/layout_tests/port/gtk.py:
2745         (GtkPort._get_gdb_output):
2746
2747 2013-01-15  Zan Dobersek  <zdobersek@igalia.com>
2748
2749         [GTK] Limit the number of frames printed out when backtracing with gdb
2750         https://bugs.webkit.org/show_bug.cgi?id=106901
2751
2752         Reviewed by Philippe Normand.
2753
2754         Printing an unlimited number of frames when dumping the gdb backtracing
2755         output can cause timeouts in the builders. This patch limits the number
2756         of frames that are printed out to 1024.
2757
2758         * Scripts/webkitpy/layout_tests/port/gtk.py:
2759         (GtkPort._get_gdb_output):
2760
2761 2013-01-15  Andras Becsi  <andras.becsi@digia.com>
2762
2763         [Qt] Fix ImageDiff's image format conversion
2764         https://bugs.webkit.org/show_bug.cgi?id=106880
2765
2766         Reviewed by Csaba Osztrogonác.
2767
2768         Besides actually doing the conversion this also silences the suspicious warning:
2769         "ignoring return value of function declared with warn_unused_result attribute".
2770
2771         * ImageDiff/qt/ImageDiff.cpp:
2772         (main): QImage::convertToFormat, contrary to the assumed behaviour, returns a
2773         copy of the image in the given format and does not alter the image itself.
2774
2775 2013-01-15  Jochen Eisinger  <jochen@chromium.org>
2776
2777         [chromium] move remaining methods that just set a boolean flag to TestRunner library
2778         https://bugs.webkit.org/show_bug.cgi?id=106823
2779
2780         Reviewed by Darin Fisher.
2781
2782         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2783         (DRTTestRunner::DRTTestRunner):
2784         (DRTTestRunner::reset):
2785         * DumpRenderTree/chromium/DRTTestRunner.h:
2786         (DRTTestRunner):
2787         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
2788         (WebTestRunner::WebTestRunner::shouldDumpBackForwardList):
2789         (WebTestRunner::WebTestRunner::deferMainResourceDataLoad):
2790         (WebTestRunner::WebTestRunner::shouldDumpSelectionRect):
2791         (WebTestRunner::WebTestRunner::testRepaint):
2792         (WebTestRunner::WebTestRunner::sweepHorizontally):
2793         (WebTestRunner::WebTestRunner::isPrinting):
2794         (WebTestRunner::WebTestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
2795         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2796         (WebTestRunner::TestRunner::TestRunner):
2797         (WebTestRunner::TestRunner::reset):
2798         (WebTestRunner::TestRunner::shouldDumpBackForwardList):
2799         (WebTestRunner):
2800         (WebTestRunner::TestRunner::deferMainResourceDataLoad):
2801         (WebTestRunner::TestRunner::shouldDumpSelectionRect):
2802         (WebTestRunner::TestRunner::testRepaint):
2803         (WebTestRunner::TestRunner::sweepHorizontally):
2804         (WebTestRunner::TestRunner::isPrinting):
2805         (WebTestRunner::TestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
2806         (WebTestRunner::TestRunner::dumpBackForwardList):
2807         (WebTestRunner::TestRunner::setDeferMainResourceDataLoad):
2808         (WebTestRunner::TestRunner::dumpSelectionRect):
2809         (WebTestRunner::TestRunner::repaintSweepHorizontally):
2810         (WebTestRunner::TestRunner::setPrinting):
2811         (WebTestRunner::TestRunner::setShouldStayOnPageAfterHandlingBeforeUnload):
2812         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2813         (TestRunner):
2814
2815 2013-01-14  Dirk Pranke  <dpranke@chromium.org>
2816
2817         nrwt: stub out show_results_html for mock ports
2818         https://bugs.webkit.org/show_bug.cgi?id=106848
2819
2820         Reviewed by Ojan Vafai.
2821
2822         We were accidentally using the underlying ports'
2823         show_results_html_file() implementation, which would, unsurprisingly,
2824         fail in many cases (e.g., running mock-efl on the mac).
2825
2826         No test added since we don't generally add tests for the mock
2827         implementation.
2828
2829         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
2830         (MockDRTPort.show_results_html_file):
2831
2832 2013-01-14  Tim 'mithro' Ansell  <mithro@mithis.com>
2833
2834         Changing clean_working_directory/clean_local_commits and related
2835         functions to have consistent naming.
2836
2837         https://bugs.webkit.org/show_bug.cgi?id=104198
2838
2839         Reviewed by Adam Barth.
2840
2841         * Scripts/webkitpy/common/checkout/scm/git.py:
2842         * Scripts/webkitpy/common/checkout/scm/scm.py:
2843         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2844         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2845         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
2846         * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py:
2847
2848 2013-01-14  Alan Cutter  <alancutter@chromium.org>
2849
2850         Fix EWS GCE build scripts to detect which zone is available
2851         https://bugs.webkit.org/show_bug.cgi?id=106524
2852
2853         Reviewed by Adam Barth.
2854
2855         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
2856         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
2857         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh:
2858         * EWSTools/GoogleComputeEngine/findzone.sh: Added.
2859
2860 2013-01-14  Tim 'mithro' Ansell  <mithro@mithis.com>
2861
2862         Adding an error string to AmbiguousCommitError.
2863         https://bugs.webkit.org/show_bug.cgi?id=106846
2864
2865         Reviewed by Adam Barth.
2866
2867         * Scripts/webkitpy/common/checkout/scm/git.py:
2868         (AmbiguousCommitError.__init__):
2869
2870 2013-01-14  Dirk Pranke  <dpranke@chromium.org>
2871
2872         kill whole lighttpd process tree for chromium win
2873         https://bugs.webkit.org/show_bug.cgi?id=106838
2874
2875         Reviewed by Tony Chang.
2876
2877         Land a speculative fix for lighttpd.exe hanging on some chromium bots;
2878         I think a test is causing a httpd server child process to wedge and
2879         killing the parent httpd server process isn't sufficient to ensure
2880         that the children are also killed.
2881
2882         * Scripts/webkitpy/layout_tests/servers/http_server.py:
2883         (Lighttpd._check_and_kill):
2884         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
2885         (TestHttpServer.test_start_cmd):
2886         (TestHttpServer):
2887         (TestHttpServer.test_win32_start_and_stop):
2888         (TestHttpServer.test_win32_start_and_stop.wait_for_action):
2889         (TestHttpServer.test_win32_start_and_stop.mock_returns):
2890         (TestHttpServer.test_win32_start_and_stop.mock_returns.return_value_thunk):
2891
2892 2013-01-14  Nico Weber  <thakis@chromium.org>
2893
2894         [chromium] Enable `update-webkit --chromium --ninja` on windows
2895         https://bugs.webkit.org/show_bug.cgi?id=106836
2896
2897         Reviewed by Eric Seidel.
2898
2899         After running this, build-webkit --chromium will use ninja to build.
2900         Apparently there are some minor issues with that still, so it's
2901         not quite ready for use yet.
2902
2903         * Scripts/webkitdirs.pm:
2904         (determineIsChromiumNinja):
2905         (buildChromium):
2906
2907 2013-01-14  Dirk Pranke  <dpranke@chromium.org>
2908
2909         nrwt: use the same search path for baselines and TestExpectations on apple mac
2910         https://bugs.webkit.org/show_bug.cgi?id=105599
2911
2912         Reviewed by Ryosuke Niwa.
2913
2914         Bug 105583 revealed some confusion due to the fact that the Apple
2915         Mac port used a different list of directories to search for baselines
2916         and TestExpectations files (actually, pretty much every port does).
2917
2918         It seems like a good idea to use the same list for both by default, but
2919         making this happen will affect every port in slightly different ways, so
2920         we'll try this on the Apple Mac port first.
2921
2922         Note that the effective changes for this are that:
2923         1) The apple mac port will look in platform/wk2 for baselines where
2924         it didn't before (it will look after looking in mac-wk2 but before
2925         the non-wk2 dirs)
2926         2) The apple mac-snowleopard port will use the expectations in
2927         mac-lion as well as the expectations in mac-snowleopard, although
2928         I'm not even sure if mac-snowleopard is still supported ...
2929
2930         * Scripts/webkitpy/layout_tests/port/mac.py:
2931         (MacPort.default_baseline_search_path):
2932         (MacPort.expectations_files):
2933         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2934         (test_baseline_search_path):
2935
2936 2013-01-14  Dominic Mazzoni  <dmazzoni@google.com>
2937
2938         AX: Need to implement ColorWellRole
2939         https://bugs.webkit.org/show_bug.cgi?id=106756
2940
2941         Reviewed by Chris Fleizach.
2942
2943         Returns a string representation of the value of a color
2944         when the role is Color Well, to make it easy to write layout
2945         tests for color controls.
2946
2947         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
2948
2949 2013-01-14  Dominic Mazzoni  <dmazzoni@google.com>
2950
2951         Chromium: Error in AccessibilityUIElement::intValueGetterCallback
2952         https://bugs.webkit.org/show_bug.cgi?id=106682
2953
2954         Reviewed by Chris Fleizach.
2955
2956         Modify Chromium's DRT implementation of intValue to return a
2957         different value depending on the role.
2958
2959         There are actually platform-specific differences in what should
2960         be returned in the "value" of an object, so Chromium normally keeps
2961         these separate (i.e. valueForRange, headingLevel, hierarchicalLevel, etc.)
2962         but this is a fine simplification to make cross-platform tests easier.
2963
2964         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
2965         (WebTestRunner::AccessibilityUIElement::intValueGetterCallback):
2966
2967 2013-01-14  Jochen Eisinger  <jochen@chromium.org>
2968
2969         [chromium] move remaining methods to dump WebViewClient callbacks to TestRunner library
2970         https://bugs.webkit.org/show_bug.cgi?id=106785
2971
2972         Reviewed by Adam Barth.
2973
2974         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2975         (DRTTestRunner::DRTTestRunner):
2976         (DRTTestRunner::reset):
2977         * DumpRenderTree/chromium/DRTTestRunner.h:
2978         (DRTTestRunner):
2979         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
2980         (WebTestProxyBase):
2981         (WebTestRunner::WebTestProxy::setStatusText):
2982         (WebTestRunner::WebTestProxy::didStopLoading):
2983         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
2984         (WebTestRunner::WebTestRunner::shouldDumpStatusCallbacks):
2985         (WebTestRunner::WebTestRunner::shouldDumpProgressFinishedCallback):
2986         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2987         (WebTestRunner::TestRunner::TestRunner):
2988         (WebTestRunner::TestRunner::reset):
2989         (WebTestRunner::TestRunner::shouldDumpStatusCallbacks):
2990         (WebTestRunner):
2991         (WebTestRunner::TestRunner::shouldDumpProgressFinishedCallback):
2992         (WebTestRunner::TestRunner::dumpWindowStatusChanges):
2993         (WebTestRunner::TestRunner::dumpProgressFinishedCallback):
2994         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2995         (TestRunner):
2996         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
2997         (WebTestRunner::WebTestProxyBase::setStatusText):
2998         (WebTestRunner):
2999         (WebTestRunner::WebTestProxyBase::didStopLoading):
3000         * DumpRenderTree/chromium/WebViewHost.cpp:
3001         (WebViewHost::didStopLoading):
3002         * DumpRenderTree/chromium/WebViewHost.h:
3003         (WebViewHost):
3004
3005 2013-01-14  Andrey Lushnikov  <lushnikov@chromium.org>
3006
3007         Web Inspector: devtools front-end doesn't have focus in TestShell
3008         https://bugs.webkit.org/show_bug.cgi?id=106778
3009
3010         Reviewed by Pavel Feldman.
3011
3012         Focus devTools window after loadURL method.
3013
3014         * DumpRenderTree/chromium/TestShell.cpp:
3015         (TestShell::runFileTest):
3016
3017 2013-01-14  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
3018
3019         [EFL][jhbuild] Build the GStreamer-related dependencies with the "configure" script
3020         https://bugs.webkit.org/show_bug.cgi?id=106573
3021
3022         Reviewed by Philippe Normand.
3023
3024         Similarly to what's been described in bug 106569, we're building
3025         from release tarballs, so there's no reason to regenerate the
3026         autoconf-related stuff with autogen.sh, especially since we might
3027         run into trouble with automake 1.13 and deprecated macros.
3028
3029         * efl/jhbuild.modules:
3030
3031 2013-01-14  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
3032
3033         [Qt] The Qt's configuration isn't honoured regarding the use of the system libpng and libjpeg
3034         https://bugs.webkit.org/show_bug.cgi?id=104909
3035
3036         Reviewed by Simon Hausmann.
3037
3038         To be able to build redistribuable binary packages, Qt's configure switches
3039         -qt-libpng and -qt-libjpeg are used to avoid having the binaries trying to
3040         dynamically link to optional system libraries.
3041         QtWebKit is doing its own configure checks for those libraries, thus adding a
3042         runtime dependency that might not be fulfilled if the packager's machine had
3043         those libraries while the user's machine won't.
3044
3045         Since in most cases where WebKit will want to use those system libraries, Qt will
3046         also be using them, remove these configure tests from WebKit.
3047
3048         * qmake/config.tests/libjpeg/libjpeg.cpp: Removed.
3049         * qmake/config.tests/libjpeg/libjpeg.pro: Removed.
3050         * qmake/config.tests/libpng/libpng.cpp: Removed.
3051         * qmake/config.tests/libpng/libpng.pro: Removed.
3052         * qmake/mkspecs/features/features.prf:
3053
3054 2013-01-09  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
3055
3056         [EFL][jhbuild] Bump the EFL dependencies in jhbuild to 1.7.5.
3057         https://bugs.webkit.org/show_bug.cgi?id=106574
3058
3059         Reviewed by Laszlo Gombos.
3060
3061         Rely on a more recent stable release, which includes support for
3062         Lua 5.2 in Edje and other assorted minor fixes.
3063
3064         While here, also use the "configure" script to build the libraries
3065         instead of relying on autogen.sh, which is not really needed with
3066         a release tarball and may have problems with automake 1.13.
3067
3068         * efl/jhbuild.modules:
3069
3070 2013-01-14  Andrey Lushnikov  <lushnikov@chromium.org>
3071
3072         Web Inspector: fix DRT to deliver simulated events to devtools front-end
3073         https://bugs.webkit.org/show_bug.cgi?id=106650
3074
3075         Reviewed by Pavel Feldman.
3076
3077         Add separated m_devToolsTestInterfaces object to testShell which is
3078         bind to devTools webview.
3079
3080         * DumpRenderTree/chromium/TestShell.cpp:
3081         (TestShell::initialize):
3082         (TestShell::createMainWindow):
3083         (TestShell::~TestShell):
3084         (TestShell::showDevTools):
3085         (TestShell::resetTestController):
3086         (TestShell::bindJSObjectsToWindow):
3087         (TestShell::createNewWindow):
3088         * DumpRenderTree/chromium/TestShell.h:
3089         (TestShell):
3090
3091 2013-01-14  Alan Cutter  <alancutter@chromium.org>
3092
3093         Sheriffbot command aliases need test cases
3094         https://bugs.webkit.org/show_bug.cgi?id=106754
3095
3096         Reviewed by Eric Seidel.
3097
3098         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
3099         (SheriffBotTest.test_command_aliases):
3100
3101 2013-01-13  Alan Cutter  <alancutter@chromium.org>
3102
3103         Allow users to misspell the "sheriffs" command in sheriffbot
3104         https://bugs.webkit.org/show_bug.cgi?id=106628
3105
3106         Reviewed by Steve Block.
3107
3108         * Scripts/webkitpy/tool/bot/irc_command.py:
3109
3110 2013-01-13  Alan Cutter  <alancutter@chromium.org>
3111
3112         Make "gardeners" an alias for "sheriffs" in sherrifbot
3113         https://bugs.webkit.org/show_bug.cgi?id=106627
3114
3115         Reviewed by Eric Seidel.
3116
3117         * Scripts/webkitpy/tool/bot/irc_command.py:
3118
3119 2013-01-13  Dirk Pranke  <dpranke@chromium.org>
3120
3121         [chromium] webkitpy-test: executive.py stringify_args error on the release test bot
3122         https://bugs.webkit.org/show_bug.cgi?id=105380
3123
3124         Reviewed by Eric Seidel.
3125
3126         Fix a regression introduced in r137692 where we were double-encoding
3127         the arguments to popen(); this was only an issue on windows, where
3128         we would try to encode something to mbcs, then try to encode it
3129         to unicode as if the input as ascii.
3130
3131         * Scripts/webkitpy/common/system/executive.py:
3132         (Executive.run_command):
3133
3134 2013-01-13  Alan Cutter  <alancutter@chromium.org>
3135
3136         State who told sheriffbot to roll the Chromium deps and to what revision
3137         https://bugs.webkit.org/show_bug.cgi?id=106626
3138
3139         Reviewed by Eric Seidel.
3140
3141         Added optional argument to post-chromium-deps-roll so Sheriffbot can specify ChangeLog message.
3142
3143         * Scripts/webkitpy/tool/bot/irc_command.py:
3144         (RollChromiumDEPS._expand_irc_nickname):
3145         (RollChromiumDEPS.execute):
3146         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
3147         (IRCCommandTest.test_roll_chromium_deps):
3148         * Scripts/webkitpy/tool/bot/sheriff.py:
3149         (Sheriff.post_chromium_deps_roll):
3150         * Scripts/webkitpy/tool/commands/roll.py:
3151         (RollChromiumDEPS._prepare_state):
3152         (PostChromiumDEPSRoll):
3153         (PostChromiumDEPSRoll._prepare_state):
3154         * Scripts/webkitpy/tool/commands/roll_unittest.py:
3155         (PostRollCommandsTest.test_prepare_state):
3156         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py:
3157         (PrepareChangeLogForDEPSRoll.run):
3158
3159 2013-01-13  Alan Cutter  <alancutter@chromium.org>
3160
3161         Add Alan Cutter as contributor
3162         https://bugs.webkit.org/show_bug.cgi?id=106747
3163
3164         Reviewed by Eric Seidel.
3165
3166         * Scripts/webkitpy/common/config/committers.py:
3167
3168 2013-01-13  Jonathan Liu  <net147@gmail.com>
3169
3170         Fix CONFIG missing link_pkgconfig on Windows
3171         https://bugs.webkit.org/show_bug.cgi?id=106647
3172
3173         Some libraries (e.g. libxslt, libxml2 and sqlite3) fail to link
3174         properly on Windows because they are added to PKGCONFIG but
3175         CONFIG does not contain link_pkgconfig.
3176
3177         This is because link_pkgconfig is added in unix/default_pre.prf
3178         which is only used for UNIX platforms. To fix this, move it to
3179         the general default_pre.prf.
3180
3181         Reviewed by Simon Hausmann.
3182
3183         * qmake/mkspecs/features/default_pre.prf:
3184         * qmake/mkspecs/features/unix/default_pre.prf:
3185
3186 2013-01-12  Nico Weber  <thakis@chromium.org>
3187
3188         nrwt/chromium: Don't prefer chromium over webkit build directories
3189         https://bugs.webkit.org/show_bug.cgi?id=105597
3190
3191         Reviewed by Dirk Pranke.
3192
3193         Rely on the new timestamp logic instead. Requested by dpranke in
3194         https://bugs.webkit.org/show_bug.cgi?id=105498
3195
3196         * Scripts/webkitpy/layout_tests/port/chromium.py:
3197         (ChromiumPort._static_build_path):
3198         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
3199         (ChromiumLinuxPortTest.test_build_path):
3200         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
3201         (ChromiumMacPortTest.test_build_path):
3202         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
3203         (ChromiumWinTest.test_build_path):
3204
3205 2013-01-12  Nico Weber  <thakis@chromium.org>
3206
3207         Use ninja by default on Linux for build-webkit --chromium, bot edition
3208         https://bugs.webkit.org/show_bug.cgi?id=104434
3209
3210         Reviewed by Eric Seidel.
3211
3212         r139557 changed update-webkit to pick ninja by default on linux, but
3213         the bots run update-webkit-chromium directly so they didn't see this.
3214         Move the default for ninja into update-webkit-chromium so that it's
3215         picked up by the bots, and let update-webkit forward non-default
3216         options to there.
3217
3218         This way, the default is in one place only and both developers (who
3219         usually use update-webkit which then shells out to
3220         updat-webkit-chromium) and bots (which use update-webkit-chromium
3221         directly) see the same behavior.
3222
3223         * Scripts/update-webkit:
3224         * Scripts/update-webkit-chromium:
3225
3226 2013-01-12  Nico Weber  <thakis@chromium.org>
3227
3228         Make ninja the default build system on Linux for build-webkit --chromium
3229         https://bugs.webkit.org/show_bug.cgi?id=104434
3230
3231         Reviewed by Eric Seidel.
3232
3233         * Scripts/update-webkit:
3234
3235 2013-01-12  Alan Cutter  <alancutter@chromium.org>
3236
3237         Migrate the remaining bots in EC2 to Google Compute Engine
3238         https://bugs.webkit.org/show_bug.cgi?id=106005
3239
3240         Reviewed by Eric Seidel.
3241
3242         Updated bot scripts for launching feeder-queue, style-queue and sheriffbot on GCE.
3243
3244         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh: Copied from Tools/EWSTools/build-repo.sh.
3245         * EWSTools/boot.sh:
3246         * EWSTools/build-repo.sh:
3247         * EWSTools/start-queue.sh:
3248
3249 2013-01-12  Jochen Eisinger  <jochen@chromium.org>
3250
3251         [chromium] move inspector related methods to TestRunner library
3252         https://bugs.webkit.org/show_bug.cgi?id=106654
3253
3254         Reviewed by Adam Barth.
3255
3256         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3257         (DRTTestRunner::DRTTestRunner):
3258         * DumpRenderTree/chromium/DRTTestRunner.h:
3259         (DRTTestRunner):
3260         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
3261         (WebTestRunner::WebTestDelegate::showDevTools):
3262         (WebTestRunner::WebTestDelegate::closeDevTools):
3263         (WebTestRunner::WebTestDelegate::evaluateInWebInspector):
3264         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3265         (WebTestRunner::TestRunner::TestRunner):
3266         (WebTestRunner::TestRunner::showWebInspector):
3267         (WebTestRunner):
3268         (WebTestRunner::TestRunner::closeWebInspector):
3269         (WebTestRunner::TestRunner::evaluateInWebInspector):
3270         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3271         (TestRunner):
3272         * DumpRenderTree/chromium/WebViewHost.cpp:
3273         (WebViewHost::showDevTools):
3274         (WebViewHost::closeDevTools):
3275         (WebViewHost::evaluateInWebInspector):
3276         * DumpRenderTree/chromium/WebViewHost.h:
3277         (WebViewHost):
3278
3279 2013-01-11  Julie Parent  <jparent@chromium.org>
3280
3281         Builder should not be a valid parameter for stats dashboard
3282         https://bugs.webkit.org/show_bug.cgi?id=106698
3283
3284         Reviewed by Dirk Pranke.
3285
3286         Since builder is a dashboard specific parameter, dashboard_base
3287         should not be handling it in handleValidHashParameterWrapper, rather,
3288         each specific dashboard should in its handleValidHashParameter function.
3289
3290         Note that the FIXME in dashboard_base about this was actually wrong -
3291         we don't want to move it to g_crossDashboardState, because it isn't
3292         actually cross dashboard state.
3293
3294         In fact, flakiness and treemap have the code in
3295         handleValidHashParameter, but it is currently dead code because
3296         dashboard_base gets to it first.
3297
3298         Added the proper handling to timeline_explorer, since builder is
3299         valid there.
3300
3301         * TestResultServer/static-dashboards/dashboard_base.js:
3302         * TestResultServer/static-dashboards/timeline_explorer.html:
3303
3304 2013-01-11  Ryosuke Niwa  <rniwa@webkit.org>
3305
3306         REGRESSION: buildbot mangles error messages with timestamps run-webkit-tests outputs
3307         https://bugs.webkit.org/show_bug.cgi?id=106688
3308
3309         Reviewed by Eric Seidel.
3310
3311         Update the regular expression used to strip the garbage at the beginning.
3312
3313         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3314         (RunWebKitTests.nrwt_log_message_regexp):
3315
3316 2013-01-11  Pratik Solanki  <psolanki@apple.com>
3317
3318         TestRunner leaks when running tests
3319         https://bugs.webkit.org/show_bug.cgi?id=106683
3320
3321         Reviewed by Simon Fraser.
3322
3323         Remove extra ref() that we missed out on deleting when refactoring window.layoutTestController
3324         to window.testRunner in r124705. This caused the TestRunner object to be leaked when running
3325         tests.
3326
3327         * DumpRenderTree/TestRunner.cpp:
3328         (TestRunner::makeWindowObject):
3329
3330 2013-01-11  Julie Parent  <jparent@chromium.org>
3331
3332         Dashboard Cleanup: Add isLoadingComplete to the loader.Loader object.
3333         https://bugs.webkit.org/show_bug.cgi?id=106247
3334
3335         Old code nulled out the loader instance when it completed loading and
3336         then later used the fact that it was null to determine if it had loaded
3337         or not.  This is not only unintuitive, but it also prevents using the
3338         loader object later on.
3339
3340         Added new method, used it, added unit test for it.
3341
3342         Reviewed by Dirk Pranke.
3343
3344         * TestResultServer/static-dashboards/dashboard_base.js:
3345         (resourceLoadingComplete):
3346         (handleLocationChange):
3347         * TestResultServer/static-dashboards/loader.js:
3348         (.):
3349         * TestResultServer/static-dashboards/loader_unittests.js:
3350
3351 2013-01-11  Ryosuke Niwa  <rniwa@webkit.org>
3352
3353         Try CRLF to LF change in r139407 again.
3354
3355         * BuildSlaveSupport/delete-stale-build-files:
3356         (main):
3357         (webkitBuildDirectory):
3358         * BuildSlaveSupport/kill-old-processes:
3359         (main):
3360
3361 2013-01-11  Carlos Garcia Campos  <cgarcia@igalia.com>
3362
3363         [GTK] Disable the unit tests timeout when running from make check
3364         https://bugs.webkit.org/show_bug.cgi?id=106670
3365
3366         Reviewed by Philippe Normand.
3367
3368         * GNUmakefile.am: Pass --timeout=-1 to run-gtk-test.
3369
3370 2013-01-11  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
3371
3372         Yet another unreviewed fix after r139431.
3373
3374         * Scripts/run-launcher: Pass the arguments to `jhbuild-wrapper' in
3375         the correct order.
3376
3377 2013-01-11  Dan Carney  <dcarney@google.com>
3378
3379         [chromium] move some whitespace and resize related methods to TestRunner library
3380         https://bugs.webkit.org/show_bug.cgi?id=106655
3381
3382         Reviewed by Jochen Eisinger.
3383
3384         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3385         (DRTTestRunner::DRTTestRunner):
3386         * DumpRenderTree/chromium/DRTTestRunner.h:
3387         (DRTTestRunner):
3388         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
3389         (WebKit):
3390         (WebTestRunner::WebTestDelegate::setClientWindowRect):
3391         (WebTestRunner::WebTestDelegate::setSelectTrailingWhitespaceEnabled):
3392         (WebTestRunner::WebTestDelegate::setSmartInsertDeleteEnabled):
3393         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3394         (WebTestRunner::TestRunner::TestRunner):
3395         (WebTestRunner::TestRunner::setSmartInsertDeleteEnabled):
3396         (WebTestRunner):
3397         (WebTestRunner::TestRunner::setSelectTrailingWhitespaceEnabled):
3398         (WebTestRunner::TestRunner::enableAutoResizeMode):
3399         (WebTestRunner::TestRunner::disableAutoResizeMode):
3400         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3401         (TestRunner):
3402         * DumpRenderTree/chromium/WebViewHost.cpp:
3403         (WebViewHost::setClientWindowRect):
3404         * DumpRenderTree/chromium/WebViewHost.h:
3405         (WebViewHost):
3406
3407 2013-01-11  Mario Sanchez Prada  <mario.prada@samsung.com>
3408
3409         Unreviewed. Update my e-mail addresses.
3410
3411         * Scripts/webkitpy/common/config/committers.py:
3412
3413 2013-01-11  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
3414
3415         Another unreviewed fix after r139431.
3416
3417         In a way, this is also a generic bug fix, since previously isEfl()
3418         would fail when called from run-efl-tests and we thus did not use
3419         jhbuild to run our tests. This now resulted in us calling
3420         "jhbuild-wrapper run" without specifying a platform.
3421
3422         * Scripts/run-efl-tests: Pass "--efl" to ARGV manually for isEfl()
3423         to work.
3424
3425 2013-01-11  Allan Sandfeld Jensen  <allan.jensen@digia.com>
3426
3427         [Qt][WK1] Web Audio support
3428         https://bugs.webkit.org/show_bug.cgi?id=106651
3429
3430         Reviewed by Jocelyn Turcotte.
3431
3432         Implements support for dumping audio data in DumpRenderTree.
3433
3434         Adds WebAudio to toggleable features in QtTestBrowser.
3435
3436         Enables LEGACY_WEB_AUDIO. This feature is required for 2/3 of the web audio regression tests. It is enabled by default
3437         because it has no effect when WEB_AUDIO is not enabled. This combination matches the settings in FeatureList.pm.
3438
3439         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3440         (WebCore::DumpRenderTree::dump):
3441         * DumpRenderTree/qt/TestRunnerQt.cpp:
3442         (TestRunner::reset):
3443         (TestRunner::overridePreference):
3444         (TestRunner::setAudioData):
3445         * DumpRenderTree/qt/TestRunnerQt.h:
3446         (TestRunner::shouldDumpAsAudio):
3447         (TestRunner::audioData):
3448         (TestRunner):
3449         * QtTestBrowser/launcherwindow.cpp:
3450         (LauncherWindow::applyPrefs):
3451         (LauncherWindow::createChrome):
3452         (LauncherWindow::toggleWebAudio):
3453         * QtTestBrowser/launcherwindow.h:
3454         (WindowOptions::WindowOptions):
3455         (WindowOptions):
3456         (LauncherWindow):
3457         * qmake/mkspecs/features/features.prf:
3458         * qmake/mkspecs/features/features.pri:
3459
3460 2013-01-11  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
3461
3462         Unreviewed jhbuild-related fix after r139431.
3463
3464         * Scripts/webkitpy/layout_tests/port/efl.py:
3465         (EflPort.__init__): Pass a string to set_option_default(), since
3466         shlex.split() will be called on it later.
3467
3468 2013-01-11  Csaba Osztrogonác  <ossy@webkit.org>
3469
3470         Unreviewed typo fixes after r139431.
3471
3472         * Scripts/run-javascriptcore-tests:
3473
3474 2013-01-11  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
3475
3476         [jhbuild] Remove the "run-with-jhbuild" scripts.
3477         https://bugs.webkit.org/show_bug.cgi?id=106572
3478
3479         Reviewed by Martin Robinson.
3480
3481         Both ports which use jhbuild were mostly duplicating the
3482         `run-with-jhbuild' script in their own directories for no clear reason.
3483
3484         The script itself was just a thin wrapper around the `jhbuild-wrapper',
3485         so just start using that directly and get rid of a useless middle man.
3486
3487         Adjust scripts which called run-with-jhbuild to call jhbuild-wrapper
3488         instead.
3489
3490         * Scripts/run-javascriptcore-tests:
3491         * Scripts/run-launcher:
3492         * Scripts/webkitdirs.pm:
3493         (runAutogenForAutotoolsProjectIfNecessary):
3494         (buildAutotoolsProject):
3495         (jhbuildWrapperPrefixIfNeeded):
3496         (generateBuildSystemFromCMakeProject):
3497         (buildCMakeGeneratedProject):
3498         * Scripts/webkitpy/common/multiprocessing_bootstrap.py:
3499         (run):
3500         * Scripts/webkitpy/layout_tests/port/efl.py:
3501         (EflPort.__init__):
3502         (EflPort._image_diff_command):
3503         * efl/run-with-jhbuild: Removed.
3504         * gtk/run-with-jhbuild: Removed.
3505
3506 2013-01-11  Alan Cutter  <alancutter@chromium.org>
3507
3508         Allow arbitrary queue launch parameters in EWSTools/start-queue.sh
3509         https://bugs.webkit.org/show_bug.cgi?id=106636
3510
3511         Reviewed by Adam Barth.
3512
3513         This parameter will allow the bot boot script to use start-queue.sh and provide an IRC password for sheriffbot.
3514
3515         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
3516         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
3517         * EWSTools/screen-config:
3518         * EWSTools/start-queue.sh:
3519
3520 2013-01-10  Ryosuke Niwa  <rniwa@webkit.org>
3521
3522         kill-old-processes and delete-stale-build-files use CRLF linebreaks
3523         https://bugs.webkit.org/show_bug.cgi?id=106622
3524
3525         Reviewed by Simon Fraser.
3526
3527         Use LF instead of CRLF in kill-old-processes and delete-stale-build-files.
3528         Also escape clang\+\+ correctly in kill-old-processes.
3529
3530         * BuildSlaveSupport/delete-stale-build-files:
3531         * BuildSlaveSupport/kill-old-processes:
3532
3533 2013-01-10  Ryosuke Niwa  <rniwa@webkit.org>
3534
3535         Build fix after r139357. It was missing a comma.
3536
3537         * QueueStatusServer/model/queues.py:
3538         (Queue):
3539
3540 2013-01-10  Tim 'mithro' Ansell  <mithro@mithis.com>
3541
3542         Fixing AuthenticationError when running test-webkitpy as a non-committer.
3543         https://bugs.webkit.org/show_bug.cgi?id=106420
3544
3545         Reviewed by Eric Seidel.
3546
3547         * Scripts/webkitpy/common/checkout/scm/git.py:
3548         (Git.push_local_commits_to_server):
3549         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3550         * Scripts/webkitpy/common/checkout/scm/svn.py:
3551         (SVNRepository):
3552         (SVNRepository.has_authorization_for_realm):
3553
3554 2013-01-10  Christophe Dumez  <christophe.dumez@intel.com>
3555
3556         [EFL][jhbuild] Use tarballs for gstreamer instead of git
3557         https://bugs.webkit.org/show_bug.cgi?id=106552
3558
3559         Reviewed by Laszlo Gombos.
3560
3561         Use tarballs for gstreamer instead of git in EFL's jhbuild
3562         to work around intermittent network issues on our build
3563         bots. Tarballs are fully cached and require no network
3564         operation if their checksum matches.
3565
3566         * efl/jhbuild.modules:
3567
3568 2013-01-10  Ryosuke Niwa  <rniwa@webkit.org>
3569
3570         Add Mac WK2 EWS bots
3571         https://bugs.webkit.org/show_bug.cgi?id=106590
3572
3573         Reviewed by Adam Barth.
3574
3575         Added MacWK2EWS, and made myself a watcher for MacEWS and MacWK2EWS.
3576         Also add a deprecated MacWK2Port class.
3577
3578         * QueueStatusServer/model/queues.py:
3579         (Queue):
3580         * Scripts/webkitpy/common/config/ports.py:
3581         (DeprecatedPort.port):
3582         (MacWK2Port):
3583         (MacWK2Port.run_webkit_tests_command):
3584         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3585         (MacEWS):
3586         (MacWK2EWS):
3587         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3588         (_test_ewses):
3589
3590 2013-01-10  Dan Carney  <dcarney@google.com>
3591
3592         [chromium] move webpermissionclient related methods to TestRunner library
3593         https://bugs.webkit.org/show_bug.cgi?id=106548
3594
3595         Reviewed by Jochen Eisinger.
3596
3597         * DumpRenderTree/DumpRenderTree.gypi:
3598         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3599         (DRTTestRunner::DRTTestRunner):
3600         (DRTTestRunner::reset):
3601         * DumpRenderTree/chromium/DRTTestRunner.h:
3602         (DRTTestRunner):
3603         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
3604         (WebTestRunner::WebTestDelegate::normalizeLayoutTestURL):
3605         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
3606         (WebKit):
3607         (WebTestRunner::WebTestRunner::webPermissions):
3608         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3609         (WebTestRunner::TestRunner::TestRunner):
3610         (WebTestRunner::TestRunner::setDelegate):
3611         (WebTestRunner):
3612         (WebTestRunner::TestRunner::reset):
3613         (WebTestRunner::TestRunner::webPermissions):
3614         (WebTestRunner::TestRunner::dumpPermissionClientCallbacks):
3615         (WebTestRunner::TestRunner::setImagesAllowed):
3616         (WebTestRunner::TestRunner::setScriptsAllowed):
3617         (WebTestRunner::TestRunner::setStorageAllowed):
3618         (WebTestRunner::TestRunner::setPluginsAllowed):
3619         (WebTestRunner::TestRunner::setAllowDisplayOfInsecureContent):
3620         (WebTestRunner::TestRunner::setAllowRunningOfInsecureContent):
3621         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3622         (WebTestRunner):
3623         (TestRunner):
3624         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.cpp: Renamed from Tools/DumpRenderTree/chromium/WebPermissions.cpp.
3625         (WebTestRunner):
3626         (WebTestRunner::WebPermissions::WebPermissions):
3627         (WebTestRunner::WebPermissions::~WebPermissions):
3628         (WebTestRunner::WebPermissions::allowImage):
3629         (WebTestRunner::WebPermissions::allowScriptFromSource):
3630         (WebTestRunner::WebPermissions::allowStorage):
3631         (WebTestRunner::WebPermissions::allowPlugins):
3632         (WebTestRunner::WebPermissions::allowDisplayingInsecureContent):
3633         (WebTestRunner::WebPermissions::allowRunningInsecureContent):
3634         (WebTestRunner::WebPermissions::setImagesAllowed):
3635         (WebTestRunner::WebPermissions::setScriptsAllowed):
3636         (WebTestRunner::WebPermissions::setStorageAllowed):
3637         (WebTestRunner::WebPermissions::setPluginsAllowed):
3638         (WebTestRunner::WebPermissions::setDisplayingInsecureContentAllowed):
3639         (WebTestRunner::WebPermissions::setRunningInsecureContentAllowed):
3640         (WebTestRunner::WebPermissions::setDelegate):
3641         (WebTestRunner::WebPermissions::setDumpCallbacks):
3642         (WebTestRunner::WebPermissions::reset):
3643         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.h: Renamed from Tools/DumpRenderTree/chromium/WebPermissions.h.
3644         (WebTestRunner):
3645         (WebPermissions):
3646         * DumpRenderTree/chromium/TestShell.cpp:
3647         (TestShell::initialize):
3648         (TestShell::resetTestController):
3649         (TestShell::createNewWindow):
3650         * DumpRenderTree/chromium/TestShell.h:
3651         (TestShell):
3652         * DumpRenderTree/chromium/WebViewHost.cpp:
3653         (WebViewHost::normalizeLayoutTestURL):
3654         * DumpRenderTree/chromium/WebViewHost.h:
3655         (WebViewHost):
3656
3657 2013-01-10  Alan Cutter  <alancutter@chromium.org>
3658
3659         Split EWS tool cold-boot.sh into modular components
3660         https://bugs.webkit.org/show_bug.cgi?id=106527
3661
3662         Reviewed by Adam Barth.
3663
3664         Split cold-boot.sh script up into build-vm.sh, build-repo.sh and build-boot-cmd.sh.
3665         Updated GCE bot build scripts to match.
3666         Unable to test scripts directly as they depend on being in the repository to work!
3667
3668         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
3669         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
3670         * EWSTools/build-boot-cmd.sh: Copied from Tools/EWSTools/GoogleComputeEngine/build-chromium-ews.sh.
3671         * EWSTools/build-repo.sh: Copied from Tools/EWSTools/cold-boot.sh.
3672         * EWSTools/build-vm.sh: Renamed from Tools/EWSTools/cold-boot.sh.
3673
3674 2013-01-10  Julie Parent  <jparent@chromium.org>
3675
3676         Dashboard Cleanup: Do not generate the page if we are about to reload.
3677         https://bugs.webkit.org/show_bug.cgi?id=106584
3678
3679         Reviewed by Dirk Pranke.
3680
3681         Move the logic to determine if we should generate the page into
3682         parseParameters() since that is where we have the knowledge to
3683         determine it, and return that value to handleLocationChange,