Universal links from Google search results pages don't open the app.
[WebKit-https.git] / Tools / ChangeLog
1 2019-02-27  Brady Eidson  <beidson@apple.com>
2
3         Universal links from Google search results pages don't open the app.
4         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
5
6         Reviewed by Geoffrey Garen.
7
8         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
9         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
10         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
11         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
12
13 2019-02-27  Chris Dumez  <cdumez@apple.com>
14
15         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
16         https://bugs.webkit.org/show_bug.cgi?id=195102
17
18         Reviewed by Geoffrey Garen.
19
20         If the number of processes is not yet what we expect, wait a bit and check again to give
21         processes some time to exit.
22
23         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
24
25 2019-02-27  Chris Dumez  <cdumez@apple.com>
26
27         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
28         https://bugs.webkit.org/show_bug.cgi?id=194545
29
30         Reviewed by Brady Eidson.
31
32         Make sure the test navigates forward and then back only once. Previously, navigating
33         back would trigger a navigation again in a timer.
34
35         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
36
37 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
38
39         High Sierra Debug JSC test queue should use faster hardware
40         https://bugs.webkit.org/show_bug.cgi?id=194603
41
42         Rubber-stamped by Alexey Proskuryakov.
43
44         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
45
46         * BuildSlaveSupport/build.webkit.org-config/config.json:
47         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
48         (BubbleQueueServer):
49         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
50         (WebKitBuildbot):
51         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
52         * QueueStatusServer/config/queues.py:
53         * Scripts/webkitpy/common/config/ews.json:
54         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
55         (test_ews_name):
56
57 2019-02-27  John Wilander  <wilander@apple.com>
58
59         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
60         https://bugs.webkit.org/show_bug.cgi?id=195071
61         <rdar://problem/48417690>
62
63         Reviewed by Alex Christensen and Brent Fulgham.
64
65         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
66         (TestWebKitAPI::createURL):
67             Convenience function.
68         (TestWebKitAPI::TEST):
69             WebCore::AdClickAttribution now takes a URL when creating Source and
70             Destination.
71         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
72         (TestWebKitAPI::TEST):
73             WebCore::AdClickAttribution now takes a URL when creating Source and
74             Destination.
75
76 2019-02-27  Antoine Quint  <graouts@apple.com>
77
78         Support Pointer Events on macOS
79         https://bugs.webkit.org/show_bug.cgi?id=195008
80         <rdar://problem/47454419>
81
82         Reviewed by Dean Jackson.
83
84         * DumpRenderTree/mac/DumpRenderTree.mm:
85         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
86         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
87
88 2019-02-26  Mark Lam  <mark.lam@apple.com>
89
90         Remove remaining poisoning code.
91         https://bugs.webkit.org/show_bug.cgi?id=194138
92
93         Reviewed by Saam Barati.
94
95         * TestWebKitAPI/CMakeLists.txt:
96         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
97         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
98         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
99         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
100         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
101         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
102         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
103
104 2019-02-26  Alex Christensen  <achristensen@webkit.org>
105
106         Move ephemeral local storage from WebProcess to UIProcess
107         https://bugs.webkit.org/show_bug.cgi?id=195074
108         <rdar://problem/47937975>
109
110         Reviewed by Geoff Garen.
111
112         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
113
114 2019-02-20  Jer Noble  <jer.noble@apple.com>
115
116         [Cocoa] Media elements will restart network buffering just before suspending
117         https://bugs.webkit.org/show_bug.cgi?id=193691
118
119         Reviewed by Eric Carlson.
120
121         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
122         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
123         (TEST):
124
125 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
126
127         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
128         https://bugs.webkit.org/show_bug.cgi?id=191652
129
130         Reviewed by Alex Christensen.
131
132         Fix WinCairo MiniBrowser behavior of authentication dialog.
133
134         * MiniBrowser/win/WebKitBrowserWindow.cpp:
135         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
136
137 2019-02-26  Youenn Fablet  <youenn@apple.com>
138
139         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
140         https://bugs.webkit.org/show_bug.cgi?id=195028
141         <rdar://problem/48243733>
142
143         Reviewed by Eric Carlson.
144
145         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
146
147 2019-02-26  Philippe Normand  <pnormand@igalia.com>
148
149         [WPE] Add API for webview background color configuration
150         https://bugs.webkit.org/show_bug.cgi?id=192305
151
152         Reviewed by Michael Catanzaro.
153
154         * MiniBrowser/wpe/main.cpp:
155         (main): Add a new option to configure the webview background
156         color. Example: --bg-color=transparent.
157         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
158         (testWebViewBackgroundColor): Enable background color API tests for WPE.
159         (beforeAll): Ditto.
160
161 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
162
163         scalableNativeWebpageParameters() is not preserved on new page navigation.
164         https://bugs.webkit.org/show_bug.cgi?id=194892
165         <rdar://problem/47538280>
166
167         Reviewed by Wenson Hsieh.
168         
169         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
170
171         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
172         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
173         * DumpRenderTree/mac/UIScriptControllerMac.mm:
174         (WTR::UIScriptController::allowsViewportShrinkToFit):
175         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
176         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
177         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
178         * TestRunnerShared/UIScriptContext/UIScriptController.h:
179         * WebKitTestRunner/UIScriptControllerCocoa.mm:
180         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
181
182 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
183
184         [ews-app] Add model for handling multiple Buildbot instances
185         https://bugs.webkit.org/show_bug.cgi?id=194863
186
187         Reviewed by Stephanie Lewis.
188
189         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
190
191 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
192
193         [ews-app] Remove BuilderMapping table
194         https://bugs.webkit.org/show_bug.cgi?id=194961
195
196         Reviewed by Stephanie Lewis.
197
198         Store builder name directly in build table, instead of having a separate
199         table for it.
200
201         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
202         * BuildSlaveSupport/ews-app/ews/models/build.py:
203         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
204         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
205
206 2019-02-25  John Wilander  <wilander@apple.com>
207
208         Introduce and adopt new class RegistrableDomain for eTLD+1
209         https://bugs.webkit.org/show_bug.cgi?id=194791
210         <rdar://problem/48179240>
211
212         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
213
214         This patch adds an API test and replaces two instances of
215         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
216
217         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
218         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
219         (TestWebKitAPI::TEST):
220             Changed two strings to make sure the registrable domains are still considered
221             invalid and pass the test.
222         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
223         (TestWebKitAPI::TEST):
224         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
225         (WTR::InjectedBundle::didReceiveMessageToPage):
226
227 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
228
229         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
230         https://bugs.webkit.org/show_bug.cgi?id=195001
231
232         Reviewed by Carlos Garcia Campos.
233
234         API version 1.0 always includes the functionality previously guarded with
235         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
236         unconditionally.
237
238         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
239         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
240         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
241         (WebViewTest::showInWindow): Ditto.
242         (WebViewTest::hideView): Ditto.
243         * wpe/backends/HeadlessViewBackend.cpp:
244         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
245         * wpe/backends/ViewBackend.cpp:
246         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
247         * wpe/backends/WindowViewBackend.cpp:
248         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
249         WPE_BACKEND_CHECK_VERSION().
250         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
251
252 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
253
254         [Flatpak] Add support for flatpak > 1.1.2
255         https://bugs.webkit.org/show_bug.cgi?id=194088
256
257         Flatpak 1.2 is now out so we need to support that
258         version now.
259
260         Reviewed by Michael Catanzaro.
261
262         * flatpak/flatpakutils.py:
263         (check_flatpak):
264         (FlatpakPackages.__init__):
265         (FlatpakPackages.__detect_packages):
266         (FlatpakPackages.__detect_packages.in):
267         (FlatpakRepos.update):
268
269 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
270
271         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
272         https://bugs.webkit.org/show_bug.cgi?id=194998
273
274         Reviewed by Carlos Garcia Campos.
275
276         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
277         to a Git checkout and using the latest commit containing various fixes
278         and improvements.
279
280 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
281
282         [WPE][GTK] Remove user agent quirk for washingtonpost.com
283         https://bugs.webkit.org/show_bug.cgi?id=194981
284
285         Reviewed by Žan Doberšek.
286
287         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
288         (TestWebKitAPI::TEST):
289
290 2019-02-23  Keith Miller  <keith_miller@apple.com>
291
292         Add new mac target numbers
293         https://bugs.webkit.org/show_bug.cgi?id=194955
294
295         Reviewed by Tim Horton.
296
297         * DumpRenderTree/mac/Configurations/Base.xcconfig:
298         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
299         * MiniBrowser/Configurations/Base.xcconfig:
300         * TestWebKitAPI/Configurations/Base.xcconfig:
301         * WebKitTestRunner/Configurations/Base.xcconfig:
302
303 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
304
305         [WinCairo] Enable wk1/wk2 suffix for platform search path.
306         https://bugs.webkit.org/show_bug.cgi?id=194846
307
308         Reviewed by Don Olmstead.
309
310         Added _search_paths() and _port_specific_expectations_files() for
311         WinCairoPort.
312
313         * Scripts/webkitpy/port/win.py:
314         (WinCairoPort.default_baseline_search_path):
315         (WinCairoPort):
316         (WinCairoPort._port_specific_expectations_files):
317         (WinCairoPort._search_paths):
318
319 2019-02-22  Tim Horton  <timothy_horton@apple.com>
320
321         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
322         https://bugs.webkit.org/show_bug.cgi?id=194963
323
324         Reviewed by Dean Jackson.
325
326         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
327         Do a `contains` check instead of `equals`, because in debug builds we
328         put the GraphicsLayer pointer in a prefix.
329
330 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
331
332         [iOS] Callout menu overlaps in-page controls when editing a comment in github.com's issue tracker
333         https://bugs.webkit.org/show_bug.cgi?id=194873
334         <rdar://problem/46701974>
335
336         Reviewed by Tim Horton.
337
338         Add a couple of UIScriptController methods to make callout menu testing on iOS easier (see below).
339
340         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
341         (WTR::UIScriptController::menuRect const):
342         (WTR::UIScriptController::isShowingMenu const):
343         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
344         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
345         (WTR::UIScriptController::menuRect const):
346
347         Add a function to query the bounds of the callout menu in content coordinates.
348
349         (WTR::UIScriptController::isShowingMenu const):
350
351         Add a function to query whether the callout menu is shown (i.e., has finished its appearance animation).
352
353         * TestRunnerShared/UIScriptContext/UIScriptController.h:
354         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
355         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
356         (WTR::UIScriptController::rectForMenuAction const):
357         (WTR::UIScriptController::menuRect const):
358         (WTR::UIScriptController::isShowingMenu const):
359         (WTR::findViewInHierarchyOfType): Deleted.
360
361 2019-02-22  Chris Dumez  <cdumez@apple.com>
362
363         Regression(PSON) Unable to preview password-protected documents on iCloud.com
364         https://bugs.webkit.org/show_bug.cgi?id=194954
365         <rdar://problem/48127957>
366
367         Reviewed by Alex Christensen.
368
369         Add API test coverage.
370
371         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
372         (-[PSONNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
373         (-[PSONNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
374         (-[PSONNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
375
376 2019-02-22  Chris Dumez  <cdumez@apple.com>
377
378         REGRESSION(PSON) Scroll position is sometimes not restored on history navigation
379         https://bugs.webkit.org/show_bug.cgi?id=194924
380         <rdar://problem/48216125>
381
382         Reviewed by Geoffrey Garen.
383
384         Add API test coverage.
385
386         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
387
388 2019-02-22  Chris Dumez  <cdumez@apple.com>
389
390         Unreviewed, disable API test added in r241928 on iOS.
391
392         The cache is not enabled on devices with less than 3GB of RAM.
393
394         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
395
396 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
397
398         Hardcode Visual Viewports on everywhere except iOS WK1
399         https://bugs.webkit.org/show_bug.cgi?id=194928
400
401         Reviewed by Zalan Bujtas.
402
403         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
404         change the default value of the Setting to 'true', and hardcode WebView on iOS to
405         set it to false. The setting has shipped for several years and there's no need to turn
406         it off now.
407
408         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
409         Visual Viewports are not enabled.
410         
411         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
412         that only runs in WK2
413
414         * MiniBrowser/mac/SettingsController.h:
415         * MiniBrowser/mac/SettingsController.m:
416         (-[SettingsController init]):
417         (-[SettingsController _populateMenu]):
418         (-[SettingsController validateMenuItem:]):
419         (-[SettingsController visualViewportEnabled]): Deleted.
420         (-[SettingsController toggleVisualViewportEnabled:]): Deleted.
421         * MiniBrowser/mac/WK1BrowserWindowController.m:
422         (-[WK1BrowserWindowController didChangeSettings]):
423         * MiniBrowser/mac/WK2BrowserWindowController.m:
424         (-[WK2BrowserWindowController didChangeSettings]):
425
426 2019-02-21  Ryosuke Niwa  <rniwa@webkit.org>
427
428         Discard cached processes when clearing website data store
429         https://bugs.webkit.org/show_bug.cgi?id=194894
430
431         Reviewed by Chris Dumez.
432
433         Added a test case.
434
435         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
436         (TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses): Added.
437
438 2019-02-21  Alex Christensen  <achristensen@webkit.org>
439
440         Clicking "Go Back" on a safe browsing warning before a WKWebView has loaded any page should request to close the WKWebView
441         https://bugs.webkit.org/show_bug.cgi?id=194914
442         <rdar://problem/47586889>
443
444         Reviewed by Geoffrey Garen.
445
446         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
447         (-[SafeBrowsingNavigationDelegate webViewDidClose:]):
448         (TEST):
449         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]): Deleted.
450
451 2019-02-21  David Kilzer  <ddkilzer@apple.com>
452
453         Leak of CFErrorRef objects (1.92 Kbytes) in com.apple.WebKit.WebContent.Development running WebKit layout tests on iOS Simulator
454         <https://webkit.org/b/194761>
455
456         Reviewed by Myles Maxfield.
457
458         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
459         (WTR::activateSystemCoreWebFonts): Log `error` to console if
460         CTFontManagerRegisterFontsForURL() fails (macOS only).  Update
461         to use ARC-compliant cast.
462         (WTR::activateFonts): Change `0` to `nullptr`.  Update to use
463         ARC-compliant cast.
464         (WTR::installFakeHelvetica): Log `error` to console if
465         CTFontManagerRegisterFontsForURL() fails, but only on supported
466         platforms (macOS Mojave/iOS 12 and newer, not iOS Simulator).
467         Call CFRelease() on `error` to fix the leak.  Update to use
468         ARC-compliant cast.
469         (WTR::uninstallFakeHelvetica): Update to use ARC-compliant
470         cast.
471
472 2019-02-21  Chris Dumez  <cdumez@apple.com>
473
474         Flaky API Test: TestWebKitAPI.ProcessSwap.SuspendedPageLimit
475         https://bugs.webkit.org/show_bug.cgi?id=194481
476
477         Reviewed by Alex Christensen.
478
479         Give the processes a chance to shutdown and wait until we reached the expected number
480         of processes.
481
482         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
483
484 2019-02-21  Tim Horton  <timothy_horton@apple.com>
485
486         Fix the macOS build
487
488         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
489
490 2019-02-21  Tim Horton  <timothy_horton@apple.com>
491
492         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
493
494         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
495         I am a backwards.
496
497 2019-02-21  Tim Horton  <timothy_horton@apple.com>
498
499         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
500
501         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
502         We can't find the UI-side layer on macOS because we don't use UI-side compositing.
503         We could force on UI-side compositing, but I feel like the test might be more
504         valuable exercising the normal path on each platform (though the original
505         bug was also UI-side specific). Though we can't validate that the overlay
506         layer was installed successfully, there are layout tests that do that.
507
508 2019-02-21  Tim Horton  <timothy_horton@apple.com>
509
510         Crash under RemoteLayerTreePropertyApplier::applyProperties when reattaching to old process
511         https://bugs.webkit.org/show_bug.cgi?id=194845
512         <rdar://problem/47944579>
513
514         Reviewed by Antti Koivisto.
515
516         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
517         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
518
519 2019-02-21  Zalan Bujtas  <zalan@apple.com>
520
521         [LFC][Floats] Add support for placing formatting roots in-between floats.
522         https://bugs.webkit.org/show_bug.cgi?id=194902
523
524         Reviewed by Antti Koivisto.
525
526         * LayoutReloaded/misc/LFC-passing-tests.txt:
527
528 2019-02-21  Adrian Perez de Castro  <aperez@igalia.com>
529
530         [WPE] Do not hardcode WPEBackend-fdo library name for linking tests
531         https://bugs.webkit.org/show_bug.cgi?id=194901
532
533         Unreviewed build fix.
534
535         * TestWebKitAPI/PlatformWPE.cmake: Set TestWebKitAPIBase to be linked
536         against the detected ${WPEBACKEND_FDO_LIBRARIES} instead of hardcoding
537         WPEBackend-fdo-0.1 as library name.
538
539 2019-02-21  Rob Buis  <rbuis@igalia.com>
540
541         Update MIME type parser
542         https://bugs.webkit.org/show_bug.cgi?id=180526
543
544         Reviewed by Darin Adler.
545
546         Add tests involving leading and trailing whitespace, non-token
547         characters and quoted strings.
548
549         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
550         (TestWebKitAPI::TEST):
551
552 2019-02-20  Don Olmstead  <don.olmstead@sony.com>
553
554         [CMake][Win] Only build DumpRenderTree when WebKit Legacy is enabled
555         https://bugs.webkit.org/show_bug.cgi?id=194884
556
557         Reviewed by Michael Catanzaro.
558
559         * PlatformWin.cmake:
560
561 2019-02-20  Chris Dumez  <cdumez@apple.com>
562
563         Add API test for <rdar://problem/47471222>
564         https://bugs.webkit.org/show_bug.cgi?id=194847
565
566         Reviewed by Alex Christensen.
567
568         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
569
570 2019-02-20  Chris Dumez  <cdumez@apple.com>
571
572         Regression(PSON) "Reload without content extensions" does not work when the main resource is blocked
573         https://bugs.webkit.org/show_bug.cgi?id=194872
574         <rdar://problem/47924500>
575
576         Reviewed by Alex Christensen.
577
578         Add API test coverage.
579
580         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
581
582 2019-02-20  Jer Noble  <jer.noble@apple.com>
583
584         Add a git utility method that allows the caller to determine if a specific commitish is within a specified range of commits.
585         https://bugs.webkit.org/show_bug.cgi?id=191332
586
587         Reviewed by Dean Jackson.
588
589         * Scripts/git-is-in-range: Added.
590
591 2019-02-20  Andy Estes  <aestes@apple.com>
592
593         [Xcode] Add SDKVariant.xcconfig to various Xcode projects
594         https://bugs.webkit.org/show_bug.cgi?id=194869
595
596         Rubber-stamped by Jer Noble.
597
598         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
599         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
600         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
601         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
602         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
603         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
604
605 2019-02-20  Chris Dumez  <cdumez@apple.com>
606
607         Regression(PSON) Crash under WebKit::WebPageProxy::decidePolicyForNavigationActionSync
608         https://bugs.webkit.org/show_bug.cgi?id=194857
609         <rdar://problem/47759323>
610
611         Reviewed by Alex Christensen.
612
613         Add API test coverage.
614
615         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
616
617 2019-02-20  Chris Dumez  <cdumez@apple.com>
618
619         [WKTR] Avoid starting new NetworkProcesses unnecessarily when running the layout tests
620         https://bugs.webkit.org/show_bug.cgi?id=194829
621         <rdar://problem/47889906>
622
623         Reviewed by Alexey Proskuryakov.
624
625         Every time the TestOptions were changing we were creating both a new Web view and
626         a new WKContext, which would start a new Network process. In most cases, we only
627         need to contruct a new Web view and we do can keep reusing the same WKContext.
628         This patch implements this optimization and thus avoids spinning a lot of new
629         Network processes while running the layout tests.
630
631         * WebKitTestRunner/TestController.cpp:
632         (WTR::TestController::generateContextConfiguration const):
633         (WTR::TestController::generatePageConfiguration):
634         (WTR::TestController::createWebViewWithOptions):
635         (WTR::TestController::resetPreferencesToConsistentValues):
636         (WTR::updateTestOptionsFromTestHeader):
637         * WebKitTestRunner/TestController.h:
638         * WebKitTestRunner/TestOptions.h:
639         (WTR::TestOptions::ContextOptions::hasSameInitializationOptions const):
640         (WTR::TestOptions::ContextOptions::shouldEnableProcessSwapOnNavigation const):
641         (WTR::TestOptions::hasSameInitializationOptions const):
642         (WTR::TestOptions::shouldEnableProcessSwapOnNavigation const): Deleted.
643         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
644         (WTR::TestController::platformAddTestOptions const):
645
646 2019-02-20  Adrian Perez de Castro  <aperez@igalia.com>
647
648         [WPE][GTK] Enable support for CONTENT_EXTENSIONS
649         https://bugs.webkit.org/show_bug.cgi?id=167941
650
651         Reviewed by Carlos Garcia Campos.
652
653         * MiniBrowser/gtk/main.c:
654         (filterSavedCallback): Added.
655         (main): Support loading a JSON rule set file for content filtering.
656         * MiniBrowser/wpe/main.cpp:
657         (filterSavedCallback): Added.
658         (main): Support loading a JSON rule set file for content filtering.
659         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentFilterStore.cpp: Added.
660         (WTF::refGPtr): Added locally for WebKitUserContentFilter, as it would not be used anywhere else.
661         (WTF::derefGPtr): Ditto.
662         (testEmptyStore):
663         (testSaveInvalidFilter):
664         (testSaveLoadFilter):
665         (testSavedFilterIdentifierMatch):
666         (testRemoveFilter):
667         (testSaveMultipleFilters):
668         (testSaveFilterFromFile):
669         (testFilterPersistence):
670         (beforeAll):
671         (afterAll):
672         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
673         (removeOldInjectedContentAndResetLists): Also reset content filters.
674         (isCSSBlockedForURLAtPath): Added. Tests whether the test filter, which blocks a
675         CSS style sheet, has blocked the load of the CSS by looking at the resulting style of
676         the element affected by the style sheet.
677         (getUserContentFilter): Added. Stores the test filter in a WebKitUserContentFilterStore
678         and returns it to be used by tests.
679         (testUserContentManagerContentFilter): Added. Tests whether adding and removing a filter
680         from the WebKitUserContentManager results in the a CSS style sheet being blocked.
681         (serverCallback): Add support for serving a CSS style sheet for testing.
682         (beforeAll): Add call to testUserContentManagerContentFilter().
683         * TestWebKitAPI/glib/CMakeLists.txt: Added TestWebKitUserContentFilterStore.
684
685 2019-02-19  Keith Rollin  <krollin@apple.com>
686
687         Add timing information to build output
688         https://bugs.webkit.org/show_bug.cgi?id=194839
689         <rdar://problem/48219609>
690
691         Reviewed by Alexey Proskuryakov.
692
693         Configure xcodebuild with -ShowBuildOperationDuration, causing it to
694         emit each project's build time to its output. E.g.,
695
696             ** BUILD SUCCEEDED ** [0.132 sec]
697
698         * Scripts/webkitdirs.pm:
699         (XcodeOptions):
700
701 2019-02-19  Truitt Savell  <tsavell@apple.com>
702
703         Unreviewed, rolling out r241784.
704
705         Broke all OpenSource builds.
706
707         Reverted changeset:
708
709         "Web Inspector: Improve ES6 Class instances in Heap Snapshot
710         instances view"
711         https://bugs.webkit.org/show_bug.cgi?id=172848
712         https://trac.webkit.org/changeset/241784
713
714 2019-02-19  Zalan Bujtas  <zalan@apple.com>
715
716         [LFC][Floats] Remove redundant intersecting logic
717         https://bugs.webkit.org/show_bug.cgi?id=194804
718
719         Reviewed by Antti Koivisto.
720
721         * LayoutReloaded/misc/LFC-passing-tests.txt:
722
723 2019-02-19  Dean Jackson  <dino@apple.com>
724
725         Clean-up output from generate-xcfilelists so it can be filtered
726         https://bugs.webkit.org/show_bug.cgi?id=194795
727
728         Reviewed by Joseph Pecoraro (and Keith Rollin).
729
730         Replace the "..." with "GXCF:" in generate-xcfilelists output, and
731         make a slight tweak to filter-build-webkit so such lines are marked
732         as plain.
733
734         * Scripts/filter-build-webkit:
735         * Scripts/generate-xcfilelists:
736
737 2019-02-19  Pablo Saavedra  <psaavedra@igalia.com>
738
739         pytest is not correctly auto-installed
740         https://bugs.webkit.org/show_bug.cgi?id=194707
741
742         Reviewed by Carlos Garcia Campos.
743
744         * Scripts/webkitpy/thirdparty/__init__.py:
745         (AutoinstallImportHook._install_pytest):
746
747 2019-02-18  Chris Dumez  <cdumez@apple.com>
748
749         REGRESSION (PSON): Can't access optumbank.com from myuhc.com
750         https://bugs.webkit.org/show_bug.cgi?id=194797
751         <rdar://problem/48055151>
752
753         Reviewed by Geoffrey Garen.
754
755         Add API test coverage.
756
757         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
758
759 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
760
761         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
762         https://bugs.webkit.org/show_bug.cgi?id=194670
763         <rdar://problem/39066529>
764
765         Reviewed by Tim Horton.
766
767         Remove code and tests for subresource URL replacement, and also add a new test to verify that copied data can be
768         pasted in an editable area as attachment elements.
769
770         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
771         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
772         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]): Deleted.
773         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
774         (TestWebKitAPI::TEST):
775         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
776         (WTR::InjectedBundlePage::InjectedBundlePage):
777
778 2019-02-18  Alex Christensen  <achristensen@webkit.org>
779
780         Fix API test after r241728
781        ​https://bugs.webkit.org/show_bug.cgi?id=194723
782
783         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
784         (TEST):
785         The test should check the default preference value, not make sure the preference is NO after setting it to YES :/
786
787 2019-02-18  Daniel Bates  <dabates@apple.com>
788
789         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
790         https://bugs.webkit.org/show_bug.cgi?id=192824
791         <rdar://problem/47100332>
792
793         Reviewed by Wenson Hsieh.
794
795         Fix a bug where the wrong usage code was used for F13 thru F24.
796
797         * WebKitTestRunner/ios/HIDEventGenerator.mm:
798         (keyCodeForDOMFunctionKey):
799
800 2019-02-18  Tadeu Zagallo  <tzagallo@apple.com>
801
802         Bytecode cache should a have a boot-specific validation
803         https://bugs.webkit.org/show_bug.cgi?id=194769
804         <rdar://problem/48149509>
805
806         Reviewed by Keith Miller.
807
808         Add test for WTF::bootSessionUUIDString()
809
810         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
811         * TestWebKitAPI/Tests/WTF/UUID.cpp: Added.
812         (TEST):
813
814 2019-02-18  Alex Christensen  <achristensen@webkit.org>
815
816         Disable safe browsing in WKWebView and remove its WKPreferences API
817         https://bugs.webkit.org/show_bug.cgi?id=194723
818         <rdar://problem/48122993>
819
820         Reviewed by Geoffrey Garen.
821
822         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
823         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
824         (TEST):
825         (safeBrowsingView):
826         Make tests use SPI instead of API.
827
828 2019-02-17  Fujii Hironori  <Hironori.Fujii@sony.com>
829
830         Use dumpJSConsoleLogInStdErr=true webkit-test-runner option for non-imported tests instead of using DumpJSConsoleLogInStdErr expectation in TestExpectations
831         https://bugs.webkit.org/show_bug.cgi?id=194586
832
833         Reviewed by Ross Kirsling.
834
835         * DumpRenderTree/win/DumpRenderTree.cpp:
836         (runTest): Pass true to setDumpJSConsoleLogInStdErr if options.dumpJSConsoleLogInStdErr is true.
837         * Scripts/webkitpy/port/driver.py:
838         (Driver._command_from_driver_input): Convert Cygwin absolute path of tests to Windows path.
839
840 2019-02-17  David Kilzer  <ddkilzer@apple.com>
841
842         Unreviewed, rolling out r241620.
843
844         "Causes use-after-free crashes running layout tests with ASan and GuardMalloc."
845         (Requested by ddkilzer on #webkit.)
846
847         Reverted changeset:
848
849         "[WTF] Add environment variable helpers"
850         https://bugs.webkit.org/show_bug.cgi?id=192405
851         https://trac.webkit.org/changeset/241620
852
853 2019-02-16  Zalan Bujtas  <zalan@apple.com>
854
855         [LFC] RenderImage's default intrinsic size is 0.
856         https://bugs.webkit.org/show_bug.cgi?id=194745
857
858         Reviewed by Antti Koivisto.
859
860         * LayoutReloaded/misc/LFC-passing-tests.txt:
861
862 2019-02-16  Zalan Bujtas  <zalan@apple.com>
863
864         [LFC][BFC] Add support for block replaced intrinsic width.
865         https://bugs.webkit.org/show_bug.cgi?id=194705
866
867         Reviewed by Simon Fraser.
868
869         * LayoutReloaded/misc/LFC-passing-tests.txt:
870
871 2019-02-16  Zalan Bujtas  <zalan@apple.com>
872
873         [LFC] Apply min/max width constraints to preferred width computation
874         https://bugs.webkit.org/show_bug.cgi?id=194739
875
876         Reviewed by Simon Fraser.
877
878         * LayoutReloaded/misc/LFC-passing-tests.txt:
879
880 2019-02-15  Ross Kirsling  <ross.kirsling@sony.com>
881
882         [WTF] Add environment variable helpers
883         https://bugs.webkit.org/show_bug.cgi?id=192405
884
885         Reviewed by Michael Catanzaro.
886
887         * DumpRenderTree/mac/DumpRenderTree.mm:
888         (libraryPathForDumpRenderTree):
889         * DumpRenderTree/win/DumpRenderTree.cpp:
890         (libraryPathForDumpRenderTree):
891         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
892         (setUpIOSLayoutTestCommunication):
893         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
894         (beforeAll):
895         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
896         (main):
897         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
898         (WebKitTestBus::run):
899         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
900         (WTR::getOutputDir):
901         (WTR::initializeFontConfigSetting):
902         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
903         (WTR::InjectedBundle::platformInitialize):
904         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
905         (WTR::topLevelPath):
906         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
907         (WTR::topLevelPath):
908         (WTR::getOutputDir):
909         (WTR::activateFonts):
910         * WebKitTestRunner/TestController.cpp:
911         (WTR::TestController::libraryPathForTesting):
912         (WTR::TestController::generateContextConfiguration const):
913         (WTR::TestController::generatePageConfiguration):
914         (WTR::TestController::decideDestinationWithSuggestedFilename):
915         (WTR::TestController::platformAdjustContext):
916         * WebKitTestRunner/TestController.h:
917         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
918         (WTR::TestController::cocoaPlatformInitialize):
919         (WTR::TestController::platformAdjustContext):
920         * WebKitTestRunner/gtk/main.cpp:
921         (main):
922         * WebKitTestRunner/mac/TestControllerMac.mm:
923         (WTR::TestController::configureContentExtensionForTest):
924         * WebKitTestRunner/wpe/main.cpp:
925         (main):
926         Utilize WTF::Environment where possible.
927
928 2019-02-15  Wenson Hsieh  <wenson_hsieh@apple.com>
929
930         [iOS] WKWebView callout bar is missing Change Writing Direction item
931         https://bugs.webkit.org/show_bug.cgi?id=190015
932         <rdar://problem/44810366>
933
934         Reviewed by Tim Horton.
935
936         Make an existing API test that exercises platform SPI to change the inline text writing direction run only on
937         macOS, and add a new API test that uses similarly named SPI on iOS to change the base writing direction.
938
939         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
940         (TestWebKitAPI::TEST):
941
942 2019-02-15  Chris Dumez  <cdumez@apple.com>
943
944         Regression(PSON) Navigating quickly back and forth can lead to getting 'about:blank' in the backforward list
945         https://bugs.webkit.org/show_bug.cgi?id=194717
946         <rdar://problem/47884404>
947
948         Reviewed by Brady Eidson.
949
950         Add API test coverage.
951
952         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
953
954 2019-02-15  Youenn Fablet  <youenn@apple.com>
955
956         Make navigator.mediaDevices SecureContext
957         https://bugs.webkit.org/show_bug.cgi?id=194666
958
959         Reviewed by Eric Carlson.
960
961         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
962         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
963         (TEST_F):
964
965 2019-02-15  Brian Burg  <bburg@apple.com>
966
967         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
968         https://bugs.webkit.org/show_bug.cgi?id=194411
969         <rdar://problem/47787614>
970
971         Reviewed by Joseph Pecoraro.
972
973         Remove unnecessary soft linking macro usage.
974
975         * DumpRenderTree/mac/TestRunnerMac.mm:
976         (TestRunner::inspectorTestStubURL):
977         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
978         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
979         (WTR::TestRunner::inspectorTestStubURL):
980
981 2019-02-15  Commit Queue  <commit-queue@webkit.org>
982
983         Unreviewed, rolling out r241559 and r241566.
984         https://bugs.webkit.org/show_bug.cgi?id=194710
985
986         Causes layout test crashes under GuardMalloc (Requested by
987         ryanhaddad on #webkit).
988
989         Reverted changesets:
990
991         "[WTF] Add environment variable helpers"
992         https://bugs.webkit.org/show_bug.cgi?id=192405
993         https://trac.webkit.org/changeset/241559
994
995         "Unreviewed build fix for WinCairo Debug after r241559."
996         https://trac.webkit.org/changeset/241566
997
998 2019-02-15  Zalan Bujtas  <zalan@apple.com>
999
1000         [LFC] Out-of-flow box is never a float box
1001         https://bugs.webkit.org/show_bug.cgi?id=194704
1002
1003         Reviewed by Antti Koivisto.
1004
1005         * LayoutReloaded/misc/LFC-passing-tests.txt:
1006
1007 2019-02-10  Darin Adler  <darin@apple.com>
1008
1009         Replace more uses of String::format with StringConcatenate (mostly non-Apple platform-specific cases)
1010         https://bugs.webkit.org/show_bug.cgi?id=194487
1011
1012         Reviewed by Daniel Bates.
1013
1014         * DumpRenderTree/win/DumpRenderTree.cpp:
1015         (applicationId): Use makeString instead of String::format.
1016         (main): Ditto.
1017         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
1018         (TestWebKitAPI::Util::createURLForResource): Ditto.
1019         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
1020         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Ditto.
1021
1022         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1023         (WTR::attributeSetToString): Use StringBuilder functions directly instead of g_strconcat.
1024         (WTR::attributesOfElement): Use StringBuilder functions directly instead of String::format.
1025         (WTR::createStringWithAttributes): Use appendLiteral.
1026         (WTR::AccessibilityUIElement::helpText const): Ditto.
1027         (WTR::AccessibilityUIElement::attributedStringForRange): Use StringBuilder functions
1028         directly instead of using String::format.
1029         (WTR::AccessibilityUIElement::url): Use makeString instead of String::format.
1030         (WTR::stringAtOffset): Use StringBuilder::appendNumber instead of String::format.
1031
1032 2019-02-15  Truitt Savell  <tsavell@apple.com>
1033
1034         Unreviewed, rolling out r241564.
1035
1036         Caused 50+ Timeouts on Mac WK2, mostly in the http/ directory
1037
1038         Reverted changeset:
1039
1040         "[Mac] WebInspectorUI.framework does not need to be soft-
1041         linked anymore"
1042         https://bugs.webkit.org/show_bug.cgi?id=194411
1043         https://trac.webkit.org/changeset/241564
1044
1045 2019-02-15  Saam barati  <sbarati@apple.com>
1046
1047         [WebAssembly] Write a new register allocator for Air O0 and make BBQ use it
1048         https://bugs.webkit.org/show_bug.cgi?id=194036
1049
1050         Reviewed by Yusuke Suzuki.
1051
1052         * Scripts/run-jsc-stress-tests:
1053
1054 2019-02-14  Tim Horton  <timothy_horton@apple.com>
1055
1056         Fix the build.
1057
1058         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1059         (WTR::UIScriptController::drawSquareInEditableImage):
1060         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1061         (TestWebKitAPI::drawSquareInEditableImage):
1062
1063 2019-02-14  Tim Horton  <timothy_horton@apple.com>
1064
1065         Fix the build.
1066
1067         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1068         (WTR::UIScriptController::drawSquareInEditableImage):
1069         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1070         (TestWebKitAPI::drawSquareInEditableImage):
1071
1072 2019-02-14  Brian Burg  <bburg@apple.com>
1073
1074         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
1075         https://bugs.webkit.org/show_bug.cgi?id=194411
1076         <rdar://problem/47787614>
1077
1078         Reviewed by Joseph Pecoraro.
1079
1080         Remove unnecessary soft linking macro usage.
1081
1082         * DumpRenderTree/mac/TestRunnerMac.mm:
1083         (TestRunner::inspectorTestStubURL):
1084         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
1085         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1086         (WTR::TestRunner::inspectorTestStubURL):
1087
1088 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
1089
1090         [ews-app] status bubble should fetch builder name info from BuilderMapping table
1091         https://bugs.webkit.org/show_bug.cgi?id=194599
1092
1093         Reviewed by Lucas Forschler.
1094
1095         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1096         (StatusBubble._build_bubble):
1097
1098 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
1099
1100         [ews-app] Set Foreign Key in Django build model
1101         https://bugs.webkit.org/show_bug.cgi?id=194667
1102
1103         Reviewed by Lucas Forschler.
1104
1105         * BuildSlaveSupport/ews-app/ews/models/build.py:
1106         (Build):
1107
1108 2019-02-14  Ross Kirsling  <ross.kirsling@sony.com>
1109
1110         [WTF] Add environment variable helpers
1111         https://bugs.webkit.org/show_bug.cgi?id=192405
1112
1113         Reviewed by Michael Catanzaro.
1114
1115         * DumpRenderTree/mac/DumpRenderTree.mm:
1116         (libraryPathForDumpRenderTree):
1117         * DumpRenderTree/win/DumpRenderTree.cpp:
1118         (libraryPathForDumpRenderTree):
1119         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
1120         (setUpIOSLayoutTestCommunication):
1121         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
1122         (TestWebKitAPI::strip):
1123         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
1124         (beforeAll):
1125         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
1126         (main):
1127         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
1128         (WebKitTestBus::run):
1129         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1130         (WTR::getOutputDir):
1131         (WTR::initializeFontConfigSetting):
1132         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
1133         (WTR::InjectedBundle::platformInitialize):
1134         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
1135         (WTR::topLevelPath):
1136         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
1137         (WTR::topLevelPath):
1138         (WTR::getOutputDir):
1139         (WTR::activateFonts):
1140         * WebKitTestRunner/TestController.cpp:
1141         (WTR::TestController::libraryPathForTesting):
1142         (WTR::TestController::generateContextConfiguration const):
1143         (WTR::TestController::generatePageConfiguration):
1144         (WTR::TestController::decideDestinationWithSuggestedFilename):
1145         (WTR::TestController::platformAdjustContext):
1146         * WebKitTestRunner/TestController.h:
1147         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1148         (WTR::TestController::cocoaPlatformInitialize):
1149         (WTR::TestController::platformAdjustContext):
1150         * WebKitTestRunner/gtk/main.cpp:
1151         (main):
1152         * WebKitTestRunner/mac/TestControllerMac.mm:
1153         (WTR::TestController::configureContentExtensionForTest):
1154         * WebKitTestRunner/wpe/main.cpp:
1155         (main):
1156         Utilize WTF::Environment where possible.
1157
1158 2019-02-14  Chris Dumez  <cdumez@apple.com>
1159
1160         [PSON] Introduce a WebContent Process cache
1161         https://bugs.webkit.org/show_bug.cgi?id=194594
1162         <rdar://problem/46793397>
1163
1164         Reviewed by Geoff Garen.
1165
1166         Update API tests to turn on the WebContent Process cache.
1167
1168         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1169
1170 2019-02-14  Jiewen Tan  <jiewen_tan@apple.com>
1171
1172         Unreviewed, build fix after r241480
1173
1174         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1175         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
1176         (-[DragAndDropSimulator initWithWebView:]):
1177
1178 2019-02-14  Chris Fleizach  <cfleizach@apple.com>
1179
1180         AX: ARIA Reflection was disabled in error
1181         https://bugs.webkit.org/show_bug.cgi?id=194647
1182         <rdar://problem/48068336>
1183
1184         Reviewed by Ryosuke Niwa.
1185
1186         Remove test override now that this feature should be enabled by default.
1187
1188         * WebKitTestRunner/TestController.cpp:
1189         (WTR::TestController::resetPreferencesToConsistentValues):
1190
1191 2019-02-14  Commit Queue  <commit-queue@webkit.org>
1192
1193         Unreviewed, rolling out r241486.
1194         https://bugs.webkit.org/show_bug.cgi?id=194655
1195
1196         causing API failures in builds (Requested by ShawnRoberts on
1197         #webkit).
1198
1199         Reverted changeset:
1200
1201         "[Cocoa] Media elements will restart network buffering just
1202         before suspending"
1203         https://bugs.webkit.org/show_bug.cgi?id=193691
1204         https://trac.webkit.org/changeset/241486
1205
1206 2019-02-14  Zalan Bujtas  <zalan@apple.com>
1207
1208         [LFC][BFC][MarginCollapse] Replaced boxes don't collapse through their margins
1209         https://bugs.webkit.org/show_bug.cgi?id=194622
1210
1211         Reviewed by Antti Koivisto.
1212
1213         * LayoutReloaded/misc/LFC-passing-tests.txt:
1214
1215 2019-02-14  Zalan Bujtas  <zalan@apple.com>
1216
1217         [LFC] Shrink-to-fit-width should be constrained by min/max width
1218         https://bugs.webkit.org/show_bug.cgi?id=194653
1219
1220         Reviewed by Antti Koivisto.
1221
1222         * LayoutReloaded/misc/LFC-passing-tests.txt:
1223
1224 2019-02-13  Ryosuke Niwa  <rniwa@webkit.org>
1225
1226         Crash in WKBundleFrameGetParentFrame when called inside didRemoveFrameFromHierarchy
1227         https://bugs.webkit.org/show_bug.cgi?id=194641
1228
1229         Reviewed by Geoffrey Garen.
1230
1231         Added a call to WKBundleFrameGetParentFrame to an existing test for didRemoveFrameFromHierarchy
1232         so that the test would fail without this fix.
1233
1234         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
1235         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
1236
1237 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1238
1239         [ews-app] Change log level for a log statement
1240
1241         Unreviewed minor fix.
1242
1243         * BuildSlaveSupport/ews-app/ews/models/patch.py:
1244         (Patch.save_patch):
1245
1246 2019-02-13  Jer Noble  <jer.noble@apple.com>
1247
1248         [Cocoa] Media elements will restart network buffering just before suspending
1249         https://bugs.webkit.org/show_bug.cgi?id=193691
1250
1251         Reviewed by Eric Carlson.
1252
1253         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1254         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
1255         (TEST):
1256
1257 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1258
1259         [ews-app] Fetch builder id to name mapping
1260         https://bugs.webkit.org/show_bug.cgi?id=194355
1261
1262         Reviewed by Lucas Forschler.
1263
1264         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
1265         (Buildbot.get_builder_id_to_name_mapping):
1266         (Buildbot._get_display_name_from_builder_name):
1267
1268 2019-02-12  Jiewen Tan  <jiewen_tan@apple.com>
1269
1270         Further restricting webarchive loads
1271         https://bugs.webkit.org/show_bug.cgi?id=194567
1272         <rdar://problem/47610130>
1273
1274         Reviewed by Youenn Fablet.
1275
1276         Besides adding API tests, this patch also enhances DragAndDropSimulator to allow
1277         navigations on drop.
1278
1279         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1280         * TestWebKitAPI/Tests/mac/LoadWebArchive.mm: Added.
1281         (-[TestLoadWebArchiveNavigationDelegate webView:didFinishNavigation:]):
1282         (-[TestLoadWebArchiveNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
1283         (-[TestLoadWebArchiveNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
1284         (TestWebKitAPI::TEST):
1285         * TestWebKitAPI/Tests/mac/helloworld.webarchive: Added.
1286         * TestWebKitAPI/Tests/mac/load-web-archive-1.html: Added.
1287         * TestWebKitAPI/Tests/mac/load-web-archive-2.html: Added.
1288         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
1289         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
1290         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
1291         (-[DragAndDropSimulator _webView:dragDestinationActionMaskForDraggingInfo:]):
1292
1293 2019-02-13  John Wilander  <wilander@apple.com>
1294
1295         Store Ad Click Attribution requests in the network process
1296         https://bugs.webkit.org/show_bug.cgi?id=194510
1297         <rdar://problem/47650118>
1298
1299         Reviewed by Alex Christensen and Daniel Bates.
1300
1301         This patch adds two TestRunner functions:
1302         - dumpAdClickAttribution()
1303         - clearAdClickAttribution()
1304
1305         They call into the network process to dump and clear Ad Click
1306         Attribution state, respectively.
1307
1308         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1309         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1310         (WTR::TestRunner::dumpAdClickAttribution):
1311         (WTR::TestRunner::clearAdClickAttribution):
1312         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1313         * WebKitTestRunner/TestController.cpp:
1314         (WTR::TestController::resetStateToConsistentValues):
1315         (WTR::AdClickAttributionStringResultCallbackContext::AdClickAttributionStringResultCallbackContext):
1316         (WTR::adClickAttributionStringResultCallback):
1317         (WTR::TestController::dumpAdClickAttribution):
1318         (WTR::AdClickAttributionVoidCallbackContext::AdClickAttributionVoidCallbackContext):
1319         (WTR::adClickAttributionVoidCallback):
1320         (WTR::TestController::clearAdClickAttribution):
1321         * WebKitTestRunner/TestController.h:
1322         * WebKitTestRunner/TestInvocation.cpp:
1323         (WTR::TestInvocation::dumpResults):
1324         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1325         (WTR::TestInvocation::dumpAdClickAttribution):
1326         * WebKitTestRunner/TestInvocation.h:
1327
1328 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1329
1330         [ews-app] Generate status-bubble
1331         https://bugs.webkit.org/show_bug.cgi?id=194572
1332
1333         Reviewed by Lucas Forschler.
1334
1335         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1336         (StatusBubble._build_bubble):
1337         (StatusBubble._should_show_bubble_for):
1338         (StatusBubble._build_bubbles_for_patch):
1339
1340 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1341
1342         [ews-app] Add status bubble html template
1343         https://bugs.webkit.org/show_bug.cgi?id=194571
1344
1345         Reviewed by Lucas Forschler.
1346
1347         * BuildSlaveSupport/ews-app/ews/templates: Added.
1348         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Copied from QueueStatusServer/templates/statusbubble.html.
1349
1350 2019-02-12  Chris Dumez  <cdumez@apple.com>
1351
1352         Regression(PSON) MESSAGE_CHECK() hit under WebPageProxy::didFailProvisionalLoadForFrameShared()
1353         https://bugs.webkit.org/show_bug.cgi?id=194568
1354         <rdar://problem/47944490>
1355
1356         Reviewed by Ryosuke Niwa.
1357
1358         Add API test coverage.
1359
1360         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1361         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
1362
1363 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
1364
1365         webkitpy: Remove bug_dummy from parsed test expectations
1366         https://bugs.webkit.org/show_bug.cgi?id=194562
1367         <rdar://problem/47853999>
1368
1369         Reviewed by Lucas Forschler.
1370
1371         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1372         (TestExpectationParser):
1373         (TestExpectationParser.expectation_for_skipped_test): Remove DUMMY_BUG_MODIFIER from
1374         skipped tests.
1375         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1376
1377 2019-02-12  Aakash Jain  <aakash_jain@apple.com>
1378
1379         [ews-app] Add method to fetch patch
1380         https://bugs.webkit.org/show_bug.cgi?id=194518
1381
1382         Reviewed by Lucas Forschler.
1383
1384         * BuildSlaveSupport/ews-app/ews/models/patch.py:
1385         (Patch.get_patch):
1386
1387 2019-02-12  Zalan Bujtas  <zalan@apple.com>
1388
1389         [LFC] Expand tests coverage (60 new tests -> 860)
1390
1391         Unreviewed test gardening (run-singly, --child-processes=1).
1392
1393         * LayoutReloaded/misc/LFC-passing-tests.txt:
1394
1395 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
1396
1397         Allow pages to trigger programmatic paste from script on iOS
1398         https://bugs.webkit.org/show_bug.cgi?id=194271
1399         <rdar://problem/47808810>
1400
1401         Reviewed by Tim Horton.
1402
1403         Add support for interacting with the callout bar on iOS during layout tests. See below for more detail.
1404
1405         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1406         (WTR::UIScriptController::platformSetDidShowMenuCallback):
1407         (WTR::UIScriptController::platformSetDidHideMenuCallback):
1408         (WTR::UIScriptController::rectForMenuAction const):
1409
1410         Add new mechanisms to make it possible to interact with and query the state of the callout menu on iOS. This
1411         includes determining the rect (in content view coordinates) of the menu's controls, and callbacks to register
1412         for when the menu is shown or hidden.
1413
1414         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1415         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
1416         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1417         (WTR::UIScriptController::setDidShowMenuCallback):
1418         (WTR::UIScriptController::didShowMenuCallback const):
1419         (WTR::UIScriptController::setDidHideMenuCallback):
1420         (WTR::UIScriptController::didHideMenuCallback const):
1421         (WTR::UIScriptController::platformSetDidShowMenuCallback):
1422         (WTR::UIScriptController::platformSetDidHideMenuCallback):
1423         (WTR::UIScriptController::rectForMenuAction const):
1424         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1425         * WebKitTestRunner/TestController.cpp:
1426         (WTR::TestController::resetPreferencesToConsistentValues):
1427         (WTR::updateTestOptionsFromTestHeader):
1428         * WebKitTestRunner/TestOptions.h:
1429
1430         Add a new test option to determine whether DOM paste is enabled. DOM paste is currently enabled everywhere by
1431         default, but these new programmatic paste tests require it to be disabled in order for confirmation UI to show.
1432
1433         (WTR::TestOptions::hasSameInitializationOptions const):
1434         * WebKitTestRunner/UIScriptControllerCocoa.mm:
1435         (WTR::UIScriptController::calendarType const):
1436         (WTR::UIScriptController::platformUndoManager const):
1437         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1438         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1439         (-[TestRunnerWKWebView initWithFrame:configuration:]):
1440         (-[TestRunnerWKWebView dealloc]):
1441         (-[TestRunnerWKWebView _didShowMenu]):
1442         (-[TestRunnerWKWebView _didHideMenu]):
1443
1444         Listen to when the callout bar is presented and dismissed, and invoke testing callbacks as needed.
1445
1446         * WebKitTestRunner/ios/TestControllerIOS.mm:
1447         (WTR::handleMenuWillHideNotification):
1448         (WTR::handleMenuDidHideNotification):
1449         (WTR::TestController::platformInitialize):
1450         (WTR::TestController::platformDestroy):
1451         (WTR::TestController::platformResetStateToConsistentValues):
1452
1453         Additionally ensure that any callout menu presented by a previous layout test is dismissed before running the
1454         next test by hiding the callout bar if necessary, and then waiting for the "DidHide" notification.
1455
1456         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1457         (WTR::forEachViewInHierarchy):
1458         (WTR::findViewInHierarchyOfType):
1459
1460         Move `forEachViewInHierarchy` so that we can use it throughout the file, and then add some additional helper
1461         functions that dig through a given view's hierarchy in search of a view of a given class.
1462
1463         (WTR::UIScriptController::selectionStartGrabberViewRect const):
1464         (WTR::UIScriptController::selectionEndGrabberViewRect const):
1465         (WTR::UIScriptController::selectionCaretViewRect const):
1466         (WTR::UIScriptController::selectionRangeViewRects const):
1467         (WTR::UIScriptController::platformSetDidShowMenuCallback):
1468         (WTR::UIScriptController::platformSetDidHideMenuCallback):
1469
1470         Tweak these to use `platformContentView` instead of grabbing the content view from WKWebView directly.
1471
1472         (WTR::UIScriptController::rectForMenuAction const):
1473
1474         Add a new UIScriptController method to get the rect of the action in the contextual menu (on iOS, this is the
1475         callout bar) whose label matches the given string.
1476
1477         (WTR::UIScriptController::platformContentView const):
1478
1479         Add a `platformContentView()` helper on UIScriptController so that we can stop grabbing the value for key
1480         "_currentContentView" from various places in this file. Additionally, rewrite `platformUndoManager()` in terms
1481         of this new helper, and move the code out from iOS/macOS-specific files into UIScriptControllerCocoa.
1482
1483         (WTR::UIScriptController::platformUndoManager const): Deleted.
1484         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1485         (WTR::UIScriptController::platformContentView const):
1486         (WTR::UIScriptController::platformUndoManager const): Deleted.
1487
1488 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
1489
1490         webkitpy: No option to only show unexpected failures in results.html for iPad
1491         https://bugs.webkit.org/show_bug.cgi?id=194554
1492         <rdar://problem/47922442>
1493
1494         Rubber-stamped by Aakash Jain.
1495
1496         Just because a TestExpecations file does not exist for a specific platform does not mean that
1497         TestExpecations are not being used, given that platforms inherit test expectations.
1498
1499         * Scripts/webkitpy/port/base.py:
1500         (Port.uses_test_expectations_file): Check all possible locations of a TestExpectations file.
1501         * Scripts/webkitpy/port/base_unittest.py:
1502         (PortTest.test_uses_test_expectations_file):
1503
1504 2019-02-12  Alex Christensen  <achristensen@webkit.org>
1505
1506         Remove setDefersLoading infrastructure from WebKit2
1507         https://bugs.webkit.org/show_bug.cgi?id=194506
1508
1509         Reviewed by Brady Eidson.
1510
1511         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1512         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1513         (WTR::TestRunner::setDefersLoading): Deleted.
1514         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1515
1516 2019-02-12  Alex Christensen  <achristensen@webkit.org>
1517
1518         WebPage::close needs to remove all message receivers associated with that WebPage, not WebPage::~WebPage
1519         https://bugs.webkit.org/show_bug.cgi?id=194522
1520         <rdar://problem/47789393>
1521
1522         Reviewed by Chris Dumez.
1523
1524         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1525         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm: Added.
1526         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1527         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1528
1529 2019-02-12  Andy Estes  <aestes@apple.com>
1530
1531         [iOSMac] Enable Parental Controls Content Filtering
1532         https://bugs.webkit.org/show_bug.cgi?id=194521
1533         <rdar://39732376>
1534
1535         Reviewed by Tim Horton.
1536
1537         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1538
1539 2019-02-12  Zalan Bujtas  <zalan@apple.com>
1540
1541         [LFC][IFC] Add intrinsic width support for float boxes.
1542         https://bugs.webkit.org/show_bug.cgi?id=194528
1543
1544         Reviewed by Antti Koivisto.
1545
1546         Expand tests coverage (2 new tests -> 800).
1547         (This is the correct test ordering --runs-singly --child-processes=1)
1548
1549         * LayoutReloaded/misc/LFC-passing-tests.txt:
1550
1551 2019-02-12  Rob Buis  <rbuis@igalia.com>
1552
1553         Implement serializing in MIME type parser
1554         https://bugs.webkit.org/show_bug.cgi?id=193909
1555
1556         Reviewed by Darin Adler.
1557
1558         Add various tests involving upper case, non-ASCII, control/null characters,
1559         various HTTP whitespace, single quotes and an unpaired surrogate.
1560
1561         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
1562         (TestWebKitAPI::escapeNonASCIIPrintableCharacters):
1563         (TestWebKitAPI::serializeIfValid):
1564         (TestWebKitAPI::TEST):
1565
1566 2019-02-11  Myles C. Maxfield  <mmaxfield@apple.com>
1567
1568         [Cocoa] Ask platform for generic font family mappings
1569         https://bugs.webkit.org/show_bug.cgi?id=187723
1570         <rdar://problem/41892438>
1571
1572         Reviewed by Brent Fulgham.
1573
1574         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
1575
1576         * DumpRenderTree/mac/DumpRenderTree.mm:
1577         (allowedFontFamilySet):
1578         * WebKitTestRunner/mac/TestControllerMac.mm:
1579         (WTR::allowedFontFamilySet):
1580
1581 2019-02-11  Adrian Perez de Castro  <aperez@igalia.com>
1582
1583         [GTK][WPE] Add content extensions support in WKTR and unskip layout tests
1584         https://bugs.webkit.org/show_bug.cgi?id=193622
1585
1586         Reviewed by Michael Catanzaro.
1587
1588         This adds support for loading content extension rule sets from the JSON files which
1589         accompany the corresponding layout test, using the C API. The Cocoa specific parts
1590         of WKTR for this could be removed, but that is left for a follow-up patch with
1591         cleanups.
1592
1593         * Scripts/webkitperl/FeatureList.pm: Add an option to toggle CONTENT_EXTENSIONS.
1594         * WebKitTestRunner/TestController.cpp:
1595         (WTR::testPath): Subtract one from the length when constructing the result std::string to
1596         avoid having the null-terminator copied into the result.
1597         (WTR::TestController::configureViewForTest): Call configureContentExtensionForTest() as
1598         part of the preparations to run a test.
1599         (WTR::ContentExtensionStoreCallbackContext::ContentExtensionStoreCallbackContext): Added.
1600         (WTR::contentExtensionStoreCallback): Added.
1601         (WTR::contentExtensionJSONPath): Used to calculate the path to the JSON rule set to be
1602         used for content extensions test.
1603         (WTR::TestController::configureContentExtensionForTest): Added, handles enabling content
1604         extensions and compiling the JSON rule set for tests involving content extensions.
1605         (WTR::TestController::resetContentExtensions): Removes the content extension built for
1606         testing and disables content extensions.
1607         (WTR::TestController::resetPreferencesToConsistentValues): Add a call to
1608         resetContentExtensions().
1609         (WTR::TestController::userContentController): Added implementation for ports other than Cocoa.
1610         * WebKitTestRunner/TestController.h: Add declarations for resetContentExtensions(),
1611         configureContentExtensionForTest(), and userContentController().
1612
1613 2019-02-11  Daniel Bates  <dabates@apple.com>
1614
1615         [iOS] Mouse/Touch/Pointer events are missing modifier keys
1616         https://bugs.webkit.org/show_bug.cgi?id=191446
1617         <rdar://problem/45929460>
1618
1619         Reviewed by Tim Horton.
1620
1621         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
1622
1623         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1624         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1625         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1626         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1627         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1628         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1629         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1630         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1631         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1632         (WTR::arrayLength):
1633         (WTR::parseModifierArray):
1634         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
1635         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1636         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
1637         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1638
1639 2019-02-11  Commit Queue  <commit-queue@webkit.org>
1640
1641         Unreviewed, rolling out r241272 and r241276.
1642         https://bugs.webkit.org/show_bug.cgi?id=194514
1643
1644         Broke the Apple Internal build and the fix requires human
1645         intervention :( (Requested by dydz on #webkit).
1646
1647         Reverted changesets:
1648
1649         "[iOS] Mouse/Touch/Pointer events are missing modifier keys"
1650         https://bugs.webkit.org/show_bug.cgi?id=191446
1651         https://trac.webkit.org/changeset/241272
1652
1653         "Fix internal iOS build after r241272"
1654         https://bugs.webkit.org/show_bug.cgi?id=191446
1655         https://trac.webkit.org/changeset/241276
1656
1657 2019-02-11  Truitt Savell  <tsavell@apple.com>
1658
1659         Unreviewed, rolling out r241269.
1660
1661         Caused 5 layout tests crashes on Mac WK1
1662
1663         Reverted changeset:
1664
1665         "DumpRenderTree should report unknown options"
1666         https://bugs.webkit.org/show_bug.cgi?id=191303
1667         https://trac.webkit.org/changeset/241269
1668
1669 2019-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1670
1671         fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html does not work on iPad
1672         https://bugs.webkit.org/show_bug.cgi?id=194313
1673
1674         Reviewed by Tim Horton.
1675
1676         Add a helper to determine whether the web view is presenting modal UI.
1677
1678         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1679         (WTR::UIScriptController::isPresentingModally const):
1680         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1681         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1682         (WTR::UIScriptController::isPresentingModally const):
1683         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1684         * WebKitTestRunner/UIScriptControllerCocoa.mm:
1685         (WTR::UIScriptController::calendarType const): Deleted.
1686         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1687         (WTR::UIScriptController::isPresentingModally const):
1688         (WTR::UIScriptController::calendarType const):
1689         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1690         (WTR::UIScriptController::calendarType const):
1691
1692 2019-02-11  Joseph Pecoraro  <pecoraro@apple.com>
1693
1694         GCHeapInspector: Show the retained sizes in more places
1695         https://bugs.webkit.org/show_bug.cgi?id=194464
1696
1697         Reviewed by Simon Fraser.
1698
1699         * GCHeapInspector/gc-heap-inspector.html:
1700         * GCHeapInspector/script/interface.js:
1701         (HeapInspectorUtils.humanReadableSize):
1702         (HeapInspectorUtils.spanForNode.let.nodeHTML.node.className.span):
1703         (HeapInspectorUtils.spanForNode.span.span):
1704         (HeapSnapshotInspector.prototype.buildAllObjectsByType):
1705         (HeapSnapshotInspector.prototype.buildRoots):
1706
1707 2019-02-11  Daniel Bates  <dabates@apple.com>
1708
1709         [iOS] Mouse/Touch/Pointer events are missing modifier keys
1710         https://bugs.webkit.org/show_bug.cgi?id=191446
1711         <rdar://problem/45929460>
1712
1713         Reviewed by Tim Horton.
1714
1715         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
1716
1717         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1718         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1719         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1720         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1721         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1722         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1723         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1724         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1725         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1726         (WTR::arrayLength):
1727         (WTR::parseModifierArray):
1728         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
1729         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1730         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
1731         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1732
1733 2019-02-11  Darshan Kadu  <dkadu@igalia.com>
1734
1735         DumpRenderTree should report unknown options
1736         https://bugs.webkit.org/show_bug.cgi?id=191303
1737
1738         Reviewed by Frédéric Wang.
1739
1740         Added RELEASE_ASSERT_NOT_REACHED for DumpRenderTree/TestOptions.cpp
1741         to report unknown options.
1742         Added and assigned test options which are currently used in tests.
1743
1744         * DumpRenderTree/TestOptions.cpp:
1745         (TestOptions::TestOptions):
1746
1747 2019-02-11  Truitt Savell  <tsavell@apple.com>
1748
1749         Unreviewed, rolling out r241229.
1750
1751         Revision broke internal builds for watchOS.
1752
1753         Reverted changeset:
1754
1755         "[Cocoa] Ask platform for generic font family mappings"
1756         https://bugs.webkit.org/show_bug.cgi?id=187723
1757         https://trac.webkit.org/changeset/241229
1758
1759 2019-02-11  Takashi Komori  <Takashi.Komori@sony.com>
1760
1761         [WinCairo][MiniBrowser] Basic authentication always fails.
1762         https://bugs.webkit.org/show_bug.cgi?id=194496
1763
1764         Reviewed by Don Olmstead.
1765
1766         * MiniBrowser/win/DialogHelper.h:
1767         (Dialog::getText):
1768
1769 2019-02-11  Philippe Normand  <pnormand@igalia.com>
1770
1771         [GStreamer] GstMappedBuffer testsuite build fails
1772         https://bugs.webkit.org/show_bug.cgi?id=194495
1773
1774         Reviewed by Carlos Garcia Campos.
1775
1776         Fix the build by explicitely adding the gstreamer1.0-audio include
1777         directories to the include path.
1778
1779         * TestWebKitAPI/PlatformGTK.cmake:
1780         * TestWebKitAPI/PlatformWPE.cmake:
1781
1782 2019-02-04  Carlos Garcia Campos  <cgarcia@igalia.com>
1783
1784         [GTK][WPE] Add enable-javascript-markup setting
1785         https://bugs.webkit.org/show_bug.cgi?id=193439
1786
1787         Reviewed by Michael Catanzaro.
1788
1789         Add test cases to check the new setting.
1790
1791         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
1792         (testWebKitSettings):
1793         (testWebKitSettingsJavaScriptMarkup):
1794         (beforeAll):
1795
1796 2019-02-10  Darin Adler  <darin@apple.com>
1797
1798         Switch uses of StringBuilder with String::format for hex numbers to use HexNumber.h instead
1799         https://bugs.webkit.org/show_bug.cgi?id=194485
1800
1801         Reviewed by Daniel Bates.
1802
1803         * WebKitTestRunner/TestController.cpp: Removed unnecessary include of HexNumber.h.
1804
1805 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
1806
1807         Add more tests for clampTo<>()
1808         https://bugs.webkit.org/show_bug.cgi?id=194462
1809
1810         Reviewed by Geoffrey Garen.
1811
1812         Darin suggested to test the very last floating point number
1813         at the boundaries when truncating to integer.
1814         I added test for max/min and max-1/min-1.
1815
1816         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1817         (TestWebKitAPI::TEST):
1818
1819 2019-02-09  Darin Adler  <darin@apple.com>
1820
1821         Eliminate unnecessary String temporaries by using StringConcatenateNumbers
1822         https://bugs.webkit.org/show_bug.cgi?id=194021
1823
1824         Reviewed by Geoffrey Garen.
1825
1826         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
1827         (TestWebKitAPI::TEST): Change tests to use EXPECT_STREQ so failure messages are easier
1828         to understand. Updated tests for changes to FormattedNumber::fixedPrecision.
1829
1830 2019-02-09  Zalan Bujtas  <zalan@apple.com>
1831
1832         [LFC][IFC] Add intrinsic width support for basic inline containers
1833         https://bugs.webkit.org/show_bug.cgi?id=194473
1834
1835         Reviewed by Antti Koivisto.
1836
1837         Expand tests coverage (11 new tests -> 798)
1838
1839         * LayoutReloaded/misc/LFC-passing-tests.txt: not sure why run-singly keeps producing different ordering.
1840
1841 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
1842
1843         Fix MiniBrowser's entitlements
1844         https://bugs.webkit.org/show_bug.cgi?id=192431
1845
1846         Reviewed by Joseph Pecoraro.
1847
1848         MiniBrowser's Extensions Manager was broken. The entitlement was missing for opening
1849         files, making it impossible to load any extension.
1850
1851         * MiniBrowser/MiniBrowser.entitlements:
1852
1853 2019-02-08  Myles C. Maxfield  <mmaxfield@apple.com>
1854
1855         [Cocoa] Ask platform for generic font family mappings
1856         https://bugs.webkit.org/show_bug.cgi?id=187723
1857         <rdar://problem/41892438>
1858
1859         Reviewed by Brent Fulgham.
1860
1861         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
1862
1863         * DumpRenderTree/mac/DumpRenderTree.mm:
1864         (allowedFontFamilySet):
1865         * WebKitTestRunner/mac/TestControllerMac.mm:
1866         (WTR::allowedFontFamilySet):
1867
1868 2019-02-08  Alexander Mikhaylenko  <exalm7659@gmail.com>
1869
1870         [GTK] Implement back/forward touchpad gesture
1871         https://bugs.webkit.org/show_bug.cgi?id=193919
1872
1873         Reviewed by Michael Catanzaro.
1874
1875         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
1876         (testWebKitSettings): Add a test for 'enable-back-forward-navigation-gestures' property.
1877
1878 2019-02-08  Alex Christensen  <achristensen@webkit.org>
1879
1880         Add SPI to use networking daemon instead of XPC service
1881         https://bugs.webkit.org/show_bug.cgi?id=194427
1882
1883         Reviewed by Geoffrey Garen
1884
1885         * MiniBrowser/MiniBrowser.entitlements:
1886
1887 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
1888
1889         [ews-build] Ensure that every builder in config.json has short name
1890         https://bugs.webkit.org/show_bug.cgi?id=194461
1891
1892         Reviewed by Lucas Forschler.
1893
1894         * BuildSlaveSupport/ews-build/loadConfig.py:
1895         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: Updated unit-tests.
1896
1897 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
1898
1899         [ews-build] Add short name to config.json
1900         https://bugs.webkit.org/show_bug.cgi?id=194456
1901
1902         Reviewed by Lucas Forschler.
1903
1904         * BuildSlaveSupport/ews-build/config.json: Added short name.
1905         * BuildSlaveSupport/ews-build/loadConfig.py:
1906         (loadBuilderConfig): Set the short name as the builder description.
1907
1908 2019-02-08  Jonathan Bedard  <jbedard@apple.com>
1909
1910         webkitpy: CrashLogs.find_all_logs may return a string or a dictionary
1911         https://bugs.webkit.org/show_bug.cgi?id=194418
1912
1913         Reviewed by Lucas Forschler.
1914
1915         Do not include errors trying when finding crashlogs at the end of
1916         a run-webkit-tests run since we don't process those errors.
1917
1918         * Scripts/webkitpy/port/darwin.py:
1919         (DarwinPort._look_for_all_crash_logs_in_log_dir):
1920         * Scripts/webkitpy/port/ios_device.py:
1921         (IOSDevicePort._look_for_all_crash_logs_in_log_dir):
1922         * Scripts/webkitpy/port/watch_device.py:
1923         (WatchDevicePort._look_for_all_crash_logs_in_log_dir):
1924
1925 2019-02-08  Beth Dakin  <bdakin@apple.com>
1926
1927         Add afterScreenUpdates to WKSnapshotConfiguration
1928         https://bugs.webkit.org/show_bug.cgi?id=194362
1929         -and corresponding-
1930         <rdar://problem/40655528> Please add an "after screen updates" property to 
1931         WKSnapshotConfiguration (to solve blank snapshots)
1932
1933         Reviewed by Tim Horton.
1934
1935         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:
1936         (TEST):
1937
1938 2019-02-08  Benjamin Poulain  <benjamin@webkit.org>
1939
1940         clampTo(): do not convert the input to double when dealing with integers
1941         https://bugs.webkit.org/show_bug.cgi?id=194263
1942         <rdar://problem/47692312>
1943
1944         Reviewed by Darin Adler.
1945
1946         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1947         (TestWebKitAPI::testClampFloatingPointToFloatingPoint):
1948         (TestWebKitAPI::testClampFloatingPointToInteger):
1949         (TestWebKitAPI::testClampSameSignIntegers):
1950         (TestWebKitAPI::testClampUnsignedToSigned):
1951         (TestWebKitAPI::testClampSignedToUnsigned):
1952
1953 2019-02-07  Jonathan Bedard  <jbedard@apple.com>
1954
1955         webkitpy: Respect --dedicated-simulators flag
1956         https://bugs.webkit.org/show_bug.cgi?id=194416
1957         <rdar://problem/47894722>
1958
1959         Reviewed by Lucas Forschler.
1960
1961         * Scripts/webkitpy/port/device_port.py:
1962         (DevicePort.supported_device_types): If --dedicated-simulators is passed, all
1963         available devices can be safely ignored.
1964
1965 2019-02-07  Keith Rollin  <krollin@apple.com>
1966
1967         Remove extra copy of 100x100-red.tga
1968         https://bugs.webkit.org/show_bug.cgi?id=194371
1969         <rdar://problem/47873465>
1970
1971         Reviewed by Said Abou-Hallawa.
1972
1973         In order to help it pass its tests, Bug 194190 added a second copy of
1974         the file 100x100-red.tga. However, it turns out that this additional
1975         file wasn't actually needed, and that that sole previous copy was
1976         sufficient. At the same time, this second copy -- which was copied to
1977         the same location in the build output as the first copy -- now caused
1978         XCBuild to complain because there were two production rules for the
1979         same output file. Address this by removing the newly-added extra copy.
1980
1981         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1982         * TestWebKitAPI/Tests/mac/100x100-red.tga: Removed.
1983
1984 2019-02-07  Alex Christensen  <achristensen@webkit.org>
1985
1986         Deprecate WKBundlePageSetDefersLoading
1987         https://bugs.webkit.org/show_bug.cgi?id=191394
1988
1989         Reviewed by Dean Jackson.
1990
1991         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1992         (WTR::TestRunner::setDefersLoading):
1993
1994 2019-02-07  Zalan Bujtas  <zalan@apple.com>
1995
1996         [LFC][Out-of-flow] Use the containing block's padding width when computing min/max width.
1997         https://bugs.webkit.org/show_bug.cgi?id=194391
1998
1999         Reviewed by Antti Koivisto.
2000
2001         * LayoutReloaded/misc/LFC-passing-tests.txt:
2002
2003 2019-02-06  Keith Rollin  <krollin@apple.com>
2004
2005         Remove Info.plist from MobileMiniBrowser.framework's Copy Bundle Resources phase
2006         https://bugs.webkit.org/show_bug.cgi?id=193975
2007         <rdar://problem/47643306>
2008
2009         Reviewed by Tim Horton.
2010
2011         The MobileMiniBrowser.framework's Copy Bundle Resources phase copies
2012         the Info.plist file into the bundle. This step is not necessary as the
2013         implicit "bundle up all the build products into a framework" build
2014         phase does this already. Having the Copy Bundle Resources phase do
2015         this causes a conflict under XCBuild, which objects to two build
2016         phases producing the same file (Info.plist). Address this by removing
2017         Info.plist from the Copy Bundle Resources phase.
2018
2019         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
2020
2021 2019-02-06  Keith Rollin  <krollin@apple.com>
2022
2023         Really enable the automatic checking and regenerations of .xcfilelists during builds
2024         https://bugs.webkit.org/show_bug.cgi?id=194357
2025         <rdar://problem/47861231>
2026
2027         Reviewed by Chris Dumez.
2028
2029         Bug 194124 was supposed to enable the automatic checking and
2030         regenerating of .xcfilelist files during the build. While related
2031         changes were included in that patch, the change to actually enable the
2032         operation somehow was omitted. This patch actually enables the
2033         operation. The check-xcfilelist.sh scripts now check
2034         WK_DISABLE_CHECK_XCFILELISTS, and if it's "1", opts-out the developer
2035         from the checking.
2036
2037         * DumpRenderTree/Scripts/check-xcfilelists.sh:
2038         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
2039
2040 2019-02-06  David Kilzer  <ddkilzer@apple.com>
2041
2042         WTR::InjectedBundlePage::willSendRequestForFrame() leaks a WKDataRef
2043         <https://webkit.org/b/194286>
2044         <rdar://problem/47815558>
2045
2046         Reviewed by Alexey Proskuryakov.
2047
2048         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2049         (WTR::InjectedBundlePage::willSendRequestForFrame): Use
2050         WKRetainPtr<> to avoid leaking the WKDataRef.
2051
2052 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
2053
2054         Unreviewed, fix a typo
2055
2056         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
2057
2058 2019-02-06  Olivier Blin  <olivier.blin@softathome.com>
2059
2060         [GTK][WPE] force libpsl build to use ICU in jhbuild
2061         https://bugs.webkit.org/show_bug.cgi?id=194288
2062
2063         Reviewed by Carlos Garcia Campos.
2064
2065         * gtk/jhbuild.modules:
2066         Require ICU for libpsl build in jhbuild, like done in WPE.
2067
2068 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
2069
2070         REGRESSION(r240785): [SOUP] Broke cookie persistent storage
2071         https://bugs.webkit.org/show_bug.cgi?id=194209
2072
2073         Reviewed by Carlos Garcia Campos.
2074
2075         Enhance TestCookieManager to ensure this doesn't happen again.
2076
2077         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
2078         (testCookieManagerPersistentStorage):
2079         (beforeAll):
2080
2081 2019-02-05  Wenson Hsieh  <wenson_hsieh@apple.com>
2082
2083         Rename TestOptions.ignoreSynchronousMessagingTimeoutsForTesting
2084         https://bugs.webkit.org/show_bug.cgi?id=194324
2085
2086         Reviewed by Andy Estes.
2087
2088         Rename ignoreSynchronousMessagingTimeoutsForTesting to just ignoreSynchronousMessagingTimeouts. The -ForTesting
2089         part of the name is already implicit, since this is in testing code in TestOptions.
2090
2091         * WebKitTestRunner/TestController.cpp:
2092         (WTR::TestController::generateContextConfiguration const):
2093         (WTR::updateTestOptionsFromTestHeader):
2094         * WebKitTestRunner/TestOptions.h:
2095         (WTR::TestOptions::hasSameInitializationOptions const):
2096
2097 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2098
2099         [ews-build] Allow * as platform for builders and workers
2100         https://bugs.webkit.org/show_bug.cgi?id=188533
2101
2102         Reviewed by Lucas Forschler.
2103
2104         * BuildSlaveSupport/ews-build/loadConfig.py:
2105         (checkWorkersAndBuildersForConsistency):
2106
2107 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2108
2109         [ews-build] Add few bots to config.json
2110         https://bugs.webkit.org/show_bug.cgi?id=194304
2111
2112         Reviewed by Lucas Forschler.
2113
2114         * BuildSlaveSupport/ews-build/config.json:
2115
2116 2019-02-05  Keith Rollin  <krollin@apple.com>
2117
2118         Enable the automatic checking and regenerations of .xcfilelists during builds
2119         https://bugs.webkit.org/show_bug.cgi?id=194124
2120         <rdar://problem/47721277>
2121
2122         Reviewed by Tim Horton.
2123
2124         Bug 193790 add a facility for checking -- during build time -- that
2125         any needed .xcfilelist files are up-to-date and for updating them if
2126         they are not. This facility was initially opt-in by setting
2127         WK_ENABLE_CHECK_XCFILELISTS until other pieces were in place and until
2128         the process seemed robust. Its now time to enable this facility and
2129         make it opt-out. If there is a need to disable this facility, set and
2130         export WK_DISABLE_CHECK_XCFILELISTS=1 in your environment before
2131         running `make` or `build-webkit`, or before running Xcode from the
2132         command line.
2133
2134         Additionally, remove the step that generates a list of source files
2135         going into the UnifiedSources build step. It's only necessarily to
2136         specify Sources.txt and SourcesCocoa.txt as inputs.
2137
2138         * Scripts/generate-xcfilelists:
2139
2140 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
2141
2142         [GTK][WPE] force libpsl build to use ICU in jhbuild
2143         https://bugs.webkit.org/show_bug.cgi?id=194288
2144
2145         Reviewed by Philippe Normand.
2146
2147         In jhbuild, libpsl depends on ICU, but its configure script may decide to use libidn instead of ICU.
2148         This can cause build failures if libidn is detected but libunistring is not available.
2149
2150         Make sure that ICU is used for runtime and builtin PSL data.
2151
2152         * gtk/jhbuild.modules:
2153         * wpe/jhbuild.modules:
2154
2155 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2156
2157         [ews-app] Modified timestamp should be updated on updating data
2158         https://bugs.webkit.org/show_bug.cgi?id=194295
2159
2160         Reviewed by Lucas Forschler.
2161
2162         * BuildSlaveSupport/ews-app/ews/models/build.py:
2163         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2164         * BuildSlaveSupport/ews-app/ews/models/step.py:
2165
2166 2019-02-05  Ryan Haddad  <ryanhaddad@apple.com>
2167
2168         Unreviewed, rolling out r240742.
2169
2170         Causes crashes on iOS simulator.
2171
2172         Reverted changeset:
2173
2174         "[iOS] Keyups for non-modifier keys identified as "Dead" when
2175         not focused in a content-editable element"
2176         https://bugs.webkit.org/show_bug.cgi?id=192824
2177         https://trac.webkit.org/changeset/240742
2178
2179 2019-02-05  Jonathan Bedard  <jbedard@apple.com>
2180
2181         run-webkit-tests emits message "...running None" when running tests
2182         https://bugs.webkit.org/show_bug.cgi?id=194133
2183         <rdar://problem/47724738>
2184
2185         Reviewed by Lucas Forschler.
2186
2187         * Scripts/webkitpy/xcode/device_type.py:
2188         (DeviceType.__str__): Use both version mapping tables and use just the variant
2189         name if no version name is available.
2190         * Scripts/webkitpy/xcode/device_type_unittest.py:
2191         (DeviceTypeTest):
2192         (DeviceTypeTest.test_unmapped_version): Test case where the version does not have
2193         an associated named.
2194
2195 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
2196
2197         [WPE] require python3-setuptools for meson build in jhbuild
2198         https://bugs.webkit.org/show_bug.cgi?id=194287
2199
2200         Reviewed by Philippe Normand.
2201
2202         python3-setuptools is needed to build meson in jhbuild.
2203         It is already required by the GTK port.
2204
2205         * wpe/install-dependencies:
2206
2207 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2208
2209         [ews-app] Add method to save BuilderMapping to database
2210         https://bugs.webkit.org/show_bug.cgi?id=194264
2211
2212         Reviewed by Lucas Forschler.
2213
2214         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2215         (BuilderMapping.__str__):
2216         (BuilderMapping):
2217         (BuilderMapping.save_mapping):
2218         (BuilderMapping.update_mapping):
2219         (BuilderMapping.get_existing_mapping):
2220         (BuilderMapping.is_valid_mapping):
2221
2222 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2223
2224         [ews-app] Add timestamp fields for BuilderMappings
2225         https://bugs.webkit.org/show_bug.cgi?id=194266
2226
2227         Reviewed by Lucas Forschler.
2228
2229         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2230         (BuilderMapping):
2231
2232 2019-02-04  Ms2ger  <Ms2ger@igalia.com>
2233
2234         [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
2235         https://bugs.webkit.org/show_bug.cgi?id=174816
2236
2237         Reviewed by Michael Catanzaro.
2238
2239         Add tests for webkit_uri_for_display().
2240
2241         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
2242         (testURIForDisplayUnaffected):
2243         (testURIForDisplayAffected):
2244         (beforeAll):
2245         (afterAll):
2246         * TestWebKitAPI/glib/CMakeLists.txt:
2247
2248 2019-02-04  Jonathan Bedard  <jbedard@apple.com>
2249
2250         webkitpy: Precedence of booted devices should match precedence in DEFAULT_DEVICE_TYPES
2251         https://bugs.webkit.org/show_bug.cgi?id=194158
2252         <rdar://problem/47737268>
2253
2254         Rubber-stamped by Aakash Jain.
2255
2256         * Scripts/webkitpy/port/device_port.py:
2257         (DevicePort.supported_device_types): Sort supported device types by the DEFAULT_DEVICE_TYPES.
2258
2259 2019-02-04  Said Abou-Hallawa  <said@apple.com>
2260
2261         [CG] Enable setAdditionalSupportedImageTypes for WK1
2262         https://bugs.webkit.org/show_bug.cgi?id=194190
2263
2264         Reviewed by Tim Horton.
2265
2266         Add a test similar to the one under WebKit Cocoa but make it create a
2267         WebView instead of a WKWebView.
2268
2269         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2270         * TestWebKitAPI/Tests/mac/100x100-red.tga: Added.
2271         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.html: Added.
2272         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.mm: Added.
2273         (-[AdditionalSupportedImageTypesTest webView:didFinishLoadForFrame:]):
2274         (TestWebKitAPI::runTest):
2275         (TestWebKitAPI::TEST):
2276
2277 2019-02-04  Zalan Bujtas  <zalan@apple.com>
2278
2279         [First paint] Adjust "finishedParsingMainDocument" flag by taking deferred and async scripts into account.
2280         https://bugs.webkit.org/show_bug.cgi?id=194168
2281
2282         Reviewed by Simon Fraser.
2283
2284         Test if the firstVisuallyNoneEmpty milestone fires before the deferred script's post-message. 
2285
2286         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2287         * TestWebKitAPI/Tests/WebKit/FirstVisuallyNonEmptyMilestoneWithDeferredScript.mm: Added.
2288         (-[FirstPaintMessageHandler userContentController:didReceiveScriptMessage:]):
2289         (-[RenderingProgressNavigationDelegate _webView:renderingProgressDidChange:]):
2290         (TEST):
2291         * TestWebKitAPI/Tests/WebKit/deferred-script-load.html: Added.
2292         * TestWebKitAPI/Tests/WebKit/deferred-script.js: Added.
2293
2294 2019-02-04  Dean Johnson  <dean_johnson@apple.com>
2295
2296         REGRESSION (r237269): webkit-patch what-broke is broken 
2297         https://bugs.webkit.org/show_bug.cgi?id=193025
2298
2299         Reviewed by Aakash Jain.
2300
2301         * Scripts/webkitpy/common/host.py:
2302         (Host.buildbot):
2303         (Host.bugzilla): Renamed to 'buildbot'.
2304
2305 2019-02-04  Wenson Hsieh  <wenson_hsieh@apple.com>
2306
2307         [iOS] API test WKAttachmentTests.InsertAndRemoveDuplicateAttachment is failing after r240902
2308         https://bugs.webkit.org/show_bug.cgi?id=194207
2309
2310         Reviewed by Tim Horton.
2311
2312         Fix this API test by making it robust against smart paste on iOS. Currently, this test pastes an attachment
2313         element and assumes that the pasted attachment is adjacent to the original one. However, after enabling smart
2314         paste, we now insert an extra space in between. Instead of executing "DeleteBackward" twice to test removing the
2315         attachment elements, we delete backwards once to remove the pasted attachment, and move the selection to the
2316         start and delete forwards to remove the original attachment.
2317
2318         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2319         (TestWebKitAPI::TEST):
2320
2321 2019-02-04  Youenn Fablet  <youenn@apple.com>
2322
2323         Capture state should be managed consistently when doing process swapping
2324         https://bugs.webkit.org/show_bug.cgi?id=194122
2325         <rdar://problem/47609293>
2326
2327         Reviewed by Eric Carlson.
2328
2329         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2330         (-[GetUserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
2331         (-[GetUserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
2332         (-[GetUserMediaUIDelegate _webView:mediaCaptureStateDidChange:]):
2333         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2334         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2335         (WTR::TestRunner::isDoingMediaCapture const):
2336         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2337         * WebKitTestRunner/TestController.cpp:
2338         (WTR::TestController::isDoingMediaCapture const):
2339         * WebKitTestRunner/TestController.h:
2340         * WebKitTestRunner/TestInvocation.cpp:
2341         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2342         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2343         (WTR::TestController::isDoingMediaCapture const):
2344
2345 2019-02-03  Fujii Hironori  <Hironori.Fujii@sony.com>
2346
2347         [Win] WebKitTestRunners is failing to create the IndexedDB directory.
2348         https://bugs.webkit.org/show_bug.cgi?id=194142
2349
2350         Reviewed by Ross Kirsling.
2351
2352         There three 'separator' variables in TestController.cpp. Renamed
2353         it 'pathSeparator', and unified them.
2354
2355         * WebKitTestRunner/TestController.cpp:
2356         (WTR::TestController::generateContextConfiguration const):
2357         (WTR::createTestURL):
2358         (WTR::TestController::platformAdjustContext):
2359
2360 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
2361
2362         Make setNeedsLayout on the root more explicitly about triggering its side-effects
2363         https://bugs.webkit.org/show_bug.cgi?id=194198
2364
2365         Reviewed by Antti Koivisto.
2366
2367         No need to set the banner heights on navigation now, since Page stores them.
2368
2369         * MiniBrowser/mac/WK2BrowserWindowController.m:
2370         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
2371
2372 2019-02-03  John Wilander  <wilander@apple.com>
2373
2374         Parse and handle Ad Click Attribution attributes in HTMLAnchorElement::handleClick()
2375         https://bugs.webkit.org/show_bug.cgi?id=194104
2376         <rdar://problem/47649991>
2377
2378         Reviewed by Chris Dumez, Daniel Bates, and Darin Adler.
2379
2380         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
2381         (TestWebKitAPI::TEST):
2382             Changed numeric types from unsigned short to uint32_t.
2383
2384 2019-02-02  David Kilzer  <ddkilzer@apple.com>
2385
2386         Leak of NSArray (4.25 Kbytes) in com.apple.WebKit.WebContent running WebKit layout tests on iOS Simulator
2387         <https://webkit.org/b/194178>
2388         <rdar://problem/47753473>
2389
2390         Reviewed by Alexey Proskuryakov.
2391
2392         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
2393         (WTR::uninstallFakeHelvetica): Pass nullptr into
2394         CTFontManagerUnregisterFontsForURLs() to ignore any errors.
2395
2396 2019-02-02  Zalan Bujtas  <zalan@apple.com>
2397
2398         [LFC] Initialize ICB's style with fixed width/height.
2399         https://bugs.webkit.org/show_bug.cgi?id=194188
2400
2401         Reviewed by Antti Koivisto.
2402
2403         * LayoutReloaded/misc/LFC-passing-tests.txt:
2404
2405 2019-02-02  Zalan Bujtas  <zalan@apple.com>
2406
2407         [LFC] Add missing case to out-of-flow non-replaced horizontal used margin value computation
2408         https://bugs.webkit.org/show_bug.cgi?id=194185
2409
2410         Reviewed by Antti Koivisto.
2411
2412         * LayoutReloaded/misc/LFC-passing-tests.txt:
2413
2414 2018-12-16  Darin Adler  <darin@apple.com>
2415
2416         Convert additional String::format clients to alternative approaches
2417         https://bugs.webkit.org/show_bug.cgi?id=192746
2418
2419         Reviewed by Alexey Proskuryakov.
2420
2421         * WebKitTestRunner/TestController.cpp:
2422         (WTR::originUserVisibleName): Use makeString and reduce the use of std::string
2423         as an intermediate in code that ultimately constructs a WTF::String.
2424         (WTR::userMediaOriginHash): Use makeString.
2425         (WTR::TestController::didNavigateWithNavigationData): More of the same.
2426         (WTR::TestController::didPerformClientRedirect): Ditto.
2427         (WTR::TestController::didPerformServerRedirect): Ditto.
2428         (WTR::TestController::didUpdateHistoryTitle): Ditto.
2429
2430 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
2431
2432         [ews-build] Add unit test to verify builder keys
2433         https://bugs.webkit.org/show_bug.cgi?id=194152
2434
2435         Reviewed by Lucas Forschler.
2436
2437         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
2438         (ConfigDotJSONTest.test_builder_keys): Added unit-test.
2439
2440 2019-02-01  Zalan Bujtas  <zalan@apple.com>
2441
2442         [LFC] Expand tests coverage (12 new tests -> 787)
2443
2444         Unreviewed test gardening.
2445
2446         * LayoutReloaded/misc/LFC-passing-tests.txt:
2447
2448 2019-02-01  Zalan Bujtas  <zalan@apple.com>
2449
2450         [LFC] Fix statically positioned replaced out-of-flow horizontal geometry
2451         https://bugs.webkit.org/show_bug.cgi?id=194163
2452
2453         Reviewed by Simon Fraser.
2454
2455         775
2456
2457         * LayoutReloaded/misc/LFC-passing-tests.txt:
2458
2459 2019-02-01  Wenson Hsieh  <wenson_hsieh@apple.com>
2460
2461         [iOS] Consistent 1 sec hang when triggering modal alerts while handling synchronous touch events
2462         https://bugs.webkit.org/show_bug.cgi?id=194140
2463         <rdar://problem/47728098>
2464
2465         Reviewed by Tim Horton.
2466
2467         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2468         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2469         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
2470
2471         Add a new TestRunner hook to make modal JavaScript alerts dismiss asynchronously. This is used by the new layout
2472         test to induce an IPC deadlock when presenting a modal alert during touch start.
2473
2474         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2475         * WebKitTestRunner/TestController.cpp:
2476         (WTR::runJavaScriptAlert):
2477
2478         Add a client callback function for running JavaScript alerts.
2479
2480         (WTR::TestController::createOtherPage):
2481         (WTR::TestController::generateContextConfiguration const):
2482
2483         Add a test option to disable IPC timeouts for a layout test. This forces the test to reliably time out without
2484         the fix in this patch.
2485
2486         (WTR::TestController::createWebViewWithOptions):
2487
2488         Plumb TestOptions to generateContextConfiguration.
2489
2490         (WTR::TestController::resetPreferencesToConsistentValues):
2491         (WTR::TestController::resetStateToConsistentValues):
2492         (WTR::updateTestOptionsFromTestHeader):
2493         (WTR::TestController::setShouldDismissJavaScriptAlertsAsynchronously):
2494         (WTR::TestController::handleJavaScriptAlert):
2495         * WebKitTestRunner/TestController.h:
2496         * WebKitTestRunner/TestInvocation.cpp:
2497         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2498         * WebKitTestRunner/TestOptions.h:
2499         (WTR::TestOptions::hasSameInitializationOptions const):
2500
2501 2019-02-01  Chris Dumez  <cdumez@apple.com>
2502
2503         REGRESSION: Flaky ASSERTION FAILED: m_uncommittedState.state == State::Committed on http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page.html
2504         https://bugs.webkit.org/show_bug.cgi?id=193740
2505         <rdar://problem/47527267>
2506
2507         Reviewed by Alex Christensen.
2508
2509         Add API test coverage.
2510
2511         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2512
2513 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
2514
2515         [ews-app] Add display name field to BuilderMapping model
2516         https://bugs.webkit.org/show_bug.cgi?id=194153
2517
2518         Reviewed by Lucas Forschler.
2519
2520         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2521         (BuilderMapping):
2522
2523 2019-02-01  Youenn Fablet  <youenn@apple.com>
2524
2525         API Test broken: TestWebKitAPI.WebKit2.GetUserMediaReprompt
2526         https://bugs.webkit.org/show_bug.cgi?id=194155
2527
2528         Reviewed by Eric Carlson.
2529
2530         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
2531         Revert use of async functions as it seems it cannot be evaluated from TestWebKitAPI.
2532         Keep calling enumerateDevices to continue cover https://bugs.webkit.org/show_bug.cgi?id=194106.
2533
2534 2019-02-01  Zalan Bujtas  <zalan@apple.com>
2535
2536         [LFC] Adjust replaced element's intrinsic ratio
2537         https://bugs.webkit.org/show_bug.cgi?id=194154
2538
2539         Reviewed by Antti Koivisto.
2540
2541         761
2542
2543         * LayoutReloaded/misc/LFC-passing-tests.txt:
2544
2545 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2546
2547         [WPE] Show test results in minibrowser
2548         https://bugs.webkit.org/show_bug.cgi?id=194150
2549
2550         Reviewed by Žan Doberšek.
2551
2552         * Scripts/webkitpy/port/wpe.py:
2553         (WPEPort.show_results_html_file):
2554
2555 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2556
2557         [WPE] MiniBrowser: add ky bindings for back/forward navigation
2558         https://bugs.webkit.org/show_bug.cgi?id=194151
2559
2560         Reviewed by Žan Doberšek.
2561
2562         ALT + <- go back
2563         ALT + -> go forward
2564
2565         * MiniBrowser/wpe/main.cpp:
2566         (main):
2567
2568 2019-02-01  Zalan Bujtas  <zalan@apple.com>
2569
2570         [LFC] Set intrinsic size on Layout::Replaced
2571         https://bugs.webkit.org/show_bug.cgi?id=194139
2572
2573         Reviewed by Antti Koivisto.
2574
2575         744
2576
2577         * LayoutReloaded/misc/LFC-passing-tests.txt:
2578
2579 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2580
2581         [WPE] MiniBrowser: use g_file_new_for_commandline_arg
2582         https://bugs.webkit.org/show_bug.cgi?id=194146
2583
2584         Reviewed by Xabier Rodriguez-Calvar.
2585
2586         It allows to open relative paths.
2587
2588         * MiniBrowser/wpe/main.cpp:
2589         (main):
2590
2591 2019-01-31  Ryan Haddad  <ryanhaddad@apple.com>
2592
2593         Update flakiness dashboard configuration after recent queue changes
2594         https://bugs.webkit.org/show_bug.cgi?id=194127
2595
2596         Rubber-stamped by Aakash Jain.
2597
2598         Apple Windows queues were updated in r237755, and Sierra was removed in r239859.
2599
2600         * TestResultServer/static-dashboards/builders.jsonp:
2601
2602 2019-01-31  Youenn Fablet  <youenn@apple.com>
2603
2604         Add an API test to cover UIClient checkUserMediaPermissionForOrigin being nullptr
2605         https://bugs.webkit.org/show_bug.cgi?id=194106
2606         <rdar://problem/47676333>
2607
2608         Reviewed by Ryosuke Niwa.
2609
2610         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
2611         (TestWebKitAPI::didFinishNavigation):
2612         (TestWebKitAPI::TEST):
2613         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
2614
2615 2019-01-31  Chris Dumez  <cdumez@apple.com>
2616
2617         Page zoom level is lost after a process swap or a crash
2618         https://bugs.webkit.org/show_bug.cgi?id=194105
2619         <rdar://problem/47610781>
2620
2621         Reviewed by Alex Christensen.
2622
2623         Add API test coverage.
2624
2625         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2626         (-[PSONNavigationDelegate webView:didCommitNavigation:]):
2627
2628 2019-01-31  Alex Christensen  <achristensen@webkit.org>
2629
2630         Revert r238819 which is unneeded and caused a performance regression.
2631         https://bugs.webkit.org/show_bug.cgi?id=192272
2632         <rdar://problem/46664625>
2633
2634         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenPlugIn.mm:
2635         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didCommitLoadForFrame:]):
2636         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:willStartProvisionalLoadForFrame:completionHandler:]): Deleted.
2637
2638 2019-01-31  Jiewen Tan  <jiewen_tan@apple.com>
2639
2640         Formalize WebKitAdditions mechanism of LoadOptimizer
2641         https://bugs.webkit.org/show_bug.cgi?id=193886
2642         <rdar://problem/47696809>
2643
2644         Reviewed by Brent Fulgham.
2645
2646         * MiniBrowser/MiniBrowser.entitlements:
2647         Make com.apple.security.temporary-exception.mach-lookup.global-name an array.
2648
2649 2019-01-31  Zalan Bujtas  <zalan@apple.com>
2650
2651         [LFC] Margin before/after/start/end initial value is 0 and not auto.
2652         https://bugs.webkit.org/show_bug.cgi?id=194090
2653
2654         Reviewed by Antti Koivisto.
2655
2656         * LayoutReloaded/misc/LFC-passing-tests.txt:
2657
2658 2019-01-31  Zalan Bujtas  <zalan@apple.com>
2659
2660         [LFC] Use the used margin values in outOfFlowReplacedHorizontalGeometry consistently
2661         https://bugs.webkit.org/show_bug.cgi?id=194074
2662
2663         Reviewed by Antti Koivisto.
2664
2665         * LayoutReloaded/misc/LFC-passing-tests.txt:
2666
2667 2019-01-31  Zalan Bujtas  <zalan@apple.com>
2668
2669         [LFC][BFC] Add support for block level replaced box.
2670         https://bugs.webkit.org/show_bug.cgi?id=194071
2671
2672         Reviewed by Antti Koivisto.
2673
2674         * LayoutReloaded/misc/LFC-passing-tests.txt:
2675
2676 2019-01-31  Fujii Hironori  <Hironori.Fujii@sony.com>
2677
2678         Fix WebKitTestRunner's testPath with Windows full paths
2679         https://bugs.webkit.org/show_bug.cgi?id=194012
2680
2681         Reviewed by Alex Christensen.
2682
2683         updateTestOptionsFromTestHeader failed to open test files because
2684         testPath returned wrong file paths. It returned a path "/C:/..."
2685         if a URL "file:///C:/..." was given.
2686
2687         * WebKitTestRunner/TestController.cpp:
2688         (WTR::testPath): Removed the first '/' if the path starts with something like "/C:/".
2689
2690 2019-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
2691
2692         [WPE] Bump font related dependencies to match the GTK+ port
2693         https://bugs.webkit.org/show_bug.cgi?id=194017
2694
2695         Reviewed by Žan Doberšek.
2696
2697         * wpe/jhbuild.modules:
2698         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
2699         * wpe/patches/icudata-stdlibs.patch: Added.
2700
2701 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
2702
2703         Enable swipe tests on iOS
2704         https://bugs.webkit.org/show_bug.cgi?id=194076
2705
2706         Reviewed by Geoffrey Garen.
2707
2708         Removed the superflous call to prepareForAsyncTask and asyncTaskComplete as
2709         it causes a debug assertion failure in runUIScript.
2710
2711         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2712         (WTR::UIScriptController::beginBackSwipe):
2713         (WTR::UIScriptController::completeBackSwipe):
2714
2715 2019-01-30  Keith Rollin  <krollin@apple.com>
2716
2717         Use correct printf format specifier
2718         https://bugs.webkit.org/show_bug.cgi?id=194062
2719         <rdar://problem/47686167>
2720
2721         Reviewed by Alexey Proskuryakov.
2722
2723         LayoutTestSpellChecker.mm is trying to format a variable of type
2724         NSTextCheckingType with %tu (unsigned ptrdiff_t), when the type is
2725         actually an unsigned long long. Fix this by formatting with %llu.
2726
2727         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
2728         (-[LayoutTestTextCheckingResult description]):
2729
2730 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
2731
2732         REGRESSION(r240541): WebKit.WebsitePoliciesCustomJavaScriptUserAgent is failing since introduction on iOS
2733         https://bugs.webkit.org/show_bug.cgi?id=193979
2734
2735         Reviewed by Wenson Hsieh.
2736
2737         Fix the test for iOS. Make the test work with iOS UA string.
2738
2739         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2740
2741 2019-01-30  Ryan Haddad  <ryanhaddad@apple.com>
2742
2743         Replace High Sierra LLINT CLoop bot due to hardware failure
2744         https://bugs.webkit.org/show_bug.cgi?id=194066
2745
2746         Reviewed by Aakash Jain.
2747
2748         * BuildSlaveSupport/build.webkit.org-config/config.json:
2749
2750 2019-01-30  Keith Rollin  <krollin@apple.com>
2751
2752         [NSDragItem init] is unavailable
2753         https://bugs.webkit.org/show_bug.cgi?id=194059
2754         <rdar://problem/47685715>
2755
2756         Reviewed by Wenson Hsieh.
2757
2758         [NSDragItem init] is marked as NS_UNAVAILABLE. This affects
2759         DumpRenderTree and TestWebKitAPI, which both try to create an
2760         NSDragItem in a manner that invokes this method. Address this by using
2761         -initWithPasteboardWriter instead.
2762
2763         Note that the parameter passed to initWithPasteboardWriter is likely
2764         incorrect. In both cases, the object passed does not conform to
2765         NSPasteboardWriting. However, with this fix, we're no worse off than
2766         before, and can now perform builds with newer compilers and SDKs until
2767         a real fix can be crafted. That work is tracked in
2768         https://bugs.webkit.org/show_bug.cgi?id=194060
2769
2770         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
2771         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
2772         * TestWebKitAPI/mac/TestDraggingInfo.mm:
2773         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
2774
2775 2019-01-30  Daniel Bates  <dabates@apple.com>
2776
2777         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
2778         https://bugs.webkit.org/show_bug.cgi?id=192824
2779         <rdar://problem/47100332>
2780
2781         Reviewed by Wenson Hsieh.
2782
2783         Fix a bug where the wrong usage code was used for F13 thru F24.
2784
2785         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2786         (keyCodeForDOMFunctionKey):
2787
2788 2019-01-30  Chris Dumez  <cdumez@apple.com>
2789
2790         Regression(PSON) Load hang can occur on history navigation
2791         https://bugs.webkit.org/show_bug.cgi?id=194030
2792         <rdar://problem/47656939>
2793
2794         Reviewed by Antti Koivisto.
2795
2796         Add API test coverage.
2797
2798         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2799
2800 2019-01-30  Zalan Bujtas  <zalan@apple.com>
2801
2802         [LFC] Expand tests coverage.
2803
2804         Unreviewed test gardening.
2805
2806         * LayoutReloaded/misc/LFC-passing-tests.txt:
2807
2808 2019-01-30  Thibault Saunier  <tsaunier@igalia.com>
2809
2810         [Flatpak] Add openjpeg support
2811         https://bugs.webkit.org/show_bug.cgi?id=194019
2812
2813         Reviewed by Michael Catanzaro.
2814
2815         * flatpak/org.webkit.CommonModules.yaml:
2816
2817 2019-01-30  Commit Queue  <commit-queue@webkit.org>
2818
2819         Unreviewed, rolling out r240708.
2820         https://bugs.webkit.org/show_bug.cgi?id=194022
2821
2822         It broke WPE build (Requested by KaL on #webkit).
2823
2824         Reverted changeset:
2825
2826         "[WPE] Bump font related dependencies to match the GTK+ port"
2827         https://bugs.webkit.org/show_bug.cgi?id=194017
2828         https://trac.webkit.org/changeset/240708
2829
2830 2019-01-30  Zalan Bujtas  <zalan@apple.com>
2831
2832         [LFC][IFC] nextBreakablePosition returns the same position on hyphen characters
2833         https://bugs.webkit.org/show_bug.cgi?id=194001
2834
2835         Reviewed by Antti Koivisto.
2836
2837         * LayoutReloaded/misc/LFC-passing-tests.txt:
2838
2839 2019-01-30  Zalan Bujtas  <zalan@apple.com>
2840
2841         [LFC] Use the used margin values in outOfFlowReplacedVerticalGeometry consistently
2842         https://bugs.webkit.org/show_bug.cgi?id=194020
2843
2844         Reviewed by Antti Koivisto.
2845
2846         * LayoutReloaded/misc/LFC-passing-tests.txt:
2847
2848 2019-01-30  Chris Fleizach  <cfleizach@apple.com>
2849
2850         AX: Support color well on iOS
2851         https://bugs.webkit.org/show_bug.cgi?id=194010
2852
2853         Reviewed by Joanmarie Diggs.
2854
2855         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2856         (WTR::AccessibilityUIElement::stringAttributeValue):
2857
2858 2019-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
2859
2860         [WPE] Bump font related dependencies to match the GTK+ port
2861         https://bugs.webkit.org/show_bug.cgi?id=194017
2862
2863         Reviewed by Žan Doberšek.
2864
2865         * wpe/jhbuild.modules:
2866         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
2867         * wpe/patches/icudata-stdlibs.patch: Added.
2868
2869 2019-01-29  Alexey Proskuryakov  <ap@apple.com>
2870
2871         [Mac] Update window scale API usage
2872         https://bugs.webkit.org/show_bug.cgi?id=193991
2873         rdar://problem/47614795
2874
2875         Reviewed by Tim Horton.
2876
2877         * DumpRenderTree/mac/DumpRenderTree.mm:
2878         (changeWindowScaleIfNeeded):
2879         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
2880         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2881         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
2882
2883 2019-01-29  Chris Dumez  <cdumez@apple.com>
2884
2885         REGRESSION: ProcessSwap.DoSameSiteNavigationAfterCrossSiteProvisionalLoadStarted Failing on iOS
2886         https://bugs.webkit.org/show_bug.cgi?id=193977
2887         <rdar://problem/47643716>
2888
2889         Reviewed by Geoff Garen.
2890
2891         Update API test to address flakiness on iOS. Instead of doing the last navigation after receiving the
2892         didStartProvisionalLoad, do we right after we answer the navigation policy request. Flakiness was due
2893         to the previous provisional committing *before* we make the last load. 
2894
2895         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2896
2897 2019-01-29  Youenn Fablet  <youenn@apple.com>
2898
2899         Adopt new SPI to evaluate server certificate trust
2900         https://bugs.webkit.org/show_bug.cgi?id=193355
2901
2902         Reviewed by Alex Christensen.
2903
2904         Add infrastructure to handle HTTPS server trust evaluation testing.
2905
2906         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2907         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2908         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
2909         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
2910         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
2911         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2912         * WebKitTestRunner/TestController.cpp:
2913         (WTR::TestController::resetPreferencesToConsistentValues):
2914         (WTR::TestController::didReceiveAuthenticationChallenge):
2915         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
2916         * WebKitTestRunner/TestController.h:
2917         (WTR::TestController::serverTrustEvaluationCallbackCallsCount const):
2918         * WebKitTestRunner/TestInvocation.cpp:
2919         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2920         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2921         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
2922
2923 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2924
2925         [ews-build] Add build step to print bot Configuration
2926         https://bugs.webkit.org/show_bug.cgi?id=193887
2927
2928         Reviewed by Lucas Forschler.
2929
2930         * BuildSlaveSupport/ews-build/steps.py:
2931         (PrintConfiguration): Build step to print configuration.
2932         * BuildSlaveSupport/ews-build/factories.py:
2933
2934 2019-01-29  Chris Dumez  <cdumez@apple.com>
2935
2936         Regression (r240046): [PSON] Spurious changes to [WKWebView url] and [WKWebView loading] after [WKWebView loadRequest]
2937         https://bugs.webkit.org/show_bug.cgi?id=193967
2938         <rdar://problem/47635348>
2939
2940         Reviewed by Alex Christensen.
2941
2942         Add API test coverage.
2943
2944         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2945         (-[PSONLoadingObserver observeValueForKeyPath:ofObject:change:context:]):
2946
2947 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2948
2949         [ews-app] Handle incoming results data
2950         https://bugs.webkit.org/show_bug.cgi?id=193973
2951
2952         Reviewed by Lucas Forschler.
2953
2954         * BuildSlaveSupport/ews-app/ews/views/results.py:
2955
2956 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2957
2958         [ews-app] Make the results url generic
2959         https://bugs.webkit.org/show_bug.cgi?id=193928
2960
2961         Reviewed by Lucas Forschler.
2962
2963         * BuildSlaveSupport/ews-app/ews/urls.py:
2964
2965 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2966
2967         [ews-build] Configure buildbot to send events to ews-app
2968         https://bugs.webkit.org/show_bug.cgi?id=193968
2969
2970         Reviewed by Lucas Forschler.
2971
2972         * BuildSlaveSupport/ews-build/events.py: Added.
2973         * BuildSlaveSupport/ews-build/master.cfg:
2974
2975 2019-01-29  Keith Rollin  <krollin@apple.com>
2976
2977         Add .xcfilelists to Run Script build phases
2978         https://bugs.webkit.org/show_bug.cgi?id=193792
2979         <rdar://problem/47201785>
2980
2981         Reviewed by Alex Christensen.
2982
2983         As part of supporting XCBuild, update the necessary Run Script build
2984         phases in their Xcode projects to refer to their associated
2985         .xcfilelist files.
2986
2987         Note that the addition of these files bumps the Xcode project version
2988         number to something that's Xcode 10 compatible. This change means that
2989         older versions of the Xcode IDE can't read these projects. Nor can it
2990         fully load workspaces that refer to these projects (the updated
2991         projects are shown as non-expandable placeholders). `xcodebuild` can
2992         still build these projects; it's just that the IDE can't open them.
2993
2994         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2995         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2996
2997 2019-01-29  John Wilander  <wilander@apple.com>
2998
2999         Add data abstraction and validation for Ad Click Attribution
3000         https://bugs.webkit.org/show_bug.cgi?id=193916
3001         <rdar://problem/47603481>
3002
3003         Reviewed by Daniel Bates, Brent Fulgham, and Alex Christensen.
3004
3005         Ad click attribution has two steps. First, the storage of an ad
3006         campaign ID for a click that takes the user to a destination
3007         site. Second, a conversion on the destination site that can be
3008         attributed to the ad click.
3009
3010         This patch adds a class that represents a request for ad click
3011         attribution. Validation makes sure that the bits of entropy
3012         reported through this mechanism is limited.
3013
3014         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3015         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp: Added.
3016         (TestWebKitAPI::TEST):
3017
3018 2019-01-29  Chris Dumez  <cdumez@apple.com>
3019
3020         REGRESSION (PSON): Twitter link gets stuck at t.co after navigating back in tab
3021         https://bugs.webkit.org/show_bug.cgi?id=193932
3022         <rdar://problem/47598947>
3023
3024         Reviewed by Brady Eidson.
3025
3026         Add API test coverage.
3027
3028         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3029
3030 2019-01-29  Zalan Bujtas  <zalan@apple.com>
3031
3032         Adding new passing LFC tests.
3033
3034         Unreviewed test gardening.
3035
3036         * LayoutReloaded/misc/LFC-passing-tests.txt:
3037
3038 2019-01-29  Zalan Bujtas  <zalan@apple.com>
3039
3040         [LFC][BFC][MarginCollapsing] Remove incorrect downcast<Container>
3041         https://bugs.webkit.org/show_bug.cgi?id=193964
3042
3043         Reviewed by Antti Koivisto.
3044
3045         * LayoutReloaded/misc/LFC-passing-tests.txt:
3046
3047 2019-01-29  Zalan Bujtas  <zalan@apple.com>
3048
3049         [LFC][BFC] Do not ignore next sibling box while laying out BFC.
3050         https://bugs.webkit.org/show_bug.cgi?id=193954
3051
3052         Reviewed by Antti Koivisto.
3053
3054         * LayoutReloaded/misc/LFC-passing-tests.txt:
3055
3056 2019-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
3057
3058         WebDriver: add support for running subtests
3059         https://bugs.webkit.org/show_bug.cgi?id=193904
3060
3061         Reviewed by Michael Catanzaro.
3062
3063         pytest already supports it by passing test.py::subtest, so we can do the same.
3064
3065         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
3066         (get_item_name): Made this global.
3067         (CollectRecorder.__init__): Receive the parameter to ignore.
3068         (CollectRecorder.pytest_collectreport): Collect also the subtests.
3069         (TestExpectationsMarker.pytest_collection_modifyitems): Use get_item_name().
3070         (collect): Add parameter to ignore.
3071         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
3072         (WebDriverSeleniumExecutor.collect): Pass the driver name as parameter to ignore.
3073         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
3074         (WebDriverTestRunnerSelenium.collect_tests): Handle subtest name in test path.
3075         (WebDriverTestRunnerSelenium.run): Ditto.
3076         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
3077         (WebDriverTestRunnerW3C.collect_tests): Ditto.
3078         (WebDriverTestRunnerW3C.run): Ditto.
3079
3080 2019-01-28  Ryosuke Niwa  <rniwa@webkit.org>
3081
3082         User agent string override for navigator.userAgent should be site specific quirks
3083         https://bugs.webkit.org/show_bug.cgi?id=193950
3084
3085         Reviewed by Brent Fulgham.
3086
3087         Updated per the _WKWebsitePolicies rename.
3088
3089         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3090         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3091
3092 2019-01-28  Ross Kirsling  <ross.kirsling@sony.com>
3093
3094         Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
3095         https://bugs.webkit.org/show_bug.cgi?id=193941
3096
3097         Reviewed by Alex Christensen.
3098
3099         * TestWebKitAPI/Tests/WTF/ConcurrentPtrHashSet.cpp:
3100         * TestWebKitAPI/Tests/WTF/Condition.cpp:
3101         * TestWebKitAPI/Tests/WTF/Lock.cpp:
3102         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
3103         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
3104         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
3105         * TestWebKitAPI/Tests/WTF/ScopedLambda.cpp:
3106         * TestWebKitAPI/Tests/WTF/Time.cpp:
3107         * TestWebKitAPI/Tests/WTF/UniqueArray.cpp:
3108         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
3109         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
3110         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
3111
3112 2019-01-28  Yusuke Suzuki  <ysuzuki@apple.com>
3113
3114         Unreviewed, reorder my emails to fix autocomplete in bugzilla
3115
3116         * Scripts/webkitpy/common/config/contributors.json:
3117
3118 2019-01-28  Andy Estes  <aestes@apple.com>
3119
3120         [watchOS] Enable Parental Controls content filtering
3121         https://bugs.webkit.org/show_bug.cgi?id=193939
3122         <rdar://problem/46641912>
3123
3124         Reviewed by Ryosuke Niwa.
3125
3126         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3127
3128 2019-01-28  David Kilzer  <ddkilzer@apple.com>
3129
3130         REGRESSION (r236481): Move soft-linking of LocalAuthentication.framework out of LocalAuthenticationSoftLink.h
3131         <https://webkit.org/b/193884>
3132
3133         Reviewed by Jiewen Tan.
3134
3135         * Scripts/webkitpy/style/checkers/cpp.py:
3136         (check_language): Add LocalAuthentication to
3137         `frameworks_with_soft_links`.
3138
3139 2019-01-28  Fujii Hironori  <Hironori.Fujii@sony.com>
3140
3141         [Win][WebKitTestRunner] Error: test and reference images have different sizes. Test image is 784x561, reference image is 800x600
3142         https://bugs.webkit.org/show_bug.cgi?id=193891
3143
3144         Reviewed by Ross Kirsling.
3145
3146         There were three problems in window sizes of WebView and the host window.
3147         1. The sizes of pixel image output were incorrect.
3148         2. The host window is going to appear after window.resize was invoked.
3149         3. window.resize resized only the host window, not WebView.
3150
3151         This change solves them with a following approach.
3152         a. PlatformWebView::PlatformWebView creates the initial host window as zero size.
3153         b. Changes the host window style from WS_OVERLAPPEDWINDOW to WS_POPUP
3154            as well as DumpRenderTree in order to match the client area and the window area.
3155         c. PlatformWebView::resizeTo simply calls PlatformWebView::setWindowFrame as well as Mac port and GTK port.
3156         d. PlatformWebView::setWindowFrame changes both window sizes.
3157         e. PlatformWebView::setWindowFrame moves the host window to the out side of screen if m_options.shouldShowWebView.
3158
3159         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3160         (WTR::PlatformWebView::PlatformWebView): Create the host window
3161         and WebView as zero size. Use WS_POPUP instead of WS_OVERLAPPEDWINDOW.
3162         (WTR::PlatformWebView::resizeTo): Calls PlatformWebView::setWindowFrame.
3163         (WTR::PlatformWebView::setWindowFrame): Change both window sizes.
3164
3165 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
3166
3167         [ews-app] Add method to save Step data to database
3168         https://bugs.webkit.org/show_bug.cgi?id=193890
3169
3170         Reviewed by Lucas Forschler.
3171
3172         * BuildSlaveSupport/ews-app/ews/models/step.py:
3173         (Step.save_step): Method to save step data.
3174         (Step.update_step): Method to update step data.
3175         (Step.get_existing_step): Method to fetch existing step from database.
3176         (Step.is_valid_result): Method to validate valid step result.
3177
3178 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
3179
3180         [ews-app] Add method to save Build data to database
3181         https://bugs.webkit.org/show_bug.cgi?id=193735
3182
3183         Reviewed by Lucas Forschler.
3184
3185         * BuildSlaveSupport/ews-app/ews/models/build.py:
3186         (Build.save_build): Method to save build information to database.
3187         (Build.get_existing_build): Method to fetch existing build from database.
3188         (Build.is_valid_result): Method to validate build result.
3189         * BuildSlaveSupport/ews-app/ews/common/util.py:
3190         (is_valid_int_id): Method to validate valid id.
3191
3192 2019-01-28  Chris Dumez  <cdumez@apple.com>
3193
3194         Regression(PSON) Crash under WebPageProxy::didStartProgress()
3195         https://bugs.webkit.org/show_bug.cgi?id=193915
3196         <rdar://problem/47560907>
3197
3198         Reviewed by Alex Christensen.
3199
3200         Add API test coverage.
3201
3202         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3203
3204 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
3205
3206         [ews-app] Rename id variables
3207         https://bugs.webkit.org/show_bug.cgi?id=193883
3208
3209         Reviewed by Lucas Forschler.
3210
3211         * BuildSlaveSupport/ews-app/ews/models/build.py:
3212         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
3213         * BuildSlaveSupport/ews-app/ews/models/step.py:
3214         * BuildSlaveSupport/ews-app/ews/urls.py:
3215         * BuildSlaveSupport/ews-app/ews/views/patch.py:
3216         * BuildSlaveSupport/ews-app/ews/views/results.py:
3217         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3218
3219 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
3220
3221         [ews-app] Allow certain fields to be empty
3222         https://bugs.webkit.org/show_bug.cgi?id=193892
3223
3224         Reviewed by Lucas Forschler.
3225
3226         * BuildSlaveSupport/ews-app/ews/models/build.py:
3227         * BuildSlaveSupport/ews-app/ews/models/step.py:
3228
3229 2019-01-28  Rob Buis  <rbuis@igalia.com>
3230
3231         Update MIME type parser
3232         https://bugs.webkit.org/show_bug.cgi?id=180526
3233
3234         Reviewed by Frédéric Wang.
3235
3236         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
3237         (TestWebKitAPI::TEST):
3238
3239 2019-01-28  Zalan Bujtas  <zalan@apple.com>
3240
3241         [LFC][MarginCollapsing][Quirks] Quirk margin values get propagated through margin collapsing
3242         https://bugs.webkit.org/show_bug.cgi?id=193896
3243
3244         Reviewed by Antti Koivisto.
3245
3246         * LayoutReloaded/misc/LFC-passing-tests.txt:
3247
3248 2018-12-15  Darin Adler  <darin@apple.com>
3249
3250         Replace many uses of String::format with more type-safe alternatives
3251         https://bugs.webkit.org/show_bug.cgi?id=192742
3252
3253         Reviewed by Mark Lam.
3254
3255         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3256         (WTR::cacheTestRunnerCallback): Use makeString.
3257         * WebKitTestRunner/TestController.cpp:
3258         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
3259         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
3260
3261 2019-01-27  Jiewen Tan  <jiewen_tan@apple.com>
3262
3263         Use a load optimizer for some sites
3264         https://bugs.webkit.org/show_bug.cgi?id=193881
3265         <rdar://problem/46325455>
3266
3267         Reviewed by Brent Fulgham.
3268
3269         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3270         * TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm: Added.
3271
3272 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
3273
3274         AX: Introduce a static accessibility tree
3275         https://bugs.webkit.org/show_bug.cgi?id=193348
3276         <rdar://problem/47203295>
3277
3278         Reviewed by Ryosuke Niwa.
3279
3280         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3281
3282 2019-01-26  Zalan Bujtas  <zalan@apple.com>
3283
3284         [LFC] The default values for top/bottom in contentHeightForFormattingContextRoot should not be 0.
3285         https://bugs.webkit.org/show_bug.cgi?id=193867
3286
3287         Reviewed by Antti Koivisto.
3288
3289         * LayoutReloaded/misc/LFC-passing-tests.txt:
3290
3291 2019-01-26  Zalan Bujtas  <zalan@apple.com>
3292
3293         [LFC][BFC] Ignore last inflow child's collapsed through margin after when computing containing block's height.
3294         https://bugs.webkit.org/show_bug.cgi?id=193865
3295
3296         Reviewed by Antti Koivisto.
3297
3298         * LayoutReloaded/misc/LFC-passing-tests.txt:
3299
3300 2019-01-25  Ryosuke Niwa  <rniwa@webkit.org>
3301
3302         Need a mechanism to override navigator.userAgent
3303         https://bugs.webkit.org/show_bug.cgi?id=193762
3304         <rdar://problem/47504939>
3305
3306         Reviewed by Brent Fulgham.
3307
3308         Added test cases for _WKWebsitePolicies.customJavaScriptUserAgent.
3309
3310         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3311         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3312         (-[CustomJavaScriptUserAgentDelegate webView:didFinishNavigation:]):
3313
3314 2019-01-25  Dean Jackson  <dino@apple.com>
3315
3316         REGRESSION: Some USDz from 3rd party websites don't go directly to AR QL
3317         https://bugs.webkit.org/show_bug.cgi?id=193831
3318         <rdar://problem/47399263>
3319
3320         Reviewed by Chris Dumez.
3321
3322         Two new tests that exercise cross-origin and same-origin System
3323         Previews.
3324
3325         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3326
3327 2019-01-25  Keith Rollin  <krollin@apple.com>
3328
3329         Update Xcode projects with "Check .xcfilelists" build phase
3330         https://bugs.webkit.org/show_bug.cgi?id=193790
3331         <rdar://problem/47201374>
3332
3333         Reviewed by Alex Christensen.
3334
3335         Support for XCBuild includes specifying inputs and outputs to various
3336         Run Script build phases. These inputs and outputs are specified as
3337         .xcfilelist files. Once created, these .xcfilelist files need to be
3338         kept up-to-date. In order to check that they are up-to-date or not,
3339         add an Xcode build step that invokes an external script that performs
3340         the checking. If the .xcfilelists are found to be out-of-date, update
3341         them, halt the build, and instruct the developer to restart the build
3342         with up-to-date files.
3343
3344         At this time, the checking and regenerating is performed only if the
3345         WK_ENABLE_CHECK_XCFILELISTS environment variable is set to 1. People
3346         who want to use this facility can set this variable and test out the
3347         checking/regenerating. Once it seems like there are no egregious
3348         issues that upset a developer's workflow, we'll unconditionally enable
3349         this facility.
3350
3351         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3352         * DumpRenderTree/Scripts/check-xcfilelists.sh: Added.
3353         * WebKitTestRunner/Scripts/check-xcfilelists.sh: Added.
3354         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3355
3356 2019-01-25  Keith Rollin  <krollin@apple.com>
3357
3358         Update Xcode projects with "Apply Configuration to XCFileLists" build target
3359         https://bugs.webkit.org/show_bug.cgi?id=193781
3360         <rdar://problem/47201153>
3361
3362         Reviewed by Alex Christensen.
3363
3364         Part of generating the .xcfilelists used as part of adopting XCBuild
3365         includes running `make DerivedSources.make` from a standalone script.
3366         It’s important for this invocation to have the same environment as
3367         when the actual build invokes `make DerivedSources.make`. If the
3368         environments are different, then the two invocations will provide
3369         different results. In order to get the same environment in the
3370         standalone script, have the script launch xcodebuild targeting the
3371         "Apply Configuration to XCFileLists" build target, which will then
3372         re-invoke our standalone script. The script is now running again, this
3373         time in an environment with all workspace, project, target, xcconfig
3374         and other environment variables established.
3375
3376         The "Apply Configuration to XCFileLists" build target accomplishes
3377         this task via a small embedded shell script that consists only of:
3378
3379             eval "${WK_SUBLAUNCH_SCRIPT_PARAMETERS[@]}"
3380
3381         The process that invokes "Apply Configuration to XCFileLists" first
3382         sets WK_SUBLAUNCH_SCRIPT_PARAMETERS to an array of commands to be
3383         evaluated and exports it into the shell environment. When xcodebuild
3384         is invoked, it inherits the value of this variable and can `eval` the
3385         contents of that variable. Our external standalone script can then set
3386         WK_SUBLAUNCH_SCRIPT_PARAMETERS to the path to itself, along with a set
3387         of command-line parameters needed to restart itself in the appropriate
3388         state.
3389
3390         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3391         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3392
3393 2019-01-25  Alex Christensen  <achristensen@webkit.org>
3394
3395         Add SPI to inform an application that "Go Back" has been clicked from a safe browsing warning
3396         https://bugs.webkit.org/show_bug.cgi?id=193802
3397         <rdar://problem/46010580>
3398
3399         Reviewed by Andy Estes.
3400
3401         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3402         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]):
3403         (TEST):
3404
3405 2019-01-25  Daniel Bates  <dabates@apple.com>
3406
3407         [iOS] uiController.keyDown() does not translate Control modified key
3408         https://bugs.webkit.org/show_bug.cgi?id=192898
3409
3410         Reviewed by Wenson Hsieh.
3411
3412         Implement uiController.keyDown() in terms of HIDEventGenerator so that UIKit performs
3413         key translation, as applicable. Among other cases, key translation occurs when performing
3414         a Control key modified key sequence. Writing uiController.keyDown() in terms of HIDEventGenerator
3415         also makes the behavior of uiController.keyDown() more closely match the behavior of a
3416         human pressing down and releasing key(s) using a hardware keyboard.
3417
3418         * WebKitTestRunner/ios/HIDEventGenerator.h:
3419         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3420         (-[HIDEventGenerator sendMarkerHIDEventWithCompletionBlock:]): Renamed; formerly named _sendMarkerHIDEventWithCompletionBlock.
3421
3422         (-[HIDEventGenerator touchDown:touchCount:completionBlock:]):
3423         (-[HIDEventGenerator liftUp:touchCount:completionBlock:]):
3424         (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
3425         (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
3426         (-[HIDEventGenerator stylusUpAtPoint:completionBlock:]):
3427         (-[HIDEventGenerator stylusTapAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
3428         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
3429         (-[HIDEventGenerator longPress:completionBlock:]):
3430         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
3431         Update code for above renaming.
3432
3433         (hidUsageCodeForCharacter): Translate \b to a backspace and teach this function to recognize the
3434         DumpRenderTree EventSender-compatible modifier key names (e.g. "metaKey").
3435
3436         (-[HIDEventGenerator keyDown:]): Added.
3437         (-[HIDEventGenerator keyUp:]): Added.
3438         (-[HIDEventGenerator keyPress:completionBlock:]):
3439         (-[HIDEventGenerator eventDispatchThreadEntry:]):
3440         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]): Deleted; renamed to sendMarkerHIDEventWithCompletionBlock.
3441         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3442         (WTR::parseModifierArray): Modified to return a vector of strings that represent the modifier keys to press.
3443         (WTR::UIScriptController::keyDown): Write in terms of HIDEventGenerator.
3444         (WTR::parseModifier): Deleted.
3445
3446 2019-01-25  Keith Rollin  <krollin@apple.com>
3447
3448         Complete the implementation of generate-xcfilelists
3449         https://bugs.webkit.org/show_bug.cgi?id=193782
3450
3451         Reviewed by Alex Christensen.
3452
3453         A preliminary version of generate-xcfilelists was added in r238008.
3454         This patch updates that script in order to:
3455
3456         - Support checking of .xcfilelists
3457         - Perform better execution of `make DerivedSources.make` by
3458           relaunching generate-xcfilelists under xcodebuild
3459         - Support incremental generation and checking of .xcfilelists
3460         - Support supplementary .xcfilelists files from WebKitAdditions
3461         - Support being wrapped by parallel version of generate-xcfilelists in
3462           Internal that adds support for (re)generating WebKit projects in
3463           that repo.
3464         - Support builds that have been performed in WebKitBuild as well as
3465           ~/Library/Developer/code/DerivedData
3466         - Increase robustness and debugging facilities.
3467
3468         * Scripts/generate-xcfilelists:
3469
3470 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
3471
3472         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
3473         https://bugs.webkit.org/show_bug.cgi?id=193297
3474         <rdar://problem/47158841>
3475
3476         Unreviewed test case fix.
3477
3478         These test cases require ResourceLoadStatistics to be active, so the feature must be turned on.
3479         Previously, the default data store turned the feature on automatically, allowing these tests to pass.
3480
3481         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
3482         (TEST):
3483
3484 2019-01-25  Keith Rollin  <krollin@apple.com>
3485
3486         Update existing .xcfilelists
3487         https://bugs.webkit.org/show_bug.cgi?id=193791
3488         <rdar://problem/47201706>
3489
3490         Reviewed by Alex Christensen.
3491
3492         Many .xcfilelist files were added in r238824 in order to support
3493         XCBuild. Update these with recent changes to the set of build files
3494         and with the current generate-xcfilelist script.
3495
3496         * DumpRenderTree/DerivedSources-input.xcfilelist:
3497         * DumpRenderTree/DerivedSources-output.xcfilelist:
3498         * WebKitTestRunner/DerivedSources-input.xcfilelist:
3499         * WebKitTestRunner/DerivedSources-output.xcfilelist:
3500
3501 2019-01-25  Keith Rollin  <krollin@apple.com>
3502
3503         Fix missing dependencies in extract-dependencies-from-makefile
3504         https://bugs.webkit.org/show_bug.cgi?id=193783
3505         <rdar://problem/47201571>
3506
3507         Reviewed by Alex Christensen.
3508
3509         The extract-dependencies-from-makefile script generates .xcfilelists
3510         for XCBuild by invoking a makefile in --debug mode, parsing the
3511         dependency information in the output, and extracting information
3512         regarding targets and dependents. However, the way `make` emits this
3513         dependency information is not rigorous, and so we need to determine
3514         what lines to look for and parse by trial and error. This approach
3515         didn't coriginally atch all the information we needed to collect, so
3516         update the script to look for the additional lines we now know to look
3517         for.
3518
3519         * Scripts/extract-dependencies-from-makefile:
3520         (Parser):
3521         (Parser.addTarget):
3522         (Parser.addPrereq):
3523         (Parser.doParse):
3524
3525 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
3526
3527         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
3528         https://bugs.webkit.org/show_bug.cgi?id=193297
3529         <rdar://problem/47158841>
3530
3531         Reviewed by Alex Christensen.
3532
3533         * TestWebKitAPI/Tests/WebKit Cocoa/ResourceLoadStatistics.mm:
3534             Revise tests to ensure a running NetworkProcess before attempting ResourceLoadStatistics operations.
3535         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3536         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
3537         activating the message used to trigger the callback when it is set.
3538
3539 2019-01-25  Alex Christensen  <achristensen@webkit.org>
3540
3541         WKWebView.goBack should reload if there is a safe browsing warning
3542         https://bugs.webkit.org/show_bug.cgi?id=193805
3543         <rdar://problem/46908216>
3544
3545         Reviewed by Geoff Garen.
3546
3547         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3548         (+[Simple3LookupContext sharedLookupContext]):
3549         (-[Simple3LookupContext lookUpURL:completionHandler:]):
3550         (-[WKWebViewGoBackNavigationDelegate webView:didFinishNavigation:]):
3551         (TEST):
3552
3553 2019-01-25  Chris Dumez  <cdumez@apple.com>
3554
3555         Regression(PSON) cross-site provisional page is not canceled if a new same-site one is started
3556         https://bugs.webkit.org/show_bug.cgi?id=193788
3557         <rdar://problem/47531231>
3558
3559         Reviewed by Alex Christensen.
3560
3561         Add API test coverage.
3562
3563         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3564         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
3565
3566 2019-01-25  Jonathan Bedard  <jbedard@apple.com>
3567
3568         webkitpy: Missing PID in crashlog name should not be fatal (Follow-up fix)
3569         https://bugs.webkit.org/show_bug.cgi?id=193771
3570
3571         Unreviewed infrastructure fix.
3572
3573         * Scripts/webkitpy/port/darwin.py:
3574         (DarwinPort._merge_crash_logs): Correct syntax for catching multiple exception types.
3575
3576 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
3577
3578         * Scripts/webkitpy/common/config/contributors.json: Removing a stray comma.
3579
3580 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
3581
3582         Add contributors.json entries for Ling Ho and for a new bot watchers group.
3583
3584         * Scripts/webkitpy/common/config/contributors.json:
3585
3586 2019-01-25  Chris Dumez  <cdumez@apple.com>
3587
3588         Regression(PSON?) Crash under NavigationState::NavigationClient::decidePolicyForNavigationAction()
3589         https://bugs.webkit.org/show_bug.cgi?id=193779
3590         <rdar://problem/46170903>
3591
3592         Reviewed by Antti Koivisto.
3593
3594         Add API test that quickly navigates forward to a previous process without waiting for it to
3595         suspend. I suspect the crash could have been happening due to receiving leftover IPC from
3596         the process' previous page when reconnecting the it for the forward navigation.
3597
3598         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3599
3600 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
3601
3602         Need a way for JavaScript (or bundle) code to participate in undo
3603         https://bugs.webkit.org/show_bug.cgi?id=190009
3604         <rdar://problem/44807048>
3605
3606         Reviewed by Ryosuke Niwa.
3607
3608         Add UIScriptController helpers to grab the platform undo and redo action labels. Currently only implemented for
3609         Cocoa platforms in WebKit2. See other ChangeLogs for more detail.
3610
3611         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3612         (WTR::UIScriptController::lastUndoLabel const):
3613         (WTR::UIScriptController::firstRedoLabel const):
3614         (WTR::UIScriptController::platformUndoManager const):
3615         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3616         (WTR::UIScriptController::lastUndoLabel const):
3617         (WTR::UIScriptController::firstRedoLabel const):
3618         (WTR::UIScriptController::platformUndoManager const):
3619         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3620         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3621         (WTR::UIScriptController::lastUndoLabel const):
3622         (WTR::UIScriptController::firstRedoLabel const):
3623         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3624         * WebKitTestRunner/UIScriptControllerCocoa.mm:
3625         (WTR::UIScriptController::lastUndoLabel const):
3626         (WTR::UIScriptController::firstRedoLabel const):
3627         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3628         (WTR::UIScriptController::platformUndoManager const):
3629         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
3630         (WTR::UIScriptController::platformUndoManager const):
3631
3632 2019-01-25  Zalan Bujtas  <zalan@apple.com>
3633
3634         [LFC][BFC][MarginCollapsing] Add "clear" to static position computation.
3635         https://bugs.webkit.org/show_bug.cgi?id=193824
3636
3637         Reviewed by Antti Koivisto.
3638
3639         * LayoutReloaded/misc/LFC-passing-tests.txt:
3640
3641 2019-01-24  Ryan Haddad  <ryanhaddad@apple.com>
3642
3643         Update macOS JSC bot configurations
3644         https://bugs.webkit.org/show_bug.cgi?id=193739
3645
3646         Reviewed by Alexey Proskuryakov.
3647
3648         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove 32-bit BuildAndTest queue.
3649         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3650         (BubbleQueueServer): Move JSC EWS to Mojave section.
3651         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3652         (WebKitBuildbot): Remove 32-bit BuildAndTest queue from dashboard.
3653         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update unit test.
3654
3655 2019-01-24  Fujii Hironori  <Hironori.Fujii@sony.com>
3656
3657         [Win][WebKitTestRunner] Implement EventSenderProxy
3658         https://bugs.webkit.org/show_bug.cgi?id=193755
3659
3660         Reviewed by Don Olmstead.
3661
3662         * WebKitTestRunner/EventSenderProxy.h: Removed unused members m_buttonState and m_mouseButtonsCurrentlyDown.
3663         * WebKitTestRunner/win/EventSenderProxyWin.cpp:
3664         (WTR::EventSenderProxy::dispatchMessage):
3665         (WTR::EventSenderProxy::EventSenderProxy):
3666         (WTR::EventSenderProxy::mouseDown):
3667         (WTR::EventSenderProxy::mouseUp):
3668         (WTR::EventSenderProxy::mouseMoveTo):
3669         (WTR::EventSenderProxy::mouseScrollBy):
3670         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
3671
3672 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
3673
3674         Unreviewed fix for API test failure after r240437.
3675
3676         TestWTF.WTF.StringOperators apparently can't deal with another test using String::operator+. This is fine...
3677
3678         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
3679
3680 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
3681
3682         [webkitdirs] iosSimulatorApplicationsPath may not have iOS.simruntime in its path
3683         https://bugs.webkit.org/show_bug.cgi?id=193787
3684         <rdar://problem/47497634>
3685
3686         Reviewed by Alexey Proskuryakov.
3687
3688         * Scripts/webkitdirs.pm:
3689         (iosSimulatorApplicationsPath): Pick from available runtime directories.
3690
3691 2019-01-24  Truitt Savell  <tsavell@apple.com>
3692
3693         Unreviewed, rolling out r240446.
3694
3695         Casued 5 API failures
3696
3697         Reverted changeset: