Tools/ChangeLog

   1 2015-09-30  Jason Marcell  <jmarcell@apple.com>
   2
   3         BuildbotQueueView.prototype._appendPendingRevisionCount should skip repositories that don't
   4         have an associated trac instance.
   5         https://bugs.webkit.org/show_bug.cgi?id=149673
   6
   7         Reviewed by Alexey Proskuryakov.
   8
   9         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
  10         (BuildbotQueueView.prototype._appendPendingRevisionCount): Skip repositories that don't
  11         have an associated trac instance.
  12
  13 2015-09-30  Daniel Bates  <dabates@apple.com>
  14
  15         Prioritize testing latest build request on iOS test bots
  16         https://bugs.webkit.org/show_bug.cgi?id=149669
  17
  18         Reviewed by Darin Adler.
  19
  20         We should prioritize testing of the latest build request on the iOS test bots
  21         as we do for Mac and Windows test bots.
  22
  23         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
  24         (loadBuilderConfig):
  25
  26 2015-09-30  Daniel Bates  <dabates@apple.com>
  27
  28         Add buildbot category for iOS builders and testers
  29         https://bugs.webkit.org/show_bug.cgi?id=149667
  30
  31         Reviewed by Darin Adler.
  32
  33         Group iOS builders and testers under category iOS and add dashboard and console hyperlinks
  34         for iOS to the build.webkit.org home page.
  35
  36         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
  37         (loadBuilderConfig):
  38         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
  39
  40 2015-09-30  Daniel Bates  <dabates@apple.com>
  41
  42         Actually fix the Mac builders build after <http://trac.webkit.org/changeset/190219>
  43         (https://bugs.webkit.org/show_bug.cgi?id=149539)
  44
  45         I inadvertently didn't remove the ONLY_ACTIVE_ARCH=NO flag when building on a Mac
  46         in <http://trac.webkit.org/changeset/190351>.
  47
  48         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
  49         (CompileWebKit.start):
  50
  51 2015-09-30  Daniel Bates  <dabates@apple.com>
  52
  53         Attempt to fix the Mac builders build after <http://trac.webkit.org/changeset/190219>
  54         (https://bugs.webkit.org/show_bug.cgi?id=149539)
  55
  56         {32, 64}-bit Mac builders should not try to build project {Plugin.64, Plugin.32},
  57         respectively; only pass ONLY_ACTIVE_ARCH=NO when building for iOS.
  58
  59         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
  60         (CompileWebKit.start):
  61
  62 2015-09-30  Lucas Forschler  <lforschler@apple.com>
  63
  64         bot210 was configured for a queue instead of bot126.
  65
  66         Unreviewed config.json fix.
  67
  68         * BuildSlaveSupport/build.webkit.org-config/config.json:
  69
  70 2015-09-30  Lucas Forschler  <lforschler@apple.com>
  71
  72         Bring El Capitan buildbot infrastructure online.
  73         https://bugs.webkit.org/show_bug.cgi?id=149605
  74
  75         Reviewed by Darin Adler.
  76
  77         * BuildSlaveSupport/build.webkit.org-config/config.json:
  78
  79 2015-09-30  Tomas Popela  <tpopela@redhat.com>
  80
  81         [GTK] Deprecation warnings in DOMNodeTest
  82         https://bugs.webkit.org/show_bug.cgi?id=149663
  83
  84         After the webkit_dom_document_get_elements_by_tag_name deprecation we
  85         need to update the tests to use webkit_dom_document_query_selector_all
  86         to avoid compilation warnings.
  87
  88         Also add a new test for webkit_dom_document_get_elements_by_tag_name_as_html_collection
  89         (the suggested replacement for the deprecated function).
  90
  91         Reviewed by Carlos Garcia Campos.
  92
  93         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
  94         (WebKitDOMNodeTest::testTagNamesNodeList):
  95         (WebKitDOMNodeTest::testTagNamesHTMLCollection):
  96         (registerTests):
  97         (WebKitDOMNodeTest::testTagNames): Deleted.
  98         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
  99         (prepareDOMForTagNamesTests):
 100         (testWebKitDOMNodeTagNamesNodeList):
 101         (testWebKitDOMNodeTagNamesHTMLCollection):
 102         (beforeAll):
 103         (testWebKitDOMNodeTagNames): Deleted.
 104
 105 2015-09-29  Simon Fraser  <simon.fraser@apple.com>
 106
 107         WebKitTestRunner fails to apply "useFlexibleViewport" when it's specified in a file comment
 108         https://bugs.webkit.org/show_bug.cgi?id=149650
 109
 110         Reviewed by Tim Horton.
 111
 112         TestInvocation::invoke() consulted shouldMakeViewportFlexible(), but that only
 113         looks at the file path, and not the custom options that come from file comments.
 114
 115         Fix by computing TestOptions before making the TestInvocation, and setting them
 116         as const TestInvocation data. This meant changing various call sites to take
 117         the std::string pathOrURL, rather than the TestInvocation itself.
 118
 119         Also initialize TestInvocation with a WKURLRef, rather than a std::string.
 120
 121         * WebKitTestRunner/CMakeLists.txt:
 122         * WebKitTestRunner/TestController.cpp:
 123         (WTR::TestController::ensureViewSupportsOptionsForTest):
 124         (WTR::testPath):
 125         (WTR::createTestURL):
 126         (WTR::updateTestOptionsFromTestHeader):
 127         (WTR::TestController::testOptionsForTest):
 128         (WTR::TestController::updateWebViewSizeForTest):
 129         (WTR::TestController::updateWindowScaleForTest):
 130         (WTR::TestController::runTest):
 131         * WebKitTestRunner/TestController.h:
 132         * WebKitTestRunner/TestInvocation.cpp:
 133         (WTR::TestInvocation::TestInvocation):
 134         (WTR::TestInvocation::invoke):
 135         (WTR::createWKURL): Deleted.
 136         (WTR::TestInvocation::shouldMakeViewportFlexible): Deleted.
 137         (WTR::TestInvocation::shouldUseFixedLayout): Deleted.
 138         * WebKitTestRunner/TestInvocation.h:
 139         (WTR::TestInvocation::options):
 140         * WebKitTestRunner/TestOptions.cpp: Copied from Tools/WebKitTestRunner/TestOptions.h.
 141         (WTR::pathContains):
 142         (WTR::shouldMakeViewportFlexible):
 143         (WTR::shouldUseFixedLayout):
 144         (WTR::isSVGTestPath):
 145         (WTR::isHiDPITestPath):
 146         (WTR::TestOptions::TestOptions):
 147         * WebKitTestRunner/TestOptions.h:
 148         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
 149         * WebKitTestRunner/efl/TestControllerEfl.cpp:
 150         (WTR::pathContains):
 151         (WTR::shouldUseFixedLayout):
 152         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
 153         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
 154         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
 155         * WebKitTestRunner/ios/TestControllerIOS.mm:
 156         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
 157         * WebKitTestRunner/mac/TestControllerMac.mm:
 158         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
 159
 160 2015-09-29  Aakash Jain  <aakash_jain@apple.com>
 161
 162         Flakiness dashboard should support OS X El Capitan
 163         https://bugs.webkit.org/show_bug.cgi?id=149648
 164
 165         Reviewed by Alexey Proskuryakov.
 166
 167         * QueueStatusServer/app.yaml: We do not need to maintain SVN revision here because of
 168         difference between new appscale and old Google App Engine implementation.
 169         * TestResultServer/app.yaml: Same.
 170         * TestResultServer/static-dashboards/builders.jsonp: Added OSX El Capitan support.
 171
 172 2015-09-29  Daniel Bates  <dabates@apple.com>
 173
 174         configure-xcode-for-ios-development does not work with Xcode 7
 175         https://bugs.webkit.org/show_bug.cgi?id=149640
 176
 177         Reviewed by Alexey Proskuryakov.
 178
 179         When Xcode 7 is installed, running configure-xcode-for-ios-development dies with an error
 180         because it cannot find the Xcode specification files for iOS simulator and device. These
 181         files have moved to a new location in Xcode 7 distribution. Moreover we must add the
 182         relevant definitions to the Xcode 7 specification files directly as opposed to creating
 183         new specification files with the added definitions (as we did in older versions of Xcode)
 184         in order for Xcode 7 to honor these definitions.
 185
 186         * Scripts/configure-xcode-for-ios-development: Sorted forward declarations.
 187         (updateXcodeSpecificationFilesForSDKIfNeeded): Added.
 188         (updateXcode7SpecificationFile): Added.
 189         (createLegacyXcodeSpecificationFilesForSDKIfNeeded): Formerly named createXcodeSpecificationFilesForSDKIfNeeded.
 190         (writeXcodeSpecification): Moved congratulations line to caller so as to write out the
 191         appropriate success message.
 192         (mergeXcodeSpecificationWithSpecificationAndId): Formerly named createXcodeSpecificationFromSpecificationAndId.
 193         (createXcodeSpecificationFilesForSDKIfNeeded): Deleted.
 194         (createXcodeSpecificationFromSpecificationAndId): Deleted.
 195
 196 2015-09-29  Brent Fulgham  <bfulgham@apple.com>
 197
 198         [Win] Allow 'prepare-ChangeLog' to be used without Cygwin
 199         https://bugs.webkit.org/show_bug.cgi?id=149639
 200
 201         Reviewed by Alex Christensen.
 202
 203         * Scripts/VCSUtils.pm:
 204         (exitStatus): Use 'isWindows()' method.
 205         (isSVNVersion16OrNewer): 'eval' is not needed here, and just causes
 206         an error. This method could probably just go away.
 207         (normalizePath): Leave Windows (or Unix) paths as platform paths, rather than
 208         always changing to Unix style.
 209         (unixPath): Added. Needed so Windows can always show a Unix path in the
 210         ChangeLog file.
 211         (changeLogName): Work around the fact that 'getpwuid' is not available on
 212         a pure Windows build of Perl.
 213         * Scripts/prepare-ChangeLog:
 214         (generateFunctionLists): Normalize path received from 'svn' in case it's a Unix
 215         path on Windows.
 216         (svnUpdateCommand): Added helper function. Needed because Windows Perl does not
 217         support using arrays for 'open' arguments.
 218         (resolveChangeLogsPath): Ditto.
 219         (resolveConflictedChangeLogs): Use new helper functions.
 220         (generateNewChangeLogs): Force Windows to use Unix paths in ChangeLog output.
 221         (diffCommand): Use double-quotes for paths, since Windows doesn't understand single
 222         quotes. Unix systems are happy either way.
 223         (statusCommand): Ditto.
 224         * Scripts/webkitdirs.pm:
 225         (launcherName): Drive-by fix. WinLauncher was renamed to MiniBrowser some time ago.
 226
 227 2015-09-29  Brent Fulgham  <bfulgham@apple.com>
 228
 229         [Win] Unreviewed 64-bit build fix after switch to CMake.
 230
 231         * Scripts/webkitdirs.pm:
 232         (determineIsWin64FromArchitecture): Added.
 233
 234 2015-09-16  Carlos Garcia Campos  <cgarcia@igalia.com>
 235
 236         printing does not use minimum page zoom factor
 237         https://bugs.webkit.org/show_bug.cgi?id=108507
 238
 239         Reviewed by Darin Adler.
 240
 241         WebKitTestRunner always takes the snapshots from the UI process
 242         (expect for IOS), so in the case of printing, the layout in the
 243         web view is not the expected one. When printing, we need to take
 244         the snapshot in the web process and ensure it's rendered with a
 245         PrintContext.
 246
 247         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
 248         (WTR::InjectedBundlePage::dump): When dumping pixels, pass
 249         kWKSnapshotOptionsPrinting option to
 250         WKBundlePageCreateSnapshotWithOptions() when printing.
 251
 252 2015-09-28  Carlos Garcia Campos  <cgarcia@igalia.com>
 253
 254         [WTR] Pixel tests generate the snapshots twice in Web and UI processes
 255         https://bugs.webkit.org/show_bug.cgi?id=149595
 256
 257         Reviewed by Tim Horton.
 258
 259         All ports except IOS implement
 260         PlatformWebView::windowSnapshotImage() to generate the snapshot
 261         for the pixel tests in the UI process. But we are still generating
 262         a snapshot for pixel tests in the Web process too, that is passed
 263         to the UI process but ignored.
 264         Whether a pixel result is needed or not, is only known by the web
 265         process depending on whether the test called dumpAsText with
 266         dumpPixels == true or not. Since the pixels are now dump in the UI
 267         process, we need to pass that information to the UI process when
 268         the test is done. For that we set a PixelResultIsPending bool
 269         parameter to the Done message, and we only add the PixelResult
 270         when UI process doesn't need to generate the pixels dump.
 271
 272         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
 273         (WTR::InjectedBundle::didReceiveMessageToPage): Set
 274         m_pixelResultIsPending to false on reset.
 275         (WTR::InjectedBundle::done): Add PixelResultIsPending parameter to the
 276         Done message, and set the PixelResult if m_pixelResultIsPending is false.
 277         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
 278         (WTR::InjectedBundle::setPixelResult): Set m_pixelResultIsPending to false.
 279         (WTR::InjectedBundle::setNeedsPixelResult): Set m_pixelResultIsPending.
 280         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
 281         (WTR::InjectedBundlePage::dump): Only create a snapshot for IOS
 282         port.
 283         * WebKitTestRunner/TestInvocation.cpp:
 284         (WTR::TestInvocation::dumpResults): Use either the pixel result
 285         from the web process or generate a pixel result from the web view
 286         if need it.
 287         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
 288         * WebKitTestRunner/TestInvocation.h: Add SnapshotResultType enum
 289         parameter to dumpPixelsAndCompareWithExpected, since the snapshot
 290         is created by the caller now, but the CG implementation needs to
 291         know if it's a Web or UI process snapshot.
 292         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
 293         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
 294         cairo surface for the given image.
 295         * WebKitTestRunner/cg/TestInvocationCG.cpp:
 296         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
 297         CGContext for the given image.
 298
 299 2015-09-28  Dean Johnson  <dean_johnson@apple.com>
 300
 301         Fix JS errors on dashboard metrics page
 302         https://bugs.webkit.org/show_bug.cgi?id=149608
 303
 304         Reviewed by Alexey Proskuryakov.
 305
 306         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Updated to use Settings.
 307         (initPlatformsByFamily):
 308         (updateHiddenPlatforms):
 309         (parsePlatformFamily): Deleted.
 310         (updateToggleButtons): Deleted.
 311         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
 312         (updateHiddenPlatforms): Added to remove errors.
 313         (initPlatformsByFamily): Added to remove errors.
 314         (unhiddenQueues): Updated to use Settings.
 315         (documentReady): Added logic to add toggle buttons to the settings menu.
 316         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
 317         (Settings.prototype.parsePlatformFamily): Moved duplicate logic from Main.js and
 318         MetricsMain.js to Settings.
 319         (Settings.prototype.updateToggleButtons): Moved duplicate logic from Main.js and
 320         MetricsMain.js to Settings.
 321         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
 322         (QueueView.prototype._updateHiddenState): Updated to use Settings.
 323
 324 2015-09-28  Aakash Jain  <aakash_jain@apple.com>
 325
 326         Appscale query fails because of missing index
 327         https://bugs.webkit.org/show_bug.cgi?id=149609
 328
 329         Reviewed by Darin Adler.
 330
 331         * QueueStatusServer/index.yaml: Added the required index.
 332
 333 2015-09-28  Brent Fulgham  <bfulgham@apple.com>
 334
 335         [Win] Fix the 64-bit build after switch to cmake.
 336
 337         Reviewed by Alex Christensen.
 338
 339         * Scripts/webkitdirs.pm:
 340         (generateBuildSystemFromCMakeProject): Use correct arguments for cmake to
 341         run a 64-bit build.
 342
 343 2015-09-28  Brent Fulgham  <bfulgham@apple.com>
 344
 345         [Win] Allow Windows to run test-webkitpy without Cygwin
 346         https://bugs.webkit.org/show_bug.cgi?id=149602
 347
 348         Reviewed by Alex Christensen.
 349
 350         These changes mostly shift from hard-coded paths using UNIX-style
 351         separators to Python's "os.path.join" syntax that uses the correct
 352         path separator for each platform.
 353
 354         * Scripts/webkitpy/common/system/path.py:
 355         (cygpath): Don't pass paths through Cygpath on native Windows.
 356         * Scripts/webkitpy/port/win.py:
 357         (WinPort._path_to_apache): Use os.path.join.
 358         (WinPort._ntsd_location): Support 64-bit environment (ProgramW6432 doesn't exist
 359         in 64-bit environments).
 360         * Scripts/webkitpy/style/checker.py: Use os.path.join.
 361         * Scripts/webkitpy/style/checker_unittest.py:
 362         (GlobalVariablesTest.test_path_rules_specifier.assertNoCheck): Use os.path.join.
 363         (GlobalVariablesTest.test_path_rules_specifier): Ditto.
 364         (GlobalVariablesTest): Ditto.
 365         (GlobalVariablesTest.test_max_reports_per_category): Ditto.
 366         (CheckerDispatcherSkipTest.test_should_skip_with_warning): Ditto.
 367         (CheckerDispatcherDispatchTest.test_js_paths): Ditto.
 368         (CheckerDispatcherDispatchTest.test_json_paths): Ditto.
 369         (CheckerDispatcherDispatchTest.test_python_paths): Ditto.
 370         (CheckerDispatcherDispatchTest.test_text_paths): Ditto.
 371         (CheckerDispatcherDispatchTest.test_xml_paths): Ditto.
 372         (StyleProcessor_CodeCoverageTest._create_carriage_checker_class): Ditto.
 373         (StyleProcessor_CodeCoverageTest): Ditto.
 374         (StyleProcessor_CodeCoverageTest.test_should_process__skip_without_warning): Ditto.
 375         (StyleProcessor_CodeCoverageTest.test_should_process__skip_with_warning): Ditto.
 376         (StyleProcessor_CodeCoverageTest.test_should_process__true_result): Ditto.
 377         * Scripts/webkitpy/w3c/test_parser_unittest.py: Uses os.path.join rather than
 378         manual string concatenation of paths.
 379
 380 2015-09-28  Csaba Osztrogonác  <ossy@webkit.org>
 381
 382         Add bugzilla addresses of committers to contributors.json
 383         https://bugs.webkit.org/show_bug.cgi?id=149520
 384
 385         Reviewed by Darin Adler.
 386
 387         * Scripts/webkitpy/common/config/contributors.json:
 388
 389 2015-09-28  Csaba Osztrogonác  <ossy@webkit.org>
 390
 391         validate-committer-lists -b shouldn't need edituser privileges
 392         https://bugs.webkit.org/show_bug.cgi?id=149519
 393
 394         Reviewed by Darin Adler.
 395
 396         * Scripts/validate-committer-lists:
 397         (CommitterListBugzillaChecker._has_invalid_bugzilla_email):
 398         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
 399         (BugzillaQueries.is_invalid_bugzilla_email):
 400         (BugzillaQueries): Deleted.
 401         (BugzillaQueries.fetch_logins_matching_substring): Deleted.
 402
 403 2015-09-26  Carlos Garcia Campos  <cgarcia@igalia.com>
 404
 405         Unreviewed. Gardening: skip media stream tests failing after r190262.
 406
 407         * Scripts/run-gtk-tests:
 408         (TestRunner):
 409
 410 2015-09-25  Alexey Proskuryakov  <ap@apple.com>
 411
 412         [Mac] USE_INTERNAL_SDK is used undefined in tools projects
 413         https://bugs.webkit.org/show_bug.cgi?id=149571
 414
 415         Reviewed by Dan Bernstein.
 416
 417         Use the same pattern as in Source directory configurations (so, also get rid of AspenFamily.xcconfig).
 418
 419         * DumpRenderTree/mac/Configurations/Base.xcconfig:
 420         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
 421         * LayoutTestRelay/Configurations/Base.xcconfig:
 422         * MiniBrowser/Configurations/Base.xcconfig:
 423         * MiniBrowser/Configurations/DebugRelease.xcconfig:
 424         * TestWebKitAPI/Configurations/Base.xcconfig:
 425         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
 426         * WebEditingTester/Configurations/Base.xcconfig:
 427         * WebEditingTester/Configurations/DebugRelease.xcconfig:
 428         * WebKitTestRunner/Configurations/Base.xcconfig:
 429         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
 430         * WebKitTestRunner/iOS.xcconfig: Removed.
 431
 432 2015-09-25  Eric Carlson  <eric.carlson@apple.com>
 433
 434         Clean up user media request internal API
 435         https://bugs.webkit.org/show_bug.cgi?id=149527
 436
 437         Reviewed by Tim Horton.
 438
 439         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
 440         (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack): Update for API changes.
 441
 442         * WebKitTestRunner/TestController.cpp:
 443         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Ditto.
 444
 445 2015-09-25  Simon Fraser  <simon.fraser@apple.com>
 446
 447         [iOS WK2] Add viewport tests and fix runUIScript() timing issues
 448         https://bugs.webkit.org/show_bug.cgi?id=149577
 449
 450         Reviewed by Tim Horton.
 451
 452         When calling testRunner.runUIScript() from a page load event, the script could run
 453         in the UI process before the current remote layer tree transaction had been handled
 454         there. This meant that runUIScript() could query state which was about to change.
 455
 456         Fix by delaying the execution of the UI script until a layer tree transaction has
 457         been handled by the UI process, leveraging the existing DrawingAreaProxy::dispatchAfterEnsuringDrawing().
 458
 459         * WebKitTestRunner/TestInvocation.cpp:
 460         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
 461         (WTR::TestInvocation::runUISideScriptAfterUpdateCallback):
 462         * WebKitTestRunner/TestInvocation.h:
 463
 464 2015-09-25  Alexey Proskuryakov  <ap@apple.com>
 465
 466         [Mac] Media tests start to time out after a few days of bot uptime
 467         https://bugs.webkit.org/show_bug.cgi?id=149468
 468
 469         Reviewed by Darin Adler.
 470
 471         Delete cache directory in addition to the temporary one. Don't delete /private/tmp/MediaCache,
 472         as it's not longer used by tests. Set TMPDIR and DIRHELPER_USER_DIR_SUFFIX to make
 473         all temporary and cache files go to a custom location.
 474
 475         * Scripts/webkitpy/port/base.py:
 476         * Scripts/webkitpy/port/driver.py:
 477         * Scripts/webkitpy/port/mac.py:
 478         * Scripts/webkitpy/port/win.py:
 479         (WinPort._driver_tempdir_for_environment): Deleted unused function.
 480
 481 2015-09-25  Dan Bernstein  <mitz@apple.com>
 482
 483         Removed MiniBrowser.entitlements.
 484
 485         Rubber-stamped by Anders Carlsson.
 486
 487         The entitlements weren’t used anyway.
 488
 489         * MiniBrowser/MiniBrowser.entitlements: Removed.
 490         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
 491
 492 2015-09-24  Daniel Bates  <dabates@apple.com>
 493
 494         Add WebKitSystemInterface for iOS 9.0
 495         https://bugs.webkit.org/show_bug.cgi?id=149550
 496
 497         Rubber-stamped by Alexey Proskuryakov.
 498
 499         * Scripts/copy-webkitlibraries-to-product-directory:
 500
 501 2015-09-24  Daniel Bates  <dabates@apple.com>
 502
 503         Support building for arbitrary architectures
 504         https://bugs.webkit.org/show_bug.cgi?id=149539
 505
 506         Reviewed by Alexey Proskuryakov.
 507
 508         Teach buildbot to pass the architectures associated with the builder to build-webkit
 509         when building on OS X and iOS. As a side effect of this change we now support building
 510         universal binaries when multiples architectures are specified.
 511
 512         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
 513         (CompileWebKit.start):
 514
 515 2015-09-24  Daniel Bates  <dabates@apple.com>
 516
 517         Fix the build after <http://trac.webkit.org/changeset/190212>
 518         (http://trac.webkit.org/changeset/190212)
 519
 520         I inadvertently did not remove the fullPlatform argument from one of the callers of archiveBuiltProduct().
 521
 522         * BuildSlaveSupport/built-product-archive:
 523         (main):
 524
 525 2015-09-24  Daniel Bates  <dabates@apple.com>
 526
 527         Support running unit tests on iOS Simulator test bot
 528         https://bugs.webkit.org/show_bug.cgi?id=149536
 529
 530         Reviewed by Alexey Proskuryakov.
 531
 532         Implements support for running unit tests on a iOS test bot. At the time of writing,
 533         the script run-api-tests supports running unit tests on Mac, Windows and iOS Simulator.
 534
 535         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
 536         (RunUnitTests.start): Append appropriate command line flag when invoking script run-api-tests.
 537         (TestFactory.__init__): Add step RunUnitTests when the test bot is for the iOS Simulator platform.
 538
 539 2015-09-24  Daniel Bates  <dabates@apple.com>
 540
 541         Add support infrastructure for OpenSource iOS builders and testers
 542         https://bugs.webkit.org/show_bug.cgi?id=149534
 543
 544         Reviewed by Darin Adler.
 545
 546         Towards setting up OpenSource iOS build bots, teach buildbot and its support
 547         scripts about iOS.
 548
 549         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
 550         (appendCustomBuildFlags): Require the caller to pass parameter fullPlatform and append
 551         --ios-simulator or --device for a builder/tester whose full platform name begins with
 552         "ios-simulator" or "ios", respectively.
 553         (RunJavaScriptCoreTests.start): Pass the full platform name to appendCustomBuildFlags().
 554         * BuildSlaveSupport/built-product-archive:
 555         (main): Pass the full platform name to determineWebKitBuildDirectory().
 556         (determineWebKitBuildDirectory): Call script webkit-build-directory with the appropriate
 557         command line flag when building for iOS.
 558         (archiveBuiltProduct): Use the same logic for iOS as we do for Mac. Also, remove unused
 559         parameter fullPlatform. This parameter was originally added in r125066 to support the
 560         Chromium Android port, which has since been removed from the OpenSource WebKit Project.
 561         (extractBuiltProduct): Use the same logic for iOS as we do for Mac.
 562         * BuildSlaveSupport/clean-build:
 563         (main): Call script webkit-build-directory with the appropriate command line flag when
 564         building for iOS.
 565         * BuildSlaveSupport/delete-stale-build-files:
 566         (main): Use the same logic for iOS as we do for Mac.
 567         (webkitBuildDirectory): Call script webkit-build-directory with the appropriate command line
 568         flag when building for iOS.
 569         * BuildSlaveSupport/test-result-archive:
 570         (archiveTestResults): Use the same logic for iOS as we do for Mac.
 571
 572 2015-09-24  Daniel Bates  <dabates@apple.com>
 573
 574         Remove Chromium-specific changes to script built-product-archive
 575         https://bugs.webkit.org/show_bug.cgi?id=149530
 576
 577         Rubber-stamped by Csaba Osztrogonác.
 578
 579         Reverts changes made in r113074 and r113067 to support Chromium testers. The
 580         Chromium code has long since been removed from the OpenSource WebKit Project.
 581
 582         * BuildSlaveSupport/built-product-archive:
 583         (createZipManually):
 584         (createZip):
 585         (archiveBuiltProduct):
 586
 587 2015-09-24  Dan Bernstein  <mitz@apple.com>
 588
 589         Build fix.
 590
 591         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
 592
 593 2015-09-24  Mark Lam  <mark.lam@apple.com>
 594
 595         Unreviewed. Make Lucas Forschler a WebKit reviewer.
 596
 597         * Scripts/webkitpy/common/config/contributors.json:
 598
 599 2015-09-24  Carlos Garcia Campos  <cgarcia@igalia.com>
 600
 601         Unreviewed. Fix GObject DOM API breaks after r190120.
 602
 603         Bring back code removed in r169931 to handle documentation of
 604         deleted classes.
 605
 606         * gtk/webkitdom.py:
 607         (WebKitDOMDocGenerator):
 608         (WebKitDOMDocGenerator.write_deleted_classes):
 609         (WebKitDOMDocGenerator.generate):
 610         (write_deleted_classes):
 611         (WebKitDOMDocGeneratorSections._deleted_class):
 612         (WebKitDOMDocGeneratorSections._deleted_class.in):
 613         (WebKitDOMDocGeneratorSections.write_deleted_classes):
 614         (WebKitDOMDocGeneratorSections.write_deleted_classes.with):
 615
 616 2015-09-23  Myles C. Maxfield  <mmaxfield@apple.com>
 617
 618         [Cocoa] [Font Features] Implement font-variant-*
 619         https://bugs.webkit.org/show_bug.cgi?id=148413
 620
 621         Reviewed by Darin Adler.
 622
 623         Update test font to use "lnum" feature.
 624
 625         * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
 626         (Generator::appendGSUBTable):
 627
 628 2015-09-22  Andy Estes  <aestes@apple.com>
 629
 630         ContentFiltering.AllowDownloadAfterAddData is very flaky
 631         https://bugs.webkit.org/show_bug.cgi?id=148885
 632         <rdar://problem/22729563>
 633
 634         Reviewed by Alexey Proskuryakov.
 635
 636         The AllowDownload* tests were relying on -_downloadDidStart: being called before -webView:didFinishNavigation:,
 637         but there is no guarantee of this. For tests that should allow a download, spin the runloop until
 638         -_downloadDidStart: is called. The test will now timeout on failure, but will no longer produce false failures.
 639
 640         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
 641         (downloadTest):
 642
 643 2015-09-22  Alexey Proskuryakov  <ap@apple.com>
 644
 645         Mavericks: Media tests start to time out after a few days of bot uptime
 646         https://bugs.webkit.org/show_bug.cgi?id=149468
 647
 648         Reviewed by Chris Dumez.
 649
 650         * Scripts/webkitpy/port/base.py:
 651         * Scripts/webkitpy/port/driver.py:
 652         * Scripts/webkitpy/port/mac.py:
 653
 654 2015-09-22  Nan Wang  <n_wang@apple.com>
 655
 656         Unreviewed, add myself to the committers list.
 657
 658         * Scripts/webkitpy/common/config/contributors.json:
 659
 660 2015-09-21  Simon Fraser  <simon.fraser@apple.com>
 661
 662         Remove 'nullable' to fix older iOS builds.
 663
 664         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
 665         (-[TestRunnerWKWebView scrollViewDidEndZooming:withView:atScale:]):
 666
 667 2015-09-21  Brent Fulgham  <bfulgham@apple.com>
 668
 669         [Win] Show tiled drawing debug overlay on Windows
 670         https://bugs.webkit.org/show_bug.cgi?id=149426
 671
 672         Reviewed by Dean Jackson.
 673
 674         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc: Add new menu option.
 675         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h: Ditto.
 676         * MiniBrowser/win/Common.cpp:
 677         (::ToggleMenuItem): Recognize new menu item and toggle the 'showTiledScrollingIndicator'
 678         flag if needed.
 679         * MiniBrowser/win/MiniBrowser.h: Update to use new IWebPreferencesPrivate3 class.
 680
 681 2015-09-21  Brent Fulgham  <bfulgham@apple.com>
 682
 683         [Win] Use command-line argument to launch in regular or High DPI mode.
 684         https://bugs.webkit.org/show_bug.cgi?id=149417
 685
 686         Reviewed by Dean Jackson.
 687
 688         * MiniBrowser/win/Common.cpp:
 689         (parseCommandLine): Ignore the '--highDPI' argument. It's used at the
 690         very start of execution, before the MiniBrowser.dll is loaded.
 691         * win/DLLLauncher/DLLLauncherMain.cpp:
 692         (shouldUseHighDPI): Check for '--highDPI', and use this mode if
 693         present. On WinCairo, always use High DPI.
 694
 695 2015-09-21  Ryosuke Niwa  <rniwa@webkit.org>
 696
 697         32-bit Mac build fix attempt after r190065.
 698
 699         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
 700
 701 2015-09-21  Alexey Proskuryakov  <ap@apple.com>
 702
 703         [OS X] Update for Xcode 7.0 on Yosemite
 704         https://bugs.webkit.org/show_bug.cgi?id=149389
 705
 706         Reviewed by Dan Bernstein.
 707
 708         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
 709         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h:
 710         Removed unneeded declarations - conforming to a protocol is sufficient.
 711
 712         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
 713         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm:
 714         Changed the definitions to be compiled whenever the SDK requires it (so we will have
 715         dead code compiled in when building for 10.10 with 10.11 SDK, somewhat unfortunately).
 716
 717 2015-09-21  Simon Fraser  <simon.fraser@apple.com>
 718
 719         Add the ability for tests to run script in the UI process in WebKitTestRunner
 720         https://bugs.webkit.org/show_bug.cgi?id=149356
 721
 722         Reviewed by Tim Horton.
 723
 724         This change adds testRunner.runUIScript(script, callback), which allows a test
 725         to execute script in a JSContext which runs in the UI process. That context
 726         has bindings exposed through the UIScriptController interface; currently one test
 727         function, and some iOS-specific functions are included. UIScriptController can be
 728         async with a callback, and runUIScript() itself is asynchronous. When the UI
 729         script is complete, it calls uiController.uiScriptComplete(result), where 'result'
 730         is a string passed back to the web process, and given to the runUIScript()
 731         callback function.
 732
 733         Thanks to Gyuyoung Kim for help with the Gtk/Efl build.
 734
 735         * WebKitTestRunner/DerivedSources.make: Build UIScriptController.idl.
 736         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Add runUIScript().
 737         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
 738         (WTR::InjectedBundle::didReceiveMessageToPage): When the UI-side script is
 739         complete, call back into TestRunner.
 740         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
 741         (WTR::nextUIScriptCallbackID):
 742         (WTR::TestRunner::runUIScript): Post a message to the injected bundle to run the UI script.
 743         (WTR::TestRunner::runUIScriptCallback): When the UI script is done, execute its callback function.
 744         * WebKitTestRunner/InjectedBundle/TestRunner.h:
 745         * WebKitTestRunner/PlatformWebView.h:
 746         * WebKitTestRunner/TestController.cpp:
 747         (WTR::updateTestOptionsFromTestHeader):
 748         (WTR::TestController::testOptionsForTest): Support "useFlexibleViewport" as a test argument.
 749         (WTR::shouldUseFixedLayout): Deleted. Moved to a TestInvocation function.
 750         * WebKitTestRunner/TestInvocation.cpp:
 751         (WTR::TestInvocation::shouldUseFixedLayout):
 752         (WTR::TestInvocation::shouldUseThreadedScrolling):
 753         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
 754         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
 755         (WTR::TestInvocation::runUISideScript): Run the UI-side script!
 756         (WTR::TestInvocation::uiScriptDidComplete): Send a message back to the injected bundle.
 757         * WebKitTestRunner/TestInvocation.h:
 758         * WebKitTestRunner/TestOptions.h:
 759         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
 760         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
 761         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h: Copied from Tools/WebKitTestRunner/TestOptions.h.
 762         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm: Added.
 763         (-[TestRunnerWKWebView dragImage:at:offset:event:pasteboard:source:slideBack:]):
 764         (-[TestRunnerWKWebView zoomToScale:animated:completionHandler:]):
 765         (-[TestRunnerWKWebView scrollViewDidEndZooming:withView:atScale:]):
 766         (-[TestRunnerWKWebView onDidEndZooming:]): Allow a test to hook into the end of zooming.
 767         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
 768         (WTR::PlatformWebView::PlatformWebView): Make a TestRunnerWKWebView on iOS.
 769         * WebKitTestRunner/ios/UIScriptControllerIOS.mm: Added.
 770         (WTR::UIScriptController::doAsyncTask):
 771         (WTR::UIScriptController::zoomToScale):
 772         (WTR::UIScriptController::zoomScale):
 773         (WTR::UIScriptController::minimumZoomScale):
 774         (WTR::UIScriptController::maximumZoomScale):
 775         (WTR::UIScriptController::contentVisibleRect):
 776         * WebKitTestRunner/mac/EventSenderProxy.mm:
 777         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
 778         (-[TestRunnerWKWebView dragImage:at:offset:event:pasteboard:source:slideBack:]): Deleted.
 779         * WebKitTestRunner/mac/TestControllerMac.mm:
 780         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
 781         (WTR::shouldUseThreadedScrolling): Deleted. Moved to TestInvocation.
 782         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h:
 783         * WebKitTestRunner/uiscriptcontext/UIScriptContext.cpp: Added. Owns the JS context in the UI process.
 784         (UIScriptContext::UIScriptContext):
 785         (UIScriptContext::~UIScriptContext):
 786         (UIScriptContext::runUIScript): Entrypoint to running the UI script. If the script didn't do anything
 787         asynchronous, call the callback.
 788         (UIScriptContext::nextTaskCallbackID):
 789         (UIScriptContext::prepareForAsyncTask): Do setup for one async task (i.e. a UIScriptController function
 790         that has a callback). Has to store the callbackID of the script, so code called from the completion
 791         callback knows which UI script invoked it.
 792         (UIScriptContext::asyncTaskComplete): Called when one task is finished.
 793         (UIScriptContext::uiScriptComplete):
 794         (UIScriptContext::objectFromRect): Make a JS object from a rect.
 795         * WebKitTestRunner/uiscriptcontext/UIScriptContext.h: Copied from Tools/WebKitTestRunner/TestOptions.h.
 796         (WTR::UIScriptContext::hasOutstandingAsyncTasks):
 797         * WebKitTestRunner/uiscriptcontext/UIScriptController.cpp: Copied from Tools/WebKitTestRunner/TestOptions.h.
 798         (WTR::UIScriptController::UIScriptController):
 799         (WTR::UIScriptController::makeWindowObject):
 800         (WTR::UIScriptController::wrapperClass):
 801         (WTR::UIScriptController::doAsyncTask):
 802         (WTR::UIScriptController::zoomToScale):
 803         (WTR::UIScriptController::zoomScale):
 804         (WTR::UIScriptController::minimumZoomScale):
 805         (WTR::UIScriptController::maximumZoomScale):
 806         (WTR::UIScriptController::contentVisibleRect):
 807         (WTR::UIScriptController::uiScriptComplete):
 808         * WebKitTestRunner/uiscriptcontext/UIScriptController.h: Copied from Tools/WebKitTestRunner/TestOptions.h.
 809         (WTR::UIScriptController::create):
 810         * WebKitTestRunner/uiscriptcontext/bindings/UIScriptController.idl: Copied from Tools/WebKitTestRunner/TestOptions.h.
 811
 812 2015-09-21  Tim Horton  <timothy_horton@apple.com>
 813
 814         Turn on threaded scrolling by default in the tests
 815         https://bugs.webkit.org/show_bug.cgi?id=149377
 816
 817         Reviewed by Simon Fraser.
 818
 819         * WebKitTestRunner/mac/TestControllerMac.mm:
 820         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
 821         (WTR::shouldUseThreadedScrolling): Deleted.
 822         Turn on threaded scrolling by default.
 823
 824 2015-09-21  Carlos Garcia Campos  <cgarcia@igalia.com>
 825
 826         [GTK] run-gtk-tests doesn't provide feedback about crashing google tests
 827         https://bugs.webkit.org/show_bug.cgi?id=149252
 828
 829         Reviewed by Darin Adler.
 830
 831         In case of glib tests the test runner notifies about tests
 832         crashing, but for google tests we don't get any feedback, which
 833         means that in case of a test crashing we get a list of **PASS**
 834         messages and at the summary we are notified that the test suite
 835         has failed, but it's impossible to know which test cases have failed.
 836
 837         * Scripts/run-gtk-tests:
 838         (TestRunner._run_google_test): Add a **CRASH** message if test
 839         case crashed.
 840
 841 2015-09-20  Alexey Proskuryakov  <ap@apple.com>
 842
 843         WebKitTestRunner can leak user content script results between tests
 844         https://bugs.webkit.org/show_bug.cgi?id=149391
 845
 846         Reviewed by Sam Weinig.
 847
 848         Move WKBundlePageRemoveAllUserContent call so that it's executed before loading
 849         about:blank, and thus about:blank doesn't have unintended side effects.
 850
 851         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
 852         (WTR::InjectedBundle::beginTesting):
 853         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
 854         (WTR::InjectedBundlePage::resetAfterTest):
 855
 856 2015-09-20  Alexey Proskuryakov  <ap@apple.com>
 857
 858         [Mac, iOS] AccessibilityController doesn't uninstall global notification handler
 859         https://bugs.webkit.org/show_bug.cgi?id=149384
 860
 861         Reviewed by Chris Fleizach.
 862
 863         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
 864         (AccessibilityController::addNotificationListener): Fixed a leak, and cleaned up the code.
 865         (AccessibilityController::platformResetToConsistentState): Actually remove the handler,
 866         regardless of whether someone else holds a reference (we also call -stopListening in
 867         -dealloc).
 868
 869         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
 870         (AccessibilityController::platformResetToConsistentState):
 871         (AccessibilityController::addNotificationListener):
 872         Ditto.
 873
 874 2015-09-20  Youenn Fablet  <youenn.fablet@crf.canon.fr>
 875
 876         Remove XHR_TIMEOUT compilation guard
 877         https://bugs.webkit.org/show_bug.cgi?id=149260
 878
 879         Reviewed by Benjamin Poulain.
 880
 881         * Scripts/webkitperl/FeatureList.pm:
 882
 883 2015-09-19  Dan Bernstein  <mitz@apple.com>
 884
 885         Attempted build fix.
 886
 887         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
 888
 889 2015-09-18  Commit Queue  <commit-queue@webkit.org>
 890
 891         Unreviewed, rolling out r189908.
 892         https://bugs.webkit.org/show_bug.cgi?id=149368
 893
 894         Broke run-webkit-tests --pixel (Requested by ap on #webkit).
 895
 896         Reverted changeset:
 897
 898         "printing does not use minimum page zoom factor"
 899         https://bugs.webkit.org/show_bug.cgi?id=108507
 900         http://trac.webkit.org/changeset/189908
 901
 902 2015-09-18  Andy Estes  <aestes@apple.com>
 903
 904         [iOS] did{Start,Finish}LoadForQuickLookDocumentInMainFrame is never called on WKNavigationDelegate
 905         https://bugs.webkit.org/show_bug.cgi?id=149360
 906
 907         Reviewed by Tim Horton.
 908
 909         Added an API test.
 910
 911         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 912         * TestWebKitAPI/Tests/WebKit2Cocoa/QuickLook.mm: Added.
 913         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
 914         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
 915         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]):
 916         (TEST):
 917         * TestWebKitAPI/ios/pages.pages: Added.
 918
 919 2015-09-18  Nan Wang  <n_wang@apple.com>
 920
 921         AX: Implement ARIA 1.1 @aria-current on iOS
 922         https://bugs.webkit.org/show_bug.cgi?id=149297
 923
 924         Reviewed by Chris Fleizach.
 925
 926         Added support to test aria-current on iOS.
 927
 928         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
 929         (AccessibilityUIElement::stringAttributeValue):
 930         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
 931         (WTR::AccessibilityUIElement::stringAttributeValue):
 932
 933 2015-09-18  Alexey Proskuryakov  <ap@apple.com>
 934
 935         iOS WebKitTestRunner frequently crashes in WKContextGetIconDatabase
 936         https://bugs.webkit.org/show_bug.cgi?id=149352
 937
 938         Reviewed by Simon Fraser.
 939
 940         * WebKitTestRunner/TestController.cpp: (WTR::TestController::~TestController):
 941         m_context can be null. This may indicate a bug in webkitpy too, but
 942         WebKitTestRunner should handle this situation nicely, there is nothing intrinsically
 943         wrong with opening and immediately closing it.
 944
 945 2015-09-18  Daniel Bates  <dabates@apple.com>
 946
 947         isGitSVNDirectory() returns true when Git is not installed
 948         https://bugs.webkit.org/show_bug.cgi?id=149351
 949
 950         Reviewed by Alexey Proskuryakov.
 951
 952         Fixes an issue where VCSUtils::isGitSVNDirectory() returns true for any arbitrary directory if
 953         Git is not installed on the machine.
 954
 955         * Scripts/VCSUtils.pm:
 956         (isGitSVNDirectory): Ensure that `git config --get svn-remote.svn.fetch 2>& 1` exits with
 957         status code 0 (success).
 958
 959 2015-09-18  Alex Christensen  <achristensen@webkit.org>
 960
 961         Prevent build-webkit from building four times on Windows
 962         https://bugs.webkit.org/show_bug.cgi?id=149336
 963
 964         Reviewed by Brent Fulgham.
 965
 966         * Scripts/build-webkit:
 967         Move the Windows code out of the for loop iterating over each subdirectory to be build.
 968         They're built all at once.
 969         * Scripts/webkitdirs.pm:
 970         (buildVisualStudioProject):
 971         (cmakeGeneratedBuildfile):
 972         Don't generate the Visual Studio solution if it already exists.
 973         It will run CMake again if necessary.
 974
 975 2015-09-17  Simon Fraser  <simon.fraser@apple.com>
 976
 977         [iOS WK2] WTR fails to set the key window in the UIKit sense
 978         https://bugs.webkit.org/show_bug.cgi?id=149325
 979
 980         Reviewed by Tim Horton.
 981
 982         -[WebKitTestRunnerWindow isKeyWindow] just returned _platformWebView->windowIsKey().
 983         This causes UIKit to bypass code that actually sets the key window, resulting in
 984         [UIAppliation sharedApplication].keyWindow always being nil.
 985
 986         Fix by PlatformWebView::setWindowIsKey() actually call -makeKeyWindow, and having
 987         -[WebKitTestRunnerWindow isKeyWindow] call super.
 988
 989         * WebKitTestRunner/PlatformWebView.h:
 990         (WTR::PlatformWebView::setWindowIsKey): Deleted.
 991         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
 992         (WTR::PlatformWebView::setWindowIsKey):
 993         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
 994         (WTR::PlatformWebView::setWindowIsKey):
 995         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
 996         (-[WebKitTestRunnerWindow isKeyWindow]):
 997         (WTR::PlatformWebView::PlatformWebView):
 998         (WTR::PlatformWebView::~PlatformWebView):
 999         (WTR::PlatformWebView::setWindowIsKey):
1000         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1001         (WTR::PlatformWebView::setWindowIsKey):
1002
1003 2015-09-17  Simon Fraser  <simon.fraser@apple.com>
1004
1005         [iOS WK2] When loading viewport tests, use the normal web page viewport configuration
1006         https://bugs.webkit.org/show_bug.cgi?id=149321
1007
1008         Reviewed by Tim Horton.
1009
1010         InjectedBundlePage::platformDidStartProvisionalLoadForFrame() unconditionally
1011         enabled the "testing" viewport configuration, which disables page scaling.
1012
1013         If we're running viewport tests, we want the normal web page configuration.
1014         Do that by passing a flag in the dictionary sent to InjectedBundle::beginTesting(),
1015         based on whether the test is in a "viewport" directory.
1016
1017         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1018         (WTR::InjectedBundle::beginTesting):
1019         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
1020         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame): Deleted.
1021         * WebKitTestRunner/TestInvocation.cpp:
1022         (WTR::TestInvocation::shouldLogFrameLoadDelegates):
1023         (WTR::TestInvocation::shouldLogHistoryClientCallbacks):
1024         (WTR::TestInvocation::shouldMakeViewportFlexible):
1025         (WTR::TestInvocation::invoke):
1026         * WebKitTestRunner/TestInvocation.h:
1027         * WebKitTestRunner/ios/TestControllerIOS.mm:
1028         (WTR::TestController::platformConfigureViewForTest):
1029         (WTR::shouldMakeViewportFlexible): Deleted.
1030
1031 2015-09-17  Simon Fraser  <simon.fraser@apple.com>
1032
1033         Give iOS WebKitTestRunner a launch storyboard
1034         https://bugs.webkit.org/show_bug.cgi?id=149314
1035
1036         Reviewed by Dan Bates.
1037
1038         Add a launch storyboard to iOS WebKitTestRunner so that Springboard recognizes
1039         that it's been built for specific device configurations, and puts the window
1040         at the top of the screen. This simplifies coordinate conversions in a future patch.
1041
1042         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1043         * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist:
1044         * WebKitTestRunner/ios/Launch.storyboard: Added.
1045
1046 2015-09-17  Myles C. Maxfield  <mmaxfield@apple.com>
1047
1048         Update licence in r189890
1049         https://bugs.webkit.org/show_bug.cgi?id=149306
1050
1051         Reviewed by Dean Jackson.
1052
1053         * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
1054         * FontWithFeatures/FontWithFeatures/FontCreator.h:
1055         * FontWithFeatures/FontWithFeatures/main.cpp:
1056
1057 2015-09-17  Mark Lam  <mark.lam@apple.com>
1058
1059         Add the ability to skip JIT stress tests in run-javascriptcore-tests.
1060         https://bugs.webkit.org/show_bug.cgi?id=149285
1061
1062         Reviewed by Saam Barati.
1063
1064         Just need to add an option to pass --no-jit to run-jsc-stress-test.
1065
1066         * Scripts/run-javascriptcore-tests:
1067         (runJSCStressTests):
1068
1069 2015-09-17  Alex Christensen  <achristensen@webkit.org>
1070
1071         Switch AppleWin build to use CMake
1072         https://bugs.webkit.org/show_bug.cgi?id=149163
1073
1074         Reviewed by Brent Fulgham.
1075
1076         * Scripts/build-webkit:
1077         * Scripts/run-api-tests:
1078         (runTest):
1079         (listAllTests):
1080         (prepareEnvironmentForRunningTestTool):
1081         (testToolPaths):
1082         (testToolPath): Deleted.
1083         Run the API tests as separate executables on Windows.
1084         It used to be TestWebKitAPI.exe, and it is now TestWTF.exe, TestWebCore.exe, and TestWebKit.exe.
1085         * Scripts/webkitdirs.pm:
1086         (checkRequiredSystemConfig):
1087         (jhbuildWrapperPrefixIfNeeded):
1088         (generateBuildSystemFromCMakeProject):
1089         Fix configuration quirks.
1090
1091 2015-09-17  Dean Johnson  <dean_johnson@apple.com>
1092
1093         Added toggle options for hiding and showing certain platform families on the dashboard.
1094         https://bugs.webkit.org/show_bug.cgi?id=148403
1095
1096         Reviewed by David Kilzer.
1097
1098         This patch removes "hiddenPlatforms" from use in the code and local storage. We also removed
1099         individual hide/show buttons for platforms because we've added toggle options to hide/show entire
1100         families. Examples of these are "mac", "ios", and "linux". "Show All Platforms" was also removed
1101         in lieu of an "all" button in the toggle menu.
1102
1103         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
1104         (parsePlatformFamily): Helper function to parse out a platform family.
1105         (initPlatformsByFamily): Initializes platformsByFamily, which organizes platforms on the
1106         page by platformsByFamily[<family>] = <list of platforms belonging to that family>.
1107         (updateToggleButtons): Updates the status of the toggle buttons.
1108         (updateHiddenPlatforms): Changed to work with the new implementation of hiding/showing platforms.
1109         (documentReady): Added creation of toggle buttons.
1110         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
1111         (unhiddenQueues): Updated to search by platform family instead of the individual platform name.
1112         (documentReady): Changed hiddenPlatforms => hiddenPlatformFamilies.
1113         (updateHiddenPlatforms): Deleted. After removing the individual hide button code,
1114         this did the exact same thing as the updateHiddenPlatforms in Scripts/Main.js so it was removed.
1115         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
1116         (QueueView): Updated to use hiddenPlatformFamilies.
1117         (QueueView.prototype._updateHiddenState): Updated to use hiddenPlatformFamilies.
1118         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
1119         (Settings.prototype.toggleHiddenPlatformFamily): Renamed function and some variables.
1120         (Settings.prototype.clearHiddenPlatformFamilies): Now uses hiddenPlatformFamilies for events.
1121         (Settings.prototype.toggleHiddenPlatform): Deleted.
1122         (Settings.prototype.clearHiddenPlatforms): Deleted.
1123         (Settings.prototype.toggleShowPlatformFamily): Deleted.
1124         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1125         (div.cellButton, div.accessibilityButton, div.platformFamilyToggleButton):
1126         (div.cellButton.unhide, div.accessibilityButton.unhide, div.platformFamilyToggleButton.unhide):
1127         (.settings-visible div.settingsWrapper.hide, .settings-visible div.settingsWrapper):
1128         (table.queue-grid tr.headers th):
1129         (div.settingsWrapper.hide):
1130         (div.settingsWrapper):
1131         (div.familyToggleWrapper):
1132         (div.platformFamilyToggleButton):
1133         (div.platformFamilyShowToggleButton:not(:last-child)):
1134         (div.familyShown):
1135         (div.accessibilityButton):
1136         (div.cellButton, div.accessibilityButton): Added platformFamilyToggleButton class.
1137         (div.cellButton.unhide, div.accessibilityButton.unhide): Added platformFamilyToggleButton class.
1138         (.settings-visible div.accessibilityButton.hide, .settings-visible div.accessibilityButton.unhide): Added
1139         platformFamilyToggleButton and settingsWrapper class.
1140         (.accessibilityButton): Deleted.
1141
1142 2015-09-17  Tim Horton  <timothy_horton@apple.com>
1143
1144         Add a test ensuring that scrolling in the middle of a page can't start a swipe gesture
1145         https://bugs.webkit.org/show_bug.cgi?id=148904
1146
1147         Reviewed by Myles Maxfield.
1148
1149         * WebKitTestRunner/TestController.cpp:
1150         (WTR::parseBooleanTestHeaderValue):
1151         (WTR::updateViewOptionsFromTestHeader):
1152         Check for the key "useThreadedScrolling".
1153         Add some code to check for "true" and "false" for boolean options.
1154
1155         (WTR::TestController::viewOptionsForTest):
1156         Apply the test's overrides last, even after the platform's.
1157
1158 2015-09-16  Carlos Garcia Campos  <cgarcia@igalia.com>
1159
1160         printing does not use minimum page zoom factor
1161         https://bugs.webkit.org/show_bug.cgi?id=108507
1162
1163         Reviewed by Darin Adler.
1164
1165         WebKitTestRunner always takes the snapshots from the UI process
1166         (expect for IOS), so in the case of printing, the layout in the
1167         web view is not the expected one. When printing, we need to take
1168         the snapshot in the web process and ensure it's rendered with a
1169         PrintContext.
1170
1171         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1172         (WTR::InjectedBundlePage::dump): When dumping pixels, pass
1173         kWKSnapshotOptionsPrinting option to
1174         WKBundlePageCreateSnapshotWithOptions() when printing. When not
1175         printing, don't even create the snapshot, since it will be ignored
1176         by the UI process that always creates its own from the WebView (expect for IOS platform)
1177         * WebKitTestRunner/TestInvocation.cpp:
1178         (WTR::TestInvocation::dumpResults): Use always the snapshot image
1179         received from the web process if any when comparing pixel
1180         results. Now we only receive a snapshot from the web process in
1181         case of printing, or when platform is IOS. Otherwhise, generate
1182         the snapshot from the WebView as usual.
1183         * WebKitTestRunner/TestInvocation.h: Add SnapshotResultType enum
1184         parameter to dumpPixelsAndCompareWithExpected, since the snapshot
1185         is created by the caller now, but the CG implementation needs to
1186         know if it's a Web or UI process snapshot.
1187         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
1188         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
1189         cairo surface for the given image.
1190         * WebKitTestRunner/cg/TestInvocationCG.cpp:
1191         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
1192         CGContext for the given image.
1193
1194 2015-09-16  Myles C. Maxfield  <mmaxfield@apple.com>
1195
1196         Create a font which can be used for testing font features
1197         https://bugs.webkit.org/show_bug.cgi?id=149237
1198
1199         Reviewed by Simon Fraser.
1200
1201         This patch adds a new project in the Tools/ directory which generates a font which can
1202         be used for testing font features. This is a standalone project consisting of two files:
1203         1. A file which actually generates the byte vector representing the font. This file has
1204         a single public function: std::vector<uint8_t> generateFont(). This file is not platform
1205         specific, and only relies on the C++ STL.
1206         2. A file with a main() which calls generateFont() and writes out the font, as well as
1207         uses the font to render some demonstration text into a .png file. This file is platform
1208         specific.
1209
1210         The font itself only supports the following characters:
1211         ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz
1212         However, the shape of these letters are either an X or a check mark.
1213
1214         The letter "A" always is a check mark.
1215         The letter "B" always is an X.
1216         Without any font features turned on, the rest of the letters are shown as X.
1217
1218         Each font feature has an letter associated with it. When the font feature is enabled,
1219         that letter is shown as a check mark. For example, when "smcp" is enabled, "J" is shown
1220         as a check mark.
1221
1222         Here are the mappings of font features to letters:
1223         liga: C
1224         clig: D
1225         dlig: E
1226         hlig: F
1227         calt: G
1228         subs: H
1229         sups: I
1230         smcp: J
1231         c2sc: K
1232         pcap: L
1233         c2pc: M
1234         unic: N
1235         titl: O
1236         onum: P
1237         pnum: Q
1238         tnum: R
1239         frac: S
1240         afrc: T
1241         ordn: U
1242         zero: V
1243         hist: W
1244         jp78: X
1245         jp83: Y
1246         jp90: Z
1247         jp04: a
1248         smpl: b
1249         trad: c
1250         fwid: d
1251         pwid: e
1252         ruby: f
1253
1254         * FontWithFeatures/FontWithFeatures.xcodeproj/project.pbxproj: Added.
1255         * FontWithFeatures/FontWithFeatures/FontCreator.cpp: Added.
1256         (integralLog2):
1257         (roundDownToPowerOfTwo):
1258         (isFourByteAligned):
1259         (clampTo):
1260         (append32):
1261         (writeCFFEncodedNumber):
1262         (CFFBuilder::CFFBuilder):
1263         (CFFBuilder::takeResult):
1264         (CFFBuilder::moveTo):
1265         (CFFBuilder::lineTo):
1266         (CFFBuilder::curveToCubic):
1267         (CFFBuilder::closePath):
1268         (CFFBuilder::writePoint):
1269         (generateBoxCharString):
1270         (generateCheckCharString):
1271         (generateXCharString):
1272         (charStringForGlyph):
1273         (Generator::generate):
1274         (Generator::Placeholder::Placeholder):
1275         (Generator::Placeholder::populate):
1276         (Generator::Placeholder::~Placeholder):
1277         (Generator::placeholder):
1278         (Generator::append16):
1279         (Generator::append32):
1280         (Generator::append32BitCode):
1281         (Generator::overwrite16):
1282         (Generator::overwrite32):
1283         (Generator::appendCFFTable):
1284         (Generator::appendSubstitutionSubtable):
1285         (Generator::appendScriptSubtable):
1286         (Generator::appendGSUBTable):
1287         (Generator::appendOS2Table):
1288         (Generator::appendFormat12CMAPTable):
1289         (Generator::appendFormat4CMAPTable):
1290         (Generator::appendCMAPTable):
1291         (Generator::appendHEADTable):
1292         (Generator::appendHHEATable):
1293         (Generator::appendHMTXTable):
1294         (Generator::appendMAXPTable):
1295         (Generator::appendNAMETable):
1296         (Generator::appendPOSTTable):
1297         (Generator::calculateChecksum):
1298         (Generator::appendTable):
1299         (generateFont):
1300         * FontWithFeatures/FontWithFeatures/FontCreator.h: Added.
1301         * FontWithFeatures/FontWithFeatures/main.cpp: Added.
1302         (drawTextWithFeature):
1303         (main):
1304
1305 2015-09-16  Commit Queue  <commit-queue@webkit.org>
1306
1307         Unreviewed, rolling out r189875 and r189878.
1308         https://bugs.webkit.org/show_bug.cgi?id=149235
1309
1310         cygwin cmake build not ready yet (Requested by alexchristensen
1311         on #webkit).
1312
1313         Reverted changesets:
1314
1315         "Switch AppleWin build to use CMake"
1316         https://bugs.webkit.org/show_bug.cgi?id=149163
1317         http://trac.webkit.org/changeset/189875
1318
1319         "Cygwin build fix after r189875"
1320         http://trac.webkit.org/changeset/189878
1321
1322 2015-09-16  Alex Christensen  <achristensen@webkit.org>
1323
1324         Cygwin build fix after r189875
1325
1326         * Scripts/build-webkit:
1327         * Scripts/webkitdirs.pm:
1328         (jhbuildWrapperPrefixIfNeeded):
1329         (generateBuildSystemFromCMakeProject):
1330         Make things work with cygwin and cmake.
1331
1332 2015-09-16  Alex Christensen  <achristensen@webkit.org>
1333
1334         Switch AppleWin build to use CMake
1335         https://bugs.webkit.org/show_bug.cgi?id=149163
1336
1337         Reviewed by Brent Fulgham.
1338
1339         * Scripts/build-webkit:
1340         Build with CMake.
1341         * Scripts/run-api-tests:
1342         (runTest):
1343         (listAllTests):
1344         (prepareEnvironmentForRunningTestTool):
1345         (testToolPaths):
1346         (testToolPath): Deleted.
1347         Run the API tests as separate executables on Windows.
1348         It used to be TestWebKitAPI.exe, and it is now TestWTF.exe, TestWebCore.exe, and TestWebKit.exe.
1349
1350 2015-09-16  Alexey Proskuryakov  <ap@apple.com>
1351
1352         Add newer build.webkit.org pages to robots.txt
1353         https://bugs.webkit.org/show_bug.cgi?id=149219
1354
1355         Reviewed by Darin Adler.
1356
1357         Indexing bot watcher's dashboard can't be good.
1358
1359         * BuildSlaveSupport/build.webkit.org-config/public_html/robots.txt:
1360
1361 2015-09-16  Alex Christensen  <achristensen@webkit.org>
1362
1363         Rollout r189851 and 189853 because they didn’t actually fix the permissions issue
1364
1365         * BuildSlaveSupport/built-product-archive:
1366         (unzipArchive):
1367
1368 2015-09-16  Csaba Osztrogonác  <ossy@webkit.org>
1369
1370         [EFL] Fix the help message of separated web process option of MiniBrowser
1371         https://bugs.webkit.org/show_bug.cgi?id=149212
1372
1373         Reviewed by Gyuyoung Kim.
1374
1375         * MiniBrowser/efl/main.c:
1376
1377 2015-09-16  Alex Christensen  <achristensen@webkit.org>
1378
1379         Fix python syntax after r189851.
1380
1381         * BuildSlaveSupport/built-product-archive:
1382         (unzipArchive):
1383         For loops need a colon.
1384
1385 2015-09-15  Alex Christensen  <achristensen@webkit.org>
1386
1387         Fix Windows test bots after changing to non-cygwin build
1388         https://bugs.webkit.org/show_bug.cgi?id=149196
1389
1390         Reviewed by Daniel Bates.
1391
1392         * BuildSlaveSupport/built-product-archive:
1393         (unzipArchive):
1394         Using different versions of python makes what I think is https://bugs.python.org/issue15795
1395         prevent us from executing files from the archive on the test bots.
1396
1397 2015-09-15  Ryosuke Niwa  <rniwa@webkit.org>
1398
1399         Add ShadowRoot interface and Element.prototype.attachShadow
1400         https://bugs.webkit.org/show_bug.cgi?id=149187
1401
1402         Reviewed by Antti Koivisto.
1403
1404         * Scripts/webkitperl/FeatureList.pm:
1405
1406 2015-09-15  Aakash Jain  <aakash_jain@apple.com>
1407
1408         Appscale queue status json output lacks bots
1409         https://bugs.webkit.org/show_bug.cgi?id=149194
1410         <rdar://problem/22171089>
1411
1412         Reviewed by Alexey Proskuryakov.
1413
1414         * QueueStatusServer/handlers/queuestatusjson.py:
1415         (QueueStatusJSON._bots): Order the results by date so as to get latest events, this was default in AppEngine.
1416         * QueueStatusServer/index.yaml: Index according to appscale requirements.
1417
1418 2015-09-15  Brent Fulgham  <bfulgham@apple.com>
1419
1420         [Win] Provide a means for viewing the layer tree
1421         https://bugs.webkit.org/show_bug.cgi?id=149165
1422
1423         Reviewed by Simon Fraser.
1424
1425         Update MiniBrowser with a new Debug menu option that will
1426         dump the current layer tree to the debug console.
1427
1428         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc:
1429         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h:
1430         * MiniBrowser/win/Common.cpp:
1431         (WndProc): Add handler for 'Print Layer Tree' menu option.
1432         * MiniBrowser/win/MiniBrowser.cpp:
1433         (MiniBrowser::printLayerTree): Added Handler.
1434         * MiniBrowser/win/MiniBrowser.h:
1435
1436 2015-09-14  Myles C. Maxfield  <mmaxfield@apple.com>
1437
1438         WebKitTestRunner declarative language setting is broken for iOS
1439         https://bugs.webkit.org/show_bug.cgi?id=149119
1440
1441         Unreviewed.
1442
1443         In all of the patches on webkit.org/b/189669, my patch to get this working on iOS was
1444         lost in the final version which got committed. This simply implements the existing
1445         OS X behavior on iOS.
1446
1447         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
1448         (WTR::InjectedBundle::platformInitialize):
1449
1450 2015-09-14  Dewei Zhu  <dewei_zhu@apple.com>
1451
1452         Unreviewed, add myself to committers list.
1453
1454         * Scripts/webkitpy/common/config/contributors.json:
1455
1456 2015-09-12  Myles C. Maxfield  <mmaxfield@apple.com>
1457
1458         [Cocoa] Allow testing with the system language
1459         https://bugs.webkit.org/show_bug.cgi?id=148671
1460
1461         Reviewed by Anders Carlsson and Alexey Proskuryakov.
1462
1463         React to tests marked with language=lang1,lang2,etc in their header.
1464         Once this information is parsed, pass it to
1465         WKContextConfigurationSetOverrideLanguages().
1466
1467         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
1468         (WTR::InjectedBundle::platformInitialize): Don't clobber the language
1469         list.
1470         * WebKitTestRunner/TestController.cpp:
1471         (WTR::TestController::createWebViewWithOptions): Call
1472         WKContextConfigurationSetOverrideLanguages().
1473         (WTR::updateTestOptionsFromTestHeader): Inspect the language option.
1474         * WebKitTestRunner/TestOptions.h:
1475         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1476         (WTR::PlatformWebView::viewSupportsOptions): Cause a differing language
1477         option to restart the web process.
1478         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1479         (WTR::PlatformWebView::viewSupportsOptions): Ditto.
1480
1481 2015-09-12  Myles C. Maxfield  <mmaxfield@apple.com>
1482
1483         [WKTR] Allow changing the WKContextConfiguration between successive tests
1484         https://bugs.webkit.org/show_bug.cgi?id=148833
1485
1486         Reviewed by Tim Horton.
1487
1488         Previously, we were creating a single WKContext and it lived for the life of the entire test runner.
1489         However, there are certain tests which require specifying options in this object. This patch makes
1490         our existing code for recreating the test runner web view also recreate the WKContext.
1491
1492         As such, our options to the view are now options to the WKContextConfiguration. This patch renames the
1493         class.
1494
1495         * WebKitTestRunner/ContextConfigurationOptions.h: Renamed from Tools/WebKitTestRunner/ViewOptions.h.
1496         * WebKitTestRunner/PlatformWebView.h:
1497         (WTR::PlatformWebView::options):
1498         * WebKitTestRunner/TestController.cpp:
1499         (WTR::TestController::initialize):
1500         (WTR::TestController::generateContextConfiguration):
1501         (WTR::TestController::generatePageConfiguration):
1502         (WTR::TestController::createWebViewWithOptions):
1503         (WTR::TestController::ensureViewSupportsOptionsForTest):
1504         (WTR::updateContextConfigurationOptionsFromTestHeader):
1505         (WTR::TestController::contextConfigurationOptionsForTest):
1506         (WTR::TestController::platformCreateWebView):
1507         (WTR::TestController::platformCreateOtherPage):
1508         (WTR::updateViewOptionsFromTestHeader): Deleted.
1509         (WTR::TestController::viewOptionsForTest): Deleted.
1510         * WebKitTestRunner/TestController.h:
1511         (WTR::TestController::injectedBundlePath):
1512         (WTR::TestController::testPluginDirectory):
1513         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1514         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1515         (WTR::TestController::platformCreateWebView):
1516         (WTR::TestController::platformCreateOtherPage):
1517         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1518         (WTR::PlatformWebView::PlatformWebView):
1519         (WTR::PlatformWebView::viewSupportsOptions):
1520         * WebKitTestRunner/efl/TestControllerEfl.cpp:
1521         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
1522         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
1523         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1524         (WTR::PlatformWebView::PlatformWebView):
1525         (WTR::PlatformWebView::viewSupportsOptions):
1526         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1527         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
1528         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
1529         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1530         (WTR::PlatformWebView::PlatformWebView):
1531         (WTR::PlatformWebView::viewSupportsOptions):
1532         * WebKitTestRunner/ios/TestControllerIOS.mm:
1533         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
1534         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
1535         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1536         (WTR::PlatformWebView::PlatformWebView):
1537         (WTR::PlatformWebView::viewSupportsOptions):
1538         * WebKitTestRunner/mac/TestControllerMac.mm:
1539         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
1540         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
1541
1542 2015-09-11  Michael Saboff  <msaboff@apple.com>
1543
1544         LayoutTestHelper crashes if a color profile isn't set for a 3rd party monitor
1545         https://bugs.webkit.org/show_bug.cgi?id=149083
1546
1547         Reviewed by Alexey Proskuryakov.
1548
1549         Check to make sure that we have a valid factoryProfile CFDictionaryRef before using it.
1550
1551         * DumpRenderTree/mac/LayoutTestHelper.m:
1552         (colorProfileURLForDisplay):
1553
1554 2015-09-11  Saam barati  <sbarati@apple.com>
1555
1556         There should be a defaultSpotCheck-like mode that doesn't run the MaximalFlushInsertionPhase in run-jsc-stress-tests
1557         https://bugs.webkit.org/show_bug.cgi?id=149058
1558
1559         Reviewed by Geoffrey Garen.
1560
1561         * Scripts/run-jsc-stress-tests:
1562
1563 2015-09-10  Commit Queue  <commit-queue@webkit.org>
1564
1565         Unreviewed, rolling out r189595.
1566         https://bugs.webkit.org/show_bug.cgi?id=149052
1567
1568         The tests still fail (Requested by ap on #webkit).
1569
1570         Reverted changeset:
1571
1572         "Spurious output on Windows tests: AQMEIOManager::FindIOUnit:
1573         error -1"
1574         https://bugs.webkit.org/show_bug.cgi?id=142929
1575         http://trac.webkit.org/changeset/189595
1576
1577 2015-09-10  Alexey Proskuryakov  <ap@apple.com>
1578
1579         Spurious output on Windows tests: AQMEIOManager::FindIOUnit: error -1
1580         https://bugs.webkit.org/show_bug.cgi?id=142929
1581
1582         Reviewed by Brent Fulgham.
1583
1584         Silence the logging. We'll track fixing the root cause in Radar.
1585
1586         * Scripts/webkitpy/port/mac.py:
1587         (MacPort.stderr_patterns_to_strip): Added a FIXME.
1588
1589         * Scripts/webkitpy/port/win.py:
1590         (WinPort.logging_patterns_to_strip): Added.
1591
1592 2015-09-09  Andy Estes  <aestes@apple.com>
1593
1594         [iOS] Teach run-webkit-tests how to parse simulator runtimes when version numbers contain a revision
1595         https://bugs.webkit.org/show_bug.cgi?id=149022
1596
1597         Reviewed by Daniel Bates.
1598
1599         Simulator runtime versions can contain a revision number (e.g. 8.4.1), but the regex for matching runtimes
1600         did not account for this.
1601
1602         * Scripts/webkitpy/xcode/simulator.py:
1603         (Simulator): Optionally matched a revision at the end of a runtime version number.
1604         * Scripts/webkitpy/xcode/simulator_unittest.py: Added a test.
1605
1606 2015-09-09  Andy Estes  <aestes@apple.com>
1607
1608         [iOS] Teach run-webkit-tests how to parse `simctl list` when a tvOS SDK is installed
1609         https://bugs.webkit.org/show_bug.cgi?id=149029
1610         <rdar://problem/22432624>
1611
1612         Reviewed by Daniel Bates.
1613
1614         * Scripts/webkitpy/xcode/simulator.py:
1615         (Simulator): Taught to parse tvOS runtimes.
1616         * Scripts/webkitpy/xcode/simulator_unittest.py: Added tests.
1617
1618 2015-09-09  Alexey Proskuryakov  <ap@apple.com>
1619
1620         Fix bit rot on bot watcher's dashboard page
1621         https://bugs.webkit.org/show_bug.cgi?id=149012
1622
1623         Reviewed by Tim Horton.
1624
1625         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1626         The code path used by the metrics page was trying to add properties to an undefined.
1627
1628         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
1629         Silence an expection that would occur when the step has no logs. This should never
1630         happen, but it did (perhaps buildbot was misconfigured for a while).
1631
1632 2015-09-09  Alexey Proskuryakov  <ap@apple.com>
1633
1634         Update LayoutTestRelay xcconfig file.
1635
1636         Rubber-stamped by Dan Bernstein.
1637
1638         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
1639
1640 2015-09-09  Saam barati  <sbarati@apple.com>
1641
1642         DFG should have a debugging option that runs a phase that flushes all locals
1643         https://bugs.webkit.org/show_bug.cgi?id=148916
1644
1645         Reviewed by Filip Pizlo.
1646
1647         * Scripts/run-jsc-stress-tests:
1648
1649 2015-09-09  Commit Queue  <commit-queue@webkit.org>
1650
1651         Unreviewed, rolling out r189530 and r189534.
1652         https://bugs.webkit.org/show_bug.cgi?id=148996
1653
1654         Caused assertion failures on Yosemite (Requested by litherum
1655         on #webkit).
1656
1657         Reverted changesets:
1658
1659         "[WKTR] Allow changing the WKContextConfiguration between
1660         successive tests"
1661         https://bugs.webkit.org/show_bug.cgi?id=148833
1662         http://trac.webkit.org/changeset/189530
1663
1664         "[Cocoa] Fix the tests after r189530"
1665         http://trac.webkit.org/changeset/189534
1666
1667 2015-09-08  Myles C. Maxfield  <mmaxfield@apple.com>
1668
1669         [Cocoa] Fix the tests after r189530
1670
1671         Unreviewed.
1672
1673         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1674         (WTR::initializeWebViewConfiguration):
1675
1676 2015-09-08  Myles C. Maxfield  <mmaxfield@apple.com>
1677
1678         [WKTR] Allow changing the WKContextConfiguration between successive tests
1679         https://bugs.webkit.org/show_bug.cgi?id=148833
1680
1681         Reviewed by Tim Horton.
1682
1683         Previously, we were creating a single WKContext and it lived for the life of the entire test runner.
1684         However, there are certain tests which require specifying options in this object. This patch makes
1685         our existing code for recreating the test runner web view also recreate the WKContext.
1686
1687         As such, our options to the view are now options to the WKContextConfiguration. This patch renames the
1688         class.
1689
1690         * WebKitTestRunner/ContextConfigurationOptions.h: Renamed from Tools/WebKitTestRunner/ViewOptions.h.
1691         * WebKitTestRunner/PlatformWebView.h:
1692         (WTR::PlatformWebView::options):
1693         * WebKitTestRunner/TestController.cpp:
1694         (WTR::TestController::initialize):
1695         (WTR::TestController::generateContextConfiguration):
1696         (WTR::TestController::generatePageConfiguration):
1697         (WTR::TestController::createWebViewWithOptions):
1698         (WTR::TestController::ensureViewSupportsOptionsForTest):
1699         (WTR::updateContextConfigurationOptionsFromTestHeader):
1700         (WTR::TestController::contextConfigurationOptionsForTest):
1701         (WTR::TestController::platformCreateWebView):
1702         (WTR::TestController::platformCreateOtherPage):
1703         (WTR::updateViewOptionsFromTestHeader): Deleted.
1704         (WTR::TestController::viewOptionsForTest): Deleted.
1705         * WebKitTestRunner/TestController.h:
1706         (WTR::TestController::injectedBundlePath):
1707         (WTR::TestController::testPluginDirectory):
1708         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1709         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1710         (WTR::TestController::platformCreateWebView):
1711         (WTR::TestController::platformCreateOtherPage):
1712         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1713         (WTR::PlatformWebView::PlatformWebView):
1714         (WTR::PlatformWebView::viewSupportsOptions):
1715         * WebKitTestRunner/efl/TestControllerEfl.cpp:
1716         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
1717         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
1718         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1719         (WTR::PlatformWebView::PlatformWebView):
1720         (WTR::PlatformWebView::viewSupportsOptions):
1721         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1722         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
1723         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
1724         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1725         (WTR::PlatformWebView::PlatformWebView):
1726         (WTR::PlatformWebView::viewSupportsOptions):
1727         * WebKitTestRunner/ios/TestControllerIOS.mm:
1728         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
1729         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
1730         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1731         (WTR::PlatformWebView::PlatformWebView):
1732         (WTR::PlatformWebView::viewSupportsOptions):
1733         * WebKitTestRunner/mac/TestControllerMac.mm:
1734         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
1735         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
1736
1737 2015-09-08  Daniel Bates  <dabates@apple.com>
1738
1739         [Mac] Expose Enable/Disable Accelerated Drawing in MiniBrowser
1740         https://bugs.webkit.org/show_bug.cgi?id=148980
1741
1742         Reviewed by Alexey Proskuryakov.
1743
1744         Add setting to enable/disable accelerated drawing so as to support testing
1745         this feature in MiniBrowser on Mac.
1746
1747         * MiniBrowser/mac/SettingsController.h:
1748         * MiniBrowser/mac/SettingsController.m:
1749         (-[SettingsController _populateMenu]): Add menu item.
1750         (-[SettingsController validateMenuItem:]): Update setting when menu item is toggled.
1751         (-[SettingsController toggleAcceleratedDrawingEnabled:]): Added.
1752         (-[SettingsController acceleratedDrawingEnabled]): Added.
1753         * MiniBrowser/mac/WK1BrowserWindowController.m:
1754         (-[WK1BrowserWindowController didChangeSettings]): Apply setting in WebKit1.
1755         * MiniBrowser/mac/WK2BrowserWindowController.m:
1756         (-[WK2BrowserWindowController didChangeSettings]): Apply setting in WebKit2.
1757
1758 2015-09-08  Jason Marcell  <jmarcell@apple.com>
1759
1760         Unreviewed. Added myself as a commiter in contributors.json.
1761
1762         * Scripts/webkitpy/common/config/contributors.json:
1763
1764 2015-09-08  Keith Miller  <keith_miller@apple.com>
1765
1766         Unreviewed, added myself to the list of contributors.
1767
1768         * Scripts/webkitpy/common/config/contributors.json:
1769
1770 2015-09-08  Daniel Bates  <dabates@apple.com>
1771
1772         Dashboard: Remove use of z-index for ring overlay; use DOM ordering
1773         https://bugs.webkit.org/show_bug.cgi?id=148921
1774
1775         Reviewed by Alexey Proskuryakov.
1776
1777         The ring image is positioned above the platform icon in markup and we specify the CSS
1778         property z-index for the ring image so that it is painted on top of the platform icon
1779         instead of below it (by DOM ordering). Instead we can take advantage of the transparency
1780         of the ring image, switch the order of these DOM elements and remove the use of the CSS
1781         property z-index to achieve a similar effect.
1782
1783         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
1784         (documentReady): Create the platform icon image element before the ring image such that
1785         the ring image is painted on top of the platform icon.
1786         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1787         (table.queue-grid td.logo img.ring): Removed property z-index.
1788
1789 2015-09-08  Daniel Bates  <dabates@apple.com>
1790
1791         Dashboard: Remove duplicate gear icon data URLs
1792         https://bugs.webkit.org/show_bug.cgi?id=148920
1793
1794         Reviewed by Alexey Proskuryakov.
1795
1796         Currently we duplicate the SVG data URL for the gear icon up to its fill color in the CSS property
1797         background-image associated with each of the three gear icon states: collapsed (.settings), hover
1798         (.settings:hover), and expanded (.settings-visible .settings). Instead we should use the gear icon
1799         as a mask and make use of the CSS background-color to define the fill color for each of these three
1800         states.
1801
1802         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1803         (.settings): Use gear icon as mask and define CSS background-color for collapsed state.
1804         (.settings:hover): Override CSS background-color for hover state.
1805         (.settings-visible .settings): Override CSS background-color for expanded state.
1806
1807 2015-09-07  Andy Estes  <aestes@apple.com>
1808
1809         [Mac] DebugRelease builds should link against libWebKitSystemInterfaceElCapitan.a on 10.11
1810         https://bugs.webkit.org/show_bug.cgi?id=148946
1811         <rdar://problem/22603981>
1812
1813         Reviewed by Dan Bernstein.
1814
1815         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1816         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1817
1818 2015-09-07  Hunseop Jeong  <hs85.jeong@samsung.com>
1819
1820         [EFL] Many of the css3/device-adapt/* tests failed after r188548.
1821         https://bugs.webkit.org/show_bug.cgi?id=148927
1822
1823         Reviewed by Csaba Osztrogonác.
1824
1825         device-adapt/* tests need the fixedLayout option but useFixedLayout option is
1826         overwritten by updatePlatformSpecificViewOptionsForTest after r188548.
1827
1828         * WebKitTestRunner/TestController.cpp:
1829         (WTR::shouldUseFixedLayout): Removed the unnecessary indentations.
1830         * WebKitTestRunner/efl/TestControllerEfl.cpp:
1831         (WTR::shouldUseFixedLayout): Return true if the test is related with 'device-adapt'.
1832
1833 2015-09-07  Andy Estes  <aestes@apple.com>
1834
1835         Fix the Production build after r189455.
1836
1837         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Somehow I added the All target using the
1838         In-App Purchase template instead of the Aggregate template. Whoops.
1839
1840 2015-09-06  Andy Estes  <aestes@apple.com>
1841
1842         WebKit.xcworkspace should be be able to build iOS platforms
1843         https://bugs.webkit.org/show_bug.cgi?id=148881
1844
1845         Reviewed by Daniel Bates.
1846
1847         Since we don't want to create platform-specific schemes, all projects in the workspace's schemes need to build
1848         for all supported platforms.
1849
1850         * MiniBrowser/Configurations/Base.xcconfig: Included iphoneos and iphonesimulator in SUPPORTED_PLATFORMS.
1851         * MiniBrowser/Configurations/MiniBrowser.xcconfig: Excluded all source files on iOS, and linked Cocoa and WebKit on Mac.
1852         * MiniBrowser/Configurations/MiniBrowserBundle.xcconfig: Ditto.
1853         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Stopped linking frameworks in Link Binaries With Libraries.
1854
1855 2015-09-06  Andy Estes  <aestes@apple.com>
1856
1857         WebKitTestRunner should build for iOS using the default target
1858         https://bugs.webkit.org/show_bug.cgi?id=148918
1859
1860         Reviewed by Daniel Bates.
1861
1862         When WebKitTestRunner was ported to iOS, a separate target (WebKitTestRunnerApp) was created for building the
1863         iOS variant. This is annoying because (1) all tools that invoke xcodebuild need to be taught to build this
1864         non-default target, and (2) a single Xcode scheme cannot be used to build both Mac and iOS variants.
1865
1866         This change adds a new default target (All) and makes it work for both Mac and iOS. Files that were built for
1867         both WebKitTestRunner and WebKitTestRunnerApp are now built in a static library target (WebKitTestRunner (Library)),
1868         and both apps now link this library. Files that are specific to Mac or iOS are excluded on the other platform.
1869         WebKitTestRunnerApp.app (which should be renamed to WebKitTestRunner.app) is skipped when installing on Mac, and
1870         WebKitTestRunner is skipped when installing on iOS.
1871
1872         The target dependency graph now looks like this:
1873
1874             All
1875                 WebKitTestRunnerApp
1876                     WebKitTestRunner (Library)
1877                         WebKitTestRunnerInjectedBundle
1878                             Derived Sources
1879                 WebKitTestRunner
1880                     WebKitTestRunner (Library)
1881                         WebKitTestRunnerInjectedBundle
1882                             Derived Sources
1883
1884         * Scripts/build-webkit: Stopped building the WebKitTestRunnerApp target on iOS.
1885         * Scripts/build-webkittestrunner: Ditto.
1886         * WebKitTestRunner/Configurations/Base.xcconfig: Set SUPPORTED_PLATFORMS to macosx, iphoneos, and iphonesimulator.
1887         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Set INSTALL_PATH here since it is the same for all targets.
1888         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Stopped setting INSTALL_PATH.
1889         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig: Moved frameworks from the build phase to here,
1890         excluded iOS-only files, and skipped installing on iOS.
1891         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: Moved frameworks from the build phase to here,
1892         excluded Mac-only files, and skipped installing on Mac.
1893         * WebKitTestRunner/Configurations/WebKitTestRunnerLibrary.xcconfig: Skipped installing always.
1894         * WebKitTestRunner/Makefile: Stopped building the WebKitTestRunnerApp target on iOS.
1895         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Added new targets, removed frameworks from
1896         Link Binary With Libraries builds phases, moved common files to the WebKitTestRunner (Library) target, and added
1897         new configuration files.
1898
1899 2015-09-05  Joseph Pecoraro  <pecoraro@apple.com>
1900
1901         Web Inspector: Improve prepare-ChangeLog for multiple cases
1902         https://bugs.webkit.org/show_bug.cgi?id=148875
1903
1904         Reviewed by Timothy Hatcher.
1905
1906         * Scripts/prepare-ChangeLog:
1907         (get_function_line_ranges_for_javascript):
1908         - We were ignoring everything inside of an anonymous function expression,
1909           such as (function(){ ... }), which made InjectedScriptSource produce nothing.
1910           Better handle this by inserting a few tweaks.
1911         - Allow method syntax outside of classes as long as they are at the global level.
1912         - Avoid treating "get" and "set" as getter/setter functions in bad contexts.
1913
1914         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests-expected.txt:
1915         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests.js:
1916         (Foo.prototype.method1):
1917         (Foo.prototype.method2):
1918         (Foo.prototype.method3.innerFunction):
1919         (Foo.prototype.method3):
1920         (insideGlobalAnonymousFunctionExpression):
1921         (foo.insideGlobalFunctionExpression):
1922         (IssueWithMapGetAndSet.prototype.method1.nestedFunctionInsideMethod1):
1923         (IssueWithMapGetAndSet.prototype.method1):
1924         (IssueWithMapGetAndSet.prototype.method2):
1925         (IssueWithMapGetAndSet.prototype.method3):
1926         (IssueWithMapGetAndSet):
1927
1928 2015-09-05  Yusuke Suzuki  <utatane.tea@gmail.com>
1929
1930         [ES6] Enable ES6 Module in JSC shell by default
1931         https://bugs.webkit.org/show_bug.cgi?id=148689
1932
1933         Reviewed by Geoffrey Garen.
1934
1935         * Scripts/run-javascriptcore-tests:
1936         (runJSCStressTests):
1937         * Scripts/run-jsc-stress-tests:
1938
1939 2015-09-04  Basile Clement  <basile_clement@apple.com>
1940
1941         Unreviewed, change my email address.
1942
1943         * Scripts/webkitpy/common/config/contributors.json:
1944
1945 2015-09-04  Beth Dakin  <bdakin@apple.com>
1946
1947         Should have a test to make sure links don't navigate after a cancelled force
1948         click
1949         https://bugs.webkit.org/show_bug.cgi?id=148846
1950
1951         Reviewed by Tim Horton.
1952
1953         New EventSender function for a started then cancelled force click.
1954         * WebKitTestRunner/EventSenderProxy.h:
1955         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
1956         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1957         (WTR::EventSendingController::mouseForceClick):
1958         (WTR::EventSendingController::startAndCancelMouseForceClick):
1959         (WTR::EventSendingController::mouseForceDown):
1960         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
1961         * WebKitTestRunner/TestController.cpp:
1962         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
1963         * WebKitTestRunner/mac/EventSenderProxy.mm:
1964         (WTR::EventSenderProxy::mouseForceClick):
1965         (WTR::EventSenderProxy::startAndCancelMouseForceClick):
1966         (WTR::EventSenderProxy::mouseForceDown):
1967         (WTR::EventSenderProxy::mouseMoveTo):
1968
1969 2015-09-04  Tim Horton  <timothy_horton@apple.com>
1970
1971         Add a test for r179736 (programmatic navigation during swipe causing a crash)
1972         https://bugs.webkit.org/show_bug.cgi?id=148830
1973
1974         Reviewed by Beth Dakin.
1975
1976         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1977         (WTR::InjectedBundle::beginTesting):
1978         Make sure that TestRunner callbacks don't leak between tests!
1979
1980 2015-09-04  Anders Carlsson  <andersca@apple.com>
1981
1982         It should be possible to pass relative HTTP test paths to DumpRenderTree
1983         https://bugs.webkit.org/show_bug.cgi?id=148825
1984         <rdar://problem/22583866>
1985
1986         Reviewed by Tim Horton.
1987
1988         Convert the path to an absolute path if needed.
1989
1990         * DumpRenderTree/mac/DumpRenderTree.mm:
1991         (computeTestURL):
1992
1993 2015-09-04  Jason Marcell  <jmarcell@apple.com>
1994
1995         Fix Swift unit tests for prepare-ChangeLog.
1996         https://bugs.webkit.org/show_bug.cgi?id=148817
1997
1998         Reviewed by Alexey Proskuryakov.
1999
2000         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/swift_unittests-expected.txt: Fixed
2001         Swift unit tests for prepare-ChangeLog.
2002
2003 2015-09-04  Lucas Forschler  <lforschler@apple.com>
2004
2005         Modifications to the webkit-nightly logic.
2006
2007         * WebKitLauncher/WebKitNightlyEnablerSparkle.m:
2008         (updateAlertPanel):
2009         * WebKitLauncher/main.m:
2010         (displayErrorAndQuit):
2011
2012 2015-09-04  Beth Dakin  <bdakin@apple.com>
2013
2014         Speculative build fix.
2015
2016         * WebKitTestRunner/mac/EventSenderProxy.mm:
2017
2018 2015-09-04  Brian Burg  <bburg@apple.com>
2019
2020         Web Inspector: InspectorController should support multiple frontend channels
2021         https://bugs.webkit.org/show_bug.cgi?id=148538
2022
2023         Reviewed by Joseph Pecoraro.
2024
2025         InspectorClients must explicitly disconnect their frontend channel(s) from the
2026         inspected page's InspectorController.
2027
2028         To make this possible, DumpRenderTree should not destroy non-primary views until
2029         it has tried to close any abandoned Web Inspector instances. Performing teardown
2030         in the reverse order prevents disconnection of the frontend channel because that
2031         prematurely destroys the inspector frontend client.
2032
2033         * DumpRenderTree/mac/DumpRenderTree.mm:
2034         (runTest):
2035         * DumpRenderTree/win/DumpRenderTree.cpp:
2036         (runTest):
2037
2038 2015-09-04  Beth Dakin  <bdakin@apple.com>
2039
2040         Need to be able to test default behaviors on force click
2041         https://bugs.webkit.org/show_bug.cgi?id=148758
2042
2043         Reviewed by Tim Horton.
2044
2045         This patch adds a new eventSender method to do a full, completed force click,
2046         and it re-works all of the existing force methods to dispatch their events in
2047         such a way that they will trigger the NSImmediateAction gesture recognizer.
2048         To do this, first we need to send the events to the app rather than straight
2049         to the view, and also needed to tweak some state and send the events in a
2050         delayed fashion.
2051
2052         New public function mouseForceClick() and private helper functions to make
2053         NSEvents.
2054         * WebKitTestRunner/EventSenderProxy.h:
2055
2056         New public function mouseForceClick().
2057         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
2058         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2059         (WTR::EventSendingController::mouseMoveTo):
2060         (WTR::EventSendingController::mouseForceClick):
2061         (WTR::EventSendingController::mouseForceDown):
2062         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
2063         * WebKitTestRunner/TestController.cpp:
2064         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
2065
2066         initPressureEventAtLocation needs to take a stageTransition and a window.
2067         * WebKitTestRunner/mac/EventSenderProxy.mm:
2068         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
2069         (-[EventSenderSyntheticEvent stageTransition]):
2070         (-[EventSenderSyntheticEvent timestamp]):
2071         (-[EventSenderSyntheticEvent _cgsEventRecord]):
2072         (-[EventSenderSyntheticEvent window]):
2073
2074         In order to enter the gesture recognizer, we need to start with a mouse down
2075         that has a NSEventMaskPressure modifier.
2076         (WTR::EventSenderProxy::sendMouseDownToStartPressureEvents):
2077
2078         This ensures that the events queue properly for the force monitor in AppKit.
2079         (WTR::spinRunLoopForForce):
2080
2081          We need to start the pressure change events with a began.
2082         (WTR::EventSenderProxy::beginPressureEvent):
2083
2084         These functions can be used to create the NSEvent for a pressure change every
2085         time we need one.
2086         (WTR::EventSenderProxy::pressureChangeEvent):
2087
2088         Send the right series of events to emulate a full, completed force click.
2089         (WTR::EventSenderProxy::mouseForceClick):
2090
2091         Use all of the new things for these existing functions.
2092         (WTR::EventSenderProxy::mouseForceDown):
2093         (WTR::EventSenderProxy::mouseForceUp):
2094         (WTR::EventSenderProxy::mouseForceChanged):
2095
2096         Set NSFakeForceTouchDevice to YES.
2097         * WebKitTestRunner/mac/main.mm:
2098         (setDefaultsToConsistentValuesForTesting):
2099
2100 2015-09-04  Jason Marcell  <jmarcell@apple.com>
2101
2102         prepare-ChangeLog needs to know how to parse Swift files.
2103         https://bugs.webkit.org/show_bug.cgi?id=148784
2104         <rdar://problem/22510062>
2105
2106         Reviewed by Darin Adler.
2107
2108         * Scripts/prepare-ChangeLog:
2109         (get_function_line_ranges): Added entry for get_function_line_ranges_for_swift.
2110         (get_function_line_ranges_for_swift): Added function that knows how to parse Swift code.
2111         (parseSwiftFunctionArgs): Added function that knows how to parse Swift function arguments.
2112         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl: Added.
2113         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/swift_unittests-expected.txt: Ditto.
2114         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/swift_unittests.swift: Ditto.
2115         (freeFunction): Ditto.
2116         (MyClass.function): Ditto.
2117         (MyClass.functionWithArgument(_:)): Ditto.
2118         (MyClass.functionWithMoreArguments(_:arg2:)): Ditto.
2119         (MyClass.functionWithNamedFirstArgument(argument:)): Ditto.
2120         (MyClass.functionWithNamedFirstAndSecondArgument(first:second:)): Ditto.
2121         (MyClass.classFunction): Ditto.
2122         (MyClass.readWriteComputedVariable): Ditto.
2123         (MyClass.readOnlyComputedVariable): Ditto.
2124
2125 2015-09-04  Ryosuke Niwa  <rniwa@webkit.org>
2126
2127         Import css/css-color-3
2128         https://bugs.webkit.org/show_bug.cgi?id=148803
2129
2130         Reviewed by Chris Dumez.
2131
2132         Fixed a bug that the imported reference files used the same extention as tests.
2133         This would result in parsing errors if the tests were XML and references were HTML and vice versa.
2134
2135         * Scripts/webkitpy/w3c/test_importer.py:
2136         (TestImporter.find_importable_tests):
2137
2138 2015-09-03  Commit Queue  <commit-queue@webkit.org>
2139
2140         Unreviewed, rolling out r189338.
2141         https://bugs.webkit.org/show_bug.cgi?id=148785
2142
2143         Caused tons of crashes (Requested by cdumez on #webkit).
2144
2145         Reverted changeset:
2146
2147         "Web Inspector: InspectorController should support multiple
2148         frontend channels"
2149         https://bugs.webkit.org/show_bug.cgi?id=148538
2150         http://trac.webkit.org/changeset/189338
2151
2152 2015-09-03  Brian Burg  <bburg@apple.com>
2153
2154         Web Inspector: InspectorController should support multiple frontend channels
2155         https://bugs.webkit.org/show_bug.cgi?id=148538
2156
2157         Reviewed by Joseph Pecoraro.
2158
2159         InspectorClients must explicitly disconnect their frontend channel(s) from the
2160         inspected page's InspectorController.
2161
2162         To make this possible, DumpRenderTree should not destroy non-primary views until
2163         it has tried to close any abandoned Web Inspector instances. Performing teardown
2164         in the reverse order prevents disconnection of the frontend channel because that
2165         prematurely destroys the inspector frontend client.
2166
2167         * DumpRenderTree/mac/DumpRenderTree.mm:
2168         (runTest):
2169         * DumpRenderTree/win/DumpRenderTree.cpp:
2170         (runTest):
2171
2172 2015-09-03  Timothy Hatcher  <timothy@apple.com>
2173
2174         Update WebKit nightly icon to be more like Safari
2175         https://bugs.webkit.org/show_bug.cgi?id=148768
2176
2177         Reviewed by Joseph Pecoraro.
2178
2179         * WebKitLauncher/webkit.icns:
2180
2181 2015-09-03  Geoffrey Garen  <ggaren@apple.com>
2182
2183         JavaScriptCore should have some ES6 conformance tests
2184         https://bugs.webkit.org/show_bug.cgi?id=148771
2185
2186         Reviewed by Chris Dumez.
2187
2188         * Scripts/run-javascriptcore-tests:
2189         (runJSCStressTests): Added es6 as a test suite.
2190
2191         * Scripts/run-jsc-stress-tests: Added es6 as a test suite.
2192
2193         Some of these tests currently fail, so I also added a way to expect
2194         failure for now. We'll migrate failing tests to expected passes as we
2195         fix them.
2196
2197 2015-09-03  Tim Horton  <timothy_horton@apple.com>
2198
2199         Add a test for swipe-start hysteresis
2200         https://bugs.webkit.org/show_bug.cgi?id=148756
2201
2202         Reviewed by Anders Carlsson.
2203
2204         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2205         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2206         (WTR::cacheTestRunnerCallback):
2207         (WTR::TestRunner::clearTestRunnerCallbacks):
2208         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2209         Make sure that we log if a client tries to install a callback twice
2210         (since we use .add, the second call would not work).
2211
2212         Also, add clearTestRunnerCallbacks so tests can swap out installed
2213         callbacks.
2214
2215 2015-09-03  Anders Carlsson  <andersca@apple.com>
2216
2217         DumpRenderTree should automatically compute HTTP URLs for HTTP tests
2218         https://bugs.webkit.org/show_bug.cgi?id=148746
2219         rdar://problem/22568073
2220
2221         Reviewed by Tim Horton.
2222
2223         * DumpRenderTree/mac/DumpRenderTree.mm:
2224         (computeTestURL):
2225         Compute the test URL from the passed in path or URL. Special-case paths that contain /LayoutTests/http/tests.
2226
2227         (runTest):
2228         Call computeTestURL.
2229
2230         (testPathFromURL):
2231         Get rid of this; computeTestURL does this for us now.
2232
2233         * Scripts/webkitpy/port/driver.py:
2234         (Driver._command_from_driver_input):
2235         Don't convert HTTP test paths to URLS before passing them to DumpRenderTree on Mac. That's handled by DRT itself now.
2236
2237 2015-09-03  Tim Horton  <timothy_horton@apple.com>
2238
2239         Swipe tests fail on Mavericks
2240         https://bugs.webkit.org/show_bug.cgi?id=148752
2241
2242         Reviewed by Beth Dakin.
2243
2244         * WebKitTestRunner/mac/EventSenderProxy.mm:
2245
2246 2015-09-03  Tim Horton  <timothy_horton@apple.com>
2247
2248         Fix the 32-bit build
2249
2250         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2251         (WTR::PlatformWebView::setNavigationGesturesEnabled):
2252
2253 2015-09-03  Tim Horton  <timothy_horton@apple.com>
2254
2255         Remove some logging that wasn't meant to be in the tree
2256
2257         * WebKitTestRunner/mac/EventSenderProxy.mm:
2258         (WTR::EventSenderProxy::swipeGestureWithWheelAndMomentumPhases):
2259
2260 2015-09-03  Tim Horton  <timothy_horton@apple.com>
2261
2262         [Mac] Add support for testing swipes
2263         https://bugs.webkit.org/show_bug.cgi?id=148700
2264
2265         Reviewed by Beth Dakin.
2266
2267         * WebKitTestRunner/EventSenderProxy.h:
2268         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
2269         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2270         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2271         (WTR::cgEventPhaseFromString):
2272         (WTR::cgEventMomentumPhaseFromString):
2273         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
2274         (WTR::EventSendingController::swipeGestureWithWheelAndMomentumPhases):
2275         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
2276         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2277         (WTR::InjectedBundle::didReceiveMessageToPage):
2278         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2279         (WTR::TestRunner::installDidBeginSwipeCallback):
2280         (WTR::TestRunner::installWillEndSwipeCallback):
2281         (WTR::TestRunner::installDidEndSwipeCallback):
2282         (WTR::TestRunner::installDidRemoveSwipeSnapshotCallback):
2283         (WTR::TestRunner::callDidBeginSwipeCallback):
2284         (WTR::TestRunner::callWillEndSwipeCallback):
2285         (WTR::TestRunner::callDidEndSwipeCallback):
2286         (WTR::TestRunner::callDidRemoveSwipeSnapshotCallback):
2287         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2288         * WebKitTestRunner/TestController.cpp:
2289         (WTR::TestController::createOtherPage):
2290         (WTR::TestController::createWebViewWithOptions):
2291         (WTR::TestController::didReceiveMessageFromInjectedBundle):
2292         (WTR::TestController::didBeginNavigationGesture):
2293         (WTR::TestController::willEndNavigationGesture):
2294         (WTR::TestController::didEndNavigationGesture):
2295         (WTR::TestController::didRemoveNavigationGestureSnapshot):
2296         * WebKitTestRunner/TestController.h:
2297         * WebKitTestRunner/TestInvocation.cpp:
2298         (WTR::TestInvocation::didBeginSwipe):
2299         (WTR::TestInvocation::willEndSwipe):
2300         (WTR::TestInvocation::didEndSwipe):
2301         (WTR::TestInvocation::didRemoveSwipeSnapshot):
2302         * WebKitTestRunner/TestInvocation.h:
2303         Add callbacks when navigation gestures didBegin/willEnd/didEnd, and
2304         when the snapshot is removed.
2305
2306         Add swipeGestureWithWheelAndMomentumPhases, just like the equivalent
2307         mouseScrollBy function.
2308
2309         * WebKitTestRunner/mac/EventSenderProxy.mm:
2310         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:phase:time:eventNumber:]):
2311         (-[EventSenderSyntheticEvent type]):
2312         (-[EventSenderSyntheticEvent subtype]):
2313         (-[EventSenderSyntheticEvent locationInWindow]):
2314         (-[EventSenderSyntheticEvent location]):
2315         (-[EventSenderSyntheticEvent momentumPhase]):
2316         (-[EventSenderSyntheticEvent _isTouchesEnded]):
2317         (-[EventSenderSyntheticEvent _cgsEventRecord]):
2318         Rename EventSenderPressureEvent to EventSenderSyntheticEvent and add some
2319         more adjustable values.
2320
2321         (WTR::EventSenderProxy::mouseForceDown):
2322         (WTR::EventSenderProxy::mouseForceUp):
2323         (WTR::EventSenderProxy::mouseForceChanged):
2324         Adopt EventSenderSyntheticEvent.
2325
2326         (WTR::nsEventPhaseFromCGEventPhase):
2327         (WTR::EventSenderProxy::swipeGestureWithWheelAndMomentumPhases):
2328         Make use of EventSenderSyntheticEvent to synthesize swipe gesture events.
2329
2330         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2331         (WTR::PlatformWebView::PlatformWebView):
2332         Enable swipe.
2333
2334 2015-09-03  Myles C. Maxfield  <mmaxfield@apple.com>
2335
2336         [WK2] Allow tagging tests with metadata which needs to be known at web process creation time
2337         https://bugs.webkit.org/show_bug.cgi?id=148723
2338
2339         Reviewed by Anders Carlsson.
2340
2341         * WebKitTestRunner/TestController.cpp:
2342         (WTR::testPath):
2343         (WTR::updateViewOptionsFromTestHeader):
2344         (WTR::TestController::viewOptionsForTest):
2345
2346 2015-09-03  Lucas Forschler  <lforschler@apple.com>
2347
2348         Test commit.
2349
2350 2015-09-02  Tim Horton  <timothy_horton@apple.com>
2351
2352         Add a modern API way to know that the navigation gesture snapshot was removed, for WebKitTestRunner
2353         https://bugs.webkit.org/show_bug.cgi?id=148693
2354
2355         Reviewed by Anders Carlsson.
2356
2357         * WebKitTestRunner/TestController.cpp:
2358         (WTR::TestController::createOtherPage):
2359         (WTR::TestController::createWebViewWithOptions):
2360
2361 2015-09-02  Carlos Garcia Campos  <cgarcia@igalia.com>
2362
2363         REGRESSION(r188548): Some tests crash after r188548 because injected bundle messages are received after the test finishes
2364         https://bugs.webkit.org/show_bug.cgi?id=148529
2365
2366         Reviewed by Darin Adler.
2367
2368         When there are pending EventSender messages after a test finishes,
2369         they could be processed in the main loop started by the
2370         resetStateToConsistentValues(), but the old EventSender has been
2371         replaced by a new one at that point. The new Eventsender can crash
2372         when processing messages that were sent to the old one. To avoid
2373         this, we return early when receiving an EventSender message and
2374         the TestController state is not RunningTest.
2375
2376         * WebKitTestRunner/TestController.cpp:
2377         (WTR::TestController::didReceiveKeyDownMessageFromInjectedBundle):
2378         (WTR::TestController::didReceiveMessageFromInjectedBundle):
2379
2380 2015-09-02  Carlos Garcia Campos  <cgarcia@igalia.com>
2381
2382         REGRESSION(r188548): TestController state is Resseting while tests are running after r188548
2383         https://bugs.webkit.org/show_bug.cgi?id=148528
2384
2385         Reviewed by Darin Adler.
2386
2387         Before r188548 resetStateToConsistentValues() was called in
2388         TestController::run(), before tests are run, but now it's called
2389         for every test in TestInvocation::invoke(), after m_status has
2390         changed to RunningTest.
2391
2392         * WebKitTestRunner/TestController.cpp:
2393         (WTR::TestController::resetStateToConsistentValues): Use
2394         TemporaryChange to reset m_state ot its previous value after reset
2395         is done.
2396
2397 2015-08-31  Jason Marcell  <jmarcell@apple.com>
2398
2399         Modify prepare-Changelog to be aware of files that are marked as tests as well as files
2400         that are marked as requiring corresponding tests.
2401         https://bugs.webkit.org/show_bug.cgi?id=148498
2402         <rdar://problem/21555314>
2403
2404         Reviewed by Dan Bernstein and David Kilzer.
2405
2406         * Scripts/prepare-ChangeLog: Added "attributeCache" to cache Subversion properties in order to
2407         simulate Git's attribute behevaior.
2408         (main): Added "requiresTests" array to contain files that require tests.
2409         (generateNewChangeLogs): Checks "requiresTests" array to determine whether to inject "tests"
2410         section in ChangeLog.
2411         (attributeCommand): Queries a given file for a given Git attribute value. If using Subversion,
2412         however, we check if the file or any containing folder has the given property set to "1" and
2413         return 1 if so; return 0 otherwise.
2414         (generateFileList): Adds files to "requiresTests" array if Git attribute is set to "1". Also
2415         adds files to "addedRegressionTests" array if "test" attribute is set to "1".
2416
2417 2015-08-26  Andy Estes  <aestes@apple.com>
2418
2419         [Content Filtering] Determine navigation and content policy before continuing to filter a load
2420         https://bugs.webkit.org/show_bug.cgi?id=148506
2421
2422         Reviewed by Brady Eidson.
2423
2424         Added download API tests covering every decision and decision point.
2425         Removed _WKDownload.AsynchronousDownloadPolicy in favor of these new tests.
2426
2427         * TestWebKitAPI/Configurations/Base.xcconfig: Added $(BUILT_PRODUCTS_DIR)/WebCoreTestSupport to the header search path.
2428         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Removed it from here.
2429         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParametersPlugIn.mm:
2430         (-[BundleParametersPlugIn observeValueForKeyPath:ofObject:change:context:]): Called -valueForKeyPath:, which
2431         returns an id, instead of -valueForKey:, which always returns an NSString even if the object is of another type.
2432         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm: Added a class that can send a MockContentFilter
2433         decision and decision point as a bundle parameter.
2434         (+[MockContentFilterEnabler supportsSecureCoding]):
2435         (-[MockContentFilterEnabler copyWithZone:]):
2436         (-[MockContentFilterEnabler initWithCoder:]):
2437         (-[MockContentFilterEnabler initWithDecision:decisionPoint:]):
2438         (-[MockContentFilterEnabler encodeWithCoder:]):
2439         (configurationWithContentFilterSettings): Added a helper function to create a WKWebViewConfiguration with MockConentFilter settings.
2440         (TEST): Renamed ContentFiltering.ServerRedirect to ContentFiltering.URLAfterServerRedirect.
2441         (-[BecomeDownloadDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Decided _WKNavigationResponsePolicyBecomeDownload.
2442         (-[BecomeDownloadDelegate webView:didFailProvisionalNavigation:withError:]): Set isDone to true.
2443         (-[BecomeDownloadDelegate webView:didFinishNavigation:]): Ditto.
2444         (-[ContentFilteringDownloadDelegate _downloadDidStart:]): Set downloadDidStart to true.
2445         (downloadTest): Added a helper function to test downloads with a given decision and decision point.
2446         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm: Added a corresponding bundle class that decodes
2447         the MockContentFilter decision and decision point, and sets these values in the MockContentFilterSettings
2448         singleton. This class is duplicated in the bundle to prevent TestWebKitAPI from having to link to WebCoreTestSupport.
2449         (+[MockContentFilterEnabler supportsSecureCoding]):
2450         (-[MockContentFilterEnabler copyWithZone:]):
2451         (-[MockContentFilterEnabler initWithCoder:]):
2452         (-[MockContentFilterEnabler dealloc]):
2453         (-[MockContentFilterEnabler encodeWithCoder:]):
2454         (-[ContentFilteringPlugIn webProcessPlugIn:initializeWithObject:]): Start observing changes to the MockContentFilterEnabler key path.
2455         (-[ContentFilteringPlugIn dealloc]): Stop observing.
2456         (-[ContentFilteringPlugIn observeValueForKeyPath:ofObject:change:context:]): Store a MockContentFilterEnabler in _contentFilterEnabler.
2457         (+[ServerRedirectPlugIn initialize]): Deleted.
2458         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2459         (-[AsynchronousDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
2460         (-[AsynchronousDownloadDelegate _downloadDidStart:]): Deleted.
2461         (TEST): Deleted.
2462
2463 2015-08-31  Filip Pizlo  <fpizlo@apple.com>
2464
2465         Skip slow lock tests on Windows/debug
2466         https://bugs.webkit.org/show_bug.cgi?id=148643
2467
2468         Reviewed by Alexey Proskuryakov.
2469
2470         The lock tests simulate a critical section by doing some floating point math, and then either
2471         make those critical sections very long or invoke them many times. This appears to be
2472         particularly slow on Windows in debug mode, maybe because Visual Studio's debug build makes
2473         that kind of computation slow.
2474
2475         These tests are almost as useful in release as they are in debug, so it's probably better to
2476         just skip the in debug on platforms where this causes timeouts.
2477
2478         * TestWebKitAPI/Tests/WTF/Lock.cpp:
2479         (TestWebKitAPI::runLockTest):
2480         (TestWebKitAPI::skipSlow):
2481         (TestWebKitAPI::TEST):
2482
2483 2015-08-29  Chris Fleizach  <cfleizach@apple.com>
2484
2485         AX: When navigating the elements of a scrollable element with VoiceOver, the scrollTop() position of the element does not permanently change
2486         https://bugs.webkit.org/show_bug.cgi?id=125720
2487
2488         Reviewed by Daniel Bates.
2489
2490         Add support for scrollToMakeVisibleWithSubFocus and scrollToGlobalPoint.
2491
2492         * DumpRenderTree/AccessibilityUIElement.cpp:
2493         (pressCallback):
2494         (scrollToMakeVisibleWithSubFocusCallback):
2495         (scrollToGlobalPointCallback):
2496         (scrollToMakeVisibleCallback):
2497         (AccessibilityUIElement::getJSClass):
2498         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2499         (AccessibilityUIElement::scrollToMakeVisible):
2500         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
2501         (AccessibilityUIElement::scrollToGlobalPoint):
2502         (AccessibilityUIElement::selectedTextRange):
2503         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2504         (AccessibilityUIElement::AccessibilityUIElement):
2505         (AccessibilityUIElement::mathPrescriptsDescription):
2506         (AccessibilityUIElement::scrollToMakeVisible):
2507         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
2508         (AccessibilityUIElement::scrollToGlobalPoint):
2509         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2510         (WTR::AccessibilityUIElement::isTextMarkerValid):
2511         (WTR::AccessibilityUIElement::textMarkerForIndex):
2512         (WTR::AccessibilityUIElement::scrollToMakeVisible):
2513         (WTR::AccessibilityUIElement::scrollToGlobalPoint):
2514         (WTR::AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
2515         (WTR::AccessibilityUIElement::supportedActions):
2516         (WTR::AccessibilityUIElement::mathPostscriptsDescription):
2517         (WTR::AccessibilityUIElement::mathPrescriptsDescription):
2518         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2519         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2520         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2521         (WTR::AccessibilityUIElement::scrollToMakeVisible):
2522         (WTR::AccessibilityUIElement::scrollToGlobalPoint):
2523         (WTR::AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
2524         (WTR::AccessibilityUIElement::selectedTextRange):
2525         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2526         (WTR::AccessibilityUIElement::scrollToMakeVisible):
2527         (WTR::AccessibilityUIElement::scrollToGlobalPoint):
2528         (WTR::AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
2529         (WTR::AccessibilityUIElement::selectedTextRange):
2530
2531 2015-08-28  Timothy Horton  <timothy_horton@apple.com>
2532
2533         Add a mysteriously nonproblematic missing comma.
2534
2535         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2536         (TestExpectationParser._collect_matching_tests):
2537         (TestExpectationParser):
2538
2539 2015-08-28  Timothy Horton  <timothy_horton@apple.com>
2540
2541         Remove an old temporary script that has served its purpose
2542
2543         * Scripts/convert-test-expectations: Removed.
2544
2545 2015-08-28  Jer Noble  <jer.noble@apple.com>
2546
2547         [iOS] Add WebKit/WebKit2 settings to control automatic data loading
2548         https://bugs.webkit.org/show_bug.cgi?id=148579
2549
2550         Reviewed by Anders Carlsson.
2551
2552         In DumpRenderTree, set the new mediaDataLoadsAutomatically preference to YES.
2553
2554         In WebKitTestRunner, do the same for the new _mediaDataLoadsAutomatically configuration property,
2555         and also set the existing requiresUserActionForMediaPlayback configuration property to NO.
2556
2557         * DumpRenderTree/mac/DumpRenderTree.mm:
2558         (resetWebPreferencesToConsistentValues):
2559         (resetWebViewToConsistentStateBeforeTesting):
2560         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2561         (WTR::initializeWebViewConfiguration):
2562
2563 2015-08-28  Alexey Proskuryakov  <ap@apple.com>
2564
2565         Fix run-webkit-tests --additional-env-var="DYLD_INSERT_LIBRARIES=..."
2566         https://bugs.webkit.org/show_bug.cgi?id=148592
2567
2568         Reviewed by Tim Horton.
2569
2570         * Scripts/webkitpy/port/base.py:
2571         (Port.to.setup_environ_for_server):
2572         (Port.to):
2573         (Port.to._append_value_colon_separated):
2574         (Port.to.show_results_html_file):
2575         * Scripts/webkitpy/port/ios.py:
2576         (IOSSimulatorPort.setup_environ_for_server):
2577         * Scripts/webkitpy/port/mac.py:
2578         (MacPort.setup_environ_for_server):
2579
2580 2015-08-28  Filip Pizlo  <fpizlo@apple.com>
2581
2582         LICM should be sound even if the CFG has changed
2583         https://bugs.webkit.org/show_bug.cgi?id=148259
2584
2585         Reviewed by Benjamin Poulain.
2586
2587         Add a utility for creating tests that set some uncommon option.
2588
2589         * Scripts/run-jsc-stress-tests:
2590
2591 2015-08-28  Brent Fulgham  <bfulgham@apple.com>
2592
2593         [Win] Unreviewed EWS correction.
2594
2595         * EWSTools/start-queue-win.sh: Update settings to point to VS2015.
2596
2597 2015-08-28  Jer Noble  <jer.noble@apple.com>
2598
2599         [iOS] Make the AllowsInlineMediaPlayback preference work in WebKit / WebKit2.
2600         https://bugs.webkit.org/show_bug.cgi?id=147512
2601
2602         Reviewed by Anders Carlsson.
2603
2604         Set the value of WebKitAllowsInlineMediaPlayback / WKPreferencesSetMediaPlaybackAllowsInline()
2605         to a consistent (true) value.
2606
2607         * DumpRenderTree/mac/DumpRenderTree.mm:
2608         (setDefaultsToConsistentValuesForTesting):
2609         * WebKitTestRunner/TestController.cpp:
2610         (WTR::TestController::resetPreferencesToConsistentValues):
2611
2612 2015-08-28  Tim Horton  <timothy_horton@apple.com>
2613
2614         Add navigation gesture callbacks to WKPageNavigationClient
2615         https://bugs.webkit.org/show_bug.cgi?id=148568
2616         <rdar://problem/22371346>
2617
2618         Reviewed by Anders Carlsson.
2619
2620         * WebKitTestRunner/TestController.cpp:
2621         (WTR::TestController::createOtherPage):
2622         (WTR::TestController::createWebViewWithOptions):
2623         Add some zeroes.
2624
2625 2015-08-28  Alexey Proskuryakov  <ap@apple.com>
2626
2627         [Mac] kill-old-processes should kill more processes
2628         https://bugs.webkit.org/show_bug.cgi?id=148577
2629
2630         Reviewed by Tim Horton.
2631
2632         * BuildSlaveSupport/kill-old-processes:
2633
2634 2015-08-28  Jason Marcell  <jmarcell@apple.com>
2635
2636         The status message for combined builder queues should say "all builds succeeded" if everything
2637         built correctly.
2638         https://bugs.webkit.org/show_bug.cgi?id=148535
2639
2640         Reviewed by David Kilzer and Alexey Proskuryakov.
2641
2642         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
2643         (BuildbotCombinedQueueView.prototype.update): Make status message for combined builder queues
2644         say "all builds succeeded" if everything built correctly.
2645
2646 2015-08-28  Carlos Garcia Campos  <cgarcia@igalia.com>
2647
2648         [GTK] Simplify the internal API to create a WebView
2649         https://bugs.webkit.org/show_bug.cgi?id=148570
2650
2651         Reviewed by Žan Doberšek.
2652
2653         * TestWebKitAPI/PlatformWebView.h: Add initialize method for GTK+ too.
2654         * TestWebKitAPI/gtk/PlatformWebViewGtk.cpp:
2655         (TestWebKitAPI::PlatformWebView::PlatformWebView): Implement all
2656         PlatformWebView constructors that end up calling initialize with a PageConfiguration.
2657         (TestWebKitAPI::PlatformWebView::initialize): Create the WebView
2658         passing the received PageConfiguration.
2659         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2660         (WTR::PlatformWebView::PlatformWebView): Create the WebView
2661         passing the received PageConfiguration.
2662
2663 2015-08-27  Aakash Jain  <aakash_jain@apple.com>
2664
2665         iOS Simulator API tests fails as Simulator is not running
2666         https://bugs.webkit.org/show_bug.cgi?id=148501
2667         rdar://problem/22447525
2668
2669         Reviewed by Daniel Bates.
2670
2671         This change is a workaround for <rdar://problem/22388812>.
2672
2673          * Scripts/run-api-tests: Launch the iOS Simulator before starting the API Tests
2674          and quit it on program termination when running tests on the iOS port.
2675          * Scripts/webkitdirs.pm: Store string "For WebKit Development" in constant
2676          SIMULATOR_DEVICE_SUFFIX_FOR_WEBKIT_DEVELOPMENT to make it consistently reusable.
2677
2678 2015-08-27  Alex Christensen  <achristensen@webkit.org>
2679
2680         Make DLLLauncherMain executables dependent on dll
2681         https://bugs.webkit.org/show_bug.cgi?id=148548
2682
2683         Reviewed by Brent Fulgham.
2684
2685         * DumpRenderTree/CMakeLists.txt:
2686         * DumpRenderTree/PlatformWin.cmake:
2687         * MiniBrowser/win/CMakeLists.txt:
2688         * TestWebKitAPI/CMakeLists.txt:
2689         * TestWebKitAPI/PlatformWin.cmake:
2690
2691 2015-08-27  Lucas Forschler  <lforschler@apple.com>
2692
2693         Remove Mac slaves 188/189 after being replaced with 400/401.
2694
2695         Unreviewed.
2696
2697         * BuildSlaveSupport/build.webkit.org-config/config.json:
2698
2699 2015-08-27  Lucas Forschler  <lforschler@apple.com>
2700
2701         Add two bots to the Mac Yosemite queue.
2702         This is to eventually replace bots188/189, which will be removed after 400/401 are vetted.
2703
2704         Unreviewed.
2705
2706         * BuildSlaveSupport/build.webkit.org-config/config.json:
2707
2708 2015-08-27  Alex Christensen  <achristensen@webkit.org>
2709
2710         [Win CMake] Fix incremental build after r188673
2711         https://bugs.webkit.org/show_bug.cgi?id=148539
2712
2713         Reviewed by Brent Fulgham.
2714
2715         * TestWebKitAPI/PlatformWin.cmake:
2716         Copy forwarding headers from WebCore before building in case that was not yet done.
2717         It used to be done when running CMake, but now it's a build step.
2718
2719 2015-08-27  Nan Wang  <n_wang@apple.com>
2720
2721         AX: Fix accessibility/select-element-at-index.html test
2722         https://bugs.webkit.org/show_bug.cgi?id=148516
2723
2724         Reviewed by Chris Fleizach.
2725
2726         Implemented setSelectedChildAtIndex and removeSelectionAtIndex for mac.
2727
2728         * DumpRenderTree/AccessibilityUIElement.cpp:
2729         (setSelectedChildCallback):
2730         (setSelectedChildAtIndexCallback):
2731         (removeSelectionAtIndexCallback):
2732         (elementAtPointCallback):
2733         (sentenceAtOffsetCallback):
2734         (stringForSelectionCallback):
2735         (AccessibilityUIElement::getJSClass):
2736         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2737         (AccessibilityUIElement::setSelectedChild):
2738         (AccessibilityUIElement::setSelectedChildAtIndex):
2739         (AccessibilityUIElement::removeSelectionAtIndex):
2740         (AccessibilityUIElement::accessibilityValue):
2741         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2742         (WTR::AccessibilityUIElement::wordAtOffset):
2743         (WTR::AccessibilityUIElement::lineAtOffset):
2744         (WTR::AccessibilityUIElement::sentenceAtOffset):
2745         (WTR::AccessibilityUIElement::isSelectable):
2746         (WTR::AccessibilityUIElement::isMultiSelectable):
2747         (WTR::AccessibilityUIElement::setSelectedChild):
2748         (WTR::AccessibilityUIElement::setSelectedChildAtIndex):
2749         (WTR::AccessibilityUIElement::removeSelectionAtIndex):
2750         (WTR::AccessibilityUIElement::selectedChildrenCount):
2751         (WTR::AccessibilityUIElement::selectedChildAtIndex):
2752         (WTR::AccessibilityUIElement::isExpanded):
2753         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2754         (WTR::AccessibilityUIElement::setSelectedChild):
2755         (WTR::AccessibilityUIElement::setSelectedChildAtIndex):
2756         (WTR::AccessibilityUIElement::removeSelectionAtIndex):
2757         (WTR::AccessibilityUIElement::accessibilityValue):
2758
2759 2015-08-27  Alex Christensen  <achristensen@webkit.org>
2760
2761         Build fix after r188982
2762
2763         * MiniBrowser/win/CMakeLists.txt:
2764         The directory structure changed in the move.
2765
2766 2015-08-27  Michael Catanzaro  <mcatanzaro@igalia.com>
2767
2768         [GTK] Unreviewed, install-dependencies should install geoclue2 on Fedora
2769
2770         geoclue-devel is for obsolete geoclue. Install geoclue2-devel instead.
2771
2772         * gtk/install-dependencies:
2773
2774 2015-08-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2775
2776         Unreviewed. Mark WTF_WordLock.ContendedShortSection as slow too.
2777
2778         * Scripts/run-gtk-tests:
2779         (TestRunner):
2780
2781 2015-08-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2782
2783         Fix GTK+ WTR crashes in initializeMainRunLoop()
2784
2785         Rubber-stamped by Žan Doberšek.
2786
2787         Initialize threading and main thread before
2788         RunLoop::initializeMainRunLoop(), since the GLib implementation of
2789         the RunLoop uses isMainThread() to decide whether to create a new
2790         GMainContext or use the default one. Also use RunLoop::run() and
2791         ::stop() instead of gtk_main/quit.
2792
2793         * WebKitTestRunner/TestController.cpp:
2794         (WTR::TestController::initialize):
2795         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2796         (WTR::TestController::notifyDone):
2797         (WTR::TestController::platformRunUntil):
2798
2799 2015-08-27  Filip Pizlo  <fpizlo@apple.com>
2800
2801         Unreviewed, further shorten a test that times out because it's very long
2802         running.
2803
2804         I've locally run these tests on repeat for 24 hours and found no genuine
2805         failures, like deadlocks. So, the timeouts are probably because the test
2806         machine is slow and debug is slow. We should just run this test for fewer
2807         iterations.
2808
2809         * TestWebKitAPI/Tests/WTF/Lock.cpp:
2810         (TestWebKitAPI::TEST):
2811
2812 2015-08-26  Ryuan Choi  <ryuan.choi@navercorp.com>
2813
2814         Unreviewed build fix attempt on EFL
2815
2816         * WebKitTestRunner/PlatformEfl.cmake:
2817
2818 2015-08-26  Alex Christensen  <achristensen@webkit.org>
2819
2820         Build fix after r188982
2821
2822         * MiniBrowser/win/CMakeLists.txt:
2823         Find .rc files in correct directory.
2824
2825 2015-08-26  Ryuan Choi  <ryuan.choi@navercorp.com>
2826
2827         [EFL] Bump cairo version to 1.14.2
2828         https://bugs.webkit.org/show_bug.cgi?id=148474
2829
2830         Reviewed by Csaba Osztrogonác.
2831
2832         * efl/jhbuild.modules:
2833
2834 2015-08-26  Andy Estes  <aestes@apple.com>
2835
2836         Crash when following a Google search link to Twitter with Limit Adult Content enabled
2837         https://bugs.webkit.org/show_bug.cgi?id=147651
2838
2839         Rubber-stamped by Brady Eidson.
2840
2841         Taught TestRunner how to decide the navigation policy after a delay.
2842
2843         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2844         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2845         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
2846         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2847         (WTR::TestRunner::setShouldDecideNavigationPolicyAfterDelay):
2848         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2849         (WTR::TestRunner::shouldDecideNavigationPolicyAfterDelay):
2850         * WebKitTestRunner/TestController.cpp:
2851         (WTR::TestController::initialize):
2852         (WTR::TestController::resetStateToConsistentValues):
2853         (WTR::TestController::decidePolicyForNavigationAction):
2854         * WebKitTestRunner/TestController.h:
2855         (WTR::TestController::setShouldDecideNavigationPolicyAfterDelay):
2856         * WebKitTestRunner/TestInvocation.cpp:
2857         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2858
2859 2015-08-26  Brent Fulgham  <bfulgham@apple.com>
2860
2861         [Win] Rename 'WinLauncher' to 'MiniBrowser'
2862         https://bugs.webkit.org/show_bug.cgi?id=148485
2863
2864         Reviewed by Alex Christensen
2865
2866         Move the WinLauncher project and source files to a subdirectory
2867         of MiniBrowser. Globally change WinLauncher -> MiniBrowser in the
2868         source code and project files.
2869
2870         * MiniBrowser/MiniBrowser.vcxproj: Copied from WinLauncher/WinLauncher.vcxproj.
2871         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.ico: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.ico.
2872         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.rc: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.rc.
2873         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.vcxproj: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.
2874         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.vcxproj.filters: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.filters.
2875         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCF.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherCF.props.
2876         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCFLite.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherCFLite.props.
2877         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCommon.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherCommon.props.
2878         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserDebug.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherDebug.props.
2879         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc.
2880         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.vcxproj: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.
2881         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.vcxproj.filters: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters.
2882         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibCommon.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props.
2883         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibDebug.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibDebug.props.
2884         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibPostBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibPostBuild.cmd.
2885         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibPreBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd.
2886         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibProduction.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibProduction.props.
2887         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibRelease.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibRelease.props.
2888         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h.
2889         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserPostBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherPostBuild.cmd.
2890         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserPreBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherPreBuild.cmd.
2891         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserProduction.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherProduction.props.
2892         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserRelease.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherRelease.props.
2893         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserResource.h: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherResource.h.
2894         * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.ico: Removed.
2895         * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.rc: Removed.
2896         * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.vcxproj: Removed.
2897         * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.vcxproj.filters: Removed.
2898         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherCF.props: Removed.
2899         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherCFLite.props: Removed.
2900         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherCommon.props: Removed.
2901         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherDebug.props: Removed.
2902         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLib.rc: Removed.
2903         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLib.vcxproj: Removed.
2904         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLib.vcxproj.filters: Removed.
2905         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibCommon.props: Removed.
2906         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibDebug.props: Removed.
2907         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibPostBuild.cmd: Removed.
2908         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibPreBuild.cmd: Removed.
2909         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibProduction.props: Removed.
2910         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibRelease.props: Removed.
2911         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibResource.h: Removed.
2912         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherPostBuild.cmd: Removed.
2913         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherPreBuild.cmd: Removed.
2914         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherProduction.props: Removed.
2915         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherRelease.props: Removed.
2916         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherResource.h: Removed.
2917         * MiniBrowser/win: Copied from WinLauncher.
2918         * MiniBrowser/win/Common.cpp:
2919         * MiniBrowser/win/MiniBrowser.cpp: Copied from WinLauncher/WinLauncher.cpp.
2920         * MiniBrowser/win/MiniBrowser.h: Copied from WinLauncher/WinLauncher.h.
2921         * MiniBrowser/win/MiniBrowserReplace.h: Copied from WinLauncher/WinLauncherReplace.h.
2922         * MiniBrowser/win/MiniBrowserWebHost.cpp: Copied from WinLauncher/WinLauncherWebHost.cpp.
2923         * MiniBrowser/win/MiniBrowserWebHost.h: Copied from WinLauncher/WinLauncherWebHost.h.
2924         * MiniBrowser/win/PageLoadTestClient.cpp:
2925         * MiniBrowser/win/PageLoadTestClient.h:
2926         * MiniBrowser/win/ResourceLoadDelegate.cpp:
2927         * MiniBrowser/win/ResourceLoadDelegate.h:
2928         * MiniBrowser/win/WinLauncher.cpp: Removed.
2929         * MiniBrowser/win/WinLauncher.h: Removed.
2930         * MiniBrowser/win/WinLauncher.vcxproj: Removed.
2931         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.ico: Removed.
2932         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.rc: Removed.
2933         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.vcxproj: Removed.
2934         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.vcxproj.filters: Removed.
2935         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherCF.props: Removed.
2936         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherCFLite.props: Removed.
2937         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherCommon.props: Removed.
2938         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherDebug.props: Removed.
2939         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLib.rc: Removed.
2940         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Removed.
2941         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters: Removed.
2942         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibCommon.props: Removed.
2943         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibDebug.props: Removed.
2944         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibPostBuild.cmd: Removed.
2945         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd: Removed.
2946         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibProduction.props: Removed.
2947         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibRelease.props: Removed.
2948         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibResource.h: Removed.
2949         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherPostBuild.cmd: Removed.
2950         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherPreBuild.cmd: Removed.
2951         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherProduction.props: Removed.
2952         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherRelease.props: Removed.
2953         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherResource.h: Removed.
2954         * MiniBrowser/win/WinLauncher.vcxproj/small.ico: Removed.
2955         * MiniBrowser/win/WinLauncherReplace.h: Removed.
2956         * MiniBrowser/win/WinLauncherWebHost.cpp: Removed.
2957         * MiniBrowser/win/WinLauncherWebHost.h: Removed.
2958         * MiniBrowser/win/WinMain.cpp:
2959         * WinLauncher: Removed.
2960         * WinLauncher/AccessibilityDelegate.cpp: Removed.
2961         * WinLauncher/AccessibilityDelegate.h: Removed.
2962         * WinLauncher/CMakeLists.txt: Removed.
2963         * WinLauncher/Common.cpp: Removed.
2964         * WinLauncher/DOMDefaultImpl.cpp: Removed.
2965         * WinLauncher/DOMDefaultImpl.h: Removed.
2966         * WinLauncher/PageLoadTestClient.cpp: Removed.
2967         * WinLauncher/PageLoadTestClient.h: Removed.
2968         * WinLauncher/PrintWebUIDelegate.cpp: Removed.
2969         * WinLauncher/PrintWebUIDelegate.h: Removed.
2970         * WinLauncher/ResourceLoadDelegate.cpp: Removed.
2971         * WinLauncher/ResourceLoadDelegate.h: Removed.
2972         * WinLauncher/WebDownloadDelegate.cpp: Removed.
2973         * WinLauncher/WebDownloadDelegate.h: Removed.
2974         * WinLauncher/WinLauncher.cpp: Removed.
2975         * WinLauncher/WinLauncher.h: Removed.
2976         * WinLauncher/WinLauncher.vcxproj: Removed.
2977         * WinLauncher/WinLauncher.vcxproj/WinLauncher.ico: Removed.
2978         * WinLauncher/WinLauncher.vcxproj/WinLauncher.rc: Removed.
2979         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Removed.
2980         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.filters: Removed.
2981         * WinLauncher/WinLauncher.vcxproj/WinLauncherCF.props: Removed.
2982         * WinLauncher/WinLauncher.vcxproj/WinLauncherCFLite.props: Removed.
2983         * WinLauncher/WinLauncher.vcxproj/WinLauncherCommon.props: Removed.
2984         * WinLauncher/WinLauncher.vcxproj/WinLauncherDebug.props: Removed.
2985         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Removed.
2986         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Removed.
2987         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters: Removed.
2988         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props: Removed.
2989         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibDebug.props: Removed.
2990         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibPostBuild.cmd: Removed.
2991         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd: Removed.
2992         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibProduction.props: Removed.
2993         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibRelease.props: Removed.
2994         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h: Removed.
2995         * WinLauncher/WinLauncher.vcxproj/WinLauncherPostBuild.cmd: Removed.
2996         * WinLauncher/WinLauncher.vcxproj/WinLauncherPreBuild.cmd: Removed.
2997         * WinLauncher/WinLauncher.vcxproj/WinLauncherProduction.props: Removed.
2998         * WinLauncher/WinLauncher.vcxproj/WinLauncherRelease.props: Removed.
2999         * WinLauncher/WinLauncher.vcxproj/WinLauncherResource.h: Removed.
3000         * WinLauncher/WinLauncher.vcxproj/small.ico: Removed.
3001         * WinLauncher/WinLauncherReplace.h: Removed.
3002         * WinLauncher/WinLauncherWebHost.cpp: Removed.
3003         * WinLauncher/WinLauncherWebHost.h: Removed.
3004         * WinLauncher/WinMain.cpp: Removed.
3005         * WinLauncher/resource.h: Removed.
3006         * WinLauncher/stdafx.cpp: Removed.
3007         * WinLauncher/stdafx.h: Removed.
3008         * win/AssembleBuildLogs/AssembleLogs.cmd:
3009
3010 2015-08-26  Brent Fulgham  <bfulgham@apple.com>
3011
3012         [Win] Simplify menu handling code in WinLauncher
3013         https://bugs.webkit.org/show_bug.cgi?id=148461
3014
3015         Reviewed by Zalan Bujtas.
3016
3017         Revise 'ToggleMenuItem' to return a boolean value indicating if
3018         it handled the message. Revise WndProc to use this to decide if it
3019         should pass the message on to the default handler, rather than
3020         duplicating the logic in both places.
3021
3022         * WinLauncher/Common.cpp:
3023         (ToggleMenuItem): Return true if the menu item message was handled.
3024         (WndProc): If 'ToggleMenuItem' did not handle the message, pass
3025         the message tothe default handler.
3026
3027 2015-08-26  Csaba Osztrogonác  <ossy@webkit.org>
3028
3029         Remove unused code after r188948
3030         https://bugs.webkit.org/show_bug.cgi?id=148467
3031
3032         Reviewed by Gyuyoung Kim.
3033
3034         * WebKitTestRunner/TestController.cpp:
3035         (WTR::TestController::platformPreferences): Deleted.
3036
3037 2015-08-26  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3038
3039         [EFL][GTK] REGRESSION(r188828): All performance tests and almost all layout tests crash
3040         https://bugs.webkit.org/show_bug.cgi?id=148377
3041
3042         Reviewed by Carlos Garcia Campos.
3043
3044         EFL and GTK don't support TestController::platformPreferences() yet which was introduced by r188828.
3045         It caused all crashes of layout test and performance test on EFL and GTK. So this patch implements
3046         TestController::platformPreferences() using WKPageGroupGetPreferences() which was previous thing for
3047         EFL and GTK at the moment.
3048
3049         * WebKitTestRunner/TestController.cpp:
3050         (WTR::TestController::platformWillRunTest):
3051         * WebKitTestRunner/efl/TestControllerEfl.cpp:
3052         (WTR::TestController::platformPreferences):
3053         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
3054         (WTR::TestController::platformPreferences):
3055
3056 2015-08-25  Nan Wang  <n_wang@apple.com>
3057
3058         AX: Enable accessibility/aria-controls.html test for mac
3059         https://bugs.webkit.org/show_bug.cgi?id=148458
3060
3061         Reviewed by Chris Fleizach.
3062
3063         Implemented ariaControlsElementAtIndex(unsigned index).
3064
3065         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3066         (AccessibilityUIElement::ariaControlsElementAtIndex):
3067         (AccessibilityUIElement::disclosedRowAtIndex):
3068         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3069         (WTR::AccessibilityUIElement::ariaControlsElementAtIndex):
3070
3071 2015-08-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3072
3073         Remove python tests for PassRefPtr
3074         https://bugs.webkit.org/show_bug.cgi?id=148463
3075
3076         Reviewed by Andy Estes.
3077
3078         As we're removing uses of PassRefPtr, we need to remove all python tests for PassRefPtr as well.
3079
3080         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3081         (PassPtrTest): Deleted.
3082         (PassPtrTest.assert_pass_ptr_check): Deleted.
3083         (PassPtrTest.test_pass_ref_ptr_in_function): Deleted.
3084         (PassPtrTest.test_pass_other_type_ptr_in_function): Deleted.
3085         (PassPtrTest.test_pass_ref_ptr_return_value): Deleted.
3086         (PassPtrTest.test_ref_ptr_parameter_value): Deleted.
3087         (PassPtrTest.test_ref_ptr_member_variable): Deleted.
3088         (PassPtrTest.test_ref_ptr_member_variable.Foo): Deleted.
3089
3090 2015-08-25  Andy Estes  <aestes@apple.com>
3091
3092         [iOS] run-webkit-tests fails if watchOS SDK is installed
3093         https://bugs.webkit.org/show_bug.cgi?id=148453
3094
3095         Reviewed by David Kilzer.
3096
3097         * Scripts/webkitpy/xcode/simulator.py:
3098         (Simulator): Taught Simulator how to parse watchOS runtimes and devices.
3099         * Scripts/webkitpy/xcode/simulator_unittest.py: Added tests.
3100
3101 2015-08-25  Aakash Jain  <aakash_jain@apple.com>
3102
3103         iOS Simulator layout-tests fail to start while cleaning a directory structure if simulator is already running
3104         https://bugs.webkit.org/show_bug.cgi?id=148197
3105         rdar://problem/22334382
3106
3107         Reviewed by Daniel Bates.
3108
3109         * BuildSlaveSupport/kill-old-processes: Add Simulator to the list of processes to kill (for iOS builders).
3110         * Scripts/webkitpy/port/ios.py:
3111         (IOSSimulatorPort): Converted bundle id com.apple.iphonesimulator to a variable SIMULATOR_BUNDLE_ID.
3112         (IOSSimulatorPort._quitIOSSimulator): Common function to quit iOS Simulator.
3113         (IOSSimulatorPort.clean_up_test_run): Quit the simulator during the cleanup.
3114         (IOSSimulatorPort.check_sys_deps): No need to quit the simulator here as its now being quit in reset_preferences().
3115         (IOSSimulatorPort.reset_preferences): Quit the simulator before trying to delete associated data directory.
3116
3117 2015-08-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3118
3119         Remove PassRefPtr style check rule
3120         https://bugs.webkit.org/show_bug.cgi?id=148432
3121
3122         Reviewed by Andreas Kling.
3123
3124         PassRefPtr is being removed. Thus style rule needs to be removed as well.
3125
3126         * Scripts/webkitpy/style/checkers/cpp.py:
3127         (_check_parameter_name_against_text): Deleted.
3128         (check_function_definition_and_pass_ptr): Deleted.
3129         (check_function_definition): Deleted.
3130         (check_pass_ptr_usage): Deleted.
3131         (process_line): Deleted.
3132         (CppChecker): Deleted.
3133
3134 2015-08-25  Brent Fulgham  <bfulgham@apple.com>
3135
3136         [Win] Expose "Inverted Colors" option in WinLauncher
3137         https://bugs.webkit.org/show_bug.cgi?id=148451
3138
3139         Reviewed by Tim Horton.
3140
3141         Add the ability to toggle the "Inverted Colors" preference
3142         in WinLauncher.
3143
3144         * WinLauncher/Common.cpp:
3145         (ToggleMenuItem): Toggle the feature when the menu item
3146         is selected.
3147         (WndProc): Recognize the new menu option.
3148         * WinLauncher/WinLauncher.cpp:
3149         (WinLauncher::setToDefaultPreferences): Launch with "Invert
3150         Colors" turned off.
3151         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Add menu
3152         entry for "Invert Colors".
3153         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h:
3154
3155 2015-08-25  Nan Wang  <n_wang@apple.com>
3156
3157         [Mac] accessibility/document-attributes.html fails
3158         https://bugs.webkit.org/show_bug.cgi?id=116636
3159
3160         Reviewed by Chris Fleizach.
3161
3162         Implemented documentURI() and documentEncoding().
3163
3164         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3165         (AccessibilityUIElement::documentEncoding):
3166         (AccessibilityUIElement::documentURI):
3167         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3168         (WTR::AccessibilityUIElement::documentEncoding):
3169         (WTR::AccessibilityUIElement::documentURI):
3170
3171 2015-08-24  Brent Fulgham  <bfulgham@apple.com>
3172
3173         [Win] Unreviewed test gardening.
3174
3175         Fix another case where the logging string is constructed using the variable 'frame',
3176         but the method argument is not given a name. This causes the global 'frame' value to
3177         be used, producing incorrect output.
3178
3179         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3180         (FrameLoadDelegate::didReceiveServerRedirectForProvisionalLoadForFrame): Use 'frame'
3181         argument.
3182
3183 2015-08-24  Tim Horton  <timothy_horton@apple.com>
3184
3185         (Finally...) get rid of WKViewIOS
3186         https://bugs.webkit.org/show_bug.cgi?id=148404
3187
3188         Reviewed by Anders Carlsson.
3189
3190         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
3191         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
3192         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
3193         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
3194         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
3195         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
3196         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm:
3197         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
3198         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
3199         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.mm:
3200         Mark tests that use WKBrowsingContextController as Mac-only.
3201
3202         * WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm:
3203         (WTR::AccessibilityController::addNotificationListener):
3204         * WebKitTestRunner/ios/mainIOS.mm:
3205         (-[WebKitTestRunnerApp applicationDidEnterBackground:]):
3206         Import UIKit instead of depending on WKView.h to do so.
3207
3208 2015-08-24  Jason Marcell  <jmarcell@apple.com>
3209
3210         Add support to dashboard for displaying Git SHA's as revisions.
3211         https://bugs.webkit.org/show_bug.cgi?id=148387
3212
3213         Reviewed by Daniel Bates.
3214
3215         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3216         (parseRevisionProperty): Added support to dashboard for displaying Git SHA's as revisions.
3217         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3218         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Ditto.
3219         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js: Added
3220         "isSVN" property to Dashboard.Repository.(OpenSource|Internal).
3221
3222 2015-08-24  Andy Estes  <aestes@apple.com>
3223
3224         REGRESSION (r188851): WebKit2.BundleParameters fails on iOS
3225
3226         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Specify LD_RUNPATH_SEARCH_PATHS correctly for iOS.
3227
3228 2015-08-23  Andy Estes  <aestes@apple.com>
3229
3230         Addressed a missed piece of review feedback from r188851.
3231
3232         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
3233
3234 2015-08-23  Andy Estes  <aestes@apple.com>
3235
3236         [Content Filtering] REGRESSION (r182356): Provisional URL is incorrect in didReceiveServerRedirectForProvisionalLoadForFrame when Content Filtering is enabled
3237         https://bugs.webkit.org/show_bug.cgi?id=147872
3238         rdar://problem/22044000
3239
3240         Reviewed by Dan Bernstein.
3241
3242         Added an API test.
3243
3244         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Linked libWebCoreTestSupport in order to use MockContentFilter.
3245         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3246         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm: Added.
3247         (-[ServerRedirectNavigationDelegate webView:didStartProvisionalNavigation:]): Expect the initial request URL.
3248         (-[ServerRedirectNavigationDelegate webView:didReceiveServerRedirectForProvisionalNavigation:]): Expect the redirect URL.
3249         (-[ServerRedirectNavigationDelegate webView:didCommitNavigation:]):
3250         (TEST): Tested that -[WKWebView URL] is updated after a redirect when content filtering is enabled.
3251         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm: Added.
3252         (+[ServerRedirectPlugIn initialize]): Enable MockContentFilter.
3253         * TestWebKitAPI/cocoa/TestProtocol.h: Renamed from Tools/TestWebKitAPI/mac/TestProtocol.h.
3254         * TestWebKitAPI/cocoa/TestProtocol.mm: Renamed from Tools/TestWebKitAPI/mac/TestProtocol.mm.
3255
3256 2015-08-23  Andy Estes  <aestes@apple.com>
3257
3258         Fixed the 32-bit Mac build after r188844.
3259
3260         * TestWebKitAPI/WKWebViewConfigurationExtras.h:
3261         * TestWebKitAPI/WKWebViewConfigurationExtras.mm:
3262
3263 2015-08-22  Andy Estes  <aestes@apple.com>
3264
3265         [Cocoa] API tests using the Modern WebKit API should be able to create web process plug-ins
3266         https://bugs.webkit.org/show_bug.cgi?id=148317
3267
3268         Reviewed by Dan Bernstein.
3269
3270         Added the ability for Modern WebKit API tests to create WKWebProcessPlugIns. A test can create a plug-in by
3271         creating a class that conforms to WKWebProcessPlugIn, adding it to the WebProcessPlugIn target, and using the
3272         WKWebViewConfiguration returned by +[WKWebViewConfiguration testwebkitapi_configurationWithTestPlugInClassName:]
3273         when creating WKWebViews.
3274
3275         Since TestWebKitAPI relies on a bundle parameter to know which test class to instantiate in the plug-in, I also
3276         added a new API test for bundle parameters.
3277
3278         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Added. Named the bundle TestWebKitAPI.wkbundle and
3279         named its executable TestWebKitAPI.bundle.
3280         * TestWebKitAPI/PlatformUtilities.h: Declared TestPlugInClassNameParameter.
3281         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added the WebProcessPlugIn target.
3282         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParameters.mm: Added.
3283         (TEST): Tested bundle parameters by verifying that parameter changes in the UI process are observed in the bundle.
3284         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParametersPlugIn.mm: Added.
3285         (-[BundleParametersPlugIn webProcessPlugIn:didCreateBrowserContextController:]): Started observing changes to a
3286         bundle parameter and asked for an initial notification.
3287         (-[BundleParametersPlugIn dealloc]): Stopped observing changes to a bundle parameter.
3288         (-[BundleParametersPlugIn observeValueForKeyPath:ofObject:change:context:]): When a bundle parameter changes,
3289         mirror its value in the main frame's JSContext.
3290         * TestWebKitAPI/WKWebViewConfigurationExtras.h: Added.
3291         * TestWebKitAPI/WKWebViewConfigurationExtras.mm: Added.
3292         (+[WKWebViewConfiguration testwebkitapi_configurationWithTestPlugInClassName:]): Created a configuration with
3293         TestWebKitAPI's bundle URL and set a bundle parameter indicating the test plug-in's class name.
3294         * TestWebKitAPI/cocoa/PlatformUtilitiesCocoa.mm: Defined TestPlugInClassNameParameter.
3295         * TestWebKitAPI/cocoa/WebProcessPlugIn/Info.plist: Added. Set the principal class to WebProcessPlugIn.
3296         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm: Added.
3297         (-[WebProcessPlugIn webProcessPlugIn:initializeWithObject:]): Forwarded to a newly-created test class instance.
3298         (-[WebProcessPlugIn respondsToSelector:]): Returned YES if the test class instance response.
3299         (-[WebProcessPlugIn forwardingTargetForSelector:]): Forwarded unimplemented methods to the test class instance.
3300
3301 2015-08-23  Csaba Osztrogonác  <ossy@webkit.org>
3302
3303         URTBF after r188828.
3304
3305         * WebKitTestRunner/PlatformWebView.h:
3306
3307 2015-08-23  Alexey Proskuryakov  <ap@apple.com>
3308
3309         build.webkit.org/dashboard: Combined queues don't turn orange on internal failure
3310         https://bugs.webkit.org/show_bug.cgi?id=148356
3311
3312         Reviewed by Darin Adler.
3313
3314         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
3315         (BuildbotCombinedQueueView.prototype.update):
3316
3317 2015-08-23  Alexey Proskuryakov  <ap@apple.com>
3318
3319         build.webkit.org/dashboard: Respect step's hidden flag
3320         https://bugs.webkit.org/show_bug.cgi?id=148357
3321
3322         Reviewed by Darin Adler.
3323
3324         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3325         (BuildbotIteration.prototype._parseData):
3326
3327 2015-08-23  Nan Wang  <n_wang@apple.com>
3328
3329         AX: Fix accessibility/deleting-iframe-destroys-axcache.html test
3330         https://bugs.webkit.org/show_bug.cgi?id=148328
3331
3332         Reviewed by Darin Adler.
3333
3334         We should only expose stringValue() when value attribute is set.
3335
3336         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3337         (AccessibilityUIElement::stringValue):
3338         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3339         (WTR::AccessibilityUIElement::stringValue):
3340
3341 2015-08-23  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3342
3343         Remove style checking rule regarding OwnPtr and PassOwnPtr
3344         https://bugs.webkit.org/show_bug.cgi?id=148360
3345
3346         Reviewed by Darin Adler.
3347
3348         OwnPtr and PassOwnPtr were totally removed though, style rule is still alive.
3349         Removed it.
3350
3351         * Scripts/do-webcore-rename:
3352         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3353         (PassPtrTest.test_pass_own_ptr_in_function): Deleted.
3354         (PassPtrTest.test_pass_ref_ptr_return_value): Deleted.
3355         (PassPtrTest.test_own_ptr_parameter_value): Deleted.
3356         (WebKitStyleTest.test_names): Deleted.
3357
3358 2015-08-22  Timothy Horton  <timothy_horton@apple.com>
3359
3360         WebKitTestRunner should use WKWebView on OS X and iOS
3361         https://bugs.webkit.org/show_bug.cgi?id=143743
3362         <rdar://problem/16947123>
3363
3364         Reviewed by Anders Carlsson.
3365         Patch by Enrica Casucci and myself.
3366
3367         * WebKitTestRunner/PlatformWebView.h:
3368         (WTR::PlatformWebView::windowSnapshotEnabled): Deleted.
3369         Add a PlatformWebView constructor that takes a WKWebViewConfiguration
3370         instead of WKContext and WKPageGroup.
3371
3372         Remove the unused, always-true windowSnapshotEnabled().
3373         While technically some platforms don't have window snapshotting,
3374         they just return null instead of implementing windowSnapshotEnabled().
3375
3376         * WebKitTestRunner/TestController.h:
3377         * WebKitTestRunner/TestController.cpp:
3378         (WTR::TestController::createOtherPage):
3379         (WTR::TestController::initialize):
3380         (WTR::TestController::createWebViewWithOptions):
3381         Delegate to the various platforms for creating PlatformWebView instances,
3382         for creating WKContexts, and for accessing WKPreferences,
3383         so that they can do special things (like, use WKWebView instead!).
3384
3385         (WTR::TestController::resetPreferencesToConsistentValues):
3386         Make explicit WebKitTestRunner's desired default for two preferences
3387         which have differing defaults between the antique and modern API,
3388         for consistency's sake.
3389
3390         (WTR::TestController::resetStateToConsistentValues):
3391         Add platformResetStateToConsistentValues.
3392
3393         * WebKitTestRunner/TestInvocation.cpp:
3394         (WTR::TestInvocation::dumpResults):
3395         Adjust to the aforementioned removal of windowSnapshotEnabled().
3396
3397         * WebKitTestRunner/ios/TestControllerCocoa.mm:
3398         (WTR::TestController::platformResetStateToConsistentValues):
3399         (WTR::TestController::platformPreferences):
3400         (WTR::TestController::platformCreateWebView):
3401         (WTR::TestController::platformCreateOtherPage):
3402         (WTR::TestController::platformInitializeConfiguration):
3403         Implement the new platform functions for the Modern WebKit2 API,
3404         in a new TestControllerCocoa file that is shared between iOS and Mac.
3405
3406         For platformMaybeCreateContext, use the trick that we know we can cast
3407         the WKProcessPool to a WKContextRef to retrieve a WKContextRef from
3408         WKWebView's configuration.
3409
3410         Ditto for WKPreferencesRef and WKPreferences.
3411
3412         Remove user content filters on the WKWebView's userContentController.
3413
3414         * WebKitTestRunner/mac/TestControllerMac.mm:
3415         * WebKitTestRunner/ios/TestControllerIOS.mm:
3416         Move code into TestControllerCocoa.
3417
3418         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3419         (WTR::InjectedBundle::beginTesting):
3420         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3421         (WTR::TestRunner::addUserScript):
3422         (WTR::TestRunner::addUserStyleSheet):
3423         Adopt WKBundlePage API for user scripts/sheets.
3424
3425         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3426         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3427         Make and keep a WKWebView instead of a WKView.
3428
3429         * WebKitTestRunner/mac/EventSenderProxy.mm:
3430         (WTR::EventSenderProxy::mouseUp):
3431         (WTR::EventSenderProxy::mouseMoveTo):
3432         Reach inside the WKWebView to the WKView when dispatching events.
3433         This is fairly ugly and we should come up with a better solution.
3434         Also, fix some flipping and style errors.
3435
3436 2015-08-22  Michael Catanzaro  <mcatanzaro@igalia.com>
3437
3438         Unreviewed, attempt to fix GTK build after r188718
3439
3440         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3441         (WTR::PlatformWebView::PlatformWebView):
3442
3443 2015-08-21  Commit Queue  <commit-queue@webkit.org>
3444
3445         Unreviewed, rolling out r188807, r188813, and r188815.
3446         https://bugs.webkit.org/show_bug.cgi?id=148349
3447
3448         lots of 32-bit build problems, better to resolve separately
3449         and try again (Requested by thorton on #webkit).
3450
3451         Reverted changesets:
3452
3453         "WebKitTestRunner should use WKWebView on OS X and iOS"
3454         https://bugs.webkit.org/show_bug.cgi?id=143743
3455         http://trac.webkit.org/changeset/188807
3456
3457         "Stop building WebKitTestRunner for 32-bit platforms"
3458         https://bugs.webkit.org/show_bug.cgi?id=143743
3459         http://trac.webkit.org/changeset/188813
3460
3461         "Stop building WebKitTestRunner for 32-bit platforms"
3462         https://bugs.webkit.org/show_bug.cgi?id=143743
3463         http://trac.webkit.org/changeset/188815
3464
3465 2015-08-21  Tim Horton  <timothy_horton@apple.com>
3466
3467         Stop building WebKitTestRunner for 32-bit platforms
3468         https://bugs.webkit.org/show_bug.cgi?id=143743
3469         <rdar://problem/16947123>
3470
3471         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3472         This is a restriction on the valid set, not the desired set.
3473
3474 2015-08-21  Jason Marcell  <jmarcell@apple.com>
3475
3476         Make Dashboard.Branches be objects of the form (repository, "branch name") and update existing code
3477         to work with these new objects.
3478         https://bugs.webkit.org/show_bug.cgi?id=148188
3479
3480         Reviewed by Daniel Bates.
3481
3482         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
3483         (Buildbot.prototype._normalizeQueueInfo): Renamed BuildbotQueue.branch to BuildbotQueue.branches.
3484         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
3485         (BuildbotCombinedQueueView): Changed to work with new branch objects which represent a
3486         (repository, "branch name")-pair.
3487         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: Ditto.
3488         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
3489         (BuildbotQueue): Renamed BuildbotQueue.branch to BuildbotQueue.branches.
3490         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3491         (BuildbotQueueView.prototype._appendPendingRevisionCount): Changed to work with new branch
3492         objects which represent a (repository, "branch name")-pair.
3493         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Ditto.
3494         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Ditto.
3495         (BuildbotQueueView.prototype._addDividerToPopover): Ditto.
3496         (BuildbotQueueView.prototype.revisionContentForIteration): Ditto.
3497         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Renamed
3498         BuildbotQueue.branch to BuildbotQueue.branches.
3499         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3500         (WebKitBuildbot.prototype.get defaultBranches): Changed to new (repository, "branch name") format.
3501
3502 2015-08-21  Tim Horton  <timothy_horton@apple.com>
3503
3504         Stop building WebKitTestRunner for 32-bit platforms
3505         https://bugs.webkit.org/show_bug.cgi?id=143743
3506         <rdar://problem/16947123>
3507
3508         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3509         WKWebView is not available on 32-bit OS X.
3510
3511 2015-08-21  Brent Fulgham  <bfulgham@apple.com>
3512
3513         [Win] Unreviewed test correction after r188709.
3514
3515         I removed a function argument that happened to be mirrored by a global
3516         value with the same name. This prevented a compile error, but testing
3517         showed that the wrong value was being used in the function.
3518
3519         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3520         (FrameLoadDelegate::willPerformClientRedirectToURL): Put function argument
3521         back
3522
3523 2015-08-21  Timothy Horton  <timothy_horton@apple.com>
3524
3525         WebKitTestRunner should use WKWebView on OS X and iOS
3526         https://bugs.webkit.org/show_bug.cgi?id=143743
3527         <rdar://problem/16947123>
3528
3529         Reviewed by Anders Carlsson.
3530         Patch by Enrica Casucci and myself.
3531
3532         * WebKitTestRunner/PlatformWebView.h:
3533         (WTR::PlatformWebView::windowSnapshotEnabled): Deleted.
3534         Add a PlatformWebView constructor that takes a WKWebViewConfiguration
3535         instead of WKContext and WKPageGroup.
3536
3537         Remove the unused, always-true windowSnapshotEnabled().
3538         While technically some platforms don't have window snapshotting,
3539         they just return null instead of implementing windowSnapshotEnabled().
3540
3541         * WebKitTestRunner/TestController.h:
3542         * WebKitTestRunner/TestController.cpp:
3543         (WTR::TestController::createOtherPage):
3544         (WTR::TestController::initialize):
3545         (WTR::TestController::createWebViewWithOptions):
3546         Delegate to the various platforms for creating PlatformWebView instances,
3547         for creating WKContexts, and for accessing WKPreferences,
3548         so that they can do special things (like, use WKWebView instead!).
3549
3550         (WTR::TestController::resetPreferencesToConsistentValues):
3551         Make explicit WebKitTestRunner's desired default for two preferences