The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap...
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-03  Chris Dumez  <cdumez@apple.com>
2
3         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
4         https://bugs.webkit.org/show_bug.cgi?id=196588
5         <rdar://problem/49365787>
6
7         Reviewed by Ryosuke Niwa.
8
9         Add API test coverage.
10
11         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
12         (TestWebKitAPI::nullJavaScriptCallback):
13         (TestWebKitAPI::didCrashCheckFrames):
14         (TestWebKitAPI::TEST):
15
16 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
17
18         run-webkit-tests: Upload test results (new results database)
19         https://bugs.webkit.org/show_bug.cgi?id=196577
20         <rdar://problem/34841155>
21
22         Reviewed by Lucas Forschler.
23
24         * Scripts/webkitpy/layout_tests/controllers/manager.py:
25         (Manager.run): Upload results after each device shard, since the configuration will be
26         different for each device.
27         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
28         uploaded to a results database.
29         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
30         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
31
32 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
33
34         -apple-trailing-word is needed for browser detection
35         https://bugs.webkit.org/show_bug.cgi?id=196575
36
37         Unreviewed.
38
39         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
40
41 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
42
43         [CMake][WTF] Mirror XCode header directories
44         https://bugs.webkit.org/show_bug.cgi?id=191662
45
46         Reviewed by Konstantin Tokarev.
47
48         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
49         builds.
50
51         * CMakeLists.txt:
52         * DumpRenderTree/CMakeLists.txt:
53         * DumpRenderTree/PlatformWin.cmake:
54         * MiniBrowser/win/CMakeLists.txt:
55         * TestWebKitAPI/CMakeLists.txt:
56         * TestWebKitAPI/PlatformWin.cmake:
57         * WebKitTestRunner/PlatformGTK.cmake:
58         * WebKitTestRunner/PlatformWin.cmake:
59
60 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
61
62         [ews-app] Status bubble should not display certain infrastructure status messages
63         https://bugs.webkit.org/show_bug.cgi?id=196550
64
65         Reviewed by Lucas Forschler.
66
67         Do not display the steps which are un-needed for end-user. This information is still avaiable
68         if the user click on the bubble and look at the Buildbot build.
69         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
70         (StatusBubble._steps_messages):
71         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
72
73 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
74
75         [ews-build] Use https for sending data to ews-app
76         https://bugs.webkit.org/show_bug.cgi?id=196492
77
78         Reviewed by Lucas Forschler.
79
80         * BuildSlaveSupport/ews-build/events.py:
81
82 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
83
84         Remove support for -apple-trailing-word
85         https://bugs.webkit.org/show_bug.cgi?id=196525
86
87         Reviewed by Zalan Bujtas.
88
89         This CSS property is nonstandard and not used.
90
91         * Scripts/webkitperl/FeatureList.pm:
92         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
93
94 2019-04-03  Youenn Fablet  <youenn@apple.com>
95
96         Add a test for DOMCache on multiple browsing in case of private browsing
97         https://bugs.webkit.org/show_bug.cgi?id=196524
98
99         Reviewed by Alex Christensen.
100
101         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
102         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
103
104 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
105
106         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
107         https://bugs.webkit.org/show_bug.cgi?id=196540
108
109         Reviewed by Aakash Jain.
110
111         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
112
113 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
114
115         Add plumbing for a compatibility mode preference in WebKit
116         https://bugs.webkit.org/show_bug.cgi?id=196005
117
118         Reviewed by Tim Horton.
119
120         Add new API tests.
121
122         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
123         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
124
125 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
126
127         [WPE][GTK] Update libsrtp dependency package for Debian
128         https://bugs.webkit.org/show_bug.cgi?id=196528
129
130         Reviewed by Frédéric Wang.
131
132         * gtk/install-dependencies:
133         * wpe/install-dependencies:
134
135 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
136
137         [WK2] Add support for Window's beforeprint / afterprint events
138         https://bugs.webkit.org/show_bug.cgi?id=196478
139         <rdar://problem/49535124>
140
141         Unreviewed build fix for MSVC.
142
143         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
144
145         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
146
147         * WebKitTestRunner/TestController.cpp:
148         (WTR::printFrame): Use int and float literals.
149
150 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
151
152         [ews-build] Reassign bots to queues
153
154         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
155
156 2019-04-02  Chris Dumez  <cdumez@apple.com>
157
158         [WK2] Add support for Window's beforeprint / afterprint events
159         https://bugs.webkit.org/show_bug.cgi?id=196478
160
161         Reviewed by Alex Christensen.
162
163         Add minimal implementation for printFrame in WebKitTestRunner.
164
165         * WebKitTestRunner/TestController.cpp:
166         (WTR::printFrame):
167         (WTR::TestController::createOtherPage):
168         (WTR::TestController::createWebViewWithOptions):
169
170 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
171
172         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
173         https://bugs.webkit.org/show_bug.cgi?id=196491
174
175         Reviewed by Lucas Forschler.
176
177         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
178
179 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
180
181         [ews-build] Configure buildbot try credentials in environment variables
182         https://bugs.webkit.org/show_bug.cgi?id=196501
183
184         Reviewed by Lucas Forschler.
185
186         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
187         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
188         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
189
190 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
191
192         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
193         https://bugs.webkit.org/show_bug.cgi?id=196496
194         <rdar://problem/49521634>
195
196         Reviewed by Chris Dumez.
197
198         Add new API tests (see WebKit ChangeLog for more detail).
199
200         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
201         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
202         (TEST):
203
204 2019-04-02  David Kilzer  <ddkilzer@apple.com>
205
206         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
207         <https://webkit.org/b/196499>
208
209         Reviewed by Alexey Proskuryakov.
210
211         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
212         ENABLE_ADDRESS_SANITIZER.
213
214 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
215
216         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
217         https://bugs.webkit.org/show_bug.cgi?id=182757
218
219         Reviewed by Don Olmstead.
220
221         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
222         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
223
224 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
225
226         run-api-tests: Upload test results
227         https://bugs.webkit.org/show_bug.cgi?id=196323
228         <rdar://problem/49356714>
229
230         Reviewed by Lucas Forschler.
231
232         * Scripts/webkitpy/api_tests/manager.py:
233         (Manager):
234         (Manager.run): Upload results to a results database.
235         * Scripts/webkitpy/api_tests/run_api_tests.py:
236         (parse_args): Add upload arguments.
237         * Scripts/webkitpy/port/base.py:
238         (Port):
239         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
240         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
241         with commits from any other associated repositories.
242         * Scripts/webkitpy/port/device.py:
243         (Device):
244         (Device.build_version): Access build_versoin of underlying platform device.
245         * Scripts/webkitpy/port/ios_simulator_unittest.py:
246         (IOSSimulatorTest):
247         (IOSSimulatorTest.test_configuration_for_upload):
248         * Scripts/webkitpy/port/device_port.py:
249         (DevicePort):
250         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
251         the same as the machine uploading results.
252         * Scripts/webkitpy/port/mac.py:
253         (MacPort):
254         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
255         * Scripts/webkitpy/port/mac_unittest.py:
256         (MacTest):
257         (MacTest.test_configuration_for_upload):
258         * Scripts/webkitpy/xcode/simulated_device.py:
259         (SimulatedDeviceManager._create_device_with_runtime):
260         (SimulatedDevice.__init__): Create simulated device with a build_version.
261         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
262         (test_existing_simulator):
263
264 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
265
266         Remove extra newline characters (Follow-up fix to r243707)
267
268         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
269
270 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
271
272         [ews-app] Use API_KEY to accept results data
273         https://bugs.webkit.org/show_bug.cgi?id=196461
274
275         Reviewed by Dewei Zhu.
276
277         * BuildSlaveSupport/ews-app/ews/views/results.py:
278         (Results.post): Validate EWS_API_KEY before accepting any data.
279         * BuildSlaveSupport/ews-build/events.py:
280         (Events.sendData): Send EWS_API_KEY if available along with event data.
281
282 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
283
284         Unable to copy and paste a PDF from Notes into Mail compose body
285         https://bugs.webkit.org/show_bug.cgi?id=196442
286         <rdar://problem/48573098>
287
288         Reviewed by Tim Horton.
289
290         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
291         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
292         to be specified on the item providers.
293
294         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
295         (TestWebKitAPI::mapItemForTesting):
296         (TestWebKitAPI::contactItemForTesting):
297
298 2019-04-01  Tim Horton  <timothy_horton@apple.com>
299
300         Make UIWKDocumentContext rects per-character instead of per-word
301         https://bugs.webkit.org/show_bug.cgi?id=196459
302
303         Reviewed by Wenson Hsieh.
304
305         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
306         (TEST):
307         Adjust test results due to switching to per-character rects.
308
309 2019-04-01  Chris Dumez  <cdumez@apple.com>
310
311         UIProcess crash when a prewarmed process is terminated
312         https://bugs.webkit.org/show_bug.cgi?id=196451
313         <rdar://problem/49245471>
314
315         Reviewed by Geoffrey Garen.
316
317         Add API test coverage.
318
319         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
320         (TEST):
321
322 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
323
324         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
325         https://bugs.webkit.org/show_bug.cgi?id=196449
326
327         Reviewed by Lucas Forschler.
328
329         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
330         (StatusBubble.get_os_details): Method to get OS and Xcode details.
331         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
332         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
333
334 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
335
336         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
337         https://bugs.webkit.org/show_bug.cgi?id=196444
338
339         Reviewed by Lucas Forschler.
340
341         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
342
343 2019-04-01  Alex Christensen  <achristensen@webkit.org>
344
345         Add SPI to canonicalize NSURLs with WTF::URL
346         https://bugs.webkit.org/show_bug.cgi?id=196415
347         <rdar://problem/44980271>
348
349         Reviewed by Darin Adler.
350
351         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
352         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
353         (TestWebKitAPI::TEST):
354
355 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
356
357         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
358         https://bugs.webkit.org/show_bug.cgi?id=196441
359
360         Reviewed by Carlos Garcia Campos.
361
362         Don't cache the wpe_view_backend object that might not exist yet at the
363         time of EventSenderProxy constructor invocation, but instead retrieve
364         that object whenever it's required for event dispatching. This should
365         avoid crashes in this constructor now that it's invoked before any
366         PlatformWindow has been set up (as changed in r243496).
367
368         * WebKitTestRunner/EventSenderProxy.h:
369         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
370         (WTR::viewBackend):
371         (WTR::EventSenderProxy::EventSenderProxy):
372         (WTR::EventSenderProxy::mouseDown):
373         (WTR::EventSenderProxy::mouseUp):
374         (WTR::EventSenderProxy::mouseMoveTo):
375         (WTR::EventSenderProxy::mouseScrollBy):
376         (WTR::EventSenderProxy::keyDown):
377         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
378
379 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
380
381         [Win][WebKit] MiniBrowser should support high DPI display
382         https://bugs.webkit.org/show_bug.cgi?id=196391
383
384         Reviewed by Alex Christensen.
385
386         * MiniBrowser/win/WebKitBrowserWindow.cpp:
387         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
388         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
389         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
390
391 2019-03-31  Sam Weinig  <weinig@apple.com>
392
393         Remove more i386 specific configurations
394         https://bugs.webkit.org/show_bug.cgi?id=196430
395
396         Reviewed by Alexey Proskuryakov.
397
398         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
399         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
400
401 2019-03-31  Andy Estes  <aestes@apple.com>
402
403         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
404         https://bugs.webkit.org/show_bug.cgi?id=196433
405         <rdar://problem/49293305>
406
407         Reviewed by Tim Horton.
408
409         Enhanced API test coverage to include all navigation response policy decisions in both
410         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
411
412         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
413         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
414         (TestWebKitAPI::TEST):
415         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
416         (readFile):
417         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
418         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
419         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
420         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
421         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
422         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
423         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
424         (-[QuickLookDelegate _downloadDidStart:]):
425         (-[QuickLookDelegate _download:didReceiveResponse:]):
426         (-[QuickLookDelegate _download:didReceiveData:]):
427         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
428         (-[QuickLookDelegate _downloadDidFinish:]):
429         (-[QuickLookDelegate _download:didFailWithError:]):
430         (-[QuickLookDelegate _downloadDidCancel:]):
431         (-[QuickLookDelegate verifyDownload]):
432         (runTest):
433         (runTestDecideBeforeLoading):
434         (runTestDecideAfterLoading):
435         (TEST):
436         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
437         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
438         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
439         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
440         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
441         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
442         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
443         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
444         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
445         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
446         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
447         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
448         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
449         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
450
451 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
452
453         [CMake] add testdfg as target with build-jsc
454         https://bugs.webkit.org/show_bug.cgi?id=196393
455
456         Reviewed by Saam Barati.
457
458         Added testdfg as one of the targets to build when
459         using CMake.
460
461         * Scripts/build-jsc:
462
463 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
464
465         Delete WebMetal implementation in favor of WebGPU
466         https://bugs.webkit.org/show_bug.cgi?id=195418
467
468         Reviewed by Dean Jackson.
469
470         * DumpRenderTree/mac/DumpRenderTree.mm:
471         (enableExperimentalFeatures):
472         (resetWebPreferencesToConsistentValues):
473         * Scripts/webkitperl/FeatureList.pm:
474         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
475         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
476         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
477         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
478         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
479         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
480         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
481         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
482         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
483         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
484         (WTR::InjectedBundle::beginTesting):
485         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
486         (WTR::TestRunner::setWebMetalEnabled): Deleted.
487         * WebKitTestRunner/InjectedBundle/TestRunner.h:
488
489 2019-03-29  Chris Dumez  <cdumez@apple.com>
490
491         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
492         https://bugs.webkit.org/show_bug.cgi?id=196405
493         <rdar://problem/49428130>
494
495         Reviewed by Wenson Hsieh.
496
497         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
498         the popover presentation methods to be no-ops. Use this in the new test added in
499         r243523 so that we do not swizzle those methods for all tests. This is needed because
500         those WatchOS tests rely on the popover getting presented and interactive.
501
502         * WebKitTestRunner/TestController.cpp:
503         (WTR::updateTestOptionsFromTestHeader):
504         * WebKitTestRunner/TestController.h:
505         * WebKitTestRunner/TestOptions.h:
506         (WTR::TestOptions::hasSameInitializationOptions const):
507         * WebKitTestRunner/ios/TestControllerIOS.mm:
508         (WTR::TestController::platformInitialize):
509         (WTR::TestController::platformResetStateToConsistentValues):
510
511 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
512
513         [Curl] Add Server Trust Evaluation Support.
514         https://bugs.webkit.org/show_bug.cgi?id=191646
515
516         Reviewed by Fujii Hironori.
517
518         Implemented MiniBrowser UI for asking if user trusts the server.
519
520         * MiniBrowser/win/Common.cpp:
521         (askServerTrustEvaluation):
522         (replaceString):
523         * MiniBrowser/win/Common.h:
524         * MiniBrowser/win/MiniBrowserLib.rc:
525         * MiniBrowser/win/MiniBrowserLibResource.h:
526         * MiniBrowser/win/WebKitBrowserWindow.cpp:
527         (createPEMString):
528         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
529         (WebKitBrowserWindow::canTrustServerCertificate):
530         * MiniBrowser/win/WebKitBrowserWindow.h:
531
532 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
533
534         Implement ResizeObserver.
535         https://bugs.webkit.org/show_bug.cgi?id=157743
536
537         Reviewed by Simon Fraser.
538
539         Support resizeObserverEnabled webPreferences.
540
541         * DumpRenderTree/TestOptions.cpp:
542         (TestOptions::TestOptions):
543         * DumpRenderTree/TestOptions.h:
544         * DumpRenderTree/mac/DumpRenderTree.mm:
545         (setWebPreferencesForTestOptions):
546         * DumpRenderTree/win/DumpRenderTree.cpp:
547         (enableExperimentalFeatures):
548         * Scripts/webkitperl/FeatureList.pm:
549         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
550
551 2019-03-28  John Wilander  <wilander@apple.com>
552
553         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
554         https://bugs.webkit.org/show_bug.cgi?id=196281
555         <rdar://problem/48938748>
556
557         Reviewed by Alex Christensen.
558
559         This patch adds the function isStatisticsHasLocalStorage() to the
560         TestRunner. With it, the page can query the WebsiteDataStore in the
561         UI process to make sure that it sees LocalStorage.
562
563         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
564         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
565         (WTR::TestRunner::isStatisticsHasLocalStorage):
566         * WebKitTestRunner/InjectedBundle/TestRunner.h:
567         * WebKitTestRunner/TestController.cpp:
568         (WTR::TestController::isStatisticsHasLocalStorage):
569         * WebKitTestRunner/TestController.h:
570         * WebKitTestRunner/TestInvocation.cpp:
571         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
572
573 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
574
575         API::Data::createWithoutCopying should do a null check before calling CFRelease
576         https://bugs.webkit.org/show_bug.cgi?id=196276
577         <rdar://problem/48059859>
578
579         Reviewed by Alex Christensen.
580
581         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
582
583         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
584         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
585         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
586         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
587         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
588         (TestWebKitAPI::TEST):
589
590 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
591
592         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
593         https://bugs.webkit.org/show_bug.cgi?id=186276
594
595         Reviewed by Carlos Garcia Campos.
596
597         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
598         (webViewLoadChanged):
599         (testWebResourceGetDataError):
600         (testWebResourceGetDataEmpty):
601         (beforeAll):
602         (webViewloadChanged): Deleted.
603
604 2019-03-27  Andy Estes  <aestes@apple.com>
605
606         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
607         https://bugs.webkit.org/show_bug.cgi?id=196317
608
609         Reviewed by Dan Bernstein.
610
611         package-root copies built products into a staging directory using ditto(1), which does not
612         follow symbolic links as it traverses a directory. Now that the files in
613         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
614         itself, these become broken links when ditto'd into the staging directory.
615
616         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
617
618         * Scripts/package-root:
619
620 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
621
622         [ews-app] Update display text of Submit for ews analysis
623         https://bugs.webkit.org/show_bug.cgi?id=196309
624
625         Reviewed by Dewei Zhu.
626
627         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
628
629 2019-03-27  David Kilzer  <ddkilzer@apple.com>
630
631         run-webkit-tests should check for leaks in WebKit processes
632         <https://webkit.org/b/193772>
633         <rdar://problem/46526680>
634
635         Reviewed by Ryosuke Niwa.
636
637         This works by doing the following:
638         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
639           The list of child processes are returned one per line:
640           process.name: pid
641         - Run the "#LIST CHILD PROCESSES" command just before the
642           "#CHECK FOR WORLD LEAKS" command, and store the list of child
643           processes on the ServerProcess object.
644         - When the `--leaks` switch is handled, run check_for_leaks() on
645           each child process after the main test harness.
646
647         * DumpRenderTree/mac/DumpRenderTree.mm:
648         (handleControlCommand):
649         - Use strncmp() instead of strcmp().
650         - Add support for handling "#LIST CHILD PROCESSES" command.
651
652         * Scripts/webkitpy/port/base.py:
653         (Port.check_for_leaks):
654         * Scripts/webkitpy/port/darwin.py:
655         (DarwinPort.check_for_leaks):
656         - Rename redundant 'process_pid' argument to 'process_id'.
657
658         * Scripts/webkitpy/port/driver.py:
659         (Driver.do_post_tests_work):
660         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
661           longer the only command this sends to WebKitTestRunner.
662         - If the `--leaks` switch is present, send the
663           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
664           result using Port.set_webkit_processes().
665         (Driver._parse_child_processes_output):
666         - Add helper method to parse list of child process names and
667           process IDs returned from WebKitTestRunner.
668
669         * Scripts/webkitpy/port/ios_device.py:
670         (IOSDevicePort.check_for_leaks):
671         - Rename redundant 'process_pid' argument to 'process_id'.
672
673         * Scripts/webkitpy/port/leakdetector.py:
674         (LeakDetector._parse_leaks_output):
675         - Return early if there is no leaks_output.
676         (LeakDetector.check_for_leaks):
677         - Rename redundant 'process_pid' argument to 'process_id'.
678
679         * Scripts/webkitpy/port/server_process.py:
680         (ServerProcess.__init__):
681         (ServerProcess.child_processes):
682         (ServerProcess.set_child_processes):
683         - Add instance variable to Port to store list of child process
684           names and process IDs returned from WebKitTestRunner.
685         (ServerProcess._start):
686         - Clear self._child_processes.
687         (ServerProcess.stop):
688         - If self._child_processes is set, call
689           self._port.check_for_leaks() for each child process.
690
691         * Scripts/webkitpy/port/server_process_unittest.py:
692         (TrivialMockPort.check_for_leaks):
693         - Rename redundant 'process_pid' argument to 'process_id'.
694
695         * Scripts/webkitpy/port/simulator_process.py:
696         (SimulatorProcess.stop):
697         - If self._child_processes is set, call
698           self._port.check_for_leaks() for each child process.
699
700         * Scripts/webkitpy/port/watch_device.py:
701         (WatchDevicePort.check_for_leaks):
702         - Rename redundant 'process_pid' argument to 'process_id'.
703
704         * WebKitTestRunner/TestController.cpp:
705         (WTR::TestController::dumpResponse):
706         - Extract method from findAndDumpWorldLeaks() so that it may be
707           reused by findAndDumpWebKitProcessIdentifiers().
708         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
709         - Add method to output process name and process ID of both the
710           WebContent and Networking processes.
711         (WTR::TestController::findAndDumpWorldLeaks):
712         - Fix missing newline in output when there were no abandoned
713           documents.
714         - Call dumpResponse() for extracted code.
715         (WTR::TestController::handleControlCommand):
716         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
717         - Use strncmp() instead of strcmp().
718         - Call findAndDumpWebKitProcessIdentifiers() when
719           "#LIST CHILD PROCESSES" command is sent.
720         * WebKitTestRunner/TestController.h:
721         (WTR::TestController::dumpResponse):
722         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
723         - Declare methods.
724
725 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
726
727         Unreviewed. Add GLib API test cases after r243434.
728
729         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
730         (testWebViewActiveURI):
731         (serverCallback):
732         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
733         (sendRequestCallback):
734
735 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
736
737         Geolocation request not complete when watch request was started in a different web process
738         https://bugs.webkit.org/show_bug.cgi?id=195996
739
740         Reviewed by Alex Christensen.
741
742         Add a test case.
743
744         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
745         (TestWebKitAPI::runJavaScriptAlert):
746         (TestWebKitAPI::TEST):
747
748 2019-03-26  Keith Rollin  <krollin@apple.com>
749
750         Update the way generate-xcfilelists returns strings from functions
751         https://bugs.webkit.org/show_bug.cgi?id=195975
752         <rdar://problem/49040807>
753
754         Reviewed by Dean Jackson.
755
756         There are places where generate-xcfilelists executes assignments with
757         statements like:
758
759             FOO=$(some_function)
760
761         where "some_function" return a string by echoing it. E.g.
762
763             some_function()
764             {
765                 echo "Hello, World"
766             }
767
768         This is a common idiom, but it has a problem if "some_function" needs
769         to call "exit" in an attempt to halt the entire script right then and
770         there. Since "some_function" is called inside of $(), it's being
771         executed in a sub-shell. Calling exit in that sub-shell simply exits
772         that shell; it doesn't not exit the outer shell in which the main part
773         of the script is still running. As such, the main script keeps
774         executing when the intent was for the script to halt.
775
776         The solution to this is to use a different idiom for returning
777         strings. The one we now is to pass in the name of the variable to
778         receive the string result:
779
780             some_function()
781             {
782                 variable_name=$1
783                 eval $variable_name ="Hello, World"
784             }
785
786         The call site now looks like
787
788             some_function FOO
789
790         Because there's no invocation of a sub-shell, some_function can now
791         call "exit" if it wants to, and the entire script will exit at that
792         point.
793
794         * Scripts/generate-xcfilelists:
795
796 2019-03-26  Chris Dumez  <cdumez@apple.com>
797
798         Add basic layout test coverage for File Picker on iOS
799         https://bugs.webkit.org/show_bug.cgi?id=196265
800
801         Reviewed by Wenson Hsieh.
802
803         Add layout test infrastructure to test the file picker on iOS.
804
805         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
806         (WTR::UIScriptController::dismissFilePicker):
807         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
808         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
809         (WTR::UIScriptController::dismissFilePicker):
810         * TestRunnerShared/UIScriptContext/UIScriptController.h:
811         * WebKitTestRunner/TestController.cpp:
812         (WTR::TestController::createWebViewWithOptions):
813         (WTR::updateTestOptionsFromTestHeader):
814         * WebKitTestRunner/TestOptions.h:
815         (WTR::TestOptions::hasSameInitializationOptions const):
816         * WebKitTestRunner/ios/TestControllerIOS.mm:
817         (overridePresentViewController):
818         (WTR::TestController::platformInitialize):
819         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
820         (WTR::UIScriptController::dismissFilePicker):
821
822 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
823
824         Implement async paste method on UIWKInteractionViewProtocol
825         https://bugs.webkit.org/show_bug.cgi?id=196267
826         <rdar://problem/49236346>
827
828         Reviewed by Tim Horton.
829
830         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
831         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
832         are now a part of all iOS 12 internal SDKs.
833
834         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
835
836         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
837         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
838
839         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
840         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
841         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
842         * TestWebKitAPI/ios/UIKitSPI.h:
843
844 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
845
846         [ews-build] Use PostgreSQL for ews.webkit.org database
847         https://bugs.webkit.org/show_bug.cgi?id=196270
848
849         Reviewed by Lucas Forschler.
850
851         * BuildSlaveSupport/ews-app/ews-app/settings.py:
852
853 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
854
855         [ews] Reset simctl states on reboot
856         https://bugs.webkit.org/show_bug.cgi?id=196260
857
858         Rubber-stamped by Aakash Jain.
859
860         * EWSTools/start-queue-mac.sh:
861
862 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
863
864         [ews-build] Use PostgreSQL for ews-build database
865         https://bugs.webkit.org/show_bug.cgi?id=196229
866
867         Reviewed by Lucas Forschler.
868
869         * BuildSlaveSupport/ews-build/master.cfg:
870
871 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
872
873         [ews-build] Get master_hostname dynamically in master.cfg
874         https://bugs.webkit.org/show_bug.cgi?id=196255
875
876         Reviewed by Lucas Forschler.
877
878         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
879         send events data in test mode.
880
881 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
882
883         [ews-app] Set db_constraint to False for Foreign Keys
884         https://bugs.webkit.org/show_bug.cgi?id=196252
885
886         Reviewed by Lucas Forschler.
887
888         * BuildSlaveSupport/ews-app/ews/models/build.py:
889         * BuildSlaveSupport/ews-app/ews/models/step.py:
890
891 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
892
893         [ews-build] is_test_mode_enabled should default to True
894         https://bugs.webkit.org/show_bug.cgi?id=196248
895
896         Reviewed by Lucas Forschler.
897
898         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
899
900 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
901
902         [ews-app] Add webkitperl to ENABLED_QUEUES
903         https://bugs.webkit.org/show_bug.cgi?id=196253
904
905         Reviewed by Lucas Forschler.
906
907         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
908
909 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
910
911         Address NSWindow sometimes using WebKitTestRunnerEvent too early
912         https://bugs.webkit.org/show_bug.cgi?id=196211
913         rdar://problem/49110552
914
915         Reviewed by Tim Horton.
916
917         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
918         Make sure that EventSenderProxy always exists when running tests. We used to create
919         it when resetting before the first test, which is a bit too late.
920
921         * WebKitTestRunner/TestController.h:
922         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
923         (WTR::TestController::platformCreateWebView):
924         (WTR::TestController::platformCreateOtherPage):
925         (WTR::TestController::finishCreatingPlatformWebView):
926         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
927         (WTR::PlatformWebView::PlatformWebView):
928         Moved some code that made NSWindow use NSEvent during web view creation. We may
929         need to move more if some other case us found, but this is enough for now.
930
931 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
932
933         Unreviewed. Fix typo in GLib geolocation API after r243285.
934
935         gelocation -> geolocation.
936
937         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
938         (testGeolocationManagerWatchPosition):
939
940 2019-03-25  Alex Christensen  <achristensen@webkit.org>
941
942         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
943         https://bugs.webkit.org/show_bug.cgi?id=196213
944
945         Reviewed by Geoff Garen.
946
947         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
948         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
949         (credentialWithIdentityAndKeychainPath):
950         (-[ChallengeDelegate webView:didFinishNavigation:]):
951         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
952         (TestWebKitAPI::TEST):
953
954 2019-03-25  Alex Christensen  <achristensen@webkit.org>
955
956         Expected shouldn't assume its contained types are copyable
957         https://bugs.webkit.org/show_bug.cgi?id=195986
958
959         Reviewed by JF Bastien.
960
961         * TestWebKitAPI/Tests/WTF/Expected.cpp:
962         (TestWebKitAPI::NonCopyable::operator== const):
963         (TestWebKitAPI::NonCopyable::operator!= const):
964         (TestWebKitAPI::TEST):
965
966 2019-03-25  Tim Horton  <timothy_horton@apple.com>
967
968         Remove some now-unnecessary dynamic class lookup
969         https://bugs.webkit.org/show_bug.cgi?id=196237
970
971         Reviewed by Simon Fraser.
972
973         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
974         (makeRequest):
975         (TEST):
976
977 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
978
979         Unreviewed, rolling out r243450.
980
981         AppleWin and WinCairo port builds get broken.
982
983         Reverted changeset:
984
985         "Add test for fix of #196095"
986         https://bugs.webkit.org/show_bug.cgi?id=196097
987         https://trac.webkit.org/changeset/243450
988
989 2019-03-25  Commit Queue  <commit-queue@webkit.org>
990
991         Unreviewed, rolling out r243465.
992         https://bugs.webkit.org/show_bug.cgi?id=196226
993
994         the test doesn't build (Requested by thorton on #webkit).
995
996         Reverted changeset:
997
998         "Do not terminate the NetworkProcess if a third party
999         application sends a NSCredential with a SecIdentityRef"
1000         https://bugs.webkit.org/show_bug.cgi?id=196213
1001         https://trac.webkit.org/changeset/243465
1002
1003 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1004
1005         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1006         https://bugs.webkit.org/show_bug.cgi?id=196213
1007
1008         Reviewed by Geoff Garen.
1009
1010         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1011         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1012         (credentialWithIdentityAndKeychainPath):
1013         (-[ChallengeDelegate webView:didFinishNavigation:]):
1014         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1015         (TestWebKitAPI::TEST):
1016
1017 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1018
1019         [ews-build] Gracefully handle missing patch_id in events
1020         https://bugs.webkit.org/show_bug.cgi?id=196216
1021
1022         Reviewed by Lucas Forschler.
1023
1024         * BuildSlaveSupport/ews-build/events.py:
1025
1026 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1027
1028         [ews-build] use lz4 compression for improving buildbot performance
1029         https://bugs.webkit.org/show_bug.cgi?id=196155
1030
1031         Reviewed by Lucas Forschler.
1032
1033         * BuildSlaveSupport/ews-build/master.cfg:
1034
1035 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1036
1037         Pull some API testing helper methods out of TestWKWebView
1038         https://bugs.webkit.org/show_bug.cgi?id=196212
1039
1040         Reviewed by Tim Horton.
1041
1042         Refactor some more API testing utility methods, so that they can be used in
1043         tests that do not use TestWKWebView.
1044
1045         * TestWebKitAPI/cocoa/TestWKWebView.h:
1046         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1047         (-[WKWebView loadTestPageNamed:]):
1048         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
1049         (-[WKWebView synchronouslyLoadHTMLString:]):
1050         (-[WKWebView synchronouslyLoadTestPageNamed:]):
1051         (-[TestWKWebView loadTestPageNamed:]): Deleted.
1052         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
1053         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
1054         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
1055
1056 2019-03-25  Jer Noble  <jer.noble@apple.com>
1057
1058         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
1059         https://bugs.webkit.org/show_bug.cgi?id=196097
1060
1061         Reviewed by Eric Carlson.
1062
1063         Drive-by bug fix: allow tests to play audio without a user gesture by default.
1064
1065         * DumpRenderTree/mac/DumpRenderTree.mm:
1066         (resetWebPreferencesToConsistentValues):
1067         * WebKitTestRunner/TestController.cpp:
1068         (WTR::TestController::resetPreferencesToConsistentValues):
1069
1070 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1071
1072         Pull IPadUserInterfaceSwizzler out into a separate header file
1073         https://bugs.webkit.org/show_bug.cgi?id=196193
1074
1075         Reviewed by Anders Carlsson.
1076
1077         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
1078         be used in other API tests.
1079
1080         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1081         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
1082         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
1083         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
1084         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
1085         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
1086         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
1087
1088 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1089
1090         Remove NavigatorContentUtils in WebCore/Modules
1091         https://bugs.webkit.org/show_bug.cgi?id=196070
1092
1093         Reviewed by Alex Christensen.
1094
1095         NavigatorContentUtils was to support the custom scheme spec [1].
1096         However, in WebKit side, no port has supported the feature in
1097         WebKit layer after EFL port was removed. So there has been the
1098         only IDL implementation of the NavigatorContentUtils in WebCore.
1099         So we don't need to keep the implementation in WebCore anymore.
1100
1101         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
1102
1103         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1104
1105 2019-03-24  Andy Estes  <aestes@apple.com>
1106
1107         [watchOS] Remove unused Proximity Networking code
1108         https://bugs.webkit.org/show_bug.cgi?id=196188
1109
1110         Reviewed by Tim Horton.
1111
1112         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1113         (TEST):
1114
1115 2019-03-23  Keith Miller  <keith_miller@apple.com>
1116
1117         Refactor clz/ctz and fix getLSBSet.
1118         https://bugs.webkit.org/show_bug.cgi?id=196162
1119
1120         Reviewed by Saam Barati.
1121
1122         Add tests for clz, ctz, getLSBSet, and getMSBSet.
1123
1124         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1125         (TestWebKitAPI::TEST):
1126
1127 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1128
1129         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
1130         https://bugs.webkit.org/show_bug.cgi?id=196143
1131
1132         Reviewed by Michael Catanzaro.
1133
1134         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
1135         directories.
1136
1137         * Scripts/webkitpy/style/checkers/cpp.py:
1138         (check_identifier_name_in_declaration):
1139         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1140         (WebKitStyleTest.test_names):
1141
1142 2019-03-22  Philippe Normand  <pnormand@igalia.com>
1143
1144         [Flatpak] Manifest expanding fails for qt WPE extension
1145         https://bugs.webkit.org/show_bug.cgi?id=196148
1146
1147         Reviewed by Alex Christensen.
1148
1149         * flatpak/flatpakutils.py:
1150         (expand_submodules_recurse): The last recurse manifest expand
1151         iteration might lead to a single module so take it into account
1152         and don't try to recurse further.
1153
1154 2019-03-22  Chris Dumez  <cdumez@apple.com>
1155
1156         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
1157         https://bugs.webkit.org/show_bug.cgi?id=195348
1158         <rdar://problem/48622090>
1159
1160         Reviewed by Alex Christensen.
1161
1162         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
1163         to NO when test.options().shouldIgnoreMetaViewport is false.
1164
1165         * WebKitTestRunner/ios/TestControllerIOS.mm:
1166         (WTR::TestController::platformConfigureViewForTest):
1167
1168 2019-03-22  Chris Dumez  <cdumez@apple.com>
1169
1170         Prewarmed processes should be usable with any website data store
1171         https://bugs.webkit.org/show_bug.cgi?id=196104
1172
1173         Reviewed by Alex Christensen.
1174
1175         Add API test coverage.
1176
1177         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1178         (runInitialWarmedProcessUsedTest):
1179         (TEST):
1180
1181 2019-03-22  David Kilzer  <ddkilzer@apple.com>
1182
1183         Back out local changes to Alex's Subversion working directory
1184
1185         They were accidentally committed.
1186
1187         * Scripts/webkitpy/common/system/abstractexecutive.py:
1188         (AbstractExecutive.wait_newest):
1189         * Scripts/webkitpy/common/system/executive.py:
1190         (Executive.running_pids):
1191         * Scripts/webkitpy/common/system/executive_mock.py:
1192         (MockExecutive.running_pids):
1193         * Scripts/webkitpy/common/system/executive_unittest.py:
1194         (ExecutiveTest.serial_test_running_pids):
1195         * Scripts/webkitpy/port/darwin.py:
1196         (DarwinPort.check_for_leaks):
1197         * Scripts/webkitpy/port/leakdetector.py:
1198         (LeakDetector.check_for_leaks):
1199         - This was the hack attached to Bug 193772.
1200
1201         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
1202         (+[WebKitTestRunnerEvent mouseLocation]):
1203         - This works around a crash on an internal build.
1204
1205 2019-03-22  Tim Horton  <timothy_horton@apple.com>
1206
1207         Fix the build after r243354
1208         https://bugs.webkit.org/show_bug.cgi?id=196138
1209         <rdar://problem/49145951>
1210
1211         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1212         (TEST):
1213         * TestWebKitAPI/ios/UIKitSPI.h:
1214
1215 2019-03-21  Tim Horton  <timothy_horton@apple.com>
1216
1217         Adopt UIWKDocumentContext
1218         https://bugs.webkit.org/show_bug.cgi?id=196040
1219         <rdar://problem/48642440>
1220
1221         Reviewed by Ryosuke Niwa.
1222
1223         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1224         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
1225         (makeRequest):
1226         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
1227         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
1228         (applyStyle):
1229         (TEST):
1230         Add tests for UIWKDocumentContext.
1231
1232         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
1233         (TEST):
1234         (recursiveFindWKContentView): Deleted.
1235         * TestWebKitAPI/cocoa/TestWKWebView.h:
1236         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1237         (recursiveFindWKContentView):
1238         (-[TestWKWebView wkContentView]):
1239         * TestWebKitAPI/ios/UIKitSPI.h:
1240         Share the WKContentView finding code between tests.
1241
1242 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
1243
1244         [iOS WK2] Turn on async overflow scrolling by default
1245         https://bugs.webkit.org/show_bug.cgi?id=196011
1246         rdar://problem/48453859
1247
1248         Reviewed by Antti Koivisto.
1249         
1250         Explicitly turn off the async overflow scrolling internal feature for tests by default,
1251         since so many basic layout tests have different results when compositing is triggered for
1252         overflow.
1253         
1254         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
1255
1256         * WebKitTestRunner/TestController.cpp:
1257         (WTR::TestController::resetPreferencesToConsistentValues):
1258
1259 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1260
1261         [ews-build] Retry API test in case of failures
1262         https://bugs.webkit.org/show_bug.cgi?id=196004
1263
1264         Reviewed by Lucas Forschler.
1265
1266         * BuildSlaveSupport/ews-build/steps.py:
1267         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
1268         (CompileWebKitToT.doStepIf): Ditto.
1269         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
1270         (ReRunAPITests): Re-run API tests.
1271         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
1272         (RunAPITestsWithoutPatch): Run API tests without patch.
1273         (RunAPITestsWithoutPatch.doStepIf):
1274         (RunAPITestsWithoutPatch.hideStepIf):
1275         (RunAPITestsWithoutPatch.evaluateCommand):
1276         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
1277         (AnalyzeAPITestsResults.start):
1278         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
1279         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
1280         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
1281         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
1282
1283 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1284
1285         [ews-build] Update queues configurations
1286         https://bugs.webkit.org/show_bug.cgi?id=196074
1287
1288         Reviewed by Dewei Zhu.
1289
1290         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
1291         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
1292
1293 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1294
1295         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
1296         https://bugs.webkit.org/show_bug.cgi?id=195680
1297         <rdar://problem/48903534>
1298
1299         Unreviewed infrastructure fix.
1300
1301         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1302         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
1303
1304 2019-03-21  Andy Estes  <aestes@apple.com>
1305
1306         [iOS] Apple Pay should be available in documents with no user agent scripts
1307         https://bugs.webkit.org/show_bug.cgi?id=196061
1308         <rdar://problem/48649391>
1309
1310         Reviewed by Brady Eidson.
1311
1312         Added API tests and related infrastructure.
1313
1314         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1315         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
1316         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
1317         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
1318         (TestWebKitAPI::TEST):
1319         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
1320         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
1321         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
1322         * TestWebKitAPI/cocoa/TestProtocol.mm:
1323         (-[TestProtocol startLoading]):
1324         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
1325         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
1326         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
1327         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
1328
1329 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
1330
1331         REGRESSSION (r243297): webkitpy tests broken
1332         https://bugs.webkit.org/show_bug.cgi?id=196108
1333
1334         Reviewed by Aakash Jain.
1335
1336         r243297 updated contributors.json, which broke a few unit tests.
1337
1338         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1339         (IRCCommandTest.test_whois):
1340         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
1341
1342 2019-03-21  Chris Dumez  <cdumez@apple.com>
1343
1344         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
1345         https://bugs.webkit.org/show_bug.cgi?id=196041
1346         <rdar://problem/49083230>
1347
1348         Reviewed by Alex Christensen.
1349
1350         Add API test coverage.
1351
1352         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
1353         (TEST):
1354
1355 2019-03-21  Alex Christensen  <achristensen@webkit.org>
1356
1357         Add SPI to inform applications of WKContentRuleList actions
1358         https://bugs.webkit.org/show_bug.cgi?id=195965
1359         <rdar://problem/42664365>
1360
1361         Reviewed by Geoff Garen.
1362
1363         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1364         (TestWebKitAPI::allActionsForResourceLoad):
1365         (TestWebKitAPI::testRequest):
1366         (TestWebKitAPI::TEST_F):
1367         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
1368         (Notification::description):
1369         (Notification::operator== const):
1370         (toVector):
1371         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
1372         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
1373         (makeContentRuleList):
1374         (TEST):
1375         (makeWarnContentRuleList): Deleted.
1376
1377 2019-03-21  Timothy Hatcher  <timothy@apple.com>
1378
1379         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
1380         https://bugs.webkit.org/show_bug.cgi?id=196088
1381
1382         Reviewed by Brian Burg.
1383
1384         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
1385         Support checks when only one platform is specified. Also deprecate macosx() and
1386         force the use of macos() instead.
1387
1388         * Scripts/webkitpy/style/checkers/cpp.py:
1389         (check_min_versions_of_wk_api_available):
1390         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1391         (WebKitStyleTest.test_min_versions_of_wk_api_available):
1392
1393 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
1394
1395         Update status inactive committers' status to 'contributor'.
1396
1397         * Scripts/webkitpy/common/config/contributors.json:
1398
1399 2019-03-21  Xan Lopez  <xan@igalia.com>
1400
1401         [JSC][x86] Drop support for x87 floating point
1402         https://bugs.webkit.org/show_bug.cgi?id=194853
1403
1404         Reviewed by Don Olmstead.
1405
1406         Force SSE2 on x86/32bit builds.
1407
1408         * Scripts/webkitdirs.pm:
1409         (generateBuildSystemFromCMakeProject):
1410
1411 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1412
1413         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
1414         https://bugs.webkit.org/show_bug.cgi?id=196073
1415
1416         Reviewed by Michael Catanzaro.
1417
1418         Add test cases to check functions and constructors with no arguments but receiving user data.
1419
1420         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1421         (checkUserData):
1422         (testJSCFunction):
1423         (fooCreateWithUserData):
1424         (testJSCClass):
1425
1426 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1427
1428         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
1429
1430         Add g_assert_cmpfloat_with_epsilon macro if not defined.
1431
1432         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
1433
1434 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1435
1436         [GTK][WPE] Add API to provide geolocation information
1437         https://bugs.webkit.org/show_bug.cgi?id=195940
1438
1439         Reviewed by Michael Catanzaro.
1440
1441         Add a new test to check the new API.
1442
1443         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
1444         (testGeolocationManagerCurrentPosition):
1445         (testGeolocationManagerWatchPosition):
1446         (beforeAll):
1447         (afterAll):
1448         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
1449         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
1450         (beforeAll): Ditto.
1451         * TestWebKitAPI/glib/CMakeLists.txt:
1452
1453 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1454
1455         [GLib] Returning G_TYPE_OBJECT from a method does not work
1456         https://bugs.webkit.org/show_bug.cgi?id=195574
1457
1458         Reviewed by Michael Catanzaro.
1459
1460         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
1461
1462         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1463         (getGFile):
1464         (getParent):
1465         (createGString):
1466         (getGString):
1467         (getGStringCopyWillRaise):
1468         (getGStringCopy):
1469         (getGStringStr):
1470         (getGStringLen):
1471         (freeGString):
1472         (testJSCClass):
1473
1474 2019-03-20  Saam Barati  <sbarati@apple.com>
1475
1476         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
1477         https://bugs.webkit.org/show_bug.cgi?id=195721
1478
1479         Reviewed by Filip Pizlo.
1480
1481         * Scripts/run-javascriptcore-tests:
1482
1483 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
1484
1485         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
1486         https://bugs.webkit.org/show_bug.cgi?id=196049
1487
1488         Reviewed by Tim Horton.
1489
1490         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
1491         overflow scrolling in general, so rename it.
1492
1493         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1494
1495 2019-03-20  Daniel Bates  <dabates@apple.com>
1496
1497         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
1498         https://bugs.webkit.org/show_bug.cgi?id=196031
1499         <rdar://problem/49078172>
1500
1501         Reviewed by Tim Horton.
1502
1503         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
1504         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
1505         same code path used when the Done button is pressed to dismiss the <select> picker.
1506
1507         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
1508         (TestWebKitAPI::TEST):
1509
1510 2019-03-20  Chris Dumez  <cdumez@apple.com>
1511
1512         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
1513         https://bugs.webkit.org/show_bug.cgi?id=196029
1514         <rdar://problem/48954651>
1515
1516         Reviewed by Tim Horton.
1517
1518         Add API test coverage.
1519
1520         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1521
1522 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
1523
1524         [ews-build] Improve failure summary string for ApplyPatch step
1525         https://bugs.webkit.org/show_bug.cgi?id=195995
1526
1527         Reviewed by Alexey Proskuryakov.
1528
1529         * BuildSlaveSupport/ews-build/steps.py:
1530         (ApplyPatch.getResultSummary): Override getResultSummary.
1531
1532 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
1533
1534         AX: Implement support for new meter ARIA role
1535         https://bugs.webkit.org/show_bug.cgi?id=195966
1536
1537         Reviewed by Chris Fleizach.
1538
1539         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
1540         to AXLevelIndicator.
1541
1542         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1543
1544 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
1545
1546         [WebAuthN] Implement FIDO AppID extension
1547         https://bugs.webkit.org/show_bug.cgi?id=143491
1548         <rdar://problem/48298273>
1549
1550         Reviewed by Brent Fulgham.
1551
1552         Add a test that covers the new flag of convertToU2fSignCommand.
1553
1554         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
1555         (TestWebKitAPI::TEST):
1556         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
1557         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
1558         (TestWebKitAPI::TEST):
1559
1560 2019-03-19  Keith Rollin  <krollin@apple.com>
1561
1562         Add support for more platforms to generate-xcfilelists
1563         https://bugs.webkit.org/show_bug.cgi?id=195977
1564
1565         Reviewed by Alexey Proskuryakov.
1566
1567         generate-xcfilelists incorrectly complains when involved with building
1568         WebKit for iphonesimulator:
1569
1570             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
1571             …
1572             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
1573
1574         Address this by teaching generate-xcfilelists about more platforms.
1575
1576         * Scripts/generate-xcfilelists:
1577
1578 2019-03-19  John Wilander  <wilander@apple.com>
1579
1580         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
1581         https://bugs.webkit.org/show_bug.cgi?id=195923
1582         <rdar://problem/49001272>
1583
1584         Reviewed by Alex Christensen.
1585
1586         This patch does the following to the TestRunner:
1587         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
1588         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
1589         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
1590
1591         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1592         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1593         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
1594         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1595         * WebKitTestRunner/TestController.cpp:
1596         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
1597         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
1598         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
1599         * WebKitTestRunner/TestController.h:
1600         * WebKitTestRunner/TestInvocation.cpp:
1601         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1602
1603 2019-03-19  Christopher Reid  <chris.reid@sony.com>
1604
1605         [CMake] Support more clang and gcc sanitizers
1606         https://bugs.webkit.org/show_bug.cgi?id=195956
1607
1608         Reviewed by Michael Catanzaro.
1609
1610         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
1611
1612 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
1613
1614         [ews-build] Improve summary for PrintConfiguration step
1615         https://bugs.webkit.org/show_bug.cgi?id=195945
1616
1617         Reviewed by Lucas Forschler.
1618
1619         * BuildSlaveSupport/ews-build/steps.py:
1620         (PrintConfiguration.getResultSummary): Override getResultSummary.
1621
1622 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
1623
1624         [ews-build] Improve summary for CheckOutSource step
1625         https://bugs.webkit.org/show_bug.cgi?id=195963
1626
1627         Reviewed by Lucas Forschler.
1628
1629         * BuildSlaveSupport/ews-build/steps.py:
1630         (CheckOutSource.getResultSummary):
1631
1632 2019-03-19  Daniel Bates  <dabates@apple.com>
1633
1634         [iOS] Focus not preserved when switching between tabs
1635         https://bugs.webkit.org/show_bug.cgi?id=195820
1636         <rdar://problem/43614450>
1637
1638         Reviewed by Brent Fulgham.
1639
1640         Add tests to ensure that we restore focus when resigning and becoming first responder.
1641
1642         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1643         (TestWebKitAPI::TEST):
1644
1645 2019-03-19  Alex Christensen  <achristensen@webkit.org>
1646
1647         Make WTFLogChannelState and WTFLogLevel enum classes
1648         https://bugs.webkit.org/show_bug.cgi?id=195904
1649
1650         Reviewed by Eric Carlson.
1651
1652         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
1653         (TestWebKitAPI::TEST_F):
1654
1655 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1656
1657         [GStreamer][EME] Backported mssdemux protection data crash fix
1658         https://bugs.webkit.org/show_bug.cgi?id=195918
1659
1660         Reviewed by Philippe Normand.
1661
1662         * gstreamer/jhbuild.modules:
1663         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
1664
1665 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
1666
1667         Unreviewed, rolling out r243132.
1668
1669         Broke GTK build
1670
1671         Reverted changeset:
1672
1673         "Make WTFLogChannelState and WTFLogLevel enum classes"
1674         https://bugs.webkit.org/show_bug.cgi?id=195904
1675         https://trac.webkit.org/changeset/243132
1676
1677 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
1678
1679         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
1680
1681         * Scripts/webkitdirs.pm:
1682         (builtDylibPathForName): Adjust the shared library name that's changed
1683         with the API version bump in r243073.
1684
1685 2019-03-18  Alex Christensen  <achristensen@webkit.org>
1686
1687         Make WTFLogChannelState and WTFLogLevel enum classes
1688         https://bugs.webkit.org/show_bug.cgi?id=195904
1689
1690         Reviewed by Eric Carlson.
1691
1692         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
1693         (TestWebKitAPI::TEST_F):
1694
1695 2019-03-18  Alex Christensen  <achristensen@webkit.org>
1696
1697         Disable flaky test added in r2431100
1698         https://webkit.org/b/195785
1699
1700         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1701         (TestWebKitAPI::TEST):
1702         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
1703
1704 2019-03-18  Timothy Hatcher  <timothy@apple.com>
1705
1706         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
1707         https://bugs.webkit.org/show_bug.cgi?id=195916
1708
1709         Reviewed by Tim Horton.
1710
1711         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
1712         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
1713
1714 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
1715
1716         Add a secondary e-mail address for Fujii Hironori to make tools happier.
1717
1718         * Scripts/webkitpy/common/config/contributors.json:
1719
1720 2019-03-18  Alex Christensen  <achristensen@webkit.org>
1721
1722         Implement DownloadMonitor to prevent long-running slow downloads from background apps
1723         https://bugs.webkit.org/show_bug.cgi?id=195785
1724
1725         Reviewed by Geoffrey Garen.
1726
1727         * TestWebKitAPI/TCPServer.cpp: Added.
1728         (TestWebKitAPI::TCPServer::TCPServer):
1729         (TestWebKitAPI::TCPServer::~TCPServer):
1730         (TestWebKitAPI::TCPServer::socketBindListen):
1731         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
1732         * TestWebKitAPI/TCPServer.h: Added.
1733         (TestWebKitAPI::TCPServer::port const):
1734         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1735         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1736         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
1737         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
1738         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
1739         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
1740         (TestWebKitAPI::respondSlowly):
1741         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
1742         (TestWebKitAPI::downloadAtRate):
1743         (TestWebKitAPI::TEST):
1744
1745 2019-03-18  Saam Barati  <sbarati@apple.com>
1746
1747         Add a plan file for JetStream 2
1748         https://bugs.webkit.org/show_bug.cgi?id=190734
1749
1750         Reviewed by Mark Lam.
1751
1752         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
1753
1754 2019-03-18  Chris Dumez  <cdumez@apple.com>
1755
1756         Delay WebProcess launch until a load is triggered in a Web view
1757         https://bugs.webkit.org/show_bug.cgi?id=195758
1758         <rdar://problem/48126013>
1759
1760         Reviewed by Geoff Garen.
1761
1762         Add API test coverage. Also update some existing API tests to not expect
1763         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
1764
1765         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
1766         (TestWebKitAPI::TEST):
1767         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
1768         (TestWebKitAPI::TEST):
1769         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1770         (TEST):
1771         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1772         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
1773         (TEST):
1774         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
1775         (TEST):
1776         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
1777
1778 2019-03-18  Xan Lopez  <xan@igalia.com>
1779
1780         [CMake] Prevent potential warning when determining $architecture
1781         https://bugs.webkit.org/show_bug.cgi?id=195891
1782
1783         Reviewed by Michael Catanzaro.
1784
1785         It's possible for generateBuildSystemForCMakeProject to be called
1786         before determineArchitecture() is ever called. This will make the
1787         first eq check with $architecture to be bogus (and print a
1788         warning). Change that to an eq check with architecture(), which
1789         implicitly calls determineArchitecture() if needed, and change all
1790         the other similar cases in the method in the same way to prevent
1791         future bugs like this one.
1792
1793         * Scripts/webkitdirs.pm:
1794         (generateBuildSystemFromCMakeProject):
1795
1796 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
1797
1798         [WPE] Tarballs generated with “make dist” cannot build documentation
1799         https://bugs.webkit.org/show_bug.cgi?id=195885
1800
1801         Reviewed by Carlos Garcia Campos.
1802
1803         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
1804
1805 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
1806
1807         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
1808         https://bugs.webkit.org/show_bug.cgi?id=195883
1809
1810         Reviewed by Carlos Garcia Campos.
1811
1812         * gtkdoc/gtkdoc.py:
1813         (GTKDoc._run_command): When commands fail to run, include the full command line for
1814         the program invocation and the output it has generated on the standard error stream.
1815
1816 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
1817
1818         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
1819         https://bugs.webkit.org/show_bug.cgi?id=195786
1820
1821         Reviewed by Philippe Normand.
1822
1823         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
1824         * wpe/jhbuild.modules: Ditto.
1825
1826 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
1827
1828         [ews-build] Don't run clean builds on EWS builders
1829         https://bugs.webkit.org/show_bug.cgi?id=195851
1830
1831         Reviewed by Geoffrey Garen.
1832
1833         * BuildSlaveSupport/ews-build/factories.py:
1834
1835 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
1836
1837         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
1838         https://bugs.webkit.org/show_bug.cgi?id=195849
1839
1840         Reviewed by Chris Dumez.
1841
1842         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
1843
1844         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1845         (runWebsiteDataStoreCustomPaths):
1846
1847 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
1848
1849         webkitpy: Upload test results
1850         https://bugs.webkit.org/show_bug.cgi?id=195755
1851         <rdar://problem/48896182>
1852
1853         Reviewed by Aakash Jain.
1854
1855         Establish a new format for uploading results that is not tied to layout tests, apply
1856         that format to webkitpy tests.
1857
1858         * Scripts/webkitpy/common/checkout/scm/git.py:
1859         (Git.native_branch): Return what branch the current checkout is on.
1860         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
1861         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1862         * Scripts/webkitpy/common/checkout/scm/svn.py:
1863         (SVN.native_branch): Ditto.
1864         * Scripts/webkitpy/common/system/platforminfo.py:
1865         (PlatformInfo.build_version): Return a build version for Mac.
1866         * Scripts/webkitpy/common/system/platforminfo_mock.py:
1867         (MockPlatformInfo.__init__):
1868         (MockPlatformInfo.build_version):
1869         * Scripts/webkitpy/results: Added.
1870         * Scripts/webkitpy/results/__init__.py: Added.
1871         * Scripts/webkitpy/results/options.py: Added.
1872         (upload_options): OptParse list for upload options.
1873         * Scripts/webkitpy/results/upload.py: Added.
1874         (Upload): Class which enforces the upload format expected by the results server.
1875         (Upload.Expectations):
1876         (Upload.create_configuration):
1877         (Upload.create_commit):
1878         (Upload.create_details):
1879         (Upload.create_run_stats):
1880         (Upload.create_test_result):
1881         (Upload.__init__):
1882         (Upload.Encoder): Encode Upload object as json.
1883         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
1884         * Scripts/webkitpy/results/upload_unittest.py: Added.
1885         * Scripts/webkitpy/test/main.py:
1886         (Tester._parse_args): Add upload arguments.
1887         (Tester._run_tests): Allow results to be uploaded.
1888         * Scripts/webkitpy/test/runner.py:
1889         (Runner.__init__): Record which tests were run, rather than just counting them.
1890         (Runner.handle):
1891         * Scripts/webkitpy/test/runner_unittest.py:
1892         (RunnerTest.test_run):
1893         * Scripts/webkitpy/thirdparty/__init__.py:
1894         (AutoinstallImportHook.find_module): Add requests auto-install.
1895         (AutoinstallImportHook._install_requests):
1896         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1897         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
1898
1899 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
1900
1901         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
1902         https://bugs.webkit.org/show_bug.cgi?id=195810
1903
1904         Reviewed by Tim Horton.
1905
1906         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
1907         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
1908         ending certain layout tests.
1909
1910         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1911         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1912         (-[TestRunnerWKWebView dealloc]):
1913         (-[TestRunnerWKWebView resetInteractionCallbacks]):
1914
1915         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
1916         helper method when destroying the web view, and when resetting state between tests.
1917
1918         * WebKitTestRunner/ios/TestControllerIOS.mm:
1919         (WTR::TestController::platformResetStateToConsistentValues):
1920
1921         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
1922
1923 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
1924
1925         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
1926         https://bugs.webkit.org/show_bug.cgi?id=190350
1927         <rdar://problem/45089503>
1928
1929         Reviewed by Geoffrey Garen.
1930
1931         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1932         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
1933         (TEST):
1934         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
1935         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
1936         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
1937         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
1938         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
1939         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
1940         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
1941         (runTest):
1942         (createDirectories):
1943         (TEST):
1944         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
1945         (TEST):
1946         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
1947         (TEST):
1948
1949 2019-03-15  Timothy Hatcher  <timothy@apple.com>
1950
1951         Add support to WebPage for getting the contents as an attributed string.
1952         https://bugs.webkit.org/show_bug.cgi?id=195636
1953         rdar://problem/45055697
1954
1955         Reviewed by Tim Horton.
1956
1957         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
1958         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
1959
1960 2019-03-15  Chris Dumez  <cdumez@apple.com>
1961
1962         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
1963         https://bugs.webkit.org/show_bug.cgi?id=195747
1964
1965         Reviewed by Geoff Garen.
1966
1967         Add API test coverage.
1968
1969         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1970
1971 2019-03-15  Shawn Roberts  <sroberts@apple.com>
1972
1973         Unreviewed, rolling out r242952.
1974
1975         Causing API failures on iOS Simulator
1976
1977         Reverted changeset:
1978
1979         "[PSON] Make sure the WebProcessCache is leverage when
1980         relaunching a process after termination"
1981         https://bugs.webkit.org/show_bug.cgi?id=195747
1982         https://trac.webkit.org/changeset/242952
1983
1984 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
1985
1986         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
1987         https://bugs.webkit.org/show_bug.cgi?id=195740
1988
1989         Reviewed by Ross Kirsling.
1990
1991         window.open doesn't work for WebKitBrowserWindow because it is not
1992         implemented yet.
1993
1994         1. Implemented createNewPage callback of WKPageUIClient.
1995         2. Changed MainWindow to take a BrowserWindow factory function
1996           instead of BrowserWindowType to be flexible to create
1997           BrowserWindow with extra settings.
1998         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
1999           because it is not relevant with MainWindow anymore.
2000
2001         * MiniBrowser/win/Common.cpp:
2002         (parseCommandLine):
2003         * MiniBrowser/win/Common.h:
2004         (CommandLineOptions::CommandLineOptions):
2005         * MiniBrowser/win/MainWindow.cpp:
2006         (MainWindow::MainWindow):
2007         (MainWindow::create):
2008         (MainWindow::init):
2009         (MainWindow::WndProc):
2010         * MiniBrowser/win/MainWindow.h:
2011         * MiniBrowser/win/PrintWebUIDelegate.cpp:
2012         (PrintWebUIDelegate::createWebViewWithRequest):
2013         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2014         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
2015         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
2016         (WebKitBrowserWindow::updateProxySettings):
2017         (WebKitBrowserWindow::createNewPage):
2018         * MiniBrowser/win/WebKitBrowserWindow.h:
2019         * MiniBrowser/win/WinMain.cpp:
2020         (wWinMain):
2021
2022 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
2023
2024         Make it possible to test scrolling tree layer manipulation more easily
2025         https://bugs.webkit.org/show_bug.cgi?id=195780
2026
2027         Reviewed by Tim Horton.
2028         
2029         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
2030         cuts off communication of scrolling tree scrolls back to the web process
2031         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
2032         allows tests to trigger scrolls which run the scrolling tree layer positioning
2033         logic, but never get another commit from the web process that might mask
2034         scrolling tree bugs.
2035         
2036         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
2037         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
2038         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
2039
2040         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2041         (WTR::UIScriptController::scrollUpdatesDisabled const):
2042         (WTR::UIScriptController::setScrollUpdatesDisabled):
2043         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2044         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2045         (WTR::UIScriptController::scrollUpdatesDisabled const):
2046         (WTR::UIScriptController::setScrollUpdatesDisabled):
2047         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2048         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2049         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2050         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
2051         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
2052         * WebKitTestRunner/ios/TestControllerIOS.mm:
2053         (WTR::TestController::platformResetStateToConsistentValues):
2054         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2055         (WTR::UIScriptController::scrollUpdatesDisabled const):
2056         (WTR::UIScriptController::setScrollUpdatesDisabled):
2057
2058 2019-03-14  Youenn Fablet  <youenn@apple.com>
2059
2060         Move IDB storage in private browsing mode to NetworkProcess
2061         https://bugs.webkit.org/show_bug.cgi?id=195602
2062
2063         Reviewed by Brady Eidson.
2064
2065         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
2066         (TEST):
2067
2068 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2069
2070         [ews-build] Make descriptionDone messages more readable
2071         https://bugs.webkit.org/show_bug.cgi?id=195760
2072
2073         Reviewed by Lucas Forschler.
2074
2075         * BuildSlaveSupport/ews-build/steps.py:
2076         * BuildSlaveSupport/ews-build/steps_unittest.py:
2077
2078 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2079
2080         [ews-build] Generate status-bubble hover-over messages
2081         https://bugs.webkit.org/show_bug.cgi?id=195680
2082
2083         Reviewed by Lucas Forschler.
2084
2085         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2086         (StatusBubble):
2087         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
2088         on hover-over.
2089         (StatusBubble._iso_time):
2090         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
2091         hover-over message.
2092         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
2093
2094 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2095
2096         [ews-app] Gracefully handle the case when state_string is None
2097         https://bugs.webkit.org/show_bug.cgi?id=195753
2098
2099         Reviewed by Lucas Forschler.
2100
2101         * BuildSlaveSupport/ews-app/ews/models/build.py:
2102         * BuildSlaveSupport/ews-app/ews/models/step.py:
2103
2104 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2105
2106         [ews-app] Status bubble display pending for currently running build step
2107         https://bugs.webkit.org/show_bug.cgi?id=195744
2108
2109         Reviewed by Lucas Forschler.
2110
2111         * BuildSlaveSupport/ews-build/events.py:
2112         (Events.stepStarted): If state_string is pending, replace it with step name.
2113
2114 2019-03-14  Chris Dumez  <cdumez@apple.com>
2115
2116         Add WebsitePolicy for the client to specify the device orientation & motion access policy
2117         https://bugs.webkit.org/show_bug.cgi?id=195750
2118
2119         Reviewed by Geoffrey Garen.
2120
2121         Add API test coverage.
2122
2123         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2124         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
2125         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2126         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2127
2128 2019-03-14  Chris Dumez  <cdumez@apple.com>
2129
2130         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2131         https://bugs.webkit.org/show_bug.cgi?id=195747
2132
2133         Reviewed by Geoff Garen.
2134
2135         Add API test coverage.
2136
2137         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2138
2139 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
2140
2141         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
2142         https://bugs.webkit.org/show_bug.cgi?id=195725
2143         <rdar://problem/48545062>
2144
2145         Reviewed by Tim Horton.
2146
2147         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
2148         handler is nil.
2149
2150         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2151         (TestWebKitAPI::TEST):
2152
2153 2019-03-13  Sam Weinig  <sam@webkit.org>
2154
2155         Add utility function to allow easy reverse range-based iteration of a container
2156         https://bugs.webkit.org/show_bug.cgi?id=195542
2157
2158         Reviewed by Antti Koivisto.
2159
2160         * TestWebKitAPI/CMakeLists.txt:
2161         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2162         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
2163         (TestWebKitAPI::TEST):
2164         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
2165
2166 2019-03-13  Chris Dumez  <cdumez@apple.com>
2167
2168         Use a ServiceWorker process per registrable domain
2169         https://bugs.webkit.org/show_bug.cgi?id=195649
2170
2171         Reviewed by Youenn Fablet.
2172
2173         Update API test coverage.
2174
2175         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2176
2177 2019-03-13  Chris Dumez  <cdumez@apple.com>
2178
2179         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
2180         https://bugs.webkit.org/show_bug.cgi?id=195684
2181         <rdar://problem/48294714>
2182
2183         Reviewed by Antti Koivisto.
2184
2185         Add API test coverage.
2186
2187         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2188
2189 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2190
2191         [ews-app] Remove unused patch view
2192         https://bugs.webkit.org/show_bug.cgi?id=195669
2193
2194         Reviewed by Lucas Forschler.
2195
2196         * BuildSlaveSupport/ews-app/ews/urls.py:
2197         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
2198
2199 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2200
2201         [ews-app] Use Buildbot result code variables
2202         https://bugs.webkit.org/show_bug.cgi?id=195668
2203
2204         Reviewed by Alexey Proskuryakov.
2205
2206         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
2207         (Buildbot): Added Buildbot result code variables.
2208         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2209         (StatusBubble._build_bubble): Used Buildbot result code variables.
2210
2211 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
2212
2213         [Flatpak] Expand submodule recursively
2214         https://bugs.webkit.org/show_bug.cgi?id=195672
2215
2216         Building WPE with flatpak was impossible without that as it was raising an exception.
2217         Also update wpebackend-fdo to match what is built in jhbuild
2218
2219         Reviewed by Philippe Normand.
2220
2221         * flatpak/flatpakutils.py:
2222         (expand_submodules_recurse):
2223         (expand_manifest):
2224         * flatpak/org.webkit.WPEModules.yaml:
2225
2226 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2227
2228         [ews-app] status bubble should be hidden for certain builds
2229         https://bugs.webkit.org/show_bug.cgi?id=194597
2230
2231         Reviewed by Dewei Zhu.
2232
2233         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2234         (StatusBubble._build_bubble):
2235         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
2236         because the patch didn't have relevant changes.
2237         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
2238         in production yet.
2239
2240 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
2241
2242         [Win] Fix a slew of simple clang-cl warnings.
2243         https://bugs.webkit.org/show_bug.cgi?id=195652
2244
2245         Reviewed by Don Olmstead.
2246
2247         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2248         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
2249
2250 2019-03-12  Justin Fan  <justin_fan@apple.com>
2251
2252         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
2253         https://bugs.webkit.org/show_bug.cgi?id=195518
2254         <rdar://problem/46322356>
2255
2256         Reviewed by Myles C. Maxfield.
2257
2258         * DumpRenderTree/DerivedSources-input.xcfilelist:
2259         * DumpRenderTree/DerivedSources-output.xcfilelist:
2260
2261 2019-03-12  Commit Queue  <commit-queue@webkit.org>
2262
2263         Unreviewed, rolling out r242825.
2264         https://bugs.webkit.org/show_bug.cgi?id=195648
2265
2266         "Broke webkitpy tests with my change to
2267         lldb_dump_class_layout.py" (Requested by rmorisset on
2268         #webkit).
2269
2270         Reverted changeset:
2271
2272         "Alter Tools/Scripts/dump-class-layout to be able to dump all
2273         classes with suspicious padding"
2274         https://bugs.webkit.org/show_bug.cgi?id=195573
2275         https://trac.webkit.org/changeset/242825
2276
2277 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2278
2279         [ews-build] Show status bubbles while the patch is waiting in queue
2280         https://bugs.webkit.org/show_bug.cgi?id=195618
2281
2282         Reviewed by Lucas Forschler.
2283
2284         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2285         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
2286         enabled in initial deployment.
2287         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
2288         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
2289         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
2290         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
2291         (StatusBubble._build_bubbles_for_patch):
2292
2293 2019-03-12  Robin Morisset  <rmorisset@apple.com>
2294
2295         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
2296         https://bugs.webkit.org/show_bug.cgi?id=195573
2297
2298         Reviewed by Simon Fraser.
2299
2300         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
2301
2302         * Scripts/dump-class-layout:
2303         (main):
2304         * lldb/lldb_dump_class_layout.py:
2305         (ClassLayout.__init__):
2306         (ClassLayout._compute_padding_recursive):
2307         (LLDBDebuggerInstance.dump_layout_for_classname):
2308         (LLDBDebuggerInstance):
2309         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
2310         (LLDBDebuggerInstance.layout_for_classname): Deleted.
2311
2312 2019-03-12  Chris Dumez  <cdumez@apple.com>
2313
2314         Device Orientation access permission should be denied unless explicitly granted by the client
2315         https://bugs.webkit.org/show_bug.cgi?id=195625
2316
2317         Reviewed by Youenn Fablet.
2318
2319         add API test coverage.
2320
2321         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2322         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
2323         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
2324         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
2325         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2326         (runDeviceOrientationTest):
2327         (TEST):
2328         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2329         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2330
2331 2019-03-12  Jer Noble  <jer.noble@apple.com>
2332
2333         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
2334         https://bugs.webkit.org/show_bug.cgi?id=195137
2335         <rdar://problem/48810307>
2336
2337         Reviewed by Eric Carlson.
2338
2339         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
2340         (TestWebKitAPI::TEST):
2341
2342 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2343
2344         [ews-build] Change urls from uat to production
2345         https://bugs.webkit.org/show_bug.cgi?id=195566
2346
2347         Reviewed by Lucas Forschler.
2348
2349         * BuildSlaveSupport/ews-app/ews/config.py:
2350         * BuildSlaveSupport/ews-build/events.py:
2351         * BuildSlaveSupport/ews-build/steps.py:
2352
2353 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2354
2355         [ews-build] change max_builds for local-worker to 1
2356         https://bugs.webkit.org/show_bug.cgi?id=195568
2357
2358         Reviewed by Lucas Forschler.
2359
2360         * BuildSlaveSupport/ews-build/loadConfig.py:
2361
2362 2019-03-12  Tim Horton  <timothy_horton@apple.com>
2363
2364         Fix the build
2365
2366         * TestRunnerShared/spi/PencilKitTestSPI.h:
2367         * TestWebKitAPI/ios/PencilKitTestSPI.h:
2368
2369 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
2370
2371         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
2372         https://bugs.webkit.org/show_bug.cgi?id=194131
2373
2374         Reviewed by Michael Catanzaro.
2375
2376         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
2377         (uriChanged):
2378         (testUnfinishedSubresourceLoad):
2379         (serverCallback):
2380         (beforeAll):
2381
2382 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2383
2384         WTF::Expected should use std::addressof instead of operator&
2385         https://bugs.webkit.org/show_bug.cgi?id=195604
2386
2387         Reviewed by Myles Maxfield.
2388
2389         * TestWebKitAPI/Tests/WTF/Expected.cpp:
2390         (TestWebKitAPI::Unique::Unique):
2391         (TestWebKitAPI::Unique::operator&):
2392         (TestWebKitAPI::TEST):
2393
2394 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
2395
2396         Add Optional to Forward.h.
2397         https://bugs.webkit.org/show_bug.cgi?id=195586
2398
2399         Reviewed by Darin Adler.
2400
2401         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
2402         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
2403         Remove unnecessary includes from headers.
2404
2405 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
2406
2407         Add testing API to hit-test and scroll overflow scrollers
2408         https://bugs.webkit.org/show_bug.cgi?id=195278
2409
2410         Reviewed by Antti Koivisto.
2411         
2412         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
2413         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
2414         
2415         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
2416
2417         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2418         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2419         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2420         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2421         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2422         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2423         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2424         (WTR::enclosingScrollViewIncludingSelf):
2425         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2426
2427 2019-03-11  Tim Horton  <timothy_horton@apple.com>
2428
2429         API test WebKit.RequestTextInputContext fails on iOS
2430         https://bugs.webkit.org/show_bug.cgi?id=195585
2431
2432         Reviewed by Wenson Hsieh and Simon Fraser.
2433
2434         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
2435         (applyStyle):
2436         (TEST):
2437         Add a viewport, so that the coordinates match up on iOS.
2438         Scroll by moving the UIScrollView's contentOffset.
2439
2440 2019-03-11  Chris Dumez  <cdumez@apple.com>
2441
2442         Assert in WebPageProxy::suspendCurrentPageIfPossible()
2443         https://bugs.webkit.org/show_bug.cgi?id=195506
2444         <rdar://problem/48733477>
2445
2446         Reviewed by Alex Christensen.
2447
2448         Add API test coverage.
2449
2450         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2451
2452 2019-03-11  Shawn Roberts  <sroberts@apple.com>
2453
2454         Adding myself to contributors.json
2455
2456         Unreviewed, addming myself to contributors.json .
2457
2458         * Scripts/webkitpy/common/config/contributors.json:
2459
2460 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2461
2462         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
2463         https://bugs.webkit.org/show_bug.cgi?id=195511
2464         <rdar://problem/44873269>
2465
2466         Reviewed by Darin Adler.
2467
2468         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
2469         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
2470         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
2471         (TEST_F):
2472
2473 2019-03-11  Chris Dumez  <cdumez@apple.com>
2474
2475         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
2476         https://bugs.webkit.org/show_bug.cgi?id=195561
2477
2478         Reviewed by Youenn Fablet.
2479
2480         Make sure the JS in the test requests for permission to receive device orientation events.
2481
2482         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2483
2484 2019-03-11  Youenn Fablet  <youenn@apple.com>
2485
2486         Allow storage quota increase by default in WTR
2487         https://bugs.webkit.org/show_bug.cgi?id=195541
2488
2489         Reviewed by Geoffrey Garen.
2490
2491         Allow storage quota increase by default in WTR.
2492         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
2493         Use this for tests that explicitly need cache increase.
2494
2495         Instead of increasing quota by 2, make sure the next request is
2496         granted by adding all given parameters.
2497
2498         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2499         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2500         (WTR::TestRunner::setAllowStorageQuotaIncrease):
2501         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
2502         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2503         * WebKitTestRunner/TestController.cpp:
2504         (WTR::TestController::setAllowStorageQuotaIncrease):
2505         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
2506         * WebKitTestRunner/TestController.h:
2507         * WebKitTestRunner/TestInvocation.cpp:
2508         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2509         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2510         (WTR::TestController::cocoaResetStateToConsistentValues):
2511         (WTR::TestController::setAllowStorageQuotaIncrease):
2512         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
2513         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
2514         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
2515
2516 2019-03-11  Xan Lopez  <xan@igalia.com>
2517
2518         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
2519         https://bugs.webkit.org/show_bug.cgi?id=194147
2520
2521         Reviewed by Michael Saboff.
2522
2523         To make --32-bit work correctly on Linux/64bit we need to:
2524
2525         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
2526         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
2527         unfortunately CMake only allows us to do this during
2528         crosscompilation, which is overkill here.
2529         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
2530         pkg-config detection module uses the x86 .pc files instead of the
2531         x86_64 ones.
2532         - Set the -m32 flags for the compiler.
2533
2534         * Scripts/webkitdirs.pm:
2535         (generateBuildSystemFromCMakeProject):
2536
2537 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
2538
2539         Add MotionMark-1.1 plan file for run-benchmark script.
2540         https://bugs.webkit.org/show_bug.cgi?id=195481
2541
2542         Rubber-stamped by Darin Adler.
2543
2544         Run-benchmark script should support MontionMark-1.1.
2545
2546         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
2547
2548 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2549
2550         [ews-app] Add support for submit-to-ews url
2551         https://bugs.webkit.org/show_bug.cgi?id=195477
2552
2553         Reviewed by Lucas Forschler.
2554
2555         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2556         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
2557         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
2558         * BuildSlaveSupport/ews-app/ews/urls.py:
2559         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
2560
2561 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
2562
2563         Unreviewed, rolling out r242688, r242643, r242624.
2564
2565         Caused multiple layout test failures and crashes on iOS and macOS.
2566
2567         Reverted changeset:
2568
2569         "requestAnimationFrame should execute before the next frame"
2570         https://bugs.webkit.org/show_bug.cgi?id=177484
2571         https://trac.webkit.org/changeset/242624/webkit
2572
2573         * Tracing/SystemTracePoints.plist:
2574
2575 2019-03-11  John Wilander  <wilander@apple.com>
2576
2577         Resource Load Statistics: Make it possible exclude localhost from classification
2578         https://bugs.webkit.org/show_bug.cgi?id=195474
2579         <rdar://problem/47520577>
2580
2581         Reviewed by Brent Fulgham.
2582
2583         This patch allows for localhost to be excluded from classification and
2584         treatment as a prevalent resource.
2585
2586         The WebKit Tools change adds a new function called
2587         testRunner.setStatisticsIsRunningTest() which can be used to control this
2588         behavior.
2589
2590         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2591         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2592         (WTR::TestRunner::setStatisticsIsRunningTest):
2593         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2594         * WebKitTestRunner/TestController.cpp:
2595         (WTR::TestController::setStatisticsIsRunningTest):
2596         * WebKitTestRunner/TestController.h:
2597         * WebKitTestRunner/TestInvocation.cpp:
2598         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2599
2600 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2601
2602         [ews-build] Disable waterfall and console view for ews-build.webkit.org
2603         https://bugs.webkit.org/show_bug.cgi?id=195560
2604
2605         Reviewed by Lucas Forschler.
2606
2607         * BuildSlaveSupport/ews-build/master.cfg:
2608
2609 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2610
2611         Unreviewed, rolling out r242698.
2612
2613         API test crashes on bots.
2614
2615         Reverted changeset:
2616
2617         "Add a WKContentRuleList variant that uses copied memory
2618         instead of mmap'd shared memory for class A containerized
2619         apps"
2620         https://bugs.webkit.org/show_bug.cgi?id=195511
2621         https://trac.webkit.org/changeset/242698
2622
2623 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
2624
2625         [WPE] Enable web process sandbox
2626         https://bugs.webkit.org/show_bug.cgi?id=195169
2627
2628         Reviewed by Daniel Bates.
2629
2630         * wpe/install-dependencies:
2631         * wpe/jhbuild.modules:
2632
2633 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2634
2635         [ews-app] Use port 17000 for worker communication
2636         https://bugs.webkit.org/show_bug.cgi?id=195558
2637
2638         Reviewed by Lucas Forschler.
2639
2640         * BuildSlaveSupport/ews-build/master.cfg:
2641
2642 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2643
2644         [ews-build] unit-tests fail when passwords.json is missing
2645         https://bugs.webkit.org/show_bug.cgi?id=195557
2646
2647         Reviewed by Lucas Forschler.
2648
2649         * BuildSlaveSupport/ews-build/loadConfig.py:
2650         (loadBuilderConfig):
2651         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
2652         (ConfigDotJSONTest.test_configuration):
2653         * BuildSlaveSupport/ews-build/master.cfg:
2654
2655 2019-03-11  Truitt Savell  <tsavell@apple.com>
2656
2657         Unreviewed, rolling out r242702.
2658
2659         Broke High Sierra builders.
2660
2661         Reverted changeset:
2662
2663         "Add utility function to allow easy reverse range-based
2664         iteration of a container"
2665         https://bugs.webkit.org/show_bug.cgi?id=195542
2666         https://trac.webkit.org/changeset/242702
2667
2668 2019-03-11  Sam Weinig  <sam@webkit.org>
2669
2670         Add utility function to allow easy reverse range-based iteration of a container
2671         https://bugs.webkit.org/show_bug.cgi?id=195542
2672
2673         Reviewed by Antti Koivisto.
2674
2675         * TestWebKitAPI/CMakeLists.txt:
2676         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2677         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
2678         (TestWebKitAPI::TEST):
2679         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
2680
2681 2019-03-10  Alex Christensen  <achristensen@webkit.org>
2682
2683         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
2684         https://bugs.webkit.org/show_bug.cgi?id=195511
2685         <rdar://problem/44873269>
2686
2687         Reviewed by Darin Adler.
2688
2689         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
2690         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
2691         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
2692         (TEST_F):
2693
2694 2019-03-10  Tim Horton  <timothy_horton@apple.com>
2695
2696         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
2697         https://bugs.webkit.org/show_bug.cgi?id=195499
2698
2699         Reviewed by Darin Adler.
2700
2701         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2702         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
2703         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
2704         (-[WKWebView synchronouslyFocusTextInputContext:]):
2705         (applyStyle):
2706         (applyIframe):
2707         (TEST):
2708         Add some tests for this SPI.
2709
2710 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
2711
2712         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
2713         https://bugs.webkit.org/show_bug.cgi?id=181151
2714
2715         Reviewed by Don Olmstead.
2716
2717         * TestWebKitAPI/CMakeLists.txt:
2718         * TestWebKitAPI/PlatformWin.cmake:
2719         Enable TestWTF RunLoop tests in all platforms.
2720
2721         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
2722         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
2723         (TestWebKitAPI::DerivedOneShotTimer::fired):
2724         (TestWebKitAPI::TEST):
2725         Only a few platforms support nested RunLoop.
2726
2727         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
2728         (TestWebKitAPI::DerivedRepeatingTimer::fired):
2729
2730 2019-03-10  David Quesada  <david_quesada@apple.com>
2731
2732         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
2733         https://bugs.webkit.org/show_bug.cgi?id=152480
2734
2735         Reviewed by Chris Dumez.
2736
2737         Add a unit test based on Daniel Bates's test case that starts a download, ensures
2738         there are no additional references to the process pool besides the one held by
2739         the download, waits for the download to finish (in the sense that the
2740         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
2741         measure, also check that the process pool has been deallocated at the end of the
2742         test. The test wouldn't be meaningful if the process pool were still alive.
2743
2744         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2745         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
2746         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
2747             The download will be canceled because the delegate does not implement the
2748             method to decide the download's destination, so this is where we know the
2749             DownloadProxyMap is done with the DownloadProxy.
2750         (TEST):
2751
2752 2019-03-08  Chris Dumez  <cdumez@apple.com>
2753
2754         Add support for Device Orientation / Motion permission API
2755         https://bugs.webkit.org/show_bug.cgi?id=195329
2756         <rdar://problem/47645367>
2757
2758         Reviewed by Geoffrey Garen.
2759
2760         Add test infrastructure to help test the Device Orientation / Motion permission API.
2761
2762         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2763         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2764         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
2765         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2766         * WebKitTestRunner/TestController.cpp:
2767         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
2768         (WTR::TestController::createWebViewWithOptions):
2769         (WTR::TestController::resetStateToConsistentValues):
2770         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
2771         * WebKitTestRunner/TestController.h:
2772         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
2773         * WebKitTestRunner/TestInvocation.cpp:
2774         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2775
2776 2019-03-08  Saam barati  <sbarati@apple.com>
2777
2778         Add a compare-results script to compare benchmark results
2779         https://bugs.webkit.org/show_bug.cgi?id=195486
2780         <rdar://problem/48723397>
2781
2782         Reviewed by Geoffrey Garen.
2783
2784         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
2785         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
2786         to extend it to learn about our other benchmarks.
2787
2788         * Scripts/compare-results: Added.
2789         (readJSONFile):
2790         (detectJetStream2):
2791         (JetStream2Results):
2792         (detectSpeedometer2):
2793         (Speedometer2Results):
2794         (detectPLT5):
2795         (PLT5Results):
2796         (detectBenchmark):
2797         (biggerIsBetter):
2798         (ttest):
2799         (getOptions):
2800         (main):
2801
2802 2019-03-08  Stephanie Lewis  <slewis@apple.com>
2803
2804         Ensure old tab state is cleared between iterations of run-benchmark
2805         https://bugs.webkit.org/show_bug.cgi?id=195393
2806         <rdar://problem/46885583>
2807
2808         Reviewed by Dewei Zhu.
2809
2810         a) ensure the default to restore state is not set
2811         b) terminate Safari correctly
2812         c) Set the system default to ignore Persistent State in Safari
2813
2814         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
2815         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
2816         (OSXBrowserDriver.prepare_env): 
2817         (OSXBrowserDriver.restore_env):
2818         (OSXBrowserDriver.close_browsers):
2819         (OSXBrowserDriver._terminate_processes):
2820         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
2821         (OSXChromeDriver):
2822         (OSXChromeCanaryDriver):
2823         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
2824         (OSXFirefoxDriver):
2825         (OSXFirefoxNightlyDriver):
2826         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
2827         (OSXSafariDriver):
2828         (OSXSafariDriver.prepare_env):
2829
2830 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
2831
2832         [GTK] Several InputMethodFilter tests are failing
2833         https://bugs.webkit.org/show_bug.cgi?id=195408
2834
2835         Reviewed by Carlos Garcia Campos.
2836
2837         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
2838         Regressed in r241751.
2839         Hexadecimal values of keycodes are expressed now in upper letters.
2840         Composited characters should be cast to UTF8 strings.
2841
2842         (TestWebKitAPI::TEST):
2843
2844 2019-03-07  Tomas Popela  <tpopela@redhat.com>
2845
2846         [GTK] Make Tools/gtkdoc python3 compatible
2847         https://bugs.webkit.org/show_bug.cgi?id=195359
2848
2849         Reviewed by Carlos Garcia Campos.
2850
2851         * gtkdoc/generate-gtkdoc:
2852         ConfigParser was reworked in Python 3.2 so we have adapt the code to
2853         work with Python 2 and 3.
2854         (get_gtkdoc_module_paths):
2855         The iteritems() was removed in Python 3, so let's use items() that's
2856         available in Python 2 and 3.
2857         (get_generator_for_config):
2858         * gtkdoc/gtkdoc.py:
2859         (GTKDoc._run_command):
2860         The sys.stdout.write() is expecting str in Python 3 and not bytes
2861         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
2862         for passing the bytes there.
2863
2864 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
2865
2866         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
2867         https://bugs.webkit.org/show_bug.cgi?id=195346
2868         <rdar://problem/48667048>
2869
2870         Unreviewed build fix for clang-cl.
2871
2872         * DumpRenderTree/win/DumpRenderTree.cpp:
2873         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
2874
2875 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
2876
2877         requestAnimationFrame should execute before the next frame
2878         https://bugs.webkit.org/show_bug.cgi?id=177484
2879
2880         Reviewed by Simon Fraser.
2881
2882         Add trace points for the page RenderingUpdate.
2883
2884         * Tracing/SystemTracePoints.plist:
2885
2886 2019-03-07  Zalan Bujtas  <zalan@apple.com>
2887
2888         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
2889         https://bugs.webkit.org/show_bug.cgi?id=195353
2890         <rdar://problem/48626394>
2891
2892         Reviewed by Simon Fraser.
2893
2894         * WebKitTestRunner/ios/TestControllerIOS.mm:
2895         (WTR::TestController::platformResetPreferencesToConsistentValues):
2896
2897 2019-03-07  John Wilander  <wilander@apple.com>
2898
2899         Resource Load Statistics: Make it possible to purge only script-accessible cookies
2900         https://bugs.webkit.org/show_bug.cgi?id=195383
2901         <rdar://problem/48570136>
2902
2903         Reviewed by Brent Fulgham.
2904
2905         This patch adds test infrastructure to purge only script-accessible cookies,
2906         including a new testRunner function called statisticsDeleteCookiesForHost().git a
2907
2908         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2909         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2910         (WTR::TestRunner::statisticsDeleteCookiesForHost):
2911         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2912         * WebKitTestRunner/TestController.cpp:
2913         (WTR::TestController::statisticsDeleteCookiesForHost):
2914         * WebKitTestRunner/TestController.h:
2915         * WebKitTestRunner/TestInvocation.cpp:
2916         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2917
2918 2019-03-07  Commit Queue  <commit-queue@webkit.org>
2919
2920         Unreviewed, rolling out r242354.
2921         https://bugs.webkit.org/show_bug.cgi?id=195402
2922
2923         breaks layout tests in all configurations (Requested by
2924         zdobersek on #webkit).
2925
2926         Reverted changeset:
2927
2928         "[WPE] Enable web process sandbox"
2929         https://bugs.webkit.org/show_bug.cgi?id=195169
2930         https://trac.webkit.org/changeset/242354
2931
2932 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
2933
2934         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
2935         https://bugs.webkit.org/show_bug.cgi?id=195346
2936
2937         Reviewed by Fujii Hironori.
2938
2939         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
2940         (TestWebKitAPI::TEST):
2941         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
2942
2943         * DumpRenderTree/win/DumpRenderTree.cpp:
2944         (findFontFallback):
2945         (addFontFallbackIfPresent):
2946         (removeFontFallbackIfPresent):
2947         (main):
2948         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
2949         (TestWebKitAPI::Util::moduleDirectory):
2950         (TestWebKitAPI::Util::createInjectedBundlePath):
2951         Use wchar helpers as needed.
2952
2953 2019-03-06  Rob Buis  <rbuis@igalia.com>
2954
2955         Consider supporting the `referrerpolicy` attribute.
2956         https://bugs.webkit.org/show_bug.cgi?id=179053
2957
2958         Reviewed by Darin Adler.
2959
2960         Add a runtime flag for referrerpolicy attribute.
2961
2962         * DumpRenderTree/mac/DumpRenderTree.mm:
2963         (enableExperimentalFeatures):
2964
2965 2019-03-05  Daniel Bates  <dabates@apple.com>
2966
2967         Update expected API test result following r242379
2968         (https://bugs.webkit.org/show_bug.cgi?id=195125)
2969
2970         Update expected x-coordinate of selection rect now that the left padding of
2971         a textarea is sized in ems (so dependent on the font size) just like the left
2972         padding of a text field.
2973
2974         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
2975         (TestWebKitAPI::TEST):
2976
2977 2019-03-05  David Quesada  <david_quesada@apple.com>
2978
2979         [WK2] It should be possible to follow links with 'download' attributes
2980         https://bugs.webkit.org/show_bug.cgi?id=195145
2981         rdar://problem/48462642
2982
2983         Reviewed by Alex Christensen.
2984
2985         Add a unit test to verify that activating links with 'download' attributes now
2986         navigates to the linked resource, rather than starts downloading it. Add another
2987         to verify that it is still possible to explicitly download the link via the
2988         'Download' navigation action policy.
2989
2990         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2991         (-[DownloadAttributeTestDelegate init]):
2992         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
2993         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
2994         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
2995         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
2996         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2997         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
2998         (TEST):
2999         * WebKitTestRunner/TestController.cpp:
3000         (WTR::TestController::decidePolicyForNavigationAction):
3001         * WebKitTestRunner/TestController.h:
3002
3003 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
3004
3005         [Curl] Implement Cookie Accept Policy.
3006         https://bugs.webkit.org/show_bug.cgi?id=191645
3007
3008         Reviewed by Fujii Hironori.
3009
3010         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
3011         (TestWebKitAPI::Curl::TEST_F):
3012
3013 2019-03-05  Youenn Fablet  <youenn@apple.com>
3014
3015         Rename requestCacheStorageSpace to requestStorageSpace
3016         https://bugs.webkit.org/show_bug.cgi?id=195282
3017
3018         Reviewed by Chris Dumez.
3019
3020         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3021         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3022         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
3023
3024 2019-03-05  Brady Eidson  <beidson@apple.com>
3025
3026         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
3027         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
3028
3029         Reviewed by Tim Horton.
3030
3031         Loading a file: URL into a WKWebView and then loading another file: url from a completely
3032         different directory into that same WKWebView should work.
3033
3034         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3035         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
3036
3037 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
3038
3039         Add WeakHashSet
3040         https://bugs.webkit.org/show_bug.cgi?id=195152
3041
3042         Reviewed by Antti Koivisto.
3043
3044         Added tests for WeakHashSet.
3045
3046         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3047         (TestWebKitAPI::Base::Base): Moved.
3048         (TestWebKitAPI::Derived::foo): Moved.
3049         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
3050         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
3051         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
3052         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
3053
3054 2019-03-04  Chris Dumez  <cdumez@apple.com>
3055
3056         Do not share WebProcesses between private and regular sessions
3057         https://bugs.webkit.org/show_bug.cgi?id=195189
3058         <rdar://problem/48421064>
3059
3060         Reviewed by Alex Christensen.
3061
3062         Add API test coverage.
3063
3064         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3065         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3066
3067 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
3068
3069         [WPE] Enable web process sandbox
3070         https://bugs.webkit.org/show_bug.cgi?id=195169
3071
3072         Reviewed by Daniel Bates.
3073
3074         * wpe/install-dependencies:
3075         * wpe/jhbuild.modules:
3076
3077 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
3078
3079         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
3080         https://bugs.webkit.org/show_bug.cgi?id=195206
3081
3082         Reviewed by Žan Doberšek.
3083
3084         Add a new test case.
3085
3086         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3087         (testJSCClass):
3088
3089 2019-03-04  Charlie Turner  <cturner@igalia.com>
3090
3091         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
3092         https://bugs.webkit.org/show_bug.cgi?id=194898
3093
3094         Reviewed by Žan Doberšek.
3095
3096         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
3097         a GCC extension that permits arithmetic on void* pointer. Inline
3098         the macro until this issue is fixed upstream.
3099
3100 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3101
3102         Rid the world of WK_API_ENABLED
3103         https://bugs.webkit.org/show_bug.cgi?id=195263
3104
3105         Reviewed by Dan Bernstein.
3106
3107         List of changed files elided because it's useless.
3108
3109 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
3110
3111         Unreviewed follow-up to r242292.
3112
3113         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
3114
3115         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3116         (TestWebKitAPI::testStrip): Renamed from strip.
3117         (TestWebKitAPI::TEST):
3118
3119 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3120
3121         Unreviewed, remove accidentally-committed URLHelpers.cpp test
3122
3123         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
3124         and bug #194272 for details.
3125
3126         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
3127
3128 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3129
3130         Remove some more unused 32-bit code
3131         https://bugs.webkit.org/show_bug.cgi?id=195255
3132
3133         Reviewed by Darin Adler.
3134
3135         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3136         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
3137         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3138         (NPP_New):
3139         (NPP_HandleEvent):
3140         (handleEventCarbon): Deleted.
3141
3142 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
3143
3144         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
3145
3146         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3147         (TestWebKitAPI::TEST):
3148
3149 2019-03-01  Darin Adler  <darin@apple.com>
3150
3151         Finish removing String::format
3152         https://bugs.webkit.org/show_bug.cgi?id=194893
3153
3154         Reviewed by Daniel Bates.
3155 '
3156         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
3157
3158 2019-03-01  Alex Christensen  <achristensen@webkit.org>
3159
3160         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
3161         https://bugs.webkit.org/show_bug.cgi?id=195229
3162         <rdar://problem/48520362>
3163
3164         Reviewed by Chris Dumez.
3165
3166         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3167         (TEST):
3168
3169 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
3170
3171         Add a system trace scope for event region building
3172         https://bugs.webkit.org/show_bug.cgi?id=195226
3173
3174         Reviewed by Jon Lee.
3175
3176         This trace scope measures the time spend converting element rects into Region objects,
3177         which can be large on some pages.
3178
3179         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
3180
3181         * Tracing/SystemTracePoints.plist:
3182
3183 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
3184
3185         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
3186         https://bugs.webkit.org/show_bug.cgi?id=194612
3187
3188         Reviewed by Alex Christensen.
3189
3190         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3191         Just test the new string-processing function and don't touch the actual environment.
3192         (Test cases are all as before, but based on operator== instead of strcmp.)
3193
3194 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
3195
3196         [ews-app] Update primary keys for handling multiple Buildbot instances
3197         https://bugs.webkit.org/show_bug.cgi?id=195120
3198
3199         Reviewed by Stephanie Lewis.
3200
3201         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
3202         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
3203         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
3204
3205         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
3206         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
3207         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
3208         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
3209         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
3210         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
3211
3212 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
3213
3214         [WinCairo] Enable service worker
3215         https://bugs.webkit.org/show_bug.cgi?id=188318
3216
3217         Reviewed by Youenn Fablet.
3218
3219         * DumpRenderTree/DumpRenderTreePrefix.h:
3220         * TestWebKitAPI/PlatformWin.cmake:
3221         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
3222         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
3223         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
3224
3225 2019-03-01  Justin Fan  <justin_fan@apple.com>
3226
3227         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
3228         https://bugs.webkit.org/show_bug.cgi?id=195191
3229
3230         Rubber-stamped by Dean Jackson.
3231
3232         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
3233
3234         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3235
3236 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
3237
3238         Unreviewed, fix lldb webkitpy tests
3239         https://bugs.webkit.org/show_bug.cgi?id=194375
3240
3241         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
3242
3243         * lldb/lldb_webkit.py:
3244         (WTFStringImplProvider.is_8bit):
3245
3246 2019-02-28  David Quesada  <david_quesada@apple.com>
3247
3248         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
3249         https://bugs.webkit.org/show_bug.cgi?id=195121
3250         rdar://problem/48450302
3251
3252         Reviewed by Alex Christensen.
3253
3254         Add API tests for -WKNavigationAction._shouldPerformDownload in various
3255         configurations where the 'download' attribute is absent, blank, or populated
3256         with a filename, and where the anchor element is same-origin or cross-origin
3257         (meaning the 'download' attribute shouldn't be honored).
3258
3259         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3260         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
3261         (-[NavigationActionTestDelegate init]):
3262         (-[NavigationActionTestDelegate navigationAction]):
3263         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
3264         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
3265         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3266         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
3267         (TEST):
3268
3269 2019-02-28  Antoine Quint  <graouts@apple.com>
3270
3271         Enable the Pointer Events runtime flag by default
3272         https://bugs.webkit.org/show_bug.cgi?id=195156
3273
3274         Reviewed by Dean Jackson.
3275
3276         * DumpRenderTree/mac/DumpRenderTree.mm:
3277         (enableExperimentalFeatures):
3278
3279 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
3280
3281         Several PasteImage API tests are flaky
3282         https://bugs.webkit.org/show_bug.cgi?id=195160
3283
3284         Reviewed by Tim Horton.
3285
3286         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
3287         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
3288         listening for a "load" event after image load is already complete.
3289
3290         To address this, make these tests first register a "load" event handler, then run script to insert an image
3291         element into the document, and finally wait until the load event is observed before checking image size.
3292
3293         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
3294
3295 2019-02-28  Chris Dumez  <cdumez@apple.com>
3296
3297         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
3298         https://bugs.webkit.org/show_bug.cgi?id=195107
3299
3300         Reviewed by Alex Christensen.
3301
3302         Give some time for the zoom level to get restored.
3303
3304         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3305
3306 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
3307
3308         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
3309         https://bugs.webkit.org/show_bug.cgi?id=194958
3310
3311         Reviewed by Geoffrey Garen.
3312
3313         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
3314         (TEST):
3315
3316 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
3317
3318         [ews-app] Update method to save build to handle builder_display_name
3319         https://bugs.webkit.org/show_bug.cgi?id=195047
3320
3321         Reviewed by Dewei Zhu.
3322
3323         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
3324         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
3325
3326 2019-02-28  Justin Fan  <justin_fan@apple.com>
3327
3328         [Web GPU] Enable Web GPU only on 64-bit
3329         https://bugs.webkit.org/show_bug.cgi?id=195139
3330
3331         Because Metal is only supported on 64 bit apps.
3332
3333         Unreviewed build fix.
3334
3335         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3336
3337 2019-02-27  Youenn Fablet  <youenn@apple.com>
3338
3339         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
3340         https://bugs.webkit.org/show_bug.cgi?id=194959
3341
3342         Reviewed by Chris Dumez.
3343
3344         Spin loop until getting the condition to remove flakiness.
3345
3346         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3347
3348 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
3349
3350         [ews-build] Buildbot should include builder_display_name in the build events
3351         https://bugs.webkit.org/show_bug.cgi?id=195045
3352
3353         Reviewed by Dewei Zhu.
3354
3355         * BuildSlaveSupport/ews-build/events.py:
3356         (Events.buildStarted): Included builder_display_name in event data. Also renamed
3357         buildername to builder_name to be consistent in naming style.
3358         (Events.buildFinished): Ditto.
3359
3360 2019-02-27  Chris Dumez  <cdumez@apple.com>
3361
3362         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
3363         https://bugs.webkit.org/show_bug.cgi?id=194480
3364
3365         Reviewed by Brady Eidson.
3366
3367         Update existing API test to make it more likely to reproduce the issue.
3368
3369         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3370
3371 2019-02-27  Brady Eidson  <beidson@apple.com>
3372
3373         Universal links from Google search results pages don't open the app.
3374         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
3375
3376         Reviewed by Geoffrey Garen.
3377
3378         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
3379         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
3380         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
3381         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3382
3383 2019-02-27  Chris Dumez  <cdumez@apple.com>
3384
3385         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
3386         https://bugs.webkit.org/show_bug.cgi?id=195102
3387
3388         Reviewed by Geoffrey Garen.
3389
3390         If the number of processes is not yet what we expect, wait a bit and check again to give
3391         processes some time to exit.
3392
3393         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3394
3395 2019-02-27  Chris Dumez  <cdumez@apple.com>
3396
3397         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
3398         https://bugs.webkit.org/show_bug.cgi?id=194545
3399
3400         Reviewed by Brady Eidson.
3401
3402         Make sure the test navigates forward and then back only once. Previously, navigating
3403         back would trigger a navigation again in a timer.
3404
3405         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3406
3407 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
3408
3409         High Sierra Debug JSC test queue should use faster hardware
3410         https://bugs.webkit.org/show_bug.cgi?id=194603
3411
3412         Rubber-stamped by Alexey Proskuryakov.
3413
3414         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
3415
3416         * BuildSlaveSupport/build.webkit.org-config/config.json:
3417         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3418         (BubbleQueueServer):
3419         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3420         (WebKitBuildbot):
3421         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3422         * QueueStatusServer/config/queues.py:
3423         * Scripts/webkitpy/common/config/ews.json:
3424         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3425         (test_ews_name):
3426
3427 2019-02-27  John Wilander  <wilander@apple.com>
3428
3429         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
3430         https://bugs.webkit.org/show_bug.cgi?id=195071
3431         <rdar://problem/48417690>
3432
3433         Reviewed by Alex Christensen and Brent Fulgham.
3434
3435         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3436         (TestWebKitAPI::createURL):
3437             Convenience function.
3438         (TestWebKitAPI::TEST):
3439             WebCore::AdClickAttribution now takes a URL when creating Source and
3440             Destination.
3441         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
3442         (TestWebKitAPI::TEST):
3443             WebCore::AdClickAttribution now takes a URL when creating Source and
3444             Destination.
3445
3446 2019-02-27  Antoine Quint  <graouts@apple.com>
3447
3448         Support Pointer Events on macOS
3449         https://bugs.webkit.org/show_bug.cgi?id=195008
3450         <rdar://problem/47454419>
3451
3452         Reviewed by Dean Jackson.
3453
3454         * DumpRenderTree/mac/DumpRenderTree.mm:
3455         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
3456         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3457
3458 2019-02-26  Mark Lam  <mark.lam@apple.com>
3459
3460         Remove remaining poisoning code.
3461         https://bugs.webkit.org/show_bug.cgi?id=194138
3462
3463         Reviewed by Saam Barati.
3464
3465         * TestWebKitAPI/CMakeLists.txt:
3466         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3467         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
3468         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
3469         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
3470         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
3471         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
3472         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
3473
3474 2019-02-26  Alex Christensen  <achristensen@webkit.org>
3475
3476         Move ephemeral local storage from WebProcess to UIProcess
3477         https://bugs.webkit.org/show_bug.cgi?id=195074
3478         <rdar://problem/47937975>
3479
3480         Reviewed by Geoff Garen.
3481
3482         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3483
3484 2019-02-20  Jer Noble  <jer.noble@apple.com>
3485
3486         [Cocoa] Media elements will restart network buffering just before suspending
3487         https://bugs.webkit.org/show_bug.cgi?id=193691
3488
3489         Reviewed by Eric Carlson.
3490
3491         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3492         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
3493         (TEST):
3494
3495 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
3496
3497         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
3498         https://bugs.webkit.org/show_bug.cgi?id=191652
3499
3500         Reviewed by Alex Christensen.
3501
3502         Fix WinCairo MiniBrowser behavior of authentication dialog.
3503
3504         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3505         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
3506
3507 2019-02-26  Youenn Fablet  <youenn@apple.com>
3508
3509         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
3510         https://bugs.webkit.org/show_bug.cgi?id=195028
3511         <rdar://problem/48243733>
3512
3513         Reviewed by Eric Carlson.
3514
3515         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3516
3517 2019-02-26  Philippe Normand  <pnormand@igalia.com>
3518
3519         [WPE] Add API for webview background color configuration
3520         https://bugs.webkit.org/show_bug.cgi?id=192305
3521
3522         Reviewed by Michael Catanzaro.
3523
3524         * MiniBrowser/wpe/main.cpp:
3525         (main): Add a new option to configure the webview background
3526         color. Example: --bg-color=transparent.
3527         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
3528         (testWebViewBackgroundColor): Enable background color API tests for WPE.
3529         (beforeAll): Ditto.
3530
3531 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
3532
3533         scalableNativeWebpageParameters() is not preserved on new page navigation.
3534         https://bugs.webkit.org/show_bug.cgi?id=194892
3535         <rdar://problem/47538280>
3536
3537         Reviewed by Wenson Hsieh.
3538         
3539         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
3540
3541         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3542         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3543         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3544         (WTR::UIScriptController::allowsViewportShrinkToFit):
3545         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3546         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3547         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3548         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3549         * WebKitTestRunner/UIScriptControllerCocoa.mm:
3550         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3551
3552 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
3553
3554         [ews-app] Add model for handling multiple Buildbot instances
3555         https://bugs.webkit.org/show_bug.cgi?id=194863
3556
3557         Reviewed by Stephanie Lewis.
3558
3559         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
3560
3561 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
3562
3563         [ews-app] Remove BuilderMapping table
3564         https://bugs.webkit.org/show_bug.cgi?id=194961
3565
3566         Reviewed by Stephanie Lewis.
3567
3568         Store builder name directly in build table, instead of having a separate
3569         table for it.
3570
3571         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
3572         * BuildSlaveSupport/ews-app/ews/models/build.py:
3573         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
3574         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3575
3576 2019-02-25  John Wilander  <wilander@apple.com>
3577
3578         Introduce and adopt new class RegistrableDomain for eTLD+1
3579         https://bugs.webkit.org/show_bug.cgi?id=194791
3580         <rdar://problem/48179240>
3581
3582         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
3583
3584         This patch adds an API test and replaces two instances of
3585         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
3586
3587         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3588         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3589         (TestWebKitAPI::TEST):
3590             Changed two strings to make sure the registrable domains are still considered
3591             invalid and pass the test.
3592         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
3593         (TestWebKitAPI::TEST):
3594         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3595         (WTR::InjectedBundle::didReceiveMessageToPage):
3596
3597 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
3598
3599         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
3600         https://bugs.webkit.org/show_bug.cgi?id=195001
3601
3602         Reviewed by Carlos Garcia Campos.
3603
3604         API version 1.0 always includes the functionality previously guarded with
3605         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
3606         unconditionally.
3607
3608         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
3609         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
3610         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
3611         (WebViewTest::showInWindow): Ditto.
3612         (WebViewTest::hideView): Ditto.
3613         * wpe/backends/HeadlessViewBackend.cpp:
3614         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
3615         * wpe/backends/ViewBackend.cpp:
3616         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
3617         * wpe/backends/WindowViewBackend.cpp:
3618         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
3619         WPE_BACKEND_CHECK_VERSION().
3620         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
3621
3622 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
3623
3624         [Flatpak] Add support for flatpak > 1.1.2
3625         https://bugs.webkit.org/show_bug.cgi?id=194088
3626
3627         Flatpak 1.2 is now out so we need to support that
3628         version now.
3629
3630         Reviewed by Michael Catanzaro.
3631
3632         * flatpak/flatpakutils.py:
3633         (check_flatpak):
3634         (FlatpakPackages.__init__):
3635         (FlatpakPackages.__detect_packages):
3636         (FlatpakPackages.__detect_packages.in):
3637         (FlatpakRepos.update):
3638
3639 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
3640
3641         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
3642         https://bugs.webkit.org/show_bug.cgi?id=194998
3643
3644         Reviewed by Carlos Garcia Campos.
3645
3646         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
3647         to a Git checkout and using the latest commit containing various fixes
3648         and improvements.
3649
3650 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
3651
3652         [WPE][GTK] Remove user agent quirk for washingtonpost.com
3653         https://bugs.webkit.org/show_bug.cgi?id=194981
3654
3655         Reviewed by Žan Doberšek.
3656
3657         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3658         (TestWebKitAPI::TEST):
3659
3660 2019-02-23  Keith Miller  <keith_miller@apple.com>
3661
3662         Add new mac target numbers
3663         https://bugs.webkit.org/show_bug.cgi?id=194955
3664
3665         Reviewed by Tim Horton.
3666
3667         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3668         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3669         * MiniBrowser/Configurations/Base.xcconfig:
3670         * TestWebKitAPI/Configurations/Base.xcconfig:
3671         * WebKitTestRunner/Configurations/Base.xcconfig:
3672
3673 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
3674
3675         [WinCairo] Enable wk1/wk2 suffix for platform search path.
3676         https://bugs.webkit.org/show_bug.cgi?id=194846
3677
3678         Reviewed by Don Olmstead.
3679
3680         Added _search_paths() and _port_specific_expectations_files() for
3681         WinCairoPort.
3682
3683         * Scripts/webkitpy/port/win.py:
3684         (WinCairoPort.default_baseline_search_path):
3685         (WinCairoPort):
3686         (WinCairoPort._port_specific_expectations_files):
3687         (WinCairoPort._search_paths):
3688
3689 2019-02-22  Tim Horton  <timothy_horton@apple.com>
3690
3691         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
3692         https://bugs.webkit.org/show_bug.cgi?id=194963
3693
3694         Reviewed by Dean Jackson.
3695
3696         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3697         Do a `contains` check instead of `equals`, because in debug builds we