[CSS3 Backgrounds and Borders] Remove CSS3_BACKGROUND feature flag.
[WebKit-https.git] / Tools / ChangeLog
1 2012-12-10  Alexis Menard  <alexis@webkit.org>
2
3         [CSS3 Backgrounds and Borders] Remove CSS3_BACKGROUND feature flag.
4         https://bugs.webkit.org/show_bug.cgi?id=104539
5
6         Reviewed by Antonio Gomes.
7
8         As discussed on webkit-dev it is not needed to keep this feature flag 
9         as support for <position> type is a small feature that is already 
10         implemented by three other UAs. It was useful while landing this 
11         feature as partial bits were landed one after one.
12
13         * Scripts/webkitperl/FeatureList.pm:
14         * qmake/mkspecs/features/features.pri:
15
16 2012-12-10  Martin Robinson  <mrobinson@igalia.com>
17
18         Build fix.
19
20         Add a patchfile missing from my previous commit.
21
22         * gtk/patches/harfbuzz-icu-detection-fix.patch: Added.
23
24 2012-12-10  Martin Robinson  <mrobinson@igalia.com>
25
26         REGRESSION(137127): Causes assertion failures on the debug bots
27         https://bugs.webkit.org/show_bug.cgi?id=104549
28
29         Reviewed by Alejandro G. Castro.
30
31         After handling the new TextOutput message we should return the method
32         handling messages received.
33
34         * WebKitTestRunner/TestInvocation.cpp:
35         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Fix a missing early return.
36
37 2012-12-09  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
38
39         [Soup] utilize multipart/x-mixed-replace support recently added to libsoup
40         https://bugs.webkit.org/show_bug.cgi?id=94515
41
42         Reviewed by Martin Robinson.
43
44         This change requires a very recent libsoup, so update our jhbuild
45         requirements.
46
47         * gtk/jhbuild.modules: depend on soup version that adds the multipart/x-mixed-replace
48         support
49         * efl/jhbuild.modules: ditto
50
51 2012-12-10  Zoltan Nyul  <zoltan.nyul@intel.com>
52
53         Implement testRunner.setViewModeMediaFeature() in WebKitTestRunner
54         https://bugs.webkit.org/show_bug.cgi?id=103886
55
56         Reviewed by Kenneth Rohde Christiansen.
57
58         Implement testRunner.setViewModeMediaFeature() in WebKitTestRunner.
59         This API is required by layout tests.
60
61         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
62         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
63         (WTR::TestRunner::setViewModeMediaFeature):
64         (WTR):
65         * WebKitTestRunner/InjectedBundle/TestRunner.h:
66         (TestRunner):
67
68 2012-12-10  Martin Robinson  <mrobinson@igalia.com>
69
70         [GTK] Bring Harfbuzz-ng support to Gtk
71         https://bugs.webkit.org/show_bug.cgi?id=92098
72
73         Reviewed by Gustavo Noronha Silva.
74
75         Add HarfBuzz dependency.
76
77         * GNUmakefile.am: Add FreeType/HarfBuzz CFLAGS to the WebCore Internals library.
78         * gtk/jhbuild.modules: Add HarfBuzz to the JHbuild and remove Pango, since it
79         should no longer affect layout test results.
80
81 2012-12-10  Simon Hausmann  <simon.hausmann@digia.com>
82
83         [Qt] Use QLibraryInfo::LibraryExecutablesPath unconditionally
84         https://bugs.webkit.org/show_bug.cgi?id=104541
85
86         Reviewed by Jocelyn Turcotte.
87
88         We now depend on a Qt 5 version that is guaranteed to have this API, so we
89         can remove the configure checks for it.
90
91         * qmake/config.tests/libexecdir/libexecdir.cpp: Removed.
92         * qmake/config.tests/libexecdir/libexecdir.pro: Removed.
93         * qmake/mkspecs/features/features.prf:
94
95 2012-12-10  Víctor Manuel Jáquez Leal  <vjaquez@igalia.com>
96
97         REGRESSION(r135863): GtkLauncher --help no longer displays all help options
98         https://bugs.webkit.org/show_bug.cgi?id=104382
99
100         Reviewed by Philippe Normand.
101
102         Remove gst_init() because it steals the GOptionContext.
103         gst_init_get_option_group() already does the initialization job.
104
105         * GtkLauncher/main.c:
106         (main):
107
108 2012-12-10  Zan Dobersek  <zandobersek@gmail.com>
109
110         [GTK][WTR] Implement AccessibilityUIElement::titleUIElement
111         https://bugs.webkit.org/show_bug.cgi?id=102953
112
113         Reviewed by Martin Robinson.
114
115         Implement AccessibilityUIElement::titleUIElement in the ATK backend
116         in the same manner it is implemented in DumpRenderTree. Both implementations
117         are updated to unref the relation set before the final function return
118         rather than at the end of each loop through the relations held in the said
119         relation set.
120
121         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
122         (AccessibilityUIElement::titleUIElement):
123         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
124         (WTR::AccessibilityUIElement::titleUIElement):
125
126 2012-12-10  Martin Robinson  <mrobinson@igalia.com>
127
128         Fix the WebKit2 debug build
129
130         * WebKitTestRunner/TestInvocation.cpp:
131         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Fix a typo of WKStringGetTypeID().
132
133 2012-12-10  Martin Robinson  <mrobinson@igalia.com>
134
135         [WTR] Move text output accumulation to the UIProcess
136         https://bugs.webkit.org/show_bug.cgi?id=104214
137
138         Reviewed by Darin Adler.
139
140         Instead of accumulating text output in the InjectedBundle and then sending it to the UIProcess 
141         once a test is finished, immediately send any text output to the UIProcess. This will allow
142         WebKitTestRunner to output text from the UIProcess as well.
143
144         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: Remove the handling of the text output
145         StringBuilder. Add a method to send output to the UIProcess.
146         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
147         (InjectedBundle):
148         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Change code that appends to the StringBuilder
149         to use the new outputText method.
150         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
151         * WebKitTestRunner/InjectedBundle/TestRunner.cpp: Ditto.
152         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp: Ditto.
153         * WebKitTestRunner/TestInvocation.cpp:
154         (WTR::TestInvocation::TestInvocation): Intialize the StringBuilder.
155         (WTR::TestInvocation::invoke): Clear the StringBuilder when a new tests starts.
156         (WTR::TestInvocation::dumpResults): m_textOutput is a StringBuilder now so the
157         method of printing the text is slightly different.
158         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Handle the new TextOutput
159         message by appending the results to the StringBuilder.
160         * WebKitTestRunner/TestInvocation.h:
161         (TestInvocation): Switch the type of m_textOutput.
162
163 2012-12-10  Mihnea Ovidenie  <mihnea@adobe.com>
164
165         Unreviewed. Adding Mihai Maerean to the list of contributors, working on CSSRegions.
166
167         * Scripts/webkitpy/common/config/committers.py:
168
169 2012-12-10  Joanmarie Diggs  <jdiggs@igalia.com>
170
171         [GTK] accessibility/language-attribute.html is failing
172         https://bugs.webkit.org/show_bug.cgi?id=98369
173
174         Reviewed by Chris Fleizach.
175
176         The test is failing for two reasons: Not exposing the language
177         for accessible objects and AccessibilityUIElement::language() not
178         being implemented.
179
180         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
181         (AccessibilityUIElement::language): Implemented.
182
183 2012-12-10  Joanmarie Diggs  <jdiggs@igalia.com>
184
185         [GTK] accessibility/editable-webarea-context-menu-point.html is failing
186         https://bugs.webkit.org/show_bug.cgi?id=98364
187
188         Reviewed by Chris Fleizach.
189
190         The test is failing because the clickPoint values remain unchanged. The
191         values remain unchanged because ATK lacks a means to keep track of this
192         information.
193
194         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
195         (AccessibilityUIElement::clickPointX): Added comment that ATK doesn't have clickPoint details
196         (AccessibilityUIElement::clickPointY): Added comment that ATK doesn't have clickPoint details
197
198 2012-12-09  Alejandro Piñeiro  <apinheiro@igalia.com>
199
200         [GTK] lack of implemention of AccessibilityUIElementGtk::isSelectable and AccessibilityUIElementGtk::isMultiSelectable
201         https://bugs.webkit.org/show_bug.cgi?id=104481
202
203         Reviewed by Martin Robinson.
204
205         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
206         (AccessibilityUIElement::isSelectable): Implement this by checking
207         the current state of the AtkObject.
208         (AccessibilityUIElement::isMultiSelectable): Implement this by
209         checking the current state of the AtkObject.
210
211 2012-12-09  Joanmarie Diggs  <jdiggs@igalia.com>
212
213         [GTK] accessibility/placeholder.html is failing
214         https://bugs.webkit.org/show_bug.cgi?id=98373
215
216         Reviewed by Martin Robinson.
217
218         The test was failing because the placeholder text was not supported and
219         AccessibilityUIElement::stringAttributeValue() was not implemented.
220
221         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
222         (coreAttributeToAtkAttribute): New convenience method to convert WebCore attribute
223         names into AtkObject attribute names
224         (AccessibilityUIElement::stringAttributeValue): implemented
225
226 2012-12-09  Dan Winship  <danw@gnome.org>
227
228         [GTK] Bump libxml2 requirement in jhbuild.modules
229         https://bugs.webkit.org/show_bug.cgi?id=104477
230
231         Reviewed by Martin Robinson.
232
233         Fedora 18's Apache depends on symbols in libxml2 2.9.0, so the
234         tests won't run if we only have libxml2 2.8.0 installed in the
235         jhbuild root.
236
237         * gtk/jhbuild.modules:
238
239 2012-12-09  Zan Dobersek  <zandobersek@gmail.com>
240
241         Remove testRunner.disableImageLoading()
242         https://bugs.webkit.org/show_bug.cgi?id=98083
243
244         Reviewed by Gustavo Noronha Silva.
245
246         Remove the disableImageLoading methods and callback.
247         No tests use the method anymore and all ports except Wx
248         now support this behavior through overriding the
249         WebKitDisplayImagesKey preference.
250
251         * DumpRenderTree/TestRunner.cpp:
252         (TestRunner::staticFunctions):
253         * DumpRenderTree/TestRunner.h:
254         (TestRunner):
255         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
256         (TestRunner::overridePreference): Add support for overriding the
257         WebKitDisplayImagesKey preference which is now the preferred way
258         of disabling image loading.
259         * DumpRenderTree/efl/TestRunnerEfl.cpp:
260         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
261         * DumpRenderTree/mac/TestRunnerMac.mm:
262         * DumpRenderTree/qt/TestRunnerQt.cpp:
263         * DumpRenderTree/qt/TestRunnerQt.h:
264         (TestRunner):
265         * DumpRenderTree/win/TestRunnerWin.cpp:
266         * DumpRenderTree/wx/TestRunnerWx.cpp:
267
268 2012-12-09  Joanmarie Diggs  <jdiggs@igalia.com>
269
270         [GTK] accessibility/label-for-control-hittest.html is failing
271         https://bugs.webkit.org/show_bug.cgi?id=98368
272
273         Reviewed by Martin Robinson.
274
275         The test was failing because AccessibilityUIElement::elementAtPoint was
276         not implemented.
277
278         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
279         (AccessibilityUIElement::elementAtPoint): implemented
280
281 2012-12-09  Jon Lee  <jonlee@apple.com>
282
283         [WK2] Move button image to injected bundle
284         https://bugs.webkit.org/show_bug.cgi?id=104107
285         <rdar://problem/12813842>
286
287         Reviewed by Simon Fraser.
288
289         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
290         (WTR::InjectedBundlePage::InjectedBundlePage): Update the bundle page UI client.
291
292 2012-12-08  Halton Huo  <halton.huo@intel.com>
293
294         [CMake] Add CMake style checker
295         https://bugs.webkit.org/show_bug.cgi?id=104240
296
297         Reviewed by Eric Seidel.
298
299         The CMake style checker is followed by existing style checkers like cpp, python.
300         Unit test is added as well.
301
302         * Scripts/webkitpy/style/checker.py: Use CMakeChecker CMAKE type files(.cmake or CMakeLists.txt)
303         (FileType):
304         (CheckerDispatcher._file_type):
305         (CheckerDispatcher._create_checker):
306         * Scripts/webkitpy/style/checkers/cmake.py: Added.
307         (CMakeChecker):
308         (CMakeChecker.__init__): 
309         (CMakeChecker.check):
310         (CMakeChecker._process_line):
311         (CMakeChecker._check_trailing_whitespace):
312         (CMakeChecker._check_no_space_cmds):
313         (CMakeChecker._check_one_space_cmds):
314         (CMakeChecker._check_non_lowercase_cmd):
315         (CMakeChecker._check_indent):
316         * Scripts/webkitpy/style/checkers/cmake_unittest.py: Added.
317         (CMakeCheckerTest):
318         (CMakeCheckerTest.test_init):
319         (CMakeCheckerTest.test_init._mock_handle_style_error):
320         (CMakeCheckerTest.test_check):
321         (CMakeCheckerTest.test_check._mock_handle_style_error):
322
323 2012-12-08  Kondapally Kalyan  <kalyan.kondapally@intel.com>
324
325         [EFL] Enable WebGL by default.
326         https://bugs.webkit.org/show_bug.cgi?id=102991.
327
328         Reviewed by Kenneth Rohde Christiansen.
329
330         Enable WebGL by default.
331
332         * Scripts/webkitperl/FeatureList.pm:
333
334 2012-12-07  Scott Violet  <sky@chromium.org>
335
336         [chromium] Remove linux theme related files and switch to default
337         https://bugs.webkit.org/show_bug.cgi?id=103897
338
339         Reviewed by Dimitri Glazkov.
340
341         * Scripts/webkitpy/common/config/build_unittest.py:
342         (ShouldBuildTest): linux->default
343
344 2012-12-07  Mike Lattanzio  <mlattanzio@rim.com>
345
346         [BlackBerry] Update BlackBerry Port to use new Graphics::createBuffer BufferType enum values.
347         https://bugs.webkit.org/show_bug.cgi?id=104121
348
349         Reviewed by Rob Buis.
350
351         Update createBuffer call to reflect new BufferType enum.
352         Internal PR 254649
353         Internal Review: Jakob Petsovits
354
355         DRT is always backed for maximum compatibility.
356
357         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
358         (createBitmapContextFromWebView):
359
360 2012-12-07  Jochen Eisinger  <jochen@chromium.org>
361
362         Add 'CHROMIUM_DEVEL_SANDBOX' to the environment variables to copy for layout test drivers
363         https://bugs.webkit.org/show_bug.cgi?id=104355
364
365         Reviewed by Dirk Pranke.
366
367         This enables chromium's content_shell driver to run with the full SUID
368         sandbox.
369
370         * Scripts/webkitpy/layout_tests/port/base.py:
371         (Port.to.setup_environ_for_server):
372
373 2012-12-07  KyungTae Kim  <ktf.kim@samsung.com>
374
375         [EFL] Fix tools for WebKit2-only builds
376         https://bugs.webkit.org/show_bug.cgi?id=103904
377
378         Reviewed by Laszlo Gombos.
379
380         The libewebkit2.so should be used for library path for EFL WebKit2.
381
382         * Scripts/webkitdirs.pm:
383         (builtDylibPathForName):
384
385 2012-12-07  Xiaobo Wang  <xbwang@torchmobile.com.cn>
386
387         [BlackBerry] DRT - Update implementation of TestRunner.setCustomPolicyDelegate()
388         https://bugs.webkit.org/show_bug.cgi?id=104243
389
390         RIM PR 259337
391
392         Reviewed by Rob Buis.
393
394         1. Implement calculation of navigation originating in
395         didDecidePolicyForNavigationAction().
396         2. Implement policy delegate for resource response.
397         3. Enable customPolicyDelegate if waitForPolicyDelegate() is called.
398         4. Minor optional updates in dump() and dumpFrameLoadCallbacks().
399
400         The patch fixed the following tests:
401         - http/tests/download
402         - fast/forms/mailto/formenctype-attribute-button-html.html
403         - fast/forms/mailto/formenctype-attribute-input-html.html
404         - fast/encoding/mailto-always-utf-8.html
405
406         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
407         (BlackBerry::WebKit::DumpRenderTree::DumpRenderTree):
408         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
409         (BlackBerry::WebKit::DumpRenderTree::dump):
410         (BlackBerry::WebKit::DumpRenderTree::didFinishLoadForFrame):
411         (BlackBerry::WebKit::DumpRenderTree::didDecidePolicyForNavigationAction):
412         (BlackBerry::WebKit::DumpRenderTree::didDecidePolicyForResponse):
413         (BlackBerry::WebKit::DumpRenderTree::setCustomPolicyDelegate):
414         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
415         (DumpRenderTree):
416         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
417         (TestRunner::setCustomPolicyDelegate):
418         (TestRunner::waitForPolicyDelegate):
419         (TestRunner::overridePreference):
420
421 2012-12-07  Gwang Yoon Hwang  <ryumiel@company100.net>
422
423         [Qt] Adjust library name in layout_tests/port/qt.py after Qt5-r40
424         https://bugs.webkit.org/show_bug.cgi?id=104348
425
426         Reviewed by Csaba Osztrogonác.
427
428         After Qt-5.0.0-r40, the library was renamed from QtWebKitWidgets to
429         Qt5WebKitWidgets. run-webkit-tests were still looking for QtWebKitWidgets
430
431         * Scripts/webkitpy/layout_tests/port/qt.py:
432         (QtPort._path_to_webcore_library):
433
434 2012-12-07  Csaba Osztrogonác  <ossy@webkit.org>
435
436         Unreviewed fix, unbreak run-launcher after library renaming.
437
438         * Scripts/webkitdirs.pm:
439         (builtDylibPathForName):
440
441 2012-12-06  Csaba Osztrogonác  <ossy@webkit.org>
442
443         Unreviewed fix after r136896, unbreak --debug-rwt to make bots result verbose again.
444         https://bugs.webkit.org/show_bug.cgi?id=104296
445
446         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
447         (main):
448
449 2012-12-06  Rick Byers  <rbyers@chromium.org>
450
451         CSS cursor property should support webkit-image-set
452         https://bugs.webkit.org/show_bug.cgi?id=99493
453
454         Reviewed by Beth Dakin.
455
456         Add ENABLE_MOUSE_CURSOR_SCALE - disabled by default
457
458         * Scripts/webkitperl/FeatureList.pm:
459         * qmake/mkspecs/features/features.pri:
460
461 2012-12-06  Vivek Galatage  <vivek.vg@samsung.com>
462
463         Unreviewed. Fixing the email address order to work correctly with bugzilla.
464
465         * Scripts/webkitpy/common/config/committers.py:
466
467 2012-12-06  Jochen Eisinger  <jochen@chromium.org>
468
469         [chromium] when forwarding events through the WebPluginContainer, create a UserGestureIndicator if processing a user gesture
470         https://bugs.webkit.org/show_bug.cgi?id=104306
471
472         Reviewed by Dimitri Glazkov.
473
474         * DumpRenderTree/chromium/TestWebPlugin.cpp:
475         (TestWebPlugin::TestWebPlugin):
476         (TestWebPlugin::handleInputEvent): add support for printing the user gesture status
477         * DumpRenderTree/chromium/TestWebPlugin.h:
478         (TestWebPlugin):
479
480 2012-12-06  Dirk Pranke  <dpranke@chromium.org>
481
482         new-run-webkit-tests --lint-test-files seems to be broken
483         https://bugs.webkit.org/show_bug.cgi?id=104296
484
485         Unreviewed, build fix.
486
487         My recent refactoring caused me to not initialize the printer
488         before calling lint(); this patch restructures the code to make
489         the lint routine self-contained and do all the work necessary.
490         This will also make it easier to move this code out into a standalone
491         file.
492
493         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
494         (lint):
495         (main):
496         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
497         (LintTest.test_all_configurations):
498         (LintTest.test_lint_test_files):
499         (LintTest.test_lint_test_files__errors):
500
501 2012-12-05  Filip Pizlo  <fpizlo@apple.com>
502
503         DFG profiler should be helpful about gem installation
504         https://bugs.webkit.org/show_bug.cgi?id=104217
505
506         Reviewed by Oliver Hunt.
507         
508         'json' and 'highline' are not installed by default on the ruby distributions with
509         which I am familiar, and the default error messages don't make me happy. This makes
510         display-profiler-output print a helpful message if those gems are not found.
511
512         * Scripts/display-profiler-output:
513
514 2012-12-05  Filip Pizlo  <fpizlo@apple.com>
515
516         Profiler should print a helpful message if you pass the wrong arguments
517         https://bugs.webkit.org/show_bug.cgi?id=104222
518
519         Reviewed by Oliver Hunt.
520
521         * Scripts/display-profiler-output:
522
523 2012-12-06  Ojan Vafai  <ojan@chromium.org>
524
525         Allow for CCing a secondary email address from watchlists
526         https://bugs.webkit.org/show_bug.cgi?id=104286
527
528         Reviewed by Dirk Pranke.
529
530         Change my watchlist CC address so I can filter these separately from
531         when people explicitly CC me and update the watchlist parser to allow that.
532
533         * Scripts/webkitpy/common/config/committers.py:
534         * Scripts/webkitpy/common/config/watchlist:
535         * Scripts/webkitpy/common/watchlist/watchlistparser.py:
536         (WatchListParser._validate):
537         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:
538         (WatchListParserTest.test_cc_rule_with_invalid_email):
539         (WatchListParserTest.test_cc_rule_with_secondary_email):
540
541 2012-12-06  Max Vujovic  <mvujovic@adobe.com>
542
543         Unreviewed. Add myself to committers.py.
544
545         * Scripts/webkitpy/common/config/committers.py:
546
547 2012-12-06  Yael Aharon  <yael.aharon@intel.com>
548
549         [EFL] [WK2] fast/dom/vertical-scrollbar-in-rtl.html makes fast/regions tests flaky
550         https://bugs.webkit.org/show_bug.cgi?id=104139
551
552         Reviewed by Kenneth Rohde Christiansen.
553
554         Resize the window back to 800x600 between tests.
555         This should be a no-op if the test did not resize the window.
556
557         * WebKitTestRunner/TestController.cpp:
558         (WTR::TestController::resetStateToConsistentValues):
559
560 2012-12-06  Tommy Widenflycht  <tommyw@google.com>
561
562         Speech Recognition API: Change the error code to a string on SpeechRecognitionError
563         https://bugs.webkit.org/show_bug.cgi?id=104254
564
565         Reviewed by Adam Barth.
566
567         Changes the mock error function to take a string instead of an int.
568
569         * DumpRenderTree/chromium/DRTTestRunner.cpp:
570         (DRTTestRunner::setMockSpeechRecognitionError):
571         * DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp:
572         (WebTestRunner::ErrorTask::ErrorTask):
573         (MockWebSpeechRecognizer::setError):
574         * DumpRenderTree/chromium/MockWebSpeechRecognizer.h:
575         (MockWebSpeechRecognizer):
576
577 2012-12-06  Andras Becsi  <andras.becsi@digia.com>
578
579         [Qt][Mac] Fix libxslt and libxml2 config tests
580         https://bugs.webkit.org/show_bug.cgi?id=104164
581
582         Reviewed by Simon Hausmann.
583
584         We should not use pkg-config on Mac instead use direct include
585         paths and add needed libraries to the linker options to detect
586         libxslt and libxml2 provided by the system.
587         Previously we would always fall back to qtxmlpatterns.
588
589         * qmake/config.tests/libxml2/libxml2.pro:
590         * qmake/config.tests/libxslt/libxslt.pro:
591
592 2012-12-06  Csaba Osztrogonác  <ossy@webkit.org>
593
594         [Qt] Fix the build if the path contains "+" character
595         https://bugs.webkit.org/show_bug.cgi?id=104120
596
597         Reviewed by Tor Arne Vestbø.
598
599         The second parameter of qmake's replace() is regular expression, so
600         we have to escape special characters in paths passed to replace().
601
602         * qmake/mkspecs/features/default_post.prf:
603         * qmake/mkspecs/features/default_pre.prf:
604         * qmake/mkspecs/features/functions.prf:
605
606 2012-12-06  Sheriff Bot  <webkit.review.bot@gmail.com>
607
608         Unreviewed, rolling out r136825.
609         http://trac.webkit.org/changeset/136825
610         https://bugs.webkit.org/show_bug.cgi?id=104251
611
612         It made 100+ test fail on Qt-WK2 pixel bot, and 1800+ test
613         flakey on Qt-WK2 non-pixel bot (Requested by Ossy on #webkit).
614
615         * WebKitTestRunner/TestController.cpp:
616         (WTR::TestController::resetStateToConsistentValues):
617
618 2012-12-06  Yael Aharon  <yael.aharon@intel.com>
619
620         [EFL] [WK2] fast/dom/vertical-scrollbar-in-rtl.html makes fast/regions tests flaky
621         https://bugs.webkit.org/show_bug.cgi?id=104139
622
623         Reviewed by Kenneth Rohde Christiansen.
624
625         Resize the window back to 800x600 between tests.
626         This should be a no-op if the test did not resize the window.
627
628         * WebKitTestRunner/TestController.cpp:
629         (WTR::TestController::resetStateToConsistentValues):
630
631 2012-12-06  Sheriff Bot  <webkit.review.bot@gmail.com>
632
633         Unreviewed, rolling out r136784 and r136802.
634         http://trac.webkit.org/changeset/136784
635         http://trac.webkit.org/changeset/136802
636         https://bugs.webkit.org/show_bug.cgi?id=104231
637
638         breaks chromium canary (Requested by morrita on #webkit).
639
640         * Scripts/webkitpy/common/config/build_unittest.py:
641         (ShouldBuildTest):
642
643 2012-12-05  Ryosuke Niwa  <rniwa@webkit.org>
644
645         Add myself to watch changes in PerformanceTests/*.
646
647         * Scripts/webkitpy/common/config/watchlist:
648
649 2012-12-05  Shinya Kawanaka  <shinyak@chromium.org>
650
651         [Chromium] DRT on Windows crashes when a testcase has a progress element in indeterminate state
652         https://bugs.webkit.org/show_bug.cgi?id=102459
653
654         Reviewed by Dimitri Glazkov.
655
656         Since WebThemeControlDRTWin::markState does not consider indeterminate state, DRT caused a crash.
657
658         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp:
659         (WebThemeControlDRTWin::markState):
660
661 2012-12-05  Filip Pizlo  <fpizlo@apple.com>
662
663         DFG profiler should be able to display where a code block was inlined into, and what it inlined
664         https://bugs.webkit.org/show_bug.cgi?id=104216
665
666         Reviewed by Oliver Hunt.
667
668         Added an "inlines" command that shows the inline stacks that a code block participated
669         in. Also cleaned up some of the ways we print compilation units.
670
671         * Scripts/display-profiler-output:
672
673 2012-12-05  Halton Huo  <halton.huo@intel.com>
674
675         [CMake] Unify coding style for CMake files
676         https://bugs.webkit.org/show_bug.cgi?id=103605
677
678         Reviewed by Laszlo Gombos.
679
680         Update cmake files(.cmake, CMakeLists.txt) with following style rules:
681         1. Indentation
682         1.1 Use spaces, not tabs.
683         1.2 Four spaces as indent.
684         2. Spacing
685         2.1 Place one space between control statements and their parentheses.
686             For eg, if (), else (), elseif (), endif (), foreach (),
687             endforeach (), while (), endwhile (), break ().
688         2.2 Do not place spaces between function and macro statements and
689             their parentheses. For eg, macro(), endmacro(), function(),
690             endfunction().
691         2.3 Do not place spaces between a command or function or macro and its
692             parentheses, or between a parenthesis and its content. For eg,
693             message("testing") not message( "testing") or message ("testing" )
694         2.4 No space at line ending.
695         3. Lowercase when call commands macros and functions. For eg,
696            add_executable() not ADD_EXECUTABLE(), set() not SET().
697
698         * CMakeLists.txt:
699         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
700         * DumpRenderTree/efl/CMakeLists.txt:
701         * EWebLauncher/CMakeLists.txt:
702         * EWebLauncher/ControlTheme/CMakeLists.txt:
703         * MiniBrowser/efl/CMakeLists.txt:
704         * TestWebKitAPI/CMakeLists.txt:
705         * TestWebKitAPI/PlatformEfl.cmake:
706         * WebKitTestRunner/CMakeLists.txt:
707         * WebKitTestRunner/PlatformEfl.cmake:
708         * WinCELauncher/CMakeLists.txt:
709         * clang/ReportMemoryUsagePlugin/CMakeLists.txt:
710
711 2012-12-05  Scott Violet  <sky@chromium.org>
712
713         [chromium] Remove linux theme related files and switch to default
714         https://bugs.webkit.org/show_bug.cgi?id=103897
715
716         Reviewed by Tony Chang.
717
718         * Scripts/webkitpy/common/config/build_unittest.py:
719         (ShouldBuildTest): linux->default
720
721 2012-12-05  Dirk Pranke  <dpranke@chromium.org>
722
723         nrwt: run_webkit_tests_integrationtest.py depends on being able to share a port w/ between master and worker
724         https://bugs.webkit.org/show_bug.cgi?id=78168
725
726         Reviewed by Ojan Vafai.
727
728         This patch adds a single ordered list to ResultSummary that contains
729         the results of every test run in order of result received, and
730         modifies the TestResults class to contain the list of references used
731         for each test as well as the pid of the driver; this allows us to stop
732         having to override the test drivers to record the tests, and makes the
733         integration tests that test rdering, retries, restarts, etc. black-box
734         tests.
735
736         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
737         (SingleTestRunner._run_rebaseline):
738         (SingleTestRunner._compare_output):
739         (SingleTestRunner._run_reftest):
740         (SingleTestRunner._compare_output_with_reference):
741         * Scripts/webkitpy/layout_tests/models/result_summary.py:
742         (ResultSummary.__init__):
743         (ResultSummary.add):
744         * Scripts/webkitpy/layout_tests/models/test_results.py:
745         (TestResult.__init__):
746         * Scripts/webkitpy/layout_tests/port/driver.py:
747         (DriverOutput.__init__):
748         (Driver.run_test):
749         * Scripts/webkitpy/layout_tests/port/test.py:
750         (TestDriver):
751         (TestDriver.__init__):
752         (TestDriver.run_test):
753         (TestDriver.stop):
754         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
755         (get_tests_run):
756         (get_test_batches):
757         (get_test_results):
758         (MainTest.test_batch_size):
759         (MainTest.test_dryrun):
760         (MainTest.test_natural_order):
761         (MainTest.test_natural_order_test_specified_multiple_times):
762         (MainTest.test_random_order):
763         (MainTest.test_random_order_test_specified_multiple_times):
764         (MainTest.test_no_order):
765         (MainTest.test_no_order_test_specified_multiple_times):
766         (MainTest.test_no_order_with_directory_entries_in_natural_order):
767         (MainTest.test_repeat_each):
768         (MainTest.test_ignore_flag):
769         (MainTest.test_skipped_flag):
770         (MainTest.test_iterations):
771         (MainTest.test_run_chunk):
772         (MainTest.test_run_part):
773         (MainTest.test_run_singly):
774         (MainTest.test_skip_failing_tests):
775         (MainTest.test_single_file):
776         (MainTest.test_single_file_with_prefix):
777         (MainTest.test_single_skipped_file):
778         (MainTest.test_test_list):
779         (MainTest.test_test_list_with_prefix):
780         (MainTest.test_exit_after_n_failures):
781         (MainTest.test_exit_after_n_crashes):
782         (MainTest.test_run_order__inline):
783         (MainTest.test_reftest_run):
784         (MainTest.test_reftest_run_reftests_if_pixel_tests_are_disabled):
785         (MainTest.test_reftest_skip_reftests_if_no_ref_tests):
786         (MainTest.test_reftest_expected_html_should_be_ignored):
787         (MainTest.test_reftest_driver_should_run_expected_html):
788         (MainTest.test_reftest_driver_should_run_expected_mismatch_html):
789         (MainTest.test_no_http_tests):
790         (MainTest.test_platform_tests_are_found):
791
792 2012-12-05  Dana Jansens  <danakj@chromium.org>
793
794         [chromium] Make WebCompositorOutputSurface an empty class when USE_CC_OUTPUT_SURFACE is defined.
795         https://bugs.webkit.org/show_bug.cgi?id=103967
796
797         Reviewed by James Robinson.
798
799         Use the WebCompositorSupport methods to create an OutputSurface. If they
800         fail, then fall back to the WebViewHost methods.
801
802         Once the chromium side lands, the WebCompositorSupport methods will stop
803         failing, and will replace the WebViewHost ones.
804
805         * DumpRenderTree/chromium/WebViewHost.cpp:
806         (WebViewHost::createOutputSurface):
807
808 2012-12-05  Dirk Pranke  <dpranke@chromium.org>
809
810         nrwt: split all of the buildbot-specific output into its own file
811         https://bugs.webkit.org/show_bug.cgi?id=104165
812
813         Reviewed by Ojan Vafai.
814
815         Now that we have the RunDetails object we can move all of the
816         buildbot-specific knowledge out of the core test-running code
817         and into the outermost run_webkit_tests layer.
818
819         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
820         (run):
821         (main):
822         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
823         (passing_run):
824         (logging_run):
825         (run_and_capture):
826         (MainTest.test_all):
827         (MainTest.test_max_locked_shards):
828         (MainTest.test_child_processes_2):
829         (MainTest.test_child_processes_min):
830         (MainTest.test_full_results_html):
831         (MainTest.test_hung_thread):
832         (MainTest.test_keyboard_interrupt):
833         (MainTest.test_no_tests_found):
834         (MainTest.test_no_tests_found_2):
835         (MainTest.test_repeat_each_iterations_num_tests):
836         (MainTest.test_run_singly_actually_runs_tests):
837         (MainTest.test_test_list):
838         (MainTest.test_unexpected_failures):
839         (MainTest.test_missing_and_unexpected_results):
840         (MainTest.test_pixel_test_directories):
841         (MainTest.test_missing_and_unexpected_results_with_custom_exit_code):
842         (MainTest.test_crash_with_stderr):
843         (MainTest.test_no_image_failure_with_image_diff):
844         (MainTest.test_crash_log):
845         (MainTest.test_web_process_crash_log):
846         (MainTest.test_exit_after_n_failures_upload):
847         (MainTest.test_results_directory_absolute):
848         (MainTest.test_results_directory_default):
849         (MainTest.test_results_directory_relative):
850         (MainTest.test_retrying_and_flaky_tests):
851         (MainTest.test_reftest_should_not_use_naming_convention_if_not_listed_in_reftestlist):
852         (MainTest.test_output_diffs):
853         (MainTest.test_unsupported_platform):
854         (MainTest.test_verbose_in_child_processes):
855         (EndToEndTest.test_end_to_end):
856         (EndToEndTest.test_reftest_with_two_notrefs):
857         (RebaselineTest.test_reset_results):
858         (RebaselineTest.test_missing_results):
859         (RebaselineTest.test_new_baseline):
860         * Scripts/webkitpy/layout_tests/views/buildbot_results.py: Added.
861         (BuildBotPrinter):
862         (BuildBotPrinter.__init__):
863         (BuildBotPrinter.print_results):
864         (BuildBotPrinter._print):
865         (BuildBotPrinter.print_result_summary):
866         (BuildBotPrinter._print_result_summary_entry):
867         (BuildBotPrinter.print_unexpected_results):
868         (BuildBotPrinter.print_unexpected_results.add_to_dict_of_lists):
869         (BuildBotPrinter.print_unexpected_results.add_result):
870         * Scripts/webkitpy/layout_tests/views/buildbot_results_unittest.py: Added.
871         (BuildBotPrinterTests):
872         (BuildBotPrinterTests.assertEmpty):
873         (BuildBotPrinterTests.assertNotEmpty):
874         (BuildBotPrinterTests.get_printer):
875         (BuildBotPrinterTests.get_result):
876         (BuildBotPrinterTests.get_result_summary):
877         (BuildBotPrinterTests.test_print_unexpected_results):
878         (BuildBotPrinterTests.test_print_unexpected_results.get_unexpected_results):
879         * Scripts/webkitpy/layout_tests/views/printing.py:
880         (Printer):
881         (Printer.__init__):
882         (Printer.print_results):
883         (Printer._print_statistics_for_test_timings):
884         (Printer._print_baseline):
885         (Printer._print_debug):
886         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
887         (Testprinter.get_printer):
888         (Testprinter.get_result):
889         (Testprinter.test_configure_and_cleanup):
890         (Testprinter.test_print_config):
891         (Testprinter.test_print_one_line_summary):
892         (Testprinter.test_test_status_line):
893         (Testprinter.test_details):
894
895 2012-12-05  Dirk Pranke  <dpranke@chromium.org>
896
897         nrwt: collect all of the information about a run into a new RunDetails class
898         https://bugs.webkit.org/show_bug.cgi?id=104158
899
900         Reviewed by Ojan Vafai.
901
902         This patch collects the information from both test passes (the
903         main one and the retries) as well as the summarized results and
904         the exit code into a RunDetails class, so that the integration
905         tests can more easily tell what happened.
906
907         Also, change the way the --lint-test-files works slightly so that
908         we don't need to create a printer object (and hence we need to
909         rework the tests that are testing logging).
910
911         * Scripts/webkitpy/layout_tests/controllers/manager.py:
912         (RunDetails):
913         (RunDetails.__init__):
914         (Manager.run):
915         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
916         (run):
917         (main):
918         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
919         (passing_run):
920         (run_and_capture):
921         (LintTest.test_lint_test_files):
922         (LintTest.test_lint_test_files__errors):
923         (MainTest.test_verbose_in_child_processes):
924
925 2012-12-05  Dirk Pranke  <dpranke@chromium.org>
926
927         nrwt: remove --no-record-results
928         https://bugs.webkit.org/show_bug.cgi?id=104072
929
930         Reviewed by Ojan Vafai.
931
932         The command line flag was only being used in the unit tests and
933         wasn't really needed once we started using a mock filesystem.
934
935         Also, reformat a bunch of long lines ...
936
937         * Scripts/webkitpy/layout_tests/controllers/manager.py:
938         (Manager.run):
939         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
940         (parse_args):
941         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
942         (parse_args):
943         (passing_run):
944         (logging_run):
945         (MainTest.test_repeat_each_iterations_num_tests):
946         (MainTest.test_test_list):
947         (MainTest.test_missing_and_unexpected_results):
948         (MainTest.test_pixel_test_directories):
949         (MainTest.test_missing_and_unexpected_results_with_custom_exit_code):
950         (MainTest.test_crash_with_stderr):
951         (MainTest.test_no_image_failure_with_image_diff):
952         (MainTest.test_crash_log):
953         (MainTest.test_web_process_crash_log):
954         (MainTest.test_exit_after_n_failures_upload):
955         (MainTest.test_results_directory_absolute):
956         (MainTest.test_results_directory_relative):
957         (MainTest.test_reftest_should_not_use_naming_convention_if_not_listed_in_reftestlist):
958         (MainTest.test_additional_expectations):
959         (MainTest.test_output_diffs):
960         (EndToEndTest.test_end_to_end):
961         (EndToEndTest.test_reftest_with_two_notrefs):
962         (RebaselineTest.test_reset_results):
963         (RebaselineTest.test_missing_results):
964         (RebaselineTest.test_new_baseline):
965
966 2012-12-05  Dirk Pranke  <dpranke@chromium.org>
967
968         nrwt: only summarize the results one way
969         https://bugs.webkit.org/show_bug.cgi?id=104064
970
971         Reviewed by Ojan Vafai.
972
973         Change manager.summarize_results so that we always (and only)
974         include both expected and unexpected results. Previously we
975         would summarize the results twice, once with expected results
976         and once without. This made the code much more confusing than
977         it needed to be.
978
979         * Scripts/webkitpy/layout_tests/controllers/manager.py:
980         (summarize_results):
981         (Manager.run):
982         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
983         (ResultSummaryTest.summarized_results):
984         (ResultSummaryTest.test_no_svn_revision):
985         (ResultSummaryTest.test_svn_revision):
986         (ResultSummaryTest.test_summarized_results_wontfix):
987         * Scripts/webkitpy/layout_tests/views/printing.py:
988         (Printer.print_results):
989         (Printer._print_unexpected_results):
990         (Printer._print_unexpected_results.add_result):
991         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
992         (Testprinter.test_print_unexpected_results.get_unexpected_results):
993         (Testprinter):
994
995 2012-12-05  Filip Pizlo  <fpizlo@apple.com>
996
997         DFG profiler should display more information
998         https://bugs.webkit.org/show_bug.cgi?id=104163
999
1000         Reviewed by Gavin Barraclough.
1001
1002         Added the following:
1003         
1004         - Distinguish between source counts and bytecode counts.
1005         
1006         - Add a "full" summary view that shows both kinds of counts, plus inline counts.
1007         
1008         - Add a "source" command to see the source.
1009         
1010         - Add a "bytecode" command to see the bytecode and counts.
1011
1012         * Scripts/display-profiler-output:
1013
1014 2012-12-05  Yong Li  <yoli@rim.com>
1015
1016         [BlackBerry] Build with libjpegturbo
1017         https://bugs.webkit.org/show_bug.cgi?id=104152
1018
1019         Reviewed by Rob Buis.
1020
1021         RIM PR# 196975.
1022         Make sure the right include path for libjpeg is included.
1023
1024         * Scripts/webkitdirs.pm:
1025         (blackberryCMakeArguments):
1026
1027 2012-12-05  Joseph Pecoraro  <pecoraro@apple.com>
1028
1029         Remove stale check in check-for-webkit-framework-include-consistency
1030         https://bugs.webkit.org/show_bug.cgi?id=103775
1031
1032         Reviewed by David Kilzer.
1033
1034         The underlying issue was fixed in r81173.
1035
1036         * Scripts/check-for-webkit-framework-include-consistency:
1037
1038 2012-12-05  Dirk Pranke  <dpranke@chromium.org>
1039
1040         nrwt: simplify the finding of tests to retry
1041         https://bugs.webkit.org/show_bug.cgi?id=104067
1042
1043         Reviewed by Ryosuke Niwa.
1044
1045         I think this makes the code a little clearer; note that
1046         we were no longer using the include_missing flag.
1047
1048         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1049         (Manager.run):
1050         (Manager._failed_test_names):
1051
1052 2012-12-05  Dirk Pranke  <dpranke@chromium.org>
1053
1054         nrwt: remove two unused parameters from a function
1055         https://bugs.webkit.org/show_bug.cgi?id=104059
1056
1057         Reviewed by Ryosuke Niwa.
1058
1059         Also remove an old, stale FIXME.
1060
1061         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1062         (interpret_test_failures):
1063         (summarize_results):
1064         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1065         (ResultSummaryTest.test_interpret_test_failures):
1066
1067 2012-12-05  Dirk Pranke  <dpranke@chromium.org>
1068
1069         nrwt: return result_summaries from LayoutTestRunner.run_tests()
1070         https://bugs.webkit.org/show_bug.cgi?id=104051
1071
1072         Reviewed by Ojan Vafai.
1073
1074         This patch completes the refactoring that makes the result summary      
1075         an object returned from the layout test runner, rather than having      
1076         it passed in and modified. This makes the split of duties between       
1077         the manager and runner clearer and makes the data flow more             
1078         functionally.                                                           
1079
1080         Also clean up some minor lint issues.
1081
1082         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1083         (LayoutTestRunner.__init__):
1084         (LayoutTestRunner.run_tests):
1085         (LayoutTestRunner._mark_interrupted_tests_as_skipped):
1086         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
1087         (FakePrinter.print_expected):
1088         (LockCheckingRunner.__init__):
1089         (LayoutTestRunnerTests._runner):
1090         (LayoutTestRunnerTests._run_tests):
1091         (LayoutTestRunnerTests.test_interrupt_if_at_failure_limits):
1092         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1093         (Manager.__init__):
1094         (Manager.run):
1095         (Manager._run_tests):
1096
1097 2012-12-05  Dirk Pranke  <dpranke@chromium.org>
1098
1099         nrwt: move creation of the resultsummary objects into Manager._run_tests()
1100         https://bugs.webkit.org/show_bug.cgi?id=104048
1101
1102         Reviewed by Ojan Vafai.
1103
1104         This is a preparatory step to making the resultsummary just get
1105         returned from the layout_test_runner; this does most of manager-side
1106         changes.
1107
1108         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1109         (Manager._prepare_lists):
1110         (Manager.run):
1111         (Manager._run_tests):
1112
1113 2012-12-05  Leo Yang  <leoyang@rim.com>
1114
1115         [BlackBerry] Enable CSS_IMAGE_RESOLUTION
1116         https://bugs.webkit.org/show_bug.cgi?id=104132
1117
1118         Reviewed by Yong Li.
1119
1120         * Scripts/webkitperl/FeatureList.pm:
1121
1122 2012-12-05  Filip Pizlo  <fpizlo@apple.com>
1123
1124         JSC profiler should not count executions of op_call_put_result because doing so changes DFG codegen
1125         https://bugs.webkit.org/show_bug.cgi?id=104102
1126
1127         Reviewed by Oliver Hunt.
1128
1129         Modify the profiler to not output counts for op_call_put_result, since there
1130         won't be any. Also fix a few weird bugs, like providing better error reporting
1131         when you type something incorrectly and not reporting counts for slow paths
1132         in the old JIT since those counts are actually not what you think they are
1133         (we don't actually count slow path executions separately).
1134
1135         * Scripts/display-profiler-output:
1136
1137 2012-12-05  Andras Becsi  <andras.becsi@digia.com>
1138
1139         Fix compilation for Qt5.0.0 stable branch.
1140         https://bugs.webkit.org/show_bug.cgi?id=103870
1141
1142         Reviewed by Simon Hausmann.
1143
1144         Fix the use of renamed QWindow functions.
1145         Patch by Andras Becsi <andras.becsi@digia.com>
1146
1147         * MiniBrowser/qt/BrowserWindow.cpp:
1148         (BrowserWindow::BrowserWindow):
1149         (BrowserWindow::onTitleChanged):
1150         * MiniBrowser/qt/raw/View.cpp:
1151         (View::View):
1152
1153 2012-12-05  Jussi Kukkonen  <jussi.kukkonen@intel.com>
1154
1155         [WK2] InjectedBundle should check Intent url for null
1156         https://bugs.webkit.org/show_bug.cgi?id=104117
1157
1158         Reviewed by Kenneth Rohde Christiansen.
1159
1160         WKIntentServiceInfoCopyHref() can return null, we need to check
1161         for that in InjectedBundlePage::registerIntentServiceForFrame()
1162         to avoid crashing.
1163
1164         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1165         (WTR::InjectedBundlePage::registerIntentServiceForFrame):
1166
1167 2012-12-04  Jonathan Dong  <jonathan.dong@torchmobile.com.cn>
1168
1169         Change email address of Jonathan Dong
1170         https://bugs.webkit.org/show_bug.cgi?id=103976
1171
1172         Unreviewed, change my email address from jonathan.dong@torchmobile.com.cn
1173         to jonathan.dong.webkit@gmail.com in committers list.
1174
1175         * Scripts/webkitpy/common/config/committers.py:
1176
1177 2012-12-04  Xiaobo Wang  <xbwang@torchmobile.com.cn>
1178
1179         [BlackBerry] DRT - Tests under "dumpAsText" directory should be dumped as text
1180         https://bugs.webkit.org/show_bug.cgi?id=103986
1181
1182         Reviewed by Rob Buis.
1183
1184         Also move declaration of webSettingTransaction to before any WebSettings
1185         ::setXXX() calls so that it works as expected (commit only once in the
1186         function scope).
1187
1188         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
1189         (shouldDumpAsText):
1190         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
1191
1192 2012-12-04  Filip Pizlo  <fpizlo@apple.com>
1193
1194         display-profiler-output should be able to show source code
1195         https://bugs.webkit.org/show_bug.cgi?id=104073
1196
1197         Reviewed by Oliver Hunt.
1198
1199         Display source code in the summary, using a one-line shortening.
1200
1201         * Scripts/display-profiler-output:
1202
1203 2012-12-04  Filip Pizlo  <fpizlo@apple.com>
1204
1205         display-profiler-output should not use reflective infocation to resolve command names
1206
1207         Rubber stamped by Mark Hahnenberg.
1208
1209         Reflection is amazing, but here it was just kind of a bit much.
1210
1211         * Scripts/display-profiler-output:
1212
1213 2012-12-02  Filip Pizlo  <fpizlo@apple.com>
1214
1215         JSC should be able to report profiling data associated with the IR dumps and disassembly
1216         https://bugs.webkit.org/show_bug.cgi?id=102999
1217
1218         Reviewed by Gavin Barraclough.
1219
1220         Added a tool that allows you to grok the output from JSC's new profiler. Currently,
1221         this still gets confused a bit about the execution counts of a method running
1222         standalone versus a method running inlined, but other than that, it's pretty cool.
1223         See the attached "sampling profiling session" attached to the bug to see it in
1224         action.
1225         
1226         Also had to feed EFL's build system.
1227
1228         * DumpRenderTree/efl/CMakeLists.txt:
1229         * Scripts/display-profiler-output: Added.
1230
1231 2012-12-04  Dirk Pranke  <dpranke@chromium.org>
1232
1233         nrwt: fix total number of tests computed in the result summary
1234         https://bugs.webkit.org/show_bug.cgi?id=104061
1235
1236         Unreviewed, build fix.
1237
1238         One of the recent changes to the resultsummary refactoring caused
1239         us to not include the number of skipped tests in the total number
1240         of tests, throwing off the totals printed in print_one_line_summary().
1241
1242         Unfortunately, given the current state of the code it is difficult
1243         to construct an accurate unit test for this. I have verified the
1244         fix by hand, and will write a test once the remaining refactoring
1245         patches land, at which point it will be trivial to test it.
1246
1247         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1248         (Manager._prepare_lists):
1249
1250 2012-12-04  Dirk Pranke  <dpranke@chromium.org>
1251
1252         nrwt is not returning the exit status properly
1253         https://bugs.webkit.org/show_bug.cgi?id=103830
1254
1255         Unreviewed, build fix.
1256
1257         The fix in r136474 wasn't quite right either, and would return
1258         the correct exceptional status, but not the correct failing status.
1259
1260         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1261
1262 2012-12-04  Dirk Pranke  <dpranke@chromium.org>
1263
1264         nrwt: make paths and test_names passed arguments in Manager._prepare_lists et al
1265         https://bugs.webkit.org/show_bug.cgi?id=104047
1266
1267         Reviewed by Eric Seidel.
1268
1269         The code becomes cleaner if we are just passing values around rather
1270         than hanging them off the manager object, helps move _prepare_lists()
1271         to a pure function, and is needed to eventually make the
1272         result_summary object something returned from runner.run_tests()
1273         (note that two more patches are needed for that to happen).
1274
1275         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1276         (Manager.__init__):
1277         (Manager._http_tests):
1278         (Manager._prepare_lists):
1279         (Manager.needs_servers):
1280         (Manager._set_up_run):
1281         (Manager.run):
1282         (Manager._run_tests):
1283         (Manager._upload_json_files):
1284         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1285         (ManagerTest.test_needs_servers.get_manager):
1286         (ManagerTest.test_needs_servers):
1287         (ManagerTest.integration_test_needs_servers.get_manager):
1288         (ManagerTest.integration_test_needs_servers):
1289         (ManagerTest.test_look_for_new_crash_logs.get_manager):
1290         (ManagerTest):
1291         (ManagerTest.test_look_for_new_crash_logs):
1292         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1293         (JSONLayoutResultsGenerator.__init__):
1294         (JSONLayoutResultsGenerator._get_modifier_char):
1295
1296 2012-12-04  Adam Barth  <abarth@webkit.org>
1297
1298         commit-queue can get stuck with a local commit
1299         https://bugs.webkit.org/show_bug.cgi?id=104032
1300
1301         Reviewed by Dirk Pranke.
1302
1303         Previously the commit-queue would only clean down to HEAD. If the
1304         commit-queue gets interrupted in the middle of a commit (e.g., after
1305         the local commit but before the dcommit), then it can end up with a
1306         patch locally committed. That patch will then prevent the commit-queue
1307         from functioning.
1308
1309         This patch teaches the commit-queue to clean down to the merge base,
1310         which will remove any local commits.
1311
1312         * Scripts/webkitpy/common/checkout/scm/git.py:
1313         (Git.working_directory_is_clean):
1314         (Git.clean_working_directory):
1315         * Scripts/webkitpy/tool/commands/roll_unittest.py:
1316         * Scripts/webkitpy/tool/steps/commit.py:
1317         (Commit._commit_warning):
1318         (Commit.run):
1319
1320 2012-12-04  Dirk Pranke  <dpranke@chromium.org>
1321
1322         nrwt: store only the total number of tests in the result summary
1323         https://bugs.webkit.org/show_bug.cgi?id=103963
1324
1325         Reviewed by Ryosuke Niwa.
1326
1327         The result summary only needs the total number of tests that will
1328         be run (including repetitions) in order to provide the correct stats;
1329         it doesn't actually need to know how many unique tests there are, or
1330         or how many repetitions there are.
1331
1332         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
1333         (LayoutTestRunnerTests._result_summary):
1334         (LayoutTestRunnerTests.test_update_summary_with_result):
1335         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1336         (Manager._prepare_lists):
1337         (Manager.run):
1338         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1339         (ManagerTest.test_look_for_new_crash_logs):
1340         (ResultSummaryTest.get_result_summary):
1341         * Scripts/webkitpy/layout_tests/models/result_summary.py:
1342         (ResultSummary.__init__):
1343         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
1344         (Testprinter.get_result_summary):
1345
1346 2012-12-04  Dirk Pranke  <dpranke@chromium.org>
1347
1348         nrwt: do less work when ctrl-c'ed
1349         https://bugs.webkit.org/show_bug.cgi?id=103961
1350
1351         Reviewed by Ryosuke Niwa.
1352
1353         Do less work when we are ctrl-c'ed, because the statistics aren't
1354         that useful anyway. While we're at it, modify summarize_results
1355         to be aware that we don't always retry results (instead of pretending
1356         that the retry produced the same results the initial run did).
1357
1358         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1359         (summarize_results):
1360         (Manager.run):
1361
1362 2012-12-04  Dirk Pranke  <dpranke@chromium.org>
1363
1364         nrwt: result summaries should not require a list of tests to skip
1365         https://bugs.webkit.org/show_bug.cgi?id=103951
1366
1367         Reviewed by Ryosuke Niwa.
1368
1369         We shouldn't really be passing a list of tests to skip to the
1370         ResultSummary objects; they should be handled like any other
1371         test result as much as possible.
1372
1373         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
1374         (LayoutTestRunnerTests._result_summary):
1375         (LayoutTestRunnerTests.test_update_summary_with_result):
1376         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1377         (Manager._prepare_lists):
1378         (Manager.run):
1379         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1380         (ManagerTest.test_look_for_new_crash_logs):
1381         (ResultSummaryTest.get_result_summary):
1382         * Scripts/webkitpy/layout_tests/models/result_summary.py:
1383         (ResultSummary.__init__):
1384         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1385         (TestExpectations):
1386         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
1387         (Testprinter.get_result_summary):
1388
1389 2012-12-04  Dirk Pranke  <dpranke@chromium.org>
1390
1391         nrwt: derive per-thread, per-worker stats from result summaries
1392         https://bugs.webkit.org/show_bug.cgi?id=103943
1393
1394         Reviewed by Ojan Vafai.
1395
1396         This patch changes the manager and printing code to pull more           
1397         information from the ResultSummary object rather than tracking          
1398         additional statistics on the side. This allows us to consolidate        
1399         a bunch of logic and remove a bunch of free-floating lists and dicts of 
1400         of values. We add the shard_name and worker_name to each TestResult,    
1401         and then modify print_timing_statistics() and upload_json_files()       
1402         to just need the result summaries.                                      
1403
1404         Note that this patch also changes the timing statistics slightly
1405         so that the individual test times are the times to run just the
1406         tests themselves (TestResult.test_run_time) and do not include the
1407         times taken to run the ref tests, compute diffs, etc. The aggregated
1408         per-worker and per-shard statistics still use the total time to
1409         process each test (TestResult.total_run_time).
1410
1411         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1412         (LayoutTestRunner.__init__):
1413         (LayoutTestRunner.run_tests):
1414         (LayoutTestRunner._handle_finished_test_list):
1415         (LayoutTestRunner._handle_finished_test):
1416         (Worker.handle):
1417         (Worker._run_test):
1418         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1419         (summarize_results):
1420         (Manager.run):
1421         (Manager._upload_json_files):
1422         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1423         (ResultSummaryTest.summarized_results):
1424         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1425         (JSONLayoutResultsGenerator.__init__):
1426         (JSONLayoutResultsGenerator._get_test_timing):
1427         * Scripts/webkitpy/layout_tests/models/test_results.py:
1428         (TestResult.__init__):
1429         * Scripts/webkitpy/layout_tests/views/printing.py:
1430         (Printer.print_results):
1431         (Printer._print_timing_statistics):
1432         (Printer):
1433         (Printer._print_worker_statistics):
1434         (Printer._print_aggregate_test_statistics):
1435         (Printer._print_individual_test_times):
1436         (Printer._print_directory_timings):
1437         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
1438         (Testprinter.test_print_unexpected_results.get_unexpected_results):
1439         (Testprinter):
1440
1441 2012-12-04  Adam Barth  <abarth@webkit.org>
1442
1443         Remove obsolete code from webkitpy
1444         https://bugs.webkit.org/show_bug.cgi?id=104029
1445
1446         Reviewed by Eric Seidel.
1447
1448         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1449         (CommitQueueTask.run):
1450         * Scripts/webkitpy/tool/steps/commit.py:
1451         (Commit.options):
1452         * Scripts/webkitpy/tool/steps/options.py:
1453         (Options):
1454
1455 2012-12-04  Jochen Eisinger  <jochen@chromium.org>
1456
1457         [chromium] move WebPreferences and methods for modifying them to the TestRunner library
1458         https://bugs.webkit.org/show_bug.cgi?id=103841
1459
1460         Reviewed by Darin Fisher.
1461
1462         * DumpRenderTree/DumpRenderTree.gypi:
1463         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1464         (DRTTestRunner::DRTTestRunner):
1465         (DRTTestRunner::reset):
1466         * DumpRenderTree/chromium/DRTTestRunner.h:
1467         (DRTTestRunner):
1468         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h: Renamed from Tools/DumpRenderTree/chromium/WebPreferences.h.
1469         (WebKit):
1470         (WebTestRunner):
1471         (WebPreferences):
1472         (WebTestRunner::WebPreferences::WebPreferences):
1473         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1474         (WebTestRunner):
1475         (WebTestDelegate):
1476         (WebTestRunner::WebTestDelegate::localFileToDataURL):
1477         (WebTestRunner::WebTestDelegate::rewriteLayoutTestsURL):
1478         (WebTestRunner::WebTestDelegate::preferences):
1479         (WebTestRunner::WebTestDelegate::applyPreferences):
1480         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1481         (WebTestRunner::TestRunner::TestRunner):
1482         (WebTestRunner::TestRunner::reset):
1483         (WebTestRunner::TestRunner::setUserStyleSheetEnabled):
1484         (WebTestRunner):
1485         (WebTestRunner::TestRunner::setUserStyleSheetLocation):
1486         (WebTestRunner::TestRunner::setAuthorAndUserStylesEnabled):
1487         (WebTestRunner::TestRunner::setPopupBlockingEnabled):
1488         (WebTestRunner::TestRunner::setJavaScriptCanAccessClipboard):
1489         (WebTestRunner::TestRunner::setXSSAuditorEnabled):
1490         (WebTestRunner::TestRunner::setAllowUniversalAccessFromFileURLs):
1491         (WebTestRunner::TestRunner::setAllowFileAccessFromFileURLs):
1492         (WebTestRunner::TestRunner::overridePreference):
1493         (WebTestRunner::TestRunner::setPluginsEnabled):
1494         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1495         (TestRunner):
1496         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp: Renamed from Tools/DumpRenderTree/chromium/WebPreferences.cpp.
1497         (WebTestRunner::WebPreferences::reset):
1498         (WebTestRunner):
1499         (WebTestRunner::WebPreferences::applyTo):
1500         * DumpRenderTree/chromium/TestShell.h:
1501         (TestShell::preferences):
1502         (TestShell):
1503         * DumpRenderTree/chromium/WebViewHost.cpp:
1504         (WebViewHost::localFileToDataURL):
1505         (WebViewHost::rewriteLayoutTestsURL):
1506         (WebViewHost::preferences):
1507         (WebViewHost::applyPreferences):
1508         * DumpRenderTree/chromium/WebViewHost.h:
1509         (WebViewHost):
1510
1511 2012-12-04  Zan Dobersek  <zandobersek@gmail.com>
1512
1513         Many webkitpy unit tests can be run standalone, are executable
1514         https://bugs.webkit.org/show_bug.cgi?id=103900
1515
1516         Reviewed by Eric Seidel.
1517
1518         There's no need anymore to run unit tests in standalone mode as they
1519         are now handled by test-webkitpy in a formidable fashion. This makes
1520         it possible for this patch to remove the following unnecessary bits:
1521         - remove shebang lines from unit test files,
1522         - remove calls to unittest.main(),
1523         - make unit test files non-executable.
1524
1525         * Scripts/webkitpy/common/checkout/diff_parser_unittest.py:
1526         (DiffParserTest.test_git_mnemonicprefix):
1527         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1528         (GitTestWithMock.test_push_local_commits_to_server_without_username_and_with_password):
1529         * Scripts/webkitpy/common/config/build_unittest.py:
1530         (ShouldBuildTest.test_should_build):
1531         * Scripts/webkitpy/common/config/ports_unittest.py:
1532         (DeprecatedPortTest.test_chromium_xvfb_port):
1533         * Scripts/webkitpy/common/find_files_unittest.py:
1534         (TestWinNormalize.test_win):
1535         * Scripts/webkitpy/common/lru_cache_unittest.py:
1536         (LRUCacheTest.test_set_again):
1537         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1538         (test_results_zip_url):
1539         * Scripts/webkitpy/common/net/credentials_unittest.py:
1540         (test_keyring_without_git_repo_nor_keychain):
1541         * Scripts/webkitpy/common/net/omahaproxy_unittest.py:
1542         (OmahaProxyTest.test_get_revisions):
1543         * Scripts/webkitpy/common/net/unittestresults_unittest.py:
1544         * Scripts/webkitpy/common/newstringio_unittest.py:
1545         (NewStringIOTest.test_with):
1546         * Scripts/webkitpy/common/read_checksum_from_png_unittest.py:
1547         (ReadChecksumFromPngTest.test_read_checksum):
1548         * Scripts/webkitpy/common/system/file_lock_integrationtest.py:
1549         * Scripts/webkitpy/common/system/filesystem_mock_unittest.py:
1550         (MockFileSystemTest.test_normpath):
1551         * Scripts/webkitpy/common/system/filesystem_unittest.py:
1552         (RealFileSystemTest.test_sep):
1553         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
1554         (TestPlatformInfo.test_total_bytes_memory):
1555         * Scripts/webkitpy/common/system/zipfileset_unittest.py:
1556         (ZipFileSetTest.test_namelist):
1557         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
1558         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1559         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
1560         (TestResultWriterTest.test_reftest_diff_image):
1561         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1562         (JSONGeneratorTest.test_test_timings_trie):
1563         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1564         (TestExpectationSerializationTests.test_string_whitespace_stripping):
1565         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1566         (KeyCompareTest.test_test_key):
1567         * Scripts/webkitpy/layout_tests/port/builders_unittest.py:
1568         (BuildersTest.test_path_from_name):
1569         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
1570         (ChromiumAndroidTwoPortsTest.test_options_with_two_ports):
1571         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
1572         (ChromiumLinuxPortTest.test_path_to_image_diff):
1573         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
1574         (ChromiumMacPortTest.test_path_to_image_diff):
1575         * Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:
1576         (ChromiumPortLoggingTest.test_check_sys_deps):
1577         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1578         (ChromiumPortLoggingTest.test_check_sys_deps):
1579         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
1580         (ConfigTest.test_default_configuration__scripterror):
1581         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
1582         (DriverTest.test_start_actually_starts):
1583         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
1584         (FactoryTest.test_get_from_builder_name):
1585         * Scripts/webkitpy/layout_tests/port/http_lock_unittest.py:
1586         * Scripts/webkitpy/layout_tests/port/image_diff_unittest.py:
1587         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1588         * Scripts/webkitpy/layout_tests/reftests/extract_reference_link_unittest.py:
1589         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1590         (PortTest.disabled_test_mac_lion):
1591         * Scripts/webkitpy/layout_tests/servers/http_server_integrationtest.py:
1592         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
1593         (VerboseTest.test_log_args):
1594         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
1595         (test_details):
1596         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1597         (TestPerfTestFactory.test_inspector_test):
1598         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1599         (test_parse_args):
1600         * Scripts/webkitpy/style/checker_unittest.py:
1601         * Scripts/webkitpy/style/checkers/changelog_unittest.py:
1602         (ChangeLogCheckerTest.test_no_error):
1603         * Scripts/webkitpy/style/checkers/common_unittest.py:
1604         (TabCheckerTest.test_tab):
1605         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1606         (CppCheckerTest.test_ne):
1607         * Scripts/webkitpy/style/checkers/jsonchecker_unittest.py:
1608         * Scripts/webkitpy/style/checkers/png_unittest.py:
1609         (PNGCheckerTest.test_check):
1610         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1611         * Scripts/webkitpy/style/checkers/text_unittest.py:
1612         (TextCheckerTest.test_init):
1613         * Scripts/webkitpy/style/checkers/watchlist_unittest.py:
1614         * Scripts/webkitpy/style/checkers/xcodeproj_unittest.py:
1615         (XcodeProjectFileCheckerTest.test_detect_development_region):
1616         * Scripts/webkitpy/style/checkers/xml_unittest.py:
1617         (XMLCheckerTest.test_no_error):
1618         * Scripts/webkitpy/style/patchreader_unittest.py:
1619         * Scripts/webkitpy/test/finder_unittest.py:
1620         (FinderTest.test_paths):
1621         * Scripts/webkitpy/test/runner_unittest.py:
1622         (RunnerTest.test_run):
1623         * Scripts/webkitpy/test/skip_unittest.py:
1624         (SkipTest.test_skip_if_true):
1625         * Scripts/webkitpy/thirdparty/__init___unittest.py:
1626         (ThirdpartyTest.test_imports):
1627         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests_unittest.py:
1628         (TestTranslation.test_include_rewriting):
1629         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
1630         (QueueEngineTest.tearDown):
1631         * Scripts/webkitpy/tool/grammar_unittest.py:
1632         (GrammarTest.test_join_with_separators):
1633         * Scripts/webkitpy/tool/mocktool_unittest.py:
1634         (MockOptionsTest.test_kwarg__set):
1635         * Scripts/webkitpy/tool/multicommandtool_unittest.py:
1636         (test_command_help):
1637
1638 2012-12-04  Zan Dobersek  <zandobersek@gmail.com>
1639
1640         Many webkitpy module files are executable, have shebang line
1641         https://bugs.webkit.org/show_bug.cgi?id=103985
1642
1643         Reviewed by Dirk Pranke.
1644
1645         Remove the executable bit from webkitpy module files that are
1646         unnecessarily executable. Remove the shebang line from webkitpy
1647         module files, they are of no use. Only non-third-party files are
1648         changed.
1649
1650         * Scripts/webkitpy/bindings/main.py:
1651         * Scripts/webkitpy/common/config/watchlist:
1652         * Scripts/webkitpy/common/find_files.py:
1653         * Scripts/webkitpy/common/lru_cache.py:
1654         * Scripts/webkitpy/common/multiprocessing_bootstrap.py:
1655         * Scripts/webkitpy/common/net/file_uploader.py:
1656         * Scripts/webkitpy/common/newstringio.py:
1657         * Scripts/webkitpy/common/read_checksum_from_png.py:
1658         * Scripts/webkitpy/common/system/autoinstall.py:
1659         * Scripts/webkitpy/common/system/file_lock.py:
1660         * Scripts/webkitpy/common/system/file_lock_mock.py:
1661         * Scripts/webkitpy/common/version_check.py:
1662         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1663         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1664         * Scripts/webkitpy/layout_tests/models/test_failures.py:
1665         * Scripts/webkitpy/layout_tests/models/test_input.py:
1666         * Scripts/webkitpy/layout_tests/port/__init__.py:
1667         * Scripts/webkitpy/layout_tests/port/base.py:
1668         * Scripts/webkitpy/layout_tests/port/builders.py:
1669         * Scripts/webkitpy/layout_tests/port/chromium.py:
1670         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1671         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1672         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1673         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1674         * Scripts/webkitpy/layout_tests/port/config.py:
1675         * Scripts/webkitpy/layout_tests/port/factory.py:
1676         * Scripts/webkitpy/layout_tests/port/http_lock.py:
1677         * Scripts/webkitpy/layout_tests/port/image_diff.py:
1678         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
1679         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1680         * Scripts/webkitpy/layout_tests/port/server_process.py:
1681         * Scripts/webkitpy/layout_tests/port/test.py:
1682         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1683         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
1684         * Scripts/webkitpy/layout_tests/servers/http_server.py:
1685         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
1686         * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
1687         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
1688         * Scripts/webkitpy/layout_tests/views/printing.py:
1689         * Scripts/webkitpy/performance_tests/perftest.py:
1690         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1691         * Scripts/webkitpy/style/checkers/changelog.py:
1692         * Scripts/webkitpy/style/checkers/cpp.py:
1693         * Scripts/webkitpy/style/checkers/xcodeproj.py:
1694         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
1695         (main): There's no need to run this module in standalone because
1696         it's wrapped by the Tools/Scripts/update-webgl-conformance-tests script.
1697         * Scripts/webkitpy/tool/commands/upload.py:
1698         * Scripts/webkitpy/tool/comments.py:
1699         * Scripts/webkitpy/tool/main.py:
1700
1701 2012-12-04  Ryosuke Niwa  <rniwa@webkit.org>
1702
1703         Add a Chromium Android Release (Perf) to the list of perf. bots.
1704
1705         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
1706
1707 2012-12-04  Zan Dobersek  <zandobersek@gmail.com>
1708
1709         [GTK] Insert the jhbuild wrapper command at the beginning of the command list
1710         https://bugs.webkit.org/show_bug.cgi?id=103991
1711
1712         Reviewed by Martin Robinson.
1713
1714         Insert the Tools/gtk/run-with-jhbuild wrapper at the beginning of the
1715         command that's being formed in multiprocessing bootstrap. The wrapper is
1716         an executable Python script while the command being wrapped perhaps isn't
1717         and therefore requires the Python interpreter to be listed at the beginning
1718         of the command sublist that is then executed by the wrapper.
1719
1720         Specifically, the webkitpy/layout_tests/run_webkit_tests.py module file
1721         is about to lose the executable bit and the Python-signaling shebang line.
1722         The Jhbuild wrapper simply executes the command that's passed, but that errs
1723         in this case unless the Python executable is executed and the module file
1724         is passed to it as an argument.
1725
1726         * Scripts/webkitpy/common/multiprocessing_bootstrap.py:
1727         (run):
1728
1729 2012-12-04  Peter Beverloo  <peter@chromium.org>
1730
1731         Add the Chromium Android Release (Perf) bot
1732         https://bugs.webkit.org/show_bug.cgi?id=103891
1733
1734         Reviewed by Eric Seidel.
1735
1736         Add configuration for the bot itself. It will be triggered by the Chromium
1737         Android Release builder. When running for Android, the DownloadAndPerfTest
1738         factory will also add the OutputAndroidDeviceStatus step.
1739
1740         * BuildSlaveSupport/build.webkit.org-config/config.json:
1741         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1742         (DownloadAndPerfTestFactory.__init__):
1743
1744 2012-12-04  Peter Beverloo  <peter@chromium.org>
1745
1746         [Chromium] The ChromiumAndroidDriver constructor should not rely on adb being available
1747         https://bugs.webkit.org/show_bug.cgi?id=103758
1748
1749         Reviewed by Eric Seidel.
1750
1751         Lazily initialize the adb command parameters rather than initializing it in the
1752         constructor now that there is an assert if adb is not available on the system and
1753         we're not in a Chromium Android checkout.
1754
1755         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1756         (ChromiumAndroidDriver.__init__):
1757         (ChromiumAndroidDriver._push_file_if_needed):
1758         (ChromiumAndroidDriver._run_adb_command):
1759         (ChromiumAndroidDriver.cmd_line):
1760         (ChromiumAndroidDriver._start_once):
1761         (ChromiumAndroidDriver._read_prompt):
1762         (ChromiumAndroidDriver):
1763         (ChromiumAndroidDriver._adb_command):
1764
1765 2012-12-03  Ryosuke Niwa  <rniwa@webkit.org>
1766
1767         Dromaeo should report individual test result
1768         https://bugs.webkit.org/show_bug.cgi?id=99800
1769
1770         Reviewed by Eric Seidel.
1771
1772         Ignore subtest results spit out by Dromaeo tests.
1773
1774         * Scripts/webkitpy/performance_tests/perftest.py:
1775         (PerfTest): Added a line to ignore.
1776         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1777         (MainTest.test_parse_output_with_subtests): Added.
1778
1779 2012-12-03  Zan Dobersek  <zandobersek@gmail.com>
1780
1781         Unreviewed, functionality fix after r136437.
1782
1783         Calling sys.exit actually raises a SystemExit exception that
1784         is then handled in the second block and causes the script to
1785         return an 'exceptional' exit code rather than the code presenting
1786         the number of failed tests.
1787
1788         This is just a temporary fix to get the faultless bots green while
1789         they are unnecessarily red at the moment. The problem and a proper
1790         fix will be properly addressed.
1791
1792         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1793
1794 2012-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
1795
1796         Unreviewed, rolling out r136460.
1797         http://trac.webkit.org/changeset/136460
1798         https://bugs.webkit.org/show_bug.cgi?id=103958
1799
1800         This patch caused compile error when building DumpRenderTree
1801         (Requested by tasak on #webkit).
1802
1803         * Scripts/webkitpy/common/config/build_unittest.py:
1804         (ShouldBuildTest):
1805
1806 2012-12-03  Scott Violet  <sky@chromium.org>
1807
1808         [chromium] Remove linux theme related files and switch to default
1809         https://bugs.webkit.org/show_bug.cgi?id=103897
1810
1811         Reviewed by Darin Fisher.
1812
1813         * Scripts/webkitpy/common/config/build_unittest.py:
1814         (ShouldBuildTest): linux->default
1815
1816 2012-12-03  Roger Fong  <roger_fong@apple.com>
1817
1818         Disable WebKit2 API tests on Apple Windows port.
1819         https://bugs.webkit.org/show_bug.cgi?id=103929.
1820
1821         Reviewed by Timothy Horton.
1822
1823         * Scripts/run-api-tests:
1824         (runTestsBySuite):
1825
1826 2012-12-03  Dirk Pranke  <dpranke@chromium.org>
1827
1828         webkitpy's run_webkit_tests should initialize the printer earlier on
1829         https://bugs.webkit.org/show_bug.cgi?id=103661
1830
1831         Reviewed by Eric Seidel.
1832
1833         Initialize the printer before computing the derived options
1834         from the command line arguments, so that we can safely log from
1835         port methods.
1836
1837         Also clean up a few miscellaneous lint warnings.
1838
1839         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1840         (ChromiumAndroidPort.path_to_adb):
1841         * Scripts/webkitpy/layout_tests/port/mac.py:
1842         (MacPort.default_child_processes):
1843         (MacPort.sample_process):
1844         (MacPort.start_helper):
1845         (MacPort.stop_helper):
1846         (MacPort.nm_command):
1847         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1848         (test_default_child_processes):
1849         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1850         (run):
1851         (_set_up_derived_options):
1852
1853 2012-12-03  Dirk Pranke  <dpranke@chromium.org>
1854
1855         webkitpy: autoinstaller is failing on windows
1856         https://bugs.webkit.org/show_bug.cgi?id=103699
1857
1858         Reviewed by Tony Chang.
1859
1860         Attempt to fix the python autoinstaller to work for pylint on win32
1861         again ... it turns out one of the dependent packages contains
1862         a write-protected test file and windows will choke when it tries to move
1863         it into place. Fortunately we can just delete the file prior to
1864         installing it in the final location, but we have to jump through
1865         a couple of hoops to do so.
1866
1867         Also, make sure that we're flattening nested module names like
1868         "logilab/common" into either safe basenames (logilab_common) or
1869         host-specific subdirs (logilab\common) as needed.
1870
1871         * Scripts/webkitpy/common/system/autoinstall.py:
1872         (AutoInstaller._url_downloaded_path):
1873         (AutoInstaller._install):
1874         (AutoInstaller.install):
1875         * Scripts/webkitpy/thirdparty/__init__.py:
1876         (AutoinstallImportHook._install_pylint):
1877
1878 2012-12-03  Dirk Pranke  <dpranke@chromium.org>
1879
1880         nrwt: clean up exception propagation / handling for interrupts and early exits
1881         https://bugs.webkit.org/show_bug.cgi?id=103830
1882
1883         Reviewed by Ojan Vafai.
1884
1885         The code for propagating early exits out of the test run was
1886         convoluted and hard to follow. By adjusting the WorkerException to
1887         derive from BaseException rather than Exception (which is a fair
1888         way of representing an error that was really unexpected/unrecoverable
1889         anyway) and pushing the TestRunInterruptedException into the
1890         ResultSummary (which is also fair since it was more of a result
1891         than an exception) this allows us to consolidate and clean up
1892         a bunch of the try/catch logic and pass fewer state flags around.
1893
1894         There are no real functional changes to this patch; there's an
1895         API change in that we stop exporting TestRunInterruptedException
1896         and WorkerException out of the Manager, and the existence of the
1897         MessagePool is now completely hidden.
1898
1899         * Scripts/webkitpy/common/message_pool.py:
1900         (WorkerException):
1901         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1902         (LayoutTestRunner.run_tests):
1903         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1904         (summarize_results):
1905         (Manager.run):
1906         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1907         (ResultSummaryTest.summarized_results):
1908         * Scripts/webkitpy/layout_tests/models/result_summary.py:
1909         (ResultSummary.__init__):
1910         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1911         (run):
1912         (main):
1913         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1914         (MainTest.test_exception_raised.of):
1915         (MainTest.test_exception_raised):
1916         (MainTest.test_run_force):
1917         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
1918         (Testprinter.test_print_unexpected_results.get_unexpected_results):
1919         (Testprinter):
1920
1921 2012-12-03  Julien BRIANCEAU   <jbrianceau@nds.com>
1922
1923         Add Qt/SH4 build slave to build.webkit.org
1924         https://bugs.webkit.org/show_bug.cgi?id=103384
1925
1926         Reviewed by Csaba Osztrogonác.
1927
1928         * BuildSlaveSupport/build.webkit.org-config/config.json:
1929
1930 2012-12-03  Alexis Menard  <alexis@webkit.org>
1931
1932         Enable CSS3 background-position offset by default
1933         https://bugs.webkit.org/show_bug.cgi?id=103917
1934
1935         Reviewed by Benjamin Poulain.
1936
1937         Even though each port may enable or not the feature we still need
1938         to pass it at configure time otherwise it will be disabled.
1939
1940         * Scripts/webkitperl/FeatureList.pm:
1941
1942 2012-12-03  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
1943
1944         Unreviewed. Adding myself to committers.py.
1945
1946         * Scripts/webkitpy/common/config/committers.py:
1947
1948 2012-12-03  Laszlo Gombos  <l.gombos@samsung.com>
1949
1950         [CMake] Enable building WebKit2-only build for the EFL port
1951         https://bugs.webkit.org/show_bug.cgi?id=103820
1952
1953         Reviewed by Gyuyoung Kim.
1954
1955         Set ENABLE_WEBKIT2 to OFF if build-webkit was run with --no-webkit2.
1956         Never set ENABLE_WEBKIT in build-webkit. This will simplyfy invoking
1957         cmake directly. Initialize $cmakeArgs to avoid potential
1958         warnings when running the script.
1959
1960         * Scripts/build-webkit:
1961
1962 2012-12-03  Tommy Widenflycht  <tommyw@google.com>
1963
1964         Speech Recognition API: Update SpeechRecognitionEvent to match the specification
1965         https://bugs.webkit.org/show_bug.cgi?id=103407
1966
1967         Reviewed by Kentaro Hara.
1968
1969         Changing the mock to use the new results delivery API.
1970
1971         * DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp:
1972
1973 2012-12-03  Alexis Menard  <alexis@webkit.org>
1974
1975         [Qt] Enable CSS3 background-position offsets by default.
1976         https://bugs.webkit.org/show_bug.cgi?id=103877
1977
1978         Reviewed by Tor Arne Vestbø.
1979
1980         Enable by default CSS3 background-position offsets.
1981
1982         * qmake/mkspecs/features/features.pri:
1983
1984 2012-12-03  KyungTae Kim  <ktf.kim@samsung.com>
1985
1986         [EFL][WK2] Use float variable for zoom levels for MiniBrowser
1987         https://bugs.webkit.org/show_bug.cgi?id=103863
1988
1989         Reviewed by Gyuyoung Kim.
1990
1991         Use float instead of int for zoomLevels variables for a clearer expression
1992
1993         * MiniBrowser/efl/main.c:
1994         (on_key_down):
1995
1996 2012-12-02  KyungTae Kim  <ktf.kim@samsung.com>
1997
1998         [EFL][WK2] Add support for a zoom level setting to MiniBrowser
1999         https://bugs.webkit.org/show_bug.cgi?id=99285
2000
2001         Reviewed by Gyuyoung Kim.
2002
2003          Add support for a zoom level setting to MiniBrowser.
2004          Shortcuts for setting operations are same as common browsers:
2005          Ctrl + '+' to zoom in, Ctrl + '-' to zoom out and Ctrl + '0' to zoom to default.
2006
2007         * MiniBrowser/efl/main.c:
2008         (on_key_down):
2009
2010 2012-12-02  KyungTae Kim  <ktf.kim@samsung.com>
2011
2012         [EFL][WK2] ECORE_GETOPT_VALUE_BOOL need to be used for Eina_Bool
2013         https://bugs.webkit.org/show_bug.cgi?id=103835
2014
2015         Reviewed by Kentaro Hara.
2016
2017         Because legacy_behavior_enabled is Eina_Bool, ECORE_GETOPT_VALUE_BOOL need to be used
2018
2019         * MiniBrowser/efl/main.c:
2020         (elm_main):
2021
2022 2012-12-02  Mike West  <mkwst@chromium.org>
2023
2024         Garden-o-matic shouldn't die when blank JSON results are received.
2025         https://bugs.webkit.org/show_bug.cgi?id=103838
2026
2027         Reviewed by Adam Barth.
2028
2029         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
2030             If the JSONP string doesn't contain '(' or ')', return an empty object.
2031         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
2032             Check that this behavior stays in place.
2033
2034 2012-12-02  Eric Seidel  <eric@webkit.org>
2035
2036         run-perf-tests --profile should use iprofiler instead of instruments on Mac
2037         https://bugs.webkit.org/show_bug.cgi?id=103765
2038
2039         Unreviewed.  Updating the unittests after my previous change.
2040
2041         * Scripts/webkitpy/common/system/profiler_unittest.py:
2042         (ProfilerFactoryTest.test_basic):
2043
2044 2012-12-02  Julie Parent  <jparent@chromium.org>
2045
2046         Remove dead code in flakiness dashboard for obsolete buildDir option
2047         https://bugs.webkit.org/show_bug.cgi?id=103792
2048
2049         Reviewed by Dirk Pranke.
2050
2051         * TestResultServer/static-dashboards/dashboard_base.js:
2052         (initBuilders):
2053
2054 2012-12-02  Dirk Pranke  <dpranke@chromium.org>
2055
2056         nrwt: clean up logic for retrying failed tests a bit
2057         https://bugs.webkit.org/show_bug.cgi?id=103829
2058
2059         Reviewed by Ojan Vafai.
2060
2061         The code for determining when to retry test failures and
2062         show the results.html file was awkward and could stand some
2063         cleaning up. This patch should have no functional changes.
2064
2065         The routine called _get_failures() returned a dict of test names
2066         to failure types, but we only ever used the names, so I've converted
2067         it to return a list (and renamed it); also, the show_results_html()
2068         file was calling that routine to figure out if anything failed, when
2069         the information was already in the result_summary (as either
2070         unexpected_results or total_failures), so we were doing unnecessary work.
2071
2072         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2073         (Manager.__init__):
2074         (Manager.run):
2075         (Manager._run_tests):
2076         (Manager._failed_test_names):
2077         (Manager._copy_results_html_file):
2078
2079 2012-12-02  Dirk Pranke  <dpranke@chromium.org>
2080
2081         nrwt: remove unused methods in manager.py
2082         https://bugs.webkit.org/show_bug.cgi?id=103828
2083
2084         Reviewed by Eric Seidel.
2085
2086         These two methods weren't being called by anything and were no
2087         longer needed.
2088
2089         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2090         (Manager._get_failures):
2091         (Manager._upload_json_files):
2092
2093 2012-12-02  Laszlo Gombos  <l.gombos@samsung.com>
2094
2095         Correct the spelling of the cmakeargs argument
2096         https://bugs.webkit.org/show_bug.cgi?id=103814
2097
2098         Reviewed by Darin Adler.
2099
2100         The script expects cmakeargs (plural), so lets get the
2101         documentation of the script report the same.
2102
2103         * Scripts/build-webkit:
2104
2105 2012-12-02  Mike West  <mkwst@chromium.org>
2106
2107         [gtk] Enable the CSP_NEXT runtime flag.
2108         https://bugs.webkit.org/show_bug.cgi?id=103810
2109
2110         Reviewed by Adam Barth.
2111
2112         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2113         (resetDefaultsToConsistentValues):
2114             Turn on the CSP_NEXT runtime flag when running tests under GTK.
2115
2116 2012-12-02  Eric Seidel  <eric@webkit.org>
2117
2118         run-perf-tests --profile should use iprofiler instead of instruments on Mac
2119         https://bugs.webkit.org/show_bug.cgi?id=103765
2120
2121         Reviewed by Ryosuke Niwa.
2122
2123         Stephanie pointed out that iprofiler is the newer command-line interface
2124         to replace /usr/bin/instruments in Instruments 4 (which according to the
2125         interblags is supported on everything since 10.6.6), so I've moved --profile
2126         to use iprofiler on Mac.
2127
2128         I also made the IProfiler class wait for iprofiler to complete so that
2129         iprofiler won't continue running after run-perf-tests is complete (and
2130         spam over the top of your shell output).
2131
2132         There are a couple of "got-chas" to this approach:
2133         1.  iprofiler will ask for your password the first time you run it, which may
2134             cause your first test to fail.  /usr/bin/instruments doesn't seem to do that.
2135         2.  iprofiler has nice (but kinda awkward for our purposes) support for separate
2136             directory and basename arguments, making IProfiler a somewhat awkward
2137             baseclass of SingleFileOutputProfiler
2138
2139         I suspect we'll iterate from here.  It does seem slightly faster than
2140         /usr/bin/instruments was.
2141
2142         * Scripts/webkitpy/common/system/profiler.py:
2143         (ProfilerFactory.create_profiler):
2144         (IProfiler):
2145         (IProfiler.__init__):
2146         (IProfiler.attach_to_pid):
2147
2148 2012-12-02  Yongjun Zhang  <yongjun_zhang@apple.com>
2149
2150         Need a method to close all idle localstorage databases immediately.
2151         https://bugs.webkit.org/show_bug.cgi?id=103469
2152
2153         Reviewed by David Kilzer.
2154
2155         Add an JS method to TestRunner, to enable testing closing idle local storage databases in
2156         DumpRenderTree layout tests.
2157
2158         * DumpRenderTree/TestRunner.cpp:
2159         (closeIdleLocalStorageDatabasesCallback):
2160         (TestRunner::staticFunctions):
2161         * DumpRenderTree/TestRunner.h:
2162         (TestRunner):
2163         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
2164         (TestRunner::closeIdleLocalStorageDatabases):
2165         * DumpRenderTree/efl/TestRunnerEfl.cpp:
2166         (TestRunner::closeIdleLocalStorageDatabases):
2167         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
2168         (TestRunner::closeIdleLocalStorageDatabases):
2169         * DumpRenderTree/mac/TestRunnerMac.mm:
2170         (TestRunner::closeIdleLocalStorageDatabases):
2171         * DumpRenderTree/win/TestRunnerWin.cpp:
2172         (TestRunner::closeIdleLocalStorageDatabases):
2173         * DumpRenderTree/wx/TestRunnerWx.cpp:
2174         (TestRunner::closeIdleLocalStorageDatabases):
2175
2176 2012-12-02  Yael Aharon  <yael.aharon@intel.com>
2177
2178         [EFL][WK2] MiniBrowser should have a legacy mode
2179         https://bugs.webkit.org/show_bug.cgi?id=103679
2180
2181         Reviewed by Kenneth Rohde Christiansen.
2182
2183         Add an option to start MiniBrowser in legacy mode.
2184
2185         * MiniBrowser/efl/main.c:
2186         (window_create):
2187         (elm_main):
2188
2189 2012-12-02  Sheriff Bot  <webkit.review.bot@gmail.com>
2190
2191         Unreviewed, rolling out r136236.
2192         http://trac.webkit.org/changeset/136236
2193         https://bugs.webkit.org/show_bug.cgi?id=103833
2194
2195         [chromium] Flakey crashes in SpeechRecognitionEvent::emma
2196         during GC. (Requested by mkwst on #webkit).
2197
2198         * DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp:
2199
2200 2012-12-01  Zan Dobersek  <zandobersek@gmail.com>
2201
2202         [XvfbDriver] XvfbDriverTest.test_next_free_display is flaky on builders using XvfbDriver
2203         https://bugs.webkit.org/show_bug.cgi?id=103806
2204
2205         Reviewed by Dirk Pranke.
2206
2207         There are occasional mishaps on builders where XvfbDriver doesn't properly
2208         clean up the Xvfb instance it was managing so the related guard lock files
2209         are still existing when the webkitpy unit tests are run. This can cause failures
2210         in XvfbDriverTest.test_next_free_display as the test tries to acquire displays
2211         with a specific number but is unable to due to the stale locks.
2212
2213         The solution to this is to use MockFileLock when inside unit test. This is achievable
2214         by creating a file lock through the SystemHost instance connected to the Port object,
2215         the latter available to the Driver.
2216
2217         * Scripts/webkitpy/common/system/file_lock_mock.py:
2218         (MockFileLock.acquire_lock): Return True to signal lock acquiring succeeded.
2219         (MockFileLock.release_lock): Return True to signal lock releasing succeeded.
2220         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
2221         (XvfbDriver._next_free_display): Create the file lock through a mockable way.
2222         * Scripts/webkitpy/layout_tests/port/xvfbdriver_unittest.py:
2223         (XvfbDriverTest.test_next_free_display): Enable back the unit test.
2224
2225 2012-12-01  Zan Dobersek  <zandobersek@gmail.com>
2226
2227         [GTK] A11y tests in WK2 report badly-formatted AX roles
2228         https://bugs.webkit.org/show_bug.cgi?id=102947
2229
2230         Reviewed by Xan Lopez.
2231
2232         As in DRT, convert the ATK accessibility roles to corresponding AXRoles.
2233         These are expected in both tests and their baselines.
2234
2235         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2236         (WTR::roleToString):
2237         (WTR):
2238         (WTR::AccessibilityUIElement::role):
2239
2240 2012-11-30  Mike West  <mkwst@chromium.org>
2241
2242         CSP 1.1: Make the CSP_NEXT flag runtime enabled.
2243         https://bugs.webkit.org/show_bug.cgi?id=103652
2244
2245         Reviewed by Adam Barth.
2246
2247         Ensures that the new SecurityPolicy runtime flag is enabled for Chromium's tests.
2248
2249         * DumpRenderTree/chromium/TestShell.cpp:
2250         (TestShell::TestShell):
2251
2252 2012-11-30  Roger Fong  <roger_fong@apple.com>
2253
2254         Unreviewed. Removed temporary debugging change from DRT (r136300).
2255
2256         * DumpRenderTree/win/DumpRenderTree.cpp:
2257         (dump):
2258
2259 2012-11-30  Roger Fong  <roger_fong@apple.com>
2260
2261         Unreviewed. Temporary change to DRT for debugging purposes.
2262
2263         * DumpRenderTree/win/DumpRenderTree.cpp:
2264         (dump):
2265
2266 2012-11-29  Tommy Widenflycht  <tommyw@google.com>
2267
2268         Speech Recognition API: Update SpeechRecognitionEvent to match the specification
2269         https://bugs.webkit.org/show_bug.cgi?id=103407
2270
2271         Reviewed by Adam Barth.
2272
2273         Changing the mock to use the new results delivery API.
2274
2275         * DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp:
2276
2277 2012-11-30  Simon Hausmann  <simon.hausmann@digia.com>, Pierre Rossi  <pierre.rossi@digia.com>
2278
2279         [Qt] Separate Qt WebKit into Qt WebKit and Qt WebKit Widgets
2280         https://bugs.webkit.org/show_bug.cgi?id=99314
2281
2282         Reviewed by Tor Arne Vestbø.
2283
2284         This big change separates QtWebKit into QtWebKit and QtWebKitWidgets as
2285         shared libraries.
2286
2287         It's a big refactoring that mostly involves moving WebCore dependent
2288         code into QtWebKit and accessing it through exported QWebFrameAdapter
2289         and QWebPageAdapter classes.
2290
2291         * DumpRenderTree/qt/DumpRenderTree.pro:
2292         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2293         (WebCore::DumpRenderTree::dump): Adapt to internal API changes.
2294         * MiniBrowser/qt/MiniBrowser.pro:
2295         * Scripts/webkitpy/style/checker.py: Adapt Qt exceptions to new paths.
2296         * Scripts/webkitpy/style/checker_unittest.py:
2297         (GlobalVariablesTest.test_path_rules_specifier):
2298         * WebKitTestRunner/InjectedBundle/Target.pri:
2299         * qmake/mkspecs/features/default_post.prf:
2300         * qmake/mkspecs/features/webkit_modules.prf:
2301         * qmake/mkspecs/modules/webkitwidgets.prf: Removed.
2302
2303 2012-11-30  Csaba Osztrogonác  <ossy@webkit.org>
2304
2305         [Qt] Unreviewed trivial fix.
2306
2307         Add empty.cpp back, it was removed accidentally by r129092.
2308
2309         * qmake/config.tests/gccdepends/empty.cpp: Added.
2310
2311 2012-11-30  Tor Arne Vestbø  <tor.arne.vestbo@digia.com>
2312
2313         [Qt] Add support for prepare_docs and generate_docs
2314
2315         Follow-up to changes in Qt in how documentation is built.
2316
2317         Reviewed by Simon Hausmann.
2318
2319         * qmake/mkspecs/features/default_post.prf:
2320
2321 2012-11-30  Zan Dobersek  <zandobersek@gmail.com>
2322
2323         Finally remove webkitpy.common.system.deprecated_logging
2324         https://bugs.webkit.org/show_bug.cgi?id=103624
2325
2326         Reviewed by Adam Barth.
2327
2328         Remove the deprecated logging module and its unit tests now that such logging is not
2329         used anymore in webkitpy.
2330
2331         The tee and OutputTee classes are moved into a new module, webkitpy.common.system.outputtee.
2332         The tee class is renamed to Tee to conform with the usual guidelines.
2333
2334         Only unit test for the Tee class is currently provided as the OutputTee is not currently
2335         using the webkitpy Filesystem abstraction that would make its functionality testable.
2336
2337         * Scripts/webkitpy/common/system/executive.py: tee (now Tee) is now in a new module.
2338         (Executive.run_and_throw_if_fail):
2339         * Scripts/webkitpy/common/system/outputtee.py: Renamed from Tools/Scripts/webkitpy/common/system/deprecated_logging.py.
2340         (Tee):
2341         (Tee.__init__):
2342         (Tee.write):
2343         (OutputTee):
2344         (OutputTee.__init__):
2345         (OutputTee.add_log):
2346         (OutputTee.remove_log):
2347         (OutputTee._open_log_file):
2348         (OutputTee._tee_outputs_to_files):
2349         * Scripts/webkitpy/common/system/outputtee_unittest.py: Renamed from Tools/Scripts/webkitpy/common/system/deprecated_logging_unittest.py.
2350         (SimpleTeeTest):
2351         (SimpleTeeTest.test_simple_tee):
2352         * Scripts/webkitpy/tool/bot/queueengine.py: OutputTee is now in a new module.
2353         * Scripts/webkitpy/webkitpy.pyproj: Remove the deprecated_logging module and related unit test file.
2354
2355 2012-11-30  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
2356
2357         [EFL][WK2] Add support for PlatformWebView::simulateRightClick() in TestWebKitAPI
2358         https://bugs.webkit.org/show_bug.cgi?id=103634
2359
2360         Reviewed by Gyuyoung Kim.
2361
2362         Add support for PlatformWebView::simulateRightClick() and enable
2363         WebKit2 API test HitTestResultNodeHandle.
2364
2365         * TestWebKitAPI/PlatformEfl.cmake:
2366         * TestWebKitAPI/efl/PlatformWebView.cpp:
2367         (TestWebKitAPI::PlatformWebView::simulateRightClick):
2368         (TestWebKitAPI):
2369
2370 2012-11-30  Mihai Maerean  <mmaerean@adobe.com>
2371
2372         [CSSRegions] when WebKit uses V8, there should be a single variable to store if the CSS Regions feature is enabled
2373         https://bugs.webkit.org/show_bug.cgi?id=101192
2374
2375         Reviewed by Hajime Morita.
2376
2377         Removed the CSS Regions flag in Settings and switched to using the new flag I have added in RuntimeEnabledFeatures.
2378
2379         Tests: No new tests because there is no functional change.
2380
2381         * DumpRenderTree/chromium/WebPreferences.cpp:
2382         (WebPreferences::applyTo):
2383
2384 2012-11-29  Rafael Weinstein  <rafaelw@chromium.org>
2385
2386         [HTMLTemplateElement] Add feature flag
2387         https://bugs.webkit.org/show_bug.cgi?id=103694
2388
2389         Reviewed by Adam Barth.
2390
2391         This flag will guard the implementation of the HTMLTemplateElement.
2392         http://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/templates/index.html
2393
2394         * Scripts/webkitperl/FeatureList.pm:
2395
2396 2012-11-29  Dirk Pranke  <dpranke@chromium.org>
2397
2398         Ignore errors when removing directories on win32 during autoinstall
2399         https://bugs.webkit.org/show_bug.cgi?id=103699
2400
2401         Unreviewed, build fix.
2402
2403         I think this will work on win32; if not, I'll have to actually
2404         reproduce this :). The problem is that the logilab files
2405         appear to contain a write-protected file, and deleting those
2406         is problematic on windows.
2407
2408         * Scripts/webkitpy/common/system/autoinstall.py:
2409         (AutoInstaller._install):
2410         (AutoInstaller.install):
2411
2412 2012-11-29  Dirk Pranke  <dpranke@chromium.org>
2413
2414         webkitpy: autoinstaller is failing on windows
2415         https://bugs.webkit.org/show_bug.cgi?id=103699
2416
2417         Unreviewed, build fix.
2418
2419         We're attempting to create directories with forward slashes in them;
2420         this is a no-no on windows.
2421
2422         * Scripts/webkitpy/common/system/autoinstall.py:
2423         (AutoInstaller._create_scratch_directory_inner):
2424
2425 2012-11-29  Dirk Pranke  <dpranke@chromium.org>
2426
2427         Fix python unit tests after r136158 (android port tests failing)
2428         https://bugs.webkit.org/show_bug.cgi?id=103581
2429
2430         Unreviewed, build fix.
2431
2432         The unit tests apparently weren't ran for this patch; we failed
2433         to update the mock executive calls out to adb to determine various
2434         aspects of the environment, and were failing to create drivers.
2435
2436         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
2437         (MockRunCommand.mock_run_command_fn):
2438
2439 2012-11-29  Sheriff Bot  <webkit.review.bot@gmail.com>
2440
2441         Unreviewed, rolling out r136175 and r136177.
2442         http://trac.webkit.org/changeset/136175
2443         http://trac.webkit.org/changeset/136177
2444         https://bugs.webkit.org/show_bug.cgi?id=103683
2445
2446         Changes did not correct Windows build. (Requested by bfulgham
2447         on #webkit).
2448
2449         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:
2450
2451 2012-11-29  Brent Fulgham  <bfulgham@webkit.org>
2452
2453         [Windows, WinCairo] Unreviewed build correction. Correct debug
2454         build case on build machine.
2455
2456         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:
2457
2458 2012-11-29  Brent Fulgham  <bfulgham@webkit.org>
2459
2460         [Windows, WinCairo] Unreviewed build correction. Hide the
2461         unexported 'notSolidColor' symbol when testing against
2462         the BitmapImage class to avoid having to deal with a
2463         debug-only symbol in the Windows export definition file.
2464
2465         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp: 
2466
2467 2012-11-29  Peter Beverloo  <peter@chromium.org>
2468
2469         run-perf-tests --chromium-android should not require adb in my path
2470         https://bugs.webkit.org/show_bug.cgi?id=103581
2471
2472         Reviewed by Eric Seidel.
2473
2474         Remove the need to have "adb" available in the path for Layout and Performance
2475         tests. We'll determine the versions of the "adb" version in path (if any) and
2476         the one provided in the Chromium Android checkout. Unless the "adb" available
2477         in the path is newer, the provided version will be used.
2478
2479         Some other minor nits addressed:
2480         - The path_to_forwarder/path_to_md5sum should not be in the "private overrides"
2481           section, as they're not overriding anything and are used by the driver.
2482         - Make _restart_adb_as_root slightly more robust by waiting for the device
2483           to come back online regardless of the output.
2484
2485         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2486         (ChromiumAndroidPort.__init__):
2487         (ChromiumAndroidPort.check_build):
2488         (ChromiumAndroidPort.path_to_adb):
2489         (ChromiumAndroidPort):
2490         (ChromiumAndroidPort.path_to_forwarder):
2491         (ChromiumAndroidPort.path_to_md5sum):
2492         (ChromiumAndroidPort._path_to_helper):
2493         (ChromiumAndroidPort._determine_adb_version):
2494         (ChromiumAndroidPort._get_devices):
2495         (ChromiumAndroidDriver.__init__):
2496         (ChromiumAndroidDriver._setup_md5sum_and_push_data_if_needed):
2497         (ChromiumAndroidDriver._push_executable):
2498         (ChromiumAndroidDriver._restart_adb_as_root):
2499
2500 2012-11-29  Martin Robinson  <mrobinson@igalia.com>
2501
2502         [GTK] [WebKit2] Embed the HTTP authentication dialog into the WebView
2503         https://bugs.webkit.org/show_bug.cgi?id=103277
2504
2505         Reviewed by Carlos Garcia Campos.
2506
2507         Skip the new WebKit2GtkAuthenticationDialog files so that they are not processed
2508         during gtkdoc generation.
2509
2510         * gtk/generate-gtkdoc:
2511         (get_webkit2_options):
2512
2513 2012-11-29  Eric Seidel  <eric@webkit.org>
2514
2515         run-perf-tests --chromium-android fails due to Skia INFO logging
2516         https://bugs.webkit.org/show_bug.cgi?id=103585
2517
2518         Reviewed by Adam Barth.
2519
2520         Ignore all INFO logging from Chromium code.
2521         Also added some basic testing of the ignored-stderr lines code.
2522
2523         * Scripts/webkitpy/performance_tests/perftest.py:
2524         (PerfTest):
2525         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2526         (MainTest.test_ignored_stderr_lines):
2527
2528 2012-11-29  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
2529
2530         [EFL][WK2] Add support for PlatformWebView::simulateMouseMove() in TestWebKitAPI
2531         https://bugs.webkit.org/show_bug.cgi?id=103252
2532
2533         Reviewed by Kenneth Rohde Christiansen.
2534
2535         Add support for PlatformWebView::simulateMouseMove() and enable
2536         WebKit2 API test MouseMoveAfterCrash.
2537
2538         * TestWebKitAPI/PlatformEfl.cmake: Enable MouseMoveAfterCrash API
2539         test.
2540         * TestWebKitAPI/efl/PlatformWebView.cpp:
2541         (TestWebKitAPI::onWebProcessCrashed): Handle 'webprocess,crashed' signal
2542         to prevent loading an error page since the test case is reloading actual
2543         page after web process has terminated and recovered.
2544         (TestWebKitAPI):
2545         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2546         (TestWebKitAPI::PlatformWebView::simulateMouseMove): Implemented.
2547
2548 2012-11-29  Andras Becsi  <andras.becsi@digia.com>
2549
2550         [Qt] Fix installation of QtWebProcess binary
2551         https://bugs.webkit.org/show_bug.cgi?id=101735
2552
2553         Reviewed by Simon Hausmann.
2554
2555         Add config test to detect the availability of support
2556         for "program executables" in Qt (libexec).
2557
2558         This test can be removed after the Qt5 release.
2559
2560         * Tools.pro:
2561         * qmake/mkspecs/features/features.prf:
2562         * qmake/config.tests/libexecdir/libexecdir.cpp:
2563         * qmake/config.tests/libexecdir/libexecdir.pro:
2564
2565 2012-11-29  Eric Seidel  <eric@webkit.org>
2566
2567         run-perf-tests does not work when the layout test directory does not exist
2568         https://bugs.webkit.org/show_bug.cgi?id=103572
2569
2570         Reviewed by Ryosuke Niwa.
2571
2572         Make sure that Profiler() calls maybe_make_directory for the output_dir
2573         before ever using it.  It's a little awkward to create the directory
2574         from the constructor, but its simplest that way as the various subclasses
2575         all use the directory at different times.
2576
2577         Since this required having a filesystem in Profiler (and I didn't want
2578         to grab inside Workspace to get one), I just made Profiler expect a
2579         SystemHost instead of a separate filesystem, executive and workspace.
2580
2581         * Scripts/webkitpy/common/system/profiler.py:
2582         (ProfilerFactory.create_profiler):
2583         (Profiler.__init__):
2584         (SingleFileOutputProfiler.__init__):
2585         (GooglePProf.__init__):
2586         (GooglePProf.profile_after_exit):
2587         (Instruments.__init__):
2588         (Instruments.attach_to_pid):
2589         * Scripts/webkitpy/common/system/profiler_unittest.py:
2590         (ProfilerFactoryTest.test_basic):
2591
2592 2012-11-28  Vivek Galatage  <vivek.vg@samsung.com>
2593
2594         Adding secondary email id
2595         https://bugs.webkit.org/show_bug.cgi?id=103594
2596
2597         Unreviewed. Adding secondary email.
2598
2599         * Scripts/webkitpy/common/config/committers.py:
2600
2601 2012-11-28  Kent Tamura  <tkent@chromium.org>
2602
2603         garden-o-matic: Use indeterminate <progress> in the status area
2604         https://bugs.webkit.org/show_bug.cgi?id=103494
2605
2606         Reviewed by Adam Barth.
2607
2608         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
2609         Wrap the "Processing..." message with an indeterminate progress bar.
2610         We keep the message as a fallback content.
2611         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
2612         Follow the above change.
2613
2614 2012-11-28  Nima Ghanavatian  <nghanavatian@rim.com>
2615
2616         Adding Nima Ghanavatian to committers.py
2617         https://bugs.webkit.org/show_bug.cgi?id=103533
2618
2619         Reviewed by Rob Buis.
2620
2621         Adding myself to committers.py as a Committer.
2622
2623         * Scripts/webkitpy/common/config/committers.py:
2624
2625 2012-11-28  peavo@outlook.com  <peavo@outlook.com>
2626
2627         [WinCairo] Crash when requesting favicon.
2628         https://bugs.webkit.org/show_bug.cgi?id=102689
2629
2630         Reviewed by Brent Fulgham.
2631
2632         * TestWebKitAPI/Tests/WebCore/win: Added.
2633         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp: Added.
2634         (TestWebKitAPI::BitmapImageTest::BitmapImageTest): Allocate frame in constructor.
2635         (TestWebKitAPI::BitmapImageTest::frameCount): Override frameCount() method.
2636         (TestWebKitAPI::TEST): Added new test.
2637         * TestWebKitAPI/config.h: Make sure defines are correct for WinCairo.
2638        * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added new test.
2639
2640 2012-11-28  Eric Seidel  <eric@webkit.org>
2641
2642         run-perf-tests should have a --profile option for easy profiling
2643         https://bugs.webkit.org/show_bug.cgi?id=99517
2644
2645         Reviewed by Adam Barth.
2646
2647         This is a very basic implementation which works on Mac and Linux
2648         and makes it trivial for anyone to profile a PerformanceTest.
2649
2650         Currently it's not "hard" to profile a PerformanceTest
2651         but lowering the barriers to entry here allows all of us to focus
2652         less on the tools and more on the code.
2653
2654         This also paves the way for adding easy mobile-profiling (e.g. chromium-android)
2655         which is actually "hard", and this option will make much easier.
2656
2657         * Scripts/webkitpy/common/system/profiler.py: Added.
2658         (ProfilerFactory):
2659         (ProfilerFactory.create_profiler):
2660         (Profiler):
2661         (Profiler.__init__):
2662         (Profiler.adjusted_environment):
2663         (Profiler.attach_to_pid):
2664         (Profiler.did_stop):
2665         (SingleFileOutputProfiler):
2666         (SingleFileOutputProfiler.__init__):
2667         (GooglePProf):
2668         (GooglePProf.__init__):
2669         (GooglePProf.adjusted_environment):
2670         (GooglePProf.did_stop):
2671         (Instruments):
2672         (Instruments.__init__):
2673         (Instruments.attach_to_pid):
2674         * Scripts/webkitpy/common/system/profiler_unittest.py: Added.
2675         (ProfilerFactoryTest):
2676         (ProfilerFactoryTest.test_basic):
2677         * Scripts/webkitpy/layout_tests/port/driver.py:
2678         (Driver.__init__):
2679         (Driver._start):
2680         (Driver.stop):
2681         (Driver.cmd_line):
2682         * Scripts/webkitpy/performance_tests/perftest.py:
2683         (PerfTest.parse_output):
2684         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2685         (MainTest.test_parse_output):
2686         (MainTest.test_parse_output_with_failing_line):
2687         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2688         (PerfTestsRunner._parse_args):
2689         (PerfTestsRunner.run):
2690
2691 2012-11-28  Zan Dobersek  <zandobersek@gmail.com>
2692
2693         Remove deprecated logging usage from QueueEngine
2694         https://bugs.webkit.org/show_bug.cgi?id=103532
2695
2696         Reviewed by Dirk Pranke.
2697
2698         Replace usage of deprecated logging in webkitpy.tool.bot.queueengine with
2699         logging through the Logger object. The unit test is modified to reflect
2700         these changes.
2701
2702         After these changes the deprecated logging (i.e. logging to stderr) is not
2703         used anymore through webkitpy and can be removed.
2704
2705         * Scripts/webkitpy/tool/bot/queueengine.py:
2706         (QueueEngine.exit_after_handled_error):
2707         (QueueEngine.run):
2708         (QueueEngine._stopping):
2709         (QueueEngine._sleep):
2710         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
2711         (QueueEngineTest._run_engine):
2712
2713 2012-11-28  Nate Chapin  <japhet@chromium.org>
2714
2715         Move empty loading to DocumentLoader, simplify FrameLoader::init()
2716         https://bugs.webkit.org/show_bug.cgi?id=101512
2717
2718         Reviewed by Adam Barth.
2719
2720         * DumpRenderTree/chromium/WebViewHost.cpp:
2721         (WebViewHost::updateForCommittedLoad): This function doesn't play nicely with empty urls and incorrectly
2722             interprets them as a non-empty load. This change is required for
2723              http/tests/navigation/new-window-redirect-history.html to continue to pass in chromium.
2724         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp: This test relies on a callback that no longer
2725              is sent for about:blank loads.  Hook into didFinishLoadForFrame() instead.
2726         (TestWebKitAPI::didFinishLoadForFrame):
2727         (TestWebKitAPI::TEST):
2728
2729 2012-11-28  Sadrul Habib Chowdhury  <sadrul@chromium.org>
2730
2731         [chromium] Allow plugins to opt-in to receive synthetic mouse events out of touch events.
2732         https://bugs.webkit.org/show_bug.cgi?id=103092
2733
2734         Reviewed by Tony Chang.
2735
2736         Update the test web-plugin to be able to opt-in to receive synthesized mouse events created
2737         from touch events.
2738
2739         * DumpRenderTree/chromium/TestWebPlugin.cpp:
2740         (parseTouchEventRequestType):
2741         (TestWebPlugin::TestWebPlugin):
2742         (TestWebPlugin::initialize):
2743         * DumpRenderTree/chromium/TestWebPlugin.h:
2744         (TestWebPlugin):
2745
2746 2012-11-28  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
2747
2748         [EFL][WK2] Add support for PlatformWebView::simulateSpacebarKeyPress() in TestWebKitAPI
2749         https://bugs.webkit.org/show_bug.cgi?id=103123
2750
2751         Reviewed by Laszlo Gombos.
2752
2753         Add support for PlatformWebView::simulateSpacebarKeyPress().
2754         This functionality is needed by WebKit2 API test MouseMoveAfterCrash
2755         which is going to be unskipped in bug #103252.
2756
2757         * TestWebKitAPI/efl/PlatformUtilities.cpp:
2758         (TestWebKitAPI::Util::sleep):
2759         * TestWebKitAPI/efl/PlatformWebView.cpp: Use usleep() instead of
2760         sleep().
2761         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
2762         (TestWebKitAPI):
2763
2764 2012-11-28  Yael Aharon  <yael.aharon@intel.com>
2765
2766         Minor cleanup in TestInvocation
2767         https://bugs.webkit.org/show_bug.cgi?id=103512
2768
2769         Reviewed by Kenneth Rohde Christiansen.
2770
2771         Remove a function declaration that is not defined and not used.
2772         Fix spelling error in m_webProcessIsUnresponsive.
2773
2774         * WebKitTestRunner/TestInvocation.cpp:
2775         (WTR::TestInvocation::TestInvocation):
2776         (WTR::TestInvocation::invoke):
2777         * WebKitTestRunner/TestInvocation.h:
2778         (TestInvocation):
2779         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
2780         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
2781         * WebKitTestRunner/qt/TestInvocationQt.cpp:
2782         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
2783
2784 2012-11-28  Thiago Marcos P. Santos  <thiago.santos@intel.com>
2785
2786         Unreviewed. Use my personal email as bugzilla email.
2787
2788         * Scripts/webkitpy/common/config/committers.py:
2789
2790 2012-11-28  Thiago Marcos P. Santos  <thiago.santos@intel.com>
2791
2792         Unreviewed. Adding myself to committers.py.
2793
2794         * Scripts/webkitpy/common/config/committers.py:
2795
2796 2012-11-26  Andrey Adaikin  <aandrey@chromium.org>
2797
2798         Unreviewed. Adding myself to committers.py.
2799
2800         * Scripts/webkitpy/common/config/committers.py:
2801
2802 2012-11-28  Tommy Widenflycht  <tommyw@google.com>
2803
2804         Add basic implementation for MediaStreamAudioDestinationNode
2805         https://bugs.webkit.org/show_bug.cgi?id=101815
2806
2807         Reviewed by Chris Rogers.
2808
2809         Adds a bit of code that exercises the WebKit API.
2810
2811         * DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp:
2812         (MockWebMediaStreamSourceConsumer):
2813         (MockWebMediaStreamSourceConsumer::~MockWebMediaStreamSourceConsumer):
2814         (MockWebMediaStreamCenter::didCreateMediaStream):
2815
2816 2012-11-28  Matt Falkenhagen  <falken@chromium.org>
2817
2818         Unreviewed. Adding myself to committers list.
2819
2820         * Scripts/webkitpy/common/config/committers.py:
2821
2822 2012-11-27  Li Yin  <li.yin@intel.com>
2823
2824         Unreviewed. Adding myself to committers list.
2825
2826         * Scripts/webkitpy/common/config/committers.py:
2827
2828 2012-11-27  Christophe Dumez  <christophe.dumez@intel.com>
2829
2830         Unreviewed. Adding myself to committers.py.
2831
2832         * Scripts/webkitpy/common/config/committers.py:
2833
2834 2012-11-27  Vivek Galatage  <vivek.vg@samsung.com>
2835
2836         Unreviewd. Adding myself to committers list.
2837
2838         * Scripts/webkitpy/common/config/committers.py:
2839
2840 2012-11-27  Tony Chang  <tony@chromium.org>
2841
2842         Bring back partytime!
2843         https://bugs.webkit.org/show_bug.cgi?id=103466
2844
2845         Reviewed by Adam Barth.
2846
2847         "code 404, message Unknown function images/partytime_gif" since we didn't
2848         allow .gif or .png files to be served.
2849
2850         * Scripts/webkitpy/tool/servers/gardeningserver.py:
2851         (GardeningHTTPRequestHandler):
2852
2853 2012-11-27  Adam Barth  <abarth@webkit.org>
2854
2855         run-perf-tests fails on Android because of stderr output
2856         https://bugs.webkit.org/show_bug.cgi?id=103462
2857
2858         Reviewed by Ryosuke Niwa.
2859
2860         The chromium-android port produces some stderr output that causes
2861         run-perf-tests to get sad and not record the results of the performance
2862         test. This patch teaches run-perf-test to ignore this output much in
2863         the same way that it currently ignores some stdout messages.
2864
2865         * Scripts/webkitpy/performance_tests/perftest.py:
2866         (PerfTest.run):
2867         (PerfTest._should_ignore_line):
2868         (PerfTest):
2869         (PerfTest._should_ignore_line_in_stderr):
2870         (PerfTest._filter_stderr):
2871         (PerfTest._should_ignore_line_in_parser_test_result):
2872
2873 2012-11-27  Tony Chang  <tony@chromium.org>
2874
2875         Fix garden-o-matic for non-chromium ports
2876         https://bugs.webkit.org/show_bug.cgi?id=103458
2877
2878         Reviewed by Adam Barth.
2879
2880         I was getting a 403 error when trying to select any non-chromium port.
2881
2882         * Scripts/webkitpy/tool/servers/reflectionhandler.py:
2883         (ReflectionHandler._handle_request): Use the path without query params.
2884
2885 2012-11-27  Yael Aharon  <yael.aharon@intel.com>
2886
2887         [EFL][WK2] 3D pixel tests are failing
2888         https://bugs.webkit.org/show_bug.cgi?id=102833
2889
2890         Reviewed by Kenneth Rohde Christiansen.
2891
2892         Generate a snapshot of the view in the UI process instead of the web process.
2893         We have to use Texture Mapper in order to correctly paint 3D transforms etc.
2894
2895         * WebKitTestRunner/TestInvocation.h:
2896         (TestInvocation):
2897         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
2898         (WTR::writeFunction):
2899         (WTR::paintRepaintRectOverlay):
2900         (WTR):
2901         (WTR::TestInvocation::forceRepaintDoneCallback):
2902         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
2903         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2904         (WTR::PlatformWebView::windowSnapshotImage):
2905
2906 2012-11-27  Adam Barth  <abarth@webkit.org>
2907
2908         Make it possible to run performance tests on Chromium Android
2909         https://bugs.webkit.org/show_bug.cgi?id=103268
2910
2911         Reviewed by Ryosuke Niwa.
2912
2913         Based on a patch by Peter Beverloo.
2914
2915         This patch (almost) makes it possible to run WebKit performance tests
2916         on the Chromium port for Android. There are a few things I had to do
2917         in order to make this happen:
2918
2919         1) The worker number when creating a driver for a port is zero-based
2920            for layout tests and elsewhere. Android uses this to determine
2921            which device it has to run on, so make it zero based for performance
2922            tests as well.
2923
2924         2) Tests aren't available on the Android device, so we start an HTTP
2925            server that serves the tests to the device or emulator.
2926
2927         The one shortcoming of this patch is that chromium-android produces
2928         some stderr output that confuses run-perf-tests. I'll address that
2929         issue in a subsequent CL. This patch also depends on
2930         https://codereview.chromium.org/11416182 in order to work.
2931
2932         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2933         (ChromiumAndroidPort.start_http_server):
2934         (ChromiumAndroidDriver._command_from_driver_input):
2935         * Scripts/webkitpy/performance_tests/perftest.py:
2936         (ReplayPerfTest.prepare):
2937         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2938         (PerfTestsRunner.__init__):
2939         (PerfTestsRunner._parse_args):
2940         (PerfTestsRunner._start_servers):
2941         (PerfTestsRunner):
2942         (PerfTestsRunner._stop_servers):
2943         (PerfTestsRunner.run):
2944         (PerfTestsRunner._run_tests_set):
2945
2946 2012-11-27  Zan Dobersek  <zandobersek@gmail.com>
2947
2948         Remove use of deprecated logging from webkitpy.common and webkitpy.layout_tests
2949         https://bugs.webkit.org/show_bug.cgi?id=103408
2950
2951         Reviewed by Dirk Pranke.
2952
2953         Remove the use of the deprecated log and error methods by replacing them with
2954         logging through Python's logging.Logger objects.
2955
2956         This patch covers such changes in webkitpy.common and webkitpy.layout_tests and also
2957         updates any affected unit test.
2958
2959         * Scripts/webkitpy/common/checkout/changelog.py:
2960         (ChangeLogEntry._parse_entry):
2961         * Scripts/webkitpy/common/checkout/checkout.py:
2962         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
2963         (CheckoutTest.test_apply_patch):
2964         * Scripts/webkitpy/common/checkout/deps_mock.py:
2965         (MockDEPS.write_variable):
2966         * Scripts/webkitpy/common/checkout/scm/detection.py:
2967         (SCMDetector.default_scm):
2968         * Scripts/webkitpy/common/checkout/scm/detection_unittest.py:
2969         (SCMDetectorTest.test_detect_scm_system):
2970         * Scripts/webkitpy/common/checkout/scm/git.py:
2971         (Git._check_git_architecture):
2972         (Git._commit_on_branch):
2973         * Scripts/webkitpy/common/checkout/scm/scm.py:
2974         (SCM.ensure_clean_working_directory):
2975         (SCM.ensure_no_local_commits):
2976         (SCM.will.commit_locally_with_message):
2977         * Scripts/webkitpy/common/checkout/scm/svn.py:
2978         (SVN.apply_reverse_diff):
2979         * Scripts/webkitpy/common/net/bugzilla/attachment.py:
2980         (Attachment._validate_flag_value):
2981         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2982         (Bugzilla._fetch_bug_page):
2983         (Bugzilla.bug_id_for_attachment_id):
2984         (Bugzilla.authenticate):
2985         (Bugzilla._commit_queue_flag):
2986         (Bugzilla.add_attachment_to_bug):
2987         (Bugzilla.add_patch_to_bug):
2988         (Bugzilla.create_bug):
2989         (Bugzilla.clear_attachment_flags):
2990         (Bugzilla.set_flag_on_attachment):
2991         (Bugzilla.obsolete_attachment):
2992         (Bugzilla.add_cc_to_bug):
2993         (Bugzilla.post_comment_to_bug):
2994         (Bugzilla.close_bug_as_fixed):
2995         (Bugzilla.reassign_bug):
2996         (reopen_bug):
2997         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
2998         (MockBugzilla.create_bug):
2999         (MockBugzilla.reassign_bug):
3000         (MockBugzilla.set_flag_on_attachment):
3001         (MockBugzilla.post_comment_to_bug):
3002         (MockBugzilla.add_attachment_to_bug):
3003         (MockBugzilla.add_patch_to_bug):
3004         (MockBugzilla.reopen_bug):
3005         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
3006         (test_add_cc_to_bug):
3007         (_assert_reopen):
3008         (test_reopen_bug):
3009         * Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:
3010         (MockBuilder.force_build):
3011         * Scripts/webkitpy/common/net/credentials.py:
3012         (Credentials._run_security_tool):
3013         * Scripts/webkitpy/common/net/credentials_unittest.py:
3014         (_assert_security_call):
3015         * Scripts/webkitpy/common/net/irc/irc_mock.py:
3016         (MockIRC.post):
3017         (MockIRC.disconnect):
3018         * Scripts/webkitpy/common/net/irc/ircproxy.py:
3019         (IRCProxy.__init__):
3020         (IRCProxy.disconnect):
3021         * Scripts/webkitpy/common/net/irc/ircproxy_unittest.py:
3022         (IRCProxyTest.test_trivial):
3023         * Scripts/webkitpy/common/net/layouttestresults.py:
3024         (ORWTResultsHTMLParser._failures_from_fail_row):
3025         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3026         (test_failures_from_fail_row):
3027         * Scripts/webkitpy/common/net/networktransaction.py:
3028         * Scripts/webkitpy/common/net/resultsjsonparser.py:
3029         (JSONTestResult._tokenize):
3030         (JSONTestResult._failure_types_from_actual_result):
3031         * Scripts/webkitpy/common/net/statusserver.py:
3032         (StatusServer.update_status):
3033         (StatusServer.update_svn_revision):
3034         * Scripts/webkitpy/common/net/statusserver_mock.py:
3035         (MockStatusServer.release_work_item):
3036         (MockStatusServer.update_work_items):
3037         (MockStatusServer.submit_to_ews):
3038         (MockStatusServer.update_status):
3039         * Scripts/webkitpy/common/net/unittestresults.py:
3040         (UnitTestResults.results_from_string):
3041         * Scripts/webkitpy/common/system/executive_mock.py:
3042         (MockExecutive.running_pids):
3043         (MockExecutive.run_and_throw_if_fail):
3044         (MockExecutive.run_command):
3045         (MockExecutive.popen):
3046         * Scripts/webkitpy/common/system/user_mock.py:
3047         (MockUser.confirm):
3048         (MockUser.open_url):
3049         * Scripts/webkitpy/common/system/workspace_unittest.py:
3050         (WorkspaceTest.test_create_zip):
3051         (WorkspaceTest.test_create_zip_exception):
3052         * Scripts/webkitpy/common/watchlist/watchlist_mock.py:
3053         (MockWatchList.determine_cc_and_messages):
3054         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
3055         (ChromiumWinTest.test_setup_environ_for_server_register_cygwin):
3056         * Scripts/webkitpy/layout_tests/port/efl_unittest.py:
3057         (EflPortTest.test_show_results_html_file):
3058         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
3059         (GtkPortTest.test_show_results_html_file):
3060         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3061         (test_show_results_html_file):
3062         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3063         (test_build_driver):
3064         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
3065         (QtPortTest.test_show_results_html_file):
3066         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
3067         (WinPortTest.test_show_results_html_file):
3068         * Scripts/webkitpy/layout_tests/port/xvfbdriver_unittest.py:
3069         (XvfbDriverTest.assertDriverStartSuccessful):
3070         (XvfbDriverTest.test_start_no_pixel_tests):
3071         (XvfbDriverTest.test_start_pixel_tests):
3072         (XvfbDriverTest.test_start_arbitrary_worker_number):
3073         (XvfbDriverTest.test_start_next_worker):
3074         (XvfbDriverTest.test_stop):
3075         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
3076         (TestLayoutTestApacheHttpd.test_start_cmd):
3077         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3078         (test_run_test_pause_before_testing):
3079         (test_run_memory_test):
3080         (_test_run_with_json_output):
3081         (test_run_respects_no_results):
3082         (test_run_generates_and_show_results_page):
3083         (test_run_respects_no_show_results):
3084         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
3085         (FeedersTest.test_commit_queue_feeder):
3086         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3087         (FlakyTestReporterTest.test_create_bug_for_flaky_test):
3088         (test_report_flaky_tests_creating_bug):
3089         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
3090         (IRCCommandTest.test_rollout_updates_working_copy):
3091         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
3092         (IRCBotTest.test_exception_during_command):
3093         (IRCBotTest.test_hi):
3094         (IRCBotTest.test_help):
3095         (IRCBotTest.test_restart):
3096         (IRCBotTest.test_rollout):
3097         (IRCBotTest.test_revert):
3098         (IRCBotTest.test_roll_chromium_deps):
3099         (IRCBotTest.test_roll_chromium_deps_to_lkgr):
3100         (IRCBotTest.test_multi_rollout):
3101         (IRCBotTest.test_rollout_with_r_in_svn_revision):
3102         (IRCBotTest.test_multi_rollout_with_r_in_svn_revision):
3103         (IRCBotTest.test_rollout_bananas):
3104         (IRCBotTest.test_rollout_invalidate_revision):
3105         (IRCBotTest.test_rollout_invalidate_reason):
3106         (test_multi_rollout_invalidate_reason):
3107         (test_rollout_no_reason):
3108         (test_multi_rollout_no_reason):
3109         * Scripts/webkitpy/tool/bot/sheriff_unittest.py:
3110         (SheriffTest.test_post_blame_comment_on_bug):
3111         * Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py:
3112         (ApplyWatchListLocalTest.test_args_parsing):
3113         (test_args_parsing_with_bug):
3114         * Scripts/webkitpy/tool/commands/download_unittest.py:
3115         (test_land_cowboy):
3116         (test_check_style):
3117         (test_create_rollout):
3118         (test_create_rollout_resolved):
3119         (test_rollout):
3120         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3121         (AbstractEarlyWarningSystemTest.test_failing_tests_message):
3122         (EarlyWarningSytemTest._default_expected_logs):
3123         (EarlyWarningSytemTest._test_builder_ews):
3124         (EarlyWarningSytemTest._test_testing_ews):
3125         * Scripts/webkitpy/tool/commands/openbugs_unittest.py:
3126         (OpenBugsTest.test_args_parsing):
3127         * Scripts/webkitpy/tool/commands/queries_unittest.py:
3128         (QueryCommandsTest.test_bugs_to_commit):
3129         (QueryCommandsTest.test_patches_in_commit_queue):
3130         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3131         (FeederQueueTest.test_feeder_queue):
3132         (AbstractPatchQueueTest.test_next_patch):
3133         (AbstractPatchQueueTest.test_upload_results_archive_for_patch):
3134         (CommitQueueTest.test_commit_queue):
3135         (test_commit_queue_failure):
3136         (test_commit_queue_failure_with_failing_tests):
3137         (test_rollout):
3138         (test_rollout_lands):
3139         (test_auto_retry):
3140         (test_manual_reject_during_processing):
3141         (test_report_flaky_tests):
3142         (StyleQueueTest.test_style_queue_with_style_exception):
3143         (test_style_queue_with_watch_list_exception):
3144         * Scripts/webkitpy/tool/commands/queuestest.py:
3145         (QueuesTest._default_begin_work_queue_logs):
3146         * Scripts/webkitpy/tool/commands/roll_unittest.py:
3147         (RollCommandsTest.test_update_chromium_deps):
3148         * Scripts/webkitpy/tool/commands/upload_unittest.py:
3149         (UploadCommandsTest.test_assign_to_committer):
3150         (test_post):
3151         (test_attach_to_bug):
3152         (test_attach_to_bug_no_description_or_comment):
3153         (test_land_safely):
3154         (test_prepare):
3155         (test_upload):
3156         (test_mark_bug_fixed):
3157         * Scripts/webkitpy/tool/steps/applywatchlist_unittest.py:
3158         (ApplyWatchListTest.test_apply_watch_list_local):
3159         * Scripts/webkitpy/tool/steps/commit_unittest.py:
3160         (CommitTest._test_check_test_expectations):
3161         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
3162         (RunTestsTest.test_webkit_run_unit_tests):
3163         * Scripts/webkitpy/tool/steps/steps_unittest.py:
3164         (StepsTest._assert_step_output_with_bug):
3165         (StepsTest._assert_post_diff_output_for_bug):
3166         (StepsTest.test_post_diff):
3167         (StepsTest.test_post_diff_for_commit):
3168         (StepsTest.test_ensure_bug_is_open_and_assigned):
3169         (StepsTest.test_runtests_args):
3170         * Scripts/webkitpy/tool/steps/suggestreviewers_unittest.py:
3171         (SuggestReviewersTest.test_basic):
3172         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
3173         (ValidateChangeLogsTest._assert_start_line_produces_output):
3174
3175 2012-11-27  Pratik Solanki  <psolanki@apple.com>
3176
3177         objc/objc-runtime.h does not exist on all PLATFORM(MAC)
3178         https://bugs.webkit.org/show_bug.cgi?id=101780
3179
3180         Reviewed by Brent Fulgham.
3181
3182         Clean up header includes so we don't include objc/objc-runtime.h.
3183
3184         * DumpRenderTree/mac/DumpRenderTree.mm:
3185         * DumpRenderTree/mac/ObjCPlugin.m:
3186         * TestWebKitAPI/mac/InstanceMethodSwizzler.h:
3187         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
3188
3189 2012-11-27  Marja Hölttä  <marja@chromium.org>
3190
3191         Add callbacks to the FrameLoaderClient when a resource is requested
3192         https://bugs.webkit.org/show_bug.cgi?id=92761
3193
3194         Reviewed by Adam Barth.
3195
3196         In Chromium, when an extension script cancels a network
3197         request (which happens out of process), we'd like to
3198         notify content scripts running on the current page about
3199         which elements failed to load because the requests were
3200         cancelled (as opposed to e.g. the network request just
3201         didn't work). Since the resource request itself does not
3202         carry any information what DOM element is was made for,
3203         currently a content script has to search the DOM tree and
3204         guess which requests will be cancelled by its counter
3205         part. By adding these callbacks, the embedder can make
3206         this connection explictly.
3207
3208         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3209         (DRTTestRunner::DRTTestRunner):
3210         (DRTTestRunner::dumpResourceRequestCallbacks):
3211         (DRTTestRunner::reset):
3212         * DumpRenderTree/chromium/DRTTestRunner.h:
3213         (DRTTestRunner):
3214         (DRTTestRunner::setShouldDumpResourceRequestCallbacks):
3215         (DRTTestRunner::shouldDumpResourceRequestCallbacks):
3216         * DumpRenderTree/chromium/TestShell.h:
3217         (TestShell::shouldDumpResourceRequestCallbacks):
3218         * DumpRenderTree/chromium/WebViewHost.cpp:
3219         (WebViewHost::willRequestResource):
3220         * DumpRenderTree/chromium/WebViewHost.h:
3221         (WebViewHost):
3222
3223 2012-11-27  Víctor Manuel Jáquez Leal  <vjaquez@igalia.com>
3224
3225         [GStreamer] Verify if GStreamer was previously initialized
3226         https://bugs.webkit.org/show_bug.cgi?id=103151
3227
3228         Reviewed by Philippe Normand.
3229
3230         This patch adds the gst_init() in GtkLauncher, so we can add the
3231         GStreamer options in the command line through
3232         gst_init_get_option_group().
3233
3234         This approach is not valid for MiniBrowser because it uses WebKit2,
3235         where the GStreamer backend lives in the web process, which is
3236         different from the UI process.
3237
3238         * GNUmakefile.am:
3239         * GtkLauncher/main.c:
3240         (main):
3241
3242 2012-11-27  Andras Becsi  <andras.becsi@digia.com>
3243
3244         [Qt] Fix the build with new Qt5 hash
3245         https://bugs.webkit.org/show_bug.cgi?id=103406
3246
3247         Reviewed by Csaba Osztrogonác.
3248
3249         Remove references to deprecated QApplication::GuiServer which
3250         has been removed, and use QStyleFactory::create instead of
3251         instantiating a QWindowsStyle directly since it is about to
3252         become an internal class.
3253
3254         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
3255         (main):
3256         * QtTestBrowser/qttestbrowser.cpp:
3257         (LauncherApplication::LauncherApplication):
3258         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
3259         (WTR::InjectedBundle::platformInitialize):
3260
3261 2012-11-27  Sadrul Habib Chowdhury  <sadrul@chromium.org>
3262
3263         [style] Add a style-check for enum-member names
3264         https://bugs.webkit.org/show_bug.cgi?id=103157
3265
3266         Reviewed by Daniel Bates.
3267
3268         * Scripts/webkitpy/style/checkers/cpp.py:
3269         (_EnumState):
3270         (_EnumState.__init__):
3271         (_EnumState.process_clean_line):
3272         (check_enum_casing):
3273         (check_style):
3274         (process_line):
3275         (_process_lines):
3276         (CppChecker):
3277         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3278         (NoNonVirtualDestructorsTest.test_enum_casing):
3279         (NoNonVirtualDestructorsTest.test_internal_braces.Foo):
3280
3281 2012-11-26  Ryuan Choi  <ryuan.choi@gmail.com>
3282
3283         [EFL][jhbuild] Disable unnecessary options of elementary module
3284         https://bugs.webkit.org/show_bug.cgi?id=103360
3285
3286         Reviewed by Gyuyoung Kim.
3287
3288         When jhbuild configures elementary, unnecessary options may be enabled by
3289         user installed modules and it causes build break.
3290
3291         * efl/jhbuild.modules:
3292         Added --disable-emap --disable-ethumb --disable-eweather to elementary.
3293
3294 2012-11-26  Varun Jain  <varunjain@chromium.org>
3295
3296         LongPress and LongTap gestures should start drag/drop and open context menu respectively.
3297         https://bugs.webkit.org/show_bug.cgi?id=101545
3298
3299         Reviewed by Antonio Gomes.
3300
3301         For LongPress, we simulate drag by sending a mouse down and mouse drag
3302         events. If a drag is not started (because maybe there is no draggable
3303         element), then we show context menu instead (which is the current
3304         behavior for LongPress). For LongTap, we use the existing functions that
3305         LongPress uses to summon the context menu. LongPress initiated drag and
3306         drop can be enabled/disabled by the platform using the Setting
3307         touchDragDropEnabled which is disabled by default.
3308
3309         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
3310         (WebTestRunner):
3311         (WebTestRunner::EventSender::EventSender):
3312         (WebTestRunner::EventSender::gestureLongTap):
3313         (WebTestRunner::EventSender::gestureEvent):
3314         * DumpRenderTree/chromium/TestRunner/src/EventSender.h:
3315         (EventSender):
3316         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3317         (WebTestRunner::TestRunner::TestRunner):
3318         (WebTestRunner::TestRunner::setTouchDragDropEnabled):
3319         (WebTestRunner):
3320         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3321         (TestRunner):
3322
3323 2012-11-26  Christophe Dumez  <christophe.dumez@intel.com>
3324
3325         [EFL][WK2] Add setting to enable / disable HTML5 local storage functionality
3326         https://bugs.webkit.org/show_bug.cgi?id=103224
3327
3328         Reviewed by Laszlo Gombos.
3329
3330         Add --local-storage command line argument to MiniBrowser to
3331         explicitely disable HTML5 local storage functionality. This
3332         is useful for testing purposes.
3333
3334         * MiniBrowser/efl/main.c:
3335         (window_create):
3336         (elm_main):
3337
3338 2012-11-26  Zan Dobersek  <zandobersek@gmail.com>
3339
3340         Remove use of deprecated logging from most of webkitpy.tool
3341         https://bugs.webkit.org/show_bug.cgi?id=103180
3342
3343         Reviewed by Dirk Pranke.
3344
3345         Remove calls to log and error methods of the deprecated_logging module, replacing them
3346         by using Python's Logger objects. This patch covers the switch in all of webkitpy.tool
3347         except the QueueEngine.
3348
3349         Unit tests are adjusted for these changes, moving output from expected stderr to expected logs.
3350
3351         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3352         (MockCommitQueue.run_command):
3353         (MockCommitQueue.command_passed):
3354         (MockCommitQueue.command_failed):
3355         (MockCommitQueue.report_flaky_tests):
3356         (MockCommitQueue.archive_last_test_results):
3357         (CommitQueueTaskTest._run_through_task):
3358         (CommitQueueTaskTest.test_success_case):
3359         (test_fast_success_case):
3360         (test_clean_failure):
3361         (test_update_failure):
3362         (test_apply_failure):
3363         (test_validate_changelog_failure):
3364         (test_build_failure):
3365         (test_red_build_failure):
3366         (test_flaky_test_failure):
3367         (test_failed_archive):
3368         (test_double_flaky_test_failure):
3369         (test_test_failure):
3370         (test_red_test_failure):
3371         (test_very_red_tree_retry):
3372         (test_red_tree_patch_rejection):
3373         (test_land_failure):
3374         * Scripts/webkitpy/tool/bot/feeders.py:
3375         (CommitQueueFeeder._update_work_items):
3376         (EWSFeeder.feed):
3377         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
3378         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
3379         (LayoutTestResultsReader.archive):
3380         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
3381         (test_archive_last_layout_test_results):
3382         * Scripts/webkitpy/tool/bot/sheriff.py:
3383         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
3384         (AbstractSequencedCommand.execute):
3385         * Scripts/webkitpy/tool/commands/commandtest.py:
3386         (CommandsTest.assert_execute_outputs):
3387         * Scripts/webkitpy/tool/commands/download.py:
3388         (AbstractPatchProcessingCommand._process_patch.execute):
3389         (ProcessBugsMixin._fetch_list_of_patches_to_process):
3390         (ProcessURLsMixin._fetch_list_of_patches_to_process):
3391         (AbstractRolloutPrepCommand._commit_info):
3392         * Scripts/webkitpy/tool/commands/download_unittest.py:
3393         (AbstractRolloutPrepCommandTest.test_commit_info):
3394         (DownloadCommandsTest.test_build):
3395         (DownloadCommandsTest.test_build_and_test):
3396         (test_apply_attachment):
3397         (test_apply_from_bug):
3398         (test_apply_watch_list):
3399         (test_land):
3400         (test_land_red_builders):
3401         (test_check_style):
3402         (test_build_attachment):
3403         (test_land_attachment):
3404         (test_land_from_bug):
3405         (test_land_from_url):
3406         (test_prepare_rollout):
3407         (test_create_rollout):
3408         (test_create_rollout_resolved):
3409         (test_rollout):
3410         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3411         (AbstractEarlyWarningSystem.handle_script_error.does):
3412         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3413         (EarlyWarningSytemTest._default_expected_stderr):
3414         (EarlyWarningSytemTest._default_expected_logs):
3415         (EarlyWarningSytemTest._test_testing_ews):
3416         * Scripts/webkitpy/tool/commands/openbugs.py:
3417         (OpenBugs.execute):
3418         * Scripts/webkitpy/tool/commands/openbugs_unittest.py:
3419         (OpenBugsTest.test_args_parsing):
3420         * Scripts/webkitpy/tool/commands/perfalizer.py:
3421         (Perfalizer.handle_unexpected_error):
3422         * Scripts/webkitpy/tool/commands/queries.py:
3423         (PatchesInCommitQueue.execute):
3424         (PatchesToCommitQueue._needs_commit_queue):
3425         * Scripts/webkitpy/tool/commands/queries_unittest.py:
3426         (QueryCommandsTest.test_bugs_to_commit):
3427         (QueryCommandsTest.test_patches_in_commit_queue):
3428         (QueryCommandsTest.test_patches_to_commit_queue):
3429         * Scripts/webkitpy/tool/commands/queues.py:
3430         (AbstractQueue._cc_watchers):
3431         (AbstractQueue.begin_work_queue):
3432         (FeederQueue.handle_unexpected_error):
3433         (CommitQueue.handle_script_error):
3434         (AbstractReviewQueue.handle_unexpected_error):
3435         (AbstractReviewQueue.handle_script_error):
3436         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3437         (test_auto_retry):
3438         * Scripts/webkitpy/tool/commands/queuestest.py:
3439         (QueuesTest.assert_outputs):
3440         (QueuesTest._default_begin_work_queue_stderr):
3441         (QueuesTest):
3442         (QueuesTest._default_begin_work_queue_logs):
3443         (QueuesTest.assert_queue_outputs):
3444         * Scripts/webkitpy/tool/commands/roll_unittest.py:
3445         (RollCommandsTest.test_update_chromium_deps):
3446         (test_update_chromium_deps_older_revision):
3447         * Scripts/webkitpy/tool/commands/sheriffbot.py:
3448         (SheriffBot.handle_unexpected_error):
3449         * Scripts/webkitpy/tool/commands/stepsequence.py:
3450         (StepSequence.run_and_handle_errors):
3451         * Scripts/webkitpy/tool/commands/upload.py:
3452         (AssignToCommitter._assign_bug_to_last_patch_attacher):
3453         (AbstractPatchUploadingCommand._prepare_state):
3454         (PostCommits.execute):
3455         (MarkBugFixed._determine_bug_id_and_svn_revision):
3456         (MarkBugFixed.execute):
3457         (CreateBug.create_bug_from_commit):
3458         (CreateBug.execute):
3459         * Scripts/webkitpy/tool/commands/upload_unittest.py:
3460         (test_obsolete_attachments):
3461         (test_land_safely):
3462         (test_mark_bug_fixed):
3463         * Scripts/webkitpy/tool/multicommandtool.py:
3464         (Command.check_arguments_and_execute):
3465         (MultiCommandTool.main):
3466         * Scripts/webkitpy/tool/multicommandtool_unittest.py:
3467         (CommandTest.test_required_arguments):
3468         * Scripts/webkitpy/tool/steps/addsvnmimetypeforpng.py:
3469         (AddSvnMimetypeForPng.run):
3470         * Scripts/webkitpy/tool/steps/applypatch.py:
3471         (ApplyPatch.run):
3472         * Scripts/webkitpy/tool/steps/build.py:
3473         (Build.run):
3474         * Scripts/webkitpy/tool/steps/checkstyle.py:
3475         * Scripts/webkitpy/tool/steps/closebug.py:
3476         (CloseBug.run):
3477         * Scripts/webkitpy/tool/steps/closebugforlanddiff.py:
3478         (CloseBugForLandDiff.run):
3479         * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
3480         (CloseBugForLandDiffTest.test_empty_state):
3481         * Scripts/webkitpy/tool/steps/commit.py:
3482         (Commit.run):
3483         * Scripts/webkitpy/tool/steps/commit_unittest.py:
3484         (CommitTest._test_check_test_expectations):
3485         * Scripts/webkitpy/tool/steps/ensurelocalcommitifneeded.py:
3486         (EnsureLocalCommitIfNeeded.run):
3487         * Scripts/webkitpy/tool/steps/obsoletepatches.py:
3488         (ObsoletePatches.run):
3489         * Scripts/webkitpy/tool/steps/preparechangelog.py:
3490         (PrepareChangeLog.run):
3491         * Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
3492         (ReopenBugAfterRollout.run):
3493         * Scripts/webkitpy/tool/steps/runtests.py:
3494         (RunTests.run):
3495         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
3496         (RunTestsTest.test_webkit_run_unit_tests):
3497         * Scripts/webkitpy/tool/steps/steps_unittest.py:
3498         (StepsTest.test_update_step):
3499         (StepsTest.test_runtests_args):
3500         * Scripts/webkitpy/tool/steps/update.py:
3501         (Update.run):
3502         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
3503         (UpdateChangeLogsWithReviewerTest.test_guess_reviewer_from_bug):
3504         (UpdateChangeLogsWithReviewerTest.test_guess_reviewer_from_multipatch_bug):
3505         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
3506         (UpdateChangeLogsWithReviewer._guess_reviewer_from_bug):
3507         (UpdateChangeLogsWithReviewer.run):
3508         * Scripts/webkitpy/tool/steps/updatechromiumdeps.py:
3509         (UpdateChromiumDEPS._validate_revisions):
3510         (UpdateChromiumDEPS.run):
3511         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
3512         (ValidateChangeLogs._check_changelog_diff):
3513         (ValidateChangeLogs.run):
3514         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
3515         (ValidateChangeLogsTest._assert_start_line_produces_output):
3516         * Scripts/webkitpy/tool/steps/validatereviewer.py:
3517         (ValidateReviewer.run):
3518
3519 2012-11-26  Zan Dobersek  <zandobersek@gmail.com>
3520
3521         Coverage testing in webkitpy should omit some paths
3522         https://bugs.webkit.org/show_bug.cgi?id=103267
3523
3524         Reviewed by Dirk Pranke.
3525
3526         Omit testing coverage of any file under /usr directory and any file
3527         that is of third party origin and was autoinstalled.
3528
3529         * Scripts/webkitpy/test/main.py:
3530         (Tester._run_tests):
3531
3532 2012-11-26  Jaehun Lim  <ljaehun.lim@samsung.com>
3533
3534         Text Autosizing: Add Text Autosizing APIs for WK2
3535         https://bugs.webkit.org/show_bug.cgi?id=100633
3536
3537         Reviewed by Sam Weinig.
3538
3539         Add test cases for Text Autosizing in WKPreferences.
3540
3541         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
3542         (TestWebKitAPI::TEST):
3543
3544 2012-11-26  Pierre Rossi  <pierre.rossi@gmail.com>
3545
3546         [Qt] REGRESSION(r135575): It made all tests assert
3547         https://bugs.webkit.org/show_bug.cgi?id=103169
3548
3549         Reviewed by Simon Hausmann.
3550
3551         This fixes another regression introduced in r135515:
3552         initializeWebKitQt shouldn't implicitely call initializeWebCoreQt
3553         since it can be called from WebKit2 to initialize QStyle for testing.
3554         This would then lead to things such as PlatformStrategies being
3555         initialized twice.
3556
3557         * DumpRenderTree/qt/DumpRenderTreeQt.cpp: Also propagate the change to DRT this time.
3558         (WebCore::DumpRenderTree::DumpRenderTree):
3559
3560 2012-11-24  Zan Dobersek  <zandobersek@gmail.com>
3561
3562         Add the --order option to NRWT
3563         https://bugs.webkit.org/show_bug.cgi?id=102229
3564
3565         Reviewed by Dirk Pranke.
3566
3567         The --order option controls in what order the gathered tests will be run.
3568         There are 3 options:
3569         - natural, the tests are sorted in natural order,
3570         - random, the tests are sorted in random order,
3571         - none, the tests are kept in the order in which they were specified through
3572         arguments or the test list.
3573
3574         The natural option is the default one and maintains the current behavior.
3575
3576         The none option is primarily intended to be used with the --test-list option,
3577         with the test list file expected to list specific test names.
3578         When a directory is specified as one of the paths from under which tests should
3579         be gathered and the none option is used, that path will expand to all the tests
3580         under it, with these tests sorted in the natural order.
3581
3582         Using --order=random duplicated the behavior of the --randomize-order option, so
3583         the latter is removed.
3584
3585         This patch also incorporates the change with which makes it is possible to specify
3586         a test via arguments or the test list multiple tests and then have the test run
3587         that many times.
3588
3589         * Scripts/webkitpy/common/find_files.py:
3590         (find): Accept an optional sorting key that is used to sort files found in the directories
3591         that the given paths specify.
3592         (_normalized_find): Both paths that are then searched for the tests and the tests that
3593         were found are now kept in lists. This makes it possible to run a test multiple times
3594         by specifying it multiple times through arguments or the test list file.
3595         (_normalized_find.sort_by_directory_key):
3596         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
3597         (LayoutTestFinder.find_tests): Keep the paths where we should search for tests in a list.
3598         (LayoutTestFinder.skip_tests): Subtracting from a set of paths is necessary.
3599         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
3600         (LayoutTestRunner.__init__): The Sharder class no longer needs a test path separator.
3601         (Sharder.__init__): Ditto.
3602         (Sharder._resize_shards):
3603         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
3604         (SharderTests.get_shards): Modify the Shader initializing as required.
3605         (SharderTests.test_multiple_locked_shards): The natural sorting and test name key unit tests
3606         are now moved to the base Port unit tests.
3607         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3608         (Manager._prepare_lists): Keep the test names in a list. Order that list as specified by
3609         the new --order option.
3610         * Scripts/webkitpy/layout_tests/port/base.py:
3611         (Port.tests): This method should now return a list of all the tests found in the specified
3612         paths.
3613         (Port._real_tests): A list is required, so no conversion to a set is made.
3614         (Port):
3615         (Port.test_key): Place this method here for now, but it should really move into a separate
3616         module.
3617         (Port._natural_sort_key): Ditto.
3618         (Port._natural_sort_key.tryint):
3619         (Port._virtual_tests): A list is required, so the function now operates on that rather than
3620         on a set.
3621         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3622         (PortTest.test_find_with_skipped_directories_2): Adjust the test case to check for an empty
3623         list rather than an empty set.
3624         (PortTest.test_dont_require_http_server):
3625         (NaturalCompareTest): The natural sorting unit tests are placed here for now.
3626         (NaturalCompareTest.assert_cmp):
3627         (NaturalCompareTest.test_natural_compare):