59c98f50d2d0836d94504f68092fc6b3cdfc0d28
[WebKit-https.git] / Tools / ChangeLog
1 2016-06-14  Aakash Jain  <aakash_jain@apple.com>
2
3         Continuous "Reentrancy avoided" error messages in run-webkit-tests if Simulator quits unexpectedly
4         https://bugs.webkit.org/show_bug.cgi?id=158756
5
6         Reviewed by Alexey Proskuryakov.
7
8         * Scripts/webkitpy/xcode/simulator.py:
9         (Simulator.wait_until_device_is_booted): If checking Simulator boot state fails, verify if
10         the "simulator device" is still in booted state. Since we ensured that simulator device 
11         was in booted state earlier in this method, this indicates that simulator device has shut down
12         unexpectedly.
13
14 2016-06-14  David Kilzer  <ddkilzer@apple.com>
15
16         Follow-up fix #2: REGRESSION (r202020): El Capitan CMake Debug build broken
17         <https://webkit.org/b/158743>
18
19         Unreviewed build fix.
20
21         * DumpRenderTree/PlatformMac.cmake: Fix silly typo.
22
23 2016-06-14  Aakash Jain  <aakash_jain@apple.com>
24
25         Too much log data generated during layout-tests on iOS Simulator
26         https://bugs.webkit.org/show_bug.cgi?id=158751
27
28         Reviewed by Alexey Proskuryakov.
29
30         * Scripts/webkitpy/port/ios.py:
31         (IOSSimulatorPort._quit_ios_simulator): Do not use -v flag.
32         (IOSSimulatorPort.clean_up_test_run): Ditto.
33         (IOSSimulatorPort._createSimulatorApp): Ditto.
34
35 2016-06-14  David Kilzer  <ddkilzer@apple.com>
36
37         Follow-up fix: REGRESSION (r202020): El Capitan CMake Debug build broken
38         <https://webkit.org/b/158743>
39
40         Unreviewed build fix.
41
42         The fix in r202056 clobbered DumpRenderTree_SOURCES and
43         TestNetscapePlugin_SOURCES from DumpRenderTree/CMakeLists.txt,
44         so the build failure is now that we're not building the common
45         sources.
46
47         Fix that by saving the common sources (which are all C++ source
48         files) into *_Cpp_SOURCES lists first, then setting the compiler
49         flags, then creating the final *_SOURCES lists.
50
51         * DumpRenderTree/PlatformMac.cmake: Add
52         ${TestNetscapePlugin_Cpp_SOURCES} to list that needs
53         "-std=c++14" compiler switch.
54         (TestNetscapePlugin_Cpp_SOURCES): Add new list for C++ source
55         files for TestNetscapePlugin.  Seeded with
56         ${TestNetscapePlugin_SOURCES} from CMakeLists.txt.
57         (TestNetscapePlugin_SOURCES): Add
58         ${TestNetscapePlugin_Cpp_SOURCES} to the list of files.
59         (DumpRenderTree_Cpp_SOURCES): Seed list for C++ source files
60         with ${DumpRenderTree_SOURCES} from CMakeLists.txt.
61         (DumpRenderTree_SOURCES): Reformat and sort source lists.
62
63 2016-06-14  David Kilzer  <ddkilzer@apple.com>
64
65         REGRESSION (r202020): El Capitan CMake Debug build broken
66         <https://webkit.org/b/158743>
67
68         Reviewed by Alex Christensen.
69
70         The bug was that pure C++ source files (and Objective-C source
71         files) were being compiled as Objective-C++ source files.  This
72         is obviously incorrect, so the fix was to split out the list of
73         source files by language, then define compiler switches based on
74         each file type.
75
76         * DumpRenderTree/PlatformMac.cmake: Replace add_definitions()
77         with separate foreach loops that set compiler flags based on
78         each source file's type.
79         (TestNetscapePlugin_ObjCpp_SOURCES): Rename from
80         TestNetscapePlugin_SOURCES.
81         (TestNetscapePlugin_SOURCES): Create based on
82         ${TestNetscapePlugin_ObjCpp_SOURCES}.
83         (DumpRenderTree_ObjC_SOURCES): Split from DumpRenderTree_SOURCES.
84         (DumpRenderTree_Cpp_SOURCES): Ditto.
85         (DumpRenderTree_ObjCpp_SOURCES): Ditto.
86         (DumpRenderTree_SOURCES): Create from above three lists.
87
88 2016-06-14  Lucas Forschler  <lforschler@apple.com>
89
90         <rdar://problem/26685782>
91         Teach the copy-webkitlibraries-to-product-directory script about WebKitSystemInterfaceOSX10.12
92
93         Rubber-stamped by Jessie Berlin.
94
95         * Scripts/copy-webkitlibraries-to-product-directory:
96
97 2016-06-14  Youenn Fablet  <youenn.fablet@crf.canon.fr>
98
99         Activate CMake export compile commands option
100         https://bugs.webkit.org/show_bug.cgi?id=158734
101
102         Reviewed by Alex Christensen.
103
104         * Scripts/webkitdirs.pm:
105         (generateBuildSystemFromCMakeProject): Activating this option for all CMake builds.
106         This allows using ymcd for WebKit hacking.
107
108 2016-06-14  David Kilzer  <ddkilzer@apple.com>
109
110         Modernize DumpRenderTreeMac.h
111         <https://webkit.org/b/158721>
112
113         Reviewed by Andy Estes.
114
115         * DumpRenderTree/mac/DumpRenderTreeMac.h:
116         - Update copyright.
117         - Update license.
118         - Use #pragma once.
119         - Use OBJC_CLASS macro.
120
121 2016-06-13  David Kilzer  <ddkilzer@apple.com>
122
123         False-positive over-release of WebView in destroyWebViewAndOffscreenWindow() in DumpRenderTree.mm
124         <https://webkit.org/b/158716>
125
126         Reviewed by Andy Estes.
127
128         * DumpRenderTree/mac/DumpRenderTree.mm:
129         (destroyWebViewAndOffscreenWindow): Change this function to take
130         a WebView, and assert that it's the same as [mainFrame webView].
131         (dumpRenderTree): Pass 'webView' into
132         destroyWebViewAndOffscreenWindow().
133         * DumpRenderTree/mac/DumpRenderTreeMac.h:
134         (createWebViewAndOffscreenWindow): Add NS_RETURNS_RETAINED since
135         this function returns a +1 WebView.  Declare this method only for
136         Objective-C[++] source.
137
138 2016-06-13  Sam Weinig  <sam@webkit.org>
139
140         Make HashMap and HashSet work with Refs
141         https://bugs.webkit.org/show_bug.cgi?id=158638
142
143         Reviewed by Darin Adler.
144
145         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
146         (TestWebKitAPI::TEST):
147         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
148         (TestWebKitAPI::TEST):
149         Add tests for using Refs in HashMaps (both as key and value) and HashSets.
150
151 2016-06-13  Mark Lam  <mark.lam@apple.com>
152
153         Add a mechanism for collecting LLINT stats.
154         https://bugs.webkit.org/show_bug.cgi?id=158668
155
156         Reviewed by Filip Pizlo.
157
158         * DumpRenderTree/mac/DumpRenderTree.mm:
159         (DumpRenderTreeMain):
160
161 2016-06-13  Romain Bellessort  <romain.bellessort@crf.canon.fr>
162
163         [GTK] Enabling Shadow DOM by default
164         https://bugs.webkit.org/show_bug.cgi?id=158686
165
166         Reviewed by Carlos Garcia Campos.
167
168         Added support for enabling Shadow DOM by default for GTK.
169         Changed GTK test expectations for fast/shadow-dom tests (most tests
170         pass).
171
172         * Scripts/webkitperl/FeatureList.pm:
173
174 2016-06-12  Aakash Jain  <aakash_jain@apple.com>
175
176         run-safari/run-webkit-app fail to quit iOS simulator after Xcode installation
177         https://bugs.webkit.org/show_bug.cgi?id=158651
178         rdar://problem/26499824
179
180         Reviewed by Daniel Bates.
181
182         This change is to make our tools more robust. Sometimes run-safari/run-webkit-app fails 
183         to start the tests as one of the first thing these scripts do is to relaunch iOS Simulators,
184         and in process call quitIOSSimulator. In case the Simulator is not registered in LaunchServices
185         for some reason, quitIOSSimulator fails and the script stops. This change will make the scripts
186         still continue when they fail to quit iOS Simuator, and modify the way Simulator is opened, 
187         so that Simulator is implicitly registered with LaunchServices while opening it.
188
189         * Scripts/webkitdirs.pm:
190         (relaunchIOSSimulator):
191         Launch iOS Simulator using complete path. Partially reverting http://trac.webkit.org/changeset/184202.
192         (quitIOSSimulator):
193         Do not die if quitting ios Simulator fails, so that relaunchIOSSimulator can still 
194         attempt to launch the simulator.
195         (waitUntilIOSSimulatorDeviceIsInState):
196         Added a FIXME.
197
198 2016-06-11  Myles C. Maxfield  <mmaxfield@apple.com>
199
200         Addressing post-review comments after r201978.
201         https://bugs.webkit.org/show_bug.cgi?id=158649
202         <rdar://problem/13258122>
203
204         Unreviewed.
205
206         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
207         (TestWebKitAPI::TEST):
208
209 2016-06-11  Alexey Proskuryakov  <ap@apple.com>
210
211         Unreviewed leak fix after r201863.
212
213         * DumpRenderTree/mac/DumpRenderTree.mm:
214         (dumpFramesAsText):
215
216 2016-06-11  Myles C. Maxfield  <mmaxfield@apple.com>
217
218         [Cocoa] Map commonly used Chinese Windows font names to names present on Cocoa operating systems
219         https://bugs.webkit.org/show_bug.cgi?id=158649
220         <rdar://problem/13258122>
221
222         Reviewed by Darin Adler.
223
224         * TestWebKitAPI/Tests/WTF/WTFString.h:
225         (TestWebKitAPI::TEST):
226
227 2016-06-10  Alex Christensen  <achristensen@webkit.org>
228
229         Fix CMake build.
230
231         * TestWebKitAPI/PlatformMac.cmake:
232
233 2016-06-10  Filip Pizlo  <fpizlo@apple.com>
234
235         Rename JSAir to Air.js
236
237         Rubber stamped by Mark Lam.
238
239         * Scripts/run-javascriptcore-tests:
240
241 2016-06-10  Filip Pizlo  <fpizlo@apple.com>
242
243         JSC Stress Test failing: jsair-tests.yaml/test.js.ftl-eager-no-cjit
244         https://bugs.webkit.org/show_bug.cgi?id=158571
245
246         Reviewed by Keith Miller.
247         
248         Unskip the JSAir test.
249
250         * Scripts/run-javascriptcore-tests:
251         (runJSCStressTests):
252
253 2016-06-10  Sam Weinig  <sam@webkit.org>
254
255         Re-disable the UserMedia tests which are timing out.
256
257         They used to be accidentally disabled, due to not including
258         the FeatureDefines correctly, but not we explicitly disable it.
259
260         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
261         (TestWebKitAPI::TEST):
262
263 2016-06-10  Alex Christensen  <achristensen@webkit.org>
264
265         Introduce WTF::UniqueRef
266         https://bugs.webkit.org/show_bug.cgi?id=158596
267
268         Reviewed by Brady Eidson.
269
270         * TestWebKitAPI/CMakeLists.txt:
271         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
272         * TestWebKitAPI/Tests/WTF/UniqueRef.cpp: Added.
273         (TestWebKitAPI::B::B):
274         (TestWebKitAPI::C::C):
275         (TestWebKitAPI::function):
276         (TestWebKitAPI::TEST):
277
278 2016-06-10  Sam Weinig  <sam@webkit.org>
279
280         Refactor TestWebKitAPI to allow just testing WTF
281         https://bugs.webkit.org/show_bug.cgi?id=158625
282
283         Reviewed by Tim Horton.
284
285         Extract all the WTF tests into a new target to allow a faster build / test / fix
286         cycle when working on WTF bugs and features.
287         
288         By calling `run-api-tests --wtf-only`, you don't need to have a build of JavaScriptCore/WebCore/etc
289         to test WTF only changes.
290
291         * Scripts/build-api-tests:
292         * Scripts/run-api-tests:
293         (buildTestTool):
294         (testToolPaths):
295         Add new options to build-api-tests and run-api-tests to only build/run the WTF test runner.
296
297         * TestWebKitAPI/CMakeLists.txt:
298         * TestWebKitAPI/Configurations/TestWTF.xcconfig: Added.
299         * TestWebKitAPI/Configurations/TestWTFLibrary.xcconfig: Added.
300         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
301         Add two new targets, TestWTFLibrary which contains all the WTF tests, and TestWTF,
302         the test runner that runs the WTF tests.
303     
304         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
305         Use Utilities.h rather than PlatformUtilities.h.
306
307         * TestWebKitAPI/Utilities.h: Added.
308         * TestWebKitAPI/PlatformUtilities.h:
309         * TestWebKitAPI/cocoa/PlatformUtilitiesCocoa.mm:
310         * TestWebKitAPI/cocoa/UtilitiesCocoa.mm: Added.
311         Move the sleep and run functions into a new Utilities.h/cpp file. This file contains utilities
312         that don't depend on anything in the WebKit project. 
313
314 2016-06-10  Brady Eidson  <beidson@apple.com>
315
316         REGRESSION(r201928?) API test WTF.StringOperators failing
317         https://bugs.webkit.org/show_bug.cgi?id=158623
318
319         Unreviewed, but buddy coded with Alex Christensen.
320
321         * TestWebKitAPI/Tests/WTF/CrossThreadTask.cpp:
322         (TestWebKitAPI::LifetimeLogger::fullName): Only one file in all of TestWebKitAPI is allowed
323           to use string concatenation, otherwise the linker will mess up on the symbol related to
324           this bizarre WTF_STRINGTYPEADAPTER_COPIED_WTF_STRING macro expansion.
325
326 2016-06-10  Brady Eidson  <beidson@apple.com>
327
328         WTF_CrossThreadTask.Basic fails in all non mac ports.
329         https://bugs.webkit.org/show_bug.cgi?id=158612
330
331         Reviewed by Alex Christensen.
332
333         The test is very sensitive to argument evaluation order which is explicitly undefined in C++.
334         
335         Instead, we should just count the appropriate events to forget their order.
336         
337         * TestWebKitAPI/Tests/WTF/CrossThreadTask.cpp:
338         (TestWebKitAPI::LifetimeLogger::LifetimeLogger):
339         (TestWebKitAPI::LifetimeLogger::~LifetimeLogger):
340         (TestWebKitAPI::LifetimeLogger::isolatedCopy):
341         (TestWebKitAPI::LifetimeLogger::fullName):
342         (TestWebKitAPI::testFunction):
343         (TestWebKitAPI::TEST):
344         (TestWebKitAPI::LifetimeLogger::log): Deleted.
345         (TestWebKitAPI::LifetimeLogger::takeLogStr): Deleted.
346
347 2016-06-09  Alex Christensen  <achristensen@webkit.org>
348
349         Clean up Tools *.vcxproj after switching to CMake.
350
351         * DumpRenderTree/DumpRenderTree.sln: Removed.
352         * DumpRenderTree/DumpRenderTree.vcxproj: Removed.
353         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin: Removed.
354         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.def: Removed.
355         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.rc: Removed.
356         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/resource.h: Removed.
357         * DumpRenderTree/PlatformWin.cmake:
358         * DumpRenderTree/win/TestNetscapePlugin.def: Copied from DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.def.
359         * DumpRenderTree/win/TestNetscapePlugin.rc: Copied from DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.rc.
360         * DumpRenderTree/win/resource.h: Copied from DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/resource.h.
361         * MiniBrowser/MiniBrowser.vcxproj: Removed.
362         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.ico: Removed.
363         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.rc: Removed.
364         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc: Removed.
365         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h: Removed.
366         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserResource.h: Removed.
367         * MiniBrowser/MiniBrowser.vcxproj/small.ico: Removed.
368         * MiniBrowser/win/CMakeLists.txt:
369         * MiniBrowser/win/MiniBrowser.ico: Copied from MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.ico.
370         * MiniBrowser/win/MiniBrowser.rc: Copied from MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.rc.
371         * MiniBrowser/win/MiniBrowserLib.rc: Copied from MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc.
372         * MiniBrowser/win/MiniBrowserLibResource.h: Copied from MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h.
373         * MiniBrowser/win/MiniBrowserResource.h: Copied from MiniBrowser/MiniBrowser.vcxproj/MiniBrowserResource.h.
374         * MiniBrowser/win/small.ico: Copied from MiniBrowser/MiniBrowser.vcxproj/small.ico.
375         * WebKitTestRunner/WebKitTestRunner.sln: Removed.
376         * win/DLLLauncher/DLLLauncherWinCairo.props: Removed.
377
378 2016-06-09  Zalan Bujtas  <zalan@apple.com>
379
380         Add testing support for 3x device scale factor.
381         https://bugs.webkit.org/show_bug.cgi?id=158597
382
383         Reviewed by Simon Fraser.
384
385         Set 3x device scale factor on the test canvas when the test url is prefixed with hidpi-3x-. 
386
387         * DumpRenderTree/mac/DumpRenderTree.mm:
388         (changeWindowScaleIfNeeded):
389         * WebKitTestRunner/TestController.cpp:
390         (WTR::TestController::updateWindowScaleForTest):
391         * WebKitTestRunner/TestOptions.cpp:
392         (WTR::deviceScaleFactorForTest):
393         (WTR::TestOptions::TestOptions):
394         (WTR::isHiDPITestPath): Deleted.
395         * WebKitTestRunner/TestOptions.h:
396
397 2016-06-09  Michael Catanzaro  <mcatanzaro@igalia.com>
398
399         Add comments to clarify feature enablement
400         https://bugs.webkit.org/show_bug.cgi?id=158567
401
402         Reviewed by Alex Christensen.
403
404         * Scripts/webkitperl/FeatureList.pm:
405
406 2016-06-09  Filip Pizlo  <fpizlo@apple.com>
407
408         Unreviewed, skip jsair tests while we figure out the debug timeouts.
409
410         * Scripts/run-javascriptcore-tests:
411         (runJSCStressTests):
412
413 2016-06-09  Commit Queue  <commit-queue@webkit.org>
414
415         Unreviewed, rolling out r201815.
416         https://bugs.webkit.org/show_bug.cgi?id=158570
417
418         This broke the cmake build. (Requested by lforschler on
419         #webkit).
420
421         Reverted changeset:
422
423         "Teach cmake about libWebKitSystemInterfaceOSX10.12"
424         http://trac.webkit.org/changeset/201815
425
426 2016-06-09  Brady Eidson  <beidson@apple.com>
427
428         Greatly simplify CrossThreadTask.h.
429         https://bugs.webkit.org/show_bug.cgi?id=158542
430
431         Reviewed by Darin Adler.
432
433         * TestWebKitAPI/Tests/WTF/CrossThreadTask.cpp:
434         (TestWebKitAPI::TEST):
435
436 2016-06-09  Chris Dumez  <cdumez@apple.com>
437
438         Unreviewed, rolling out r201836, r201845, and r201848.
439
440         Looks like a 1-2% PLT regression on iOS
441
442         Reverted changesets:
443
444         "[JSC] Change some parameters based on a random search"
445         https://bugs.webkit.org/show_bug.cgi?id=158514
446         http://trac.webkit.org/changeset/201836
447
448         "Tempory fix for the debug bots"
449         http://trac.webkit.org/changeset/201845
450
451         "Change thresholdForOptimizeSoon to match
452         thresholdForOptimizeAfterWarmUp"
453         http://trac.webkit.org/changeset/201848
454
455 2016-06-09  Michael Saboff  <msaboff@apple.com>
456
457         WebKitTestRunner and DumpRenderTree do not handle dangling surrogate characters
458         https://bugs.webkit.org/show_bug.cgi?id=154863
459
460         Reviewed by Alexey Proskuryakov.
461
462         Added a non-strict verions of WKStringGetUTF8CString() that will handle dangling
463         surrogates.  Changed the extraction of inner text from frames in DumpRenderTree
464         to use the new WKStringGetUTF8CStringNonStrict() function instead of NSString
465         conversion since NSString doesn't have a way to handle dangling surrogates.
466         The code added in DumpRenderTree matches what was changed in WebKitTestRunner.
467
468         * DumpRenderTree/mac/DumpRenderTree.mm:
469         (dumpFramesAsText):
470         * WebKitTestRunner/StringFunctions.h:
471         (WTR::toWTFString):
472
473 2016-06-08  Hunseop Jeong  <hs85.jeong@samsung.com>
474
475         Try to fix the EFL build. 
476
477         Unreviewed. 
478
479         * TestWebKitAPI/CMakeLists.txt:
480
481 2016-06-08  Alex Christensen  <achristensen@webkit.org>
482
483        Fix WinCairo build
484
485         * DumpRenderTree/cairo/PixelDumpSupportCairo.h:
486
487 2016-06-08  Alex Christensen  <achristensen@webkit.org>
488
489         Fix WinCairo build
490
491         * DumpRenderTree/cairo/PixelDumpSupportCairo.h:
492         (BitmapContext::createByAdoptingBitmapAndContext):
493         (BitmapContext::~BitmapContext):
494
495 2016-06-08  Benjamin Poulain  <benjamin@webkit.org>
496
497         [JSC] Change some parameters based on a random search
498         https://bugs.webkit.org/show_bug.cgi?id=158514
499
500         Reviewed by Filip Pizlo.
501
502         * Scripts/run-jsc-stress-tests:
503
504 2016-06-08  Aakash Jain  <aakash_jain@apple.com>
505
506         tests fail if display sleeps while run-webkit-tests is running
507         https://bugs.webkit.org/show_bug.cgi?id=153919
508
509         Reviewed by Alexey Proskuryakov.
510
511         * DumpRenderTree/mac/LayoutTestHelper.m:
512         (releaseSleepAssertions): Release both Display sleep and System sleep assertions.
513         (addSleepAssertions): Add sleep assertion for both Display sleep and System sleep.
514
515 2016-06-08  Lucas Forschler  <lforschler@apple.com>
516
517         Reverted changeset 201814.
518
519         * Scripts/copy-webkitlibraries-to-product-directory:
520
521 2016-06-08  Per Arne Vollan  <pvollan@apple.com>
522
523         [Win] Shadow DOM tests are failing.
524         https://bugs.webkit.org/show_bug.cgi?id=158524
525
526         Reviewed by Brent Fulgham.
527
528         Enable Shadow DOM when running tests.
529
530         * DumpRenderTree/win/DumpRenderTree.cpp:
531         (resetWebPreferencesToConsistentValues):
532
533 2016-06-08  Lucas Forschler  <lforschler@apple.com>
534
535         Teach cmake about libWebKitSystemInterfaceOSX10.12
536         This patch also removes duplicated logic inside DumpRenderTree/PlatformMac.cmake
537
538         Rubber-stamped by Alex Christensen.
539  
540         * DumpRenderTree/PlatformMac.cmake:
541         * WebKitTestRunner/PlatformMac.cmake:
542
543 2016-06-07  Lucas Forschler  <lforschler@apple.com>
544
545         <rdar://problem/26685782>
546         Teach the copy-webkitlibraries-to-product-directory script about WebKitSystemInterfaceOSX10.12
547
548         Rubber-stamped by Jessie Berlin.
549
550         * Scripts/copy-webkitlibraries-to-product-directory:
551
552 2016-06-08  Aakash Jain  <aakash_jain@apple.com>
553
554         Don't try to cleanup non-existing ios Simulators
555         https://bugs.webkit.org/show_bug.cgi?id=158510
556
557         Reviewed by Alexey Proskuryakov.
558
559         * Scripts/webkitpy/port/ios.py:
560         (IOSSimulatorPort.clean_up_test_run): 
561         Check if simulator exists before trying to clean it up.
562
563 2016-06-08  Brady Eidson  <beidson@apple.com>
564
565         Try to fix the Windows build.
566
567         Unreviewed.
568
569         * TestWebKitAPI/Tests/WTF/CrossThreadTask.cpp:
570         (TestWebKitAPI::LifetimeLogger::log):
571         (TestWebKitAPI::LifetimeLogger::takeLogStr):
572         (TestWebKitAPI::testFunction):
573         (TestWebKitAPI::TEST):
574         (TestWebKitAPI::log): Deleted. (VS was seeing it as a dupe symbol)
575         (TestWebKitAPI::takeLogStr): Deleted. (VS was seeing it as a dupe symbol)
576
577 2016-06-08  Brady Eidson  <beidson@apple.com>
578
579         Make CrossThreadCopier more efficient (fewer copies!).
580         https://bugs.webkit.org/show_bug.cgi?id=158456
581
582         Reviewed by Alex Christensen.
583
584         * TestWebKitAPI/Tests/WTF/CrossThreadTask.cpp:
585         (TestWebKitAPI::TEST):
586
587 2016-06-07  Filip Pizlo  <fpizlo@apple.com>
588
589         Add result validation to JSAir
590         https://bugs.webkit.org/show_bug.cgi?id=158493
591
592         Reviewed by Saam Barati.
593         
594         Run JSAir.
595
596         * Scripts/run-javascriptcore-tests:
597         (runJSCStressTests):
598
599 2016-06-08  Brady Eidson  <beidson@apple.com>
600
601         Add an API test that confirms object constructor/destructor calls during creation of a CrossThreadTask.
602         https://bugs.webkit.org/show_bug.cgi?id=158528
603
604         Reviewed by Alex Christensen.
605
606         * TestWebKitAPI/CMakeLists.txt:
607         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
608         * TestWebKitAPI/Tests/WTF/CrossThreadTask.cpp: Added.
609         (TestWebKitAPI::log):
610         (TestWebKitAPI::takeLogStr):
611         (TestWebKitAPI::LifetimeLogger::LifetimeLogger):
612         (TestWebKitAPI::LifetimeLogger::~LifetimeLogger):
613         (TestWebKitAPI::LifetimeLogger::isolatedCopy):
614         (TestWebKitAPI::testFunction):
615         (TestWebKitAPI::TEST):
616
617 2016-06-08  Konstantin Tokarev  <annulen@yandex.ru>
618
619         TestWebKitAPI: Removed redunandant check PLATFORM(GTK) && !defined(BUILDING_WEBKIT2__)
620         https://bugs.webkit.org/show_bug.cgi?id=158521
621
622         Reviewed by Carlos Garcia Campos.
623
624         * TestWebKitAPI/config.h:
625
626 2016-06-07  Carlos Garcia Campos  <cgarcia@igalia.com>
627
628         [GTK] Use a longer timeout for glib unit tests
629         https://bugs.webkit.org/show_bug.cgi?id=158476
630
631         Reviewed by Darin Adler.
632
633         The timeout is supposed to be per test case, but in the case of GLib tests it affects all the tests cases of the
634         same test program. Some test programs like TestLoaderClient, that have a lot of test cases, often time out in
635         the bots because the timeout is not enough to run all the tests cases. So, we should use a longer timeout for
636         GLib tests.
637
638         * Scripts/run-gtk-tests:
639         (TestRunner._run_test_glib):
640
641 2016-06-07  Keith Rollin  <krollin@apple.com>
642
643         Remove all uses of PassRefPtr in WTF
644         https://bugs.webkit.org/show_bug.cgi?id=157596
645         <rdar://problem/26234391>
646
647         Reviewed by Chris Dumez.
648
649         Update calls to interfaces that no longer take or return PassRefPtrs.
650
651         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
652         (TestWebKitAPI::stringFromUTF8):
653         (TestWebKitAPI::TEST):
654
655 2016-06-07  Per Arne Vollan  <pvollan@apple.com>
656
657         [Win] Imported markup insertion test is failing.
658         https://bugs.webkit.org/show_bug.cgi?id=158477
659
660         Reviewed by Darin Adler.
661
662         Make sure the empty synchronous request is loaded after each test.
663
664         * DumpRenderTree/win/DumpRenderTree.cpp:
665         (runTest):
666
667 2016-06-06  Carlos Alberto Lopez Perez  <clopez@igalia.com>
668
669         REGRESSION(r201449) [GTK] ARMv7 build fails with libicudata.so.55: cannot open shared object file on gtkdoc-scangobj step.
670         https://bugs.webkit.org/show_bug.cgi?id=158417
671
672         Reviewed by Michael Catanzaro.
673
674         The toolchain on armhf (ARMv7) seems unable to properly handle
675         a shared library that doesn't link with anything.
676
677         And libicudata is built by default in this way because it only
678         contains static data.
679
680         That makes icu unusable on armhf because the linker will be
681         unable to resolve the libicudata dependencies.
682
683         Most (if not all) distributions workaround this by linking
684         libicudata with libc6, which is already a needed dependency for
685         any of the other icu shared libraries.
686
687         So import here the Debian patch fixing this issue. For further
688         details check https://bugs.debian.org/653457
689
690         * gtk/jhbuild.modules:
691         * gtk/patches/icudata-stdlibs.patch: Added.
692
693 2016-06-06  Per Arne Vollan  <pvollan@apple.com>
694
695         REGRESSION (r104174): 500+ tests failing on Windows
696         https://bugs.webkit.org/show_bug.cgi?id=75965
697
698         Reviewed by Michael Catanzaro.
699
700         Reset WebView scale factors before running next test.
701
702         * DumpRenderTree/win/DumpRenderTree.cpp:
703         (resetWebViewToConsistentStateBeforeTesting):
704
705 2016-06-04  Alexey Proskuryakov  <ap@apple.com>
706
707         REGRESSION (r201263): Some tests have become flaky timeouts.
708         https://bugs.webkit.org/show_bug.cgi?id=157990
709
710         Reviewed by Darin Adler.
711
712         * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::invoke):
713         It is somewhat legitimate for WebContent to not respond to messages after the test
714         is done; it can be e.g. re-doing a costly repaint. So, we should restart is silently,
715         without making the current test fail.
716
717 2016-06-03  Youenn Fablet  <youenn.fablet@crf.canon.fr>
718
719         [GTK] Update YouCompleteMe script to make all include paths absolute
720         https://bugs.webkit.org/show_bug.cgi?id=158301
721
722         Reviewed by Michael Catanzaro.
723
724         Before this patch, some include paths were not made absolute.
725         This could make YouCompleteMe plugin to fail extracting information or validating cpp files.
726
727         * gtk/ycm_extra_conf.py:
728
729 2016-06-03  Nael Ouedraogo  <nael.ouedraogo@crf.canon.fr>
730
731         Unreviewed: add myself to the committers list.
732
733         * Scripts/webkitpy/common/config/contributors.json:
734
735 2016-06-02  Per Arne Vollan  <pvollan@apple.com>
736
737         [Win] Fetch API tests are failing.
738         https://bugs.webkit.org/show_bug.cgi?id=158296
739
740         Reviewed by Alex Christensen.
741
742         Enable Fetch API when running tests.
743
744         * DumpRenderTree/win/DumpRenderTree.cpp:
745         (resetWebPreferencesToConsistentValues):
746
747 2016-06-02  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
748
749         Really display failing JSC stress tests in buildbot dashboard
750         https://bugs.webkit.org/show_bug.cgi?id=158324
751
752         Reviewed by Alexey Proskuryakov.
753
754         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
755         (BuildbotCombinedQueueView.prototype.update): Correctly check for string membership in array.
756         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
757         (BuildbotIteration.prototype._parseData): Correctly check for string membership in array.
758         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
759         (BuildbotQueueView.prototype._popoverContentForJavaScriptCoreTestRegressions): Correctly check for string
760         membership in array.
761         (BuildbotQueueView.prototype._presentPopoverForJavaScriptCoreTestRegressions): Ensure that the correct URL is
762         generated after the first time.
763         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
764         (BuildbotTesterQueueView.prototype.appendBuilderQueueStatus): Correctly check for string membership in array.
765
766 2016-06-02  Michael Saboff  <msaboff@apple.com>
767
768         [iOS]: Some JSC stress tests fail running out of executable memory when the LLInt is disabled
769         https://bugs.webkit.org/show_bug.cgi?id=158317
770
771         Reviewed by Saam Barati.
772
773         Added defaultNoNoLLIntRun variant to run the default tests with the exception of the no-llint
774         variant.
775
776         * Scripts/run-jsc-stress-tests:
777
778 2016-06-02  Aakash Jain  <aakash_jain@apple.com>
779
780         LayoutTests time out intermittently due to alert about reopening Simulator after it unexpectedly quit
781         https://bugs.webkit.org/show_bug.cgi?id=158305
782
783         Reviewed by Alexey Proskuryakov.
784
785         * Scripts/webkitpy/port/ios.py:
786         (IOSSimulatorPort.clean_up_test_run): Delete simulator's savedState directories during cleanup.
787
788 2016-06-01  Brian Burg  <bburg@apple.com>
789
790         REGRESSION(r191907): Can't enter combining diacritic marks in Web Inspector fields
791         https://bugs.webkit.org/show_bug.cgi?id=158227
792         <rdar://problem/26232464>
793
794         Reviewed by Alexey Proskuryakov.
795
796         Add a regression test that runs on Mac only.
797
798         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
799         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewTextInput.mm: Added.
800         (-[DummyNavigationDelegate webView:didFinishNavigation:]):
801         (TEST):
802         * TestWebKitAPI/Tests/WebKit2Cocoa/editable-body.html: Added.
803
804 2016-06-01  Chris Fleizach  <cfleizach@apple.com>
805
806         AX: iOS: VoiceOver can't access attachments in mail messages
807         https://bugs.webkit.org/show_bug.cgi?id=158198
808
809         Reviewed by Joanmarie Diggs.
810
811         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
812         (AccessibilityUIElement::stringForRange):
813         (AccessibilityUIElement::attributedStringForRange):
814         (AccessibilityUIElement::attributedStringRangeIsMisspelled):
815         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
816         (WTR::AccessibilityUIElement::attributedStringForRange):
817         (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
818
819 2016-06-01  Carlos Garcia Campos  <cgarcia@igalia.com>
820
821         Unreviewed. Mark GTK+ test /webkit2/WebKitWebInspectorServer/test-open-debugging-session as slow.
822
823         It's timing out in the bots, but it seems to pass when running run-gtk-tests with no timeout. For GLib tests the
824         timeout is applied per tester program not per test case, so we need to mark the whole test
825         WebKit2Gtk/TestInspectorServer as slow.
826
827         * Scripts/run-gtk-tests:
828         (TestRunner):
829         (TestRunner._run_test_glib):
830
831 2016-06-01  Carlos Garcia Campos  <cgarcia@igalia.com>
832
833         Unreviewed. Skip media permission request GTK+ unit tests.
834
835         They are timing out in the bots.
836
837         * Scripts/run-gtk-tests:
838         (TestRunner):
839
840 2016-05-31  Jer Noble  <jer.noble@apple.com>
841
842         Yet another unreviewed build fix; move the closing brace of the namespace declaration inside
843         the #if check.
844
845         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenTopContentInset.mm:
846
847 2016-05-31  Jer Noble  <jer.noble@apple.com>
848
849         Further unreviewed build fix; only run FullscreenTopContentInset test on Mac.
850
851         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenTopContentInset.mm:
852
853 2016-05-31  Jer Noble  <jer.noble@apple.com>
854
855         Unreviewed build fix; only run FullscreetTopContentInset test on platforms
856         where WK_API_ENABLED is set.
857
858         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenTopContentInset.mm:
859
860 2016-05-31  Jer Noble  <jer.noble@apple.com>
861
862         REGRESSION (r201405): trailers.apple.com HUD is missing in fullscreen
863         https://bugs.webkit.org/show_bug.cgi?id=158156
864         <rdar://problem/26519589>
865
866         Reviewed by Darin Adler.
867
868         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
869         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenTopContentInset.html: Added.
870         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenTopContentInset.mm: Added.
871         (-[FullscreenChangeMessageHandler userContentController:didReceiveScriptMessage:]):
872         (TestWebKitAPI::TEST):
873
874 2016-05-31  Jon Lee  <jonlee@apple.com>
875
876         Unreviewed: add myself to the reviewers list.
877
878         * Scripts/webkitpy/common/config/contributors.json:
879
880 2016-05-31  Carlos Alberto Lopez Perez  <clopez@igalia.com>
881
882         [GTK] Provide alternative mirror for the ICU tarball.
883         https://bugs.webkit.org/show_bug.cgi?id=154530
884
885         Unreviewed.
886
887         * gtk/jhbuild.modules: After r201449 the GTK+ ARM buildbot is having
888         a hard time trying to download the ICU tarball from download.icu-project.org
889         (which redirects to sourceforge and gives problems with something related to
890         SSL). Provide this alternative mirror to make things working back.
891
892 2016-05-31  Carlos Garcia Campos  <cgarcia@igalia.com>
893
894         [GTK] Test /webkit2/WebKitWebView/geolocation-permission-requests is failing since r201423
895         https://bugs.webkit.org/show_bug.cgi?id=158200
896
897         Reviewed by Philippe Normand.
898
899         This is because geolocation is no longer allowed for non secure sites, like HTTP. In that case
900         POSITION_UNAVAILABLE is returned without asking the API layer.
901
902         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
903         (testWebViewGeolocationPermissionRequests): Keep the HTTP case to check that it indeed returns
904         POSITION_UNAVAILABLE and use HTTPS URLs to check permission requests are allowed or denied. Also stop using the
905         document title, and use user script messages that are more reliable instead.
906
907 2016-05-28  Aakash Jain  <aakash_jain@apple.com>
908
909         tests fail if display sleeps while run-webkit-tests is running
910         https://bugs.webkit.org/show_bug.cgi?id=153919
911
912         Reviewed by Darin Adler.
913
914         * DumpRenderTree/mac/LayoutTestHelper.m:
915         (addDisplaySleepAssertion): Use PreventUserIdleSystemSleep flag, same as set by caffeinate tool.
916
917 2016-05-27  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
918
919         Display failing JSC stress tests in buildbot dashboard
920         https://bugs.webkit.org/show_bug.cgi?id=156595
921
922         Reviewed by Alexey Proskuryakov.
923
924         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
925         (Buildbot.prototype.javaScriptCoreTestFailuresURLForIteration):
926         (Buildbot.prototype.javaScriptCoreTestStdioUrlForIteration):
927         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
928         (BuildbotCombinedQueueView.prototype.update):
929         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
930         (BuildbotIteration):
931         (BuildbotIteration.prototype._parseData):
932         (BuildbotIteration.prototype.loadLayoutTestResults):
933         (BuildbotIteration.prototype.):
934         (BuildbotIteration.prototype.loadJavaScriptCoreTestResults):
935         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
936         (BuildbotQueueView.prototype._createLoadingIndicator):
937         (BuildbotQueueView.prototype.):
938         (BuildbotQueueView.prototype._onPopoverCopy):
939         (BuildbotQueueView.prototype._popoverContentForJavaScriptCoreTestRegressions):
940         (BuildbotQueueView.prototype._presentPopoverForJavaScriptCoreTestRegressions):
941         (BuildbotQueueView.prototype._addIterationHeadingToPopover):
942         (BuildbotQueueView.prototype._testStepFailureDescription):
943         (BuildbotQueueView.prototype._testStepFailureDescriptionWithCount):
944         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
945         (BuildbotTestResults.prototype.addJavaScriptCoreTestFailures):
946         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
947         (BuildbotTesterQueueView.prototype.appendBuilderQueueStatus):
948         (BuildbotTesterQueueView.prototype.update):
949         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions):
950         (BuildbotTesterQueueView.prototype._presentPopoverForLayoutTestRegressions):
951         (BuildbotTesterQueueView.prototype._testStepFailureDescription): Deleted.
952         (BuildbotTesterQueueView.prototype._testStepFailureDescriptionWithCount): Deleted.
953         (BuildbotTesterQueueView.prototype.): Deleted.
954         (BuildbotTesterQueueView.prototype.content.oncopy): Deleted.
955         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/index.html:
956         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbot.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbotQueue.js.
957         (MockBuildbot):
958         (MockBuildbot.prototype.buildPageURLForIteration):
959         (MockBuildbot.prototype.javaScriptCoreTestFailuresURLForIteration):
960         (MockBuildbot.prototype.javaScriptCoreTestStdioUrlForIteration):
961         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbotQueue.js:
962         (MockBuildbotQueue):
963         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbotTestResults.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbotQueue.js.
964         (MockBuildbotTestResults):
965         (MockBuildbotTestResults.prototype.addJavaScriptCoreTestFailures):
966         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/test-jsc-results.json: Added.
967         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js:
968
969 2016-05-27  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
970
971         Display failing JSC stress tests in buildbot dashboard
972         https://bugs.webkit.org/show_bug.cgi?id=156595
973
974         Reviewed by Alexey Proskuryakov.
975
976         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
977         (Buildbot.prototype.javaScriptCoreTestFailuresURLForIteration): Generate the URL for raw JSON output of
978         JSC tests.
979         (Buildbot.prototype.javaScriptCoreTestStdioURLForIteration): Generate the URL for human-readable stdio output
980         of JSC tests.
981         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
982         (BuildbotCombinedQueueView.prototype.update): Display JSC test results in popover.
983         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
984         (BuildbotIteration): Add javaScriptCoreTestResults variable.
985         (BuildbotIteration.prototype.): Check for javascriptcore tests step.
986         (BuildbotIteration.prototype.loadLayoutTestResults): Add comma at closing brace.
987         (BuildbotIteration.prototype.loadJavaScriptCoreTestResults): Fetch JSON from Buildbot server.
988         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
989         (BuildbotQueueView.prototype._createLoadingIndicator): Reusable function.
990         (BuildbotQueueView.prototype._onPopoverCopy): Reusable copy event handler to allow accurate copying of text
991         from popovers.
992         (BuildbotQueueView.prototype._popoverContentForJavaScriptCoreTestRegressions): Generates the popover bubble's
993         inner HTML from the JSC failure data.
994         (BuildbotQueueView.prototype._presentPopoverForJavaScriptCoreTestRegressions): Generate the popover bubble
995         for JSC results and handle request failures.
996         (BuildbotQueueView.prototype._testStepFailureDescription): Moved from subclass.
997         (BuildbotQueueView.prototype._testStepFailureDescriptionWithCount): Moved from subclass.
998         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
999         (BuildbotTestResults.prototype.addJavaScriptCoreTestFailures): Parse JSON into a list of failing tests.
1000         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1001         (BuildbotTesterQueueView.prototype.appendBuilderQueueStatus): Instantiate PopoverTrackers for builds whose 
1002         only failures are JSC tests.
1003         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions): Use _onPopoverCopy.
1004         (BuildbotTesterQueueView.prototype._presentPopoverForLayoutTestRegressions): Use _createLoadingIndicator.
1005         (BuildbotTesterQueueView.prototype._testStepFailureDescription): Deleted. Moved to superclass.
1006         (BuildbotTesterQueueView.prototype._testStepFailureDescriptionWithCount): Deleted. Moved to superclass.
1007         (BuildbotTesterQueueView.prototype.content.oncopy): Deleted. Using superclass's reusable function as copy handler instead.
1008         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/index.html: Add new script files.
1009         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbot.js: Added.
1010         (MockBuildbot): Mocked version of Buildbot, only containing URL methods.
1011         (MockBuildbot.prototype.buildPageURLForIteration): Same as real Buildbot.js
1012         (MockBuildbot.prototype.javaScriptCoreTestFailuresURLForIteration): Points to local file containing JSON for test.
1013         (MockBuildbot.prototype.javaScriptCoreTestStdioURLForIteration): Same as real Buildbot.js
1014         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbotQueue.js:
1015         (MockBuildbotQueue): Use a MockBuildbot() instead of a string.
1016         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbotTestResults.js: Added.
1017         (MockBuildbotTestResults): Mocked version of BuildbotTestResults.
1018         (MockBuildbotTestResults.prototype.addJavaScriptCoreTestFailures): Sets the 'regressions' variable.
1019         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/test-jsc-results.json: Added.
1020         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js: Add four groups of tests.
1021
1022 2016-05-27  Chris Dumez  <cdumez@apple.com>
1023
1024         WorkQueue::dispatch() / RunLoop::dispatch() should not copy captured lambda variables
1025         https://bugs.webkit.org/show_bug.cgi?id=158111
1026
1027         Reviewed by Darin Adler.
1028
1029         WorkQueue::dispatch() / RunLoop::dispatch() should not copy captured lambda variables.
1030         These are often used cross-thread and copying the captured lambda variables can be
1031         dangerous (e.g. we do not want to copy a String after calling isolatedCopy() upon
1032         capture).
1033
1034         * WebKitTestRunner/TestController.cpp:
1035         (WTR::TestController::decidePolicyForNavigationAction):
1036
1037 2016-05-27  Brady Eidson  <beidson@apple.com>
1038
1039         Modern IDB: After closing a Netflix video, trying to watch it again fails.
1040         <rdar://problem/25092473> and https://bugs.webkit.org/show_bug.cgi?id=158160
1041
1042         Reviewed by Alex Christensen.
1043
1044         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1045         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup-1.html: Added.
1046         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup-2.html: Added.
1047         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm: Added.
1048
1049 2016-05-27  Joanmarie Diggs  <jdiggs@igalia.com>
1050
1051         AX: [ATK] accessibility/gtk/no-notification-for-unrendered-iframe-children.html began failing after r201416
1052         https://bugs.webkit.org/show_bug.cgi?id=158152
1053
1054         Reviewed by Chris Fleizach.
1055
1056         The failure is actually a bug fix because only one child is being added, but two
1057         notifications were being emitted. Now there is only one notification. To verify
1058         this was the case, we really should examine the child reportedly being added. That
1059         child is the ATK event's any_data, so pass along that child to the listener.
1060
1061         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
1062
1063 2016-05-26  Alex Christensen  <achristensen@webkit.org>
1064
1065         Expose content extension failure error codes in SPI
1066         https://bugs.webkit.org/show_bug.cgi?id=158095
1067         rdar://problem/26475651
1068
1069         Reviewed by Anders Carlsson.
1070
1071         * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentExtensionStore.mm:
1072         (checkDomain):
1073         (TEST_F):
1074         Add tests that use the new enum.
1075
1076 2016-05-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1077
1078         New intl-numberformat.js test fails on many Linux platforms
1079         https://bugs.webkit.org/show_bug.cgi?id=154530
1080
1081         Reviewed by Darin Adler.
1082
1083         The test is actually failing because of a bug in the icu version installed in the bots, using a newer version of
1084         icu makes the tests pass and explains why it worked for some people. So, let's add icu 55.1 to the internal
1085         jhbuild to ensure JSC tests pass in the bots no matter what the icu version installed is.
1086
1087         * gtk/jhbuild.modules:
1088
1089 2016-05-26  Yusuke Suzuki  <utatane.tea@gmail.com>
1090
1091         [JSC] Allow JSBench to use precise time
1092         https://bugs.webkit.org/show_bug.cgi?id=158050
1093
1094         Reviewed by Geoffrey Garen.
1095
1096         JSBench use `new Date().getTime()` without options and there is no way to use precise time.
1097         This patch modifies the JSBench code to inject the code taking the precise time.
1098         `currentTimeInMS` is given by the benchmerk harness and JSBench uses it.
1099         run-jsc-benchmark switches this function's implementation between `Date.now()` and
1100         testRunner's precise time one.
1101
1102         While this patch modifies the code of JSBench, the last release of JSBench is Jan 2013 and
1103         the contents are not changed for a long time. As described in the original paper[1], the
1104         tests can be generated by using JSBench's record & replay system, but in that case, we can
1105         adopt this modification by changing the tool side.
1106
1107         We also add currentTimeInMS implementation in harness.js and u?rem.js directly.
1108         u?rem.js implementation is required when it is executed in u?rem.html without harness.
1109         And harness.js implementation is required when it is executed in the JSBench's harness.
1110         In these implementation, we follow the JetStream's time measuring function: performance.now(),
1111         preciseTime(), or Date.now().
1112
1113         [1]: http://dl.acm.org/citation.cfm?id=2048119
1114
1115         * Scripts/run-jsc-benchmarks:
1116
1117 2016-05-26  Brent Fulgham  <bfulgham@apple.com>
1118
1119         Unreviewed test fix after r201427.
1120         https://bugs.webkit.org/show_bug.cgi?id=157423
1121         <rdar://problem/23751632>
1122
1123         A debug assertion was firing during some test runs due to the Geolocation permission
1124         being turned off during the test. The timer logic was originally written to assert
1125         if the timer fired when permissions were disabled. But this is no longer valid,
1126         because we expect the Geolocation system to be active and become deactivated if the
1127         browsing context violates one of the security criteria.
1128
1129         * DumpRenderTree/mac/UIDelegate.mm:
1130         (-[UIDelegate timerFired]): Remove invalid assertion.
1131
1132 2016-05-26  Filip Pizlo  <fpizlo@apple.com>
1133
1134         ScopedLambda should have a lifetime story that makes sense to the compiler
1135         https://bugs.webkit.org/show_bug.cgi?id=158118
1136
1137         Reviewed by Mark Lam.
1138         
1139         Added a test case. This test crashes before the fix and now it passes.
1140
1141         * TestWebKitAPI/CMakeLists.txt:
1142         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1143         * TestWebKitAPI/Tests/WTF/ScopedLambda.cpp: Added.
1144         (TestWebKitAPI::TEST):
1145
1146 2016-05-26  Myles C. Maxfield  <mmaxfield@apple.com>
1147
1148         Build fix
1149
1150         Rubber stamped by Lucas Forschler.
1151
1152         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1153         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1154
1155 2016-05-25  Anders Carlsson  <andersca@apple.com>
1156
1157         Get rid of WTF/Functional.h
1158         https://bugs.webkit.org/show_bug.cgi?id=158081
1159
1160         Reviewed by Chris Dumez.
1161
1162         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1163         * TestWebKitAPI/Tests/WTF/Functional.cpp: Removed.
1164         (TestWebKitAPI::returnFortyTwo): Deleted.
1165         (TestWebKitAPI::TEST): Deleted.
1166         (TestWebKitAPI::multiplyByTwo): Deleted.
1167         (TestWebKitAPI::multiplyByOneAndAHalf): Deleted.
1168         (TestWebKitAPI::multiply): Deleted.
1169         (TestWebKitAPI::subtract): Deleted.
1170         (TestWebKitAPI::A::A): Deleted.
1171         (TestWebKitAPI::A::f): Deleted.
1172         (TestWebKitAPI::A::addF): Deleted.
1173         (TestWebKitAPI::B::B): Deleted.
1174         (TestWebKitAPI::B::~B): Deleted.
1175         (TestWebKitAPI::B::ref): Deleted.
1176         (TestWebKitAPI::B::deref): Deleted.
1177         (TestWebKitAPI::B::f): Deleted.
1178         (TestWebKitAPI::B::g): Deleted.
1179         (TestWebKitAPI::Number::create): Deleted.
1180         (TestWebKitAPI::Number::~Number): Deleted.
1181         (TestWebKitAPI::Number::value): Deleted.
1182         (TestWebKitAPI::Number::Number): Deleted.
1183         (TestWebKitAPI::multiplyNumberByTwo): Deleted.
1184
1185 2016-05-25  Daniel Bates  <dabates@apple.com> and Brent Fulgham  <bfulgham@apple.com>
1186
1187         [WebSockets] No infrastructure for testing secure web sockets (wss)
1188         https://bugs.webkit.org/show_bug.cgi?id=157884
1189         <rdar://problem/26477197>
1190
1191         Reviewed by Andy Estes.
1192
1193         Add support to webkitpy to start and stop a secure Web Socket server running on port 9323
1194         using the certificate, private-key from file LayoutTests/http/conf/webkit-httpd.pem. Also
1195         teaches run-webkit-httpd to start and stop the Web Socket servers.
1196
1197         Modify DumpRenderTree and WebKitTestRunner to understand a new testRunner method,
1198         'setAllowsAnySSLCertificate', which allows us to use the same self-signed test certificate
1199         we do for our HTTPS tests.
1200         
1201         * DumpRenderTree/TestRunner.cpp:
1202         (setAllowsAnySSLCertificateCallback):
1203         (TestRunner::setAllowsAnySSLCertificate):
1204         * DumpRenderTree/TestRunner.h:
1205         * DumpRenderTree/mac/DumpRenderTree.mm:
1206         (resetWebViewToConsistentStateBeforeTesting): Make sure we turn off the new flag between tests.
1207         * Scripts/run-webkit-httpd:
1208         (main): Start the websocket server at launch.
1209         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1210         (Manager.__init__): Remove dead code.
1211         * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
1212         (PyWebSocket.__init__): Cleanup code.
1213         (PyWebSocket): Pass '--tls-client-ca' to start command.
1214         (PyWebSocket._prepare_config): Cleanups.
1215         * Scripts/webkitpy/port/base.py:
1216         (Port.to.start_http_server):
1217         (Port.to):
1218         (Port.to._extract_certificate_from_pem): Added.
1219         (Port.to._extract_private_key_from_pem): Added.
1220         (Port.to.start_websocket_server): Start secure socket server.
1221         (Port.to.stop_websocket_server): Stop secure socket server.
1222         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Add new API.
1223         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1224         (WTR::InjectedBundle::setAllowsAnySSLCertificate): Added.
1225         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1226         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1227         (WTR::TestRunner::setAllowsAnySSLCertificate): Added.
1228         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1229
1230 2016-05-25  Keith Miller  <keith_miller@apple.com>
1231
1232         run-jsc-benchmarks should use the new JSBench rather than look for it in the config file.
1233         https://bugs.webkit.org/show_bug.cgi?id=158077
1234
1235         Reviewed by Mark Lam.
1236
1237         Since we didn't have JSBench in the tree before we needed to lookup the path to it from
1238         benchmark config file. That's no longer the case so we should just fix it in the script.
1239
1240         * Scripts/run-jsc-benchmarks:
1241
1242 2016-05-24  Aakash Jain  <aakash_jain@apple.com>
1243
1244         Reorganize dashboard code: move code from _timeIntervalString to base class
1245         https://bugs.webkit.org/show_bug.cgi?id=158047
1246         rdar://problem/26457274
1247
1248         Reviewed by Alexey Proskuryakov and Dean Johnson.
1249
1250         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueView.js:
1251         (BubbleQueueView.prototype._timeIntervalString): Moved core logic to base class so as to make it re-usable.
1252         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
1253         (QueueView.prototype._readableTimeString): Same.
1254
1255 2016-05-24  Yusuke Suzuki  <utatane.tea@gmail.com>
1256
1257         [JSC][GTK][EFL] Allow run-jsc-benchmark to use WebKitTestRunner in EFL / GTK ports
1258         https://bugs.webkit.org/show_bug.cgi?id=158016
1259
1260         Reviewed by Darin Adler.
1261
1262         This patch easily allows run-jsc-benchmark to run WebKitTestRunner-based tests in GTK / EFL ports.
1263         This change encourages us to run tests with the browser-heap in nix environments.
1264         Two things are modified.
1265
1266         1. Add a fall-back to look up the library path in GTK / EFL / JSCOnly environment.
1267
1268             In GTK / EFL / JSCOnly ports, the hierarchy of the build directory is slightly different from Apple port.
1269             For example, the jsc bin locate at "WebKitBuild/XXX/Release/bin/jsc" and the lib path is "WebKitBuild/XXX/Release/lib"
1270             while the one of Apple port is "WebKitBuild/XXX/Release/jsc" and "WebKitBuild/XXX/Release/lib".
1271             And based on this library path, we configure the required environment variables to run WebKitTestRunner in GTK / EFL ports.
1272
1273         2. Add --dependencies option to add dependent library paths.
1274
1275             While Apple ports does not require any additional dependent library path, GTK and EFL ports require this path,
1276             typically WebKitBuild/DependenciesGTK and WebKitBuild/DependenciesEFL respectively. So we need to add such paths to LD_LIBRARY_PATH.
1277             Instead of adding platform options like --gtk / --efl, we add --dependencies option to add the additional dependent library paths.
1278             The platform options still require the build path to look up the dependent library directory. So we pass it directly through --dependencies.
1279             Multiple additional dependent library paths can be added by using --dependencies multiple times.
1280
1281         By using these change, we can run benchmarks that require WebKitTestRunner in GTK / EFL ports (If you would like to run them in a headless manner, you can use xvbuf.).
1282         Example:
1283             `Tools/Scripts/run-jsc-benchmarks baseline:WebKitBuild/baseline/Release/bin/WebKitTestRunner patched:WebKitBuild/patched/Release/bin/WebKitTestRunner --dependencies WebKitBuild/DependenciesGTK/Root/lib --js-bench`
1284
1285         * Scripts/run-jsc-benchmarks:
1286
1287 2016-05-20  Keith Miller  <keith_miller@apple.com>
1288         We should have JSBench in PerformanceTests
1289         https://bugs.webkit.org/show_bug.cgi?id=157952
1290
1291         Rubber-stamped by Saam Barati.
1292
1293         This changes the runner to use the layout of the newest version of JSBench.
1294
1295         * Scripts/run-jsc-benchmarks:
1296
1297 2016-05-24  Chris Dumez  <cdumez@apple.com>
1298
1299         Use auto for some of our lambda function parameters
1300         https://bugs.webkit.org/show_bug.cgi?id=158001
1301
1302         Reviewed by Darin Adler.
1303
1304         Use auto for some of our lambda function parameters now that we build with c++14.
1305
1306         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1307         (WTR::InjectedBundle::willDestroyPage):
1308
1309 2016-05-23  Brady Eidson  <beidson@apple.com>
1310
1311         check-webkit-style gets flags std::literals::chrono_literals as bad naming.
1312         https://bugs.webkit.org/show_bug.cgi?id=157969
1313
1314         Reviewed by Alex Christensen.
1315
1316         * Scripts/webkitpy/style/checkers/cpp.py:
1317         (check_identifier_name_in_declaration):
1318         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1319         (WebKitStyleTest.test_names):
1320
1321 2016-05-22  Alexey Proskuryakov  <ap@apple.com>
1322
1323         RELEASE_ASSERT(TestController::singleton().isCurrentInvocation(testInvocation)) is sometimes hit when running tests
1324         https://bugs.webkit.org/show_bug.cgi?id=157977
1325         rdar://problem/20874156
1326
1327         Reviewed by David Kilzer.
1328
1329         * WebKitTestRunner/TestInvocation.cpp:
1330         (WTR::TestInvocation::invoke): Be more certain to launch a new process when there was
1331         a timeout detected. If we don't, there is a chance that the process is not quite frozen,
1332         and will still send a response that we no longer expect.
1333         (WTR::TestInvocation::dumpWebProcessUnresponsiveness): Print timeout details to stderr
1334         too, as stdout is not available, at least not in the case that I was observing.
1335
1336 2016-05-22  Brady Eidson  <beidson@apple.com>
1337
1338         Move to C++14.
1339         https://bugs.webkit.org/show_bug.cgi?id=157948
1340
1341         Reviewed by Michael Catanzaro.
1342
1343         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1344         * MiniBrowser/Configurations/Base.xcconfig:
1345         * TestWebKitAPI/Configurations/Base.xcconfig:
1346         * WebKitTestRunner/Configurations/Base.xcconfig:
1347
1348 2016-05-21  Aakash Jain  <aakash_jain@apple.com>
1349
1350         Simulator launch fails intermittently due to failure in checking simulator boot status
1351         https://bugs.webkit.org/show_bug.cgi?id=157965
1352         rdar://problem/26402404
1353
1354         Reviewed by Alexey Proskuryakov.
1355
1356         * Scripts/webkitpy/xcode/simulator.py:
1357         (Simulator.wait_until_device_is_booted): Ignore CalledProcessError exception while checking
1358         whether simulator has finished booting.
1359
1360 2016-05-21  Dan Bernstein  <mitz@apple.com>
1361
1362         Silence warnings from svn propget when using newer versions of Subversion.
1363         https://bugs.webkit.org/show_bug.cgi?id=157879
1364
1365         Reviewed by Daniel Bates.
1366
1367         * Scripts/prepare-ChangeLog:
1368         (attributeCommand): Redirect svn propget stderr to /dev/null.
1369         * Scripts/svn-create-patch:
1370         (findMimeType): Ditto.
1371
1372 2016-05-20  Ryosuke Niwa  <rniwa@webkit.org>
1373
1374         run-benchmark's results should contain Animometer's debug output
1375         https://bugs.webkit.org/show_bug.cgi?id=157941
1376
1377         Reviewed by Stephanie Lewis.
1378
1379         Modified the Animometer patch to store debug output and made benchmark_runner extract them together as a single array.
1380         The result can be dragged and dropped into Animometer's developer.html page.
1381
1382         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1383         (BenchmarkRunner._run_one_test): Parse JSON here instead of doing it in multiple call sites.
1384         (BenchmarkRunner._run_benchmark): Strip debugOutput from individual test result, and merge them together separately.
1385         * Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch:
1386         Modified the patch to store the debug output.
1387         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
1388         (ServerControl.render_POST): Fixed a bug that POST to /report results in 500 because getvalue is not defined
1389         when the request body is larger than a certain size on twisted.
1390
1391 2016-05-20  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
1392
1393         Use clearer names for JSON output of javascriptcore test results
1394         https://bugs.webkit.org/show_bug.cgi?id=157921
1395
1396         Reviewed by Alexey Proskuryakov.
1397
1398         "failures" and "apiTestResult" were somewhat ambiguous names. 
1399         
1400         * Scripts/run-javascriptcore-tests:
1401         (runJSCStressTests): "failures" -> "stressFailures", "apiTestResult" -> "allApiTestsPassed".
1402
1403 2016-05-20  Chris Dumez  <cdumez@apple.com>
1404
1405         Unreviewed, fix API test introduced in r201213.
1406
1407         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
1408         (TestWebKitAPI::TEST):
1409
1410 2016-05-20  Rawinder Singh  <rawinder.singh-webkit@cisra.canon.com.au>
1411
1412         Implement operator== for WeakPtr
1413         https://bugs.webkit.org/show_bug.cgi?id=157883
1414
1415         Reviewed by Chris Dumez.
1416
1417         Implement operator== and operator!= for WeakPtr and update code to use the operators.
1418
1419         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
1420         (TestWebKitAPI::TEST):
1421
1422 2016-05-19  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
1423
1424         Add JSON results to 32-bit and CLoop JSC tests
1425         https://bugs.webkit.org/show_bug.cgi?id=157929
1426
1427         Reviewed by Alexey Proskuryakov.
1428
1429         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1430         (RunLLINTCLoopTests): Change command-line parameters to run-javascriptcore-tests in order to get JSON output.
1431         (Run32bitJSCTests): Change command-line parameters to run-javascriptcore-tests in order to get JSON output.
1432
1433 2016-05-19  Csaba Osztrogonác  <ossy@webkit.org>
1434
1435         Typo fix in import-test262-tests
1436         https://bugs.webkit.org/show_bug.cgi?id=157902
1437
1438         Reviewed by Keith Miller.
1439
1440         * Scripts/import-test262-tests:
1441
1442 2016-05-19  Csaba Osztrogonác  <ossy@webkit.org>
1443
1444         [EFL] Fix the gst-libav build on ARM Thumb2 after r199649
1445         https://bugs.webkit.org/show_bug.cgi?id=157893
1446
1447         Reviewed by Antonio Gomes.
1448
1449         * efl/patches/gst-libav.patch:
1450
1451 2016-05-19  Jer Noble  <jer.noble@apple.com>
1452
1453         REGRESSION(r200951): VideoControlsManager API tests time out
1454         https://bugs.webkit.org/show_bug.cgi?id=157896
1455         <rdar://problem/26326293>
1456
1457         Reviewed by Eric Carlson.
1458
1459         Explicitly disable user gesture requirements for playback.
1460
1461         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1462         (TestWebKitAPI::TEST):
1463
1464 2016-05-19  Csaba Osztrogonác  <ossy@webkit.org>
1465
1466         Slow JSC stress tests times out in 32 bit debug mode
1467         https://bugs.webkit.org/show_bug.cgi?id=154964
1468
1469         Reviewed by Michael Catanzaro.
1470
1471         * Scripts/run-javascriptcore-tests:
1472         (runJSCStressTests): Pass through the --debug option.
1473         * Scripts/run-jsc-stress-tests: Increase the timeout for debug builds.
1474
1475 2016-05-18  Aakash Jain  <aakash_jain@apple.com>
1476
1477         Remove underline from Status Bubbles on dashboard
1478         https://bugs.webkit.org/show_bug.cgi?id=157870
1479         rdar://problem/26332321
1480
1481         Reviewed by Alexey Proskuryakov.
1482
1483         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css: Reverted style 
1484         change made in http://trac.webkit.org/r200880
1485
1486 2016-05-18  Michael Saboff  <msaboff@apple.com>
1487
1488         r199812 broke test262
1489         https://bugs.webkit.org/show_bug.cgi?id=157595
1490
1491         Reviewed by Filip Pizlo.
1492
1493         Added a new run type, runOneLargeHeap, for tests that use a large amount of memory.
1494         This run type will not run with the --memory-limited option.  Without that option,
1495         we'll only the default test variant.
1496
1497         * Scripts/run-jsc-stress-tests:
1498
1499 2016-05-18  Simon Fraser  <simon.fraser@apple.com>
1500
1501         REGRESSION (r200534) Command-+ no longer zooms pages 
1502         https://bugs.webkit.org/show_bug.cgi?id=157826
1503         rdar://problem/26334636
1504
1505         Reviewed by Dean Jackson.
1506
1507         * DumpRenderTree/mac/DumpRenderTree.mm:
1508         (resetWebPreferencesToConsistentValues): Remove ENABLE() #ifdefs that do nothing (see http://webkit.org/b/157828).
1509
1510 2016-05-18  Joanmarie Diggs  <jdiggs@igalia.com>
1511
1512         [GTK] accessibility/meter-element.html is failing
1513         https://bugs.webkit.org/show_bug.cgi?id=115633
1514
1515         Reviewed by Chris Fleizach.
1516
1517         Implement AccessibilityUIElement::valueDescription() and add mapping
1518         from ATK_ROLE_LEVEL_BAR to AXProgressIndicator.
1519
1520         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1521         (WTR::AccessibilityUIElement::valueDescription):
1522
1523 2016-05-18  Brady Eidson  <beidson@apple.com>
1524
1525         Modern IDB: Make TestRunner.clearAllDatabases also delete IndexedDB databases (once doing so is supported).
1526         https://bugs.webkit.org/show_bug.cgi?id=157823
1527
1528         Reviewed by Alex Christensen.
1529
1530         * DumpRenderTree/mac/TestRunnerMac.mm:
1531         (TestRunner::clearAllDatabases):
1532         
1533         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1534         (WTR::TestRunner::clearAllDatabases):
1535         
1536         * WebKitTestRunner/TestInvocation.cpp:
1537         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1538
1539 2016-05-18  Joanmarie Diggs  <jdiggs@igalia.com>
1540
1541         AX: [ATK] Use WebCore Accessibility's AccessibilityText for AtkObject name and description
1542         https://bugs.webkit.org/show_bug.cgi?id=157822
1543
1544         Reviewed by Chris Fleizach.
1545
1546         Fix AccessibilityUIElement::helpText() so that it returns an empty string rather than
1547         nullptr upon failure.
1548
1549         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1550         (WTR::AccessibilityUIElement::helpText):
1551
1552 2016-05-17  Beth Dakin  <bdakin@apple.com>
1553
1554         Make handleAcceptedCandidate a public function
1555         https://bugs.webkit.org/show_bug.cgi?id=157763
1556         -and corresponding-
1557         rdar://problem/26206397
1558
1559         Reviewed by Tim Horton.
1560
1561         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1562         * TestWebKitAPI/Tests/WebKit2Cocoa/autofocused-text-input.html: Added.
1563         * TestWebKitAPI/Tests/mac/ViewWithEditableAreaLeak.mm: Added.
1564         (-[DoNotLeakWebView dealloc]):
1565         (-[DoNotLeakWebView showCandidates:forString:inRect:forSelectedRange:view:completionHandler:]):
1566         (-[DoNotLeakFrameLoadDelegate webView:didFinishLoadForFrame:]):
1567         (TestWebKitAPI::TEST):
1568
1569 2016-05-17  Keith Miller  <keith_miller@apple.com>
1570
1571         Add test262 harness support code
1572         https://bugs.webkit.org/show_bug.cgi?id=157797
1573
1574         Reviewed by Filip Pizlo.
1575
1576         The import-test262-tests script is used to generate the yaml file used to run test262. It
1577         takes a path to the local copy of the Test262 repository as well as an optional path to file
1578         containing a list of failures. This script currently just creates the yaml file used to run
1579         the script. It does not relocate the test files into our tests directory. In the future I
1580         plan to add that feature but it didn't seem essential for the first iteration. Since many
1581         test262 tests need to be run in both strict and non-strict mode, import-test262-tests
1582         creates two separate runs for those tests. This enables us to distinguish between failures
1583         in only one of the two modes.
1584
1585         This patch also updates the run-jsc-stress-tests Script to run tests from Test262. In order
1586         to do so two new run commands were needed runTest262 and prepareTest262Fixture. runTest262
1587         takes an actual test file along with the metadata associated with it. prepareTest262Fixture
1588         takes a fixture file (used by module tests for importing) and makes sure that file is
1589         properly relocated to the test runner directory.
1590
1591         The proccess I used to import the tests was to first run import-test262-tests to create a
1592         yaml for all the tests (import-test262-tests assumes all tests pass if to failures file is
1593         passed). Then I ran the generated yaml file with "run-jsc-stress-tests -v -c 1" piping the
1594         output to a file and collected all the lines with "FAIL" in it. Finally, I reran
1595         import-test262-tests with the new failure file to create the final yaml.
1596
1597         * Scripts/import-test262-tests: Added.
1598         * Scripts/run-jsc-stress-tests:
1599
1600 2016-05-16  Enrica Casucci  <enrica@apple.com>
1601
1602         build fix after r200968 and r200969
1603
1604         Unreviewed.
1605
1606         * DumpRenderTree/mac/EventSendingController.mm:
1607         (-[EventSendingController keyDown:withModifiers:withLocation:]):
1608
1609 2016-05-16  Jer Noble  <jer.noble@apple.com>
1610
1611         API test WebKit2.MSEIsPlayingAudio timing out after r200951
1612         https://bugs.webkit.org/show_bug.cgi?id=157748
1613
1614         Reviewed by Eric Carlson.
1615
1616         The file-with-mse.html testcase only calls play() once it's own XHR loading is complete; the
1617         "user gesture" check fails at that point.  Call play() up front; playback will begin as soon
1618         as enough data is loaded.
1619
1620         * TestWebKitAPI/Tests/WebKit2/file-with-mse.html:
1621
1622 2016-05-16  Enrica Casucci  <enrica@apple.com>
1623
1624         Remove unused initializer for WebEvent on iOS.
1625         https://bugs.webkit.org/show_bug.cgi?id=157689
1626
1627         Reviewed by Anders Carlsson.
1628
1629         Adopting different initializer for WebEvent to fix the build.
1630
1631         * DumpRenderTree/mac/EventSendingController.mm:
1632         (-[EventSendingController keyDown:withModifiers:withLocation:]):
1633
1634 2016-05-16  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
1635
1636         Add machine-readable results for JSC API tests to the Buildbot json log
1637         https://bugs.webkit.org/show_bug.cgi?id=157642
1638
1639         Reviewed by Geoffrey Garen.
1640
1641         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1642         (RunJavaScriptCoreTests): Use --no-fail-fast option on run-javascriptcore-tests
1643         * Scripts/run-javascriptcore-tests:
1644         (runJSCStressTests): Abstracted out writing JSON to file (new function below)
1645         (writeJsonDataIfApplicable): Added
1646
1647 2016-04-06  Jer Noble  <jer.noble@apple.com>
1648
1649         [WK2] Add API to WKWebViewConfiguration to control autoplay policy.
1650         https://bugs.webkit.org/show_bug.cgi?id=156312
1651
1652         Reviewed by Dan Bernstein.
1653
1654         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1655         (WTR::initializeWebViewConfiguration):
1656         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
1657         (TEST_F):
1658
1659 2016-05-16  Brent Fulgham  <bfulgham@apple.com>
1660
1661         REGRESSION (r192098): Content missing after copy and paste to Notes App on retina displays
1662         https://bugs.webkit.org/show_bug.cgi?id=157630
1663         <rdar://problem/25277577>
1664
1665         Reviewed by Simon Fraser.
1666
1667         Update test infrastructure to support checking the number of images in the pasteboard.
1668
1669         * DumpRenderTree/TestRunner.cpp:
1670         (imageCountInGeneralPasteboardCallback): Added.
1671         (TestRunner::staticFunctions):
1672         * DumpRenderTree/TestRunner.h:
1673         * DumpRenderTree/mac/TestRunnerMac.mm:
1674         (TestRunner::imageCountInGeneralPasteboard): Added.
1675         * DumpRenderTree/win/TestRunnerWin.cpp:
1676         (TestRunner::imageCountInGeneralPasteboard): Added stub method.
1677         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1678         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1679         (WTR::InjectedBundle::imageCountInGeneralPasteboard): Added.
1680         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1681         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1682         (WTR::TestRunner::imageCountInGeneralPasteboard): Added.
1683         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1684         * WebKitTestRunner/TestController.cpp:
1685         (WTR::TestController::imageCountInGeneralPasteboard): Added stub implementation.
1686         * WebKitTestRunner/TestController.h:
1687         * WebKitTestRunner/TestInvocation.cpp:
1688         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle): Handle copy message.
1689         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1690         (WTR::TestController::imageCountInGeneralPasteboard): Added.
1691
1692 2016-05-13  Dewei Zhu  <dewei_zhu@apple.com>
1693
1694         Fix JSBench which causes math domain error in run-benchmark script.
1695         https://bugs.webkit.org/show_bug.cgi?id=157697
1696         <rdar://problem/26279292>
1697
1698         Reviewed by Ryosuke Niwa.
1699
1700         Some tests of JSBench give time usage to be 0 ms which will causes error while calculating geometric mean.
1701         Also fix a round-off error while calculating stdev.
1702
1703         * Scripts/webkitpy/benchmark_runner/benchmark_results.py:
1704         (BenchmarkResults._format_values):
1705         * Scripts/webkitpy/benchmark_runner/data/patches/JSBench.patch:
1706
1707 2016-05-13  Brady Eidson  <beidson@apple.com>
1708
1709         Extend protector naming code style guideline to cover operator= assignment.
1710         https://bugs.webkit.org/show_bug.cgi?id=157693
1711
1712         Reviewed by Darin Adler.
1713
1714         * Scripts/webkitpy/style/checkers/cpp.py:
1715         (check_identifier_name_in_declaration):
1716         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1717         (WebKitStyleTest.test_names):
1718
1719 2016-05-13  Aakash Jain  <aakash_jain@apple.com>
1720
1721         Dashboard code restructuring
1722         https://bugs.webkit.org/show_bug.cgi?id=157680
1723         <rdar://problem/14736888>
1724
1725         Reviewed by Alexey Proskuryakov.
1726
1727         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueView.js:
1728         (BubbleQueueView.prototype.addLinkToRow): Moved to base class.
1729         (BubbleQueueView.prototype.addTextToRow): Moved to base class.
1730         (BubbleQueueView.prototype._addDividerToPopover): Moved to base class.
1731         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
1732         (BuildbotBuilderQueueView.prototype.update): Passing additional argument to _appendPendingRevisionCount.
1733         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
1734         (BuildbotCombinedQueueView.prototype.update): Passing additional argument to _appendPendingRevisionCount.
1735         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1736         (BuildbotTesterQueueView.prototype.update): Passing additional argument to _appendPendingRevisionCount.
1737         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1738         (BuildbotQueueView.prototype._appendPendingRevisionCount): Moved to base class and modified to take
1739         additional argument.
1740         (BuildbotQueueView.prototype._popoverLinesForCommitRange): Moved to base class.
1741         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Moved to base class.
1742         (BuildbotQueueView.prototype._addDividerToPopover): Moved to base class.
1743         (BuildbotQueueView.prototype._formatRevisionForDisplay): Moved to base class.
1744         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
1745         (documentReady): Display any customView if available.
1746         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
1747         (QueueView.prototype.addLinkToRow): Moved from child class, no changes.
1748         (QueueView.prototype.addTextToRow): Moved from child class, no changes.
1749         (QueueView.prototype._addDividerToPopover): Moved from child class, no changes.
1750         (QueueView.prototype._appendPendingRevisionCount): Moved from child class, made it more generic
1751         by taking latestIterationGetter method as an argument.
1752         (QueueView.prototype._popoverLinesForCommitRange): Moved from child class, no changes.
1753         (QueueView.prototype._presentPopoverForPendingCommits): Moved from child class, no changes.
1754         (QueueView.prototype._formatRevisionForDisplay): Moved from child class, no changes.
1755         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1756         (a:hover:link): Underline only when there is a link.
1757
1758 2016-05-13  Yoav Weiss  <yoav@yoav.ws>
1759
1760         Turn on WEB_TIMING for all ports
1761         https://bugs.webkit.org/show_bug.cgi?id=157673
1762
1763         Reviewed by Alex Christensen.
1764
1765         * Scripts/webkitperl/FeatureList.pm: Make sure that WEB_TIMING is on by default.
1766
1767 2016-05-13  Brady Eidson  <beidson@apple.com>
1768
1769         Protector Ref/RefPtrs should have a specified naming style.
1770         https://bugs.webkit.org/show_bug.cgi?id=157591
1771
1772         Reviewed by Darin Adler.
1773
1774         * Scripts/webkitpy/style/checkers/cpp.py:
1775         (check_identifier_name_in_declaration):
1776         (CppChecker):
1777         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1778         (WebKitStyleTest.test_names):
1779
1780 2016-05-12  Csaba Osztrogonác  <ossy@webkit.org>
1781
1782         Remove ENABLE(ES6_ARROWFUNCTION_SYNTAX) guards
1783         https://bugs.webkit.org/show_bug.cgi?id=157564
1784
1785         Reviewed by Darin Adler.
1786
1787         * Scripts/webkitperl/FeatureList.pm:
1788         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1789
1790 2016-05-11  Joanmarie Diggs  <jdiggs@igalia.com>
1791
1792         [GTK] accessibility/aria-readonly.html is failing
1793         https://bugs.webkit.org/show_bug.cgi?id=98357
1794
1795         Reviewed by Chris Fleizach.
1796
1797         Add checks to isAttributeSettable() for ATK_STATE_READ_ONLY and the 'readonly'
1798         AtkObject attribute along with ATK_STATE_CHECKABLE for toggle-able elements,
1799         ATK_STATE_SELECTABLE for select elements, and ATK_STATE_FOCUSABLE combined
1800         with range verification for inputs which implement AtkValue. The latter two
1801         additions are admittedly a heuristic workaround for platform accessibility
1802         API differences. But they should be sufficient to facilitate cross-platform
1803         testing of isAttributeSettable() for form elements which lack ARIA attributes.
1804
1805         Bump the minimum version of at-spi2-core and at-spi2-atk
1806         to 2.15.4 (earliest version that supports STATE_READ_ONLY).
1807
1808         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1809         (WTR::AccessibilityUIElement::isAttributeSettable):
1810         * gtk/jhbuild.modules:
1811
1812 2016-05-10  Ryan Haddad  <ryanhaddad@apple.com>
1813
1814         Another attempt to fix the build after r200668.
1815
1816         Unreviewed build fix.
1817
1818         * TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm:
1819         (TEST):
1820
1821 2016-05-10  Dan Bernstein  <mitz@apple.com>
1822
1823         Tried to fix the Mac build after r200668.
1824
1825         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1826         (WTR::TestController::platformCreateWebView):
1827
1828 2016-05-10  Sam Weinig  <sam@webkit.org>
1829
1830         Tweak underline style for data detected links
1831         https://bugs.webkit.org/show_bug.cgi?id=157546
1832
1833         Reviewed by Tim Horton.
1834
1835         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1836         * TestWebKitAPI/Tests/WebCore/Color.cpp: Added.
1837         (TestWebKitAPI::TEST):
1838         Add tests for the new Color::getHSV() function.
1839
1840 2016-05-10  Filip Pizlo  <fpizlo@apple.com>
1841
1842         Internal JSC profiler should have a timestamped log of events for each code block
1843         https://bugs.webkit.org/show_bug.cgi?id=157538
1844
1845         Reviewed by Benjamin Poulain.
1846
1847         * Scripts/display-profiler-output:
1848
1849 2016-05-10  Michael Catanzaro  <mcatanzaro@igalia.com>
1850
1851         [Linux] Remove seccomp filters support
1852         https://bugs.webkit.org/show_bug.cgi?id=157380
1853
1854         Reviewed by Darin Adler.
1855
1856         * Scripts/webkitperl/FeatureList.pm:
1857         * TestWebKitAPI/PlatformEfl.cmake:
1858         * TestWebKitAPI/PlatformGTK.cmake:
1859         * TestWebKitAPI/Tests/WebKit2/SeccompFilters.cpp: Removed.
1860         * efl/jhbuild.modules:
1861         * gtk/jhbuild.modules:
1862
1863 2016-05-09  Simon Fraser  <simon.fraser@apple.com>
1864
1865         [iOS] visibility:hidden -webkit-overflow-scrolling: touch divs can interfere with page scrolling
1866         https://bugs.webkit.org/show_bug.cgi?id=157496
1867         rdar://problem/22963278
1868
1869         Reviewed by Tim Horton.
1870
1871         Enhance UIScriptController to generate a drag, which is useful for scrolling.
1872
1873         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
1874         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
1875         (WTR::UIScriptController::dragFromPointToPoint):
1876         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
1877         * WebKitTestRunner/ios/HIDEventGenerator.h:
1878         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1879         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
1880         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1881         (WTR::UIScriptController::dragFromPointToPoint):
1882
1883 2016-05-09  Simon Fraser  <simon.fraser@apple.com>
1884
1885         Remove testRunner.setTextAutosizingEnabled and migrate the one test that uses it
1886         https://bugs.webkit.org/show_bug.cgi?id=157480
1887
1888         Reviewed by Zalan Bujtas.
1889
1890         Migrate the one test that used testRunner.setTextAutosizingEnabled() to window.internals.settings.setTextAutosizingEnabled()
1891         and move it next to the other iOS text autosizing tests.
1892         
1893         Remove testRunner.setTextAutosizingEnabled(), which was only implemented in DumpRenderTree.
1894
1895         * DumpRenderTree/TestRunner.cpp:
1896         (setTextAutosizingEnabledCallback): Deleted.
1897         (TestRunner::staticFunctions): Deleted.
1898         * DumpRenderTree/mac/TestRunnerMac.mm:
1899         (TestRunner::setTextAutosizingEnabled): Deleted.
1900
1901 2016-05-07  Darin Adler  <darin@apple.com>
1902
1903         Next step on dictionary bindings, along with other bindings refinements
1904         https://bugs.webkit.org/show_bug.cgi?id=157451
1905
1906         Reviewed by Chris Dumez.
1907
1908         * Scripts/do-webcore-rename: Use this to rename JSDOMBuild.h to JSDOMConvert.h.
1909         Also skip test expectations in a directory that this was modifying unnecessarily.
1910
1911 2016-05-06  Simon Fraser  <simon.fraser@apple.com>
1912
1913         Enable IOS_TEXT_AUTOSIZING on Mac and make it testable
1914         https://bugs.webkit.org/show_bug.cgi?id=157432
1915         rdar://problem/16406720
1916
1917         Reviewed by Dean Jackson.
1918
1919         Enable IOS_TEXT_AUTOSIZING on Mac so it can be tested.
1920
1921         Make the setTextAutosizingEnabled() Setting work, and plumb it through WK1 and WK2
1922         preferences for WTR and DRT. Make textAutosizingWindowSizeOverride() work, for layout tests.
1923         These two settings are shared with TEXT_AUTOSIZING.
1924
1925         Add a TextAutosizing log channel, which is useful for generated -expected.html results.
1926
1927         Move adjustComputedFontSizesOnBlocks() and related code from RenderObject to RenderElement
1928         without changes.
1929
1930         An implication of this set of changes is that the way clients enable text autosizing
1931         has changed. Previously, they set the "MinimumZoomFontSize" preference to 0.
1932         Settings::defaultMinimumZoomFontSize() used to do this in order to enable text autosizing
1933         on iPhone only, not iPad.
1934
1935         Now the preferred technique is to leave minimumZoomFontSize alone, and to use textAutosizingEnabled()
1936         instead. Settings::defaultTextAutosizingEnabled() now does the check for iPhone.
1937
1938         UIWebView calls WebKitGetMinimumZoomFontSize() to setup the default minimum font zoom size,
1939         which will now always return 15, but had no other code that toggled this. So it's safe to just rely
1940         on Settings::defaultTextAutosizingEnabled() doing the right thing for iPhone/iPad.
1941
1942         * DumpRenderTree/mac/DumpRenderTree.mm:
1943         (resetWebPreferencesToConsistentValues):
1944         * DumpRenderTree/mac/TestRunnerMac.mm:
1945         (TestRunner::setTextAutosizingEnabled):
1946         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1947         * WebKitTestRunner/ios/TestControllerIOS.mm:
1948         (WTR::TestController::platformResetPreferencesToConsistentValues):
1949
1950 2016-05-06  Dean Jackson  <dino@apple.com>
1951
1952         Regions, Shapes and Tracks don't need runtime features
1953         https://bugs.webkit.org/show_bug.cgi?id=157426
1954         <rdar://problem/26146262>
1955
1956         Reviewed by Simon Fraser.
1957
1958         The following RuntimeEnabledFeatures can be removed since
1959         we have no need to disable them (they are stable and have
1960         shipped for a while):
1961         - CSS Regions
1962         - CSS Shapes
1963         - Media tracks
1964
1965         * DumpRenderTree/mac/DumpRenderTree.mm:
1966         (resetWebPreferencesToConsistentValues): Deleted.
1967
1968 2016-05-06  Ryan Haddad  <ryanhaddad@apple.com>
1969
1970         Increase delay when launching multiple ios-simulators in parallel
1971         https://bugs.webkit.org/show_bug.cgi?id=157422
1972
1973         Reviewed by Alexey Proskuryakov.
1974
1975         Tests are intermittently failing when launching multiple simulators in parallel due to "You are opening
1976         this application for the first time" confirmation dialogs. Increasing the delay to alleviate this issue.
1977
1978         * Scripts/webkitpy/port/ios.py:
1979         (IOSSimulatorPort.setup_test_run):
1980
1981 2016-05-06  Per Arne Vollan  <peavo@outlook.com>
1982
1983         [Win] Remove WinXP support.
1984         https://bugs.webkit.org/show_bug.cgi?id=157416
1985
1986         Reviewed by Brent Fulgham.
1987
1988         * win/DLLLauncher/DLLLauncherMain.cpp:
1989         (enableTerminationOnHeapCorruption):
1990
1991 2016-05-06  Manuel Rego Casasnovas  <rego@igalia.com>
1992
1993         [css-grid] Unprefix CSS Grid Layout properties
1994         https://bugs.webkit.org/show_bug.cgi?id=157137
1995
1996         Reviewed by Simon Fraser.
1997
1998         Remove "-webkit" prefix from all the grid layout properties,
1999         including the display value.
2000         Update the source code to remove the prefix where it was used too.
2001
2002         * TestWebKitAPI/Tests/WebCore/CSSParser.cpp:
2003         (TestWebKitAPI::TEST):
2004
2005 2016-05-05  Alexey Proskuryakov  <ap@apple.com>
2006
2007         Partially revert http://trac.webkit.org/r200504
2008         Improve HTTP test names in WebKitTestRunner's crash report information
2009         https://bugs.webkit.org/show_bug.cgi?id=157389
2010
2011         * WebKitTestRunner/cocoa/CrashReporterInfo.mm: Turns out that we can't have URLs
2012         in crash reporter information.
2013
2014 2016-05-05  Alexey Proskuryakov  <ap@apple.com>
2015
2016         Improve HTTP test names in WebKitTestRunner's crash report information
2017         https://bugs.webkit.org/show_bug.cgi?id=157389
2018
2019         Reviewed by Alex Christensen.
2020
2021         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
2022         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame): Added a FIXME.
2023
2024         * WebKitTestRunner/cocoa/CrashReporterInfo.mm:
2025         (WTR::testDescription): Don't bail out if the port is neither 8000 nor 8443; we
2026         use other port numbers too. For http tests, return the complete URL string, not
2027         just the path.
2028
2029 2016-05-04  Alex Christensen  <achristensen@webkit.org>
2030
2031         Blocked redirected main resource requests need descriptive errors
2032         https://bugs.webkit.org/show_bug.cgi?id=156828
2033         rdar://problem/25711316
2034
2035         Reviewed by Daniel Bates.
2036
2037         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2038         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
2039         Print out the error type to make sure we have the most descriptive error type.
2040
2041 2016-05-05  Enrique Ocaña González  <eocanha@igalia.com>
2042
2043         [GStreamer] Bump internal jhbuild versions to 1.8.0 and patches to support MSE
2044         https://bugs.webkit.org/show_bug.cgi?id=157341
2045
2046         Reviewed by Xabier Rodriguez-Calvar.
2047
2048         * gtk/jhbuild.modules:
2049         * gtk/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Added.
2050         * gtk/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Added.
2051
2052 2016-05-04  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
2053
2054         Add JSC test results in JSON format to a Buildbot log
2055         https://bugs.webkit.org/show_bug.cgi?id=156920
2056
2057         Reviewed by Daniel Bates.
2058
2059         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2060         (RunJavaScriptCoreTests): Move command-line option for output file out
2061         of WithProperties.
2062
2063 2016-05-04  Dean Jackson  <dino@apple.com>
2064
2065         TestRunner should always enable all the experimental features
2066         https://bugs.webkit.org/show_bug.cgi?id=157360
2067         <rdar://problem/26099748>
2068
2069         Reviewed by Anders Carlsson.
2070
2071         Call the new SPI that enables all the experimental features.
2072
2073         * WebKitTestRunner/TestController.cpp:
2074         (WTR::TestController::resetPreferencesToConsistentValues):
2075
2076 2016-05-04  Mark Lam  <mark.lam@apple.com>
2077
2078         ES6 Function.name inferred from property names of literal objects can break some websites.
2079         https://bugs.webkit.org/show_bug.cgi?id=157246
2080
2081         Reviewed by Geoffrey Garen.
2082
2083         * WebKitTestRunner/TestController.cpp:
2084         (WTR::TestController::resetPreferencesToConsistentValues):
2085         (WTR::updateTestOptionsFromTestHeader):
2086         * WebKitTestRunner/TestOptions.h:
2087
2088         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2089         (WTR::PlatformWebView::viewSupportsOptions):
2090         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2091         (WTR::PlatformWebView::viewSupportsOptions):
2092         - Add needsSiteSpecificQuirks to WKTR options that can be set. 
2093
2094 2016-05-04  Joanmarie Diggs  <jdiggs@igalia.com>
2095
2096         AX: ARIA 'region' role is now a landmark; HTML 'section' element should be a landmark only if named
2097         https://bugs.webkit.org/show_bug.cgi?id=157331
2098
2099         Reviewed by Chris Fleizach.
2100
2101         Add AXLandmarkRegion to the landmark strings handled by roleToString
2102         for objects with ATK_ROLE_LANDMARK.
2103
2104         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2105
2106 2016-05-03  Beth Dakin  <bdakin@apple.com>
2107
2108         Add VideoControlsManager tests
2109         https://bugs.webkit.org/show_bug.cgi?id=157332
2110         -and corresponding-
2111         rdar://problem/24358431
2112
2113         Reviewed by Sam Weinig.
2114
2115         This patch adds three VideoControlsManager tests.
2116
2117         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2118         * TestWebKitAPI/Tests/WebKit/ios/video-with-audio.html:
2119         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm: Added.
2120         (-[DidPlayMessageHandler initWithWKWebView:]):
2121         (-[DidPlayMessageHandler userContentController:didReceiveScriptMessage:]):
2122         (TestWebKitAPI::TEST):
2123         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-with-audio.html: Added.
2124         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-with-audio.mp4: Added.
2125         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-without-audio.html: Added.
2126
2127 2016-05-03  Joanmarie Diggs  <jdiggs@igalia.com>
2128
2129         [ATK] accessibility/document-attributes.html is failing
2130         https://bugs.webkit.org/show_bug.cgi?id=125348
2131
2132         Reviewed by Chris Fleizach.
2133
2134         The test was failing because the WebArea is now being exposed with the role of
2135         ATK_ROLE_DOCUMENT_WEB; not ATK_ROLE_DOCUMENT_FRAME. Unfortunately, when that
2136         change was made, documentEncoding() and documentURI() were not updated accordingly.
2137
2138         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2139         (WTR::AccessibilityUIElement::documentEncoding):
2140         (WTR::AccessibilityUIElement::documentURI):
2141
2142 2016-05-03  Brent Fulgham  <bfulgham@apple.com>
2143
2144         [Win] Unreviewed build fix.
2145
2146         * EWSTools/start-queue-win.sh: Establish proper VS2015 build
2147         environment at start of queue run.
2148
2149 2016-05-03  Joanmarie Diggs  <jdiggs@igalia.com>
2150
2151         [ATK] accessibility/content-editable-as-textarea.html fails
2152         https://bugs.webkit.org/show_bug.cgi?id=155353
2153
2154         Reviewed by Darin Adler.
2155
2156         The test was timing out because it expected an AXValueChanged notification.
2157         In ATK, AXValueChanged notifications are made for widgets which implement
2158         the AtkValue interface (sliders, progress bars, etc.). We should be listening
2159         for AXTextChanged instead. AtkText's text-insert and text-remove have been
2160         added to the AccessibilityNotificationHandler.
2161
2162         Also, ATK's AccessibilityUIElement support had a number of unimplemented
2163         methods that are being used as part of the previously-failing test. Those
2164         methods are now implemented so that the ATK results are much more similar
2165         to those on the Mac.
2166
2167         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
2168         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks):
2169         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2170         (WTR::AccessibilityUIElement::stringAttributeValue):
2171         (WTR::AccessibilityUIElement::rangeForLine):
2172         (WTR::AccessibilityUIElement::boundsForRange):
2173         (WTR::AccessibilityUIElement::attributedStringForRange):
2174
2175 2016-05-02  Brady Eidson  <beidson@apple.com>
2176
2177         Add the ability to accumulate logs for specific logging channels to help diagnose test timeouts.
2178         https://bugs.webkit.org/show_bug.cgi?id=157274
2179
2180         Reviewed by Alex Christensen.
2181
2182         Add the new accumulate method to DRT's TestRunner, dump the accumulated logs if there's a timeout,
2183         and reset them in between tests:
2184         * DumpRenderTree/TestRunner.cpp:
2185         (accummulateLogsForChannel):
2186         (TestRunner::staticFunctions):
2187         (TestRunner::waitToDumpWatchdogTimerFired):
2188         (TestRunner::setAccummulateLogsForChannel):
2189         * DumpRenderTree/TestRunner.h:
2190         * DumpRenderTree/mac/DumpRenderTree.mm:
2191         (resetWebViewToConsistentStateBeforeTesting):
2192
2193         Also add the new method to WKTR's TestRunner, but just stubbed for now:
2194         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2195         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2196         (WTR::TestRunner::accummulateLogsForChannel):
2197         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2198
2199 2016-05-02  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
2200
2201         Add fail-fast option to run-javascriptcore-tests
2202         https://bugs.webkit.org/show_bug.cgi?id=157270
2203
2204         Reviewed by Geoffrey Garen.
2205
2206         * Scripts/run-javascriptcore-tests: Add fail-fast command line option.
2207         Defaults to yes, which is the current behavior.
2208
2209 2016-05-02  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2210
2211         [CMake] MiniBrowser fails to build because libsoup link flags are not defined.
2212         https://bugs.webkit.org/show_bug.cgi?id=157268
2213
2214         Reviewed by Michael Catanzaro.
2215
2216         * MiniBrowser/gtk/CMakeLists.txt:
2217
2218 2016-04-30  Darin Adler  <darin@apple.com>
2219
2220         Streamline and remove unused bindings generation code
2221         https://bugs.webkit.org/show_bug.cgi?id=157237
2222
2223         Reviewed by Chris Dumez.
2224
2225         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
2226         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2227         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2228         Replace non-standard "int" with standard "long", which means the same thing.
2229
2230 2016-04-30  Darin Adler  <darin@apple.com>
2231
2232         Next batch of conversions to use C++ enum class instead of strings for enumerations
2233         https://bugs.webkit.org/show_bug.cgi?id=157232
2234
2235         Reviewed by Chris Dumez.
2236
2237         * Scripts/webkitpy/style/checker.py: Skip the bindings script tests when doing style
2238         checking. We don't want to waste time trying to make our generated code match our style.
2239
2240 2016-04-29  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
2241
2242         Add JSC test results in JSON format to a Buildbot log.
2243         https://bugs.webkit.org/show_bug.cgi?id=156920
2244
2245         Reviewed by Daniel Bates.
2246
2247         Generate JSON results for JSC tests and upload them to the master
2248         using Buildbot's logfiles machinery.
2249
2250         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2251         (RunJavaScriptCoreTests): Use --json-output option when invoking the
2252         run-javascriptcore-tests Perl script, and expose this JSON output as a 
2253         Buildbot log.
2254         * Scripts/run-javascriptcore-tests:
2255         (runJSCStressTests): Change key names and remove redundant count key.
2256
2257 2016-04-29  Joanmarie Diggs  <jdiggs@igalia.com>
2258
2259         [ATK] Expose the value of aria-roledescription via an AtkObject attribute
2260         https://bugs.webkit.org/show_bug.cgi?id=146719
2261
2262         Reviewed by Chris Fleizach.
2263
2264         Implement roleDescription() so that the implementation can be tested.
2265
2266         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2267         (WTR::AccessibilityUIElement::roleDescription):
2268
2269 2016-04-27  Alexey Proskuryakov  <ap@apple.com>
2270
2271         Don't throttle GuardMalloc on 8-core Macs
2272         https://bugs.webkit.org/show_bug.cgi?id=157108
2273
2274         Reviewed by Alex Christensen.
2275
2276         This was making them slower unnecessarily.
2277
2278         * Scripts/webkitpy/port/mac.py: (MacPort.default_child_processes):
2279
2280 2016-04-26  Konstantin Tokarev  <annulen@yandex.ru>
2281
2282         Unreviewed: add myself to the committers list.
2283
2284         * Scripts/webkitpy/common/config/contributors.json:
2285
2286 2016-04-26  Ryosuke Niwa  <rniwa@webkit.org>
2287
2288         Fix text in log files autogenerated by import-w3c-tests
2289         https://bugs.webkit.org/show_bug.cgi?id=157021
2290
2291         Unreviewed. Fixing the second typo.
2292
2293         * Scripts/webkitpy/w3c/test_importer.py:
2294         (TestImporter.write_import_log):
2295
2296 2016-04-26  Filip Pizlo  <fpizlo@apple.com>
2297
2298         WebCore on Mac ignores the user's preferred region (country) while getting the language
2299         https://bugs.webkit.org/show_bug.cgi?id=156993
2300
2301         Reviewed by Geoffrey Garen.
2302
2303         Change the test expectations for this test. If the variant is not explicitly specified in
2304         the AppleLanguage, then we use the locale's country code, which this test assumes is US.
2305
2306         * TestWebKitAPI/Tests/mac/NavigatorLanguage.mm:
2307         (TestWebKitAPI::languageForSystemLanguage):
2308         (TestWebKitAPI::TEST):
2309
2310 2016-04-25  Ryosuke Niwa  <rniwa@webkit.org>
2311
2312         Remove the build flag for template elements
2313         https://bugs.webkit.org/show_bug.cgi?id=157022
2314
2315         Reviewed by Daniel Bates.
2316
2317         Removed the build option.
2318
2319         * Scripts/webkitperl/FeatureList.pm:
2320
2321 2016-04-25  Ryosuke Niwa  <rniwa@webkit.org>
2322
2323         Fix text in log files autogenerated by import-w3c-tests
2324         https://bugs.webkit.org/show_bug.cgi?id=157021
2325
2326         Reviewed by Chris Dumez.
2327
2328         s/Webkit/WebKit/ and end each sentence with a period.
2329
2330         * Scripts/webkitpy/w3c/test_importer.py:
2331         (TestImporter.write_import_log):
2332
2333 2016-04-25  Myles C. Maxfield  <mmaxfield@apple.com>
2334
2335         [Cocoa] Guarantee FontPlatformData's m_cgFont is never nullptr
2336         https://bugs.webkit.org/show_bug.cgi?id=156929
2337
2338         Reviewed by Darin Adler.
2339
2340         * TestWebKitAPI/Tests/mac/StringTruncator.mm:
2341         (TestWebKitAPI::TEST):
2342
2343 2016-04-25  Caitlin Potter  <caitp@igalia.com>
2344
2345         [Tools] whitelist all-uppercase JSTokenType enum in JavaScriptCore
2346         https://bugs.webkit.org/show_bug.cgi?id=156976
2347
2348         Reviewed by Darin Adler.
2349
2350         Mitigate style-checker spam on bugs which introduce new JavaScript
2351         token types.
2352
2353         * Scripts/webkitpy/style/checkers/cpp.py:
2354         (_EnumState.__init__):
2355         (_EnumState.process_clean_line):
2356         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2357         (NoNonVirtualDestructorsTest.test_enum_casing):
2358
2359 2016-04-25  Simon Fraser  <simon.fraser@apple.com>
2360
2361         Fix issues with content-animation performance tests
2362         https://bugs.webkit.org/show_bug.cgi?id=157001
2363
2364         Reviewed by Sam Weinig.
2365
2366         Add patch content for svg-animation.html, and fix the paths in the patch so
2367         it applies correctly.
2368
2369         Add the patch file to the .plan file.
2370
2371         * Scripts/webkitpy/benchmark_runner/data/patches/ContentAnimation.patch:
2372         * Scripts/webkitpy/benchmark_runner/data/plans/content-animation.plan:
2373
2374 2016-04-25  Brady Eidson  <beidson@apple.com>
2375
2376         Tweaking IndexedDB watchlist and adding myself to it.
2377
2378         * Scripts/webkitpy/common/config/watchlist:
2379
2380 2016-04-25  Commit Queue  <commit-queue@webkit.org>
2381
2382         Unreviewed, rolling out r199916.
2383         https://bugs.webkit.org/show_bug.cgi?id=156989
2384
2385         Might break buildbot when master is restarted (Requested by
2386         Srinivasan Vijayaraghava, Guest100, on #webkit).
2387
2388         Reverted changeset:
2389
2390         "Add JSC test results in json format to a buildbot log"
2391         https://bugs.webkit.org/show_bug.cgi?id=156920
2392         http://trac.webkit.org/changeset/199916
2393
2394 2016-04-23  Chris Dumez  <cdumez@apple.com>
2395
2396         [WebIDL] Drop [Default] WebKit-IDL extended attribute
2397         https://bugs.webkit.org/show_bug.cgi?id=156955
2398
2399         Reviewed by Darin Adler.
2400
2401         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2402
2403 2016-04-23  Csaba Osztrogonác  <ossy@webkit.org>
2404
2405         Really enable INDEXED_DATABASE on Apple Mac cmake build
2406         https://bugs.webkit.org/show_bug.cgi?id=156902
2407
2408         Reviewed by Michael Catanzaro.
2409
2410         * Scripts/webkitperl/FeatureList.pm:
2411
2412 2016-04-23  Andy Estes  <aestes@apple.com>
2413
2414         check-webkit-style: fix false-positive warnings about @synchronized
2415         https://bugs.webkit.org/show_bug.cgi?id=156957
2416
2417         Reviewed by Dan Bernstein.
2418
2419         * Scripts/webkitpy/style/checkers/cpp.py:
2420         (check_spacing_for_function_call): Ignore @synchronized lines.
2421         (check_braces): Ditto.
2422         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2423         (CppStyleTest.test_brace_at_begin_of_line): Added a test case.
2424
2425 2016-04-22  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
2426
2427         Add JSC test results in json format to a buildbot log
2428         https://bugs.webkit.org/show_bug.cgi?id=156920
2429
2430         Reviewed by Alexey Proskuryakov.
2431
2432         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2433         (RunJavaScriptCoreTests):
2434         Add runtime flag to output json into buildbot
2435         * Scripts/run-javascriptcore-tests:
2436         (runJSCStressTests):
2437         Change key names and remove redundant count key
2438
2439 2016-04-22  Ryan Haddad  <ryanhaddad@apple.com>
2440
2441         Update expected result for WKPreferencesGetOfflineWebApplicationCacheEnabled after r199854
2442
2443         Unreviewed test gardening.
2444
2445         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
2446         (TestWebKitAPI::TEST):
2447
2448 2016-04-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2449
2450         [GTK] Enable the download attribute support
2451         https://bugs.webkit.org/show_bug.cgi?id=99025
2452
2453         Reviewed by Žan Doberšek.
2454
2455         * Scripts/webkitperl/FeatureList.pm:
2456
2457 2016-04-21  Keith Miller  <keith_miller@apple.com>
2458
2459         WebScriptObject description swizzler should work in a multi-threaded world
2460         https://bugs.webkit.org/show_bug.cgi?id=156808
2461
2462         Add a test for our NSObject swizzling TLS implementation. The test runs on
2463         two threads. One in JS and another in Objective-C. We expect the JS thread
2464         to use our NSObject description override and the Objective-C thread to act
2465         as though it was using the original NSObject description method.
2466
2467         Reviewed by Geoffrey Garen.
2468
2469         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2470         * TestWebKitAPI/Tests/mac/WebScriptObjectDescription.html: Added.
2471         * TestWebKitAPI/Tests/mac/WebScriptObjectDescription.mm: Added.
2472         (nsObjectDescriptionTest):
2473         (-[WebScriptDescriptionTest webView:didFinishLoadForFrame:]):
2474         (TestWebKitAPI::TEST):
2475
2476 2016-04-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2477
2478         [GTK] WebKitWebView should claim the contents size as its natural size
2479         https://bugs.webkit.org/show_bug.cgi?id=156835
2480
2481         Reviewed by Žan Doberšek.
2482
2483         Add test case to check the WebKitWebView preferred size.
2484
2485         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2486         (testWebViewPreferredSize):
2487         (beforeAll):
2488
2489 2016-04-20  Simon Fraser  <simon.fraser@apple.com>
2490
2491         Add content animation tests to benchmark_runner, and allow the runner to collect device data as part of the results
2492         https://bugs.webkit.org/show_bug.cgi?id=156827
2493         
2494         Update the .plan file now that the files are present in SVN.
2495
2496         * Scripts/webkitpy/benchmark_runner/data/plans/content-animation.plan:
2497
2498 2016-04-20  Simon Fraser  <simon.fraser@apple.com>
2499
2500         Add content animation tests to benchmark_runner, and allow the runner to collect device data as part of the results
2501         https://bugs.webkit.org/show_bug.cgi?id=156827
2502         rdar://problem/24358135
2503
2504         Reviewed by Stephanie Lewis.
2505
2506         Enhance benchmark_runner so that a benchmark can load a set of tests sequentially,
2507         and collate results across them. Also add the ability for the browser_driver to supply
2508         additional results, allowing for tests that collect results data in native code, rather
2509         than generating it in the web page.
2510
2511         Add a set of "content animation" tests that use this new functionality, which test
2512         CSS animation and requestAnimationFrame performance.
2513
2514         'plan' files have two new optional keys:
2515             'test_files': a list of files to run as a suite
2516             'options': optional parameters. Currently supports one new option,
2517                 'animation_command', which affects the way that iOS tests are run,
2518                 and is passed to MobileSafari as a parameter on launch.
2519
2520         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2521         (BenchmarkRunner.__init__): If options is not specified in the plan file, set it to an empty dictionary.
2522         (BenchmarkRunner._get_result): Allow the browser_driver to modify the test results.
2523         (BenchmarkRunner):
2524         (BenchmarkRunner._run_one_test): Factored out of _run_benchmark, this contains logic for
2525         running a single test. It starts and stops the http_server_driver.
2526         (BenchmarkRunner._run_benchmark): Run a test in the traditional way if the plan has an 'entry_point'
2527         key, otherwise look for the new 'test_files' and load each in a loop.
2528         (BenchmarkRunner._dump):
2529         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
2530         (BrowserDriver.launch_url): Pass options.
2531         (BrowserDriver.add_additional_results): Allow a driver to supply additional results.
2532         (BrowserDriver):
2533         * Scripts/webkitpy/benchmark_runner/browser_driver/gtk_minibrowser_driver.py:
2534         (GTKMiniBrowserDriver.launch_url):
2535         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
2536         (OSXBrowserDriver.close_browsers):
2537         (OSXBrowserDriver._terminate_processes): Fix spelling mistake.
2538         (OSXBrowserDriver._terminiate_processes): Deleted.
2539         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
2540         (OSXChromeDriver.launch_url):
2541         (OSXChromeCanaryDriver.launch_url):
2542         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
2543         (OSXFirefoxDriver.launch_url):
2544         (OSXFirefoxNightlyDriver.launch_url):
2545         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
2546         (OSXSafariDriver.launch_url):
2547         * Scripts/webkitpy/benchmark_runner/data/patches/ContentAnimation.patch: Added.
2548         * Scripts/webkitpy/benchmark_runner/data/plans/content-animation.plan: Added.
2549
2550 2016-04-20  Dustin Falgout  <dustin@falgout.us>
2551
2552         [GTK] Expose AllowUniversalAccessFromFileURLs preference now that calling localStorage.getItem() results in SecurityError: DOM Exception 18
2553         https://bugs.webkit.org/show_bug.cgi?id=156651
2554
2555         Reviewed by Michael Catanzaro.
2556
2557         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
2558         (testWebKitSettings):
2559
2560 2016-04-20  Brady Eidson  <beidson@apple.com>
2561
2562         Modern IDB (Workers): Enable INDEXED_DATABASE_IN_WORKERS compile time flag, but disabled in RuntimeEnabledFeatures.
2563         https://bugs.webkit.org/show_bug.cgi?id=156782
2564
2565         Reviewed by Alex Christensen.
2566
2567         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2568
2569 2016-04-19  Brent Fulgham  <bfulgham@apple.com>
2570
2571         Unreviewed build fix after r199752.
2572
2573         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2574         (FrameLoadDelegate::didChangeIcons): Remove call to removed function.
2575
2576 2016-04-19  Brent Fulgham  <bfulgham@apple.com>
2577
2578         Remove remaining bits of dynamic <link> rel='icon' loading
2579         https://bugs.webkit.org/show_bug.cgi?id=156727
2580
2581         Reviewed by Darin Adler.
2582
2583         Remove unused test infrastructure. This code never existed in WebKit2
2584         testing since was only used on Windows.
2585
2586         * DumpRenderTree/TestRunner.cpp:
2587         (dumpIconChangesCallback): Deleted.
2588         * DumpRenderTree/TestRunner.h:
2589         (TestRunner::dumpIconChanges): Deleted.
2590         (TestRunner::setDumpIconChanges): Deleted.
2591
2592 2016-04-19  Keith Miller  <keith_miller@apple.com>
2593
2594         ObjcInstance::stringValue should not call NSObject's description method
2595         https://bugs.webkit.org/show_bug.cgi?id=156758
2596
2597         Reviewed by Geoffrey Garen.
2598
2599         Add new methods to ObjCController that expose two Types of WebScriptObjects. The first is
2600         an NSObject and the second is an NSArray of NSObjects. These are used to test that we don't
2601         call the NSObjects description method without first swizzling it.
2602
2603         * DumpRenderTree/mac/ObjCController.m:
2604         (+[ObjCController isSelectorExcludedFromWebScript:]):
2605         (+[ObjCController webScriptNameForSelector:]):
2606         (-[ObjCController testArrayOfObjects]):
2607         (-[ObjCController testObject]):
2608
2609 2016-04-18  Dan Bernstein  <mitz@apple.com>
2610
2611         Fixed building with old Xcode.
2612
2613         * TestWebKitAPI/Tests/WebKit2Cocoa/Preferences.mm:
2614         (TEST):
2615
2616 2016-04-18  Dean Jackson  <dino@apple.com>
2617
2618         New SPI to export a dictionary of runtime features
2619         https://bugs.webkit.org/show_bug.cgi?id=156645
2620         <rdar://problem/23621666>
2621
2622         Reviewed by Darin Adler.
2623
2624         Test the experimental features SPI on WKPreferences.
2625
2626         * TestWebKitAPI/Tests/WebKit2Cocoa/Preferences.mm:
2627
2628 2016-04-18  Yusuke Suzuki  <utatane.tea@gmail.com>
2629
2630         [JSCOnly] Implement RunLoop and remove glib dependency
2631         https://bugs.webkit.org/show_bug.cgi?id=155706
2632
2633         Reviewed by Michael Catanzaro.
2634
2635         Add TestWTF to JSCOnly port to test WorkQueue and RunLoop.
2636         Platform specific ones locate under jsconly directory since
2637         it is not `generic` (Since it includes the GLIB event loop case).
2638
2639         * CMakeLists.txt:
2640         * TestWebKitAPI/PlatformJSCOnly.cmake: Added.
2641         * TestWebKitAPI/PlatformUtilities.h:
2642         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
2643         (TestWebKitAPI::TEST):
2644         * TestWebKitAPI/config.h:
2645         * TestWebKitAPI/jsconly/PlatformUtilitiesJSCOnly.cpp: Renamed from Source/WTF/wtf/none/RunLoopNone.cpp.
2646         (TestWebKitAPI::Util::run):
2647         (TestWebKitAPI::Util::sleep):
2648         * TestWebKitAPI/jsconly/main.cpp: Renamed from Source/WTF/wtf/none/WorkQueueNone.cpp.
2649         (main):
2650
2651 2016-04-18  Jon Lee  <jonlee@apple.com>
2652
2653         Update Animometer plan.
2654         https://bugs.webkit.org/show_bug.cgi?id=156652
2655
2656         Reviewed by Darin Adler.
2657
2658         * Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan: Update to r199616.
2659
2660 2016-04-18  Dana Burkart  <dburkart@apple.com>
2661
2662         svn-apply: add option for ignoring changes to ChangeLog files
2663         https://bugs.webkit.org/show_bug.cgi?id=156618
2664
2665         Reviewed by Darin Adler.
2666
2667         This change adds a new option to svn-apply, --skip-changelogs, which short-circuits out of
2668         patch() if the file in question is a ChangeLog.
2669
2670         * Scripts/svn-apply:
2671         (patch):
2672
2673 2016-04-18  Carlos Garcia Campos  <cgarcia@igalia.com>
2674
2675         Pending API Request URL is wrong after reloading
2676         https://bugs.webkit.org/show_bug.cgi?id=139342
2677
2678         Reviewed by Darin Adler.
2679
2680         Update test case to check that the active URL should remain the
2681         same after a reload.
2682
2683         * TestWebKitAPI/Tests/WebKit2/PendingAPIRequestURL.cpp:
2684         (TestWebKitAPI::TEST):
2685
2686 2016-04-18  Carlos Garcia Campos  <cgarcia@igalia.com>
2687
2688         Pending API request URL no set when loading Data, Alternate HTML or plain text
2689         https://bugs.webkit.org/show_bug.cgi?id=136916
2690
2691         Reviewed by Darin Adler.
2692
2693         Add new test to check that active URL is the requested one right
2694         after calling WKPage load methods.
2695
2696         * TestWebKitAPI/PlatformEfl.cmake:
2697         * TestWebKitAPI/PlatformGTK.cmake:
2698         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2699         * TestWebKitAPI/Tests/WebKit2/PendingAPIRequestURL.cpp: Added.
2700         (TestWebKitAPI::TEST):
2701         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
2702         (WebViewTest::loadPlainText): Remove FIXME.
2703         (WebViewTest::loadBytes): Ditto.
2704         (WebViewTest::loadAlternateHTML): Ditto.
2705
2706 2016-04-18  Commit Queue  <commit-queue@webkit.org>
2707
2708         Unreviewed, rolling out r199660.
2709         https://bugs.webkit.org/show_bug.cgi?id=156691
2710
2711         It broke the iOS build (Requested by KaL on #webkit).
2712
2713         Reverted changeset:
2714
2715         "Pending API request URL no set when loading Data, Alternate
2716         HTML or plain text"
2717         https://bugs.webkit.org/show_bug.cgi?id=136916
2718         http://trac.webkit.org/changeset/199660
2719
2720 2016-04-18  Carlos Garcia Campos  <cgarcia@igalia.com>
2721
2722         Pending API request URL no set when loading Data, Alternate HTML or plain text
2723         https://bugs.webkit.org/show_bug.cgi?id=136916
2724
2725         Reviewed by Darin Adler.
2726
2727         Add new test to check that active URL is the requested one right
2728         after calling WKPage load methods.
2729
2730         * TestWebKitAPI/PlatformEfl.cmake:
2731         * TestWebKitAPI/PlatformGTK.cmake:
2732         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2733         * TestWebKitAPI/Tests/WebKit2/PendingAPIRequestURL.cpp: Added.
2734         (TestWebKitAPI::TEST):
2735         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
2736         (WebViewTest::loadPlainText): Remove FIXME.
2737         (WebViewTest::loadBytes): Ditto.
2738         (WebViewTest::loadAlternateHTML): Ditto.
2739
2740 2016-04-18  Jeremy Huddleston Sequoia  <jeremyhu@apple.com>
2741
2742         Fix incorrect assumption that APPLE implies Mac.
2743         https://bugs.webkit.org/show_bug.cgi?id=156679
2744
2745         Addresses build failure introduced in r198947
2746
2747         Reviewed by Alex Christensen.
2748
2749         * CMakeLists.txt:
2750
2751 2016-04-18  Carlos Garcia Campos  <cgarcia@igalia.com>
2752
2753         [GTK] Test /webkit2/WebKitWebView/mouse-target fails with overlay scrollbars
2754         https://bugs.webkit.org/show_bug.cgi?id=156621
2755
2756         Reviewed by Martin Robinson.
2757
2758         This is a problem of the test itself, we are using an overflow that is not actually scrollable, but that shows
2759         scrollbar troughs when not using overlay scrollbars because it's marked as scrollable. It would be easier to
2760         simply use the main frame scrollbars to test that and it will work no matter of scrollbars are overlay or not.
2761
2762         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
2763         (testWebViewMouseTarget): Remove the div and move the mouse over the main frame scrollbar to test scrolbars hit test.
2764
2765 2016-04-17  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2766
2767         [EFL] Bump gstreamer from 1.4.4 to 1.6.3
2768         https://bugs.webkit.org/show_bug.cgi?id=156655
2769
2770         Reviewed by Antonio Gomes.
2771
2772         To support html5 video feature, we should bump gstreamer version.
2773
2774         * efl/jhbuild.modules:
2775         * efl/patches/gst-libav.patch: Update against newer version.
2776         * efl/patches/gst-plugins-bad-remove-gnustep-support.patch: Removed because this patch was merged.
2777
2778 2016-04-16  Sam Weinig  <sam@webkit.org>
2779
2780         More build fixing.
2781
2782         * MiniBrowser/mac/BrowserWindowController.m:
2783         (-[BrowserWindowController share:]):
2784
2785 2016-04-16  Sam Weinig  <sam@webkit.org>
2786
2787         Another build fix.
2788
2789         * MiniBrowser/mac/BrowserWindowController.m:
2790         (-[BrowserWindowController sharingServicePicker:sharingServicesForItems:proposedSharingServices:]):
2791
2792 2016-04-16  Sam Weinig  <sam@webkit.org>
2793
2794         Fix 32-bit build.
2795
2796         * MiniBrowser/mac/BrowserWindowController.m:
2797         (-[BrowserWindowController share:]):
2798         (-[BrowserWindowController fetch:]):
2799         (-[BrowserWindowController sharingService:transitionImageForShareItem:contentRect:]):
2800
2801 2016-04-15  Sam Weinig  <sam@webkit.org>
2802
2803         Add support for NSSharingService to MiniBrowser, for no great reasons
2804         https://bugs.webkit.org/show_bug.cgi?id=156658
2805
2806         Reviewed by Darin Adler.
2807
2808         * MiniBrowser/mac/BrowserWindow.xib:
2809         * MiniBrowser/mac/BrowserWindowController.h:
2810         Add the share button.
2811
2812         * MiniBrowser/mac/BrowserWindowController.m:
2813         (-[BrowserWindowController windowDidLoad]):
2814         Set the share button to fire it's actions on mouse down, as it is supposed to act like a menu.
2815
2816         (-[BrowserWindowController share:]):
2817         Show the picker when the button is pressed.
2818         (-[BrowserWindowController mainContentView]):
2819         Add a new override to get the main content view of derived classes (either a WKWebView or the WebView).
2820
2821         (-[BrowserWindowController sharingServicePicker:sharingServicesForItems:proposedSharingServices:]):
2822         (-[BrowserWindowController sharingServicePicker:delegateForSharingService:]):
2823         (-[BrowserWindowController sharingServicePicker:didChooseSharingService:]):
2824         (-[BrowserWindowController sharingService:sourceFrameOnScreenForShareItem:]):
2825         (-[BrowserWindowController sharingService:transitionImageForShareItem:contentRect:]):
2826         (-[BrowserWindowController sharingService:sourceWindowForShareItems:sharingContentScope:]):
2827         Add delegate methods.
2828
2829         * MiniBrowser/mac/WK1BrowserWindowController.m:
2830         (-[WK1BrowserWindowController mainContentView]):
2831         * MiniBrowser/mac/WK2BrowserWindowController.m:
2832         (-[WK2BrowserWindowController mainContentView]):
2833         Implement to return the web view.
2834
2835 2016-04-16  Alexey Proskuryakov  <ap@apple.com>
2836
2837         Build fix.
2838
2839         Temporary workaround for rdar://problem/25754945.
2840
2841         * LayoutTestRelay/LayoutTestRelay/CoreSimulatorSPI.h:
2842
2843 2016-04-15  Commit Queue  <commit-queue@webkit.org>
2844
2845         Unreviewed, rolling out r199600.
2846         https://bugs.webkit.org/show_bug.cgi?id=156642
2847
2848         It didn't help (Requested by ap_ on #webkit).
2849
2850         Reverted changeset:
2851
2852         "Build fix."
2853         http://trac.webkit.org/changeset/199600
2854
2855 2016-04-15  Alexey Proskuryakov  <ap@apple.com>
2856
2857         Build fix.
2858
2859         * LayoutTestRelay/LayoutTestRelay/main.m: Allow some deprecated methods.
2860
2861 2016-04-14  Alexey Proskuryakov  <ap@apple.com>
2862
2863         Some GuardMalloc bots are not happy when running many parallel processes
2864         https://bugs.webkit.org/show_bug.cgi?id=156614
2865         rdar://problem/24711525
2866
2867         Reviewed by David Kilzer.
2868
2869         * Scripts/webkitpy/port/mac.py: (MacPort.default_child_processes):
2870
2871 2016-04-14  Brent Fulgham  <bfulgham@apple.com>
2872
2873         Make <a download> a runtime enabled option
2874         https://bugs.webkit.org/show_bug.cgi?id=156583
2875         <rdar://problem/25733449>
2876
2877         Reviewed by Alex Christensen.
2878
2879         * DumpRenderTree/mac/DumpRenderTree.mm:
2880         (resetWebPreferencesToConsistentValues):
2881         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2882         (WTR::InjectedBundle::beginTesting):
2883         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2884         (WTR::TestRunner::setDownloadAttributeEnabled):
2885         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2886
2887 2016-04-14  Anders Carlsson  <andersca@apple.com>
2888
2889         Another build fix attempt.
2890
2891         * MiniBrowser/mac/WK2BrowserWindowController.m:
2892
2893 2016-04-14  Anders Carlsson  <andersca@apple.com>
2894
2895         Fix build.
2896
2897         * MiniBrowser/mac/WK2BrowserWindowController.m:
2898         (-[WK2BrowserWindowController webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]):
2899
2900 2016-04-14  Anders Carlsson  <andersca@apple.com>
2901
2902         [Mac] Add API for open panel handling to WKWebView
2903         https://bugs.webkit.org/show_bug.cgi?id=137759
2904         rdar://problem/23278623
2905
2906         Reviewed by Tim Horton.
2907
2908         Have MiniBrowser implement the new delegate method.
2909
2910         * MiniBrowser/mac/WK2BrowserWindowController.m:
2911         (-[WK2BrowserWindowController webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]):
2912
2913 2016-04-14  Jiewen Tan  <jiewen_tan@apple.com>
2914
2915         Unreviewed, rolling out r199554.
2916
2917         The change breaks Yosemite Release/Debug build
2918
2919         Reverted changeset:
2920
2921         "[Mac] Add API for open panel handling to WKWebView"
2922         https://bugs.webkit.org/show_bug.cgi?id=137759
2923         http://trac.webkit.org/changeset/199554
2924
2925 2016-04-14  Anders Carlsson  <andersca@apple.com>
2926
2927         [Mac] Add API for open panel handling to WKWebView
2928         https://bugs.webkit.org/show_bug.cgi?id=137759
2929         rdar://problem/23278623
2930
2931         Reviewed by Tim Horton.
2932
2933         Have MiniBrowser implement the new delegate method.
2934
2935         * MiniBrowser/mac/WK2BrowserWindowController.m:
2936         (-[WK2BrowserWindowController webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]):
2937
2938 2016-04-14  Jon Lee  <jonlee@apple.com>
2939
2940         Update Animometer plan
2941         https://bugs.webkit.org/show_bug.cgi?id=156569
2942
2943         Reviewed by Alex Christensen.
2944
2945         * Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan: Update to r199328. Includes update to screen
2946         resolution, starting with complexity of 1, and fixing SVG, multiply, and text tests.
2947
2948 2016-04-13  Alex Christensen  <achristensen@webkit.org>
2949
2950         CMake MiniBrowser should be an app bundle
2951         https://bugs.webkit.org/show_bug.cgi?id=156521
2952
2953         Reviewed by Brent Fulgham.
2954
2955         * MiniBrowser/mac/CMakeLists.txt:
2956         Make an app bundle and compile nibs.
2957         * MiniBrowser/mac/Info.plist:
2958         CMake doesn't know what to do with :rfc1034identifier and there's no reason to keep it.  This is just MiniBrowser.
2959
2960 2016-04-13  Chris Dumez  <cdumez@apple.com>
2961
2962         We should not speculatively revalidate cached redirects
2963         https://bugs.webkit.org/show_bug.cgi?id=156548
2964         <rdar://problem/25583886>
2965
2966         Reviewed by Darin Adler.
2967
2968         Re-enable speculative loading in the context of layout tests. This was
2969         turned off by mistake when speculative loading was turned into a
2970         setting recently.
2971
2972         * WebKitTestRunner/TestController.cpp:
2973         (WTR::TestController::generatePageConfiguration):
2974
2975 2016-04-12  Alexey Proskuryakov  <ap@apple.com>
2976
2977         Python test webkitpy.common.system.executive_unittest.ExecutiveTest.serial_test_kill_process is flaky
2978         https://bugs.webkit.org/show_bug.cgi?id=155367
2979
2980         Reviewed by Darin Adler.
2981
2982         * Scripts/webkitpy/common/system/executive.py: (Executive.kill_process):
2983         Don't flakily consume the return code with waitpid, callers need to do waitpid on
2984         their own. Not sure if this line of code was even intentional.
2985
2986 2016-04-12  Myles C. Maxfield  <mmaxfield@apple.com>
2987
2988         [OS X] Flakey crash after ScrollAnimatorMac destruction
2989         https://bugs.webkit.org/show_bug.cgi?id=156372
2990
2991         Reviewed by Darin Adler.
2992
2993         Implement the new <!-- webkit-test-runner --> flag.
2994
2995         * WebKitTestRunner/TestController.cpp:
2996         (WTR::TestController::createWebViewWithOptions):
2997         (WTR::TestController::ensureViewSupportsOptionsForTest):
2998         (WTR::TestController::resetPreferencesToConsistentValues):
2999         (WTR::TestController::resetStateToConsistentValues):
3000         (WTR::updateTestOptionsFromTestHeader):
3001         * WebKitTestRunner/TestController.h:
3002         * WebKitTestRunner/TestInvocation.cpp:
3003         (WTR::TestInvocation::invoke):
3004         * WebKitTestRunner/TestOptions.h:
3005         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3006         (WKR::PlatformWebView::viewSupportsOptions):
3007
3008 2016-04-12  Tomas Popela  <tpopela@redhat.com>
3009
3010         Modify the CXXFLAGS in webkitdirs.pm just on architectures where the flags are supported
3011         https://bugs.webkit.org/show_bug.cgi?id=156338
3012
3013         Reviewed by Michael Catanzaro.
3014
3015         Add the "-march=pentium4 -msse2 -mfpmath=sse " into the CXXFLAGS just
3016         for the i686 where it is supported and not for other architectures
3017         (such as s390(x) and ppc(64)) where the build will fail with these
3018         CXXFLAGS.
3019
3020         * Scripts/webkitdirs.pm:
3021         (generateBuildSystemFromCMakeProject):
3022
3023 2016-04-11  Alex Christensen  <achristensen@webkit.org>
3024
3025         Build MiniBrowser with CMake on Mac
3026         https://bugs.webkit.org/show_bug.cgi?id=156471
3027
3028         Reviewed by Daniel Bates.
3029
3030         * CMakeLists.txt:
3031         * DumpRenderTree/CMakeLists.txt:
3032         * DumpRenderTree/PlatformWin.cmake:
3033         * MiniBrowser/mac/CMakeLists.txt: Added.
3034
3035 2016-04-11  Ryuan Choi  <ryuan.choi@navercorp.com>
3036
3037         [EFL] Do not pass context to EwkViewCreate
3038         https://bugs.webkit.org/show_bug.cgi?id=156461
3039
3040         Reviewed by Darin Adler.
3041
3042         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp:
3043         (TestWebKitAPI::TEST): Removed context argument from EwkViewCreate calls.
3044         * TestWebKitAPI/efl/PlatformWebView.cpp:
3045         (TestWebKitAPI::PlatformWebView::PlatformWebView): Ditto.
3046         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
3047         (WTR::PlatformWebView::PlatformWebView): Ditto.
3048
3049 2016-04-11  Fujii Hironori  <Hironori.Fujii@jp.sony.com>
3050
3051         [CMake] Make FOLDER property INHERITED
3052         https://bugs.webkit.org/show_bug.cgi?id=156460
3053
3054         Reviewed by Brent Fulgham.
3055
3056         * CMakeLists.txt:
3057         * DumpRenderTree/CMakeLists.txt:
3058         * DumpRenderTree/PlatformWin.cmake:
3059         * ImageDiff/CMakeLists.txt:
3060         * MiniBrowser/efl/CMakeLists.txt:
3061         * MiniBrowser/gtk/CMakeLists.txt:
3062         * MiniBrowser/win/CMakeLists.txt:
3063         Set FOLDER property as a directory property not a target property
3064
3065 2016-04-10  Caitlin Potter  <caitp@igalia.com>
3066
3067         [Tools] correctly check for braces in multiline branches in macro definition
3068         https://bugs.webkit.org/show_bug.cgi?id=156441
3069
3070         Reviewed by Darin Adler.
3071
3072         Prevents emitting whitespace/braces warning for code like the
3073         following:
3074
3075         ```
3076         #define MACRO(x) \
3077             if (x) { \
3078                 doTheThing(); \
3079                 continue; \
3080             }
3081         ```
3082
3083         * Scripts/webkitpy/style/checkers/cpp.py:
3084         (check_braces):
3085         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3086         (WebKitStyleTest.test_line_breaking):
3087
3088 2016-04-08  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3089
3090         Testharness-based tests that time out should be able to produce a detailed output
3091         https://bugs.webkit.org/show_bug.cgi?id=145313
3092
3093         Reviewed by Xabier Rodriguez-Calvar.
3094
3095         Adding timeout readonly accessor to TestRunner for both WK1 and WK2.
3096
3097         * DumpRenderTree/TestRunner.cpp:
3098         (getTimeoutCallback): The js "timeout" property getter.
3099         (TestRunner::staticValues): Adding "timeout" property to DumpRenderTree so that testRunner.timeout called from JS returns the timeout value.
3100         * DumpRenderTree/TestRunner.h:
3101         (TestRunner::timeout): Adding access to DRT m_timeout private value.
3102         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Adding timeout readonly attribute so that testRunner.timeout can be called from JS.
3103         * WebKitTestRunner/InjectedBundle/TestRunner.h: Adding DOM timeout getter to implement timeout IDL definition.
3104         (WTR::TestRunner::timeout):
3105
3106 2016-04-07  Joseph Pecoraro  <pecoraro@apple.com>
3107
3108         stylebot should know about TestWebKitAPI FeatureDefines.xcconfig
3109         https://bugs.webkit.org/show_bug.cgi?id=156387
3110
3111         Rubber-stamped by Dan Bernstein.
3112
3113         * Scripts/webkitpy/style/checkers/featuredefines.py:
3114         (FeatureDefinesChecker.check):
3115
3116 2016-04-07  Joseph Pecoraro  <pecoraro@apple.com>
3117
3118         Remove ENABLE(ENABLE_ES6_CLASS_SYNTAX) guards
3119         https://bugs.webkit.org/show_bug.cgi?id=156384
3120
3121         Reviewed by Ryosuke Niwa.
3122
3123         * Scripts/webkitperl/FeatureList.pm:
3124         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3125
3126 2016-04-06  Dean Jackson  <dino@apple.com>
3127
3128         Watchlist modifications:
3129         - remove roger_fong
3130         - add myself to a few areas
3131         - remove graouts from WebInspectorAPI
3132
3133         * Scripts/webkitpy/common/config/watchlist:
3134
3135 2016-04-07  Simon Fraser  <simon.fraser@apple.com>
3136
3137         Make it possible to test effect of view exposed rect on tiled backing
3138         https://bugs.webkit.org/show_bug.cgi?id=156365
3139
3140         Reviewed by Tim Horton.
3141
3142         Expose testRunner.setViewSize() and internals.setViewExposedRect() to enable
3143         testing of tile coverage when setViewExposedRect() is passed a non-null rectangle.
3144
3145         testRunner.setViewSize() is used instead of using window.resizeTo(), since we
3146         can't easily resize a window to larger than the screen being tested on.
3147
3148         * DumpRenderTree/TestRunner.cpp:
3149         (setViewSizeCallback):
3150         (TestRunner::staticFunctions):
3151         * DumpRenderTree/TestRunner.h:
3152         * DumpRenderTree/mac/TestRunnerMac.mm:
3153         (TestRunner::setViewSize):
3154         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3155         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3156         (WTR::InjectedBundle::postSetViewSize):
3157         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3158         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3159         (WTR::TestRunner::setViewSize):
3160         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3161         * WebKitTestRunner/TestInvocation.cpp:
3162         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3163
3164 2016-04-07  Jason Marcell  <jmarcell@apple.com>
3165
3166         Adding layout tests for the bot watcher's dashboard QUnit tests.
3167         https://bugs.webkit.org/show_bug.cgi?id=155272
3168
3169         Reviewed by Daniel Bates.
3170
3171         Moved supporting resources into a resources folder and updated index.html accordingly
3172         to point to the new locations. Added code to tests.js to dumpAsText when QUnit is done.
3173
3174         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/index-expected.txt: Added.
3175         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/index.html: Updated to point to tests.js and Mock files in resources directory.
3176         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbotQueue.js: Renamed from
3177         Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueue.js.
3178         (MockBuildbotQueue):
3179         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbotQueueView.js: Renamed from
3180         Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueueView.js.
3181         (MockBuildbotQueueView):
3182         (MockBuildbotQueueView.prototype._latestProductiveIteration):
3183         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockTrac.js: Renamed from
3184         Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js.
3185         (MockTrac):
3186         (MockTrac.prototype.get oldestRecordedRevisionNumber):
3187         (MockTrac.prototype.get latestRecordedRevisionNumber):
3188         (MockTrac.prototype.loadMoreHistoricalData):
3189         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/test-fixture-git-trac-rss.xml: Renamed from
3190         Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/test-fixture-git-trac-rss.xml.
3191         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/test-fixture-trac-rss.xml: Renamed from
3192         Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/test-fixture-trac-rss.xml.
3193         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js: Renamed from
3194         Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js.
3195         Updated the unit tests for Trac._loaded() to point to the XML files that are now located in the 'resources' directory.
3196         (QUnit.done): Added. Removes machine-specific output from test results and calls testRunner.notifyDone to let the layout test harness know that all testing is done.
3197         * Scripts/run-dashboard-tests: Added.
3198
3199 2016-04-06  ChangSeok Oh  <changseok@webkit.org>
3200
3201         Unreviewed, Update my primary email address and expertise.
3202
3203         * Scripts/webkitpy/common/config/contributors.json:
3204
3205 2016-04-06  Jon Lee  <jonlee@apple.com>
3206
3207         Update the Animometer patch and plan files
3208         https://bugs.webkit.org/show_bug.cgi?id=156263
3209
3210         Reviewed by Ryosuke Niwa.
3211
3212         Measure the latest set of tests by updating the plan revision to r199134.
3213
3214         * Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch: Update to run the master suite only.
3215         * Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan: Update to use the release page instead
3216         of the developer page.
3217
3218 2016-04-06  Saam barati  <sbarati@apple.com>
3219
3220         jsc-layout-tests.yaml/js/script-tests/regress-141098.js failing on Yosemite Debug after r198989
3221         https://bugs.webkit.org/show_bug.cgi?id=156187
3222
3223         Reviewed by Keith Miller.
3224
3225         * Scripts/run-jsc-stress-tests:
3226
3227 2016-04-06  Alex Christensen  <achristensen@webkit.org>
3228
3229         Compile WebKitTestRunner with CMake on Mac
3230         https://bugs.webkit.org/show_bug.cgi?id=156310
3231
3232         Reviewed by Daniel Bates.
3233
3234         * CMakeLists.txt:
3235         * WebKitTestRunner/CMakeLists.txt:
3236         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3237         * WebKitTestRunner/PlatformEfl.cmake:
3238         * WebKitTestRunner/PlatformGTK.cmake:
3239         * WebKitTestRunner/PlatformMac.cmake: Added.
3240
3241 2016-04-05  Simon Fraser  <simon.fraser@apple.com>
3242
3243         Implement operator== and operator!= for Optional<>
3244         https://bugs.webkit.org/show_bug.cgi?id=156266
3245
3246         Reviewed by Anders Carlsson.
3247
3248         * TestWebKitAPI/Tests/WTF/Optional.cpp:
3249         (TestWebKitAPI::TEST):
3250
3251 2016-04-05  Alex Christensen  <achristensen@webkit.org>
3252
3253         Make CMake-generated binaries on Mac able to run
3254         https://bugs.webkit.org/show_bug.cgi?id=156268
3255
3256         Reviewed by Daniel Bates.
3257
3258         * DumpRenderTree/CMakeLists.txt:
3259         * DumpRenderTree/PlatformMac.cmake:
3260         * DumpRenderTree/PlatformWin.cmake:
3261         * TestWebKitAPI/PlatformMac.cmake:
3262
3263 2016-04-05  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3264
3265         [Fetch API] Add a runtime flag to fetch API and related constructs
3266         https://bugs.webkit.org/show_bug.cgi?id=156113
3267  
3268         Reviewed by Alex Christensen.
3269
3270         * DumpRenderTree/TestRunner.h:
3271         * DumpRenderTree/mac/DumpRenderTree.mm:
3272         (resetWebPreferencesToConsistentValues):
3273         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3274         (WTR::InjectedBundle::beginTesting):
3275         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3276         (WTR::TestRunner::setWebGL2Enabled):
3277         (WTR::TestRunner::setFetchAPIEnabled):
3278         (WTR::TestRunner::setAllowUniversalAccessFromFileURLs):
3279         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3280
3281 2016-04-05  Keith Miller  <keith_miller@apple.com>
3282
3283         Make Keith a reviewer!
3284         https://bugs.webkit.org/show_bug.cgi?id=156246
3285
3286         Reviewed by Mark Lam.
3287
3288         * Scripts/webkitpy/common/config/contributors.json:
3289
3290 2016-04-05  Antoine Quint  <graouts@apple.com>
3291
3292         [WebGL2] Allow enabling WebGL2 with a runtime flag
3293         https://bugs.webkit.org/show_bug.cgi?id=156166
3294         <rdar://problem/25526929>
3295
3296         Always enable WebGL2 during testing.
3297
3298         Reviewed by Dean Jackson.
3299
3300         * DumpRenderTree/mac/DumpRenderTree.mm:
3301         (resetWebPreferencesToConsistentValues):
3302         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3303         (WTR::InjectedBundle::beginTesting):
3304         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3305         (WTR::TestRunner::setWebGL2Enabled):
3306         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3307
3308 2016-04-04  Bill Ming  <mbbill@gmail.com>
3309
3310         [win] run-webkit-tests failed to launch DumpRenderTree
3311         https://bugs.webkit.org/show_bug.cgi?id=156150
3312
3313         Reviewed by Alex Christensen.
3314
3315         * Tools/Scripts/webkitpy/port/base.py:
3316
3317 2016-04-04  Bill Ming  <mbbill@gmail.com>
3318
3319         prepare-ChangeLog set endl incorrectly.
3320         https://bugs.webkit.org/show_bug.cgi?id=156151
3321
3322         Reviewed by Alex Christensen.
3323
3324         * Tools/Scripts/prepare-ChangeLog:
3325
3326 2016-04-03  Sam Weinig  <sam@webkit.org>
3327
3328         Add SPI to allow install script message handlers in isolated worlds
3329         https://bugs.webkit.org/show_bug.cgi?id=156153
3330
3331         Reviewed by Anders Carlsson.
3332
3333         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
3334         Add new test, WKUserContentController.ScriptMessageHandlerBasicPostIsolatedWorld
3335
3336 2016-04-04  Jiewen Tan  <jiewen_tan@apple.com>
3337
3338         Build fix for r198956.
3339
3340         Unreviewed.
3341
3342         * TestWebKitAPI/Tests/WebKit2Cocoa/LoadInvalidURLRequest.mm:
3343         (-[LoadInvalidURLNavigationActionDelegate webView:didFailProvisionalNavigation:withError:]):
3344         * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.mm:
3345         (-[LoadInvalidURLWebFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
3346
3347 2016-04-04  Bill Ming  <mbbill@gmail.com>
3348
3349         [win] prepare-ChangeLog should treat windows path differently.
3350         https://bugs.webkit.org/show_bug.cgi?id=156120
3351
3352         Reviewed by Brent Fulgham.
3353
3354         * Scripts/prepare-ChangeLog:
3355
3356 2016-04-04  Alejandro G. Castro  <alex@igalia.com>
3357
3358         REGRESSION(r198492): [GTK] The WEB_RTC flag was not correctly added in some situations
3359         https://bugs.webkit.org/show_bug.cgi?id=156164
3360
3361         Reviewed by Philippe Normand.
3362
3363         Enable the new WEB_RTC option by default for Gtk+.
3364
3365         * Scripts/webkitperl/FeatureList.pm:
3366
3367 2016-04-03  Dan Bernstein  <mitz@apple.com>
3368
3369         Use the correct value for the first nightly build with frameworks built for OS X 10.11.
3370
3371         * Scripts/bisect-builds:
3372         (makeNightlyList):
3373
3374 2016-04-03  Dan Bernstein  <mitz@apple.com>
3375
3376         Made bisect-builds work again.
3377
3378         Rubber-stamped by Sam Weinig.
3379
3380         * Scripts/bisect-builds:
3381         Changed to use HTTPS to access nightly.webkit.org, and added a minimum revision for OS X 10.11.
3382
3383 2016-04-01  Jiewen Tan  <jiewen_tan@apple.com>
3384
3385         Build fix for r198956.
3386
3387         Unreviewed.
3388
3389         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3390         * TestWebKitAPI/Tests/WebKit2Cocoa/ProvisionalURLNotChange.mm: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Cocoa/ProvisionalURLChange.mm.
3391         (-[ProvisionalURLNotChangeController webView:didFinishNavigation:]):
3392         (-[ProvisionalURLNotChangeController webView:didFailProvisionalNavigation:withError:]):
3393         (TEST):
3394         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
3395         (-[LoadInvalidSchemeDelegate browsingContextController:didFailProvisionalLoadWithError:]):
3396         (TestWebKitAPI::TEST):
3397
3398 2016-04-01  Jiewen Tan  <jiewen_tan@apple.com>
3399
3400         WebKit should dispatchDidFailProvisionalLoad while loading invalid URLs
3401         https://bugs.webkit.org/show_bug.cgi?id=155995
3402         <rdar://problem/14967004>
3403
3404         Reviewed by Andy Estes.
3405
3406         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3407         * TestWebKitAPI/Tests/WebKit2Cocoa/LoadAlternateHTMLString.mm:
3408         (-[LoadAlternateHTMLStringFromProvisionalLoadErrorController webView:didFailProvisionalNavigation:withError:]):
3409         (-[LoadAlternateHTMLStringFromProvisionalLoadErrorController webView:didStartProvisionalNavigation:]):
3410         (TEST):
3411         * TestWebKitAPI/Tests/WebKit2Cocoa/LoadInvalidURLRequest.mm: Added.
3412         (literalURL):
3413         (-[LoadInvalidURLNavigationActionDelegate webView:didCommitNavigation:]):
3414         (-[LoadInvalidURLNavigationActionDelegate webView:didFailProvisionalNavigation:withError:]):
3415         (TestWebKitAPI::TEST):
3416         * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.html: Added.
3417         * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.mm: Added.
3418         (-[LoadInvalidURLWebFrameLoadDelegate webView:didCommitLoadForFrame:]):
3419         (-[LoadInvalidURLWebFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
3420         (TestWebKitAPI::TEST):
3421
3422 2016-04-01  Brent Fulgham  <bfulgham@apple.com>
3423
3424         Confirm <a download> satisfies specification criteria
3425         https://bugs.webkit.org/show_bug.cgi?id=156057
3426
3427         Reviewed by Andy Estes.
3428
3429         Revise WebKitTestRunner:
3430         (1) Provide a download client delegate.
3431         (2) Teach WKTR to wait to finish a test until a download finishes.
3432         (3) Allow WKTR to notify the current TestRunner that it can finish.
3433
3434         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3435         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3436         (WTR::InjectedBundle::didReceiveMessageToPage): Update to recognize a new
3437         message "NotifyDownloadDone".
3438         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3439         (WTR::InjectedBundlePage::decidePolicyForNavigationAction): Handle 'download'
3440         attribute case.
3441         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3442         (WTR::TestRunner::waitUntilDownload): Added.
3443         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3444         (WTR::TestRunner::shouldFinishAfterDownload): Added.
3445         * WebKitTestRunner/TestController.cpp:
3446         (WTR::TestController::createWebViewWithOptions): Set up the download client.
3447         (WTR::TestController::downloadDidStart): Added.
3448         (WTR::TestController::decideDestinationWithSuggestedFilename): Added.
3449         (WTR::TestController::downloadDidFinish): Added.
3450         (WTR::TestController::downloadDidFail): Added.
3451         (WTR::TestController::downloadDidCancel): Added.
3452         * WebKitTestRunner/TestController.h:
3453         * WebKitTestRunner/TestInvocation.cpp:
3454         (WTR::TestInvocation::notifyDownloadDone): Added.
3455         * WebKitTestRunner/TestInvocation.h:
3456
3457 2016-04-01  Alex Christensen  <achristensen@webkit.org>
3458
3459         Compile DumpRenderTree with CMake on Mac
3460         https://bugs.webkit.org/show_bug.cgi?id=156088
3461
3462         Reviewed by Brent Fulgham.
3463
3464         * CMakeLists.txt:
3465         * DumpRenderTree/CMakeLists.txt:
3466         * DumpRenderTree/DefaultPolicyDelegate.m:
3467         (-[DefaultPolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
3468         * DumpRenderTree/DumpRenderTreeFileDraggingSource.m:
3469         * DumpRenderTree/PlatformMac.cmake: Added.
3470         * DumpRenderTree/PlatformWin.cmake:
3471         * DumpRenderTree/mac/AppleScriptController.m:
3472         (convertAEDescToObject):
3473         * DumpRenderTree/mac/DumpRenderTreeMain.mm:
3474         * DumpRenderTree/mac/LayoutTestHelper.m:
3475
3476 2016-03-31  Bill Ming  <mbbill@gmail.com>
3477
3478         https://bugs.webkit.org/show_bug.cgi?id=156094
3479         [Win] TestWebCore target build sometimes fail.
3480
3481         Reviewed by Alex Christensen.
3482
3483         * Tools/TestWebKitAPI/PlatformWin.cmake:
3484
3485 2016-03-31  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3486
3487         [EFL] Bump EFL version to 1.17.0
3488         https://bugs.webkit.org/show_bug.cgi?id=153008
3489
3490         Reviewed by Michael Catanzaro.
3491
3492         Original author is Csaba Osztrogonác  <ossy@webkit.org>
3493
3494         * efl/jhbuild.modules:
3495
3496 2016-03-31  Daniel Bates  <dabates@apple.com>
3497
3498         run-webkit-tests fails to create user's cache directory when System Integrity Protection is enabled
3499         https://bugs.webkit.org/show_bug.cgi?id=156071
3500         <rdar://problem/25467827>
3501
3502         Reviewed by Brent Fulgham.
3503
3504         Fixes an issue where run-webkit-tests will fail to create the suffixed user's cache directory
3505         on non-Apple Internal machines with System Integrity Protection enabled because the OS only
3506         honors the suffix, specified by the environment variable DIRHELPER_USER_DIR_SUFFIX, in
3507         privileged processes. And python(1) does not have sufficient privileges. As a workaround for
3508         systems that have System Integrity Protection enabled we compute the path to the suffixed
3509         user's cache directory by hand.
3510
3511         Additionally, fix an issue where the user's cache directory created by run-webkit-test was
3512         never deleted on cessation of the test run.
3513
3514         * Scripts/webkitpy/port/driver.py:
3515         (Driver._start): Actually store the path to the user's cache directory in self._driver_user_cache_directory
3516         so that we can delete this directory on cessation of the test run.
3517         * Scripts/webkitpy/port/mac.py:
3518         (MacPort):
3519         (MacPort._path_to_user_cache_directory): Unset the environment variable DIRHELPER_USER_DIR_SUFFIX (if set),
3520         query the OS for the path to the user's cache directory and concatenate this path with the
3521         specified suffix.
3522
3523 2016-03-31  Jiewen Tan  <jiewen_tan@apple.com>
3524
3525         WebKit should set Original URL of a download request correctly
3526         https://bugs.webkit.org/show_bug.cgi?id=155914
3527         <rdar://problem/10473811>
3528
3529         Reviewed by Anders Carlsson.
3530
3531         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3532         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
3533         (-[DownloadRequestOriginalURLDelegate initWithExpectOriginalURL:]):
3534         (-[DownloadRequestOriginalURLDelegate _downloadDidStart:]):
3535         (-[DownloadRequestOriginalURLNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3536         (TEST):
3537         * TestWebKitAPI/Tests/WebKit2Cocoa/DownloadRequestOriginalURL.html: Added.
3538         * TestWebKitAPI/Tests/WebKit2Cocoa/DownloadRequestOriginalURL2.html: Added.
3539         * TestWebKitAPI/Tests/WebKit2Cocoa/DownloadRequestOriginalURLFrame.html: Added.
3540
3541 2016-03-30  Dewei Zhu  <dewei_zhu@apple.com>
3542
3543         Extend animometer timeout for slow CPUs.
3544         https://bugs.webkit.org/show_bug.cgi?id=156047
3545
3546         Reviewed by Ryosuke Niwa.
3547
3548         Extend animometer timeout to 30 minutes for slow device.
3549
3550         * Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan:
3551
3552 2016-03-30  Daniel Bates  <dabates@apple.com>
3553
3554         run-webkit-tests must create parent directory of user's cache directory before running tests
3555         https://bugs.webkit.org/show_bug.cgi?id=156009
3556         <rdar://problem/25442682>
3557
3558         Reviewed by Alexey Proskuryakov.
3559
3560         The script run-webkit-tests must create the parent directory of the user's cache directory
3561         before running tests because a WebKit2 child process expects that this directory exists
3562         when it starts.
3563
3564         The script run-webkit-tests influences the path chosen by a WebKit2 child process for the
3565         user's temporary directory and user's cache directory via the environment variable
3566         DIRHELPER_USER_DIR_SUFFIX. For the user's temporary directory, run-webkit-tests creates it
3567         as part of setting up the test environment. But run-webkit-tests does not create the user's
3568         cache directory. Therefore there is race between the time AppKit creates it and when the
3569         launched WebContent and Network processes query for the path to the user's cache directory
3570         such that the OS may return the empty string to the WebContent and Network processes if
3571         queried for this directory before AppKit creates it.
3572
3573         * Scripts/webkitpy/port/base.py:
3574         (Port._path_to_user_cache_directory): Added. Base class implementation that returns the
3575         empty string. We will override this method for the OS X port to return the path to the
3576         user's cache directory with the specified suffix.
3577         (Port.remove_cache_directory): Deleted.
3578         * Scripts/webkitpy/port/driver.py:
3579         (Driver.__init__): Initialize self._driver_user_directory_suffix and self._driver_user_cache_directory
3580         to the suffix to use for the user's temporary and cache directories and the path to the
3581         user's cache directory, respectively.
3582         (Driver._setup_environ_for_driver): Modified to set the environment variable DIRHELPER_USER_DIR_SUFFIX
3583         to self._driver_user_directory_suffix.
3584         (Driver._start): Compute the user directory suffix and the path to the user's cache
3585         directory. Create the user's cache directory (if applicable).
3586         (Driver.stop): Modified to remove directory self._driver_user_cache_directory (if applicable).
3587         * Scripts/webkitpy/port/mac.py:
3588         (MacPort.user_cache_directory): Added. Overrides Port._path_to_user_cache_directory().
3589         (MacPort.remove_cache_directory): Deleted.
3590
3591 2016-03-29  Benjamin Poulain  <bpoulain@apple.com>
3592
3593         [WTF] Removing a smart pointer from HashTable issues two stores to the same location
3594         https://bugs.webkit.org/show_bug.cgi?id=155676
3595
3596         Reviewed by Darin Adler.
3597
3598         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
3599         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
3600
3601 2016-03-29  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
3602
3603         Add machine-readable results for JSC stress tests
3604         https://bugs.webkit.org/show_bug.cgi?id=155771
3605
3606         Reviewed by Darin Adler and Dean Johnson
3607
3608         Add an option to output JSC stress test results to a user-specified file in JSON format.
3609
3610         * Scripts/run-javascriptcore-tests:
3611         (runJSCStressTests): Add JSON output support
3612         (readAllLines): Remove trailing newline from the end of each item
3613
3614 2016-03-29  Alex Christensen  <achristensen@webkit.org>
3615
3616         Fix Windows build.
3617
3618         * TestWebKitAPI/PlatformWin.cmake:
3619
3620 2016-03-29  Timothy Hatcher  <timothy@apple.com>
3621
3622         Update WebKit nightly to have a red needle to better match Safari
3623
3624         https://bugs.webkit.org/show_bug.cgi?id=155983
3625
3626         Reviewed by Joseph Pecoraro.
3627
3628         * WebKitLauncher/webkit.icns:
3629
3630 2016-03-28  Joanmarie Diggs  <jdiggs@igalia.com>
3631
3632         Adding myself as a reviewer.
3633
3634         Unreviewed.
3635
3636         * Scripts/webkitpy/common/config/contributors.json:
3637
3638 2016-03-25  Dewei Zhu  <dewei_zhu@apple.com>
3639
3640         Dromaeo patch used by run-benchmark should not include an invalid address.
3641         https://bugs.webkit.org/show_bug.cgi?id=155910
3642
3643         Reviewed by Ryosuke Niwa.
3644
3645         Should not use invalid 'http://127.0.0.1/Icons/w3c_home' in the patched version of test.
3646         * Scripts/webkitpy/benchmark_runner/data/patches/Dromaeo.patch:
3647
3648 2016-03-25  Daniel Bates  <dabates@apple.com>
3649
3650         Add WebKitSystemInterface for iOS 9.3
3651         https://bugs.webkit.org/show_bug.cgi?id=155893
3652
3653         Rubber-stamped by Alexey Proskuryakov.
3654
3655         * Scripts/copy-webkitlibraries-to-product-directory:
3656
3657 2016-03-25  Daniel Bates  <dabates@apple.com>
3658
3659         Use webkitdirs::determineXcodeSDK() instead of webkitdirs::willUseIOSDeviceSDK()
3660         in copy-webkitlibraries-to-product-directory
3661         https://bugs.webkit.org/show_bug.cgi?id=155869
3662
3663         Reviewed by Alexey Proskuryakov.
3664
3665         It is sufficient and more direct to call webkitdirs::determineXcodeSDK() instead of
3666         webkitdirs::willUseIOSDeviceSDK() to process the --sdk/--device/--ios-simulator command
3667         line argument.
3668
3669         * Scripts/copy-webkitlibraries-to-product-directory:
3670
3671 2016-03-25  Konstantin Tokarev  <annulen@yandex.ru>
3672
3673         Turned on ENABLE_REQUEST_ANIMATION_FRAME by default for any port.
3674         https://bugs.webkit.org/show_bug.cgi?id=155882
3675
3676         Reviewed by Michael Catanzaro.
3677
3678         It was already enabled in all trunk ports, and is required for
3679         WebInspectorUI to work.
3680
3681         * Scripts/webkitperl/FeatureList.pm:
3682
3683 2016-03-24  Jeremy Zerfas  <WebKit@JeremyZerfas.com>
3684
3685         Improve update-webkit-dependency script.
3686         https://bugs.webkit.org/show_bug.cgi?id=155576
3687
3688         Reviewed by Brent Fulgham.
3689
3690         * Scripts/update-webkit-dependency:
3691         -Updated script to also use ETags for helping to determine whether dependency is up to date.
3692         -Updated script so it usually won't need to download the entire dependency each time it is
3693          ran.
3694         -Updated script to ensure zip file contains expected directories before trying to install.
3695         -Added some more error checking and improved error messages.
3696         (lastModifiedToUnixTime): Deleted.
3697
3698         * Scripts/update-webkit-wincairo-libs:
3699         -Corrected comment about what script does.
3700
3701 2016-03-24 Bill Ming <mbbill@gmail.com>
3702
3703         Fix webkitpy tests after r198617
3704         https://bugs.webkit.org/show_bug.cgi?id=155827
3705
3706         Reviewed by Alex Christensen.
3707
3708         * Scripts/webkitpy/tool/steps/confirmdiff.py:
3709         (ConfirmDiff._show_pretty_diff):
3710
3711 2016-03-23  Bill Ming  <mbbill@gmail.com>
3712
3713         webkit-patch failed to open pretty diff on Windows
3714         https://bugs.webkit.org/show_bug.cgi?id=155827
3715
3716         Reviewed by Alex Christensen.
3717
3718         * Scripts/webkitpy/tool/steps/confirmdiff.py:
3719         (ConfirmDiff._show_pretty_diff):
3720
3721 2016-03-23  Jer Noble  <jer.noble@apple.com>
3722
3723         [ios-sim] RequiresUserActionForPlaybackTest.DoesNotRequireUserActionForMediaPlayback and RequiresUserActionForVideoButNotAudioPlayback failing
3724         https://bugs.webkit.org/show_bug.cgi?id=155764
3725
3726         Reviewed by Eric Carlson.
3727
3728         Remove the requirement for media elements to have webkit-playsinline attributes on iOS.
3729
3730         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
3731         (RequiresUserActionForPlaybackTest::SetUp):
3732
3733 2016-03-23  Anders Carlsson  <andersca@apple.com>
3734
3735         Crash when using KVO from within -[WebView initWithCoder:]
3736         https://bugs.webkit.org/show_bug.cgi?id=155816
3737         rdar://problem/17073265
3738
3739         Reviewed by Dan Bernstein.
3740
3741         Add test.
3742
3743         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3744         * TestWebKitAPI/Tests/mac/EarlyKVOCrash.mm: Added.
3745         (-[EarlyKVOCrashResponder initWithWebView:]):
3746         (-[EarlyKVOCrashResponder initWithCoder:]):
3747         (-[EarlyKVOCrashResponder dealloc]):
3748         (-[EarlyKVOCrashResponder encodeWithCoder:]):
3749         (TestWebKitAPI::TEST):
3750
3751 2016-03-23  Lucas Forschler  <lforschler@apple.com>
3752
3753         Teach kill-old-processes about perl 5.18.
3754         
3755         Reviewed by Alexey Proskuryakov
3756
3757         * BuildSlaveSupport/kill-old-processes:
3758         (main):
3759
3760 2016-03-22  Keith Rollin  <krollin@apple.com>
3761
3762         Unreviewed: add Keith Rollin to the committers list.
3763
3764         * Scripts/webkitpy/common/config/contributors.json:
3765
3766 2016-03-22  Per Arne Vollan  <peavo@outlook.com>
3767
3768         [Win] [64-bit] Remove MSVC 2013 FMA3 Bug Workaround
3769         https://bugs.webkit.org/show_bug.cgi?id=141499
3770
3771         Reviewed by Brent Fulgham.
3772
3773         As we have moved on to VS2015, this workaround is no longer needed.
3774
3775         * DumpRenderTree/cg/ImageDiffCG.cpp:
3776         (main):
3777         * DumpRenderTree/win/DumpRenderTree.cpp:
3778         (main):
3779         * DumpRenderTree/win/ImageDiffCairo.cpp:
3780         (main):
3781         * MiniBrowser/win/Common.cpp:
3782         (DllMain):
3783         * TestWebKitAPI/win/main.cpp:
3784         (main):
3785         * win/DLLLauncher/DLLLauncherMain.cpp:
3786         (wWinMain):
3787
3788 2016-03-22  Yusuke Suzuki  <utatane.tea@gmail.com>
3789
3790         [JSC] ASMBench cannot be run without JSBENCH_PATH
3791         https://bugs.webkit.org/show_bug.cgi?id=155751
3792
3793         Reviewed by Saam Barati.
3794
3795         Check ASMBENCH_PATH instead of JSBENCH_PATH for ASMBench files.
3796
3797         * Scripts/run-jsc-benchmarks:
3798
3799 2016-03-21  Brent Fulgham  <bfulgham@apple.com>
3800
3801         [Win] SharedBuffer::copy() can cause a segmentation fault.
3802         https://bugs.webkit.org/show_bug.cgi?id=155739
3803
3804         Reviewed by Ryosuke Niwa.
3805
3806         * TestWebKitAPI/PlatformWin.cmake: Build and run the
3807         SharedBuffer tests.
3808
3809 2016-03-22  Csaba Osztrogonác  <ossy@webkit.org>
3810
3811         [buildbot] Move ARM Linux bots to JSCOnly port
3812         https://bugs.webkit.org/show_bug.cgi?id=155655
3813
3814         Reviewed by Lucas Forschler.
3815
3816         * BuildSlaveSupport/build.webkit.org-config/config.json:
3817         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3818         (ConfigureBuild.__init__):
3819         (appendCustomBuildFlags):
3820         (CompileJSCOnly):
3821         (Factory.__init__):
3822         (BuildAndRemoteJSCTestsFactory):
3823         (BuildAndRemoteJSCTestsFactory.__init__):
3824         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3825         * BuildSlaveSupport/clean-build:
3826         (main):
3827
3828 2016-03-21  Brent Fulgham  <bfulgham@apple.com>
3829
3830         Improve SharedBuffer testing
3831         https://bugs.webkit.org/show_bug.cgi?id=93078
3832         <rdar://problem/25277829>
3833
3834         Reviewed by Ryosuke Niwa.
3835
3836         Based on a Blink patch by Huang Dongsung <luxtella@company100.net>.
3837         <https://src.chromium.org/viewvc/blink?revision=153850&view=revision,
3838         and a Blink patch by <tyoshino@chromium.org>
3839         <https://src.chromium.org/viewvc/blink?view=rev&revision=151617>
3840
3841         Add three test cases from the Blink project that cover various append,
3842         copy, and createArrayBuffer calls.
3843
3844         * TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp:
3845         (TestWebKitAPI::TEST_F):
3846
3847 2016-03-21  Hyungwook Lee  <hyungwook.lee@navercorp.com>
3848
3849         [Win] Connect layoutTestController.findString() to support testing
3850         https://bugs.webkit.org/show_bug.cgi?id=50234
3851
3852         Reviewed by Alex Christensen.
3853
3854         Implement TestRunner::findString().
3855
3856         * DumpRenderTree/win/TestRunnerWin.cpp:
3857         (TestRunner::findString):
3858
3859 2016-03-20  Dan Bernstein  <mitz@apple.com>
3860
3861         [Mac] Determine TARGET_MAC_OS_X_VERSION_MAJOR from MACOSX_DEPLOYMENT_TARGET rather than from MAC_OS_X_VERSION_MAJOR
3862         https://bugs.webkit.org/show_bug.cgi?id=155707
3863         <rdar://problem/24980691>
3864
3865         Reviewed by Darin Adler.
3866
3867         * ContentExtensionTester/Configurations/Base.xcconfig: Set TARGET_MAC_OS_X_VERSION_MAJOR
3868           based on the last component of MACOSX_DEPLOYMENT_TARGET.
3869         * ContentExtensionTester/Configurations/DebugRelease.xcconfig: For engineering builds,
3870           preserve the behavior of TARGET_MAC_OS_X_VERSION_MAJOR being the host’s OS version.
3871
3872         Similarly for these projects:
3873
3874         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3875         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3876         * LayoutTestRelay/Configurations/Base.xcconfig:
3877         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
3878         * MiniBrowser/Configurations/Base.xcconfig:
3879         * MiniBrowser/Configurations/DebugRelease.xcconfig:
3880         * TestWebKitAPI/Configurations/Base.xcconfig:
3881         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
3882         * WebEditingTester/Configurations/Base.xcconfig:
3883         * WebEditingTester/Configurations/DebugRelease.xcconfig:
3884         * WebKitTestRunner/Configurations/Base.xcconfig:
3885         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3886
3887 2016-03-20  Dan Bernstein  <mitz@apple.com>
3888
3889         Update build settings
3890
3891         Rubber-stamped by Andy Estes.
3892
3893         * ContentExtensionTester/Configurations/DebugRelease.xcconfig:
3894         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3895         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
3896         * MiniBrowser/Configurations/DebugRelease.xcconfig:
3897         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
3898         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Synced up to the ones in ../Source.
3899         * WebEditingTester/Configurations/DebugRelease.xcconfig:
3900         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3901         * asan/asan.xcconfig:
3902
3903 2016-03-18  Sam Weinig  <sam@webkit.org>
3904
3905         Add test for HashMap::ensure that shows that moving into the lambda does not incure extra cost
3906         https://bugs.webkit.org/show_bug.cgi?id=155621
3907
3908         Reviewed by Alex Christensen.
3909
3910         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
3911         (TestWebKitAPI::ObjectWithRefLogger::ObjectWithRefLogger):
3912         (TestWebKitAPI::testMovingUsingEnsure):
3913         (TestWebKitAPI::testMovingUsingAdd):
3914         Add tests ensuring that objects moved into a map using ensure don't
3915         have extra ref-churn.
3916
3917 2016-03-17  Tim Horton  <timothy_horton@apple.com>
3918
3919         Fix some deprecation warnings in WebEditingTester
3920         https://bugs.webkit.org/show_bug.cgi?id=155601
3921
3922         Reviewed by Simon Fraser.
3923
3924         * WebEditingTester/AppDelegate.m:
3925         (-[WebEditingAppDelegate showOperations:]):
3926         (-[WebEditingAppDelegate _updateNewWindowKeyEquivalents]):
3927
3928 2016-03-17  Tim Horton  <timothy_horton@apple.com>
3929
3930         Find-in-page indicator in Mail viewer is the wrong scale and cut off
3931         https://bugs.webkit.org/show_bug.cgi?id=155605
3932         <rdar://problem/23948165>
3933
3934         Reviewed by Simon Fraser.
3935
3936         * TestWebKitAPI/Tests/WebKit2Cocoa/FindInPage.mm:
3937         (TEST):
3938         Add a test that ensures that the find result image is correctly @2x.
3939         The NSImage size should be in points.
3940
3941 2016-03-16  Commit Queue  <commit-queue@webkit.org>
3942
3943         Unreviewed, rolling out r198187.
3944         https://bugs.webkit.org/show_bug.cgi?id=155564
3945
3946         Potentially break testing on iOS (Requested by Guest23 on
3947         #webkit).
3948
3949         Reverted changeset:
3950
3951         "Add twisted-15.5.0 module to
3952         webkitpy.thirdparty.autoinstalled."
3953         https://bugs.webkit.org/show_bug.cgi?id=154667
3954         http://trac.webkit.org/changeset/198187
3955
3956 2016-03-16  David Kilzer  <ddkilzer@apple.com>
3957
3958         check-webkit-style: should warn about blank lines after #include "config.h" in TestWebKitAPI
3959         <http://webkit.org/b/155445>
3960
3961         Reviewed by Darin Adler.
3962
3963         * Scripts/webkitpy/style/checker.py:
3964         (_PATH_RULES_SPECIFIER): Do not ignore "build/include*" checks
3965         on TestWebKitAPI since this project uses a config.h header as of
3966         r95188.  Also remove references to WebKitAPITest, which ceased
3967         to exist in r95944.
3968
3969         * Scripts/webkitpy/style/checker_unittest.py:
3970         (GlobalVariablesTest.test_path_rules_specifier): Add tests.
3971         Remove reference to WebKitAPITest project.
3972
3973 2016-03-16  Tim Horton  <timothy_horton@apple.com>
3974
3975         [mac] Printing test snapshots are upside-down after r198242
3976         https://bugs.webkit.org/show_bug.cgi?id=155543
3977
3978         Reviewed by Simon Fraser.
3979
3980         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
3981         (createPagedBitmapContext):
3982         Flip printing snapshots in DRT so that everything is right-side-up.
3983
3984 2016-03-16  Alexey Proskuryakov  <ap@apple.com>
3985
3986         Update unit test for iOS debug queues.
3987
3988         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3989
3990 2016-03-16  Jiewen Tan  <jiewen_tan@apple.com>
3991
3992         URL Parsing should signal failure for illegal IDN
3993         https://bugs.webkit.org/show_bug.cgi?id=154945
3994         <rdar://problem/8014795>
3995
3996         Reviewed by Brent Fulgham.
3997
3998         * MiniBrowser/mac/WK2BrowserWindowController.m:
3999         (-[WK2BrowserWindowController fetch:]):
4000         * TestWebKitAPI/Tests/Cocoa/URLExtras.mm:
4001         (TestWebKitAPI::TEST):
4002
4003 2016-03-15  Tim Horton  <timothy_horton@apple.com>
4004
4005         [iOS Simulator] Test result snapshots are upside down
4006         https://bugs.webkit.org/show_bug.cgi?id=154761
4007
4008         Reviewed by Simon Fraser.
4009
4010         * WebKitTestRunner/cg/TestInvocationCG.cpp:
4011         (WTR::createCGContextFromImage):
4012         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
4013         In r97104, Simon added code to take WindowServer snapshots, which came
4014         in flipped, and added code to flip them back. At this point, WindowServer
4015         snapshots got flipped, and software snapshots did not.
4016
4017         In r140067, Simon noticed that WindowServer ref test images were upside-down
4018         on Mac (not sure why this changed), so turned off the flipping code (but
4019         didn't delete it!). Now, WindowServer snapshots and software snapshots both
4020         are not flipped.
4021
4022         In r190304, Carlos added an enum for the source of the snapshot ("WebView"
4023         for window server snapshots, and "WebContent" for software snapshots),
4024         and - critically - changed the flipping logic to flip software snapshots!
4025
4026         We didn't notice this on Mac because at this point we've made it so that
4027         we *always* have WindowServer snapshots, but on iOS we still don't have
4028         WindowServer snapshots, so now they're flipped.
4029
4030         And that's how we got here.
4031
4032         To restore the behavior from r140067, and correctly unflip snapshots on
4033         iOS, just delete this code.
4034
4035 2016-03-15  Alexey Proskuryakov  <ap@apple.com>
4036
4037         run-api-tests doesn't print test name when the test crashes
4038         https://bugs.webkit.org/show_bug.cgi?id=155476
4039
4040         Reviewed by Daniel Bates.
4041
4042         * Scripts/run-api-tests: Print "UNEXPECTEDLY EXITED" with a test name when output
4043         doesn't contain the test name yet. Changed test name output to always be before raw
4044         stdout for clarity.
4045
4046 2016-03-15  Chris Dumez  <cdumez@apple.com>
4047
4048         Unreviewed, rolling out r198203.
4049
4050         Favorites view is no longer loading on iOS
4051
4052         Reverted changeset:
4053
4054         "URL Parsing should signal failure for illegal IDN"
4055         https://bugs.webkit.org/show_bug.cgi?id=154945
4056         http://trac.webkit.org/changeset/198203
4057
4058 2016-03-15  Jiewen Tan  <jiewen_tan@apple.com>
4059
4060         URL Parsing should signal failure for illegal IDN
4061         https://bugs.webkit.org/show_bug.cgi?id=154945
4062         <rdar://problem/8014795>
4063
4064         Reviewed by Brent Fulgham.
4065
4066         * MiniBrowser/mac/WK2BrowserWindowController.m:
4067         (-[WK2BrowserWindowController fetch:]):
4068         * TestWebKitAPI/Tests/Cocoa/URLExtras.mm:
4069         (TestWebKitAPI::TEST):
4070
4071 2016-03-14  Chris Dumez  <cdumez@apple.com>
4072
4073         Unreviewed, rolling out r197981.
4074
4075         Caused a massive PLT regression on Mac.
4076
4077         Reverted changeset:
4078
4079         "Font antialiasing (smoothing) changes when elements are
4080         rendered into compositing layers"
4081         https://bugs.webkit.org/show_bug.cgi?id=23364
4082         http://trac.webkit.org/changeset/197981
4083
4084 2016-03-14  Dewei Zhu  <dewei_zhu@apple.com>
4085
4086         Add twisted-15.5.0 module to webkitpy.thirdparty.autoinstalled.
4087         https://bugs.webkit.org/show_bug.cgi?id=154667
4088
4089         Reviewed by Ryosuke Niwa and Simon Fraser.
4090
4091         Add twisted-15.5.0 to webkitpy.thirdparty.autoinstalled.
4092         Minor fix for twsited_http_server used by run-benchmark that we should only stop http server while recieving 'GET /shutdown'.
4093
4094         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
4095         (ServerControl.render_POST): Deleted.
4096         * Scripts/webkitpy/thirdparty/__init__.py:
4097         (AutoinstallImportHook.find_module):
4098         (AutoinstallImportHook._install_twisted_15_5_0):
4099         * Scripts/webkitpy/thirdparty/__init___unittest.py:
4100         (ThirdpartyTest.test_imports):
4101
4102 2016-03-14  Mark Lam  <mark.lam@apple.com>
4103
4104         Need to distinguish between Symbol() and Symbol("").
4105         https://bugs.webkit.org/show_bug.cgi?id=155438
4106
4107         Reviewed by Saam Barati.
4108
4109         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
4110         (TestWebKitAPI::TEST):
4111         - Test that the a symbol with an empty string is not equivalent to a null symbol. 
4112
4113 2016-03-14  David Kilzer  <ddkilzer@apple.com>
4114
4115         Remove blank lines after #include "config.h"
4116
4117         Follow-up fix from review comments on Bug 155394.
4118
4119         * TestWebKitAPI/PlatformUtilities.cpp:
4120         * TestWebKitAPI/Tests/WTF/RefLogger.cpp:
4121
4122 2016-03-14  Frederic Wang  <fred.wang@free.fr>
4123
4124         Unreviewed: Add my professional email address.
4125
4126         * Scripts/webkitpy/common/config/contributors.json:
4127
4128 2016-03-14  Youenn Fablet  <youenn.fablet@crf.canon.fr>
4129
4130         Web platform test server should not try to launch servers on already bound sockets
4131         https://bugs.webkit.org/show_bug.cgi?id=141157
4132
4133         Reviewed by Darin Adler.
4134
4135         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
4136         (wpt_config_json): Load WPT config from LayoutTests/imported/w3c/resources/config.json.
4137         (base_url): Refactored to use wpt_config_json routine.
4138         (WebPlatformTestServer.__init__): Fill port mappings according WPT config.
4139
4140 2016-03-13  Joseph Pecoraro  <pecoraro@apple.com>
4141
4142         Remove ENABLE(ES6_TEMPLATE_LITERAL_SYNTAX) guards
4143         https://bugs.webkit.org/show_bug.cgi?id=155417
4144
4145         Reviewed by Yusuke Suzuki.
4146
4147         * Scripts/webkitperl/FeatureList.pm:
4148         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4149
4150 2016-03-13  Dean Jackson  <dino@apple.com>
4151
4152         DRT should enable WebGL by default on Mac
4153         https://bugs.webkit.org/show_bug.cgi?id=155419
4154         <rdar://problem/25136981>
4155
4156         Reviewed by Sam Weinig.
4157
4158         For some reason, lost in time, WebGL was enabled
4159         by default on trunk, but disabled by default
4160         in DumpRenderTree when using WebKit 1. This
4161         was very annoying, because each test had
4162         an explicit command to enable it.
4163
4164         * DumpRenderTree/mac/DumpRenderTree.mm:
4165         (resetWebPreferencesToConsistentValues): Deleted WebGL line.
4166
4167 2016-03-13  Konstantin Tokarev  <annulen@yandex.ru>
4168
4169         Added new port JSCOnly.
4170         https://bugs.webkit.org/show_bug.cgi?id=154512
4171
4172         Reviewed by Michael Catanzaro.
4173
4174         This port allows to build JavaScriptCore engine with minimal
4175         dependencies.
4176
4177         * Scripts/build-jsc:
4178         * Scripts/webkitdirs.pm:
4179         (argumentsForConfiguration):
4180         (executableProductDir):
4181         (determinePortName):
4182         (isJSCOnly):
4183         (wrapperPrefixIfNeeded):
4184         (generateBuildSystemFromCMakeProject):
4185         (buildCMakeGeneratedProject):
4186
4187 2016-03-13  David Kilzer  <ddkilzer@apple.com>
4188
4189         TestWebKitAPI: fix linker warnings
4190         <http://webkit.org/b/155394>
4191
4192         Reviewed by Darin Adler.
4193
4194         * TestWebKitAPI/CMakeLists.txt:
4195         - Add RefLogger.cpp source file.
4196         - Add other missing cross-platform source files.
4197         - Add FIXMEs about RunLoop.cpp and about missing
4198           platform-specific source files.
4199         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4200         - Add RefLogger.cpp source file.
4201
4202         * TestWebKitAPI/Counters.cpp:
4203         (DeleterCounter<ConstructorDestructorCounter>::deleterCount):
4204         Move specific declaration here to fix linker warning.
4205         * TestWebKitAPI/Counters.h:
4206         (DeleterCounter<T>::deleterCount): Remove declaration of global
4207         template variable.
4208
4209         * TestWebKitAPI/Tests/WTF/RefLogger.cpp: Added.
4210         (TestWebKitAPI::log): Added.  Move inline definition in
4211         RefLogger.h to here to fix linker warning.
4212
4213         * TestWebKitAPI/Tests/WTF/RefLogger.h:
4214         (TestWebKitAPI::log): Replace inline function with declaration.
4215
4216 2016-03-12  David Kilzer  <ddkilzer@apple.com>
4217
4218         REGRESSION (r178615): Fix incorrect case in included header for WeakPtr.cpp
4219
4220         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp: Change "test.h" to
4221         "Test.h" to fix incorrect case.  This was discovered when adding
4222         WeakPtr.cpp to CMakeLists.txt for the patch on Bug 155394.
4223
4224 2016-03-12  David Kilzer  <ddkilzer@apple.com>
4225
4226         run-webkit-tests: handle Darwin framework/library environment variables more consistently
4227         <http://webkit.org/b/155392>
4228
4229         Reviewed by Daniel Bates.
4230
4231         These changes will make it possible to pass through environment
4232         variables from the run-webkit-tests command-line.
4233
4234         * Scripts/webkitpy/port/base.py:
4235         (Port.to.setup_environ_for_server): Add DYLD_FRAMEWORK_PATH,
4236         __XPC_DYLD_FRAMEWORK_PATH and __XPC_DYLD_LIBRARY_PATH to the
4237         list of variables to keep from the run-webkit-test environment.
4238
4239         * Scripts/webkitpy/port/driver.py:
4240         (Driver._append_environment_variable_path): Add method to append
4241         a path to an environment variable, or set the path if the
4242         variable doesn't exist.
4243         (Driver._setup_environ_for_driver): Extract build_root_path into
4244         a local variable.  Use Driver._append_environment_variable_path
4245         to extend DYLD_LIBRARY_PATH, __XPC_DYLD_LIBRARY_PATH,
4246         DYLD_FRAMEWORK_PATH and __XPC_DYLD_FRAMEWORK_PATH instead of
4247         overwriting them.
4248
4249         * Scripts/webkitpy/port/driver_unittest.py:
4250         (DriverTest.test__append_environment_variable_path): Add test
4251         method to test Driver._append_environment_variable_path.
4252
4253 2016-03-11  Alexey Proskuryakov  <ap@apple.com>
4254
4255         [ios-sim debug] API test WTF_Lock.ContendedShortSection and WTF_ParkingLot.UnparkOneFifty timing out
4256         https://bugs.webkit.org/show_bug.cgi?id=155276
4257
4258         [ios-sim] API test WTF_Condition.TenProducersTenConsumersOneSlot timing out
4259         https://bugs.webkit.org/show_bug.cgi?id=155345
4260
4261         [iOS Simulator] API test timeout: WTF_ParkingLot.UnparkOneFiftyThenFiftyAll
4262         https://bugs.webkit.org/show_bug.cgi?id=153997
4263         <rdar://problem/23580034>
4264
4265         <rdar://problem/23580018> TestWebKitAPI Timeout: WTF_ParkingLot.UnparkOneFifty
4266
4267         Rubber-stamped by Filip Pizlo.
4268
4269         * Scripts/run-api-tests: These tests are pretty slow. Increase API test timeout.
4270
4271         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp: Start running WTF_ParkingLot.UnparkOneFiftyThenFiftyAll
4272         on iOS again.
4273
4274 2016-03-11  Jer Noble  <jer.noble@apple.com>
4275
4276         [ios-sim debug] API tests RequiresUserActionForPlaybackTest.DoesNotRequireUserActionForMediaPlayback and RequiresUserActionForAudioButNotVideoPlayback asserting
4277         https://bugs.webkit.org/show_bug.cgi?id=155365
4278
4279         Reviewed by Darin Adler.
4280
4281         Allow tests running on iOS simulator to play video inline, avoiding this assert.
4282
4283         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
4284         (RequiresUserActionForPlaybackTest::SetUp):
4285
4286 2016-03-11  Frederic Wang  <fwang@igalia.com>
4287
4288         [jhbuild] Disable LLVM OCaml bindings.
4289         https://bugs.webkit.org/show_bug.cgi?id=153274
4290
4291         Reviewed by Michael Catanzaro.
4292
4293         * gtk/jhbuild.modules: disable all (actually only OCaml) bindings for LLVM.
4294
4295 2016-03-11  Commit Queue  <commit-queue@webkit.org>
4296
4297         Unreviewed, rolling out r197495.
4298         https://bugs.webkit.org/show_bug.cgi?id=155369
4299
4300         LLVM is needed to run update-webkitgtk-libs reliably
4301         (Requested by mcatanzaro on #webkit).
4302
4303         Reverted changeset:
4304
4305         "[jhbuild] Remove LLVM dependency."
4306         https://bugs.webkit.org/show_bug.cgi?id=153274
4307         http://trac.webkit.org/changeset/197495
4308
4309 2016-03-11  Youenn Fablet  <youenn.fablet@crf.canon.fr>
4310
4311         WTF should have a similar function as equalLettersIgnoringASCIICase to match beginning of strings
4312         https://bugs.webkit.org/show_bug.cgi?id=153419
4313
4314         Reviewed by Darin Adler.
4315
4316         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
4317         (TestWebKitAPI::TEST): Adding test case for startsWithLettersIgnoringASCIICase.
4318
4319
4320 2016-03-10  Simon Fraser  <simon.fraser@apple.com>
4321
4322         Font antialiasing (smoothing) changes when elements are rendered into compositing layers
4323         https://bugs.webkit.org/show_bug.cgi?id=23364
4324
4325         Reviewed by Tim Horton.
4326
4327         Turn off smoothed layer text because it affects many layout test results.
4328
4329         * DumpRenderTree/mac/DumpRenderTree.mm:
4330         (resetWebViewToConsistentStateBeforeTesting):
4331         * WebKitTestRunner/TestController.cpp:
4332         (WTR::TestController::resetStateToConsistentValues):