[GTK] run-gtk-tests should use webkitpy.port.gtk and webkitpy.port.xvfbdriver
[WebKit-https.git] / Tools / ChangeLog
1 2016-08-26  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2
3         [GTK] run-gtk-tests should use webkitpy.port.gtk and webkitpy.port.xvfbdriver
4         https://bugs.webkit.org/show_bug.cgi?id=160736
5
6         Reviewed by Carlos Garcia Campos.
7
8         This plugs run-gtk-tests into the webkitpy testing infrastructure.
9         As a benefit of this, run-gtk-tests now can be executed over any of
10         the existing supported gtk test display servers (xvfb, weston-over-xvfb,
11         or native xorg). A new command line switch --wayland is added for
12         run-gtk-tests.
13
14         * Scripts/run-gtk-tests:
15         (TestRunner.__init__): Remove the --display command line switch, its not longer useful.
16         Add a --wayland command line switch.
17         (TestRunner._start_accessibility_daemons):
18         (TestRunner):
19         (TestRunner.__init__):
20         (TestRunner._run_xvfb): Deleted.
21         (TestRunner._create_driver):
22         (TestRunner._setup_testing_environment): Delete the environment variable definitions that
23         are now done by driver._setup_environ_for_test().
24         (TestRunner._tear_down_testing_environment):
25         * Scripts/webkitpy/port/driver.py:
26         (Driver.__init__): Define self._server_name in the constructor of the base class.
27         It is used by several functions, so it makes sense to store once the value here.
28         (Driver._setup_environ_for_test): Factorize setting the environment for a given test.
29         (Driver._start): Get the environment from self._setup_environ_for_test()
30         * Scripts/webkitpy/port/driver_unittest.py:
31         (DriverTest):
32         (DriverTest.test_setup_environ_for_test): Add unittest for driver._setup_environ_for_test()
33         * Scripts/webkitpy/port/gtk.py: Move the inspection of the env var USE_NATIVE_XDISPLAY to the constructor.
34         (GtkPort.__init__):
35         (GtkPort._driver_class):
36         * Scripts/webkitpy/port/westondriver.py: Define and use self._setup_environ_for_test()
37         (WestonDriver._setup_environ_for_test):
38         (WestonDriver._start):
39         * Scripts/webkitpy/port/xorgdriver.py: Define and use self._setup_environ_for_test()
40         (XorgDriver._setup_environ_for_test):
41         (XorgDriver._start):
42         * Scripts/webkitpy/port/xvfbdriver.py: Define and use self._setup_environ_for_test()
43         (XvfbDriver._setup_environ_for_test):
44         (XvfbDriver._start):
45
46 2016-08-26  Csaba Osztrogonác  <ossy@webkit.org>
47
48         [EFL][GTK] REGRESSION(204877): Fix the clean build
49         https://bugs.webkit.org/show_bug.cgi?id=161240
50
51         Reviewed by Carlos Garcia Campos.
52
53         * WebKitTestRunner/PlatformEfl.cmake:
54         * WebKitTestRunner/PlatformGTK.cmake:
55
56 2016-08-26  Aakash Jain  <aakash_jain@apple.com>
57
58         EWS should indicate which bot processed the patch
59         https://bugs.webkit.org/show_bug.cgi?id=161222
60
61         Reviewed by Daniel Bates.
62
63         * QueueStatusServer/handlers/statusbubble.py:
64         (StatusBubble._build_bubble): Display the bot id in status bubble. Also removed "Started processing" message since
65         after bug fix of 161223, bots send the "Started processing patch" message and it would be displayed in Recent messages.
66         Also added "Started processing patch" message to progress_statuses.
67         I might consider displaying bot id in other statuses as well later on.
68
69 2016-08-26  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
70
71         [EFL] Change homepage url to www.ewebkit.org on MiniBrowser
72         https://bugs.webkit.org/show_bug.cgi?id=161184
73
74         Reviewed by Carlos Garcia Campos.
75
76         * MiniBrowser/efl/main.c: Set www.ewebkit.org.
77
78 2016-08-25  Aakash Jain  <aakash_jain@apple.com>
79
80         ews queues should update status server when they start processing patch
81         https://bugs.webkit.org/show_bug.cgi?id=161223
82
83         Reviewed by Daniel Bates.
84
85         * Scripts/webkitpy/tool/commands/queues.py:
86         (AbstractReviewQueue.process_work_item): Update status server that the bot started processing the patch.
87         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
88         (EarlyWarningSystemTest._default_expected_logs): Updated the unit test accordingly.
89         * Scripts/webkitpy/tool/commands/queues_unittest.py:
90         (StyleQueueTest.test_style_queue_with_style_exception): Same.
91         (test_style_queue_with_watch_list_exception): Same.
92         (test_non_valid_patch): Same.
93
94 2016-08-25  Alex Christensen  <achristensen@webkit.org>
95
96         CMake build fix.
97
98         * DumpRenderTree/PlatformMac.cmake:
99
100 2016-08-25  Alex Christensen  <achristensen@webkit.org>
101
102         Fix URLParserTest with GuardMalloc
103         https://bugs.webkit.org/show_bug.cgi?id=161214
104         rdar://problem/28014390
105
106         Reviewed by Tim Horton.
107
108         The CString returned by String::utf8 was going out of scope before we were doing a string comparison on its data.
109         This just does the comparison of the CStrings instead to keep them in scope during the comparison.
110
111         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
112         (TestWebKitAPI::eq):
113         (TestWebKitAPI::checkURL):
114         (TestWebKitAPI::checkURLDifferences):
115         (TestWebKitAPI::s): Deleted.
116
117 2016-08-25  Wenson Hsieh  <wenson_hsieh@apple.com>
118
119         Dragging against the end of the inline media scrubber causes the media scrubber to hide
120         https://bugs.webkit.org/show_bug.cgi?id=161207
121
122         Reviewed by Eric Carlson.
123
124         Tweaks an existing WebKit API test covering this behavior change. After some discussion, rather than hide media
125         controls in this case, we should actually continue showing them. This is because seeking due to user gestures
126         similar to "scrubbing" are indistinguishable from gestures that immediately seek to the end.
127
128         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
129         (TestWebKitAPI::TEST):
130
131 2016-08-25  Daniel Bates  <dabates@apple.com>
132
133         Watch more things.
134
135         * Scripts/webkitpy/common/config/watchlist:
136
137 2016-08-25  Daniel Bates  <dabates@apple.com>
138
139         Fix test failure on GTK Linux bots after <http://trac.webkit.org/changeset/204695>
140         (https://bugs.webkit.org/show_bug.cgi?id=148437)
141
142         Remove use of module File::Slurp as it is not part of the standard Perl 5 distribution
143         and is not installed on the GTK Linux bots.
144
145         * Scripts/webkitperl/prepare-ChangeLog_unittest/generateFunctionLists.pl:
146         (writeFileWithContent): Added.
147
148 2016-08-25  Per Arne Vollan  <pvollan@apple.com>
149
150         [Win] run-api-tests is failing.
151         https://bugs.webkit.org/show_bug.cgi?id=161140
152
153         Reviewed by Brent Fulgham.
154
155         Since the move constructor is called 3 more times on Windows, we will have 3 more destructor calls.
156
157         * TestWebKitAPI/Tests/WTF/CrossThreadTask.cpp:
158         (TestWebKitAPI::TEST):
159
160 2016-08-24  Per Arne Vollan  <pvollan@apple.com>
161
162         [Win] run-api-tests is failing.
163         https://bugs.webkit.org/show_bug.cgi?id=161140
164
165         Reviewed by Brent Fulgham.
166
167         The number of times the move constructor is called is different on Windows in this test. This seems
168         to be caused by differences in MSVC's implementation of lambdas or std functions like std::make_tuple.
169
170         * TestWebKitAPI/Tests/WTF/CrossThreadTask.cpp:
171         (TestWebKitAPI::TEST):
172
173 2016-08-24  Simon Fraser  <simon.fraser@apple.com>
174
175         Fix iOS DRT build.
176
177         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
178         (WTR::UIScriptController::zoomToScale):
179
180 2016-08-24  Simon Fraser  <simon.fraser@apple.com>
181
182         [iOS DRT] Hook up uiController.zoomToScale() for DRT
183         https://bugs.webkit.org/show_bug.cgi?id=161173
184
185         Reviewed by Tim Horton.
186         
187         Make a UIWebScrollView subclass, DumpRenderTreeWebScrollView, which has an internal delegate to get
188         UIScrollView delegate callbacks. Store the zoomToScaleCompletionHandler on it.
189         
190         UIScriptController::zoomToScale() has to bounce the zoom to the main thread (no poking UIKit from
191         the WebThread!), but queue up the callback first.
192
193         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
194         * DumpRenderTree/ios/DumpRenderTreeBrowserView.mm:
195         (-[DumpRenderTreeWebScrollView initWithFrame:]):
196         (-[DumpRenderTreeWebScrollView dealloc]):
197         (-[DumpRenderTreeWebScrollView zoomToScale:animated:completionHandler:]):
198         (-[DumpRenderTreeWebScrollView completedZoomToScale]):
199         (-[DumpRenderTreeWebScrollViewDelegate initWithScrollView:]):
200         (-[DumpRenderTreeWebScrollViewDelegate viewForZoomingInScrollView:]): All UIScrollView delegates need to implement this.
201         (-[DumpRenderTreeWebScrollViewDelegate scrollViewDidEndZooming:withView:atScale:]):
202         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
203         (WTR::UIScriptController::zoomToScale):
204         * DumpRenderTree/mac/DumpRenderTree.mm:
205         (createWebViewAndOffscreenWindow):
206         * TestRunnerShared/UIScriptContext/UIScriptController.h:
207         (WTR::UIScriptController::context):
208
209 2016-08-24  Ryan Haddad  <ryanhaddad@apple.com>
210
211         Attempt to fix Windows build after r204918.
212
213         Unreviewed build fix.
214
215         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
216         (ResourceLoadDelegate::willSendRequest):
217
218 2016-08-24  Simon Fraser  <simon.fraser@apple.com>
219
220         [iOS DRT] Get basic viewport tests working in DRT
221         https://bugs.webkit.org/show_bug.cgi?id=161160
222
223         Reviewed by Tim Horton.
224         
225         Hook up enough of UIScriptController in iOS DRT to be able to read viewport
226         scale, and get the contentVisibleRect.
227         
228         Requires exposing a bit of UIWebBrowserView SPI from UIKit, which in turn
229         requires typing the gWebBrowserView as a DumpRenderTreeBrowserView * everywhere.
230         
231         One test has different results between DRT and WTR, but DRT behavior seems to differ
232         from UIWebView here, so just give it a WK1-specific result.
233
234         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
235         * DumpRenderTree/ios/DumpRenderTreeBrowserView.mm:
236         (-[DumpRenderTreeBrowserView documentVisibleRect]):
237         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
238         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
239         (WTR::UIScriptController::zoomScale):
240         (WTR::UIScriptController::minimumZoomScale):
241         (WTR::UIScriptController::maximumZoomScale):
242         (WTR::UIScriptController::contentVisibleRect):
243         * DumpRenderTree/mac/DumpRenderTree.mm:
244         (createWebViewAndOffscreenWindow):
245         * DumpRenderTree/mac/DumpRenderTreeMac.h:
246
247 2016-08-24  Simon Fraser  <simon.fraser@apple.com>
248
249         Minor project rearrangement.
250
251         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
252
253 2016-08-24  Simon Fraser  <simon.fraser@apple.com>
254
255         [iOS DRT] Make iOS DRT use the same window size as WebKitTestRunner for flexible viewport tests
256         https://bugs.webkit.org/show_bug.cgi?id=161124
257
258         Reviewed by Daniel Bates.
259         
260         Use the main UIScreen's bounds for the size of the window in flexible viewport mode,
261         and remove the 'phoneBrowserAddressBarOffset' hack, so that it matches WTR.
262         
263         Remove some unnecessary zero initializations of static variables.
264         
265         Change _setVisibleSize to use the window size, which should not be a behavior change
266         because this it just used for text autosizing, which is disabled by default,
267         and only the width is consulted.
268
269         * DumpRenderTree/mac/DumpRenderTree.mm:
270         (adjustWebDocumentForFlexibleViewport):
271         (adjustWebDocumentForStandardViewport):
272         (createWebViewAndOffscreenWindow):
273
274 2016-08-24  Jonathan Bedard  <jbedard@apple.com>
275
276         WebKit2 needs layoutTestController.setDeferMainResourceDataLoad
277         https://bugs.webkit.org/show_bug.cgi?id=42777
278
279         Reviewed by Darin Adler.
280
281         The setDeferMainResourceDataLoad method was not correctly tested in DumpRenderTree and would pass even when setDeterMainResourceDataLoad was not called.  Removed function and test.
282
283         * DumpRenderTree/TestRunner.cpp:
284         (setDeferMainResourceDataLoadCallback): Removed setDeferMainResourceDataLoad.
285         * DumpRenderTree/TestRunner.h:
286         (TestRunner::deferMainResourceDataLoad): Ditto.
287         (TestRunner::setDeferMainResourceDataLoad): Ditto.
288         * DumpRenderTree/mac/ResourceLoadDelegate.mm: Ditto.
289
290 2016-08-23  Anders Carlsson  <andersca@apple.com>
291
292         Add enum traits and use them in the IPC::Decoder
293         https://bugs.webkit.org/show_bug.cgi?id=161103
294
295         Reviewed by Sam Weinig.
296
297         Add API test.
298
299         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
300         * TestWebKitAPI/Tests/WTF/EnumTraits.cpp: Added.
301         (TestWebKitAPI::TEST):
302
303 2016-08-24  Filip Pizlo  <fpizlo@apple.com>
304
305         Unreviewed, roll out r204901, r204897, r204866, r204856, r204854.
306
307         * DumpRenderTree/TestRunner.cpp:
308         * DumpRenderTree/mac/DumpRenderTree.mm:
309         (DumpRenderTreeMain):
310         * Scripts/run-jsc-stress-tests:
311         * TestWebKitAPI/Tests/WTF/Vector.cpp:
312         (TestWebKitAPI::TEST):
313
314 2016-08-24  Simon Fraser  <simon.fraser@apple.com>
315
316         Try to fix Production builds.
317         
318         PRODUCTION_FRAMEWORKS_DIR was undefined here.
319
320         * DumpRenderTree/mac/Configurations/Base.xcconfig:
321
322 2016-08-24  Dan Bernstein  <mitz@apple.com>
323
324         Add a convenience function for creating a WKFrameHandleRef from a WKFrameRef without going through WKFrameInfoRef
325         https://bugs.webkit.org/show_bug.cgi?id=161152
326
327         Reviewed by Anders Carlsson.
328
329         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
330         * TestWebKitAPI/Tests/WebKit2/FrameHandle.cpp: Added.
331         (TestWebKitAPI::didFinishLoadForFrame):
332         (TestWebKitAPI::TEST):
333
334 2016-08-24  Nan Wang  <n_wang@apple.com>
335
336         AX: Add test for line text marker range on iOS
337         https://bugs.webkit.org/show_bug.cgi?id=161108
338         <rdar://problem/27976405>
339
340         Reviewed by Chris Fleizach.
341
342         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
343         (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
344         (AccessibilityUIElement::textMarkerRangeForElement):
345         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
346         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
347         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
348
349 2016-08-24  Per Arne Vollan  <pvollan@apple.com>
350
351         [Win] Warning fixes.
352         https://bugs.webkit.org/show_bug.cgi?id=161079
353
354         Reviewed by Brent Fulgham.
355
356         * MiniBrowser/win/WebDownloadDelegate.cpp:
357         * MiniBrowser/win/WinMain.cpp:
358         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
359         (TestWebKitAPI::TEST):
360
361 2016-08-23  Simon Fraser  <simon.fraser@apple.com>
362
363         Fix Windows DRT build.
364
365         * DumpRenderTree/win/TestRunnerWin.cpp:
366         (TestRunner::mainFrameJSContext):
367
368 2016-08-23  Simon Fraser  <simon.fraser@apple.com>
369
370         Try to fix Windows build.
371         
372         Pass Tools/DumpRenderTree/Bindings as the working directory for the generate_bindings.pl
373         so that perl finds CodeGeneratorDumpRenderTree.pm.
374
375         * DumpRenderTree/CMakeLists.txt:
376
377 2016-08-23  Simon Fraser  <simon.fraser@apple.com>
378
379         Hook up UIScriptController in DumpRenderTree
380         https://bugs.webkit.org/show_bug.cgi?id=161064
381
382         Reviewed by Sam Weinig.
383
384         Add a skeleton implementation of UIScriptController to DumpRenderTree, building for both
385         Mac and iOS. Currently this is sufficient to test doAsyncTask(), enabling two tests
386         in fast/harness which test this.
387
388         Add a DerivedSources target to DumpRenderTree to invoke DerivedSources.make.
389
390         Move related code shared between WTR and DRT into Tools/TestRunnerShared, and cleanse it of
391         WK2-isms. Fix the makefiles to refer to the new location.
392
393         Hook up TestRunner::runUIScript() for DumpRenderTree, which requires keeping track of callbacks
394         by ID and firing them once they are complete.
395
396         * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm: Added (copied from WTR).
397         * DumpRenderTree/CMakeLists.txt:
398         * DumpRenderTree/DerivedSources.make: Copied from Tools/WebKitTestRunner/DerivedSources.make.
399         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
400         * DumpRenderTree/TestRunner.cpp:
401         (runUIScriptCallback):
402         (TestRunner::staticFunctions):
403         (TestRunner::cacheTestRunnerCallback):
404         (TestRunner::callTestRunnerCallback):
405         (TestRunner::clearTestRunnerCallbacks):
406         (nextUIScriptCallbackID):
407         (TestRunner::runUIScript):
408         (TestRunner::callUIScriptCallback):
409         (TestRunner::uiScriptDidComplete):
410         (TestRunner::cleanup):
411         * DumpRenderTree/TestRunner.h:
412         * DumpRenderTree/ios/UIScriptControllerIOS.mm: Added.
413         * DumpRenderTree/mac/Configurations/Base.xcconfig: DerivedSources.make needs WEBCORE_PRIVATE_HEADERS_DIR to be defined.
414         * DumpRenderTree/mac/DumpRenderTree.mm:
415         (runTest):
416         * DumpRenderTree/mac/TestRunnerMac.mm:
417         (TestRunner::mainFrameJSContext):
418         * DumpRenderTree/mac/UIScriptControllerMac.mm: Copied from Tools/WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h.
419         (WTR::UIScriptController::doAsyncTask):
420         * DumpRenderTree/win/DumpRenderTree.cpp:
421         * TestRunnerShared/Bindings/JSWrappable.h: Renamed from Tools/WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h.
422         (WTR::JSWrappable::~JSWrappable):
423         (WTR::JSValueMakeStringOrNull):
424         * TestRunnerShared/Bindings/JSWrapper.cpp: Renamed from Tools/WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp.
425         (WTR::JSWrapper::wrap):
426         (WTR::JSWrapper::unwrap):
427         (WTR::unwrapObject):
428         (WTR::JSWrapper::initialize):
429         (WTR::JSWrapper::finalize):
430         * TestRunnerShared/Bindings/JSWrapper.h: Renamed from Tools/WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.h.
431         (WTR::toJS):
432         (WTR::setProperty):
433         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl: Renamed from Tools/WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl.
434         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp: Renamed from Tools/WebKitTestRunner/UIScriptContext/UIScriptContext.cpp.
435         * TestRunnerShared/UIScriptContext/UIScriptContext.h: Renamed from Tools/WebKitTestRunner/UIScriptContext/UIScriptContext.h.
436         (WTR::UIScriptContext::currentParentCallbackIsPendingCompletion):
437         * TestRunnerShared/UIScriptContext/UIScriptController.cpp: Renamed from Tools/WebKitTestRunner/UIScriptContext/UIScriptController.cpp.
438         * TestRunnerShared/UIScriptContext/UIScriptController.h: Renamed from Tools/WebKitTestRunner/UIScriptContext/UIScriptController.h.
439         * WebKitTestRunner/CMakeLists.txt:
440         * WebKitTestRunner/DerivedSources.make:
441         * WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h:
442         (WTR::JSWrappable::~JSWrappable): Deleted.
443         (WTR::JSValueMakeStringOrNull): Deleted.
444         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp:
445         (WTR::JSWrapper::wrap): Deleted.
446         (WTR::JSWrapper::unwrap): Deleted.
447         (WTR::unwrapObject): Deleted.
448         (WTR::JSWrapper::initialize): Deleted.
449         (WTR::JSWrapper::finalize): Deleted.
450         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.h:
451         (WTR::toJS): Deleted.
452         (WTR::setProperty): Deleted.
453         * WebKitTestRunner/TestInvocation.cpp:
454         (WTR::TestInvocation::runUISideScript):
455         (WTR::TestInvocation::uiScriptDidComplete):
456         * WebKitTestRunner/TestInvocation.h:
457         * WebKitTestRunner/UIScriptContext/UIScriptContext.cpp: Moved
458         * WebKitTestRunner/UIScriptContext/UIScriptContext.h: Moved
459         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp: Moved
460         * WebKitTestRunner/UIScriptContext/UIScriptController.h: Moved
461         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
462         * WebKitTestRunner/config.h:
463         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
464         (WTR::UIScriptController::contentVisibleRect):
465
466 2016-08-23  Saam Barati  <sbarati@apple.com>
467
468         JSC should have a "microbenchmarks" directory instead of "regress" directory
469         https://bugs.webkit.org/show_bug.cgi?id=161096
470
471         Rubber stamped by Mark Lam.
472
473         This patch moves LayoutTests/js/regress/script-tests to the JSTests/microbenchmarks
474         directory and removes all the related html and txt files. I did this because
475         that directory was only there for microbenchmarks, and not for "regression"
476         tests. I also changed the various scripts to point to it.
477
478         * Scripts/run-javascriptcore-tests:
479         (runJSCStressTests):
480         * Scripts/run-jsc-benchmarks:
481
482 2016-08-23  Alex Christensen  <achristensen@webkit.org>
483
484         Fix EFL build.
485
486         * TestWebKitAPI/CMakeLists.txt:
487         Include new directory.
488
489 2016-08-22  Filip Pizlo  <fpizlo@apple.com>
490
491         Butterflies should be allocated in Auxiliary MarkedSpace instead of CopiedSpace and we should rewrite as much of the GC as needed to make this not a regression
492         https://bugs.webkit.org/show_bug.cgi?id=160125
493
494         Reviewed by Geoffrey Garen.
495
496         * DumpRenderTree/TestRunner.cpp: Rewire some #includes.
497         * Scripts/run-jsc-stress-tests: New test flag!
498
499 2016-08-23  Brady Eidson  <beidson@apple.com>
500
501         WK2 Gamepad layout test support.
502         https://bugs.webkit.org/show_bug.cgi?id=134671
503
504         Reviewed by Alex Christensen.
505         
506         Have the injected bundle expose the MockGamepadProvider to the UI process, which will then 
507         feed back into the UIGamepadProvider.
508         
509         Also, fool NSApplication into treating the most recently created "isKeyWindow" of the test windows
510         as the actual keyWindow for the test runner, which will allow the view to get gamepad updates.
511
512         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
513         
514         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
515         (WTR::TestRunner::setMockGamepadDetails):
516         (WTR::TestRunner::setMockGamepadAxisValue):
517         (WTR::TestRunner::setMockGamepadButtonValue):
518         
519         * WebKitTestRunner/PlatformWebView.h:
520         
521         * WebKitTestRunner/TestController.cpp:
522         (WTR::TestController::initialize):
523         
524         * WebKitTestRunner/TestInvocation.cpp:
525         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
526         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Deleted.
527         
528         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
529         
530         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
531         (-[WebKitTestRunnerWindow initWithFrame:]):
532         (-[WebKitTestRunnerWindow dealloc]):
533         (WTR::PlatformWebView::keyWindow):
534         
535         * WebKitTestRunner/ios/TestControllerIOS.mm:
536         (WTR::wtr_NSApplication_keyWindow):
537         (WTR::TestController::platformInitialize):
538         
539         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
540         (+[WebKitTestRunnerWindow _WTR_keyWindow]):
541         (-[WebKitTestRunnerWindow initWithContentRect:styleMask:backing:defer:]):
542         (-[WebKitTestRunnerWindow dealloc]):
543         (WTR::PlatformWebView::keyWindow):
544         
545         * WebKitTestRunner/mac/TestControllerMac.mm:
546         (WTR::wtr_NSApplication_keyWindow):
547         (WTR::TestController::platformInitialize):
548         * WebKitTestRunner/mac/main.mm:
549
550 2016-08-23  Alexey Proskuryakov  <ap@apple.com>
551
552         REGRESSION (PHP 5.6): http/tests/misc/bad-charset-alias.html fails
553         https://bugs.webkit.org/show_bug.cgi?id=161047
554         rdar://problem/27434307
555
556         Reviewed by Lucas Forschler.
557
558         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py: Specify a php.ini file.
559
560 2016-08-23  Chris Dumez  <cdumez@apple.com>
561
562         Unreviewed, rolling out r204243.
563
564         Caused some layout test failures
565
566         Reverted changeset:
567
568         "Write API test to cover crash fix in r204135"
569         https://bugs.webkit.org/show_bug.cgi?id=160587
570         http://trac.webkit.org/changeset/204243
571
572 2016-08-23  Rawinder Singh  <rawinder.singh-webkit@cisra.canon.com.au>
573
574         Order feature option list in FeatureList.pm
575         https://bugs.webkit.org/show_bug.cgi?id=161074
576
577         Reviewed by Michael Catanzaro.
578
579         Reorder features in alphabetical order based on command line option. Also, sort variables in alphabetical order.
580
581         * Scripts/webkitperl/FeatureList.pm:
582
583 2016-08-22  Dewei Zhu  <dewei_zhu@apple.com>
584
585         Stop python icon bouncing in the dock while running browser benchmarks.
586         https://bugs.webkit.org/show_bug.cgi?id=161066
587
588         Reviewed by Ryosuke Niwa.
589
590         Bouncing python icon may impact browser benchmark results.
591         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
592         (OSXBrowserDriver.prepare_env):
593         (OSXBrowserDriver.restore_env):
594
595 2016-08-22  Simon Fraser  <simon.fraser@apple.com>
596
597         <select> menu on iPad causes shifting of hit-testing areas
598         https://bugs.webkit.org/show_bug.cgi?id=150079
599
600         Reviewed by Tim Horton.
601
602         -isAssistingNode (aka the poorly named isEditable) is input into WebPageProxy::computeCustomFixedPositionRect(),
603         so when it changes we have to update visible rects. We were doing this on focus, but failing
604         to do it on blur.
605
606         Added the ability to test by:
607         1. Making it possible to initiate an animated scroll in the UI process
608         2. Adding callbacks for starting and ending interaction with a form control. Sadly
609         the "ending interaction" for <select> popovers on iPad isn't late enough, since we
610         have no way currently to know when the dimming view behind the popover animates out,
611         so for now the test keeps trying to tap a button.
612
613         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
614         * WebKitTestRunner/UIScriptContext/UIScriptContext.h:
615         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
616         (WTR::UIScriptController::setDidStartFormControlInteractionCallback):
617         (WTR::UIScriptController::didStartFormControlInteractionCallback):
618         (WTR::UIScriptController::setDidEndFormControlInteractionCallback):
619         (WTR::UIScriptController::didEndFormControlInteractionCallback):
620         (WTR::UIScriptController::scrollToOffset):
621         (WTR::UIScriptController::platformSetDidStartFormControlInteractionCallback):
622         (WTR::UIScriptController::platformSetDidEndFormControlInteractionCallback):
623         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
624         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
625         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
626         (-[TestRunnerWKWebView dealloc]):
627         (-[TestRunnerWKWebView didStartFormControlInteraction]):
628         (-[TestRunnerWKWebView didEndFormControlInteraction]):
629         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
630         (WTR::contentOffsetBoundedInValidRange):
631         (WTR::UIScriptController::scrollToOffset):
632         (WTR::UIScriptController::platformSetDidStartFormControlInteractionCallback):
633         (WTR::UIScriptController::platformSetDidEndFormControlInteractionCallback):
634
635 2016-08-22  Carlos Alberto Lopez Perez  <clopez@igalia.com>
636
637         [EFL][GTK] Script process-linux-coredump is not needed, switch back to use the kernel core dumper instead.
638         https://bugs.webkit.org/show_bug.cgi?id=160927
639
640         Reviewed by Daniel Bates.
641
642         * Scripts/process-linux-coredump: Removed.
643         * Scripts/webkitpy/port/efl.py:
644         (EflPort._get_crash_log):
645         * Scripts/webkitpy/port/gtk.py:
646         (GtkPort._get_crash_log):
647         * Scripts/webkitpy/port/linux_get_crash_log.py:
648         (GDBCrashLogGenerator.__init__):
649         (GDBCrashLogGenerator.generate_crash_log):
650         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
651         (GDBCrashLogGeneratorTest.test_generate_crash_log):
652
653 2016-08-22  Jonathan Bedard  <jbedard@apple.com>
654
655         check-webkit-style does not work with Lambda functions in C++
656         https://bugs.webkit.org/show_bug.cgi?id=160910
657
658         Reviewed by Darin Adler.
659
660         This change eliminates false positives on correctly styled lambda functions and includes a few basic checks on capture list.
661
662         * Scripts/webkitpy/style/checkers/cpp.py:
663         (regex_for_lambda_functions): Added function which checks if a string is the start of a lambda function.
664         (check_for_non_standard_constructs): Added lambda function check.
665         (check_spacing_for_function_call): Added lambda function check.
666         (check_braces): Added lambda function check.
667         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
668         (CppStyleTest.test_lambda_functions): Added test function for lambda function style checks.
669
670 2016-08-21  Alex Christensen  <achristensen@webkit.org>
671
672         URLParser should parse IPv4 addresses
673         https://bugs.webkit.org/show_bug.cgi?id=161023
674
675         Reviewed by Darin Adler.
676
677         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
678         (TestWebKitAPI::TEST_F):
679         (TestWebKitAPI::checkURLDifferences):
680         We are already getting differences between the old URL::parse and the new URLParser.
681         (TestWebKitAPI::shouldFail):
682
683 2016-08-21  Daniel Bates  <dabates@apple.com>
684
685         prepare-ChangeLog lists unmodified functions as modified and marks functions with few changes as deleted
686         https://bugs.webkit.org/show_bug.cgi?id=148437
687
688         Reviewed by Dan Bernstein.
689
690         * Scripts/prepare-ChangeLog:
691         (diffCommand): When using a Subversion checkout, generate a unified diff without any context lines.
692         This matches our behavior when using a Git checkout. The function overlap logic in generateFunctionListsByRanges()
693         assumes that its line ranges were from a unified diff without any context lines.
694         (extractLineRangeAfterChange): A deleted line should be represented with a ("begin line number", "end line number") = ("new starting line number", "new starting line number").
695         (extractLineRangeBeforeChange): An added line should be represented with a ("begin line number", "end line number") = ("original starting line number", "original starting line number").
696         * Scripts/webkitperl/prepare-ChangeLog_unittest/extractLineRangeBeforeAndAfterChange.pl: Update expected results
697         based on changes to extractLineRangeAfterChange() and extractLineRangeBeforeChange().
698         * Scripts/webkitperl/prepare-ChangeLog_unittest/generateFunctionLists.pl: Added.
699         (discardOutput): Convenience function invokes the specified function redirecting standard output and standard error
700         to /dev/null for the duration of the function call.
701
702 2016-08-20  Gyuyoung Kim  <gyuyoung.kim@navercorp.com>
703
704         [EFL] Remove unnecessary a patch to mute ecore warnings
705         https://bugs.webkit.org/show_bug.cgi?id=160997
706
707         Reviewed by Darin Adler.
708
709         There is no warning messages during the layout test and perf test
710         after bumping efl version from 1.17 to 1.18. Remove it.
711
712         * efl/patches/ecore_remove_warnings.patch: Removed.
713
714 2016-08-20  Simon Fraser  <simon.fraser@apple.com>
715
716         REGRESSION (r204477): Running LayoutTests on ios-simulator became ~15 minutes slower
717         https://bugs.webkit.org/show_bug.cgi?id=160985
718
719         Re-land r204672, but don't check the result of 'xcrun simctl shutdown', because
720         device shutdown seems to happen as result of killing Simulator.apps, and we're racing
721         with that.
722
723         * Scripts/webkitpy/layout_tests/views/printing.py:
724         (Printer.print_config):
725         * Scripts/webkitpy/port/base.py:
726         (Port.driver_cmd_line_for_logging):
727         (Port.driver_cmd_line): Deleted.
728         * Scripts/webkitpy/port/driver.py:
729         (IOSSimulatorDriver.cmd_line):
730         * Scripts/webkitpy/port/ios.py:
731         (IOSSimulatorPort.__init__):
732         (IOSSimulatorPort.driver_cmd_line_for_logging):
733         (IOSSimulatorPort._create_simulators):
734         (IOSSimulatorPort.setup_test_run):
735         (IOSSimulatorPort._quit_ios_simulator):
736         (IOSSimulatorPort.clean_up_test_run):
737         (IOSSimulatorPort._create_device):
738         (IOSSimulatorPort):
739         (IOSSimulatorPort._remove_device):
740         (IOSSimulatorPort._testing_device):
741         (IOSSimulatorPort.device_id_for_worker_number):
742         (IOSSimulatorPort._set_device_class): Deleted.
743         (IOSSimulatorPort.testing_device): Deleted.
744         * Scripts/webkitpy/port/port_testcase.py:
745         (PortTestCase.test_driver_cmd_line):
746         * Scripts/webkitpy/xcode/simulator.py:
747         (Device.shutdown):
748         (Device):
749         (Device.delete):
750         (Device.reset):
751         (Simulator):
752         (Simulator.create_device):
753         (Simulator.remove_device):
754         (Simulator.device_number):
755         (Simulator.device_state_description):
756         (Simulator.wait_until_device_is_in_state):
757
758 2016-08-19  Ryan Haddad  <ryanhaddad@apple.com>
759
760         Unreviewed, rolling out r204659.
761
762         This change appears to have caused ios-simulator LayoutTests
763         to fail when shutting down the simulator
764
765         Reverted changeset:
766
767         "REGRESSION (r204477): Running LayoutTests on ios-simulator
768         became ~15 minutes slower"
769         https://bugs.webkit.org/show_bug.cgi?id=160985
770         http://trac.webkit.org/changeset/204659
771
772 2016-08-19  Alexey Proskuryakov  <ap@apple.com>
773
774         Build fix for non-USE_SIM_SERVICE_CONTEXT builds
775         * LayoutTestRelay/LayoutTestRelay/main.m: (main):
776
777 2016-08-18  Simon Fraser  <simon.fraser@apple.com>
778
779         REGRESSION (r204477): Running LayoutTests on ios-simulator became ~15 minutes slower
780         https://bugs.webkit.org/show_bug.cgi?id=160985
781
782         Reviewed by Alexey Proskuryakov.
783         
784         r204477 removed @memoized on a couple of ios.py functions, causing them to instantiate
785         a Simulator() on every call, which causes 'xcrun simctl list' to run. The functions
786         must not be @memoized, because their return value depends on the value of simulator_device_type().
787         
788         Fix by adding some global state in simulator.py that tracks the created devices 
789         in a worker number -> Device dictionary. Explicitly create devices in _create_simulators(),
790         and delete them in clean_up_test_run().
791         
792         Also explicitly called 'xcrun simctl shutdown' to shut down devices, since it seems
793         that killing the Simulator apps isn't enough.
794         
795         Simulator tracks the devices in a global dictionary, since state needs to persist
796         across different instances of IOSSimulatorPort.
797         
798         Annoyingly, the "Command line:" dumping tried to access a device before we'd done
799         any setup. Rather than implicitly creating a device here (which the old code did),
800         override the more clearly named driver_cmd_line_for_logging() in IOSSimulatorPort
801         and set flag to say that device_id_for_worker_number() doesn't need to return a real
802         device id.
803
804         * Scripts/webkitpy/layout_tests/views/printing.py:
805         (print_options):
806         (Printer.print_config):
807         * Scripts/webkitpy/port/base.py:
808         (Port.driver_cmd_line_for_logging):
809         (Port.driver_cmd_line): Deleted.
810         * Scripts/webkitpy/port/driver.py:
811         (IOSSimulatorDriver.cmd_line):
812         * Scripts/webkitpy/port/ios.py:
813         (IOSSimulatorPort.__init__):
814         (IOSSimulatorPort.driver_cmd_line_for_logging):
815         (IOSSimulatorPort._create_simulators):
816         (IOSSimulatorPort.setup_test_run):
817         (IOSSimulatorPort.clean_up_test_run):
818         (IOSSimulatorPort._create_device):
819         (IOSSimulatorPort):
820         (IOSSimulatorPort._remove_device):
821         (IOSSimulatorPort._testing_device):
822         (IOSSimulatorPort.device_id_for_worker_number):
823         (IOSSimulatorPort._set_device_class): Deleted.
824         (IOSSimulatorPort.testing_device): Deleted.
825         * Scripts/webkitpy/port/port_testcase.py:
826         (PortTestCase.test_driver_cmd_line):
827         * Scripts/webkitpy/xcode/simulator.py:
828         (Device.shutdown):
829         (Device.delete):
830         (Device.reset):
831         (Simulator.create_device):
832         (Simulator.remove_device):
833         (Simulator.device_number):
834         (Simulator.device_state_description):
835         (Simulator.wait_until_device_is_in_state):
836
837 2016-08-19  Alexey Proskuryakov  <ap@apple.com>
838
839         Adopt SimServiceContext in LayoutTestRelay
840         https://bugs.webkit.org/show_bug.cgi?id=161000
841         <rdar://problem/25765594>
842
843         Reviewed by Daniel Bates.
844
845         * LayoutTestRelay/LayoutTestRelay/CoreSimulatorSPI.h:
846         * LayoutTestRelay/LayoutTestRelay/main.m:
847
848 2016-08-19  Lucas Forschler  <lforschler@apple.com>
849
850         Remove Yosemite Leaks bot after http://trac.webkit.org/projects/webkit/changeset/204629
851
852         Reviewed by Kocsen Chung.
853
854         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
855         (WebKitBuildbot):
856
857 2016-08-19  Alexey Proskuryakov  <ap@apple.com>
858
859         Partial revert of r203811 - this key is not needed.
860
861         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m: (-[LTRelayController installApp]):
862
863 2016-08-19  Daniel Bates  <dabates@apple.com>
864
865         Another attempt to fix the iOS 9.3 build
866
867         Define WK_EMPTY_, WK_NOT_, and WK_NOT_YES.
868
869         * DumpRenderTree/mac/Configurations/Base.xcconfig:
870         * WebKitTestRunner/Configurations/Base.xcconfig:
871
872 2016-08-19  Lucas Forschler  <lforschler@apple.com>
873
874         Remove Yosemite Leaks bot from config.json
875         
876         Reviewed by Alexey Proskuryakov.
877
878         * BuildSlaveSupport/build.webkit.org-config/config.json:
879
880 2016-08-18  Dan Bernstein  <mitz@apple.com>
881
882         [Cocoa] API::Number needs to be wrapped by an NSNumber
883         https://bugs.webkit.org/show_bug.cgi?id=160977
884         <rdar://problem/27877735>
885
886         Reviewed by Anders Carlsson.
887
888         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
889         * TestWebKitAPI/Tests/WebKit2Cocoa/WKNSNumber.mm: Added.
890         (TestWebKitAPI::TEST):
891
892 2016-08-17  Myles C. Maxfield  <mmaxfield@apple.com>
893
894         [Cocoa] Migrate off of deprecated CoreGraphics API CGContextSelectFont() and CGContextShowTextAtPoint()
895         https://bugs.webkit.org/show_bug.cgi?id=160895
896
897         Reviewed by Dean Jackson.
898
899         Link to the existing CoreText framework.
900
901         * DumpRenderTree/PlatformWin.cmake:
902         * TestWebKitAPI/PlatformWin.cmake:
903
904 2016-08-17  Brent Fulgham  <bfulgham@apple.com>
905
906         [Win] Remove old libraries from build inputs
907         https://bugs.webkit.org/show_bug.cgi?id=160949
908
909         Reviewed by Dean Jackson.
910
911         Modify the download script to remove the old 'icuuc.lib' and
912         'icuin.lib' files for Windows builds.
913
914         * Scripts/update-webkit-auxiliary-libs:
915
916 2016-08-17  Jonathan Bedard  <jbedard@apple.com>
917
918         Extra logging for crash reason
919         https://bugs.webkit.org/show_bug.cgi?id=160943
920
921         Reviewed by Alexey Proskuryakov.
922
923         A number of tests have been erroneously marked as crashed, this should help diagnose these false crashes.
924
925         * Scripts/webkitpy/port/server_process.py:
926         (ServerProcess.write): Add extra logging to determine why a process has been marked as crashed.
927         (ServerProcess._wait_for_data_and_update_buffers_using_select): Ditto.
928         (ServerProcess.has_crashed): Ditto.
929
930 2016-08-17  Dan Bernstein  <mitz@apple.com>
931
932         [Cocoa] -[NSString isEqualToString:] returns NO for any WKNSString argument
933         https://bugs.webkit.org/show_bug.cgi?id=160938
934         <rdar://problem/27876652>
935
936         Reviewed by Anders Carlsson.
937
938         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
939         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm: Added.
940         (TestWebKitAPI::TEST):
941
942 2016-08-17  Chris Fleizach  <cfleizach@apple.com>
943
944         AX: Support abbreviations in iOS
945         https://bugs.webkit.org/show_bug.cgi?id=160907
946
947         Reviewed by Joanmarie Diggs.
948
949         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
950         (AccessibilityUIElement::stringAttributeValue):
951         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
952         (WTR::AccessibilityUIElement::stringAttributeValue):
953
954 2016-08-17  Gyuyoung Kim  <gyuyoung.kim@navercorp.com>
955
956         [EFL] Bump efl version from 1.17 to 1.18
957         https://bugs.webkit.org/show_bug.cgi?id=160899
958
959         Reviewed by Antonio Gomes.
960
961         To use efl-1.18, EFL port needs to update install dependencies as well.
962
963         * efl/install-dependencies:
964         * efl/jhbuild.modules:
965
966 2016-08-17  Per Arne Vollan  <pvollan@apple.com>
967
968         [Win] Add tests for linked fonts.
969         https://bugs.webkit.org/show_bug.cgi?id=160898
970
971         Reviewed by Brent Fulgham.
972
973         Add tests for https://trac.webkit.org/changeset/204502.
974
975         * TestWebKitAPI/PlatformWin.cmake:
976         * TestWebKitAPI/Tests/WebCore/win/LinkedFonts.cpp: Added.
977         (TestWebKitAPI::TEST):
978
979 2016-08-16  Daniel Bates  <dabates@apple.com>
980
981         prepare-ChangeLog: Extract logic from generateFunctionLists() into a function that takes a delegate object
982         https://bugs.webkit.org/show_bug.cgi?id=160924
983
984         Reviewed by Stephanie Lewis.
985
986         Towards adding unit tests for generateFunctionLists() we move its logic into actuallyGenerateFunctionLists()
987         and have actuallyGenerateFunctionLists() take a delegate object to use to query the file system and SCM.
988         We modify generateFunctionLists() to call actuallyGenerateFunctionLists(). This will make is possible to
989         test the generate function list machinery without requiring a SCM checkout by substituting a delegate
990         object that mocks out the file system and SCM operations.
991
992         * Scripts/VCSUtils.pm:
993         (parseDiffStartLine): Parses an SVN or Git start line and returns the path to the target file.
994         * Scripts/prepare-ChangeLog:
995         (generateFunctionLists): Move functionality to actually generate the function lists to actuallyGenerateFunctionLists(),
996         abstracting the logic to query the file system and SCM into functions on a delegate object that
997         we pass to it.
998         (actuallyGenerateFunctionLists): Extracted from generateFunctionLists().
999         (diffHeaderFormat): Deleted.
1000
1001 2016-08-16  Alex Christensen  <achristensen@webkit.org>
1002
1003         URLParser should parse URLs without credentials
1004         https://bugs.webkit.org/show_bug.cgi?id=160913
1005
1006         Reviewed by Brady Eidson.
1007
1008         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1009         (TestWebKitAPI::s):
1010         (TestWebKitAPI::checkURL):
1011         (TestWebKitAPI::TEST_F):
1012
1013 2016-08-16  Anders Carlsson  <andersca@apple.com>
1014
1015         Add WTF::ScopeExit
1016         https://bugs.webkit.org/show_bug.cgi?id=160908
1017
1018         Reviewed by Geoffrey Garen.
1019
1020         * TestWebKitAPI/CMakeLists.txt:
1021         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1022         * TestWebKitAPI/Tests/WTF/Scope.cpp: Added.
1023         (TestWebKitAPI::TEST):
1024
1025 2016-08-16  Aakash Jain  <aakash_jain@apple.com>
1026
1027         EWS logs file are rotated too quickly
1028         https://bugs.webkit.org/show_bug.cgi?id=160724
1029
1030         Reviewed by Daniel Bates.
1031
1032         Currently we are rotating the log file after 10 iterations of queue. If the queue
1033         doesn't have any pending patches, these iterations result in very small amount of 
1034         logs (1 KB log file). Even if the queue process some patches, logs are few KBs.
1035         This results in a lot of log files in a day. This patch ensures that we rotate the
1036         log file when its file size is greater than or equal to 100 KB.
1037
1038         * EWSTools/start-queue-mac.sh: Added check for file size before rotating log file.
1039
1040 2016-08-16  Daniel Bates  <dabates@apple.com>
1041
1042         WKSI static library should be named by major iOS revision, not individual updates
1043         https://bugs.webkit.org/show_bug.cgi?id=160727
1044         <rdar://problem/22274848>
1045
1046         Reviewed by Alexey Proskuryakov.
1047
1048         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1049         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1050         * Scripts/copy-webkitlibraries-to-product-directory:
1051         * WebKitTestRunner/Configurations/Base.xcconfig:
1052         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1053
1054 2016-08-16  Simon Fraser  <simon.fraser@apple.com>
1055
1056         Make it possible to test iOS select elements, and add iPhone and iPad tests for them
1057         https://bugs.webkit.org/show_bug.cgi?id=160909
1058
1059         Reviewed by Enrica Casucci.
1060         
1061         Add functions to UIScriptController to dismiss the form accessory view for iOS,
1062         and to programmatically pick a row from a <select> picker.
1063
1064         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
1065         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
1066         (WTR::UIScriptController::dismissFormAccessoryView):
1067         (WTR::UIScriptController::selectFormAccessoryPickerRow):
1068         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
1069         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1070         (WTR::UIScriptController::dismissFormAccessoryView):
1071         (WTR::UIScriptController::selectFormAccessoryPickerRow):
1072
1073 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
1074
1075         [iOS] Add iPad viewport and form tests, and revert the iPad-testing part of r202132
1076         https://bugs.webkit.org/show_bug.cgi?id=160878
1077
1078         Reviewed by Tim Horton.
1079         
1080         Remove testing-specific "forceIPadStyleZoomOnInputFocus" behavior added in r202132
1081         now that we have the ability to run tests in the iPad simulator.
1082
1083         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
1084         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
1085         (WTR::UIScriptController::forceIPadStyleZoomOnInputFocus): Deleted.
1086         (WTR::UIScriptController::setForceIPadStyleZoomOnInputFocus): Deleted.
1087         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
1088         * WebKitTestRunner/ios/TestControllerIOS.mm:
1089         (WTR::TestController::platformResetStateToConsistentValues): Deleted.
1090         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1091         (WTR::UIScriptController::forceIPadStyleZoomOnInputFocus): Deleted.
1092         (WTR::UIScriptController::setForceIPadStyleZoomOnInputFocus): Deleted.
1093
1094 2016-08-15  Anders Carlsson  <andersca@apple.com>
1095
1096         Add an address-of operator to RetainPtr
1097         https://bugs.webkit.org/show_bug.cgi?id=160879
1098
1099         Reviewed by Tim Horton.
1100
1101         Test HashMap and HashSet with an object whose operator& is deleted.
1102
1103         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1104         Sort the Xcode project.
1105
1106         * TestWebKitAPI/Tests/WTF/DeletedAddressOfOperator.h: Added.
1107         (DeletedAddressOfOperator::DeletedAddressOfOperator):
1108         (DeletedAddressOfOperator::value):
1109         (DeletedAddressOfOperator::operator==):
1110         (WTF::HashTraits<DeletedAddressOfOperator>::constructDeletedValue):
1111         (WTF::HashTraits<DeletedAddressOfOperator>::isDeletedValue):
1112         (WTF::DefaultHash<DeletedAddressOfOperator>::Hash::hash):
1113         (WTF::DefaultHash<DeletedAddressOfOperator>::Hash::equal):
1114         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
1115         (TestWebKitAPI::TEST):
1116         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
1117         (TestWebKitAPI::TEST):
1118
1119 2016-08-16  Jonathan Bedard  <jbedard@apple.com>
1120
1121         False crashes in fast/text/emoji-gender-* tests
1122         https://bugs.webkit.org/show_bug.cgi?id=160779
1123
1124         Reviewed by Alexey Proskuryakov.
1125
1126         Fix from <rdar://problem/27786762>, where timed out tests falsely report as crashed.
1127
1128         * Scripts/webkitpy/port/driver.py:
1129         (Driver._check_for_driver_crash_or_unresponsiveness): Change call to ‘write’ to disable crash flag.
1130         * Scripts/webkitpy/port/driver_unittest.py: Added 3 variable to test version of ‘write.’
1131         * Scripts/webkitpy/port/server_process.py:
1132         (ServerProcess.write): Allow caller to disable crash flag on exception.
1133
1134 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
1135
1136         webkitpy error in TestRunResults.merge()
1137         https://bugs.webkit.org/show_bug.cgi?id=160882
1138
1139         Reviewed by Daniel Bates.
1140         
1141         The argument to TestRunResults.merge() can be None if there are no device-specifc
1142         initial results or retry results in Manager.run(), so just return early in that case.
1143
1144         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1145         (TestRunResults.merge):
1146
1147 2016-08-15  Sam Weinig  <sam@webkit.org>
1148
1149         Speed up compile times by not including wtf/Variant.h so much
1150         https://bugs.webkit.org/show_bug.cgi?id=160847
1151
1152         Reviewed by Alex Christensen and Saam Barati.
1153
1154         * TestWebKitAPI/Tests/WTF/Variant.cpp:
1155         (TestWebKitAPI::TEST):
1156         Explicitly use std::experimental::variant.
1157
1158 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
1159
1160         Allow a port to run tests with a custom device setup
1161         https://bugs.webkit.org/show_bug.cgi?id=160833
1162
1163         Reviewed by Daniel Bates.
1164
1165         These changes allow the IOSSimulator port to run tests in iPad mode.
1166
1167         This is made possible by allowing a platform to define CUSTOM_DEVICE_CLASSES,
1168         in this case 'ipad'. When specified, any test in a directory with a suffix that matches
1169         a custom device will be collected into a set, and run in that device's environment after
1170         the other tests have run.
1171
1172         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1173         (Manager._custom_device_for_test): If the test contains a directory matching a
1174         custom device suffix, return that custom device.
1175         (Manager._set_up_run): Push the custom device class, if any, into options so
1176         that the Worker can get to it.
1177         (Manager.run): Go through the list of tests, and break it down into device-generic
1178         tests, and tests for each device class. _run_test_subset is then called for
1179         each collection of tests, and the results merged.
1180         (Manager._run_test_subset): Some lines unwrapped.
1181         (Manager._end_test_run):
1182         (Manager._run_tests):
1183         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1184         (SingleTestRunner.__init__): Unwrapped a line.
1185         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1186         (TestRunResults.merge): Add this function to merge TestRunResults
1187         * Scripts/webkitpy/layout_tests/views/printing.py:
1188         (Printer.print_workers_and_shards): Print the custom device, if any.
1189         * Scripts/webkitpy/port/base.py:
1190         (Port): Base port has empty array of custom devices.
1191         (Port.setup_test_run): Add device_class argument.
1192         * Scripts/webkitpy/port/driver.py:
1193         (DriverInput.__repr__):
1194         (Driver.check_driver.implementation):
1195         * Scripts/webkitpy/port/efl.py:
1196         (EflPort.setup_test_run):
1197         * Scripts/webkitpy/port/gtk.py:
1198         (GtkPort.setup_test_run):
1199         * Scripts/webkitpy/port/ios.py:
1200         (IOSSimulatorPort): Add CUSTOM_DEVICE_CLASSES for ipad.
1201         (IOSSimulatorPort.__init__):
1202         (IOSSimulatorPort.simulator_device_type): Use a device name from the DEVICE_CLASS_MAP
1203         based on the custom device class.
1204         (IOSSimulatorPort._set_device_class):
1205         (IOSSimulatorPort._create_simulators): Factor some code into this function.
1206         (IOSSimulatorPort.setup_test_run):
1207         (IOSSimulatorPort.testing_device):
1208         (IOSSimulatorPort.reset_preferences): This used to create the simulator apps, but that
1209         seemed wrong for this function. That was moved to setup_test_run().
1210         (IOSSimulatorPort.check_sys_deps): This function used to create testing devices,
1211         but this happened too early, before we knew which kind of devices to create. Devices
1212         are now created in setup_test_run().
1213         * Scripts/webkitpy/port/win.py:
1214         (WinPort.setup_test_run):
1215
1216 2016-08-15  Daniel Bates  <dabates@apple.com>
1217
1218         Cannot build WebKit for iOS device using Xcode 7.3/iOS 9.3 public SDK due to missing
1219         private frameworks and libraries
1220         https://bugs.webkit.org/show_bug.cgi?id=155931
1221         <rdar://problem/25807989>
1222
1223         Reviewed by Dan Bernstein.
1224
1225         Add directory WebKitLibraries/WebKitPrivateFrameworkStubs/iOS/X to the framework search path
1226         where X is the major version of the active iOS SDK.
1227
1228         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1229         * WebKitTestRunner/Configurations/Base.xcconfig:
1230
1231 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
1232
1233         Add a setting and preferences to enable visual viewport mode
1234         https://bugs.webkit.org/show_bug.cgi?id=160843
1235
1236         Reviewed by Sam Weinig.
1237         
1238         Pref and a menu item to toggle visualViewportEnabled for WebKits 1 and 2.
1239
1240         * MiniBrowser/mac/SettingsController.h:
1241         * MiniBrowser/mac/SettingsController.m:
1242         (-[SettingsController _populateMenu]):
1243         (-[SettingsController validateMenuItem:]):
1244         (-[SettingsController visualViewportEnabled]):
1245         (-[SettingsController toggleVisualViewportEnabled:]):
1246         * MiniBrowser/mac/WK1BrowserWindowController.m:
1247         (-[WK1BrowserWindowController didChangeSettings]):
1248         * MiniBrowser/mac/WK2BrowserWindowController.m:
1249         (-[WK2BrowserWindowController didChangeSettings]):
1250
1251 2016-08-15  Konstantin Tokarev  <annulen@yandex.ru>
1252
1253         Allow using make-dist with non-GTK ports
1254         https://bugs.webkit.org/show_bug.cgi?id=160842
1255
1256         Reviewed by Michael Catanzaro.
1257
1258         This patch adds support for setting base name of tarball and argument
1259         passed to cmake's -DPORT= via command line arguments.
1260
1261         * gtk/make-dist.py:
1262         (Distcheck.configure):
1263         (Distcheck.check):
1264         (get_tarball_root_and_output_filename_from_arguments):
1265
1266 2016-08-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1267
1268         [GTK] Install script lacks gstreamer related dependencies
1269         https://bugs.webkit.org/show_bug.cgi?id=160814
1270
1271         Reviewed by Carlos Garcia Campos.
1272
1273         * gtk/install-dependencies: Fedora case had already listed this dependencies,
1274         but both Arch and Debian/Ubuntu were missing them.
1275
1276 2016-08-13  Konstantin Tokarev  <annulen@yandex.ru>
1277
1278         make-dist.py should not allow unknown rules in manifest
1279         https://bugs.webkit.org/show_bug.cgi?id=160841
1280
1281         Reviewed by Carlos Garcia Campos.
1282
1283         * gtk/make-dist.py:
1284         (Manifest.process_line):
1285
1286 2016-08-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1287
1288         [EFL][GTK] Install script not working on Debian 9 (testing) and Ubuntu 16.10
1289         https://bugs.webkit.org/show_bug.cgi?id=160809
1290
1291         Reviewed by Carlos Garcia Campos.
1292
1293         * efl/install-dependencies: Factorize the previous logic for handling the php5/7
1294         case, and use it also for the new package names of libpng and libgeoclue.
1295         * gtk/install-dependencies: Ditto.
1296
1297 2016-08-12  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1298
1299         Skip to check directories existence in build-webkit
1300         https://bugs.webkit.org/show_bug.cgi?id=160691
1301
1302         Reviewed by Alex Christensen.
1303
1304         CMake checks if directories are there itself. So CMake ports
1305         don't need to check it in the build-webkit script.
1306
1307         * Scripts/build-webkit:
1308         * Scripts/webkitdirs.pm:
1309         (determineSourceDir):
1310         (isCMakeBuild):
1311
1312 2016-08-12  Alex Christensen  <achristensen@webkit.org>
1313
1314         Make URLParser work with URLs missing URL parts
1315         https://bugs.webkit.org/show_bug.cgi?id=160824
1316
1317         Reviewed by Brady Eidson.
1318
1319         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1320         (TestWebKitAPI::s):
1321         (TestWebKitAPI::checkURL):
1322         (TestWebKitAPI::TEST_F):
1323         (TestWebKitAPI::eq): Deleted.
1324
1325 2016-08-12  John Wilander  <wilander@apple.com>
1326
1327         Add HashCountedSet API tests to TestWTFLibrary target
1328         https://bugs.webkit.org/show_bug.cgi?id=160815
1329
1330         Reviewed by Alex Christensen.
1331
1332         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1333             Added HashCountedSet.cpp and sorted the file reference section
1334             according to UNIX sort.
1335
1336 2016-08-12  Ryosuke Niwa  <rniwa@webkit.org>
1337
1338         run-benchmark should run JetStream 1.1 instead of 1.0.1
1339         https://bugs.webkit.org/show_bug.cgi?id=160816
1340
1341         Reviewed by Filip Pizlo.
1342
1343         Use the latest JetStream 1.1 in run-benchmark.
1344
1345         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
1346         (BenchmarkBuilder.__exit__):
1347         * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Updated to apply against 1.1 directory.
1348         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Updated to use r190897, which is the last
1349         change to JetStream directory.
1350
1351 2016-08-12  Alex Christensen  <achristensen@webkit.org>
1352
1353         Initial URLParser implementation
1354         https://bugs.webkit.org/show_bug.cgi?id=160811
1355
1356         Reviewed by Brady Eidson.
1357
1358         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1359         (TestWebKitAPI::eq):
1360         (TestWebKitAPI::checkURL):
1361         (TestWebKitAPI::TEST_F):
1362
1363 2016-08-12  Brady Eidson  <beidson@apple.com>
1364
1365         Fix the 32-bit Mac build after:
1366         Add WK2 ExperimentalFeature support to MiniBrowser
1367         https://bugs.webkit.org/show_bug.cgi?id=160788
1368
1369         Unreviewed.
1370
1371         Sprinkle "#if WK_API_ENABLED"s liberally.
1372         
1373         * MiniBrowser/mac/AppDelegate.m:
1374         (defaultConfiguration):
1375         * MiniBrowser/mac/SettingsController.m:
1376         (-[SettingsController _populateMenu]):
1377         (-[SettingsController validateMenuItem:]):
1378
1379 2016-08-12  Philippe Normand  <pnormand@igalia.com>
1380
1381         [GStreamer][OWR] Video rendering fixes
1382         https://bugs.webkit.org/show_bug.cgi?id=160764
1383
1384         Reviewed by Xabier Rodriguez-Calvar.
1385
1386         * gtk/jhbuild.modules: Bump to current OpenWebRTC master.
1387
1388 2016-08-12  Per Arne Vollan  <pvollan@apple.com>
1389
1390         Add missing return statement in convertFast function added in r204376.
1391
1392         Unreviewed.
1393
1394         * Scripts/webkitpy/common/system/path.py:
1395         (_CygPath.convertFast):
1396
1397 2016-08-11  Brady Eidson  <beidson@apple.com>
1398
1399         Add WK2 ExperimentalFeature support to MiniBrowser.
1400         https://bugs.webkit.org/show_bug.cgi?id=160788
1401
1402         Reviewed by Alex Christensen.
1403
1404         * MiniBrowser/mac/AppDelegate.h:
1405         * MiniBrowser/mac/AppDelegate.m:
1406         (defaultConfiguration):
1407         (defaultPreferences):
1408         
1409         * MiniBrowser/mac/SettingsController.m:
1410         (-[SettingsController _populateMenu]):
1411         (-[SettingsController validateMenuItem:]):
1412         (-[SettingsController toggleExperimentalFeature:]):
1413
1414 2016-08-11  Aakash Jain  <aakash_jain@apple.com>
1415
1416         Keep EWS logs for longer
1417         https://bugs.webkit.org/show_bug.cgi?id=160776
1418
1419         Reviewed by Daniel Bates.
1420
1421         * EWSTools/start-queue-mac.sh: Keep logs for 30 days instead of 14 days.
1422
1423 2016-08-11  Simon Fraser  <simon.fraser@apple.com>
1424
1425         iOS DRT/WTR project cleanup
1426         https://bugs.webkit.org/show_bug.cgi?id=160778
1427
1428         Reviewed by Tim Horton.
1429
1430         Move TARGETED_DEVICE_FAMILY from the project to an xcconfig file.
1431
1432         Remove AppDelegate.* which were unused.
1433
1434         Exclude ios/Launch.storyboard on more platforms.
1435
1436         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1437         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
1438         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
1439         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1440         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.h: Removed.
1441         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.m: Removed.
1442         (-[AppDelegate application:didFinishLaunchingWithOptions:]): Deleted.
1443
1444 2016-08-11  Alex Christensen  <achristensen@webkit.org>
1445
1446         Fix Yosemite bots' cookie accept policies after r204365.
1447         https://bugs.webkit.org/show_bug.cgi?id=160758
1448
1449         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm:
1450         (TEST):
1451         This makes the test fully clean up after itself.
1452
1453 2016-08-11  Alex Christensen  <achristensen@webkit.org>
1454
1455         Fix Yosemite bots' cookie accept policies after r204365.
1456         https://bugs.webkit.org/show_bug.cgi?id=160758
1457
1458         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm:
1459         (TEST):
1460         I didn't restore the cookieAcceptPolicy of the sharedHTTPCookieStorage after changing it with this API test.
1461         On Yosemite, this is changing the cookieAcceptPolicy that DumpRenderTree uses.
1462         On more recent Cocoa platforms, it is only changing the cookieAcceptPolicy that TestWebKitAPI uses, which isn't
1463         causing any problems because there are no other API tests that do anything with cookies.
1464         My solution will be to restore the original cookieAcceptPolicy after running this API test to clean up,
1465         but first I am committing this patch setting the cookieAcceptPolicy to NSHTTPCookieAcceptPolicyOnlyFromMainDocumentDomain
1466         to reset any bots that have run tests since r204365.  I will commit a followup that sets it to originalCookieAcceptPolicy.
1467
1468 2016-08-11  Aakash Jain  <aakash_jain@apple.com>
1469
1470         EWS should check if the patch is still valid before executing every major step
1471         https://bugs.webkit.org/show_bug.cgi?id=160739
1472         rdar://problem/27768813
1473
1474         Reviewed by Alexey Proskuryakov.
1475
1476         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1477         (CommitQueueTask.run): validate method is now executed in base class.
1478         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
1479         (EarlyWarningSystemTask.run): validate method is now executed in base class.
1480         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
1481         (StyleQueueTask.validate): Raise an PatchIsNotValid exception instead of returning False.
1482         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1483         (PatchAnalysisTask._run_command): validate the patch before executing any command. This is to ensure
1484         that we do not waste time on any patch which has become invalid (e.g.: obsolete, r-).
1485         * Scripts/webkitpy/tool/commands/perfalizer.py:
1486         (PerfalizerTask.validate): Added.
1487         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1488         (test_manual_reject_during_processing): Updated test case.
1489
1490 2016-08-11  Alex Christensen  <achristensen@webkit.org>
1491
1492         Add URLParser stub
1493         https://bugs.webkit.org/show_bug.cgi?id=160770
1494
1495         Reviewed by Sam Weinig.
1496
1497         * TestWebKitAPI/PlatformGTK.cmake:
1498         * TestWebKitAPI/PlatformWin.cmake:
1499         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1500         * TestWebKitAPI/Tests/WebCore/URLParser.cpp: Added.
1501         (TestWebKitAPI::TEST_F):
1502
1503 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
1504
1505         [iOS DRT] Allow DRT to be iPad-sized in the iPad simulator
1506         https://bugs.webkit.org/show_bug.cgi?id=160761
1507
1508         Reviewed by Tim Horton.
1509
1510         Give iOS DRT a Launch storyboard.
1511
1512         Have it use a UIViewController so future forms testing works correctly.
1513
1514         Add TARGETED_DEVICE_FAMILY = "1,2" to the build settings for the .app, so that it
1515         can run in iPad mode.
1516
1517         Remove empty InfoPlist.strings files.
1518
1519         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1520         * DumpRenderTree/ios/Info.plist:
1521         * DumpRenderTree/ios/Launch.storyboard: Added.
1522         * DumpRenderTree/mac/DumpRenderTree.mm:
1523         (createWebViewAndOffscreenWindow):
1524         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1525         * WebKitTestRunner/WebKitTestRunnerApp/en.lproj/InfoPlist.strings: Removed.
1526         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1527         (WTR::PlatformWebView::PlatformWebView): Drive-by leak fix.
1528
1529 2016-08-11  Per Arne Vollan  <pvollan@apple.com>
1530
1531         [Win] Unable to reliably run tests in parallel
1532         https://bugs.webkit.org/show_bug.cgi?id=140914
1533
1534         Reviewed by Brent Fulgham.
1535
1536         The cygpath utility function can fail badly when running with multiple DumpRenderTree
1537         processes. We can use string replacement to convert the Cygwin path to a Windows path
1538         instead.
1539
1540         * Scripts/webkitpy/common/system/path.py:
1541         (cygpathFast):
1542         * Scripts/webkitpy/port/driver.py:
1543         (Driver._command_from_driver_input):
1544
1545 2016-08-10  Alex Christensen  <achristensen@webkit.org>
1546
1547         Fix crash when changing cookie accept policy after r204327
1548         https://bugs.webkit.org/show_bug.cgi?id=160758
1549
1550         Reviewed by Simon Fraser.
1551
1552         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1553         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm: Added.
1554         (-[CookieAcceptPolicyMessageHandler userContentController:didReceiveScriptMessage:]):
1555         (TEST):
1556         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieMessage.html: Added.
1557
1558 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
1559
1560         [iOS WK2] Have WebKitTestRunnerApp.app use a UIViewController, and fix to avoid the status bar
1561         https://bugs.webkit.org/show_bug.cgi?id=160757
1562
1563         Reviewed by Tim Horton.
1564
1565         When programmatically creating the test UIWindow, make a root UIViewController and parent
1566         the WKWebView in its view. This makes the app more like a normal UIKit application.
1567         
1568         Move the WKWebView down 20px to avoid the status bar.
1569         
1570         Give the UIWindow a gray background so it's obvious where the window and view positioned.
1571
1572         Sorted the project file. Removed the link to UIKit which showed red, and wasn't necessary.
1573         
1574         Remove duplicate references to Launch.storyboard.
1575
1576         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1577         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.h: Add license.
1578         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.m: Add license.
1579         (-[AppDelegate applicationWillResignActive:]): Deleted.
1580         (-[AppDelegate applicationDidEnterBackground:]): Deleted.
1581         (-[AppDelegate applicationWillEnterForeground:]): Deleted.
1582         (-[AppDelegate applicationDidBecomeActive:]): Deleted.
1583         (-[AppDelegate applicationWillTerminate:]): Deleted.
1584         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1585         (WTR::viewRectForWindowRect):
1586         (WTR::PlatformWebView::PlatformWebView):
1587         (WTR::PlatformWebView::setWindowFrame):
1588
1589 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
1590
1591         [iOS WK2] Use the simulated device's screen size, rather than a harcoded size
1592         https://bugs.webkit.org/show_bug.cgi?id=160748
1593
1594         Reviewed by Tim Horton.
1595         
1596         Use the main UIScreen's bounds for the window size if we're using a flexible viewport. This
1597         opens the door for tests using other device sizes.
1598
1599         * WebKitTestRunner/ios/TestControllerIOS.mm:
1600         (WTR::TestController::platformConfigureViewForTest):
1601
1602 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
1603
1604         Sort the feature flags in the FEATURE_DEFINES lines
1605         https://bugs.webkit.org/show_bug.cgi?id=160742
1606
1607         Reviewed by Anders Carlsson.
1608         
1609         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1610
1611 2016-08-09  Simon Fraser  <simon.fraser@apple.com>
1612
1613         Logging and other minor improvements to iOS webkitpy
1614         https://bugs.webkit.org/show_bug.cgi?id=160722
1615
1616         Reviewed by Dan Bates.
1617
1618         Fix --debug-rwt-logging to log all the calls to simctl as well as device state information,
1619         to make it easier to debug launching issues.
1620
1621         Have reset_preferences() reset the device, rather than just nuking the data
1622         directory (which broke some versions of the simulator).
1623
1624         Make the Simulator.app launch in the background with open -g.
1625
1626         Wait for the simulator device to be in a known state in some more places.
1627
1628         * Scripts/webkitpy/port/ios.py:
1629         (IOSSimulatorPort.setup_test_run):
1630         (IOSSimulatorPort._quit_ios_simulator):
1631         (IOSSimulatorPort.clean_up_test_run):
1632         (IOSSimulatorPort.setup_environ_for_server):
1633         (IOSSimulatorPort.reset_preferences):
1634         * Scripts/webkitpy/xcode/simulator.py:
1635         (Device.create):
1636         (Device.delete):
1637         (Device):
1638         (Device.reset):
1639         (Simulator.wait_until_device_is_booted):
1640         (Simulator.wait_until_device_is_in_state):
1641         (Simulator):
1642         (Simulator.delete_device):
1643         (Simulator.reset_device):
1644         (Simulator.lookup_or_create_device):
1645
1646 2016-08-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1647
1648         [GTK][EFL] ALSA_CARD environment variable is not passed for layout tests.
1649         https://bugs.webkit.org/show_bug.cgi?id=160697
1650
1651         Reviewed by Antonio Gomes.
1652
1653         * Scripts/webkitpy/port/base.py:
1654         (Port.to.setup_environ_for_server): Add ALSA_CARD and sort the Linux
1655         list of environment variables to copy.
1656
1657 2016-08-09  George Ruan  <gruan@apple.com>
1658
1659         Implement functionality of media capture on iOS
1660         https://bugs.webkit.org/show_bug.cgi?id=158945
1661         <rdar://problem/26893343>
1662
1663         Reviewed by Tim Horton.
1664
1665         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Enable Media
1666         Capture feature on iOS.
1667
1668 2016-08-09  Saam Barati  <sbarati@apple.com>
1669
1670         Parser<LexerType>::parseFunctionInfo() has the wrong info about captured vars when a function is not cached.
1671         https://bugs.webkit.org/show_bug.cgi?id=160671
1672         <rdar://problem/27756112>
1673
1674         Reviewed by Mark Lam.
1675
1676         * Scripts/run-jsc-stress-tests:
1677
1678 2016-08-09  Alexey Proskuryakov  <ap@apple.com>
1679
1680         Make directory reading code in iOSSimulatorDevices() more strict
1681         https://bugs.webkit.org/show_bug.cgi?id=160702
1682
1683         Reviewed by Tim Horton.
1684
1685         * Scripts/webkitdirs.pm:
1686         (iOSSimulatorDevices):
1687
1688 2016-08-06  Sam Weinig  <sam@webkit.org>
1689
1690         Replace NodeOrString with std::variant<RefPtr<Node>, String>
1691         https://bugs.webkit.org/show_bug.cgi?id=160638
1692
1693         Reviewed by Anders Carlsson.
1694
1695         * TestWebKitAPI/CMakeLists.txt:
1696         * TestWebKitAPI/Tests/WTF/Variant.cpp:
1697         Add additional tests for the initial state of std::variant and using
1698         makeVisitor for visiting.
1699
1700 2016-08-09  Aakash Jain  <aakash_jain@apple.com>
1701
1702         EWS logging should ensure the logging to file is stopped on queue termination
1703         https://bugs.webkit.org/show_bug.cgi?id=160698
1704         rdar://problem/24464570
1705
1706         Reviewed by Daniel Bates.
1707
1708         * Scripts/webkitpy/tool/bot/queueengine.py:
1709         (QueueEngine._stopping): Stop logging to file on queue termination.
1710         (QueueEngine._begin_logging): Configure the Python logger to log to file.
1711         * Scripts/webkitpy/common/system/logutils.py:
1712         (configure_logger_to_log_to_file): Return the handler so as to enable caller to remove it later.
1713         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
1714         (QueueEngineTest._run_engine): Removed extra newline character to improve log readability.
1715         * Scripts/webkitpy/tool/commands/queues.py:
1716         (AbstractQueue._log_directory): Reverting to os.path.join as we don't have host object.
1717         (AbstractQueue.queue_log_path): Same.
1718         (AbstractQueue.begin_work_queue): Removed logging initialization, it is now being done in QueueEngine.
1719         (AbstractQueue.__init__): Removed host parameter, not required anymore, it was required by logging initialization
1720         which moved to QueueEngine now.
1721         (PatchProcessingQueue.__init__): Same.
1722         (CommitQueue.__init__): Same.
1723         (AbstractReviewQueue.__init__): Same.
1724         (StyleQueue.__init__): Same.
1725         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1726         (TestCommitQueue): Removed host parameter.
1727         (TestCommitQueue.__init__): Same.
1728         (AbstractPatchQueueTest.test_next_patch): Same.
1729         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Same.
1730         (test_commit_queue_failure): Same.
1731         (mock_run_webkit_patch):
1732         (MockCommitQueueTask.results_from_patch_test_run): Same.
1733         (test_rollout_lands): Same.
1734         (test_non_valid_patch): Same.
1735         (test_auto_retry): Same.
1736         (test_style_queue_with_watch_list_exception): Same.
1737         (TestQueue.__init__): Deleted.
1738         (TestReviewQueue.__init__): Deleted.
1739         (TestFeederQueue.__init__): Deleted.
1740
1741 2016-08-09  Konstantin Tokarev  <annulen@yandex.ru>
1742
1743         webkit-gtk tarball fails to build due to missing files
1744         https://bugs.webkit.org/show_bug.cgi?id=160684
1745
1746         Reviewed by Alex Christensen.
1747
1748         * gtk/manifest.txt.in: Added back spi directories.
1749
1750 2016-08-09  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1751
1752         [GTK] Build the jhbuild with -O2 optimization level by default
1753         https://bugs.webkit.org/show_bug.cgi?id=160544
1754
1755         Reviewed by Michael Catanzaro.
1756
1757         * gtk/jhbuildrc: Pass -O2 when building the JHBuild, as also -g1
1758         which don't increases the required disk space significatively and
1759         provides better debug information than no passing it.
1760
1761 2016-08-09  Csaba Osztrogonác  <ossy@webkit.org>
1762
1763         Allow more --cmakeargs option in build-jsc and build-webkit
1764         https://bugs.webkit.org/show_bug.cgi?id=160340
1765
1766         Reviewed by Michael Catanzaro.
1767
1768         * Scripts/build-jsc:
1769         * Scripts/build-webkit:
1770
1771 2016-08-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1772
1773         Do not check if WebKitLibraries folder exists on EFL and GTK
1774         https://bugs.webkit.org/show_bug.cgi?id=160659
1775
1776         Reviewed by Csaba Osztrogonác.
1777
1778         Though WebKitLibraries is only needed by mac and win ports,
1779         EFL and GTK ports have checked whether it exists.
1780
1781         * Scripts/build-webkit:
1782
1783 2016-08-08  Aakash Jain  <aakash_jain@apple.com>
1784
1785         Some EWS console logs doesn't go to log file
1786         https://bugs.webkit.org/show_bug.cgi?id=160585
1787         rdar://problem/24464570
1788
1789         Reviewed by Daniel Bates.
1790
1791         * Scripts/webkitpy/common/system/logutils.py:
1792         (FileSystemHandler._open): Ensure that we open logfile in append mode in order to avoid
1793         any possible overwriting.
1794         * Scripts/webkitpy/common/system/filesystem.py:
1795         (FileSystem.open_text_file_for_writing): Add should_append parameter to append to file.
1796         * Scripts/webkitpy/common/system/filesystem_mock.py:
1797         (MockFileSystem.open_text_file_for_writing): Same.
1798         * Scripts/webkitpy/common/system/filesystem_unittest.py:
1799         (RealFileSystemTest.test_read_and_write_text_file): Removed unused variable 'hex_equivalent'.
1800         (RealFileSystemTest.test_append_to_text_file): Added new unit test for testing append functionality.
1801         * Scripts/webkitpy/tool/commands/queues.py:
1802         (AbstractQueue.begin_work_queue): Configure the logger for overall webkitpy to log to file.
1803         This will ensure that all the sub-modules inside webkitpy will log to file.
1804
1805 2016-08-08  Simon Fraser  <simon.fraser@apple.com>
1806
1807         Have the iOS platform interit from the Apple platform in webkitpy
1808         https://bugs.webkit.org/show_bug.cgi?id=160672
1809
1810         Reviewed by Dan Bates.
1811         
1812         The IOSSimulatorPort used to inherit from Port, rather than ApplePort.
1813         Fix this, and move duplicated code from IOSSimulatorPort and MacPort into
1814         ApplePort.
1815         
1816         Since WinPort also inherits from ApplePort, it needs to stub out some things
1817         that are unavailable on Windows (leaks, sampling).
1818         
1819         Some SnowLeopard-related code and the associated test were removed.
1820
1821         * Scripts/webkitpy/port/apple.py:
1822         (ApplePort.__init__):
1823         (ApplePort):
1824         (ApplePort._make_leak_detector):
1825         (ApplePort.default_timeout_ms):
1826         (ApplePort.supports_per_test_timeout):
1827         (ApplePort.should_retry_crashes):
1828         (ApplePort._generate_all_test_configurations):
1829         (ApplePort.check_for_leaks):
1830         (ApplePort.print_leaks_summary):
1831         (ApplePort._path_to_webcore_library):
1832         (ApplePort.show_results_html_file):
1833         (ApplePort._merge_crash_logs):
1834         (ApplePort._look_for_all_crash_logs_in_log_dir):
1835         (ApplePort._get_crash_log):
1836         (ApplePort.look_for_new_crash_logs):
1837         (ApplePort.sample_process):
1838         (ApplePort.sample_file_path):
1839         (ApplePort.look_for_new_samples):
1840         (ApplePort._path_to_helper):
1841         (ApplePort.determine_full_port_name): Deleted.
1842         * Scripts/webkitpy/port/ios.py:
1843         (IOSSimulatorPort):
1844         (IOSSimulatorPort.__init__):
1845         (IOSSimulatorPort.default_timeout_ms): Deleted.
1846         (IOSSimulatorPort.supports_per_test_timeout): Deleted.
1847         (IOSSimulatorPort.should_retry_crashes): Deleted.
1848         (IOSSimulatorPort.check_for_leaks): Deleted.
1849         (IOSSimulatorPort.print_leaks_summary): Deleted.
1850         (IOSSimulatorPort._path_to_webcore_library): Deleted.
1851         (IOSSimulatorPort.show_results_html_file): Deleted.
1852         (IOSSimulatorPort.sample_file_path): Deleted.
1853         (IOSSimulatorPort._merge_crash_logs): Deleted.
1854         (IOSSimulatorPort._look_for_all_crash_logs_in_log_dir): Deleted.
1855         (IOSSimulatorPort.look_for_new_crash_logs): Deleted.
1856         (IOSSimulatorPort.look_for_new_samples): Deleted.
1857         (IOSSimulatorPort.sample_process): Deleted.
1858         (IOSSimulatorPort._path_to_helper): Deleted.
1859         (IOSSimulatorPort.make_command): Deleted.
1860         * Scripts/webkitpy/port/mac.py:
1861         (MacPort.__init__):
1862         (MacPort.make_command):
1863         (MacPort._build_java_test_support):
1864         (MacPort): Deleted.
1865         (MacPort.default_timeout_ms): Deleted.
1866         (MacPort.supports_per_test_timeout): Deleted.
1867         (MacPort.should_retry_crashes): Deleted.
1868         (MacPort.default_child_processes): Deleted.
1869         (MacPort.check_for_leaks): Deleted.
1870         (MacPort.print_leaks_summary): Deleted.
1871         (MacPort._path_to_webcore_library): Deleted.
1872         (MacPort.show_results_html_file): Deleted.
1873         (MacPort.sample_file_path): Deleted.
1874         (MacPort._merge_crash_logs): Deleted.
1875         (MacPort._look_for_all_crash_logs_in_log_dir): Deleted.
1876         (MacPort.look_for_new_crash_logs): Deleted.
1877         (MacPort.look_for_new_samples): Deleted.
1878         (MacPort.sample_process): Deleted.
1879         (MacPort._path_to_helper): Deleted.
1880         * Scripts/webkitpy/port/mac_unittest.py:
1881         (MacTest.test_default_child_processes): Deleted.
1882         * Scripts/webkitpy/port/win.py:
1883         (WinPort.look_for_new_samples):
1884         (WinPort):
1885         (WinPort.sample_process):
1886         (WinPort._make_leak_detector):
1887         (WinPort.check_for_leaks):
1888         (WinPort.print_leaks_summary):
1889         (WinPort._path_to_webcore_library):
1890
1891 2016-08-08  Matt Baker  <mattbaker@apple.com>
1892
1893         Unreviewed: moved myself to the reviewers list.
1894
1895         * Scripts/webkitpy/common/config/contributors.json:
1896
1897 2016-08-08  Chris Dumez  <cdumez@apple.com>
1898
1899         Update API tests in mac/SetDocumentURI.mm after r204247
1900         https://bugs.webkit.org/show_bug.cgi?id=160660
1901
1902         Reviewed by Alex Christensen.
1903
1904         * TestWebKitAPI/Tests/mac/SetDocumentURI.mm:
1905         (TestWebKitAPI::TEST):
1906
1907 2016-08-08  Jonathan Bedard  <jbedard@apple.com>
1908
1909         run-webkit-tests should trigger a spindump when WebContent process is unresponsive
1910         https://bugs.webkit.org/show_bug.cgi?id=159827
1911
1912         Reviewed by Daniel Bates.
1913
1914         This change was spurred by a process hang which occurred between tests and did
1915         not produce a meaningful crashlog.
1916
1917         * Scripts/webkitpy/port/driver.py:
1918         (Driver._check_for_driver_crash_or_unresponsiveness): Notify test controller when finished through stdin.
1919
1920          * Scripts/webkitpy/port/ios.py:
1921         (IOSSimulatorPort):
1922         (IOSSimulatorPort.sample_process): Attempt spindump, but use sample if spindump fails.
1923         * Scripts/webkitpy/port/mac.py:
1924         (MacPort):
1925         (MacPort.sample_process): Attempt spindump, but use sample if spindump fails.
1926
1927         * Scripts/webkitpy/port/mac_unittest.py: Changed expected values to match spindump calls, added specific spindump test.
1928         * Scripts/webkitpy/port/driver_unittest.py: Added dummy write function.
1929
1930         * WebKitTestRunner/TestController.h:
1931         (WTR::TestController::usingServerMode): Added accessor for m_usingServerMode.
1932         * WebKitTestRunner/TestInvocation.cpp:
1933         (WTR::TestInvocation::dumpWebProcessUnresponsiveness): Wait for stdin before continuing when in server mode.
1934
1935 2016-08-07  Dan Bernstein  <mitz@apple.com>
1936
1937         [Cocoa] Reply block leaks if the remote object doesn’t call it
1938         https://bugs.webkit.org/show_bug.cgi?id=160642
1939
1940         Reviewed by Sam Weinig.
1941
1942         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h: Declared a new method.
1943         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
1944         (TEST): Added a test case that checks that the reply block is released even when it’s not
1945           called.
1946         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
1947         (-[RemoteObjectRegistryPlugIn doNotCallCompletionHandler:]): Implement new method by not
1948           calling the completion handler.
1949
1950 2016-08-07  Chris Dumez  <cdumez@apple.com>
1951
1952         Write API test to cover crash fix in r204135
1953         https://bugs.webkit.org/show_bug.cgi?id=160587
1954
1955         Reviewed by Darin Adler.
1956
1957         Add API test to cover crash fix in r204135. This reproduces the crash
1958         by destroying a related WKWebView in the webViewWebContentProcessDidTerminate
1959         callback.
1960
1961         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
1962         (-[NavigationDelegate webViewWebContentProcessDidTerminate:]):
1963         (TEST):
1964
1965 2016-08-06  Chris Dumez  <cdumez@apple.com>
1966
1967         Unreviewed, rolling out r204226.
1968
1969         Broke some API tests
1970
1971         Reverted changeset:
1972
1973         "Write API test to cover crash fix in r204135"
1974         https://bugs.webkit.org/show_bug.cgi?id=160587
1975         http://trac.webkit.org/changeset/204226
1976
1977 2016-08-06  Aakash Jain  <aakash_jain@apple.com>
1978
1979         EWS Style Queue fails to process patches which fails validation
1980         https://bugs.webkit.org/show_bug.cgi?id=160632
1981
1982         Reviewed by Alexey Proskuryakov.
1983
1984         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
1985         (StyleQueueTask.validate): Add more information about validation failure.
1986         (StyleQueueTask.run): Pass the error details in the PatchIsNotValid exception.
1987         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1988         (test_non_valid_patch): Add a unit test to test the above code path.
1989
1990 2016-08-06  Sam Weinig  <sam@webkit.org>
1991
1992         WTF needs a variant implementation
1993         https://bugs.webkit.org/show_bug.cgi?id=160618
1994
1995         Reviewed by Darin Adler.
1996
1997         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1998         * TestWebKitAPI/Tests/WTF/Variant.cpp: Added.
1999         Add tests for the variant implementation.
2000
2001 2016-08-06  Chris Dumez  <cdumez@apple.com>
2002
2003         Write API test to cover crash fix in r204135
2004         https://bugs.webkit.org/show_bug.cgi?id=160587
2005
2006         Reviewed by Darin Adler.
2007
2008         Add API test to cover crash fix in r204135. This reproduces the crash
2009         by destroying a related WKWebView in the webViewWebContentProcessDidTerminate
2010         callback.
2011
2012         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
2013         (-[NavigationDelegate webViewWebContentProcessDidTerminate:]):
2014         (TEST):
2015
2016 2016-08-05  Tim Horton  <timothy_horton@apple.com>
2017
2018         run-api-tests should use a headed simulator
2019         https://bugs.webkit.org/show_bug.cgi?id=160611
2020
2021         Reviewed by Sam Weinig.
2022
2023         CADisplayLink doesn't work in a headless simulator, but is
2024         vital for the proper functioning of WebKit2 painting on iOS.
2025         So, we should not use a headless simulator.
2026
2027         * Scripts/run-api-tests:
2028         Launch a simulator app, don't just boot the simulator.
2029
2030         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
2031         Re-enable a test that works now.
2032
2033 2016-08-05  Dan Bernstein  <mitz@apple.com>
2034
2035         [Cocoa] WKRemoteObjectCoder doesn’t handle NSRange
2036         https://bugs.webkit.org/show_bug.cgi?id=160589
2037
2038         Reviewed by Tim Horton.
2039
2040         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h:
2041         (remoteObjectInterface): Fixed a mistake in the set of allowed classes in one of the reply
2042           blocks, which wasn’t caught because the test wasn’t run correctly.
2043         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
2044         (TEST): Fixed the -selectionAndClickInformationForClickAtPoint:completionHandler: test, and
2045           added a test that sends over an NSRange.
2046         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
2047         (-[RemoteObjectRegistryPlugIn takeRange:completionHandler:]): Added. Calls the completion
2048           handler with the range‘s location and length.
2049
2050 2016-08-05  Enrica Casucci  <enrica@apple.com>
2051
2052         Fixing tests failing after r204175.
2053
2054         Unreviewed.
2055
2056         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig:
2057
2058 2016-08-05  Enrica Casucci  <enrica@apple.com>
2059
2060         Build fix after 204053.
2061
2062         Unreviewed.
2063
2064         * TestWebKitAPI/Configurations/Base.xcconfig:
2065         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
2066         (-[MockContentFilterEnabler initWithCoder:]):
2067         (-[MockContentFilterEnabler dealloc]):
2068
2069 2016-08-05  Konstantin Tokarev  <annulen@yandex.ru>
2070
2071         Print test name in "Last character read from DRT..." error message.
2072         https://bugs.webkit.org/show_bug.cgi?id=160559
2073
2074         Reviewed by Michael Catanzaro.
2075
2076         * Scripts/webkitpy/port/driver.py:
2077         (Driver.run_test):
2078         (Driver._read_first_block):
2079         (Driver._read_optional_image_block):
2080         (Driver._read_block):
2081         * Scripts/webkitpy/port/driver_unittest.py:
2082         (DriverTest.test_read_block):
2083         (DriverTest.test_read_binary_block):
2084         (DriverTest.test_read_base64_block):
2085
2086 2016-08-05  Commit Queue  <commit-queue@webkit.org>
2087
2088         Unreviewed, rolling out r204123.
2089         https://bugs.webkit.org/show_bug.cgi?id=160597
2090
2091         Caused layout test timeouts on Windows. (Requested by perarne
2092         on #webkit).
2093
2094         Reverted changeset:
2095
2096         "[Win] Unable to reliably run tests in parallel"
2097         https://bugs.webkit.org/show_bug.cgi?id=140914
2098         http://trac.webkit.org/changeset/204123
2099
2100 2016-08-04  Saam Barati  <sbarati@apple.com>
2101
2102         Restore CodeBlock jettison code to jettison when a CodeBlock has been alive for a long time
2103         https://bugs.webkit.org/show_bug.cgi?id=151241
2104
2105         Reviewed by Benjamin Poulain.
2106
2107         * Scripts/run-jsc-stress-tests:
2108
2109 2016-08-04  Dean Johnson  <dean_johnson@apple.com>
2110
2111         UI improvements to Flakiness Dashboard.
2112         https://bugs.webkit.org/show_bug.cgi?id=153295
2113
2114         Reviewed by Alexey Proskuryakov.
2115
2116         * TestResultServer/static-dashboards/flakiness_dashboard.css:
2117         (td.options-container): Center text in most fields.
2118         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2119         (createBugHTML): Text/Grammar updates.
2120         (tableHeaders): Ditto.
2121         (htmlForSingleTestRow): Ditto.
2122         (headerForTestTableHtml): Ditto.
2123         * TestResultServer/static-dashboards/ui.js: Removed the "Group: " and "Test type: " headings.
2124         (ui.html.testTypeSwitcher): Deleted. Removes the "Group:" heading.
2125
2126 2016-08-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2127
2128         [GTK] install-dependencies script misses libxslt as build-dependency and some python libs for the run-benchmark script
2129         https://bugs.webkit.org/show_bug.cgi?id=160518
2130
2131         Reviewed by Michael Catanzaro.
2132
2133         * Scripts/webkitpy/thirdparty/__init__.py:
2134         (AutoinstallImportHook._install_twisted): Twisted requires zope.interface.
2135         * gtk/install-dependencies:
2136
2137 2016-08-04  Alexey Proskuryakov  <ap@apple.com>
2138
2139         Optimize bot watcher's dashboard a little
2140         https://bugs.webkit.org/show_bug.cgi?id=160515
2141         rdar://problem/26096900
2142
2143         Reviewed by Lucas Forschler.
2144
2145         Made re-sorting after loading an iteration more efficient.
2146
2147         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2148         (BuildbotIteration.prototype._updateWithData):
2149         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2150         (BuildbotQueue.prototype.updateIterationPosition):
2151
2152 2016-08-04  Per Arne Vollan  <pvollan@apple.com>
2153
2154         [Win] Unable to reliably run tests in parallel
2155         https://bugs.webkit.org/show_bug.cgi?id=140914
2156
2157         Reviewed by Brent Fulgham.
2158
2159         The cygpath utility function can fail badly when running with multiple DumpRenderTree
2160         processes. We can use string replacement to convert the Cygwin path to a Windows path
2161         instead.
2162  
2163         * Scripts/webkitpy/common/system/path.py:
2164         (cygpathFast):
2165         * Scripts/webkitpy/port/driver.py:
2166         (Driver._command_from_driver_input):
2167
2168 2016-08-03  Aakash Jain  <aakash_jain@apple.com>
2169
2170         Document instructions for increasing process and file limits
2171         https://bugs.webkit.org/show_bug.cgi?id=160528
2172         rdar://problem/24777576
2173
2174         Reviewed by Alexey Proskuryakov.
2175
2176         * Scripts/webkitpy/port/ios.py:
2177         (IOSSimulatorPort.default_child_processes):
2178
2179 2016-08-03  Anders Carlsson  <andersca@apple.com>
2180
2181         Remove the Objective-C bindings generator
2182         https://bugs.webkit.org/show_bug.cgi?id=160526
2183
2184         Reviewed by Sam Weinig.
2185
2186         * Scripts/run-bindings-tests:
2187         Update test.
2188
2189 2016-08-03  Tim Horton  <timothy_horton@apple.com>
2190
2191         Revise a TestWebKitAPI comment to mention the actual underlying problem
2192
2193         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
2194         Note that this is because of https://bugs.webkit.org/show_bug.cgi?id=160516
2195
2196 2016-08-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2197
2198         Benchmark test content-animation timeouts always
2199         https://bugs.webkit.org/show_bug.cgi?id=160057
2200
2201         Reviewed by Simon Fraser.
2202
2203         * Scripts/webkitpy/benchmark_runner/data/plans/Skipped: Added.
2204         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
2205         (start):
2206
2207 2016-08-02  Nan Wang  <n_wang@apple.com>
2208
2209         AX: Simulated touch events are not working on iOS
2210         https://bugs.webkit.org/show_bug.cgi?id=160395
2211         <rdar://problem/27633597>
2212
2213         Reviewed by Chris Fleizach.
2214
2215         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2216         (WTR::AccessibilityUIElement::press):
2217         (WTR::AccessibilityUIElement::setSelectedChild):
2218
2219 2016-08-02  Filip Pizlo  <fpizlo@apple.com>
2220
2221         run-javascriptcore-tests should accept multiple --extra-tests
2222         https://bugs.webkit.org/show_bug.cgi?id=160486
2223
2224         Reviewed by Saam Barati.
2225         
2226         We want to be able to pass --extra-tests multiple times, to supply an arbitrary number of extra
2227         test suites. This does it by using GetOpt::Long's array support.
2228
2229         * Scripts/run-javascriptcore-tests:
2230         (runJSCStressTests):
2231
2232 2016-08-02  Enrica Casucci  <enrica@apple.com>
2233
2234         Allow building with content filtering disabled.
2235         https://bugs.webkit.org/show_bug.cgi?id=160454
2236
2237         Reviewed by Simon Fraser.
2238
2239         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2240
2241 2016-08-02  Brady Eidson  <beidson@apple.com>
2242
2243         Removing IndexedDB WebsiteData can fail for some users.
2244         https://bugs.webkit.org/show_bug.cgi?id=160463
2245
2246         Reviewed by Alex Christensen.
2247
2248         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm:
2249
2250 2016-08-01  Alex Christensen  <achristensen@webkit.org>
2251
2252         _WKDownloadDelegate.didReceiveResponse should be called before decideDestinationWithSuggestedFilename
2253         https://bugs.webkit.org/show_bug.cgi?id=160437
2254         <rdar://problem/27578272>
2255
2256         Reviewed by Brady Eidson.
2257
2258         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2259         (-[DownloadDelegate _download:didReceiveResponse:]):
2260         (-[DownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
2261         (runTest):
2262         Add a boolean to make sure that didReceiveResponse is called before decideDestinationWithSuggestedFilename.
2263
2264 2016-08-01  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2265
2266         [Tools] The GDB backtrace report tool don't checks the gdb return code.
2267         https://bugs.webkit.org/show_bug.cgi?id=160414
2268
2269         Reviewed by Michael Catanzaro.
2270
2271         * Scripts/webkitpy/port/linux_get_crash_log.py:
2272         (GDBCrashLogGenerator._wait_for_corefile):
2273
2274 2016-08-01  Youenn Fablet  <youenn@apple.com>
2275
2276         Make wpt server generate its certificates in layout test results folder
2277         https://bugs.webkit.org/show_bug.cgi?id=160422
2278
2279         Reviewed by Chris Dumez.
2280
2281         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2282         (WebPlatformTestServer._copy_webkit_test_files): Setting certificate folder to layout tests results directory.
2283
2284 2016-08-01  Jonathan Bedard  <jbedard@apple.com>
2285
2286         Function Call on NULL Object
2287         https://bugs.webkit.org/show_bug.cgi?id=160325
2288
2289         Reviewed by Darin Adler.
2290
2291         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2292         (WTR::InjectedBundle::didReceiveMessageToPage): Changed removeAllWebNotificationPermissions() call to static function call.
2293         * WebKitTestRunner/InjectedBundle/TestRunner.h: Made all web-notification functions static.
2294
2295 2016-08-01  Keith Miller  <keith_miller@apple.com>
2296
2297         We should not keep the JavaScript tests inside the Source/JavaScriptCore/ directory.
2298         https://bugs.webkit.org/show_bug.cgi?id=160372
2299
2300         Rubber stamped by Geoffrey Garen.
2301
2302         This patch moves all the JavaScript tests from Source/JavaScriptCore/tests to
2303         a new top level directory, JSTests. Having the tests in the Source directory
2304         was both confusing an inconvenient for people that just want to checkout the
2305         source code of WebKit. Since there is no other obvious place to put all the
2306         JavaScript tests a new top level directory seemed the most sensible.
2307
2308         * Scripts/import-test262-tests:
2309         * Scripts/run-javascriptcore-tests:
2310         * Scripts/update-javascriptcore-test-res:
2311
2312 2016-07-31  Nan Wang  <n_wang@apple.com>
2313
2314         AX: Add a check for touch event listener on iOS accessibility object
2315         https://bugs.webkit.org/show_bug.cgi?id=160388
2316
2317         Reviewed by Chris Fleizach.
2318
2319         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2320         (AccessibilityUIElement::boolAttributeValue):
2321         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2322         (WTR::AccessibilityUIElement::boolAttributeValue):
2323
2324 2016-07-30  Manuel Rego Casasnovas  <rego@igalia.com>
2325
2326         Unreviewed: add myself to the reviewers list.
2327
2328         * Scripts/webkitpy/common/config/contributors.json:
2329
2330 2016-07-29  Alexey Proskuryakov  <ap@apple.com>
2331
2332         Undo r203939, and copy over a rule that clips the logos.
2333
2334         Sierra wasn't the only logo without transparency.
2335
2336         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra.png:
2337         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra@2x.png:
2338         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2339
2340 2016-07-29  Alan Sien Wei Hshieh  <hshieh@apple.com>
2341
2342         The Sierra asset at build.webkit.org/dashboard/images/Sierra*.png has a white background
2343         https://bugs.webkit.org/show_bug.cgi?id=160377
2344
2345         Reviewed by Brian Weinstein.
2346
2347         Update assets to remove the white background and use a transparent background instead.
2348
2349         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra.png:
2350         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra@2x.png:
2351
2352 2016-07-29  David Kilzer  <ddkilzer@apple.com>
2353
2354         Ignore most check-webkit-style checks for ANGLE project
2355         <https://webkit.org/b/160333>
2356
2357         Reviewed by Daniel Bates.
2358
2359         * Scripts/webkitpy/style/checker.py: Ignore all checkers except:
2360         - No tabs.
2361         - No spaces at the end of lines.
2362         - No carriage returns (DOS line endings).
2363
2364 2016-07-29  Wenson Hsieh  <wenson_hsieh@apple.com>
2365
2366         Media controls are not displayed for some autoplaying videos at certain browser dimensions
2367         https://bugs.webkit.org/show_bug.cgi?id=160360
2368         <rdar://problem/27179484>
2369
2370         Reviewed by Myles C. Maxfield.
2371
2372         Adds two tests verifying that videos may be considered main content as long as they
2373         are large enough and cover a majority of the mainframe's viewport.
2374
2375         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2376         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
2377         (TestWebKitAPI::TEST):
2378         * TestWebKitAPI/Tests/WebKit2Cocoa/full-size-autoplaying-video-with-audio.html: Added.
2379         * TestWebKitAPI/Tests/WebKit2Cocoa/skinny-autoplaying-video-with-audio.html: Added.
2380
2381 2016-07-29  Mark Lam  <mark.lam@apple.com>
2382
2383         Gardening: removed unused variable.
2384
2385         Not reviewed.
2386
2387         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2388         (TestWebKitAPI::TEST):
2389
2390 2016-07-29  Wenson Hsieh  <wenson_hsieh@apple.com>
2391
2392         Add TestWebKitAPI support for interacting with media controls
2393         https://bugs.webkit.org/show_bug.cgi?id=160342
2394         <rdar://problem/27610246>
2395
2396         Reviewed by Beth Dakin.
2397
2398         Adds support for testing interaction with some media controls, as well as a basic test
2399         verifying that media control teardown after interaction does not result in a crash.
2400
2401         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
2402         (-[WKWebView mouseDownAtPoint:]):
2403         (-[WKWebView performAfterLoading:]):
2404         (TestWebKitAPI::TEST):
2405
2406 2016-07-29  Jonathan Bedard  <jbedard@apple.com>
2407
2408         Crash Log Clobbering on Unbound Crashes
2409         https://bugs.webkit.org/show_bug.cgi?id=160198
2410         <rdar://problem/27472618>
2411
2412         Reviewed by Alexey Proskuryakov.
2413
2414         * Scripts/webkitpy/common/system/crashlogs.py:
2415         (CrashLogs): Fix header order.
2416         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2417         (TestResultWriter.output_filename): Only remove file extension if it is clearly a file extension.
2418
2419 2016-07-29  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
2420
2421         Update for contributors.json
2422         https://bugs.webkit.org/show_bug.cgi?id=160294
2423
2424         * Scripts/webkitpy/common/config/contributors.json:
2425
2426 2016-07-28  Myles C. Maxfield  <mmaxfield@apple.com>
2427
2428         Remove deprecated SPI for video inline / fullscreen controls
2429         https://bugs.webkit.org/show_bug.cgi?id=160318
2430
2431         Reviewed by Tim Horton.
2432
2433         * DumpRenderTree/mac/DumpRenderTree.mm:
2434         (setDefaultsToConsistentValuesForTesting): Deleted.
2435         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
2436         (RequiresUserActionForPlaybackTest::SetUp): Deleted.
2437         * WebKitTestRunner/TestController.cpp:
2438         (WTR::TestController::resetPreferencesToConsistentValues): Deleted.
2439         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2440         (WTR::initializeWebViewConfiguration): Deleted.
2441
2442 2016-07-28  Daniel Bates  <dabates@apple.com>
2443
2444         [iOS] TestWebKitAPI bundle targets are not code signed
2445         https://bugs.webkit.org/show_bug.cgi?id=160328
2446         <rdar://problem/27409246>
2447
2448         Reviewed by Andy Estes.
2449
2450         Workaround <rdar://problem/27459890> by explicitly defining Xcode build settings
2451         CODE_SIGNING_ALLOWED and AD_HOC_CODE_SIGNING_ALLOWED to be YES so as to allow the
2452         the TestWebKitAPI bundle targets to be code signed when building for the iOS simulator.
2453
2454         * TestWebKitAPI/Configurations/Base.xcconfig:
2455
2456 2016-07-28  Tim Horton  <timothy_horton@apple.com>
2457
2458         Disable WebKit2.ResizeWithHiddenContentDoesNotHang for now
2459
2460         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
2461         (animatedResizeWebView):
2462         (TEST):
2463         This test times out only when run in the WebKit Testing simulator environment,
2464         but not in a fresh simulator. Disabling to keep the bots green while under investigation.
2465
2466 2016-07-28  Tim Horton  <timothy_horton@apple.com>
2467
2468         Frequent animation lags when interacting with Safari (sidebar, tab switching, etc.)
2469         https://bugs.webkit.org/show_bug.cgi?id=160289
2470         <rdar://problem/27553464>
2471
2472         Reviewed by Simon Fraser.
2473
2474         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
2475         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2476         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm: Added.
2477         (-[AnimatedResizeNavigationDelegate _webView:renderingProgressDidChange:]):
2478         (-[AnimatedResizeWebView _endAnimatedResize]):
2479         (animatedResizeWebView):
2480         (TEST):
2481         * TestWebKitAPI/Tests/WebKit2Cocoa/blinking-div.html: Added.
2482         Add two tests that ensure that hidden-content and animated resizes
2483         don't cause unnecessary synchronous waits. Only the hidden-content
2484         one fails before my patch, but it seemed reasonable to add both anyway.
2485
2486 2016-07-28  David Kilzer  <ddkilzer@apple.com>
2487
2488         webkit-patch upload --suggest-reviewers shouldn't break in the presence of deleted or moved files
2489         <https://webkit.org/b/83342>
2490
2491         Reviewed by Ryosuke Niwa.
2492
2493         * Scripts/webkitpy/common/checkout/scm/git.py:
2494         (Git.revisions_changing_file): Remove code to raise an exception
2495         when the file doesn't exist.  If a file was moved or renamed,
2496         then this caused the script to terminate, which was very
2497         frustrating when you wanted a list of reviewers.
2498         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2499         (SCMTest._shared_test_revisions_changing_file): Update test
2500         expectation to return an empty list of revisions.
2501         (test_create_patch_is_full_patch): Drive-by fix when running all
2502         webkitpy tests (including scm tests).
2503         * Scripts/webkitpy/common/checkout/scm/svn.py:
2504         (SVN.revisions_changing_file): Catch ScriptError exceptions and
2505         return an empty array of revisions if this occurs.
2506
2507 2016-07-28  Aakash Jain  <aakash_jain@apple.com>
2508
2509         EWS error message "Error: * did not process patch" should include explanation
2510         https://bugs.webkit.org/show_bug.cgi?id=159903
2511         <rdar://problem/27410788>
2512
2513         Reviewed by Alexey Proskuryakov.
2514
2515         * QueueStatusServer/handlers/statusbubble.py:
2516         (StatusBubble._build_bubble): Display more detailed error message on bubbles when patch
2517         is not processed.
2518         * QueueStatusServer/handlers/processingtimesjson.py:
2519         (ProcessingTimesJSON._resultFromFinalStatus): Updated error message to match with rest
2520         of the code.
2521         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2522         (CommitQueueTask.validate): Add more information about validation failure.
2523         (CommitQueueTask.run): Pass the error details in the PatchIsNotValid exception.
2524         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
2525         (EarlyWarningSystemTask.validate): Add more information about validation failure.
2526         (EarlyWarningSystemTask.run): Pass the error details in the PatchIsNotValid exception.
2527         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
2528         (PatchIsNotValid.__init__): Add the failure_message argument.
2529         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2530         (AbstractEarlyWarningSystem.review_patch): Re-word the error message and include
2531         failure details.
2532         * Scripts/webkitpy/tool/commands/queues.py:
2533         (CommitQueue.process_work_item): Same.
2534         (StyleQueue.review_patch): Same.
2535         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2536         (test_non_valid_patch): Updated test-cases messages to match the above changes.
2537
2538 2016-07-27  Alexey Proskuryakov  <ap@apple.com>
2539
2540         LayoutTestRelay should wait for WebKitTestRunnerApp installation to complete
2541         https://bugs.webkit.org/show_bug.cgi?id=160262
2542
2543         Reviewed by Daniel Bates.
2544
2545         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
2546         (-[LTRelayController installApp]):
2547
2548 2016-07-27  Ryan Haddad  <ryanhaddad@apple.com>
2549
2550         Disable WebCoreNSURLSessionTest API tests on ios-simulator
2551         https://bugs.webkit.org/show_bug.cgi?id=160225
2552
2553         Reviewed by Alexey Proskuryakov.
2554
2555         * TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm:
2556
2557 2016-07-27  Miguel Gomez  <magomez@igalia.com>
2558
2559         [GTK] Fix some video/canvas tests that should be passing
2560         https://bugs.webkit.org/show_bug.cgi?id=160023
2561
2562         Reviewed by Carlos Garcia Campos.
2563
2564         Add a platform identifier to the TestRunner's page user agent when the tests are run on the
2565         EFL or GTK platforms.
2566
2567         * WebKitTestRunner/efl/TestControllerEfl.cpp:
2568         (WTR::TestController::platformConfigureViewForTest):
2569         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2570         (WTR::TestController::platformConfigureViewForTest):
2571
2572 2016-07-27  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2573
2574         [Tools] The built product doesn't contains the dwo files when DEBUG_FISSION is enabled.
2575         https://bugs.webkit.org/show_bug.cgi?id=160247
2576
2577         Reviewed by Michael Catanzaro.
2578
2579         * BuildSlaveSupport/built-product-archive:
2580         (createZip):
2581         (dirContainsdwo):
2582         (archiveBuiltProduct):
2583
2584 2016-07-26  Alex Christensen  <achristensen@webkit.org>
2585
2586         Fix tests after r203743.
2587         https://bugs.webkit.org/show_bug.cgi?id=156947
2588
2589         * WebKitTestRunner/TestController.cpp:
2590         (WTR::TestController::resetStateToConsistentValues):
2591         Reset the new boolean m_rejectsProtectionSpaceAndContinueForAuthenticationChallenges.
2592
2593 2016-07-26  Myles C. Maxfield  <mmaxfield@apple.com>
2594
2595         [iPhone] Playing a video on tudou.com plays only sound, no video
2596         https://bugs.webkit.org/show_bug.cgi?id=160178
2597         <rdar://problem/27535468>
2598
2599         Reviewed by Dan Bernstein.
2600
2601         * DumpRenderTree/mac/DumpRenderTree.mm:
2602         (setDefaultsToConsistentValuesForTesting):
2603         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
2604         (RequiresUserActionForPlaybackTest::SetUp):
2605         * WebKitTestRunner/TestController.cpp:
2606         (WTR::TestController::resetPreferencesToConsistentValues):
2607         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2608         (WTR::initializeWebViewConfiguration):
2609
2610 2016-07-26  Simon Fraser  <simon.fraser@apple.com>
2611
2612         Allow LOG macros to be used outside the namespace, and other logging cleanup
2613         https://bugs.webkit.org/show_bug.cgi?id=160216
2614
2615         Reviewed by Anders Carlsson.
2616         
2617         initializeLoggingChannelsIfNecessary -> initializeLogChannelsIfNecessary
2618
2619         * DumpRenderTree/TestRunner.cpp:
2620         * DumpRenderTree/mac/DumpRenderTree.mm:
2621         (resetWebViewToConsistentStateBeforeTesting):
2622
2623 2016-07-26  David Kilzer <ddkilzer@apple.com>
2624
2625         Networking process crash due to missing -[WebCoreAuthenticationClientAsChallengeSender performDefaultHandlingForAuthenticationChallenge:] implementation
2626         https://bugs.webkit.org/show_bug.cgi?id=156947
2627         <rdar://problem/23325160>
2628
2629         Reviewed by Alex Christensen.
2630
2631         * DumpRenderTree/TestRunner.cpp:
2632         (TestRunner::TestRunner):
2633         (setRejectsProtectionSpaceAndContinueForAuthenticationChallengesCallback):
2634         * DumpRenderTree/TestRunner.h:
2635         (TestRunner::rejectsProtectionSpaceAndContinueForAuthenticationChallenges):
2636         (TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
2637         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2638         (-[ResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]):
2639         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2640         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2641         (WTR::TestRunner::queueNonLoadingScript):
2642         (WTR::TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
2643         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2644         * WebKitTestRunner/TestController.cpp:
2645         (WTR::TestController::didReceiveAuthenticationChallenge):
2646         * WebKitTestRunner/TestController.h:
2647         (WTR::TestController::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
2648         * WebKitTestRunner/TestInvocation.cpp:
2649         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2650         Add TestRunner.setRejectsProtectionSpaceAndContinueForAuthenticationChallenges to use for testing.
2651
2652 2016-07-26  David Kilzer  <ddkilzer@apple.com>
2653
2654         check-for-exit-time-destructors should be usable outside Xcode
2655         <https://webkit.org/b/160195>
2656
2657         Reviewed by Darin Adler.
2658
2659         * Scripts/check-for-exit-time-destructors: Update to parse
2660         -h|--help switch, or to take one argument to a binary to check
2661         for exit time destructors on the command-line.  The clang
2662         compiler will find these at compile-time with the
2663         -Wexit-time-destructors switch, but this script will check for
2664         them after-the-fact.
2665
2666 2016-07-26  Lucas Forschler  <lforschler@apple.com>
2667
2668         Test svn.webkit.org functionality after maintenance.
2669
2670 2016-07-25  Brady Eidson  <beidson@apple.com>
2671
2672         Modern IDB: Make sure IndexedDB works from file:// url documents by default
2673         https://bugs.webkit.org/show_bug.cgi?id=153783
2674
2675         Reviewed by Alex Christensen.
2676
2677         Previously, to grant IndexedDB access to file:// urls for testing purposes, 
2678         we had to call the SPI [WKWebViewConfiguration _setAllowUniversalAccessFromFileURLs:].
2679         
2680         As of https://trac.webkit.org/changeset/203695 this is no longer required.
2681         
2682         Change the relevant API tests to make sure this continues to be no longer required.
2683
2684         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm:
2685         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm:
2686         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
2687         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm:
2688         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm:
2689         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
2690
2691 2016-07-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2692
2693         Media controls should not be displayed for a video until it starts playing
2694         https://bugs.webkit.org/show_bug.cgi?id=160092
2695         <rdar://problem/26986673>
2696
2697         Reviewed by Beth Dakin.
2698
2699         Verify that multiple videos do or don't show the media controller depending on whether videos
2700         are playing. Also tweaks an existing API test (VideoControlsManagerSingleLargeVideo) that was
2701         passing because we were always showing media controls for large videos with audio, even if they
2702         had not played back yet. This change ensures that large videos with audio show media controls
2703         only after they begin to play back, and not by virtue of being large enough for main content.
2704
2705         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2706         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
2707         (TestWebKitAPI::TEST):
2708         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-with-audio.html:
2709         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-with-audio-autoplay.html: Added.
2710         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-with-audio.html: Added.
2711
2712 2016-07-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2713
2714         Media controls on apple.com don't disappear when movie finishes playing
2715         https://bugs.webkit.org/show_bug.cgi?id=160068
2716         <rdar://problem/26668526>
2717
2718         Reviewed by Darin Adler.
2719
2720         Adds new API tests. Please see WebCore ChangeLog for more details.
2721
2722         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2723         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
2724         (-[MediaPlaybackMessageHandler initWithWKWebView:finalMessageString:]):
2725         (-[MediaPlaybackMessageHandler userContentController:didReceiveScriptMessage:]):
2726         (TestWebKitAPI::TEST):
2727         (-[DidPlayMessageHandler initWithWKWebView:]): Deleted.
2728         (-[DidPlayMessageHandler userContentController:didReceiveScriptMessage:]): Deleted.
2729         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-hides-controls-after-seek-to-end.html: Added.
2730         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-seek-after-ending.html: Added.
2731         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-seek-to-beginning-and-play-after-ending.html: Added.
2732
2733 2016-07-25  Philippe Normand  <pnormand@igalia.com>
2734
2735         Unreviewed, fix test-webkitpy after r203674.
2736
2737         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
2738         (GDBCrashLogGeneratorTest.test_generate_crash_log):
2739
2740 2016-07-24  Philippe Normand  <pnormand@igalia.com>
2741
2742         Unreviewed, forgot to commit this file in r203674.
2743
2744         * Scripts/process-linux-coredump: Added.
2745         (main):
2746
2747 2016-07-25  Philippe Normand  <pnormand@igalia.com>
2748
2749         Improve GDB backtrace generation for GTK/EFL
2750         https://bugs.webkit.org/show_bug.cgi?id=128928
2751
2752         Reviewed by Carlos Garcia Campos.
2753
2754         The PID of the crashed process is now correctly supplied to the
2755         crash log reporter. The kernel core_pattern needs to be updated
2756         after this change to something like:
2757
2758         echo "|/home/phil/WebKit/Tools/Scripts/process-linux-coredump /tmp/core-pid_%p.dump" > /proc/sys/kernel/core_pattern
2759
2760         * Scripts/process-linux-coredump: Added.
2761         (main): Minimal python script reading coredump data on stdin and writing it to a file in /tmp/.
2762         * Scripts/webkitpy/port/efl.py:
2763         (EflPort._get_crash_log): Supply path of the process-linux-coredump script.
2764         * Scripts/webkitpy/port/gtk.py:
2765         (GtkPort._get_crash_log): Ditto.
2766         * Scripts/webkitpy/port/linux_get_crash_log.py:
2767         (GDBCrashLogGenerator.__init__): New argument for supplying the path of a coredump processor script.
2768         (GDBCrashLogGenerator.generate_crash_log): Update error message, the core_pattern should now be set to pipe coredumps to a script.
2769         (GDBCrashLogGenerator): Deleted.
2770         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
2771         (GDBCrashLogGeneratorTest.test_generate_crash_log): Update test expectations.
2772         * WebKitTestRunner/TestController.cpp:
2773         (WTR::TestController::networkProcessDidCrash): Supply PID of crash process.
2774         (WTR::TestController::databaseProcessDidCrash): Ditto.
2775         (WTR::TestController::processDidCrash): Ditto.
2776
2777 2016-07-23  Youenn Fablet  <youenn@apple.com>
2778
2779         WPT stash server should be kept running when launching wpt server
2780         https://bugs.webkit.org/show_bug.cgi?id=160052
2781
2782         Reviewed by Sam Weinig.
2783
2784         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
2785         (main): waiting to read stdin while stash server is started.
2786
2787 2016-07-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2788
2789         Media controls should be displayed for media in media documents
2790         https://bugs.webkit.org/show_bug.cgi?id=160104
2791         <rdar://problem/27438936>
2792
2793         Reviewed by Myles C. Maxfield.
2794
2795         Verifies that even a small video with audio in a media document gets media controls.
2796
2797         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
2798         (TestWebKitAPI::TEST):
2799
2800 2016-07-22  Michael Saboff  <msaboff@apple.com>
2801
2802         REGRESSION(203616): no FTL testing was inadvertently removed
2803         https://bugs.webkit.org/show_bug.cgi?id=160100
2804
2805         Rubber-stamped by Filip Pizlo.
2806
2807         Added runNoFTL back into the set of tests we run on FTL enabled platforms.
2808         Renamed runLayoutTestNoFTL to runLayoutTestDefault.  Restructured the test
2809         logic for the runLayout and runNoisy variants to match the run test logic,
2810         that is we always invoke runXXXDefault and invoke runXXXNoFTL for FTL
2811         enabled platforms.
2812
2813         * Scripts/run-jsc-stress-tests:
2814
2815 2016-07-22  Brady Eidson  <beidson@apple.com>
2816
2817         Removing IndexedDatabases that have stored blobs doesn't remove the blob files.
2818         https://bugs.webkit.org/show_bug.cgi?id=160089
2819
2820         Reviewed by Darin Adler.
2821
2822         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2823         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm: Added.
2824         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobToBeDeleted.html: Added.
2825
2826 2016-07-22  Konstantin Tokarev  <annulen@yandex.ru>
2827
2828         [GTK] Improved exclusion patterns in make-dist.py manifest.
2829         https://bugs.webkit.org/show_bug.cgi?id=160094
2830
2831         Reviewed by Michael Catanzaro.
2832
2833         * gtk/manifest.txt.in:
2834         Exclude Platform*.cmake files for more ports.
2835         Removed obsolete .gyp and .pro.user patterns.
2836         Exclude 'Configurations' and 'spi' directories.
2837         Exclude CMakeLists.txt.user (Qt Creator IDE).
2838
2839 2016-07-22  Michael Saboff  <msaboff@apple.com>
2840
2841         Don't run FTL related JSC stress tests on non-FTL platforms
2842         https://bugs.webkit.org/show_bug.cgi?id=160033
2843
2844         Reviewed by Mark Lam.
2845
2846         Added check for running tests on platforms that don't enable FTL to not run FTL tests.
2847         Refactored several of the runXXX test methods to always runXXXDefault and made those
2848         runXXXDefault to pass FTL_OPTIONS.  For platforms that don't enable the FTL, FTL_OPTIONS
2849         doesn't cause a problem.
2850
2851         * Scripts/run-jsc-stress-tests:
2852
2853 2016-07-22  Per Arne Vollan  <pvollan@apple.com>
2854
2855         IWebView::mainFrame crashes if called after IWebView::close
2856         https://bugs.webkit.org/show_bug.cgi?id=32868
2857
2858         Reviewed by Brent Fulgham.
2859
2860         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp:
2861         (TestWebKitAPI::TEST_F): Added test.
2862
2863 2016-07-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2864
2865         [GTK] Enable threaded compositor by default
2866         https://bugs.webkit.org/show_bug.cgi?id=160079
2867
2868         Reviewed by Žan Doberšek.
2869
2870         * Scripts/webkitperl/FeatureList.pm:
2871
2872 2016-07-22  Youenn Fablet  <youenn@apple.com>
2873
2874         run-builtins-generator-tests should be able to test WebCore builtins wrapper with more than one file
2875         https://bugs.webkit.org/show_bug.cgi?id=159921
2876
2877         Reviewed by Brian Burg.
2878
2879         Updated builtin generator test runner to generate WebCore wrapper files based on all WebCore valid separate files.
2880
2881         * Scripts/webkitpy/codegen/main.py:
2882         (BuiltinsGeneratorTests.generate_from_js_builtins): Passing a list of builtin files to the script.
2883         (BuiltinsGeneratorTests):
2884         (BuiltinsGeneratorTests.single_builtin_test): Added to handle the case of single builtin generation.
2885         (BuiltinsGeneratorTests.wrappers_builtin_test): Added to handle the case of WebCore wrappers builtin generation.
2886         (BuiltinsGeneratorTests.run_test): Helper routine to run a test in reset mode or normal check mode.
2887         (BuiltinsGeneratorTests.run_tests): Updated to add WebCore wrappers builtin generation test.
2888
2889 2016-07-21  Dan Bernstein  <mitz@apple.com>
2890
2891         [Mac] webkitdirs.pm contains unused code to support outdated OS X and Xcode versions
2892         https://bugs.webkit.org/show_bug.cgi?id=160072
2893
2894         Reviewed by Andy Estes.
2895
2896         * Scripts/webkitdirs.pm:
2897         (readXcodeUserDefault): Changed to take a defaults key rather than a suffix. Removed support
2898           for old Xcode versions.
2899         (determineBaseProductDir): Removed support for old Xcode versions. Updated for the change
2900           to readXcodeUserDefault.
2901         (debugger): Deleted. This was only used for Darwin, where LLDB is now the only supported
2902           debugger.
2903         (determineDebugger): Ditto.
2904         (checkRequiredSystemConfig): Updated to require at least OS X Yosemite v10.10.5 and Xcode
2905           7.0.
2906         (printHelpAndExitForRunAndDebugWebKitAppIfNeeded): Removed --use-gdb and --use-lldb
2907           switches.
2908         (execMacWebKitAppForDebugging): Removed support for GDB.
2909
2910 2016-07-21  Myles C. Maxfield  <mmaxfield@apple.com>
2911
2912         Remove support for deprecated SPI inlineMediaPlaybackRequiresPlaysInlineAttribute
2913         https://bugs.webkit.org/show_bug.cgi?id=160066
2914
2915         Reviewed by Dean Jackson.
2916
2917         * DumpRenderTree/mac/DumpRenderTree.mm:
2918         (setDefaultsToConsistentValuesForTesting): Deleted.
2919         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
2920         (RequiresUserActionForPlaybackTest::SetUp): Deleted.
2921         * WebKitTestRunner/TestController.cpp:
2922         (WTR::TestController::resetPreferencesToConsistentValues): Deleted.
2923         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2924         (WTR::initializeWebViewConfiguration): Deleted.
2925
2926 2016-07-21  Chelsea Pugh  <cpugh@apple.com>
2927
2928         [iOS] Apps using WKWebView will crash if they set the scroll view's delegate and don't nil it out later
2929         https://bugs.webkit.org/show_bug.cgi?id=159980
2930         rdar://problem/27450825
2931
2932         Reviewed by Dan Bernstein.
2933
2934         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2935         * TestWebKitAPI/Tests/ios/WKScrollViewDelegateCrash.mm: Added.
2936         (-[TestDelegateForScrollView dealloc]): Update delegateIsDeallocated to true so that we can tell
2937         when our delegate has hit -dealloc.
2938         (TestWebKitAPI::TEST): Ensure that after an object has been set as the scroll view's delegate,
2939         and has then been deallocated, that the scroll view's delegate is nil and the deallocated delegate
2940         will not be messaged.
2941
2942 2016-07-21  Myles C. Maxfield  <mmaxfield@apple.com>
2943
2944         Follow-up patch to r203520
2945         https://bugs.webkit.org/show_bug.cgi?id=159967
2946         <rdar://problem/26964090>
2947
2948         Unreviewed.
2949
2950         * DumpRenderTree/mac/DumpRenderTree.mm:
2951         (setDefaultsToConsistentValuesForTesting):
2952         * WebKitTestRunner/TestController.cpp:
2953         (WTR::TestController::resetPreferencesToConsistentValues):
2954
2955 2016-07-21  Myles C. Maxfield  <mmaxfield@apple.com>
2956
2957         [iPhone] Playing a video on tudou.com plays only sound, no video
2958         https://bugs.webkit.org/show_bug.cgi?id=159967
2959         <rdar://problem/26964090>
2960
2961         Reviewed by Jon Lee, Jeremy Jones, and Anders Carlsson.
2962
2963         Migrate tests to use new SPI.
2964
2965         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
2966         (RequiresUserActionForPlaybackTest::SetUp):
2967         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2968         (WTR::initializeWebViewConfiguration):
2969
2970 2016-07-21  Csaba Osztrogonác  <ossy@webkit.org>
2971
2972         Clarify testing mode names in run-jsc-stress-tests
2973         https://bugs.webkit.org/show_bug.cgi?id=160021
2974
2975         Reviewed by Mark Lam.
2976
2977         Default should mean really default, not default with disabled FTL, renamed
2978         - runMozillaTestDefault to runMozillaTestNoFTL
2979         - runMozillaTestDefaultFTL to runMozillaTestDefault
2980         - runDefault to runNoFTL
2981         - runDefaultFTL to runDefault
2982         - runLayoutTestDefault to runLayoutTestNoFTL
2983         - runLayoutTestDefaultFTL to runLayoutTestDefault
2984         - runNoisyTestDefault to runNoisyTestNoFTL
2985         - runNoisyTestDefaultFTL to runNoisyTestDefault
2986
2987         * Scripts/run-jsc-stress-tests:
2988
2989 2016-07-21  Yongjun Zhang  <yongjun_zhang@apple.com>
2990
2991         WebBackForwardList's currentIndex could get out of bounds when filtering items.
2992         https://bugs.webkit.org/show_bug.cgi?id=159986
2993
2994         Add a test to verify filtering out 2 items from a 3-item list will set the currentIndex
2995         to 0.
2996
2997         Reviewed by Dan Bernstein.
2998
2999         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3000         * TestWebKitAPI/Tests/WebKit2/WKBackForwardList.mm: Added.
3001         (-[WKBackForwardListTestNavigationDelegate webView:didFinishNavigation:]):
3002         (TEST):
3003
3004 2016-07-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3005
3006         [GTK] Web view background colors don't work in accelerated compositing mode
3007         https://bugs.webkit.org/show_bug.cgi?id=159455
3008
3009         Reviewed by Michael Catanzaro.
3010
3011         Set always RGBA visual to the view widget when setting a background color.
3012
3013         * MiniBrowser/gtk/BrowserWindow.c:
3014         (browser_window_set_background_color):
3015
3016 2016-07-20  Youenn Fablet  <youenn@apple.com>
3017
3018         Bots should run built-ins generator tests
3019         https://bugs.webkit.org/show_bug.cgi?id=159971
3020
3021         Reviewed by Alexey Proskuryakov.
3022
3023         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3024         (RunBuiltinsTests): New step to run built-in generator tests.
3025         (TestFactory.__init__): Adding an additional step for bultin generator tests.
3026         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Rebasing expectations.
3027         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: Adding additional step for proper display.
3028
3029 2016-07-20  Aakash Jain  <aakash_jain@apple.com>
3030
3031         Revert temporary fix r203417
3032         https://bugs.webkit.org/show_bug.cgi?id=160001
3033
3034         Reviewed by Alexey Proskuryakov.
3035
3036         * EWSTools/start-queue-mac.sh: Revert the temporary fix.
3037
3038 2016-07-20  Aakash Jain  <aakash_jain@apple.com>
3039
3040         REGRESSION(r148588): ews classes might get garbage collected
3041         https://bugs.webkit.org/show_bug.cgi?id=159990
3042
3043         Reviewed by Ryosuke Niwa.
3044
3045         * Scripts/webkitpy/tool/commands/__init__.py: Store the loaded ews classes
3046         in a variable so that they do not get garbage collected.
3047
3048 2016-07-20  Jeremy Jones  <jeremyj@apple.com>
3049
3050         Add API test for layout constraints after exit fullscreen
3051         https://bugs.webkit.org/show_bug.cgi?id=159900
3052
3053         Reviewed by Jon Lee.
3054
3055         Added Fullscreen.LaytoutConstraints API test. 
3056         Tests fix from https://bugs.webkit.org/show_bug.cgi?id=159731
3057
3058         This test compares layout constraints on the web view before and after fullscreen to make sure 
3059         they are preserved.
3060
3061         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenLayoutConstraints.html: Added.
3062         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenLayoutConstraints.mm: Added.
3063         (-[FullscreenStateChangeMessageHandler userContentController:didReceiveScriptMessage:]):
3064         (TestWebKitAPI::TEST):
3065
3066 2016-07-20  Ryan Haddad  <ryanhaddad@apple.com>
3067
3068         Disable two failing API tests.
3069
3070         Unreviewed test gardening.
3071
3072         * TestWebKitAPI/Tests/mac/CandidateTests.mm:
3073         (TestWebKitAPI::TEST):
3074
3075 2016-07-20  Wenson Hsieh  <wenson_hsieh@apple.com>
3076
3077         Unreviewed iOS build fix.
3078
3079         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm: Only import Carbon.h on Mac.
3080
3081 2016-07-20  Wenson Hsieh  <wenson_hsieh@apple.com>
3082
3083         Media controls don't appear when pausing a small autoplaying video
3084         https://bugs.webkit.org/show_bug.cgi?id=159972
3085         <rdar://problem/27180657>
3086
3087         Reviewed by Beth Dakin.
3088
3089         Adds a new test that verifies media controls show up when pausing a small autoplayed video. Also adds mechanisms
3090         for simulating basic user interaction in VideoControlsManager.
3091
3092         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3093         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
3094         (-[WKWebView mouseDownAtPoint:]):
3095         (-[DidPlayMessageHandler userContentController:didReceiveScriptMessage:]):
3096         (-[OnLoadMessageHandler initWithWKWebView:handler:]):
3097         (-[OnLoadMessageHandler userContentController:didReceiveScriptMessage:]):
3098         (TestWebKitAPI::TEST):
3099         * TestWebKitAPI/Tests/WebKit2Cocoa/autoplaying-video-with-audio.html: Added.
3100
3101 2016-07-20  Per Arne Vollan  <pvollan@apple.com>
3102
3103         [Win] MathML fonts are not found.
3104         https://bugs.webkit.org/show_bug.cgi?id=159920
3105
3106         Reviewed by Alex Christensen.
3107
3108         When looking up a font in the registry, use the /v option of the Windows 'reg query' command to query
3109         for a specific registry key value.
3110
3111         * Scripts/webkitdirs.pm:
3112         (fontExists):
3113
3114 2016-07-20  Joseph Pecoraro  <pecoraro@apple.com>
3115
3116         Improve prepare-ChangeLog for @media blocks
3117         https://bugs.webkit.org/show_bug.cgi?id=159907
3118
3119         Reviewed by Timothy Hatcher.
3120
3121         * Scripts/prepare-ChangeLog:
3122         (get_selector_line_ranges_for_css):
3123         Get a range for @media blocks just like a selector.
3124             Start Line = line with '{'
3125             End line = line with '}'
3126             Name = "@media ..."
3127
3128         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests_warning-expected.txt:
3129         Improved error messages for unbalanced portions.
3130
3131         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests-expected.txt:
3132         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests.css:
3133         (.media-query::before):
3134         (@media only screen and (max-width: 980px)):
3135         (.media-query a):
3136         (@media (-webkit-min-device-pixel-ratio: 2)):
3137         (.both a):
3138         (.both b):
3139         (.media-query b):
3140         (.media-query::after):
3141
3142 2016-07-20  Csaba Osztrogonác  <ossy@webkit.org>
3143
3144         Fix expectedFailErrorHandler in run-jsc-stress-tests
3145         https://bugs.webkit.org/show_bug.cgi?id=159811
3146
3147         Reviewed by Yusuke Suzuki.
3148
3149         * Scripts/run-jsc-stress-tests:
3150
3151 2016-07-20  Csaba Osztrogonác  <ossy@webkit.org>
3152
3153         Unreviewed Mac cmake buildfix after r203426. Just for fun.
3154
3155         * TestWebKitAPI/PlatformMac.cmake:
3156
3157 2016-07-19  Filip Pizlo  <fpizlo@apple.com>
3158
3159         The default testing mode should not involve disabling the FTL JIT
3160         https://bugs.webkit.org/show_bug.cgi?id=159929
3161
3162         Rubber stamped by Mark Lam and Saam Barati.
3163         
3164         It used to be the case that most actively maintained ports did not have the FTL JIT enabled.
3165         Heck, for most of the FTL's initial development, it wasn't enabled anywhere. So, testing the
3166         FTL was not the default. You had to enable it with an option.
3167         
3168         For some reason we have kept this arrangement even though the FTL JIT is now the default on
3169         all of the major ports. This has become a serious pain. For example, it's useful to be able
3170         to say that a test should only run in the default config that is representative of what a
3171         normal user would see if they ran JSC. Clearly, this would be a config that does not
3172         explicitly disable the FTL JIT on the command line. However, if you try to specify this then
3173         your test won't run at all if the --ftl-jit option is not passed. That's dangerous!
3174         
3175         So, this change gets rid of all of this logic. I think it's better to get rid of it then to
3176         try to fix it, because:
3177         
3178         - I don't know what the fix would look like. Presumably it would ensure that ports that don't
3179           have the FTL enabled never run any tests that explicitly disable the FTL, since that
3180           doesn't do anything. The code is not really structured to allow this.
3181         
3182         - It benefits a minority of clients. Three build bots run tests in a config that has the FTL
3183           disabled in testing. On the other hand there are already build bots that do FTL tests
3184           despite having the FTL disabled by virtue of being a 32-bit platform. So, maybe rather than
3185           preserving this broken feature, we should create something that (a) acknowledges the fact
3186           that the FTL is the default on those platforms that support it and (b) avoids running
3187           no-ftl tests on precisely those platforms that don't have FTL.
3188         
3189         - To the extent that some bots benefited from disabling FTL tests, they were doing it by
3190           relying on a feature that was never meant to stick around. The FTL JIT is meant to be the
3191           default configuration. Disabling the FTL JIT is the non-default. So, we shouldn't be
3192           pretending that the FTL JIT is not the default just because some bots used that as an
3193           optimization.
3194         
3195         This change allows me to speed up some debug tests and paint some bots green.
3196
3197         * Scripts/run-javascriptcore-tests:
3198         (runJSCStressTests):
3199         * Scripts/run-jsc-stress-tests:
3200
3201 2016-07-19  Alex Christensen  <achristensen@webkit.org>
3202
3203         Fix API test after r203426.
3204         https://bugs.webkit.org/show_bug.cgi?id=159949
3205
3206         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
3207         (TEST):
3208         If there is website data already on disk, the initial count after putting the AppCache data in place will not be exactly 1.
3209         This is no problem.  We want to verify that it is a nonzero number and that it decrements by one when we remove the 1 AppCache data.
3210
3211 2016-07-19  Andy Estes  <aestes@apple.com>
3212
3213         Move WebKitErrorFrameLoadBlockedByContentFilter from WebKitErrors.h to WebKitErrorsPrivate.h
3214         https://bugs.webkit.org/show_bug.cgi?id=159956
3215
3216         Reviewed by Dan Bernstein.
3217
3218         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm: Included WKErrorRef.h.
3219         (-[LoadAlternateNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
3220         Used kWKErrorCodeFrameLoadBlockedByContentFilter instead of WebKitErrorFrameLoadBlockedByContentFilter.
3221         * TestWebKitAPI/Tests/mac/ContentFiltering.mm: Included WebKitErrorsPrivate.h instead of WebKitErrors.h.
3222
3223 2016-07-19  Alex Christensen  <achristensen@webkit.org>
3224
3225         Add regression test for r203392
3226         https://bugs.webkit.org/show_bug.cgi?id=159949
3227
3228         Reviewed by Brady Eidson.
3229
3230         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
3231         (fileSize):
3232         (swizzledBundleIdentifierWebBookmarksD):
3233         (defaultApplicationCacheDirectory):
3234         (TEST):
3235         (swizzledBundleIdentifierMobileSafari): Deleted.
3236         This actually tests that webbookmarksd uses the path quirk in WebsiteDataStore::defaultApplicationCacheDirectory.
3237         I wanted to verify that it uses the same path as MobileSafari, but swizzling out the bundleIdentifier twice caused
3238         problems with the static bools that are set once in RuntimeApplicationChecks.mm.
3239
3240 2016-07-19  Alex Christensen  <achristensen@webkit.org>
3241
3242         Add regression test for r203392
3243         https://bugs.webkit.org/show_bug.cgi?id=159949
3244
3245         Reviewed by Brady Eidson.
3246
3247         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3248         * TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db: Added.
3249         * TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db-shm: Added.
3250         * TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db-wal: Added.
3251         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
3252         (TEST):
3253         (fileSize):
3254         (swizzledBundleIdentifierMobileSafari):
3255         (swizzledBundleIdentifierWebBookmarksD):
3256         (defaultApplicationCacheDirectory):
3257         * TestWebKitAPI/cocoa/InstanceMethodSwizzler.h: Copied from TestWebKitAPI/mac/InstanceMethodSwizzler.h.
3258         * TestWebKitAPI/cocoa/InstanceMethodSwizzler.mm: Copied from TestWebKitAPI/mac/InstanceMethodSwizzler.mm.
3259         * TestWebKitAPI/mac/InstanceMethodSwizzler.h: Removed.
3260         * TestWebKitAPI/mac/InstanceMethodSwizzler.mm: Removed.
3261
3262 2016-07-19  Keith Miller  <keith_miller@apple.com>
3263
3264         Test262 should have a file with the revision and url
3265         https://bugs.webkit.org/show_bug.cgi?id=159937
3266
3267         Reviewed by Mark Lam.
3268
3269         The import script should update the information from
3270         the path to the test262 repository it gets.
3271
3272         * Scripts/import-test262-tests:
3273
3274 2016-07-19  Alexey Proskuryakov  <ap@apple.com>
3275
3276         Temporary workaround for iOS EWS failing after the fix for bug 159539.
3277         To be deleted once the root cause is found and addressed.
3278
3279         * EWSTools/start-queue-mac.sh:
3280
3281 2016-07-19  Frederic Wang  <fwang@igalia.com>
3282
3283         [win] Fixup the register name for STIX Math and Latin Modern Math
3284
3285         Unreviewed follow-up of r203406
3286
3287         * Scripts/webkitdirs.pm:
3288         (checkInstalledTools):
3289
3290 2016-07-19  Frederic Wang  <fwang@igalia.com>
3291
3292         [win] Update the list of MathML fonts
3293         https://bugs.webkit.org/show_bug.cgi?id=156838
3294
3295         The set of recommended math fonts is now described at
3296         https://trac.webkit.org/wiki/MathML/Fonts
3297         We update the Perl script to use the latest list of fonts.
3298
3299         Reviewed by Brent Fulgham.
3300
3301         * Scripts/webkitdirs.pm:
3302         (checkInstalledTools):
3303
3304 2016-07-19  Per Arne Vollan  <pvollan@apple.com>
3305
3306         [Win] The test fast/scrolling/overflow-scroll-past-max.html is timing out.
3307         https://bugs.webkit.org/show_bug.cgi?id=159342
3308
3309         Reviewed by Darin Adler.
3310
3311         Implement required functions in event sender.
3312
3313         * DumpRenderTree/PlatformWin.cmake:
3314         * DumpRenderTree/win/EventSender.cpp:
3315         (monitorWheelEvents): Added.
3316         (callAfterScrollingCompletes): Added.
3317
3318 2016-07-19  Youenn Fablet  <youenn@apple.com>
3319
3320         Add new aliases to http test server
3321         https://bugs.webkit.org/show_bug.cgi?id=159878
3322
3323         Reviewed by Darin Adler.
3324
3325         Adding testharness.css, testharness.js and testharnessreport.js new aliases to http test servers.
3326         Adding explicitly these links to perl script.
3327         Extracting default alias in an aliases.json file.
3328         Reading that file from python scripts to initialize aliases from that file.
3329
3330         Python script changes covered by unit tests and changed layout test.
3331
3332         * Scripts/webkitperl/httpd.pm:
3333         (getDefaultConfigForTestDirectory): Adding 3 new aliases
3334         * Scripts/webkitpy/layout_tests/servers/aliases.json: Added.
3335         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
3336         (LayoutTestApacheHttpd.__init__): Setting upper class tests_dir member if needed and according constructor parameter.
3337         Adding -c directives for each alias.
3338         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
3339         (TestLayoutTestApacheHttpd.test_start_cmd): Adding aliases.json mock-up file.
3340         * Scripts/webkitpy/layout_tests/servers/http_server.py:
3341         (Lighttpd.__init__): Setting upper class tests_dir member if needed and according constructor parameter.
3342         Adding alias directive for each alias.
3343         (Lighttpd._prepare_config):
3344         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
3345         (HttpServerBase.__init__): Adding tests_dir member with a default value being layout tests directory.
3346         (HttpServerBase.aliases): Computing of alias from the json file, paths to the real files being relative to
3347         layout tests directory.
3348         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
3349         (TestHttpServer.test_start_cmd): Adding aliases.json mock-up file and updating test expectation.
3350         (TestHttpServer.test_win32_start_and_stop): Adding aliases.json mock-up file.
3351
3352 2016-07-18  Aakash Jain  <aakash_jain@apple.com>
3353
3354         EWS console logs doesn't go to log file
3355         https://bugs.webkit.org/show_bug.cgi?id=159539
3356         <rdar://problem/24464570>
3357
3358         Reviewed by David Kilzer.
3359
3360         * Scripts/webkitpy/common/system/logutils.py:
3361         (configure_logger_to_log_to_file): Added method to configure the logger to log to file.
3362         (FileSystemHandler): Added class which uses logging.FileHandler as base class and supports writing
3363         to filesystem. It also supports passing MockFilesystem.
3364         (FileSystemHandler.__init__): Initialize the class and calls base class __init__.
3365         (FileSystemHandler._open): Overrides the base class _open method to use filesystem object.
3366         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3367         (AbstractEarlyWarningSystemTest.test_failing_tests_message): Added MockHost() parameter.
3368         (_test_ews): Same.
3369         * Scripts/webkitpy/tool/commands/queues.py:
3370         (AbstractQueue.begin_work_queue): Configure the logger to log to file.
3371         (AbstractQueue._log_directory): Using filesystem object instead of os.
3372         (AbstractQueue.queue_log_path): Same.
3373         (AbstractQueue.__init__): Passed host parameter.
3374         (PatchProcessingQueue.__init__): Same.
3375         (CommitQueue.__init__): Same.
3376         (AbstractReviewQueue.__init__): Same.
3377         (StyleQueue.__init__): Same.
3378         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3379         (TestCommitQueue): Passed MockHost() as host.
3380         (TestCommitQueue.__init__): Same.
3381         (TestQueue.__init__): Same.
3382         (TestReviewQueue.__init__): Same.
3383         (TestFeederQueue.__init__): Same.
3384         (AbstractPatchQueueTest.test_next_patch): Same.
3385         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Same.
3386         (test_commit_queue_failure): Same.
3387         (MockCommitQueueTask.results_from_patch_test_run): Same.
3388         (test_rollout_lands): Same.
3389         (test_non_valid_patch): Same.
3390         (test_auto_retry): Same.
3391         (test_style_queue_with_watch_list_exception): Same.
3392
3393 2016-07-02  Filip Pizlo  <fpizlo@apple.com>
3394
3395         WTF::Lock should be fair eventually
3396         https://bugs.webkit.org/show_bug.cgi?id=159384
3397
3398         Reviewed by Geoffrey Garen.
3399
3400         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
3401
3402 2016-07-17  Sam Weinig  <sam@webkit.org>
3403
3404         [WebKit API] Add SPI to track multiple navigations caused by a single user gesture
3405         <rdar://problem/26554137>
3406         https://bugs.webkit.org/show_bug.cgi?id=159856
3407
3408         Reviewed by Dan Bernstein.
3409
3410         * MiniBrowser/mac/WK2BrowserWindowController.m:
3411         (-[WK2BrowserWindowController webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
3412         Add basic window.open implementation.
3413
3414         (-[WK2BrowserWindowController webView:decidePolicyForNavigationAction:decisionHandler:]):
3415         Add basic navigation policy implementation which implements a rule where a user gesture is only allowed
3416         to open a single non-web URL, all others are dropped.
3417
3418         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3419         * TestWebKitAPI/Tests/WebKit2Cocoa/UserInitiatedActionInNavigationAction.mm: Added.
3420         * TestWebKitAPI/Tests/WebKit2Cocoa/open-multiple-external-url.html: Added.
3421         Add API for the new SPI.
3422
3423 2016-07-17  Yusuke Suzuki  <utatane.tea@gmail.com>
3424
3425         [JSC] Enable test262 module tests
3426         https://bugs.webkit.org/show_bug.cgi?id=159854
3427
3428         Reviewed by Saam Barati.
3429
3430         Use --module-file instead.
3431
3432         * Scripts/run-jsc-stress-tests:
3433
3434 2016-07-16  Chris Dumez  <cdumez@apple.com>
3435
3436         Unreviewed, rolling out r203318.
3437
3438         Regressed most JS Benchmarks on MacBook Air by ~2% (7% on
3439         SunSpider)
3440
3441         Reverted changeset:
3442
3443         "[JSC] Change some parameters based on a random search"
3444         https://bugs.webkit.org/show_bug.cgi?id=158514
3445         http://trac.webkit.org/changeset/203318
3446
3447 2016-07-16  Chris Dumez  <cdumez@apple.com>
3448
3449         Add move constructor / assignment operator to ListHashSet
3450         https://bugs.webkit.org/show_bug.cgi?id=159837
3451
3452         Reviewed by Darin Adler.
3453
3454         Add API tests.
3455
3456         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
3457         (TestWebKitAPI::TEST):
3458
3459 2016-07-15  Benjamin Poulain  <bpoulain@apple.com>
3460
3461         [JSC] Change some parameters based on a random search
3462         https://bugs.webkit.org/show_bug.cgi?id=158514
3463
3464         Reviewed by Saam Barati.
3465
3466         * Scripts/run-jsc-stress-tests:
3467
3468 2016-07-15  Jon Davis  <jond@apple.com>
3469
3470         Changed the start page URL for WebKit Nightly builds.
3471         https://bugs.webkit.org/show_bug.cgi?id=159816
3472
3473         Reviewed by Timothy Hatcher.
3474
3475         * WebKitLauncher/start.html:
3476
3477 2016-07-15  Per Arne Vollan  <pvollan@apple.com>
3478
3479         Uninitialized variable in DIBPixelData can cause a dangerous memory write
3480         https://bugs.webkit.org/show_bug.cgi?id=159414
3481
3482         Reviewed by Brent Fulgham.
3483
3484         Add test to check that DIBPixelData::setRGBABitmapAlpha does not cause a crash
3485         when the HDC parameter is invalid.
3486
3487         * TestWebKitAPI/PlatformWin.cmake:
3488         * TestWebKitAPI/Tests/WebCore/win/DIBPixelData.cpp: Added.
3489         (TestWebKitAPI::TEST):
3490
3491 2016-07-15  Carlos Garcia Campos  <cgarcia@igalia.com>
3492
3493         [GTK] Add basic tabs support to MiniBrowser
3494         https://bugs.webkit.org/show_bug.cgi?id=159803
3495
3496         Reviewed by Sergio Villar Senin.
3497
3498         It's quite common to have issues with web views loaded in secondary tabs, and we need to use an external browser
3499         like epiphany to debug those issues. It would be a lot easier to work on those bugs if we could use the MiniBrowser.
3500
3501         * MiniBrowser/gtk/BrowserTab.c: Added.
3502         (titleChanged):
3503         (isLoadingChanged):
3504         (decidePolicy):
3505         (removeChildIfInfoBar):
3506         (loadChanged):
3507         (createInfoBarQuestionMessage):
3508         (tlsErrorsDialogResponse):
3509         (loadFailedWithTLSerrors):
3510         (permissionRequestDialogResponse):
3511         (decidePermissionRequest):
3512         (colorChooserRGBAChanged):
3513         (popoverColorClosed):
3514         (colorChooserRequestFinished):
3515         (runColorChooserCallback):
3516         (inspectorOpenedInWindow):
3517         (inspectorClosed):
3518         (browserTabSetProperty):
3519         (browserTabFinalize):
3520         (browser_tab_init):
3521         (browserTabConstructed):
3522         (browser_tab_class_init):
3523         (getInternalURI):
3524         (browser_tab_new):
3525         (browser_tab_get_web_view):
3526         (browser_tab_load_uri):
3527         (browser_tab_get_title_widget):
3528         (browser_tab_set_status_text):
3529         (browser_tab_toggle_inspector):
3530         (browser_tab_start_search):
3531         (browser_tab_stop_search):
3532         (browser_tab_add_accelerators):
3533         (fullScreenMessageTimeoutCallback):
3534         (browser_tab_enter_fullscreen):
3535         (browser_tab_leave_fullscreen):
3536         * MiniBrowser/gtk/BrowserTab.h: Added.
3537         * MiniBrowser/gtk/BrowserWindow.c:
3538         (getExternalURI):
3539         (browserWindowSetStatusText):
3540         (reloadOrStopCallback):
3541         (goBackCallback):
3542         (goForwardCallback):
3543         (settingsCallback):
3544         (webViewURIChanged):
3545         (browserWindowHistoryItemActivated):
3546         (browserWindowUpdateNavigationActions):
3547         (webViewCreate):
3548         (webViewEnterFullScreen):
3549         (webViewLeaveFullScreen):
3550         (webViewDecidePolicy):
3551         (browserWindowCanZoomIn):
3552         (browserWindowCanZoomOut):
3553         (browserWindowZoomIn):
3554         (browserWindowZoomOut):
3555         (scrollEventCallback):
3556         (faviconChanged):
3557         (webViewIsLoadingChanged):
3558         (defaultZoomCallback):
3559         (searchCallback):
3560         (newTabCallback):
3561         (toggleWebInspector):
3562         (reloadPage):
3563         (reloadPageIgnoringCache):
3564         (stopPageLoad):
3565         (loadHomePage):
3566         (editingCommandCallback):
3567         (insertImageCommandCallback):
3568         (insertLinkCommandCallback):
3569         (browserWindowSetupEditorToolbar):
3570         (browserWindowSwitchTab):
3571         (browserWindowTabAddedOrRemoved):
3572         (browser_window_init):
3573         (browserWindowConstructed):
3574         (browserWindowSaveSession):
3575         (browserWindowDeleteEvent):
3576         (browser_window_new):
3577         (browser_window_append_view):
3578         (browser_window_load_uri):
3579         (browser_window_load_session):
3580         (browser_window_set_background_color):
3581         (resetStatusText): Deleted.
3582         (activateUriEntryCallback): Deleted.
3583         (webViewTitleChanged): Deleted.
3584         (resetEntryProgress): Deleted.
3585         (browserWindowCreateBackForwardMenu): Deleted.
3586         (webViewReadyToShow): Deleted.
3587         (webViewLoadFailed): Deleted.
3588         (webViewMouseTargetChanged): Deleted.
3589         (browserWindowUpdateZoomActions): Deleted.
3590         (webViewZoomLevelChanged): Deleted.
3591         (updateUriEntryIcon): Deleted.
3592         (zoomInCallback): Deleted.
3593         (zoomOutCallback): Deleted.
3594         (toggleFullScreen): Deleted.
3595         (browserWindowEditingCommandToggleButtonSetActive): Deleted.
3596         (browserWindowFinalize): Deleted.
3597         (browser_window_class_init): Deleted.
3598         * MiniBrowser/gtk/BrowserWindow.h:
3599         * MiniBrowser/gtk/CMakeLists.txt:
3600         * MiniBrowser/gtk/main.c:
3601         (createBrowserTab):
3602         (aboutURISchemeRequestCallback):
3603         (main):
3604         (parseBackgroundColor): Deleted.
3605
3606 2016-07-14  Alex Christensen  <achristensen@webkit.org>
3607
3608         Allow RefPtrs of const RefCounted types
3609         https://bugs.webkit.org/show_bug.cgi?id=158269
3610
3611         Reviewed by Anders Carlsson.
3612
3613         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
3614         (TestWebKitAPI::TEST):
3615         (TestWebKitAPI::ConstRefCounted::create):
3616         (TestWebKitAPI::returnConstRefCountedRef):
3617         (TestWebKitAPI::returnRefCountedRef):
3618
3619 2016-07-13  Carlos Garcia Campos  <cgarcia@igalia.com>
3620
3621         Test WTF.StringViewIterators is crashing since r203119
3622         https://bugs.webkit.org/show_bug.cgi?id=159710
3623
3624         Reviewed by Darin Adler.
3625
3626         There are two problems in the test case added in r203119. First is that it's testing
3627         StringView::CodeUnits::Iterator instead of StringView::CodePoints::Iterator, and second is that
3628         StringView::codePoints() returns a temporary, so the iterator created from the temporary ends up pointing to a