Move two MiniBrowserBundle settings out of the .pbxproj
[WebKit-https.git] / Tools / ChangeLog
1 2017-02-10  Andy Estes  <aestes@apple.com>
2
3         Move two MiniBrowserBundle settings out of the .pbxproj
4         https://bugs.webkit.org/show_bug.cgi?id=168106
5
6         Reviewed by Tim Horton.
7
8         INFOPLIST_FILE was specified in MiniBrowserBundle.xcconfig but overridden to "" in
9         the project file. This removes the project file override.
10
11         WRAPPER_EXTENSION was moved from the project file to MiniBrowserBundle.xcconfig.
12
13         * MiniBrowser/Configurations/MiniBrowserBundle.xcconfig:
14         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
15
16 2017-02-10  Alex Christensen  <achristensen@webkit.org>
17
18         Fix 32-and-64-bit build on El Capitan.
19
20         * Scripts/build-webkit:
21         Somebody's building with something like this:
22         build-webkit ARCHS="i386 x86_64"
23         We want this to also not build libwebrtc for now.
24
25 2017-02-10  Alex Christensen  <achristensen@webkit.org>
26
27         Fix 32-bit build on El Capitan.
28
29         * Scripts/build-webkit:
30         The bot uses ARCHS=i386 instead of --32-bit.
31         This is a hack, but it should fix the bot until I can do a better fix in the morning.
32
33 2017-02-10  Alex Christensen  <achristensen@webkit.org>
34
35         Fix 32-bit build on El Capitan.
36
37         * Scripts/build-webkit:
38         Don't build i386 libwebrtc.
39
40 2017-02-09  Alex Christensen  <achristensen@webkit.org>
41
42         Unreviewed, rolling out r212040.
43
44         Broke build.  I'm not surprised
45
46         Reverted changeset:
47
48         "[WebRTC][Mac] Activate libwebrtc"
49         https://bugs.webkit.org/show_bug.cgi?id=167293
50         http://trac.webkit.org/changeset/212040
51
52 2017-02-09  Alex Christensen  <achristensen@webkit.org>
53
54         Build libwebrtc on bots without using it yet
55         https://bugs.webkit.org/show_bug.cgi?id=168062
56
57         Reviewed by Brent Fulgham.
58
59         * Scripts/build-webkit:
60
61 2017-02-09  Alex Christensen  <achristensen@webkit.org>
62
63         Don't build libwebrtc.
64
65         * Scripts/build-webkit:
66         Not ready yet.  It broke El Capitan and iOS.
67
68 2017-02-09  Alex Christensen  <achristensen@webkit.org>
69
70         Build libwebrtc on bots without using it yet
71         https://bugs.webkit.org/show_bug.cgi?id=168062
72
73         Reviewed by Brent Fulgham.
74
75         * Scripts/build-webkit:
76
77 2017-02-09  Alex Christensen  <achristensen@webkit.org>
78
79         Rename isAppleMacWebKit to isAppleCocoaWebKit
80         https://bugs.webkit.org/show_bug.cgi?id=168075
81
82         Reviewed by Geoffrey Garen.
83
84         It returns true for Mac and iOS.  "isAppleMacWebKit" is confusing and wrong.
85
86         * Scripts/build-api-tests:
87         * Scripts/build-dumprendertree:
88         * Scripts/build-jsc:
89         (buildMyProject):
90         * Scripts/build-layouttestrelay:
91         * Scripts/build-webkit:
92         * Scripts/build-webkittestrunner:
93         * Scripts/run-api-tests:
94         (isSupportedPlatform):
95         (runTest):
96         (listAllTests):
97         (prepareEnvironmentForRunningTestTool):
98         * Scripts/run-content-extension-tester:
99         * Scripts/run-javascriptcore-tests:
100         * Scripts/run-minibrowser:
101         * Scripts/show-pretty-diff:
102         * Scripts/webkitdirs.pm:
103         (determineBaseProductDir):
104         (determineArchitecture):
105         (determinePassedArchitecture):
106         (safariPath):
107         (builtDylibPathForName):
108         (checkFrameworks):
109         (isAppleWebKit):
110         (isAppleCocoaWebKit):
111         (determineNmPath):
112         (launcherName):
113         (wrapperPrefixIfNeeded):
114         (isCMakeBuild):
115         (mobileSafariBundle):
116         (debugSafari):
117         (runSafari):
118         (runMiniBrowser):
119         (debugMiniBrowser):
120         (runWebKitTestRunner):
121         (debugWebKitTestRunner):
122         (isAppleMacWebKit): Deleted.
123         * Scripts/webkitperl/FeatureList.pm:
124
125 2017-02-09  Alex Christensen  <achristensen@webkit.org>
126
127         Revert r211991
128         https://bugs.webkit.org/show_bug.cgi?id=168062
129
130         * Scripts/build-webkit:
131         Not quite ready yet.
132
133 2017-02-09  Alex Christensen  <achristensen@webkit.org>
134
135         Build libwebrtc on bots without using it yet
136         https://bugs.webkit.org/show_bug.cgi?id=168062
137
138         Reviewed by Brent Fulgham.
139
140         * Scripts/build-webkit:
141         Build libwebrtc on Mac when we build ANGLE.
142
143 2017-02-09  Youenn Fablet  <youenn@apple.com>
144
145         Improve W3C importer command line options
146         https://bugs.webkit.org/show_bug.cgi?id=167448
147
148         Reviewed by Ryosuke Niwa.
149
150         Making the list of test paths to import the main arguments of the script.
151         Allow passing the source directory to import as a -s option.
152         Adding a warning when given test paths are skipped by default in ImportExpectations.
153
154         Making link conversion off by default when importing from a specific directory since this script is mostly used with web-platform-tests.
155         Link conversion rules do not change when imported tests are downloaded by the script.
156
157         * Scripts/webkitpy/w3c/test_importer.py:
158         (main):
159         (parse_args):
160         (TestImporter.__init__):
161         (TestImporter.do_import):
162         (TestImporter):
163         (TestImporter.check_imported_expectations):
164
165 2017-02-08  Chris Dumez  <cdumez@apple.com>
166
167         Update web-platform-tests resources
168         https://bugs.webkit.org/show_bug.cgi?id=168026
169
170         Reviewed by Youenn Fablet.
171
172         Stop copying testharness.js from resources/ to web-platform-tests/resources.
173
174         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
175         (WebPlatformTestServer._copy_webkit_test_files):
176
177 2017-02-08  Andy Estes  <aestes@apple.com>
178
179         Custom protocols should not continue loading after a network process crash
180         https://bugs.webkit.org/show_bug.cgi?id=168028
181         <rdar://problem/27607520>
182
183         Reviewed by Brady Eidson.
184
185         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
186         (processGroup):
187         (-[CloseWhileStartingProtocol startLoading]):
188         (-[CloseWhileStartingProtocol stopLoading]):
189         (TestWebKitAPI::runTest):
190         (TestWebKitAPI::TEST):
191
192 2017-02-08  Dan Bernstein  <mitz@apple.com>
193
194         [Cocoa] WKRemoteObjectCoder doesn’t handle CGSize
195         https://bugs.webkit.org/show_bug.cgi?id=168031
196
197         Reviewed by Tim Horton.
198
199         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h:
200         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
201         (TEST):
202         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
203         (-[RemoteObjectRegistryPlugIn takeSize:completionHandler:]):
204
205 2017-02-08  Chris Dumez  <cdumez@apple.com>
206
207         Use smaller tiles in windows that are not active to facilitate App Napping
208         https://bugs.webkit.org/show_bug.cgi?id=167997
209         <rdar://problem/30358835>
210
211         Reviewed by Simon Fraser.
212
213         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
214         (WTR::PlatformWebView::setWindowIsKey):
215         Actually update windowIsKey state of NSWindow so the WebView
216         properly updates its activity state.
217
218 2017-02-08  Wenson Hsieh  <wenson_hsieh@apple.com>
219
220         Add kUTTypeUTF8PlainText and kUTTypeJPEG to the list of compatible content types in DragData
221         https://bugs.webkit.org/show_bug.cgi?id=167942
222         <rdar://problem/30315079>
223
224         Reviewed by Tim Horton.
225
226         Adds a new test case that simulates dragging from a source that only vends JPEG images or UTF8 plaintext into a
227         contenteditable area. An image element and the plain text content, respectively, should be inserted into the
228         contenteditable in these cases.
229
230         The DragSource and DragInfo are used to mock dragging into the WebView. There is no reliance on using mouse
231         events in this test, since we call the dragging delegate methods (draggingEntered:, draggingUpdated:, and
232         performDragOperation:) directly.
233
234         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
235         * TestWebKitAPI/Tests/mac/DragAndDropPasteboardTests.mm: Added.
236         (+[FrameLoadCompletionListener listenerWithCompletionBlock:]):
237         (-[FrameLoadCompletionListener initWithCompletionBlock:]):
238         (-[FrameLoadCompletionListener webView:didFinishLoadForFrame:]):
239         (-[DragSource draggingSourceOperationMaskForLocal:]):
240         (-[DragInfo initWithImage:offset:pasteboard:source:destinationWindow:]):
241         (-[DragInfo lastMousePosition]):
242         (-[DragInfo setLastMousePosition:]):
243         (-[DragInfo draggingDestinationWindow]):
244         (-[DragInfo draggingSourceOperationMask]):
245         (-[DragInfo draggingLocation]):
246         (-[DragInfo draggedImageLocation]):
247         (-[DragInfo draggedImage]):
248         (-[DragInfo draggingPasteboard]):
249         (-[DragInfo draggingSource]):
250         (-[DragInfo draggingSequenceNumber]):
251         (-[DragInfo slideDraggedImageTo:]):
252         (-[DragInfo namesOfPromisedFilesDroppedAtDestination:]):
253         (-[DragInfo draggingFormation]):
254         (-[DragInfo setDraggingFormation:]):
255         (-[DragInfo animatesToDestination]):
256         (-[DragInfo setAnimatesToDestination:]):
257         (-[DragInfo numberOfValidItemsForDrop]):
258         (-[DragInfo setNumberOfValidItemsForDrop:]):
259         (-[DragInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
260         (-[DragInfo springLoadingHighlight]):
261         (-[DragInfo resetSpringLoading]):
262         (TestWebKitAPI::getTestImage):
263         (TestWebKitAPI::webViewAfterPerformingDragOperation):
264         (TestWebKitAPI::TEST):
265         * TestWebKitAPI/Tests/mac/full-page-contenteditable.html: Added.
266
267 2017-02-08  Jer Noble  <jer.noble@apple.com>
268
269         Move FullscreenClient creation into WebViewImpl, for use in (deprecated) WKView.
270         https://bugs.webkit.org/show_bug.cgi?id=168007
271
272         Reviewed by Alex Christensen.
273
274         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenDelegate.mm:
275         (didFinishLoadForFrame):
276         (TestWebKitAPI::TEST):
277
278 2017-02-08  Commit Queue  <commit-queue@webkit.org>
279
280         Unreviewed, rolling out r211873.
281         https://bugs.webkit.org/show_bug.cgi?id=168001
282
283         It's in jhbuild for consistent layout tests (Requested by
284         mcatanzaro on #webkit).
285
286         Reverted changeset:
287
288         "[GTK] Add icu packages to Tools/gtk/install-dependencies"
289         https://bugs.webkit.org/show_bug.cgi?id=167993
290         http://trac.webkit.org/changeset/211873
291
292 2017-02-08  Adrian Perez de Castro  <aperez@igalia.com>
293
294         [GTK] Add icu packages to Tools/gtk/install-dependencies
295         https://bugs.webkit.org/show_bug.cgi?id=167993
296
297         Reviewed by Michael Catanzaro.
298
299         * gtk/install-dependencies: Add "icu" to the list of required packages (or "icu-dev", or "icu-devel"
300         depending in the GNU/Linux distribution)
301
302 2017-02-07  Ryan Haddad  <ryanhaddad@apple.com>
303
304         Update flakiness dashboard configuration.
305         https://bugs.webkit.org/show_bug.cgi?id=167957
306
307         Reviewed by Alexey Proskuryakov.
308
309         * TestResultServer/static-dashboards/builders.jsonp:
310
311 2017-02-07  Ryan Haddad  <ryanhaddad@apple.com>
312
313         Replace a bot that has an incorrect configuration.
314         https://bugs.webkit.org/show_bug.cgi?id=167747
315
316         Rubber-stamped by Alexey Proskuryakov.
317
318         * BuildSlaveSupport/build.webkit.org-config/config.json:
319
320 2017-02-07  Myles C. Maxfield  <mmaxfield@apple.com>
321
322         [Win] [GTK] [EFL] Compile (but don't use, yet) the platform-independent piece of ComplexTextController
323         https://bugs.webkit.org/show_bug.cgi?id=167927
324
325         Reviewed by Brent Fulgham.
326
327         Enable ComplexTextController API tests on the Win and GTK ports.
328
329         * TestWebKitAPI/PlatformGTK.cmake:
330         * TestWebKitAPI/PlatformWin.cmake:
331
332 2017-02-07  Jonathan Bedard  <jbedard@apple.com>
333
334         File index appended to previous file in svn-create-patch with SVN 1.9
335         https://bugs.webkit.org/show_bug.cgi?id=167903
336         <rdar://problem/30387395>
337
338         Reviewed by Daniel Bates.
339
340         * Scripts/VCSUtils.pm:
341         (fixSVNPatchForAdditionWithHistory): Append a trailing newline character.
342         * Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl: Do not remove
343         trailing newline character from the expected result before comparing it to the actual result.
344
345 2017-02-07  Olivier Blin  <olivier.blin@softathome.com>
346
347         [webkitdirs] remove unused host_processor variable in determineArchitecture()
348         https://bugs.webkit.org/show_bug.cgi?id=167936
349
350         Reviewed by Michael Catanzaro.
351
352         * Scripts/webkitdirs.pm:
353         (determineArchitecture):
354         The host_processor variable in webkitdirs.pm's determineArchitecture() is not used anymore,
355         since r195083.
356
357 2017-02-07  Youenn Fablet  <youenn@apple.com>
358
359         Use a JSON file to define which WPT files/folders to import
360         https://bugs.webkit.org/show_bug.cgi?id=167923
361
362         Reviewed by Alex Christensen.
363
364         * Scripts/webkitpy/w3c/test_downloader.py:
365         (TestDownloader.__init__):
366         (TestDownloader._init_paths_from_expectations):
367         * Scripts/webkitpy/w3c/test_importer.py:
368         (parse_args):
369         * Scripts/webkitpy/w3c/test_importer_unittest.py:
370
371 2017-02-06  Fujii Hironori  <Hironori.Fujii@sony.com>
372
373         [GTK] jhbuild fails: mesa-11.0.6.tar.xz: 404 Not Found
374         https://bugs.webkit.org/show_bug.cgi?id=167916
375
376         Reviewed by Carlos Garcia Campos.
377
378         URL of mesa-11.0.6.tar.xz has been moved.
379
380         * gtk/jhbuild.modules: Fix the module path.
381
382 2017-02-06  Joseph Pecoraro  <pecoraro@apple.com>
383
384         Static Analyzer: Address some leaks in MiniBrowser
385         https://bugs.webkit.org/show_bug.cgi?id=167897
386
387         Reviewed by Alexey Proskuryakov.
388
389         * MiniBrowser/mac/BrowserWindowController.m:
390         (-[BrowserWindowController sharingService:transitionImageForShareItem:contentRect:]):
391         * MiniBrowser/mac/ExtensionManagerWindowController.m:
392         (-[ExtensionManagerWindowController add:]):
393         (-[ExtensionManagerWindowController remove:]):
394         * MiniBrowser/mac/SettingsController.m:
395         (-[SettingsController _populateMenu]):
396         (-[SettingsController togglePerWindowWebProcessesDisabled:]):
397         Address obvious leaks caught by the static analyzer.
398
399 2017-02-06  Myles C. Maxfield  <mmaxfield@apple.com>
400
401         Migrate ComplexTextController to use platform-independent types
402         https://bugs.webkit.org/show_bug.cgi?id=167833
403
404         Reviewed by Brent Fulgham.
405
406         Migrate tests away from platform-dependent types.
407
408         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
409         (TestWebKitAPI::TEST_F):
410
411 2017-02-06  Brent Fulgham  <bfulgham@apple.com>
412
413         Correct File Path Handling in SecurityOrigin and FileSystem
414         https://bugs.webkit.org/show_bug.cgi?id=167894
415         <rdar://problem/30380080>
416
417         Reviewed by Alexey Proskuryakov.
418
419         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp: Don't encode the temporary files,
420         and perform same-volume checks using filesystem-compatible paths.        
421         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp: Create SecurityOrigins from
422         filesystem paths, and perform validation of same-volume checks.
423         (TestWebKitAPI::SecurityOriginTest::tempFilePath): Added.
424         (TestWebKitAPI::SecurityOriginTest::spaceContainingFilePath): Added.
425         (TestWebKitAPI::SecurityOriginTest::bangContainingFilePath): Added.
426         (TestWebKitAPI::SecurityOriginTest::quoteContainingFilePath): Added.
427
428 2017-02-06  Jer Noble  <jer.noble@apple.com>
429
430         Playback stalls when a SourceBuffer append causes frame eviction
431         https://bugs.webkit.org/show_bug.cgi?id=167834
432
433         Reviewed by Eric Carlson.
434
435         Add new correctness tests for the Webcore::SampleMap class. Add additional subtests
436         for the WTF::MediaTime class.
437
438         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
439         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
440         (TestWebKitAPI::TEST):
441         * TestWebKitAPI/Tests/WebCore/SampleMap.cpp: Added.
442         (WTF::operator<<):
443         (TestWebKitAPI::TestSample::create):
444         (TestWebKitAPI::TestSample::TestSample):
445         (TestWebKitAPI::TEST_F):
446
447 2017-02-06  Ryan Haddad  <ryanhaddad@apple.com>
448
449         Change capitalization in platform name after r211735.
450
451         Unreviewed dashboard fix.
452
453         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
454         (WebKitBuildbot):
455
456 2017-02-06  Alexey Proskuryakov  <ap@apple.com>
457
458         Move the Leaks bot to Sierra
459         https://bugs.webkit.org/show_bug.cgi?id=167886
460
461         Reviewed by Daniel Bates.
462
463         * BuildSlaveSupport/build.webkit.org-config/config.json:
464         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
465         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
466         (LeaksViewer._displayURLPrompt):
467         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
468         (WebKitBuildbot):
469
470 2017-02-06  Jonathan Bedard  <jbedard@apple.com>
471
472         Prevent app crash on launch during simctl install workaround
473         https://bugs.webkit.org/show_bug.cgi?id=167685
474
475         Reviewed by Daniel Bates.
476
477         * Scripts/webkitpy/port/simulator_process.py:
478         (SimulatorProcess.__init__): Pass environment to install.
479         * Scripts/webkitpy/xcode/simulator.py:
480         (Device.install_app): Accept environment, pass environment to launch.
481
482 2017-02-06  Alex Christensen  <achristensen@webkit.org>
483
484         Rebase API tests after r211638
485         https://bugs.webkit.org/show_bug.cgi?id=167779
486
487         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
488         (TestWebKitAPI::TEST_F):
489         URLs with non-special schemes and characters like % in the host now fail to parse,
490         more like their special counterparts and according to spec.
491
492 2017-02-06  Csaba Osztrogonác  <ossy@webkit.org>
493
494         Unreviewed trivial fix after r211697.
495         https://bugs.webkit.org/show_bug.cgi?id=167863
496
497         * Scripts/run-javascriptcore-tests:
498         (runJSCStressTests): Renamed ES6SampleBench to ARES-6.
499
500 2017-02-04  Simon Fraser  <simon.fraser@apple.com>
501
502         Clean up how GraphicsLayer's "inWindow" state is set, and fix some issues with Page Overlays
503         https://bugs.webkit.org/show_bug.cgi?id=167850
504
505         Reviewed by Tim Horton.
506
507         * DumpRenderTree/TestRunner.cpp:
508         (TestRunner::uiScriptDidComplete): Fix an assertion that fires for non-16-bit strings.
509
510 2017-02-04  Andreas Kling  <akling@apple.com>
511
512         Plug some leaks in TestController and UIScriptContext.
513         <https://webkit.org/b/167839>
514
515         Reviewed by Alexey Proskuryakov.
516
517         Fix a couple of the leaks seen on the leaks bot.
518
519         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
520         (UIScriptContext::runUIScript):
521         * WebKitTestRunner/TestController.cpp:
522         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin):
523         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible):
524
525 2017-02-03  Jeremy Jones  <jeremyj@apple.com>
526
527         WK1 mouse events are missing movementX and movementY for pointerlock.
528         https://bugs.webkit.org/show_bug.cgi?id=167775
529         rdar://problem/30343810
530
531         Reviewed by Alexey Proskuryakov.
532
533         Set kCGMouseEventDeltaX and kCGMouseEventDeltaY when synthesizing mouse move events.
534
535         * DumpRenderTree/mac/EventSendingController.mm:
536         (-[EventSendingController mouseMoveToX:Y:]):
537         * WebKitTestRunner/mac/EventSenderProxy.mm:
538         (WTR::EventSenderProxy::mouseMoveTo):
539
540 2017-02-03  Simon Fraser  <simon.fraser@apple.com>
541
542         Correctly set the "inWindow" flag for TileControllers that aren't the page tiles, and clarify "usingTiledBacking" logic
543         https://bugs.webkit.org/show_bug.cgi?id=167774
544
545         Reviewed by Tim Horton.
546
547         Implement UIScriptController removeViewFromWindow() and addViewToWindow(), and hook
548         up for Mac WK1 and WK2, and iOS WK2. It takes a callback because view state updates to the
549         web process are async, so the callback fires after the web process gets the new state.
550
551         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
552         (WTR::UIScriptController::removeViewFromWindow):
553         (WTR::UIScriptController::addViewToWindow):
554         * DumpRenderTree/mac/DumpRenderTree.mm:
555         (createWebViewAndOffscreenWindow):
556         (resetWebViewToConsistentStateBeforeTesting):
557         * DumpRenderTree/mac/DumpRenderTreeMac.h:
558         * DumpRenderTree/mac/UIScriptControllerMac.mm:
559         (WTR::UIScriptController::removeViewFromWindow):
560         (WTR::UIScriptController::addViewToWindow):
561         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
562         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
563         (WTR::UIScriptController::removeViewFromWindow):
564         (WTR::UIScriptController::addViewToWindow):
565         * TestRunnerShared/UIScriptContext/UIScriptController.h:
566         * WebKitTestRunner/PlatformWebView.h:
567         * WebKitTestRunner/TestController.cpp:
568         (WTR::TestController::resetStateToConsistentValues):
569         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
570         (WTR::PlatformWebView::removeFromWindow):
571         (WTR::PlatformWebView::addToWindow):
572         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
573         (WTR::UIScriptController::removeViewFromWindow):
574         (WTR::UIScriptController::addViewToWindow):
575         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
576         (WTR::PlatformWebView::removeFromWindow):
577         (WTR::PlatformWebView::addToWindow):
578         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
579         (WTR::UIScriptController::removeViewFromWindow):
580         (WTR::UIScriptController::addViewToWindow):
581
582 2017-02-03  Alexey Proskuryakov  <ap@apple.com>
583
584         Remove check for SkipSafariExecutableEntitlementChecks
585         https://bugs.webkit.org/show_bug.cgi?id=167762
586
587         Reviewed by Dan Bernstein.
588
589         Follow-up fix: don't break internal behavior.
590
591         * Scripts/webkitdirs.pm:
592         (safariPath):
593         (executableHasEntitlements): Deleted.
594         (safariPathFromSafariBundle): Deleted.
595         (installedSafariPath): Deleted.
596
597 2017-02-03  Daniel Bates  <dabates@apple.com>
598
599         [Mac][WK2] Add SPI to override the Content Security Policy of a page
600         https://bugs.webkit.org/show_bug.cgi?id=167810
601         <rdar://problem/30102568>
602
603         Reviewed by Anders Carlsson.
604
605         Add tests to ensure that we do not regress -[WKWebView _setOverrideContentSecurityPolicy:].
606
607         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
608         * TestWebKitAPI/Tests/WebKit2Cocoa/OverrideContentSecurityPolicy.mm: Added.
609         (TEST):
610         * TestWebKitAPI/Tests/WebKit2Cocoa/page-with-csp-iframe.html: Added.
611         * TestWebKitAPI/Tests/WebKit2Cocoa/page-with-csp.html: Added.
612         * TestWebKitAPI/Tests/WebKit2Cocoa/page-without-csp-iframe.html: Added.
613         * TestWebKitAPI/Tests/WebKit2Cocoa/page-without-csp.html: Added.
614
615 2017-02-02  Alex Christensen  <achristensen@webkit.org>
616
617         URLParser: Fix parsing invalid IPv4 addresses with non-ASCII characters
618         https://bugs.webkit.org/show_bug.cgi?id=167773
619         <rdar://problem/30221102>
620
621         Reviewed by Ryosuke Niwa.
622
623         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
624         (TestWebKitAPI::TEST_F):
625
626 2017-02-02  Alexey Proskuryakov  <ap@apple.com>
627
628         Remove check for SkipSafariExecutableEntitlementChecks
629         https://bugs.webkit.org/show_bug.cgi?id=167762
630         rdar://problem/22480673
631
632         Reviewed by Dan Bernstein.
633
634         * Scripts/webkitdirs.pm:
635         (safariPathFromSafariBundle):
636         (skipSafariExecutableEntitlementChecks): Deleted.
637
638 2017-02-02  Jonathan Bedard  <jbedard@apple.com>
639
640         Undefined subroutine in svn-create-patch
641         https://bugs.webkit.org/show_bug.cgi?id=167742
642
643         Unreviewed build-fix after r211543.
644
645         * Scripts/VCSUtils.pm: fixSVNPatchForAdditionWithHistory was not exported.
646
647 2017-02-02  Xabier Rodriguez Calvar  <calvaris@igalia.com>
648
649         Unreviewed. Fix jhbuild dependencies build.
650
651         * gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch:
652         Patch updated.
653
654 2017-02-02  Xabier Rodriguez Calvar  <calvaris@igalia.com>
655
656         [EME][GStreamer] Fixed decryptor selection
657         https://bugs.webkit.org/show_bug.cgi?id=167588
658
659         Reviewed by Žan Doberšek.
660
661         This patches are pending at https://bugzilla.gnome.org/show_bug.cgi?id=770107
662
663         * gtk/jhbuild.modules: Added patches to gstreamer and
664         gst-plugins-good packages.
665         * gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch: Added.
666         * gtk/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Added.
667
668 2017-02-01  Dewei Zhu  <dewei_zhu@apple.com>
669
670         Make run-benchmark script supports 'config' key in test plan.
671         https://bugs.webkit.org/show_bug.cgi?id=167715
672
673         Reviewed by Ryosuke Niwa.
674
675         Add support for 'config' key in test paln.
676         'config' key is a dictionary that specifies environment configurations while test is running.
677         Specifies orientation to be portrait in MotionMark benchmark.
678
679         * Scripts/webkitpy/benchmark_runner/README.md:
680         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
681         (BenchmarkRunner.__init__):
682         (BenchmarkRunner._run_benchmark):
683         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
684         (BrowserDriver.prepare_env):
685         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
686         (LinuxBrowserDriver.prepare_env):
687         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
688         (OSXBrowserDriver.prepare_env):
689         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
690         (OSXSafariDriver.prepare_env):
691         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan:
692
693 2017-02-01  Daniel Bates  <dabates@apple.com>
694
695         REGRESSION (r210820): svn-create-patch does not emit property change only diff
696         https://bugs.webkit.org/show_bug.cgi?id=167169
697
698         Reviewed by David Kilzer.
699
700         More directly handle the SVN 1.9 or newer syntax change for a diff of a copied or moved file
701         - a SVN diff header and an empty body. In particular, remove a duplicate leading SVN diff
702         header from the output of "svn diff" on a file that was copied or moved.
703
704         Following r210820 svn-create-patch emits to standard output a diff only if it has at least one
705         chunk range line (e.g. @@ -0,0 +1,7 @@) as a means to workaround a syntax change in the diff
706         output of a copied or moved file in SVN version 1.9 or newer. In SVN 1.9 or newer "svn diff"
707         of a copied or moved file always emits to standard output a leading SVN diff header (an "Index:"
708         line followed by a separator line) with an empty body; => no chunk range lines. However a diff
709         of a file with only a property change also does not contain any chunk range lines. Therefore
710         svn-create-patch no longer emitted to standard output such a diff. Instead of indirectly detecting
711         a SVN diff header with an empty body by counting the number of chunk range lines in the diff
712         we should directly test for the presence of a leading SVN diff header with an empty body and
713         remove such lines from the diff.
714
715         * Scripts/VCSUtils.pm:
716         (fixSVNPatchForAdditionWithHistory): Added.
717         * Scripts/svn-create-patch:
718         (generateDiff): Pass the output from "svn diff" to fixSVNPatchForAdditionWithHistory() when
719         we have a non empty patch for an added file with history (i.e. a copied or moved file).
720         * Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl: Added.
721
722 2017-02-01  Eric Carlson  <eric.carlson@apple.com>
723
724         [Mac] Update CARingBuffer class
725         https://bugs.webkit.org/show_bug.cgi?id=167656
726
727         Reviewed by Jer Noble.
728
729         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
730         * TestWebKitAPI/Tests/WebCore/CARingBuffer.cpp: Added.
731         (TestWebKitAPI::CARingBufferTest::SetUp):
732         (TestWebKitAPI::CARingBufferTest::setup):
733         (TestWebKitAPI::CARingBufferTest::setListDataBuffer):
734         (TestWebKitAPI::CARingBufferTest::description):
735         (TestWebKitAPI::CARingBufferTest::bufferList):
736         (TestWebKitAPI::CARingBufferTest::ringBuffer):
737         (TestWebKitAPI::CARingBufferTest::capacity):
738         (TestWebKitAPI::CARingBufferTest::audioBufferListSizeForStream):
739         (TestWebKitAPI::CARingBufferTest::configureBufferListForStream):
740         (TestWebKitAPI::TEST_F):
741         (TestWebKitAPI::MixingTest::run):
742
743 2017-02-01  Alexey Proskuryakov  <ap@apple.com>
744
745         [Mac] TestWebKitAPI includes system frameworks incorrectly
746         https://bugs.webkit.org/show_bug.cgi?id=167703
747         rdar://problem/30301498
748
749         Reviewed by Ryosuke Niwa.
750
751         FRAMEWORK_SEARCH_PATH results in frameworks being treated as user ones, not system.
752         Make TestWebKitAPI use -iframework instead, like the rest of WebKit does.
753
754         Also, reduced the number of subframework search paths, looks like we only need one now.
755
756         * TestWebKitAPI/Configurations/Base.xcconfig:
757
758 2017-02-01  Brent Fulgham  <bfulgham@apple.com>
759
760         Correct "filesHaveSameVolume" predicate
761         https://bugs.webkit.org/show_bug.cgi?id=167696
762         <rdar://problem/30298722>
763
764         Reviewed by David Kilzer.
765
766         Add new tests that confirm that the 'filesHaveSamePath' predicate properly handles
767         percent-escaped path inputs.
768
769         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp:
770         (TestWebKitAPI::FileSystemTest::spaceContainingFilePath):
771         (TestWebKitAPI::FileSystemTest::bangContainingFilePath):
772         (TestWebKitAPI::FileSystemTest::quoteContainingFilePath):
773         (TestWebKitAPI::TEST_F):
774
775 2017-02-01  Tomas Popela  <tpopela@redhat.com>
776
777         Unreviewed. Fix coding style in MiniBrowser
778
779         * MiniBrowser/gtk/BrowserWindow.c:
780         (editingCommandCallback):
781         (insertImageCommandCallback):
782         (insertLinkCommandCallback):
783
784 2017-02-01  Tomas Popela  <tpopela@redhat.com>
785
786         [GTK] Add an API to add a custom tab into the print dialog
787         https://bugs.webkit.org/show_bug.cgi?id=151998
788
789         Reviewed by Carlos Garcia Campos.
790
791         Add a new WebKitPrintOperation/custom-widget test in TestPrinting
792         that is testing a newly added API.
793
794         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
795         (testPrintCustomWidget):
796         (beforeAll):
797
798 2017-02-01  Enrique Ocaña González  <eocanha@igalia.com>
799
800         [GStreamer][MSE] qtdemux: Update the tfdt patch to the version finally accepted upstream
801         https://bugs.webkit.org/show_bug.cgi?id=166529
802
803         Reviewed by Xabier Rodriguez-Calvar.
804
805         * gtk/patches/gst-plugins-good-use-the-tfdt-decode-time.patch:
806         New patch version accepted in GStreamer upstream.
807
808 2017-02-01  Xabier Rodriguez Calvar  <calvaris@igalia.com>
809
810         [GTK] Install either libxfont1-dev or libxfont-dev as dependency
811         https://bugs.webkit.org/show_bug.cgi?id=167498
812
813         Reviewed by Carlos Garcia Campos.
814
815         Depending on the distro version you can need either libxfont1-dev
816         or libfont-dev to build with jhbuild.
817
818         * gtk/install-dependencies:
819
820 2017-01-31  Ryan Haddad  <ryanhaddad@apple.com>
821
822         Disable API test WebKit2.WKWebProcessPlugInRangeHandle
823         https://bugs.webkit.org/show_bug.cgi?id=167594
824
825         Unreviewed test gardening.
826
827         Disabling this test while we investigate the cause of a timeout on ios-simulator.
828
829         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm:
830         (TEST):
831
832 2017-01-31  Filip Pizlo  <fpizlo@apple.com>
833
834         Move slow-running microbenchmarks out of JSTests/microbenchmarks
835         https://bugs.webkit.org/show_bug.cgi?id=167676
836
837         Reviewed by Saam Barati.
838
839         * Scripts/run-javascriptcore-tests:
840         (runJSCStressTests): Add slowMicrobenchmarks.yaml.
841
842 2017-01-31  Megan Gardner  <megan_gardner@apple.com>
843
844         Make Dump Render Tree not crash
845         https://bugs.webkit.org/show_bug.cgi?id=167667
846
847         DumpRenderTree is crashing when running WK2 tests that it's not supposed to be running. 
848         DumpRenderTree uses RunLoop::main.dispatch(), but that crashes because it's not set up on iOS.
849         So we're making use of RunWebThread, which is the correct thing to do on iOS, and it doesn't crash.
850         This does not fix any tests, it just fixes the crash.
851         
852         Reviewed by Simon Fraser.
853
854         * DumpRenderTree/TestRunner.cpp:
855         (TestRunner::callUIScriptCallback):
856
857 2017-01-31  Jonathan Bedard  <jbedard@apple.com>
858
859         Workaround for simctl install failing to report install failure
860         https://bugs.webkit.org/show_bug.cgi?id=167654
861
862         Reviewed by Daniel Bates.
863
864         simctl install will sometimes report success even though install has failed.
865         To workaround this bug, we attempt an app launch after install to ensure
866         install has succeeded.
867
868         * Scripts/webkitpy/xcode/simulator.py:
869         (Device.install_app): Attempt app launch after install, retry install if launch fails.
870         (Device.launch_app): Correct comment.
871
872 2017-01-31  Jonathan Bedard  <jbedard@apple.com>
873
874         Unreviewed webkitpy fix after r211405.
875
876         * Scripts/webkitpy/xcode/simulator.py:
877         (Device.launch_app): Remove @staticmethod on _log_debug_error.
878
879 2017-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
880
881         Unreviewed. Do not include libwebrtc and qunit in GTK+ tarballs.
882
883         * gtk/manifest.txt.in:
884
885 2017-01-31  Chris Fleizach  <cfleizach@apple.com>
886
887         AX: enable search predication for iOS
888         https://bugs.webkit.org/show_bug.cgi?id=167558
889         <rdar://problem/30251367>
890
891         Reviewed by Joanmarie Diggs.
892
893         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
894         (AccessibilityUIElement::uiElementForSearchPredicate):
895         * DumpRenderTree/mac/AccessibilityCommonMac.h:
896         * DumpRenderTree/mac/AccessibilityCommonMac.mm:
897         (searchPredicateParameterizedAttributeForSearchCriteria):
898         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
899         (searchPredicateParameterizedAttributeForSearchCriteria): Deleted.
900         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
901         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
902         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
903         * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.h:
904         * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.mm:
905         (WTR::searchPredicateParameterizedAttributeForSearchCriteria):
906         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
907         (WTR::searchPredicateParameterizedAttributeForSearchCriteria): Deleted.
908         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
909
910 2017-01-30  Jonathan Bedard  <jbedard@apple.com>
911
912         Workaround for simctl launch bug
913         https://bugs.webkit.org/show_bug.cgi?id=167613
914
915         Reviewed by Daniel Bates.
916
917         simctl launch will sometimes fail because of a race condition when many
918         simulators are being run simultaneously. These failures will always have
919         an exit code of 1. This change attempts to launch an app multiple times
920         before reporting a failure to workaround this bug.
921
922         * Scripts/webkitpy/xcode/simulator.py:
923         (Device.launch_app): Execute multiple launch attempts, better logging of failures.
924
925 2017-01-30  Alexey Proskuryakov  <ap@apple.com>
926
927         Commit queue fails to look at real name aliases for the reviewer
928         https://bugs.webkit.org/show_bug.cgi?id=167422
929
930         Reviewed by Joseph Pecoraro.
931
932         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
933         (test_has_valid_reviewer): Added tests.
934
935         * Scripts/webkitpy/common/config/committers.py:
936         (CommitterList._name_to_contributor_map):
937         Made _name_to_contributor_map include alias names.
938
939         * Scripts/webkitpy/common/config/committers_unittest.py:
940         (CommittersTest.test_contributors_by_fuzzy_match):
941         Removed subtests that are now obsolete, as these matches are strict. It is not
942         obvious if distance based fuzzy matching for names is useful at all, but we can
943         look into that some other time.
944
945 2017-01-30  Aakash Jain  <aakash_jain@apple.com>
946
947         QueueStatusServer should have an explicit timeout for _fetch_url
948         https://bugs.webkit.org/show_bug.cgi?id=167467
949
950         Reviewed by Alexey Proskuryakov.
951
952         * Scripts/webkitpy/common/net/statusserver.py:
953         (StatusServer._fetch_url): Add an explicit timeout of 300s.
954
955 2017-01-30  Kocsen Chung  <kocsen_chung@apple.com>
956
957         Add support for Trac instances that host multiple projects.
958         https://bugs.webkit.org/show_bug.cgi?id=167524
959
960         Reviewed by Alexey Proskuryakov.
961
962         When multiple projects are hosted on a single Trac instance, the current
963         behavior will retrieve changesets from all tracked projects.
964         This patch teaches Trac.js to get project-specific changesets from Trac.
965         We do this by replacing the parameter `changeset=on` to `repo-projectname=on`
966         when querying the Trac timeline.
967
968         To tell Trac to be aware of multi-project instances we leverage the 
969         `options` parameter when creating a new instance: 
970
971             new Trac("https://mytrac.com/", { projectIdentifier: "tracProjectName" });
972
973         If this option is not provided, the original behaviour will prevail.
974         Additionally, add corresponding tests.
975
976         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
977         (Trac): Reason about new optional parameter 'projectIdentifier'.
978         (Trac.prototype.revisionURL): Given a projectIdentifier, append it to the end of the URL.
979         (Trac.prototype._xmlTimelineURL): Given a projectIdentifier,
980         replace default parameter `changeset=on` with `repo-projectname=on`.
981         (Trac.prototype._convertCommitInfoElementToObject): Fix missing ';'.
982         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockTrac.js:
983         (MockTrac): Add support for instantiating Trac with a projectIdentifier.
984         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js:
985         (setup): Provide a multiple-project MockTrac instance to all test cases for testing.
986         Add the following tests:
987             test("revisionURL")
988             test("revisionURL with Trac Identifier")
989             test("_xmlTimelineURL")
990             test("_xmlTimelineURL with Trac Identifier")
991         (this.view._latestProductiveIteration): Fix missing ';'.
992
993 2017-01-30  Myles C. Maxfield  <mmaxfield@apple.com>
994
995         Correct spacing regression on inter-element complex path shaping on some fonts
996         https://bugs.webkit.org/show_bug.cgi?id=166013
997
998         Reviewed by Simon Fraser.
999
1000         Unskip existing tests and make some new tests:
1001         - Testing complex text with no origins
1002         - Testing initial expansions
1003         - Testing the sign of vertical advances
1004
1005         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
1006         (TestWebKitAPI::TEST_F):
1007
1008 2017-01-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1009
1010         [GTK][EFL] Avoid using a thin directory to create the built product on the archive-built-product step.
1011         https://bugs.webkit.org/show_bug.cgi?id=167596
1012
1013         Reviewed by Daniel Bates.
1014
1015         We avoid needing a thin directory by invoking the zip program with
1016         the list of directories from the build directory to be zipped,
1017         and by using the zip feature to exclude files matching a pattern.
1018
1019         * BuildSlaveSupport/built-product-archive:
1020         (copyBuildFiles):
1021         (createZipFromList):
1022         (archiveBuiltProduct):
1023
1024 2017-01-30  Jonathan Bedard  <jbedard@apple.com>
1025
1026         Use simctl instead of LayoutTestRelay
1027         https://bugs.webkit.org/show_bug.cgi?id=165927
1028
1029         Reviewed by Daniel Bates.
1030
1031         Part 1
1032
1033         LayoutTestRelay uses SPI, since recent versions of the iOS SDK allow for installing apps on
1034         simulators through simctl (iOS 10 and later), use this functionality instead.
1035
1036         * Scripts/webkitpy/port/base.py:
1037         (Port.__init__): Added _test_runner_process_constructor.
1038         * Scripts/webkitpy/port/darwin.py:
1039         (DarwinPort.app_identifier_from_bundle): Added function to extract bundle ID from plist.
1040         * Scripts/webkitpy/port/driver.py:
1041         (Driver._start): Pass worker_number to server_process so we can look up the correct simulator device to use.
1042         (IOSSimulatorDriver): Deleted.
1043         * Scripts/webkitpy/port/driver_unittest.py:
1044         (DriverTest.test_stop_cleans_up_properly): Set _test_runner_process_constructor for testing.
1045         (DriverTest.test_two_starts_cleans_up_properly): Ditto.
1046         (DriverTest.test_start_actually_starts): Ditto.
1047         * Scripts/webkitpy/port/ios.py:
1048         (IOSSimulatorPort): Remove relay_name.
1049         (IOSSimulatorPort.__init__): Set _test_runner_process_constructor to SimulatorProcess for IOSSimulatorPort.
1050         (IOSSimulatorPort._create_simulators): Formatting change.
1051         (IOSSimulatorPort.relay_path): Deleted.
1052         (IOSSimulatorPort._check_relay): Deleted.
1053         (IOSSimulatorPort._check_port_build): Deleted. Use base class implementation
1054         (IOSSimulatorPort._build_relay): Deleted.
1055         (IOSSimulatorPort._build_driver): Deleted. Use base class implementation
1056         (IOSSimulatorPort._driver_class): Deleted. Use base class implementation
1057         * Scripts/webkitpy/port/ios_unittest.py:
1058         (iosTest.test_32bit): Update test.
1059         (iosTest.test_64bit): Update test.
1060         * Scripts/webkitpy/port/server_process.py:
1061         (ServerProcess.__init__): Added argument worker_number. This class does not make use of it. We will make use of this argument in SimulatorProcess to lookup the associated simulator device.
1062         (ServerProcess._set_file_nonblocking): Added to share common code.
1063         * Scripts/webkitpy/port/server_process_mock.py:
1064         (MockServerProcess.__init__): Added argument worker_number.
1065         * Scripts/webkitpy/port/simulator_process.py: Added.
1066         (SimulatorProcess): Added.
1067         (SimulatorProcess.Popen): Added.
1068         (SimulatorProcess.Popen.__init__): Added. Initialize Popen structure with stdin, stdout, stderr and pid.
1069         (SimulatorProcess.Popen.poll): Added. Check if the process is running.
1070         (SimulatorProcess.Popen.wait): Added. Wait for process to close.
1071         (SimulatorProcess.__init__): Added. Install app to device specified through port and worker_number.
1072         (SimulatorProcess._reset): Added. Unlink fifos.
1073         (SimulatorProcess._start): Added. Launch app on simulator, link fifos.
1074         (SimulatorProcess._kill): Added. Shutdown app on simulator.
1075         * Scripts/webkitpy/xcode/simulator.py:
1076         (Device.__init__): Accept host to run install/launch/terminate.
1077         (Device.install_app): Install app to target Device.
1078         (Device.launch_app): Launch app on target Device.
1079         (Device.terminate_app): Shutdown app on target Device.
1080         (Simulator._parse_devices): Pass host to Device.
1081
1082 2017-01-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1083
1084         [GTK] pixman fails to compile on Raspberry Pi (GCC crash)
1085         https://bugs.webkit.org/show_bug.cgi?id=167411
1086
1087         Reviewed by Michael Catanzaro.
1088
1089         Disable the ARM iwMMXt fast path for pixman, because it triggers
1090         a GCC bug on the RPi with Raspbian/PIXEL causing a build failure.
1091
1092         * gtk/jhbuild.modules:
1093
1094 2017-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1095
1096         [GTK] Add API to handle the accelerated compositing policy
1097         https://bugs.webkit.org/show_bug.cgi?id=167509
1098
1099         Reviewed by Michael Catanzaro.
1100
1101         Handle new setting in MiniBrowser. The settings dialog doesn't support enum settings so it needs to be handled
1102         as a special case. Also add test cases to the get/set API.
1103
1104         * MiniBrowser/gtk/BrowserSettingsDialog.c:
1105         (hardwareAccelerationPolicyToString):
1106         (stringToHardwareAccelerationPolicy):
1107         (cellRendererChanged):
1108         (browserSettingsDialogConstructed):
1109         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
1110         (testWebKitSettings):
1111
1112 2017-01-29  Andy Estes  <aestes@apple.com>
1113
1114         [QuickLook] Add a WebPreference to enable saving QuickLook documents in WebKitLegacy
1115         https://bugs.webkit.org/show_bug.cgi?id=167563
1116         <rdar://problem/30253207>
1117
1118         Reviewed by Andreas Kling.
1119
1120         * TestWebKitAPI/Tests/WebKit2Cocoa/QuickLook.mm:
1121         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
1122         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
1123         (runTest):
1124         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
1125         (TEST):
1126
1127 2017-01-29  Dan Bernstein  <mitz@apple.com>
1128
1129         [iOS] Expose WebCore::DataDetection::detectContentInRange WKWebProcessPlugInRangeHandle
1130         https://bugs.webkit.org/show_bug.cgi?id=167565
1131
1132         Reviewed by Sam Weinig.
1133
1134         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1135         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm: Added.
1136         (-[BundleRangeHandleRemoteObject textFromBodyRange:]):
1137         (-[BundleRangeHandleRemoteObject bodyInnerHTMLAfterDetectingData:]):
1138         (TEST):
1139         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandlePlugIn.mm: Added.
1140         (-[BundleRangeHandlePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1141         (-[BundleRangeHandlePlugIn webProcessPlugInBrowserContextController:didFinishDocumentLoadForFrame:]):
1142         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandleProtocol.h: Added.
1143
1144 2017-01-28  Yoav Weiss  <yoav@yoav.ws>
1145
1146         Add Link Preload as an off-by-default experimental feature menu item.
1147         https://bugs.webkit.org/show_bug.cgi?id=167201
1148
1149         Reviewed by Ryosuke Niwa.
1150
1151         * DumpRenderTree/mac/DumpRenderTree.mm:
1152         (resetWebPreferencesToConsistentValues):
1153         * DumpRenderTree/win/DumpRenderTree.cpp:
1154         (resetWebPreferencesToConsistentValues):
1155
1156 2017-01-28  Joseph Pecoraro  <pecoraro@apple.com>
1157
1158         Add User Timing Experimental Feature
1159         https://bugs.webkit.org/show_bug.cgi?id=167542
1160         <rdar://problem/22746307>
1161
1162         Reviewed by Ryosuke Niwa.
1163
1164         * DumpRenderTree/mac/DumpRenderTree.mm:
1165         (enableExperimentalFeatures):
1166         (resetWebPreferencesToConsistentValues):
1167         * DumpRenderTree/win/DumpRenderTree.cpp:
1168         (enableExperimentalFeatures):
1169
1170 2017-01-28  Joseph Pecoraro  <pecoraro@apple.com>
1171
1172         Patch Review: EWS Bubbles wrap to multiple lines but can fit on one line
1173         https://bugs.webkit.org/show_bug.cgi?id=167519
1174
1175         Reviewed by Ryosuke Niwa.
1176
1177         * QueueStatusServer/templates/statusbubble.html:
1178         To measure the bubbleContainer's width, it must not be wrapping based
1179         on its parent container. So when measuring the width temporarily set
1180         the parent to a very large width so as to not artificially wrap us.
1181         Restore the parent's width after measuring.
1182
1183 2017-01-27  Andy Estes  <aestes@apple.com>
1184
1185         [iOS] Add a test for _WKNSFileManagerExtras
1186         https://bugs.webkit.org/show_bug.cgi?id=167478
1187
1188         Reviewed by Andreas Kling.
1189
1190         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1191         * TestWebKitAPI/Tests/WebKit2Cocoa/NSFileManagerExtras.mm: Added.
1192         (expectAttributes):
1193         (TEST):
1194
1195 2017-01-27  Keith Miller  <keith_miller@apple.com>
1196
1197         run-benchmarks should make sure it passes the test url to the right application
1198         https://bugs.webkit.org/show_bug.cgi?id=167533
1199
1200         Reviewed by Joseph Pecoraro.
1201
1202         This fixes an issue when trying to run-benchmark script with the
1203         system default browser set to STP. Previously, it would run
1204         the test in STP rather than the provided build. Now, it should run
1205         in the provided build.
1206
1207         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1208         (OSXSafariDriver.launch_url):
1209
1210 2017-01-27  Myles C. Maxfield  <mmaxfield@apple.com>
1211
1212         [Cocoa] Prepare ComplexTextController for unit testing
1213         https://bugs.webkit.org/show_bug.cgi?id=167493
1214
1215         Reviewed by Simon Fraser.
1216
1217         Addressing post-review comments from Simon Fraser.
1218
1219         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
1220         (TestWebKitAPI::TEST_F):
1221
1222 2017-01-27  Myles C. Maxfield  <mmaxfield@apple.com>
1223
1224         [Cocoa] Prepare ComplexTextController for unit testing
1225         https://bugs.webkit.org/show_bug.cgi?id=167493
1226
1227         Reviewed by Dean Jackson.
1228
1229         Create four unit tests.
1230
1231         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1232         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp: Added.
1233         (TestWebKitAPI::ComplexTextControllerTest::SetUp):
1234         (TestWebKitAPI::TEST_F):
1235
1236 2017-01-26  Chris Dumez  <cdumez@apple.com>
1237
1238         Crash when navigating back to a page in PacheCache when one of its frames has been removed
1239         https://bugs.webkit.org/show_bug.cgi?id=167421
1240         <rdar://problem/30188490>
1241
1242         Reviewed by Darin Adler.
1243
1244         Add a new setting allowing layout tests to enable PageCache in a window
1245         that has an opener, for convenience.
1246
1247         * DumpRenderTree/mac/DumpRenderTree.mm:
1248         (resetWebPreferencesToConsistentValues):
1249         * DumpRenderTree/win/DumpRenderTree.cpp:
1250         (resetWebPreferencesToConsistentValues):
1251         * WebKitTestRunner/TestController.cpp:
1252         (WTR::TestController::resetPreferencesToConsistentValues):
1253
1254 2017-01-26  Keith Miller  <keith_miller@apple.com>
1255
1256         classInfo should take a VM so it is not materialized from the object on each call
1257         https://bugs.webkit.org/show_bug.cgi?id=167424
1258
1259         Rubber Stamped by Michael Saboff.
1260
1261         Previously, classInfo() would get the VM from the target's
1262         MarkedBlock.  Most callers already have a VM on hand, so it is
1263         wasteful to compute the VM from the marked block every time. This
1264         patch refactors some of the most common callers of classInfo(),
1265         jsDynamicCast and inherits to take a VM as well.
1266
1267         * DumpRenderTree/TestRunner.cpp:
1268         (setAudioResultCallback):
1269
1270 2017-01-26  Jer Noble  <jer.noble@apple.com>
1271
1272         Autoplay muted videos stop playback of any streaming app in the background
1273         https://bugs.webkit.org/show_bug.cgi?id=163993
1274         <rdar://problem/29020431>
1275
1276         Reviewed by Eric Carlson.
1277
1278         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1279         * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:
1280         (TestWebKitAPI::TEST):
1281         * TestWebKitAPI/Tests/WebKit/ios/video-with-muted-audio-and-webaudio.html: Added.
1282
1283 2017-01-26  Ryan Haddad  <ryanhaddad@apple.com>
1284
1285         Disable API test WebKit2.WebsitePoliciesPlayAfterPreventedAutoplay.
1286         https://bugs.webkit.org/show_bug.cgi?id=167466
1287
1288         Unreviewed test gardening.
1289
1290         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
1291         (TEST):
1292
1293 2017-01-26  Matt Rajca  <mrajca@apple.com>
1294
1295         Notify clients when the user plays media otherwise prevented from autoplaying
1296         https://bugs.webkit.org/show_bug.cgi?id=167390
1297
1298         Reviewed by Alex Christensen.
1299
1300         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1301         * TestWebKitAPI/Tests/WebKit2/autoplay-with-controls.html: Added.
1302         * TestWebKitAPI/Tests/WebKit2/js-play-with-controls.html: Added.
1303         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
1304         (didPlayMediaPreventedFromPlayingWithoutUserGesture):
1305         (TEST):
1306         * TestWebKitAPI/cocoa/TestWKWebView.h:
1307         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1308         (-[TestWKWebViewHostWindow _mouseUpAtPoint:]):
1309         (-[TestWKWebView waitForLoad]):
1310         (-[TestWKWebView mouseUpAtPoint:]):
1311         * WebKitTestRunner/TestController.cpp:
1312         (WTR::TestController::createOtherPage):
1313         (WTR::TestController::createWebViewWithOptions):
1314
1315 2017-01-26  Per Arne Vollan  <pvollan@apple.com>
1316
1317         Crash when setting custom scale factor.
1318         https://bugs.webkit.org/show_bug.cgi?id=167369
1319
1320         Reviewed by Sam Weinig.
1321
1322         Added API test.
1323
1324         * TestWebKitAPI/PlatformWin.cmake:
1325         * TestWebKitAPI/Tests/WebKit/win/ScaleWebView.cpp: Added.
1326         (TestWebKitAPI::WebKitCreateInstance):
1327         (TestWebKitAPI::ScaleWebView::SetUp):
1328         (TestWebKitAPI::ScaleWebView::TearDown):
1329         (TestWebKitAPI::TEST_F):
1330
1331 2017-01-25  Ryosuke Niwa  <rniwa@webkit.org>
1332
1333         run-benchmark nests MotionMark results by the suite name twice
1334         https://bugs.webkit.org/show_bug.cgi?id=164948
1335
1336         Reviewed by Said Abou-Hallawa.
1337
1338         Use a single level MotionMark now that this is the name of the benchmark,
1339         and we no longer have tests that aren't part of the MotionMark suite.
1340
1341         * Scripts/webkitpy/benchmark_runner/data/patches/MotionMark.patch:
1342
1343 2017-01-25  Ryan Haddad  <ryanhaddad@apple.com>
1344
1345         Unreviewed, rolling out r211193.
1346
1347         This change broke internal builds.
1348
1349         Reverted changeset:
1350
1351         "Notify clients when the user plays media otherwise prevented
1352         from autoplaying"
1353         https://bugs.webkit.org/show_bug.cgi?id=167390
1354         http://trac.webkit.org/changeset/211193
1355
1356 2017-01-25  Matt Rajca  <mrajca@apple.com>
1357
1358         Notify clients when the user plays media otherwise prevented from autoplaying
1359         https://bugs.webkit.org/show_bug.cgi?id=167390
1360
1361         Reviewed by Alex Christensen.
1362
1363         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1364         * TestWebKitAPI/Tests/WebKit2/autoplay-with-controls.html: Added.
1365         * TestWebKitAPI/Tests/WebKit2/js-play-with-controls.html: Added.
1366         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
1367         (didPlayMediaPreventedFromPlayingWithoutUserGesture):
1368         (TEST):
1369         * TestWebKitAPI/cocoa/TestWKWebView.h:
1370         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1371         (-[TestWKWebViewHostWindow _mouseUpAtPoint:]):
1372         (-[TestWKWebView waitForLoad]):
1373         (-[TestWKWebView mouseUpAtPoint:]):
1374         * WebKitTestRunner/TestController.cpp:
1375         (WTR::TestController::createOtherPage):
1376         (WTR::TestController::createWebViewWithOptions):
1377
1378 2017-01-25  Matt Rajca  <mrajca@apple.com>
1379
1380         [ios-simulator] API test WebKit2.WebsitePoliciesAutoplayEnabled timing out
1381         https://bugs.webkit.org/show_bug.cgi?id=167385
1382
1383         Reviewed by Alex Christensen.
1384
1385         * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Avoid arbitrary timeouts in favor of promises.
1386         * TestWebKitAPI/Tests/WebKit2/autoplay-no-audio-check.html:
1387         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
1388         (TEST): Allow inline (rather than full screen) media playback on iOS.
1389
1390 2017-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
1391
1392         [GTK] Icon Database should be in private browsing mode for ephemeral web views
1393         https://bugs.webkit.org/show_bug.cgi?id=167414
1394
1395         Reviewed by Michael Catanzaro.
1396
1397         Add a test case to check ephemeral web views don't write favicons to the database.
1398
1399         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
1400         (ephemeralViewLoadChanged):
1401         (testPrivateBrowsing):
1402         (testFaviconDatabase):
1403
1404 2017-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
1405
1406         [GTK] Add a private browsing mode to MiniBrowser
1407         https://bugs.webkit.org/show_bug.cgi?id=167413
1408
1409         Reviewed by Michael Catanzaro.
1410
1411         Add -p/--private command line option to create a private instance. Also add CTRL+SHIFT+P shortcut to create
1412         private windows, even on non-private instances.
1413
1414         * MiniBrowser/gtk/BrowserWindow.c:
1415         (webViewTitleChanged): Add [Private] to title window for private windows.
1416         (webViewCreate): Pass web context to browser_window_new.
1417         (openPrivateWindow): Create a new ephemeral web view and add it to a new window.
1418         (browserWindowFinalize): Disconnect web context signal handlers.
1419         (browser_window_init): Add shortcut for opening private window.
1420         (browser_window_new): It now receives the context and connect to download-started here.
1421         (browser_window_get_web_context): Return the context.
1422         * MiniBrowser/gtk/BrowserWindow.h:
1423         * MiniBrowser/gtk/main.c:
1424         (createBrowserTab): Create the web view for the window web context.
1425         (aboutDataScriptMessageReceivedCallback): Do not use the default web context, but the window one.
1426         (aboutDataHandleRequest): Ditto.
1427         (aboutURISchemeRequestCallback): Ditto.
1428         (main): Create ephemeral web context if private command line option is used.
1429
1430 2017-01-25  Ryosuke Niwa  <rniwa@webkit.org>
1431
1432         collectMatchingElementsInFlatTree should not find elements inside an user agent shadow tree
1433         https://bugs.webkit.org/show_bug.cgi?id=167409
1434
1435         Reviewed by Antti Koivisto.
1436
1437         Added a test case for collectMatchingElementsInFlatTree not finding elements inside an user agent shadow tree
1438         as well as tests for the newly added matchingElementInFlatTree.
1439
1440         * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen.cpp:
1441         (TestWebKitAPI::runJavaScriptAlert):
1442         * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen_Bundle.cpp:
1443         (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize):
1444         * TestWebKitAPI/Tests/WebKit2/closed-shadow-tree-test.html:
1445
1446 2017-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1447
1448         [GTK] Add API to create ephemeral web views and deprecate the private browsing setting
1449         https://bugs.webkit.org/show_bug.cgi?id=167370
1450
1451         Reviewed by Michael Catanzaro.
1452
1453         Add several test cases of ephemeral web views.
1454
1455         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
1456         (testWebViewAuthenticationStorage):
1457         * TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp:
1458         (ephemeralViewloadChanged):
1459         (testCookieManagerEphemeral):
1460         (beforeAll):
1461         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
1462         (testWebKitSettings):
1463         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1464         (testWebContextEphemeral):
1465         (ephemeralViewloadChanged):
1466         (testWebContextProxySettings):
1467         (beforeAll):
1468         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1469         (ephemeralViewloadChanged):
1470         (testWebViewEphemeral):
1471         (beforeAll):
1472         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp:
1473         (ephemeralViewloadChanged):
1474         (testWebsiteDataEphemeral):
1475         (beforeAll):
1476
1477 2017-01-24  Alex Christensen  <achristensen@webkit.org>
1478
1479         REGRESSION (r208902): URLWithUserTypedString returns nil with file URLs
1480         https://bugs.webkit.org/show_bug.cgi?id=167402
1481
1482         Reviewed by Ryosuke Niwa.
1483
1484         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
1485         (TestWebKitAPI::TEST):
1486
1487 2017-01-24  Zalan Bujtas  <zalan@apple.com>
1488
1489         Add simple line layout toggle to MiniBrowser
1490         https://bugs.webkit.org/show_bug.cgi?id=167405
1491
1492         Reviewed by Andreas Kling.
1493
1494         * MiniBrowser/mac/SettingsController.h:
1495         * MiniBrowser/mac/SettingsController.m:
1496         (-[SettingsController _populateMenu]):
1497         (-[SettingsController validateMenuItem:]):
1498         (-[SettingsController toggleSimpleLineLayoutEnabled:]):
1499         (-[SettingsController simpleLineLayoutEnabled]):
1500         * MiniBrowser/mac/WK1BrowserWindowController.m:
1501         (-[WK1BrowserWindowController didChangeSettings]):
1502         * MiniBrowser/mac/WK2BrowserWindowController.m:
1503         (-[WK2BrowserWindowController didChangeSettings]):
1504
1505 2017-01-24  Joseph Pecoraro  <pecoraro@apple.com>
1506
1507         WKR does not include my nick when commit-queue lands my patch
1508         https://bugs.webkit.org/show_bug.cgi?id=167388
1509
1510         Reviewed by Ryosuke Niwa.
1511
1512         * Scripts/webkitpy/tool/commands/newcommitbot.py:
1513         (NewCommitBot._summarize_commit_log):
1514         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
1515         Perform nickname insertion before grabbing "Patch by" details.
1516         This way we can include the nickname with the full name.
1517
1518 2017-01-24  Joseph Pecoraro  <pecoraro@apple.com>
1519
1520         Fold USER_TIMING into WEB_TIMING and make it a RuntimeEnabledFeature
1521         https://bugs.webkit.org/show_bug.cgi?id=167394
1522
1523         Reviewed by Ryosuke Niwa.
1524
1525         * Scripts/webkitperl/FeatureList.pm:
1526         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1527
1528 2017-01-24  Youenn Fablet  <youenn@apple.com>
1529
1530         [WebRTC] Use HAVE_PTHREAD_COND_TIMEDWAIT_RELATIVE for libwebrtc
1531         https://bugs.webkit.org/show_bug.cgi?id=167353
1532
1533         Reviewed by Alex Christensen.
1534
1535         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
1536         (CMakeGenerator.initialize_targets):
1537
1538 2017-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
1539
1540         WKR should not confuse Miguel Gomez with Andres Gomez
1541         https://bugs.webkit.org/show_bug.cgi?id=167389
1542
1543         Reviewed by Lucas Forschler.
1544
1545         Andres's email is a substring of Miguel's, causing WKR to credit Miguel's commits to
1546         "mAndres Gomez". Fix this.
1547
1548         * Scripts/webkitpy/tool/commands/newcommitbot.py:
1549         (NewCommitBot._summarize_commit_log): Be stricter about matching emails. SVN logs include a
1550         space on each side of the email address, so expect both spaces to be there before
1551         considering the email for replacement.
1552         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py: Add a test.
1553
1554 2017-01-24  Matt Rajca  <mrajca@apple.com>
1555
1556         Pass down website autoplay policies to media elements
1557         https://bugs.webkit.org/show_bug.cgi?id=167355
1558
1559         Reviewed by Alex Christensen.
1560
1561         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1562         * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Renamed from Tools/TestWebKitAPI/Tests/WebKit2/autoplayCheck.html to match our naming conventions.
1563         * TestWebKitAPI/Tests/WebKit2/autoplay-no-audio-check.html: Added.
1564         * TestWebKitAPI/Tests/WebKit2/test-without-audio-track.mp4: Added.
1565         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
1566         (-[AutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
1567         (TEST):
1568
1569 2017-01-24  Nan Wang  <n_wang@apple.com>
1570
1571         AX: Speak Selection does not work in an iframe
1572         https://bugs.webkit.org/show_bug.cgi?id=166794
1573         <rdar://problem/29913013>
1574
1575         Reviewed by Chris Fleizach.
1576
1577         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1578         (WTR::UIScriptController::retrieveSpeakSelectionContent):
1579         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
1580         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1581         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1582         (WTR::UIScriptController::retrieveSpeakSelectionContent):
1583         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
1584         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1585         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1586         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1587         (-[TestRunnerWKWebView dealloc]):
1588         (-[TestRunnerWKWebView _accessibilityDidGetSpeakSelectionContent:]):
1589         (-[TestRunnerWKWebView accessibilityRetrieveSpeakSelectionContentWithCompletionHandler:]):
1590         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1591         (WTR::UIScriptController::retrieveSpeakSelectionContent):
1592         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
1593
1594 2017-01-24  Daniel Bates  <dabates@apple.com>
1595
1596         StringView.split() should use an iterator design pattern instead of allocating a Vector
1597         https://bugs.webkit.org/show_bug.cgi?id=163225
1598
1599         Reviewed by Darin Adler.
1600
1601         Add unit tests for StringView.split().
1602
1603         * TestWebKitAPI/Tests/WTF/StringView.cpp:
1604         (TestWebKitAPI::stringViewFromLiteral): Moved to the top of the file so that it can be
1605         used in the StringView.split() unit tests.
1606         (TestWebKitAPI::stringViewFromUTF8): Ditto.
1607         (TestWebKitAPI::vectorFromSplitResult): Convenience function to convert a StringView::SplitResult
1608         object to a Vector of String objects.
1609         (TestWebKitAPI::TEST): Added the following tests:
1610             - WTF.StringViewSplitEmptyAndNullStrings
1611             - WTF.StringViewSplitBasic
1612             - WTF.StringViewSplitWithConsecutiveSeparators
1613
1614 2017-01-23  Anders Carlsson  <andersca@apple.com>
1615
1616         The Score Esports crashes on launch
1617         https://bugs.webkit.org/show_bug.cgi?id=167338
1618         rdar://problem/29948645
1619
1620         Reviewed by Dan Bernstein.
1621
1622         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm:
1623         (TestWebKitAPI::TEST):
1624         Add a test.
1625
1626 2017-01-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1627
1628         [GTK] Add API to WebKitWebsiteDataManager to handle website data
1629         https://bugs.webkit.org/show_bug.cgi?id=146589
1630
1631         Reviewed by Michael Catanzaro.
1632
1633         Add about:data handler to MiniBrowser to manually test the website data API. Also add unit tests to test all the
1634         new API, moving the WebKitWebsiteDataManager configuration API to the new file too.
1635
1636         * MiniBrowser/gtk/BrowserWindow.c:
1637         (webViewDecidePolicy):
1638         (newTabCallback):
1639         * MiniBrowser/gtk/main.c:
1640         (createBrowserTab):
1641         (aboutDataRequestFree):
1642         (aboutDataRequestNew):
1643         (aboutDataRequestForView):
1644         (websiteDataRemovedCallback):
1645         (websiteDataClearedCallback):
1646         (aboutDataScriptMessageReceivedCallback):
1647         (domainListFree):
1648         (aboutDataFillTable):
1649         (gotWebsiteDataCallback):
1650         (aboutDataHandleRequest):
1651         (aboutURISchemeRequestCallback):
1652         (main):
1653         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
1654         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1655         (serverCallback):
1656         (beforeAll):
1657         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp: Added.
1658         (serverCallback):
1659         (WebsiteDataTest::WebsiteDataTest):
1660         (WebsiteDataTest::~WebsiteDataTest):
1661         (WebsiteDataTest::fetch):
1662         (WebsiteDataTest::remove):
1663         (WebsiteDataTest::clear):
1664         (testWebsiteDataConfiguration):
1665         (testWebsiteDataCache):
1666         (testWebsiteDataStorage):
1667         (testWebsiteDataDatabases):
1668         (testWebsiteDataAppcache):
1669         (beforeAll):
1670         (afterAll):
1671
1672 2017-01-23  Commit Queue  <commit-queue@webkit.org>
1673
1674         Unreviewed, rolling out r211062.
1675         https://bugs.webkit.org/show_bug.cgi?id=167354
1676
1677         broke API tests (Requested by alexchristensen on #webkit).
1678
1679         Reverted changeset:
1680
1681         "Pass down website autoplay policies to media elements"
1682         https://bugs.webkit.org/show_bug.cgi?id=167132
1683         http://trac.webkit.org/changeset/211062
1684
1685 2017-01-23  Alex Christensen  <achristensen@webkit.org>
1686
1687         URLParser should fail to parse percent-encoded invalid UTF-8 sequences
1688         https://bugs.webkit.org/show_bug.cgi?id=167330
1689
1690         Reviewed by Tim Horton.
1691
1692         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1693         (TestWebKitAPI::TEST_F):
1694
1695 2017-01-23  Alex Christensen  <achristensen@webkit.org>
1696
1697         Make URLs with non-special schemes and a query or fragment but no slash after the host more compatible
1698         https://bugs.webkit.org/show_bug.cgi?id=167317
1699
1700         Reviewed by Sam Weinig.
1701
1702         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1703         (TestWebKitAPI::TEST_F):
1704
1705 2017-01-23  Jonathan Bedard  <jbedard@apple.com>
1706
1707         svn-create-patch should emit properties when files are moved or copied
1708         https://bugs.webkit.org/show_bug.cgi?id=167264
1709
1710         Reviewed by Daniel Bates.
1711
1712         * Scripts/svn-create-patch:
1713         (manufacturePatchForAdditionWithHistory): Diff the source file against nothing to get properties.
1714
1715 2017-01-23  Youenn Fablet  <youenn@apple.com>
1716
1717         [WebRTC] Filter libwebrtc link flags
1718         https://bugs.webkit.org/show_bug.cgi?id=167287
1719
1720         Reviewed by Alex Christensen.
1721
1722         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
1723         (CMakeGenerator._compute_link_flags):
1724         (CMakeGenerator._compute_link_flags.keep_flag):
1725         (CMakeGenerator._generate_compile_target_options):
1726
1727 2017-01-23  Youenn Fablet  <youennf@gmail.com>
1728
1729         [WebRTC] Make VP8 optional in libwebrtc
1730         https://bugs.webkit.org/show_bug.cgi?id=167257
1731
1732         Reviewed by Darin Adler.
1733
1734         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
1735         (CMakeGenerator.remove_libvpx): Adding vp8_noop.cc to the build system.
1736
1737 2017-01-23  Jer Noble  <jer.noble@apple.com>
1738
1739         Video details does not apear and missing scrubber in Control Center
1740         https://bugs.webkit.org/show_bug.cgi?id=167233
1741
1742         Reviewed by Alex Christensen.
1743
1744         Refactor TestWKWebViewMac to work on PLATFORM(IOS). Add a new test to
1745         NowPlayingControlTests for iOS.
1746
1747         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1748         * TestWebKitAPI/Tests/WebKit2Cocoa/NowPlayingControlsTests.mm:
1749         (-[NowPlayingTestWebView setWindowVisible:]):
1750         (TestWebKitAPI::TEST):
1751         * TestWebKitAPI/Tests/WebKit2Cocoa/SnapshotStore.mm:
1752         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1753         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewCandidateTests.mm:
1754         * TestWebKitAPI/cocoa/TestWKWebView.h: Renamed from Tools/TestWebKitAPI/mac/TestWKWebViewMac.h.
1755         * TestWebKitAPI/cocoa/TestWKWebView.mm: Renamed from Tools/TestWebKitAPI/mac/TestWKWebViewMac.mm.
1756         (SOFT_LINK_CLASS):
1757         (-[TestMessageHandler addMessage:withHandler:]):
1758         (-[TestMessageHandler userContentController:didReceiveScriptMessage:]):
1759         (__simulated_forceClickAssociatedEventsMask):
1760         (-[TestWKWebViewHostWindow _mouseDownAtPoint:simulatePressure:]):
1761         (-[TestWKWebViewHostWindow isKeyWindow]):
1762         (-[TestWKWebViewHostWindow makeKeyWindow]):
1763         (-[TestWKWebViewHostWindow resignKeyWindow]):
1764         (-[TestWKWebView initWithFrame:]):
1765         (-[TestWKWebView initWithFrame:configuration:]):
1766         (-[TestWKWebView _setUpTestWindow:]):
1767         (-[TestWKWebView performAfterReceivingMessage:action:]):
1768         (-[TestWKWebView loadTestPageNamed:]):
1769         (-[TestWKWebView synchronouslyLoadTestPageNamed:]):
1770         (-[TestWKWebView stringByEvaluatingJavaScript:]):
1771         (-[TestWKWebView waitForMessage:]):
1772         (-[TestWKWebView performAfterLoading:]):
1773         (-[TestWKWebView mouseDownAtPoint:simulatePressure:]):
1774         (-[TestWKWebView typeCharacter:]):
1775
1776 2017-01-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1777
1778         Unreviewed. Bring back gtk-doc error messages after r209981.
1779
1780         Since r209981, if gtk-doc shows warnings the build fails but those warnings are not printed to stdout so it's
1781         impossible to know what's wrong.
1782
1783         * gtk/gtkdoc.py:
1784         (GTKDoc._run_command): Make print_output True by default again and use debug instead of info to log "Running" messages.
1785
1786 2017-01-20  Youenn Fablet  <youennf@gmail.com>
1787
1788         [WebRTC] Update build system to make G711 optional in libwebrtc
1789         https://bugs.webkit.org/show_bug.cgi?id=167256
1790
1791         Reviewed by Alex Christensen.
1792
1793         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
1794         (CMakeGenerator.remove_webrtc_g711): Adding a missing file to the build system as this file includes generic pcm encoder functions.
1795
1796 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
1797
1798         Cleanup RuntimeEnabledFeatures
1799         https://bugs.webkit.org/show_bug.cgi?id=167228
1800
1801         Reviewed by Simon Fraser.
1802
1803         * DumpRenderTree/mac/DumpRenderTree.mm:
1804         (enableExperimentalFeatures):
1805         (resetWebPreferencesToConsistentValues):
1806         (setWebPreferencesForTestOptions):
1807         (resetWebViewToConsistentStateBeforeTesting):
1808         * DumpRenderTree/win/DumpRenderTree.cpp:
1809         (enableExperimentalFeatures):
1810         (resetWebPreferencesToConsistentValues):
1811         More closely match WebKitTestRunner initialization of preferences
1812         for experimental features.
1813
1814 2017-01-20  Alex Christensen  <achristensen@webkit.org>
1815
1816         Build Fix for Windows DumpRenderTree after r210976
1817         https://bugs.webkit.org/show_bug.cgi?id=167115
1818
1819         * DumpRenderTree/win/DumpRenderTree.cpp:
1820         (resetWebPreferencesToConsistentValues):
1821
1822 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
1823
1824         Remove outdated ENABLE(CSP_NEXT) build flag
1825         https://bugs.webkit.org/show_bug.cgi?id=167252
1826
1827         Reviewed by Brent Fulgham.
1828
1829         * Scripts/webkitperl/FeatureList.pm:
1830         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1831
1832 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
1833
1834         Build Fix for Windows DumpRenderTree after r210976
1835
1836         * DumpRenderTree/win/DumpRenderTree.cpp:
1837         (resetWebPreferencesToConsistentValues):
1838
1839 2017-01-20  Antoine Quint  <graouts@apple.com>
1840
1841         Web Animations should be off by default and enabled as an experimental feature
1842         https://bugs.webkit.org/show_bug.cgi?id=167115
1843         <rdar://problem/30048963>
1844
1845         Reviewed by Joseph Pecoraro.
1846
1847         Turn Web Animations on in DRT.
1848
1849         * DumpRenderTree/mac/DumpRenderTree.mm:
1850         (resetWebPreferencesToConsistentValues):
1851         * DumpRenderTree/win/DumpRenderTree.cpp:
1852         (resetWebPreferencesToConsistentValues):
1853
1854 2017-01-20  Youenn Fablet  <youenn@apple.com>
1855
1856         [WebRTC] Add libwebrtc build infrastructure
1857         https://bugs.webkit.org/show_bug.cgi?id=167207
1858
1859         Reviewed by Alex Christensen.
1860
1861         Adding a script doing the libwebrtc project json to CMake file conversion.
1862
1863         * Scripts/generate-libwebrtc-cmake: Added.
1864         * Scripts/webkitpy/libwebrtc/__init__.py: Added.
1865         * Scripts/webkitpy/libwebrtc/generate_cmake.py: Added.
1866
1867 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
1868
1869         Mini Browser: Show tooltip for Experimental Features
1870         https://bugs.webkit.org/show_bug.cgi?id=167225
1871
1872         Reviewed by Alex Christensen.
1873
1874         * MiniBrowser/mac/SettingsController.m:
1875         (-[SettingsController _populateMenu]):
1876         Include the full details string as a tooltip.
1877
1878 2017-01-20  Per Arne Vollan  <pvollan@apple.com>
1879
1880         [Win] Test output results should not be written twice.
1881         https://bugs.webkit.org/show_bug.cgi?id=167197
1882
1883         Reviewed by Brent Fulgham.
1884
1885         Prevent test output from being written twice by returning early from
1886         the dump() function, if it already has been called.
1887         This patch also adds a missing newline to a test output line. 
1888         
1889         * DumpRenderTree/win/DumpRenderTree.cpp:
1890         (dump):
1891
1892 2017-01-20  Antoine Quint  <graouts@apple.com>
1893
1894         [Modern Media Controls] Turn modern media controls on by default
1895         https://bugs.webkit.org/show_bug.cgi?id=165668
1896
1897         Reviewed by Dean Jackson.
1898
1899         Enabled modern media controls by default in test runners.
1900
1901         * DumpRenderTree/TestOptions.h:
1902         * WebKitTestRunner/TestOptions.h:
1903
1904 2017-01-19  Chris Dumez  <cdumez@apple.com>
1905
1906         iterable<> should be enabled on WK1
1907         https://bugs.webkit.org/show_bug.cgi?id=167221
1908         <rdar://problem/30108531>
1909
1910         Reviewed by Youenn Fablet.
1911
1912         * DumpRenderTree/mac/DumpRenderTree.mm:
1913         (resetWebPreferencesToConsistentValues):
1914         * DumpRenderTree/win/DumpRenderTree.cpp:
1915         (resetWebPreferencesToConsistentValues):
1916         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1917         (WTR::InjectedBundle::beginTesting):
1918         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1919         (WTR::TestRunner::setDOMIteratorEnabled): Deleted.
1920         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1921
1922 2017-01-19  Aakash Jain  <aakash_jain@apple.com>
1923
1924         Ensure status server logs go to log file
1925         https://bugs.webkit.org/show_bug.cgi?id=167210
1926
1927         Reviewed by Alexey Proskuryakov.
1928
1929         * Scripts/webkitpy/common/net/statusserver.py:
1930         (StatusServer.next_work_item): Change log level from debug to info in
1931         order to facilitate deubgging issues.
1932         (StatusServer.update_work_items): Same.
1933
1934 2017-01-19  Megan Gardner  <megan_gardner@apple.com>
1935
1936         Additional selection tests and interpolation fix
1937         https://bugs.webkit.org/show_bug.cgi?id=167171
1938
1939         Reviewed by Simon Fraser.
1940
1941         We weren't adding the final event when interpolating event streams.
1942
1943         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1944         (-[HIDEventGenerator interpolatedEvents:]):
1945
1946 2017-01-19  Myles C. Maxfield  <mmaxfield@apple.com>
1947
1948         [Cocoa] Variation fonts are erroneously disabled on iOS
1949         https://bugs.webkit.org/show_bug.cgi?id=167172
1950
1951         Reviewed by Simon Fraser.
1952
1953         OpenSource builders don't seem to understand sdk=embedded*.
1954
1955         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1956
1957 2017-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1958
1959         Unreviewed. Fix GTK+ unit tests failing since r210531.
1960
1961         Avoid using paths to files that don't actually exist.
1962
1963         * TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp:
1964         (testWebKitConsoleMessageNetworkError):
1965         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
1966         (testContextMenuDefaultMenu):
1967         * TestWebKitAPI/Tests/WebKit2Gtk/resources/silence.mpg: Added.
1968         * TestWebKitAPI/Tests/WebKit2Gtk/resources/simple.json: Added.
1969         * TestWebKitAPI/Tests/WebKit2Gtk/resources/tracks.ogg: Added.
1970
1971 2017-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1972
1973         [GTK] Provide API to set proxy settings
1974         https://bugs.webkit.org/show_bug.cgi?id=128674
1975
1976         Reviewed by Michael Catanzaro.
1977
1978         Add tests for new proxy settings API.
1979
1980         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1981         (serverCallback):
1982         (ProxyTest::ProxyTest):
1983         (ProxyTest::~ProxyTest):
1984         (ProxyTest::loadURIAndGetMainResourceData):
1985         (ProxyTest::proxyServerPortAsString):
1986         (testWebContextProxySettings):
1987         (beforeAll):
1988
1989 2017-01-19  Timothy Hatcher  <timothy@hatcher.name>
1990
1991         Add back my old email address so old commits will still match it.
1992
1993         * Scripts/webkitpy/common/config/contributors.json:
1994
1995 2017-01-19  Timothy Hatcher  <timothy@hatcher.name>
1996
1997         Remove my old email address from contributors.json and watchlist.
1998
1999         * Scripts/validate-committer-lists:
2000         (CommitterListFromGit): Change the mapping to the correct email.
2001         * Scripts/webkitpy/common/config/contributors.json:
2002         * Scripts/webkitpy/common/config/watchlist:
2003
2004 2017-01-18  Ryan Haddad  <ryanhaddad@apple.com>
2005
2006         Unreviewed, rolling out r210848.
2007
2008         This change introduced media-related LayoutTest failures and
2009         crashes on macOS.
2010
2011         Reverted changeset:
2012
2013         "[Modern Media Controls] Turn modern media controls on by
2014         default"
2015         https://bugs.webkit.org/show_bug.cgi?id=165668
2016         http://trac.webkit.org/changeset/210848
2017
2018 2017-01-18  Andreas Kling  <akling@apple.com>
2019
2020         Document::securityOrigin() should return a reference.
2021         <https://webkit.org/b/167124>
2022
2023         Reviewed by Sam Weinig.
2024
2025         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
2026         (TestWebKitAPI::TEST_F):
2027
2028 2017-01-18  Per Arne Vollan  <pvollan@apple.com>
2029
2030         [Win] Clipboard tests are flaky.
2031         https://bugs.webkit.org/show_bug.cgi?id=167088
2032
2033         Reviewed by Brent Fulgham.
2034
2035         Tests involving the clipboard are flaky when running with multiple DRTs, since the clipboard is global. 
2036         We can fix this by assigning each DRT a separate window station (each window station has its own clipboard).
2037
2038         * DumpRenderTree/win/DumpRenderTree.cpp:
2039         (main):
2040
2041 2017-01-18  Antoine Quint  <graouts@apple.com>
2042
2043         [Modern Media Controls] Turn modern media controls on by default
2044         https://bugs.webkit.org/show_bug.cgi?id=165668
2045
2046         Reviewed by Dean Jackson.
2047
2048         Enabled modern media controls by default in test runners. 
2049
2050         * DumpRenderTree/TestOptions.h:
2051         * WebKitTestRunner/TestOptions.h:
2052
2053 2017-01-17  Michael Catanzaro  <mcatanzaro@igalia.com>
2054
2055         Unreviewed, rolling out r210834
2056         https://bugs.webkit.org/show_bug.cgi?id=165668
2057
2058         It introduced dozens of test timeouts.
2059
2060         Reverted changeset:
2061         "[Modern Media Controls] Turn modern media controls on by default"
2062         https://bugs.webkit.org/show_bug.cgi?id=165668
2063         http://trac.webkit.org/changeset/210834
2064
2065 2017-01-17  Antoine Quint  <graouts@apple.com>
2066
2067         [Modern Media Controls] Turn modern media controls on by default
2068         https://bugs.webkit.org/show_bug.cgi?id=165668
2069
2070         Reviewed by Dean Jackson.
2071
2072         Enabled modern media controls by default in test runners. 
2073
2074         * DumpRenderTree/TestOptions.h:
2075         * WebKitTestRunner/TestOptions.h:
2076
2077 2017-01-17  Chris Dumez  <cdumez@apple.com>
2078
2079         Document title changed twice when setting document.title
2080         https://bugs.webkit.org/show_bug.cgi?id=167065
2081
2082         Reviewed by Darin Adler.
2083
2084         Add WebKit2GTK API test that was written by Michael Catanzaro.
2085
2086         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2087         (testWebViewTitleChange):
2088         (beforeAll):
2089
2090 2017-01-17  Joseph Pecoraro  <pecoraro@apple.com>
2091
2092         ENABLE(USER_TIMING) Not Defined for Apple Windows or OS X Ports
2093         https://bugs.webkit.org/show_bug.cgi?id=116551
2094         <rdar://problem/13949830>
2095
2096         Reviewed by Alex Christensen.
2097
2098         * Scripts/webkitperl/FeatureList.pm:
2099         Remove stale RESOURCE_TIMING references which are now a runtime enabled feature
2100         that is part of the existing WEB_TIMING feature.
2101
2102         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2103
2104 2017-01-17  Jonathan Bedard  <jbedard@apple.com>
2105
2106         'webkit-patch post' no longer works with moved/copied files
2107         https://bugs.webkit.org/show_bug.cgi?id=166914
2108         <rdar://problem/29979707>
2109
2110         Reviewed by Daniel Bates.
2111
2112         SVN 1.9 has a bug where when a file has been moved or copied, the svn diff of the new
2113         file outputs only the "Index:" line with an empty body.  This workaround
2114         ignores such output from svn diff.  A issue has been filed with SVN, a link to the
2115         public email list tracking this bug is below.
2116         http://mail-archives.apache.org/mod_mbox/subversion-users/201701.mbox/%3cCF9BDE0A-7454-4405-8259-1120C6B76A03@apple.com%3e
2117         
2118
2119         * Scripts/svn-create-patch:
2120         (generateDiff): Ignore an "Index:" line with an empty body.
2121
2122 2017-01-16  Joseph Pecoraro  <pecoraro@apple.com>
2123
2124         Remove the REQUEST_ANIMATION_FRAME flag
2125         https://bugs.webkit.org/show_bug.cgi?id=156980
2126         <rdar://problem/25906849>
2127
2128         Reviewed by Simon Fraser.
2129
2130         * Scripts/webkitperl/FeatureList.pm:
2131         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2132
2133 2017-01-15  Sam Weinig  <sam@webkit.org>
2134
2135         Add the ability to use numbers in makeString()
2136         https://bugs.webkit.org/show_bug.cgi?id=167087
2137
2138         Reviewed by Darin Adler.
2139
2140         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2141         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Added.
2142         Add tests for StringConcatenate, focusing on new numeric additions.
2143
2144 2017-01-15  Michael Catanzaro  <mcatanzaro@igalia.com>
2145
2146         Unreviewed, remove stale comment.
2147
2148         This test was fixed by r163173.
2149
2150         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
2151
2152 2017-01-14  Yusuke Suzuki  <utatane.tea@gmail.com>
2153
2154         Annotate large string tests with largeHeap
2155         https://bugs.webkit.org/show_bug.cgi?id=167054
2156
2157         Reviewed by Filip Pizlo.
2158
2159         * Scripts/run-javascriptcore-tests:
2160         * Scripts/run-jsc-stress-tests:
2161
2162 2017-01-14  Joseph Pecoraro  <pecoraro@apple.com>
2163
2164         Remove stale references to ENABLE_ES6_GENERATORS and ENABLE_PROMISES
2165         https://bugs.webkit.org/show_bug.cgi?id=167043
2166
2167         Reviewed by Darin Adler.
2168
2169         * Scripts/webkitperl/FeatureList.pm:
2170
2171 2017-01-13  Joseph Pecoraro  <pecoraro@apple.com>
2172
2173         Remove ENABLE(DETAILS_ELEMENT) guards
2174         https://bugs.webkit.org/show_bug.cgi?id=167042
2175
2176         Reviewed by Alex Christensen.
2177
2178         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2179
2180 2017-01-13  Said Abou-Hallawa  <sabouhallawa@apple.com>
2181
2182         26 MotionMark performance tests failing
2183         https://bugs.webkit.org/show_bug.cgi?id=166854
2184
2185         Reviewed by Ryosuke Niwa.
2186
2187         Unrelated change. This is the last place that we need to rename Animometer
2188         to MotionMark.
2189
2190         * Scripts/webkitpy/common/config/watchlist:
2191
2192 2017-01-13  Yusuke Suzuki  <utatane.tea@gmail.com>
2193
2194         run-jsc-benchmarks' echo should have -e option
2195         https://bugs.webkit.org/show_bug.cgi?id=167009
2196
2197         Reviewed by Sam Weinig.
2198
2199         echo requires `-e` option to use escape sequence.
2200         Without it, in some environment (in my Fedora 25), the escape sequence is not
2201         recognized and just dumped as `\c` etc.
2202
2203         * Scripts/run-jsc-benchmarks:
2204
2205 2017-01-12  Chris Dumez  <cdumez@apple.com>
2206
2207         Add KEYBOARD_KEY_ATTRIBUTE / KEYBOARD_CODE_ATTRIBUTE to FeatureDefines.xcconfig
2208         https://bugs.webkit.org/show_bug.cgi?id=166995
2209
2210         Reviewed by Jer Noble.
2211
2212         Add KEYBOARD_KEY_ATTRIBUTE / KEYBOARD_CODE_ATTRIBUTE to FeatureDefines.xcconfig
2213         as some people are having trouble building without it.
2214
2215         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2216
2217 2017-01-12  Sam Weinig  <sam@webkit.org>
2218
2219         Add the ability to filter the set of bindings tests you want to run
2220         https://bugs.webkit.org/show_bug.cgi?id=166977
2221
2222         Reviewed by Tim Horton.
2223
2224         Allows doing things like:
2225             run-bindings-tests TestObj* TestCEReactions*
2226         
2227         to run only those tests that match the patterns.
2228
2229         * Scripts/run-bindings-tests:
2230         (main):
2231         Switch to using optparse and pass the remaining args as the filters.
2232
2233         * Scripts/webkitpy/bindings/main.py:
2234         (BindingsTests.__init__):
2235         Store the pattens.
2236
2237         (BindingsTests.test_matches_patterns):
2238         Add helper predicate to determine if a test should be run. When no
2239         patterns are present, all tests should run.
2240
2241         (BindingsTests.run_tests):
2242         Filter tests using the passed in patterns.
2243
2244 2017-01-12  Per Arne Vollan  <pvollan@apple.com>
2245
2246         Followup fix after r210503.
2247         https://bugs.webkit.org/show_bug.cgi?id=166887
2248
2249         Reviewed by Alex Christensen.
2250
2251         After <http://trac.webkit.org/changeset/210503>, test results are written to a
2252         duplicated file handle on Windows. This patch fixes the remaining call sites.
2253
2254         * DumpRenderTree/PixelDumpSupport.cpp:
2255         * DumpRenderTree/TestRunner.cpp:
2256         (TestRunner::waitToDumpWatchdogTimerFired):
2257         * DumpRenderTree/TestRunner.h:
2258         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2259         * DumpRenderTree/win/DumpRenderTree.cpp:
2260         * DumpRenderTree/win/DumpRenderTreeWin.h:
2261         * DumpRenderTree/win/TestRunnerWin.cpp:
2262         (TestRunner::setSpellCheckerLoggingEnabled):
2263
2264 2017-01-11  Megan Gardner  <megan_gardner@apple.com>
2265
2266         Add committer status for Megan
2267         https://bugs.webkit.org/show_bug.cgi?id=166954
2268
2269         Reviewed by Tim Horton.
2270
2271         Add committer status for Megan Gardner
2272
2273         * Scripts/webkitpy/common/config/contributors.json:
2274
2275 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
2276
2277         Unreviewed test fix after r210599.
2278
2279         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
2280         (TestWebKitAPI::TEST): Remove debugging code that was causing a timeout.
2281
2282 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
2283
2284         Unreviewed build fix after r210599.
2285
2286         Add missing files.
2287
2288         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
2289         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
2290
2291 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
2292
2293         File scheme should not allow access of a resource on a different volume.
2294         https://bugs.webkit.org/show_bug.cgi?id=158552
2295         <rdar://problem/15307582>
2296
2297         Reviewed by Alex Christensen.
2298
2299         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
2300         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
2301         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
2302
2303 2017-01-11  Ryan Haddad  <ryanhaddad@apple.com>
2304
2305         Unreviewed, rolling out r210571.
2306
2307         This change broke the 32-bit macOS build and caused LayoutTest
2308         failures.
2309
2310         Reverted changeset:
2311
2312         "File scheme should not allow access of a resource on a
2313         different volume."
2314         https://bugs.webkit.org/show_bug.cgi?id=158552
2315         http://trac.webkit.org/changeset/210571
2316
2317 2017-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2318
2319         [GTK] install-dependencies script misses gdb
2320         https://bugs.webkit.org/show_bug.cgi?id=166917
2321
2322         Reviewed by Michael Catanzaro.
2323
2324         gdb is needed for generating the crash logs.
2325
2326         * gtk/install-dependencies:
2327
2328 2017-01-10  Michael Catanzaro  <mcatanzaro@igalia.com>
2329
2330         [GTK] No way for applications to set notification permissions without waiting for permission request
2331         https://bugs.webkit.org/show_bug.cgi?id=163366
2332
2333         Reviewed by Carlos Garcia Campos.
2334
2335         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2336         (testWebViewNotification):
2337         (setInitialNotificationPermissionsAllowedCallback):
2338         (setInitialNotificationPermissionsDisallowedCallback):
2339         (testWebViewNotificationInitialPermissionAllowed):
2340         (testWebViewNotificationInitialPermissionDisallowed):
2341         (beforeAll):
2342         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
2343         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
2344         (WebViewTest::WebViewTest):
2345         (WebViewTest::initializeWebView):
2346         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
2347
2348 2017-01-10  Tim Horton  <timothy_horton@apple.com>
2349
2350         MobileMiniBrowser tests don't work by default
2351         https://bugs.webkit.org/show_bug.cgi?id=166910
2352
2353         Reviewed by Alex Christensen.
2354
2355         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/xcshareddata/xcschemes/MobileMiniBrowserUITests.xcscheme: Added.
2356         Add a shared scheme; the Makefile depends on the MobileMiniBrowserUITests scheme existing, at the very least.
2357
2358 2017-01-10  Brent Fulgham  <bfulgham@apple.com>
2359
2360         File scheme should not allow access of a resource on a different volume.
2361         https://bugs.webkit.org/show_bug.cgi?id=158552
2362         <rdar://problem/15307582>
2363
2364         Reviewed by Alex Christensen.
2365
2366         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
2367         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
2368         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
2369
2370 2017-01-10  Mark Lam  <mark.lam@apple.com>
2371
2372         Reverting run-jsc-stress-tests' $buildType to use string values.
2373         https://bugs.webkit.org/show_bug.cgi?id=166912
2374
2375         Rubber stamped by Filip Pizlo.
2376
2377         This is so that we can test for it in the tests e.g.
2378         //@ if $buildType == "debug" then runDefault("--maxSingleAllocationSize=1048576") else skip end
2379
2380         * Scripts/run-jsc-stress-tests:
2381
2382 2017-01-10  Ryosuke Niwa  <rniwa@webkit.org>
2383
2384         Temporarily add back the file removed in r210463 to unbreak internal bots.
2385
2386         * Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch: Copied from Tools/Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch.
2387
2388 2017-01-10  Jonathan Bedard  <jbedard@apple.com>
2389
2390         svn-apply failed to apply a patch (deleting file with svn property)
2391         https://bugs.webkit.org/show_bug.cgi?id=165953
2392
2393         Reviewed by Daniel Bates.
2394
2395         * Scripts/VCSUtils.pm:
2396         (parseSvnPropertyValue): The beginning of a diff will cause an early exit in the case of no empty newlines.
2397         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl: Add tests without break between diffs for properties.
2398
2399 2017-01-10  Ryan Haddad  <ryanhaddad@apple.com>
2400
2401         Update flakiness dashboard configuration.
2402         https://bugs.webkit.org/show_bug.cgi?id=166869
2403
2404         Reviewed by Alexey Proskuryakov.
2405
2406         * TestResultServer/static-dashboards/builders.jsonp:
2407         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2408
2409 2017-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2410
2411         [GTK] Stop honoring the environment variable USE_NATIVE_XDISPLAY
2412         https://bugs.webkit.org/show_bug.cgi?id=165232
2413
2414         Unreviewed follow-up patch after r210539 and r210523.
2415
2416         Instead of using that environment variable, the argument
2417         --display-server=xorg should be passed now.
2418
2419         The GTK+ performance bot was the only bot using this, and is
2420         already passing --display-server=xorg after r210539.
2421
2422         * Scripts/webkitpy/port/gtk.py:
2423         (GtkPort._driver_class):
2424
2425 2017-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2426
2427         [GTK] Add a new release test bot for Wayland and pass --display-server=xorg to the GTK Perf bot.
2428         https://bugs.webkit.org/show_bug.cgi?id=166872
2429
2430         Reviewed by Michael Catanzaro.
2431
2432         Add the new wayland release test bot as a test-only bot. It will download the built product from the release build-only bot.
2433         Define the required "--display-server=driver" in the bot additionalArguments config entry.
2434         Implement support for honoring additionalArguments on the RunGtkAPITests and RunAndUploadPerfTests steps.
2435         The step RunWebKitTests already has support for it.
2436
2437         * BuildSlaveSupport/build.webkit.org-config/config.json:
2438         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2439         (RunGtkAPITests.start):
2440         (RunAndUploadPerfTests.start):
2441         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2442
2443 2017-01-09  Ryan Haddad  <ryanhaddad@apple.com>
2444
2445         Unreviewed, rolling out r210531.
2446
2447         This change broke the 32-bit macOS build and caused LayoutTest
2448         failures.
2449
2450         Reverted changeset:
2451
2452         "File scheme should not allow access of a resource on a
2453         different volume."
2454         https://bugs.webkit.org/show_bug.cgi?id=158552
2455         http://trac.webkit.org/changeset/210531
2456
2457 2017-01-09  Brent Fulgham  <bfulgham@apple.com>
2458
2459         File scheme should not allow access of a resource on a different volume.
2460         https://bugs.webkit.org/show_bug.cgi?id=158552
2461         <rdar://problem/15307582>
2462
2463         Reviewed by Alex Christensen.
2464
2465         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
2466         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
2467         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
2468
2469 2017-01-09  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2470
2471         [GTK][Wayland] Allow running the layout tests under a native Wayland environment.
2472         https://bugs.webkit.org/show_bug.cgi?id=165232
2473
2474         Reviewed by Michael Catanzaro.
2475
2476         Add a new WaylandDriver to run the tests in the user current wayland session.
2477
2478         Also merge all the configuration options for selecting the display server inside one
2479         switch --display-server=xvfb/xorg/wayland/weston (defaulting to xvfb).
2480
2481         This switch is supported on the scripts: run-gtk-tests, run-perf-tests and run-webkit-tests.
2482
2483         * Scripts/run-gtk-tests: Add missing logging.basicConfig() initialization for the error logger.
2484         (TestRunner._create_driver):
2485         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2486         (parse_args):
2487         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2488         (PerfTestsRunner._parse_args):
2489         * Scripts/webkitpy/port/gtk.py:
2490         (GtkPort.__init__):
2491         (GtkPort._driver_class):
2492         (GtkPort._search_paths):
2493         * Scripts/webkitpy/port/waylanddriver.py: Added.
2494         (WaylandDriver):
2495         (WaylandDriver.check_driver):
2496         (WaylandDriver._setup_environ_for_test):
2497         (WaylandDriver._start):
2498
2499 2017-01-09  Andy Estes  <aestes@apple.com>
2500
2501         [QuickLook] Add a layout test for webkit.org/b/135651
2502         https://bugs.webkit.org/show_bug.cgi?id=166855
2503
2504         Reviewed by Andreas Kling.
2505
2506         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2507         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]): Added output for
2508         errors with code WebKitErrorCannotShowURL.
2509         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2510         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame): Made the error output
2511         not specific to WebKit2 error codes.
2512
2513 2017-01-09  Antoine Quint  <graouts@apple.com>
2514
2515         Support webkit-test-runner key-value pairs in http tests in DumpRenderTree
2516         https://bugs.webkit.org/show_bug.cgi?id=166837
2517
2518         Reviewed by Alex Christensen.
2519
2520         We now correctly handle the --absolutePath argument in DumpRenderTree and use
2521         the provided value when trying to determine the path to the test file. Failing
2522         that, we use the computed URL or the raw path provided to cover all cases.
2523         
2524         This was tested in the context of https://bugs.webkit.org/show_bug.cgi?id=165668
2525         by applying this patch and seeing the number test failures dramatically reduced
2526         with WK1 due to the option to turn modern media controls off for older media controls
2527         tests.
2528
2529         * DumpRenderTree/DumpRenderTree.h:
2530         * DumpRenderTree/DumpRenderTreeCommon.cpp:
2531         (parseInputLine):
2532         * DumpRenderTree/TestOptions.h:
2533         * DumpRenderTree/TestOptions.mm:
2534         (TestOptions::TestOptions):
2535         * DumpRenderTree/mac/DumpRenderTree.mm:
2536         (runTest):
2537
2538 2017-01-09  Milan Crha  <mcrha@redhat.com>
2539
2540         prepare-ChangeLog: Correct help string for --style option
2541         https://bugs.webkit.org/show_bug.cgi?id=166725
2542
2543         Reviewed by Alexey Proskuryakov.
2544
2545         * Scripts/prepare-ChangeLog:
2546         (main):
2547
2548 2017-01-09  Lucas Forschler  <lforschler@apple.com>
2549
2550         https://bugs.webkit.org/show_bug.cgi?id=166839
2551         Add php7 support for macOS.
2552         Mirror the debian logic to look for a php7 module on disk, and return the appropriate apache config file.
2553
2554         Reviewed by Alexey Proskuryakov.
2555
2556         * Scripts/webkitpy/port/base.py:
2557         (Port._is_darwin_php_version_7):
2558         (Port._debian_php_version):
2559         (Port):
2560         (Port._darwin_php_version):
2561         (Port._apache_config_file_name_for_platform):
2562
2563 2017-01-06  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2564
2565         [GTK] Should support key and code properties on keyboard events
2566         https://bugs.webkit.org/show_bug.cgi?id=166759
2567
2568         Reviewed by Carlos Garcia Campos.
2569
2570         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
2571         (WTR::getGDKKeySymForKeyRef): add missing modifier keys which were being reported as 'l' and 'r' only
2572         on tests.
2573
2574 2017-01-06  Per Arne Vollan  <pvollan@apple.com>
2575
2576         [Win] Some tests are flaky because certain DLLs are writing to stdout.
2577         https://bugs.webkit.org/show_bug.cgi?id=166760
2578
2579         Reviewed by Darin Adler.
2580
2581         Some tests are flaky because certain DLLs are writing to stdout, giving incorrect test results.
2582         We can work around that by duplicating and redirecting stdout.
2583
2584         * DumpRenderTree/PixelDumpSupport.cpp:
2585         (dumpWebViewAsPixelsAndCompareWithExpected):
2586         (printPNG):
2587         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2588         (logEventProc):
2589         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
2590         (DRTDesktopNotificationPresenter::showDesktopNotification):
2591         (DRTDesktopNotificationPresenter::cancelDesktopNotification):
2592         (DRTDesktopNotificationPresenter::requestNotificationPermission):
2593         * DumpRenderTree/win/DumpRenderTree.cpp:
2594         (dumpFrameScrollPosition):
2595         (dumpHistoryItem):
2596         (dumpBackForwardList):
2597         (dump):
2598         (runTest):
2599         (main):
2600         * DumpRenderTree/win/DumpRenderTreeWin.h:
2601         * DumpRenderTree/win/EditingDelegate.cpp:
2602         (EditingDelegate::shouldBeginEditingInDOMRange):
2603         (EditingDelegate::shouldEndEditingInDOMRange):
2604         (EditingDelegate::shouldInsertNode):
2605         (EditingDelegate::shouldInsertText):
2606         (EditingDelegate::shouldDeleteDOMRange):
2607         (EditingDelegate::shouldChangeSelectedDOMRange):
2608         (EditingDelegate::shouldApplyStyle):
2609         (EditingDelegate::shouldChangeTypingStyle):
2610         (EditingDelegate::doPlatformCommand):
2611         (EditingDelegate::webViewDidBeginEditing):
2612         (EditingDelegate::webViewDidChange):
2613         (EditingDelegate::webViewDidEndEditing):
2614         (EditingDelegate::webViewDidChangeTypingStyle):
2615         (EditingDelegate::webViewDidChangeSelection):
2616         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2617         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
2618         (FrameLoadDelegate::didReceiveServerRedirectForProvisionalLoadForFrame):
2619         (FrameLoadDelegate::didChangeLocationWithinPageForFrame):
2620         (FrameLoadDelegate::didFailProvisionalLoadWithError):
2621         (FrameLoadDelegate::didCommitLoadForFrame):
2622         (FrameLoadDelegate::didReceiveTitle):
2623         (FrameLoadDelegate::didFinishLoadForFrame):
2624         (FrameLoadDelegate::didFailLoadWithError):
2625         (FrameLoadDelegate::willPerformClientRedirectToURL):
2626         (FrameLoadDelegate::didCancelClientRedirectForFrame):
2627         (FrameLoadDelegate::windowScriptObjectAvailable):
2628         (FrameLoadDelegate::didFinishDocumentLoadForFrame):
2629         (FrameLoadDelegate::didHandleOnloadEventsForFrame):
2630         (FrameLoadDelegate::didDisplayInsecureContent):
2631         (FrameLoadDelegate::didRunInsecureContent):
2632         (FrameLoadDelegate::webViewProgressFinishedNotification):
2633         * DumpRenderTree/win/HistoryDelegate.cpp:
2634         (HistoryDelegate::didNavigateWithNavigationData):
2635         (HistoryDelegate::didPerformClientRedirectFromURL):
2636         (HistoryDelegate::didPerformServerRedirectFromURL):
2637         (HistoryDelegate::updateHistoryTitle):
2638         (HistoryDelegate::populateVisitedLinksForWebView):
2639         * DumpRenderTree/win/PolicyDelegate.cpp:
2640         (PolicyDelegate::decidePolicyForNavigationAction):
2641         (PolicyDelegate::unableToImplementPolicyWithError):
2642         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
2643         (ResourceLoadDelegate::willSendRequest):
2644         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
2645         (ResourceLoadDelegate::didReceiveResponse):
2646         (ResourceLoadDelegate::didFinishLoadingFromDataSource):
2647         (ResourceLoadDelegate::didFailLoadingWithError):
2648         * DumpRenderTree/win/TestRunnerWin.cpp:
2649         (TestRunner::addDisallowedURL):
2650         (TestRunner::originsWithApplicationCache):
2651         (TestRunner::setStorageDatabaseIdleInterval):
2652         (TestRunner::closeIdleLocalStorageDatabases):
2653         (TestRunner::copyDecodedHostName):
2654         (TestRunner::copyEncodedHostName):
2655         (TestRunner::numberOfPendingGeolocationPermissionRequests):
2656         (TestRunner::isGeolocationProviderActive):
2657         (TestRunner::pathToLocalResource):
2658         (TestRunner::setMockDeviceOrientation):
2659         (TestRunner::setMockGeolocationPosition):
2660         (TestRunner::setMockGeolocationPositionUnavailableError):
2661         (TestRunner::setSpatialNavigationEnabled):
2662         (TestRunner::setAutomaticLinkDetectionEnabled):
2663         (TestRunner::isCommandEnabled):
2664         (TestRunner::authenticateSession):
2665         (TestRunner::addChromeInputField):
2666         (TestRunner::removeChromeInputField):
2667         (TestRunner::focusWebView):
2668         (TestRunner::grantWebNotificationPermission):
2669         (TestRunner::denyWebNotificationPermission):
2670         (TestRunner::removeAllWebNotificationPermissions):
2671         (TestRunner::simulateWebNotificationClick):
2672         (TestRunner::imageCountInGeneralPasteboard):
2673         * DumpRenderTree/win/UIDelegate.cpp:
2674         (UIDelegate::runJavaScriptAlertPanelWithMessage):
2675         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
2676         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
2677         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage):
2678         (UIDelegate::webViewAddMessageToConsole):
2679         (UIDelegate::exceededDatabaseQuota):
2680         (UIDelegate::setStatusText):
2681         (UIDelegate::didPressMissingPluginButton):
2682
2683 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2684
2685         Add a setting to create editable MiniBrowser windows by default
2686         https://bugs.webkit.org/show_bug.cgi?id=166806
2687
2688         Reviewed by Beth Dakin.
2689
2690         * MiniBrowser/mac/AppDelegate.m:
2691         (-[BrowserAppDelegate createBrowserWindowController:]):
2692         (-[BrowserAppDelegate applicationDidFinishLaunching:]):
2693         (-[BrowserAppDelegate _updateNewWindowKeyEquivalents]):
2694         * MiniBrowser/mac/SettingsController.h:
2695         * MiniBrowser/mac/SettingsController.m:
2696         (-[SettingsController _populateMenu]):
2697         (-[SettingsController validateMenuItem:]):
2698         (-[SettingsController toggleCreateEditorByDefault:]):
2699         (-[SettingsController createEditorByDefault]):
2700         Add a setting and update the key equivalents accordingly.
2701         Also make sure to make the right kind of window on launch.
2702
2703 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2704
2705         Fix the 32-bit build.
2706
2707         * MiniBrowser/mac/BrowserWindowController.h:
2708         * MiniBrowser/mac/BrowserWindowController.m:
2709
2710 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2711
2712         Fix the 32-bit build.
2713
2714         * MiniBrowser/mac/BrowserWindowController.m:
2715
2716 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2717
2718         Make it possible to drop HTML files on the MiniBrowser icon
2719         https://bugs.webkit.org/show_bug.cgi?id=166802
2720
2721         Reviewed by Simon Fraser.
2722
2723         * MiniBrowser/mac/AppDelegate.m:
2724         (-[BrowserAppDelegate application:openFile:]):
2725         * MiniBrowser/mac/Info.plist:
2726         If you're using an editable window, the usual trick of dropping on the
2727         window doesn't work anymore (it makes an <attachment> instead).
2728
2729 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2730
2731         MiniBrowser window gets smaller each time it is instantiated
2732         https://bugs.webkit.org/show_bug.cgi?id=166807
2733
2734         Reviewed by Andy Estes.
2735
2736         * MiniBrowser/mac/BrowserWindowController.m:
2737         (-[BrowserWindowController windowDidLoad]):
2738         * MiniBrowser/mac/BrowserWindow.xib:
2739         Turn on full-window content view support with IB, instead of waiting
2740         until after the views have been loaded. This seems to resolve the
2741         longstanding ever-shrinking-window problem.
2742
2743 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2744
2745         Add indent/outdent items to MiniBrowser's new format menu
2746         https://bugs.webkit.org/show_bug.cgi?id=166805
2747
2748         Reviewed by Dan Bernstein.
2749
2750         * MiniBrowser/mac/MainMenu.xib:
2751
2752 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2753
2754         Add a stock Format menu to MiniBrowser
2755         https://bugs.webkit.org/show_bug.cgi?id=166804
2756
2757         Reviewed by Andy Estes.
2758
2759         * MiniBrowser/mac/MainMenu.xib:
2760         Many of the features automatically work with editable web views.
2761         However, this seems to expose a bug where none of the font-related features
2762         (Cmd-B, for example) work until the first time the font panel is shown,
2763         per process, which will need to be investigated separately.
2764
2765 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2766
2767         Remove unused applicationWillTerminate methods from MiniBrowser
2768         https://bugs.webkit.org/show_bug.cgi?id=166803
2769
2770         Reviewed by Andy Estes.
2771
2772         * MiniBrowser/mac/AppDelegate.m:
2773         (-[BrowserAppDelegate applicationWillTerminate:]): Deleted.
2774         * MiniBrowser/mac/BrowserWindowController.h:
2775         * MiniBrowser/mac/BrowserWindowController.m:
2776         (-[BrowserWindowController applicationTerminating]): Deleted.
2777         * MiniBrowser/mac/WK1BrowserWindowController.m:
2778         (-[WK1BrowserWindowController applicationTerminating]): Deleted.
2779         * MiniBrowser/mac/WK2BrowserWindowController.m:
2780         (-[WK2BrowserWindowController applicationTerminating]): Deleted.
2781
2782 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2783
2784         Add the ability to create empty contentEditable windows in MiniBrowser
2785         https://bugs.webkit.org/show_bug.cgi?id=166801
2786
2787         Reviewed by Wenson Hsieh.
2788
2789         * MiniBrowser/mac/AppDelegate.h:
2790         * MiniBrowser/mac/AppDelegate.m:
2791         (-[BrowserAppDelegate createBrowserWindowController:]):
2792         (-[BrowserAppDelegate newWindow:]):
2793         (-[BrowserAppDelegate newEditorWindow:]):
2794         (-[BrowserAppDelegate openDocument:]):
2795         (-[BrowserAppDelegate _updateNewWindowKeyEquivalents]):
2796         * MiniBrowser/mac/BrowserWindowController.h:
2797         * MiniBrowser/mac/BrowserWindowController.m:
2798         (-[BrowserWindowController loadHTMLString:]):
2799         (-[BrowserWindowController toggleEditable:]):
2800         * MiniBrowser/mac/MainMenu.xib:
2801         * MiniBrowser/mac/WK1BrowserWindowController.m:
2802         (-[WK1BrowserWindowController awakeFromNib]):
2803         (-[WK1BrowserWindowController loadHTMLString:]):
2804         (-[WK1BrowserWindowController validateMenuItem:]):
2805         (-[WK1BrowserWindowController setEditable:]):
2806         (-[WK1BrowserWindowController updateTitle:]):
2807         * MiniBrowser/mac/WK2BrowserWindowController.m:
2808         (-[WK2BrowserWindowController awakeFromNib]):
2809         (-[WK2BrowserWindowController validateMenuItem:]):
2810         (-[WK2BrowserWindowController setEditable:]):
2811         (-[WK2BrowserWindowController updateTitle:]):
2812         (-[WK2BrowserWindowController loadHTMLString:]):
2813         Merge more functionality from WebEditingTester.
2814         Add two menu items for creating empty editable WebKit1/2 windows.
2815         Add a menu item to the Edit menu to toggle editability on any window.
2816
2817 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2818
2819         Implement find-in-page in MiniBrowser
2820         https://bugs.webkit.org/show_bug.cgi?id=166799
2821
2822         Reviewed by Andy Estes.
2823
2824         * MiniBrowser/mac/BrowserWindow.xib:
2825         * MiniBrowser/mac/BrowserWindowController.h:
2826         * MiniBrowser/mac/BrowserWindowController.m:
2827         (-[BrowserWindowController find:]): Deleted.
2828         * MiniBrowser/mac/MainMenu.xib:
2829         * MiniBrowser/mac/WK1BrowserWindowController.m:
2830         (-[WK1BrowserWindowController toggleShrinkToFit:]):
2831         (-[WK1BrowserWindowController find:]): Deleted.
2832         * MiniBrowser/mac/WK2BrowserWindowController.m:
2833         (-[WK2BrowserWindowController awakeFromNib]):
2834         (-[WK2BrowserWindowController dealloc]):
2835         (-[WK2BrowserWindowController validateMenuItem:]):
2836         (-[WK2BrowserWindowController performTextFinderAction:]):
2837         (-[WK2BrowserWindowController findBarView]):
2838         (-[WK2BrowserWindowController setFindBarView:]):
2839         (-[WK2BrowserWindowController isFindBarVisible]):
2840         (-[WK2BrowserWindowController setFindBarVisible:]):
2841         (-[WK2BrowserWindowController contentView]):
2842         (-[WK2BrowserWindowController findBarViewDidChangeHeight]):
2843         (-[WK2BrowserWindowController performFindPanelAction:]): Deleted.
2844         (-[WK2BrowserWindowController find:]): Deleted.
2845         Implement find-in-page using WKWebView's conformance to the NSTextFinderClient
2846         protocol. At first glance, it's pretty broken, but vaguely works.
2847
2848 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2849
2850         Share the implementation of MiniBrowser view hiding functionality
2851         https://bugs.webkit.org/show_bug.cgi?id=166800
2852
2853         Reviewed by Andy Estes.
2854
2855         * MiniBrowser/mac/BrowserWindowController.m:
2856         (-[BrowserWindowController showHideWebView:]):
2857         (-[BrowserWindowController removeReinsertWebView:]):
2858         * MiniBrowser/mac/WK1BrowserWindowController.m:
2859         (-[WK1BrowserWindowController showHideWebView:]): Deleted.
2860         (-[WK1BrowserWindowController removeReinsertWebView:]): Deleted.
2861         * MiniBrowser/mac/WK2BrowserWindowController.m:
2862         (-[WK2BrowserWindowController showHideWebView:]): Deleted.
2863         (-[WK2BrowserWindowController removeReinsertWebView:]): Deleted.
2864         Move the implementation of these two things to the shared superclass,
2865         since they don't depend on WebKit-specific things.
2866         Also, there was no reason to retain the (WK)WebView while it was unparented,
2867         as the BrowserWindowController maintains a reference the entire time.
2868
2869 2017-01-06  Andy Estes  <aestes@apple.com>
2870
2871         [Cocoa] Consolidate duplicate copies of WebArchiveDumpSupport in DRT and WKTR into WebCoreTestSupport
2872         https://bugs.webkit.org/show_bug.cgi?id=166789
2873
2874         Reviewed by Alex Christensen.
2875
2876         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2877         * DumpRenderTree/PlatformMac.cmake:
2878         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp: Removed.
2879         * DumpRenderTree/cf/WebArchiveDumpSupport.h: Removed.
2880         * DumpRenderTree/mac/DumpRenderTree.mm:
2881         Called WebCoreTestSupport::createXMLStringFromWebArchiveData() instead of
2882         createXMLStringFromWebArchiveData().
2883         * DumpRenderTree/mac/WebArchiveDumpSupportMac.mm: Removed.
2884         * WebKitTestRunner/Configurations/Base.xcconfig:
2885         Added $(BUILT_PRODUCTS_DIR)/WebCoreTestSupport to HEADER_SEARCH_PATHS.
2886         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2887         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
2888         Called WebCoreTestSupport::createXMLStringFromWebArchiveData() instead of
2889         createXMLStringFromWebArchiveData().
2890         * WebKitTestRunner/InjectedBundle/cocoa/WebArchiveDumpSupportCocoa.mm: Removed.
2891         * WebKitTestRunner/PlatformMac.cmake:
2892         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2893         * WebKitTestRunner/cf/WebArchiveDumpSupport.h: Removed.
2894
2895 2017-01-06  Tim Horton  <timothy_horton@apple.com>
2896
2897         Minor cleanups to IndentOutdentCommand and related code
2898         https://bugs.webkit.org/show_bug.cgi?id=166791
2899
2900         Reviewed by Simon Fraser.
2901
2902         * WebEditingTester/EditingOperations.m:
2903         (editingOperations):
2904         Add the outdent operation to WebEditingTester.
2905
2906 2017-01-06  Said Abou-Hallawa  <sabouhallawa@apple.com>
2907
2908         Create a plan and a patch files for MotionMark and delete the Animometer's ones
2909         https://bugs.webkit.org/show_bug.cgi?id=166785
2910
2911         Reviewed by Ryosuke Niwa.
2912
2913         * Scripts/webkitpy/benchmark_runner/data/patches/MotionMark.patch: Renamed from Tools/Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch.
2914         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan: Renamed from Tools/Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan.
2915
2916 2017-01-06  Antoine Quint  <graouts@apple.com>
2917
2918         Support webkit-test-runner key-value pairs in http tests
2919         https://bugs.webkit.org/show_bug.cgi?id=149812
2920
2921         Reviewed by Alex Christensen.
2922
2923         We pass the absolute path for a test through to WKTR so that we can parse
2924         tests that are running as URLs for webkit-test-runner options.
2925
2926         * DumpRenderTree/DumpRenderTreeCommon.cpp:
2927         (parseInputLine):
2928
2929         Explicitly skip the --absolute-path option in DRT or else we'd crash.
2930
2931         * Scripts/webkitpy/port/driver.py:
2932         (Driver._command_from_driver_input):
2933
2934         Pass the absolute path to the file through the CLI.
2935
2936         * WebKitTestRunner/TestController.cpp:
2937         (WTR::updateTestOptionsFromTestHeader):
2938         (WTR::TestController::testOptionsForTest):
2939         (WTR::parseInputLine):
2940         (WTR::TestController::runTest):
2941         * WebKitTestRunner/TestController.h:
2942
2943 2017-01-06  Tim Horton  <timothy_horton@apple.com>
2944
2945         Warning about unconnectable outlets when opening a MiniBrowser window
2946         https://bugs.webkit.org/show_bug.cgi?id=166756
2947
2948         Reviewed by Dan Bernstein.
2949
2950         * MiniBrowser/mac/BrowserWindow.xib:
2951         When launching MiniBrowser, it says:
2952         Failed to connect (Share) outlet from (WK1BrowserWindowController) to
2953             (MBToolbarItem): missing setter or instance variable
2954         Failed to connect (shareButton) outlet from (WK1BrowserWindowController) to
2955             (NSButtonCell): missing setter or instance variable.
2956
2957         It looks like someone added the connection from the share button
2958         to the BrowserWindowController three times; only one of the connections
2959         is valid. Remove the other two.
2960
2961 2017-01-05  Keith Rollin  <krollin@apple.com>
2962
2963         Add WebCore::URL::protocolHostAndPort
2964         https://bugs.webkit.org/show_bug.cgi?id=166426
2965
2966         Reviewed by Alex Christensen.
2967
2968         Add test for protocolHostAndPort.
2969
2970         * TestWebKitAPI/Tests/WebCore/URL.cpp:
2971         (TestWebKitAPI::TEST_F):
2972
2973 2017-01-05  Per Arne Vollan  <pvollan@apple.com>
2974
2975         [Win] Archive test result is failing.
2976         https://bugs.webkit.org/show_bug.cgi?id=166720
2977
2978         Reviewed by Alex Christensen.
2979
2980         Deleting the layout test result folder is sometimes failing
2981         on Windows. This is not a critical error.
2982
2983         * BuildSlaveSupport/test-result-archive:
2984         (archiveTestResults):
2985
2986 2017-01-04  Tomas Popela  <tpopela@redhat.com>
2987
2988         [GTK] Minibrowser: Add printing support
2989         https://bugs.webkit.org/show_bug.cgi?id=165298
2990
2991         Open a print dialog when the Ctrl + P shortcut is pressed. If there is
2992         an error during the print, it's printed on the console.
2993
2994         Reviewed by Michael Catanzaro.
2995
2996         * MiniBrowser/gtk/BrowserWindow.c:
2997         (webKitPrintOperationFailedCallback):
2998         (printPage):
2999         (browser_window_init):
3000
3001 2017-01-04  Manuel Rego Casasnovas  <rego@igalia.com>
3002
3003         [css-grid] Fix crash clamping grid lines
3004         https://bugs.webkit.org/show_bug.cgi?id=166637
3005
3006         Reviewed by Darin Adler.
3007
3008         Creates new unit test to verify that the maximum tracks limit
3009         is used in GridPosition too.
3010
3011         * TestWebKitAPI/PlatformEfl.cmake:
3012         * TestWebKitAPI/PlatformGTK.cmake:
3013         * TestWebKitAPI/PlatformWin.cmake:
3014         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3015         * TestWebKitAPI/Tests/WebCore/GridPosition.cpp: Added.
3016         (TestWebKitAPI::TEST):
3017
3018 2017-01-04  Wenson Hsieh  <wenson_hsieh@apple.com>
3019
3020         Move editing history scripts to WebCore PrivateHeaders
3021         https://bugs.webkit.org/show_bug.cgi?id=166709
3022         <rdar://problem/29876612>
3023
3024         Reviewed by Dan Bernstein.
3025
3026         Update references to editing script files in WebCore that were moved.
3027
3028         * EditingHistory/EditingHistory.xcodeproj/project.pbxproj:
3029
3030 2017-01-04  Yusuke Suzuki  <utatane.tea@gmail.com>
3031
3032         Unreviewed, build fix after r210313 part 2
3033         https://bugs.webkit.org/show_bug.cgi?id=166676
3034
3035         Add 'U' suffix.
3036
3037         * TestWebKitAPI/Tests/WTF/StringView.cpp:
3038         (TestWebKitAPI::TEST):
3039         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
3040         (TestWebKitAPI::TEST):
3041
3042 2017-01-04  Yusuke Suzuki  <utatane.tea@gmail.com>
3043
3044         Limit thread name appropriately
3045         https://bugs.webkit.org/show_bug.cgi?id=166676
3046
3047         Reviewed by Sam Weinig.
3048
3049         * TestWebKitAPI/Tests/WTF/StringView.cpp:
3050         (TestWebKitAPI::TEST):
3051         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
3052         (TestWebKitAPI::TEST):
3053
3054 2017-01-04  Andy Estes  <aestes@apple.com>
3055
3056         [Cocoa] Teach SharedBuffer to return an NSArray of data segments to avoid flattening
3057         https://bugs.webkit.org/show_bug.cgi?id=166696
3058
3059         Reviewed by Tim Horton.
3060
3061         * TestWebKitAPI/PlatformGTK.cmake:
3062         * TestWebKitAPI/PlatformWin.cmake:
3063         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3064         * TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp: Moved class SharedBufferTest to SharedBufferTest.{cpp,h}.
3065         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp: Moved class SharedBufferTest from SharedBuffer.cpp.
3066         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.h: Ditto.
3067         * TestWebKitAPI/Tests/WebCore/cocoa/SharedBuffer.mm: Added.
3068         (TestWebKitAPI::expectDataArraysEqual): Added a helper to assert that two NSArrays of NSData are equal.
3069         (TestWebKitAPI::TEST_F): Added a test for createNSDataArray.
3070
3071 2017-01-03  Brian Burg  <bburg@apple.com>
3072
3073         Web Inspector: teach the protocol generator about platform-specific types, events, and commands
3074         https://bugs.webkit.org/show_bug.cgi?id=166003
3075         <rdar://problem/28718990>
3076
3077         Reviewed by Joseph Pecoraro.
3078
3079         Teach run-inspector-generator-tests to generate test output using the platform name
3080         derived from the directory that the test is in. For example, tests in the /generic/
3081         subdirectory will pass `--platform generic` to generate-inspector-protocol-bindings.py.
3082
3083         * Scripts/webkitpy/inspector/main.py:
3084         (InspectorGeneratorTests.generate_from_json):
3085         (InspectorGeneratorTests.run_tests):
3086         (InspectorGeneratorTests.main):
3087
3088 2017-01-04  Csaba Osztrogonác  <ossy@webkit.org>
3089
3090         Unreviewed cmake buildfix after r210266.
3091
3092         * DumpRenderTree/PlatformMac.cmake:
3093
3094 2017-01-04  Tim Horton  <timothy_horton@apple.com>
3095
3096         Provide a setting for clients to always prefer low-power WebGL
3097         https://bugs.webkit.org/show_bug.cgi?id=166675
3098         <rdar://problem/29834093>
3099
3100         Reviewed by Dan Bernstein.
3101
3102         * MiniBrowser/mac/Info.plist:
3103         Have MiniBrowser claim to be a modern app that supports
3104         automatic graphics switching. WebKit needs to support automatic
3105         graphics switching, so our test app might as well. Without this
3106         Info.plist parameter, this change has no effect, and bringing up
3107         a WebGL context still brings up the discrete GPU (also true of the
3108         existing web-exposed preferLowPowerToHighPerformance API).
3109
3110 2017-01-03  Yusuke Suzuki  <utatane.tea@gmail.com>
3111
3112         WorkQueueGeneric's platformInvalidate() can deadlock when called on the RunLoop's thread
3113         https://bugs.webkit.org/show_bug.cgi?id=166645
3114
3115         Reviewed by Carlos Garcia Campos.
3116
3117         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
3118         (TestWebKitAPI::TEST):
3119
3120 2017-01-03  Andy Estes  <aestes@apple.com>
3121
3122         Place all the Cocoa WebCore API tests in the same directory
3123         https://bugs.webkit.org/show_bug.cgi?id=166673
3124
3125         Reviewed by Michael Catanzaro.
3126
3127         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3128         * TestWebKitAPI/Tests/WebCore/cocoa/SerializedCryptoKeyWrap.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/SerializedCryptoKeyWrap.mm.
3129         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm: Renamed from Tools/TestWebKitAPI/Tests/Cocoa/URLExtras.mm.
3130         * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm.
3131
3132 2017-01-03  Tim Horton  <timothy_horton@apple.com>
3133
3134         NSSpellChecker's recordResponse isn't called for unseen automatic corrections
3135         https://bugs.webkit.org/show_bug.cgi?id=166450
3136         <rdar://problem/29447824>
3137
3138         Reviewed by Darin Adler.
3139
3140         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3141         * DumpRenderTree/TestRunner.cpp:
3142         (TestRunner::staticFunctions):
3143         * DumpRenderTree/mac/TestRunnerMac.mm:
3144         (setSpellCheckerLoggingEnabledCallback):
3145         * DumpRenderTree/win/TestRunnerWin.cpp:
3146         (setSpellCheckerLoggingEnabledCallback):
3147         * DumpRenderTree/mac/DumpRenderTree.mm:
3148         (resetWebViewToConsistentStateBeforeTesting):
3149         * DumpRenderTree/mac/DumpRenderTreeSpellChecker.h: Added.
3150         * DumpRenderTree/mac/DumpRenderTreeSpellChecker.mm: Added.
3151         (stringForCorrectionResponse):
3152         (drt_NSSpellChecker_recordResponseToCorrection):
3153         (swizzleNSSpellCheckerMethodsIfNeeded):
3154         (setSpellCheckerLoggingEnabled):
3155         Add a new testRunner method, setSpellCheckerLoggingEnabled, which, when
3156         set to true, logs to stdout (which ends up in the test result) whenever
3157         NSSpellChecker recordResponse:toCorrection:forWord:language:inSpellDocumentWithTag:
3158         is called, and then calls the original method. It is reset to false between tests.
3159
3160 2017-01-03  Sam Weinig  <sam@webkit.org>
3161
3162         Make WTF::Expected support Ref template parameters
3163         https://bugs.webkit.org/show_bug.cgi?id=166662
3164
3165         Reviewed by Alex Christensen.
3166
3167         * TestWebKitAPI/Tests/WTF/Expected.cpp:
3168         (TestWebKitAPI::TEST):
3169         Add tests for using Ref with Expected.
3170
3171 2017-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3172
3173         [GTK] Expose WebKitSecurityOrigin API
3174         https://bugs.webkit.org/show_bug.cgi?id=166632
3175
3176         Reviewed by Carlos Garcia Campos.
3177
3178         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
3179         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSecurityOrigin.cpp: Added.
3180         (testSecurityOriginBasicConstructor):
3181         (testSecurityOriginURIConstructor):
3182         (testSecurityOriginDefaultPort):
3183         (testSecurityOriginFileURI):
3184         (testSecurityOriginDataURI):
3185         (beforeAll):
3186         (afterAll):
3187
3188 2017-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3189
3190         [GTK] HTTP auth layout tests are flaky
3191         https://bugs.webkit.org/show_bug.cgi?id=158919
3192
3193         Reviewed by Michael Catanzaro.
3194
3195         * gtk/jhbuild.modules: Update libsoup to version 2.57.1.
3196         * gtk/jhbuildrc: Stop passing --enable-introspection unconditionally to all modules. We don't really need
3197         introspection for the dependencies in the internal build, and it makes newer libsoup build fail because of
3198         missing valac in the bots.
3199
3200 2017-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3201
3202         REGRESSION(r173753): [GTK] Source/WebKit is distributed in tarballs
3203         https://bugs.webkit.org/show_bug.cgi?id=165797
3204
3205         Reviewed by Michael Catanzaro.
3206
3207         Move directory ruleset after all exclude rules of Source rulset.
3208
3209         * gtk/manifest.txt.in:
3210
3211 2017-01-02  Yusuke Suzuki  <utatane.tea@gmail.com>
3212
3213         Leverage Substring to create new AtomicStringImpl for StaticStringImpl and SymbolImpl
3214         https://bugs.webkit.org/show_bug.cgi?id=166636
3215
3216         Reviewed by Darin Adler.
3217
3218         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
3219         (TestWebKitAPI::TEST):
3220
3221 2017-01-02  Manuel Rego Casasnovas  <rego@igalia.com>
3222
3223         [GTK] WebCore/CSSParser unit test is not being built
3224         https://bugs.webkit.org/show_bug.cgi?id=166492
3225
3226         Reviewed by Michael Catanzaro.
3227
3228         This test was introduced in r175930, but we were not building
3229         it on GTK+ port since r176015.
3230         This patch marks the test to be built again on GTK+.
3231         JFTR, the test is passing right now.
3232
3233         * TestWebKitAPI/PlatformGTK.cmake: Add CSSParser.cpp test file and use
3234         ADD_WHOLE_ARCHIVE_TO_LIBRARIES to avoid linking errors.
3235
3236 2017-01-02  Chris Fleizach  <cfleizach@apple.com>
3237
3238         AX: Expose block quote level to iOS API
3239         https://bugs.webkit.org/show_bug.cgi?id=166629
3240         <rdar://problem/29834793>
3241
3242         Reviewed by Darin Adler.
3243
3244         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3245         (AccessibilityUIElement::numberAttributeValue):
3246         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3247         (WTR::AccessibilityUIElement::numberAttributeValue):
3248
3249 2016-12-31  Michael Catanzaro  <mcatanzaro@igalia.com>
3250
3251         SecurityOrigin::create triplet constructor does not canonicalize port
3252         https://bugs.webkit.org/show_bug.cgi?id=166624
3253
3254         Reviewed by Daniel Bates.
3255
3256         * TestWebKitAPI/PlatformGTK.cmake:
3257         * TestWebKitAPI/PlatformWin.cmake:
3258         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3259         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp: Added.
3260         (TestWebKitAPI::SecurityOriginTest::SetUp):
3261         (TestWebKitAPI::TEST_F):
3262
3263 2016-12-30  Michael Catanzaro  <mcatanzaro@igalia.com>
3264
3265         [GTK] Improve user agent construction
3266         https://bugs.webkit.org/show_bug.cgi?id=142074
3267
3268         Reviewed by Carlos Garcia Campos.
3269
3270         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3271         (TestWebKitAPI::assertUserAgentForURLHasChromeBrowserQuirk):
3272         (TestWebKitAPI::assertUserAgentForURLHasFirefoxBrowserQuirk):
3273         (TestWebKitAPI::assertUserAgentForURLHasLinuxPlatformQuirk):
3274         (TestWebKitAPI::assertUserAgentForURLHasMacPlatformQuirk):
3275         (TestWebKitAPI::TEST):
3276
3277 2016-12-27  Michael Catanzaro  <mcatanzaro@igalia.com>
3278
3279         [GTK] Improve user agent construction
3280         https://bugs.webkit.org/show_bug.cgi?id=142074
3281
3282         Reviewed by Carlos Garcia Campos.
3283
3284         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3285         (TestWebKitAPI::TEST):
3286
3287 2016-12-23  Simon Fraser  <simon.fraser@apple.com>
3288
3289         REGRESSION (r209299): Selection is broken when you zoom in webpage using trackpad
3290         https://bugs.webkit.org/show_bug.cgi?id=166472
3291         rdar://problem/29675551
3292
3293         Reviewed by Tim Horton.
3294
3295         These changes are necessary to allow the mouse to leave the WTR window while
3296         drag-scrolling, to test autoscroll. Previously, we were never calling -mouseDragged
3297         (which DRT does); we'd always go through mouseMoved, which hits an early return
3298         in WebViewImpl::mouseMoved() when the point is outside the view.
3299
3300         * WebKitTestRunner/mac/EventSenderProxy.mm:
3301         (WTR::EventSenderProxy::mouseMoveTo):
3302
3303 2016-12-23  Andy Estes  <aestes@apple.com>
3304
3305         [iOS] Fix some crashing webarchive tests
3306         https://bugs.webkit.org/show_bug.cgi?id=166470
3307
3308         Reviewed by Andreas Kling.
3309
3310         Tests that use TestRunner.dumpDOMAsWebArchive() crashed on iOS due to a stub implementation
3311         of WebArchiveDumpSupport in WebKitTestRunner. The Mac implementation works fine on iOS too,
3312         so this change uses that on both platforms.
3313
3314         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Removed
3315         WebArchiveDumpSupportMac.mm from EXCLUDED_SOURCE_FILE_NAMES.
3316         * WebKitTestRunner/InjectedBundle/cocoa/WebArchiveDumpSupportCocoa.mm: Renamed from
3317         Tools/WebKitTestRunner/mac/WebArchiveDumpSupportMac.mm.
3318         * WebKitTestRunner/PlatformMac.cmake:
3319         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3320         * WebKitTestRunner/ios/WebArchiveDumpSupportIOS.mm: Removed.
3321
3322 2016-12-22  Saam Barati  <sbarati@apple.com>
3323
3324         WebAssembly: Silence the output of the spec-tests
3325         https://bugs.webkit.org/show_bug.cgi?id=166417
3326
3327         Reviewed by Mark Lam.
3328
3329         * Scripts/run-jsc-stress-tests:
3330
3331 2016-12-22  Zhuo Li  <zachli@apple.com>
3332
3333         [Cocoa] SPI for setloadsImagesAutomatically.
3334         https://bugs.webkit.org/show_bug.cgi?id=166401.
3335
3336         Reviewed by Darin Adler.
3337
3338         * TestWebKitAPI/Tests/WebKit2Cocoa/Preferences.mm:
3339         (TEST): Test the _setLoadsImagesAutomatically SPI. By default,
3340         _loadsImagesAutomatically returns YES.
3341
3342 2016-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3343
3344         fast/events/ios/viewport-shrink-to-fit-allows-double-tap.html is flaky/order dependent
3345         https://bugs.webkit.org/show_bug.cgi?id=161328
3346         <rdar://problem/28475977>
3347
3348         Reviewed by Darin Adler.
3349
3350         Running a test that scales the viewport and listens to a didEndZooming callback (such as
3351         viewport-shrink-to-fit-allows-double-tap.html) immediately after a test that may begin to trigger viewport
3352         scaling as the test completes (such as viewport-device-width-at-initial-scale-fast-clicks.html) may result in
3353         the didEndZooming callback of the latter test being fired early due to the previous test triggering a zoom
3354         animation. Ideally, -[WKScrollView _stopScrollingAndZoomingAnimations], which is called when committing the page
3355         load, should prevent this from happening, but from reading documentation and code inspection, this is not
3356         intended to fire any associated delegate methods or notifications of the UIScrollView, instead deferring them
3357         for later. Instead, what we need in this case is to clear out any started but not yet completed animations after
3358         we finish running a test and before we load the next test.
3359
3360         One way to do this is to remove all animations from the WKScrollView's layer, and the layers of its children,
3361         recursively. Doing so causes scrollViewDidEndZooming:withView:atScale: to fire at the end of the runloop if the
3362         previous test started zooming and then finished before zooming completed. Since this happens before the next
3363         test has a chance to run UI-side scripts, we won't end up firing this callback prematurely during the next test.
3364
3365         * WebKitTestRunner/ios/TestControllerIOS.mm:
3366         (WTR::TestController::platformResetStateToConsistentValues):
3367
3368 2016-12-22  Jer Noble  <jer.noble@apple.com>
3369
3370         Muted media element playback should not interrupt other audio playback
3371         https://bugs.webkit.org/show_bug.cgi?id=166347
3372
3373         Reviewed by Eric Carlson.
3374
3375         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3376         * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:
3377         (TestWebKitAPI::TEST):
3378         * TestWebKitAPI/Tests/WebKit/ios/video-with-muted-audio.html: Added.
3379
3380 2016-12-22  Alejandro G. Castro  <alex@igalia.com>
3381
3382         [WebRTC] Add support for runtime PeeConnection setting, required after r209757
3383         https://bugs.webkit.org/show_bug.cgi?id=166346
3384
3385         Reviewed by Carlos Garcia Campos.
3386
3387         Enable WebRTC by default to simplify testing.
3388
3389         * MiniBrowser/gtk/main.c:
3390         (main):
3391
3392 2016-12-21  Alexey Proskuryakov  <ap@apple.com>
3393
3394         REGRESSION: API test failure: WKWebView.LocalStorageClear
3395         https://bugs.webkit.org/show_bug.cgi?id=166032
3396         <rdar://problem/29758423>
3397
3398         Reviewed by Simon Fraser.
3399
3400         Add an @autoreleasepool around the code that allocates then clears the WKWebView, 
3401         to ensure that the view is destroyed before the callback fires.
3402
3403         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
3404         (TEST):
3405
3406 2016-12-21  Saam Barati  <sbarati@apple.com>
3407
3408         WebAssembly: Import spec tests
3409         https://bugs.webkit.org/show_bug.cgi?id=166395
3410
3411         Rubber stamped by Keith Miller.
3412
3413         * Scripts/run-jsc-stress-tests:
3414
3415 2016-12-21  Alexey Proskuryakov  <ap@apple.com>
3416
3417         REGRESSION: API test failure: _WKDownload.OriginatingWebView
3418         https://bugs.webkit.org/show_bug.cgi?id=166033
3419         <rdar://problem/29758428>
3420
3421         Reviewed by Simon Fraser.
3422
3423         Add an @autoreleasepool around the code that allocates the WKWebView, 
3424         so that it can be destroyed by removing the last reference in _downloadDidStart.
3425
3426         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
3427         (TEST):
3428
3429 2016-12-21  Daniel Bates  <dabates@apple.com>
3430
3431         WebKitTestRunner: Add comment to TestRunner::setCanOpenWindows()
3432         https://bugs.webkit.org/show_bug.cgi?id=166356
3433
3434         Add comment in TestRunner::setCanOpenWindows() to elaborate further on its purpose
3435         as a means to allow a test to explicit allow an embedding client to open a new windows
3436         such that the default behavior is for the embedding client to forbid such an action.
3437         The test plugins/get-url-with-blank-target.html assumes this default behavior though
3438         it is currently skipped on WebKit2 because questions were raised in the patch for
3439         <https://bugs.webkit.org/show_bug.cgi?id=43389> about its correctness and usefulness.
3440         We will need to implement TestRunner::setCanOpenWindows() should we decide to unskip
3441         this test.
3442
3443         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3444         (WTR::TestRunner::setCanOpenWindows):
3445
3446 2016-12-20  Simon Fraser  <simon.fraser@apple.com>
3447
3448         REGRESSION: API test failure: WKWebView.EvaluateJavaScriptBlockCrash
3449         https://bugs.webkit.org/show_bug.cgi?id=166031
3450
3451         Reviewed by Tim Horton.
3452         
3453         Add an @autoreleasepool around the code that allocates then clears the WKWebView, 
3454         to ensure that the view is destroyed before the callback fires.
3455
3456         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm:
3457
3458 2016-12-20  Megan Gardner  <megan_gardner@apple.com>
3459
3460         Throw Exception when test doesn't clean up HID Events properly
3461         https://bugs.webkit.org/show_bug.cgi?id=166271
3462
3463         Reviewed by Simon Fraser.
3464
3465         Add in a check when UIScriptController is deleted to make sure that the HID event
3466         callback dictionary is empty. If it is not, and a HID event is hit, this will cause
3467         the program to crash without any good information. Crashes are race-y, and will still
3468         happen with malformed test, but the information will be much more helpful. 
3469
3470         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3471         (WTR::UIScriptController::checkForClean):
3472         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
3473         (UIScriptContext::~UIScriptContext):
3474         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3475         (WTR::UIScriptController::checkForClean):
3476         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3477         * WebKitTestRunner/ios/HIDEventGenerator.h:
3478         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3479         (-[HIDEventGenerator checkHIDCallbacksClear]):
3480         * WebKitTestRunner/ios/TestControllerIOS.mm:
3481         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3482         (WTR::UIScriptController::checkForClean):
3483
3484 2016-12-20  Andy Estes  <aestes@apple.com>
3485
3486         [Cocoa] REGRESSION (r209558): Calling decisionHandler multiple times in webView:decidePolicyForNavigationAction:decisionHandler: leads to a crash
3487         https://bugs.webkit.org/show_bug.cgi?id=165992
3488
3489         Reviewed by Brady Eidson.
3490
3491         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3492         * TestWebKitAPI/Tests/WebKit2Cocoa/DuplicateCompletionHandlerCalls.mm: Added.
3493         (expectException):
3494         (-[DuplicateCompletionHandlerCallsDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3495         (-[DuplicateCompletionHandlerCallsDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3496         (-[DuplicateCompletionHandlerCallsDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3497         (-[DuplicateCompletionHandlerCallsDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
3498         (-[DuplicateCompletionHandlerCallsDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:completionHandler:]):
3499         (-[DuplicateCompletionHandlerCallsDelegate _webView:decideDatabaseQuotaForSecurityOrigin:currentQuota:currentOriginUsage:currentDatabaseUsage:expectedUsage:decisionHandler:]):
3500         (-[DuplicateCompletionHandlerCallsDelegate _webView:willSubmitFormValues:userObject:submissionHandler:]):
3501         (TEST):
3502         * TestWebKitAPI/Tests/WebKit2Cocoa/duplicate-completion-handler-calls.html: Added.
3503
3504 2016-12-20  Dean Jackson  <dino@apple.com>
3505
3506         Remove INDIE_UI
3507         https://bugs.webkit.org/show_bug.cgi?id=165881
3508         <rdar://problem/29672532>
3509
3510         Reviewed by Simon Fraser.
3511
3512         The Indie UI work has been discontinued.
3513
3514         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3515
3516 2016-12-19  Yusuke Suzuki  <utatane.tea@gmail.com>
3517
3518         [ES6] Enable ES6 Modules
3519         https://bugs.webkit.org/show_bug.cgi?id=165849
3520
3521         Reviewed by Geoffrey Garen.
3522
3523         * DumpRenderTree/mac/DumpRenderTree.mm:
3524         (resetWebPreferencesToConsistentValues):
3525         * DumpRenderTree/win/DumpRenderTree.cpp:
3526         (resetWebPreferencesToConsistentValues):
3527         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3528         (WTR::InjectedBundle::beginTesting):
3529         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3530         (WTR::TestRunner::setES6ModulesEnabled): Deleted.
3531         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3532
3533 2016-12-19  Ryan Haddad  <ryanhaddad@apple.com>
3534
3535         Repurpose bots and clean up dashboard.
3536         https://bugs.webkit.org/show_bug.cgi?id=166045
3537
3538         Reviewed by Lucas Forschler.
3539
3540         * BuildSlaveSupport/build.webkit.org-config/config.json:
3541         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3542         (BubbleQueueServer):
3543         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3544         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3545         (WebKitBuildbot):
3546         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3547         (table.queue-grid tr.platform.mac-os-x-yosemite img.logo): Deleted.
3548
3549 2016-12-19  Michael Catanzaro  <mcatanzaro@igalia.com>
3550
3551         [CMake] TestWebKitAPIBase links to itself
3552         https://bugs.webkit.org/show_bug.cgi?id=165985
3553
3554         Reviewed by Alex Christensen.
3555
3556         Fix CMake warning about a target linking to itself, which makes no sense.
3557
3558         * TestWebKitAPI/CMakeLists.txt:
3559
3560 2016-12-19  Michael Catanzaro  <mcatanzaro@igalia.com>
3561
3562         [GTK] GtkDoc build should be quieter
3563         https://bugs.webkit.org/show_bug.cgi?id=165994
3564
3565         Reviewed by Carlos Garcia Campos.
3566
3567         Make it not print by default.
3568
3569         * gtk/generate-gtkdoc:
3570         (get_generator_for_config):
3571         (generate_doc):
3572         * gtk/gtkdoc.py:
3573         (GTKDoc._run_command):
3574         (GTKDoc._copy_doc_files_to_output_dir):
3575
3576 2016-12-18  Simon Fraser  <simon.fraser@apple.com>
3577
3578         Expose a way for MiniBrowser to simulate header and footer banners
3579         https://bugs.webkit.org/show_bug.cgi?id=166005
3580
3581         Reviewed by Wenson Hsieh.
3582         
3583         Add a MiniBrowser menu item and setting to toggle adding space for header and footer
3584         banners. This only works in WebKit2.
3585         
3586         We need to reset these on each navigation, since newly created FrameViews
3587         don't re-fetch the header and footer height stored on Page.
3588         
3589         Also fix the signature of webView:didFinishNavigation: to follow API changes,
3590         as well as fixing webViewWebContentProcessDidTerminate:
3591
3592         * MiniBrowser/mac/SettingsController.h:
3593         * MiniBrowser/mac/SettingsController.m:
3594         (-[SettingsController _populateMenu]):
3595         (-[SettingsController validateMenuItem:]):
3596         (-[SettingsController toggleReserveSpaceForBanners:]):
3597         (-[SettingsController isSpaceReservedForBanners]):
3598         * MiniBrowser/mac/WK2BrowserWindowController.m:
3599         (-[WK2BrowserWindowController didChangeSettings]):
3600         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
3601         (-[WK2BrowserWindowController webViewWebContentProcessDidTerminate:]):
3602         (-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]): Deleted.
3603         (-[WK2BrowserWindowController _webViewWebProcessDidCrash:]): Deleted.
3604
3605 2016-12-17  Simon Fraser  <simon.fraser@apple.com>
3606
3607         Fix iOS test results after r209967.
3608         
3609         Subtracting out the status bar height was erroneously happening for all tests,
3610         not just for flexible viewport tests.
3611         
3612         Fix by plumbing WebViewSizingMode through resizeTo() and setWindowFrame().
3613
3614         * WebKitTestRunner/PlatformWebView.h:
3615         * WebKitTestRunner/TestController.cpp:
3616         (WTR::TestController::resetStateToConsistentValues):
3617         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
3618         (WTR::PlatformWebView::resizeTo):
3619         (WTR::PlatformWebView::setWindowFrame):
3620         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3621         (WTR::PlatformWebView::resizeTo):
3622         (WTR::PlatformWebView::setWindowFrame):
3623         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3624         (WTR::PlatformWebView::resizeTo):
3625         (WTR::PlatformWebView::setWindowFrame):
3626         * WebKitTestRunner/ios/TestControllerIOS.mm:
3627         (WTR::TestController::platformConfigureViewForTest):
3628         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3629         (WTR::PlatformWebView::resizeTo):
3630         (WTR::PlatformWebView::setWindowFrame):
3631
3632 2016-12-17  Joonghun Park  <jh718.park@samsung.com>
3633
3634         [EFL] bump EFL version to 1.18.4
3635         https://bugs.webkit.org/show_bug.cgi?id=166004
3636
3637         Reviewed by Gyuyoung Kim.
3638
3639         * efl/jhbuild.modules: Use efl-1.18.4 instead of 1.18.1.
3640
3641 2016-12-17  Wenson Hsieh  <wenson_hsieh@apple.com>
3642
3643         Visual viewports: bottom fixed elements disappear behind the keyboard
3644         https://bugs.webkit.org/show_bug.cgi?id=165983
3645         <rdar://problem/29409852>
3646
3647         Reviewed by Simon Fraser.
3648
3649         Add support for UIScriptController.inputViewBounds, which UI-side scripts may use to fetch the bounding rect of
3650         the keyboard when it is up.
3651
3652         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3653         (WTR::UIScriptController::inputViewBounds):
3654         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3655         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3656         (WTR::UIScriptController::inputViewBounds):
3657         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3658         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3659         (WTR::viewRectForWindowRect):
3660
3661         Previously, we accounted for the status bar height by translating the entire web view down by the height of the
3662         status bar. However, we did not shrink the height of the web view itself, which means that for tests which
3663         involve scrolling past the end of the document, the bottom strip of the web view is out of bounds of the window.
3664
3665         (WTR::PlatformWebView::PlatformWebView):
3666         (WTR::PlatformWebView::setWindowFrame):
3667         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3668         (WTR::UIScriptController::inputViewBounds):
3669
3670 2016-12-16  Ryosuke Niwa  <rniwa@webkit.org>
3671
3672         Deleting a character converted from pinyin after an image causes a Safari crash