58494506235a9a5be74ff2473b384eb8697117ec
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-09  Chris Dumez  <cdumez@apple.com>
2
3         Loads using loadHTMLString() cause flashing when process-swapping
4         https://bugs.webkit.org/show_bug.cgi?id=196714
5         <rdar://problem/49637354>
6
7         Reviewed by Antti Koivisto.
8
9         Add API test coverage.
10
11         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
12
13 2019-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
14
15         Unreviewed. Fix ATK accessibility tests after r244059.
16
17         We are failing to load the injected bundle due to undefined symbol
18         AccessibilityUIElement::replaceTextInRange().
19
20         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
21         (WTR::AccessibilityUIElement::replaceTextInRange):
22
23 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
24
25         AX: Support API: accessibilityReplaceRange:withText
26         https://bugs.webkit.org/show_bug.cgi?id=196636
27
28         Unreviewed build fix for Windows port.
29
30         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
31         (WTR::AccessibilityUIElement::replaceTextInRange): Added.
32
33 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
34
35         [CMake][WinCairo] Separate copied headers into different directories
36         https://bugs.webkit.org/show_bug.cgi?id=196655
37
38         Reviewed by Michael Catanzaro.
39
40         * DumpRenderTree/CMakeLists.txt:
41         * MiniBrowser/win/CMakeLists.txt:
42         * TestWebKitAPI/CMakeLists.txt:
43         * TestWebKitAPI/PlatformWin.cmake:
44
45 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
46
47         Log stack-trace for run-webkit-tests when interrupted
48         https://bugs.webkit.org/show_bug.cgi?id=176393
49         <rdar://problem/34262310>
50
51         Reviewed by Lucas Forschler.
52
53         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
54         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
55         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
56         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
57         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
58         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
59         (main): Set handlers to log stack trace on interruption.
60
61 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
62
63         AX: Support API: accessibilityReplaceRange:withText
64         https://bugs.webkit.org/show_bug.cgi?id=196636
65
66         Unreviewed build fix for Windows port.
67
68         * DumpRenderTree/AccessibilityUIElement.cpp:
69         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
70
71 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
72
73         [ews-build] Scripts using Buildbot API have CORS error
74         https://bugs.webkit.org/show_bug.cgi?id=196709
75
76         Reviewed by Alexey Proskuryakov.
77
78         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
79
80 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
81
82         AX: Support API: accessibilityReplaceRange:withText
83         https://bugs.webkit.org/show_bug.cgi?id=196636
84
85         Reviewed by Daniel Bates.
86
87         * DumpRenderTree/AccessibilityUIElement.cpp:
88         (replaceTextInRangeCallback):
89         (AccessibilityUIElement::replaceTextInRange):
90         (AccessibilityUIElement::getJSClass):
91         * DumpRenderTree/AccessibilityUIElement.h:
92         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
93         (AccessibilityUIElement::replaceTextInRange):
94         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
95         (AccessibilityUIElement::replaceTextInRange):
96         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
97         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
98         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
99         (WTR::AccessibilityUIElement::replaceTextInRange):
100         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
101         (WTR::AccessibilityUIElement::replaceTextInRange):
102
103 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
104
105         [iOS] Do not allow starting selection drags when selection views are not visible
106         https://bugs.webkit.org/show_bug.cgi?id=196686
107         <rdar://problem/49399192>
108
109         Reviewed by Tim Horton.
110
111         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
112         also add some new API tests to cover scenarios where the web view is not first responder.
113
114         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
115         (TestWebKitAPI::TEST):
116         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
117
118         Add a switch to optionally make the web view first responder when starting the simulated drag.
119
120         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
121         (-[DragAndDropSimulator initWithWebView:]):
122         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
123
124 2019-04-08  Justin Fan  <justin_fan@apple.com>
125
126         [Web GPU] Fix Web GPU experimental feature on iOS
127         https://bugs.webkit.org/show_bug.cgi?id=196632
128
129         Reviewed by Myles C. Maxfield.
130
131         Properly make Web GPU available on iOS 11+.
132
133         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
134
135 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
136
137         [ews-build] Do not upload archive when Compile Fails
138         https://bugs.webkit.org/show_bug.cgi?id=196674
139
140         Reviewed by Alexey Proskuryakov.
141
142         * BuildSlaveSupport/ews-build/factories.py:
143         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
144         * BuildSlaveSupport/ews-build/steps.py:
145         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
146         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
147         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
148
149 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
150
151         Enable DFG on MIPS
152         https://bugs.webkit.org/show_bug.cgi?id=196689
153
154         Reviewed by Žan Doberšek.
155
156         Since the bytecode change, we enabled the baseline JIT on mips in
157         r240432, but DFG is still missing. With this change, all tests are
158         passing on a ci20 board.
159
160         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
161
162 2019-04-08  Philippe Normand  <pnormand@igalia.com>
163
164         [Flatpak] Second run update-webkitwpe-flatpak fails
165         https://bugs.webkit.org/show_bug.cgi?id=192702
166
167         Reviewed by Carlos Garcia Campos.
168
169         * flatpak/flatpakutils.py:
170         (FlatpakObject.flatpak): Fix typo.
171         (FlatpakPackage.install): When installing, also update to the configured remote commit.
172         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
173
174 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
175
176         [GTK][WPE] outlook.live.com displays old-fashioned UI
177         https://bugs.webkit.org/show_bug.cgi?id=196642
178
179         Reviewed by Carlos Garcia Campos.
180
181         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
182         (TestWebKitAPI::TEST): New Mac platform quirk test.
183
184 2019-04-07  Commit Queue  <commit-queue@webkit.org>
185
186         Unreviewed, rolling out r243956.
187         https://bugs.webkit.org/show_bug.cgi?id=196688
188
189         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
190         by aakashjain on #webkit).
191
192         Reverted changeset:
193
194         "Clicking "Go Back" from a safe browsing warning from an
195         iframe should navigate the WKWebView back to the previous
196         page"
197         https://bugs.webkit.org/show_bug.cgi?id=196665
198         https://trac.webkit.org/changeset/243956
199
200 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
201
202         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
203         https://bugs.webkit.org/show_bug.cgi?id=196669
204
205         Reviewed by Geoffrey Garen.
206
207         Added three new unit tests for WeakHashSet.
208
209         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
210         (WTF_WeakPtr.WeakHashSetConstObjects):
211         (WTF_WeakPtr.WeakHashSetComputesEmpty):
212         (WTF_WeakPtr.WeakHashSetComputeSize):
213
214 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
215
216         Hide next and previous form control buttons when WKWebView is editable
217         https://bugs.webkit.org/show_bug.cgi?id=196672
218         <rdar://problem/35625321>
219
220         Reviewed by Tim Horton.
221
222         Add a new API test.
223
224         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
225         (-[TestWKWebView lastTrailingBarButtonGroup]):
226         (TestWebKitAPI::TEST):
227         * TestWebKitAPI/ios/UIKitSPI.h:
228
229 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
230
231         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
232         https://bugs.webkit.org/show_bug.cgi?id=196077
233         <rdar://problem/49108202>
234
235         Reviewed by Chris Dumez.
236
237         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
238         on new web view.
239
240         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
241
242 2019-04-05  Saam Barati  <sbarati@apple.com>
243
244         Make compare-results understand MotionMark
245         https://bugs.webkit.org/show_bug.cgi?id=196666
246
247         Reviewed by Yusuke Suzuki.
248
249         * Scripts/compare-results:
250         (PLT5Results):
251         (detectMotionMark):
252         (detectMotionMark1_1):
253         (motionMarkResults):
254         (motionMark1_1Results):
255         (detectBenchmark):
256         (biggerIsBetter):
257         (main):
258
259 2019-04-05  Alex Christensen  <achristensen@webkit.org>
260
261         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
262         https://bugs.webkit.org/show_bug.cgi?id=196665
263         <rdar://45115669>
264
265         Reviewed by Geoff Garen.
266
267         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
268         (goBack):
269         (+[SimpleLookupContext sharedLookupContext]):
270         (-[SimpleLookupContext lookUpURL:completionHandler:]):
271         (TEST):
272         (+[Simple3LookupContext sharedLookupContext]): Deleted.
273         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
274
275 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
276
277         [ews-build] Add configuration and architecture for windows builders
278         https://bugs.webkit.org/show_bug.cgi?id=196660
279
280         Reviewed by Lucas Forschler.
281
282         * BuildSlaveSupport/ews-build/config.json:
283
284 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
285
286         webkitpy: Don't run subsequent rounds if interrupted
287         https://bugs.webkit.org/show_bug.cgi?id=196646
288
289         Reviewed by Aakash Jain.
290
291         * Scripts/webkitpy/layout_tests/controllers/manager.py:
292         (Manager.run): Bail out if interrupted.
293
294 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
295
296         Test sessionStorage in PSON private browsing mode
297         https://bugs.webkit.org/show_bug.cgi?id=196561
298
299         Reviewed by Alex Christensen.
300
301         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
302
303 2019-04-05  Commit Queue  <commit-queue@webkit.org>
304
305         Unreviewed, rolling out r243833.
306         https://bugs.webkit.org/show_bug.cgi?id=196645
307
308         This change breaks build of WPE and GTK ports (Requested by
309         annulen on #webkit).
310
311         Reverted changeset:
312
313         "[CMake][WTF] Mirror XCode header directories"
314         https://bugs.webkit.org/show_bug.cgi?id=191662
315         https://trac.webkit.org/changeset/243833
316
317 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
318
319         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
320         https://bugs.webkit.org/show_bug.cgi?id=196635
321
322         Reviewed by Antti Koivisto.
323         
324         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
325         for a test to enable async frame scrolling via:
326             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
327         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
328         
329         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
330
331         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
332         (WTR::InjectedBundle::beginTesting):
333         * WebKitTestRunner/TestController.cpp:
334         (WTR::TestController::resetPreferencesToConsistentValues):
335
336 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
337
338         Use a correct LC_RPATH when building with ASan
339         https://bugs.webkit.org/show_bug.cgi?id=196576
340
341         Reviewed by David Kilzer.
342
343         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
344         so that ../Frameworks is checked. This is simpler and more reliable than updating
345         each SPC service xcconfig.
346
347 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
348
349         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
350         https://bugs.webkit.org/show_bug.cgi?id=196629
351
352         Reviewed by Lucas Forschler.
353
354         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
355
356 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
357
358         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
359         https://bugs.webkit.org/show_bug.cgi?id=196618
360
361         Reviewed by Lucas Forschler.
362
363         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
364         (StatusBubble): Added QUEUE_TRIGGERS.
365         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
366         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
367         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
368         its parent(builder).
369
370 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
371
372         [ews-app] Status-bubble steps are sometimes displayed in reverse order
373         https://bugs.webkit.org/show_bug.cgi?id=196625
374
375         Reviewed by Lucas Forschler.
376
377         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
378         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
379
380 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
381
382         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
383         https://bugs.webkit.org/show_bug.cgi?id=196630
384
385         Reviewed by Wenson Hsieh.
386
387         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
388
389 2019-04-04  Youenn Fablet  <youenn@apple.com>
390
391         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
392         https://bugs.webkit.org/show_bug.cgi?id=196543
393
394         Reviewed by Alex Christensen.
395
396         * WebKitTestRunner/TestController.cpp:
397         (WTR::TestController::generatePageConfiguration):
398
399 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
400
401         [ews-app] Status bubble should not display skipped buildbot steps
402         https://bugs.webkit.org/show_bug.cgi?id=196584
403
404         Reviewed by Lucas Forschler.
405
406         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
407
408 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
409
410         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
411         https://bugs.webkit.org/show_bug.cgi?id=196620
412
413         Reviewed by Lucas Forschler.
414
415         * BuildSlaveSupport/ews-app/ews/config.py:
416
417 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
418
419         [Win] DumpRenderTreeWatchDog.py is not checked into source
420         https://bugs.webkit.org/show_bug.cgi?id=196567
421         <rdar://problem/49525901>
422
423         Reviewed by Lucas Forschler.
424
425         This script is used on Win EWS bots to terminate hanging DRT processes.
426
427         * EWSTools/dumprendertreewatchdog.py: Added.
428
429 2019-04-04  Chris Dumez  <cdumez@apple.com>
430
431         Unreviewed, roll out r243858 which made tests time out.
432
433         Disable new API tests on Windows instead.
434
435         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
436         (TestWebKitAPI::TEST):
437
438 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
439
440         [ATK] Cleanup WebPageAccessibilityObjectAtk
441         https://bugs.webkit.org/show_bug.cgi?id=196537
442
443         Reviewed by Michael Catanzaro.
444
445         Also consider files under atk directories as exceptions for GObject conventions.
446
447         * Scripts/webkitpy/style/checkers/cpp.py:
448         (check_identifier_name_in_declaration):
449
450 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
451
452         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
453         https://bugs.webkit.org/show_bug.cgi?id=196588
454         <rdar://problem/49365787>
455
456         Unreviewed build fix for Windows port.
457
458         error C3861: 'kill': identifier not found
459
460         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
461         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
462
463 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
464
465         [ews-build] Cancel build and similar operations should have authentication
466         https://bugs.webkit.org/show_bug.cgi?id=196520
467
468         Reviewed by Dewei Zhu.
469
470         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
471         environment variables.
472
473 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
474
475         [ews-build] Do not trigger queues which are not in production yet
476         https://bugs.webkit.org/show_bug.cgi?id=196581
477
478         Reviewed by Dewei Zhu.
479
480         * BuildSlaveSupport/ews-build/config.json:
481
482 2019-04-03  Chris Dumez  <cdumez@apple.com>
483
484         Unreviewed, fix typo in the name of API test added in r243848.
485
486         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
487         (TestWebKitAPI::TEST):
488
489 2019-04-03  Chris Dumez  <cdumez@apple.com>
490
491         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
492         https://bugs.webkit.org/show_bug.cgi?id=196588
493         <rdar://problem/49365787>
494
495         Reviewed by Ryosuke Niwa.
496
497         Add API test coverage.
498
499         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
500         (TestWebKitAPI::nullJavaScriptCallback):
501         (TestWebKitAPI::didCrashCheckFrames):
502         (TestWebKitAPI::TEST):
503
504 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
505
506         run-webkit-tests: Upload test results (new results database)
507         https://bugs.webkit.org/show_bug.cgi?id=196577
508         <rdar://problem/34841155>
509
510         Reviewed by Lucas Forschler.
511
512         * Scripts/webkitpy/layout_tests/controllers/manager.py:
513         (Manager.run): Upload results after each device shard, since the configuration will be
514         different for each device.
515         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
516         uploaded to a results database.
517         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
518         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
519
520 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
521
522         -apple-trailing-word is needed for browser detection
523         https://bugs.webkit.org/show_bug.cgi?id=196575
524
525         Unreviewed.
526
527         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
528
529 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
530
531         [CMake][WTF] Mirror XCode header directories
532         https://bugs.webkit.org/show_bug.cgi?id=191662
533
534         Reviewed by Konstantin Tokarev.
535
536         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
537         builds.
538
539         * CMakeLists.txt:
540         * DumpRenderTree/CMakeLists.txt:
541         * DumpRenderTree/PlatformWin.cmake:
542         * MiniBrowser/win/CMakeLists.txt:
543         * TestWebKitAPI/CMakeLists.txt:
544         * TestWebKitAPI/PlatformWin.cmake:
545         * WebKitTestRunner/PlatformGTK.cmake:
546         * WebKitTestRunner/PlatformWin.cmake:
547
548 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
549
550         [ews-app] Status bubble should not display certain infrastructure status messages
551         https://bugs.webkit.org/show_bug.cgi?id=196550
552
553         Reviewed by Lucas Forschler.
554
555         Do not display the steps which are un-needed for end-user. This information is still avaiable
556         if the user click on the bubble and look at the Buildbot build.
557         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
558         (StatusBubble._steps_messages):
559         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
560
561 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
562
563         [ews-build] Use https for sending data to ews-app
564         https://bugs.webkit.org/show_bug.cgi?id=196492
565
566         Reviewed by Lucas Forschler.
567
568         * BuildSlaveSupport/ews-build/events.py:
569
570 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
571
572         Remove support for -apple-trailing-word
573         https://bugs.webkit.org/show_bug.cgi?id=196525
574
575         Reviewed by Zalan Bujtas.
576
577         This CSS property is nonstandard and not used.
578
579         * Scripts/webkitperl/FeatureList.pm:
580         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
581
582 2019-04-03  Youenn Fablet  <youenn@apple.com>
583
584         Add a test for DOMCache on multiple browsing in case of private browsing
585         https://bugs.webkit.org/show_bug.cgi?id=196524
586
587         Reviewed by Alex Christensen.
588
589         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
590         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
591
592 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
593
594         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
595         https://bugs.webkit.org/show_bug.cgi?id=196540
596
597         Reviewed by Aakash Jain.
598
599         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
600
601 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
602
603         Add plumbing for a compatibility mode preference in WebKit
604         https://bugs.webkit.org/show_bug.cgi?id=196005
605
606         Reviewed by Tim Horton.
607
608         Add new API tests.
609
610         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
611         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
612
613 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
614
615         [WPE][GTK] Update libsrtp dependency package for Debian
616         https://bugs.webkit.org/show_bug.cgi?id=196528
617
618         Reviewed by Frédéric Wang.
619
620         * gtk/install-dependencies:
621         * wpe/install-dependencies:
622
623 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
624
625         [WK2] Add support for Window's beforeprint / afterprint events
626         https://bugs.webkit.org/show_bug.cgi?id=196478
627         <rdar://problem/49535124>
628
629         Unreviewed build fix for MSVC.
630
631         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
632
633         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
634
635         * WebKitTestRunner/TestController.cpp:
636         (WTR::printFrame): Use int and float literals.
637
638 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
639
640         [ews-build] Reassign bots to queues
641
642         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
643
644 2019-04-02  Chris Dumez  <cdumez@apple.com>
645
646         [WK2] Add support for Window's beforeprint / afterprint events
647         https://bugs.webkit.org/show_bug.cgi?id=196478
648
649         Reviewed by Alex Christensen.
650
651         Add minimal implementation for printFrame in WebKitTestRunner.
652
653         * WebKitTestRunner/TestController.cpp:
654         (WTR::printFrame):
655         (WTR::TestController::createOtherPage):
656         (WTR::TestController::createWebViewWithOptions):
657
658 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
659
660         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
661         https://bugs.webkit.org/show_bug.cgi?id=196491
662
663         Reviewed by Lucas Forschler.
664
665         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
666
667 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
668
669         [ews-build] Configure buildbot try credentials in environment variables
670         https://bugs.webkit.org/show_bug.cgi?id=196501
671
672         Reviewed by Lucas Forschler.
673
674         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
675         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
676         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
677
678 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
679
680         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
681         https://bugs.webkit.org/show_bug.cgi?id=196496
682         <rdar://problem/49521634>
683
684         Reviewed by Chris Dumez.
685
686         Add new API tests (see WebKit ChangeLog for more detail).
687
688         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
689         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
690         (TEST):
691
692 2019-04-02  David Kilzer  <ddkilzer@apple.com>
693
694         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
695         <https://webkit.org/b/196499>
696
697         Reviewed by Alexey Proskuryakov.
698
699         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
700         ENABLE_ADDRESS_SANITIZER.
701
702 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
703
704         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
705         https://bugs.webkit.org/show_bug.cgi?id=182757
706
707         Reviewed by Don Olmstead.
708
709         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
710         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
711
712 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
713
714         run-api-tests: Upload test results
715         https://bugs.webkit.org/show_bug.cgi?id=196323
716         <rdar://problem/49356714>
717
718         Reviewed by Lucas Forschler.
719
720         * Scripts/webkitpy/api_tests/manager.py:
721         (Manager):
722         (Manager.run): Upload results to a results database.
723         * Scripts/webkitpy/api_tests/run_api_tests.py:
724         (parse_args): Add upload arguments.
725         * Scripts/webkitpy/port/base.py:
726         (Port):
727         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
728         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
729         with commits from any other associated repositories.
730         * Scripts/webkitpy/port/device.py:
731         (Device):
732         (Device.build_version): Access build_versoin of underlying platform device.
733         * Scripts/webkitpy/port/ios_simulator_unittest.py:
734         (IOSSimulatorTest):
735         (IOSSimulatorTest.test_configuration_for_upload):
736         * Scripts/webkitpy/port/device_port.py:
737         (DevicePort):
738         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
739         the same as the machine uploading results.
740         * Scripts/webkitpy/port/mac.py:
741         (MacPort):
742         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
743         * Scripts/webkitpy/port/mac_unittest.py:
744         (MacTest):
745         (MacTest.test_configuration_for_upload):
746         * Scripts/webkitpy/xcode/simulated_device.py:
747         (SimulatedDeviceManager._create_device_with_runtime):
748         (SimulatedDevice.__init__): Create simulated device with a build_version.
749         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
750         (test_existing_simulator):
751
752 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
753
754         Remove extra newline characters (Follow-up fix to r243707)
755
756         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
757
758 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
759
760         [ews-app] Use API_KEY to accept results data
761         https://bugs.webkit.org/show_bug.cgi?id=196461
762
763         Reviewed by Dewei Zhu.
764
765         * BuildSlaveSupport/ews-app/ews/views/results.py:
766         (Results.post): Validate EWS_API_KEY before accepting any data.
767         * BuildSlaveSupport/ews-build/events.py:
768         (Events.sendData): Send EWS_API_KEY if available along with event data.
769
770 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
771
772         Unable to copy and paste a PDF from Notes into Mail compose body
773         https://bugs.webkit.org/show_bug.cgi?id=196442
774         <rdar://problem/48573098>
775
776         Reviewed by Tim Horton.
777
778         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
779         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
780         to be specified on the item providers.
781
782         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
783         (TestWebKitAPI::mapItemForTesting):
784         (TestWebKitAPI::contactItemForTesting):
785
786 2019-04-01  Tim Horton  <timothy_horton@apple.com>
787
788         Make UIWKDocumentContext rects per-character instead of per-word
789         https://bugs.webkit.org/show_bug.cgi?id=196459
790
791         Reviewed by Wenson Hsieh.
792
793         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
794         (TEST):
795         Adjust test results due to switching to per-character rects.
796
797 2019-04-01  Chris Dumez  <cdumez@apple.com>
798
799         UIProcess crash when a prewarmed process is terminated
800         https://bugs.webkit.org/show_bug.cgi?id=196451
801         <rdar://problem/49245471>
802
803         Reviewed by Geoffrey Garen.
804
805         Add API test coverage.
806
807         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
808         (TEST):
809
810 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
811
812         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
813         https://bugs.webkit.org/show_bug.cgi?id=196449
814
815         Reviewed by Lucas Forschler.
816
817         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
818         (StatusBubble.get_os_details): Method to get OS and Xcode details.
819         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
820         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
821
822 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
823
824         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
825         https://bugs.webkit.org/show_bug.cgi?id=196444
826
827         Reviewed by Lucas Forschler.
828
829         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
830
831 2019-04-01  Alex Christensen  <achristensen@webkit.org>
832
833         Add SPI to canonicalize NSURLs with WTF::URL
834         https://bugs.webkit.org/show_bug.cgi?id=196415
835         <rdar://problem/44980271>
836
837         Reviewed by Darin Adler.
838
839         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
840         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
841         (TestWebKitAPI::TEST):
842
843 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
844
845         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
846         https://bugs.webkit.org/show_bug.cgi?id=196441
847
848         Reviewed by Carlos Garcia Campos.
849
850         Don't cache the wpe_view_backend object that might not exist yet at the
851         time of EventSenderProxy constructor invocation, but instead retrieve
852         that object whenever it's required for event dispatching. This should
853         avoid crashes in this constructor now that it's invoked before any
854         PlatformWindow has been set up (as changed in r243496).
855
856         * WebKitTestRunner/EventSenderProxy.h:
857         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
858         (WTR::viewBackend):
859         (WTR::EventSenderProxy::EventSenderProxy):
860         (WTR::EventSenderProxy::mouseDown):
861         (WTR::EventSenderProxy::mouseUp):
862         (WTR::EventSenderProxy::mouseMoveTo):
863         (WTR::EventSenderProxy::mouseScrollBy):
864         (WTR::EventSenderProxy::keyDown):
865         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
866
867 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
868
869         [Win][WebKit] MiniBrowser should support high DPI display
870         https://bugs.webkit.org/show_bug.cgi?id=196391
871
872         Reviewed by Alex Christensen.
873
874         * MiniBrowser/win/WebKitBrowserWindow.cpp:
875         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
876         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
877         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
878
879 2019-03-31  Sam Weinig  <weinig@apple.com>
880
881         Remove more i386 specific configurations
882         https://bugs.webkit.org/show_bug.cgi?id=196430
883
884         Reviewed by Alexey Proskuryakov.
885
886         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
887         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
888
889 2019-03-31  Andy Estes  <aestes@apple.com>
890
891         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
892         https://bugs.webkit.org/show_bug.cgi?id=196433
893         <rdar://problem/49293305>
894
895         Reviewed by Tim Horton.
896
897         Enhanced API test coverage to include all navigation response policy decisions in both
898         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
899
900         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
901         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
902         (TestWebKitAPI::TEST):
903         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
904         (readFile):
905         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
906         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
907         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
908         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
909         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
910         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
911         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
912         (-[QuickLookDelegate _downloadDidStart:]):
913         (-[QuickLookDelegate _download:didReceiveResponse:]):
914         (-[QuickLookDelegate _download:didReceiveData:]):
915         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
916         (-[QuickLookDelegate _downloadDidFinish:]):
917         (-[QuickLookDelegate _download:didFailWithError:]):
918         (-[QuickLookDelegate _downloadDidCancel:]):
919         (-[QuickLookDelegate verifyDownload]):
920         (runTest):
921         (runTestDecideBeforeLoading):
922         (runTestDecideAfterLoading):
923         (TEST):
924         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
925         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
926         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
927         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
928         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
929         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
930         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
931         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
932         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
933         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
934         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
935         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
936         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
937         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
938
939 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
940
941         [CMake] add testdfg as target with build-jsc
942         https://bugs.webkit.org/show_bug.cgi?id=196393
943
944         Reviewed by Saam Barati.
945
946         Added testdfg as one of the targets to build when
947         using CMake.
948
949         * Scripts/build-jsc:
950
951 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
952
953         Delete WebMetal implementation in favor of WebGPU
954         https://bugs.webkit.org/show_bug.cgi?id=195418
955
956         Reviewed by Dean Jackson.
957
958         * DumpRenderTree/mac/DumpRenderTree.mm:
959         (enableExperimentalFeatures):
960         (resetWebPreferencesToConsistentValues):
961         * Scripts/webkitperl/FeatureList.pm:
962         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
963         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
964         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
965         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
966         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
967         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
968         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
969         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
970         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
971         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
972         (WTR::InjectedBundle::beginTesting):
973         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
974         (WTR::TestRunner::setWebMetalEnabled): Deleted.
975         * WebKitTestRunner/InjectedBundle/TestRunner.h:
976
977 2019-03-29  Chris Dumez  <cdumez@apple.com>
978
979         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
980         https://bugs.webkit.org/show_bug.cgi?id=196405
981         <rdar://problem/49428130>
982
983         Reviewed by Wenson Hsieh.
984
985         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
986         the popover presentation methods to be no-ops. Use this in the new test added in
987         r243523 so that we do not swizzle those methods for all tests. This is needed because
988         those WatchOS tests rely on the popover getting presented and interactive.
989
990         * WebKitTestRunner/TestController.cpp:
991         (WTR::updateTestOptionsFromTestHeader):
992         * WebKitTestRunner/TestController.h:
993         * WebKitTestRunner/TestOptions.h:
994         (WTR::TestOptions::hasSameInitializationOptions const):
995         * WebKitTestRunner/ios/TestControllerIOS.mm:
996         (WTR::TestController::platformInitialize):
997         (WTR::TestController::platformResetStateToConsistentValues):
998
999 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
1000
1001         [Curl] Add Server Trust Evaluation Support.
1002         https://bugs.webkit.org/show_bug.cgi?id=191646
1003
1004         Reviewed by Fujii Hironori.
1005
1006         Implemented MiniBrowser UI for asking if user trusts the server.
1007
1008         * MiniBrowser/win/Common.cpp:
1009         (askServerTrustEvaluation):
1010         (replaceString):
1011         * MiniBrowser/win/Common.h:
1012         * MiniBrowser/win/MiniBrowserLib.rc:
1013         * MiniBrowser/win/MiniBrowserLibResource.h:
1014         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1015         (createPEMString):
1016         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
1017         (WebKitBrowserWindow::canTrustServerCertificate):
1018         * MiniBrowser/win/WebKitBrowserWindow.h:
1019
1020 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
1021
1022         Implement ResizeObserver.
1023         https://bugs.webkit.org/show_bug.cgi?id=157743
1024
1025         Reviewed by Simon Fraser.
1026
1027         Support resizeObserverEnabled webPreferences.
1028
1029         * DumpRenderTree/TestOptions.cpp:
1030         (TestOptions::TestOptions):
1031         * DumpRenderTree/TestOptions.h:
1032         * DumpRenderTree/mac/DumpRenderTree.mm:
1033         (setWebPreferencesForTestOptions):
1034         * DumpRenderTree/win/DumpRenderTree.cpp:
1035         (enableExperimentalFeatures):
1036         * Scripts/webkitperl/FeatureList.pm:
1037         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1038
1039 2019-03-28  John Wilander  <wilander@apple.com>
1040
1041         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
1042         https://bugs.webkit.org/show_bug.cgi?id=196281
1043         <rdar://problem/48938748>
1044
1045         Reviewed by Alex Christensen.
1046
1047         This patch adds the function isStatisticsHasLocalStorage() to the
1048         TestRunner. With it, the page can query the WebsiteDataStore in the
1049         UI process to make sure that it sees LocalStorage.
1050
1051         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1052         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1053         (WTR::TestRunner::isStatisticsHasLocalStorage):
1054         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1055         * WebKitTestRunner/TestController.cpp:
1056         (WTR::TestController::isStatisticsHasLocalStorage):
1057         * WebKitTestRunner/TestController.h:
1058         * WebKitTestRunner/TestInvocation.cpp:
1059         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1060
1061 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
1062
1063         API::Data::createWithoutCopying should do a null check before calling CFRelease
1064         https://bugs.webkit.org/show_bug.cgi?id=196276
1065         <rdar://problem/48059859>
1066
1067         Reviewed by Alex Christensen.
1068
1069         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
1070
1071         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1072         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
1073         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
1074         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
1075         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1076         (TestWebKitAPI::TEST):
1077
1078 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
1079
1080         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
1081         https://bugs.webkit.org/show_bug.cgi?id=186276
1082
1083         Reviewed by Carlos Garcia Campos.
1084
1085         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
1086         (webViewLoadChanged):
1087         (testWebResourceGetDataError):
1088         (testWebResourceGetDataEmpty):
1089         (beforeAll):
1090         (webViewloadChanged): Deleted.
1091
1092 2019-03-27  Andy Estes  <aestes@apple.com>
1093
1094         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
1095         https://bugs.webkit.org/show_bug.cgi?id=196317
1096
1097         Reviewed by Dan Bernstein.
1098
1099         package-root copies built products into a staging directory using ditto(1), which does not
1100         follow symbolic links as it traverses a directory. Now that the files in
1101         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
1102         itself, these become broken links when ditto'd into the staging directory.
1103
1104         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
1105
1106         * Scripts/package-root:
1107
1108 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
1109
1110         [ews-app] Update display text of Submit for ews analysis
1111         https://bugs.webkit.org/show_bug.cgi?id=196309
1112
1113         Reviewed by Dewei Zhu.
1114
1115         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
1116
1117 2019-03-27  David Kilzer  <ddkilzer@apple.com>
1118
1119         run-webkit-tests should check for leaks in WebKit processes
1120         <https://webkit.org/b/193772>
1121         <rdar://problem/46526680>
1122
1123         Reviewed by Ryosuke Niwa.
1124
1125         This works by doing the following:
1126         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
1127           The list of child processes are returned one per line:
1128           process.name: pid
1129         - Run the "#LIST CHILD PROCESSES" command just before the
1130           "#CHECK FOR WORLD LEAKS" command, and store the list of child
1131           processes on the ServerProcess object.
1132         - When the `--leaks` switch is handled, run check_for_leaks() on
1133           each child process after the main test harness.
1134
1135         * DumpRenderTree/mac/DumpRenderTree.mm:
1136         (handleControlCommand):
1137         - Use strncmp() instead of strcmp().
1138         - Add support for handling "#LIST CHILD PROCESSES" command.
1139
1140         * Scripts/webkitpy/port/base.py:
1141         (Port.check_for_leaks):
1142         * Scripts/webkitpy/port/darwin.py:
1143         (DarwinPort.check_for_leaks):
1144         - Rename redundant 'process_pid' argument to 'process_id'.
1145
1146         * Scripts/webkitpy/port/driver.py:
1147         (Driver.do_post_tests_work):
1148         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
1149           longer the only command this sends to WebKitTestRunner.
1150         - If the `--leaks` switch is present, send the
1151           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
1152           result using Port.set_webkit_processes().
1153         (Driver._parse_child_processes_output):
1154         - Add helper method to parse list of child process names and
1155           process IDs returned from WebKitTestRunner.
1156
1157         * Scripts/webkitpy/port/ios_device.py:
1158         (IOSDevicePort.check_for_leaks):
1159         - Rename redundant 'process_pid' argument to 'process_id'.
1160
1161         * Scripts/webkitpy/port/leakdetector.py:
1162         (LeakDetector._parse_leaks_output):
1163         - Return early if there is no leaks_output.
1164         (LeakDetector.check_for_leaks):
1165         - Rename redundant 'process_pid' argument to 'process_id'.
1166
1167         * Scripts/webkitpy/port/server_process.py:
1168         (ServerProcess.__init__):
1169         (ServerProcess.child_processes):
1170         (ServerProcess.set_child_processes):
1171         - Add instance variable to Port to store list of child process
1172           names and process IDs returned from WebKitTestRunner.
1173         (ServerProcess._start):
1174         - Clear self._child_processes.
1175         (ServerProcess.stop):
1176         - If self._child_processes is set, call
1177           self._port.check_for_leaks() for each child process.
1178
1179         * Scripts/webkitpy/port/server_process_unittest.py:
1180         (TrivialMockPort.check_for_leaks):
1181         - Rename redundant 'process_pid' argument to 'process_id'.
1182
1183         * Scripts/webkitpy/port/simulator_process.py:
1184         (SimulatorProcess.stop):
1185         - If self._child_processes is set, call
1186           self._port.check_for_leaks() for each child process.
1187
1188         * Scripts/webkitpy/port/watch_device.py:
1189         (WatchDevicePort.check_for_leaks):
1190         - Rename redundant 'process_pid' argument to 'process_id'.
1191
1192         * WebKitTestRunner/TestController.cpp:
1193         (WTR::TestController::dumpResponse):
1194         - Extract method from findAndDumpWorldLeaks() so that it may be
1195           reused by findAndDumpWebKitProcessIdentifiers().
1196         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1197         - Add method to output process name and process ID of both the
1198           WebContent and Networking processes.
1199         (WTR::TestController::findAndDumpWorldLeaks):
1200         - Fix missing newline in output when there were no abandoned
1201           documents.
1202         - Call dumpResponse() for extracted code.
1203         (WTR::TestController::handleControlCommand):
1204         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
1205         - Use strncmp() instead of strcmp().
1206         - Call findAndDumpWebKitProcessIdentifiers() when
1207           "#LIST CHILD PROCESSES" command is sent.
1208         * WebKitTestRunner/TestController.h:
1209         (WTR::TestController::dumpResponse):
1210         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1211         - Declare methods.
1212
1213 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1214
1215         Unreviewed. Add GLib API test cases after r243434.
1216
1217         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
1218         (testWebViewActiveURI):
1219         (serverCallback):
1220         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1221         (sendRequestCallback):
1222
1223 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1224
1225         Geolocation request not complete when watch request was started in a different web process
1226         https://bugs.webkit.org/show_bug.cgi?id=195996
1227
1228         Reviewed by Alex Christensen.
1229
1230         Add a test case.
1231
1232         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
1233         (TestWebKitAPI::runJavaScriptAlert):
1234         (TestWebKitAPI::TEST):
1235
1236 2019-03-26  Keith Rollin  <krollin@apple.com>
1237
1238         Update the way generate-xcfilelists returns strings from functions
1239         https://bugs.webkit.org/show_bug.cgi?id=195975
1240         <rdar://problem/49040807>
1241
1242         Reviewed by Dean Jackson.
1243
1244         There are places where generate-xcfilelists executes assignments with
1245         statements like:
1246
1247             FOO=$(some_function)
1248
1249         where "some_function" return a string by echoing it. E.g.
1250
1251             some_function()
1252             {
1253                 echo "Hello, World"
1254             }
1255
1256         This is a common idiom, but it has a problem if "some_function" needs
1257         to call "exit" in an attempt to halt the entire script right then and
1258         there. Since "some_function" is called inside of $(), it's being
1259         executed in a sub-shell. Calling exit in that sub-shell simply exits
1260         that shell; it doesn't not exit the outer shell in which the main part
1261         of the script is still running. As such, the main script keeps
1262         executing when the intent was for the script to halt.
1263
1264         The solution to this is to use a different idiom for returning
1265         strings. The one we now is to pass in the name of the variable to
1266         receive the string result:
1267
1268             some_function()
1269             {
1270                 variable_name=$1
1271                 eval $variable_name ="Hello, World"
1272             }
1273
1274         The call site now looks like
1275
1276             some_function FOO
1277
1278         Because there's no invocation of a sub-shell, some_function can now
1279         call "exit" if it wants to, and the entire script will exit at that
1280         point.
1281
1282         * Scripts/generate-xcfilelists:
1283
1284 2019-03-26  Chris Dumez  <cdumez@apple.com>
1285
1286         Add basic layout test coverage for File Picker on iOS
1287         https://bugs.webkit.org/show_bug.cgi?id=196265
1288
1289         Reviewed by Wenson Hsieh.
1290
1291         Add layout test infrastructure to test the file picker on iOS.
1292
1293         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1294         (WTR::UIScriptController::dismissFilePicker):
1295         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1296         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1297         (WTR::UIScriptController::dismissFilePicker):
1298         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1299         * WebKitTestRunner/TestController.cpp:
1300         (WTR::TestController::createWebViewWithOptions):
1301         (WTR::updateTestOptionsFromTestHeader):
1302         * WebKitTestRunner/TestOptions.h:
1303         (WTR::TestOptions::hasSameInitializationOptions const):
1304         * WebKitTestRunner/ios/TestControllerIOS.mm:
1305         (overridePresentViewController):
1306         (WTR::TestController::platformInitialize):
1307         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1308         (WTR::UIScriptController::dismissFilePicker):
1309
1310 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
1311
1312         Implement async paste method on UIWKInteractionViewProtocol
1313         https://bugs.webkit.org/show_bug.cgi?id=196267
1314         <rdar://problem/49236346>
1315
1316         Reviewed by Tim Horton.
1317
1318         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
1319         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
1320         are now a part of all iOS 12 internal SDKs.
1321
1322         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
1323
1324         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
1325         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
1326
1327         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
1328         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1329         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
1330         * TestWebKitAPI/ios/UIKitSPI.h:
1331
1332 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1333
1334         [ews-build] Use PostgreSQL for ews.webkit.org database
1335         https://bugs.webkit.org/show_bug.cgi?id=196270
1336
1337         Reviewed by Lucas Forschler.
1338
1339         * BuildSlaveSupport/ews-app/ews-app/settings.py:
1340
1341 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
1342
1343         [ews] Reset simctl states on reboot
1344         https://bugs.webkit.org/show_bug.cgi?id=196260
1345
1346         Rubber-stamped by Aakash Jain.
1347
1348         * EWSTools/start-queue-mac.sh:
1349
1350 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1351
1352         [ews-build] Use PostgreSQL for ews-build database
1353         https://bugs.webkit.org/show_bug.cgi?id=196229
1354
1355         Reviewed by Lucas Forschler.
1356
1357         * BuildSlaveSupport/ews-build/master.cfg:
1358
1359 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1360
1361         [ews-build] Get master_hostname dynamically in master.cfg
1362         https://bugs.webkit.org/show_bug.cgi?id=196255
1363
1364         Reviewed by Lucas Forschler.
1365
1366         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
1367         send events data in test mode.
1368
1369 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1370
1371         [ews-app] Set db_constraint to False for Foreign Keys
1372         https://bugs.webkit.org/show_bug.cgi?id=196252
1373
1374         Reviewed by Lucas Forschler.
1375
1376         * BuildSlaveSupport/ews-app/ews/models/build.py:
1377         * BuildSlaveSupport/ews-app/ews/models/step.py:
1378
1379 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1380
1381         [ews-build] is_test_mode_enabled should default to True
1382         https://bugs.webkit.org/show_bug.cgi?id=196248
1383
1384         Reviewed by Lucas Forschler.
1385
1386         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
1387
1388 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1389
1390         [ews-app] Add webkitperl to ENABLED_QUEUES
1391         https://bugs.webkit.org/show_bug.cgi?id=196253
1392
1393         Reviewed by Lucas Forschler.
1394
1395         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1396
1397 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
1398
1399         Address NSWindow sometimes using WebKitTestRunnerEvent too early
1400         https://bugs.webkit.org/show_bug.cgi?id=196211
1401         rdar://problem/49110552
1402
1403         Reviewed by Tim Horton.
1404
1405         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
1406         Make sure that EventSenderProxy always exists when running tests. We used to create
1407         it when resetting before the first test, which is a bit too late.
1408
1409         * WebKitTestRunner/TestController.h:
1410         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1411         (WTR::TestController::platformCreateWebView):
1412         (WTR::TestController::platformCreateOtherPage):
1413         (WTR::TestController::finishCreatingPlatformWebView):
1414         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1415         (WTR::PlatformWebView::PlatformWebView):
1416         Moved some code that made NSWindow use NSEvent during web view creation. We may
1417         need to move more if some other case us found, but this is enough for now.
1418
1419 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
1420
1421         Unreviewed. Fix typo in GLib geolocation API after r243285.
1422
1423         gelocation -> geolocation.
1424
1425         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
1426         (testGeolocationManagerWatchPosition):
1427
1428 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1429
1430         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1431         https://bugs.webkit.org/show_bug.cgi?id=196213
1432
1433         Reviewed by Geoff Garen.
1434
1435         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1436         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1437         (credentialWithIdentityAndKeychainPath):
1438         (-[ChallengeDelegate webView:didFinishNavigation:]):
1439         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1440         (TestWebKitAPI::TEST):
1441
1442 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1443
1444         Expected shouldn't assume its contained types are copyable
1445         https://bugs.webkit.org/show_bug.cgi?id=195986
1446
1447         Reviewed by JF Bastien.
1448
1449         * TestWebKitAPI/Tests/WTF/Expected.cpp:
1450         (TestWebKitAPI::NonCopyable::operator== const):
1451         (TestWebKitAPI::NonCopyable::operator!= const):
1452         (TestWebKitAPI::TEST):
1453
1454 2019-03-25  Tim Horton  <timothy_horton@apple.com>
1455
1456         Remove some now-unnecessary dynamic class lookup
1457         https://bugs.webkit.org/show_bug.cgi?id=196237
1458
1459         Reviewed by Simon Fraser.
1460
1461         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1462         (makeRequest):
1463         (TEST):
1464
1465 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
1466
1467         Unreviewed, rolling out r243450.
1468
1469         AppleWin and WinCairo port builds get broken.
1470
1471         Reverted changeset:
1472
1473         "Add test for fix of #196095"
1474         https://bugs.webkit.org/show_bug.cgi?id=196097
1475         https://trac.webkit.org/changeset/243450
1476
1477 2019-03-25  Commit Queue  <commit-queue@webkit.org>
1478
1479         Unreviewed, rolling out r243465.
1480         https://bugs.webkit.org/show_bug.cgi?id=196226
1481
1482         the test doesn't build (Requested by thorton on #webkit).
1483
1484         Reverted changeset:
1485
1486         "Do not terminate the NetworkProcess if a third party
1487         application sends a NSCredential with a SecIdentityRef"
1488         https://bugs.webkit.org/show_bug.cgi?id=196213
1489         https://trac.webkit.org/changeset/243465
1490
1491 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1492
1493         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1494         https://bugs.webkit.org/show_bug.cgi?id=196213
1495
1496         Reviewed by Geoff Garen.
1497
1498         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1499         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1500         (credentialWithIdentityAndKeychainPath):
1501         (-[ChallengeDelegate webView:didFinishNavigation:]):
1502         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1503         (TestWebKitAPI::TEST):
1504
1505 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1506
1507         [ews-build] Gracefully handle missing patch_id in events
1508         https://bugs.webkit.org/show_bug.cgi?id=196216
1509
1510         Reviewed by Lucas Forschler.
1511
1512         * BuildSlaveSupport/ews-build/events.py:
1513
1514 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1515
1516         [ews-build] use lz4 compression for improving buildbot performance
1517         https://bugs.webkit.org/show_bug.cgi?id=196155
1518
1519         Reviewed by Lucas Forschler.
1520
1521         * BuildSlaveSupport/ews-build/master.cfg:
1522
1523 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1524
1525         Pull some API testing helper methods out of TestWKWebView
1526         https://bugs.webkit.org/show_bug.cgi?id=196212
1527
1528         Reviewed by Tim Horton.
1529
1530         Refactor some more API testing utility methods, so that they can be used in
1531         tests that do not use TestWKWebView.
1532
1533         * TestWebKitAPI/cocoa/TestWKWebView.h:
1534         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1535         (-[WKWebView loadTestPageNamed:]):
1536         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
1537         (-[WKWebView synchronouslyLoadHTMLString:]):
1538         (-[WKWebView synchronouslyLoadTestPageNamed:]):
1539         (-[TestWKWebView loadTestPageNamed:]): Deleted.
1540         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
1541         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
1542         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
1543
1544 2019-03-25  Jer Noble  <jer.noble@apple.com>
1545
1546         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
1547         https://bugs.webkit.org/show_bug.cgi?id=196097
1548
1549         Reviewed by Eric Carlson.
1550
1551         Drive-by bug fix: allow tests to play audio without a user gesture by default.
1552
1553         * DumpRenderTree/mac/DumpRenderTree.mm:
1554         (resetWebPreferencesToConsistentValues):
1555         * WebKitTestRunner/TestController.cpp:
1556         (WTR::TestController::resetPreferencesToConsistentValues):
1557
1558 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1559
1560         Pull IPadUserInterfaceSwizzler out into a separate header file
1561         https://bugs.webkit.org/show_bug.cgi?id=196193
1562
1563         Reviewed by Anders Carlsson.
1564
1565         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
1566         be used in other API tests.
1567
1568         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1569         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
1570         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
1571         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
1572         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
1573         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
1574         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
1575
1576 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1577
1578         Remove NavigatorContentUtils in WebCore/Modules
1579         https://bugs.webkit.org/show_bug.cgi?id=196070
1580
1581         Reviewed by Alex Christensen.
1582
1583         NavigatorContentUtils was to support the custom scheme spec [1].
1584         However, in WebKit side, no port has supported the feature in
1585         WebKit layer after EFL port was removed. So there has been the
1586         only IDL implementation of the NavigatorContentUtils in WebCore.
1587         So we don't need to keep the implementation in WebCore anymore.
1588
1589         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
1590
1591         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1592
1593 2019-03-24  Andy Estes  <aestes@apple.com>
1594
1595         [watchOS] Remove unused Proximity Networking code
1596         https://bugs.webkit.org/show_bug.cgi?id=196188
1597
1598         Reviewed by Tim Horton.
1599
1600         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1601         (TEST):
1602
1603 2019-03-23  Keith Miller  <keith_miller@apple.com>
1604
1605         Refactor clz/ctz and fix getLSBSet.
1606         https://bugs.webkit.org/show_bug.cgi?id=196162
1607
1608         Reviewed by Saam Barati.
1609
1610         Add tests for clz, ctz, getLSBSet, and getMSBSet.
1611
1612         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1613         (TestWebKitAPI::TEST):
1614
1615 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1616
1617         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
1618         https://bugs.webkit.org/show_bug.cgi?id=196143
1619
1620         Reviewed by Michael Catanzaro.
1621
1622         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
1623         directories.
1624
1625         * Scripts/webkitpy/style/checkers/cpp.py:
1626         (check_identifier_name_in_declaration):
1627         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1628         (WebKitStyleTest.test_names):
1629
1630 2019-03-22  Philippe Normand  <pnormand@igalia.com>
1631
1632         [Flatpak] Manifest expanding fails for qt WPE extension
1633         https://bugs.webkit.org/show_bug.cgi?id=196148
1634
1635         Reviewed by Alex Christensen.
1636
1637         * flatpak/flatpakutils.py:
1638         (expand_submodules_recurse): The last recurse manifest expand
1639         iteration might lead to a single module so take it into account
1640         and don't try to recurse further.
1641
1642 2019-03-22  Chris Dumez  <cdumez@apple.com>
1643
1644         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
1645         https://bugs.webkit.org/show_bug.cgi?id=195348
1646         <rdar://problem/48622090>
1647
1648         Reviewed by Alex Christensen.
1649
1650         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
1651         to NO when test.options().shouldIgnoreMetaViewport is false.
1652
1653         * WebKitTestRunner/ios/TestControllerIOS.mm:
1654         (WTR::TestController::platformConfigureViewForTest):
1655
1656 2019-03-22  Chris Dumez  <cdumez@apple.com>
1657
1658         Prewarmed processes should be usable with any website data store
1659         https://bugs.webkit.org/show_bug.cgi?id=196104
1660
1661         Reviewed by Alex Christensen.
1662
1663         Add API test coverage.
1664
1665         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1666         (runInitialWarmedProcessUsedTest):
1667         (TEST):
1668
1669 2019-03-22  David Kilzer  <ddkilzer@apple.com>
1670
1671         Back out local changes to Alex's Subversion working directory
1672
1673         They were accidentally committed.
1674
1675         * Scripts/webkitpy/common/system/abstractexecutive.py:
1676         (AbstractExecutive.wait_newest):
1677         * Scripts/webkitpy/common/system/executive.py:
1678         (Executive.running_pids):
1679         * Scripts/webkitpy/common/system/executive_mock.py:
1680         (MockExecutive.running_pids):
1681         * Scripts/webkitpy/common/system/executive_unittest.py:
1682         (ExecutiveTest.serial_test_running_pids):
1683         * Scripts/webkitpy/port/darwin.py:
1684         (DarwinPort.check_for_leaks):
1685         * Scripts/webkitpy/port/leakdetector.py:
1686         (LeakDetector.check_for_leaks):
1687         - This was the hack attached to Bug 193772.
1688
1689         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
1690         (+[WebKitTestRunnerEvent mouseLocation]):
1691         - This works around a crash on an internal build.
1692
1693 2019-03-22  Tim Horton  <timothy_horton@apple.com>
1694
1695         Fix the build after r243354
1696         https://bugs.webkit.org/show_bug.cgi?id=196138
1697         <rdar://problem/49145951>
1698
1699         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1700         (TEST):
1701         * TestWebKitAPI/ios/UIKitSPI.h:
1702
1703 2019-03-21  Tim Horton  <timothy_horton@apple.com>
1704
1705         Adopt UIWKDocumentContext
1706         https://bugs.webkit.org/show_bug.cgi?id=196040
1707         <rdar://problem/48642440>
1708
1709         Reviewed by Ryosuke Niwa.
1710
1711         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1712         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
1713         (makeRequest):
1714         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
1715         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
1716         (applyStyle):
1717         (TEST):
1718         Add tests for UIWKDocumentContext.
1719
1720         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
1721         (TEST):
1722         (recursiveFindWKContentView): Deleted.
1723         * TestWebKitAPI/cocoa/TestWKWebView.h:
1724         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1725         (recursiveFindWKContentView):
1726         (-[TestWKWebView wkContentView]):
1727         * TestWebKitAPI/ios/UIKitSPI.h:
1728         Share the WKContentView finding code between tests.
1729
1730 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
1731
1732         [iOS WK2] Turn on async overflow scrolling by default
1733         https://bugs.webkit.org/show_bug.cgi?id=196011
1734         rdar://problem/48453859
1735
1736         Reviewed by Antti Koivisto.
1737         
1738         Explicitly turn off the async overflow scrolling internal feature for tests by default,
1739         since so many basic layout tests have different results when compositing is triggered for
1740         overflow.
1741         
1742         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
1743
1744         * WebKitTestRunner/TestController.cpp:
1745         (WTR::TestController::resetPreferencesToConsistentValues):
1746
1747 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1748
1749         [ews-build] Retry API test in case of failures
1750         https://bugs.webkit.org/show_bug.cgi?id=196004
1751
1752         Reviewed by Lucas Forschler.
1753
1754         * BuildSlaveSupport/ews-build/steps.py:
1755         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
1756         (CompileWebKitToT.doStepIf): Ditto.
1757         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
1758         (ReRunAPITests): Re-run API tests.
1759         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
1760         (RunAPITestsWithoutPatch): Run API tests without patch.
1761         (RunAPITestsWithoutPatch.doStepIf):
1762         (RunAPITestsWithoutPatch.hideStepIf):
1763         (RunAPITestsWithoutPatch.evaluateCommand):
1764         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
1765         (AnalyzeAPITestsResults.start):
1766         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
1767         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
1768         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
1769         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
1770
1771 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1772
1773         [ews-build] Update queues configurations
1774         https://bugs.webkit.org/show_bug.cgi?id=196074
1775
1776         Reviewed by Dewei Zhu.
1777
1778         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
1779         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
1780
1781 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1782
1783         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
1784         https://bugs.webkit.org/show_bug.cgi?id=195680
1785         <rdar://problem/48903534>
1786
1787         Unreviewed infrastructure fix.
1788
1789         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1790         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
1791
1792 2019-03-21  Andy Estes  <aestes@apple.com>
1793
1794         [iOS] Apple Pay should be available in documents with no user agent scripts
1795         https://bugs.webkit.org/show_bug.cgi?id=196061
1796         <rdar://problem/48649391>
1797
1798         Reviewed by Brady Eidson.
1799
1800         Added API tests and related infrastructure.
1801
1802         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1803         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
1804         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
1805         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
1806         (TestWebKitAPI::TEST):
1807         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
1808         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
1809         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
1810         * TestWebKitAPI/cocoa/TestProtocol.mm:
1811         (-[TestProtocol startLoading]):
1812         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
1813         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
1814         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
1815         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
1816
1817 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
1818
1819         REGRESSSION (r243297): webkitpy tests broken
1820         https://bugs.webkit.org/show_bug.cgi?id=196108
1821
1822         Reviewed by Aakash Jain.
1823
1824         r243297 updated contributors.json, which broke a few unit tests.
1825
1826         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1827         (IRCCommandTest.test_whois):
1828         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
1829
1830 2019-03-21  Chris Dumez  <cdumez@apple.com>
1831
1832         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
1833         https://bugs.webkit.org/show_bug.cgi?id=196041
1834         <rdar://problem/49083230>
1835
1836         Reviewed by Alex Christensen.
1837
1838         Add API test coverage.
1839
1840         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
1841         (TEST):
1842
1843 2019-03-21  Alex Christensen  <achristensen@webkit.org>
1844
1845         Add SPI to inform applications of WKContentRuleList actions
1846         https://bugs.webkit.org/show_bug.cgi?id=195965
1847         <rdar://problem/42664365>
1848
1849         Reviewed by Geoff Garen.
1850
1851         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1852         (TestWebKitAPI::allActionsForResourceLoad):
1853         (TestWebKitAPI::testRequest):
1854         (TestWebKitAPI::TEST_F):
1855         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
1856         (Notification::description):
1857         (Notification::operator== const):
1858         (toVector):
1859         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
1860         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
1861         (makeContentRuleList):
1862         (TEST):
1863         (makeWarnContentRuleList): Deleted.
1864
1865 2019-03-21  Timothy Hatcher  <timothy@apple.com>
1866
1867         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
1868         https://bugs.webkit.org/show_bug.cgi?id=196088
1869
1870         Reviewed by Brian Burg.
1871
1872         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
1873         Support checks when only one platform is specified. Also deprecate macosx() and
1874         force the use of macos() instead.
1875
1876         * Scripts/webkitpy/style/checkers/cpp.py:
1877         (check_min_versions_of_wk_api_available):
1878         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1879         (WebKitStyleTest.test_min_versions_of_wk_api_available):
1880
1881 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
1882
1883         Update status inactive committers' status to 'contributor'.
1884
1885         * Scripts/webkitpy/common/config/contributors.json:
1886
1887 2019-03-21  Xan Lopez  <xan@igalia.com>
1888
1889         [JSC][x86] Drop support for x87 floating point
1890         https://bugs.webkit.org/show_bug.cgi?id=194853
1891
1892         Reviewed by Don Olmstead.
1893
1894         Force SSE2 on x86/32bit builds.
1895
1896         * Scripts/webkitdirs.pm:
1897         (generateBuildSystemFromCMakeProject):
1898
1899 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1900
1901         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
1902         https://bugs.webkit.org/show_bug.cgi?id=196073
1903
1904         Reviewed by Michael Catanzaro.
1905
1906         Add test cases to check functions and constructors with no arguments but receiving user data.
1907
1908         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1909         (checkUserData):
1910         (testJSCFunction):
1911         (fooCreateWithUserData):
1912         (testJSCClass):
1913
1914 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1915
1916         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
1917
1918         Add g_assert_cmpfloat_with_epsilon macro if not defined.
1919
1920         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
1921
1922 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1923
1924         [GTK][WPE] Add API to provide geolocation information
1925         https://bugs.webkit.org/show_bug.cgi?id=195940
1926
1927         Reviewed by Michael Catanzaro.
1928
1929         Add a new test to check the new API.
1930
1931         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
1932         (testGeolocationManagerCurrentPosition):
1933         (testGeolocationManagerWatchPosition):
1934         (beforeAll):
1935         (afterAll):
1936         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
1937         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
1938         (beforeAll): Ditto.
1939         * TestWebKitAPI/glib/CMakeLists.txt:
1940
1941 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1942
1943         [GLib] Returning G_TYPE_OBJECT from a method does not work
1944         https://bugs.webkit.org/show_bug.cgi?id=195574
1945
1946         Reviewed by Michael Catanzaro.
1947
1948         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
1949
1950         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1951         (getGFile):
1952         (getParent):
1953         (createGString):
1954         (getGString):
1955         (getGStringCopyWillRaise):
1956         (getGStringCopy):
1957         (getGStringStr):
1958         (getGStringLen):
1959         (freeGString):
1960         (testJSCClass):
1961
1962 2019-03-20  Saam Barati  <sbarati@apple.com>
1963
1964         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
1965         https://bugs.webkit.org/show_bug.cgi?id=195721
1966
1967         Reviewed by Filip Pizlo.
1968
1969         * Scripts/run-javascriptcore-tests:
1970
1971 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
1972
1973         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
1974         https://bugs.webkit.org/show_bug.cgi?id=196049
1975
1976         Reviewed by Tim Horton.
1977
1978         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
1979         overflow scrolling in general, so rename it.
1980
1981         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1982
1983 2019-03-20  Daniel Bates  <dabates@apple.com>
1984
1985         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
1986         https://bugs.webkit.org/show_bug.cgi?id=196031
1987         <rdar://problem/49078172>
1988
1989         Reviewed by Tim Horton.
1990
1991         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
1992         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
1993         same code path used when the Done button is pressed to dismiss the <select> picker.
1994
1995         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
1996         (TestWebKitAPI::TEST):
1997
1998 2019-03-20  Chris Dumez  <cdumez@apple.com>
1999
2000         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
2001         https://bugs.webkit.org/show_bug.cgi?id=196029
2002         <rdar://problem/48954651>
2003
2004         Reviewed by Tim Horton.
2005
2006         Add API test coverage.
2007
2008         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2009
2010 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
2011
2012         [ews-build] Improve failure summary string for ApplyPatch step
2013         https://bugs.webkit.org/show_bug.cgi?id=195995
2014
2015         Reviewed by Alexey Proskuryakov.
2016
2017         * BuildSlaveSupport/ews-build/steps.py:
2018         (ApplyPatch.getResultSummary): Override getResultSummary.
2019
2020 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
2021
2022         AX: Implement support for new meter ARIA role
2023         https://bugs.webkit.org/show_bug.cgi?id=195966
2024
2025         Reviewed by Chris Fleizach.
2026
2027         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
2028         to AXLevelIndicator.
2029
2030         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2031
2032 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
2033
2034         [WebAuthN] Implement FIDO AppID extension
2035         https://bugs.webkit.org/show_bug.cgi?id=143491
2036         <rdar://problem/48298273>
2037
2038         Reviewed by Brent Fulgham.
2039
2040         Add a test that covers the new flag of convertToU2fSignCommand.
2041
2042         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
2043         (TestWebKitAPI::TEST):
2044         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
2045         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
2046         (TestWebKitAPI::TEST):
2047
2048 2019-03-19  Keith Rollin  <krollin@apple.com>
2049
2050         Add support for more platforms to generate-xcfilelists
2051         https://bugs.webkit.org/show_bug.cgi?id=195977
2052
2053         Reviewed by Alexey Proskuryakov.
2054
2055         generate-xcfilelists incorrectly complains when involved with building
2056         WebKit for iphonesimulator:
2057
2058             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
2059             …
2060             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
2061
2062         Address this by teaching generate-xcfilelists about more platforms.
2063
2064         * Scripts/generate-xcfilelists:
2065
2066 2019-03-19  John Wilander  <wilander@apple.com>
2067
2068         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
2069         https://bugs.webkit.org/show_bug.cgi?id=195923
2070         <rdar://problem/49001272>
2071
2072         Reviewed by Alex Christensen.
2073
2074         This patch does the following to the TestRunner:
2075         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
2076         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
2077         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
2078
2079         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2080         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2081         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
2082         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2083         * WebKitTestRunner/TestController.cpp:
2084         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
2085         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
2086         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
2087         * WebKitTestRunner/TestController.h:
2088         * WebKitTestRunner/TestInvocation.cpp:
2089         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2090
2091 2019-03-19  Christopher Reid  <chris.reid@sony.com>
2092
2093         [CMake] Support more clang and gcc sanitizers
2094         https://bugs.webkit.org/show_bug.cgi?id=195956
2095
2096         Reviewed by Michael Catanzaro.
2097
2098         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
2099
2100 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2101
2102         [ews-build] Improve summary for PrintConfiguration step
2103         https://bugs.webkit.org/show_bug.cgi?id=195945
2104
2105         Reviewed by Lucas Forschler.
2106
2107         * BuildSlaveSupport/ews-build/steps.py:
2108         (PrintConfiguration.getResultSummary): Override getResultSummary.
2109
2110 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2111
2112         [ews-build] Improve summary for CheckOutSource step
2113         https://bugs.webkit.org/show_bug.cgi?id=195963
2114
2115         Reviewed by Lucas Forschler.
2116
2117         * BuildSlaveSupport/ews-build/steps.py:
2118         (CheckOutSource.getResultSummary):
2119
2120 2019-03-19  Daniel Bates  <dabates@apple.com>
2121
2122         [iOS] Focus not preserved when switching between tabs
2123         https://bugs.webkit.org/show_bug.cgi?id=195820
2124         <rdar://problem/43614450>
2125
2126         Reviewed by Brent Fulgham.
2127
2128         Add tests to ensure that we restore focus when resigning and becoming first responder.
2129
2130         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2131         (TestWebKitAPI::TEST):
2132
2133 2019-03-19  Alex Christensen  <achristensen@webkit.org>
2134
2135         Make WTFLogChannelState and WTFLogLevel enum classes
2136         https://bugs.webkit.org/show_bug.cgi?id=195904
2137
2138         Reviewed by Eric Carlson.
2139
2140         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2141         (TestWebKitAPI::TEST_F):
2142
2143 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2144
2145         [GStreamer][EME] Backported mssdemux protection data crash fix
2146         https://bugs.webkit.org/show_bug.cgi?id=195918
2147
2148         Reviewed by Philippe Normand.
2149
2150         * gstreamer/jhbuild.modules:
2151         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
2152
2153 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
2154
2155         Unreviewed, rolling out r243132.
2156
2157         Broke GTK build
2158
2159         Reverted changeset:
2160
2161         "Make WTFLogChannelState and WTFLogLevel enum classes"
2162         https://bugs.webkit.org/show_bug.cgi?id=195904
2163         https://trac.webkit.org/changeset/243132
2164
2165 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
2166
2167         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
2168
2169         * Scripts/webkitdirs.pm:
2170         (builtDylibPathForName): Adjust the shared library name that's changed
2171         with the API version bump in r243073.
2172
2173 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2174
2175         Make WTFLogChannelState and WTFLogLevel enum classes
2176         https://bugs.webkit.org/show_bug.cgi?id=195904
2177
2178         Reviewed by Eric Carlson.
2179
2180         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2181         (TestWebKitAPI::TEST_F):
2182
2183 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2184
2185         Disable flaky test added in r2431100
2186         https://webkit.org/b/195785
2187
2188         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2189         (TestWebKitAPI::TEST):
2190         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
2191
2192 2019-03-18  Timothy Hatcher  <timothy@apple.com>
2193
2194         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
2195         https://bugs.webkit.org/show_bug.cgi?id=195916
2196
2197         Reviewed by Tim Horton.
2198
2199         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2200         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
2201
2202 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
2203
2204         Add a secondary e-mail address for Fujii Hironori to make tools happier.
2205
2206         * Scripts/webkitpy/common/config/contributors.json:
2207
2208 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2209
2210         Implement DownloadMonitor to prevent long-running slow downloads from background apps
2211         https://bugs.webkit.org/show_bug.cgi?id=195785
2212
2213         Reviewed by Geoffrey Garen.
2214
2215         * TestWebKitAPI/TCPServer.cpp: Added.
2216         (TestWebKitAPI::TCPServer::TCPServer):
2217         (TestWebKitAPI::TCPServer::~TCPServer):
2218         (TestWebKitAPI::TCPServer::socketBindListen):
2219         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
2220         * TestWebKitAPI/TCPServer.h: Added.
2221         (TestWebKitAPI::TCPServer::port const):
2222         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2223         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2224         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
2225         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
2226         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2227         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
2228         (TestWebKitAPI::respondSlowly):
2229         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
2230         (TestWebKitAPI::downloadAtRate):
2231         (TestWebKitAPI::TEST):
2232
2233 2019-03-18  Saam Barati  <sbarati@apple.com>
2234
2235         Add a plan file for JetStream 2
2236         https://bugs.webkit.org/show_bug.cgi?id=190734
2237
2238         Reviewed by Mark Lam.
2239
2240         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
2241
2242 2019-03-18  Chris Dumez  <cdumez@apple.com>
2243
2244         Delay WebProcess launch until a load is triggered in a Web view
2245         https://bugs.webkit.org/show_bug.cgi?id=195758
2246         <rdar://problem/48126013>
2247
2248         Reviewed by Geoff Garen.
2249
2250         Add API test coverage. Also update some existing API tests to not expect
2251         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
2252
2253         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
2254         (TestWebKitAPI::TEST):
2255         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
2256         (TestWebKitAPI::TEST):
2257         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2258         (TEST):
2259         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2260         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2261         (TEST):
2262         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2263         (TEST):
2264         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
2265
2266 2019-03-18  Xan Lopez  <xan@igalia.com>
2267
2268         [CMake] Prevent potential warning when determining $architecture
2269         https://bugs.webkit.org/show_bug.cgi?id=195891
2270
2271         Reviewed by Michael Catanzaro.
2272
2273         It's possible for generateBuildSystemForCMakeProject to be called
2274         before determineArchitecture() is ever called. This will make the
2275         first eq check with $architecture to be bogus (and print a
2276         warning). Change that to an eq check with architecture(), which
2277         implicitly calls determineArchitecture() if needed, and change all
2278         the other similar cases in the method in the same way to prevent
2279         future bugs like this one.
2280
2281         * Scripts/webkitdirs.pm:
2282         (generateBuildSystemFromCMakeProject):
2283
2284 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2285
2286         [WPE] Tarballs generated with “make dist” cannot build documentation
2287         https://bugs.webkit.org/show_bug.cgi?id=195885
2288
2289         Reviewed by Carlos Garcia Campos.
2290
2291         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
2292
2293 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2294
2295         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
2296         https://bugs.webkit.org/show_bug.cgi?id=195883
2297
2298         Reviewed by Carlos Garcia Campos.
2299
2300         * gtkdoc/gtkdoc.py:
2301         (GTKDoc._run_command): When commands fail to run, include the full command line for
2302         the program invocation and the output it has generated on the standard error stream.
2303
2304 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2305
2306         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
2307         https://bugs.webkit.org/show_bug.cgi?id=195786
2308
2309         Reviewed by Philippe Normand.
2310
2311         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
2312         * wpe/jhbuild.modules: Ditto.
2313
2314 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
2315
2316         [ews-build] Don't run clean builds on EWS builders
2317         https://bugs.webkit.org/show_bug.cgi?id=195851
2318
2319         Reviewed by Geoffrey Garen.
2320
2321         * BuildSlaveSupport/ews-build/factories.py:
2322
2323 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
2324
2325         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
2326         https://bugs.webkit.org/show_bug.cgi?id=195849
2327
2328         Reviewed by Chris Dumez.
2329
2330         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
2331
2332         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2333         (runWebsiteDataStoreCustomPaths):
2334
2335 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
2336
2337         webkitpy: Upload test results
2338         https://bugs.webkit.org/show_bug.cgi?id=195755
2339         <rdar://problem/48896182>
2340
2341         Reviewed by Aakash Jain.
2342
2343         Establish a new format for uploading results that is not tied to layout tests, apply
2344         that format to webkitpy tests.
2345
2346         * Scripts/webkitpy/common/checkout/scm/git.py:
2347         (Git.native_branch): Return what branch the current checkout is on.
2348         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2349         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2350         * Scripts/webkitpy/common/checkout/scm/svn.py:
2351         (SVN.native_branch): Ditto.
2352         * Scripts/webkitpy/common/system/platforminfo.py:
2353         (PlatformInfo.build_version): Return a build version for Mac.
2354         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2355         (MockPlatformInfo.__init__):
2356         (MockPlatformInfo.build_version):
2357         * Scripts/webkitpy/results: Added.
2358         * Scripts/webkitpy/results/__init__.py: Added.
2359         * Scripts/webkitpy/results/options.py: Added.
2360         (upload_options): OptParse list for upload options.
2361         * Scripts/webkitpy/results/upload.py: Added.
2362         (Upload): Class which enforces the upload format expected by the results server.
2363         (Upload.Expectations):
2364         (Upload.create_configuration):
2365         (Upload.create_commit):
2366         (Upload.create_details):
2367         (Upload.create_run_stats):
2368         (Upload.create_test_result):
2369         (Upload.__init__):
2370         (Upload.Encoder): Encode Upload object as json.
2371         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
2372         * Scripts/webkitpy/results/upload_unittest.py: Added.
2373         * Scripts/webkitpy/test/main.py:
2374         (Tester._parse_args): Add upload arguments.
2375         (Tester._run_tests): Allow results to be uploaded.
2376         * Scripts/webkitpy/test/runner.py:
2377         (Runner.__init__): Record which tests were run, rather than just counting them.
2378         (Runner.handle):
2379         * Scripts/webkitpy/test/runner_unittest.py:
2380         (RunnerTest.test_run):
2381         * Scripts/webkitpy/thirdparty/__init__.py:
2382         (AutoinstallImportHook.find_module): Add requests auto-install.
2383         (AutoinstallImportHook._install_requests):
2384         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2385         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
2386
2387 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2388
2389         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
2390         https://bugs.webkit.org/show_bug.cgi?id=195810
2391
2392         Reviewed by Tim Horton.
2393
2394         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
2395         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
2396         ending certain layout tests.
2397
2398         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2399         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2400         (-[TestRunnerWKWebView dealloc]):
2401         (-[TestRunnerWKWebView resetInteractionCallbacks]):
2402
2403         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
2404         helper method when destroying the web view, and when resetting state between tests.
2405
2406         * WebKitTestRunner/ios/TestControllerIOS.mm:
2407         (WTR::TestController::platformResetStateToConsistentValues):
2408
2409         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
2410
2411 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
2412
2413         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
2414         https://bugs.webkit.org/show_bug.cgi?id=190350
2415         <rdar://problem/45089503>
2416
2417         Reviewed by Geoffrey Garen.
2418
2419         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2420         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
2421         (TEST):
2422         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
2423         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
2424         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
2425         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
2426         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
2427         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
2428         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
2429         (runTest):
2430         (createDirectories):
2431         (TEST):
2432         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
2433         (TEST):
2434         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
2435         (TEST):
2436
2437 2019-03-15  Timothy Hatcher  <timothy@apple.com>
2438
2439         Add support to WebPage for getting the contents as an attributed string.
2440         https://bugs.webkit.org/show_bug.cgi?id=195636
2441         rdar://problem/45055697
2442
2443         Reviewed by Tim Horton.
2444
2445         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2446         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
2447
2448 2019-03-15  Chris Dumez  <cdumez@apple.com>
2449
2450         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2451         https://bugs.webkit.org/show_bug.cgi?id=195747
2452
2453         Reviewed by Geoff Garen.
2454
2455         Add API test coverage.
2456
2457         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2458
2459 2019-03-15  Shawn Roberts  <sroberts@apple.com>
2460
2461         Unreviewed, rolling out r242952.
2462
2463         Causing API failures on iOS Simulator
2464
2465         Reverted changeset:
2466
2467         "[PSON] Make sure the WebProcessCache is leverage when
2468         relaunching a process after termination"
2469         https://bugs.webkit.org/show_bug.cgi?id=195747
2470         https://trac.webkit.org/changeset/242952
2471
2472 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
2473
2474         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
2475         https://bugs.webkit.org/show_bug.cgi?id=195740
2476
2477         Reviewed by Ross Kirsling.
2478
2479         window.open doesn't work for WebKitBrowserWindow because it is not
2480         implemented yet.
2481
2482         1. Implemented createNewPage callback of WKPageUIClient.
2483         2. Changed MainWindow to take a BrowserWindow factory function
2484           instead of BrowserWindowType to be flexible to create
2485           BrowserWindow with extra settings.
2486         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
2487           because it is not relevant with MainWindow anymore.
2488
2489         * MiniBrowser/win/Common.cpp:
2490         (parseCommandLine):
2491         * MiniBrowser/win/Common.h:
2492         (CommandLineOptions::CommandLineOptions):
2493         * MiniBrowser/win/MainWindow.cpp:
2494         (MainWindow::MainWindow):
2495         (MainWindow::create):
2496         (MainWindow::init):
2497         (MainWindow::WndProc):
2498         * MiniBrowser/win/MainWindow.h:
2499         * MiniBrowser/win/PrintWebUIDelegate.cpp:
2500         (PrintWebUIDelegate::createWebViewWithRequest):
2501         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2502         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
2503         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
2504         (WebKitBrowserWindow::updateProxySettings):
2505         (WebKitBrowserWindow::createNewPage):
2506         * MiniBrowser/win/WebKitBrowserWindow.h:
2507         * MiniBrowser/win/WinMain.cpp:
2508         (wWinMain):
2509
2510 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
2511
2512         Make it possible to test scrolling tree layer manipulation more easily
2513         https://bugs.webkit.org/show_bug.cgi?id=195780
2514
2515         Reviewed by Tim Horton.
2516         
2517         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
2518         cuts off communication of scrolling tree scrolls back to the web process
2519         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
2520         allows tests to trigger scrolls which run the scrolling tree layer positioning
2521         logic, but never get another commit from the web process that might mask
2522         scrolling tree bugs.
2523         
2524         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
2525         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
2526         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
2527
2528         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2529         (WTR::UIScriptController::scrollUpdatesDisabled const):
2530         (WTR::UIScriptController::setScrollUpdatesDisabled):
2531         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2532         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2533         (WTR::UIScriptController::scrollUpdatesDisabled const):
2534         (WTR::UIScriptController::setScrollUpdatesDisabled):
2535         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2536         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2537         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2538         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
2539         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
2540         * WebKitTestRunner/ios/TestControllerIOS.mm:
2541         (WTR::TestController::platformResetStateToConsistentValues):
2542         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2543         (WTR::UIScriptController::scrollUpdatesDisabled const):
2544         (WTR::UIScriptController::setScrollUpdatesDisabled):
2545
2546 2019-03-14  Youenn Fablet  <youenn@apple.com>
2547
2548         Move IDB storage in private browsing mode to NetworkProcess
2549         https://bugs.webkit.org/show_bug.cgi?id=195602
2550
2551         Reviewed by Brady Eidson.
2552
2553         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
2554         (TEST):
2555
2556 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2557
2558         [ews-build] Make descriptionDone messages more readable
2559         https://bugs.webkit.org/show_bug.cgi?id=195760
2560
2561         Reviewed by Lucas Forschler.
2562
2563         * BuildSlaveSupport/ews-build/steps.py:
2564         * BuildSlaveSupport/ews-build/steps_unittest.py:
2565
2566 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2567
2568         [ews-build] Generate status-bubble hover-over messages
2569         https://bugs.webkit.org/show_bug.cgi?id=195680
2570
2571         Reviewed by Lucas Forschler.
2572
2573         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2574         (StatusBubble):
2575         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
2576         on hover-over.
2577         (StatusBubble._iso_time):
2578         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
2579         hover-over message.
2580         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
2581
2582 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2583
2584         [ews-app] Gracefully handle the case when state_string is None
2585         https://bugs.webkit.org/show_bug.cgi?id=195753
2586
2587         Reviewed by Lucas Forschler.
2588
2589         * BuildSlaveSupport/ews-app/ews/models/build.py:
2590         * BuildSlaveSupport/ews-app/ews/models/step.py:
2591
2592 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2593
2594         [ews-app] Status bubble display pending for currently running build step
2595         https://bugs.webkit.org/show_bug.cgi?id=195744
2596
2597         Reviewed by Lucas Forschler.
2598
2599         * BuildSlaveSupport/ews-build/events.py:
2600         (Events.stepStarted): If state_string is pending, replace it with step name.
2601
2602 2019-03-14  Chris Dumez  <cdumez@apple.com>
2603
2604         Add WebsitePolicy for the client to specify the device orientation & motion access policy
2605         https://bugs.webkit.org/show_bug.cgi?id=195750
2606
2607         Reviewed by Geoffrey Garen.
2608
2609         Add API test coverage.
2610
2611         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2612         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
2613         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2614         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2615
2616 2019-03-14  Chris Dumez  <cdumez@apple.com>
2617
2618         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2619         https://bugs.webkit.org/show_bug.cgi?id=195747
2620
2621         Reviewed by Geoff Garen.
2622
2623         Add API test coverage.
2624
2625         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2626
2627 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
2628
2629         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
2630         https://bugs.webkit.org/show_bug.cgi?id=195725
2631         <rdar://problem/48545062>
2632
2633         Reviewed by Tim Horton.
2634
2635         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
2636         handler is nil.
2637
2638         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2639         (TestWebKitAPI::TEST):
2640
2641 2019-03-13  Sam Weinig  <sam@webkit.org>
2642
2643         Add utility function to allow easy reverse range-based iteration of a container
2644         https://bugs.webkit.org/show_bug.cgi?id=195542
2645
2646         Reviewed by Antti Koivisto.
2647
2648         * TestWebKitAPI/CMakeLists.txt:
2649         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2650         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
2651         (TestWebKitAPI::TEST):
2652         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
2653
2654 2019-03-13  Chris Dumez  <cdumez@apple.com>
2655
2656         Use a ServiceWorker process per registrable domain
2657         https://bugs.webkit.org/show_bug.cgi?id=195649
2658
2659         Reviewed by Youenn Fablet.
2660
2661         Update API test coverage.
2662
2663         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2664
2665 2019-03-13  Chris Dumez  <cdumez@apple.com>
2666
2667         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
2668         https://bugs.webkit.org/show_bug.cgi?id=195684
2669         <rdar://problem/48294714>
2670
2671         Reviewed by Antti Koivisto.
2672
2673         Add API test coverage.
2674
2675         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2676
2677 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2678
2679         [ews-app] Remove unused patch view
2680         https://bugs.webkit.org/show_bug.cgi?id=195669
2681
2682         Reviewed by Lucas Forschler.
2683
2684         * BuildSlaveSupport/ews-app/ews/urls.py:
2685         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
2686
2687 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2688
2689         [ews-app] Use Buildbot result code variables
2690         https://bugs.webkit.org/show_bug.cgi?id=195668
2691
2692         Reviewed by Alexey Proskuryakov.
2693
2694         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
2695         (Buildbot): Added Buildbot result code variables.
2696         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2697         (StatusBubble._build_bubble): Used Buildbot result code variables.
2698
2699 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
2700
2701         [Flatpak] Expand submodule recursively
2702         https://bugs.webkit.org/show_bug.cgi?id=195672
2703
2704         Building WPE with flatpak was impossible without that as it was raising an exception.
2705         Also update wpebackend-fdo to match what is built in jhbuild
2706
2707         Reviewed by Philippe Normand.
2708
2709         * flatpak/flatpakutils.py:
2710         (expand_submodules_recurse):
2711         (expand_manifest):
2712         * flatpak/org.webkit.WPEModules.yaml:
2713
2714 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2715
2716         [ews-app] status bubble should be hidden for certain builds
2717         https://bugs.webkit.org/show_bug.cgi?id=194597
2718
2719         Reviewed by Dewei Zhu.
2720
2721         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2722         (StatusBubble._build_bubble):
2723         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
2724         because the patch didn't have relevant changes.
2725         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
2726         in production yet.
2727
2728 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
2729
2730         [Win] Fix a slew of simple clang-cl warnings.
2731         https://bugs.webkit.org/show_bug.cgi?id=195652
2732
2733         Reviewed by Don Olmstead.
2734
2735         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2736         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
2737
2738 2019-03-12  Justin Fan  <justin_fan@apple.com>
2739
2740         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
2741         https://bugs.webkit.org/show_bug.cgi?id=195518
2742         <rdar://problem/46322356>
2743
2744         Reviewed by Myles C. Maxfield.
2745
2746         * DumpRenderTree/DerivedSources-input.xcfilelist:
2747         * DumpRenderTree/DerivedSources-output.xcfilelist:
2748
2749 2019-03-12  Commit Queue  <commit-queue@webkit.org>
2750
2751         Unreviewed, rolling out r242825.
2752         https://bugs.webkit.org/show_bug.cgi?id=195648
2753
2754         "Broke webkitpy tests with my change to
2755         lldb_dump_class_layout.py" (Requested by rmorisset on
2756         #webkit).
2757
2758         Reverted changeset:
2759
2760         "Alter Tools/Scripts/dump-class-layout to be able to dump all
2761         classes with suspicious padding"
2762         https://bugs.webkit.org/show_bug.cgi?id=195573
2763         https://trac.webkit.org/changeset/242825
2764
2765 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2766
2767         [ews-build] Show status bubbles while the patch is waiting in queue
2768         https://bugs.webkit.org/show_bug.cgi?id=195618
2769
2770         Reviewed by Lucas Forschler.
2771
2772         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2773         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
2774         enabled in initial deployment.
2775         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
2776         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
2777         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
2778         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
2779         (StatusBubble._build_bubbles_for_patch):
2780
2781 2019-03-12  Robin Morisset  <rmorisset@apple.com>
2782
2783         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
2784         https://bugs.webkit.org/show_bug.cgi?id=195573
2785
2786         Reviewed by Simon Fraser.
2787
2788         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
2789
2790         * Scripts/dump-class-layout:
2791         (main):
2792         * lldb/lldb_dump_class_layout.py:
2793         (ClassLayout.__init__):
2794         (ClassLayout._compute_padding_recursive):
2795         (LLDBDebuggerInstance.dump_layout_for_classname):
2796         (LLDBDebuggerInstance):
2797         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
2798         (LLDBDebuggerInstance.layout_for_classname): Deleted.
2799
2800 2019-03-12  Chris Dumez  <cdumez@apple.com>
2801
2802         Device Orientation access permission should be denied unless explicitly granted by the client
2803         https://bugs.webkit.org/show_bug.cgi?id=195625
2804
2805         Reviewed by Youenn Fablet.
2806
2807         add API test coverage.
2808
2809         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2810         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
2811         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
2812         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
2813         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2814         (runDeviceOrientationTest):
2815         (TEST):
2816         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2817         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2818
2819 2019-03-12  Jer Noble  <jer.noble@apple.com>
2820
2821         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
2822         https://bugs.webkit.org/show_bug.cgi?id=195137
2823         <rdar://problem/48810307>
2824
2825         Reviewed by Eric Carlson.
2826
2827         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
2828         (TestWebKitAPI::TEST):
2829
2830 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2831
2832         [ews-build] Change urls from uat to production
2833         https://bugs.webkit.org/show_bug.cgi?id=195566
2834
2835         Reviewed by Lucas Forschler.
2836
2837         * BuildSlaveSupport/ews-app/ews/config.py:
2838         * BuildSlaveSupport/ews-build/events.py:
2839         * BuildSlaveSupport/ews-build/steps.py:
2840
2841 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2842
2843         [ews-build] change max_builds for local-worker to 1
2844         https://bugs.webkit.org/show_bug.cgi?id=195568
2845
2846         Reviewed by Lucas Forschler.
2847
2848         * BuildSlaveSupport/ews-build/loadConfig.py:
2849
2850 2019-03-12  Tim Horton  <timothy_horton@apple.com>
2851
2852         Fix the build
2853
2854         * TestRunnerShared/spi/PencilKitTestSPI.h:
2855         * TestWebKitAPI/ios/PencilKitTestSPI.h:
2856
2857 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
2858
2859         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
2860         https://bugs.webkit.org/show_bug.cgi?id=194131
2861
2862         Reviewed by Michael Catanzaro.
2863
2864         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
2865         (uriChanged):
2866         (testUnfinishedSubresourceLoad):
2867         (serverCallback):
2868         (beforeAll):
2869
2870 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2871
2872         WTF::Expected should use std::addressof instead of operator&
2873         https://bugs.webkit.org/show_bug.cgi?id=195604
2874
2875         Reviewed by Myles Maxfield.
2876
2877         * TestWebKitAPI/Tests/WTF/Expected.cpp:
2878         (TestWebKitAPI::Unique::Unique):
2879         (TestWebKitAPI::Unique::operator&):
2880         (TestWebKitAPI::TEST):
2881
2882 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
2883
2884         Add Optional to Forward.h.
2885         https://bugs.webkit.org/show_bug.cgi?id=195586
2886
2887         Reviewed by Darin Adler.
2888
2889         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
2890         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
2891         Remove unnecessary includes from headers.
2892
2893 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
2894
2895         Add testing API to hit-test and scroll overflow scrollers
2896         https://bugs.webkit.org/show_bug.cgi?id=195278
2897
2898         Reviewed by Antti Koivisto.
2899         
2900         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
2901         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
2902         
2903         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
2904
2905         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2906         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2907         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2908         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2909         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2910         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2911         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2912         (WTR::enclosingScrollViewIncludingSelf):
2913         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2914
2915 2019-03-11  Tim Horton  <timothy_horton@apple.com>
2916
2917         API test WebKit.RequestTextInputContext fails on iOS
2918         https://bugs.webkit.org/show_bug.cgi?id=195585
2919
2920         Reviewed by Wenson Hsieh and Simon Fraser.
2921
2922         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
2923         (applyStyle):
2924         (TEST):
2925         Add a viewport, so that the coordinates match up on iOS.
2926         Scroll by moving the UIScrollView's contentOffset.
2927
2928 2019-03-11  Chris Dumez  <cdumez@apple.com>
2929
2930         Assert in WebPageProxy::suspendCurrentPageIfPossible()
2931         https://bugs.webkit.org/show_bug.cgi?id=195506
2932         <rdar://problem/48733477>
2933
2934         Reviewed by Alex Christensen.
2935
2936         Add API test coverage.
2937
2938         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2939
2940 2019-03-11  Shawn Roberts  <sroberts@apple.com>
2941
2942         Adding myself to contributors.json
2943
2944         Unreviewed, addming myself to contributors.json .
2945
2946         * Scripts/webkitpy/common/config/contributors.json:
2947
2948 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2949
2950         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
2951         https://bugs.webkit.org/show_bug.cgi?id=195511
2952         <rdar://problem/44873269>
2953
2954         Reviewed by Darin Adler.
2955
2956         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
2957         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
2958         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
2959         (TEST_F):
2960
2961 2019-03-11  Chris Dumez  <cdumez@apple.com>
2962
2963         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
2964         https://bugs.webkit.org/show_bug.cgi?id=195561
2965
2966         Reviewed by Youenn Fablet.
2967
2968         Make sure the JS in the test requests for permission to receive device orientation events.
2969
2970         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2971
2972 2019-03-11  Youenn Fablet  <youenn@apple.com>
2973
2974         Allow storage quota increase by default in WTR
2975         https://bugs.webkit.org/show_bug.cgi?id=195541
2976
2977         Reviewed by Geoffrey Garen.
2978
2979         Allow storage quota increase by default in WTR.
2980         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
2981         Use this for tests that explicitly need cache increase.
2982
2983         Instead of increasing quota by 2, make sure the next request is
2984         granted by adding all given parameters.
2985
2986         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2987         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2988         (WTR::TestRunner::setAllowStorageQuotaIncrease):
2989         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
2990         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2991         * WebKitTestRunner/TestController.cpp:
2992         (WTR::TestController::setAllowStorageQuotaIncrease):
2993         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
2994         * WebKitTestRunner/TestController.h:
2995         * WebKitTestRunner/TestInvocation.cpp:
2996         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2997         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2998         (WTR::TestController::cocoaResetStateToConsistentValues):
2999         (WTR::TestController::setAllowStorageQuotaIncrease):
3000         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
3001         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3002         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3003
3004 2019-03-11  Xan Lopez  <xan@igalia.com>
3005
3006         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
3007         https://bugs.webkit.org/show_bug.cgi?id=194147
3008
3009         Reviewed by Michael Saboff.
3010
3011         To make --32-bit work correctly on Linux/64bit we need to:
3012
3013         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
3014         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
3015         unfortunately CMake only allows us to do this during
3016         crosscompilation, which is overkill here.
3017         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
3018         pkg-config detection module uses the x86 .pc files instead of the
3019         x86_64 ones.
3020         - Set the -m32 flags for the compiler.
3021
3022         * Scripts/webkitdirs.pm:
3023         (generateBuildSystemFromCMakeProject):
3024
3025 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
3026
3027         Add MotionMark-1.1 plan file for run-benchmark script.
3028         https://bugs.webkit.org/show_bug.cgi?id=195481
3029
3030         Rubber-stamped by Darin Adler.
3031
3032         Run-benchmark script should support MontionMark-1.1.
3033
3034         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
3035
3036 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3037
3038         [ews-app] Add support for submit-to-ews url
3039         https://bugs.webkit.org/show_bug.cgi?id=195477
3040
3041         Reviewed by Lucas Forschler.
3042
3043         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3044         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
3045         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
3046         * BuildSlaveSupport/ews-app/ews/urls.py:
3047         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
3048
3049 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
3050
3051         Unreviewed, rolling out r242688, r242643, r242624.
3052
3053         Caused multiple layout test failures and crashes on iOS and macOS.
3054
3055         Reverted changeset:
3056
3057         "requestAnimationFrame should execute before the next frame"
3058         https://bugs.webkit.org/show_bug.cgi?id=177484
3059         https://trac.webkit.org/changeset/242624/webkit
3060
3061         * Tracing/SystemTracePoints.plist:
3062
3063 2019-03-11  John Wilander  <wilander@apple.com>
3064
3065         Resource Load Statistics: Make it possible exclude localhost from classification
3066         https://bugs.webkit.org/show_bug.cgi?id=195474
3067         <rdar://problem/47520577>
3068
3069         Reviewed by Brent Fulgham.
3070
3071         This patch allows for localhost to be excluded from classification and
3072         treatment as a prevalent resource.
3073
3074         The WebKit Tools change adds a new function called
3075         testRunner.setStatisticsIsRunningTest() which can be used to control this
3076         behavior.
3077
3078         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3079         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3080         (WTR::TestRunner::setStatisticsIsRunningTest):
3081         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3082         * WebKitTestRunner/TestController.cpp:
3083         (WTR::TestController::setStatisticsIsRunningTest):
3084         * WebKitTestRunner/TestController.h:
3085         * WebKitTestRunner/TestInvocation.cpp:
3086         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3087
3088 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3089
3090         [ews-build] Disable waterfall and console view for ews-build.webkit.org
3091         https://bugs.webkit.org/show_bug.cgi?id=195560
3092
3093         Reviewed by Lucas Forschler.
3094
3095         * BuildSlaveSupport/ews-build/master.cfg:
3096
3097 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3098
3099         Unreviewed, rolling out r242698.
3100
3101         API test crashes on bots.
3102
3103         Reverted changeset:
3104
3105         "Add a WKContentRuleList variant that uses copied memory
3106         instead of mmap'd shared memory for class A containerized
3107         apps"
3108         https://bugs.webkit.org/show_bug.cgi?id=195511
3109         https://trac.webkit.org/changeset/242698
3110
3111 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
3112
3113         [WPE] Enable web process sandbox
3114         https://bugs.webkit.org/show_bug.cgi?id=195169
3115
3116         Reviewed by Daniel Bates.
3117
3118         * wpe/install-dependencies:
3119         * wpe/jhbuild.modules:
3120
3121 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3122
3123         [ews-app] Use port 17000 for worker communication
3124         https://bugs.webkit.org/show_bug.cgi?id=195558
3125
3126         Reviewed by Lucas Forschler.
3127
3128         * BuildSlaveSupport/ews-build/master.cfg:
3129
3130 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3131
3132         [ews-build] unit-tests fail when passwords.json is missing
3133         https://bugs.webkit.org/show_bug.cgi?id=195557
3134
3135         Reviewed by Lucas Forschler.
3136
3137         * BuildSlaveSupport/ews-build/loadConfig.py:
3138         (loadBuilderConfig):
3139         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
3140         (ConfigDotJSONTest.test_configuration):
3141         * BuildSlaveSupport/ews-build/master.cfg:
3142
3143 2019-03-11  Truitt Savell  <tsavell@apple.com>
3144
3145         Unreviewed, rolling out r242702.
3146
3147         Broke High Sierra builders.
3148
3149         Reverted changeset:
3150
3151         "Add utility function to allow easy reverse range-based
3152         iteration of a container"
3153         https://bugs.webkit.org/show_bug.cgi?id=195542
3154         https://trac.webkit.org/changeset/242702
3155
3156 2019-03-11  Sam Weinig  <sam@webkit.org>
3157
3158         Add utility function to allow easy reverse range-based iteration of a container
3159         https://bugs.webkit.org/show_bug.cgi?id=195542
3160
3161         Reviewed by Antti Koivisto.
3162
3163         * TestWebKitAPI/CMakeLists.txt:
3164         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3165         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
3166         (TestWebKitAPI::TEST):
3167         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
3168
3169 2019-03-10  Alex Christensen  <achristensen@webkit.org>
3170
3171         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
3172         https://bugs.webkit.org/show_bug.cgi?id=195511
3173         <rdar://problem/44873269>
3174
3175         Reviewed by Darin Adler.
3176
3177         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3178         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3179         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3180         (TEST_F):
3181
3182 2019-03-10  Tim Horton  <timothy_horton@apple.com>
3183
3184         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
3185         https://bugs.webkit.org/show_bug.cgi?id=195499
3186
3187         Reviewed by Darin Adler.
3188
3189         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3190         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
3191         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
3192         (-[WKWebView synchronouslyFocusTextInputContext:]):
3193         (applyStyle):
3194         (applyIframe):
3195         (TEST):
3196         Add some tests for this SPI.
3197
3198 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
3199
3200         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
3201         https://bugs.webkit.org/show_bug.cgi?id=181151
3202
3203         Reviewed by Don Olmstead.
3204
3205         * TestWebKitAPI/CMakeLists.txt:
3206         * TestWebKitAPI/PlatformWin.cmake:
3207         Enable TestWTF RunLoop tests in all platforms.
3208
3209         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
3210         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
3211         (TestWebKitAPI::DerivedOneShotTimer::fired):
3212         (TestWebKitAPI::TEST):
3213         Only a few platforms support nested RunLoop.
3214
3215         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
3216         (TestWebKitAPI::DerivedRepeatingTimer::fired):
3217
3218 2019-03-10  David Quesada  <david_quesada@apple.com>
3219
3220         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
3221         https://bugs.webkit.org/show_bug.cgi?id=152480
3222
3223         Reviewed by Chris Dumez.
3224
3225         Add a unit test based on Daniel Bates's test case that starts a download, ensures
3226         there are no additional references to the process pool besides the one held by
3227         the download, waits for the download to finish (in the sense that the
3228         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
3229         measure, also check that the process pool has been deallocated at the end of the
3230         test. The test wouldn't be meaningful if the process pool were still alive.
3231
3232         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3233         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
3234         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
3235             The download will be canceled because the delegate does not implement the
3236             method to decide the download's destination, so this is where we know the
3237             DownloadProxyMap is done with the DownloadProxy.
3238         (TEST):
3239
3240 2019-03-08  Chris Dumez  <cdumez@apple.com>
3241
3242         Add support for Device Orientation / Motion permission API
3243         https://bugs.webkit.org/show_bug.cgi?id=195329
3244         <rdar://problem/47645367>
3245
3246         Reviewed by Geoffrey Garen.
3247
3248         Add test infrastructure to help test the Device Orientation / Motion permission API.
3249
3250         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3251         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3252         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
3253         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3254         * WebKitTestRunner/TestController.cpp:
3255         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
3256         (WTR::TestController::createWebViewWithOptions):
3257         (WTR::TestController::resetStateToConsistentValues):
3258         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
3259         * WebKitTestRunner/TestController.h:
3260         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
3261         * WebKitTestRunner/TestInvocation.cpp:
3262         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3263
3264 2019-03-08  Saam barati  <sbarati@apple.com>
3265
3266         Add a compare-results script to compare benchmark results
3267         https://bugs.webkit.org/show_bug.cgi?id=195486
3268         <rdar://problem/48723397>
3269
3270         Reviewed by Geoffrey Garen.
3271
3272         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
3273         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
3274         to extend it to learn about our other benchmarks.
3275
3276         * Scripts/compare-results: Added.
3277         (readJSONFile):
3278         (detectJetStream2):
3279         (JetStream2Results):
3280         (detectSpeedometer2):
3281         (Speedometer2Results):
3282         (detectPLT5):
3283         (PLT5Results):
3284         (detectBenchmark):
3285         (biggerIsBetter):
3286         (ttest):
3287         (getOptions):
3288         (main):
3289
3290 2019-03-08  Stephanie Lewis  <slewis@apple.com>
3291
3292         Ensure old tab state is cleared between iterations of run-benchmark
3293         https://bugs.webkit.org/show_bug.cgi?id=195393
3294         <rdar://problem/46885583>
3295
3296         Reviewed by Dewei Zhu.
3297
3298         a) ensure the default to restore state is not set
3299         b) terminate Safari correctly
3300         c) Set the system default to ignore Persistent State in Safari
3301
3302         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
3303         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
3304         (OSXBrowserDriver.prepare_env): 
3305         (OSXBrowserDriver.restore_env):
3306         (OSXBrowserDriver.close_browsers):
3307         (OSXBrowserDriver._terminate_processes):
3308         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
3309         (OSXChromeDriver):
3310         (OSXChromeCanaryDriver):
3311         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
3312         (OSXFirefoxDriver):
3313         (OSXFirefoxNightlyDriver):
3314         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
3315         (OSXSafariDriver):
3316         (OSXSafariDriver.prepare_env):
3317
3318 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
3319
3320         [GTK] Several InputMethodFilter tests are failing
3321         https://bugs.webkit.org/show_bug.cgi?id=195408
3322
3323         Reviewed by Carlos Garcia Campos.
3324
3325         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
3326         Regressed in r241751.
3327         Hexadecimal values of keycodes are expressed now in upper letters.
3328         Composited characters should be cast to UTF8 strings.
3329
3330         (TestWebKitAPI::TEST):
3331
3332 2019-03-07  Tomas Popela  <tpopela@redhat.com>
3333
3334         [GTK] Make Tools/gtkdoc python3 compatible
3335         https://bugs.webkit.org/show_bug.cgi?id=195359
3336
3337         Reviewed by Carlos Garcia Campos.
3338
3339         * gtkdoc/generate-gtkdoc:
3340         ConfigParser was reworked in Python 3.2 so we have adapt the code to
3341         work with Python 2 and 3.
3342         (get_gtkdoc_module_paths):
3343         The iteritems() was removed in Python 3, so let's use items() that's
3344         available in Python 2 and 3.
3345         (get_generator_for_config):
3346         * gtkdoc/gtkdoc.py:
3347         (GTKDoc._run_command):
3348         The sys.stdout.write() is expecting str in Python 3 and not bytes
3349         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
3350         for passing the bytes there.
3351
3352 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
3353
3354         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3355         https://bugs.webkit.org/show_bug.cgi?id=195346
3356         <rdar://problem/48667048>
3357
3358         Unreviewed build fix for clang-cl.
3359
3360         * DumpRenderTree/win/DumpRenderTree.cpp:
3361         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
3362
3363 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
3364
3365         requestAnimationFrame should execute before the next frame
3366         https://bugs.webkit.org/show_bug.cgi?id=177484
3367
3368         Reviewed by Simon Fraser.
3369
3370         Add trace points for the page RenderingUpdate.
3371
3372         * Tracing/SystemTracePoints.plist:
3373
3374 2019-03-07  Zalan Bujtas  <zalan@apple.com>
3375
3376         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
3377         https://bugs.webkit.org/show_bug.cgi?id=195353
3378         <rdar://problem/48626394>
3379
3380         Reviewed by Simon Fraser.
3381
3382         * WebKitTestRunner/ios/TestControllerIOS.mm:
3383         (WTR::TestController::platformResetPreferencesToConsistentValues):
3384
3385 2019-03-07  John Wilander  <wilander@apple.com>
3386
3387         Resource Load Statistics: Make it possible to purge only script-accessible cookies
3388         https://bugs.webkit.org/show_bug.cgi?id=195383
3389         <rdar://problem/48570136>
3390
3391         Reviewed by Brent Fulgham.
3392
3393         This patch adds test infrastructure to purge only script-accessible cookies,
3394         including a new testRunner function called statisticsDeleteCookiesForHost().git a
3395
3396         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3397         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3398         (WTR::TestRunner::statisticsDeleteCookiesForHost):
3399         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3400         * WebKitTestRunner/TestController.cpp:
3401         (WTR::TestController::statisticsDeleteCookiesForHost):
3402         * WebKitTestRunner/TestController.h:
3403         * WebKitTestRunner/TestInvocation.cpp:
3404         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3405
3406 2019-03-07  Commit Queue  <commit-queue@webkit.org>
3407
3408         Unreviewed, rolling out r242354.
3409         https://bugs.webkit.org/show_bug.cgi?id=195402
3410
3411         breaks layout tests in all configurations (Requested by
3412         zdobersek on #webkit).
3413
3414         Reverted changeset:
3415
3416         "[WPE] Enable web process sandbox"
3417         https://bugs.webkit.org/show_bug.cgi?id=195169
3418         https://trac.webkit.org/changeset/242354
3419
3420 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
3421
3422         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3423         https://bugs.webkit.org/show_bug.cgi?id=195346
3424
3425         Reviewed by Fujii Hironori.
3426
3427         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
3428         (TestWebKitAPI::TEST):
3429         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
3430
3431         * DumpRenderTree/win/DumpRenderTree.cpp:
3432         (findFontFallback):
3433         (addFontFallbackIfPresent):
3434         (removeFontFallbackIfPresent):
3435         (main):
3436         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3437         (TestWebKitAPI::Util::moduleDirectory):
3438         (TestWebKitAPI::Util::createInjectedBundlePath):
3439         Use wchar helpers as needed.
3440
3441 2019-03-06  Rob Buis  <rbuis@igalia.com>
3442
3443         Consider supporting the `referrerpolicy` attribute.
3444         https://bugs.webkit.org/show_bug.cgi?id=179053
3445
3446         Reviewed by Darin Adler.
3447
3448         Add a runtime flag for referrerpolicy attribute.
3449
3450         * DumpRenderTree/mac/DumpRenderTree.mm:
3451         (enableExperimentalFeatures):
3452
3453 2019-03-05  Daniel Bates  <dabates@apple.com>
3454
3455         Update expected API test result following r242379
3456         (https://bugs.webkit.org/show_bug.cgi?id=195125)
3457
3458         Update expected x-coordinate of selection rect now that the left padding of
3459         a textarea is sized in ems (so dependent on the font size) just like the left
3460         padding of a text field.
3461
3462         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3463         (TestWebKitAPI::TEST):
3464
3465 2019-03-05  David Quesada  <david_quesada@apple.com>
3466
3467         [WK2] It should be possible to follow links with 'download' attributes
3468         https://bugs.webkit.org/show_bug.cgi?id=195145
3469         rdar://problem/48462642
3470
3471         Reviewed by Alex Christensen.
3472
3473         Add a unit test to verify that activating links with 'download' attributes now
3474         navigates to the linked resource, rather than starts downloading it. Add another
3475         to verify that it is still possible to explicitly download the link via the
3476         'Download' navigation action policy.
3477
3478         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3479         (-[DownloadAttributeTestDelegate init]):
3480         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
3481         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
3482         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
3483         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
3484         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3485         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
3486         (TEST):
3487         * WebKitTestRunner/TestController.cpp:
3488         (WTR::TestController::decidePolicyForNavigationAction):
3489         * WebKitTestRunner/TestController.h:
3490
3491 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
3492
3493         [Curl] Implement Cookie Accept Policy.
3494         https://bugs.webkit.org/show_bug.cgi?id=191645
3495
3496         Reviewed by Fujii Hironori.
3497
3498         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
3499         (TestWebKitAPI::Curl::TEST_F):
3500
3501 2019-03-05  Youenn Fablet  <youenn@apple.com>
3502
3503         Rename requestCacheStorageSpace to requestStorageSpace
3504         https://bugs.webkit.org/show_bug.cgi?id=195282
3505
3506         Reviewed by Chris Dumez.
3507
3508         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3509         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3510         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
3511
3512 2019-03-05  Brady Eidson  <beidson@apple.com>
3513
3514         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
3515         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
3516
3517         Reviewed by Tim Horton.
3518
3519         Loading a file: URL into a WKWebView and then loading another file: url from a completely
3520         different directory into that same WKWebView should work.
3521
3522         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3523         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
3524
3525 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
3526
3527         Add WeakHashSet
3528         https://bugs.webkit.org/show_bug.cgi?id=195152
3529
3530         Reviewed by Antti Koivisto.
3531
3532         Added tests for WeakHashSet.
3533
3534         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3535         (TestWebKitAPI::Base::Base): Moved.
3536         (TestWebKitAPI::Derived::foo): Moved.
3537         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
3538         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
3539         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
3540         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
3541
3542 2019-03-04  Chris Dumez  <cdumez@apple.com>
3543
3544         Do not share WebProcesses between private and regular sessions
3545         https://bugs.webkit.org/show_bug.cgi?id=195189
3546         <rdar://problem/48421064>
3547
3548         Reviewed by Alex Christensen.
3549
3550         Add API test coverage.
3551
3552         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3553         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3554
3555 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
3556
3557         [WPE] Enable web process sandbox
3558         https://bugs.webkit.org/show_bug.cgi?id=195169
3559
3560         Reviewed by Daniel Bates.
3561
3562         * wpe/install-dependencies:
3563         * wpe/jhbuild.modules:
3564
3565 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
3566
3567         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
3568         https://bugs.webkit.org/show_bug.cgi?id=195206
3569
3570         Reviewed by Žan Doberšek.
3571
3572         Add a new test case.
3573
3574         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3575         (testJSCClass):
3576
3577 2019-03-04  Charlie Turner  <cturner@igalia.com>
3578
3579         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
3580         https://bugs.webkit.org/show_bug.cgi?id=194898
3581
3582         Reviewed by Žan Doberšek.
3583
3584         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
3585         a GCC extension that permits arithmetic on void* pointer. Inline
3586         the macro until this issue is fixed upstream.
3587
3588 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3589
3590         Rid the world of WK_API_ENABLED
3591         https://bugs.webkit.org/show_bug.cgi?id=195263
3592
3593         Reviewed by Dan Bernstein.
3594
3595         List of changed files elided because it's useless.
3596
3597 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
3598
3599         Unreviewed follow-up to r242292.
3600
3601         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
3602
3603         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3604         (TestWebKitAPI::testStrip): Renamed from strip.
3605         (TestWebKitAPI::TEST):
3606
3607 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3608
3609         Unreviewed, remove accidentally-committed URLHelpers.cpp test
3610
3611         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
3612         and bug #194272 for details.
3613
3614         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
3615
3616 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3617
3618         Remove some more unused 32-bit code
3619         https://bugs.webkit.org/show_bug.cgi?id=195255
3620
3621         Reviewed by Darin Adler.
3622
3623         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3624         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
3625         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3626         (NPP_New):
3627         (NPP_HandleEvent):
3628         (handleEventCarbon): Deleted.
3629
3630 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
3631
3632         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
3633
3634         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3635         (TestWebKitAPI::TEST):
3636
3637 2019-03-01  Darin Adler  <darin@apple.com>
3638
3639         Finish removing String::format
3640         https://bugs.webkit.org/show_bug.cgi?id=194893
3641
3642         Reviewed by Daniel Bates.
3643 '
3644         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
3645
3646 2019-03-01  Alex Christensen  <achristensen@webkit.org>
3647
3648         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
3649         https://bugs.webkit.org/show_bug.cgi?id=195229
3650         <rdar://problem/48520362>
3651
3652         Reviewed by Chris Dumez.
3653
3654         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3655         (TEST):
3656
3657 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
3658
3659         Add a system trace scope for event region building
3660         https://bugs.webkit.org/show_bug.cgi?id=195226
3661
3662         Reviewed by Jon Lee.
3663
3664         This trace scope measures the time spend converting element rects into Region objects,
3665         which can be large on some pages.
3666
3667         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
3668
3669         * Tracing/SystemTracePoints.plist:
3670
3671 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
3672
3673         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
3674         https://bugs.webkit.org/show_bug.cgi?id=194612
3675
3676         Reviewed by Alex Christensen.
3677
3678         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3679         Just test the new string-processing function and don't touch the actual environment.
3680         (Test cases are all as before, but based on operator== instead of strcmp.)
3681
3682 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
3683
3684         [ews-app] Update primary keys for handling multiple Buildbot instances
3685         https://bugs.webkit.org/show_bug.cgi?id=195120
3686
3687         Reviewed by Stephanie Lewis.
3688
3689         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
3690         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
3691         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
3692
3693         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
3694         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
3695         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
3696         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
3697         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
3698         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
3699
3700 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
3701
3702         [WinCairo] Enable service worker
3703         https://bugs.webkit.org/show_bug.cgi?id=188318
3704
3705         Reviewed by Youenn Fablet.
3706
3707         * DumpRenderTree/DumpRenderTreePrefix.h: